Timeline



Nov 11, 2012:

11:49 PM Changeset in webkit [134193] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Fix assertion failure in JSObject::tryGetIndexQuickly()
https://bugs.webkit.org/show_bug.cgi?id=101869

Patch by Michael Pruett <michael@68k.org> on 2012-11-11
Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Currently JSObject::tryGetIndexQuickly() triggers an assertion
failure when the object has an undecided indexing type. This
case should be treated the same as a blank indexing type.

  • runtime/JSObject.h:

(JSC::JSObject::tryGetIndexQuickly):

LayoutTests:

Add test case for an assertion failure triggered when constructing
a Blob with a sparse array.

  • fast/constructors/blob-sparse-array-assertion-failure.html: Added.
11:24 PM Changeset in webkit [134192] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Change build congratulation message in EFL
https://bugs.webkit.org/show_bug.cgi?id=101833

Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-11
Reviewed by Gyuyoung Kim.

EFL port is currently supporting both WK1 and WK2.
But, build congratulation message still shows WK1(EWebLauncher) only.
Therefore, this patch adopts WK2 reference execution(MiniBrowser) in its message.

From 'To run EWebLauncher with this newly-built code, use the'
to 'To run EWebLauncher/MiniBrowser with this newly-built code, use the'.

  • Scripts/build-webkit:

(writeCongrats):

  • Scripts/webkitdirs.pm:

(launcherName):

11:09 PM Changeset in webkit [134191] by rniwa@webkit.org
  • 6 edits in trunk

Multiple Layout Tests (e.g. fast/repaint/japanese-rl-selection-clear.html) is failing after r133840.
https://bugs.webkit.org/show_bug.cgi?id=101547

Reviewed by Simon Fraser.

Source/WebCore:

I overlooked the fact when the selection is null, we still have to invalidate the caret rect that
previously existed. Revert the optimization added in r133840 to skip caret invalidation when new
selection is null, and add a special method to be called by FrameLoader prior to destruction instead.
This will let us avoid doing an extra layout upon destruction and not regress repaint tests.

Covered by existing tests.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelection): Added DoNotUpdateAppearance option.
(WebCore::FrameSelection::prepareForDestruction): Added.
(WebCore::FrameSelection::updateAppearance): Reverted the flawed optimization added in r133840.
Also, don't update style before updating selection unless text caret is disabled since we always
update the layout (including style) when text caret is enabled.

  • editing/FrameSelection.h:

(FrameSelection):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::clear): Call prepareForDestruction instead of clear to avoid a layout.

LayoutTests:

Remove Chromium test expectations as these tests now pass.

  • platform/chromium/TestExpectations:
10:37 PM Changeset in webkit [134190] by commit-queue@webkit.org
  • 19 edits
    9 adds in trunk

[CSS3] Parsing the property, text-align-last.
https://bugs.webkit.org/show_bug.cgi?id=99439

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-11-11
Reviewed by Julien Chaffraix.

This patch implements the parsing side of the "text-align-last" property specified
in CSS3 working draft, with "-webkit-" prefix, under ENABLE_CSS3_TEXT flag.
Specification link : http://www.w3.org/TR/css3-text/#text-align-last

Source/WebCore:

Tests: fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited.html

fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Get the value of the text-align-last property.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Parse the value, and check whether it is a proper value which text-align-last can have.

  • css/CSSPrimitiveValueMappings.h:

(WebCore):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ETextAlignLast):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in: Add '-webkit-text-align-last' property.
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • css/StylePropertySet.cpp:

(WebCore):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

(StyleRareInheritedData): Add m_textAlignLast.

LayoutTests:

  • fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited.html: Added.
  • fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last.html: Added.
  • fast/css3-text/css3-text-align-last/getComputedStyle/script-tests/getComputedStyle-text-align-last-inherited.js: Added.

(testComputedStyle):

  • fast/css3-text/css3-text-align-last/getComputedStyle/script-tests/getComputedStyle-text-align-last.js: Added.

(testElementStyle):
(testComputedStyle):

  • platform/chromium/TestExpectations:
  • fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-expected.txt: Added.
  • fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited-expected.txt: Added.
  • platform/mac/TestExpectations:
  • platform/qt-4.8/TestExpectations:
  • platform/qt-mac/TestExpectations:
  • platform/qt/TestExpectations:
10:35 PM Changeset in webkit [134189] by shinyak@chromium.org
  • 2 edits in trunk/Source/WebCore

[Refactoring] Remove shadowPseudoId() and use setPseudo() in HTMLKeygenElement
https://bugs.webkit.org/show_bug.cgi?id=101881

Reviewed by Kent Tamura.

We're migrating shadowPseudoId() to pseudo(). We remove shadowPseudoId() from HTMLKeygenElement and use
setPseudo()/pseudo() instead.

No new tests, simple refacotring.

  • html/HTMLKeygenElement.cpp:

(WebCore::KeygenSelectElement::KeygenSelectElement):
(KeygenSelectElement):

9:30 PM Changeset in webkit [134188] by abarth@webkit.org
  • 8 edits in trunk/Source/WebCore

Many DOMWindowProperties would benefit from being ScriptWrappable
https://bugs.webkit.org/show_bug.cgi?id=101887

Reviewed by Kentaro Hara.

These object are only ever created at the behest of script, which means
making them ScriptWrappable is a win.

  • page/BarInfo.h:
  • page/Console.h:
  • page/Crypto.h:
  • page/History.h:
  • page/Location.h:
  • page/Navigator.h:
  • page/Performance.h:
9:04 PM Changeset in webkit [134187] by keishi@webkit.org
  • 48 edits in trunk/LayoutTests

Rebaseline month/week appearance tests
https://bugs.webkit.org/show_bug.cgi?id=101561

Unreviewed.

Rebaselining month/week appearance tests.

  • platform/chromium-linux/fast/forms/month/month-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/month/month-appearance-l10n-expected.png:
  • platform/chromium-linux/fast/forms/month/month-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/month/month-appearance-pseudo-elements-expected.png:
  • platform/chromium-linux/fast/forms/month/month-appearance-style-expected.png:
  • platform/chromium-linux/fast/forms/week/week-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/week/week-appearance-pseudo-classes-expected.png:
  • platform/chromium-linux/fast/forms/week/week-appearance-pseudo-elements-expected.png:
  • platform/chromium-linux/fast/forms/week/week-appearance-style-expected.png:
  • platform/chromium-mac-lion/fast/forms/month/month-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/month/month-appearance-l10n-expected.png:
  • platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-lion/fast/forms/month/month-appearance-style-expected.png:
  • platform/chromium-mac-lion/fast/forms/week/week-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-lion/fast/forms/week/week-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-l10n-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-style-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/month/month-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/month/month-appearance-l10n-expected.png:
  • platform/chromium-mac/fast/forms/month/month-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/month/month-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/month/month-appearance-style-expected.png:
  • platform/chromium-mac/fast/forms/week/week-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/week/week-appearance-pseudo-classes-expected.png:
  • platform/chromium-mac/fast/forms/week/week-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/week/week-appearance-style-expected.png:
  • platform/chromium-win-xp/fast/forms/month/month-appearance-l10n-expected.png:
  • platform/chromium-win/fast/forms/month/month-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/month/month-appearance-l10n-expected.png:
  • platform/chromium-win/fast/forms/month/month-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/month/month-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/month/month-appearance-style-expected.png:
  • platform/chromium-win/fast/forms/week/week-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/week/week-appearance-pseudo-classes-expected.png:
  • platform/chromium-win/fast/forms/week/week-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/week/week-appearance-style-expected.png:
  • platform/chromium/TestExpectations:
8:42 PM Changeset in webkit [134186] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] HTMLDocument::all() needs not to be custom
https://bugs.webkit.org/show_bug.cgi?id=101875

Reviewed by Adam Barth.

We can easily remove the custom getter from V8 because the
custom setter sets .all by ForceSet(). On the other hand,
it is non-trivial to remove the custom getter from JSC
because the custom setter sets .all by putDirect()
and the custom getter wants to get it by getDirect().

No tests. No change in behavior.

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • html/HTMLDocument.idl:
8:29 PM Changeset in webkit [134185] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] V8Console::memoryAttrGetter() needs not to be custom
https://bugs.webkit.org/show_bug.cgi?id=101873

Reviewed by Adam Barth.

No tests. No change in behavior.

  • bindings/v8/custom/V8ConsoleCustom.cpp:

(WebCore):

  • page/Console.idl:
7:40 PM Changeset in webkit [134184] by shinyak@chromium.org
  • 15 edits
    2 adds in trunk

[Shadow] ElementShadow should have RuleFeatureSet for select attribute selectors.
https://bugs.webkit.org/show_bug.cgi?id=101180

Reviewed by Dimitri Glazkov.

.:

Exposes necessary symbols.

  • Source/autotools/symbols.filter:

Source/WebCore:

This is a preparation patch for Bug 100451.

We preserve RuleFeatureSet collected from select attributes in ShadowDOM.
When an element attribute is changed, we might have to invalidate content distribution,
however it's high cost operation. So we would like to check RuleFeatureSet used in
select attributes to determine we really need to invalidate distribution.

Like StyleResolver, ElementShadow has several rule features. When nested ShadowDOM is used,
first we collect features in nested ShadowDOM, and merge it to the parent ShadowDOM.
For the performance reason, we have a flag to check whether we need to collect features again.

Test: fast/dom/shadow/shadow-select-attribute-featureset.html

  • WebCore.exp.in:
  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::ElementShadow):
(WebCore::ElementShadow::setShouldCollectSelectFeatureSet): Enable a flag to collect feature set of descendant
nodes (and their ShadowDOM).
(WebCore):
(WebCore::ElementShadow::ensureSelectFeatureSetCollected):
(WebCore::ElementShadow::collectSelectFeatureSetFrom): Collect RuleFeatureSet from all descendant Nodes and their
ShadowDOM. We need to collect id, class, and attribute names.

  • dom/ElementShadow.h:

(WebCore::ElementShadow::shouldCollectSelectFeatureSet):
(ElementShadow):
(WebCore::ElementShadow::hasSelectorForId):
(WebCore):
(WebCore::ElementShadow::hasSelectorForClass):
(WebCore::ElementShadow::hasSelectorForAttribute):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::parseAttribute): When select attribute is changed, enable a flag to recollect features.
(WebCore::HTMLContentElement::insertedInto): We have to recollect features when HTMLContentElement is moved.
(WebCore::HTMLContentElement::removedFrom): ditto.

  • html/shadow/HTMLContentElement.h:

(WebCore::toHTMLContentElement):
(WebCore):

  • testing/Internals.cpp:

(WebCore::Internals::hasSelectorForIdInShadow):
(WebCore):
(WebCore::Internals::hasSelectorForClassInShadow):
(WebCore::Internals::hasSelectorForAttributeInShadow):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • fast/dom/shadow/shadow-select-attribute-featureset-expected.txt: Added.
  • fast/dom/shadow/shadow-select-attribute-featureset.html: Added.
6:57 PM WikiStart edited by jamesr@google.com
(diff)
6:27 PM Changeset in webkit [134183] by commit-queue@webkit.org
  • 13 edits
    2 deletes in trunk

Unreviewed, rolling out r134144.
http://trac.webkit.org/changeset/134144
https://bugs.webkit.org/show_bug.cgi?id=101876

seems to break win 7 chromium browser test (Requested by
hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-11

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • page/EventHandler.cpp:

(WebCore):
(WebCore::EventHandler::handleMouseMoveEvent):

  • page/EventHandler.h:

(EventHandler):

  • testing/Internals.cpp:
  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • fast/events/mouse-cursor-expected.txt: Removed.
  • fast/events/mouse-cursor.html: Removed.
6:08 PM Changeset in webkit [134182] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG register allocation should be greedy rather than round-robin
https://bugs.webkit.org/show_bug.cgi?id=101870

Reviewed by Geoffrey Garen.

This simplifies the code, reduces some code duplication, and shows some slight
performance improvements in a few places, likely due to the fact that lower-numered
registers also typically have smaller encodings.

  • dfg/DFGRegisterBank.h:

(JSC::DFG::RegisterBank::RegisterBank):
(JSC::DFG::RegisterBank::tryAllocate):
(JSC::DFG::RegisterBank::allocate):
(JSC::DFG::RegisterBank::allocateInternal):
(RegisterBank):

5:41 PM Changeset in webkit [134181] by tkent@chromium.org
  • 1 edit
    2 copies in branches/chromium/1312

Merge 133860 - User can change a disabled select (drop down box)
https://bugs.webkit.org/show_bug.cgi?id=100932

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-08
Reviewed by Kent Tamura.

Source/WebCore:

<select> should not handle events if it's disabled.

Test: fast/forms/select/select-disabled.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::defaultEventHandler):

LayoutTests:

Verify that keyboard events do not change value of disabled select.

  • fast/forms/select/select-disabled-expected.txt: Added.
  • fast/forms/select/select-disabled.html: Added.

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11363189

5:40 PM Changeset in webkit [134180] by tkent@chromium.org
  • 17 edits in trunk

Internals: MockPagePopup should not update DOM structure during detach()
https://bugs.webkit.org/show_bug.cgi?id=101710

Reviewed by Hajime Morita.

Source/WebCore:

PickerIndicatorElement::detach calls
MockPagePopupDriver::closePagePopup, MockPagePopup::~MockPagePopup,
which remove the mock iframe from the tree. But updating the tree during
detach() is dangerous.

MockPagePopupDriver::closePagePopup calls MockpagePopup::closeLater, it
requests to call 'close' asynchronously, and 'close' removes the mock
iframe. We need to change MockPagePopup so that it is ref-couted and has
a timer.

No new tests. This is a change for the test harness.

  • testing/MockPagePopupDriver.cpp:

(MockPagePopup): Make this ref-counted, add closeLater, add close, and
add m_closeTimer.
(WebCore::MockPagePopup::MockPagePopup): Initialize the timer.
(WebCore::MockPagePopup::create): PassOwnPtr -> PassRefPtr
(WebCore::MockPagePopup::closeLater):

  • Add one reference to avoid destruction by m_mockPagePopup.clear() in closePagePopup.
  • Notify didClosePopup here because the client expects didClosePopup is called synchronously.
  • Invoke the timer to call 'close'

(WebCore::MockPagePopup::close):
Just remove one reference. This means calling the desructor.
(WebCore::MockPagePopup::~MockPagePopup):
Move didClosePopup call to caloseLater.
(WebCore::MockPagePopupDriver::closePagePopup):
Request to close PagePopup.
Clear PagePopupClient in m_pagePopupController because this object is
necessary until MockPagePopup is closed, but it should not have a
reference to the PagePopupClient.

  • testing/MockPagePopupDriver.h:

(MockPagePopupDriver): Make MockPagePopup ref-counted.

LayoutTests:

Update tests because page popup closing becomes asynchronous.

  • fast/forms/resources/picker-common.js:

(waitUntilClosing): Added. Helper to wait until a page popup closing.

  • platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-pre-100-year.html:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-type-change-onchange.html:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-with-step.html:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations.html:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-reset-value-after-reload.html:
  • platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute.html:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-key-operations.html:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations.html:
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-step-attribute.html:
5:35 PM Changeset in webkit [134179] by staikos@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] The QNX extension method should not be enabled by default
https://bugs.webkit.org/show_bug.cgi?id=101863

Reviewed by Rob Buis.

Simply change the default to false.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):

4:29 PM Changeset in webkit [134178] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

axObjectCache code is more complicated than necessary
https://bugs.webkit.org/show_bug.cgi?id=101820

Reviewed by Darin Adler.

This code should use OwnPtr rather than manually calling new/delete.
Also, instead of using a "double check" pattern, we can just access the
private fields on the top document directly.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::clearAXObjectCache):
(WebCore::Document::axObjectCacheExists):
(WebCore):
(WebCore::Document::axObjectCache):

  • dom/Document.h:

(Document):

4:12 PM Changeset in webkit [134177] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebKit/chromium

[chromium] Expose CustomEvent through WebDOMCustomEvent.
https://bugs.webkit.org/show_bug.cgi?id=101293

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-11-11
Reviewed by Adam Barth.

  • WebKit.gyp:
  • public/WebDOMCustomEvent.h: Added.

(WebKit):
(WebDOMCustomEvent):
(WebKit::WebDOMCustomEvent::WebDOMCustomEvent):

  • src/WebDOMCustomEvent.cpp: Added.

(WebKit):
(WebKit::WebDOMCustomEvent::initCustomEvent):

3:54 PM Changeset in webkit [134176] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[WK2] Mark fast/repaint/body-background-image.html as flaky.

  • platform/wk2/TestExpectations:
3:51 PM Changeset in webkit [134175] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Replace the pixel expectation for
fast/repaint/body-background-image.html with the one generated by the
WK1 port, since WK2 fails to render it properly at times (see bug
101773).

  • platform/efl/fast/repaint/body-background-image-expected.png:
8:58 AM Changeset in webkit [134174] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Save one call to containerForRepaint() when updating layer positions
https://bugs.webkit.org/show_bug.cgi?id=101856

Reviewed by Dan Bernstein.

RenderLayer::updateLayerPositions() has already computed the repaint container,
but calls computeRepaintRects() which computes it again. Computing the repaint
container involves a walk back up the layer tree, so calling it during a tree
traversal is costly.

Fix by passing the repaint container down into computeRepaintRects().

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::computeRepaintRects):
(WebCore::RenderLayer::computeRepaintRectsIncludingDescendants):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
(WebCore::RenderLayer::setHasVisibleContent):

  • rendering/RenderLayer.h:

(RenderLayer):

6:17 AM Changeset in webkit [134173] by bashi@chromium.org
  • 15 edits in trunk/Source

WTFString::utf8() should have a mode of conversion to use replacement character
https://bugs.webkit.org/show_bug.cgi?id=101678

Source/JavaScriptCore:

Reviewed by Alexey Proskuryakov.

Follow the change on String::utf8()

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode): Pass String::StrictConversion instead of true to String::utf8().

Source/WebCore:

Reviewed by Alexey Proskuryakov.

Follow the change on String::utf8()

No new tests. No changes in behavior.

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::close): Pass String::StrictConversion instead of true to String::utf8().

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send): Ditto.

  • html/MediaFragmentURIParser.cpp:

(WebCore::MediaFragmentURIParser::parseFragments): Ditto.

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::notifyChallengeResult): Ditto.

  • platform/network/blackberry/rss/RSSFilterStream.cpp:

(WebCore::RSSFilterStream::convertContentToHtml): Ditto.

  • platform/network/blackberry/rss/RSSGenerator.cpp:

(WebCore::RSSGenerator::generateHtml): Ditto.

Source/WebKit2:

Reviewed by Alexey Proskuryakov.

Update the symbol for String::utf8().

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

Source/WTF:

Reviewed by Alexander Pavlov.

Introduce conversion mode to String::utf8().
There are three conversion modes; lenient mode, strict mode, and
"replacing unpaired surrogates with the replacement character" (replacement) mode.
Lenient mode converts unpaired surrogates. Strict mode fails when there is an unpaired
surrogates and returns CString(). Replacement mode replaces unpaired surrogates with
the replacement character(U+FFFD). Replacement mode implements the algorithm defined at
http://dev.w3.org/2006/webapi/WebIDL/#dfn-obtain-unicode. WebSocket::send() requires
this algorithm to encode a string to utf-8.

  • wtf/text/WTFString.cpp:

(WTF::String::utf8): Changed to take ConversionMode as the argument.

  • wtf/text/WTFString.h:

(String):

5:12 AM Changeset in webkit [134172] by bashi@chromium.org
  • 2 edits
    2 copies in branches/chromium/1312

Merge 133983 - [Chromium] Arabic digits should appear left-to-right
https://bugs.webkit.org/show_bug.cgi?id=101440

Reviewed by Tony Chang.

Source/WebCore:

Call hb_buffer_set_direction() to set direction when drawing glyphs or
direction should be overridden. Leave direction setting to HarfBuzz when
WebKit is calculating widths because the direction is LTR by default while
calculating widths. Set script before shaping so that HarfBuzz can estimate
appropriate direction.

Test: fast/text/international/arabic-digits.html

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::HarfBuzzRun::HarfBuzzRun):
Add m_script. This holds the script of the run.
(WebCore::HarfBuzzShaper::shape):
Tell shapeHarfBuzzRuns() to set direction when drawing glyphs or
direction should be overridden.
(WebCore::HarfBuzzShaper::collectHarfBuzzRuns):
Set script of HarfBuzzRuns.
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):
Add an argument that indicates it should set direction.

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:

(WebCore::HarfBuzzShaper::HarfBuzzRun::create):
(WebCore::HarfBuzzShaper::HarfBuzzRun::rtl):
(WebCore::HarfBuzzShaper::HarfBuzzRun::script):
(HarfBuzzRun):
(HarfBuzzShaper):

LayoutTests:

Add a test that checks Arabic digits appear in increasing order from left to right.

  • fast/text/international/arabic-digits-expected.html: Added.
  • fast/text/international/arabic-digits.html: Added.

TBR=bashi@chromium.org
Review URL: https://codereview.chromium.org/11293219

4:59 AM Changeset in webkit [134171] by bashi@chromium.org
  • 1 edit
    2 copies in branches/chromium/1312

Merge 133550 - [Chromium] Unicode combining diacritical aren't always combined on Linux
https://bugs.webkit.org/show_bug.cgi?id=101009

Reviewed by Kent Tamura.

Source/WebCore:

Add a space character to harfbuzzBuffer as pre-context. This will prevent
harfbuzz from inserting dotted-circle.

Test: fast/text/international/combining-marks-position.html

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):

LayoutTests:

Add a test that checks whether combining marks are combined with base characters.

  • fast/text/international/combining-marks-position-expected.txt: Added.
  • fast/text/international/combining-marks-position.html: Added.

TBR=bashi@chromium.org
Review URL: https://codereview.chromium.org/11365191

Nov 10, 2012:

10:39 PM Changeset in webkit [134170] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

Coalesce main thread scroll position updates
https://bugs.webkit.org/show_bug.cgi?id=101855

Reviewed by Anders Carlsson.

When using threaded scrolling, the dispatched updateMainFrameScrollPosition() calls
from ScrollingTree would pile up on the main thread, and we'd handle several per
runloop cycle when scrolling fast. This causes extra work especially on pages
with position:fixed elements which must update RenderLayers on scrolling.

Fix by using a zero-delay timer in ScrollingCoordinator to coalesce these
scrolling updates to one per runloop.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::ScrollingCoordinator): Initialized data members
for the scheduled scroll position update.
(WebCore::ScrollingCoordinator::scheduleUpdateMainFrameScrollPosition): If
the timer is active and the parameters match, just update the target scroll
position and return. If the params don't match, dispatch the scheduled update,
and then the new one. Otherwise, prime the timer.
(WebCore::ScrollingCoordinator::updateMainFrameScrollPositionTimerFired): Call
the existing updateMainFrameScrollPosition() with the saved values.

  • page/scrolling/ScrollingCoordinator.h:
  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateMainFrameScrollPosition): Call scheduleUpdateMainFrameScrollPosition()
rather than updateMainFrameScrollPosition().

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::syncChildPositions): Fixed a bug that caused fixed
position elements to jiggle with the patch; we should be calling syncPosition() (which just
sets the position data, without touching CA layers).

9:21 PM Changeset in webkit [134169] by Simon Fraser
  • 8 edits in trunk/Source/WebCore

Remove ScrollingCoordinatorMac::updateMainFrameScrollPositionAndScrollLayerPosition()
https://bugs.webkit.org/show_bug.cgi?id=101514

Reviewed by Tim Horton.

ScrollingCoordinatorMac::updateMainFrameScrollPositionAndScrollLayerPosition() is very similar to
ScrollingCoordinator::updateMainFrameScrollPosition(). In order to eliminate updateMainFrameScrollPositionAndScrollLayerPosition(),
we just need to plumb through a flag that says that updateMainFrameScrollPosition() should
set the layer position (rather than just doing a 'sync').

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):

  • page/scrolling/ScrollingCoordinator.h:
  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateMainFrameScrollPosition):

  • page/scrolling/ScrollingTree.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:
  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::setScrollPositionWithoutContentEdgeConstraints):

6:56 PM Changeset in webkit [134168] by fpizlo@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

DFG should optimize out the NaN check on loads from double arrays if the array prototype chain is having a great time
https://bugs.webkit.org/show_bug.cgi?id=101718

Reviewed by Geoffrey Garen.

If we're reading from a JSArray in double mode, where the array's structure is
primordial (all aspects of the structure are unchanged except for indexing type),
and the result of the load is used in arithmetic that is known to not distinguish
between NaN and undefined, then we should not emit a NaN check. Looks like a 5%
win on navier-stokes.

Also fixed an OpInfo initialization goof for String ops that was revealed by this
change.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::arraySpeculationToString):

  • dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::isSaneChain):
(ArrayMode):
(JSC::DFG::ArrayMode::isInBounds):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNodeFlags.cpp:

(JSC::DFG::nodeFlagsAsString):

  • dfg/DFGNodeFlags.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::arrayPrototypeChainIsSane):
(JSC):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):

4:55 PM Changeset in webkit [134167] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r134069.
http://trac.webkit.org/changeset/134069
https://bugs.webkit.org/show_bug.cgi?id=101852

"It is a wrong way to fix the problem. See discussions in bug
96614" (Requested by 1JTAAPQFJ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-10

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::getWithUndefinedOrNullCheck):

4:20 PM Changeset in webkit [134166] by mkwst@chromium.org
  • 7 edits in trunk

Web Inspector: Multiple '%c' formatting options should all have effect.
https://bugs.webkit.org/show_bug.cgi?id=101495

Reviewed by Pavel Feldman.

Source/WebCore:

This patch supports multiple '%c' formatting blocks in console messages.
'console.log("%cblue! %cgreen!", "color: blue;", "color: green;")' will
do exactly what you expect: "blue!" will be blue, and "green!" will be
green.

The implementation moves the styles off the message's parent 'span', and
onto new 'span' elements that wrap the various textual bits of the
message.

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype.):
(WebInspector.ConsoleMessageImpl.prototype.append):
(WebInspector.ConsoleMessageImpl.prototype._formatWithSubstitutionString):

LayoutTests:

  • http/tests/inspector/console-test.js:

(initialize_ConsoleTest.InspectorTest.dumpConsoleMessagesWithStyles):

We're no longer putting the style directly on the message's
parent, but instead on each section of the message in order to
support multiple styles.

  • inspector/console/console-format-style-expected.txt:
  • inspector/console/console-format-style-whitelist-expected.txt:
  • inspector/console/console-format-style.html:
3:36 PM Changeset in webkit [134165] by mkwst@chromium.org
  • 3 edits in trunk/Source/WebCore

Including <CoreText/CoreText.h> breaks the chromium/mac build.
https://bugs.webkit.org/show_bug.cgi?id=101851

Reviewed by Dan Bernstein.

r134146 introduced inclusion of 'CoreText/CoreText.h' in
SimpleFontDataCoreText.cpp, which broke the chromium/mac build. Grepping
around, it looks like this needs to be modified to include
'ApplicationServices/ApplicationServices.h'.

  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

Drop 'CoreText.h' in favor of 'ApplicationServices.h'.

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

Drop the platform-specific '#if' logic; just include 'ApplicationServices.h'.

3:33 PM Changeset in webkit [134164] by fpizlo@apple.com
  • 6 edits
    1 add in trunk/Source/JavaScriptCore

DFG constant folding and CFG simplification should be smart enough to know that if a logical op's operand is proven to have a non-masquerading structure then it always evaluates to true
https://bugs.webkit.org/show_bug.cgi?id=101511

Reviewed by Geoffrey Garen.

This is the second attempt at this patch, which fixes the !"" case.

To make life easier, this moves BranchDirection into BasicBlock so that after
running the CFA, we always know, for each block, what direction the CFA
proved. CFG simplification now both uses and preserves cfaBranchDirection in
its transformations.

Also made both LogicalNot and Branch check whether the operand is a known cell
with a known structure, and if so, made them do the appropriate folding.

5% speed-up on V8/raytrace because it makes raytrace's own null checks
evaporate (i.e. idioms like 'if (!x) throw "unhappiness"') thanks to the fact
that we were already doing structure check hoisting.

(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeToSuccessors):

  • dfg/DFGAbstractState.h:

(AbstractState):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::BasicBlock):
(BasicBlock):

  • dfg/DFGBranchDirection.h: Added.

(DFG):
(JSC::DFG::branchDirectionToString):
(JSC::DFG::isKnownDirection):
(JSC::DFG::branchCondition):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

2:35 PM Changeset in webkit [134163] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Don't detach from shared ElementAttributeData when overwriting attribute with identical value.
<http://webkit.org/b/101849>

Reviewed by Anders Carlsson.

Defer the mutableAttributeData() call in Element::setAttributeInternal() until the last
possible moment, to avoid unnecessarily detaching and cloning from attribute data.

120 kB progression on Membuster3.

  • dom/Element.cpp:

(WebCore::Element::setAttributeInternal):
(WebCore::Element::addAttributeInternal):

1:56 PM Changeset in webkit [134162] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Some minor optimizations in RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=101847

Reviewed by Anders Carlsson.

Some minor performance improvements in RenderLayer code.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition): isRenderInline() is a virtual call,
so prefix it with an isInline() check which tests a bit on RenderObject.
(WebCore::RenderLayer::localBoundingBox): Ditto.
(WebCore::RenderLayer::calculateLayerBounds): Pull layer->renderer()
into a local variable.

1:19 PM Changeset in webkit [134161] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Use QLibraryInfo to search for executables.
https://bugs.webkit.org/show_bug.cgi?id=101774

Reviewed by Simon Hausmann.

This allows finding the WebProcess or the PluginProcess
in it's installed location. This is necessary when
deploying QtWebKit with an installer.

  • Shared/qt/ProcessExecutablePathQt.cpp:

(WebKit::executablePath):

11:48 AM Changeset in webkit [134160] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Document::m_fullScreenElementStack should be a Vector
https://bugs.webkit.org/show_bug.cgi?id=101844

Reviewed by Andreas Kling.

m_fullScreenElementStack is currently a Deque where elements are being prepended
and removed from the beginning in LIFO order, so it can be replaced with a Vector.

  • dom/Document.cpp:

(WebCore::Document::requestFullScreenForElement):
(WebCore::Document::webkitCancelFullScreen):
(WebCore::Document::popFullscreenElementStack):
(WebCore::Document::pushFullscreenElementStack):

  • dom/Document.h:

(WebCore::Document::webkitFullscreenElement):
(Document):

10:25 AM Changeset in webkit [134159] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Clean up header includes and ifdefs in V8GCController
https://bugs.webkit.org/show_bug.cgi?id=101691

Reviewed by Kentaro Hara.

This file doesn't need to include all these headers anymore.

  • bindings/v8/V8GCController.cpp:

(WebCore::workingSetEstimateMBMutex):
(WebCore::V8GCController::majorGCEpilogue):
(WebCore::V8GCController::checkMemoryUsage):

8:11 AM Changeset in webkit [134158] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Mac] Guard WebCore PageVisibility Symbol Export
https://bugs.webkit.org/show_bug.cgi?id=101817

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2012-11-10
Reviewed by Andreas Kling.

Guard the export with the same ENABLE guards around its definition
and implementation.

  • WebCore.exp.in:
7:13 AM Changeset in webkit [134157] by commit-queue@webkit.org
  • 6 edits
    1 delete in trunk/Source/JavaScriptCore

Unreviewed, rolling out r133971.
http://trac.webkit.org/changeset/133971
https://bugs.webkit.org/show_bug.cgi?id=101839

Causes WebProcess to hang at 100% on www.apple.com (Requested
by kling on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-10

(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeToSuccessors):

  • dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::branchDirectionToString):
(AbstractState):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::BasicBlock):
(BasicBlock):

  • dfg/DFGBranchDirection.h: Removed.
  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

6:41 AM Changeset in webkit [134156] by Bruno de Oliveira Abinader
  • 8 edits in trunk

[css] text-decoration:none no longer valid
https://bugs.webkit.org/show_bug.cgi?id=101529

Reviewed by Ojan Vafai.

Source/WebCore:

This patch fixes an issue where the 'none' value was parsed as explicitly
'initial' value. However true in a sense that the initial value for the
'text-decoration' property is 'none', the value itself could not be parsed as
'initial'.

The getComputedStyle layout tests for 'text-decoration' and
'-webkit-text-decoration-line' CSS properties are updated with the correct
results.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseTextDecoration): When parsed, 'none' value
gets its own identifier value instead of explicit initial.

LayoutTests:

The getComputedStyle layout tests for 'text-decoration' and
'-webkit-text-decoration-line' CSS properties are updated with the correct
results for the 'none' value.

  • fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt:
  • fast/css/getComputedStyle/script-tests/getComputedStyle-text-decoration.js:
  • fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt:
  • fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-line.js:
  • inspector/console/console-format-style-whitelist-expected.txt:
6:29 AM Changeset in webkit [134155] by noel.gordon@gmail.com
  • 3 edits in trunk/LayoutTests

[chromium] Unreviewed. Rebaseline fast/images/color-jpeg-with-color-profile.html on Win.

  • platform/chromium-win/fast/images/color-jpeg-with-color-profile-expected.png: Rebaseline.
  • platform/chromium/TestExpectations:

Nov 9, 2012:

11:00 PM Changeset in webkit [134154] by dino@apple.com
  • 13 edits in trunk/Source/WebCore

Support list of tracks in caption media controls
https://bugs.webkit.org/show_bug.cgi?id=101669

Reviewed by Eric Carlson.

Attempt three of commit. The first two times caused build failures on Chromium.

Add some new elements to the media control shadow DOM that display the list of available
tracks on an audio/video element. The UI is hidden by default everywhere but on Mac,
where it is given a very basic design. At the moment only the list of available tracks
are displayed; The followup bug will make the UI active: https://bugs.webkit.org/show_bug.cgi?id=101670

No new tests - this doesn't expose any testable surface.

  • css/mediaControls.css: Added default rules that hide the new elements.
  • css/mediaControlsQuickTime.css: Specific rules that give a basic rendering of the new track list.
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlElement::isShowing): Tests for the visibility of a control.
(WebCore::MediaControlClosedCaptionsContainerElement::MediaControlClosedCaptionsContainerElement):
(WebCore::MediaControlClosedCaptionsContainerElement::create):
(WebCore::MediaControlClosedCaptionsContainerElement::shadowPseudoId):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create): Now takes a reference to the media controls as a parameter.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId):
(WebCore::MediaControlClosedCaptionsTrackListElement::MediaControlClosedCaptionsTrackListElement): New element for holding a list of tracks to display.

  • html/shadow/MediaControlElements.h:

(MediaControlElement):
(MediaControlToggleClosedCaptionsButtonElement):
(MediaControlClosedCaptionsContainerElement):
(MediaControlClosedCaptionsTrackListElement): Examines the media element to build a shadow DOM that lists all the tracks available.

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControlRootElement::create): New track container and list elements created.
(WebCore::MediaControlRootElement::setMediaController): Hook up the new elements to the controller..
(WebCore::MediaControlRootElement::hide):
(WebCore::MediaControlRootElement::makeTransparent):
(WebCore::MediaControlRootElement::reset):
(WebCore::MediaControlRootElement::reportedError):
(WebCore::MediaControlRootElement::toggleClosedCaptionTrackList): Shows or hides the popup with the list of tracks.
(WebCore):

  • html/shadow/MediaControlRootElement.h:

(WebCore):
(MediaControlRootElement):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::initializeControls): Pass in the controls as a parameter.

  • html/shadow/MediaControls.h:

(MediaControls):

  • platform/Language.cpp:

(WebCore::displayNameForLanguageLocale): New function to return a human-readable name for a locale, given the identifier input.

  • platform/Language.h:

(WebCore):

  • rendering/RenderMediaControls.cpp:

(WebCore::RenderMediaControls::paintMediaControlsPart): New enum values into switch.

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::RenderMediaControlsChromium::paintMediaControlsPart): New enum values into switch.

10:47 PM Changeset in webkit [134153] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebCore

Unreviewed, rolling out r134152.
http://trac.webkit.org/changeset/134152
https://bugs.webkit.org/show_bug.cgi?id=101831

broke chromium again (Requested by dino_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-09

  • css/mediaControls.css:
  • css/mediaControlsQuickTime.css:

(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId):

  • html/shadow/MediaControlElements.h:

(MediaControlElement):
(MediaControlToggleClosedCaptionsButtonElement):

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControlRootElement::create):
(WebCore::MediaControlRootElement::setMediaController):
(WebCore::MediaControlRootElement::hide):
(WebCore::MediaControlRootElement::makeTransparent):
(WebCore::MediaControlRootElement::reset):
(WebCore::MediaControlRootElement::reportedError):

  • html/shadow/MediaControlRootElement.h:

(WebCore):
(MediaControlRootElement):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::initializeControls):

  • html/shadow/MediaControls.h:

(MediaControls):

  • platform/Language.cpp:

(WebCore):

  • platform/Language.h:

(WebCore):

  • rendering/RenderMediaControls.cpp:

(WebCore::RenderMediaControls::paintMediaControlsPart):

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):

10:23 PM Changeset in webkit [134152] by dino@apple.com
  • 13 edits in trunk/Source/WebCore

Support list of tracks in caption media controls
https://bugs.webkit.org/show_bug.cgi?id=101669

Reviewed by Eric Carlson.

Attempt two of commit. The first time caused a build failure on Chromium.

Add some new elements to the media control shadow DOM that display the list of available
tracks on an audio/video element. The UI is hidden by default everywhere but on Mac,
where it is given a very basic design. At the moment only the list of available tracks
are displayed; The followup bug will make the UI active: https://bugs.webkit.org/show_bug.cgi?id=101670

No new tests - this doesn't expose any testable surface.

  • css/mediaControls.css: Added default rules that hide the new elements.
  • css/mediaControlsQuickTime.css: Specific rules that give a basic rendering of the new track list.
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlElement::isShowing): Tests for the visibility of a control.
(WebCore::MediaControlClosedCaptionsContainerElement::MediaControlClosedCaptionsContainerElement):
(WebCore::MediaControlClosedCaptionsContainerElement::create):
(WebCore::MediaControlClosedCaptionsContainerElement::shadowPseudoId):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create): Now takes a reference to the media controls as a parameter.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId):
(WebCore::MediaControlClosedCaptionsTrackListElement::MediaControlClosedCaptionsTrackListElement): New element for holding a list of tracks to display.

  • html/shadow/MediaControlElements.h:

(MediaControlElement):
(MediaControlToggleClosedCaptionsButtonElement):
(MediaControlClosedCaptionsContainerElement):
(MediaControlClosedCaptionsTrackListElement): Examines the media element to build a shadow DOM that lists all the tracks available.

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControlRootElement::create): New track container and list elements created.
(WebCore::MediaControlRootElement::setMediaController): Hook up the new elements to the controller..
(WebCore::MediaControlRootElement::hide):
(WebCore::MediaControlRootElement::makeTransparent):
(WebCore::MediaControlRootElement::reset):
(WebCore::MediaControlRootElement::reportedError):
(WebCore::MediaControlRootElement::toggleClosedCaptionTrackList): Shows or hides the popup with the list of tracks.
(WebCore):

  • html/shadow/MediaControlRootElement.h:

(WebCore):
(MediaControlRootElement):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::initializeControls): Pass in the controls as a parameter.

  • html/shadow/MediaControls.h:

(MediaControls):

  • platform/Language.cpp:

(WebCore::displayNameForLanguageLocale): New function to return a human-readable name for a locale, given the identifier input.

  • platform/Language.h:

(WebCore):

  • rendering/RenderMediaControls.cpp:

(WebCore::RenderMediaControls::paintMediaControlsPart): New enum values into switch.

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::RenderMediaControlsChromium::paintMediaControlsPart): New enum values into switch.

9:54 PM Changeset in webkit [134151] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

If the DFG ArrayMode says that an access is on an OriginalArray, then the checks should always enforce this
https://bugs.webkit.org/show_bug.cgi?id=101720

Reviewed by Mark Hahnenberg.

Previously, "original" arrays was just a hint that we could find the structure
of the array if we needed to even if the array profile didn't have it due to
polymorphism. Now, "original" arrays are a property that is actually checked:
if an array access has ArrayMode::arrayClass() == Array::OriginalArray, then we
can be sure that the code performing the access is dealing with not just a
JSArray, but a JSArray that has no named properties, no indexed accessors, and
the ArrayPrototype as its prototype. This will be useful for optimizations that
are being done as part of https://bugs.webkit.org/show_bug.cgi?id=101720.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::originalArrayStructure):
(DFG):
(JSC::DFG::ArrayMode::alreadyChecked):

  • dfg/DFGArrayMode.h:

(JSC):
(DFG):
(JSC::DFG::ArrayMode::withProfile):
(ArrayMode):
(JSC::DFG::ArrayMode::benefitsFromOriginalArray):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::checkArray):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode):
(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):

9:16 PM Changeset in webkit [134150] by ojan@chromium.org
  • 6 edits
    2 adds in trunk

Should only fire a single set of mouse events and update hover state once when scrolling is done
https://bugs.webkit.org/show_bug.cgi?id=99940

Reviewed by Levi Weintraub.

Source/WebCore:

-Use a DeferrableOneShotTimer instead of a Timer. By resetting when the
timer is fired, we ensure the actual goal of not firing fake mouse events
until the scroll is completed. This is the core part of this change.
-Change our mouse event throttling to keep a running average of how long
mouse events take and adjust throttling appropriately.
Test: fast/scrolling/fake-mouse-event-throttling.html
-Maintain a minimum throttle of 100ms.

  • page/EventHandler.cpp:

(WebCore):
(WebCore::RunningAverageDurationTracker::RunningAverageDurationTracker):
(WebCore::RunningAverageDurationTracker::~RunningAverageDurationTracker):
Keep track of a running average instead of max. This lets us adjust throttling
dynamically without punishing a page for having a single mouse event handler
that takes disproportionately long.
(RunningAverageDurationTracker):
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):

  • page/EventHandler.h:

(EventHandler):

  • platform/Timer.h:

(WebCore::DeferrableOneShotTimer::setDelay):
(WebCore::DeferrableOneShotTimer::delay):
Add a way of adjusting the timer delay.

LayoutTests:

Tests basic throttling. I couldn't think of a good way to test changing
the delay that wouldn't make for a test that takes minutes to run.

  • fast/scrolling/fake-mouse-event-throttling-expected.txt: Added.
  • fast/scrolling/fake-mouse-event-throttling.html: Added.
9:12 PM Changeset in webkit [134149] by commit-queue@webkit.org
  • 9 edits
    1 delete in trunk

Source/WebCore: Move chromium to USE(LAZY_NATIVE_CURSOR)
https://bugs.webkit.org/show_bug.cgi?id=101501

Patch by Rick Byers <rbyers@chromium.org> on 2012-11-09
Reviewed by Adam Barth.

This simplifies cursor handling in chromium and unifies it with other
ports for easier code sharing and testing by moving to the
USE_LAZY_CURSOR model and eliminating PlatformCursor entirely.

PlatformCursor adds no value in chromium since the sandboxing model
requires the cursor information be marshalled to the browser process
before being turned into a real OS cursor.

Test: fast/events/mouse-cursor.html

  • WebCore.gypi:
  • platform/Cursor.h:

(WebCore):

  • platform/chromium/CursorChromium.cpp:

(WebCore::Cursor::Cursor):
(WebCore::Cursor::operator=):
(WebCore::Cursor::~Cursor):
(WebCore::Cursor::ensurePlatformCursor):

  • platform/chromium/PlatformCursor.h: Removed.

Source/WebKit/chromium: Move chromium to USE(LAZY_NATIVE_CURSOR)
https://bugs.webkit.org/show_bug.cgi?id=101501

Patch by Rick Byers <rbyers@chromium.org> on 2012-11-09
Reviewed by Adam Barth.

Update conversion from Cursor to WebCursorInfo to remove the
intermediate (and useless) step of PlatformCursor.

  • src/AssertMatchingEnums.cpp:
  • src/WebCursorInfo.cpp:

(WebKit::WebCursorInfo::WebCursorInfo):

LayoutTests: [chromium] Move to USE(LAZY_NATIVE_CURSOR)
https://bugs.webkit.org/show_bug.cgi?id=101501

Patch by Rick Byers <rbyers@chromium.org> on 2012-11-09
Reviewed by Adam Barth.

Remove failure expectation for fast/events/mouse-cursor.html now that
chromium uses the same cursor architecture as other ports.

  • platform/chromium/TestExpectations:
9:05 PM Changeset in webkit [134148] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebKit2

Coordinated Graphics: Rename tileRect from targetRect.
https://bugs.webkit.org/show_bug.cgi?id=101705

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-09
Reviewed by Noam Rosenthal.

Messages::LayerTreeCoordinatorProxy::CreateTileForLayer contains the targetRect
variable. The targetRect stands for the rect of the tile created. This patch
renames tileRect to enhance the clearity.

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStoreTile::swapBuffers):
(WebKit::CoordinatedBackingStoreTile::setBackBuffer):
(WebKit::CoordinatedBackingStore::updateTile):

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:

(CoordinatedBackingStoreTile):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::createTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::updateTile):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(TileUpdate):
(WebKit::LayerTreeRenderer::TileUpdate::TileUpdate):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::createTile):
(WebCore::CoordinatedGraphicsLayer::updateTile):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h:

(CoordinatedTileClient):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::createTile):
(WebKit::LayerTreeCoordinator::updateTile):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

8:49 PM Changeset in webkit [134147] by noam.rosenthal@nokia.com
  • 6 edits in trunk/Source

Allow ports to decide whether an image should be directly composited
https://bugs.webkit.org/show_bug.cgi?id=101827

Reviewed by Simon Fraser.

Source/WebCore:

Tested by compositing/tiling/huge-layer-img.html.

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::shouldDirectlyCompositeImage):

Allow the GraphicsLayer implementation to decide if the image can be composited.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::isDirectlyCompositedImage):

Take onto account the new shouldDirectlyCompositeImage check.

Source/WebKit2:

Implement shouldDirectlyCompositeImage for coordinated graphics, effectively disabling direct
compositing of images with width or height larger than 2000 pixels.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::shouldDirectlyCompositeImage):
(WebCore):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayer):

7:34 PM Changeset in webkit [134146] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

SimpleFontData::getCFStringAttributes sets some attributes to their default values, but shouldn’t
https://bugs.webkit.org/show_bug.cgi?id=101799

Reviewed by Alexey Proskuryakov.

In some configurations, setting kCTLigatureAttributeName to its default value of 1 yields
different behavior from not setting it at all. We can get the correct behavior and greatly
simplify the code by not setting attributes to their default values.

  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

Removed redundant #import directives and changed the remaining ones to #include.
(WebCore::SimpleFontData::getCFStringAttributes): Changed to use a mutable dictionary and
only add attributes that have non-default values.

6:54 PM Changeset in webkit [134145] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Coordinated Graphics: Antialias the edge-tiles of CoordinatedBackingStore.
https://bugs.webkit.org/show_bug.cgi?id=101818

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-09
Reviewed by Noam Rosenthal.

Since we now have the entire surfaceRect, we can antialias the edge-tiles.

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStore::paintTilesToTextureMapper):
(WebKit::CoordinatedBackingStore::paintToTextureMapper):

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:

(CoordinatedBackingStore):

6:45 PM Changeset in webkit [134144] by commit-queue@webkit.org
  • 14 edits
    2 adds in trunk

No tests for changing mouse cursors
https://bugs.webkit.org/show_bug.cgi?id=100550

Patch by Rick Byers <rbyers@chromium.org> on 2012-11-09
Reviewed by Adam Barth.

.:

Add necessary exports for Internals::getCurrentCursorInfo

  • Source/autotools/symbols.filter:

Source/WebCore:

Add infrastructure to keep track of the last set mouse cursor,
and then to query it from DumpRenderTree.

Test: fast/events/mouse-cursor.html

  • WebCore.exp.in: Add Cursor copy ctor export
  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseMoveEvent): Keep track of last set mouse cursor

  • page/EventHandler.h:

(WebCore::EventHandler::currentMouseCursor): New getter for last set mouse cursor

  • testing/Internals.cpp:

(WebCore::cursorTypeToString): Helper to convert cursor type to enum
(WebCore):
(WebCore::Internals::getCurrentCursorInfo): New function to return a string describing the last set mouse cursor

  • testing/Internals.h: Declare getCurrentCursorInfo
  • testing/Internals.idl: Declare getCurrentCursorInfo

Source/WebKit2:

Add necessary exports for Internals::getCurrentCursorInfo

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

Add a simple test covering the basic scenarios of changing a mouse
cursor with CSS. This includes most of the cases currently covered
by ManualTests/*cursor*.

  • fast/events/mouse-cursor-expected.txt: Added.
  • fast/events/mouse-cursor.html: Added.
  • platform/chromium/TestExpectations: Add failure expectation.
6:42 PM Changeset in webkit [134143] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Add missing exports setMediaTypeOverride, setResolutionOverride and layerTreeAsText to WebKit2CFLite.def
https://bugs.webkit.org/show_bug.cgi?id=101816

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-11-09
Reviewed by Anders Carlsson.

Add missing exports setMediaTypeOverride, setResolutionOverride and layerTreeAsText to WebKit2CFLite.def to fix win-cairo build.

  • win/WebKit2CFLite.def:
6:32 PM Changeset in webkit [134142] by commit-queue@webkit.org
  • 16 edits in trunk/Source

Coordinated Graphics: Amend CoordinatedBackingStore::paintToTextureMapper to fit its own semantic.
https://bugs.webkit.org/show_bug.cgi?id=101701

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-09
Reviewed by Noam Rosenthal.

Source/WebCore:

Add TiledBackingStore::rect() because CoordinatedTile needs to know
m_rect of TiledBackingStore.

  • platform/graphics/TiledBackingStore.h:

(WebCore::TiledBackingStore::rect):

Source/WebKit2:

Currently, all subclasses of TextureMapperPlatformLayer implement
paintToTextureMapper to draw its own texture on the given targetRect. Subclasses
can scale the texture to fit the size of the targetRect. However, only
CoordinatedBackingStore::paintToTextureMapper draws its texture using its own
texture size. There is no bug yet, because TextureMapperLayer uses
CoordinatedBackingStore only as a backing store, not a content layer. So,
TextureMapperLayer always request CoordinatedBackingStore to draw using its own
texture size. However, we can use CoordinatedBackingStore as a content layer in
the future. So this patch fixes this potential bug.

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStore::setSize):
(WebKit):
(WebKit::mapToContents):
(WebKit::paintTilesToTextureMapper):
(WebKit::CoordinatedBackingStore::paintToTextureMapper):

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:

(CoordinatedBackingStore):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::createTileForLayer):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::createTile):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::createTile):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp:

(WebKit::CoordinatedTile::updateBackBuffer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h:

(CoordinatedTileClient):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::createTile):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

6:07 PM Changeset in webkit [134141] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Unreviewed, rolling out r134139.
http://trac.webkit.org/changeset/134139
https://bugs.webkit.org/show_bug.cgi?id=101823

breaks chromium (android) build (Requested by thorton on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-09

  • css/mediaControls.css:
  • css/mediaControlsQuickTime.css:

(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
(audio::-webkit-media-controls-volume-slider-mute-button, video::-webkit-media-controls-volume-slider-mute-button):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId):

  • html/shadow/MediaControlElements.h:

(MediaControlElement):
(MediaControlToggleClosedCaptionsButtonElement):

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControlRootElement::create):
(WebCore::MediaControlRootElement::setMediaController):
(WebCore::MediaControlRootElement::hide):
(WebCore::MediaControlRootElement::makeTransparent):
(WebCore::MediaControlRootElement::reset):
(WebCore::MediaControlRootElement::reportedError):

  • html/shadow/MediaControlRootElement.h:

(WebCore):
(MediaControlRootElement):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::initializeControls):

  • html/shadow/MediaControls.h:

(MediaControls):

  • platform/Language.cpp:

(WebCore):

  • platform/Language.h:

(WebCore):

5:46 PM Changeset in webkit [134140] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[TexMap] Initialize m_compositedNativeImagePtr in GraphicsLayerTextureMapper.
https://bugs.webkit.org/show_bug.cgi?id=101675

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-09
Reviewed by Noam Rosenthal.

Fix a potential bug in GraphicsLayerTextureMapper. If the member's uninitialized
value equals image->nativeImageForCurrentFrame() by change, we can encounter
undefined behavior.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::setContentsToImage):

5:44 PM Changeset in webkit [134139] by dino@apple.com
  • 11 edits in trunk/Source/WebCore

Support list of tracks in caption media controls
https://bugs.webkit.org/show_bug.cgi?id=101669

Reviewed by Eric Carlson.

Add some new elements to the media control shadow DOM that display the list of available
tracks on an audio/video element. The UI is hidden by default everywhere but on Mac,
where it is given a very basic design. At the moment only the list of available tracks
are displayed; The followup bug will make the UI active: https://bugs.webkit.org/show_bug.cgi?id=101670

No new tests - this doesn't expose any testable surface.

  • css/mediaControls.css: Added default rules that hide the new elements.
  • css/mediaControlsQuickTime.css: Specific rules that give a basic rendering of the new track list.
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlElement::isShowing): Tests for the visibility of a control.
(WebCore::MediaControlClosedCaptionsContainerElement::MediaControlClosedCaptionsContainerElement):
(WebCore::MediaControlClosedCaptionsContainerElement::create):
(WebCore::MediaControlClosedCaptionsContainerElement::shadowPseudoId):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::create): Now takes a reference to the media controls as a parameter.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId):
(WebCore::MediaControlClosedCaptionsTrackListElement::MediaControlClosedCaptionsTrackListElement): New element for holding a list of tracks to display.

  • html/shadow/MediaControlElements.h:

(MediaControlElement):
(MediaControlToggleClosedCaptionsButtonElement):
(MediaControlClosedCaptionsContainerElement):
(MediaControlClosedCaptionsTrackListElement): Examines the media element to build a shadow DOM that lists all the tracks available.

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::MediaControlRootElement):
(WebCore::MediaControlRootElement::create): New track container and list elements created.
(WebCore::MediaControlRootElement::setMediaController): Hook up the new elements to the controller..
(WebCore::MediaControlRootElement::hide):
(WebCore::MediaControlRootElement::makeTransparent):
(WebCore::MediaControlRootElement::reset):
(WebCore::MediaControlRootElement::reportedError):
(WebCore::MediaControlRootElement::toggleClosedCaptionTrackList): Shows or hides the popup with the list of tracks.
(WebCore):

  • html/shadow/MediaControlRootElement.h:

(WebCore):
(MediaControlRootElement):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::initializeControls): Pass in the controls as a parameter.

  • html/shadow/MediaControls.h:

(MediaControls):

  • platform/Language.cpp:

(WebCore::displayNameForLanguageLocale): New function to return a human-readable name for a locale, given the identifier input.

  • platform/Language.h:

(WebCore):

5:26 PM Changeset in webkit [134138] by noel.gordon@gmail.com
  • 4 edits
    2 adds in trunk

[chromium] Should pass fast/images/paletted-png-with-color-profile.html
https://bugs.webkit.org/show_bug.cgi?id=101551

Reviewed by Adam Barth.

Source/WebCore:

Support decoding color PALETTE images that have an ICC color profile.

Covered by fast/images/png-suite/test.html and many other fast/image tests.

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::headerAvailable): Move the color profile code after the
transparency (tRNS) reader. Allow color PNG images: RGB, RGBA, PALLETE to be color
corrected. Use the transparency count from the tRNS reader to detect the expansion
of RGB and PALLETE image pixels to RGBA.

LayoutTests:

Update fast/images/paletted-png-with-color-profile.html image results for
Mac and Win (Chromium Android and Linux don't support color profiles).

  • platform/chromium-mac/fast/images/paletted-png-with-color-profile-expected.png: Added.
  • platform/chromium-win/fast/images/paletted-png-with-color-profile-expected.png: Added.
  • platform/chromium/TestExpectations:
4:53 PM Changeset in webkit [134137] by beidson@apple.com
  • 11 edits in trunk/Source/WebKit2

Implement NetworkProcess willSendRequest
https://bugs.webkit.org/show_bug.cgi?id=101812

Reviewed by Alexey Proskuryakov.

Message to the WebProcess to get the new request, if any.

Because network callbacks are coming in on a background thread we have to jump through hoops to synchronously
ask the WebProcess, but these hoops follow an established pattern of using async messaging with BlockingResourceMap.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::willSendRequestHandled): Pass the new request back to NetworkRequest for handling.

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • NetworkProcess/NetworkRequest.cpp:

(WebKit::NetworkRequest::didFail):
(WebKit::responseMap):
(WebKit::generateWillSendRequestID):
(WebKit::didReceiveWillSendRequestHandled):
(WebKit::NetworkRequest::willSendRequest): Asynchronously message the WebProcess but synchronous wait for a reply back.

  • NetworkProcess/NetworkRequest.h:
  • WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::willSendRequest): Ask the WebResourceLoadScheduler for the new request then

message back to the NetworkProcess with the reply.

  • WebProcess/Network/NetworkProcessConnection.h:
  • WebProcess/Network/NetworkProcessConnection.messages.in:
  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::willSendRequest):

  • WebProcess/Network/WebResourceLoadScheduler.h:
4:46 PM Changeset in webkit [134136] by jsbell@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening. One more baseline following 134112.

  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/composited-iframe-alignment-expected.png: Added.
4:16 PM Changeset in webkit [134135] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Correct hit-test point scaling for document.elementFromPoint
https://bugs.webkit.org/show_bug.cgi?id=101798

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-11-09
Reviewed by Adam Barth.

The hit-test point come from user JavaScript is in the document coordinate.
Convert to the frame coordinate with correct scale factor for hit test.

Source/WebCore:

Test: fast/dom/elementFromPoint-scaled-scrolled.html

  • dom/Document.cpp:

(WebCore::nodeFromPoint):

LayoutTests:

  • fast/dom/elementFromPoint-scaled-scrolled-expected.txt: Added.
  • fast/dom/elementFromPoint-scaled-scrolled.html: Added.
4:15 PM Changeset in webkit [134134] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix indentation of BooleanPrototype.h

Rubber stamped by Mark Hahnenberg.

  • runtime/BooleanPrototype.h:
4:14 PM Changeset in webkit [134133] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix indentation of BooleanObject.h

Rubber stamped by Mark Hahnenberg.

  • runtime/BooleanObject.h:
4:12 PM Changeset in webkit [134132] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] More gardening.

media/video-seek-past-end-playing.html is still flaky on WK2, skip
it on both WK1 and WK2.

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
4:09 PM Changeset in webkit [134131] by timothy_horton@apple.com
  • 13 edits in trunk/Source/WebKit2

PDFPlugin should support clicking on external links
https://bugs.webkit.org/show_bug.cgi?id=101647
<rdar://problem/12555222>

Reviewed by Alexey Proskuryakov.

  • WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add details about clickedLinkWithURL: callback.
  • WebProcess/Plugins/PDF/PDFPlugin.h:

(PDFPlugin): Add clickedLink() and storage for the last mouse event that was dispatched.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(-[WKPDFLayerControllerDelegate pdfLayerController:clickedLinkWithURL:]): Forward the URL to PDFPlugin.
(WebKit::PDFPlugin::handleMouseEvent): Store the last mouse event that was dispatched.
We use this to get the correct mouse button and modifier keys, so that command-clicking, etc. links works.
(WebKit::PDFPlugin::clickedLink): Request a load given the new URL.

  • PluginProcess/PluginControllerProxy.h:

(PluginControllerProxy):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::shouldAllowScripting):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/PDF/PDFLayerControllerDetails.h:
  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::shouldAllowScripting):

  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::shouldAllowScripting):

  • WebProcess/Plugins/PluginView.h:

Add shouldAllowScripting() function to Plugin (and plumb through PluginProxy and PluginView, etc.)

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::allowScript): Override allowScript(); if the frame is hosting a PluginDocument,
ask its plugin whether it should allow execution of JavaScript and JavaScript URLs or not.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/Plugins/PDF/SimplePDFPlugin.h: Disable scripting for SimplePDFPlugin (and, by inheritance, PDFPlugin).
4:07 PM Changeset in webkit [134130] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Skip fast/canvas/canvas-resize-reset-pixelRatio.html since
HIGH_DPI_CANVAS is disabled by default.

  • platform/efl/TestExpectations:
4:01 PM Changeset in webkit [134129] by alecflett@chromium.org
  • 11 edits
    1 delete in trunk/Source

IndexedDB: Combine IDBBackingStore and IDBLevelDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=101415

Reviewed by Tony Chang.

Source/WebCore:

Combine abstract interface IDBBackingStore with its only
implementation, IDBLevelDBBackingStore, to reduce code
complexity. The legacy structure existed to support a SQLLite
IDBBackingStore, but it is no longer worth the complexity to
support this abstraction.

Changes include:
1) Merging IDBLevelDBBackingStore into IDBBackingStore.

2) Merge together IDBBackingStore's inner classes: Cursor,
Transaction, and ObjectStoreRecordIdentfier with their respective
subclasses in IDBLevelDBBackingStore.

3) Simplifying the inner Transaction class to not be refcounted or
virtualized, to allow it to be a simple concrete member of its
owner, IDBTransactionBackendImpl.

No new tests as this is purely a refactor.

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::recordInternalError):
(WebCore::setUpMetadata):
(WebCore::IDBBackingStore::IDBBackingStore):
(WebCore):
(WebCore::IDBBackingStore::~IDBBackingStore):
(WebCore::IDBBackingStore::open):
(WebCore::IDBBackingStore::getDatabaseNames):
(WebCore::IDBBackingStore::getIDBDatabaseMetaData):
(WebCore::IDBBackingStore::createIDBDatabaseMetaData):
(WebCore::IDBBackingStore::updateIDBDatabaseIntVersion):
(WebCore::IDBBackingStore::updateIDBDatabaseMetaData):
(WebCore::deleteRange):
(WebCore::IDBBackingStore::deleteDatabase):
(WebCore::IDBBackingStore::getObjectStores):
(WebCore::setMaxObjectStoreId):
(WebCore::IDBBackingStore::createObjectStore):
(WebCore::IDBBackingStore::deleteObjectStore):
(WebCore::IDBBackingStore::getRecord):
(WebCore::IDBBackingStore::putRecord):
(WebCore::IDBBackingStore::clearObjectStore):
(WebCore::IDBBackingStore::deleteRecord):
(WebCore::IDBBackingStore::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBBackingStore::getIndexes):
(WebCore::setMaxIndexId):
(WebCore::IDBBackingStore::createIndex):
(WebCore::IDBBackingStore::deleteIndex):
(WebCore::IDBBackingStore::putIndexDataForRecord):
(WebCore::IDBBackingStore::deleteIndexDataForRecord):
(WebCore::IDBBackingStore::findKeyInIndex):
(WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStore::keyExistsInIndex):
(WebCore::IDBBackingStore::Cursor::Cursor):
(WebCore::IDBBackingStore::Cursor::firstSeek):
(WebCore::IDBBackingStore::Cursor::advance):
(WebCore::IDBBackingStore::Cursor::continueFunction):
(WebCore::IDBBackingStore::Cursor::haveEnteredRange):
(WebCore::IDBBackingStore::Cursor::isPastBounds):
(WebCore::ObjectStoreKeyCursorImpl::create):
(ObjectStoreKeyCursorImpl):
(WebCore::ObjectStoreKeyCursorImpl::value):
(WebCore::ObjectStoreKeyCursorImpl::ObjectStoreKeyCursorImpl):
(WebCore::ObjectStoreKeyCursorImpl::loadCurrentRow):
(WebCore::ObjectStoreCursorImpl::create):
(ObjectStoreCursorImpl):
(WebCore::ObjectStoreCursorImpl::value):
(WebCore::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
(WebCore::ObjectStoreCursorImpl::loadCurrentRow):
(WebCore::IndexKeyCursorImpl::create):
(IndexKeyCursorImpl):
(WebCore::IndexKeyCursorImpl::value):
(WebCore::IndexKeyCursorImpl::primaryKey):
(WebCore::IndexKeyCursorImpl::recordIdentifier):
(WebCore::IndexKeyCursorImpl::IndexKeyCursorImpl):
(WebCore::IndexKeyCursorImpl::loadCurrentRow):
(WebCore::IndexCursorImpl::create):
(IndexCursorImpl):
(WebCore::IndexCursorImpl::value):
(WebCore::IndexCursorImpl::primaryKey):
(WebCore::IndexCursorImpl::recordIdentifier):
(WebCore::IndexCursorImpl::IndexCursorImpl):
(WebCore::IndexCursorImpl::loadCurrentRow):
(WebCore::objectStoreCursorOptions):
(WebCore::indexCursorOptions):
(WebCore::IDBBackingStore::openObjectStoreCursor):
(WebCore::IDBBackingStore::openObjectStoreKeyCursor):
(WebCore::IDBBackingStore::openIndexKeyCursor):
(WebCore::IDBBackingStore::openIndexCursor):
(WebCore::IDBBackingStore::Transaction::Transaction):
(WebCore::IDBBackingStore::Transaction::begin):
(WebCore::IDBBackingStore::Transaction::commit):
(WebCore::IDBBackingStore::Transaction::rollback):

  • Modules/indexeddb/IDBBackingStore.h:

(WebCore):
(IDBBackingStore):
(RecordIdentifier):
(WebCore::IDBBackingStore::RecordIdentifier::create):
(WebCore::IDBBackingStore::RecordIdentifier::~RecordIdentifier):
(WebCore::IDBBackingStore::RecordIdentifier::isValid):
(WebCore::IDBBackingStore::RecordIdentifier::primaryKey):
(WebCore::IDBBackingStore::RecordIdentifier::setPrimaryKey):
(WebCore::IDBBackingStore::RecordIdentifier::version):
(WebCore::IDBBackingStore::RecordIdentifier::setVersion):
(WebCore::IDBBackingStore::RecordIdentifier::RecordIdentifier):
(Transaction):
(WebCore::IDBBackingStore::Transaction::levelDBTransactionFrom):
(CursorOptions):
(Cursor):
(WebCore::IDBBackingStore::Cursor::Cursor):
(WebCore::IDBBackingStore::Cursor::key):
(WebCore::IDBBackingStore::Cursor::primaryKey):
(WebCore::IDBBackingStore::Cursor::~Cursor):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::openBackingStore):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::countInternal):

  • Modules/indexeddb/IDBLevelDBBackingStore.h: Removed.
  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::commit):
(WebCore::IDBTransactionBackendImpl::taskTimerFired):

  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(WebCore::IDBTransactionBackendImpl::backingStoreTransaction):

  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

Remove method that is no longer in the base class.

  • tests/IDBFakeBackingStore.h:
3:55 PM Changeset in webkit [134128] by Lucas Forschler
  • 5 edits in branches/safari-536.28-branch

Merged r132427. <rdar://problem/12589196>

3:54 PM Changeset in webkit [134127] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Correct scroll adjustment for touchEvent.clientX/clientY
https://bugs.webkit.org/show_bug.cgi?id=101800

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-11-09
Reviewed by Adam Barth.

FrameView::scrollX/scrollY returns scroll offset in (scaled) frame coordinate.
Convert to document coordinate before passing to JavaScript.

Source/WebCore:

Test: fast/events/touch/touch-scaled-scrolled.html

  • dom/Touch.cpp:

(WebCore::contentsX):
(WebCore::contentsY):

LayoutTests:

  • fast/events/touch/touch-scaled-scrolled-expected.txt: Added.
  • fast/events/touch/touch-scaled-scrolled.html: Added.
3:52 PM Changeset in webkit [134126] by Lucas Forschler
  • 6 edits in branches/safari-536.28-branch/Source/WebCore

Merged r131939. <rdar://problem/12589196>

3:49 PM Changeset in webkit [134125] by Alexandru Chiculita
  • 7 edits
    3 adds in trunk

[Texmap][CSS Shaders] Enable CSS Shaders in TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=98990

Reviewed by Noam Rosenthal.

Source/WebCore:

Added code that draws the Custom Filter in the TextureMapperGL. Also added
required code to make a depth buffer for a BitmapTextureGL.

Note that the code is not optimized yet, so it will always recompile the shader.

Test: css3/filters/custom/composited/custom-filter-blend-modes.html

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::getPassesRequiredForFilter):
(WebCore):
(WebCore::TextureMapperGL::drawUsingCustomFilter):
(WebCore::BitmapTextureGL::applyFilters):
(WebCore::BitmapTextureGL::initializeDepthBuffer):
(WebCore::BitmapTextureGL::~BitmapTextureGL):

  • platform/graphics/texmap/TextureMapperGL.h:

(BitmapTextureGL):

LayoutTests:

Copied the custom-filter-blend-modes.html test file and forced the filtered elements to have
composited layers using 3d transforms.

  • css3/filters/custom/composited/custom-filter-blend-modes-expected.html: Added.
  • css3/filters/custom/composited/custom-filter-blend-modes.html: Added.
  • platform/qt-4.8/TestExpectations: Only Qt-Wk2 can currently run the shaders.
  • platform/qt-5.0-wk1/TestExpectations:
  • platform/qt/TestExpectations: Added a couple of tests that are not passing currently.

I've added 101531 to track those.

3:46 PM Changeset in webkit [134124] by jsbell@chromium.org
  • 1 edit
    13 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening. A few more baselines following 134112.

  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/overflow-positioning-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/overflow-positioning-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/reflection-opacity-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/clip-content-under-overflow-controls-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/overflow-positioning-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/reflection-opacity-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/newly-composited-on-scroll-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/absolute-position-changed-with-composited-parent-layer-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/iframes/composited-iframe-alignment-expected.png: Added.
3:40 PM Changeset in webkit [134123] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Widen cross-fade-invalidation expectation to include all platforms.

  • platform/chromium/TestExpectations:
3:37 PM Changeset in webkit [134122] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Unskip fast/dom/navigator-vibration.html after r133828.

  • platform/efl-wk2/TestExpectations:
3:36 PM Changeset in webkit [134121] by Lucas Forschler
  • 6 edits in branches/safari-536.28-branch/Source/WebCore

Merge r130236. <rdar://problem/12589196>

3:27 PM Changeset in webkit [134120] by commit-queue@webkit.org
  • 7 edits
    1 copy in trunk/Source/WebCore

CustomEvent: Allow taking in a serialized value during initialization.
https://bugs.webkit.org/show_bug.cgi?id=101348

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-11-09
Reviewed by Adam Barth.

If a CustomEvent is initialized using a serialized value, then for each access
to |detail|, the value is deserialized first. This way, each world gets a different
deserialization.

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

  • bindings/v8/custom/V8CustomEventCustom.cpp: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.

(WebCore):
(WebCore::V8CustomEvent::detailAccessorGetter):

  • dom/CustomEvent.cpp:

(WebCore::CustomEvent::initCustomEvent):
(WebCore):

  • dom/CustomEvent.h:

(CustomEvent):
(WebCore::CustomEvent::serializedScriptValue):

  • dom/CustomEvent.idl:
3:25 PM Changeset in webkit [134119] by beidson@apple.com
  • 5 edits in trunk/Source

Implement WebResourceBuffer::isEmpty()
https://bugs.webkit.org/show_bug.cgi?id=101805

Reviewed by Alexey Proskuryakov.

This is required to make the existing subresource loading in NetworkProcess work correctly,
as there's an isEmpty() check in the WebProcess that decides whether or not to actually deliver
the data to the ResourceLoader.

Source/WebCore:

No new tests (No change in behavior in any configuration we test.)

  • loader/ResourceBuffer.h: Make isEmpty() virtual.

Source/WebKit2:

  • Shared/WebResourceBuffer.cpp:

(WebKit::WebResourceBuffer::isEmpty):

  • Shared/WebResourceBuffer.h:
2:36 PM Changeset in webkit [134118] by Lucas Forschler
  • 3 edits in branches/safari-536.28-branch/Source/JavaScriptCore

Merged r126624. <rdar://problem/12486145>

2:33 PM Changeset in webkit [134117] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Adding a sound to touch events on anchor elements
https://bugs.webkit.org/show_bug.cgi?id=101655

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-11-09
Reviewed by Antonio Gomes.

Adding audio feedback to touchevents on html anchor elements.

The feedback is called directly from client instead of using the
mouseup event to avoid the delay between touch start and end caused
by the tap sequence recognizer.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::playSoundIfAnchorIsTarget):
(WebKit):

  • Api/WebPage.h:
  • WebKitSupport/TouchEventHandler.cpp:

(WebKit):
(BlackBerry::WebKit::TouchEventHandler::playSoundIfAnchorIsTarget):

  • WebKitSupport/TouchEventHandler.h:

(TouchEventHandler):

2:32 PM Changeset in webkit [134116] by msaboff@apple.com
  • 4 edits in trunk/Source/WebCore

HTML Attributes names and values should be created as 8 bit string where possible
https://bugs.webkit.org/show_bug.cgi?id=101781

Reviewed by Filip Pizlo.

Given that almost all attribute names and values are lower case ASCII, we should try to
create 8 bit strings to process them. Creating an AtomicString already tries to make
an 8 bit string, so that didn't need to change.

No new tests, functionality covered by existing tests.

  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::processTagToken):

  • html/parser/HTMLMetaCharsetParser.cpp:

(WebCore::HTMLMetaCharsetParser::processMeta):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::PreloadTask::processAttributes):

2:31 PM Changeset in webkit [134115] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Updated expectations following 134112.

  • platform/chromium/TestExpectations:
2:28 PM Changeset in webkit [134114] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix indentation of BooleanConstructor.h

Rubber stamped by Mark Hahnenberg.

  • runtime/BooleanConstructor.h:
2:27 PM Changeset in webkit [134113] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix indentation of BatchedTransitionOptimizer.h

Rubber stamped by Mark Hahnenberg.

  • runtime/BatchedTransitionOptimizer.h:
2:22 PM Changeset in webkit [134112] by enne@google.com
  • 2 edits
    1 move
    160 adds in trunk/LayoutTests

[chromium] Rebaselining software compositor tests.

Patch by Slavomir Kaslev <skaslev@google.com> on 2012-11-09
Patch by Slavomir Kaslev <skaslev@google.com> on 2012-11-09
Reviewed by Adrienne Walker.

  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/clipping-foreground-expected.png: Renamed from LayoutTests/platform/chromium-android/platform/chromium/virtual/softwarecompositing/geometry/clipping-foreground-expected.png.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/masks/direct-image-mask-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/masks/multiple-masks-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/masks/simple-composited-mask-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-anchor-point-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-mask-change-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/transform-inside-reflection-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/clipping-foreground-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/images/direct-image-background-color-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/masks/direct-image-mask-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/masks/multiple-masks-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/masks/simple-composited-mask-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-anchor-point-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-mask-change-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/transform-inside-reflection-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/clipping-foreground-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/images/direct-image-background-color-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/masks/direct-image-mask-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/masks/multiple-masks-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/masks/simple-composited-mask-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-anchor-point-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-mask-change-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/transform-inside-reflection-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/clipping-foreground-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/images/direct-image-background-color-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/masks/direct-image-mask-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/masks/multiple-masks-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/masks/simple-composited-mask-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-anchor-point-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-mask-change-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/transform-inside-reflection-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/scrollbar-painting-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/color-matching/image-color-matching-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/direct-image-compositing-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/flat-with-transformed-child-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/masks/direct-image-mask-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/masks/multiple-masks-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/masks/simple-composited-mask-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-anchor-point-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-animated-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-opacity-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/nested-reflection-transition-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/transform-inside-reflection-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/scaling/tiled-layer-recursion-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-expected.png: Added.
  • platform/chromium/TestExpectations:
2:07 PM Changeset in webkit [134111] by danakj@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Define WEBKIT_IMPLEMENTATION everywhere inside WebCore
https://bugs.webkit.org/show_bug.cgi?id=101795

Reviewed by James Robinson.

  • WebCore.gyp/WebCore.gyp:
2:00 PM Changeset in webkit [134110] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening, failing new hidpi tests in r134099/r134100

  • platform/chromium/TestExpectations:
1:53 PM Changeset in webkit [134109] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/Source/WebKit2

Merged r126490. <rdar://problem/12516330>

1:53 PM Changeset in webkit [134108] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, last few chromium-mac-mountainlion expectations cleaned up.

  • platform/chromium/TestExpectations:
1:50 PM Changeset in webkit [134107] by Lucas Forschler
  • 4 edits
    2 adds in branches/safari-536.28-branch

Merged r1164161. WebKit r126251. <rdar://problem/12536470>

1:43 PM Changeset in webkit [134106] by Lucas Forschler
  • 11 edits in branches/safari-536.28-branch/Source/WebCore

Merged r1164159. WebKit r126048. <rdar://problem/12536470>

1:42 PM Changeset in webkit [134105] by jsbell@chromium.org
  • 11 edits
    1 copy in trunk/Source

Unreviewed, rolling out r134101.
http://trac.webkit.org/changeset/134101
https://bugs.webkit.org/show_bug.cgi?id=101790

IDBDatabaseBackendTest.BackingStoreRetention failing
(Requested by jsbell|gardener on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-09

Source/WebCore:

  • GNUmakefile.list.am:
  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
(WebCore::IDBLevelDBBackingStore::~IDBLevelDBBackingStore):
(WebCore::IDBLevelDBBackingStore::open):
(WebCore::IDBLevelDBBackingStore::getDatabaseNames):
(WebCore::IDBLevelDBBackingStore::getIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::createIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseIntVersion):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseMetaData):
(WebCore::IDBLevelDBBackingStore::deleteDatabase):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::IDBLevelDBBackingStore::deleteObjectStore):
(WebCore::IDBLevelDBBackingStore::getRecord):
(WebCore):
(WebCore::IDBLevelDBBackingStore::putRecord):
(WebCore::IDBLevelDBBackingStore::clearObjectStore):
(WebCore::IDBLevelDBBackingStore::createInvalidRecordIdentifier):
(WebCore::IDBLevelDBBackingStore::deleteRecord):
(WebCore::IDBLevelDBBackingStore::getKeyGeneratorCurrentNumber):
(WebCore::IDBLevelDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBLevelDBBackingStore::getIndexes):
(WebCore::IDBLevelDBBackingStore::createIndex):
(WebCore::IDBLevelDBBackingStore::deleteIndex):
(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
(WebCore::IDBLevelDBBackingStore::deleteIndexDataForRecord):
(WebCore::IDBLevelDBBackingStore::findKeyInIndex):
(WebCore::IDBLevelDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBLevelDBBackingStore::keyExistsInIndex):
(WebCore::IDBLevelDBBackingStore::openObjectStoreCursor):
(WebCore::IDBLevelDBBackingStore::openObjectStoreKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexKeyCursor):
(WebCore::IDBLevelDBBackingStore::openIndexCursor):
(WebCore::IDBLevelDBBackingStore::createTransaction):
(WebCore::IDBLevelDBBackingStore::Transaction::create):
(WebCore::IDBLevelDBBackingStore::Transaction::Transaction):
(WebCore::IDBLevelDBBackingStore::Transaction::begin):
(WebCore::IDBLevelDBBackingStore::Transaction::commit):
(WebCore::IDBLevelDBBackingStore::Transaction::rollback):
(WebCore::IDBLevelDBBackingStore::backingStoreExists):

  • Modules/indexeddb/IDBBackingStore.h:

(WebCore):
(WebCore::IDBBackingStore::~IDBBackingStore):
(IDBBackingStore):
(RecordIdentifier):
(WebCore::IDBBackingStore::Cursor::~Cursor):
(WebCore::IDBBackingStore::Transaction::~Transaction):
(Transaction):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::openBackingStore):

  • Modules/indexeddb/IDBLevelDBBackingStore.h: Copied from Source/WebCore/Modules/indexeddb/IDBBackingStore.h.

(WebCore):
(IDBLevelDBBackingStore):
(Transaction):
(WebCore::IDBLevelDBBackingStore::Transaction::levelDBTransactionFrom):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::commit):
(WebCore::IDBTransactionBackendImpl::taskTimerFired):

  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(WebCore::IDBTransactionBackendImpl::backingStoreTransaction):

  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

  • tests/IDBFakeBackingStore.h:
1:29 PM Changeset in webkit [134104] by dpranke@chromium.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Unreviewed, baselines change - remove stray baselines for reftests.

  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/text-on-scaled-layer-expected.png: Removed.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/text-on-scaled-surface-expected.png: Removed.
1:25 PM Changeset in webkit [134103] by Lucas Forschler
  • 10 edits in branches/safari-536.28-branch/Source/WebCore

Merged r1164158. WebKit r125737. <rdar://problem/12536470>

12:54 PM Changeset in webkit [134102] by arv@chromium.org
  • 4 edits
    2 adds in trunk

REGRESSION (r125239): classList contains() doesn't work after element was moved from strict mode document to quirks mode document
https://bugs.webkit.org/show_bug.cgi?id=101627

Reviewed by Alexey Proskuryakov.

We used to only create m_classNamesForQuirksMode in the constructor or when the class attribute
was changed. If an element is moved from a standards document to a quirks mode document the
m_classNamesForQuirksMode would not be up to date which lead to wrong results.

Now we alway check if m_classNamesForQuirksMode is up to date (in quirks mode only).

Source/WebCore:

Test: fast/dom/Element/class-list-move-between-document-with-different-quirks-mode.html

  • html/ClassList.cpp:

(WebCore::ClassList::classNames): Create the m_classNamesForQuirksMode lazily as needed so that

it is up to date.

  • html/ClassList.h:

LayoutTests:

  • fast/dom/Element/class-list-move-between-document-with-different-quirks-mode-expected.txt: Added.
  • fast/dom/Element/class-list-move-between-document-with-different-quirks-mode.html: Added.
12:47 PM Changeset in webkit [134101] by alecflett@chromium.org
  • 11 edits
    1 delete in trunk/Source

IndexedDB: Combine IDBBackingStore and IDBLevelDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=101415

Reviewed by Tony Chang.

Source/WebCore:

Combine abstract interface IDBBackingStore with its only
implementation, IDBLevelDBBackingStore, to reduce code
complexity. The legacy structure existed to support a SQLLite
IDBBackingStore, but it is no longer worth the complexity to
support this abstraction.

Changes include:
1) Merging IDBLevelDBBackingStore into IDBBackingStore.

2) Merge together IDBBackingStore's inner classes: Cursor,
Transaction, and ObjectStoreRecordIdentfier with their respective
subclasses in IDBLevelDBBackingStore.

3) Simplifying the inner Transaction class to not be refcounted or
virtualized, to allow it to be a simple concrete member of its
owner, IDBTransactionBackendImpl.

No new tests as this is purely a refactor.

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::recordInternalError):
(WebCore::setUpMetadata):
(WebCore::IDBBackingStore::IDBBackingStore):
(WebCore):
(WebCore::IDBBackingStore::~IDBBackingStore):
(WebCore::IDBBackingStore::open):
(WebCore::IDBBackingStore::getDatabaseNames):
(WebCore::IDBBackingStore::getIDBDatabaseMetaData):
(WebCore::IDBBackingStore::createIDBDatabaseMetaData):
(WebCore::IDBBackingStore::updateIDBDatabaseIntVersion):
(WebCore::IDBBackingStore::updateIDBDatabaseMetaData):
(WebCore::deleteRange):
(WebCore::IDBBackingStore::deleteDatabase):
(WebCore::IDBBackingStore::getObjectStores):
(WebCore::setMaxObjectStoreId):
(WebCore::IDBBackingStore::createObjectStore):
(WebCore::IDBBackingStore::deleteObjectStore):
(WebCore::IDBBackingStore::getRecord):
(WebCore::IDBBackingStore::putRecord):
(WebCore::IDBBackingStore::clearObjectStore):
(WebCore::IDBBackingStore::deleteRecord):
(WebCore::IDBBackingStore::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBBackingStore::getIndexes):
(WebCore::setMaxIndexId):
(WebCore::IDBBackingStore::createIndex):
(WebCore::IDBBackingStore::deleteIndex):
(WebCore::IDBBackingStore::putIndexDataForRecord):
(WebCore::IDBBackingStore::deleteIndexDataForRecord):
(WebCore::IDBBackingStore::findKeyInIndex):
(WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStore::keyExistsInIndex):
(WebCore::IDBBackingStore::Cursor::Cursor):
(WebCore::IDBBackingStore::Cursor::firstSeek):
(WebCore::IDBBackingStore::Cursor::advance):
(WebCore::IDBBackingStore::Cursor::continueFunction):
(WebCore::IDBBackingStore::Cursor::haveEnteredRange):
(WebCore::IDBBackingStore::Cursor::isPastBounds):
(WebCore::ObjectStoreKeyCursorImpl::create):
(ObjectStoreKeyCursorImpl):
(WebCore::ObjectStoreKeyCursorImpl::value):
(WebCore::ObjectStoreKeyCursorImpl::ObjectStoreKeyCursorImpl):
(WebCore::ObjectStoreKeyCursorImpl::loadCurrentRow):
(WebCore::ObjectStoreCursorImpl::create):
(ObjectStoreCursorImpl):
(WebCore::ObjectStoreCursorImpl::value):
(WebCore::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
(WebCore::ObjectStoreCursorImpl::loadCurrentRow):
(WebCore::IndexKeyCursorImpl::create):
(IndexKeyCursorImpl):
(WebCore::IndexKeyCursorImpl::value):
(WebCore::IndexKeyCursorImpl::primaryKey):
(WebCore::IndexKeyCursorImpl::recordIdentifier):
(WebCore::IndexKeyCursorImpl::IndexKeyCursorImpl):
(WebCore::IndexKeyCursorImpl::loadCurrentRow):
(WebCore::IndexCursorImpl::create):
(IndexCursorImpl):
(WebCore::IndexCursorImpl::value):
(WebCore::IndexCursorImpl::primaryKey):
(WebCore::IndexCursorImpl::recordIdentifier):
(WebCore::IndexCursorImpl::IndexCursorImpl):
(WebCore::IndexCursorImpl::loadCurrentRow):
(WebCore::objectStoreCursorOptions):
(WebCore::indexCursorOptions):
(WebCore::IDBBackingStore::openObjectStoreCursor):
(WebCore::IDBBackingStore::openObjectStoreKeyCursor):
(WebCore::IDBBackingStore::openIndexKeyCursor):
(WebCore::IDBBackingStore::openIndexCursor):
(WebCore::IDBBackingStore::Transaction::Transaction):
(WebCore::IDBBackingStore::Transaction::begin):
(WebCore::IDBBackingStore::Transaction::commit):
(WebCore::IDBBackingStore::Transaction::rollback):

  • Modules/indexeddb/IDBBackingStore.h:

(WebCore):
(IDBBackingStore):
(RecordIdentifier):
(WebCore::IDBBackingStore::RecordIdentifier::create):
(WebCore::IDBBackingStore::RecordIdentifier::~RecordIdentifier):
(WebCore::IDBBackingStore::RecordIdentifier::isValid):
(WebCore::IDBBackingStore::RecordIdentifier::primaryKey):
(WebCore::IDBBackingStore::RecordIdentifier::setPrimaryKey):
(WebCore::IDBBackingStore::RecordIdentifier::version):
(WebCore::IDBBackingStore::RecordIdentifier::setVersion):
(WebCore::IDBBackingStore::RecordIdentifier::RecordIdentifier):
(Transaction):
(WebCore::IDBBackingStore::Transaction::levelDBTransactionFrom):
(CursorOptions):
(Cursor):
(WebCore::IDBBackingStore::Cursor::Cursor):
(WebCore::IDBBackingStore::Cursor::key):
(WebCore::IDBBackingStore::Cursor::primaryKey):
(WebCore::IDBBackingStore::Cursor::~Cursor):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::openBackingStore):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::countInternal):

  • Modules/indexeddb/IDBLevelDBBackingStore.h: Removed.
  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::commit):
(WebCore::IDBTransactionBackendImpl::taskTimerFired):

  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(WebCore::IDBTransactionBackendImpl::backingStoreTransaction):

  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

Remove method that is no longer in the base class.

  • tests/IDBFakeBackingStore.h:
12:39 PM Changeset in webkit [134100] by timothy@apple.com
  • 10 edits
    3 adds in trunk

Source/WebCore: Make -webkit-canvas in CSS use the full backing store instead
of always 1x when rendering.

https://bugs.webkit.org/show_bug.cgi?id=100611

Reviewed by Dean Jackson.

Test: fast/canvas/canvas-as-image-hidpi.html

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::makePresentationCopy): Pass Unscaled to copyImage.
(WebCore::HTMLCanvasElement::copiedImage): Ditto.

  • platform/graphics/ImageBuffer.h:
  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::copyImage): Added Scale parameter and use copyNativeImage for Unscaled.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::copyImage): Added unnamed ScaleBehavior parameter.

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::copyImage): Ditto.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::copyImage): Ditto.

  • platform/graphics/wince/ImageBufferWinCE.cpp:

(WebCore::ImageBuffer::copyImage): Ditto.

  • platform/graphics/wx/ImageBufferWx.cpp:

(WebCore::ImageBuffer::copyImage): Ditto.

LayoutTests: Test if -webkit-canvas in CSS uses the full backing store instead
of always 1x when rendering.

https://bugs.webkit.org/show_bug.cgi?id=100611

Reviewed by Dean Jackson.

  • fast/canvas/canvas-as-image-hidpi-expected.png: Added.
  • fast/canvas/canvas-as-image-hidpi-expected.txt: Added.
  • fast/canvas/canvas-as-image-hidpi.html: Added.
12:39 PM Changeset in webkit [134099] by timothy@apple.com
  • 4 edits
    2 adds in trunk

Source/WebCore: Reset the canvas backing store pixel ratio when the buffer resizes.

The backing store was not being recreated using the current page pixel ratio
when a resize occurred.

https://bugs.webkit.org/show_bug.cgi?id=100608

Reviewed by Darin Adler.

Test: fast/canvas/canvas-resize-reset-pixelRatio.html

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement): Use targetDeviceScaleFactor.
(WebCore::HTMLCanvasElement::reset): Do a clear only if the pixel ratios also
match. Store the new pixel ratio in m_deviceScaleFactor.
(WebCore::HTMLCanvasElement::targetDeviceScaleFactor): Added.

  • html/HTMLCanvasElement.h:

(WebCore::HTMLCanvasElement::setSize): Return early only if the sizes and
pixel ratios match.

LayoutTests: Test the canvas backing store pixel ratio when the buffer resizes.

https://bugs.webkit.org/show_bug.cgi?id=100608

Reviewed by Darin Adler.

  • fast/canvas/canvas-resize-reset-pixelRatio-expected.txt: Added.
  • fast/canvas/canvas-resize-reset-pixelRatio.html: Added.
12:30 PM Changeset in webkit [134098] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2][AC] Fixed layers are shaking when scrolling
https://bugs.webkit.org/show_bug.cgi?id=101549

Patch by Hurnjoo Lee <hurnjoo.lee@samsung.com> on 2012-11-09
Reviewed by Kenneth Rohde Christiansen.

At the time of adjusting positions for fixed layers, the locations of
fixed layers are calculated incorrectly because the contentsSize is empty.

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::didChangeContentsSize): Call the
setContentsSize function in LayerTreeCoordinatorProxy in order to calculate
the locations of fixed layers correctly.

12:16 PM Changeset in webkit [134097] by rniwa@webkit.org
  • 2 edits in trunk/Tools

People with dichromacy can't tell crashes and passes on flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=101711

Reviewed by Ojan Vafai.

Lower the brightness of orange, and raise the brightness of green so that
people with color blindnes can still distinguish passes and crashes easily.

  • TestResultServer/static-dashboards/flakiness_dashboard_tests.css:

(.P):
(.C):

12:10 PM Changeset in webkit [134096] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

RemoveFormat command doesn't remove background color
https://bugs.webkit.org/show_bug.cgi?id=101682

Reviewed by Tony Chang.

Source/WebCore:

Fixed the bug by removing all non-transparent background-color properties.

Test: editing/execCommand/remove-format-background-color.html

  • editing/RemoveFormatCommand.cpp:

(WebCore::RemoveFormatCommand::doApply):

LayoutTests:

Added a regression test.

  • editing/execCommand/remove-format-background-color-expected.txt: Added.
  • editing/execCommand/remove-format-background-color.html: Added.
11:55 AM Changeset in webkit [134095] by alecflett@chromium.org
  • 32 edits in trunk/Source

IndexedDB: switch frontend to use int64_t-based references
https://bugs.webkit.org/show_bug.cgi?id=100426

Reviewed by Tony Chang.

Source/WebCore:

Remove String-based objectStore/index references, obsoleted by
https://bugs.webkit.org/show_bug.cgi?id=100425.

No new tests as this is the second half of a refactor.

  • Modules/indexeddb/IDBCallbacks.h:
  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBMetadata.h:

(WebCore::IDBObjectStoreMetadata::findIndex):
(IDBObjectStoreMetadata):
(WebCore::IDBObjectStoreMetadata::containsIndex):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put):
(WebCore):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h:
  • inspector/Inspector-1.0.json:
  • inspector/Inspector.json:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):
(WebCore::InspectorIndexedDBAgent::requestData):

  • inspector/InspectorIndexedDBAgent.h:

(InspectorIndexedDBAgent):

Source/WebKit/chromium:

Remove implementation stubs from chromium API for
methods obsoleted by https://bugs.webkit.org/show_bug.cgi?id=100425

  • src/IDBObjectStoreBackendProxy.cpp:
  • src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:
  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • src/WebIDBObjectStoreImpl.cpp:
  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

11:47 AM Changeset in webkit [134094] by mario@webkit.org
  • 3 edits in trunk/Source/WebCore

[GTK] Isolate the GTK/Gail/Pango specific code in accessibility/gtk
https://bugs.webkit.org/show_bug.cgi?id=101727

Reviewed by Chris Fleizach.

Added conditional compilation checks for GTK+ specific
accessibility code, to pave the way for sharing this
implementation with other ports (e.g WebKitEFL).

  • accessibility/gtk/WebKitAccessibleInterfaceText.cpp:

(webkitAccessibleTextGetTextAfterOffset): Added conditional
compilation checks, only implementing it in GTK so far.
(webkitAccessibleTextGetTextAtOffset): Ditto.
(webkitAccessibleTextGetTextBeforeOffset): Ditto.

  • accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:

(atkParentOfRootObject): Added conditional compilation checks,
only implementing in GTK the part of getting the accessible object
for the root object.
(webkitAccessibleGetParent): Updated comments.
(webkitAccessibleGetNChildren): Ditto.
(webkitAccessibleRefChild): Ditto.
(webkitAccessibleGetIndexInParent): Ditto.
(webkitAccessibleGetAttributes): Only set the 'toolkit' attribute
for GTK. Other ports might be interested in this too.
(setAtkStateSetFromCoreObject): Updated comments.

11:39 AM Changeset in webkit [134093] by tommyw@google.com
  • 2 edits in trunk/Source/WebCore

MediaStream API: Don't trigger any object deletion during RTCPeerConnection::stop
https://bugs.webkit.org/show_bug.cgi?id=101586

Reviewed by Adam Barth.

Stop calling stop on the RTCPeerConnectionHandler, and don't delete it, when
ActiveDOMObject::stop is called on RTCPeerConnection. Due to the async nature of the new
API some WebCore objects might be cleaned away which is not allowed at this stage.

This behaviour is not possible to test unfortunately in webkit.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::stop):

11:32 AM Changeset in webkit [134092] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2012-11-09 Oliver Hunt <oliver@apple.com>

So Thingy probably isn't the best name for a class, so
renamed to CacheMap.

RS=Geoff

  • runtime/CodeCache.h: (JSC::CacheMap::CacheMap):
11:27 AM Changeset in webkit [134091] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Unreviewed gardening. Fix chromium-win builds following r134082

  • WebCore.gypi:
11:15 AM Changeset in webkit [134090] by beidson@apple.com
  • 3 edits in trunk/Source/WebKit2

NetworkRequest refactoring
https://bugs.webkit.org/show_bug.cgi?id=101777

Reviewed by Alexey Proskuryakov.

Move all of the ResourceHandleClient stubs from the .h to the .cpp in one patch
to make future patches cleaner.

Also completely remove the declaration for shouldCacheResponse() for now.

  • NetworkProcess/NetworkRequest.cpp:

(WebKit::NetworkRequest::willSendRequest):
(WebKit::NetworkRequest::didSendData):
(WebKit::NetworkRequest::didReceiveCachedMetadata):
(WebKit::NetworkRequest::wasBlocked):
(WebKit::NetworkRequest::cannotShowURL):
(WebKit::NetworkRequest::willCacheResponse):
(WebKit::NetworkRequest::shouldUseCredentialStorage):
(WebKit::NetworkRequest::didReceiveAuthenticationChallenge):
(WebKit::NetworkRequest::didCancelAuthenticationChallenge):
(WebKit::NetworkRequest::receivedCancellation):
(WebKit::NetworkRequest::canAuthenticateAgainstProtectionSpace):
(WebKit::NetworkRequest::supportsDataArray):
(WebKit::NetworkRequest::didReceiveDataArray):
(WebKit::NetworkRequest::willStopBufferingData):
(WebKit::NetworkRequest::createAsyncFileStream):

  • NetworkProcess/NetworkRequest.h:
11:10 AM Changeset in webkit [134089] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebCore

[V8] Remove ScriptController::windowShell()
https://bugs.webkit.org/show_bug.cgi?id=100235

Patch by Dan Carney <dcarney@google.com> on 2012-11-09
Reviewed by Adam Barth.

Refactored windowShell(DOMWrapperWorld*) and
existingWindowShell(DOMWrapperWorld*) to be like JSC.

No new tests. No change in functionality.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateToV8Converters):

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::isolatedWorldMap):
(WebCore::DOMWrapperWorld::getAllWorlds):
(WebCore):

  • bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):

  • bindings/v8/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::clearForOutOfMemory):
(WebCore):
(WebCore::ScriptController::clearForClose):
(WebCore::ScriptController::updateSecurityOrigin):
(WebCore::ScriptController::initializeMainWorld): Returns true if the main world was initialized.
(WebCore::existingWindowShellWorkaroundWorld):
(WebCore::ScriptController::existingWindowShell):
(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):
(WebCore::ScriptController::mainWorldContext):
(WebCore::ScriptController::haveInterpreter):
(WebCore::ScriptController::enableEval):
(WebCore::ScriptController::disableEval):
(WebCore::ScriptController::clearWindowShell):
(WebCore::ScriptController::setContextDebugId):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::namedItemAdded):
(WebCore::ScriptController::namedItemRemoved):

  • bindings/v8/ScriptController.h:

(ScriptController):
(WebCore::ScriptController::getAllWorlds):

  • bindings/v8/V8Binding.cpp:

(WebCore::perContextDataForCurrentWorld):
(WebCore::handleOutOfMemory):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::updateDocument):
(WebCore::V8DOMWindowShell::namedItemAdded):
(WebCore::V8DOMWindowShell::namedItemRemoved):

  • bindings/v8/V8DOMWindowShell.h:

(WebCore::V8DOMWindowShell::isContextInitialized):
(WebCore::V8DOMWindowShell::isGlobalInitialized):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::toV8):

11:07 AM Changeset in webkit [134088] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-536.28-branch

Merged r125635. <rdar://problem/12536426>

10:56 AM Changeset in webkit [134087] by zandobersek@gmail.com
  • 30 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining and removing stale expectations after the Cairo
version used in Jhbuild modules was bumped to 1.12.8 in r134073.

  • platform/gtk/TestExpectations:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-01-t-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • platform/gtk/svg/batik/text/smallFonts-expected.png:
  • platform/gtk/svg/batik/text/smallFonts-expected.txt:
  • platform/gtk/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
  • platform/gtk/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/gtk/svg/batik/text/textOnPath-expected.png:
  • platform/gtk/svg/batik/text/textOnPath-expected.txt:
  • platform/gtk/svg/batik/text/textOnPath2-expected.png:
  • platform/gtk/svg/batik/text/textOnPath2-expected.txt:
  • platform/gtk/svg/batik/text/textOnPath3-expected.png:
  • platform/gtk/svg/batik/text/textOnPath3-expected.txt:
  • platform/gtk/svg/batik/text/textOnPathSpaces-expected.png:
  • platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/gtk/svg/batik/text/verticalTextOnPath-expected.png:
  • platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt:
  • platform/gtk/svg/custom/js-update-path-changes-expected.png:
  • platform/gtk/svg/custom/js-update-path-changes-expected.txt:
  • platform/gtk/svg/custom/js-update-path-removal-expected.png:
  • platform/gtk/svg/custom/js-update-path-removal-expected.txt:
  • platform/gtk/svg/custom/path-textPath-simulation-expected.png:
  • platform/gtk/svg/custom/path-textPath-simulation-expected.txt:
10:55 AM Changeset in webkit [134086] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

[V8] Remove a level of indirection in DOMDataStore
https://bugs.webkit.org/show_bug.cgi?id=101690

Reviewed by Kentaro Hara.

There is no longer any reason for the DOMDataStore to hold the wrapper
map via a pointer. It can just hold the wrapper map directly, saving a
level of indirection. I doubt this has any measurable performance gain.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::~DOMDataStore):
(WebCore::DOMDataStore::reportMemoryUsage):

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::get):
(WebCore::DOMDataStore::set):
(DOMDataStore):

10:24 AM Changeset in webkit [134085] by mihnea@adobe.com
  • 3 edits
    2 adds in trunk

[CSSRegions] Region styling properties are not filtered correctly
https://bugs.webkit.org/show_bug.cgi?id=101768

Reviewed by Andreas Kling.

Source/WebCore:

Region styling allows only a handful of css properties. There is a mechanism in place,
in StyleResolver::isValidRegionStyleProperty that filters the supported region style properties.
In order to be effective, this mechanism relies on RuleData::m_isInRegionRule being set correctly.
This patch makes sure that the flag RuleData::m_isInRegionRule is set properly in RuleData constructor.

Test: fast/regions/region-style-not-supported-properties.html

  • css/RuleSet.cpp:

(WebCore::RuleData::RuleData):

LayoutTests:

Visibility is not a supported region style property, therefore using it inside @-webkit-region
should not be possible.

  • fast/regions/region-style-not-supported-properties-expected.html: Added.
  • fast/regions/region-style-not-supported-properties.html: Added.
10:22 AM Changeset in webkit [134084] by tommyw@google.com
  • 31 edits
    65 deletes in trunk

MediaStream API: Deleting all files relating to the deprecated PeerConnection00
https://bugs.webkit.org/show_bug.cgi?id=101730

Reviewed by Adam Barth.

Since RTCPeerConenction has superseeded PeerConnection00 this patch removes all
files relating to the old API.

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):

  • chromium/public/WebICECandidateDescriptor.h: Removed.
  • chromium/public/WebICEOptions.h: Removed.
  • chromium/public/WebMediaHints.h: Removed.
  • chromium/public/WebMediaStreamCenter.h:

(WebKit):
(WebMediaStreamCenter):

  • chromium/public/WebPeerConnection00Handler.h: Removed.
  • chromium/public/WebPeerConnection00HandlerClient.h: Removed.
  • chromium/public/WebPeerConnectionHandler.h: Removed.
  • chromium/public/WebPeerConnectionHandlerClient.h: Removed.
  • chromium/public/WebSessionDescriptionDescriptor.h: Removed.

Source/WebCore:

No testing needed, the remaining tests makes sure that nothing else breaks.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/DOMWindowMediaStream.idl:
  • Modules/mediastream/IceCallback.h: Removed.
  • Modules/mediastream/IceCallback.idl: Removed.
  • Modules/mediastream/IceCandidate.cpp: Removed.
  • Modules/mediastream/IceCandidate.h: Removed.
  • Modules/mediastream/IceCandidate.idl: Removed.
  • Modules/mediastream/PeerConnection00.cpp: Removed.
  • Modules/mediastream/PeerConnection00.h: Removed.
  • Modules/mediastream/PeerConnection00.idl: Removed.
  • Modules/mediastream/SessionDescription.cpp: Removed.
  • Modules/mediastream/SessionDescription.h: Removed.
  • Modules/mediastream/SessionDescription.idl: Removed.
  • WebCore.gypi:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):

  • dom/EventTargetFactory.in:
  • platform/chromium/support/WebICECandidateDescriptor.cpp: Removed.
  • platform/chromium/support/WebICEOptions.cpp: Removed.
  • platform/chromium/support/WebMediaHints.cpp: Removed.
  • platform/mediastream/IceCandidateDescriptor.cpp: Removed.
  • platform/mediastream/IceCandidateDescriptor.h: Removed.
  • platform/mediastream/IceOptions.cpp: Removed.
  • platform/mediastream/IceOptions.h: Removed.
  • platform/mediastream/MediaHints.cpp: Removed.
  • platform/mediastream/MediaHints.h: Removed.
  • platform/mediastream/MediaStreamCenter.h:

(WebCore):
(MediaStreamCenter):

  • platform/mediastream/PeerConnection00Handler.cpp: Removed.
  • platform/mediastream/PeerConnection00Handler.h: Removed.
  • platform/mediastream/PeerConnection00HandlerClient.h: Removed.
  • platform/mediastream/SessionDescriptionDescriptor.cpp: Removed.
  • platform/mediastream/SessionDescriptionDescriptor.h: Removed.
  • platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:
  • platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:

(WebCore):
(MediaStreamCenterBlackBerry):

  • platform/mediastream/chromium/MediaStreamCenterChromium.cpp:
  • platform/mediastream/chromium/MediaStreamCenterChromium.h:

(WebCore):
(MediaStreamCenterChromium):

  • platform/mediastream/chromium/PeerConnection00Handler.cpp: Removed.
  • platform/mediastream/chromium/PeerConnection00HandlerInternal.cpp: Removed.
  • platform/mediastream/chromium/PeerConnection00HandlerInternal.h: Removed.
  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:

(WebCore):
(MediaStreamCenterGStreamer):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • public/platform/WebICECandidateDescriptor.h: Removed.
  • public/platform/WebICEOptions.h: Removed.
  • public/platform/WebMediaHints.h: Removed.
  • public/platform/WebPeerConnection00Handler.h: Removed.
  • public/platform/WebPeerConnection00HandlerClient.h: Removed.
  • public/platform/WebPeerConnectionHandler.h: Removed.
  • public/platform/WebPeerConnectionHandlerClient.h: Removed.
  • public/platform/WebSessionDescriptionDescriptor.h: Removed.
  • src/AssertMatchingEnums.cpp:
  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::isPeerConnectionEnabled):

  • src/WebSessionDescriptionDescriptor.cpp: Removed.

Tools:

  • DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
  • DumpRenderTree/chromium/MockWebMediaStreamCenter.h:

(MockWebMediaStreamCenter):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

LayoutTests:

  • fast/mediastream/SessionDescription-expected.txt: Removed.
  • fast/mediastream/SessionDescription.html: Removed.
  • fast/mediastream/constructors-expected.txt:
  • fast/mediastream/constructors.html:
  • fast/mediastream/peerconnection-Attributes-expected.txt: Removed.
  • fast/mediastream/peerconnection-Attributes.html: Removed.
  • fast/mediastream/peerconnection-addstream-expected.txt: Removed.
  • fast/mediastream/peerconnection-addstream.html: Removed.
  • fast/mediastream/peerconnection-argument-types-expected.txt: Removed.
  • fast/mediastream/peerconnection-argument-types.html: Removed.
  • fast/mediastream/peerconnection-eventlistener-optional-argument-expected.txt: Removed.
  • fast/mediastream/peerconnection-eventlistener-optional-argument.html: Removed.
  • fast/mediastream/peerconnection-iceoptions-expected.txt: Removed.
  • fast/mediastream/peerconnection-iceoptions.html: Removed.
  • fast/mediastream/peerconnection-mediastreamlist-expected.txt: Removed.
  • fast/mediastream/peerconnection-mediastreamlist.html: Removed.
  • fast/mediastream/peerconnection-removestream-expected.txt: Removed.
  • fast/mediastream/peerconnection-removestream.html: Removed.
  • fast/mediastream/script-tests/peerconnection-Attributes.js: Removed.
  • fast/mediastream/script-tests/peerconnection-addstream.js: Removed.
  • fast/mediastream/script-tests/peerconnection-argument-types.js: Removed.
  • fast/mediastream/script-tests/peerconnection-removestream.js: Removed.
10:16 AM Changeset in webkit [134083] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

Plugin diagnostic logging should send plugin file basename instead of MIME type.
https://bugs.webkit.org/show_bug.cgi?id=101679

Reviewed by Eric Carlson.

Log the basename of the plugin file rather than the mime type so as to more
accurately log which plugin was used to handle the request.

  • loader/SubframeLoader.cpp:

(WebCore::logPluginRequest): Log the plugin 'file' field, if present.

  • plugins/PluginData.cpp:

(WebCore::PluginData::pluginInfoForMimeType): Factored out from pluginNameForMimeType.
(WebCore::PluginData::pluginNameForMimeType): Use pluginInfoForMimeType to retrieve name field.
(WebCore::PluginData::pluginFileForMimeType): Use pluginInfoForMimeType to retrieve file field.

  • plugins/PluginData.h:
10:08 AM Changeset in webkit [134082] by ap@apple.com
  • 16 edits
    1 copy
    6 moves
    1 add in trunk/Source

CookieJar uses Document class, which is a layering violation
https://bugs.webkit.org/show_bug.cgi?id=101621

Reviewed by Brady Eidson.

Source/WebCore:

Split CookieJar in two parts, one that takes a Document, and another that is a pure
platform one, using NetworkingContext to access the correct platform storage.

  • GNUmakefile.list.am:
  • PlatformBlackBerry.cmake:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Updated.

  • loader/CookieJar.cpp: Added.

(WebCore::networkingContext):
(WebCore::cookies):
(WebCore::setCookies):
(WebCore::cookiesEnabled):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):

  • loader/CookieJar.h: Copied from Source/WebCore/platform/CookieJar.h.

This is an adaptor for pure platform implementations. Clients continue to use the
old interface unchanged.

  • platform/blackberry/CookieJarBlackBerry.cpp: Removed.
  • loader/blackberry/CookieJarBlackBerry.cpp: Copied from Source/WebCore/platform/blackberry/CookieJarBlackBerry.cpp.
  • platform/network/chromium/CookieJarChromium.cpp: Removed.
  • loader/chromium/CookieJarChromium.cpp: Copied from Source/WebCore/platform/network/chromium/CookieJarChromium.cpp.

These platforms do not have a pure platform implementation yet, so they just keep
to use original implementations. Since the code is not in platform/ any more, the
violation is resolved for Chromium and Blackberry, too.

  • platform/CookieJar.h: Removed.
  • platform/network/PlatformCookieJar.h: Copied from Source/WebCore/platform/CookieJar.h.

The platform interface is now more uniform - all functions take a NetworkingContext
instead of hardcoding which cookie storage to use in some cases.
Renamed functions that are only useful for document.cookie implementation to look
less generic.

  • platform/mac/CookieJar.mm: Removed.
  • platform/network/mac/CookieJarMac.mm: Copied from Source/WebCore/platform/mac/CookieJar.mm.

(WebCore::cookiesForDOM): This now takes a context instead of Document, and also
takes a firstParty URL (unused on Mac, but used on some other platforms).
(WebCore::cookieRequestHeaderFieldValue): Get cookie storage from context (and
use shared one if context is null).
(WebCore::setCookiesFromDOM): Ditto.
(WebCore::cookiesEnabled): Ditto.
(WebCore::getRawCookies): Ditto.
(WebCore::deleteCookie): Ditto.
(WebCore::getHostnamesWithCookies): Ditto. This used to only support default storage,
but its cleaner to have a uniform interface.
(WebCore::deleteCookiesForHostname): Ditto.
(WebCore::deleteAllCookies): Ditto.

  • platform/network/cf/CookieJarCFNet.cpp:

Same changes as on Mac.

  • platform/network/curl/CookieJarCurl.cpp:

Updated for new interface. Implementation is largely a dummy one.

  • platform/qt/CookieJarQt.h: Removed.
  • platform/network/qt/CookieJarQt.h: Copied from Source/WebCore/platform/qt/CookieJarQt.h.

Moved to a common location, most cookie files were in network/ already.

  • platform/qt/CookieJarQt.cpp: Removed.
  • platform/network/qt/CookieJarQt.cpp: Copied from Source/WebCore/platform/qt/CookieJarQt.cpp.

(WebCore::setCookiesFromDOM): Use context's or shared cooke jar as appropriate.
(WebCore::cookiesForDOM): Ditto.
(WebCore::cookieRequestHeaderFieldValue): Ditto.
(WebCore::cookiesEnabled): Ditto.
(WebCore::getRawCookies): Ditto.
(WebCore::deleteCookie): Ditto.
(WebCore::getHostnamesWithCookies): Back-end implementation can only handle shared
jar here, assert that argument does not request another one.
(WebCore::deleteCookiesForHostname): Ditto.
(WebCore::deleteAllCookies): Ditto.

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::cookieJarForContext):
(WebCore::setCookiesFromDOM):
(WebCore::cookiesForContext):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):
Updated for new function signatures, and use the same cross-platform logic for
choosing a cookie jar.

  • platform/network/soup/CookieJarSoup.h: Don't include unnecessary CooieJar.h.
  • platform/network/win/CookieJarWin.cpp:

(WebCore::setCookiesFromDOM):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):
Updated for new function signatures.

Source/WebKit2:

  • UIProcess/API/C/WKAPICast.h: Don't include CookieJar.h, its completely unnecessary.
10:04 AM Changeset in webkit [134081] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

ArrayPrototype should start out with a blank indexing type
https://bugs.webkit.org/show_bug.cgi?id=101719

Reviewed by Mark Hahnenberg.

This allows us to track if the array prototype ever ends up with indexed
properties.

  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::create):
(JSC::ArrayPrototype::ArrayPrototype):

  • runtime/ArrayPrototype.h:

(ArrayPrototype):
(JSC::ArrayPrototype::createStructure):

9:58 AM Changeset in webkit [134080] by mhahnenberg@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

MarkStackArray should use the BlockAllocator instead of the MarkStackSegmentAllocator
https://bugs.webkit.org/show_bug.cgi?id=101642

Reviewed by Filip Pizlo.

MarkStackSegmentAllocator is like a miniature version of the BlockAllocator. Now that the BlockAllocator has support
for a variety of block sizes, we should get rid of the MarkStackSegmentAllocator in favor of the BlockAllocator.

  • heap/BlockAllocator.h: Add new specializations of regionSetFor for the new MarkStackSegments.

(JSC):
(JSC::MarkStackSegment):

  • heap/GCThreadSharedData.cpp:

(JSC::GCThreadSharedData::GCThreadSharedData):
(JSC::GCThreadSharedData::reset):

  • heap/GCThreadSharedData.h:

(GCThreadSharedData):

  • heap/MarkStack.cpp:

(JSC::MarkStackArray::MarkStackArray): We now have a doubly linked list of MarkStackSegments, so we need to refactor
all the places that used the old custom tail/previous logic.
(JSC::MarkStackArray::~MarkStackArray):
(JSC::MarkStackArray::expand):
(JSC::MarkStackArray::refill):
(JSC::MarkStackArray::donateSomeCellsTo): Refactor to use the new linked list.
(JSC::MarkStackArray::stealSomeCellsFrom): Ditto.

  • heap/MarkStack.h:

(JSC):
(MarkStackSegment):
(JSC::MarkStackSegment::MarkStackSegment):
(JSC::MarkStackSegment::sizeFromCapacity):
(MarkStackArray):

  • heap/MarkStackInlines.h:

(JSC::MarkStackSegment::create):
(JSC):
(JSC::MarkStackArray::postIncTop):
(JSC::MarkStackArray::preDecTop):
(JSC::MarkStackArray::setTopForFullSegment):
(JSC::MarkStackArray::setTopForEmptySegment):
(JSC::MarkStackArray::top):
(JSC::MarkStackArray::validatePrevious):
(JSC::MarkStackArray::append):
(JSC::MarkStackArray::removeLast):
(JSC::MarkStackArray::isEmpty):
(JSC::MarkStackArray::size):

  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::SlotVisitor):

9:51 AM Changeset in webkit [134079] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Give the view a size in TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=101770

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-09
Reviewed by Laszlo Gombos.

2 tests are currently failing, because they expect us to paint, but we don't paint if the view size is empty.

  • TestWebKitAPI/efl/PlatformWebView.cpp:

(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI):
(TestWebKitAPI::PlatformWebView::resizeTo):

9:22 AM Changeset in webkit [134078] by Bruno de Oliveira Abinader
  • 5 edits in trunk

[css] Text decoration's "blink" not valid when CSS3_TEXT is enabled
https://bugs.webkit.org/show_bug.cgi?id=101750

Reviewed by Ojan Vafai.

Source/WebCore:

This patch fixes an issue regarding "blink" value, which is valid for CSS 2.1
"text-decoration" property, but recently have its parser function modified by
the addition of CSS3 "-webkit-text-decoration-line" property.

The 'fast/css/getComputedStyle/getComputedStyle-text-decoration.html'
layout test is updated with all possible value combinations.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseTextDecoration): Added 'blink' value to list
if accepted.

LayoutTests:

This patch updates the "text-decoration" computed style layout tests to
handle a larger variety of value combinations.

  • fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt:
  • fast/css/getComputedStyle/script-tests/getComputedStyle-text-decoration.js:
9:18 AM Changeset in webkit [134077] by eae@chromium.org
  • 36 edits
    2 copies in branches/chromium/1312

Merge 133172 - [subpixel] Change intrinsicSize to LayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=99104

Reviewed by Levi Weintraub.

Source/WebCore:

Change RenderReplaced and intrinsicSize to LayoutUnit to avoid
rounding problems when zooming/scaling. Also change imageSize to
LayoutUnit as it can return a scaled size.

Test: fast/sub-pixel/tiled-canvas-elements.html

  • html/ImageDocument.cpp:

(WebCore::ImageDocumentParser::finish):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::imageSizeForRenderer):

  • loader/cache/CachedImage.h:

(CachedImage):

  • platform/graphics/FractionalLayoutSize.h:

(FractionalLayoutSize):
(WebCore::FractionalLayoutSize::scale):
(WebCore::FractionalLayoutSize::clampToMinimumSize):

  • rendering/RenderBox.h:

(WebCore::RenderBox::intrinsicSize):

  • rendering/RenderHTMLCanvas.cpp:

(WebCore::RenderHTMLCanvas::canvasSizeChanged):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageChanged):
(WebCore::RenderImage::updateIntrinsicSizeIfNeeded):
(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::minimumReplacedHeight):

  • rendering/RenderImage.h:

(RenderImage):

  • rendering/RenderImageResource.h:

(WebCore::RenderImageResource::imageSize):

  • rendering/RenderImageResourceStyleImage.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::RenderReplaced):
(WebCore::RenderReplaced::computeAspectRatioInformationForRenderBox):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):

  • rendering/RenderReplaced.h:

(RenderReplaced):
(WebCore::RenderReplaced::minimumReplacedHeight):
(WebCore::RenderReplaced::setIntrinsicSize):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::updateIntrinsicSize):
(WebCore::RenderVideo::calculateIntrinsicSize):
(WebCore::RenderVideo::videoBox):
(WebCore::RenderVideo::minimumReplacedHeight):

  • rendering/RenderVideo.h:

(RenderVideo):

  • rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::imageSize):

  • rendering/style/StyleCachedImage.h:

(StyleCachedImage):

  • rendering/style/StyleCachedImageSet.cpp:

(WebCore::StyleCachedImageSet::imageSize):

  • rendering/style/StyleCachedImageSet.h:

(StyleCachedImageSet):

  • rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::imageSize):
(WebCore::StyleGeneratedImage::computeIntrinsicDimensions):

  • rendering/style/StyleGeneratedImage.h:

(StyleGeneratedImage):

  • rendering/style/StyleImage.h:

(StyleImage):

  • rendering/style/StylePendingImage.h:

LayoutTests:

Add test for tiled replaced elements and update existing expectations as needed.

  • fast/sub-pixel/tiled-canvas-elements-expected.txt: Added.
  • fast/sub-pixel/tiled-canvas-elements.html: Added.
  • platform/chromium-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
  • platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-win/svg/as-image/svg-non-integer-scaled-image-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/chromium/fast/reflections/reflection-with-zoom-expected.txt:
  • platform/chromium/svg/as-image/svg-non-integer-scaled-image-expected.txt:
  • platform/chromium/svg/zoom/page/zoom-svg-as-image-expected.txt:
  • platform/chromium/svg/zoom/page/zoom-svg-as-relative-image-expected.txt:

TBR=eae@chromium.org

9:16 AM Changeset in webkit [134076] by jsbell@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening - rebaseline a handful of image tests for chromium-mac-lion.

  • platform/chromium-mac-lion/platform/chromium/compositing/layout-width-change-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/compositing/video-frame-size-change-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/core/backgrounds-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/core/captions3-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png: Added.
  • platform/chromium-mac-lion/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Added.
9:09 AM Changeset in webkit [134075] by xan@webkit.org
  • 2 edits in trunk/Source/WebCore

2012-11-09 Xan Lopez <xlopez@igalia.com>

[GTK] Do not use 'ls' to list IDL files in EXTRA_DIST
https://bugs.webkit.org/show_bug.cgi?id=101581

Reviewed by Martin Robinson.

Use normal GNU Make wildcards instead of 'ls' to list files in
EXTRA_DIST, it's safer and more straightforward.

  • GNUmakefile.am: ditto.
8:55 AM Changeset in webkit [134074] by rakuco@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r134068.
http://trac.webkit.org/changeset/134068
https://bugs.webkit.org/show_bug.cgi?id=101766

Caused crashes on the bots. (Requested by rakuco on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-09

  • WebKitTestRunner/cairo/TestInvocationCairo.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

8:20 AM Changeset in webkit [134073] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[GTK] Bump the jhbuild Cairo version to 1.12.8
https://bugs.webkit.org/show_bug.cgi?id=101721

Bump the Cairo version in Jhbuild moduleset to 1.12.8. This version
should fix multiple failures in canvas tests and also contains
fixes for X-related crashes that occurred from the 1.12.4 version onwards.

  • gtk/jhbuild.modules:
8:03 AM Changeset in webkit [134072] by Lucas Forschler
  • 4 edits in tags/Safari-537.18.1/Source

Versioning.

8:02 AM Changeset in webkit [134071] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] r133953 broke the ARM_TRADITIONAL build
https://bugs.webkit.org/show_bug.cgi?id=101706

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-11-09
Reviewed by Csaba Osztrogonác.

Fix for both hardfp and softfp.

  • dfg/DFGCCallHelpers.h:

(CCallHelpers):
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):

7:59 AM Changeset in webkit [134070] by Lucas Forschler
  • 1 copy in tags/Safari-537.18.1

New Tag.

7:56 AM Changeset in webkit [134069] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

Need to clear exception in JSDictionary that might have been caused by previous operation.
https://bugs.webkit.org/show_bug.cgi?id=96614

Reviewed by George Staikos.

IndexedDB IDBDatabase::createObjectStore supports both String type of KeyPath and
String Array type of KeyPath. It will first try to get the keyPath as a String Array,
if fails, it will try to get KeyPath as a String, from the Dictionary. The first get
will leave the internal ExecState of Dictionary in exception state. We need to clear
the exception state before the 2nd query, otherwise the second query will also fail.

No new tests. The existing test case LayoutTests/storage/indexeddb/tutorial.html should
now work with this patch.

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::getWithUndefinedOrNullCheck):

7:49 AM Changeset in webkit [134068] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[WTR][Cairo] Do not call paintRepaintRectOverlay() when there is no repaint rect.
https://bugs.webkit.org/show_bug.cgi?id=101759

Reviewed by Kenneth Rohde Christiansen.

  • WebKitTestRunner/cairo/TestInvocationCairo.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Improve
the check for an empty repaintRect -- we need to check if the
WKArrayRef has any items. `if (repaintRect)' will return true
regardless of whether the array is empty or not.

7:32 AM Changeset in webkit [134067] by staikos@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove obsolete tokenizer settings
https://bugs.webkit.org/show_bug.cgi?id=101689

Reviewed by Yong Li.

These tokenizer settings are obsolete and should not be here. Remove them.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

7:23 AM Changeset in webkit [134066] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Stop watchlist from triggering QtBuildSystem rule on DerivedSources

Having DerivedSources.pri in the watchlist regexp was creating too much
noise.

Reviewed by Ossy.

  • Scripts/webkitpy/common/config/watchlist:
7:18 AM Changeset in webkit [134065] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

[EFL] Rebaseline svg tests after 99870
https://bugs.webkit.org/show_bug.cgi?id=101756

Unreviewed svg baseline after https://bugs.webkit.org/show_bug.cgi?id=99870.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-09

  • platform/efl/TestExpectations:
  • platform/efl/svg/custom/pattern-scaling-expected.png: Added.
  • platform/efl/svg/custom/pattern-scaling-expected.txt: Added.
  • platform/efl/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
6:58 AM Changeset in webkit [134064] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Rebaseline fast/table/025-expected
https://bugs.webkit.org/show_bug.cgi?id=101752

Unreviewed rebaseline after https://bugs.webkit.org/show_bug.cgi?id=11645.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-09

  • platform/efl/TestExpectations:
  • platform/efl/fast/table/025-expected.png:
  • platform/efl/fast/table/025-expected.txt:
6:51 AM Changeset in webkit [134063] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r134051.
http://trac.webkit.org/changeset/134051
https://bugs.webkit.org/show_bug.cgi?id=101757

It didn't fix the build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-09

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):

6:42 AM Changeset in webkit [134062] by jocelyn.turcotte@digia.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Unmark now passing tests
https://bugs.webkit.org/show_bug.cgi?id=65531

Reviewed by Csaba Osztrogonác.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::viewModes):

6:36 AM Changeset in webkit [134061] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

WinCairo build fails to link
https://bugs.webkit.org/show_bug.cgi?id=101739

Patch by peavo@outlook.com <peavo@outlook.com> on 2012-11-09
Reviewed by Kentaro Hara.

  • win/WebKit2CFLite.def:
6:28 AM Changeset in webkit [134060] by dominik.rottsches@intel.com
  • 2 edits in trunk/Tools

webkitpy/layouttests integration test fails if high shards/processes environment variables are used
https://bugs.webkit.org/show_bug.cgi?id=101455

Reviewed by Dirk Pranke.

Updating test to disregard WEBKIT_TEST_MAX_LOCKED_SHARDS environment variable.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_max_locked_shards):

6:25 AM Changeset in webkit [134059] by rakuco@webkit.org
  • 5 edits in trunk

[EFL][DRT] Force a repaint before tracking repaint rects.
https://bugs.webkit.org/show_bug.cgi?id=101743

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::forceLayout): Added.

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Do like other ports and force a repaint before we start tracking
repaints so that the pixel results generated look more in line
with what's expected.

  • DumpRenderTree/efl/DumpRenderTree.cpp:

(displayWebView): Call DRTSupport::forceLayout() before start
tracking repaints.

6:22 AM Changeset in webkit [134058] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Month/week picker should submit month/week string
https://bugs.webkit.org/show_bug.cgi?id=101744

Reviewed by Kent Tamura.

Month/week picker should submit month/week string and not yyyy-mm-dd.

No new tests. Test will be added in Bug 101555 and Bug 101556.

  • Resources/pagepopups/calendarPicker.js:

(DaysTable.prototype._handleDayClick):

6:03 AM Changeset in webkit [134057] by commit-queue@webkit.org
  • 3 edits in trunk

[EFL] Enable -Werror for the EFL port
https://bugs.webkit.org/show_bug.cgi?id=98715

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-11-09
Reviewed by Gyuyoung Kim.

Treat all warnings as errors, except the existing warnings in the
current code base ("unused-parameter", "sign-compare" and "switch").

Thanks for Raphael Kubo da Costa for the extra help.

  • Source/CMakeLists.txt: Enable warnings as error for all libraries

(except WebKit and WebKit2) for the EFL port.
Other cmake-based ports are welcome to join.

  • Source/cmake/WebKitHelpers.cmake: Treat warnings as errors by

default for cmake-based ports when ENABLE_WERROR is set.

5:52 AM Changeset in webkit [134056] by rakuco@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] REGRESSION (r134043): API tests crashes
https://bugs.webkit.org/show_bug.cgi?id=101742

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-09
Reviewed by Kenneth Rohde Christiansen.

Do not assert on PassRefPtr<WebContext> after it becomes 0.

  • UIProcess/efl/BatteryProvider.cpp:

(BatteryProvider::BatteryProvider):

  • UIProcess/efl/NetworkInfoProvider.cpp:

(NetworkInfoProvider::NetworkInfoProvider):

5:42 AM Changeset in webkit [134055] by rakuco@webkit.org
  • 31 edits in trunk/LayoutTests/fast/repaint

Remove the `svn:executable' property from a few test files.

5:15 AM Changeset in webkit [134054] by kbalazs@webkit.org
  • 1 edit
    103 adds in trunk/LayoutTests

Pixel tests need rebaseline https://bugs.webkit.org/show_bug.cgi?id=99323

Unreviewed pixel rebaseline.

Rebaseline some tests, add missing expectations.

  • platform/qt-5.0-wk2/css3/filters/composited-reflected-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/transformed-body-background-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/transformed-body-html-background-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/transformed-html-body-background-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css-generated-content/before-with-first-letter-expected.png: Added.
  • platform/qt-5.0-wk2/svg/animations/animateMotion-additive-2c-expected.png: Added.
  • platform/qt-5.0-wk2/svg/text/text-rescale-expected.png: Added.
  • platform/qt/css3/filters/effect-reference-ordering-hw-actual.png: Added.
  • platform/qt/fast/images/png-suite/test-actual.png: Added.
  • platform/qt/svg/as-image/image-respects-pageScaleFactor-change-actual.png: Added.
  • platform/qt/svg/as-object/embedded-svg-size-changes-actual.png: Added.
  • platform/qt/svg/as-object/nested-embedded-svg-size-changes-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-refX-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-refY-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAngle-call-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMarkerElement-svgdom-setOrientToAuto-call-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-dom-height-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-dom-maskUnits-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-dom-width-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-dom-x-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-dom-y-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-maskUnits-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPathElement-dom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPathElement-svgdom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-dom-height-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-dom-patternContentUnits-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-dom-patternTransform-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-dom-patternUnits-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-dom-width-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-dom-x-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-dom-y-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-height-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-patternContentUnits-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-patternUnits-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-width-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-x-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPatternElement-svgdom-y-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPolygonElement-dom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPolygonElement-svgdom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPolylineElement-dom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGPolylineElement-svgdom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRectElement-dom-height-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRectElement-dom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRectElement-dom-width-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRectElement-dom-x-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRectElement-dom-y-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-height-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-width-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGRectElement-svgdom-y-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGSVGElement-dom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGSVGElement-svgdom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTRefElement-dom-href-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-dom-dx-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-dom-dy-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-dom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-dom-transform-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-dom-x-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-dom-y-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-dx-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-dy-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-rotate-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-transform-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-x-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGTextElement-svgdom-y-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGUseElement-dom-href1-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGUseElement-dom-href2-attr-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-actual.png: Added.
  • platform/qt/svg/dynamic-updates/SVGUseElement-svgdom-requiredFeatures-actual.png: Added.
  • platform/qt/svg/filters/subRegion-one-effect-actual.png: Added.
  • platform/qt/svg/filters/subRegion-two-effects-actual.png: Added.
5:05 AM Changeset in webkit [134053] by pfeldman@chromium.org
  • 10 edits
    1 copy in trunk

Web Inspector: wrong output for empty object {}
https://bugs.webkit.org/show_bug.cgi?id=101356

Reviewed by Vsevolod Vlasov.

Changed preview formatting to iterate over enumerable properties only + visit the prototypes.

Source/WebCore:

  • inspector/InjectedScriptSource.js:

(.):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):

LayoutTests:

  • inspector/console/command-line-api-expected.txt:
  • inspector/console/command-line-api-inspect-expected.txt:
  • inspector/console/console-format-collections-expected.txt:
  • inspector/console/console-format-expected.txt:
  • platform/chromium/inspector/console/console-format-collections-expected.txt:
4:54 AM Changeset in webkit [134052] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[BlackBerry] DRT - eventSender.keyDown() needs to support pageUp, pageDown, home, end key
https://bugs.webkit.org/show_bug.cgi?id=100937

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-11-09
Reviewed by Rob Buis.

  1. Translate these keys to their corresponding BlackBerry key code.
  2. Break down a KeyChar event to a KeyDown/KeyUp pair. This is required

because we only handle scrolling on a KeyDown event in WebPage::keyEvent()
, and internally a KeyChar event is interpreted as a KeyDown event + a
KeyUp event in InputHandler::handleKeyboardInput().

Tests fixed:

  1. editing/input/scroll-viewport-page-up-down.html
  2. editing/selection/move-begin-end.html
  3. fast/forms/select-popup-pagekeys.html
  • DumpRenderTree/blackberry/EventSender.cpp:

(keyDownCallback):

4:41 AM Changeset in webkit [134051] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] r133953 broke the ARM_TRADITIONAL build
https://bugs.webkit.org/show_bug.cgi?id=101706

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-11-09
Reviewed by Csaba Osztrogonác.

Fix the ARM_TRADITIONAL build after r133953

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):

4:28 AM Changeset in webkit [134050] by keishi@webkit.org
  • 4 edits in trunk/Source/WebCore

Fix annotations in page popup files
https://bugs.webkit.org/show_bug.cgi?id=101736

Reviewed by Kent Tamura.

Add @constructor where needed. Replacing /* with / for annotations.

No new tests. No behavior change.

  • Resources/pagepopups/calendarPicker.js:
  • Resources/pagepopups/pickerCommon.js:
  • Resources/pagepopups/suggestionPicker.js:
4:23 AM Changeset in webkit [134049] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2][AC] Random crashes in layout tests on the bot
https://bugs.webkit.org/show_bug.cgi?id=101687

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-09
Reviewed by Kenneth Rohde Christiansen.

Speculative fix for a crash on the bot.
If didCommitLoad() is called before the view size was set, we will
try to paint an empty area, and that will crash.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::update):

4:13 AM Changeset in webkit [134048] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Coordinated Graphics: Remove a backing store of GraphicsLayer when the layer is far from the viewport.
https://bugs.webkit.org/show_bug.cgi?id=101656

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-09
Reviewed by Kenneth Rohde Christiansen.

TiledBackingStore computes cover and keep rects to create, keep or remove tiles
smartly, but currently TiledBackingStore expects a contents rect is big enough
to cover the visibleRect. However, when CoordinatedGraphicsLayer uses TBS, it
is usually wrong expectation.

We must compute cover and keep rects using the visibleRect, instead of
the rect intersecting the visibleRect with m_rect, because TBS can be
used as a backing store of GraphicsLayer and the visible rect usually
does not intersect with m_rect.
In the below case, the intersecting rect is an empty.

+---------------+
| |
| m_rect |

| +-------+

| | HERE | cover or keep |
+---------------+ rect |

| +---------+ |
| | visible | |
| | rect | |
| +---------+ |
| |
| |
+-------------------------------+

We must create or keep the tiles in the HERE region. Currently in the
case, we do not create or keep tiles on the HERE region. Moreover, in
the case, we early return, which means we don't remove any tiles. It
causes to waste heap and video memory.

This patch changes TiledBackingStore to manage tiles smartly for
Coordinated Graphics.

Changing cache policy is not testable in layout tests.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::visibleRect):
(WebCore::TiledBackingStore::visibleAreaIsCovered):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::adjustForContentsRect):
(WebCore::TiledBackingStore::removeAllNonVisibleTiles):

  • platform/graphics/TiledBackingStore.h:

(TiledBackingStore):

4:08 AM Changeset in webkit [134047] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Refactor TestExpectations file
https://bugs.webkit.org/show_bug.cgi?id=101738

Unreviewed, EFL gardening.

Remove duplicated definitions.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-09

  • platform/efl/TestExpectations:
3:39 AM Changeset in webkit [134046] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix undefined variable in Week constructor for calendar picker
https://bugs.webkit.org/show_bug.cgi?id=101734

Reviewed by Kent Tamura.

Closer compiler found an undefined variable in the Week constructor.

No new tests. This code isn't used.

  • Resources/pagepopups/calendarPicker.js:

(Week): Used wrong variable name.

3:33 AM Changeset in webkit [134045] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: render canvas log as a grid.
https://bugs.webkit.org/show_bug.cgi?id=101732

Reviewed by Vsevolod Vlasov.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype._onSelectTraceLog):
(WebInspector.CanvasProfileView.prototype._replayTraceLog.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._replayTraceLog):
(WebInspector.CanvasProfileHeader.prototype.traceLogId):
(WebInspector.CanvasLogGrid):
(WebInspector.CanvasLogGrid.prototype._didReceiveTraceLog):
(WebInspector.CanvasLogGrid.prototype._createCallNode):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGridNode.prototype.createCell):

  • inspector/front-end/canvasProfiler.css:

(#canvas-replay-image-container):

3:28 AM Changeset in webkit [134044] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

Regression(r107593) Crash in ContextMenuController::addInspectElementItem()
https://bugs.webkit.org/show_bug.cgi?id=101595

Reviewed by Simon Hausmann.

If the contextMenu is a null pointer treat it as empty, appendItem will later
create it if necessary.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::addInspectElementItem):

3:25 AM Changeset in webkit [134043] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit2

[EFL][WK2] Make classes for client use WebContext instead of WKContext
https://bugs.webkit.org/show_bug.cgi?id=101564

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-09
Reviewed by Kenneth Rohde Christiansen.

EwkContext class has been refactored to use WebContext instead of WKContext in r133844,
so this patch makes client classes use WebContext

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::EwkContext):

  • UIProcess/efl/BatteryProvider.cpp:

(BatteryProvider::~BatteryProvider):
(BatteryProvider::create):
(BatteryProvider::BatteryProvider):
(BatteryProvider::didChangeBatteryStatus):

  • UIProcess/efl/BatteryProvider.h:

(BatteryProvider):

  • UIProcess/efl/ContextHistoryClientEfl.cpp:

(WebKit::ContextHistoryClientEfl::ContextHistoryClientEfl):

  • UIProcess/efl/ContextHistoryClientEfl.h:

(WebKit::ContextHistoryClientEfl::create):
(ContextHistoryClientEfl):

  • UIProcess/efl/NetworkInfoProvider.cpp:

(NetworkInfoProvider::create):
(NetworkInfoProvider::NetworkInfoProvider):
(NetworkInfoProvider::~NetworkInfoProvider):

  • UIProcess/efl/NetworkInfoProvider.h:

(NetworkInfoProvider):

3:12 AM Changeset in webkit [134042] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Fix build warning in test_ewk2_context.cpp: [-Wwrite-strings]
https://bugs.webkit.org/show_bug.cgi?id=101666

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-09
Reviewed by Kenneth Rohde Christiansen.

Use constant character pointer to fix [-Wwrite-strings] warning.

  • UIProcess/API/efl/tests/test_ewk2_context.cpp:

(TEST_F):

3:06 AM Changeset in webkit [134041] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[EFL][WK2] Add support for custom cursors
https://bugs.webkit.org/show_bug.cgi?id=101723

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-09
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add getEvasObject() virtual method to Image class and
provide implementation for BitmapImage.

No new tests, no behavior change.

  • platform/efl/CursorEfl.cpp:

(WebCore::cursorString):

  • platform/graphics/BitmapImage.h:

(BitmapImage):

  • platform/graphics/Image.h:

(Image):
(WebCore::Image::getEvasObject):

  • platform/graphics/efl/ImageEfl.cpp:

(WebCore::BitmapImage::getEvasObject):
(WebCore):

Source/WebKit2:

EwkViewImpl::setCursor() now properly handles custom
cursors.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::setCursor):

  • UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl):

2:33 AM Changeset in webkit [134040] by abarth@webkit.org
  • 11 edits in trunk/Source/WebCore

IndexedDB should use mostly ScriptWrappable DOM objects
https://bugs.webkit.org/show_bug.cgi?id=101694

Reviewed by Kentaro Hara.

These object always have JavaScript wrappers, so we should store the
wrappers inline to use less memory and be faster.

  • Modules/indexeddb/IDBAny.h:
  • Modules/indexeddb/IDBCursor.h:
  • Modules/indexeddb/IDBDatabase.h:
  • Modules/indexeddb/IDBFactory.h:
  • Modules/indexeddb/IDBIndex.h:
  • Modules/indexeddb/IDBKey.h:
  • Modules/indexeddb/IDBKeyRange.h:
  • Modules/indexeddb/IDBObjectStore.h:
  • Modules/indexeddb/IDBRequest.h:
  • Modules/indexeddb/IDBTransaction.h:
2:10 AM Changeset in webkit [134039] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Skip failing test perf/accessibility-title-ui-element.html
https://bugs.webkit.org/show_bug.cgi?id=101728

Unreviewed EFL gardening.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-09

  • platform/efl/TestExpectations:
2:09 AM Changeset in webkit [134038] by dominik.rottsches@intel.com
  • 11 edits in trunk/LayoutTests

[EFL] Update baselines for failing svg tests
https://bugs.webkit.org/show_bug.cgi?id=101726

Unreviewed EFL gardening.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-09

  • platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt:
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.txt:
  • platform/efl/svg/text/bidi-tspans-expected.png:
  • platform/efl/svg/text/bidi-tspans-expected.txt:
2:06 AM Changeset in webkit [134037] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Add meaningful error message when request content was evicted from inspector cache.
https://bugs.webkit.org/show_bug.cgi?id=101578

Reviewed by Yury Semikhatsky.

Added specific error message when request content was evicted from inspector cache.
Replaced purge with evict in fields/methods names.

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::getResponseBody):

  • inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::ResourceData::evictContent):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeAddResourceData):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):
(WebCore::NetworkResourcesData::ensureNoDataForRequestId):
(WebCore::NetworkResourcesData::ensureFreeSpace):

  • inspector/NetworkResourcesData.h:

(WebCore::NetworkResourcesData::ResourceData::isContentEvicted):
(ResourceData):

2:03 AM Changeset in webkit [134036] by tkent@chromium.org
  • 6 edits in trunk/Source/WebCore

Don't use RenderTextControlSingleLine for date/time input types without the multiple-fields UI
https://bugs.webkit.org/show_bug.cgi?id=101722

Reviewed by Hajime Morita.

Because the date/time input types are not textfields, we should not use
RenderTextControlSingleLine, and don't need to create shadow trees for
RenderTextControlSingleLine.

No new tests. Covered by fast/forms/*/*-appearance-*.html.

  • css/html.css:

(input[type="date"]):
It has menulist appeanrace by default, and should be a flexible box to
center the inner text. 10em width is almost same as the default width of
text fields.
(input[type="datetime"]): Ditto.
(input[type="datetime-local"]): Ditto.
(input[type="month"]): Ditto.
(input[type="time"]): Ditto.
(input[type="week"]): Ditto.
(input::-webkit-date-and-time-value):
Added. A style for the inner text block.

  • html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::createRenderer):
Don't create RenderTextControlSingleLine.
(WebCore::BaseChooserOnlyDateAndTimeInputType::updateInnerTextValue):
Skip TextFieldInputType::updateInnerTextValue.
(WebCore::BaseChooserOnlyDateAndTimeInputType::forwardEvent):
Skip TextFieldInputType::forwardEvent.
(WebCore::BaseChooserOnlyDateAndTimeInputType::createShadowSubtree):
Just add one element to the shadow root.
(WebCore::BaseChooserOnlyDateAndTimeInputType::updateAppearance):
Sets a localized value to the inner text block.
(WebCore::BaseChooserOnlyDateAndTimeInputType::setValue):
Calls updateAppearance if the value is updated.

  • html/BaseChooserOnlyDateAndTimeInputType.h:

(BaseChooserOnlyDateAndTimeInputType): Declare updateAppearance,
createRenderer, updateInnerTextValue, forwardEvent, createShadowSubtree,
and setValue.

  • html/BaseDateAndTimeInputType.h:

(WebCore): Add a FIXME comment.
(BaseDateAndTimeInputType):
Make visibleValue protected. It is used by BaseChooserOnlyDateAndTimeInputType.

  • html/TextFieldInputType.h:

(TextFieldInputType):
Make setValue protected. It is used by BaseChooserOnlyDateAndTimeInputType.

1:59 AM Changeset in webkit [134035] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Clarify meaning of different urls in protocol.
https://bugs.webkit.org/show_bug.cgi?id=101582

Reviewed by Yury Semikhatsky.

  • inspector/Inspector.json:
1:58 AM Changeset in webkit [134034] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Month picker should select the current month when navigating while keeping selection position.
https://bugs.webkit.org/show_bug.cgi?id=101724

Reviewed by Kent Tamura.

Month picker needs to behave differently because selection won't be in the same position when changing current month.

No new tests. Test will be added in Bug 101556.

  • Resources/pagepopups/calendarPicker.js:

(DaysTable.prototype.navigateToMonth): Date/Week picker should keep selection position for first selected date node.
(DaysTable.prototype._startMoveInAnimation): Moving shared code to separate function.
(MonthPickerDaysTable.prototype.navigateToMonth): Month picker should just select the month.

1:50 AM Changeset in webkit [134033] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Web Inspector: Fix heap snapshots counted several times by NMI
https://bugs.webkit.org/show_bug.cgi?id=101085

The fix moves snapshots size counting to V8PerIsolateData class. As long
as it has one instance per isolate its reportMemoryUsage should be
called once per isolate.

Patch by Alexei Filippov <alph@chromium.org> on 2012-11-09
Reviewed by Yury Semikhatsky.

Source/WebCore:

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::reportMemoryUsage):

Source/WTF:

  • wtf/MemoryInstrumentation.h:

(WTF::MemoryClassInfo::addPrivateBuffer):

1:47 AM Changeset in webkit [134032] by Simon Hausmann
  • 2 edits in trunk/Tools

Unreviewed prospective Qt/Windows build bot fix:

Make determination of qmake mkspec work with older versions of Qt that
still create a "mkspecs/default" directory.

  • Scripts/webkitdirs.pm:

(qtMakeCommand):

1:22 AM Changeset in webkit [134031] by pfeldman@chromium.org
  • 22 edits
    1 add in trunk/Source/WebCore

Web Inspector: split SplitView into SplitView and SidebarView
https://bugs.webkit.org/show_bug.cgi?id=101612

Reviewed by Vsevolod Vlasov.

Currently, SplitView is rather a sidebar view. I'm extracting the reusable split component from it.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/AuditsPanel.js:

(WebInspector.AuditsPanel):

  • inspector/front-end/CSSNamedFlowCollectionsView.js:

(WebInspector.CSSNamedFlowCollectionsView):
(WebInspector.CSSNamedFlowCollectionsView.prototype.wasShown):

  • inspector/front-end/ElementsPanel.js:
  • inspector/front-end/FileSystemView.js:

(WebInspector.FileSystemView):

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.CounterUI):
(WebInspector.MemoryStatistics.prototype.setTopPosition):
(WebInspector.MemoryStatistics.prototype.setSidebarWidth):
(WebInspector.MemoryStatistics.prototype.visible):
(WebInspector.MemoryStatistics.prototype.show):
(WebInspector.MemoryStatistics.prototype.hide):

  • inspector/front-end/NavigatorOverlayController.js:

(WebInspector.NavigatorOverlayController.prototype.set _pinNavigator):
(WebInspector.NavigatorOverlayController.prototype.set showNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype.hideNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype._innerHideNavigatorOverlay):

  • inspector/front-end/NetworkPanel.js:
  • inspector/front-end/Panel.js:

(WebInspector.Panel.prototype.createSidebarView):
(WebInspector.Panel.prototype.createSidebarViewWithTree):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel):

  • inspector/front-end/ResourcesPanel.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel):

  • inspector/front-end/SidebarView.js: Added.

(WebInspector.SidebarView):
(WebInspector.SidebarView.prototype._hasLeftSidebar):
(WebInspector.SidebarView.prototype.get mainElement):
(WebInspector.SidebarView.prototype.get sidebarElement):
(WebInspector.SidebarView.prototype._innerSetSidebarPosition):
(WebInspector.SidebarView.prototype.setMinimalSidebarWidth):
(WebInspector.SidebarView.prototype.setMinimalMainWidthPercent):
(WebInspector.SidebarView.prototype.setSidebarWidth):
(WebInspector.SidebarView.prototype.sidebarWidth):
(WebInspector.SidebarView.prototype.onResize):
(WebInspector.SidebarView.prototype.applyConstraints):
(WebInspector.SidebarView.prototype.hideMainElement):
(WebInspector.SidebarView.prototype.showMainElement):
(WebInspector.SidebarView.prototype.hideSidebarElement):
(WebInspector.SidebarView.prototype.showSidebarElement):
(WebInspector.SidebarView.prototype.elementsToRestoreScrollPositionsFor):

  • inspector/front-end/SplitView.js:

(WebInspector.SplitView):
(WebInspector.SplitView.prototype.firstElement):
(WebInspector.SplitView.prototype.secondElement):
(WebInspector.SplitView.prototype.setChangeFirstOnResize):
(WebInspector.SplitView.prototype.resizerElement):
(WebInspector.SplitView.prototype.showOnlyFirst):
(WebInspector.SplitView.prototype.showOnlySecond):
(WebInspector.SplitView.prototype._showOnly):
(WebInspector.SplitView.prototype._removeAllLayoutProperties):
(WebInspector.SplitView.prototype.showBoth):
(WebInspector.SplitView.prototype.setResizable):
(WebInspector.SplitView.prototype.setSplitOffset):
(WebInspector.SplitView.prototype.splitOffset):
(WebInspector.SplitView.prototype._innerSetSplitOffset):
(WebInspector.SplitView.prototype._startResizerDragging):

  • inspector/front-end/TimelinePanel.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/splitView.css:
1:20 AM Changeset in webkit [134030] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Ctrl+A in the network panel should select resource content, not the entire panel
https://bugs.webkit.org/show_bug.cgi?id=101591

Patch by Andrey Lushnikov <lushnikov@google.com> on 2012-11-09
Reviewed by Vsevolod Vlasov.

Intercept Ctrl+A event in DefaultTextEditor to select resource content

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype._registerShortcuts): Added Ctrl+A
(WebInspector.DefaultTextEditor.prototype._handleKeyDown): Intercept Ctrl+A even for readonly fields
(WebInspector.TextEditorMainPanel.prototype.handleSelectAll):

  • inspector/front-end/KeyboardShortcut.js: Added SelectAll constant for Ctrl+A combination
1:11 AM Changeset in webkit [134029] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[V8] Main world should have one DOMDataStore
https://bugs.webkit.org/show_bug.cgi?id=101470

Patch by Dan Carney <dcarney@google.com> on 2012-11-09
Reviewed by Kentaro Hara.

The main world DOMWrapperWorld held onto a DOMDataStore that should
never be used, as there is a static one optimized for speed in
DOMDataStore.

No new tests. No change in functionality.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

  • bindings/v8/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::isolatedWorldDomDataStore):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

1:01 AM Changeset in webkit [134028] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Navigating around NMI snapshot grid with keys breaks the grid
https://bugs.webkit.org/show_bug.cgi?id=101611

Patch by Alexei Filippov <alph@chromium.org> on 2012-11-09
Reviewed by Yury Semikhatsky.

Keys navigation cause populate message sent to the node. The node should
not react on populate messages but the first one.

  • inspector/front-end/NativeMemorySnapshotView.js:
1:00 AM Changeset in webkit [134027] by jochen@chromium.org
  • 5 edits
    2 adds in trunk/Tools

[chromium] Introduce a WebTestProxy to override methods in WebViewClient for layout tests
https://bugs.webkit.org/show_bug.cgi?id=101452

Reviewed by Adam Barth.

The WebTestProxy is template, so it can derive from an implementation
of the WebViewClient interface. That way, WebTestProxy can hook into
individual methods of the WebViewClient and forward all the rest to the
actual implementation.

To demonstrate how I want to use this, I moved the
postAccessibilityNotification method from WebViewHost to WebTestProxy.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Added.

(WebKit):
(WebTestRunner):
(WebTestProxyBase):
(WebTestProxy):
(WebTestRunner::WebTestProxy::WebTestProxy):
(WebTestRunner::WebTestProxy::~WebTestProxy):
(WebTestRunner::WebTestProxy::postAccessibilityNotification):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Added.

(WebTestRunner):
(WebTestRunner::WebTestProxyBase::WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::setInterfaces):
(WebTestRunner::WebTestProxyBase::setDelegate):
(WebTestRunner::WebTestProxyBase::doPostAccessibilityNotification):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::createNewWindow):

  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

12:54 AM Changeset in webkit [134026] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] css3/flexbox/multiline-justify-content.html doesn't crash
https://bugs.webkit.org/show_bug.cgi?id=101717

Unreviewed, EFL gardening.

css3/flexbox/multiline-justify-content.html doesn't crash and can be passed.

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-11-09

  • platform/efl/TestExpectations:
12:40 AM Changeset in webkit [134025] by Csaba Osztrogonác
  • 3 edits in trunk/Source/JavaScriptCore

[Qt] Fix the LLINT build from ARMv7 platform
https://bugs.webkit.org/show_bug.cgi?id=101712

Reviewed by Simon Hausmann.

Enable generating of LLIntAssembly.h on ARM platforms.

12:36 AM Changeset in webkit [134024] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Build with MSVC fails to use nmake instead of make
https://bugs.webkit.org/show_bug.cgi?id=98645

Reviewed by Tor Arne Vestbø.

Don't rely on the "default" mkspec but instead query the target
mkspec variable from qmake to find the right qmake.conf.

  • Scripts/webkitdirs.pm:

(qtMakeCommand):

Nov 8, 2012:

11:45 PM Changeset in webkit [134023] by commit-queue@webkit.org
  • 4 edits in trunk

Web Inspector: Timeline: "Send Request" events are shown out of order.
https://bugs.webkit.org/show_bug.cgi?id=101544

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-08
Reviewed by Yury Semikhatsky.

Solution: replace obsolete out-of-order record pushing with frontend
record reparenting.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willSendResourceRequest): Replaced
direct record pushing with standard appendRecord invokation.

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.prototype._findParentRecord):
Made "Send Request" records top-level if gluing is on.

11:41 PM Changeset in webkit [134022] by commit-queue@webkit.org
  • 31 edits in trunk/Source

Unreviewed, rolling out r134010.
http://trac.webkit.org/changeset/134010
https://bugs.webkit.org/show_bug.cgi?id=101716

Broke the chromium windows build. (Requested by noel_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-08

Source/WebCore:

  • Modules/indexeddb/IDBAny.cpp:
  • Modules/indexeddb/IDBCallbacks.h:
  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::getObjectStoreId):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(WebCore):
(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBMetadata.h:

(WebCore::IDBObjectStoreMetadata::containsIndex):
(WebCore::IDBDatabaseMetadata::findObjectStore):
(IDBDatabaseMetadata):
(WebCore::IDBDatabaseMetadata::containsObjectStore):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put):
(WebCore):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):

  • Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReady):
(WebCore::IDBObjectStoreBackendImpl::index):
(WebCore::IDBObjectStoreBackendImpl::getIndexId):
(WebCore::IDBObjectStoreBackendImpl::getIndexIds):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h:

(WebCore):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::objectStore):
(WebCore):

  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(IDBTransactionBackendImpl):

  • Modules/indexeddb/IDBTransactionBackendInterface.h:

Source/WebKit/chromium:

  • src/IDBCallbacksProxy.cpp:
  • src/IDBDatabaseBackendProxy.cpp:

(WebKit::IDBDatabaseBackendProxy::transaction):
(WebKit):

  • src/IDBDatabaseBackendProxy.h:

(IDBDatabaseBackendProxy):

  • src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::putWithIndexKeys):
(WebKit):
(WebKit::IDBObjectStoreBackendProxy::setIndexKeys):
(WebKit::IDBObjectStoreBackendProxy::createIndex):
(WebKit::IDBObjectStoreBackendProxy::setIndexesReady):
(WebKit::IDBObjectStoreBackendProxy::index):
(WebKit::IDBObjectStoreBackendProxy::deleteIndex):

  • src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::deleteObjectStore):
(WebKit):
(WebKit::WebIDBDatabaseImpl::transaction):

  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::putWithIndexKeys):
(WebKit):
(WebKit::WebIDBObjectStoreImpl::setIndexKeys):
(WebKit::WebIDBObjectStoreImpl::setIndexesReady):
(WebKit::WebIDBObjectStoreImpl::index):
(WebKit::WebIDBObjectStoreImpl::deleteIndex):

  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

  • src/WebIDBTransactionImpl.cpp:

(WebKit::WebIDBTransactionImpl::objectStore):
(WebKit):

  • src/WebIDBTransactionImpl.h:
  • tests/IDBRequestTest.cpp:
11:34 PM Changeset in webkit [134021] by g.czajkowski@samsung.com
  • 7 edits in trunk/Source

[EFL] Add a method to the TextCheckerEnchant class to check whether any dictionary is loaded
https://bugs.webkit.org/show_bug.cgi?id=101570

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Expose a new method to check whether a vector of loaded languages is empty.
WK2-EFL needs it to set the default language (if the client didn't set any) when
spelling setting is being enabled. This change makes it more convenient to check
whether the dictionaries vector is empty.

No new tests, no behavior change.

  • platform/text/enchant/TextCheckerEnchant.cpp:

(TextCheckerEnchant::checkSpellingOfString):
(TextCheckerEnchant::getGuessesForWord):
(TextCheckerEnchant::loadedSpellCheckingLanguages):
A newly exposed method is used internally too.

  • platform/text/enchant/TextCheckerEnchant.h:

(WebCore::TextCheckerEnchant::hasDictionary):
Add an inline hasDictionary() method.

Source/WebKit2:

To do not get the vector of loaded languages, WebKit2-EFL calls
TextCheckerEnchant::hasDictionary() method to check whether the
dictionaries vector is empty.

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_continuous_spell_checking_enabled_set):

  • UIProcess/API/efl/ewk_text_checker.cpp:

(Ewk_Text_Checker::hasDictionary):
(Ewk_Text_Checker):

  • UIProcess/API/efl/ewk_text_checker_private.h:

(Ewk_Text_Checker):

11:28 PM Changeset in webkit [134020] by shinyak@chromium.org
  • 3 edits in trunk/Source/WebCore

[Refactoring] Remove shadowPseudoId() and use pseudo() instead in TextTrackCue
https://bugs.webkit.org/show_bug.cgi?id=101702

Reviewed by Hajime Morita.

We're migrating shadowPseudoId() to pseudo(). We remove shadowPseudoId() from TextTrackCue and use
setPseudo()/pseudo() instead.

No new tests, simple refactoring.

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCueBox::TextTrackCueBox):

  • html/track/TextTrackCue.h:

(TextTrackCueBox):

11:23 PM Changeset in webkit [134019] by hayato@chromium.org
  • 4 edits
    2 adds in trunk/LayoutTests

Unreviewed, update chromium-mac baselines.

  • platform/chromium-mac/platform/chromium/compositing/layout-width-change-expected.png:
  • platform/chromium-mac/platform/chromium/compositing/video-frame-size-change-expected.png:
  • platform/chromium-mac/platform/chromium/media/video-frame-size-change-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/text-on-scaled-layer-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/text-on-scaled-surface-expected.png: Added.
11:20 PM Changeset in webkit [134018] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove Chromium test expectations after r133939.

  • platform/chromium/TestExpectations:
11:03 PM Changeset in webkit [134017] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

table not aligned in center column and seems shrunk because of float:right (table-layout: fixed and width: 100%)
https://bugs.webkit.org/show_bug.cgi?id=18153

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-11-08
Reviewed by Beth Dakin.

Source/WebCore:

Preferred logical width is computed incorrectly for fixed layout tables
with 100% percent width, in standards mode.

According to our fixed table layout algorithm (CSS2 specification - 17.5.2.1)
the ultimate width of the table is the greater of the value of the
'width' property for the table elements and the sum of the column
widths.

For our specific scenario we have a fixed layout table with 100% width
consisting of columns with fixed widths, the sum of which is less than
the specified width of the table (i.e. 100% of the containing block).
Even then the applied width is the cummulative of the width of the
columns.

This happens because of the quirks mode check added in
FixedTableLayout::computePreferredLogicalWidths(), which prohibits the
setting of maxWidth to our fixed layout table with percent width, and
which perhaps is not required anymore.

Test: fast/table/fixed-table-layout/table-with-percent-width.html

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::computePreferredLogicalWidths):
Removed the quirks mode check.

LayoutTests:

  • fast/table/fixed-table-layout/table-with-percent-width-expected.txt: Added.
  • fast/table/fixed-table-layout/table-with-percent-width.html: Added.

Test added to verify the width of the fixed layout tables with 100%
width, in standards mode.

10:54 PM Changeset in webkit [134016] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r134004.
http://trac.webkit.org/changeset/134004
https://bugs.webkit.org/show_bug.cgi?id=101713

multiple crashes (Requested by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-08

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::adjustMediaSliderThumbSize):
(WebCore::RenderThemeMac::paintMediaFullscreenButton):
(WebCore::RenderThemeMac::paintMediaMuteButton):
(WebCore::RenderThemeMac::paintMediaPlayButton):
(WebCore::RenderThemeMac::paintMediaSeekBackButton):
(WebCore::RenderThemeMac::paintMediaSeekForwardButton):
(WebCore::RenderThemeMac::paintMediaSliderTrack):
(WebCore::RenderThemeMac::paintMediaSliderThumb):
(WebCore::RenderThemeMac::paintMediaRewindButton):
(WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
(WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
(WebCore::RenderThemeMac::paintMediaControlsBackground):
(WebCore::RenderThemeMac::paintMediaCurrentTime):
(WebCore::RenderThemeMac::paintMediaTimeRemaining):
(WebCore::RenderThemeMac::paintMediaVolumeSliderContainer):
(WebCore::RenderThemeMac::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeMac::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderTrack):
(WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderThumb):

10:46 PM Changeset in webkit [134015] by timothy@apple.com
  • 4 edits in trunk/Source

Always use a textured window for the Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=101693

Reviewed by Joseph Pecoraro.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController window]): Removed the conditional for a textured window.

Source/WebKit2:

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow): Removed the conditional for a textured window.

10:46 PM Changeset in webkit [134014] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: stop using cursorCoords in CodeMirrorTextEditor
https://bugs.webkit.org/show_bug.cgi?id=101607

Patch by Jan Keromnes <janx@linux.com> on 2012-11-08
Reviewed by Vsevolod Vlasov.

API changes completing migration to v3.

  • inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.revealLine):
(WebInspector.CodeMirrorTextEditor.prototype.selection):

10:39 PM Changeset in webkit [134013] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] about:blank should display the blank page
https://bugs.webkit.org/show_bug.cgi?id=101566

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-08
Reviewed by Laszlo Gombos.

Add a check to return early without prepending http:// scheme, if the
URL is 'about:blank'.

  • EWebLauncher/url_utils.c:

(url_from_user_input):

10:33 PM Changeset in webkit [134012] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed test expectations update.

Unskip and start generating results for fast/images/color-jpeg-with-color-profile.html
on Win to prepare for an upcoming rebaseline.

  • platform/chromium/TestExpectations:
10:30 PM Changeset in webkit [134011] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: make "Other" bar color darker in NMI snapshot.
https://bugs.webkit.org/show_bug.cgi?id=101602

Patch by Alexei Filippov <alph@chromium.org> on 2012-11-08
Reviewed by Vsevolod Vlasov.

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

10:27 PM Changeset in webkit [134010] by alecflett@chromium.org
  • 31 edits in trunk/Source

IndexedDB: switch frontend to use int64_t-based references
https://bugs.webkit.org/show_bug.cgi?id=100426

Reviewed by Tony Chang.

Source/WebCore:

Remove String-based objectStore/index references, obsoleted by
https://bugs.webkit.org/show_bug.cgi?id=100425.

No new tests as this is the second half of a refactor.

  • Modules/indexeddb/IDBCallbacks.h:
  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBMetadata.h:

(WebCore::IDBObjectStoreMetadata::findIndex):
(IDBObjectStoreMetadata):
(WebCore::IDBObjectStoreMetadata::containsIndex):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put):
(WebCore):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h:
  • inspector/Inspector-1.0.json:
  • inspector/Inspector.json:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):
(WebCore::InspectorIndexedDBAgent::requestData):

  • inspector/InspectorIndexedDBAgent.h:

(InspectorIndexedDBAgent):

Source/WebKit/chromium:

Remove implementation stubs from chromium API for
methods obsoleted by https://bugs.webkit.org/show_bug.cgi?id=100425

  • src/IDBObjectStoreBackendProxy.cpp:
  • src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:
  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • src/WebIDBObjectStoreImpl.cpp:
  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

10:24 PM Changeset in webkit [134009] by keishi@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

WebPagePopupImpl::handleKeyEvent is called after WebPagePopupImpl::close
https://bugs.webkit.org/show_bug.cgi?id=93800

Reviewed by Kent Tamura.

We need to set m_closing to true in WebPagePopupImpl::close so we won't access m_page in WebPagePopupImpl::handleKeyEvent.

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::close): Set m_closing to true.

10:17 PM Changeset in webkit [134008] by shinyak@chromium.org
  • 4 edits in trunk/Source/WebCore

[Refactoring] Expose collectFeaturesFromSelector from RuleSet.cpp
https://bugs.webkit.org/show_bug.cgi?id=101692

Reviewed by Dimitri Glazkov.

We expose collectFeaturesFromSelector in RuleSet.cpp to use it for collecting ShadowDOM select attribute features.

No new tests, simple refactoring.

  • css/RuleFeature.cpp:

(WebCore::RuleFeatureSet::collectFeaturesFromSelector): Moved from RuleSet.cpp.
(WebCore):

  • css/RuleFeature.h:

(WebCore):
(RuleFeatureSet):

  • css/RuleSet.cpp:

(WebCore::collectFeaturesFromRuleData):

10:02 PM Changeset in webkit [134007] by hayato@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed, Unreviewed gardening following r133972.

  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/exif-orientation-expected.png: Added.
9:50 PM Changeset in webkit [134006] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium expectations for svg/repaint/image-with-clip-path.svg.

  • platform/chromium/TestExpectations:
9:42 PM Changeset in webkit [134005] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Make jquery/manipulation.html into one in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=101686

Unreviewed, EFL gardening.

Currently there are three definitions on jquery/manipulation.html case.
As BUG 100636 fixed, we don't need Crash definition anymore.
Therefore, this patch makes this case into one definition without Crash in TestExpectations.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-08

  • platform/efl/TestExpectations:
9:02 PM Changeset in webkit [134004] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Guard calls to WebKitSystemInterface media control drawing functions in RenderThemeMac with PLATFORM(MAC)
https://bugs.webkit.org/show_bug.cgi?id=101634

Patch by Robert Sesek <rsesek@chromium.org> on 2012-11-08
Reviewed by Adam Barth.

No new tests, just disabling unused code in Chromium port.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::adjustMediaSliderThumbSize):
(WebCore::RenderThemeMac::paintMediaFullscreenButton):
(WebCore::RenderThemeMac::paintMediaMuteButton):
(WebCore::RenderThemeMac::paintMediaPlayButton):
(WebCore::RenderThemeMac::paintMediaSeekBackButton):
(WebCore::RenderThemeMac::paintMediaSeekForwardButton):
(WebCore::RenderThemeMac::paintMediaSliderTrack):
(WebCore::RenderThemeMac::paintMediaSliderThumb):
(WebCore::RenderThemeMac::paintMediaRewindButton):
(WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton):
(WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
(WebCore::RenderThemeMac::paintMediaControlsBackground):
(WebCore::RenderThemeMac::paintMediaCurrentTime):
(WebCore::RenderThemeMac::paintMediaTimeRemaining):
(WebCore::RenderThemeMac::paintMediaVolumeSliderContainer):
(WebCore::RenderThemeMac::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeMac::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderTrack):
(WebCore::RenderThemeMac::paintMediaFullScreenVolumeSliderThumb):

8:50 PM Changeset in webkit [134003] by hayato@chromium.org
  • 7 edits in trunk/LayoutTests

Unreviewed, update chromium expectations for tables/.

  • platform/chromium-mac/tables/mozilla_expected_failures/core/backgrounds-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
8:34 PM Changeset in webkit [134002] by dpranke@chromium.org
  • 1985 edits
    2139 adds in trunk/LayoutTests

2012-11-08 Dirk Pranke <dpranke@chromium.org>

Unreviewed, update chromium-mac-mountainlion baselines for fast/

Also roll remaining mountainlion-specific failures into the main
TestExpectations file.

  • platform/chromium/TestExpectations:
  • platform/chromium-mac-mountainlion/TestExpectations:
8:21 PM Changeset in webkit [134001] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

Coordinated Graphics: Don't send the messages for releasing resources during purging.
https://bugs.webkit.org/show_bug.cgi?id=101685

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-08
Reviewed by Noam Rosenthal.

We don't need to send the messages related to releasing resources to UI Process
during purging, because UI Process already had removed all resources.
This patch gives us reducing slight messaging overhead and increasing readability.

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::purgeBackingStores):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::purgeReleasedImages):
(WebKit::LayerTreeCoordinator::removeTile):
(WebKit::LayerTreeCoordinator::removeUpdateAtlas):
(WebKit::LayerTreeCoordinator::purgeBackingStores):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

8:18 PM Changeset in webkit [134000] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ArrayPrototype.h should have correct indentation

Rubber stamped by Sam Weinig.

  • runtime/ArrayPrototype.h:
8:15 PM Changeset in webkit [133999] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] need to call closePopup at setValueAndClosePopup
https://bugs.webkit.org/show_bug.cgi?id=101568

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-11-08
Reviewed by George Staikos.

When early return occurs, we need to call closePopup
at setValueAndClosePopup function. See the comments
in WebCore/page/PagePopupClient.h. If we have not it,
Webkit thread is held and browser will be unresponsive
in BlackBerry port.

RIM PR 232962
Internally reviewed by Charles Wei.

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::setValueAndClosePopup):

7:51 PM Changeset in webkit [133998] by keishi@webkit.org
  • 4 edits in trunk

Enable calendar picker for input types week/month
https://bugs.webkit.org/show_bug.cgi?id=101553

Reviewed by Kent Tamura.

Source/WebCore:

Enabling calendar picker for <input type=week/month>

No new tests. Tests will be added later in Bug 101556 and Bug 101555.

  • rendering/RenderThemeChromiumCommon.cpp:

(WebCore::RenderThemeChromiumCommon::supportsCalendarPicker):

LayoutTests:

  • platform/chromium/TestExpectations: Mark week/month appearance tests as needs rebaseline.
7:43 PM Changeset in webkit [133997] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Change the default return value of MediaPlayerPrivate::hasSingleSecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=101681

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-11-08
Reviewed by George Staikos.

Since the platform player in BlackBerry disallows resources that come from different origins,
so it's safe to directly returns true here.

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::hasSingleSecurityOrigin):

7:36 PM Changeset in webkit [133996] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium expectations to remove a duplication.

  • platform/chromium/TestExpectations:
7:03 PM Changeset in webkit [133995] by mark.lam@apple.com
  • 54 edits
    10 moves in trunk/Source

Renamed ...InlineMethods.h files to ...Inlines.h.
https://bugs.webkit.org/show_bug.cgi?id=101145.

Reviewed by Geoffrey Garen.

This is only a refactoring effort to rename the files. There are no
functionality changes.

Source/JavaScriptCore:

  • API/JSObjectRef.cpp:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/CodeBlock.cpp:
  • dfg/DFGOperations.cpp:
  • heap/ConservativeRoots.cpp:
  • heap/CopiedBlock.h:
  • heap/CopiedSpace.cpp:
  • heap/CopiedSpaceInlineMethods.h: Removed.
  • heap/CopiedSpaceInlines.h: Copied from Source/JavaScriptCore/heap/CopiedSpaceInlineMethods.h.
  • heap/CopyVisitor.cpp:
  • heap/CopyVisitorInlineMethods.h: Removed.
  • heap/CopyVisitorInlines.h: Copied from Source/JavaScriptCore/heap/CopyVisitorInlineMethods.h.
  • heap/GCThread.cpp:
  • heap/GCThreadSharedData.cpp:
  • heap/HandleStack.cpp:
  • heap/Heap.cpp:
  • heap/HeapRootVisitor.h:
  • heap/MarkStack.cpp:
  • heap/MarkStackInlineMethods.h: Removed.
  • heap/MarkStackInlines.h: Copied from Source/JavaScriptCore/heap/MarkStackInlineMethods.h.
  • heap/SlotVisitor.cpp:
  • heap/SlotVisitor.h:
  • heap/SlotVisitorInlineMethods.h: Removed.
  • heap/SlotVisitorInlines.h: Copied from Source/JavaScriptCore/heap/SlotVisitorInlineMethods.h.
  • jit/HostCallReturnValue.cpp:
  • jit/JIT.cpp:
  • jit/JITArithmetic.cpp:
  • jit/JITArithmetic32_64.cpp:
  • jit/JITCall.cpp:
  • jit/JITCall32_64.cpp:
  • jit/JITInlineMethods.h: Removed.
  • jit/JITInlines.h: Copied from Source/JavaScriptCore/jit/JITInlineMethods.h.
  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp:
  • jit/JITPropertyAccess.cpp:
  • jit/JITPropertyAccess32_64.cpp:
  • jsc.cpp:
  • runtime/ArrayConstructor.cpp:
  • runtime/ArrayPrototype.cpp:
  • runtime/ButterflyInlineMethods.h: Removed.
  • runtime/ButterflyInlines.h: Copied from Source/JavaScriptCore/runtime/ButterflyInlineMethods.h.
  • runtime/IndexingHeaderInlineMethods.h: Removed.
  • runtime/IndexingHeaderInlines.h: Copied from Source/JavaScriptCore/runtime/IndexingHeaderInlineMethods.h.
  • runtime/JSActivation.h:
  • runtime/JSArray.cpp:
  • runtime/JSArray.h:
  • runtime/JSCell.h:
  • runtime/JSObject.cpp:
  • runtime/JSValueInlineMethods.h: Removed.
  • runtime/JSValueInlines.h: Copied from Source/JavaScriptCore/runtime/JSValueInlineMethods.h.
  • runtime/LiteralParser.cpp:
  • runtime/ObjectConstructor.cpp:
  • runtime/Operations.h:
  • runtime/RegExpMatchesArray.cpp:
  • runtime/RegExpObject.cpp:
  • runtime/StringPrototype.cpp:

Source/WebCore:

No new tests.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLEntityParser.cpp:
  • html/parser/HTMLTokenizer.cpp:
  • html/track/WebVTTTokenizer.cpp:
  • xml/parser/CharacterReferenceParserInlineMethods.h: Removed.
  • xml/parser/CharacterReferenceParserInlines.h: Copied from Source/WebCore/xml/parser/CharacterReferenceParserInlineMethods.h.
  • xml/parser/MarkupTokenizerInlineMethods.h: Removed.
  • xml/parser/MarkupTokenizerInlines.h: Copied from Source/WebCore/xml/parser/MarkupTokenizerInlineMethods.h.
  • xml/parser/XMLCharacterReferenceParser.cpp:
  • xml/parser/XMLTokenizer.cpp:
6:52 PM Changeset in webkit [133994] by commit-queue@webkit.org
  • 26 edits in trunk/Source

Unreviewed, rolling out r133984.
http://trac.webkit.org/changeset/133984
https://bugs.webkit.org/show_bug.cgi?id=101684

windows build error. (Requested by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-08

Source/WebCore:

  • Modules/indexeddb/IDBCallbacks.h:
  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::getObjectStoreId):
(WebCore):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBMetadata.h:

(WebCore::IDBObjectStoreMetadata::containsIndex):
(WebCore::IDBDatabaseMetadata::findObjectStore):
(IDBDatabaseMetadata):
(WebCore::IDBDatabaseMetadata::containsObjectStore):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put):
(WebCore):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):

  • Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReady):
(WebCore::IDBObjectStoreBackendImpl::index):
(WebCore::IDBObjectStoreBackendImpl::getIndexId):
(WebCore::IDBObjectStoreBackendImpl::getIndexIds):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h:
  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::objectStore):
(WebCore):

  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(IDBTransactionBackendImpl):

  • Modules/indexeddb/IDBTransactionBackendInterface.h:

Source/WebKit/chromium:

  • src/IDBObjectStoreBackendProxy.cpp:

(WebKit::IDBObjectStoreBackendProxy::putWithIndexKeys):
(WebKit):
(WebKit::IDBObjectStoreBackendProxy::setIndexKeys):
(WebKit::IDBObjectStoreBackendProxy::createIndex):
(WebKit::IDBObjectStoreBackendProxy::setIndexesReady):
(WebKit::IDBObjectStoreBackendProxy::index):
(WebKit::IDBObjectStoreBackendProxy::deleteIndex):

  • src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::deleteObjectStore):
(WebKit):
(WebKit::WebIDBDatabaseImpl::transaction):

  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • src/WebIDBObjectStoreImpl.cpp:

(WebKit::WebIDBObjectStoreImpl::putWithIndexKeys):
(WebKit):
(WebKit::WebIDBObjectStoreImpl::setIndexKeys):
(WebKit::WebIDBObjectStoreImpl::setIndexesReady):
(WebKit::WebIDBObjectStoreImpl::index):
(WebKit::WebIDBObjectStoreImpl::deleteIndex):

  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

  • src/WebIDBTransactionImpl.cpp:

(WebKit::WebIDBTransactionImpl::objectStore):
(WebKit):

  • src/WebIDBTransactionImpl.h:
6:49 PM Changeset in webkit [133993] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[QT] css3/line-break should be removed from TestExpectations.
https://bugs.webkit.org/show_bug.cgi?id=101562

Unreviewed gardening.

css3/line-break is removed by http://trac.webkit.org/changeset/133644.

Patch by Dongwoo Joshua Im <dw.im@samsung.com> on 2012-11-08

  • platform/qt/TestExpectations:
6:40 PM Changeset in webkit [133992] by shinyak@chromium.org
  • 8 edits in trunk/Source/WebCore

HTMLContentElement should preserve parsed CSSSelectorList
https://bugs.webkit.org/show_bug.cgi?id=101543

Reviewed by Dimitri Glazkov.

We would like to preserve CSSSelectorList for select attribute of HTMLContentElement.

Before, we parsed and validated select attribute every time distribution happens. If we preserve the parsed
CSSSelectorList, we can reduce distribution time.

This is also a prepration patch for Bug 101180. It also needs the parsed CSSSelectorList. We don't want to
parse and validate it again.

No new tests, covered by exising tests.

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorQuery::ContentSelectorQuery): We don't parse select attribute here anymore.
if it's already parsed.
(WebCore::ContentSelectorQuery::matches):

  • html/shadow/ContentSelectorQuery.h:

(ContentSelectorQuery):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::isSelectValid):
(WebCore::HTMLContentElement::ensureSelectParsed): If we don't have parsed the current select attribute,
we parse and validate it.
(WebCore::HTMLContentElement::parseAttribute): When select attribute is changed, we have to have a flag enabled
to parse select attrite again.
(WebCore::validateSubSelector): Moved from ContentSelectorQuery.
(WebCore):
(WebCore::validateSelector): Moved from ContentSelectorQuery.
(WebCore::HTMLContentElement::validateSelect):

  • html/shadow/HTMLContentElement.h:

(HTMLContentElement):
(WebCore::HTMLContentElement::setSelect):
(WebCore):
(WebCore::HTMLContentElement::selectorList):

  • html/shadow/HTMLShadowElement.cpp:

(WebCore::HTMLShadowElement::emptySelectorList):
(WebCore):

  • html/shadow/HTMLShadowElement.h:

(HTMLShadowElement):
(WebCore::HTMLShadowElement::selectorList):

  • html/shadow/InsertionPoint.h:

(InsertionPoint):

6:04 PM Changeset in webkit [133991] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ArrayConstructor.h should have correct indentation

Rubber stamped by Sam Weinig.

  • runtime/ArrayConstructor.h:
5:57 PM Changeset in webkit [133990] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG should know that int == null is always false
https://bugs.webkit.org/show_bug.cgi?id=101665

Reviewed by Oliver Hunt.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

5:54 PM Changeset in webkit [133989] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, update chromium expectations for chromium-mac-mountainlion svg failure.

  • platform/chromium/TestExpectations:
5:49 PM Changeset in webkit [133988] by dpranke@chromium.org
  • 873 edits
    879 adds in trunk

Unreviewed, chromium-mac-mountainlion baselines for tables/.

  • platform/chromium/TestExpectations:
  • platform/chromium-mac-mountainlion/TestExpectations:
5:42 PM Changeset in webkit [133987] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Arguments.h should have correct indentation

Rubber stamped by Sam Weinig.

  • runtime/Arguments.h:
5:41 PM Changeset in webkit [133986] by jsbell@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Unreviewed gardening following r133972.

  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/exif-orientation-expected.png: Added.
5:38 PM Changeset in webkit [133985] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

It should be possible to JIT compile get_by_vals and put_by_vals even if the DFG is disabled.

Reviewed by Oliver Hunt.

  • jit/JITInlineMethods.h:

(JSC::JIT::chooseArrayMode):

5:36 PM Changeset in webkit [133984] by alecflett@chromium.org
  • 26 edits in trunk/Source

IndexedDB: switch frontend to use int64_t-based references
https://bugs.webkit.org/show_bug.cgi?id=100426

Reviewed by Tony Chang.

Source/WebCore:

Remove String-based objectStore/index references, obsoleted by
https://bugs.webkit.org/show_bug.cgi?id=100425.

No new tests as this is the second half of a refactor.

  • Modules/indexeddb/IDBCallbacks.h:
  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transaction):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBMetadata.h:

(WebCore::IDBObjectStoreMetadata::findIndex):
(IDBObjectStoreMetadata):
(WebCore::IDBObjectStoreMetadata::containsIndex):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put):
(WebCore):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h:
  • inspector/Inspector-1.0.json:
  • inspector/Inspector.json:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):
(WebCore::InspectorIndexedDBAgent::requestData):

  • inspector/InspectorIndexedDBAgent.h:

(InspectorIndexedDBAgent):

Source/WebKit/chromium:

Remove implementation stubs from chromium API for
methods obsoleted by https://bugs.webkit.org/show_bug.cgi?id=100425

  • src/IDBObjectStoreBackendProxy.cpp:
  • src/IDBObjectStoreBackendProxy.h:

(IDBObjectStoreBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:
  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • src/WebIDBObjectStoreImpl.cpp:
  • src/WebIDBObjectStoreImpl.h:

(WebIDBObjectStoreImpl):

5:34 PM Changeset in webkit [133983] by bashi@chromium.org
  • 4 edits
    2 adds in trunk

[Chromium] Arabic digits should appear left-to-right
https://bugs.webkit.org/show_bug.cgi?id=101440

Reviewed by Tony Chang.

Source/WebCore:

Call hb_buffer_set_direction() to set direction when drawing glyphs or
direction should be overridden. Leave direction setting to HarfBuzz when
WebKit is calculating widths because the direction is LTR by default while
calculating widths. Set script before shaping so that HarfBuzz can estimate
appropriate direction.

Test: fast/text/international/arabic-digits.html

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::HarfBuzzRun::HarfBuzzRun):
Add m_script. This holds the script of the run.
(WebCore::HarfBuzzShaper::shape):
Tell shapeHarfBuzzRuns() to set direction when drawing glyphs or
direction should be overridden.
(WebCore::HarfBuzzShaper::collectHarfBuzzRuns):
Set script of HarfBuzzRuns.
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):
Add an argument that indicates it should set direction.

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:

(WebCore::HarfBuzzShaper::HarfBuzzRun::create):
(WebCore::HarfBuzzShaper::HarfBuzzRun::rtl):
(WebCore::HarfBuzzShaper::HarfBuzzRun::script):
(HarfBuzzRun):
(HarfBuzzShaper):

LayoutTests:

Add a test that checks Arabic digits appear in increasing order from left to right.

  • fast/text/international/arabic-digits-expected.html: Added.
  • fast/text/international/arabic-digits.html: Added.
5:33 PM Changeset in webkit [133982] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] WebElement::hasHTMLTagName returns true for non-HTML elements
https://bugs.webkit.org/show_bug.cgi?id=101537

Reviewed by Abhishek Arya.

We should not do ignore-case comparison for tagName, which is always
upper-case and createElementNS(xhtmlNS, "INPUT") doesn't create an
HTMLInputElement object. We need to check if localName is equal to
"input" in this case.

  • src/WebElement.cpp:

(WebKit::WebElement::hasHTMLTagName):

5:31 PM Changeset in webkit [133981] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[TexMap] Remove contentsLayer() in GraphicsLayerTextureMapper.
https://bugs.webkit.org/show_bug.cgi?id=101658

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-08
Reviewed by Noam Rosenthal.

GraphicsLayerTextureMapper::contentsLayer() is duplicated to
GraphicsLayer::platformLayer(), so we remove it.

No new tests, this is just a refactor.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(WebCore::GraphicsLayerTextureMapper::platformLayer):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::flushCompositingStateSelf):

5:27 PM Changeset in webkit [133980] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

op_call should have LLInt call link info even if the DFG is disabled
https://bugs.webkit.org/show_bug.cgi?id=101672

Reviewed by Oliver Hunt.

Get rid of the evil uses of fall-through.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

5:25 PM Changeset in webkit [133979] by jpetsovits@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Replace checkerboard with page background color.
https://bugs.webkit.org/show_bug.cgi?id=101652
RIM PR 188235

Reviewed by George Staikos.

In order to do this, we introduce a new member variable for
BackingStore because when blitting, we can't access the
page background color in a threadsafe way.

Solid background color fill is still only used for public builds.
Developers and beta testers should still see checkerboard and
do something about it.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::fillWindow):
(BlackBerry::WebKit::BackingStorePrivate::webPageBackgroundColorUserInterfaceThread):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::setWebPageBackgroundColor):

  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

5:21 PM Changeset in webkit [133978] by yael@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Some more gardening after r133898.

  • platform/efl/TestExpectations:
5:20 PM Changeset in webkit [133977] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Null check URL key entries into WebHistory hash table.
https://bugs.webkit.org/show_bug.cgi?id=101664
<rdar://problem/12440852>

Reviewed by Brady Eidson.

Sometimes the _entriesByURL hash table used to keep track of web history is erroneously passed in null key entries, which causes an exception to fire.
This prevents the desired page navigation from taking effect. This is a workaround for the problem.
Ideally we would figure out where the null values for the key are coming from but for now we'll just set it to "" to prevent the exception from being thrown
so that navigation can continue as expected.

  • History/WebHistory.mm:

(-[WebHistoryPrivate visitedURL:withTitle:increaseVisitCount:]):

5:15 PM Changeset in webkit [133976] by benjamin@webkit.org
  • 96 edits in trunk/Source

Improve the use of AtomicString with literals
https://bugs.webkit.org/show_bug.cgi?id=101298

Reviewed by Darin Adler.

Fix a bunch of cases of AtomicString with literals:
-Do not create temporary AtomicString to perform a comparison, that is very wasteful.
-Use the ConstructFromLiteral constructor whenever it makes sense.
-Make "x-frame-options" static instead of creating it for each response.
-Use ASCIILiteral() instead of AtomicString() in EventHandler, the function takes a String,

not an AtomicString.

  • Modules/battery/BatteryController.cpp:

(WebCore::BatteryController::supplementName):

  • Modules/battery/NavigatorBattery.cpp:

(WebCore::NavigatorBattery::from):

  • Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp:

(WebCore::DraggedIsolatedFileSystem::supplementName):

  • Modules/gamepad/NavigatorGamepad.cpp:

(WebCore::NavigatorGamepad::from):

  • Modules/geolocation/GeolocationController.cpp:

(WebCore::GeolocationController::supplementName):

  • Modules/geolocation/NavigatorGeolocation.cpp:

(WebCore::NavigatorGeolocation::from):

  • Modules/indexeddb/DOMWindowIndexedDatabase.cpp:

(WebCore::DOMWindowIndexedDatabase::from):

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::directionNext):
(WebCore::IDBCursor::directionNextUnique):
(WebCore::IDBCursor::directionPrev):
(WebCore::IDBCursor::directionPrevUnique):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::readyState):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::modeReadOnly):
(WebCore::IDBTransaction::modeReadWrite):
(WebCore::IDBTransaction::modeVersionChange):
(WebCore::IDBTransaction::modeReadOnlyLegacy):
(WebCore::IDBTransaction::modeReadWriteLegacy):

  • Modules/indexeddb/PageGroupIndexedDatabase.cpp:

(WebCore::PageGroupIndexedDatabase::from):

  • Modules/intents/DOMWindowIntents.cpp:

(WebCore::DOMWindowIntents::from):

  • Modules/mediastream/UserMediaController.cpp:

(WebCore::UserMediaController::supplementName):

  • Modules/navigatorcontentutils/NavigatorContentUtils.cpp:

(WebCore::NavigatorContentUtils::supplementName):

  • Modules/networkinfo/NavigatorNetworkInfoConnection.cpp:

(WebCore::NavigatorNetworkInfoConnection::from):

  • Modules/networkinfo/NetworkInfoController.cpp:

(WebCore::NetworkInfoController::supplementName):

  • Modules/notifications/DOMWindowNotifications.cpp:

(WebCore::DOMWindowNotifications::from):

  • Modules/notifications/NotificationController.cpp:

(WebCore::NotificationController::supplementName):

  • Modules/quota/DOMWindowQuota.cpp:

(WebCore::DOMWindowQuota::from):

  • Modules/speech/SpeechRecognitionController.cpp:

(WebCore::SpeechRecognitionController::supplementName):

  • Modules/vibration/Vibration.cpp:

(WebCore::Vibration::supplementName):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::invalidStatus):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::ariaLiveRegionStatus):
(WebCore::AccessibilityRenderObject::ariaLiveRegionRelevant):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedSecurityCheck):

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::namedPropertyGetter):

  • dom/ContextFeatures.cpp:

(WebCore::ContextFeatures::supplementName):

  • dom/DeviceMotionController.cpp:

(WebCore::DeviceMotionController::supplementName):

  • dom/DeviceOrientationController.cpp:

(WebCore::DeviceOrientationController::supplementName):

  • dom/Element.cpp:

(WebCore::Element::webkitRegionOverset):

  • dom/MutationRecord.cpp:
  • html/FileInputType.cpp:

(WebCore::UploadButtonElement::shadowPseudoId):

  • html/FormController.cpp:

(WebCore::SavedFormState::getReferencedFilePaths):
(WebCore::FormKeyGenerator::formKey):

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::formControlType):

  • html/HTMLDetailsElement.cpp:

(WebCore::summaryQuerySelector):

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::formControlType):

  • html/HTMLKeygenElement.cpp:

(WebCore::KeygenSelectElement::shadowPseudoId):
(WebCore::HTMLKeygenElement::formControlType):

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::formControlType):

  • html/HTMLOutputElement.cpp:

(WebCore::HTMLOutputElement::formControlType):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::formControlType):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::formControlType):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::directionString):

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::DateTimeEditElement):

  • html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeAMPMFieldElement::create):
(WebCore::DateTimeDayFieldElement::create):
(WebCore::DateTimeHourFieldElement::create):
(WebCore::DateTimeMillisecondFieldElement::create):
(WebCore::DateTimeMinuteFieldElement::create):
(WebCore::DateTimeMonthFieldElement::create):
(WebCore::DateTimeSecondFieldElement::create):
(WebCore::DateTimeSymbolicMonthFieldElement::create):
(WebCore::DateTimeWeekFieldElement::create):
(WebCore::DateTimeYearFieldElement::create):

  • html/shadow/DetailsMarkerControl.cpp:

(WebCore::DetailsMarkerControl::shadowPseudoId):

  • html/shadow/ImageInnerElement.cpp:

(WebCore::ImageInnerElement::shadowPseudoId):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::shadowPseudoId):
(WebCore::MediaControlTimelineContainerElement::shadowPseudoId):
(WebCore::MediaControlVolumeSliderContainerElement::shadowPseudoId):
(WebCore::MediaControlStatusDisplayElement::shadowPseudoId):
(WebCore::MediaControlPanelMuteButtonElement::shadowPseudoId):
(WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId):
(WebCore::MediaControlPlayButtonElement::shadowPseudoId):
(WebCore::MediaControlOverlayPlayButtonElement::shadowPseudoId):
(WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId):
(WebCore::MediaControlSeekBackButtonElement::shadowPseudoId):
(WebCore::MediaControlRewindButtonElement::shadowPseudoId):
(WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId):
(WebCore::MediaControlTimelineElement::shadowPseudoId):
(WebCore::MediaControlVolumeSliderElement::shadowPseudoId):
(WebCore::MediaControlFullscreenVolumeSliderElement::shadowPseudoId):
(WebCore::MediaControlFullscreenButtonElement::shadowPseudoId):
(WebCore::MediaControlFullscreenVolumeMinButtonElement::shadowPseudoId):
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::shadowPseudoId):
(WebCore::MediaControlTimeRemainingDisplayElement::shadowPseudoId):
(WebCore::MediaControlCurrentTimeDisplayElement::shadowPseudoId):
(WebCore::MediaControlTextTrackContainerElement::shadowPseudoId):

  • html/shadow/MediaControlRootElement.cpp:

(WebCore::MediaControlRootElement::shadowPseudoId):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlPanelEnclosureElement::shadowPseudoId):
(WebCore::MediaControlRootElementChromium::shadowPseudoId):

  • html/shadow/MediaControlRootElementChromiumAndroid.cpp:

(WebCore::MediaControlOverlayEnclosureElement::shadowPseudoId):

  • html/shadow/MeterShadowElement.cpp:

(WebCore::MeterInnerElement::shadowPseudoId):
(WebCore::MeterBarElement::shadowPseudoId):
(WebCore::MeterValueElement::shadowPseudoId):

  • html/shadow/ProgressShadowElement.cpp:

(WebCore::ProgressInnerElement::shadowPseudoId):
(WebCore::ProgressBarElement::shadowPseudoId):
(WebCore::ProgressValueElement::shadowPseudoId):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::sliderThumbShadowPseudoId):
(WebCore::mediaSliderThumbShadowPseudoId):
(WebCore::SliderContainerElement::shadowPseudoId):

  • html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::shadowPseudoId):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldResultsButtonElement::shadowPseudoId):
(WebCore::SearchFieldCancelButtonElement::shadowPseudoId):
(WebCore::InputFieldSpeechButtonElement::shadowPseudoId):

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCueBox::textTrackCueBoxShadowPseudoId):

  • loader/CrossOriginAccessControl.cpp:

(WebCore::passesAccessControlCheck):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

  • loader/PrerendererClient.cpp:

(WebCore::PrerendererClient::supplementName):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::updateResponseAfterRevalidation):

  • page/DOMWindowPagePopup.cpp:

(WebCore::DOMWindowPagePopup::supplementName):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handlePasteGlobalSelection):
(WebCore::focusDirectionForKey):

  • page/SpeechInput.cpp:

(WebCore::SpeechInput::supplementName):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::updateKeyframeAnimations):

  • platform/graphics/FontCache.cpp:

(WebCore::alternateFamilyName):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::applicationOctetStream):
(WebCore::textPlain):
(WebCore::codecs):

  • platform/graphics/chromium/FontCacheAndroid.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::effectName):

  • platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::effectName):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/skia/FontCacheSkia.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

  • platform/graphics/wx/FontCacheWx.cpp:

(WebCore::FontCache::getSimilarFontPlatformData):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::parseCacheControlDirectives):
(WebCore::ResourceResponseBase::hasCacheValidatorFields):
(WebCore::ResourceResponseBase::date):
(WebCore::ResourceResponseBase::age):
(WebCore::ResourceResponseBase::expires):
(WebCore::ResourceResponseBase::lastModified):
(WebCore::ResourceResponseBase::isAttachment):

  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::getAvgCharWidth):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::getAvgCharWidth):
(WebCore::RenderTextControlSingleLine::preferredContentWidth):

  • svg/SVGAnimateColorElement.cpp:

(WebCore::attributeValueIsCurrentColor):

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::rotateMode):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::setCalcMode):
(WebCore::SVGAnimationElement::setAttributeType):
(WebCore::SVGAnimationElement::isAdditive):
(WebCore::SVGAnimationElement::isAccumulated):
(WebCore::inheritsFromProperty):

  • svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthXIdentifier):
(WebCore::SVGFEConvolveMatrixElement::kernelUnitLengthYIdentifier):
(WebCore::SVGFEConvolveMatrixElement::orderXIdentifier):
(WebCore::SVGFEConvolveMatrixElement::orderYIdentifier):

  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthXIdentifier):
(WebCore::SVGFEDiffuseLightingElement::kernelUnitLengthYIdentifier):

  • svg/SVGFEDropShadowElement.cpp:

(WebCore::SVGFEDropShadowElement::stdDeviationXIdentifier):
(WebCore::SVGFEDropShadowElement::stdDeviationYIdentifier):

  • svg/SVGFEGaussianBlurElement.cpp:

(WebCore::SVGFEGaussianBlurElement::stdDeviationXIdentifier):
(WebCore::SVGFEGaussianBlurElement::stdDeviationYIdentifier):

  • svg/SVGFEMorphologyElement.cpp:

(WebCore::SVGFEMorphologyElement::radiusXIdentifier):
(WebCore::SVGFEMorphologyElement::radiusYIdentifier):

  • svg/SVGFESpecularLightingElement.cpp:

(WebCore::SVGFESpecularLightingElement::kernelUnitLengthXIdentifier):
(WebCore::SVGFESpecularLightingElement::kernelUnitLengthYIdentifier):

  • svg/SVGFETurbulenceElement.cpp:

(WebCore::SVGFETurbulenceElement::baseFrequencyXIdentifier):
(WebCore::SVGFETurbulenceElement::baseFrequencyYIdentifier):

  • svg/SVGFilterElement.cpp:

(WebCore::SVGFilterElement::filterResXIdentifier):
(WebCore::SVGFilterElement::filterResYIdentifier):

  • svg/SVGLangSpace.cpp:

(WebCore::SVGLangSpace::xmlspace):
(WebCore::SVGLangSpace::addSupportedAttributes):

  • svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::orientTypeIdentifier):
(WebCore::SVGMarkerElement::orientAngleIdentifier):
(WebCore::SVGMarkerElement::synchronizeOrientType):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::contentScriptType):
(WebCore::SVGSVGElement::contentStyleType):

  • svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::type):
(WebCore::SVGStyleElement::media):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::collectStyleForAttribute):

  • svg/SVGViewSpec.cpp:

(WebCore::SVGViewSpec::viewBoxIdentifier):
(WebCore::SVGViewSpec::preserveAspectRatioIdentifier):
(WebCore::SVGViewSpec::transformIdentifier):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::parseClockValue):
(WebCore::SVGSMILElement::restart):
(WebCore::SVGSMILElement::fill):
(WebCore::SVGSMILElement::repeatCount):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::from):

  • xml/parser/XMLTreeBuilder.cpp:

(WebCore::XMLTreeBuilder::processDOCTYPE):
(WebCore::XMLTreeBuilder::processXMLEntity):

5:12 PM Changeset in webkit [133975] by oliver@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Improve effectiveness of function-level caching
https://bugs.webkit.org/show_bug.cgi?id=101667

Reviewed by Filip Pizlo.

Added a random-eviction based cache for unlinked functions, and switch
UnlinkedFunctionExecutable's code references to Weak<>, thereby letting
us remove the explicit UnlinkedFunctionExecutable::clearCode() calls that
were being triggered by GC.

Refactored the random eviction part of the CodeCache into a separate data
structure so that I didn't have to duplicate the code again, and then used
that for the new function cache.

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::visitChildren):
(JSC::UnlinkedFunctionExecutable::codeBlockFor):

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedFunctionExecutable::clearCodeForRecompilation):
(UnlinkedFunctionExecutable):

  • debugger/Debugger.cpp:
  • runtime/CodeCache.cpp:

(JSC::CodeCache::getCodeBlock):
(JSC::CodeCache::generateFunctionCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
(JSC::CodeCache::usedFunctionCode):
(JSC):

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::clearUnlinkedCodeForRecompilationIfNotCompiling):
(JSC::FunctionExecutable::clearCode):

  • runtime/Executable.h:

(FunctionExecutable):

5:01 PM Changeset in webkit [133974] by Beth Dakin
  • 7 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=101644
Fixed header on Facebook news feed becomes detached from top of
viewport after rubber band scrolling
-and corresponding-
<rdar://problem/12651944>

Reviewed by Simon Fraser.

Source/WebCore:

There is code to handle this for non-threaded scrolling on FrameView.
This patch moves most of that code into a convenience function on
ScrollingCoordinator.

Have FrameView::scrollOffsetForFixedPosition() call
WebCore::scrollOffsetForFixedPosition() with all the right
parameters.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollOffsetForFixedPosition):

Here's where all the math happens.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::fixedPositionScrollOffset):
(WebCore::scrollOffsetForFixedPosition):

The viewportRect in these three places needs to have the
adjusted-for-fixed offset.
(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeFixedViewportConstraints):

LayoutTests:

New test ensures that negative offsets will not make their way into
the FixedPositionViewportConstraints.

  • platform/mac/tiled-drawing/fixed/negative-scroll-offset-expected.txt: Added.
  • platform/mac/tiled-drawing/fixed/negative-scroll-offset.html: Added.
4:20 PM Changeset in webkit [133973] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/Source/JavaScriptCore

Merged r125806. <rdar://problem/12486139>

4:19 PM Changeset in webkit [133972] by hclam@chromium.org
  • 5 edits
    5 deletes in trunk

[chromium] Deferred image decoding fails with image orientation
https://bugs.webkit.org/show_bug.cgi?id=101648

Reviewed by Stephen White.

Source/WebCore:

When an image is deferred save the orientation state. Once this state
is cached it can be used to reply future queries since this state is
static.

No new tests but platform/chromium/virtual/deferred/fast/images/image-orientation.html is passing now.

  • platform/graphics/chromium/DeferredImageDecoder.cpp:

(WebCore::DeferredImageDecoder::DeferredImageDecoder):
(WebCore::DeferredImageDecoder::frameBufferAtIndex):
(WebCore::DeferredImageDecoder::orientation):

  • platform/graphics/chromium/DeferredImageDecoder.h:

(DeferredImageDecoder):

LayoutTests:

Update test expectations and baselines accordingly since these two
tests are now passing with deferred image decoding.

fast/images/exif-orientation-image-document.html
fast/images/exif-orientation.html

  • platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/exif-orientation-image-document-expected.png: Removed.
  • platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/exif-orientation-image-document-expected.png: Removed.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/exif-orientation-image-document-expected.png: Removed.
  • platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/exif-orientation-image-document-expected.png: Removed.
  • platform/chromium-win/platform/chromium/virtual/deferred/fast/images/exif-orientation-image-document-expected.png: Removed.
  • platform/chromium/TestExpectations:
4:15 PM Changeset in webkit [133971] by fpizlo@apple.com
  • 6 edits
    1 add in trunk/Source/JavaScriptCore

DFG constant folding and CFG simplification should be smart enough to know that if a logical op's operand is proven to have a non-masquerading structure then it always evaluates to true
https://bugs.webkit.org/show_bug.cgi?id=101511

Reviewed by Oliver Hunt.

To make life easier, this moves BranchDirection into BasicBlock so that after
running the CFA, we always know, for each block, what direction the CFA
proved. CFG simplification now both uses and preserves cfaBranchDirection in
its transformations.

Also made both LogicalNot and Branch check whether the operand is a known cell
with a known structure, and if so, made them do the appropriate folding.

5% speed-up on V8/raytrace because it makes raytrace's own null checks
evaporate (i.e. idioms like 'if (!x) throw "unhappiness"') thanks to the fact
that we were already doing structure check hoisting.

(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeToSuccessors):

  • dfg/DFGAbstractState.h:

(AbstractState):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::BasicBlock):
(BasicBlock):

  • dfg/DFGBranchDirection.h: Added.

(DFG):
(JSC::DFG::branchDirectionToString):
(JSC::DFG::isKnownDirection):
(JSC::DFG::branchCondition):

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

4:12 PM Changeset in webkit [133970] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

DocumentLoader: Shrink-to-fit the ResourceResponse vector after loading completes.
<http://webkit.org/b/101657>

Reviewed by Anders Carlsson.

Shrink DocumentLoader::m_responses to exact size when we stop adding responses to it,
as we know it won't grow after that.

520kB progression on Membuster3.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::stopRecordingResponses):

4:10 PM Changeset in webkit [133969] by Lucas Forschler
  • 6 edits
    2 copies in branches/safari-536.28-branch

Merged r125695. <rdar://problem/12665292>

4:09 PM Changeset in webkit [133968] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

[CSS Exclusions] Polygon with horizontal bottom edges returns incorrect segments
https://bugs.webkit.org/show_bug.cgi?id=100874

Patch by Hans Muller <hmuller@adobe.com> on 2012-11-08
Reviewed by Dirk Schulze.

Source/WebCore:

Revised the way that computeXIntersections() handles intersections with horizotal polygon edges.
Deciding if a vertex intersection corresponds to a polygon "edge crossing", i.e. a change from inside
to outside or outside to inside, now depends on which side of the horizontal line the function's
y parameter corresponds to. If the y corresponds to the top of the line, then isaMinY the parameter
is true, and an intersection with a horizontal edge is only considered to be an edge crossing if
if the inside of the polygon is just below the horizontal edge. When isMinY is false then the inside
of the polygon must be just above the horizontal edge.

Tests: fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-003.html

fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-004.html

  • rendering/ExclusionPolygon.cpp:

(WebCore::getVertexIntersectionVertices): Corrected two cases where the next/previous vertex was determined incorrectly.
(WebCore::ExclusionPolygon::computeXIntersections): Added a bool isMinY parameter which specifies if the y parameter corresponds to the top or bottom a horizontal line.
(WebCore::ExclusionPolygon::getExcludedIntervals): Added the new computeXIntersections() parameter.
(WebCore::ExclusionPolygon::getIncludedIntervals): Ditto.

  • rendering/ExclusionPolygon.h:

(WebCore::ExclusionPolygonEdge::previousEdge): Corrected the previousEdge() function.

LayoutTests:

Added two additional tests for rectilinear polygons, where the tops and bottoms
of lines intersect the polygons' horizontal edges. More tests of this kind will
be needed when exclusion layout supports polygons that break horizontal lines up
into more than one segment.

  • fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-003-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-003.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-004-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rectilinear-polygon-004.html: Added.
4:07 PM Changeset in webkit [133967] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Unused parameters on LayerTreeRenderer.cpp
https://bugs.webkit.org/show_bug.cgi?id=101653

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-08
Reviewed by Noam Rosenthal.

Because the 'tileID' parameter is not used now,
comment out it to fix build warning -Wunused-parameter

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::removeBackingStoreIfNeeded):

4:05 PM Changeset in webkit [133966] by commit-queue@webkit.org
  • 4 edits
    8 adds in trunk

[JSC] HTML extensions to String.prototype should escape " as &quot; in argument values
https://bugs.webkit.org/show_bug.cgi?id=90667

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-08
Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

Escape quotation mark as &quot; in argument values to:

  • String.prototype.anchor(name)
  • String.prototype.fontcolor(color)
  • String.prototype.fontsize(size)
  • String.prototype.link(href)

This behavior matches Chromium/V8 and Firefox/Spidermonkey
implementations and is requited by:
http://mathias.html5.org/specs/javascript/#escapeattributevalue

This also fixes a potential security risk (XSS vector).

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
(JSC::stringProtoFuncLink):

LayoutTests:

Add layout test coverage for the following String.prototype methods:

  • String.prototype.anchor(name)
  • String.prototype.fontcolor(color)
  • String.prototype.fontsize(size)
  • String.prototype.link(href)

Those tests also check that the quotation mark is correctly escaped
in argument values to prevent potential exploits.

  • fast/js/string-anchor-expected.txt: Added.
  • fast/js/string-anchor.html: Added.
  • fast/js/string-fontcolor-expected.txt: Added.
  • fast/js/string-fontcolor.html: Added.
  • fast/js/string-fontsize-expected.txt: Added.
  • fast/js/string-fontsize.html: Added.
  • fast/js/string-link-expected.txt: Added.
  • fast/js/string-link.html: Added.
  • platform/chromium/TestExpectations: Skip new tests for chromium port due

to http://code.google.com/p/v8/issues/detail?id=2218

3:50 PM Changeset in webkit [133965] by jsbell@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening. Added missing *-expected.txt following rebaselines.

  • platform/chromium-mac/fast/css/text-overflow-input-expected.txt: Added.
  • platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.txt: Added.
  • platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.txt: Added.
3:50 PM Changeset in webkit [133964] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Disable cookies on file://
https://bugs.webkit.org/show_bug.cgi?id=101646

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-11-08
Reviewed by Rob Buis.

Disabling cookies on file and local in the browser app.

PR 239779

Tested by trying to set and retrieve cookies on WI while browsing
files on the file scheme.

  • platform/blackberry/CookieManager.cpp:

(WebCore):
(WebCore::shouldIgnoreScheme):
(WebCore::CookieManager::getRawCookies):
(WebCore::CookieManager::checkAndTreatCookie):

3:47 PM Changeset in webkit [133963] by jsbell@chromium.org
  • 7 edits in trunk/Source

Expose snapshots in platform/leveldb wrapper API
https://bugs.webkit.org/show_bug.cgi?id=100786

Reviewed by Tony Chang.

Source/WebCore:

Expose leveldb "snapshots" in the LevelDB API. A snapshot lets you observe the database
as it was when the snapshot was taken. This can be used to implement parallel transactions,
e.g. where a read transaction won't see updates made by a later write transaction.

Tests: webkit_unit_tests --gtest_filter='LevelDBDatabaseTest.Transaction*'

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBSnapshot::LevelDBSnapshot): New (but for now internal-only) wrapper type.
(WebCore):
(WebCore::LevelDBSnapshot::~LevelDBSnapshot): Release the leveldb::Snapshot.
(WebCore::LevelDBDatabase::get): Optional snapshot argument, for use by transactions.
(WebCore::LevelDBDatabase::createIterator): Ditto.

  • platform/leveldb/LevelDBDatabase.h:

(leveldb):
(WebCore):
(LevelDBSnapshot):
(LevelDBDatabase):

  • platform/leveldb/LevelDBTransaction.cpp:

(WebCore::LevelDBTransaction::LevelDBTransaction): Initialize a snapshot.
(WebCore::LevelDBTransaction::get):
(WebCore::LevelDBTransaction::TransactionIterator::TransactionIterator):

  • platform/leveldb/LevelDBTransaction.h:

(LevelDBTransaction):

Source/WebKit/chromium:

Add unit tests for transactions/snapshots.

  • tests/LevelDBTest.cpp:

(WebCore::encodeString): Don't append to pre-sized vector.
(WebCore::TEST):
(WebCore):

3:41 PM Changeset in webkit [133962] by yael@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Some more gardening after r133898.

  • platform/efl/TestExpectations:
3:34 PM Changeset in webkit [133961] by commit-queue@webkit.org
  • 9 edits in trunk

[EFL][WK2] Add proper support for fullscreen API to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=101615

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-08
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::enterFullScreen):

  • UIProcess/API/efl/ewk_security_origin.cpp:

(EwkSecurityOrigin::EwkSecurityOrigin):

  • UIProcess/API/efl/ewk_security_origin_private.h:

(EwkSecurityOrigin::create): Add factory method to construct a
EwkSecurityOrigin from a KURL.
(EwkSecurityOrigin):

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_fullscreen_exit): Add public API function to exit
fullscreen mode.

  • UIProcess/API/efl/ewk_view.h: Add security origin parameter

to fullscreen_enter smart function since this information is
useful to the user agent.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(fullScreenCallback):
(fullScreenExitCallback):
(TEST_F):

Tools:

Implement fullscreen API support in MiniBrowser. When entering
fullscreen a popup is shown to notify the user that something
is displayed in fullscreen and to advertise that the Escape
key can be used to exit fullscreen. This behavior is according
to specification.

  • MiniBrowser/efl/main.c:

(on_key_down):
(on_fullscreen_accept):
(on_fullscreen_deny):
(on_fullscreen_enter):
(on_fullscreen_exit):
(window_create):

3:32 PM Changeset in webkit [133960] by jsbell@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening - rebaseline a couple of tests for lion.

  • platform/chromium-mac-lion/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/basic-textareas-expected.png: Added.
3:32 PM Changeset in webkit [133959] by andersca@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

HeapStatistics::s_pauseTimeStarts and s_pauseTimeEnds should be Vectors
https://bugs.webkit.org/show_bug.cgi?id=101651

Reviewed by Andreas Kling.

HeapStatistics uses Deques when Vectors would work just as good.

  • heap/HeapStatistics.cpp:
  • heap/HeapStatistics.h:

(HeapStatistics):

3:08 PM Changeset in webkit [133958] by Lucas Forschler
  • 3 edits
    1 copy in branches/safari-536.28-branch

Merged r125597. <rdar://problem/12516348>

3:04 PM Changeset in webkit [133957] by beidson@apple.com
  • 17 edits
    3 copies
    1 add in trunk/Source

Have NetworkProcess do the actual loading of subresources.
https://bugs.webkit.org/show_bug.cgi?id=101640

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests (No change in behavior in any configuration we test.)

  • WebCore.exp.in:
  • loader/ResourceBuffer.h: Virtualize a few methods for ports to override.

Source/WebKit2:

This adds actual loading of subresources in the NetworkProcess.

Currently a resource just gets its entire buffer of data built up and then delivered to the WebProcess in one chunk.

Many FIXMEs point the path towards much better behavior.

Project file stuff:

  • WebKit2.xcodeproj/project.pbxproj:

Add a new Logging channel for scheduling so the one for loading can be separate:

  • Platform/Logging.cpp:
  • Platform/Logging.h:

Add an enhancement FIXME:

  • NetworkProcess/HostRecord.cpp:

(WebKit::HostRecord::remove):

NetworkRequest now derives from ResourceHandleClient and does actual loading, messaging WebProcess as it does:

  • NetworkProcess/NetworkRequest.cpp:

(WebKit::NetworkRequest::NetworkRequest):
(WebKit::NetworkRequest::~NetworkRequest):
(WebKit::NetworkRequest::start):
(WebKit::requestsToStopMutex):
(WebKit::requestsToStop):
(WebKit::NetworkRequest::scheduleStopOnMainThread): Stop
(WebKit::NetworkRequest::performStops):
(WebKit::NetworkRequest::stop): Does NetworkRequest cleanup that happens no matter the state of the network load.
(WebKit::NetworkRequest::didReceiveResponse):
(WebKit::NetworkRequest::didReceiveData):
(WebKit::NetworkRequest::didFinishLoading):
(WebKit::NetworkRequest::didFail):

  • NetworkProcess/NetworkRequest.h:

Change some logging and now invalid asserts, as well as starting requests in-process instead of relying on WebProcess:

  • NetworkProcess/NetworkResourceLoadScheduler.cpp:

(WebKit::NetworkResourceLoadScheduler::scheduleNetworkRequest):
(WebKit::NetworkResourceLoadScheduler::addLoadInProgress):
(WebKit::NetworkResourceLoadScheduler::removeLoadIdentifier):
(WebKit::NetworkResourceLoadScheduler::crossOriginRedirectReceived):
(WebKit::NetworkResourceLoadScheduler::servePendingRequests):
(WebKit::NetworkResourceLoadScheduler::servePendingRequestsForHost):
(WebKit::NetworkResourceLoadScheduler::removeScheduledLoadIdentifiers):
(WebKit::NetworkResourceLoadScheduler::scheduleRemoveLoadIdentifier):

  • NetworkProcess/NetworkResourceLoadScheduler.h:

(NetworkResourceLoadScheduler):

Add a "ShareableResource" which includes a SharedMemory block, an offset into that block, and a size:

  • Shared/ShareableResource.cpp: Added.

(WebKit::ShareableResource::Handle::Handle):
(WebKit::ShareableResource::Handle::encode):
(WebKit::ShareableResource::Handle::decode):
(WebKit::ShareableResource::create):
(WebKit::ShareableResource::ShareableResource):
(WebKit::ShareableResource::~ShareableResource):
(WebKit::ShareableResource::createHandle):
(WebKit::ShareableResource::data):
(WebKit::ShareableResource::size):

  • Shared/ShareableResource.h:

(WebKit::ShareableResource::Handle::isNull):
(WebKit::ShareableResource::Handle::size):

Add an implementation of WebCore::ResourceBuffer that wraps a ShareableResource instead of a SharedBuffer:

  • Shared/WebResourceBuffer.cpp:

(WebKit::WebResourceBuffer::WebResourceBuffer):
(WebKit::WebResourceBuffer::~WebResourceBuffer):
(WebKit::WebResourceBuffer::data):
(WebKit::WebResourceBuffer::size):

  • Shared/WebResourceBuffer.h:

(WebResourceBuffer):
(WebKit::WebResourceBuffer::create):

Add messaging that responds to resource load events from the NetworkProcess and passes them to the scheduler:

  • WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didReceiveResponse):
(WebKit::NetworkProcessConnection::didReceiveResource):
(WebKit::NetworkProcessConnection::didFailResourceLoad):

  • WebProcess/Network/NetworkProcessConnection.h:
  • WebProcess/Network/NetworkProcessConnection.messages.in:

Takes resource load events passed from the NetworkProcess and hands them off directly to WebCore ResourceLoaders:

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::scheduleLoad): Update some logging.
(WebKit::WebResourceLoadScheduler::addMainResourceLoad): Ditto.
(WebKit::WebResourceLoadScheduler::remove): Ditto.
(WebKit::WebResourceLoadScheduler::crossOriginRedirectReceived): Ditto.
(WebKit::WebResourceLoadScheduler::servePendingRequests): Ditto.
(WebKit::WebResourceLoadScheduler::didReceiveResponse): Call through to ResourceLoader.
(WebKit::WebResourceLoadScheduler::didReceiveResource): Ditto.
(WebKit::WebResourceLoadScheduler::didFailResourceLoad): Ditto.

  • WebProcess/Network/WebResourceLoadScheduler.h:
2:55 PM Changeset in webkit [133956] by fpizlo@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

DFG should not assume that something is a double just because it might be undefined
https://bugs.webkit.org/show_bug.cgi?id=101438

Reviewed by Oliver Hunt.

This changes all non-bitop arithmetic to (a) statically expect that variables are
defined prior to use in arithmetic and (b) not fall off into double paths just
because a value may not be a number. This is accomplished with two new notions of
speculation:

shouldSpeculateIntegerExpectingDefined: Should we speculate that the value is an
integer if we ignore undefined (i.e. SpecOther) predictions?

shouldSpeculateIntegerForArithmetic: Should we speculate that the value is an
integer if we ignore non-numeric predictions?

This is a ~2x speed-up on programs that seem to our prediction propagator to have
paths in which otherwise numeric variables are undefined.

  • bytecode/SpeculatedType.h:

(JSC::isInt32SpeculationForArithmetic):
(JSC):
(JSC::isInt32SpeculationExpectingDefined):
(JSC::isDoubleSpeculationForArithmetic):
(JSC::isNumberSpeculationExpectingDefined):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::addShouldSpeculateInteger):
(JSC::DFG::Graph::mulShouldSpeculateInteger):
(JSC::DFG::Graph::negateShouldSpeculateInteger):
(JSC::DFG::Graph::addImmediateShouldSpeculateInteger):
(JSC::DFG::Graph::mulImmediateShouldSpeculateInteger):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateIntegerForArithmetic):
(Node):
(JSC::DFG::Node::shouldSpeculateIntegerExpectingDefined):
(JSC::DFG::Node::shouldSpeculateDoubleForArithmetic):
(JSC::DFG::Node::shouldSpeculateNumberExpectingDefined):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithMod):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_div):

2:37 PM Changeset in webkit [133955] by commit-queue@webkit.org
  • 9 edits
    3 adds in trunk

Coordinated Graphics: Remove an invisible TiledBackingStore of CoordinatedGraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=101424

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-08
Reviewed by Noam Rosenthal.

Source/WebCore:

This patch adds ASSERT to TextureMapperLayer while fixing this bug in
WebKit2.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelf):

Source/WebKit2:

We must remove an invisible TiledBackingStore of CoordinatedGraphicsLayer.
Currently, CoordinatedGraphicsLayer only removes a TiledBackingStore if
!drawsContent() while TextureMapperLayer::updateBackingStore() removes a backing

store if (!m_state.drawsContent
!m_state.contentsVisible m_size.isEmpty()).

CoordinatedGraphicsLayer must have the same behavior.

In addition, this patch makes LayerTreeRenderer remove a backing store from
GraphicsLayerTextureMapper when CoordinatedBackingStore does not have any tiles.

Test: compositing/nested-direct-image-compositing.html

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStore::removeTile):
(WebKit::CoordinatedBackingStore::isEmpty):
(WebKit):
(WebKit::CoordinatedBackingStore::commitTileOperations):

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:

(CoordinatedBackingStore):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::removeBackingStoreIfNeeded):
(WebKit):
(WebKit::LayerTreeRenderer::removeTile):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::adjustContentsScale):

LayoutTests:

Coordinated Graphics had a bug when a compositing div has a compositing
img with an absolute position property. This test is added to prevent from
a regression.

  • compositing/nested-direct-image-compositing-expected.png: Added.
  • compositing/nested-direct-image-compositing-expected.txt: Added.
  • compositing/nested-direct-image-compositing.html: Added.
2:35 PM Changeset in webkit [133954] by jsbell@chromium.org
  • 20 edits in trunk/Source/WebCore

Unreviewed, rolling out r133945.
http://trac.webkit.org/changeset/133945
https://bugs.webkit.org/show_bug.cgi?id=101645

Numerous layout and unit test failures (Requested by
jsbell|gardener on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-08

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/scripts/test/V8/V8Float64Array.h:

(WebCore::V8Float64Array::toNative):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::V8TestActiveDOMObject::toNative):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::V8TestCustomNamedGetter::toNative):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::V8TestEventConstructor::toNative):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::V8TestEventTarget::toNative):

  • bindings/scripts/test/V8/V8TestException.h:

(WebCore::V8TestException::toNative):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::V8TestInterface::toNative):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::V8TestMediaQueryListListener::toNative):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::V8TestNamedConstructor::toNative):

  • bindings/scripts/test/V8/V8TestNode.h:

(WebCore::V8TestNode::toNative):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore::V8TestObj::toNative):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::V8TestSerializedScriptValueInterface::toNative):

  • bindings/v8/NPV8Object.cpp:

(WebCore::v8ObjectToNPObject):
(WebCore::npCreateV8ScriptObject):

  • bindings/v8/V8Collection.h:

(WebCore::toNativeCollection):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::setIsolatedWorldField):
(WebCore::V8DOMWindowShell::enteredIsolatedWorldContext):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::isWrapperOfType):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::setDOMWrapper):
(WebCore::V8DOMWrapper::clearDOMWrapper):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore::toNative):
(WebCore::toWrapperTypeInfo):

2:28 PM Changeset in webkit [133953] by fpizlo@apple.com
  • 87 edits
    2 adds in trunk/Source

JSC should infer when indexed storage contains only integers or doubles
https://bugs.webkit.org/show_bug.cgi?id=98606

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This adds two new indexing types: int32 and double. It also adds array allocation profiling,
which allows array allocations to converge to allocating arrays using those types to which
those arrays would have been converted.

20% speed-up on navier-stokes. 40% speed-up on various Kraken DSP tests. Some slow-downs too,
but a performance win overall on all benchmarks we track.

  • API/JSObjectRef.cpp:

(JSObjectMakeArray):

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/AbstractMacroAssembler.h:

(JumpList):
(JSC::AbstractMacroAssembler::JumpList::JumpList):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branchDouble):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::jnp):
(X86Assembler):
(JSC::X86Assembler::X86InstructionFormatter::emitRex):

  • bytecode/ArrayAllocationProfile.cpp: Added.

(JSC):
(JSC::ArrayAllocationProfile::updateIndexingType):

  • bytecode/ArrayAllocationProfile.h: Added.

(JSC):
(ArrayAllocationProfile):
(JSC::ArrayAllocationProfile::ArrayAllocationProfile):
(JSC::ArrayAllocationProfile::selectIndexingType):
(JSC::ArrayAllocationProfile::updateLastAllocation):
(JSC::ArrayAllocationProfile::selectIndexingTypeFor):
(JSC::ArrayAllocationProfile::updateLastAllocationFor):

  • bytecode/ArrayProfile.cpp:

(JSC::ArrayProfile::updatedObservedArrayModes):
(JSC):

  • bytecode/ArrayProfile.h:

(JSC):
(JSC::arrayModesInclude):
(JSC::shouldUseSlowPutArrayStorage):
(JSC::shouldUseFastArrayStorage):
(JSC::shouldUseContiguous):
(JSC::shouldUseDouble):
(JSC::shouldUseInt32):
(ArrayProfile):

  • bytecode/ByValInfo.h:

(JSC::isOptimizableIndexingType):
(JSC::jitArrayModeForIndexingType):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC):
(JSC::CodeBlock::updateAllValueProfilePredictions):
(JSC::CodeBlock::updateAllArrayPredictions):
(JSC::CodeBlock::updateAllPredictions):
(JSC::CodeBlock::shouldOptimizeNow):

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::numberOfArrayAllocationProfiles):
(JSC::CodeBlock::addArrayAllocationProfile):
(JSC::CodeBlock::updateAllValueProfilePredictions):
(JSC::CodeBlock::updateAllArrayPredictions):

  • bytecode/DFGExitProfile.h:

(JSC::DFG::exitKindToString):

  • bytecode/Instruction.h:

(JSC):
(JSC::Instruction::Instruction):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecode/SpeculatedType.h:

(JSC):
(JSC::isRealNumberSpeculation):

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):

  • bytecode/UnlinkedCodeBlock.h:

(JSC):
(JSC::UnlinkedCodeBlock::addArrayAllocationProfile):
(JSC::UnlinkedCodeBlock::numberOfArrayAllocationProfiles):
(UnlinkedCodeBlock):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::newArrayAllocationProfile):
(JSC):
(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitExpectedFunctionSnippet):

  • bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::fromObserved):
(JSC::DFG::ArrayMode::refine):
(DFG):
(JSC::DFG::ArrayMode::alreadyChecked):
(JSC::DFG::arrayTypeToString):

  • dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::withType):
(ArrayMode):
(JSC::DFG::ArrayMode::withTypeAndConversion):
(JSC::DFG::ArrayMode::usesButterfly):
(JSC::DFG::ArrayMode::isSpecific):
(JSC::DFG::ArrayMode::supportsLength):
(JSC::DFG::ArrayMode::arrayModesThatPassFiltering):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getArrayMode):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):

  • dfg/DFGCallArrayAllocatorSlowPathGenerator.h:

(JSC::DFG::CallArrayAllocatorSlowPathGenerator::generateInternal):
(JSC::DFG::CallArrayAllocatorWithVariableSizeSlowPathGenerator::generateInternal):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::byValIsPure):

  • dfg/DFGNode.h:

(NewArrayBufferData):
(JSC::DFG::Node::hasIndexingType):
(Node):
(JSC::DFG::Node::indexingType):
(JSC::DFG::Node::setIndexingType):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitAllocateJSArray):
(JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode):
(DFG):
(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::arrayify):
(JSC::DFG::SpeculativeJIT::compileDoublePutByVal):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
(SpeculateIntegerOperand):
(JSC::DFG::SpeculateIntegerOperand::use):
(SpeculateDoubleOperand):
(JSC::DFG::SpeculateDoubleOperand::use):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(DFG):
(JSC::DFG::SpeculativeJIT::compileContiguousPutByVal):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JIT.h:

(JSC::JIT::emitInt32GetByVal):
(JIT):
(JSC::JIT::emitInt32PutByVal):
(JSC::JIT::emitDoublePutByVal):
(JSC::JIT::emitContiguousPutByVal):

  • jit/JITExceptions.cpp:

(JSC::genericThrow):

  • jit/JITInlineMethods.h:

(JSC::arrayProfileSaw):
(JSC::JIT::chooseArrayMode):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_array):
(JSC::JIT::emit_op_new_array_with_size):
(JSC::JIT::emit_op_new_array_buffer):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitDoubleGetByVal):
(JSC):
(JSC::JIT::emitContiguousGetByVal):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::privateCompileGetByVal):
(JSC::JIT::privateCompilePutByVal):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitContiguousGetByVal):
(JSC::JIT::emitDoubleGetByVal):
(JSC):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emitSlow_op_put_by_val):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:

(JSC):

  • jsc.cpp:

(GlobalObject::finishCreation):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/x86.rb:
  • runtime/ArrayConstructor.cpp:

(JSC::constructArrayWithSizeQuirk):

  • runtime/ArrayConstructor.h:

(JSC):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):

  • runtime/Butterfly.h:

(JSC::Butterfly::contiguousInt32):
(JSC::Butterfly::contiguousDouble):
(JSC::Butterfly::fromContiguous):

  • runtime/ButterflyInlineMethods.h:

(JSC::Butterfly::createUninitializedDuringCollection):

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncBind):

  • runtime/IndexingHeaderInlineMethods.h:

(JSC::IndexingHeader::indexingPayloadSizeInBytes):

  • runtime/IndexingType.cpp:

(JSC::leastUpperBoundOfIndexingTypes):
(JSC):
(JSC::leastUpperBoundOfIndexingTypeAndType):
(JSC::leastUpperBoundOfIndexingTypeAndValue):
(JSC::indexingTypeToString):

  • runtime/IndexingType.h:

(JSC):
(JSC::hasUndecided):
(JSC::hasInt32):
(JSC::hasDouble):

  • runtime/JSArray.cpp:

(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::shiftCountWithAnyIndexingType):
(JSC::JSArray::unshiftCountWithAnyIndexingType):
(JSC::compareNumbersForQSortWithInt32):
(JSC):
(JSC::compareNumbersForQSortWithDouble):
(JSC::JSArray::sortNumericVector):
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sortCompactedVector):
(JSC::JSArray::sort):
(JSC::JSArray::sortVector):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToArguments):
(JSC::JSArray::compactForSorting):

  • runtime/JSArray.h:

(JSArray):
(JSC::createContiguousArrayButterfly):
(JSC::JSArray::create):
(JSC::JSArray::tryCreateUninitialized):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):
(JSC):
(JSC::JSGlobalObject::haveABadTime):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::originalArrayStructureForIndexingType):
(JSC::JSGlobalObject::arrayStructureForIndexingTypeDuringAllocation):
(JSC::JSGlobalObject::arrayStructureForProfileDuringAllocation):
(JSC::JSGlobalObject::isOriginalArrayStructure):
(JSC::constructEmptyArray):
(JSC::constructArray):

  • runtime/JSObject.cpp:

(JSC::JSObject::copyButterfly):
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::putByIndex):
(JSC::JSObject::enterDictionaryIndexingMode):
(JSC::JSObject::createInitialIndexedStorage):
(JSC):
(JSC::JSObject::createInitialUndecided):
(JSC::JSObject::createInitialInt32):
(JSC::JSObject::createInitialDouble):
(JSC::JSObject::createInitialContiguous):
(JSC::JSObject::convertUndecidedToInt32):
(JSC::JSObject::convertUndecidedToDouble):
(JSC::JSObject::convertUndecidedToContiguous):
(JSC::JSObject::constructConvertedArrayStorageWithoutCopyingElements):
(JSC::JSObject::convertUndecidedToArrayStorage):
(JSC::JSObject::convertInt32ToDouble):
(JSC::JSObject::convertInt32ToContiguous):
(JSC::JSObject::convertInt32ToArrayStorage):
(JSC::JSObject::convertDoubleToContiguous):
(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):
(JSC::JSObject::convertUndecidedForValue):
(JSC::JSObject::convertInt32ForValue):
(JSC::JSObject::setIndexQuicklyToUndecided):
(JSC::JSObject::convertInt32ToDoubleOrContiguousWhilePerformingSetIndex):
(JSC::JSObject::convertDoubleToContiguousWhilePerformingSetIndex):
(JSC::JSObject::ensureInt32Slow):
(JSC::JSObject::ensureDoubleSlow):
(JSC::JSObject::ensureContiguousSlow):
(JSC::JSObject::ensureArrayStorageSlow):
(JSC::JSObject::ensureArrayStorageExistsAndEnterDictionaryIndexingMode):
(JSC::JSObject::switchToSlowPutArrayStorage):
(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::putByIndexBeyondVectorLengthWithoutAttributes):
(JSC::JSObject::putByIndexBeyondVectorLength):
(JSC::JSObject::putDirectIndexBeyondVectorLength):
(JSC::JSObject::getNewVectorLength):
(JSC::JSObject::countElements):
(JSC::JSObject::ensureLengthSlow):
(JSC::JSObject::getOwnPropertyDescriptor):

  • runtime/JSObject.h:

(JSC::JSObject::getArrayLength):
(JSC::JSObject::getVectorLength):
(JSC::JSObject::canGetIndexQuickly):
(JSC::JSObject::getIndexQuickly):
(JSC::JSObject::tryGetIndexQuickly):
(JSC::JSObject::canSetIndexQuickly):
(JSC::JSObject::canSetIndexQuicklyForPutDirect):
(JSC::JSObject::setIndexQuickly):
(JSC::JSObject::initializeIndex):
(JSC::JSObject::hasSparseMap):
(JSC::JSObject::inSparseIndexingMode):
(JSObject):
(JSC::JSObject::ensureInt32):
(JSC::JSObject::ensureDouble):
(JSC::JSObject::ensureLength):
(JSC::JSObject::indexingData):
(JSC::JSObject::currentIndexingData):
(JSC::JSObject::getHolyIndexQuickly):
(JSC::JSObject::relevantLength):
(JSC::JSObject::currentRelevantLength):

  • runtime/JSValue.cpp:

(JSC::JSValue::description):

  • runtime/LiteralParser.cpp:

(JSC::::parse):

  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSplit):

  • runtime/Structure.cpp:

(JSC::Structure::nonPropertyTransition):

  • runtime/StructureTransitionTable.h:

(JSC::newIndexingType):

Source/WebCore:

Just refactoring WebCore to pass 0 for the ArrayAllocationProfile*.

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::JSCanvasRenderingContext2D::webkitLineDash):

  • bindings/js/JSClipboardCustom.cpp:

(WebCore::JSClipboard::types):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::jsArray):

  • bindings/js/JSDOMBinding.h:

(WebCore::jsArray):

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::getJSListenerFunctions):

  • bindings/js/JSJavaScriptCallFrameCustom.cpp:

(WebCore::JSJavaScriptCallFrame::scopeChain):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::ports):

  • bindings/js/JSMutationCallbackCustom.cpp:

(WebCore::JSMutationCallback::handleEvent):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):
(WebCore::JSWebGLRenderingContext::getAttachedShaders):
(WebCore::JSWebGLRenderingContext::getSupportedExtensions):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::deserialize):

2:25 PM Changeset in webkit [133952] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[BlackBerry] Update BB10 date input form.
https://bugs.webkit.org/show_bug.cgi?id=101075

Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-08
Reviewed by Rob Buis.

RIM PR 234531
Internally Reviewed by Mike Fenton.
Change date input appearance to button and hide caret when click on them.

Source/WebCore:

  • css/themeBlackBerry.css:

(input[type="date"], input[type="datetime"], input[type="datetime-local"], input[type="time"], input[type="month"]):

Source/WebKit/blackberry:

  • WebCoreSupport/DatePickerClient.cpp:

(WebCore::DatePickerClient::setValueAndClosePopup):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openDatePopup):

2:22 PM Changeset in webkit [133951] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Provide pixel coordinates to IMF relative to the screen
https://bugs.webkit.org/show_bug.cgi?id=101628

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-08
Reviewed by Rob Buis.

Reviewed internally by Mike Fenton and Jakob Petsovits.

We need to provide the correct pixel coordinates to IMF,
accounting for webkit based fields in UIB as well as browser.
Getting an offset value from the screen point to the document
content point allows us to adjust for when the document,
such as in UIB, does not start at 0,0.

  • Api/WebPageClient.h:
  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):

  • WebKitSupport/InputHandler.h:

(InputHandler):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

2:20 PM Changeset in webkit [133950] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

ASSERT problem on MIPS
https://bugs.webkit.org/show_bug.cgi?id=100589

Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2012-11-08
Reviewed by Oliver Hunt.

ASSERT fix for MIPS arch.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_resolve_operations):

2:03 PM Changeset in webkit [133949] by Lucas Forschler
  • 10 edits
    3 copies in branches/safari-536.28-branch

Merged r125457. <rdar://problem/12516352>

1:59 PM Changeset in webkit [133948] by yael@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Some more gardening after r133898.

  • platform/efl/TestExpectations:
1:58 PM Changeset in webkit [133947] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/Source/WebKit2

Merged r125100. <rdar://problem/12516350>

1:55 PM Changeset in webkit [133946] by Lucas Forschler
  • 32 edits
    8 copies in branches/safari-536.28-branch

Merged r124815. <rdar://problem/12516369>

1:53 PM Changeset in webkit [133945] by abarth@webkit.org
  • 20 edits in trunk/Source/WebCore

[V8] Update callers to use the aligned pointer API rather than the deprecated unaligned pointer API
https://bugs.webkit.org/show_bug.cgi?id=101519

Reviewed by Ojan Vafai.

There should be no change in behavior. The new API is slightly faster
than the old API (and apparently works correctly internally in V8).

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/scripts/test/V8/V8Float64Array.h:

(WebCore::V8Float64Array::toNative):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::V8TestActiveDOMObject::toNative):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::V8TestCustomNamedGetter::toNative):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::V8TestEventConstructor::toNative):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::V8TestEventTarget::toNative):

  • bindings/scripts/test/V8/V8TestException.h:

(WebCore::V8TestException::toNative):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::V8TestInterface::toNative):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::V8TestMediaQueryListListener::toNative):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::V8TestNamedConstructor::toNative):

  • bindings/scripts/test/V8/V8TestNode.h:

(WebCore::V8TestNode::toNative):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore::V8TestObj::toNative):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::V8TestSerializedScriptValueInterface::toNative):

  • bindings/v8/NPV8Object.cpp:

(WebCore::v8ObjectToNPObject):
(WebCore::npCreateV8ScriptObject):

  • bindings/v8/V8Collection.h:

(WebCore::toNativeCollection):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::setIsolatedWorldField):
(WebCore::V8DOMWindowShell::enteredIsolatedWorldContext):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::isWrapperOfType):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::setDOMWrapper):
(WebCore::V8DOMWrapper::clearDOMWrapper):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore::toNative):
(WebCore::toWrapperTypeInfo):

1:52 PM Changeset in webkit [133944] by arv@chromium.org
  • 7 edits in trunk

setAttributeNode and friends should not have optional argument
https://bugs.webkit.org/show_bug.cgi?id=101631

Reviewed by Ojan Vafai.

Source/WebCore:

http://www.w3.org/TR/DOM-Level-3-Core/core.html#ID-887236154

Fix getAttributeNode, getAttributeNodeNS and removeAttributeNode to make the Attr
argument mandatory.

These used to throw DOMExceptions when an invalid type was passed instead of
TypeError which is also a spec violation.

Updated existing tests.

  • bindings/scripts/CodeGeneratorV8.pm:
  • dom/Element.cpp:
  • dom/Element.idl:

LayoutTests:

Fix getAttributeNode, getAttributeNodeNS and removeAttributeNode to make the Attr
argument mandatory.

These used to throw DOMExceptions when an invalid type was passed instead of
TypeError which is also a spec violation.

  • fast/dom/Element/attr-param-typechecking-expected.txt:
  • fast/dom/Element/script-tests/attr-param-typechecking.js:
1:50 PM Changeset in webkit [133943] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/Source/WebKit2

Merged r124652. <rdar://problem/12516369>

1:48 PM Changeset in webkit [133942] by Lucas Forschler
  • 8 edits in branches/safari-536.28-branch

Merged r124649. <rdar://problem/12516369>

1:39 PM Changeset in webkit [133941] by commit-queue@webkit.org
  • 3 edits in trunk

[Chromium] DumpRenderTree fix for canvas in software compositing
https://bugs.webkit.org/show_bug.cgi?id=101509

Patch by Slavomir Kaslev <skaslev@google.com> on 2012-11-08
Reviewed by Adrienne Walker.

Don't use accelerated canvas 2d when in software compositing mode.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::runFileTest):

1:37 PM Changeset in webkit [133940] by jsbell@chromium.org
  • 6 edits in trunk

Source/WebCore: IndexedDB: Remove unused error handling clauses when writing to transaction
https://bugs.webkit.org/show_bug.cgi?id=100700

Reviewed by Tony Chang.

Transactions are written into in-memory data structures. This can only fail if allocation
fails, so "success" results are always returned. Change the return types to void, and delete
all of the unreachable error handling code.

No new tests - just refactoring/dead code removal.

  • Modules/indexeddb/IDBLevelDBBackingStore.cpp:

(WebCore::putBool): Only write to transactions.
(WebCore):
(WebCore::putInt): Ditto.
(WebCore::putVarInt): Ditto.
(WebCore::putString): Ditto.
(WebCore::putIDBKeyPath): Ditto.
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseIntVersion):
(WebCore::IDBLevelDBBackingStore::updateIDBDatabaseMetaData):
(WebCore::deleteRange): Writes only to transaction, so can't fail.
(WebCore::setMaxObjectStoreId):
(WebCore::IDBLevelDBBackingStore::createObjectStore):
(WebCore::getNewVersionNumber):
(WebCore::IDBLevelDBBackingStore::putObjectStoreRecord):
(WebCore::IDBLevelDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::setMaxIndexId):
(WebCore::IDBLevelDBBackingStore::createIndex):
(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):

  • platform/leveldb/LevelDBTransaction.cpp:

(WebCore::LevelDBTransaction::set): Return type is void.
(WebCore::LevelDBTransaction::put): Ditto.
(WebCore::LevelDBTransaction::remove): Ditto.

  • platform/leveldb/LevelDBTransaction.h:

(LevelDBTransaction):

LayoutTests: [Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
1:36 PM Changeset in webkit [133939] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

On Chromium, click-after-nested-block.html, focus_editable_html.html, and autoscroll.html
hit assertion added in r133840
https://bugs.webkit.org/show_bug.cgi?id=101576

Reviewed by Abhishek Arya.

Update layout before invalidating caret rect as needed.
Existing tests cover this.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setCaretVisibility): Merged clearCaretRectIfNeeded.

  • editing/FrameSelection.h:
1:35 PM Changeset in webkit [133938] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed.

Roll Chromium DEPS: 166678 => 166755

  • DEPS:
1:09 PM Changeset in webkit [133937] by Lucas Forschler
  • 6 edits in branches/safari-536.28-branch/Source/WebKit2

Merged r124393. <rdar://problem/12516369>

12:54 PM Changeset in webkit [133936] by eae@chromium.org
  • 8 edits
    21 adds
    18 deletes in trunk/LayoutTests

Unreviewed chromium rebaselines.

  • platform/chromium-linux-x86/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/chromium-linux-x86/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/chromium-mac-lion/fast/css/text-overflow-ellipsis-bidi-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/text-overflow-ellipsis-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/text-overflow-ellipsis-strict-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/text-overflow-input-expected.png: Added.
  • platform/chromium-mac-lion/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/basic-textareas-quirks-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/input-disabled-color-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/input-readonly-dimmed-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/input-text-scroll-left-on-blur-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/search-rtl-expected.png: Added.
  • platform/chromium-mac-lion/fast/multicol/span/anonymous-split-block-crash-expected.png: Added.
  • platform/chromium-mac-lion/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Added.
  • platform/chromium-mac-lion/fast/replaced/width100percent-textarea-expected.png: Added.
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-text-align-center-expected.png:
  • platform/chromium-win-xp/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/chromium-win-xp/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/chromium-win/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/chromium-win/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/efl-wk1/fast/css: Added.
  • platform/efl-wk1/fast/css/text-overflow-ellipsis-bidi-expected.png: Added.
  • platform/efl-wk1/fast/css/text-overflow-ellipsis-expected.png: Added.
  • platform/efl-wk1/fast/css/text-overflow-ellipsis-strict-expected.png: Added.
  • platform/efl-wk1/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Added.
  • platform/efl-wk1/fast/css/text-overflow-input-expected.png: Added.
  • platform/efl-wk1/fast/css/text-overflow-input-expected.txt: Added.
  • platform/efl-wk1/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Added.
  • platform/efl/fast/css/text-overflow-ellipsis-bidi-expected.png: Removed.
  • platform/efl/fast/css/text-overflow-ellipsis-expected.png: Removed.
  • platform/efl/fast/css/text-overflow-ellipsis-strict-expected.png: Removed.
  • platform/efl/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Removed.
  • platform/efl/fast/css/text-overflow-input-expected.png: Removed.
  • platform/efl/fast/css/text-overflow-input-expected.txt: Removed.
  • platform/efl/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Removed.
  • platform/efl/fast/forms/basic-textareas-quirks-expected.png: Removed.
  • platform/efl/fast/forms/basic-textareas-quirks-expected.txt: Removed.
  • platform/efl/fast/forms/input-disabled-color-expected.png: Removed.
  • platform/efl/fast/forms/input-disabled-color-expected.txt: Removed.
  • platform/efl/fast/forms/input-readonly-dimmed-expected.png: Removed.
  • platform/efl/fast/forms/input-readonly-dimmed-expected.txt: Removed.
  • platform/efl/fast/forms/input-text-scroll-left-on-blur-expected.png: Removed.
  • platform/efl/fast/forms/input-text-scroll-left-on-blur-expected.txt: Removed.
  • platform/efl/fast/multicol/span/anonymous-split-block-crash-expected.png: Removed.
  • platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png: Removed.
  • platform/efl/fast/replaced/width100percent-textarea-expected.png: Removed.
12:47 PM Changeset in webkit [133935] by timothy_horton@apple.com
  • 13 edits in trunk/Source/WebKit2

[WK2] Print preview should vend images to the UIProcess instead of PDFs
https://bugs.webkit.org/show_bug.cgi?id=101382
<rdar://problem/9866766>

Reviewed by Alexey Proskuryakov.

In the interests of keeping PDF processing inside the WebProcess, we should
remove print preview's reliance on PDFs, by handing bitmaps back instead.

  • Shared/ShareableBitmap.cpp:

(WebKit::ShareableBitmap::create): Add an optional SharedMemory::Protection argument, so we can make
ShareableBitmaps from read-only handles if desired. Defaults to read-write as previously.
(WebKit::ShareableBitmap::createHandle): Add an optional SharedMemory::Protection argument, so we can make
read-only handles if desired. Defaults to read-write as previously.

  • Shared/ShareableBitmap.h:
  • UIProcess/API/mac/WKPrintingView.h:

(WebImage): Store WebImages instead of raw PDF data for previews.

  • UIProcess/API/mac/WKPrintingView.mm:

(pageDidDrawToImage): Add a callback for when a preview we've requested is done rendering into an image.
Cache the image in _pagePreviews if appropriate.
(pageDidDrawToPDF): Do not handle PDF data unless we are expecting a real print callback (not a preview).
(-[WKPrintingView _drawPreview:]): Request an image instead of PDF data when doing a print preview.

  • UIProcess/GenericCallback.h:

(ImageCallback): Add a callback type with one argument: a ShareableBitmap::Handle.
I can't use the GenericCallback template because ShareableBitmap::Handle doesn't have a corresponding WK type.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close): Add support for ImageCallback.
(WebKit::WebPageProxy::imageCallback): Add support for ImageCallback.
(WebKit::WebPageProxy::drawRectToImage): Rename drawRectToPDF to drawRectToImage.

  • UIProcess/WebPageProxy.h:

(WebPageProxy): Rename drawRectToPDF to drawRectToImage, add support for ImageCallback.

  • UIProcess/WebPageProxy.messages.in: Add support for ImageCallback.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::drawRectToImage): Rename drawRectToPDF to drawRectToImage.
Make drawRectToImage create a bitmap snapshot of the page (using the normal snapshotting code),
or, if the page is backed by a *PDFPlugin, draw the PDF document into a bitmap and use that.

  • WebProcess/WebPage/WebPage.h:

(WebPage): Rename drawRectToPDF to drawRectToImage.

  • WebProcess/WebPage/WebPage.messages.in: Rename drawRectToPDF to drawRectToImage.
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::drawPDFDocument): Rename drawRectToPDFFromPDFDocument to drawPDFDocument,
because it's more like drawImage than anything else.

12:41 PM Changeset in webkit [133934] by tony@chromium.org
  • 4 edits in trunk/LayoutTests

Layout test editing/pasteboard/file-drag-to-editable.html flaky
https://bugs.webkit.org/show_bug.cgi?id=101092

Reviewed by Ryosuke Niwa.

Fix a flaky test. The problem was that we were confusing the test harness by
trying to do a navigation before the initial load finished (the notifyDone()
call did nothing because waitUntilDone() was missing). Depending on the state
of the frame loader when the test run, there was a race in whether or not we
would dump the results before or after completing the script execution.

Fix this by restructuring the test to run during onload and by calling notifyDone()
after the file load attempt failed.

  • editing/pasteboard/file-drag-to-editable-expected.txt:
  • editing/pasteboard/script-tests/file-drag-to-editable.js:

(runTest.window.onbeforeunload): Simplify and don't run nofityDone yet.
(runTest): Run test during onload event.

  • platform/chromium/TestExpectations: Remove flaky marker.
12:37 PM Changeset in webkit [133933] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Skip frame owner disconnect when there's no frames
https://bugs.webkit.org/show_bug.cgi?id=101619

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-08
Reviewed by Ojan Vafai.

Even when there's no subframes in the document we traverse down every
subtree on Node removal looking for frames to disconnect. This patch
checks document()->frame()->tree()->firstChild() to skip this traversal
if there's no subframes.

No new tests, this just short circuits code for speed.

  • dom/ContainerNodeAlgorithms.h:

(WebCore::ChildFrameDisconnector::ChildFrameDisconnector):

12:33 PM Changeset in webkit [133932] by arv@chromium.org
  • 11 edits in trunk

Wrong error type is thrown for type errors in callbacks
https://bugs.webkit.org/show_bug.cgi?id=101502

Reviewed by Adam Barth.

We should be throwing a TypeError and not a DOMException with code TYPE_MISMATCH_ERR.

http://www.w3.org/TR/WebIDL/#es-callback-function

Source/WebCore:

Updated existing tests.

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/V8/V8TestObj.cpp:

LayoutTests:

  • fast/mediastream/argument-types-expected.txt:
  • fast/mediastream/peerconnection-argument-types-expected.txt:
  • fast/mediastream/script-tests/argument-types.js:
  • fast/mediastream/script-tests/peerconnection-argument-types.js:
  • fast/workers/storage/open-database-inputs-sync-expected.txt:
12:33 PM Changeset in webkit [133931] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-08

  • DEPS:
12:16 PM Changeset in webkit [133930] by yael@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Even more gardening after r133898.

  • platform/efl/TestExpectations:
12:09 PM Changeset in webkit [133929] by andersca@apple.com
  • 3 edits in trunk/WebKitLibraries

Roll WebKitSystemInterface DEPS.

Rubber-stamped by Andreas Kling.

  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
12:08 PM Changeset in webkit [133928] by jpetsovits@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Janitor: Remove unused m_isValid bool
https://bugs.webkit.org/show_bug.cgi?id=101610

Reviewed by Rob Buis.

It's not used anywhere, but as we have a constructor
that creates an invalid TileIndex, let's add another
method to check validity - now a correct check.

On top of that, make the stylebot happy by reducing
"unsigned int" to just "unsigned".

  • WebKitSupport/TileIndex.h:

(BlackBerry::WebKit::TileIndex::TileIndex):
(BlackBerry::WebKit::TileIndex::i):
(BlackBerry::WebKit::TileIndex::j):
(BlackBerry::WebKit::TileIndex::setIndex):
(BlackBerry::WebKit::TileIndex::isValid):
(TileIndex):

12:03 PM Changeset in webkit [133927] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Introduce WebScreenInfo.deviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=101613

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-11-08
Reviewed by Adam Barth.

Introduce the WebScreenInfo.deviceScaleFactor property, which specifies the
ratio between physical and logical pixels. This is the first step in replacing
horizontalDPI/verticalDPI in favor of the deviceScaleFactor.

For now, this value is only initialized on Mac, because the other ports that
use it initialize the value in Chromium, whereas Windows and X11 default to a
factor of 1. The value on Mac is truncated to an integer to match the
expectation in Chromium's RenderWidget.

Source/Platform:

  • chromium/public/WebScreenInfo.h:

(WebScreenInfo):
(WebKit::WebScreenInfo::WebScreenInfo):

Source/WebKit/chromium:

  • src/mac/WebScreenInfoFactory.mm:

(WebKit::WebScreenInfoFactory::screenInfo):

11:37 AM Changeset in webkit [133926] by kling@webkit.org
  • 3 edits in trunk/Source/WebCore

4.68MB below RenderStyle::filter() on Membuster3.
<http://webkit.org/b/101624>
<rdar://problem/12663822>

Reviewed by Darin Adler.

Rename the non-const RenderStyle::filter() to mutableFilter() since using it causes us to detach
from the rare non-inherited data (copy-on-write.)
Most call sites were calling filter() on a RenderStyle* which was causing the bloat.

4.68MB progression on Membuster3.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::loadPendingShaders):

  • rendering/style/RenderStyle.h:
11:35 AM Changeset in webkit [133925] by ap@apple.com
  • 1 edit
    1 add in trunk/Source/WebCore

Create loader/blackberry directory, because svn-apply cannot apply a patch that
creates a directory and moves a file into it.

  • loader/blackberry: Added.
11:30 AM Changeset in webkit [133924] by efidler@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Increase memory cache size
https://bugs.webkit.org/show_bug.cgi?id=101622

Reviewed by Yong Li.

  • WebCoreSupport/CacheClientBlackBerry.cpp:

(WebCore::CacheClientBlackBerry::updateCacheCapacity):

  • WebCoreSupport/CacheClientBlackBerry.h:

(CacheClientBlackBerry):

11:23 AM Changeset in webkit [133923] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Mac build fix: Mark WidthCache.h 'private' so WebKit can use it.

Not reviewed.

  • WebCore.xcodeproj/project.pbxproj:
11:13 AM Changeset in webkit [133922] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening - widen flaky expectation to include crash

  • platform/chromium/TestExpectations:
11:06 AM Changeset in webkit [133921] by ggaren@apple.com
  • 8 edits
    1 add in trunk/Source/WebCore

Optimized kerning and ligatures using caching
https://bugs.webkit.org/show_bug.cgi?id=101269

Reviewed by Dan Bernstein.

Consider three kinds of text layout, and the value of caching for each:

(1) 1 layout of 100% unique words: small negative value.

(2) 1 layout of English prose: medium positive value.

(3) Many layouts of anything: extra-extra-large positive value.

Since we can't distinguish betwen these workflows a priori, we use statistical
sampling. To minimize cost in (1) and maximize benefit in (2) and (3), we treat
each cache access as a statistical sample, and use the cache in proportion to
the observed probability of duplicate text measurement.

Benchmark results:

plt3: 1% faster
chapter-reflow-once-random: No change [*]
chapter-reflow-once: 23% faster
chapter-reflow-twice: 52% faster
chapter-reflow-thrice: 68% faster
chapter-reflow: 263% faster
line-layout: 270% faster

[*] This is a stress test designed to make everything go wrong for
caching. It does not represent real world content.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/WidthCache.h: Added.

(WidthCache): Added a class that caches common word widths. This cache
could cache more things or more cases in future -- but for now it seems
to cover the common cases.

(SmallStringKey): Early profiling showed that allocating an AtomicString
or String measurably added to the cost of the cache, so I added a custom
string key that can be stored directly inside the table by value --
empirically answering an age-old question with which Apple WebKit engineers
seem to be obsessed.

(WebCore::WidthCache::SmallStringKey::capacity):
(WebCore::WidthCache::SmallStringKey::SmallStringKey):
(WebCore::WidthCache::SmallStringKey::characters):
(WebCore::WidthCache::SmallStringKey::length):
(WebCore::WidthCache::SmallStringKey::hash):
(WebCore::WidthCache::SmallStringKey::isHashTableDeletedValue):
(WebCore::WidthCache::SmallStringKey::isHashTableEmptyValue):
(WebCore::WidthCache::SmallStringKeyHash::hash):
(WebCore::WidthCache::SmallStringKeyHash::equal):
(SmallStringKeyHash):
(SmallStringKeyHashTraits):
(WebCore::WidthCache::SmallStringKeyHashTraits::isEmptyValue): Ditto.

(WebCore::WidthCache::WidthCache):
(WebCore::WidthCache::add): Separate out the "don't use the cache" case
so the compiler can inline it separate, hopefully further reducing cases
of (1).

(WebCore::WidthCache::addSlowCase): There's a little subtlety to the
sampling policy here. Lots of different approaches are possible, and I
just picked a simple one that seemed to work based on benchmarking. I'll
point out some interesting sublteties I'm aware of here:

(*) Since we start at the min sampling rate, a font used for 20 words
or fewer never allocates a cache. Anecdotally, some fonts seem to
be used this way.

(*) When the sampling rate is x / y, sampling all x words in a row
seems smart because some words may occur more commonly in relation to
each other (such as 'each' and 'other'), and repeat workloads will
lay out the same words in order. Intuitively, these are both reasons
this policy may ramp up more effectively under load.

(*) I opted for linear back-off instead of, say, exponential back-off
because we're not trying to back off to infinity -- just to our min
sampling rate. Since we don't expect the cache to hit for every word,
my guess is that exponential back-off would be too aggressive.

(*) Our "eviction" policy has an IQ of 1. I expect this is sufficient
because it would be surprising to see a million unique words all used
in the same document. (I would not like to play a Letterpress game
against such a document.)

(WebCore::WidthCache::clear): Needed because a font can change, in which
case we need to ditch its cache.

(WebCore::operator==): Needed for hashing.

10:57 AM Changeset in webkit [133920] by yael@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. More gardening after r133898.

  • platform/efl/TestExpectations:
10:54 AM Changeset in webkit [133919] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening - fix lint failures in expectations file.

  • platform/chromium/TestExpectations:
10:47 AM Changeset in webkit [133918] by msaboff@apple.com
  • 2 edits in trunk/Source/WTF

HashAndUTF8CharactersTranslator should create an 8 bit string if possible
https://bugs.webkit.org/show_bug.cgi?id=101515

Reviewed by Darin Adler.

Added isAllASCII flag that's passed to convertUTF8ToUTF16(). If on return it is true, create an
8 bit string, otherwise use the 16 bit string.

  • wtf/text/AtomicString.cpp:

(WTF::HashAndUTF8CharactersTranslator::translate):

10:37 AM Changeset in webkit [133917] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

Multiple Layout Tests (e.g. fast/repaint/japanese-rl-selection-clear.html) is failing after r133840.
https://bugs.webkit.org/show_bug.cgi?id=101547

[Chromium] Unreviewed gardening - test expectations update.

  • platform/chromium/TestExpectations:
10:33 AM Changeset in webkit [133916] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Cleanup IDBBindingUtilitiesTest
https://bugs.webkit.org/show_bug.cgi?id=100860

Patch by Dan Carney <dcarney@google.com> on 2012-11-08
Reviewed by Adam Barth.

Small cleanup of IDBBindingUtilitiesTest as per
https://bugs.webkit.org/show_bug.cgi?id=99975#c38

  • tests/IDBBindingUtilitiesTest.cpp:

(IDBKeyFromValueAndKeyPathTest):
(WebKit::IDBKeyFromValueAndKeyPathTest::IDBKeyFromValueAndKeyPathTest):
(WebKit::IDBKeyFromValueAndKeyPathTest::context):
(WebKit):
(WebKit::TEST_F):

10:24 AM Changeset in webkit [133915] by caseq@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: show statistics over selected frame range in Timeline's Frame mode
https://bugs.webkit.org/show_bug.cgi?id=101593

Reviewed by Pavel Feldman.

  • change status bar records counter wording to "N of M frames|records shown" depending on mode;
  • append average frame length and & stddev in frame mode;
  • expand the above to a popover that includes frame count, range duration and min/avg/max/stddev on frame length;
  • show frame bars & dividers iff selection range includes < 30 frames (drive-by)
  • English.lproj/localizedStrings.js:
  • inspector/front-end/TimelineFrameController.js:

(WebInspector.FrameStatistics):

  • inspector/front-end/TimelineModel.js:

(WebInspector.TimelineModel.aggregateTimeByCategory):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype._createStatusBarItems.getAnchor):
(WebInspector.TimelinePanel.prototype._createStatusBarItems):
(WebInspector.TimelinePanel.prototype._updateRecordsCounter):
(WebInspector.TimelinePanel.prototype._updateFrameStatistics):
(WebInspector.TimelinePanel.prototype._showFrameStatistics):
(WebInspector.TimelinePanel.prototype._updateFrameBars):
(WebInspector.TimelinePanel.prototype._overviewModeChanged.set if):
(WebInspector.TimelinePanel.prototype._overviewModeChanged):
(WebInspector.TimelinePanel.prototype._refresh):

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.prototype.):
(WebInspector.TimelinePresentationModel.prototype.compareEndTime):
(WebInspector.TimelinePresentationModel.prototype.filteredFrames):
(WebInspector.TimelinePresentationModel.generatePopupContentForFrameStatistics):

  • inspector/front-end/timelinePanel.css:

(.timeline-records-stats, .storage-application-cache-status, .storage-application-cache-connectivity):
(.timeline-records-stats):
(.timeline-frames-stats):

10:21 AM Changeset in webkit [133914] by jpetsovits@rim.com
  • 16 edits in trunk

[BlackBerry] Rework the API to use document coordinates
https://bugs.webkit.org/show_bug.cgi?id=101608
RIM PR 173292

Reviewed by Adam Treat.

Source/WebCore:

Provide a better API for WebPage to relay.
See Source/WebKit/blackberry/ChangeLog for details.

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::getWindowScreenRect):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(Platform):
(BlackBerry):
(MediaPlayerPrivate):

Source/WebKit/blackberry:

Scrolling and zooming APIs used to operate on
transformed coordinates, which is a bad idea:
The UI thread might long have moved on to a
different scale and scroll position so outdated
pixel coordinates are of limited value.

Moreover, more transformation calculations are
needed than if we operate purely on document
coordinates.

With webkitThreadViewportAccessor() exposed,
the caller has a choice between how to handle
coordinates and the means to perform conversions
with little effort and overhead if needed.
Therefore, we should remove pixel coordinates
from the public API. This commit makes this change.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::didRenderContent):

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScroller::setDocumentScrollPositionCompositingThread):
(BlackBerry::WebKit::InRegionScroller::setDocumentScrollPositionWebKitThread):
(BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):

  • Api/InRegionScroller.h:
  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::shouldZoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
(BlackBerry::WebKit::WebPage::setDocumentScrollPosition):
(BlackBerry::WebKit::WebPagePrivate::hasVirtualViewport):
(BlackBerry::WebKit::WebPagePrivate::notifyTransformedContentsSizeChanged):
(BlackBerry::WebKit::WebPagePrivate::notifyTransformedScrollChanged):
(BlackBerry::WebKit::WebPagePrivate::setCursor):
(BlackBerry::WebKit::WebPagePrivate::notifyPopupAutofillDialog):
(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::bestNodeForZoomUnderPoint):
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
(BlackBerry::WebKit::WebPagePrivate::zoomBlock):
(BlackBerry::WebKit::WebPage::setVirtualViewportSize):
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
(BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):
(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::setScrollOriginPoint):
(BlackBerry::WebKit::WebPage::setDocumentScrollOriginPoint):
(BlackBerry::WebKit::handleScrolling):
(BlackBerry::WebKit::WebPage::selectionContainsDocumentPoint):
(BlackBerry::WebKit::WebPage::setDocumentSelection):
(BlackBerry::WebKit::WebPage::setDocumentCaretPosition):
(BlackBerry::WebKit::WebPage::selectAtDocumentPoint):
(BlackBerry::WebKit::WebPagePrivate::setTextReflowAnchorPoint):
(BlackBerry::WebKit::WebPage::pinchZoomAboutPoint):
(BlackBerry::WebKit::WebPage::blockZoom):
(BlackBerry::WebKit::WebPage::nodeAtDocumentPoint):
(BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):

  • Api/WebPage.h:

(Platform):

  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebCoreSupport/AutofillManager.cpp:

(WebCore::AutofillManager::didChangeInTextField):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):

Tools:

Adapt to changed WebPage API.
See Source/WebKit/blackberry/ChangeLog for details.

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):

10:15 AM Changeset in webkit [133913] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectations for failing image tests following Chromium r166632.

Unreviewed gardening.

  • platform/chromium/TestExpectations:
9:51 AM Changeset in webkit [133912] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Widen flaky crash expectation fast/workers/worker-multi-startup.html to include linux.

Unreviewed gardening.

  • platform/chromium/TestExpectations:
9:44 AM Changeset in webkit [133911] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] http/tests/inspector/indexeddb/database-data.html ASSERT on Win7 following r133855
https://bugs.webkit.org/show_bug.cgi?id=101618

Unreviewed gardening.

  • platform/chromium/TestExpectations:
9:43 AM Changeset in webkit [133910] by keishi@webkit.org
  • 4 edits in trunk/Source

Add properties for week/month picker in DateTimeChooserImpl::writeDocument
https://bugs.webkit.org/show_bug.cgi?id=101552

Reviewed by Kent Tamura.

Source/Platform:

  • chromium/public/WebLocalizedString.h: Add WeekNumberLabel.

Source/WebKit/chromium:

Changing the arguments for calendar picker to support week/month picker.

  • src/DateTimeChooserImpl.cpp:

(WebKit::DateTimeChooserImpl::writeDocument):

9:35 AM Changeset in webkit [133909] by jsbell@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r133892.
http://trac.webkit.org/changeset/133892
https://bugs.webkit.org/show_bug.cgi?id=101617

Compile failures on mac, android, linux (Requested by
jsbell|gardener on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-08

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

  • bindings/v8/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::domDataStore):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

9:28 AM Changeset in webkit [133908] by eae@chromium.org
  • 26 edits
    28 adds
    7 deletes in trunk/LayoutTests

Unreviewed chromium mac rebaseline for r101497.

  • platform/chromium-mac-lion/fast/css/text-overflow-ellipsis-bidi-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/text-overflow-ellipsis-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/text-overflow-ellipsis-strict-expected.txt: Added.
  • platform/chromium-mac-lion/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/input-readonly-autoscroll-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/input-readonly-autoscroll-expected.txt: Added.
  • platform/chromium-mac-lion/fast/forms/search-rtl-expected.txt: Added.
  • platform/chromium-mac-lion/fast/multicol/span: Added.
  • platform/chromium-mac-lion/fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
  • platform/chromium-mac-lion/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
  • platform/chromium-mac-lion/fast/replaced/width100percent-textarea-expected.txt: Added.
  • platform/chromium-mac-lion/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-bidi-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/text-overflow-ellipsis-strict-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textarea-expected.png:
  • platform/chromium-mac-snowleopard/fast/replaced/width100percent-textarea-expected.txt: Added.
  • platform/chromium-mac-snowleopard/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-bidi-expected.png:
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-bidi-expected.txt: Added.
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-expected.png:
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-expected.txt: Added.
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.txt: Added.
  • platform/chromium-mac/fast/css/text-overflow-input-expected.png:
  • platform/chromium-mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png:
  • platform/chromium-mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/chromium-mac/fast/forms/basic-textareas-expected.png:
  • platform/chromium-mac/fast/forms/basic-textareas-expected.txt:
  • platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.png:
  • platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/chromium-mac/fast/forms/input-disabled-color-expected.png:
  • platform/chromium-mac/fast/forms/input-disabled-color-expected.txt:
  • platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.txt: Added.
  • platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png:
  • platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-mac/fast/forms/search-rtl-expected.png:
  • platform/chromium-mac/fast/forms/search-rtl-expected.txt: Added.
  • platform/chromium-mac/fast/multicol/span/anonymous-split-block-crash-expected.png:
  • platform/chromium-mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
  • platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/chromium-mac/fast/replaced/width100percent-textarea-expected.png:
  • platform/chromium-mac/fast/replaced/width100percent-textarea-expected.txt: Added.
  • platform/chromium-mac/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/css/text-overflow-input-expected.txt: Removed.
  • platform/chromium/fast/forms/input-readonly-dimmed-expected.txt: Removed.
  • platform/chromium/fast/forms/input-text-scroll-left-on-blur-expected.txt: Removed.
  • platform/gtk/fast/forms/basic-textareas-quirks-expected.txt: Removed.
  • platform/mac/fast/css/text-overflow-input-expected.txt: Removed.
  • platform/mac/fast/forms/input-readonly-dimmed-expected.txt: Removed.
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt: Removed.
9:28 AM Changeset in webkit [133907] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Canvas] UI iterations: image on the top, auto replay
https://bugs.webkit.org/show_bug.cgi?id=101584

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-08
Reviewed by Pavel Feldman.

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype._showTraceLog):
(WebInspector.CanvasProfileView.prototype._onTraceLogItemClick):
(WebInspector.CanvasProfileView.prototype._replayTraceLog.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._replayTraceLog):

  • inspector/front-end/canvasProfiler.css:

(.canvas-trace-log):
(#canvas-replay-image-container):
(#canvas-replay-image):

9:26 AM Changeset in webkit [133906] by commit-queue@webkit.org
  • 5 edits in trunk

While absolute positioning is put before the first flexitem, flexitems will move to a new line.
https://bugs.webkit.org/show_bug.cgi?id=101294

Patch by Wei Fanzhe <whyer1@gmail.com> on 2012-11-08
Reviewed by Ojan Vafai.

Source/WebCore:

This issue has to do with RenderFlexibleBox::computeNextFlexLine. When determing line breaks, the algorithm sees if 1) the total width exceeds lineBreakLength and 2) whether orderedChildren is non-empty. But then, if the total width exceeds lineBreakLength and there's only absolutely positioned elemments in orderedChildren then the conditions are met and the algorithm mistakenly breaks the line. The solution is to see if orderedChildren collects at least a flex item. If it does, break the line.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeNextFlexLine):

LayoutTests:

Add a case to test flexible layout while absolute positioning is put before the first flexitem.

  • css3/flexbox/flex-algorithm-expected.txt:
  • css3/flexbox/flex-algorithm.html:
9:19 AM Changeset in webkit [133905] by yael@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Gardening after r133898.

  • platform/efl/TestExpectations:
9:00 AM Changeset in webkit [133904] by Dimitri Glazkov
  • 10 edits in trunk/Source

Unreviewed, rolling out r133429.
http://trac.webkit.org/changeset/133429
https://bugs.webkit.org/show_bug.cgi?id=101173

Speculative roll out, investigating perf regression.

Source/WebCore:

  • dom/ContextFeatures.cpp:
  • dom/ContextFeatures.h:
  • dom/Position.cpp:

(WebCore::Position::Position):
(WebCore::Position::findParent):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::getSelection):

  • html/HTMLTagNames.in:
  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::contentTagName):

  • page/DOMWindow.idl:

Source/WebKit/chromium:

  • src/ContextFeaturesClientImpl.cpp:

(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):

8:45 AM Changeset in webkit [133903] by eae@chromium.org
  • 25 edits in trunk

Fix enclosingLayoutRect calls in InlineFlowBox.h
https://bugs.webkit.org/show_bug.cgi?id=101497

Reviewed by Levi Weintraub.

Source/WebCore:

InlineFlowBox.h used to include LayoutTypesInlineMethods.h which
overrid enclosingLayoutRect to call closingIntRect. When we
removed the LayoutTypes abstraction we switched these to
enclosingIntRect to preserve the behavior.
This patch changes these back to enclosingLayoutRect which is
the desired behavior.

Covered by existing tests.

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::layoutOverflowRect):
(WebCore::InlineFlowBox::visualOverflowRect):

LayoutTests:

Update tests expectations to reflect change form
enclosingIntRect to enclosingLayoutRect.

  • platform/chromium-linux/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/chromium-linux/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/chromium-win/svg/text/text-overflow-ellipsis-svgfont-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.txt:
  • platform/mac/fast/css/text-overflow-input-expected.txt:
  • platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/mac/fast/forms/input-disabled-color-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/mac/fast/replaced/width100percent-textarea-expected.txt:
  • platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.txt:
8:24 AM Changeset in webkit [133902] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Verify touched element using the rootEditableElement
https://bugs.webkit.org/show_bug.cgi?id=101510

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-08
Reviewed by Rob Buis.

Reviewed internally by Mike Fenton.

Move up the tree until we find the rootEditableElement and use
that to compare with the touched element.

  • WebKitSupport/FatFingers.h:

(BlackBerry::WebKit::FatFingersResult::node):
(BlackBerry::WebKit::FatFingersResult::nodeAsElementIfApplicable):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

7:43 AM Changeset in webkit [133901] by rjkroege@chromium.org
  • 2 edits in trunk/Source/Platform

[chromium] correct coding oversight for clang
https://bugs.webkit.org/show_bug.cgi?id=101513

Reviewed by Kent Tamura.

https://bugs.webkit.org/show_bug.cgi?id=100675 contains an
incorrect declaration that precludes compiling embedder code
with clang: patch changes class to struct appropriately.

  • chromium/public/WebGestureCurveTarget.h:

(WebKit):

7:39 AM Changeset in webkit [133900] by commit-queue@webkit.org
  • 2 edits in trunk

[EFL] Turn WTF_USE_TILED_BACKING_STORE in OptionsEfl.cmake.
https://bugs.webkit.org/show_bug.cgi?id=101559

Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2012-11-08
Reviewed by Kenneth Rohde Christiansen.

Follow-up to 133859; also change the default value in
OptionsEfl.cmake so that the default changes for people not using
build-webkit (ie. users) as well.

  • Source/cmake/OptionsEfl.cmake:
7:32 AM Changeset in webkit [133899] by allan.jensen@digia.com
  • 3 edits in trunk/Source/WebKit/qt

[Qt] API test tst_qwebinspector crashes
https://bugs.webkit.org/show_bug.cgi?id=101599

Reviewed by Simon Hausmann.

Delete the internal inspector from QWebPage destructor, instead of causing recursions
between QWebPagePrivate::setInspector and QWebInspector::setPage.

Also separate the three tests in tst_QWebInspector to better tell which one is failing.

  • Api/qwebpage.cpp:

(QWebPagePrivate::~QWebPagePrivate):
(QWebPagePrivate::setInspector):

  • tests/qwebinspector/tst_qwebinspector.cpp:

(tst_QWebInspector):
(tst_QWebInspector::attachAndDestroyPageFirst):
(tst_QWebInspector::attachAndDestroyInspectorFirst):
(tst_QWebInspector::attachAndDestroyInternalInspector):

7:25 AM Changeset in webkit [133898] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Turn on WTF_USE_TILED_BACKING_STORE by default
https://bugs.webkit.org/show_bug.cgi?id=101526

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-08
Reviewed by Kenneth Rohde Christiansen.

.:

Separate out ENABLE_WEBGL. It is not ready to be enabled by default.

  • Source/cmake/OptionsEfl.cmake:

Tools:

Turn on WTF_USE_TILED_BACKING_STORE for EFL port.

  • Scripts/webkitperl/FeatureList.pm:
7:19 AM Changeset in webkit [133897] by pdr@google.com
  • 2 edits in trunk/Source/WebCore

Remove unnecessary save/restore in SVGTextRunRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=101546

Reviewed by Andreas Kling.

This patch removes an unnecessary context save/restore SVGTextRunRenderingContext by
refactoring the code to save off the stroke thickness.

No new tests as this is heavily covered by existing tests.

  • rendering/svg/SVGTextRunRenderingContext.cpp:

(WebCore::SVGTextRunRenderingContext::drawSVGGlyphs):

7:09 AM Changeset in webkit [133896] by Simon Hausmann
  • 4 edits in trunk

[Qt] Fix build with MSVC 2012 and Angle
https://bugs.webkit.org/show_bug.cgi?id=101588

Reviewed by Tor Arne Vestbø.

Angle includes STL's <memory> header file, which with MSVC 2012 includes stdint.h. MSVC 2012
does ship stdint.h, but it's lacking other headers such as inttypes.h.

So for the rest of WebKit we have to continue to use our own versions of these files from
JavaScriptCore/os-win32. But for Angle we are just including a shipped STL header file (memory)
and so it's up to the compiler to make that work, i.e. using the stdint.h it ships.

This patch moves the addition of JavaScriptCore/os-win32 out of default_post.prf, so that it
doesn't apply to each and every target anymore. In particular it won't apply to Angle anymore,
because its presence causes a build issue where due to the addition of os-win32/ we end up
including our own stdint.h but are lacking WTF/ to be in the include search path (which our own
stdint.h requires). So out of default_post.prf and into WTF.pri, our own wrappers are now only
used where WTF is also needed, and since os-win32/stdint.h depends on wtf/Platform.h, it seems
like a logical location.

Source/WTF:

  • WTF.pri:

Tools:

  • qmake/mkspecs/features/default_post.prf:
6:56 AM Changeset in webkit [133895] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

Rebaseline fast/media/w3c/test_media_queries.html and fast/media/mq-resolution.html after r133884
https://bugs.webkit.org/show_bug.cgi?id=101597

Unreviewed, WebKit gardening.

Layout tests fast/media/w3c/test_media_queries.html and fast/media/mq-resolution.html
need new test expectations after r133884.

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-11-08

  • fast/media/mq-resolution-expected.txt:
  • fast/media/w3c/test_media_queries-expected.txt:
6:54 AM Changeset in webkit [133894] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

OpaqueJSClassContextData() should use StringImpl::isolatedCopy() to make string copies
https://bugs.webkit.org/show_bug.cgi?id=101507

Reviewed by Andreas Kling.

Changed to use isolatedCopy() for key Strings.

  • API/JSClassRef.cpp:

(OpaqueJSClassContextData::OpaqueJSClassContextData):

6:34 AM Changeset in webkit [133893] by Carlos Garcia Campos
  • 53 edits in trunk/Source/WebCore

[GTK] Clean up includes in GObject DOM bindings code
https://bugs.webkit.org/show_bug.cgi?id=101077

Reviewed by Kentaro Hara.

Remove some headers included multiple times for the same file and
fix consistency in the includes style.

  • bindings/gobject/DOMObjectCache.cpp:
  • bindings/gobject/GObjectEventListener.cpp:
  • bindings/gobject/GObjectEventListener.h:
  • bindings/gobject/WebKitDOMBinding.cpp:
  • bindings/gobject/WebKitDOMBinding.h:
  • bindings/gobject/WebKitDOMEventTarget.cpp:
  • bindings/gobject/WebKitDOMEventTarget.h:
  • bindings/gobject/WebKitDOMEventTargetPrivate.h:

(WebKit):

  • bindings/gobject/WebKitDOMObject.cpp:
  • bindings/gobject/WebKitDOMObject.h:
  • bindings/gobject/WebKitHTMLElementWrapperFactory.cpp:
  • bindings/gobject/WebKitHTMLElementWrapperFactory.h:
  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateHeader):
(GenerateFunction):
(Generate):
(WriteData):

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.h:
  • bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h:
  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructorPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
  • bindings/scripts/test/GObject/WebKitDOMTestEventTargetPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestException.h:
  • bindings/scripts/test/GObject/WebKitDOMTestExceptionPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.h:
  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructorPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestNode.h:
  • bindings/scripts/test/GObject/WebKitDOMTestNodePrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:
6:23 AM Changeset in webkit [133892] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[V8] Main world should have one DOMDataStore
https://bugs.webkit.org/show_bug.cgi?id=101470

Patch by Dan Carney <dcarney@google.com> on 2012-11-08
Reviewed by Kentaro Hara.

The main world DOMWrapperWorld held onto a DOMDataStore that should
never be used, as there is a static one optimized for speed in
DOMDataStore.

No new tests. No change in functionality.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

  • bindings/v8/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::isolatedWorldDomDataStore):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

6:15 AM Changeset in webkit [133891] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL] Remove non-variable options from the build system
https://bugs.webkit.org/show_bug.cgi?id=101506

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-11-08
Reviewed by Kenneth Rohde Christiansen.

.:

Remove WTF_USE_PTHREADS, WTF_USE_ICU_UNICODE, WTF_USE_CAIRO,
WTF_USE_FREETYPE and WTF_USE_HARFBUZZ_NG cmake variables
as these are always set to const 1 and not really configurable.

Remove the definition of ENABLE_CONTEXT_MENUS as this is already set to 1 by default in Platform.h.

  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Remove WTF_USE_ICU_UNICODE, WTF_USE_CAIRO and WTF_USE_FREETYPE cmake variables
as these are always set to const 1 and not really configurable.

Remove duplicate platform/graphics/cairo include path from
PlatformEfl.cmake.

No new tests as there is no new functionality.

  • PlatformEfl.cmake:

Source/WebKit:

Remove WTF_USE_FREETYPE and ENABLE_GLIB_SUPPORT cmake variables
as these are always set to const 1 and not really configurable.

  • PlatformEfl.cmake:
5:55 AM Changeset in webkit [133890] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Fix build without WebKit1
https://bugs.webkit.org/show_bug.cgi?id=101583

Patch by Simon Hausmann <simon.hausmann@digia.com> on 2012-11-08
Reviewed by Tor Arne Vestbø.

WebProcess needs access to the QStyle themeing via the initializeWebKit2Theme() function from
WebKit1. Try to access it depending on whether WebKit1 is built or not, not depending on whether
widgets are available not.

  • WebProcess.pro:
  • qt/MainQt.cpp:

(WebKit):
(main):

5:35 AM Changeset in webkit [133889] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unused parameters on GraphicsLayerUpdater.cpp
https://bugs.webkit.org/show_bug.cgi?id=101577

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-08
Reviewed by Kentaro Hara.

The parameter 'displayID' is not used when !USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR)
Use UNUSED_PARAM macro for removing -Wunused-parameter warnings

  • platform/graphics/GraphicsLayerUpdater.cpp:

(WebCore::GraphicsLayerUpdater::GraphicsLayerUpdater):
(WebCore::GraphicsLayerUpdater::screenDidChange):

5:23 AM Changeset in webkit [133888] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Rebaseline fast/canvas/fillText-shadow.html
https://bugs.webkit.org/show_bug.cgi?id=101587

Unreviewed gardening.

Test fast/canvas/fillText-shadow.html has to be rebased after r133834.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-08

  • platform/efl/fast/canvas/fillText-shadow-expected.txt:
5:21 AM Changeset in webkit [133887] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening after r133807 and r133820
https://bugs.webkit.org/show_bug.cgi?id=101585

Unreviewed gardening.

Skipping of compositing/absolute-inside-out-of-view-fixed.html and
editing/execCommand/switch-list-type-with-orphaned-li.html for EFL.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-08

  • platform/efl/TestExpectations:
5:19 AM Changeset in webkit [133886] by rakuco@webkit.org
  • 2 edits
    1 add
    1 delete in trunk/LayoutTests

[EFL] Rebaseline svg/css/group-with-shadow.svg
https://bugs.webkit.org/show_bug.cgi?id=101592

Unreviewed gardening.

Test svg/css/group-with-shadow.svg has to be rebaselined after r133834.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-08

  • platform/efl-wk1/svg/css/group-with-shadow-expected.png: Removed.
  • platform/efl/svg/css/group-with-shadow-expected.png: Added.
  • platform/efl/svg/css/group-with-shadow-expected.txt:
5:13 AM Changeset in webkit [133885] by apavlov@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: Add option to disable rulers (Elements panel)
https://bugs.webkit.org/show_bug.cgi?id=101554

Reviewed by Pavel Feldman.

A new setting, showMetricsRulers, has been introduced (off by default, so users need to opt in to see the rulers).
The setting value is passed into InspectorDOMAgent, down to the InspectorOverlayPage, which affects the drawGrid() and
drawRulers() calls. As a side effect, the issue when the rulers were painted for elements having no renderers has been fixed.

No new tests, a UI change.

  • English.lproj/localizedStrings.js: Add "Show rulers" string.
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject): Copy over the showRulers value.

  • inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForHighlight): Copy over the showRulers value.

  • inspector/InspectorOverlay.h:

(HighlightConfig): Add |bool showRulers|.
(WebCore::Highlight::Highlight): Initialize fields.
(Highlight): Add |bool showRulers|.
(WebCore::Highlight::setDataFromConfig):

  • inspector/InspectorOverlayPage.html:
  • inspector/front-end/DOMAgent.js: Make use of WebInspector.settings.showMetricsRulers when building the highlight DTO.
  • inspector/front-end/Settings.js: Add showMetricsRulers.
  • inspector/front-end/SettingsScreen.js:

(WebInspector.GenericSettingsTab): Add "Show rulers" checkbox in the Elements panel section.

5:11 AM Changeset in webkit [133884] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

Warn in the inspector console when using dpi and dpcm units outside of media="print"
https://bugs.webkit.org/show_bug.cgi?id=100865

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-11-08
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Added function that prints warning to inspector console whenever dpi or dpcm CSS units
are used for screen media.

Test: fast/media/mq-resolution-dpi-dpcm-warning.html

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::setMediaQueries):

  • css/MediaList.cpp:

(WebCore):
(WebCore::addResolutionWarningMessageToConsole):
(WebCore::reportMediaQueryWarningIfNeeded):

  • css/MediaList.h:

(WebCore):

  • css/MediaQueryMatcher.cpp:

(WebCore::MediaQueryMatcher::matchMedia):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parserAppendRule):

LayoutTests:

Added layout test that checks if warning is printed to console when dpi or dpcm CSS
units are used for resolution media feature.

  • fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Added.
  • fast/media/mq-resolution-dpi-dpcm-warning.html: Added.

Skip tests for platforms that doesn't support resolution media feature.

  • platform/chromium/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
5:10 AM Changeset in webkit [133883] by zandobersek@gmail.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a platform-specific baseline for the test added in r133868.

  • platform/gtk/http/tests/security/XFrameOptions: Added.
  • platform/gtk/http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt: Added.
4:45 AM Changeset in webkit [133882] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] Unreviewed build fix after r133880.

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::setAdditionalPluginPath):

4:39 AM Changeset in webkit [133881] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Console: "time" and "timeEnd" should have same number of required arguments
https://bugs.webkit.org/show_bug.cgi?id=101451

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-08
Reviewed by Yury Semikhatsky.

Solution: make console.time "title" parameter mandatory.

  • page/Console.idl: Changed parameter specification.
4:14 AM Changeset in webkit [133880] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Add ewk_context_additional_plugin_path_set API
https://bugs.webkit.org/show_bug.cgi?id=101530

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-11-08
Reviewed by Gyuyoung Kim.

Add ewk_context_additional_plugin_path_set() to set additional plugin directory.

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::setAdditionalPluginPath):
(ewk_context_additional_plugin_path_set):

  • UIProcess/API/efl/ewk_context.h:
  • UIProcess/API/efl/ewk_context_private.h:

(EwkContext):

  • UIProcess/API/efl/tests/test_ewk2_context.cpp:

(TEST_F):

3:55 AM Changeset in webkit [133879] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Use explicit constructor in BatteryProvider, DownloadManagerEfl, NetworkInfoProvider
https://bugs.webkit.org/show_bug.cgi?id=101567

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-08
Reviewed by Kentaro Hara.

Added explicit keyword in constructors of BatteryProvider, DownloadManagerEfl,
and NetworkInfoProvider in order to avoid implicit type conversion.

  • UIProcess/efl/BatteryProvider.h:

(BatteryProvider):

  • UIProcess/efl/DownloadManagerEfl.h:

(DownloadManagerEfl):

  • UIProcess/efl/NetworkInfoProvider.h:

(NetworkInfoProvider):

3:36 AM Changeset in webkit [133878] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

[EFL][WK2] Use smart pointers in EwkContext more actively
https://bugs.webkit.org/show_bug.cgi?id=101565

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-08
Reviewed by Gyuyoung Kim.

Since we're using WebContext instead of WKContext starting r133844 we should
use smart pointers accordingly including PassRefPtr.

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::EwkContext):
(EwkContext::~EwkContext):
(EwkContext::create):
(EwkContext::cookieManager):
(EwkContext::ensureFaviconDatabase):
(EwkContext::setFaviconDatabaseDirectoryPath):
(EwkContext::addVisitedLink):
(EwkContext::setCacheModel):
(EwkContext::cacheModel):

  • UIProcess/API/efl/ewk_context_private.h:

(EwkContext):
(EwkContext::webContext):

  • UIProcess/API/efl/ewk_database_manager_private.h:

(Ewk_Database_Manager::create):

  • UIProcess/API/efl/ewk_storage_manager_private.h:

(Ewk_Storage_Manager::create):

  • UIProcess/efl/DownloadManagerEfl.cpp:

(WebKit::DownloadManagerEfl::DownloadManagerEfl):

  • UIProcess/efl/RequestManagerClientEfl.cpp:

(WebKit::RequestManagerClientEfl::RequestManagerClientEfl):

3:32 AM Changeset in webkit [133877] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed fixed inspector frontend compilation

  • inspector/front-end/DataGrid.js:
3:32 AM Changeset in webkit [133876] by dominik.rottsches@intel.com
  • 2 edits in trunk

Unreviewed, rolling out r133865.
http://trac.webkit.org/changeset/133865
https://bugs.webkit.org/show_bug.cgi?id=101579

dependent patch has been rolled out. (Requested by drott on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-08

  • Source/cmake/OptionsEfl.cmake:
3:21 AM Changeset in webkit [133875] by dominik.rottsches@intel.com
  • 4 edits in trunk

Unreviewed, rolling out r133859.
http://trac.webkit.org/changeset/133859
https://bugs.webkit.org/show_bug.cgi?id=101526

Breaks EFL bots test execution.

.:

  • Source/cmake/OptionsEfl.cmake:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
2:49 AM Changeset in webkit [133874] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

GraphicsSurfaceGLX needs to query the drawable for YInversion.
https://bugs.webkit.org/show_bug.cgi?id=101472

After r133049 the WebGL content is now displayed upside down
for the Qt port. We cannot just apply a generic rule, that
the content needs to be flipped upside down.
Instead we have to query GLX to tell us, if the drawable's
framebuffer is y-inverted.

Reviewed by Kenneth Rohde Christiansen.

  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurfacePrivate::textureIsYInverted):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):

2:37 AM Changeset in webkit [133873] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Reduce the number of clean builds
https://bugs.webkit.org/show_bug.cgi?id=100844

Reviewed by Tor Arne Vestbø.

A change in any Qt project file shouldn't trigger clean
build always, but only if the incremental build failed.

  • Scripts/webkitdirs.pm:

(buildQMakeProjects):

2:35 AM Changeset in webkit [133872] by kadam@inf.u-szeged.hu
  • 5 edits in trunk/LayoutTests

[Qt] Unreviewed Gardening.

Skip a failing after r133820. Added new baseline after 133834. Update expectation after 133638.

  • platform/qt/TestExpectations:
  • platform/qt/css3/filters/effect-reference-expected.png:
  • platform/qt/css3/filters/effect-reference-expected.txt:
  • platform/qt/svg/css/group-with-shadow-expected.txt:
2:25 AM Changeset in webkit [133871] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][MiniBrowser] Add encoding detector option.
https://bugs.webkit.org/show_bug.cgi?id=100931

Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-08
Reviewed by Gyuyoung Kim.

Source/WebKit2:

Add triggering Settings::setUsesEncodingDetector for WK2 UI process.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

Add a runtime option to enable/disable encoding detector.

  • MiniBrowser/efl/main.c:

(window_create):
(elm_main):

2:15 AM WebKit Team edited by zandobersek@gmail.com
Adding myself as a committer. (diff)
1:53 AM Changeset in webkit [133870] by zandobersek@gmail.com
  • 5 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a failure expectation for editing/execCommand/switch-list-type-with-orphaned-li.html,
the test regressed in r133820
Further rebaselining after r133834.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/canvas/fillText-shadow-expected.txt:
  • platform/gtk/svg/css/group-with-shadow-expected.png:
  • platform/gtk/svg/css/group-with-shadow-expected.txt:
1:49 AM Changeset in webkit [133869] by kbalazs@webkit.org
  • 4 edits in trunk/Tools

[Qt] DumpRenderTree does not honor the shouldDumpPixels boolean argument of dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=101485

Reviewed by Csaba Osztrogonác.

[Qt] DumpRenderTree does not honor the shouldDumpPixels boolean argument of dumpAsText

Support dumpAsText(true) which means we should not dump a render tree
but should dump pixels. All other platforms already support it.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::dump):

  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunner::reset):
(TestRunner::dumpAsText):

  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner::shouldDumpPixels):
(TestRunner):

1:43 AM Changeset in webkit [133868] by mkwst@chromium.org
  • 6 edits
    3 adds in trunk

Warn when parsing an invalid X-Frame-Options header.
https://bugs.webkit.org/show_bug.cgi?id=101447

Reviewed by Adam Barth.

Source/WebCore:

An 'X-Frame-Options' header that contains an invalid option (that is,
neither 'DENY' nor 'SAMEORIGIN') is ignored. This patch adds a console
warning to notify developers that they've made a mistake.

Test: http/tests/security/XFrameOptions/x-frame-options-invalid.html

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

Move the request identifier generation out of the failure block in
order to pass it into 'shouldInterruptLoadForXFrameOptions'. This
ensures that the console message is properly tied to a request.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):

  • loader/FrameLoader.h:

(FrameLoader):

'shouldInterruptLoadForXFrameOptions' now accepts a request
identifier as a parameter, and generates a console message if the
load is blocked.

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

Pass the request identifier into 'shouldInterruptLoadForXFrameOptions'.

LayoutTests:

  • http/tests/security/XFrameOptions/resources/x-frame-options-invalid.cgi: Added.
  • http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt: Added.
  • http/tests/security/XFrameOptions/x-frame-options-invalid.html: Added.

New test with an invalid frame option value.

1:36 AM Changeset in webkit [133867] by Carlos Garcia Campos
  • 6 edits in trunk/Source/WebKit2

[GTK] WebKitWebView doesn't notify of favicon changes for known favicons but new pages
https://bugs.webkit.org/show_bug.cgi?id=98874

Reviewed by Martin Robinson.

If the page is unknown (not registered in the icon database) but
the icon is known (registered by another page) favicon-ready
signal is not emitted because the icon has already been imported
from the database. The view always asks for the favicon when the
load has been committed, but it's usually too early and the
favicon of the page is still unkown. We can use
didChangeIconForPageURLCallback to know when to ask for the
favicon emitting a favicon-changed signal. The callback
iconDataReadyForPageURLCallback is still useful to process pending
icon requests, but the favicon-ready signal can be removed in
favor of favicon-changed.

  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp:

(_WebKitFaviconDatabasePrivate): Keep a map of page icons that has
been imported to make sure we only emit favicon-changed signal
when the favicon URI has actually changed, because
didChangeIconForPageURLCallback can be called multiple times for
the same favicon URI in some cases.
(webkit_favicon_database_class_init): Remove favicon-ready signal
and add favicon-changed that includes the new favicon URI for the
given page URI.
(didChangeIconForPageURLCallback): Emit favicon-changed signal if
the favicon URI is new or has changed for the given page URI.
(iconDataReadyForPageURLCallback): Process pending icon requests.
(webkitFaviconDatabaseCreate): Add implementation for
didChangeIconForPageURLCallback.

  • UIProcess/API/gtk/WebKitFaviconDatabasePrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(_WebKitWebViewPrivate): Add favicon URI to make sure we only ask for a
new favicon when the favicon URI has changed.
(webkitWebViewUpdateFavicon): Update the favicon and emit
notify::favicon if it has changed.
(gotFaviconCallback): Update the favicon if the request hasn't
been cancelled.
(webkitWebViewRequestFavicon): Ask for the page favicon.
(webkitWebViewUpdateFaviconURI): Updated the favicon URI and
request the page favicon if the favicon URI has changed.
(faviconChangedCallback): Call webkitWebViewUpdateFaviconURI() with
the given favicon URI.
(webkitWebViewWatchForChangesInFavicon): Connect to
WebKitFaviconDatabase::favicon-changed.
(webkitWebViewDisconnectFaviconDatabaseSignalHandlers): Disconnect
WebKitFaviconDatabase::favicon-changed signal.
(webkitWebViewLoadChanged): Call webkitWebViewUpdateFaviconURI()
with the current favicon URI when the load has been committed.

  • UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:

(serverCallback):
(testNotInitialized):
(testGetFavicon):
(testGetFaviconURI):
(testWebViewFavicon):
(beforeAll):

  • UIProcess/API/gtk/webkit2marshal.list: Add new marshaler.
1:02 AM Changeset in webkit [133866] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Attempt to silence a compiler warning.

  • WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:

(WebKit::RemoteGraphicsLayer::RemoteGraphicsLayer):

1:00 AM Changeset in webkit [133865] by rakuco@webkit.org
  • 2 edits in trunk

[EFL] Turn WTF_USE_TILED_BACKING_STORE in OptionsEfl.cmake.
https://bugs.webkit.org/show_bug.cgi?id=101559

Reviewed by Kenneth Rohde Christiansen.

Follow-up to 133859; also change the default value in
OptionsEfl.cmake so that the default changes for people not using
build-webkit (ie. users) as well.

  • Source/cmake/OptionsEfl.cmake:
12:49 AM Changeset in webkit [133864] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Moving some expectations to proper sections, unskiping a couple of tests
and merging expectations for tests in printing/.

  • platform/gtk/TestExpectations:
12:40 AM Changeset in webkit [133863] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Web Inspector: Timeline: Improve time/timeEnd appearance.
https://bugs.webkit.org/show_bug.cgi?id=100936

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-08
Reviewed by Yury Semikhatsky.

Source/WebCore:

Changes:

  • time/timeEnd records should be top level records only in "glue" mode
  • time/timeEnd records should display "message" in record list / popover
  • glued records add aggregated statistics to root record
  • glued records do not reduce their origin self time

Test: inspector/timeline/timeline-time.html

  • English.lproj/localizedStrings.js: Added "Message" string.
  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record): Added "origin" field.

LayoutTests:

Tested gluing of time/timeEnd records.

  • inspector/timeline/timeline-time-expected.txt: Added.
  • inspector/timeline/timeline-time.html: Added.
12:35 AM Changeset in webkit [133862] by yurys@chromium.org
  • 9 edits in trunk

Web Inspector: move front-end methods called from native part to InspectorFrontendAPI
https://bugs.webkit.org/show_bug.cgi?id=101463

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Moved Web Inspector methods called from native code to InspectorFrontendAPI.

  • inspector/InspectorClient.cpp:

(WebCore::InspectorClient::doDispatchMessageOnFrontendPage):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::FrontendMenuProvider::create):
(WebCore::FrontendMenuProvider::disconnect):
(WebCore::FrontendMenuProvider::FrontendMenuProvider):
(WebCore::FrontendMenuProvider::contextMenuItemSelected):
(WebCore::FrontendMenuProvider::contextMenuCleared):
(FrontendMenuProvider):
(WebCore::InspectorFrontendHost::showContextMenu):

  • inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.loadCompleted):
(InspectorFrontendAPI.contextMenuItemSelected):
(InspectorFrontendAPI.contextMenuCleared):
(InspectorFrontendAPI.dispatchMessageAsync):
(InspectorFrontendAPI.dispatchMessage):

  • inspector/front-end/inspector.js:

Source/WebKit/chromium:

Moved Web Inspector methods called from native code to InspectorFrontendAPI. Updated
WebDevToolsFrontendImpl appropriately.

  • src/WebDevToolsFrontendImpl.cpp:

(WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):

LayoutTests:

Moved Web Inspector methods called from native code to InspectorFrontendAPI.

  • http/tests/inspector-protocol/resources/InspectorTest.js:

(InspectorFrontendAPI.dispatchMessageAsync):

12:33 AM Changeset in webkit [133861] by zandobersek@gmail.com
  • 18 edits
    5 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining after r131974, r133037 and r133834.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/gtk/fast/table/025-expected.png:
  • platform/gtk/fast/table/025-expected.txt:
  • platform/gtk/svg/css/arrow-with-shadow-expected.png:
  • platform/gtk/svg/css/arrow-with-shadow-expected.txt:
  • platform/gtk/svg/css/clippath-with-shadow-expected.txt:
  • platform/gtk/svg/css/composite-shadow-example-expected.png:
  • platform/gtk/svg/css/composite-shadow-example-expected.txt:
  • platform/gtk/svg/css/composite-shadow-text-expected.png:
  • platform/gtk/svg/css/composite-shadow-with-opacity-expected.png: Added.
  • platform/gtk/svg/css/composite-shadow-with-opacity-expected.txt:
  • platform/gtk/svg/css/shadow-changes-expected.png:
  • platform/gtk/svg/css/shadow-changes-expected.txt:
  • platform/gtk/svg/custom/pattern-scaling-expected.png: Added.
  • platform/gtk/svg/custom/pattern-scaling-expected.txt: Added.
  • platform/gtk/svg/custom/pattern-skew-transformed-expected.png:
  • platform/gtk/svg/custom/pattern-skew-transformed-expected.txt: Added.
  • platform/gtk/svg/custom/pattern-with-transformation-expected.png:
  • platform/gtk/svg/custom/simple-text-double-shadow-expected.txt:
  • platform/gtk/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
  • platform/gtk/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
12:17 AM Changeset in webkit [133860] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

User can change a disabled select (drop down box)
https://bugs.webkit.org/show_bug.cgi?id=100932

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-08
Reviewed by Kent Tamura.

Source/WebCore:

<select> should not handle events if it's disabled.

Test: fast/forms/select/select-disabled.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::defaultEventHandler):

LayoutTests:

Verify that keyboard events do not change value of disabled select.

  • fast/forms/select/select-disabled-expected.txt: Added.
  • fast/forms/select/select-disabled.html: Added.
12:10 AM Changeset in webkit [133859] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Turn on WTF_USE_TILED_BACKING_STORE by default
https://bugs.webkit.org/show_bug.cgi?id=101526

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-08
Reviewed by Kenneth Rohde Christiansen.

.:

Separate out ENABLE_WEBGL. It is not ready to be enabled by default.

  • Source/cmake/OptionsEfl.cmake:

Tools:

Turn on WTF_USE_TILED_BACKING_STORE for EFL port.

  • Scripts/webkitperl/FeatureList.pm:
12:05 AM Changeset in webkit [133858] by alecflett@chromium.org
  • 9 edits in trunk/Source

IndexedDB: Rename methods and remove dead code from IDBBackingStore
https://bugs.webkit.org/show_bug.cgi?id=101488

Reviewed by Ojan Vafai.

Source/WebCore:

In preparation for merging IDBBackingStore and IDBLevelDBBackingStore:

1) rename ObjectStoreRecordIdentifier to RecordIdentifier
2) remove IDBBackingStore::forEachRecord and friends
3) remove IDBBackingStore::Cursor::close, since it was an empty method.

No new tests as this is purely code cleanup.

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::getRecord):
(WebCore):
(WebCore::IDBLevelDBBackingStore::putRecord):
(WebCore::IDBLevelDBBackingStore::createInvalidRecordIdentifier):
(WebCore::IDBLevelDBBackingStore::deleteRecord):
(WebCore::IDBLevelDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBLevelDBBackingStore::putIndexDataForRecord):
(WebCore::IDBLevelDBBackingStore::deleteIndexDataForRecord):

  • Modules/indexeddb/IDBBackingStore.h:

(WebCore::IDBBackingStore::RecordIdentifier::~RecordIdentifier):
(IDBBackingStore):

  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::close):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::countInternal):
(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::getKeyInternal):

  • Modules/indexeddb/IDBLevelDBBackingStore.h:

(IDBLevelDBBackingStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):
(WebCore::IDBObjectStoreBackendImpl::countInternal):

Source/WebKit/chromium:

Update IDBFakeBackingStore to reflect method changes in IDBBackingStore.

  • tests/IDBFakeBackingStore.h:

Nov 7, 2012:

11:38 PM Changeset in webkit [133857] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: console error after inspecting IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=101481

Reviewed by Pavel Feldman.

Added objectId nullity check to RemoteOBject::release.
Drive-by added release for entry key and primaryKey.

  • inspector/front-end/IndexedDBViews.js:

(WebInspector.IDBDataView.prototype.clear):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.release):

11:35 PM Changeset in webkit [133856] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Web Inspector: some tests failing with "Cannot call method 'hasTextContent' of undefined"
https://bugs.webkit.org/show_bug.cgi?id=94501

Unreviewed unskipped test.

  • platform/chromium/TestExpectations:
11:32 PM Changeset in webkit [133855] by vsevik@chromium.org
  • 7 edits in trunk

Web Inspector: Migrate inspector IndexedDB support to frontend API.
https://bugs.webkit.org/show_bug.cgi?id=101457

Reviewed by Pavel Feldman.

Source/WebCore:

Migrated IndexedDB support to web facing IndexedDB API.

  • inspector/Inspector.json:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore):
(WebCore::assertIDBFactory):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):

  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel.prototype.innerCallback):
(WebInspector.IndexedDBModel.prototype._requestData):

  • inspector/front-end/IndexedDBViews.js:

(WebInspector.IDBDataView.prototype._updateData.callback):
(WebInspector.IDBDataView.prototype._updateData):
(WebInspector.IDBDataGridNode):
(WebInspector.IDBDataGridNode.prototype.createCell):

LayoutTests:

  • http/tests/inspector/indexeddb/database-data.html:
11:29 PM Changeset in webkit [133854] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Make wait-for-SVN-server.py accept empty string as revision
https://bugs.webkit.org/show_bug.cgi?id=98014

Reviewed by Dirk Pranke.

  • BuildSlaveSupport/wait-for-SVN-server.py:

(waitForSVNRevision):

11:03 PM Changeset in webkit [133853] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Web Inspector: Infinite loop in DataGrid::autoSizeColumn
https://bugs.webkit.org/show_bug.cgi?id=101363

Patch by Vsevolod Vlasov <vsevik@chromium.org> on 2012-11-07
Reviewed by Pavel Feldman.

  • inspector/datagrid-autosize-expected.txt: Added.
  • inspector/datagrid-autosize.html: Added.
10:49 PM Changeset in webkit [133852] by vsevik@chromium.org
  • 5 edits in trunk/Source

Web Inspector: Drop dimmed crumb handling
https://bugs.webkit.org/show_bug.cgi?id=94457

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-08-20
Reviewed by Vsevolod Vlasov.

Source/WebCore:

No new tests. Existing inspector test should work.

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
(WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes):

  • inspector/front-end/breadcrumbList.css:

Source/WebKit/chromium:

  • src/js/devTools.css:
10:45 PM Changeset in webkit [133851] by vsevik@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Infinite loop in DataGrid::autoSizeColumn
https://bugs.webkit.org/show_bug.cgi?id=101363

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/datagrid-autosize.html

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._autoSizeWidths):
(WebInspector.DataGrid.prototype.autoSizeColumns):

LayoutTests:

  • inspector/datagrid-autosize-expected.txt: Added.
  • inspector/datagrid-autosize.html: Added.
10:35 PM Changeset in webkit [133850] by keishi@webkit.org
  • 7 edits in trunk

Implement week picking to calendar picker
https://bugs.webkit.org/show_bug.cgi?id=101449

Reviewed by Kent Tamura.

.:

  • ManualTests/forms/calendar-picker.html: Added test for week picker.

Source/WebCore:

This adds week picker mode to CalendarPicker.

No new tests. Tests will be added later when this feature is enabled in DRT.

  • Resources/pagepopups/calendarPicker.css:

(.month-mode .day):
(.week-mode .available.day-selected.monday): Rounded corners around week selection.
(.week-mode .available.day-selected.sunday): Ditto.
(.week-mode .unavailable.day-selected):
(.week-mode .unavailable.day-selected.monday):
(.week-mode .unavailable.day-selected.sunday):
(.week-mode .week-column.unavailable.day-selected):
(.week-column): Hide week column unless in week mode.
(.week-mode .week-column):

  • Resources/pagepopups/calendarPicker.js:

(parseDateString): Support week string.
(Week):
(Week.parse): Parses "yyyy-Www" string.
(Week.createFromDate): Creates Week containing datetime.
(Week.createFromToday): Creates Week containing today.
(Week.weekOneStartDateForYear): Returns the start date for the first week of year.
(Week.numberOfWeeksInYear): Returns the number of weeks in year.
(Week._numberOfWeeksSinceDate): Returns number of weeks since a date.
(Week.prototype.equals): Returns true if the Weeks are the same.
(Week.prototype.previous): Returns the previous Week.
(Week.prototype.next): Returns the next Week.
(Week.prototype.startDate): Returns start datetime of Week.
(Week.prototype.endDate): Returns end datetime of Week.
(Week.prototype.valueOf): Returns the milliseconds since epoch.
(Week.prototype.toString): Returns ISO week string.
(CalendarPicker): Add week picker mode.
(CalendarPicker.prototype.showMonth): Use NavigationBehaviour instead of bools.
(YearMonthController.prototype.attachTo): Fix bug.
(YearMonthController.prototype.moveRelatively): Use new showMonth.
(DaysTable.prototype.attachTo): Add week number column.
(DaysTable.prototype._renderMonth): Render week numbers.
(DaysTable.prototype.navigateToMonth): Render week numbers.
(DaysTable.prototype.selectRange):
(DaysTable.prototype._selectRangeAtPosition): Week number nodes have an positionX of -1.
(DaysTable.prototype._maybeSetPreviousMonth):
(DaysTable.prototype._maybeSetNextMonth):
(MonthPickerDaysTable.prototype.selectRange):
(MonthPickerDaysTable.prototype.selectRangeAndShowEntireRange):
(MonthPickerDaysTable.prototype._handleKey):
(WeekPickerDaysTable): Added.
(WeekPickerDaysTable.prototype._markRangeAsSelected): Marks week as selected.
(WeekPickerDaysTable.prototype.selectRange): Selects week.
(WeekPickerDaysTable.prototype.selectRangeAndShowEntireRange): Selects week and navigate to show entire selection.
(WeekPickerDaysTable.prototype._rangeForNode): Returns Week for node.
(WeekPickerDaysTable.prototype._handleKey):

LayoutTests:

  • platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html: Needs to be changed because we changed DaysTable DOM.
10:14 PM Changeset in webkit [133849] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, WebKit gardening.

Remove a duplication which caused a webkit-lint error.

  • platform/chromium/TestExpectations:
10:08 PM Changeset in webkit [133848] by commit-queue@webkit.org
  • 25 edits
    2 adds in trunk

Unreviewed, rolling out r133841.
http://trac.webkit.org/changeset/133841
https://bugs.webkit.org/show_bug.cgi?id=101542

Reverted patches were innocent (Requested by shinyak on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-07

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • dom/Element.cpp:

(WebCore::Element::shadowPseudoId):

  • dom/Element.h:

(Element):

  • dom/ElementRareData.cpp:

(WebCore::ElementRareData::reportMemoryUsage):

  • dom/ElementRareData.h:

(ElementRareData):

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updatePlaceholderText):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::createShadowSubtree):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::buildBubbleTree):

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitLiteral):
(WebCore::DateTimeEditElement::DateTimeEditElement):

  • html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::initialize):

  • html/shadow/DateTimeFieldElement.h:

(DateTimeFieldElement):

  • html/shadow/PickerIndicatorElement.cpp:

(WebCore::PickerIndicatorElement::PickerIndicatorElement):

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCueBox::TextTrackCueBox):
(WebCore::TextTrackCue::updateDisplayTree):

  • testing/Internals.cpp:

(WebCore::Internals::setShadowPseudoId):

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • fast/dom/shadow/styling-pseudo-attribute-expected.html: Added.
  • fast/dom/shadow/styling-pseudo-attribute.html: Added.
  • platform/chromium/TestExpectations:
9:40 PM Changeset in webkit [133847] by hayato@chromium.org
  • 5 edits
    6 copies
    4 moves
    6 adds
    6 deletes in trunk/LayoutTests

Unreviewed, WebKit gardening.

Rebaseline after r133384.

  • fast/repaint/moving-shadow-on-container-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/repaint/moving-shadow-on-container-expected.txt.
  • platform/chromium-linux-x86/svg/css/group-with-shadow-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.txt.
  • platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
  • platform/chromium-linux/svg/css/group-with-shadow-expected.png: Added.
  • platform/chromium-linux/svg/css/group-with-shadow-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.txt.
  • platform/chromium-mac-lion/svg/css/group-with-shadow-expected.png: Renamed from LayoutTests/platform/chromium-mac-snowleopard/svg/css/group-with-shadow-expected.png.
  • platform/chromium-mac-lion/svg/css/group-with-shadow-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.txt.
  • platform/chromium-mac-snowleopard/svg/css/group-with-shadow-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.txt.
  • platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.txt:
  • platform/chromium-mac/svg/css/group-with-shadow-expected.png: Added.
  • platform/chromium-mac/svg/css/group-with-shadow-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.txt.
  • platform/chromium-win-xp/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
  • platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Added.
  • platform/chromium-win-xp/svg/css/group-with-shadow-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/css/group-with-shadow-expected.txt.
  • platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
  • platform/chromium-win/svg/css/group-with-shadow-expected.png: Added.
  • platform/chromium-win/svg/css/group-with-shadow-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
  • platform/chromium/svg/css/group-with-shadow-expected.png: Removed.
  • platform/efl-wk1/fast/repaint/moving-shadow-on-container-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/moving-shadow-on-container-expected.png.
  • platform/efl-wk1/svg/css/group-with-shadow-expected.png: Renamed from LayoutTests/platform/efl/svg/css/group-with-shadow-expected.png.
  • platform/efl/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
9:36 PM Changeset in webkit [133846] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Fix EFL build, which has accelerated compositing disabled, by making
repaintViewRectangle() const.

  • rendering/RenderView.cpp:

(WebCore::RenderView::repaintViewRectangle):

  • rendering/RenderView.h:

(RenderView):

9:15 PM Changeset in webkit [133845] by Simon Fraser
  • 41 edits in trunk/Source/WebCore

constify ALL the repaint containers
https://bugs.webkit.org/show_bug.cgi?id=101541

Reviewed by Beth Dakin.

Make all the RenderLayerModelObject* repaintContainer arguments const, since
these member functions should have no need to mutate this object.

  • WebCore.exp.in:
  • rendering/RenderBR.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::rectWithOutlineForRepaint):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::outlineBoundsForRepaint):
(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):

  • rendering/RenderBox.h:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::repaintRectangleInRegions): Need to use a const_iterator.

  • rendering/RenderFlowThread.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::rectWithOutlineForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::mapLocalToContainer):

  • rendering/RenderInline.h:
  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::selectionRectForRepaint):

  • rendering/RenderListMarker.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
(WebCore::RenderObject::rectWithOutlineForRepaint):
(WebCore::RenderObject::clippedOverflowRectForRepaint):
(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::computeFloatRectForRepaint):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::localToContainerQuad):
(WebCore::RenderObject::localToContainerPoint):

  • rendering/RenderObject.h:

(WebCore::RenderObject::selectionRectForRepaint):
(WebCore::RenderObject::outlineBoundsForRepaint):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::selectionRectForRepaint):
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):

  • rendering/RenderReplaced.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::computeRectForRepaint):

  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::clippedOverflowRectForRepaint):

  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::clippedOverflowRectForRepaint):

  • rendering/RenderTableRow.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::clippedOverflowRectForRepaint):
(WebCore::RenderText::selectionRectForRepaint):

  • rendering/RenderText.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::mapLocalToContainer):
(WebCore::RenderView::computeRectForRepaint):

  • rendering/RenderView.h:
  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGForeignObject::computeFloatRectForRepaint):
(WebCore::RenderSVGForeignObject::mapLocalToContainer):

  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGGradientStop.h:
  • rendering/svg/RenderSVGHiddenContainer.h:
  • rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::clippedOverflowRectForRepaint):
(WebCore::RenderSVGInline::computeFloatRectForRepaint):
(WebCore::RenderSVGInline::mapLocalToContainer):

  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGModelObject::computeFloatRectForRepaint):
(WebCore::RenderSVGModelObject::mapLocalToContainer):
(WebCore::RenderSVGModelObject::outlineBoundsForRepaint):

  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
(WebCore::RenderSVGRoot::computeFloatRectForRepaint):
(WebCore::RenderSVGRoot::mapLocalToContainer):

  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::clippedOverflowRectForRepaint):
(WebCore::RenderSVGText::computeRectForRepaint):
(WebCore::RenderSVGText::computeFloatRectForRepaint):
(WebCore::RenderSVGText::mapLocalToContainer):

  • rendering/svg/RenderSVGText.h:
  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::computeFloatRectForRepaint):
(WebCore::SVGRenderSupport::mapLocalToContainer):

  • rendering/svg/SVGRenderSupport.h:

(SVGRenderSupport):

8:38 PM Changeset in webkit [133844] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebKit2

[EFL][WK2] Make ewk_context use WebContext instead of WKContext
https://bugs.webkit.org/show_bug.cgi?id=101477

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-07
Reviewed by Gyuyoung Kim.

Refactor ewk_context to use WebContext as ewk_context is encapsulated in a C++ classes.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl):

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::EwkContext):
(EwkContext::~EwkContext):
(EwkContext::create):
(EwkContext::defaultContext):
(EwkContext::cookieManager):
(EwkContext::ensureFaviconDatabase):
(EwkContext::setFaviconDatabaseDirectoryPath):
(EwkContext::addVisitedLink):
(EwkContext::setCacheModel):
(EwkContext::cacheModel):

  • UIProcess/API/efl/ewk_context_private.h:

(EwkContext):
(EwkContext::webContext):

  • UIProcess/API/efl/ewk_database_manager.cpp:

(Ewk_Database_Manager::Ewk_Database_Manager):
(Ewk_Database_Manager::getDatabaseOrigins):

  • UIProcess/API/efl/ewk_database_manager_private.h:

(Ewk_Database_Manager::create):
(Ewk_Database_Manager):

  • UIProcess/API/efl/ewk_storage_manager.cpp:

(Ewk_Storage_Manager::Ewk_Storage_Manager):
(Ewk_Storage_Manager::getStorageOrigins):

  • UIProcess/API/efl/ewk_storage_manager_private.h:

(Ewk_Storage_Manager::create):
(Ewk_Storage_Manager):

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_base_add):

  • UIProcess/efl/DownloadManagerEfl.cpp:

(WebKit::DownloadManagerEfl::DownloadManagerEfl):

  • UIProcess/efl/RequestManagerClientEfl.cpp:

(WebKit::RequestManagerClientEfl::RequestManagerClientEfl):

8:34 PM Changeset in webkit [133843] by dpranke@chromium.org
  • 1114 edits
    1107 copies
    40 adds in trunk/LayoutTests

Unreviewed, new chromium-mac-mountainlion svg baselines.

8:12 PM Changeset in webkit [133842] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

[Chromium-win] Refactor date/time format conversion code in LocaleWin
https://bugs.webkit.org/show_bug.cgi?id=101329

Reviewed by Kentaro Hara.

convertWindowsDateFormatToLDML and convertWindowsTimeFormatToLDML did
similar jobs with different code. We can merge them into one function.

As for the date format conversion, we have tokenized a format string and
stored token objects into a vector. We skip token object generation and
generate a LDML-compliant pattern string during parsing.

No new tests. This should make no behavior changes and
WebKit/chromium/tests/LocaleWinTest.cpp has test cases.

  • platform/text/win/LocaleWin.cpp:

(WebCore): Remove DateFormatToken, isFooSymbol, ensureShortDateTokens,
convertWindowsDateFormatToLDML, mapCharacterToDateTimeFieldType, and
convertWindowsTimeFormatToLDML.
(WebCore::commitLiteralToken): Store the result to the specified StringBuilder.
(WebCore::convertWindowsDateTimeFormat):
Renamed from parseDateFormat, and supports time format symbols.
(WebCore::LocaleWin::dateFormat): Use convertWindowsDateTimeFormat.
(WebCore::LocaleWin::monthFormat): Ditto.
(WebCore::LocaleWin::timeFormat): Ditto.
(WebCore::LocaleWin::shortTimeFormat): Ditto.

  • platform/text/win/LocaleWin.h:

(LocaleWin): Remove ensureShortDateTokens and m_shortDateTokens.

8:00 PM Changeset in webkit [133841] by shinyak@chromium.org
  • 25 edits
    2 deletes in trunk

Unreviewed, rolling out r133428 and r133749
https://bugs.webkit.org/show_bug.cgi?id=101533

These patches might cause memory regression.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • dom/Element.cpp:

(WebCore::Element::shadowPseudoId):
(WebCore):
(WebCore::Element::setShadowPseudoId):

  • dom/Element.h:

(Element):

  • dom/ElementRareData.cpp:

(WebCore::ElementRareData::reportMemoryUsage):

  • dom/ElementRareData.h:

(ElementRareData):

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updatePlaceholderText):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::createShadowSubtree):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::buildBubbleTree):

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitLiteral):
(WebCore::DateTimeEditElement::DateTimeEditElement):

  • html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::initialize):

  • html/shadow/DateTimeFieldElement.h:

(DateTimeFieldElement):

  • html/shadow/PickerIndicatorElement.cpp:

(WebCore::PickerIndicatorElement::PickerIndicatorElement):

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCueBox::TextTrackCueBox):
(WebCore::TextTrackCue::updateDisplayTree):

  • testing/Internals.cpp:

(WebCore::Internals::setShadowPseudoId):

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • fast/dom/shadow/styling-pseudo-attribute-expected.html: Removed.
  • fast/dom/shadow/styling-pseudo-attribute.html: Removed.
  • platform/chromium/TestExpectations:
7:50 PM Changeset in webkit [133840] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Crash in WebCore::RenderLayer::normalFlowList
https://bugs.webkit.org/show_bug.cgi?id=101528

Reviewed by Simon Fraser.

Make sure the layout is up to date before re-computing the caret rect.
Avoid doing the layout when the selection is cleared since we can always stop
the blink timer in that case.

Unfortunately, we haven't found any reproduction of this crash yet.

  • editing/FrameSelection.cpp:

(WebCore::isNonOrphanedCaret):
(WebCore::FrameSelection::localCaretRect):
(WebCore::FrameSelection::updateAppearance):

7:42 PM Changeset in webkit [133839] by hayato@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

Marking new test editing/execCommand/switch-list-type-with-orphaned-li.html per webkit.org/b/101539.

  • platform/chromium/TestExpectations:
7:23 PM Changeset in webkit [133838] by kareng@chromium.org
  • 1 edit
    2 copies in branches/chromium/1312

Merge 133124 - [Refactoring] Move initial style setting for ProgressValueElement from attach method to createShadowSubtree method in HTMLProgressElement.
https://bugs.webkit.org/show_bug.cgi?id=83664

Reviewed by Hajime Morita.

Source/WebCore:

The original code updates inline style during attach(). However,
the attach would be invoked from Element::recalcStyle()'s reattach().
If updating inline styles during the reattach(), style related flags,
i.e. childNeedsStyleRecalc, and needsStyleRecalc are cleared after the
reattach(). So the inline styles are not updated in next
setNeedsStyleRecalc, because ProgressValueElement has already had
InlineStyleChange (existingChanegType == InlineStyleChange) and
markAncestorsWithChildNeedsStyleRecalc is not invoked.

Test: fast/dom/HTMLProgressElement/progress-bar-set-value.html

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::attach):
Copied updateFromElement from didElementStateChange. If removing the
update, indeterminate-progress-001.html and progress-element.html
under fast/dom/HTMLProgressElement will fail. We still need attach()
and updateFromElement. To remove the attach(), need more refactoring,
i.e. investigating where attach() is invoked from and modifying all
related codes.
(WebCore::HTMLProgressElement::createShadowSubtree):
Initialize m_value by indeterminate-position. The value is default
value of progress element.

LayoutTests:

  • fast/dom/HTMLProgressElement/progress-bar-set-value-expected.html: Added.
  • fast/dom/HTMLProgressElement/progress-bar-set-value.html: Added.

TBR=tasak@google.com
Review URL: https://codereview.chromium.org/11275208

7:05 PM Changeset in webkit [133837] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

[V8] IntrusiveDOMWrapperMap should be usable for more than just Nodes
https://bugs.webkit.org/show_bug.cgi?id=101110

Reviewed by Kentaro Hara.

Hopefully the memory issues with this patch have been resolved by
fixing bug 101525. This patch re-lands this patch again, hopefully for
the last time.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::weakCallback):

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::wrapperIsStoredInObject):
(WebCore::DOMDataStore::getWrapperFromObject):
(WebCore::DOMDataStore::setWrapperInObject):

7:03 PM Changeset in webkit [133836] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Seam occurred between pieces of ShadowBlur on floating point zoom
https://bugs.webkit.org/show_bug.cgi?id=101435

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-07
Reviewed by Simon Fraser.

When paint Shadow that doesn't have blurred edge on floating point zoom,
pixel seam (pixel cracks) occurred between pieces of the ShadowBlur because of unaligned clip rect.
So, enlarge the clipping area 1 pixel so that the fill does not bleed (due to antialiasing)
even if the unaligned clip rect occurred.

  • platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::calculateLayerBoundingRect):

7:01 PM Changeset in webkit [133835] by dpranke@chromium.org
  • 148 edits
    135 copies
    27 adds in trunk/LayoutTests

Unreviewed, new chromium-mac-mountainlion baselines for remaining dirs outside of fast, svg, and tables.

6:58 PM Changeset in webkit [133834] by timothy_horton@apple.com
  • 26 edits
    7 adds in trunk

Repaint issues with -webkit-svg-shadow used on a container
https://bugs.webkit.org/show_bug.cgi?id=65643
<rdar://problem/7600532>

Reviewed by Simon Fraser.

SVG renderer repaint rects are currently expanded only by the shadow of
the renderer itself; however, the area they need to repaint can be larger
than that, if their parents also have shadows. We need to take into account
parent's shadows (respecting transforms, as well).

clippedOverflowRectForRepaint already recurses upwards through the render tree,
and ends up with a rect in layout coordinates, so we manually apply the shadow
at each step (repaintRectInLocalCoordinatesExcludingSVGShadow was added to allow
us to get the raw repaint rect without the shadow baked-in).

repaintRectInLocalCoordinates now includes shadows from all parents.

Also, RenderSVGRoot was clipping repaint rects to the viewport before applying
shadows, so offscreen elements with on-screen shadows (applied by the root) would not paint the shadows.
We can just swap the order of these things to correct this.

Tests: svg/css/parent-shadow-offscreen.svg, svg/css/root-shadow-offscreen.svg, svg/repaint/repaint-webkit-svg-shadow.svg

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::addChild): Mark the child being added as having an SVG shadow if it is being added as a child of an element that does.
(WebCore::RenderObject::styleDidChange): Mark the child being added as having an SVG shadow if its new style has a shadow.

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::layout): Cache the repaint rect before intersecting it with the shadow.

  • rendering/svg/RenderSVGImage.h:

(WebCore::RenderSVGImage::repaintRectInLocalCoordinatesExcludingSVGShadow): Return the cached repaint rect for the renderer without the shadow included.

  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::RenderSVGModelObject): Renderers do not have a shadow by default.

  • rendering/svg/RenderSVGModelObject.h:

(WebCore::RenderSVGModelObject::repaintRectInLocalCoordinatesExcludingSVGShadow): Return the cached repaint rect for the renderer without the shadow included.
(WebCore::RenderSVGModelObject::hasSVGShadow): Return whether or not the renderer has a shadow.
(WebCore::RenderSVGModelObject::setHasSVGShadow): Set whether or not the renderer has a shadow.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::RenderSVGRoot):
(WebCore::RenderSVGRoot::computeFloatRectForRepaint): Apply the shadow before clipping to the viewport, so we draw shadows for elements outside the viewport.
(WebCore::RenderSVGRoot::updateCachedBoundaries): Cache the repaint rect before intersecting it with the shadow.

  • rendering/svg/RenderSVGRoot.h:

(WebCore::RenderSVGRoot::hasSVGShadow): Return whether or not the renderer has a shadow.
(WebCore::RenderSVGRoot::setHasSVGShadow): Set whether or not the renderer has a shadow.
(WebCore::RenderSVGRoot::repaintRectInLocalCoordinatesExcludingSVGShadow): Return the cached repaint rect for the renderer without the shadow included.

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::updateRepaintBoundingBox): Cache the repaint rect before intersecting it with the shadow.

  • rendering/svg/RenderSVGShape.h:

(WebCore::RenderSVGShape::repaintRectInLocalCoordinatesExcludingSVGShadow): Return the cached repaint rect for the renderer without the shadow included.

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::repaintRectForRendererInLocalCoordinatesExcludingSVGShadow): Return the cached repaint rect for the renderer without the shadow included.
(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint): Apply shadows as we walk through our parents, instead of only applying the renderer's own shadow.
(WebCore::SVGRenderSupport::rendererHasSVGShadow): Return whether or not the renderer has a shadow.
(WebCore::SVGRenderSupport::setRendererHasSVGShadow): Set whether or not the renderer has a shadow.
(WebCore::SVGRenderSupport::intersectRepaintRectWithShadows): Walk through the element's parents, adding shadows to the repaint rect as we go, eventually
transforming the repaint rect back into local coordinates.
(WebCore::SVGRenderSupport::intersectRepaintRectWithResources): Don't add shadows by default, just other resources, so that we can cache repaint rects with and without shadows.

  • rendering/svg/SVGRenderSupport.h:
  • platform/chromium/TestExpectations: Mark tests as needing rebaseline.
  • platform/efl/TestExpectations: Mark tests as needing rebaseline.
  • platform/gtk/TestExpectations: Mark tests as needing rebaseline.
  • platform/qt/TestExpectations: Mark tests as needing rebaseline.
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.txt:
  • platform/mac/svg/css/arrow-with-shadow-expected.txt:
  • platform/mac/svg/css/clippath-with-shadow-expected.txt:
  • platform/mac/svg/css/composite-shadow-example-expected.txt:
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:
  • platform/mac/svg/css/group-with-shadow-expected.txt:
  • platform/mac/svg/css/shadow-changes-expected.txt:
  • platform/mac/svg/custom/simple-text-double-shadow-expected.txt:

Rebaseline Mac results due to this change.

  • svg/css/parent-shadow-offscreen-expected.svg: Added.
  • svg/css/parent-shadow-offscreen.svg: Added.

Add a new test that ensures that <g> with -webkit-svg-shadow applied draws when children are offscreen but the shadow is not.

  • svg/css/root-shadow-offscreen-expected.svg: Added.
  • svg/css/root-shadow-offscreen.svg: Added.

Add a new test that ensures that <svg> with -webkit-svg-shadow applied draws when children are offscreen but the shadow is not.

  • platform/mac/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
  • svg/repaint/repaint-webkit-svg-shadow-expected.txt: Added.
  • svg/repaint/repaint-webkit-svg-shadow.svg: Added.

Add a new test that ensures that SVG elements with -webkit-svg-shadow are correctly invalidated.

6:52 PM Changeset in webkit [133833] by andersca@apple.com
  • 9 edits
    2 copies in trunk/Source

Add RemoteGraphicsLayer class
https://bugs.webkit.org/show_bug.cgi?id=101535

Reviewed by Simon Fraser.

Source/WebCore:

  • WebCore.exp.in:

Export GraphicsLayer symbols required by WebKit2.

  • WebCore.xcodeproj/project.pbxproj:

Make GraphicsLayerFactory.h a private header.

Source/WebKit2:

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
  • WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:

Add RemoteGraphicsLayer, a subclass of WebCore::GraphicsLayer.

  • WebProcess/WebPage/mac/RemoteLayerTreeController.h:

Make RemoteLayerTreeController a GraphicsLayerFactory.

  • WebProcess/WebPage/mac/RemoteLayerTreeController.mm:

(WebKit::RemoteLayerTreeController::createGraphicsLayer):
Create a new RemoteGraphicsLayer.

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::graphicsLayerFactory):
Return the layer tree controller.

6:52 PM Changeset in webkit [133832] by roger_fong@apple.com
  • 30 edits in trunk

Enable Subpixel Layout on Windows. Rebaseline any failing tests that were rebaselined in r133351.
https://bugs.webkit.org/show_bug.cgi?id=101538

Rubberstamped by Tim Horton.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • platform/win/css1/font_properties/font-expected.txt:
  • platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/win/editing/selection/caret-ltr-right-expected.txt:
  • platform/win/editing/selection/caret-rtl-2-left-expected.txt:
  • platform/win/editing/selection/caret-rtl-right-expected.txt:
  • platform/win/editing/selection/mixed-editability-10-expected.txt:
  • platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
  • platform/win/fast/borders/bidi-012-expected.txt:
  • platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt:
  • platform/win/fast/forms/file/file-input-disabled-expected.txt:
  • platform/win/fast/inline/inline-box-background-expected.txt:
  • platform/win/fast/inline/inline-box-background-long-image-expected.txt:
  • platform/win/fast/inline/inline-box-background-repeat-x-expected.txt:
  • platform/win/fast/inline/inline-box-background-repeat-y-expected.txt:
  • platform/win/fast/lists/003-vertical-expected.txt:
  • platform/win/fast/text/international/vertical-text-glyph-test-expected.txt:
  • platform/win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/win/transforms/2d/hindi-rotated-expected.txt:
5:41 PM Changeset in webkit [133831] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=101408

Reviewed by Kent Tamura.

Mistake with timezone was making this test flaky.

  • platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
5:39 PM Changeset in webkit [133830] by dpranke@chromium.org
  • 744 edits
    742 copies
    17 adds in trunk/LayoutTests

Unreviewed, new chromium-mac-mountainlion baselines for css3/selectors3.

5:29 PM Changeset in webkit [133829] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

[V8] Don't leak <img> elements in content scripts
https://bugs.webkit.org/show_bug.cgi?id=101525

Reviewed by Ojan Vafai.

I found the leak that was causing a problem for bug 101110. We weren't
filling in the derefObjectFunction for HTMLImageElements (and
potentially some other types of elements). That manifests today as a
memory leak in content scripts (which use the derefObjectFunction for
nodes) and caused a memory leak after bug 101110 because we started
using the derefObjectFunction in the main world as well.

This patch adds ASSERTs so that we won't make this mistake in the future.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNamedConstructorCallback):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::weakCallback):

  • bindings/v8/DOMWrapperMap.h:

(WebCore::DOMWrapperMap::defaultWeakCallback):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore):

5:29 PM Changeset in webkit [133828] by commit-queue@webkit.org
  • 21 edits
    1 move
    1 add
    1 delete in trunk/Source/WebKit2

[WK2] Make WebVibrationProxy to be a member of WebPageProxy.
https://bugs.webkit.org/show_bug.cgi?id=100334

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-11-07
Reviewed by Anders Carlsson.

WebVibrationProxy should be a member of WebPageProxy, because the IPC
messages of WebVibrationProxy have page destination ID.

The r132386 proposed a way to add/delete message receivers that can
handle IPC messages with destination ID.

Previous implementation that creating WebVibrationProxy as a WebContext
member and using the global message receiver for the proxy can make
assertions after r132386.

To handle the vibration IPC messages properly, this patch will do the
followings.

1) Instead of WebContext, WebPageProxy will have the WebVibrationProxy.

2) WebVibrationProxy will add itself to the message receiver map of

the WebContext with page destination ID.

3) When WebProcessProxy received vibration ipc messages, it will

forward the messages to the WebContext first. Then the message
receiver map of the WebContext will handle the messages with the
registered WebVibrationProxy.

4) APIs will be modified to apply these changes.

a) WK API to get WKVibrationRef will use WKPageRef not WKContextRef.
b) EFL APIs and API test for the vibration will also be changed.

  • EwkViewImpl will have vibration client. (EwkContext will not have it)
  • Previous API to register the vibration callback will be removed.
  • New signals for vibration will be added to the EwkViewImpl.
  • VibrationProxy will be renamed to VibrationClient for the consistency with other clients in EwkViewImpl.
  • VibrationClient will use EwkViewImpl instead of EwkContext.
  • Previous API test for vibration will be moved from context test to view test, and it will use the changed API.
  • PlatformEfl.cmake:
  • UIProcess/API/C/WKContext.cpp:
  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageGetVibration):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/efl/EwkViewCallbacks.h:

(EwkViewCallbacks):

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl):

  • UIProcess/API/efl/EwkViewImpl.h:

(WebKit):
(EwkViewImpl):

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::EwkContext):

  • UIProcess/API/efl/ewk_context.h:
  • UIProcess/API/efl/ewk_context_private.h:

(WebKit):
(EwkContext):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/tests/test_ewk2_context.cpp:
  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(VibrationCbData):
(onVibrate):
(onCancelVibration):
(loadVibrationHTMLString):
(TEST_F):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::disconnectProcess):

  • UIProcess/WebContext.h:

(WebKit):
(WebContext):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):

  • UIProcess/WebPageProxy.h:

(WebKit):
(WebPageProxy):
(WebKit::WebPageProxy::vibration):

  • UIProcess/WebVibrationProxy.cpp:

(WebKit::WebVibrationProxy::create):
(WebKit::WebVibrationProxy::WebVibrationProxy):
(WebKit::WebVibrationProxy::~WebVibrationProxy):
(WebKit::WebVibrationProxy::invalidate):

  • UIProcess/WebVibrationProxy.h:

(WebKit):
(WebVibrationProxy):

  • UIProcess/efl/VibrationClientEfl.cpp: Renamed from Source/WebKit2/UIProcess/efl/VibrationProvider.cpp.

(toVibrationClient):
(VibrationClientEfl::vibrateCallback):
(VibrationClientEfl::cancelVibrationCallback):
(VibrationClientEfl::create):
(VibrationClientEfl::VibrationClientEfl):
(VibrationClientEfl::~VibrationClientEfl):

  • UIProcess/efl/VibrationClientEfl.h: Renamed from Source/WebKit2/UIProcess/efl/VibrationProvider.h.

(WebKit):
(VibrationClientEfl):

5:26 PM Changeset in webkit [133827] by andersca@apple.com
  • 4 edits
    2 copies in trunk/Source/WebKit2

Add empty RemoteLayerTree class
https://bugs.webkit.org/show_bug.cgi?id=101524

Reviewed by Simon Fraser.

Add a new RemoteLayerTree class which will contain the remote graphics layers.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/mac/RemoteLayerTree.h: Added.
  • WebProcess/WebPage/mac/RemoteLayerTree.mm: Added.
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:

(RemoteLayerTreeDrawingArea):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):

5:18 PM Changeset in webkit [133826] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

5:16 PM Changeset in webkit [133825] by alecflett@chromium.org
  • 5 edits
    1 move in trunk/Source/WebCore

IndexedDB: Prepare for IDBBackingStore merge by renaming IDBLevelDBBackingStore.cpp
https://bugs.webkit.org/show_bug.cgi?id=101486

Reviewed by Ojan Vafai.

Rename IDBLevelDBBackingStore.cpp to IDBBackingStore.cpp in
preparation for merging these classes. This will make the merge
diffs sane. See https://bugs.webkit.org/show_bug.cgi?id=101415
for the final goal.

No new tests, this is is just a rename and minor style fix.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/indexeddb/IDBBackingStore.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp.
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
5:13 PM Changeset in webkit [133824] by Lucas Forschler
  • 1 copy in tags/Safari-537.18

New Tag.

4:56 PM Changeset in webkit [133823] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Prepare DOMDataStore to be able to store ScriptWrappable wrappers inline
https://bugs.webkit.org/show_bug.cgi?id=101523

Unreviewed. Technically this patch hasn't been reviewed, but it is part
of a patch that was reviewed by Kentaro Hara.

Sadly, my patch for bug 101110 triggered the regression again. This
patch is a smaller incremental step towards the patch in bug 101110. It
doesn't make that much sense on its own, but it will help me isolate
the source of the regression.

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::get):
(DOMDataStore):
(WebCore::DOMDataStore::set):
(WebCore::DOMDataStore::wrapperIsStoredInObject):
(WebCore::DOMDataStore::getWrapperFromObject):
(WebCore::DOMDataStore::setWrapperInObject):

4:52 PM Changeset in webkit [133822] by dpranke@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

Unreviewed, fix mistakenly added pngs for failing compositing ref tests :(.

  • platform/chromium-mac/compositing/text-on-scaled-layer-expected.png: Removed.
  • platform/chromium-mac/compositing/text-on-scaled-surface-expected.png: Removed.
  • platform/chromium/TestExpectations:
4:36 PM Changeset in webkit [133821] by dpranke@chromium.org
  • 9 edits
    7 copies
    2 adds in trunk/LayoutTests

Unreviewed, clean up chromium-mac-mountainlion for remaining compositing, css3 (non selectors3) tests.

  • platform/chromium-mac-lion/css3/css3-modsel-33-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/css3-modsel-33-expected.png.
  • platform/chromium-mac-lion/css3/css3-modsel-35-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/css3-modsel-35-expected.png.
  • platform/chromium-mac-lion/css3/css3-modsel-36-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/css3-modsel-36-expected.png.
  • platform/chromium-mac-lion/css3/css3-modsel-37-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/css3-modsel-37-expected.png.
  • platform/chromium-mac-lion/css3/flexbox/repaint-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/flexbox/repaint-expected.png.
  • platform/chromium-mac-lion/css3/font-feature-settings-rendering-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/font-feature-settings-rendering-expected.png.
  • platform/chromium-mac-lion/css3/unicode-bidi-isolate-basic-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png.
  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium-mac/compositing/text-on-scaled-layer-expected.png: Added.
  • platform/chromium-mac/compositing/text-on-scaled-surface-expected.png: Added.
  • platform/chromium-mac/css3/css3-modsel-33-expected.png:
  • platform/chromium-mac/css3/css3-modsel-35-expected.png:
  • platform/chromium-mac/css3/css3-modsel-36-expected.png:
  • platform/chromium-mac/css3/css3-modsel-37-expected.png:
  • platform/chromium-mac/css3/flexbox/repaint-expected.png:
  • platform/chromium-mac/css3/font-feature-settings-rendering-expected.png:
  • platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png:
4:35 PM Changeset in webkit [133820] by rniwa@webkit.org
  • 17 edits in trunk/Source/WebCore

SimplifyMarkupCommand takes a disproportionally long time to run when there are many nodes to remove
https://bugs.webkit.org/show_bug.cgi?id=101144

Reviewed by Enrica Casucci.

The bug was caused by attach() happening between each node removal. Since the command was trying
to remove millions of node in some cases, attach()ing render objects for each node being reinserted
imposed a huge runtime cost.

Fixed the bug by using lazy attach when removing nodes and avoiding calls to isContentEditable.
Also remove all ancestors at once when they are direct child/parent of each other so that we don't
remove an ancestor and then insert its child back only to remove it again in the next iteration.

No new tests since it doesn't change the asymptotic performance, and adding a new performance test for
this specific case is not the worth the increase in the bot cycle time. I'll note that the email
attached in the original radar bug (<rdar://problem/12179712>) took 100 seconds to open now only takes
7 seconds to open on my MacPro.

  • editing/AppendNodeCommand.cpp:

(WebCore::AppendNodeCommand::doApply): Takes a flag indicating whether we should assume nodes are editable
without calling isContentEditable or not.

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Update the style as later code requires render
object.

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::insertNodeBefore): Passes a flag to the command.
(WebCore::CompositeEditCommand::removeNode): Ditto.
(WebCore::CompositeEditCommand::removeNodePreservingChildren): Ditto.

  • editing/CompositeEditCommand.h:

(CompositeEditCommand):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::removeNode): Takes a flag indicating whether we should assume nodes are
editable without calling isContentEditable or not.

  • editing/DeleteSelectionCommand.h:

(DeleteSelectionCommand):

  • editing/EditCommand.h:
  • editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::doApply): Update the layout when password echo is enabled since
we need to have render objects for echoing.

  • editing/InsertNodeBeforeCommand.cpp:

(WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): Ditto.
(WebCore::InsertNodeBeforeCommand::doApply): Ditto; also always use lazy attach.
(WebCore::InsertNodeBeforeCommand::doUnapply):

  • editing/InsertNodeBeforeCommand.h:

(WebCore::InsertNodeBeforeCommand::create):
(InsertNodeBeforeCommand):

  • editing/RemoveNodeCommand.cpp:

(WebCore::RemoveNodeCommand::RemoveNodeCommand): Ditto about the flag.
(WebCore::RemoveNodeCommand::doApply):

  • editing/RemoveNodeCommand.h:

(WebCore::RemoveNodeCommand::create):
(RemoveNodeCommand):

  • editing/RemoveNodePreservingChildrenCommand.cpp:

(WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand): Ditto.
(WebCore::RemoveNodePreservingChildrenCommand::doApply):

  • editing/RemoveNodePreservingChildrenCommand.h:

(WebCore::RemoveNodePreservingChildrenCommand::create):
(RemoveNodePreservingChildrenCommand):

  • editing/SimplifyMarkupCommand.cpp:

(WebCore::SimplifyMarkupCommand::doApply):
(WebCore::SimplifyMarkupCommand::pruneSubsequentAncestorsToRemove): Added to optimize removals of multiple
ancestors.

  • editing/SimplifyMarkupCommand.h:

(SimplifyMarkupCommand):

4:22 PM Changeset in webkit [133819] by dpranke@chromium.org
  • 3 edits
    1 delete in trunk/LayoutTests

Unreviewed, chromium expectations cleanup

Remove entries for a couple of passing tests and one stale pixel
result for a reftest.

  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium-mac/fast/sub-pixel/float-wrap-zoom-expected.png: Removed.
  • platform/chromium/TestExpectations:
4:20 PM Changeset in webkit [133818] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r133810.
http://trac.webkit.org/changeset/133810
https://bugs.webkit.org/show_bug.cgi?id=101520

This patch made ws_single_peak_r regress by 15% (Requested by
abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-07

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::weakCallback):

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::get):
(WebCore::DOMDataStore::set):
(DOMDataStore):

4:14 PM Changeset in webkit [133817] by dpranke@chromium.org
  • 3 edits
    8 deletes in trunk/LayoutTests

Unreviewed, update chromium-mac-ml expectations after r133811 and r133814.

  • platform/chromium-mac-mountainlion/TestExpectations:
  • platform/chromium-mac/css2.1/20110323/border-conflict-element-001d-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/overflow-applies-to-007-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/overflow-applies-to-010-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/overflow-applies-to-012-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/overflow-applies-to-013-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/overflow-applies-to-014-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/overflow-applies-to-015-expected.png: Removed.
  • platform/chromium-mac/css2.1/20110323/text-indent-014-expected.png: Removed.
  • platform/chromium/TestExpectations:
4:11 PM Changeset in webkit [133816] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Remove exif-orientation-image-document.html from failure list
https://bugs.webkit.org/show_bug.cgi?id=101518

Unreviewed gardening.

fast/images/exif-orientation-image-document.html passes after r133728

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-07

  • platform/efl-wk1/TestExpectations:
4:09 PM Changeset in webkit [133815] by pdr@google.com
  • 10 edits
    2 adds in trunk/LayoutTests

Rebaselinene after external SVG unblocked in WK100485
https://bugs.webkit.org/show_bug.cgi?id=101248

Unreviewed update of test expectations.

  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added property svn:mime-type.
  • platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added property svn:mime-type.
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added property svn:mime-type.
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added property svn:mime-type.
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added property svn:mime-type.
  • platform/chromium/TestExpectations:
3:48 PM Changeset in webkit [133814] by dpranke@chromium.org
  • 476 edits
    475 copies
    4 adds in trunk/LayoutTests

Unreviewed, update chromium-mac-mountainlion baselines for css2.1

3:37 PM Changeset in webkit [133813] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Clean up confused use of Document::renderer and renderView
https://bugs.webkit.org/show_bug.cgi?id=101484

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-07
Reviewed by Ojan Vafai.

Document::renderer and Document::renderView are the same thing, but it seems
people don't always realize it and check if document()->renderer() is a RenderView.

This patch cleans up usage of document()->renderer() and document()->renderView() and
simplifies the code that was written without realizing they were the same thing.

No new tests, this is just a refactor.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::visiblePositionForPoint): Lots of simplification.

  • dom/Element.cpp:

(WebCore::Element::screenRect):
(WebCore::Element::unregisterNamedFlowContentNode): Remove unneeded conditional.

  • editing/FrameSelection.cpp: Remove verbose casts.

(WebCore::clearRenderViewSelection):
(WebCore::FrameSelection::recomputeCaretRect):
(WebCore::CaretBase::invalidateCaretRect):
(WebCore::FrameSelection::focusedOrActiveStateChanged):

  • page/Frame.cpp:

(WebCore::Frame::contentRenderer): Vastly simplified.

  • page/PrintContext.cpp: Remove verbose casts.

(WebCore::PrintContext::computePageRects):
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):

  • page/wince/FrameWinCE.cpp:

(WebCore::computePageRectsForFrame): Remove unreachable code.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::maximalOutlineSize): Remove verbose cast.

3:34 PM Changeset in webkit [133812] by mhahnenberg@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

WeakBlocks should be HeapBlocks
https://bugs.webkit.org/show_bug.cgi?id=101411

Reviewed by Oliver Hunt.

Currently WeakBlocks use fastMalloc memory. They are very similar to the other HeapBlocks, however,
so we should change them to being allocated with the BlockAllocator.

  • heap/BlockAllocator.cpp:

(JSC::BlockAllocator::BlockAllocator):

  • heap/BlockAllocator.h: Added a new RegionSet for WeakBlocks.

(JSC):
(BlockAllocator):
(JSC::WeakBlock):

  • heap/Heap.h: Friended WeakSet to allow access to the BlockAllocator.

(Heap):

  • heap/WeakBlock.cpp:

(JSC::WeakBlock::create): Refactored to use HeapBlocks rather than fastMalloc.
(JSC::WeakBlock::WeakBlock):

  • heap/WeakBlock.h: Changed the WeakBlock size to 4 KB so that it divides evenly into the Region size.

(JSC):
(WeakBlock):

  • heap/WeakSet.cpp:

(JSC::WeakSet::~WeakSet):
(JSC::WeakSet::addAllocator):

3:25 PM Changeset in webkit [133811] by dpranke@chromium.org
  • 256 edits
    255 copies
    9 adds in trunk/LayoutTests

Unreviewed, update chromium-mac-mountainlion baselines for css2.1/2011/0323

3:11 PM Changeset in webkit [133810] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

[V8] IntrusiveDOMWrapperMap should be usable for more than just Nodes
https://bugs.webkit.org/show_bug.cgi?id=101110

Reviewed by Kentaro Hara.

This patch generalizes our support for storing wrappers in DOM objects
to be usable for more than just nodes. After this patch, any object
with a ScriptWrappable base class will have its wrapper stored inline
in the object in the main world.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::weakCallback):

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::get):
(WebCore::DOMDataStore::set):

3:01 PM Changeset in webkit [133809] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
2:48 PM Changeset in webkit [133808] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Update BB10 form theme.
https://bugs.webkit.org/show_bug.cgi?id=100760

Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-07
Reviewed by Rob Buis.

RIM PR 236997
Internally Reviewed by Jakob Petsovits.

Set font family to fix DRT test fast/forms/input-type-text-min-width.html

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::defaultGUIFont):
(WebCore):
(WebCore::RenderThemeBlackBerry::systemFont):

2:27 PM Changeset in webkit [133807] by Beth Dakin
  • 9 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=101303
Fixed position elements that are out of view still end up forcing
non-threaded scrolling
-and corresponding-
<rdar://problem/12642222>

Reviewed by Simon Fraser.

Source/WebCore:

Re-name hasNonLayerFixedObjects() to
hasVisibleSlowRepaintFixedObjects() and make it virtual.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::hasVisibleSlowRepaintFixedObjects):
(WebCore::ScrollingCoordinator::mainThreadScrollingReasons):

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

Override hasVisibleSlowRepaintFixedObjects() to always return false.
We don't want to bother with the extra computation in the
ScrollingCoordinator implementation, though other ports might still
want it.

  • page/scrolling/mac/ScrollingCoordinatorMac.h:

(WebCore::ScrollingCoordinatorMac::hasVisibleSlowRepaintFixedObjects):
(ScrollingCoordinatorMac):

Make this function const so that we can call it from
requiresCompositingForPosition().

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::calculateCompositedBounds):

Actually be thorough here and check if the fixed object has any
descendants that are visible in the view. If it does, then we do
want to composite the fixed object.
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

  • rendering/RenderLayerCompositor.h:

LayoutTests:

New tests for an invisible fixed object that has visible children.

  • compositing/absolute-inside-out-of-view-fixed-expected.txt: Added.
  • compositing/absolute-inside-out-of-view-fixed.html: Added.
  • platform/mac/tiled-drawing/fixed/absolute-inside-out-of-view-fixed-expected.txt: Added.
  • platform/mac/tiled-drawing/fixed/absolute-inside-out-of-view-fixed.html: Added.

Updated results because these tests can now scroll on the scrolling
thread, yay!

  • platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-expected.txt:
  • platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex-expected.txt:
1:58 PM Changeset in webkit [133806] by roger_fong@apple.com
  • 3 edits in trunk/Source/WebCore

Unreviewed. Style fix following r133262.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::clearMediaPlayer):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

1:45 PM Changeset in webkit [133805] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

[V8] DOMWrapperMap doesn't need to use virtual functions
https://bugs.webkit.org/show_bug.cgi?id=101494

Reviewed by Kentaro Hara.

DOMWrapperMap has only one subclass. There's no reason to use virtual functions.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):

  • bindings/v8/DOMWrapperMap.h:

(WebCore::DOMWrapperMap::DOMWrapperMap):
(WebCore::DOMWrapperMap::get):
(WebCore::DOMWrapperMap::set):
(WebCore::DOMWrapperMap::clear):
(WebCore::DOMWrapperMap::reportMemoryUsage):
(WebCore::DOMWrapperMap::remove):
(WebCore::DOMWrapperMap::defaultWeakCallback):

  • bindings/v8/V8NPObject.cpp:

(WebCore::staticNPObjectMap):

1:42 PM Changeset in webkit [133804] by dpranke@chromium.org
  • 2 edits in trunk/Tools

garden-o-matic should handle concurrent requests
https://bugs.webkit.org/show_bug.cgi?id=101407

Reviewed by Ojan Vafai.

Garden-o-Matic is implemented on top of the BaseHttpServer
python library, which implements a single-threaded (one request at
a time) server. This means that we can only rebaseline one test at
a time, and when using a local results file, even fetching the results
for diffs is single-threaded.

Mixing in the ThreadingMixin enables concurrent requests (subject
to the global python interpreter lock). Given that we're doing all
of the work in webkit-patch subprocesses, I think this is safe.

Of course, it may not be safe to do some of the subprocesses in
parallel (e.g., rollout), but I think as long as we don't issue
commands that touch overlapping sets of files things should be fine.
The file locking over modifying testexpectations should keep that
from being corrupted.

  • Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningHTTPServer):
(GardeningHTTPRequestHandler):

1:30 PM Changeset in webkit [133803] by Alexandru Chiculita
  • 7 edits in trunk/Source/WebCore

[CSS Shaders] Remove the dependency on CustomFilterValidatedProgram from CustomFilterRenderer
https://bugs.webkit.org/show_bug.cgi?id=101071

Reviewed by Dean Jackson.

I've removed the need to get a CustomFilterValidatedProgram from FilterEffectRenderer. It was only
used to delay the compilation of the shader until it was really needed. Instead, the FilterEffectRenderer
will directly get the compiled shader in the constructor. The callers that still want to avoid
compiling the shader until it is really needed can use the setCompiledProgram to inject the shader
at a later time, before painting.

No new tests, the change is covered by the css3/filters/custom/ tests.

  • platform/graphics/filters/CustomFilterConstants.h:
  • platform/graphics/filters/CustomFilterProgramInfo.h:
  • platform/graphics/filters/CustomFilterRenderer.cpp:

(WebCore::CustomFilterRenderer::create):
(WebCore::CustomFilterRenderer::CustomFilterRenderer):
(WebCore::CustomFilterRenderer::premultipliedAlpha):
(WebCore::CustomFilterRenderer::setCompiledProgram):
(WebCore):
(WebCore::CustomFilterRenderer::prepareForDrawing):
(WebCore::CustomFilterRenderer::bindProgramAndBuffers):

  • platform/graphics/filters/CustomFilterRenderer.h:

(WebCore):
(CustomFilterRenderer):
(WebCore::CustomFilterRenderer::compiledProgram):

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::prepareForDrawing):

  • platform/graphics/filters/FECustomFilter.h:

(FECustomFilter):

1:30 PM Changeset in webkit [133802] by rwlbuis@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove setUserStyleSheetString/userStyleSheetString
https://bugs.webkit.org/show_bug.cgi?id=101490

Reviewed by Yong Li.

We no longer need this API.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

  • Api/WebSettings.cpp:

(WebKit):

  • Api/WebSettings.h:
1:24 PM Changeset in webkit [133801] by pdr@google.com
  • 2 edits
    1 delete in trunk/LayoutTests

Update expectations for svg/text/text-rescale.svg

Unreviewed update of test expectations.

This test needed a rebaseline after r133786.

  • platform/chromium-win/svg/text/text-rescale-expected.png:
  • platform/efl/svg/text/text-rescale-expected.png: Removed.
1:15 PM Changeset in webkit [133800] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Indentation of ArgList.h is wrong
https://bugs.webkit.org/show_bug.cgi?id=101441

Reviewed by Andreas Kling.

Just unindented by 4 spaces.

  • runtime/ArgList.h:
1:10 PM Changeset in webkit [133799] by commit-queue@webkit.org
  • 5 edits in trunk

Remove build-webkit dependency on Java SDK for Apple Mac WebKit.
<http://webkit.org/b/101492>

Patch by Andreas Kling <akling@apple.com> on 2012-11-07
Reviewed by Anders Carlsson.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj: Remove WebJavaPlugIn.h

Source/WebKit/mac:

  • Plugins/WebJavaPlugIn.h: Removed.

Tools:

Don't check for a Java SDK before building the Apple Mac port. It's no longer needed for
the build after the Java bridge was removed.

  • Scripts/build-webkit:

(cMakeArgsFromFeatures):

1:08 PM Changeset in webkit [133798] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL][WK2] Allow client to override setWindowFrame() / getWindowFrame()
https://bugs.webkit.org/show_bug.cgi?id=101496

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add window_geometry_set() / window_geometry_get() smart functions to
ewk_view allowing the client to provide its own implementation for
those.

This is particularly useful if the application uses elm_win because
the default implementation will not behave correctly in this case.
This is due to the fact that the default implementation interacts
with the Ecore_Evas that contains the view and is not aware of the
parent window widget.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::windowGeometry):
(EwkViewImpl::setWindowGeometry):

  • UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::getWindowFrame):
(WebKit::PageUIClientEfl::setWindowFrame):

Tools:

Provide implementation for on_window_geometry_get() / on_window_geometry_set()
smart functions that interact with the elm_win widget.

  • MiniBrowser/efl/main.c:

(on_window_geometry_get):
(on_window_geometry_set):
(window_create):

12:54 PM Changeset in webkit [133797] by Luciano Miguel Wolf
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Adding myself to commiters.py.

12:47 PM Changeset in webkit [133796] by hans@chromium.org
  • 2 edits in trunk/Source/WTF

Fix asm operand type for weakCompareAndSwap on ARM_THUMB2
https://bugs.webkit.org/show_bug.cgi?id=101238

Reviewed by Benjamin Poulain.

'result' was a bool, but the asm was expecting a 32-bit register. A
recent version of Clang warned about this:

WebKit/Source/WTF/wtf/Atomics.h:163:34: error: the size being stored
is truncated, use a modifier to specify the size [-Werror,-Wasm-operand-widths]

This patch fixes it by making 'result' an unsigned. It does not change
the functionality in practice ('result' would be in a 32-bit register
anyway), but it makes the code more correct and makes the warning go
away.

Also make 'result' for the X86 version an 'unsigned char' to make it
more clear that it is a byte.

  • wtf/Atomics.h:

(WTF::weakCompareAndSwap):

12:41 PM Changeset in webkit [133795] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2][AC] API tests crash
https://bugs.webkit.org/show_bug.cgi?id=101480

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

When AC is enabled, 8 API tests are crashing. We need to properly set the evas engine for these tests.

  • TestWebKitAPI/efl/PlatformWebView.cpp:

(TestWebKitAPI::initEcoreEvas):

12:39 PM Changeset in webkit [133794] by abarth@webkit.org
  • 5 edits
    1 delete in trunk/Source/WebCore

[V8] IntrusiveDOMWrapperMap is no longer needed and can be deleted
https://bugs.webkit.org/show_bug.cgi?id=101493

Reviewed by Kentaro Hara.

This patch is another incremental step towards landing the patch in bug

  1. In this patch, we delete IntrusiveDOMWrapperMap, which is no

longer needed.

  • WebCore.gypi:
  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::~DOMDataStore):
(WebCore::DOMDataStore::reportMemoryUsage):
(WebCore::DOMDataStore::weakCallback):
(WebCore):

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::get):
(WebCore::DOMDataStore::set):
(DOMDataStore):

  • bindings/v8/IntrusiveDOMWrapperMap.h: Removed.
  • bindings/v8/V8GCController.cpp:
12:35 PM Changeset in webkit [133793] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Function adoptNS and adoptCF should not generate memory leak diagnostic with Clang Static Analyzer.
https://bugs.webkit.org/show_bug.cgi?id=101420

Patch by Remy Demarest <rdemarest@apple.com> on 2012-11-07
Reviewed by Benjamin Poulain.

Add attributes to the adoptNS and adoptCF function arguments to remove Clang Static Analyzer diagnotics.
Define CF_RELEASES_ARGUMENT and NS_RELEASES_ARGUMENT if not available, use them in function declarations.

  • wtf/RetainPtr.h:

(WTF::adoptCF): Adds CF_RELEASES_ARGUMENT attribute to the argument.
(WTF::adoptNS): Adds NS_RELEASES_ARGUMENT attribute to the argument.

12:34 PM Changeset in webkit [133792] by lauro.neto@openbossa.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Adding myself to commiters.py.

12:32 PM Changeset in webkit [133791] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[AC] glXChooseFBConfig() and glXGetVisualFromFBConfig() return values are leaking in GraphicsSurface
https://bugs.webkit.org/show_bug.cgi?id=101475

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

Free the memory returned by glXChooseFBConfig and glXGetVisualFromFBConfig
using XFree to avoid memory leaks.

No tests. No change in behavior.

  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):

12:10 PM Changeset in webkit [133790] by fsamuel@chromium.org
  • 4 edits in trunk/Source/WebCore

Autoresize should work even if turned on while the page is loading.
https://bugs.webkit.org/show_bug.cgi?id=101380

Reviewed by David Levin.

Autoresize does not work in cases where it is turned on while loading.
This patch addresses this by allowing autoSize to complete if it's turned on
while loading and doing a final pass after loading.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkCompleted):
Adjust to call renamed function.

  • page/FrameView.cpp:

(WebCore::FrameView::handleLoadCompleted):
Rename function to encompass its expanded responsibilities (which include doing the final auto size after the load is completed).
(WebCore::FrameView::autoSizeIfEnabled):
Allow the size to shrink if autosize is adjusted while the page is loading.

  • page/FrameView.h:

(FrameView):
Renamed 'checkFlushDeferredRepaintsAfterLoadComplete' to 'handleLoadComplete'

11:49 AM Changeset in webkit [133789] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Open link in this window action
https://bugs.webkit.org/show_bug.cgi?id=101226

Patch by Allan Sandfeld Jensen <allan.jensen@digia.com> on 2012-11-07
Reviewed by Csaba Osztrogonác.

  • Api/qwebpage.cpp: Fix after r133763, move the initialization of OpenLinkInThisWindow to the proper place.
11:35 AM Changeset in webkit [133788] by eae@chromium.org
  • 2 edits in trunk/Source/WebKit/efl

Unreviewed EFL build fix.

  • ewk/ewk_view.cpp:
11:31 AM Changeset in webkit [133787] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

Add API for touchEventHandlerRegion to WebLayer
https://bugs.webkit.org/show_bug.cgi?id=101406

Patch by Yusuf Ozuysal <yusufo@google.com> on 2012-11-07
Reviewed by James Robinson.

These will be used to keep track of JavaScript touch event handlers from the compositor thread.

  • chromium/public/WebLayer.h:

(WebKit::WebLayer::setTouchEventHandlerRegion):
(WebKit::WebLayer::touchEventHandlerRegion):
(WebLayer):

11:26 AM Changeset in webkit [133786] by pdr@google.com
  • 11 edits in trunk

Skip SVG repaint tracking when parent container transforms
https://bugs.webkit.org/show_bug.cgi?id=101177

Reviewed by Eric Seidel.

Source/WebCore:

This patch skips child repaint rect checks when a parent container is transformed, leading
to a 75% increase on the RoboHornet SVG benchmark:

http://www.robohornet.org/#et=svg (average of 2 runs)
Before patch: 161.6ms
After patch: 38.5ms

SVG transforms are relative to the local container which makes calculating an absolute
repaint rect expensive because it requires multiplying the local repaint rect by each
parent container's local transform. See SVGRenderSupport::computeFloatRectForRepaint
as an example of this calculation.

This patch takes advantage of SVG's container rules: when a parent container's transform
changes, all children must be repainted (there is no absolute positioning in SVG).
SVGRenderSupport::checkForSVGRepaintDuringLayout has been added which checks for whether
the parent transform changed before doing child repaint checks. A similar optimization is
used in HTML (see RenderObject::checkForRepaintDuringLayout) where no repaint checking
is done when the view is fully repainted.

This code is tested in existing tests.

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::layout):

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::layout):

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::layout):

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::layout):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::layout):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::checkForSVGRepaintDuringLayout):
(WebCore):

  • rendering/svg/SVGRenderSupport.h:

(SVGRenderSupport):

LayoutTests:

The repaint area in svg/repaint/inner-svg-change-viewBox.svg has
been tightened as a result of this patch.

  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
11:24 AM Changeset in webkit [133785] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: Textfields don't get focus when navigated to from 'show all tabs' button
https://bugs.webkit.org/show_bug.cgi?id=101369

Reviewed by Darin Adler.

When focus leaves a webpage, the webpage does not normally clear its focused node. When focus
returns (through tab, or mouse click), then focus will be cleared and restored.

However, when focus is returned through accessibility means, focus is not cleared first, which
means subsequent focus actions do nothing.

This fix will check if the focused node is the same as the node being focused, and if so, clear the focus first.

Making a layout test for this is not possible because it requires setting focus to something in the chrome, and then
moving focus back to the webpage.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::setFocused):

11:02 AM Changeset in webkit [133784] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Text on scaled layer is blurry
https://bugs.webkit.org/show_bug.cgi?id=101491

Unreviewed gardening.

Mark tests as ImageOnlyFailure.

  • platform/qt-5.0-wk2/TestExpectations:
10:59 AM Changeset in webkit [133783] by abarth@webkit.org
  • 14 edits
    2 deletes in trunk/Source

[V8] We should hide the DOMWrapperMaps inside DOMDataStore
https://bugs.webkit.org/show_bug.cgi?id=101430

Reviewed by Kentaro Hara.

Source/WebCore:

This is yet another incremental step towards landing the patch in bug

  1. In this patch, we hide the existence of DOMWrapperMaps inside

DOMDataStore. In the process, we can remove V8DOMMap.cpp.

  • UseV8.cmake:
  • WebCore.gypi:
  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::set):

  • bindings/v8/DOMWrapperWorld.h:
  • bindings/v8/ScriptProfiler.cpp:
  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::neuterBinding):

  • bindings/v8/V8DOMMap.cpp: Removed.
  • bindings/v8/V8DOMMap.h: Removed.
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):
(WebCore::V8DOMWrapper::setWrapperClass):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):

  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/WorkerContextExecutionProxy.cpp:
  • bindings/v8/WorkerScriptController.cpp:

Source/WebKit/chromium:

Remove unneeded header includes.

  • src/WebScriptController.cpp:
10:53 AM Changeset in webkit [133782] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

Enable text dump in fast/forms/file/get-file-upload.html earlier.
https://bugs.webkit.org/show_bug.cgi?id=101468

Reviewed by Kentaro Hara.

Do not call testRunner.dumpAsText() only when processing the form
submission, since that will not be triggered if a port does not
support, say, beginDragWithFiles(), and a useless pixel result
will be generated in that case.

Instead, call dumpAsText() as early as possible.

  • fast/forms/file/get-file-upload.html:
10:49 AM Changeset in webkit [133781] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

[Qt][ARM] REGRESSION(r133688): It made all JSC and layout tests crash on ARM traditional platform
https://bugs.webkit.org/show_bug.cgi?id=101465

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-11-07
Reviewed by Oliver Hunt.

Fix failing javascriptcore tests on ARM after r133688

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

10:37 AM Changeset in webkit [133780] by commit-queue@webkit.org
  • 9 edits in trunk

Add new gesture type, LongTap, which is basically the completion of a GestureLongPress
https://bugs.webkit.org/show_bug.cgi?id=101385

Patch by Varun Jain <varunjain@chromium.org> on 2012-11-07
Reviewed by Adam Barth.

Test: Only creating the new enum. No functionality change, hence no tests required.

Source/WebCore:

  • platform/PlatformEvent.h:

Source/WebKit/chromium:

  • public/WebInputEvent.h:

(WebKit::WebInputEvent::isGestureEventType):

  • src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::handleInputEvent):

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

10:33 AM Changeset in webkit [133779] by eae@chromium.org
  • 116 edits
    9 moves
    1 add
    3 deletes in trunk/Source

Remove LayoutTypes abstraction
https://bugs.webkit.org/show_bug.cgi?id=93050

Reviewed by Levi Weintraub.

Remove LayoutTypes abstraction and rename FractionalLayout* to
Layout* now that all platforms use the FractionalLayout version
(albeit with different fractions).

No new tests, no change in functionality.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityNodeObject.cpp:
  • accessibility/AccessibilityNodeObject.h:
  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.h:
  • css/LengthFunctions.cpp:
  • css/LengthFunctions.h:
  • dom/Document.h:
  • dom/DocumentMarkerController.h:
  • dom/ElementRareData.h:
  • dom/MouseRelatedEvent.h:
  • dom/Node.h:
  • dom/Touch.h:
  • editing/FrameSelection.cpp:
  • editing/FrameSelection.h:
  • editing/RenderedPosition.h:
  • html/HTMLAreaElement.h:
  • inspector/InspectorOverlay.h:
  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp:
  • inspector/TimelineRecordFactory.h:
  • loader/cache/CachedImage.h:
  • page/FocusController.h:
  • page/FrameView.h:
  • page/Page.h:
  • page/SpatialNavigation.cpp:
  • page/SpatialNavigation.h:
  • platform/FractionalLayoutUnit.h: Removed.
  • platform/LayoutUnit.h: Copied from Source/WebCore/platform/FractionalLayoutUnit.h.
  • platform/Length.h:
  • platform/PopupMenuClient.h:
  • platform/animation/AnimationUtilities.h:
  • platform/graphics/FloatPoint.cpp:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.cpp:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.cpp:
  • platform/graphics/FloatSize.h:
  • platform/graphics/FractionalLayoutBoxExtent.cpp: Removed.
  • platform/graphics/FractionalLayoutBoxExtent.h: Removed.
  • platform/graphics/FractionalLayoutPoint.h: Removed.
  • platform/graphics/FractionalLayoutRect.cpp: Removed.
  • platform/graphics/FractionalLayoutRect.h: Removed.
  • platform/graphics/FractionalLayoutSize.h: Removed.
  • platform/graphics/GraphicsLayer.cpp:
  • platform/graphics/GraphicsLayerAnimation.cpp:
  • platform/graphics/IntRect.cpp:
  • platform/graphics/IntRect.h:
  • platform/graphics/LayoutBoxExtent.cpp: Copied from Source/WebCore/platform/graphics/FractionalLayoutBoxExtent.cpp.
  • platform/graphics/LayoutBoxExtent.h: Copied from Source/WebCore/platform/graphics/FractionalLayoutBoxExtent.h.
  • platform/graphics/LayoutPoint.h: Copied from Source/WebCore/platform/graphics/FractionalLayoutPoint.h.
  • platform/graphics/LayoutRect.cpp: Copied from Source/WebCore/platform/graphics/FractionalLayoutRect.cpp.
  • platform/graphics/LayoutRect.h: Copied from Source/WebCore/platform/graphics/FractionalLayoutRect.h.
  • platform/graphics/LayoutSize.h: Copied from Source/WebCore/platform/graphics/FractionalLayoutSize.h.
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/filters/CustomFilterOperation.h:
  • platform/graphics/filters/CustomFilterParameterList.h:
  • platform/graphics/filters/FilterOperation.h:
  • platform/graphics/filters/FilterOperations.h:
  • platform/graphics/filters/ValidatedCustomFilterOperation.cpp:
  • platform/graphics/filters/ValidatedCustomFilterOperation.h:
  • platform/graphics/qt/FractionalLayoutPointQt.cpp: Removed.
  • platform/graphics/qt/FractionalLayoutRectQt.cpp: Removed.
  • platform/graphics/qt/FractionalLayoutSizeQt.cpp: Removed.
  • platform/graphics/qt/LayoutPointQt.cpp: Copied from Source/WebCore/platform/graphics/qt/FractionalLayoutPointQt.cpp.
  • platform/graphics/qt/LayoutRectQt.cpp: Added.
  • platform/graphics/qt/LayoutSizeQt.cpp: Copied from Source/WebCore/platform/graphics/qt/FractionalLayoutSizeQt.cpp.
  • platform/graphics/transforms/TransformOperations.h:
  • platform/graphics/transforms/TransformState.h:
  • platform/graphics/transforms/TransformationMatrix.cpp:
  • platform/graphics/transforms/TransformationMatrix.h:
  • rendering/AutoTableLayout.h:
  • rendering/ColumnInfo.h:
  • rendering/ExclusionShapeInsideInfo.h:
  • rendering/FilterEffectRenderer.h:
  • rendering/FixedTableLayout.h:
  • rendering/GapRects.h:
  • rendering/HitTestResult.h:
  • rendering/HitTestingTransformState.cpp:
  • rendering/HitTestingTransformState.h:
  • rendering/InlineFlowBox.cpp:
  • rendering/LayoutRepainter.cpp:
  • rendering/LayoutRepainter.h:
  • rendering/LayoutState.h:
  • rendering/LayoutTypes.h:
  • rendering/LayoutTypesInlineMethods.h:
  • rendering/PaintInfo.h:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:
  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp:
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderDeprecatedFlexibleBox.cpp:
  • rendering/RenderFieldset.cpp:
  • rendering/RenderFlexibleBox.cpp:
  • rendering/RenderFlowThread.cpp:
  • rendering/RenderGeometryMap.h:
  • rendering/RenderImageResource.h:
  • rendering/RenderInline.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayerFilterInfo.h:
  • rendering/RenderLineBoxList.cpp:
  • rendering/RenderListMarker.cpp:
  • rendering/RenderMarquee.cpp:
  • rendering/RenderMenuList.h:
  • rendering/RenderMultiColumnBlock.cpp:
  • rendering/RenderMultiColumnSet.cpp:
  • rendering/RenderNamedFlowThread.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderOverflow.h:
  • rendering/RenderRegion.cpp:
  • rendering/RenderReplaced.cpp:
  • rendering/RenderTable.cpp:
  • rendering/RenderTable.h:
  • rendering/RenderText.cpp:
  • rendering/RenderThemeChromiumCommon.cpp:
  • rendering/RenderThemeChromiumCommon.h:
  • rendering/RenderTreeAsText.cpp:
  • rendering/RenderTreeAsText.h:
  • rendering/RenderView.h:
  • rendering/style/NinePieceImage.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/ShadowData.cpp:
  • rendering/style/ShadowData.h:
  • rendering/style/StyleCachedImageSet.h:
  • rendering/style/StyleImage.h:
  • rendering/svg/SVGRenderSupport.h:

Source/WebKit/chromium:

  • src/LinkHighlight.cpp:
10:33 AM Changeset in webkit [133778] by peter@chromium.org
  • 2 edits in trunk/Tools

Don't show the Android tester in garden-o-matic yet
https://bugs.webkit.org/show_bug.cgi?id=101476

Reviewed by Adam Barth.

The Android tester just started running layout tests, and doesn't upload its
results yet. Don't show it for now. This exception will be removed once it
has a baseline of greenness.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:

(.):

10:29 AM Changeset in webkit [133777] by Alexandru Chiculita
  • 5 edits in trunk/Source

CoordinatedGraphicsArgumentCoders should use ValidatedCustomFitlerOperation instead
https://bugs.webkit.org/show_bug.cgi?id=100905

Reviewed by Noam Rosenthal.

Source/WebCore:

Added getters for the validated shaders, so that platform code could extract them.

No new tests, just added two getters.

  • platform/graphics/filters/CustomFilterValidatedProgram.h:

(WebCore::CustomFilterValidatedProgram::validatedVertexShader):
(WebCore::CustomFilterValidatedProgram::validatedFragmentShader):
(CustomFilterValidatedProgram):

Source/WebKit2:

The code now knows how to read a ValidatedCustomFitlerOperation and serialize it to the UI process.

No new tests, the code path is not used yet.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/CoordinatedGraphics/WebCustomFilterProgram.h:
10:26 AM Changeset in webkit [133776] by jsbell@chromium.org
  • 5 edits
    3 adds in trunk

IndexedDB: Assertion failure with open() within upgradeneeded
https://bugs.webkit.org/show_bug.cgi?id=96947

Reviewed by Dimitri Glazkov.

Source/WebCore:

Postpone creation of the "pending second half open" until the version change
transaction has started.

Test: storage/indexeddb/unblocked-version-changes.html

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::setIntVersionInternal):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseCallbacks.h:

LayoutTests:

Exercise the code path leading to the assert by having a second version change transaction
unblocked by the first's connection closing. Includes a known failure due to metadata
snapshot timing.

  • storage/indexeddb/resources/unblocked-version-changes.js: Added.

(test):
(openConnection):
(onUpgradeNeeded):
(onError):
(onUpgradeNeeded2):
(onSuccess):

  • storage/indexeddb/unblocked-version-changes-expected.txt: Added.
  • storage/indexeddb/unblocked-version-changes.html: Added.
10:20 AM Changeset in webkit [133775] by Lucas Forschler
  • 8 edits in branches/safari-536.28-branch/Source/WebCore

Merged r129652. <rdar://problem/12516382>

9:57 AM Changeset in webkit [133774] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-536.28-branch

Merged r129535. <rdar://problem/12536360>

9:55 AM Changeset in webkit [133773] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-536.28-branch

Merged r129469. <rdar://problem/12536545>

9:48 AM Changeset in webkit [133772] by Simon Fraser
  • 1 edit
    17 adds in trunk/LayoutTests

Fix failing platform/mac/tiled-drawing on Lion.

It's not possible to use TestExpectations to skip tests on all but current mac-wk2,
so just land results for Lion.

  • platform/mac-lion/platform/mac/tiled-drawing/fixed/absolute-inside-fixed-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/fixed/fixed-in-overflow-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/fixed/four-bars-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/fixed/nested-fixed-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/fixed/percentage-inside-fixed-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/scrolling-tree-after-scroll-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/scrolling-tree-slow-scrolling-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/tile-coverage-after-scroll-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/tiled-drawing-zoom-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt: Added.
  • platform/mac-lion/platform/mac/tiled-drawing/use-tiled-drawing-expected.txt: Added.
9:46 AM Changeset in webkit [133771] by Alexandru Chiculita
  • 5 edits in trunk/Source/WebCore

[CSS Shaders] Add CustomFilterMeshBoxType to ValidatedCustomFilterOperation
https://bugs.webkit.org/show_bug.cgi?id=100890

Reviewed by Dean Jackson.

Added the CustomFilterMeshBoxType parameter to the ValidatedCustomFilterOperation.

No new tests, this parameter is not used in the implementation yet.

  • platform/graphics/filters/ValidatedCustomFilterOperation.cpp:

(WebCore::ValidatedCustomFilterOperation::ValidatedCustomFilterOperation):

  • platform/graphics/filters/ValidatedCustomFilterOperation.h:

(WebCore::ValidatedCustomFilterOperation::create):
(WebCore::ValidatedCustomFilterOperation::meshBoxType):
(WebCore::ValidatedCustomFilterOperation::operator==):
(ValidatedCustomFilterOperation):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::createCustomFilterEffect):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::computeFilterOperations):

9:39 AM Changeset in webkit [133770] by sergio@webkit.org
  • 3 edits in trunk/Source/WebCore

[Qt] Implement deleteCookie() for persistent storage
https://bugs.webkit.org/show_bug.cgi?id=101272

Reviewed by Jocelyn Turcotte.

Individual cookies were never persistently cleared as the
deleteCookie() virtual method was not implemented for persistent
storage. That's why cookies were only deleted for the current
session.

  • platform/qt/CookieJarQt.cpp:

(WebCore::SharedCookieJarQt::deleteCookie):
(WebCore): added deleteCookie() implementation for persistent
storage.

  • platform/qt/CookieJarQt.h:

(SharedCookieJarQt):

9:35 AM Changeset in webkit [133769] by shinyak@chromium.org
  • 3 edits
    2 adds in trunk

[Shadow] Style should update when 'pseudo' attribute is dynamically updated
https://bugs.webkit.org/show_bug.cgi?id=100918

Reviewed by Dimitri Glazkov.

Source/WebCore:

When 'pseudo' attribute is changed and its element is in ShadowTree, we enable the styleShouldRecalc flag.

It would be fast if we have a set of pseudo attribute style value in RuleFeatureSet,
but it might consume a lot of memory.

Test: fast/dom/shadow/pseudo-attribute-dynamic.html

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

LayoutTests:

  • fast/dom/shadow/pseudo-attribute-dynamic-expected.html: Added.
  • fast/dom/shadow/pseudo-attribute-dynamic.html: Added.
9:33 AM Changeset in webkit [133768] by kbalazs@webkit.org
  • 5 edits in trunk/Tools

WebKitTestRunner flakily hangs when running pixel tests on Qt
https://bugs.webkit.org/show_bug.cgi?id=100686

Reviewed by Csaba Osztrogonác.

Make WebKitTestRunner harden against the situation when the coordinated
graphics rendering synchronisation fails. If we time out when waiting
for the forced repaint to finish it usually a symptom of the synchronisation
has been broken. In this case all other tests will fail with the same error.
The underlying problem is not yet known. Ths patch make us report this situation
as web process unresponsiveness, so the test harness will kill us and launch
a new instance. This will make our pixel test bot usable while it should not limit
us debugging the underlying bug.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::run):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::dumpWebProcessUnresponsiveness):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

  • WebKitTestRunner/TestInvocation.h:

(TestInvocation): Introduce new members to hold our state
that was local to invoke() so far.

  • WebKitTestRunner/qt/TestInvocationQt.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

9:30 AM Changeset in webkit [133767] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test expectations update.

  • platform/chromium/TestExpectations:
9:14 AM Changeset in webkit [133766] by jsbell@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening. Rebaseline the tests added
in http://trac.webkit.org/changeset/133686 - part deux.

  • platform/chromium-win/fast/backgrounds/transformed-body-background-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/transformed-body-html-background-expected.png: Added.
  • platform/chromium-win/fast/backgrounds/transformed-html-body-background-expected.png: Added.
9:12 AM Changeset in webkit [133765] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] WebKit sends unnecessary low memory notification when running memory benchmarks
https://bugs.webkit.org/show_bug.cgi?id=101474

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-11-07
Reviewed by Kentaro Hara.

Do not send low memory notification to V8 when most of memory usage
comes from V8 heap and not DOM objects. In this case V8 can schedule GC
itself more optimally.

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::checkMemoryUsage):

8:28 AM Changeset in webkit [133764] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-07

  • DEPS:
8:12 AM Changeset in webkit [133763] by allan.jensen@digia.com
  • 10 edits in trunk

[Qt] Open link in this window action
https://bugs.webkit.org/show_bug.cgi?id=101226

Reviewed by Simon Hausmann.

Source/WebCore:

Adds the action to the WebCore context-menu controller.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):

  • platform/ContextMenuItem.h:
  • platform/LocalizedStrings.h:
  • platform/qt/LocalizedStringsQt.cpp:

(WebCore::contextMenuItemTagOpenLinkInThisWindow):

Source/WebKit/qt:

Adds the action to QtWebKit.

  • Api/qwebpage.cpp:

(webActionForContextMenuAction):
(QWebPage::triggerAction):
(QWebPage::action):

  • Api/qwebpage.h:

Tools:

Populates the context-menu with the new action when the default action is to open in a new window.

  • QtTestBrowser/webview.cpp:

(createContextMenu):

8:05 AM Changeset in webkit [133762] by vsevik@chromium.org
  • 2 edits in branches/chromium/1312/Source/WebCore/inspector/front-end

Merge 133750 - Web Inspector: [Regression] Editing formatted source should not be allowed.
https://bugs.webkit.org/show_bug.cgi?id=101355

Reviewed by Pavel Feldman.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._onFormattedChanged):

  • inspector/front-end/UISourceCodeFrame.js:

(WebInspector.UISourceCodeFrame.prototype._onFormattedChanged):

TBR=vsevik@chromium.org
BUG=159820
Review URL: https://codereview.chromium.org/11377027

8:04 AM Changeset in webkit [133761] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL][WK2] Add ewk_settings_preferred_minimum_contents_width_get/set API
https://bugs.webkit.org/show_bug.cgi?id=101467

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Added ewk_settings_preferred_minimum_contents_width_get/set API which is used for setting/getting
of default minimum contents width for non viewport meta element sites.

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_preferred_minimum_contents_width_set):
(ewk_settings_preferred_minimum_contents_width_get):

  • UIProcess/API/efl/ewk_settings.h:
  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

Tools:

Added ewk_settings_preferred_minimum_contents_width_get/set API which is used for setting/getting
of default minimum contents width for non viewport meta element sites.
Set default minimum contents width to '0' for MiniBrowser as it should behave like desktop browser.

  • MiniBrowser/efl/main.c:

(window_create):

7:16 AM Changeset in webkit [133760] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2][AC] Avoid creating an empty surface
https://bugs.webkit.org/show_bug.cgi?id=101464

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

Make sure we have a valid view size before creating a GL surface.

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_calculate):

7:13 AM Changeset in webkit [133759] by vsevik@chromium.org
  • 3 edits in trunk/LayoutTests

Layout Test inspector/debugger/script-formatter-breakpoints.html is failing
https://bugs.webkit.org/show_bug.cgi?id=101361

Unreviewed test fix.

  • inspector/debugger/script-formatter-breakpoints.html:
  • platform/chromium/TestExpectations:
7:07 AM Changeset in webkit [133758] by kbalazs@webkit.org
  • 1 edit
    4 deletes in trunk/LayoutTests

[Qt] Unreviewed gardening

Some image expectetions was accidentally added for reference tests and it consused nrwt.
Deleted them.

  • platform/qt-5.0-wk2/compositing/text-on-scaled-layer-expected.png: Removed.
  • platform/qt-5.0-wk2/compositing/text-on-scaled-surface-expected.png: Removed.
  • platform/qt/css2.1/20110323/margin-collapse-clear-016-expected.png: Removed.
  • platform/qt/svg/animations/animateMotion-additive-2c-expected.png: Removed.
7:05 AM Changeset in webkit [133757] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Add EFL to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=101444

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

Added the EFL bots running layout tests to the garden-o-matic report
page. We are skipping here the bot that just builds WebKit EFL to make
the data fetching faster.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:

(.):

6:58 AM Changeset in webkit [133756] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a timeout expectation for the test introduced in r133660.
Adding timeout expectations for two media tests that started timing
out probably after r133633.

  • platform/gtk/TestExpectations:
6:55 AM Changeset in webkit [133755] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][UNIX] Crash in WebKit::PluginProcessProxy::scanPlugin()
https://bugs.webkit.org/show_bug.cgi?id=101446

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

Make sure that the disposition of the SIGCHLD signal is reset to the default
before calling g_spawn_sync(). If the disposition is set to SIG_IGN, then
g_spawn_sync() will not be able to return the exit status of the child
process, our exit failure check will be useless and the following warning
will be printed:

GLib-WARNING : In call to g_spawn_sync(), exit status of a child process
was requested but SIGCHLD action was set to SIG_IGN and ECHILD was received
by waitpid(), so exit status can't be returned. This is a bug in the
program calling g_spawn_sync(); either don't request the exit status, or
don't set the SIGCHLD action.

This patch also adds a NULL-check for stdOut to avoid crashing in such
case and makes use of String::split() to parse stdOut instead of doing it
manually.

  • UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::scanPlugin):

6:52 AM Changeset in webkit [133754] by dominik.rottsches@intel.com
  • 7 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Rebaselining a few ruby tests.

  • platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.png:
  • platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt:
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
6:42 AM Changeset in webkit [133753] by Csaba Osztrogonác
  • 1 edit
    3 deletes in trunk/LayoutTests

[Qt] Unreviewed gardening after r133688, remove unnecessary platform specific expected files.

  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Removed.
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Removed.
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Removed.
6:37 AM Changeset in webkit [133752] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Canvas] closure compiler fixes
https://bugs.webkit.org/show_bug.cgi?id=101459

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-07
Reviewed by Pavel Feldman.

  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

6:18 AM Changeset in webkit [133751] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r133712.
http://trac.webkit.org/changeset/133712
https://bugs.webkit.org/show_bug.cgi?id=101461

Broke fast/forms/time* tests on chromium-win. (Requested by
mkwst on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-07

  • platform/text/win/LocaleWin.cpp:

(WebCore::DateFormatToken::DateFormatToken):
(DateFormatToken):
(WebCore):
(WebCore::isEraSymbol):
(WebCore::isYearSymbol):
(WebCore::isMonthSymbol):
(WebCore::isDaySymbol):
(WebCore::commitLiteralToken):
(WebCore::parseDateFormat):
(WebCore::LocaleWin::ensureShortDateTokens):
(WebCore::convertWindowsDateFormatToLDML):
(WebCore::mapCharacterToDateTimeFieldType):
(WebCore::convertWindowsTimeFormatToLDML):
(WebCore::LocaleWin::dateFormat):
(WebCore::LocaleWin::monthFormat):
(WebCore::LocaleWin::timeFormat):
(WebCore::LocaleWin::shortTimeFormat):

  • platform/text/win/LocaleWin.h:

(LocaleWin):

6:14 AM Changeset in webkit [133750] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Regression] Editing formatted source should not be allowed.
https://bugs.webkit.org/show_bug.cgi?id=101355

Reviewed by Pavel Feldman.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._onFormattedChanged):

  • inspector/front-end/UISourceCodeFrame.js:

(WebInspector.UISourceCodeFrame.prototype._onFormattedChanged):

6:13 AM Changeset in webkit [133749] by shinyak@chromium.org
  • 21 edits in trunk

[Shadow] Use setPseudo() instead of setShadowPseudoId().
https://bugs.webkit.org/show_bug.cgi?id=101306

Reviewed by Kent Tamura.

.:

Exposes necessary symbols.

  • Source/autotools/symbols.filter:

Source/WebCore:

We would like to remove setShadowPseudoId() and use setPseudo() instead, since ShadowDOM spec now has
'pseudo' attribute.

We change all setShadowPseudoId() invocation to setPseudo() invocation. Also, when AtomicString is not
constructed with AtomicStringFromLiteral, we use it.

No new tests, refactoring.

  • WebCore.exp.in:
  • dom/Element.cpp:
  • dom/Element.h:

(Element):

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updatePlaceholderText):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::createShadowSubtree):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::buildBubbleTree):

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitLiteral):
(WebCore::DateTimeEditElement::DateTimeEditElement):

  • html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::initialize):

  • html/shadow/DateTimeFieldElement.h:

(DateTimeFieldElement):

  • html/shadow/PickerIndicatorElement.cpp:

(WebCore::PickerIndicatorElement::PickerIndicatorElement):

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCueBox::TextTrackCueBox):
(WebCore::TextTrackCue::updateDisplayTree):

  • testing/Internals.cpp:

(WebCore::Internals::setShadowPseudoId):

Source/WebKit2:

Exposes necessary symbols.

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:
5:57 AM Changeset in webkit [133748] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

navigator-vibration.html is still crashing occasionally.

  • platform/efl-wk2/TestExpectations:
5:53 AM Changeset in webkit [133747] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Web Inspector: [Canvas] Save CanvasGradient objects state for a replay
https://bugs.webkit.org/show_bug.cgi?id=101432

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-07
Reviewed by Pavel Feldman.

Source/WebCore:

Save CanvasGradient resource state for a subsequent replay. The gradient's state is modified by the gradient.addColorStop() call.

Test: inspector/profiler/canvas2d/canvas2d-gradient-capturing.html

  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

LayoutTests:

Alerts about API changes to CanvasGradient and CanvasPattern classes.
Checks capturing for CanvasGradient objects' state.

  • inspector/profiler/canvas2d/canvas2d-api-changes-expected.txt:
  • inspector/profiler/canvas2d/canvas2d-api-changes.html:
  • inspector/profiler/canvas2d/canvas2d-gradient-capturing-expected.txt: Added.
  • inspector/profiler/canvas2d/canvas2d-gradient-capturing.html: Added.
5:51 AM Changeset in webkit [133746] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: [Regression] Snippets evaluations should not appear in Sources tab of navigator.
https://bugs.webkit.org/show_bug.cgi?id=101354

Reviewed by Pavel Feldman.

  • inspector/front-end/DebuggerScriptMapping.js:
  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.isSnippet):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._snippetIdForSourceURL):

5:50 AM Changeset in webkit [133745] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

fast/repaint/block-selection-gap-in-table-cell.html is not
rendering correctly, so skip it when running pixel tests. Need a

  • platform/efl/TestExpectations:
5:45 AM Changeset in webkit [133744] by commit-queue@webkit.org
  • 39 edits in trunk

[EFL][WK2] Make EWK classes Ewk_Objects
https://bugs.webkit.org/show_bug.cgi?id=101057

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

Now all the existing EWK classes share common Ewk_Object ref/unref API.

Source/WebKit2:

  • UIProcess/API/efl/EwkViewCallbacks.h:
  • UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl):

  • UIProcess/API/efl/ewk_database_manager.cpp:

(Ewk_Database_Manager::createOriginList):

  • UIProcess/API/efl/ewk_database_manager_private.h:
  • UIProcess/API/efl/ewk_file_chooser_request.cpp:

(EwkFileChooserRequest::EwkFileChooserRequest):
(EwkFileChooserRequest::~EwkFileChooserRequest):
(EwkFileChooserRequest::allowMultipleFiles):
(EwkFileChooserRequest::acceptedMIMETypes):
(EwkFileChooserRequest::cancel):
(EwkFileChooserRequest::chooseFiles):
(ewk_file_chooser_request_allow_multiple_files_get):
(ewk_file_chooser_request_accepted_mimetypes_get):
(ewk_file_chooser_request_cancel):
(ewk_file_chooser_request_files_choose):
(ewk_file_chooser_request_file_choose):

  • UIProcess/API/efl/ewk_file_chooser_request.h:
  • UIProcess/API/efl/ewk_file_chooser_request_private.h:

(EwkFileChooserRequest):
(EwkFileChooserRequest::create):

  • UIProcess/API/efl/ewk_form_submission_request.cpp:

(EwkFormSubmissionRequest::EwkFormSubmissionRequest):
(EwkFormSubmissionRequest::~EwkFormSubmissionRequest):
(EwkFormSubmissionRequest::fieldValue):
(EwkFormSubmissionRequest::fieldNames):
(EwkFormSubmissionRequest::submit):
(ewk_form_submission_request_field_names_get):
(ewk_form_submission_request_field_value_get):
(ewk_form_submission_request_submit):

  • UIProcess/API/efl/ewk_form_submission_request.h:
  • UIProcess/API/efl/ewk_form_submission_request_private.h:

(EwkFormSubmissionRequest):
(EwkFormSubmissionRequest::create):

  • UIProcess/API/efl/ewk_intent.cpp:

(EwkIntent::EwkIntent):
(EwkIntent::webIntentData):
(EwkIntent::action):
(EwkIntent::type):
(EwkIntent::service):
(EwkIntent::suggestions):
(EwkIntent::extra):
(EwkIntent::extraKeys):
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):
(ewk_intent_suggestions_get):
(ewk_intent_extra_get):
(ewk_intent_extra_names_get):

  • UIProcess/API/efl/ewk_intent.h:
  • UIProcess/API/efl/ewk_intent_private.h:

(EwkIntent):
(EwkIntent::create):

  • UIProcess/API/efl/ewk_intent_service.cpp:

(EwkIntentService::EwkIntentService):
(EwkIntentService::action):
(EwkIntentService::type):
(EwkIntentService::href):
(EwkIntentService::title):
(EwkIntentService::disposition):
(ewk_intent_service_action_get):
(ewk_intent_service_type_get):
(ewk_intent_service_href_get):
(ewk_intent_service_title_get):
(ewk_intent_service_disposition_get):

  • UIProcess/API/efl/ewk_intent_service.h:
  • UIProcess/API/efl/ewk_intent_service_private.h:

(EwkIntentService):
(EwkIntentService::create):

  • UIProcess/API/efl/ewk_navigation_policy_decision.cpp:

(EwkNavigationPolicyDecision::EwkNavigationPolicyDecision):
(EwkNavigationPolicyDecision::~EwkNavigationPolicyDecision):
(EwkNavigationPolicyDecision::navigationType):
(EwkNavigationPolicyDecision::mouseButton):
(EwkNavigationPolicyDecision::modifiers):
(EwkNavigationPolicyDecision::frameName):
(EwkNavigationPolicyDecision::request):
(EwkNavigationPolicyDecision::accept):
(EwkNavigationPolicyDecision::reject):
(EwkNavigationPolicyDecision::download):
(ewk_navigation_policy_navigation_type_get):
(ewk_navigation_policy_mouse_button_get):
(ewk_navigation_policy_modifiers_get):
(ewk_navigation_policy_frame_name_get):
(ewk_navigation_policy_request_get):
(ewk_navigation_policy_decision_accept):
(ewk_navigation_policy_decision_reject):
(ewk_navigation_policy_decision_download):

  • UIProcess/API/efl/ewk_navigation_policy_decision.h:
  • UIProcess/API/efl/ewk_navigation_policy_decision_private.h:

(EwkNavigationPolicyDecision):
(EwkNavigationPolicyDecision::create):

  • UIProcess/API/efl/ewk_resource.cpp:

(EwkResource::EwkResource):
(EwkResource::url):
(EwkResource::isMainResource):
(ewk_resource_url_get):
(ewk_resource_main_resource_get):

  • UIProcess/API/efl/ewk_resource.h:
  • UIProcess/API/efl/ewk_resource_private.h:

(EwkResource):
(EwkResource::create):

  • UIProcess/API/efl/ewk_security_origin.cpp:

(EwkSecurityOrigin::EwkSecurityOrigin):
(EwkSecurityOrigin::host):
(EwkSecurityOrigin::protocol):
(EwkSecurityOrigin::port):
(ewk_security_origin_host_get):
(ewk_security_origin_protocol_get):
(ewk_security_origin_port_get):

  • UIProcess/API/efl/ewk_security_origin.h:
  • UIProcess/API/efl/ewk_security_origin_private.h:

(EwkSecurityOrigin):
(EwkSecurityOrigin::create):

  • UIProcess/API/efl/ewk_storage_manager.cpp:

(Ewk_Storage_Manager::createOriginList):

  • UIProcess/API/efl/ewk_url_scheme_request_private.h:

(EwkUrlSchemeRequest):

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_intent_deliver):

  • UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp:

(onFileChooserRequest):
(TEST_F):

  • UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:

(TEST_F):

  • UIProcess/efl/FormClientEfl.cpp:

(WebKit::FormClientEfl::willSubmitForm):

  • UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didReceiveIntentForFrame):
(WebKit::PageLoadClientEfl::registerIntentServiceForFrame):

  • UIProcess/efl/PagePolicyClientEfl.cpp:

(WebKit::PagePolicyClientEfl::decidePolicyForNavigationAction):
(WebKit::PagePolicyClientEfl::decidePolicyForNewWindowAction):

  • UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::runOpenPanel):

  • UIProcess/efl/ResourceLoadClientEfl.cpp:

(WebKit::ResourceLoadClientEfl::didInitiateLoadForResource):

  • UIProcess/efl/ResourceLoadClientEfl.h:

Tools:

  • MiniBrowser/efl/main.c:

(close_file_picker):
(on_file_chooser_request):

5:42 AM Changeset in webkit [133743] by keishi@webkit.org
  • 2 edits in branches/chromium/1312/Source/WebKit/chromium

Merge 133132 - [Chromium] Page popup shows up at wrong locations when root view is scrolled
https://bugs.webkit.org/show_bug.cgi?id=100830

Reviewed by Kent Tamura.

We need to account for the scroll position when calculating the root view rectangle in the screen.

  • src/DateTimeChooserImpl.cpp:

(WebKit::DateTimeChooserImpl::writeDocument):

TBR=keishi@webkit.org
Review URL: https://codereview.chromium.org/11275190

5:35 AM Changeset in webkit [133742] by vsevik@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed inspector test polish.
Made http/tests/indexeddb/database-data.html test faster, added more verbose errors for test debugging.

  • http/tests/inspector/indexeddb/database-data-expected.txt:
  • http/tests/inspector/indexeddb/database-data.html:
  • http/tests/inspector/indexeddb/indexeddb-test.js:

(onIndexedDBError):
(onIndexedDBBlocked):
(doWithDatabase):

5:35 AM Changeset in webkit [133741] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Return earlier if a plugin snapshot cannot be created.
https://bugs.webkit.org/show_bug.cgi?id=101445

Reviewed by Kenneth Rohde Christiansen.

Currently only the Mac port has support for creating snapshots of
Netscape plugins. Return earlier in PluginProxy::snapshot() so
that we do not pass a null handler to ShareableBitmap::create()
and avoid crashing when running pixel tests with plugins.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::snapshot):

5:33 AM Changeset in webkit [133740] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Change encoding detector API names
https://bugs.webkit.org/show_bug.cgi?id=101450

Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-07
Reviewed by Gyuyoung Kim.

To make settings API name consistent, we need to change two APIs with respect to encoding detector.

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_encoding_detector_enabled_set):
(ewk_settings_encoding_detector_enabled_get):

  • UIProcess/API/efl/ewk_settings.h:
  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

5:15 AM Changeset in webkit [133739] by rakuco@webkit.org
  • 8 edits
    4 adds in trunk/LayoutTests

[EFL] Gardening. Add or fix a few pixel expectations.

  • platform/efl/compositing/plugins/composited-plugin-expected.png:
  • platform/efl/compositing/repaint/composited-document-element-expected.png: Added.
  • platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.png:
  • platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt:
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
  • platform/efl/plugins/iframe-plugin-bgcolor-expected.png: Added.
  • platform/efl/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
  • platform/efl/plugins/netscape-dom-access-expected.png: Added.
5:14 AM Changeset in webkit [133738] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Unreviewed. Add Qt EWS bots to the watchers list.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(QtEWS):
(QtWK2EWS):

4:55 AM Changeset in webkit [133737] by senorblanco@chromium.org
  • 1 edit
    7 deletes in trunk/LayoutTests

Now that it no longer produces image results, remove unnecessary
PNGs for crash-hw-sw-switch.html. Unreviewed.

  • platform/chromium-android/css3/filters/crash-hw-sw-switch-expected.png: Removed.
  • platform/chromium-linux/css3/filters/crash-hw-sw-switch-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png: Removed.
  • platform/chromium-mac/css3/filters/crash-hw-sw-switch-expected.png: Removed.
  • platform/chromium-win/css3/filters/crash-hw-sw-switch-expected.png: Removed.
  • platform/mac-snowleopard/css3/filters/crash-hw-sw-switch-expected.png: Removed.
  • platform/qt/css3/filters/crash-hw-sw-switch-expected.png: Removed.
4:39 AM Changeset in webkit [133736] by g.czajkowski@samsung.com
  • 9 edits
    3 adds in trunk

Source/WebKit2: WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
https://bugs.webkit.org/show_bug.cgi?id=93611

Reviewed by Gyuyoung Kim.

When WebKitTestRunner turns on the spelling feature with the resetStateToConsistentValues() method,
it happens that the WebProcess is still not launched (although it is already created).
In this case, isValid() method returns false.

This fix sends a message to the WebProcess messages queue, and the message
will be handled once the WebProcess is ready.

  • Target.pri:

Adds missing files to compile spellcheking feature for WebKit2-Qt
to use WebKit C API from WKTextChecker.h.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::updateTextCheckerState):
Uses canSendMessage() method instead of isValid() to check whether the message to
the WebProcess can be sent.

  • UIProcess/efl/TextCheckerEfl.cpp:

(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
Calls TextChecker::setContinuousSpellCheckingEnabled which additionaly invokes the client's method.
WK2-EFL settings for text checker (ewk_settings.cpp) set the default language (if it wasn't set earlier) to
perform the spelling. It allows to pass the tests from editing/spelling directory.

Tools: WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
https://bugs.webkit.org/show_bug.cgi?id=93611

Reviewed by Gyuyoung Kim.

WebKitTestRunner enables spelling feature to pass the layout tests from editing/spelling.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):
Enables spelling by WebKit2 C API.

LayoutTests: [EFL] WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
https://bugs.webkit.org/show_bug.cgi?id=93611

Reviewed by Gyuyoung Kim.

Unskip the spelling tests from efl-wk2/TestExpectations to run them for WebKit2-EFL.
Add new missing baselines for two spelling tests for EFL platform.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/editing/spelling/inline_spelling_markers-expected.txt: Added.
  • platform/efl/editing/spelling/spelling-expected.txt: Added.
4:28 AM Changeset in webkit [133735] by dominik.rottsches@intel.com
  • 2 edits in trunk/Tools

[EFL] Switch the efl-linux-slave-2 to Wk2 Release
https://bugs.webkit.org/show_bug.cgi?id=101345

Reviewed by Gyuyoung Kim.

Switching efl-linux-slave-2 to Wk2 Release.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
3:14 AM Changeset in webkit [133734] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[V8] Cleanup V8DOMWrapper::getCachedWrapper
https://bugs.webkit.org/show_bug.cgi?id=100853

Patch by Dan Carney <dcarney@google.com> on 2012-11-07
Reviewed by Adam Barth.

Slight cleanup. Removed redundant branch.

No new tests. No change in functionality.

  • bindings/v8/V8DOMWrapper.h:

(WebCore::V8DOMWrapper::getCachedWrapper):

2:22 AM Changeset in webkit [133733] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Qt] Unreviewed trivial build fix adapting to QtMultimedia API changes

The QtMultimedia namespace is now called QMultimedia and
QtMultimedia::MetaData is now QMediaMetaData.

  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivateQt::supportsType):
(WebCore::MediaPlayerPrivateQt::totalBytes):

1:45 AM Changeset in webkit [133732] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Marking new test media/progress-events-generated-correctly.html as failing on EFL.

  • platform/efl/TestExpectations:
1:43 AM Changeset in webkit [133731] by commit-queue@webkit.org
  • 22 edits in trunk

Add replaceWithLiteral() method to WTF::String
https://bugs.webkit.org/show_bug.cgi?id=101257

Patch by Christophe Dumez <Christophe Dumez> on 2012-11-07
Reviewed by Benjamin Poulain.

Source/WebCore:

Substitute String::replace() calls by String::replaceWithLiteral() where
adequate, for efficiency.

No new tests, no behavior change.

  • dom/Node.cpp:

(WebCore::Node::showNode):

  • editing/EditingStyle.cpp:

(WebCore::StyleChange::extractTextStyles):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::setSearch):

  • loader/FormSubmission.cpp:

(WebCore::appendMailtoPostFormDataToURL):

  • platform/network/soup/ProxyResolverSoup.cpp:

(soupProxyResolverWkSetProperty):

  • plugins/PluginView.cpp:

(WebCore::makeURL):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::showBox):

  • xml/XSLTProcessor.cpp:

(WebCore::transformTextStringToXHTMLDocumentString):

Source/WebKit/blackberry:

Substitute String::replace() calls by String::replaceWithLiteral() where
adequate, for efficiency.

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::generateHTML):

Source/WebKit2:

Substitute String::replace() calls by String::replaceWithLiteral() where
adequate, for efficiency.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::makeURLString):

Source/WTF:

Add replaceWithLiteral() method to WTF::String that takes
replacement string as a literal to avoid uselessly constructing
a String object.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::replace):
(WTF):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::replace):
(StringImpl):

  • wtf/text/WTFString.h:

(String):
(WTF::String::replaceWithLiteral):

Tools:

Add API tests for String::replaceWithLiteral() and corresponding
StringImpl methods.

  • TestWebKitAPI/CMakeLists.txt: Add WTFString API tests to CMake.
  • TestWebKitAPI/Tests/WTF/StringImpl.cpp:

(TestWebKitAPI::TEST):
(TestWebKitAPI):

  • TestWebKitAPI/Tests/WTF/WTFString.cpp:

(TestWebKitAPI::TEST):

1:32 AM Changeset in webkit [133730] by Simon Hausmann
  • 4 edits in trunk

[Qt] Fix build of modules depending on QtWebKit when using prefix
https://bugs.webkit.org/show_bug.cgi?id=101437

Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-11-07
Reviewed by Simon Hausmann.

.:

.qmake.conf loads qt_build_config.prf, which nowadays is responsible for
adding the path to .qmake.super (before it was done by default_pre.prf,
so having setting the path in our default_pre wrapper was sufficient).

  • .qmake.conf:

Tools:

Remove setting of MODULE_QMAKE_OUTDIR from here, it's been moved to .qmake.conf.

  • qmake/mkspecs/features/default_pre.prf:
12:54 AM Changeset in webkit [133729] by kenneth@webkit.org
  • 7 edits in trunk/Source

Remove support for "desktop-width" in the viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=101217

Reviewed by Gyuyoung Kim.

Source/WebCore:

This has been removed from the CSS Device Adaptation spec, and
should be safe to remove as it is not documented anywhere (neither
in blog posts).

The viewport meta should only support the legacy features.

  • dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes):
(WebCore::findSizeValue):
(WebCore::findScaleValue):
(WebCore::findUserScalableValue):

  • dom/ViewportArguments.h:

Source/WebKit/blackberry:

Sync WebViewportArguments enum with the one in
WebCore::ViewportArguments

  • Api/WebViewportArguments.h:

Source/WebKit/chromium:

Remove some code trying to use the set desktop width (say 980) for
sites not using a viewport meta element.

Removing this code should have no effect as it ends up being set
to desktop width in that case anyway, by the ViewportArguments
algorithm.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

12:40 AM Changeset in webkit [133728] by dominik.rottsches@intel.com
  • 4 edits in trunk

[EFL] Fix execution of exif-orientation-image-document.html on EFL Wk2 bot
https://bugs.webkit.org/show_bug.cgi?id=101343

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add Cairo to the list of backends that support shouldRespectImageOrientation.

No new tests, fixes exif-orientation-image-document.html.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::shouldRespectImageOrientation):

LayoutTests:

Unskipping exif-orientation-image-document.html now that respecting
orientation is default enabled for image documents.

  • platform/efl-wk2/TestExpectations:
12:32 AM Changeset in webkit [133727] by yurys@chromium.org
  • 4 edits
    2 adds in trunk

Console not displaying all properties of an Object once native Constructor overwritten
https://bugs.webkit.org/show_bug.cgi?id=101320

Reviewed by Pavel Feldman.

Source/WebCore:

Use Object instance from {}.constructor when formatting inspector messages in the
injected script. Otherwise inspected page may overwrite Object value and break inspector.

Test: inspector/console/console-Object-overwritten.html

  • inspector/InjectedScriptSource.js:

LayoutTests:

Check that Web Inspector's console works fine if Object is overwritten in the inspected
page.

  • inspector/console/console-Object-overwritten-expected.txt: Added.
  • inspector/console/console-Object-overwritten.html: Added.
Note: See TracTimeline for information about the timeline view.