Timeline



Dec 3, 2012:

11:48 PM Changeset in webkit [136480] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r136467

The template element patch added asserts in parserAppendChild and parserInsertBefore which should be valid, but DOMImplementation::createDocument() calls parserAppendChild with docType without regard to its owner. This patch removes the assert and adds a FIXME.

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2012-12-03

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserAppendChild):

11:41 PM Changeset in webkit [136479] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Enter an Isolate before initializing PerIsolateData
https://bugs.webkit.org/show_bug.cgi?id=103949

Reviewed by Adam Barth.

Currently we initialize PerIsolateData before entering an Isolate,
which prevents us from using an Isolate in the PerIsolateData
constructor. We should enter an Isolate first and then initialize
PerIsolateData.

No tests. No change in behavior.

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::WorkerScriptController):

11:37 PM Changeset in webkit [136478] by Nate Chapin
  • 2 edits in trunk/LayoutTests

svg/foreignObject/viewport-foreignObject-crash.html recurses infinitely sometimes
https://bugs.webkit.org/show_bug.cgi?id=103935.

Reviewed by Abhishek Arya.

  • svg/foreignObject/viewport-foreignobject-crash.html:
11:36 PM Changeset in webkit [136477] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Coordinated Graphics: Reorder messages to LayerTreeCoordinatorProxy
https://bugs.webkit.org/show_bug.cgi?id=103843

Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-03
Reviewed by Noam Rosenthal.

Remove updateViewport() in LayerTreeCoordinatorProxy::setRootCompositingLayer()
because LayerTreeCoordinatorProxy::didRenderFrame() is always called after
setting the root layer. There is no behaviour changes because setting the root
layer isn't actually applied to TextureMapperLayer until DidRenderFrame message
is received.

This is in preparation for refactoring TextureMapper to work in an actor
model (http://webkit.org/b/103854).

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::setRootCompositingLayer):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):

11:35 PM Changeset in webkit [136476] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Add WebKitDOMShadowRoot.h to the list of public API headers after r135693
https://bugs.webkit.org/show_bug.cgi?id=103909

Reviewed by Martin Robinson.

WebKitDOMShadowRoot was added in r135693. As it is added to
webkitdom.h we have to export the include file, otherwise clients
will fail to build due to the missing file.

  • bindings/gobject/GNUmakefile.am:
11:17 PM Changeset in webkit [136475] by jsbell@chromium.org
  • 15 edits in trunk

IndexedDB: Correct database version after aborted upgrade
https://bugs.webkit.org/show_bug.cgi?id=103763

Reviewed by Tony Chang.

Source/WebCore:

After an aborted "versionchange" transaction, the IDBDatabase would fetch a fresh snapshot
of the metadata from the back end. If the back end had already started a new "versionchange"
transaction the snapshot would be bogus. Instead, save a copy of the IDBDatabase's metadata
and roll back to that, as is done for IDBObjectStore.

Tests: storage/indexeddb/intversion-abort-in-initial-upgradeneeded.html

storage/indexeddb/mozilla/versionchange-abort.html
storage/indexeddb/unblocked-version-changes.html

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::IDBDatabase):
(WebCore::IDBDatabase::transactionCreated):

  • Modules/indexeddb/IDBDatabase.h:

(WebCore::IDBDatabase::setMetadata): Let IDBOpenDBRequest and IDBTransaction tinker.

  • Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::onUpgradeNeeded): Fetch new and compute old metadata.
(WebCore::IDBOpenDBRequest::onSuccess): Fetch new metadata, in case upgrade changed it.

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::create): Stash the old metadata, in case of rollback.
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::onAbort): Revert the database as well as the stores.

  • Modules/indexeddb/IDBTransaction.h:

(IDBTransaction):

Source/WebKit/chromium:

Pass previously created proxy along in an open onSuccess, rather than a useless wrapper.

  • src/WebIDBCallbacksImpl.cpp:

(WebKit::WebIDBCallbacksImpl::WebIDBCallbacksImpl):
(WebKit::WebIDBCallbacksImpl::onSuccess):
(WebKit::WebIDBCallbacksImpl::onUpgradeNeeded):

  • src/WebIDBCallbacksImpl.h:

(WebCore):
(WebIDBCallbacksImpl):

LayoutTests:

Update test expectations and tweak a test so it's testing what it claimed.

  • storage/indexeddb/intversion-abort-in-initial-upgradeneeded-expected.txt:
  • storage/indexeddb/mozilla/resources/versionchange-abort.js:

(postAbort):

  • storage/indexeddb/mozilla/versionchange-abort-expected.txt:
  • storage/indexeddb/resources/unblocked-version-changes.js:

(onUpgradeNeeded):

  • storage/indexeddb/unblocked-version-changes-expected.txt:
10:59 PM Changeset in webkit [136474] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed, functionality fix after r136437.

Calling sys.exit actually raises a SystemExit exception that
is then handled in the second block and causes the script to
return an 'exceptional' exit code rather than the code presenting
the number of failed tests.

This is just a temporary fix to get the faultless bots green while
they are unnecessarily red at the moment. The problem and a proper
fix will be properly addressed.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
8:41 PM Changeset in webkit [136473] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Gardening of Apple Windows port.
https://bugs.webkit.org/show_bug.cgi?id=102603.

  • platform/win/TestExpectations:
8:31 PM Changeset in webkit [136472] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening of Apple Windows Port.
https://bugs.webkit.org/show_bug.cgi?id=97026

  • platform/win/TestExpectations:
8:25 PM Changeset in webkit [136471] by tasak@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, WebKit gardening.

  • platform/chromium/TestExpectations:

Marked the following tests as crash timeout for Android:
media/encrypted-media/encrypted-media-syntax.html,
media/encrypted-media/encrypted-media-events.html, and
media/encrypted-media/encrypted-media-not-loaded.html.

7:58 PM Changeset in webkit [136470] by roger_fong@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed. Removing expected failing results for Windows port. Test now works.
https://bugs.webkit.org/show_bug.cgi?id=51469

  • platform/win/fast/js/large-expressions-expected.txt: Removed.
7:53 PM Changeset in webkit [136469] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip fast/js/kde/Array.html.
https://bugs.webkit.org/show_bug.cgi?id=103962.

  • platform/win/TestExpectations:
7:44 PM Changeset in webkit [136468] by roger_fong@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed. Line ending fix.

  • platform/win/css3/filters/effect-reference-expected.txt:
  • platform/win/css3/filters/effect-reference-hw-expected.txt:
7:19 PM EFLWebKitCodingStyle edited by halton.huo@gmail.com
(diff)
7:09 PM Changeset in webkit [136467] by rafaelw@chromium.org
  • 34 edits
    17 adds in trunk

Implement HTMLTemplateElement
https://bugs.webkit.org/show_bug.cgi?id=86031

Reviewed by Adam Barth.

Source/WebCore:

Initial implementation. This patch includes the parser changes, new IDL and element implementation for <template>.

Spec: http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html

Tests: fast/dom/HTMLTemplateElement/cloneNode.html

fast/dom/HTMLTemplateElement/inertContents.html
fast/dom/HTMLTemplateElement/innerHTML.html
fast/dom/HTMLTemplateElement/ownerDocument.html
html5lib/run-template.html

  • WebCore.gypi:
  • css/html.css:

(template):

  • dom/Document.cpp:

(WebCore):
(WebCore::Document::templateContentsOwnerDocument):

  • dom/Document.h:

(Document):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::serializeNodesWithNamespaces):

  • html/HTMLElement.h:

(HTMLElement):

  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
  • html/HTMLTemplateElement.cpp: Added.

(WebCore):
(WebCore::HTMLTemplateElement::HTMLTemplateElement):
(WebCore::HTMLTemplateElement::setInnerHTML):
(WebCore::HTMLTemplateElement::~HTMLTemplateElement):
(WebCore::HTMLTemplateElement::create):
(WebCore::HTMLTemplateElement::content):
(WebCore::HTMLTemplateElement::setContent):
(WebCore::toHTMLTemplateElement):

  • html/HTMLTemplateElement.h: Added.

(WebCore):
(HTMLTemplateElement):
(WebCore::toHTMLTemplateElement):

  • html/HTMLTemplateElement.idl: Added.
  • html/parser/HTMLConstructionSite.cpp:

(WebCore::executeTask):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::ownerDocumentForCurrentNode):
(WebCore):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore::HTMLConstructionSite::findFosterSite):

  • html/parser/HTMLConstructionSite.h:

(HTMLConstructionSite):

  • html/parser/HTMLElementStack.cpp:

(WebCore):
(WebCore::HTMLElementStack::hasTemplateInHTMLScope):

  • html/parser/HTMLElementStack.h:

(HTMLElementStack):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::constructTreeFromToken):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore):
(WebCore::HTMLTreeBuilder::processTemplateEndTag):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processHtmlStartTagForInBody):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processTrEndTagForInRow):
(WebCore::HTMLTreeBuilder::processTableEndTagForInTable):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):

  • html/parser/HTMLTreeBuilder.h:

(HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::isParsingTemplateContents):
(WebCore::HTMLTreeBuilder::isParsingFragmentOrTemplateContents):

  • page/DOMWindow.idl:

Source/WebKit/chromium:

Turning on HTMLTemplateElement for chromium port.

  • features.gypi:

LayoutTests:

  • fast/dom/HTMLTemplateElement/cloneNode-expected.txt: Added.
  • fast/dom/HTMLTemplateElement/cloneNode.html: Added.
  • fast/dom/HTMLTemplateElement/inertContents-expected.txt: Added.
  • fast/dom/HTMLTemplateElement/inertContents.html: Added.
  • fast/dom/HTMLTemplateElement/innerHTML-expected.txt: Added.
  • fast/dom/HTMLTemplateElement/innerHTML.html: Added.
  • fast/dom/HTMLTemplateElement/ownerDocument-expected.txt: Added.
  • fast/dom/HTMLTemplateElement/ownerDocument.html: Added.
  • html5lib/resources/template.dat: Added.
  • html5lib/run-template-expected.txt: Added.
  • html5lib/run-template.html: Added.
  • resources/dump-as-markup.js:

(Markup._get):
(Markup._getSelectionFromNode):

6:37 PM Changeset in webkit [136466] by commit-queue@webkit.org
  • 12 edits
    9 adds in trunk

Unreviewed, rolling out r136460.
http://trac.webkit.org/changeset/136460
https://bugs.webkit.org/show_bug.cgi?id=103958

This patch caused compile error when building DumpRenderTree
(Requested by tasak on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-03

Source/Platform:

  • Platform.gypi:
  • chromium/public/linux/WebThemeEngine.h: Added.

(WebKit):
(WebThemeEngine):
(ScrollbarTrackExtraParams):
(ButtonExtraParams):
(TextFieldExtraParams):
(MenuListExtraParams):
(SliderExtraParams):
(InnerSpinButtonExtraParams):
(ProgressBarExtraParams):
(WebKit::WebThemeEngine::getSize):
(WebKit::WebThemeEngine::paint):

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/PlatformThemeChromiumLinux.cpp: Added.

(WebCore):
(WebCore::PlatformThemeChromiumLinux::setScrollbarColors):
(WebCore::clamp):
(WebCore::PlatformThemeChromiumLinux::saturateAndBrighten):
(WebCore::PlatformThemeChromiumLinux::outlineColor):
(WebCore::PlatformThemeChromiumLinux::paintArrowButton):

  • platform/chromium/PlatformThemeChromiumLinux.h: Added.

(WebCore):
(PlatformThemeChromiumLinux):
(WebCore::PlatformThemeChromiumLinux::thumbInactiveColor):
(WebCore::PlatformThemeChromiumLinux::thumbActiveColor):
(WebCore::PlatformThemeChromiumLinux::trackColor):
(WebCore::PlatformThemeChromiumLinux::PlatformThemeChromiumLinux):

  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: Added.

(WebCore):
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumLinux::paintButton):
(WebCore::ScrollbarThemeChromiumLinux::paintThumb):
(WebCore::ScrollbarThemeChromiumLinux::shouldCenterOnThumb):
(WebCore::ScrollbarThemeChromiumLinux::buttonSize):
(WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):

  • platform/chromium/ScrollbarThemeChromiumLinux.h: Added.

(ScrollbarThemeChromiumLinux):

  • rendering/RenderThemeChromiumAndroid.cpp:

(WebCore::RenderThemeChromiumAndroid::extraDefaultStyleSheet):

  • rendering/RenderThemeChromiumAndroid.h:
  • rendering/RenderThemeChromiumLinux.cpp: Added.

(WebCore):
(WebCore::getWebThemeState):
(WebCore::RenderThemeChromiumLinux::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux):
(WebCore::RenderThemeChromiumLinux::~RenderThemeChromiumLinux):
(WebCore::RenderThemeChromiumLinux::systemColor):
(WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet):
(WebCore::RenderThemeChromiumLinux::controlSupportsTints):
(WebCore::RenderThemeChromiumLinux::activeListBoxSelectionBackgroundColor):
(WebCore::RenderThemeChromiumLinux::activeListBoxSelectionForegroundColor):
(WebCore::RenderThemeChromiumLinux::inactiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeChromiumLinux::inactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeChromiumLinux::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumLinux::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumLinux::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeChromiumLinux::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeChromiumLinux::sliderTickSize):
(WebCore::RenderThemeChromiumLinux::sliderTickOffsetFromTrackCenter):
(WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
(WebCore::RenderThemeChromiumLinux::supportsControlTints):
(WebCore::RenderThemeChromiumLinux::setCaretBlinkInterval):
(WebCore::RenderThemeChromiumLinux::caretBlinkIntervalInternal):
(WebCore::RenderThemeChromiumLinux::setSelectionColors):
(WebCore::RenderThemeChromiumLinux::paintCheckbox):
(WebCore::RenderThemeChromiumLinux::setCheckboxSize):
(WebCore::RenderThemeChromiumLinux::paintRadio):
(WebCore::RenderThemeChromiumLinux::setRadioSize):
(WebCore::RenderThemeChromiumLinux::paintButton):
(WebCore::RenderThemeChromiumLinux::paintTextField):
(WebCore::RenderThemeChromiumLinux::paintMenuList):
(WebCore::RenderThemeChromiumLinux::paintSliderTrack):
(WebCore::RenderThemeChromiumLinux::paintSliderThumb):
(WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumLinux::paintInnerSpinButton):
(WebCore::RenderThemeChromiumLinux::paintProgressBar):
(WebCore::RenderThemeChromiumLinux::shouldOpenPickerWithF4Key):

  • rendering/RenderThemeChromiumLinux.h: Added.

(WebCore):
(RenderThemeChromiumLinux):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/linux/WebRenderTheme.h: Added.

(WebKit):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setScrollbarColors):
(WebKit::WebViewImpl::setSelectionColors):

  • src/linux/WebRenderTheme.cpp: Added.

(WebKit):
(WebKit::setCaretBlinkInterval):

Tools:

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest):

6:24 PM Changeset in webkit [136465] by jchaffraix@webkit.org
  • 7 edits
    2 adds in trunk

Source/WebCore: [CSS Grid Layout] Support paddings and margins on grid items
https://bugs.webkit.org/show_bug.cgi?id=103677

Reviewed by Tony Chang.

After bug 102968, we properly resolve grid items' width and height against the
grid areas' sizes. However we didn't check for paddings and margins, which is
what this change fixes..

Test: fast/css-grid-layout/percent-padding-margin-resolution-grid-item.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegion):
Don't stretch the end margin to match the containing block's extent.
The fix is similar to what was done for flex-box in bug 65887.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::computeStickyPositionConstraints):
Added a comment about not using containingBlockLogicalWidthForContent.

(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
Updated these functions to use containingBlockLogicalWidthForContent.

  • rendering/RenderGrid.h:
  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderGrid):
Added isRenderGrid.

LayoutTests: [CSS Grid Layout] Support percentage paddings and margins on grid items
https://bugs.webkit.org/show_bug.cgi?id=103677

Reviewed by Tony Chang.

  • resources/check-layout.js:

Extended check-layout to be able to query paddings and margins. Note that in order to compare,
the attribute with the returned value from getComputedStyle, we need to trim the unit ("px")
from the actual values. This trick also works in FireFox and Opera.

  • fast/css-grid-layout/percent-padding-margin-resolution-grid-item-expected.txt: Added.
  • fast/css-grid-layout/percent-padding-margin-resolution-grid-item.html: Added.
6:22 PM Changeset in webkit [136464] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

Make it easier to add more web process initialization parameters
https://bugs.webkit.org/show_bug.cgi?id=103942

Reviewed by Andreas Kling.

Add a WebProcessInitializationParameters struct to make it easier to add more initialization
parameters in the future. Also, fix naming and spelling errors.

  • WebProcess/mac/WebProcessInitialization.h:

(WebProcessInitializationParameters):
(WebKit):

  • WebProcess/mac/WebProcessInitialization.mm:

(WebKit::initializeWebProcess):

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

  • WebProcess/mac/WebProcessServiceEntryPoints.h:
  • WebProcess/mac/WebProcessServiceEntryPoints.mm:

(WebKit::WebProcessServiceEventHandler):
(webProcessServiceMain):
(initializeWebProcessForWebProcessServiceForWebKitDevelopment):

  • WebProcessService/WebProcessServiceMain.mm:

(main):

  • WebProcessServiceForWebKitDevelopment/WebProcessServiceForWebKitDevelopmentMain.mm:

(WebProcessServiceForWebKitDevelopmentEventHandler):

6:19 PM Changeset in webkit [136463] by roger_fong@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed. Expected failing results on Windows.

  • platform/win/css3/filters: Added.
  • platform/win/css3/filters/effect-reference-expected.txt: Added.
  • platform/win/css3/filters/effect-reference-hw-expected.txt: Added.
5:57 PM Changeset in webkit [136462] by tasak@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, WebKit gardening.

  • platform/chromium/TestExpectations:

Removed duplicate entries for compositing/masks/masked-ancestor.html.
Fixed overriding: compositing/masks/simple-composited-mask.html.

5:38 PM Changeset in webkit [136461] by pierre.rossi@gmail.com
  • 4 edits in trunk

[Qt] another stab at fixing the windows build

It seems the QT_BUILD_{TARGET}_LIB are not set as they should by qt_module.prf.
Define them by hand to be on the safe side.

.:

  • Source/widgetsapi.pri:

Source/WebKit:

  • WebKit1.pro:
5:20 PM Changeset in webkit [136460] by commit-queue@webkit.org
  • 12 edits
    9 deletes in trunk

[chromium] Remove linux theme related files and switch to default
https://bugs.webkit.org/show_bug.cgi?id=103897

Patch by Scott Violet <sky@chromium.org> on 2012-12-03
Reviewed by Darin Fisher.

Source/Platform:

  • Platform.gypi: remove WebThemeEngine.h
  • chromium/public/linux/WebThemeEngine.h: Removed.

Source/WebCore:

linux theme related files are now named default. This removes
linux theme files, updates build files and removes ifdefs.

Code cleanup, no new tests.

  • WebCore.gyp/WebCore.gyp: Update build rules
  • WebCore.gypi: Update build rules
  • platform/chromium/PlatformThemeChromiumLinux.cpp: Removed.
  • platform/chromium/PlatformThemeChromiumLinux.h: Removed.
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: Removed.
  • platform/chromium/ScrollbarThemeChromiumLinux.h: Removed.
  • rendering/RenderThemeChromiumAndroid.h: Change superclass
  • rendering/RenderThemeChromiumAndroid.cpp: Change call to superclass
  • rendering/RenderThemeChromiumLinux.cpp: Removed.
  • rendering/RenderThemeChromiumLinux.h: Removed.

Source/WebKit/chromium:

linux theme related files are now named default. This removes
linux files updates build files and removes ifdefs.

  • WebKit.gyp: update rules.
  • public/linux/WebRenderTheme.h: Removed.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setScrollbarColors): Update ifdefs
(WebKit::WebViewImpl::setSelectionColors): Update ifdefs

  • src/linux/WebRenderTheme.cpp: Removed.

Tools:

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest): linux->default

5:05 PM Changeset in webkit [136459] by dino@apple.com
  • 7 edits
    681 adds in trunk/LayoutTests

Add Opera-submitted W3C <track> tests to LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=103887

Patch by Antoine Quint <Antoine Quint> on 2012-12-03
Reviewed by Eric Carlson.

Adding the Opera-submitted W3C <track> testsuite and test results for passing tests. Failing tests are skipped
on all platforms.

  • media/track/opera/idl/media-idl-tests.html: Added.
  • media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack.html: Added.
  • media/track/opera/interfaces/HTMLElement/HTMLMediaElement/crossOrigin.html: Added.
  • media/track/opera/interfaces/HTMLElement/HTMLMediaElement/textTracks-expected.txt: Added.
  • media/track/opera/interfaces/HTMLElement/HTMLMediaElement/textTracks.html: Added.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/default-expected.txt: Added.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/default.html: Added.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/kind.html: Added.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/label-expected.txt: Added.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/label.html: Added.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/readyState-expected.txt: Added.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/readyState.html: Added.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/src.html: Added.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/srclang-expected.txt: Added.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/srclang.html: Added.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/track-expected.txt: Added.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/track.html: Added.
  • media/track/opera/interfaces/TextTrack/activeCues.html: Added.
  • media/track/opera/interfaces/TextTrack/addCue.html: Added.
  • media/track/opera/interfaces/TextTrack/constants-expected.txt: Added.
  • media/track/opera/interfaces/TextTrack/constants.html: Added.
  • media/track/opera/interfaces/TextTrack/cues.html: Added.
  • media/track/opera/interfaces/TextTrack/kind.html: Added.
  • media/track/opera/interfaces/TextTrack/label-expected.txt: Added.
  • media/track/opera/interfaces/TextTrack/label.html: Added.
  • media/track/opera/interfaces/TextTrack/language-expected.txt: Added.
  • media/track/opera/interfaces/TextTrack/language.html: Added.
  • media/track/opera/interfaces/TextTrack/mode-expected.txt: Added.
  • media/track/opera/interfaces/TextTrack/mode.html: Added.
  • media/track/opera/interfaces/TextTrack/oncuechange-expected.txt: Added.
  • media/track/opera/interfaces/TextTrack/oncuechange.html: Added.
  • media/track/opera/interfaces/TextTrack/removeCue.html: Added.
  • media/track/opera/interfaces/TextTrackCue/align.html: Added.
  • media/track/opera/interfaces/TextTrackCue/endTime.html: Added.
  • media/track/opera/interfaces/TextTrackCue/getCueAsHTML.html: Added.
  • media/track/opera/interfaces/TextTrackCue/id.html: Added.
  • media/track/opera/interfaces/TextTrackCue/line.html: Added.
  • media/track/opera/interfaces/TextTrackCue/onenter.html: Added.
  • media/track/opera/interfaces/TextTrackCue/onexit.html: Added.
  • media/track/opera/interfaces/TextTrackCue/pauseOnExit.html: Added.
  • media/track/opera/interfaces/TextTrackCue/snapToLines.html: Added.
  • media/track/opera/interfaces/TextTrackCue/startTime.html: Added.
  • media/track/opera/interfaces/TextTrackCue/text.html: Added.
  • media/track/opera/interfaces/TextTrackCue/track.html: Added.
  • media/track/opera/interfaces/TextTrackCue/vertical.html: Added.
  • media/track/opera/interfaces/TextTrackCueList/getCueById-expected.txt: Added.
  • media/track/opera/interfaces/TextTrackCueList/getCueById.html: Added.
  • media/track/opera/interfaces/TextTrackCueList/getter.html: Added.
  • media/track/opera/interfaces/TextTrackCueList/length-expected.txt: Added.
  • media/track/opera/interfaces/TextTrackCueList/length.html: Added.
  • media/track/opera/interfaces/TextTrackList/getter.html: Added.
  • media/track/opera/interfaces/TextTrackList/length-expected.txt: Added.
  • media/track/opera/interfaces/TextTrackList/length.html: Added.
  • media/track/opera/interfaces/TextTrackList/onaddtrack-expected.txt: Added.
  • media/track/opera/interfaces/TextTrackList/onaddtrack.html: Added.
  • media/track/opera/interfaces/TextTrackList/onremovetrack.html: Added.
  • media/track/opera/interfaces/TrackEvent/constructor.html: Added.
  • media/track/opera/interfaces/TrackEvent/createEvent.html: Added.
  • media/track/opera/resources/WebIDLParser.js: Added.

(window.WebIDLParser):
(window.WebIDLParser.):

  • media/track/opera/resources/idlharness.js: Added.

(.):

  • media/track/opera/resources/media/sunflower.mp4: Added.
  • media/track/opera/resources/media/sunflower.webm: Added.
  • media/track/opera/track/track-element/cloneNode.html: Added.
  • media/track/opera/track/track-element/src-clear-cues.html: Added.
  • media/track/opera/track/webvtt/parsing-cue-data/buildtests.py: Added.

(appendtest):

  • media/track/opera/track/webvtt/parsing-cue-data/common.js: Added.

(format):
(test_serializer):
(.if):
(print_diffs):
(runTests.tests.forEach):
(runTests):
(trackError):
(removeElm):

  • media/track/opera/track/webvtt/parsing-cue-data/dat/entities.dat: Added.
  • media/track/opera/track/webvtt/parsing-cue-data/dat/tags.dat: Added.
  • media/track/opera/track/webvtt/parsing-cue-data/dat/timestamps.dat: Added.
  • media/track/opera/track/webvtt/parsing-cue-data/dat/tree-building.dat: Added.
  • media/track/opera/track/webvtt/parsing-cue-data/tests/entities.html: Added.
  • media/track/opera/track/webvtt/parsing-cue-data/tests/tags.html: Added.
  • media/track/opera/track/webvtt/parsing-cue-data/tests/timestamps.html: Added.
  • media/track/opera/track/webvtt/parsing-cue-data/tests/tree-building.html: Added.
  • media/track/opera/track/webvtt/parsing/001.html: Added.
  • media/track/opera/track/webvtt/parsing/support/.htaccess: Added.
  • media/track/opera/track/webvtt/parsing/support/arrows.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/cue-counts.json: Added.
  • media/track/opera/track/webvtt/parsing/support/header-garbage.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/header-space.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/header-tab.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/header-timings.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/ids.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/newlines.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/no-signature.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/nulls.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/omitted-hours.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/settings-align.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/settings-line.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/settings-multiple.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/settings-position.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/settings-size.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/settings-vertical.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/signature-bom.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/signature-formfeed.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/signature-lowercase.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/signature-no-newline.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/signature-null.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/signature-space-no-newline.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/signature-space.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/signature-tab-no-newline.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/signature-tab.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/signature-timings.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/signature-too-short.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/signature-two-boms.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/signature-websrt.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/space-chars.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/timings-60.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/timings-garbage.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/timings-negative.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/timings-too-long.vtt: Added.
  • media/track/opera/track/webvtt/parsing/support/timings-too-short.vtt: Added.
  • media/track/opera/track/webvtt/rendering/adhoc/12345_timestamps.html: Added.
  • media/track/opera/track/webvtt/rendering/adhoc/cue_font_size_transition.html: Added.
  • media/track/opera/track/webvtt/rendering/adhoc/support/12345_timestamps.vtt: Added.
  • media/track/opera/track/webvtt/rendering/adhoc/support/class.vtt: Added.
  • media/track/opera/track/webvtt/rendering/adhoc/support/voice_with_evil_timestamp.vtt: Added.
  • media/track/opera/track/webvtt/rendering/adhoc/voice_with_evil_timestamp.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/2_cues_overlapping_completely_move_up-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/2_cues_overlapping_completely_move_up.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/2_cues_overlapping_partially_move_down-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/2_cues_overlapping_partially_move_down.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/2_cues_overlapping_partially_move_up-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/2_cues_overlapping_partially_move_up.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/2_tracks-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/2_tracks.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/3_tracks-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/3_tracks.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/align_end-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/align_end.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/align_end_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/align_end_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_50-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_50.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_gt_50-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_gt_50.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50_size_gt_maximum_size-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50_size_gt_maximum_size.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/align_start-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/align_start.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/align_start_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/align_start_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/audio_has_no_subtitles-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/audio_has_no_subtitles.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/basic-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/basic.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/bidi/bidi_ruby-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/bidi/bidi_ruby.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/bidi/u002E_LF_u05D0-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/bidi/u002E_LF_u05D0.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/bidi/u002E_u2028_u05D0-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/bidi/u002E_u2028_u05D0.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/bidi/u002E_u2029_u05D0-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/bidi/u002E_u2029_u05D0.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/bidi/u0041_first-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/bidi/u0041_first.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/bidi/u05D0_first-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/bidi/u05D0_first.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/bidi/u0628_first-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/bidi/u0628_first.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/bidi/u06E9_no_strong_dir-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/bidi/u06E9_no_strong_dir.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/build-manifest.py: Added.
  • media/track/opera/track/webvtt/rendering/reftest/cue_too_long-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/cue_too_long.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/decode_escaped_entities-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/decode_escaped_entities.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/disable_controls_reposition-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/disable_controls_reposition.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size_while_paused-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size_while_paused.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_line-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_line.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text_while_paused-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text_while_paused.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_remove_cue_while_paused-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_remove_cue_while_paused.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/enable_controls_reposition-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/enable_controls_reposition.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/evil/9_cues_overlapping_completely-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/evil/9_cues_overlapping_completely.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/evil/9_cues_overlapping_completely_all_cues_have_same_timestamp-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/evil/9_cues_overlapping_completely_all_cues_have_same_timestamp.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/evil/media_404_omit_subtitles-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/evil/media_404_omit_subtitles.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/evil/media_height_19-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/evil/media_height_19.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/evil/single_quote-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/evil/single_quote.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/evil/size_90-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/evil/size_90.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/evil/size_99-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/evil/size_99.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/evil/support/9_cues_overlapping_completely.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/evil/support/9_cues_overlapping_completely_all_cues_have_same_timestamp.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/evil/support/single_quote.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/evil/support/size_90.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/evil/support/size_99.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/evil/support/test.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/line_-2_wrapped_cue_grow_upwards-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/line_-2_wrapped_cue_grow_upwards.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/line_0_is_top-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/line_0_is_top.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/line_1_wrapped_cue_grow_downwards-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/line_1_wrapped_cue_grow_downwards.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/line_50_percent-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/line_50_percent.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/line_integer_and_percent_mixed_overlap-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/line_integer_and_percent_mixed_overlap.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/line_integer_and_percent_mixed_overlap_move_up-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/line_integer_and_percent_mixed_overlap_move_up.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/line_percent_and_integer_mixed_overlap-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/line_percent_and_integer_mixed_overlap.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/line_percent_and_integer_mixed_overlap_move_up-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/line_percent_and_integer_mixed_overlap_move_up.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/media/background.gif: Added.
  • media/track/opera/track/webvtt/rendering/reftest/media/white.mp4: Added.
  • media/track/opera/track/webvtt/rendering/reftest/media/white.webm: Added.
  • media/track/opera/track/webvtt/rendering/reftest/media_height400_with_controls-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/media_height400_with_controls.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/media_with_controls-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/media_with_controls.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/navigate_cue_position-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/navigate_cue_position.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/one_line_cue_plus_wrapped_cue-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/one_line_cue_plus_wrapped_cue.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/reftest.list: Added.
  • media/track/opera/track/webvtt/rendering/reftest/repaint-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/repaint.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/background_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/background_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/background_shorthand-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/background_shorthand.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/background_shorthand_css_relative_url-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/background_shorthand_css_relative_url.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/color_hex-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/color_hex.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/color_hsla-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/color_hsla.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/color_rgba-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/color_rgba.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/cue_selector_single_colon-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/cue_selector_single_colon.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/font_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/font_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/font_shorthand-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/font_shorthand.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/inherit_values_from_media_element-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/inherit_values_from_media_element.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/outline_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/outline_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/outline_shorthand-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/outline_shorthand.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/text-decoration_line-through-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/text-decoration_line-through.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/text-decoration_overline-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/text-decoration_overline.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/text-decoration_overline_underline_line-through-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/text-decoration_overline_underline_line-through.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/text-decoration_underline-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/text-decoration_underline.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/text-shadow-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/text-shadow.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/white-space_normal_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/white-space_normal_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/white-space_nowrap_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/white-space_nowrap_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/white-space_pre-line_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/white-space_pre-line_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/white-space_pre-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/white-space_pre-wrap_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/white-space_pre-wrap_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/white-space_pre.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/white-space_pre_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue/white-space_pre_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/background_box-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/background_box.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/background_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/background_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/background_shorthand-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/background_shorthand.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/background_shorthand_css_relative_url-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/background_shorthand_css_relative_url.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_animation_with_timestamp-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_animation_with_timestamp.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_background_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_background_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_background_shorthand-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_background_shorthand.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_color-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_color.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_font_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_font_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_font_shorthand-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_font_shorthand.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_namespace-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_namespace.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_outline_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_outline_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_outline_shorthand-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_outline_shorthand.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_text-decoration_line-through-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_text-decoration_line-through.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_text-shadow-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_text-shadow.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_timestamp_future-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_timestamp_future.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_timestamp_past-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_timestamp_past.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_transition_with_timestamp-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_transition_with_timestamp.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_white-space_normal_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_white-space_normal_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_white-space_nowrap-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_white-space_nowrap.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_white-space_pre-line_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_white-space_pre-line_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_white-space_pre-wrap_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_white-space_pre-wrap_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_white-space_pre_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_white-space_pre_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_with_class-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_with_class.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_with_class_object_specific_selector-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/bold_object/bold_with_class_object_specific_selector.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_animation_with_timestamp-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_animation_with_timestamp.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_background_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_background_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_background_shorthand-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_background_shorthand.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_color-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_color.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_font_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_font_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_font_shorthand-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_font_shorthand.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_namespace-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_namespace.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_outline_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_outline_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_outline_shorthand-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_outline_shorthand.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_text-decoration_line-through-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_text-decoration_line-through.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_text-shadow-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_text-shadow.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_timestamp_future-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_timestamp_future.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_timestamp_past-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_timestamp_past.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_transition_with_timestamp-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_transition_with_timestamp.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_white-space_normal_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_white-space_normal_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_white-space_nowrap-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_white-space_nowrap.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_white-space_pre-line_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_white-space_pre-line_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_white-space_pre-wrap_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_white-space_pre-wrap_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_white-space_pre_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_white-space_pre_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_with_class-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_with_class.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_with_class_object_specific_selector-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/class_object/class_with_class_object_specific_selector.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/color_hex-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/color_hex.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/color_hsla-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/color_hsla.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/color_rgba-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/color_rgba.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/cue_func_selector_single_colon-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/cue_func_selector_single_colon.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/font_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/font_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/font_shorthand-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/font_shorthand.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/id_color-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/id_color.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/inherit_values_from_media_element-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/inherit_values_from_media_element.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_animation_with_timestamp-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_animation_with_timestamp.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_background_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_background_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_background_shorthand-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_background_shorthand.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_color-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_color.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_font_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_font_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_font_shorthand-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_font_shorthand.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_namespace-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_namespace.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_outline_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_outline_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_outline_shorthand-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_outline_shorthand.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_text-decoration_line-through-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_text-decoration_line-through.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_text-shadow-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_text-shadow.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_timestamp_future-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_timestamp_future.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_timestamp_past-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_timestamp_past.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_transition_with_timestamp-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_transition_with_timestamp.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_white-space_normal_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_white-space_normal_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_white-space_nowrap-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_white-space_nowrap.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_white-space_pre-line_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_white-space_pre-line_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_white-space_pre-wrap_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_white-space_pre-wrap_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_white-space_pre_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_white-space_pre_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_with_class-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_with_class.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_with_class_object_specific_selector-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/italic_object/italic_with_class_object_specific_selector.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/not_allowed_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/not_allowed_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/not_root_selector-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/not_root_selector.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/outline_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/outline_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/outline_shorthand-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/outline_shorthand.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/root_namespace-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/root_namespace.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/root_selector-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/root_selector.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/text-decoration_line-through-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/text-decoration_line-through.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/text-decoration_overline-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/text-decoration_overline.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/text-decoration_overline_underline_line-through-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/text-decoration_overline_underline_line-through.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/text-decoration_underline-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/text-decoration_underline.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/text-shadow-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/text-shadow.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/type_selector_root-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/type_selector_root.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_animation_with_timestamp-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_animation_with_timestamp.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_background_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_background_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_background_shorthand-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_background_shorthand.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_color-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_color.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_font_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_font_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_font_shorthand-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_font_shorthand.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_namespace-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_namespace.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_outline_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_outline_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_outline_shorthand-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_outline_shorthand.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_text-decoration_line-through-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_text-decoration_line-through.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_text-shadow-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_text-shadow.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_timestamp_future-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_timestamp_future.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_timestamp_past-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_timestamp_past.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_transition_with_timestamp-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_transition_with_timestamp.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_white-space_normal_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_white-space_normal_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_white-space_nowrap-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_white-space_nowrap.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_white-space_pre-line_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_white-space_pre-line_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_white-space_pre-wrap_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_white-space_pre-wrap_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_white-space_pre_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_white-space_pre_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_with_class-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_with_class.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_with_class_object_specific_selector-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/underline_object/underline_with_class_object_specific_selector.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_animation_with_timestamp-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_animation_with_timestamp.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_background_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_background_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_background_shorthand-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_background_shorthand.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_color-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_color.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_font_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_font_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_font_shorthand-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_font_shorthand.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_namespace-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_namespace.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_outline_properties-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_outline_properties.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_outline_shorthand-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_outline_shorthand.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_text-decoration_line-through-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_text-decoration_line-through.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_text-shadow-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_text-shadow.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_timestamp_future-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_timestamp_future.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_timestamp_past-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_timestamp_past.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_transition_with_timestamp-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_transition_with_timestamp.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_voice_attribute-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_voice_attribute.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_white-space_normal_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_white-space_normal_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_white-space_nowrap-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_white-space_nowrap.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_white-space_pre-line_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_white-space_pre-line_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_white-space_pre-wrap_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_white-space_pre-wrap_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_white-space_pre_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_white-space_pre_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_with_class-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_with_class.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_with_class_object_specific_selector-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/voice_object/voice_with_class_object_specific_selector.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/white-space_normal_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/white-space_normal_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/white-space_nowrap_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/white-space_nowrap_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/white-space_pre-line_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/white-space_pre-line_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/white-space_pre-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/white-space_pre-wrap_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/white-space_pre-wrap_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/white-space_pre.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/white-space_pre_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/cue_function/white-space_pre_wrapped.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/default_styles/bold_object_default_font-style-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/default_styles/bold_object_default_font-style.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/default_styles/inherit_as_default_value_inherits_values_from_media_element-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/default_styles/inherit_as_default_value_inherits_values_from_media_element.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/default_styles/italic_object_default_font-style-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/default_styles/italic_object_default_font-style.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/default_styles/underline_object_default_font-style-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/selectors/default_styles/underline_object_default_font-style.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/size_50-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/size_50.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/2_cues_overlapping_completely_move_up.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/2_cues_overlapping_partially_move_down.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/2_cues_overlapping_partially_move_up.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/align_end.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/align_end_long.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/align_middle.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/align_middle_long.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/align_middle_position_50.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/align_middle_position_gt_50.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/align_middle_position_lt_50.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/align_middle_position_lt_50_size_gt_maximum_size.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/align_start.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/align_start_long.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/bidi_ruby.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/bold_long.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/bold_with_2_timestamps.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/bold_with_timestamp.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/class_long.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/class_with_2_timestamps.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/class_with_timestamp.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/cue_with_id.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/decode_escaped_entities.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/foo.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/foo_c_bar.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/foo_space_space_bar_LF_baz.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/italic_long.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/italic_with_2_timestamps.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/italic_with_timestamp.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/line_-2_long.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/line_0.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/line_1_long.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/line_50_percent.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/line_integer_and_percent_overlap.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/line_integer_and_percent_overlap_move_up.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/line_percent_and_integer_overlap.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/line_percent_and_integer_overlap_move_up.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/one_line_cue_plus_wrapped_cue.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/refTestWait.js: Added.

(takeScreenshot):
(takeScreenshoDelayed):

  • media/track/opera/track/webvtt/rendering/reftest/support/size_50.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/test.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/test_bold.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/test_bold_with_class.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/test_class.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/test_class_with_class.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/test_italic.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/test_italic_with_class.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/test_long.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/test_two_voices.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/test_underline.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/test_underline_with_class.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/test_voice.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/test_voice_with_class.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/too_many_cues.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/too_many_cues_wrapped.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/u002E_LF_u05D0.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/u002E_u2028_u05D0.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/u002E_u2029_u05D0.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/u0041_first.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/u05D0_first.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/u0628_first.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/u06E9_no_strong_dir.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/underline_long.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/underline_with_2_timestamps.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/underline_with_timestamp.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/very_long_cue.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/voice_long.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/voice_with_2_timestamps.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/voice_with_timestamp.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/white-spaces.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/white-spaces_long.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/support/white-spaces_long_size_20.vtt: Added.
  • media/track/opera/track/webvtt/rendering/reftest/too_many_cues-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/too_many_cues.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/too_many_cues_wrapped-ref.html: Added.
  • media/track/opera/track/webvtt/rendering/reftest/too_many_cues_wrapped.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
5:02 PM Changeset in webkit [136458] by tony@chromium.org
  • 8 edits in trunk/LayoutTests

Unreviewed, add Chromium GTK+ baselines after r136409 (mathml sup/sub box changes).

  • platform/gtk/TestExpectations:
  • platform/gtk/mathml/presentation/roots-expected.txt:
  • platform/gtk/mathml/presentation/row-alignment-expected.txt:
  • platform/gtk/mathml/presentation/sub-expected.txt:
  • platform/gtk/mathml/presentation/subsup-expected.txt:
  • platform/gtk/mathml/presentation/sup-expected.txt:
  • platform/gtk/mathml/presentation/tables-expected.txt:
4:58 PM Changeset in webkit [136457] by tony@chromium.org
  • 27 edits
    2 copies
    1 move
    2 adds
    7 deletes in trunk/LayoutTests

Unreviewed, add Chromium Win/Mac baselines after r136409 (mathml sup/sub box changes).

  • platform/chromium-mac-lion/mathml/presentation/row-alignment-expected.txt: Removed.
  • platform/chromium-mac-lion/mathml/presentation/sub-expected.txt: Added.
  • platform/chromium-mac-lion/mathml/presentation/subsup-expected.txt: Removed.
  • platform/chromium-mac-lion/mathml/presentation/sup-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/mathml/presentation/sup-expected.txt.
  • platform/chromium-mac-lion/mathml/presentation/tables-expected.txt:
  • platform/chromium-mac-snowleopard/mathml/presentation/roots-expected.txt:
  • platform/chromium-mac-snowleopard/mathml/presentation/row-alignment-expected.txt:
  • platform/chromium-mac-snowleopard/mathml/presentation/sub-expected.txt:
  • platform/chromium-mac-snowleopard/mathml/presentation/subsup-expected.txt:
  • platform/chromium-mac-snowleopard/mathml/presentation/sup-expected.txt:
  • platform/chromium-mac-snowleopard/mathml/presentation/tables-expected.txt:
  • platform/chromium-mac/mathml/presentation/roots-expected.txt: Renamed from LayoutTests/platform/chromium/mathml/presentation/roots-expected.txt.
  • platform/chromium-mac/mathml/presentation/row-alignment-expected.txt:
  • platform/chromium-mac/mathml/presentation/sub-expected.txt: Added.
  • platform/chromium-mac/mathml/presentation/subsup-expected.txt:
  • platform/chromium-mac/mathml/presentation/sup-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/mathml/presentation/sup-expected.txt.
  • platform/chromium-mac/mathml/presentation/tables-expected.txt:
  • platform/chromium-win-xp/mathml/presentation/roots-expected.txt:
  • platform/chromium-win-xp/mathml/presentation/row-alignment-expected.txt:
  • platform/chromium-win-xp/mathml/presentation/sub-expected.txt:
  • platform/chromium-win-xp/mathml/presentation/subsup-expected.txt:
  • platform/chromium-win-xp/mathml/presentation/sup-expected.txt:
  • platform/chromium-win-xp/mathml/presentation/tables-expected.txt:
  • platform/chromium-win/mathml/presentation/roots-expected.txt:
  • platform/chromium-win/mathml/presentation/row-alignment-expected.txt:
  • platform/chromium-win/mathml/presentation/sub-expected.txt:
  • platform/chromium-win/mathml/presentation/subsup-expected.txt:
  • platform/chromium-win/mathml/presentation/sup-expected.txt:
  • platform/chromium-win/mathml/presentation/tables-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/chromium/mathml/presentation/row-alignment-expected.txt: Removed.
  • platform/chromium/mathml/presentation/subsup-expected.txt: Removed.
4:42 PM Changeset in webkit [136456] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Disable WebKit2 API tests on Apple Windows port.
https://bugs.webkit.org/show_bug.cgi?id=103929.

Reviewed by Timothy Horton.

  • Scripts/run-api-tests:

(runTestsBySuite):

4:34 PM Changeset in webkit [136455] by yurys@chromium.org
  • 2 edits in trunk/Source/WebKit/mac

Unreviewed. Fix Mac compilation after r136448.

  • WebCoreSupport/WebChromeClient.mm:

(stringForMessageType):

4:22 PM Changeset in webkit [136454] by Lucas Forschler
  • 7 edits in tags/Safari-537.20.1/Source/WebCore

Merged r136449. <rdar://problem/12792802>

4:11 PM Changeset in webkit [136453] by pierre.rossi@gmail.com
  • 3 edits in trunk/Source/WebCore

[Qt] Unreviewed build fix after r136410

When building without libjpeg, take JPEGImageDecoder's header out, since it now includes libjpeg.h.

  • Target.pri: conditionally add JPEGImageDecoder.h to HEADERS
  • platform/image-decoders/ImageDecoder.cpp: guard JPEGImageDecoder.h's include
4:04 PM Changeset in webkit [136452] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL][Qt][WK2] Fixed position elements are not always fixed
https://bugs.webkit.org/show_bug.cgi?id=103452

Reviewed by Simon Fraser.

The code figuring out whether fixed position layers are inside
the visible viewport, assumes that the visible viewport is always
the size of the layout viewport. This assumption doesn't hold with
how the Qt and EFL tiled backing store and coordinated graphics
works, so instead using the visibleContentsRect(), which provides
the right values in all cases.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

Use visibleContentsRect instead of scrollOffsetForFixedPosition().

scrollOffsetForFixedPosition() is needed sometimes in the Mac code
because visibleContentRect() will return negative offsets when you
are in the rubber-band phase of a scroll on the Mac.

However that is not an issue here.

4:04 PM Changeset in webkit [136451] by Lucas Forschler
  • 4 edits in tags/Safari-537.20.1/Source

Versioning.

4:00 PM Changeset in webkit [136450] by Lucas Forschler
  • 1 copy in tags/Safari-537.20.1

New Tag.

3:51 PM Changeset in webkit [136449] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r135271.
http://trac.webkit.org/changeset/135271
https://bugs.webkit.org/show_bug.cgi?id=103940

Some user stylesheet API clients broken (Requested by anttik
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-03

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectRulesFromUserStyleSheets):
(WebCore::collectCSSOMWrappers):

  • css/StyleResolver.h:

(StyleResolver):

  • dom/Document.cpp:

(WebCore::Document::setCompatibilityMode):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::pageUserSheet):
(WebCore::DocumentStyleSheetCollection::clearPageUserSheet):
(WebCore::DocumentStyleSheetCollection::updatePageUserSheet):
(WebCore::collectActiveCSSStyleSheetsFromSeamlessParents):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):

  • dom/DocumentStyleSheetCollection.h:

(DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::documentUserStyleSheets):

  • page/Page.cpp:

(WebCore::Page::userStyleSheetLocationChanged):

3:43 PM Changeset in webkit [136448] by caseq@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: make it possible to fliter out messages from console.{time,timeEnd}()
https://bugs.webkit.org/show_bug.cgi?id=103781

Reviewed by Yury Semikhatsky.

  • make console messages produced by console.timeEnd() TimingMessageType & DebugMessageLevel;
  • add console filter for Debug messages;
  • inspector/ConsoleMessage.cpp:

(WebCore::messageTypeValue):

  • inspector/Inspector.json:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::stopTiming):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype.toMessageElement):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.):
(WebInspector.ConsoleView.prototype.filter):

  • inspector/front-end/inspector.css:

(.console-warning-level, .console-error-level, .console-log-level, .console-debug-level):
(.filter-all .console-debug-level, .filter-debug .console-debug-level):
(.filter-all .console-debug-level.repeated-message, .filter-debug .console-debug-level.repeated-message):

  • page/ConsoleTypes.h:
3:42 PM Changeset in webkit [136447] by fsamuel@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Expose removeAttribute in WebElement
https://bugs.webkit.org/show_bug.cgi?id=103780

Reviewed by Darin Fisher.

  • public/WebElement.h:

(WebElement):

  • src/WebElement.cpp:

(WebKit::WebElement::removeAttribute):
(WebKit):

3:33 PM Changeset in webkit [136446] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r136444.
http://trac.webkit.org/changeset/136444
https://bugs.webkit.org/show_bug.cgi?id=103938

broke chromium build (Requested by zhenyao_wfh on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-03

  • Target.pri:
  • platform/image-decoders/ImageDecoder.cpp:
3:11 PM Changeset in webkit [136445] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening on Apple Windows port.

  • platform/win/TestExpectations:
3:11 PM Changeset in webkit [136444] by pierre.rossi@gmail.com
  • 3 edits in trunk/Source/WebCore

[Qt] Unreviewed build fix after r136410

When building without libjpeg, take JPEGImageDecoder's header out, since it now includes libjpeg.h.

  • Target.pri: conditionally add JPEGImageDecoder.h to HEADERS
  • platform/image-decoders/ImageDecoder.cpp: guard JPEGImageDecoder.h's include
3:08 PM Changeset in webkit [136443] by dpranke@chromium.org
  • 5 edits in trunk/Tools

webkitpy's run_webkit_tests should initialize the printer earlier on
https://bugs.webkit.org/show_bug.cgi?id=103661

Reviewed by Eric Seidel.

Initialize the printer before computing the derived options
from the command line arguments, so that we can safely log from
port methods.

Also clean up a few miscellaneous lint warnings.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.path_to_adb):

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.default_child_processes):
(MacPort.sample_process):
(MacPort.start_helper):
(MacPort.stop_helper):
(MacPort.nm_command):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(test_default_child_processes):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(run):
(_set_up_derived_options):

3:07 PM Changeset in webkit [136442] by jpetsovits@rim.com
  • 9 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Refactor the backingstore to swap full geometries.
https://bugs.webkit.org/show_bug.cgi?id=103924
RIM PR 253496

Reviewed by Yong Li.
Internally reviewed by Adam Treat and Arvid Nilsson.

The backingstore had a working split between front and
back state, but it was multilayered and hard to grasp.
This commit cleanly divides the responsibilities of
BackingStoreGeometry and TileBuffer, with the latter
now being able to function on its own without the help
of its geometry. The BackingStoreTile class was an
unnecessary middleman and can be removed wholesale.

A BackingStoreGeometry can now function with null tiles
being assigned to its indices, which enables us to reclaim
tile buffers outside of the visible contents area as back
buffers. This reduces the need to swap and block when the
backingstore size exceeds the contents size, and also lets
us use more tiles for initial rendering after a call to
resetTiles() which is now implemented as swapping in a
geometry with only null buffers.

setBackingStoreRect() was the only function that had to
get a change of behavior. Because we're now constructing
new BackingStoreGeometry objects every time the front
geometry is being exchanged for a new one, it is only
safe to call other functions reliant on the new geometry
after it has been finalized and put in place. Therefore,
updateTilesForScrollOrNotRenderedRegion() takes on the
render queue maintenance tasks that setBackingStoreRect()
had performed previously. It was already doing something
very similar so only few changes to the function were
necessary.

This commit will make subsequent changes to the
backingstore geometry and tile logic a lot easier.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStoreGeometry::isTileCorrespondingToBuffer):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::~BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
(BlackBerry::WebKit::BackingStorePrivate::updateTilesAfterBackingStoreRectChange):
(BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
(BlackBerry::WebKit::BackingStorePrivate::clearRenderedRegion):
(BlackBerry::WebKit::BackingStorePrivate::isCurrentVisibleJob):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::copyPreviousContentsToTileBuffer):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::compositeContents):
(BlackBerry::WebKit::BackingStorePrivate::blitTileRect):
(BlackBerry::WebKit::BackingStorePrivate::tileVisibleContentsRect):
(BlackBerry::WebKit::BackingStorePrivate::resetTiles):
(BlackBerry::WebKit::BackingStorePrivate::updateTiles):
(BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):
(BlackBerry::WebKit::BackingStorePrivate::mapFromTilesToTransformedContents):
(BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles):
(BlackBerry::WebKit::BackingStorePrivate::transformChanged):
(BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
(BlackBerry::WebKit::BackingStoreGeometry::originOfTile):
(BlackBerry::WebKit::BackingStorePrivate::adoptAsFrontState):

  • Api/BackingStore_p.h:

(WebKit):
(BackingStoreGeometry):
(BlackBerry::WebKit::BackingStoreGeometry::tileBufferAt):
(BackingStorePrivate):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

  • Api/WebPage_p.h:

(WebKit):

  • WebKitSupport/BackingStoreTile.cpp:

(BlackBerry::WebKit::TileBuffer::TileBuffer):
(BlackBerry::WebKit::TileBuffer::~TileBuffer):
(BlackBerry::WebKit::TileBuffer::isRendered):
(BlackBerry::WebKit::TileBuffer::nativeBuffer):
(BlackBerry::WebKit::TileBuffer::wasNativeBufferCreated):
(BlackBerry::WebKit::TileBuffer::paintBackground):

  • WebKitSupport/BackingStoreTile.h:

(BlackBerry::WebKit::TileBuffer::lastRenderOrigin):
(BlackBerry::WebKit::TileBuffer::setLastRenderOrigin):
(BlackBerry::WebKit::TileBuffer::lastRenderScale):
(BlackBerry::WebKit::TileBuffer::setLastRenderScale):
(TileBuffer):
(BlackBerry::WebKit::TileBuffer::backgroundPainted):

  • WebKitSupport/SurfacePool.cpp:

(BlackBerry::WebKit::SurfacePool::SurfacePool):
(BlackBerry::WebKit::SurfacePool::size):
(WebKit):
(BlackBerry::WebKit::SurfacePool::initialize):
(BlackBerry::WebKit::SurfacePool::initializeVisibleTileBuffer):
(BlackBerry::WebKit::SurfacePool::hasBackBuffer):
(BlackBerry::WebKit::SurfacePool::takeBackBuffer):
(BlackBerry::WebKit::SurfacePool::addBackBuffer):
(BlackBerry::WebKit::SurfacePool::createBuffers):
(BlackBerry::WebKit::SurfacePool::releaseBuffers):
(BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):

  • WebKitSupport/SurfacePool.h:

(BlackBerry::WebKit::SurfacePool::isActive):
(BlackBerry::WebKit::SurfacePool::isEmpty):
(SurfacePool):
(BlackBerry::WebKit::SurfacePool::visibleTileBuffer):

2:49 PM Changeset in webkit [136441] by dpranke@chromium.org
  • 3 edits in trunk/Tools

webkitpy: autoinstaller is failing on windows
https://bugs.webkit.org/show_bug.cgi?id=103699

Reviewed by Tony Chang.

Attempt to fix the python autoinstaller to work for pylint on win32
again ... it turns out one of the dependent packages contains
a write-protected test file and windows will choke when it tries to move
it into place. Fortunately we can just delete the file prior to
installing it in the final location, but we have to jump through
a couple of hoops to do so.

Also, make sure that we're flattening nested module names like
"logilab/common" into either safe basenames (logilab_common) or
host-specific subdirs (logilab\common) as needed.

  • Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller._url_downloaded_path):
(AutoInstaller._install):
(AutoInstaller.install):

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_pylint):

2:48 PM Changeset in webkit [136440] by xan@webkit.org
  • 3 edits in trunk/LayoutTests

2012-12-03 Xan Lopez <xlopez@igalia.com>

Unreviewed gardening.

Update grid layout tests with proper expected results for cosmetic
debug() changes I did in the previous patch.

  • fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
  • fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
2:20 PM Changeset in webkit [136439] by simonjam@chromium.org
  • 6 edits in trunk/Source/WebCore

[Resource Timing] Record and report initiator
https://bugs.webkit.org/show_bug.cgi?id=103777

Reviewed by Nate Chapin.

This will start populating the Resource Timing buffer with entries. The initiator will be
recorded for each CachedResourceLoader. This should match the next update of the spec.

Tests: http/tests/w3c/webperf/submission/resource-timing

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::beginLoadTimerFired):

  • loader/ResourceLoadNotifier.cpp: Always record timing information if ENABLE(RESOURCE_TIMING).

(WebCore::ResourceLoadNotifier::dispatchWillSendRequest):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::releaseResources): Report the actual resource that called loadDone().

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::loadResource): Record the initiator.
(WebCore::CachedResourceLoader::loadDone): Record the entry in Resource Timing.

  • loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):
(InitiatorInfo):

2:03 PM Changeset in webkit [136438] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
1:59 PM Changeset in webkit [136437] by dpranke@chromium.org
  • 9 edits in trunk/Tools

nrwt: clean up exception propagation / handling for interrupts and early exits
https://bugs.webkit.org/show_bug.cgi?id=103830

Reviewed by Ojan Vafai.

The code for propagating early exits out of the test run was
convoluted and hard to follow. By adjusting the WorkerException to
derive from BaseException rather than Exception (which is a fair
way of representing an error that was really unexpected/unrecoverable
anyway) and pushing the TestRunInterruptedException into the
ResultSummary (which is also fair since it was more of a result
than an exception) this allows us to consolidate and clean up
a bunch of the try/catch logic and pass fewer state flags around.

There are no real functional changes to this patch; there's an
API change in that we stop exporting TestRunInterruptedException
and WorkerException out of the Manager, and the existence of the
MessagePool is now completely hidden.

  • Scripts/webkitpy/common/message_pool.py:

(WorkerException):

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner.run_tests):

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(summarize_results):
(Manager.run):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ResultSummaryTest.summarized_results):

  • Scripts/webkitpy/layout_tests/models/result_summary.py:

(ResultSummary.init):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(run):
(main):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_exception_raised.of):
(MainTest.test_exception_raised):
(MainTest.test_run_force):

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(Testprinter.test_print_unexpected_results.get_unexpected_results):
(Testprinter):

1:48 PM Changeset in webkit [136436] by pierre.rossi@gmail.com
  • 4 edits in trunk/Source/WebKit/qt

[Qt] Unreviewed speculative Windows buildfix.

Somehow it seems messing around with the export macros made some old issues resurface.

  • Api/qwebsettings.cpp:

(qt_networkAccessAllowed):

  • Api/qwebsettings.h:
  • Api/qwebkitglobal.h: fix an obvious blunder from r136394.
1:42 PM Changeset in webkit [136435] by fmalita@chromium.org
  • 4 edits in trunk/Source/WebCore

[Skia] Deferred SkCanvas save()
https://bugs.webkit.org/show_bug.cgi?id=102272

Reviewed by Stephen White.

Implement a lazy save() strategy: instead of delegating to the canvas upfront, defer and
only commit when a clip/matrix mutation is observed.

The patch yields a 1-20% SkCanvas save/restore reduction for heavy pages, with much larger
gains observed for deeply nested SVG content.

No new tests: no behaviour changes, coverage provided by existing tests.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::canvasClip):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore):
(WebCore::PlatformContextSkia::DeferredSaveState::DeferredSaveState):
(PlatformContextSkia::DeferredSaveState):
(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::save):
(WebCore::PlatformContextSkia::saveLayer):
(WebCore::PlatformContextSkia::beginLayerClippedToImage):
(WebCore::PlatformContextSkia::restore):
(WebCore::PlatformContextSkia::applyClipFromImage):

  • platform/graphics/skia/PlatformContextSkia.h:

(PlatformContextSkia):
(WebCore::PlatformContextSkia::realizeSave):
(WebCore):
(WebCore::PlatformContextSkia::canvas):
(WebCore::PlatformContextSkia::clipPath):
(WebCore::PlatformContextSkia::clipRect):
(WebCore::PlatformContextSkia::setMatrix):
(WebCore::PlatformContextSkia::concat):
(WebCore::PlatformContextSkia::rotate):
(WebCore::PlatformContextSkia::scale):
(WebCore::PlatformContextSkia::translate):

1:22 PM Changeset in webkit [136434] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add Qt/SH4 build slave to build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=103384

Patch by Julien BRIANCEAU <jbrianceau@nds.com> on 2012-12-03
Reviewed by Csaba Osztrogonác.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
1:19 PM Changeset in webkit [136433] by Simon Fraser
  • 6 edits
    2 adds in trunk

When animating mask-postion on a composited layer, element renders incorrectly
https://bugs.webkit.org/show_bug.cgi?id=103700

Reviewed by Tim Horton.

Source/WebCore:

When a composited layer has a mask, we clipped the layer bounds to the
size of the mask. This caused problems when animating the mask origin,
which is considered a 'repaint' style change and so should not require
layout or compositing geometry changes.

Fix by ignoring the mask when computing the bounds of the compositing
layer.

Test: compositing/masks/mask-layer-size.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::localBoundingBox):
(WebCore::RenderLayer::calculateLayerBounds):

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::calculateCompositedBounds):

LayoutTests:

Test that dumps the layer tree for a composited layer with a mask.

  • compositing/masks/mask-layer-size-expected.txt: Added.
  • compositing/masks/mask-layer-size.html: Added.
1:07 PM Changeset in webkit [136432] by xan@webkit.org
  • 12 edits
    2 adds in trunk

2012-12-03 Xan Lopez <Xan Lopez>

[CSS Grid Layout] Support <percentage> and viewport-relative breadth sizes
https://bugs.webkit.org/show_bug.cgi?id=103335

Reviewed by Julien Chaffraix.

Test: fast/css-grid-layout/breadth-size-resolution-grid.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForGridTrackBreadth): Support the new types. (WebCore::valueForGridTrackMinMax): Modify the call to previous method, since the signature has changed. (WebCore::valueForGridTrackGroup): Ditto. (WebCore::valueForGridTrackList): Ditto. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.
  • rendering/RenderGrid.cpp: (WebCore::RenderGrid::computedUsedBreadthOfGridTracks): Suport percent and viewport relative types, calc() will be supported in a follow up (see bug #103761)

2012-12-03 Xan Lopez <Xan Lopez>

[CSS Grid Layout] Support <percentage> and viewport-relative breadth sizes
https://bugs.webkit.org/show_bug.cgi?id=103335

Reviewed by Julien Chaffraix.

  • fast/css-grid-layout/breadth-size-resolution-grid-expected.txt: Added.
  • fast/css-grid-layout/breadth-size-resolution-grid.html: Added.
  • fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
  • fast/css-grid-layout/grid-columns-rows-get-set.html:
  • fast/css-grid-layout/percent-grid-item-in-percent-grid-track-expected.txt:
  • fast/css-grid-layout/percent-grid-item-in-percent-grid-track-in-percent-grid-expected.txt:
  • fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:
  • fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
1:05 PM Changeset in webkit [136431] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Web Inspector: make ASSERTION FAILED: foundPropertiesCount == object->size() more useful
https://bugs.webkit.org/show_bug.cgi?id=103254

Patch by Peter Rybin <prybin@chromium.org> on 2012-12-03
Reviewed by Pavel Feldman.

Source/JavaScriptCore:

Missing symbol WTFReportFatalError is added to the linker list.

Source/WebCore:

Assert code generation is slightly changed so that it dumped JSON object text before crashing.

  • inspector/CodeGeneratorInspector.py:
12:56 PM Changeset in webkit [136430] by mvujovic@adobe.com
  • 5 edits
    3 adds in trunk

[CSS Shaders] Do not clamp indirect array indices during CSS Shaders ANGLE validation pass
https://bugs.webkit.org/show_bug.cgi?id=102731

Reviewed by Dean Jackson.

Source/WebCore:

Before this patch, we validated all shaders with the compile flag
SH_CLAMP_INDIRECT_ARRAY_BOUNDS in ANGLEWebKitBridge. This would insert a GLSL function
"webgl_int_clamp" in validated CSS shaders. However, when validated CSS shaders would pass
through ANGLE again at the GC3D level, ANGLE would reject them because they would contain
the "webgl_" restricted prefix.

Now, we only pass the compile flag SH_CLAMP_INDIRECT_ARRAY_BOUNDS at the GC3D level.

Test: css3/filters/custom/custom-filter-array-uniform-indirect-index.html

  • platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::ANGLEWebKitBridge::compileShaderSource):

Remove the SH_CLAMP_INDIRECT_ARRAY_BOUNDS compile flag.

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::compiledProgram):

Add an assert that validated programs compile at the GC3D or platform level to help us
catch validation and rewriting issues.

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

Pass the SH_CLAMP_INDIRECT_ARRAY_BOUNDS to compileShaderSource.

LayoutTests:

Add a vertex shader which indirectly indexes a uniform array. This shader should validate,
compile, and execute properly.

The GLSL ES 1.0 spec [1], Appendix A, Section 5 "Uniforms (excluding samplers)" says:
"In the vertex shader, support for all forms of array indexing is mandated."

[1]: http://www.khronos.org/registry/gles/specs/2.0/GLSL_ES_Specification_1.0.17.pdf

  • css3/filters/custom/custom-filter-array-uniform-indirect-index-expected.html: Added.
  • css3/filters/custom/custom-filter-array-uniform-indirect-index.html: Added.
  • css3/filters/resources/array-indirect-index.vs: Added.
12:45 PM Changeset in webkit [136429] by alexis@webkit.org
  • 2 edits in trunk/Tools

Enable CSS3 background-position offset by default
https://bugs.webkit.org/show_bug.cgi?id=103917

Reviewed by Benjamin Poulain.

Even though each port may enable or not the feature we still need
to pass it at configure time otherwise it will be disabled.

  • Scripts/webkitperl/FeatureList.pm:
12:41 PM Changeset in webkit [136428] by tony@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Performance degradation while rendering MathML content, freezes the tab.
https://bugs.webkit.org/show_bug.cgi?id=102585

Reviewed by Eric Seidel.

Add a regression test for nested fractions. The O(2n) layout time should
be fixed by r136324.

  • mathml/presentation/mfrac-nested-expected.txt: Added.
  • mathml/presentation/mfrac-nested.html: Added.
12:04 PM Changeset in webkit [136427] by alexis@webkit.org
  • 4 edits in trunk

[EFL] Enable CSS3 background-position offsets by default.
https://bugs.webkit.org/show_bug.cgi?id=103879

Reviewed by Laszlo Gombos.

.:

Enable the feature for EFL only.

  • Source/cmake/OptionsEfl.cmake:

LayoutTests:

Enable by default the new CSS3 background position offsets therefore we
can unskip the tests.

  • platform/efl/TestExpectations:
12:04 PM Changeset in webkit [136426] by caseq@chromium.org
  • 12 edits in trunk/Source

Web Inspector: Make main-thread monitoring go through InspectorController
https://bugs.webkit.org/show_bug.cgi?id=103550

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-12-03
Reviewed by Pavel Feldman.

InspectorInstrumentation was a wrong path.

Source/WebCore:

  • inspector/InspectorClient.h: Remove start/stop methods.
  • inspector/InspectorController.cpp:

Dispatch main thread activity notifications.

  • inspector/InspectorController.h: Ditto.
  • inspector/InspectorInstrumentation.cpp: Remove dispatchng.
  • inspector/InspectorInstrumentation.h: Ditto.
  • inspector/InspectorTimelineAgent.cpp:

Do not subscribe for notifications explicitly.

Source/WebKit/chromium:

  • src/InspectorClientImpl.cpp: Remove TaskObserver implementation, and

listen/unlisten methods.

  • src/InspectorClientImpl.h: Ditto.
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::~WebDevToolsAgentImpl):
Unsubscribe for main thread activity events.
(WebKit::WebDevToolsAgentImpl::detach): Ditto.
(WebKit::WebDevToolsAgentImpl::attach):
Subscribe for main thread activity events.
(WebKit::WebDevToolsAgentImpl::willProcessTask): Implement TasObserver
interface. Froward to InspectorController.
(WebKit::WebDevToolsAgentImpl::didProcessTask): Ditto.

  • src/WebDevToolsAgentImpl.h: Implement TasObserver interface.
11:55 AM Changeset in webkit [136425] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.
Fix duplicate test expectations.

  • platform/chromium/TestExpectations:
11:44 AM Changeset in webkit [136424] by pdr@google.com
  • 3 edits
    2 adds in trunk

Source/WebCore: Invalidate SVG width on width attribute changes.
https://bugs.webkit.org/show_bug.cgi?id=103304

Reviewed by Dirk Schulze.

An inline SVG element's replaced width can depend on both attributes and style properties.
After r105513, we invalidated this width on style changes but not attribute changes. With
this patch we invalidate the replaced width on width attribute changes too. Note that height
is handled differently for replaced elements so only the width attribute needs this handling
(the added test covers this too).

Test: svg/custom/root-size-attribute-changes.html

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::svgAttributeChanged):

LayoutTests: Invalidate SVG width on width attribute change.
https://bugs.webkit.org/show_bug.cgi?id=103304

Reviewed by Dirk Schulze.

  • svg/custom/root-size-attribute-changes-expected.html: Added.
  • svg/custom/root-size-attribute-changes.html: Added.
11:36 AM Changeset in webkit [136423] by alecflett@chromium.org
  • 11 edits in trunk/Source

IndexedDB: remove IDBDatabaseBackendInterface::transaction()
https://bugs.webkit.org/show_bug.cgi?id=102733

Reviewed by Darin Fisher.

Source/WebCore:

Part 3 of a refactor, remove the old transaction() method.

No new tests as this is just post-refactor cleanup.

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

Source/WebKit/chromium:

Part 3 of a refactor - just remove the proxy code for the now
defunct transaction method.

  • public/WebIDBDatabase.h:
  • src/IDBDatabaseBackendProxy.cpp:
  • src/IDBDatabaseBackendProxy.h:

(IDBDatabaseBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:
  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • tests/IDBDatabaseBackendTest.cpp:
11:17 AM Changeset in webkit [136422] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

PDFPlugin: <embed> and <object> PDFs affect their parent frame's page scale
https://bugs.webkit.org/show_bug.cgi?id=103286
<rdar://problem/12752315>

Reviewed by Dan Bernstein.

Style fixes after http://trac.webkit.org/changeset/136316.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::isFullFramePlugin):

11:15 AM Changeset in webkit [136421] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Tell WebInputHandlerClient when end of input is reached for current vsync period
https://bugs.webkit.org/show_bug.cgi?id=103648

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-12-03
Reviewed by James Robinson.

Let the WebInputHandlerClient know when we've received the final input event
for the current vsync period.

Test: WebCompositorInputHandlerImplTest.lastInputEventForVSync

Source/Platform:

  • chromium/public/WebInputHandlerClient.h:

(WebKit::WebInputHandlerClient::didReceiveLastInputEventForVSync):
(WebInputHandlerClient):

Source/WebKit/chromium:

  • src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):

11:13 AM Changeset in webkit [136420] by senorblanco@chromium.org
  • 4 edits in trunk

[chromium] Turn on the new Skia mask blur algorithm.
https://bugs.webkit.org/show_bug.cgi?id=103906

Reviewed by Adrienne Walker.

Source/WebKit/chromium:

  • skia_webkit.gyp:

LayoutTests:

  • platform/chromium/TestExpectations:
11:07 AM Changeset in webkit [136419] by arv@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Fix issue with hard coded error codes in quota error
https://bugs.webkit.org/show_bug.cgi?id=103892

Reviewed by Darin Fisher.

Chromium currently hard codes the enum values for QuotaStatusCode. To fix
this we need to do a few iteration of changes. This is the first step and
it exposes the enums that Chromium depends on.

  • public/WebStorageQuotaError.h:
10:59 AM Changeset in webkit [136418] by aandrey@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Canvas] show replay screenshot of the last call's canvas
https://bugs.webkit.org/show_bug.cgi?id=103739

Reviewed by Pavel Feldman.

When many canvases are being instrumented we'll want to show replay screenshots for each canvas.
Meanwhile, show the screenshot of the last-touched canvas during the current replay.

  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

10:58 AM WebKit Team edited by sudarsana.nagineni@linux.intel.com
Added myself to the committers list. (diff)
10:54 AM Changeset in webkit [136417] by jsbell@chromium.org
  • 23 edits in trunk/Source

IndexedDB: Rename exception enum members from UGLY_ERR to PrettyError
https://bugs.webkit.org/show_bug.cgi?id=103759

Reviewed by Darin Fisher.

Source/WebCore:

Now that IDBDatabaseException isn't exposed to script with constants, the exception types
can be renamed to match the much friendlier names used in newer iterations of the spec. Also
remove the legacy/unused types.

No new tests, just constant renames.

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update):
(WebCore::IDBCursor::advance):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::deleteFunction):

  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::continueFunction):
(WebCore::IDBCursorBackendImpl::advance):
(WebCore::IDBCursorBackendImpl::prefetchContinue):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndAbortFired):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::openConnectionWithVersion):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
(WebCore::IDBDatabaseBackendImpl::close):

  • Modules/indexeddb/IDBDatabaseException.cpp: Tidying and renaming.

(WebCore):
(WebCore::getErrorEntry):

  • Modules/indexeddb/IDBDatabaseException.h:
  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::cmp):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::getDatabaseNames):
(WebCore::IDBFactoryBackendImpl::deleteDatabase):
(WebCore::IDBFactoryBackendImpl::open):

  • Modules/indexeddb/IDBIndex.cpp:

(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::count):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::IDBIndexBackendImpl::openKeyCursor):
(WebCore::IDBIndexBackendImpl::count):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):

  • Modules/indexeddb/IDBKeyRange.cpp:

(WebCore::IDBKeyRange::only):
(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):
(WebCore::IDBKeyRange::bound):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):
(WebCore::IDBObjectStore::openCursor):
(WebCore::IDBObjectStore::count):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreStorageOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::clear):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):
(WebCore::IDBObjectStoreBackendImpl::openCursor):
(WebCore::IDBObjectStoreBackendImpl::count):

  • Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::dispatchEvent):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::result):
(WebCore::IDBRequest::error):
(WebCore::IDBRequest::errorCode):
(WebCore::IDBRequest::webkitErrorMessage):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::uncaughtExceptionInEventHandler):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::abort):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::objectStore):
(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::commit):

Source/WebKit/chromium:

Update IDBDatabaseException enum names/values to match WebCore.

  • public/WebIDBDatabaseException.h:
  • src/AssertMatchingEnums.cpp:
  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::allowIndexedDB):

  • tests/IDBRequestTest.cpp:
10:50 AM Changeset in webkit [136416] by tony@chromium.org
  • 6 edits in branches/chromium/1312

Merge 135178

[Chromium] Flash cannot receive scroll events when threaded compositing is in use
https://bugs.webkit.org/show_bug.cgi?id=101423

Patch by Yusuke Sato <yusukes@chromium.org> on 2012-11-19
Reviewed by James Robinson.

Source/WebKit/chromium:

Add setWantsWheelEvents() to Chromium's WebPluginContainer interface so that a plugin can tell the
container that the plugin always wants to handle wheel events even when a scroll bar is not shown.

  • public/WebPluginContainer.h:

(WebPluginContainer):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::setWantsWheelEvents):
(WebKit):
(WebKit::WebPluginContainerImpl::wantsWheelEvents):
(WebKit::WebPluginContainerImpl::WebPluginContainerImpl):

  • src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

Tools:

Call setWantsWheelEvents(true) in initialize() so that gesture-events and transformed-events tests in
LayoutTests/platform/chromium/plugins/ will not fail even if a buildbot introduces threaded compositing
in the future.

  • DumpRenderTree/chromium/TestWebPlugin.cpp:

(TestWebPlugin::initialize):

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11411321

10:46 AM Changeset in webkit [136415] by alexis@webkit.org
  • 11 edits in trunk

[Mac] Enable CSS3 background-position offset by default.
https://bugs.webkit.org/show_bug.cgi?id=103905

Reviewed by Simon Fraser.

Source/JavaScriptCore:

Turn the flag on by default.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Turn the flag on by default.

No new tests : covered by tests landed previously.

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapFillXPosition): Build fix in release on Mac with unused variable.
(WebCore::CSSToStyleMap::mapFillYPosition): Ditto.

Source/WebKit/mac:

Turn the flag on by default.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Turn the flag on by default.

  • Configurations/FeatureDefines.xcconfig:

LayoutTests:

Enable by default the new CSS3 background position offsets therefore we
can unskip the tests.

  • platform/mac/TestExpectations:
10:44 AM Changeset in webkit [136414] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Implement context menus in CodeMirrorTextEditor
https://bugs.webkit.org/show_bug.cgi?id=94062

Patch by Jan Keromnes <janx@linux.com> on 2012-12-03
Reviewed by Pavel Feldman.

Listen for contextmenu events in the editor and handle them differently
if triggered on gutter line number or in text body. This adds controls
for breakpoints (including disabled / conditional), debugger navigation
and text input methods.

  • inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype._contextMenu):

10:42 AM Changeset in webkit [136413] by tasak@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

[style scoped]: style scoped needs more tests.
https://bugs.webkit.org/show_bug.cgi?id=99821

Reviewed by Dimitri Glazkov.

Test cases in this patch validate dynamically creating, moving and
removing a scoped style works well.

  • fast/css/style-scoped/style-scoped-with-dom-operation-expected.txt: Added.
  • fast/css/style-scoped/style-scoped-with-dom-operation.html: Added.
10:23 AM Changeset in webkit [136412] by Nate Chapin
  • 4 edits in trunk/Source/WebCore

Make MainResourceLoader not use m_frame directly.
https://bugs.webkit.org/show_bug.cgi?id=103907

Reviewed by Darin Adler.

MainResourceLoader will soon cease to be a ResourceLoader subclass. It currently
makes extensively use of both m_documentLoader and m_frame from ResourceLoader.
By moving everything over to going through m_documentLoader, we reduce the number
of members we have to add to MainResourceLoader in https://bugs.webkit.org/show_bug.cgi?id=49246.

No new tests, refactor only.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::startLoadingMainResource):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::create):
(WebCore::MainResourceLoader::receivedError):
(WebCore::MainResourceLoader::willSendRequest):
(WebCore::MainResourceLoader::continueAfterContentPolicy):
(WebCore::MainResourceLoader::didReceiveResponse):
(WebCore::MainResourceLoader::didReceiveData):
(WebCore::MainResourceLoader::startDataLoadTimer):

  • loader/MainResourceLoader.h:

(MainResourceLoader):

10:21 AM Changeset in webkit [136411] by commit-queue@webkit.org
  • 3 edits
    2 moves in trunk

Text Autosizing: don't autosize horizontal menu items implemented via floating list items
https://bugs.webkit.org/show_bug.cgi?id=103840

Patch by Anton Vayvod <avayvod@chromium.org> on 2012-12-03
Reviewed by Kenneth Rohde Christiansen.

Floating list items are often used to implement horizontal menus. Currently, text autosizing
disregards such elements as autosizing containers. List items are often then autosized as part
of a bigger cluster (usually the whole page) and look too big.
This change turns floating list items into autosizing clusters so they are autosized separately
resulting in no font size multiplication for menu items implemented in this manner.

Source/WebCore:

Test: fast/text-autosizing/cluster-list-item.html

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::isAutosizingContainer): Returns true for floating list items; split the
condition logically.

LayoutTests:

  • fast/text-autosizing/cluster-list-item-expected.html: Renamed from LayoutTests/fast/text-autosizing/list-item-out-of-flow-expected.html.
  • fast/text-autosizing/cluster-list-item.html: Renamed from LayoutTests/fast/text-autosizing/list-item-out-of-flow.html; added case for a floating list item.
10:18 AM Changeset in webkit [136410] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Optimization in image decoding
https://bugs.webkit.org/show_bug.cgi?id=88424

Patch by Viatcheslav Ostapenko <v.ostapenko@samsung.com> on 2012-12-03
Reviewed by Brent Fulgham.

Replace int with J_COLOR_SPACE in parameters of templates setPixel and
outputScanlines to avoid casting from int to enum. It required move
inclusion of jpeglib.h and related #if to JPEGImageDecoder.h .

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore):
(WebCore::setPixel):
(WebCore::JPEGImageDecoder::outputScanlines):

  • platform/image-decoders/jpeg/JPEGImageDecoder.h:

(JPEGImageDecoder):

10:12 AM Changeset in webkit [136409] by tony@chromium.org
  • 14 edits
    2 adds in trunk

[mathml] Improve performance of nested sup or sub elements
https://bugs.webkit.org/show_bug.cgi?id=103665

Reviewed by Darin Adler.

Source/WebCore:

Reduce the number of extra layouts. Since RenderMathMLSubSup calls
layout twice, this can lead to an exponential number of layouts. Avoid
extra layouts.

Test: mathml/presentation/sup-nested.html - Should not time out.

  • css/mathml.css:

(msup): Stretching children also causes extra layouts. Avoid this by aligning to the top.
(msub): Same as msup, but align to the bottom.

  • rendering/mathml/RenderMathMLSubSup.cpp:

(WebCore::RenderMathMLSubSup::layout): Only do the second layout if the padding changed.
Also fix up the calls to setNeedsLayout (since we're calling it on this) and
setChildNeedsLayout (since we're calling it on a child).

LayoutTests:

Update Chromium Linux baselines and mark tests as failing on other platforms.
The mathml.css change causes these pixel results changes. This doesn't change
the pixel results, it is only a change to the render tree. The render boxes
should more tightly wrap the superscripts and subscripts but be positioned
in the same place.

  • mathml/presentation/sup-nested-expected.txt: Added.
  • mathml/presentation/sup-nested.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/chromium-linux/mathml/presentation/roots-expected.txt:
  • platform/chromium-linux/mathml/presentation/row-alignment-expected.txt:
  • platform/chromium-linux/mathml/presentation/sub-expected.txt:
  • platform/chromium-linux/mathml/presentation/subsup-expected.txt:
  • platform/chromium-linux/mathml/presentation/sup-expected.txt:
  • platform/chromium-linux/mathml/presentation/tables-expected.txt:
9:54 AM Changeset in webkit [136408] by kpiascik@rim.com
  • 4 edits in trunk/Source/WebCore

Web Inspector: free Page resources on inspector disconnect
https://bugs.webkit.org/show_bug.cgi?id=103888

Reviewed by Yury Semikhatsky.

We don't need to keep the page around and can free up memory when disconnecting web inspector.

Not testable.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::disconnectFrontend):

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::freePage):
(WebCore):

  • inspector/InspectorOverlay.h:

(InspectorOverlay):

9:48 AM Changeset in webkit [136407] by alexis@webkit.org
  • 6 edits in trunk

[GTK] Enable CSS3 background-background position offset by default.
https://bugs.webkit.org/show_bug.cgi?id=103903

Reviewed by Philippe Normand.

.:

Turn on the flag by default.

  • configure.ac:

Source/WebCore:

Turn the feature on by default.

No new tests : covered by tests already landed.

  • GNUmakefile.features.am:

LayoutTests:

Enable by default the new CSS3 background position offsets therefore we
can unskip the tests.

  • platform/gtk/TestExpectations:
9:37 AM Changeset in webkit [136406] by sudarsana.nagineni@linux.intel.com
  • 2 edits in trunk/Tools

Unreviewed. Adding myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
9:06 AM Changeset in webkit [136405] by morrita@google.com
  • 3 edits
    4 adds in trunk

Corrupted DOM tree during appendChild/insertBefore
https://bugs.webkit.org/show_bug.cgi?id=103601

Reviewed by Abhishek Arya.

Source/WebCore:

There are some missing protection in appendChild() and insertBefore().
This change added these.

Dromaeo dom-modify shows no speed regression (5445run/s before vs 5351run/s after)

Tests: fast/events/mutation-during-append-child.html

fast/events/mutation-during-insert-before.html

  • dom/ContainerNode.cpp:

(WebCore::checkAcceptChildGuaranteedNodeTypes):
(WebCore):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::appendChild):

LayoutTests:

  • fast/events/mutation-during-append-child-expected.txt: Added.
  • fast/events/mutation-during-append-child.html: Added.
  • fast/events/mutation-during-insert-before-expected.txt: Added.
  • fast/events/mutation-during-insert-before.html: Added.
9:01 AM Changeset in webkit [136404] by jocelyn.turcotte@digia.com
  • 5 edits in trunk/Source

Document::initSecurityContext() fails to call securityOrigin().grantLoadLocalResources()
https://bugs.webkit.org/show_bug.cgi?id=68711

Reviewed by Adam Barth.

Source/WebCore:

It currently fails since Document::loader() will return 0 until
Frame::setDocument is called and we are doing this check before it happens.

Delay the check and let the FrameLoader take care of doing grantLoadLocalResources()
on the Document along with other header checks in FrameLoader::didBeginDocument.

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

Source/WebKit/qt:

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::testStopScheduledPageRefresh): Unmark the expected failure.

8:25 AM Changeset in webkit [136403] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[GTK][EFL] Gardening for media/video-volume.html
https://bugs.webkit.org/show_bug.cgi?id=103894

Unreviewed gardening: media/video-volume.html fails with
gstreamer.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-12-03

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
7:49 AM Changeset in webkit [136402] by ryuan.choi@samsung.com
  • 9 edits in trunk/Source/WebKit2

[EFL][WK2] Add contents,size,changed signal to the ewk_view API
https://bugs.webkit.org/show_bug.cgi?id=103094

Reviewed by Kenneth Rohde Christiansen.

This patch emits signal to let applications know contents size.
Applications can use this signal to give some additional behavior such as
minimap, external scroll for quick movement.

  • UIProcess/API/efl/EwkViewCallbacks.h: Added contents,size,changed signal.
  • UIProcess/API/efl/EwkViewImpl.cpp: Removed dead code.
  • UIProcess/API/efl/EwkViewImpl.h: Ditto.

(EwkViewImpl):

  • UIProcess/API/efl/ewk_view.h: Added test case.
  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(onContentsSizeChanged):
(TEST_F):

  • UIProcess/efl/PageClientDefaultImpl.cpp: Emitted contents,size,changed signal.

(WebKit::PageClientDefaultImpl::didChangeContentsSize):

  • UIProcess/efl/PageClientLegacyImpl.cpp: Ditto.

(WebKit::PageClientLegacyImpl::didChangeContentsSize):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):
Sended DidChangeContentsSize message although TILED_BACKINGSTORE is disabled.

7:48 AM Changeset in webkit [136401] by yoli@rim.com
  • 2 edits in trunk/Source/WebCore

ENABLE(IMAGE_DECODER_DOWN_SAMPLING): Should use TURBO_JPEG_RGB_SWIZZLE fast path for non-scaled images
https://bugs.webkit.org/show_bug.cgi?id=103749

Reviewed by Rob Buis.

Replace !ENABLE(IMAGE_DECODER_DOWN_SAMPLING) with !m_scaled.

No new tests as existing jpegs are good with IMAGE_DECODER_DOWN_SAMPLING set up.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::outputScanlines):

7:42 AM Changeset in webkit [136400] by commit-queue@webkit.org
  • 4 edits in trunk

[BlackBerry] Enable HIDDEN_PAGE_DOM_TIMER_THROTTLING
https://bugs.webkit.org/show_bug.cgi?id=103842

Patch by Cosmin Truta <ctruta@rim.com> on 2012-12-03
Reviewed by Yong Li.

.:

Set ENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING to ON.

  • Source/cmake/OptionsBlackBerry.cmake:

Source/WebKit/blackberry:

Add HIDDEN_PAGE_DOM_TIMER_THROTTLING.

  • WebCoreSupport/AboutDataEnableFeatures.in:
7:36 AM EFLWebKit edited by laszlo.gombos@gmail.com
Document the possibility of building WebKit2-only - see … (diff)
7:25 AM Changeset in webkit [136399] by Csaba Osztrogonác
  • 11 edits in trunk/Source/WebKit2

Unreviewed fix after r136292 to make GIT-SVN repositories happy.

  • win/WebKit2ExportGenerator.vcproj: Added property svn:eol-style.
  • win/WebKit2ExportGeneratorCommon.vsprops: Added property svn:eol-style.
  • win/WebKit2ExportGeneratorDebug.vsprops: Added property svn:eol-style.
  • win/WebKit2ExportGeneratorDebugAll.vsprops: Added property svn:eol-style.
  • win/WebKit2ExportGeneratorDebugCairoCFLite.vsprops: Added property svn:eol-style.
  • win/WebKit2ExportGeneratorPostBuild.cmd: Added property svn:eol-style.
  • win/WebKit2ExportGeneratorPreBuild.cmd: Added property svn:eol-style.
  • win/WebKit2ExportGeneratorProduction.vsprops: Added property svn:eol-style.
  • win/WebKit2ExportGeneratorRelease.vsprops: Added property svn:eol-style.
  • win/WebKit2ExportGeneratorReleaseCairoCFLite.vsprops: Added property svn:eol-style.
7:20 AM Changeset in webkit [136398] by commit-queue@webkit.org
  • 5 edits in trunk

[CMake] Enable building WebKit2-only build for the EFL port
https://bugs.webkit.org/show_bug.cgi?id=103820

Patch by Laszlo Gombos <Laszlo Gombos> on 2012-12-03
Reviewed by Gyuyoung Kim.

.:

To create a WebKit2-only build for EFL use the following command:
build-webkit --efl --cmakeargs="-DENABLE_WEBKIT=OFF".

  • CMakeLists.txt: Turn on WebKit1 support if it is not explicitly set (enabled or disabled) for

all CMake based ports.

  • Source/cmake/OptionsEfl.cmake: Enable WebKit2

for the EFL port if it is not explicitly set (enabled or disabled).

Tools:

Set ENABLE_WEBKIT2 to OFF if build-webkit was run with --no-webkit2.
Never set ENABLE_WEBKIT in build-webkit. This will simplyfy invoking
cmake directly. Initialize $cmakeArgs to avoid potential
warnings when running the script.

  • Scripts/build-webkit:
7:18 AM Changeset in webkit [136397] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed Qt gardening.

Remove image expectation for tests that now pass.

  • platform/qt-5.0-wk2/TestExpectations:
7:04 AM Changeset in webkit [136396] by schenney@chromium.org
  • 2 edits
    2 adds
    1 delete in trunk/LayoutTests

[Chromium] Expectations fix up

Unreviewed expectations.

Two tests appear to have been out-of-date when they were last rebaselined.

  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/shadows: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-win-xp/svg/carto.net: Removed.
  • platform/chromium-win-xp/svg/carto.net/colourpicker-expected.png: Removed.
  • platform/chromium-win/svg/carto.net/colourpicker-expected.png:
7:00 AM Changeset in webkit [136395] by kbalazs@webkit.org
  • 2 edits
    1 add
    10 deletes in trunk/LayoutTests

svg/custom/baseval-animval-equality.svg should use dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=103873

Reviewed by Dirk Schulze.

Turn it to a dumpAsText test.

  • platform/chromium-mac-lion/svg/custom/baseval-animval-equality-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/svg/custom/baseval-animval-equality-expected.txt: Removed.
  • platform/chromium-mac/svg/custom/baseval-animval-equality-expected.txt: Removed.
  • platform/chromium-win/svg/custom/baseval-animval-equality-expected.txt: Removed.
  • platform/chromium/svg/custom/baseval-animval-equality-expected.txt: Removed.
  • platform/gtk/svg/custom/baseval-animval-equality-expected.txt: Removed.
  • platform/mac-lion/svg/custom/baseval-animval-equality-expected.txt: Removed.
  • platform/mac-wk2/svg/custom/baseval-animval-equality-expected.txt: Removed.
  • platform/mac/svg/custom/baseval-animval-equality-expected.txt: Removed.
  • platform/qt/svg/custom/baseval-animval-equality-expected.txt: Removed.
  • svg/custom/baseval-animval-equality-expected.txt: Added.
  • svg/custom/baseval-animval-equality.svg:
6:52 AM Changeset in webkit [136394] by pierre.rossi@gmail.com
  • 9 edits in trunk/Source/WebKit/qt

[Qt] Use a separate QWEBKITWIDGETS_EXPORT macro for WebKitWidgets
https://bugs.webkit.org/show_bug.cgi?id=103844

Patch by Pierre Rossi <pierre.rossi@digia.com> on 2012-12-03
Reviewed by Simon Hausmann.

Let's follow the common practice and have one export macro per library.
We can't rely on BUILDING_WEBKIT anymore in that case, so we use the
qmake defines instead.

  • Api/qwebkitglobal.h: Updated the import/export logic.
  • WidgetApi/qgraphicswebview.h: s/QWEBKIT/QWEBKITWIDGETS/
  • WidgetApi/qwebframe.h: Ditto.
  • WidgetApi/qwebinspector.h: Ditto.
  • WidgetApi/qwebpage.h: Ditto.
  • WidgetApi/qwebview.h: Ditto.
  • WidgetSupport/InitWebKitQt.cpp:

(WebKit::initializeWebKitWidgets): use QWEBKITWIDGETS_EXPORT.

  • WidgetSupport/InitWebKitQt.h:

(WebKit): Ditto.

6:28 AM Changeset in webkit [136393] by arv@chromium.org
  • 3 edits in trunk/LayoutTests

Update Acid3 test to the latest version
https://bugs.webkit.org/show_bug.cgi?id=102943

Reviewed by Ojan Vafai.

The Acid3 test has been updated to not break when browsers starts to implement new
standards. This updates our copy of the Acid3 test.

  • fast/dom/Range/acid3-surround-contents.html:
  • http/tests/misc/acid3.html:
6:27 AM Changeset in webkit [136392] by tommyw@google.com
  • 23 edits
    3 deletes in trunk

Speech Recognition API: Update SpeechRecognitionEvent to match the specification
https://bugs.webkit.org/show_bug.cgi?id=103407

Reviewed by Kentaro Hara.

Source/WebCore:

Specification for the Speech Recognition API:
http://dvcs.w3.org/hg/speech-api/raw-file/tip/speechapi.html

This patch does the following:
o Adds results, and removing result, on SpeechRecognitionEvent
o Renaming SpeechRecognitionResult::final to isFinal
o Removing emma from SpeechRecognitionResult

The emma attribute is supposed to move from SpeechRecognitionResult to the SpeechRecognitionEvent,
but that caused GC issues for unrelated code so it will be added later when properly fixed.

Existing tests updated to test the new API.

  • Modules/speech/SpeechRecognition.cpp:

(WebCore::SpeechRecognition::start):
(WebCore::SpeechRecognition::didReceiveResults):
(WebCore):

  • Modules/speech/SpeechRecognition.h:

(SpeechRecognition):

  • Modules/speech/SpeechRecognitionEvent.cpp:

(WebCore::SpeechRecognitionEvent::createResult):
(WebCore):
(WebCore::SpeechRecognitionEvent::SpeechRecognitionEvent):
(WebCore::SpeechRecognitionEvent::~SpeechRecognitionEvent):

  • Modules/speech/SpeechRecognitionEvent.h:

(SpeechRecognitionEventInit):
(SpeechRecognitionEvent):
(WebCore::SpeechRecognitionEvent::resultIndex):
(WebCore::SpeechRecognitionEvent::results):

  • Modules/speech/SpeechRecognitionEvent.idl:
  • Modules/speech/SpeechRecognitionResult.cpp:
  • Modules/speech/SpeechRecognitionResult.h:

(WebCore::SpeechRecognitionResult::isFinal):
(SpeechRecognitionResult):

  • Modules/speech/SpeechRecognitionResult.idl:
  • WebCore.gypi:
  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):
(WebCore):

  • bindings/js/JSDictionary.h:
  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):
(WebCore):

  • bindings/v8/Dictionary.h:

(Dictionary):

  • bindings/v8/custom/V8SpeechRecognitionResultCustom.cpp: Removed.

Source/WebKit/chromium:

Adding the new didReceiveResults method.

  • public/WebSpeechRecognizerClient.h:
  • src/SpeechRecognitionClientProxy.cpp:

(WebKit::SpeechRecognitionClientProxy::didReceiveResults):
(WebKit):

  • src/SpeechRecognitionClientProxy.h:

(SpeechRecognitionClientProxy):

Tools:

Changing the mock to use the new results delivery API.

  • DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:

LayoutTests:

Updating basic tests and removing emma tests temporarily.

  • fast/speech/scripted/emma-expected.txt: Removed.
  • fast/speech/scripted/emma.html: Removed.
  • fast/speech/scripted/speechrecognition-basics-expected.txt:
  • fast/speech/scripted/speechrecognition-basics.html:
6:26 AM Changeset in webkit [136391] by michael.bruning@digia.com
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] New resize tests fail
https://bugs.webkit.org/show_bug.cgi?id=103875

Reviewed by Jocelyn Turcotte.

Removes reference to unused viewportSpy, adds clearing the sizeSpy to the init method instead.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_resize.qml:
6:15 AM Changeset in webkit [136390] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening, mark tests flaky
https://bugs.webkit.org/show_bug.cgi?id=103884

Unreviewed gardening to mark tests flaky based on flakiness dashboard.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-12-03

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
6:10 AM Changeset in webkit [136389] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebKit2

[GTK] Custom URI schemes stop working on Epiphany using WebKit2 after killing the web process
https://bugs.webkit.org/show_bug.cgi?id=103729

Patch by Joaquim Rocha <jrocha@igalia.com> on 2012-12-03
Reviewed by Carlos Garcia Campos.

When a URI scheme is registered and the WebProcess is killed,
those schemes would not work anymore after the process is relaunched.

This was observed in Epiphany and possibly affects any port that
uses libsoup.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode): Encode the registered URI schemes.
(WebKit::WebProcessCreationParameters::decode): Decode the registered URI schemes.

  • Shared/WebProcessCreationParameters.h: Add the urlSchemesRegistered Vector to hold the registered URI schemes.

(WebProcessCreationParameters):

  • UIProcess/efl/WebContextEfl.cpp:

(WebKit::WebContext::platformInitializeWebProcess): Assign the parameters.urlSchemesRegistered from the URI schemes
registered in the WebSoupRequestManagerProxy and removed the notImplemented() call.

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformInitializeWebProcess): Assign the parameters.urlSchemesRegistered from the URI schemes
registered in the WebSoupRequestManagerProxy.

  • UIProcess/soup/WebSoupRequestManagerProxy.cpp:

(WebKit::WebSoupRequestManagerProxy::registerURIScheme): Add the given scheme to the m_registeredURISchemes Vector.

  • UIProcess/soup/WebSoupRequestManagerProxy.h:

(WebKit::WebSoupRequestManagerProxy::registeredURISchemes): Return the m_registeredURISchemes.
(WebSoupRequestManagerProxy): Define the m_registeredURISchemes to hold the schemes that are registered.

  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformInitializeWebProcess): Call m_soupRequestManager.registerURIScheme for each URI scheme
found in the parameters.

  • WebProcess/soup/WebSoupRequestManager.h: Make registerURIScheme public.

(WebSoupRequestManager):

5:30 AM Changeset in webkit [136388] by kov@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.10/Source/JavaScriptCore

Merge 129577 - We shouldn't use the optimized versions of shift/unshift if the user is doing crazy things to the array
https://bugs.webkit.org/show_bug.cgi?id=97603
<rdar://problem/12370864>

Reviewed by Gavin Barraclough.

You changed the length behind our backs? No optimizations for you then!

  • runtime/ArrayPrototype.cpp:

(JSC::shift):
(JSC::unshift):

  • runtime/JSArray.cpp:

(JSC::JSArray::shiftCount):

Conflicts:

Source/JavaScriptCore/runtime/JSArray.cpp

5:23 AM Changeset in webkit [136387] by alexis@webkit.org
  • 4 edits in trunk

[Qt] Enable CSS3 background-position offsets by default.
https://bugs.webkit.org/show_bug.cgi?id=103877

Reviewed by Tor Arne Vestbø.

Tools:

Enable by default CSS3 background-position offsets.

  • qmake/mkspecs/features/features.pri:

LayoutTests:

Enable by default the new CSS3 background position offsets therefore we
can unskip the tests.

  • platform/qt/TestExpectations:
5:20 AM Changeset in webkit [136386] by commit-queue@webkit.org
  • 198 edits in trunk

Unreviewed, rolling out r136377.
http://trac.webkit.org/changeset/136377
https://bugs.webkit.org/show_bug.cgi?id=103881

Causes crashes on debug builds that use JSC. (Requested by
mkwst on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-03

Source/WebCore:

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::didFailSocketStream):

  • css/MediaList.cpp:

(WebCore::addResolutionWarningMessageToConsole):

  • dom/Document.cpp:

(WebCore::Document::logExceptionToConsole):
(WebCore::Document::processHttpEquiv):

  • dom/Document.h:

(Document):

  • dom/ScriptExecutionContext.h:

(ScriptExecutionContext):

  • dom/ViewportArguments.cpp:

(WebCore):
(WebCore::parserLineNumber):
(WebCore::reportViewportWarning):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::parseAttribute):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::printWarningToConsole):

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::ConsoleMessage):

  • inspector/ConsoleMessage.h:

(ConsoleMessage):

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::enable):
(WebCore::InspectorConsoleAgent::addMessageToConsole):
(WebCore::InspectorConsoleAgent::count):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

  • page/Console.cpp:
  • page/Console.h:

(Console):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::printErrorMessage):

  • svg/SVGDocumentExtensions.cpp:

(WebCore):
(WebCore::parserLineNumber):
(WebCore::reportMessage):

  • workers/WorkerContext.cpp:
  • workers/WorkerContext.h:

(WorkerContext):

LayoutTests:

  • fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
  • fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
  • fast/frames/xss-auditor-handles-file-urls-expected.txt:
  • html5lib/run-test11-expected.txt:
  • http/tests/inspector/console-xhr-logging-expected.txt:
  • http/tests/misc/bubble-drag-events-expected.txt:
  • http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt:
  • http/tests/misc/iframe-invalid-source-crash-expected.txt:
  • http/tests/misc/image-blocked-src-change-expected.txt:
  • http/tests/misc/image-blocked-src-no-change-expected.txt:
  • http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • http/tests/security/frame-loading-via-document-write-expected.txt:
  • http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt:
  • http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
  • http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
  • http/tests/security/xssAuditor/base-href-control-char-expected.txt:
  • http/tests/security/xssAuditor/base-href-expected.txt:
  • http/tests/security/xssAuditor/base-href-null-char-expected.txt:
  • http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
  • http/tests/security/xssAuditor/cookie-injection-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/form-action-expected.txt:
  • http/tests/security/xssAuditor/full-block-base-href-expected.txt:
  • http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt:
  • http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
  • http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
  • http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
  • http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
  • http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
  • http/tests/security/xssAuditor/get-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/iframe-injection-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-url-encoded-expected.txt:
  • http/tests/security/xssAuditor/iframe-onload-GBK-char-expected.txt:
  • http/tests/security/xssAuditor/iframe-onload-in-svg-tag-expected.txt:
  • http/tests/security/xssAuditor/iframe-srcdoc-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-GBK-char-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-non-ASCII-char-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-default-encoding-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-expected.txt:
  • http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-control-char-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-null-char-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-one-plus-one-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-url-encoded-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-control-char-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-null-char-expected.txt:
  • http/tests/security/xssAuditor/link-opens-new-window-expected.txt:
  • http/tests/security/xssAuditor/malformed-HTML-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-1-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-2-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-3-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-4-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-5-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-6-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-7-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-8-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-9-expected.txt:
  • http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/object-tag-expected.txt:
  • http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/open-attribute-body-expected.txt:
  • http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
  • http/tests/security/xssAuditor/open-iframe-src-expected.txt:
  • http/tests/security/xssAuditor/open-script-src-expected.txt:
  • http/tests/security/xssAuditor/post-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/property-escape-comment-expected.txt:
  • http/tests/security/xssAuditor/property-escape-entity-expected.txt:
  • http/tests/security/xssAuditor/property-escape-expected.txt:
  • http/tests/security/xssAuditor/property-escape-long-expected.txt:
  • http/tests/security/xssAuditor/property-escape-quote-expected.txt:
  • http/tests/security/xssAuditor/report-script-tag-expected.txt:
  • http/tests/security/xssAuditor/script-tag-Big5-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode-expected.txt:
  • http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-expected.txt:
  • http/tests/security/xssAuditor/script-tag-Big5-char2-expected.txt:
  • http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt:
  • http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-convoluted-expected.txt:
  • http/tests/security/xssAuditor/script-tag-entities-expected.txt:
  • http/tests/security/xssAuditor/script-tag-expected.txt:
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag-expected.txt:
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag2-expected.txt:
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag3-expected.txt:
  • http/tests/security/xssAuditor/script-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt:
  • http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-post-expected.txt:
  • http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-redirect-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode2-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode3-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode4-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-actual-comma-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-comma-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-data-url-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-data-url2-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-data-url3-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-unterminated-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt:
  • http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt:
  • http/tests/security/xssAuditor/xss-filter-bypass-long-string-expected.txt:
  • http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-02-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
  • platform/chromium-linux/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
  • platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:
  • platform/chromium/http/tests/misc/bubble-drag-events-expected.txt:
  • platform/chromium/http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt:
  • platform/chromium/http/tests/misc/iframe-invalid-source-crash-expected.txt:
  • platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed-expected.txt:
  • platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked-expected.txt:
  • platform/chromium/http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt:
  • platform/chromium/svg/custom/polyline-setattribute-points-null-expected.txt:
  • platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/mac/svg/custom/polyline-setattribute-points-null-expected.txt:
  • svg/custom/invalid-length-units-expected.txt:
  • svg/custom/poly-parsing-error-expected.txt:
  • svg/dom/fuzz-path-parser-expected.txt:
  • svg/dom/path-parser-expected.txt:
  • svg/dom/points-parser-expected.txt:
4:48 AM Changeset in webkit [136385] by kihong.kwon@samsung.com
  • 10 edits
    4 moves
    1 add in trunk

Remove useless included header and change position of Proximity Events test cases
https://bugs.webkit.org/show_bug.cgi?id=103871

Reviewed by Antonio Gomes.

Source/WebCore:

Remove useless included header from DeviceProximityEvent.cpp.

No new tests, It is just code refactoring.

  • Modules/proximity/DeviceProximityEvent.cpp:

LayoutTests:

Change the path of Proximity Events test cases from LayoutTests/fast/dom/Proximity to LayoutTests/proximity.

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • proximity/check-event-deviceproximity-expected.txt: Renamed from LayoutTests/fast/dom/Proximity/check-event-deviceproximity-expected.txt.
  • proximity/check-event-deviceproximity.html: Renamed from LayoutTests/fast/dom/Proximity/check-event-deviceproximity.html.
  • proximity/create-event-deviceproximity-expected.txt: Renamed from LayoutTests/fast/dom/Proximity/create-event-deviceproximity-expected.txt.
  • proximity/create-event-deviceproximity.html: Renamed from LayoutTests/fast/dom/Proximity/create-event-deviceproximity.html.
4:40 AM Changeset in webkit [136384] by zeno.albisser@digia.com
  • 2 edits in trunk

[Qt][Mac] QtWebKitWidgets has wrong install_name.

This part got lost during the library split.
It was done for QtWebKit before, but it also
needs to be applied to QtWebKitWidgets.

Reviewed by Tor Arne Vestbø.

  • Source/widgetsapi.pri:
4:39 AM Changeset in webkit [136383] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Mark last input event for current vsync interval
https://bugs.webkit.org/show_bug.cgi?id=103647

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-12-03
Reviewed by James Robinson.

On Android all input events are triggered at the start of a vsync to maximize
the amount of time an application has for painting. Add a field to
WebInputEvent to indicate when the input event is the final one for the
current vsync interval. This information will be used for more efficient
render scheduling.

  • public/WebInputEvent.h:

(WebKit::WebInputEvent::WebInputEvent):

4:37 AM Changeset in webkit [136382] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GStreamer] initial volume events on media elements should happen earlier
https://bugs.webkit.org/show_bug.cgi?id=96912

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-12-03
Reviewed by Philippe Normand.

Update mediaelement volume and mute properties to whatever values
playbin has as soon as possible (when the playbin reaches PAUSED state).
This will improve user experience as the volume visuals won't suddenly
change when user clicks play.

No new tests: media/event-attributes.html already tests media events.
Unfortunately this test is flaky on EFL and GTK (more specifically
it is flaky on pulseaudio-using gstreamer platforms: http://webkit.org/b/83704).

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::load):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

4:37 AM Changeset in webkit [136381] by kkristof@inf.u-szeged.hu
  • 6 edits
    1 add in trunk/LayoutTests

[Qt] Gardening after r136280, r136323, r136164 and r136031.
https://bugs.webkit.org/show_bug.cgi?id=103876

Patch by János Badics <János Badics> on 2012-12-03
Reviewed by Csaba Osztrogonác.

r136280: Added Qt baseline for fast/events/stopPropagation-submit.html.
r136323: Skipped storage/domstorage/localstorage/close-idle-localstorage-databases-immediately.html
r136164: Skipped fast/dom/Geolocation/cached-position-iframe.html on Qt-WK2
r136031: Updated Qt-WK2 baselines for http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag* tests.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/qt/TestExpectations:
  • platform/qt/fast/events/stopPropagation-submit-expected.txt: Added.
4:26 AM Changeset in webkit [136380] by alexis@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r136378.

  • css/CSSPrimitiveValueMappings.h:

(WebCore):
(WebCore::CSSPrimitiveValue::operator BackgroundEdgeOrigin):

3:56 AM Changeset in webkit [136379] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.10/Source/WebCore

Merge 130855 - Recursively detach SVGElementInstances
https://bugs.webkit.org/show_bug.cgi?id=98851

Reviewed by Ryosuke Niwa and Abhishek Arya

Before this patch, SVGElementInstance child nodes were not being detached. This
patch makes detach() recursively detach SVGElementInstances.

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::detach):

3:55 AM Changeset in webkit [136378] by alexis@webkit.org
  • 18 edits
    2 adds in trunk

[CSS3 Backgrounds and Borders] Implement CSS3 background-position offsets rendering.
https://bugs.webkit.org/show_bug.cgi?id=103440

Reviewed by Julien Chaffraix.

Source/WebCore:

Add the rendering bits of the new background-position offsets. It adds
new bits in FillLayer to store the edges used to position the
background. The old x and y members are used the same way as before, to
store the value of the offset.

Test: fast/backgrounds/background-position-rendering.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::createPositionListForLayer): Refactor into a function the
code duplicated in getPropertyCSSValue to avoid more code
duplication.
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Add implicit conversion from the enums used in the rendering code to
CSS values.
(WebCore::CSSPrimitiveValue::operator BackgroundEdgeOrigin):

  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Add
support for the new positioning and refactor a little naming of the
variables for better readability.

  • rendering/style/FillLayer.cpp:

(SameSizeAsFillLayer):
(WebCore::FillLayer::FillLayer):
(WebCore::FillLayer::operator=):
(WebCore::FillLayer::operator==):
(WebCore::FillLayer::fillUnsetProperties):
(WebCore::FillLayer::fillUnsetProperties): When filling the layer with
unset properties make sure we also set the x and y origins of the
background in case they were set.

  • rendering/style/FillLayer.h:

(WebCore::FillLayer::backgroundXOrigin):
(WebCore::FillLayer::backgroundYOrigin):
(WebCore::FillLayer::isBackgroundOriginSet):
(FillLayer):
(WebCore::FillLayer::setBackgroundXOrigin):
(WebCore::FillLayer::setBackgroundYOrigin):
(WebCore::FillLayer::clearPositionX):
(WebCore::FillLayer::clearPositionY):

  • rendering/style/RenderStyleConstants.h:

LayoutTests:

Uncomment the computed style tests from background-position-parsing-2
and add the expected output. Add a new
background-position-rendering test to verify that the background has a
correct position with the new <position> value. I also covered some old
CSS 2.1 values for verification.

  • fast/backgrounds/background-position-parsing-2-expected.txt:
  • fast/backgrounds/background-position-parsing-2.html:
  • fast/backgrounds/background-position-rendering-expected.html: Added.
  • fast/backgrounds/background-position-rendering.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
3:07 AM Changeset in webkit [136377] by mkwst@chromium.org
  • 198 edits in trunk

Web Inspector: Autogenerate stack traces and line numbers when possible.
https://bugs.webkit.org/show_bug.cgi?id=100650

Reviewed by Yury Semikhatsky.

Source/WebCore:

Console messages generated in WebCore generally are asked to do a bit of
work in order to provide a developer with a detailed report. We ask the
caller to either generate stack traces, or pass in a url/line number
pair, which can be a bit of work. Predictably, most callers don't pass
in what we'd like to see.

This patch creates a new, simpler console message generation API that we
expect most call sites to use. Source, type, level, and message are
required, and an optional request ID can be passed in. Everything else
will be autogenerated inside ConsoleMessage when appropriate.

In a subsequent patch, we expect to be able to trim down more of the
external call sites (ContentSecurityPolicy springs to mind) in order to
further consolidate the external interface. Simple is good.

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::didFailSocketStream):

Drop the now-redundant URL parameter from various WebSocket errors.

  • css/MediaList.cpp:

(WebCore::addResolutionWarningMessageToConsole):

Switch to Document::addConsoleMessage, which means that we can move
line-number generation out of MediaList.

  • dom/Document.cpp:

(WebCore::Document::logExceptionToConsole):

Use the long-form 'addMessage()' rather than the public interface.

(WebCore::Document::processHttpEquiv):

Drop the URL parameter, as it's now autogenerated.

(WebCore::Document::addConsoleMessage):
(WebCore):

  • dom/Document.h:

(Document):

Override the pure virtual method on ScriptExecutionContext, and pass
the call through to the new Console::addMessage, which accepts a
pointer to the Document in order to do line-number generation.

  • dom/ScriptExecutionContext.h:

(ScriptExecutionContext):

Add a pure virtual variant of addConsoleMessage which accepts only
bare minimum data, and expects autogeneration of the rest.
Additionally, ensure that the other variants always have either a
URL/line number, or a stack trace.

  • dom/ViewportArguments.cpp:

(WebCore::reportViewportWarning):

Drop line numbers and URLs from Viewport warnings. We can generate
these now.

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

Drop the URL from form autofocus warnings

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::parseAttribute):

Drop the URL and line from sandbox attribute warnings.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::printWarningToConsole):

Drop the URL from WebGL warnings.

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::ConsoleMessage):

Call 'autogenerateMetadata' to ensure that a stack trace is
generated if one isn't provided. Create a new constructor that
accepts a ScriptState/ScriptArguments pair, and use it for console
API calls.

(WebCore):
(WebCore::ConsoleMessage::autogenerateMetadata):

Generate a stack trace given whatever information we've got.

  • inspector/ConsoleMessage.h:

(ConsoleMessage):

Create a new constructor that accepts a ScriptState/ScriptArguments
pair, and use it for console API calls.

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::enable):

Use the short-form ConsoleMessage constructor.

(WebCore::InspectorConsoleAgent::addMessageToConsole):

Use the stack-only constructor, or the ScriptState
constructor, as appropriate.

(WebCore::InspectorConsoleAgent::count):

We generated a stack, pass it in.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

Drop the URL parameter from the console message for X-Frame-Options
parsing errors.

  • page/Console.cpp:

(WebCore::Console::addMessage):

When given a Document*, generate a line number if: 1) the document
is still being parsed, 2) the document is not in document.write(),
3) the parser isn't waiting for script, and 4) the parser isn't
executing script. Many callsites didn't check all of these, which
is why the SVG rebaseline (for example) drops lots and lots of line
numbers which point at a closing '</script>' tag.

(WebCore):

  • page/Console.h:

(WebCore):
(Console):

Update the public API to accept a Document* and little else.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::printErrorMessage):

Don't generate a stack here. We can do it later.

  • svg/SVGDocumentExtensions.cpp:

(WebCore::reportMessage):

Drop the URL and line number. We'll generate them. It'll be sweet.

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::addConsoleMessage):

Generate a stack here, as we likely won't have the context to do
so later. Pass it through.

(WebCore):

  • workers/WorkerContext.h:

(WorkerContext):

Implement the new addConsoleMessage variant.

LayoutTests:

New line numbers! Huzzah! (Also, removing some that shouldn't be there).

  • http/tests/inspector/console-xhr-logging-expected.txt:
  • platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:

One new stack trace! OMG!

  • fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
  • fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
  • fast/frames/xss-auditor-handles-file-urls-expected.txt:
  • html5lib/run-test11-expected.txt:
  • http/tests/misc/bubble-drag-events-expected.txt:
  • http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt:
  • http/tests/misc/iframe-invalid-source-crash-expected.txt:
  • http/tests/misc/image-blocked-src-change-expected.txt:
  • http/tests/misc/image-blocked-src-no-change-expected.txt:
  • http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • http/tests/security/frame-loading-via-document-write-expected.txt:
  • http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt:
  • http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
  • http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
  • http/tests/security/xssAuditor/base-href-control-char-expected.txt:
  • http/tests/security/xssAuditor/base-href-expected.txt:
  • http/tests/security/xssAuditor/base-href-null-char-expected.txt:
  • http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
  • http/tests/security/xssAuditor/cookie-injection-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/form-action-expected.txt:
  • http/tests/security/xssAuditor/full-block-base-href-expected.txt:
  • http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt:
  • http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
  • http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
  • http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
  • http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
  • http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
  • http/tests/security/xssAuditor/get-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/iframe-injection-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-url-encoded-expected.txt:
  • http/tests/security/xssAuditor/iframe-onload-GBK-char-expected.txt:
  • http/tests/security/xssAuditor/iframe-onload-in-svg-tag-expected.txt:
  • http/tests/security/xssAuditor/iframe-srcdoc-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-GBK-char-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-non-ASCII-char-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-default-encoding-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-expected.txt:
  • http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-control-char-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-null-char-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-one-plus-one-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-url-encoded-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-control-char-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-null-char-expected.txt:
  • http/tests/security/xssAuditor/link-opens-new-window-expected.txt:
  • http/tests/security/xssAuditor/malformed-HTML-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-1-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-2-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-3-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-4-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-5-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-6-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-7-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-8-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-9-expected.txt:
  • http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/object-tag-expected.txt:
  • http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/open-attribute-body-expected.txt:
  • http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
  • http/tests/security/xssAuditor/open-iframe-src-expected.txt:
  • http/tests/security/xssAuditor/open-script-src-expected.txt:
  • http/tests/security/xssAuditor/post-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/property-escape-comment-expected.txt:
  • http/tests/security/xssAuditor/property-escape-entity-expected.txt:
  • http/tests/security/xssAuditor/property-escape-expected.txt:
  • http/tests/security/xssAuditor/property-escape-long-expected.txt:
  • http/tests/security/xssAuditor/property-escape-quote-expected.txt:
  • http/tests/security/xssAuditor/report-script-tag-expected.txt:
  • http/tests/security/xssAuditor/script-tag-Big5-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode-expected.txt:
  • http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-expected.txt:
  • http/tests/security/xssAuditor/script-tag-Big5-char2-expected.txt:
  • http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt:
  • http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-convoluted-expected.txt:
  • http/tests/security/xssAuditor/script-tag-entities-expected.txt:
  • http/tests/security/xssAuditor/script-tag-expected.txt:
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag-expected.txt:
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag2-expected.txt:
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag3-expected.txt:
  • http/tests/security/xssAuditor/script-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt:
  • http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-post-expected.txt:
  • http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-redirect-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode2-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode3-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode4-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-actual-comma-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-comma-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-data-url-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-data-url2-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-data-url3-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-unterminated-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt:
  • http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt:
  • http/tests/security/xssAuditor/xss-filter-bypass-long-string-expected.txt:
  • http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-02-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
  • platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/chromium/http/tests/misc/bubble-drag-events-expected.txt:
  • platform/chromium/http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt:
  • platform/chromium/http/tests/misc/iframe-invalid-source-crash-expected.txt:
  • platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed-expected.txt:
  • platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked-expected.txt:
  • platform/chromium/http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt:
  • platform/chromium/svg/custom/polyline-setattribute-points-null-expected.txt:
  • platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/mac/svg/custom/polyline-setattribute-points-null-expected.txt:
  • svg/custom/invalid-length-units-expected.txt:
  • svg/custom/poly-parsing-error-expected.txt:
  • svg/dom/SVGScriptElement/script-onerror-bubbling-expected.txt:
  • svg/dom/fuzz-path-parser-expected.txt:
  • svg/dom/path-parser-expected.txt:
  • svg/dom/points-parser-expected.txt:
2:21 AM Changeset in webkit [136376] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a failure expectation for editing/selection/caret-alignment-for-vertical-text.html.

  • platform/gtk/TestExpectations:
2:15 AM Changeset in webkit [136375] by rgabor@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Remove an unnecessary masking from swapBgrToRgb()
https://bugs.webkit.org/show_bug.cgi?id=103630

Reviewed by Zoltan Herczeg.

Get rid of a masking command in swapBgrToRgb() to speed up a little bit.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::swapBgrToRgb):

2:01 AM Changeset in webkit [136374] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Accessibility gardening
https://bugs.webkit.org/show_bug.cgi?id=103735

Unreviewed, EFL accessibility gardening.

Unskipping accessibility tests. Skipping failing ones.

Patch by Mateusz Leszko <m.leszko@samsung.com> on 2012-12-03

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
1:22 AM Changeset in webkit [136373] by commit-queue@webkit.org
  • 9 edits
    3 adds in trunk

CSS Device Adaptation: window.innerWidth returns wrong value if CSS viewport descriptors are applied
https://bugs.webkit.org/show_bug.cgi?id=103737

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-12-03
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

ViewportStyleResolver used frame view visibleContentRect size as initial viewport size.
This however caused a problem when page enabled/disabled CSS stylesheets, having viewport
descriptors. Viewport descriptors from new stylesheet were applied to the visibleContentRect
affected already by the viewport descriptors from the previous stylesheet.

New 'initialViewportSize' property (http://dev.w3.org/csswg/css-device-adapt/#initial-viewport)
was added to frame view so that viewport descriptors can always be applied to the reliable
viewport size.

Test: css3/device-adapt/viewport-width-check-window-innerwidth-correct.html

  • css/ViewportStyleResolver.cpp:

(WebCore::ViewportStyleResolver::ViewportStyleResolver):
(WebCore::ViewportStyleResolver::getViewportArgumentValue):

  • css/ViewportStyleResolver.h:

(ViewportStyleResolver):

  • dom/Document.cpp:

(WebCore):
(WebCore::Document::initialViewportSize):

  • dom/Document.h:

(Document):

  • page/FrameView.h:

(FrameView):
(WebCore::FrameView::initialViewportSize):
(WebCore::FrameView::setInitialViewportSize):

Source/WebKit2:

ViewportStyleResolver used frame view visibleContentRect size as initial viewport size.
This however caused a problem when page enabled/disabled CSS stylesheets, having viewport
descriptors. Viewport descriptors from new stylesheet were applied to the visibleContentRect
affected already by the viewport descriptors from the previous stylesheet.

New 'initialViewportSize' property (http://dev.w3.org/csswg/css-device-adapt/#initial-viewport)
was added to frame view so that viewport descriptors can always be applied to the reliable
viewport size.

Both newly added 'initialViewportSize' property and 'fixedVisibleContentRect' property
are assigned appropriately now in WebPage::sendViewportAttributesChanged().

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendViewportAttributesChanged):

LayoutTests:

Added new test css3/device-adapt/viewport-width-check-window-innerwidth-correct.html.

  • css3/device-adapt/viewport-width-check-window-innerwidth-correct-expected.txt: Added.
  • css3/device-adapt/viewport-width-check-window-innerwidth-correct.html: Added.
1:21 AM Changeset in webkit [136372] by fpizlo@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

DFG should trigger rage conversion from double to contiguous if it sees a GetByVal on Double being used in an integer context
https://bugs.webkit.org/show_bug.cgi?id=103858

Reviewed by Gavin Barraclough.

A rage conversion from double to contiguous is one where you try to convert each
double to an int32.

This is probably not the last we'll hear of rage conversion from double to contiguous.
It may be better to do this right during parsing, which will result in fewer cases of
Arrayification. But even so, this looks like a straight win already - 1% speed-up on
Kraken, no major regression anywhere else.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::refine):
(JSC::DFG::arrayConversionToString):
(JSC::DFG::ArrayMode::dump):
(WTF):
(WTF::printInternal):

  • dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::withConversion):
(ArrayMode):
(JSC::DFG::ArrayMode::doesConversion):
(WTF):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupBlock):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(FixupPhase):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGNodeFlags.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::arrayify):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

  • runtime/JSObject.cpp:

(JSC):
(JSC::JSObject::genericConvertDoubleToContiguous):
(JSC::JSObject::convertDoubleToContiguous):
(JSC::JSObject::rageConvertDoubleToContiguous):
(JSC::JSObject::ensureContiguousSlow):
(JSC::JSObject::rageEnsureContiguousSlow):

  • runtime/JSObject.h:

(JSObject):
(JSC::JSObject::rageEnsureContiguous):

12:56 AM Changeset in webkit [136371] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Use float variable for zoom levels for MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=103863

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-12-03
Reviewed by Gyuyoung Kim.

Use float instead of int for zoomLevels variables for a clearer expression

  • MiniBrowser/efl/main.c:

(on_key_down):

12:51 AM Changeset in webkit [136370] by apavlov@chromium.org
  • 12 edits
    2 adds in trunk

Web Inspector: [Styles] Retain selector case as written in the source code
https://bugs.webkit.org/show_bug.cgi?id=103118

Reviewed by Antti Koivisto.

Source/WebCore:

This change:

  • adds parsing of selector group components in the CSSParser;
  • builds the SelectorList.selectors based on the source code whenever possible. Strips [multiline] comments and whitespace;
  • adds the MultilineMode to RegularExpression.

Test: inspector/styles/selector-list.html

  • WebCore.exp.in: Update the exported symbol.
  • css/CSSGrammar.y.in: Add invocations for CSSParser::markSelector[Start|End]() as required.
  • css/CSSParser.cpp:

(WebCore::CSSParser::markSelectorStart): Gets invoked to mark a selector group item start offset.
(WebCore::CSSParser::markSelectorEnd): Ditto for the end offset.

  • css/CSSParser.h: Add new methods and a SourceRange tracking field.
  • css/CSSPropertySourceData.h: Add SelectorRangeList to the CSSRuleSourceData.
  • inspector/InspectorStyleSheet.cpp:

(WebCore::selectorsFromSource): Builds the SelectorList based on the underlying source data.
Strips comments and whitespace from selectors.
(WebCore::InspectorStyleSheet::buildObjectForSelectorList):
Builds SelectorList based on the availability of the source code.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype._markSelectorMatches):
Update selectors in all cases to make use of the source-based information whenever possible.

  • platform/text/RegularExpression.cpp:

Add the MultilineMode parameter into the constructor/factory method and ultimately pass it into YarrPattern.
(WebCore::RegularExpression::Private::create): See above.
(WebCore::RegularExpression::Private::Private): See above.
(WebCore::RegularExpression::Private::compile): See above.
(WebCore::RegularExpression::RegularExpression): See above.

  • platform/text/RegularExpression.h:

Add enum MultilineMode, modify constructor and factory method signatures accordingly.

LayoutTests:

  • inspector/styles/selector-list-expected.txt: Added.
  • inspector/styles/selector-list.html: Added.
  • inspector/styles/styles-add-new-rule-expected.txt: Rebaselined.

Dec 2, 2012:

11:58 PM Changeset in webkit [136369] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Add support for a zoom level setting to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=99285

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-12-02
Reviewed by Gyuyoung Kim.

Add support for a zoom level setting to MiniBrowser.
Shortcuts for setting operations are same as common browsers:
Ctrl + '+' to zoom in, Ctrl + '-' to zoom out and Ctrl + '0' to zoom to default.

  • MiniBrowser/efl/main.c:

(on_key_down):

11:47 PM Changeset in webkit [136368] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed, WebKit2 gardening.

Skip storage/domstorage/localstorage/close-idle-localstorage-databases-immediately.html
on WebKit2 since testRunner.closeIdleLocalStorageDatabases() is not implemented yet.

  • platform/wk2/TestExpectations:
11:27 PM Changeset in webkit [136367] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Coordinated Graphics: Reorder messages to LayerTreeCoordinatorProxy
https://bugs.webkit.org/show_bug.cgi?id=103843

Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-02
Reviewed by Noam Rosenthal.

Send messages to the UI process by the tree order.
This is in preparation for refactoring TextureMapper to work in an actor
model (http://webkit.org/b/103854).

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):

10:54 PM Changeset in webkit [136366] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Unskip fast/js/array-sort-modifying-tostring.html in release mode
https://bugs.webkit.org/show_bug.cgi?id=103850

Unreviewed, EFL gardening.

This case has been passed in release mode, whereas crashed occasionally in debug mode.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-12-02

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
10:24 PM Changeset in webkit [136365] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebCore

ImageOrientation::transformFromDefault() case labels should be in numerical order
https://bugs.webkit.org/show_bug.cgi?id=101596

Reviewed by Simon Fraser.

Place the orientation case labels in numerical order to better match the EXIF2.2 spec
definitions of orientation values and their ImageOrientation.h enumeration.

No change in behavior. Covered by existing tests:

fast/images/exif-orientation-css.html
fast/images/exif-orientation-image-document.html
fast/images/exif-orientation.html

  • platform/graphics/ImageOrientation.cpp:

(WebCore::ImageOrientation::transformFromDefault): Numerically order the orientation
case statement labels.

10:13 PM Changeset in webkit [136364] by tasak@google.com
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed, webkit gardening. Rebaseline of fast/css/font-weight-1.

  • platform/chromium-mac-snowleopard/fast/css/font-weight-1-expected.png: Added.
  • platform/chromium-mac/fast/css/font-weight-1-expected.png: Added.
  • platform/chromium-mac/fast/css/font-weight-1-expected.txt: Added.
9:23 PM Changeset in webkit [136363] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[chromium] platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html is failing on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=103817

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-12-02
Reviewed by Kent Tamura.

Adding initial value to the datetime input. Without it, the test fails
because calendar picker opens current month.

  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html:
9:04 PM Changeset in webkit [136362] by tasak@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, webkit gardening.

https://bugs.webkit.org/show_bug.cgi?id=103834

  • platform/chromium/TestExpectations:

Mark month-multiple-fields-keyboard-events.html as FAIL for WinXP.

7:30 PM Changeset in webkit [136361] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

should sniff it if mimetype don't contain a slash.
https://bugs.webkit.org/show_bug.cgi?id=102778

Reviewed by George Staikos.

Based on http://mimesniff.spec.whatwg.org/, a valid media type
is the string represented by concatenating type, the string "/",
and subtype. So if the mimetype don't contain slash, we should
possible get sniffed type from the content like Firefox/chrome/safari.

RIM Bug# 219590, internally reviewed by Liam Quinn.

No new tests, the patch only impact qt/blackberry porting to be consistent
with chrome, other portings have their own behavior.

  • platform/network/MIMESniffing.cpp:

(std::isUnknownType):

7:12 PM Changeset in webkit [136360] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG CSE should not keep alive things that aren't relevant to OSR
https://bugs.webkit.org/show_bug.cgi?id=103849

Reviewed by Oliver Hunt.

Most Phantom nodes are inserted by CSE, and by default have the same children as the
node that CSE had eliminated. This change makes CSE inspect all Phantom nodes (both
those it creates and those that were created by other phases) to see if they have
children that are redundant - i.e. children that are not interesting to OSR, which
is the only reason why Phantoms exist in the first place. Being relevant to OSR is
defined as one of: (1) you're a Phi, (2) you're a SetLocal, (3) somewhere between
your definition and the Phantom there was a SetLocal that referred to you.

This is a slight speed-up in a few places.

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::CSEPhase):
(JSC::DFG::CSEPhase::run):
(JSC::DFG::CSEPhase::performSubstitution):
(CSEPhase):
(JSC::DFG::CSEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::performBlockCSE):

6:30 PM Changeset in webkit [136359] by ryuan.choi@samsung.com
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Update comments of header files which mentions deprecated API
https://bugs.webkit.org/show_bug.cgi?id=103718

Patch by Ryuan Choi <ryuan.choi@gmail.com> on 2012-12-02
Reviewed by Gyuyoung Kim.

Updated comments which mentions XXX_unref() which was replaced to ewk_object_unref()

  • UIProcess/API/efl/ewk_context.h:
  • UIProcess/API/efl/ewk_database_manager.h:
  • UIProcess/API/efl/ewk_storage_manager.h:
6:08 PM Changeset in webkit [136358] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK1] Change AC bug url appropriately
https://bugs.webkit.org/show_bug.cgi?id=103808

Unreviewed, EFL gardening.

From https://bugs.webkit.org/show_bug.cgi?id=103488 to https://bugs.webkit.org/show_bug.cgi?id=103847

Patch by Kangil Han <kangil.han@samsung.com> on 2012-12-02

  • platform/efl-wk1/TestExpectations:
5:59 PM Changeset in webkit [136357] by fpizlo@apple.com
  • 9 edits in trunk/Source

It should be possible to build and run with DFG_ENABLE(PROPAGATION_VERBOSE)
https://bugs.webkit.org/show_bug.cgi?id=103848

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Fix random dataLog() and print() statements.

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseCodeBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dumpBlockHeader):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

Source/WTF:

Increase the variadicity of dataLog() and print(), and add a pointerDump()
which allows passing a pointer to something that has a printInternal(). If
the pointer is null, it'll print "(null)"; otherwise it'll invoke the
printInternal() function.

  • wtf/DataLog.h:

(WTF):
(WTF::dataLog):

  • wtf/PrintStream.h:

(PrintStream):
(WTF::PrintStream::print):
(WTF):
(PointerDump):
(WTF::PointerDump::PointerDump):
(WTF::PointerDump::dump):
(WTF::pointerDump):

5:46 PM Changeset in webkit [136356] by tasak@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, webkit gardening, fix webkit lint.

  • platform/chromium/TestExpectations:
4:45 PM Changeset in webkit [136355] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

REGRESSION(r134376): ASSERT(!m_mainBackingStore) hits in CoordinatedGraphicsLayer::syncImageBacking().
https://bugs.webkit.org/show_bug.cgi?id=103845

Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-02
Reviewed by Noam Rosenthal.

flushCompositingStateForThisLayerOnly() calls syncImageBacking() before calling
updateContentBuffers(). It means there can be the moment that
CoordinatedGraphicsLayer has m_mainBackingStore although
shouldHaveBackingStore() return false.
This patch changes syncImageBacking() to check shouldHaveBackingStore() instead
of m_mainBackingStore.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::syncImageBacking):
(WebCore::CoordinatedGraphicsLayer::adjustContentsScale):
(WebCore::CoordinatedGraphicsLayer::updateContentBuffers):
(WebCore::CoordinatedGraphicsLayer::shouldHaveBackingStore):
(WebCore):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayer):

4:21 PM Changeset in webkit [136354] by commit-queue@webkit.org
  • 2 edits
    1 move
    1 add in trunk/Source/WebKit2

Rename WebSocketServerGtk.cpp as WebSocketServerSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=103743

Patch by Seokju Kwon <Seokju Kwon> on 2012-12-02
Reviewed by Gustavo Noronha Silva.

EFL port is using a GSocket based implementation as well.
WebSocketServerSoup can be used together.

  • GNUmakefile.list.am:
  • UIProcess/InspectorServer/soup/WebSocketServerSoup.cpp: Renamed from Source/WebKit2/UIProcess/InspectorServer/gtk/WebSocketServerGtk.cpp.

(WebKit):
(WebKit::connectionCallback):
(WebKit::WebSocketServer::platformInitialize):
(WebKit::WebSocketServer::platformListen):
(WebKit::WebSocketServer::platformClose):

3:43 PM Changeset in webkit [136353] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] ECORE_GETOPT_VALUE_BOOL need to be used for Eina_Bool
https://bugs.webkit.org/show_bug.cgi?id=103835

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-12-02
Reviewed by Kentaro Hara.

Because legacy_behavior_enabled is Eina_Bool, ECORE_GETOPT_VALUE_BOOL need to be used

  • MiniBrowser/efl/main.c:

(elm_main):

1:18 PM Changeset in webkit [136352] by mkwst@chromium.org
  • 3 edits in trunk/Tools

Garden-o-matic shouldn't die when blank JSON results are received.
https://bugs.webkit.org/show_bug.cgi?id=103838

Reviewed by Adam Barth.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:

If the JSONP string doesn't contain '(' or ')', return an empty object.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:

Check that this behavior stays in place.

12:48 PM Changeset in webkit [136351] by eric@webkit.org
  • 2 edits in trunk/Tools

run-perf-tests --profile should use iprofiler instead of instruments on Mac
https://bugs.webkit.org/show_bug.cgi?id=103765

Unreviewed. Updating the unittests after my previous change.

  • Scripts/webkitpy/common/system/profiler_unittest.py:

(ProfilerFactoryTest.test_basic):

12:29 PM Changeset in webkit [136350] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Adding checks for null when checking cookie status in CookieJarBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=103748

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-12-02
Reviewed by Rob Buis.

The logic is flipped in the previous patch.

  • loader/blackberry/CookieJarBlackBerry.cpp:

(WebCore::cookiesEnabled):

11:56 AM Changeset in webkit [136349] by commit-queue@webkit.org
  • 5 edits in trunk

[chromium] Correct the location of synthetic mouse events when page is zoomed
https://bugs.webkit.org/show_bug.cgi?id=103823

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-12-02
Reviewed by Adam Barth.

Source/WebKit/chromium:

The event-location conversion function expects absolute locations. Change the
function name to reflect that, and use the absolute location of the touch-points
when converting from touch events.

  • src/WebInputEventConversion.cpp:

(WebKit::convertAbsoluteLocationForRenderObject):
(WebKit::updateWebMouseEventFromWebCoreMouseEvent):
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
(WebKit::addTouchPoints):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):

LayoutTests:

  • platform/chromium/plugins/touch-events-synthesized-expected.txt:
  • platform/chromium/plugins/touch-events-synthesized.html:
10:49 AM Changeset in webkit [136348] by jparent@chromium.org
  • 2 edits in trunk/Tools

Remove dead code in flakiness dashboard for obsolete buildDir option
https://bugs.webkit.org/show_bug.cgi?id=103792

Reviewed by Dirk Pranke.

  • TestResultServer/static-dashboards/dashboard_base.js:

(initBuilders):

9:25 AM Changeset in webkit [136347] by robert@webkit.org
  • 3 edits
    4 adds in trunk

Bad rendering of web page because of image's height is set to 100%
https://bugs.webkit.org/show_bug.cgi?id=28035

Reviewed by Eric Seidel.

Source/WebCore:

Call computeReplacedLogicalHeight() to get the correct logical height of a replaced element
for calculating the element's width. RenderBox::computeLogicalHeightUsing() is a helper function designed for finding
the min and max height values and is not the way to find the actual used height of a replaced element.

WebKit's quirks-mode behaviour for the test case is unaffected by this change.

Tests: fast/css/computed-image-width-with-percent-height-quirksmode.html

fast/css/computed-image-width-with-percent-height.html

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth):

LayoutTests:

  • fast/css/computed-image-width-with-percent-height-expected.html: Added.
  • fast/css/computed-image-width-with-percent-height-quirksmode-expected.html: Added.
  • fast/css/computed-image-width-with-percent-height-quirksmode.html: Added.
  • fast/css/computed-image-width-with-percent-height.html: Added.
7:35 AM Changeset in webkit [136346] by mihnea@adobe.com
  • 5 edits
    2 adds in trunk

[CSS Regions] regionlayoutupdate event fires continuously
https://bugs.webkit.org/show_bug.cgi?id=102101

Reviewed by David Hyatt.

Source/WebCore:

According to the CSSRegions spec, http://dev.w3.org/csswg/css3-regions/#region-flow-layout-events, the regionlayoutupdate event
should be dispatched when there is a possible layout change in the region chain.
In the current implementation, regionlayoutupdate is dispatched when:

  1. a region from region chain changed its regionOverset value
  2. a region from region chain has regionOverset = fit| overset

In the case of a named flow having an auto-height region with regionOverset = fit, the second step of layout was done
also when there was not required, therefore the regionlayoutuodate was unnecessary triggered.

We should proceed with the 2-pass layout only if the flow-thread having auto-height regions in region chain needs layout.

Test: fast/regions/autoheight-regionlayoutupdate-multipletimes.html

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::hasRenderNamedFlowThreadsNeedingLayout):

  • rendering/FlowThreadController.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::layout):

LayoutTests:

Add a test to make sure that for a flow thread with auto-height region, the regionlayoutupdate event is not unnecessary triggered.

  • fast/regions/autoheight-regionlayoutupdate-multipletimes-expected.txt: Added.
  • fast/regions/autoheight-regionlayoutupdate-multipletimes.html: Added.
7:14 AM WebInspector edited by mousewiki@yahoo.com
(diff)
7:13 AM WebInspector edited by zandobersek@gmail.com
Remove spam content. (diff)
7:12 AM BadContent edited by zandobersek@gmail.com
Relist a tireless spam bot. (diff)
5:22 AM Changeset in webkit [136345] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt: clean up logic for retrying failed tests a bit
https://bugs.webkit.org/show_bug.cgi?id=103829

Reviewed by Ojan Vafai.

The code for determining when to retry test failures and
show the results.html file was awkward and could stand some
cleaning up. This patch should have no functional changes.

The routine called _get_failures() returned a dict of test names
to failure types, but we only ever used the names, so I've converted
it to return a list (and renamed it); also, the show_results_html()
file was calling that routine to figure out if anything failed, when
the information was already in the result_summary (as either
unexpected_results or total_failures), so we were doing unnecessary work.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.init):
(Manager.run):
(Manager._run_tests):
(Manager._failed_test_names):
(Manager._copy_results_html_file):

5:12 AM Changeset in webkit [136344] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt: remove unused methods in manager.py
https://bugs.webkit.org/show_bug.cgi?id=103828

Reviewed by Eric Seidel.

These two methods weren't being called by anything and were no
longer needed.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._get_failures):
(Manager._upload_json_files):

5:09 AM Changeset in webkit [136343] by commit-queue@webkit.org
  • 6 edits
    1 copy in trunk/Source/WebKit/chromium

[Chromium] Create an enum for the kind of date input and use that on WebDateTimeChooserParams instead of a bare WebString
https://bugs.webkit.org/show_bug.cgi?id=103746

Patch by Miguel Garcia <miguelg@chromium.org> on 2012-12-02
Reviewed by Kent Tamura.

Using an enum makes the chromium part much simpler and prevents makes sure that new items are added explicitly.

  • WebKit.gyp:
  • public/WebDateTimeChooserParams.h:

(WebDateTimeChooserParams):

  • public/WebDateTimeInputType.h: Copied from Source/WebKit/chromium/public/WebTextInputType.h.

(WebKit):

  • public/WebTextInputType.h:
  • public/WebViewClient.h:

(WebViewClient):

  • src/ExternalDateTimeChooser.cpp:

(WebKit::ExternalDateTimeChooser::openDateTimeChooser):
(WebKit::ExternalDateTimeChooser::webType):
(WebKit):

  • src/ExternalDateTimeChooser.h:

(ExternalDateTimeChooser):

5:00 AM Changeset in webkit [136342] by Christophe Dumez
  • 2 edits in trunk/Source/WebKit2

[CoordinatedGraphics] LayerTreeRenderer::removeImageBacking() calls HashMap::find() twice
https://bugs.webkit.org/show_bug.cgi?id=103815

Reviewed by Noam Rosenthal.

Call HashMap::take() in LayerTreeRenderer::removeImageBacking()
to avoid calling HashMap::find() twice. find() was called once
explicitly to get an iterator and a second time to remove the
value from the value from the HashMap. We could have used
remove(iterator) instead of remove(key) but using take() results
in simpler code.

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::removeImageBacking):

4:49 AM Changeset in webkit [136341] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Coordinated Graphics: Images disappear randomly
https://bugs.webkit.org/show_bug.cgi?id=103522

Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-02
Reviewed by Kenneth Rohde Christiansen.

Currently, we delete layers before synchronizing layer states of layers. It
causes flash. This patch deletes layers after the synchronization.

In addiation, this patch removes updateViewport() in
LayerTreeCoordinatorProxy::deleteCompositingLayer() because
LayerTreeCoordinatorProxy::didRenderFrame() is always called after
deleting layers.

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::deleteCompositingLayer):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):

4:43 AM Changeset in webkit [136340] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Correct the spelling of the cmakeargs argument
https://bugs.webkit.org/show_bug.cgi?id=103814

Patch by Laszlo Gombos <Laszlo Gombos> on 2012-12-02
Reviewed by Darin Adler.

The script expects cmakeargs (plural), so lets get the
documentation of the script report the same.

  • Scripts/build-webkit:
4:40 AM Changeset in webkit [136339] by mkwst@chromium.org
  • 7 edits in trunk

[gtk] Enable the CSP_NEXT runtime flag.
https://bugs.webkit.org/show_bug.cgi?id=103810

Reviewed by Adam Barth.

Source/WebKit/gtk:

This patch adds methods to DumpRenderTreeSupport in order to ensure that
CSP 1.1 features are enabled when running DRT tests in the GTK port.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setExperimentalContentSecurityPolicyFeaturesEnabled):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

Turn on the CSP_NEXT runtime flag when running tests under GTK.

LayoutTests:

  • platform/gtk/TestExpectations:

Unskipping CSP 1.1 tests for GTK.

4:38 AM Changeset in webkit [136338] by mkwst@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.

Skipping failing tests on mac.

  • platform/chromium/TestExpectations:

Mark fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html
and widening fast/css/font-weight-1.html to include 'Mac'.

4:22 AM Changeset in webkit [136337] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

Extend JavaScript support for blending in canvas
https://bugs.webkit.org/show_bug.cgi?id=101804

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-12-02
Reviewed by Dirk Schulze.

Source/WebCore:

Added parsing code and variables to support additional canvas blend modes
see spec: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#canvascompositingandblending

Test: canvas/philip/tests/2d.composite.globalComposite.html

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::State::operator=):
(WebCore::CanvasRenderingContext2D::globalCompositeOperation):
(WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
(WebCore::CanvasRenderingContext2D::drawImageFromRect):

  • html/canvas/CanvasRenderingContext2D.h:

(State):

  • platform/graphics/GraphicsTypes.cpp:

(WebCore):
(WebCore::parseCompositeAndBlendOperator):
(WebCore::compositeOperatorName):

  • platform/graphics/GraphicsTypes.h:

LayoutTests:

Added a test that checks that all blendingmodes are supported

  • canvas/philip/tests/2d.composite.globalComposite-expected.txt: Added.
  • canvas/philip/tests/2d.composite.globalComposite.html: Added.
4:11 AM Changeset in webkit [136336] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Windows, WinCairo] Revise export definitions to match mac.
https://bugs.webkit.org/show_bug.cgi?id=103687

Reviewed by Tim Horton.

Update export definition files to use the same feature exclusion
macros as other generated ports.

  • win/WebKit2.def.in: Added additional build macro guards.
4:09 AM Changeset in webkit [136335] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Fix build warning in GraphicsContext3DEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=103807

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-12-02
Reviewed by Laszlo Gombos.

Because GraphicsContext3D::ImageExtractor::extractImage is not implemented yet,
comment out the parameter names for removing -Wunused-parameter warnings.

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

4:03 AM Changeset in webkit [136334] by akling@apple.com
  • 11 edits
    2 adds in trunk/Source/WebCore

Keep ElementAttributeData sharing cache open for a while after document parsing finishes.
<http://webkit.org/b/103720>

Reviewed by Antti Koivisto.

Allow web pages that generate content dynamically to benefit more from the ElementAttributeData sharing
cache by keeping it open for 10 seconds after document parsing finishes. This enables elements constructed
from HTML fragments to share attribute data with other identical elements.

Elements created via Document.createElement are still unsupported since we don't know the list of attributes
at the time of construction.

401kB progression on Membuster3.

Document now holds on to a DocumentSharedObjectPool, accessible via Document::sharedObjectPool().
It is non-null during parsing and for some time afterwards, and can be used to implement additional
caches that are not worth holding on to permanently.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCore.vcproj/WebCore.vcproj:

Add new class DocumentSharedObjectPool.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::setParsing):
(WebCore::Document::finishedParsing):
(WebCore::Document::sharedObjectPoolClearTimerFired):

  • dom/Document.h:

(WebCore::Document::sharedObjectPool):

Create DocumentSharedObjectPool when parsing starts, kill it on a 10s timer after parsing finishes.

  • dom/DocumentSharedObjectPool.cpp: Added.

(ImmutableElementAttributeDataCacheKey):
(WebCore::ImmutableElementAttributeDataCacheKey::ImmutableElementAttributeDataCacheKey):
(WebCore::ImmutableElementAttributeDataCacheKey::operator!=):
(WebCore::ImmutableElementAttributeDataCacheKey::hash):
(ImmutableElementAttributeDataCacheEntry):
(WebCore::ImmutableElementAttributeDataCacheEntry::ImmutableElementAttributeDataCacheEntry):
(WebCore::DocumentSharedObjectPool::cachedImmutableElementAttributeData):
(WebCore::DocumentSharedObjectPool::DocumentSharedObjectPool):
(WebCore::DocumentSharedObjectPool::~DocumentSharedObjectPool):

  • dom/DocumentSharedObjectPool.h: Added.

(DocumentSharedObjectPool):
(WebCore::DocumentSharedObjectPool::create):

  • dom/Element.cpp:

(WebCore::Element::parserSetAttributes):

Moved the ElementAttributeData cache to DocumentSharedObjectPool.

3:56 AM Changeset in webkit [136333] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] fast/forms/*-multiple-fields/*-multiple-fields-preserve-value-after-history-back.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=96720

  • platform/chromium/TestExpectations: Mark them Slow
3:54 AM Changeset in webkit [136332] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Let Pepper Flash use integrated GPU
https://bugs.webkit.org/show_bug.cgi?id=103800

Patch by John Bauman <jbauman@chromium.org> on 2012-12-02
Reviewed by Kenneth Russell.

Pepper Flash uses the SharedGraphicsContext3D as a parent, so don't
require that to use the discrete GPU. This means that accelerated
canvas will use the integrated GPU, but that will save battery life
and seems acceptable.

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3DImpl::createContext):

3:38 AM Changeset in webkit [136331] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

documentElement should not always get a renderer
https://bugs.webkit.org/show_bug.cgi?id=103475

Patch by Elliott Sprehn <Elliott Sprehn> on 2012-12-02
Reviewed by Ojan Vafai.

Source/WebCore:

Only SVG documents need a renderer on the documentElement when it's
display: none. This behavior is wrong, but there's assumptions in
FrameView and SVGImage that depend on a RenderSVGRoot existing for all
loaded SVG document and images.

The current code has logic that makes it appear as if we always create
a renderer for the documentElement even when it's display: none, but
because HTMLElement::createRenderer doesn't call super we end up with
HTMLElement::rendererIsNeeded returning true for display: none, but
HTMLElement::createRenderer returning null.

Instead of this generic documentElement logic only special case SVG
until someone can fix Bug 103493 so we don't need it.

Test: fast/css/display-none-documentElement.html

  • dom/Element.cpp:

(WebCore::Element::rendererIsNeeded):
(WebCore::Element::createRenderer):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::rendererIsNeeded):

  • svg/SVGSVGElement.h:

(SVGSVGElement):

LayoutTests:

Test that using display: none on the documentElement hides the document.

  • fast/css/display-none-documentElement-expected.html: Added.
  • fast/css/display-none-documentElement.html: Added.
3:30 AM Changeset in webkit [136330] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry]Tap highlight
https://bugs.webkit.org/show_bug.cgi?id=103787

Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-12-02
Reviewed by Rob Buis.

RIM PR 248626
Internally Reviewed by Genevieve Mak.

Draw tap highlight as soon as tap on element.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::touchEvent):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

  • WebKitSupport/TouchEventHandler.h:

(TouchEventHandler):

3:23 AM Changeset in webkit [136329] by commit-queue@webkit.org
  • 4 edits
    5 adds in trunk

Source/WebCore: [Resource Timing] implementation of cross origin resouce timing restrictions.
https://bugs.webkit.org/show_bug.cgi?id=84886.

Patch by Pan Deng <pan.deng@intel.com> on 2012-12-02
Reviewed by Tony Gentilcore.

This patch implemented resource timing behaviors of cross origin. By default, detailed timing info is hided in cross origin resource timing, only startTime, duration, fetchStart and responseEnd can be observed. Exceptions are, server side allow its origin can be timing by another through a header with "timing-allow-origin" field.

Tests: http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_resource_request.html

http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_timing_allow_cross_origin_resource_request.html

  • page/Performance.cpp:

(WebCore::passesTimingAllowCheck):
(WebCore):
(WebCore::Performance::addResourceTiming):

  • page/Performance.h:

(WebCore):
(Performance):

  • page/PerformanceResourceTiming.cpp:

(WebCore):

  • page/PerformanceResourceTiming.h:

(WebCore::PerformanceResourceTiming::create):
(PerformanceResourceTiming):

LayoutTests: [Resource Timing]Test cases of cross origin resource timing.
https://bugs.webkit.org/show_bug.cgi?id=84886.

Patch by Pan Deng <pan.deng@intel.com> on 2012-12-02
Reviewed by Tony Gentilcore.

Test cases in this patch validate resource timing behavior when cross origin request with/without "allow-timing-origin" response header.

  • http/tests/w3c/webperf/resources/blank_page_green_with_allow_timing.php: Added.
  • http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_resource_request-expected.txt: Added.
  • http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_resource_request.html: Added.
  • http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_timing_allow_cross_origin_resource_request-expected.txt: Added.
  • http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_timing_allow_cross_origin_resource_request.html: Added.
3:16 AM Changeset in webkit [136328] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

Simplify treeScope and setTreeScope
https://bugs.webkit.org/show_bug.cgi?id=103708

Patch by Elliott Sprehn <Elliott Sprehn> on 2012-12-02
Reviewed by Hajime Morita.

By making the default treeScope in NodeRareData the document and then
moving the m_treeScope field to NodeRareDataBase we can make treeScope
inline and make setTreeScope much simpler.

There's also no reason to save calls to rareData() now that the map has
been eliminated by r133372 so we can eliminate the return value from
setTreeScope.

No new tests, just refactoring.

  • WebCore.exp.in:
  • dom/Document.h:

(WebCore::Node::treeScope):
(WebCore):

  • dom/Element.cpp:

(WebCore::Element::createRareData):

  • dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::ElementRareData):

  • dom/Node.cpp:

(WebCore::Node::setTreeScope):
(WebCore::Node::createRareData):

  • dom/Node.h:

(NodeRareDataBase):
(WebCore::NodeRareDataBase::treeScope):
(WebCore::NodeRareDataBase::setTreeScope):
(WebCore::NodeRareDataBase::NodeRareDataBase):
(Node):

  • dom/NodeRareData.cpp:

(WebCore::NodeRareData::reportMemoryUsage):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::NodeRareData):
(NodeRareData):

  • dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope):

3:00 AM Changeset in webkit [136327] by eric@webkit.org
  • 2 edits in trunk/Tools

run-perf-tests --profile should use iprofiler instead of instruments on Mac
https://bugs.webkit.org/show_bug.cgi?id=103765

Reviewed by Ryosuke Niwa.

Stephanie pointed out that iprofiler is the newer command-line interface
to replace /usr/bin/instruments in Instruments 4 (which according to the
interblags is supported on everything since 10.6.6), so I've moved --profile
to use iprofiler on Mac.

I also made the IProfiler class wait for iprofiler to complete so that
iprofiler won't continue running after run-perf-tests is complete (and
spam over the top of your shell output).

There are a couple of "got-chas" to this approach:

  1. iprofiler will ask for your password the first time you run it, which may

cause your first test to fail. /usr/bin/instruments doesn't seem to do that.

  1. iprofiler has nice (but kinda awkward for our purposes) support for separate

directory and basename arguments, making IProfiler a somewhat awkward
baseclass of SingleFileOutputProfiler

I suspect we'll iterate from here. It does seem slightly faster than
/usr/bin/instruments was.

  • Scripts/webkitpy/common/system/profiler.py:

(ProfilerFactory.create_profiler):
(IProfiler):
(IProfiler.init):
(IProfiler.attach_to_pid):

2:55 AM Changeset in webkit [136326] by junov@google.com
  • 5 edits
    2 adds in trunk

Fix occlusion culling logic to handle css background layer clipping
https://bugs.webkit.org/show_bug.cgi?id=103276

Reviewed by Simon Fraser.

Source/WebCore:

Bug was introduced by r135629
This patch fixes it by verifying layer clip. A fill layer must
not be treated as if it occludes the layers under it unless it has
a larger or equal clip setting than the layers under it.

Test: fast/backgrounds/background-opaque-clipped-gradients.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintFillLayers):

  • rendering/style/FillLayer.cpp:

(WebCore::clipMax):
(WebCore::FillLayer::computeClipMax):
(WebCore::FillLayer::clipOccludesNextLayers):

  • rendering/style/FillLayer.h:

(FillLayer):

LayoutTests:

New ref test that verifies the superposition of background layers with
the layers having smaller clip regions than the layers beneath them.
This test ensures the bottom layers are not removed by culling
optimizations.

  • fast/backgrounds/background-opaque-clipped-gradients-expected.html: Added.
  • fast/backgrounds/background-opaque-clipped-gradients.html: Added.
2:42 AM Changeset in webkit [136325] by rjkroege@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] make sourceDevice available to more WebGestureEvent subtypes
https://bugs.webkit.org/show_bug.cgi?id=103551

Reviewed by James Robinson.

Added an additional data payload to WebGestureEvent that can
contain the source device (touchpad or touchscreen).

  • public/WebInputEvent.h:
  • src/WebInputEvent.cpp:

(SameSizeAsWebGestureEvent):

2:39 AM Changeset in webkit [136324] by tony@chromium.org
  • 5 edits
    2 adds in trunk

Avoid a second layout of flex items in layoutAndPlaceChildren()
https://bugs.webkit.org/show_bug.cgi?id=102352

Reviewed by Ojan Vafai.

Source/WebCore:

Avoid doing a second layout if we're going to get the same size as before.
This prevents us from doing an exponential number of layouts in some
common cases.

Test: css3/flexbox/stretch-after-sibling-size-change.html

  • html/shadow/SliderThumbElement.cpp:

(WebCore::RenderSliderContainer::layout): Force a layout of the track, which positions the thumb.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::needToStretchChild): Determine if a child is going to stretch.
(WebCore::RenderFlexibleBox::resetAutoMarginsAndLogicalTopInCrossAxis): Makes sure we're in a consistent state before
we apply auto margins.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):

  • rendering/RenderFlexibleBox.h: Add needToStretchChild.

LayoutTests:

Add a test case to make sure we relayout when a sibling is stretching.

  • css3/flexbox/stretch-after-sibling-size-change-expected.txt: Added.
  • css3/flexbox/stretch-after-sibling-size-change.html: Added.
2:31 AM Changeset in webkit [136323] by commit-queue@webkit.org
  • 24 edits
    3 adds in trunk

Need a method to close all idle localstorage databases immediately.
https://bugs.webkit.org/show_bug.cgi?id=103469

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2012-12-02
Reviewed by David Kilzer.

Source/WebCore:

Add a new PageGroup method closeIdleLocalStorageDatabases, which walks through
all local storage areas that don't have document referencing to them and closes
their underlying databases.

Test: storage/domstorage/localstorage/close-idle-localstorage-databases-immediately.html

  • WebCore.exp.in:
  • page/PageGroup.cpp:

(WebCore::PageGroup::clearLocalStorageForOrigin):
(WebCore):
(WebCore::PageGroup::closeIdleLocalStorageDatabases): walking through all idle local storages and

closing their databases.

  • page/PageGroup.h:

(PageGroup):

  • storage/StorageArea.h:

(WebCore::StorageArea::closeDatabaseIfIdle):

  • storage/StorageAreaImpl.cpp:

(WebCore::StorageAreaImpl::closeDatabaseIfIdle): close the database if it is idle.
(WebCore):

  • storage/StorageAreaImpl.h:

(StorageAreaImpl):

  • storage/StorageNamespace.h:

(StorageNamespace):

  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::closeIdleLocalStorageDatabases):
(WebCore):

  • storage/StorageNamespaceImpl.h:

(StorageNamespaceImpl):

Source/WebKit/mac:

Add a new method to WebStorageManager that we can call to close all
idle local storage databases.

  • Storage/WebStorageManager.mm:

(+[WebStorageManager closeIdleLocalStorageDatabases]):

  • Storage/WebStorageManagerPrivate.h:

Tools:

Add an JS method to TestRunner, to enable testing closing idle local storage databases in
DumpRenderTree layout tests.

  • DumpRenderTree/TestRunner.cpp:

(closeIdleLocalStorageDatabasesCallback):
(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:

(TestRunner::closeIdleLocalStorageDatabases):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::closeIdleLocalStorageDatabases):

  • DumpRenderTree/gtk/TestRunnerGtk.cpp:

(TestRunner::closeIdleLocalStorageDatabases):

  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::closeIdleLocalStorageDatabases):

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::closeIdleLocalStorageDatabases):

  • DumpRenderTree/wx/TestRunnerWx.cpp:

(TestRunner::closeIdleLocalStorageDatabases):

LayoutTests:

  • storage/domstorage/localstorage/close-idle-localstorage-databases-immediately-expected.txt: Added.
  • storage/domstorage/localstorage/close-idle-localstorage-databases-immediately.html: Added.
  • storage/resources/storage-close-idle-localstorage-databases-immediately.html: Added.
2:29 AM Changeset in webkit [136322] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[CoordinatedGraphics] Crash in TextureMapperLayer::setBackingStore()
https://bugs.webkit.org/show_bug.cgi?id=103714

Patch by No'am Rosenthal <Noam Rosenthal> on 2012-12-02
Reviewed by Kenneth Rohde Christiansen.

Remove a layer from the m_pendingSyncBackingStores map when it is deleted.

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::deleteLayer):

2:27 AM Changeset in webkit [136321] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Adding checks for null when checking cookie status in CookieJarBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=103748

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-12-02
Reviewed by Rob Buis.

Updating CookieJarBlackBerry::cookieEnabled and have other methods in the class call that
method. Also, adding null checks for document->settings().

No change in behaviour.

  • loader/blackberry/CookieJarBlackBerry.cpp:

(WebCore::cookies):
(WebCore::setCookies):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::cookieRequestHeaderFieldValue):

2:27 AM WebInspector edited by mousewiki@yahoo.com
(diff)
2:27 AM WebInspector edited by zandobersek@gmail.com
Removing spam. (diff)
2:12 AM Changeset in webkit [136320] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][WK2] MiniBrowser should have a legacy mode
https://bugs.webkit.org/show_bug.cgi?id=103679

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-12-02
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

We need a way to create a web view in legacy mode, while still using the default context.
WKViewCreate creates a legacy view, so change it to create a default context if a context
was not passed.

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_base_add):

Tools:

Add an option to start MiniBrowser in legacy mode.

  • MiniBrowser/efl/main.c:

(window_create):
(elm_main):

1:45 AM Changeset in webkit [136319] by mkwst@chromium.org
  • 21 edits
    1 move in trunk

Unreviewed, rolling out r136236.
http://trac.webkit.org/changeset/136236
https://bugs.webkit.org/show_bug.cgi?id=103833

[chromium] Flakey crashes in SpeechRecognitionEvent::emma
during GC. (Requested by mkwst on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-02

Source/WebCore:

  • Modules/speech/SpeechRecognition.cpp:

(WebCore::SpeechRecognition::start):

  • Modules/speech/SpeechRecognition.h:

(SpeechRecognition):

  • Modules/speech/SpeechRecognitionEvent.cpp:

(WebCore::SpeechRecognitionEvent::SpeechRecognitionEvent):

  • Modules/speech/SpeechRecognitionEvent.h:

(SpeechRecognitionEventInit):
(SpeechRecognitionEvent):
(WebCore::SpeechRecognitionEvent::resultIndex):

  • Modules/speech/SpeechRecognitionEvent.idl:
  • Modules/speech/SpeechRecognitionResult.cpp:

(WebCore::emmaQualifiedName):
(WebCore):
(WebCore::SpeechRecognitionResult::emma):

  • Modules/speech/SpeechRecognitionResult.h:

(WebCore):
(WebCore::SpeechRecognitionResult::final):
(SpeechRecognitionResult):

  • Modules/speech/SpeechRecognitionResult.idl:
  • WebCore.gypi:
  • bindings/v8/custom/V8SpeechRecognitionResultCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8SpeechRecognitionEventCustom.cpp.

(WebCore):
(WebCore::V8SpeechRecognitionResult::opaqueRootForGC):

Source/WebKit/chromium:

  • public/WebSpeechRecognizerClient.h:
  • src/SpeechRecognitionClientProxy.cpp:
  • src/SpeechRecognitionClientProxy.h:

(SpeechRecognitionClientProxy):

Tools:

  • DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:

LayoutTests:

  • fast/speech/scripted/emma-expected.txt:
  • fast/speech/scripted/emma.html:
  • fast/speech/scripted/speechrecognition-basics-expected.txt:
  • fast/speech/scripted/speechrecognition-basics.html:
12:00 AM Changeset in webkit [136318] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

CodeBlock should be able to dump bytecode to something other than WTF::dataFile()
https://bugs.webkit.org/show_bug.cgi?id=103832

Reviewed by Oliver Hunt.

Add a PrintStream& argument to all of the CodeBlock bytecode dumping methods.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecodeCommentAndNewLine):
(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::dumpStructure):
(JSC::dumpChain):
(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dumpBytecode):

  • bytecode/CodeBlock.h:

(CodeBlock):

  • jit/JITDisassembler.cpp:

(JSC::JITDisassembler::dumpForInstructions):

Dec 1, 2012:

11:55 PM Changeset in webkit [136317] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

PDFPlugin: Support PDF form editing in <iframe>s
https://bugs.webkit.org/show_bug.cgi?id=103287
<rdar://problem/10326917>

Reviewed by Dan Bernstein.

PDFPlugin form editing depends on having a Document that has the same
size and position as the plugin; this is true not only in the full-main-frame
case, but also in the <iframe> case. Therefore, we can enable form editing
for <iframe> PDFPlugins.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::supportsForms): Support form editing whenever
our Document's widget is our PluginView (which will only be true in the
full-main-frame or <iframe> case).

11:51 PM Changeset in webkit [136316] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

PDFPlugin: <embed> and <object> PDFs affect their parent frame's page scale
https://bugs.webkit.org/show_bug.cgi?id=103286
<rdar://problem/12752315>

Reviewed by Dan Bernstein.

Detecting whether or not a PDFPlugin is a full-page plugin or not is not
as simple as checking isMainFrame(), because <embed> and <object> will
cause PDFPlugin to live in the main frame, while still not being full-page.
We also have to check that the main frame's document is a PluginDocument,
and whether that PluginDocument's PluginWidget is our PDFPlugin's PluginView.

  • WebProcess/Plugins/PDF/PDFPlugin.h:

(PDFPlugin): Add isFullFramePlugin.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::isFullFramePlugin): Check whether the main frame is
backed by a PluginDocument, and that that PluginDocument corresponds
to this PDFPlugin.
(WebKit::PDFPlugin::handlesPageScaleFactor): Use isFullFramePlugin.
(WebKit::PDFPlugin::supportsForms): Use isFullFramePlugin.

11:44 PM Changeset in webkit [136315] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

[wk2] Use spoolRect instead of snapshots for print preview
https://bugs.webkit.org/show_bug.cgi?id=103798
<rdar://problem/12686749>

Reviewed by Sam Weinig.

Revert to using spoolRect instead of snapshotting for printing; this was a bogus
change I made in http://trac.webkit.org/changeset/133935 which was irrelevant to
the core of that change, and incorrectly disregards the Frame parameter passed to
beginPrinting, instead using the WebPage's current Frame.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::drawRectToImage):

11:06 PM Changeset in webkit [136314] by zandobersek@gmail.com
  • 4 edits in trunk/Tools

[XvfbDriver] XvfbDriverTest.test_next_free_display is flaky on builders using XvfbDriver
https://bugs.webkit.org/show_bug.cgi?id=103806

Reviewed by Dirk Pranke.

There are occasional mishaps on builders where XvfbDriver doesn't properly
clean up the Xvfb instance it was managing so the related guard lock files
are still existing when the webkitpy unit tests are run. This can cause failures
in XvfbDriverTest.test_next_free_display as the test tries to acquire displays
with a specific number but is unable to due to the stale locks.

The solution to this is to use MockFileLock when inside unit test. This is achievable
by creating a file lock through the SystemHost instance connected to the Port object,
the latter available to the Driver.

  • Scripts/webkitpy/common/system/file_lock_mock.py:

(MockFileLock.acquire_lock): Return True to signal lock acquiring succeeded.
(MockFileLock.release_lock): Return True to signal lock releasing succeeded.

  • Scripts/webkitpy/layout_tests/port/xvfbdriver.py:

(XvfbDriver._next_free_display): Create the file lock through a mockable way.

  • Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:

(XvfbDriverTest.test_next_free_display): Enable back the unit test.

10:35 PM WebInspector edited by mousewiki@yahoo.com
(diff)
4:31 PM Changeset in webkit [136313] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r136015.
http://trac.webkit.org/changeset/136015
https://bugs.webkit.org/show_bug.cgi?id=103821

Did not heal performance bot and caused other performance
regressions (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-01

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

2:34 PM EFLWebKit edited by laszlo.gombos@gmail.com
fix the spelling for cmakeargs - see … (diff)
1:33 PM Changeset in webkit [136312] by mkwst@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Skipping crashing tests.

The DEPS roll containing r170422 is causing three crashes cross-platform
in the Chromium port. Skipping them here, filed crbug.com/163785 to fix.

  • platform/chromium/TestExpectations:

Marked media/encrypted-media/encrypted-media-events.html,
media/encrypted-media/encrypted-media-not-loaded.html, and
media/encrypted-media/encrypted-media-syntax.html as crashing.

12:00 PM Changeset in webkit [136311] by mkwst@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Skipping calendar-picker-datetime-with-step.html.

It looks like platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html
started failing at midnight PST, December 1st. I don't think it handled
the month change correctly. Filed https://bugs.webkit.org/show_bug.cgi?id=103817
to cover the fix.

  • platform/chromium/TestExpectations:
10:43 AM Changeset in webkit [136310] by kov@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.10/Source

Merge 133059 - Enable webkit2 introspection
https://bugs.webkit.org/show_bug.cgi?id=94313

Patch by Jesse van den Kieboom <jessevdk@gnome.org> on 2012-10-31
Reviewed by Martin Robinson.

This patch enables generation of introspection information for webkit2
in the same was as it is done for webkit. The resulting gir and
typelib file are named WebKit2-3.0.{gir,typelib}.

  • GNUmakefile.am:
  • UIProcess/API/gtk/WebKitBackForwardList.cpp:
4:39 AM Changeset in webkit [136309] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

DRT - crashed in WebCore::SearchFieldCancelButtonElement::defaultEventHandler
https://bugs.webkit.org/show_bug.cgi?id=103592

Patch by Xiaobo Wang <xiaobo.wang@torchmobile.com.cn> on 2012-12-01
Reviewed by Kent Tamura.

The crash happened when the search field cancel button handles mouseout
event after the search input was detached. When it happens the input
element returned from shadowHost() is null, need to check the pointer
before dereferencing.
InputFieldSpeechButton and SearchFieldResultsButtonElement have the
similar issue.

No new tests. The patch fixes the following test on BlackBerry platform.
Test: fast/forms/search-delete-while-cancel-button-clicked.html

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):

3:09 AM Changeset in webkit [136308] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[GTK] A11y tests in WK2 report badly-formatted AX roles
https://bugs.webkit.org/show_bug.cgi?id=102947

Reviewed by Xan Lopez.

As in DRT, convert the ATK accessibility roles to corresponding AXRoles.
These are expected in both tests and their baselines.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::roleToString):
(WTR):
(WTR::AccessibilityUIElement::role):

12:33 AM Changeset in webkit [136307] by mkwst@chromium.org
  • 2 edits in trunk/LayoutTests

[gtk] Unreviewed gardening. Skipping CSP 1.1 tests.

The CSP 1.1 tests are failing under GTK after r136305 made the CSP_NEXT
flag runtime enabled. Will fix in webkit.org/b/103810, skipping for now.

  • platform/gtk/TestExpectations:

Skipping CSP 1.1 tests.

Nov 30, 2012:

11:09 PM Changeset in webkit [136306] by rniwa@webkit.org
  • 2 edits
    1 move in trunk/LayoutTests

Shorten a file name as the test renamed in r136122 is still hosing Chromium Win perf. bot.

  • http/tests/inspector/network/resources/script-as-text-with-a-very-very-very-very-very-very-very-very-very-very-very-very-very-very-long-url.php: Renamed.
  • http/tests/inspector/network/resources/script-as-text-with-a-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-long-url.php: Removed.
  • http/tests/inspector/network/script-as-text-loading-long-url.html:
10:53 PM Changeset in webkit [136305] by mkwst@chromium.org
  • 11 edits in trunk

CSP 1.1: Make the CSP_NEXT flag runtime enabled.
https://bugs.webkit.org/show_bug.cgi?id=103652

Reviewed by Adam Barth.

Source/WebCore:

Content Security Policy 1.1 continues to live behind the CSP_NEXT flag,
this patch adds another layer on top of that in order to enable runtime
decisions about whether it should be active.

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::experimentalContentSecurityPolicyFeaturesEnabled):
(WebCore::RuntimeEnabledFeatures::setExperimentalContentSecurityPolicyFeaturesEnabled):

Adds methods in order to correctly handle enabling and disabling
CSP 1.1 features.

  • dom/Document.idl:

Gate the 'document.securityPolicy' object on the runtime flag.

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::addDirective):

Check that experimental features are runtime enabled before
processing 1.1 directives.

(WebCore::ContentSecurityPolicy::experimentalFeaturesEnabled):
(WebCore):

  • page/ContentSecurityPolicy.h:

Adds a new method which checks against the runtime flag to determine
whether CSP 1.1 features are enabled.

Source/WebKit/chromium:

The CSP_NEXT flag continues to be enabled on the Chromium port, but this
patch now locks the features away behind the securityPolicy runtime
flag.

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableExperimentalContentSecurityPolicyFeatures):
(WebKit):
(WebKit::WebRuntimeFeatures::isExperimentalContentSecurityPolicyFeaturesEnabled):

Adds the feature to WebRuntimeFeatures so it can be toggled from
inside Chromium.

Tools:

Ensures that the new SecurityPolicy runtime flag is enabled for Chromium's tests.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

10:18 PM Changeset in webkit [136304] by ryuan.choi@samsung.com
  • 2 edits in trunk/LayoutTests

[EFL][WK1] Gardening test cases which are not crashed after r135662
https://bugs.webkit.org/show_bug.cgi?id=103803

Unreviewed, EFL gardening.

Patch by Sujin Park <sujjin.park@gmail.com> on 2012-11-30

  • platform/efl-wk1/TestExpectations:
10:12 PM Changeset in webkit [136303] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Avoid calling into NSUserDefaults every time we start a scroll
https://bugs.webkit.org/show_bug.cgi?id=103804

Reviewed by Dan Bernstein.

Cache the NSScrollAnimationEnabled preference to avoid
hitting NSUserDefaults every time we start scrolling.

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::scrollAnimationEnabledForSystem):

6:24 PM Changeset in webkit [136302] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Always listen for the DidFirstLayout layout milestone
https://bugs.webkit.org/show_bug.cgi?id=103795
<rdar://problem/12790268>

Reviewed by Dan Bernstein.

The DidFirstLayout layout milestone is used to determine when to unfreeze the layer tree, so we always want to listen for it.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

5:40 PM Changeset in webkit [136301] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Removed temporary debugging change from DRT (r136300).

  • DumpRenderTree/win/DumpRenderTree.cpp:

(dump):

5:23 PM Changeset in webkit [136300] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Temporary change to DRT for debugging purposes.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(dump):

5:19 PM Changeset in webkit [136299] by pierre.rossi@gmail.com
  • 4 edits in trunk/Source

[Qt] Unreviewed speculative Mac build fix after r136232

Source/JavaScriptCore:

Update the include path so that LLIntAssembly.h is picked up.
The bot didn't break until later when a clean build was triggered.

Source/WebKit2:

cleanup an oversight from r136235

  • PluginProcess.pro: s/webkit/webkitwidgets/
4:53 PM Changeset in webkit [136298] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=103790
The LayerPool m_pruneTimer should have a longer delay

Reviewed by Simon Fraser.

A 1 second delay is more appropriate here.

  • platform/graphics/ca/mac/LayerPool.mm:

(WebCore::LayerPool::schedulePrune):

4:50 PM Changeset in webkit [136297] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Optimise more cases of op_typeof
https://bugs.webkit.org/show_bug.cgi?id=103783

Reviewed by Mark Hahnenberg.

Increase our coverage of typeof based typechecks by
making sure that the codegenerators always uses
consistent operand ordering when feeding typeof operations
into equality operations.

  • bytecompiler/NodesCodegen.cpp:

(JSC::BinaryOpNode::emitBytecode):
(JSC::EqualNode::emitBytecode):
(JSC::StrictEqualNode::emitBytecode):

4:43 PM Changeset in webkit [136296] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Windows build fix.

Add a default: entry to an case statement to fix a build error when compiled in VS2005.

  • html/MediaController.cpp:

(MediaController::playbackState):

4:13 PM Changeset in webkit [136295] by jer.noble@apple.com
  • 7 edits
    1 copy
    1 add in trunk

Add support for the 'unpause()' method on MediaController.
https://bugs.webkit.org/show_bug.cgi?id=103751

Reviewed by Eric Carlson.

Source/WebCore:

The MediaController spec has been updated to add an unpause() method
which is functionally identical to the old play() method, and changes
the semantics of play() to call play() on the underlying slaved media
elements. The spec also added a playbackState() method, returning a
string representing the last calculated playback state.

Test: media/media-controller-unpause.html

  • html/MediaController.cpp:

(MediaController::unpause): Renamed from play().
(MediaController::play): Added. Same as unpause(), but also call

play() on slaved media elements.

(playbackStateWaiting): Static string accessor.
(playbackStatePlaying): Ditto.
(playbackStateEnded): Ditto.
(MediaController::playbackState): Added. Returns string value of

m_playbackState.

  • html/MediaController.h:
  • html/MediaController.idl:

LayoutTests:

Add new test for unpause() and playbackState() methods.

  • media/media-controller-unpause.html:
  • media/media-controller-unpause-expected.txt:
  • media/media-controller-playback.html:
  • media/media-controller-playback-expected.txt:
3:59 PM Changeset in webkit [136294] by jchaffraix@webkit.org
  • 5 edits in trunk/Source/WebCore

[CSS Grid Layout] Align the grid track code with the specification's production rules
https://bugs.webkit.org/show_bug.cgi?id=103703

Reviewed by Alexis Menard.

In order to support more of the syntax and make the code more readable, this change
splits following the grammar's production rules (see
http://dev.w3.org/csswg/css3-grid-layout/#grid-definition-columns-and-grid-definit).

Refactoring covered by existing tests.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridTrackMinMax):
(WebCore::valueForGridTrackGroup):
(WebCore::valueForGridTrackList):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseGridTrackGroup):
(WebCore::CSSParser::parseGridTrackMinMax):

  • css/CSSParser.h:
  • css/StyleResolver.cpp:

(WebCore::createGridTrackMinMax):
(WebCore::createGridTrackGroup):
(WebCore::createGridTrackList):
Mechanical split of the parsing, resolving and computed style code into
<track-list>, <track-group>, <track-minmax> and <track-breadth> parts.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseGridBreadth):
Changed this function to just parse a single value (without any extra logic).

  • css/StyleResolver.cpp:

(WebCore::createGridTrackBreadth):
Changed this function to take a Length as it is used to parse a <track-breadth>.
The goal is for it to be the low-level function createGridTrackMinmax will call on
each function parameter.

3:56 PM Changeset in webkit [136293] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix potential crash when canceling animations on renderers with no node
https://bugs.webkit.org/show_bug.cgi?id=103784

Reviewed by Dan Bernstein.

We could crash when tearing down RenderScrollbars because we hit
AnimationController::cancelAnimations() for a renderer with no node.
The assertion already check for a null node, but the line after
does not, so fix that.

I tried to make a test with animations/transitions on a custom scrollbar, but was not able
to get it to crash.

  • page/animation/AnimationController.cpp:

(WebCore::AnimationController::cancelAnimations):

3:36 PM Changeset in webkit [136292] by bfulgham@webkit.org
  • 6 edits
    1 move
    10 adds
    1 delete in trunk/Source

Source/WebKit/win: [Windows, WinCairo] Generate library export definition file.
https://bugs.webkit.org/show_bug.cgi?id=103687

Reviewed by Tim Horton.

Update project solutions to use the new generated *.def files.

  • WebKit.vcproj/WebKit.sln: Update for new project and file

locations.

Source/WebKit2: [Windows, WinCairo] Generate library export symbol file.
https://bugs.webkit.org/show_bug.cgi?id=103687

Reviewed by Tim Horton.

Generate the export definition file based on the compile options
and port settings. Get rid of the old hand-written file, and use
a revised master input file that allows using conditional
settings to generate the output, much like the Mac and other
ports do.

  • win/WebKit2.def: Removed.
  • win/WebKit2.def.in: Added.
  • win/WebKit2Apple.vsprops:
  • win/WebKit2CFLite.def: Removed.
  • win/WebKit2CFLite.vsprops:
  • win/WebKit2Common.vsprops:
  • win/WebKit2ExportGenerator.vcproj: Added.
  • win/WebKit2ExportGeneratorCommon.vsprops: Added.
  • win/WebKit2ExportGeneratorDebug.vsprops: Added.
  • win/WebKit2ExportGeneratorDebugAll.vsprops: Added.
  • win/WebKit2ExportGeneratorDebugCairoCFLite.vsprops: Added.
  • win/WebKit2ExportGeneratorPostBuild.cmd: Added.
  • win/WebKit2ExportGeneratorPreBuild.cmd: Added.
  • win/WebKit2ExportGeneratorProduction.vsprops: Added.
  • win/WebKit2ExportGeneratorRelease.vsprops: Added.
  • win/WebKit2ExportGeneratorReleaseCairoCFLite.vsprops: Added.
3:33 PM Changeset in webkit [136291] by cevans@google.com
  • 1 edit in branches/chromium/1312/Source/WebCore/platform/graphics/chromium/FontPlatformDataChromiumWin.h

Merge 134902
BUG=157875
Review URL: https://codereview.chromium.org/11419266

3:33 PM Changeset in webkit [136290] by cevans@google.com
  • 9 edits in branches/chromium/1312/Source/WebCore/platform/graphics

Merge 134871
BUG=157875
Review URL: https://codereview.chromium.org/11348334

3:30 PM Changeset in webkit [136289] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

PluginDocument fires didFinishDocumentLoadForFrame upon receiving initial bytes instead of when load completes
https://bugs.webkit.org/show_bug.cgi?id=103702
<rdar://problem/12762534>

Reviewed by Alexey Proskuryakov.

Remove the call to finish() from PluginDocumentParser::appendBytes().

This was introduced in http://trac.webkit.org/changeset/14838, when finish() wouldn't get
called for PluginDocuments any other way. In the time since, DocumentWriter::end() was made
to call finish() anyway, at the correct time (the call from appendBytes makes a PluginDocument
appear to be finished loading after the first bytes are received).

No new tests, because there doesn't seem to be any state in a PluginDocument that can be accessed
from JavaScript to determine whether or not it has finished loading.

  • html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::appendBytes):

3:21 PM Changeset in webkit [136288] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

RenderBlock minor clean-up: replace raw pointers with OwnPtrs.
https://bugs.webkit.org/show_bug.cgi?id=103690

Reviewed by Eric Seidel.

raw pointers were replaced with OwnPtrs.
Probably we also gain a small performance improvements because
I replaced get && remove pair with take.

  • rendering/RenderBlock.cpp:

(WebCore):
(WebCore::removeBlockFromDescendantAndContainerMaps):
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::addContinuationWithOutline):
(WebCore::RenderBlock::paintContinuationOutlines):
(WebCore::RenderBlock::insertIntoTrackedRendererMaps):
(WebCore::RenderBlock::removeFromTrackedRendererMaps):
(WebCore::RenderBlock::setDesiredColumnCountAndWidth):

  • rendering/RenderBlock.h:

(WebCore):

3:21 PM Changeset in webkit [136287] by zmo@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, webkit gardening, fix webkit lint.

  • platform/chromium/TestExpectations:
3:17 PM Changeset in webkit [136286] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1312

Merge 136060
BUG=158693
Review URL: https://codereview.chromium.org/11416300

3:12 PM Changeset in webkit [136285] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1312

Merge 135914
BUG=158695
Review URL: https://codereview.chromium.org/11415245

3:12 PM Changeset in webkit [136284] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Use the correct path to a test in TestExpectations.

  • platform/chromium/TestExpectations:
3:07 PM Changeset in webkit [136283] by cevans@google.com
  • 1 edit in branches/chromium/1312/Source/WebCore/page/EventHandler.cpp

Merge 136062
BUG=159219
Review URL: https://codereview.chromium.org/11415242

3:04 PM Changeset in webkit [136282] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

WebGL: Add a class to abstract the status of the Image in texImage2D() and texSubImage2D()
https://bugs.webkit.org/show_bug.cgi?id=103606

Patch by Jun Jiang <jun.a.jiang@intel.com> on 2012-11-30
Reviewed by Kenneth Russell.

In texImage2D() and texSubImage2D() for WebGL, the status of the Image is extracted and kept in the function GraphicsContext3D::getImageData() but provides no interface or guaranteed way to use the status of the Image outside GraphicsContext3D::getImageData() safely. For example, you can not get the address of the raw Image data and operate it outside the scope of the GraphicsContext3D::getImageData() and there is at least one memory copy existed from the Image to the intermediate vector.

This patch refactors the code by adding a ImageExtractor class to abstract and keep the status of the Image. The lifetime and validity of Image status are determined by the lifetime of the object instead of the scope of getImageData(). It provides flexibility on future optimizations.

No new tests. It is a code refactoring patch.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::texImage2DImpl):
(WebCore::WebGLRenderingContext::texSubImage2DImpl):

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::ImageExtractor):
(WebCore):
(WebCore::GraphicsContext3D::packImageData):

  • platform/graphics/GraphicsContext3D.h:

(WebCore):
(GraphicsContext3D):
(ImageExtractor):
(WebCore::GraphicsContext3D::ImageExtractor::extractSucceeded):
(WebCore::GraphicsContext3D::ImageExtractor::imagePixelData):
(WebCore::GraphicsContext3D::ImageExtractor::imageWidth):
(WebCore::GraphicsContext3D::ImageExtractor::imageHeight):
(WebCore::GraphicsContext3D::ImageExtractor::imageSourceFormat):
(WebCore::GraphicsContext3D::ImageExtractor::imageAlphaOp):
(WebCore::GraphicsContext3D::ImageExtractor::imageSourceUnpackAlignment):

  • platform/graphics/NativeImagePtr.h:
  • platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::~ImageExtractor):
(WebCore):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

  • platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::~ImageExtractor):
(WebCore):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

  • platform/graphics/clutter/GraphicsContext3DClutter.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::~ImageExtractor):
(WebCore):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::~ImageExtractor):
(WebCore):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::~ImageExtractor):
(WebCore):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

  • platform/graphics/skia/GraphicsContext3DSkia.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::~ImageExtractor):
(WebCore):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

3:01 PM Changeset in webkit [136281] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1312

Merge 136034
BUG=146882
Review URL: https://codereview.chromium.org/11299286

3:00 PM Changeset in webkit [136280] by Simon Fraser
  • 6 edits in trunk

Make RenderLayer::updateLayerPosition() private
https://bugs.webkit.org/show_bug.cgi?id=102624

Reviewed by Ryosuke Niwa.

Source/WebCore:

Made updateLayerPosition() private. The only external caller was
MouseRelatedEvent::computeRelativePosition(), which has no business updating
layer positions. In fact it had positively dangerous behavior; doing just
a style update without layout, and then calling absoluteToLocal() and walking
layers. Fixed by having it call updateLayoutIgnorePendingStylesheets().

This revealed a bug where event.offsetX/offsetY could be wrong in some cases.
fast/events/stopPropagation-submit.html does a simulated click (which has
client coordinates at 0,0), so the image submit coordinates were incorrectly
0,0. Now that we do layout before computing them, they are correctly reported
as being relative to the element.

  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::computeRelativePosition):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositionsAfterScroll):

  • rendering/RenderLayer.h:

(RenderLayer):

LayoutTests:

New results with correctly computed event offsets.

  • fast/events/stopPropagation-submit-expected.txt:
2:45 PM Changeset in webkit [136279] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1312

Merge 135719
BUG=161690
Review URL: https://codereview.chromium.org/11316291

2:43 PM Changeset in webkit [136278] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1271

Merge 135719
BUG=161690
Review URL: https://codereview.chromium.org/11434065

2:30 PM Changeset in webkit [136277] by Simon Fraser
  • 7 edits in trunk/Source/WebCore

Late-loading stylesheets can cause composited layers to be blank
https://bugs.webkit.org/show_bug.cgi?id=103773

Reviewed by Tim Horton.

Early painting can be short-circuited in RenderBlock::paintContents() if we know a stylesheet
is pending, which is done to avoid a flash of unstyled content (FOUC). When the stylesheet
finally loaded, Document::styleResolverChanged() would try to repaint everything by calling
repaint() on the RenderView(). In a composited world, however, this repaint() doesn't repaint
composited layers.

This was particularly prevalent on this specific URL because it failed to load
a CSS file from typekit.com, so Document::styleResolverChanged()
just did the repaint and returned (rather than doing a recalc style as would
happen for correctly loaded stylesheets).

Fix by making a way to repaint all compositing layers, and calling it
from Document::styleResolverChanged().

No tests because this is timing-dependant.

  • dom/Document.cpp:

(WebCore::Document::styleResolverChanged): Call repaintViewAndCompositedLayers().

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintContents): Fix the comment.

  • rendering/RenderLayerCompositor.cpp: Convert repaintCompositedLayersAbsoluteRect()

and associated recursiveRepaintLayerRect() to allow the rect to be null, which indicates
that we should just repaint the entire layer, and improve their names.
(WebCore::RenderLayerCompositor::repaintCompositedLayers):
(WebCore::RenderLayerCompositor::recursiveRepaintLayer):

  • rendering/RenderLayerCompositor.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::repaintRectangleInViewAndCompositedLayers): repaintCompositedLayersAbsoluteRect()
was renamed to repaintCompositedLayers().
(WebCore::RenderView::repaintViewAndCompositedLayers):

  • rendering/RenderView.h:

(RenderView): repaintViewRectangle() and repaintRectangleInViewAndCompositedLayers() should not
be virtual. Add repaintViewAndCompositedLayers().

1:56 PM Changeset in webkit [136276] by fpizlo@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

Rationalize and clean up DFG handling of scoped accesses
https://bugs.webkit.org/show_bug.cgi?id=103715

Reviewed by Oliver Hunt.

Previously, we had a GetScope node that specified the depth to which you wanted
to travel to get a JSScope, and the backend implementation of the node would
perform all of the necessary footwork, including potentially skipping the top
scope if necessary, and doing however many loads were needed. But there were
strange things. First, if you had accesses at different scope depths, then the
loads to get to the common depth could not be CSE'd - CSE would match only
GetScope's that had identical depth. Second, GetScope would be emitted even if
we already had the scope, for example in put_to_base. And finally, even though
the ResolveOperations could tell us whether or not we had to skip the top scope,
the backend would recompute this information itself, often pessimistically.

This eliminates GetScope and replaces it with the following:

GetMyScope: just get the JSScope from the call frame header. This will forever
mean getting the JSScope associated with the machine call frame; it will not
mean getting the scope of an inlined function. Or at least that's the intent.

SkipTopScope: check if there is an activation, and if so, skip a scope. This
takes a scope as a child and returns a scope.

SkipScope: skip one scope level.

The bytecode parser now emits the right combination of the above, and
potentially emits multiple SkipScope's, based on the ResolveOperations.

This change also includes some fixups to debug logging. We now always print
the ExecutableBase* in addition to the CodeBlock* in the CodeBlock's dump,
and we are now more verbose when dumping CodeOrigins and InlineCallFrames.

This is performance-neutral. It's just meant to be a clean-up.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpAssumingJITType):

  • bytecode/CodeOrigin.cpp:

(JSC::CodeOrigin::inlineStack):
(JSC::CodeOrigin::dump):
(JSC):
(JSC::InlineCallFrame::dump):

  • bytecode/CodeOrigin.h:

(CodeOrigin):
(InlineCallFrame):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(JSC::DFG::ByteCodeParser::getScope):
(DFG):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::scopedVarLoadElimination):
(JSC::DFG::CSEPhase::scopedVarStoreElimination):
(JSC::DFG::CSEPhase::getMyScopeLoadElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::dump):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dumpCodeOrigin):
(JSC::DFG::Graph::dumpBlockHeader):

  • dfg/DFGNode.h:

(Node):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITDisassembler.cpp:

(JSC::JITDisassembler::dump):

1:54 PM Changeset in webkit [136275] by commit-queue@webkit.org
  • 17 edits
    3 deletes in trunk

Unreviewed, rolling out r136142.
http://trac.webkit.org/changeset/136142
https://bugs.webkit.org/show_bug.cgi?id=103768

break a bunch of interactive_ui_tests in chromium win
(Requested by zhenyao_home on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-30

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:
  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::layout):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

(StyleRareInheritedData):

LayoutTests:

  • fast/ruby/position-after.html: Removed.
  • platform/mac/fast/ruby/position-after-expected.png: Removed.
  • platform/mac/fast/ruby/position-after-expected.txt: Removed.
1:53 PM Changeset in webkit [136274] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1312

Merge 135740
BUG=158204
Review URL: https://codereview.chromium.org/11348330

1:52 PM Changeset in webkit [136273] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1271

Merge 135740
BUG=158204
Review URL: https://codereview.chromium.org/11418272

1:48 PM Changeset in webkit [136272] by jsbell@chromium.org
  • 9 edits in trunk/Source/WebCore

IndexedDB: Replace use of ScriptExecutionContext::Task (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=101483

Reviewed by Tony Chang.

The IDB back end (which runs on a single thread) makes use of ScriptExecutionContext's
Task and facilities for cross-task posting with callbacks, and requires decorating various
IDB classes with "ThreadSafe" when they are not. Move towards encapsulating the tasks
in "Operation" classes which are IDB-operation specific.

Part 1 (this patch) retains the use of ScriptExecutionContext::Task but wraps the creation
and the callback function in an Operation class which will be fleshed out in later patches.
As an aside, a little bit of RefPtr churn is eliminated, and IDB_TRACE sprinkled in.

No new tests - just a refactor.

  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(IDBCursorBackendImpl::CursorIterationOperation):
(WebCore::IDBCursorBackendImpl::CursorIterationOperation::create):
(WebCore):
(IDBCursorBackendImpl::CursorAdvanceOperation):
(WebCore::IDBCursorBackendImpl::CursorAdvanceOperation::create):
(IDBCursorBackendImpl::CursorPrefetchIterationOperation):
(WebCore::IDBCursorBackendImpl::CursorPrefetchIterationOperation::create):
(WebCore::IDBCursorBackendImpl::continueFunction):
(WebCore::IDBCursorBackendImpl::advance):
(WebCore::IDBCursorBackendImpl::CursorAdvanceOperation::perform):
(WebCore::IDBCursorBackendImpl::CursorIterationOperation::perform):
(WebCore::IDBCursorBackendImpl::prefetchContinue):
(WebCore::IDBCursorBackendImpl::CursorPrefetchIterationOperation::perform):

  • Modules/indexeddb/IDBCursorBackendImpl.h:

(IDBCursorBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(IDBDatabaseBackendImpl::CreateObjectStoreOperation):
(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreOperation::create):
(WebCore):
(IDBDatabaseBackendImpl::DeleteObjectStoreOperation):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreOperation::create):
(IDBDatabaseBackendImpl::VersionChangeOperation):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::create):
(IDBDatabaseBackendImpl::CreateObjectStoreAbortOperation):
(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreAbortOperation::create):
(IDBDatabaseBackendImpl::DeleteObjectStoreAbortOperation):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreAbortOperation::create):
(IDBDatabaseBackendImpl::VersionChangeAbortOperation):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::create):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::perform):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(IDBIndexBackendImpl::OpenIndexCursorOperation):
(WebCore::IDBIndexBackendImpl::OpenIndexCursorOperation::create):
(WebCore):
(IDBIndexBackendImpl::IndexCountOperation):
(WebCore::IDBIndexBackendImpl::IndexCountOperation::create):
(IDBIndexBackendImpl::IndexReferencedValueRetrievalOperation):
(WebCore::IDBIndexBackendImpl::IndexReferencedValueRetrievalOperation::create):
(IDBIndexBackendImpl::IndexValueRetrievalOperation):
(WebCore::IDBIndexBackendImpl::IndexValueRetrievalOperation::create):
(WebCore::IDBIndexBackendImpl::OpenIndexCursorOperation::perform):
(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::IDBIndexBackendImpl::openKeyCursor):
(WebCore::IDBIndexBackendImpl::IndexCountOperation::perform):
(WebCore::IDBIndexBackendImpl::count):
(WebCore::IDBIndexBackendImpl::IndexReferencedValueRetrievalOperation::perform):
(WebCore::IDBIndexBackendImpl::IndexValueRetrievalOperation::perform):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):

  • Modules/indexeddb/IDBIndexBackendImpl.h:

(WebCore::IDBIndexBackendImpl::metadata):
(IDBIndexBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(IDBObjectStoreBackendImpl::ObjectStoreRetrievalOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreRetrievalOperation::create):
(WebCore):
(IDBObjectStoreBackendImpl::ObjectStoreStorageOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreStorageOperation::create):
(IDBObjectStoreBackendImpl::ObjectStoreIndexesReadyOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreIndexesReadyOperation::create):
(IDBObjectStoreBackendImpl::ObjectStoreDeletionOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreDeletionOperation::create):
(IDBObjectStoreBackendImpl::ObjectStoreClearOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreClearOperation::create):
(IDBObjectStoreBackendImpl::CreateIndexOperation):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexOperation::create):
(IDBObjectStoreBackendImpl::DeleteIndexOperation):
(WebCore::IDBObjectStoreBackendImpl::DeleteIndexOperation::create):
(IDBObjectStoreBackendImpl::OpenObjectStoreCursorOperation):
(WebCore::IDBObjectStoreBackendImpl::OpenObjectStoreCursorOperation::create):
(IDBObjectStoreBackendImpl::ObjectStoreCountOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreCountOperation::create):
(IDBObjectStoreBackendImpl::CreateIndexAbortOperation):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexAbortOperation::create):
(IDBObjectStoreBackendImpl::DeleteIndexAbortOperation):
(WebCore::IDBObjectStoreBackendImpl::DeleteIndexAbortOperation::create):
(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreRetrievalOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReady):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreIndexesReadyOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreStorageOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreDeletionOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::clear):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreClearOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):
(WebCore::IDBObjectStoreBackendImpl::DeleteIndexOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::openCursor):
(WebCore::IDBObjectStoreBackendImpl::OpenObjectStoreCursorOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::count):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreCountOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexAbortOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::DeleteIndexAbortOperation::perform):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

1:31 PM Changeset in webkit [136271] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Suppress the new separable mask blurs in skia until the tests can be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=103766

Unreviewed.

  • skia_webkit.gyp:
1:29 PM Changeset in webkit [136270] by Lucas Forschler
  • 4 edits in branches/safari-536.28-branch/Source

Versioning.

1:27 PM Changeset in webkit [136269] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1312

Merge 135193
BUG=156619
Review URL: https://codereview.chromium.org/11411295

1:26 PM Changeset in webkit [136268] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1271

Merge 135193
BUG=156619
Review URL: https://codereview.chromium.org/11418269

1:25 PM Changeset in webkit [136267] by Lucas Forschler
  • 1 copy in tags/Safari-536.28.5

New Tag.

1:25 PM Changeset in webkit [136266] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
1:24 PM Changeset in webkit [136265] by timothy_horton@apple.com
  • 9 edits in trunk/Source

(Simple)PDFPlugin: Support conversion of PostScript documents
https://bugs.webkit.org/show_bug.cgi?id=103289
<rdar://problem/10235708>

Reviewed by Dan Bernstein.

SimplePDFPlugin (and PDFPlugin) should support converting PostScript files
to PDF before handing them off to their respective backends.

As PDFPlugin inherits from SimplePDFPlugin, it gets the new functionality automatically.

  • WebProcess/Plugins/PDF/SimplePDFPlugin.h: Add convertPostScriptDataIfNeeded(), and m_isPostScript.
  • WebProcess/Plugins/PDF/SimplePDFPlugin.mm:

(WebKit::SimplePDFPlugin::pluginInfo): SimplePDFPlugin should claim to support PDF and PostScript.
(WebKit::convertPostScriptDataSourceToPDF): PS->PDF conversion code, copied from PDFViewController (which I intend to remove).
(WebKit::SimplePDFPlugin::convertPostScriptDataIfNeeded): Check if the loaded data represents a PS file; if so, convert it.
(WebKit::SimplePDFPlugin::streamDidReceiveResponse): Check if the loaded data is of MIME type application/postscript, and store that in m_isPostScript.
(WebKit::SimplePDFPlugin::streamDidFinishLoading): Call convertPostScriptDataIfNeeded when we finish loading.
(WebKit::SimplePDFPlugin::manualStreamDidReceiveResponse): Ditto from streamDidReceiveResponse.
(WebKit::SimplePDFPlugin::manualStreamDidFinishLoading): Ditto from streamDidFinishLoading.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin): Use (Simple)PDFPlugin for PostScript files too.

  • English.lproj/Localizable.strings:
  • WebCore.exp.in:
  • platform/LocalizedStrings.cpp:

(WebCore::postScriptDocumentTypeDescription):

  • platform/LocalizedStrings.h:

Add and export postScriptDocumentTypeDescription, for PostScript files.

1:21 PM Changeset in webkit [136264] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1312

Merge 135303
BUG=154488
Review URL: https://codereview.chromium.org/11421183

1:20 PM Changeset in webkit [136263] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1271

Merge 135303
BUG=154488
Review URL: https://codereview.chromium.org/11418268

1:11 PM Changeset in webkit [136262] by junov@google.com
  • 5 edits
    1 add in trunk

[Chromium] Animation updates fail when using a canvas as a CSS backround-image style with -webkit-canvas
https://bugs.webkit.org/show_bug.cgi?id=103643

Reviewed by Stephen White.

.:

New test to verify that elements using a canvas as a style image
source are redrawn when the canvas is animated. Added as a manual test
because the bug was not reproducible in DumpRenderTree.

  • ManualTests/animated-canvas-as-background.html: Added.

Source/WebCore:

CanvasRenderingContext2D::didDraw was not propagating the change
notification to observers in the accelerated compositing case.
Problem fixed by adding observer notifications.

New manual test: animated-canvas-as-background.html

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::didDraw):
The observer notification was factored out into a separate method
so that it can be invoked directly for accelerated compositing.
(WebCore):
(WebCore::HTMLCanvasElement::notifyObserversCanvasChanged):

  • html/HTMLCanvasElement.h:

(HTMLCanvasElement):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::didDraw):
Added observer notification call to trigger repainting of elements that
use this canvas for their style.

1:09 PM Changeset in webkit [136261] by oliver@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Add direct string->function code cache
https://bugs.webkit.org/show_bug.cgi?id=103764

Reviewed by Michael Saboff.

A fairly logically simple patch. We now track the start of the
unique portion of a functions body, and use that as our key for
unlinked function code. This allows us to cache identical code
in different contexts, leading to a small but consistent improvement
on the benchmarks we track.

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedFunctionExecutable::functionStartOffset):
(UnlinkedFunctionExecutable):

  • parser/ASTBuilder.h:

(ASTBuilder):
(JSC::ASTBuilder::setFunctionStart):

  • parser/Nodes.cpp:
  • parser/Nodes.h:

(JSC::FunctionBodyNode::setFunctionStart):
(JSC::FunctionBodyNode::functionStart):
(FunctionBodyNode):

  • parser/Parser.cpp:

(JSC::::parseFunctionInfo):

  • parser/Parser.h:

(JSC::Parser::findCachedFunctionInfo):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::setFunctionStart):

  • runtime/CodeCache.cpp:

(JSC::CodeCache::generateFunctionCodeBlock):
(JSC::CodeCache::getFunctionCodeBlock):
(JSC::CodeCache::usedFunctionCode):

  • runtime/CodeCache.h:
12:49 PM Changeset in webkit [136260] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

PDFPlugin: "Show Definition" context menu item should be implemented
https://bugs.webkit.org/show_bug.cgi?id=103389
<rdar://problem/12710751>

Reviewed by Dan Bernstein.

Call existing dictionary popup code when the context menu "Show Definition" item is selected.

  • WebProcess/Plugins/PDF/PDFPlugin.h:

(PDFPlugin): Add showDefinitionForAttributedString and convertFromPDFViewToRootView.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(-[WKPDFLayerControllerDelegate showDefinitionForAttributedString:atPoint:]): Forward this call to PDFPlugin.
(WebKit::PDFPlugin::showDefinitionForAttributedString): Create a DictionaryPopupInfo with the necessary information.
Ask WebPageProxy to show the dictionary popup.
(WebKit::PDFPlugin::convertFromPDFViewToRootView): Convert a point from PDFLayerController space to the root view space.

12:39 PM Changeset in webkit [136259] by yoli@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Set the minimal DOM timer interval to 4 milliseconds
https://bugs.webkit.org/show_bug.cgi?id=103534

Patch by Cosmin Truta (ctruta@rim.com)

Reviewed by Yong Li.

We align this behavior with other platforms.

  • Api/BlackBerryGlobal.cpp:

(BlackBerry::WebKit::globalInitialize):

12:20 PM Changeset in webkit [136258] by schenney@chromium.org
  • 135 edits
    1 move
    3 adds
    8 deletes in trunk/LayoutTests

[Chromium] Rebaselining tests affected by recent Skia changes

Unreviewed test expectations updates.

Due to the Win7 builders being so far behind, some Win7 expectations may be wrong.
Also fixes https://bugs.webkit.org/show_bug.cgi?id=103722

  • platform/chromium-linux-x86/svg/transforms: Added.
  • platform/chromium-linux-x86/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/chromium-linux/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-linux/fast/text/line-initial-and-final-swashes-expected.png: Removed.
  • platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-mac-lion/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-mac-lion/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac-lion/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/chromium-mac-lion/fast/box-shadow/inset-expected.png:
  • platform/chromium-mac-lion/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-mac-lion/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-mac-lion/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac-lion/fast/transforms/shadows-expected.png:
  • platform/chromium-mac-lion/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.png:
  • platform/chromium-mac-lion/svg/css/group-with-shadow-expected.png:
  • platform/chromium-mac-lion/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-mac-lion/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-mac-lion/svg/custom/pattern-rotate-expected.png:
  • platform/chromium-mac-lion/svg/custom/stroke-width-large-expected.png:
  • platform/chromium-mac-lion/svg/custom/use-transform-expected.png:
  • platform/chromium-mac-lion/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-mac-snowleopard/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-mac-snowleopard/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-vertical-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/pattern-rotate-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/stroke-width-large-expected.png:
  • platform/chromium-mac/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png:
  • platform/chromium-mac/fast/box-shadow/box-shadow-radius-expected.png:
  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/chromium-mac/fast/box-shadow/inset-box-shadow-radius-expected.png:
  • platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-mac/fast/box-shadow/inset-expected.png:
  • platform/chromium-mac/fast/box-shadow/scaled-box-shadow-expected.png:
  • platform/chromium-mac/fast/box-shadow/single-pixel-shadow-expected.png:
  • platform/chromium-mac/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac/fast/repaint/transform-replaced-shadows-expected.png:
  • platform/chromium-mac/fast/transforms/shadows-expected.png:
  • platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.png:
  • platform/chromium-mac/svg/css/group-with-shadow-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-mac/svg/custom/pattern-rotate-expected.png:
  • platform/chromium-mac/svg/custom/stroke-width-large-expected.png:
  • platform/chromium-mac/svg/custom/use-transform-expected.png:
  • platform/chromium-mac/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/chromium-mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium-win-xp/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-win-xp/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
  • platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
  • platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/color: Removed.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-win-xp/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
  • platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-expected.png:
  • platform/chromium-win/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-win/fast/text/line-initial-and-final-swashes-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/text/line-initial-and-final-swashes-expected.png.
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-win/svg/custom/pattern-rotate-expected.png:
  • platform/chromium-win/svg/custom/stroke-width-large-expected.png:
  • platform/chromium-win/svg/custom/use-transform-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/chromium/TestExpectations:
11:28 AM Changeset in webkit [136257] by Lucas Forschler
  • 1 edit in branches/safari-536.28-branch/Source/WebCore/English.lproj/Localizable.strings

Update localized strings.

11:19 AM Changeset in webkit [136256] by simonjam@chromium.org
  • 8 edits in trunk

Report CSS as initiator instead of elements, except body
https://bugs.webkit.org/show_bug.cgi?id=103546

Reviewed by Tony Gentilcore.

Source/WebCore:

The Resource Timing spec says the initiator should be "css" when the the load comes from a
url() rule in a stylesheet. Separately, WebKit reports <body background> as a CSS load, we
need to override that to match the spec.

Tests: http/tests/w3c/webperf/submission/resource-timing

  • css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::cachedImage):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::cachedImage): By default, the initiator is "css".

  • css/CSSImageValue.h:

(CSSImageValue):
(WebCore::CSSImageValue::setInitiator): Allow users to manually override it (see body).

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingImage):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::collectStyleForPresentationAttribute): Record "body" as the initiator.

LayoutTests:

  • platform/chromium/fast/loader/resource-request-callbacks-expected.txt: Rebaseline to match new behavior.
11:17 AM Changeset in webkit [136255] by simonjam@chromium.org
  • 3 edits in trunk/Source/WebCore

Remember the CachedResourceRequest for preloads
https://bugs.webkit.org/show_bug.cgi?id=102995

Reviewed by Tony Gentilcore.

Without this, the initiator is lost.

Tests: http/tests/w3c/webperf/submission/resource-timing

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::preload):
(WebCore::CachedResourceLoader::checkForPendingPreloads):
(WebCore::CachedResourceLoader::requestPreload):
(WebCore::CachedResourceLoader::isPreloaded):

  • loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):
(PendingPreload):

10:47 AM Changeset in webkit [136254] by Michelangelo De Simone
  • 3 edits
    6 adds in trunk

[CSS Shaders] Clamp input colors before blending
https://bugs.webkit.org/show_bug.cgi?id=98962

Reviewed by Dean Jackson.

Source/WebCore:

The result of css_ColorMatrix multiplication is now clamped in [0.0, 1.0]
before the blending step.

Relevant spec section is:
http://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#shader-processing-model

Tests: css3/filters/custom/custom-filter-color-clamping-negative.html

css3/filters/custom/custom-filter-color-clamping.html

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::rewriteMixFragmentShader): Added clamping
code.

LayoutTests:

Test to check the correct clamping of color values.

  • css3/filters/custom/custom-filter-color-clamping-expected.html: Added.
  • css3/filters/custom/custom-filter-color-clamping-negative-expected.html: Added.
  • css3/filters/custom/custom-filter-color-clamping-negative.html: Added.
  • css3/filters/custom/custom-filter-color-clamping.html: Added.
  • css3/filters/resources/custom-filter-color-clamping-negative.fs: Added.
  • css3/filters/resources/custom-filter-color-clamping.fs: Added.
10:19 AM FeatureFlags edited by rafaelw@chromium.org
(diff)
10:18 AM FeatureFlags edited by rafaelw@chromium.org
(diff)
10:14 AM Changeset in webkit [136253] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Crash due to intruding float not removed after writing mode changed.
https://bugs.webkit.org/show_bug.cgi?id=100149

Reviewed by Levi Weintraub.

Source/WebCore:

When RenderView writing mode changes, make sure to mark all descendants
with floats for layout.

Test: fast/block/float/intruding-float-not-removed-writing-mode.xhtml

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

LayoutTests:

  • fast/block/float/intruding-float-not-removed-writing-mode-expected.txt: Added.
  • fast/block/float/intruding-float-not-removed-writing-mode.xhtml: Added.
9:57 AM Changeset in webkit [136252] by pierre.rossi@gmail.com
  • 4 edits in trunk/Source/WebKit/qt

[Qt] Introduce setTextSizeMultiplier in the page adapter as well.

Rubber-stamped by Simon Hausmann.

As it turns out it the bots didn't like the previous attempt.

  • WebCoreSupport/QWebFrameAdapter.cpp:

(QWebFrameAdapter::setTextSizeMultiplier):

  • WebCoreSupport/QWebFrameAdapter.h:
  • WidgetApi/qwebframe.cpp:

(QWebFrame::setTextSizeMultiplier):

9:57 AM Changeset in webkit [136251] by pierre.rossi@gmail.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Unreviewed build fix.

In the same vein as r136245. Include PlatformExportMacros proper.

  • WebCoreSupport/QtPrintContext.h:
9:49 AM Changeset in webkit [136250] by fmalita@chromium.org
  • 4 edits
    2 adds in trunk

SVG pattern data deleted while in use
https://bugs.webkit.org/show_bug.cgi?id=103415

Reviewed by Dirk Schulze.

Source/WebCore:

Various calls in RenderSVGResourcePattern::applyResource() can trigger invalidations,
which may end up deleting our current pattern data (via removeAllClientsFromCache).
To avoid this, we should add the pattern data to the cache only after it is fully built.
For clarity, the patch also refactors the pattern setup code into a separate method.

Test: svg/custom/large-image-pattern-crash.html

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::buildPattern):
(WebCore::RenderSVGResourcePattern::applyResource):

  • rendering/svg/RenderSVGResourcePattern.h:

(RenderSVGResourcePattern):

LayoutTests:

  • svg/custom/large-image-pattern-crash-expected.txt: Added.
  • svg/custom/large-image-pattern-crash.html: Added.
9:20 AM Changeset in webkit [136249] by apavlov@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: It's Sass, not SASS
https://bugs.webkit.org/show_bug.cgi?id=103626

Reviewed by Yury Semikhatsky.

Change "SASS" to "Sass" in UI strings.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SettingsScreen.js:
9:17 AM Changeset in webkit [136248] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Fixing TestExpectations

Unreviewed fix to pass lint

  • platform/chromium/TestExpectations:
9:06 AM Changeset in webkit [136247] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

Unreviewed trivial Qt build fix:

Always link against WebProcess against QT += webkit and use webkitwidgets only if available.

  • WebProcess.pro:
8:59 AM Changeset in webkit [136246] by allan.jensen@digia.com
  • 2 edits in trunk/Source/JavaScriptCore

Crash in conversion of empty OpaqueJSString to Identifier
https://bugs.webkit.org/show_bug.cgi?id=101867

Reviewed by Michael Saboff.

The constructor call used for both null and empty OpaqueJSStrings results
in an assertion voilation and crash. This patch instead uses the Identifier
constructors which are specifically for null and empty Identifier.

  • API/OpaqueJSString.cpp:

(OpaqueJSString::identifier):

8:24 AM Changeset in webkit [136245] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit/qt

Unreviewed prospective MIPS build fix:

Explicitly include PlatformExportMacros for the correct export macro to be find.
Not really MIPS specific but rather to a minimal build configuration with less implicit
includes.

  • WebCoreSupport/UndoStepQt.h:
8:20 AM Changeset in webkit [136244] by pierre.rossi@gmail.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Unreviewed build un-break

Revert r136243 and hope it served its purpose.

  • WidgetApi/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

8:10 AM Changeset in webkit [136243] by pierre.rossi@gmail.com
  • 4 edits in trunk

[Qt] Unreviewed build break

Rubber-stamped by Simon Hausmann.

Poor man's way to trigger a clean build on a bot.

.:

  • WebKit.pro:

Source/WebKit/qt:

  • WidgetApi/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate):

7:48 AM Changeset in webkit [136242] by Simon Hausmann
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Fix QML import installation with newer Qt

Reviewed by Tor Arne Vestbø.

The import path has been separated between QML1 and QML2. Use
QT_INSTALL_QML if it's available.

  • declarative/experimental/experimental.pri:
  • declarative/public.pri:
7:32 AM Changeset in webkit [136241] by jochen@chromium.org
  • 1 edit
    2 copies in branches/chromium/1312

Merge 135578 - REGRESSION (r128633): td changes size during re-layout of table although it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=102802

Patch by Julian Pastarmov <pastarmovj@chromium.org> on 2012-11-23
Reviewed by Ojan Vafai.

Source/WebCore:

The bug was caused by incorrectly rewriting a nested condition which caused the else
clause to trigger in wrong cases.

Test: fast/table/nested-tables-with-div-offset.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePercentageLogicalHeight):
Reverted wrong combination of nested if statements.

LayoutTests:

This test checks that table layout of some nested tables in quirks mode is computed correctly.

  • fast/table/nested-tables-with-div-offset-expected.txt: Added.
  • fast/table/nested-tables-with-div-offset.html: Added.

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11414259

7:25 AM Changeset in webkit [136240] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit/qt

Prospective build fix for --minimal build.

  • WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::triggerAction):
(QWebPageAdapter::contextMenuItemTagForAction):

7:22 AM Changeset in webkit [136239] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip failing test editing/selection/caret-alignment-for-vertical-text.html
https://bugs.webkit.org/show_bug.cgi?id=103741

Unreviewed, EFL gardening.

Skip failing test editing/selection/caret-alignment-for-vertical-text.html
until bug 103740 is fixed.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-30

  • platform/efl/TestExpectations:
7:22 AM Changeset in webkit [136238] by Simon Hausmann
  • 2 edits in trunk

[Qt] Unreviewed doc fix

Add additional search paths for API folders.

  • Source/qtwebkit.qdocconf:
7:17 AM Changeset in webkit [136237] by pierre.rossi@gmail.com
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Fix zoomIn/zoomOut related regression.

Reviewed by Simon Hausmann.

Following r136235, fix a case of refactoring gone wrong.
Implementing setTextSizeMultiplier in terms of
setZoomFactor, and not the other way around.

  • WebCoreSupport/QWebFrameAdapter.cpp:

(QWebFrameAdapter::setZoomFactor):

  • WidgetApi/qwebframe.cpp:

(QWebFrame::setTextSizeMultiplier):

7:09 AM Changeset in webkit [136236] by tommyw@google.com
  • 21 edits
    1 move in trunk

Source/WebCore: Speech Recognition API: Update SpeechRecognitionEvent/Result to match the specification
https://bugs.webkit.org/show_bug.cgi?id=103407

Reviewed by Adam Barth.

This patch does the following:
o Adds results, and removing result on SpeechRecognitionEvent
o Renaming SpeechRecognitionResult::final to isFinal
o Moving emma to SpeechRecognitionEvent from SpeechRecognitionResult

Existing tests updated to test the new API.

  • Modules/speech/SpeechRecognition.cpp:

(WebCore::SpeechRecognition::start):
(WebCore::SpeechRecognition::didReceiveResults):
(WebCore):

  • Modules/speech/SpeechRecognition.h:

(SpeechRecognition):

  • Modules/speech/SpeechRecognitionEvent.cpp:

(WebCore::SpeechRecognitionEvent::createResult):
(WebCore):
(WebCore::SpeechRecognitionEvent::SpeechRecognitionEvent):
(WebCore::SpeechRecognitionEvent::~SpeechRecognitionEvent):
(WebCore::emmaQualifiedName):
(WebCore::SpeechRecognitionEvent::emma):

  • Modules/speech/SpeechRecognitionEvent.h:

(WebCore):
(SpeechRecognitionEventInit):
(SpeechRecognitionEvent):
(WebCore::SpeechRecognitionEvent::resultIndex):
(WebCore::SpeechRecognitionEvent::results):

  • Modules/speech/SpeechRecognitionEvent.idl:
  • Modules/speech/SpeechRecognitionResult.cpp:
  • Modules/speech/SpeechRecognitionResult.h:

(WebCore::SpeechRecognitionResult::isFinal):
(SpeechRecognitionResult):

  • Modules/speech/SpeechRecognitionResult.idl:
  • WebCore.gypi:
  • bindings/v8/custom/V8SpeechRecognitionEventCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8SpeechRecognitionResultCustom.cpp.

(WebCore):
(WebCore::V8SpeechRecognitionEvent::opaqueRootForGC):

Source/WebKit/chromium: Speech Recognition API: Update SpeechRecognitionEvent to match the specification
https://bugs.webkit.org/show_bug.cgi?id=103407

Reviewed by Adam Barth.

Adding the new didReceiveResults method.

  • public/WebSpeechRecognizerClient.h:
  • src/SpeechRecognitionClientProxy.cpp:

(WebKit::SpeechRecognitionClientProxy::didReceiveResults):
(WebKit):

  • src/SpeechRecognitionClientProxy.h:

(SpeechRecognitionClientProxy):

Tools: Speech Recognition API: Update SpeechRecognitionEvent to match the specification
https://bugs.webkit.org/show_bug.cgi?id=103407

Reviewed by Adam Barth.

Changing the mock to use the new results delivery API.

  • DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:

LayoutTests: Speech Recognition API: Update SpeechRecognitionEvent to match the specification
https://bugs.webkit.org/show_bug.cgi?id=103407

Reviewed by Adam Barth.

Updating tests.

  • fast/speech/scripted/emma-expected.txt:
  • fast/speech/scripted/emma.html:
  • fast/speech/scripted/speechrecognition-basics-expected.txt:
  • fast/speech/scripted/speechrecognition-basics.html:
7:00 AM Changeset in webkit [136235] by Simon Hausmann
  • 51 edits
    1 copy
    38 moves
    7 adds
    5 deletes in trunk

2012-11-30 Simon Hausmann <simon.hausmann@digia.com>, Pierre Rossi <pierre.rossi@digia.com>

[Qt] Separate Qt WebKit into Qt WebKit and Qt WebKit Widgets
https://bugs.webkit.org/show_bug.cgi?id=99314

Reviewed by Tor Arne Vestbø.

This big change separates QtWebKit into QtWebKit and QtWebKitWidgets as
shared libraries.

It's a big refactoring that mostly involves moving WebCore dependent
code into QtWebKit and accessing it through exported QWebFrameAdapter
and QWebPageAdapter classes.

6:20 AM Changeset in webkit [136234] by joone.hur@intel.com
  • 4 edits in trunk/Source/WebKit2

[EFL]Drawing artifacts while resizing the view
https://bugs.webkit.org/show_bug.cgi?id=101288

Reviewed by Kenneth Rohde Christiansen.

An Evas GL surface is recreated when the window is resized, but the update of the surface is
asynchronously done, which gives Evas a chance of painting the empty surface on the screen.
As a result, the flickering problem happens while resizing the view.
So this patch allows to create an Evas GL surface synchronously with the update of the surface.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl): Set m_pendingSurfaceResize to false.
(EwkViewImpl::displayTimerFired): Create an Evas GL surface.

  • UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl::setNeedsSurfaceResize): Added.
(EwkViewImpl):

  • UIProcess/API/efl/ewk_view.cpp:

(_ewk_view_smart_calculate): Set m_pendingSurfaceResize to true.

6:16 AM Changeset in webkit [136233] by vestbo@webkit.org
  • 2 edits in trunk

[Qt] Build as a regular Qt module when production_build is enabled

Instead of always setting CONFIG+=force_independent. This means the
libs, headers, and documentation will end up in qtbase for developer
builds of Qt, instead of always in the QtWebKit build directory.

Reviewed by Simon Hausmann.

  • Source/api.pri:
6:16 AM Changeset in webkit [136232] by vestbo@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Qt] Place the LLIntOffsetsExtractor binaries in debug/release subdirs on Mac

Otherwise we'll end up using the same LLIntAssembly.h for both build
configs of JavaScriptCore -- one of them which will be for the wrong
config.

Reviewed by Simon Hausmann.

5:58 AM WebKitEFLLayoutTest edited by ryuan.choi@samsung.com
(diff)
5:56 AM Changeset in webkit [136231] by commit-queue@webkit.org
  • 5 edits in trunk

[WK2] TiledBackingStore: Frame view re-layouts with wrong Fixed Visible Content Rect.
https://bugs.webkit.org/show_bug.cgi?id=103428

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-30
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Set now appropriate fixed visible content rect before layout when viewport
attributes change.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::syncVisibleContents):
(WebKit::PageViewportController::didChangeViewportAttributes):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendViewportAttributesChanged):

LayoutTests:

Unskipped corresponding test cases for EFL WK2.

  • platform/efl-wk2/TestExpectations:
5:44 AM Changeset in webkit [136230] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

[EFL] Gardening after r136031 and r136142
https://bugs.webkit.org/show_bug.cgi?id=103734

Source/WebKit2:

Unreviewed, API test EWK2UnitTestBase.ewk_view_setting_encoding_custom
is asserting after r136031. So, disabling the test until bug 103732 is
fixed.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-30

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

LayoutTests:

Unreviewed, EFL gardening.

Add baselines for new test fast/ruby/position-after.html. Also
unskip passing tests.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-30

  • platform/efl/TestExpectations:
  • platform/efl/fast/ruby/position-after-expected.png: Added.
  • platform/efl/fast/ruby/position-after-expected.txt: Added.
5:03 AM Changeset in webkit [136229] by zeno.albisser@digia.com
  • 4 edits in trunk/Source

[Qt] Enable WebGL by default.
https://bugs.webkit.org/show_bug.cgi?id=103731

Reviewed by Simon Hausmann.

Source/WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettings::QWebSettings):

Source/WebKit2:

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):

4:59 AM Changeset in webkit [136228] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r136227.
http://trac.webkit.org/changeset/136227

Broke the Qt bots due to version mismatch

  • platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:

(FullScreenVideoWindow::FullScreenVideoWindow):
(PlatformVideoWindow::PlatformVideoWindow):

4:50 AM Changeset in webkit [136227] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Qt] Fixed use of to-be-removed compatibility functions in QWindow.

Patch by Samuel Rødal <samuel.rodal@digia.com> on 2012-11-30
Reviewed by Simon Hausmann.

  • platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:

(FullScreenVideoWindow::FullScreenVideoWindow):
(PlatformVideoWindow::PlatformVideoWindow):

4:47 AM Changeset in webkit [136226] by Csaba Osztrogonác
  • 1 edit
    1 add in trunk/Tools

[Qt] Unreviewed trivial fix.

Add empty.cpp back, it was removed accidentally by r129092.

  • qmake/config.tests/gccdepends/empty.cpp: Added.
4:32 AM Changeset in webkit [136225] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Caret is painted horizontally in vertical writing mode when there are no visible text
https://bugs.webkit.org/show_bug.cgi?id=102359

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-11-30
Reviewed by Ryosuke Niwa.

Source/WebCore:

In the vertical writing mode the caret rect on an empty editable box or
an empty line is rendered as per the horizontal writing mode.

This changes though when any text is added; the caret is then displayed
in accordance with the vertical writing mode.

Test: editing/selection/caret-alignment-for-vertical-text.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::localCaretRect):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):
The caret rect should be transposed for the vertical writing mode. Its
width and height values need to be interchanged for it to be oriented
as per the vertical text.

LayoutTests:

  • editing/selection/caret-alignment-for-vertical-text-expected.txt: Added.
  • editing/selection/caret-alignment-for-vertical-text.html: Added.

Test to verify that the orientation of the caret on an empty vertical text
line or container is same as that for a non-empty container.

4:01 AM Changeset in webkit [136224] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Add support for prepare_docs and generate_docs

Follow-up to changes in Qt in how documentation is built.

Reviewed by Simon Hausmann.

  • qmake/mkspecs/features/default_post.prf:
3:26 AM Changeset in webkit [136223] by kkristof@inf.u-szeged.hu
  • 1 edit
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

Add expected results for a new test.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-11-30

  • platform/qt/fast/ruby/position-after-expected.png: Added.
  • platform/qt/fast/ruby/position-after-expected.txt: Added.
3:21 AM Changeset in webkit [136222] by keishi@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Page popup doesn't change mouse cursor
https://bugs.webkit.org/show_bug.cgi?id=97454

Reviewed by Kent Tamura.

The mouse cursor should change based on the page popup content and not the main window content.
On Mac the mousemove event propagates to both the page popup and main window causing the cursor to flicker.
The change to ChromeClientImpl stops that.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::setCursor): On Mac, don't update the mouse cursor if a popup is open.

  • src/WebPagePopupImpl.cpp: Implement setCursor so the mouse cursor gets set based on the page popup content.
2:56 AM Changeset in webkit [136221] by zandobersek@gmail.com
  • 4 edits
    2 adds
    2 deletes in trunk/Tools

Finally remove webkitpy.common.system.deprecated_logging
https://bugs.webkit.org/show_bug.cgi?id=103624

Reviewed by Adam Barth.

Remove the deprecated logging module and its unit tests now that such logging is not
used anymore in webkitpy.

The tee and OutputTee classes are moved into a new module, webkitpy.common.system.outputtee.
The tee class is renamed to Tee to conform with the usual guidelines.

Only unit test for the Tee class is currently provided as the OutputTee is not currently
using the webkitpy Filesystem abstraction that would make its functionality testable.

  • Scripts/webkitpy/common/system/executive.py: tee (now Tee) is now in a new module.

(Executive.run_and_throw_if_fail):

  • Scripts/webkitpy/common/system/outputtee.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging.py.

(Tee):
(Tee.init):
(Tee.write):
(OutputTee):
(OutputTee.init):
(OutputTee.add_log):
(OutputTee.remove_log):
(OutputTee._open_log_file):
(OutputTee._tee_outputs_to_files):

  • Scripts/webkitpy/common/system/outputtee_unittest.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging_unittest.py.

(SimpleTeeTest):
(SimpleTeeTest.test_simple_tee):

  • Scripts/webkitpy/tool/bot/queueengine.py: OutputTee is now in a new module.
  • Scripts/webkitpy/webkitpy.pyproj: Remove the deprecated_logging module and related unit test file.
2:52 AM Changeset in webkit [136220] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Timeline] JS error when clicking in Memory Statistics view
https://bugs.webkit.org/show_bug.cgi?id=103486

Patch by Sankeerth V S <sankeerth.vs@samsung.com> on 2012-11-30
Reviewed by Alexander Pavlov.

The counter value can be null/undefined. Hence a check is needed
before we access the "time" property on this counter object.

No new tests required as UI related change.

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype._onClick):

2:32 AM Changeset in webkit [136219] by tkent@chromium.org
  • 6 edits in trunk/LayoutTests

[Chromium] Layout Test fast/forms/*-multiple-fields/*-multiple-fields-preserve-value-after-history-back.html is failing
https://bugs.webkit.org/show_bug.cgi?id=96720

Reviewed by Kentaro Hara.

We should start tests after js-test-post.js loading to avoid missing
testRunner.waitUntilDone calls.

  • fast/forms/date-multiple-fields/date-multiple-fields-preserve-value-after-history-back.html:

Make the outer switch a function to be called window.onload, and stop to
remove the iframe because the script in the iframe calls notifyDone.

  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-preserve-value-after-history-back.html:

Ditto.

  • fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html:

Ditto.

  • fast/forms/week-multiple-fields/week-multiple-fields-preserve-value-after-history-back.html:

Ditto.

  • platform/chromium/TestExpectations:

Move the line for
week-multiple-fields-preserve-value-after-history-back.html near to
others. We don't remove these expectations yet just in case.

2:19 AM Changeset in webkit [136218] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[sh4] Fix compilation warnings in JavaScriptCore JIT for sh4 arch
https://bugs.webkit.org/show_bug.cgi?id=103378

Patch by Julien BRIANCEAU <jbrianceau@nds.com> on 2012-11-30
Reviewed by Filip Pizlo.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branchTest32):
(JSC::MacroAssemblerSH4::branchAdd32):
(JSC::MacroAssemblerSH4::branchMul32):
(JSC::MacroAssemblerSH4::branchSub32):
(JSC::MacroAssemblerSH4::branchOr32):

1:45 AM Changeset in webkit [136217] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[EFL][WK2] Add support for PlatformWebView::simulateRightClick() in TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=103634

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-30
Reviewed by Gyuyoung Kim.

Add support for PlatformWebView::simulateRightClick() and enable
WebKit2 API test HitTestResultNodeHandle.

  • TestWebKitAPI/PlatformEfl.cmake:
  • TestWebKitAPI/efl/PlatformWebView.cpp:

(TestWebKitAPI::PlatformWebView::simulateRightClick):
(TestWebKitAPI):

1:13 AM Changeset in webkit [136216] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, fast/text/line-initial-and-final-swashes.html missing expectations on XP after r136153.

  • platform/chromium/TestExpectations:
1:02 AM Changeset in webkit [136215] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix typos in DateTimeNumericFieldElement.cpp and DateTimeSymbolicFieldElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=103717

Reviewed by Hajime Morita.

  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::customStyleForRenderer):
maximum, not maxium.

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::customStyleForRenderer): Ditto.

1:01 AM Changeset in webkit [136214] by tasak@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, WebKit gardening.

  • platform/chromium/TestExpectations:
12:58 AM Changeset in webkit [136213] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

12:54 AM Changeset in webkit [136212] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] libwebcore_efl.a fail to link when enable webgl
https://bugs.webkit.org/show_bug.cgi?id=103610

Patch by Halton Huo <halton.huo@intel.com> on 2012-11-30
Reviewed by Gyuyoung Kim.

libwebcore_efl.a should link to X11, Xcomposite and Xrender libraries when ENABLE_WEBGL is ON

No new tests, no behavior change for layout tests.

  • PlatformEfl.cmake: Append ${X11_X11_LIB}, ${X11_Xcomposite_LIB} and ${X11_Xrender_LIB} to WebCore_LIBRARIES
12:52 AM Changeset in webkit [136211] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix the PDFPlugin build after http://trac.webkit.org/changeset/136205.

  • WebCore.xcodeproj/project.pbxproj:
12:48 AM Changeset in webkit [136210] by commit-queue@webkit.org
  • 32 edits in trunk

[CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled
https://bugs.webkit.org/show_bug.cgi?id=101192

Patch by Mihai Maerean <Mihai Maerean> on 2012-11-30
Reviewed by Hajime Morita.

Removed the CSS Regions flag in Settings and switched to using the new flag I have added in RuntimeEnabledFeatures.

Tests: No new tests because there is no functional change.

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setCSSRegionsEnabled):
(WebCore::RuntimeEnabledFeatures::cssRegionsEnabled):

  • dom/Document.cpp:

(WebCore::Document::cssRegionsEnabled):

  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(Settings):

Source/WebKit/chromium:

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • public/WebSettings.h: moved setExperimentalCSSRegionsEnabled to the bottom of the interface and made it a

no-op. After this patch lands and Chromium's webkit_rev is increased, we'll remove any callers in Chromium. Once
the Chromium callers are gone and WebKit's chromium_rev is increased, we'll remove the deprecated API.

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableCSSRegions):
(WebKit):
(WebKit::WebRuntimeFeatures::isCSSRegionsEnabled):

  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:

(WebSettingsImpl):

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setCSSRegionsEnabled):

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setCSSRegionsEnabled):

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/qt:

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

Source/WebKit/win:

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit2:

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
(WebKit::InjectedBundle::setCSSRegionsEnabled):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::applyTo):

12:08 AM Changeset in webkit [136209] by keishi@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Layout Test fast/forms/month-multiple-fields/month-multiple-fields-preserve-value-after-history-back.html is failing
https://bugs.webkit.org/show_bug.cgi?id=103713

Unreviewed.

Rebaselining month-multiple-fields-preserve-value-after-history-back.html for Windows.

  • platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-preserve-value-after-history-back-expected.txt: Added.
  • platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-preserve-value-after-history-back-expected.txt: Added.

Nov 29, 2012:

11:58 PM Changeset in webkit [136208] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

PDFPlugin: Only plain text can be copied out of PDFs
https://bugs.webkit.org/show_bug.cgi?id=103591
<rdar://problem/12555161>

Reviewed by Alexey Proskuryakov.

Don't write zero-length data to the pasteboard, just skip the item.

As mentioned in the comment, we don't expect this to come up, and would like to know if it does,
so we assert that it doesn't happen in debug builds.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::writeItemsToPasteboard):

10:41 PM Changeset in webkit [136207] by Martin Robinson
  • 5 edits in trunk/Source

[GTK] [WebKit2] WebKitWebViewBase creates a GL context for the redirected XComposite window crashing WebKit in Xvfb
https://bugs.webkit.org/show_bug.cgi?id=103476

Reviewed by Alejandro G. Castro.

Source/WebCore:

Allow creation of RedirectedXCompositeWindow in a mode which does not have a backing
GLContext. For WebKit2 the GLContext is always in the WebProcess. Creating the GLContext
in both processes can cause crashes when library is run in Xvfb.

No new tests. This fixes a crash running tests on some systems.

  • platform/gtk/RedirectedXCompositeWindow.cpp:

(WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow):
(WebCore::RedirectedXCompositeWindow::resize): Do not create the GLContext when
in the new no-GLContext mode.
(WebCore::RedirectedXCompositeWindow::context): ASSERT that we are not in
no-GLContext mode.

Source/WebKit2:

Create the RedirectedXCompositeWindow with an argument specifying that it
should never have a GLContext backing it.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(_WebKitWebViewBasePrivate::_WebKitWebViewBasePrivate):

10:15 PM Changeset in webkit [136206] by Lucas Forschler
  • 2 edits in tags/Safari-537.20/Source/WebKit2

Patch for <rdar://problem/12781591>.

9:46 PM Changeset in webkit [136205] by keishi@webkit.org
  • 14 edits
    2 adds in trunk

Better type ahead for DateTimeSymbolicFieldElement
https://bugs.webkit.org/show_bug.cgi?id=103031

Reviewed by Kent Tamura.

Source/WebCore:

This cuts out the type ahead code that will be used by HTMLSelectElement
and DateTimeSymbolicFieldElement into a TypeAhead class. This will
improve DateTimeSymbolicFieldElement type ahead which was first
character match only, by adding cycling, prefix match and index number
match.

Added tests to month-multiple-fields-keyboard-events.html.

  • GNUmakefile.list.am: Added TypeAhead.{h,cpp}
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • CMakeLists.txt: Ditto.
  • html/HTMLSelectElement.cpp:

(WebCore):
(WebCore::HTMLSelectElement::HTMLSelectElement):
(WebCore::HTMLSelectElement::indexOfSelectedOption): Returns index of current selection.
(WebCore::HTMLSelectElement::optionCount): Returns total number of options.
(WebCore::HTMLSelectElement::optionAtIndex): Returns option at index.
(WebCore::HTMLSelectElement::typeAheadFind): Use TypeAhead.

  • html/HTMLSelectElement.h:

(HTMLSelectElement):

  • html/TypeAhead.cpp: Added.

(WebCore):
(WebCore::TypeAhead::TypeAhead):
(WebCore::stripLeadingWhiteSpace): Moved from HTMLSelectElement.cpp.
(WebCore::TypeAhead::handleEvent): Returns index for match.

  • html/TypeAhead.h: Added.

(WebCore):
(TypeAheadDataSource): Provide the data about the options that TypeAhead should match against.
(TypeAhead):

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement):
(WebCore::DateTimeSymbolicFieldElement::handleKeyboardEvent):
(WebCore::DateTimeSymbolicFieldElement::indexOfSelectedOption):
(WebCore):
(WebCore::DateTimeSymbolicFieldElement::optionCount):
(WebCore::DateTimeSymbolicFieldElement::optionAtIndex):

  • html/shadow/DateTimeSymbolicFieldElement.h:

(DateTimeSymbolicFieldElement):

LayoutTests:

  • fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html: Added tests for typeahead.
9:40 PM Changeset in webkit [136204] by rafaelw@chromium.org
  • 16 edits in trunk

[HTMLTemplateElement] Add feature flag
https://bugs.webkit.org/show_bug.cgi?id=103694

Reviewed by Adam Barth.

This flag will guard the implementation of the HTMLTemplateElement.
http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.features.am:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
9:30 PM Changeset in webkit [136203] by Lucas Forschler
  • 1 copy in tags/Safari-537.20

New Tag.

9:05 PM Changeset in webkit [136202] by keishi@webkit.org
  • 1 edit
    18 adds in trunk/LayoutTests

Add month-multiple-fields tests
https://bugs.webkit.org/show_bug.cgi?id=102046

Reviewed by Kent Tamura.

Adding tests for multiple field <input type=month>.

  • fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes-expected.txt: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes.html: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-ax-value-changed-notification-expected.txt: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-ax-value-changed-notification.html: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-blur-and-focus-events-expected.txt: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-blur-and-focus-events.html: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-change-layout-by-value-expected.txt: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-change-layout-by-value.html: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-mouse-events-expected.txt: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-mouse-events.html: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-preserve-value-after-history-back-expected.txt: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-preserve-value-after-history-back.html: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-reset-value-after-reloads-expected.txt: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-reset-value-after-reloads.html: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-spinbutton-change-and-input-events-expected.txt: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-spinbutton-change-and-input-events.html: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-wheel-event-expected.txt: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-wheel-event.html: Added.
8:43 PM Changeset in webkit [136201] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Ignore errors when removing directories on win32 during autoinstall
https://bugs.webkit.org/show_bug.cgi?id=103699

Unreviewed, build fix.

I think this will work on win32; if not, I'll have to actually
reproduce this :). The problem is that the logilab files
appear to contain a write-protected file, and deleting those
is problematic on windows.

  • Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller._install):
(AutoInstaller.install):

8:41 PM Changeset in webkit [136200] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix typo in commit 136189
https://bugs.webkit.org/show_bug.cgi?id=103706

Patch by Viatcheslav Ostapenko <v.ostapenko@samsung.com> on 2012-11-29
Reviewed by Kentaro Hara.

Because of typo in commit 136189 blue color value was set twice for every pixel.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::setPixel):

7:42 PM Changeset in webkit [136199] by fpizlo@apple.com
  • 32 edits
    7 adds in trunk/Source

It should be easy to find code blocks in debug dumps
https://bugs.webkit.org/show_bug.cgi?id=103623

Source/JavaScriptCore:

Reviewed by Goeffrey Garen.

This gives CodeBlock a relatively strong, but also relatively compact, hash. We compute
it lazily so that it only impacts run-time when debug support is enabled. We stringify
it smartly so that it's short and easy to type. We base it on the source code so that
the optimization level is irrelevant. And, we use SHA1 since it's already in our code
base. Now, when a piece of code wants to print some debugging to say that it's operating
on some code block, it can use this CodeBlockHash instead of memory addresses.

This also takes CodeBlock debugging into the new world of print() and dataLog(). In
particular, CodeBlock::dump() corresponds to the thing you want printed if you do:

dataLog("I heart ", *myCodeBlock);

Probably, you want to just print some identifying information at this point rather than
the full bytecode dump. So, the existing CodeBlock::dump() has been renamed to
CodeBlock::dumpBytecode(), and CodeBlock::dump() now prints the CodeBlockHash plus just
a few little tidbits.

Here's an example of CodeBlock::dump() output:

EkILzr:[0x103883a00, BaselineFunctionCall]

EkILzr is the CodeBlockHash. 0x103883a00 is the CodeBlock's address in memory. The other
part is self-explanatory.

Finally, this new notion of CodeBlockHash is available for other purposes like bisecting
breakage. As such CodeBlockHash has all of the comparison operator overloads. When
bisecting in DFGDriver.cpp, you can now say things like:

if (codeBlock->hash() < CodeBlockHash("CAAAAA"))

return false;


And yes, CAAAAA is near the median hash, and the largest one is smaller than E99999. Such
is life when you use base 62 to encode a 32-bit number.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CallLinkInfo.h:

(CallLinkInfo):
(JSC::CallLinkInfo::specializationKind):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::hash):
(JSC):
(JSC::CodeBlock::dumpAssumingJITType):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::resetStubInternal):
(JSC::CodeBlock::reoptimize):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::tallyFrequentExitSites):
(JSC::CodeBlock::dumpValueProfiles):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::specializationKind):
(CodeBlock):
(JSC::CodeBlock::getJITType):

  • bytecode/CodeBlockHash.cpp: Added.

(JSC):
(JSC::CodeBlockHash::CodeBlockHash):
(JSC::CodeBlockHash::dump):

  • bytecode/CodeBlockHash.h: Added.

(JSC):
(CodeBlockHash):
(JSC::CodeBlockHash::CodeBlockHash):
(JSC::CodeBlockHash::hash):
(JSC::CodeBlockHash::operator==):
(JSC::CodeBlockHash::operator!=):
(JSC::CodeBlockHash::operator<):
(JSC::CodeBlockHash::operator>):
(JSC::CodeBlockHash::operator<=):
(JSC::CodeBlockHash::operator>=):

  • bytecode/CodeBlockWithJITType.h: Added.

(JSC):
(CodeBlockWithJITType):
(JSC::CodeBlockWithJITType::CodeBlockWithJITType):
(JSC::CodeBlockWithJITType::dump):

  • bytecode/CodeOrigin.cpp: Added.

(JSC):
(JSC::CodeOrigin::inlineDepthForCallFrame):
(JSC::CodeOrigin::inlineDepth):
(JSC::CodeOrigin::inlineStack):
(JSC::InlineCallFrame::hash):

  • bytecode/CodeOrigin.h:

(InlineCallFrame):
(JSC::InlineCallFrame::specializationKind):
(JSC):

  • bytecode/CodeType.cpp: Added.

(WTF):
(WTF::printInternal):

  • bytecode/CodeType.h:

(WTF):

  • bytecode/ExecutionCounter.cpp:

(JSC::ExecutionCounter::dump):

  • bytecode/ExecutionCounter.h:

(ExecutionCounter):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseCodeBlock):

  • dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::dump):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dumpCodeOrigin):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOperations.cpp:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::dfgLinkClosureCall):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::dumpCallFrame):

  • jit/JITCode.cpp: Added.

(WTF):
(WTF::printInternal):

  • jit/JITCode.h:

(JSC::JITCode::jitType):
(WTF):

  • jit/JITDisassembler.cpp:

(JSC::JITDisassembler::dump):
(JSC::JITDisassembler::dumpForInstructions):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::privateCompileGetByVal):
(JSC::JIT::privateCompilePutByVal):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/CodeSpecializationKind.cpp: Added.

(WTF):
(WTF::printInternal):

  • runtime/CodeSpecializationKind.h:

(JSC::specializationFromIsCall):
(JSC):
(JSC::specializationFromIsConstruct):
(WTF):

  • runtime/Executable.cpp:

(JSC::ExecutableBase::hashFor):
(JSC):
(JSC::NativeExecutable::hashFor):
(JSC::ScriptExecutable::hashFor):

  • runtime/Executable.h:

(ExecutableBase):
(NativeExecutable):
(ScriptExecutable):
(JSC::ScriptExecutable::source):

Source/WTF:

Reviewed by Geoffrey Garen.

Changed RawPointer to accept both const void* and void*, and use the former internally.

Cleaned up SHA1 so that the functionality already used internally for self-testing is
available via the API. This includes addBytes(CString) and computing hex digests.

  • wtf/RawPointer.h:

(WTF::RawPointer::RawPointer):
(RawPointer):
(WTF::RawPointer::value):

  • wtf/SHA1.cpp:

(WTF::expectSHA1):
(WTF::SHA1::hexDigest):
(WTF::SHA1::computeHexDigest):

  • wtf/SHA1.h:

(WTF::SHA1::addBytes):

7:26 PM Changeset in webkit [136198] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Node::isDescendantOf contains logic that duplicates isDocumentNode
https://bugs.webkit.org/show_bug.cgi?id=103698

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-29
Reviewed by Hajime Morita.

Instead of checking for documents with node->document() == node just
use node->isDocumentNode().

  • dom/Node.cpp:

(WebCore::Node::isDescendantOf):

6:32 PM Changeset in webkit [136197] by ap@apple.com
  • 33 edits in trunk/Source

[WK2] Forward cookie jar calls to NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=103457

Reviewed by Darin Adler.

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:

PlatformCookieJar.h functions are now used in WebKit2.

  • loader/CookieJar.cpp:

(WebCore::cookies):
(WebCore::setCookies):
(WebCore::cookiesEnabled):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):
Use a strategy instead of going to PlatformCookieJar directly.

  • platform/Cookie.h: (Cookie): Added a default constructor, so that Cookie could be

sent over IPC.

  • platform/CookiesStrategy.h: Added functions for cookie jar.

Source/WebKit/efl:

  • WebCoreSupport/PlatformStrategiesEfl.cpp:

(PlatformStrategiesEfl::cookiesForDOM):
(PlatformStrategiesEfl::setCookiesFromDOM):
(PlatformStrategiesEfl::cookiesEnabled):
(PlatformStrategiesEfl::cookieRequestHeaderFieldValue):
(PlatformStrategiesEfl::getRawCookies):
(PlatformStrategiesEfl::deleteCookie):
(PlatformStrategiesEfl::getHostnamesWithCookies):
(PlatformStrategiesEfl::deleteCookiesForHostname):
(PlatformStrategiesEfl::deleteAllCookies):

Source/WebKit/gtk:

  • WebCoreSupport/PlatformStrategiesGtk.cpp:

(PlatformStrategiesGtk::cookiesForDOM):
(PlatformStrategiesGtk::setCookiesFromDOM):
(PlatformStrategiesGtk::cookiesEnabled):
(PlatformStrategiesGtk::cookieRequestHeaderFieldValue):
(PlatformStrategiesGtk::getRawCookies):
(PlatformStrategiesGtk::deleteCookie):
(PlatformStrategiesGtk::getHostnamesWithCookies):
(PlatformStrategiesGtk::deleteCookiesForHostname):
(PlatformStrategiesGtk::deleteAllCookies):

Source/WebKit/mac:

  • WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):

  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::cookiesForDOM):
(WebPlatformStrategies::setCookiesFromDOM):
(WebPlatformStrategies::cookiesEnabled):
(WebPlatformStrategies::cookieRequestHeaderFieldValue):
(WebPlatformStrategies::getRawCookies):
(WebPlatformStrategies::deleteCookie):
(WebPlatformStrategies::getHostnamesWithCookies):
(WebPlatformStrategies::deleteCookiesForHostname):
(WebPlatformStrategies::deleteAllCookies):
(WebPlatformStrategies::getPluginInfo):
(WebPlatformStrategies::bufferForType):
WebKit1 strategy just uses PlatformCookieJar.

Source/WebKit/qt:

  • WebCoreSupport/PlatformStrategiesQt.cpp:

(PlatformStrategiesQt::cookiesForDOM):
(PlatformStrategiesQt::setCookiesFromDOM):
(PlatformStrategiesQt::cookiesEnabled):
(PlatformStrategiesQt::cookieRequestHeaderFieldValue):
(PlatformStrategiesQt::getRawCookies):
(PlatformStrategiesQt::deleteCookie):
(PlatformStrategiesQt::getHostnamesWithCookies):
(PlatformStrategiesQt::deleteCookiesForHostname):
(PlatformStrategiesQt::deleteAllCookies):

Source/WebKit/win:

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::cookiesForDOM):
(WebPlatformStrategies::setCookiesFromDOM):
(WebPlatformStrategies::cookiesEnabled):
(WebPlatformStrategies::cookieRequestHeaderFieldValue):
(WebPlatformStrategies::getRawCookies):
(WebPlatformStrategies::deleteCookie):
(WebPlatformStrategies::getHostnamesWithCookies):
(WebPlatformStrategies::deleteCookiesForHostname):
(WebPlatformStrategies::deleteAllCookies):

Source/WebKit/wince:

  • WebCoreSupport/PlatformStrategiesWinCE.cpp:

(PlatformStrategiesWinCE::cookiesForDOM):
(PlatformStrategiesWinCE::setCookiesFromDOM):
(PlatformStrategiesWinCE::cookiesEnabled):
(PlatformStrategiesWinCE::cookieRequestHeaderFieldValue):
(PlatformStrategiesWinCE::getRawCookies):
(PlatformStrategiesWinCE::deleteCookie):
(PlatformStrategiesWinCE::getHostnamesWithCookies):
(PlatformStrategiesWinCE::deleteCookiesForHostname):
(PlatformStrategiesWinCE::deleteAllCookies):

Source/WebKit2:

  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:

Added messages to maniputate CookieJar in network process.

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp: Removed unnecessary WebCore:: prefixes,

this file has a using direcive.
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
(WebKit::NetworkConnectionToWebProcess::getRawCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookie):
(WebKit::NetworkConnectionToWebProcess::getHostnamesWithCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookiesForHostname):
(WebKit::NetworkConnectionToWebProcess::deleteAllCookies):
Added implementations that use PlatformCookieJar in the network process.

  • Scripts/webkit2/messages.py: (struct_or_class):
  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):
Added support for Cookie.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::cookiesForDOM):
(WebKit::WebPlatformStrategies::setCookiesFromDOM):
(WebKit::WebPlatformStrategies::cookiesEnabled):
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
(WebKit::WebPlatformStrategies::getRawCookies):
(WebKit::WebPlatformStrategies::deleteCookie):
(WebKit::WebPlatformStrategies::getHostnamesWithCookies):
(WebKit::WebPlatformStrategies::deleteCookiesForHostname):
(WebKit::WebPlatformStrategies::deleteAllCookies):
When using the network process, forward cookie calls to it.

6:28 PM Changeset in webkit [136196] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r136167.
http://trac.webkit.org/changeset/136167
https://bugs.webkit.org/show_bug.cgi?id=103701

Win debug build failure (Requested by zhenyao on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-29

  • platform/graphics/chromium/LazyDecodingPixelRef.cpp:

(WebCore::LazyDecodingPixelRef::LazyDecodingPixelRef):

  • platform/graphics/chromium/LazyDecodingPixelRef.h:

(LazyDecodingPixelRef):

6:23 PM Changeset in webkit [136195] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkitpy: autoinstaller is failing on windows
https://bugs.webkit.org/show_bug.cgi?id=103699

Unreviewed, build fix.

We're attempting to create directories with forward slashes in them;
this is a no-no on windows.

  • Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller._create_scratch_directory_inner):

6:22 PM Changeset in webkit [136194] by dgrogan@chromium.org
  • 12 edits in trunk/Source

IndexedDB: Propagate more leveldb errors to script
https://bugs.webkit.org/show_bug.cgi?id=103580

Reviewed by Tony Chang.

Source/WebCore:

LevelDBDatabase used a single return value to indicate both I/O problems
and a missing key. Now an out variable is used to indicate if the
requested key was found. The return value is used to report corruption
or disk error.

This is a small step toward propagating low level errors everywhere
possible. So far only one scenario will newly cause script to receive
an error: when leveldb has trouble looking for existing keys during an
objectstore->add.

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::getInt):
(WebCore::getVarInt):
(WebCore::getString):
(WebCore::IDBBackingStore::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::keyExistsInObjectStore):

  • Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::generateKey):
(WebCore::IDBObjectStoreBackendImpl::updateKeyGenerator):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(IDBObjectStoreBackendImpl):

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::safeGet):

  • platform/leveldb/LevelDBDatabase.h:

(LevelDBDatabase):

  • platform/leveldb/LevelDBTransaction.cpp:

(WebCore::LevelDBTransaction::safeGet):
(WebCore):
(WebCore::LevelDBTransaction::get):

  • platform/leveldb/LevelDBTransaction.h:

(LevelDBTransaction):

Source/WebKit/chromium:

  • tests/IDBFakeBackingStore.h: Update method signatures.
6:18 PM Changeset in webkit [136193] by commit-queue@webkit.org
  • 23 edits in trunk/Source/WebKit2

Instantiate snapshot plugins in a PluginProcess with muted audio
https://bugs.webkit.org/show_bug.cgi?id=101536

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-11-29
Reviewed by Anders Carlsson.

Plugins created for generation of a snapshot should be instantiated in a separate process with
muted audio so that any sound generated during the snapshot process is not audible to the user.

  • Configurations/WebKit2.xcconfig: Add CoreAudio to the list of linked frameworks.
  • PluginProcess/PluginProcess.h: Add PluginProcess::Type enum with values for regular and

snapshot process types. Provide DefaultHash and IsInteger template specializations for the enum
so that PluginProcessConnectionManager can store it in a HashMap.

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::muteAudio):
(WebKit::PluginProcess::platformInitialize): Mute audio if the process creation parameters indicate
that the plugin process type is snapshot process.

  • Shared/Plugins/PluginProcessCreationParameters.cpp:

(WebKit::PluginProcessCreationParameters::encode):
(WebKit::PluginProcessCreationParameters::decode):

  • Shared/Plugins/PluginProcessCreationParameters.h: Add processType process creation parameter.
  • UIProcess/Plugins/PluginProcessManager.cpp:

(WebKit::PluginProcessManager::getPluginProcessConnection): Add process type parameter.
(WebKit::PluginProcessManager::getSitesWithData): Forward message to regular plugin process only.
(WebKit::PluginProcessManager::clearSiteData): Forward message to regular plugin process only.
(WebKit::PluginProcessManager::pluginProcessWithPath): Add process type parameter.
(WebKit::PluginProcessManager::getOrCreatePluginProcess): Ditto.

  • UIProcess/Plugins/PluginProcessManager.h:
  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::create): Add process type parameter.
(WebKit::PluginProcessProxy::PluginProcessProxy): Ditto.
(WebKit::PluginProcessProxy::didClose): Include process type with the plugin process crashed message.
(WebKit::PluginProcessProxy::didFinishLaunching): Set process type process creation parameter.

  • UIProcess/Plugins/PluginProcessProxy.h:

(WebKit::PluginProcessProxy::processType):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPluginProcessConnection): Pass along process type parameter to
PluginProcessManager.

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

  • UIProcess/WebProcessProxy.messages.in: Add process type parameter to GetPluginProcessConnection message.
  • WebProcess/Plugins/PluginProcessConnection.cpp:

(WebKit::PluginProcessConnection::PluginProcessConnection): Add process type parameter.

  • WebProcess/Plugins/PluginProcessConnection.h:

(WebKit::PluginProcessConnection::create): Ditto.
(WebKit::PluginProcessConnection::processType): Ditto.

  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::getPluginProcessConnection): Add process type parameter.
(WebKit::PluginProcessConnectionManager::removePluginProcessConnection): Use process type in addition to
plugin path to find the connection to remove.
(WebKit::PluginProcessConnectionManager::pluginProcessCrashed): Add process type parameter.

  • WebProcess/Plugins/PluginProcessConnectionManager.h:
  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::create): Ditto.
(WebKit::PluginProxy::PluginProxy): Ditto.
(WebKit::PluginProxy::initialize): Add process type parameter in call to
PluginProcessConnectionManager::getPluginProcessConnection.

  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin): Determine process type based on display state of plugin element and
pass it to PluginProxy::create.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::pluginProcessCrashed): Pass along process type parameter to
PluginProcessConnectionManager.

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in: Add process type parameter to PluginProcessCrashed message.
6:11 PM Changeset in webkit [136192] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Fix python unit tests after r136158 (android port tests failing)
https://bugs.webkit.org/show_bug.cgi?id=103581

Unreviewed, build fix.

The unit tests apparently weren't ran for this patch; we failed
to update the mock executive calls out to adb to determine various
aspects of the environment, and were failing to create drivers.

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:

(MockRunCommand.mock_run_command_fn):

5:42 PM Changeset in webkit [136191] by commit-queue@webkit.org
  • 12 edits in trunk/Source

Unreviewed, rolling out r136171.
http://trac.webkit.org/changeset/136171
https://bugs.webkit.org/show_bug.cgi?id=103695

Likely caused ReOpenedWithID and ReOpenedWithURL to fail in
linux/chromeos (Requested by zhenyao on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-29

Source/WebCore:

  • inspector/InspectorClient.h:

(WebCore::InspectorClient::startMainThreadMonitoring):
(WebCore::InspectorClient::stopMainThreadMonitoring):

  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:

(InspectorController):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willProcessTaskImpl):
(WebCore::InspectorInstrumentation::didProcessTaskImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willProcessTask):
(WebCore):
(WebCore::InspectorInstrumentation::didProcessTask):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):

Source/WebKit/chromium:

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::startMainThreadMonitoring):
(WebKit):
(WebKit::InspectorClientImpl::stopMainThreadMonitoring):
(WebKit::InspectorClientImpl::willProcessTask):
(WebKit::InspectorClientImpl::didProcessTask):

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::attach):
(WebKit::WebDevToolsAgentImpl::detach):

  • src/WebDevToolsAgentImpl.h:

(WebDevToolsAgentImpl):

5:25 PM Changeset in webkit [136190] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Initialize m_xpcConnection to null if the identifier doesn't have an XPC connection
https://bugs.webkit.org/show_bug.cgi?id=103689

Reviewed by Darin Adler.

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::platformInitialize):

5:15 PM Changeset in webkit [136189] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Optimization in image decoding.
https://bugs.webkit.org/show_bug.cgi?id=88424

Patch by Viatcheslav Ostapenko <v.ostapenko@samsung.com> on 2012-11-29
Reviewed by Brent Fulgham.

Reduce branching and multiplications in JPEG image decoding loops and functions.
Code is moved to the template functions with scale and color space template parameters
because they were reason of branches inside loops. With templated funtions compiler
will generate separate instance of function for every set of parameters removing
unreachable code in every condition where constant value is used.

Rebase and update of original patch by Misha Tyutyunik <michael.tyuytunik@nokia.com> .

Thanks to Noel Gordon for his help in cleaning up remaining issues.

Covered by existing tests.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore):
(WebCore::setPixel):
(WebCore::JPEGImageDecoder::outputScanlines):

  • platform/image-decoders/jpeg/JPEGImageDecoder.h:

(JPEGImageDecoder):

5:13 PM Changeset in webkit [136188] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r135862.
http://trac.webkit.org/changeset/135862
https://bugs.webkit.org/show_bug.cgi?id=103367

We've been observing 'Fatal error in
v8::V8::AddMessageListener()' in bots

  • bindings/v8/V8Binding.cpp:

(WebCore::v8NonStringValueToWebCoreString):

  • bindings/v8/V8StringResource.cpp:

(WebCore::int32ToWebCoreStringFast):
(WebCore::int32ToWebCoreString):

  • bindings/v8/V8StringResource.h:

(WebCore::V8StringResource::V8StringResource):
(WebCore::V8StringResource::prepareBase):
(WebCore::V8StringResource::setString):
(V8StringResource):
(WebCore::V8StringResource::toString):
(WebCore::::prepare):

5:06 PM Changeset in webkit [136187] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: optimize repaint regions upon text editing
https://bugs.webkit.org/show_bug.cgi?id=103674

Reviewed by Vsevolod Vlasov.

There is a lot happening that makes repaint area larger than it should be,
namely unnecessary tabbed pane and navigator updates.

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView.prototype._updateScriptTitle):

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPaneTab.prototype.set title):

5:02 PM Changeset in webkit [136186] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Remove deprecated API since it is no longer used
https://bugs.webkit.org/show_bug.cgi?id=103570

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-11-29
Reviewed by Adam Barth.

Remove WebPluginContainer::setIsAcceptingTouchEvents, since this is not used anymore,
in favour of WebPluginContainer::requestTouchEventType.

  • public/WebPluginContainer.h:

(WebPluginContainer):

  • src/WebPluginContainerImpl.cpp:
  • src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

4:48 PM Changeset in webkit [136185] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unused parameters on plugins/npapi.cpp
https://bugs.webkit.org/show_bug.cgi?id=103676

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-29
Reviewed by Kentaro Hara.

Because 'instance' and 'menu' are not used when !PLATFORM(QT)
!defined(XP_MACOSX),

use UNUSED_PARAM macro to fix build warning -Wunused-parameter

  • plugins/npapi.cpp:

(NPN_PopUpContextMenu):

4:47 PM Changeset in webkit [136184] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r134693): Compilation error on @supports grammar code
https://bugs.webkit.org/show_bug.cgi?id=103678

Patch by Pablo Flouret <pablof@motorola.com> on 2012-11-29
Reviewed by Tony Chang.

Coming from https://bugs.webkit.org/show_bug.cgi?id=102295

No new tests, compile fix.

  • css/CSSGrammar.y.in:
4:31 PM Changeset in webkit [136183] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r136175 and r136177.
http://trac.webkit.org/changeset/136175
http://trac.webkit.org/changeset/136177
https://bugs.webkit.org/show_bug.cgi?id=103683

Changes did not correct Windows build. (Requested by bfulgham
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-29

  • TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
4:29 PM Changeset in webkit [136182] by Lucas Forschler
  • 4 edits in branches/safari-536.28-branch/Source

Versioning.

4:29 PM Changeset in webkit [136181] by Christophe Dumez
  • 3 edits in trunk/Source/WebKit2

[CoordinatedGraphics] Use OwnPtr for LayerMap's layers in LayerTreeRenderer
https://bugs.webkit.org/show_bug.cgi?id=103650

Reviewed by Noam Rosenthal.

We currently store raw pointers to WebCore::GraphicsLayer in the LayerMap
meaning that we need to delete them manually. This patch leverages smart
pointers and stores layers as OwnPtr in the LayerMap so that the layers
are owned by the HashMap and we don't have to handle memory manually.

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::adjustPositionForFixedLayers):
(WebKit::LayerTreeRenderer::setLayerChildren):
(WebKit::LayerTreeRenderer::deleteLayer):
(WebKit::LayerTreeRenderer::ensureLayer):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
4:28 PM Changeset in webkit [136180] by Lucas Forschler
  • 1 copy in tags/Safari-536.28.4

New Tag.

4:20 PM Changeset in webkit [136179] by Simon Fraser
  • 2 edits in branches/safari-536.28-branch/Source/WebCore

<rdar://problem/12781055>

Merge r136174

2012-11-29 Simon Fraser <Simon Fraser>

Avoid painting lots of small rects in WebLayer painting
https://bugs.webkit.org/show_bug.cgi?id=103673

Reviewed by Tim Horton.

r109186 added code in drawLayerContents() to enumerate over the rects in
the CALayer's dirty region, and paint them individually. This was done
to help performance on the IE Maze Solver test.

On large, complex pages like Facebook, the overhead of traversing the
RenderLayer tree for painting is such that it's better to paint a single,
or fewer rects rather than lots of little ones.

So adopt a heuristic similar to that in DrawingArea, where if the
combined area of the small rects is 75% or more of the combined rect,
just paint the combined rect. Also paint the combined rect if there
are more than 5 individual rects.

I verified that this preserves the optimization for IE Maze Solver.

  • platform/graphics/mac/WebLayer.mm: (drawLayerContents):
4:01 PM Changeset in webkit [136178] by andersca@apple.com
  • 19 edits in trunk/Source/WebKit2

Add a minimumLayoutWidth WKView property
https://bugs.webkit.org/show_bug.cgi?id=103660
<rdar://problem/11791729>

Reviewed by Beth Dakin.

When minimumLayoutWidth is set to a positive value, the WKView will update its intrinsic content size given the layout width.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::intrinsicContentSizeDidChange):
Call the WKView.

  • UIProcess/API/mac/WKView.mm:

(-[WKView intrinsicContentSize]):
Override the intrinsicContentSize getter.

(-[WKView _setIntrinsicContentSize:]):
Update the intrinsic content size and mark it as invalid.

(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
By default, the WKView should have no intrinsic size.

(-[WKView minimumLayoutWidth]):
(-[WKView setMinimumLayoutWidth:]):
Call through to the WebPageProxy object.

  • UIProcess/API/mac/WKViewPrivate.h:

Add the SPI here.

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::minimumLayoutWidthDidChange):
(WebKit::DrawingAreaProxy::didUpdateGeometry):
(WebKit::DrawingAreaProxy::intrinsicContentSizeDidChange):
Add empty stubs.

  • UIProcess/DrawingAreaProxy.messages.in:

Update the DidUpdateGeometry signature and add IntrinsicContentSizeDidChange.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
Initialize the minimum layout width.

(WebKit::WebPageProxy::setMinimumLayoutWidth):
Update the minimum layout width and call the drawing area proxy.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::minimumLayoutWidth):
Add getter.

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:

(TiledCoreAnimationDrawingAreaProxy):

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::minimumLayoutWidthDidChange):
Update the geometry if needed.

(WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry):
Update the intrinsic content size.

(WebKit::TiledCoreAnimationDrawingAreaProxy::intrinsicContentSizeDidChange):
Call through to WebPageProxy::intrinsicContentSizeDidChange.

(WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry):
Pass along the minimum layout width.

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::intrinsicContentSizeDidChange):
Call through to the page client.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):
Call DrawingArea::mainFrameContentSizeChanged.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::mainFrameContentSizeChanged):
Add empty stub.

(WebKit::DrawingArea::updateGeometry):
Update signature.

  • WebProcess/WebPage/DrawingArea.messages.in:

Add minimumLayoutWidth to UpdateGeometry.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
If the content size change is not coming from updateGeometry, send an InstrinsicContentSizeDidChange message.

(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
If m_minimumLayoutWidth is positive, do an initial layout pass to figure out the height of the page and then do another
layout with the viewport set to that height.

3:40 PM Changeset in webkit [136177] by bfulgham@webkit.org
  • 2 edits in trunk/Tools

[Windows, WinCairo] Unreviewed build correction. Correct debug
build case on build machine.

  • TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3:37 PM Changeset in webkit [136176] by zmo@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-29

  • DEPS:
3:30 PM Changeset in webkit [136175] by bfulgham@webkit.org
  • 2 edits in trunk/Tools

[Windows, WinCairo] Unreviewed build correction. Hide the
unexported 'notSolidColor' symbol when testing against
the BitmapImage class to avoid having to deal with a
debug-only symbol in the Windows export definition file.

  • TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3:21 PM Changeset in webkit [136174] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Avoid painting lots of small rects in WebLayer painting
https://bugs.webkit.org/show_bug.cgi?id=103673

Reviewed by Tim Horton.

r109186 added code in drawLayerContents() to enumerate over the rects in
the CALayer's dirty region, and paint them individually. This was done
to help performance on the IE Maze Solver test.

On large, complex pages like Facebook, the overhead of traversing the
RenderLayer tree for painting is such that it's better to paint a single,
or fewer rects rather than lots of little ones.

So adopt a heuristic similar to that in DrawingArea, where if the
combined area of the small rects is 75% or more of the combined rect,
just paint the combined rect. Also paint the combined rect if there
are more than 5 individual rects.

I verified that this preserves the optimization for IE Maze Solver.

  • platform/graphics/mac/WebLayer.mm:

(drawLayerContents):

3:17 PM Changeset in webkit [136173] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] window.open can load url twice which can cause security and timing issues
https://bugs.webkit.org/show_bug.cgi?id=103670

Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Yong Li.

PR: 252234
When we call window.open() in JS, DOMWindow will create a window and
change the url to load the resources. However, during the window
creation, we dispatch an OpenWindow event with the url to browser side
and browser side loads the url thereafter as well.
DOMWindow::createWindow() is only required to create the window not to
load url as far as I can tell. This is unneccessary and can cause
unexpected issues. So just pass an empty url instead to avoid
the double-load issue.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::createWindow):

3:16 PM Changeset in webkit [136172] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

CoreIPC::Connection should retain its xpc_connection_t
https://bugs.webkit.org/show_bug.cgi?id=103671
<rdar://problem/12717331>

Reviewed by Beth Dakin.

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::platformInitialize):
Retain the xpc_connection_t object here to balance the xpc_object_release in platformInvalidate.

3:07 PM Changeset in webkit [136171] by commit-queue@webkit.org
  • 12 edits in trunk/Source

Source/WebCore: Web Inspector: Web Inspector: Make main-thread monitoring go through InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=103550

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-11-29
Reviewed by Pavel Feldman.

InspectorInstrumentation was a wrong path.

  • inspector/InspectorClient.h: Remove start/stop methods.
  • inspector/InspectorController.cpp:

Dispatch main thread activity notifications.

  • inspector/InspectorController.h: Ditto.
  • inspector/InspectorInstrumentation.cpp: Remove dispatching.
  • inspector/InspectorInstrumentation.h: Ditto.
  • inspector/InspectorTimelineAgent.cpp:

Do not subscribe for notifications explicitly.

Source/WebKit/chromium: Web Inspector: Make main-thread monitoring go through InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=103550

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-11-29
Reviewed by Pavel Feldman.

InspectorInstrumentation was a wrong path

  • src/InspectorClientImpl.cpp: Remove TaskObserver implementation, and

listen/unlisten methods.

  • src/InspectorClientImpl.h: Ditto.
  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::attach):
Subscribe for main thread activity events.
(WebKit::WebDevToolsAgentImpl::detach):
Unsubscribe for main thread activity events.
(WebKit::WebDevToolsAgentImpl::willProcessTask): Implement TaskObserver
interface. Froward to InspectorController.
(WebKit::WebDevToolsAgentImpl::didProcessTask): Ditto.

  • src/WebDevToolsAgentImpl.h: Implement TaskObserver interface.
3:06 PM Changeset in webkit [136170] by Lucas Forschler
  • 4 edits in branches/safari-536.28-branch/Source

Versioning.

3:04 PM Changeset in webkit [136169] by Lucas Forschler
  • 1 copy in tags/Safari-536.28.3

New Tag.

2:59 PM Changeset in webkit [136168] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

[V8] DOM callbacks shouldn't reimplement ScopedPersistent they should use it
https://bugs.webkit.org/show_bug.cgi?id=103662

Reviewed by Eric Seidel.

This patch replaces yet another instance of the ScopedPersistent
pattern with ScopedPersistent.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateCallbackHeader):
(GenerateCallbackImplementation):

  • bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:

(WebCore::V8SQLStatementErrorCallback::handleEvent):

  • bindings/v8/custom/V8MutationCallbackCustom.cpp:

(WebCore::V8MutationCallback::handleEvent):

2:34 PM Changeset in webkit [136167] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Make LazyDecodingPixelRef inherit from skia::LazyPixelRef so that cc thread can access it
https://bugs.webkit.org/show_bug.cgi?id=103555

Patch by Min Qin <qinmin@chromium.org> on 2012-11-29
Reviewed by Stephen White.

Expose LazyDecodingPixelRef to the cc thread by inheriting from skia::LazyPixelRef.
No test added for now as impl side paiting is still WIP.

  • platform/graphics/chromium/LazyDecodingPixelRef.cpp:

(WebCore::LazyDecodingPixelRef::LazyDecodingPixelRef):
(WebCore::LazyDecodingPixelRef::PrepareToDecode):
(WebCore):
(WebCore::LazyDecodingPixelRef::Decode):

  • platform/graphics/chromium/LazyDecodingPixelRef.h:

(LazyDecodingPixelRef):

2:26 PM Changeset in webkit [136166] by jchaffraix@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

  • WebCore.gypi:

The new file is GridTrackSize.h not GridTrackSizes.h. For some reason, the
EWS didn't complain.

2:26 PM Changeset in webkit [136165] by zmo@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, WebKit gardening.

  • platform/chromium/TestExpectations:
2:18 PM Changeset in webkit [136164] by jknotten@chromium.org
  • 4 edits
    4 adds in trunk

Use GeolocationController's last geoposition as cached position.
https://bugs.webkit.org/show_bug.cgi?id=103540

Reviewed by Benjamin Poulain.

The page's GeolocationController mediates access to the
GeolocationClient for multiple frames' Geolocation instances. This
patch changes the position cache to be on the GeolocationController
rather than on the Geolocation instance.

This fixes a bug where if one frame has has received a fresh
position, then a request for a cached position from a second frame
does not succeed because the Geolocation instance in the second
frame's position cache hasn't received the position update that
went to the first frame.

Source/WebCore:

Test: fast/dom/Geolocation/cached-position-iframe.html

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::makeCachedPositionCallbacks):
(WebCore::Geolocation::haveSuitableCachedPosition):
(WebCore::Geolocation::positionChanged):

  • Modules/geolocation/Geolocation.h:
  • Modules/geolocation/GeolocationController.h:

(GeolocationController):

LayoutTests:

  • fast/dom/Geolocation/cached-position-iframe-expected.txt: Added.
  • fast/dom/Geolocation/cached-position-iframe.html: Added.
  • fast/dom/Geolocation/resources/cached-position-iframe-inner.html: Added.
  • fast/dom/Geolocation/script-tests/cached-position-iframe.js: Added.

(window.onmessage):

2:16 PM Changeset in webkit [136163] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Allow sorting in NMI snapshot grid view
https://bugs.webkit.org/show_bug.cgi?id=102955

Patch by Alexei Filippov <alph@chromium.org> on 2012-11-29
Reviewed by Yury Semikhatsky.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeSnapshotDataGrid.prototype.sortingChanged):
(WebInspector.NativeSnapshotDataGrid.prototype._sortingFunction):
(WebInspector.NativeSnapshotNode):
(WebInspector.NativeSnapshotNode.prototype._storeState):
(WebInspector.NativeSnapshotNode.prototype._restoreState):
(WebInspector.NativeSnapshotNode.prototype.uid):
(WebInspector.NativeSnapshotNode.prototype._createSizeCell):

2:13 PM Changeset in webkit [136162] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Modifying GeoClientBlackBerry to switch between high and low accuracy
https://bugs.webkit.org/show_bug.cgi?id=103666

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-11-29
Reviewed by Yong Li.

Internally reviewed by Yong Li.

PR 243420

Updating GeolocationClientBlackBerry to switch accuracy when GeolocationController
calls setEnableHighAccuracy.

  • WebCoreSupport/GeolocationClientBlackBerry.cpp:

(GeolocationClientBlackBerry::startUpdating):
(GeolocationClientBlackBerry::setEnableHighAccuracy):

1:52 PM Changeset in webkit [136161] by zmo@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, WebKit gardening.

  • platform/chromium/TestExpectations:
1:35 PM Changeset in webkit [136160] by schenney@chromium.org
  • 22 edits
    2 adds in trunk/LayoutTests

[Chromium] Skia rebaseline after we made kSrc_Mode go faster

Unreviewed expectations update.

Some of these are still crashing on Debug.

  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-mac-lion/svg/carto.net/colourpicker-expected.png:
  • platform/chromium-mac-lion/svg/custom/invalid-uri-stroke-expected.png:
  • platform/chromium-mac-lion/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/colourpicker-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/invalid-uri-stroke-expected.png:
  • platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-mac/svg/carto.net/colourpicker-expected.png:
  • platform/chromium-mac/svg/custom/gradient-stop-corner-cases-expected.png:
  • platform/chromium-mac/svg/custom/invalid-uri-stroke-expected.png:
  • platform/chromium-mac/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-win-xp/svg/carto.net: Added.
  • platform/chromium-win-xp/svg/carto.net/colourpicker-expected.png: Added.
  • platform/chromium-win-xp/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-win/svg/custom/invalid-uri-stroke-expected.png:
  • platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium/TestExpectations:
1:31 PM Changeset in webkit [136159] by bfulgham@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Windows, WinCairo] Unreviewed build fix. Build was failing
because the export definition file included a debug-only
symbol. It's not needed and shouldn't be included for export.

  • win/WebKit2.def: Don't require notSolidColor to be exported.
  • win/WebKit2CFLite.def: Ditto.
1:27 PM Changeset in webkit [136158] by peter@chromium.org
  • 2 edits in trunk/Tools

run-perf-tests --chromium-android should not require adb in my path
https://bugs.webkit.org/show_bug.cgi?id=103581

Reviewed by Eric Seidel.

Remove the need to have "adb" available in the path for Layout and Performance
tests. We'll determine the versions of the "adb" version in path (if any) and
the one provided in the Chromium Android checkout. Unless the "adb" available
in the path is newer, the provided version will be used.

Some other minor nits addressed:

  • The path_to_forwarder/path_to_md5sum should not be in the "private overrides" section, as they're not overriding anything and are used by the driver.
  • Make _restart_adb_as_root slightly more robust by waiting for the device to come back online regardless of the output.
  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidPort.init):
(ChromiumAndroidPort.check_build):
(ChromiumAndroidPort.path_to_adb):
(ChromiumAndroidPort):
(ChromiumAndroidPort.path_to_forwarder):
(ChromiumAndroidPort.path_to_md5sum):
(ChromiumAndroidPort._path_to_helper):
(ChromiumAndroidPort._determine_adb_version):
(ChromiumAndroidPort._get_devices):
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
(ChromiumAndroidDriver._push_executable):
(ChromiumAndroidDriver._restart_adb_as_root):

1:25 PM Changeset in webkit [136157] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Do not adjust scroll position on viewport resizes that are not orientation change related
https://bugs.webkit.org/show_bug.cgi?id=103659

Patch by Andrew Lo <anlo@rim.com> on 2012-11-29
Reviewed by Rob Buis.
Internally reviewed by Gen Mak.

Internal PR253893.
Only adjust scroll position during an orientation change
when setting viewport size.
We don't want the scroll position jumping around when opening
& closing the VKB.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

1:22 PM Changeset in webkit [136156] by schenney@chromium.org
  • 20 edits
    4 adds
    3 deletes in trunk/LayoutTests

[Chromium] Rebaseline after removed double drawing of clipped hairlines at edges

Unreviewed expectations update

  • platform/chromium-linux-x86/svg/hixie/perf/003-expected.png: Removed.
  • platform/chromium-mac-lion/fast/repaint/list-marker-expected.png: Added.
  • platform/chromium-mac-lion/svg/hixie/perf/001-expected.png: Added.
  • platform/chromium-mac-lion/svg/hixie/perf/002-expected.png: Added.
  • platform/chromium-mac-lion/svg/hixie/perf/003-expected.png:
  • platform/chromium-mac-lion/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/list-marker-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/perf/001-expected.png:
  • platform/chromium-mac-snowleopard/svg/hixie/perf/002-expected.png:
  • platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac/fast/repaint/list-marker-expected.png:
  • platform/chromium-mac/svg/hixie/perf/001-expected.png:
  • platform/chromium-mac/svg/hixie/perf/002-expected.png:
  • platform/chromium-mac/svg/hixie/perf/003-expected.png:
  • platform/chromium-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/fast/repaint/list-marker-expected.png:
  • platform/chromium-win/svg/hixie/perf/001-expected.png:
  • platform/chromium-win/svg/hixie/perf/002-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
  • platform/gtk/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Removed.
  • platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Removed.
  • svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
1:08 PM Changeset in webkit [136155] by schenney@chromium.org
  • 22 edits
    6 adds
    3 deletes in trunk/LayoutTests

[Chromium] Rebaseline after SK_DISABLE_EXTRACTSUBSET_OPAQUE_FIX was removed

Unreviewed test expectations update.

  • platform/chromium-linux-x86/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Removed.
  • platform/chromium-linux-x86/svg/custom/clip-mask-negative-scale-expected.png: Removed.
  • platform/chromium-linux/svg/transforms/text-with-mask-with-svg-transform-expected.png:
  • platform/chromium-mac-lion/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Added.
  • platform/chromium-mac-lion/fast/borders/border-image-rotate-transform-expected.png: Added.
  • platform/chromium-mac-lion/fast/forms/select-style-expected.png: Added.
  • platform/chromium-mac-lion/svg/custom/clip-mask-negative-scale-expected.png: Added.
  • platform/chromium-mac-lion/svg/custom/focus-ring-expected.png: Added.
  • platform/chromium-mac-lion/svg/transforms/animated-path-inside-transformed-html-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/select-style-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
  • platform/chromium-mac/fast/forms/select-style-expected.png:
  • platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-mac/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-win-xp/svg/custom/clip-mask-negative-scale-expected.png: Removed.
  • platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-win/fast/borders/border-image-rotate-transform-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDashed06-expected.png:
  • platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
  • platform/chromium-win/svg/custom/focus-ring-expected.png:
  • platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium/TestExpectations:
1:05 PM Changeset in webkit [136154] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

PDFPlugin: Only plain text can be copied out of PDFs
https://bugs.webkit.org/show_bug.cgi?id=103591
<rdar://problem/12555161>

Reviewed by Alexey Proskuryakov.

Enable rich data to be copied from PDFKit to the pasteboard.

  • WebProcess/Plugins/PDF/PDFPlugin.h:

(PDFPlugin): Add writeItemsToPasteboard.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(-[WKPDFLayerControllerDelegate writeItemsToPasteboard:withTypes:]): Move implementation to PDFPlugin.
(WebKit::PDFPlugin::writeItemsToPasteboard): Don't round-trip through WebCore for pasteboard operations,
use WebContext directly. This provides a simple way to hand over a buffer for complex pasteboard types
(RTF, HTML, etc.). Use this interface for arbitrary non-plain-text pasteboard data that PDFKit hands us.

12:44 PM Changeset in webkit [136153] by schenney@chromium.org
  • 14 edits
    7 adds
    15 deletes in trunk/LayoutTests

[Chromium] Expectations update

Unreviewed expectation.

These expectations seem to have been rebaselined in error or missed
being rebaselined during the great Skia rebaseline of Thanksgiving
Day. This fixes some failing expectations and removes some incorrect
expectations that crept in.

  • fast/repaint/bugzilla-6278-expected.png: Added.
  • fast/repaint/invisible-objects-expected.png: Added.
  • platform/chromium-mac-lion/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-mac-lion/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-mac-lion/fast/repaint/bugzilla-6278-expected.png: Added.
  • platform/chromium-mac-lion/fast/repaint/invisible-objects-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/bugzilla-6278-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/line-initial-and-final-swashes-expected.png: Removed.
  • platform/chromium-mac/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-mac/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-mac/fast/repaint/bugzilla-6278-expected.png: Added.
  • platform/chromium-mac/fast/repaint/iframe-scroll-repaint-expected.png: Added.
  • platform/chromium-win-xp/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-win-xp/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-win/fast/repaint/body-background-image-expected.png:
  • platform/chromium-win/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-win/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-win/fast/repaint/invisible-objects-expected.png: Added.
  • platform/chromium-win/fast/text/font-initial-expected.png:
  • platform/chromium-win/fast/text/line-initial-and-final-swashes-expected.png: Removed.
  • platform/chromium-win/fast/text/line-initial-and-final-swashes-expected.txt: Removed.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/js/date-toisostring-expected.txt: Removed.
  • platform/chromium/fast/js/toString-and-valueOf-override-expected.txt: Removed.
  • platform/chromium/fast/repaint/bugzilla-6278-expected.png: Removed.
  • platform/chromium/fast/repaint/iframe-scroll-repaint-expected.png: Removed.
  • platform/chromium/fast/repaint/invisible-objects-expected.png: Removed.
  • platform/chromium/svg/custom/getBBox-path-expected.txt: Removed.
  • platform/chromium/svg/custom/global-constructors-expected.txt: Removed.
  • platform/efl/fast/repaint/bugzilla-6278-expected.png: Removed.
  • platform/efl/fast/repaint/invisible-objects-expected.png: Removed.
  • platform/gtk/fast/repaint/bugzilla-6278-expected.png: Removed.
  • platform/gtk/fast/repaint/invisible-objects-expected.png: Removed.
12:36 PM Changeset in webkit [136152] by commit-queue@webkit.org
  • 14 edits in trunk

[GTK] [WebKit2] Embed the HTTP authentication dialog into the WebView
https://bugs.webkit.org/show_bug.cgi?id=103277

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-11-29
Reviewed by Carlos Garcia Campos.

Source/WebCore:

Refactor the WebCore authentication dialog so that it can be reused for the WebKit2
embedded authentication dialog. The main purpose of this refactor is so that the
dialog does not rely on GtkDialog to add the action buttons to the dialog itself.
This also simplifies the structure of the dialog, using the GtkTable or GtkGrid to
contain more of the widget elements, greatly simplifying this code. We also expose
a new constructor that does not create the parent GtkDialog -- so that WebKit2
can embed the dialog directly into the WebView.

No new tests. This shouldn't change behavior, only slightly the look of the authentication
dialog.

  • platform/gtk/GtkAuthenticationDialog.cpp:

(WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog): Added this new constructor
which does not add the dialog contents to a GtkDialog.
(WebCore::packTwoColumnLayoutInBox): Added this generic method for creating a two column
layout in the style the dialog box needs (for both GTK+ 2.x and GTK+ 3.x).
(WebCore::createDialogLabel): Added this helper.
(WebCore::createDialogEntry): ditto.
(WebCore::GtkAuthenticationDialog::createContentsInContainer): Added this method which
can be used by subclasses to add the guts of the dialog to the parent container.
(WebCore::GtkAuthenticationDialog::show): Added some focus/default handling code that
GtkDialog was calling before.
(WebCore::GtkAuthenticationDialog::buttonClickedCallback): Added a button clicked handler.
Before GtkDialog handled this.

  • platform/gtk/GtkAuthenticationDialog.h: Updated methods to reflect new functionality.

(WebCore::GtkAuthenticationDialog::~GtkAuthenticationDialog): Inline the default constructor.

Source/WebKit2:

Embed the WebKit2 HTTP authentication dialog into the WebView. Add the dialog as a child
of the WebKitWebViewBase container (like the web inspector).

We do not yet properly handle pages that require authentication for more than one resource.
As that is an uncommon situation, it will be handled in another patch.

  • UIProcess/API/gtk/WebKit2GtkAuthenticationDialog.cpp:

(WebKit::drawSignal): We have to override the draw signal of the dialog to draw
a GtkWindow background on the widget. This is required because the widget doesn't
have a real GtkWindow to draw its background.
(WebKit::loadChangedSignal): When a new load starts in the WebView destroy the dialog. This
is so that the dialog doesn't stick around when the user chooses to navigate away from the
page requiring authentication.
(WebKit::WebKit2GtkAuthenticationDialog::WebKit2GtkAuthenticationDialog): Create an eventbox
and frame to hold the dialog contents. Also append the 'background' widget class to the
event box, so that it can draw a GtkWindow background in the draw signal handler.
(WebKit::WebKit2GtkAuthenticationDialog::~WebKit2GtkAuthenticationDialog): Disconnect the
load status changed signal handler.
(WebKit::WebKit2GtkAuthenticationDialog::show): When it's time to show the dialog, add it to
WebKitWebViewBase.

  • UIProcess/API/gtk/WebKit2GtkAuthenticationDialog.h: Add some new methods for handling the

embedded dialog.

  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(didReceiveAuthenticationChallengeInFrame): Collapse the creation of the dialog into one line.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(_WebKitWebViewBasePrivate): Add the dialog as a property of the private structure.
(webkitWebViewChildIsInternalWidget): Added this helper used for determining when a child widget
is "internal" (ie the web inspector or the authentication dialog).
(webkitWebViewBaseContainerAdd): Only add non-internal widgets to the children map.
(webkitWebViewBaseAddAuthenticationDialog): Added.
(webkitWebViewBaseAddWebInspector): Added this more-foolproof method of adding a web inspector
to the WebView. This also aligns it with the way the authentication dialog is added.
(webkitWebViewBaseContainerRemove): When removing the authentication dialog, zero out the
field in the private structure.
(webkitWebViewBaseContainerForall): Add support for the authentication dialog here too.
(webkitWebViewBaseChildMoveResize): Don't pass on move_resize events to internal children.
(webkit_web_view_base_init): Zero out the authentication dialog member on init.
(webkitWebViewBaseDraw): If the authentication dialog is active, draw a shadow over web content.
(resizeWebKitWebViewBaseFromAllocation): Make the authentication dialog centered in the view.
(webkitWebViewBaseKeyPressEvent): Pass on key events to the authentication dialog if active.
(webkitWebViewBaseButtonPressEvent): If the authentication dialog is active don't pass button events
to web content.
(webkitWebViewBaseButtonReleaseEvent): Ditto.
(webkitWebViewBaseScrollEvent): Ditto.
(webkitWebViewBaseMotionNotifyEvent): Ditto.
(webkitWebViewBaseFocus): Pass on focus events to the authentication dialog so that tabbing between
elements in the dialog works correctly.
(webkit_web_view_base_class_init): Hook up the focus event.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Add new methods for adding the authentication dialog

and the web inspector.

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::createInspectorWindow): Use the new method for adding the web inspector.

Tools:

Skip the new WebKit2GtkAuthenticationDialog files so that they are not processed
during gtkdoc generation.

  • gtk/generate-gtkdoc:

(get_webkit2_options):

12:34 PM Changeset in webkit [136151] by Beth Dakin
  • 4 edits
    2 adds in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=103577
TiledDrawingArea should recycle tiles
-and corresponding-
<rdar://problem/12714586>

Reviewed by Simon Fraser.

New class LayerPool will keep a list of layers to reuse so that
we can avoid creating and destroying so many layer.

When removing layers, add them to the LayerPool

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::revalidateTiles):

Before creating a new layer, try to get one of the appropriate size
from the LayerPool.
(WebCore::TileCache::createTileLayer):

New class.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/ca/mac/LayerPool.h: Added.

(WebCore):
(LayerPool):
(WebCore::LayerPool::capacity):
(WebCore::LayerPool::canReuseLayerWithSize):

  • platform/graphics/ca/mac/LayerPool.mm: Added.

(WebCore):
(WebCore::LayerPool:: LayerPool):
(WebCore::LayerPool::sharedPool):
(WebCore::LayerPool::bytesBackingLayerWithPixelSize):
(WebCore::LayerPool::listOfLayersWithSize):
(WebCore::LayerPool::addLayer):
(WebCore::LayerPool::takeLayerWithSize):
(WebCore::LayerPool::decayedCapacity):
(WebCore::LayerPool::schedulePrune):
(WebCore::LayerPool::prune):
(WebCore::LayerPool::drain):

If we're under memory pressure, drain the LayerPool

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::releaseMemory):

12:26 PM Changeset in webkit [136150] by jchaffraix@webkit.org
  • 11 edits
    1 add in trunk/Source/WebCore

[CSS Grid Layout] track sizing functions should have their own type
https://bugs.webkit.org/show_bug.cgi?id=103343

Reviewed by Tony Chang.

The current code uses a Length to represent the track sizing function. This is
fine as we only parse <length> | <percentage> but in order to support minmax
sizing, we have to store 2 Lengths. We could go with a pair but that would make
the code not very readable so this change introduces GridTrackSize.

Refactoring, covered by existing tests.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added GridTrackSize.h to all our build systems.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridTrackBreadth):
(WebCore::valueForGridTrackList):

  • css/StyleResolver.cpp:

(WebCore::createGridTrackBreadth):
(WebCore::createGridTrackList):
(WebCore::StyleResolver::applyProperty):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computePreferredLogicalWidths):
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):

  • rendering/style/RenderStyle.h:

Updated the above call sites to use GridTrackSize. While
touching them, changed the code to use an empty Vector to represent
'none' instead of Length(Undefined).

  • rendering/style/StyleGridData.h:

Updated #include, removed a comment as it would have gone stale after
adding more grammar support and added a FIXME to rename some variables.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutGridItems):
Implemented a work-around to avoid crashing due to implicit columns / rows.

  • rendering/style/GridTrackSize.h: Added.

(WebCore::GridTrackSize::GridTrackSize):
(WebCore::GridTrackSize::length):
(WebCore::GridTrackSize::setLength):
(WebCore::GridTrackSize::type):
(WebCore::GridTrackSize::operator==):
New class, it now only wraps a single Length.

12:23 PM Changeset in webkit [136149] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Typo in Color creation function name
https://bugs.webkit.org/show_bug.cgi?id=103464

Patch by Helder Correia <Helder Correia> on 2012-11-29
Reviewed by Alexey Proskuryakov.

Renaming createUnCheked() as createUnchecked().

No new tests.

  • platform/graphics/Color.cpp:

(WebCore::colorFromPremultipliedARGB):

  • platform/graphics/Color.h:

(WebCore::Color::createUnchecked):

12:15 PM Changeset in webkit [136148] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Cookies in private mode should not have access to public cookies
https://bugs.webkit.org/show_bug.cgi?id=103649

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-11-29
Reviewed by Rob Buis.

PR 253983

When CookieManager switches back from public to private mode,
we will clear the cookie tree so the browser won't have access
to the public cookies.

Tested using browser.swlab.rim.net cookie tests and the steps in
the PR.

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::setPrivateMode):

12:12 PM Changeset in webkit [136147] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

Be consistent in handling of frameAtIndex (and related) returns.
https://bugs.webkit.org/show_bug.cgi?id=103207

Patch by Brent Fulgham <bfulgham@gmail.com> on 2012-11-29
Reviewed by David Hyatt.

Under various conditions, frameAtIndex (and therefore,
nativeImageForCurrentFrame) returns null. A series of bugs over
the years has ensured null returns are handled in some cases,
but there are a handful of remaining cases where this is still a
problem.

No new tests, as these low-level functions are covered by
numerous existing test cases.

12:11 PM Changeset in webkit [136146] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

[New Multicolumn] Add minimum column height tracking and forced break tracking to column sets.
https://bugs.webkit.org/show_bug.cgi?id=103657

Reviewed by Simon Fraser.

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):

  • rendering/RenderMultiColumnSet.h:

(WebCore::RenderMultiColumnSet::updateMinimumColumnHeight):
(WebCore::RenderMultiColumnSet::minimumColumnHeight):
(RenderMultiColumnSet):
(WebCore::RenderMultiColumnSet::forcedBreaksCount):
(WebCore::RenderMultiColumnSet::forcedBreakOffset):
(WebCore::RenderMultiColumnSet::maximumDistanceBetweenForcedBreaks):
(WebCore::RenderMultiColumnSet::clearForcedBreaks):
(WebCore::RenderMultiColumnSet::addForcedBreak):

12:06 PM Changeset in webkit [136145] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: introduce fast case for within-chunk edit
https://bugs.webkit.org/show_bug.cgi?id=103545

Reviewed by Vsevolod Vlasov.

Special-casing edits within the chunk for faster operation.

  • inspector/front-end/DOMExtension.js:

(removeSubsequentNodes):

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):

11:59 AM Changeset in webkit [136144] by pfeldman@chromium.org
  • 13 edits in trunk/Source/WebCore

Web Inspector: Console: hovering node wrappers in object tree should highlight them on the page
https://bugs.webkit.org/show_bug.cgi?id=101150

Reviewed by Vsevolod Vlasov.

  • Introduced a way to highlight nodes by object id in addition to node id.
  • Decorated nodes in the object tree outline and added on-hover highlighting.
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::highlightNode):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._appendPropertyPreview):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype.highlightDOMNode):

  • inspector/front-end/DOMPresentationUtils.js:

(WebInspector.DOMPresentationUtils.createSpansForNodeTitle):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.update):
(WebInspector.ObjectPropertyTreeElement.prototype._mouseMove):
(WebInspector.ObjectPropertyTreeElement.prototype._mouseOut):

  • inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.highlightAsDOMNode):
(WebInspector.RemoteObject.prototype.hideDOMNodeHighlight):

  • inspector/front-end/TestController.js:
  • inspector/front-end/externs.js:
  • inspector/front-end/inspector.css:

(.console-formatted-node:hover):

  • inspector/front-end/utilities.js:
11:28 AM Changeset in webkit [136143] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] LayoutTests/fast/js/string-replacement-outofmemory.html crashes
https://bugs.webkit.org/show_bug.cgi?id=103348

Reviewed by Abhishek Arya.

Add a comment to explain that the crash is expected and is performed in an
orderly fashion.

  • platform/chromium/TestExpectations:
10:43 AM Changeset in webkit [136142] by mitz@apple.com
  • 17 edits
    3 adds in trunk

<rdar://problem/12771885> Support ruby-position: {before, after}
https://bugs.webkit.org/show_bug.cgi?id=103569

Reviewed by Anders Carlsson.

Source/WebCore:

Specified in <http://www.w3.org/TR/2011/WD-css3-ruby-20110630/#rubypos>, the ruby-position
property takes four values: before, after, inter-character, and inline. This change adds
support for the values before and after.

Test: fast/ruby/position-after.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Handle ruby-position.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue): Accept before and after as valid values for
ruby-position.
(WebCore::isKeywordPropertyID): Added ruby-position to the list of properties with keyword
values.
(WebCore::CSSParser::parseValue): Added ruby-position to the switch statement.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added mapping from RubyPosition.
(WebCore::CSSPrimitiveValue::operator RubyPosition): Added mapping from CSSPrimitiveValue.

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty): Added ruby-position as an inherited property.

  • css/CSSPropertyNames.in: Added -webkit-ruby-position.
  • css/CSSValueKeywords.in: Added after and before.
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder): Added a handler for ruby-position.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty): Added ruby-position.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection): Changed to choose which of
hasAnnotationsBefore and hasAnnotationsAfter to set based on ruby position.
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment): Changed to adjust only for
ruby positioned before the base.
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment): Added adjustment for ruby
positioned after the base.

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::layout): Account for ruby-position when positioning the ruby text
relative to the base.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): Made a ruby-position difference a layout difference.

  • rendering/style/RenderStyle.h: Added rubyPosition(), setRubyPosition(), and

initialRubyPosition().

  • rendering/style/RenderStyleConstants.h: Added the RubyPosition enum.
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Added initialized for
m_rubyPosition. Added copying the value of this member to the copy constructor.
(WebCore::StyleRareInheritedData::operator==): Added comparison of m_rubyPosition.

  • rendering/style/StyleRareInheritedData.h:

(StyleRareInheritedData): Added m_rubyPosition member variable.

LayoutTests:

  • fast/ruby/position-after.html: Added.
  • platform/mac/fast/ruby/position-after-expected.png: Added.
  • platform/mac/fast/ruby/position-after-expected.txt: Added.
10:22 AM Changeset in webkit [136141] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix the build after r136095
https://bugs.webkit.org/show_bug.cgi?id=103629

Unreviewed.

Add a static_cast to fix the build.

Patch by Andrei Bucur <abucur@adobe.com> on 2012-11-29

  • Shared/mac/ObjCObjectGraphCoders.mm:

(WebKit::ObjCObjectGraphEncoder::baseEncode):

10:22 AM Changeset in webkit [136140] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Speculative Windows build fix after r136086.

Unreviewed build fix.

Suspect that ?setDumpsGeneratedCode@BytecodeGenerator@JSC@@SAX_N@Z needs to be removed from Windows
export list since the symbol was removed in r136086.

10:17 AM Changeset in webkit [136139] by Christophe Dumez
  • 3 edits in trunk/Source/WebKit2

[CoordinatedGraphics] Have LayerTreeRenderer::ensureLayer() return the layer
https://bugs.webkit.org/show_bug.cgi?id=103645

Reviewed by Noam Rosenthal.

The current LayerTreeRenderer code keep calling ensureLayer() and then
LayerMap::find() to retrieve the layer. Since ensureLayer() already has
a pointer to the layer, we can simply have the function return it.
This is slightly more efficient and it makes the code a bit simpler.

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::setLayerChildren):
(WebKit::LayerTreeRenderer::setLayerFilters):
(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::ensureLayer):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
10:14 AM Changeset in webkit [136138] by schenney@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Add code supppression flags for skia

Unreviewed addition of Skia build flags to allow for their removal from Chromium's skia.gyp.

  • skia_webkit.gyp: Added defines for SK_DISABLE_DITHER_32BIT_GRADIENT and SK_DISABLE_DASHING_OPTIMIZATION
9:20 AM Changeset in webkit [136137] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

Build fix for WinCE after r136096.

  • wtf/StringPrintStream.cpp: Added missing include file.
9:09 AM Changeset in webkit [136136] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Update BB10 form theme.
https://bugs.webkit.org/show_bug.cgi?id=100760

Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-29
Reviewed by Rob Buis.

Internally Reviewed by Eli Fidler.
Set text color after buttons are pressed.

  • css/themeBlackBerry.css:

(input[type="button"]:active, input[type="submit"]:active, input[type="reset"]:active, input[type="file"]:active::-webkit-file-upload-button, button:active):
(select:active):

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore):
(WebCore::RenderThemeBlackBerry::paintButton):
(WebCore::RenderThemeBlackBerry::paintMenuList):

9:07 AM Changeset in webkit [136135] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

GraphicsSurfaceGLX: remove redundant parameter from resolveGLMethods.
https://bugs.webkit.org/show_bug.cgi?id=103636

Reviewed by Kenneth Rohde Christiansen.

  • platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:

(WebCore::resolveGLMethods):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):

8:50 AM Changeset in webkit [136134] by eric@webkit.org
  • 3 edits in trunk/Tools

run-perf-tests --chromium-android fails due to Skia INFO logging
https://bugs.webkit.org/show_bug.cgi?id=103585

Reviewed by Adam Barth.

Ignore all INFO logging from Chromium code.
Also added some basic testing of the ignored-stderr lines code.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest):

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(MainTest.test_ignored_stderr_lines):

7:48 AM Changeset in webkit [136133] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WK2] TiledBackingStore: User events are sent to web page before it is shown
https://bugs.webkit.org/show_bug.cgi?id=101753

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-29
Reviewed by Jocelyn Turcotte.

User events are suppressed on WEB process side while drawing area is frozen.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::wheelEvent):
(WebKit::WebPage::keyEvent):
(WebKit::WebPage::gestureEvent):
(WebKit::WebPage::touchEvent):
(WebKit::WebPage::sendIfEventCannotBeHandled):
(WebKit):
(WebKit::WebPage::didCompletePageTransition):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

7:34 AM Changeset in webkit [136132] by mkwst@chromium.org
  • 4 edits in trunk

Typo in 'autofocus' sandboxing error message.
https://bugs.webkit.org/show_bug.cgi?id=103616

Reviewed by Jochen Eisinger.

Source/WebCore:

The sandbox attribute name is 'allow-scripts', not 'allow-script'. :(

  • html/HTMLFormControlElement.cpp:

(WebCore::shouldAutofocus):

LayoutTests:

  • fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
7:33 AM Changeset in webkit [136131] by morrita@google.com
  • 6 edits
    2 adds in trunk

Source/WebCore: HTMLMediaElement's .textTracks property does not reflect <track> element
https://bugs.webkit.org/show_bug.cgi?id=103420

Reviewed by Eric Carlson.

There were some assumptions that <track> elements are valid only
if the parent <media> is in document. This change relaxes this
assumption so that <track> is valid when it has <media> as a
parent regardless whether the <media> is in the document or not.

HTMLMediaElement::didAddTrack and didRemoveTrack are now called
when the <track> is inserted to or removed from the parent <media>
element.

Test: media/track/track-node-add-remove.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::didRemoveTrack):
Renamed from willRemoveTrack() to reflect the timing. This was once called from
Node::willRemove(), which was removed a while ago.

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::insertedInto):
The old code notified parent <media> only if the subtree became a part of the document.
Now it notifies the <media> when this <track> becomes a child of that <media>.

(WebCore::HTMLTrackElement::removedFrom):
The old code notifies the parent <media> every time as long as the parent is available.
Now it notifies the <media> only if this <track> is removed from the parent <media>.
This matches how corresponding notification is done in insertedInto().

  • html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::trackElementIndex):

LayoutTests: HTMLMediaElement's .textTracks property does not reflect <track> element
https://bugs.webkit.org/show_bug.cgi?id=103420

Reviewed by Eric Carlson.

  • media/track/track-node-add-remove-expected.txt: Added.
  • media/track/track-node-add-remove.html: Added.
7:31 AM Changeset in webkit [136130] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, update Mac expectation after r136128.

  • platform/chromium/TestExpectations:
7:00 AM Changeset in webkit [136129] by allan.jensen@digia.com
  • 3 edits
    1 add in trunk/Source/WebKit2

Possible to resize out of bounds
https://bugs.webkit.org/show_bug.cgi?id=103521

Reviewed by Jocelyn Turcotte.

Enforce the viewportBounds after resize, and ensure a user fitted page remains
fit on viewport resize, but not on content growth.

  • UIProcess/API/qt/tests/qmltests/WebView/tst_resize.qml: Added.
  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::didChangeContentsSize):
(WebKit::PageViewportController::didChangeViewportAttributes):
(WebKit::PageViewportController::updateMinimumScaleToFit):

  • UIProcess/PageViewportController.h:

(PageViewportController):

6:57 AM Changeset in webkit [136128] by schenney@chromium.org
  • 2 edits
    1 move
    4 deletes in trunk/LayoutTests

Unreviewed Chromium expectations cleanup

  • platform/chromium-mac-snowleopard/fast/css/font-weight-1-expected.png: Removed. Should not have been added ever.
  • platform/chromium-mac-snowleopard/fast/css/font-weight-1-expected.txt: Removed. Should not have been added ever.
  • platform/chromium-mac/fast/css/font-weight-1-expected.png: Removed. Should not have been added ever.
  • platform/chromium-mac/fast/css/font-weight-1-expected.txt: Removed. Should not have been added ever.
  • platform/chromium-win/fast/css/font-weight-1-expected.png: Removed. Should not have been added ever.
  • platform/chromium/TestExpectations: Removed tests now passing
  • platform/chromium/fast/css/font-weight-1-expected.png: Copied from LayoutTests/platform/chromium-win/fast/css/font-weight-1-expected.png.
6:38 AM Changeset in webkit [136127] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Layout Test svg/animations/mpath-remove-from-dependents-on-delete-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=103375

Unreviewed expectations update.

The test is no longer flakey after yeterdays test modification.

  • platform/chromium/TestExpectations:
6:17 AM Changeset in webkit [136126] by michael.bruning@digia.com
  • 12 edits in trunk/Source/WebKit2

[Qt][WK2] Commit the preedit string in the input method when focus is about to be moved.
https://bugs.webkit.org/show_bug.cgi?id=97774

Reviewed by Kenneth Rohde Christiansen.

Implements the handler for willSetInputMethodState in WebKit2 in Qt.
This is needed to tell the input method instance in Qt to commit its
preedit content when the focus has moved to another node to prevent a
bug where the old preedit string was kept as the preedit string and
the editor moved focus back to the old node when continuing to enter
text via the input method.

This behavior is analog to the behavior of the QtQuick text input
elements.

  • UIProcess/API/qt/raw/qrawwebview.cpp:

(QRawWebViewPrivate::handleWillSetInputMethodState):

  • UIProcess/API/qt/raw/qrawwebview_p_p.h:

(QRawWebViewPrivate):

  • UIProcess/PageClient.h:

(PageClient):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/qt/QtPageClient.cpp:

(WebKit::QtPageClient::handleWillSetInputMethodState):
(WebKit):

  • UIProcess/qt/QtPageClient.h:

(QtPageClient):

  • UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::handleWillSetInputMethodState):
(WebKit):

  • UIProcess/qt/QtWebPageEventHandler.h:

(QtWebPageEventHandler):

  • UIProcess/qt/WebPageProxyQt.cpp:

(WebKit::WebPageProxy::willSetInputMethodState):
(WebKit):

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::willSetInputMethodState):

5:34 AM Changeset in webkit [136125] by fmalita@chromium.org
  • 5 edits in trunk/Source

[Skia] Add missing OpaqueRegionSkia notifier calls
https://bugs.webkit.org/show_bug.cgi?id=102824

Reviewed by Stephen White.

Source/WebCore:

http://trac.webkit.org/changeset/135390 exposed some canvas draw clients which are not
updating the opaque region tracker. This patch adds the required notifier calls.

No new tests: platform unit tests added.

  • platform/graphics/skia/OpaqueRegionSkia.h:

(OpaqueRegionSkia):

  • platform/graphics/skia/PlatformContextSkia.h:

(WebCore::PlatformContextSkia::writePixels):
(WebCore::PlatformContextSkia::drawBitmap):
(WebCore::PlatformContextSkia::drawBitmapRect):
(WebCore::PlatformContextSkia::drawIRect):
(WebCore::PlatformContextSkia::drawPosText):
(WebCore::PlatformContextSkia::drawPosTextH):
(WebCore::PlatformContextSkia::drawTextOnPath):

Source/WebKit/chromium:

Add opaque region tracking unit tests for the new PlatformContextSkia draw methods.

  • tests/PlatformContextSkiaTest.cpp:

(WebCore::TEST):
(WebCore):

5:25 AM Changeset in webkit [136124] by Simon Hausmann
  • 9 edits in trunk/Source/WebCore

[Qt] Implement support for Cocoa based NPAPI plugins on Mac
https://bugs.webkit.org/show_bug.cgi?id=72358

Patch by Andy Shaw <andy.shaw@digia.com> on 2012-11-29
Reviewed by Simon Hausmann.

With later versions of Flash they are only Cocoa based which meant that it was not possible to use Flash in a QtWebKit browser.
This makes it possible to also use 64bit based plugins too.

  • plugins/PluginPackage.cpp:

(WebCore::PluginPackage::initializeBrowserFuncs):
(WebCore):

  • plugins/PluginQuirkSet.h:
  • plugins/PluginView.cpp:

(WebCore::PluginView::handleEvent):
(WebCore::PluginView::PluginView):
(WebCore):
(WebCore::PluginView::userAgent):

  • plugins/PluginView.h:

(WebCore):
(PluginView):

  • plugins/mac/PluginPackageMac.cpp:

(WebCore::PluginPackage::determineQuirks):
(WebCore::PluginPackage::fetchInfo):

  • plugins/mac/PluginViewMac.mm:

(WebCore):
(WebCore::initializeNPCocoaEvent):
(WebCore::getModifiers):
(WebCore::PluginView::platformStart):

  • plugins/npapi.cpp:

(NPN_PopUpContextMenu):

  • plugins/npapi.h:
5:15 AM Changeset in webkit [136123] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Remove duplicated entries from efl-wk1/TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=103236

Unreviewed. These entries exist in efl/TestExpectations. Remove duplication.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-11-29

  • platform/efl-wk1/TestExpectations:
4:23 AM Changeset in webkit [136122] by mkwst@chromium.org
  • 3 edits
    1 move in trunk/LayoutTests

Layout Test http/tests/inspector/network/script-as-text-loading-long-url.html is failing
https://bugs.webkit.org/show_bug.cgi?id=103619

Reviewed by Alexander Pavlov.

Windows doesn't like loooong filenames.

  • http/tests/inspector/network/resources/script-as-text-with-a-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-long-url.php: Renamed from LayoutTests/http/tests/inspector/network/resources/script-as-text-with-a-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-very-long-url.php.
  • http/tests/inspector/network/script-as-text-loading-long-url.html:
  • platform/chromium/TestExpectations:

Unskipping the test on XP.

3:40 AM Changeset in webkit [136121] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] flaky reftests after r135935
https://bugs.webkit.org/show_bug.cgi?id=103618

Unreviewed gardening, mark more reftests flaky after r135935.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-29

  • platform/efl-wk2/TestExpectations:
3:26 AM Changeset in webkit [136120] by shinyak@chromium.org
  • 2 edits
    3 adds in trunk/PerformanceTests

[Shadow] Performance tests of distribution for changing select attribute
https://bugs.webkit.org/show_bug.cgi?id=103611

Reviewed by Hajime Morita.

We would like to measure ShadowDOM performance and compare it to the similar functional HTML without using ShadowDOM.
In this patch, we add a case when select attribute of HTMLContentElement is changed.

  • ShadowDOM/ChangingSelect.html: Added.
  • ShadowDOM/ChangingSelectWithoutShadow.html: Added.
  • Skipped:
3:14 AM Changeset in webkit [136119] by jocelyn.turcotte@digia.com
  • 3 edits in trunk/Source/WebKit2

[Qt] The WebView should be flickable only using touch events
https://bugs.webkit.org/show_bug.cgi?id=100964

Reviewed by Kenneth Rohde Christiansen.

Let a user interacting with the WebView using a mouse the same way that a
desktop browser would.
This allows normal behaviors like text selecting, hover events, mouse cursors
as well as avoid touch highlighting and touch adjustment.

To do so we let all mouse events to be handled by the page directly instead
of sending them to QtWebPageEventHandler. Since unhandled mouse events aren't
pushed back to the PageClient like touch events does, this have the intended
behavior of not letting mouse events affect QQuickFlickable.

  • UIProcess/API/qt/qquickwebview.cpp:
  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewFlickablePrivate):

3:05 AM Changeset in webkit [136118] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Fix typo in description of openDateTimeChooser documentation
https://bugs.webkit.org/show_bug.cgi?id=103622

Patch by Miguel Garcia <miguelg@chromium.org> on 2012-11-29
Reviewed by Kent Tamura.

  • public/WebViewClient.h:

(WebViewClient):

3:03 AM Changeset in webkit [136117] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[EFL][WK2] Add support for PlatformWebView::simulateMouseMove() in TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=103252

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-29
Reviewed by Kenneth Rohde Christiansen.

Add support for PlatformWebView::simulateMouseMove() and enable
WebKit2 API test MouseMoveAfterCrash.

  • TestWebKitAPI/PlatformEfl.cmake: Enable MouseMoveAfterCrash API

test.

  • TestWebKitAPI/efl/PlatformWebView.cpp:

(TestWebKitAPI::onWebProcessCrashed): Handle 'webprocess,crashed' signal
to prevent loading an error page since the test case is reloading actual
page after web process has terminated and recovered.
(TestWebKitAPI):
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::simulateMouseMove): Implemented.

2:56 AM Changeset in webkit [136116] by Simon Hausmann
  • 7 edits
    3 adds in trunk

[Qt] Fix installation of QtWebProcess binary
https://bugs.webkit.org/show_bug.cgi?id=101735

Patch by Andras Becsi <andras.becsi@digia.com> on 2012-11-29
Reviewed by Simon Hausmann.

Source/WebKit2:

If available use QLibraryInfo::LibraryExecutablesPath to find
the web process and the plugin process and deploy both helper
processes to QT_INSTALL_LIBEXECS.

The effective fallback used to find the helper processes becomes:

  1. Application directory
  2. Qt library executables directory (QLibraryInfo::LibraryExecutablesPath)
  3. Qt binaries directory (QLibraryInfo::BinariesPath)
  4. No absolute path used
  • PluginProcess.pro:
  • Shared/qt/ProcessExecutablePathQt.cpp:

(WebKit::executablePath):

  • WebProcess.pro:

Tools:

Add config test to detect the availability of support
for "program executables" in Qt (libexec).

This test can be removed after the Qt5 release.

  • Tools.pro:
  • qmake/mkspecs/features/features.prf:
  • qmake/config.tests/libexecdir/libexecdir.cpp:
  • qmake/config.tests/libexecdir/libexecdir.pro:
2:40 AM Changeset in webkit [136115] by kkristof@inf.u-szeged.hu
  • 5 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.
Rebase 3 tests. Skip one test because it needs Qt implementation.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-11-29

  • platform/qt/TestExpectations:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
2:18 AM Changeset in webkit [136114] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] remove failure expectations from passing tests
https://bugs.webkit.org/show_bug.cgi?id=103523

Unreviewed gardening, remove failure expectations:
http/tests/security/isolatedWorld/world-reuse.html was fixed in
r135871 and the rest have been passing for a long while according
to flakiness dashboard.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-29

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
2:16 AM Changeset in webkit [136113] by apavlov@chromium.org
  • 14 edits
    2 deletes in trunk

Unreviewed, rolling out r136111.
http://trac.webkit.org/changeset/136111
https://bugs.webkit.org/show_bug.cgi?id=103620

Broke compilation on Mac (unused private field m_matchMode)
(Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-29

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLSelectElement.cpp:

(WebCore):
(WebCore::HTMLSelectElement::HTMLSelectElement):
(WebCore::stripLeadingWhiteSpace):
(WebCore::HTMLSelectElement::typeAheadFind):

  • html/HTMLSelectElement.h:

(HTMLSelectElement):

  • html/TypeAhead.cpp: Removed.
  • html/TypeAhead.h: Removed.
  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement):
(WebCore::DateTimeSymbolicFieldElement::handleKeyboardEvent):

  • html/shadow/DateTimeSymbolicFieldElement.h:

(DateTimeSymbolicFieldElement):

LayoutTests:

  • fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html:
1:47 AM Changeset in webkit [136112] by mkwst@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:

Skipping 'http/tests/inspector/network/script-as-text-loading-long-url.html'
on WinXP.

1:15 AM Changeset in webkit [136111] by keishi@webkit.org
  • 14 edits
    2 adds in trunk

Better type ahead for DateTimeSymbolicFieldElement
https://bugs.webkit.org/show_bug.cgi?id=103031

Reviewed by Kent Tamura.

Source/WebCore:

This cuts out the type ahead code that will be used by HTMLSelectElement
and DateTimeSymbolicFieldElement into a TypeAhead class. This will
improve DateTimeSymbolicFieldElement type ahead which was first
character match only, by adding cycling, prefix match and index number
match.

Added tests to month-multiple-fields-keyboard-events.html.

  • GNUmakefile.list.am: Added TypeAhead.{h,cpp}
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • CMakeLists.txt: Ditto.
  • html/HTMLSelectElement.cpp:

(WebCore):
(WebCore::HTMLSelectElement::HTMLSelectElement):
(WebCore::HTMLSelectElement::indexOfSelectedOption): Returns index of current selection.
(WebCore::HTMLSelectElement::optionCount): Returns total number of options.
(WebCore::HTMLSelectElement::optionAtIndex): Returns option at index.
(WebCore::HTMLSelectElement::typeAheadFind): Use TypeAhead.

  • html/HTMLSelectElement.h:

(HTMLSelectElement):

  • html/TypeAhead.cpp: Added.

(WebCore):
(WebCore::TypeAhead::TypeAhead):
(WebCore::stripLeadingWhiteSpace): Moved from HTMLSelectElement.cpp.
(WebCore::TypeAhead::handleEvent): Returns index for match.

  • html/TypeAhead.h: Added.

(WebCore):
(TypeAheadDataSource): Provide the data about the options that TypeAhead should match against.
(TypeAhead):

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement):
(WebCore::DateTimeSymbolicFieldElement::handleKeyboardEvent):
(WebCore::DateTimeSymbolicFieldElement::indexOfSelectedOption):
(WebCore):
(WebCore::DateTimeSymbolicFieldElement::optionCount):
(WebCore::DateTimeSymbolicFieldElement::optionAtIndex):

  • html/shadow/DateTimeSymbolicFieldElement.h:

(DateTimeSymbolicFieldElement):

LayoutTests:

  • fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html: Added tests for typeahead.
12:59 AM Changeset in webkit [136110] by tkent@chromium.org
  • 3 edits
    8 copies
    21 deletes in trunk/LayoutTests

Convert *-appearance-pseudo-classes.html to dumpAsText tests
https://bugs.webkit.org/show_bug.cgi?id=103602

Reviewed by Kentaro Hara.

fast/forms/*/*-appearance-pseudo-classes.html doesn't need to be a pixel
test because "how css properties are applied" is tested in
fast/forms/*/*-appearance-basic.html. Checking querySelectorAll result
is enough to check pseudo classes support, and we can convert the test
to a dumpAsText test. We imporve test coverage in the new dumpAsText tests.

Also, this patch adds missing datetimelocal-pseudo-classes.html.

  • fast/forms/date/date-pseudo-classes-expected.txt:
  • fast/forms/date/date-pseudo-classes.html: Add :in-range -> :out-of-range cases.
  • fast/forms/datetimelocal/datetimelocal-pseudo-classes-expected.txt: Added.
  • fast/forms/datetimelocal/datetimelocal-pseudo-classes.html: Added.
  • fast/forms/month/month-appearance-pseudo-classes-expected.txt: Removed.
  • fast/forms/month/month-appearance-pseudo-classes.html: Removed.
  • fast/forms/month/month-pseudo-classes-expected.txt: Added.
  • fast/forms/month/month-pseudo-classes.html: Added.
  • fast/forms/time/time-appearance-pseudo-classes-expected.txt: Removed.
  • fast/forms/time/time-appearance-pseudo-classes.html: Removed.
  • fast/forms/time/time-pseudo-classes-expected.txt: Added.
  • fast/forms/time/time-pseudo-classes.html: Added.
  • fast/forms/week/week-appearance-pseudo-classes-expected.txt: Removed.
  • fast/forms/week/week-appearance-pseudo-classes.html: Removed.
  • fast/forms/week/week-pseudo-classes-expected.txt: Added.
  • fast/forms/week/week-pseudo-classes.html: Added.
  • platform/chromium-linux/fast/forms/month/month-appearance-pseudo-classes-expected.png: Removed.
  • platform/chromium-linux/fast/forms/time/time-appearance-pseudo-classes-expected.png: Removed.
  • platform/chromium-linux/fast/forms/week/week-appearance-pseudo-classes-expected.png: Removed.
  • platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-classes-expected.png: Removed.
  • platform/chromium-mac-lion/fast/forms/time/time-appearance-pseudo-classes-expected.png: Removed.
  • platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-classes-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-classes-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-pseudo-classes-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-classes-expected.png: Removed.
  • platform/chromium-mac/fast/forms/month/month-appearance-pseudo-classes-expected.png: Removed.
  • platform/chromium-mac/fast/forms/time/time-appearance-pseudo-classes-expected.png: Removed.
  • platform/chromium-mac/fast/forms/week/week-appearance-pseudo-classes-expected.png: Removed.
  • platform/chromium-win/fast/forms/month/month-appearance-pseudo-classes-expected.png: Removed.
  • platform/chromium-win/fast/forms/time/time-appearance-pseudo-classes-expected.png: Removed.
  • platform/chromium-win/fast/forms/week/week-appearance-pseudo-classes-expected.png: Removed.
12:40 AM Changeset in webkit [136109] by apavlov@chromium.org
  • 2 edits
    3 deletes in trunk/LayoutTests

[Chromium] Unreviewed, mark fast/regions tests failing after r136045 as failing, since they are actually reftests.

  • platform/chromium-mac/fast/regions/autoheight-dynamic-update-expected.png: Removed.
  • platform/chromium-mac/fast/regions/firstletter-inside-flowthread-expected.png: Removed.
  • platform/chromium-mac/fast/regions/listmarker-inside-flowthread-expected.png: Removed.
  • platform/chromium/TestExpectations:
12:38 AM Changeset in webkit [136108] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Broken rendering occurs when scrolling in ewk_view_single.
https://bugs.webkit.org/show_bug.cgi?id=77325

Reviewed by Gyuyoung Kim.

After r104687, broken rendering occurs when scrolling contents.
It's because scrollWidth can be smaller than width of image buffer.

This patch fixes it and renames parameter to avoid confusion.

  • ewk/ewk_view_single.cpp:

(_ewk_view_screen_move):
(_ewk_view_single_scroll_process_single):

12:35 AM Changeset in webkit [136107] by commit-queue@webkit.org
  • 7 edits
    6 adds in trunk

[CSS Regions] Fix content node renderers ordering inside the named flow thread
https://bugs.webkit.org/show_bug.cgi?id=103501

Patch by Andrei Bucur <abucur@adobe.com> on 2012-11-29
Reviewed by David Hyatt.

Source/WebCore:

This patch fixes two issues with how content nodes renderers are added to a named flow thread.
The first issue was about determining the insertion position of a renderer inside the children list of a named flow thread. Before this patch, the
insertion point was based on both the DOM ordering of the elements and insertion order of previous renderers.
The patch fixes this and makes the renderer position just a function of the DOM ordering of elements.
The second issue appeared when next/previousRenderer methods were skipping nodes because they had the flow-into property as a side effect
of copying the style of the parent element (e.g. Text nodes). The patch ensures the skipped nodes are also elements.

Tests: fast/regions/named-flow-content-order-1.html

fast/regions/named-flow-content-order-2.html
fast/regions/named-flow-content-order-3.html

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::nextRenderer): Skip only elements.
(WebCore::NodeRenderingContext::previousRenderer): Skip only elements.

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::addFlowChild): Insert the renderer in the list based on the DOM position of the owner element.

  • rendering/RenderNamedFlowThread.h:

(RenderNamedFlowThread):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::renderNamedFlowThreadWrapper): Rename to eliminate the confusion with enclosingRenderFlowThread.
(WebCore::RenderObject::insertedIntoTree):
(WebCore::RenderObject::willBeRemovedFromTree):

  • rendering/RenderObject.h:

(RenderObject):

LayoutTests:

The first two ref tests cover the issue with incorrectly computing the insertion position for a content node renderer.
The third ref test covers the issue with nextRenderer and previousRenderer skipping valid nodes.

  • fast/regions/named-flow-content-order-1-expected.html: Added.
  • fast/regions/named-flow-content-order-1.html: Added.
  • fast/regions/named-flow-content-order-2-expected.html: Added.
  • fast/regions/named-flow-content-order-2.html: Added.
  • fast/regions/named-flow-content-order-3-expected.html: Added.
  • fast/regions/named-flow-content-order-3.html: Added.
12:03 AM WebInspector edited by zandobersek@gmail.com
Removing spam links. (diff)
12:03 AM Changeset in webkit [136106] by eric@webkit.org
  • 3 edits in trunk/Tools

run-perf-tests does not work when the layout test directory does not exist
https://bugs.webkit.org/show_bug.cgi?id=103572

Reviewed by Ryosuke Niwa.

Make sure that Profiler() calls maybe_make_directory for the output_dir
before ever using it. It's a little awkward to create the directory
from the constructor, but its simplest that way as the various subclasses
all use the directory at different times.

Since this required having a filesystem in Profiler (and I didn't want
to grab inside Workspace to get one), I just made Profiler expect a
SystemHost instead of a separate filesystem, executive and workspace.

  • Scripts/webkitpy/common/system/profiler.py:

(ProfilerFactory.create_profiler):
(Profiler.init):
(SingleFileOutputProfiler.init):
(GooglePProf.init):
(GooglePProf.profile_after_exit):
(Instruments.init):
(Instruments.attach_to_pid):

  • Scripts/webkitpy/common/system/profiler_unittest.py:

(ProfilerFactoryTest.test_basic):

Note: See TracTimeline for information about the timeline view.