Timeline



Dec 10, 2012:

11:49 PM Changeset in webkit [137259] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=84432

fast/filesystem/op-restricted-names.html
fast/filesystem/op-restricted-unicode.html
fast/filesystem/read-directory.html
fast/filesystem/simple-readonly-file-object.html

Patch by Noel Gordon <noel.gordon@gmail.com> on 2012-12-10

  • platform/chromium/TestExpectations: These have been passing on WIN for over a month.
11:46 PM Changeset in webkit [137258] by danakj@chromium.org
  • 1 edit
    2 deletes in trunk/Source/Platform

[chromium] Remove WebCompositorFrame(Ack) as these classes are not needed now that they are passed through cc::OutputSurface.
https://bugs.webkit.org/show_bug.cgi?id=104635

Reviewed by James Robinson.

These have been supplanted by cc::CompositorFrame(Ack) which do not
need to inherit from them.

  • chromium/public/WebCompositorFrame.h: Removed.
  • chromium/public/WebCompositorFrameAck.h: Removed.
11:46 PM Changeset in webkit [137257] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=84432

fast/filesystem/op-restricted-names.html
fast/filesystem/op-restricted-unicode.html
fast/filesystem/read-directory.html
fast/filesystem/simple-readonly-file-object.html

  • platform/chromium/TestExpectations: These have been passing on WIN for over a month.
11:45 PM Changeset in webkit [137256] by danakj@chromium.org
  • 12 edits
    7 deletes in trunk

[chromium] Remove WebCompositorOutputSurface implementations from DRT
https://bugs.webkit.org/show_bug.cgi?id=104046

Reviewed by Darin Fisher.

Source/Platform:

Remove now-unused definitions for these classes. The cc::OutputSurface
and its related classes have replaced these, with the
WebCompositorOutputSurface class as an empty base class.

  • Platform.gypi:
  • chromium/public/WebCompositorOutputSurface.h:

(WebKit):

  • chromium/public/WebCompositorOutputSurfaceClient.h: Removed.
  • chromium/public/WebCompositorSoftwareOutputDevice.h: Removed.

Source/WebKit/chromium:

Use WebCompositorSupport to create an OutputSurface.

  • WebKit.gypi:
  • src/WebViewImpl.cpp:

(WebKit):

  • tests/Canvas2DLayerBridgeTest.cpp:
  • tests/FakeWebCompositorOutputSurface.h: Removed.
  • tests/WebLayerTreeViewTestCommon.h:

Tools:

The classes are now provided through WebCompositorSupport.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createOutputSurface):

  • DumpRenderTree/chromium/WebViewHostOutputSurface.cpp: Removed.
  • DumpRenderTree/chromium/WebViewHostOutputSurface.h: Removed.
  • DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.cpp: Removed.
  • DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.h: Removed.
11:33 PM Changeset in webkit [137255] by ap@apple.com
  • 5 edits in trunk/Source/WebKit2

[WK2] Add a user default to limit the number of web processes
https://bugs.webkit.org/show_bug.cgi?id=104606

Reviewed by Sam Weinig.

When the limit is reached, we'll reuse an existing process with fewest pages.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Initialize m_webProcessCountLimit.
(WebKit::WebContext::platformInitialize): Added a hook for reading the preference,
empty implementation on most platforms.
(WebKit::WebContext::createNewWebProcess): Changed to return a raw pointer. The new
process is put into a vector anyway, so there is no ownership transfer.
(WebKit::WebContext::warmInitialProcess): Don't create a new process if that would
exceed the limit.
(WebKit::WebContext::createNewWebProcessRespectingProcessCountLimit): Added a new
function that wither creates a new process, or picks an existing one.
(WebKit::WebContext::createWebPage): Call the above new function instead of
unconditionally creating a process.

  • UIProcess/WebContext.h: createNewWebProcess is no private. All clients should

respect the process count limit.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::reattachToWebProcess):

Respect the process count limit.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::registerUserDefaultsIfNeeded): Register the new default.
(WebKit::WebContext::platformInitialize): Read the default into a WebContext
member variable.
(WebKit::WebContext::platformInitializeWebProcess): Moved registerUserDefaultsIfNeeded()
from here to platformInitialize(), as that's a better place for it. Also added a
FIXME for an unrelated issue.

11:31 PM Changeset in webkit [137254] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline fast/js/global-constructors.html after r137243.

  • platform/efl/fast/js/global-constructors-expected.txt:
11:20 PM Changeset in webkit [137253] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening

Mark platform/chromium/virtual/deferred/fast/images/pdf-as-image-landscape.html WontFix.

  • platform/chromium/TestExpectations:
11:02 PM Changeset in webkit [137252] by noel.gordon@gmail.com
  • 2 edits
    1 add in trunk/LayoutTests

[chromium] Unreviewed gardening: rebase fast/repaint/body-background-image.html on linux

  • platform/chromium/TestExpectations:
10:57 PM Changeset in webkit [137251] by noel.gordon@gmail.com
  • 2 edits
    1 add in trunk/LayoutTests

[chromium] Unreviewed gardening: rebase fast/text/font-initial.html on linux

  • platform/chromium-linux/fast/text/font-initial-expected.png: Added.
  • platform/chromium/TestExpectations:
10:44 PM Changeset in webkit [137250] by commit-queue@webkit.org
  • 4 edits
    2 copies
    1 add in trunk

REGRESSION (r137006): CSS clip on solid color composited div broken
https://bugs.webkit.org/show_bug.cgi?id=104604

Patch by No'am Rosenthal <Noam Rosenthal> on 2012-12-10
Reviewed by Simon Fraser.

Source/WebCore:

Disable direct compositing of background color for clipping layers.

Test: compositing/geometry/clip-inside.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::supportsDirectBoxDecorationsComposition):

Never allow direct background composition if there is a clip.

LayoutTests:

Added a new test (by Simon Fraser) to make sure background color doesn't break clipping.

  • compositing/geometry/clip-inside-expected.txt: Added.
  • compositing/geometry/clip-inside.html: Added.
  • compositing/geometry/clip-expected:

New result.

  • platform/chromium/compositing/geometry/clip-inside-expected.txt

Adjust Chromium expected result for new test.

10:07 PM Changeset in webkit [137249] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening after http://trac.webkit.org/changeset/137243

  • platform/chromium/TestExpectations: Remove animations test.
9:54 PM Changeset in webkit [137248] by Simon Fraser
  • 4 edits
    2 adds in trunk

Source/WebCore: REGRESSION (r137215): WebKit stretches and shrinks a part of screen on scroll
https://bugs.webkit.org/show_bug.cgi?id=104626

Reviewed by Beth Dakin.

r137215 removed a compositing layer repaint on size changes. However, there
are cases where the compositing code constrains layer size by clipping
with the viewport and a clipping ancestor. When that happens, we must
invalidate the layer on a size change to avoid showing stretched or
shrunken content.

Test: compositing/repaint/clipped-layer-size-change.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

LayoutTests: REGRESSION(r137215): WebKit stretches and shrinks a part of screen on scroll
https://bugs.webkit.org/show_bug.cgi?id=104626

Reviewed by Beth Dakin.

Testcase that scrolls an overflow area containing a compositing layer.

  • compositing/repaint/clipped-layer-size-change-expected.html: Added.
  • compositing/repaint/clipped-layer-size-change.html: Added.
9:22 PM Changeset in webkit [137247] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Don't OSR exit just because a string is a rope
https://bugs.webkit.org/show_bug.cgi?id=104621

Reviewed by Michael Saboff.

Slight SunSpider speed-up at around the 0.7% level. This patch does the obvious
thing of calling a slow path to resolve ropes rather than OSR exiting if the
string is a rope.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::getIndexedPropertyStorageMayTriggerGC):
(ArrayMode):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::putStructureStoreElimination):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

9:17 PM Changeset in webkit [137246] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/win

ASSERTION failed in Windows: css3/css3-modsel-33.html
https://bugs.webkit.org/show_bug.cgi?id=104472

Patch by Xueqing Huang <huangxueqing@baidu.com> on 2012-12-10
Reviewed by Tim Horton.

In WebFrameLoaderClient::dispatchDidLayout, milestones maybe
DidFirstLayout & DidFirstVisualNonEmptyLayout, we should
use seperate COMPtrs for the two cases rather than reuse one.

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidLayout):

8:44 PM Changeset in webkit [137245] by dino@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Change Tab's affiliation in ChangeLog on recent patch.

8:31 PM Changeset in webkit [137244] by noel.gordon@gmail.com
  • 4 edits
    1 move
    1 add in trunk/LayoutTests

[chromium] fast/dom/HTMLMeterElement/meter-boundary-values.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=104625

Unreviewed HTMLMeterElement/meter-boundary-values.html rebaselines.

  • platform/chromium-mac-lion/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
  • platform/efl-wk1/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Renamed from LayoutTests/platform/efl/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png.
8:23 PM Changeset in webkit [137243] by dino@apple.com
  • 24 edits
    10 deletes in trunk

Remove old WebKit Animation API code
https://bugs.webkit.org/show_bug.cgi?id=104611

Reviewed by Simon Fraser.

Remove the existing, unused animation API code. We'll look into
implementing the W3C Animation API if/when it is stable.

Source/WebCore:

  • CMakeLists.txt: Remove WebKitAnimation and WebKitAnimationList classes.
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • UseJSC.cmake:
  • UseV8.cmake:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp: Remove includes.
  • bindings/js/JSWebKitAnimationCustom.cpp: Removed.
  • bindings/js/JSWebKitAnimationListCustom.cpp: Removed.
  • dom/Element.cpp: Remove API.
  • dom/Element.h: Ditto.
  • dom/Element.idl: Ditto.
  • page/DOMWindow.idl: Ditto.
  • page/WebKitAnimation.cpp: Removed.
  • page/WebKitAnimation.h: Removed.
  • page/WebKitAnimation.idl: Removed.
  • page/WebKitAnimationList.cpp: Removed.
  • page/WebKitAnimationList.h: Removed.
  • page/WebKitAnimationList.idl: Removed.
  • page/animation/AnimationController.cpp: Remove API.
  • page/animation/AnimationController.h: Ditto.
  • page/animation/AnimationControllerPrivate.h: Ditto.
  • page/animation/CompositeAnimation.cpp: Ditto.
  • page/animation/CompositeAnimation.h: Ditto.

LayoutTests:

  • animations/animation-api-1-expected.txt: Removed.
  • animations/animation-api-1.html: Removed.
  • fast/js/global-constructors-expected.txt:
7:53 PM Changeset in webkit [137242] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Re-enable a failing test. Disabling it just seemed to
move the problem to another test. Unreviewed.

  • tests/GraphicsLayerChromiumTest.cpp:
7:34 PM Changeset in webkit [137241] by jonlee@apple.com
  • 3 edits in trunk/Source/WebKit2

Build fix.

  • WebProcess/WebCoreSupport/WebPlugInClient.cpp:

(WebKit::WebPlugInClient::WebPlugInClient): Remove unneeded m_page variable.

  • WebProcess/WebCoreSupport/WebPlugInClient.h:

(WebPlugInClient):

7:10 PM Changeset in webkit [137240] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the Mac build after r137233

  • html/shadow/HTMLShadowElement.h:

Remove a declaration of a member variable that was moved to the InsertionPoint superclass.

6:37 PM Changeset in webkit [137239] by commit-queue@webkit.org
  • 5 edits
    3 copies
    3 adds
    1 delete in trunk/LayoutTests

[EFL] Rebaseline expected results for "visibility:hidden; position: absolute;" cases
https://bugs.webkit.org/show_bug.cgi?id=104620

Unreviewed, EFL gardening.

This is a following rebaseline of BUG 104195.
This patch sets AC ON as a default expected result of EFL.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-12-10

  • platform/efl-wk1/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Copied from LayoutTests/platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt.
  • platform/efl-wk1/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Copied from LayoutTests/platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt.
  • platform/efl-wk1/fast/block/basic/020-expected.txt: Copied from LayoutTests/platform/efl/fast/block/basic/020-expected.txt.
  • platform/efl-wk2/fast/block/basic/020-expected.txt: Removed.
  • platform/efl/TestExpectations:
  • platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
  • platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
  • platform/efl/fast/block/basic/020-expected.txt:
6:06 PM Changeset in webkit [137238] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Fix expectations lint errors in r137231
Unreviewed gardening.

  • platform/chromium/TestExpectations:
6:00 PM Changeset in webkit [137237] by dpranke@chromium.org
  • 5 edits in trunk/Tools

change --no-launch-safari to --no-show-results in scripts
https://bugs.webkit.org/show_bug.cgi?id=104298

Reviewed by Eric Seidel.

Since Safari only exists on the Apple ports, NRWT calls the
command line flag --[no-]show-results instead. This updates
the scripts to use the new flag (but not the buildbot config yet).

  • Scripts/generate-coverage-data:
  • Scripts/webkit-tools-completion.sh:
  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

  • Scripts/webkitpy/tool/steps/runtests_unittest.py:
5:59 PM Changeset in webkit [137236] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix after r137221
https://bugs.webkit.org/show_bug.cgi?id=104617

Unreviewed build fix

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-12-10

  • html/HTMLPropertiesCollection.cpp:

(WebCore::nextNodeWithProperty):

5:54 PM Changeset in webkit [137235] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Rewrite last occurrences of "Image" in TestExpectations to "ImageOnlyFailure".
Unreviewed test expectations update.

  • platform/chromium/TestExpectations:
5:48 PM Changeset in webkit [137234] by dpranke@chromium.org
  • 3 edits in trunk/Tools

nrwt: fix mapping of AUDIO onto FAIL when printing unexpected results
https://bugs.webkit.org/show_bug.cgi?id=104597

Reviewed by Ojan Vafai.

This was broken in the recent printer refactoring.

  • Scripts/webkitpy/layout_tests/views/buildbot_results.py:

(BuildBotPrinter.print_unexpected_results.add_result.is_expected):

  • Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:

(BuildBotPrinterTests.get_result):
(BuildBotPrinterTests.test_print_unexpected_results):
(BuildBotPrinterTests.test_print_unexpected_results.get_unexpected_results):
(BuildBotPrinterTests):

5:42 PM Changeset in webkit [137233] by morrita@google.com
  • 11 edits in trunk/Source/WebCore

[Shadow DOM][Refactoring] HTMLContentElement,HTMLShadowElement::m_registeredWithShadowRoot should be moved to InsertionPoint
https://bugs.webkit.org/show_bug.cgi?id=104516

Reviewed by Dimitri Glazkov.

This change pulls duplicated code in removedFrom() and
insertedInto() of both both HTMLShadowElement and
HTMLContentElement to their super class InsertionPoint.

This is a part of effor that encapsulate node distribution algorithm to
ContentDistributor and its family.

No new tests, no behavior change.

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::registerInsertionPoint): Added.
(WebCore::ShadowRoot::unregisterInsertionPoint): Added.

  • dom/ShadowRoot.h:

(ShadowRoot):

  • html/shadow/ContentDistributor.cpp:

(WebCore::ShadowRootContentDistributionData::regiterInsertionPoint): Generalized two methods for <content> and <shadow>.
(WebCore):
(WebCore::ShadowRootContentDistributionData::unregisterInsertionPoint): Ditto.

  • html/shadow/ContentDistributor.h:

(ShadowRootContentDistributionData):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::HTMLContentElement):

  • html/shadow/HTMLContentElement.h:
  • html/shadow/HTMLShadowElement.cpp:

(WebCore::HTMLShadowElement::HTMLShadowElement):

  • html/shadow/HTMLShadowElement.h:
  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::insertedInto): Pulled up from subclasses
(WebCore::InsertionPoint::removedFrom): Pulled up from subclasses

  • html/shadow/InsertionPoint.h:

(InsertionPoint):

5:40 PM Changeset in webkit [137232] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Expand flakiness of move-by-line-001.html.
Unreviewed gardening.

  • platform/chromium/TestExpectations:
5:35 PM Changeset in webkit [137231] by acolwell@chromium.org
  • 2 edits in trunk/LayoutTests

Temporarily disable video-media-source-seek.html & video-media-source-state-changes.html
https://bugs.webkit.org/show_bug.cgi?id=104584

Reviewed by Dirk Pranke.

Changes in Chromium needed for Bug 104581 and Bug 104583 will break these tests so they are
being temporarily disabled until the Chromium & WebKit changes are both landed.

  • platform/chromium/TestExpectations:
5:33 PM Changeset in webkit [137230] by jonlee@apple.com
  • 25 edits
    5 adds in trunk/Source

Keep track of plug-in snapshots clicked by user
https://bugs.webkit.org/show_bug.cgi?id=103206
<rdar://problem/12746483>

Reviewed by Anders Carlsson.

Source/WebCore:

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Initially the hash is
unknown. Set to 0. Move the check for whether to snapshot the plugin into the
new function subframeLoaderWillLoadPlugIn.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Rename
setPendingClickEvent to userDidClickSnapshot. In addition to holding onto the
click event used to activate the plug-in, the function now also tells the plug-in
client to add the origin hash as an auto-start origin.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillLoadPlugIn): Calculate the
hash based on the provided URL, which is the URL the plug-in will load. Extend
the check that used to be in the constructor to see if the plug-in should not
automatically load, including checking the plug-in size and whether the hash
is an auto-start origin.

  • html/HTMLPlugInImageElement.h: Rename setPendingClickEvent to userDidClickSnapshot

and add a variable for the origin hash.

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestPlugin): When the loader is about to load the
plug-in, pass the URL to the element, so that it can calculate the hash.

  • page/Page.cpp:

(WebCore::Page::Page): Take the plugInClient from the page clients.
(WebCore::Page::~Page): If the client exists, tell it that the page is being
destroyed.
(WebCore::Page::PageClients::PageClients): Initialize this optional client to
null.

  • page/Page.h: Add PlugInClient to page clients.

(PageClients): Add PlugInClient variable.
(WebCore::Page::plugInClient):

  • page/PlugInClient.h: Added.
  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::handleEvent): Call the renamed function
userDidClickSnapshot().
(WebCore::RenderSnapshottedPlugIn::layout): Move the check of the plug-in size
to subframeLoaderWillLoadPlugIn.

Add PlugInClient.h.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

Create a new provider class for the web context that maintains a mapping of the plug-in origins
allowed to auto-start for a specific page origin.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Create and set WebPlugInClient.

Implement WebCore::PlugInClient.

  • WebProcess/WebCoreSupport/WebPlugInClient.cpp: Added.

(WebKit::WebPlugInClient::WebPlugInClient):
(WebKit::WebPlugInClient::~WebPlugInClient):
(WebKit::WebPlugInClient::pageDestroyed):
(WebKit::WebPlugInClient::isAutoStartOrigin): Forward to WebProcess.
(WebKit::WebPlugInClient::addAutoStartOrigin): Forward to WebProcess.

  • WebProcess/WebCoreSupport/WebPlugInClient.h: Added.
  • WebProcess/WebProcess.cpp: Maintains a copy of the hash set.

(WebKit::WebProcess::isPlugInAutoStartOrigin): Look for the hash in the set.
(WebKit::WebProcess::addPlugInAutoStartOrigin): Tell the UI process to add the hash for the page.
(WebKit::WebProcess::didAddPlugInAutoStartOrigin): Add the hash to the cached set.

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in: Add DidAddPlugInAutoStartOrigin.

Add the auto-start provider.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Initialize the provider.
(WebKit::WebContext::addPlugInAutoStartOriginHash): Forward to the provider.

  • UIProcess/WebContext.h:
  • UIProcess/WebContext.messages.in: Add AddPlugInAutoStartOriginHash.

The provider class maintains a map of page domains to hashes, and a set of all the hashes.
The latter will be used to initialize new web processes without having to crawl through the
whole map.

  • UIProcess/Plugins/PlugInAutoStartProvider.cpp: Added.

(WebKit::PlugInAutoStartProvider::PlugInAutoStartProvider):
(WebKit::PlugInAutoStartProvider::addAutoStartOrigin): Add the origin to the map and set. Tell
all processes to add the origin to their local copies.

  • UIProcess/Plugins/PlugInAutoStartProvider.h: Added.

Add PlugInAutoStartProvider and WebPlugInClient.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
5:18 PM Changeset in webkit [137229] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add WKPageSetInvalidMessageFunction stub
https://bugs.webkit.org/show_bug.cgi?id=104614
<rdar://problem/12841671>

Reviewed by Mark Rowe.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetInvalidMessageFunction):

  • UIProcess/API/C/WKPagePrivate.h:
5:13 PM Changeset in webkit [137228] by dpranke@chromium.org
  • 2 edits in trunk/Tools

old-run-webkit-tests: add --show-results properly
https://bugs.webkit.org/show_bug.cgi?id=104608

Reviewed by Eric Seidel.

Rework r137219 / bug 104601 to use the correct perl idiom.

  • Scripts/old-run-webkit-tests:
5:03 PM Changeset in webkit [137227] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Not reviewed.

Build fix.

  • html/HTMLPropertiesCollection.cpp:

(WebCore::nextNodeWithProperty):

  • page/TouchDisambiguation.cpp:

(WebCore::boundingBoxForEventNodes):

5:02 PM Changeset in webkit [137226] by acolwell@chromium.org
  • 2 edits in trunk/Tools

Unreviewed. Adding Aaron Colwell to the contributor list.

  • Scripts/webkitpy/common/config/committers.py:
4:43 PM Changeset in webkit [137225] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Mark an encrypted media test as failing after http://crrev.com/172175
Unreviewed gardening.

  • platform/chromium/TestExpectations:
4:40 PM WebKitGTK/1.10.x edited by kalevlember@gmail.com
Added r135761 as proposed merge (diff)
4:32 PM Changeset in webkit [137224] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=104602
DidHitRelevantRepaintedObjectsAreaThreshold LayoutMilestone fires too
early on some pages with iframes

Reviewed by Simon Fraser.

This change makes it so that any RenderObjects inside iframes are not
considered relevant.

  • page/Page.cpp:

(WebCore::Page::addRelevantRepaintedObject):

4:21 PM Changeset in webkit [137223] by dgrogan@chromium.org
  • 6 edits in trunk/Source

IndexedDB: Propagate more leveldb errors to script
https://bugs.webkit.org/show_bug.cgi?id=104422

Reviewed by Tony Chang.

Source/WebCore:

These are the last places that ignore leveldb errors that can get the
usual ok/found treatment.

Nothing called getBool, so it is deleted.

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore):
(WebCore::getInt):
(WebCore::isSchemaKnown):
(WebCore::setUpMetadata):
(WebCore::getMaxObjectStoreId):
(WebCore::IDBBackingStore::open):
(WebCore::IDBBackingStore::getIDBDatabaseMetaData):
(WebCore::getNewDatabaseId):
(WebCore::IDBBackingStore::createIDBDatabaseMetaData):
(WebCore::setMaxObjectStoreId):
(WebCore::getNewVersionNumber):
(WebCore::IDBBackingStore::putRecord):
(WebCore::setMaxIndexId):

  • Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreStorageOperation::perform):

Source/WebKit/chromium:

  • tests/IDBFakeBackingStore.h: Delete method override that doesn't match new signature.
4:17 PM Changeset in webkit [137222] by andersca@apple.com
  • 2 edits
    9 deletes in trunk/Tools

Remove WebKit2 tests on Windows
https://bugs.webkit.org/show_bug.cgi?id=104607

Reviewed by Tim Horton.

Stop building WebKit2 tests and remove associated files.

  • TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Removed.
  • TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Removed.
  • TestWebKitAPI/win/PlatformWebViewWin.cpp: Removed.
  • TestWebKitAPI/win/TestWebKitAPI.sln: Removed.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
  • TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Removed.
  • TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Removed.
  • TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Removed.
  • TestWebKitAPI/win/WindowMessageObserver.h: Removed.
  • TestWebKitAPI/win/copy-resources.cmd: Removed.
4:13 PM Changeset in webkit [137221] by Antti Koivisto
  • 79 edits
    2 adds in trunk/Source

Factor node traversal into standalone functions
https://bugs.webkit.org/show_bug.cgi?id=104507

Source/WebCore:

Reviewed by Eric Seidel.

Node traversal functions are currently Node and ContainerNode members. Their implementations
are confusingly scattered over multiple header and source files. These functions have no particular
reason to be members as they don't require non-public access. They should be made freestanding
function instead and gathered together.

This patch adds NodeTraversal namespace, defined in NodeTraversal.h. It contains freestanding
functions for traversing Nodes. Most popular functions are inlined (as before) and
there are ContainerNode specific specializations (as before).

In client code

node = node->traverseNextNode();
node = node->traverseNextSibling();


becomes

node = NodeTraversal::next(node);
node = NodeTraversal::nextSkippingChildren(node);


etc.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::accessibilityDescriptionForElements):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::firstAccessibleObjectFromNode):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::addImageMapChildren):

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::toJS):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::allVisitedStateChanged):
(WebCore::SelectorChecker::visitedStateChanged):

  • css/StyleInvalidationAnalysis.cpp:

(WebCore::StyleInvalidationAnalysis::invalidateStyle):

  • dom/ContainerNode.cpp:

(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):

  • dom/ContainerNode.h:

(ContainerNode):
(WebCore):

  • dom/ContainerNodeAlgorithms.h:

(WebCore::ChildFrameDisconnector::collectDescendant):

  • dom/Document.cpp:

(WebCore::Document::buildAccessKeyMap):
(WebCore::Document::removeAllEventListeners):
(WebCore::Document::updateBaseURL):
(WebCore::Document::processBaseElement):
(WebCore::Document::nodeAbsIndex):
(WebCore::Document::nodeWithAbsIndex):
(WebCore::Document::getFocusableNodes):

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::markersInRange):
(WebCore::DocumentMarkerController::setMarkersActive):
(WebCore::DocumentMarkerController::hasMarkers):
(WebCore::DocumentMarkerController::clearDescriptionOnMarkersIntersectingRange):

  • dom/DocumentOrderedMap.cpp:

(WebCore::DocumentOrderedMap::get):

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::collectSelectFeatureSetFrom):

  • dom/Node.cpp:

(WebCore::Node::normalize):
(WebCore::Node::lazyAttach):
(WebCore):
(WebCore::Node::detach):
(WebCore::traverseTreeAndMark):

  • dom/Node.h:

(Node):

  • dom/NodeIterator.cpp:

(WebCore::NodeIterator::NodePointer::moveToNext):
(WebCore::NodeIterator::NodePointer::moveToPrevious):
(WebCore::NodeIterator::updateForNodeRemoval):

  • dom/NodeTraversal.h: Added.

(WebCore):
(NodeTraversal):
(WebCore::NodeTraversal::traverseNextNodeTemplate):
(WebCore::NodeTraversal::next):
(WebCore::NodeTraversal::traverseNextSiblingTemplate):
(WebCore::NodeTraversal::nextSibling):

  • dom/Range.cpp:

(WebCore::Range::toString):
(WebCore::Range::checkDeleteExtract):
(WebCore::Range::firstNode):
(WebCore::Range::pastLastNode):
(WebCore::Range::textRects):
(WebCore::Range::textQuads):
(WebCore::Range::getBorderAndTextQuads):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::labelElementForId):
(WebCore::TreeScope::findAnchor):

  • dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):

  • dom/TreeWalker.cpp:

(WebCore::TreeWalker::nextNode):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle):
(WebCore::containsNonEditableRegion):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
(WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle):
(WebCore::ApplyStyleCommand::removeInlineStyle):

  • editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::deleteInsignificantText):
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::firstEditablePositionInNode):
(WebCore::DeleteSelectionCommand::makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss):
(WebCore::DeleteSelectionCommand::handleGeneralDelete):

  • editing/EditCommand.cpp:

(WebCore::SimpleEditCommand::addNodeAndDescendants):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::triStateOfStyle):
(WebCore::EditingStyle::textDirectionForSelection):

  • editing/Editor.cpp:

(WebCore::Editor::simplifyMarkup):

  • editing/FrameSelection.cpp:

(WebCore::scanForForm):
(WebCore::FrameSelection::setSelectionFromNone):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::removeUnrenderedNodes):
(WebCore::ReplacementFragment::removeInterchangeNodes):
(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNodePreservingChildren):
(WebCore::ReplaceSelectionCommand::InsertedNodes::willRemoveNode):
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::removeHeadContents):
(WebCore::ReplaceSelectionCommand::handleStyleSpans):

  • editing/ReplaceSelectionCommand.h:

(WebCore::ReplaceSelectionCommand::InsertedNodes::pastLastLeaf):

  • editing/SimplifyMarkupCommand.cpp:

(WebCore::SimplifyMarkupCommand::doApply):

  • editing/TextIterator.cpp:

(WebCore::TextIterator::advance):
(WebCore::shouldEmitNewlineAfterNode):

  • editing/htmlediting.cpp:

(WebCore::hasARenderedDescendant):

  • editing/mac/EditorMac.mm:

(WebCore::Editor::fontForSelection):

  • editing/markup.cpp:

(WebCore::completeURLs):
(WebCore::StyledMarkupAccumulator::traverseNodesForSerialization):
(WebCore::findNodesSurroundingContext):
(WebCore::trimFragment):

  • editing/visible_units.cpp:

(WebCore::startOfParagraph):
(WebCore::endOfParagraph):

  • html/HTMLCollection.cpp:

(WebCore::nextNode):

  • html/HTMLElement.cpp:

(WebCore::setHasDirAutoFlagRecursively):
(WebCore::HTMLElement::directionality):
(WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):
(WebCore::HTMLElement::getItemRefElements):

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::invalidateDisabledStateUnder):
(WebCore::HTMLFieldSetElement::refreshElementsIfNeeded):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::formElementIndex):

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::control):

  • html/HTMLLegendElement.cpp:

(WebCore::HTMLLegendElement::associatedControl):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::mapMouseEvent):

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::virtualItemAfter):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::collectOptionInnerText):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::nextNodeWithProperty):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::recalcListItems):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::selection):
(WebCore::HTMLTextFormControlElement::innerTextValue):
(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks):

  • html/RadioInputType.cpp:

(WebCore::RadioInputType::handleKeydownEvent):

  • html/shadow/ContentDistributor.cpp:

(WebCore::ShadowRootContentDistributionData::ensureInsertionPointList):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::performSearch):

  • inspector/InspectorMemoryAgent.cpp:
  • page/FocusController.cpp:

(WebCore::FocusController::findFocusCandidateInContainer):

  • page/Frame.cpp:

(WebCore::Frame::searchForLabelsAboveCell):
(WebCore::Frame::searchForLabelsBeforeElement):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::getRanges):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::collectIntersectionOrEnclosureList):
(WebCore::SVGSVGElement::getElementById):

  • svg/SVGUseElement.cpp:

(WebCore::removeDisallowedElementsFromSubtree):

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateDocumentOrderIndexes):

  • xml/XPathNodeSet.cpp:

(WebCore::XPath::NodeSet::traversalSort):

  • xml/XPathStep.cpp:

(WebCore::XPath::Step::nodesInAxis):

  • xml/XPathUtil.cpp:

(WebCore::XPath::stringValue):

Source/WebKit/chromium:

Reviewed by Eric Seidel.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):

Source/WebKit/mac:

Reviewed by Eric Seidel.

  • WebView/WebHTMLRepresentation.mm:

(searchForLabelsBeforeElement):

Source/WebKit2:

Reviewed by Eric Seidel.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::containsAnyFormElements):

4:08 PM Changeset in webkit [137220] by commit-queue@webkit.org
  • 4 edits
    7 adds in trunk

Sending multi-touch events to the same Iframe
https://bugs.webkit.org/show_bug.cgi?id=97973

Patch by Min Qin <qinmin@chromium.org> on 2012-12-10
Reviewed by Dimitri Glazkov.

Source/WebCore:

Multi-Touch in different iframe can give both documents access to each other.
This could cause cross-origin access. To solve this, all the touch events should
be sent to the iframe where the first touchstart happens.

Test: fast/events/touch/multi-touch-inside-iframes.html

fast/events/touch/multi-touch-inside-nested-iframes.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleTouchEvent):

  • page/EventHandler.h:

LayoutTests:

Check that all multi-touch events are sent to the same iframe.

  • fast/events/touch/multi-touch-inside-iframes-expected.txt: Added.
  • fast/events/touch/multi-touch-inside-iframes.html: Added.
  • fast/events/touch/resources/multi-touch-inside-iframes2.html: Added.
  • fast/events/touch/multi-touch-inside-nested-iframes-expected.txt: Added.
  • fast/events/touch/multi-touch-inside-nested-iframes.html: Added.
  • fast/events/touch/resources/multi-touch-inside-nested-iframes2.html: Added.
  • fast/events/touch/resources/multi-touch-inside-nested-iframes3.html: Added.
3:56 PM Changeset in webkit [137219] by dpranke@chromium.org
  • 2 edits in trunk/Tools

old-run-webkit-tests: support --no-show-results for compatibility w/ NRWT
https://bugs.webkit.org/show_bug.cgi?id=104601

Reviewed by Eric Siedel.

This flag is being added so we can move all of the calling scripts
over to using --no-show-results instead of --no-launch-safari.

  • Scripts/old-run-webkit-tests:
3:55 PM Changeset in webkit [137218] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[soup] Fix build warning in ResourceHandleSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=104605

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-12-10
Reviewed by Martin Robinson.

The nextMultipartResponsePartCallback has unused parameter 'source',
comment out it to fix 'unused parameter' build warning.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::nextMultipartResponsePartCallback):

3:43 PM Changeset in webkit [137217] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix frame border painting in tiled drawing mode
https://bugs.webkit.org/show_bug.cgi?id=104453
<rdar://problem/11678611>

Reviewed by Dan Bernstein.

Frame borders were not correctly invalidated when in tiled drawing mode, because
RenderFrameSet::layout() invalidated directly on the view, which skips the tile
cache.

Fix by invalidating like all other renderers, via the repaint container.

Also, the layer transform should be updated before the invalidation, and
we make use of RenderObject::updateLayerTransform() which has the same behavior
as the old code.

Attempts to make a layout test failed. Resizing composited framesets repainted
via layer resizing, and an attempt to make a ref test in tiled drawing mode
failed (the test passed without the patch).

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::layout):

3:43 PM Changeset in webkit [137216] by Simon Fraser
  • 3 edits
    3 adds in trunk

When converting a layer into a tiled layer, ensure that we update the visible rect
https://bugs.webkit.org/show_bug.cgi?id=104467

Reviewed by Darin Adler.

Source/WebCore:

When a GraphicsLayerCA toggles to use a TileCache, we have to ensure that the
layer's visible rect (which is used to ensure tile coverage) is updated in
the same commit. Otherwise we can get blank layers until something else causes
the visible rect to be updated.

Test: compositing/tiling/tiled-layer-resize.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::dumpAdditionalProperties): With the debug flag, dump the TiledBacking
address for ease of debugging.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Set the VisibleRectChanged bit in
m_uncommittedChanges if we've just switched to a tiled layer.

LayoutTests:

Test that resizes a layer over the tiled layer threshold, then dumps layer data.

Mac-specific results added because only Mac dumps tile cache info.

  • compositing/tiling/tiled-layer-resize-expected.txt: Added.
  • compositing/tiling/tiled-layer-resize.html: Added.
  • platform/mac/compositing/tiling/tiled-layer-resize-expected.txt: Added.
3:43 PM Changeset in webkit [137215] by Simon Fraser
  • 3 edits
    2 adds in trunk

Don't unconditionally repaint compositing layers when their size changes
https://bugs.webkit.org/show_bug.cgi?id=104461

Reviewed by Sam Weinig.

Source/WebCore:

RenderLayerBacking always repainted the entire compositing layer when its size
changed. This was done to fix repaint issues when outline widths changes, but
that issue is now solved by repainting in GraphicsLayer::setOffsetFromRenderer(),
add in r134628. I believe this is no longer necessary.

Always repainting when the size changes is terrible for the tile cache when
loading large documents, as all tiles repaint every time the document gets
longer.

Test: compositing/repaint/resize-repaint.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

LayoutTests:

Test that dumps repaint rects after adding content to a compositing layer.

  • compositing/repaint/resize-repaint-expected.txt: Added.
  • compositing/repaint/resize-repaint.html: Added.
3:34 PM Changeset in webkit [137214] by ojan@chromium.org
  • 6 edits
    2 deletes in trunk

Unreviewed, rolling out r134150.
http://trac.webkit.org/changeset/134150
https://bugs.webkit.org/show_bug.cgi?id=99940

Caused JS-based tooltips to remain during scroll on Facebook
and Gmail. Rollout until I have time to experiment with less
aggresive approaches.

Source/WebCore:

  • page/EventHandler.cpp:

(WebCore):
(WebCore::MaximumDurationTracker::MaximumDurationTracker):
(WebCore::MaximumDurationTracker::~MaximumDurationTracker):
(MaximumDurationTracker):
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):

  • page/EventHandler.h:

(EventHandler):

  • platform/Timer.h:

LayoutTests:

  • fast/scrolling/fake-mouse-event-throttling-expected.txt: Removed.
  • fast/scrolling/fake-mouse-event-throttling.html: Removed.
  • platform/mac/TestExpectations:
3:30 PM Changeset in webkit [137213] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Keyboard caret movement in textarea with RTL Override Character can make tab unresponsive
https://bugs.webkit.org/show_bug.cgi?id=103067

Patch by Yi Shen <max.hong.shen@gmail.com> on 2012-12-10
Reviewed by Ryosuke Niwa.

Source/WebCore:

For textarea with RTL override character, the line break could be the previous leaf InlineTextBox of
the InlineTextBox for the RTL override text. When overshots the left/right, make sure the
leftVisuallyDistinctCandidate and rightVisuallyDistinctCandidate return the visually distinct
left/right position by ignoring the line break.

Test: editing/selection/move-by-character-crash-test-textarea.html

  • editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate):

LayoutTests:

New test for moving caret in textarea with RTL override character causes crash.

  • editing/selection/move-by-character-crash-test-textarea-expected.txt: Added.
  • editing/selection/move-by-character-crash-test-textarea.html: Added.
3:06 PM Changeset in webkit [137212] by adamk@chromium.org
  • 6 edits in branches/chromium/1312/Source

Merge 136785

Add runtime enable for web intents.
https://bugs.webkit.org/show_bug.cgi?id=103669

Patch by Greg Billock <gbillock@google.com> on 2012-12-05
Reviewed by Adam Barth.

Source/WebCore:

Make web intents Javascript API enabled by a runtime setting.

  • Modules/intents/DOMWindowIntents.idl:
  • Modules/intents/NavigatorIntents.idl:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::webkitStartActivityEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIntentEnabled):
(WebCore::RuntimeEnabledFeatures::webKitIntentEnabled):
(WebCore::RuntimeEnabledFeatures::setWebIntentsEnabled):

Source/WebKit/chromium:

Propagate runtime setting to enable/disable web intents Javascript API.

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableWebIntents):
(WebKit):
(WebKit::WebRuntimeFeatures::isWebIntentsEnabled):

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11519009

3:01 PM Changeset in webkit [137211] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

[EFL][WebGL] Minor Refactoring in GraphicsContext3DEfl.
https://bugs.webkit.org/show_bug.cgi?id=104553.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-10
Reviewed by Kenneth Rohde Christiansen.

We use different FBO for canvas and offscreen surface of our platform layer.
Thus we need to manage any bound buffers while copying contents to the surface. Currently, Surface
always uses double buffering but in future we should be able to configure it to use either
double or single buffer. For these use cases, it would be handy to bind buffers directly to
FBO used by the surface. This patch does the needed changes in GraphicsContext3DEfl and
PlatformSurface. Also, removes some unused code.

Covered by existing tests.

Relevant changes in GraphicsContext3DEfl to obtain FBO id from PlatformSurface.

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):

Renamed createGraphicsSurface to didResizeCanvas.
(WebCore::GraphicsContext3D::createGraphicsSurfaces):

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(GraphicsContext3DPrivate::didResizeCanvas):
(GraphicsContext3DPrivate::copyToGraphicsSurface):

  • platform/graphics/efl/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

Header cleanup.

  • platform/graphics/opengl/GLDefs.h:
  • platform/graphics/opengl/GLPlatformContext.cpp:

(WebCore::GLPlatformContext::createContext):

  • platform/graphics/opengl/GLPlatformContext.h:

Added initialize method to expose FBO id of the surface.
Removed unused code.

  • platform/graphics/opengl/GLPlatformSurface.cpp:

(WebCore::GLPlatformSurface::initialize):
(WebCore):
(WebCore::GLPlatformSurface::updateContents):

  • platform/graphics/opengl/GLPlatformSurface.h:

(GLPlatformSurface):

  • platform/graphics/surfaces/glx/GLXSurface.h:
2:57 PM Changeset in webkit [137210] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Flash content is being rendered as garbled characters when Flashplayer is disabled
https://bugs.webkit.org/show_bug.cgi?id=104505

Patch by Max Feil <mfeil@rim.com> on 2012-12-10
Reviewed by Antonio Gomes.

The check to allow video and audio as the source of embed and
object elements is causing a problem when the Flashplayer plugin
is disabled. We have to take Flash content into account in this
check otherwise the swf contents will be rendered as garbled
text characters where there should just be blank space.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::createPlugin):

2:53 PM Changeset in webkit [137209] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Tidy up the tiled scrolling indicator, fix with zooming
https://bugs.webkit.org/show_bug.cgi?id=104386

Reviewed by Tim Horton.

Fix the tiled scrolling indicator to not get tiny when zooming,
to not poke out of the bottom of the window, and to not look
so crappy.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::updateTileCoverageMap):
(WebCore::TileCache::drawTileMapContents):

2:42 PM Changeset in webkit [137208] by dpranke@chromium.org
  • 5 edits in trunk

nrwt: use the default logic for skipping platform-specific tests for chromium
https://bugs.webkit.org/show_bug.cgi?id=104403

Reviewed by Stephen White.

Tools:

I thought I had fixed this a while ago, but the chromium port was
using custom logic to figure out which platform/* tests to run (or
skip) and as a result we were getting some odd behavior (like running
tests in chromium-linux on chromium-mac, but only when there was
an expectation listed for the test).

Ports are supposed to only run the tests found under their
baseline_search_path() by default.

Not writing a test for this; theoretically there shouldn't been a
test checking that the behavior for Chromium was *different* than
the other ports before.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._missing_symbol_to_skipped_tests):

LayoutTests:

Remove a bunch of WONTFIX lines that will now be handled programmatically.

  • platform/chromium-android/TestExpectations:
  • platform/chromium/TestExpectations:
2:31 PM Changeset in webkit [137207] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r136817.
http://trac.webkit.org/changeset/136817
https://bugs.webkit.org/show_bug.cgi?id=104596

This patch was an unnecessarily complex solution to handling
conversion of union types. (Requested by mpruett on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-10

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSDictionary.h:

(WebCore::JSDictionary::tryGetPropertyAndResult):

2:15 PM Changeset in webkit [137206] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Deprecate prefixed linear-gradient and radial-gradient functions
https://bugs.webkit.org/show_bug.cgi?id=104591

Patch by Tab Atkins <jackalmage@gmail.com> on 2012-12-10
Reviewed by Dean Jackson.

Rename the old gradient parsing functions in anticipation of functions that parse the new syntax.

No new tests added - this is a rename and has no functionality change.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseDeprecatedLinearGradient):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::parseGeneratedImage):

  • css/CSSParser.h:
2:14 PM Changeset in webkit [137205] by dpranke@chromium.org
  • 2 edits in trunk/Tools

fix regression in test-webkitpy after r137189
https://bugs.webkit.org/show_bug.cgi?id=104589

Reviewed by Eric Seidel.

Need to specify full port names.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_build_check):

2:13 PM Changeset in webkit [137204] by dino@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed update to test results after http://trac.webkit.org/changeset/137200.
The 'widows' and 'orphans' properties have an initial value of 'auto'.

  • editing/pasteboard/onpaste-text-html-expected.txt:
  • fast/events/ondrop-text-html-expected.txt:
2:06 PM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org
(diff)
1:53 PM Changeset in webkit [137203] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Change the minimum required EFL version to 1.6
https://bugs.webkit.org/show_bug.cgi?id=104431

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-12-10
Reviewed by Kenneth Rohde Christiansen.

.:

Change the minimum required EFL version to 1.6 from 1.7 to enable
building on Tizen.

The elementary EFL package is only required to build MiniBrowser,
so I moved the required only to the Minibrowser CMake file.

  • Source/cmake/OptionsEfl.cmake:

Tools:

Change the minimum required EFL version to 1.6 from 1.7.
The elementary EFL package is only required to build MiniBrowser,
so I moved the required only to the Minibrowser CMake file.

  • MiniBrowser/efl/CMakeLists.txt: In addition removed

ENABLE_GLIB_SUPPORT as it is obsolete and it was always set to be on.

1:40 PM Changeset in webkit [137202] by dino@apple.com
  • 1 edit in trunk/Tools/ChangeLog

Updating date in Tools/ChangeLog

1:33 PM Changeset in webkit [137201] by pilgrim@chromium.org
  • 5 edits in trunk/Source

[Chromium][Win] Remove theme-related functions from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=102699

Reviewed by Adam Barth.

Call theme engine directly instead of going through
PlatformSupport. Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/chromium/ScrollbarThemeChromiumWin.cpp:

(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumWin::paintButton):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):
(WebCore::RenderThemeChromiumWin::paintButton):
(WebCore::RenderThemeChromiumWin::paintSliderTrack):
(WebCore::RenderThemeChromiumWin::paintSliderThumb):
(WebCore::RenderThemeChromiumWin::paintMenuList):
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
(WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
(WebCore::RenderThemeChromiumWin::paintProgressBar):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::pluginScriptableObject):

1:22 PM Changeset in webkit [137200] by dino@apple.com
  • 18 edits
    2 adds in trunk

Support for CSS widows and orphans
https://bugs.webkit.org/show_bug.cgi?id=9410

Reviewed by Darin Adler.

Source/WebCore:

The CSS 'widow' and 'orphan' properties were supported by the parser and
style system, but were not actually doing anything in layout. Now they do!

In order to not break existing content, I unfortunately had to go against
the specification and change our default value from 2 to auto. A value of
auto means that widows and orphans will not cause any page/column breaks.

Supporting orphans was a small change. During line layout, if we realise
we need to move to a new page in a situation that would create an orphan,
move the entire block to the new page. There was already code to do this.

Support for widows was trickier. When we finish laying out a block, count
the number of hanging lines. If we've created a widow, and there are enough
available lines on the previous page, then steal some and remember the line
to break at. Trigger a relayout. Then notice the line that was marked for
breaking and avoid the widow. This means some blocks go through layout
twice, but as long as the widow value is small it shouldn't be a huge penalty.

Tests: fast/multicol/widows-and-orphans.html (new test)

printing/page-break-orphans.html
printing/page-break-orphans-and-widows.html
printing/page-break-widows.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return CSSValueAuto for widows and orphans if necessary.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Support "auto" in widow and orphan property parsing.

  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder): Change property handler to something that supports auto.

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimation::ensurePropertyMap): Add widows and orphans to the animation map.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlockChild): Detect if we've caused a widow-fixing break, and request relayout evaluation.
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded): Test for a widow-fixing line.
(WebCore::RenderBlock::setBreakAtLineToAvoidWidow): New function to remember where we should break on next layout.
(WebCore::RenderBlock::adjustLinePositionForPagination): Move the entire block to a new page if this would create an orphan.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::shouldBreakAtLineToAvoidWidow): New function to indicate if we are remembering a widow.
(WebCore::RenderBlock::clearShouldBreakAtLineToAvoidWidow): Reset the line breaks.
(WebCore::RenderBlock::lineBreakToAvoidWidow):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData): Add a flag for indicating if we are remembering a line, and the actual line itself.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange): The code to detect and fix widows. Explained above.

  • rendering/style/RenderStyle.h: New methods for indicating if widows and orphans are non-default values.
  • rendering/style/StyleRareInheritedData.cpp: Ditto.
  • rendering/style/StyleRareInheritedData.h: Ditto.

LayoutTests:

A new, slightly more comprehensive, test for widows and orphans. We also
now pass the existing widows and orphans tests from printing. And
since the default value of the properties changed, update the
computed style test as well.

  • fast/css/getComputedStyle/computed-style-expected.txt: New auto value.
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: New auto value.
  • fast/multicol/widows-and-orphans-expected.txt: Added.
  • fast/multicol/widows-and-orphans.html: Added.
  • printing/page-break-orphans-and-widows-expected.txt:
  • printing/page-break-orphans-expected.txt:
  • printing/page-break-widows-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt: New auto value.
1:21 PM Changeset in webkit [137199] by dino@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Adding Antoine to the contributor list so his name autocompletes in bugzilla.

  • Scripts/webkitpy/common/config/committers.py:
1:07 PM Changeset in webkit [137198] by zandobersek@gmail.com
  • 4 edits in trunk

REGRESSION (r118735): svg/dom/complex-svgView-specification.html, svg/dom/SVGViewSpec.html, svg/dom/viewspec-parser.html failing on GTK Linux 64-bit Release
https://bugs.webkit.org/show_bug.cgi?id=87734

Reviewed by Martin Robinson.

Source/WebCore:

Don't modify ResourceRequest's URL to have the value of the (encoded)
URI of the SoupMessage. The only exception is in the case of cancelled
SoupMessage - the URL of the ResourceRequest should then be null.

No new tests - existing tests should show no regressions.

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateFromSoupMessage):

Tools:

When willSendRequest should return null in testing, cancel the SoupMessage
instead of setting the request's URI to about:blank.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(willSendRequestCallback):

12:21 PM Changeset in webkit [137197] by Lucas Forschler
  • 4 edits in tags/Safari-537.20.4/Source/WebCore

Merged r137178. <rdar://problem/12724571>

12:01 PM Changeset in webkit [137196] by Lucas Forschler
  • 4 edits in tags/Safari-537.20.4/Source

Versioning.

11:59 AM Changeset in webkit [137195] by Lucas Forschler
  • 1 copy in tags/Safari-537.20.4

New Tag.

11:56 AM Changeset in webkit [137194] by kov@webkit.org
  • 4 edits in trunk/Source

Unreviewed distcheck fix.

Source/JavaScriptCore:

  • GNUmakefile.list.am:

Source/WebCore:

  • GNUmakefile.list.am:
11:52 AM Changeset in webkit [137193] by jochen@chromium.org
  • 3 edits
    1 move
    1 add
    1 delete in trunk/Tools

[chromium] Move the test implementation of WebKit::WebPlugin to the TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=104537

Reviewed by Tony Chang.

In order to hide implementation details from the public TestRunner API,
I moved the plugin to WebTestPluginImpl and added a static create
method to WebTestPlugin. Also, I renamed the plugin from TestWebPlugin
to WebTestPlugin to be more in line with other classes in the
TestRunner API.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebTestPlugin.h: Added.

(WebTestRunner):
(WebTestPlugin):

  • DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestWebPlugin.cpp.

(WebTestRunner::WebTestPlugin::create):
(WebTestRunner):
(WebTestRunner::WebTestPlugin::WebTestPlugin):
(WebTestRunner::WebTestPlugin::~WebTestPlugin):
(WebTestRunner::WebTestPlugin::mimeType):

  • DumpRenderTree/chromium/TestWebPlugin.h: Removed.
  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createPlugin):

11:42 AM Changeset in webkit [137192] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

[GTK] Expose HitTestResult::scrollbar() condition in API
https://bugs.webkit.org/show_bug.cgi?id=104369

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2012-12-10
Reviewed by Carlos Garcia Campos.

This patch populates WebCore::HitTestResult::scrollbar() condition
in WebKitHitTestResult public API, and includes a corresponding unit
test.

  • Shared/WebHitTestResult.cpp: Adds new isScrollbar member to

encoding and decoding methods to carry the scrollbar condition
from Web process to UI process.
(WebKit::WebHitTestResult::Data::encode):
(WebKit::WebHitTestResult::Data::decode):

  • Shared/WebHitTestResult.h:

(Data): Adds new bool member isScrollbar.
(WebKit::WebHitTestResult::Data::Data): Initializes isScrollbar from
WebCore::HitTestResult::scrollbar().
(WebKit::WebHitTestResult::isScrollbar): Method that returns value
of isScrollbar member.
(WebHitTestResult):

  • UIProcess/API/gtk/WebKitHitTestResult.cpp:

(webkitHitTestResultCreate): Adds scrollbar condition to context upon
initialization.
(webkitHitTestResultCompare): Adds comparison of scrollbar condition.
(webkit_hit_test_result_context_is_scrollbar): Public accessor for
scrollbar presence in context.

  • UIProcess/API/gtk/WebKitHitTestResult.h: Adds new flag

WEBKIT_HIT_TEST_RESULT_CONTEXT_SCROLLBAR to
WebKitHitTestResultContext enum.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Adds new API symbol

to the corresponding documentation sections.

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewMouseTarget): Updates mouse-target
test to include assertions for hitting scrollbar condition, and
an new HTML to privide a positive case.

11:36 AM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org
(diff)
11:33 AM Changeset in webkit [137191] by Christophe Dumez
  • 102 edits in trunk/LayoutTests

[EFL] Massive rebaseline after r137146
https://bugs.webkit.org/show_bug.cgi?id=104576

Unreviewed EFL gardening.

Rebaseline several test cases after r137146.

  • platform/efl/fast/text/atsui-spacing-features-expected.png:
  • platform/efl/fast/text/atsui-spacing-features-expected.txt:
  • platform/efl/fast/text/complex-text-opacity-expected.png:
  • platform/efl/fast/text/complex-text-opacity-expected.txt:
  • platform/efl/fast/text/international/bidi-AN-after-empty-run-expected.png:
  • platform/efl/fast/text/international/bidi-AN-after-empty-run-expected.txt:
  • platform/efl/fast/text/international/bidi-CS-after-AN-expected.png:
  • platform/efl/fast/text/international/bidi-CS-after-AN-expected.txt:
  • platform/efl/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/efl/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/efl/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt:
  • platform/efl/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/efl/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
  • platform/efl/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/efl/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
  • platform/efl/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/efl/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt:
  • platform/efl/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/efl/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt:
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/efl/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-direction-ltr-expected.txt:
  • platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/efl/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
  • platform/efl/svg/text/bidi-text-query-expected.png:
  • platform/efl/svg/text/bidi-text-query-expected.txt:
  • platform/efl/svg/text/bidi-tspans-expected.png:
  • platform/efl/svg/text/bidi-tspans-expected.txt:
  • platform/efl/svg/text/text-intro-05-t-expected.png:
  • platform/efl/svg/text/text-intro-05-t-expected.txt:
11:31 AM Changeset in webkit [137190] by eric@webkit.org
  • 5 edits in trunk/Source/WebCore

Caused crashes in v8. Rolling out until abarth can fix. See cr-issue 165136 for more info
https://bugs.webkit.org/show_bug.cgi?id=104575

Unreviewed, just rolling out r136559.

  • bindings/v8/V8GCController.cpp:
  • bindings/v8/V8NodeFilterCondition.cpp:

(WebCore::V8NodeFilterCondition::V8NodeFilterCondition):
(WebCore::V8NodeFilterCondition::acceptNode):

  • bindings/v8/V8NodeFilterCondition.h:

(WebCore::V8NodeFilterCondition::create):
(V8NodeFilterCondition):

  • dom/NodeFilter.h:
11:29 AM Changeset in webkit [137189] by dpranke@chromium.org
  • 3 edits in trunk/Tools

run_webkit_tests throws exception when DRT is not present
https://bugs.webkit.org/show_bug.cgi?id=104565

Reviewed by Jochen Eisinger.

Don't actually try to print the bot results if there aren't
any because we exited before running any tests.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(main):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_build_check):

11:26 AM Changeset in webkit [137188] by benjamin@webkit.org
  • 7 edits
    1 add in trunk

Add convenience methods to use ListHashSet for a LRU cache
https://bugs.webkit.org/show_bug.cgi?id=104499

Reviewed by Sam Weinig.

Source/WTF:

ListHashSet is a great abstract data type to implement caches.
Unfortunately, the class was missing methods to do that easily and
efficiently. This patch fixes that.

The names appendOrMoveToLast() and prependOrMoveToFirst() were chosen
in favor of append()/prepend() to ensure they are not used in place of
add() by accident.

  • wtf/ListHashSet.h:

(ListHashSet):
(WTF::::removeFirst):
(WTF::::appendOrMoveToLast):
(WTF::::prependOrMoveToFirst):
(WTF::::unlink):
(WTF::::unlinkAndDelete):
(WTF::::prependNode):

Tools:

Test the new methods added to ListHashSet.

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/GNUmakefile.am:
  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/ListHashSet.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::TEST):

11:14 AM Changeset in webkit [137187] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r137167.

  • WebCore.xcodeproj/project.pbxproj: Add InbandTextTrackPrivate.h to framework private

headers.

11:09 AM Changeset in webkit [137186] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

Fix the GTK+ build after a collision of two patches.

Unreviewed build fix.

  • bindings/gobject/GNUmakefile.am: The GObject DOM bindings library needs to

include the harfbuzz cflags when compiling.

11:05 AM Changeset in webkit [137185] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Source/WebCore: Make hiddenPageDomTimerInterval a setting
https://bugs.webkit.org/show_bug.cgi?id=104555

Patch by Parth Patel <parpatel@rim.com> on 2012-12-10
Reviewed by Yong Li.

Make hiddenPageDomTimerInterval a setting so client can customize it.

No new tests are needed.

  • page/Page.cpp:

(WebCore):
(WebCore::Page::setVisibilityState):

  • page/Settings.cpp:

(WebCore):
(WebCore::Settings::setHiddenPageDOMTimerAlignmentInterval):
(WebCore::Settings::hiddenPageDOMTimerAlignmentInterval):

  • page/Settings.h:

(Settings):

Source/WebKit/blackberry: [BlackBerry] Make hiddenPageDomTimerInterval a setting
https://bugs.webkit.org/show_bug.cgi?id=104555

Patch by Parth Patel <parpatel@rim.com> on 2012-12-10
Reviewed by Yong Li.

HiddenPageDomTimerInterval in setting in webcore can be utilized by browser application
when needed.

  • Api/BlackBerryGlobal.cpp:

(BlackBerry::WebKit::globalInitialize):

11:04 AM Changeset in webkit [137184] by dpranke@chromium.org
  • 5 edits in trunk/Tools

webkit-patch print-expectations doesn't work right for platforms w/ shared expectations
https://bugs.webkit.org/show_bug.cgi?id=104405

Reviewed by Eric Seidel.

If multiple ports shared a TestExpectations file, webkit-patch
print-expectations would use the expectation for the first port
using that file and print the result for all ports, rather than
re-parse and print each port separately (e.g., we might print
the chromium-linux expectation for a file for both chromium-linux
and chromium-mac). Discovered while testing/debugging the fix
for bug 104403.

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestPort._skipped_tests_for_unsupported_features):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(lint):

  • Scripts/webkitpy/tool/commands/queries.py:

(PrintExpectations._model):

  • Scripts/webkitpy/tool/commands/queries_unittest.py:

(PrintExpectationsTest.test_platform):

10:58 AM Changeset in webkit [137183] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt: fix total number of tests computed in the result summary
https://bugs.webkit.org/show_bug.cgi?id=104061

Reviewed by Jochen Eisinger.

Good thing I left this open, because I actually broke it again
the same way in a merge. Fix the computation of the one_line_summary
again, and add tests for it (also clean up some redundant tests).

Also, add constants into the test port code so that the knowledge
of how many tests should fail and how is next to the list of tests,
rather than a totally different place.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner.run_tests):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestList.getitem):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(get_test_results):
(MainTest.setUp):
(MainTest.test_basic):
(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_test_list_with_prefix):
(MainTest.test_missing_and_unexpected_results_with_custom_exit_code.CustomExitCodePort):
(MainTest.test_tolerance.ImageDiffTestPort):
(EndToEndTest.parse_full_results):

10:47 AM Changeset in webkit [137182] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Compile fix in ImageCairoWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=104554

Patch by peavo@outlook.com <peavo@outlook.com> on 2012-12-10
Reviewed by Brent Fulgham.

  • platform/graphics/win/ImageCairoWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize): Added parameter.
(WebCore::BitmapImage::drawFrameMatchingSourceSize): Added parameter.

10:47 AM Changeset in webkit [137181] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed gardening.

Adding failure expectations for failing http tests that started
failing on EFL and GTK after the Jhbuild libsoup was bumped to 2.40.0.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
10:42 AM Changeset in webkit [137180] by mkwst@chromium.org
  • 17 edits in trunk

Log to console when script is blocked by sandbox attributes.
https://bugs.webkit.org/show_bug.cgi?id=104365

Reviewed by Ojan Vafai.

Source/WebCore:

Adds a console message to cover script execution blocked within the
context of a sandboxed frame which lacks the 'allow-scripts' permission.

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):

Log a warning when sandboxing flags block script execution.

Tools:

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest):

Ignoring the new console message in perftests, as it broke parsing
for the Parser/html-parser.html microbenchmark.

LayoutTests:

  • fast/frames/sandboxed-iframe-attribute-parsing-expected.txt:
  • fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
  • fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
  • fast/frames/sandboxed-iframe-scripting-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-invalid-header-expected.txt:
  • http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
  • http/tests/security/sandbox-inherit-to-initial-document-2-expected.txt:
  • media/video-controls-no-scripting-expected.txt:

Rebaselining tests with new expectations.

10:38 AM Changeset in webkit [137179] by fpizlo@apple.com
  • 10 edits in trunk

JSC profiling and debug dump code should use inferred names when possible
https://bugs.webkit.org/show_bug.cgi?id=104519

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This does as advertised: the profiler now knows the inferred name of all code blocks,
and all uses of CodeBlock::dump() dump it along with the hash.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::inferredName):
(JSC::CodeBlock::dumpAssumingJITType):

  • bytecode/CodeBlock.h:
  • profiler/ProfilerBytecodes.cpp:

(JSC::Profiler::Bytecodes::Bytecodes):
(JSC::Profiler::Bytecodes::toJS):

  • profiler/ProfilerBytecodes.h:

(JSC::Profiler::Bytecodes::inferredName):

  • profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::addBytecodes):
(JSC::Profiler::Database::ensureBytecodesFor):

  • profiler/ProfilerDatabase.h:
  • runtime/CommonIdentifiers.h:

Tools:

The format I'm using for referring to a code block is now name#hash. For example,
v8-crypto has something called bnpSquareTo#B5QFbU. The profiler allows you to use
either the hash, the inferred name, or the combined hash and full name when referring
to blocks.

  • Scripts/display-profiler-output:
10:36 AM Changeset in webkit [137178] by Chris Fleizach
  • 4 edits in trunk/Source/WebCore

AX: Crash in NSAccessibilityUnignoredDescendant
https://bugs.webkit.org/show_bug.cgi?id=104468

Reviewed by Anders Carlsson.

This crash occurred because AccessibilityScrollView stopped retaining it's ScrollView pointer.

Unfortunately, there was still a case that didn't correctly clear that variable.

That case was when a Frame had a new FrameView associated with it. The old FrameView didn't inform the
accessibility object cache that it should be removed. As a result, when the FrameView deallocated and
did try to remove, it used the wrong AXObjectCache because it was no longer correctly hooked into the
document tree.

No new tests. Existing tests will stop crashing.

  • page/Frame.cpp:

(WebCore::Frame::setView): change the name of the method that tells the FrameView to detach

  • page/FrameView.cpp:

(WebCore::FrameView::~FrameView):
(WebCore::FrameView::removeFromAXObjectCache): add a method that can be called in multiple places
(WebCore::FrameView::isFrameView):
(WebCore::FrameView::prepareForDetach): detaches scrollbars and accessibility

  • page/FrameView.h:

(FrameView):

10:22 AM Changeset in webkit [137177] by pilgrim@chromium.org
  • 12 edits
    1 copy
    2 moves in trunk/Source

[Chromium] Move getPluginsList out of PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96507

Reviewed by Darin Fisher.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

  • Platform.gypi:
  • chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::getPluginList):

  • chromium/public/WebPluginListBuilder.h: Added.

(WebKit):
(WebPluginListBuilder):

Source/WebCore:

  • WebCore.gypi:
  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • plugins/chromium/PluginDataChromium.cpp:

(WebCore::PluginCache::plugins):

  • plugins/chromium/PluginListBuilder.cpp: Added.

(WebKit):
(WebKit::PluginListBuilder::addPlugin):
(WebKit::PluginListBuilder::addMediaTypeToLastPlugin):
(WebKit::PluginListBuilder::addFileExtensionToLastMediaType):

  • plugins/chromium/PluginListBuilder.h: Added.

(WebKit):
(PluginListBuilder):
(WebKit::PluginListBuilder::PluginListBuilder):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebPluginListBuilder.h:
  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKit::WebKitPlatformSupport::idbFactory):

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::idbFactory):

  • src/WebPluginListBuilderImpl.cpp: Removed.
  • src/WebPluginListBuilderImpl.h: Removed.
10:21 AM Changeset in webkit [137176] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Fixing most of the expectations added in r137153, the baselines are missing so the expectations
are changed according to that. The a11y gurus will have a look at them and determine what the
baselines should look like and whether the tests can be fixed.

  • platform/gtk/TestExpectations:
10:17 AM Changeset in webkit [137175] by fpizlo@apple.com
  • 23 edits
    6 adds in trunk

Profiler should say things about OSR exits
https://bugs.webkit.org/show_bug.cgi?id=104497

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This adds support for profiling OSR exits. For each exit that is taken, the profiler
records the machine code address that the exit occurred on, the exit kind, the origin
stack, and the number of times that it happened.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/AbstractMacroAssembler.h:

(Jump):
(JSC::AbstractMacroAssembler::Jump::label):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::saveCompilation):
(CodeBlock):
(JSC::CodeBlock::compilation):
(DFGData):

  • bytecode/DFGExitProfile.h:

(DFG):

  • bytecode/ExitKind.cpp: Added.

(JSC):
(JSC::exitKindToString):
(JSC::exitKindIsCountable):
(WTF):
(WTF::printInternal):

  • bytecode/ExitKind.h: Added.

(JSC):
(WTF):

  • dfg/DFGGraph.h:

(Graph):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGJITCompiler.h:

(JITCompiler):

  • dfg/DFGOSRExitCompiler.cpp:
  • jit/JIT.cpp:

(JSC::JIT::JIT):
(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JIT):

  • jit/JumpReplacementWatchpoint.h:

(JSC::JumpReplacementWatchpoint::sourceLabel):
(JumpReplacementWatchpoint):

  • profiler/ProfilerCompilation.cpp:

(JSC::Profiler::Compilation::addOSRExitSite):
(Profiler):
(JSC::Profiler::Compilation::addOSRExit):
(JSC::Profiler::Compilation::toJS):

  • profiler/ProfilerCompilation.h:

(Compilation):

  • profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::newCompilation):

  • profiler/ProfilerDatabase.h:

(Database):

  • profiler/ProfilerOSRExit.cpp: Added.

(Profiler):
(JSC::Profiler::OSRExit::OSRExit):
(JSC::Profiler::OSRExit::~OSRExit):
(JSC::Profiler::OSRExit::toJS):

  • profiler/ProfilerOSRExit.h: Added.

(Profiler):
(OSRExit):
(JSC::Profiler::OSRExit::id):
(JSC::Profiler::OSRExit::origin):
(JSC::Profiler::OSRExit::exitKind):
(JSC::Profiler::OSRExit::isWatchpoint):
(JSC::Profiler::OSRExit::counterAddress):
(JSC::Profiler::OSRExit::count):

  • profiler/ProfilerOSRExitSite.cpp: Added.

(Profiler):
(JSC::Profiler::OSRExitSite::toJS):

  • profiler/ProfilerOSRExitSite.h: Added.

(Profiler):
(OSRExitSite):
(JSC::Profiler::OSRExitSite::OSRExitSite):
(JSC::Profiler::OSRExitSite::codeAddress):

  • runtime/CommonIdentifiers.h:

Tools:

Adds support for displaying OSR exit information for full summary (just displays the
counts and the number of recompilations), bytecode display (says which bytecodes
exited), and DFG display (annotates disassembly with taken OSR exits and their
counts).

  • Scripts/display-profiler-output:
9:58 AM Changeset in webkit [137174] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

inspector/styles/styles-computed-trace still times out after r137156.

Unreviewed gardening.

  • platform/chromium/TestExpectations:
9:55 AM Changeset in webkit [137173] by Carlos Garcia Campos
  • 38 edits in trunk/Source

[GTK] Build GObject DOM bindings as a separate library
https://bugs.webkit.org/show_bug.cgi?id=104527

Reviewed by Xan Lopez.

Source/WebCore:

  • bindings/gobject/GNUmakefile.am: Add libWebCoreDOM library.
  • bindings/gobject/WebKitDOMBinding.h: Define private macros.
  • bindings/gobject/WebKitDOMCustom.h: Don't include webkit/webkitdefines.h.
  • bindings/gobject/WebKitDOMEventTarget.h: Ditto.
  • bindings/gobject/WebKitDOMObject.h: Ditto.
  • bindings/scripts/CodeGeneratorGObject.pm:

(Generate): Don't include webkitglobalsprivate.h.
(WriteData): Don't include webkit/webkitdefines.h.

  • bindings/scripts/gobject-generate-headers.pl: Define WEBKIT_API

macro in webkitdomdefines.h.

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.h:
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h:
  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h:
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
  • bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestException.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.h:
  • bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestNode.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.h:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:

Source/WebKit/gtk:

  • GNUmakefile.am: Link to libWebCoreDOM.la.
9:53 AM Changeset in webkit [137172] by rniwa@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Removed failing test expectations for GTK+ port after r137107.

  • platform/gtk/TestExpectations:
9:48 AM Changeset in webkit [137171] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

In InbandTextTrackPrivate, return emptyAtoms instead of emptyString() by default.

Unreviewed build fix.

  • platform/graphics/InbandTextTrackPrivate.h:

(WebCore::InbandTextTrackPrivate::label):
(WebCore::InbandTextTrackPrivate::language):

9:35 AM Changeset in webkit [137170] by adamk@chromium.org
  • 2 edits in trunk/LayoutTests

Chromium test expectations update after r137152.
Unreviewed gardening.

  • platform/chromium/TestExpectations:
9:31 AM Changeset in webkit [137169] by loislo@chromium.org
  • 13 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: instrument RenderBox descendants.
https://bugs.webkit.org/show_bug.cgi?id=104026

Reviewed by Eric Seidel.

Plain vanilla instrumentation for RenderBox descendants.

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::reportMemoryUsage):
(WebCore):
(WebCore::RenderFrameSet::GridAxis::reportMemoryUsage):

  • rendering/RenderFrameSet.h:

(RenderFrameSet):
(GridAxis):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::reportMemoryUsage):
(WebCore):

  • rendering/RenderListMarker.h:

(RenderListMarker):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::reportMemoryUsage):
(WebCore):

  • rendering/RenderReplaced.h:

(RenderReplaced):

  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::reportMemoryUsage):
(WebCore):

  • rendering/RenderTableCol.h:

(RenderTableCol):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::reportMemoryUsage):
(WebCore):

  • rendering/RenderTableRow.h:

(RenderTableRow):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::reportMemoryUsage):
(WebCore):
(WebCore::RenderTableSection::RowStruct::reportMemoryUsage):
(WebCore::RenderTableSection::CellStruct::reportMemoryUsage):

  • rendering/RenderTableSection.h:

(CellStruct):
(RowStruct):

9:30 AM Changeset in webkit [137168] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

AX: wrong Enabled states on a ListBox
https://bugs.webkit.org/show_bug.cgi?id=104483

Patch by Alejandro Piñeiro <apinheiro@igalia.com> on 2012-12-10
Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/listbox-enabled-states.html

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::isEnabled): taking into
account the DISABLED attribute and the aria-disabled attribute to
decide if the item is enabled or not.

LayoutTests:

  • accessibility/listbox-enabled-states-expected.txt: Added.
  • accessibility/listbox-enabled-states.html: Added.
9:28 AM Changeset in webkit [137167] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

cr-win build fix after r137161.

Unreviewed.

  • platform/graphics/MediaPlayer.h: Replace forward-decl of

InbandTextTrackPrivate with #include as the definition is required.

9:25 AM Changeset in webkit [137166] by alexis@webkit.org
  • 31 edits in trunk

[CSS3 Backgrounds and Borders] Remove CSS3_BACKGROUND feature flag.
https://bugs.webkit.org/show_bug.cgi?id=104539

Reviewed by Antonio Gomes.

.:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
  • configure.ac:

Source/JavaScriptCore:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

No new tests : the feature is covered by various tests and it is already enabled in many ports.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.features.am:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillProperty):

  • css/CSSParser.h:
  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):

  • rendering/style/FillLayer.cpp:

(SameSizeAsFillLayer):
(WebCore::FillLayer::FillLayer):
(WebCore::FillLayer::operator=):
(WebCore::FillLayer::operator==):
(WebCore::FillLayer::fillUnsetProperties):

  • rendering/style/FillLayer.h:

(WebCore::FillLayer::backgroundXOrigin):
(WebCore::FillLayer::backgroundYOrigin):
(WebCore::FillLayer::isBackgroundOriginSet):
(WebCore::FillLayer::clearXPosition):
(WebCore::FillLayer::clearYPosition):
(FillLayer):

Source/WebKit/chromium:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

  • features.gypi:

Source/WebKit/mac:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

  • Configurations/FeatureDefines.xcconfig:

Tools:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

As discussed on webkit-dev it is not needed to keep this feature flag
as support for <position> type is a small feature that is already
implemented by three other UAs. It was useful while landing this
feature as partial bits were landed one after one.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

Unskip the related CSS3 <position> type tests for background-position
as now the feature is enabled by default.

  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
9:19 AM Changeset in webkit [137165] by adamk@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Remove expectation of previously failing test.
It passes after r137152.

Unreviewed gardening.

  • platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Removed.
9:14 AM Changeset in webkit [137164] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

WebKitWebViewBase produces a warning if compiled with gcc
https://bugs.webkit.org/show_bug.cgi?id=104561

Patch by Alberto Garcia <agarcia@igalia.com> on 2012-12-10
Reviewed by Carlos Garcia Campos.

  • UIProcess/API/gtk/WebKitWebViewBase.h:

since this file can be included from C code, use void to
explicitly specify that webkit_web_view_base_get_type() doesn't
have parameters. Otherwise we get "warning: function declaration
isn't a prototype" with -Wstrict-prototypes.

9:01 AM Changeset in webkit [137163] by nghanavatian@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix warning for comparison between signed and unsigned
https://bugs.webkit.org/show_bug.cgi?id=104563

Reviewed by Rob Buis.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::isCaretAtEndOfText):

8:56 AM Changeset in webkit [137162] by jocelyn.turcotte@digia.com
  • 2 edits in trunk

[Qt] Remove the support for building a debug WebKit with a release Qt
https://bugs.webkit.org/show_bug.cgi?id=104560

Reviewed by Tor Arne Vestbø.

This creates issues with non-framework builds of Qt (necessary for debug-only
builds) since a Qt5 prefix is now added to the base target name.

  • Source/api.pri:
8:50 AM ViewportInteractionTopics edited by kenneth@webkit.org
(diff)
8:19 AM Changeset in webkit [137161] by eric.carlson@apple.com
  • 25 edits
    1 move
    8 adds in trunk

Add support for in-band text tracks to Mac port
https://bugs.webkit.org/show_bug.cgi?id=103663

Reviewed by Sam Weinig.

Source/WebCore:

Test: media/track/track-in-band.html

  • GNUmakefile.list.am: Move InbandTextTrackPrivate.h to platform/graphics. Add InbandTextTrackPrivateClient.h.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Add new files.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setReadyState): No need to call processInbandTextTracks, in-band tracks

are now registered by the media engine as they are discovered.

(WebCore::HTMLMediaElement::mediaPlayerDidAddTrack): New, called by the media player when a new

in-band track is found.

(WebCore::HTMLMediaElement::mediaPlayerDidRemoveTrack): New, called by the media player when an

in-band track goes away.

  • html/HTMLMediaElement.h:
  • html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::InbandTextTrack): Use m_private instead of tracksPrivate because

it is zeroed during assignment.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::addTextTrack): New MediaPlayerClient method to allow MediaPlayerPrivate subclasses

to add a new in-band track.

(WebCore::MediaPlayer::removeTextTrack): New MediaPlayerClient method to allow MediaPlayerPrivate subclasses

to remove a new in-band track.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:
  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: Added.

(WebCore::InbandTextTrackPrivateAVF::InbandTextTrackPrivateAVF):
(WebCore::InbandTextTrackPrivateAVF::~InbandTextTrackPrivateAVF):
(WebCore::InbandTextTrackPrivateAVF::processCueAttributes): Convert an attribute string into WebVTT

cue setting and content strings.

(WebCore::InbandTextTrackPrivateAVF::processCue): Process a new cue.
(WebCore::InbandTextTrackPrivateAVF::disconnect): Clear member variables.
(WebCore::InbandTextTrackPrivateAVF::resetCueValues): Reset cue values to defaults.
(WebCore::InbandTextTrackPrivateAVF::setMode): Set track mode and call player's trackModeChanged.

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h: Added.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: Initialize

m_inbandTrackConfigurationPending.

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Flush the currently accumulating

cue so it doesn't get the wrong duration.

(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Handle InbandTracksNeedConfiguration.
(WebCore::MediaPlayerPrivateAVFoundation::flushCurrentCue): New, pass the current cue up to the client.
(WebCore::MediaPlayerPrivateAVFoundation::configureInbandTracks): Configure in-band tracks.
(WebCore::MediaPlayerPrivateAVFoundation::trackModeChanged): Schedule a call to configureInbandTracks.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h: Added.
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm: Added.

(WebCore::InbandTextTrackPrivateAVFObjC::InbandTextTrackPrivateAVFObjC):
(WebCore::InbandTextTrackPrivateAVFObjC::disconnect):
(WebCore::InbandTextTrackPrivateAVFObjC::kind): Return track kind.
(WebCore::InbandTextTrackPrivateAVFObjC::label): Return track label.
(WebCore::InbandTextTrackPrivateAVFObjC::language): Return track language.
(WebCore::InbandTextTrackPrivateAVFObjC::isDefault):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

(MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItem):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize m_currentTrack.
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Clear m_legibleOutput.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Create and initialize m_legibleOutput.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processTextTracks): Called when the player item's

"tracks" changes, add and remove in-band text tracks as necessary.

(WebCore::MediaPlayerPrivateAVFoundationObjC::processCue): Pass an attributed string to the current

track to be processed.

(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Tell AVFoundation to select an in-band track.
(WebCore::MediaPlayerPrivateAVFoundationObjC::currentTrack): Return the current track.
(-[WebCoreAVFMovieObserver legibleOutput:didOutputAttributedStrings:nativeSampleBuffers:forItemTime:]): Legible

output delegate.

Source/WTF:

  • wtf/Platform.h: Define HAVE_AVFOUNDATION_TEXT_TRACK_SUPPORT.

LayoutTests:

Test for initial support for in-band text tracks. New test skipped on all ports that don't
have support in the media engine.

  • media/content/counting-subtitled.m4v: Added.
  • media/track/track-in-band-expected.txt: Added.
  • media/track/track-in-band.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
8:18 AM Changeset in webkit [137160] by pfeldman@chromium.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: fix front-end compilation warnings
https://bugs.webkit.org/show_bug.cgi?id=104557

Reviewed by Alexander Pavlov.

Corresponding annotations added.

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::highlightNode):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleDeclaration.prototype.):
(WebInspector.CSSStyleDeclaration.prototype.insertPropertyAt):

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._appendPropertyPreview):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMAgent.prototype.highlightDOMNode):

  • inspector/front-end/DOMPresentationUtils.js:

(WebInspector.DOMPresentationUtils.linkifyNodeReference):

  • inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.prototype.update):

  • inspector/front-end/Toolbar.js:
8:10 AM Changeset in webkit [137159] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] MediaPlayerQTKit broken after switching QPainter to raster engine.
https://bugs.webkit.org/show_bug.cgi?id=104550

With Qt5 QPainter changed to using the raster engine.
Therefore we no longer have an NSGraphicsContext that we can
use for drawing video frames.
With this patch we are rendering the video frame into an image buffer
and then paint it manually using QPainter.

Reviewed by Simon Hausmann.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore):
(WebCore::swapBgrToRgb):

Swap the color format from BGR to RGB,
since BGR is not supported by QImage.

(WebCore::MediaPlayerPrivateQTKit::paint):

8:00 AM Changeset in webkit [137158] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Link fix in InspectorController.cpp
https://bugs.webkit.org/show_bug.cgi?id=104556

Patch by peavo@outlook.com <peavo@outlook.com> on 2012-12-10
Reviewed by Pavel Feldman.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController): Added missing #if check.

7:55 AM ViewportInteractionTopics edited by kenneth@webkit.org
(diff)
7:28 AM Changeset in webkit [137157] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Add 'WebKit/chromium/win8' to .gitignore
https://bugs.webkit.org/show_bug.cgi?id=104534

Reviewed by Jochen Eisinger.

I've now added it via 'git add' once, and via 'git commit -a' twice.
Let's make that more difficult, shall we?

  • .gitignore:
7:23 AM Changeset in webkit [137156] by loislo@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed: Web Inspector: update test expectation for inspector/styles/styles-computed-trace.html.
it is slow in debug version. ~20 sec on linux.

  • platform/chromium/TestExpectations:
7:20 AM Changeset in webkit [137155] by Martin Robinson
  • 1 edit
    1 add in trunk/Tools

Build fix.

Add a patchfile missing from my previous commit.

  • gtk/patches/harfbuzz-icu-detection-fix.patch: Added.
7:20 AM Changeset in webkit [137154] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: remove the Overrides / Settings context menu from gear icon
https://bugs.webkit.org/show_bug.cgi?id=104546

Reviewed by Alexander Pavlov.

It sounds like too many people don't like the way it works. Bringing things back: overrides will be a tab in settings for now.
Moving present behavior to under experiment.

  • inspector/front-end/OverridesView.js:

(WebInspector.OverridesView):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.OverridesSettingsTab):
(WebInspector.SettingsController):
(WebInspector.SettingsController.prototype.get statusBarItem):
(WebInspector.SettingsController.prototype._mouseDown.showSettings):
(WebInspector.SettingsController.prototype._mouseDown):
(WebInspector.SettingsController.prototype._mouseUp):

  • inspector/front-end/helpScreen.css:

(#settings-screen .tabbed-pane-header):
(#settings-screen .tabbed-pane-header-tabs):
(#settings-screen .tabbed-pane-header-tab):

7:16 AM Changeset in webkit [137153] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Unskipping 8 failing accessibility tests, adding expected failures for them.

  • platform/gtk/TestExpectations:
7:13 AM Changeset in webkit [137152] by tkent@chromium.org
  • 12 edits in trunk

Visual order of empty value placeholder in INPUT_MULTIPLE_FIELDS_UI is wrong in RTL
https://bugs.webkit.org/show_bug.cgi?id=104438

Reviewed by Hajime Morita.

Source/WebCore:

No new tests. This updates datetimelocal-appearance-l10n.html for he-il
and ar-eg locales.

  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
We should not append Right-to-left-mark to each of placeholder
strings. It makes numeric field separators such as ':' and '/' RTL, and
makes a wrong visual order. We use unicode-bidi:bidi-override and
direction:ltr instead. It means we force LTR only to this element

  • html/shadow/DateTimeNumericFieldElement.h:

Makes m_placeholder const again.

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitLiteral):
Explicitly set right-to-left-mark before S, WS, ON types according to
Unicod Bidirectional Algorithm Table 4 [1]. This is needed because we
don't have context like "This literal follows European/Arabic numbers"
in a case of showing placeholders.
[1] http://www.unicode.org/reports/tr9/#Bidirectional_Character_Types

LayoutTests:

  • platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
  • platform/chromium/TestExpectations:

Update bug numbers and add time-multiple-fields-localization.html.

  • fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html:

Adjust test scenario for the new behavior.

  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html:
  • fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html:
  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:
7:11 AM Changeset in webkit [137151] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

REGRESSION(137127): Causes assertion failures on the debug bots
https://bugs.webkit.org/show_bug.cgi?id=104549

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-12-10
Reviewed by Alejandro G. Castro.

After handling the new TextOutput message we should return the method
handling messages received.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Fix a missing early return.

7:02 AM Changeset in webkit [137150] by kov@webkit.org
  • 16 edits
    1 copy in trunk

[Soup] utilize multipart/x-mixed-replace support recently added to libsoup
https://bugs.webkit.org/show_bug.cgi?id=94515

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2012-12-09
Reviewed by Martin Robinson.

.:

  • configure.ac: require soup 2.40.0, which adds the new support.

Source/WebCore:

The multipart/x-mixed-replace content type is often used for providing
"push" server support, with each part in the multipart response
replacing the previous one in the rendering. Soup recently acquired
support for multipart/x-mixed replace, which this change utilizes.

Covered by existing multipart/x-mixed-replace tests.

  • platform/network/ResourceHandleInternal.h:

(ResourceHandleInternal): add new member to this class, the multipart input stream

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::cleanupSoupRequestOperation): also clear the multipart input stream on
cleanup
(WebCore::nextPartCallback): callback that handles reporting the new response delivered
with the new part, if any; uses the factored out updateFromSoupMessageHeaders method
(WebCore::sendRequestCallback): handle multipart/x-mixed-replace responses by
requesting the next part
(WebCore::readCallback): when reading has finished, request the next part when
handling a multipart/x-mixed-replace response

  • platform/network/soup/ResourceResponse.h:

(ResourceResponse): add declaration for new method

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::updateFromSoupMessage): call new updateFromSoupMessageHeaders
method, instead of dealing with the message headers directly
(WebCore::ResourceResponse::updateFromSoupMessageHeaders): new method, factored out from
updateFromSoupMessage, so this same code can be reused for updating responses for
multipart/x-mixed-replace responses parts

Tools:

This change requires a very recent libsoup, so update our jhbuild
requirements.

  • gtk/jhbuild.modules: depend on soup version that adds the multipart/x-mixed-replace

support

  • efl/jhbuild.modules: ditto

LayoutTests:

  • platform/efl/TestExpectations: adjust expectations for tests that now pass.
  • platform/gtk/TestExpectations: ditto.
  • platform/gtk-wk2/TestExpectations: add missing multipart tests expectations.
  • platform/gtk/http/tests/multipart/invalid-image-data-expected.png: new baseline
  • platform/gtk/http/tests/multipart/invalid-image-data-expected.txt: ditto.
6:58 AM Changeset in webkit [137149] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

[WK2] TiledBackingStore: remove unneeded 'treatAsInitialValue' parameter from PageViewportControllerClient::setContentsScale
https://bugs.webkit.org/show_bug.cgi?id=104544

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-12-10
Reviewed by Kenneth Rohde Christiansen.

Removed 'treatAsInitialValue' parameter from PageViewportControllerClient::setContentsScale()
as it was not used by anyone.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::didRenderFrame):

  • UIProcess/PageViewportControllerClient.h:

(PageViewportControllerClient):

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::setContentsScale):

  • UIProcess/efl/PageViewportControllerClientEfl.h:

(PageViewportControllerClientEfl):

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::setContentsScale):

  • UIProcess/qt/PageViewportControllerClientQt.h:

(PageViewportControllerClientQt):

6:57 AM Changeset in webkit [137148] by commit-queue@webkit.org
  • 13 edits in trunk

Implement testRunner.setViewModeMediaFeature() in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=103886

Patch by Zoltan Nyul <zoltan.nyul@intel.com> on 2012-12-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Export symbol for WebCore::Page::setViewMode on Mac.

No new tests, no behavior change for layout tests.

  • WebCore.exp.in:

Source/WebKit2:

Add support for TestRunner::setViewModeMediaFeature().
This functionality is needed by the following LayoutTests:
fast/media/media-query-list-02.html
fast/media/media-query-list-03.html
fast/media/media-query-list-04.html
fast/media/media-query-list-05.html
fast/media/media-query-list-06.html
fast/media/media-query-list-07.html
fast/media/view-mode-media-feature.html

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetViewMode):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setViewMode):
(WebKit):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

Tools:

Implement testRunner.setViewModeMediaFeature() in WebKitTestRunner.
This API is required by layout tests.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setViewModeMediaFeature):
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Unskipping the following tests for EFL WebKit2:
fast/media/media-query-list-02.html
fast/media/media-query-list-03.html
fast/media/media-query-list-04.html
fast/media/media-query-list-05.html
fast/media/media-query-list-06.html
fast/media/media-query-list-07.html
fast/media/view-mode-media-feature.html

  • platform/efl-wk2/TestExpectations:
6:54 AM Changeset in webkit [137147] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix QtWebProcess discovery on Windows
https://bugs.webkit.org/show_bug.cgi?id=104552

Reviewed by Jocelyn Turcotte.

Make sure to look for QtWebProcess.exe on Windows instead of QtWebProcess.

  • Shared/qt/ProcessExecutablePathQt.cpp:

(WebKit::executablePath):

6:50 AM Changeset in webkit [137146] by Martin Robinson
  • 135 edits
    8 adds in trunk

[GTK] Bring Harfbuzz-ng support to Gtk
https://bugs.webkit.org/show_bug.cgi?id=92098

Reviewed by Gustavo Noronha Silva.

.:

Add support for detecting HarfBuzz during configuration phase. Add these
flags to the FreeType ones since HarfBuzz support is part of the FreeType
backend.

  • configure.ac: Detect HarfBuzz.

Source/WebCore:

Enable HarfBuzz support by default. With the Freetype backend we no longer
fall back to Pango for rendering complex text.

No new tests. This is covered by existing tests.

  • GNUmakefile.am: Add HarfBuzz include directories and define.
  • GNUmakefile.list.am: Add HarfBuzz files to source list and remove

Pango ones.

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::FontPlatformData::operator==): To properly render fallback
fonts via HarfBuzz , it's important that we actually ask Fontconfig
whether or not two patterns are the same. This ensures that when patterns
are just copies of one another they only take up one slot in the font cache
and appear to be the same font to HarfBuzzShaper.

Source/WebKit/gtk:

Add HarfBuzz dependency.

  • GNUmakefile.am: Add FreeType/HarfBuzz CFLAGS to the library.

Source/WebKit2:

Add a HarfBuzz dependency.

  • GNUmakefile.am: Add FreeType/HarfBuzz CFLAGS/LIBS to the libraries.

Tools:

Add HarfBuzz dependency.

  • GNUmakefile.am: Add FreeType/HarfBuzz CFLAGS to the WebCore Internals library.
  • gtk/jhbuild.modules: Add HarfBuzz to the JHbuild and remove Pango, since it

should no longer affect layout test results.

LayoutTests:

Update tests results that have changed due to the switch to HarfBuzz.
In general, these are progressions or harmless metrics differences.

  • platform/gtk: Update test results that have changed.
6:40 AM Changeset in webkit [137145] by Simon Hausmann
  • 6 edits
    2 deletes in trunk

[Qt] Use QLibraryInfo::LibraryExecutablesPath unconditionally
https://bugs.webkit.org/show_bug.cgi?id=104541

Reviewed by Jocelyn Turcotte.

We now depend on a Qt 5 version that is guaranteed to have this API, so we
can remove the configure checks for it.

Source/WebKit2:

  • PluginProcess.pro:
  • Shared/qt/ProcessExecutablePathQt.cpp:

(WebKit::executablePath):

  • WebProcess.pro:

Tools:

  • qmake/config.tests/libexecdir/libexecdir.cpp: Removed.
  • qmake/config.tests/libexecdir/libexecdir.pro: Removed.
  • qmake/mkspecs/features/features.prf:
6:38 AM Changeset in webkit [137144] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=104548

  • platform/chromium/TestExpectations:

Hyphenation tests failure on WebKit-only checkout Linux

6:31 AM Changeset in webkit [137143] by loislo@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed: update expectation for inspector/styles/svg-style.xhtml

  • inspector/styles/svg-style-expected.txt:
  • platform/chromium/TestExpectations:
6:15 AM Changeset in webkit [137142] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Overrides] Unable to change values in Device Metrics override setting
https://bugs.webkit.org/show_bug.cgi?id=104542

Reviewed by Vsevolod Vlasov.

Remove inadvertent object property assignment.

  • inspector/front-end/OverridesView.js:
5:51 AM Changeset in webkit [137141] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

REGRESSION(r135863): GtkLauncher --help no longer displays all help options
https://bugs.webkit.org/show_bug.cgi?id=104382

Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2012-12-10
Reviewed by Philippe Normand.

Remove gst_init() because it steals the GOptionContext.
gst_init_get_option_group() already does the initialization job.

  • GtkLauncher/main.c:

(main):

5:34 AM Changeset in webkit [137140] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Webkit crashes sometimes (even though very rarely) when deleting a webview
https://bugs.webkit.org/show_bug.cgi?id=104504

Reviewed by George Staikos.

When deleting a webview, the webkit thread will send a sync message to userInterfaceThread
to delete handlers, including the viewport accessor. But the UserInterfaceThread could be
doing a blit after it has deleted the viewport accessor and before the webkit thread gets
the time slot to resume it's operation to clean up the webview, which leaves a very short
time that viewport accessor of a webpage has been deleted while the webpage is still in
the process of deleting, and the viewport accessor is referenced in the UserInterfaceThread.

So we need to check if the viewport accessor is NULL before using it in the backingstore code.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):

5:14 AM Changeset in webkit [137139] by michael.bruning@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Builds for Mac are tied to the OS system instead of the SDK version.
https://bugs.webkit.org/show_bug.cgi?id=104529

Reviewed by Simon Hausmann.

Using work by Eike Ziller <eike.ziller@digia.com>.

The build system now first tries to assign the correct system libraries
for the SDK being used for Mac builds. If this does not yield any
result, it falls back to using the Mac OS version to determine the
correct library.

No new tests (not applicable).

  • WebCore.pri:
4:58 AM Changeset in webkit [137138] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

[Qt] Fix build without QtQuick 2

Unreviewed trivial build fix.

This function is defined in QtWebContext, which is only used when QtQuick2 is available.

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInvalidateContext):

4:20 AM Changeset in webkit [137137] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed: touch RenderingAllInOne.cpp to fix Apple Windows builder.

  • rendering/RenderingAllInOne.cpp:
4:18 AM Changeset in webkit [137136] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Network: newly added items are not filtered.
https://bugs.webkit.org/show_bug.cgi?id=104021

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-12-10
Reviewed by Vsevolod Vlasov.

Extracted method to higlight/hide record according to filter.
Used this method to process newly created records.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._applyFilter): Extracted.
(WebInspector.NetworkLogView.prototype.performFilter): Refactored.

4:11 AM Changeset in webkit [137135] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Unreviewed: move reportMemoryUsage to public section.

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.h:

(RenderBox):

4:03 AM Changeset in webkit [137134] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Managing current failures on the 64-bit debug builder to get it green.

  • platform/gtk/TestExpectations:
3:53 AM QtWebKitReleases edited by Simon Hausmann
(diff)
3:50 AM WebKitEFLLayoutTest edited by thiago.santos@intel.com
(diff)
3:47 AM Changeset in webkit [137133] by pfeldman@chromium.org
  • 9 edits in trunk/Source/WebCore

Web Inspector: adds an option to remove toolbar icons.
https://bugs.webkit.org/show_bug.cgi?id=95654

Reviewed by Vsevolod Vlasov.

  • removes compact mode in favor or dock-to-bottom
  • introduces setting for hiding toolbar icons
  • inspector/front-end/DockController.js:

(WebInspector.DockController.prototype._toggleDockState):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/Toolbar.js:

(WebInspector.Toolbar.prototype.setDockedToBottom):
(WebInspector.Toolbar.prototype._toolbarDragStart):
(WebInspector.Toolbar.prototype._toolbarDrag):

  • inspector/front-end/helpScreen.css:

(body.dock-to-bottom .help-content):

  • inspector/front-end/inspector.css:

(body.dock-to-bottom #toolbar):
(body.no-toolbar-icons #toolbar):
(body.dock-to-bottom.port-qt #toolbar):
(body.dock-to-bottom.inactive #toolbar):
(body.no-toolbar-icons .toolbar-item.toggleable):
(body.dock-to-bottom .toolbar-item.toggleable):
(body.dock-to-bottom .toolbar-icon):
(body.no-toolbar-icons .toolbar-icon):
(body.no-toolbar-icons #main):
(body.dock-to-bottom .toolbar-icon.custom-toolbar-icon):
(body.dock-to-bottom .toolbar-item:active .toolbar-icon):
(body.dock-to-bottom .toolbar-label):
(body.dock-to-bottom #search-toolbar-label):
(body.no-toolbar-icons .toolbar-label):
(body.no-toolbar-icons #toolbar-dropdown):
(#toolbar-dropdown .scrollable-content):
(#toolbar-dropdown .toolbar-item.toggleable:hover):
(body.no-toolbar-icons #toolbar-dropdown .toolbar-label):
(body.no-toolbar-icons #toolbar-dropdown .toolbar-item):
(body.dock-to-bottom .toolbar-item.resources .toolbar-icon):
(body.dock-to-bottom .toolbar-item.network .toolbar-icon):
(body.dock-to-bottom .toolbar-item.scripts .toolbar-icon):
(body.dock-to-bottom .toolbar-item.timeline .toolbar-icon):
(body.dock-to-bottom .toolbar-item.profiles .toolbar-icon):
(body.dock-to-bottom .toolbar-item.audits .toolbar-icon):
(body.dock-to-bottom .toolbar-item.console .toolbar-icon):
(body.dock-to-bottom.port-qt .toolbar-item.close-left, body.dock-to-bottom.port-qt .toolbar-item.close-right):
(body.dock-to-bottom #main):

3:43 AM QtWebKitReleases edited by Simon Hausmann
(diff)
3:41 AM QtWebKitReleases edited by Simon Hausmann
(diff)
3:39 AM Changeset in webkit [137132] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Remove duplicate expectations
https://bugs.webkit.org/show_bug.cgi?id=104526

Unreviewed gardening: collect all WebAudio-related skips
to one place.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-12-10

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
3:34 AM Changeset in webkit [137131] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

Refactoring: Remove HTMLFormControlElement::autofocus
https://bugs.webkit.org/show_bug.cgi?id=104524

Reviewed by Kentaro Hara.

autofocus function is used only by HTMLFormControlElement itself, no
sub-classes override it, and it is not exposed via an IDL attribute,

No new tests. This doesn't make any behavior changes.

  • html/HTMLFormControlElement.cpp:

(WebCore::shouldAutofocus): Use fastHasAttribute instead of autofocus().

  • html/HTMLFormControlElement.h: Remove autofocus().
3:30 AM Changeset in webkit [137130] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

[GTK][WTR] Implement AccessibilityUIElement::titleUIElement
https://bugs.webkit.org/show_bug.cgi?id=102953

Reviewed by Martin Robinson.

Implement AccessibilityUIElement::titleUIElement in the ATK backend
in the same manner it is implemented in DumpRenderTree. Both implementations
are updated to unref the relation set before the final function return
rather than at the end of each loop through the relations held in the said
relation set.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::titleUIElement):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::titleUIElement):

3:29 AM Changeset in webkit [137129] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix GC3Dintptr and GC3Dsizeiptr typedefs for Win64
https://bugs.webkit.org/show_bug.cgi?id=104426

Patch by Jonathan Liu <net147@gmail.com> on 2012-12-10
Reviewed by Simon Hausmann.

The GC3Dintptr and GC3Dsizeiptr typedefs are incorrect for Win64 as
LLP64 is used there. This would result in compile error due to
narrowing conversion of 64-bit pointer to signed long int which is
32-bit.

  • platform/graphics/GraphicsTypes3D.h:
3:00 AM Changeset in webkit [137128] by Martin Robinson
  • 2 edits in trunk/Tools

Fix the WebKit2 debug build

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Fix a typo of WKStringGetTypeID().

2:44 AM Changeset in webkit [137127] by commit-queue@webkit.org
  • 9 edits in trunk/Tools

[WTR] Move text output accumulation to the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=104214

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-12-10
Reviewed by Darin Adler.

Instead of accumulating text output in the InjectedBundle and then sending it to the UIProcess
once a test is finished, immediately send any text output to the UIProcess. This will allow
WebKitTestRunner to output text from the UIProcess as well.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Remove the handling of the text output

StringBuilder. Add a method to send output to the UIProcess.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Change code that appends to the StringBuilder

to use the new outputText method.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
  • WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: Ditto.
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::TestInvocation): Intialize the StringBuilder.
(WTR::TestInvocation::invoke): Clear the StringBuilder when a new tests starts.
(WTR::TestInvocation::dumpResults): m_textOutput is a StringBuilder now so the
method of printing the text is slightly different.
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the new TextOutput
message by appending the results to the StringBuilder.

  • WebKitTestRunner/TestInvocation.h:

(TestInvocation): Switch the type of m_textOutput.

2:37 AM Changeset in webkit [137126] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Coordinated Graphics: Remove the dependency of ShareableSurface from Coordinated Graphics.
https://bugs.webkit.org/show_bug.cgi?id=100819

Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-10
Reviewed by Kenneth Rohde Christiansen.

It is a follow-up patch of r137117.

There are two changes

  1. Add a const qualifier to supportsAlpha().
  2. Use << instead of encode() when using ArgumentEncoder.
  • Shared/CoordinatedGraphics/CoordinatedSurface.h:

(WebKit::CoordinatedSurface::supportsAlpha):

  • Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:

(WebKit::WebCoordinatedSurface::Handle::encode):
(WebKit::WebCoordinatedSurface::copyToTexture):

2:35 AM Changeset in webkit [137125] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Coordinated Graphics: Remove the dependency of ShareableSurface from Coordinated Graphics.
https://bugs.webkit.org/show_bug.cgi?id=100819

Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-10
Reviewed by Kenneth Rohde Christiansen.

WebCoordinatedSurface::copyToTexture should return early if the backend
is GraphicsSurface.

  • Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:

(WebKit::WebCoordinatedSurface::copyToTexture):

2:26 AM Changeset in webkit [137124] by tkent@chromium.org
  • 16 edits in trunk/Source

Refactoring: Introduce HTMLFormControlElement::isDisabledOrReadOnly
https://bugs.webkit.org/show_bug.cgi?id=104508

Reviewed by Kentaro Hara.

Source/WebCore:

We have a lot of code like element->disabled
element->readOnly().

isDisabledOrReadOnly makes them simpler.

No new tests. This make no behaivor change.

  • html/HTMLFormControlElement.h:

(WebCore::HTMLFormControlElement::isDisabledOrReadOnly):
Added. Note that the implmentation of disabled() is not just "return m_disabled;".

  • html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
Use isDisabledOrReadOnly.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldSpinButtonRespondToMouseEvents): Ditto.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isPickerIndicatorOwnerDisabledOrReadOnly): Ditto.

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::handleDOMActivateEvent): Ditto.
(WebCore::ColorInputType::didChooseColor): Ditto.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::recalcWillValidate): Ditto.

  • html/HTMLTextAreaElement.h:

(WebCore::HTMLTextAreaElement::valueMissing): Ditto.

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent): Ditto.
(WebCore::RangeInputType::handleTouchEvent): Ditto.
(WebCore::RangeInputType::handleKeydownEvent): Ditto.

  • html/SearchInputType.cpp:

(WebCore::SearchInputType::handleKeydownEvent): Ditto.

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::handleKeydownEventForSpinButton): Ditto.
(WebCore::TextFieldInputType::shouldSpinButtonRespondToMouseEvents): Ditto.

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldCancelButtonElement::defaultEventHandler): Ditto.
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents): Ditto.
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler): Ditto.

  • html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::defaultEventHandler): Ditto.
(WebCore::TextFieldDecorationElement::willRespondToMouseMoveEvents): Ditto.
(WebCore::TextFieldDecorationElement::willRespondToMouseClickEvents): Ditto.

Source/WebKit/blackberry:

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openDatePopup): Use isDisabledOrReadOnly.
(BlackBerry::WebKit::InputHandler::openColorPopup): Ditto.

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::textInputType):
Use isDisabledOrReadOnly. Also, remove unnecessary local variable.

2:14 AM Changeset in webkit [137123] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Removing failure expectations for the MicroData tests that were fixed in r137107.

  • platform/gtk/TestExpectations:
2:12 AM Changeset in webkit [137122] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

Check that plugin functionality is enabled before querying the database for installed plugins.
https://bugs.webkit.org/show_bug.cgi?id=73671

Patch by Andy Shaw <andy.shaw@digia.com> on 2012-12-10
Reviewed by Jocelyn Turcotte.

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::objectContentType):

1:38 AM Changeset in webkit [137121] by pfeldman@chromium.org
  • 6 edits in trunk

Web Inspector: console broken? - console.dirxml behaves like console.log
https://bugs.webkit.org/show_bug.cgi?id=104245

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Do not generate preview for dirxml.

  • inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArray):

LayoutTests:

  • inspector/console/console-dirxml-expected.txt:
  • inspector/console/console-dirxml.html:
  • platform/chromium/TestExpectations:
1:29 AM Changeset in webkit [137120] by tkent@chromium.org
  • 4 edits in trunk/Source/WebCore

Refactoring: Remove HTMLFormControlElement::setDisabled
https://bugs.webkit.org/show_bug.cgi?id=104510

Reviewed by Kentaro Hara.

Remove it because the number of call sites is only one, and the
setDisabled implementation is equivalent to setBooleanAttribute.

No new tests. This should not make behavior changes.

  • html/HTMLFormControlElement.cpp: Remove setDisabled.
  • html/HTMLFormControlElement.h: Ditto.
  • html/FileInputType.cpp:

(WebCore::FileInputType::disabledAttributeChanged):
Replace setDisabled with setBooleanAttribute.

1:03 AM Changeset in webkit [137119] by morrita@google.com
  • 5 edits in trunk/Source/WebCore

[Shadow DOM][Refacdtoring] nextTo() and previousTo() can be part of ContentDistribution
https://bugs.webkit.org/show_bug.cgi?id=104514

Reviewed by Kentaro Hara.

InsertionPoint::nextTo() and InsertionPoint::previousTo() are an
query to distributed nodes, which is what ContentDistribution
represents. We can move them to better home.

No new tests. No behavior change.

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistribution::nextTo): Moved from InsertionPoint
(WebCore):
(WebCore::ContentDistribution::previousTo): Moved from InsertionPoint

  • html/shadow/ContentDistributor.h:

(ContentDistribution):

  • html/shadow/InsertionPoint.cpp:
  • html/shadow/InsertionPoint.h:

(WebCore::InsertionPoint::nextTo): Delegated to ContentDistribution
(WebCore::InsertionPoint::previousTo): Delegated to ContentDistribution

12:42 AM Changeset in webkit [137118] by mihnea@adobe.com
  • 2 edits in trunk/Tools

Unreviewed. Adding Mihai Maerean to the list of contributors, working on CSSRegions.

12:28 AM Changeset in webkit [137117] by commit-queue@webkit.org
  • 18 edits
    2 moves
    1 add in trunk/Source/WebKit2

Coordinated Graphics: Add CoordinatedSurface to remove the dependency of ShareableSurface from Coordinated Graphics.
https://bugs.webkit.org/show_bug.cgi?id=100819

Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-10
Reviewed by Noam Rosenthal.

Internal Review by Gwang Yoon Hwang and Jae Hyun Park.

It is a preparation patch for Threaded Coordinated Graphics on WK1.

Create a CoordinatedSurface class that can be the base class both for
the current IPC-based ShareableSurface, renamed here to
WebCoordinatedSurface, and to a future thread-based surface
implementation.

  • CMakeLists.txt:
  • Shared/CoordinatedGraphics/CoordinatedSurface.h: Added.

(WebCore):
(WebKit):
(CoordinatedSurface):
(WebKit::CoordinatedSurface::~CoordinatedSurface):
(WebKit::CoordinatedSurface::supportsAlpha):

  • Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp: Renamed from Source/WebKit2/Shared/ShareableSurface.cpp. Extends CoordinatedSurface.

(WebKit):
(WebKit::WebCoordinatedSurface::Handle::Handle):
(WebKit::WebCoordinatedSurface::Handle::encode):
(WebKit::WebCoordinatedSurface::Handle::decode):
(WebKit::CoordinatedSurface::create):
(WebKit::WebCoordinatedSurface::create):
(WebKit::WebCoordinatedSurface::createWithSurface):
(WebKit::WebCoordinatedSurface::createGraphicsContext):
(WebKit::WebCoordinatedSurface::WebCoordinatedSurface):
(WebKit::WebCoordinatedSurface::~WebCoordinatedSurface):
(WebKit::WebCoordinatedSurface::createHandle):
(WebKit::WebCoordinatedSurface::copyToTexture):

  • Shared/CoordinatedGraphics/WebCoordinatedSurface.h: Renamed from Source/WebKit2/Shared/ShareableSurface.h.

(WebCore):
(WebKit):
(WebCoordinatedSurface):
(Handle):
(WebKit::WebCoordinatedSurface::Handle::graphicsSurfaceToken):
(WebKit::WebCoordinatedSurface::isBackedByGraphicsSurface):

  • Target.pri:
  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStoreTile::swapBuffers):
(WebKit::CoordinatedBackingStoreTile::setBackBuffer):
(WebKit::CoordinatedBackingStore::updateTile):

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:

(WebKit):
(CoordinatedBackingStoreTile):
(CoordinatedBackingStore):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::createUpdateAtlas):
(WebKit::LayerTreeCoordinatorProxy::updateImageBacking):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::updateImageBacking):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(TileUpdate):
(WebKit::LayerTreeRenderer::TileUpdate::TileUpdate):
(LayerTreeRenderer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::beginContentUpdate):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.cpp:

(WebKit::CoordinatedImageBacking::update):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.h:

(Coordinator):
(CoordinatedImageBacking):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::updateImageBacking):
(WebKit::LayerTreeCoordinator::createUpdateAtlas):
(WebKit::LayerTreeCoordinator::beginContentUpdate):
(WebKit::LayerTreeCoordinator::releaseInactiveAtlasesTimerFired):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

  • WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:

(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):

  • WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h:

(UpdateAtlasClient):
(UpdateAtlas):
(WebKit::UpdateAtlas::supportsAlpha):

12:22 AM Changeset in webkit [137116] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip 5 MicroData test cases that were fixed in r137107.

  • platform/efl/TestExpectations:
12:19 AM Changeset in webkit [137115] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Add fast/canvas/webgl tests to TestExpectations since they
sometimes crash on the bots.

  • platform/efl/TestExpectations:
12:17 AM Changeset in webkit [137114] by commit-queue@webkit.org
  • 7 edits in trunk

[GTK] accessibility/language-attribute.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98369

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-12-10
Reviewed by Chris Fleizach.

The test is failing for two reasons: Not exposing the language
for accessible objects and AccessibilityUIElement::language() not
being implemented.

Source/WebCore:

No new tests; instead, unskipped the previously-failing test.

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getAttributeSetForAccessibilityObject): Expose the language via AtkText attribute

Tools:

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::language): Implemented.

LayoutTests:

  • accessibility/language-attribute.html: Modified the test to work with

both Mac and Atk platforms. (The former exposes static text objects as
accessibles; the latter folds the text into the parent element.)

  • platform/gtk/TestExpectations: Unskipped the previously-failing test.
12:04 AM Changeset in webkit [137113] by commit-queue@webkit.org
  • 9 edits
    2 moves in trunk

[GTK] accessibility/editable-webarea-context-menu-point.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98364

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-12-10
Reviewed by Chris Fleizach.

Tools:

The test is failing because the clickPoint values remain unchanged. The
values remain unchanged because ATK lacks a means to keep track of this
information.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::clickPointX): Added comment that ATK doesn't have clickPoint details
(AccessibilityUIElement::clickPointY): Added comment that ATK doesn't have clickPoint details

LayoutTests:

This test seems to be Mac-specific. Therefore, move the test to that
platform and remove the skips from the other platforms.

  • platform/chromium/TestExpectations: Remove editable-webarea-context-menu-point.html
  • platform/efl-wk2/TestExpectations: Remove editable-webarea-context-menu-point.html
  • platform/gtk-wk2/TestExpectations: Remove editable-webarea-context-menu-point.html
  • platform/gtk/TestExpectations: Remove editable-webarea-context-menu-point.html
  • platform/mac/accessibility/editable-webarea-context-menu-point-expected.txt: Renamed from LayoutTests/accessibility/editable-webarea-context-menu-point-expected.txt.
  • platform/mac/accessibility/editable-webarea-context-menu-point.html: Renamed from LayoutTests/accessibility/editable-webarea-context-menu-point.html.
  • platform/win/TestExpectations: Remove editable-webarea-context-menu-point.html
  • platform/wincairo/TestExpectations: Remove editable-webarea-context-menu-point.html

Dec 9, 2012:

11:43 PM Changeset in webkit [137112] by tasak@google.com
  • 7 edits in trunk

[Shadow DOM]: reset-style-inheritance doesn't work for insertion point
https://bugs.webkit.org/show_bug.cgi?id=103711

Reviewed by Hajime Morita.

Source/WebCore:

reset-style-inheritance can be specified by using insertion points'
attribute, e.g. <content reset-style-inheritance>.
c.f. shadow dom spec:
https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#styles

No new tests. Updated an existing test,
fast/dom/shadow/insertion-point-resetStyleInheritance.html to cover
this feature.

  • html/HTMLAttributeNames.in:

Added HTMLNames::reset_style_inheritanceAttr.

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::parseAttribute):
Since both shadow and content elements have to support
reset-style-inheritance, added InsertionPoint::parseAttribute.
(WebCore::InsertionPoint::resetStyleInheritance):
(WebCore::InsertionPoint::setResetStyleInheritance):
Modified to update reset-style-inheritance attribute value.

  • html/shadow/InsertionPoint.h:

(InsertionPoint):
Removed m_shouldResetStyleInheritance. Instead, use
reset-style-inheritance attribute value.

LayoutTests:

  • fast/dom/shadow/insertion-point-resetStyleInheritance-expected.txt:
  • fast/dom/shadow/insertion-point-resetStyleInheritance.html:

Added two more basic tests to cover <content reset-style-inheritance>
and <shadow reset-style-inheritance>.

11:28 PM Changeset in webkit [137111] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] lack of implemention of AccessibilityUIElementGtk::isSelectable and AccessibilityUIElementGtk::isMultiSelectable
https://bugs.webkit.org/show_bug.cgi?id=104481

Patch by Alejandro Piñeiro <apinheiro@igalia.com> on 2012-12-09
Reviewed by Martin Robinson.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::isSelectable): Implement this by checking
the current state of the AtkObject.
(AccessibilityUIElement::isMultiSelectable): Implement this by
checking the current state of the AtkObject.

10:54 PM Changeset in webkit [137110] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG ArrayPush/Pop should not pass their second child as the index for blessArrayOperation()
https://bugs.webkit.org/show_bug.cgi?id=104500

Reviewed by Oliver Hunt.

Slight across-the-board speed-up.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

10:45 PM Changeset in webkit [137109] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

Coordinated Graphics: Reorder messages to LayerTreeCoordinatorProxy
https://bugs.webkit.org/show_bug.cgi?id=103843

Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-09
Reviewed by Noam Rosenthal.

Send SetRootCompositingLayer message to the UI process before
flushing compositing states of layer tree.

This is in preparation for refactoring TextureMapper to work in an actor
model (http://webkit.org/b/103854).

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::setRootLayerID):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
(WebKit::LayerTreeCoordinator::initializeRootCompositingLayerIfNeeded):
(WebKit):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

10:16 PM Changeset in webkit [137108] by loislo@chromium.org
  • 32 edits in trunk/Source/WebCore

Native Memory Instrumentation: instrument a part of RenderObject class tree.
https://bugs.webkit.org/show_bug.cgi?id=103564

Reviewed by Eric Seidel.

Many RenderObject descendants have OwnPtrs and RefPtrs members.
Looks like we have to instrument all the RenderObject classes and visit
all the render objects instead of counting entire render arena memory.

  • WebCore.exp.in:
  • dom/Node.cpp:

(WebCore::Node::reportMemoryUsage):

  • dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::reportRenderTreeInfo):
(WebCore):

  • platform/PlatformMemoryInstrumentation.cpp:

(WebCore):

  • platform/PlatformMemoryInstrumentation.h:

(PlatformMemoryTypes):

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::reportMemoryUsage):
(WebCore):

  • platform/graphics/GraphicsLayer.h:

(GraphicsLayer):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::reportMemoryUsage):
(WebCore):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::reportMemoryUsage):
(WebCore):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::reportMemoryUsage):
(WebCore):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::reportMemoryUsage):
(WebCore):

  • rendering/RenderInline.h:

(RenderInline):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::reportMemoryUsage):
(WebCore):

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::reportMemoryUsage):
(WebCore):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::reportMemoryUsage):
(WebCore):

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

  • rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::reportMemoryUsage):
(WebCore):

  • rendering/RenderLayerModelObject.h:

(RenderLayerModelObject):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::reportMemoryUsage):
(WebCore):

  • rendering/RenderObject.h:

(RenderObject):

  • rendering/RenderText.cpp:

(WebCore::RenderText::reportMemoryUsage):
(WebCore):

  • rendering/RenderText.h:

(RenderText):

  • rendering/RenderView.cpp:

(WebCore::RenderView::reportMemoryUsage):
(WebCore):

  • rendering/RenderView.h:

(RenderView):

9:39 PM Changeset in webkit [137107] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

REGRESSION (r137003): failures in MicroData tests on EFL, GTK
https://bugs.webkit.org/show_bug.cgi?id=104469

Reviewed by Darin Adler.

Fix the regression by calling propertyNodeList on HTMLPropertiesCollection
in the named getter for HTMLCollection. It's a miracle that the old code prior to r137003
worked at all since the return type of namedItem was different.

Existing tests cover this.

  • bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::JSHTMLCollection::nameGetter):

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::V8HTMLCollection::namedPropertyGetter):

9:09 PM Changeset in webkit [137106] by commit-queue@webkit.org
  • 38 edits in trunk/LayoutTests

[Qt] Gardening after r137006.
https://bugs.webkit.org/show_bug.cgi?id=104432

Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-09
Reviewed by Kentaro Hara.

Update existing tests that are affected by r137006.

  • compositing/rtl/rtl-iframe-absolute-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-expected.txt:
  • compositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt:
  • platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • platform/qt-5.0-wk2/compositing/overflow/content-gains-scrollbars-expected.txt:
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scrollbar-layers-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/qt/compositing/backing/no-backing-for-clip-expected.txt:
  • platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • platform/qt/compositing/backing/no-backing-for-perspective-expected.txt:
  • platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
7:58 PM Changeset in webkit [137105] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r137103.
http://trac.webkit.org/changeset/137103
https://bugs.webkit.org/show_bug.cgi?id=104503

Didn't resolve the chrome win build bot failure, problem moved
elsewhere. (Requested by noel_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-09

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::TEST_F):

7:39 PM Changeset in webkit [137104] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK1] Gardening for Accelerated Compositing
https://bugs.webkit.org/show_bug.cgi?id=104466

Unreviewed, EFL gardening.

As EFL WK1 does not support Accelerated Compositing, related cases should be skipped from layout tests.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-12-09

  • platform/efl-wk1/TestExpectations:
7:05 PM EFLWebKit edited by Seokju Kwon
Add Web Inspector in EFL (diff)
7:02 PM Changeset in webkit [137103] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] webkit_unit_tests tests are failing on win
https://bugs.webkit.org/show_bug.cgi?id=104502

Unreviewed test fix: disable applyScrollToScrollableArea test.

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::TEST_F):

5:59 PM Changeset in webkit [137102] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening: broken or flakey hardness perftests

fast/harness/perftests/runs-per-second-iterations.html
fast/harness/perftests/perf-runner-compute-statistics.html
fast/harness/perftests/runs-per-second-log.html

  • platform/chromium/TestExpectations:
5:17 PM Changeset in webkit [137101] by tkent@chromium.org
  • 1 edit in branches/chromium/1312/Source/WebCore/Resources/pagepopups/pickerCommon.js

Merge 136671

Fix flickering when hiding page popup
https://bugs.webkit.org/show_bug.cgi?id=104100

Reviewed by Kent Tamura.

Moving the page popup while hiding was causing flickering in some environments.

No new tests. Can't reproduce in layout test.

  • Resources/pagepopups/pickerCommon.js:

(hideWindow): Don't move and just resize.

TBR=keishi@webkit.org
Review URL: https://codereview.chromium.org/11488003

5:11 PM Changeset in webkit [137100] by tkent@chromium.org
  • 3 edits in branches/chromium/1312

Merge 136803

Source/WebCore: INPUT_MULTIPLE_FIELDS_UI: The hour, am/pm, millisecond fields should support read-only state correctly
https://bugs.webkit.org/show_bug.cgi?id=104210

Reviewed by Kentaro Hara.

  1. The hour, am/pm, and millisecond fields should have CSS rules for [readonly]. They should be gray when they are read-only.
  2. The am/pm field should reject to set an empty value like other numeric fields do.

Tests: Add test cases to fast/forms/time/time-appearance-basic.html.

  • css/html.css: merge existing readonly rules, and add ampm, hour, and

millisecond pseudo classes.

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::setEmptyValue):
Reject to set empty value if it is read-only.

LayoutTests: INPUT_MULTIPLE_FIELDS_UI: The hour field and the am/pm field should support read-only state correctly
https://bugs.webkit.org/show_bug.cgi?id=104210

Reviewed by Kentaro Hara.

  • fast/forms/time/time-appearance-basic.html:

Add test cases for step=86400 (24 hours)

  • platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
  • platform/chromium/TestExpectations:

TBR=tkent@chromium.org
Review URL: https://codereview.chromium.org/11503003

5:09 PM Changeset in webkit [137099] by commit-queue@webkit.org
  • 6 edits in trunk

[GTK] accessibility/placeholder.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98373

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-12-09
Reviewed by Martin Robinson.

The test was failing because the placeholder text was not supported and
AccessibilityUIElement::stringAttributeValue() was not implemented.

Source/WebCore:

No new tests; instead the failing test was unskipped.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes): Add the placeholder text as an AtkAttribute
of the AtkObject, as is done in Gtk+ 3.

Tools:

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(coreAttributeToAtkAttribute): New convenience method to convert WebCore attribute
names into AtkObject attribute names
(AccessibilityUIElement::stringAttributeValue): implemented

LayoutTests:

  • platform/gtk/TestExpectations: Unskip the failing test
2:56 PM Changeset in webkit [137098] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] [WebGL] Path is not resized correctly.
https://bugs.webkit.org/show_bug.cgi?id=104458.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-09
Reviewed by Kenneth Rohde Christiansen.

In GraphicsContext3D::paintToCanvas, we flip the contents and draw on the surface.
The operations done to flip the image (translation and scale) are done before rectangle with correct size
is added to current path. This resulted in updating pixels at wrong positions.

Covered by existing tests.

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::paintToCanvas):

2:53 PM Changeset in webkit [137097] by joone.hur@intel.com
  • 4 edits in trunk/Source/WebCore

[GTK][AC] build fix after r130525 and r133332
https://bugs.webkit.org/show_bug.cgi?id=104491

Reviewed by Martin Robinson.

Build fix for Accelerated Compositing Clutter backend after r130525 and r133332.

  • platform/graphics/clutter/GraphicsLayerClutter.cpp:
  • platform/gtk/RedirectedXCompositeWindow.cpp:
  • platform/gtk/RedirectedXCompositeWindow.h:
1:45 PM Changeset in webkit [137096] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding failure expectations for 15 layout tests that started failing after libxml2
version used in Jhbuild was bumped in r137090.

  • platform/gtk/TestExpectations:
12:43 PM Changeset in webkit [137095] by kov@webkit.org
  • 1 copy in releases/WebKitGTK/webkitgtk-1.10.2

Tagging WebKitGTK+ 1.10.2.

12:41 PM Changeset in webkit [137094] by fpizlo@apple.com
  • 18 edits
    2 adds in trunk/Source/JavaScriptCore

JSC should scale the optimization threshold for a code block according to the cost of compiling it
https://bugs.webkit.org/show_bug.cgi?id=104406

Reviewed by Oliver Hunt.

We've long known that we want to scale the execution count threshold needed for the DFG
to kick in to scale according to some estimate of the cost of compiling that code block.
This institutes a relationship like this:

threshold = thresholdSetting * (a * sqrt(instructionCount + b) + abs(c * instructionCount) + d

Where a, b, c, d are coefficients derived from fitting the above expression to various
data points, which I chose based on looking at one benchmark (3d-cube) and from my
own intuitions.

Making this work well also required changing the thresholdForOptimizeAfterLongWarmUp
from 5000 to 1000.

This is a >1% speed-up on SunSpider, a >3% speed-up on V8Spider, ~1% speed-up on V8v7,
neutral on Octane, and neutral on Kraken.

I also out-of-lined a bunch of methods related to these heuristics, because I couldn't
stand having them defined in the header anymore. I also made improvements to debugging
code because I needed it for tuning this change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::sourceCodeForTools):
(JSC::CodeBlock::sourceCodeOnOneLine):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::reoptimizationRetryCounter):
(JSC::CodeBlock::countReoptimization):
(JSC::CodeBlock::optimizationThresholdScalingFactor):
(JSC::clipThreshold):
(JSC::CodeBlock::counterValueForOptimizeAfterWarmUp):
(JSC::CodeBlock::counterValueForOptimizeAfterLongWarmUp):
(JSC::CodeBlock::counterValueForOptimizeSoon):
(JSC::CodeBlock::checkIfOptimizationThresholdReached):
(JSC::CodeBlock::optimizeNextInvocation):
(JSC::CodeBlock::dontOptimizeAnytimeSoon):
(JSC::CodeBlock::optimizeAfterWarmUp):
(JSC::CodeBlock::optimizeAfterLongWarmUp):
(JSC::CodeBlock::optimizeSoon):
(JSC::CodeBlock::adjustedExitCountThreshold):
(JSC::CodeBlock::exitCountThresholdForReoptimization):
(JSC::CodeBlock::exitCountThresholdForReoptimizationFromLoop):
(JSC::CodeBlock::shouldReoptimizeNow):
(JSC::CodeBlock::shouldReoptimizeFromLoopNow):

  • bytecode/CodeBlock.h:
  • bytecode/ExecutionCounter.cpp:

(JSC::ExecutionCounter::hasCrossedThreshold):

  • bytecode/ReduceWhitespace.cpp: Added.

(JSC::reduceWhitespace):

  • bytecode/ReduceWhitespace.h: Added.
  • dfg/DFGCapabilities.cpp:

(JSC::DFG::mightCompileEval):
(JSC::DFG::mightCompileProgram):
(JSC::DFG::mightCompileFunctionForCall):
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForConstruct):

  • dfg/DFGCapabilities.h:
  • dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::dumpHeader):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • jit/JITDisassembler.cpp:

(JSC::JITDisassembler::dumpHeader):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::entryOSR):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::ensureBytecodesFor):

  • runtime/Options.h:
12:32 PM WebInspector edited by zandobersek@gmail.com
Begone spam! (diff)
12:32 PM BadContent edited by zandobersek@gmail.com
Add a spamming mail address. (diff)
12:15 PM Changeset in webkit [137093] by Carlos Garcia Campos
  • 16 edits in trunk/Source/WebCore

[GTK] Use GObject casts instead of C++ cast for GObjects in DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=104492

Reviewed by Martin Robinson.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateCFile):

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestException.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(WebKit::kit):

11:33 AM Changeset in webkit [137092] by senorblanco@chromium.org
  • 4 edits in trunk

Source/WebKit/chromium: [Chromium] Unreviewed. Temporarily disable a webkit_unit_tests test
that's failing on Windows.

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKit::TEST_F):

LayoutTests: [Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
11:28 AM Changeset in webkit [137091] by pfeldman@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: do not treat object as equal to itself when logging to console
https://bugs.webkit.org/show_bug.cgi?id=104487

Reviewed by Alexander Pavlov.

Source/WebCore:

Otherwise, mutating object in a loop results in the repeat count update instead of generation of the new preview.

Test: inspector/console/console-object-preview.html

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::isEqual):

LayoutTests:

  • inspector/console/console-object-preview-expected.txt: Added.
  • inspector/console/console-object-preview.html: Added.
11:28 AM Changeset in webkit [137090] by danw@gnome.org
  • 2 edits in trunk/Tools

[GTK] Bump libxml2 requirement in jhbuild.modules
https://bugs.webkit.org/show_bug.cgi?id=104477

Reviewed by Martin Robinson.

Fedora 18's Apache depends on symbols in libxml2 2.9.0, so the
tests won't run if we only have libxml2 2.8.0 installed in the
jhbuild root.

  • gtk/jhbuild.modules:
11:00 AM Changeset in webkit [137089] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Remove unused code in GObject DOM bindings generator
https://bugs.webkit.org/show_bug.cgi?id=104490

Reviewed by Martin Robinson.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperties): Remove code to install event listeners and
signals.

10:55 AM Changeset in webkit [137088] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

[GTK] accessibility/canvas-fallback-content.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98362

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-12-09
Reviewed by Martin Robinson.

The failure was due to platform-specific expectations of the accessible
role reported for comboboxes. The solution was conditionalizing the test.

  • accessibility/canvas-fallback-content.html: Base expected role on platform.
  • platform/gtk/TestExpectations: Unskipped the test.
  • platform/gtk/accessibility/canvas-fallback-content-expected.txt: Added.
10:40 AM Changeset in webkit [137087] by kov@webkit.org
  • 4 edits in releases/WebKitGTK/webkit-1.10

Patch by Gustavo Noronha on 2012-12-09
Reviewed by Martin Robinson.

Update configure.ac and the NEWS in preparation for the 1.10.2 release.

10:39 AM Changeset in webkit [137086] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.10/Source/WebKit/gtk

Merge 132363 - [GTK] Typos in user-visible strings: "coordintate"
https://bugs.webkit.org/show_bug.cgi?id=100252

Patch by Priit Laes <plaes@plaes.org> on 2012-10-24
Reviewed by Martin Robinson.

s/coordintate/coordinate

  • webkit/webkithittestresult.cpp:

(webkit_hit_test_result_class_init):

10:39 AM Changeset in webkit [137085] by kov@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.10/Source/WebCore

Merge 131478 - [GStreamer] GstBuffer ref race in WebKitWebAudioSrcLoop
https://bugs.webkit.org/show_bug.cgi?id=95833

Reviewed by Philippe Normand.

The render bus used in GStreamer's implementation of AudioDestination no longer
allocates memory for each of its channels. Rather than that, when looping, the
data is rendered into a channel-specific GstBuffer. Each buffer is then chained
to the appropriate GstPad, as has been the case before.

No new tests - there are tests covering this change but they are not yet working
on the GTK port or any other GStreamer implementation of Web Audio.

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(_WebKitWebAudioSourcePrivate): Remove an unused member variable.
(webkit_web_audio_src_init): Remove an unnecessary line.
(webKitWebAudioSrcConstructed): Ditto.
(webKitWebAudioSrcLoop):

10:38 AM Changeset in webkit [137084] by kov@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-1.10/Source/WebCore

Merge 131755 - [GTK] AudioBusGtk sometimes fails to load the HRTF database
https://bugs.webkit.org/show_bug.cgi?id=99601

Reviewed by Martin Robinson.

AudioBusGtk now first lookup for the uninstalled resource files,
if the AUDIO_RESOURCES_PATH environment variable is
set. Additionally the audio file reader is now better dealing with
errors, returning an empty AudioBus in such cases and issuing
warnings on the console output. The cleanup of some member
variables was also moved to the destructor.

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(AudioFileReader):
(WebCore::AudioFileReader::AudioFileReader):
(WebCore::AudioFileReader::~AudioFileReader): Clear and free
member variables. This was done in createBus before.
(WebCore::AudioFileReader::handleMessage): Issue warnings in case
of error and exit from the main loop so the pipeline is not
forever stuck.
(WebCore::AudioFileReader::createBus): Return an empty bus in case
of error.

  • platform/audio/gtk/AudioBusGtk.cpp:

(WebCore::AudioBus::loadPlatformResource): Load uninstalled
resources first if AUDIO_RESOURCES_PATH is set.

10:25 AM WebKitGTK/1.10.x edited by kov@webkit.org
(diff)
10:22 AM WebKitGTK edited by kov@webkit.org
(diff)
10:20 AM Changeset in webkit [137083] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
10:19 AM Changeset in webkit [137082] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebCore

Unreviewed update for the GObject bindings after r137074 and r137078.

  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:

(webkit_dom_test_event_target_dispatch_event):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(webkit_dom_test_interface_supplemental_method2):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_method_that_requires_all_args_and_throws):
(webkit_dom_test_obj_method_with_exception):
(webkit_dom_test_obj_with_script_state_void_exception):
(webkit_dom_test_obj_with_script_state_obj_exception):
(webkit_dom_test_obj_with_script_execution_context_and_script_state_obj_exception):
(webkit_dom_test_obj_strict_function):
(webkit_dom_test_obj_get_attr_with_getter_exception):
(webkit_dom_test_obj_set_attr_with_setter_exception):
(webkit_dom_test_obj_get_string_attr_with_getter_exception):
(webkit_dom_test_obj_set_string_attr_with_setter_exception):
(webkit_dom_test_obj_get_with_script_state_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_attribute_raises):

10:16 AM Changeset in webkit [137081] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
10:14 AM Changeset in webkit [137080] by zandobersek@gmail.com
  • 11 edits in trunk/Tools

Remove testRunner.disableImageLoading()
https://bugs.webkit.org/show_bug.cgi?id=98083

Reviewed by Gustavo Noronha Silva.

Remove the disableImageLoading methods and callback.
No tests use the method anymore and all ports except Wx
now support this behavior through overriding the
WebKitDisplayImagesKey preference.

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:

(TestRunner::overridePreference): Add support for overriding the
WebKitDisplayImagesKey preference which is now the preferred way
of disabling image loading.

  • DumpRenderTree/efl/TestRunnerEfl.cpp:
  • DumpRenderTree/gtk/TestRunnerGtk.cpp:
  • DumpRenderTree/mac/TestRunnerMac.mm:
  • DumpRenderTree/qt/TestRunnerQt.cpp:
  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

  • DumpRenderTree/win/TestRunnerWin.cpp:
  • DumpRenderTree/wx/TestRunnerWx.cpp:
9:55 AM WebKitGTK/1.10.x edited by kov@webkit.org
Striking the commits that have been merged (diff)
9:48 AM Changeset in webkit [137079] by senorblanco@chromium.org
  • 4 edits in trunk/LayoutTests

Try to fix a finnicky reftest.
https://bugs.webkit.org/show_bug.cgi?id=104486

Reviewed by Simon Fraser.

This reftest fails on Chromium Mac since the leftmost pixel of the 'T'
of 'Text' is clipped in composited mode, and non-clipped in software
painting. Not sure exactly why, but a lowercase 't' doesn't seem to
have this problem.

  • compositing/background-color/background-color-change-to-text-expected.html:
  • compositing/background-color/background-color-change-to-text.html:
  • platform/chromium-mac/compositing/background-color/background-color-change-to-text-expected.png: Removed.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/background-color/background-color-change-to-text-expected.png: Removed.
  • platform/chromium/TestExpectations:
9:34 AM Changeset in webkit [137078] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Fix the GError check in GObject DOM bindings.

Reviewed by Xan Lopez.

Previous commit introduced a check to make sure the passed GError
is valid in all DOM methods receiving an error.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GetGReturnMacro): Check that the passed GError either is NULL or
the pointer has been initialized to NULL.

9:10 AM Changeset in webkit [137077] by kov@webkit.org
  • 5 edits in releases/WebKitGTK/webkit-1.10

Merge 133610 - Heap-buffer-overflow in WebCore::TextTrackCueList::add
https://bugs.webkit.org/show_bug.cgi?id=101018

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-11-06
Reviewed by Eric Carlson.

Source/WebCore:

Added an extra check to avoid using a negative array index when a cue
is added to the beginning of the list.

Test case added to LayoutTests/media/track/track-add-remove-cue.html.

  • html/track/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::add):

LayoutTests:

Added a test case to verify that adding a cue to the beginning of a non-empty list doesn't crash.

  • media/track/track-add-remove-cue-expected.txt:
  • media/track/track-add-remove-cue.html:
8:36 AM Changeset in webkit [137076] by senorblanco@chromium.org
  • 2 edits
    40 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/chromium-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
  • platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-expected.txt: Added.
  • platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
  • platform/chromium/compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
  • platform/chromium/compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
  • platform/chromium/compositing/rtl/rtl-iframe-relative-expected.txt: Added.
8:30 AM Changeset in webkit [137075] by leoyang@rim.com
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Adapt to name change of createNetworkBufferByCopyingData()
https://bugs.webkit.org/show_bug.cgi?id=104449

Reviewed by Rob Buis.

Name change no new tests.

  • platform/network/blackberry/rss/RSSFilterStream.cpp:

(WebCore::RSSFilterStream::handleRSSContent):

8:17 AM Changeset in webkit [137074] by Carlos Garcia Campos
  • 16 edits in trunk/Source/WebCore

[GTK] Clean up g_return macros usage in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=101079

Reviewed by Xan Lopez.

Several improvements:

  • Move g_return macros at the beginning of the methods.
  • Use them only to check parameters of public API.
  • Use GObject macros to check GObjects.
  • Check also GError parameters.
  • Use early returns in kit and core methods, since they should work even if g_return macros are disabled handling NULL gracefully.
  • bindings/scripts/CodeGeneratorGObject.pm:

(GetGReturnMacro):
(GenerateFunction):
(GenerateCFile):
(Generate):

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapFloat64Array):
(webkit_dom_float64array_foo):

  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestActiveDOMObject):
(webkit_dom_test_active_dom_object_exciting_function):
(webkit_dom_test_active_dom_object_post_message):
(webkit_dom_test_active_dom_object_get_exciting_attr):

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestCallback):
(webkit_dom_test_callback_callback_with_no_param):
(webkit_dom_test_callback_callback_with_class1param):
(webkit_dom_test_callback_callback_with_class2param):
(webkit_dom_test_callback_callback_with_non_bool_return_type):
(webkit_dom_test_callback_callback_with_string_list):
(webkit_dom_test_callback_callback_with_boolean):
(webkit_dom_test_callback_callback_requires_this_to_pass):

  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestCustomNamedGetter):
(webkit_dom_test_custom_named_getter_another_function):

  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestEventConstructor):
(webkit_dom_test_event_constructor_get_attr1):
(webkit_dom_test_event_constructor_get_attr2):

  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestEventTarget):
(webkit_dom_test_event_target_item):
(webkit_dom_test_event_target_dispatch_event):

  • bindings/scripts/test/GObject/WebKitDOMTestException.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestException):
(webkit_dom_test_exception_get_name):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestInterface):
(webkit_dom_test_interface_supplemental_method1):
(webkit_dom_test_interface_supplemental_method2):
(webkit_dom_test_interface_supplemental_method4):
(webkit_dom_test_interface_get_supplemental_str1):
(webkit_dom_test_interface_get_supplemental_str2):
(webkit_dom_test_interface_set_supplemental_str2):
(webkit_dom_test_interface_get_supplemental_node):
(webkit_dom_test_interface_set_supplemental_node):

  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestMediaQueryListListener):

  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestNamedConstructor):

  • bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestNode):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestObj):
(webkit_dom_test_obj_void_method):
(webkit_dom_test_obj_void_method_with_args):
(webkit_dom_test_obj_long_method):
(webkit_dom_test_obj_long_method_with_args):
(webkit_dom_test_obj_obj_method):
(webkit_dom_test_obj_obj_method_with_args):
(webkit_dom_test_obj_method_that_requires_all_args_and_throws):
(webkit_dom_test_obj_serialized_value):
(webkit_dom_test_obj_idb_key):
(webkit_dom_test_obj_options_object):
(webkit_dom_test_obj_method_with_exception):
(webkit_dom_test_obj_with_script_state_void):
(webkit_dom_test_obj_with_script_state_obj):
(webkit_dom_test_obj_with_script_state_void_exception):
(webkit_dom_test_obj_with_script_state_obj_exception):
(webkit_dom_test_obj_with_script_execution_context):
(webkit_dom_test_obj_with_script_execution_context_and_script_state):
(webkit_dom_test_obj_with_script_execution_context_and_script_state_obj_exception):
(webkit_dom_test_obj_with_script_execution_context_and_script_state_with_spaces):
(webkit_dom_test_obj_method_with_optional_arg):
(webkit_dom_test_obj_method_with_non_optional_arg_and_optional_arg):
(webkit_dom_test_obj_method_with_non_optional_arg_and_two_optional_args):
(webkit_dom_test_obj_method_with_optional_string):
(webkit_dom_test_obj_method_with_optional_string_is_undefined):
(webkit_dom_test_obj_method_with_optional_string_is_null_string):
(webkit_dom_test_obj_conditional_method1):
(webkit_dom_test_obj_conditional_method2):
(webkit_dom_test_obj_conditional_method3):
(webkit_dom_test_obj_class_method):
(webkit_dom_test_obj_class_method_with_optional):
(webkit_dom_test_obj_overloaded_method1):
(webkit_dom_test_obj_convert1):
(webkit_dom_test_obj_convert2):
(webkit_dom_test_obj_convert4):
(webkit_dom_test_obj_convert5):
(webkit_dom_test_obj_mutable_point_function):
(webkit_dom_test_obj_immutable_point_function):
(webkit_dom_test_obj_orange):
(webkit_dom_test_obj_strict_function):
(webkit_dom_test_obj_variadic_string_method):
(webkit_dom_test_obj_variadic_double_method):
(webkit_dom_test_obj_variadic_node_method):
(webkit_dom_test_obj_get_read_only_long_attr):
(webkit_dom_test_obj_get_read_only_string_attr):
(webkit_dom_test_obj_get_read_only_test_obj_attr):
(webkit_dom_test_obj_get_short_attr):
(webkit_dom_test_obj_set_short_attr):
(webkit_dom_test_obj_get_unsigned_short_attr):
(webkit_dom_test_obj_set_unsigned_short_attr):
(webkit_dom_test_obj_get_long_attr):
(webkit_dom_test_obj_set_long_attr):
(webkit_dom_test_obj_get_long_long_attr):
(webkit_dom_test_obj_set_long_long_attr):
(webkit_dom_test_obj_get_unsigned_long_long_attr):
(webkit_dom_test_obj_set_unsigned_long_long_attr):
(webkit_dom_test_obj_get_string_attr):
(webkit_dom_test_obj_set_string_attr):
(webkit_dom_test_obj_get_test_obj_attr):
(webkit_dom_test_obj_set_test_obj_attr):
(webkit_dom_test_obj_get_xml_obj_attr):
(webkit_dom_test_obj_set_xml_obj_attr):
(webkit_dom_test_obj_get_create):
(webkit_dom_test_obj_set_create):
(webkit_dom_test_obj_get_reflected_string_attr):
(webkit_dom_test_obj_set_reflected_string_attr):
(webkit_dom_test_obj_get_reflected_integral_attr):
(webkit_dom_test_obj_set_reflected_integral_attr):
(webkit_dom_test_obj_get_reflected_unsigned_integral_attr):
(webkit_dom_test_obj_set_reflected_unsigned_integral_attr):
(webkit_dom_test_obj_get_reflected_boolean_attr):
(webkit_dom_test_obj_set_reflected_boolean_attr):
(webkit_dom_test_obj_get_reflected_url_attr):
(webkit_dom_test_obj_set_reflected_url_attr):
(webkit_dom_test_obj_get_reflected_custom_integral_attr):
(webkit_dom_test_obj_set_reflected_custom_integral_attr):
(webkit_dom_test_obj_get_reflected_custom_boolean_attr):
(webkit_dom_test_obj_set_reflected_custom_boolean_attr):
(webkit_dom_test_obj_get_reflected_custom_url_attr):
(webkit_dom_test_obj_set_reflected_custom_url_attr):
(webkit_dom_test_obj_get_attr_with_getter_exception):
(webkit_dom_test_obj_set_attr_with_getter_exception):
(webkit_dom_test_obj_get_attr_with_setter_exception):
(webkit_dom_test_obj_set_attr_with_setter_exception):
(webkit_dom_test_obj_get_string_attr_with_getter_exception):
(webkit_dom_test_obj_set_string_attr_with_getter_exception):
(webkit_dom_test_obj_get_string_attr_with_setter_exception):
(webkit_dom_test_obj_set_string_attr_with_setter_exception):
(webkit_dom_test_obj_get_with_script_state_attribute):
(webkit_dom_test_obj_set_with_script_state_attribute):
(webkit_dom_test_obj_get_with_script_execution_context_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_attribute):
(webkit_dom_test_obj_get_with_script_state_attribute_raises):
(webkit_dom_test_obj_set_with_script_state_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_attribute_raises):
(webkit_dom_test_obj_set_with_script_execution_context_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_attribute):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_attribute_raises):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_and_script_state_with_spaces_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_and_script_state_with_spaces_attribute):
(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_get_any_attribute):
(webkit_dom_test_obj_set_any_attribute):
(webkit_dom_test_obj_get_content_document):
(webkit_dom_test_obj_get_mutable_point):
(webkit_dom_test_obj_set_mutable_point):
(webkit_dom_test_obj_get_immutable_point):
(webkit_dom_test_obj_set_immutable_point):
(webkit_dom_test_obj_get_strawberry):
(webkit_dom_test_obj_set_strawberry):
(webkit_dom_test_obj_get_strict_float):
(webkit_dom_test_obj_set_strict_float):
(webkit_dom_test_obj_get_description):
(webkit_dom_test_obj_get_id):
(webkit_dom_test_obj_set_id):
(webkit_dom_test_obj_get_hash):
(webkit_dom_test_obj_get_replaceable_attribute):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestSerializedScriptValueInterface):
(webkit_dom_test_serialized_script_value_interface_accept_transfer_list):
(webkit_dom_test_serialized_script_value_interface_multi_transfer_list):
(webkit_dom_test_serialized_script_value_interface_get_value):
(webkit_dom_test_serialized_script_value_interface_set_value):
(webkit_dom_test_serialized_script_value_interface_get_readonly_value):
(webkit_dom_test_serialized_script_value_interface_get_cached_value):
(webkit_dom_test_serialized_script_value_interface_set_cached_value):
(webkit_dom_test_serialized_script_value_interface_get_ports):
(webkit_dom_test_serialized_script_value_interface_get_cached_readonly_value):

7:56 AM Changeset in webkit [137073] by mihnea@adobe.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Unskip a skipped test for which i have added expectation in http://trac.webkit.org/changeset/135851.

  • platform/gtk-wk2/TestExpectations:
7:48 AM Changeset in webkit [137072] by Carlos Garcia Campos
  • 17 edits in trunk/Source/WebCore

[GTK] Use a private struct and placement new syntax in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=101074

Reviewed by Xan Lopez.

It allows to use RefPtr for the wrapped object and it simplifies
the code. Only the classes deriving from WebKitDOMObject keep a
reference of the wrapped object in a private struct. The wrapped
object is added to the cache in GObjectClass::constructor() and
removed in GObjectClass::finalize().

  • bindings/gobject/WebKitDOMBinding.cpp:

(WebKit::createWrapper):
(WebKit::kit):
(WebKit::wrapEventTarget):

  • bindings/scripts/CodeGeneratorGObject.pm:

(GetParentImplClassName):
(GenerateProperties):
(GenerateCFile):
(Generate):
(WriteData):

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapFloat64Array):
(webkit_dom_float64array_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:

(_WebKitDOMTestActiveDOMObjectPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestActiveDOMObject):
(webkit_dom_test_active_dom_object_finalize):
(webkit_dom_test_active_dom_object_constructor):
(webkit_dom_test_active_dom_object_class_init):
(webkit_dom_test_active_dom_object_init):

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:

(_WebKitDOMTestCallbackPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestCallback):
(webkit_dom_test_callback_finalize):
(webkit_dom_test_callback_constructor):
(webkit_dom_test_callback_class_init):
(webkit_dom_test_callback_init):

  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:

(_WebKitDOMTestCustomNamedGetterPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestCustomNamedGetter):
(webkit_dom_test_custom_named_getter_finalize):
(webkit_dom_test_custom_named_getter_constructor):
(webkit_dom_test_custom_named_getter_class_init):
(webkit_dom_test_custom_named_getter_init):

  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:

(_WebKitDOMTestEventConstructorPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestEventConstructor):
(webkit_dom_test_event_constructor_finalize):
(webkit_dom_test_event_constructor_constructor):
(webkit_dom_test_event_constructor_class_init):
(webkit_dom_test_event_constructor_init):

  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:

(_WebKitDOMTestEventTargetPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestEventTarget):
(webkit_dom_test_event_target_finalize):
(webkit_dom_test_event_target_constructor):
(webkit_dom_test_event_target_class_init):
(webkit_dom_test_event_target_init):

  • bindings/scripts/test/GObject/WebKitDOMTestException.cpp:

(_WebKitDOMTestExceptionPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestException):
(webkit_dom_test_exception_finalize):
(webkit_dom_test_exception_constructor):
(webkit_dom_test_exception_class_init):
(webkit_dom_test_exception_init):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:

(_WebKitDOMTestInterfacePrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestInterface):
(webkit_dom_test_interface_finalize):
(webkit_dom_test_interface_constructor):
(webkit_dom_test_interface_class_init):
(webkit_dom_test_interface_init):

  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:

(_WebKitDOMTestMediaQueryListListenerPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestMediaQueryListListener):
(webkit_dom_test_media_query_list_listener_finalize):
(webkit_dom_test_media_query_list_listener_constructor):
(webkit_dom_test_media_query_list_listener_class_init):
(webkit_dom_test_media_query_list_listener_init):

  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:

(_WebKitDOMTestNamedConstructorPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestNamedConstructor):
(webkit_dom_test_named_constructor_finalize):
(webkit_dom_test_named_constructor_constructor):
(webkit_dom_test_named_constructor_class_init):
(webkit_dom_test_named_constructor_init):

  • bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestNode):
(webkit_dom_test_node_class_init):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(_WebKitDOMTestObjPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestObj):
(webkit_dom_test_obj_finalize):
(webkit_dom_test_obj_constructor):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_init):

  • bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:

(_WebKitDOMTestOverloadedConstructorsPrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestOverloadedConstructors):
(webkit_dom_test_overloaded_constructors_finalize):
(webkit_dom_test_overloaded_constructors_constructor):
(webkit_dom_test_overloaded_constructors_class_init):
(webkit_dom_test_overloaded_constructors_init):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(_WebKitDOMTestSerializedScriptValueInterfacePrivate):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestSerializedScriptValueInterface):
(webkit_dom_test_serialized_script_value_interface_finalize):
(webkit_dom_test_serialized_script_value_interface_constructor):
(webkit_dom_test_serialized_script_value_interface_class_init):
(webkit_dom_test_serialized_script_value_interface_init):

5:26 AM Changeset in webkit [137071] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] accessibility/label-for-control-hittest.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98368

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-12-09
Reviewed by Martin Robinson.

Tools:

The test was failing because AccessibilityUIElement::elementAtPoint was
not implemented.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::elementAtPoint): implemented

LayoutTests:

Unskip the test having implemented AccessibilityUIElement::elementAtPoint.

  • platform/gtk/TestExpectations: unskip accessibility/label-for-control-hittest.html
3:41 AM Changeset in webkit [137070] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark 2 compositing/background-color ref tests introduced
in r137006 as failing for WK2 EFL.

  • platform/efl-wk2/TestExpectations:
3:22 AM Changeset in webkit [137069] by Christophe Dumez
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline 2 media/track test cases after r136991.

  • platform/efl/media/track/track-cue-rendering-horizontal-expected.txt:
  • platform/efl/media/track/track-cue-rendering-vertical-expected.txt:
3:06 AM Changeset in webkit [137068] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark inspector/styles/import-pseudoclass-crash.html as crashing
since it is hitting m_childRuleCSSOMWrappers.size() == ruleCount
assertion after r136948.

  • platform/efl-wk2/TestExpectations:
2:43 AM Changeset in webkit [137067] by jonlee@apple.com
  • 15 edits
    2 deletes in trunk

[WK2] Move button image to injected bundle
https://bugs.webkit.org/show_bug.cgi?id=104107
<rdar://problem/12813842>

Reviewed by Simon Fraser.

Source/WebCore:

Update RenderSnapshottedPlugIn to retrieve the start button image from the ChromeClient. Expand the
kinds of images available for use as the button. Try to find the best sized button to use for the plug-in,
otherwise use no image at all.

  • rendering/RenderSnapshottedPlugIn.h: Add an enum representing the size to use. Remove the label rect

variable since it is unneeded.

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::startLabelImage): Maintain a cache of the images for reuse. Index into the
array using the enum. If the image has been loaded, or an attempt was made, then return the result. Otherwise
ask the chrome client for the image.
(WebCore::RenderSnapshottedPlugIn::paintLabel): Determine the proper label to use, and paint if the image is
available.
(WebCore::RenderSnapshottedPlugIn::tryToFitStartLabel): Compare the label size with the provided content
box. Return a LayoutRect representing the label's placement. If it doesn't fit, return an empty rect.
(WebCore::RenderSnapshottedPlugIn::layout): The rect is not needed because it is all determined at paint time.

  • page/ChromeClient.h:

(WebCore::ChromeClient::plugInStartLabelImage): Added.

  • WebCore.exp.in: Expose GraphicsContext::drawNativeImage() for WKImageCG.cpp.
  • WebCore.xcodeproj/project.pbxproj: Remove start button assets.
  • Resources/startButton.png: Removed.
  • Resources/startButton@2x.png: Removed.

Source/WebKit2:

Rely on the injected bundle to create the image used for the button in snapshotted plug-ins.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::plugInStartLabelImage): Forward the call to the injected bundle UI client.

  • WebProcess/WebCoreSupport/WebChromeClient.h: Implement plugInStartLabelImage().
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::plugInStartLabelImage): Convert the WebCore enums to WK API enums.

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h: Expose a new callback to generate the button image.
  • Shared/API/c/cg/WKImageCG.cpp:

(WKImageCreateFromCGImage): Refactor to use GraphicsContext methods so that the image is flipped appropriately.

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage): Update the bundle page UI client.

2:39 AM Changeset in webkit [137066] by Christophe Dumez
  • 2 edits
    2 deletes in trunk/LayoutTests

Unreviewed EFL gardening.

Skip fast/text/hyphenate-locale.html since the EFL port does
not support hyphenation. Also remove wrong expected results
for WK1 EFL.

  • platform/efl-wk1/fast/text/hyphenate-locale-expected.png: Removed.
  • platform/efl-wk1/fast/text/hyphenate-locale-expected.txt: Removed.
  • platform/efl/TestExpectations:
2:28 AM Changeset in webkit [137065] by Christophe Dumez
  • 10 edits in trunk/LayoutTests

Unreviewing gardening.

Rebaseline several compositing test cases after r137051.

  • compositing/iframes/overlapped-nested-iframes-expected.txt:
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-iframe-absolute-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-expected.txt:
  • compositing/rtl/rtl-iframe-relative-expected.txt:
  • compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
1:59 AM Changeset in webkit [137064] by commit-queue@webkit.org
  • 15 edits in trunk

Unreviewed, rolling out r137053.
http://trac.webkit.org/changeset/137053
https://bugs.webkit.org/show_bug.cgi?id=104471

Broke PerformanceTests/Parser/html-parser.html (Requested by
mkwst_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-09

Source/WebCore:

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):

LayoutTests:

  • fast/frames/sandboxed-iframe-attribute-parsing-expected.txt:
  • fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
  • fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
  • fast/frames/sandboxed-iframe-scripting-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-invalid-header-expected.txt:
  • http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
  • http/tests/security/sandbox-inherit-to-initial-document-2-expected.txt:
  • media/video-controls-no-scripting-expected.txt:
1:54 AM Changeset in webkit [137063] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline fast/js/global-constructors.html after WebGL
was enabled for EFL port in r137050.

  • platform/efl/fast/js/global-constructors-expected.txt:
1:42 AM Changeset in webkit [137062] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Adding failure expectation for several MicroData test cases
that started failing after r137003.

  • platform/efl/TestExpectations:
1:24 AM Changeset in webkit [137061] by kov@webkit.org
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-1.10

Merge 133717 - Crash due to column span under button element
https://bugs.webkit.org/show_bug.cgi?id=101402

Reviewed by Abhishek Arya.

Source/WebCore:

When there is a column-spanning child of a RenderButton
splitBlocks() must split the RenderButton as well as its
only permitted direct child, the anonymous block referenced
by m_inner. A crash was occurring because splitBlocks()
calls addChildIgnoringAnonymousColumnBlocks() to add the
cloned m_inner to the cloned RenderButton, which meant the
m_inner for the cloned RenderButton was not being set even
though a child was being added. This violates state
assumptions in the RenderButton code.

This patch prevents any descendants of RenderButton from
spanning columns. Also, it adds a precautionary check in
RenderButton::removeChild() to mitigate problems if similar
state problems are found in future.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::containingColumnsBlock):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::removeChild):

LayoutTests:

Test creates crashing condition for bug 101402.

  • fast/block/colspan-under-button-crash.html: Added.
  • fast/block/colspan-under-button-crash-expected.txt: Added.
1:18 AM Changeset in webkit [137060] by kov@webkit.org
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-1.10

Merge 132983 - Delaying 'change' and 'input' event dispatching during HTMLInputElement::setValue
https://bugs.webkit.org/show_bug.cgi?id=100772

Reviewed by Abhishek Arya.

Source/WebCore:

'change' and 'input' events are asynchronous and not
cancelable. We can use ScopedEvent.

Test: fast/forms/range/range-type-change-onchange.html

  • dom/Node.cpp:

(WebCore::Node::dispatchChangeEvent): Use dispatchScopedEvent.
(WebCore::Node::dispatchInputEvent): Ditto.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue):
Make a scope to delay event dispatching.

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent): Ditto.

LayoutTests:

  • fast/forms/range/range-type-change-onchange-expected.txt: Added.
  • fast/forms/range/range-type-change-onchange.html: Added.
1:04 AM Changeset in webkit [137059] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a failure expectation for an accelerated compositing layout test introduced in r136959.
Adding failure expectations for MicroData layout tests that regressed in r137003.

  • platform/gtk/TestExpectations:
12:13 AM Changeset in webkit [137058] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Fix unused parameter compile warnings
https://bugs.webkit.org/show_bug.cgi?id=104463

Patch by Kangil Han <kangil.han@samsung.com> on 2012-12-09
Reviewed by Kentaro Hara.

Remove compile warning messages by omitting parameter name.

Source/WebCore:

  • platform/graphics/surfaces/GraphicsSurface.cpp:

(WebCore::GraphicsSurface::GraphicsSurface):

Source/WebKit2:

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::createCanvas):

Dec 8, 2012:

11:46 PM Changeset in webkit [137057] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Tools

[CMake] Add CMake style checker
https://bugs.webkit.org/show_bug.cgi?id=104240

Patch by Halton Huo <halton.huo@intel.com> on 2012-12-08
Reviewed by Eric Seidel.

The CMake style checker is followed by existing style checkers like cpp, python.
Unit test is added as well.

  • Scripts/webkitpy/style/checker.py: Use CMakeChecker CMAKE type files(.cmake or CMakeLists.txt)

(FileType):
(CheckerDispatcher._file_type):
(CheckerDispatcher._create_checker):

  • Scripts/webkitpy/style/checkers/cmake.py: Added.

(CMakeChecker):
(CMakeChecker.init):
(CMakeChecker.check):
(CMakeChecker._process_line):
(CMakeChecker._check_trailing_whitespace):
(CMakeChecker._check_no_space_cmds):
(CMakeChecker._check_one_space_cmds):
(CMakeChecker._check_non_lowercase_cmd):
(CMakeChecker._check_indent):

  • Scripts/webkitpy/style/checkers/cmake_unittest.py: Added.

(CMakeCheckerTest):
(CMakeCheckerTest.test_init):
(CMakeCheckerTest.test_init._mock_handle_style_error):
(CMakeCheckerTest.test_check):
(CMakeCheckerTest.test_check._mock_handle_style_error):

9:48 PM Changeset in webkit [137056] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK1] Gardening for WebGL
https://bugs.webkit.org/show_bug.cgi?id=104464

Unreviewed, EFL gardening.

As EFL WK1 does not support WebGL, it should be skipped from layout tests.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-12-08

  • platform/efl-wk1/TestExpectations:
7:02 PM Changeset in webkit [137055] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Build break if SVG is disabled
https://bugs.webkit.org/show_bug.cgi?id=104452

Patch by Rakesh KN <rakeshchaitan@gmail.com> on 2012-12-08
Reviewed by Darin Adler.

Build breaking after r136975 if SVG is disabled.
No new tests required.

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter):
As document is not an argument anymore, removing UNUSED_PARAM against it.

  • rendering/FilterEffectRenderer.h:

Added forward declaration for RenderObject.

6:30 PM Changeset in webkit [137054] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

Compiling WTF outside of WebKit failed on Windows
https://bugs.webkit.org/show_bug.cgi?id=100201

Reviewed by Darin Adler.

Explicitly use the Unicode variants of the Windows API to
allow building the WTF library without the UNICODE define.

  • wtf/win/MainThreadWin.cpp:

(WTF::initializeMainThreadPlatform):

5:54 PM Changeset in webkit [137053] by mkwst@chromium.org
  • 15 edits in trunk

Log to console when script is blocked by sandbox attributes.
https://bugs.webkit.org/show_bug.cgi?id=104365

Reviewed by Ojan Vafai.

Source/WebCore:

Adds a console message to cover script execution blocked within the
context of a sandboxed frame which lacks the 'allow-scripts' permission.

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):

Log a warning when sandboxing flags block script execution.

LayoutTests:

  • fast/frames/sandboxed-iframe-attribute-parsing-expected.txt:
  • fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
  • fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
  • fast/frames/sandboxed-iframe-scripting-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-invalid-header-expected.txt:
  • http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
  • http/tests/security/sandbox-inherit-to-initial-document-2-expected.txt:
  • media/video-controls-no-scripting-expected.txt:

Rebaselining tests with new expectations.

4:03 PM Changeset in webkit [137052] by tkent@chromium.org
  • 2 edits
    7 adds in trunk/LayoutTests

Add appearance tests for input[type=datetime-local]
https://bugs.webkit.org/show_bug.cgi?id=104439

Reviewed by Kentaro Hara.

  • fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.txt: Added.
  • fast/forms/datetimelocal/datetimelocal-appearance-basic.html: Added.
  • fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.txt: Added.
  • fast/forms/datetimelocal/datetimelocal-appearance-l10n.html: Added.
  • platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png: Added.
  • platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:

Added.
The placeholder strings "yyyy" "mm" "dd" are expected to be
non-localized because they don't support
setLangAttributeAwareFormControlUIEnabled(true).
Note that sub-fields order of filled-outs input and empty inputs
in ar-eg and he-il locales are mismatched. It will be addressed in
webkit.org/b/104438.

  • platform/chromium/TestExpectations:
3:46 PM Changeset in webkit [137051] by commit-queue@webkit.org
  • 90 edits
    38 copies
    20 adds in trunk

Use background color for GraphicsLayers when applicable
https://bugs.webkit.org/show_bug.cgi?id=103786

Source/WebCore:

Updated RenderLayerBacking to call GraphicsLayer::setContentsToBackgroundColor when the following conditions take place:

  1. The layer doesn't paint its own content, other than background/decoration.
  2. There are no borders or other box decorations (border radius, borders, outline, shadow etc.)
  3. The image has only a background color, and no background image.
  4. background-composite is set to source-over, and background-clip is anything apart from text.
  5. The port supports setContentsToBackgroundColor.

This allows any implementation of GraphicsLayer that supports setContentsToBackgroundColor to avoid allocating a backing store
for that layer, but instead draw that solid color directly.
In addition to setting the background color, the layer's contentsRect needs to be adjusted, since the default contents rect of
a layer is not always equivalent to the rect where the background is supposed to be painted, which is derived from the box's
background-clip property.

Patch by No'am Rosenthal <Noam Rosenthal> on 2012-12-08
Reviewed by Simon Fraser.

Tests: compositing/background-color/background-color-alpha.html

compositing/background-color/background-color-change-to-text.html
compositing/background-color/background-color-composite.html
compositing/background-color/background-color-container.html
compositing/background-color/background-color-content-clip.html
compositing/background-color/background-color-padding-change.html
compositing/background-color/background-color-padding-clip.html
compositing/background-color/background-color-simple.html
compositing/background-color/background-color-text-change.html
compositing/background-color/background-color-text-clip.html

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::supportsBackgroundColorContent):

Allows different implementation of GraphicsLayer to identify whether they implement setContentsToBackgroundColor.
Currently only the MAC implementation and TextureMapper falls under that category.

  • rendering/RenderBox.h:

(WebCore::RenderBox::paddingBoxRect):

Added paddingBoxRect to compliment borderBoxRect and contentsBoxRect. paddingBoxRect corresponds to
background-clip: padding.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):

Update the background color if needed, for every configuration change.
This should accomodate the old behavior for full-screen, while enabling background color changes for other layers.

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

Move the contentsRect logic to updateContentsRect.

(WebCore::RenderLayerBacking::updateContentsRect):

Use the background box when directly compositing backgrounds.

(WebCore::RenderLayerBacking::updateBackgroundColor):

Set the background color if applicable, otherwise set to trasnparent and clear.
This was not needed in the past because background colors were only used for the special case of full-screen.

(WebCore::supportsDirectBoxDecorationsComposition):

Helper function to determine whether a particular background can be directly composited. Right now only
background color can be composited, and only if the GraphicsLayer implementation supports background colors.
Also we don't yet support background-clip: text and any background-composite other than source-over.

(WebCore::RenderLayerBacking::paintsBoxDecorations):

Apply the new supportsDirectBoxDecorationsComposition logic.

(WebCore::RenderLayerBacking::contentsBox):

Remove unnecessary local variable.

(WebCore::backgroundRectForBox):
(WebCore::RenderLayerBacking::backgroundBox):

Figure out the correct rect for the GraphicsLayer's contentsRect, based on the renderer's backgroundClip.
The rectangle has to be adjusted based on the composited layer offset, and snapped to an IntRect as
GraphicsLayer::contentsRect expects snapped pixels.

LayoutTests:

Created new tests for composited background colors, update existing tests that are affected by the change,
and created platform-specific overrides for Chromium, since it does not yet support composited background
colors.

Patch by No'am Rosenthal <Noam Rosenthal> on 2012-12-08
Reviewed by Simon Fraser.

  • compositing/background-color/background-color-alpha-expected.html: Added.
  • compositing/background-color/background-color-alpha.html: Added.
  • compositing/background-color/background-color-change-to-text-expected.html: Added.
  • compositing/background-color/background-color-change-to-text.html: Added.
  • compositing/background-color/background-color-composite-expected.html: Added.
  • compositing/background-color/background-color-composite.html: Added.
  • compositing/background-color/background-color-container-expected.html: Added.
  • compositing/background-color/background-color-container.html: Added.
  • compositing/background-color/background-color-content-clip-expected.html: Added.
  • compositing/background-color/background-color-content-clip.html: Added.
  • compositing/background-color/background-color-padding-change-expected.html: Added.
  • compositing/background-color/background-color-padding-change.html: Added.
  • compositing/background-color/background-color-padding-clip-expected.html: Added.
  • compositing/background-color/background-color-padding-clip.html: Added.
  • compositing/background-color/background-color-simple-expected.html: Added.
  • compositing/background-color/background-color-simple.html: Added.
  • compositing/background-color/background-color-text-change-expected.html: Added.
  • compositing/background-color/background-color-text-change.html: Added.
  • compositing/background-color/background-color-text-clip-expected.html: Added.
  • compositing/background-color/background-color-text-clip.html: Added.

Added new tests for the specific functionality added, with the edge cases regarding composited
backgrounds.

  • compositing/backing/no-backing-for-clip-expected.txt:
  • compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • compositing/backing/no-backing-for-perspective-expected.txt:
  • compositing/columns/composited-in-paginated-expected.txt:
  • compositing/geometry/ancestor-overflow-change-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • compositing/geometry/clip-expected.txt:
  • compositing/geometry/composited-in-columns-expected.txt:
  • compositing/geometry/flipped-writing-mode-expected.txt:
  • compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
  • compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
  • compositing/geometry/preserve-3d-switching-expected.txt:
  • compositing/iframes/become-composited-nested-iframes-expected.txt:
  • compositing/iframes/become-overlapped-iframe-expected.txt:
  • compositing/iframes/composited-parent-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • compositing/iframes/connect-compositing-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe2-expected.txt:
  • compositing/iframes/connect-compositing-iframe3-expected.txt:
  • compositing/iframes/enter-compositing-iframe-expected.txt:
  • compositing/iframes/iframe-resize-expected.txt:
  • compositing/iframes/invisible-nested-iframe-hide-expected.txt:
  • compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • compositing/iframes/overlapped-iframe-expected.txt:
  • compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • compositing/iframes/page-cache-layer-tree-expected.txt:
  • compositing/iframes/scrolling-iframe-expected.txt:
  • compositing/layer-creation/animation-overlap-with-children-expected.txt:
  • compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • compositing/layer-creation/overflow-scroll-overlap-expected.txt:
  • compositing/layer-creation/overlap-animation-expected.txt:
  • compositing/layer-creation/overlap-child-layer-expected.txt:
  • compositing/layer-creation/overlap-clipping-expected.txt:
  • compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
  • compositing/layer-creation/overlap-transformed-layer-expected.txt:
  • compositing/layer-creation/overlap-transforms-expected.txt:
  • compositing/layer-creation/scroll-partial-update-expected.txt:
  • compositing/layer-creation/spanOverlapsCanvas-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
  • compositing/layer-creation/translatez-overlap-expected.txt:
  • compositing/overflow-trumps-transform-style-expected.txt:
  • compositing/overflow/clip-descendents-expected.txt:
  • compositing/plugins/no-backing-store-expected.txt:
  • compositing/rtl/rtl-absolute-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-fixed-expected.txt:
  • compositing/rtl/rtl-fixed-overflow-expected.txt:
  • compositing/rtl/rtl-relative-expected.txt:
  • compositing/tiled-layers-hidpi-expected.txt:
  • compositing/visible-rect/2d-transformed-expected.txt:
  • compositing/visible-rect/3d-transform-style-expected.txt:
  • compositing/visible-rect/3d-transformed-expected.txt:
  • compositing/visible-rect/animated-expected.txt:
  • compositing/visible-rect/animated-from-none-expected.txt:
  • compositing/visible-rect/clipped-by-viewport-expected.txt:
  • compositing/visible-rect/clipped-visible-rect-expected.txt:
  • compositing/visible-rect/iframe-and-layers-expected.txt:
  • compositing/visible-rect/nested-transform-expected.txt:
  • compositing/visible-rect/scrolled-expected.txt:
  • css3/filters/filtered-compositing-descendant-expected.txt:

Updated existing tests that now print different layer-tree results.

  • platform/chromium/compositing/backing/no-backing-for-clip-expected.txt: Copied from LayoutTests/compositing/backing/no-backing-for-clip-expected.txt.
  • platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt: Copied from LayoutTests/compositing/backing/no-backing-for-clip-overlap-expected.txt.
  • platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt: Copied from LayoutTests/compositing/backing/no-backing-for-perspective-expected.txt.
  • platform/chromium/compositing/columns/composited-in-paginated-expected.txt: Copied from LayoutTests/compositing/columns/composited-in-paginated-expected.txt.
  • platform/chromium/compositing/geometry/ancestor-overflow-change-expected.txt: Copied from LayoutTests/compositing/geometry/ancestor-overflow-change-expected.txt.
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Copied from LayoutTests/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt.
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Copied from LayoutTests/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt.
  • platform/chromium/compositing/geometry/clip-expected.txt: Copied from LayoutTests/compositing/geometry/clip-expected.txt.
  • platform/chromium/compositing/geometry/composited-in-columns-expected.txt: Copied from LayoutTests/compositing/geometry/composited-in-columns-expected.txt.
  • platform/chromium/compositing/geometry/flipped-writing-mode-expected.txt: Copied from LayoutTests/compositing/geometry/flipped-writing-mode-expected.txt.
  • platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Copied from LayoutTests/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt.
  • platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt.
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-positioned-expected.txt.
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt.
  • platform/chromium/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-transformed-expected.txt.
  • platform/chromium/compositing/geometry/preserve-3d-switching-expected.txt: Copied from LayoutTests/compositing/geometry/preserve-3d-switching-expected.txt.
  • platform/chromium/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Copied from LayoutTests/compositing/iframes/invisible-nested-iframe-hide-expected.txt.
  • platform/chromium/compositing/layer-creation/fixed-position-and-transform-expected.txt: Copied from LayoutTests/compositing/layer-creation/fixed-position-and-transform-expected.txt.
  • platform/chromium/compositing/layer-creation/fixed-position-under-transform-expected.txt: Copied from LayoutTests/compositing/layer-creation/fixed-position-under-transform-expected.txt.
  • platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Copied from LayoutTests/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-animation-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-animation-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-child-layer-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-child-layer-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-clipping-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-clipping-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-transformed-layer-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-transformed-layer-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-transforms-expected.txt.
  • platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt: Copied from LayoutTests/compositing/layer-creation/scroll-partial-update-expected.txt.
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-expected.txt: Copied from LayoutTests/compositing/layer-creation/stacking-context-overlap-expected.txt.
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Copied from LayoutTests/compositing/layer-creation/stacking-context-overlap-nested-expected.txt.
  • platform/chromium/compositing/layer-creation/translatez-overlap-expected.txt: Copied from LayoutTests/compositing/layer-creation/translatez-overlap-expected.txt.
  • platform/chromium/compositing/overflow-trumps-transform-style-expected.txt: Copied from LayoutTests/compositing/overflow-trumps-transform-style-expected.txt.
  • platform/chromium/compositing/rtl/rtl-absolute-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-absolute-expected.txt.
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-absolute-overflow-expected.txt.
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt.
  • platform/chromium/compositing/rtl/rtl-fixed-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-fixed-expected.txt.
  • platform/chromium/compositing/rtl/rtl-fixed-overflow-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-fixed-overflow-expected.txt.
  • platform/chromium/compositing/rtl/rtl-relative-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-relative-expected.txt.
  • platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt: Copied from LayoutTests/css3/filters/filtered-compositing-descendant-expected.txt.

Create chromium-specific results since chromium does not yet support setContentsToBackgroundColor.

3:13 PM Changeset in webkit [137050] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Enable WebGL by default.
https://bugs.webkit.org/show_bug.cgi?id=102991.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-08
Reviewed by Kenneth Rohde Christiansen.

Tools:

Enable WebGL by default.

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Update TestExpectations file to enable WebGL tests.

  • platform/efl/TestExpectations:
3:07 PM Changeset in webkit [137049] by zhajiang@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Google results page rendering issue with RTL languages like arabic/hebrew
https://bugs.webkit.org/show_bug.cgi?id=104451

Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.

PR: 206372
On Google results page, we layout the contents at the width of 833.
However, "appbar" and "top_nav" elements which have width 980 cause
overflow during the last layout and make the contents width larger.
The other renderers still stay at the old width unfortunately which
results in blank areas on the left side of the Google results RTL page.
Give it a chance to request another layout if overflow exceeds the
contents size and the page doesn't have virtual viewport, as this
layout will pick up the absolute visible overflow width within
DEFAULT_MAX_LAYOUT_WIDTH and update the other renderers.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::overflowExceedsContentsSize):
(WebKit):

  • Api/WebPage_p.h:

(WebPagePrivate):

1:47 PM Changeset in webkit [137048] by Patrick Gansterer
  • 7 edits in trunk/Source/WebCore

Build fix for WinCE after r137011.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):
(WebCore::GraphicsContext::drawBitmap):

  • platform/graphics/wince/ImageBufferWinCE.cpp:

(WebCore::BufferedImage::draw):
(WebCore::ImageBuffer::draw):

  • platform/graphics/wince/ImageWinCE.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
(WebCore::BitmapImage::draw):

  • platform/graphics/wince/SharedBitmap.cpp:

(WebCore::SharedBitmap::draw):

  • platform/graphics/wince/SharedBitmap.h:
1:19 PM Changeset in webkit [137047] by gavinp@chromium.org
  • 1 edit in trunk/Source/WebCore/loader/LinkLoader.cpp

Unreviewed. Fix build after r137045 for !ENABLE(LINK_PRERENDER) platforms.

A new guard was needed.

I am sorry.

12:34 PM Changeset in webkit [137046] by mifenton@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Enforce selection of last work when triggering caret based selection
https://bugs.webkit.org/show_bug.cgi?id=104447

Reviewed by Rob Buis.

PR 249225.

When the selection has reached the end of an input field,
ensure the last word is selected by adjusting the caret.

Reviewed Internally by Gen Mak.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::isCaretAtEndOfText):
(WebKit):

  • WebKitSupport/InputHandler.h:

(InputHandler):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectObject):

12:03 PM Changeset in webkit [137045] by gavinp@chromium.org
  • 26 edits
    1 copy
    4 adds in trunk/Source

Add status events on <link rel=prerender> elements.
https://bugs.webkit.org/show_bug.cgi?id=96474

Reviewed by Adam Barth.

The new PrerenderStatusEvent is sent to link elements when
prerenders are started by the embedder, and also sent when they
are stopped. Pages using this feature can now serialize launching
prerenders, and track timing performance.

Source/Platform:

  • chromium/public/WebPrerender.h:

(WebKit::WebPrerender::WebPrerender):
(WebKit::WebPrerender::operator=):
(WebPrerender):

Source/WebCore:

Tested in a new WebKitUnitTest for the chromium port.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventNames.h:

(WebCore):

  • html/HTMLLinkElement.cpp:

(WebCore):
(WebCore::HTMLLinkElement::didStartLinkPrerender):
(WebCore::HTMLLinkElement::didStopLinkPrerender):
(WebCore::HTMLLinkElement::didSendLoadForLinkPrerender):
(WebCore::HTMLLinkElement::didSendDOMContentLoadedForLinkPrerender):

  • html/HTMLLinkElement.h:

(HTMLLinkElement):

  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::didStartPrerender):
(WebCore):
(WebCore::LinkLoader::didStopPrerender):
(WebCore::LinkLoader::didSendLoadForPrerender):
(WebCore::LinkLoader::didSendDOMContentLoadedForPrerender):
(WebCore::LinkLoader::loadLink):

  • loader/LinkLoader.h:

(LinkLoader):

  • loader/LinkLoaderClient.h:

(LinkLoaderClient):

  • loader/Prerenderer.cpp:

(WebCore::Prerenderer::render):

  • loader/Prerenderer.h:

(WebCore):
(Prerenderer):

  • platform/PrerenderClient.h: Copied from Source/WebCore/loader/LinkLoaderClient.h.

(WebCore):
(PrerenderClient):
(WebCore::PrerenderClient::~PrerenderClient):

  • platform/PrerenderHandle.h:

(WebCore):
(PrerenderHandle):

  • platform/chromium/Prerender.cpp:

(WebCore::Prerender::Prerender):
(WebCore::Prerender::removeClient):
(WebCore):
(WebCore::Prerender::add):
(WebCore::Prerender::cancel):
(WebCore::Prerender::abandon):
(WebCore::Prerender::didStartPrerender):
(WebCore::Prerender::didStopPrerender):
(WebCore::Prerender::didSendLoadForPrerender):
(WebCore::Prerender::didSendDOMContentLoadedForPrerender):

  • platform/chromium/Prerender.h:

(WebKit):
(WebCore):
(Prerender):

  • platform/chromium/PrerenderHandle.cpp:

(WebCore::PrerenderHandle::create):
(WebCore::PrerenderHandle::PrerenderHandle):
(WebCore::PrerenderHandle::~PrerenderHandle):
(WebCore::PrerenderHandle::removeClient):
(WebCore):

  • platform/chromium/support/WebPrerender.cpp:

(WebKit::WebPrerender::toPrerender):
(WebKit):
(WebKit::WebPrerender::assign):
(WebKit::WebPrerender::isNull):
(WebKit::WebPrerender::didStartPrerender):
(WebKit::WebPrerender::didStopPrerender):
(WebKit::WebPrerender::didSendLoadForPrerender):
(WebKit::WebPrerender::didSendDOMContentLoadedForPrerender):

Source/WebKit/chromium:

  • WebKit.gyp:
  • WebKit.gypi:
  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::createWebView):
(FrameTestHelpers):
(WebKit::FrameTestHelpers::createWebViewAndLoad):

  • tests/FrameTestHelpers.h:

(FrameTestHelpers):

  • tests/PrerenderingTest.cpp: Added.
  • tests/data/prerender/multiple_prerenders.html: Added.
  • tests/data/prerender/single_prerender.html: Added.
11:42 AM Changeset in webkit [137044] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Martin Robinson.

Update the Chromium/Chrome version we advertise in our User-Agent
string to version 25, to better match our current reality.

  • platform/gtk/UserAgentGtk.cpp:

(WebCore::standardUserAgent):

11:18 AM Changeset in webkit [137043] by kov@webkit.org
  • 1 edit in releases/WebKitGTK/webkit-1.10/Source/WebKit/gtk/webkit/webkitwebsettings.cpp

Update the Chromium version we expose in our User-Agent to match the stable one used when we branched

11:18 AM Changeset in webkit [137042] by kov@webkit.org
  • 3 edits
    3 adds in releases/WebKitGTK/webkit-1.10

Merge 133155 - SVG as an image may recreate the renderer on zoom
https://bugs.webkit.org/show_bug.cgi?id=99508

Reviewed by Abhishek Arya.

Source/WebCore:

The SVGImage code, when SVG is used in <img> tags, caches the renderer
at the start of the painting method and re-uses the pointer at the end
of the method. However, when the page is zoomed the renderer may be
detached mid-method, thus leaving a stray pointer. The fix is to
re-fetch the pointer after the zooms.

Test: svg/as-image/img-zoom-svg-stylesheet.html

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer): Re-fetch the renderer after
the zoom operations.

LayoutTests:

Test and ref-test-result for zooming of SVG content when loaded as-image, and the svg is actually a css file.

  • svg/as-image/img-zoom-svg-stylesheet-expected.html: Added.
  • svg/as-image/img-zoom-svg-stylesheet.html: Added.
  • svg/as-image/resources/svg-stylesheet-for-zoom.svg: Added.
10:27 AM Changeset in webkit [137041] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove about:credits
https://bugs.webkit.org/show_bug.cgi?id=104399

Patch by Chris Hutten-Czapski <chutten@rim.com> on 2012-12-08
Reviewed by Rob Buis.

Just a simple removal.

  • WebKitSupport/AboutData.cpp:
10:10 AM Changeset in webkit [137040] by kov@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

[as_IN] New translation for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=103419

Patch by Nilamdyuti Goswami <nilamdyuti@gmail.com> on 2012-12-08
Rubber-stamped by Gustavo Noronha.

  • as.po: Added.
9:59 AM Changeset in webkit [137039] by commit-queue@webkit.org
  • 90 edits
    58 deletes in trunk

Unreviewed, rolling out r137006.
http://trac.webkit.org/changeset/137006
https://bugs.webkit.org/show_bug.cgi?id=104446

Broke plugin painting on Mac (youtube, etc.) (Requested by
thorton_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-08

Source/WebCore:

  • platform/graphics/GraphicsLayer.h:

(GraphicsLayer):

  • rendering/RenderBox.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::clipBox):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::updateDrawsContent):
(WebCore::RenderLayerBacking::updateBackgroundColor):
(WebCore::RenderLayerBacking::paintsBoxDecorations):
(WebCore::RenderLayerBacking::contentChanged):
(WebCore::RenderLayerBacking::updateImageContents):
(WebCore::RenderLayerBacking::contentsBox):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

LayoutTests:

  • compositing/background-color/background-color-alpha-expected.html: Removed.
  • compositing/background-color/background-color-alpha.html: Removed.
  • compositing/background-color/background-color-change-to-text-expected.html: Removed.
  • compositing/background-color/background-color-change-to-text.html: Removed.
  • compositing/background-color/background-color-composite-expected.html: Removed.
  • compositing/background-color/background-color-composite.html: Removed.
  • compositing/background-color/background-color-container-expected.html: Removed.
  • compositing/background-color/background-color-container.html: Removed.
  • compositing/background-color/background-color-content-clip-expected.html: Removed.
  • compositing/background-color/background-color-content-clip.html: Removed.
  • compositing/background-color/background-color-padding-change-expected.html: Removed.
  • compositing/background-color/background-color-padding-change.html: Removed.
  • compositing/background-color/background-color-padding-clip-expected.html: Removed.
  • compositing/background-color/background-color-padding-clip.html: Removed.
  • compositing/background-color/background-color-simple-expected.html: Removed.
  • compositing/background-color/background-color-simple.html: Removed.
  • compositing/background-color/background-color-text-change-expected.html: Removed.
  • compositing/background-color/background-color-text-change.html: Removed.
  • compositing/background-color/background-color-text-clip-expected.html: Removed.
  • compositing/background-color/background-color-text-clip.html: Removed.
  • compositing/backing/no-backing-for-clip-expected.txt:
  • compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • compositing/backing/no-backing-for-perspective-expected.txt:
  • compositing/columns/composited-in-paginated-expected.txt:
  • compositing/geometry/ancestor-overflow-change-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • compositing/geometry/clip-expected.txt:
  • compositing/geometry/composited-in-columns-expected.txt:
  • compositing/geometry/flipped-writing-mode-expected.txt:
  • compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
  • compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
  • compositing/geometry/preserve-3d-switching-expected.txt:
  • compositing/iframes/become-composited-nested-iframes-expected.txt:
  • compositing/iframes/become-overlapped-iframe-expected.txt:
  • compositing/iframes/composited-parent-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • compositing/iframes/connect-compositing-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe2-expected.txt:
  • compositing/iframes/connect-compositing-iframe3-expected.txt:
  • compositing/iframes/enter-compositing-iframe-expected.txt:
  • compositing/iframes/iframe-resize-expected.txt:
  • compositing/iframes/invisible-nested-iframe-hide-expected.txt:
  • compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • compositing/iframes/overlapped-iframe-expected.txt:
  • compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • compositing/iframes/page-cache-layer-tree-expected.txt:
  • compositing/iframes/scrolling-iframe-expected.txt:
  • compositing/layer-creation/animation-overlap-with-children-expected.txt:
  • compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • compositing/layer-creation/overflow-scroll-overlap-expected.txt:
  • compositing/layer-creation/overlap-animation-expected.txt:
  • compositing/layer-creation/overlap-child-layer-expected.txt:
  • compositing/layer-creation/overlap-clipping-expected.txt:
  • compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
  • compositing/layer-creation/overlap-transformed-layer-expected.txt:
  • compositing/layer-creation/overlap-transforms-expected.txt:
  • compositing/layer-creation/scroll-partial-update-expected.txt:
  • compositing/layer-creation/spanOverlapsCanvas-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
  • compositing/layer-creation/translatez-overlap-expected.txt:
  • compositing/overflow-trumps-transform-style-expected.txt:
  • compositing/overflow/clip-descendents-expected.txt:
  • compositing/overflow/content-gains-scrollbars-expected.txt:
  • compositing/overflow/overflow-scrollbar-layers-expected.txt:
  • compositing/overflow/resize-painting-expected.txt:
  • compositing/plugins/no-backing-store-expected.txt:
  • compositing/rtl/rtl-absolute-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-fixed-expected.txt:
  • compositing/rtl/rtl-fixed-overflow-expected.txt:
  • compositing/rtl/rtl-relative-expected.txt:
  • compositing/tiled-layers-hidpi-expected.txt:
  • compositing/visible-rect/2d-transformed-expected.txt:
  • compositing/visible-rect/3d-transform-style-expected.txt:
  • compositing/visible-rect/3d-transformed-expected.txt:
  • compositing/visible-rect/animated-expected.txt:
  • compositing/visible-rect/animated-from-none-expected.txt:
  • compositing/visible-rect/clipped-by-viewport-expected.txt:
  • compositing/visible-rect/clipped-visible-rect-expected.txt:
  • compositing/visible-rect/iframe-and-layers-expected.txt:
  • compositing/visible-rect/nested-transform-expected.txt:
  • compositing/visible-rect/scrolled-expected.txt:
  • css3/filters/filtered-compositing-descendant-expected.txt:
  • platform/chromium/compositing/backing/no-backing-for-clip-expected.txt: Removed.
  • platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt: Removed.
  • platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt: Removed.
  • platform/chromium/compositing/columns/composited-in-paginated-expected.txt: Removed.
  • platform/chromium/compositing/geometry/ancestor-overflow-change-expected.txt: Removed.
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Removed.
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Removed.
  • platform/chromium/compositing/geometry/clip-expected.txt: Removed.
  • platform/chromium/compositing/geometry/composited-in-columns-expected.txt: Removed.
  • platform/chromium/compositing/geometry/flipped-writing-mode-expected.txt: Removed.
  • platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Removed.
  • platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Removed.
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Removed.
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Removed.
  • platform/chromium/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Removed.
  • platform/chromium/compositing/geometry/preserve-3d-switching-expected.txt: Removed.
  • platform/chromium/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/fixed-position-and-transform-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/fixed-position-under-transform-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/overlap-animation-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/overlap-child-layer-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/overlap-clipping-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/overlap-transformed-layer-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/translatez-overlap-expected.txt: Removed.
  • platform/chromium/compositing/overflow-trumps-transform-style-expected.txt: Removed.
  • platform/chromium/compositing/overflow/content-gains-scrollbars-expected.txt:
  • platform/chromium/compositing/overflow/overflow-scrollbar-layers-expected.txt:
  • platform/chromium/compositing/overflow/resize-painting-expected.txt:
  • platform/chromium/compositing/rtl/rtl-absolute-expected.txt: Removed.
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-expected.txt: Removed.
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Removed.
  • platform/chromium/compositing/rtl/rtl-fixed-expected.txt: Removed.
  • platform/chromium/compositing/rtl/rtl-fixed-overflow-expected.txt: Removed.
  • platform/chromium/compositing/rtl/rtl-relative-expected.txt: Removed.
  • platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
  • platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt:
  • platform/mac/compositing/iframes/resizer-expected.txt:
  • platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
  • platform/mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
9:42 AM Changeset in webkit [137038] by kov@webkit.org
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-1.10

Merge 132856 - feImage should not be allowed to self reference
https://bugs.webkit.org/show_bug.cgi?id=94652

Reviewed by Eric Seidel.

Source/WebCore:

Add cycle detection for SVG filter application, and also fix a problem
with graphics context restore when filters are applied. This also
converts the flags in FilterData to a state tracking system, as the
number of flags was getting messy and only one flag is valid at any given time.

Test: svg/filters/feImage-self-and-other-referencing.html

  • rendering/svg/RenderSVGResourceFilter.cpp: Convert to new FilterData

state management and enable cycle detection.
(WebCore):
(WebCore::RenderSVGResourceFilter::removeClientFromCache): Change isBuilt and markedForRemoval flags to state enums.
(WebCore::RenderSVGResourceFilter::applyResource): Change flags to state enums and detect cycles.
(WebCore::RenderSVGResourceFilter::postApplyResource): Change flags to state and add handling
for the various states.
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged): Change isBuilt flag to state enums.

  • rendering/svg/RenderSVGResourceFilter.h:

(WebCore::FilterData::FilterData):
(FilterData): Convert to a state tracking system.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced): Add a block around the
SVGRenderingContext so that it applies the filter and reverts the
context before the calling method restores the context.

LayoutTests:

Additional test case for situations when the filter is applied to multiple objects that it also references.

  • svg/filters/feImage-self-and-other-referencing-expected.html: Added.
  • svg/filters/feImage-self-and-other-referencing.html: Added.

Conflicts:

Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp
Source/WebCore/rendering/svg/RenderSVGResourceFilter.h

9:41 AM Changeset in webkit [137037] by kov@webkit.org
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-1.10

Merge 131488 - An feImage that tries to render itself should be stopped
https://bugs.webkit.org/show_bug.cgi?id=94652

Reviewed by Eric Seidel.

Source/WebCore:

An SVG feImage filter element will accept, as the src to render, an
SVG document that makes use of the feImage itself. This causes the
feImage to try to draw itself while already in the process of drawing
itself. Various problems arise from this. The invariant we wish to
maintain is that no element in the src tree of an feImage element
refers to that feImage.

This patch adds a flag to all FilterData objects that tracks whether or
not the filter is currently applying itself, and avoids applying the
filter recursively.

While it may seem better to catch this problem when the src is set, or
when the filter is built, that turns out to be challenging and
inefficient. Say we choose to test when the src atttribute is set. To
do so would require looking through all of the DOM nodes that will be
rendered for the src, finding all resources used, and checking if any
of them make use fo the feImage element that we are setting the source
for. The infrastructure is not in place to do that, and it would
involve walking a potentially very large portion of the DOM in order
to detect a very rare situation. Note that it is not enough just to
walk the DOM directly under the src; we also need to recursively follow any
resource links to see if they use the feImage (e.g. patterns or
masks or use or ...).

If we instead try to use the renderer node to find self referencing,
we need to recursively walk a potentially very large render tree,
tracing all resources in search of the feImage. This would need to be
done every time the filter is built, which is again a significant
overhead for a situation that is very unlikely to occur. And we do not
have methods that make it easy to find feImage filter effect nodes; they are
hidden behind filter resource nodes.

Hence the runtime check to catch the problem. The check must be in
FilterData and RenderSVGResourceFilter code because we must prevent
the destruction of the feImage when we encounter it recursively.

This patch also renames FilterData::builded to FilterData::isBuilt.

Test: svg/filters/feImage-self-referencing.html

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::ApplyingFilterEffectGuard): Guard to ensure that, in the future, we always
clear the isApplying flag even if the postApplyResource method returns early.
(WebCore::RenderSVGResourceFilter::applyResource): Do not apply a resource that is already applying and
rename builded to isBuilt.
(WebCore::RenderSVGResourceFilter::postApplyResource): Mark a resource as applying and clear after
it is done. Abort if a resource is already applying when the method begins. Rename builded to isBuilt.
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged): Rename builded to isBuilt.

  • rendering/svg/RenderSVGResourceFilter.h:

(WebCore::FilterData::FilterData):
(FilterData): Add isApplying and rename builded to isBuilt.

LayoutTests:

Ref-test to verify that an feImage that tries to draw itself will not
crash. This test must be render in order to verify the result. Do not
convert to dumpAstext.

  • svg/filters/feImage-self-referencing-expected.html: Added.
  • svg/filters/feImage-self-referencing.html: Added.

Conflicts:

Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp

9:30 AM Changeset in webkit [137036] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.10/Source/WebKit2

Merge 137033 - Unreviewed. Make building the WebKit2 GIR file conditional on building the WebKit2 library.

  • GNUmakefile.am:
9:16 AM Changeset in webkit [137035] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

[EFL][WK2] Add Remote Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=98705

Patch by Seokju Kwon <Seokju Kwon> on 2012-12-08
Reviewed by Gyuyoung Kim.

.:

Prepare inspectorPageIndex.html for remote web inspector.

  • Source/PlatformEfl.cmake:

Source/WebKit2:

Add Remote Web Inspector to EFL port.
The WebInspectorSever will be started during WebKit context initialization.
The IP address and port number for the server can be set in WEBKIT_INSPECTOR_SERVER.

  • CMakeLists.txt:
  • PlatformEfl.cmake:
  • UIProcess/InspectorServer/WebInspectorServer.h:

(WebInspectorServer):

  • UIProcess/InspectorServer/WebSocketServer.h:

(WebSocketServer):

  • UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp: Added.

(WebKit):
(WebKit::inspectorResourcePath):
(WebKit::WebInspectorServer::platformResourceForPath):
(WebKit::WebInspectorServer::buildPageList):

  • UIProcess/InspectorServer/soup/WebSocketServerSoup.cpp:

(WebKit::connectionCallback):

  • UIProcess/efl/WebContextEfl.cpp:

(WebKit::initializeInspectorServer):
(WebKit):
(WebKit::WebContext::platformInitializeWebProcess):

  • config.h:
9:13 AM Changeset in webkit [137034] by kov@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

Merge Hindi translation of webkit
https://bugs.webkit.org/show_bug.cgi?id=97410

Patch by Rajesh Ranjan <rajeshkajha@yahoo.com> on 2012-12-08
Rubber-stamped by Gustavo Noronha.

  • hi.po: Added.
8:41 AM Changeset in webkit [137033] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Make building the WebKit2 GIR file conditional on building the WebKit2 library.

  • GNUmakefile.am:
8:08 AM Changeset in webkit [137032] by kov@webkit.org
  • 2 edits in trunk/Source/WTF

Unreviewed trivial space fix to silence an automake warning.

  • GNUmakefile.list.am:
8:01 AM Changeset in webkit [137031] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove no-op line in WebPage.cpp
https://bugs.webkit.org/show_bug.cgi?id=104385

Reviewed by Antonio Gomes.

Remove self-assignment no-op line. Must have been left when I removed the
mapFromTransformed part.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):

7:52 AM Changeset in webkit [137030] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
6:41 AM Changeset in webkit [137029] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
5:48 AM Changeset in webkit [137028] by james.wei@intel.com
  • 2 edits in trunk/Source/WebCore

Remove incorrect ASSERT for m_error in CachedResource
https://bugs.webkit.org/show_bug.cgi?id=104333

Reviewed by Nate Chapin.

This assertion was brought in https://bugs.webkit.org/show_bug.cgi?id=100901
When the request is canceled, m_error.isNull() should be true.

run webkit_unit_tests Debug build.

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::stopLoading):

3:05 AM Changeset in webkit [137027] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Qt Linux Minimal build fix after r136975.

  • dom/ElementRareData.h:

(ElementRareData):

2:52 AM Changeset in webkit [137026] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Qt Linux Minimal build fix attempt after r136959.

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::layerTreeDidChange):
(WebCore::InspectorInstrumentation::renderLayerDestroyed):

2:44 AM Changeset in webkit [137025] by xan@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix after r137003. Wrap Microdata only sections with ENABLE(MICRODATA).

  • dom/NodeRareData.h:

(NodeRareData):

2:37 AM Changeset in webkit [137024] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix after r137003. Wrap NodeMutationObserverData with ENABLE(MUTATION_OBSERVERS).

  • dom/NodeRareData.h:

(NodeRareData):

2:22 AM Changeset in webkit [137023] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Remove unused headers
https://bugs.webkit.org/show_bug.cgi?id=104428

Patch by Seokju Kwon <Seokju Kwon> on 2012-12-08
Reviewed by Kentaro Hara.

Header inclusion cleanup.
Remove <WebCore/NotImplement.h>.

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:
  • WebMutableURLRequest.cpp:

Source/WebKit2:

  • Platform/qt/WorkQueueQt.cpp:
  • Platform/win/WorkQueueWin.cpp:
  • Shared/qt/ShareableBitmapQt.cpp:
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
  • UIProcess/win/TextCheckerWin.cpp:
  • UIProcess/win/WebContextMenuProxyWin.cpp:
  • WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:
2:01 AM Changeset in webkit [137022] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for ENABLE(SVG) && !ENABLE(FILTERS) after r136975.

  • rendering/svg/SVGResources.cpp:

(WebCore::SVGResources::buildCachedResources):

1:33 AM WebKitGTK edited by Simon Pena
Updated reference to IRC channel (diff)
1:22 AM Changeset in webkit [137021] by adamk@chromium.org
  • 3 edits
    2 adds in trunk

HTMLTemplateElement.innerHTML should be parsed into the template contents owner document
https://bugs.webkit.org/show_bug.cgi?id=104407

Reviewed by Eric Seidel.

Source/WebCore:

When parsing via innerHTML, ensure that all operations (including the
initial fragment creation) occur in the proper document to avoid,
e.g., images loading while being parsed into the template contents.
This matches the parsing behavior during page load.

Test: fast/dom/HTMLTemplateElement/innerHTML-inert.html

  • editing/markup.cpp:

(WebCore::createFragmentForInnerOuterHTML):

LayoutTests:

  • fast/dom/HTMLTemplateElement/innerHTML-inert-expected.txt: Added.
  • fast/dom/HTMLTemplateElement/innerHTML-inert.html: Added.
12:36 AM Changeset in webkit [137020] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Assertion failed at WebCore::RedirectedXCompositeWindow::context()
https://bugs.webkit.org/show_bug.cgi?id=104349

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-12-08
Reviewed by Martin Robinson.

We should return GLContext if m_needsContext is CreateGLContext. By the way
CreateGLContext is a enum value and its default value is 0. So checking
ASSERT(m_needsContext) causes a crash on debug build.
ASSERT(m_needsContext == CreateGLContext) is better here.

No new tests since we can verify this with already existing AC tests.

  • platform/gtk/RedirectedXCompositeWindow.cpp:

(WebCore::RedirectedXCompositeWindow::context):

Dec 7, 2012:

10:51 PM Changeset in webkit [137019] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Remove unused source file from PlatformEfl.cmake
https://bugs.webkit.org/show_bug.cgi?id=104430

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-12-07
Reviewed by Kentaro Hara.

Shared/API/c/gtk/WKGraphicsContextGtk.cpp is not used for building WebKit2/EFL.

  • PlatformEfl.cmake:
9:39 PM Changeset in webkit [137018] by senorblanco@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-win-xp/fast/text/hyphenate-character-expected.txt: Added.
9:35 PM Changeset in webkit [137017] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Add missing forward declaration for JSC::ArrayAllocationProfile
https://bugs.webkit.org/show_bug.cgi?id=104425

Patch by Jonathan Liu <net147@gmail.com> on 2012-12-07
Reviewed by Kentaro Hara.

The header for the JSC::ArrayConstructor class is missing a forward
declaration for the JSC::ArrayAllocationProfile class which causes
compilation to fail when compiling with MinGW-w64.

  • runtime/ArrayConstructor.h:

(JSC):

9:17 PM Changeset in webkit [137016] by senorblanco@chromium.org
  • 1 edit
    1 move
    3 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-mac-lion/css3/flexbox/repaint-column-reverse-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/flexbox/repaint-column-reverse-expected.png: Removed.
  • platform/chromium-win-xp/css3/flexbox/repaint-column-reverse-expected.png: Removed.
  • platform/chromium-win/css3/flexbox/repaint-column-reverse-expected.png: Renamed from LayoutTests/platform/chromium-linux/css3/flexbox/repaint-column-reverse-expected.png.
9:15 PM Changeset in webkit [137015] by senorblanco@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-mac/compositing/background-color/background-color-change-to-text-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/background-color/background-color-change-to-text-expected.png: Added.
8:58 PM Changeset in webkit [137014] by senorblanco@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening. Remove some incorrect baselines.

  • platform/chromium-linux/compositing/backface-visibility/backface-visibility-webgl-expected.png: Removed.
  • platform/chromium-mac/compositing/backface-visibility/backface-visibility-webgl-expected.png: Removed.
  • platform/chromium/TestExpectations:
8:24 PM Changeset in webkit [137013] by senorblanco@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-mac-lion/css3/flexbox/repaint-column-reverse-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/flexbox/repaint-column-reverse-expected.png: Added.
  • platform/chromium-mac/css3/flexbox/repaint-column-reverse-expected.png: Added.
8:14 PM Changeset in webkit [137012] by senorblanco@chromium.org
  • 1 edit
    10 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-linux/fast/text/hyphenate-character-expected.png: Added.
  • platform/chromium-linux/fast/text/hyphenate-character-expected.txt: Added.
  • platform/chromium-linux/fast/text/hyphenate-first-word-expected.png: Added.
  • platform/chromium-linux/fast/text/hyphenate-limit-before-after-expected.png: Added.
  • platform/chromium-linux/fast/text/hyphenate-limit-lines-expected.png: Added.
  • platform/chromium-linux/fast/text/hyphenate-locale-expected.png: Added.
  • platform/chromium-linux/fast/text/hyphens-expected.png: Added.
  • platform/chromium-linux/fast/text/international/hindi-whitespace-expected.png: Added.
  • platform/chromium-linux/fast/text/international/hindi-whitespace-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/hyphenate-limit-before-after-expected.png: Added.
8:03 PM Changeset in webkit [137011] by commit-queue@webkit.org
  • 38 edits in trunk/Source

Extend platform layer so it can pass blend modes to the compositing calls
https://bugs.webkit.org/show_bug.cgi?id=104176

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-12-07
Reviewed by Dirk Schulze.

Source/WebCore:

Adding blend mode enumeration to drawImage functions + stored blendmode in graphics context

No new tests, no new functionality.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

  • platform/graphics/BitmapImage.h:
  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::draw):

  • platform/graphics/CrossfadeGeneratedImage.h:

(CrossfadeGeneratedImage):

  • platform/graphics/GeneratedImage.h:

(GeneratedImage):

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::draw):

  • platform/graphics/GeneratorGeneratedImage.h:

(GeneratorGeneratedImage):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage):
(WebCore):
(WebCore::GraphicsContext::drawImageBuffer):
(WebCore::GraphicsContext::setCompositeOperation):

  • platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContextState::GraphicsContextState):
(GraphicsContextState):
(GraphicsContext):

  • platform/graphics/Image.cpp:

(WebCore::Image::draw):
(WebCore::Image::drawTiled):

  • platform/graphics/Image.h:

(Image):

  • platform/graphics/ImageBuffer.h:

(ImageBuffer):

  • platform/graphics/cairo/BitmapImageCairo.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::draw):

  • platform/graphics/cg/PDFDocumentImage.h:

(PDFDocumentImage):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/qt/ImageQt.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/qt/StillImageQt.cpp:

(WebCore::StillImage::draw):

  • platform/graphics/qt/StillImageQt.h:

(StillImage):

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h:

(BitmapImageSingleFrameSkia):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):

  • platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::nativeImageForCurrentFrame):

  • svg/graphics/SVGImage.h:

(SVGImage):

Source/WebKit/chromium:

Adding blend mode enumeration to draw functions

  • tests/DragImageTest.cpp:

(WebCore::TestImage::draw):

  • tests/ImageLayerChromiumTest.cpp:

(WebCore::TestImage::draw):

7:54 PM Changeset in webkit [137010] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Add missing const qualifier to JSC::CodeBlock::getJITType()
https://bugs.webkit.org/show_bug.cgi?id=104424

Patch by Jonathan Liu <net147@gmail.com> on 2012-12-07
Reviewed by Laszlo Gombos.

JSC::CodeBlock::getJITType() has the const qualifier when JIT is
enabled but is missing the const qualifier when JIT is disabled.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::getJITType):

7:14 PM Changeset in webkit [137009] by senorblanco@chromium.org
  • 12 edits
    3 copies
    9 moves
    32 adds
    9 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-linux/svg/custom/transform-with-shadow-and-gradient-expected.png: Removed.
  • platform/chromium-mac-lion/fast/text/hyphenate-character-expected.png: Added.
  • platform/chromium-mac-lion/fast/text/hyphenate-character-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/hyphenate-first-word-expected.png: Added.
  • platform/chromium-mac-lion/fast/text/hyphenate-first-word-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/hyphenate-limit-before-after-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt.
  • platform/chromium-mac-lion/fast/text/hyphenate-limit-lines-expected.png: Added.
  • platform/chromium-mac-lion/fast/text/hyphenate-limit-lines-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/hyphenate-locale-expected.png: Added.
  • platform/chromium-mac-lion/fast/text/hyphens-expected.png: Added.
  • platform/chromium-mac-lion/fast/text/hyphens-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-character-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-character-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-first-word-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt:
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-lines-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-lines-expected.txt:
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-locale-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphens-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/hyphens-expected.txt: Added.
  • platform/chromium-mac/fast/text/hyphenate-character-expected.png:
  • platform/chromium-mac/fast/text/hyphenate-character-expected.txt: Added.
  • platform/chromium-mac/fast/text/hyphenate-first-word-expected.png: Added.
  • platform/chromium-mac/fast/text/hyphenate-first-word-expected.txt: Added.
  • platform/chromium-mac/fast/text/hyphenate-limit-before-after-expected.png:
  • platform/chromium-mac/fast/text/hyphenate-limit-before-after-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt.
  • platform/chromium-mac/fast/text/hyphenate-limit-lines-expected.png: Added.
  • platform/chromium-mac/fast/text/hyphenate-limit-lines-expected.txt: Added.
  • platform/chromium-mac/fast/text/hyphenate-locale-expected.png: Added.
  • platform/chromium-mac/fast/text/hyphenate-locale-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/text/hyphenate-locale-expected.txt.
  • platform/chromium-mac/fast/text/hyphens-expected.png:
  • platform/chromium-mac/fast/text/hyphens-expected.txt: Added.
  • platform/chromium-mac/svg/custom/transform-with-shadow-and-gradient-expected.png: Removed.
  • platform/chromium-win-xp/fast/text/hyphenate-character-expected.png: Added.
  • platform/chromium-win-xp/fast/text/hyphens-expected.png: Added.
  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.png: Added.
  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/text/international/hindi-whitespace-expected.txt.
  • platform/chromium-win/fast/text/hyphenate-character-expected.png: Added.
  • platform/chromium-win/fast/text/hyphenate-character-expected.txt: Added.
  • platform/chromium-win/fast/text/hyphenate-first-word-expected.png: Added.
  • platform/chromium-win/fast/text/hyphenate-limit-before-after-expected.png: Added.
  • platform/chromium-win/fast/text/hyphenate-limit-lines-expected.png: Added.
  • platform/chromium-win/fast/text/hyphenate-locale-expected.png: Added.
  • platform/chromium-win/fast/text/hyphenate-locale-expected.txt: Renamed from LayoutTests/platform/chromium/fast/text/hyphenate-locale-expected.txt.
  • platform/chromium-win/fast/text/hyphens-expected.png: Added.
  • platform/chromium-win/fast/text/international/hindi-whitespace-expected.png:
  • platform/chromium-win/fast/text/international/hindi-whitespace-expected.txt:
  • platform/chromium-win/svg/custom/transform-with-shadow-and-gradient-expected.png: Removed.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/text/hyphenate-character-expected.png: Removed.
  • platform/chromium/fast/text/hyphenate-first-word-expected.png: Removed.
  • platform/chromium/fast/text/hyphenate-limit-before-after-expected.png: Removed.
  • platform/chromium/fast/text/hyphenate-limit-lines-expected.png: Removed.
  • platform/chromium/fast/text/hyphenate-locale-expected.png: Removed.
  • platform/chromium/fast/text/hyphens-expected.png: Removed.
  • platform/chromium/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
  • platform/efl-wk1/fast/text/hyphenate-character-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-character-expected.png.
  • platform/efl-wk1/fast/text/hyphenate-first-word-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-first-word-expected.png.
  • platform/efl-wk1/fast/text/hyphenate-limit-before-after-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-limit-before-after-expected.png.
  • platform/efl-wk1/fast/text/hyphenate-limit-lines-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-limit-lines-expected.png.
  • platform/efl-wk1/fast/text/hyphenate-locale-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-locale-expected.png.
  • platform/efl-wk1/fast/text/hyphenate-locale-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-locale-expected.txt.
  • platform/efl-wk1/fast/text/hyphens-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphens-expected.png.
7:00 PM Changeset in webkit [137008] by hclam@chromium.org
  • 12 edits in trunk/Source

[chromium] ImageDecodingStore should cache partially decoded images
https://bugs.webkit.org/show_bug.cgi?id=103796

Reviewed by Stephen White.

Source/WebCore:

Implement caching for incomplete images, meaning the image is partially
decoded. The image is cached together with partially decoded ImageDecoder.
This allows decoding to resume in a later time.

Caching logic for incomplete images is implemented in ImageDecodingStore.

Logic for resuming image decoding is implemented in ImageFrameGenerator.

ImageDecodingStore allows storing incomplete image with the decoder.
The cache entry can be used in a later time to read and write (i.e. resume
decoding.) To avoid the same entry being written and read at the same time,
an incomplete entry can be used by one user only. Concurrent access to
an incomplete entry should never happen and is checked by an assert.
An entry can becomes complete when decoding is finished. In this case
the associated decoder is deleted. Once an entry becomes complete concurrent
read is allowed.

ImageFrameGenerator performs the logic to resume image decoding. It
performs the following operations in sequence:

  • Try to lookup a complete image
  • Try to perform scaling on a complete image
  • Try to lookup an incomplete image and resume decoding & scaling
  • Everything fails, start decoding from scratch

The entire sequence of operations in under a mutex, hence there will be
no more than 1 user of an incomplete cache entry at the same time.

New unit tests in ImageDecodingStoreTest and ImageFrameGeneratorTest.

  • platform/graphics/chromium/ImageDecodingStore.cpp:

(WebCore::ImageDecodingStore::lockCache):
Change of method definition to return an image and ImageDecoder.
(WebCore::ImageDecodingStore::unlockCache):
(WebCore::ImageDecodingStore::insertAndLockCache):
(WebCore::ImageDecodingStore::overwriteAndLockCache):
New method to allow an incomplete cache entry be overwritten.
(WebCore):

  • platform/graphics/chromium/ImageDecodingStore.h:

(ImageDecodingStore):
(WebCore::ImageDecodingStore::CacheEntry::createAndUse):
(WebCore::ImageDecodingStore::CacheEntry::CacheEntry):
(WebCore::ImageDecodingStore::CacheEntry::cachedImage):
(WebCore::ImageDecodingStore::CacheEntry::cachedDecoder):
(WebCore::ImageDecodingStore::CacheEntry::releaseCachedDecoder):
(WebCore::ImageDecodingStore::CacheEntry::overwriteCachedImage):
New method to allow an incomplete image be overwitten.
(CacheEntry):

  • platform/graphics/chromium/ImageFrameGenerator.cpp:

(WebCore::ImageFrameGenerator::ImageFrameGenerator):
(WebCore::ImageFrameGenerator::decodeAndScale):
(WebCore::ImageFrameGenerator::tryToLockCompleteCache):
(WebCore::ImageFrameGenerator::tryToScale):
(WebCore::ImageFrameGenerator::tryToResumeDecodeAndScale):
New method to lookup an incomplete cache entry and resume decoding.
(WebCore):
(WebCore::ImageFrameGenerator::tryToDecodeAndScale):
(WebCore::ImageFrameGenerator::decoder):
New helper method to do decoding for a full sized image.
(WebCore::ImageFrameGenerator::prepareData):
New helper method to prepare data safely.

  • platform/graphics/chromium/ImageFrameGenerator.h:

(ImageFrameGenerator):

  • platform/graphics/chromium/LazyDecodingPixelRef.cpp:

(WebCore::LazyDecodingPixelRef::onLockPixels):

  • platform/graphics/chromium/ScaledImageFragment.h:

(WebCore::ScaledImageFragment::setIsComplete):

Source/WebKit/chromium:

Added unit tests to verify caching behavior for partially decoded images.
New tests added:

  • ImageDecodingStoreTest.insertIncompleteCache

Insert incomplete image with a decoder into cache.

  • ImageDecodingStoreTest.insertCompleteCacheWithDecoder

Insert complete image with a decoder, decoder is deleted.

  • ImageDecodingStoreTest.incompleteCacheBecomesComplete

Progressive downloading of a file. Image becomes complete, decoder deleted.

  • ImageFrameGeneratorTest.cacheMissWithIncompleteDecodeAndScale

Cache lookup failed and start a decoding that decoded an incomplete image.

ImageFrameGeneratorTest.incompleteDecodeBecomesComplete
Image decoded as incomplete, file fully downloaded and cache entry becomes complete.

ImageFrameGeneratorTest.incompleteDecodeAndScaleBecomesComplete
Image decoded and scaled as incomplete, becomes complete after file is fully dowloaded.

ImageFrameGeneratorTest.incompleteDecodeBecomesCompleteMultiThreaded
Transition from incomplete to complete, entire lifecycle happens on 2 threads.

  • tests/DeferredImageDecoderTest.cpp:

(WebCore::DeferredImageDecoderTest::SetUp):

  • tests/ImageDecodingStoreTest.cpp:

(WebCore::ImageDecodingStoreTest::SetUp):
(WebCore::ImageDecodingStoreTest::decoderBeingDestroyed):
(ImageDecodingStoreTest):
(WebCore::ImageDecodingStoreTest::frameBufferRequested):
(WebCore::ImageDecodingStoreTest::frameStatus):
(WebCore::ImageDecodingStoreTest::createIncompleteImage):
(WebCore::ImageDecodingStoreTest::lockCache):
(WebCore::TEST_F):
(WebCore):

  • tests/ImageFrameGeneratorTest.cpp:

(WebCore::ImageFrameGeneratorTest::SetUp):
(WebCore::ImageFrameGeneratorTest::decoderBeingDestroyed):
(ImageFrameGeneratorTest):
(WebCore::MockImageDecoderFactory::create):
(WebCore::TEST_F):
(WebCore):
(WebCore::decodeThreadMain):

  • tests/MockImageDecoder.h:

(WebCore::MockImageDecoder::create):
(MockImageDecoder):
(WebCore::MockImageDecoder::setSize):
(WebCore::MockImageDecoder::frameBufferAtIndex):

6:34 PM Changeset in webkit [137007] by alexis@webkit.org
  • 8 edits in trunk

Enable CSS3 position offset for CSS Masking.
https://bugs.webkit.org/show_bug.cgi?id=104252

Reviewed by Dirk Schulze.

Source/WebCore:

To follow CSS3 background-position, mask-position should also support
the new <position> type (http://dvcs.w3.org/hg/FXTF/raw-file/tip/masking/index.html#mask-property).
Now the code is shared between background and mask I renamed the
functions used to be more generic. Note that the feature flag is not
meant to stay and will be removed in a following commit.

No new tests : I modified LayoutTests/fast/masking/parsing-mask.html to
cover the new feature.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::createPositionListForLayer):

  • css/CSSParser.cpp:

(WebCore::isFillPositionKeyword):
(WebCore::CSSParser::parse4ValuesFillPosition):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::isPotentialPositionValue):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parse2ValuesFillPosition):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseTransformOriginShorthand):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parsePerspectiveOrigin):

  • css/CSSParser.h:
  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):

LayoutTests:

Add coverage for the new cases. Both when setting the position with the
longhand or with the shorthand.

  • fast/masking/parsing-mask-expected.txt:
  • fast/masking/parsing-mask.html:
6:29 PM Changeset in webkit [137006] by commit-queue@webkit.org
  • 90 edits
    38 copies
    24 adds in trunk

Use background color for GraphicsLayers when applicable
https://bugs.webkit.org/show_bug.cgi?id=103786

Source/WebCore:

Updated RenderLayerBacking to call GraphicsLayer::setContentsToBackgroundColor when the following conditions take place:

  1. The layer doesn't paint its own content, other than background/decoration.
  2. There are no borders or other box decorations (border radius, borders, outline, shadow etc.)
  3. The image has only a background color, and no background image.
  4. background-composite is set to source-over, and background-clip is anything apart from text.
  5. The port supports setContentsToBackgroundColor.

This allows any implementation of GraphicsLayer that supports setContentsToBackgroundColor to avoid allocating a backing store
for that layer, but instead draw that solid color directly.
In addition to setting the background color, the layer's contentsRect needs to be adjusted, since the default contents rect of
a layer is not always equivalent to the rect where the background is supposed to be painted, which is derived from the box's
background-clip property.

Patch by No'am Rosenthal <Noam Rosenthal> on 2012-12-07
Reviewed by Simon Fraser.

Tests: compositing/background-color/background-color-alpha.html

compositing/background-color/background-color-change-to-text.html
compositing/background-color/background-color-composite.html
compositing/background-color/background-color-container.html
compositing/background-color/background-color-content-clip.html
compositing/background-color/background-color-padding-change.html
compositing/background-color/background-color-padding-clip.html
compositing/background-color/background-color-simple.html
compositing/background-color/background-color-text-change.html
compositing/background-color/background-color-text-clip.html

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::supportsBackgroundColorContent):

Allows different implementation of GraphicsLayer to identify whether they implement setContentsToBackgroundColor.
Currently only the MAC implementation and TextureMapper falls under that category.

  • rendering/RenderBox.h:

(WebCore::RenderBox::paddingBoxRect):

Added paddingBoxRect to compliment borderBoxRect and contentsBoxRect. paddingBoxRect corresponds to
background-clip: padding.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):

Update the background color if needed, for every configuration change.
This should accomodate the old behavior for full-screen, while enabling background color changes for other layers.

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

Move the contentsRect logic to updateContentsRect.

(WebCore::RenderLayerBacking::updateContentsRect):

Use the background box when directly compositing backgrounds.

(WebCore::RenderLayerBacking::updateBackgroundColor):

Set the background color if applicable, otherwise set to trasnparent and clear.
This was not needed in the past because background colors were only used for the special case of full-screen.

(WebCore::supportsDirectBoxDecorationsComposition):

Helper function to determine whether a particular background can be directly composited. Right now only
background color can be composited, and only if the GraphicsLayer implementation supports background colors.
Also we don't yet support background-clip: text and any background-composite other than source-over.

(WebCore::RenderLayerBacking::paintsBoxDecorations):

Apply the new supportsDirectBoxDecorationsComposition logic.

(WebCore::RenderLayerBacking::contentsBox):

Remove unnecessary local variable.

(WebCore::backgroundRectForBox):
(WebCore::RenderLayerBacking::backgroundBox):

Figure out the correct rect for the GraphicsLayer's contentsRect, based on the renderer's backgroundClip.
The rectangle has to be adjusted based on the composited layer offset, and snapped to an IntRect as
GraphicsLayer::contentsRect expects snapped pixels.

LayoutTests:

Created new tests for composited background colors, update existing tests that are affected by the change,
and created platform-specific overrides for Chromium, since it does not yet support composited background
colors.

Patch by No'am Rosenthal <Noam Rosenthal> on 2012-12-07
Reviewed by Simon Fraser.

  • compositing/background-color/background-color-alpha-expected.html: Added.
  • compositing/background-color/background-color-alpha.html: Added.
  • compositing/background-color/background-color-change-to-text-expected.html: Added.
  • compositing/background-color/background-color-change-to-text.html: Added.
  • compositing/background-color/background-color-composite-expected.html: Added.
  • compositing/background-color/background-color-composite.html: Added.
  • compositing/background-color/background-color-container-expected.html: Added.
  • compositing/background-color/background-color-container.html: Added.
  • compositing/background-color/background-color-content-clip-expected.html: Added.
  • compositing/background-color/background-color-content-clip.html: Added.
  • compositing/background-color/background-color-padding-change-expected.html: Added.
  • compositing/background-color/background-color-padding-change.html: Added.
  • compositing/background-color/background-color-padding-clip-expected.html: Added.
  • compositing/background-color/background-color-padding-clip.html: Added.
  • compositing/background-color/background-color-simple-expected.html: Added.
  • compositing/background-color/background-color-simple.html: Added.
  • compositing/background-color/background-color-text-change-expected.html: Added.
  • compositing/background-color/background-color-text-change.html: Added.
  • compositing/background-color/background-color-text-clip-expected.html: Added.
  • compositing/background-color/background-color-text-clip.html: Added.

Added new tests for the specific functionality added, with the edge cases regarding composited
backgrounds.

  • compositing/backing/no-backing-for-clip-expected.txt:
  • compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • compositing/backing/no-backing-for-perspective-expected.txt:
  • compositing/columns/composited-in-paginated-expected.txt:
  • compositing/geometry/ancestor-overflow-change-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • compositing/geometry/clip-expected.txt:
  • compositing/geometry/composited-in-columns-expected.txt:
  • compositing/geometry/flipped-writing-mode-expected.txt:
  • compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
  • compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
  • compositing/geometry/preserve-3d-switching-expected.txt:
  • compositing/iframes/become-composited-nested-iframes-expected.txt:
  • compositing/iframes/become-overlapped-iframe-expected.txt:
  • compositing/iframes/composited-parent-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • compositing/iframes/connect-compositing-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe2-expected.txt:
  • compositing/iframes/connect-compositing-iframe3-expected.txt:
  • compositing/iframes/enter-compositing-iframe-expected.txt:
  • compositing/iframes/iframe-resize-expected.txt:
  • compositing/iframes/invisible-nested-iframe-hide-expected.txt:
  • compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • compositing/iframes/overlapped-iframe-expected.txt:
  • compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • compositing/iframes/page-cache-layer-tree-expected.txt:
  • compositing/iframes/scrolling-iframe-expected.txt:
  • compositing/layer-creation/animation-overlap-with-children-expected.txt:
  • compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • compositing/layer-creation/overflow-scroll-overlap-expected.txt:
  • compositing/layer-creation/overlap-animation-expected.txt:
  • compositing/layer-creation/overlap-child-layer-expected.txt:
  • compositing/layer-creation/overlap-clipping-expected.txt:
  • compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
  • compositing/layer-creation/overlap-transformed-layer-expected.txt:
  • compositing/layer-creation/overlap-transforms-expected.txt:
  • compositing/layer-creation/scroll-partial-update-expected.txt:
  • compositing/layer-creation/spanOverlapsCanvas-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
  • compositing/layer-creation/translatez-overlap-expected.txt:
  • compositing/overflow-trumps-transform-style-expected.txt:
  • compositing/overflow/clip-descendents-expected.txt:
  • compositing/plugins/no-backing-store-expected.txt:
  • compositing/rtl/rtl-absolute-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-fixed-expected.txt:
  • compositing/rtl/rtl-fixed-overflow-expected.txt:
  • compositing/rtl/rtl-relative-expected.txt:
  • compositing/tiled-layers-hidpi-expected.txt:
  • compositing/visible-rect/2d-transformed-expected.txt:
  • compositing/visible-rect/3d-transform-style-expected.txt:
  • compositing/visible-rect/3d-transformed-expected.txt:
  • compositing/visible-rect/animated-expected.txt:
  • compositing/visible-rect/animated-from-none-expected.txt:
  • compositing/visible-rect/clipped-by-viewport-expected.txt:
  • compositing/visible-rect/clipped-visible-rect-expected.txt:
  • compositing/visible-rect/iframe-and-layers-expected.txt:
  • compositing/visible-rect/nested-transform-expected.txt:
  • compositing/visible-rect/scrolled-expected.txt:
  • css3/filters/filtered-compositing-descendant-expected.txt:

Updated existing tests that now print different layer-tree results.

  • platform/chromium/compositing/backing/no-backing-for-clip-expected.txt: Copied from LayoutTests/compositing/backing/no-backing-for-clip-expected.txt.
  • platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt: Copied from LayoutTests/compositing/backing/no-backing-for-clip-overlap-expected.txt.
  • platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt: Copied from LayoutTests/compositing/backing/no-backing-for-perspective-expected.txt.
  • platform/chromium/compositing/columns/composited-in-paginated-expected.txt: Copied from LayoutTests/compositing/columns/composited-in-paginated-expected.txt.
  • platform/chromium/compositing/geometry/ancestor-overflow-change-expected.txt: Copied from LayoutTests/compositing/geometry/ancestor-overflow-change-expected.txt.
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Copied from LayoutTests/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt.
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Copied from LayoutTests/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt.
  • platform/chromium/compositing/geometry/clip-expected.txt: Copied from LayoutTests/compositing/geometry/clip-expected.txt.
  • platform/chromium/compositing/geometry/composited-in-columns-expected.txt: Copied from LayoutTests/compositing/geometry/composited-in-columns-expected.txt.
  • platform/chromium/compositing/geometry/flipped-writing-mode-expected.txt: Copied from LayoutTests/compositing/geometry/flipped-writing-mode-expected.txt.
  • platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Copied from LayoutTests/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt.
  • platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt.
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-positioned-expected.txt.
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt.
  • platform/chromium/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-transformed-expected.txt.
  • platform/chromium/compositing/geometry/preserve-3d-switching-expected.txt: Copied from LayoutTests/compositing/geometry/preserve-3d-switching-expected.txt.
  • platform/chromium/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Copied from LayoutTests/compositing/iframes/invisible-nested-iframe-hide-expected.txt.
  • platform/chromium/compositing/layer-creation/fixed-position-and-transform-expected.txt: Copied from LayoutTests/compositing/layer-creation/fixed-position-and-transform-expected.txt.
  • platform/chromium/compositing/layer-creation/fixed-position-under-transform-expected.txt: Copied from LayoutTests/compositing/layer-creation/fixed-position-under-transform-expected.txt.
  • platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Copied from LayoutTests/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-animation-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-animation-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-child-layer-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-child-layer-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-clipping-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-clipping-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-transformed-layer-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-transformed-layer-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-transforms-expected.txt.
  • platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt: Copied from LayoutTests/compositing/layer-creation/scroll-partial-update-expected.txt.
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-expected.txt: Copied from LayoutTests/compositing/layer-creation/stacking-context-overlap-expected.txt.
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Copied from LayoutTests/compositing/layer-creation/stacking-context-overlap-nested-expected.txt.
  • platform/chromium/compositing/layer-creation/translatez-overlap-expected.txt: Copied from LayoutTests/compositing/layer-creation/translatez-overlap-expected.txt.
  • platform/chromium/compositing/overflow-trumps-transform-style-expected.txt: Copied from LayoutTests/compositing/overflow-trumps-transform-style-expected.txt.
  • platform/chromium/compositing/rtl/rtl-absolute-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-absolute-expected.txt.
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-absolute-overflow-expected.txt.
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt.
  • platform/chromium/compositing/rtl/rtl-fixed-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-fixed-expected.txt.
  • platform/chromium/compositing/rtl/rtl-fixed-overflow-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-fixed-overflow-expected.txt.
  • platform/chromium/compositing/rtl/rtl-relative-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-relative-expected.txt.
  • platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt: Copied from LayoutTests/css3/filters/filtered-compositing-descendant-expected.txt.

Create chromium-specific results since chromium does not yet support setContentsToBackgroundColor.

5:48 PM Changeset in webkit [137005] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebKit2

Allow the WebProcess access to the CoreMedia preferences file.
https://bugs.webkit.org/show_bug.cgi?id=104320
<rdar://problem/10904519>

Reviewed by Alexey Proskuryakov.

Allow read access to ~/Library/Preferences/com.apple.coremedia.plist and com.apple.avfoundation.plist
by the WebProcess. The QuickTime.plugin uses CoreMedia for playback, so allow PluginProcess
to access those preferences as well.

  • PluginProcess/mac/com.apple.WebKit.PluginProcess.sb.in:
  • WebProcess/com.apple.WebProcess.sb.in:
5:19 PM Changeset in webkit [137004] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

[wk2] WebProcessServiceForWebKitDevelopment should forward stdout and stderr to the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=104418

Reviewed by Simon Fraser.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::connectToWebProcessServiceForWebKitDevelopment): Send stdout and stderr file descriptors to the WebProcess.

  • WebProcessServiceForWebKitDevelopment/WebProcessServiceForWebKitDevelopmentMain.mm:

(WebProcessServiceForWebKitDevelopmentEventHandler): Replace the WebProcess' stdout and stderr with those from the UIProcess.

5:17 PM Changeset in webkit [137003] by rniwa@webkit.org
  • 9 edits in trunk/Source/WebCore

Shrink the size of NodeRareData by moving pointers into separate objects
https://bugs.webkit.org/show_bug.cgi?id=104312

Reviewed by Andreas Kling.

This patch does three things:

  1. Move ChildNodeList back into NodeListsNodeData.
  2. Move m_mutationObserverRegistry & m_transientMutationObserverRegistry into a separate object owned by NodeRareData.
  3. Move m_itemProp, m_itemRef, m_itemType & into a separate object owned by NodeRareData.

Moving m_childNodeList from NodeRareData to NodeListsNodeData also has a nice side-effect of making ChildNodeList
behave more like other LiveNodeLists.

This patch also fixes Mac build when microdata is enabled.

There should be no user-visible behavior change.

  • dom/ChildNodeList.cpp:

(WebCore::ChildNodeList::~ChildNodeList):

  • dom/Node.cpp:

(WebCore::Node::childNodes): Moved the code to create ChildNodeList into NodeListsNodeData to match other node lists.
(WebCore::Node::invalidateNodeListCachesInAncestors):
(WebCore): Removed removeCachedChildNodeList.

  • dom/Node.h:

(Node):

  • dom/NodeRareData.cpp:

(WebCore): Assert the size of NodeRareData at compilation time.
(WebCore::NodeListsNodeData::reportMemoryUsage):
(WebCore::NodeRareData::reportMemoryUsage):

  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::clearChildNodeListCache): Moved from NodeRareData.
(WebCore::NodeListsNodeData::ensureChildNodeList): Extracted from Node::childNodes.
(WebCore::NodeListsNodeData::removeChildNodeList): Added.
(WebCore::NodeListsNodeData::NodeListsNodeData): Initialize m_childNodeList.
(WebCore::NodeRareData::NodeMutationObserverData): Extracted from NodeRareData.
(WebCore::NodeRareData::NodeMutationObserverData::create):
(WebCore::NodeRareData::NodeMicroDataTokenLists): Ditto.
(WebCore::NodeRareData::NodeMicroDataTokenLists::create):
(WebCore::NodeRareData::NodeRareData):
(WebCore::NodeRareData::ensureNodeLists): Merged setNodeLists since it's not called elsewhere.
(WebCore::NodeRareData::mutationObserverRegistry):
(WebCore::NodeRareData::ensureMutationObserverRegistry): Added.
(WebCore::NodeRareData::transientMutationObserverRegistry):
(WebCore::NodeRareData::ensureTransientMutationObserverRegistry):
(WebCore::NodeRareData::ensureMicroDataTokenLists):
(NodeRareData):
(WebCore::NodeRareData::itemProp):
(WebCore::NodeRareData::setItemProp):
(WebCore::NodeRareData::itemRef):
(WebCore::NodeRareData::setItemRef):
(WebCore::NodeRareData::itemType):
(WebCore::NodeRareData::setItemType):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::propertyNodeList): Renamed from namedItem since its return type, PropertyNodeList,
is different from that, Node, of LiveNodeList::namedItem. It was shadowing the function name instead of overriding.

  • html/HTMLPropertiesCollection.h:

(HTMLPropertiesCollection):

  • html/HTMLPropertiesCollection.idl:
5:05 PM Changeset in webkit [137002] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
5:00 PM Changeset in webkit [137001] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Make function code cache proportional to main codeblock cache
https://bugs.webkit.org/show_bug.cgi?id=104420

Reviewed by Geoffrey Garen.

Makes the constants determining the recently used function cache proportional
to the number of root codeblocks in the cache. Also renames the constants to
make them more clear.

  • runtime/CodeCache.h:
4:42 PM Changeset in webkit [137000] by senorblanco@chromium.org
  • 1 edit
    3 moves
    3 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening. New baselines for new tests.

  • platform/chromium-mac/css3/filters/effect-reference-after-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-reference-delete-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-reference-rename-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-reference-after-expected.png: Renamed from LayoutTests/platform/chromium-linux/css3/filters/effect-reference-after-expected.png.
  • platform/chromium-win/css3/filters/effect-reference-delete-expected.png: Renamed from LayoutTests/platform/chromium-linux/css3/filters/effect-reference-delete-expected.png.
  • platform/chromium-win/css3/filters/effect-reference-rename-expected.png: Renamed from LayoutTests/platform/chromium-linux/css3/filters/effect-reference-rename-expected.png.
4:40 PM Changeset in webkit [136999] by commit-queue@webkit.org
  • 38 edits in trunk/Source

Unreviewed, rolling out r136993.
http://trac.webkit.org/changeset/136993
https://bugs.webkit.org/show_bug.cgi?id=104415

This patch breaks the mac build (Requested by cabanier on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-07

Source/WebCore:

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

  • platform/graphics/BitmapImage.h:
  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::draw):

  • platform/graphics/CrossfadeGeneratedImage.h:

(CrossfadeGeneratedImage):

  • platform/graphics/GeneratedImage.h:

(GeneratedImage):

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::draw):

  • platform/graphics/GeneratorGeneratedImage.h:

(GeneratorGeneratedImage):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawImageBuffer):
(WebCore::GraphicsContext::setCompositeOperation):

  • platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContextState::GraphicsContextState):
(GraphicsContextState):
(GraphicsContext):

  • platform/graphics/Image.cpp:

(WebCore::Image::draw):
(WebCore::Image::drawTiled):

  • platform/graphics/Image.h:

(Image):

  • platform/graphics/ImageBuffer.h:

(ImageBuffer):

  • platform/graphics/cairo/BitmapImageCairo.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::draw):

  • platform/graphics/cg/PDFDocumentImage.h:

(PDFDocumentImage):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/qt/ImageQt.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/qt/StillImageQt.cpp:

(WebCore::StillImage::draw):

  • platform/graphics/qt/StillImageQt.h:

(StillImage):

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h:

(BitmapImageSingleFrameSkia):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):

  • platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::nativeImageForCurrentFrame):

  • svg/graphics/SVGImage.h:

(SVGImage):

Source/WebKit/chromium:

  • tests/DragImageTest.cpp:

(WebCore::TestImage::draw):

  • tests/ImageLayerChromiumTest.cpp:

(WebCore::TestImage::draw):

Source/WebKit2:

  • win/WebKit2.def.in:
4:38 PM Changeset in webkit [136998] by ap@apple.com
  • 9 edits in trunk/Source

There is no need to change cached resource storage policy through ResourceHandleClient
https://bugs.webkit.org/show_bug.cgi?id=104413

Reviewed by Brady Eidson.

This code was only needed to prevent storing responses to disk in private browsing
mode, but we now have a storage session to take care of that in a cleaner and more
reliable way.

4:16 PM Changeset in webkit [136997] by ap@apple.com
  • 14 edits in trunk/Source/WebKit2

Network process should use a correct storage session in private browsing mode
<rdar://problem/12838490>
https://bugs.webkit.org/show_bug.cgi?id=104401

Reviewed by Brady Eidson.

Notify NetworkProcess when it needs to create or destroy a private browsing session,
and add a NetworkResourceLoadParameters member telling if the particular resource
should be requested using it.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::cookiesForDOM): (WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM): (WebKit::NetworkConnectionToWebProcess::cookiesEnabled): (WebKit::NetworkConnectionToWebProcess::getRawCookies): (WebKit::NetworkConnectionToWebProcess::deleteCookie): (WebKit::NetworkConnectionToWebProcess::getHostnamesWithCookies): (WebKit::NetworkConnectionToWebProcess::deleteCookiesForHostname): (WebKit::NetworkConnectionToWebProcess::deleteAllCookies): Added another dummy argument to dummy networking context.
  • NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::initializeNetworkProcess): Ensure private browsing session if it's needed due to a persistent preference, not an API call at runtime (which is handled below as ensure/destroy).
  • NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::start): Pass private browsing state to RemoteNetworkingContext used for loading. (WebKit::NetworkResourceLoader::willCacheResponse): Added an implemntation that matches WebCore, but may be not needed.
  • NetworkProcess/mac/RemoteNetworkingContext.h: (WebKit::RemoteNetworkingContext::create): Store privateBrowsingEnabled flag.
  • NetworkProcess/mac/RemoteNetworkingContext.mm: (WebKit::RemoteNetworkingContext::storageSession): Return a private session when it's in use.
  • Shared/Network/NetworkProcessCreationParameters.cpp: (WebKit::NetworkProcessCreationParameters::encode): (WebKit::NetworkProcessCreationParameters::decode):
  • Shared/Network/NetworkProcessCreationParameters.h: Pass privateBrowsingEnabled flag to the new process.
  • Shared/Network/NetworkResourceLoadParameters.cpp: (WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters): (WebKit::NetworkResourceLoadParameters::encode): (WebKit::NetworkResourceLoadParameters::decode):
  • Shared/Network/NetworkResourceLoadParameters.h: (WebKit::NetworkResourceLoadParameters::inPrivateBrowsingMode): Pass inPrivateBrowsingMode flag for the request.
  • UIProcess/Network/NetworkProcessManager.h: (WebKit::NetworkProcessManager::process): Exposed, so that we can send messages without going through NetworkProcessManager.
  • UIProcess/WebContext.cpp: (WebKit::WebContext::usesNetworkProcess): (WebKit::anyContextUsesNetworkProcess): (WebKit::WebContext::willStartUsingPrivateBrowsing): (WebKit::WebContext::willStopUsingPrivateBrowsing): Notify NetworkProcess when entering or exiting private browsing.
  • UIProcess/WebContext.h: Exposed usesNetworkProcess() for the new static function anyContextUsesNetworkProcess to use.
  • WebProcess/Network/WebResourceLoadScheduler.cpp: (WebKit::WebResourceLoadScheduler::scheduleLoad): Put current private browsing state over in NetworkResourceLoadParameters.
3:43 PM Changeset in webkit [136996] by adamk@chromium.org
  • 7 edits in trunk

MutationRecord addedNodes/removedNodes should never be null
https://bugs.webkit.org/show_bug.cgi?id=98921

Reviewed by Ryosuke Niwa.

Source/WebCore:

Per an update to the DOM4 spec that matches Gecko's behavior,
addedNodes/removedNodes should be empty NodeLists on 'attributes'
and 'characterData' records, rather than null.

This is accomplished with lazy initialization of addedNodes/removedNodes
attributes on 'attributes'/'characterData' records and the
addition of a new StaticNodeList::createEmpty() factory method.

  • dom/MutationRecord.cpp:
  • dom/MutationRecord.h:

(MutationRecord):

  • dom/StaticNodeList.h:

(WebCore::StaticNodeList::adopt):
(StaticNodeList):
(WebCore::StaticNodeList::createEmpty):
(WebCore::StaticNodeList::StaticNodeList):

LayoutTests:

Updated nullity test to check for empty nodelists.

  • fast/mutation/mutation-record-nullity-expected.txt:
  • fast/mutation/mutation-record-nullity.html:
3:42 PM Changeset in webkit [136995] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build correction after 136959.

The initialization list should follow the same compiler macro
exclusions as the class members.

  • inspector/InstrumentingAgents.h: Add USE(ACCELERATED_COMPOSITING) guards around m_inspectorLayerTreeAgent as this does not exist when the guard is false.
3:34 PM Changeset in webkit [136994] by eae@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

Unreviewed chromium-win rebaselines.

  • platform/chromium-win-xp/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Removed.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
3:33 PM Changeset in webkit [136993] by commit-queue@webkit.org
  • 37 edits in trunk/Source

Extend platform layer so it can pass blend modes to the compositing calls
https://bugs.webkit.org/show_bug.cgi?id=104176

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-12-07
Reviewed by Dirk Schulze.

Source/WebCore:

Adding blend mode enumeration to drawImage functions + stored blendmode in graphics context

No new tests, no new functionality.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

  • platform/graphics/BitmapImage.h:
  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::draw):

  • platform/graphics/CrossfadeGeneratedImage.h:

(CrossfadeGeneratedImage):

  • platform/graphics/GeneratedImage.h:

(GeneratedImage):

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::draw):

  • platform/graphics/GeneratorGeneratedImage.h:

(GeneratorGeneratedImage):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage):
(WebCore):
(WebCore::GraphicsContext::drawImageBuffer):
(WebCore::GraphicsContext::setCompositeOperation):

  • platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContextState::GraphicsContextState):
(GraphicsContextState):
(GraphicsContext):

  • platform/graphics/Image.cpp:

(WebCore::Image::draw):
(WebCore::Image::drawTiled):

  • platform/graphics/Image.h:

(Image):

  • platform/graphics/ImageBuffer.h:

(ImageBuffer):

  • platform/graphics/cairo/BitmapImageCairo.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::draw):

  • platform/graphics/cg/PDFDocumentImage.h:

(PDFDocumentImage):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/qt/ImageQt.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/qt/StillImageQt.cpp:

(WebCore::StillImage::draw):

  • platform/graphics/qt/StillImageQt.h:

(StillImage):

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h:

(BitmapImageSingleFrameSkia):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):

  • platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::nativeImageForCurrentFrame):

  • svg/graphics/SVGImage.h:

(SVGImage):

Source/WebKit/chromium:

Adding blend mode enumeration to draw functions

  • tests/DragImageTest.cpp:

(WebCore::TestImage::draw):

  • tests/ImageLayerChromiumTest.cpp:

(WebCore::TestImage::draw):

3:20 PM Changeset in webkit [136992] by alecflett@chromium.org
  • 10 edits in trunk/Source

IndexedDB: propagate transaction_ids through open/upgradeneeded
https://bugs.webkit.org/show_bug.cgi?id=103922

Reviewed by Tony Chang.

Source/WebCore:

Make sure front-end is always generating the transaction id,
so that it can be relied upon as an alternative to the
to-be-deprecated IDBTransactionBackendInterface pointer.

No new tests, this is one stage in a larger refactor.

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::create):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::VersionChangeOperation):
(IDBDatabaseBackendImpl::VersionChangeOperation):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::transactionId):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::PendingOpenCall):
(IDBDatabaseBackendImpl::PendingOpenCall):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::transactionId):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::PendingOpenWithVersionCall):
(IDBDatabaseBackendImpl::PendingOpenWithVersionCall):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::createTransaction):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendImpl::openConnectionWithVersion):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::openInternal):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::open):

Source/WebKit/chromium:

Update test to account for pre-generated transaction ids.

  • tests/IDBDatabaseBackendTest.cpp:
3:11 PM Changeset in webkit [136991] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk

Implement general ::cue pseudo element for the <video>
https://bugs.webkit.org/show_bug.cgi?id=104043

Patch by Dima Gorbik <dgorbik@apple.com> on 2012-12-07
Reviewed by Eric Carlson.

Source/WebCore:

Implemented the ::cue pseudo element to be able to style all WebVTT cues.
Added the subcontainer with a '::cue' pseudoId in between the TextTrackContainerElement and WebVTT nodes to separate
user agent default styles from user defined styles for the cue elements.

Test: media/track/track-css-all-cues.html

  • css/CSSSelector.cpp: ::cue pseudo selector doesn't have a valid prefix but should be allowed in the user-agent stylesheet.

(WebCore::CSSSelector::parsePseudoType):

  • html/shadow/MediaControlElements.cpp:

(WebCore):
(WebCore::MediaControlTextTrackContainerElement::createSubtrees): create a subcontainer and set its pseudoId to '::cue'.
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): append WebVTT nodes to the newly created subcontainer.

  • html/shadow/MediaControlElements.h:

(MediaControlTextTrackContainerElement):

  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::createTextTrackDisplay): initiate creating subtrees for the MediaControlTextTrackContainerElement.

  • html/shadow/MediaControlsChromium.cpp:

(WebCore::MediaControlsChromium::createTextTrackDisplay):

LayoutTests:

  • media/track/captions-webvtt/styling.vtt: Added.
  • media/track/track-css-all-cues-expected.txt: Added.
  • media/track/track-css-all-cues.html: Added.
3:06 PM Changeset in webkit [136990] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Fix webgl-depth-texture.html to match the test expectation.
https://bugs.webkit.org/show_bug.cgi?id=104259.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-07
Reviewed by Kenneth Russell.

The text expectation of this testcase expects to check for FrameBuffer status and compare the value
using ShouldBe after creating the framebuffer.
Currently, we do it only in case of adding a color buffer. This patch ensures that the Framebuffer
Status check using ShouldBe is done in all cases.

  • fast/canvas/webgl/webgl-depth-texture.html:
2:55 PM Changeset in webkit [136989] by fpizlo@apple.com
  • 5 edits
    3 adds in trunk

Strange results calculating a square root in a loop
https://bugs.webkit.org/show_bug.cgi?id=104247
<rdar://problem/12826880>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Fixed the CFG simplification phase to ignore dead GetLocals in the first of the blocks
under the merge. This fixes the assertion, and is also cleaner: our general rule is
to not "revive" things that we've already proved to be dead.

Also fixed some rotted debug code.

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::fixPossibleGetLocal):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

LayoutTests:

  • fast/js/dfg-cfg-simplify-redundant-dead-get-local-expected.txt: Added.
  • fast/js/dfg-cfg-simplify-redundant-dead-get-local.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-cfg-simplify-redundant-dead-get-local.js: Added.

(getDist):
(calcError):

2:47 PM Changeset in webkit [136988] by eae@chromium.org
  • 1 edit
    5 adds
    2 deletes in trunk/LayoutTests

Unreviewed chromium rebaselines.

  • platform/chromium-linux-x86/ietestcenter: Removed.
  • platform/chromium-linux/compositing/backface-visibility: Added.
  • platform/chromium-linux/compositing/backface-visibility/backface-visibility-webgl-expected.png: Added.
  • platform/chromium-mac/compositing/backface-visibility: Added.
  • platform/chromium-mac/compositing/backface-visibility/backface-visibility-webgl-expected.png: Added.
  • platform/chromium-win-xp/http/tests/w3c/webperf/submission/Intel/user-timing: Removed.
  • platform/chromium-win-xp/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_mark-expected.txt: Removed.
  • platform/chromium-win-xp/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
2:40 PM Changeset in webkit [136987] by nghanavatian@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] General code cleanup and improved logging.
https://bugs.webkit.org/show_bug.cgi?id=104389

Reviewed by Rob Buis.

Internally reviewed by Mike Fenton

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::convertStringToWchar):
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):

2:34 PM Changeset in webkit [136986] by ggaren@apple.com
  • 4 edits in trunk/Source

Crash in JSC::Bindings::RootObject::globalObject() sync'ing notes in Evernote
https://bugs.webkit.org/show_bug.cgi?id=104321
<rdar://problem/12770497>

Reviewed by Sam Weinig.

../JavaScriptCore:

Work around a JSValueUnprotect(NULL) in Evernote.

  • API/JSValueRef.cpp:

(evernoteHackNeeded):
(JSValueUnprotect):

../WebCore:

Missed a null check.

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject JSObject]): If our root object has been cleared, don't
try to dereference it. This happens in Evernote during tear-down.

This matches the behavior of other methods in the same class.

(_isSafeScript returns false if the root object has been cleared.)

If we believe _isSafeScript is a good idea, it's probably the right test
to use here (as opposed to just null-checking _rootObject) because this API
gives the client unlimited access to the underlying JavaScript object.

2:16 PM Changeset in webkit [136985] by eae@chromium.org
  • 5 edits
    2 adds
    2 deletes in trunk/LayoutTests

Unreviewed chromium rebaselines.

  • platform/chromium-linux-x86/ietestcenter/css3: Removed.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
  • platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
  • platform/efl-wk1/ietestcenter/css3/bordersbackgrounds: Added.
  • platform/efl-wk1/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Removed.
2:13 PM Changeset in webkit [136984] by schenney@chromium.org
  • 5 edits in trunk

XMLSerializer is too aggressive in adding prefixes
https://bugs.webkit.org/show_bug.cgi?id=104387

Reviewed by Ryosuke Niwa.

Source/WebCore:

We have been adding "xlink:" and "xmlns:" and "xml:" prefixes to any
attribute that is in one of those namespaces but which did not already
have the matching prefix. This appears to be in error, at least
compared to other browsers.

The correct behavior appears to be to add the prefix only if there is
no existing prefix. If there is an existing prefix, we now leave it alone.

No new tests. Existing test expanded.

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendAttribute): Only replace the prefix
attribute name prefix if it is empty, and in one of the recognised
namespaces.

LayoutTests:

Add a test case for a prefix that is already set, but to a different name than the default.

  • svg/custom/xlink-prefix-in-attributes.html:
  • svg/custom/xlink-prefix-in-attributes-expected.txt:
2:13 PM Changeset in webkit [136983] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[CoordGfx] Variable name starts with upper case character
https://bugs.webkit.org/show_bug.cgi?id=104327

Patch by Helder Correia <Helder Correia> on 2012-12-07
Reviewed by Noam Rosenthal.

Just fixing a typo.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setMaskLayer):

2:08 PM Changeset in webkit [136982] by jonlee@apple.com
  • 4 edits
    2 deletes in trunk/Source/WebCore

Display the auto-start label image after a delay
https://bugs.webkit.org/show_bug.cgi?id=104173
<rdar://problem/12820071>

Reviewed by Dan Bernstein.

Treat the button now as a label. Once the user has hovered over the plug-in, wait a little while before showing the label.

  • rendering/RenderSnapshottedPlugIn.h:

(RenderSnapshottedPlugIn): Add a one-shot timer, and a variable representing whether the label should
be drawn. Remove the variable that determines whether the label is active.

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): Set the time to a delay of 1 second.
(WebCore::RenderSnapshottedPlugIn::paintReplaced): Paint the label only when we should.
(WebCore::RenderSnapshottedPlugIn::paintLabel): The label should only paint in its hovered state.
(WebCore::startLabelImage): Renamed.
(WebCore::RenderSnapshottedPlugIn::repaintLabel): Renamed.
(WebCore::RenderSnapshottedPlugIn::hoverDelayTimerFired): Now that the timer has fired, we should paint
the label. Repaint.
(WebCore::RenderSnapshottedPlugIn::handleEvent): Update event handling. Click event handler is the
same, except we move the label check inside so that if the click is not the left label we don't
fall through to the other irrevelant if clauses.

For the mouse down handler, make sure to check for the left label. If the hover timer is still running,

stop it, so that we don't draw a label while the user is in the middle of a mouse gesture.

Redo mouse over and out. On mouse over we start the delay timer. On mouse out we stop the delay timer

if it is still running, reset state, and paint the label out.
(WebCore::RenderSnapshottedPlugIn::layout): Refactor.

2:04 PM Changeset in webkit [136981] by nghanavatian@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Strip whitespace from learned text.
https://bugs.webkit.org/show_bug.cgi?id=104391

Reviewed by Rob Buis.

This was removing the first word from the sentence being learned. Using
stripWhiteSpace to remove spaces from the start and end of the text.

Internally reviewed by Mike Fenton.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::learnText):

1:48 PM Changeset in webkit [136980] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/win

Remove WebKit2 related projects from WebKit.sln
https://bugs.webkit.org/show_bug.cgi?id=104395

Reviewed by Tim Horton.

  • WebKit.vcproj/WebKit.sln:
1:34 PM Changeset in webkit [136979] by commit-queue@webkit.org
  • 12 edits
    10 deletes in trunk

[chromium] Remove linux theme related files and switch to default
https://bugs.webkit.org/show_bug.cgi?id=103897

Patch by Scott Violet <sky@chromium.org> on 2012-12-07
Reviewed by Dimitri Glazkov.

Source/Platform:

  • Platform.gypi: Remove WebThemeEngine.h
  • chromium/public/linux/WebThemeEngine.h: Removed.

Source/WebCore:

Linux related theme files are now named Default.

No new tests, code cleanup.

  • WebCore.gyp/WebCore.gyp: Update files
  • WebCore.gypi: Update files
  • platform/chromium/PlatformThemeChromiumLinux.cpp: Removed.
  • platform/chromium/PlatformThemeChromiumLinux.h: Removed.
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: Removed.
  • platform/chromium/ScrollbarThemeChromiumLinux.h: Removed.
  • rendering/RenderThemeChromiumAndroid.cpp:

(WebCore::RenderThemeChromiumAndroid::extraDefaultStyleSheet): Linux->Default

  • rendering/RenderThemeChromiumAndroid.h: Change superclass
  • rendering/RenderThemeChromiumLinux.cpp: Removed.
  • rendering/RenderThemeChromiumLinux.h: Removed.

Source/WebKit/chromium:

Linux theme related files are now named Default.

  • WebKit.gyp:
  • public/linux/WebRenderTheme.h: Removed.
  • public/platform/linux/WebThemeEngine.h: Removed.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setScrollbarColors): Cleanup ifdefs.
(WebKit::WebViewImpl::setSelectionColors): Cleanup ifdefs.

  • src/linux/WebRenderTheme.cpp: Removed.

Tools:

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest): linux->default

1:30 PM Changeset in webkit [136978] by eric.carlson@apple.com
  • 10 edits in trunk

Captions menu doesn't update to track changes
https://bugs.webkit.org/show_bug.cgi?id=104393

Reviewed by Dean Jackson.

Source/WebCore:

Flag the captions menu as needing an update when tracks are added or removed. Don't actually
change the menu until it needs to be displayed.

No new tests, media/video-controls-captions-trackmenu.html was updated to test this.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::addTextTrack): Call closedCaptionTracksChanged().
(WebCore::HTMLMediaElement::didRemoveTrack): Ditto.
(WebCore::HTMLMediaElement::configureTextTracks): Ditto.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlClosedCaptionsTrackListElement::MediaControlClosedCaptionsTrackListElement):

Intialize m_trackListHasChanged.

(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay): Call rebuildTrackListMenu if

the track list has changed.

(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu): Renamed from resetTrackListMenu.

  • html/shadow/MediaControlElements.h:

(WebCore::MediaControlClosedCaptionsTrackListElement::resetTrackListMenu): Just set m_trackListHasChanged.

  • html/shadow/MediaControls.h:

(WebCore::MediaControls::closedCaptionTracksChanged): New, do nothing for base class.

  • html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsApple::toggleClosedCaptionTrackList): Update the track list before

showing it.

(WebCore::MediaControlsApple::closedCaptionTracksChanged):

  • html/shadow/MediaControlsApple.h:

LayoutTests:

Test to ensure that the captions menu is updated as tracks added and removed.

  • media/video-controls-captions-trackmenu-expected.txt:
  • media/video-controls-captions-trackmenu.html:
1:29 PM ViewportInteractionTopics edited by kenneth@webkit.org
(diff)
1:27 PM ViewportInteractionTopics edited by kenneth@webkit.org
(diff)
1:26 PM Changeset in webkit [136977] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
1:15 PM Changeset in webkit [136976] by kenneth@webkit.org
  • 20 edits in trunk/Source/WebKit2

[WK2][EFL][Qt] Pixel alignment is wrong in some cases involving a non-integral content scale
https://webkit.org/b/103519

Reviewed by Noam Rosenthal.

This patch removes the blurriness by pixel aligning the layers. It
does not fully remove the shaking, only minimizes it.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::transformFromScene):
(EwkViewImpl::displayTimerFired):

  • UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl::pagePosition):

As the pixel alignment of the main layer is moved to the
PageViewportController, rename discretePagePosition to just
pagePosition. It now returns a FloatPoint but the positions
should still be discrete.

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::setVisibleContentsRect):
(WebKit::LayerTreeCoordinatorProxy::didChangeScrollPosition):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::didChangeScrollPosition):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::visibleContentsRect):
(WebKit::LayerTreeCoordinator::setVisibleContentsRect):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.messages.in:
  • WebProcess/WebPage/LayerTreeHost.h:

(WebCore):
(WebKit::LayerTreeHost::setVisibleContentsRect):

Change the internal scroll position/visible contents rect
to be represented as float positions. The rounding to integer
values not happens just before setFixesVisibleContentsRect.
This makes it possible to know our exact positions and
calculate proper scroll deltas.

(WebKit::LayerTreeRenderer::setLayerState):

Group anchor point, position and size together.

  • UIProcess/PageViewportController.h:

(PageViewportController):

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::boundContentsPosition):
(WebKit::PageViewportController::boundContentsPositionAtScale):
(WebKit::PageViewportController::didRenderFrame):
(WebKit::PageViewportController::pageDidRequestScroll):
(WebKit::PageViewportController::didChangeContentsVisibility):
(WebKit::PageViewportController::syncVisibleContents):
(WebKit::PageViewportController::visibleContentsSize):
(WebKit::PageViewportController::applyPositionAfterRenderingContents):

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::focusEditableArea):
(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):
(WebKit::PageViewportControllerClientQt::nearestValidVisibleContentsRect):

Some renaming as what was called viewportPos was actually the
contents position. Rename clampViewportToContents to
boundContentsPosition and remove scale argument which is has
direct access to.

Make the boundContentsPosition allow one extra pixel in each
orientation to allow for pixel alignment of fixed position layers

(WebKit::isIntegral):
(WebKit):
(WebKit::PageViewportController::pixelAlignedFloatPoint):

Introduce way to pixel align the main contents layer. Only in
use for EFL so far.

  • UIProcess/efl/PageClientLegacyImpl.cpp:

(WebKit::PageClientLegacyImpl::updateViewportSize):

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::setViewportPosition):

  • UIProcess/efl/PageViewportControllerClientEfl.h:

(WebKit::PageViewportControllerClientEfl::contentPosition):
(PageViewportControllerClientEfl):

Store the contents position as a FloatPoint.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
(WebCore::CoordinatedGraphicsLayer::setMaskLayer):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::isIntegral):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::computePositionRelativeToBase):
(WebCore::CoordinatedGraphicsLayer::computePixelAlignment):
(WebCore::CoordinatedGraphicsLayer::computeTransformedVisibleRect):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):

Pixel align layers when the effective scale is not an integer
value. This code is based on code from GraphicsLayerCA.

12:56 PM Changeset in webkit [136975] by senorblanco@chromium.org
  • 20 edits
    17 adds in trunk

CSS url() filters with forward references don't work
https://bugs.webkit.org/show_bug.cgi?id=90405

Based on a patch by Keyar Hood.

Reviewed by Dirk Schulze.

Source/WebCore:

In order for CSS to reference SVG filters that will occur later in
the document, or will be added at a future time, we need a way to
notify the target element (the one the filter style is applied to)
when the correct SVG filter is added to the DOM.
There is already code for SVG elements that handles this problem, in
SVGResourcesCache. This patch allows any element to have a reference to
an SVG element in SVGResourceCache.

Tests: css3/filters/effect-reference-after.html

css3/filters/effect-reference-delete-crash.html
css3/filters/effect-reference-delete.html
css3/filters/effect-reference-rename.html
css3/filters/effect-reference-reset-style-delete-crash.html
svg/filters/filter-cycle.html

  • dom/Element.cpp:

(WebCore::Element::hasPendingResources): Added
(WebCore::Element::setHasPendingResources): Added
(WebCore::Element::clearHasPendingResources): Added

  • dom/Element.h:

Accessors for ElementRareData's new bit flag.
(WebCore::Element::buildPendingResource):
Virtual function to override for referenced elements (moved from SVGElement).

  • dom/ElementRareData.h:

(WebCore::ElementRareData::ElementRareData):
Add a new bit flag to indicate whether the element depends on pending resources or not.

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::applyFilters):
Changed to the new function signature for FilterEffectRenderer::build().

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter):
Changed signature to accept a RenderObject rather than a Document, so we know which node to notify when the SVG filter arrives. If the referenced filter cannot be found, add its id as a pending reference.
(WebCore::FilterEffectRenderer::build):
Changed signature to accept a RenderObject rather than a Document, so we know which node to notify when the SVG filter arrives.

  • rendering/FilterEffectRenderer.h:

Change to signatures of build() and buildReferenceFilter() to pass
a RenderObject instead of a Document.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateOrRemoveFilterEffectRenderer):
Use the new semantics for FilterEffectRenderer::build().

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):
Notify the cache if a RenderObject is destroyed.

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::registerResource):
Call clearHasPendingResourceIfPossible on the SVGDocumentExtensions, not
on the element, since we want to support generic Elements.

  • rendering/svg/SVGResources.cpp:

(WebCore::SVGResources::buildCachedResources):
Add support for building filters on non-SVG elements.

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::addResourcesFromRenderObject):
Do cycle detection only on SVG elements.
(WebCore::SVGResourcesCache::clientStyleChanged):
For non-SVG elements, set a synthetic style change when parent resources
are invalidated.
(WebCore::SVGResourcesCache::resourceDestroyed):
Add support for non-SVG Elements.

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::addPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::isElementPendingResource):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResourcesForRemoval):
Changed to allow use of Element instead of SVGElement.
(WebCore::SVGDocumentExtensions::clearHasPendingResourcesIfPossible):
Moved from SVGElement, and made to work on any Element. This way,
we avoid adding this function to Element itself.

  • svg/SVGDocumentExtensions.h:

SVGElement -> Element.

  • svg/SVGElement.cpp:
  • svg/SVGElement.h:

All functions moved to Element, except for clearHasPendingResourcesIfPossible() moved to SVGDocumentExtensions.

  • svg/SVGElementRareData.h:

(WebCore::SVGElementRareData::SVGElementRareData):
m_hasPendingResources add accessors moved to ElementRareData.

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
SVGElement -> Element, and call SVGDocumentExtensions for
clearHasPendingResourcesIfPossible().

LayoutTests:

  • css3/filters/effect-reference-after-expected.txt: Added.
  • css3/filters/effect-reference-after.html: Added.
  • css3/filters/effect-reference-delete-crash-expected.txt: Added.
  • css3/filters/effect-reference-delete-crash.html: Added.
  • css3/filters/effect-reference-delete-expected.txt: Added.
  • css3/filters/effect-reference-delete.html: Added.
  • css3/filters/effect-reference-rename-expected.txt: Added.
  • css3/filters/effect-reference-rename.html: Added.
  • css3/filters/effect-reference-reset-style-delete-crash-expected.txt: Added.
  • css3/filters/effect-reference-reset-style-delete-crash.html: Added.
  • css3/filters/script-tests/effect-reference-delete-crash.js: Added.
  • css3/filters/script-tests/effect-reference-reset-style-delete-crash.js: Added.
  • svg/filters/filter-cycle.html: Added.
  • svg/filters/filter-cycle-expected.html: Added.
  • platform/chromium-linux/css3/filters/effect-reference-after-expected: Added.
  • platform/chromium-linux/css3/filters/effect-reference-delete-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-reference-rename-expected.png: Added.
  • platform/chromium/TestExpectations:
12:52 PM Changeset in webkit [136974] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Add shortcut to set visibility:hidden on elements in the ElementsPanel
https://bugs.webkit.org/show_bug.cgi?id=104146

Patch by Eberhard Graether <egraether@google.com> on 2012-12-07
Reviewed by Pavel Feldman.

This change adds the shortcut H to set and unset visibility:hidden on the inline style
of elements in the Elementspanel. This feature makes it easier to look for elements that
cause bad rendering performance, because visibility:hidden does not paint the element,
but preserves the layout.

No new tests.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.toggleInlineVisibility):

  • inspector/front-end/ElementsPanelDescriptor.js:

(WebInspector.ElementsPanelDescriptor.prototype.registerShortcuts):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype.handleShortcut):

  • inspector/front-end/KeyboardShortcut.js:
12:47 PM Changeset in webkit [136973] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r136770): Assertion failure in sendMessage() whenever WebProcess crashes
https://bugs.webkit.org/show_bug.cgi?id=104392

Reviewed by Anders Carlsson.

  • Shared/ChildProcessProxy.cpp: (WebKit::ChildProcessProxy::sendMessage): Changed back to using m_conection where it can be null.
12:41 PM Changeset in webkit [136972] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Improve our decoded data size estimation for style sheets.
<http://webkit.org/b/104388>

Reviewed by Antti Koivisto.

Tweak how we estimate the total decoded size of a given style sheet. (We were guessing at about 30% of actual size.)
This is just used as a hint to the WebCore cache.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::averageSizeInBytes):

  • css/StyleRule.cpp:

(WebCore::StyleRule::averageSizeInBytes):

12:39 PM Changeset in webkit [136971] by alexis@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening.

css3/calc/background-position-parsing.html is now working as
webkit.org/b/104131 has been fixed. I also rebased
background_position_three_four_values-expected.png which was incorrect and
now with the CSS3 background-position offsets it renders correctly.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
12:34 PM Changeset in webkit [136970] by alexis@webkit.org
  • 4 edits in trunk

[Chromium] Enable CSS3 background-position offset by default.
https://bugs.webkit.org/show_bug.cgi?id=104253

Reviewed by Tony Chang.

Source/WebKit/chromium:

Turn on the feature by default.

  • features.gypi:

LayoutTests:

Enable by default the new CSS3 background position offsets therefore we
can unskip the tests.

  • platform/chromium/TestExpectations:
12:22 PM Changeset in webkit [136969] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] GeolocationClientBB should show file system path in prompts when host is not avaliable
https://bugs.webkit.org/show_bug.cgi?id=103785

PR 247656

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-12-07
Reviewed by Rob Buis.

Adding a special case for origins with protocol "file". We will use the filepath as
an origin when asking for geolocation permission.

If the origin is unique (ie. from a sandboxed iframe), we will fail the location request
right away.

  • WebCoreSupport/GeolocationClientBlackBerry.cpp:

(getOrigin):
(GeolocationClientBlackBerry::requestPermission):
(GeolocationClientBlackBerry::cancelPermissionRequest):

11:34 AM Changeset in webkit [136968] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Enable Intel's Resource Timing tests
https://bugs.webkit.org/show_bug.cgi?id=104330

Reviewed by Tony Gentilcore.

  • platform/chromium/TestExpectations: 2 fail because they rely on iframes.
11:30 AM Changeset in webkit [136967] by robert@webkit.org
  • 3 edits
    4 adds in trunk

REGRESSION(r127163): Content is offset to the right at rea.ru
https://bugs.webkit.org/show_bug.cgi?id=103116

Reviewed by David Hyatt.

Source/WebCore:

The top margin edge of a self-collapsing block that clears a float intrudes up into it by the height of the margin,
so to ensure any child floats of the self-collapsing block only go as far as the top content edge
add the margin back in to the block's current height before placing them.

Tests: fast/block/margin-collapse/self-collapsing-block-with-float-child-collapsed-margins.html

fast/block/margin-collapse/self-collapsing-block-with-float-child.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):

LayoutTests:

  • fast/block/margin-collapse/self-collapsing-block-with-float-child-collapsed-margins-expected.html: Added.
  • fast/block/margin-collapse/self-collapsing-block-with-float-child-collapsed-margins.html: Added.
  • fast/block/margin-collapse/self-collapsing-block-with-float-child-expected.html: Added.
  • fast/block/margin-collapse/self-collapsing-block-with-float-child.html: Added.
11:23 AM Changeset in webkit [136966] by alexis@webkit.org
  • 3 edits in trunk/Source/WebCore

Improve r136754 by hardening checks of expected values for background-position.
https://bugs.webkit.org/show_bug.cgi?id=104380

Reviewed by Antti Koivisto.

r136754 was landed to fix the problem of checking successively two calc
values with validUnit. It was asserting as validUnit expect you to use
the parsed value of the calc after the call. In this case we pre-check the
background-position longhand to count how many values it has to then
call the right parsing functions accordingly. While r136754 is not
wrong it is better to harden isPotentialPositionValue with the real
expected units and keywords. For this matter we can reuse the
ReleaseParsedCalcValueCondition enum which was created with the same
idea as this patch. If you are not interested of the calc parsed
value when calling validUnit() you can now specify it, I believe it is
good to have it explicit to avoid mistake in the future.

No new tests : this is covered by css3/*, fast/backgrounds/*.

  • css/CSSParser.cpp:

(WebCore::CSSParser::validCalculationUnit):
(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::isPotentialPositionValue):

  • css/CSSParser.h:

(WebCore::CSSParser::validUnit):
(CSSParser):

11:16 AM Changeset in webkit [136965] by commit-queue@webkit.org
  • 5 edits in trunk

[BlackBerry] Update BlackBerry Port to use new Graphics::createBuffer BufferType enum values.
https://bugs.webkit.org/show_bug.cgi?id=104121

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-12-07
Reviewed by Rob Buis.

Source/WebKit/blackberry:

Update createBuffer calls to reflect new BufferType enum.
Set buffers opaque if possible to avoid unnecessary blends.
Internal PR 254649
Internal Review: Jakob Petsovits

  • WebKitSupport/BackingStoreTile.cpp:

(BlackBerry::WebKit::TileBuffer::nativeBuffer):

Tools:

Update createBuffer call to reflect new BufferType enum.
Internal PR 254649
Internal Review: Jakob Petsovits

DRT is always backed for maximum compatibility.

  • DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:

(createBitmapContextFromWebView):

11:10 AM Changeset in webkit [136964] by bfulgham@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove unnecessary casts in transformations.
https://bugs.webkit.org/show_bug.cgi?id=104376

Reviewed by Simon Fraser.

Several casts from float-to-double are performed prior to
storing the result in a double type. These casts are unnecessary
overhead and reduce the clarity of the source code.

No new tests. Covered by existing CSS test cases.

  • platform/graphics/transforms/RotateTransformOperation.cpp:
  • platform/graphics/transforms/TransformationMatrix.cpp:
10:49 AM Changeset in webkit [136963] by mkwst@chromium.org
  • 4 edits in trunk/LayoutTests

fast/frames/sandboxed-iframe-scripting.html contains very misleading comments.
https://bugs.webkit.org/show_bug.cgi?id=104363

Reviewed by Darin Adler.

The comments in this test describe a state that is in fact the opposite
of what's being tested. That confused me. This patch corrects the
comments to make it clear that adding a sandbox attribute at runtime has
no effect on the frame; the sandboxing flags are set when the nested
browsing context is _navigated_, not when the attribute changes value.

Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#attr-iframe-sandbox

  • fast/frames/resources/sandboxed-iframe-script-dynamic.html:
  • fast/frames/sandboxed-iframe-scripting-expected.txt:
  • fast/frames/sandboxed-iframe-scripting.html:
10:26 AM Changeset in webkit [136962] by jochen@chromium.org
  • 2 edits in trunk/Tools

Add 'CHROMIUM_DEVEL_SANDBOX' to the environment variables to copy for layout test drivers
https://bugs.webkit.org/show_bug.cgi?id=104355

Reviewed by Dirk Pranke.

This enables chromium's content_shell driver to run with the full SUID
sandbox.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.to.setup_environ_for_server):

10:16 AM Changeset in webkit [136961] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Double zoom animation when focusing on input field.
https://bugs.webkit.org/show_bug.cgi?id=104375

Patch by Andrew Lo <anlo@rim.com> on 2012-12-07
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.

UI thread does not need to be notified of a scale change if the WebKit
thread scale has not changed.

This caused issues when two viewport resizes occured one after the other.
Before the scale change due to the first resize could be set in the WK
thread's scale value, it caused WK thread to dispatch a scaleChanged,
overwritting & resetting the new UI thread scale value, resulting in the
double zoom animation.

The larger issue dealing with synchronization between the threads where
scale changes could occur on either thread, however that is beyond the
scope of this change.

Internal PR253122

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::shouldZoomAboutPoint):

10:07 AM Changeset in webkit [136960] by tony@chromium.org
  • 14 edits
    2 copies in branches/chromium/1312

Merge 136878

REGRESSION(r135082): Restore the ability to insert author level style sheets from script
https://bugs.webkit.org/show_bug.cgi?id=104042

Reviewed by Antti Koivisto.

.:

Update exports for Internals.cpp.

  • Source/autotools/symbols.filter:

Source/WebCore:

Add DocumentStyleSheetCollection::addAuthorSheet so embedders can allow scripts
to insert author level styles. Expose the method to window.interals for testing.

Test: userscripts/insert-stylesheets.html

  • WebCore.exp.in: Update exports for Internals.cpp.
  • WebCore.order: Update exports for Internals.cpp.
  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::addAuthorSheet): Add the stylesheet and force a style recalc.
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets): Include author level styles.
(WebCore::DocumentStyleSheetCollection::reportMemoryUsage): Include author styles.

  • dom/DocumentStyleSheetCollection.h:

(WebCore::DocumentStyleSheetCollection::documentAuthorStyleSheets): Accessor.
(DocumentStyleSheetCollection): Keep track of author styles added by script.

  • testing/Internals.cpp:

(WebCore::Internals::insertAuthorCSS): Testing addAuthorSheet.
(WebCore::Internals::insertUserCSS): Testing addUserSheet.

  • testing/Internals.h:
  • testing/Internals.idl: Add addAuthorSheet and addUserSheet.

Source/WebKit/chromium:

  • src/WebDocument.cpp:

(WebKit::WebDocument::insertUserStyleSheet): Use addAuthorSheet if an author level script is requested.

Source/WebKit2:

Update exports for Internals.cpp.

  • win/WebKit2.def.in:

LayoutTests:

Add a test that makes sure that an author level style is set.

  • userscripts/insert-stylesheets-expected.txt: Added.
  • userscripts/insert-stylesheets.html: Added.

TBR=tony@chromium.org
Review URL: https://codereview.chromium.org/11471034

9:54 AM Changeset in webkit [136959] by commit-queue@webkit.org
  • 19 edits
    4 adds in trunk

Provide the backend for exposing the layer tree to the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=103513

Patch by Antoine Quint <Antoine Quint> on 2012-12-07
Reviewed by Pavel Feldman.

Source/WebCore:

The purpose of this patch is to provide a new agent enabling the Web Inspector to interface
with WebCore to access information about the render layer tree and, more specifically, expose
useful information about layers backed by textures composited on the GPU such as metrics and
backing store. Thus we now provide a LayerTreeAgent which will inform the front-end of
changes to the render layer tree via a new layerTreeDidChange event, providing an object
containing the entire hierarchy of RenderLayers for the inspected document. This hierarchy
can be queried at any time using the .getLayerTree() method on the LayerTreeAgent. Finally,
the LayerTreeAgent also exposes a .nodeIdForLayerId() method allowing to get the id of the
node associated with the RenderLayer with the provided layer id.

In terms of implementation, RenderLayerCompositor has been changed such that in its
updateCompositingLayers() method we call the layerTreeDidChange method on the
InspectorLayerTreeAgent instance via the InspectorInstrumentation.

Test: inspector-protocol/layer-tree.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/Inspector.json: Define new types IntRect (x, y, width, height) and Layer, which

holds the information for a RenderLayer (layerId, bounds, isComposited, memory,
compositedBounds) and its children (childLayers). We also define the methods of the
LayerTreeAgent object (enable, disable, getLayerTree, nodeIdForLayerId) and the
layerTreeDidChange event it
fires.

  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::pushNodePathForRenderLayerToFrontend): New method facilitating
pushing the node associated with a given RenderLayer to the front-end.
(WebCore):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::layerTreeDidChangeImpl):
(WebCore::InspectorInstrumentation::renderLayerDestroyedImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::layerTreeDidChange):
(WebCore::InspectorInstrumentation::renderLayerDestroyed):

  • inspector/InspectorLayerTreeAgent.cpp: Added.

(WebCore):
(LayerTreeAgentState):
(WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):
(WebCore::InspectorLayerTreeAgent::~InspectorLayerTreeAgent):
(WebCore::InspectorLayerTreeAgent::setFrontend):
(WebCore::InspectorLayerTreeAgent::clearFrontend):
(WebCore::InspectorLayerTreeAgent::restore):
(WebCore::InspectorLayerTreeAgent::reset):
(WebCore::InspectorLayerTreeAgent::enable):
(WebCore::InspectorLayerTreeAgent::disable):
(WebCore::InspectorLayerTreeAgent::layerTreeDidChange):
(WebCore::InspectorLayerTreeAgent::renderLayerDestroyed):
(WebCore::InspectorLayerTreeAgent::getLayerTree):
(WebCore::InspectorLayerTreeAgent::buildObjectForRootLayer):
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer): Build the entire hierarchy of
RenderLayers from the provided RenderLayer.
(WebCore::InspectorLayerTreeAgent::buildObjectForIntRect):
(WebCore::InspectorLayerTreeAgent::bind):
(WebCore::InspectorLayerTreeAgent::unbind):
(WebCore::InspectorLayerTreeAgent::nodeIdForLayerId):

  • inspector/InspectorLayerTreeAgent.h: Added.

(WebCore):
(InspectorLayerTreeAgent):
(WebCore::InspectorLayerTreeAgent::create):

  • inspector/InstrumentingAgents.h:

(WebCore):
(WebCore::InstrumentingAgents::InstrumentingAgents):
(InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorLayerTreeAgent):
(WebCore::InstrumentingAgents::setInspectorLayerTreeAgent):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers): Call the layerTreeDidChange method
on the LayerTreeAgent via the InspectorInstrumentation to inform the front-end that the
RenderLayer hierarchy has changed.
(WebCore):
(WebCore::RenderLayerCompositor::layerBecameNonComposited): Call the renderLayerDestroyed
method on the LayerTreeAgent via the InspectorInstrumentation to unbind the layer that is
being destroyed.

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

LayoutTests:

Adding a LayoutTest that exercises the various APIs and event exposed by the LayerTreeAgent.
This test is skipped on EFL where ACCELERATED_COMPOSITING is not available.

  • inspector-protocol/layer-tree-expected.txt: Added.
  • inspector-protocol/layer-tree.html: Added.
  • platform/efl/TestExpectations:
9:52 AM Changeset in webkit [136958] by jsbell@chromium.org
  • 8 edits in trunk/Source/WebCore

IndexedDB: Check SSV version when opening database
https://bugs.webkit.org/show_bug.cgi?id=102243

Reviewed by Tony Chang.

Ensure that the data format (SerializedScriptValue) isn't "from the future" when opening
a backing store. Treat an unknown version the same as an unknown schema version.

Chromium-side test at https://codereview.chromium.org/11470013/ (same as other schema version tests)

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore):
(WebCore::isSchemaKnown): Check data version as well.
(WebCore::setUpMetadata): Ensure data version is recorded; bump schema version.

  • Modules/indexeddb/IDBLevelDBCoding.cpp: Encoding for "DataVersion" global metadata entry.

(IDBLevelDBCoding):
(WebCore::IDBLevelDBCoding::compare):
(WebCore::IDBLevelDBCoding::DataVersionKey::encode):

  • Modules/indexeddb/IDBLevelDBCoding.h:

(DataVersionKey):
(IDBLevelDBCoding):

  • bindings/js/SerializedScriptValue.cpp:

(SerializedScriptValue::wireFormatVersion): New method (JSC side).

  • bindings/js/SerializedScriptValue.h:
  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::wireFormatVersion): New method (V8 side).
(WebCore):

  • bindings/v8/SerializedScriptValue.h:

(SerializedScriptValue):

8:54 AM Changeset in webkit [136957] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Fix tools for WebKit2-only builds
https://bugs.webkit.org/show_bug.cgi?id=103904

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-12-07
Reviewed by Laszlo Gombos.

The libewebkit2.so should be used for library path for EFL WebKit2.

  • Scripts/webkitdirs.pm:

(builtDylibPathForName):

8:39 AM QtWebKit edited by jocelyn.turcotte@digia.com
Quick cleanup to remove deprecated or misleading information. Those … (diff)
8:32 AM Changeset in webkit [136956] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Throw away StyleResolvers that haven't been used for a long time.
<http://webkit.org/b/104314>

Reviewed by Antti Koivisto.

A lot of memory gets tied up in StyleResolver and the structures and caches that hang from it.
Add a mechanism to throw it away after it's been unused for a while (1 minute.)
This frees up large amounts of memory on inactive pages (background tabs) and static content.

We already have a number of scenarios where the document style is invalidated by throwing away
the StyleResolver so the major code paths are prepared for having a null StyleResolver* on occasion.

~20MB progression on Membuster3.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):

Call document()->didAccessStyleResolver() from the relevant parts of StyleResolver's public API.
This prevents Document from throwing the StyleResolver away for 1 minute after it's used.

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::createStyleResolver):
(WebCore::Document::didAccessStyleResolver):
(WebCore::Document::styleResolverThrowawayTimerFired):

Add a mechanism to call clearStyleResolver() on a refreshing timer.

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

If an attribute change occurs while the document doesn't have a StyleResolver, dirty the element style
since we can't be sure that the attribute change didn't affect any rules.

8:09 AM Changeset in webkit [136955] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding an image mismatch expectation for fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-002.html.

  • platform/gtk/TestExpectations:
7:51 AM Changeset in webkit [136954] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r136947): Made two tests fail on all platforms (Requested by tonikitoo-ll on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=104368

Unreviewed partial rollout.

r136947 was too aggressive in the sense of fixing RenderBox::canBeScrolledAndHasScrollableArea
as part of itself. Revert the related changes in order to fix both
fast/events/autoscroll-should-not-stop-on-keypress.html and
fast/events/autoscroll-in-textfield.html

Patch by Antonio Gomes <a1.gomes@sisa.samsung.com> on 2012-12-07

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::canBeScrolledAndHasScrollableArea):

  • rendering/RenderBox.h:
7:02 AM Changeset in webkit [136953] by allan.jensen@digia.com
  • 5 edits in trunk

[TexMap] Can not do multiple accelerated animations
https://bugs.webkit.org/show_bug.cgi?id=104364

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

By removing all animations with the same name, it is not possible to animate more than one property accelerated.
Instead only remove any animations with both same name and property.

Covered by animations/opacity-transform-animation.html.

  • platform/graphics/GraphicsLayerAnimation.cpp:

(WebCore::GraphicsLayerAnimations::add):
(WebCore::GraphicsLayerAnimations::remove):

  • platform/graphics/GraphicsLayerAnimation.h:

(GraphicsLayerAnimations):

LayoutTests:

Unskip test animating multiple accelerated properties.

  • platform/qt/TestExpectations:
6:52 AM Changeset in webkit [136952] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Fix build warning in StyleResolver.cpp using gcc 4.7.2
https://bugs.webkit.org/show_bug.cgi?id=104262

Patch by Sujin Park <sujjin.park@gmail.com> on 2012-12-07
Reviewed by Alexis Menard.

EFL port treats build warning as compile error and there are
maybe-uninitialized when building with gcc 4.7.2.
This patch adds default case to resolve a build break.

  • css/StyleResolver.cpp:

(WebCore::getFontAndGlyphOrientation):

6:47 AM Changeset in webkit [136951] by pilgrim@chromium.org
  • 3 edits
    1 add in trunk/Source/WebKit/chromium

[Chromium] Move WorkerContextProxy::create out of PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=104151

Reviewed by Kentaro Hara.

Doesn't really solve the layering violation as much as kick it
down the road a bit. Part of a refactoring series; see tracking
bug 82948.

  • WebKit.gyp:
  • src/PlatformSupport.cpp:

(WebCore):

  • src/WorkerContextProxy.cpp: Added.

(WebCore):
(WebCore::WebCore::WorkerContextProxy::create):

6:30 AM Changeset in webkit [136950] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] Ctrl + ']' "Goto right panel" keyboard shortcut doesn't work
https://bugs.webkit.org/show_bug.cgi?id=104250

Reviewed by Pavel Feldman.

Ignore "keypress" event resulting from a WM_CHAR message emitted by Win7 upon Ctrl + ']' keypress.

  • inspector/front-end/InspectorView.js:

(WebInspector.InspectorView.prototype._keyPress): Ignore all events with charCode < 32.

6:13 AM Changeset in webkit [136949] by pfeldman@chromium.org
  • 18 edits in trunk

Web Inspector: provide a way to reload page with given script preprocessor.
https://bugs.webkit.org/show_bug.cgi?id=80992

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change introduces a way to inject 'preprocessor' script that would process
each JavaScript file before it gets into the VM for compilation. That way inspector
can expose capabilities such as assessing code coverage or tracing all the calls.

Preprocessor script is stored in the page agent where it waits for reload to happen.
Upon reload, ScriptDebugServer is using it to patch the script sources.

Test: inspector/debugger/debugger-script-preprocessor.html

  • bindings/js/ScriptDebugServer.h:

(WebCore::ScriptDebugServer::setScriptPreprocessor):
(ScriptDebugServer):

  • bindings/v8/DebuggerScript.js:
  • bindings/v8/ScriptDebugServer.cpp:

(ScriptDebugServer::ScriptPreprocessor):
(WebCore::ScriptDebugServer::ScriptPreprocessor::ScriptPreprocessor):
(WebCore::ScriptDebugServer::ScriptPreprocessor::preprocessSourceCode):
(WebCore::ScriptDebugServer::ScriptPreprocessor::~ScriptPreprocessor):
(WebCore):
(WebCore::ScriptDebugServer::~ScriptDebugServer):
(WebCore::ScriptDebugServer::setScriptSource):
(WebCore::ScriptDebugServer::setScriptPreprocessor):
(WebCore::ScriptDebugServer::handleV8DebugEvent):

  • bindings/v8/ScriptDebugServer.h:

(ScriptDebugServer):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::reload):
(WebCore::InspectorPageAgent::frameNavigated):

  • inspector/InspectorPageAgent.h:

(WebCore::InspectorPageAgent::page):
(WebCore::InspectorPageAgent::scriptPreprocessor):
(InspectorPageAgent):

  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::create):
(WebCore::PageDebuggerAgent::PageDebuggerAgent):
(WebCore::PageDebuggerAgent::startListeningScriptDebugServer):
(WebCore::PageDebuggerAgent::stopListeningScriptDebugServer):
(WebCore::PageDebuggerAgent::injectedScriptForEval):
(WebCore::PageDebuggerAgent::didClearMainFrameWindowObject):
(WebCore):

  • inspector/PageDebuggerAgent.h:

(WebCore):
(PageDebuggerAgent):

LayoutTests:

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest.InspectorTest.hardReloadPage):
(initialize_InspectorTest.InspectorTest.reloadPage):
(initialize_InspectorTest.InspectorTest._innerReloadPage):

  • inspector/debugger/debugger-script-preprocessor-expected.txt: Added.
  • inspector/debugger/debugger-script-preprocessor.html: Added.
  • platform/chromium/inspector/debugger/debugger-script-preprocessor-expected.txt: Added.
5:22 AM Changeset in webkit [136948] by apavlov@chromium.org
  • 5 edits
    2 adds in trunk

Web Inspector: the "Sources" column is always empty in CSS selector profiles
https://bugs.webkit.org/show_bug.cgi?id=104225

Reviewed by Pavel Feldman.

Source/WebCore:

r112923 and preceding changesets modified the CSSOM wrapper creation for StyleRules in a way
that would not specify the parent CSSStyleSheet for the CSSStyleRules created. Instead,
styleResolver->ensureFullCSSOMWrapperForInspector(rule) is now used to make sure the CSSStyleRule
has a valid parent CSSStyleSheet.

Test: inspector/profiler/selector-profiler-url.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::applyProperties):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willMatchRuleImpl):
(WebCore::InspectorInstrumentation::willProcessRuleImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willMatchRule):
(WebCore::InspectorInstrumentation::willProcessRule):

LayoutTests:

  • inspector/profiler/selector-profiler-url-expected.txt: Added.
  • inspector/profiler/selector-profiler-url.html: Added.
5:03 AM Changeset in webkit [136947] by tonikitoo@webkit.org
  • 5 edits in trunk/Source/WebCore

Rework bug 97927 to not depend on RenderLayer::allowsScrolling
https://bugs.webkit.org/show_bug.cgi?id=103999

Reviewed by James Robinson.
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>

Patch makes it possible for methods like
RenderLayer::{updateScrollbarsAfterLayout,updateScrollbarsAfterStyleChange}
to not depend on RenderLayer::allowsScrolling to determine if a layer should
be added or removed from its FrameView's ScrollableArea set.

Following the same logic, the patch also fixes RenderBox::canBeScrolledAndHasScrollableArea
method to take into account the box' scroll allowance in a given direction only
when it overflows. This allows simplifying custom methods like InRegionScrollerPrivate::canScrollRenderBox
(@WebKit/blackberry/Api/InRegionScroller.cpp).

The naming pattern for the newly added methods were chosen to keep the consistency
with the existing ones, in the same class.

No new test: it is already covered by ScrollingCoordinatorChromiumTest.clippedBodyTest.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::canBeScrolledAndHasScrollableArea):

  • rendering/RenderBox.h:

(RenderBox):
(WebCore::RenderBox::hasScrollableOverflowX):
(WebCore::RenderBox::hasScrollableOverflowY):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hasScrollableHorizontalOverflow):
(WebCore):
(WebCore::RenderLayer::hasScrollableVerticalOverflow):
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
(WebCore::RenderLayer::updateScrollbarsAfterStyleChange):

  • rendering/RenderLayer.h:

(RenderLayer):

4:57 AM Changeset in webkit [136946] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] make "isVideo" information available to platform media player
https://bugs.webkit.org/show_bug.cgi?id=104334

Patch by Max Feil <mfeil@rim.com> on 2012-12-07
Reviewed by Rob Buis.

The platform player needs to know whether the element is <video>
or <audio>, so it can make certain decisions before metadata
is ready. This is part of a performance optimization refactor
which does not change functionality so no new tests are required.

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::load):

4:47 AM Changeset in webkit [136945] by loislo@chromium.org
  • 2 edits
    2 moves
    4 deletes in trunk/LayoutTests

Web Inspector: enable inspector tests on chromium-mac.
https://bugs.webkit.org/show_bug.cgi?id=104357

Reviewed by Pavel Feldman.

After chromium r171707 patch we can enable inspector tests on chromium-mac.
Two expectation files were moved from chromium-win to chromium because chromium-mac doesn't inherit expectations from chromium-win.

Expectations in chromium-mac were removed because they were added by mistake.
[ Win Linux ] filter was removed because I need to add Mac but [ Mac Win Linux ] is equivalent to nothing.

  • platform/chromium-mac/inspector/console/command-line-api-getEventListeners-expected.txt: Removed.
  • platform/chromium-mac/inspector/cookie-parser-expected.txt: Removed.
  • platform/chromium-mac/inspector/debugger/debugger-activation-crash2-expected.txt: Removed.
  • platform/chromium-mac/inspector/debugger/event-listener-breakpoints-expected.txt: Removed.
  • platform/chromium/TestExpectations:
  • platform/chromium/inspector/console/command-line-api-getEventListeners-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/console/command-line-api-getEventListeners-expected.txt.
  • platform/chromium/inspector/debugger/debugger-scripts-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/debugger/debugger-scripts-expected.txt.
4:38 AM Changeset in webkit [136944] by sudarsana.nagineni@linux.intel.com
  • 1 edit
    2 adds
    4 deletes in trunk/LayoutTests

Unreviewed EFL gardening.

Remove platform-specific baselines for viewsource-attribute.html
and viewsource-on-image-file.html as the current results matches
base expectations. Also, add missing platform-specific baselines
for fast/text/decorations-with-text-combine.html.

  • platform/efl-wk2/fast/frames/viewsource-attribute-expected.png: Removed.
  • platform/efl-wk2/fast/frames/viewsource-attribute-expected.txt: Removed.
  • platform/efl-wk2/fast/frames/viewsource-on-image-file-expected.png: Removed.
  • platform/efl-wk2/fast/frames/viewsource-on-image-file-expected.txt: Removed.
  • platform/efl/fast/text/decorations-with-text-combine-expected.png: Added.
  • platform/efl/fast/text/decorations-with-text-combine-expected.txt: Added.
4:01 AM Changeset in webkit [136943] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt][Qnx] Fix QNX build by adding missing include.
https://bugs.webkit.org/show_bug.cgi?id=104359

Patch by Sergio Martins <sergio.martins@kdab.com> on 2012-12-07
Reviewed by Jocelyn Turcotte.

It's where WEBKIT_EXPORTDATA is defined, so include it. Not sure why other
platforms aren't failing.

  • WebCoreSupport/QWebPageAdapter.h:
2:50 AM Changeset in webkit [136942] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] [AC] Implement ImageExtractor::extractImage in GraphicsContext3DEfl.
https://bugs.webkit.org/show_bug.cgi?id=104271.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-07
Reviewed by Kenneth Rohde Christiansen.

This patch implements ImageExtractor::extractImage in GraphicsContext3DEfl.

Covered by existing tests.

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::~ImageExtractor):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

2:47 AM Changeset in webkit [136941] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add ewk_settings APIs for text autosizing
https://bugs.webkit.org/show_bug.cgi?id=103342

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-12-07
Reviewed by Kenneth Rohde Christiansen.

Add ewk_settings_text_autosizing_enabled_get / set() functions.
Text autosizing is disabled by default.

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_text_autosizing_enabled_set):
(ewk_settings_text_autosizing_enabled_get):

  • UIProcess/API/efl/ewk_settings.h:
  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

2:22 AM Changeset in webkit [136940] by commit-queue@webkit.org
  • 7 edits in trunk

[BlackBerry] DRT - Update implementation of TestRunner.setCustomPolicyDelegate()
https://bugs.webkit.org/show_bug.cgi?id=104243

RIM PR 259337

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-12-07
Reviewed by Rob Buis.

Source/WebKit/blackberry:

  1. Add DRT callback in dispatchDecidePolicyForResponse.
  2. Pass frame pointer to DRT callback in

dispatchDecidePolicyForNavigationAction, so that it can be used to
calculate originating.

  1. Fix some webkit style errors.

The patch fixed the following tests:

  • http/tests/download
  • fast/forms/mailto/formenctype-attribute-button-html.html
  • fast/forms/mailto/formenctype-attribute-input-html.html
  • fast/encoding/mailto-always-utf-8.html
  • Api/DumpRenderTreeClient.h:
  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForResponse):
(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
(WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):

Tools:

  1. Implement calculation of navigation originating in

didDecidePolicyForNavigationAction().

  1. Implement policy delegate for resource response.
  2. Enable customPolicyDelegate if waitForPolicyDelegate() is called.
  3. Minor optional updates in dump() and dumpFrameLoadCallbacks().

The patch fixed the following tests:

  • http/tests/download
  • fast/forms/mailto/formenctype-attribute-button-html.html
  • fast/forms/mailto/formenctype-attribute-input-html.html
  • fast/encoding/mailto-always-utf-8.html
  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
(BlackBerry::WebKit::DumpRenderTree::dump):
(BlackBerry::WebKit::DumpRenderTree::didFinishLoadForFrame):
(BlackBerry::WebKit::DumpRenderTree::didDecidePolicyForNavigationAction):
(BlackBerry::WebKit::DumpRenderTree::didDecidePolicyForResponse):
(BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate):

  • DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:

(DumpRenderTree):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:

(TestRunner::setCustomPolicyDelegate):
(TestRunner::waitForPolicyDelegate):
(TestRunner::overridePreference):

1:58 AM Changeset in webkit [136939] by loislo@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed roll crhomium to r171707.

  • DEPS:
1:56 AM Changeset in webkit [136938] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

Use always the order iterator from data member in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=104112

Reviewed by Tony Chang.

Some methods receive it as parameter and others use the data
member.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeNextFlexLine):
(WebCore::RenderFlexibleBox::alignFlexLines):
(WebCore::RenderFlexibleBox::alignChildren):
(WebCore::RenderFlexibleBox::flipForRightToLeftColumn):
(WebCore::RenderFlexibleBox::flipForWrapReverse):

  • rendering/RenderFlexibleBox.h:
1:53 AM Changeset in webkit [136937] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Improve confusing code in BaseMultipleFieldsDateAndTimeInputType
https://bugs.webkit.org/show_bug.cgi?id=104353

Reviewed by Kentaro Hara.

This doesn't change any behavior because call sites of
isEditControlOwnerDisabled and isEditControlOwnerReadOnly treat them
similarly.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerDisabled):
Checks element()->disabled, not readOnly.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerReadOnly):
Checks element()->readOnly, not disabled.

1:16 AM Changeset in webkit [136936] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Gardening after r136857, r136893 and 136919.
https://bugs.webkit.org/show_bug.cgi?id=104351

Patch by János Badics <János Badics> on 2012-12-07
Reviewed by Csaba Osztrogonác.

r136857: skipped a newly added failing reftest.
r136893: skipped two newly added xmlhttprequest tests
r136919: skipped a test because layoutTestController.setBackingScaleFactor() is unimplemented

  • platform/qt/TestExpectations:
1:09 AM Changeset in webkit [136935] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

REGRESSION(r136631): Fix null pointer dereference in WebPagePopupImpl::paint
https://bugs.webkit.org/show_bug.cgi?id=104350

Reviewed by Hajime Morita.

We changed WebPagePopupImpl so that it deleted m_page in
closePopup. However, paint function is still called.

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::paint): Block by m_closing.

12:49 AM Changeset in webkit [136934] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Adjust library name in layout_tests/port/qt.py after Qt5-r40
https://bugs.webkit.org/show_bug.cgi?id=104348

Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2012-12-07
Reviewed by Csaba Osztrogonác.

After Qt-5.0.0-r40, the library was renamed from QtWebKitWidgets to
Qt5WebKitWidgets. run-webkit-tests were still looking for QtWebKitWidgets

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._path_to_webcore_library):

12:46 AM Changeset in webkit [136933] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • plugins/PlugInOriginHash.cpp:

(WebCore::PlugInOriginHash::hash):

12:43 AM Changeset in webkit [136932] by jonlee@apple.com
  • 7 edits
    2 adds in trunk/Source/WebCore

Add PlugInOriginHash
https://bugs.webkit.org/show_bug.cgi?id=103655
<rdar://problem/12778949>

Reviewed by Alexey Proskuryakov.

Add the concept of plug-in origin hashes, which are based on a combination of the base domains of the
page's main frame and the plug-in, and the plug-in MIME type.

  • plugins/PlugInOriginHash.cpp: Added.

(WebCore::addCaseFoldedCharacters): Add the case-folded string to the hash.
(WebCore::PlugInOriginHash::hash): The hash is based on the concatenation of the page's host, the plug-in
URL's host, and the MIME type. We use StringHasher to get all 32-bits of the hash, since using StringImpl's hash
masks out 8 of the hash bits to make room for bit flags.

  • plugins/PlugInOriginHash.h: Added.
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
12:25 AM Changeset in webkit [136931] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed fix, unbreak run-launcher after library renaming.

  • Scripts/webkitdirs.pm:

(builtDylibPathForName):

12:25 AM Changeset in webkit [136930] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] new target window would cause the url being loaded twice
https://bugs.webkit.org/show_bug.cgi?id=104086

Reviewed by Yong Li.

When webkit need to open window for a new target like "_blank", it would
load the url subsequently after createWindow. But the chrome browser would
load the url again when it get the OpenWindowEvent from native, which
causes the url being loaded twice. We should make sure that createWindow() be
used to create a new window only, not loading url, so we pass empty url
as parameter.

RIM PR# 257329
Internally reviewed by Charles Wei.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):

12:04 AM Changeset in webkit [136929] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed fix after r136896, unbreak --debug-rwt to make bots result verbose again.
https://bugs.webkit.org/show_bug.cgi?id=104296

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(main):

Dec 6, 2012:

11:46 PM Changeset in webkit [136928] by tkent@chromium.org
  • 6 edits in trunk/Source

Refactoring: Clean up placeholder attribute usage
https://bugs.webkit.org/show_bug.cgi?id=104337

Reviewed by Kentaro Hara.

Source/WebCore:

No new tests. This doesn't change any behavior.

  • html/HTMLInputElement.cpp: Remove placeholder and setPlacehodler.
  • html/HTMLInputElement.h: Ditto.
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::strippedPlaceholder):
We can use fastGetAttribute for placeholder.
(WebCore::HTMLTextFormControlElement::isPlaceholderEmpty):
Ditto.

Source/WebKit/chromium:

  • src/WebInputElement.cpp:

(WebKit::WebInputElement::setPlaceholder):
Use setAttribute.
(WebKit::WebInputElement::placeholder):
Use fastGetAttribute.

11:44 PM Changeset in webkit [136927] by fpizlo@apple.com
  • 9 edits
    3 adds in trunk

Incorrect inequality for checking whether a statement is within bounds of a handler
https://bugs.webkit.org/show_bug.cgi?id=104313
<rdar://problem/12808934>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

The most relevant change is in handlerForBytecodeOffset(), which fixes the inequality
used for checking whether a handler is pertinent to the current instruction. '<' is
correct, but '<=' isn't, since the 'end' is not inclusive.

Also found, and addressed, a benign goof in how the finally inliner works: sometimes
we will have end > start. This falls out naturally from how the inliner works and how
we pop scopes in the bytecompiler, but it's sufficiently surprising that, to avoid any
future confusion, I added a comment and some code to prune those handlers out. Because
of how the handler resolution works, these handlers would have been skipped anyway.

Also made various fixes to debugging code, which was necessary for tracking this down.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::handlerForBytecodeOffset):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):

  • bytecompiler/Label.h:

(JSC::Label::bind):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::throwException):

  • llint/LLIntExceptions.cpp:

(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::handleHostCall):

LayoutTests:

  • fast/js/jsc-test-list:
  • fast/js/script-tests/try-catch-try-try-catch-try-finally-return-catch-finally.js: Added.

(foo):

  • fast/js/try-catch-try-try-catch-try-finally-return-catch-finally-expected.txt: Added.
  • fast/js/try-catch-try-try-catch-try-finally-return-catch-finally.html: Added.
11:24 PM Changeset in webkit [136926] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[chromium] Introduce setting for low latency rendering
https://bugs.webkit.org/show_bug.cgi?id=104011

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-12-06
Reviewed by James Robinson.

This low latency rendering setting will be used to enable alternate
render signaling and scheduling to reduce latency.

Source/Platform:

  • chromium/public/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setLowLatencyRenderingEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):
(WebKit::WebSettingsImpl::lowLatencyRenderingEnabled):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

11:21 PM Changeset in webkit [136925] by tkent@chromium.org
  • 12 edits in trunk/Source/WebCore

Refactoring: Rename HTMLFormControlElement::required to isRequired
https://bugs.webkit.org/show_bug.cgi?id=104336

Reviewed by Kentaro Hara.

m_required should be m_isRequired, and required() should be
isRequired. It's safe to rename them because HTML*Element::required IDL
attributes are [Reflected].
http://www.webkit.org/coding/coding-style.html#names-bool

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isRequired):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithControl):

  • dom/CheckedRadioButtons.cpp:

(WebCore::RadioButtonGroup::add):
(WebCore::RadioButtonGroup::requiredAttributeChanged):
(WebCore::RadioButtonGroup::remove):

  • html/CheckboxInputType.cpp:

(WebCore::CheckboxInputType::valueMissing):

  • html/FileInputType.cpp:

(WebCore::FileInputType::valueMissing):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::parseAttribute):
(WebCore::HTMLFormControlElement::isRequired):

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isRequiredFormControl):
(WebCore::HTMLInputElement::setupDateTimeChooserParameters):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::valueMissing):
(WebCore::HTMLSelectElement::isRequiredFormControl):

  • html/HTMLTextAreaElement.h:

(WebCore::HTMLTextAreaElement::isRequiredFormControl):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::valueMissing):

11:20 PM Changeset in webkit [136924] by morrita@google.com
  • 21 edits
    2 adds in trunk

[Shadow DOM] Implement Element::shadowRoot with prefix
https://bugs.webkit.org/show_bug.cgi?id=102912

Reviewed by Dimitri Glazkov.

  • Added Element::shadowRoot() which return the youngest author shadow root.
  • Renamed existing Node::shadowRoot() to containingShadowRoot() to avoid name shadowing. The name shadowRoot() is confusing anyway so this is good opportunity to rename it.

Test: fast/dom/shadow/shadow-aware-shadow-root.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector):

  • css/StyleScopeResolver.cpp:

(WebCore::StyleScopeResolver::scopeFor):
(WebCore::StyleScopeResolver::addHostRule):

  • dom/Element.cpp:

(WebCore::Element::shadowRoot):
(WebCore):

  • dom/Element.h:

(Element):

  • dom/Element.idl:
  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::setShouldCollectSelectFeatureSet):

  • dom/Node.cpp:

(WebCore::Node::rendererIsEditable):
(WebCore::Node::shadowHost):
(WebCore::Node::shadowAncestorNode):
(WebCore::Node::containingShadowRoot):

  • dom/Node.h:

(Node):

  • dom/Range.cpp:

(WebCore::Range::shadowRoot):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::insertedInto):
(WebCore::ShadowRoot::removedFrom):

  • dom/ShadowRoot.h:

(WebCore::ShadowRoot::isAccessible):

  • editing/TextIterator.cpp:

(WebCore::TextIterator::handleReplacedElement):

  • editing/htmlediting.cpp:

(WebCore::indexForVisiblePosition):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::scopedAttributeChanged):
(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::removedFrom):

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distribute):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::parseAttribute):
(WebCore::HTMLContentElement::insertedInto):
(WebCore::HTMLContentElement::removedFrom):

  • html/shadow/HTMLShadowElement.cpp:

(WebCore::HTMLShadowElement::insertedInto):
(WebCore::HTMLShadowElement::removedFrom):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::attach):
(WebCore::InsertionPoint::detach):
(WebCore::InsertionPoint::isActive):
(WebCore::InsertionPoint::childrenChanged):
(WebCore::InsertionPoint::insertedInto):
(WebCore::InsertionPoint::removedFrom):
(WebCore::InsertionPoint::setResetStyleInheritance):

  • page/EventHandler.cpp:

(WebCore::instanceAssociatedWithShadowTreeElement):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::correspondingElement):
(WebCore::collectInstancesForSVGElement):

11:02 PM Changeset in webkit [136923] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Replace int64 with int64_t
https://bugs.webkit.org/show_bug.cgi?id=104338

Patch by Michael Pruett <michael@68k.org> on 2012-12-06
Reviewed by Kentaro Hara.

Cleaning up coding inconsistencies, no change in behavior.

Tests: storage/indexeddb/*

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::openInternal):

10:22 PM Changeset in webkit [136922] by noel.gordon@gmail.com
  • 1 edit
    7 adds in trunk/LayoutTests

Unreviewed Gardening. More http://trac.webkit.org/changeset/136910. Add Chromium Linux results.

  • platform/chromium-linux/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_clearMarks-expected.txt: Added.
  • platform/chromium-linux/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_mark-expected.txt: Added.
9:40 PM Changeset in webkit [136921] by tkent@chromium.org
  • 9 edits in trunk/Source/WebKit/chromium

[Chromium] Rename some init* functions to initialize*
https://bugs.webkit.org/show_bug.cgi?id=104335

Reviewed by Kentaro Hara.

We should use full words.
http://www.webkit.org/coding/coding-style.html#names-full-words

  • src/WebHelperPluginImpl.cpp:

(WebKit::WebHelperPluginImpl::initialize): Renamed from init.
(WebKit::WebHelperPluginImpl::initializePage): Renamed from initPage.

  • src/WebHelperPluginImpl.h:

(WebHelperPluginImpl):

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::initialize): Renamed from init.
(WebKit::WebPagePopupImpl::initializePage): Renamed from initPage.

  • src/WebPagePopupImpl.h:

(WebPagePopupImpl):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::initialize): Renamed from init.

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::openPagePopup): Follow the renamings.
(WebKit::WebViewImpl::createHelperPlugin): Ditto.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::popupOpened): Ditto.

9:08 PM Changeset in webkit [136920] by simonjam@chromium.org
  • 4 edits in trunk

[Resource Timing] Allow detailed timing on same origin sites
https://bugs.webkit.org/show_bug.cgi?id=104328

Reviewed by Tony Gentilcore.

Source/WebCore:

This block was lost when I moved it to PerformanceResourceTiming.cpp.

Test: http/tests/w3c/webperf/submission/resource-timing/html/test_resource_attribute_order.html

  • page/PerformanceResourceTiming.cpp:

(WebCore::passesTimingAllowCheck):

LayoutTests:

  • platform/chromium/TestExpectations: This was mismarked as an iframe failure.
7:07 PM Changeset in webkit [136919] by commit-queue@webkit.org
  • 45 edits
    7 adds in trunk

CSS cursor property should support webkit-image-set
https://bugs.webkit.org/show_bug.cgi?id=99493

Patch by Rick Byers <rbyers@chromium.org> on 2012-12-06
Reviewed by Beth Dakin.

.:

Add ENABLE_MOUSE_CURSOR_SCALE (disabled by default)

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Add ENABLE_MOUSE_CURSOR_SCALE (disabled by default)

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Add support for image scale factors attached to custom mouse cursor images
behind ENABLE(MOUSE_CURSOR_SCALE).

This required refactoring CSSCursorImageValue to derive directly from
CSSValue since it can contain either a CSSImageValue or a CSSImageSetValue.
If it contains an image-set, then we can plumb directly through to the
CSSImageSetValue. If it contains an image, then either we can plumb directly
through to the CSSImageValue, or if the URL represents an SVG cursor we have
to intercept the image loading in order to substitute the actual SVG image URL
and do the appropriate lifetime management.

Tests: fast/css/cursor-parsing-image-set.html

fast/events/mouse-cursor-image-set.html

  • Configurations/FeatureDefines.xcconfig: Add ENABLE_MOUSE_CURSOR_SCALE - disabled
  • GNUmakefile.features.am: ditto
  • css/CSSCursorImageValue.cpp: Refactor to inherit directly from CSSValue and support image sets

(WebCore::CSSCursorImageValue::CSSCursorImageValue):
(WebCore::CSSCursorImageValue::~CSSCursorImageValue):
(WebCore::CSSCursorImageValue::customCssText):
(WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
(WebCore::CSSCursorImageValue::cachedImage):
(WebCore::CSSCursorImageValue::cachedOrPendingImage):
(WebCore::CSSCursorImageValue::isSVGCursor):
(WebCore::CSSCursorImageValue::cachedImageURL):
(WebCore::CSSCursorImageValue::clearCachedImage):
(WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):

  • css/CSSCursorImageValue.h: Remove cursor-specific hacks

(WebCore::CSSCursorImageValue::create):
(CSSCursorImageValue):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::cachedImage):

  • css/CSSImageValue.h:

(CSSImageValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Parse cursor(-webkit-image-set(...)) rules

  • css/CSSValue.h:

(WebCore::CSSValue::isImageValue):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyCursor::applyValue):

  • css/StyleResolver.cpp: Hook up new CSSCursorImageValue support since it can't be handled like other images any more.

(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::StyleResolver::loadPendingImage):

  • css/StyleResolver.h:

(StyleResolver):

  • page/EventHandler.cpp:

(WebCore::EventHandler::selectCursor): Handle StyleCachedImageSet images and plumb scale factor through

  • platform/Cursor.cpp:

(WebCore::Cursor::Cursor): Add imageScaleFactor

  • platform/Cursor.h: Add imageScaleFactor

(Cursor):
(WebCore::Cursor::imageScaleFactor):

  • platform/chromium/CursorChromium.cpp: Add imageScaleFactor

(WebCore::Cursor::Cursor):
(WebCore::Cursor::operator=):

  • rendering/style/CursorData.h: Clarify hotspot units

(CursorData):

  • rendering/style/StyleCachedImage.h:

(StyleCachedImage::cachedImage): Override new virtual.

  • rendering/style/StyleCachedImageSet.h:

(StyleCachedImageSet::cachedImage): Override new virtual.

  • rendering/style/StyleImage.h:

(StyleImage::cachedImage): Add new virtual method to avoid lots of casts and typechecks.

  • rendering/style/StylePendingImage.h: Add CSSCursorImageValue support

(WebCore::StylePendingImage::cssCursorImageValue):

  • testing/Internals.cpp:

(WebCore::Internals::getCurrentCursorInfo): Print non-identity scale factors for testing

Source/WebKit/chromium:

Add ENABLE_MOUSE_CURSOR_SCALE and enable it on the chromium port.
Plumb cursor image scale factor through to chromium API.

  • features.gypi:
  • public/WebCursorInfo.h:
  • src/WebCursorInfo.cpp:

(WebKit::WebCursorInfo::WebCursorInfo):

Source/WebKit/mac:

Add ENABLE_MOUSE_CURSOR_SCALE - disabled by default.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Add ENABLE_MOUSE_CURSOR_SCALE - disabled by default.

  • Configurations/FeatureDefines.xcconfig:

Tools:

Add ENABLE_MOUSE_CURSOR_SCALE - disabled by default

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

Add ENABLE_MOUSE_CURSOR_SCALE - disabled by default

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

Add tests for parser round-tripping of cursor rules with -webkit-image-set,
and also end-to-end mouse cursor tests that validate the cursor details
ultimately used at different device scales.

Tests are disabled on ports other than chromium (require ENABLE(MOUSE_CURSOR_SCALE))

  • fast/css/cursor-parsing-image-set-expected.txt: Added.
  • fast/css/cursor-parsing-image-set.html: Added.
  • fast/events/mouse-cursor-image-set-expected.txt: Added.
  • fast/events/mouse-cursor-image-set.html: Added.
  • fast/events/resources/greenbox200.png: Added.
  • fast/events/resources/greenbox30-hotspot28-3.cur: Added.
  • fast/events/resources/greenbox30.png: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
7:03 PM Changeset in webkit [136918] by hayato@chromium.org
  • 8 edits
    2 adds in trunk

Event's relatedTarget re-targeting does not occur for manually fired mouse events created by event.initMouseEvent().
https://bugs.webkit.org/show_bug.cgi?id=102681

Reviewed by Dimitri Glazkov.

Source/WebCore:

Make sure that event's relatedTarget re-targeting occurs for mouse
events created by event.initMouseEvent(). Since user-generated
mouse events can have a relatedTarget which is same to the target
node, the algorithm which calculates event's ancestors is also
updated so that ancestors are not shrunk wrongly.

Test: fast/events/dispatch-synthetic-mouseevent.html

fast/dom/shadow/shadow-dom-event-dispatching.html

  • dom/EventDispatcher.cpp:

(WebCore::EventRelatedTargetAdjuster::adjust):

  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::create):
(WebCore::MouseEventDispatchMediator::MouseEventDispatchMediator):
(WebCore::MouseEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.h:

(WebCore::MouseEventDispatchMediator::isSyntheticMouseEvent):
(MouseEventDispatchMediator):

  • dom/Node.cpp:

(WebCore::Node::dispatchEvent):

LayoutTests:

  • fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
  • fast/dom/shadow/shadow-dom-event-dispatching.html:
  • fast/events/dispatch-synthetic-mouseevent-expected.txt: Added.
  • fast/events/dispatch-synthetic-mouseevent.html: Added.
6:57 PM Changeset in webkit [136917] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

[chromium] Rename non-standard discard/ensureFramebufferCHROMIUM extensions so we can use real GL_EXT_discard_framebuffer
https://bugs.webkit.org/show_bug.cgi?id=104316

Patch by James Robinson <jamesr@chromium.org> on 2012-12-06
Reviewed by Kenneth Russell.

GL_EXT_discard_framebuffer is a GL extension that enables optimizations for GPUs that aggressively defer
operations. We've 'borrowed' the extension namespace to enable backbuffer management, but this makes it
impossible to use the actual extension. This adds new entry points for backbuffer management. After callers
(which aren't in the WebKit repo) are updated, we can remove the overlapping entry points.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::discardFramebufferCHROMIUM):
(WebKit::WebGraphicsContext3D::discardBackbufferCHROMIUM):
(WebKit::WebGraphicsContext3D::ensureBackbufferCHROMIUM):

6:30 PM Changeset in webkit [136916] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

Review page is super flakey now
https://bugs.webkit.org/show_bug.cgi?id=104331

Committing without review since this is breaking the code review tool.

remove is only shipping in Chromium. Use jQuery's remove instead.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
6:18 PM Changeset in webkit [136915] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Disabled file input box stops a certain other div from being rendered
https://bugs.webkit.org/show_bug.cgi?id=104226

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-12-06
Reviewed by Dimitri Glazkov.

Source/WebCore:

The bug was caused by setNeedsStyleRecalc() call during style recalculation,
which resulted in inconsistent ChildNeedsStyleRecalc flags in DOM tree.

When reattach of file input happens during style recalculation,
RenderFileUploadControl::updateFromElement() is called from attach().
It may change the disabled state of the upload button in its shadow tree,
but it triggers style recalculation.

This patch solves this issue by setting disabled state of the upload button in
FileInputType::disabledAttributeChanged instead of RenderFileUploadControl.

Test: fast/forms/file/sibling-of-disabled-file-input.html

  • html/FileInputType.cpp:

(WebCore::FileInputType::disabledAttributeChanged): Added.

  • html/FileInputType.h:

(FileInputType): Declare disabledAttributeChanged.

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::updateFromElement): Remove call to button->setDisabled().

LayoutTests:

Add a test to ensure that sibling of disabled file input is correctly rendered.

  • fast/forms/file/sibling-of-disabled-file-input-expected.txt: Added.
  • fast/forms/file/sibling-of-disabled-file-input.html: Added.
6:17 PM Changeset in webkit [136914] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

[CMake] Consolidate list of files to build for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=104287

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-12-06
Reviewed by Gyuyoung Kim.

Add MemoryStatistics.cpp and ExecutableAllocator.cpp to the common
list of files and remove them from the port specific lists.

  • CMakeLists.txt:
  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • PlatformWinCE.cmake:
5:48 PM Changeset in webkit [136913] by dominicc@chromium.org
  • 8 edits in trunk

Element.pseudo property should be prefixed
https://bugs.webkit.org/show_bug.cgi?id=104060

Reviewed by Hajime Morita.

Source/WebCore:

Other Shadow DOM properties are prefixed; pseudo should be too.

Covered by updated tests in fast/dom/shadow.

  • dom/Element.idl:

LayoutTests:

Updated tests.

  • fast/dom/shadow/pseudo-attribute-dynamic.html:
  • fast/dom/shadow/pseudo-attribute-expected.txt:
  • fast/dom/shadow/pseudo-attribute-rendering.html:
  • fast/dom/shadow/pseudo-attribute.html:
  • fast/dom/shadow/shadow-pseudo-id.html:
5:45 PM Changeset in webkit [136912] by commit-queue@webkit.org
  • 18 edits
    2 moves in trunk/Source/WebKit2

Coordinated Graphics: Rename WebLayerTreeInfo to CoordinatedLayerInfo
https://bugs.webkit.org/show_bug.cgi?id=103983

Patch by Jae Hyun Park <jae.park@company100.net> on 2012-12-06
Reviewed by Noam Rosenthal.

This patch refactors WebLayerTreeInfo in 2 areas.

  1. WebLayerTreeInfo is only used by Coordinated Graphics. So, the file

should be located in WebKit2/Shared/CoordinatedGraphics instead of
WebKit2/Shared.

  1. The name of WebLayerTreeInfo is incorrect. Currently,

WebLayerTreeInfo only has WebLayerInfo struct. Also, it is hard to know
what WebLayer is since we don't use that name anymore. More appropriate
name for WebLayerInfo would be CoordinatedLayerInfo.

No new test, because no behavioral change.

  • CMakeLists.txt:
  • Scripts/webkit2/messages.py:

(headers_for_type):

  • Shared/CoordinatedGraphics/CoordinatedLayerInfo.cpp: Renamed from Source/WebKit2/Shared/WebLayerTreeInfo.cpp.

(WebKit):
(WebKit::CoordinatedLayerInfo::encode):
(WebKit::CoordinatedLayerInfo::decode):

  • Shared/CoordinatedGraphics/CoordinatedLayerInfo.h: Renamed from Source/WebKit2/Shared/WebLayerTreeInfo.h.

(WebKit):
(WebKit::CoordinatedLayerInfo::CoordinatedLayerInfo):
(CoordinatedLayerInfo):

  • Shared/LayerTreeContext.h:

(LayerTreeContext):

  • Shared/efl/LayerTreeContextEfl.cpp:

(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
(WebKit::LayerTreeContext::isEmpty):
(WebKit::operator==):

  • Shared/qt/LayerTreeContextQt.cpp:

(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
(WebKit::LayerTreeContext::isEmpty):
(WebKit::operator==):

  • Target.pri:
  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::createTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::removeTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::deleteCompositingLayer):
(WebKit::LayerTreeCoordinatorProxy::setRootCompositingLayer):
(WebKit::LayerTreeCoordinatorProxy::setCompositingLayerState):
(WebKit::LayerTreeCoordinatorProxy::setCompositingLayerChildren):
(WebKit::LayerTreeCoordinatorProxy::setCompositingLayerFilters):
(WebKit::LayerTreeCoordinatorProxy::setLayerAnimations):
(WebKit::LayerTreeCoordinatorProxy::createCanvas):
(WebKit::LayerTreeCoordinatorProxy::syncCanvas):
(WebKit::LayerTreeCoordinatorProxy::destroyCanvas):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:

(WebKit):
(LayerTreeCoordinatorProxy):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::LayerTreeRenderer):
(WebKit::LayerTreeRenderer::createLayer):
(WebKit::LayerTreeRenderer::createCanvas):
(WebKit::LayerTreeRenderer::syncCanvas):
(WebKit::LayerTreeRenderer::destroyCanvas):
(WebKit::LayerTreeRenderer::setLayerChildren):
(WebKit::LayerTreeRenderer::setLayerFilters):
(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::deleteLayer):
(WebKit::LayerTreeRenderer::ensureLayer):
(WebKit::LayerTreeRenderer::setRootLayerID):
(WebKit::LayerTreeRenderer::createTile):
(WebKit::LayerTreeRenderer::removeTile):
(WebKit::LayerTreeRenderer::updateTile):
(WebKit::LayerTreeRenderer::ensureRootLayer):
(WebKit::LayerTreeRenderer::purgeGLResources):
(WebKit::LayerTreeRenderer::setLayerAnimations):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(WebKit):
(LayerTreeRenderer):
(WebKit::LayerTreeRenderer::layerByID):

  • UIProcess/DrawingAreaProxy.h:

(WebKit):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::layerByIDMap):
(WebCore::toCoordinatedLayerID):
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::id):
(WebCore::CoordinatedGraphicsLayer::syncChildren):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.h:
  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::syncLayerState):
(WebKit::LayerTreeCoordinator::syncLayerChildren):
(WebKit::LayerTreeCoordinator::createCanvas):
(WebKit::LayerTreeCoordinator::syncCanvas):
(WebKit::LayerTreeCoordinator::destroyCanvas):
(WebKit::LayerTreeCoordinator::syncLayerFilters):
(WebKit::LayerTreeCoordinator::createTile):
(WebKit::LayerTreeCoordinator::updateTile):
(WebKit::LayerTreeCoordinator::removeTile):
(WebKit::LayerTreeCoordinator::setLayerAnimations):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

5:43 PM Changeset in webkit [136911] by li.yin@intel.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, webaudio/audioparam-connect-audioratesignal.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=87273

Remove audioparam-connect-audioratesignal.html from chromium/TestExpectations,
since it no longer appears on the flakiness dashboard.

  • platform/chromium/TestExpectations:
5:31 PM Changeset in webkit [136910] by eae@chromium.org
  • 1 edit
    13 adds in trunk/LayoutTests

Unreviewed chromium rebaseline for r136909.

  • platform/chromium-win-xp/http/tests/w3c: Added.
  • platform/chromium-win-xp/http/tests/w3c/webperf: Added.
  • platform/chromium-win-xp/http/tests/w3c/webperf/submission: Added.
  • platform/chromium-win-xp/http/tests/w3c/webperf/submission/Intel: Added.
  • platform/chromium-win-xp/http/tests/w3c/webperf/submission/Intel/user-timing: Added.
  • platform/chromium-win-xp/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_mark-expected.txt: Added.
  • platform/chromium-win/http/tests/w3c: Added.
  • platform/chromium-win/http/tests/w3c/webperf: Added.
  • platform/chromium-win/http/tests/w3c/webperf/submission: Added.
  • platform/chromium-win/http/tests/w3c/webperf/submission/Intel: Added.
  • platform/chromium-win/http/tests/w3c/webperf/submission/Intel/user-timing: Added.
  • platform/chromium-win/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_clearMarks-expected.txt: Added.
  • platform/chromium-win/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_mark-expected.txt: Added.
4:52 PM Changeset in webkit [136909] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r136900.
http://trac.webkit.org/changeset/136900
https://bugs.webkit.org/show_bug.cgi?id=104318

Unreviewed build for Windows port. (Requested by rfong on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

  • win/WebKit2.def.in:
4:33 PM Changeset in webkit [136908] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[CSS Regions] Remove the sanitize mechanism from LineFragmentationData
https://bugs.webkit.org/show_bug.cgi?id=104234

Patch by Andrei Bucur <abucur@adobe.com> on 2012-12-06
Reviewed by David Hyatt.

Remove previous work that ensured an invalid region is never returned by the containingRegion getter. After r136793 the blocks always
relayout children if the region chain changes. This means the sanitize() method is only necessary when all the regions are removed.
This case is treated separately in layoutInlineChildren.

Tests: no new functionality, no bug fixed.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::containingRegion):
(WebCore):
(WebCore::RootInlineBox::setContainingRegion):

  • rendering/RootInlineBox.h:

(RootInlineBox):
(WebCore::RootInlineBox::LineFragmentationData::LineFragmentationData):
(LineFragmentationData):

4:26 PM Changeset in webkit [136907] by kbr@google.com
  • 6 edits in trunk/Source

Associate URLs with GraphicsContext3D instances created for WebGL
https://bugs.webkit.org/show_bug.cgi?id=103793

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebGraphicsContext3D.h:

(Attributes):

Add top document's URL to context creation attributes.

Source/WebCore:

Pass down the URL of the topmost frame's document creating the
WebGL context to the platform layer through
GraphicsContext3D::Attributes.

Not feasible to write a layout test for this change; has no
user-visible effect. Tested manually with failure injection in
Chromium port.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::create):

Pass top document's URL in context creation attributes.

  • platform/chromium/support/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3D::create):

Pass URL through WebKit API.

  • platform/graphics/GraphicsContext3D.h:

(Attributes):

Add top document's URL to context creation attributes.

4:21 PM Changeset in webkit [136906] by pdr@google.com
  • 14 edits
    4 adds in trunk

Unify SVG's animation and target tracking systems.
https://bugs.webkit.org/show_bug.cgi?id=102655

Reviewed by Dirk Schulze.

Source/WebCore:

This patch unifies our animation target tracking system and regular target tracking system.
This simplifies the code, fixes a bug, and cleans up a historically security-sensitive area.

Background: When <use>, <mpath>, <animate>, etc. reference another element using
xlink:href="#id", we need to track when #id changes to #otherId, when #id is removed, etc.
This bookkeeping of element -> target is done in SVGDocumentExtensions. Additionally, when
a target changes that causes layout (e.g., rect.x is changed), all dependent elements with
renderers are notified (<animate> has no renderer and will not use this).

Previously, xlink:href changes were lazily resolved when targetElement() was called, target
changes were tracked using the animation tracking framework, and pending targets did not
work (e.g., <animate xlink:href="#p"><!--animate is now pending #p --><rect id="p"/>).

After this patch, we no longer lazily resolve targetElement() but instead change it when
our xlink:href attribute changes. Instead of using the animation tracking framework in
SVGDocumentExtensions, we now use the regular target tracking framework. Lastly, by using
the regular target tracking framework we are able to hook into the pending resource handling
which fixes a bug (see the test).

A test has been added to test that the order of animation elements does not matter. A second
test has been added to show we do not regress a pending-while-pending case.

Tests: svg/animations/svg-animation-order.html

svg/custom/svg-pending-twice.html

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::setTargetElement):

setTargetElement and setAttributeName now work similarly. When the corresponding attribute
changes, we update our internal state (target or attributeName) and save it instead of
looking these values up on each iteration.

(WebCore::SVGAnimateElement::setAttributeName):
(WebCore):
(WebCore::SVGAnimateElement::resetAnimatedPropertyType):

  • svg/SVGAnimateElement.h:

(SVGAnimateElement):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::setAttributeType):
(WebCore::SVGAnimationElement::setTargetElement):
(WebCore::SVGAnimationElement::setAttributeName):

  • svg/SVGAnimationElement.h:

(SVGAnimationElement):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):
(WebCore):

  • svg/SVGDocumentExtensions.h:

(SVGDocumentExtensions):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::~SVGElement):
(WebCore::SVGElement::removedFrom):
(WebCore::SVGElement::attributeChanged):

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::invalidateAllInstancesOfElement):

This can be removed after r131631 landed.

  • svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::buildPendingResource):

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::buildPendingResource):

A bug was discovered in review with our resource tracking in a pending-while-pending
case. SVGMpathElement and SVGTextPathElement have been updated to fix this as well.

  • svg/animation/SVGSMILElement.cpp:

The changes in SVGSMILElement should look very similar to SVGFEImageElement,
SVGMPathElement, etc. The idea is to build pending resources when added or
removed from the document, or when the href attribute changes.

(WebCore::SVGSMILElement::~SVGSMILElement):
(WebCore):
(WebCore::SVGSMILElement::clearResourceReferences):
(WebCore::SVGSMILElement::buildPendingResource):
(WebCore::SVGSMILElement::insertedInto):
(WebCore::SVGSMILElement::removedFrom):
(WebCore::SVGSMILElement::svgAttributeChanged):
(WebCore::SVGSMILElement::setAttributeName):
(WebCore::SVGSMILElement::setTargetElement):

  • svg/animation/SVGSMILElement.h:

(WebCore):
(WebCore::SVGSMILElement::targetElement):
(SVGSMILElement):

LayoutTests:

  • svg/animations/svg-animation-order-expected.html: Added.
  • svg/animations/svg-animation-order.html: Added.
  • svg/custom/svg-pending-twice-expected.html: Added.
  • svg/custom/svg-pending-twice.html: Added.
4:10 PM Changeset in webkit [136905] by jonlee@apple.com
  • 5 edits in trunk/Source

Retry snapshots if they are too empty
https://bugs.webkit.org/show_bug.cgi?id=104174
<rdar://problem/12820146>

Reviewed by Simon Fraser.

Source/WebCore:

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::updateSnapshot): Change the state machine check so that even
when the plug-in is displaying a snapshot, the snapshot can still be updated. This allows for the
retries to be drawn.

Source/WebKit2:

  • WebProcess/Plugins/PluginView.h: Add a new variable that keeps track of the number of times we've

retried to come up with a snapshot.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView): Initialize the count to 0.
(WebKit::isAlmostSolidColor): Figure out if the image is almost a solid color by overlaying
a grid of dots, and calculate the differences among them. If the average color difference is greater than
a threshold, we consider it to have meaningful content. For now we expect a minimum size and a specific
bitmap image format, otherwise we return early.
(WebKit::PluginView::pluginSnapshotTimerFired): If we have a snapshot image to look at, and if it is
evaluated to be too empty, then try again.

3:50 PM Changeset in webkit [136904] by simonjam@chromium.org
  • 4 edits
    1 add
    1 delete in trunk

[Chromium] Enable Resource Timing and User Timing
https://bugs.webkit.org/show_bug.cgi?id=103788

Reviewed by Tony Gentilcore.

Source/WebKit/chromium:

  • features.gypi:

LayoutTests:

  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_iframe_navigation.html: Removed. Incomplete, shouldn't have been submitted.
  • platform/chromium/TestExpectations: Remove 'Skip' expectations and add expected failures for iframes.
  • platform/chromium/fast/dom/Window/window-properties-performance-expected.txt: Added. Now includes User Timing and Resource Timing properties.
3:47 PM Changeset in webkit [136903] by adamk@chromium.org
  • 17 edits
    1 copy
    2 adds in trunk

[HTMLTemplateElement] make content readonly and cloneNode(deep) clone content
https://bugs.webkit.org/show_bug.cgi?id=104181

Reviewed by Adam Barth.

Source/WebCore:

Note that this patch also adds IDL attributes/custom code to tie the lifetime
of the content DocumentFragment wrapper to the lifetime of the template element wrapper
via a hidden JS property.

Based on a patch by Rafael Weinstein.

Test: fast/dom/HTMLTemplateElement/contentWrappers.html

  • DerivedSources.cpp:
  • Target.pri:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSHTMLTemplateElementCustom.cpp: Copied from Source/WebCore/html/HTMLTemplateElement.idl.

(WebCore):
(WebCore::JSHTMLTemplateElement::content):

  • bindings/scripts/CodeGeneratorV8.pm: Add support for new V8CacheAttributeForGC attribute.
  • dom/Element.h:

(Element): Annotate cloneNode() with OVERRIDE

  • html/HTMLTemplateElement.cpp:

(WebCore::HTMLTemplateElement::cloneNode):

  • html/HTMLTemplateElement.h:

(HTMLTemplateElement): override cloneNode

  • html/HTMLTemplateElement.idl: Make content readonly and add custom attributes.

LayoutTests:

  • fast/dom/HTMLTemplateElement/cloneNode-expected.txt:
  • fast/dom/HTMLTemplateElement/cloneNode.html:
  • fast/dom/HTMLTemplateElement/contentWrappers-expected.txt: Added.
  • fast/dom/HTMLTemplateElement/contentWrappers.html: Added.
  • fast/dom/HTMLTemplateElement/ownerDocument-expected.txt:
  • fast/dom/HTMLTemplateElement/ownerDocument.html:
3:31 PM Changeset in webkit [136902] by eae@chromium.org
  • 4 edits
    4 adds
    1 delete in trunk/LayoutTests

Unreviewed chromium rebaseline for r136885.

  • platform/chromium-mac-lion/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/efl-wk1/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/efl/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Removed.
3:30 PM Changeset in webkit [136901] by vivek.vg@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Fixing the email order to work correctly with bugzilla.

3:28 PM Changeset in webkit [136900] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, Apple Win Debug build fix.

  • win/WebKit2.def.in: Add 2 symbols that are needed by the debug build.
3:20 PM Changeset in webkit [136899] by jochen@chromium.org
  • 7 edits
    2 adds in trunk

[chromium] when forwarding events through the WebPluginContainer, create a UserGestureIndicator if processing a user gesture
https://bugs.webkit.org/show_bug.cgi?id=104306

Reviewed by Dimitri Glazkov.

Source/WebKit/chromium:

In http://trac.webkit.org/changeset/65964 a UserGestureIndicator was
introduced in chromium's WebKit layer intended to fix a problem with
plugins, however, it also affected regular event handling, so I removed
it in http://trac.webkit.org/changeset/128273. Turns out it still is a
problem for plugins. This change adds the UserGestureIndicator back,
however, only for the WebPluginContainer.

  • public/WebInputEvent.h:

(WebInputEvent):
(WebKit::WebInputEvent::isUserGestureEventType):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::handleEvent):

Tools:

  • DumpRenderTree/chromium/TestWebPlugin.cpp:

(TestWebPlugin::TestWebPlugin):
(TestWebPlugin::handleInputEvent): add support for printing the user gesture status

  • DumpRenderTree/chromium/TestWebPlugin.h:

(TestWebPlugin):

LayoutTests:

  • platform/chromium/plugins/user-gesture-expected.txt: Added.
  • platform/chromium/plugins/user-gesture.html: Added.
3:02 PM Changeset in webkit [136898] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

[Windows, WinCairo] Unreviewed build correction.

Exclude 'DocumentSharedObjectPool.cpp' from build, since it is
built as part of DOMAllInOne.cpp. The build (besides wasting
time) generates a bunch of build warnings for duplicate symbols.

  • WebCore.vcproj/WebCore.vcproj: Mark DocumentSharedObjectPool.cpp

to not build independently of DOMAllInOne.cpp.

2:56 PM Changeset in webkit [136897] by dgrogan@chromium.org
  • 6 edits in trunk/Source

IndexedDB: Abort transactions because of leveldb errors part 4
https://bugs.webkit.org/show_bug.cgi?id=103964

Reviewed by Tony Chang.

Source/WebCore:

deleteDatabase, open, and deleteObjectStore will now fire more aborts
and errors in case of leveldb problems

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::getVarInt): Make return value indicate leveldb error.
(WebCore::getString): ditto.
(WebCore::IDBBackingStore::getIDBDatabaseMetaData):
Change return value to indicate leveldb error.

(WebCore::IDBBackingStore::deleteDatabase):
Already had the desired return value semantics. As a consumer of
getIDBDatabaseMetadata, will return an error (causing an abort) more
often.

(WebCore::IDBBackingStore::deleteObjectStore):
Needed return value change. Will return error to DatabaseBackend to
indicate leveldb problems.

  • Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::openInternal):
Pass leveldb errors up to callers, who already handle internal errors.

(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreOperation::perform):
Abort transaction if there were leveldb problems deleting an object
store.

Source/WebKit/chromium:

  • tests/IDBFakeBackingStore.h: Update one overridden method signature, delete another.
2:45 PM Changeset in webkit [136896] by dpranke@chromium.org
  • 3 edits in trunk/Tools

new-run-webkit-tests --lint-test-files seems to be broken
https://bugs.webkit.org/show_bug.cgi?id=104296

Unreviewed, build fix.

My recent refactoring caused me to not initialize the printer
before calling lint(); this patch restructures the code to make
the lint routine self-contained and do all the work necessary.
This will also make it easier to move this code out into a standalone
file.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(lint):
(main):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(LintTest.test_all_configurations):
(LintTest.test_lint_test_files):
(LintTest.test_lint_test_fileserrors):

2:36 PM Changeset in webkit [136895] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Tell heap that we've released all the compiled code.

Reviewed by Geoff Garen.

When we discard compiled code, inform the heap that we've
released an entire object graph. This informs the heap that
it might want to perform a GC soon.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::discardAllCode):

2:33 PM Changeset in webkit [136894] by dgrogan@chromium.org
  • 9 edits in trunk

IndexedDB: Add webkitErrorMessage to IDBTransaction
https://bugs.webkit.org/show_bug.cgi?id=104199

Reviewed by Tony Chang.

Source/WebCore:

Don't drop error messages on the floor.

Expose an error message on IDBTransaction to give developers more
information than the opaque error code currently available. This is
exactly what is done in IDBRequest.

Tests - transaction-error.html

  • Modules/indexeddb/IDBDatabaseError.h:

(WebCore::IDBDatabaseError::create):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::uncaughtExceptionInEventHandler):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::setError):
(WebCore):
(WebCore::IDBTransaction::webkitErrorMessage):
(WebCore::IDBTransaction::onAbort):

  • Modules/indexeddb/IDBTransaction.h:

(IDBTransaction):

  • Modules/indexeddb/IDBTransaction.idl:

LayoutTests:

Test for webkitErrorMessage in the three circumstances that can
generate one:
1) Bubble from operation error
2) Uncaught exception in operation event handler
3) Asynchronous abort from the backend

And fix a FIXME in the test.

  • storage/indexeddb/resources/transaction-error.js:

(testErrorFromRequest.trans.onabort):
(testErrorFromRequest):
(testErrorFromException.trans.onabort):
(testErrorFromException):
(testErrorFromCommit.trans.oncomplete.request.onupgradeneeded.trans.onabort):
(testErrorFromCommit.trans.oncomplete.request.onupgradeneeded):
(testErrorFromCommit.trans.oncomplete):
(testErrorFromCommit):

  • storage/indexeddb/transaction-error-expected.txt:
2:32 PM Changeset in webkit [136893] by commit-queue@webkit.org
  • 4 edits
    5 adds in trunk

XMLHttpRequest Content-Type should be taken from Blob type
https://bugs.webkit.org/show_bug.cgi?id=99983

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-12-06
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Fix XMLHttpRequest::send(Blob*) method, so that the Content-Type is set according to W3C specification.
http://www.w3.org/TR/XMLHttpRequest/#the-send-method

Added test that check if content type is set correctly when blob object is sent.

Test: http/tests/xmlhttprequest/post-blob-content-type.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

Set correct MIME type for Blob objects.

  • WebCore.vcproj/WebCore.vcproj:

Added ParsedContentType to project file.

LayoutTests:

Added tests that check if content type is set correctly when blob object is sent.

  • http/tests/xmlhttprequest/post-blob-content-type-expected.txt: Added.
  • http/tests/xmlhttprequest/post-blob-content-type.html: Added.
2:30 PM Changeset in webkit [136892] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] IndexedDB: storage/indexeddb/resources/cursor-advance.html flaky in content_shell after WK136782
https://bugs.webkit.org/show_bug.cgi?id=104292

Reviewed by Tony Chang.

Test had a read-only transaction depending on the completion of a prior read-write transaction,
which is not guaranteed by the spec. Switch from triggering the second transaction into the
oncomplete of the first.

  • storage/indexeddb/resources/cursor-advance.js:

(populateObjectStore):

2:21 PM Changeset in webkit [136891] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Make LazyDecodingPixelRef inherit from skia::LazyPixelRef so that cc thread can access it
https://bugs.webkit.org/show_bug.cgi?id=103555

Patch by Min Qin <qinmin@chromium.org> on 2012-12-06
Reviewed by Stephen White.

Expose LazyDecodingPixelRef to the cc thread by inheriting from skia::LazyPixelRef.
No test added for now as impl side paiting is still WIP.

  • platform/graphics/chromium/LazyDecodingPixelRef.cpp:

(WebCore::LazyDecodingPixelRef::LazyDecodingPixelRef):
(WebCore::LazyDecodingPixelRef::PrepareToDecode):
(WebCore):
(WebCore::LazyDecodingPixelRef::Decode):

  • platform/graphics/chromium/LazyDecodingPixelRef.h:

(LazyDecodingPixelRef):

2:21 PM Changeset in webkit [136890] by scherkus@chromium.org
  • 7 edits in trunk/LayoutTests

[Chromium] Unreviewed, rebaselining http/tests/media/video-buffered-range-contains-currentTime.html
https://bugs.webkit.org/show_bug.cgi?id=104300

  • platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac-lion/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium/TestExpectations:
2:18 PM Changeset in webkit [136889] by Lucas Forschler
  • 1 copy in tags/Safari-536.28.6

New Tag.

2:14 PM Changeset in webkit [136888] by ap@apple.com
  • 11 edits in trunk/Source/WebKit2

Track private browsing session in network process
https://bugs.webkit.org/show_bug.cgi?id=104281

Reviewed by Jessie Berlin.

Added ensure/destroy messages that match what's done in WebProcess. Also similarly,
ensuring a private session may happen on demand if network process has been restarted
after a crash, or if private browsing is enabled via a persistent preference.

Eventually, we should find a way to share code between WebFrameNetworkingContext
and RemoteNetworkingContext.

  • NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::initializeNetworkProcess): (WebKit::NetworkProcess::ensurePrivateBrowsingSession): (WebKit::NetworkProcess::destroyPrivateBrowsingSession):
  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/mac/RemoteNetworkingContext.h: (RemoteNetworkingContext):
  • NetworkProcess/mac/RemoteNetworkingContext.mm: (WebKit::privateBrowsingStorageSessionIdentifierBase): (WebKit::RemoteNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase): (WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession): (WebKit::RemoteNetworkingContext::destroyPrivateBrowsingSession):
  • Shared/Network/NetworkProcessCreationParameters.cpp: (WebKit::NetworkProcessCreationParameters::encode): (WebKit::NetworkProcessCreationParameters::decode):
  • Shared/Network/NetworkProcessCreationParameters.h: (NetworkProcessCreationParameters):
  • UIProcess/Network/mac/NetworkProcessProxyMac.mm: (WebKit::NetworkProcessProxy::platformInitializeNetworkProcess):
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm: (WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess):
2:10 PM Changeset in webkit [136887] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Make an Isolate mandatory in v8UnsignedInteger()
https://bugs.webkit.org/show_bug.cgi?id=104235

Reviewed by Adam Barth.

No tests. No change in behavior.

  • bindings/v8/ArrayValue.cpp:

(WebCore::ArrayValue::get):

  • bindings/v8/V8Binding.h:

(WebCore::v8UnsignedInteger):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

2:08 PM Changeset in webkit [136886] by hyatt@apple.com
  • 5 edits in trunk/Source/WebCore

[New Multicolumn] Add requiresBalancing booleans to track which column sets need to rebalance.
https://bugs.webkit.org/show_bug.cgi?id=104297

Reviewed by Simon Fraser.

Add requiresBalancing booleans to RenderMultiColumnBlock and RenderMultiColumnSet. For now the former is just propagated
to the latter, but eventually RenderMultiColumnSets will have a notion of balancing that has to be independent of the
owning block (e.g., maybe only the last set rebalances, or maybe only a set that contains the content between two forced
breaks wants to rebalance, etc.).

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):
(WebCore::RenderMultiColumnBlock::ensureColumnSets):

  • rendering/RenderMultiColumnBlock.h:

(WebCore::RenderMultiColumnBlock::requiresBalancing):
(RenderMultiColumnBlock):

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):

  • rendering/RenderMultiColumnSet.h:

(WebCore::RenderMultiColumnSet::requiresBalancing):
(WebCore::RenderMultiColumnSet::setRequiresBalancing):
(RenderMultiColumnSet):
(WebCore::toRenderMultiColumnSet):
(WebCore):

2:00 PM Changeset in webkit [136885] by wangxianzhu@chromium.org
  • 9 edits in trunk/LayoutTests

internals.settings.setEnableCompositingForFixedPosition() should be called before onload
https://bugs.webkit.org/show_bug.cgi?id=104277

Fixed some tests that set enableCompositingForFixedPosition in onload handler which may not take effect because it is too late.
Leave the image mismatches to bug 96839.

Reviewed by Simon Fraser.

  • compositing/geometry/fixed-position-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-composited-page-scale-scroll.html:
  • compositing/geometry/fixed-position-composited-page-scale.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale.html:
  • compositing/layer-creation/fixed-position-out-of-view.html:
  • platform/chromium/TestExpectations: Mark the original flaky image mismatch as constantly failure. Add one image mismatch caused by this change but because of incorrect baseline.
1:58 PM Changeset in webkit [136884] by commit-queue@webkit.org
  • 10 edits in trunk

[EFL] Remove ENABLE_GLIB_SUPPORT CMake variable
https://bugs.webkit.org/show_bug.cgi?id=104278

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-12-06
Reviewed by Brent Fulgham.

.:

The variable is unnecessary as glib is a required dependency
for the EFL port and glib is not used by other ports building
with CMake.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

The conditional is not required as it is always set for EFL.

  • PlatformEfl.cmake:

Source/WebKit2:

The guards are not required as it is always set for EFL.

  • PlatformEfl.cmake:
  • UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::scanPlugin):

  • WebProcess/efl/WebProcessMainEfl.cpp:

(WebKit::WebProcessMainEfl):

1:41 PM Changeset in webkit [136883] by eae@chromium.org
  • 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r136871.
http://trac.webkit.org/changeset/136871
https://bugs.webkit.org/show_bug.cgi?id=104293

crashes on bots and memory leaks (Requested by esprehn on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

  • dom/Document.h:

(WebCore::Node::treeScope):

  • dom/Element.cpp:

(WebCore::Element::createRareData):

  • dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::ElementRareData):

  • dom/Node.cpp:

(WebCore::Node::setTreeScope):
(WebCore::Node::ensureRareData):
(WebCore::Node::createRareData):
(WebCore::Node::clearRareData):

  • dom/Node.h:

(WebCore::NodeRareDataBase::~NodeRareDataBase):
(WebCore::NodeRareDataBase::NodeRareDataBase):
(NodeRareDataBase):
(WebCore::Node::renderer):
(WebCore::Node::setRenderer):
(Node):
(WebCore::Node::hasRareData):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::NodeRareData):
(NodeRareData):

1:26 PM Changeset in webkit [136882] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove non-v8 binding files from WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=104288

Reviewed by Adam Barth.

Since the gyp build is only used by the Chromium project,
there's no need for cpp, gobject, objc, or jsc bindings
in these build files.

  • WebCore.gypi:
1:22 PM Changeset in webkit [136881] by fpizlo@apple.com
  • 2 edits in trunk/Tools

DFG profiler should be helpful about gem installation
https://bugs.webkit.org/show_bug.cgi?id=104217

Reviewed by Oliver Hunt.

'json' and 'highline' are not installed by default on the ruby distributions with
which I am familiar, and the default error messages don't make me happy. This makes
display-profiler-output print a helpful message if those gems are not found.

  • Scripts/display-profiler-output:
1:21 PM Changeset in webkit [136880] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
1:20 PM Changeset in webkit [136879] by fpizlo@apple.com
  • 2 edits in trunk/Tools

Profiler should print a helpful message if you pass the wrong arguments
https://bugs.webkit.org/show_bug.cgi?id=104222

Reviewed by Oliver Hunt.

  • Scripts/display-profiler-output:
1:19 PM Changeset in webkit [136878] by tony@chromium.org
  • 15 edits
    2 adds in trunk

REGRESSION(r135082): Restore the ability to insert author level style sheets from script
https://bugs.webkit.org/show_bug.cgi?id=104042

Reviewed by Antti Koivisto.

.:

Update exports for Internals.cpp.

  • Source/autotools/symbols.filter:

Source/WebCore:

Add DocumentStyleSheetCollection::addAuthorSheet so embedders can allow scripts
to insert author level styles. Expose the method to window.interals for testing.

Test: userscripts/insert-stylesheets.html

  • WebCore.exp.in: Update exports for Internals.cpp.
  • WebCore.order: Update exports for Internals.cpp.
  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::addAuthorSheet): Add the stylesheet and force a style recalc.
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets): Include author level styles.
(WebCore::DocumentStyleSheetCollection::reportMemoryUsage): Include author styles.

  • dom/DocumentStyleSheetCollection.h:

(WebCore::DocumentStyleSheetCollection::documentAuthorStyleSheets): Accessor.
(DocumentStyleSheetCollection): Keep track of author styles added by script.

  • testing/Internals.cpp:

(WebCore::Internals::insertAuthorCSS): Testing addAuthorSheet.
(WebCore::Internals::insertUserCSS): Testing addUserSheet.

  • testing/Internals.h:
  • testing/Internals.idl: Add addAuthorSheet and addUserSheet.

Source/WebKit/chromium:

  • src/WebDocument.cpp:

(WebKit::WebDocument::insertUserStyleSheet): Use addAuthorSheet if an author level script is requested.

Source/WebKit2:

Update exports for Internals.cpp.

  • win/WebKit2.def.in:

LayoutTests:

Add a test that makes sure that an author level style is set.

  • userscripts/insert-stylesheets-expected.txt: Added.
  • userscripts/insert-stylesheets.html: Added.
1:15 PM Changeset in webkit [136877] by senorblanco@chromium.org
  • 4 edits
    1 delete in trunk/LayoutTests

[Chromium] Unreviewed gardening.

effect-reference-hw.html is failing (lighting has a Y-flip), but people
seem tempted to rebaseline it. Put the software result in its place
for now, and mark it failing, so people aren't tempted to rebaseline it.

  • platform/chromium-linux/css3/filters/effect-reference-hw-expected.png: Removed.
  • platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium/TestExpectations:
1:13 PM Changeset in webkit [136876] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Add some null-checks for the touch-lists in TouchEvent
https://bugs.webkit.org/show_bug.cgi?id=104098

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-12-06
Reviewed by Adam Barth.

It is possible for the touch-lists to be NULL in a TouchEvent. V8TouchEvent checks for NULL
touches(), targetTouches() and changedTouches(). So do the same for WebMouseEventBuilder.

  • src/WebInputEventConversion.cpp:

(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):

  • tests/WebInputEventConversionTest.cpp:
1:09 PM Changeset in webkit [136875] by ojan@chromium.org
  • 5 edits in trunk/Tools

Allow for CCing a secondary email address from watchlists
https://bugs.webkit.org/show_bug.cgi?id=104286

Reviewed by Dirk Pranke.

Change my watchlist CC address so I can filter these separately from
when people explicitly CC me and update the watchlist parser to allow that.

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/watchlist:
  • Scripts/webkitpy/common/watchlist/watchlistparser.py:

(WatchListParser._validate):

  • Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:

(WatchListParserTest.test_cc_rule_with_invalid_email):
(WatchListParserTest.test_cc_rule_with_secondary_email):

12:40 PM Changeset in webkit [136874] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a new test because of missing test font.

  • platform/qt/TestExpectations:
12:31 PM Changeset in webkit [136873] by senorblanco@chromium.org
  • 11 edits
    1 add
    1 delete in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-linux/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-linux/fast/css/background-clip-radius-values-expected.png:
  • platform/chromium-mac-lion/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-mac-lion/fast/css/background-clip-radius-values-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-mac/fast/css/background-clip-radius-values-expected.png:
  • platform/chromium-win/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-win/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-win/fast/css/background-clip-radius-values-expected.png: Added.
  • platform/chromium/TestExpectations:
12:24 PM Changeset in webkit [136872] by andersca@apple.com
  • 6 edits in branches/safari-536.28-branch/Source/WebKit2

<rdar://problem/12828185> "Invalid message" crash reporter data should also include last sent sync message

Reviewed by Dan Bernstein.

Add a way to get the last sent sync message and pass it along to the invalid message callback.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::Connection):
(CoreIPC::Connection::sendSyncMessage):

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::lastSentSyncMessageID):
(Connection):

  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit):
(WebKit::WebProcessProxy::didReceiveInvalidMessage):
(WebKit::WebProcessProxy::setInvalidMessageCallback):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

12:16 PM Changeset in webkit [136871] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Create only NodeRareDataBase when setting TreeScope
https://bugs.webkit.org/show_bug.cgi?id=104202

Patch by Elliott Sprehn <Elliott Sprehn> on 2012-12-06
Reviewed by Dimitri Glazkov.

Move many fields from NodeRareData into NodeRareDataBase and rename it
UncommonNodeData and add a flag to determine if a UncommonNodeData is
actually a full NodeRareData instance. By moving fields up from NodeRareData
we ensure that this new flag in the base class doesn't make NodeRareData
grow in size.

We then make setting the tree scope only allocate the UncommonNodeData
instead of creating the full NodeRareData or ElementRareData. This is
important because when putting nodes into ShadowRoot or any descendant
we must associate the node with a tree scope which adds rare data to the
node making NodeRareData and ElementRareData not very rare.

On 64bit, this reduces the overhead per element from 136 bytes to
32 bytes for a 76% savings, and on other nodes from 64 bytes to 32 bytes
for a 50% savings.

No new tests, no change in behavior.

  • dom/Document.h:

(WebCore::Node::treeScope):

  • dom/Element.cpp:

(WebCore::Element::createRareData):

  • dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::ElementRareData):

  • dom/Node.cpp:

(WebCore::Node::setTreeScope):
(WebCore::Node::ensureRareData):
(WebCore::Node::createRareData):
(WebCore::Node::clearRareData):

  • dom/Node.h:

(WebCore::UncommonNodeData::create):
(UncommonNodeData):
(WebCore::UncommonNodeData::~UncommonNodeData):
(WebCore::UncommonNodeData::isNodeRareData):
(WebCore::UncommonNodeData::UncommonNodeData):
(WebCore::Node::renderer):
(WebCore::Node::setRenderer):
(Node):
(WebCore::Node::hasRareData):
(WebCore::Node::hasUncommonNodeData):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::NodeRareData):
(NodeRareData):

12:13 PM Changeset in webkit [136870] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Add some bug IDs to failing tests, and restore some old expectations.

  • platform/chromium/TestExpectations:
12:11 PM Changeset in webkit [136869] by jsbell@chromium.org
  • 11 edits
    1 delete in trunk/Source/WebCore

IndexedDB: Remove IDBDatabaseException.idl
https://bugs.webkit.org/show_bug.cgi?id=102961

Reviewed by Adam Barth.

Delete the IDL and references to it. No longer needed as a enum member
in the autogenerated ExceptionCodeDescription.h so removed from the ".in"
file; only direct references are retained in the autogenerated cpp file.

Ideally the code generator would handle these new-style DOMExceptions,
but we don't have any other examples yet to know what pattern to follow.

No new tests - just removing dead code.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Modules/indexeddb/IDBDatabaseException.idl: Removed.
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMExceptions.in:
  • dom/make_dom_exceptions.pl:

(generateImplementation):

12:02 PM Changeset in webkit [136868] by eae@chromium.org
  • 1 edit
    2 adds
    3 deletes in trunk/LayoutTests

Unreviewed chromium rebaselines.

  • platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Removed.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/masks: Removed.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png: Removed.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/shadows: Removed.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png: Removed.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/iframes: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/iframes/composited-iframe-alignment-expected.png: Added.
11:54 AM Changeset in webkit [136867] by junov@google.com
  • 4 edits
    2 adds
    1 delete in trunk/LayoutTests

New pixel baselines for fast/backgrounds/gradient-background-leakage.html
https://bugs.webkit.org/show_bug.cgi?id=103896

Unreviewed

  • platform/chromium-linux/fast/backgrounds/gradient-background-leakage-expected.png:
  • platform/chromium-mac/fast/backgrounds/gradient-background-leakage-expected.png:
  • platform/chromium/TestExpectations:
  • platform/efl-wk1/fast/backgrounds: Added.
  • platform/efl-wk1/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/efl/fast/backgrounds/gradient-background-leakage-expected.png: Removed.
11:48 AM Changeset in webkit [136866] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

[Mac] Drain the CSSValuePool on memory pressure.
<http://webkit.org/b/104274>

Reviewed by Antti Koivisto.

Add a drain() mechanism to CSSValuePool and call it when we're under memory pressure.

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::drain):

  • css/CSSValuePool.h:
  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::releaseMemory):

11:47 AM Changeset in webkit [136865] by yael@webkit.org
  • 2 edits
    25 adds in trunk/LayoutTests

Unreviewed gardening.

Add expected results for transforms/3d tests that are producing correct resulta.

  • platform/efl/TestExpectations:
  • platform/efl/transforms/3d: Added.
  • platform/efl/transforms/3d/general: Added.
  • platform/efl/transforms/3d/general/perspective-non-layer-expected.png: Added.
  • platform/efl/transforms/3d/general/perspective-non-layer-expected.txt: Added.
  • platform/efl/transforms/3d/general/perspective-units-expected.png: Added.
  • platform/efl/transforms/3d/general/perspective-units-expected.txt: Added.
  • platform/efl/transforms/3d/hit-testing: Added.
  • platform/efl/transforms/3d/hit-testing/backface-hit-test-expected.png: Added.
  • platform/efl/transforms/3d/hit-testing/backface-hit-test-expected.txt: Added.
  • platform/efl/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.png: Added.
  • platform/efl/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt: Added.
  • platform/efl/transforms/3d/point-mapping: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-2-expected.png: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-3-expected.png: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-3-expected.txt: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-expected.txt: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Added.
11:35 AM Changeset in webkit [136864] by schenney@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

Fix a bad rebaseline

Unreviewed expectations fix.

This test is apparently flaky and I put in the wrong flake.

  • platform/chromium-mac-lion/svg/custom/mask-invalidation-expected.png: Removed.
  • platform/chromium-win/svg/custom/mask-invalidation-expected.png:
11:34 AM Changeset in webkit [136863] by oliver@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Build fix, last patch rolled out logic that is now needed on ToT.

11:33 AM Changeset in webkit [136862] by adamk@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove gyp config for incomplete and unused Apple Mac gyp build
https://bugs.webkit.org/show_bug.cgi?id=104068

Reviewed by Adam Barth.

As part of the removal, move some files to the proper sections
of the gypi file.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
11:27 AM Changeset in webkit [136861] by wangxianzhu@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Expose acceleratedCompositingForScrollableFramesEnabled in WebKit API
https://bugs.webkit.org/show_bug.cgi?id=104272

We may need the API to enable compositing scrollable frames in Chromium.

Reviewed by Darin Fisher.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setAcceleratedCompositingForScrollableFramesEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

11:26 AM Changeset in webkit [136860] by oliver@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Remove harmful string->function cache
https://bugs.webkit.org/show_bug.cgi?id=104193

Reviewed by Alexey Proskuryakov.

Remove the string->function code cache that turned out to actually
be quite harmful.

  • runtime/CodeCache.cpp:

(JSC::CodeCache::getFunctionCodeBlock):

  • runtime/CodeCache.h:

(JSC::CodeCache::clear):

11:21 AM Changeset in webkit [136859] by abecsi@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Fix QWebKitTest's notification of device pixel ratio change
https://bugs.webkit.org/show_bug.cgi?id=104269

Unreviewed, trivialy fixing last minute change.

Move signal emission to the correct place.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::onComponentComplete):

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::PageViewportControllerClientQt):

11:06 AM Changeset in webkit [136858] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

[Chromium] Add GL_CHROMIUM_async_pixel_transfers extension support.
https://bugs.webkit.org/show_bug.cgi?id=103995

Patch by David Reveman <reveman@chromium.org> on 2012-12-06
Reviewed by Kenneth Russell.

Add asyncTexImage2DCHROMIUM and asyncTexSubImage2DCHROMIUM to
WebGraphicsContext3D.h.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::asyncTexImage2DCHROMIUM):
(WebKit::WebGraphicsContext3D::asyncTexSubImage2DCHROMIUM):

11:05 AM Changeset in webkit [136857] by commit-queue@webkit.org
  • 11 edits
    4 adds in trunk

[CSS Exclusions] Add support for computing the first included interval position.
https://bugs.webkit.org/show_bug.cgi?id=103327

Source/WebCore:

Patch by Hans Muller <hmuller@adobe.com> on 2012-12-06
Reviewed by Levi Weintraub.

If the first "word" in a line doesn't fit within the shape-inside when lineTop
is the top of the shape's logical bounding box, adjust lineTop downwards to where
the word fits. Currently only rounded rectangle shapes are supported.

Added ExclusionShape::firstIncludedIntervalLogicalTop(). The new virtual method
computes the topmost/leftmost location where a line segment with the specified
minLogicalIntervalSize will fit within the exclusion shape and returns the
corresponding logical Y coordinate. The result is additionally constrained to
be at or below minLogicalIntervalTop. If the segment will not fit anywhere within
the shape, then false is returned.

During layout, minLogicalIntervalTop is the nominal top of the line being laid
out within the exclusion shape.

RenderBlock::layoutRunsAndFloatsInRange() now calls a new ExclusionShapeInsideInfo
method, adjustLogicalLineTop(), which uses firstIncludedIntervalLogicalTop() to
decide if the logical top of the line has to be moved downwards, for the first
word to fit within the exclusion shape.

Tests: fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-001.html

fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-002.html

  • rendering/ExclusionPolygon.cpp:

(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): This is a stub implementation.

  • rendering/ExclusionPolygon.h:
  • rendering/ExclusionRectangle.cpp:

(WebCore::ellipseXIntercept): Added spaces to conform to webkit style and to be consistent with ellipseYIntercept()
(WebCore::ellipseYIntercept): Compute an ellipse's Y intercept for an X coordinate.
(WebCore::ExclusionRectangle::firstIncludedIntervalLogicalTop): See the description above.

  • rendering/ExclusionRectangle.h:
  • rendering/ExclusionShape.h:

(ExclusionShape):
(WebCore::ExclusionShape::logicalTopForMinY): Internal to logical coordinate conversion.

  • rendering/ExclusionShapeInsideInfo.cpp:

(WebCore::ExclusionShapeInsideInfo::adjustLogicalLineTop): A new method that updates m_lineTop with firstIncludedIntervalPosition().

  • rendering/ExclusionShapeInsideInfo.h:

(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::logicalLineTop): This is just a cover for the private m_lineTop field.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Added code that restarts the layout loop if it's necessary to adjust the line's logicalTop.
(WebCore::RenderBlock::restartLayoutRunsAndFloatsInRange): Factored newly common code into this helper function.

LayoutTests:

Test the rounded rectangle support for adjusting the top of a line downwards
when the first word doesn't fit within the shape.

Patch by Hans Muller <hmuller@adobe.com> on 2012-12-06
Reviewed by Levi Weintraub.

  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-001-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-001.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-002-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-002.html: Added.
10:59 AM Changeset in webkit [136856] by mvujovic@adobe.com
  • 2 edits in trunk/Tools

Unreviewed. Add myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
10:24 AM Changeset in webkit [136855] by schenney@chromium.org
  • 16 edits
    8 adds
    4 deletes in trunk/LayoutTests

Rebaseline some expectations

Unreviewed expectations update

These test have expectations but apparently just need rebaselines.
Some may still be flakey.

  • platform/chromium-linux/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-linux/svg/css/group-with-shadow-expected.png:
  • platform/chromium-linux/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
  • platform/chromium-mac-lion/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-mac-lion/svg/css/group-with-shadow-expected.png:
  • platform/chromium-mac-lion/svg/custom/mask-invalidation-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/transform-with-shadow-and-gradient-expected.png: Removed.
  • platform/chromium-mac/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-mac/svg/css/group-with-shadow-expected.png:
  • platform/chromium-mac/svg/custom/radialGradient-focal-radius-expected.png: Added.
  • platform/chromium-mac/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
  • platform/chromium-win-xp/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/svg/custom/mask-invalidation-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/chromium-win/svg/custom/radialGradient-focal-radius-expected.png: Added.
  • platform/chromium-win/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
  • platform/chromium/svg/custom/radialGradient-focal-radius-expected.png: Removed.
  • platform/chromium/svg/custom/transform-with-shadow-and-gradient-expected.png: Removed.
  • platform/efl-wk1/svg/custom: Added.
  • platform/efl-wk1/svg/custom/radialGradient-focal-radius-expected.png: Added.
  • platform/efl/svg/custom/radialGradient-focal-radius-expected.png: Removed.
10:18 AM Changeset in webkit [136854] by commit-queue@webkit.org
  • 2 edits in trunk

[EFL] Optimize binary size by removing dead sections on unix/gcc
https://bugs.webkit.org/show_bug.cgi?id=102827

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-12-06
Reviewed by Kenneth Rohde Christiansen.

Turn on -ffunction-sections -fdata-sections --gc-section flags
on unix for the gcc toolchain for release builds to optimize binary
size for the Efl port.

  • Source/cmake/OptionsEfl.cmake:
10:10 AM Changeset in webkit [136853] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Test expectations update
https://bugs.webkit.org/show_bug.cgi?id=104007

Unreviewed expectations update.

  • platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png:
10:02 AM Changeset in webkit [136852] by wjmaclean@chromium.org
  • 3 edits
    3 adds in trunk

[chromium] Should apply link highlight to largest enclosing node with a handCursor.
https://bugs.webkit.org/show_bug.cgi?id=104264

Reviewed by Adrienne Walker.

Source/WebKit/chromium:

Link highlights sometimes only apply to part of a link, if we select an enclosed
node (e.g. font changes in link text). The highlight should be applied to the
largest enclosing node that still has handCursor set.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::bestTouchLinkNode):

LayoutTests:

Add layout test to cover new functionality.

  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested.html: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested-expected.png: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested-expected.txt: Added.
9:53 AM Changeset in webkit [136851] by abecsi@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Fix QWebKitTest's notification of device pixel ratio change
https://bugs.webkit.org/show_bug.cgi?id=104269

Reviewed by Kenneth Rohde Christiansen.

Since the ViewportInfoItem of MiniBrowser is created before the
WebView finishes construction, thus before the viewport controller
has been instantiated, the shown device pixel ratio was incorrect.
Additionally QWebKitTest's notification signal was also not emitted
when the value changed.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::PageViewportControllerClientQt):

9:52 AM Changeset in webkit [136850] by rniwa@webkit.org
  • 21 edits in trunk/Source/WebCore

Use ownerNode() instead of base() in HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=104244

Reviewed by Adam Barth.

Use ownerNode() instead of base() in HTMLCollection to match LiveNodeList.
Notice that the definition of base(), which this patch removes, is "return ownerNode()".

  • bindings/js/JSHTMLFormControlsCollectionCustom.cpp:

(WebCore::getNamedItems):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::indexSetter):
(WebCore::JSHTMLOptionsCollection::remove):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateOpaqueRootForGC):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp:

(WebCore::getNamedItems):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::removeCallback):
(WebCore::V8HTMLOptionsCollection::indexedPropertySetter):

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::ownerNode):

  • dom/WebKitNamedFlow.h:

(WebKitNamedFlow):

  • dom/WebKitNamedFlow.idl:
  • html/HTMLAllCollection.idl:
  • html/HTMLCollection.h:

(HTMLCollection):

  • html/HTMLCollection.idl:
  • html/HTMLFormControlsCollection.cpp:

(WebCore::HTMLFormControlsCollection::HTMLFormControlsCollection):
(WebCore::HTMLFormControlsCollection::create):
(WebCore::HTMLFormControlsCollection::formControlElements):
(WebCore::HTMLFormControlsCollection::formImageElements):
(WebCore::HTMLFormControlsCollection::namedItem):
(WebCore::HTMLFormControlsCollection::updateNameCache):

  • html/HTMLFormControlsCollection.idl:
  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::~HTMLNameCollection):
(WebCore::HTMLNameCollection::virtualItemAfter):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):
(WebCore::HTMLOptionsCollection::remove):
(WebCore::HTMLOptionsCollection::selectedIndex):
(WebCore::HTMLOptionsCollection::setSelectedIndex):
(WebCore::HTMLOptionsCollection::setLength):

  • html/HTMLOptionsCollection.idl:
  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::updateRefElements):
(WebCore::HTMLPropertiesCollection::namedItem):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::virtualItemAfter):

9:49 AM Changeset in webkit [136849] by zandobersek@gmail.com
  • 10 edits
    1 delete in trunk/LayoutTests

UndoManager layout tests should be removed
https://bugs.webkit.org/show_bug.cgi?id=104246

Reviewed by Adam Barth.

The UndoManager feature support was removed from the source tree
in r133326. The layout tests should be removed as well. As with
the feature implementation, these too can be restored back when needed.

  • editing/undomanager: Removed.
  • editing/undomanager/automatic-transaction-attribute-expected.txt: Removed.
  • editing/undomanager/automatic-transaction-attribute.html: Removed.
  • editing/undomanager/automatic-transaction-data-expected.txt: Removed.
  • editing/undomanager/automatic-transaction-data.html: Removed.
  • editing/undomanager/automatic-transaction-node-expected.txt: Removed.
  • editing/undomanager/automatic-transaction-node.html: Removed.
  • editing/undomanager/document-has-undomanager-expected.txt: Removed.
  • editing/undomanager/document-has-undomanager.html: Removed.
  • editing/undomanager/domtransaction-survives-gc-expected.txt: Removed.
  • editing/undomanager/domtransaction-survives-gc.html: Removed.
  • editing/undomanager/undomanager-isolated-world-expected.txt: Removed.
  • editing/undomanager/undomanager-isolated-world.html: Removed.
  • editing/undomanager/undomanager-item-expected.txt: Removed.
  • editing/undomanager/undomanager-item.html: Removed.
  • editing/undomanager/undomanager-reenter-expected.txt: Removed.
  • editing/undomanager/undomanager-reenter.html: Removed.
  • editing/undomanager/undomanager-transact-expected.txt: Removed.
  • editing/undomanager/undomanager-transact.html: Removed.
  • editing/undomanager/undomanager-undo-redo-expected.txt: Removed.
  • editing/undomanager/undomanager-undo-redo.html: Removed.
  • editing/undomanager/undoscopehost-use-after-free-expected.txt: Removed.
  • editing/undomanager/undoscopehost-use-after-free.html: Removed.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-4.8/TestExpectations:
  • platform/qt-mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
9:49 AM WebKit Team edited by akling@apple.com
(diff)
9:43 AM Changeset in webkit [136848] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
https://bugs.webkit.org/show_bug.cgi?id=104139

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-12-06
Reviewed by Kenneth Rohde Christiansen.

Resize the window back to 800x600 between tests.
This should be a no-op if the test did not resize the window.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

9:07 AM Changeset in webkit [136847] by alexis@webkit.org
  • 2 edits in trunk/LayoutTests

[Mac] Unreviewed gardening after r136415.

r136415 enables the CSS3 background position offsets therefore this
expected png needs to be updated with the new result (the correct one
actually). It was not failing on the bot as the Apple Mac bot does not
seem to run pixel tests.

  • platform/mac/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
8:59 AM Changeset in webkit [136846] by tommyw@google.com
  • 19 edits in trunk

Speech Recognition API: Change the error code to a string on SpeechRecognitionError
https://bugs.webkit.org/show_bug.cgi?id=104254

Reviewed by Adam Barth.

Source/WebCore:

SpeechRecognitionError::code (numeric value) has been changed to SpeechRecognitionError::error (string)
in the latest specification.

http://dvcs.w3.org/hg/speech-api/raw-file/tip/speechapi.html#speechreco-error

Existing tests modified to cover this patch.

  • Modules/speech/SpeechRecognitionError.cpp:

(WebCore::ErrorCodeToString):
(WebCore):
(WebCore::SpeechRecognitionError::create):
(WebCore::SpeechRecognitionError::SpeechRecognitionError):

  • Modules/speech/SpeechRecognitionError.h:

(SpeechRecognitionErrorInit):
(WebCore::SpeechRecognitionError::error):
(SpeechRecognitionError):

  • Modules/speech/SpeechRecognitionError.idl:

Source/WebKit/chromium:

Minor WebCore type changes.

  • src/AssertMatchingEnums.cpp:
  • src/SpeechRecognitionClientProxy.cpp:

(WebKit::SpeechRecognitionClientProxy::didReceiveError):

Tools:

Changes the mock error function to take a string instead of an int.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::setMockSpeechRecognitionError):

  • DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:

(WebTestRunner::ErrorTask::ErrorTask):
(MockWebSpeechRecognizer::setError):

  • DumpRenderTree/chromium/MockWebSpeechRecognizer.h:

(MockWebSpeechRecognizer):

LayoutTests:

Adjusting tests.

  • fast/events/constructors/speech-recognition-error-constructor-expected.txt:
  • fast/events/constructors/speech-recognition-error-constructor.html:
  • fast/speech/scripted/speechrecognition-errors-expected.txt:
  • fast/speech/scripted/speechrecognition-errors.html:
  • fast/speech/scripted/speechrecognitionerror-basics-expected.txt:
  • fast/speech/scripted/speechrecognitionerror-basics.html:
  • platform/chromium/fast/events/constructors/speech-recognition-error-constructor-expected.txt:
8:53 AM Changeset in webkit [136845] by schenney@chromium.org
  • 4 edits
    3 adds in trunk

SVG <use> element inside an svg-as-image fails
https://bugs.webkit.org/show_bug.cgi?id=104007

Reviewed by Eric Seidel.

Upon redraw, SVGImage calls layout on the document it is drawing into
the image if the image, provided it believes the redraw does not need
to be delayed. Unfortunately, when an SVG <use> element is modified
(by animation, say) and regenerates its shadow tree, the destructors
invoke redraw, causing the SVGImage to call layout on something that
is in the process of being deleted. That's bad.

This change causes SVGImage to always delay the redraw. It is the most robust
way to protect against this problem, as there may be any number of
ways to cause this issue (a node being deleted in an svg-as-image
target) and this protects against them all.

The test case crashes in Asan Chromium.

Source/WebCore:

Test: svg/as-image/animated-use-as-image-crash.html

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged): Always redraw on the timer.

LayoutTests:

  • platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png: Changed as a result of this change.
  • svg/as-image/animated-use-as-image-crash-expected.txt: Added.
  • svg/as-image/animated-use-as-image-crash.html: Added.
  • svg/as-image/resources/animated-href-on-use.svg: Added.
8:41 AM Changeset in webkit [136844] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, update an expected file.

  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
7:23 AM Changeset in webkit [136843] by commit-queue@webkit.org
  • 12 edits
    1 add in trunk

TextTrack's .cues not ordered correctly when two cues have the same .startTime
https://bugs.webkit.org/show_bug.cgi?id=103266

Patch by Antoine Quint <Antoine Quint> on 2012-12-06
Reviewed by Eric Carlson.

Source/WebCore:

Adding a new method TextTrackCueList::updateCueIndex() to update the list of
cues after changing the .startTime or .endTime of a TextTrackCue. I elected to
add a new method to TextTrackCueList rather than calling remove() and then add()
on the list from TextTrack::cueDidChange() so that the nature of the operation
is abstracted and we can easily change the way we keep the cue list sorted at
a later time should we choose to.

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::cueDidChange):

  • html/track/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::updateCueIndex):
(WebCore):

  • html/track/TextTrackCueList.h:

(TextTrackCueList):

LayoutTests:

Unskip an Opera test that we now pass. Note that the original test has two issues that prompted
changes in this patch. The first issue is https://www.w3.org/Bugs/Public/show_bug.cgi?id=20066
and I've elected to comment the sub-test that fails and tracking turning it back on when the test
is corrected with https://bugs.webkit.org/show_bug.cgi?id=104255. The second issue was in the sub-test
that revealed the failure covered by this bug and had an issue acknowledged by the author
(see https://www.w3.org/Bugs/Public/show_bug.cgi?id=20066) so I fixed it in our repository.

  • media/track/opera/interfaces/TextTrack/cues-expected.txt: Added.
  • media/track/opera/interfaces/TextTrack/cues.html:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
7:01 AM Changeset in webkit [136842] by pierre.rossi@gmail.com
  • 4 edits in trunk/Source/WebKit/qt

[Qt] QWebView uses the mobile style and doesn't follow Qt's style
https://bugs.webkit.org/show_bug.cgi?id=104134

Reviewed by Simon Hausmann.

Another issue introduced by r136235.
Fix the order of initialization of the styleFactory and creation of the
WebCore Page. Since the latter has a RenderTheme member and the creation
of the appropriate RenderTheme type (QStyle-backed) is dependant on having
first initialized the theme factory function, we need to postpone this just
a little bit.

  • WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::QWebPageAdapter):
(QWebPageAdapter::initializeWebCorePage): Added.

  • WebCoreSupport/QWebPageAdapter.h:
  • WidgetApi/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate): call initializeWebCorePage only after
having initialized WebKitWidgets related logic (QStyle hooks in this case).

6:56 AM Changeset in webkit [136841] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

Unreviewed, rolling out r136788.
http://trac.webkit.org/changeset/136788
https://bugs.webkit.org/show_bug.cgi?id=104260

Asserts on EFL WebKit2 Debug bot (Requested by yael on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::setRootLayerID):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

6:45 AM Changeset in webkit [136840] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r136795.
http://trac.webkit.org/changeset/136795
https://bugs.webkit.org/show_bug.cgi?id=104257

Asserts on EFL WebKit2 Debug bot (Requested by yael on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::setRootLayerID):

6:11 AM Changeset in webkit [136839] by commit-queue@webkit.org
  • 2 edits in trunk

[EFL] Fix destination path in Source/PlatformEfl.cmake
https://bugs.webkit.org/show_bug.cgi?id=104237

Patch by Seokju Kwon <Seokju Kwon> on 2012-12-06
Reviewed by Laszlo Gombos.

Remove InspectorBackendCommands.js when copying it for the consistency in Source/PlatformEfl.cmake.

  • Source/PlatformEfl.cmake:
6:04 AM Changeset in webkit [136838] by zandobersek@gmail.com
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Adding missing platform-specific baselines.

  • platform/gtk/fast/text/decorations-with-text-combine-expected.png: Added.
  • platform/gtk/fast/text/decorations-with-text-combine-expected.txt: Added.
  • platform/gtk/fast/text/orientation-sideways-expected.png: Added.
  • platform/gtk/fast/text/orientation-sideways-expected.txt: Added.
6:02 AM Changeset in webkit [136837] by abecsi@webkit.org
  • 5 edits in trunk

[Qt][Mac] Fix libxslt and libxml2 config tests
https://bugs.webkit.org/show_bug.cgi?id=104164

Reviewed by Simon Hausmann.

Source/WebCore:

Since libxml2 is a dependency for libxslt and is not used
standalone the configurations for it should also depend on
whether XSLT is enabled.
Also avoid using pkg-config on Mac, instead use direct
include paths and add needed libraries to the linker.

No new tests needed.

  • WebCore.pri:

Tools:

We should not use pkg-config on Mac instead use direct include
paths and add needed libraries to the linker options to detect
libxslt and libxml2 provided by the system.
Previously we would always fall back to qtxmlpatterns.

  • qmake/config.tests/libxml2/libxml2.pro:
  • qmake/config.tests/libxslt/libxslt.pro:
5:55 AM Changeset in webkit [136836] by Csaba Osztrogonác
  • 4 edits in trunk/Tools

[Qt] Fix the build if the path contains "+" character
https://bugs.webkit.org/show_bug.cgi?id=104120

Reviewed by Tor Arne Vestbø.

The second parameter of qmake's replace() is regular expression, so
we have to escape special characters in paths passed to replace().

  • qmake/mkspecs/features/default_post.prf:
  • qmake/mkspecs/features/default_pre.prf:
  • qmake/mkspecs/features/functions.prf:
5:54 AM Changeset in webkit [136835] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

[EFL][Qt] fast/regions/autowidth-normalflow-maxwidth.html is failing
https://bugs.webkit.org/show_bug.cgi?id=104160

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-12-06
Reviewed by Kenneth Rohde Christiansen.

The test fast/regions/autowidth-normalflow-maxwidth.html is failing for EFL and Qt
because the test expects that the text of the test would fit in 400 pixels,
but both for Qt and for EFL, the text requires more than that.
Changed the test and the expectation ref-test to allow 450 pixels.

  • fast/regions/autowidth-normalflow-maxwidth-expected.html:
  • fast/regions/autowidth-normalflow-maxwidth.html:
  • platform/efl-wk2/TestExpectations:
  • platform/qt-5.0-wk2/TestExpectations:
5:38 AM Changeset in webkit [136834] by shinyak@chromium.org
  • 13 edits in trunk

Internals.getElementByIdInShadowRoot is nonsense now.
https://bugs.webkit.org/show_bug.cgi?id=104241

Reviewed by Kent Tamura.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Since we have ShadowRoot.getElementById() now, we don't need Internals.getElementByIdInShadowRoot, which is
the same functionality of ShadowRoot.getElementById().

Test: fast/dom/shadow/get-element-by-id-in-shadow-root.html

  • WebCore.exp.in:
  • testing/Internals.cpp:
  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def.in:

LayoutTests:

  • fast/dom/shadow/get-element-by-id-in-shadow-root-expected.txt:
  • fast/dom/shadow/get-element-by-id-in-shadow-root.html:
  • fast/dom/shadow/resources/shadow-dom.js: Uses ShadowRoot.getElementById() instead.

(getNodeInShadowTreeStack):

5:11 AM Changeset in webkit [136833] by Christophe Dumez
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Context clients should unregister themselves when destroyed
https://bugs.webkit.org/show_bug.cgi?id=104113

Reviewed by Kenneth Rohde Christiansen.

Make sure the context clients (History and Download clients)
unregister themselves when destroyed to make sure their
callback functions are never called after the client objects
have been destroyed (i.e. when the parent Ewk_Context has
been destroyed).

This addresses crashing issues after a Ewk_Context object
gets unref'd and destroyed.

  • UIProcess/efl/ContextHistoryClientEfl.cpp:

(WebKit::ContextHistoryClientEfl::ContextHistoryClientEfl):
(WebKit):
(WebKit::ContextHistoryClientEfl::~ContextHistoryClientEfl):

  • UIProcess/efl/ContextHistoryClientEfl.h:

(ContextHistoryClientEfl):

  • UIProcess/efl/DownloadManagerEfl.cpp:

(WebKit::DownloadManagerEfl::~DownloadManagerEfl):
(WebKit):

  • UIProcess/efl/DownloadManagerEfl.h:

(DownloadManagerEfl):

4:32 AM Changeset in webkit [136832] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[EFL] Active texture state gets corrupted after updating graphics surface contents.
https://bugs.webkit.org/show_bug.cgi?id=104248.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-06
Reviewed by Kenneth Rohde Christiansen.

GraphicsContext3DPrivate::copyToGraphicsSurface() doesn't restore the previously bound texture
after copying texture contents. This corrupts the texture state.

Existing Tests should cover this.

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(GraphicsContext3DPrivate::copyToGraphicsSurface):

  • platform/graphics/opengl/GLPlatformSurface.cpp:

(WebCore::GLPlatformSurface::updateContents):

  • platform/graphics/opengl/GLPlatformSurface.h:

(GLPlatformSurface):

4:29 AM Changeset in webkit [136831] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Goto panel shortcuts and description are reversed
https://bugs.webkit.org/show_bug.cgi?id=103988

Reviewed by Pavel Feldman.

Swap the square brackets in the shortcuts.

  • inspector/front-end/inspector.js:

(WebInspector._registerShortcuts):

4:13 AM Changeset in webkit [136830] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r136825.
http://trac.webkit.org/changeset/136825
https://bugs.webkit.org/show_bug.cgi?id=104251

It made 100+ test fail on Qt-WK2 pixel bot, and 1800+ test
flakey on Qt-WK2 non-pixel bot (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

3:51 AM Changeset in webkit [136829] by commit-queue@webkit.org
  • 8 edits
    2 deletes in trunk

Unreviewed, rolling out r136818.
http://trac.webkit.org/changeset/136818
https://bugs.webkit.org/show_bug.cgi?id=104249

simulatedClick does not work as per #chrmium irc. (Requested
by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

Source/WebCore:

  • dom/EventDispatcher.cpp:

(WebCore::EventRelatedTargetAdjuster::adjust):

  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::create):
(WebCore::MouseEventDispatchMediator::MouseEventDispatchMediator):
(WebCore::MouseEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.h:

(MouseEventDispatchMediator):

  • dom/Node.cpp:

(WebCore::Node::dispatchEvent):

LayoutTests:

  • fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
  • fast/dom/shadow/shadow-dom-event-dispatching.html:
  • fast/events/dispatch-synthetic-mouseevent-expected.txt: Removed.
  • fast/events/dispatch-synthetic-mouseevent.html: Removed.
3:13 AM Changeset in webkit [136828] by podivilov@chromium.org
  • 2 edits
    3 deletes in trunk/LayoutTests

[chromium] Unreviewed, fix baselines for plugins/npp-set-window-called-during-destruction.html on win7.

  • platform/chromium-linux/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
  • platform/chromium-win-xp/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
  • platform/chromium-win/plugins/npp-set-window-called-during-destruction-expected.txt:
  • platform/win/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
2:48 AM Changeset in webkit [136827] by tkent@chromium.org
  • 54 edits in trunk/LayoutTests

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=104210
https://bugs.webkit.org/show_bug.cgi?id=103869

  • platform/chromium-linux/fast/forms/date/date-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/date/date-appearance-l10n-expected.png:
  • platform/chromium-linux/fast/forms/date/date-appearance-pseudo-elements-expected.png:
  • platform/chromium-linux/fast/forms/datetime/datetime-appearance-l10n-expected.png:
  • platform/chromium-linux/fast/forms/month/month-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/month/month-appearance-l10n-expected.png:
  • platform/chromium-linux/fast/forms/month/month-appearance-pseudo-elements-expected.png:
  • platform/chromium-linux/fast/forms/time/time-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/time/time-appearance-pseudo-elements-expected.png:
  • platform/chromium-linux/fast/forms/week/week-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/week/week-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-lion/fast/forms/date/date-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/date/date-appearance-l10n-expected.png:
  • platform/chromium-mac-lion/fast/forms/date/date-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-lion/fast/forms/datetime/datetime-appearance-l10n-expected.png:
  • platform/chromium-mac-lion/fast/forms/month/month-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/month/month-appearance-l10n-expected.png:
  • platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-lion/fast/forms/time/time-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/time/time-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-lion/fast/forms/week/week-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-l10n-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/datetime/datetime-appearance-l10n-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-l10n-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/date/date-appearance-l10n-expected.png:
  • platform/chromium-mac/fast/forms/date/date-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/month/month-appearance-l10n-expected.png:
  • platform/chromium-mac/fast/forms/month/month-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/time/time-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/week/week-appearance-pseudo-elements-expected.png:
  • platform/chromium-win-xp/fast/forms/date/date-appearance-l10n-expected.png:
  • platform/chromium-win-xp/fast/forms/month/month-appearance-l10n-expected.png:
  • platform/chromium-win/fast/forms/date/date-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/date/date-appearance-l10n-expected.png:
  • platform/chromium-win/fast/forms/date/date-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/datetime/datetime-appearance-l10n-expected.png:
  • platform/chromium-win/fast/forms/month/month-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/month/month-appearance-l10n-expected.png:
  • platform/chromium-win/fast/forms/month/month-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/time/time-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/time/time-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/week/week-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/week/week-appearance-pseudo-elements-expected.png:
  • platform/chromium/TestExpectations:
2:25 AM Changeset in webkit [136826] by tkent@chromium.org
  • 111 edits
    16 adds in trunk/LayoutTests

[Chromium] Update test expectations
https://bugs.webkit.org/show_bug.cgi?id=103853
https://bugs.webkit.org/show_bug.cgi?id=103869

  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium/TestExpectations:
2:08 AM Changeset in webkit [136825] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
https://bugs.webkit.org/show_bug.cgi?id=104139

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-12-06
Reviewed by Kenneth Rohde Christiansen.

Resize the window back to 800x600 between tests.
This should be a no-op if the test did not resize the window.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

1:49 AM Changeset in webkit [136824] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[v8] Fix hidden property name of V8ArrayBufferView flag.
https://bugs.webkit.org/show_bug.cgi?id=104099

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-12-06
Reviewed by Kentaro Hara.

Fix hidden property name of V8ArrayBufferView hidden copy method.

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

  • bindings/v8/custom/V8ArrayBufferViewCustom.cpp:

(WebCore::getHiddenCopyMethod):
(WebCore::installHiddenCopyMethod):

1:38 AM Changeset in webkit [136823] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fixed a wrong comment landed in r136822.

  • bindings/v8/V8Binding.h:

(WebCore):

1:19 AM Changeset in webkit [136822] by haraken@chromium.org
  • 23 edits in trunk/Source/WebCore

[V8] Implement deprecatedV8String()
https://bugs.webkit.org/show_bug.cgi?id=104230

Reviewed by Adam Barth.

To make an Isolate mandatory in v8String(), we implement
deprecatedV8String() for call sites that don't have
an Isolate. Eventually we want to kill the method though.

No tests. No change in behavior.

  • bindings/scripts/test/V8/V8TestCallback.cpp:

(WebCore::V8TestCallback::callbackWithClass2Param):

  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::getKey):

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::get):
(WebCore::set):

  • bindings/v8/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::evaluate):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::compileAndRunScript):
(WebCore::ScriptController::bindToWindowObject):
(WebCore::ScriptController::disableEval):

  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::setScriptSource):
(WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled):
(WebCore::ScriptDebugServer::compileScript):

  • bindings/v8/ScriptFunctionCall.cpp:

(WebCore::ScriptCallArgumentHandler::appendArgument):
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):
(WebCore::ScriptProfiler::takeHeapSnapshot):

  • bindings/v8/ScriptSourceCode.cpp:

(WebCore::ScriptSourceCode::compileScript):

  • bindings/v8/V8Binding.h:

(WebCore):
(WebCore::deprecatedV8String):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::namedItemAdded):
(WebCore::V8DOMWindowShell::namedItemRemoved):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8WindowErrorHandler.cpp:

(WebCore::V8WindowErrorHandler::callListenerFunction):

  • bindings/v8/V8WorkerContextErrorHandler.cpp:

(WebCore::V8WorkerContextErrorHandler::callListenerFunction):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

  • bindings/v8/custom/V8ArrayBufferViewCustom.cpp:

(WebCore::installHiddenCopyMethod):
(WebCore::copyElements):

  • bindings/v8/custom/V8CustomXPathNSResolver.cpp:

(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::getEventListenersCallback):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):

1:03 AM Changeset in webkit [136821] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Page popup should align to the right when the anchor element is rtl
https://bugs.webkit.org/show_bug.cgi?id=104219

Reviewed by Kent Tamura.

Page popup should align to the right edge of the anchor element when the anchor element is rtl.

No new tests. Mock page popup can't test popup window position.

  • Resources/pagepopups/pickerCommon.js:

(_adjustWindowRectHorizontally): Align to the right edge when anchor element is rtl. Removed some redundant lines.
(setWindowRect): If the window is hidden we want to move first then resize so the popup doesn't flicker.
(isWindowHidden): Returns true if the window is hidden using hideWindow().

1:01 AM Changeset in webkit [136820] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Make an Isolate mandatory for v8StringOrNull() and v8StringOrUndefined()
https://bugs.webkit.org/show_bug.cgi?id=104213

Reviewed by Adam Barth.

All call sites of v8StringOrNull() and v8StringOrUndefined() have an Isolate.

No tests. No change in behavior.

  • bindings/v8/V8Binding.h:

(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):

12:57 AM Changeset in webkit [136819] by haraken@chromium.org
  • 14 edits in trunk/Source/WebCore

[V8] Implement deprecatedV8Integer(int i)
https://bugs.webkit.org/show_bug.cgi?id=104220

Reviewed by Adam Barth.

To make an Isolate mandatory in v8Integer(), we implement
deprecatedV8Integer(int i) for call sites that don't have
an Isolate. Eventually we want to kill deprecatedV8Integer(int i).

No new tests. No change in behavior.

  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

  • bindings/v8/NPV8Object.cpp:

(_NPN_Enumerate):

  • bindings/v8/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):

  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::compileScript):

  • bindings/v8/ScriptSourceCode.cpp:

(WebCore::ScriptSourceCode::compileScript):

  • bindings/v8/V8Binding.h:

(WebCore):
(WebCore::deprecatedV8Integer):

  • bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::batchConfigureConstants):

  • bindings/v8/V8NPUtils.cpp:

(WebCore::convertNPVariantToV8Object):

  • bindings/v8/V8Utilities.cpp:

(WebCore::createHiddenDependency):
(WebCore::removeHiddenDependency):

  • bindings/v8/V8WindowErrorHandler.cpp:

(WebCore::V8WindowErrorHandler::callListenerFunction):

  • bindings/v8/V8WorkerContextErrorHandler.cpp:

(WebCore::V8WorkerContextErrorHandler::callListenerFunction):

  • bindings/v8/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::addListener):

  • bindings/v8/custom/V8MutationCallbackCustom.cpp:

(WebCore::V8MutationCallback::handleEvent):

12:52 AM Changeset in webkit [136818] by hayato@chromium.org
  • 8 edits
    2 adds in trunk

Event's relatedTarget re-targeting does not occur for manually fired mouse events created by event.initMouseEvent().
https://bugs.webkit.org/show_bug.cgi?id=102681

Reviewed by Dimitri Glazkov.

Source/WebCore:

Make sure that event's relatedTarget re-targeting occurs for mouse
events created by event.initMouseEvent(). Since user-generated
mouse events can have a relatedTarget which is same to the target
node, the algorithm which calculates event's ancestors is also
updated so that ancestors are not shrunk wrongly.

Test: fast/events/dispatch-synthetic-mouseevent.html

fast/dom/shadow/shadow-dom-event-dispatching.html

  • dom/EventDispatcher.cpp:

(WebCore::EventRelatedTargetAdjuster::adjust):

  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::create):
(WebCore::MouseEventDispatchMediator::MouseEventDispatchMediator):
(WebCore::MouseEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.h:

(WebCore::MouseEventDispatchMediator::isSyntheticMouseEvent):
(MouseEventDispatchMediator):

  • dom/Node.cpp:

(WebCore::Node::dispatchEvent):

LayoutTests:

  • fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
  • fast/dom/shadow/shadow-dom-event-dispatching.html:
  • fast/events/dispatch-synthetic-mouseevent-expected.txt: Added.
  • fast/events/dispatch-synthetic-mouseevent.html: Added.
12:50 AM Changeset in webkit [136817] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[JSC] Check whether property is an array before attempting conversion to array in JSDictionary
https://bugs.webkit.org/show_bug.cgi?id=96614

Patch by Michael Pruett <michael@68k.org> on 2012-12-06
Reviewed by Kentaro Hara.

JSDictionary should check whether the property being accessed in get()
is an array before attempting to convert the value to an array.

Previously calling get() with a result type of Vector<String> when
the named property could not be converted to an array would generate
an exception.

Tests: storage/indexeddb/*

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSDictionary.h:

(WebCore::JSDictionary::tryGetPropertyAndResult):

12:47 AM Changeset in webkit [136816] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Pass Isolate to toDOMStringList()
https://bugs.webkit.org/show_bug.cgi?id=104224

Reviewed by Adam Barth.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(JSValueToNative):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):

  • bindings/v8/V8Binding.cpp:

(WebCore::toDOMStringList):

  • bindings/v8/V8Binding.h:

(WebCore):

12:43 AM Changeset in webkit [136815] by haraken@chromium.org
  • 7 edits
    2 deletes in trunk/Source/WebCore

Remove JSDependentRetained.h and V8DependentRetained.h
https://bugs.webkit.org/show_bug.cgi?id=104232

Reviewed by Adam Barth.

Although (JS|V8)DependentRetained.h were introduced for MutationObservers,
they are not going to be used (See the discussion in bug 95519).
We can remove them.

No tests. No change in behavior.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDependentRetained.h: Removed.
  • bindings/v8/V8DependentRetained.h: Removed.
  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::V8PerIsolateData):

  • bindings/v8/V8PerIsolateData.h:

(V8PerIsolateData):

12:32 AM Changeset in webkit [136814] by zandobersek@gmail.com
  • 1 edit
    15 adds
    34 deletes in trunk/LayoutTests

Turn pixel tests in dom/xhtml/level3/core into reftests
https://bugs.webkit.org/show_bug.cgi?id=103809

Reviewed by Dirk Pranke.

Turn 15 pixel tests under dom/xhtml/level3/core into reftests.
The reference files are tailored so they present the same output that
the pixel baselines (being removed) do.

  • dom/xhtml/level3/core/canonicalform08-expected.html: Added.
  • dom/xhtml/level3/core/canonicalform09-expected.html: Added.
  • dom/xhtml/level3/core/documentgetinputencoding03-expected.html: Added.
  • dom/xhtml/level3/core/entitygetinputencoding02-expected.html: Added.
  • dom/xhtml/level3/core/entitygetxmlversion02-expected.html: Added.
  • dom/xhtml/level3/core/nodegetbaseuri05-expected.html: Added.
  • dom/xhtml/level3/core/nodegetbaseuri07-expected.html: Added.
  • dom/xhtml/level3/core/nodegetbaseuri09-expected.html: Added.
  • dom/xhtml/level3/core/nodegetbaseuri10-expected.html: Added.
  • dom/xhtml/level3/core/nodegetbaseuri11-expected.html: Added.
  • dom/xhtml/level3/core/nodegetbaseuri15-expected.html: Added.
  • dom/xhtml/level3/core/nodegetbaseuri17-expected.html: Added.
  • dom/xhtml/level3/core/nodegetbaseuri18-expected.html: Added.
  • dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.html: Added.
  • dom/xhtml/level3/core/nodelookupprefix19-expected.html: Added.
  • The now-unnecessary pixel and render tree baselines: Removed.
12:31 AM Changeset in webkit [136813] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Replace v8String("symbol") with v8::String::NewSymbol("symbol")
https://bugs.webkit.org/show_bug.cgi?id=104209

Reviewed by Adam Barth.

V8 can look up symbols faster than strings.

No tests. No change in behavior.

  • bindings/v8/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::caller):
(WebCore::JavaScriptCallFrame::sourceID):
(WebCore::JavaScriptCallFrame::line):
(WebCore::JavaScriptCallFrame::column):
(WebCore::JavaScriptCallFrame::functionName):
(WebCore::JavaScriptCallFrame::scopeChain):
(WebCore::JavaScriptCallFrame::scopeType):
(WebCore::JavaScriptCallFrame::thisObject):
(WebCore::JavaScriptCallFrame::evaluate):
(WebCore::JavaScriptCallFrame::restart):

  • bindings/v8/V8ThrowException.cpp:

(WebCore::domExceptionStackGetter):
(WebCore::domExceptionStackSetter):
(WebCore::V8ThrowException::setDOMException):

  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::V8InspectorFrontendHost::platformCallback):

  • bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:

(WebCore::V8JavaScriptCallFrame::typeAccessorGetter):

12:20 AM Changeset in webkit [136812] by commit-queue@webkit.org
  • 12 edits
    10 adds in trunk

Unreviewed, rolling out r136784 and r136802.
http://trac.webkit.org/changeset/136784
http://trac.webkit.org/changeset/136802
https://bugs.webkit.org/show_bug.cgi?id=104231

breaks chromium canary (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

Source/Platform:

  • Platform.gypi:
  • chromium/public/linux/WebThemeEngine.h: Added.

(WebKit):
(WebThemeEngine):
(ScrollbarTrackExtraParams):
(ButtonExtraParams):
(TextFieldExtraParams):
(MenuListExtraParams):
(SliderExtraParams):
(InnerSpinButtonExtraParams):
(ProgressBarExtraParams):
(WebKit::WebThemeEngine::getSize):
(WebKit::WebThemeEngine::paint):

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/PlatformThemeChromiumLinux.cpp: Added.

(WebCore):
(WebCore::PlatformThemeChromiumLinux::setScrollbarColors):
(WebCore::clamp):
(WebCore::PlatformThemeChromiumLinux::saturateAndBrighten):
(WebCore::PlatformThemeChromiumLinux::outlineColor):
(WebCore::PlatformThemeChromiumLinux::paintArrowButton):

  • platform/chromium/PlatformThemeChromiumLinux.h: Added.

(WebCore):
(PlatformThemeChromiumLinux):
(WebCore::PlatformThemeChromiumLinux::thumbInactiveColor):
(WebCore::PlatformThemeChromiumLinux::thumbActiveColor):
(WebCore::PlatformThemeChromiumLinux::trackColor):
(WebCore::PlatformThemeChromiumLinux::PlatformThemeChromiumLinux):

  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: Added.

(WebCore):
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumLinux::paintButton):
(WebCore::ScrollbarThemeChromiumLinux::paintThumb):
(WebCore::ScrollbarThemeChromiumLinux::shouldCenterOnThumb):
(WebCore::ScrollbarThemeChromiumLinux::buttonSize):
(WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):

  • platform/chromium/ScrollbarThemeChromiumLinux.h: Added.

(ScrollbarThemeChromiumLinux):

  • rendering/RenderThemeChromiumAndroid.cpp:

(WebCore::RenderThemeChromiumAndroid::extraDefaultStyleSheet):

  • rendering/RenderThemeChromiumAndroid.h:
  • rendering/RenderThemeChromiumLinux.cpp: Added.

(WebCore):
(WebCore::getWebThemeState):
(WebCore::RenderThemeChromiumLinux::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux):
(WebCore::RenderThemeChromiumLinux::~RenderThemeChromiumLinux):
(WebCore::RenderThemeChromiumLinux::systemColor):
(WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet):
(WebCore::RenderThemeChromiumLinux::controlSupportsTints):
(WebCore::RenderThemeChromiumLinux::activeListBoxSelectionBackgroundColor):
(WebCore::RenderThemeChromiumLinux::activeListBoxSelectionForegroundColor):
(WebCore::RenderThemeChromiumLinux::inactiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeChromiumLinux::inactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeChromiumLinux::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumLinux::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumLinux::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeChromiumLinux::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeChromiumLinux::sliderTickSize):
(WebCore::RenderThemeChromiumLinux::sliderTickOffsetFromTrackCenter):
(WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
(WebCore::RenderThemeChromiumLinux::supportsControlTints):
(WebCore::RenderThemeChromiumLinux::setCaretBlinkInterval):
(WebCore::RenderThemeChromiumLinux::caretBlinkIntervalInternal):
(WebCore::RenderThemeChromiumLinux::setSelectionColors):
(WebCore::RenderThemeChromiumLinux::paintCheckbox):
(WebCore::RenderThemeChromiumLinux::setCheckboxSize):
(WebCore::RenderThemeChromiumLinux::paintRadio):
(WebCore::RenderThemeChromiumLinux::setRadioSize):
(WebCore::RenderThemeChromiumLinux::paintButton):
(WebCore::RenderThemeChromiumLinux::paintTextField):
(WebCore::RenderThemeChromiumLinux::paintMenuList):
(WebCore::RenderThemeChromiumLinux::paintSliderTrack):
(WebCore::RenderThemeChromiumLinux::paintSliderThumb):
(WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumLinux::paintInnerSpinButton):
(WebCore::RenderThemeChromiumLinux::paintProgressBar):
(WebCore::RenderThemeChromiumLinux::shouldOpenPickerWithF4Key):

  • rendering/RenderThemeChromiumLinux.h: Added.

(WebCore):
(RenderThemeChromiumLinux):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/linux/WebRenderTheme.h: Added.

(WebKit):

  • public/platform/linux/WebThemeEngine.h: Added.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setScrollbarColors):
(WebKit::WebViewImpl::setSelectionColors):

  • src/linux/WebRenderTheme.cpp: Added.

(WebKit):
(WebKit::setCaretBlinkInterval):

Tools:

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest):

Note: See TracTimeline for information about the timeline view.