Timeline
Dec 25, 2012:
- 11:24 PM Changeset in webkit [138472] by
-
- 2 edits in trunk/Source/JavaScriptCore
[CMAKE] Remove header files in JavaScriptCore/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=105753
Reviewed by Laszlo Gombos.
- CMakeLists.txt: Remove header files in source list.
- 6:36 PM Changeset in webkit [138471] by
-
- 4 edits in trunk/Source/WebKit2
Fix the Database manager assert, again.
- WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit):
(WebKit::WebDatabaseManager::WebDatabaseManager):
(WebKit::WebDatabaseManager::initialize):
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
(WebDatabaseManager):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
- 6:29 PM Changeset in webkit [138470] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Need to initialize the onLine in the global
https://bugs.webkit.org/show_bug.cgi?id=105749
Reviewed by George Staikos.
The NetworkStatus is initialized to online in the constructor by default,
we need to update it correctly with the network status at startup.
- Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::globalInitialize):
- 6:15 PM Changeset in webkit [138469] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Media controls are drawn on top of one another for media with unknown duration.
https://bugs.webkit.org/show_bug.cgi?id=105747
Patch by John Griggs <jgriggs@rim.com> on 2012-12-25
Reviewed by George Staikos.
No need to reposition controls when there is no timeline element, this mispositions them in the new design.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
- 6:04 PM Changeset in webkit [138468] by
-
- 8 edits in trunk/Source/WebKit2
Coordinated Graphics: Manage the lifecycle of CoordinatedGraphicsLayer explicitly.
https://bugs.webkit.org/show_bug.cgi?id=104990
Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-25
Reviewed by Noam Rosenthal.
Send explicit commands to the UI process to create/delete compositing
layers, instead of having the UI process decide lazily when to create
them.
Avoid creating a compositing layer at all if it was deleted in the same
cycle.
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::createCompositingLayer):
(WebKit):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(CoordinatedLayerTreeHostProxy):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::createCanvas):
(WebKit::LayerTreeRenderer::destroyCanvas):
(WebKit::LayerTreeRenderer::setLayerChildren):
(WebKit::LayerTreeRenderer::setLayerFilters):
(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::getLayerByIDIfExists):
(WebKit):
(WebKit::LayerTreeRenderer::createLayer):
(WebKit::LayerTreeRenderer::deleteLayer):
(WebKit::LayerTreeRenderer::setRootLayerID):
(WebKit::LayerTreeRenderer::createTile):
(WebKit::LayerTreeRenderer::removeTile):
(WebKit::LayerTreeRenderer::updateTile):
(WebKit::LayerTreeRenderer::ensureRootLayer):
(WebKit::LayerTreeRenderer::setLayerAnimations):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer):
(WebKit::LayerTreeRenderer::layerByID):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::flushPendingLayerChanges):
(WebKit::CoordinatedLayerTreeHost::createCompositingLayers):
(WebKit):
(WebKit::CoordinatedLayerTreeHost::deleteCompositingLayers):
(WebKit::CoordinatedLayerTreeHost::detachLayer):
(WebKit::CoordinatedLayerTreeHost::createGraphicsLayer):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- 5:56 PM Changeset in webkit [138467] by
-
- 2 edits in trunk/Source/WebKit2
Fix Qt build.
- WebProcess/WebPage/qt/WebPageQt.cpp:
- 5:37 PM Changeset in webkit [138466] by
-
- 16 edits in trunk/Source/WebKit2
Reduce the number of includes in WebProcess.h
https://bugs.webkit.org/show_bug.cgi?id=105709
Reviewed by Dan Bernstein.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::downloadsAuthenticationManager):
- NetworkProcess/NetworkProcess.h:
(WebKit):
- Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
- WebProcess/FullScreen/WebFullScreenManager.cpp:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/Network/NetworkProcessConnection.cpp:
- WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
- WebProcess/WebPage/FindController.cpp:
- WebProcess/WebPage/WebContextMenu.cpp:
- WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::downloadsAuthenticationManager):
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::geolocationManager):
(WebKit):
(WebKit::WebProcess::applicationCacheManager):
(WebKit::WebProcess::resourceCacheManager):
(WebKit::WebProcess::cookieManager):
(WebKit::WebProcess::authenticationManager):
(WebKit::WebProcess::databaseManager):
(WebKit::WebProcess::notificationManager):
(WebKit::WebProcess::pluginProcessConnectionManager):
(WebKit::WebProcess::networkProcessConnectionClosed):
(WebKit::WebProcess::webResourceLoadScheduler):
(WebKit::WebProcess::pluginProcessCrashed):
- WebProcess/WebProcess.h:
(WebCore):
(WebKit):
(WebProcess):
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- 1:07 PM Changeset in webkit [138465] by
-
- 11 edits3 adds in trunk/Source/JavaScriptCore
JITThunks should be in its own file
https://bugs.webkit.org/show_bug.cgi?id=105744
Rubber stamped by Sam Weinig.
Moved JITThunks into its own file and removed some static methods from it
that were not related to what JITThunks currently does. Performed various
pagan rituals to get it to build - apparently there is a circular dependency
between JSCell, Weak, and JITThunks, which magically resolves itself if you
make sure to first include Register.h. Making it so that fewer pagan rituals
need to be performed if this code changes in the future is covered by
https://bugs.webkit.org/show_bug.cgi?id=105696.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- jit/JITStubs.cpp:
(JSC::tryCachePutByID):
(JSC::tryCacheGetByID):
- jit/JITStubs.h:
(JSC::JITStackFrame::returnAddressSlot):
(JSC::returnAddressIsInCtiTrampoline):
- jit/JITThunks.cpp: Added.
(JSC::JITThunks::JITThunks):
(JSC::JITThunks::~JITThunks):
(JSC::JITThunks::ctiStub):
(JSC::JITThunks::hostFunctionStub):
(JSC::JITThunks::clearHostFunctionStubs):
- jit/JITThunks.h: Added.
(JSC::JITThunks::ctiStringLengthTrampoline):
(JSC::JITThunks::ctiVirtualCallLink):
(JSC::JITThunks::ctiVirtualConstructLink):
(JSC::JITThunks::ctiVirtualCall):
(JSC::JITThunks::ctiVirtualConstruct):
(JSC::JITThunks::ctiNativeCall):
(JSC::JITThunks::ctiNativeConstruct):
- jit/ThunkGenerator.h: Added.
- jit/ThunkGenerators.cpp:
- jit/ThunkGenerators.h:
- runtime/JSGlobalData.h:
- 1:06 PM Changeset in webkit [138464] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][Mac] Call Carbon resource APIs on main thread only.
<rdar://problem/11760262>
<http://webkit.org/b/105746>
Reviewed by Anders Carlsson.
The Carbon resource APIs are not thread-safe, so use a little libdispatch sugar to make
sure that plugin enumeration never calls them on a secondary thread.
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getPluginInfoFromCarbonResourcesOnMainThread):
(WebKit::getPluginInfoFromCarbonResources):
- 9:08 AM Changeset in webkit [138463] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Build breaks with --no-input-type-color
https://bugs.webkit.org/show_bug.cgi?id=105740
Patch by Seokju Kwon <Seokju Kwon> on 2012-12-25
Reviewed by Laszlo Gombos.
- UIProcess/API/efl/EwkViewImpl.h: Add INPUT_TYPE_COLOR guard.
(EwkViewImpl):
- 4:28 AM Changeset in webkit [138462] by
-
- 9 edits in trunk
[EFL][WK2] Refactor snapshot taking code
https://bugs.webkit.org/show_bug.cgi?id=105687
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Refactor EFL WK2 snapshot taking code to use
smart pointers when possible and follow naming
conventions.
- UIProcess/API/C/efl/WKView.cpp:
(WKViewCreateSnapshot):
- UIProcess/API/C/efl/WKView.h: Rename WKViewGetSnapshot
to WKViewCreateSnapshot to follow C API naming conventions,
since the returned value needs to be adopted.
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::takeSnapshot):
- UIProcess/API/efl/EwkViewImpl.h: Have takeSnapshot() return
a cairo_surface_t instead of a WKType. The value should be
converted to a WKType at C API level.
(EwkViewImpl):
- UIProcess/API/efl/SnapshotImageGL.cpp: Use OwnArrayPtr for the
buffer to avoid manual memory handling. Remove useless call to
glBindTexture() since glReadPixels() reads pixels from the frame
buffer, not from the texture.
(getImageDataFromFrameBuffer):
- UIProcess/API/efl/SnapshotImageGL.h: Rename getImageFromCurrentTexture
to getImageDataFromFrameBuffer for consistency since we technically
return the pixel data of the image and since glReadPixels does not
actually read from the texture. Have the function return a smart
pointer instead of a raw one to avoid manual memory handling.
Tools:
Call WKViewCreateSnapshot() instead of WKViewGetSnapshot()
since the function was renamed to follow naming style.
- WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::windowSnapshotImage):
- 3:08 AM Changeset in webkit [138461] by
-
- 12 edits in trunk/Source/WebKit2
PDFPlugin: Find-in-page
https://bugs.webkit.org/show_bug.cgi?id=105710
<rdar://problem/12555331>
Reviewed by Alexey Proskuryakov.
Make use of PDFLayerController's find-in-page functionality to mimic WebKit's.
Add two Plugin methods, countFindMatches and findString, and make use of them
if attempting to find-in-page within a PluginDocument.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::countFindMatches): Added. We don't support find-in-page for NetscapePlugin.
(WebKit::NetscapePlugin::findString): Added. We don't support find-in-page for NetscapePlugin.
- WebProcess/Plugins/Netscape/NetscapePlugin.h: Add countFindMatches and findString.
- WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add requisite PDFLayerController interfaces.
- WebProcess/Plugins/PDF/PDFPlugin.h: Add countFindMatches, findString, and nextMatchForString,
as well as storage for the most-recently-searched string.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::writeItemsToPasteboard):
(WebKit::PDFPlugin::countFindMatches):
(WebKit::PDFPlugin::nextMatchForString):
(WebKit::PDFPlugin::findString):
- WebProcess/Plugins/PDF/SimplePDFPlugin.h: Add countFindMatches and findString.
- WebProcess/Plugins/Plugin.h: Add countFindMatches and findString.
- WebProcess/Plugins/PluginProxy.h: Add countFindMatches and findString, but since PDFPlugin
is in-process, we don't need to forward these calls to the PluginProcess.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::countFindMatches): Forward countFindMatches to the plugin.
(WebKit::PluginView::findString): Forward findString to the plugin.
- WebProcess/Plugins/PluginView.h: Add countFindMatches and findString.
- WebProcess/WebPage/FindController.cpp:
(WebKit::pluginViewForFrame): If the given frame hosts a PluginDocument, grab its PluginView.
(WebKit::FindController::countStringMatches): Forward countStringMatches to PluginView if necessary.
(WebKit::FindController::updateFindUIAfterPageScroll): Only use unmarkAllTextMatches if we're using
ordinary find-in-page and don't have a plugin. If we have a plugin, disable our overlay, as it must
be handled by the plugin itself, and request the number of matches for the search from the plugin.
(WebKit::FindController::findString): If necessary, forward findString to the plugin.
(WebKit::FindController::hideFindUI): Hide the search highlight by searching for an empty string.
- 1:26 AM Changeset in webkit [138460] by
-
- 5 edits2 adds in trunk
Web Inspector: Crash when modifying a rule that has been removed through JavaScript
https://bugs.webkit.org/show_bug.cgi?id=105718
Reviewed by Yury Semikhatsky.
Source/WebCore:
CSSStyleRules should be stored by RefPtr's to avoid using stale pointers to deleted instances.
Test: inspector/styles/removed-rule-crash.html
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::ruleForId):
(WebCore::InspectorStyleSheet::revalidateStyle):
(WebCore::InspectorStyleSheet::buildArrayForRuleList):
(WebCore::InspectorStyleSheet::collectFlatRules):
- inspector/InspectorStyleSheet.h:
(InspectorStyleSheet):
LayoutTests:
- http/tests/inspector/elements-test.js: Add InspectorTest.toggleMatchedStyleProperty.
(initialize_ElementTest.InspectorTest.toggleMatchedStyleProperty): Added.
- inspector/styles/removed-rule-crash-expected.txt: Added.
- inspector/styles/removed-rule-crash.html: Added.
- 1:24 AM Changeset in webkit [138459] by
-
- 2 edits3 adds in trunk/LayoutTests
Web Inspector: device-metrics-fit-window.html is failing on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=104362
Unreviewed expectations rebaseline.
- platform/chromium-mac/platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt: Added.
- platform/chromium/TestExpectations:
- 1:13 AM Changeset in webkit [138458] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: [Console] Add "Replay XHR" context menu item for corresponding messages.
https://bugs.webkit.org/show_bug.cgi?id=105714
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-12-25
Reviewed by Pavel Feldman.
Expose "request" value from console message object and use it in console
context menu generator.
- inspector/front-end/ConsoleMessage.js: Expose "request".
- inspector/front-end/ConsoleView.js: Add "Replay XHR" menu item.
- inspector/front-end/NetworkPanel.js: Fix whitespaces.
- 1:00 AM Changeset in webkit [138457] by
-
- 63 edits in trunk/Source/WebCore
Web Inspector: Make InspectorState instances per-agent, corresponding to JSON map entries in the cookie
https://bugs.webkit.org/show_bug.cgi?id=105722
Reviewed by Yury Semikhatsky.
Inspector state cookie (in JSON format) has become a map (agent name -> "properties object")
to avoid cross-agent property name clashes in a single property namespace.
As such, InspectorState corresponds to a single "properties object" and is now per-agent,
managed by an InspectorCompositeState (which is owned by [Worker]InspectorController).
Since InspectorCompositeState maps "properties objects" by their agent names, InspectorStates are created
by InspectorCompositeState in the InspectorBaseAgentInterface ctor, using the respective agent name.
No new tests, no change in visible behavior.
- inspector/InspectorAgent.cpp: Pass InspectorCompositeState rather than InspectorState.
- inspector/InspectorAgent.h: Ditto.
- inspector/InspectorApplicationCacheAgent.cpp: Ditto.
- inspector/InspectorApplicationCacheAgent.h: Ditto.
- inspector/InspectorBaseAgent.cpp: Ditto.
(WebCore::InspectorBaseAgentInterface::InspectorBaseAgentInterface):
Create InspectorState via InspectorCompositeState::createAgentState(agentName).
- inspector/InspectorBaseAgent.h: Pass InspectorCompositeState rather than InspectorState.
- inspector/InspectorCSSAgent.cpp: Ditto.
- inspector/InspectorCSSAgent.h: Ditto.
- inspector/InspectorCanvasAgent.cpp: Ditto.
- inspector/InspectorCanvasAgent.h: Ditto.
- inspector/InspectorConsoleAgent.cpp: Ditto.
- inspector/InspectorConsoleAgent.h: Ditto.
- inspector/InspectorController.cpp: Use InspectorCompositeState rather than InspectorState.
- inspector/InspectorController.h: Ditto.
- inspector/InspectorDOMAgent.cpp: Pass InspectorCompositeState rather than InspectorState.
(WebCore::InspectorDOMAgent::InspectorDOMAgent): Ditto.
- inspector/InspectorDOMAgent.h: Ditto.
- inspector/InspectorDOMDebuggerAgent.cpp: Ditto.
- inspector/InspectorDOMDebuggerAgent.h: Ditto.
- inspector/InspectorDOMStorageAgent.cpp: Ditto.
- inspector/InspectorDOMStorageAgent.h: Ditto.
- inspector/InspectorDatabaseAgent.cpp: Ditto.
- inspector/InspectorDatabaseAgent.h: Ditto.
- inspector/InspectorDebuggerAgent.cpp: Ditto.
- inspector/InspectorDebuggerAgent.h: Ditto.
- inspector/InspectorFileSystemAgent.cpp: Ditto.
- inspector/InspectorFileSystemAgent.h: Ditto.
- inspector/InspectorIndexedDBAgent.cpp: Ditto.
- inspector/InspectorIndexedDBAgent.h: Ditto.
- inspector/InspectorInputAgent.cpp: Ditto.
- inspector/InspectorInputAgent.h: Ditto.
- inspector/InspectorLayerTreeAgent.cpp: Ditto.
- inspector/InspectorLayerTreeAgent.h: Ditto.
- inspector/InspectorMemoryAgent.cpp: Ditto.
- inspector/InspectorMemoryAgent.h: Ditto.
- inspector/InspectorPageAgent.cpp: Ditto.
- inspector/InspectorPageAgent.h: Ditto.
- inspector/InspectorProfilerAgent.cpp: Ditto.
- inspector/InspectorProfilerAgent.h: Ditto.
- inspector/InspectorResourceAgent.cpp: Ditto.
- inspector/InspectorResourceAgent.h: Ditto.
- inspector/InspectorRuntimeAgent.cpp: Ditto.
- inspector/InspectorRuntimeAgent.h: Ditto.
- inspector/InspectorState.cpp: Introduce InspectorCompositeState, refactor.
(WebCore::InspectorState::updateCookie): Delegates to the owning InspectorCompositeState instance.
(WebCore::InspectorState::setFromCookie): Gets called from InspectorCompositeState::loadFromCookie().
(WebCore::InspectorState::remove): Don't forget to update the cookie.
(WebCore::InspectorCompositeState::createAgentState): Creates an InspectorState instance for a named agent.
(WebCore::InspectorCompositeState::loadFromCookie): Restores InspectorStates from a cookie.
(WebCore::InspectorCompositeState::inspectorStateUpdated): Delegate invoked from InspectorState::updateCookie().
- inspector/InspectorState.h:
(InspectorStateUpdateListener): InspectorCompositeState API exposed to InspectorState.
- inspector/InspectorTimelineAgent.cpp: Pass InspectorCompositeState rather than InspectorState.
- inspector/InspectorTimelineAgent.h: Ditto.
- inspector/InspectorWorkerAgent.cpp: Ditto.
- inspector/InspectorWorkerAgent.h: Ditto.
- inspector/PageConsoleAgent.cpp: Ditto.
- inspector/PageConsoleAgent.h: Ditto.
- inspector/PageDebuggerAgent.cpp: Ditto.
- inspector/PageDebuggerAgent.h: Ditto.
- inspector/PageRuntimeAgent.cpp: Ditto.
- inspector/PageRuntimeAgent.h: Ditto.
- inspector/WorkerConsoleAgent.cpp: Ditto.
- inspector/WorkerConsoleAgent.h: Ditto.
- inspector/WorkerDebuggerAgent.cpp: Ditto.
- inspector/WorkerDebuggerAgent.h: Ditto.
- inspector/WorkerInspectorController.cpp: Ditto.
- inspector/WorkerInspectorController.h: Ditto.
- inspector/WorkerRuntimeAgent.cpp: Ditto.
- inspector/WorkerRuntimeAgent.h: Ditto.
- 12:12 AM Changeset in webkit [138456] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed follow-up for r138455.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Dec 24, 2012:
- 11:53 PM Changeset in webkit [138455] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed compilation fix for r138452.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 11:41 PM Changeset in webkit [138454] by
-
- 7 edits in trunk/Source
Memory instrumentation: provide a way to mark a node as a root
https://bugs.webkit.org/show_bug.cgi?id=105737
Reviewed by Alexander Pavlov.
Source/WebCore:
Extended HeapGraphSerializer to add a fake root node with edges to all
real instrumentation roots.
- inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::addRootNode):
(WebCore):
- inspector/HeapGraphSerializer.h:
(HeapGraphSerializer):
Source/WTF:
Objects added using MemoryInstrumentation::addRootObject will be marked as roots.
- wtf/MemoryInstrumentation.cpp:
(WTF::MemoryInstrumentation::WrapperBase::process):
(WTF):
(WTF::MemoryInstrumentation::WrapperBase::processPointer):
(WTF::MemoryInstrumentation::WrapperBase::processRootObjectRef):
- wtf/MemoryInstrumentation.h:
(WrapperBase):
- wtf/MemoryObjectInfo.h: added root marker which can be used by the heap graph builder.
(WTF::MemoryObjectInfo::MemoryObjectInfo):
(WTF::MemoryObjectInfo::isRoot):
(WTF::MemoryObjectInfo::markAsRoot):
(MemoryObjectInfo):
- 11:26 PM Changeset in webkit [138453] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: add message listener only in case of standalone test-runner.html
https://bugs.webkit.org/show_bug.cgi?id=105715
Reviewed by Pavel Feldman.
Tell InspectorFrontendAPI that it is launched by standalone test runner so that it
can decide whether message event listener should be added.
- inspector/front-end/InspectorFrontendAPI.js:
- inspector/front-end/test-runner.html:
- 11:01 PM Changeset in webkit [138452] by
-
- 10 edits in trunk
Web Inspector: Native Memory Instrumentation: propagate member type as edge type to the serialized heap graph.
https://bugs.webkit.org/show_bug.cgi?id=105725
Reviewed by Yury Semikhatsky.
Source/WebCore:
MemoryOwningType was renamed to MemberType.
Source argument were removed from reportEdge, reportLeaf and other edge related methods because it is not necessary.
MemberType argument was propagated from MemoryInstrumentation down to HeapGraphSerializer.
- inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphEdge::HeapGraphEdge):
(HeapGraphEdge):
(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::reportEdge):
(WebCore::HeapGraphSerializer::reportLeaf):
(WebCore::HeapGraphSerializer::serialize):
- inspector/HeapGraphSerializer.h:
(HeapGraphSerializer):
- inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationClientImpl::reportEdge):
(WebCore::MemoryInstrumentationClientImpl::reportLeaf):
- inspector/MemoryInstrumentationImpl.h:
(MemoryInstrumentationClientImpl):
Source/WTF:
MemoryOwningType was renamed to MemberType.
Source argument were removed from reportEdge, reportLeaf and other edge related methods because it is not necessary.
MemberType argument was propagated from MemoryInstrumentation down to HeapGraphSerializer.
The changes covered by tests in TestWebKitAPI.
- wtf/MemoryInstrumentation.cpp:
(WTF::MemoryInstrumentation::reportEdge):
(WTF::MemoryInstrumentation::reportLinkToBuffer):
(WTF::MemoryClassInfo::addPrivateBuffer):
- wtf/MemoryInstrumentation.h:
(MemoryInstrumentationClient):
(MemoryInstrumentation):
(WTF::MemoryInstrumentation::addRawBuffer):
(WTF::MemoryInstrumentation::MemberTypeTraits::addObject):
(WTF::MemoryInstrumentation::addObjectImpl):
Tools:
MemberType value names were adjusted according to Style Guide.
Existing tests were extended with link type validation.
- TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
- 10:16 PM Changeset in webkit [138451] by
-
- 3 edits2 adds in trunk
::first-letter { overflow: -webkit-paged-y } causes crash
https://bugs.webkit.org/show_bug.cgi?id=105393
Reviewed by Beth Dakin.
Source/WebCore:
Should check whether e is available or not before invoking
e->hasTagName in adjustRenderStyle in StyleResolver.cpp.
Test: fast/css/pseudo-element-opagedxy-crash.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
If adjustRenderStyle is invoked in pseudoStyleForElement, the given
element is 0. So e is not available. However if the given style's
overflowY is OPAGEDX or OPAGEDY, adjustRenderStyle doesn't check
whether e is available or not before e->hasTagName.
This causes a crash.
LayoutTests:
- fast/css/pseudo-element-opagedxy-crash-expected.txt: Added.
- fast/css/pseudo-element-opagedxy-crash.html: Added.
- 9:23 PM Changeset in webkit [138450] by
-
- 7 edits in trunk/Source
Web Inspector: add async API for passing renderer process memory stats
https://bugs.webkit.org/show_bug.cgi?id=105278
Patch by Alexei Filippov <alph@chromium.org> on 2012-12-24
Reviewed by Yury Semikhatsky.
On some platforms (e.g. Linux) it may take some time to collect
total process memory information as it involves an IPC out of a
sandboxed renderer process. So add an async way to collect the statistics.
Source/Platform:
- chromium/public/Platform.h:
(Platform):
(ProcessMemorySizesCallback):
(WebKit::Platform::ProcessMemorySizesCallback::~ProcessMemorySizesCallback):
(WebKit::Platform::requestProcessMemorySizes):
Source/WebCore:
- platform/MemoryUsageSupport.cpp:
(WebCore::MemoryUsageSupport::requestProcessMemorySizes):
(WebCore):
- platform/MemoryUsageSupport.h:
(MemoryUsageSupport):
(ProcessMemorySizesCallback):
(WebCore::MemoryUsageSupport::ProcessMemorySizesCallback::~ProcessMemorySizesCallback):
- platform/chromium/MemoryUsageSupportChromium.cpp:
(WebCore::MemoryUsageSupport::requestProcessMemorySizes):
(WebCore):
- platform/qt/MemoryUsageSupportQt.cpp:
(WebCore::MemoryUsageSupport::requestProcessMemorySizes):
(WebCore):
- 6:17 PM Changeset in webkit [138449] by
-
- 13 edits in trunk/Source
Remove wtf/Platform.h includes from {c|cpp} files
https://bugs.webkit.org/show_bug.cgi?id=105678
Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-12-24
Reviewed by Kentaro Hara.
Remove wtf/Platform.h from the include list as it is already
included in config.h.
Source/JavaScriptCore:
- disassembler/udis86/udis86.c:
- disassembler/udis86/udis86_decode.c:
- disassembler/udis86/udis86_input.c:
- disassembler/udis86/udis86_itab_holder.c:
- disassembler/udis86/udis86_syn-att.c:
- disassembler/udis86/udis86_syn-intel.c:
- disassembler/udis86/udis86_syn.c:
- heap/VTableSpectrum.cpp:
Source/WebCore:
No new tests as there is no new functionality.
- rendering/svg/RenderSVGRect.cpp:
Source/WebKit2:
- Shared/qt/QtNetworkRequestData.cpp:
- 5:17 PM Changeset in webkit [138448] by
-
- 2 edits in trunk/Source/WebCore
Follow up fixes for r137739
https://bugs.webkit.org/show_bug.cgi?id=104982
Reviewed by Ryosuke Niwa.
Applied darin's comments in https://bugs.webkit.org/show_bug.cgi?id=104982#c18
No tests. No change in behavior.
- dom/ContainerNode.h:
(WebCore::ChildNodesLazySnapshot::nextNode):
- 11:37 AM Changeset in webkit [138447] by
-
- 3 edits in trunk/Source/WebCore
Update BB10 media render theme.
https://bugs.webkit.org/show_bug.cgi?id=105728
Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-12-24
Reviewed by Rob Buis.
Internally reviewed by John Griggs.
Use GL renderer to paint media control.
- css/mediaControlsBlackBerry.css:
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):
- 10:28 AM Changeset in webkit [138446] by
-
- 2 edits1 add14 deletes in trunk/LayoutTests
[CSS Regions] Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=80191
Reviewed by Tony Chang.
Convert fast/regions/bottom-overflow-out-of-first-region.html to a ref test.
Used a monospace font, removed text-align and margins for text flowing into regions so that
the text fits nicely in the two regions of the test.
- fast/regions/bottom-overflow-out-of-first-region-expected.html: Added.
- fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
- fast/regions/bottom-overflow-out-of-first-region.html:
- platform/chromium-linux/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
- platform/chromium-mac-lion/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
- platform/chromium-mac/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
- platform/chromium-mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
- platform/chromium-win/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
- platform/chromium-win/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
- platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
- platform/gtk/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
- platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
- platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
- platform/qt/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
- platform/qt/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
- 10:19 AM Changeset in webkit [138445] by
-
- 2 edits in trunk/Source/WebKit2
Assert fix take 2.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):
- 10:12 AM Changeset in webkit [138444] by
-
- 3 edits in trunk/Source/WebKit2
Fix WebKit2 asserting on launch.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
- WebProcess/WebProcess.h:
(WebKit::WebProcess::databaseManager):
(WebProcess):
- 8:45 AM Changeset in webkit [138443] by
-
- 20 edits in trunk/Source/WebCore
Unreviewed, rolling out r138436.
http://trac.webkit.org/changeset/138436
https://bugs.webkit.org/show_bug.cgi?id=105723
Asserts on state restoration in debug builds (Requested by
apavlov on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-24
- inspector/InspectorAgent.cpp:
(InspectorAgentState):
(WebCore::InspectorAgent::enable):
(WebCore::InspectorAgent::disable):
(WebCore::InspectorAgent::evaluateForTestInFrontend):
(WebCore::InspectorAgent::inspect):
- inspector/InspectorApplicationCacheAgent.cpp:
(ApplicationCacheAgentState):
(WebCore::InspectorApplicationCacheAgent::restore):
(WebCore::InspectorApplicationCacheAgent::enable):
- inspector/InspectorCSSAgent.cpp:
(CSSAgentState):
(WebCore::InspectorCSSAgent::restore):
(WebCore::InspectorCSSAgent::enable):
(WebCore::InspectorCSSAgent::disable):
- inspector/InspectorCanvasAgent.cpp:
(CanvasAgentState):
(WebCore::InspectorCanvasAgent::restore):
(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::disable):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorController.h:
(WebCore):
(InspectorController):
- inspector/InspectorDOMStorageAgent.cpp:
(DOMStorageAgentState):
(WebCore::InspectorDOMStorageAgent::restore):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::disable):
- inspector/InspectorDatabaseAgent.cpp:
(DatabaseAgentState):
(WebCore):
(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::disable):
(WebCore::InspectorDatabaseAgent::restore):
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::disable):
- inspector/InspectorFileSystemAgent.cpp:
(FileSystemAgentState):
(WebCore):
(WebCore::InspectorFileSystemAgent::enable):
(WebCore::InspectorFileSystemAgent::disable):
(WebCore::InspectorFileSystemAgent::clearFrontend):
(WebCore::InspectorFileSystemAgent::restore):
- inspector/InspectorIndexedDBAgent.cpp:
(IndexedDBAgentState):
(WebCore):
(WebCore::InspectorIndexedDBAgent::restore):
(WebCore::InspectorIndexedDBAgent::enable):
(WebCore::InspectorIndexedDBAgent::disable):
- inspector/InspectorLayerTreeAgent.cpp:
(LayerTreeAgentState):
(WebCore::InspectorLayerTreeAgent::restore):
(WebCore::InspectorLayerTreeAgent::enable):
(WebCore::InspectorLayerTreeAgent::disable):
- inspector/InspectorPageAgent.cpp:
(PageAgentState):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::webViewResized):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::removeScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::setDeviceMetricsOverride):
(WebCore::InspectorPageAgent::setShowPaintRects):
(WebCore::InspectorPageAgent::setShowFPSCounter):
(WebCore::InspectorPageAgent::setScriptExecutionDisabled):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::applyScreenWidthOverride):
(WebCore::InspectorPageAgent::applyScreenHeightOverride):
(WebCore::InspectorPageAgent::didPaint):
(WebCore::InspectorPageAgent::didLayout):
(WebCore::InspectorPageAgent::setEmulatedMedia):
(WebCore::InspectorPageAgent::applyEmulatedMedia):
- inspector/InspectorResourceAgent.cpp:
(ResourceAgentState):
(WebCore::InspectorResourceAgent::restore):
(WebCore::InspectorResourceAgent::~InspectorResourceAgent):
(WebCore::InspectorResourceAgent::enable):
(WebCore::InspectorResourceAgent::disable):
- inspector/InspectorState.cpp:
(WebCore::InspectorState::InspectorState):
(WebCore::InspectorState::loadFromCookie):
(WebCore):
(WebCore::InspectorState::mute):
(WebCore::InspectorState::unmute):
(WebCore::InspectorState::updateCookie):
(WebCore::InspectorState::remove):
- inspector/InspectorState.h:
(WebCore):
(InspectorState):
(WebCore::InspectorState::setLong):
- inspector/InspectorTimelineAgent.cpp:
(TimelineAgentState):
(WebCore::InspectorTimelineAgent::restore):
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
- inspector/WorkerInspectorController.h:
(WebCore):
(WorkerInspectorController):
- 7:59 AM Changeset in webkit [138442] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Keep LiveEdit API disabled when idle
https://bugs.webkit.org/show_bug.cgi?id=104039
Patch by Peter Rybin <prybin@chromium.org> on 2012-12-24
Reviewed by Pavel Feldman.
Guards are added to LiveEdit call
- bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setScriptSource):
- 6:03 AM Changeset in webkit [138441] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Fix various RenderQueue bugs introduced by r138024.
https://bugs.webkit.org/show_bug.cgi?id=105717
RIM PR 269029
Reviewed by George Staikos.
Scroll/zoom jobs were pretty solid, but I managed to
leave some bugs in the region handling of RenderQueue's
renderRegularRenderJobs() function, causing us to skip
a desired blit or render operation in cases where the
region and tile tracking did not match up.
This commit fixes these errors.
- WebKitSupport/RenderQueue.cpp:
(BlackBerry::WebKit::RenderQueue::renderRegularRenderJobs):
- 4:56 AM Changeset in webkit [138440] by
-
- 2 edits in trunk/Tools
[BlackBerry] DRT - Crashed when running pixels tests
https://bugs.webkit.org/show_bug.cgi?id=105711
RIM PR 270003
Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-12-24
Reviewed by George Staikos.
Calling window->post() here will result in buffer swapping which is
only allowed in UI thread now, and I found we don't need to call it
for GL renderer.
- DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
(createBitmapContextFromWebView):
- 4:37 AM Changeset in webkit [138439] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Close page popup when a page becomes invisible.
https://bugs.webkit.org/show_bug.cgi?id=105704
Reviewed by George Staikos.
Reviewed internally by Jakob Petsovits.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setVisible):
- 3:23 AM Changeset in webkit [138438] by
-
- 6 edits in trunk
Web Inspector: refactor TextEditorHighlighter's highlight attributes to dense array
https://bugs.webkit.org/show_bug.cgi?id=105626
Patch by Andrey Lushnikov <lushnikov@chromium.com> on 2012-12-24
Reviewed by Pavel Feldman.
Source/WebCore:
Refactor highlight attributes from sparse array to dense array.
No new tests: no behaviour changes, coverage provided by existing tests.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._paintLine):
(WebInspector.TextEditorMainPanel.prototype._closingBlockOffset):
- inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter.prototype._highlightLines):
LayoutTests:
Fix tests according to new highlight attribute structure.
- inspector/editor/highlighter-long-line.html:
- inspector/editor/highlighter-test.js:
(initialize_HighlighterTests.InspectorTest.dumpTextModel):
(initialize_HighlighterTests):
- 2:03 AM Changeset in webkit [138437] by
-
- 2 edits in trunk
[EFL [WebGL] GLES2 detection is broken.
https://bugs.webkit.org/show_bug.cgi?id=105677
We use the logic in FindGLES.cmake to detect GLES2 support during compile time.
OPENGLES2_FOUND is never set, even though OPENGLES2_INCLUDE_DIR and OPENGLES2_LIBRARY
contain right information. The name passed to find_package_handle_standard_args seems to be the issue here.
This patch changes the name passed to find_package_handle_standard_args to OPENGLES2.
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-24
Reviewed by Kenneth Rohde Christiansen.
- Source/cmake/FindGLES.cmake:
- 1:07 AM Changeset in webkit [138436] by
-
- 20 edits in trunk/Source/WebCore
Web Inspector: Make use of the new InspectorState::remove() in inspector agents
https://bugs.webkit.org/show_bug.cgi?id=105438
Reviewed by Yury Semikhatsky.
This patch introduces the following refactorings:
- setting property values of InspectorState to "empty" objects has been replaced by removing them from the state;
- InspectorState instance is no longer shared across agents, so that the property names can no longer clash. Instead, InspectorCompositeState creates and owns InspectorState instances for every agent;
- agent-specific prefix has been stripped from most property names, where it looked synthetic.
- updateCookie() is called from InspectorState::remove().
No new tests, as there is no visible change in the behavior.
- inspector/InspectorAgent.cpp: Agent-specific property name prefix stripped.
- inspector/InspectorApplicationCacheAgent.cpp: Ditto.
- inspector/InspectorCSSAgent.cpp: Ditto.
- inspector/InspectorCanvasAgent.cpp: Ditto.
- inspector/InspectorController.cpp: Make use of InspectorCompositeState rather than InspectorState.
- inspector/InspectorController.h: Ditto.
- inspector/InspectorDOMStorageAgent.cpp: Agent-specific property name prefix stripped.
- inspector/InspectorDatabaseAgent.cpp: Ditto.
- inspector/InspectorDebuggerAgent.cpp: Ditto.
(WebCore::InspectorDebuggerAgent::disable):
Use "remove" instead of setting an empty object.
- inspector/InspectorFileSystemAgent.cpp: Agent-specific property name prefix stripped.
- inspector/InspectorIndexedDBAgent.cpp: Ditto.
- inspector/InspectorLayerTreeAgent.cpp: Ditto.
- inspector/InspectorPageAgent.cpp: Ditto.
(WebCore::InspectorPageAgent::disable):
Use "remove" instead of setting empty values for certain properties.
(WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
Remove unnecessary code (object is created and put into the map if none is found).
- inspector/InspectorResourceAgent.cpp: Agent-specific property name prefix stripped.
(WebCore::InspectorResourceAgent::disable):
Use "remove" instead of setting an empty object for userAgentOverride.
- inspector/InspectorState.cpp: Add InspectorCompositeState.
(WebCore::InspectorState::setFromCookie): Gets invoked from InspectorCompositeState::loadFromCookie().
(WebCore::InspectorState::updateCookie): Call updateCookie().
(WebCore::InspectorCompositeState::createAgentState): Creates an InspectorState instance to be passed to an agent.
- inspector/InspectorState.h: Add InspectorCompositeState.
(WebCore::InspectorState::setLong): Fix cast.
- inspector/InspectorTimelineAgent.cpp: Agent-specific property name prefix stripped.
- inspector/WorkerInspectorController.cpp: Make use of InspectorCompositeState rather than InspectorState.
- inspector/WorkerInspectorController.h: Ditto.
- 12:19 AM Changeset in webkit [138435] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][Win] Unreviewed Xmas buildfix after r138433.
- WebProcess/Cookies/WebCookieManager.h:
Dec 23, 2012:
- 10:10 PM Changeset in webkit [138434] by
-
- 3 edits in trunk/Source/WebKit2
Fix the incorrect use of preprocessor statement in API header
https://bugs.webkit.org/show_bug.cgi?id=105675
Patch by Seokju Kwon <Seokju Kwon> on 2012-12-23
Reviewed by Sam Weinig.
Remove a preprocessor statement in WKBundlePage.h
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageGetInspector):
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- 9:45 PM Changeset in webkit [138433] by
-
- 13 edits in trunk/Source/WebKit2
Switch WebCookieManager and AuthenticationManager to use the ChildProcess rather than holding on to a Connection
https://bugs.webkit.org/show_bug.cgi?id=105703
Reviewed by Dan Bernstein.
Also switches WebCookieManager over to be a MessageReceiver while we are at it.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::initialize):
(WebKit::NetworkProcess::didReceiveMessage):
- NetworkProcess/NetworkProcess.h:
(WebKit):
- WebProcess/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::AuthenticationManager):
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
- WebProcess/Authentication/AuthenticationManager.h:
(AuthenticationManager):
- WebProcess/Cookies/WebCookieManager.cpp:
(WebKit):
(WebKit::WebCookieManager::WebCookieManager):
(WebKit::WebCookieManager::didReceiveMessage):
(WebKit::WebCookieManager::getHostnamesWithCookies):
(WebKit::WebCookieManager::cookiesDidChange):
(WebKit::WebCookieManager::dispatchCookiesDidChange):
(WebKit::WebCookieManager::getHTTPCookieAcceptPolicy):
- WebProcess/Cookies/WebCookieManager.h:
(WebKit):
(WebCookieManager):
- WebProcess/Cookies/soup/WebCookieManagerSoup.cpp:
(WebKit::WebCookieManager::setCookiePersistentStorage):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setAlwaysAcceptCookies):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initialize):
(WebKit::WebProcess::didReceiveMessage):
- WebProcess/WebProcess.h:
(WebProcess):
(WebKit::WebProcess::cookieManager):
- 9:05 PM Changeset in webkit [138432] by
-
- 12 edits2 adds in trunk/Source/WebCore
Split fast-rejection filter logic off SelectorChecker.
https://bugs.webkit.org/show_bug.cgi?id=105660
The awesome Bloom filter and parent stack logic don't need to be in SelectorChecker. They nicely factor out
into their own pretty thing, named thereby SelectorFilter.
Reviewed by Eric Seidel.
No change in functionality, covered by existing tests.
- CMakeLists.txt: Added SelectorFilter to build systems.
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- css/CSSAllInOne.cpp: Ditto.
- css/RuleSet.cpp: Changed to use SelectorFilter.
(WebCore::RuleData::RuleData): Ditto.
- css/SelectorChecker.cpp: Ditto.
- css/SelectorChecker.h: Ditto.
(SelectorChecker):
- css/StyleResolver.cpp: Ditto.
(WebCore):
(WebCore::StyleResolver::pushParentElement): Ditto.
(WebCore::StyleResolver::popParentElement): Ditto.
(WebCore::StyleResolver::collectMatchingRulesForList): Ditto.
- css/StyleResolver.h:
(StyleResolver): Ditto.
- 8:43 PM Changeset in webkit [138431] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] give url when createWindow
https://bugs.webkit.org/show_bug.cgi?id=105702
RIM bug# 257329
Reviewed by George Staikos.
This is to revert previous commit 575407238c35f1a0fa7ff7dd5dbbf6cc3ece1107
for integration issue of cascade and air, as old app side still use the url
to invoke. It would unrevert after resolving the integration issue.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
- 8:38 PM Changeset in webkit [138430] by
-
- 2 edits in trunk/Source/WebCore
Remove unused reference to "class LayerChromium"
https://bugs.webkit.org/show_bug.cgi?id=105502
Patch by Qiankun Miao <qiankun.miao@intel.com> on 2012-12-23
Reviewed by Kentaro Hara.
class LayerChromium doesn't exist any more. Just remove the unused
code.
- platform/graphics/chromium/Canvas2DLayerBridge.h:
- 6:57 PM Changeset in webkit [138429] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the Qt build.
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
- 6:34 PM Changeset in webkit [138428] by
-
- 11 edits in trunk/Source/WebKit2
Remove more special cased message receiving code from WebProcess
https://bugs.webkit.org/show_bug.cgi?id=105700
Reviewed by Dan Bernstein.
Makes WebApplicationCacheManager, WebResourceCacheManager and WebDatabaseManager
CoreIPC::MessageReceivers, removes them as special cases in WebProcess.
- WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
(WebKit::WebApplicationCacheManager::WebApplicationCacheManager):
(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManager::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManager::deleteAllEntries):
(WebKit::WebApplicationCacheManager::setAppCacheMaximumSize):
- WebProcess/ApplicationCache/WebApplicationCacheManager.h:
(WebKit):
(WebApplicationCacheManager):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::clearAllDatabases):
(WebKit::InjectedBundle::setDatabaseQuota):
(WebKit::InjectedBundle::clearApplicationCache):
(WebKit::InjectedBundle::setAppCacheMaximumSize):
- WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::WebResourceCacheManager):
(WebKit::WebResourceCacheManager::getCacheOrigins):
(WebKit::WebResourceCacheManager::clearCacheForOrigin):
(WebKit::WebResourceCacheManager::clearCacheForAllOrigins):
- WebProcess/ResourceCache/WebResourceCacheManager.h:
(WebKit):
(WebResourceCacheManager):
- WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit):
(WebKit::WebDatabaseManager::WebDatabaseManager):
(WebKit::WebDatabaseManager::getDatabasesByOrigin):
(WebKit::WebDatabaseManager::getDatabaseOrigins):
(WebKit::WebDatabaseManager::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManager::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManager::deleteAllDatabases):
(WebKit::WebDatabaseManager::setQuotaForOrigin):
(WebKit::WebDatabaseManager::dispatchDidModifyOrigin):
(WebKit::WebDatabaseManager::dispatchDidModifyDatabase):
- WebProcess/WebCoreSupport/WebDatabaseManager.h:
(WebKit):
(WebDatabaseManager):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::didReceiveMessage):
- WebProcess/WebProcess.h:
(WebProcess):
(WebKit::WebProcess::applicationCacheManager):
(WebKit::WebProcess::resourceCacheManager):
(WebKit::WebProcess::databaseManager):
- 5:29 PM Changeset in webkit [138427] by
-
- 39 edits in trunk/Source
<rdar://problem/12808377> Network process should respect cookie accept policy
https://bugs.webkit.org/show_bug.cgi?id=105684
Reviewed by Sam Weinig.
Source/WebCore:
Changed cookie change observer to not use platform strategies, to make it usable
in NetworkProcess. startObservingCookieChanges() now just takes a callback pointer.
- WebCore.exp.in:
- platform/CookiesStrategy.h:
- platform/network/CookieStorage.h:
- platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::notifyCookiesChangedOnMainThread):
(WebCore::startObservingCookieChanges):
- platform/network/mac/CookieStorageMac.mm:
(-[WebCookieStorageObjCAdapter notifyCookiesChangedOnMainThread]):
(-[WebCookieStorageObjCAdapter startListeningForCookieChangeNotificationsWithCallback:]):
(WebCore::startObservingCookieChanges):
Source/WebKit/efl:
- WebCoreSupport/PlatformStrategiesEfl.cpp:
- WebCoreSupport/PlatformStrategiesEfl.h:
CookiesStrategy no longer has notifyCookiesChanged(). This port didn't use it anyway.
Source/WebKit/gtk:
- WebCoreSupport/PlatformStrategiesGtk.cpp:
- WebCoreSupport/PlatformStrategiesGtk.h:
CookiesStrategy no longer has notifyCookiesChanged(). This port didn't use it anyway.
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
CookiesStrategy no longer has notifyCookiesChanged().
Source/WebKit/qt:
- WebCoreSupport/PlatformStrategiesQt.cpp:
- WebCoreSupport/PlatformStrategiesQt.h:
CookiesStrategy no longer has notifyCookiesChanged(). This port didn't use it anyway.
Source/WebKit/win:
- WebCoreSupport/WebPlatformStrategies.cpp:
- WebCoreSupport/WebPlatformStrategies.h:
CookiesStrategy no longer has notifyCookiesChanged(). This port didn't use it anyway.
Source/WebKit/wince:
- WebCoreSupport/PlatformStrategiesWinCE.cpp:
- WebCoreSupport/PlatformStrategiesWinCE.h:
CookiesStrategy no longer has notifyCookiesChanged(). This port didn't use it anyway.
Source/WebKit2:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initialize): Tell cookie manager which connection to
make calls on. Now that the code can run in either WebProcess or NetworkProcess,
it cannot use WebProcess singleton.
(WebKit::NetworkProcess::didReceiveMessage): Dispatch WebCookieManager messages.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initialize): Tell cookie manager which connection to
make calls on.
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didReceiveAuthenticationChallenge): Changed to use
WebContext::networkingProcessConnection() instead of deciding upon the connection here.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didReceiveMessage): Call m_webContext->dispatchMessage),
as WebCookieManagerProxy handlers are registered on the context. This may seem wasteful,
but a lot of registered managers will need the ame handling soon.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::networkingProcessConnection): Added a way to get connection
to whichever process performs networking.
(WebKit::WebContext::removeNetworkProcessProxy): Invalidate cookie manager proxy,
so that expected responses could be cleared.
(WebKit::WebContext::disconnectProcess): Updated a FIXME.
- UIProcess/WebContext.h: Deleted deprecatedSharedProcess().
(WebKit::WebContext::networkingProcessConnection): Added.
(WebKit::WebContext::sendToNetworkingProcess): Added.
(WebKit::WebContext::sendToNetworkingProcessRelaunchingIfNecessary): Added.
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::shouldTerminate): Should not prevent WebProcess
termination when NetworkProcess is in use.
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies): Removed a useless ASSERT
that neiter documents expectations nor helps find bugs. Send a message to correct
process, whether WebProcess or NetworkProcess.
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname): Ditto.
(WebKit::WebCookieManagerProxy::deleteAllCookies): Ditto.
(WebKit::WebCookieManagerProxy::startObservingCookieChanges): Ditto.
(WebKit::WebCookieManagerProxy::stopObservingCookieChanges): Ditto.
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy): Ditto.
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy): Ditto.
- WebProcess/Cookies/WebCookieManager.h:
- WebProcess/Cookies/WebCookieManager.cpp: Made the class usable in either WebProcess
or NetworkProcess.
(WebKit::WebCookieManager::setConnection): WebCookieManager now remembers which
connection to talk back on.
(WebKit::WebCookieManager::didReceiveMessage): Added an assertion that stored connection
matches the one being used to reciev messages.
(WebKit::WebCookieManager::getHostnamesWithCookies): Use the stored connection to
send a reply.
(WebKit::WebCookieManager::startObservingCookieChanges): Pass a callback function,
so that WebCore doesn't have to use a platform strategy.
(WebKit::WebCookieManager::cookiesDidChange): The new callback.
(WebKit::WebCookieManager::dispatchCookiesDidChange): Use the stored connection.
(WebKit::WebCookieManager::getHTTPCookieAcceptPolicy): Use the stored connection.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
Removed notifyCookiesChanged() which is no longer part of CookiesStrategy.
- 1:03 PM Changeset in webkit [138426] by
-
- 10 edits in trunk/Source/WebKit2
Make CustomProtocolManager a MessageReceiver to remove more special casing
https://bugs.webkit.org/show_bug.cgi?id=105682
Reviewed by Dan Bernstein.
To avoid storing a Connection in CustomProtocolManager, which is not a great idea without
it being the Connection::Client and therefore getting death notifications, I also made
ChildProcess a MessageSender so that extensions to it, like CustomProtocolManager, can
easily send messages to the parent process.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
Initialize the shared CustomProtocolManager, which will add it to the MessageReceiverMap in
the ChildProcess.
(WebKit::NetworkProcess::didReceiveMessage):
Remove the special case for CustomProtocolManager.
(WebKit::NetworkProcess::initializeNetworkProcess):
Call connectionEstablished on the CustomProtocolManager to make it start working as a NSURLProtocol handler.
- NetworkProcess/NetworkProcess.h:
Add overrides necessary for MessageSender.
- PluginProcess/PluginProcess.h:
Ditto.
- Shared/ChildProcess.h:
(ChildProcess):
Make ChildProcess a MessageSender.
- Shared/Network/CustomProtocols/CustomProtocolManager.h:
(CustomProtocolManager):
(WebKit::CustomProtocolManager::childProcess):
- Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
(-[WKCustomProtocol startLoading]):
(-[WKCustomProtocol stopLoading]):
(WebKit::CustomProtocolManager::CustomProtocolManager):
(WebKit::CustomProtocolManager::initialize):
(WebKit::CustomProtocolManager::connectionEstablished):
Make CustomProtocolManager a MessageReceiver and split initialization and the time when it can
start acting as protocol handler as these happen at different times now. It also now stores a
ChildProcess rather than a Connection.
- SharedWorkerProcess/SharedWorkerProcess.h:
Add overrides necessary for MessageSender.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
Initialize the shared CustomProtocolManager, which will add it to the MessageReceiverMap in
the ChildProcess.
(WebKit::WebProcess::didReceiveMessage):
Remove the special case for CustomProtocolManager.
(WebKit::WebProcess::initializeCustomProtocolManager):
Call connectionEstablished on the CustomProtocolManager to make it start working as a NSURLProtocol handler.
- WebProcess/WebProcess.h:
Add overrides necessary for MessageSender.
- 12:22 PM Changeset in webkit [138425] by
-
- 5 edits in trunk
[GTK] Remove plugin process configuration option
https://bugs.webkit.org/show_bug.cgi?id=105564
Reviewed by Carlos Garcia Campos.
Remove the --enable-plugin-process configuration option, opting instead to
always build the plugin process when building WebKit2. It isn't very interesting
for downstream to enable or disable the plugin process. It should always be
enabled for WebKit2 and it's better for us not to have to keep a disabled plugin
process building. Additionally, the in-process plugin isn't functional, since
plugins depend on GTK+ 2 and WebKit2 depends on GTK+ 3.
.:
- configure.ac: Remove the configuration option.
Source/WebKit2:
- GNUmakefile.am: Remove the option.
- GNUmakefile.list.am: Remote the option.
- 9:52 AM Changeset in webkit [138424] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Specify tile usage enum for backingstore tiles.
https://bugs.webkit.org/show_bug.cgi?id=105688
RIM PR 262120
Reviewed by George Staikos.
This enables us to have separate tile sizes for
backingstore / root layer purposes and generic layers.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::tileSize):
- 9:35 AM Changeset in webkit [138423] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding crashing expectations for two tests that constantly crash
in debug builds.
- platform/gtk/TestExpectations:
- 9:28 AM Changeset in webkit [138422] by
-
- 4 edits1 add in trunk
Add a patch to fix libxml2 2.9.0 regression
https://bugs.webkit.org/show_bug.cgi?id=104494
Reviewed by Martin Robinson.
- gtk/jhbuild.modules:
- gtk/patches/libxml2-2.9.0-dtd.patch: patch from upstream
Unskip tests that were failing in libxml 2.9.0
https://bugs.webkit.org/show_bug.cgi?id=104494
Reviewed by Martin Robinson.
Added a patch from upstream to the jhbuild config to make all but
one of these pass again; the remaining one fails for a different
reason and is being tracked in a different bug.
- platform/gtk/TestExpectations:
- 9:04 AM Changeset in webkit [138421] by
-
- 2 edits in trunk/Source/WebCore
[Qt][Mac] Unreviewed fix the build after r138413
https://bugs.webkit.org/show_bug.cgi?id=105686
Don't use a temporary const reference so the compiler doesn't make a copy.
An example compile error (clang):
Source/WebCore/loader/CookieJar.cpp:73:67: error: copying parameter of type 'WebCore::NetworkStorageSession' invokes deleted constructor
return platformStrategies()->cookiesStrategy()->cookiesForDOM(SESSION(document), document->firstPartyForCookies(), url);
- loader/CookieJar.cpp:
(WebCore::cookies):
(WebCore::setCookies):
(WebCore::cookiesEnabled):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
- 6:59 AM Changeset in webkit [138420] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening
Rebaseline fast/js/global-constructors.html after
r138393.
- platform/efl/fast/js/global-constructors-expected.txt:
- 6:13 AM Changeset in webkit [138419] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed Xmas gardening after r138395.
- platform/qt-5.0/fast/js/global-constructors-expected.txt:
- 5:16 AM Changeset in webkit [138418] by
-
- 2 edits in trunk/Tools
Unreviewed update of status to reviewer.
- Scripts/webkitpy/common/config/committers.py:
- 1:28 AM Changeset in webkit [138417] by
-
- 7 edits in branches/chromium/1312
Merge 138365
Fix typing zero into multiple field input
https://bugs.webkit.org/show_bug.cgi?id=105501
Reviewed by Kent Tamura.
Source/WebCore:
We have a couple of problems when handling zero in a multiple fields
element.
- Typing '02' into a month field will set '12'.
- Typing '0' into 12 hour hour field will set '12' and move to the focus to the next field.
This change adds a type ahead buffer so we can handle these cases
properly. If the value in the type ahead buffer is valid we set it so a
change event will fire.
Added tests to *-multiple-fields-keyboard-events.html.
- html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::didBlur): Clear the type ahead
buffer. handleKeyboardEvent() won't set the type ahead value if it is
not in range, so we set the value here.
(WebCore::DateTimeNumericFieldElement::handleKeyboardEvent):
(WebCore::DateTimeNumericFieldElement::setEmptyValue): Clear type ahead buffer.
(WebCore::DateTimeNumericFieldElement::setValueAsInteger):
(WebCore::DateTimeNumericFieldElement::stepDown): Clear type ahead buffer.
(WebCore::DateTimeNumericFieldElement::stepUp): Clear type ahead buffer.
(WebCore::DateTimeNumericFieldElement::typeAheadValue): Returns integer
value for the type ahead characters.
(WebCore):
(WebCore::DateTimeNumericFieldElement::visibleValue): If we have type
ahead characters, show that.
- html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement):
LayoutTests:
- fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt:
- fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html:
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt:
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html:
- fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:
- fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events-expected.txt:
- fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events.html:
TBR=keishi@webkit.org
BUG=crbug.com/167020
Review URL: https://codereview.chromium.org/11665021
- 12:53 AM Changeset in webkit [138416] by
-
- 2 edits in trunk/Tools
[GTK][jhbuild] Bump GStreamer to 1.0.4
https://bugs.webkit.org/show_bug.cgi?id=105640
Reviewed by Martin Robinson.
- gtk/jhbuild.modules: Update GStreamer modules to 1.0.4.
Dec 22, 2012:
- 8:44 PM EFLWebKitTests edited by
- (diff)
- 6:36 PM Changeset in webkit [138415] by
-
- 9 edits in trunk/Source/WebKit2
Give the ChildProcess a MessageReceiverMap
https://bugs.webkit.org/show_bug.cgi?id=105681
Reviewed by Dan Bernstein.
Moving the MessageReceiverMap to the ChildProcess will help shared code
between the WebProcess and NetworkProcess.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
Pass 'this' instead of the MessageReceiverMap, now that ChildProcess
can be used to access the MessageReceiverMap.
- NetworkProcess/NetworkProcess.h:
(NetworkProcess):
Remove the now extraneous MessageReceiverMap.
- Shared/ChildProcess.cpp:
(WebKit::ChildProcess::ChildProcess):
(WebKit):
(WebKit::ChildProcess::~ChildProcess):
(WebKit::ChildProcess::addMessageReceiver):
(WebKit::ChildProcess::removeMessageReceiver):
- Shared/ChildProcess.h:
(ChildProcess):
Add a MessageReceiverMap and helper functions from WebProcess.
- WebProcess/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::AuthenticationManager):
- WebProcess/Authentication/AuthenticationManager.h:
(AuthenticationManager):
Fix the FIXME, passing the ChildProcess rather than the MessageReceiverMap.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
- WebProcess/WebProcess.h:
(WebProcess):
Remove the MessageReceiverMap and helper functions.
- 6:19 PM Changeset in webkit [138414] by
-
- 2 edits in trunk/Source/WebKit2
Windows build fix.
- WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp:
- 6:15 PM Changeset in webkit [138413] by
-
- 90 edits3 adds2 deletes in trunk/Source
Add a separate class for networking related storage
https://bugs.webkit.org/show_bug.cgi?id=105676
Reviewed by Sam Weinig.
NetworkingContext combines a reference to storage (cookies and more) and data that's
only meaningful when loading. This makes it very ugly to use for cookie manipulation
when there is no load (e.g. for document.cookie).
Adding NetworkStorageSession, which encorportes network-related sesion data, such
as cookies and session HTTP credentials.
For some ports, refactoring is not finished, NetworkStorageSession being a wrapper
for NetworkingContext.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj: Updated for new files and functions.
- platform/network/PlatformCookieJar.h:
- loader/CookieJar.cpp:
- platform/CookiesStrategy.h:
- platform/network/cf/CookieJarCFNet.cpp:
- platform/network/chromium/CookieJarChromium.cpp:
- platform/network/curl/CookieJarCurl.cpp:
- platform/network/mac/CookieJarMac.mm:
- platform/network/qt/CookieJarQt.cpp:
- platform/network/soup/CookieJarSoup.cpp:
- platform/network/win/CookieJarWin.cpp: PlatformCookieJar and strategy cookie functions now take a NetworkStorageSession instead of NetworkingContext. Note that they take a const reference to support creating a temporary session wrapper for ports that just wrap a NetworkingContext.
- loader/ResourceLoader.cpp:
- loader/cache/CachedResource.h:
- platform/network/BlobResourceHandle.cpp:
- platform/network/ResourceHandle.cpp:
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
- platform/network/chromium/ResourceHandle.cpp:
- platform/network/curl/ResourceHandleCurl.cpp:
- platform/network/mac/ResourceHandleMac.mm:
- platform/network/qt/QNetworkReplyHandler.cpp:
- platform/network/soup/DNSSoup.cpp:
- platform/network/soup/ResourceHandleSoup.cpp:
- platform/network/win/ResourceHandleWin.cpp: ResourceHandle no longer includes unneeded NetworkingContext.h and AuthenticationClient.h. This avoids near-world rebuilds on any NetworkingContext change.
- platform/network/NetworkStorageSession.h: Added.
- platform/network/NetworkStorageSessionStub.cpp: Added.
- platform/network/cf/NetworkStorageSessionCFNet.cpp: Added. Good new stuff. Stub version just wraps NetworkingContext for platforms that still need to finish the refactoring.
- platform/network/NetworkingContext.h: The context now has a NetworkStorageSession, and doesn't expose CFNet level objects directly.
- platform/network/cf/CookieStorageCFNet.cpp:
- platform/network/cf/CookieStorageCFNet.h: Removed. We no longer have separate free functions to track storage, it's part of NetworkStorageSession now.
- platform/network/cf/ResourceHandleCFNet.cpp: Updated to use NetworkStorageSession.
- platform/network/mac/CookieStorageMac.mm: Dont include CookieStorageCFNet.h, it was not needed.
- 3:14 PM Changeset in webkit [138412] by
-
- 2 edits in trunk/Source/WebCore
InlineTextBox: Remove potentially confusing "} if" pattern.
https://bugs.webkit.org/show_bug.cgi?id=105499
Reviewed by Ojan Vafai.
It's not clear to me on first look if this is intentional or missing
an "else" (and this pattern was used in just one other place in
webkit, which I've removed). It turns out no else is missing here,
this is checked by fast/text/justified-selection.html
- rendering/InlineTextBox.cpp:
(WebCore::paintTextWithShadows):
- 2:35 PM FeatureFlags edited by
- Remove COMMANDLINE_TYPEDARRAYS from the list - see r114575 (diff)
- 2:28 PM FeatureFlags edited by
- Remove JIT_USE_SOFT_MODULO from the list - see r111481 (diff)
- 1:53 PM FeatureFlags edited by
- Remove CLASSIC_INTERPRETER and COMPUTED_GOTO_CLASSIC_INTERPRETER from … (diff)
- 1:07 PM FeatureFlags edited by
- Remove ARM_NEON_INTRINSICS from the list as it is not an ENABLE flag - … (diff)
- 12:54 PM FeatureFlags edited by
- Remove RUN_TIME_HEURISTICS from the list - see r131089 (diff)
- 12:38 PM FeatureFlags edited by
- Remove SKIA_GPU_CANVAS from the list - see r97570 (diff)
- 12:28 PM FeatureFlags edited by
- Remove MAC_JAVA_BRIDGE from the list - see r129964 (diff)
- 12:20 PM FeatureFlags edited by
- Remove CSS3_FLEXBOX from the list - see r100198 (diff)
- 12:15 PM FeatureFlags edited by
- Fix typo - DRAGGBALE -> DRAGGABLE (diff)
- 12:11 PM FeatureFlags edited by
- Remove DATABASE from the list - see r95271 (diff)
- 12:00 AM Changeset in webkit [138411] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaselining the global constructors test after r138393.
Adjusting and merging expectations as required.
- platform/gtk/TestExpectations:
- platform/gtk/fast/js/global-constructors-expected.txt:
Dec 21, 2012:
- 11:34 PM Changeset in webkit [138410] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: Update CodeMirror to stable
https://bugs.webkit.org/show_bug.cgi?id=105653
Patch by Jan Keromnes <janx@linux.com> on 2012-12-21
Reviewed by Pavel Feldman.
Fixes several minor issues, including throw scroll on mac.
- inspector/front-end/cm/codemirror.css:
(.cm-negative):
(.cm-positive):
(.CodeMirror-gutter):
(.cm-searching):
- inspector/front-end/cm/codemirror.js:
(window.CodeMirror):
(window.CodeMirror.):
- inspector/front-end/cm/css.js:
(.):
- inspector/front-end/cm/htmlmixed.js:
(.):
- inspector/front-end/cm/javascript.js:
(.):
- inspector/front-end/cm/xml.js:
- 10:16 PM Changeset in webkit [138409] by
-
- 2 edits in trunk/Source/WTF
Unreviewed. Another try to fix Apple Win Release build.
- wtf/FastMalloc.cpp:
(WTF::ClassIndex):
- 10:06 PM Changeset in webkit [138408] by
-
- 2 edits in trunk/Source/WTF
Unreviewed compilation fix for Apple Win Release after r138398.
- wtf/FastMalloc.cpp:
(WTF::ClassIndex):
- 9:40 PM Changeset in webkit [138407] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Remove Crash expectation from media/track tests after r138381.
- platform/chromium/TestExpectations:
- 6:12 PM Changeset in webkit [138406] by
-
- 2 edits in trunk/Tools
chromium: webkit-build-directory doesn't handle ninja output dirs
https://bugs.webkit.org/show_bug.cgi?id=105671
Reviewed by Daniel Bates.
Teach webkit-build-directory to detect the ninja build directory.
- Scripts/webkitdirs.pm:
(determineBaseProductDir):
(determineIsChromiumNinja):
- 5:06 PM Changeset in webkit [138405] by
-
- 7 edits in trunk
[Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing
https://bugs.webkit.org/show_bug.cgi?id=95477
Reviewed by Sam Weinig.
Tools:
Co-authored by Jia Pu.
Specify a fixed autocorrection dictionary in resetDefaultsToConsistentValues() so that
we can have consistent autocorrection behavior when running tests.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
- WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):
LayoutTests:
Use "notationl" -> "notational" auto correction in autocorrection-blockquote-crash.html to get reliable results.
Also add a failing expectation to removing-underline-after-accepting-autocorrection-using-punctuation.html for WebKit2.
This failure is tracked by the bug 105616.
- platform/mac-wk2/TestExpectations:
- platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
- platform/mac/editing/spelling/autocorrection-blockquote-crash.html:
- 4:24 PM Changeset in webkit [138404] by
-
- 12 edits in trunk
Replace documentFragmentIsShadowRoot with isTreeScope
https://bugs.webkit.org/show_bug.cgi?id=105345
Reviewed by Dimitri Glazkov.
.:
Expose isTreeScope symbol.
- Source/autotools/symbols.filter:
Source/WebCore:
We can replace documentFragmentIsShadowRoot with isTreeScope() which is
trival to detect by checking treeScope()->rootNode() == this. To do this
we must stop adopting ShadowRoots into the document when they're removed,
which was always wrong anyway as it meant that the TreeScope of a ShadowRoot
was no longer itself after it had been removed. It also meant that the
children of a ShadowRoot that was removed were no longer in it's tree scope
despite being descendants of it.
Making this simplification allows further simplication like
Node::containingShadowRoot can be made O(1) instead of O(k) where k is
the depth of the node.
No new tests, just refactoring.
- WebCore.exp.in:
- dom/DocumentFragment.h:
(DocumentFragment):
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::removeAllShadowRoots):
- dom/Node.cpp:
(WebCore::Node::setTreeScope):
(WebCore::Node::isTreeScope):
(WebCore):
- dom/Node.h:
(Node):
(WebCore::Node::isShadowRoot):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::~ShadowRoot):
- dom/ShadowRoot.h:
(ShadowRoot):
Source/WebKit2:
Expose isTreeScope symbol.
- win/WebKit2.def.in:
- 4:22 PM Changeset in webkit [138403] by
-
- 10 edits in trunk/Source
Unreviewed, rolling out r138331.
http://trac.webkit.org/changeset/138331
https://bugs.webkit.org/show_bug.cgi?id=105668
Broke Windows clean builds; can't figure out how to fix it
(Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-21
Source/WebKit/win:
- WebKit.vcproj/WebKit.sln:
- WebKit.vcproj/WebKit.vcproj:
- WebKit.vcproj/WebKitLibCommon.vsprops:
- WebKit.vcproj/WebKitLibDebug.vsprops:
- WebKit.vcproj/WebKitLibDebugAll.vsprops:
- WebKit.vcproj/WebKitLibProduction.vsprops:
- WebKit.vcproj/WebKitLibRelease.vsprops:
Source/WebKit2:
- win/WebKit2.def.in:
- 3:48 PM Changeset in webkit [138402] by
-
- 2 edits in trunk/LayoutTests
[Chromium] IndexedDB: storage/indexeddb/intversion-close-between-events.html flaky in content_shell
https://bugs.webkit.org/show_bug.cgi?id=105665
Test uses a setTimeout() which may fire at different times relative to the completion of the
IDBOpenDBRequest in multiprocess ports. Make the test resilient against different outcomes.
Reviewed by Tony Chang.
- storage/indexeddb/resources/intversion-close-between-events.js:
(deleteSuccess):
(openSuccessOrError):
(checkFinished):
- 3:27 PM Changeset in webkit [138401] by
-
- 4 edits in trunk/Source
[Chromium-Android] Use harfbuzz-ng instead of harfbuzz-old on Android
https://bugs.webkit.org/show_bug.cgi?id=104410
Source/WebCore:
Using harfbuzz-ng we can avoid many bugs of the obsolete harfbuzz-old.
Reviewed by Eric Seidel.
No new tests. No change of functionality. Existing tests should pass.
- WebCore.gyp/WebCore.gyp: Use harfbuzz-ng on Android.
Source/WebKit/chromium:
Reviewed by Eric Seidel.
- features.gypi: Enable harfbuzz-ng on Android.
- 3:26 PM Changeset in webkit [138400] by
-
- 7 edits3 adds in trunk
IndexedDB: Combine openConnection and openConnectionWithVersion
https://bugs.webkit.org/show_bug.cgi?id=105658
Reviewed by Tony Chang.
Source/WebCore:
Combine the logic from these two methods. Mostly a refactor, but in the "pending calls"
case the behavior is slightly altered since the version and no-version queues were
previously separate, so the order changes. The new order matches the spec and FF/IE
behavior, and a test is added to verify this.
Chromium's webkit_unit_tests rely on a quirk to bypass the upgrade mechanism; the usage
is slightly altered and made more explicit, and requires a small amount of test-only code.
Test: storage/indexeddb/open-ordering.html
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::PendingOpenCall):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndAbortFired):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendImpl::close):
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
- Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open):
Source/WebKit/chromium:
- tests/IDBDatabaseBackendTest.cpp:
LayoutTests:
- storage/indexeddb/open-ordering-expected.txt: Added.
- storage/indexeddb/open-ordering.html: Added.
- storage/indexeddb/resources/open-ordering.js: Added.
(runTest):
(onDeleteSuccess):
(onRequest1Success):
(onRequest2Success):
(onRequest3Success):
(checkOrder):
- 2:34 PM Changeset in webkit [138399] by
-
- 7 edits3 adds in trunk/Source/JavaScriptCore
DFG Arrayify slow path should be out-of-line
https://bugs.webkit.org/show_bug.cgi?id=105400
Reviewed by Gavin Barraclough.
The interesting bit of this change is allowing out-of-line slow path generators
to emit speculation checks. This is accomplished by having a version of
speculationCheck() that returns a jump placeholder instead of taking a jump (or
jump list) as an argument. You can then fill in that jump placeholder at a
later time, so long as you do it before OSR exit linking. Slow path generators
run before linking, so that just naturally ends up working.
This isn't really a big win, but we know that out-of-lining slow paths is
generally a good thing to do, so it's fair to assume that this is a move in the
right direction.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGArrayifySlowPathGenerator.h: Added.
(DFG):
(ArrayifySlowPathGenerator):
(JSC::DFG::ArrayifySlowPathGenerator::ArrayifySlowPathGenerator):
(JSC::DFG::ArrayifySlowPathGenerator::generateInternal):
- dfg/DFGOSRExitJumpPlaceholder.cpp: Added.
(DFG):
(JSC::DFG::OSRExitJumpPlaceholder::fill):
- dfg/DFGOSRExitJumpPlaceholder.h: Added.
(DFG):
(OSRExitJumpPlaceholder):
(JSC::DFG::OSRExitJumpPlaceholder::OSRExitJumpPlaceholder):
(JSC::DFG::OSRExitJumpPlaceholder::operator!):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::speculationCheck):
(DFG):
(JSC::DFG::SpeculativeJIT::arrayify):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- 2:22 PM Changeset in webkit [138398] by
-
- 2 edits in trunk/Source/WTF
Further harden FastMalloc
https://bugs.webkit.org/show_bug.cgi?id=105656
Reviewed by Gavin Barraclough.
This increases the degree to which we harden the FastMalloc
linked lists. We now also mask the previous and next pointers
in the doubly linked list implementation. I've also made
the masking itself somewhat more complex without a measurable
cost. We still use ASLR to provide some general entropy, but
we blind the pointers against each nodes 'this' pointer.
- wtf/FastMalloc.cpp:
(WTF::ClassIndex):
(WTF::SLL_Next):
(WTF::SLL_SetNext):
(WTF::Span::next):
(WTF::Span::prev):
(WTF::Span::setNext):
(WTF::Span::setPrev):
(Span):
As Span now has to do masking on the next and previous pointers,
I've updated the code to use accessors instead.
(WTF::DLL_Init):
(WTF::DLL_Remove):
(WTF::DLL_IsEmpty):
(WTF::DLL_Length):
(WTF::DLL_Prepend):
(WTF::TCMalloc_Central_FreeList::enumerateFreeObjects):
(WTF::TCMalloc_PageHeap::scavenge):
(WTF::TCMalloc_PageHeap::New):
(WTF::TCMalloc_PageHeap::AllocLarge):
(WTF::TCMalloc_PageHeap::ReturnedBytes):
(WTF::TCMalloc_PageHeap::Check):
(WTF::TCMalloc_PageHeap::CheckList):
(WTF::TCMalloc_PageHeap::ReleaseFreeList):
(WTF::TCMalloc_Central_FreeList::FetchFromSpans):
- 2:17 PM Changeset in webkit [138397] by
-
- 3 edits in trunk/Source/WebKit2
ASSERT in WebResourceLoadScheduler::scheduleLoad with a crashed NetworkProcess.
<rdar://problem/12924845> and https://bugs.webkit.org/show_bug.cgi?id=105646
Reviewed by Alexey Proskuryakov.
If we fail to schedule a loader with the NetworkProcess it is probably because the NetworkProcess crashed.
Since these loaders will never succeed in loading we should schedule them to fail on a timer.
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::WebResourceLoadScheduler):
(WebKit::WebResourceLoadScheduler::scheduleLoad):
(WebKit::WebResourceLoadScheduler::addUnschedulableLoad):
(WebKit::WebResourceLoadScheduler::unscheduledLoadTimerFired):
(WebKit::WebResourceLoadScheduler::remove):
- WebProcess/Network/WebResourceLoadScheduler.h:
- 1:00 PM Changeset in webkit [138396] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Removing CRASH expectations for media layout tests
broken by http://crbug.com/162917.
https://bugs.webkit.org/show_bug.cgi?id=103093
- platform/chromium/TestExpectations:
- 12:58 PM Changeset in webkit [138395] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed potential fix EFL/Qt test breakage on WK2
Only disable scrollbars when in fixed layout mode.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
- 11:48 AM Changeset in webkit [138394] by
-
- 2 edits in trunk/Source/WebCore
Update localizable strings as a followup to http://trac.webkit.org/changeset/138387
https://bugs.webkit.org/show_bug.cgi?id=105592
Rubberstamped by Alexey Proskuryakov.
- English.lproj/Localizable.strings: Added a new error string.
- 11:38 AM Changeset in webkit [138393] by
-
- 6 edits in trunk
Expose ArrayBufferView constructor on DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=105605
Reviewed by Sam Weinig.
Source/WebCore:
Update IDL to track recent spec change exposing ArrayBufferView
constructor on DOMWindow for instanceof checks. There are no
constructors exposed in the Web IDL, however, so calling it via
operator new throws TypeError.
Test (updated): fast/canvas/webgl/array-unit-tests.html
- html/canvas/ArrayBufferView.idl:
Removed OmitConstructor attribute.
- page/DOMWindow.idl:
Exposed ArrayBufferView constructor function attribute.
LayoutTests:
Updated test from Khronos repository.
- fast/canvas/webgl/array-unit-tests-expected.txt:
- fast/canvas/webgl/array-unit-tests.html:
- 11:27 AM Changeset in webkit [138392] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening, unskip now passing tests.
- platform/qt-5.0-wk2/TestExpectations:
- 11:14 AM Changeset in webkit [138391] by
-
- 7 edits in trunk/Source
Remove ResourceLoadScheduler::addMainResourceLoad and all related code
<rdar://problem/12925275> and https://bugs.webkit.org/show_bug.cgi?id=105644
Reviewed by Alexey Proskuryakov.
Now that main resources loads are scheduled (bug 49246) we don't need this stuff anymore.
Source/WebCore:
No new tests (No change in behavior).
- WebCore.exp.in:
- loader/ResourceLoadScheduler.cpp:
- loader/ResourceLoadScheduler.h:
Source/WebKit2:
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::remove):
(WebKit::WebResourceLoadScheduler::networkProcessCrashed):
- WebProcess/Network/WebResourceLoadScheduler.h:
- 11:13 AM Changeset in webkit [138390] by
-
- 2 edits in trunk/Source/WebCore
[WebGL][EFL][Qt] Transparent canvas composited non-transparent
https://bugs.webkit.org/show_bug.cgi?id=105325
Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2012-12-21
Reviewed by Kenneth Rohde Christiansen.
glXPixmap is always created without alpha channel because 1st GLXFBConfig
in a list doesn't support transparency.
Use the same code that is used to find GLXFBConfig with alpha for window
creation in GraphicsSurfacePrivate::createPixmap(). Code is moved to
findFBConfigWithAlpha() method.
Covered by fast/canvas/webgl/webgl-composite-modes-repaint.html
- platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createPixmap):
(WebCore::GraphicsSurfacePrivate::findFBConfigWithAlpha):
(GraphicsSurfacePrivate):
- 10:57 AM Changeset in webkit [138389] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Fullscreen video fixed position container horizontal position is wrong
https://bugs.webkit.org/show_bug.cgi?id=105488
Patch by Max Feil <mfeil@rim.com> on 2012-12-21
Reviewed by George Staikos.
The fix for https://bugs.webkit.org/show_bug.cgi?id=105333 has
broken fullscreen video, which was compensating by doing its
own positioning in x. My patch fixes things by making vertical
and horizontal handling symmetrical.
NOTE: This function was not upstreamed before, so you can't
actually see my diff. See the bug.
- Api/WebPage.cpp:
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::adjustFullScreenElementDimensionsIfNeeded):
- 10:53 AM Changeset in webkit [138388] by
-
- 8 edits in trunk/Source/WebKit2
Add WebKit2 SPI to get the current selection as a WebArchive
https://bugs.webkit.org/show_bug.cgi?id=105613
Reviewed by Anders Carlsson.
- UIProcess/API/C/WKPage.cpp:
(WKPageGetSelectionAsWebArchiveData):
- UIProcess/API/C/WKPage.h:
Add SPI.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getSelectionAsWebArchiveData):
(WebKit):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- WebProcess/WebPage/WebPage.cpp:
(WebKit):
(WebKit::frameWithSelection):
(WebKit::WebPage::getSelectionAsWebArchiveData):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebProcess/WebPage/WebPage.messages.in:
Pipe getter to the WebProcess and back.
- 10:46 AM Changeset in webkit [138387] by
-
- 9 edits in trunk/Source/WebKit2
Perform cleanup in WebProcess if the NetworkProcess crashes.
<rdar://problem/12903117> and https://bugs.webkit.org/show_bug.cgi?id=105592
Reviewed by Alexey Proskuryakov.
If the NetworkProcess crashes, a whole bunch of WebResourceLoaders (and WebCore::ResourceLoaders)
might be orphaned in the WebProcess.
These loaders need to fail once it is apparent they will never finish loading.
- Shared/API/c/WKError.h: Add a new error representing an "WebKit Internal Error."
- WebProcess/WebCoreSupport/WebErrors.h:
- WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
(WebKit::internalError):
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::networkProcessCrashed): Call didFail all outstanding ResourceLoaders
and tell all WebResourceLoaders the NetworkProcess crashed.
- WebProcess/Network/WebResourceLoadScheduler.h:
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::networkProcessCrashed): Call didFail with the new InternalError
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::networkProcessConnectionClosed): Tell the scheduled the NetworkProcess crashed.
- 9:42 AM Changeset in webkit [138386] by
-
- 74 edits in trunk
Unreviewed, rolling out r138376.
http://trac.webkit.org/changeset/138376
https://bugs.webkit.org/show_bug.cgi?id=104995
Broke a bunch of tests on mac.
Source/WebCore:
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::nodeName):
(WebCore):
- dom/ShadowRoot.h:
(ShadowRoot):
LayoutTests:
- editing/deleting/delete-ligature-001-expected.txt:
- editing/pasteboard/copy-in-password-field-expected.txt:
- editing/selection/select-all-textarea-expected.txt:
- fast/dom/shadow/layout-tests-can-access-shadow-expected.txt:
- fast/dom/shadow/layout-tests-can-access-shadow.html:
- fast/dom/shadow/resources/shadow-dom.js:
(isShadowRoot):
- fast/events/5056619-expected.txt:
- fast/forms/focus-selection-input-expected.txt:
- inspector/elements/shadow-dom-modify-chardata-expected.txt:
- inspector/elements/shadow-root-expected.txt:
- inspector/elements/update-shadowdom-expected.txt:
- platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
- platform/chromium-linux/fast/forms/textfield-outline-expected.txt:
- platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
- platform/chromium-win/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
- platform/chromium-win/editing/input/caret-at-the-edge-of-input-expected.txt:
- platform/chromium-win/editing/input/reveal-caret-of-multiline-input-expected.txt:
- platform/chromium-win/editing/inserting/4960120-1-expected.txt:
- platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/chromium-win/editing/pasteboard/pasting-tabs-expected.txt:
- platform/chromium-win/editing/selection/4895428-3-expected.txt:
- platform/chromium-win/editing/selection/4975120-expected.txt:
- platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/chromium-win/fast/events/autoscroll-expected.txt:
- platform/chromium-win/fast/events/context-no-deselect-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
- platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
- platform/chromium-win/fast/forms/input-text-drag-down-expected.txt:
- platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
- platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/chromium-win/fast/forms/number/number-appearance-rtl-expected.txt:
- platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
- platform/chromium-win/fast/forms/search-rtl-expected.txt:
- platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- platform/chromium-win/fast/forms/textarea-scrollbar-expected.txt:
- platform/chromium-win/fast/forms/textarea-scrolled-type-expected.txt:
- platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
- platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
- platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt:
- platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
- resources/dump-as-markup.js:
(Markup._get):
- 9:12 AM Changeset in webkit [138385] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Removing a list of failure expectations that were added as a precaution
in r138250 in case of regressions (which in the end didn't occur).
- platform/gtk/TestExpectations:
- 9:05 AM Changeset in webkit [138384] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding a few missing expectations for tests that require their baselines
to be checked before they are added.
Adding and modifying expectations where necessary to accommodate recent
changes in test behavior.
- platform/gtk/TestExpectations:
- 8:47 AM Changeset in webkit [138383] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r138237.
http://trac.webkit.org/changeset/138237
https://bugs.webkit.org/show_bug.cgi?id=105637
Regresses web inspector's editor performance. (Requested by
pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-21
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine):
(WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
(WebInspector.TextEditorMainChunk.prototype.expand):
- 8:45 AM Changeset in webkit [138382] by
-
- 4 edits2 adds in trunk
[GTK] Add WebKit1-specific TestExpectations file
https://bugs.webkit.org/show_bug.cgi?id=97562
Reviewed by Dirk Pranke.
Tools:
Implement the expectations_files method inside the GtkPort class that
returns the list of the TestExpectations files the current test configuration
requires. The method is implemented in a similar way as on the EFL port.
A unit test is also added.
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._search_paths):
(GtkPort):
(GtkPort.expectations_files):
- Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
(GtkPortTest.test_expectations_files):
LayoutTests:
Add properly formatted but currently empty TestExpectations file
for GTK WebKit1-specific test expectations.
- platform/gtk-wk1/TestExpectations: Added.
- 8:36 AM Changeset in webkit [138381] by
-
- 2 edits in trunk/Source/WebCore
Various tests in media/track are intermittently crashing.
https://bugs.webkit.org/show_bug.cgi?id=105606
Reviewed by Eric Seidel.
The root of problem is the fact that we update tracks even if we are in process of deleting the document.
Media element can stop doing that if the document informed the element via ::stop that it is going away.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::endIgnoringTrackDisplayUpdateRequests):
- 8:19 AM Changeset in webkit [138380] by
-
- 3 edits2 adds in trunk
[Chromium/Mac] Don't send an onclick event from a ctrl-click
https://bugs.webkit.org/show_bug.cgi?id=105554
Patch by Alexei Svitkine <asvitkine@chromium.org> on 2012-12-21
Reviewed by Dimitri Glazkov.
Don't send the onclick event on a control click event (which
triggers the context menu on the Mac). This matches the
behaviour of the Apple Mac port, although the Apple port
does this by checking whether the context menu is visible
in WebPage::mouseEvent().
This is a fix for http://crbug.com/146143
Source/WebCore:
Test: fast/events/controlclick-no-onclick.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):
LayoutTests:
- fast/events/controlclick-no-onclick-expected.txt: Added.
- fast/events/controlclick-no-onclick.html: Added.
- 8:01 AM Changeset in webkit [138379] by
-
- 6 edits2 adds in trunk
Implement ShadowRoot::elementFromPoint
https://bugs.webkit.org/show_bug.cgi?id=104579
Reviewed by Dimitri Glazkov.
Source/WebCore:
Move elementFromPoint and nodeFromPoint to TreeScope from Document so that ShadowRoot can call it.
In the elementFromPoint(), the element taken by nodeFromPoint is not in the same tree scope, its ancestor is returned.
Since nodeFromPoint does not return the shadow ancestor of the result node, I don't make it TreeScope method.
Test: fast/dom/shadow/elementfrompoint.html
- dom/Document.cpp:
(WebCore::Document::elementFromPoint): Code is shared with TreeScope.
(WebCore::Document::caretRangeFromPoint):
- dom/ShadowRoot.idl:
- dom/TreeScope.cpp:
(WebCore::nodeFromPoint): Moved from Document.cpp
(WebCore):
(WebCore::TreeScope::elementFromPoint):
- dom/TreeScope.h:
(WebCore):
(TreeScope):
LayoutTests:
- fast/dom/shadow/elementfrompoint-expected.txt: Added.
- fast/dom/shadow/elementfrompoint.html: Added.
- 7:55 AM Changeset in webkit [138378] by
-
- 4 edits in trunk/Source
[EFL][WK2] Never create WebCore scrollbars for EFL/WK2
https://bugs.webkit.org/show_bug.cgi?id=105632
Reviewed by Antonio Gomes.
Source/WebCore:
For delegates scroll we must not use the scroll animator,
or similar as those depends on creating WebCore scrollbars.
Handle the wheel event manually for delegates scrolling.
- page/FrameView.cpp:
(WebCore::FrameView::wheelEvent):
Source/WebKit2:
Then creating the frame ask to not create scrollbars and
lock it so they won't be created at any later time.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
- 7:55 AM Changeset in webkit [138377] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Add Crash test expectation to the media/track/ tests which have explicit expectations.
It needs to be removed after fixing https://bugs.webkit.org/show_bug.cgi?id=105606
- platform/chromium/TestExpectations:
- 7:44 AM Changeset in webkit [138376] by
-
- 74 edits in trunk
[Shadow DOM]: ShadowRoot wrong nodeName attribute
https://bugs.webkit.org/show_bug.cgi?id=104995
Reviewed by Dimitri Glazkov.
Source/WebCore:
According to the Shadow DOM spec, ShadowRoot.nodeName should return '#document-fragment' instead of '#shadow-root'.
We remove ShadowRoot::nodeName.
No new tests, covered by existing tests.
- dom/ShadowRoot.cpp:
- dom/ShadowRoot.h:
(ShadowRoot):
LayoutTests:
Uses 'instanceof' to check the instance is ShadowRoot or not.
Update dump-as-markup.js to see 'instanceof' instead of nodeType.
Also, a lot of rebaselines have been conducted.
- editing/deleting/delete-ligature-001-expected.txt:
- editing/pasteboard/copy-in-password-field-expected.txt:
- editing/selection/select-all-textarea-expected.txt:
- fast/dom/shadow/layout-tests-can-access-shadow-expected.txt:
- fast/dom/shadow/layout-tests-can-access-shadow.html:
- fast/dom/shadow/resources/shadow-dom.js:
(isShadowRoot):
- fast/events/5056619-expected.txt:
- fast/forms/focus-selection-input-expected.txt:
- inspector/elements/shadow-dom-modify-chardata-expected.txt:
- inspector/elements/shadow-root-expected.txt:
- inspector/elements/update-shadowdom-expected.txt:
- platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
- platform/chromium-linux/fast/forms/textfield-outline-expected.txt:
- platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
- platform/chromium-win/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
- platform/chromium-win/editing/input/caret-at-the-edge-of-input-expected.txt:
- platform/chromium-win/editing/input/reveal-caret-of-multiline-input-expected.txt:
- platform/chromium-win/editing/inserting/4960120-1-expected.txt:
- platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
- platform/chromium-win/editing/pasteboard/pasting-tabs-expected.txt:
- platform/chromium-win/editing/selection/4895428-3-expected.txt:
- platform/chromium-win/editing/selection/4975120-expected.txt:
- platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
- platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
- platform/chromium-win/fast/events/autoscroll-expected.txt:
- platform/chromium-win/fast/events/context-no-deselect-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
- platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
- platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
- platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
- platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
- platform/chromium-win/fast/forms/input-text-drag-down-expected.txt:
- platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
- platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
- platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
- platform/chromium-win/fast/forms/number/number-appearance-rtl-expected.txt:
- platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
- platform/chromium-win/fast/forms/search-rtl-expected.txt:
- platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- platform/chromium-win/fast/forms/textarea-scrollbar-expected.txt:
- platform/chromium-win/fast/forms/textarea-scrolled-type-expected.txt:
- platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
- platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
- platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt:
- platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt:
- platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt:
- platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
- platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
- resources/dump-as-markup.js:
(Markup._get):
- 7:36 AM Changeset in webkit [138375] by
-
- 2 edits in trunk/LayoutTests
Unreviewed rebaseline.
- platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt:
- 7:30 AM Changeset in webkit [138374] by
-
- 3 edits2 adds in trunk
Slow performance with <select> with many options and size >= 2
https://bugs.webkit.org/show_bug.cgi?id=105483
Source/WebCore:
Reviewed by Eric Seidel.
Avoids creating renderers for children of list <select>s that are not
<option> or <optgroup>. This is both more correct (no other browser
displays them) and provides a performance benefit (direct text children
of <select> would have O(N2) behavior; this usually happened due to
whitespace between <option>...</option> tags).
Test: fast/forms/menulist-no-renderer-for-unexpected-children.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childShouldCreateRenderer):
LayoutTests:
Reviewed by Eric Seidel.
Test that checks that text and non-<option> and <optgroup> element
children of <select> do not get a renderer.
- fast/forms/menulist-no-renderer-for-unexpected-children-expected.txt: Added.
- fast/forms/menulist-no-renderer-for-unexpected-children.html: Added.
- 7:28 AM Changeset in webkit [138373] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline fast/js/global-constructors.html after r138248.
- platform/efl/fast/js/global-constructors-expected.txt:
- 7:19 AM Changeset in webkit [138372] by
-
- 2 edits in trunk/LayoutTests
Unreviewed rebaseline.
- platform/chromium-win-xp/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt:
- 7:08 AM Changeset in webkit [138371] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Mark svg/custom/feDisplacementMap-01.svg as missing.
- platform/efl/TestExpectations:
- 6:51 AM Changeset in webkit [138370] by
-
- 4 edits in trunk/Source
[EFL] Add guard around ContextMenuItemTagInspectElement
https://bugs.webkit.org/show_bug.cgi?id=105267
Patch by Seokju Kwon <Seokju Kwon> on 2012-12-21
Reviewed by Ryosuke Niwa.
Need INSPECTOR guard for using ContextMenuItemTagInspectElement.
Source/WebKit/efl:
- WebCoreSupport/AssertMatchingEnums.cpp:
Source/WebKit2:
- UIProcess/API/efl/ewk_context_menu_item.cpp:
- 6:50 AM FeatureFlags edited by
- Add CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED (diff)
- 6:25 AM Changeset in webkit [138369] by
-
- 2 edits in trunk/Tools
[EFL] Enable feature option for the CSS sticky position
https://bugs.webkit.org/show_bug.cgi?id=105630
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-12-21
Reviewed by Kenneth Rohde Christiansen.
Enable CSS sticky position feature by default for the
EFL port. This feature option was added in r138252.
No new tests. Existing layout tests pass.
- Scripts/webkitperl/FeatureList.pm:
- 5:47 AM Changeset in webkit [138368] by
-
- 2 edits in trunk/Tools
[WK2] REGRESSION(r138232): It made 4 tests timeout
https://bugs.webkit.org/show_bug.cgi?id=105623
Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-12-21
Reviewed by Kenneth Rohde Christiansen.
r138232 changed functionality so that empty text output
no longer leads to a dump() call, which leads to a timeout.
Instead do a text dump if there is text output or if there
is no audio output.
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::dumpResults):
- 5:40 AM Changeset in webkit [138367] by
-
- 3 edits3 adds in trunk
[WK2] TiledBackingStore: Scroll position is not reset when new page is loaded
https://bugs.webkit.org/show_bug.cgi?id=105627
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Reset scroll position to (0,0) when new page is loaded.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendViewportAttributesChanged):
LayoutTests:
Added a layout test checking scroll position for newly loaded pages.
- fast/dom/resources/check-scroll-position-onload.html: Added.
- fast/dom/scroll-position-for-new-loads-expected.txt: Added.
- fast/dom/scroll-position-for-new-loads.html: Added.
- 5:30 AM Changeset in webkit [138366] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Rebaseline after r138365.
- platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt:
- 4:42 AM Changeset in webkit [138365] by
-
- 13 edits in trunk
Fix typing zero into multiple field input
https://bugs.webkit.org/show_bug.cgi?id=105501
Reviewed by Kent Tamura.
Source/WebCore:
We have a couple of problems when handling zero in a multiple fields
element.
- Typing '02' into a month field will set '12'.
- Typing '0' into 12 hour hour field will set '12' and move to the focus to the next field.
This change adds a type ahead buffer so we can handle these cases
properly. If the value in the type ahead buffer is valid we set it so a
change event will fire.
Added tests to *-multiple-fields-keyboard-events.html.
- html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::didBlur): Clear the type ahead
buffer. handleKeyboardEvent() won't set the type ahead value if it is
not in range, so we set the value here.
(WebCore::DateTimeNumericFieldElement::handleKeyboardEvent):
(WebCore::DateTimeNumericFieldElement::setEmptyValue): Clear type ahead buffer.
(WebCore::DateTimeNumericFieldElement::setValueAsInteger):
(WebCore::DateTimeNumericFieldElement::stepDown): Clear type ahead buffer.
(WebCore::DateTimeNumericFieldElement::stepUp): Clear type ahead buffer.
(WebCore::DateTimeNumericFieldElement::typeAheadValue): Returns integer
value for the type ahead characters.
(WebCore):
(WebCore::DateTimeNumericFieldElement::visibleValue): If we have type
ahead characters, show that.
- html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement):
LayoutTests:
- fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt:
- fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html:
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt:
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html:
- fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:
- fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events-expected.txt:
- fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events.html:
- 2:46 AM Changeset in webkit [138364] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Buffering ranges are reported incorrectly with GStreamer 1.0
https://bugs.webkit.org/show_bug.cgi?id=105319
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2012-12-21
Reviewed by Philippe Normand.
We add the gPercentMax constant to select between 100 and
GST_FORMAT_PERCENT_MAX depending if we are compiling against
GStreamer 0.10 or 1.0 and we use that in the corresponding method.
Current tests should suffice.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::buffered): Added the use of
gPercentMax constant instead of 100 to have the different code
paths for GStreamer 0.10 and 1.0.
- 2:46 AM Changeset in webkit [138363] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL][WK1] Obsolete a case in test_ewk_frame api test to not make bot sick
https://bugs.webkit.org/show_bug.cgi?id=105142
Patch by Kangil Han <kangil.han@samsung.com> on 2012-12-21
Reviewed by Gyuyoung Kim.
BUG 49246 has changed load behavior on malformed url input.
That is why test_ewk_frame api test is timed out.
To not make bot sick, this patch comments out that test case at a moment.
- tests/test_ewk_frame.cpp:
(TEST_F):
- 2:34 AM Changeset in webkit [138362] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Gardening after r138232. Skipped 4 tests timing out.
https://bugs.webkit.org/show_bug.cgi?id=105623
Reviewed by Csaba Osztrogonác.
- platform/qt-5.0-wk2/TestExpectations:
- 2:31 AM Changeset in webkit [138361] by
-
- 11 edits in trunk/Source
PDFPlugin: Cannot drop files/URLs on PDFPlugin
https://bugs.webkit.org/show_bug.cgi?id=105516
<rdar://problem/12729443>
Reviewed by Alexey Proskuryakov.
Add shouldAllowNavigationFromDrags to Plugin/PluginView/etc., which WebCore will
consult when dragging over a PluginDocument to decide whether or not a drag may result in navigation.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::shouldAllowNavigationFromDrags): Added, always returning false to keep existing behavior.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
(NetscapePlugin): Added.
- WebProcess/Plugins/PDF/SimplePDFPlugin.h:
(WebKit::SimplePDFPlugin::shouldAllowNavigationFromDrags): Added, always returning true. (Simple)PDFPlugin should
navigate when dropped onto, just like an image or HTML document would.
- WebProcess/Plugins/Plugin.h:
(Plugin): Add shouldAllowNavigationFromDrags.
- WebProcess/Plugins/PluginProxy.h: Add shouldAllowNavigationFromDrags.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::shouldAllowNavigationFromDrags): Forward shouldAllowNavigationFromDrags to the plugin.
- WebProcess/Plugins/PluginView.h: Add shouldAllowNavigationFromDrags.
- page/DragController.cpp:
(WebCore::DragController::operationForLoad): If we drag over a PluginDocument, check if its PluginView
claims to support navigation resulting from a drag (only PDFPlugin will for now). If it does, allow the drag.
- plugins/PluginViewBase.h:
(WebCore::PluginViewBase::shouldAllowNavigationFromDrags): Add shouldAllowNavigationFromDrags.
- 2:22 AM WK2-EFLTextCheckerApiTutorial created by
- 2:19 AM Changeset in webkit [138360] by
-
- 2 edits in trunk/LayoutTests
[Qt] Gardening after r138316. Skipped a new failing reftest
with minor pixel differences.
Reviewed by Csaba Osztrogonác.
- platform/qt/TestExpectations:
- 2:17 AM Changeset in webkit [138359] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r138357.
http://trac.webkit.org/changeset/138357
https://bugs.webkit.org/show_bug.cgi?id=105622
wrong fix for the problem (the original author actually
already did this, and it's not helping) (Requested by thorton
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-21
- win/WebKit2.def.in:
- 2:05 AM Changeset in webkit [138358] by
-
- 10 edits in trunk
Unreviewed, rolling out r138338.
http://trac.webkit.org/changeset/138338
https://bugs.webkit.org/show_bug.cgi?id=105621
speculative rollout because fast/dom/shadow/content-element-
distributed-nodes.html is crashing on linux debug. (Requested
by loislo on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-21
.:
- Source/autotools/symbols.filter:
Source/WebCore:
- WebCore.exp.in:
- dom/DocumentFragment.h:
- dom/Node.cpp:
(WebCore::Node::documentFragmentIsShadowRoot):
(WebCore):
- dom/Node.h:
(Node):
(WebCore::Node::isShadowRoot):
- dom/ShadowRoot.h:
Source/WebKit2:
- win/WebKit2.def.in:
- 2:04 AM Changeset in webkit [138357] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed Windows build fix after http://trac.webkit.org/changeset/138338
- win/WebKit2.def.in:
- 1:54 AM Changeset in webkit [138356] by
-
- 7 edits in trunk/Source/WebKit2
Reducing print preview scale significantly causes a crash
https://bugs.webkit.org/show_bug.cgi?id=105519
<rdar://problem/12807090>
Reviewed by Alexey Proskuryakov.
The bitmap image used for print previews was being created respecting the print preview scale.
This doesn't make any sense, as the scale does not affect the size of the image required to
represent the previewed page. Instead, we should not scale the size, creating the buffer at a
size that is constant regardless of scale, and do the scaling when drawing *into* the buffer instead.
In some cases, this could cause an out-of-memory crash.
- UIProcess/API/mac/WKPrintingView.mm:
(-[WKPrintingView _drawPreview:]): Rename rect to scaledPrintingRect for clarity. Compute print
preview bitmap image size from the original non-scaled drawing size and the device scale factor.
Hand the image size to drawRectToImage. Draw the image without scaling, as it's always created
at the correct size. Don't compute the scale factor from the size of the image, we can know it from WebPageProxy.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::drawRectToImage): Add a parameter to drawRectForImage, imageSize.
- UIProcess/WebPageProxy.h:
(WebPageProxy): Add a parameter to drawRectForImage, imageSize.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::drawRectToImage): Use imageSize to size our buffer, and scale up to make the printing rect
fit in the bitmap's bounds.
- WebProcess/WebPage/WebPage.h:
(WebPage): Add a parameter to drawRectForImage, imageSize.
- WebProcess/WebPage/WebPage.messages.in: Add a parameter to drawRectForImage, imageSize.
- 1:45 AM EFLWebKit edited by
- (diff)
- 1:33 AM Changeset in webkit [138355] by
-
- 2 edits in trunk/Tools
[Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
https://bugs.webkit.org/show_bug.cgi?id=105309
On Windows the library name is Qt5WebKitWidgets as well.
So r138136 should not have adjusted the library name for Windows.
Reviewed by Simon Hausmann.
- Scripts/webkitdirs.pm:
(builtDylibPathForName):
- 1:15 AM Changeset in webkit [138354] by
-
- 13 edits in trunk
MediaStream API: Update the MediaStream constructor
https://bugs.webkit.org/show_bug.cgi?id=98416
Reviewed by Adam Barth.
Updated the MediaStream constructor to support the more general argument
list from the latest Media Capture and Streams specification:
http://dev.w3.org/2011/webrtc/editor/getusermedia.html
Source/WebCore:
Added more test cases to existing tests.
- Modules/mediastream/MediaStream.cpp:
(WebCore::containsSource):
(WebCore):
(WebCore::processTrack):
(WebCore::createFromSourceVectors):
(WebCore::MediaStream::create):
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStream.idl:
LayoutTests:
- fast/js/constructor-length.html:
- fast/mediastream/MediaStreamConstructor-expected.txt:
- fast/mediastream/MediaStreamConstructor.html:
- platform/blackberry/fast/js/constructor-length-expected.txt:
- platform/chromium/fast/js/constructor-length-expected.txt:
- platform/gtk/fast/js/constructor-length-expected.txt:
- platform/mac/fast/js/constructor-length-expected.txt:
- platform/qt/fast/js/constructor-length-expected.txt:
- 1:07 AM Changeset in webkit [138353] by
-
- 4 edits2 adds in trunk
[Qt] Add new TestExpectations for qt-5.0-mac-wk2.
https://bugs.webkit.org/show_bug.cgi?id=105424
This change will allow us to run a very specific
subset of the available LayoutTests on a mac buildbot.
The new baseline search path for mac will look as follows:
qt-5.0-mac-wk2 -> qt-5.0-wk2 -> qt-5.0 -> qt-mac -> qt
Reviewed by Dirk Pranke.
Tools:
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._search_paths):
- Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest):
LayoutTests:
- platform/qt-5.0-mac-wk2/TestExpectations: Added.
