Timeline



Jan 10, 2013:

11:54 PM Changeset in webkit [139412] by g.czajkowski@samsung.com
  • 9 edits in trunk

On Linux, should be able to get spelling suggestions without selecting the misspelled word
https://bugs.webkit.org/show_bug.cgi?id=103520

Reviewed by Ryosuke Niwa.

Source/WebCore:

Allow to get/insert spelling suggestions without selecting the misspelled word for
Linux WebKit ports. WebCore assumes that the misspelled word has to be selected
to get its suggestions.

In compliance with native application behaviour a new editing policy is introduced,
to do not highlight the misspelled word to just get its guesses.

No new tests, covered by context-menu-suggestions.html.

  • WebCore.exp.in:

Remove _ZN7WebCore6Editor21isSelectionMisspelledEv symbol as Mac port doesn't
need it any longer.

  • editing/EditingBehavior.h:

(EditingBehavior):
(WebCore::EditingBehavior::shouldAllowSpellingSuggestionsWithoutSelection):
Add a new behavior for Linux, to allow spelling suggestions without selecting
the misspelled word.

  • editing/Editor.cpp:

(WebCore::Editor::isContinuousSpellCheckingEnabled):
Add missing const modifier, to use this method in 'misspelledWordAtCaretOrRange() const'.

(WebCore::Editor::misspelledWordAtCaretOrRange):
Allow to check spelling under the caret or selected word.
Does nothing for selection made on the multiple words.

(WebCore::Editor::misspelledSelectionString):
Return the misspelled selection.

(WebCore::Editor::guessesForMisspelledWord):
Remove 'Selection' from method name as it may return guesses without selection.

(WebCore::Editor::guessesForMisspelledOrUngrammatical):
Ditto.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):
Select the word under caret to meet the conditions from misspelledWordAtCaretOrRange.

(WebCore::ContextMenuController::populate):
Update guessesForMisspelledOrUngrammatical call.

LayoutTests:

  • platform/efl/TestExpectations:

Unskip context-menu-suggestions.html for WebKit-EFL as it passes now.

  • platform/gtk/TestExpectations:

Update failing reason.

11:44 PM Changeset in webkit [139411] by noel.gordon@gmail.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Disable PNG and ICO image webkit-unit-tests after r139347
https://bugs.webkit.org/show_bug.cgi?id=106631

Reviewed by Eric Seidel.

  • tests/WebImageTest.cpp:

(WebKit::TEST): Disable ICOImage and PNGImage tests on WIN and MAC to
green their respective webkit-unit-test bots. The tests still pass on
LINUX so keep test coverage there for now.

11:39 PM Changeset in webkit [139410] by morrita@google.com
  • 11 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=106283
[Shadow DOM] HTMLContentElement and HTMLShadowElement should be behind SHADOW_DOM

Reviewed by Kentaro Hara.

No new tests. Covered by existing tests.

This change moves <content> and <shadow> behind
ENABLE(SHADOW_DOM). Note that empty stub definitions are remaining
even after this change. They are for minimizing #if/#endif usage
and won't hurt code size.

  • WebCore.exp.in:
  • html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distribute):

  • html/shadow/HTMLContentElement.cpp:

(WebCore):
(WebCore::HTMLContentElement::create):
(WebCore::HTMLContentElement::HTMLContentElement):

  • html/shadow/HTMLContentElement.h:

(WebCore):
(HTMLContentElement):

  • html/shadow/HTMLShadowElement.cpp:
  • html/shadow/HTMLShadowElement.h:

(WebCore):
(WebCore::isHTMLShadowElement):
(WebCore::toHTMLShadowElement):

  • html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::decorate):

  • testing/Internals.cpp:

(WebCore::Internals::createContentElement):
(WebCore::Internals::isValidContentSelect):

11:08 PM Changeset in webkit [139409] by tasak@google.com
  • 13 edits
    1 copy
    1 add in trunk/Source/WebCore

Implement CSSGroupingRule for @host @-rules and @supports.
https://bugs.webkit.org/show_bug.cgi?id=106418

Reviewed by Antti Koivisto.

CSSGroupingRule is to share code between CSSMediaRule, CSSSupportsRule
and CSSHostRule. @supports and @host @-rules are dervied from
CSSGroupingRule:
http://www.w3.org/TR/2012/WD-css3-conditional/#the-cssgroupingrule-interface
https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#css-host-rule-interface
Since @media is also derived from CSSGroupingRule and @region has the
same interface as CSSGroupingRule, modify to use CSSGroupingRule:
http://dev.w3.org/csswg/css3-regions/#the-at-region-style-rule

No new tests, because no new feature is implemented.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added CSSGroupingRule.h and CSSGroupingRule.cpp.

  • css/CSSAllInOne.cpp:

Modified to include CSSGroupingRule.cpp.

  • css/CSSGroupingRule.cpp: Added.

(WebCore):
(WebCore::CSSGroupingRule::CSSGroupingRule):
(WebCore::CSSGroupingRule::~CSSGroupingRule):
(WebCore::CSSGroupingRule::insertRule):
(WebCore::CSSGroupingRule::deleteRule):
(WebCore::CSSGroupingRule::appendCssTextForItems):
(WebCore::CSSGroupingRule::length):
(WebCore::CSSGroupingRule::item):
(WebCore::CSSGroupingRule::cssRules):
(WebCore::CSSGroupingRule::reattach):
(WebCore::CSSGroupingRule::reportMemoryUsage):
These codes are moved from CSSMediaRule and WebKitCSSRegionRule.

  • css/CSSGroupingRule.h:

(WebCore):
(CSSGroupingRule):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):
Make CSSMediaRule inherit CSSGroupingRule.
(WebCore::CSSMediaRule::media):
(WebCore::CSSMediaRule::reattach):
Keep the code for updating media queries' CSSOMWrapper.
(WebCore::CSSMediaRule::reportMemoryUsage):
We need to report media queries' CSSOMWrapper memory usage.
(WebCore::CSSMediaRule::mediaQueries):
(WebCore::CSSMediaRule::cssText):

  • css/CSSMediaRule.h:
  • css/WebKitCSSRegionRule.cpp:

Make WebKitCSSRegionRule inherit CSSGroupingRule.
(WebCore::WebKitCSSRegionRule::WebKitCSSRegionRule):
(WebCore::WebKitCSSRegionRule::cssText):

  • css/WebKitCSSRegionRule.h:
  • css/StyleRule.h:

Added inlined accessor to obtain StyleRuleMedia* and StyleRuleRegion*
from StyleRuleBlock*.

10:57 PM Changeset in webkit [139408] by aandrey@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: [Canvas] add an option to reload the page if there is an uninstrumented canvas
https://bugs.webkit.org/show_bug.cgi?id=105822

Reviewed by Pavel Feldman.

Show in the front-end an option to reload the page if there is an uninstrumented canvas.

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileType):
(WebInspector.CanvasProfileType.prototype.decorationElement):
(WebInspector.CanvasProfileType.prototype._updateDecorationElement):
(WebInspector.CanvasProfileType.prototype._onReloadPageButtonClick):

  • inspector/front-end/ProfileLauncherView.js:

(WebInspector.ProfileLauncherView.prototype.addProfileType):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileType.prototype.decorationElement):

10:22 PM Changeset in webkit [139407] by rniwa@webkit.org
  • 2 edits in trunk/Tools

kill-old-processes and delete-stale-build-files use CRLF linebreaks
https://bugs.webkit.org/show_bug.cgi?id=106622

Reviewed by Simon Fraser.

Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
Also escape clang\+\+ correctly in kill-old-processes.

  • BuildSlaveSupport/delete-stale-build-files:
  • BuildSlaveSupport/kill-old-processes:
10:18 PM Changeset in webkit [139406] by Dimitri Glazkov
  • 7 edits in trunk/Source/WebCore

The word "selector" is somewhat redundant redundantly used in SelectorChecker.
https://bugs.webkit.org/show_bug.cgi?id=106413

In https://bugs.webkit.org/show_bug.cgi?id=105864, Antti suggested reducing some of the redundant uses of the word
"selector" in SelectorChecker. Here's a start.

Reviewed by Antti Koivisto.

Simple renames, no change in behavior.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::match): Renamed.
(WebCore):
(WebCore::SelectorChecker::fastCheck): Ditto,
(WebCore::SelectorChecker::checkOne): Ditto.

  • css/SelectorChecker.h:

(SelectorChecker):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList): Changed to use new name.
(WebCore::StyleResolver::ruleMatches): Renamed from checkSelector to better match argument and return value.
(WebCore::StyleResolver::checkRegionSelector): Changed to use new names.

  • css/StyleResolver.h:

(StyleResolver):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::matches): Ditto.
(WebCore::SelectorDataList::execute): Ditto.

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorChecker::checkContentSelector): Ditto.

10:17 PM Changeset in webkit [139405] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

Web Inspector: Pass the script url to the script-preprocessor script
https://bugs.webkit.org/show_bug.cgi?id=104384

Patch by John J. Barton <johnjbarton@chromium.org> on 2013-01-10
Reviewed by Pavel Feldman.

Source/WebCore:

Add url argument to the script-preprocessor script in PageAgent.reload()

Test: inspector/debugger/debugger-script-preprocessor.html

  • bindings/v8/DebuggerScript.js:
  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::ScriptPreprocessor::ScriptPreprocessor):
(WebCore::ScriptDebugServer::ScriptPreprocessor::preprocessSourceCode):
(WebCore::ScriptDebugServer::handleV8DebugEvent):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):

LayoutTests:

Tests for Bug 80922 by Pavel Feldman <pfeldman@chromium.org> that did not land somehow,
with additional test for Bug 104384

  • inspector/debugger/debugger-script-preprocessor-expected.txt: Added.
  • inspector/debugger/debugger-script-preprocessor.html: Added.
  • platform/chromium/inspector/debugger/debugger-script-preprocessor-expected.txt: Added.
9:49 PM Changeset in webkit [139404] by commit-queue@webkit.org
  • 7 edits in trunk

Web Inspector: DataGrid refactoring: make cell editing more generic.
https://bugs.webkit.org/show_bug.cgi?id=105849

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-10
Reviewed by Pavel Feldman.

Source/WebCore:

Editing feature has been added to DataGrid to edit localStorage.
Column numbers (0 and 1) are hardcoded.

This patch makes column editing feature more generic: remove hardcoded
colums, take "editable" column property into account.

This patch is a prerequisite for cookie editing.

  • inspector/front-end/DOMStorageItemsView.js:

Use meaningful column names.

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._ondblclick): Check column editability.
(WebInspector.DataGrid.prototype._contextMenuInDataTable): Ditto.
(WebInspector.DataGridNode.prototype.createCell):
Supply cell element with column id.
(WebInspector.DataGrid.prototype.columnIdentifierFromNode):
Added utility method.
(WebInspector.DataGrid.prototype._nextEditableColumn): Ditto.
(WebInspector.DataGrid.prototype._keyDown): Calculate editable column.
(WebInspector.DataGrid.prototype._editingCommitted): Ditto.
(WebInspector.DataGrid.prototype._startEditing): Ditto.
(WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode):
Refined parameter type / name.
(WebInspector.DataGrid.prototype._resizerDragging):
Fix resizer index property names.
(WebInspector.DataGrid.prototype._startResizerDragging): Ditto.
(WebInspector.DataGrid.prototype._positionResizers): Ditto.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._updateDividersIfNeeded): Ditto.

LayoutTests:

  • inspector/storage-panel-dom-storage-update.html: Fix column names.
  • inspector/storage-panel-dom-storage.html: Ditto.
9:33 PM Changeset in webkit [139403] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix after r139357. It was missing a comma.

  • QueueStatusServer/model/queues.py:

(Queue):

8:46 PM Changeset in webkit [139402] by falken@chromium.org
  • 3 edits
    4 adds in trunk

Elements must be reattached when inserted/removed from top layer
https://bugs.webkit.org/show_bug.cgi?id=105489

Reviewed by Julien Chaffraix.

Source/WebCore:

Ensure a reattach occurs when an element is inserted/removed from top layer, so its renderer can be inserted correctly:
as a child of RenderView in top layer sibling order if it's in the top layer, and in the usual place otherwise.

We previously relied on style recalc to catch when an element is inserted/removed from the top layer, because it
only happens on dialog.show/close which toggle display: none. But that is incorrect because, for example, close()
followed immediately by show() results in no style change.

Tests: fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html

fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html

  • dom/Element.cpp:

(WebCore::Element::removedFrom): Call Document::removeFromTopLayer to let the element be removed from the top layer vector.
removeFromTopLayer calls Element::setIsInTopLayer(false) itself if needed.
(WebCore::Element::setIsInTopLayer): Ensure a reattach occurs if the element is already attached.

LayoutTests:

  • fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer-expected.html: Added.
  • fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html: Added.

This tests that a top layer element removed from the document does not reappear in the top layer if readded.
This test actually would pass before this patch, but just by good fortune (see bug).

  • fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd-expected.html: Added.
  • fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html: Added.

This tests that top layer ordering is correct after removing and readding an element to the top layer.

8:44 PM Changeset in webkit [139401] by shinyak@chromium.org
  • 4 edits
    2 adds in trunk

When a selected node in nested ShadowDOM is deleted, selection have wrong range.
https://bugs.webkit.org/show_bug.cgi?id=106526

Reviewed by Ryosuke Niwa.

Source/WebCore:

Since FrameSelection and htmlediting did not consider nested Shadow DOM, the FrameSelection still selects
removed elements if selected nodes in nested Shadow DOM are removed.

We have to use containsIncludingShadowDOM to handle with nested Shadow DOM correctly.

Test: fast/dom/shadow/selection-in-nested-shadow.html

  • editing/FrameSelection.cpp:

(WebCore::removingNodeRemovesPosition):

  • editing/htmlediting.cpp:

(WebCore::updatePositionForNodeRemoval):

LayoutTests:

  • fast/dom/shadow/selection-in-nested-shadow-expected.txt: Added.
  • fast/dom/shadow/selection-in-nested-shadow.html: Added.
8:00 PM Changeset in webkit [139400] by morrita@google.com
  • 10 edits in trunk/Source/WebCore

[Shadow DOM] Refactoring: InsertionPoint could simplify its subclass hooks
https://bugs.webkit.org/show_bug.cgi?id=106614

Reviewed by Dimitri Glazkov.

This change simplifies InsertionPoint overrides and give some flexibility to it.

The change

  • Removes InsertionPoint::isSelectValid(). now ContentSelectorQuery parses given selector anyway. Invalid select attribute is handled by newly introduced matchTypeFor() method.
  • Introduces InsertionPoint::matchTypeFor() to give a chance each InsertionPoint to decide whether it accepts the given node as its distribution. Then it lets DetailsSummaryElement adopt it.
  • Pulls some HTMLShadowElement overrides up to InsertionPoint so that other upcoming InsertionPoint subclasses don't need to override them.

No new tests. Refactoring.

  • html/HTMLDetailsElement.cpp:

(WebCore::DetailsSummaryElement::DetailsSummaryElement):

  • Implemented matchTypeFor() to get rid of HTMLContentElement machinery which is compiled out in the upcoming change.

(DetailsSummaryElement):

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorQuery::ContentSelectorQuery):
(WebCore::ContentSelectorQuery::matches):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::matchTypeFor): Added.
(WebCore):

  • html/shadow/HTMLContentElement.h:

(HTMLContentElement):
(WebCore::isHTMLContentElement):

  • html/shadow/HTMLShadowElement.cpp:
  • html/shadow/HTMLShadowElement.h:

(HTMLShadowElement):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::emptySelectorList): Moved from HTMLShadowElement.
(WebCore):

  • html/shadow/InsertionPoint.h:

(WebCore::InsertionPoint::matchTypeFor): Added.
(WebCore::InsertionPoint::selectorList): Moved from HTMLShadowElement.
(InsertionPoint):

  • testing/Internals.cpp:

(WebCore::Internals::isValidContentSelect):

7:18 PM Changeset in webkit [139399] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Fixing AuthenticationError when running test-webkitpy as a non-committer.
https://bugs.webkit.org/show_bug.cgi?id=106420

Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-10
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.push_local_commits_to_server):

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVNRepository):
(SVNRepository.has_authorization_for_realm):

7:00 PM Changeset in webkit [139398] by cevans@google.com
  • 5 edits
    2 copies in branches/chromium/1364

Merge 138850
BUG=162622
Review URL: https://codereview.chromium.org/11856005

6:36 PM Changeset in webkit [139397] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebCore/platform/graphics/FontCache.cpp

Merge 138812
BUG=167443
Review URL: https://codereview.chromium.org/11854003

6:30 PM Changeset in webkit [139396] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 138908
BUG=166324
Review URL: https://codereview.chromium.org/11853004

6:28 PM Changeset in webkit [139395] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1312

Merge 138908
BUG=166324
Review URL: https://codereview.chromium.org/11853003

6:19 PM Changeset in webkit [139394] by cevans@google.com
  • 2 edits in branches/chromium/1364/Source/WebCore/editing

Merge 138657
BUG=167827
Review URL: https://codereview.chromium.org/11851002

6:17 PM Changeset in webkit [139393] by cevans@google.com
  • 2 edits in branches/chromium/1312/Source/WebCore/editing

Merge 138657
BUG=167827
Review URL: https://codereview.chromium.org/11850002

6:01 PM Changeset in webkit [139392] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Plugin snapshot label should take device resolution and inset into account
https://bugs.webkit.org/show_bug.cgi?id=106619

Reviewed by Simon Fraser.

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::paintLabel): Take into account the inset in the label image.
(WebCore::RenderSnapshottedPlugIn::tryToFitStartLabel): Look at the page's device scale, and adjust the label image accordingly.

5:54 PM Changeset in webkit [139391] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1364

Merge 139029
BUG=167868
Review URL: https://codereview.chromium.org/11840004

5:42 PM Changeset in webkit [139390] by cevans@google.com
  • 1 edit
    2 deletes in branches/chromium/1364

Merge 138974
BUG=166336
Review URL: https://codereview.chromium.org/11847002

5:30 PM Changeset in webkit [139389] by cevans@google.com
  • 2 edits in branches/chromium/1364/Source

Merge 138173
BUG=166627
Review URL: https://codereview.chromium.org/11828063

5:27 PM Changeset in webkit [139388] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1364

Merge 138131
BUG=166513
Review URL: https://codereview.chromium.org/11846002

5:21 PM Changeset in webkit [139387] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1364

Merge 138316
BUG=161420
Review URL: https://codereview.chromium.org/11845002

5:13 PM Changeset in webkit [139386] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1364

Merge 138460
BUG=167498
Review URL: https://codereview.chromium.org/11841005

4:07 PM Changeset in webkit [139385] by jamesr@google.com
  • 4 edits in trunk

[chromium] Store scrollable layer's contents size for coordinated scrollable layers
https://bugs.webkit.org/show_bug.cgi?id=106518

Reviewed by Adrienne Walker.

Source/WebCore:

This stores a scrollable layer's contentsSize in the scroll layer's bounds, which is otherwise not useful. This
value is currently calculated based on fragile knowledge of the tree structure immediately beneath a scrollable
layer.

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinatorChromium::frameViewLayoutUpdated):

LayoutTests:

  • platform/chromium/TestExpectations:
4:01 PM Changeset in webkit [139384] by commit-queue@webkit.org
  • 4 edits
    3 copies
    1 add in trunk/LayoutTests

IndexedDB: Update expected results for IndexedDB layout tests
https://bugs.webkit.org/show_bug.cgi?id=106411

Patch by Michael Pruett <michael@68k.org> on 2013-01-10
Reviewed by Tony Chang.

For IndexedDB layout tests whose output differs between V8 and
JSC, move V8 test output to platform/chromium and set expected
results to JSC test output.

  • platform/chromium/storage/indexeddb/exception-in-event-aborts-expected.txt: Copied from LayoutTests/storage/indexeddb/exception-in-event-aborts-expected.txt.
  • platform/chromium/storage/indexeddb/transaction-error-expected.txt: Copied from LayoutTests/storage/indexeddb/transaction-error-expected.txt.
  • platform/chromium/storage/indexeddb/version-change-abort-expected.txt: Copied from LayoutTests/storage/indexeddb/version-change-abort-expected.txt.
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/indexeddb/transaction-error-expected.txt:
  • storage/indexeddb/version-change-abort-expected.txt:
3:43 PM Changeset in webkit [139383] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

Layout Test fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=106612

  • platform/chromium/TestExpectations: Marked as flake.
3:41 PM Changeset in webkit [139382] by cevans@google.com
  • 4 edits in branches/chromium/1364/Source/WebCore

Merge 138863
BUG=156906
Review URL: https://codereview.chromium.org/11830062

3:40 PM Changeset in webkit [139381] by cevans@google.com
  • 4 edits in branches/chromium/1312/Source/WebCore

Merge 138863
BUG=156906
Review URL: https://codereview.chromium.org/11833048

3:35 PM Changeset in webkit [139380] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[Qt][EFL] Rename from xxxContentsScale() to xxxScale() in PageViewportController.
https://bugs.webkit.org/show_bug.cgi?id=106537

Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-10
Reviewed by Kenneth Rohde Christiansen.

Rename 3 methods to match the terms of ViewportAttributes.

  • UIProcess/API/qt/qwebkittest.cpp:

(QWebKitTest::viewport):
(QWebKitTest::contentsScale):

  • UIProcess/PageViewportController.h:

(WebKit::PageViewportController::minimumScale):
(WebKit::PageViewportController::maximumScale):
(WebKit::PageViewportController::currentScale):

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):

3:28 PM Changeset in webkit [139379] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebKit/chromium/public/WebInputEvent.h

Merge 138684
BUG=165836
Review URL: https://codereview.chromium.org/11817055

3:19 PM Changeset in webkit [139378] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 138918
BUG=167147
Review URL: https://codereview.chromium.org/11827065

3:18 PM Changeset in webkit [139377] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1312

Merge 138918
BUG=167147
Review URL: https://codereview.chromium.org/11786012

3:14 PM Changeset in webkit [139376] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test animations/fill-mode-iteration-count-non-integer.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=106609

  • platform/chromium/TestExpectations: Marked as failing.
3:11 PM Changeset in webkit [139375] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

Adjust ref-test expectation to actual work.

  • platform/chromium/TestExpectations: Adjusted.
2:45 PM Changeset in webkit [139374] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed rebaseline. Apple Windows port.

  • platform/win/fast/ruby/base-shorter-than-text-expected.txt:
2:42 PM Changeset in webkit [139373] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test fast/canvas/webgl/context-release-upon-reload.html is a flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=106606

  • platform/chromium/TestExpectations: Added.
2:40 PM Changeset in webkit [139372] by commit-queue@webkit.org
  • 20 edits
    5 adds in trunk

Implement AutocompleteErrorEvent#reason
https://bugs.webkit.org/show_bug.cgi?id=105568

Source/WebCore:

Patch by Dan Beam <dbeam@chromium.org> on 2013-01-10
Reviewed by Adam Barth.

Test: fast/events/constructors/autocomplete-error-event-constructor.html

  • WebCore.gypi: Added AutocompleteErrorEvent.idl and AutocompleteErrorEvent.h for chromium port's build.
  • dom/AutocompleteErrorEvent.h: Added.

(WebCore): Added new type of error named AutocompleteErrorEvent.
(AutocompleteErrorEventInit): Added init params for AutocompleteErrorEvents (so initEvent() can be used).
(AutocompleteErrorEvent): Added a new error event that inherits from Event but also has a reason for failure.
(WebCore::AutocompleteErrorEvent::create): Factory function to create AutocompleteErrorEvents.
(WebCore::AutocompleteErrorEvent::reason): The reason why a requestAutocomplete() invocation failed. Can be

"disabled", "cancel", or "invalid".

(WebCore::AutocompleteErrorEvent::interfaceName): The name of the event's interface (for event.toString()).
(WebCore::AutocompleteErrorEvent::AutocompleteErrorEvent): Various ways of constructing the error event.

  • dom/AutocompleteErrorEvent.idl: Added.
  • dom/EventNames.in: Added AutocompleteError to this list, based on REQUEST_AUTOCOMPLETE conditional.
  • html/HTMLFormElement.cpp: Updated form elements to dispatch AutocompleteErrorEvents on errors and to give

more details (event.reason) when the request fails.

(WebCore::HTMLFormElement::requestAutocomplete): Changed to newly added failure type "disabled".
(WebCore::HTMLFormElement::finishRequestAutocomplete): Changed

  • html/HTMLFormElement.h: Added new results (ErrorDisabled, ErrorCancel, ErrorInvalid).
  • page/DOMWindow.idl: Added global event constructor for new AutocompleteErrorEvent() style event creation.

Source/WebKit/chromium:

Patch by Dan Beam <dbeam@chromium.org> on 2013-01-10
Reviewed by Adam Barth.

  • public/WebFormElement.h: Added matching enum values for public chromium WebKit API.
  • src/AssertMatchingEnums.cpp: Updated compile assert that WebKit and WebCore enums match.

LayoutTests:

Added tests to verify event creation and global event constructor existence of AutocompleteErrorEvent
and updated the existing tests to make sure errors received are of the right type and have the right reason.

Patch by Dan Beam <dbeam@chromium.org> on 2013-01-10
Reviewed by Adam Barth.

  • fast/events/constructors/autocomplete-error-event-constructor-expected.txt: Added.
  • fast/events/constructors/autocomplete-error-event-constructor.html: Added.
  • fast/events/event-creation.html: Added new AutocompleteErrorEvent() test case.
  • fast/forms/form-request-autocomplete.html: Updated 'autocompleteerror' listeners to check event.reason.
  • fast/js/constructor-length.html: Added AutocompleteErrorEvent to list.
  • fast/js/script-tests/global-constructors.js: Added AutocompleteErrorEvent to list.
  • platform/blackberry/fast/js/constructor-length-expected.txt: Added expected ReferenceError.
  • platform/chromium/fast/events/constructors/autocomplete-error-event-constructor-expected.txt: Added.
  • platform/chromium/fast/forms/form-request-autocomplete-expected.txt: Updated passing expectations.
  • platform/chromium/fast/js/constructor-length-expected.txt: Added expected 0 length result.
  • platform/gtk/fast/js/constructor-length-expected.txt: Added expected ReferenceError.
  • platform/mac/fast/js/constructor-length-expected.txt: Added expected ReferenceError.
  • platform/qt/fast/js/constructor-length-expected.txt: Added expected ReferenceError.
2:31 PM Changeset in webkit [139371] by yoli@rim.com
  • 2 edits in trunk/Source/WebCore

HTMLMediaElement::resume() should schedule a load rather than load immediately
https://bugs.webkit.org/show_bug.cgi?id=106587

Reviewed by Eric Carlson.

It is not always safe to start the jobs at the time resume() is called. That is why the jobs are
suspended. It can also be suspended again right after being resumed.

No new tests as there is no visible functional change, also it is a theoretically good-to-have change
that doesn't fix any known cross-platform issue.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::resume): Replace load() with scheduleLoad().

2:31 PM Changeset in webkit [139370] by roger_fong@apple.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed rebaselines. Apple Windows port.

  • platform/win/TestExpectations:
  • platform/win/fast/dom/window-load-crash-expected.txt: Added.
2:25 PM Changeset in webkit [139369] by commit-queue@webkit.org
  • 2 edits
    2 deletes in trunk/LayoutTests

Unreviewed, rolling out r139226.
http://trac.webkit.org/changeset/139226
https://bugs.webkit.org/show_bug.cgi?id=106602

re
baselines were premature (Requested by rfong on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-10

  • platform/win/accessibility/canvas-fallback-content-2-expected.txt:
  • platform/win/platform/win/accessibility/option-element-selection-and-focus-events-expected.txt: Removed.
  • platform/win/platform/win/accessibility/select-element-valuechange-event-expected.txt: Removed.
2:09 PM Changeset in webkit [139368] by roger_fong@apple.com
  • 2 edits in trunk/WebKitLibraries

Update WebkitSystemInterface lib for Windows port.
This hasn't been done in a while and the current one is out of date.
In addition I believe it will fix:
<rdar://problem/12990844>

Rubberstamped by Timothy Horton.

  • win/lib/WebKitSystemInterface.lib:
2:06 PM Changeset in webkit [139367] by abarth@webkit.org
  • 4 edits in trunk/Source

Add an ENABLE macro and a WebCore::Setting for the threaded parser
https://bugs.webkit.org/show_bug.cgi?id=106595

Reviewed by Benjamin Poulain.

Source/WebCore:

This patch adds both a WebCore::Setting and an ENABLE macro for the
threaded parser. We plan to keep the ENABLE macro off by default for a
while. The runtime setting will let us more easily conduct A/B
experiments when the time arises.

  • page/Settings.in:

Source/WebKit/chromium:

Explicitly disable THREADED_HTML_PARSER for Chromium so that we can
more easily enable it locally.

  • features.gypi:
1:58 PM Changeset in webkit [139366] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Test svg/dom/SVGScriptElement/script-onerror-bubbling.svg is a flaky timeout on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=106598

  • platform/chromium/TestExpectations: Expectatized.
1:52 PM Changeset in webkit [139365] by wangxianzhu@chromium.org
  • 2 edits in trunk/Source/WebCore

Regression(r129944): Heap-use-after-free in WebCore::computeNonFastScrollableRegion
https://bugs.webkit.org/show_bug.cgi?id=99515

Reviewed by Simon Fraser.

The object used-after-freed is a destructed FrameView that is still in the m_scrollableAreas set of the parent FrameView. Actually it has been removed from m_scrollableAreas when setParent(0), but then is added back in updateScrollableAreaSet() because its frameViewParent() is still not 0 (though parent() is already 0).

No new tests. The heap-use-after-free doesn't always cause crash so it can't be stably tested with a test case. Memory analysis tools like asan discovered the heap-use-after-free and verified that the patch can fix the issue.

  • page/FrameView.cpp:

(WebCore::FrameView::parentFrameView): Checks if the FrameView has been removed from the parent.

1:49 PM Changeset in webkit [139364] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[WK2] Set IndexedDB database path in WK2
https://bugs.webkit.org/show_bug.cgi?id=106257

Patch by Michael Pruett <michael@68k.org> on 2013-01-10
Reviewed by Benjamin Poulain.

  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp:

(WebKit::WebKeyValueStorageManager::initialize):

  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.h:

(WebKeyValueStorageManager):
(WebKit::WebKeyValueStorageManager::indexedDBDatabaseDirectory):

  • WebProcess/WebPage/WebPageGroupProxy.cpp:

(WebKit::WebPageGroupProxy::WebPageGroupProxy):

1:47 PM Changeset in webkit [139363] by cevans@google.com
  • 6 edits
    15 copies
    4 deletes in branches/chromium/1364

Merge 138654
BUG=139321
Review URL: https://codereview.chromium.org/11823064

1:44 PM Changeset in webkit [139362] by cevans@google.com
  • 6 edits
    15 copies
    4 deletes in branches/chromium/1312

Merge 138654
BUG=139321
Review URL: https://codereview.chromium.org/11820059

1:44 PM Changeset in webkit [139361] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Expanding the timeout expectation for fast/css/user-drag-none.html, the test
times out on both debug and release builds.

  • platform/gtk/TestExpectations:
1:43 PM Changeset in webkit [139360] by Christophe Dumez
  • 2 edits in trunk/Tools

[EFL][jhbuild] Use tarballs for gstreamer instead of git
https://bugs.webkit.org/show_bug.cgi?id=106552

Reviewed by Laszlo Gombos.

Use tarballs for gstreamer instead of git in EFL's jhbuild
to work around intermittent network issues on our build
bots. Tarballs are fully cached and require no network
operation if their checksum matches.

  • efl/jhbuild.modules:
1:37 PM Changeset in webkit [139359] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1364

Merge 138926
BUG=129890
Review URL: https://codereview.chromium.org/11819066

1:35 PM Changeset in webkit [139358] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1312

Merge 138926
BUG=129890
Review URL: https://codereview.chromium.org/11819065

1:27 PM Changeset in webkit [139357] by rniwa@webkit.org
  • 5 edits in trunk/Tools

Add Mac WK2 EWS bots
https://bugs.webkit.org/show_bug.cgi?id=106590

Reviewed by Adam Barth.

Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
Also add a deprecated MacWK2Port class.

  • QueueStatusServer/model/queues.py:

(Queue):

  • Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.port):
(MacWK2Port):
(MacWK2Port.run_webkit_tests_command):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(MacEWS):
(MacWK2EWS):

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(_test_ewses):

1:10 PM Changeset in webkit [139356] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Fix scale of screen.width, window.outerWidth and @media device-width when page scale not applied in compositor.
https://bugs.webkit.org/show_bug.cgi?id=106460

Patch by John Mellor <johnme@chromium.org> on 2013-01-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

screen.width, window.outerWidth and @media device-width should be in
density independent (UI) pixels, not physical screen pixels.

This already works on most ports (including iOS). However Chrome for
Android currently internally sizes its windows in physical screen pixels
instead of density independent pixels, and this leaks through in the
sizes provided to WebCore.

This patch scales these sizes appropriately before they reach JavaScript,
on platforms where the applyPageScaleFactorInCompositor setting is false
(i.e. just Chrome for Android). Once Chrome for Android switches over to
the same coordinate space, the applyPageScaleFactorInCompositor setting
will be removed, along with any code (such as this) that depends on it.

The effect of this patch on Chrome for Android when viewing a page with
a width=device-width viewport on a Galaxy Nexus (720x1280 @ dPR 2) is:

@media device-width changes from 720 to 360
screen.width changes from 720 to 360
screen.availWidth changes from 720 to 360
window.outerWidth changes from 720 to 360
window.innerWidth remains 360 (at overview zoom)
@media width remains 360
document.documentElement.clientWidth remains 360
document.documentElement.offsetWidth remains 360
document.documentElement.scrollWidth remains 360
document.body.clientWidth remains 360
document.body.offsetWidth remains 360
document.body.scrollWidth remains 360

And similarly for heights (though they are slightly less than 640, since
toolbars etc. get subtracted from the available height).

No new tests, as applyDeviceScaleFactorInCompositor appears to always be
true in DumpRenderTree, so this situation cannot occur there.

  • page/Settings.in:

Added applyDeviceScaleFactorInCompositor setting, which allows
detecting whether we need to normalize the scale.

  • platform/chromium/PlatformScreenChromium.cpp:

(WebCore::toUserSpace):

Static function for normalizing screen rect scale.

(WebCore::screenRect):

Uses toUserSpace.

(WebCore::screenAvailableRect):

Uses toUserSpace.

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::processSubtree):

Use applyDeviceScaleFactorInCompositor instead of
applyPageScaleFactorInCompositor, to scale the window rect correctly
on platforms other than Chrome for Android.

Source/WebKit/chromium:

  1. Exposes the existing applyDeviceScaleFactorInCompositor from

WebSettings on Settings (and stores the value there instead), so it can
be accessed from WebCore.

  1. Changes ChromeClientImpl::windowRect to return values in density

independent (UI) pixels pixels instead of physical screen pixels (see
explanation in Source/WebCore/ChangeLog).

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::windowRect):

Normalizes window rect scale.

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setApplyDeviceScaleFactorInCompositor):
(WebKit::WebSettingsImpl::applyDeviceScaleFactorInCompositor):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

1:02 PM Changeset in webkit [139355] by commit-queue@webkit.org
  • 12 edits
    2 moves in trunk/Tools

[chromium] move webpermissionclient related methods to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=106548

Patch by Dan Carney <dcarney@google.com> on 2013-01-10
Reviewed by Jochen Eisinger.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebKit):
(WebTestRunner::WebTestRunner::webPermissions):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::setDelegate):
(WebTestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::webPermissions):
(WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
(WebTestRunner::TestRunner::setImagesAllowed):
(WebTestRunner::TestRunner::setScriptsAllowed):
(WebTestRunner::TestRunner::setStorageAllowed):
(WebTestRunner::TestRunner::setPluginsAllowed):
(WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
(WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebTestRunner):
(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.

(WebTestRunner):
(WebTestRunner::WebPermissions::WebPermissions):
(WebTestRunner::WebPermissions::~WebPermissions):
(WebTestRunner::WebPermissions::allowImage):
(WebTestRunner::WebPermissions::allowScriptFromSource):
(WebTestRunner::WebPermissions::allowStorage):
(WebTestRunner::WebPermissions::allowPlugins):
(WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
(WebTestRunner::WebPermissions::allowRunningInsecureContent):
(WebTestRunner::WebPermissions::setImagesAllowed):
(WebTestRunner::WebPermissions::setScriptsAllowed):
(WebTestRunner::WebPermissions::setStorageAllowed):
(WebTestRunner::WebPermissions::setPluginsAllowed):
(WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
(WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
(WebTestRunner::WebPermissions::setDelegate):
(WebTestRunner::WebPermissions::setDumpCallbacks):
(WebTestRunner::WebPermissions::reset):

  • DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.

(WebTestRunner):
(WebPermissions):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):
(TestShell::resetTestController):
(TestShell::createNewWindow):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::normalizeLayoutTestURL):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

1:01 PM Changeset in webkit [139354] by commit-queue@webkit.org
  • 3 edits
    2 copies
    1 move in trunk/Tools

Split EWS tool cold-boot.sh into modular components
https://bugs.webkit.org/show_bug.cgi?id=106527

Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-10
Reviewed by Adam Barth.

Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
Updated GCE bot build scripts to match.
Unable to test scripts directly as they depend on being in the repository to work!

  • EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
  • EWSTools/GoogleComputeEngine/build-commit-queue.sh:
  • EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
  • EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
  • EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
12:51 PM Changeset in webkit [139353] by fmalita@chromium.org
  • 12 edits in trunk/Source/WebCore

Rename GraphicsContext::addRoundedRectClip
https://bugs.webkit.org/show_bug.cgi?id=106581

Reviewed by Simon Fraser.

This patch renames GraphicsContext::addRoundedRectClip to clipRoundedRect for consistency
with the other GC clipping methods.

No new tests: no functional changes.

  • WebCore.order:
  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::clipRoundedRect):

  • platform/graphics/GraphicsContext.h:

(GraphicsContext):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::clipRoundedRect):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::pushContentsClip):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::clipRoundedInnerRect):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clipToRect):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):

  • rendering/RenderThemeMacShared.mm:

(WebCore::RenderThemeMacShared::paintMenuListButtonGradients):
(WebCore::RenderThemeMacShared::paintSliderTrack):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintSliderTrack):

  • rendering/RenderThemeWinCE.cpp:

(WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):

12:44 PM Changeset in webkit [139352] by tommyw@google.com
  • 13 edits in trunk/Source

MediaStream API: Adding the new id attribute to MediaStream and MediaStreamTrack
https://bugs.webkit.org/show_bug.cgi?id=106564

Reviewed by Adam Barth.

Specification: http://dev.w3.org/2011/webrtc/editor/getusermedia.html
MediaStream looses its label attribute and instead gets an id attribute.
MediaStreamTrack gets an id attribute.

Source/Platform:

  • chromium/public/WebMediaStreamComponent.h:

(WebMediaStreamComponent):

  • chromium/public/WebMediaStreamDescriptor.h:

(WebMediaStreamDescriptor):

Source/WebCore:

Not testable yet, will add tests in a followup patch.

  • Modules/mediastream/MediaStream.h:

(WebCore::MediaStream::label):
(MediaStream):
(WebCore::MediaStream::id):

  • Modules/mediastream/MediaStream.idl:
  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::id):
(WebCore):

  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/MediaStreamTrack.idl:
  • platform/chromium/support/WebMediaStreamComponent.cpp:

(WebKit::WebMediaStreamComponent::initialize):
(WebKit):
(WebKit::WebMediaStreamComponent::isEnabled):
(WebKit::WebMediaStreamComponent::id):
(WebKit::WebMediaStreamComponent::source):

  • platform/chromium/support/WebMediaStreamDescriptor.cpp:

(WebKit::WebMediaStreamDescriptor::label):
(WebKit):
(WebKit::WebMediaStreamDescriptor::id):

  • platform/mediastream/MediaStreamComponent.h:

(WebCore::MediaStreamComponent::id):
(WebCore::MediaStreamComponent::MediaStreamComponent):
(MediaStreamComponent):

  • platform/mediastream/MediaStreamDescriptor.h:

(WebCore::MediaStreamDescriptor::create):
(WebCore::MediaStreamDescriptor::id):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):
(MediaStreamDescriptor):

12:32 PM Changeset in webkit [139351] by ojan@chromium.org
  • 9 edits
    2 adds in trunk

Flexboxes incorrectly add the scrollbar width to the intrinsic width of fixed-width items
https://bugs.webkit.org/show_bug.cgi?id=106591

Reviewed by Levi Weintraub.

Source/WebCore:

The scrollbar width should only be added if the width of the flex item
is not fixed.

Test: fast/css/fixed-width-intrinsic-width-excludes-scrollbars.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):
Use shared helper method. This also happens to fix the vertical
writing-mode case.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::instrinsicScrollbarLogicalWidth):
(WebCore):

  • rendering/RenderBox.h:

(RenderBox):
Add a method for determining the scrollbar's contribution to the boxes
intrinsic width.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
Use shared code for determining the scrollbar width and only add the
width when computing the intrinsic widths.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computePreferredLogicalWidths):\
Just adding a FIXME to account for scrollbar width.

LayoutTests:

  • fast/css/fixed-width-intrinsic-width-excludes-scrollbars-expected.txt: Added.
  • fast/css/fixed-width-intrinsic-width-excludes-scrollbars.html: Added.
  • fast/css/positioned-overflow-scroll.html:
12:21 PM Changeset in webkit [139350] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

Replace unnecessary null-checks with an assert in MainResourceLoader::continueAfterNavigationPolicy.
https://bugs.webkit.org/show_bug.cgi?id=106476

Reviewed by Alexey Proskuryakov.

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::continueAfterNavigationPolicy): Null-checks for resourceLoader were

added in an abundance of caution in r139150. Given that we know the load hasn't been cancelled,
resourceLoader can only be null if continueAfterNavigationPolicy() has already been called
before when m_substituteData is valid. continueAfterNavigationPolicy() is only called for redirects,
and SubstituteData doesn't support redirects, so it is correct to assert that resourceLoader is non-null.

12:14 PM Changeset in webkit [139349] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Removing a few crash expectations for tests that haven't crashed
for a long time. Hopefully the crash causes have been fixed.
Adding a flaky failure expectation for a CSS Regions reftest.

  • platform/gtk/TestExpectations:
11:52 AM Changeset in webkit [139348] by jparent@chromium.org
  • 2 edits in trunk/Tools

Dashboard Cleanup: Do not generate the page if we are about to reload.
https://bugs.webkit.org/show_bug.cgi?id=106584

Reviewed by Dirk Pranke.

Move the logic to determine if we should generate the page into
parseParameters() since that is where we have the knowledge to
determine it, and return that value to handleLocationChange,
rather than passing the changed parameters back to handleLocationChange
and having it make the decision.

This is logically equivalent, save one case: when we are about to do
a reload, we know that there is no reason to generate the page. Old
code was causing an extra page generation in this case.

  • TestResultServer/static-dashboards/dashboard_base.js:

(parseParameters):
(handleLocationChange):

11:47 AM Changeset in webkit [139347] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-10

  • DEPS:
11:33 AM Changeset in webkit [139346] by leviw@chromium.org
  • 3 edits
    4 adds in trunk

ScrollingCoordinator touch event hit rects aren't converted to proper coordinates when in nested views
https://bugs.webkit.org/show_bug.cgi?id=106383

Reviewed by James Robinson.

Source/WebCore:

ScrollingCoordinator uses clippedOverflowRectForRepaint(0) to generate the bounds for a renderer's hit
testing rect. The rect this returns is in the coordinates of its document. This change converts the
rect to the outermost view's coordinate system using convertToContainingView.

Tests: platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::accumulateRendererTouchEventTargetRects):

LayoutTests:

  • platform/chromium/fast/events/touch/resources: Added.
  • platform/chromium/fast/events/touch/resources/frame-with-touch-handler.html: Added.
  • platform/chromium/fast/events/touch/touch-hit-rects-in-iframe-expected.txt: Added.
  • platform/chromium/fast/events/touch/touch-hit-rects-in-iframe.html: Added.
11:29 AM Changeset in webkit [139345] by leviw@chromium.org
  • 3 edits
    2 adds in trunk

Regression(r137939): Heap-use-after-free in WebCore::accumulateDocumentEventTargetRects
https://bugs.webkit.org/show_bug.cgi?id=106454

Reviewed by James Robinson.

Source/WebCore:

Correctly removing child Documents from their parent's tracked touch handler maps when detaching and
when their last touch event handler is removed.

Test: fast/events/touch/nested-document-with-touch-handler-detached-crash.html

  • dom/Document.cpp:

(WebCore::Document::detach):
(WebCore::Document::didRemoveEventTargetNode):

LayoutTests:

  • fast/events/touch/nested-document-with-touch-handler-detached-crash.html: Added.
  • fast/events/touch/nested-document-with-touch-handler-detached-crash-expected.txt: Added.
11:22 AM Changeset in webkit [139344] by ojan@chromium.org
  • 3 edits
    1 add
    16 deletes in trunk/LayoutTests

Convert fast/css/positioned-overflow-scroll.html to a check-layout.js test
https://bugs.webkit.org/show_bug.cgi?id=106585

Reviewed by Tony Chang.

This is in preparation for adding more cases to this test.

  • fast/css/positioned-overflow-scroll-expected.txt: Added.
  • fast/css/positioned-overflow-scroll.html:
  • platform/chromium-android/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/chromium-android/fast/css/positioned-overflow-scroll-expected.txt: Removed.
  • platform/chromium-linux/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/chromium-mac-lion/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/chromium-mac/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/chromium-win/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/chromium/fast/css/positioned-overflow-scroll-expected.txt: Removed.
  • platform/efl/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/efl/fast/css/positioned-overflow-scroll-expected.txt: Removed.
  • platform/gtk/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/gtk/fast/css/positioned-overflow-scroll-expected.txt: Removed.
  • platform/mac/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/mac/fast/css/positioned-overflow-scroll-expected.txt: Removed.
  • platform/qt/fast/css/positioned-overflow-scroll-expected.png: Removed.
  • platform/qt/fast/css/positioned-overflow-scroll-expected.txt: Removed.
  • resources/check-layout.js:
11:22 AM Changeset in webkit [139343] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

REGRESSION(r138222): WebDocumentLoaderMac-related leaks seen on Leaks bot
https://bugs.webkit.org/show_bug.cgi?id=106137

Reviewed by Brady Eidson.

Tested manually by comparing before and after leaks output for WK1-mac.

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::receivedError): Call dispatchDidFailLoading() if

a SubstituteData load fails or is cancelled. Without this call, load counts
are not balanced on WebDocumentLoaderMac and it is retained forever.

(WebCore::MainResourceLoader::didFinishLoading):

11:11 AM Changeset in webkit [139342] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[jhbuild] Use the "configure" script to build glib
https://bugs.webkit.org/show_bug.cgi?id=106569

Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2013-01-10
Reviewed by Martin Robinson.

So far both EFL and GTK have been using autogen.sh to build glib.
While that does work most of the time, it's not really needed since
we are downloading and building stable releases from tarballs.
Additionally, autogen.sh fails to work with automake 1.13 due to the
usage of some macros that have been removed (this has already been
fixed in glib master).

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:
10:44 AM Changeset in webkit [139341] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebKit2

Ensure that WebPageProxy's notion of pageScaleFactor is reset on didCommitLoad
https://bugs.webkit.org/show_bug.cgi?id=103290
<rdar://problem/12752467>

Reviewed by Darin Adler.

When a standard main frame load is committed, we reset the WebPage's
pageScaleFactor, if it's not the default. However, if the previous
page had a full-main-frame plugin that was handling page scaling itself,
WebPageProxy can have a cached pageScaleFactor != 1, while WebPage
now (since the plugin that was overriding (set)pageScaleFactor is gone)
has a pageScaleFactor of 1, causing us to skip the call to reset the
WebPage's pageScaleFactor.

Therefore, when WebPageProxy is notified that a standard main-frame load
is committed, reset its cached notion of the pageScaleFactor.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame): Add a parameter which corresponds to FrameLoadType, so we can
determine whether a frame load is of FrameLoadTypeStandard (which matches the check to reset page scale in
WebFrameLoaderClient::didCommitLoad), so we can reset m_pageScaleFactor.

  • UIProcess/WebPageProxy.h:

(WebPageProxy): Add frameLoadType parameter to didCommitLoadForFrame.

  • UIProcess/WebPageProxy.messages.in: Add frameLoadType parameter to didCommitLoadForFrame.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad): Pass frameLoadType parameter to didCommitLoadForFrame.

10:42 AM Changeset in webkit [139340] by timothy_horton@apple.com
  • 6 edits in trunk/Source/WebKit2

PDFPlugin: Cmd-/+ should affect PDF page scale
https://bugs.webkit.org/show_bug.cgi?id=103285
<rdar://problem/12710469>

Reviewed by Darin Adler.

Plugins which support handling page scale themselves should also handle
page zoom, as it is a very similar concept.

This patch disables text zoom in the case of a main-frame plugin which supports
page scale factor changes, as it is not needed in the PDFPlugin case
(we can't do text-only scale for PDF), but it could be added later if needed.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::pageZoomFactorDidChange):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:

Add WebPageProxy::pageZoomFactorDidChange, to notify WebPageProxy of
out-of-band page zoom factor changes (in this case, from PluginView).

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::setPageScaleFactor):
Update WebPageProxy's notion of the current page zoom whenever PluginView
is notified of a page scale factor change.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setTextZoomFactor): We don't support text zoom in plugins, but
we also don't want it to silently act on the Frame if we have a plugin that
purports to handle page scale itself. Return early if this is the case.
(WebKit::WebPage::pageZoomFactor): For plugins that support page scale factor,
we equate page scale and page zoom. Return the PluginView's page scale factor
in place of the Frame's page zoom factor.
(WebKit::WebPage::setPageZoomFactor): Make page zoom changes in the aforementioned
case affect the PluginView's page scale.
(WebKit::WebPage::setPageAndTextZoomFactors): Ditto.

10:41 AM Changeset in webkit [139339] by rjkroege@chromium.org
  • 3 edits
    2 deletes in trunk

Manually revert http://trac.webkit.org/changeset/136012
https://bugs.webkit.org/show_bug.cgi?id=106580

Reviewed by Dimitri Glazkov.

Source/WebCore:

136012 broke touch-scrolling of an overflow div in an iframe. Revert manually
to work around conflicts.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):

LayoutTests:

  • fast/events/touch/gesture/touch-gesture-scroll-remove-node-expected.txt: Removed.
  • fast/events/touch/gesture/touch-gesture-scroll-remove-node.html: Removed.
10:41 AM Changeset in webkit [139338] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Changing tests to be consistent and use self.scm rather then recreating the scm object.
(Missed a couple)
https://bugs.webkit.org/show_bug.cgi?id=106536

Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-10
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
10:39 AM Changeset in webkit [139337] by robert@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r136967): margin-top + overflow:hidden causes incorrect layout for internal floated elements
https://bugs.webkit.org/show_bug.cgi?id=106374

Reviewed by David Hyatt.

Source/WebCore:

r136397 treated any self-collapsing block that had a clearance delta as though it was clearing a float, but
blocks that avoid floats can get a clearance delta too. So just ensure there is clearance on the block when deciding
whether we need to add the margin back in before placing the float.

Test: fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden-and-float-child.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):

LayoutTests:

  • fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden-and-float-child-expected.txt: Added.
  • fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden-and-float-child.html: Added.
10:39 AM Changeset in webkit [139336] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

PDFPlugin: Header cleanup
https://bugs.webkit.org/show_bug.cgi?id=106540

Reviewed by Andreas Kling.

  • WebProcess/Plugins/PDF/PDFPlugin.mm: Remove some unneeded headers.
10:28 AM Changeset in webkit [139335] by Dimitri Glazkov
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Update expectations for fast/regions/selecting-text-through-different-region-flows.html.

  • platform/chromium-mac-lion/fast/regions/selecting-text-through-different-region-flows-expected.png: Added.
10:27 AM Changeset in webkit [139334] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Color picker in Styles pane shows wrong initial color
https://bugs.webkit.org/show_bug.cgi?id=106567

Reviewed by Pavel Feldman.

The RGB's G value for "crimson" was wrong.

  • inspector/front-end/Color.js:
10:27 AM Changeset in webkit [139333] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Mark more inspector/geolocation* tests as flaky on Win.
https://bugs.webkit.org/show_bug.cgi?id=106426

  • platform/chromium/TestExpectations: Marked.
10:25 AM Changeset in webkit [139332] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Web Inspector: Refactor InspectorTest to create output interface
https://bugs.webkit.org/show_bug.cgi?id=106231

Patch by John J. Barton <johnjbarton@chromium.org> on 2013-01-10
Reviewed by Pavel Feldman.

Refactor InspectorTest to extract InspectorTest.Output, the API
used between InspectorTest and the test output reciever (the
test-script page by default).

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest.InspectorTest.Output.testComplete):
(initialize_InspectorTest.InspectorTest.Output.addResult):
(initialize_InspectorTest.InspectorTest.Output.clearResults):
(initialize_InspectorTest.InspectorTest.completeTest):
(initialize_InspectorTest.InspectorTest.addResult):

10:25 AM Changeset in webkit [139331] by tony@chromium.org
  • 14 edits in trunk

Speed up supplemental dependency computation
https://bugs.webkit.org/show_bug.cgi?id=106503

Reviewed by Adam Barth.

.:

  • Source/cmake/WebKitMacros.cmake: Add --idlAttributesFile to the binding generation step in cmake.

Source/WebCore:

On my machine, generating supplemental IDL dependencies was taking about 18s
because it has to run the C preprocessor on each IDL file. Avoid this by using
a regular expression to find the Supplemental= value in each IDL file rather than
doing a full parse. Now generating supplemental IDL dependencies is less than a
second.

preprocess-idls.pl used to also check IDL attributes against IDLAttributes.txt.
Move this code to run in generate-bindings.pl. This change revealed that
TestRunner.idl uses PassContext so add that to IDLAttributes.txt.

No new tests, this is a build refactor. EWS bots should be green.

  • DerivedSources.make: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
  • DerivedSources.pri: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
  • GNUmakefile.am: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
  • UseJSC.cmake: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
  • UseV8.cmake: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
  • WebCore.gyp/WebCore.gyp: Remove --idlAttributesFile from preprocess-idls.pl and add it to generate-bindings.pl.
  • bindings/scripts/IDLAttributes.txt: Add PassContext needed by TestRunner.idl.
  • bindings/scripts/generate-bindings.pl:

(loadIDLAttributes): Moved from preprocess-idls.pl.
(checkIDLAttributes): Moved from preprocess-idls.pl.
(checkIfIDLAttributesExists): Moved from preprocess-idls.pl.

  • bindings/scripts/preprocess-idls.pl:

(getSupplementalFromIDLFile): Helper method to get Supplemental=* quickly.

Tools:

Pass the IDL attributes file for generating the bindings in WebKitTestRunner.

  • WebKitTestRunner/CMakeLists.txt:
10:16 AM Changeset in webkit [139330] by mvujovic@adobe.com
  • 4 edits
    11 adds in trunk

[CSS Filters] RenderLayerCompositor::addToOverlapMap should take into account the filters outsets (ie. blur and drop-shadow)
https://bugs.webkit.org/show_bug.cgi?id=94022

Reviewed by Simon Fraser.

Source/WebCore:

When a layer has a filter that moves pixels, we need to add its entire bounds, including its
outsets and children, to the overlap map. The filter can move the children's pixels
anywhere in the layer, so we can't rely on the children's bounds.

Eventually, we should avoid adding children to the overlap map if the parent's bounds used
for overlap testing already include the children. I've added a FIXME for this optimization.

Tests: compositing/filters/sw-layer-overlaps-hw-shadow.html

compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow.html
compositing/filters/sw-shadow-overlaps-hw-layer.html
compositing/filters/sw-shadow-overlaps-hw-shadow.html

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::overlapBounds):

If necessary, return the calculated layer bounds, including the children. Otherwise,
return the localBoundingBox.

(RenderLayer):
(WebCore::RenderLayer::overlapBoundsIncludeChildren):

If the layer has a filter that moves pixels, return true.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap):

Add the overlapBounds instead of the localBoundingBox to the overlap map.

(WebCore::RenderLayerCompositor::computeCompositingRequirements):

Use the overlapBounds instead of the localBoundingBox for overlap testing.

LayoutTests:

Add tests to check several combinations of software layer and composited layer overlap when
filter outsets are involved.

  • compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Added.
  • compositing/filters/sw-layer-overlaps-hw-shadow.html: Added.
  • compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Added.
  • compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow.html: Added.
  • compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Added.
  • compositing/filters/sw-shadow-overlaps-hw-layer.html: Added.
  • compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Added.
  • compositing/filters/sw-shadow-overlaps-hw-shadow.html: Added.
  • platform/chromium/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Added.
  • platform/chromium/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Added.
10:08 AM Changeset in webkit [139329] by ojan@chromium.org
  • 6 edits
    2 adds in trunk

intrinsic min-widths don't override width for file upload controls
https://bugs.webkit.org/show_bug.cgi?id=106517

Reviewed by Tony Chang.

Source/WebCore:

Separate out computing intrinsic width from perferred width so that
we can use the intrinsic width correctly when applying min-width/max-width.
The preferred width is the width used in its container's computation
of its intrinsic width.

This is the first in a series of patches making this work across
the render tree.

Test: fast/forms/file/intrinsic-min-width-overrides-width.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::minIntrinsicLogicalWidth):
(WebCore):
(WebCore::RenderBox::maxIntrinsicLogicalWidth):
(WebCore::RenderBox::computeIntrinsicLogicalWidths):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::computeIntrinsicLogicalWidths):
(WebCore):
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):

  • rendering/RenderFileUploadControl.h:

(RenderFileUploadControl):

LayoutTests:

  • fast/forms/file/intrinsic-min-width-overrides-width-expected.html: Added.
  • fast/forms/file/intrinsic-min-width-overrides-width.html: Added.
9:56 AM Changeset in webkit [139328] by fmalita@chromium.org
  • 102 edits
    4 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaselining results after http://trac.webkit.org/changeset/138250.

  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Removed.
  • platform/chromium-linux-x86/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-lion/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-mac-lion/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-mac-lion/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-mac-lion/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-mac-snowleopard/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-mac/svg/custom/feDisplacementMap-01-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-mac/svg/filters/feImage-animated-transform-on-target-rect-expected.png:
  • platform/chromium-mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-mac/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-mac/svg/filters/feImage-late-indirect-update-expected.png:
  • platform/chromium-mac/svg/filters/feImage-multiple-targets-id-change-expected.png:
  • platform/chromium-mac/svg/filters/feImage-position-expected.png:
  • platform/chromium-mac/svg/filters/feImage-preserveAspectratio-expected.png:
  • platform/chromium-mac/svg/filters/feImage-reference-invalidation-expected.png:
  • platform/chromium-mac/svg/filters/feImage-subregions-expected.png:
  • platform/chromium-mac/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
  • platform/chromium-mac/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-add-to-document-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-attribute-change-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-changes-id-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-id-change-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-inline-style-change-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-property-change-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-reappend-to-document-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-remove-from-document-expected.png:
  • platform/chromium-mac/svg/filters/feImage-target-style-change-expected.png:
  • platform/chromium-win-xp/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Removed.
  • platform/chromium-win-xp/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
  • platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
  • platform/chromium-win/svg/filters/feImage-late-indirect-update-expected.png:
  • platform/chromium/TestExpectations:
9:51 AM Changeset in webkit [139327] by zandobersek@gmail.com
  • 2 edits in trunk

[Autotools] Add the AM_WEBKIT_FEATURE_CONDITIONAL macro
https://bugs.webkit.org/show_bug.cgi?id=106576

Reviewed by Martin Robinson.

Replace the AC_CHECK_WEBKIT_FEATURE_ENABLED with the new macro.
The former was executing actions based on the passed-in feature being
enabled in the (possibly overridden) GNUmakefile.features.am, the actions
usually affecting the Automake conditional value that was set up afterwards.
The new macro does this directly, setting up an Automake conditional of the
same name as the feature that was checked.

  • Source/autotools/webkitfeature.m4:
9:45 AM Changeset in webkit [139326] by victor@rosedu.org
  • 5 edits in trunk

media/video-controls-captions.html fails after fixing https://bugs.webkit.org/show_bug.cgi?id=105536
https://bugs.webkit.org/show_bug.cgi?id=106230

Reviewed by Eric Carlson.

Source/WebCore:

Until Chromium has proper controls for lists of text tracks, the caption button
needs to preserve its functionality.

Updated TestExpectations to reactivate test.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Added explicit call to updateTextTrackDisplay.
This enables hiding the tracks immediately.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Added extra check before rendering
that captions should actually be displayed.

LayoutTests:

  • platform/chromium/TestExpectations: Reactivated test.
9:44 AM Changeset in webkit [139325] by morrita@google.com
  • 18 edits
    2 adds in trunk/Source/WebCore

ComposedShadowTreeWalker shouldn't be exposed to non-ShadowDOM classes
https://bugs.webkit.org/show_bug.cgi?id=106505

Reviewed by Dimitri Glazkov.

This change hides ComposedShadowTreeWalker from non-ShadowDOM classes by

  • introducing thin wrapper functions on NodeRenderingTraversal and relacing CSTW callsites with it,
  • replacing ComposedShadowTreeWalker usage with AncestorChainWalker if possible and
  • moving AncestorChainWalker to its own file and including it on files which needs only AncestorChainWalker. This eliminates ComposedShadowTreeWalker.h inclusions.

No new tests. No behavior change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/AncestorChainWalker.cpp: Added. Extracted from ComposedShadowTreeWalker.cpp

(WebCore):
(WebCore::AncestorChainWalker::AncestorChainWalker):
(WebCore::AncestorChainWalker::parent):

  • dom/AncestorChainWalker.h: Added. Extracted from ComposedShadowTreeWalker.h

(WebCore):
(AncestorChainWalker):
(WebCore::AncestorChainWalker::get):
(WebCore::AncestorChainWalker::crossingInsertionPoint):

  • dom/ComposedShadowTreeWalker.cpp:
  • dom/ComposedShadowTreeWalker.h:
  • dom/DOMAllInOne.cpp:
  • dom/ElementShadow.h:

(WebCore::shadowOfParent):
(WebCore):

  • dom/EventDispatcher.cpp:
  • dom/Node.cpp:
  • dom/NodeRenderingTraversal.cpp:

(WebCore::NodeRenderingTraversal::nextInScope):
(NodeRenderingTraversal):
(WebCore::NodeRenderingTraversal::previousInScope): Added.
(WebCore::NodeRenderingTraversal::parentInScope): Added.
(WebCore::NodeRenderingTraversal::lastChildInScope): Added.

  • dom/NodeRenderingTraversal.h:

(NodeRenderingTraversal):

  • dom/TreeScope.cpp:
  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::attach):

  • page/EventHandler.cpp:
  • page/FocusController.cpp: Replacing CSTW with NRT

(WebCore):
(WebCore::FocusNavigationScope::focusNavigationScopeOf):
(WebCore::FocusController::findNodeWithExactTabIndex):
(WebCore::nextNodeWithGreaterTabIndex):
(WebCore::previousNodeWithLowerTabIndex):
(WebCore::FocusController::nextFocusableNode):
(WebCore::FocusController::previousFocusableNode):

9:29 AM Changeset in webkit [139324] by zandobersek@gmail.com
  • 17 edits in trunk

Remove the ENABLE_ANIMATION_API feature define occurences
https://bugs.webkit.org/show_bug.cgi?id=106544

Reviewed by Simon Fraser.

The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
feature define handling still lingers in various build systems and configurations
but is of no use, so it should be removed.

.:

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests - no new functionality.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.features.am.in:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:
9:27 AM Changeset in webkit [139323] by Dimitri Glazkov
  • 149 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r139227.
http://trac.webkit.org/changeset/139227
https://bugs.webkit.org/show_bug.cgi?id=106227

Broke Win component build.

  • public/WebAccessibilityObject.h:
  • public/WebAccessibilityRole.h:
  • public/WebActiveWheelFlingParameters.h:
  • public/WebAnimationController.h:
  • public/WebApplicationCacheHost.h:
  • public/WebApplicationCacheHostClient.h:
  • public/WebArrayBuffer.h:
  • public/WebAudioSourceProvider.h:
  • public/WebBatteryStatus.h:
  • public/WebBindings.h:
  • public/WebBlob.h:
  • public/WebCache.h:
  • public/WebCachedURLRequest.h:
  • public/WebColorChooser.h:
  • public/WebColorChooserClient.h:
  • public/WebColorName.h:
  • public/WebCommonWorkerClient.h:
  • public/WebCompositionUnderline.h:
  • public/WebCompositorInputHandler.h:
  • public/WebConsoleMessage.h:
  • public/WebContentDetectionResult.h:
  • public/WebContextMenuData.h:
  • public/WebCrossOriginPreflightResultCache.h:
  • public/WebCursorInfo.h:
  • public/WebDOMEvent.h:
  • public/WebDOMEventListener.h:
  • public/WebDOMStringList.h:
  • public/WebDataSource.h:
  • public/WebDatabase.h:
  • public/WebDateTimeChooserCompletion.h:
  • public/WebDateTimeChooserParams.h:
  • public/WebDeliveredIntentClient.h:
  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h:
  • public/WebDevToolsFrontend.h:
  • public/WebDeviceOrientationClient.h:
  • public/WebDeviceOrientationClientMock.h:
  • public/WebDeviceOrientationController.h:
  • public/WebDocument.h:
  • public/WebDraggableRegion.h:
  • public/WebExternalPopupMenuClient.h:
  • public/WebFileChooserCompletion.h:
  • public/WebFileChooserParams.h:
  • public/WebFileSystemCallbacks.h:
  • public/WebFileSystemEntry.h:
  • public/WebFileWriter.h:
  • public/WebFileWriterClient.h:
  • public/WebFindOptions.h:
  • public/WebFont.h:
  • public/WebFontCache.h:
  • public/WebFontDescription.h:
  • public/WebFormControlElement.h:
  • public/WebFormElement.h:
  • public/WebFrame.h:
  • public/WebFrameClient.h:
  • public/WebGeolocationClientMock.h:
  • public/WebGeolocationController.h:
  • public/WebGeolocationError.h:
  • public/WebGeolocationPermissionRequest.h:
  • public/WebGeolocationPermissionRequestManager.h:
  • public/WebGeolocationPosition.h:
  • public/WebGlyphCache.h:
  • public/WebHelperPlugin.h:
  • public/WebHistoryItem.h:
  • public/WebHitTestResult.h:
  • public/WebIDBCallbacks.h:
  • public/WebIDBCursor.h:
  • public/WebIDBDatabase.h:
  • public/WebIDBDatabaseCallbacks.h:
  • public/WebIDBDatabaseError.h:
  • public/WebIDBFactory.h:
  • public/WebIDBIndex.h:
  • public/WebIDBKey.h:
  • public/WebIDBKeyPath.h:
  • public/WebIDBKeyRange.h:
  • public/WebIDBMetadata.h:
  • public/WebIDBObjectStore.h:
  • public/WebIDBTransaction.h:
  • public/WebIDBTransactionCallbacks.h:
  • public/WebIconURL.h:
  • public/WebImageDecoder.h:
  • public/WebInputEvent.h:
  • public/WebIntent.h:
  • public/WebIntentRequest.h:
  • public/WebIntentServiceInfo.h:
  • public/WebMediaPlayer.h:
  • public/WebMediaStreamRegistry.h:
  • public/WebMenuItemInfo.h:
  • public/WebNetworkStateNotifier.h:
  • public/WebNode.h:
  • public/WebNodeCollection.h:
  • public/WebNodeList.h:
  • public/WebNotification.h:
  • public/WebNotificationPresenter.h:
  • public/WebOptionElement.h:
  • public/WebPageOverlay.h:
  • public/WebPagePopup.h:
  • public/WebPageSerializer.h:
  • public/WebPasswordFormData.h:
  • public/WebPerformance.h:
  • public/WebPlugin.h:
  • public/WebPluginContainer.h:
  • public/WebPluginParams.h:
  • public/WebPopupMenu.h:
  • public/WebPopupMenuInfo.h:
  • public/WebPrerendererClient.h:
  • public/WebPrintParams.h:
  • public/WebRange.h:
  • public/WebRegularExpression.h:
  • public/WebRuntimeFeatures.h:
  • public/WebScopedMicrotaskSuppression.h:
  • public/WebScopedUserGesture.h:
  • public/WebScriptController.h:
  • public/WebScriptSource.h:
  • public/WebSearchableFormData.h:
  • public/WebSecurityOrigin.h:
  • public/WebSecurityPolicy.h:
  • public/WebSelectElement.h:
  • public/WebSettings.h:
  • public/WebSharedWorker.h:
  • public/WebSharedWorkerRepository.h:
  • public/WebSpeechGrammar.h:
  • public/WebSpeechInputController.h:
  • public/WebSpeechInputResult.h:
  • public/WebSpeechRecognitionHandle.h:
  • public/WebSpeechRecognitionParams.h:
  • public/WebSpeechRecognitionResult.h:
  • public/WebSpeechRecognizer.h:
  • public/WebSpeechRecognizerClient.h:
  • public/WebSpellCheckClient.h:
  • public/WebStorageEventDispatcher.h:
  • public/WebSurroundingText.h:
  • public/WebTestingSupport.h:
  • public/WebTextCheckingCompletion.h:
  • public/WebTextCheckingResult.h:
  • public/WebTextFieldDecoratorClient.h:
  • public/WebTextInputInfo.h:
  • public/WebTextRun.h:
  • public/WebTimeRange.h:
  • public/WebTouchPoint.h:
  • public/WebUserMediaRequest.h:
  • public/WebView.h:
  • public/WebViewBenchmarkSupport.h:
  • public/WebViewClient.h:
  • public/WebWidget.h:
  • public/WebWidgetClient.h:
  • public/WebWindowFeatures.h:
  • public/WebWorkerInfo.h:
8:48 AM Changeset in webkit [139322] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Serialization of Gradients fails when PlatformContextSkia is not bitmap backed
https://bugs.webkit.org/show_bug.cgi?id=106559

Patch by Robert Phillips <robertphillips@chromium.org> on 2013-01-10
Reviewed by Stephen White.

This patch switches over from having platform/Skia improperly
crack open the device to find the bitmap configuration to just
specifying it directly.

No new tests. This bug is Chromium specific and only occurs in a
debugging tool (when serializing to a Skia-specific file format).

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::createCompatibleDevice):

8:27 AM Changeset in webkit [139321] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

The "outline-offset" property is not found in the computed style property list
https://bugs.webkit.org/show_bug.cgi?id=106561

Reviewed by Alexis Menard.

Source/WebCore:

Listed CSSPropertyOutlineOffset in the CSSComputedStyleDeclaration's computedProperties[].

Test: fast/css/getComputedStyle/getComputedStyle-outline-offset.html

  • css/CSSComputedStyleDeclaration.cpp:

LayoutTests:

  • fast/css/getComputedStyle/getComputedStyle-outline-offset-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-outline-offset.html: Added.
8:20 AM WebKit Team edited by nghanavatian@rim.com
adding myself to committers list (diff)
7:53 AM Changeset in webkit [139320] by Lucas Forschler
  • 4 edits in tags/Safari-537.25.1/Source

Versioning.

7:51 AM Changeset in webkit [139319] by Lucas Forschler
  • 1 copy in tags/Safari-537.25.1

New Tag.

7:31 AM Changeset in webkit [139318] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

PluginPackage::freeLibraryTimerFired asserts if plugin got loaded again meanwhile
https://bugs.webkit.org/show_bug.cgi?id=106463

Patch by David Faure <faure@kde.org> on 2013-01-10
Reviewed by Simon Hausmann.

No new tests, this code path will be tested by bug 106140.

  • plugins/PluginPackage.cpp:

(WebCore::PluginPackage::freeLibraryTimerFired): skip unloading if loaded again meanwhile.

7:13 AM Changeset in webkit [139317] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

CSSParser does not allow the absence of whitespace between "and" and "expression"
https://bugs.webkit.org/show_bug.cgi?id=106458

Patch by Alexander Pavlov <apavlov@chromium.org> on 2013-01-10
Reviewed by Antti Koivisto.

  • fast/css/media-rule-no-whitespace-expected.txt: Added.
  • fast/css/media-rule-no-whitespace.html: Added.
6:40 AM Changeset in webkit [139316] by apavlov@chromium.org
  • 4 edits
    2 adds in trunk

CSSParser does not allow the absence of whitespace between "and" and "expression"
https://bugs.webkit.org/show_bug.cgi?id=106458

Reviewed by Antti Koivisto.

Source/WebCore:

The issue was that a construct similar to "and(max-width: 480px)" looks like a function call (token type FUNCTION), even though
it is actually a MEDIA_AND followed by a parenthesized expression.

Test: fast/css/media-rule-no-whitespace.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::detectFunctionTypeToken): Return if the detection has been successful.
(WebCore::CSSParser::realLex): Test for media query tokens if function type detection has failed.

  • css/CSSParser.h:

LayoutTests:

  • fast/css/media-rule-no-whitespace-expected.txt: Added.
  • fast/css/media-rule-no-whitespace.html: Added.
6:23 AM Changeset in webkit [139315] by fmalita@chromium.org
  • 162 edits
    1 move
    1 add in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaselining results after http://trac.webkit.org/changeset/139191.

  • platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-lion/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-mac-lion/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-mac-lion/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-mac-lion/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-mac-lion/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac-lion/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac-lion/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-lion/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-mac-lion/fast/layers/video-layer-expected.png:
  • platform/chromium-mac-lion/fast/regions/full-screen-video-from-region-expected.png:
  • platform/chromium-mac-lion/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-mac-lion/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac-lion/fast/transforms/shadows-expected.png:
  • platform/chromium-mac-lion/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac-lion/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png:
  • platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
  • platform/chromium-mac-lion/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-lion/media/audio-repaint-expected.png:
  • platform/chromium-mac-lion/media/controls-after-reload-expected.png:
  • platform/chromium-mac-lion/media/controls-layout-direction-expected.png:
  • platform/chromium-mac-lion/media/controls-strict-expected.png:
  • platform/chromium-mac-lion/media/controls-styling-expected.png:
  • platform/chromium-mac-lion/media/controls-styling-strict-expected.png:
  • platform/chromium-mac-lion/media/controls-without-preload-expected.png:
  • platform/chromium-mac-lion/media/media-controls-clone-expected.png:
  • platform/chromium-mac-lion/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-lion/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-lion/media/video-display-toggle-expected.png:
  • platform/chromium-mac-lion/media/video-empty-source-expected.png:
  • platform/chromium-mac-lion/media/video-no-audio-expected.png:
  • platform/chromium-mac-lion/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac-lion/media/video-zoom-controls-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-snowleopard/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-mac-snowleopard/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/layers/video-layer-expected.png:
  • platform/chromium-mac-snowleopard/fast/regions/full-screen-video-from-region-expected.png:
  • platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-layout-direction-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-styling-strict-expected.png:
  • platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
  • platform/chromium-mac-snowleopard/media/media-controls-clone-expected.png:
  • platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
  • platform/chromium-mac-snowleopard/media/video-empty-source-expected.png:
  • platform/chromium-mac-snowleopard/media/video-no-audio-expected.png:
  • platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-mac/fast/backgrounds/background-leakage-expected.png:
  • platform/chromium-mac/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png:
  • platform/chromium-mac/fast/box-shadow/spread-expected.png:
  • platform/chromium-mac/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-mac/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-mac/fast/layers/video-layer-expected.png:
  • platform/chromium-mac/fast/regions/full-screen-video-from-region-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac/fast/transforms/shadows-expected.png:
  • platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/audio-repaint-expected.png:
  • platform/chromium-mac/media/controls-after-reload-expected.png:
  • platform/chromium-mac/media/controls-layout-direction-expected.png:
  • platform/chromium-mac/media/controls-strict-expected.png:
  • platform/chromium-mac/media/controls-styling-expected.png:
  • platform/chromium-mac/media/controls-styling-strict-expected.png:
  • platform/chromium-mac/media/controls-without-preload-expected.png:
  • platform/chromium-mac/media/media-controls-clone-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-empty-source-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-playing-and-pause-expected.png:
  • platform/chromium-mac/media/video-zoom-controls-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-win/fast/backgrounds/background-leakage-expected.png:
  • platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
  • platform/chromium-win/fast/box-shadow/spread-expected.png:
  • platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-win/fast/css/shadow-multiple-expected.png:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-win/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-win/fast/layers/video-layer-expected.png:
  • platform/chromium-win/fast/regions/full-screen-video-from-region-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png:
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-layout-direction-expected.png:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-styling-strict-expected.png:
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/media-controls-clone-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-empty-source-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-playing-and-pause-expected.png:
  • platform/chromium-win/media/video-zoom-controls-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium/TestExpectations:
  • platform/efl-wk2/media/video-zoom-controls-expected.png: Renamed from LayoutTests/platform/efl/media/video-zoom-controls-expected.png.
6:01 AM Changeset in webkit [139314] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebCore/inspector/front-end/inspector.css

Merge 138166

Web Inspector: default font on mac is Monaco (should do be Menlo)
https://bugs.webkit.org/show_bug.cgi?id=105435

Reviewed by Alexander Pavlov.

Regressed when I introduced mountain lion modifier in the inspector.css.

  • inspector/front-end/inspector.css:

(body.platform-mac .monospace, body.platform-mac .source-code):
(body.platform-mac.platform-mac-tiger .source-code):

TBR=pfeldman@chromium.org
Review URL: https://codereview.chromium.org/11823053

5:46 AM Changeset in webkit [139313] by alexis@webkit.org
  • 4 edits
    2 adds in trunk

ASSERT_NOT_REACHED in StylePropertySet::fontValue when accessing font style property through JS after setting style font size.
https://bugs.webkit.org/show_bug.cgi?id=88866

Reviewed by Alexander Pavlov.

Source/WebCore:

StylePropertySet::fontValue always assumed that it was called using
style.font after a subsequent call which set the shorthand font. The
ASSERT_NOT_REACHED assumed that all longhands of the font shorthand not
set by the shorthand itself were set to initial. While it's true when
we set the font shorthand (i.e all longhands are set to implicit initial)
it is not true when you set the longhands individually. For example setting
font-size will not set other font properties to initial. It is the behavior of all
other shorthands in WebKit. When reconstructing the shorthand other
properties tests whether the value of each longhands is initial or not
(if not then we omit the value, as we should always construct the
shortest shorthand possible) or if the value is set or not (if set then
we include it in the shorthand if not then we omit it). The comment
removed was also talking about invalid font property potentially built
by fontValue(). So far appendFontLonghandValueIfExplicit will always
construct a valid value as it takes care of adding ' ' or '/' when
needed, so the return value is parsable and correct.

Test: fast/css/font-shorthand-from-longhands.html

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::appendFontLonghandValueIfExplicit):
(WebCore::StylePropertySet::fontValue):

  • css/StylePropertySet.h:

LayoutTests:

Add tests to cover the bug.

  • fast/css/font-shorthand-from-longhands-expected.txt: Added.
  • fast/css/font-shorthand-from-longhands.html: Added.
5:37 AM Changeset in webkit [139312] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Contents gets blurry when page is scrolled down
https://bugs.webkit.org/show_bug.cgi?id=106545

Reviewed by Kenneth Rohde Christiansen.

The bound values for scrolling also should be pixel aligned, otherwise
it leads to page contents blurriness when the page is scrolled down.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::pageDidRequestScroll):

4:28 AM Changeset in webkit [139311] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Marking one more flaky crasher due to gstreamer.

  • platform/efl/TestExpectations:
4:28 AM Changeset in webkit [139310] by loislo@chromium.org
  • 21 edits in trunk/Source/WebCore

Unreviewed, rolling out r139306.
http://trac.webkit.org/changeset/139306
https://bugs.webkit.org/show_bug.cgi?id=106550

it broke inspector-protocol/nmi-webaudio-leak-test.html
(Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-10

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::reportMemoryUsage):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::reportMemoryUsage):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::reportMemoryUsage):

  • css/MediaList.cpp:

(WebCore::MediaList::reportMemoryUsage):

  • css/RuleSet.cpp:

(WebCore::RuleData::reportMemoryUsage):
(WebCore::RuleSet::reportMemoryUsage):
(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::MatchedPropertiesCacheItem::reportMemoryUsage):
(WebCore::StyleResolver::reportMemoryUsage):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::reportMemoryUsage):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::reportMemoryUsage):

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::reportMemoryUsage):

  • inspector/InspectorMemoryAgent.cpp:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::reportMemoryUsage):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationClientImpl::reportMemoryUsage):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::reportMemoryUsage):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::reportMemoryUsage):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::reportMemoryUsage):

  • loader/Prerenderer.cpp:

(WebCore::Prerenderer::reportMemoryUsage):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::reportMemoryUsage):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::reportMemoryUsage):

  • page/Page.cpp:

(WebCore::Page::reportMemoryUsage):

4:25 AM Changeset in webkit [139309] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Marking three media tests as flaky crashers.

  • platform/efl/TestExpectations:
4:07 AM Changeset in webkit [139308] by Csaba Osztrogonác
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed gardening, paint the bots green.

  • platform/qt/TestExpectations: Skip http/tests/security/isolatedWorld/* tests instead of marking them as failures. (r138817)
  • platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.png: Added after r139197.
  • platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.txt: Added after r139197.
3:49 AM Changeset in webkit [139307] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Fix ietestcenter/css3/bordersbackgrounds/border-radius-clip-002.htm expectation lines

Unreviewed gardening.

  • platform/chromium/TestExpectations: Two bugs and expectation lines refer to this test, and one

expectation line overrides the other: assign to the earlier bug and ditch the redundant line.

3:31 AM Changeset in webkit [139306] by loislo@chromium.org
  • 21 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: fix instrumentation for already instrumented classes 2/N
https://bugs.webkit.org/show_bug.cgi?id=106546

Reviewed by Vsevolod Vlasov.

Many nontrivial class members were instrumented in reportMemoryUsage methods.

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::reportMemoryUsage):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::reportMemoryUsage):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::reportMemoryUsage):

  • css/MediaList.cpp:

(WebCore::MediaList::reportMemoryUsage):

  • css/RuleSet.cpp:

(WebCore::RuleData::reportMemoryUsage):
(WebCore::RuleSet::reportMemoryUsage):
(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::MatchedPropertiesCacheItem::reportMemoryUsage):
(WebCore::StyleResolver::reportMemoryUsage):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::reportMemoryUsage):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::reportMemoryUsage):

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::reportMemoryUsage):

  • inspector/InspectorMemoryAgent.cpp:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::reportMemoryUsage):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationClientImpl::reportMemoryUsage):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::reportMemoryUsage):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::reportMemoryUsage):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::reportMemoryUsage):

  • loader/Prerenderer.cpp:

(WebCore::Prerenderer::reportMemoryUsage):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::reportMemoryUsage):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::reportMemoryUsage):

  • page/Page.cpp:

(WebCore::Page::reportMemoryUsage):

3:27 AM Changeset in webkit [139305] by commit-queue@webkit.org
  • 19 edits
    4 copies
    12 adds in trunk

[GTK] Add support for loading web process extensions
https://bugs.webkit.org/show_bug.cgi?id=105631

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-01-10
Reviewed by Gustavo Noronha Silva.

.:

  • GNUmakefile.am: Add webkit2_web_extension_h_api.
  • Source/autotools/symbols.filter: Export WebGtkExtensionManager

symbols required by the injected bundle lib.

Source/WebKit2:

  • GNUmakefile.am: Link to libWebCoreDOM.la and build injected

bundle lib.

  • GNUmakefile.list.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(injectedBundleDirectory): Helper funtion to get the injected
bundle directory.
(injectedBundleFilename): Helper funtion to get the injected undle
library full path.
(createDefaultWebContext): Create the WebContext with an injected
bundle path.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_page_id): Return the identifier of the web
page associated to the web view.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new chapter for

web extensions.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/docs/webkit2gtk.types: Add new types.
  • UIProcess/API/gtk/tests/GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/gtk/tests/TestMain.cpp:

(main):

  • UIProcess/API/gtk/tests/TestWebExtensions.cpp: Added.

(testWebExtension):
(beforeAll):
(afterAll):

  • UIProcess/API/gtk/tests/WebExtensionTest.cpp: Added.

(methodCallCallback):
(webkit_web_extension_initialize):

  • UIProcess/API/gtk/tests/WebKitTestBus.cpp: Added.

(WebKitTestBus::WebKitTestBus):
(WebKitTestBus::run):
(WebKitTestBus::~WebKitTestBus):
(WebKitTestBus::connection):
(onNameAppeared):
(WebKitTestBus::createProxy):

  • UIProcess/API/gtk/tests/WebKitTestBus.h: Added.

(WebKitTestBus):

  • WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp: Added.

(_WebKitWebExtensionPrivate):
(webkitWebExtensionPageCreated): Create a WebKitWebPage for the
newly crated page and emit WebKitWebExtension::page-created
signals.
(webkitWebExtensionPageDestroy): Remove the page from the map.
(didCreatePage): Call webkitWebExtensionPageCreated().
(willDestroyPage): Call webkitWebExtensionPageDestroy().
(webkitWebExtensionCreate): Create a new WebKitWebExtension and
initialize the injected bundle client.
(webkit_web_extension_get_page): Return the WebKitWebPage for the
given page identifier.

  • WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.h: Added.

(_WebKitWebExtension):
(_WebKitWebExtensionClass):

  • WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionDefines.h: Added.
  • WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionPrivate.h: Added.
  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp: Added.

(_WebKitWebPagePrivate):
(webkit_web_page_class_init):
(webkitWebPageCreate): Create a new WebKitWebPage.
(webkit_web_page_get_dom_document): Return the WebKitDOMDocument
loaded in the WebKitWebPage.

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h: Added.

(_WebKitWebPage):
(_WebKitWebPageClass):

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPagePrivate.h: Added.
  • WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h: Added.
  • WebProcess/gtk/WebGtkExtensionManager.cpp: Added.

(WebKit::WebGtkExtensionManager::shared): Return the global shared
instance.
(WebKit::WebGtkExtensionManager::WebGtkExtensionManager):
(WebKit::WebGtkExtensionManager::appendModuleDirectories): Add
directories to scan for modules.
(WebKit::WebGtkExtensionManager::scanModules): Scan for modules.
(WebKit::WebGtkExtensionManager::initialize): Load and initialize
the modules found.

  • WebProcess/gtk/WebGtkExtensionManager.h: Added.
  • WebProcess/gtk/WebGtkInjectedBundleMain.cpp: Added.

(WKBundleInitialize): Initialize WebGtkExtensionManager.

Tools:

  • MiniBrowser/gtk/GNUmakefile.am:
  • MiniBrowser/gtk/main.c:

(main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
bundle lib from build dir.

  • Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API

located in WebProcess/InjectedBundle/API/gtk.

  • gtk/generate-gtkdoc:

(get_webkit2_options): Scan also files in
WebProcess/InjectedBundle/API/gtk to generate API docs.
(get_webkit2_options.injected_bundle_src_path): Helper function to
build paths in WebProcess/InjectedBundle/API/gtk.

3:14 AM Changeset in webkit [139304] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Remove lost-compositor-context layout tests
https://bugs.webkit.org/show_bug.cgi?id=106089

Unreviewed gardening.

  • platform/chromium/TestExpectations: Remove all references to the

lost-compositor-context test expectations after r138814.

3:04 AM Changeset in webkit [139303] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Tools

[EFL][WK2] Writing immediately to created windows (open) fails
https://bugs.webkit.org/show_bug.cgi?id=105276

Reviewed by Kenneth Rohde Christiansen.

Do not reset 'about:blank' url for the new pages in mini browser.

  • MiniBrowser/efl/main.c:

(window_create):

2:52 AM Changeset in webkit [139302] by noel.gordon@gmail.com
  • 2 edits
    1 delete in trunk/LayoutTests

[chromium] Optimize expectations for fast/forms/button-inner-block-reuse.html

Unreviewed gardening.

  • platform/chromium-win-xp/fast/forms/button-inner-block-reuse-expected.png: Removed.
  • platform/chromium-win/fast/forms/button-inner-block-reuse-expected.png:
2:47 AM EFLWebKit edited by Christophe Dumez
Remove gstreamer from dependencies since it is in jhbuild now and add … (diff)
2:42 AM Changeset in webkit [139301] by noel.gordon@gmail.com
  • 2 edits
    1 delete in trunk/LayoutTests

[chromium] Optimize expectaions for fast/forms/button-generated-content.html

Unreviewed gardening.

  • platform/chromium-win-xp/fast/forms/button-generated-content-expected.png: Removed.
  • platform/chromium-win/fast/forms/button-generated-content-expected.png:
1:59 AM Changeset in webkit [139300] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r139189): pixel alignment must be performed in device units.
https://bugs.webkit.org/show_bug.cgi?id=106504

Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-10
Reviewed by Kenneth Rohde Christiansen.

After r139189, pixel alignment is performed in UI units. If deviceScaleFactor is
fractional number, adjusted scroll position can blur non-composited layer.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::pixelAlignedFloatPoint):

1:58 AM Changeset in webkit [139299] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Changing tests to be consistent and use self.scm rather then recreating the scm object.
https://bugs.webkit.org/show_bug.cgi?id=106536

Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-10
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1:35 AM Changeset in webkit [139298] by dominik.rottsches@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

Marking a missing expectation for fast/repaint/caret-with-transformation.html

  • platform/efl/TestExpectations:
1:21 AM Changeset in webkit [139297] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Removing a few failure expectations that are no longer needed.
The tests the expectations were covering now pass.

  • platform/gtk/TestExpectations:
1:17 AM Changeset in webkit [139296] by zandobersek@gmail.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a platform-specific baseline for a CSS Regions test.
Adding a missing expectation for the fast/repaint/caret-with-transformation.html layout test.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/regions/selecting-text-through-different-region-flows-expected.txt: Added.
1:15 AM Changeset in webkit [139295] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Handle the case that start/end position is out of unclipped selection region
https://bugs.webkit.org/show_bug.cgi?id=106486

Patch by Yongxin Dai <yodai@rim.com> on 2013-01-10
Reviewed by Rob Buis.

PR #270624
Unclipped selection region should cover start/end position of the selection.
Since we exclude hidden text when calculating unclipped selection region, the
start/end position can be out of unclipped selection region if it is for hidden
text. If that is the case, start/end handle will be invisible. To avoid invisible
handle, we take unclipped selection region as reference rectangle in the case.

Internally reviewed by Genevieve Mak, Mike Fenton

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::referencePoint):

1:06 AM Changeset in webkit [139294] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Converting to unittest2 so we can use assertItemsEqual, making tests
not dependent on order of items.
https://bugs.webkit.org/show_bug.cgi?id=106532

Before:
Ran 1733 tests in 38.385s
FAILED (failures=1, errors=22)

After:
Ran 1733 tests in 32.298s
FAILED (failures=0, errors=22)

Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-10
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_unittest2):

12:59 AM Changeset in webkit [139293] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] [Gtk] web inspector is not visible.
https://bugs.webkit.org/show_bug.cgi?id=106050

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-01-10
Reviewed by Carlos Garcia Campos.

Use webkitWebViewBaseAddWebInspector when adding web inspector to
webview in order to make webview aware of its existence.

Use gtk_container_add when adding web inspector wiew to its own window
because m_inspectorWindow is not a WebKitWebViewBase.

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformAttach):

12:45 AM Changeset in webkit [139292] by Christophe Dumez
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Add platform expectation for new test added in r139197.

  • platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.png: Added.
  • platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.txt: Added.
12:42 AM Changeset in webkit [139291] by Christophe Dumez
  • 14 edits
    1 delete in trunk

[EFL] Add gstreamer 1.0.5 to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=106178

Reviewed by Laszlo Gombos.

.:

Update EFL CMake configuration to require gstreamer
1.0.5.

  • Source/cmake/FindGStreamer.cmake:
  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Remove GSTREAMER_INTERFACES_LIBRARIES from EFL
CMake configuration.

No new tests, no behavior change for layout tests.

  • PlatformEfl.cmake:

Source/WebKit:

Remove GSTREAMER_INTERFACES_LIBRARIES from EFL
CMake configuration.

  • PlatformEfl.cmake:

Source/WebKit/efl:

Fix compilation error when using gstreamer 1.0.

  • WebCoreSupport/FullscreenVideoControllerEfl.cpp:
  • WebCoreSupport/FullscreenVideoControllerEfl.h:

Tools:

Add gstreamer 1.0.5 to EFL's jhbuild configuration.

  • efl/jhbuild.modules:

LayoutTests:

Skip several media tests that are crashing with gstreamer 1.0.

  • platform/efl/TestExpectations:
  • platform/efl/media/sources-fallback-codecs-expected.txt: Removed.

Jan 9, 2013:

11:44 PM Changeset in webkit [139290] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r139266.

r139266 broke the debug build of the gstreamer backend due
to a missing header include.

No new tests, no behavior change.

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
11:33 PM Changeset in webkit [139289] by alecflett@chromium.org
  • 25 edits
    2 deletes in trunk/Source

IndexedDB: Allow createIndex/createObjectStore to be asynchronous
https://bugs.webkit.org/show_bug.cgi?id=106377

Reviewed by Tony Chang.

Source/WebCore:

Migrate implementations of createIndex/deleteIndex,
createObjectStore/deleteObjectStore over to IDBDatabaseBackendImpl,
so that they can be asynchronous in multi-process ports.

Has the side effect of removing the last consumers of
IDBIndexBackendImpl and IDBObjectStoreBackendImpl. The former
is removed complete and the latter becomes a temporary namespace
pending a further more mechanical code shuffle.

A key refactoring effect is that the IDBDatabaseBackendImpl
now contains the authoritative IDBDatabaseMetadata hierarchy,
and updates to it are consolidated in one place rather than
scattered across a parallel object tree.

No new tests as this is just refactoring.

  • Modules/indexeddb/IDBBackingStore.cpp: Simplify objectstore/index loading and propagate errors.

(WebCore::IDBBackingStore::getObjectStores):
(WebCore::IDBBackingStore::getIndexes):

  • Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

  • Modules/indexeddb/IDBCursorBackendImpl.cpp: Dependency cleanup.
  • Modules/indexeddb/IDBCursorBackendImpl.h: Dependency cleanup.

(WebCore):

  • Modules/indexeddb/IDBDatabase.cpp: Frontend IDBObjectStores no longer hold onto backend objects.

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Add all create/deleteIndex operations from IDBIndexBackendImpl.

(WebCore::CreateObjectStoreOperation::create):
(WebCore::CreateObjectStoreOperation::CreateObjectStoreOperation):
(CreateObjectStoreOperation):
(WebCore::DeleteObjectStoreOperation::create):
(WebCore::DeleteObjectStoreOperation::DeleteObjectStoreOperation):
(DeleteObjectStoreOperation):
(WebCore::CreateObjectStoreAbortOperation::create):
(WebCore::CreateObjectStoreAbortOperation::CreateObjectStoreAbortOperation):
(CreateObjectStoreAbortOperation):
(WebCore::DeleteObjectStoreAbortOperation::create):
(WebCore::DeleteObjectStoreAbortOperation::DeleteObjectStoreAbortOperation):
(DeleteObjectStoreAbortOperation):
(CreateIndexOperation):
(WebCore::CreateIndexOperation::create):
(WebCore::CreateIndexOperation::CreateIndexOperation):
(WebCore):
(DeleteIndexOperation):
(WebCore::DeleteIndexOperation::create):
(WebCore::DeleteIndexOperation::DeleteIndexOperation):
(CreateIndexAbortOperation):
(WebCore::CreateIndexAbortOperation::create):
(WebCore::CreateIndexAbortOperation::CreateIndexAbortOperation):
(DeleteIndexAbortOperation):
(WebCore::DeleteIndexAbortOperation::create):
(WebCore::DeleteIndexAbortOperation::DeleteIndexAbortOperation):
(WebCore::GetOperation::GetOperation):
(WebCore::IDBDatabaseBackendImpl::addObjectStore):
(WebCore::IDBDatabaseBackendImpl::removeObjectStore):
(WebCore::IDBDatabaseBackendImpl::addIndex):
(WebCore::IDBDatabaseBackendImpl::removeIndex):
(WebCore::IDBDatabaseBackendImpl::openInternal):
(WebCore::IDBDatabaseBackendImpl::metadata):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::CreateObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::createIndex):
(WebCore::CreateIndexOperation::perform):
(WebCore::CreateIndexAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteIndex):
(WebCore::DeleteIndexOperation::perform):
(WebCore::DeleteIndexAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::get):
(WebCore::IDBDatabaseBackendImpl::put):
(WebCore::IDBDatabaseBackendImpl::setIndexKeys):
(WebCore::IDBDatabaseBackendImpl::count):
(WebCore::DeleteRangeOperation::perform):
(WebCore::DeleteObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteDatabaseFinal):
(WebCore::IDBDatabaseBackendImpl::loadObjectStores): Load directly into metadata from backing store.
(WebCore::CreateObjectStoreAbortOperation::perform):
(WebCore::DeleteObjectStoreAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::perform):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(WebCore):
(IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp: Removed.
  • Modules/indexeddb/IDBIndexBackendImpl.h: Removed.
  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::IDBObjectStore): Frontend IDBIndex objects no longer hold onto backend.
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::deleteIndex):

  • Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::create):
(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(WebCore):
(IDBObjectStoreBackendImpl):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):

  • Modules/indexeddb/IDBTransaction.h:
  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:
  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(WebCore::IDBTransactionBackendImpl::objectStore):

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

Remove this test as it makes no sense once the objectstore/index
hierarchy is gone.

  • tests/IDBDatabaseBackendTest.cpp:
11:26 PM Changeset in webkit [139288] by noel.gordon@gmail.com
  • 1 edit
    1 add in trunk/LayoutTests

New chromium-mac pixel baseline for gradient-background-leakage-hidpi.html
https://bugs.webkit.org/show_bug.cgi?id=106373

Unreviewed gardening.

  • platform/chromium-mac/fast/backgrounds/gradient-background-leakage-hidpi-expected.png: Added.
11:07 PM Changeset in webkit [139287] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][EFL] Add guard around NativeWebTouchEvent
https://bugs.webkit.org/show_bug.cgi?id=105846

Patch by Seokju Kwon <Seokju Kwon> on 2013-01-09
Reviewed by Benjamin Poulain.

Fix EFL build without TOUCH_EVENTS.

  • Shared/efl/NativeWebTouchEventEfl.cpp: Add TOUCH_EVENTS guard.
11:05 PM Changeset in webkit [139286] by noel.gordon@gmail.com
  • 1 edit
    1 move
    1 add
    1 delete in trunk/LayoutTests

Update expectations for fast/forms/button-generated-content.html

Unreviewed gardening.

  • fast/forms/button-generated-content-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/forms/button-generated-content-expected.txt.
  • platform/chromium-win-xp/fast/forms/button-generated-content-expected.png: Added.
  • platform/mac/fast/forms/button-generated-content-expected.txt: Removed.
11:05 PM Changeset in webkit [139285] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Don't throw exceptions when we don't have a callstack
https://bugs.webkit.org/show_bug.cgi?id=104849

Patch by John J. Barton <johnjbarton@chromium.org> on 2013-01-09
Reviewed by Pavel Feldman.

Check array details.callFrames.length before accessing array;

No new tests, but this fix may help us find the cause of 'other' reasons.

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._debuggerPaused):

10:52 PM Changeset in webkit [139284] by noel.gordon@gmail.com
  • 1 edit
    1 move
    1 add
    1 delete in trunk/LayoutTests

Update expectations for fast/forms/button-inner-block-reuse.html

Unreviewed gardening.

  • fast/forms/button-inner-block-reuse-expected.txt: Renamed from LayoutTests/platform/chromium/fast/forms/button-inner-block-reuse-expected.txt.
  • platform/chromium-win-xp/fast/forms/button-inner-block-reuse-expected.png: Added.
  • platform/mac/fast/forms/button-inner-block-reuse-expected.txt: Removed.
10:28 PM Changeset in webkit [139283] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Network] Data grid header and content cells are misaligned.
https://bugs.webkit.org/show_bug.cgi?id=105795

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-09
Reviewed by Pavel Feldman.

Header and content tables have different width -> same percent values
turn to different cell widths.

  • inspector/front-end/DataGrid.js: Add "corner" cell to all rows.
  • inspector/front-end/dataGrid.css: Apply "corner" rules to "td" nodes.

(.data-grid .data-container): Remove artificial padding.

10:23 PM Changeset in webkit [139282] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk

Make caret repainting container-aware
https://bugs.webkit.org/show_bug.cgi?id=103955

Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-01-09
Reviewed by Simon Fraser.

Source/WebCore:

Only invalidate local rects on the caret's repaint container,
instead of invalidating an absolute rect on the whole view.

Test: fast/repaint/caret-with-transformation.html

  • editing/FrameSelection.cpp:

(WebCore::caretRendersInsideNode):
(WebCore::caretRenderer):
(WebCore::FrameSelection::caretRenderer):
(WebCore::DragCaretController::caretRenderer):
(WebCore::repaintCaretForLocalRect):
(WebCore::FrameSelection::recomputeCaretRect):
(WebCore::CaretBase::invalidateCaretRect):
(WebCore::FrameSelection::focusedOrActiveStateChanged):

  • editing/FrameSelection.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::repaintSelection):

  • rendering/RenderView.h:

LayoutTests:

The caret repaint padding has been removed. Needs rebaseline.
Added test that carets should be repainted correctly on a transformed element.

  • fast/repaint/caret-with-transformation.html: Added.
  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
9:57 PM Changeset in webkit [139281] by noel.gordon@gmail.com
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Add win mac expectations for r139256
https://bugs.webkit.org/show_bug.cgi?id=106404

Unreviewed gardening.

  • platform/chromium-mac/fast/borders/border-radius-with-box-shadow-expected.png: Added.
  • platform/chromium-win/fast/borders/border-radius-with-box-shadow-expected.png: Added.
9:53 PM Changeset in webkit [139280] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Rebaseline the binding test after r139278.

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTarget::getOwnPropertySlot):

8:41 PM Changeset in webkit [139279] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Updated parameters in GCE build scripts so they now work.
https://bugs.webkit.org/show_bug.cgi?id=106523

Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-09
Reviewed by Adam Barth.

  • EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
  • EWSTools/GoogleComputeEngine/build-commit-queue.sh:
  • EWSTools/cold-boot.sh:
7:55 PM Changeset in webkit [139278] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

[JSC] REGRESSION(r135093): A form control with name=length overrides length property on form.elements
https://bugs.webkit.org/show_bug.cgi?id=105775

Reviewed by Sam Weinig.

Source/WebCore:

Fixed the bug by respecting properties on ancestor classes.

Test: fast/dom/collection-length-should-not-be-overridden.html

  • bindings/js/JSDOMBinding.h:

(WebCore::getStaticValueSlotEntryWithoutCaching): Added.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody): Use getStaticValueSlotEntryWithoutCaching to climb up the class
hierarchy.

LayoutTests:

Added a regression tests for all known HTMLCollection sublcasses except HTMLNameCollection,
which is used only to implement named getters on window and document objects and HTMLPropertiesCollection
since it's not enabled on all ports yet.

  • fast/dom/collection-length-should-not-be-overridden-expected.txt: Added.
  • fast/dom/collection-length-should-not-be-overridden.html: Added.
7:44 PM Changeset in webkit [139277] by pilgrim@chromium.org
  • 3 edits in trunk/Tools

[Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=106520

Reviewed by James Robinson.

Part of a larger refactoring series. See tracking bug 82948.

  • DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
  • DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
7:42 PM Changeset in webkit [139276] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[EFL] [WebGL] Remove GLX dependencies from X11WindowResources..
https://bugs.webkit.org/show_bug.cgi?id=106319

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-01-09
Reviewed by Kenneth Rohde Christiansen.

This patch removes GLX specific calls from X11WindowResources.
This class is shared by both GLX and EGL implementations.

  • platform/graphics/surfaces/glx/GLXSurface.cpp:

(WebCore::GLXTransportSurface::setGeometry):

  • platform/graphics/surfaces/glx/X11WindowResources.cpp:

(WebCore::X11OffScreenWindow::reSizeWindow):

7:33 PM Changeset in webkit [139275] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Remove deviceScaleFactor argument in computeMinimumScaleFactorForContentContained().
https://bugs.webkit.org/show_bug.cgi?id=106500

Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-09
Reviewed by Kenneth Rohde Christiansen.

deviceScaleFactor argument is not used after r139189.

Source/WebCore:

No new tests. Refactoring only.

  • dom/ViewportArguments.cpp:

(WebCore::computeMinimumScaleFactorForContentContained):

  • dom/ViewportArguments.h:

(WebCore):

Source/WebKit2:

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::updateMinimumScaleToFit):

7:11 PM Changeset in webkit [139274] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[QT][EFL][WK2] Rename scale members in PageViewportController.
https://bugs.webkit.org/show_bug.cgi?id=106499

Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-09
Reviewed by Kenneth Rohde Christiansen.

Rename from m_contentsScale to m_pageScaleFactor and from devicePixelRatio() to
deviceScaleFactor() to match terms of WebCore.

  • UIProcess/API/qt/qwebkittest.cpp:

(QWebKitTest::devicePixelRatio):

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::deviceScaleFactor):
(WebKit::PageViewportController::pixelAlignedFloatPoint):
(WebKit::PageViewportController::boundContentsPosition):
(WebKit::PageViewportController::didRenderFrame):
(WebKit::PageViewportController::didChangeContentsVisibility):
(WebKit::PageViewportController::syncVisibleContents):
(WebKit::PageViewportController::visibleContentsSize):
(WebKit::PageViewportController::applyScaleAfterRenderingContents):
(WebKit::PageViewportController::updateMinimumScaleToFit):

  • UIProcess/PageViewportController.h:

(PageViewportController):
(WebKit::PageViewportController::currentContentsScale):

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::updateViewportSize):

6:51 PM Changeset in webkit [139273] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Node::containingShadowRoot should be constant time
https://bugs.webkit.org/show_bug.cgi?id=106494

Patch by Elliott Sprehn <Elliott Sprehn> on 2013-01-09
Reviewed by Dimitri Glazkov.

There's no reason to traverse up the tree to find the containing
ShadowRoot when we already know if we're in a ShadowRoot by looking at
the treeScope().

No new tests, just refactoring.

  • dom/Node.cpp:

(WebCore::Node::containingShadowRoot):

6:50 PM Changeset in webkit [139272] by jparent@chromium.org
  • 2 edits in trunk/Tools

Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
https://bugs.webkit.org/show_bug.cgi?id=106514

This is old code, as these can no longer get out of sync.
permmaLinkURLHash is generated from currentState, which is set only
from the location. The commment about how these can get out of sync
refers to a function that no longer exists.

Reviewed by Dirk Pranke.

  • TestResultServer/static-dashboards/dashboard_base.js:

(handleLocationChange):

6:41 PM Changeset in webkit [139271] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

6:35 PM Changeset in webkit [139270] by jparent@chromium.org
  • 2 edits in trunk/Tools

Dashboard Cleanup: Reload the page as soon as we know we need to.
https://bugs.webkit.org/show_bug.cgi?id=106515

No need to continue parsing all of the data once we know that
we need to do a reload.

Reviewed by Dirk Pranke.

  • TestResultServer/static-dashboards/dashboard_base.js:

(parseParameters):

6:29 PM Changeset in webkit [139269] by morrita@google.com
  • 17 edits in trunk

[Shadow DOM] Distribution related code on ElementShadow should be minimized.
https://bugs.webkit.org/show_bug.cgi?id=106294

Reviewed by Dimitri Glazkov.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

This change moves ElementShadow::m_selectFeatures,
m_shouldCollectSelectFeatureSet and related methods to
ContentDistributor.

There are also some renaming and small refactorings for better fit
on new place:

  • shouldCollectSelectFeatureSet is renamed needsSelectorRuleSet for conciseness.
  • setShouldCollectSelectFeatureSet() which used recursion morphed into iterative willAffectSelector().
  • ensureDistributionFromDocument() becomes a static method.

No new tests. Refactoring.

  • WebCore.exp.in:
  • dom/Element.cpp:

(WebCore::Element::shouldInvalidateDistributionWhenAttributeChanged):

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::addShadowRoot):
(WebCore::ElementShadow::removeAllShadowRoots):

  • dom/ElementShadow.h:

(ElementShadow):
(WebCore::ElementShadow::invalidateDistribution):
(WebCore::ElementShadow::ensureDistribution):
(WebCore::ElementShadow::didAffectSelector):
(WebCore::ElementShadow::willAffectSelector):
(WebCore::ElementShadow::containingShadow):
(WebCore):

  • html/shadow/ContentDistributor.cpp:

(WebCore::ScopeContentDistribution::registerInsertionPoint):
(WebCore::ScopeContentDistribution::unregisterInsertionPoint):
(WebCore::ContentDistributor::ContentDistributor):
(WebCore::ContentDistributor::ensureDistribution):
(WebCore):
(WebCore::ContentDistributor::ensureDistributionFromDocument):
(WebCore::ContentDistributor::invalidateDistribution):
(WebCore::ContentDistributor::ensureSelectFeatureSet):
(WebCore::ContentDistributor::collectSelectFeatureSetFrom):
(WebCore::ContentDistributor::didAffectSelector):
(WebCore::ContentDistributor::willAffectSelector):
(WebCore::ContentDistributor::didShadowBoundaryChange):

  • html/shadow/ContentDistributor.h:

(ScopeContentDistribution):
(WebCore::ContentDistributor::needsSelectFeatureSet):
(WebCore::ContentDistributor::setNeedsSelectFeatureSet):
(ContentDistributor):
(WebCore::ContentDistributor::setValidity):
(WebCore::ContentDistributor::needsInvalidation):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::parseAttribute):

  • html/shadow/HTMLContentElement.h:
  • html/shadow/HTMLShadowElement.cpp:

(WebCore::HTMLShadowElement::olderShadowRoot):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::getDistributedNodes):
(WebCore::InsertionPoint::insertedInto):
(WebCore::InsertionPoint::removedFrom):

  • html/shadow/InsertionPoint.h:

(WebCore::InsertionPoint::canAffectSelector):

  • testing/Internals.cpp:

(WebCore::Internals::hasSelectorForIdInShadow):
(WebCore::Internals::hasSelectorForClassInShadow):
(WebCore::Internals::hasSelectorForAttributeInShadow):
(WebCore::Internals::hasSelectorForPseudoClassInShadow):

Source/WebKit/win:

  • WebKit.vcproj/WebKit.def.in:
6:26 PM Changeset in webkit [139268] by Lucas Forschler
  • 1 copy in tags/Safari-537.25

New Tag.

6:24 PM Changeset in webkit [139267] by shinyak@chromium.org
  • 3 edits
    2 adds in trunk

Assert triggered in SelectorChecker::checkOneSelector when scrollbar (e.g. :horizontal) selector is specified.
https://bugs.webkit.org/show_bug.cgi?id=106414

Reviewed by Dimitri Glazkov.

Source/WebCore:

In SelectorChecker::checkOneSelector, scrollbar related pseudoType (e.g. :horizontal) is not handled anywhere.
This caused ASSERT triggered. We have to check them.

Test: fast/css/scrollbar-crash.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector):

LayoutTests:

  • fast/css/scrollbar-crash-expected.txt: Added.
  • fast/css/scrollbar-crash.html: Added.
6:16 PM Changeset in webkit [139266] by fpizlo@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix build after http://trac.webkit.org/changeset/139262

  • Modules/webaudio/DefaultAudioDestinationNode.cpp:
6:07 PM Changeset in webkit [139265] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Just move the JavaScriptCore exports file around in the vcproj to make things clearer.

5:59 PM Changeset in webkit [139264] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Dont use a node reference after appending to the graph.
https://bugs.webkit.org/show_bug.cgi?id=103305
<rdar://problem/12753096>

Reviewed by Mark Hahnenberg.

  • dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

5:56 PM Changeset in webkit [139263] by eric@webkit.org
  • 3 edits in trunk/Tools

run-perf-tests --chromium-android --profile should show symbols for the kernel
https://bugs.webkit.org/show_bug.cgi?id=106498

Reviewed by Adam Barth.

Turns out this was easy, once I finally read the output from "perf report".
It appears there may be a bug in "perf record" on android, as it complains
about not being able to read from /proc/kallsyms even when
/proc/sys/kernel/kptr_restrict is 0. For now I've not bothered
to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
but rather just flip it to 0 long enough to grab the /proc/kallsyms
and then flip it back to whatever the device had.

/proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
on Linux. /proc/kallsyms contains a mapping of kernel addresses
to symbol names. Its world-readable, but will return all 0s if you
don't have permission to see the kernel symbols. kptr_restrict
supports values 0, 1, 2. Where 0 means "everyone can see the real symbols"
1 is only a specific group, and 2 is "no one, not even root".
By default kptr_restrict is 2 on Android it seems.
More kptr_restrict docs: http://lwn.net/Articles/420403/

I also took this opportunity to clean up how the perf record command
was built for use/display in AndroidPerf.profile_after_exit and
change to always using long-form names for the arguments (to hopefully help readability).

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(AndroidPerf.init):
(profile_after_exit):
(ChromiumAndroidDriver.init):
(ChromiumAndroidDriver._update_kallsyms_cache):

  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
5:40 PM Changeset in webkit [139262] by crogers@google.com
  • 14 edits in trunk/Source

Allow live/local audio input to be enabled only when needed
https://bugs.webkit.org/show_bug.cgi?id=106490

Source/Platform:

Reviewed by Kenneth Russell.

  • chromium/public/Platform.h:

(Platform):
(WebKit::Platform::createAudioDevice):

Source/WebCore:

Reviewed by Kenneth Russell.

WebAudio can process live/local audio input using a MediaStreamAudioSourceNode.
But currently the audio back-end is not able to know when/if audio input will be
needed, so it needs to assume the worst and initialize the system to support potential
audio input in all cases. For some audio back-ends this can end up being less efficient
than initializing for audio output only. This patch adds the ability for the audio back-end
to be able to initialize itself for audio input later on, only when/if it's needed.

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaStreamSource):

  • Modules/webaudio/AudioDestinationNode.h:

(AudioDestinationNode):

  • Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):
(WebCore::DefaultAudioDestinationNode::initialize):
(WebCore::DefaultAudioDestinationNode::uninitialize):
(WebCore::DefaultAudioDestinationNode::createDestination):
(WebCore):
(WebCore::DefaultAudioDestinationNode::enableInput):

  • Modules/webaudio/DefaultAudioDestinationNode.h:

(DefaultAudioDestinationNode):

  • Modules/webaudio/OfflineAudioDestinationNode.h:

(OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::sampleRate):

  • platform/audio/AudioDestination.h:

(AudioDestination):

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestination::create):

  • platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestination::create):

Source/WebKit/chromium:

Reviewed by Kenneth Russell.

  • src/AudioDestinationChromium.cpp:

(WebCore):
(WebCore::AudioDestination::create):
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestinationChromium::render):

  • src/AudioDestinationChromium.h:

(AudioDestinationChromium):

5:33 PM Changeset in webkit [139261] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

[WK2][soup] Get rid of LocalTerminationDisabler
https://bugs.webkit.org/show_bug.cgi?id=106510

Unreviewed build fix.

With r139257(bug 106501), the LocalTerminationDisabler was removed from WebKit::ChildProcess.
So, it should be removed on setCookiePersistentStorage, too.

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2013-01-09

  • WebProcess/Cookies/soup/WebCookieManagerSoup.cpp:

(WebKit::WebCookieManager::setCookiePersistentStorage):

5:33 PM Changeset in webkit [139260] by jparent@chromium.org
  • 2 edits in trunk/Tools

Dashboard cleanup: remove dead code.
https://bugs.webkit.org/show_bug.cgi?id=106509

Reviewed by Dirk Pranke.

  • TestResultServer/static-dashboards/dashboard_base.js:

(parseParameters):

5:00 PM Changeset in webkit [139259] by roger_fong@apple.com
  • 10 edits
    2 moves in trunk/Source

Rename export files to make them more easily findable.
https://bugs.webkit.org/show_bug.cgi?id=98695.

Reviewed by Timothy Horton.

  • WebKit.vcproj/WebKit.def.in: Removed.
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitExportGenerator.vcproj:
  • WebKit.vcproj/WebKitExportGeneratorBuildCmd.cmd:
  • WebKit.vcproj/WebKitExportGeneratorPostBuild.cmd:
  • WebKit.vcproj/WebKitExportGeneratorPreBuild.cmd:
  • WebKit.vcproj/WebKitExports.def.in: Copied from Source/WebKit/win/WebKit.vcproj/WebKit.def.in.
  • WebKit.vcproj/WebKitLibCommon.vsprops:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def: Copied from Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def.
4:50 PM Changeset in webkit [139258] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Don't drop to huge tile mode if we're only slow-scrolling because of a page overlay
https://bugs.webkit.org/show_bug.cgi?id=106502
<rdar://problem/12959143>

Reviewed by Simon Fraser.

We only use the MainThreadScrollingReason "ForcedOnMainThread" if WebKit2 installs
a page overlay (TiledCoreAnimationDrawingArea::didInstallPageOverlay), which clients
can cause arbitrarily.

We probably should still use default-sized tiles in this case (this will also
prevent us from falling into gigantic tiles for WebKit2 find-in-page, among other things).

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::adjustTileCacheCoverage):

4:46 PM Changeset in webkit [139257] by ap@apple.com
  • 9 edits in trunk/Source/WebKit2

[WK2] Get rid of LocalTerminationDisabler
https://bugs.webkit.org/show_bug.cgi?id=106501

Reviewed by Anders Carlsson.

LocalTerminationDisabler is no-op - termination timer can't fire inside its scope
even if not stopped.

  • PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::getSitesWithData): (WebKit::PluginProcess::clearSiteData):
  • Shared/ChildProcess.h:
  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp: (WebKit::WebApplicationCacheManager::getApplicationCacheOrigins): (WebKit::WebApplicationCacheManager::deleteEntriesForOrigin): (WebKit::WebApplicationCacheManager::deleteAllEntries): (WebKit::WebApplicationCacheManager::setAppCacheMaximumSize):
  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp: (WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins): (WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin): (WebKit::WebKeyValueStorageManager::deleteAllEntries):
  • WebProcess/MediaCache/WebMediaCacheManager.cpp: (WebKit::WebMediaCacheManager::getHostnamesWithMediaCache): (WebKit::WebMediaCacheManager::clearCacheForHostname): (WebKit::WebMediaCacheManager::clearCacheForAllHostnames):
  • WebProcess/ResourceCache/WebResourceCacheManager.cpp: (WebKit::WebResourceCacheManager::getCacheOrigins): (WebKit::WebResourceCacheManager::clearCacheForOrigin): (WebKit::WebResourceCacheManager::clearCacheForAllOrigins):
  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp: (WebKit::WebDatabaseManager::getDatabasesByOrigin): (WebKit::WebDatabaseManager::getDatabaseOrigins): (WebKit::WebDatabaseManager::deleteDatabaseWithNameForOrigin): (WebKit::WebDatabaseManager::deleteDatabasesForOrigin): (WebKit::WebDatabaseManager::deleteAllDatabases): (WebKit::WebDatabaseManager::setQuotaForOrigin):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::getSitesWithPluginData): (WebKit::WebProcess::clearPluginSiteData):
4:44 PM Changeset in webkit [139256] by tasak@google.com
  • 3 edits
    3 adds in trunk

border-radius with box-shadow is not rendered correctly
https://bugs.webkit.org/show_bug.cgi?id=106404

Reviewed by Hajime Morita.

Source/WebCore:

RoundedRect::isRenderable is wrong. So RoundedRect::adjustRadii
is invoked for renderable RoundedRects.

Test: fast/borders/border-radius-with-box-shadow.html

  • platform/graphics/RoundedRect.cpp:

(WebCore::RoundedRect::isRenderable):
Have to compare topLeft's height plus bottomLeft's height with
rect's height and to compare topRight's height plus bottomRight's
height with rect's height.

LayoutTests:

  • fast/borders/border-radius-with-box-shadow-expected.txt: Added.
  • fast/borders/border-radius-with-box-shadow.html: Added.
  • platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png: Added.
4:39 PM Changeset in webkit [139255] by andersca@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Update a test result.

  • platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt:
4:32 PM Changeset in webkit [139254] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

Rebaseline fast/inline/continuation-outlines-with-layers.html
https://bugs.webkit.org/show_bug.cgi?id=106064.

Unreviewed.

Rebaseline after http://trac.webkit.org/changeset/139223.

  • platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt:
4:27 PM Changeset in webkit [139253] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Always enable autocomplete for password fields
https://bugs.webkit.org/show_bug.cgi?id=104600

Patch by Yue Zhang <zysxqn@google.com> on 2013-01-09
Reviewed by Darin Fisher.

Don't check autocomplete in webkit code. Rather, we check it in chrome code in the following way: if the password field is chrome generated password, we ignore autocomplete=off and always fill the password; otherwise, we respect the autocomplete set. Since this is a chrome only feature, we make it configurable (default to false but enable this in chrome code).

  • src/WebPasswordFormUtils.cpp:

(WebKit::findPasswordFormFields):

  • src/WebPasswordFormUtils.h:

(WebKit):
(WebKit::findPasswordFormFields):

4:18 PM Changeset in webkit [139252] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Add a notification when a WebWidget's WebLayerTreeView is about to go away
https://bugs.webkit.org/show_bug.cgi?id=106495

Patch by James Robinson <jamesr@chromium.org> on 2013-01-09
Reviewed by Adrienne Walker.

The WebWidget / WebLayerTreeView ownership is in a slightly awkward place. I'm moving the ownership
of the WebLayerTreeView to the WebWidgetClient, but to stage things sanely the WebLayerTreeView's
client is sill owned by the WebWidget implementation. Thus to shut down cleanly we need an explicit
notification to the WebWidget that the WebLayerTreeView is going to go away.

This API can go away once the WebWidget implementation does not provide the WebLayerTreeViewClient,
which will take a bit more refactoring.

  • public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::willCloseLayerTreeView):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::willCloseLayerTreeView):
(WebKit):

  • src/WebViewImpl.h:

(WebViewImpl):

4:17 PM Changeset in webkit [139251] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Ascribe a bug to a crash..

  • platform/chromium/TestExpectations: Ascribed.
4:09 PM Changeset in webkit [139250] by commit-queue@webkit.org
  • 13 edits
    1 add
    1 delete in trunk

[GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
https://bugs.webkit.org/show_bug.cgi?id=105638

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2013-01-09
Reviewed by Martin Robinson.

The test was failing for two reasons:

  • AccessibilityRenderObject::correspondingLabelForControlElement() was not ignoring the ARIA labelled-by property
  • AccessibilityController::accessibleElementById() was not implemented

Because getting an element by ID cannot be done in the UIProcess, the
decision was made to expose the element's ID as an accessible attribute
of the object.

In addition, fixing the bug in AccessibilityRenderObject made it possible
to eliminate the Gtk platform-specific expectations for another test.

Source/WebCore:

No new tests; instead, the failing test was unskipped and a proper baseline
provided.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::correspondingLabelForControlElement):
Return null for objects where hasTextAlternative() is true.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes): Expose the element's ID as an accessible
attribute.

Tools:

  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(childElementById): Added. Walks the tree looking for the AtkObject
Attribute which exposes the HTML element's ID.
(AccessibilityController::accessibleElementById): Implemented.

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::title): Modified to print out "AXTitle: " even
when there is no title, as is done with the Mac port.

  • WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:

(WTR):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:

(WTR::childElementById): Added. Walks the tree looking for the AtkObject
Attribute which exposes the HTML element's ID.
(WTR):
(WTR::AccessibilityController::accessibleElementById): Implemented.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
even when there is no title, as is done with the Mac port.

LayoutTests:

  • accessibility/aria-labelledby-overrides-label-expected.txt: Added.
  • accessibility/radio-button-title-label-expected.txt: Modified based on

null check which was added and which gets included in the test output.

  • accessibility/radio-button-title-label.html: Check to see that we have

a titleUIElement before attempting to get its title.

  • platform/gtk/TestExpectations: Unskipped the previously failing test.
  • platform/gtk/accessibility/radio-button-title-label-expected.txt: Removed.
3:25 PM ExportingSymbols edited by roger_fong@apple.com
(diff)
3:19 PM Changeset in webkit [139249] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unused includes from HTMLTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=106496

Reviewed by Levi Weintraub.

Noticed these while searching HTMLTreeBuilder for non-thread friendly deps.

No new tests because no new functionality.

  • html/parser/HTMLTreeBuilder.cpp:
3:13 PM Changeset in webkit [139248] by mvujovic@adobe.com
  • 6 edits
    3 adds in trunk

[CSS Shaders] Detached identifier after mesh box type is not applied
https://bugs.webkit.org/show_bug.cgi?id=105321

Reviewed by Dean Jackson.

Source/WebCore:

Before this patch, if a "detached" identifier followed a mesh box type identifier, the
detached identifier was not applied. In other words, the mesh would still be attached.

For example:
-webkit-filter: custom(url(...) mix(url(...) normal source-atop), 1 1 border-box detached);

Although the mesh box type is being removed from the Filter Effects spec, for now, we
continue to accept the mesh box type in parsing because of existing content. Eventually,
custom filters will transition to an at-rule syntax, once it is defined.

Test: css3/filters/custom/custom-filter-detached-mesh-with-mesh-box-type.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseCustomFilter):

In CSSParser, do not add the mesh box type identifier to the list that will be passed to
StyleResolver. StyleResolver is expecting a "detached" identifier in that position and
does not interpret mesh box types.

LayoutTests:

Add a test to verify that a "detached" identifier after a mesh box type identifier is
actually applied.

For example:
-webkit-filter: custom(url(...) mix(url(...) normal source-atop), 1 1 border-box detached);

Update parsing tests and expectations to expect that the mesh box type is not returned in
the cssText.

  • css3/filters/custom/custom-filter-detached-mesh-with-mesh-box-type-expected.html: Added.
  • css3/filters/custom/custom-filter-detached-mesh-with-mesh-box-type.html: Added.
  • css3/filters/custom/custom-filter-property-parsing-expected.txt:
  • css3/filters/script-tests/custom-filter-property-parsing.js:
  • css3/filters/resources/a-triangle-coord-defined.vs: Added.
  • platform/chromium/css3/filters/custom/custom-filter-property-parsing-expected.txt:
3:13 PM Changeset in webkit [139247] by gman@chromium.org
  • 2 edits in trunk/Tools

Add Gregg Tavares as a committer
https://bugs.webkit.org/show_bug.cgi?id=106492

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
3:12 PM Changeset in webkit [139246] by pilgrim@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove stray references to WebKitPlatformSupport.h
https://bugs.webkit.org/show_bug.cgi?id=106493

Reviewed by James Robinson.

Part of a refactoring series. See tracking bug 82948.

  • src/SharedWorkerRepository.cpp:
  • tests/RunAllTests.cpp:
3:00 PM Changeset in webkit [139245] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

Proper version of http://trac.webkit.org/changeset/139221.
The problem was that there was line-wrapping due to form controls
being different sizes on different platforms, not that form
controls dump innerText differently.

  • fast/forms/min-content-form-controls-expected.txt:
  • fast/forms/min-content-form-controls.html:
2:57 PM Changeset in webkit [139244] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Device Proximity is not enabled/implemented on Windows.
Skipping related tests:

proximity/add-listener-from-callback.html
proximity/basic-operation.html
proximity/create-event.html
proximity/event-after-navigation.html
proximity/multiple-frames.html
proximity/no-page-cache.html
proximity/optional-event-properties.html
proximity/updates.html
proximity/window-property.html

  • platform/win/TestExpectations:
2:45 PM Changeset in webkit [139243] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Enable seamless iFrames for Windows DRT.
https://bugs.webkit.org/show_bug.cgi?id=106468.

Rubberstamped by Timothy Horton.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

2:36 PM Changeset in webkit [139242] by Christophe Dumez
  • 10 edits in trunk

[WK2] Implement eventSender.scheduleAsynchronousKeyDown
https://bugs.webkit.org/show_bug.cgi?id=93979

Reviewed by Benjamin Poulain.

Tools:

Implement eventSender.scheduleAsynchronousKeyDown() in
WebKitTestRunner.

  • WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::createKeyDownMessageBody):
(WTR::EventSendingController::keyDown):
(WTR::EventSendingController::scheduleAsynchronousKeyDown):

  • WebKitTestRunner/InjectedBundle/EventSendingController.h:

(EventSendingController):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
(WTR::TestController::didReceiveMessageFromInjectedBundle):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

  • WebKitTestRunner/TestController.h:

(TestController):

LayoutTests:

Update WK2 expectations for tests requiring
eventSender.scheduleAsynchronousKeyDown now that it is
implemented in WebKitTestRunner.

  • platform/efl-wk2/TestExpectations:
  • platform/gtk-wk2/TestExpectations:
  • platform/wk2/TestExpectations:
2:30 PM Changeset in webkit [139241] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

Add user defaults to override system proxy settings for NetworkProcess on Mac
https://bugs.webkit.org/show_bug.cgi?id=104197

Patch by Kiran Muppala <cmuppala@apple.com> on 2013-01-09
Reviewed by Brady Eidson.

For internal testing and debugging, it is useful to have a defaults write to set the HTTP and HTTPS proxy specific to a
WebKit2 client application and not affect the system proxy settings on Mac.

  • NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit::overrideSystemProxies): Add helper method to parse proxy URLs and populate settings dictionary passed
to WKCFNetworkSetOverrideSystemProxySettings.
(WebKit::NetworkProcess::platformInitializeNetworkProcess): Call overrideSystemProxies if process creation parameters for
http proxy or https proxy is set.

  • Shared/Network/NetworkProcessCreationParameters.cpp: Add httpProxy and httpsProxy process creation parameters on Mac.

(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):

  • Shared/Network/NetworkProcessCreationParameters.h:
  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeNetworkProcess): Initialize httpProxy and httpsProxy process creation parameters
based on the value of WebKit2HTTPProxyDefaultsKey and WebKit2HTTPSProxyDefaultsKey user default respectively.

2:22 PM WebKit Team edited by gman@google.com
added gregg tavares as committer (diff)
2:12 PM Changeset in webkit [139240] by ap@apple.com
  • 4 edits
    1 move in trunk/Source/WebKit2

Local builds of NetworkProcess should have a process icon
https://bugs.webkit.org/show_bug.cgi?id=106489

Reviewed by Mark Rowe.

  • Resources/WebKit.icns: Copied from Source/WebKit2/WebProcess/mac/WebKit.icns.
  • WebProcess/mac/WebKit.icns: Removed. Copied to a shared location. We don't have different icons, so just using WebKit one.
  • Configurations/NetworkProcess.xcconfig:
  • NetworkProcess/Info.plist:
  • WebKit2.xcodeproj/project.pbxproj: Same changes as for WebProcess.
2:03 PM Changeset in webkit [139239] by danw@gnome.org
  • 8 edits in trunk

[Soup] Handle redirection inside WebKit
https://bugs.webkit.org/show_bug.cgi?id=61122
https://bugs.webkit.org/show_bug.cgi?id=88961

Reviewed by Martin Robinson.

Source/WebCore:

Rather than using libsoup's built-in redirection handling (which
doesn't do everything exactly the way WebKit wants, and can't
handle redirects to non-http URIs anyway), process redirections
ourselves.

No new tests; unskips a few existing tests.

  • platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(ResourceHandleInternal):

  • platform/network/soup/ResourceError.h:

(ResourceError):

  • platform/network/soup/ResourceErrorSoup.cpp:

(WebCore::ResourceError::transportError):
(WebCore):
(WebCore::ResourceError::httpError):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore):
(WebCore::gotHeadersCallback):
(WebCore::restartedCallback):
(WebCore::shouldRedirect):
(WebCore::doRedirect):
(WebCore::redirectCloseCallback):
(WebCore::redirectSkipCallback):
(WebCore::cleanupSoupRequestOperation):
(WebCore::sendRequestCallback):
(WebCore::createSoupMessageForHandleAndRequest):
(WebCore::createSoupRequestAndMessageForHandle):
(WebCore::ResourceHandle::start):

LayoutTests:

Unskip some tests.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
2:01 PM Changeset in webkit [139238] by fmalita@chromium.org
  • 22 edits in trunk

[Skia] Implement GraphicsContext::addRoundedRectClip() using SkCanvas::clipRRect()
https://bugs.webkit.org/show_bug.cgi?id=106461

Reviewed by Stephen White.

Source/WebCore:

This patch adds a Skia-specific version of GraphicsContext::addRoundedRectClip() to take
advantage of the SkCanvas::clipRRect() primitive.

As a minor cleanup, the anonymous namespace in GraphicsContextSkia.cpp is extended to cover
all the local helper functions.

No new tests: coverage provided by existing tests.

  • platform/graphics/GraphicsContext.cpp:

(WebCore):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::addRoundedRectClip):
(WebCore):
(WebCore::GraphicsContext::fillRoundedRect):

  • platform/graphics/skia/PlatformContextSkia.h:

(WebCore::PlatformContextSkia::clipRRect):
(WebCore):

LayoutTests:

  • platform/chromium-linux/fast/backgrounds/border-radius-split-background-image-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-complex-inner-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-inset-outset-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-wide-border-05-expected.png:
  • platform/chromium-linux/fast/borders/border-styles-split-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
  • platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-linux/fast/css/background-clip-radius-values-expected.png:
  • platform/chromium-linux/fast/replaced/border-radius-clip-content-edge-expected.png:
  • platform/chromium-linux/fast/writing-mode/border-styles-vertical-lr-expected.png:
  • platform/chromium-linux/fast/writing-mode/border-styles-vertical-rl-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium/TestExpectations:
1:55 PM Changeset in webkit [139237] by roger_fong@apple.com
  • 6 edits in trunk/Source/WebKit/win

Add WebPreferences for Seamless IFrames on Windows port.
https://bugs.webkit.org/show_bug.cgi?id=106468.

Rubberstamped by Eric Seidel.

  • Interfaces/IWebPreferences.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::areSeamlessIFramesEnabled):
(WebPreferences::setSeamlessIFramesEnabled):

  • WebPreferences.h:

(WebPreferences):

  • WebView.cpp:

(WebView::notifyPreferencesChanged):

1:51 PM Changeset in webkit [139236] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

SVG-as-image: Throw out cached bitmap renderings after they sit unused for some time.
<http://webkit.org/b/106484>
<rdar://problem/12983216>

Reviewed by Antti Koivisto.

Add a one-shot timer to SVGImageCache to self-clear the bitmap cache 30 seconds after last access.
This prevents us from keeping huge ImageBuffers around in memory for the lifetime of the elements
referencing that particular SVG file. (The ownership model is actually a bit more complicated
but that's irrelevant to this issue.)

10234kB progression on Membuster3.

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::SVGImageCache):
(WebCore::SVGImageCache::~SVGImageCache):
(WebCore::SVGImageCache::clearBitmapCache):
(WebCore::SVGImageCache::cacheClearTimerFired):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):

  • svg/graphics/SVGImageCache.h:

(SVGImageCache):

1:48 PM Changeset in webkit [139235] by Dimitri Glazkov
  • 2 edits
    4 adds in trunk/LayoutTests

[Chromium] Land expectations for r139197.

  • platform/chromium-linux/fast/regions/selecting-text-through-different-region-flows-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/regions/selecting-text-through-different-region-flows-expected.png: Added.
  • platform/chromium-mac/fast/regions/selecting-text-through-different-region-flows-expected.png:
  • platform/chromium-win/fast/regions/selecting-text-through-different-region-flows-expected.png: Added.
  • platform/chromium-win/fast/regions/selecting-text-through-different-region-flows-expected.txt: Added.
1:44 PM Changeset in webkit [139234] by jochen@chromium.org
  • 11 edits in trunk/Tools

[chromium] move resource load callback dumping to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=106449

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebKit):
(WebTestRunner::WebTestDelegate::makeURLErrorDescription):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebKit):
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::assignIdentifierToRequest):
(WebTestRunner::WebTestProxy::willRequestResource):
(WebTestRunner::WebTestProxy::willSendRequest):
(WebTestRunner::WebTestProxy::didReceiveResponse):
(WebTestRunner::WebTestProxy::didFinishResourceLoad):
(WebTestRunner::WebTestProxy::didFailResourceLoad):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
(WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
(WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
(WebTestRunner):
(WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
(WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
(WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::reset):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
(WebTestRunner::WebTestProxyBase::willRequestResource):
(WebTestRunner::WebTestProxyBase::willSendRequest):
(WebTestRunner::WebTestProxyBase::didReceiveResponse):
(WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
(WebTestRunner::WebTestProxyBase::didFailResourceLoad):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::willSendRequest):
(WebViewHost::makeURLErrorDescription):
(WebViewHost::reset):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

1:44 PM Changeset in webkit [139233] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] inspector/geolocation-error.html is flaky in Win.
https://bugs.webkit.org/show_bug.cgi?id=106487

  • platform/chromium/TestExpectations: Marked as flaky.
1:39 PM Changeset in webkit [139232] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Tweak webaduio test expectations once more.

  • platform/chromium/TestExpectations: Tweaked.
1:07 PM Changeset in webkit [139231] by commit-queue@webkit.org
  • 9 edits in trunk/Tools

[chromium] move dumpcreateview methods to testrunner library
https://bugs.webkit.org/show_bug.cgi?id=106434

Patch by Dan Carney <dcarney@google.com> on 2013-01-09
Reviewed by Adam Barth.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner::WebTestRunner::shouldDumpCreateView):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::shouldDumpCreateView):
(WebTestRunner):
(WebTestRunner::TestRunner::dumpCreateView):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

12:53 PM Changeset in webkit [139230] by ap@apple.com
  • 4 edits
    3 adds in trunk

Assertion failure in SubresourceLoader::didFail when reloading
https://bugs.webkit.org/show_bug.cgi?id=101416

Reviewed by Nate Chapin.

Test: http/tests/cache/network-error-during-revalidation.html

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didFail): Handle revalidation.
12:46 PM Changeset in webkit [139229] by Alexandru Chiculita
  • 4 edits in trunk

Assertion Failure in WebCore::RenderLayerCompositor::updateCompositingLayers
https://bugs.webkit.org/show_bug.cgi?id=106419

Reviewed by Simon Fraser.

Source/WebCore:

No new tests added, just un-skipped 3 existing tests.

RenderLayerCompositor::updateCompositingLayers is being called with a pending layout, so computing the
layers at that point would be useless & error-prone as they will be using incorrect layout values. If a layout is pending it means that
RenderLayerCompositor::updateCompositingLayers would get called again after the pending layout ends, so any values calculated at that point would be
overwritten immediately. This patch removes the old ASSERT and makes it a return instead.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers):

LayoutTests:

Re-added skipped tests as this patch resolves the flakiness.

  • platform/mac/TestExpectations:
12:45 PM Changeset in webkit [139228] by roger_fong@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Unreviewed. Changelog fix.

12:44 PM Changeset in webkit [139227] by pilgrim@chromium.org
  • 149 edits in trunk/Source/WebKit/chromium

[Chromium] Update some #includes in WebKit/chromium/public/ for new Platform directory
https://bugs.webkit.org/show_bug.cgi?id=106227

Reviewed by Darin Fisher.

Part of a larger refactoring series. See tracking bug 82948.

  • public/WebAccessibilityObject.h:
  • public/WebAccessibilityRole.h:
  • public/WebActiveWheelFlingParameters.h:
  • public/WebAnimationController.h:
  • public/WebApplicationCacheHost.h:
  • public/WebApplicationCacheHostClient.h:
  • public/WebArrayBuffer.h:
  • public/WebAudioSourceProvider.h:
  • public/WebBatteryStatus.h:
  • public/WebBindings.h:
  • public/WebBlob.h:
  • public/WebCache.h:
  • public/WebCachedURLRequest.h:
  • public/WebColorChooser.h:
  • public/WebColorChooserClient.h:
  • public/WebColorName.h:
  • public/WebCommonWorkerClient.h:
  • public/WebCompositionUnderline.h:
  • public/WebCompositorInputHandler.h:
  • public/WebConsoleMessage.h:
  • public/WebContentDetectionResult.h:
  • public/WebContextMenuData.h:
  • public/WebCrossOriginPreflightResultCache.h:
  • public/WebCursorInfo.h:
  • public/WebDOMEvent.h:
  • public/WebDOMEventListener.h:
  • public/WebDOMStringList.h:
  • public/WebDataSource.h:
  • public/WebDatabase.h:
  • public/WebDateTimeChooserCompletion.h:
  • public/WebDateTimeChooserParams.h:
  • public/WebDeliveredIntentClient.h:
  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h:
  • public/WebDevToolsFrontend.h:
  • public/WebDeviceOrientationClient.h:
  • public/WebDeviceOrientationClientMock.h:
  • public/WebDeviceOrientationController.h:
  • public/WebDocument.h:
  • public/WebDraggableRegion.h:
  • public/WebExternalPopupMenuClient.h:
  • public/WebFileChooserCompletion.h:
  • public/WebFileChooserParams.h:
  • public/WebFileSystemCallbacks.h:
  • public/WebFileSystemEntry.h:
  • public/WebFileWriter.h:
  • public/WebFileWriterClient.h:
  • public/WebFindOptions.h:
  • public/WebFont.h:
  • public/WebFontCache.h:
  • public/WebFontDescription.h:
  • public/WebFormControlElement.h:
  • public/WebFormElement.h:
  • public/WebFrame.h:
  • public/WebFrameClient.h:
  • public/WebGeolocationClientMock.h:
  • public/WebGeolocationController.h:
  • public/WebGeolocationError.h:
  • public/WebGeolocationPermissionRequest.h:
  • public/WebGeolocationPermissionRequestManager.h:
  • public/WebGeolocationPosition.h:
  • public/WebGlyphCache.h:
  • public/WebHelperPlugin.h:
  • public/WebHistoryItem.h:
  • public/WebHitTestResult.h:
  • public/WebIDBCallbacks.h:
  • public/WebIDBCursor.h:
  • public/WebIDBDatabase.h:
  • public/WebIDBDatabaseCallbacks.h:
  • public/WebIDBDatabaseError.h:
  • public/WebIDBFactory.h:
  • public/WebIDBIndex.h:
  • public/WebIDBKey.h:
  • public/WebIDBKeyPath.h:
  • public/WebIDBKeyRange.h:
  • public/WebIDBMetadata.h:
  • public/WebIDBObjectStore.h:
  • public/WebIDBTransaction.h:
  • public/WebIDBTransactionCallbacks.h:
  • public/WebIconURL.h:
  • public/WebImageDecoder.h:
  • public/WebInputEvent.h:
  • public/WebIntent.h:
  • public/WebIntentRequest.h:
  • public/WebIntentServiceInfo.h:
  • public/WebMediaPlayer.h:
  • public/WebMediaStreamRegistry.h:
  • public/WebMenuItemInfo.h:
  • public/WebNetworkStateNotifier.h:
  • public/WebNode.h:
  • public/WebNodeCollection.h:
  • public/WebNodeList.h:
  • public/WebNotification.h:
  • public/WebNotificationPresenter.h:
  • public/WebOptionElement.h:
  • public/WebPageOverlay.h:
  • public/WebPagePopup.h:
  • public/WebPageSerializer.h:
  • public/WebPasswordFormData.h:
  • public/WebPerformance.h:
  • public/WebPlugin.h:
  • public/WebPluginContainer.h:
  • public/WebPluginParams.h:
  • public/WebPopupMenu.h:
  • public/WebPopupMenuInfo.h:
  • public/WebPrerendererClient.h:
  • public/WebPrintParams.h:
  • public/WebRange.h:
  • public/WebRegularExpression.h:
  • public/WebRuntimeFeatures.h:
  • public/WebScopedMicrotaskSuppression.h:
  • public/WebScopedUserGesture.h:
  • public/WebScriptController.h:
  • public/WebScriptSource.h:
  • public/WebSearchableFormData.h:
  • public/WebSecurityOrigin.h:
  • public/WebSecurityPolicy.h:
  • public/WebSelectElement.h:
  • public/WebSettings.h:
  • public/WebSharedWorker.h:
  • public/WebSharedWorkerRepository.h:
  • public/WebSpeechGrammar.h:
  • public/WebSpeechInputController.h:
  • public/WebSpeechInputResult.h:
  • public/WebSpeechRecognitionHandle.h:
  • public/WebSpeechRecognitionParams.h:
  • public/WebSpeechRecognitionResult.h:
  • public/WebSpeechRecognizer.h:
  • public/WebSpeechRecognizerClient.h:
  • public/WebSpellCheckClient.h:
  • public/WebStorageEventDispatcher.h:
  • public/WebSurroundingText.h:
  • public/WebTestingSupport.h:
  • public/WebTextCheckingCompletion.h:
  • public/WebTextCheckingResult.h:
  • public/WebTextFieldDecoratorClient.h:
  • public/WebTextInputInfo.h:
  • public/WebTextRun.h:
  • public/WebTimeRange.h:
  • public/WebTouchPoint.h:
  • public/WebUserMediaRequest.h:
  • public/WebView.h:
  • public/WebViewBenchmarkSupport.h:
  • public/WebViewClient.h:
  • public/WebWidget.h:
  • public/WebWidgetClient.h:
  • public/WebWindowFeatures.h:
  • public/WebWorkerInfo.h:
12:41 PM Changeset in webkit [139226] by roger_fong@apple.com
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed. Rebaseline some accessibility test results on Win7 port.

  • platform/win/accessibility/canvas-fallback-content-2-expected.txt:
  • platform/win/platform/win/accessibility: Added.
  • platform/win/platform/win/accessibility/option-element-selection-and-focus-events-expected.txt: Added.
  • platform/win/platform/win/accessibility/select-element-valuechange-event-expected.txt: Added.
12:41 PM Changeset in webkit [139225] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Useless if statement check
https://bugs.webkit.org/show_bug.cgi?id=106113

Patch by Genevieve Mak <gmak@rim.com> on 2013-01-09
Reviewed by Yong Li.

Remove stray ! in if statement which was mistakenly left in during
refactoring. Since Injected events are checked before they are sent to
webkit, it didn't have an effect on behaviour.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::touchEvent):

12:33 PM Changeset in webkit [139224] by Csaba Osztrogonác
  • 7 edits in trunk/Tools

webkitpy cleanup: Merge additional_comment_text into comment_text
https://bugs.webkit.org/show_bug.cgi?id=106421

Reviewed by Adam Barth.

  • Scripts/webkitpy/common/config/committervalidator.py:

(CommitterValidator.reject_patch_from_commit_queue):
(CommitterValidator.reject_patch_from_review_queue):

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla.set_flag_on_attachment):

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:

(MockBugzilla.set_flag_on_attachment):

  • Scripts/webkitpy/tool/bot/feeders_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem._post_reject_message_on_bug):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:
12:30 PM Changeset in webkit [139223] by robert@webkit.org
  • 5 edits in trunk

REGRESSION(r111439): Focus ring is rendered incorrectly in fast/inline/continuation-outlines-with-layers.html
https://bugs.webkit.org/show_bug.cgi?id=106064

Reviewed by David Hyatt.

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintObject):

LayoutTests:

  • platform/chromium-linux/fast/inline/continuation-outlines-with-layers-expected.png:
12:27 PM Changeset in webkit [139222] by commit-queue@webkit.org
  • 2 edits in trunk/Source/ThirdParty

Change ARCHS to generic setting to work with multiple platforms.
https://bugs.webkit.org/show_bug.cgi?id=106478

Patch by David Farler <dfarler@apple.com> on 2013-01-09
Reviewed by Anders Carlsson.

  • gtest/xcode/Config/General.xcconfig: ARCHS = $(ARCHS_STANDARD_32_64_BIT);
12:24 PM Changeset in webkit [139221] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

fast/forms/min-content-form-controls.html fails on some platforms
https://bugs.webkit.org/show_bug.cgi?id=106482

Reviewed by Eric Seidel.

The text dump for some form controls (menulists?) has different whitespace
output on different platforms. Remove the form controls to avoid adding
platform-specific expectations for this test.

  • fast/forms/min-content-form-controls-expected.txt:
  • fast/forms/min-content-form-controls.html:
  • platform/mac/TestExpectations:
12:19 PM Changeset in webkit [139220] by commit-queue@webkit.org
  • 20 edits
    3 adds in trunk

Add stub for CanvasProxy
https://bugs.webkit.org/show_bug.cgi?id=106275

Patch by Gregg Tavares <gman@google.com> on 2013-01-09
Reviewed by Dean Jackson.

No new tests as no new fuctionality exposed.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/CanvasProxy.cpp: Added.
  • html/canvas/CanvasProxy.h: Added.
  • html/canvas/CanvasProxy.idl: Added.
12:12 PM Changeset in webkit [139219] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

IndexedDB: Remove unnecessary tests from storage/indexeddb/key-type-array.html
https://bugs.webkit.org/show_bug.cgi?id=106472

Patch by Michael Pruett <michael@68k.org> on 2013-01-09
Reviewed by Tony Chang.

The tests which verify that JSON.stringify() throws an exception
for cyclic objects produce different error messages on JSC and
V8 and do nothing to test IndexedDB functionality. These tests
should be removed.

  • storage/indexeddb/key-type-array-expected.txt:
  • storage/indexeddb/resources/key-type-array.js:
12:08 PM Changeset in webkit [139218] by Antti Koivisto
  • 11 edits in trunk/Source

Source/WebCore: Release FastMalloc thread caches on memory warning
https://bugs.webkit.org/show_bug.cgi?id=106471

Reviewed by Geoff Garen.

FastMalloc keeps some memory in per-thread caches (currently 2MB each). We currently flush these caches on memory warning
for the main thread only. We should do it for other WebKit threads that use FastMalloc too.

Call WTF::releaseFastMallocFreeMemory in a bunch of WebCore support threads on memory warning. Unfortunately we don't have
an uniform way of doing threads so this requires bunch of thread type specific code.

Looks to be ~1% progression in membuster3 final and maximum numbers.

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::releaseMemory):

  • storage/StorageTask.cpp:

(WebCore::StorageTask::performTask):

  • storage/StorageTask.h:

(WebCore::StorageTask::createReleaseFastMallocFreeMemory):

  • storage/StorageThread.cpp:

(WebCore::storageThreads):
(WebCore):
(WebCore::StorageThread::StorageThread):
(WebCore::StorageThread::~StorageThread):
(WebCore::StorageThread::releaseFastMallocFreeMemoryInAllThread):

  • storage/StorageThread.h:

(StorageThread):

  • workers/WorkerThread.cpp:

(WebCore::threadSetMutex):
(WebCore::workerThreads):
(WebCore::WorkerThread::workerThreadCount):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::~WorkerThread):
(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThread):
(WebCore):

  • workers/WorkerThread.h:

(WorkerThread):

Source/WTF: Release FastMalloc thread caches on memory warning
https://bugs.webkit.org/show_bug.cgi?id=106471

Reviewed by Geoff Garen.

Use TCMalloc_ThreadCache::Cleanup() instead of calling Scavenge() twice. This releases all the memory
and looks nicer too.

  • wtf/FastMalloc.cpp:

(WTF::releaseFastMallocFreeMemory):

12:01 PM Changeset in webkit [139217] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r139141): Assertion failure in WebCore::HTMLConstructionSite::HTMLConstructionSite
https://bugs.webkit.org/show_bug.cgi?id=106412

Reviewed by Darin Adler.

This corrects the assertion added in r139141. The assertion was designed to make sure that we are using the
HTMLDocument class. XHTML documents also use HTMLDocument.

No new tests because no new functionality.

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::HTMLConstructionSite):

11:41 AM Changeset in webkit [139216] by ojan@chromium.org
  • 8 edits
    2 adds in trunk

min-content gets the wrong value if min-width is set on some form controls
https://bugs.webkit.org/show_bug.cgi?id=106389

Reviewed by Tony Chang.

Source/WebCore:

Simplify the logic. The only exposed change in behavior is that
m_minPreferredLogicalWidth gets set to m_maxPreferredLogicalWidth
instead of 0 when min-width is set.

Test: fast/forms/min-content-form-controls.html

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::computePreferredLogicalWidths):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::computePreferredLogicalWidths):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::computePreferredLogicalWidths):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computePreferredLogicalWidths):

LayoutTests:

  • fast/forms/min-content-form-controls-expected.txt: Added.
  • fast/forms/min-content-form-controls.html: Added.
11:36 AM Changeset in webkit [139215] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Fix a typo in in the double-tap-to-zoom logic

Rubber-stamped by Csaba Osztrogonác.

The qMin for the upper boundary of the scale was accidentally
changed to qMax in r139189, change it back to fix the Qt API tests.

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):

11:36 AM Changeset in webkit [139214] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skipping 4 video controls tests on Windows.
https://bugs.webkit.org/show_bug.cgi?id=106477.

Skipped tests:
media/video-controls-captions-trackmenu-localized.html
media/video-controls-captions-trackmenu-sorted.html
media/video-controls-captions-trackmenu.html
media/video-controls-visible-exiting-fullscreen.html

  • platform/win/TestExpectations:
11:08 AM Changeset in webkit [139213] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

Mitigate out-of-bounds access in InlineIterator
https://bugs.webkit.org/show_bug.cgi?id=104812

Reviewed by Levi Weintraub.

Share code between InlineIterator::current and InlineIterator::previousInSameNode,
thereby checking for access outside text renderer's length.

  • rendering/InlineIterator.h:

(InlineIterator):
(WebCore::InlineIterator::characterAt):
(WebCore):
(WebCore::InlineIterator::current):
(WebCore::InlineIterator::previousInSameNode):

11:06 AM Changeset in webkit [139212] by Dimitri Glazkov
  • 6 edits
    8 adds in trunk/LayoutTests

[Chromium] Rebaseline a few tests after r139191.

  • platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/video/video-controls-layer-creation-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/video/video-controls-layer-creation-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/video/video-controls-layer-creation-expected.png: Added.
  • platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
  • platform/chromium-win/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/video/video-controls-layer-creation-expected.png: Added.
10:58 AM Changeset in webkit [139211] by Dimitri Glazkov
  • 11 edits in trunk/LayoutTests

[Chromium] Rebaseline a few tests after r139201.

  • platform/chromium-mac-lion/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac-lion/fast/forms/menulist-option-wrap-expected.png:
  • platform/chromium-mac-lion/fast/repaint/control-clip-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/menulist-option-wrap-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/control-clip-expected.png:
  • platform/chromium-mac/fast/forms/menulist-clip-expected.png:
  • platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png:
  • platform/chromium-mac/fast/forms/select-empty-option-height-expected.png:
  • platform/chromium-mac/fast/repaint/control-clip-expected.png:
10:55 AM Changeset in webkit [139210] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] fast/images/embed-does-not-propagate-dimensions-to-object-ancestor.html is a flaky crash.
https://bugs.webkit.org/show_bug.cgi?id=106473

  • platform/chromium/TestExpectations: Marked.
10:52 AM Changeset in webkit [139209] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

If ImageLoader's loadEventSender or errorEventSender fires after document is detached, the document will be leaked.

https://bugs.webkit.org/show_bug.cgi?id=106394

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-01-09
Reviewed by Alexey Proskuryakov.

ImageLoader's loadEventSender and errorEventSender schedule event dispatching in separate timers and refs
the Element in updatedHasPendingEvent. If the Document is detached before either eventSender dispatches,
we would leak the Document since we bail out early in dispatchPendingLoadEvent or dispatchPendingErrorEvent,
without deref-ing the Element itself.

No new tests. Verified manually by using heap tool to count the living HTMLDocuments.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingLoadEvent): also call updatedHasPendingEvent to deref the Element if

the document is detached.

(WebCore::ImageLoader::dispatchPendingErrorEvent): ditto.

10:50 AM Changeset in webkit [139208] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r139143.
http://trac.webkit.org/changeset/139143
https://bugs.webkit.org/show_bug.cgi?id=106135

Broke Chromium content_browsertests.

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::openInMemory):

10:50 AM Changeset in webkit [139207] by mario@webkit.org
  • 2 edits in trunk/Tools

[GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
https://bugs.webkit.org/show_bug.cgi?id=106464

Reviewed by Martin Robinson.

Current version in jhbuild.modules (2.26.0) is giving trouble to
when trying to build WebKitGTK from scratch, due to a segmentation
fault error in gdk-pixbuf-query-loader during the 'make'
phase. Raising the version to 2.26.5 fixes this issue.

  • gtk/jhbuild.modules: Version raised, checksums updated.
10:29 AM Changeset in webkit [139206] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Add Settings.in and make_settings.pl to the project.

Reviewed by Anders Carlsson.

  • WebCore.xcodeproj/project.pbxproj:
10:22 AM Changeset in webkit [139205] by dbates@webkit.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Remove duplicate ChangeLog entry for https://bugs.webkit.org/show_bug.cgi?id=105035
that was inadvertently added in <http://trac.webkit.org/changeset/139203>.

10:17 AM Changeset in webkit [139204] by junov@google.com
  • 1 edit
    1 add in trunk/LayoutTests

New chromium-win pixel baseline for gradient-background-leakage-hidpi.html
https://bugs.webkit.org/show_bug.cgi?id=106373

Unreviewed.

  • platform/chromium-win/fast/backgrounds/gradient-background-leakage-hidpi-expected.png: Added.
10:10 AM Changeset in webkit [139203] by ojan@chromium.org
  • 3 edits in trunk

Source/WebCore: marquee special-case in RenderBlock is not needed
https://bugs.webkit.org/show_bug.cgi?id=106396

Reviewed by Simon Fraser.

This was added in http://trac.webkit.org/changeset/105772. The layout test
in that patch (which is disabled) works and the original site that was broken
also still works.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computePreferredLogicalWidths):

LayoutTests: Implement CSS computed style value for transition shorthand
https://bugs.webkit.org/show_bug.cgi?id=105035

Patch by Alexis Menard <alexis@webkit.org> on 2013-01-09
Reviewed by Dean Jackson.

Uncomment existing tests to cover the new feature.

  • transitions/transitions-parsing-expected.txt:
  • transitions/transitions-parsing.html:
10:07 AM Changeset in webkit [139202] by tony@chromium.org
  • 15 edits in trunk

Automatically generate Settings::unifiedTextCheckerEnabled
https://bugs.webkit.org/show_bug.cgi?id=106382

Reviewed by Adam Barth.

Source/WebCore:

No new tests, no change in behavior. This is covered by existing editing/spelling tests.

  • page/Settings.cpp:

(WebCore): Move default value into a global so we can generate the initializer.
(WebCore::Settings::Settings): Remove initializer code that is now generated.

  • page/Settings.h:

(Settings): Remove getters and setters.

  • page/Settings.in: Add entry to be generated.
  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup): Remove backup since the generated code does this.
(WebCore::InternalSettings::Backup::restoreTo): Remove restore code since the generated code does this.

  • testing/InternalSettings.h:

(InternalSettings): Remove member variable.

  • testing/InternalSettings.idl: The getter was unused so it's being removed. The setter is now generated.

LayoutTests:

The InternalSettings.idl method didn't match the Settings' getter/setter. Now
that we're using the generated version, make the tests use the same name.

  • editing/spelling/grammar-edit-word.html:
  • editing/spelling/spellcheck-async-mutation.html:
  • editing/spelling/spellcheck-async-remove-frame.html:
  • editing/spelling/spellcheck-async.html:
  • editing/spelling/spelling-marker-description.html:
  • editing/spelling/spelling-unified-emulation.html:
  • platform/chromium/editing/spelling/delete-misspelled-word.html:
10:04 AM Changeset in webkit [139201] by schenney@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Adjust Skia build flags to WebKit skia gyp

Unreviewed change to enable easy layout test rebaselining.

  • skia_webkit.gyp:
10:04 AM Changeset in webkit [139200] by alexis@webkit.org
  • 5 edits in trunk

Implement CSS computed style value for transition shorthand
https://bugs.webkit.org/show_bug.cgi?id=105035

Reviewed by Dean Jackson.

Source/WebCore:

Implement support for query the transition and webkit-transition
shorthand from the computed style.

Test: transitions/transitions-parsing.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::createTransitionPropertyValue): Factor the code to create the
correct value into a function to reuse it for the shorthand.
(WebCore::getTransitionPropertyValue):
(WebCore::createTimingFunctionValue): Little refactor, the intermediate
local variables are not needed.
(WebCore::getTimingFunctionValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Uncomment existing tests to cover the new feature.

  • transitions/transitions-parsing-expected.txt:
  • transitions/transitions-parsing.html:
9:41 AM Changeset in webkit [139199] by morrita@google.com
  • 5 edits in trunk/Source/WebCore

Document::setActiveNode() should be Document::setActiveElement()
https://bugs.webkit.org/show_bug.cgi?id=106437

Reviewed by Ojan Vafai.

No new tests. No functoinal change.

  • dom/Document.cpp:

(WebCore::Document::setActiveElement):
(WebCore::Document::updateHoverActiveState):

  • dom/Document.h:

(Document):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::innerElement):
(WebCore):

  • rendering/HitTestResult.h:

(HitTestResult):

9:34 AM Changeset in webkit [139198] by shinyak@chromium.org
  • 361 edits in trunk

Source/WebCore: [Shadow DOM]: ShadowRoot has wrong nodeName attribute
https://bugs.webkit.org/show_bug.cgi?id=104995

Reviewed by Dimitri Glazkov.

According to the Shadow DOM spec, ShadowRoot.nodeName should return '#document-fragment' instead of '#shadow-root'.
We remove ShadowRoot::nodeName.

No new tests, covered by existing tests.

  • dom/ShadowRoot.cpp:
  • dom/ShadowRoot.h:

(ShadowRoot):

LayoutTests: [Shadow DOM]: ShadowRoot wrong nodeName attribute
https://bugs.webkit.org/show_bug.cgi?id=104995

Reviewed by Dimitri Glazkov.

Converted #shadow-root to #document-fragment in LayoutTests files using sed.

  • editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
  • editing/deleting/delete-ligature-001-expected.txt:
  • editing/pasteboard/copy-in-password-field-expected.txt:
  • editing/selection/select-all-textarea-expected.txt:
  • fast/dom/shadow/layout-tests-can-access-shadow-expected.txt:
  • fast/dom/shadow/layout-tests-can-access-shadow.html:
  • fast/dom/shadow/shadow-and-list-elements.html:
  • fast/events/5056619-expected.txt:
  • fast/forms/focus-selection-input-expected.txt:
  • fast/forms/focus-selection-textarea-expected.txt:
  • fast/forms/textfield-outline-expected.txt:
  • fast/html/details-add-summary-1-and-click-expected.txt:
  • fast/html/details-add-summary-10-and-click-expected.txt:
  • fast/html/details-add-summary-2-and-click-expected.txt:
  • fast/html/details-add-summary-3-and-click-expected.txt:
  • fast/html/details-add-summary-4-and-click-expected.txt:
  • fast/html/details-add-summary-5-and-click-expected.txt:
  • fast/html/details-add-summary-6-and-click-expected.txt:
  • fast/html/details-add-summary-7-and-click-expected.txt:
  • fast/html/details-add-summary-8-and-click-expected.txt:
  • fast/html/details-add-summary-9-and-click-expected.txt:
  • fast/html/details-remove-summary-1-and-click-expected.txt:
  • fast/html/details-remove-summary-2-and-click-expected.txt:
  • fast/html/details-remove-summary-3-and-click-expected.txt:
  • fast/html/details-remove-summary-4-and-click-expected.txt:
  • fast/html/details-remove-summary-5-and-click-expected.txt:
  • fast/html/details-remove-summary-6-and-click-expected.txt:
  • inspector/elements/shadow-dom-modify-chardata-expected.txt:
  • inspector/elements/shadow-root-expected.txt:
  • inspector/elements/shadow-root.html:
  • inspector/elements/update-shadowdom-expected.txt:
  • platform/chromium-android/fast/events/autoscroll-expected.txt:
  • platform/chromium-android/fast/forms/input-appearance-selection-expected.txt:
  • platform/chromium-android/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/chromium-linux-x86/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-linux/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-linux/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac-lion/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-mac-lion/fast/forms/search-rtl-expected.txt:
  • platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.txt:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/chromium-mac/fast/forms/search-rtl-expected.txt:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/chromium-win-xp/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-win/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
  • platform/chromium-win/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/chromium-win/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/chromium-win/editing/inserting/4960120-1-expected.txt:
  • platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/chromium-win/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/chromium-win/editing/selection/4895428-3-expected.txt:
  • platform/chromium-win/editing/selection/4975120-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/chromium-win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium-win/fast/events/autoscroll-expected.txt:
  • platform/chromium-win/fast/events/context-no-deselect-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-focus-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-readonly-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-selection-expected.txt:
  • platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium-win/fast/forms/input-text-click-inside-expected.txt:
  • platform/chromium-win/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium-win/fast/forms/input-text-drag-down-expected.txt:
  • platform/chromium-win/fast/forms/input-text-option-delete-expected.txt:
  • platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/chromium-win/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/chromium-win/fast/forms/plaintext-mode-2-expected.txt:
  • platform/chromium-win/fast/forms/search-rtl-expected.txt:
  • platform/chromium-win/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/chromium-win/fast/forms/textarea-scrollbar-expected.txt:
  • platform/chromium-win/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/chromium-win/fast/forms/textfield-focus-ring-expected.txt:
  • platform/chromium-win/fast/forms/textfield-outline-expected.txt:
  • platform/chromium-win/fast/forms/textfield-overflow-expected.txt:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/chromium-win/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/chromium/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/chromium/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/chromium/editing/inserting/4960120-1-expected.txt:
  • platform/chromium/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/chromium/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/chromium/editing/selection/4895428-3-expected.txt:
  • platform/chromium/editing/selection/4975120-expected.txt:
  • platform/chromium/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/chromium/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt:
  • platform/chromium/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt:
  • platform/chromium/fast/events/autoscroll-expected.txt:
  • platform/chromium/fast/events/context-no-deselect-expected.txt:
  • platform/chromium/fast/forms/input-appearance-focus-expected.txt:
  • platform/chromium/fast/forms/input-appearance-readonly-expected.txt:
  • platform/chromium/fast/forms/input-appearance-selection-expected.txt:
  • platform/chromium/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/chromium/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/chromium/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/chromium/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/chromium/fast/forms/input-text-click-inside-expected.txt:
  • platform/chromium/fast/forms/input-text-double-click-expected.txt:
  • platform/chromium/fast/forms/input-text-drag-down-expected.txt:
  • platform/chromium/fast/forms/input-text-option-delete-expected.txt:
  • platform/chromium/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/chromium/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/chromium/fast/forms/plaintext-mode-2-expected.txt:
  • platform/chromium/fast/forms/search-rtl-expected.txt:
  • platform/chromium/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/chromium/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/chromium/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/chromium/fast/forms/textarea-scrollbar-expected.txt:
  • platform/chromium/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/chromium/fast/forms/textfield-focus-ring-expected.txt:
  • platform/chromium/fast/forms/textfield-outline-expected.txt:
  • platform/chromium/fast/forms/textfield-overflow-expected.txt:
  • platform/chromium/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/chromium/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/chromium/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/chromium/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/efl/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/efl/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/efl/editing/inserting/4960120-1-expected.txt:
  • platform/efl/fast/events/autoscroll-expected.txt:
  • platform/efl/fast/events/context-no-deselect-expected.txt:
  • platform/efl/fast/forms/input-appearance-focus-expected.txt:
  • platform/efl/fast/forms/input-appearance-readonly-expected.txt:
  • platform/efl/fast/forms/input-appearance-selection-expected.txt:
  • platform/efl/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/efl/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/efl/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/efl/fast/forms/input-text-click-inside-expected.txt:
  • platform/efl/fast/forms/input-text-double-click-expected.txt:
  • platform/efl/fast/forms/input-text-option-delete-expected.txt:
  • platform/efl/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/efl/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/efl/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/efl/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/efl/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/efl/fast/forms/textarea-scrollbar-expected.txt:
  • platform/efl/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/efl/fast/forms/textfield-focus-ring-expected.txt:
  • platform/efl/fast/forms/textfield-outline-expected.txt:
  • platform/efl/fast/forms/validation-message-appearance-expected.txt:
  • platform/efl/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/efl/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/efl/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/efl/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/gtk/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/gtk/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/gtk/editing/inserting/4960120-1-expected.txt:
  • platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/gtk/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/gtk/editing/selection/4895428-3-expected.txt:
  • platform/gtk/editing/selection/4975120-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/gtk/fast/events/autoscroll-expected.txt:
  • platform/gtk/fast/events/context-no-deselect-expected.txt:
  • platform/gtk/fast/forms/input-appearance-focus-expected.txt:
  • platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-selection-expected.txt:
  • platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/gtk/fast/forms/input-text-click-inside-expected.txt:
  • platform/gtk/fast/forms/input-text-click-outside-expected.txt:
  • platform/gtk/fast/forms/input-text-double-click-expected.txt:
  • platform/gtk/fast/forms/input-text-drag-down-expected.txt:
  • platform/gtk/fast/forms/input-text-option-delete-expected.txt:
  • platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/gtk/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
  • platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
  • platform/gtk/fast/forms/textfield-outline-expected.txt:
  • platform/gtk/fast/forms/textfield-overflow-expected.txt:
  • platform/gtk/fast/forms/validation-message-appearance-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac-wk2/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac-wk2/fast/forms/plaintext-mode-2-expected.txt:
  • platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/mac/editing/inserting/4960120-1-expected.txt:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/mac/editing/selection/4895428-3-expected.txt:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt:
  • platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt:
  • platform/mac/fast/events/autoscroll-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/forms/input-appearance-focus-expected.txt:
  • platform/mac/fast/forms/input-appearance-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-selection-expected.txt:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-text-click-inside-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/forms/input-text-drag-down-expected.txt:
  • platform/mac/fast/forms/input-text-option-delete-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/mac/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/mac/fast/forms/plaintext-mode-2-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/mac/fast/forms/textarea-scrollbar-expected.txt:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/mac/fast/forms/textfield-focus-ring-expected.txt:
  • platform/mac/fast/forms/textfield-outline-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/qt/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/qt/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/qt/editing/inserting/4960120-1-expected.txt:
  • platform/qt/editing/pasteboard/pasting-tabs-expected.txt:
  • platform/qt/editing/selection/4895428-3-expected.txt:
  • platform/qt/editing/selection/4975120-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/qt/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/qt/fast/events/context-no-deselect-expected.txt:
  • platform/qt/fast/forms/input-appearance-focus-expected.txt:
  • platform/qt/fast/forms/input-appearance-readonly-expected.txt:
  • platform/qt/fast/forms/input-appearance-selection-expected.txt:
  • platform/qt/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/qt/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/qt/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/qt/fast/forms/input-text-click-inside-expected.txt:
  • platform/qt/fast/forms/input-text-click-outside-expected.txt:
  • platform/qt/fast/forms/input-text-double-click-expected.txt:
  • platform/qt/fast/forms/input-text-option-delete-expected.txt:
  • platform/qt/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/qt/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/qt/fast/forms/plaintext-mode-2-expected.txt:
  • platform/qt/fast/forms/search-rtl-expected.txt:
  • platform/qt/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.txt:
  • platform/qt/fast/forms/textarea-scrollbar-expected.txt:
  • platform/qt/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/qt/fast/forms/textfield-focus-ring-expected.txt:
  • platform/qt/fast/forms/textfield-outline-expected.txt:
  • platform/qt/fast/forms/textfield-overflow-expected.txt:
  • platform/qt/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/qt/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/qt/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/qt/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/qt/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/win-wk2/fast/forms/textfield-overflow-expected.txt:
  • platform/win/editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
  • platform/win/editing/input/reveal-caret-of-multiline-input-expected.txt:
  • platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
  • platform/win/fast/forms/input-text-drag-down-expected.txt:
9:29 AM Changeset in webkit [139197] by zoltan@webkit.org
  • 3 edits
    3 adds in trunk

[CSS Regions] Selecting text through nested regions causes weird and unclearable selection
https://bugs.webkit.org/show_bug.cgi?id=105641

Reviewed by David Hyatt.

If you have a region with a nested region inside what is rendered below the base region and you are trying select text
starting from the base region and ending it in the nested region, firstly you got a weird selection, secondly you can't
clear the selection. We could prevent this strange behavior by preventing the selection through different region flows.

Source/WebCore:

Test: fast/regions/selecting-text-through-different-region-flows.html

  • rendering/RenderView.cpp:

(WebCore::RenderView::setSelection): Don't allow selection when trying to select different region flows.

LayoutTests:

  • fast/regions/selecting-text-through-different-region-flows-expected.txt: Added.
  • fast/regions/selecting-text-through-different-region-flows.html: Added.
  • platform/chromium-mac/fast/regions/selecting-text-through-different-region-flows-expected.png: Added.
9:00 AM Changeset in webkit [139196] by Hugo Parente Lima
  • 5 edits in trunk/Source/WebCore

Regression(r138681) : Add HAVE(ACCESSIBILITY) guard to atk files, fix for a fix.
https://bugs.webkit.org/show_bug.cgi?id=106448

Reviewed by Gyuyoung Kim.

Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
the macro isn't enabled.

  • accessibility/atk/WebKitAccessibleHyperlink.h:
  • accessibility/atk/WebKitAccessibleInterfaceAction.h:
  • accessibility/atk/WebKitAccessibleInterfaceComponent.h:
  • accessibility/atk/WebKitAccessibleInterfaceHypertext.h:
7:55 AM Changeset in webkit [139195] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: native popup buttons should not use textUnderElement for their title
https://bugs.webkit.org/show_bug.cgi?id=106349

Reviewed by Ryosuke Niwa.

Chromium relies on the older title() method to return its title. As a result, we also
need to handle the case of <select> element pop up buttons returning the textUnderElement().

No new tests. Fix existing break.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::title):

7:53 AM Changeset in webkit [139194] by János Badics
  • 16 edits in trunk/Tools

[Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
https://bugs.webkit.org/show_bug.cgi?id=90968.

Reviewed by Csaba Osztrogonác.

Added functionality in DRT and WTR to use any timeout value while running
slow tests (eventually, any test). Now NRWT --time-out-ms determines the
timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
to indicate whether the current port supports setting timeout value
per test (it's False by default; I enabled it only on Qt).
Also corrected a typo in driver.py

  • DumpRenderTree/DumpRenderTree.h:

(TestCommand::TestCommand):
(TestCommand):

  • DumpRenderTree/DumpRenderTreeCommon.cpp:

(parseInputLine):

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::processLine):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.supports_per_test_timeout):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver.run_test):
(Driver._command_from_driver_input):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort.supports_per_test_timeout):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::InjectedBundle):
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setCustomTimeout):
(WTR):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

  • WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:

(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::TestController):
(WTR::TestController::getCustomTimeout):
(WTR):
(WTR::TestCommand::TestCommand):
(TestCommand):
(WTR::parseInputLine):
(WTR::TestController::runTest):
(WTR::TestController::runUntil):

  • WebKitTestRunner/TestController.h:

(TestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::setCustomTimeout):
(WTR):
(WTR::TestInvocation::invoke):

  • WebKitTestRunner/TestInvocation.h:

(TestInvocation):

7:38 AM Changeset in webkit [139193] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Remove ASSERTs that can't assert but result in compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=106442

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2013-01-09
Reviewed by Kentaro Hara.

IDBLevelDBCoding::m_metaDataType has been changed to unsigned
so ASSERT(m_metaDataType >= 0) is no longer useful: the compiler
warnings however create build difficulties at least with EFL.

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):

7:02 AM Changeset in webkit [139192] by loislo@chromium.org
  • 14 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: fix instrumentation for already instrumented classes 1/N
https://bugs.webkit.org/show_bug.cgi?id=106445

Reviewed by Vsevolod Vlasov.

The patch has almost mechanical changes.

  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8ValueCache.cpp:

(WTF):
(WebCore::StringCache::reportMemoryUsage):
(WebCore):

  • dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):

  • dom/ElementRareData.cpp:

(WebCore::ElementRareData::reportMemoryUsage):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::reportMemoryUsage):

  • page/Frame.cpp:

(WebCore::Frame::reportMemoryUsage):

  • page/Page.cpp:

(WebCore::Page::reportMemoryUsage):

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::reportMemoryUsage):

  • platform/network/FormData.cpp:

(WebCore::FormData::reportMemoryUsage):
(WebCore):
(WebCore::FormDataElement::reportMemoryUsage):

  • platform/network/FormData.h:

(FormDataElement):

  • rendering/RenderView.cpp:

(WebCore::RenderView::reportMemoryUsage):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::reportMemoryUsage):

6:53 AM BuildingGtk edited by calvaris@igalia.com
(diff)
6:31 AM Changeset in webkit [139191] by fmalita@chromium.org
  • 51 edits
    2 adds in trunk

[Skia] Implement GraphicsContext::fillRoundedRect() using SkCanvas::drawRRect()
https://bugs.webkit.org/show_bug.cgi?id=106366

Reviewed by Stephen White.

Source/WebCore:

Skia provides rounded-rect primitives, so we can avoid degrading fillRoundedRect() to
drawPath().

Due to subtle pixel differences (not visually noticeable), switching from drawPath() to
drawRRect() requires rebaselining some of the existing results.

No new tests: coverage provided by existing tests.

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::fillRoundedRect):

  • platform/graphics/skia/PlatformContextSkia.h:

(WebCore::PlatformContextSkia::drawRRect):
(WebCore):

LayoutTests:

  • platform/chromium-linux/compositing/video/video-controls-layer-creation-expected.png:
  • platform/chromium-linux/fast/backgrounds/background-leakage-expected.png:
  • platform/chromium-linux/fast/backgrounds/background-leakage-transforms-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
  • platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
  • platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-linux/fast/box-shadow/box-shadow-clipped-slices-expected.png:
  • platform/chromium-linux/fast/box-shadow/spread-expected.png:
  • platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-linux/fast/css/shadow-multiple-expected.png:
  • platform/chromium-linux/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-linux/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-linux/fast/layers/video-layer-expected.png:
  • platform/chromium-linux/fast/regions/full-screen-video-from-region-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-linux/fast/transforms/shadows-expected.png:
  • platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.png:
  • platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background-color-applied-to-rounded-inline-element-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png:
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
  • platform/chromium-linux/media/audio-controls-rendering-expected.png:
  • platform/chromium-linux/media/audio-repaint-expected.png:
  • platform/chromium-linux/media/controls-after-reload-expected.png:
  • platform/chromium-linux/media/controls-layout-direction-expected.png:
  • platform/chromium-linux/media/controls-strict-expected.png:
  • platform/chromium-linux/media/controls-styling-expected.png:
  • platform/chromium-linux/media/controls-styling-strict-expected.png:
  • platform/chromium-linux/media/controls-without-preload-expected.png:
  • platform/chromium-linux/media/media-controls-clone-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-empty-source-expected.png:
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-playing-and-pause-expected.png:
  • platform/chromium-linux/media/video-zoom-controls-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/video/video-controls-layer-creation-expected.png: Added.
  • platform/chromium/TestExpectations:
6:13 AM Changeset in webkit [139190] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skipping failing tests after r139141, r139145.

  • platform/efl/TestExpectations:
5:59 AM Changeset in webkit [139189] by abecsi@webkit.org
  • 7 edits in trunk/Source/WebKit2

[Qt][EFL][WK2] Remove redundant device pixel ratio adjustment from PageViewportController
https://bugs.webkit.org/show_bug.cgi?id=106355

Reviewed by Kenneth Rohde Christiansen.

Since r137597 Qt uses the device pixel ratio of the underlying
platform window as the device pixel ratio in WebCore.
The tiles are rendered with the effective scale (scale adjusted with
the device scale factor) and the projection matrix is also adjusted
with the device pixel ratio when painting.
As a result we can follow the same approach as QtQuick and all the
coordinates in PageViewportController need to be in device independent
pixels (UI pixels) thus we do no longer need to adjust with the device
pixel ratio when calculating the viewport attributes.
This simplifies the logic significantly and increases robustness,
but does not allow to set a custom device pixel ratio different from
the factor of the underlying platform (eg. for testing purposes).
This patch is conceptually a follow-up of r137597 and fixes layout
and canvas size on retina display.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::innerBoundedViewportScale):
(WebKit::PageViewportController::outerBoundedViewportScale):
(WebKit::PageViewportController::pixelAlignedFloatPoint):
(WebKit::PageViewportController::boundContentsPosition):
(WebKit::PageViewportController::didRenderFrame):
(WebKit::PageViewportController::pageTransitionViewportReady):
(WebKit::PageViewportController::didChangeContentsVisibility):
(WebKit::PageViewportController::syncVisibleContents):
(WebKit::PageViewportController::visibleContentsSize):
(WebKit::PageViewportController::applyScaleAfterRenderingContents):
(WebKit::PageViewportController::updateMinimumScaleToFit):

  • UIProcess/PageViewportController.h:

(WebKit::PageViewportController::currentContentsScale):
(PageViewportController):

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::updateViewportSize):
Adjust the viewport size with the device pixel ratio to keep previous
behaviour.

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::focusEditableArea):
(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):

  • UIProcess/qt/QtWebPageSGNode.cpp:

(WebKit::ContentsSGNode::clipRect):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendViewportAttributesChanged):

5:33 AM Changeset in webkit [139188] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: cannot undock inspector when window size is too small
https://bugs.webkit.org/show_bug.cgi?id=106054

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-01-09
Reviewed by Pavel Feldman.

Consider dockingUnavailable flag only when dockSide is in undocked
state.

  • inspector/front-end/DockController.js:

(WebInspector.DockController.prototype._updateUI.get document):

5:32 AM Changeset in webkit [139187] by mnaganov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Unreviewed: A trivial fix for WebFrameTest.DivAutoZoomParamsTest after r139177.

  • tests/WebFrameTest.cpp:
5:31 AM Changeset in webkit [139186] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] WebGL content is incomplete when using multiple canvas
https://bugs.webkit.org/show_bug.cgi?id=106313

While we are using double buffering for WebGL,
we do not use a drawable that implements a mechanism
for swapping buffers.
Therefore we have to make sure that all GL commands
have been executed properly before copying the texture
onto the GraphicsSurface.

Reviewed by Simon Hausmann.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebufferAndRestoreContext):

4:07 AM Changeset in webkit [139185] by mikhail.pozdnyakov@intel.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaselining of media/video-controls-captions.html.

  • platform/efl/media/video-controls-captions-expected.txt: Added.
4:03 AM Changeset in webkit [139184] by Carlos Garcia Campos
  • 8 edits in trunk/Source

Unreviewed. Fix make distcheck.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Add mips.rb to offlineasm_nosources.

Source/WebCore:

  • GNUmakefile.list.am: Add missing headers.

Source/WebKit2:

  • GNUmakefile.list.am: Add missing headers.

Source/WTF:

  • GNUmakefile.list.am: Add missing header.
3:53 AM Changeset in webkit [139183] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skipping failing tests after r139111, r139140.

  • platform/efl/TestExpectations:
3:25 AM Changeset in webkit [139182] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt][Mac] GraphicsSurface does not need glEnable/glDisable for texture targets.
https://bugs.webkit.org/show_bug.cgi?id=106310

glEnable/glDisable for texture targets is only necessary
when using the fixed function pipeline.
Enabling or disabling the target might cause unexpected
behavior to texture bindings and is therefore considered harmful.

Reviewed by Noam Rosenthal.

  • platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:

(WebCore::createTexture):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(WebCore::GraphicsSurface::platformCopyToGLTexture):

3:23 AM Changeset in webkit [139181] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/LayoutTests

EFL port gardening after r139145, r139002.

Unreviewed gardening.

  • platform/efl/TestExpectations:
3:15 AM Keeping the Tree Green edited by Christophe Dumez
Add link to EFL port gardening schedule (diff)
2:21 AM Changeset in webkit [139180] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/win

[WinCairo] Link fix after r138759
https://bugs.webkit.org/show_bug.cgi?id=106323

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-01-09
Reviewed by Kentaro Hara.

  • WebKit.vcproj/WebKitLibDebugCairoCFLite.vsprops: Include WebKitCFLite.vsprops.
  • WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops: Include WebKitCFLite.vsprops.
2:18 AM Changeset in webkit [139179] by apavlov@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebCore/inspector/front-end/SettingsScreen.js

Merge 138144

Web Inspector: [REGRESSION] The last remembered tab is not restored when the Settings dialog is opened
https://bugs.webkit.org/show_bug.cgi?id=105414

Reviewed by Vsevolod Vlasov.

Do not force the "General" tab when opening settings upon the Cog button click.

  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsController.prototype._mouseUp):

TBR=apavlov@chromium.org
Review URL: https://codereview.chromium.org/11819026

2:14 AM Changeset in webkit [139178] by apavlov@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebCore/inspector/front-end/StylesSidebarPane.js

Merge 138022

Web Inspector: [Styles] Selector matches are not marked after property editing
https://bugs.webkit.org/show_bug.cgi?id=105284

Reviewed by Vsevolod Vlasov.

Once a property edit is committed, the selector markup is reset and needs to be re-applied.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertiesSection.prototype.update):

TBR=apavlov@chromium.org
Review URL: https://codereview.chromium.org/11819025

1:37 AM Changeset in webkit [139177] by mnaganov@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] When viewport is disabled, use display width in DIP pixels for the fallback width
https://bugs.webkit.org/show_bug.cgi?id=106021

This is to emulate 'UseWideViewport' setting of Android WebView properly.
'UseWideViewport' now corresponds to the 'viewportEnabled' setting.
When the value is false, "meta viewport" tag is ignored, and when calculating
layout width, display width in DIP pixels is used.

Reviewed by Adam Barth.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::dipSize):
(WebKit):

  • src/WebViewImpl.h:

(WebCore):
(WebViewImpl):

1:36 AM Changeset in webkit [139176] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Removed crash expectations from tests that have been passing per bugs 105566, 105567, and 105580.

  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
1:26 AM Changeset in webkit [139175] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] fast/frames/frame-limit.html can be slow in release
https://bugs.webkit.org/show_bug.cgi?id=106126

Unreviewed gardening.

  • platform/chromium/TestExpectations: Add Slow expectation for Win and Linux.

[ Win Linux Release ] fast/frames/frame-limit.html [ Pass Slow ]

1:22 AM Changeset in webkit [139174] by commit-queue@webkit.org
  • 7 edits in trunk

INPUT_MULTIPLE_FIELDS_UI: min/max attributes should not make all fields read-only
https://bugs.webkit.org/show_bug.cgi?id=106422

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-01-09
Reviewed by Kent Tamura.

Source/WebCore:

Do not make day-field of date input and month-field of month input readonly
even if min and max are the same.

Tests: fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html

fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield.html

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitField): Added check for date type.

LayoutTests:

  • fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield-expected.txt:
  • fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html: Update expectations.
  • fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield-expected.txt:
  • fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield.html: Ditto.
1:20 AM Changeset in webkit [139173] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r139134.
http://trac.webkit.org/changeset/139134
https://bugs.webkit.org/show_bug.cgi?id=106424

WebGL tests still crash on EFL (Requested by MPozdnyakov on

#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-09

  • platform/efl/TestExpectations:
12:53 AM Changeset in webkit [139172] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

INPUT_MULTIPLE_FIELDS_UI: Step-up/-down of week field should respect min/max attributes
https://bugs.webkit.org/show_bug.cgi?id=106416

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-01-09
Reviewed by Kent Tamura.

Source/WebCore:

Make step-up/-down of the week field respect the min/max attributes of the element.
Note that it still accepts any keyboard inputs (the element
becomes 'invalid' state when out-of-range values entered).

Tests: fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield.html

fast/forms/week-multiple-fields/week-multiple-fields-stepup-stepdown-from-renderer.html

  • css/html.css: Add a CSS rule for week field.
  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitField):
Compute minimum/maximum values of week field from the min/max parameters of the element.

  • html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeWeekFieldElement::DateTimeWeekFieldElement): Add mininum/maximum arguments.
(WebCore::DateTimeWeekFieldElement::create): Ditto.
(WebCore::DateTimeWeekFieldElement::clampValueForHardLimits): Added.

  • html/shadow/DateTimeFieldElements.h:

(DateTimeWeekFieldElement): Add mininum/maximum arguments and declare clampValueForHardLimits.

LayoutTests:

  • fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield.html: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Added.
  • fast/forms/week-multiple-fields/week-multiple-fields-stepup-stepdown-from-renderer.html: Added.
12:32 AM Changeset in webkit [139171] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Tighten svg/custom/feComponentTransfer-Table.svg on windows
https://bugs.webkit.org/show_bug.cgi?id=106126

Unreviewed gardening. Bot reports:

Regressions: Unexpected image-only failures (1)

svg/custom/feComponentTransfer-Table.svg [ ImageOnlyFailure ]

  • platform/chromium/TestExpectations: So change Failure -> ImageOnlyFailure

to silence the bot.

12:22 AM Changeset in webkit [139170] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a flaky timeout expectation for fast/workers/worker-close-more.html
that regressed with r139145.

  • platform/gtk/TestExpectations:

Jan 8, 2013:

11:41 PM Changeset in webkit [139169] by tasak@google.com
  • 3 edits in trunk/LayoutTests

Use window.WebKitShadowRoot for checking whether a node is shadow root or not.
https://bugs.webkit.org/show_bug.cgi?id=88748

Reviewed by Hajime Morita.

  • fast/dom/shadow/resources/shadow-dom.js:

(isShadowRoot):
Modified to use window.WebKitShadowRoot instead of node name.

  • resources/dump-as-markup.js:

(Markup.get var):
Added shadowRootList which has information about whether the given node
is a shadow root or not.
(Markup):
(Markup._get):
If the given element is a document fragment and its address is in
shadowRootList, use "<shadow:root>".
(Markup._getShadowHostIfPossible):
Only this method uses internals.shadowRoot and obtains the youngest
shadow root from the given node. So update shadowRootList in this
method.

11:12 PM Changeset in webkit [139168] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

Assertion Failure in WebCore::RenderLayerCompositor::updateCompositingLayers.
https://bugs.webkit.org/show_bug.cgi?id=106419.

Unreviewed.

Updated Expectations.

  • platform/mac/TestExpectations:
11:09 PM Changeset in webkit [139167] by noel.gordon@gmail.com
  • 1 edit
    2 adds in trunk/LayoutTests

[chromium] Unreviewed gardening. Update fast/events/touch/compositor-touch-hit-rects on linux

  • platform/chromium-linux/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt: Added.
10:55 PM Changeset in webkit [139166] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Caret is incorrectly painted for a contenteditable <div> containing a <br> in vertical writing mode
https://bugs.webkit.org/show_bug.cgi?id=103621

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2013-01-08
Reviewed by Ryosuke Niwa.

Source/WebCore:

While computing the caret rect for the given specific scenario, we
canonicalize our position. For the upstream (or downstream) block flow
candidates a check to ignore the nodes having renderers with zero height
is carried out. This is where we fail our check in the vertical writing mode.

In the vertical writing mode, instead of verifying the height of the descendants
of the candidate nodes, a check for their width should be carried out.

For our case, i.e. the <br> element contained inside the div, the bounding box
in the vertical writing mode would have a width greater than zero and height
equal to zero (as is to be expected in the vertical mode).

Thus, we need to make a check against the logical height. For the vertical
writing mode, the logical height should return the width of the computed
bounding box.

Test: editing/selection/caret-in-div-containing-br-in-vertical-mode.html

  • dom/Position.cpp:

(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
Have modified the code to verify against the logical height, instead
of simply the height, both in case of RenderText and RenderBox.
The logical height of the computed rects returns a value according
to the writing mode.

For the RenderText a new function, linesLogicalBoundingBox() is called
which returns the values depending on the writing mode.
Similarly, on the RenderBox, pixelSnappedLogicalHeight() is called which
too takes care of the writing mode internally. (borderBoundingBox()
internally calls on the pixelSnappedRect).

  • rendering/RenderText.cpp:

(WebCore::RenderText::linesLogicalBoundingBox):
(WebCore):

  • rendering/RenderText.h:

(RenderText):
New function is added to return the logical linesBoundingBox, i.e.,
the width and height of the linesBoundingBox are set according to
the writing mode.

LayoutTests:

  • editing/selection/caret-in-div-containing-br-in-vertical-mode-expected.txt: Added.
  • editing/selection/caret-in-div-containing-br-in-vertical-mode.html: Added.

Testcase added for verifying the caret display at the start of an editable
div containing only a <br> element in vertical writing mode.

10:42 PM Changeset in webkit [139165] by crogers@google.com
  • 5 edits in trunk/Source

Remove unused/deprecated render() method in chromium WebKit API
https://bugs.webkit.org/show_bug.cgi?id=106399

Reviewed by Kent Tamura.

Source/Platform:

  • chromium/public/WebAudioDevice.h:

Source/WebKit/chromium:

  • src/AudioDestinationChromium.cpp:
  • src/AudioDestinationChromium.h:

(AudioDestinationChromium):

10:39 PM Changeset in webkit [139164] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing tests.

  • platform/qt/TestExpectations:
10:33 PM Changeset in webkit [139163] by noel.gordon@gmail.com
  • 1 edit
    1 move in trunk/LayoutTests

[chromium] Rebaseline and optimise fast/regions/full-screen-video-from-region on Win7 and Win XP

Unreviewed gardening.

  • platform/chromium-win/fast/regions/full-screen-video-from-region-expected.png: Renamed from LayoutTests/platform/chromium-win-xp/fast/regions/full-screen-video-from-region-expected.png.
10:26 PM Changeset in webkit [139162] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip new failing tests.

  • platform/qt/TestExpectations:
9:32 PM Changeset in webkit [139161] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove a few unused includes from HTMLTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=106401

Reviewed by Adam Barth.

I happened to notice these while attempting to remove non-thread friendly deps from HTMLTreeBuilder.

No new tests because no new functionality.

  • html/parser/HTMLTreeBuilder.cpp:
9:30 PM Changeset in webkit [139160] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

A couple of fast/workers tests fail after http://trac.webkit.org/projects/webkit/changeset/139145.
https://bugs.webkit.org/show_bug.cgi?id=106415.

Unreviewed.

Updated Expectations.

  • platform/mac/TestExpectations:
9:26 PM Changeset in webkit [139159] by gyuyoung.kim@samsung.com
  • 28 edits in trunk

Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
https://bugs.webkit.org/show_bug.cgi?id=106290

Reviewed by Martin Robinson.

Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
the macro isn't enabled.

Source/WebCore:

  • accessibility/atk/AXObjectCacheAtk.cpp:
  • accessibility/atk/WebKitAccessibleHyperlink.h:
  • accessibility/atk/WebKitAccessibleInterfaceAction.cpp:
  • accessibility/atk/WebKitAccessibleInterfaceAction.h:
  • accessibility/atk/WebKitAccessibleInterfaceComponent.cpp:
  • accessibility/atk/WebKitAccessibleInterfaceDocument.cpp:
  • accessibility/atk/WebKitAccessibleInterfaceDocument.h:
  • accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp:
  • accessibility/atk/WebKitAccessibleInterfaceEditableText.h:
  • accessibility/atk/WebKitAccessibleInterfaceHyperlinkImpl.cpp:
  • accessibility/atk/WebKitAccessibleInterfaceHyperlinkImpl.h:
  • accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp:
  • accessibility/atk/WebKitAccessibleInterfaceImage.cpp:
  • accessibility/atk/WebKitAccessibleInterfaceImage.h:
  • accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:
  • accessibility/atk/WebKitAccessibleInterfaceSelection.h:
  • accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
  • accessibility/atk/WebKitAccessibleInterfaceTable.h:
  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:
  • accessibility/atk/WebKitAccessibleInterfaceText.h:
  • accessibility/atk/WebKitAccessibleInterfaceValue.cpp:
  • accessibility/atk/WebKitAccessibleInterfaceValue.h:
  • accessibility/atk/WebKitAccessibleUtil.cpp:
  • accessibility/atk/WebKitAccessibleUtil.h:
  • accessibility/atk/WebKitAccessibleWrapperAtk.h:

Tools:

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
9:21 PM Changeset in webkit [139158] by commit-queue@webkit.org
  • 4 edits in trunk/WebKitLibraries

Add WebKitSystemInterface needed for overriding system proxies on Mac
https://bugs.webkit.org/show_bug.cgi?id=106410

Patch by Kiran Muppala <cmuppala@apple.com> on 2013-01-08
Reviewed by Stephanie Lewis.

This patch is in anticipation of the fix for https://bugs.webkit.org/show_bug.cgi?id=104197,
Add user defaults to override system proxy settings for NetworkProcess on Mac, which
is awaiting the approval of a WebKit2 committer. Commiting the WKSI portion separately,
so that the internal repository commit for generating the WKSI libraries does not have to
be rolled back every time the rest of the patch changes.

Add WKCFNetworkSetOverrideSystemProxySettings(), needed by NetworkProcess to set
custom proxies during initialization.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
9:21 PM Changeset in webkit [139157] by yosin@chromium.org
  • 2 edits
    2 deletes in trunk/Source/WebKit/chromium

Remove WebKit/chromium/src/DragScrollTimer.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=106403

This patch removes unused file DragScrollTimer.{cpp,h} obsoleted by
r139044.

Reviewed by Hajime Morita.

  • WebKit.gyp: Changed to remove lines for DragScroll.{cpp.h}.
  • src/DragScrollTimer.cpp: Removed.
  • src/DragScrollTimer.h: Removed.
9:11 PM Changeset in webkit [139156] by weinig@apple.com
  • 1 edit
    1 add in trunk/Source/WebKit2

Add Owners file.

  • Owners: Added.
9:01 PM Changeset in webkit [139155] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

Assertion failure in WebCore::HTMLConstructionSite::HTMLConstructionSite.
https://bugs.webkit.org/show_bug.cgi?id=106412.

Unreviewed.

Updating Expectations.

  • platform/mac/TestExpectations:
8:46 PM Changeset in webkit [139154] by falken@chromium.org
  • 3 edits
    6 adds in trunk

Make NodeRenderingContext::parentRenderer and nextRenderer top layer aware
https://bugs.webkit.org/show_bug.cgi?id=103477

Reviewed by Hajime Morita.

Source/WebCore:

Original patch by Elliott Sprehn (minor code and layout tests added).

Instead of using adjustInsertionPointForTopLayerElement and reassigning
pointers passed by reference we should just make nextRenderer and parentRenderer
handle the top layer properly. Right now they would return the wrong values
since we only correctly handle the top layer during renderer creation.

This makes handling of top layer elements consistent with handling of
other special renderering systems like flow threads.

Tests: fast/dom/HTMLDialogElement/modal-dialog-in-replaced-renderer.html

fast/dom/HTMLDialogElement/modal-dialog-in-table-column.html
fast/dom/HTMLDialogElement/modal-dialog-sibling.html

  • dom/NodeRenderingContext.cpp:

(WebCore::isRendererReparented): Added this helper function. We must skip
renderers that are reparented in nextRenderer and previousRenderer.
(WebCore):
(WebCore::adjustInsertionPointForTopLayerElement): Removed this method.
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::createRendererForElementIfNeeded):

LayoutTests:

  • fast/dom/HTMLDialogElement/modal-dialog-in-replaced-renderer-expected.html: Added.
  • fast/dom/HTMLDialogElement/modal-dialog-in-replaced-renderer.html: Added.
  • fast/dom/HTMLDialogElement/modal-dialog-in-table-column-expected.html: Added.
  • fast/dom/HTMLDialogElement/modal-dialog-in-table-column.html: Added.
  • fast/dom/HTMLDialogElement/modal-dialog-sibling-expected.html: Added.
  • fast/dom/HTMLDialogElement/modal-dialog-sibling.html: Added.
8:41 PM Changeset in webkit [139153] by hayato@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Shadow DOM] The MouseEvent offsetX and offsetY attributes must return the coordinates relative to the origin of the padding edge of the relative target after retargeting.
https://bugs.webkit.org/show_bug.cgi?id=104509

Reviewed by Dimitri Glazkov.

Adding a test for making sure that MouseEvent offsetX and offsetY arrributes are adjusted in retargeting.

  • fast/dom/shadow/shadow-dom-mouse-event-adjust-offset-expected.txt: Added.
  • fast/dom/shadow/shadow-dom-mouse-event-adjust-offset.html: Added.
8:35 PM Changeset in webkit [139152] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. jquery/event.html timeouts in release and debug.

  • platform/chromium/TestExpectations:
8:17 PM Changeset in webkit [139151] by tkent@chromium.org
  • 6 edits in trunk

REGRESSION(r135836): Invalid user input for input[type=number] should be cleared by input.value=""
https://bugs.webkit.org/show_bug.cgi?id=106284

Reviewed by Hajime Morita.

Source/WebCore:

No new tests. Updates fast/forms/number/number/validity-badinput.html.

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::setValue):
If the new sanitized value is empty and innerTextValue is a bad input
(it means !valueChanged && !innerTextValue().isEmpty() because the new
sanitized value is empty), we need to update innerTextValue with the
empty string.

  • html/NumberInputType.h:

(NumberInputType): Declare setValue.

LayoutTests:

  • fast/forms/number/number-validity-badinput.html:

Add a test case.

  • fast/forms/number/number-validity-badinput-expected.txt:
7:30 PM Changeset in webkit [139150] by Nate Chapin
  • 6 edits in trunk

REGRESSION(r138222?): [Mac WK1] http/tests/appcache/main-resource-redirect.html asserts in WebFrameLoaderClient::dispatchDidFinishLoading
https://bugs.webkit.org/show_bug.cgi?id=106123

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests, fixing an existing test.

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::continueAfterNavigationPolicy): Before calling m_resource->removeClient(this)

and potentially canceling the ResourceLoader, ensure it won't send resource load callbacks.

  • loader/ResourceLoader.h:

(WebCore::ResourceLoader::setSendCallbackPolicy):

LayoutTests:

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations: main-resource-redirect.html is no longer crashing.
7:28 PM Changeset in webkit [139149] by Martin Robinson
  • 2 edits in trunk/LayoutTests

[EFL] [WK2] Some authentication tests fail in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=106407

  • platform/efl-wk2/TestExpectations: Skip some tests failing for EFL

on WebKit2.

7:22 PM Changeset in webkit [139148] by Martin Robinson
  • 2 edits in trunk/LayoutTests

[Mac] Authentication tests fail even after r139140
https://bugs.webkit.org/show_bug.cgi?id=106405

  • platform/mac-wk2/TestExpectations: Skip authentication tests that are still

failing in WebKit2 on Mac.

7:21 PM Changeset in webkit [139147] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Layout Test fast/css-grid-layout/grid-columns-rows-get-set-multiple.html, grid-columns-rows-get-set.html is failing
https://bugs.webkit.org/show_bug.cgi?id=104090

Unreviewed gardening.

  • platform/chromium/TestExpectations:

In r139025, the not-totally-OK call to GridTrackSize::length() was removed and thus the
tests don't trigger an ASSERT anymore. This change merrily re-enable them.

6:57 PM Changeset in webkit [139146] by Alexandru Chiculita
  • 5 edits
    4 adds in trunk

Assert in RenderGeometryMap::mapToContainer
https://bugs.webkit.org/show_bug.cgi?id=106068

Reviewed by Simon Fraser.

Source/WebCore:

The assert was due to a pending layout, so the values used to compute the layer bounding boxes were incorrect.
That was because of the Document::setVisualUpdatesAllowed mechanism, which triggers a compositor update
and a repaint, but before this patch didn't check whether a layout was pending or not.

Added a check in Document::setVisualUpdatesAllowed for pending layouts and bailed when such case happened.
A layout will come anyway and trigger the correct updates. Couldn't not force an inline layout at that time
as this function is sometimes called really soon, when the WebKit parts are not fully created yet and updates were
calling back into some client callbacks that were not ready.

Also added an assert in RenderLayerCompositor::updateCompositingLayers to check for other cases that might
try to update the layers with a layout pending. That one led to finding an issue in the RenderMarquee, which
was updating on a timer callback. It might happen that a layout is pending while this timer fires and it
tries to update the scroll position of the layers while a layout is still due.

There was already a protection to bail if a layout is pending in RenderMarquee::timerFired, so I've just broadened the scope
to the whole RenderView to catch all the layout requests.

Tests: compositing/geometry/assert-layout-not-done.html

compositing/geometry/assert-marquee-timer.html

  • dom/Document.cpp:

(WebCore::Document::setVisualUpdatesAllowed):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::timerFired):

LayoutTests:

  • compositing/geometry/assert-layout-not-done-expected.txt: Added.
  • compositing/geometry/assert-layout-not-done.html: Added. Testing for the case when compositor is triggered before the first layout.
  • compositing/geometry/assert-marquee-timer-expected.txt: Added.
  • compositing/geometry/assert-marquee-timer.html: Added. Tested for the case when the marquee might trigger compositor updates, while a layout is still pending.
6:37 PM Changeset in webkit [139145] by oliver@apple.com
  • 20 edits in trunk/Source/JavaScriptCore

Support op_typeof in the DFG
https://bugs.webkit.org/show_bug.cgi?id=98898

Reviewed by Filip Pizlo.

Adds a TypeOf node to the DFG to support op_typeof.

To avoid adding too much GC horror, this also makes the
common strings portion of the SmallString cache strongly
referenced.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

We try to determine the result early here, and substitute in a constant.
Otherwise we leave the node intact, and set the result type to SpecString.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

Parse op_typeof

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

TypeOf nodes can be subjected to pure CSE

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

We can handle typeof.

  • dfg/DFGNodeType.h:

(DFG):

Define the node.

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h: Add operationTypeOf to support the non-trivial cases.
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

Actual codegen

  • runtime/Operations.cpp:

(JSC::jsTypeStringForValue):
(JSC):

  • runtime/Operations.h:

(JSC):

Some refactoring to allow us to get the type string for an
object without needing a callframe.

6:30 PM Changeset in webkit [139144] by junov@google.com
  • 2 edits in trunk/Source/WebCore

CanvasRenderingContext2D::setFont argument may reference destroyed object
https://bugs.webkit.org/show_bug.cgi?id=106385

Reviewed by Abhishek Arya.

No new tests: covered by fast/canvas/canvas-measureText.html

This is a re-write of r138994. Fixing bug in setFont instead of
workaround at call site.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):
(WebCore::CanvasRenderingContext2D::accessFont):

6:28 PM Changeset in webkit [139143] by dgrogan@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Provide LevelDB with IDBEnv instead of Env::Default
https://bugs.webkit.org/show_bug.cgi?id=106135

Reviewed by Tony Chang.

IDBEnv only changes the name of the histogram where errors are logged.

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::openInMemory):

6:21 PM Changeset in webkit [139142] by commit-queue@webkit.org
  • 13 edits
    3 adds in trunk

Make WebGLRenderingContext inherit from ActiveDOMObject
https://bugs.webkit.org/show_bug.cgi?id=104733

Patch by Brandon Jones <bajones@chromium.org> on 2013-01-08
Reviewed by Adam Barth.

Source/WebCore:

When ActiveDOMObject::stop is called on the WebGLRenderingContext the
DrawingBuffer and GraphicsContext3D instances are forcibly released in
order to keep GPU memory utilization to a minimum.

Incorporated new layout test based on one just added to the WebGL
conformance suite. Also tested manually by reloading and
navigating between many WebGL apps.

Test: fast/canvas/webgl/context-release-upon-reload.html

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

Removed garbage collection hack added in Bug 76255.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::create):

Call suspendIfNeeded per ActiveDOMObject contract.

(WebCore::WebGLRenderingContext::WebGLRenderingContext):

Call ActiveDOMObject constructor.

(WebCore::WebGLRenderingContext::~WebGLRenderingContext):

Call destroyGraphicsContext3D.

(WebCore::WebGLRenderingContext::destroyGraphicsContext3D):

Drop DrawingBuffer backing store and delete GraphicsContext3D.

(WebCore::WebGLRenderingContext::hasPendingActivity):

Always return false.

(WebCore::WebGLRenderingContext::stop):

Force lost context upon page reload or navigation.

  • html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

Inherit from ActiveDOMObject and override notifications.

  • platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:

(WebCore):
(WebCore::DrawingBuffer::clearPlatformLayer):

Add currently no-op implementation.

  • platform/graphics/cairo/DrawingBufferCairo.cpp:

(WebCore):
(WebCore::DrawingBuffer::clearPlatformLayer):

Add currently no-op implementation.

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBufferPrivate::clearTextureId):

Clear texture ID from compositor's layer.

(DrawingBufferPrivate):
(WebCore::DrawingBuffer::framebuffer):

Moved around to reduce number of #ifdefs.

(WebCore):
(WebCore::DrawingBuffer::platformLayer):
(WebCore::DrawingBuffer::clearPlatformLayer):

Tell compositor to stop referencing DrawingBuffer's texture.

  • platform/graphics/clutter/DrawingBufferClutter.cpp:

(WebCore):
(WebCore::DrawingBuffer::clearPlatformLayer):

Add currently no-op implementation.

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::clear):

Call clearPlatformLayer before deleting OpenGL resources.

  • platform/graphics/gpu/DrawingBuffer.h:

(DrawingBuffer):

Add clearPlatformLayer.

  • platform/graphics/gpu/mac/DrawingBufferMac.mm:

(WebCore):
(WebCore::DrawingBuffer::clearPlatformLayer):

Add currently no-op implementation.

  • platform/graphics/gpu/qt/DrawingBufferQt.cpp:

(WebCore):
(WebCore::DrawingBuffer::clearPlatformLayer):

Add currently no-op implementation.

LayoutTests:

  • fast/canvas/webgl/context-release-upon-reload-expected.txt: Added.
  • fast/canvas/webgl/context-release-upon-reload.html: Added.
  • fast/canvas/webgl/resources/context-release-upon-reload-child.html: Added.
5:43 PM Changeset in webkit [139141] by tonyg@chromium.org
  • 6 edits in trunk/Source/WebCore

Remove dependency on Document from HTMLConstructionSite::inQuirksMode()
https://bugs.webkit.org/show_bug.cgi?id=106375

Reviewed by Adam Barth.

This is another step towards removing main thread object dependencies
from the parser.

No new tests because no new functionality.

  • dom/Document.h:
  • html/HTMLDocument.cpp:
  • html/HTMLDocument.h:

(HTMLDocument):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::HTMLConstructionSite):
(WebCore::HTMLConstructionSite::setDefaultCompatibilityMode):
(WebCore):
(WebCore::HTMLConstructionSite::setCompatibilityMode):
(WebCore::HTMLConstructionSite::setCompatibilityModeFromDoctype):
(WebCore::HTMLConstructionSite::insertDoctype):
(WebCore::HTMLConstructionSite::inQuirksMode):

  • html/parser/HTMLConstructionSite.h:

(HTMLConstructionSite):

5:41 PM Changeset in webkit [139140] by Martin Robinson
  • 10 edits in trunk

WebKitTestRunner needs support for setHandlesAuthenticationChallenges
https://bugs.webkit.org/show_bug.cgi?id=103653

Reviewed by Anders Carlsson.

Tools:

Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
client callback.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner

methods to the JavaScript API.

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
(WTR::TestRunner::setAuthenticationUsername): Ditto.
(WTR::TestRunner::setAuthenticationPassword): Ditto.

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner): Added new declarations for the above.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
callback.
(WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
(WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
the authentication information passed from the InjectedBundle.

  • WebKitTestRunner/TestController.h:

(WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
to communicate with the TestController.
(WTR::TestController::setAuthenticationUsername): Ditto.
(WTR::TestController::setAuthenticationPassword): Ditto.
(TestController):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
information from the InjectedBundle.
(WTR::TestInvocation::outputText): Added this method so that the TestController can output
text to the TestInvocation text output.

  • WebKitTestRunner/TestInvocation.h:

(TestInvocation): Added declaration for new method.

LayoutTests:

Unskip authentication tests which are now passing.

  • platform/wk2/TestExpectations:
5:41 PM Changeset in webkit [139139] by keishi@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Hiding popups on mouse wheel should be handled by WebViewImpl
https://bugs.webkit.org/show_bug.cgi?id=106312

Reviewed by Kent Tamura.

We had to removed the code that closed popups on mouse wheel events from
content::RenderWidgetHostViewMac because it no longer had access to
child popups. WebViewImpl will hide the popups on mouse wheel events so
we can maintain the same behavior.

https://src.chromium.org/viewvc/chrome?view=rev&revision=175488

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleMouseWheel): Overriding so we can hide popups.
(WebKit):

  • src/WebViewImpl.h:
5:36 PM Changeset in webkit [139138] by fmalita@chromium.org
  • 9 edits in trunk/Source/WebCore

Remove unused GraphicsContext::addInnerRoundedRectClip()
https://bugs.webkit.org/show_bug.cgi?id=106376

Reviewed by Andreas Kling.

Since there don't seem to be any users left for it, remove addInnerRoundedRectClip().

No new tests: no functional changes.

  • platform/graphics/GraphicsContext.h:

(GraphicsContext):

  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/openvg/GraphicsContextOpenVG.cpp:
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore):

  • platform/graphics/wince/GraphicsContextWinCE.cpp:
  • platform/graphics/wx/GraphicsContextWx.cpp:
5:17 PM Changeset in webkit [139137] by junov@google.com
  • 4 edits
    3 adds in trunk

Color bleeding with rounded rectangles on high dpi displays
https://bugs.webkit.org/show_bug.cgi?id=106373

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/backgrounds/gradient-background-leakage-hidpi.html

Avoid using the BackgroundBleedShrinkBackground draw strategy for
RenderBox when border width is less than two layout units. This
is because rounded rectangles are always snapped to integer layout
coordinates, even with subpixel layout enabled.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::determineBackgroundBleedAvoidance):

LayoutTests:

New layout test to verify that rounded rectangle corners do not
produce color bleeding on high dpi devices.

  • fast/backgrounds/gradient-background-leakage-hidpi-expected.txt: Added.
  • fast/backgrounds/gradient-background-leakage-hidpi.html: Added.
  • platform/chromium-linux/fast/backgrounds/gradient-background-leakage-hidpi-expected.png: Added.
5:11 PM Changeset in webkit [139136] by fpizlo@apple.com
  • 5 edits
    3 adds in trunk

DFG shouldn't treat the 'this' argument as being captured if a code block uses arguments
https://bugs.webkit.org/show_bug.cgi?id=106398
<rdar://problem/12439776>

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

This is a possible optimization for inlined calls, and fixes crashes for inlined constructors, in the case
that the inlined code used arguments. The problem was that assuming that 'this' was captured implies the
assumption that it was initialized by the caller, which is wrong for constructors and this.

Also added a pretty essential DFG IR validation rule: we shouldn't have any live locals at the top of the
root block. This helps to catch this bug: our assumption that 'this' was captured in an inlined constructor
that used arguments led to liveness for the temporary that would have held 'this' in the caller being
propagated all the way up to the entrypoint of the function.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::isCaptured):

  • dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::reportValidationContext):
(Validate):
(JSC::DFG::Validate::dumpGraphIfAppropriate):

LayoutTests:

Reviewed by Mark Hahnenberg.

  • fast/js/dfg-inline-constructor-that-uses-arguments-expected.txt: Added.
  • fast/js/dfg-inline-constructor-that-uses-arguments.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-inline-constructor-that-uses-arguments.js: Added.

(Foo):
(bar):

4:59 PM Changeset in webkit [139135] by esprehn@chromium.org
  • 3 edits in trunk/Source/WebCore

Merge getLineAtIndex into RenderBlock::lineAtIndex
https://bugs.webkit.org/show_bug.cgi?id=106379

Reviewed by Eric Seidel.

getLineAtIndex can be merged into lineAtIndex, which was it's only caller.

No new tests, just refactoring.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lineAtIndex):
(WebCore::RenderBlock::lineCount):

  • rendering/RenderBlock.h:

(RenderBlock):

4:47 PM Changeset in webkit [139134] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] WebGL test cases are sometimes crashing
https://bugs.webkit.org/show_bug.cgi?id=104506

Unreviewed gardening.

Enable webgl tests that are passing after recent changes.

Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2013-01-08

  • platform/efl/TestExpectations:
4:44 PM Changeset in webkit [139133] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Unbreak the world.

  • WebProcess/com.apple.WebProcess.sb.in:
4:42 PM Changeset in webkit [139132] by rafaelw@chromium.org
  • 10 edits in trunk/Source/WebCore

[HTMLTemplateElement] Allow <template> content to be inspected
https://bugs.webkit.org/show_bug.cgi?id=105839

Reviewed by Pavel Feldman.

In addition to the plumbing which allows template contents to be
displayed within the inspector, this patch adds a manually-managed
weakref from the template document back to its host document (typically
the creator). This is required so that the inspector agent can be found
for template elements.

  • dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::templateDocument):

  • dom/Document.h:

(Document):
(WebCore::Document::setTemplateDocumentHost):
(WebCore::Document::templateDocumentHost):

  • editing/markup.cpp:

(WebCore::createFragmentForInnerOuterHTML):

  • html/HTMLTemplateElement.cpp:

(WebCore::HTMLTemplateElement::content):

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForNode):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::instrumentingAgentsForDocument):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.hasChildNodes):
(WebInspector.DOMNode.prototype._insertChild):
(WebInspector.DOMNode.prototype._setChildrenPayload):

4:32 PM Changeset in webkit [139131] by morrita@google.com
  • 4 edits in trunk/LayoutTests

Unreviewed, marking drag-and-drop-autoscroll.html

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
4:30 PM Changeset in webkit [139130] by zandobersek@gmail.com
  • 1 edit
    1 add in trunk

Add an Autoconf macro that checks whether a given feature is enabled
https://bugs.webkit.org/show_bug.cgi?id=106380

Reviewed by Martin Robinson.

Add the AC_CHECK_WEBKIT_FEATURE_ENABLED macro. It checks the generated
Source/WebCore/GNUmakefile.features.am file to determine whether the
given feature is enabled or disabled in the build that's being configured.

  • Source/autotools/webkitfeature.m4: Added.
4:29 PM Changeset in webkit [139129] by benjamin@webkit.org
  • 2 edits in trunk/Tools

Add myself as a watcher for Web Geolocation

Unreviewed.

  • Scripts/webkitpy/common/config/watchlist:
4:16 PM Changeset in webkit [139128] by morrita@google.com
  • 17 edits in trunk

[Shadow DOM] Distribution related code on ShadowRoot should be minimized.
https://bugs.webkit.org/show_bug.cgi?id=106282

Reviewed by Dimitri Glazkov.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

ShadowRoot had a certain amount of logic which is dedicated for
node distribution computation. These code is going to be compiled
out (Bug 103339) and better be part of the node distribution
algorithm, which is ScopeContentDistribution class.

This change

  • Renames ShadowRootContentDistributionData to ScopeContentDistribution. New name is concise and a bit more meaningful: It owns per TreeScope distribution state.
  • Moves distribution related code from ShadowRoot to ScopeContentDistribution

No new tests. Refactoring.

  • WebCore.exp.in:
  • css/StyleScopeResolver.cpp:

(WebCore::StyleScopeResolver::styleSharingCandidateMatchesHostRules):
(WebCore::StyleScopeResolver::matchHostRules):

  • dom/ComposedShadowTreeWalker.cpp:

(WebCore::nodeCanBeDistributed):
(WebCore::ComposedShadowTreeWalker::traverseBackToYoungerShadowRoot):
(WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost):
(WebCore::AncestorChainWalker::parent):

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::collectSelectFeatureSetFrom):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::insertedInto):
(WebCore::ShadowRoot::removedFrom):
(WebCore::ShadowRoot::ensureScopeDistribution):
(WebCore::ShadowRoot::reportMemoryUsage):

  • dom/ShadowRoot.h:

(WebCore):
(ShadowRoot):
(WebCore::ShadowRoot::scopeDistribution):

  • html/shadow/ContentDistributor.cpp:

(WebCore::ScopeContentDistribution::ScopeContentDistribution):
(WebCore::ScopeContentDistribution::invalidateInsertionPointList):
(WebCore::ScopeContentDistribution::ensureInsertionPointList):
(WebCore::ScopeContentDistribution::registerInsertionPoint):
(WebCore::ScopeContentDistribution::unregisterInsertionPoint):
(WebCore::ScopeContentDistribution::hasShadowElement):
(WebCore):
(WebCore::ScopeContentDistribution::hasContentElement):
(WebCore::ScopeContentDistribution::countElementShadow):
(WebCore::ScopeContentDistribution::hasInsertionPoint):
(WebCore::ScopeContentDistribution::assignedTo):
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::invalidate):

  • html/shadow/ContentDistributor.h:

(ScopeContentDistribution):
(WebCore::ScopeContentDistribution::registerElementShadow):
(WebCore::ScopeContentDistribution::unregisterElementShadow):
(WebCore::ScopeContentDistribution::hasElementShadow):

  • html/shadow/HTMLShadowElement.cpp:

(WebCore::HTMLShadowElement::olderShadowRoot):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::insertedInto):
(WebCore::InsertionPoint::removedFrom):
(WebCore::InsertionPoint::contains):
(WebCore):
(WebCore::resolveReprojection):

  • html/shadow/InsertionPoint.h:

(InsertionPoint):
(WebCore):

  • testing/Internals.cpp:

(WebCore::Internals::hasShadowInsertionPoint):
(WebCore::Internals::hasContentElement):
(WebCore::Internals::countElementShadow):

Source/WebKit/win:

  • WebKit.vcproj/WebKit.def.in:
4:09 PM Changeset in webkit [139127] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[chromium] Remove transitional #defines from WebKit API headers
https://bugs.webkit.org/show_bug.cgi?id=106381

Patch by James Robinson <jamesr@chromium.org> on 2013-01-08
Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebGraphicsContext3D.h:

Source/WebKit/chromium:

  • public/WebWidget.h:
3:53 PM Changeset in webkit [139126] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Removing the totalusage variable in ChromeClientBB::exceededDatabaseQuota
https://bugs.webkit.org/show_bug.cgi?id=106370

Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-01-08
Reviewed by Yong Li.

Removing totalUsage in ChromeClientBlackBerry as we no longer use that variable.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):

3:50 PM Changeset in webkit [139125] by Dimitri Glazkov
  • 1 edit
    2 deletes in trunk/LayoutTests

Organize some svg/gynamic-updates expectations.

  • platform/chromium-win-xp/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Removed.
  • platform/chromium-win-xp/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Removed.
3:42 PM Changeset in webkit [139124] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-08

  • DEPS:
3:28 PM Changeset in webkit [139123] by Lucas Forschler
  • 4 edits in tags/Safari-537.24.3/Source

Versioning.

3:26 PM Changeset in webkit [139122] by Lucas Forschler
  • 1 copy in tags/Safari-537.24.3

New Tag.

3:11 PM Changeset in webkit [139121] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Layout Tests svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues* are flaky.
https://bugs.webkit.org/show_bug.cgi?id=106390

  • platform/chromium/TestExpectations: Adjusted expectations.
2:59 PM Changeset in webkit [139120] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Silence a sandbox violation
https://bugs.webkit.org/show_bug.cgi?id=106386
<rdar://problem/12976435>

Reviewed by Andreas Kling.

  • WebProcess/com.apple.WebProcess.sb.in:
2:57 PM Changeset in webkit [139119] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

Layout Tests svg/W3C-SVG-1.1/filters-comptran-01-b.svg and svg/W3C-SVG-1.1/animate-elem-80-t.svg are flaky.
https://bugs.webkit.org/show_bug.cgi?id=106387

  • platform/chromium/TestExpectations: Marked new flakes.
2:54 PM Changeset in webkit [139118] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Skip the test added by r139062 on WebKit2 bots since it uses a testRunner method
that hasn't been implemented yet.

  • platform/wk2/TestExpectations:
2:50 PM Changeset in webkit [139117] by aelias@chromium.org
  • 1 edit
    3 copies in branches/chromium/1364

Merge 139022

Divide gesture scroll delta by scale factor
https://bugs.webkit.org/show_bug.cgi?id=106263

Reviewed by Adam Barth.

Gesture scroll deltas were not being adjusted by the frame's scale
factors, resulting in overly fast main-thread scrolling when zoomed
in.

New test: fast/events/touch/gesture/touch-gesture-scroll-div-scaled.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureScrollCore):

TBR=aelias@chromium.org

BUG=166628
Review URL: https://codereview.chromium.org/11826009

2:50 PM Changeset in webkit [139116] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Tighten up some test expectations.

  • platform/chromium/TestExpectations: Tightened.
2:49 PM Changeset in webkit [139115] by leviw@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebKit/chromium/src/WebViewImpl.cpp

Merge 139017. Requested by yusufo@google.com

Don't use double tap zoom if minimum and maximum page scale is the same
https://bugs.webkit.org/show_bug.cgi?id=106272

Patch by Yusuf Ozuysal <yusufo@google.com> on 2013-01-07
Reviewed by James Robinson.

We should only try to computed relevant scale and scrollOffset and start the animation
if the page is zoomable. This now creates an undesired animation for mobile pages which
are not zoomable.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11821007

2:19 PM Changeset in webkit [139114] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/LayoutTests

Update test result. <rdar://problem/12968772>

2:16 PM Changeset in webkit [139113] by weinig@apple.com
  • 1 edit
    1 delete in trunk/Source/WebKit2

This should be camel case. Must remove to fix.

  • OWNERS: Removed.
2:16 PM Changeset in webkit [139112] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] A bunch of fast/css-grid-layout tests started timing out after r139025.
https://bugs.webkit.org/show_bug.cgi?id=106378

  • platform/chromium/TestExpectations: Marked expectations.
2:11 PM Changeset in webkit [139111] by tsepez@chromium.org
  • 23 edits
    2 adds in trunk

Copy-paste preserves <embed> tags containing active content.
https://bugs.webkit.org/show_bug.cgi?id=77625

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: editing/pasteboard/paste-noplugin.html

  • dom/FragmentScriptingPermission.h:

(WebCore::scriptingContentIsAllowed):
(WebCore::pluginContentIsAllowed):
Add new permission to restrict plugin pasting. Add inline functions to check
the implications of each permission rather than having a list of raw comparisions
sprinkled throughout the code.

  • editing/markup.cpp:

(WebCore::createFragmentFromMarkup):
Revert back to unsafe plugin pasting regardless of caller's intentions when
the settings allow it.

  • dom/Element.cpp:

(WebCore::Element::parserSetAttributes):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertScriptElement):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::endElementNs):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::parseEndElement):
Use new inline functions to check implications of permissions rather than raw
comparisions.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
Check if plugin pasting is allowed before inserting applet/embed/oject elements.

  • page/Settings.in:

Declaration of new unsafePluginPastingEnabled setting.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::documentFragment):

  • platform/blackberry/PasteboardBlackBerry.cpp:

(WebCore::Pasteboard::documentFragment):

  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::asFragment):

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::documentFragment):

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::documentFragment):

  • platform/qt/DragDataQt.cpp:

(WebCore::DragData::asFragment):

  • platform/qt/PasteboardQt.cpp:

(WebCore::Pasteboard::documentFragment):

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::fragmentFromCFHTML):
(WebCore::fragmentFromHTML):

  • platform/wx/PasteboardWx.cpp:

(WebCore::Pasteboard::documentFragment):
Pass DisallowScriptingAndPluginContent enum value.

Source/WebKit/chromium:

Adds chromium API to new unsafePluginPastingEnabled setting.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setUnsafePluginPastingEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

LayoutTests:

  • editing/pasteboard/paste-noplugin-expected.txt: Added.
  • editing/pasteboard/paste-noplugin.html: Added.
2:03 PM Changeset in webkit [139110] by zhajiang@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[Blackberry][FullScreen] Create a helper method to adjust the fullscreen renderer dimensions
https://bugs.webkit.org/show_bug.cgi?id=91748

Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Antonio Gomes.

PR: 195524
The was originally from Antonio Gomes on PR195524. Bug 105488 has
partially upstreamed that patch. This patch upstreams the rest of it.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::updateViewportSize):
(BlackBerry::WebKit::WebPagePrivate::notifyTransformedScrollChanged):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):

2:02 PM Changeset in webkit [139109] by fpizlo@apple.com
  • 6 edits
    3 adds in trunk

REGRESSION (r138921): Crash in JSC::Arguments::create
https://bugs.webkit.org/show_bug.cgi?id=106329
<rdar://problem/12974196>

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Arguments::finishCreation() that takes an InlineCallFrame* needs to understand that the callee can
be unset, indicating that the callee needs to be loaded from the true call frame. This adds a
method to InlineCallFrame to do just that.

  • bytecode/CodeOrigin.cpp:

(JSC::InlineCallFrame::calleeForCallFrame):

  • bytecode/CodeOrigin.h:

(InlineCallFrame):

  • runtime/Arguments.h:

(JSC::Arguments::finishCreation):

LayoutTests:

Reviewed by Mark Hahnenberg.

  • fast/js/dfg-create-inlined-arguments-in-closure-inline-expected.txt: Added.
  • fast/js/dfg-create-inlined-arguments-in-closure-inline.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-create-inlined-arguments-in-closure-inline.js: Added.

(foo):

1:54 PM Changeset in webkit [139108] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Layout Test http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=106332

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-01-08
Reviewed by Ryosuke Niwa.

Fix this flaky test by adjusting the authentication realm
used in the HTTP headers.

  • http/tests/misc/authentication-redirect-4/resources/auth-then-redirect.php: The authentication realm used

in the HTTP headers is shared with several other HTTP tests, so cached credentials can "leak" from one
test to another. Make the authentication realm unique for this test.

1:50 PM Changeset in webkit [139107] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/12944813> Network process temporary and cache directories are not set correctly

Reviewed by Sam Weinig.

Set DIRHELPER_USER_DIR_SUFFIX, like we do for WebProcess. Also while in this function,
enabled sandbox-style file quarantine.

  • NetworkProcess/mac/NetworkProcessMac.mm: (WebKit::NetworkProcess::initializeSandbox):
1:44 PM Changeset in webkit [139106] by alexis@webkit.org
  • 7 edits in trunk

WebKit does not reject some cubic-bezier form values for transition-timing-function.
https://bugs.webkit.org/show_bug.cgi?id=106369

Reviewed by Dean Jackson.

Source/WebCore:

http://www.w3.org/TR/css3-transitions/#transition-timing-function-property
describes restricitions on cubic-bezier values where the x values of
the curve should be between [0, 1] and y values can exceed this range.
WebKit was not following the specification by allowing x values
exceeding the range.
The spec also says that we should reject the defintion if the condition
is not respected which is what the new code does.

Test: transitions/transitions-parsing.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationTimingFunction):

LayoutTests:

Extended existing tests to cover the bug. Updated an existing test
which was checking wrong values.

  • fast/css/transition-timing-function.html: Change the tested values as

they are considered wrong by the spec.

  • fast/css/transition-timing-function-expected.txt:
1:37 PM Changeset in webkit [139105] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Tighten up the actual expectations around webaudio fails..
https://bugs.webkit.org/show_bug.cgi?id=106232

  • platform/chromium/TestExpectations: Tightened.
1:33 PM Changeset in webkit [139104] by Dimitri Glazkov
  • 2 edits
    1 delete in trunk/LayoutTests

[Chromium] Update expectations for platform/chromium/fast/events/touch/compositor-touch-hit-rects.html.

  • platform/chromium-win-xp/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt: Removed.
  • platform/chromium-win/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt:
1:25 PM Changeset in webkit [139103] by Dimitri Glazkov
  • 4 edits
    2 deletes in trunk/LayoutTests

Update expectations for various tests.

  • platform/chromium-win-xp/fast/table/038-vertical-expected.png: Removed.
  • platform/chromium-win-xp/fast/table/border-collapsing/004-vertical-expected.png: Removed.
  • platform/chromium-win/fast/ruby/base-shorter-than-text-expected.txt:
  • platform/chromium-win/fast/table/038-vertical-expected.png:
  • platform/chromium-win/fast/table/border-collapsing/004-vertical-expected.png:
1:25 PM Changeset in webkit [139102] by zandobersek@gmail.com
  • 4 edits in trunk/Tools

[webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
https://bugs.webkit.org/show_bug.cgi?id=106364

Reviewed by Eric Seidel.

When the setup_test_run method is called on the subclasses of the base Port
interface, the parent method should also be called via super(), despite the
parent method not doing anything at the moment.

The according calls to super() are required in the ChromiumPort, EflPort
and GtkPort implementations.

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.setup_test_run):

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort.setup_test_run):

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.setup_test_run):

1:11 PM Changeset in webkit [139101] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Use correct capitalization in service name
https://bugs.webkit.org/show_bug.cgi?id=106368

Reviewed by Andreas Kling.

  • WebProcess/com.apple.WebProcess.sb.in:
1:08 PM Changeset in webkit [139100] by akling@apple.com
  • 4 edits
    2 adds in trunk

Heap-use-after-free in bool WebCore::SelectorChecker::checkOneSelector.
<http://webkit.org/b/105834>

Reviewed by Antti Koivisto.

Source/WebCore:

Suppress the DOMSubtreeModified event when synchronizing the "style" attribute and we've
instantiated an Attr node wrapper for the said attribute.

Also added an assertion that Document's StyleResolver isn't cleared during style recalc,
which will help us catch this kind of bug in the future.

Test: fast/dom/mutation-event-listener-with-dirty-inline-style-crash.html

  • dom/Document.cpp:

(WebCore::Document::styleResolverThrowawayTimerFired):

  • dom/Element.cpp:

(WebCore::Element::setAttributeInternal):

LayoutTests:

  • fast/dom/mutation-event-listener-with-dirty-inline-style-crash-expected.txt: Added.
  • fast/dom/mutation-event-listener-with-dirty-inline-style-crash.html: Added.
1:04 PM Changeset in webkit [139099] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r139096.
http://trac.webkit.org/changeset/139096
https://bugs.webkit.org/show_bug.cgi?id=106367

not a complete fix (Requested by bweinstein on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-08

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::userDidClickSnapshot):

12:54 PM Changeset in webkit [139098] by fpizlo@apple.com
  • 4 edits
    15 adds in trunk

DFG initrinsic handling should ensure that we backwards propagate the fact that all operands may escape
https://bugs.webkit.org/show_bug.cgi?id=106365

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Use the fact that Phantom means that things escaped, and just insert Phantoms for all
of the operands.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):

LayoutTests:

Reviewed by Mark Hahnenberg.

Add tests that cover the possible badness that could occur for all of those
intrinsics that don't intrinsically (pun sort of intended) cause escapeage
to happen. As in, if we did happen to know for sure that what we want is
ArithSqrt, then we would have a guarantee that ArithSqrt does not by itself
use its operands in a way that involves NodeUsedAsOther. But when ArithSqrt
is inserted because of intrinsic optimization (i.e. something like
Math.sqrt(blah)) then the intrinsic machinery needs to indicate that blah
could escape in the case that we didn't end up doing ArithSqrt because we
exited prior to it and called some other function.

  • fast/js/dfg-abs-backwards-propagation-expected.txt: Added.
  • fast/js/dfg-abs-backwards-propagation.html: Added.
  • fast/js/dfg-max-backwards-propagation-expected.txt: Added.
  • fast/js/dfg-max-backwards-propagation.html: Added.
  • fast/js/dfg-min-backwards-propagation-expected.txt: Added.
  • fast/js/dfg-min-backwards-propagation.html: Added.
  • fast/js/dfg-proven-sqrt-backwards-propagation-expected.txt: Added.
  • fast/js/dfg-proven-sqrt-backwards-propagation.html: Added.
  • fast/js/dfg-sqrt-backwards-propagation-expected.txt: Added.
  • fast/js/dfg-sqrt-backwards-propagation.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-abs-backwards-propagation.js: Added.

(foo):
(bar):

  • fast/js/script-tests/dfg-max-backwards-propagation.js: Added.

(foo):
(bar):

  • fast/js/script-tests/dfg-min-backwards-propagation.js: Added.

(foo):
(bar):

  • fast/js/script-tests/dfg-proven-sqrt-backwards-propagation.js: Added.

(foo):
(bar):

  • fast/js/script-tests/dfg-sqrt-backwards-propagation.js: Added.

(foo):
(bar):

12:33 PM Changeset in webkit [139097] by jparent@chromium.org
  • 5 edits in trunk/Tools

Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
https://bugs.webkit.org/show_bug.cgi?id=106356

g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
dashboard_base, assigned by Loader, and used only by dashboard_base to
create error messages. Moved the variables to be privates on the Loader
object, moved error message creation to _getLoadingErrorMessages on the
Loader object, and now pass the errors back to dashboard base via the
resourceLoadingComplete callback.

Also removed the now unused clearError function, it was only being used
by unit tests to clean up global state.

Reviewed by Dirk Pranke.

  • TestResultServer/static-dashboards/dashboard_base.js:

(resourceLoadingComplete):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  • TestResultServer/static-dashboards/loader.js:

(.):

  • TestResultServer/static-dashboards/loader_unittests.js:
12:31 PM Changeset in webkit [139096] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebCore

Plug-ins shouldn’t be added to list to autostart if you start a plugin in private browsing.
https://bugs.webkit.org/show_bug.cgi?id=106348
<rdar://problem/12968442>

Reviewed by Anders Carlsson.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Don't call addAutoStartOrigin if we are

in private browsing mode.

12:23 PM Changeset in webkit [139095] by zandobersek@gmail.com
  • 6 edits
    1 add in trunk/Tools

[EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
https://bugs.webkit.org/show_bug.cgi?id=106354

Reviewed by Eric Seidel.

Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
instead of those two inheriting from it. Also add a mock object of the
sanitizer that's used in unit tests.

  • Scripts/webkitpy/layout_tests/port/efl.py:

(EflPort):
(EflPort.init):
(EflPort.setup_test_run):
(EflPort.clean_up_test_run):

  • Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the

importing order.
(EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort):
(GtkPort.init):
(GtkPort.setup_test_run):
(GtkPort.clean_up_test_run):

  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the

importing order.
(GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.

  • Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:

(PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
(PulseAudioSanitizer.restore_pulseaudio_module): Ditto.

  • Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.

(PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
(PulseAudioSanitizerMock.unload_pulseaudio_module):
(PulseAudioSanitizerMock.restore_pulseaudio_module):

12:21 PM Changeset in webkit [139094] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

If array allocation profiling causes a new_array to allocate double arrays, then the holes should end up being correctly initialized
https://bugs.webkit.org/show_bug.cgi?id=106363

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

  • runtime/JSArray.h:

(JSC::JSArray::tryCreateUninitialized):

LayoutTests:

  • fast/js/jsc-test-list:
  • fast/js/new-array-double-with-holes-expected.txt: Added.
  • fast/js/new-array-double-with-holes.html: Added.
  • fast/js/script-tests/new-array-double-with-holes.js: Added.

(foo):

12:12 PM Changeset in webkit [139093] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Tweak sandbox profile
https://bugs.webkit.org/show_bug.cgi?id=106362
<rdar://problem/12884745>

Reviewed by Sam Weinig.

  • WebProcess/com.apple.WebProcess.sb.in:

Allow access to com.apple.CoreServices.launchservicesd.

12:05 PM Changeset in webkit [139092] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add a crashing test expectation to a test added in r139029.
The failure is tracked by the bug 106361.

  • platform/mac/TestExpectations:
11:52 AM Changeset in webkit [139091] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: native popup buttons should not use textUnderElement for their title
https://bugs.webkit.org/show_bug.cgi?id=106349

Reviewed by Ryosuke Niwa.

Native popup buttons (<select> elements) were calculating its title based on the text
under the element. When Bug 103794 introduced a more complete way of getting render text,
it causes popup buttons to start returning a title.
The fix is that we should not be calculating a title for a native popup button from its children.

Existing tests cover this functionality. This will fix a failing test.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::visibleText):

11:49 AM Changeset in webkit [139090] by jochen@chromium.org
  • 14 edits in trunk/Tools

[chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=106324

Reviewed by Adam Barth.

Since the frame load callbacks are part of the WebFrameClient, the
WebTestProxy is now intercepting both WebViewClient and WebFrameClient
methods.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebTestInterfaces):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebKit):
(WebTestProxyBase):
(WebTestRunner):
(WebTestRunner::WebTestProxy::WebTestProxy):
(WebTestProxy):
(WebTestRunner::WebTestProxy::didInvalidateRect):
(WebTestRunner::WebTestProxy::didScrollRect):
(WebTestRunner::WebTestProxy::scheduleComposite):
(WebTestRunner::WebTestProxy::scheduleAnimation):
(WebTestRunner::WebTestProxy::setWindowRect):
(WebTestRunner::WebTestProxy::show):
(WebTestRunner::WebTestProxy::didAutoResize):
(WebTestRunner::WebTestProxy::postAccessibilityNotification):
(WebTestRunner::WebTestProxy::startDragging):
(WebTestRunner::WebTestProxy::shouldBeginEditing):
(WebTestRunner::WebTestProxy::shouldEndEditing):
(WebTestRunner::WebTestProxy::shouldInsertNode):
(WebTestRunner::WebTestProxy::shouldInsertText):
(WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
(WebTestRunner::WebTestProxy::shouldDeleteRange):
(WebTestRunner::WebTestProxy::shouldApplyStyle):
(WebTestRunner::WebTestProxy::didBeginEditing):
(WebTestRunner::WebTestProxy::didChangeSelection):
(WebTestRunner::WebTestProxy::didChangeContents):
(WebTestRunner::WebTestProxy::didEndEditing):
(WebTestRunner::WebTestProxy::registerIntentService):
(WebTestRunner::WebTestProxy::dispatchIntent):
(WebTestRunner::WebTestProxy::willPerformClientRedirect):
(WebTestRunner::WebTestProxy::didCancelClientRedirect):
(WebTestRunner::WebTestProxy::didStartProvisionalLoad):
(WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
(WebTestRunner::WebTestProxy::didFailProvisionalLoad):
(WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
(WebTestRunner::WebTestProxy::didReceiveTitle):
(WebTestRunner::WebTestProxy::didFinishDocumentLoad):
(WebTestRunner::WebTestProxy::didHandleOnloadEvents):
(WebTestRunner::WebTestProxy::didFailLoad):
(WebTestRunner::WebTestProxy::didFinishLoad):
(WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
(WebTestRunner::WebTestProxy::didDisplayInsecureContent):
(WebTestRunner::WebTestProxy::didRunInsecureContent):
(WebTestRunner::WebTestProxy::didDetectXSS):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner::WebTestRunner::setTestIsRunning):
(WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
(WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
(WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
(WebTestRunner::WebTestRunner::shouldDumpTitleChanges):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::setTestIsRunning):
(WebTestRunner):
(WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
(WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
(WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
(WebTestRunner::TestRunner::stopProvisionalFrameLoads):
(WebTestRunner::TestRunner::shouldDumpTitleChanges):
(WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
(WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
(WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
(WebTestRunner::TestRunner::dumpTitleChanges):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::webView):
(WebTestRunner::WebTestInterfaces::Internal::Internal):
(WebTestRunner::WebTestInterfaces::Internal::setWebView):
(WebTestRunner):
(WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
(WebTestRunner::WebTestInterfaces::setWebView):
(WebTestRunner::WebTestInterfaces::setTestIsRunning):
(WebTestRunner::WebTestInterfaces::webView):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
(WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
(WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
(WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
(WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
(WebTestRunner::WebTestProxyBase::didReceiveTitle):
(WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
(WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
(WebTestRunner::WebTestProxyBase::didFailLoad):
(WebTestRunner::WebTestProxyBase::didFinishLoad):
(WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
(WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
(WebTestRunner::WebTestProxyBase::didRunInsecureContent):
(WebTestRunner::WebTestProxyBase::didDetectXSS):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::runFileTest):
(TestShell::testFinished):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didStartProvisionalLoad):
(WebViewHost::didReceiveServerRedirectForProvisionalLoad):
(WebViewHost::didFailProvisionalLoad):
(WebViewHost::didCommitProvisionalLoad):
(WebViewHost::didReceiveTitle):
(WebViewHost::didFailLoad):
(WebViewHost::didFinishLoad):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

11:40 AM Changeset in webkit [139089] by ojan@chromium.org
  • 7 edits
    2 adds in trunk

text controls are sized too small when a percentage height is set
https://bugs.webkit.org/show_bug.cgi?id=106277

Reviewed by Tony Chang.

Source/WebCore:

This makes our behavior match Firefox 17, IE 9 and Opera 12.
The current logic came from http://trac.webkit.org/changeset/13723,
which itself was copy-pasted from RenderReplaced and no longer has this clause..

Test: fast/forms/percent-height-auto-width-form-controls.html

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::computePreferredLogicalWidths):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::computePreferredLogicalWidths):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::computePreferredLogicalWidths):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computePreferredLogicalWidths):

LayoutTests:

  • fast/forms/percent-height-auto-width-form-controls-expected.txt: Added.
  • fast/forms/percent-height-auto-width-form-controls.html: Added.
11:35 AM Changeset in webkit [139088] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

[GTK] Lower the default timeout value for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=106353

Reviewed by Dirk Pranke.

The default timeout value for WebKitTestRunner should be lowered.
The current value (80 seconds) is irrational and just leads to producing
text failures for layout tests that genuinely time out. This just leads
to more deviation from the GTK WK1 port in terms of test expectations.

The value used is the same as when running the DumpRenderTree, that's
6 seconds in release builds and 12 seconds in debug builds.

  • Scripts/webkitpy/layout_tests/port/gtk.py:
  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py:

(GtkPortTest.test_default_timeout_ms):

11:28 AM Changeset in webkit [139087] by peter@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Modify Android's user agent CSS to not set a border-radius on select elements
https://bugs.webkit.org/show_bug.cgi?id=106327

Reviewed by Adam Barth.

Android's user agent CSS overrides the style applied to <select>
elements with a @size or @multiple attribute, and then applies
(among other things) a border-radius of 5 pixels. While select
elements with a larger size or multiple selection should appear
as drop-down boxes for now, setting the border radius causes
Chromium to skip rendering the background and border, making
them hard to read when the page relies on the default styling.

This is covered by existing pixel tests.

  • css/themeChromiumAndroid.css:

(select[size][multiple]):

11:27 AM Changeset in webkit [139086] by weinig@apple.com
  • 1 edit
    1 add in trunk/Source/WebKit2

Add OWNERS file.

  • OWNERS: Added.
11:22 AM Changeset in webkit [139085] by mkwst@chromium.org
  • 3 edits
    2 adds in trunk

CSP: 'none' should take effect only if no other source expression is present.
https://bugs.webkit.org/show_bug.cgi?id=106314

Reviewed by Adam Barth.

Source/WebCore:

WebKit's handling of 'none' in Content Security Policy source lists
doesn't quite match the spec. Currently, we're treating any source list
that contains 'none' as its first token as an empty list. That is:
"script-src 'none'" is handled in the same way as
"script-src 'none' example.com". Based on a bit of public-webappsec@
discussion[1], the behavior we actually want should treat the first as
an empty list, while treating the second as "script-src example.com". In
other words, 'none' in a source list is a no-op, unless it is the _only_
item in the source list.

This patch adjusts our parsing behavior accordingly, and tweaks the
console log we emit for invalid source expressions to warn specifically
about this case.

[1]: http://lists.w3.org/Archives/Public/public-webappsec/2013Jan/0006.html

Test: http/tests/security/contentSecurityPolicy/source-list-parsing-none.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::isSourceListNone):

A new static method that returns true when given a string that
contains only 'none' (potentially surrounded by whitespace), and
false otherwise.

(WebCore):
(WebCore::CSPSourceList::parse):

Move the 'none' check into the initial layer of parsing, which means
that we can drop the 'isFirstSourceInList' check entirely.

(WebCore::CSPSourceList::parseSource):

Since we've already checked for 'none' in ::parse, we can at this
point safely treat any occurance of 'none' in the source list as an
invalid expression.

(WebCore::ContentSecurityPolicy::reportInvalidSourceExpression):

If the invalid expression is 'none', add a clarification to the
console message, noting that 'none' only has effect when it's all
alone.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/source-list-parsing-none-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/source-list-parsing-none.html: Added.
11:19 AM Changeset in webkit [139084] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

test-webkitpy shows failure output on my linux box
https://bugs.webkit.org/show_bug.cgi?id=101261

Reviewed by Eric Seidel.

Mock out the PulseAudioSanitizer methods when creating testing instances
of EflPort and GtkPort interfaces in unit tests. This stops throwing up
PulseAudio output when the sanitizer was trying to unload modules which
were already unloaded by another unit test that was being run in parallel.

  • Scripts/webkitpy/layout_tests/port/efl_unittest.py:

(EflPortTest):
(EflPortTest.make_port):

  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py:

(GtkPortTest):
(GtkPortTest.make_port):

11:15 AM Changeset in webkit [139083] by alokp@chromium.org
  • 3 edits in trunk/Source/WebCore

Added OpaqueRegionSkia::currentTrackingOpaqueRect

[chromium] Add OpaqueRegionSkia::currentTrackingOpaqueRect
https://bugs.webkit.org/show_bug.cgi?id=106267

Reviewed by Stephen White.

No new tests needed. No change in functionality.

  • platform/graphics/skia/OpaqueRegionSkia.cpp:

(WebCore::OpaqueRegionSkia::applyOpaqueRegionFromLayer):
(WebCore::OpaqueRegionSkia::markRectAsOpaque):
(WebCore::OpaqueRegionSkia::markRectAsNonOpaque):
(WebCore::OpaqueRegionSkia::markAllAsNonOpaque):
(WebCore::OpaqueRegionSkia::currentTrackingOpaqueRect):
(WebCore):

  • platform/graphics/skia/OpaqueRegionSkia.h:

(OpaqueRegionSkia):

11:00 AM Changeset in webkit [139082] by jparent@chromium.org
  • 3 edits in trunk/Tools

Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
https://bugs.webkit.org/show_bug.cgi?id=106254

Remove the global variable g_hasDoneInitialPageGeneration. It was used
only to figure out if we should call addBuilderLoadErrors during
handleLocationChange, which was called when the loader completed and on
any hash change, but we only ever wanted to call addBuilderLoadErrors
on the initial loader load. Moved the call of addBuilderLoadErrors to
resourceLoadingComplete rather than handleLocationChange, so now we
only call it when we want to, and the check can go away completely.

Reviewed by Dirk Pranke.

  • TestResultServer/static-dashboards/dashboard_base.js:

(addBuilderLoadErrors):
(resourceLoadingComplete):
(handleLocationChange):

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
10:54 AM Changeset in webkit [139081] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[GTK] Build failures when building with python 3.3
https://bugs.webkit.org/show_bug.cgi?id=106194

Reviewed by Dirk Pranke.

Python 3.3 introduced changes to dictionaries which can result in changed
iteration order. More about these changes:
http://docs.python.org/3.3/whatsnew/3.3.html#pep-412-key-sharing-dictionary
http://www.python.org/dev/peps/pep-0412/#cons

This causes the Source/WebCore/inspector/generate-inspector-protocol-version
script to fail the self-testing when using Python 3.3. These changes work
around this problem by not checking for expected errors in order but rather
for their presence in the error output sequence. The number of actual errors
is also checked to be equal to the number of expected errors.

No new tests - no new functionality.

  • inspector/generate-inspector-protocol-version:

(self_test):

10:49 AM Changeset in webkit [139080] by commit-queue@webkit.org
  • 14 edits
    5 adds in trunk

<track> element's mode set to "disabled" after load although it was explicitly set to "hidden"
https://bugs.webkit.org/show_bug.cgi?id=105536

Source/WebCore:

Remove all concept of "showing by default". This means removing the showingByDefault()
and setShowingByDefault() methods on TextTrack. As I was going through this code,
I also noticed that in HTMLMediaElement::configureTextTrackGroup(), we would set
defaultTrack to textTrack.get() even though defaultTrack was created to be a RefPtr<TextTrack>.

As a result, we can now pass an additional 8 tests from the Opera-submitted test suite:

LayoutTests/media/track/opera/interfaces/TextTrack/addCue.html
LayoutTests/media/track/opera/interfaces/TextTrack/removeCue.html
LayoutTests/media/track/opera/interfaces/TextTrackCue/endTime.html
LayoutTests/media/track/opera/interfaces/TextTrackCue/startTime.html
LayoutTests/media/track/opera/interfaces/TextTrackCue/align.html
LayoutTests/media/track/opera/interfaces/TextTrackCue/id.html
LayoutTests/media/track/opera/interfaces/TextTrackCue/pauseOnExit.html
LayoutTests/media/track/opera/interfaces/TextTrackCue/track.html

Patch by Antoine Quint <Antoine Quint> on 2013-01-08
Reviewed by Eric Carlson.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::configureTextTrackGroup):
(WebCore::HTMLMediaElement::toggleTrackAtIndex):

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::setMode):
(WebCore::TextTrack::isRendered):

  • html/track/TextTrack.h:

(WebCore::TextTrack::mode):
(TextTrack):

LayoutTests:

Patch by Antoine Quint <Antoine Quint> on 2013-01-08
Reviewed by Eric Carlson.

  • media/track/opera/interfaces/TextTrack/addCue-expected.txt:
  • media/track/opera/interfaces/TextTrack/removeCue-expected.txt: Added.
  • media/track/opera/interfaces/TextTrackCue/align-expected.txt: Added.
  • media/track/opera/interfaces/TextTrackCue/endTime-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/id-expected.txt: Added.
  • media/track/opera/interfaces/TextTrackCue/pauseOnExit-expected.txt: Added.
  • media/track/opera/interfaces/TextTrackCue/startTime-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/track-expected.txt: Added.
  • platform/chromium/TestExpectations: Skipping newly failing test on Chrome.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
10:47 AM Changeset in webkit [139079] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Unifying accessibility layout test failure expectations in the WK2
TestExpectations file, with each expectation given an appropriate bug modifier.
Removing three failure expectations for transitions tests that are now passing
on WK2.

  • platform/gtk-wk2/TestExpectations:
10:47 AM Changeset in webkit [139078] by mark.lam@apple.com
  • 40 edits in trunk/Source

Removed the need for the ProposedDatabase mechanism.
https://bugs.webkit.org/show_bug.cgi?id=106292.

Reviewed by Sam Weinig.

Source/WebCore:

No new tests.

  • Modules/webdatabase/AbstractDatabase.cpp:

(WebCore::AbstractDatabase::details):
(WebCore):

  • Modules/webdatabase/AbstractDatabase.h:

(AbstractDatabase):

  • Modules/webdatabase/DatabaseContext.cpp:

(WebCore::DatabaseContext::databaseExceededQuota):

  • Modules/webdatabase/DatabaseContext.h:

(DatabaseContext):

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::fullPathForDatabaseNoLock):
(WebCore::DatabaseTracker::detailsForNameAndOrigin):

  • Modules/webdatabase/DatabaseTracker.h:

(DatabaseTracker):

  • Modules/webdatabase/SQLTransactionClient.cpp:

(WebCore::SQLTransactionClient::didExceedQuota):

  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::exceededDatabaseQuota):

  • page/ChromeClient.h:

(ChromeClient):

Source/WebKit/blackberry:

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):

  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::exceededDatabaseQuota):

  • src/ChromeClientImpl.h:

(ChromeClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::exceededDatabaseQuota):

  • WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::exceededDatabaseQuota):

  • WebCoreSupport/ChromeClientGtk.h:

(ChromeClient):

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::exceededDatabaseQuota):

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:
  • WebCoreSupport/ChromeClientQt.h:

(ChromeClientQt):

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::exceededDatabaseQuota):

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::exceededDatabaseQuota):

  • WebCoreSupport/ChromeClientWinCE.h:

(ChromeClientWinCE):

Source/WebKit/wx:

  • WebKitSupport/ChromeClientWx.cpp:

(WebCore::ChromeClientWx::exceededDatabaseQuota):

  • WebKitSupport/ChromeClientWx.h:

(ChromeClientWx):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::exceededDatabaseQuota):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

10:40 AM Changeset in webkit [139077] by Chris Fleizach
  • 4 edits
    2 adds in trunk

AX: PopUpButtons do not report that AXValueAttribute is supported
https://bugs.webkit.org/show_bug.cgi?id=106333

Reviewed by Ryosuke Niwa.

Source/WebCore:

The Mac platform expects that AXPopUpButton's expose the AXValue attribute.

Test: platform/mac/accessibility/popup-button-exposes-axvalue.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isPopUpButton):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):

LayoutTests:

  • platform/mac/accessibility/popup-button-exposes-axvalue-expected.txt: Added.
  • platform/mac/accessibility/popup-button-exposes-axvalue.html: Added.
10:34 AM Changeset in webkit [139076] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

Remove dead Connection members in ChildProcess subclasses (and their users)
https://bugs.webkit.org/show_bug.cgi?id=106347
<rdar://problem/12973955>

Reviewed by Alexey Proskuryakov.

This also fixes a crash when entering fullscreen with a plug-in.

  • PluginProcess/PluginProcess.h:

Remove dead m_connection member.

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::setModalWindowIsShowing):
(WebKit::PluginProcess::setFullscreenWindowIsShowing):
Replace use of m_connection, which is dead, with parentProcessConnection().

  • SharedWorkerProcess/SharedWorkerProcess.h:

(SharedWorkerProcess):
Remove dead m_connection member.

  • SharedWorkerProcess/SharedWorkerProcess.cpp:

(WebKit::SharedWorkerProcess::createWebProcessConnection):
Replace use of m_connection, which is dead, with parentProcessConnection().

10:17 AM Changeset in webkit [139075] by dmazzoni@google.com
  • 2 edits in trunk/Tools

Add aboxhall@chromium.org to accessibility watchlist.

Unreviewed.

  • Scripts/webkitpy/common/config/watchlist:
10:15 AM Changeset in webkit [139074] by Dimitri Glazkov
  • 7 edits
    3 adds in trunk/LayoutTests

Update expectations for fast/text/justify-ideograph*.

  • platform/chromium-linux-x86/fast/text/justify-ideograph-vertical-expected.txt: Added.
  • platform/chromium-linux/fast/text/justify-ideograph-vertical-expected.png: Added.
  • platform/chromium-linux/fast/text/justify-ideograph-vertical-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/justify-ideograph-simple-expected.png:
  • platform/chromium-mac-lion/fast/text/justify-ideograph-vertical-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/justify-ideograph-simple-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/justify-ideograph-vertical-expected.png:
  • platform/chromium-mac/fast/text/justify-ideograph-simple-expected.png:
  • platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.png:
10:14 AM Changeset in webkit [139073] by Dimitri Glazkov
  • 1 edit
    1 add in trunk/LayoutTests

Update expectations for webaudio/realtimeanalyser-fft-sizing.html.

  • platform/chromium-linux/webaudio/realtimeanalyser-fft-sizing-expected.txt: Added.
10:13 AM Changeset in webkit [139072] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] context-creation-and-destruction.html is slow and flaky.
https://bugs.webkit.org/show_bug.cgi?id=92287

  • platform/chromium/TestExpectations: Adjusted expectations.
10:10 AM Changeset in webkit [139071] by danw@gnome.org
  • 9 edits
    1 copy
    1 move in trunk

Tools: Add Apache 2.4 support for Fedora 18
https://bugs.webkit.org/show_bug.cgi?id=104478

Reviewed by Martin Robinson.

Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
need a separate config.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port._apache_version):
(Port._apache_config_file_name_for_platform):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
  • Scripts/run-webkit-httpd:
  • Scripts/webkitperl/httpd.pm:

(getApacheVersion):
(getDefaultConfigForTestDirectory):
(getHTTPDConfigPathForTestDirectory):

LayoutTests: Updates for Apache 2.4
https://bugs.webkit.org/show_bug.cgi?id=104478

Reviewed by Martin Robinson.

Apache 2.4 requires a slightly different config from 2.2, so split
fedora-httpd.conf into separate 2.2 and 2.4 versions.

2.4 is also more picky about passing request headers to CGI
scripts, and will ignore headers that aren't valid according to
the HTTP grammar, so change underscores to hyphens to fix them.

  • http/conf/fedora-httpd-2.2.conf: Renamed from

LayoutTests/http/conf/fedora-httpd.conf.

  • http/conf/fedora-httpd-2.4.conf: Based on

LayoutTests/http/conf/fedora-httpd.conf and updated for 2.4.

  • http/tests/cookies/resources/cookies-test-pre.js:

(setCookies):
(clearCookies):

  • http/tests/navigation/ping-cookie.html:
  • http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html:
10:08 AM Changeset in webkit [139070] by alexis@webkit.org
  • 5 edits in trunk

transition-delay and transition-duration return incorrect values when querying using the computed style.
https://bugs.webkit.org/show_bug.cgi?id=105432

Reviewed by Dean Jackson.

Source/WebCore:

When setting the transition-delay to 10ms for example the value of transition-delay
on the computed style was incorrect, it should return 0.01s but it was
returning something like 0.0099999999...s. In fact the bug was after
the parsing step when creating the Animation object where a conversion
from a double to float was done. This conversion is not needed as the
animation class expects double for delay and transition times.

Test: transitions/transitions-parsing.html

  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapAnimationDelay):
(WebCore::CSSToStyleMap::mapAnimationDuration):

LayoutTests:

Uncomment existing tests to cover the bug.

  • transitions/transitions-parsing-expected.txt:
  • transitions/transitions-parsing.html:
10:06 AM Changeset in webkit [139069] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Tweak expectations for random-array-gc-stress.html to reflect reality.
https://bugs.webkit.org/show_bug.cgi?id=84802

  • platform/chromium/TestExpectations: Tweaked expectations.
9:56 AM Changeset in webkit [139068] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG should backwards-propagate NodeUsedAsValue for Phantom
https://bugs.webkit.org/show_bug.cgi?id=106299

Reviewed by Mark Hahnenberg.

This is currently benign because Phantom is only inserted by the bytecode parser for
things that already happen to be used in contexts that backwards propagate
NodeUsedAsValue. But that doesn't change the fact that the semantics of Phantom are
that the value can be arbitrarily used by the baseline JIT.

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

9:51 AM Changeset in webkit [139067] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Skip http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url.html, because
it's been timing out since it was added.
https://bugs.webkit.org/show_bug.cgi?id=106332

  • platform/chromium/TestExpectations: Adjusted expectations.
9:50 AM Changeset in webkit [139066] by ap@apple.com
  • 14 edits
    2 moves in trunk/Source/WebKit2

[WK2] NetworkProcess should have a Keychain shim
https://bugs.webkit.org/show_bug.cgi?id=106286

Reviewed by Sam Weinig.

Renamed WebProcessShim to SecItemShim. Use it with NetworkProcess, too.

  • WebProcess/mac/SecItemShimLibrary.h: Copied from Source/WebKit2/WebProcess/mac/WebProcessShim.h.
  • WebProcess/mac/SecItemShimLibrary.mm: Copied from Source/WebKit2/WebProcess/mac/WebProcessShim.mm. This code lives in SecItemShim.dylib. "Library" in the name is to avoid conflicting with SecItemShim class in WebKit2.
  • Shared/mac/SecItemShim.cpp: (WebKit::sendSecItemRequest): (WebKit::SecItemShim::initialize):
  • Shared/mac/SecItemShim.h: Take a ChildProcess pointer at initialization instead of using using WebProcess::shared().
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::addDYLDEnvironmentAdditions): Use SecItemShim with NetworkProcess too.
  • NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::initializeConnection):
  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/mac/NetworkProcessMac.mm: (WebKit::NetworkProcess::platformInitializeNetworkProcess):
  • UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::didFinishLaunching):
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeConnection):
  • WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeProcess):
  • WebProcess/mac/WebProcessMainMac.mm: (WebKit::WebProcessMainDelegate::doPreInitializationWork):
  • WebProcess/mac/WebProcessServiceEntryPoints.mm: (webProcessServiceMain): (initializeWebProcessForWebProcessServiceForWebKitDevelopment):
  • WebProcess/mac/WebProcessShim.h: Removed.
  • WebProcess/mac/WebProcessShim.mm: Removed.
  • WebProcessService/Info.plist:
9:33 AM Changeset in webkit [139065] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Make the override-feature-defines script compatible with Python v3
https://bugs.webkit.org/show_bug.cgi?id=105742

Reviewed by Martin Robinson.

Instead of printing output through a statement, use the print function and format
the output using the str.format method. This makes the script runnable with Python v3.

  • gtk/override-feature-defines:

(adjust_feature_defines_makefile):

9:29 AM Changeset in webkit [139064] by morrita@google.com
  • 17 edits in trunk/Source/WebCore

[Shadow DOM] Refactoring: invalidateParentDistributionIfNecessary() calls are too intrusive
https://bugs.webkit.org/show_bug.cgi?id=106305

Reviewed by Dimitri Glazkov.

Scattering invalidateParentDistributionIfNecessary() looks bad because

  • it has long name whose terminology is cryptic for people who don't know much about Shadow DOM standard.
  • its calls are always paired with setNeedsStyleRecalc() and people do setNeedsStyleRecalc() need to be aware about distribution feature bit tracking. Separate invalidateParentDistributionIfNecessary() call doesn't help that recognition.

This change introduces Element::didAffectSelector() to replace a setNeedsStyleRecalc()-i37y() call sequence.
SelectRuleFeatureSet::FeatureRule is renamed AffectedSelectorType so that it explains its purpose
in a bit more plain WebKit term.

No new tests. Refactoring.

  • dom/Document.cpp:

(WebCore::Document::setCSSTarget): Adopted didAffectSelector.

  • dom/Element.cpp:

(WebCore::Element::didAffectSelector): Added.
(WebCore):

  • dom/Element.h:

(Element):

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::didAffectSelector): Morphed from invalidateParentDistributionIfNecessary().

  • dom/ElementShadow.h:

(ElementShadow):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute): Adopted didAffectSelector

  • html/HTMLDetailsElement.cpp:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::disabledAttributeChanged): Adopted didAffectSelector

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setChecked): Adopted didAffectSelector
(WebCore::HTMLInputElement::setIndeterminate): Adopted didAffectSelector

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::parseAttribute): Adopted didAffectSelector

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::parseAttribute): Adopted didAffectSelector
(WebCore::HTMLOptionElement::setSelectedState): Adopted didAffectSelector

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::didElementStateChange): Adopted didAffectSelector

  • html/HTMLSummaryElement.cpp:
  • html/shadow/HTMLContentElement.cpp:
  • html/shadow/SelectRuleFeatureSet.cpp:

(WebCore::SelectRuleFeatureSet::collectFeaturesFromSelector): Followed renaming.

  • html/shadow/SelectRuleFeatureSet.h: Followed renaming.

(WebCore::SelectRuleFeatureSet::hasSelectorForChecked):
(WebCore::SelectRuleFeatureSet::hasSelectorForEnabled):
(WebCore::SelectRuleFeatureSet::hasSelectorForDisabled):
(WebCore::SelectRuleFeatureSet::hasSelectorForIndeterminate):
(WebCore::SelectRuleFeatureSet::hasSelectorForLink):
(WebCore::SelectRuleFeatureSet::hasSelectorForTarget):
(WebCore::SelectRuleFeatureSet::hasSelectorForVisited):
(WebCore::SelectRuleFeatureSet::hasSelectorFor):
(WebCore::SelectRuleFeatureSet::setSelectRuleFeature):

8:47 AM Changeset in webkit [139063] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Fix build with --web-audio
https://bugs.webkit.org/show_bug.cgi?id=106328

Reviewed by Philippe Normand.

Build fix, no new tests required.

  • Target.pri: addded missing OfflineAudioContext.[cpp|h].
8:45 AM Changeset in webkit [139062] by Martin Robinson
  • 3 edits
    6 adds in trunk

[GTK] Login & password shown in browsers' URL entry after successful HTTP authentication
https://bugs.webkit.org/show_bug.cgi?id=105190

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Test: http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url.html

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::restartedCallback): After sending a redirect with credentials to libsoup, strip
the credentials from the request. This ensures that the credentials do not show up in
the user agent or in document.location.

LayoutTests:

Add a new test that checks that the URL of a page that redirects and uses
authentication. This verifies correct behavior for ports that communicates
a request's credentials to the platform networking layer by setting them in the URL.
The credentials should not remain in the URL string itself.

  • http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt: Added.
  • http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url.html: Added.
  • http/tests/misc/authentication-redirect-4/resources/auth-echo.php: Added.
  • http/tests/misc/authentication-redirect-4/resources/auth-then-redirect.php: Added.
8:36 AM Changeset in webkit [139061] by zandobersek@gmail.com
  • 5 edits in trunk/LayoutTests

Unreviwed gardening.

Removing failure expectations/skip entries for fast/dom/Window/window-postmessage-arrays.html.
The test was fixed by r138964.

Also further remove failure expectations for now-passing tests on the GTK builders.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
8:28 AM Changeset in webkit [139060] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Can't select text out of current focused input
https://bugs.webkit.org/show_bug.cgi?id=106322

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2013-01-08
Reviewed by Rob Buis.

PR270755
Internally reviewed by Mike Fenton

When selection changed, the selection handler clips new selection with
current focused node's boundary. So we clear focus before selectObject.
This patch clear focus when selectObject is at a point but not at a node.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectObject):

8:08 AM Changeset in webkit [139059] by junov@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 138994

Fixing memory read after free in CanvasRenderingContext2D::accessFont
https://bugs.webkit.org/show_bug.cgi?id=106244

Reviewed by Abhishek Arya.

Source/WebCore:

Using a temporary String object to hold ref count on string that is
passed by reference in CanvasRenderingContext2D::accessFont.

Test: fast/canvas/canvas-measureText.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::accessFont):

LayoutTests:

New test case to verify stability of 2D canvas method measureText.
Test case was causing a DumpRenderTree crash on builds with
AddressSantitizer instrumentation.

  • fast/canvas/canvas-measureText-expected.txt: Added.
  • fast/canvas/canvas-measureText.html: Added.

TBR=junov@google.com
Review URL: https://codereview.chromium.org/11808004

8:04 AM Changeset in webkit [139058] by junov@google.com
  • 1 edit
    2 copies in branches/chromium/1312

Merge 138994

Fixing memory read after free in CanvasRenderingContext2D::accessFont
https://bugs.webkit.org/show_bug.cgi?id=106244

Reviewed by Abhishek Arya.

Source/WebCore:

Using a temporary String object to hold ref count on string that is
passed by reference in CanvasRenderingContext2D::accessFont.

Test: fast/canvas/canvas-measureText.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::accessFont):

LayoutTests:

New test case to verify stability of 2D canvas method measureText.
Test case was causing a DumpRenderTree crash on builds with
AddressSantitizer instrumentation.

  • fast/canvas/canvas-measureText-expected.txt: Added.
  • fast/canvas/canvas-measureText.html: Added.

TBR=junov@google.com
Review URL: https://codereview.chromium.org/11783030

7:58 AM Changeset in webkit [139057] by junov@google.com
  • 3 edits
    2 copies in branches/chromium/1271

Merge 138994

Fixing memory read after free in CanvasRenderingContext2D::accessFont
https://bugs.webkit.org/show_bug.cgi?id=106244

Reviewed by Abhishek Arya.

Source/WebCore:

Using a temporary String object to hold ref count on string that is
passed by reference in CanvasRenderingContext2D::accessFont.

Test: fast/canvas/canvas-measureText.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::accessFont):

LayoutTests:

New test case to verify stability of 2D canvas method measureText.
Test case was causing a DumpRenderTree crash on builds with
AddressSantitizer instrumentation.

  • fast/canvas/canvas-measureText-expected.txt: Added.
  • fast/canvas/canvas-measureText.html: Added.

TBR=junov@google.com

7:26 AM Changeset in webkit [139056] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Changing a timeout expectation for inspector/timeline/timeline-decode-resize.html
to a failure expectation. The test doesn't time out anymore due to added WebP support.

Adding a timeout expectation for two proximity layout tests added in r139050.

  • platform/gtk/TestExpectations:
6:12 AM Changeset in webkit [139055] by keishi@webkit.org
  • 7 edits in trunk

[Chromium] Don't confine page popups to root view on Mac
https://bugs.webkit.org/show_bug.cgi?id=106315

Reviewed by Kent Tamura.

Source/WebCore:

No new tests.

  • Resources/pagepopups/pickerCommon.js:

(adjustWindowRect): Remove code to confine to root view.

Source/WebKit/chromium:

Page popups on Mac no longer get clipped to the web view so we can
remove the code to confine to root view.

  • src/ColorChooserPopupUIController.cpp:

(WebKit::ColorChooserPopupUIController::writeDocument): Removing parameters confineToRootView and rootViewRectInScreen.

  • src/DateTimeChooserImpl.cpp:

(WebKit::DateTimeChooserImpl::writeDocument): Ditto.

LayoutTests:

  • platform/chromium/fast/forms/page-popup/page-popup-adjust-rect.html: Remove setting parameters confineToRootView and rootViewRectInScreen.
6:06 AM Changeset in webkit [139054] by tonikitoo@webkit.org
  • 3 edits in trunk/Source/WebCore

Make RenderLayer::updateNeedsCompositedScrolling scrollbars agnostic
https://bugs.webkit.org/show_bug.cgi?id=95494

Reviewed by James Robinson.
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>

Some ports (including Qt-wk1 and BlackBerry) allow disabling
scrollbars at FrameView creation level. That said, cheking for the
scrollbars presence in order to determine if we should promote a
RenderLayer to use composited scrolling is not ideal, as done in
RenderLayerCompositor::updateNeedsCompositedScrolling()

Instead, this patch makes the RenderLayer class to query its FrameView
if it has been cached as scrollable by the later.

Least, patch also takes this opportunity to remove RenderLayer::allowsScrolling,
which became unused.

No new tests added, since there is no *practical* behavior change: ports
like Chromium and others who currently check for the scrollbars presence
in order to determine either to promote or not layers to benefit of composited
scrolling should not be affected.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateNeedsCompositedScrolling):

  • rendering/RenderLayer.h:

(RenderLayer):

6:05 AM Changeset in webkit [139053] by tonikitoo@webkit.org
  • 5 edits in trunk/Source

Introduce a compositing trigger for scrollable frames
https://bugs.webkit.org/show_bug.cgi?id=105573

Reviewed by James Robinson.
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>

Source/WebCore:

Make requiresCompositingForScrollableFrame to check the
newly added compositing trigger instead of the associated setting.

It introduces no have behavior change, so no new tests. Patch basically
does some preparation work for adding support to composite scrollable inner
frames independently from "force compositing mode" bit.

  • page/ChromeClient.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
(WebCore::RenderLayerCompositor::requiresCompositingForScrollableFrame):

Source/WebKit/chromium:

Set the newly added scrollable-inner-frames bit to compositing-trigger
bitset in accordance to the respective setting value.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::allowedCompositingTriggers):

5:28 AM Changeset in webkit [139052] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Qt] Fix libxml2 config test
https://bugs.webkit.org/show_bug.cgi?id=106317

Patch by Heikki Paajanen <heikki.paajanen@palm.com> on 2013-01-08
Reviewed by Simon Hausmann.

Don't assume standard include/libxml2, libxml-2.0.pc should know
where it's headers are.

  • qmake/config.tests/libxml2/libxml2.cpp: Fix include
3:54 AM Changeset in webkit [139051] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a new failing test.

  • platform/qt/TestExpectations:
3:34 AM Changeset in webkit [139050] by kihong.kwon@samsung.com
  • 20 edits
    27 adds in trunk

Add DeviceProximityController to support Device Proximity Events.
https://bugs.webkit.org/show_bug.cgi?id=97630

Reviewed by Hajime Morita.

Source/WebCore:

Implement DeviceProximityController which is inherited from DeviceController to support Device Proximity Events.
DeviceProximityController has two major functionalities.

  • When listener is added, DeviceProximityController stores DOMWindow pointer to m_listeners and start gathering proximity event.
  • When DeviceProximityController receives a proximity event from client, fire an event using m_listeners.

In addition, setDeviceProximity function is added to Internals for layout test.

Tests: proximity/add-listener-from-callback.html

proximity/basic-operation.html
proximity/create-event.html
proximity/event-after-navigation.html
proximity/multiple-frames.html
proximity/no-page-cache.html
proximity/optional-event-properties.html
proximity/updates.html
proximity/window-property.html

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/proximity/DeviceProximityClient.h: Added.

(WebCore):
(DeviceProximityClient):
(WebCore::DeviceProximityClient::~DeviceProximityClient):

  • Modules/proximity/DeviceProximityController.cpp: Added.

(WebCore):
(WebCore::DeviceProximityController::DeviceProximityController):
(WebCore::DeviceProximityController::create):
(WebCore::DeviceProximityController::didChangeDeviceProximity):
(WebCore::DeviceProximityController::deviceProximityClient):
(WebCore::DeviceProximityController::hasLastData):
(WebCore::DeviceProximityController::getLastEvent):
(WebCore::DeviceProximityController::supplementName):
(WebCore::DeviceProximityController::from):
(WebCore::DeviceProximityController::isActiveAt):
(WebCore::provideDeviceProximityTo):

  • Modules/proximity/DeviceProximityController.h: Added.

(WebCore):
(DeviceProximityController):
(WebCore::DeviceProximityController::~DeviceProximityController):

  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.xcodeproj/project.pbxproj:
  • history/PageCache.cpp:

When a page has Device Proximity Event Listener, it has not to be cached like Device Orientation.
(WebCore::logCanCachePageDecision):
(WebCore::PageCache::canCache):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):

  • testing/Internals.cpp:

(WebCore::Internals::setDeviceProximity):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

Add initial WebDeviceProximityClient class which is inherited DeviceProximityClient.
But startUpdating and stopUpdating need to be implemented.

  • CMakeLists.txt:
  • WebProcess/WebCoreSupport/WebDeviceProximityClient.cpp: Added.

(WebKit):
(WebKit::WebDeviceProximityClient::WebDeviceProximityClient):
(WebKit::WebDeviceProximityClient::startUpdating):
(WebKit::WebDeviceProximityClient::stopUpdating):
(WebKit::WebDeviceProximityClient::hasLastData):

  • WebProcess/WebCoreSupport/WebDeviceProximityClient.h: Added.

(WebKit):
(WebDeviceProximityClient):
(WebKit::WebDeviceProximityClient::~WebDeviceProximityClient):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

LayoutTests:

Add layout test cases for the DeviceProximityController.

  • proximity/add-listener-from-callback-expected.txt: Added.
  • proximity/add-listener-from-callback.html: Added.
  • proximity/basic-operation-expected.txt: Added.
  • proximity/basic-operation.html: Added.
  • proximity/create-event-expected.txt: Added.
  • proximity/create-event.html: Added.
  • proximity/event-after-navigation-expected.txt: Added.
  • proximity/event-after-navigation.html: Added.
  • proximity/multiple-frames-expected.txt: Added.
  • proximity/multiple-frames.html: Added.
  • proximity/no-page-cache-expected.txt: Added.
  • proximity/no-page-cache.html: Added.
  • proximity/optional-event-properties-expected.txt: Added.
  • proximity/optional-event-properties.html: Added.
  • proximity/resources/cached-page-1.html: Added.
  • proximity/resources/cached-page-2.html: Added.
  • proximity/resources/event-after-navigation-new.html: Added.
  • proximity/updates-expected.txt: Added.
  • proximity/updates.html: Added.
  • proximity/window-property-expected.txt: Added.
  • proximity/window-property.html: Added.
2:36 AM AddingFeatures edited by zandobersek@gmail.com
Adding instructions about adding new features for the Autotools build … (diff)
2:29 AM ScalesAndZooms edited by mnaganov@chromium.org
Logical pixels -> DIP pixels, see … (diff)
2:17 AM Changeset in webkit [139049] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding failure expectation for an a11y test added in r139002.

  • platform/gtk/TestExpectations:
2:10 AM Changeset in webkit [139048] by zandobersek@gmail.com
  • 4 edits in trunk/Tools

[GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
https://bugs.webkit.org/show_bug.cgi?id=106195

Reviewed by Philippe Normand.

Perform changes in the generate-gtkdoc script and common and gtkdoc modules
to make the Python code compatible with Python 3. This includes modifying
print statements, exception handling, dictionary iteration and
byte-sequence-to-string conversion.

  • gtk/common.py:

(get_build_path):
(pkg_config_file_variable):
(gtk_version_of_pkg_config_file):

  • gtk/generate-gtkdoc:

(print_missing_api):

  • gtk/gtkdoc.py:

(GTKDoc.init):
(GTKDoc._run_command):

1:37 AM Changeset in webkit [139047] by Csaba Osztrogonác
  • 1 edit
    19 adds in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening after r138932.

  • platform/qt-5.0-wk2/fast/ruby/ruby-beforeafter-expected.png: Added.
  • platform/qt-5.0-wk2/fast/ruby/ruby-beforeafter-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/ruby/ruby-empty-rt-expected.png: Added.
  • platform/qt-5.0-wk2/fast/ruby/ruby-empty-rt-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/ruby/ruby-length-expected.png: Added.
  • platform/qt-5.0-wk2/fast/ruby/ruby-length-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/ruby/ruby-run-break-expected.png: Added.
  • platform/qt-5.0-wk2/fast/ruby/ruby-run-break-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/ruby/ruby-runs-expected.png: Added.
  • platform/qt-5.0-wk2/fast/ruby/ruby-runs-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/ruby/ruby-runs-spans-expected.png: Added.
  • platform/qt-5.0-wk2/fast/ruby/ruby-runs-spans-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/ruby/ruby-simple-expected.png: Added.
  • platform/qt-5.0-wk2/fast/ruby/ruby-simple-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/ruby/ruby-simple-rp-expected.png: Added.
  • platform/qt-5.0-wk2/fast/ruby/ruby-simple-rp-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/ruby/ruby-trailing-expected.png: Added.
  • platform/qt-5.0-wk2/fast/ruby/ruby-trailing-expected.txt: Added.
1:31 AM Changeset in webkit [139046] by sergio@webkit.org
  • 11 edits in trunk

[GTK] Add WebP image support
https://bugs.webkit.org/show_bug.cgi?id=105915

Reviewed by Martin Robinson.

.:

WebP is from now on a dependency for WebKitGtk+.

  • configure.ac: added WebP library detection.

Source/WebCore:

  • GNUmakefile.am: add WTF_USE_WEBP definition.
  • GNUmakefile.list.am: properly sort image decoders in the sources list.

Source/WebKit/gtk:

  • GNUmakefile.am: link against WebP library.

Source/WebKit2:

  • GNUmakefile.am: link against WebP library.

LayoutTests:

  • platform/gtk/TestExpectations: unskipped two tests passing now

that we have WebP support.

1:27 AM Changeset in webkit [139045] by commit-queue@webkit.org
  • 12 edits in trunk/Source

Rename 'IntSize toSize(const IntPoint&)' to 'toIntSize'
https://bugs.webkit.org/show_bug.cgi?id=106307

This matches other method names which distinguish between sizes and
points. See https://bugs.webkit.org/show_bug.cgi?id=105992#c4.

Patch by Steve Block <steveblock@chromium.org> on 2013-01-08
Reviewed by Kentaro Hara.

Source/WebCore:

Refactoring only, no functional change.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::scrollTo):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

  • platform/ScrollView.h:

(WebCore::ScrollView::scrollOffset):

  • platform/graphics/IntPoint.h:

(WebCore::toIntSize):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::positionNewlyCreatedOverflowControls):
(WebCore::RenderLayer::paintOverflowControls):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

Source/WebKit/blackberry:

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition):

Source/WebKit/chromium:

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::setViewport):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::minimumScrollOffset):
(WebKit::WebFrameImpl::maximumScrollOffset):

12:57 AM Changeset in webkit [139044] by yosin@chromium.org
  • 16 edits
    2 adds in trunk

Dragging over an element with scrollbars should scroll the element when dragging near edges
https://bugs.webkit.org/show_bug.cgi?id=39725

Reviewed by Hajime Morita.

Source/WebCore:

This patch introduces auto scrolling functionality during drag-and-drop
when drop source is near edge of scrollable element.

When drop source is inside 20px of scrollable element more than 200ms,
scrollable element is automatically scrolled every 50ms toward drop
source position, e.g. vertically scroll up when drop source is in top
edge.

Test: fast/events/drag-and-drop-autoscroll.html

  • page/AutoscrollController.cpp:

(WebCore::AutoscrollController::AutoscrollController): Changed to initialize m_dragAndDropAutoscrollStartTime.
(WebCore::AutoscrollController::updateDragAndDrop): Added for start/stop autoscroll during drag-and-drop.
(WebCore::AutoscrollController::autoscrollTimerFired): Changed to add autoscroll for drag-and-drop, and to pass last know position to RenderBox::autoscroll().

  • page/AutoscrollController.h:

(AutoscrollController): Changed to add updateDragAndDrop() and m_dragAndDropAutoscrollReferencePosition and m_dragAndDropAutoscrollStartTime.

  • page/EventHandler.cpp:

(WebCore::EventHandler::updateDragAndDrop): Changed to call AutoscrollController::updateDragAndDrop().

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::autoscroll): Changed for new parameter position.
(WebCore::RenderBox::calculateAutoscrollDirection): Added for autoscroll.

  • rendering/RenderBox.h:

(RenderBox):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::autoscroll): Changed for new parameter position and move updateSelectionForMouseDrag() to AutoscrollController.

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::autoscroll): Changed for new parameter position.

  • rendering/RenderListBox.h:

(RenderListBox):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::autoscroll): Changed for new parameter position.

  • rendering/RenderTextControlSingleLine.h:

(RenderTextControlSingleLine):

Source/WebKit/chromium:

This patch removes DragScrollTimer used for automatic scrolling of main
frame drag-and-drop which is now implemented in EventHandler.

Another patch will remove DragScrollTimer.{cpp,h} and update GYP files to
make patch size small.

No tests. Existing test covers this change.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl): Changed to remove m_dragScrollTimer.
(WebKit::WebViewImpl::dragSourceEndedAt): ditto
(WebKit::WebViewImpl::dragSourceMovedTo): ditto
(WebKit::WebViewImpl::dragTargetDrop): ditto
(WebKit::WebViewImpl::dragTargetDragEnterOrOver): ditto

  • src/WebViewImpl.h:

(WebKit): Chagned to remove DragScrollTimer.

LayoutTests:

This patch adds new test for autoscroll during drag-and-drop.

  • fast/events/drag-and-drop-autoscroll-expected.txt: Added.
  • fast/events/drag-and-drop-autoscroll.html: Added.
12:40 AM Changeset in webkit [139043] by jochen@chromium.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r139036): 'WebCore::DateTimeSymbolicFieldElement::isInRange' hides overloaded virtual function
https://bugs.webkit.org/show_bug.cgi?id=106311

Unreviewed build fix.

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::stepDown):
(WebCore::DateTimeSymbolicFieldElement::stepUp):

  • html/shadow/DateTimeSymbolicFieldElement.h:

(WebCore::DateTimeSymbolicFieldElement::indexIsInRange): renamed method to avoid hiding Element::isInRange

12:23 AM Changeset in webkit [139042] by abarth@webkit.org
  • 5 edits in trunk/Source/WebCore

HTMLTreeBuilder shouldn't keep a Document pointer
https://bugs.webkit.org/show_bug.cgi?id=106268

Reviewed by Eric Seidel.

The tree builder shouldn't interact with the Document directly.
Instead, the tree builder should use the HTMLConstructionSite to
interact with the document.

Unfortunately, the HTMLTreeBuilder does need to read back one bit of
information (the quirks mode) from the Document. Currently the
HTMLConstructionSite reads the information directly from the Document.
If/when we move the parser onto its own thread, we'll need to keep
track of this bit on the parser thread. (We should be able to
encapsulate all that logic in the HTMLConstructionSite.)

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::setDefaultCompatibilityMode):
(WebCore):
(WebCore::HTMLConstructionSite::finishedParsing):
(WebCore::HTMLConstructionSite::inQuirksMode):

  • html/parser/HTMLConstructionSite.h:

(HTMLConstructionSite):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::detach):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::defaultForInitial):
(WebCore::HTMLTreeBuilder::finished):

  • html/parser/HTMLTreeBuilder.h:

(HTMLTreeBuilder):

12:15 AM Changeset in webkit [139041] by Csaba Osztrogonác
  • 1 edit
    4 adds in trunk/Source/WebKit2

[Qt][Win] Unreviewed buildfix, partially revert
r139003, because Qt port still uses these files.

  • Platform/CoreIPC/win/BinarySemaphoreWin.cpp: Added.
  • Platform/CoreIPC/win/ConnectionWin.cpp: Added.
  • Platform/win/SharedMemoryWin.cpp: Added.
  • Platform/win/WorkQueueWin.cpp: Added.
12:12 AM Changeset in webkit [139040] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Float block's logical top margin is illegal in vertical writing mode.
https://bugs.webkit.org/show_bug.cgi?id=96597

Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2013-01-08
Reviewed by Hajime Morita.

Source/WebCore:

flipFloatForWritingModeForChild() should use child->renderer()->width() not child->width() like horizontal writing mode.

Test: fast/writing-mode/vertical-float-margin.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::flipFloatForWritingModeForChild):

LayoutTests:

Specify margin to float block in vertical writing mode.

  • fast/writing-mode/vertical-float-margin-expected.html: Added.
  • fast/writing-mode/vertical-float-margin.html: Added.
  • platform/chromium/TestExpectations: Add need rebaseline.

Jan 7, 2013:

11:53 PM Changeset in webkit [139039] by steveblock@google.com
  • 2 edits in trunk/Tools

Add chromium.org email address for Steve Block.

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
11:49 PM Changeset in webkit [139038] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

REGRESSION(r137406): Text inside an empty optgroup prevents subsequent options from appearing
https://bugs.webkit.org/show_bug.cgi?id=106298

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/forms/select/select-empty-optgroup.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::recalcListItems):
Traverse to the first element within the 'current' only if it exists.

LayoutTests:

  • fast/forms/select/select-empty-optgroup-expected.html: Added.
  • fast/forms/select/select-empty-optgroup.html: Added.
11:46 PM Changeset in webkit [139037] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Use toSize() to convert from Int/FloatPoint to Int/FloatSize
https://bugs.webkit.org/show_bug.cgi?id=105992

Patch by Steve Block <steveblock@chromium.org> on 2013-01-07
Reviewed by Kentaro Hara.

Source/WebCore:

Refactoring only, no change in behavior.

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::computePath):

  • platform/ScrollView.h:

(WebCore::ScrollView::scrollOffset):

  • platform/graphics/FloatPoint.h:

(WebCore::toFloatSize):
Add 'inline FloatSize toFloatSize(const FloatPoint&)' to match IntPoint.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

Source/WebKit/chromium:

  • src/LinkHighlight.cpp:

(WebKit::LinkHighlight::computeHighlightLayerPathAndPosition):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::minimumScrollOffset):
(WebKit::WebFrameImpl::maximumScrollOffset):

11:19 PM Changeset in webkit [139036] by commit-queue@webkit.org
  • 10 edits
    6 adds in trunk

INPUT_MULTIPLE_FIELDS_UI: Step-up/-down of month/day field should respect min/max attributes
https://bugs.webkit.org/show_bug.cgi?id=106212

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-01-07
Reviewed by Kent Tamura.

Source/WebCore:

Make step-up/-down of the month and day fields respect the min/max
attributes of the element.
Note that these fields still accept any keyboard inputs (the element
becomes 'invalid' state when out-of-bounds values entered).

Tests: fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html

fast/forms/date-multiple-fields/date-multiple-fields-stepup-stepdown-from-renderer.html
fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield.html
fast/forms/month-multiple-fields/month-multiple-fields-stepup-stepdown-from-renderer.html

  • css/html.css: Add CSS rules for month and day fields.
  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditBuilder::visitField):
Compute minimum/maximum values of month/day fields from the min/max
parameters of the element. If minimum, maximum, and current value is
the same, makes the field read-only.

  • html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeAMPMFieldElement::DateTimeAMPMFieldElement): Add mininum/maximum arguments.
(WebCore::DateTimeDayFieldElement::DateTimeDayFieldElement): Ditto.
(WebCore::DateTimeDayFieldElement::create): Ditto.
(WebCore::DateTimeDayFieldElement::clampValueForHardLimits): Added.
(WebCore::DateTimeMonthFieldElement::DateTimeMonthFieldElement): Add mininum/maximum arguments.
(WebCore::DateTimeMonthFieldElement::create): Ditto.
(WebCore::DateTimeMonthFieldElement::clampValueForHardLimits): Added.
(WebCore::DateTimeSymbolicMonthFieldElement::DateTimeSymbolicMonthFieldElement): Add mininum/maximum arguments.
(WebCore::DateTimeSymbolicMonthFieldElement::create): Ditto.

  • html/shadow/DateTimeFieldElements.h:

(DateTimeDayFieldElement): Add mininum/maximum arguments and declare clampValueForHardLimits.
(DateTimeMonthFieldElement): Ditto.
(DateTimeSymbolicMonthFieldElement): Add mininum/maximum arguments.

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement): Add mininum/maximum arguments.
(WebCore::DateTimeSymbolicFieldElement::maximum): Returns m_maximumIndex + 1 as it assumes 1-origin value.
(WebCore::DateTimeSymbolicFieldElement::minimum): Ditto.
(WebCore::DateTimeSymbolicFieldElement::stepDown): Restrict value to m_minimumIndex-m_maximumIndex.
(WebCore::DateTimeSymbolicFieldElement::stepUp): Ditto.

  • html/shadow/DateTimeSymbolicFieldElement.h:

(DateTimeSymbolicFieldElement): Add m_minimumIndex and m_maximumIndex.
(WebCore::DateTimeSymbolicFieldElement::isInRange): Added.

LayoutTests:

  • fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield-expected.txt:
  • fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html: Add tests for month and day fields.
  • fast/forms/date-multiple-fields/date-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-stepup-stepdown-from-renderer.html: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield-expected.txt: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield.html: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Added.
  • fast/forms/month-multiple-fields/month-multiple-fields-stepup-stepdown-from-renderer.html: Added.
11:18 PM Changeset in webkit [139035] by keishi@webkit.org
  • 13 edits in branches/chromium/1364

Merge 138365

Fix typing zero into multiple field input
https://bugs.webkit.org/show_bug.cgi?id=105501

Reviewed by Kent Tamura.

Source/WebCore:

We have a couple of problems when handling zero in a multiple fields
element.

  1. Typing '02' into a month field will set '12'.
  2. Typing '0' into 12 hour hour field will set '12' and move to the focus to the next field.

This change adds a type ahead buffer so we can handle these cases
properly. If the value in the type ahead buffer is valid we set it so a
change event will fire.

Added tests to *-multiple-fields-keyboard-events.html.

  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::didBlur): Clear the type ahead
buffer. handleKeyboardEvent() won't set the type ahead value if it is
not in range, so we set the value here.
(WebCore::DateTimeNumericFieldElement::handleKeyboardEvent):
(WebCore::DateTimeNumericFieldElement::setEmptyValue): Clear type ahead buffer.
(WebCore::DateTimeNumericFieldElement::setValueAsInteger):
(WebCore::DateTimeNumericFieldElement::stepDown): Clear type ahead buffer.
(WebCore::DateTimeNumericFieldElement::stepUp): Clear type ahead buffer.
(WebCore::DateTimeNumericFieldElement::typeAheadValue): Returns integer
value for the type ahead characters.
(WebCore):
(WebCore::DateTimeNumericFieldElement::visibleValue): If we have type
ahead characters, show that.

  • html/shadow/DateTimeNumericFieldElement.h:

(DateTimeNumericFieldElement):

LayoutTests:

  • fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html:
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html:
  • fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:
  • fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events.html:

TBR=keishi@webkit.org
Review URL: https://codereview.chromium.org/11801035

11:07 PM Changeset in webkit [139034] by Christophe Dumez
  • 4 edits in trunk

[CoordinatedGraphics] compositing/repaint/resize-repaint.html is failing
https://bugs.webkit.org/show_bug.cgi?id=104637

Reviewed by Noam Rosenthal.

Source/WebKit2:

r137526 attempted to fix excessive repainting when compositing layers
change size. However, the fix did not suffice for ports using Coordinated
Graphics because CoordinatedGraphicsLayer::setSize() was calling
setNeedsDisplay() causing a full repaint.

This patch removes the call to setNeedsDisplay() in
CoordinatedGraphicsLayer::setSize() so that we don't unconditionally
repaint CoordinatedGraphics layers when their size changes.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setSize):

LayoutTests:

Unskip compositing/repaint/resize-repaint.html now that Coordinated
Graphics is no longer repainting unconditionally compositing layers
when their size changes.

  • platform/efl-wk2/TestExpectations:
10:53 PM Changeset in webkit [139033] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL][WK2][WebGL] The top left side of the screen is shown inside the canvas element
https://bugs.webkit.org/show_bug.cgi?id=105136

Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2013-01-07
Reviewed by Noam Rosenthal.

Use glXSwapBuffers to force resize of GL surface after X window resize.

Fixes fast/canvas/webgl/webgl-composite-modes.html pixel test on EFL platform.

  • platform/graphics/surfaces/glx/X11WindowResources.cpp:

(WebCore::X11OffScreenWindow::reSizeWindow):

10:07 PM Changeset in webkit [139032] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Use explicit constructor to convert from Int/FloatSize to Int/FloatPoint
https://bugs.webkit.org/show_bug.cgi?id=106209

Patch by Steve Block <steveblock@chromium.org> on 2013-01-07
Reviewed by Kentaro Hara.

Refactoring only, no functional change.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

10:03 PM Changeset in webkit [139031] by Christophe Dumez
  • 5 edits
    2 adds in trunk

[CoordinatedGraphics] Support invalidation tracking for CoordinatedGraphicsLayer
https://bugs.webkit.org/show_bug.cgi?id=106002

Reviewed by Noam Rosenthal.

Source/WebKit2:

Add calls to addRepaintRect() to CoordinatedGraphicsLayer so that
we can track invalidation in the composited layer.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setContentsNeedsDisplay):
(WebCore::CoordinatedGraphicsLayer::setNeedsDisplay): Pass a FloatRect instead
of an IntRect to setNeedsDisplayInRect() since it is what it expects.
(WebCore::CoordinatedGraphicsLayer::setNeedsDisplayInRect):

LayoutTests:

Unskip several tests that require invalidation tracking for EFL WK2 now that
it is supported by Coordinated Graphics.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.

Use same expectation as mac port.

  • platform/efl/fast/images/repaint-subrect-grid-expected.txt: Added. We are sometimes

1 pixel off compared to the global expectation likely due to lack for subpixel layout
support.

8:58 PM Changeset in webkit [139030] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL][WebGL] Crash of WebKitTestRunner when running webgl layout tests
https://bugs.webkit.org/show_bug.cgi?id=105936

Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2013-01-07
Reviewed by Laszlo Gombos.

If canvas window becomes invalid don't create pixmap from it and don't
use it for painting.

Improves stability of existing webgl layout tests.

  • platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurfacePrivate::createPixmap):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):

8:39 PM Changeset in webkit [139029] by morrita@google.com
  • 4 edits
    2 adds in trunk

Document::m_activeNode should be always an Element.
https://bugs.webkit.org/show_bug.cgi?id=106193

Reviewed by Ryosuke Niwa.

Source/WebCore:

r137277 tightened an invariant that assumes that active node is
always an element. But Document::updateHoverActiveState() didn't
respect that assumption. This change forces it.

Test: svg/custom/text-use-click-crash.html

  • dom/Document.cpp:

(WebCore::Document::removedLastRef):
(WebCore::Document::detach):
(WebCore::Document::setActiveNode):
(WebCore::Document::activeChainNodeDetached):
(WebCore::Document::updateHoverActiveState):

  • dom/Document.h:

(WebCore::Document::activeElement): Renamed from m_activeNode for the clarification.
(Document):

LayoutTests:

  • svg/custom/text-use-click-crash-expected.txt: Added.
  • svg/custom/text-use-click-crash.html: Added.
8:24 PM Changeset in webkit [139028] by wangxianzhu@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Expose compositedScrollingForFramesEnabled setting in WebKit API
https://bugs.webkit.org/show_bug.cgi?id=106262

Reviewed by James Robinson.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setCompositedScrollingForFramesEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

7:00 PM Changeset in webkit [139027] by morrita@google.com
  • 4 edits in trunk/Source/WebCore

WebKit should compile on Mac with --shadow-dom
https://bugs.webkit.org/show_bug.cgi?id=105469

Reviewed by Dimitri Glazkov.

No new tests. Just changing build files.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Element.idl:
6:58 PM Changeset in webkit [139026] by senorblanco@chromium.org
  • 7 edits in trunk/Source

Add a flag to control canvas antialiasing.
https://bugs.webkit.org/show_bug.cgi?id=106255

Reviewed by Darin Fisher.

Source/WebCore:

This flag is not exposed through TestRunner or DRT, so no testing is
possible yet.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer):

  • page/Settings.in:

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setAntialiased2dCanvasEnabled):

  • src/WebSettingsImpl.h:
6:41 PM Changeset in webkit [139025] by jchaffraix@webkit.org
  • 5 edits
    4 adds in trunk

[CSS Grid Layout] Implement grid items sizing for fixed minmax grid tracks
https://bugs.webkit.org/show_bug.cgi?id=104700

Reviewed by Tony Chang.

Source/WebCore:

This change implements parts of the minmax() track sizing algorithm. The chosen subset enables us
to resolve any sizing function that doesn't size based on the content (min-content, max-content).

Tests: fast/css-grid-layout/minmax-fixed-logical-height-only.html

fast/css-grid-layout/minmax-fixed-logical-width-only.html

  • rendering/RenderGrid.cpp:

(WebCore::GridTrack::GridTrack):
Added a new member to hold the maximum track breadth.

(WebCore::RenderGrid::computePreferredLogicalWidths):
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
Updated these functions to work on both min and max track breadth. In order to match
the specification, if max track breadth < min track breadth, we ignore the max track breadth.
For computedUsedBreadthOfGridTracks, it also involves calling distributeSpaceToTracks.

(WebCore::RenderGrid::computeUsedBreadthOfLength):
New helper function that compute a single length's size.

(WebCore::sortByGridTrackGrowthPotential):
Ordering function for the sorting the track: it orders the track per increasing potential
growth (defined as the difference between max breadth and the currently used breadth).

(WebCore::RenderGrid::distributeSpaceToTracks):
Added this function that matches the specification's algorithm. Only the relevant bits from
the specification were implemented for now (for example, SubsetOfTracksForGrowthBeyondTrackGrowthConstraint
is always the empty set so it was omitted).

  • rendering/RenderGrid.h:

Added the new functions and declared GridTrack as public into the WebCore namespace.

  • rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::minTrackBreadth):
(WebCore::GridTrackSize::maxTrackBreadth):
Removed 2 ASSERTs as the layout algorithm doesn't care if the min / max were
set from a single track breadth or through minmax().

LayoutTests:

  • fast/css-grid-layout/minmax-fixed-logical-height-only-expected.txt: Added.
  • fast/css-grid-layout/minmax-fixed-logical-height-only.html: Added.
  • fast/css-grid-layout/minmax-fixed-logical-width-only-expected.txt: Added.
  • fast/css-grid-layout/minmax-fixed-logical-width-only.html: Added.
5:51 PM Changeset in webkit [139024] by wangxianzhu@chromium.org
  • 7 edits
    2 adds in trunk

Add a setting to enable composited scrolling for frames
https://bugs.webkit.org/show_bug.cgi?id=104950

Reviewed by James Robinson.

Source/WebCore:

Test: compositing/iframes/iframe-composited-scrolling.html

  • page/FrameView.cpp:

(WebCore::FrameView::usesCompositedScrolling): Returns true if compositedScrollingForFramesEnabled and the frame is in forced compositing mode (which is set when forced compositing mode and compositing for scrollable frames are enabled), so that ScrollingCoordinator won't include the region of the frame in the nonFastScrollableRegion.
(WebCore):

  • page/FrameView.h:

(FrameView):

  • page/Settings.in: Add compositedScrollingForFramesEnabled setting.
  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinatorChromium::frameViewLayoutUpdated): Changed the comment about which ScrollableAreas are non-fast-scrollable.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidScroll): Let ScrollongCoordinator know when the scrolling changes for a frame with composited scrolling enabled.

LayoutTests:

Test case to ensure iframes are not added into nonFastScrollableRegion when acceleratedCompositingForScrollableFramesEnabled and compositedScrollingForFramesEnabled.

  • compositing/iframes/iframe-composited-scrolling-expected.txt: Added.
  • compositing/iframes/iframe-composited-scrolling.html: Added.
5:45 PM Changeset in webkit [139023] by andersca@apple.com
  • 75 edits in trunk/Source/WebKit2

Remove PLATFORM(WIN) #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=106279

Reviewed by Sam Weinig.

  • Platform/CoreIPC/BinarySemaphore.cpp:
  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::waitForSyncReply):

  • Platform/CoreIPC/Connection.h:

(Client):

  • Platform/Module.cpp:

(WebKit::Module::Module):

  • Platform/Module.h:

(Module):

  • Platform/PlatformProcessIdentifier.h:

(WebKit):

  • Shared/CommandLine.h:

(CommandLine):

  • Shared/FontSmoothingLevel.h:
  • Shared/LayerTreeContext.h:

(LayerTreeContext):

  • Shared/NativeWebKeyboardEvent.h:

(NativeWebKeyboardEvent):

  • Shared/NativeWebMouseEvent.h:

(NativeWebMouseEvent):

  • Shared/NativeWebWheelEvent.h:

(NativeWebWheelEvent):

  • Shared/PlatformPopupMenuData.cpp:

(WebKit::PlatformPopupMenuData::PlatformPopupMenuData):
(WebKit::PlatformPopupMenuData::encode):
(WebKit::PlatformPopupMenuData::decode):

  • Shared/PlatformPopupMenuData.h:

(PlatformPopupMenuData):

  • Shared/Plugins/PluginModuleInfo.h:

(PluginModuleInfo):
(WebKit::PluginModuleInfo::isolatedCopy):

  • Shared/ShareableBitmap.h:

(ShareableBitmap):

  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebEvent.h:

(WebMouseEvent):

  • Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformMouseEvent::WebKit2PlatformMouseEvent):

  • Shared/WebMouseEvent.cpp:

(WebKit::WebMouseEvent::WebMouseEvent):
(WebKit::WebMouseEvent::encode):
(WebKit::WebMouseEvent::decode):

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:

(WebPageCreationParameters):

  • Shared/WebPreferencesStore.h:

(WebKit):

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters):

  • Shared/WebURLRequest.h:
  • Shared/WebURLResponse.h:
  • Shared/cg/ShareableBitmapCG.cpp:

(WebKit::ShareableBitmap::makeCGImageCopy):

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toFontSmoothingLevel):
(WebKit::toAPI):

  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/BackingStore.h:

(BackingStore):

  • UIProcess/PageClient.h:

(WebKit):
(PageClient):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):

  • UIProcess/WebContext.h:

(WebContext):

  • UIProcess/WebFullScreenManagerProxy.h:

(WebKit):

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy):

  • UIProcess/WebInspectorProxy.h:

(WebInspectorProxy):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::performDragControllerAction):
(WebKit::WebPageProxy::didReceiveEvent):
(WebKit::WebPageProxy::creationParameters):
(WebKit):

  • UIProcess/WebPageProxy.h:

(WebKit):
(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

  • WebKit2Prefix.h:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameCopyWebArchiveFilteringSubframes):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPrivateBrowsingEnabled):
(WebKit::InjectedBundle::switchNetworkLoaderToNewTestingSession):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(WebKit):
(InjectedBundle):

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

(NetscapePlugin):

  • WebProcess/Plugins/PluginController.h:

(PluginController):

  • WebProcess/Plugins/PluginView.cpp:
  • WebProcess/Plugins/PluginView.h:

(PluginView):

  • WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):
(WebKit::WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection):
(WebKit):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

  • WebProcess/WebCoreSupport/WebDragClient.cpp:

(WebKit):

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::respondToChangedSelection):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/WebPopupMenu.cpp:

(WebKit::WebPopupMenu::updateFromElement):

  • WebProcess/WebKitMain.cpp:
  • WebProcess/WebPage/DrawingArea.h:

(WebKit):
(DrawingArea):

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::createGraphicsContext):

  • WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl):

  • WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):

  • WebProcess/WebPage/LayerTreeHost.h:

(WebCore):
(WebKit):
(LayerTreeHost):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit):

  • WebProcess/WebPage/WebFrame.h:

(WebFrame):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::installPageOverlay):
(WebKit::WebPage::uninstallPageOverlay):
(WebKit::WebPage::getWebArchiveOfFrame):
(WebKit):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::ensurePrivateBrowsingSession):
(WebKit::WebProcess::destroyPrivateBrowsingSession):

  • WebProcess/WebProcess.h:

(WebProcess):

  • WebProcess/WebProcess.messages.in:
  • config.h:
5:39 PM Changeset in webkit [139022] by aelias@chromium.org
  • 2 edits
    3 adds in trunk

Divide gesture scroll delta by scale factor
https://bugs.webkit.org/show_bug.cgi?id=106263

Reviewed by Adam Barth.

Gesture scroll deltas were not being adjusted by the frame's scale
factors, resulting in overly fast main-thread scrolling when zoomed
in.

New test: fast/events/touch/gesture/touch-gesture-scroll-div-scaled.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureScrollCore):

5:23 PM Changeset in webkit [139021] by fpizlo@apple.com
  • 13 edits in trunk

Rationalize closure call heuristics and profiling
https://bugs.webkit.org/show_bug.cgi?id=106270

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Did a number of things:

  • CallLinkInfo now remembers if it was ever a closure call, and CallLinkStatus uses this. Reduces the likelihood that we will inline a closure call as if it was a normal call.


  • Made InlineCallFrame print inferred function names, and refactored CodeBlock::inferredName() to better use FunctionExecutable's API.


  • Made bytecode dumping print frequent exit sites that led to recompilation.


  • Made bytecode dumping for op_call and op_construct print what the CallLinkStatus saw.


  • bytecode/CallLinkInfo.h:

(JSC::CallLinkInfo::CallLinkInfo):
(CallLinkInfo):

  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFor):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::inferredName):
(JSC::CodeBlock::dumpBytecodeCommentAndNewLine):
(JSC::CodeBlock::printCallOp):

  • bytecode/CodeOrigin.cpp:

(JSC::CodeOrigin::dump):
(JSC::InlineCallFrame::inferredName):
(JSC):
(JSC::InlineCallFrame::dumpBriefFunctionInformation):
(JSC::InlineCallFrame::dump):

  • bytecode/CodeOrigin.h:

(InlineCallFrame):

  • bytecode/DFGExitProfile.cpp:

(JSC::DFG::ExitProfile::exitSitesFor):
(DFG):

  • bytecode/DFGExitProfile.h:

(ExitProfile):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

Source/WTF:

Reviewed by Oliver Hunt.

Add a macro to add a method to a class that returns a dumper. Allows you to have
secondary dump() methods for dumping either more or less information.

  • wtf/PrintStream.h:

(WTF):

Tools:

Reviewed by Oliver Hunt.

Add ability to use display-profiler-output via a pipe, and add the ability to dump
all generated code ('display *' or 'd *').

  • Scripts/display-profiler-output:
5:21 PM Changeset in webkit [139020] by abarth@webkit.org
  • 14 edits in trunk

HTMLTreeBuilder should not depend on Frame
https://bugs.webkit.org/show_bug.cgi?id=106256

Reviewed by Eric Seidel.

Source/WebCore:

Rather than have the tree builder ask the Frame whether scripting and
plugins are enabled, we now push that information to the tree builder
via HTMLParserOptions, letting us remove the Frame dependency from the
tree builder.

As a consequence of this change, the "script enabled" bit in the parser
is now locked in when the parser starts. This bit doesn't actually
control when script execute, only how the <noscript> element is parsed.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::tokenizerStateForContextElement):
(WebCore::HTMLDocumentParser::HTMLDocumentParser):

  • html/parser/HTMLMetaCharsetParser.cpp:

(WebCore::HTMLMetaCharsetParser::HTMLMetaCharsetParser):
(WebCore::HTMLMetaCharsetParser::checkForMetaCharset):

  • html/parser/HTMLParserOptions.cpp:

(WebCore::HTMLParserOptions::HTMLParserOptions):

  • html/parser/HTMLParserOptions.h:

(HTMLParserOptions):
(WebCore::HTMLParserOptions::HTMLParserOptions):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):
(WebCore::HTMLPreloadScanner::processToken):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::HTMLTokenizer):
(WebCore::HTMLTokenizer::nextToken):
(WebCore::HTMLTokenizer::updateStateFor):

  • html/parser/HTMLTokenizer.h:

(WebCore::HTMLTokenizer::create):
(HTMLTokenizer):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):

  • html/parser/HTMLTreeBuilder.h:
  • html/parser/HTMLViewSourceParser.cpp:

(WebCore::HTMLViewSourceParser::HTMLViewSourceParser):
(WebCore::HTMLViewSourceParser::updateTokenizerState):

LayoutTests:

I needed to update this test slightly because now we lock in the
"script enabled" bit for the parser when the parser starts. That means
we'll parse the document in a consistent way even if the "script
enabled" bit gets flipped later.

  • fast/parser/noscript-with-javascript-disabled-expected.txt:
  • fast/parser/noscript-with-javascript-disabled.html:
5:19 PM Changeset in webkit [139019] by ap@apple.com
  • 2 edits
    2 deletes in trunk/Source/WebKit2

[WK2] Delete more obsolete Keychain code
https://bugs.webkit.org/show_bug.cgi?id=106276

Reviewed by Sam Weinig.

Deleting dead code.

  • Shared/mac/KeychainAttribute.cpp: Removed.
  • Shared/mac/KeychainAttribute.h: Removed.
  • WebKit2.xcodeproj/project.pbxproj:
5:17 PM Changeset in webkit [139018] by ap@apple.com
  • 3 edits
    2 deletes in trunk/Source/WebKit2

[WK2] Merge SecItemShimMethods files into SecItemShim
https://bugs.webkit.org/show_bug.cgi?id=106278

Reviewed by Anders Carlsson.

Now that we have a SecItemShim class, there is no reason to split implementation
into a separate file.

  • Shared/mac/SecItemShim.cpp: (WebKit::responseMap): (WebKit::generateSecItemRequestID): (WebKit::sendSecItemRequest): (WebKit::webSecItemCopyMatching): (WebKit::webSecItemAdd): (WebKit::webSecItemUpdate): (WebKit::webSecItemDelete): (WebKit::SecItemShim::secItemResponse): (WebKit::SecItemShim::install):
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/mac/SecItemShimMethods.h: Removed.
  • WebProcess/mac/SecItemShimMethods.mm: Removed.
5:08 PM Changeset in webkit [139017] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Don't use double tap zoom if minimum and maximum page scale is the same
https://bugs.webkit.org/show_bug.cgi?id=106272

Patch by Yusuf Ozuysal <yusufo@google.com> on 2013-01-07
Reviewed by James Robinson.

We should only try to computed relevant scale and scrollOffset and start the animation
if the page is zoomable. This now creates an undesired animation for mobile pages which
are not zoomable.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

5:00 PM Changeset in webkit [139016] by tony@chromium.org
  • 8 edits in trunk

Remove more internals.settings that are autogenerated
https://bugs.webkit.org/show_bug.cgi?id=106253

Reviewed by Adam Barth.

Source/WebCore:

Remove 8 methods that are autogenerated by Settings.in.

No new tests, this is a refactor and is convered by existing tests.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup): Remove backup.
(WebCore::InternalSettings::Backup::restoreTo): Remove restore.

  • testing/InternalSettings.h:

(Backup): Remove member variables and functions.
(InternalSettings):

  • testing/InternalSettings.idl: Remove functions.

LayoutTests:

These tests were manually trying to reset setMediaPlaybackRequiresUserGesture
when the test ended because they weren't using the InternalSettings::Backup to
save/restore the prefs. The autogenerated code will properly reset these prefs
before the next test.

  • media/no-autoplay-with-user-gesture-requirement.html:
  • media/video-load-require-user-gesture.html:
  • media/video-play-require-user-gesture.html:
4:59 PM Changeset in webkit [139015] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Another incremental build fix after r139013.

  • mathml/MathMLAllInOne.cpp:
4:52 PM Changeset in webkit [139014] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Incremental build system on Windows port does not necessarily rebuild RenderBox.cpp after r139013.

  • rendering/RenderingAllInOne.cpp:
4:39 PM Changeset in webkit [139013] by eae@chromium.org
  • 5 edits
    2 adds in trunk

REGRESSION(SUBPIXEL_LAYOUT): el.offsetWidth < el.clientWidth for elements of a certain size
https://bugs.webkit.org/show_bug.cgi?id=106107

Source/WebCore:

Reviewed by Levi Weintraub.

Add overloaded pixelSnappedOffsetWidth|Height methods to
RenderBox that do pixel snapping with the same offset
as clientWidth/height to ensure consistent rounding.

Test: fast/sub-pixel/client-and-offset-width.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::pixelSnappedOffsetWidth):
(WebCore::RenderBox::pixelSnappedOffsetHeight):
Snap using the same offset as the clientWidth/height versions.

  • rendering/RenderBox.h:

Remove out of date FIXME and add OVERRIDE keyword.

  • rendering/RenderBoxModelObject.h:

Mark pixelSnappedOffsetWidth|Height as virtual.

LayoutTests:

Reviewed by Levi Weintraub.

Add test for clientWidth/offsetWidth rounding.

  • fast/sub-pixel/client-and-offset-width-expected.txt: Added.
  • fast/sub-pixel/client-and-offset-width.html: Added.
4:38 PM Changeset in webkit [139012] by rniwa@webkit.org
  • 6 edits in trunk

Source/JavaScriptCore: Sorted the xcodeproj file.

Tools: Sorted more xcodeproj files.

  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
4:38 PM Changeset in webkit [139011] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
4:30 PM Changeset in webkit [139010] by rniwa@webkit.org
  • 9 edits in trunk

Source/WebKit: Sorted the xcodeproj file.

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit2: Sorted the xcodeproj file.

  • WebKit2.xcodeproj/project.pbxproj:

Source/WTF: Sorted the xcodeproj file.

  • WTF.xcodeproj/project.pbxproj:

Tools: Sorted xcodeprojs files.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4:20 PM Changeset in webkit [139009] by ap@apple.com
  • 13 edits
    6 adds in trunk/Source/WebKit2

[WK2] Make SecItemShim messages work with any process
https://bugs.webkit.org/show_bug.cgi?id=106269

Reviewed by Sam Weinig.

Add SecItemShim and SecItemShimProxy classes to manage message sending, and moved
relevant code from WebProcess(Proxy).

  • DerivedSources.make:
  • Platform/CoreIPC/MessageID.h:
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didFinishLaunching):
  • UIProcess/WebProcessProxy.h: (WebProcessProxy):
  • UIProcess/WebProcessProxy.messages.in:
  • Shared/mac/SecItemShim.cpp: Added. (WebKit::SecItemShim::shared): (WebKit::SecItemShim::SecItemShim): (WebKit::SecItemShim::secItemResponse): (WebKit::SecItemShim::install): (WebKit::SecItemShim::didReceiveMessageOnConnectionWorkQueue):
  • Shared/mac/SecItemShim.h: Added.
  • Shared/mac/SecItemShim.messages.in: Added.
  • UIProcess/mac/SecItemShimProxy.cpp: Added. (WebKit::SecItemShimProxy::shared): (WebKit::SecItemShimProxy::SecItemShimProxy): (WebKit::handleSecItemRequest): (WebKit::dispatchFunctionOnQueue): (WebKit::SecItemShimProxy::secItemRequest): (WebKit::SecItemShimProxy::didReceiveMessageOnConnectionWorkQueue):
  • UIProcess/mac/SecItemShimProxy.h: Added.
  • UIProcess/mac/SecItemShimProxy.messages.in: Added.
  • UIProcess/mac/WebProcessProxyMac.mm:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeConnection):
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
  • WebProcess/mac/SecItemShimMethods.mm: (WebKit::sendSeqItemRequest):
  • WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeProcess):
4:20 PM Changeset in webkit [139008] by abarth@webkit.org
  • 14 edits
    2 adds in trunk/Source/WebCore

Introduce HTMLParserOptions to encapsulate HTML parser options
https://bugs.webkit.org/show_bug.cgi?id=106251

Reviewed by Eric Seidel.

Currently, the HTMLTreeBuilder (and potentially other parts of the
parser) use their Document* to read configuration information from the
Document (such as Settings). This patch introduces the
HTMLParserOptions class to encapsulate that information, making it
easier to move the HTML parser to a background thread (because the
HTMLTreeBuilder won't need to talk to the Document directly).

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):

  • html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):

  • html/parser/HTMLPreloadScanner.h:

(WebCore):
(HTMLPreloadScanner):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):

  • html/parser/HTMLTreeBuilder.h:

(WebCore::HTMLTreeBuilder::create):
(HTMLTreeBuilder):

  • html/parser/HTMLViewSourceParser.cpp:

(WebCore::HTMLViewSourceParser::HTMLViewSourceParser):

3:59 PM Changeset in webkit [139007] by rniwa@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Add Mac Lion result after r138986.

  • platform/mac-lion/platform/mac/fast/text/vertical-no-sideways-expected.txt: Added.
3:57 PM Changeset in webkit [139006] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Minor improvements to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=105353

Reviewed by Eric Carlson.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::canPlayType):
(WebCore::createFileURLForApplicationCacheResource):
(WebCore::stringForNetworkState):
(WebCore::HTMLMediaElement::preload):
(WebCore::HTMLMediaElement::getPluginProxyParams):
Use ASCIILiteral for literal strings becoming WTFStrings.

(WebCore::HTMLMediaElement::setLoop):
By going through setAttribute, parseAttribute would already take care of
updating the disable sleep, so the call here is not needed.

3:57 PM Changeset in webkit [139005] by Joseph Pecoraro
  • 4 edits in trunk/Source/WebCore

String improvements in geolocation and notifications modules
https://bugs.webkit.org/show_bug.cgi?id=105352

Reviewed by Sam Weinig.

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::GeoNotifier::timerFired):
(WebCore::Geolocation::startRequest):
(WebCore::Geolocation::requestUsesCachedPosition):
(WebCore::Geolocation::makeCachedPositionCallbacks):
(WebCore::Geolocation::setIsAllowed):
(WebCore::Geolocation::cancelRequests):
(WebCore::Geolocation::handlePendingPermissionNotifiers):

  • Modules/geolocation/GeolocationController.cpp:

(WebCore::GeolocationController::positionChanged):

  • Modules/notifications/WorkerContextNotifications.cpp:

Use ASCIILiteral for constant strings becoming WTFStrings.

(WebCore::WorkerContextNotifications::from):
Use AtomicString::ConstructFromLiteral for the static local.

3:49 PM Changeset in webkit [139004] by fpizlo@apple.com
  • 10 edits in trunk/Source

Unreviewed, it should be possible to build JSC on ARM.

Source/JavaScriptCore:

  • API/JSBase.h:
  • jit/JITStubs.cpp:

(JSC::performPlatformSpecificJITAssertions):
(JSC):

  • jit/JITStubs.h:

(JSC):

  • jit/JITThunks.cpp:

(JSC::JITThunks::JITThunks):

  • jit/JITThunks.h:

(JITThunks):

  • offlineasm/armv7.rb:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

Source/WTF:

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::IncrementalScavenge):

3:35 PM Changeset in webkit [139003] by andersca@apple.com
  • 1 edit
    76 deletes in trunk/Source/WebKit2

Remove Windows files from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=106264

Reviewed by Sam Weinig.

  • Platform/CoreIPC/win/BinarySemaphoreWin.cpp: Removed.
  • Platform/CoreIPC/win/ConnectionWin.cpp: Removed.
  • Platform/win/ModuleWin.cpp: Removed.
  • Platform/win/SharedMemoryWin.cpp: Removed.
  • Platform/win/WorkQueueWin.cpp: Removed.
  • Shared/API/c/win/WKBaseWin.h: Removed.
  • Shared/API/c/win/WKCertificateInfoWin.cpp: Removed.
  • Shared/API/c/win/WKCertificateInfoWin.h: Removed.
  • Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp: Removed.
  • Shared/cg/win/ShareableBitmapCGWin.cpp: Removed.
  • Shared/win/CoalescedWindowGeometriesUpdater.cpp: Removed.
  • Shared/win/CoalescedWindowGeometriesUpdater.h: Removed.
  • Shared/win/CommandLineWin.cpp: Removed.
  • Shared/win/LayerTreeContextWin.cpp: Removed.
  • Shared/win/NativeWebKeyboardEventWin.cpp: Removed.
  • Shared/win/NativeWebMouseEventWin.cpp: Removed.
  • Shared/win/NativeWebWheelEventWin.cpp: Removed.
  • Shared/win/PlatformCertificateInfo.cpp: Removed.
  • Shared/win/PlatformCertificateInfo.h: Removed.
  • Shared/win/ShareableBitmapWin.cpp: Removed.
  • Shared/win/WebCoreArgumentCodersWin.cpp: Removed.
  • Shared/win/WebEventFactory.cpp: Removed.
  • Shared/win/WebEventFactory.h: Removed.
  • Shared/win/WebKitBundle.cpp: Removed.
  • Shared/win/WebKitBundle.h: Removed.
  • Shared/win/WebURLRequestWin.cpp: Removed.
  • Shared/win/WebURLResponseWin.cpp: Removed.
  • Shared/win/WindowGeometry.cpp: Removed.
  • Shared/win/WindowGeometry.h: Removed.
  • UIProcess/API/C/win/WKAPICastWin.h: Removed.
  • UIProcess/API/C/win/WKContextPrivateWin.h: Removed.
  • UIProcess/API/C/win/WKContextWin.cpp: Removed.
  • UIProcess/API/C/win/WKView.cpp: Removed.
  • UIProcess/API/C/win/WKView.h: Removed.
  • UIProcess/API/C/win/WKViewPrivate.cpp: Removed.
  • UIProcess/API/C/win/WKViewPrivate.h: Removed.
  • UIProcess/Launcher/win/ProcessLauncherWin.cpp: Removed.
  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp: Removed.
  • UIProcess/win/BackingStoreWin.cpp: Removed.
  • UIProcess/win/TextCheckerWin.cpp: Removed.
  • UIProcess/win/WebContextMenuProxyWin.cpp: Removed.
  • UIProcess/win/WebContextMenuProxyWin.h: Removed.
  • UIProcess/win/WebContextWin.cpp: Removed.
  • UIProcess/win/WebFullScreenManagerProxyWin.cpp: Removed.
  • UIProcess/win/WebInspectorProxyWin.cpp: Removed.
  • UIProcess/win/WebPageProxyWin.cpp: Removed.
  • UIProcess/win/WebPopupMenuProxyWin.cpp: Removed.
  • UIProcess/win/WebPopupMenuProxyWin.h: Removed.
  • UIProcess/win/WebProcessProxyWin.cpp: Removed.
  • UIProcess/win/WebUndoClient.cpp: Removed.
  • UIProcess/win/WebUndoClient.h: Removed.
  • UIProcess/win/WebView.cpp: Removed.
  • UIProcess/win/WebView.h: Removed.
  • WebProcess/Downloads/cf/win/DownloadCFWin.cpp: Removed.
  • WebProcess/InjectedBundle/API/c/win/WKBundlePrivateWin.cpp: Removed.
  • WebProcess/InjectedBundle/API/c/win/WKBundlePrivateWin.h: Removed.
  • WebProcess/InjectedBundle/win/InjectedBundleWin.cpp: Removed.
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp: Removed.
  • WebProcess/WebCoreSupport/win/WebContextMenuClientWin.cpp: Removed.
  • WebProcess/WebCoreSupport/win/WebDragClientWin.cpp: Removed.
  • WebProcess/WebCoreSupport/win/WebDragSource.cpp: Removed.
  • WebProcess/WebCoreSupport/win/WebDragSource.h: Removed.
  • WebProcess/WebCoreSupport/win/WebErrorsWin.cpp: Removed.
  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.cpp: Removed.
  • WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h: Removed.
  • WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp: Removed.
  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp: Removed.
  • WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h: Removed.
  • WebProcess/WebPage/ca/win/WKCACFViewWindow.cpp: Removed.
  • WebProcess/WebPage/ca/win/WKCACFViewWindow.h: Removed.
  • WebProcess/WebPage/win/DrawingAreaImplWin.cpp: Removed.
  • WebProcess/WebPage/win/LayerTreeHostWin.cpp: Removed.
  • WebProcess/WebPage/win/WebInspectorWin.cpp: Removed.
  • WebProcess/WebPage/win/WebPageWin.cpp: Removed.
  • WebProcess/win/WebProcessMainWin.cpp: Removed.
  • WebProcess/win/WebProcessWin.cpp: Removed.
3:32 PM Changeset in webkit [139002] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: the text of render counters are not exposed to Accessibility
https://bugs.webkit.org/show_bug.cgi?id=103794

Reviewed by Ryosuke Niwa.

Source/WebCore:

Support RenderText objects that don't have nodes (like RenderCounter).

Test: accessibility/render-counter-text.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement):

LayoutTests:

  • accessibility/render-counter-text-expected.txt: Added.
  • accessibility/render-counter-text.html: Added.
3:29 PM Changeset in webkit [139001] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebKit/qt

[qt] Fix ENABLE_IFRAME_SEAMLESS=0 builds.
https://bugs.webkit.org/show_bug.cgi?id=106252

Reviewed by Eric Seidel.

Wrap the call to setSeamlessIFramesEnabled in an ifdef in order
to ensure that it's only called when IFRAME_SEAMLESS is enabled.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setSeamlessIFramesEnabled):

3:26 PM Changeset in webkit [139000] by mitz@apple.com
  • 7 edits
    1 add in trunk

[mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
https://bugs.webkit.org/show_bug.cgi?id=106261

Reviewed by Simon Fraser.

Source/WebKit/mac:

Test: TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm.

Added -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::detachedFromParent2): Added a call to the new frame load delegate
method.

  • WebView/WebDelegateImplementationCaching.h:

(WebFrameLoadDelegateImplementationCache): Added the new method to the cache.

  • WebView/WebFrameLoadDelegatePrivate.h: Declared the new delegate method.
  • WebView/WebView.mm:

(-[WebView _cacheFrameLoadDelegateImplementations]): Added the new method to the cache.

Tools:

Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.

(-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
(-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

3:23 PM Changeset in webkit [138999] by Lucas Forschler
  • 5 edits in tags/Safari-537.24.2/Source/WebCore

Merged r138997.

3:18 PM Changeset in webkit [138998] by Lucas Forschler
  • 2 edits
    1 copy
    1 delete in branches/safari-536.28-branch/LayoutTests

Merged r125813.

3:17 PM Changeset in webkit [138997] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebCore

Tiled-layer TileCaches shouldn't unparent offscreen tiles
https://bugs.webkit.org/show_bug.cgi?id=106258
<rdar://problem/12969116>

Reviewed by Simon Fraser.

Add a setting on TiledBacking (implemented on TileCache) that controls whether or not
the TileCache should unparent offscreen tiles. We can't use this behavior for tiled-layer TileCaches
currently because m_isInWindow is not updated for tiled-layer TileCaches, and because we haven't
decided exactly what their behavior should be. So, revert to the old behavior for them.

  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/mac/TileCache.h:

(TileCache): Add setUnparentsOffscreenTiles/unparentsOffscreenTiles.

  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::TileCache): m_unparentsOffscreenTiles defaults to false.
(WebCore::TileCache::revalidateTiles):
Return to the old behavior of always adding new layers to the layer tree regardless of m_isInWindow if m_unparentsOffscreenTiles is false.
Return to the old behavior of never unparenting tiles regardless of m_isInWindow if m_unparentsOffscreenTiles is false.
(WebCore::TileCache::ensureTilesForRect): Return to the old behavior of always ensuring tiles regardless of m_isInWindow if m_unparentsOffscreen$

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking): Tell primary TileCaches that it's OK to unparent offscreen tiles.

3:04 PM Changeset in webkit [138996] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

A couple more rebaselines for http://trac.webkit.org/changeset/138838.

  • platform/mac/fast/table/038-vertical-expected.txt:
  • platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:
2:59 PM Changeset in webkit [138995] by ojan@chromium.org
  • 2 edits in trunk/Tools

Add the Apple MountainLion bots to garden-o-matic.
Eventually, we really should move away from hardcoding
the list of bots.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2:56 PM Changeset in webkit [138994] by junov@google.com
  • 3 edits
    2 adds in trunk

Fixing memory read after free in CanvasRenderingContext2D::accessFont
https://bugs.webkit.org/show_bug.cgi?id=106244

Reviewed by Abhishek Arya.

Source/WebCore:

Using a temporary String object to hold ref count on string that is
passed by reference in CanvasRenderingContext2D::accessFont.

Test: fast/canvas/canvas-measureText.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::accessFont):

LayoutTests:

New test case to verify stability of 2D canvas method measureText.
Test case was causing a DumpRenderTree crash on builds with
AddressSantitizer instrumentation.

  • fast/canvas/canvas-measureText-expected.txt: Added.
  • fast/canvas/canvas-measureText.html: Added.
2:52 PM Changeset in webkit [138993] by jochen@chromium.org
  • 7 edits in trunk/Tools

[chromium] move web audio related methods to testrunner library
https://bugs.webkit.org/show_bug.cgi?id=106211

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebKit):
(WebTestRunner::WebTestRunner::shouldDumpAsAudio):
(WebTestRunner::WebTestRunner::audioData):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::shouldDumpAsAudio):
(WebTestRunner):
(WebTestRunner::TestRunner::audioData):
(WebTestRunner::TestRunner::setAudioData):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::dump):

2:24 PM Changeset in webkit [138992] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

DOMEvents.h should include DOMProgressEvent.h
https://bugs.webkit.org/show_bug.cgi?id=106250

Reviewed by Sam Weinig.

DOMProgressEvent.h is already installed as a public header, so it should also be included by DOMEvents.h.

  • bindings/objc/DOMEvents.h:
2:12 PM Changeset in webkit [138991] by wangxianzhu@chromium.org
  • 13 edits in trunk

Add window.internals.nonFastScrollableRects for testing scrollable areas in fast/slow paths
https://bugs.webkit.org/show_bug.cgi?id=105546

Reviewed by James Robinson.

.:

Export the new symbol.

  • Source/autotools/symbols.filter:

Source/WebCore:

No new tests. Added test API for new tests of other bugs.

  • WebCore.exp.in:
  • page/Page.cpp:

(WebCore::Page::nonFastScrollableRects):
(WebCore):

  • page/Page.h:

(WebCore):
(Page):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion): Change to public to allow Page::nonFastScrollableRects to access.

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

  • testing/Internals.cpp:

(WebCore::Internals::nonFastScrollableRects):
(WebCore):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

Export the new symbol.

  • win/WebKit2.def.in:
2:10 PM Changeset in webkit [138990] by tsepez@chromium.org
  • 2 edits in trunk/Source/WebCore

Document::initSecurityContext() gives parent security context to iframes with invalid URLs.
https://bugs.webkit.org/show_bug.cgi?id=104960

Reviewed by Adam Barth.

Change covers the case of an invalid non-empty URL. We know nothing
about that kind of URL and choose not to inherit origins.

  • dom/Document.cpp:

(WebCore::shouldInheritSecurityOriginFromOwner):

2:09 PM Changeset in webkit [138989] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: Regression: Contextual menu not following with VO cursor in HTML content when item is scrolled
https://bugs.webkit.org/show_bug.cgi?id=70075

Reviewed by Anders Carlsson.

On WK2 only, when accessibility opens a contextual menu, it does not honor the scroll offset.
On WK1, the attachment views handle this conversion when it's needed, but on WK2 it needs to be done manually
(similar to how the accessibility position is calculated).

No test. Cannot test the location of context menu popups on WK2 yet.

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityShowContextMenu]):

2:07 PM Changeset in webkit [138988] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Heap-buffer-overflow in WebCore::RenderBlock::clone.
https://bugs.webkit.org/show_bug.cgi?id=101984

Reviewed by Julien Chaffraix.

Source/WebCore:

Add a global in RenderBlock to prevent recursion inside splitFlow.
While inside splitFlow (multi-column handling), we move many children
using fullRemoveInsert=true, causing RenderBlock::addChild to be called
and recursing in splitFlow. This messes the tree splitting happening in
RenderBlock::splitBlocks and can cause bad casts.

Test: fast/multicol/recursive-split-flow-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):

LayoutTests:

  • fast/multicol/recursive-split-flow-crash-expected.txt: Added.
  • fast/multicol/recursive-split-flow-crash.html: Added.
2:05 PM Changeset in webkit [138987] by alokp@chromium.org
  • 9 edits in trunk/Source

[chromium] Fix PlatformContextSkia::setDrawingToImageBuffer abuse
https://bugs.webkit.org/show_bug.cgi?id=104956

Reviewed by James Robinson.

Replaced PlatformContextSkia::SetDrawingToImageBuffer with GraphicsContext::setShouldSmoothFonts.

Source/WebCore:

No new tests needed. No change in functionality.

  • platform/graphics/chromium/CompositorHUDFontAtlas.cpp:

(WebCore::CompositorHUDFontAtlas::generateFontAtlas):

  • platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:

(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::ImageBuffer):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::couldUseLCDRenderedText):
(WebCore):

Source/WebKit/chromium:

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::paintContents):
(WebKit):
(WebKit::NonCompositedContentHost::setShowDebugBorders):

  • src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::paint):

  • src/WebFontImpl.cpp:

(WebKit::WebFontImpl::drawText):

2:03 PM Changeset in webkit [138986] by enrica@apple.com
  • 4 edits
    2 adds in trunk

Some characters are not rotated properly in vertical text
https://bugs.webkit.org/show_bug.cgi?id=105663
<rdar://problem/12738911>

Source/WebCore:

Reviewed by Dan Bernstein.

Test: platform/mac/fast/text/vertical-no-sideways.html

  • platform/graphics/Font.cpp:

(WebCore::Font::isCJKIdeographOrSymbol): Added several characters to the list.

  • platform/graphics/FontFastPath.cpp:

(WebCore::shouldIgnoreRotation): Added
(WebCore::Font::glyphDataAndPageForNonCJKCharacterWithGlyphOrientation): Added logic to avoid
rotation for all the characters listed in shouldIgnoreRotation.

LayoutTests:

Reviewed by Dan Bernstein.

  • platform/mac/fast/text/vertical-no-sideways.html: Added.
  • platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt: Added.
2:02 PM Changeset in webkit [138985] by leviw@chromium.org
  • 3 edits
    3 adds
    1 delete in trunk/LayoutTests

Unreviewed gardening. Updating test expectations following r138717.

  • platform/chromium-linux/platform/chromium/fast/events/touch: Removed.
  • platform/chromium-linux/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt: Removed.
  • platform/chromium-mac/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt:
  • platform/chromium-win-xp/platform/chromium/fast/events: Added.
  • platform/chromium-win-xp/platform/chromium/fast/events/touch: Added.
  • platform/chromium-win-xp/platform/chromium/fast/events/touch/compositor-touch-hit-rects-expected.txt: Added.
  • platform/chromium/TestExpectations:
1:47 PM Changeset in webkit [138984] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] fast/speech/scripted/navigate-away.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=106249

  • platform/chromium/TestExpectations: Marked as flaky.
1:45 PM Changeset in webkit [138983] by mkwst@chromium.org
  • 35 edits in trunk

Make the IFRAME_SEAMLESS flag runtime-enabled.
https://bugs.webkit.org/show_bug.cgi?id=106213

Reviewed by Ojan Vafai.

Source/WebCore:

Seamless IFrames live behind the IFRAME_SEAMLESS compile-time flag, this
patch adds another layer to that in order to enable runtime decisions
about when it should be active. This will allow ports (Chromium, for
instance) to toggle the feature on/off for particular builds without
recompiling from scratch.

  • WebCore.exp.in:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::seamlessIFramesEnabled):
(WebCore::RuntimeEnabledFeatures::setSeamlessIFramesEnabled):

Add seamless IFrames to the set of runtime controlled features.

  • dom/Document.cpp:

(WebCore::Document::shouldDisplaySeamlesslyWithParent):

If seamless IFrames aren't runtime enabled, always return false from
Document::shouldDisplaySeamlesslyWithParent. As this method already
acts as the single gate that controls the rest of the system, it's
the only place we need to make the runtime check.

Source/WebKit/chromium:

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableSeamlessIFrames):
(WebKit):
(WebKit::WebRuntimeFeatures::areSeamlessIFramesEnabled):

Expose the new runtime feature to the Chromium port.

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setSeamlessIFramesEnabled):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:
  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

Add a toggle for seamless IFrames to EFL's DRTSuport.

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Add a toggle for seamless IFrames to GTK's DRTSuport.

Source/WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(-[WebPreferences seamlessIFramesEnabled]):
(-[WebPreferences setSeamlessIFramesEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Add a seamless IFrame preference to WebPreferences, and use it to
toggle the runtime state of the feature as appropriate.

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setSeamlessIFramesEnabled):

  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Add a toggle for seamless IFrames to QT's DRTSuport.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetSeamlessIFramesEnabled):

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setSeamlessIFramesEnabled):
(WebKit):

  • WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Add a toggle for seamless IFrames to InjectedBundle, and set it to
true when beginning testing.

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

Ensure that seamless IFrames are enabled for layout tests in each of
the ports that support seamless IFrames.

1:34 PM Changeset in webkit [138982] by ap@apple.com
  • 4 edits in trunk/Source/WebKit2

[WK2] Remove more obsolete shim code
https://bugs.webkit.org/show_bug.cgi?id=106248

Reviewed by Anders Carlsson.

Removing KeychainItemShimCallbacks, and SecItemRequestData::CopyContent, which was
only needed for that obsolete version of shim.

We now use WebProcessSecItemShimCallbacks.

  • Shared/mac/SecItemRequestData.h:
  • UIProcess/mac/WebProcessProxyMac.mm: (WebKit::handleSecItemRequest):
  • WebProcess/mac/WebProcessShim.h:
1:26 PM Changeset in webkit [138981] by weinig@apple.com
  • 9 edits
    1 copy
    1 add in trunk/Source/WebKit2

Merge child process main functions as much as possible
https://bugs.webkit.org/show_bug.cgi?id=106192

Reviewed by Anders Carlsson.

To reduce copied code, this merges the Mac main functions for the WebProcess,
NetworkProcess, PluginProcess, and SharedWorkerProcess. Since slight variations
are needed, it adds a delegate class for hooks into the main function that each
process can override if necessary.

  • NetworkProcess/mac/NetworkProcessMainMac.mm:

(WebKit::NetworkProcessMain):
Remove almost everything with a call to ChildProcessMain with the default delegate.

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::platformInitializeProcess):
Move defaults registration here from PluginProcessMainMac.

  • PluginProcess/mac/PluginProcessMainMac.mm:

(PluginProcessMainDelegate):
Add a delegate for the new shared main function that does does PluginProcess
specific work.

(WebKit::PluginProcessMainDelegate::doPreInitializationWork):
Move DYLD_INSERT_LIBRARIES removal and createPluginMIMETypesPreferences special mode
to this pre-initialization hook.

(WebKit::PluginProcessMainDelegate::doPostRunWork):
Move private temporary and cache directories clean up to this post run hook.

(WebKit::PluginProcessMain):
Call the ChildProcessMain shared main function with the PluginProcess as the process
to initialize and PluginProcessMainDelegate as the main delegate.

  • Shared/mac/ChildProcessMain.h: Added.

(ChildProcessMainDelegate):
ChildProcessMainDelegate is a helper class that process can subclass to hook into
the main function.

(WebKit::ChildProcessMain):
Add a single version of the "main" function that uses the ChildProcessMainDelegate to
allow processes to hook into it.

  • Shared/mac/ChildProcessMain.mm:

(WebKit::ChildProcessMainDelegate::~ChildProcessMainDelegate):
(WebKit::ChildProcessMainDelegate::installSignalHandlers):
(WebKit::ChildProcessMainDelegate::doPreInitializationWork):
(WebKit::ChildProcessMainDelegate::getConnectionIdentifier):
(WebKit::ChildProcessMainDelegate::getClientIdentifier):
(WebKit::ChildProcessMainDelegate::getClientProcessName):
(WebKit::ChildProcessMainDelegate::doPostRunWork):
Add default implementations of the delegate hooks, most processes should be able to
use the defaults.

  • SharedWorkerProcess/mac/SharedWorkerProcessMainMac.mm:

(WebKit::SharedWorkerProcessMain):
Remove almost everything with a call to ChildProcessMain with the default delegate.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/mac/WebProcessMainMac.mm:

(WebProcessMainDelegate):
Add a delegate for the new shared main function that does does WebProcess
specific work.

(WebKit::WebProcessMainDelegate::doPreInitializationWork):
Move DYLD_INSERT_LIBRARIES removal to this this pre-initialization hook.

(WebKit::WebProcessMainDelegate::getConnectionIdentifier):
A custom getConnectionIdentifier is necessary for the WebProcess to keep support for having the WebProcess
be able to launch the UIProcess (for debugging purposes).

(WebKit::WebProcessMainDelegate::getClientIdentifier):
For the same reasons as about, a custom getClientIdentifier is needed.

(WebKit::WebProcessMain):
Call the ChildProcessMain shared main function with the WebProcess as the process
to initialize and WebProcessMainDelegate as the main delegate.

1:21 PM Changeset in webkit [138980] by jochen@chromium.org
  • 6 edits in trunk/Tools

[chromium] move dumpAsText and friends to the TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=106222

Reviewed by Adam Barth.

This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner::WebTestRunner::shouldDumpAsText):
(WebTestRunner::WebTestRunner::setShouldDumpAsText):
(WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
(WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
(WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
(WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::shouldDumpAsText):
(WebTestRunner):
(WebTestRunner::TestRunner::setShouldDumpAsText):
(WebTestRunner::TestRunner::shouldGeneratePixelResults):
(WebTestRunner::TestRunner::setShouldGeneratePixelResults):
(WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions):
(WebTestRunner::TestRunner::shouldDumpChildFramesAsText):
(WebTestRunner::TestRunner::dumpAsText):
(WebTestRunner::TestRunner::dumpChildFrameScrollPositions):
(WebTestRunner::TestRunner::dumpChildFramesAsText):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

12:58 PM Changeset in webkit [138979] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Touch Events are falling through fullscreen video
https://bugs.webkit.org/show_bug.cgi?id=106112

Patch by Genevieve Mak <gmak@rim.com> on 2013-01-07
Reviewed by Rob Buis.

Reviewed Internally by Jakob Petsovits.
PR #274326
Do not do viewport centering calculations if in fullscreen video.
The offset should be zero.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

12:53 PM Changeset in webkit [138978] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

LayoutUnit(unsigned long long value) compile failure
https://bugs.webkit.org/show_bug.cgi?id=106239

Cast the result of ('unsigned long long' * 'int') to an int before storing in m_value
to avoid compile failure on some platforms.

Reviewed by Ryosuke Niwa.

  • platform/LayoutUnit.h:

(WebCore::LayoutUnit::LayoutUnit): Cast to int after multiplication.

12:47 PM Changeset in webkit [138977] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Handle the new AuthRetry result code in NetworkJob::notifyAuthReceived
https://bugs.webkit.org/show_bug.cgi?id=106233

Patch by Joe Mason <jmason@rim.com> on 2013-01-07
Reviewed by Rob Buis.

Internal PR: 270683
FilterStream::notifyAuthReceived has a new result code, AuthRetry. When it's received we
need to handle it by resending the request with the same credentials.

Reviewed internally by Leo Yang.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::notifyAuthReceived):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

12:33 PM Changeset in webkit [138976] by pdr@google.com
  • 2 edits in trunk/Source/WebCore

Clear pending container size requests as early as possible
https://bugs.webkit.org/show_bug.cgi?id=106162

Reviewed by Eric Seidel.

http://trac.webkit.org/changeset/137981 contained a bug where pending container size
requests were only cleared for images that use container sizes. Bitmap images do not use
container sizes so these requests were not being cleared. This patch does the trivial
refactoring so that container size requests are cleared as early as possible.

No new tests as this is just a refactoring of some messy code added in r137981.

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::createImage):

12:23 PM Changeset in webkit [138975] by Dimitri Glazkov
  • 1 edit
    1 move in trunk/LayoutTests

[Chromium] Rebaseline webaudio/realtimeanalyser-fft-sizing.html.

  • platform/chromium-win/webaudio/realtimeanalyser-fft-sizing-expected.txt: Renamed from LayoutTests/platform/chromium-win-xp/webaudio/realtimeanalyser-fft-sizing-expected.txt.
11:52 AM Changeset in webkit [138974] by inferno@chromium.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r137632.
http://trac.webkit.org/changeset/137632
https://bugs.webkit.org/show_bug.cgi?id=106237

Caused major security regressions on ClusterFuzz (Requested by
inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-07

Source/WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::startDelayUpdateScrollInfo):
(WebCore::RenderBlock::finishDelayUpdateScrollInfo):

LayoutTests:

  • mathml/mo-stretch-crash-expected.txt: Removed.
  • mathml/mo-stretch-crash.html: Removed.
11:52 AM Changeset in webkit [138973] by Simon Fraser
  • 12 edits in trunk/Source/WebKit2

Make WKViews work when layer-backed
https://bugs.webkit.org/show_bug.cgi?id=106166

Reviewed by Sam Weinig.

When not in TileCache mode, WebKit2 views had redraw problems on scrolling,
if layer-backed.

The issue is that the DrawingAreaProxy code tries to optimize scrolling by
calling -scrollRect:by: on the WKView (an NSView) to copy bits, rather than
repainting the entire view. However, -scrollRect:by: does nothing for NSViews
that have layers.

Fix by plumbing through a canScrollView() function which PageClientImpl()
implements, returning true if the view does not have layer backing.
When canScrollView() is false, DrawingAreaProxyImpl::incorporateUpdate()
dirties the entire view.

  • UIProcess/API/gtk/PageClientImpl.h:

(WebKit::PageClientImpl::canScrollView):

  • UIProcess/API/mac/PageClientImpl.h:

(PageClientImpl):

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::canScrollView):

  • UIProcess/API/qt/raw/qrawwebview_p_p.h:

(QRawWebViewPrivate::canScrollView):

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::incorporateUpdate):

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::canScrollView):

  • UIProcess/WebPageProxy.h:
  • UIProcess/efl/PageClientBase.h:

(WebKit::PageClientBase::canScrollView):

  • UIProcess/qt/QtPageClient.h:

(WebKit::QtPageClient::canScrollView):

  • UIProcess/win/WebView.h:

(WebKit::WebView::canScrollView):

11:44 AM Changeset in webkit [138972] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Rebaseline svg/W3C-SVG-1.1/paths-data-03-f.svg.

  • platform/chromium-win/svg/W3C-SVG-1.1/paths-data-03-f-expected.png: Updated expectation.
11:41 AM Changeset in webkit [138971] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Tests in svg/dynamic-updates are flaky..
https://bugs.webkit.org/show_bug.cgi?id=106238

  • platform/chromium/TestExpectations: Marked as flaky.
11:40 AM Changeset in webkit [138970] by commit-queue@webkit.org
  • 12 edits
    1 add in trunk/Source

MIPS LLInt implementation.
https://bugs.webkit.org/show_bug.cgi?id=99706

Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-01-07
Reviewed by Filip Pizlo.

LLInt implementation for MIPS.

Source/JavaScriptCore:

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::jump):

  • dfg/DFGOperations.cpp:

(JSC):

  • jit/JITStubs.cpp:

(JSC):

  • jit/JITStubs.h:

(JITStackFrame):

  • llint/LLIntOfflineAsmConfig.h:
  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • offlineasm/backends.rb:
  • offlineasm/instructions.rb:
  • offlineasm/mips.rb: Added.

Source/WTF:

  • wtf/Platform.h:
11:36 AM Changeset in webkit [138969] by inferno@chromium.org
  • 1 edit
    2 deletes in branches/chromium/1312

Revert 137759
Review URL: https://codereview.chromium.org/11784026

11:31 AM Changeset in webkit [138968] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Roll out r136173 as there are alternative approaches from the client sides now
https://bugs.webkit.org/show_bug.cgi?id=106236

Unreviewed, rolling out r136173.
This becomes unnecessary now as there are alternative approaches to
solve the issue from the client sides.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::createWindow):

11:24 AM Changeset in webkit [138967] by ojan@chromium.org
  • 20 edits
    2 copies
    1 move
    8 adds in trunk/LayoutTests

Rebaselines after http://trac.webkit.org/changeset/138838.

  • platform/chromium-mac-lion/fast/ruby/base-shorter-than-text-expected.txt:
  • platform/chromium-mac-lion/fast/table/038-vertical-expected.png:
  • platform/chromium-mac-lion/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/038-vertical-expected.png:
  • platform/chromium-mac-snowleopard/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/chromium-mac/fast/ruby/base-shorter-than-text-expected.txt:
  • platform/chromium-mac/fast/table/038-vertical-expected.png:
  • platform/chromium-mac/fast/table/038-vertical-expected.txt: Copied from LayoutTests/platform/chromium/fast/table/038-vertical-expected.txt.
  • platform/chromium-mac/fast/table/border-collapsing/004-vertical-expected.png:
  • platform/chromium-mac/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.txt:
  • platform/chromium-win-xp/fast/table/038-vertical-expected.png: Added.
  • platform/chromium-win-xp/fast/table/border-collapsing/004-vertical-expected.png: Added.
  • platform/chromium/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/ruby/base-shorter-than-text-expected.txt:
  • platform/gtk/fast/table/038-vertical-expected.txt:
  • platform/gtk/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/mac-lion/fast/table/038-vertical-expected.txt: Copied from LayoutTests/platform/chromium/fast/table/038-vertical-expected.txt.
  • platform/mac-lion/fast/table/border-collapsing/004-vertical-expected.txt: Added.
  • platform/mac-wk2/fast/table/038-vertical-expected.txt: Renamed from LayoutTests/platform/chromium/fast/table/038-vertical-expected.txt.
  • platform/mac-wk2/fast/table/border-collapsing/004-vertical-expected.txt: Added.
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/qt/fast/table/038-vertical-expected.txt:
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.txt:
11:21 AM Changeset in webkit [138966] by victor@rosedu.org
  • 3 edits
    2 adds in trunk

[Track] Rendering crash
https://bugs.webkit.org/show_bug.cgi?id=106199

Reviewed by Eric Carlson.

Source/WebCore:

The browser is crashing if a text track is added through JavaScript,
due to the fact that the containing block is not marked as inline at
the time RenderTextTrackCue::layout() is called. The fix consists
of ensuring that the pseudo id is set, even if the track isn't
yet visible.

Test: media/track/track-cue-inline-assertion-crash.html

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::updateDisplayTree): The pseudo-id should
be set when the display tree is generated.
(WebCore::TextTrackCue::getDisplayTree): Added extra check to not
do unneccessary logic if the track will never be displayed.

LayoutTests:

  • media/track/track-cue-inline-assertion-crash-expected.txt: Added.
  • media/track/track-cue-inline-assertion-crash.html: Added.
11:04 AM Changeset in webkit [138965] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix attempt after r138810.

Apparently python 2.6 is really bad at floating point computation.

  • Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:

(MainTest.test_run_memory_test):

11:03 AM Changeset in webkit [138964] by commit-queue@webkit.org
  • 8 edits in trunk

[JSC] Copy non-index properties of arrays in SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=105575

Patch by Michael Pruett <michael@68k.org> on 2013-01-07
Reviewed by Oliver Hunt.

The structured cloning algorithm requires copying all properties of
array objects, including non-index properties.

Source/WebCore:

Tests: fast/storage/serialized-script-value.html

storage/indexeddb/structured-clone.html

  • bindings/js/SerializedScriptValue.cpp:

(WebCore):
(WebCore::CloneSerializer::serialize):
(WebCore::CloneDeserializer::putProperty):
(WebCore::CloneDeserializer::deserialize):

LayoutTests:

  • fast/storage/resources/serialized-script-value.js:
  • fast/storage/serialized-script-value-expected.txt:
  • fast/storage/serialized-script-value.html:
  • platform/chromium/fast/storage/serialized-script-value-expected.txt:
  • platform/chromium/fast/storage/serialized-script-value.html:
10:53 AM Changeset in webkit [138963] by alecflett@chromium.org
  • 10 edits in trunk/Source

IndexedDB: Stub out async IDBDatabaseBackendInterface::createObjectStore
https://bugs.webkit.org/show_bug.cgi?id=106148

Reviewed by Adam Barth.

Source/WebCore:

These methods are becoming async in multiprocess ports, so stub out
versions that have no return values.

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

Source/WebKit/chromium:

Stub out WebKit API for async createObjectStore.

  • public/WebIDBDatabase.h:

(WebIDBDatabase):

  • src/IDBDatabaseBackendProxy.cpp:

(WebKit::IDBDatabaseBackendProxy::createObjectStore):
(WebKit):
(WebKit::IDBDatabaseBackendProxy::deleteObjectStore):

  • src/IDBDatabaseBackendProxy.h:

(IDBDatabaseBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::createObjectStore):
(WebKit):
(WebKit::WebIDBDatabaseImpl::deleteObjectStore):

  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

10:40 AM Changeset in webkit [138962] by ap@apple.com
  • 15 edits in trunk/Source/WebCore

ResourceHandle::willLoadFromCache is evil
https://bugs.webkit.org/show_bug.cgi?id=106147

Reviewed by Brady Eidson.

For back/forward navigations to a page that's a result of form submission, we may
never silently re-submit the form. So, we show a warning dialog when about to re-submit,
but try to load from cache if possible.

This patch changes the logic so that we always try to fetch from cache, without
any preflighting. If cache load fails, we restart the load as a known re-submit.

No behavior change expected, so no tests.

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::handleClick): Added a FIXME.
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::startLoadingMainResource): Amended a FIXME with some information about why this call may still be needed.
  • loader/FrameLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadURLIntoChildFrame): Pass an explicit argument for unchanged caching behavior. (WebCore::FrameLoader::reloadWithOverrideEncoding): Added a FIXME. This function can silently re-submit a form. (WebCore::FrameLoader::addExtraFieldsToMainResourceRequest): Added a FIXME about an incorrect use of current load type. (WebCore::FrameLoader::addExtraFieldsToRequest): Make sure that a correct caching policy is used for subresources even if main resource was loaded from cache. We didn't need that before because initial request had wrong extra fields due to a use of m_loadType when it was first called. Removed code to change caching policy for b/f navigations. This function does not have enough context to decide what the policy should be. (WebCore::FrameLoader::loadDifferentDocumentItem): Added an argument telling the function whether it should attempt loading from cache. It should do that on first attempt to navigate to a form submission result, but not if that failed. Pass a correct loadType - m_loadType is one for _previous_ load. Removed a special case for https - we've long stopped prohibiting caching of https resources, and using a resource that's already cached should definitely be allowed. (WebCore::FrameLoader::loadItem): Pass an explicit argument for unchanged caching behavior. (WebCore::FrameLoader::retryAfterFailedCacheOnlyMainResourceLoad): Added.
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::notifyFinished): Removed a check for m_resource being null, because we were immediately dereferencing it anyway. Call retryAfterFailedCacheOnlyMainResourceLoad() to let FrameLoader restart the navigation.
  • platform/network/ResourceHandle.h:
  • platform/network/blackberry/ResourceHandleBlackBerry.cpp:
  • platform/network/cf/ResourceHandleCFNet.cpp:
  • platform/network/chromium/ResourceHandle.cpp:
  • platform/network/curl/ResourceHandleCurl.cpp:
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/network/qt/ResourceHandleQt.cpp:
  • platform/network/soup/ResourceHandleSoup.cpp:
  • platform/network/win/ResourceHandleWin.cpp: Removed willLoadFromCache() - the new logic is cross-platform.
10:36 AM Changeset in webkit [138961] by mihnea@adobe.com
  • 2 edits
    1 add
    13 deletes in trunk/LayoutTests

[CSS Regions] LayoutTests/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl.html has repainting issues
https://bugs.webkit.org/show_bug.cgi?id=97208

Reviewed by Tony Chang.

Following the fix for https://bugs.webkit.org/show_bug.cgi?id=105893, i converted this to a ref test.
Used a defined monospace font for similar results on all platforms.

  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.html: Added.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Removed.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl.html:
  • platform/chromium-linux/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Removed.
  • platform/chromium-mac-lion/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Removed.
  • platform/chromium-mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Removed.
  • platform/chromium-win/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Removed.
  • platform/chromium-win/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Removed.
  • platform/chromium/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Removed.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Removed.
  • platform/gtk/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Removed.
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Removed.
  • platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Removed.
  • platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Removed.
  • platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Removed.
10:34 AM Changeset in webkit [138960] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Disable deprecation warnings for GStaticRecMutex
https://bugs.webkit.org/show_bug.cgi?id=105918

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-01-07
Reviewed by Philippe Normand.

GStaticRecMutex is deprecated since glib 2.32, but we can't remove
it because it's needed by GStreamer 0.10. The solution is to
disable the deprecation warnings for that code alone.

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
10:33 AM Changeset in webkit [138959] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Marked WebAudio tests that are failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=106232

  • platform/chromium/TestExpectations: Marked.
10:32 AM Changeset in webkit [138958] by pdr@google.com
  • 2 edits in trunk/Source/WebCore

Refactor client removal in CachedResource::switchClientsToRevalidatedResource
https://bugs.webkit.org/show_bug.cgi?id=106206

Previously switchClientsToRevalidatedResource() failed to call didRemoveClient() for each
client and instead simply cleared m_clients. This patch removes an incorrect comment and
refactors the code so that removeClient() and didRemoveClient() are properly called.

Reviewed by Nate Chapin.

No new tests as there are no observable changes from this refactoring.

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::switchClientsToRevalidatedResource):

10:31 AM Changeset in webkit [138957] by mhahnenberg@apple.com
  • 2 edits
    1 move in trunk/Source/JavaScriptCore

testapi is failing with a block-related error in the Objc API
https://bugs.webkit.org/show_bug.cgi?id=106055

Reviewed by Geoffrey Garen.

Casting a block to a bool will always return true, which isn't the behavior that is intended here.
Instead we need to call the block, but C semantics don't allow this, so we need to change
testapi.m to be Objective-C++ and therefore testapi.mm.

  • API/tests/testapi.m: Removed.
  • API/tests/testapi.mm: Copied from Source/JavaScriptCore/API/tests/testapi.m.

(blockSignatureContainsClass):

10:28 AM Changeset in webkit [138956] by jpetsovits@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Never avoid blitting when one-shot drawing sync is involved.
https://bugs.webkit.org/show_bug.cgi?id=106225
RIM PR 274948

Reviewed by George Staikos.
Based on a patch by Chris Guan.

didRenderContent() has a mechanism to avoid double blits;
when scrolling or zooming is enabled then we don't issue
blitContents() as the client would (continually) do that
already.

However, since r138024, didRenderContents() also deals
with one-shot drawing synchronization and commits.
When these are required, we can't just skip out or the
backingstore and overlaying composited layers are likely
to get out of sync. The condition also doesn't make much
sense for direct rendering as no blit calls are issued
at all when it is enabled.

Fix the issue by limiting the impact of the scroll/zoom
early return to only regular blit operations.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::didRenderContent):

10:28 AM Changeset in webkit [138955] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver
https://bugs.webkit.org/show_bug.cgi?id=106172

Reviewed by Tony Chang.

Extracted PerfTestMetric, which represents a test result and knows how to compute statistics and convert itself
to a dictionary. A metric is a type of measurement each test makes such as "Time", "Malloc", and "JSHeap".
A single test (e.g. html5-full-render.html) may have multiple metrics, each of which is reported as a separate
test on perf-o-matic and perf. test's results page.

Also, use python's compute_statistics instead of reading statistics off of DriverOutput to simplify the code.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTestMetric): Added.
(PerfTestMetric.init): Added.
(PerfTestMetric.metric): Added.
(PerfTestMetric.has_values): Added.
(PerfTestMetric.legacy_chromium_bot_compatible_test_name): Added. Following the legacy convention, "Malloc" and
"JSHeap" will use "test_name:Malloc" whereas "Time" uses "test_name" itself. We should eventually move these
conversions to be done on the client side (perf-o-matic and results page).
(PerfTestMetric.append): Added.
(PerfTestMetric.to_dict): Added. Computes the statistics and generates the dictionary object that represents
a result for this metric.
(PerfTestMetric.metric_to_unit): Added. Each metric maps to exactly one unit (it's not one-to-one).
(PerfTestMetric.compute_statistics): Moved from PerfTest.

(PerfTest._create_driver): Extracted from PerfTest.run.
(PerfTest.run): Given an array of PerfTestMetric, generate the results dictionary. Also print out results
as needed.
(PerfTest._run_with_driver):
(PerfTest): Removed _result_classes and _result_class_regex. "result class" is the old name for "metric".
(PerfTest.parse_output): Dramatically simplified. We now just return an array of PerfTestMetric's. Also ignore
all keys except "values". We rely on PerfTestMetric to compute the statistics for us.

(ChromiumStylePerfTest.run): Added and merged _run_with_driver. Since chromium style perf tests are so different
from other perf tests, there isn't much point in sharing the code here.

(PageLoadingPerfTest._run_with_driver): Simplified. Just create an array of PerfTestMetric's without computing
statistics for the measured values.

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPerfTestMetric): Added.
(TestPerfTestMetric.test_init_set_missing_unit): Added.
(TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name): Added.
(TestPerfTestMetric.test_has_values): Added.
(TestPerfTestMetric.test_append): Added.
(TestPerfTestMetric.test_compute_statistics.compute_statistics):
(TestPerfTestMetric.test_compute_statistics): Added a trivial test case.

(TestPerfTest._assert_results_are_correct): Updated as needed.
(TestPageLoadingPerfTest.test_run): Ditto. Notice that we no longer log anything in _run_with_driver. It's done
in PerfTest.run now after generating the results dictionary.
(TestPageLoadingPerfTest.test_run_with_memory_output): Ditto.

10:27 AM Changeset in webkit [138954] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

Mark fast/block/float/max-width-clear-float-with-overflow-hidden.html as failing.
https://bugs.webkit.org/show_bug.cgi?id=47975

  • platform/chromium/TestExpectations: Marked.
10:18 AM Changeset in webkit [138953] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

[Chromium] Update bug numbers and organize bug lines.

  • platform/chromium/TestExpectations: Organizzazzed.
9:25 AM Changeset in webkit [138952] by jchaffraix@webkit.org
  • 4 edits in trunk

Support size_t multiplication and division operators on LayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=83848

Reviewed by Emil A Eklund.

Source/WebCore:

Per Darin's suggestion, adding a version of the operator for most unsigned types (excluding
only unsigned char). This should automatically cover size_t as it should be one of these.

Test: TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp

  • platform/LayoutUnit.h:

(WebCore::LayoutUnit::LayoutUnit):
(WebCore::operator*):
(WebCore::operator/):
Added the operators and (possibly saturating) constructors for unsigned short, unsigned long,
unsigned long long.

Tools:

  • TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:

Added some simple tests for the new operators using size_t.

9:15 AM Changeset in webkit [138951] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

[Qt] run-webkit-tests cleanup for parallel NRWT
https://bugs.webkit.org/show_bug.cgi?id=106220

Reviewed by Dirk Pranke.

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort):
(QtPort.default_child_processes):

9:02 AM Changeset in webkit [138950] by schenney@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Add comment to WebKit skia gyp

Unreviewed additon of a comment.

  • skia_webkit.gyp: Some changes should not yet be committed. Commented to that effect.
8:54 AM Changeset in webkit [138949] by schenney@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Add Skia build flags to WebKit skia gyp

Unreviewed change to enable easy layout test rebaselining.

  • skia_webkit.gyp: Added SK_IGNORE_QUAD_STROKE_FIX and SK_IGNORE_TREAT_AS_SPRITE
8:40 AM Changeset in webkit [138948] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r138944.
http://trac.webkit.org/changeset/138944
https://bugs.webkit.org/show_bug.cgi?id=106223

It made 28 tests crash (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-07

  • plugins/qt/PluginPackageQt.cpp:

(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):

8:32 AM Changeset in webkit [138947] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[WinCairo] Build fixes after r138413
https://bugs.webkit.org/show_bug.cgi?id=106087

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-01-07
Reviewed by Alexey Proskuryakov.

  • WebCore.vcproj/WebCore.vcproj: Added NetworkStorageSessionStub.cpp,

and removed NetworkStorageSessionCFNet.cpp for WinCairo build.

  • platform/win/TemporaryLinkStubs.cpp: Include fix.
7:51 AM Changeset in webkit [138946] by michael.bruning@digia.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Apply correct patch for the scrolling issue from bug 105014
https://bugs.webkit.org/show_bug.cgi?id=106219

Correct the if condition when overwriting the layout direction option
with the values from the facade options to only overwrite if the facade
direction is not equal to LayoutDirectionAuto.

Reviewed by Allan Sandfeld Jensen.

  • WidgetSupport/QStyleFacadeImp.cpp:

(WebKit::initGenericStyleOption):

7:45 AM Changeset in webkit [138945] by Philippe Normand
  • 2 edits in trunk/Tools

Create a GStreamerAudio watchlist and add myself to it.

Unreviewed.

  • Scripts/webkitpy/common/config/watchlist:
7:40 AM Changeset in webkit [138944] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Major performance improvement in Qt's PluginDatabase implementation
https://bugs.webkit.org/show_bug.cgi?id=106140

Patch by David Faure <faure@kde.org> on 2013-01-07
Reviewed by Simon Hausmann.

No new tests, only a performance improvement.

  • plugins/qt/PluginPackageQt.cpp:

(WebCore::PluginPackage::fetchInfo): Don't do a full-fledged load(), load the module directly.
(WebCore::PluginPackage::load): Use existing module if fetchInfo created it.

7:33 AM Changeset in webkit [138943] by Lucas Forschler
  • 13 edits in tags/Safari-537.24.2/Source

Merged r138858.

7:25 AM Changeset in webkit [138942] by Lucas Forschler
  • 4 edits in tags/Safari-537.24.2/Source

Versioning.

7:23 AM Changeset in webkit [138941] by Lucas Forschler
  • 1 copy in tags/Safari-537.24.2

New Tag.

7:21 AM Changeset in webkit [138940] by haraken@chromium.org
  • 3 edits
    2 copies in branches/chromium/1364

Merge 137964

Regression causing DOM objects to have unstable NPObject* references with v8 bindings
https://bugs.webkit.org/show_bug.cgi?id=104921

Source/WebCore:

Patch by Matthew Dempsky <mdempsky@google.com> on 2012-12-17
Reviewed by Kentaro Hara.

Fix regression introduced by changeset 135804 resulting in
unstable NPObject* references for v8 objects. In the iter !=
v8NPObjectMap->end() code path, objectVector was left unassigned
if the for loop terminated without returning.

Also, V8Object::GetIdentityHash() is documented as not being guaranteed
as unique. As such, don't ASSERT() that two objects with the same hash
must therefor be the same object.

Tests: plugins/npruntime/embed-property-iframe-equality.html

  • bindings/v8/NPV8Object.cpp:

(WebCore::npCreateV8ScriptObject): Fix.

LayoutTests:

Patch by Mathew Dempsky <mdempsky@google.com> on 2012-12-17
Reviewed by Kentaro Hara.

Add variant of embed-property-equality test to verify that the
test still passes when the object being tested for equality
has already been remembered by a plugin from a different
JavaScript context.

  • plugins/npruntime/embed-property-iframe-equality.html: Added.
  • plugins/npruntime/embed-property-iframe-equality-expected.txt: Added.

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/11791021

7:13 AM Changeset in webkit [138939] by mihnea@adobe.com
  • 3 edits in trunk/LayoutTests

Unreviewed. Unskip tests fixed in http://trac.webkit.org/changeset/138937.

7:13 AM Changeset in webkit [138938] by mkwst@chromium.org
  • 1 edit in branches/chromium/1312/Source/WebKit/chromium/features.gypi

[chromium] Unreviewed. Toggling ENABLE_IFRAME_SEAMLESS off for M24.

BUG=168555

6:47 AM Changeset in webkit [138937] by mihnea@adobe.com
  • 5 edits in trunk/LayoutTests

[GTK][EFL][Qt] New tests fast/regions/region-rule-nested-region-rule.html, fast/regions/region-styling-mediaquery.html are failing
https://bugs.webkit.org/show_bug.cgi?id=106168

Reviewed by Csaba Osztrogonác.

Specify a margin-top: 0 both for the h1 element that is flowed into region and the h1 element in the ref test to ensure
the h1 element is displayed at the same position in the region and in the containing article element.
Also, cleaned up the tests a little.

  • fast/regions/region-rule-nested-region-rule-expected.html:
  • fast/regions/region-rule-nested-region-rule.html:
  • fast/regions/region-styling-mediaquery-expected.html:
  • fast/regions/region-styling-mediaquery.html:
6:31 AM Changeset in webkit [138936] by rgabor@webkit.org
  • 3 edits in trunk/Source/WebCore

Optimizing RGBA16, RGB16, ARGB16, BGRA16 unpacking functions with NEON intrinsics
https://bugs.webkit.org/show_bug.cgi?id=103614

Reviewed by Zoltan Herczeg.

Optimizing RGBA16, RGB16, ARGB16, BGRA16 unpacking functions in GraphicsContext3D
with ARM NEON intrinsics. The optimized functions are 2-3x faster than the origin.

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore):

  • platform/graphics/cpu/arm/GraphicsContext3DNEON.h:

(WebCore::SIMD::unpackOneRowOfRGBA16LittleToRGBA8):
(SIMD):
(WebCore::SIMD::unpackOneRowOfRGB16LittleToRGBA8):
(WebCore::SIMD::unpackOneRowOfARGB16LittleToRGBA8):
(WebCore::SIMD::unpackOneRowOfBGRA16LittleToRGBA8):

5:26 AM Changeset in webkit [138935] by Christophe Dumez
  • 4 edits in trunk

Regression(r138786): Causes webaudio tests to crash
https://bugs.webkit.org/show_bug.cgi?id=106182

Reviewed by Philippe Normand.

Source/WebCore:

Partially revert r138786 since it causes crashes in webaudio
tests. The WebProcess would actually become unresponsive due
to source element never going to PLAYING state.

Only the changes to webKitWebAudioSrcChangeState() were reverted.

No new tests, already covered by existing tests.

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcChangeState):

LayoutTests:

Unskip several webaudio tests for EFL WK2 now that the
regression was fixed.

  • platform/efl-wk2/TestExpectations:
3:26 AM Changeset in webkit [138934] by János Badics
  • 3 edits in trunk/LayoutTests

[Qt] Gardening.
r138820: Skipped a test because track feature is not functional yet.
r138838: Added new baseline to fast/writing-mode/table-percent-width-quirk-expected.txt.

Reviewed by Csaba Osztrogonác.

  • platform/qt/TestExpectations:
  • platform/qt/fast/writing-mode/table-percent-width-quirk-expected.txt:
2:09 AM Changeset in webkit [138933] by michael.bruning@digia.com
  • 6 edits
    2 adds in trunk/Source/WebKit/qt

[Qt] Horizontal scrollbars events are offseted making them difficult to use
https://bugs.webkit.org/show_bug.cgi?id=105014

Reviewed by Allan Sandfeld Jensen.

Patch co-authored by Simon Hausmann.

Only copy the layout direction from the facade options if the
current option is Qt::LayoutDirectionAuto in order to prevent
misinterpretations as different layout direction when hit testing.

Tests added to tst_qwebview and tst_qgraphicswebview to verify
that the view actually is scrolled in the right direction.

  • WidgetSupport/QStyleFacadeImp.cpp:

(WebKit::initGenericStyleOption):

  • tests/qgraphicswebview/resources/scrolltest_page.html: Added.
  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView):
(tst_QGraphicsWebView::horizontalScrollbarTest):

  • tests/qgraphicswebview/tst_qgraphicswebview.qrc:
  • tests/qwebview/resources/scrolltest_page.html: Added.
  • tests/qwebview/tst_qwebview.cpp:

(tst_QWebView):
(tst_QWebView::horizontalScrollbarTest):

  • tests/qwebview/tst_qwebview.qrc:
2:01 AM Changeset in webkit [138932] by allan.jensen@digia.com
  • 2 edits
    9 adds in trunk/LayoutTests

Unskip now passing ruby tests.

Unreviewed gardening.

Verified to match rendering in other ports.

  • platform/qt/TestExpectations:
  • platform/qt/fast/ruby/ruby-beforeafter-expected.txt: Added.
  • platform/qt/fast/ruby/ruby-empty-rt-expected.txt: Added.
  • platform/qt/fast/ruby/ruby-length-expected.txt: Added.
  • platform/qt/fast/ruby/ruby-run-break-expected.txt: Added.
  • platform/qt/fast/ruby/ruby-runs-expected.txt: Added.
  • platform/qt/fast/ruby/ruby-runs-spans-expected.txt: Added.
  • platform/qt/fast/ruby/ruby-simple-expected.txt: Added.
  • platform/qt/fast/ruby/ruby-simple-rp-expected.txt: Added.
  • platform/qt/fast/ruby/ruby-trailing-expected.txt: Added.
1:18 AM Changeset in webkit [138931] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark 2 fast/regions ref tests as failing for EFL
port. Those tests were introduced in r138854.

  • platform/efl/TestExpectations:
1:13 AM Changeset in webkit [138930] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark several webaudio tests as crashing on WK2 EFL
due to a regression in r138786.

  • platform/efl-wk2/TestExpectations:
1:07 AM Changeset in webkit [138929] by hayato@chromium.org
  • 2 edits in trunk/Source/WebCore

Cannot compile with ENABLE_SHADOW_DOM=0 and ENABLE_STYLE_SCOPED=1
https://bugs.webkit.org/show_bug.cgi?id=106207

Reviewed by Hajime Morita.

Guard StyleScopeResolver::addHostRule with SHADOW_DOM flag.

No tests, as no change in behavior.

  • css/StyleScopeResolver.cpp:

(WebCore):

12:12 AM Changeset in webkit [138928] by jonlee@apple.com
  • 3 edits in trunk/Source/WebCore

Missing amendments to r138927. Amend Changelog to remove item about Timer.h, which was not changed.

  • rendering/RenderSnapshottedPlugIn.cpp: Rename stopAndRestartDelayTimer() to resetDelayTimer().

(WebCore::RenderSnapshottedPlugIn::updateSnapshot):
(WebCore::RenderSnapshottedPlugIn::handleEvent):
(WebCore::RenderSnapshottedPlugIn::resetDelayTimer):

  • rendering/RenderSnapshottedPlugIn.h:

Jan 6, 2013:

11:28 PM Changeset in webkit [138927] by jonlee@apple.com
  • 4 edits in trunk/Source/WebCore

Show label automatically for plug-ins of significant size
https://bugs.webkit.org/show_bug.cgi?id=106146
<rdar://problem/12783010>

Reviewed by Simon Fraser.

For significantly sized plug-ins, trigger a timer that displays the label automatically
without requiring the user to mouse over the element first. The trickiness of the logic
here is that there are two delays involved-- one for whether the user mouses over (shorter),
and one for when the label is shown automatically (longer). Mousing over a plug-in that is
marked to show it automatically should have the timer delay switched. And if the label
showed automatically, mousing in and out of the element should not change that label's
state.

  • html/HTMLPlugInImageElement.cpp:

(WebCore): Add constants that determine whether the plug-in is of a significant size.
(WebCore::shouldPlugInShowLabelAutomatically): Based on the size of the frame view and the
clipped plug-in size, determine whether the label should show automatically. If the plug-in is
not contained within the bounds of the frame view, or is not at least as large as the threshold
size, then do not show the label automatically.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): After we've determined that
the plug-in should not auto-start, make a check to see if the label should show automatically.
Also, update some of the logging.
(WebCore::HTMLPlugInImageElement::subframeLoaderDidCreatePlugIn): Update the logging.

  • platform/Timer.h:

(WebCore::DeferrableOneShotTimer::setDelay): Added to allow changing the delay of the timer. It
does not change any currently set timer, but should change the delay for the next one.

  • rendering/RenderSnapshottedPlugIn.h: Rename the timer to m_showLabelDelayTimer since

it can fire for two different reasons. Add some additional state variables, and an enum
to explain why the label appeared.

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore): Change hoverDelay to showLabelAfterMouseOverDelay. Add a new, longer delay for
when the plug-in is supposed to auto-show the label.
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): Initialize the member variables.
(WebCore::RenderSnapshottedPlugIn::updateSnapshot): When the snapshot image is updated,
start the timer to auto-show the label.
(WebCore::RenderSnapshottedPlugIn::paintLabel): Avoid painting the label only if the element
is not hovered and the user was mousing over the plug-in. Otherwise, the plug-in is supposed
to show automatically, and we should paint. Mark the renderer as having showed the label at
least once.
(WebCore::RenderSnapshottedPlugIn::showLabelDelayTimerFired): Renamed to reflect the
purpose of the timer.
(WebCore::RenderSnapshottedPlugIn::setShouldShowLabelAutomatically): Set the variable that
determines whether, in general, this plug-in should show the label automatically even
without user input.
(WebCore::RenderSnapshottedPlugIn::handleEvent): If the user mouses over the plug-in,
only reset the show timer is the label has never appeared before, or if it has, that
it's not because the label was supposed to show automatically. That is, if the label is
supposed to show automatically, the label should remain visible. This is also true when
the user mouses out of the plug-in. If the user moused out before the time had a chance
to fire and show the label for the first time, then we check to see if the plug-in should
be displaying the label automatically, and if so, restart the timer using the longer delay.
(WebCore::RenderSnapshottedPlugIn::stopAndRestartDelayTimer): Convenience function to
update the m_showReason variable, and reset the timer with the appropriate delay.

11:15 PM Changeset in webkit [138926] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

Heap-use-after-free in DocumentLoader::stopLoading
https://bugs.webkit.org/show_bug.cgi?id=103656

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/dom/ready-state-change-crash.html

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::prepareToStopParsing): Bail out
if the parser is detached due to mutation event.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::stopLoading): Move the protectors for
frame and document loader to the start of the function. Call to
m_frame->loader()->stopLoading() can change document ready state
and fire mutation event which might blow the document loader from
underneath.

LayoutTests:

  • fast/dom/ready-state-change-crash-expected.txt: Added.
  • fast/dom/ready-state-change-crash.html: Added.
10:45 PM Changeset in webkit [138925] by hayato@chromium.org
  • 6 edits in branches/chromium/1364

Merge 138165

Expose WebKitShadowRoot constructor to DOMWindow.
https://bugs.webkit.org/show_bug.cgi?id=105385

Reviewed by Dimitri Glazkov.

Source/WebCore:

This is a follow-up patch for r137870. WebKitShadowRoot
constructor should be in DOMWindow, just like all of the other
not-callable-constructors like HTMLDivElement, etc. We need it
for instanceof tests and so on.

Test: fast/dom/shadow/shadow-root-js-api.html

fast/js/global-constructors-expected.html

  • page/DOMWindow.idl:

LayoutTests:

  • fast/dom/shadow/shadow-root-js-api-expected.txt:
  • fast/dom/shadow/shadow-root-js-api.html:
  • fast/js/global-constructors-expected.txt:
  • platform/efl/fast/js/global-constructors-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:

TBR=hayato@chromium.org
Review URL: https://codereview.chromium.org/11776020

10:34 PM Changeset in webkit [138924] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Simplify slow case profiling
https://bugs.webkit.org/show_bug.cgi?id=106208

Reviewed by Mark Rowe.

Removing the minimum execution ratio portion of slow case profiling, which allows
the removal of a field from CodeBlock. This appears to be performance neutral,
implying that the complexity incurred by the previous heuristic was purely
harmful: it made the code more complicated, and it made CodeBlock larger, without
resulting in any measurable benefits.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::couldTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • runtime/Options.h:
10:10 PM Changeset in webkit [138923] by tasak@google.com
  • 2 edits in trunk/Source/WebCore

[Shadow DOM]: crash in WebCore::ElementShadow::setValidityUndetermined
https://bugs.webkit.org/show_bug.cgi?id=106203

Reviewed by Hajime Morita.

InsertionPoint should check whether ElementShadow is available or not
before invoking its methods.

No new tests. Webcomponents_fuzzer reported this bug. Would like to
use the fuzzer to check this issue.

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::getDistributedNodes):
(WebCore::InsertionPoint::childrenChanged):
(WebCore::InsertionPoint::insertedInto):
Added ifs to check whether ElementShadow is available or not before
invoking ElementShadow's methods, i.e. setValidityUndetermined,
invalidateDistribution, and ensureDistributionDocument.

10:03 PM Changeset in webkit [138922] by shinyak@chromium.org
  • 2 edits in trunk/Source/WebCore

RenderImage should not use shadowAncestorNode
https://bugs.webkit.org/show_bug.cgi?id=97871

Reviewed by Dimitri Glazkov.

Since shadowAncestorNode() does not return 0, this if-condition will never hold.
shadowHost() should be used instead.

No change in logic, refactoring.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::hostImageElement):

6:24 PM Changeset in webkit [138921] by fpizlo@apple.com
  • 18 edits in trunk/Source/JavaScriptCore

DFG should inline closure calls
https://bugs.webkit.org/show_bug.cgi?id=106067

Reviewed by Gavin Barraclough.

This adds initial support for inlining closure calls to the DFG. A call is considered
to be a closure call when the JSFunction* varies, but always has the same executable.
We already have closure call inline caching in both JITs, which works by checking that
the callee has an expected structure (as a cheap way of detecting that it is in fact
a JSFunction) and an expected executable. Closure call inlining uses profiling data
aggregated by CallLinkStatus to decide when to specialize the call to the particular
structure/executable, and inline the call rather than emitting a call sequence. When
we choose to do a closure inline rather than an ordinary inline, a number of things
change about how inlining is performed:

  • The inline is guarded by a CheckStructure/CheckExecutable rather than a CheckFunction.


  • Instead of propagating a constant value for the scope, we emit GetMyScope every time that the scope is needed, which loads the scope from a local variable. We do similar things for the callee.


  • The prologue of the inlined code includes SetMyScope and SetCallee nodes to eagerly plant the scope and callee into the "true call frame", i.e. the place on the stack where the call frame would have been if the call had been actually performed. This allows GetMyScope/GetCallee to work as they would if the code wasn't inlined. It also allows for trivial handling of scope and callee for call frame reconstruction upon stack introspection and during OSR.


  • A new node called GetScope is introduced, which just gets the scope of a function. This node has the expected CSE support. This allows for the SetMyScope(GetScope(@function)) sequence to set up the scope in the true call frame.


  • GetMyScope/GetCallee CSE can match against SetMyScope/SetCallee, which means that the GetMyScope/GetCallee nodes emitted during parsing are often removed during CSE, if we can prove that it is safe to do so.


  • Inlining heuristics are adjusted to grok the cost of inlining a closure. We are less likely to inline a closure call than we are to inline a normal call, since we end up emitting more code for closures due to CheckStructure, CheckExecutable, GetScope, SetMyScope, and SetCallee.


Additionally, I've fixed the VariableEventStream to ensure that we don't attempt to
plant Undefined into the true call frames. This was previously a harmless oversight,
but it becomes quite bad if OSR is relying on the scope/callee already having been
set and not subsequently clobbered by the OSR itself.

This is a ~60% speed-up on programs that frequently make calls to closures. It's
neutral on V8v7 and other major benchmark suites.

The lack of a definite speed-up is likely due the fact that closure inlining currently
does not do any cardinality [1] optimizations. We don't observe when a closure was
constructed within its caller, and so used the scope from its caller; and furthermore
we have no facility to detect when the scope is single. All scoped variable accesses
are assumed to be multiple instead. A subsequent step will be to ensure that closure
call inlining will be single and loving it.

[1] Single and loving it: Must-alias analysis for higher-order languages. Suresh

Jagannathan, Peter Thiemann, Stephen Weeks, and Andrew Wright. In POPL '98.

  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::dump):

  • bytecode/CallLinkStatus.h:

(JSC::CallLinkStatus::isClosureCall):
(CallLinkStatus):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::globalObjectFor):
(JSC):

  • bytecode/CodeBlock.h:

(CodeBlock):

  • bytecode/CodeOrigin.cpp:

(JSC::InlineCallFrame::dump):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::emitFunctionChecks):
(JSC::DFG::ByteCodeParser::handleInlining):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::pureCSE):
(CSEPhase):
(JSC::DFG::CSEPhase::getCalleeLoadElimination):
(JSC::DFG::CSEPhase::checkExecutableElimination):
(JSC::DFG::CSEPhase::getMyScopeLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::mightInlineFunctionForClosureCall):

  • dfg/DFGCapabilities.h:

(DFG):
(JSC::DFG::mightInlineFunctionForClosureCall):
(JSC::DFG::canInlineFunctionForClosureCall):
(JSC::DFG::canInlineFunctionFor):

  • dfg/DFGNode.h:

(Node):
(JSC::DFG::Node::hasExecutable):
(JSC::DFG::Node::executable):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::reconstruct):

  • runtime/Options.h:

(JSC):

3:58 PM Changeset in webkit [138920] by kerz@chromium.org
  • 2 edits in branches/chromium/1364/Source/WebKit/chromium

Merge 138302

[chromium] Disable color profile support for WebImageSkia users
https://bugs.webkit.org/show_bug.cgi?id=105493

Reviewed by Eric Seidel.

Disable color profiles to prevent null pointer dereference under some
conditions. Tested by unittests at src.chromium.org.

  • src/WebImageSkia.cpp:

(WebKit::WebImage::fromData):
(WebKit::WebImage::framesFromData):

TBR=noel.gordon@gmail.com
Review URL: https://codereview.chromium.org/11785017

12:26 PM Changeset in webkit [138919] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Bug 106177 - [GStreamer] Don't call gst_video_info_from_caps() with non-fixed caps
https://bugs.webkit.org/show_bug.cgi?id=106177

Patch by Sebastian Dröge <sebastian.droege@collabora.co.uk> on 2013-01-06
Reviewed by Martin Robinson.

  • platform/graphics/gstreamer/GStreamerVersioning.cpp:

(getVideoSizeAndFormatFromCaps):
Don't call gst_video_info_from_caps() with non-fixed caps as
it will cause assertions.

10:53 AM Changeset in webkit [138918] by inferno@chromium.org
  • 3 edits
    2 adds in trunk

Heap-use-after-free in WebCore::Document::implicitClose
https://bugs.webkit.org/show_bug.cgi?id=105655

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/dom/window-load-crash.html

  • dom/Document.cpp:

(WebCore::Document::implicitClose): RefPtr protect |this| document since it
can be destroyed in the dispatchWindowLoadEvent call.

LayoutTests:

  • fast/dom/window-load-crash-expected.txt: Added.
  • fast/dom/window-load-crash.html: Added.
3:18 AM BuildingGtk edited by Christophe Dumez
(diff)
3:17 AM BuildingGtk edited by Christophe Dumez
(diff)
1:43 AM Changeset in webkit [138917] by mkwst@chromium.org
  • 4 edits in trunk

Seamless: IFrame's padding isn't taken into account when calculating its height.
https://bugs.webkit.org/show_bug.cgi?id=106167

Reviewed by Eric Seidel.

Source/WebCore:

IFrames rendered seamlessly don't currently calculate their height
correctly when padding is applied to the frame itself. This patch adds
padding calculations to RenderIFrame::layoutSeamlessly to ensure that
the seamless frame is correctly sized.

  • rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::layoutSeamlessly):

LayoutTests:

  • fast/frames/seamless/seamless-border-padding-expected.txt:

Adjusts the previously failing expectations to the correct values.

Note: See TracTimeline for information about the timeline view.