Timeline



Feb 7, 2013:

11:58 PM Changeset in webkit [142239] by yurys@chromium.org
  • 13 edits in trunk

Web Inspector: reduce number of native memory instrumentation categories
https://bugs.webkit.org/show_bug.cgi?id=109146

Reviewed by Pavel Feldman.

Source/WebCore:

Merged some of memory instrumentation categories.

  • dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

  • platform/PlatformMemoryInstrumentation.cpp:

(WebCore):

LayoutTests:

Updated tests to use new memory categories.

  • inspector-protocol/nmi-webaudio-expected.txt:
  • inspector-protocol/nmi-webaudio-leak-test-expected.txt:
  • inspector-protocol/nmi-webaudio-leak-test.html:
  • inspector-protocol/nmi-webaudio.html:
  • inspector/profiler/memory-instrumentation-cached-images-expected.txt:
  • inspector/profiler/memory-instrumentation-cached-images.html:
  • inspector/profiler/memory-instrumentation-canvas-expected.txt:
  • inspector/profiler/memory-instrumentation-canvas.html:
11:47 PM Changeset in webkit [142238] by falken@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Flakiness on table-cell-before-after-content-around-table-row.html
https://bugs.webkit.org/show_bug.cgi?id=109262

An assert is sometimes hit in WebCore::RenderTableCell::styleDidChange.

  • platform/chromium/TestExpectations:
11:38 PM Changeset in webkit [142237] by jochen@chromium.org
  • 31 edits
    3 copies in trunk/Tools

[chromium] turn TestRunner library into a component build
https://bugs.webkit.org/show_bug.cgi?id=108466

Reviewed by Adam Barth.

To achieve this, we need to drop all dependencies on WTF.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTask.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
  • DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:

(AccessibilityUIElementList):

  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:

(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):

  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:

(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):

  • DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:

(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):

  • DumpRenderTree/chromium/TestRunner/src/CppVariant.h:

(CppVariant):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):

  • DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:

(WebTestRunner::NativeKeyCodeForWindowsKeyCode):

  • DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:

(WebTestRunner::MockGrammarCheck::checkGrammarOfString):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:

(WebTestRunner):
(MockGrammarCheck):

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:

(WebTestRunner::MockSpellCheck::spellCheckWord):
(WebTestRunner::MockSpellCheck::initializeIfNeeded):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:

(MockSpellCheck):

  • DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:

(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):

  • DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.

(isASCIIAlpha):
(isNotASCIIAlpha):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:

(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:

(TestPlugin):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner::TestRunner::deliverWebIntent):
(WebTestRunner::TestRunner::setBackingScaleFactor):
(WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
(WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
(WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
(WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:

(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):

  • DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):

  • DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:

(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):

  • DumpRenderTree/chromium/TestRunner/src/config.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
11:35 PM Changeset in webkit [142236] by mkwst@chromium.org
  • 5 edits in trunk

<iframe seamless> should avoid vertical scrollbars during the initial layout passes.
https://bugs.webkit.org/show_bug.cgi?id=87707

Reviewed by Eric Seidel.

Source/WebCore:

Seamless documents currently render incorrectly when their content fills
the width of the container into which they're placed. Because FrameView
assumes that the container's size is properly set before the first pass
of layout, vertical scrollbars are incorrectly forced onto seamless
content, because seamless sets the container's height to 0 before
handing it off to FrameView for layout. The scrollbars make the
available width for the seamless document ~15px smaller than it should
be, resulting in content getting bumped to the next line.

This patch special-cases FrameView::calculateScrollbarModesForLayout in
order to force scrollbars off for seamless documents with a full visible
height of 0px. Once the layout pass has grabbed the content height and
applied it to the visible height, scrollbars will again be applicable.

The change should be covered by rebaselines for the newly-passing
results in fast/frame/seamless-{float,inline}.html

  • page/FrameView.cpp:

(WebCore::FrameView::calculateScrollbarModesForLayout):

If we're rendering a seamless document, and the full visible height
is 0, and the vertical scrollbar would otherwise be ScrollbarAuto,
then force ScrollbarAlwaysOff.

LayoutTests:

  • fast/frames/seamless/seamless-float-expected.txt:
  • fast/frames/seamless/seamless-inline-expected.txt:

Rebaseline the now-passing bits of these tests.

11:34 PM Changeset in webkit [142235] by alokp@chromium.org
  • 2 edits
    2 copies
    9 adds in trunk/LayoutTests

Unreviewed rebaseline.

  • platform/mac-lion/compositing/visible-rect/iframe-no-layers-expected.txt: Copied from LayoutTests/platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt.
  • platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt:
  • platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt: Copied from LayoutTests/platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt.
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt: Added.
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt: Added.
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt: Added.
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt: Added.
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt: Added.
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt: Added.
11:18 PM Changeset in webkit [142234] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

document.activeElement should not return a non-focusable element
https://bugs.webkit.org/show_bug.cgi?id=86707

Reviewed by Hajime Morita.

Source/WebCore:

This is based on a patch by Arpita Bahuguna.

Test: fast/dom/HTMLDocument/set-focus-on-valid-element.html

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode):
Added check for verifying that the node to be focused is
focusable. However, this check should be skipped for HTMLPlugInElement
because it has special behavior.

LayoutTests:

  • fast/dom/HTMLDocument/set-focus-on-valid-element-expected.txt: Added.
  • fast/dom/HTMLDocument/set-focus-on-valid-element.html: Added.

This test verifies that document.activeElement does not return an
invalid or non-focusable element.

11:08 PM Changeset in webkit [142233] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed followup to r142232.

Work around a bug in jhbuild that was incorrectly composing the source
package URL by adjusting slightly the repository and module paths.

  • gtk/jhbuild.modules:
10:46 PM Changeset in webkit [142232] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Use a mirror for the sourceware.org repo used in jhbuild

Unreviewed.

The ftp://sourceware.org site is down, causing errors when running jhbuild
and subsequently failing complete builds on the builders. Use the mirrors.kernel.org
mirror to get sources for the desired libffi dependency.

  • gtk/jhbuild.modules:
10:42 PM Changeset in webkit [142231] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Fix front-end compilation warnings related to WebInspector.SidebarPane
https://bugs.webkit.org/show_bug.cgi?id=109259

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-07
Reviewed by Vsevolod Vlasov.

  • inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.Proxy):

  • inspector/front-end/SidebarPane.js:
10:41 PM Changeset in webkit [142230] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WTF

Fix #endif comment from r142163 and r142183

  • wtf/MainThread.h:

(WTF): s/PLATFORM/USE/

10:15 PM Changeset in webkit [142229] by falken@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Two webgl/conformance/context tests are timing out.

See https://bugs.webkit.org/show_bug.cgi?id=109114

  • platform/chromium/TestExpectations:
10:05 PM Changeset in webkit [142228] by zoltan@webkit.org
  • 1 edit
    7 deletes in trunk/LayoutTests

Cleaning up after r142208
https://bugs.webkit.org/show_bug.cgi?id=109228

Unreviewed.

The commit-queue didn't remove these files for some reason. Removing them manually.

  • platform/chromium-mac-lion/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
  • platform/chromium-mac/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
  • platform/chromium-win/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
  • platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
  • platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
  • platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
  • platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
9:47 PM Changeset in webkit [142227] by charles.wei@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

webpage needs null check in BackingStore::setCurrentBackingStoreOwner
https://bugs.webkit.org/show_bug.cgi?id=109253

Reviewed by George Staikos.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::setCurrentBackingStoreOwner):

9:37 PM Changeset in webkit [142226] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] enum V8HiddenPropertyCreationType is not used
https://bugs.webkit.org/show_bug.cgi?id=109250

Reviewed by Adam Barth.

V8HiddenPropertyCreationType is always NewSymbol. We can remove the enum.

No tests. No change in behavior.

  • bindings/v8/V8HiddenPropertyName.cpp:

(WebCore::hiddenReferenceName):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

9:32 PM Changeset in webkit [142225] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Unreviewed, rolling out r142212.
http://trac.webkit.org/changeset/142212
https://bugs.webkit.org/show_bug.cgi?id=109255

Causes ASSERT(!m_installed) on launch (Requested by smfr on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-07

Source/WebCore:

  • WebCore.exp.in:
  • platform/MemoryPressureHandler.cpp:

(WebCore):
(WebCore::MemoryPressureHandler::respondToMemoryPressure):

  • platform/MemoryPressureHandler.h:

(MemoryPressureHandler):

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::respondToMemoryPressure):

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(WebInstallMemoryPressureHandler):

Source/WebKit2:

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::initializeProcess):
(WebKit::PluginProcess::shouldTerminate):

  • PluginProcess/PluginProcess.h:

(PluginProcess):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

9:03 PM Changeset in webkit [142224] by alokp@chromium.org
  • 5 edits
    1 move
    4 adds in trunk/LayoutTests

Rebaseline text output for contentOpaque
https://bugs.webkit.org/show_bug.cgi?id=108656

Unreviewed rebaseline.

  • platform/chromium-mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-win/compositing/visibility/visibility-image-layers-dynamic-expected.txt.
  • platform/mac/TestExpectations:
  • platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt: Added.
8:59 PM Changeset in webkit [142223] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

NamedFlowCollection should be a ContextDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=99239

Patch by Hanyee Kim <choco@company100.net> on 2013-02-07
Reviewed by Adam Barth

This patch removes the raw pointer of Document in NamedFlowCollection.
It could be replaced with ContextDestructionObserver.
ContextDestructionObserver has the pointer and clears the pointer
automatically when the document is destroyed.

  • dom/Document.cpp:

(WebCore::Document::~Document):

  • dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::NamedFlowCollection):
(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):
(WebCore::NamedFlowCollection::document):
(WebCore):

  • dom/NamedFlowCollection.h:

(NamedFlowCollection):

8:29 PM Changeset in webkit [142222] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Remove dead code after r142169
https://bugs.webkit.org/show_bug.cgi?id=109251

Reviewed by Benjamin Poulain.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):

8:16 PM Changeset in webkit [142221] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Followup review suggestions from Alexey Proskuryakov on
https://bugs.webkit.org/show_bug.cgi?id=109215

Don't provide a charset on embedded SVG, especially
with incorrect syntax :)

  • css/mediaControlsQuickTime.css:

(video::-webkit-media-controls-toggle-closed-captions-button):
(video::-webkit-media-controls-closed-captions-track-list li.selected):
(video::-webkit-media-controls-closed-captions-track-list li.selected:hover):

7:01 PM Changeset in webkit [142220] by mary.wu@torchmobile.com.cn
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Enable non-video element enter/exit fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=108314

Reviewed by Antonio Gomes.

Webkit support non-video element (like div) to enter/exit
fullscreen. We should pass this capability in blackberry porting.

RIM PR 256370, internally reviewed by Max Feil.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::clearDocumentData):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPage::notifyFullScreenVideoExited):
(BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):
(BlackBerry::WebKit::WebPagePrivate::exitFullscreenForNode):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::adjustFullScreenElementDimensionsIfNeeded):

  • Api/WebPage_p.h:

(WebPagePrivate):

6:41 PM Changeset in webkit [142219] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Gtk] RunLoop::run shuold run current thread's run loop.
https://bugs.webkit.org/show_bug.cgi?id=107887

Patch by Seulgi Kim <seulgikim@company100.net> on 2013-02-07
Reviewed by Martin Robinson.

Currently, RunLoop in Gtk can use just main thread's event loop.
But the other ports are implemented to use RunLoop in sub threads.

This patch makes RunLoop constructor create new context, not use default
context.
But in the main thread still uses default context to use main event loop
since there is some codes using glib directly (e.g. in
LayerTreeHostGtk::scheduleLayerFlush).

No new tests. There is no case that uses RunLoop in off the main thread
yet.

  • platform/gtk/RunLoopGtk.cpp:

(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::run):

6:29 PM Changeset in webkit [142218] by falken@chromium.org
  • 1 edit
    1 move in trunk/LayoutTests

Unreviewed gardening. Rebaseline bidi-ignored-for-first-child-inline.html
which was failing on Chromium Mac after r142152.

  • platform/chromium-mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt: Renamed from LayoutTests/platform/chromium/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt.
6:11 PM Changeset in webkit [142217] by haraken@chromium.org
  • 9 edits in trunk/Source/WebCore

[V8] Move V8DOMWrapper::setNamedHiddenReference() to V8HiddenPropertyName.h
https://bugs.webkit.org/show_bug.cgi?id=109186

Reviewed by Adam Barth.

V8HiddenPropertyName.h is a right place for setNamedHiddenReference().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):

  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

  • bindings/v8/V8HiddenPropertyName.cpp:

(WebCore::V8HiddenPropertyName::hiddenReferenceName):
(WebCore::V8HiddenPropertyName::setNamedHiddenReference):
(WebCore):

  • bindings/v8/V8HiddenPropertyName.h:

(V8HiddenPropertyName):
(WebCore::V8HiddenPropertyName::V8HiddenPropertyName):

  • bindings/v8/custom/V8MessageChannelCustom.cpp:

(WebCore::V8MessageChannel::constructorCallbackCustom):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

5:42 PM Changeset in webkit [142216] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

Unreviewed, rolling out r142113.
http://trac.webkit.org/changeset/142113
https://bugs.webkit.org/show_bug.cgi?id=109244

tests started failing after r142081 was rolled out in r142166
(Requested by falken on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-07

  • inspector/profiler/memory-instrumentation-cached-images-expected.txt:
  • inspector/profiler/memory-instrumentation-cached-images.html:
  • inspector/profiler/memory-instrumentation-canvas-expected.txt:
  • inspector/profiler/memory-instrumentation-canvas.html:
5:40 PM Changeset in webkit [142215] by esprehn@chromium.org
  • 10 edits in trunk

getComputedStyle() doesn't report intermediate values during a transition of a pseudo element
https://bugs.webkit.org/show_bug.cgi?id=106535

Reviewed by Ojan Vafai.

Source/WebCore:

Element::computedStyle and CSSComputedStyleDeclaration::getPropertyCSSValue
should use the PseudoElement and it's renderer if they exist so that
querying the computed style while an animation is running returns
the intermediate values.

No new tests, updated existing tests.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::styledNode): Added, returns either the PseudoElement or the Node.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Updated to use styledNode.

  • css/CSSComputedStyleDeclaration.h:

(CSSComputedStyleDeclaration):

  • dom/Element.cpp:

(WebCore::Element::computedStyle): Check the PseudoElement, not just the cached pseudo style.

  • dom/ElementRareData.h:

(WebCore::ElementRareData::pseudoElement): Remove ASSERT_NOT_REACHED so passing other pseudos returns 0.

LayoutTests:

Update tests to also check getComputedStyle during animations and transitions.

  • fast/css-generated-content/pseudo-animation-expected.txt:
  • fast/css-generated-content/pseudo-animation.html:
  • fast/css-generated-content/pseudo-transition-expected.txt:
  • fast/css-generated-content/pseudo-transition.html:
5:28 PM Changeset in webkit [142214] by tkent@chromium.org
  • 4 edits in trunk

[Chromium-Android] Disable input[type=datetime]
https://bugs.webkit.org/show_bug.cgi?id=107614

Reviewed by Kentaro Hara.

Source/WebKit/chromium:

Reason:
http://lists.webkit.org/pipermail/webkit-dev/2013-January/023404.html

  • features.gypi:

Disable ENABLE_INPUT_TYPE_DATETIME because of a wrong UI.
We enable it for non-Android ports but the runtime flag for it is
disabled by default. The runtime flag is enabled only in DumpRenderTree.

LayoutTests:

  • platform/chromium/TestExpectations:

Tetsts in fast/forms/datetime/ fail.

5:23 PM Changeset in webkit [142213] by mark.lam@apple.com
  • 2 edits in trunk/Source/WebCore

Add a comment about how the SQLTransaction state machine works.
https://bugs.webkit.org/show_bug.cgi?id=109243.

Rubber stamped by Anders Carlsson.

No new tests.

  • Modules/webdatabase/SQLTransactionBackend.cpp:
5:22 PM Changeset in webkit [142212] by barraclough@apple.com
  • 11 edits in trunk/Source

PluginProcess should quit immediately if idle in response to low-memory notifications
https://bugs.webkit.org/show_bug.cgi?id=109103
<rdar://problem/12679827>

Reviewed by Darin Adler.

Source/WebCore:

This patch allows a process to set a custom callback for low memory warnings
(defaulting to the current behaviour, as implemented in releaseMemory).

MemoryPressureHandler::install is currently used for two purposes - it is
called when first initializing a low memory handler for a process, and also
used to reinstall the handler (on a delay) after the notification has occured.
Since reinstallation doesn't change the callback, split these behaviours out -
MemoryPressureHandler::initialize is added to initialization, and accepts a
custom callback, install in made private.

  • WebCore.exp.in:
    • Added export for releaseMemory.
  • platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::releaseMemory):

  • Added null implementation for non-Mac builds.
  • platform/MemoryPressureHandler.h:

(WebCore::MemoryPressureHandler::initialize):

  • distinguish initialization from reinstallations, allow handler to be set.

(MemoryPressureHandler):

  • Added m_lowMemoryHandler function pointer member variable.
  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::respondToMemoryPressure):

  • Call m_lowMemoryHandler instead of releaseMemory.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

  • MemoryPressureHandler::install is now called via MemoryPressureHandler::initialize.

(WebInstallMemoryPressureHandler):

  • MemoryPressureHandler::install is now called via MemoryPressureHandler::initialize.

Source/WebKit2:

PluginProcess now initializes a MemoryPressureHandler for the process, providing
a custom callback which will call terminate if appropriate (if the plugin is not
currently in use).

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::lowMemoryHandler):

  • Custom callback to terminate if appropriate.

(WebKit::PluginProcess::initializeProcess):

  • Initialize the MemoryPressureHandler.

(WebKit::PluginProcess::shouldTerminate):

  • This method now also needs to be callable in situations where it might return false.
  • PluginProcess/PluginProcess.h:

(PluginProcess):

  • Added declaration for lowMemoryHandler.
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

  • MemoryPressureHandler::install is now called via MemoryPressureHandler::initialize.
5:13 PM Changeset in webkit [142211] by jpfau@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] Unreviewed, skip crashing test

  • platform/mac/TestExpectations:
5:07 PM Changeset in webkit [142210] by roger_fong@apple.com
  • 4 edits in trunk/Source/WebKit

Unreviewed. Corrections the exports definition file.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
  • WebKit.vcproj/WebKitExports.def.in:
5:06 PM Changeset in webkit [142209] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] #ifndef NDEBUG is redundant for assertContextHasCorrectPrototype()
https://bugs.webkit.org/show_bug.cgi?id=109167

Reviewed by Andreas Kling.

Given that assertContextHasCorrectPrototype() is anyway empty in a release
build, we don't need to surround it with #ifndef NDEBUG.

No tests. No change in behavior.

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::assertContextHasCorrectPrototype):

  • bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolated):

4:59 PM Changeset in webkit [142208] by zoltan@webkit.org
  • 2 edits
    1 add
    5 deletes in trunk/LayoutTests

[CSS Regions] Turn selecting-text-through-different-region-flows test into a reftest
https://bugs.webkit.org/show_bug.cgi?id=109228

Reviewed by Eric Seidel.

Simplify and turn the test into a reftest, remove the unnecessary expected files.

  • fast/regions/selecting-text-through-different-region-flows-expected.html: Added.
  • fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
  • fast/regions/selecting-text-through-different-region-flows.html:
  • platform/chromium-linux/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
  • platform/chromium-mac-lion/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
  • platform/chromium-win/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
  • platform/chromium-win/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
  • platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
  • platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
  • platform/gtk/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
  • platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
  • platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
4:56 PM Changeset in webkit [142207] by commit-queue@webkit.org
  • 7 edits in trunk

Makefiles should work for arbitrary SDKs and architectures on Apple ports
https://bugs.webkit.org/show_bug.cgi?id=107863

Patch by David Farler <dfarler@apple.com> on 2013-02-07
Reviewed by Mark Rowe.

.:

  • Makefile:

Allow SDKROOT, ARCHS outside of $(ARGS).
Setting ARCHS => ONLY_ACTIVE_ARCH=NO.

  • Makefile.shared: options to webkitdirs based on SDKROOT
  • Source/Makefile: don't build WebKit2 for iOS

Tools:

  • DumpRenderTree/Makefile: SDKROOT=iphone* => -target All-iOS
  • Makefile: Only build some projects for iOS
4:51 PM Changeset in webkit [142206] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Chromium: Hang parsing bidi control chars on Mac OS X 10.6
https://bugs.webkit.org/show_bug.cgi?id=108877

This was broken a while ago by:

https://bugs.webkit.org/show_bug.cgi?id=83045

On 10.6, CoreText will not produce any runs covering the
Unicode BiDi RTL mark control char, which causes an infinite
loop in ComplexTextController::indexOfCurrentRun() due to no
run covering the character at offset 0.

This patch fixes that issue by finding the earliest run
explicitly via the minimum stringBegin() index instead of
relying on a run existing that covers offset 0.

Fixes hang on many BiDi wikipedia pages on Chromium/Mac10.6.
Chromium bug: http://crbug.com/167844

Source/WebCore:

New test in the same style as the harfbuzz-buffer-overrun.html
test (in the same folder).

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2013-02-07
Reviewed by Eric Seidel.

Test: fast/text/international/rtl-mark.html

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::indexOfCurrentRun):

LayoutTests:

New test in the same style as harfbuzz-buffer-overrun.html
in the same folder.

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2013-02-07
Reviewed by Eric Seidel.

  • fast/text/international/rtl-mark-expected.txt: Added.
  • fast/text/international/rtl-mark.html: Added.
4:37 PM Changeset in webkit [142205] by haraken@chromium.org
  • 12 edits
    2 adds in trunk

Implement FocusEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=109170

Reviewed by Adam Barth.

Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm

FocusEvent constructor should be implemented under a DOM4_EVENTS_CONSTRUCTOR
flag, which is enabled on Chromium and Safari.

Source/WebCore:

Test: fast/events/constructors/focus-event-constructor.html

  • dom/FocusEvent.cpp:

(WebCore::FocusEventInit::FocusEventInit):
(WebCore):
(WebCore::FocusEvent::FocusEvent):

  • dom/FocusEvent.h:

(FocusEventInit):
(WebCore):
(WebCore::FocusEvent::create):
(FocusEvent):

  • dom/FocusEvent.idl:
  • page/DOMWindow.idl:

LayoutTests:

  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/events/constructors/focus-event-constructor-expected.txt: Added.
  • fast/events/constructors/focus-event-constructor.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
4:35 PM Changeset in webkit [142204] by esprehn@chromium.org
  • 6 edits
    2 adds in trunk

HTML parser should queue MutationRecords for its operations
https://bugs.webkit.org/show_bug.cgi?id=89351

Reviewed by Eric Seidel.

Source/WebCore:

Generate mutation records inside the parser. This is done by using a
ChildListMutationScope in the ContainerNode::parser* methods and then
adding delivery before each <script> element would be processed by
the parser.

Test: fast/dom/MutationObserver/parser-mutations.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserRemoveChild):
(WebCore::ContainerNode::parserAppendChild):

  • html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::executeParsingBlockingScript):
(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::execute):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForLoad):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForStylesheets):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing):
(WebCore::HTMLScriptRunner::runScript):

LayoutTests:

Add new test mutation records in the parser and fix shadow-dom.html
test since it used setTimeout and sometimes could observe parser
mutations.

  • fast/dom/MutationObserver/parser-mutations-expected.txt: Added.
  • fast/dom/MutationObserver/parser-mutations.html: Added.
  • fast/dom/MutationObserver/shadow-dom-expected.txt:
  • fast/dom/MutationObserver/shadow-dom.html:
4:34 PM Changeset in webkit [142203] by roger_fong@apple.com
  • 8 edits in trunk

Unreviewed. More VS2010 WebKit solution touchups.

  • win/tools/vsprops/common.props:

Move an ignored warning from a project to common properties.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj:
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.filters:

Make WebKitExports.def.in be treated as a custom build file so that changes to it cause the exports to be rebuilt.

  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.filters:

Make JavaScriptCoreExports.def.in be treated as a custom build file so that changes to it cause the exports to be rebuilt.

4:30 PM Changeset in webkit [142202] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix FIXMEs in WindowFeatures.h
https://bugs.webkit.org/show_bug.cgi?id=109151

Reviewed by Adam Barth.

  1. FIXME: We can delete this constructor once V8 showModalDialog is changed to use DOMWindow.

This FIXME is not right. The WindowFeatures() constructor is used by
other ports too (e.g. WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp).
So we should remove the FIXME.

  1. FIXME: We can make these functions private non-member functions once V8 showModalDialog is changed to use DOMWindow.

Given that V8 now uses DOMWindow in showModalDialog(), we can make the
methods private.

No tests. No change in behavior.

  • page/WindowFeatures.h:

(WebCore):
(WebCore::WindowFeatures::WindowFeatures):
(WindowFeatures):

4:27 PM Changeset in webkit [142201] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix build warning after r142017
https://bugs.webkit.org/show_bug.cgi?id=109119

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-07
Reviewed by Alexey Proskuryakov.

Use UNUSED_PARAM macro to fix -Wunused-parameter build warning.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getPluginPath):

4:24 PM Changeset in webkit [142200] by abarth@webkit.org
  • 4 edits
    4 adds in trunk

fast/parser/document-write-noscript.html fails for threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=109237

Reviewed by Eric Seidel.

Source/WebCore:

If there are multiple calls to document.write in an external script, we
need to wait for them all to complete before invalidating the
speculative tokens. Instead of doing this when we unwind the
document.write call stack, we do this when we're about to resume
parsing after script execution.

Test: fast/parser/document-write-basic.html

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):

LayoutTests:

This tests basic document.write functionality. There doesn't appear to
be another fast/parser test that covers this basic case (although it's
convered in some more complicated test cases incidentally.)

  • fast/parser/document-write-basic-expected.txt: Added.
  • fast/parser/document-write-basic.html: Added.
4:18 PM Changeset in webkit [142199] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix build when compiling with css3-text and css3-conditional-rules feature flags enabled.
https://bugs.webkit.org/show_bug.cgi?id=109217

Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-02-07
Reviewed by Benjamin Poulain.

  • css/InspectorCSSOMWrappers.cpp:

(WebCore::InspectorCSSOMWrappers::collect):

4:06 PM Changeset in webkit [142198] by tkent@chromium.org
  • 5 edits
    6 adds in trunk

REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute
https://bugs.webkit.org/show_bug.cgi?id=109136

Patch by Keishi Hattori <keishi@webkit.org> on 2013-02-07
Reviewed by Kent Tamura.

Source/WebCore:

Calendar picker was using the "Clear" button to calculate the window width.
Since it doesn't exist when the input element has a required attribute,
it was throwing an error. This patch fixes the width calculating logic.

Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html

platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html

  • Resources/pagepopups/calendarPicker.css:

(.today-clear-area):

  • Resources/pagepopups/calendarPicker.js:

(CalendarPicker.prototype.fixWindowSize): Fixing the logic to calculate
the width. We don't want to use clear button because it doesn't exist
when a value is required.

LayoutTests:

  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.txt: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.txt: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html: Added.
  • platform/chromium/TestExpectations:
4:03 PM Changeset in webkit [142197] by tdanderson@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Flings should not bubble up to enclosing scrollables when main-thread touch scrolling
https://bugs.webkit.org/show_bug.cgi?id=108719

Reviewed by Eric Seidel.

In the event of a main-thread touch fling, dispatch a series of
GestureScrollUpdateWithoutPropagation events defined in
https://bugs.webkit.org/show_bug.cgi?id=108849 (instead of
GestureScrollUpdate events) so that the fling does not
propagate to enclosing scrollables.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::scrollBy):

3:59 PM Changeset in webkit [142196] by Lucas Forschler
  • 1 edit in branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/Skipped

Skip test -> <rdar://problem/12968012>

3:58 PM Changeset in webkit [142195] by tdanderson@chromium.org
  • 4 edits
    6 adds in trunk

Non-scrollable divs and non-scrollable iframes can scroll with touch
https://bugs.webkit.org/show_bug.cgi?id=109087

Reviewed by Eric Seidel.

Source/WebCore:

Tests: fast/events/touch/gesture/touch-gesture-noscroll-div.html

fast/events/touch/gesture/touch-gesture-noscroll-iframe.html

When finding a candidate for a scrollable node in
EventHandler::handleGestureScrollUpdate(), select the document node
if it is reached before any scrollable element when walking up the DOM
tree. Also ensure that calling RenderLayer::scrollBy() for a document
node does not result in scrolling if the element is not scrollable.

  • page/EventHandler.cpp:

(WebCore::closestScrollableNodeCandidate):
(WebCore::EventHandler::handleGestureScrollUpdate):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollBy):

LayoutTests:

Two new layout tests added to demonstrate that the changes to
RenderLayer::scrollBy() and closestScrollableNodeCandidate() in
EventHandler.cpp are both necessary to ensure that non-scrollable
divs and non-scrollable iframes cannot be scrolled with touch.

  • fast/events/touch/gesture/touch-gesture-noscroll-div-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-noscroll-div.html: Added.
  • fast/events/touch/gesture/touch-gesture-noscroll-iframe-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-noscroll-iframe.html: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-div-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-iframe-expected.txt: Added.
3:52 PM Changeset in webkit [142194] by mark.lam@apple.com
  • 1 edit
    4 adds in trunk/Source/WebCore

Introduce SQLTransactionBackend and SQLTransactionBackendSync [Part 2].
https://bugs.webkit.org/show_bug.cgi?id=109109.

Reviewed by Anders Carlsson.

Adding back the new SQLTransaction and SQLTransactionSync files.

No new tests.

  • Modules/webdatabase/SQLTransaction.cpp: Added.

(WebCore::SQLTransaction::create):
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::from):

  • Modules/webdatabase/SQLTransaction.h: Added.

(SQLTransaction):

  • Modules/webdatabase/SQLTransactionSync.cpp: Added.

(WebCore::SQLTransactionSync::create):
(WebCore::SQLTransactionSync::SQLTransactionSync):
(WebCore::SQLTransactionSync::from):

  • Modules/webdatabase/SQLTransactionSync.h: Added.

(SQLTransactionSync):

3:49 PM Changeset in webkit [142193] by mark.lam@apple.com
  • 16 edits
    4 moves in trunk/Source/WebCore

Introduce SQLTransactionBackend and SQLTransactionBackendSync.
https://bugs.webkit.org/show_bug.cgi?id=109109.

Reviewed by Anders Carlsson.

  • Renamed SQLTransaction and SQLTransactionSync to SQLTransactionBackend and SQLTransactionBackendSync respectively.
  • Added back SQLTransaction and SQLTransactionSync as new files, and have their classes extends their respective backends. This is a stop gap measure to keep things working until the front-end and back-end can be properly split. Note: these files will be committed in a subsequent commit to ensure that the patching goes smoothly.
  • Where needed, I made use of new SQLTransaction::from() and SQLTransactionSync::from() static methods that "get" the front-end transactions from the back-ends. This is also a stop gap measure to keep things working until the proper refactoring is complete.
  • Fixed up pre-existing style checker violations that are now detected on code that were touched during my renaming.
  • Added the back-end files to all the build files.

No new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/webdatabase/Database.cpp:

(WebCore::Database::scheduleTransactionStep):

  • Modules/webdatabase/Database.h:

(Database):

  • Modules/webdatabase/DatabaseBackend.h:

(DatabaseBackend):

  • Modules/webdatabase/DatabaseTask.cpp:

(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::DatabaseTransactionTask):

  • Modules/webdatabase/DatabaseTask.h:

(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::create):
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::transaction):
(DatabaseBackendAsync::DatabaseTransactionTask):

  • Modules/webdatabase/SQLTransaction.cpp: Removed.
  • Modules/webdatabase/SQLTransaction.h: Removed.
  • Modules/webdatabase/SQLTransactionBackend.cpp: Copied from Source/WebCore/Modules/webdatabase/SQLTransaction.cpp.

(WebCore::SQLTransactionBackend::SQLTransactionBackend):
(WebCore::SQLTransactionBackend::~SQLTransactionBackend):
(WebCore::SQLTransactionBackend::executeSQL):
(WebCore::SQLTransactionBackend::enqueueStatement):
(WebCore::SQLTransactionBackend::debugStepName):
(WebCore::SQLTransactionBackend::checkAndHandleClosedOrInterruptedDatabase):
(WebCore::SQLTransactionBackend::performNextStep):
(WebCore::SQLTransactionBackend::performPendingCallback):
(WebCore::SQLTransactionBackend::notifyDatabaseThreadIsShuttingDown):
(WebCore::SQLTransactionBackend::acquireLock):
(WebCore::SQLTransactionBackend::lockAcquired):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):
(WebCore::SQLTransactionBackend::deliverTransactionCallback):
(WebCore::SQLTransactionBackend::scheduleToRunStatements):
(WebCore::SQLTransactionBackend::runStatements):
(WebCore::SQLTransactionBackend::getNextStatement):
(WebCore::SQLTransactionBackend::runCurrentStatement):
(WebCore::SQLTransactionBackend::handleCurrentStatementError):
(WebCore::SQLTransactionBackend::deliverStatementCallback):
(WebCore::SQLTransactionBackend::deliverQuotaIncreaseCallback):
(WebCore::SQLTransactionBackend::postflightAndCommit):
(WebCore::SQLTransactionBackend::deliverSuccessCallback):
(WebCore::SQLTransactionBackend::cleanupAfterSuccessCallback):
(WebCore::SQLTransactionBackend::handleTransactionError):
(WebCore::SQLTransactionBackend::deliverTransactionErrorCallback):
(WebCore::SQLTransactionBackend::cleanupAfterTransactionErrorCallback):

  • Modules/webdatabase/SQLTransactionBackend.h: Copied from Source/WebCore/Modules/webdatabase/SQLTransaction.h.

(SQLTransactionBackend):

  • Modules/webdatabase/SQLTransactionBackendSync.cpp: Copied from Source/WebCore/Modules/webdatabase/SQLTransactionSync.cpp.

(WebCore::SQLTransactionBackendSync::SQLTransactionBackendSync):
(WebCore::SQLTransactionBackendSync::~SQLTransactionBackendSync):
(WebCore::SQLTransactionBackendSync::executeSQL):
(WebCore::SQLTransactionBackendSync::begin):
(WebCore::SQLTransactionBackendSync::execute):
(WebCore::SQLTransactionBackendSync::commit):
(WebCore::SQLTransactionBackendSync::rollback):

  • Modules/webdatabase/SQLTransactionBackendSync.h: Copied from Source/WebCore/Modules/webdatabase/SQLTransactionSync.h.

(SQLTransactionBackendSync):

  • Modules/webdatabase/SQLTransactionCoordinator.cpp:

(WebCore::getDatabaseIdentifier):
(WebCore::SQLTransactionCoordinator::processPendingTransactions):
(WebCore::SQLTransactionCoordinator::acquireLock):
(WebCore::SQLTransactionCoordinator::releaseLock):
(WebCore::SQLTransactionCoordinator::shutdown):

  • Modules/webdatabase/SQLTransactionCoordinator.h:

(SQLTransactionCoordinator):
(WebCore::SQLTransactionCoordinator::SQLTransactionCoordinator):
(CoordinationInfo):

  • Modules/webdatabase/SQLTransactionSync.cpp: Removed.
  • Modules/webdatabase/SQLTransactionSync.h: Removed.
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
3:45 PM Changeset in webkit [142192] by tkent@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Add a flag to enable native form validation message
https://bugs.webkit.org/show_bug.cgi?id=109134

Reviewed by Adam Barth.

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures): Add enableNativeValidationMessage and
isNativeValidationMessageEnabled.

  • src/WebRuntimeFeatures.cpp:

(WebKit): Add nativeValidationMessageEnabled.
(WebKit::WebRuntimeFeatures::enableNativeValidationMessage): Added.
(WebKit::WebRuntimeFeatures::isNativeValidationMessageEnabled): Addedd.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
Fill Page::PageClients::validationMessageClient if the flag is true.

3:42 PM Changeset in webkit [142191] by dino@apple.com
  • 6 edits in trunk/Source/WebCore

Use new speech bubble artwork for captions menu button
https://bugs.webkit.org/show_bug.cgi?id=109215

Reviewed by Eric Carlson.

Rather than call into RenderTheme to display this button, embed artwork
into the CSS. This means we can remove some uncalled methods in
RenderTheme.

  • css/mediaControlsQuickTime.css:

(video::-webkit-media-controls-toggle-closed-captions-button): New background image using SVG.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint): Don't call the specific painter for the CC button.

  • rendering/RenderTheme.h: Remove unused function.
  • rendering/RenderThemeMac.h: Ditto.
  • rendering/RenderThemeMac.mm: Ditto.
3:32 PM Changeset in webkit [142190] by Michelangelo De Simone
  • 4 edits
    2 adds in trunk

[CSS Shaders] Add the last blending step
https://bugs.webkit.org/show_bug.cgi?id=104012

Source/WebCore:

The resulting blended color in mix() is now weighted according to
the original element's backdrop alpha value.

Reviewed by Dean Jackson.

Test: css3/filters/custom/custom-filter-blend-fractional-destination-alpha.html

  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::rewriteMixFragmentShader):

LayoutTests:

Added a test to check the correct blending in presence of a transparent backdrop.

Reviewed by Dean Jackson.

  • css3/filters/custom/custom-filter-blend-fractional-destination-alpha-expected.html: Added.
  • css3/filters/custom/custom-filter-blend-fractional-destination-alpha.html: Added.
  • platform/mac/TestExpectations: This test is currently skipped on Mac for slight color

differences, please see the relevant bug: http://webkit.org/b/107487

3:29 PM Changeset in webkit [142189] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix two exports of WebCore symbols on iOS
https://bugs.webkit.org/show_bug.cgi?id=109238

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07
Reviewed by David Kilzer.

  • WebCore.exp.in: Export wkCTFontTransformGlyphs but not

wkCGContextDrawsWithCorrectShadowOffsets on iOS.

3:25 PM Changeset in webkit [142188] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Another temporary EWS bot fix. It'll totally work this time.

  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

3:20 PM Changeset in webkit [142187] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[CSS Exclusions] Ignore ExclusionPolygon edges above minLogicalIntervalTop
https://bugs.webkit.org/show_bug.cgi?id=107566

Patch by Hans Muller <hmuller@adobe.com> on 2013-02-07
Reviewed by David Hyatt.

Source/WebCore:

Improve ExclusionPolygon::firstIncludedIntervalLogicalTop() performance by only
creating offset edges for polygon edges that are below the horizontal minLogicalIntervalTop
line. In other words, don't bother creating offset edges that can't define the polygon's
first fit location.

Test: fast/exclusions/shape-inside/shape-inside-first-fit-004.html

  • rendering/ExclusionPolygon.cpp:

(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): Don't create offset edges for polygon edges above minLogicalIntervalTop.

LayoutTests:

Added a simple polygonal shape-inside test where only a subset of the polygon edges
should contribute to each line's offset edges.

  • fast/exclusions/shape-inside/shape-inside-first-fit-004-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-first-fit-004.html: Added.
3:19 PM Changeset in webkit [142186] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Improve logging of MediaPlayerPrivateAVFoundation Notifications.
https://bugs.webkit.org/show_bug.cgi?id=109223

Reviewed by Eric Carlson.

Convert the existing Notification enum to an expandable macro. Then add a
Logging-only function which stringifies the enums.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore):
(WebCore::notificationName):
(WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification):
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
3:17 PM Changeset in webkit [142185] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add layout test verifying role, subrole, and role description for all HTML elements and ARIA roles
https://bugs.webkit.org/show_bug.cgi?id=109027

Patch by James Craig <jcraig@apple.com> on 2013-02-07
Reviewed by Chris Fleizach.

New layout test verifies AXRole, AXSubrole, and AXRoleDescription for all HTML elements and ARIA roles.

  • platform/mac/accessibility/role-subrole-roledescription-expected.txt: Added.
  • platform/mac/accessibility/role-subrole-roledescription.html: Added.
3:11 PM Changeset in webkit [142184] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Objective-C API: testapi.mm should use ARC
https://bugs.webkit.org/show_bug.cgi?id=107838

Reviewed by Mark Rowe.

Removing the changes to the Xcode project file and moving the equivalent flags into
the ToolExecutable xcconfig file.

  • Configurations/ToolExecutable.xcconfig:
  • JavaScriptCore.xcodeproj/project.pbxproj:
2:53 PM Changeset in webkit [142183] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Fix an incorrect comment from r142163

Unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07

  • wtf/MainThread.h:

I accidentally copied PLATFORM(IOS) instead of USE(WEB_THREAD) for the #ifdef closing.

2:52 PM Changeset in webkit [142182] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Fix syntax error in runtests.py.

  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

2:44 PM Changeset in webkit [142181] by bfulgham@webkit.org
  • 2 edits
    1 delete in trunk/Source/JavaScriptCore

[Windows] Unreviewed Visual Studio 2010 build fixes after r142179.

  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in: Correct changed symbols
  • JavaScriptCore.vcxproj/JavaScriptCoreExports.def: Removed autogenerated file.
2:33 PM Changeset in webkit [142180] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Temporary fix for Win EWS bots.
Don't build DRT since it has already been built in the build step.

  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

2:08 PM Changeset in webkit [142179] by Martin Robinson
  • 11 edits in trunk

[GTK] Cleanup command-line defines
https://bugs.webkit.org/show_bug.cgi?id=109213

Reviewed by Xan Lopez.

.:

  • GNUmakefile.am: Remove references to flags that are now provided

by autotoolsconfig.h

  • configure.ac: Add new AC_DEFINE invocations for flags that were

before manually appended to the compiler CPPFLAGS and clump all
AC_DEFINE invocations together.

Source/WebCore:

  • GNUmakefile.am: Remove references to flags that are now handled

via autotoolsconfig.h.

Source/WebKit/gtk:

  • GNUmakefile.am: Remove references to flags that are now provided

by autotoolsconfig.h

Source/WebKit2:

  • GNUmakefile.am: Remove references to flags that are now

provided by autotoolsconfig.h.

Tools:

  • TestWebKitAPI/config.h: Include the autotoolsconfig.h header to pick

up defines from autoconf.

2:04 PM Changeset in webkit [142178] by rniwa@webkit.org
  • 2 edits in trunk/Tools

git.svn_revision doesn't fetch the same revision as svn.svn_revision
https://bugs.webkit.org/show_bug.cgi?id=108684

Reviewed by Dirk Pranke.

Always call git log on the checkout root.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.svn_revision):

1:58 PM Changeset in webkit [142177] by tsepez@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Binding Integrity crash in V8MediaStream::createWrapper
https://bugs.webkit.org/show_bug.cgi?id=109211

Reviewed by Adam Barth.

Patch suppresses a chrome crasher.

  • Modules/mediastream/MediaStream.idl:
1:55 PM Changeset in webkit [142176] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] decrease in-band caption advance notice interval
https://bugs.webkit.org/show_bug.cgi?id=109190

Reviewed by Simon Fraser.

No new tests, no observable change in behavior.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Request cues 2 seconds in advance.

1:49 PM Changeset in webkit [142175] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Patch for testing Win EWS bots.

  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

1:44 PM Changeset in webkit [142174] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding a failure expectation for a test in r142122.
  • platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r142149.
1:39 PM Changeset in webkit [142173] by gavinp@chromium.org
  • 31 edits
    3 deletes in trunk/Tools

Unreviewed, rolling out r142165.
http://trac.webkit.org/changeset/142165
https://bugs.webkit.org/show_bug.cgi?id=108466

Broke linux_aura builds.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTask.h:

(WebTaskList):

  • DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
  • DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebTestInterfaces):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestProxyBase):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:

(AccessibilityUIElementList):

  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:

(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):

  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:

(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):

  • DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:

(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):

  • DumpRenderTree/chromium/TestRunner/src/CppVariant.h:

(CppVariant):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):

  • DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:

(WebTestRunner::NativeKeyCodeForWindowsKeyCode):

  • DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:

(MockGrammarCheck::checkGrammarOfString):

  • DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:

(MockGrammarCheck):

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:

(append):
(isNotASCIIAlpha):
(MockSpellCheck::spellCheckWord):
(MockSpellCheck::initializeIfNeeded):

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:

(MockSpellCheck):

  • DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:

(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):

  • DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:

(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:

(TestPlugin):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner):
(WebTestRunner::TestRunner::setBackingScaleFactor):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:

(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):

  • DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):

  • DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:

(WebTestRunner):
(WebTestRunner::WebTaskList::WebTaskList):
(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):

  • DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
1:37 PM Changeset in webkit [142172] by commit-queue@webkit.org
  • 5 edits in trunk

[GTK][AC] Clutter required version up to 1.12
https://bugs.webkit.org/show_bug.cgi?id=109037

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-07
Reviewed by Martin Robinson.

.:

The clutter requried version is changed to 1.12.

  • configure.ac:

Source/WebCore:

Replace deprecated clutter apis with new ones.

No new tests, since this patch is minor refactoring.

  • platform/graphics/clutter/GraphicsLayerActor.cpp:

(graphicsLayerActorSetAnchorPoint):

  • platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::idleDestroy):
(WebCore::GraphicsLayerClutter::updateSublayerList):

1:34 PM Changeset in webkit [142171] by benjamin@webkit.org
  • 53 edits
    4 adds
    4 deletes in trunk

Move pauseAnimation/pauseTransition from TestRunner to Internals
https://bugs.webkit.org/show_bug.cgi?id=109107

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07
Reviewed by Anders Carlsson.

Source/WebCore:

Tests: animations/animation-internals-api-multiple-keyframes.html

animations/animation-internals-api.html

  • testing/Internals.cpp:

(WebCore::Internals::pauseAnimationAtTimeOnElement):
(WebCore):
(WebCore::Internals::pauseTransitionAtTimeOnElement):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

  • WebView/WebFrame.mm:
  • WebView/WebFramePrivate.h:

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
  • WebProcess/WebPage/WebFrame.cpp:
  • WebProcess/WebPage/WebFrame.h:

(WebFrame):

Tools:

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:
  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:
  • DumpRenderTree/gtk/TestRunnerGtk.cpp:
  • DumpRenderTree/mac/TestRunnerMac.mm:
  • DumpRenderTree/qt/TestRunnerQt.cpp:
  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

  • DumpRenderTree/win/TestRunnerWin.cpp:
  • DumpRenderTree/wx/TestRunnerWx.cpp:
  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  • WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

Change the tests with the following:
-Use the methods on Internals instead of TestRunner.
-Adapt the calls to pass a particular element instead of an ID.
-Remove feature detection. Having Internals implies having the feature.

  • animations/animation-hit-test-transform.html:
  • animations/animation-hit-test.html:
  • animations/animation-internals-api-expected.txt: Renamed from LayoutTests/animations/animation-drt-api-expected.txt.
  • animations/animation-internals-api-multiple-keyframes-expected.txt: Renamed from LayoutTests/animations/animation-drt-api-multiple-keyframes-expected.txt.
  • animations/animation-internals-api-multiple-keyframes.html: Renamed from LayoutTests/animations/animation-drt-api-multiple-keyframes.html.
  • animations/animation-internals-api.html: Renamed from LayoutTests/animations/animation-drt-api.html.
  • animations/change-keyframes-name.html:
  • animations/change-transform-style-during-animation.html:
  • animations/missing-from-to-transforms.html:
  • animations/missing-from-to.html:
  • animations/resources/animation-test-helpers.js:

(checkExpectedValue):
(startTest):

  • css3/calc/transitions-dependent.html:
  • fast/dom/shadow/transition-on-shadow-host-with-distributed-node.html:
  • transitions/opacity-transition-zindex.html:
  • transitions/resources/transition-test-helpers.js:

(expected):

  • transitions/transition-drt-api-delay.html:
  • transitions/transition-drt-api.html:
  • transitions/transition-hit-test-transform.html:
  • transitions/transition-hit-test.html:
1:26 PM Changeset in webkit [142170] by gavinp@chromium.org
  • 20 edits in trunk/Source/WebCore

Unreviewed, rolling out r142155.
http://trac.webkit.org/changeset/142155
https://bugs.webkit.org/show_bug.cgi?id=82888

cr/win build broke.

  • bindings/js/JSClipboardCustom.cpp:

(WebCore::JSClipboard::types):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::typesAccessorGetter):

  • dom/Clipboard.h:

(Clipboard):

  • platform/blackberry/ClipboardBlackBerry.cpp:

(WebCore::ClipboardBlackBerry::types):

  • platform/blackberry/ClipboardBlackBerry.h:

(ClipboardBlackBerry):

  • platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::types):

  • platform/chromium/ChromiumDataObject.h:

(ChromiumDataObject):

  • platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::types):

  • platform/chromium/ClipboardChromium.h:

(ClipboardChromium):

  • platform/efl/ClipboardEfl.cpp:

(WebCore::ClipboardEfl::types):

  • platform/efl/ClipboardEfl.h:

(ClipboardEfl):

  • platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::types):

  • platform/gtk/ClipboardGtk.h:

(ClipboardGtk):

  • platform/mac/ClipboardMac.h:

(ClipboardMac):

  • platform/mac/ClipboardMac.mm:

(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):

  • platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::types):

  • platform/qt/ClipboardQt.h:

(ClipboardQt):

  • platform/win/ClipboardWin.cpp:

(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):

  • platform/win/ClipboardWin.h:

(ClipboardWin):

1:20 PM Changeset in webkit [142169] by mikhail.pozdnyakov@intel.com
  • 22 edits in trunk/Source/WebKit2

[WK2][EFL] Removal of non coordinated graphics code path from WK2 EFL
https://bugs.webkit.org/show_bug.cgi?id=109165

Reviewed by Anders Carlsson.

Removed non coordinated graphics code path from WK2 EFL as it was not used by
anyone and caused a lot of preprocessor macros in the code making it less readable.

  • UIProcess/API/efl/EvasGLContext.cpp:
  • UIProcess/API/efl/EvasGLContext.h:

(WebKit::EvasGLContext::context):

  • UIProcess/API/efl/EvasGLSurface.cpp:
  • UIProcess/API/efl/EvasGLSurface.h:

(WebKit::EvasGLSurface::surface):

Removed also 'inline' and 'const' keywords from functions declaration,
as both EvasGLContext::context() and EvasGLSurface::surface()
are defined inside their classes and return mutable pointer.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::transformFromScene):
(EwkView::transformToScreen):
(EwkView::coordinatedGraphicsScene):
(EwkView::displayTimerFired):
(EwkView::scheduleUpdateDisplay): Renamed from EwkView::update().
(EwkView::exitAcceleratedCompositingMode):
(EwkView::handleEvasObjectCalculate):
(EwkView::takeSnapshot):

  • UIProcess/API/efl/EwkView.h:

(WebCore):
(EwkView):

  • UIProcess/API/efl/SnapshotImageGL.cpp:

(getImageSurfaceFromFrameBuffer):

  • UIProcess/API/efl/SnapshotImageGL.h:
  • UIProcess/API/efl/ewk_view.cpp:
  • UIProcess/efl/PageClientBase.cpp:

(WebKit::PageClientBase::setViewNeedsDisplay):
(WebKit::PageClientBase::updateAcceleratedCompositingMode):

  • UIProcess/efl/PageClientBase.h:

(PageClientBase):

  • UIProcess/efl/PageClientDefaultImpl.cpp:

(WebKit::PageClientDefaultImpl::didCommitLoad):
(WebKit::PageClientDefaultImpl::updateViewportSize):
(WebKit::PageClientDefaultImpl::didChangeViewportProperties):
(WebKit::PageClientDefaultImpl::didChangeContentsSize):
(WebKit::PageClientDefaultImpl::pageTransitionViewportReady):

  • UIProcess/efl/PageClientDefaultImpl.h:

(PageClientDefaultImpl):

  • UIProcess/efl/PageClientLegacyImpl.cpp:

(WebKit::PageClientLegacyImpl::didCommitLoad):
(WebKit::PageClientLegacyImpl::updateViewportSize):
(WebKit::PageClientLegacyImpl::didChangeViewportProperties):
(WebKit::PageClientLegacyImpl::didChangeContentsSize):
(WebKit::PageClientLegacyImpl::pageDidRequestScroll):
(WebKit::PageClientLegacyImpl::didRenderFrame):
(WebKit::PageClientLegacyImpl::pageTransitionViewportReady):

  • UIProcess/efl/PageClientLegacyImpl.h:

(PageClientLegacyImpl):

  • UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
(WebKit::PageLoadClientEfl::PageLoadClientEfl):

  • UIProcess/efl/PageLoadClientEfl.h:

(PageLoadClientEfl):

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
(WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):

  • UIProcess/efl/PageViewportControllerClientEfl.h:
  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):

1:13 PM Changeset in webkit [142168] by commit-queue@webkit.org
  • 11 edits
    8 adds in trunk

Add support for parsing of -webkit-background-blend-mode
https://bugs.webkit.org/show_bug.cgi?id=108547

Patch by Rik Cabanier <cabanier@adobe.com> on 2013-02-07
Reviewed by David Hyatt.

Source/WebCore:

Added parsing and general CSS handling of -webkit-background-blend-mode per
https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#background-blend-mode

Tests: css3/compositing/background-blend-mode-property-parsing.html

css3/compositing/background-blend-mode-property.html

  • css/CSSComputedStyleDeclaration.cpp: Built value for getComputedStyle.

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp: Parsed and stored value of -webkit-background-blend-mode.

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillProperty):

  • css/CSSProperty.cpp: Listed -webkit-background-blend-mode as a non-inherited property.

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in: Added -webkit-background-blend-mode as a CSS property.
  • css/CSSToStyleMap.cpp: Mapped background blend mode from CSS value to enum.

(WebCore::CSSToStyleMap::mapFillBlendMode):
(WebCore):

  • css/CSSToStyleMap.h: Added function declaration 'mapFillBlendMode'.

(CSSToStyleMap):

  • css/StyleBuilder.cpp: Set up propery handler for -webkit-background-blend-mode.

(WebCore::StyleBuilder::StyleBuilder):

  • rendering/style/FillLayer.cpp: Added code to store and retrieve the blend mode from a layer.

(WebCore::FillLayer::FillLayer):
(WebCore::FillLayer::operator=):
(WebCore::FillLayer::operator==):
(WebCore::FillLayer::fillUnsetProperties):

  • rendering/style/FillLayer.h: Added function definitions to manage blend mode in a layer.

(WebCore::FillLayer::blendMode):
(WebCore::FillLayer::isBlendModeSet):
(WebCore::FillLayer::setBlendMode):
(WebCore::FillLayer::clearBlendMode):
(WebCore::FillLayer::initialFillBlendMode):
(FillLayer):

LayoutTests:

Added parsing and general CSS handling of -webkit-background-blend-mode per
https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#background-blend-mode

  • css3/compositing/background-blend-mode-property-expected.txt: Added.
  • css3/compositing/background-blend-mode-property-parsing-expected.txt: Added.
  • css3/compositing/background-blend-mode-property-parsing.html: Added.
  • css3/compositing/background-blend-mode-property.html: Added.
  • css3/compositing/script-tests/background-blend-mode-property-parsing.js: Added.

(jsWrapperClass):
(shouldBeType):
(testBlendModeRule):

  • css3/compositing/script-tests/background-blend-mode-property.js: Added.

(testblendmode):

  • css3/compositing/background-blend-mode-property-expected.txt: Added.
  • css3/compositing/background-blend-mode-property-parsing-expected.txt: Added.
  • css3/compositing/background-blend-mode-property-parsing.html: Added.
  • css3/compositing/background-blend-mode-property.html: Added.
  • css3/compositing/script-tests/background-blend-mode-property-parsing.js: Added.

(jsWrapperClass):
(shouldBeType):
(testBlendModeRule):

  • css3/compositing/script-tests/background-blend-mode-property.js: Added.

(testblendmode):

  • platform/chromium/css3/compositing/background-blend-mode-property-expected.txt: Added.
  • platform/chromium/css3/compositing/background-blend-mode-property-parsing-expected.txt: Added.
1:10 PM Changeset in webkit [142167] by gavinp@chromium.org
  • 6 edits
    2 deletes in trunk

Unreviewed, rolling out r142142.
http://trac.webkit.org/changeset/142142
https://bugs.webkit.org/show_bug.cgi?id=109154

Source/WebCore:

Mac expectations were not right. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio-leak-test.html and http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio.html .

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._registerShortcuts):

LayoutTests:

Mac expectations were not right. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Feditor%2Ftext-editor-home-button.html

  • inspector/editor/text-editor-home-button-expected.txt: Removed.
  • inspector/editor/text-editor-home-button.html: Removed.
  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
1:03 PM Changeset in webkit [142166] by gavinp@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r142081.
http://trac.webkit.org/changeset/142081
https://bugs.webkit.org/show_bug.cgi?id=109146

The patch caused a crash in inspector-protocol/nmi-webaudio*.html .

See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio-leak-test.html and http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio.html .

  • dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

  • platform/PlatformMemoryInstrumentation.cpp:

(WebCore):

12:58 PM Changeset in webkit [142165] by jochen@chromium.org
  • 31 edits
    3 copies in trunk/Tools

[chromium] turn TestRunner library into a component build
https://bugs.webkit.org/show_bug.cgi?id=108466

Reviewed by Adam Barth.

To achieve this, we need to drop all dependencies on WTF.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTask.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
  • DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:

(AccessibilityUIElementList):

  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:

(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):

  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:

(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):

  • DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:

(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):

  • DumpRenderTree/chromium/TestRunner/src/CppVariant.h:

(CppVariant):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):

  • DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:

(WebTestRunner::NativeKeyCodeForWindowsKeyCode):

  • DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:

(WebTestRunner::MockGrammarCheck::checkGrammarOfString):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:

(WebTestRunner):
(MockGrammarCheck):

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:

(WebTestRunner::MockSpellCheck::spellCheckWord):
(WebTestRunner::MockSpellCheck::initializeIfNeeded):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:

(MockSpellCheck):

  • DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:

(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):

  • DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.

(isASCIIAlpha):
(isNotASCIIAlpha):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:

(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:

(TestPlugin):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner::TestRunner::deliverWebIntent):
(WebTestRunner::TestRunner::setBackingScaleFactor):
(WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
(WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
(WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
(WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:

(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):

  • DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):

  • DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:

(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):

  • DumpRenderTree/chromium/TestRunner/src/config.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
12:50 PM Changeset in webkit [142164] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

[CSS Exclusions] shape-inside does not properly handle padding or border
https://bugs.webkit.org/show_bug.cgi?id=102715

Patch by Bear Travis <betravis@adobe.com> on 2013-02-07
Reviewed by David Hyatt.

Source/WebCore:

This patch positions the exclusion shape based on the value of the css box sizing
property. Geometry calculations happen in the shape coordinate space. For layout,
these coordinates are translated to the border-box coordinate system by adding
the appropriate offsets.

Test: fast/exclusions/shape-inside/shape-inside-box-sizing.html

  • rendering/ExclusionShapeInfo.cpp:

(WebCore::::computedShape): Pass m_shapeLogicalWidth to the exclusion shape
geometry code.

  • rendering/ExclusionShapeInfo.h:

(WebCore::ExclusionShapeInfo::setShapeSize): Adjust block layout dimensions to
shape dimensions when checking to see if the shape geometry must be recalculated.
(WebCore::ExclusionShapeInfo::shapeLogicalTop): Account for layout offsets.
(WebCore::ExclusionShapeInfo::shapeLogicalBottom): Ditto.
(WebCore::ExclusionShapeInfo::shapeLogicalLeft): Ditto.
(WebCore::ExclusionShapeInfo::shapeLogicalRight): Ditto.
(WebCore::ExclusionShapeInfo::logicalTopOffset): Return the offset from the logical
top of the border box to the logical top of the shape.
(WebCore::ExclusionShapeInfo::logicalLeftOffset): Return the offset from the logical
left of the border box to the logical left of the shape.
(ExclusionShapeInfo):

  • rendering/ExclusionShapeInsideInfo.cpp:

(WebCore::ExclusionShapeInsideInfo::computeSegmentsForLine): Adjust line top to
be in shape coordinates.
(WebCore::ExclusionShapeInsideInfo::adjustLogicalLineTop): Ditto.

  • rendering/ExclusionShapeInsideInfo.h:

(WebCore::ExclusionShapeInsideInfo::lineOverlapsShapeBounds): Use consistent
coordinate system (border box) to test for whether a line overlaps a shape.
(WebCore::ExclusionShapeInsideInfo::logicalLineTop): Include the logical offset
from the border box.
(WebCore::ExclusionShapeInsideInfo::logicalLineBottom): Ditto.

LayoutTests:

Test that borders and padding are properly accounted for when laying out text in
a shape inside.

  • fast/exclusions/shape-inside/shape-inside-bottom-edge.html: Modified to no longer

use padding.

  • fast/exclusions/shape-inside/shape-inside-box-sizing-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-box-sizing.html: Added.
12:35 PM Changeset in webkit [142163] by benjamin@webkit.org
  • 8 edits in trunk/Source

Upstream iOS isWebThread() and isUIThread()
https://bugs.webkit.org/show_bug.cgi?id=109130

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07
Reviewed by Sam Weinig.

Source/WebCore:

  • bindings/objc/WebScriptObject.mm:

(+[WebScriptObject initialize]):

  • platform/mac/SharedBufferMac.mm:

(+[WebCoreSharedBufferData initialize]):
#ifdef out the legacy initialization as it is not correct when
using a WebThread.

Source/WTF:

On iOS, it is sometimes necessary to differenciate the thread running WebCore,
and the thread running the UI. This patch upstream those functions.

  • wtf/MainThread.cpp:
  • wtf/MainThread.h:

Disable the legacy initializer as it is incorrect when using the WebThread to run WebCore.
(WTF::isWebThread):
(WTF::isUIThread):
Return true when the current thread is the Web/UI thread.

  • wtf/mac/MainThreadMac.mm:

(WTF::isUIThread):
(WTF::isWebThread):

  • wtf/text/AtomicString.cpp:

(WTF::AtomicStringTable::create):
Use the newly added methods.

12:22 PM Changeset in webkit [142162] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

DFG::ByteCodeParser should do surgical constant folding to reduce load on the optimization fixpoint
https://bugs.webkit.org/show_bug.cgi?id=109000

Reviewed by Oliver Hunt.

Previously our source parser's ASTBuilder did some surgical constant folding, but it
didn't cover some cases. It was particularly incapable of doing constant folding for
cases where we do some minimal loop peeling in the bytecode generator - since it
didn't "see" those constants prior to the peeling. Example:

for (var i = 0; i < 4; ++i)

things;

This will get peeled just a bit by the bytecode generator, so that the "i < 4" is
duplicated both at the top of the loop and the bottom. This means that we have a
constant comparison: "0 < 4", which the bytecode generator emits without any further
thought.

The DFG optimization fixpoint of course folds this and simplifies the CFG
accordingly, but this incurs a compile-time cost. The purpose of this change is to
do some surgical constant folding in the DFG's bytecode parser, so that such
constructs reduce load on the CFG simplifier and the optimization fixpoint. The goal
is not to cover all cases, since the DFG CFA and CFG simplifier have a powerful
sparse conditional constant propagation that we can always fall back on. Instead the
goal is to cover enough cases that for common small functions we don't have to
perform such transformations, thereby reducing compile times.

This also refactors m_inlineStackEntry->m_inlineCallFrame to be a handy method call
and also adds the notion of a TriState-based JSValue::pureToBoolean(). Both of these
things are used by the folder.

As well, care has been taken to make sure that the bytecode parser only does folding
that is statically provable, and that doesn't arise out of speculation. This means
we cannot fold on data flow that crosses inlining boundaries. On the other hand, the
folding that the bytecode parser uses doesn't require phantoming anything. Such is
the trade-off: for anything that we do need phantoming, we defer it to the
optimization fixpoint.

Slight SunSpider speed-up.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::flushArgumentsAndCapturedVariables):
(JSC::DFG::ByteCodeParser::toInt32):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::inlineCallFrame):
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::canFold):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::getScope):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

  • dfg/DFGNode.h:

(JSC::DFG::Node::isStronglyProvedConstantIn):
(Node):

  • runtime/JSCJSValue.h:
  • runtime/JSCJSValueInlines.h:

(JSC::JSValue::pureToBoolean):
(JSC):

12:02 PM Changeset in webkit [142161] by vivek.vg@samsung.com
  • 6 edits in trunk/Source/WebCore

Web Inspector: CPU pegged when inspecting LocalStorage that mutates.
https://bugs.webkit.org/show_bug.cgi?id=107937

Reviewed by Yury Semikhatsky.

The DOM storage agent will fire an event to the frontend based on the action
performed on the storage. Based on this action, the front-end will just add/update/remove
the entry in the view. This enhances the front-end responsiveness as the round trip
for fetching the storage entries has been eliminated.

Existing test: LayoutTests/inspector/storage-panel-dom-storage-update.html should verify the change

  • inspector/Inspector.json:
  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):

  • inspector/front-end/DOMStorage.js:

(WebInspector.DOMStorageModel.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageModel.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageModel.prototype._domStorageItemAdded):
(WebInspector.DOMStorageModel.prototype._domStorageItemUpdated):
(WebInspector.DOMStorageDispatcher.prototype.domStorageItemsCleared):
(WebInspector.DOMStorageDispatcher.prototype.domStorageItemRemoved):
(WebInspector.DOMStorageDispatcher.prototype.domStorageItemAdded):
(WebInspector.DOMStorageDispatcher.prototype.domStorageItemUpdated):

  • inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView):
(WebInspector.DOMStorageItemsView.prototype.wasShown):
(WebInspector.DOMStorageItemsView.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageItemsView.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageItemsView.prototype._domStorageItemAdded):
(WebInspector.DOMStorageItemsView.prototype._domStorageItemUpdated):
(WebInspector.DOMStorageItemsView.prototype._update):
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
(WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
(WebInspector.DOMStorageItemsView.prototype._editingCallback):
(WebInspector.DOMStorageItemsView.prototype._deleteCallback):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._showDOMStorage.get if):
(WebInspector.ResourcesPanel.prototype._showDOMStorage):

11:58 AM Changeset in webkit [142160] by weinig@apple.com
  • 20 edits in trunk/Source/WebKit2

Make WebPageProxy and sub-objects MessageReceivers
https://bugs.webkit.org/show_bug.cgi?id=108785

Reviewed by Anders Carlsson.

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:

(WebKit::CoordinatedLayerTreeHostProxy::CoordinatedLayerTreeHostProxy):
(WebKit::CoordinatedLayerTreeHostProxy::~CoordinatedLayerTreeHostProxy):

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:

(CoordinatedLayerTreeHostProxy):

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
  • UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::~DrawingAreaProxy):
(WebKit::DrawingAreaProxy::contentsRect):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::setVisibleContentsRect):

  • UIProcess/DrawingAreaProxy.messages.in:
  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::setVisibleContentsRect):

  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/WebFullScreenManagerProxy.cpp:

(WebKit::WebFullScreenManagerProxy::WebFullScreenManagerProxy):

  • UIProcess/WebFullScreenManagerProxy.h:

(WebFullScreenManagerProxy):

  • UIProcess/WebFullScreenManagerProxy.messages.in:
  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::invalidate):

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/WebInspectorProxy.messages.in:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::inspector):
(WebKit::WebPageProxy::fullScreenManager):
(WebKit::WebPageProxy::processDidCrash):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):

  • UIProcess/mac/WebFullScreenManagerProxyMac.mm:

(WebKit::WebFullScreenManagerProxy::invalidate):

11:48 AM Changeset in webkit [142159] by commit-queue@webkit.org
  • 35 edits in trunk/Source/WebCore

[v8] move persistent::new and ::dispose into same class
https://bugs.webkit.org/show_bug.cgi?id=109065

Patch by Dan Carney <dcarney@google.com> on 2013-02-07
Reviewed by Adam Barth.

No new tests. No change in functionality.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::createWrapper):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::createWrapper):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::createWrapper):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):
(WebCore::V8TestEventConstructor::createWrapper):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::createWrapper):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::createWrapper):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::constructorCallback):
(WebCore::V8TestInterface::createWrapper):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::createWrapper):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):
(WebCore::V8TestNamedConstructor::createWrapper):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::constructorCallback):
(WebCore::V8TestNode::createWrapper):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::constructorCallback):
(WebCore::V8TestObj::createWrapper):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::constructor1Callback):
(WebCore::V8TestOverloadedConstructors::constructor2Callback):
(WebCore::V8TestOverloadedConstructors::constructor3Callback):
(WebCore::V8TestOverloadedConstructors::constructor4Callback):
(WebCore::V8TestOverloadedConstructors::createWrapper):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
(WebCore::V8TestSerializedScriptValueInterface::createWrapper):

  • bindings/v8/DOMDataStore.cpp:
  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::setWrapper):
(DOMDataStore):
(WebCore::DOMDataStore::set):
(WebCore::DOMDataStore::setWrapperInObject):

  • bindings/v8/DOMWrapperMap.h:

(WebCore::DOMWrapperMap::get):
(WebCore::DOMWrapperMap::set):
(WebCore::DOMWrapperMap::removeAndDispose):
(WebCore::DOMWrapperMap::defaultWeakCallback):

  • bindings/v8/ScriptWrappable.h:

(WebCore::ScriptWrappable::wrapper):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::reportMemoryUsage):
(ScriptWrappable):
(WebCore::ScriptWrappable::disposeWrapper):
(WebCore::ScriptWrappable::weakCallback):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow):

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):
(WebCore::V8DOMWrapper::associateObjectWithWrapper):

  • bindings/v8/V8NPObject.cpp:

(WebCore::weakNPObjectCallback):
(WebCore::createV8ObjectForNPObject):
(WebCore::forgetV8ObjectForNPObject):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::initializeContextIfNeeded):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WrapperConfiguration):
(WebCore::WrapperConfiguration::configureWrapper):
(WebCore::buildWrapperConfiguration):

  • bindings/v8/custom/V8ArrayBufferCustom.cpp:

(WebCore::V8ArrayBuffer::constructorCallbackCustom):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::wrapArrayBufferView):
(WebCore::constructWebGLArray):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallbackCustom):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCallbackCustom):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallbackCustom):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

  • bindings/v8/custom/V8IntentCustom.cpp:

(WebCore::V8Intent::constructorCallbackCustom):

  • bindings/v8/custom/V8MessageChannelCustom.cpp:

(WebCore::V8MessageChannel::constructorCallbackCustom):

  • bindings/v8/custom/V8MutationObserverCustom.cpp:

(WebCore::V8MutationObserver::constructorCallbackCustom):

  • bindings/v8/custom/V8WebKitPointCustom.cpp:

(WebCore::V8WebKitPoint::constructorCallbackCustom):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::constructorCallbackCustom):

11:31 AM Changeset in webkit [142158] by zandobersek@gmail.com
  • 7 edits in trunk

[Autotools] Remove uses of Automake FARSTREAM_(CFLAGS|LIBS) variables, USE_FARSTREAM conditional
https://bugs.webkit.org/show_bug.cgi?id=109198

Reviewed by Martin Robinson.

.:

  • GNUmakefile.am: The USE_FARSTREAM conditional is being removed while the WTF_USE_FARSTREAM

define is currently a no-op.

  • configure.ac: Don't set the Automake conditional as it's currently not needed due

to checking for Farstream dependency being removed in r142005.

Source/WebCore:

  • GNUmakefile.am: Remove FARSTREAM_CFLAGS variable, it's not set to anything.

Source/WebKit2:

  • GNUmakefile.am: Remove the FARSTREAM_(CFLAGS|LIBS) variables, they're

not set to anything.

11:19 AM Changeset in webkit [142157] by kenneth@webkit.org
  • 8 edits in trunk/Source/WebKit2

[WK2][EFL] Add WKView methods related to background drawing
https://bugs.webkit.org/show_bug.cgi?id=109159

Reviewed by Anders Carlsson.

  • UIProcess/API/C/efl/WKView.cpp:

(WKViewSetDrawsBackground):
(WKViewGetDrawsBackground):
(WKViewSetDrawsTransparentBackground):
(WKViewGetDrawsTransparentBackground):

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::setDrawsBackground):
(WebKit):
(WebKit::WebView::drawsBackground):
(WebKit::WebView::setDrawsTransparentBackground):
(WebKit::WebView::drawsTransparentBackground):

  • UIProcess/efl/WebView.h:

(WebView):

  • UIProcess/API/C/efl/WKView.h:

New methods added

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::displayTimerFired):
(EwkView::handleEvasObjectColorSet):

  • UIProcess/API/efl/EwkView.h:

(EwkView):

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_draws_page_background_set):

Remove the unneeded m_setDrawsBackground and replace
it with the WKView setting.

11:04 AM Changeset in webkit [142156] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Do not check enum's casing for WebKit2 C API.
https://bugs.webkit.org/show_bug.cgi?id=109128

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-02-07
Reviewed by Kenneth Rohde Christiansen.

Add "-readability/enum_casing" for WebKit2 C APIs because we use word
which starts with non-capital letter 'k' for types of enums.

  • Scripts/webkitpy/style/checker.py:
11:00 AM Changeset in webkit [142155] by Vineet
  • 20 edits in trunk/Source/WebCore

Consider replacing return type of Clipboard::types() from ListHashSet<String> to Vector<String>
https://bugs.webkit.org/show_bug.cgi?id=82888

Reviewed by Kentaro Hara.

As part of removing custom bindings of types Array Clipboard::types() needs to return
Vector<String> than ListHashSet<String>

No new tests. Existing test should pass with this change as no behavoural changes.

  • bindings/js/JSClipboardCustom.cpp: Replace data type from ListHashSet<> to Vector<>.

(WebCore::JSClipboard::types):

  • bindings/v8/custom/V8ClipboardCustom.cpp: Ditto.

(WebCore::V8Clipboard::typesAccessorGetter): Ditto.

  • dom/Clipboard.h: Ditto.
  • platform/blackberry/ClipboardBlackBerry.cpp: Ditto.

(WebCore::ClipboardBlackBerry::types):

  • platform/blackberry/ClipboardBlackBerry.h: Ditto.
  • platform/chromium/ChromiumDataObject.cpp: Ditto.

(WebCore::ChromiumDataObject::types):

  • platform/chromium/ChromiumDataObject.h: Ditto.
  • platform/chromium/ClipboardChromium.cpp: Ditto.

(WebCore::ClipboardChromium::types):

  • platform/chromium/ClipboardChromium.h: Ditto.
  • platform/efl/ClipboardEfl.cpp: Ditto.

(WebCore::ClipboardEfl::types):

  • platform/efl/ClipboardEfl.h: Ditto.
  • platform/gtk/ClipboardGtk.cpp: Ditto.

(WebCore::ClipboardGtk::types):

  • platform/gtk/ClipboardGtk.h: Ditto.
  • platform/mac/ClipboardMac.h: Ditto.
  • platform/mac/ClipboardMac.mm: Ditto.

(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):

  • platform/qt/ClipboardQt.cpp: Ditto.

(WebCore::ClipboardQt::types):

  • platform/qt/ClipboardQt.h: Ditto.
  • platform/win/ClipboardWin.cpp: Ditto.

(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):

  • platform/win/ClipboardWin.h: Ditto.
10:57 AM Changeset in webkit [142154] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] StringCache::m_stringCache should be HashMap<StringImpl*, Persistent<String>>
https://bugs.webkit.org/show_bug.cgi?id=109123

Reviewed by Adam Barth.

Currently StringCache::m_stringCache is implemented as
HashMap<StringImpl*, v8::String*>. Given that v8::String*
can change when a GC is triggered, it is dangerous to store a raw pointer.
We should use HashMap<StringImpl*, v8::Persistent<v8::String>> instead.

This is a possible fix for an IndexedDB crash (https://bugs.webkit.org/show_bug.cgi?id=105363),
although I'm not sure if this patch fixes the crash. (I couldn't reproduce the crash.)

No tests. This change highly depends on GC behavior and thus it is
difficult to make a reliable test case.

  • bindings/v8/V8ValueCache.cpp:

(WebCore::makeExternalString):

  • bindings/v8/V8ValueCache.h:

(StringCache):

10:49 AM Changeset in webkit [142153] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] EWK2UnitTestBase.ewk_view_page_contents_get API test is sometimes failing
https://bugs.webkit.org/show_bug.cgi?id=108634

Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-07
Reviewed by Alexey Proskuryakov.

Use more robust data validation in EWK2UnitTestBase.ewk_view_page_contents_get
so that the test passes consistently. The issue was that the header before the
data includes the current date. Depending on the date, the data may start at a
different index in the returned string. Instead of hardcoding the data start
index in the test, we now use String::contains().

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(PageContentsCallback):
(TEST_F):

10:48 AM Changeset in webkit [142152] by robert@webkit.org
  • 9 edits
    4 adds in trunk

CSS 2.1 failure: floats-149 fails
https://bugs.webkit.org/show_bug.cgi?id=95772

Reviewed by David Hyatt.

Source/WebCore:

Treat inlines that contain nothing but empty inlines as empty too so that they get a linebox.

Tests: fast/inline/inline-with-empty-inline-children.html

css2.1/20110323/floats-149.htm

  • rendering/InlineIterator.h:

(WebCore::isEmptyInline):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Now that empty inlines get a linebox any out-of-flow
objects inside an empty inline (on a line that is otherwise empty) won't get positioned while skipping
through leading whitespace.

LayoutTests:

  • css2.1/20110323/floats-149-expected.html: Added.
  • css2.1/20110323/floats-149.htm: Added.
  • fast/inline/inline-with-empty-inline-children-expected.txt: Added.
  • fast/inline/inline-with-empty-inline-children.html: Added.
  • platform/chromium-win/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
10:39 AM Changeset in webkit [142151] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Compile fix after r141981
https://bugs.webkit.org/show_bug.cgi?id=109184

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-02-07
Reviewed by Brent Fulgham.

  • platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::loadResourceSynchronously):

10:24 AM Changeset in webkit [142150] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[BlackBerry] Cookie database isn't loaded into memory in some rare cases
https://bugs.webkit.org/show_bug.cgi?id=109202
PR 286189

Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-02-07
Reviewed by Yong Li.
Internally Reviewed by Konrad Piascik.

If a get/setCookie call is made before the database is loaded, or if there's some
kind of error that causes the loading of the database to fail in the constructor
of CookieManager, the browser will get into a state where it seems like cookie is
permanenty disabled.

Instead of logging the errors and redispatching the setCookie, we should do a force sync
to load the cookie database before continuing.

Since the bug is so difficult to reproduce (I never did so myself), I did the follow test
to make sure the code path is correct:
1) Make sure original implementation is retained - open and loading done in the constructor
2) Removed opening and loading in constructor, the new calls in get/setcookies loaded the db just fine (although with
an initial lag because we are blocking WKT while performing SQLite options).
3) Removed loading in constructor, the new calls loaded the db just fine.

  • platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:

(WebCore::CookieDatabaseBackingStore::openAndLoadDatabaseSynchronously):
(WebCore):

  • platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:

(CookieDatabaseBackingStore):

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::setCookies):
(WebCore::CookieManager::getCookie):
(WebCore::CookieManager::generateHtmlFragmentForCookies):
(WebCore::CookieManager::getRawCookies):

10:21 AM Changeset in webkit [142149] by mvujovic@adobe.com
  • 3 edits
    5 moves
    1 add
    2 deletes in trunk

[CSS Shaders] Add WebKitCSSFilterRule to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=109082

Source/WebCore:

Reviewed by Dean Jackson.

Add an entry for WebKitCSSFilterRuleConstructor in DOMWindow.idl.

Tests: css3/filters/custom-with-at-rule-syntax/parsing-at-rule-invalid.html

css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid.html

  • page/DOMWindow.idl:

LayoutTests:

Move the at-rule parsing tests to the recently added folder named
"custom-with-at-rule-parsing".

Remove the "custom-filter" prefix from the test filenames to
match the new convention.

Update the tests to use the "shouldHaveConstructor" JS helper function instead of the
"shouldBeType" JS helper function. Among other things, using "shouldHaveConstructor" tests
that window.WebKitCSSFilterRule is defined. "shouldHaveConstructor" has the same
behavior in JSC and V8, unlike "shouldBeType". Therefore, remove the Chromium-specific text
expectation file that was previously needed for "shouldBeType".

Reviewed by Dean Jackson.

  • css3/filters/custom-with-at-rule-syntax/parsing-at-rule-invalid-expected.txt: Renamed from LayoutTests/css3/filters/custom/custom-filter-parsing-at-rule-invalid-expected.txt.
  • css3/filters/custom-with-at-rule-syntax/parsing-at-rule-invalid.html: Renamed from LayoutTests/css3/filters/custom/custom-filter-parsing-at-rule-invalid.html.
  • css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid-expected.txt: Added.
  • css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid.html: Renamed from LayoutTests/css3/filters/custom/custom-filter-parsing-at-rule-valid.html.
  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-at-rule-invalid.js: Renamed from LayoutTests/css3/filters/script-tests/custom-filter-parsing-at-rule-invalid.js.

(testInvalidFilterAtRule):

  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-at-rule-valid.js: Renamed from LayoutTests/css3/filters/script-tests/custom-filter-parsing-at-rule-valid.js.

(testFilterAtRule):
(testNestedRules):
(checkRule):

  • css3/filters/custom/custom-filter-parsing-at-rule-valid-expected.txt: Removed.
  • platform/chromium/css3/filters/custom/custom-filter-parsing-at-rule-valid-expected.txt: Removed.
10:14 AM Changeset in webkit [142148] by vsevik@chromium.org
  • 5 edits in trunk

Web Inspector: Remove unused workspace field from NetworkUISourceCodeProvider
https://bugs.webkit.org/show_bug.cgi?id=109201

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider):

  • inspector/front-end/inspector.js:

LayoutTests:

  • inspector/debugger/network-uisourcecode-provider.html:
10:12 AM Changeset in webkit [142147] by jberlin@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r142003): Duplicate "Unknown" strings in LocalizedStrings.cpp not distinguished
by key
https://bugs.webkit.org/show_bug.cgi?id=109196

Reviewed by Eric Carlson.

  • English.lproj/Localizable.strings:

Updated for the changes.

  • platform/LocalizedStrings.cpp:

(WebCore::unknownFileSizeText):
Add a key.
(WebCore::textTrackNoLabelText):
Ditto.

10:04 AM Changeset in webkit [142146] by zherczeg@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Invalid code is generated for storing constants with baseindex addressing modes on ARM traditional.
https://bugs.webkit.org/show_bug.cgi?id=109050

Reviewed by Oliver Hunt.

The S! scratch register is reused, but it should contain the constant value.

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::baseIndexTransfer32):
(JSC::ARMAssembler::baseIndexTransfer16):

10:03 AM Changeset in webkit [142145] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: linkifyResourceAsNode produced anchor should not prefer resources to scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=109197

Reviewed by Pavel Feldman.

Javascript syntax errors in console are now linkified so that they show sources panel by default.

  • inspector/front-end/ResourceUtils.js:

(WebInspector.linkifyResourceAsNode):

9:55 AM Changeset in webkit [142144] by commit-queue@webkit.org
  • 16 edits in trunk/Source

Web Inspector: Add settings checkbox for composited layer borders
https://bugs.webkit.org/show_bug.cgi?id=109096

Patch by Eberhard Graether <egraether@google.com> on 2013-02-07
Reviewed by Pavel Feldman.

This change adds a checkbox to show composited layer borders to the WebInspector's
rendering settings and plumbs the setting to Chromium's WebLayerTreeView. The setting
is visible if InspectorClient::canShowDebugBorders() returns true.

Source/Platform:

  • chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):
(WebKit::WebLayerTreeView::setShowDebugBorders):

Source/WebCore:

No new tests.

  • English.lproj/localizedStrings.js:
  • inspector/Inspector.json:
  • inspector/InspectorClient.h:

(WebCore::InspectorClient::canShowDebugBorders):
(WebCore::InspectorClient::setShowDebugBorders):
(InspectorClient):

  • inspector/InspectorPageAgent.cpp:

(PageAgentState):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::canShowDebugBorders):
(WebCore):
(WebCore::InspectorPageAgent::setShowDebugBorders):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.GenericSettingsTab):
(WebInspector.GenericSettingsTab.prototype.get _showDebugBordersChanged):

  • inspector/front-end/inspector.js:

(WebInspector.doLoadedDone):

Source/WebKit/chromium:

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::canShowDebugBorders):
(WebKit):
(WebKit::InspectorClientImpl::setShowDebugBorders):

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setShowDebugBorders):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:
9:51 AM Changeset in webkit [142143] by gavinp@chromium.org
  • 12 edits
    3 adds in trunk

Unreviewed, rolling out r142141.
http://trac.webkit.org/changeset/142141
https://bugs.webkit.org/show_bug.cgi?id=108990

Reland r142112, will update Chromium expectations and create a
Chromium bug instead for the crash.

.:

  • ManualTests/remove-fixed-position-but-keep-compositing.html: Added.

Source/WebCore:

  • CMakeLists.txt:
  • Target.pri:
  • WebCore.pri:
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::create):

  • page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp: Added.

(WebCore):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::ScrollingCoordinatorCoordinatedGraphics):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::setLayerIsFixedToContainerLayer):

  • page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h: Added.

(WebCore):
(ScrollingCoordinatorCoordinatedGraphics):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setFixedToViewport):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::flushCompositingState):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):

Source/WebKit2:

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl):

9:46 AM Changeset in webkit [142142] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Web Inspector: home button behaviour is wrong in DTE
https://bugs.webkit.org/show_bug.cgi?id=109154

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-07
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Handle home key shortcut explicitly in TextEditorMainPanel.

New test: inspector/editor/text-editor-home-button.html

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._registerShortcuts):
(WebInspector.TextEditorMainPanel.prototype._handleHomeKey):

LayoutTests:

Add layout test to verify home button behaviour. Exclude this test on
platforms that do not have eventSender object in test shell.

  • inspector/editor/text-editor-home-button-expected.txt: Added.
  • inspector/editor/text-editor-home-button.html: Added.
  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
9:32 AM Changeset in webkit [142141] by gavinp@chromium.org
  • 12 edits
    3 deletes in trunk

Unreviewed, rolling out r142112.
http://trac.webkit.org/changeset/142112
https://bugs.webkit.org/show_bug.cgi?id=108990

The new test scrollingcoordinator/non-fast-scrollable-region-transformed- iframe.html crashes on Lion.

See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=scrollingcoordinator%2Fnon-fast-scrollable-region-transformed-iframe.html

.:

  • ManualTests/remove-fixed-position-but-keep-compositing.html: Removed.

Source/WebCore:

  • CMakeLists.txt:
  • Target.pri:
  • WebCore.pri:
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::create):

  • page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp: Removed.
  • page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h: Removed.
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::flushCompositingState):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient):
(WebCore::CoordinatedGraphicsLayer::setFixedToViewport):

Source/WebKit2:

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::updateOffsetFromViewportForSelf):
(WebKit):
(WebKit::updateOffsetFromViewportForLayer):
(WebKit::CoordinatedLayerTreeHost::syncFixedLayers):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl):

9:29 AM Changeset in webkit [142140] by allan.jensen@digia.com
  • 5 edits in trunk

Scrollbars misplaced with accelerated compositing for overflow scroll
https://bugs.webkit.org/show_bug.cgi?id=108625

Reviewed by Simon Fraser.

Source/WebCore:

Scrollbars require their own layer if overflow scroll is composited,
otherwise the scrollbars would be rendered on the content layer and
not fixed to the viewport.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::requiresHorizontalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresVerticalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresScrollCornerLayer):

LayoutTests:

Update the results for the one test that explicitly set accelerated compositing for overflow scroll,
and used to have bad results for non-chromium. The new baselines are almost identical to chomium baseline.

  • platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
  • platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
9:18 AM Changeset in webkit [142139] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebCore

Don't ASSERT things about uninitialized variables.
https://bugs.webkit.org/show_bug.cgi?id=109187

Reviewed by Jochen Eisinger.

Rather than ASSERTing that an uninitialized ExceptionCode is non-zero
after some method executes, we should use the ASSERT_NO_EXCEPTION macro.

  • editing/markup.cpp:

(WebCore::removeElementPreservingChildren):

9:17 AM Changeset in webkit [142138] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Regression] breakpoint condition not editable
https://bugs.webkit.org/show_bug.cgi?id=109183

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-07
Reviewed by Vsevolod Vlasov.

Improve TextEditorMainPanel.selection() method to return null if the
selection is set inside of decoration element.

No new tests.

  • inspector/front-end/DOMExtension.js:

(Node.prototype.enclosingNodeOrSelfWithClass): Improve to add iteration boundary.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype.selection):

8:58 AM Changeset in webkit [142137] by jpetsovits@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix all flicker caused by empty/incomplete geometries.
https://bugs.webkit.org/show_bug.cgi?id=108951
RIM PR 286925

Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.

The main idea for this patch is that whenever we adopt
a new backingstore geometry that doesn't contain any
rendered tiles, or VisibleZoom render jobs that need more
tiles to be rendered to be considered complete, we'll then
suspend blitting until there is valid content to show.

This main idea is codified as checks for empty buffers
in adoptAsFrontState(), and checks for the current state
of the render queue after rendering content in render().
However, as BackingStore objects with disabled surface pools
or pure use of accelerated compositing also swap geometries
in some circumstances, the use of suspend counters grows
increasingly fragile.

To make this patch more resilient against regressions,
the current suspend counter is complemented with several
explicit conditions for suspending screen updates,
and both subsequently combined into a single cached
boolean value telling the UI thread whether or not to
suspend. In the future, other suspend calls can be
migrated to this "state machine" design as well,
potentially phasing out the suspend counter altogether.

The immediate result is that there will be no flashing
of background color between page loads or after discarding
tiles on scale changes until the content has been rendered.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::suspendBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::suspendScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::adoptAsFrontState):
(BlackBerry::WebKit::BackingStorePrivate::setCurrentBackingStoreOwner):
(BlackBerry::WebKit::BackingStore::releaseOwnedBackingStoreMemory):

  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setVisible):
(BlackBerry::WebKit::WebPagePrivate::setCompositorDrawsRootLayer):

8:46 AM Changeset in webkit [142136] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Source/WebCore

[WK2][EFL][QT]REGRESSION(r142045): Scrolling is broken
https://bugs.webkit.org/show_bug.cgi?id=109185

Reviewed by Kenneth Rohde Christiansen.

This patch is disabling paints clipping logic added at r142045 for the case
when the view should render the entire contents (case of using tiled backing store).

No new tests, covered by plenty of existing manual tests that allow scrolling
(for example fixed-position.html).

  • platform/ScrollView.cpp:

(WebCore::ScrollView::paint):

8:42 AM Changeset in webkit [142135] by kadam@inf.u-szeged.hu
  • 26 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening. Added platform specific expected files after r140693.
https://bugs.webkit.org/show_bug.cgi?id=107567.

  • platform/qt/TestExpectations:
  • platform/qt/css2.1/t0505-c16-descendant-01-e-expected.png:
  • platform/qt/css2.1/t0505-c16-descendant-01-e-expected.txt:
  • platform/qt/editing/selection/extend-by-sentence-001-expected.png:
  • platform/qt/editing/selection/extend-by-sentence-001-expected.txt:
  • platform/qt/fast/inline/drawStyledEmptyInlines-expected.png:
  • platform/qt/fast/inline/drawStyledEmptyInlines-expected.txt:
  • platform/qt/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
  • platform/qt/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt:
  • platform/qt/fast/text/capitalize-empty-generated-string-expected.png:
  • platform/qt/fast/text/capitalize-empty-generated-string-expected.txt:
  • platform/qt/fast/text/whitespace/006-expected.png:
  • platform/qt/fast/text/whitespace/006-expected.txt:
  • platform/qt/fast/text/whitespace/007-expected.png:
  • platform/qt/fast/text/whitespace/007-expected.txt:
  • platform/qt/svg/batik/text/xmlSpace-expected.png:
  • platform/qt/svg/batik/text/xmlSpace-expected.txt:
  • platform/qt/svg/carto.net/combobox-expected.png:
  • platform/qt/svg/carto.net/combobox-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug113235-3-expected.png:
  • platform/qt/tables/mozilla/bugs/bug113235-3-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug1318-expected.png:
  • platform/qt/tables/mozilla/bugs/bug1318-expected.txt:
8:42 AM Changeset in webkit [142134] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed warning fix.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(BuildAndTestFactory.init):
(DownloadAndPerfTestWebKit2Factory.init):

8:42 AM Changeset in webkit [142133] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed typo fix after r142121.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
8:39 AM Changeset in webkit [142132] by pfeldman@chromium.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: Show elements and sources sidebar panes in a tabbed pane when they are below the main pane
https://bugs.webkit.org/show_bug.cgi?id=107552

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-07
Reviewed by Pavel Feldman.

Removed the aspect ratio detection logic and implemented explicit user action "Split Horizontally" available
in Elements and Sources panels. When split horizontally the sidebar panes are organized into a tabbed pane.
This user action is behind an experimental flag.

No new tests.

  • inspector/front-end/ContextMenu.js:

(WebInspector.ContextMenu.prototype.show):

  • inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.prototype.createProxy):
(WebInspector.DOMBreakpointsSidebarPane.prototype.onContentReady):
(WebInspector.DOMBreakpointsSidebarPane.Proxy):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype.expanded):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype.expand):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype.collapse):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype.onContentReady):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype.wasShown):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype._reattachBody):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._populateContextMenu):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._clearInterface):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
(WebInspector.ScriptsPanel.prototype._contextMenuEventFired):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SidebarPane.js:

(WebInspector.SidebarPane):
(WebInspector.SidebarPane.prototype.prepareContent):
(WebInspector.SidebarPane.prototype.expanded):
(WebInspector.SidebarPane.prototype.expand):
(WebInspector.SidebarPane.prototype.collapse):
(WebInspector.SidebarPane.prototype.onContentReady):
(WebInspector.SidebarPane.prototype._setExpandCallback):
(WebInspector.SidebarPaneStack.prototype.addPane):
(WebInspector.SidebarPaneStack.prototype.activePaneId):
(WebInspector.SidebarPaneStack.prototype.setActivePaneId):
(WebInspector.SidebarPaneStack.prototype._setExpanded):
(WebInspector.SidebarPaneStack.prototype._onPaneExpanded):
(WebInspector.SidebarPaneStack.prototype._collapsePane):
(WebInspector.SidebarTabbedPane):
(WebInspector.SidebarTabbedPane.prototype.addPane):
(WebInspector.SidebarTabbedPane.prototype.activePaneId):
(WebInspector.SidebarTabbedPane.prototype.setActivePaneId):
(WebInspector.SidebarPaneGroup):
(WebInspector.SidebarPaneGroup.prototype.setStacked):
(WebInspector.SidebarPaneGroup.prototype.addPane):
(WebInspector.SidebarPaneGroup.prototype.attachToPanel):
(WebInspector.SidebarPaneGroup.prototype.populateContextMenu.toggleSplitDirection):
(WebInspector.SidebarPaneGroup.prototype.get _contextMenuEventFired):
(WebInspector.SidebarPaneGroup.prototype._onSplitDirectionSettingChanged):

  • inspector/front-end/SidebarView.js:

(WebInspector.SidebarView):
(WebInspector.SidebarView.prototype._updateSidebarElementStyle):
(WebInspector.SidebarView.prototype.setVertical):
(WebInspector.SidebarView.prototype.onResize):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.ComputedStyleSidebarPane.prototype.wasShown):
(WebInspector.ComputedStyleSidebarPane.prototype.prepareContent):

  • inspector/front-end/inspector.css:

(.sidebar-pane .section .properties, .event-bar .event-properties):
(.pane-title):
(.sidebar-pane-toolbar):
(.sidebar-pane-toolbar > *):
(.sidebar-pane-toolbar > select):
(.sidebar-pane-toolbar > select:hover):
(.sidebar-pane-toolbar > select:active):
(.sidebar-pane-toolbar > select.select-settings):
(.sidebar-pane-toolbar > select.select-filter):
(.sidebar-pane-toolbar > select > option, .sidebar-pane-toolbar > select > hr):
(.sidebar-pane-toolbar > .pane-title-button):
(.sidebar-pane-toolbar > .pane-title-button:hover):
(.sidebar-pane-toolbar > .pane-title-button:active, .sidebar-pane-toolbar > .pane-title-button.toggled):
(.sidebar-pane-toolbar > .pane-title-button.add):
(.sidebar-pane-toolbar > .pane-title-button.element-state):
(.sidebar-pane-toolbar > .pane-title-button.refresh):
(.sidebar-pane):
(.sidebar-pane > .body):
(.sidebar-pane > .body .info):
(.sidebar-pane > .body .placard + .info):
(.sidebar-pane.visible > .body):
(.sidebar-pane > .body .breakpoint-condition):
(.sidebar-pane.visible:nth-last-of-type(1)):
(.sidebar-pane-subtitle):
(.sidebar-pane-subtitle input, .section .header input[type=checkbox]):
(.sidebar-pane .breakpoint-hit):

8:38 AM Changeset in webkit [142131] by zandobersek@gmail.com
  • 2 edits in trunk

[GTK] configure.ac requires a cleanup
https://bugs.webkit.org/show_bug.cgi?id=99272

Reviewed by Martin Robinson.

Clean up configure.ac. While there is no strict style guideline determined
for this file the changes enforce the usual indentation of four spaces along
with line wrapping at 130 characters and grammar fixes/updates.

  • configure.ac:
8:37 AM Changeset in webkit [142130] by gavinp@chromium.org
  • 5 edits
    6 deletes in trunk

Unreviewed, rolling out r142111.
http://trac.webkit.org/changeset/142111
https://bugs.webkit.org/show_bug.cgi?id=108055

win7 bot didn't display Arabic, see http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-appearance-required-ar.html

Source/WebCore:

  • Resources/pagepopups/calendarPicker.css:

(.today-clear-area .today-button):

  • Resources/pagepopups/calendarPicker.js:

(CalendarPicker.prototype.fixWindowSize):

LayoutTests:

  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Removed.
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Removed.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.txt: Removed.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html: Removed.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.txt: Removed.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html: Removed.
8:31 AM Changeset in webkit [142129] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WTF

[Qt] Fix build without 3D_GRAPHICS
https://bugs.webkit.org/show_bug.cgi?id=109194

Reviewed by Noam Rosenthal.

Now that Coordinated Graphics was moved to WebCore, we need to explicitly enable
it when we have 3D_GRAPHICS. This dependency was implicitly by the fact that
3D_GRAPHICS is a dependency of WebKit2 and Coordinated Graphics was only
available there. This should fix build for Qt SH4 Linux.

  • wtf/Platform.h:
8:30 AM Changeset in webkit [142128] by vsevik@chromium.org
  • 5 edits in trunk

Web Inspector: [Regression] Map.size() returns negative values.
https://bugs.webkit.org/show_bug.cgi?id=109174

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/utilities.js:

LayoutTests:

  • inspector/map-expected.txt:
  • inspector/map.html:
8:25 AM Changeset in webkit [142127] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: break details are only rendered upon first debugger pause.
https://bugs.webkit.org/show_bug.cgi?id=109193

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype.update):

8:22 AM Changeset in webkit [142126] by gavinp@chromium.org
  • 35 edits in trunk/Source/WebCore

Unreviewed, rolling out r142118.
http://trac.webkit.org/changeset/142118
https://bugs.webkit.org/show_bug.cgi?id=109044

Broke SVG! Oh noes!

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::direction):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::mode):

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::takeAllChildrenFrom):

  • dom/Document.cpp:

(WebCore::Document::setTitle):

  • dom/MessagePort.cpp:

(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::disentanglePorts):

  • editing/DeleteButtonController.cpp:

(WebCore::enclosingDeletableElement):
(WebCore::DeleteButtonController::createDeletionUI):
(WebCore::DeleteButtonController::show):

  • editing/EditorCommand.cpp:

(WebCore::unionDOMRanges):

  • editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment):
(WebCore::ReplacementFragment::removeNode):
(WebCore::ReplacementFragment::insertNodeBefore):
(WebCore::ReplacementFragment::insertFragmentForTestRendering):
(WebCore::ReplacementFragment::restoreAndRemoveTestRenderingNodesToFragment):
(WebCore::ReplaceSelectionCommand::insertAsListItems):

  • editing/SplitTextNodeCommand.cpp:

(WebCore::SplitTextNodeCommand::doUnapply):

  • editing/TextIterator.cpp:

(WebCore::CharacterIterator::range):
(WebCore::BackwardsCharacterIterator::range):
(WebCore::TextIterator::rangeFromLocationAndLength):
(WebCore::collapsedToBoundary):

  • editing/htmlediting.cpp:

(WebCore::createTabSpanElement):

  • editing/mac/EditorMac.mm:

(WebCore::Editor::fontForSelection):
(WebCore::Editor::fontAttributesForSelectionStart):

  • editing/markup.cpp:

(WebCore::createMarkup):
(WebCore::trimFragment):
(WebCore::createFragmentFromMarkupWithContext):
(WebCore::fillContainerFromString):
(WebCore::createFragmentFromText):
(WebCore::createFragmentFromNodes):

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updatePlaceholderText):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::indexForVisiblePosition):
(WebCore::HTMLTextFormControlElement::setInnerTextValue):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::updatePlaceholderText):

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::buildBubbleTree):

  • html/shadow/MediaControlElementTypes.cpp:

(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::getCookies):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::addRule):

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::dispatchDOMEvent):

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::deleteFromDocument):

  • page/DragController.cpp:

(WebCore::prepareClipboardForImageDrag):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::visiblePositionForIndex):

  • rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::initialBaselineShiftValue):
(WebCore::SVGRenderStyle::initialKerning):
(WebCore::SVGRenderStyle::initialStrokeDashOffset):
(WebCore::SVGRenderStyle::initialStrokeWidth):

  • svg/SVGAnimatedLength.cpp:

(WebCore::sharedSVGLength):
(WebCore::SVGAnimatedLengthAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):

  • svg/SVGLength.cpp:

(WebCore::SVGLength::SVGLength):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::textLengthAnimated):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::constructQualifiedName):

8:21 AM WebKitGTK/1.10.x edited by Martin Robinson
(diff)
8:19 AM WebKitGTK/1.10.x edited by Martin Robinson
(diff)
8:04 AM Changeset in webkit [142125] by vivek.vg@samsung.com
  • 3 edits in trunk/Tools

[Qt] QtTestBrowser should provide option to enable/disable Javascript
https://bugs.webkit.org/show_bug.cgi?id=107461

Reviewed by Jocelyn Turcotte.

Option to enable/disable Javascript would be handy option to test
certain functionalities of web pages with/without Javascript.

  • QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::createChrome):
(LauncherWindow::toggleJavaScriptEnabled):

  • QtTestBrowser/launcherwindow.h:

(LauncherWindow):

7:56 AM Changeset in webkit [142124] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove #if USE(V8) from IDBRequest.h
https://bugs.webkit.org/show_bug.cgi?id=109163

Reviewed by Andreas Kling.

The header included inside the #if USE(V8) macro is not used.
We can simply remove it.

No tests. No change in behavior.

  • Modules/indexeddb/IDBRequest.h:
7:53 AM Changeset in webkit [142123] by schenney@chromium.org
  • 3 edits in trunk/Source/WebCore

GraphicsContext::drawImageBuffer is inefficient
https://bugs.webkit.org/show_bug.cgi?id=104367

Reviewed by Dirk Schulze.

This patch converts all of the drawImage and drawImageBuffer
convenience methods (those that take parameters of various types) to
invoke the implementing method (that takes FloatRect src and dest)
directly, rather than through the next-most-convenient method as was
done previously. This will knock some layers off the stack compared
to the existing code, and may remove one or two constructor invocations.
This may be slightly more efficient, and also makes debugging simpler.

Also removes the unused drawImage method that takes and IntRect source
area and IntRect destination. It is not invoked anywhere in a standard
WebKit checkout.

No new tests. No change in functionality, just refactoring.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage): Modify all the convenience versions to call
the implementing version directly.
(WebCore::GraphicsContext::drawImageBuffer): Modify all the convenience versions
to call the implementing version directly.

  • platform/graphics/GraphicsContext.h:

(GraphicsContext): Remove IntRect, IntRect version of drawImage.

7:46 AM Changeset in webkit [142122] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

Conversion from localized numbers to HTML numbers should accept not only localized numbers but also HTML numbers
https://bugs.webkit.org/show_bug.cgi?id=109160

Reviewed by Kentaro Hara.

Source/WebCore:

For example, A French user needs to specify a number to a number input
field. He might use a local decimal point, like 3,141592, or he might
use the standard decimal point like 3.141592. We had better accept both
of them.

We accepted both last year, but we changed the behavior so that we
accept only localized numbers because we had some cases where an input
string can be recognized as both of a localized number and the standard
number. e.g. 3.141 is 3141 in French locale and 3.141 in the
standard. Now we introduce a simple rule that we don't accept group
separator at all. So users won't confuse even if we accept both of
decimal points.

Test: fast/forms/number/number-l10n-input.html

  • platform/text/PlatformLocale.cpp:

(WebCore::Locale::convertFromLocalizedNumber):
If the specified string contains invalid characters including group
separators, just return the specified string.

LayoutTests:

  • fast/forms/number/number-l10n-input-expected.txt: Added.
  • fast/forms/number/number-l10n-input.html: Added.
7:35 AM Changeset in webkit [142121] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[EFL] Add a WebKit2 Performance bot.
https://bugs.webkit.org/show_bug.cgi?id=109188

Reviewed by Csaba Osztrogonác.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Add the

efl-linux-perf-1 slave (a 64-bit Release WK2 Perf bot), and make
the "EFL Linux 64-bit Release" bot trigger it.

7:24 AM Changeset in webkit [142120] by commit-queue@webkit.org
  • 11 edits in trunk

[BlackBerry] CHHW - Characters that are using 32 bits encoding get trunked to 16bits
https://bugs.webkit.org/show_bug.cgi?id=109126
PR 292540

Source/WebCore:

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-02-07
Reviewed by Yong Li.

Change char code to 4 bytes.
Need to convert UTF32 key char to UTF16 before constructing a WTF::String.

  • platform/PlatformKeyboardEvent.h:

(WebCore::PlatformKeyboardEvent::unmodifiedCharacter):
(PlatformKeyboardEvent):

  • platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:

(WebCore::keyIdentifierForBlackBerryCharacter):
(WebCore::windowsKeyCodeForBlackBerryCharacter):
(WebCore::adjustCharacterFromOS):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

Source/WebKit/blackberry:

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-02-07
Reviewed by Yong Li.
Internally reviewed by Mike Fenton.

Key char is UTF32 encoded, should be 4 bytes.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::handleScrolling):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::handleKeyboardInput):

  • WebKitSupport/InputHandler.h:

(InputHandler):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::directionOfPointRelativeToRect):
(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
(BlackBerry::WebKit::shouldExtendSelectionInDirection):
(BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):

  • WebKitSupport/SelectionHandler.h:

(SelectionHandler):

Tools:

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-02-07
Reviewed by Yong Li.

Change char code to 4 bytes.

  • DumpRenderTree/blackberry/EventSender.cpp:

(keyDownCallback):

7:21 AM Changeset in webkit [142119] by senorblanco@chromium.org
  • 8 edits
    4 adds in trunk/LayoutTests

[chromium] New baselines for GPU-accelerated reference filters tests. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=104289

  • platform/chromium-linux/css3/filters/effect-reference-hw-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-reference-ordering-hw-expected.png:
  • platform/chromium-mac-lion/css3/filters/effect-reference-hw-expected.txt: Added.
  • platform/chromium-mac-snowleopard/css3/filters/effect-reference-hw-expected.txt: Added.
  • platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium-mac/css3/filters/effect-reference-hw-expected.txt:
  • platform/chromium-mac/css3/filters/effect-reference-ordering-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-ordering-hw-expected.png:
  • platform/chromium/TestExpectations:
7:14 AM Changeset in webkit [142118] by mkwst@chromium.org
  • 35 edits in trunk/Source/WebCore

Replace ExceptionCode assertions with ASSERT_NO_EXCEPTION macro.
https://bugs.webkit.org/show_bug.cgi?id=109044

Reviewed by Darin Adler.

The pattern:

ExceptionCode ec = 0;
methodThatGeneratesException(ec);
ASSERT(!ec);

is more clearly and succinctly written as:

methodThatGeneratesException(ASSERT_NO_EXCEPTION);

This patch replaces the occurances of the former that never touch 'ec'
again with the latter. It does the same for 'ASSERT(ec == 0);' (and, as
a drive-by, replaces 'ASSERT(ec == 0)' with 'ASSERT(!ec)' in places
where it does indeed matter that 'ec' get set properly.

No change in behavior should result from this refactoring.

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::direction):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::mode):

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::takeAllChildrenFrom):

  • dom/Document.cpp:

(WebCore::Document::setTitle):

  • dom/MessagePort.cpp:

(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::disentanglePorts):

  • editing/DeleteButtonController.cpp:

(WebCore::enclosingDeletableElement):
(WebCore::DeleteButtonController::createDeletionUI):

Replaced inline ASSERT with ASSERT_NO_EXCEPTION.

(WebCore::DeleteButtonController::show):

Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.

  • editing/EditorCommand.cpp:

(WebCore::unionDOMRanges):

  • editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment):
(WebCore::ReplacementFragment::removeNode):
(WebCore::ReplacementFragment::insertNodeBefore):
(WebCore::ReplacementFragment::insertFragmentForTestRendering):
(WebCore::ReplacementFragment::restoreAndRemoveTestRenderingNodesToFragment):
(WebCore::ReplaceSelectionCommand::insertAsListItems):

  • editing/SplitTextNodeCommand.cpp:

(WebCore::SplitTextNodeCommand::doUnapply):

  • editing/TextIterator.cpp:

(WebCore::CharacterIterator::range):
(WebCore::BackwardsCharacterIterator::range):
(WebCore::TextIterator::rangeFromLocationAndLength):
(WebCore::collapsedToBoundary):

  • editing/htmlediting.cpp:

(WebCore::createTabSpanElement):

  • editing/mac/EditorMac.mm:

(WebCore::Editor::fontForSelection):
(WebCore::Editor::fontAttributesForSelectionStart):

  • editing/markup.cpp:

(WebCore::createMarkup):
(WebCore::trimFragment):
(WebCore::createFragmentFromMarkupWithContext):
(WebCore::fillContainerFromString):
(WebCore::createFragmentFromText):
(WebCore::createFragmentFromNodes):

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree):

Replaced inline ASSERT with ASSERT_NO_EXCEPTION.

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):

Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updatePlaceholderText):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::indexForVisiblePosition):
(WebCore::HTMLTextFormControlElement::setInnerTextValue):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::updatePlaceholderText):

  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::buildBubbleTree):

  • html/shadow/MediaControlElementTypes.cpp:

(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::getCookies):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::addRule):

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::dispatchDOMEvent):

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::deleteFromDocument):

  • page/DragController.cpp:

(WebCore::prepareClipboardForImageDrag):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::visiblePositionForIndex):

  • rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::initialBaselineShiftValue):
(WebCore::SVGRenderStyle::initialKerning):
(WebCore::SVGRenderStyle::initialStrokeDashOffset):
(WebCore::SVGRenderStyle::initialStrokeWidth):

  • svg/SVGAnimatedLength.cpp:

(WebCore::sharedSVGLength):
(WebCore::SVGAnimatedLengthAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):

  • svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):

  • svg/SVGLength.cpp:

(WebCore::SVGLength::SVGLength):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::textLengthAnimated):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::constructQualifiedName):

Replaced inline ASSERT with ASSERT_NO_EXCEPTION.

7:08 AM Changeset in webkit [142117] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Reader Mode: Opening two links quickly from reader mode causes browser bad state
https://bugs.webkit.org/show_bug.cgi?id=109124

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2013-02-07
Reviewed by Yong Li.

RIM BUG 291246 Internally reviewed by YongLi.
Move the WebPageGroupLoadDeferrer object from ChromeClientBlackBerry::createWindow()
into WebPageClientImpl::createWindow() to make it more close to its protecting place.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::createWindow):

7:07 AM Changeset in webkit [142116] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Send type details with IMF mask as part of focus gained.
https://bugs.webkit.org/show_bug.cgi?id=109086

Reviewed by Yong Li.

PR 292609.

Add masking options based on VKB type to the IMF mask.

Reviewed Internally by Nima Ghanavatian.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::addInputStyleMaskForKeyboardType):
(WebKit):
(BlackBerry::WebKit::InputHandler::setElementFocused):

7:05 AM Changeset in webkit [142115] by mary.wu@torchmobile.com.cn
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Export mimeType in NetworkJob
https://bugs.webkit.org/show_bug.cgi?id=109002

Reviewed by Yong Li.

NetworkJob will analysize resource mimetype and set it to resourceResponse,
we will pass it on to be used by other Streams like download stream.

RIM bug# 284408, internally reviewed by Liam Quinn.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::mimeType):
(WebCore):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

7:00 AM Changeset in webkit [142114] by commit-queue@webkit.org
  • 20 edits
    3 adds in trunk

Web Inspector: support JavaScript variable mutation in protocol and V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=107829

Source/WebCore:

A new command is added to protocol description and the call is passed through
debugger agent through injected script and debugger script down to V8 mirror
API. JSC bindings got a thorw exception stub.

Only declarative JavaScript scopes are supported (local, closure, catch). Other
scopes (global, with) are not supported by V8 and not supported by protocol, because
manual approach (direct property assigment) is available for them in form of evaluate
commands and is more desirable because of a complex nature of operation (it can throw
exception in several cases such as exception in setter function).

Patch by Peter Rybin <prybin@chromium.org> on 2013-02-07
Reviewed by Pavel Feldman.

Test: inspector-protocol/debugger-setVariableValue.html

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::setFunctionVariableValue):
(WebCore):

  • bindings/js/JSJavaScriptCallFrameCustom.cpp:

(WebCore::JSJavaScriptCallFrame::setVariableValue):
(WebCore):

  • bindings/v8/DebuggerScript.js:

(.):

  • bindings/v8/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::setVariableValue):
(WebCore):

  • bindings/v8/JavaScriptCallFrame.h:

(JavaScriptCallFrame):

  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setFunctionVariableValue):
(WebCore):

  • bindings/v8/ScriptDebugServer.h:

(ScriptDebugServer):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::setFunctionVariableValueCallback):
(WebCore):

  • bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:

(WebCore::V8JavaScriptCallFrame::setVariableValueCallback):
(WebCore):

  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::setVariableValue):
(WebCore):

  • inspector/InjectedScript.h:

(InjectedScript):

  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js:

(.):

  • inspector/Inspector.json:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::setVariableValue):
(WebCore):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/JavaScriptCallFrame.idl:

LayoutTests:

Patch by Peter Rybin <prybin@chromium.org> on 2013-02-07
Reviewed by Pavel Feldman.

  • inspector-protocol/debugger-setVariableValue-expected.txt: Added.
  • inspector-protocol/debugger-setVariableValue.html: Added.
  • inspector/console/command-line-api-expected.txt:
  • platform/chromium/inspector-protocol/debugger-setVariableValue-expected.txt: Added.
6:56 AM Changeset in webkit [142113] by yurys@chromium.org
  • 5 edits in trunk/LayoutTests

Web Inspector: reduce number of native memory instrumentation categories
https://bugs.webkit.org/show_bug.cgi?id=109146

Reviewed by Pavel Feldman.

Fix layout tests that started failing after r142081.

  • inspector/profiler/memory-instrumentation-cached-images-expected.txt:
  • inspector/profiler/memory-instrumentation-cached-images.html:
  • inspector/profiler/memory-instrumentation-canvas-expected.txt:
  • inspector/profiler/memory-instrumentation-canvas.html:
6:47 AM Changeset in webkit [142112] by caio.oliveira@openbossa.org
  • 12 edits
    4 adds in trunk

[CoordinatedGraphics] Use ScrollingCoordinator to track fixed layers
https://bugs.webkit.org/show_bug.cgi?id=108990

.:

Reviewed by Noam Rosenthal.

Add a new test that allow us to remove the fixed positioning of a layer but still keeping
it compositing. Coordinated Graphics had a bug where the CoordinatedSceneGraph would still
count this layer as fixed position.

  • ManualTests/remove-fixed-position-but-keep-compositing.html: Added.

Source/WebCore:

Reviewed by Noam Rosenthal.

WebCore keeps ScrollingCoordinator up-to-date about whether layers are fixed or not, so we
don't need to traverse the tree every frame to get this information.

The function ScrollingCoordinator::setLayerIsFixedToContainerLayer() is called when
RenderLayerBacking is updating its graphics layers.

The new code also works in new situations where the previous was broken: if a layer changed
from being fixed to not fixed (but still kept as a layer for other reasons), the layer will
be correctly updated. Previous implementation only had logic to mark layers as fixed, but
not the other way round. A manual test was added to illustrate the solved problem.

Testing was done with the existing manual tests that make use of "position:fixed". Automatic
tests are mostly not affected by this because usage of this information affects only the
UseFixedLayout mode, not used by default in WebKitTestRunner. Work to improve this situation
will be tracked in bug https://bugs.webkit.org/show_bug.cgi?id=109175.

  • CMakeLists.txt:
  • Target.pri:
  • WebCore.pri:
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::create): create specific version of ScrollingCoordinator.

  • page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp: Added.

(WebCore):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::ScrollingCoordinatorCoordinatedGraphics):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::setLayerIsFixedToContainerLayer):
update layer information using existing hook in ScrollingCoordinator.

  • page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h: Added.

(WebCore):
(ScrollingCoordinatorCoordinatedGraphics):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setFixedToViewport): now that setting viewport is not
embedded in the synchronization work, we need to mark the layer so it is updated in the
next frame.
(WebCore):
(WebCore::CoordinatedGraphicsLayer::flushCompositingState): remove call to syncFixedLayers().

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient): remove now unused syncFixedLayers() from client.
(CoordinatedGraphicsLayer):

Source/WebKit2:

Reviewed by Noam Rosenthal.
Signed off for WebKit2 by Simon Fraser.

WebCore keeps ScrollingCoordinator up-to-date about whether layers are fixed or not, so we
don't need to traverse the tree every frame to get this information.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp: remove

syncFixedLayers() and its helper functions. Those were used to identify the fixed layers
and are not needed anymore.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl): enable the scrolling coordinator usage for
Coordinated Graphics.

6:42 AM Changeset in webkit [142111] by keishi@webkit.org
  • 5 edits
    6 adds in trunk

Source/WebCore: REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute
https://bugs.webkit.org/show_bug.cgi?id=109136

Reviewed by Kent Tamura.

Calendar picker was using the "Clear" button to calculate the window width.
Since it doesn't exist when the input element has a required attribute,
it was throwing an error. This patch fixes the width calculating logic.

Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html

platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html

  • Resources/pagepopups/calendarPicker.css:

(.today-clear-area):

  • Resources/pagepopups/calendarPicker.js:

(CalendarPicker.prototype.fixWindowSize): Fixing the logic to calculate
the width. We don't want to use clear button because it doesn't exist
when a value is required.

LayoutTests: REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute
https://bugs.webkit.org/show_bug.cgi?id=108055

Reviewed by Kent Tamura.

  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.txt: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.txt: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html: Added.
  • platform/chromium/TestExpectations:
6:32 AM Changeset in webkit [142110] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing test.

  • platform/qt/TestExpectations:
6:20 AM Changeset in webkit [142109] by gavinp@chromium.org
  • 31 edits
    3 deletes in trunk/Tools

Unreviewed, rolling out r142090.
http://trac.webkit.org/changeset/142090
https://bugs.webkit.org/show_bug.cgi?id=108466

lots of selection expectations failures

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTask.h:

(WebTaskList):

  • DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
  • DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebTestInterfaces):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestProxyBase):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:

(AccessibilityUIElementList):

  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:

(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):

  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:

(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):

  • DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:

(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):

  • DumpRenderTree/chromium/TestRunner/src/CppVariant.h:

(CppVariant):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):

  • DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:

(WebTestRunner::NativeKeyCodeForWindowsKeyCode):

  • DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:

(MockGrammarCheck::checkGrammarOfString):

  • DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:

(MockGrammarCheck):

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:

(append):
(isNotASCIIAlpha):
(MockSpellCheck::spellCheckWord):
(MockSpellCheck::initializeIfNeeded):

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:

(MockSpellCheck):

  • DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:

(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):

  • DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:

(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:

(TestPlugin):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner):
(WebTestRunner::TestRunner::setBackingScaleFactor):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:

(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):

  • DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):

  • DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:

(WebTestRunner):
(WebTestRunner::WebTaskList::WebTaskList):
(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):

  • DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
6:14 AM Changeset in webkit [142108] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix. libWebCore.la needs to be relinked when
symbols.filter changes.

  • GNUmakefile.am: add symbols.filter as a dependency for the

libWebCore.la library.

5:56 AM Changeset in webkit [142107] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Closure compilation fixes
https://bugs.webkit.org/show_bug.cgi?id=109131

Reviewed by Yury Semikhatsky.

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):

  • inspector/front-end/FileSystemMapping.js:

(WebInspector.FileSystemMappingImpl.prototype.uriPrefixForPathPrefix):

  • inspector/front-end/IsolatedFileSystemModel.js:

(WebInspector.IsolatedFileSystemModel.prototype._fileSystemRemoved):

  • inspector/front-end/SidebarPane.js:
5:51 AM Changeset in webkit [142106] by kadam@inf.u-szeged.hu
  • 3 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviwed gardening. Rebaselining and skipping new failures.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-02-07

  • platform/qt/TestExpectations:
  • platform/qt/fast/dynamic/002-expected.txt:
  • platform/qt/fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated-expected.txt: Added.
  • platform/qt/fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated-expected.txt: Added.
5:48 AM Changeset in webkit [142105] by kov@webkit.org
  • 2 edits in trunk

Unreviewed build fix after r141196 for 32 bits autotools.

  • Source/autotools/symbols.filter: restore 32 bits version of the

WebCore::TextIterator::getLocationAndLengthFromRange(WebCore::Node*,
WebCore::Range const*, unsigned int&, unsigned int&) symbol.

5:47 AM Changeset in webkit [142104] by Gregg Tavares
  • 1 edit
    30 adds in trunk/LayoutTests

Add WebGL Conformance Tests state, renderbuffers, and reading folders.
https://bugs.webkit.org/show_bug.cgi?id=109121

Reviewed by Kenneth Russell.

  • webgl/conformance/reading/read-pixels-pack-alignment-expected.txt: Added.
  • webgl/conformance/reading/read-pixels-pack-alignment.html: Added.
  • webgl/conformance/renderbuffers/framebuffer-state-restoration-expected.txt: Added.
  • webgl/conformance/renderbuffers/framebuffer-state-restoration.html: Added.
  • webgl/conformance/renderbuffers/framebuffer-test-expected.txt: Added.
  • webgl/conformance/renderbuffers/framebuffer-test.html: Added.
  • webgl/conformance/renderbuffers/renderbuffer-initialization-expected.txt: Added.
  • webgl/conformance/renderbuffers/renderbuffer-initialization.html: Added.
  • webgl/conformance/state/gl-enable-enum-test-expected.txt: Added.
  • webgl/conformance/state/gl-enable-enum-test.html: Added.
  • webgl/conformance/state/gl-enum-tests-expected.txt: Added.
  • webgl/conformance/state/gl-enum-tests.html: Added.
  • webgl/conformance/state/gl-get-calls-expected.txt: Added.
  • webgl/conformance/state/gl-get-calls.html: Added.
  • webgl/conformance/state/gl-geterror-expected.txt: Added.
  • webgl/conformance/state/gl-geterror.html: Added.
  • webgl/conformance/state/gl-getstring-expected.txt: Added.
  • webgl/conformance/state/gl-getstring.html: Added.
  • webgl/resources/webgl_test_files/conformance/reading/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/reading/read-pixels-pack-alignment.html: Added.
  • webgl/resources/webgl_test_files/conformance/renderbuffers/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/renderbuffers/framebuffer-state-restoration.html: Added.
  • webgl/resources/webgl_test_files/conformance/renderbuffers/framebuffer-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/renderbuffers/renderbuffer-initialization.html: Added.
  • webgl/resources/webgl_test_files/conformance/state/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/state/gl-enable-enum-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/state/gl-enum-tests.html: Added.
  • webgl/resources/webgl_test_files/conformance/state/gl-get-calls.html: Added.
  • webgl/resources/webgl_test_files/conformance/state/gl-geterror.html: Added.
  • webgl/resources/webgl_test_files/conformance/state/gl-getstring.html: Added.
5:37 AM Changeset in webkit [142103] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r142077.
http://trac.webkit.org/changeset/142077
https://bugs.webkit.org/show_bug.cgi?id=108579

fast/filesystem/workers/file-writer-empty-blob.html is broken

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::setWrapperInObject):

  • bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolated):

  • bindings/v8/V8Binding.h:

(WebCore):
(WebCore::worldForEnteredContextIfIsolated):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):

  • bindings/v8/V8GCController.cpp:

(WebCore::WrapperVisitor::WrapperVisitor):
(WebCore):
(WebCore::gcTree):
(WebCore::V8GCController::didCreateWrapperForNode):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):

  • bindings/v8/V8GCController.h:

(V8GCController):

5:36 AM Changeset in webkit [142102] by Gregg Tavares
  • 1 edit
    29 adds in trunk/LayoutTests

Add WebGL Conformance Tests rendering folder.
https://bugs.webkit.org/show_bug.cgi?id=109122

Reviewed by Kenneth Russell.

  • webgl/conformance/rendering/culling-expected.txt: Added.
  • webgl/conformance/rendering/culling.html: Added.
  • webgl/conformance/rendering/draw-arrays-out-of-bounds-expected.txt: Added.
  • webgl/conformance/rendering/draw-arrays-out-of-bounds.html: Added.
  • webgl/conformance/rendering/draw-elements-out-of-bounds-expected.txt: Added.
  • webgl/conformance/rendering/draw-elements-out-of-bounds.html: Added.
  • webgl/conformance/rendering/gl-clear-expected.txt: Added.
  • webgl/conformance/rendering/gl-clear.html: Added.
  • webgl/conformance/rendering/gl-drawelements-expected.txt: Added.
  • webgl/conformance/rendering/gl-drawelements.html: Added.
  • webgl/conformance/rendering/gl-scissor-fbo-test-expected.txt: Added.
  • webgl/conformance/rendering/gl-scissor-fbo-test.html: Added.
  • webgl/conformance/rendering/line-loop-tri-fan-expected.txt: Added.
  • webgl/conformance/rendering/line-loop-tri-fan.html: Added.
  • webgl/conformance/rendering/simple-expected.txt: Added.
  • webgl/conformance/rendering/simple.html: Added.
  • webgl/conformance/rendering/triangle-expected.txt: Added.
  • webgl/conformance/rendering/triangle.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/culling.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/draw-arrays-out-of-bounds.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/draw-elements-out-of-bounds.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/gl-clear.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/gl-drawelements.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/gl-scissor-fbo-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/line-loop-tri-fan.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/simple.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/triangle.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/vertex-texture-fetch.html: Added.
5:20 AM Changeset in webkit [142101] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
5:05 AM Changeset in webkit [142100] by Gregg Tavares
  • 1 edit
    25 adds in trunk/LayoutTests

Add WebGL Conformance Tests programs folder.
https://bugs.webkit.org/show_bug.cgi?id=109120

Reviewed by Kenneth Russell.

  • webgl/conformance/programs/get-active-test-expected.txt: Added.
  • webgl/conformance/programs/get-active-test.html: Added.
  • webgl/conformance/programs/gl-bind-attrib-location-test-expected.txt: Added.
  • webgl/conformance/programs/gl-bind-attrib-location-test.html: Added.
  • webgl/conformance/programs/gl-get-active-attribute-expected.txt: Added.
  • webgl/conformance/programs/gl-get-active-attribute.html: Added.
  • webgl/conformance/programs/gl-get-active-uniform-expected.txt: Added.
  • webgl/conformance/programs/gl-get-active-uniform.html: Added.
  • webgl/conformance/programs/gl-getshadersource-expected.txt: Added.
  • webgl/conformance/programs/gl-getshadersource.html: Added.
  • webgl/conformance/programs/gl-shader-test-expected.txt: Added.
  • webgl/conformance/programs/gl-shader-test.html: Added.
  • webgl/conformance/programs/invalid-UTF-16-expected.txt: Added.
  • webgl/conformance/programs/invalid-UTF-16.html: Added.
  • webgl/conformance/programs/use-program-crash-with-discard-in-fragment-shader-expected.txt: Added.
  • webgl/conformance/programs/use-program-crash-with-discard-in-fragment-shader.html: Added.
  • webgl/resources/webgl_test_files/conformance/programs/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/programs/get-active-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/programs/gl-bind-attrib-location-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/programs/gl-get-active-attribute.html: Added.
  • webgl/resources/webgl_test_files/conformance/programs/gl-get-active-uniform.html: Added.
  • webgl/resources/webgl_test_files/conformance/programs/gl-getshadersource.html: Added.
  • webgl/resources/webgl_test_files/conformance/programs/gl-shader-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/programs/invalid-UTF-16.html: Added.
  • webgl/resources/webgl_test_files/conformance/programs/use-program-crash-with-discard-in-fragment-shader.html: Added.
5:01 AM Changeset in webkit [142099] by tonyg@chromium.org
  • 9 edits in trunk/Source/WebCore

Call XSSAuditor.filterToken() from threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=107603

Reviewed by Adam Barth.

With this patch we now pass 180 of 182 tests in http/tests/security/xssAuditor.

We do this by creating aan XSSAuditor on the main thread and passing ownership of them to the BackgroundHTMLParser upon its creation.

Then the background thread calls filterToken() and stores the resulting XSSInfo (if any) on the CompactHTMLToken for the main thread to handle.

This involved trimming the XSSAuditor to only depend on the TextEncoding instead of the whole TextResourceDecoder.

No new tests because covered by existing tests.

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(WebCore::BackgroundHTMLParser::createPartial):

  • html/parser/BackgroundHTMLParser.h:

(WebCore):
(WebCore::BackgroundHTMLParser::create):
(BackgroundHTMLParser):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::startBackgroundParser):

  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::start):
(WebCore::HTMLSourceTracker::end):

  • html/parser/HTMLSourceTracker.h: Change the HTMLInputStream args to SegmentedString because the background thread only has a BackgroundHTMLInputStream.

(HTMLSourceTracker):

  • html/parser/HTMLViewSourceParser.cpp:

(WebCore::HTMLViewSourceParser::pumpTokenizer):

  • html/parser/XSSAuditor.cpp:

(WebCore::fullyDecodeString):
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init): Copies necessary to make isSafeToSendToAnotherThread() happy.
(WebCore::XSSAuditor::decodedSnippetForName):
(WebCore::XSSAuditor::decodedSnippetForAttribute):
(WebCore::XSSAuditor::decodedSnippetForJavaScript):
(WebCore::XSSAuditor::isSafeToSendToAnotherThread): Check that all String and KURL members are safe to send to another thread.
(WebCore):

  • html/parser/XSSAuditor.h:

(WebCore):
(WebCore::FilterTokenRequest::FilterTokenRequest):
(FilterTokenRequest):
(XSSAuditor):

4:57 AM Changeset in webkit [142098] by Gregg Tavares
  • 1 edit
    38 adds in trunk/LayoutTests

Add WebGL Conformance Tests context folder.
https://bugs.webkit.org/show_bug.cgi?id=109114

Reviewed by Kenneth Russell.

  • webgl/conformance/context/constants-expected.txt: Added.
  • webgl/conformance/context/constants.html: Added.
  • webgl/conformance/context/context-attributes-alpha-depth-stencil-antialias-expected.txt: Added.
  • webgl/conformance/context/context-attributes-alpha-depth-stencil-antialias.html: Added.
  • webgl/conformance/context/context-lost-expected.txt: Added.
  • webgl/conformance/context/context-lost-restored-expected.txt: Added.
  • webgl/conformance/context/context-lost-restored.html: Added.
  • webgl/conformance/context/context-lost.html: Added.
  • webgl/conformance/context/context-release-upon-reload-expected.txt: Added.
  • webgl/conformance/context/context-release-upon-reload.html: Added.
  • webgl/conformance/context/context-release-with-workers-expected.txt: Added.
  • webgl/conformance/context/context-release-with-workers.html: Added.
  • webgl/conformance/context/context-type-test-expected.txt: Added.
  • webgl/conformance/context/context-type-test.html: Added.
  • webgl/conformance/context/incorrect-context-object-behaviour-expected.txt: Added.
  • webgl/conformance/context/incorrect-context-object-behaviour.html: Added.
  • webgl/conformance/context/methods-expected.txt: Added.
  • webgl/conformance/context/methods.html: Added.
  • webgl/conformance/context/premultiplyalpha-test-expected.txt: Added.
  • webgl/conformance/context/premultiplyalpha-test.html: Added.
  • webgl/conformance/context/resource-sharing-test-expected.txt: Added.
  • webgl/conformance/context/resource-sharing-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/context/constants.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/context-attributes-alpha-depth-stencil-antialias.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/context-lost-restored.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/context-lost.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/context-release-upon-reload.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/context-release-with-workers.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/context-type-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/incorrect-context-object-behaviour.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/methods.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/premultiplyalpha-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/resource-sharing-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/resources/context-release-child-with-worker.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/resources/context-release-upon-reload-child.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/resources/context-release-worker.js: Added.
4:43 AM Changeset in webkit [142097] by Gregg Tavares
  • 1 edit
    17 adds in trunk/LayoutTests

Add WebGL Conformance Tests uniforms folder.
https://bugs.webkit.org/show_bug.cgi?id=109112

Reviewed by Kenneth Russell.

  • webgl/conformance/uniforms/gl-uniform-bool-expected.txt: Added.
  • webgl/conformance/uniforms/gl-uniform-bool.html: Added.
  • webgl/conformance/uniforms/gl-uniformmatrix4fv-expected.txt: Added.
  • webgl/conformance/uniforms/gl-uniformmatrix4fv.html: Added.
  • webgl/conformance/uniforms/gl-unknown-uniform-expected.txt: Added.
  • webgl/conformance/uniforms/gl-unknown-uniform.html: Added.
  • webgl/conformance/uniforms/null-uniform-location-expected.txt: Added.
  • webgl/conformance/uniforms/null-uniform-location.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/gl-uniform-bool.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/gl-uniform-packing-restrictions.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/gl-uniform-struct-unused.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/gl-uniform-unused-array-elements-get-truncated.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/gl-uniformmatrix4fv.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/gl-unknown-uniform.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/null-uniform-location.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/out-of-bounds-uniform-array-access.html: Added.
4:39 AM Changeset in webkit [142096] by Gregg Tavares
  • 1 edit
    22 adds in trunk/LayoutTests

Add WebGL Conformance Tests canvas folder.
https://bugs.webkit.org/show_bug.cgi?id=109113

Reviewed by Kenneth Russell.

  • webgl/conformance/canvas/canvas-test-expected.txt: Added.
  • webgl/conformance/canvas/canvas-test.html: Added.
  • webgl/conformance/canvas/canvas-zero-size-expected.txt: Added.
  • webgl/conformance/canvas/canvas-zero-size.html: Added.
  • webgl/conformance/canvas/drawingbuffer-hd-dpi-test-expected.txt: Added.
  • webgl/conformance/canvas/drawingbuffer-hd-dpi-test.html: Added.
  • webgl/conformance/canvas/drawingbuffer-static-canvas-test-expected.txt: Added.
  • webgl/conformance/canvas/drawingbuffer-static-canvas-test.html: Added.
  • webgl/conformance/canvas/framebuffer-bindings-unaffected-on-resize-expected.txt: Added.
  • webgl/conformance/canvas/framebuffer-bindings-unaffected-on-resize.html: Added.
  • webgl/conformance/canvas/texture-bindings-unaffected-on-resize-expected.txt: Added.
  • webgl/conformance/canvas/texture-bindings-unaffected-on-resize.html: Added.
  • webgl/conformance/canvas/viewport-unchanged-upon-resize-expected.txt: Added.
  • webgl/conformance/canvas/viewport-unchanged-upon-resize.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/canvas-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/canvas-zero-size.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/drawingbuffer-hd-dpi-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/drawingbuffer-static-canvas-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/framebuffer-bindings-unaffected-on-resize.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/texture-bindings-unaffected-on-resize.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/viewport-unchanged-upon-resize.html: Added.
4:34 AM Changeset in webkit [142095] by michael.bruning@digia.com
  • 6 edits
    2 deletes in trunk/Source/WebKit2

[Qt][WK2] Fold QtWebPageLoadClient into QQuickWebViewPrivate and move to C API.
https://bugs.webkit.org/show_bug.cgi?id=108473

Reviewed by Simon Hausmann.
Signed off for WebKit2 by Benjamin Poulain.

This patch removes the QtWebPageLoadClient and moves the functionality into the
QQuickWebViewPrivate as most callback methods are calling the private webview
indirectly anyway.

The patch also moves as much of the functionality to the C API as is possible with
the current C API.

  • Target.pri:
  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::didStartProvisionalLoadForFrame):
(QQuickWebViewPrivate::didReceiveServerRedirectForProvisionalLoadForFrame):
(QQuickWebViewPrivate::didFailLoad):
(QQuickWebViewPrivate::didCommitLoadForFrame):
(QQuickWebViewPrivate::didFinishLoadForFrame):
(QQuickWebViewPrivate::didSameDocumentNavigationForFrame):
(QQuickWebViewPrivate::didReceiveTitleForFrame):
(QQuickWebViewPrivate::didStartProgress):
(QQuickWebViewPrivate::didChangeProgress):
(QQuickWebViewPrivate::didFinishProgress):
(QQuickWebViewPrivate::didChangeBackForwardList):
(QQuickWebViewPrivate::setTransparentBackground):
(QQuickWebViewPrivate::transparentBackground):
(QQuickWebViewPrivate::loadProgressDidChange):

  • UIProcess/API/qt/qquickwebview_p.h:

(WebKit):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(WebKit):
(QQuickWebViewPrivate):

  • UIProcess/qt/QtWebError.cpp:

(WebKit::QtWebError::url):

  • UIProcess/qt/QtWebPageLoadClient.cpp: Removed.
  • UIProcess/qt/QtWebPageLoadClient.h: Removed.
4:21 AM Changeset in webkit [142094] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk/Source

[GTK][AC] Implement opacity animation with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=108961

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-07
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Implement opacity animation with clutter ac backend.
Almost all implementations of GraphicsLayerClutter are based on mac port's one.
PlatformClutterAnimation interfaces are also similar with mac port, but they are implemented
with native clutter APIs.
This patch includes only opacity animation related changes, so many APIs might be empty.
Remained animations like rotation and translate will be dealt in another patches.

Covered by existing animation tests.

  • GNUmakefile.list.am:
  • platform/graphics/clutter/GraphicsLayerActor.cpp:

(graphicsLayerActorGetAnimationForKey):

  • platform/graphics/clutter/GraphicsLayerActor.h:
  • platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore):
(WebCore::propertyIdToString):
(WebCore::animationIdentifier):
(WebCore::animationHasStepsTimingFunction):
(WebCore::GraphicsLayerClutter::setOpacity):
(WebCore::GraphicsLayerClutter::updateAnimations):
(WebCore::GraphicsLayerClutter::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerClutter::setupAnimation):
(WebCore::GraphicsLayerClutter::timingFunctionForAnimationValue):
(WebCore::GraphicsLayerClutter::createBasicAnimation):
(WebCore::GraphicsLayerClutter::createKeyframeAnimation):
(WebCore::GraphicsLayerClutter::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerClutter::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):
(WebCore::GraphicsLayerClutter::createAnimationFromKeyframes):
(WebCore::GraphicsLayerClutter::addAnimation):
(WebCore::GraphicsLayerClutter::removeClutterAnimationFromLayer):
(WebCore::GraphicsLayerClutter::pauseClutterAnimationOnLayer):
(WebCore::GraphicsLayerClutter::setAnimationOnLayer):
(WebCore::GraphicsLayerClutter::setAnimationEndpoints):
(WebCore::GraphicsLayerClutter::setAnimationKeyframes):
(WebCore::GraphicsLayerClutter::animatedLayer):

  • platform/graphics/clutter/GraphicsLayerClutter.h:

(GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::LayerPropertyAnimation::LayerPropertyAnimation):
(LayerPropertyAnimation):
(WebCore::GraphicsLayerClutter::AnimationProcessingAction::AnimationProcessingAction):
(AnimationProcessingAction):

  • platform/graphics/clutter/PlatformClutterAnimation.cpp: Added.

(WebCore):
(WebCore::timelineStartedCallback):
(WebCore::toClutterAnimationMode):
(WebCore::PlatformClutterAnimation::stringToAnimatedPropertyType):
(WebCore::PlatformClutterAnimation::create):
(WebCore::PlatformClutterAnimation::PlatformClutterAnimation):
(WebCore::PlatformClutterAnimation::~PlatformClutterAnimation):
(WebCore::PlatformClutterAnimation::supportsValueFunction):
(WebCore::PlatformClutterAnimation::beginTime):
(WebCore::PlatformClutterAnimation::setBeginTime):
(WebCore::PlatformClutterAnimation::duration):
(WebCore::PlatformClutterAnimation::setDuration):
(WebCore::PlatformClutterAnimation::speed):
(WebCore::PlatformClutterAnimation::setSpeed):
(WebCore::PlatformClutterAnimation::timeOffset):
(WebCore::PlatformClutterAnimation::setTimeOffset):
(WebCore::PlatformClutterAnimation::repeatCount):
(WebCore::PlatformClutterAnimation::setRepeatCount):
(WebCore::PlatformClutterAnimation::autoreverses):
(WebCore::PlatformClutterAnimation::setAutoreverses):
(WebCore::PlatformClutterAnimation::fillMode):
(WebCore::PlatformClutterAnimation::setFillMode):
(WebCore::PlatformClutterAnimation::setTimingFunction):
(WebCore::PlatformClutterAnimation::copyTimingFunctionFrom):
(WebCore::PlatformClutterAnimation::isRemovedOnCompletion):
(WebCore::PlatformClutterAnimation::setRemovedOnCompletion):
(WebCore::PlatformClutterAnimation::isAdditive):
(WebCore::PlatformClutterAnimation::setAdditive):
(WebCore::PlatformClutterAnimation::valueFunction):
(WebCore::PlatformClutterAnimation::setValueFunction):
(WebCore::PlatformClutterAnimation::setFromValue):
(WebCore::PlatformClutterAnimation::copyFromValueFrom):
(WebCore::PlatformClutterAnimation::setToValue):
(WebCore::PlatformClutterAnimation::copyToValueFrom):
(WebCore::PlatformClutterAnimation::setValues):
(WebCore::PlatformClutterAnimation::copyValuesFrom):
(WebCore::PlatformClutterAnimation::setKeyTimes):
(WebCore::PlatformClutterAnimation::copyKeyTimesFrom):
(WebCore::PlatformClutterAnimation::setTimingFunctions):
(WebCore::PlatformClutterAnimation::copyTimingFunctionsFrom):
(WebCore::PlatformClutterAnimation::animationDidStart):
(WebCore::PlatformClutterAnimation::timeline):
(WebCore::PlatformClutterAnimation::addOpacityTransition):
(WebCore::PlatformClutterAnimation::addAnimationForKey):
(WebCore::PlatformClutterAnimation::removeAnimationForKey):

  • platform/graphics/clutter/PlatformClutterAnimation.h: Added.

(WebCore):
(PlatformClutterAnimation):
(WebCore::PlatformClutterAnimation::animationType):

Source/WebKit/gtk:

Add AnimationTrigger for ac compositing.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::allowedCompositingTriggers):

4:18 AM Changeset in webkit [142093] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Add null check to editable in moveCaretSelectionTowardsWindowPoint
https://bugs.webkit.org/show_bug.cgi?id=108962

Patch by David Trainor <dtrainor@chromium.org> on 2013-02-07
Reviewed by Eric Seidel.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):

  • tests/WebFrameTest.cpp:
3:57 AM Changeset in webkit [142092] by Gregg Tavares
  • 1 edit
    85 adds in trunk/LayoutTests

Add WebGL Conformance Tests texture folder.
https://bugs.webkit.org/show_bug.cgi?id=109111

Reviewed by Kenneth Russell.

  • webgl/conformance/textures/compressed-tex-image-expected.txt: Added.
  • webgl/conformance/textures/compressed-tex-image.html: Added.
  • webgl/conformance/textures/copy-tex-image-and-sub-image-2d-expected.txt: Added.
  • webgl/conformance/textures/copy-tex-image-and-sub-image-2d.html: Added.
  • webgl/conformance/textures/gl-get-tex-parameter-expected.txt: Added.
  • webgl/conformance/textures/gl-get-tex-parameter.html: Added.
  • webgl/conformance/textures/gl-teximage-expected.txt: Added.
  • webgl/conformance/textures/gl-teximage.html: Added.
  • webgl/conformance/textures/mipmap-fbo-expected.txt: Added.
  • webgl/conformance/textures/mipmap-fbo.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-array-buffer-view-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-array-buffer-view.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgb565-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgb565.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba4444-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba4444.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba5551-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba5551.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data.html: Added.
  • webgl/conformance/textures/tex-image-and-uniform-binding-bugs-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-uniform-binding-bugs.html: Added.
  • webgl/conformance/textures/tex-image-webgl-expected.txt: Added.
  • webgl/conformance/textures/tex-image-webgl.html: Added.
  • webgl/conformance/textures/tex-image-with-format-and-type-expected.txt: Added.
  • webgl/conformance/textures/tex-image-with-format-and-type.html: Added.
  • webgl/conformance/textures/tex-image-with-invalid-data-expected.txt: Added.
  • webgl/conformance/textures/tex-image-with-invalid-data.html: Added.
  • webgl/conformance/textures/tex-input-validation-expected.txt: Added.
  • webgl/conformance/textures/tex-input-validation.html: Added.
  • webgl/conformance/textures/tex-sub-image-2d-bad-args-expected.txt: Added.
  • webgl/conformance/textures/tex-sub-image-2d-bad-args.html: Added.
  • webgl/conformance/textures/tex-sub-image-2d-expected.txt: Added.
  • webgl/conformance/textures/tex-sub-image-2d.html: Added.
  • webgl/conformance/textures/texparameter-test-expected.txt: Added.
  • webgl/conformance/textures/texparameter-test.html: Added.
  • webgl/conformance/textures/texture-attachment-formats-expected.txt: Added.
  • webgl/conformance/textures/texture-attachment-formats.html: Added.
  • webgl/conformance/textures/texture-clear-expected.txt: Added.
  • webgl/conformance/textures/texture-clear.html: Added.
  • webgl/conformance/textures/texture-complete-expected.txt: Added.
  • webgl/conformance/textures/texture-complete.html: Added.
  • webgl/conformance/textures/texture-formats-test-expected.txt: Added.
  • webgl/conformance/textures/texture-formats-test.html: Added.
  • webgl/conformance/textures/texture-hd-dpi-expected.txt: Added.
  • webgl/conformance/textures/texture-hd-dpi.html: Added.
  • webgl/conformance/textures/texture-npot-expected.txt: Added.
  • webgl/conformance/textures/texture-npot.html: Added.
  • webgl/conformance/textures/texture-size-cube-maps-expected.txt: Added.
  • webgl/conformance/textures/texture-size-cube-maps.html: Added.
  • webgl/conformance/textures/texture-sub-image-cube-maps-expected.txt: Added.
  • webgl/conformance/textures/texture-sub-image-cube-maps.html: Added.
  • webgl/conformance/textures/texture-transparent-pixels-initialized-expected.txt: Added.
  • webgl/conformance/textures/texture-transparent-pixels-initialized.html: Added.
  • webgl/conformance/textures/texture-upload-cube-maps-expected.txt: Added.
  • webgl/conformance/textures/texture-upload-cube-maps.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/textures/compressed-tex-image.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/copy-tex-image-and-sub-image-2d.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/gl-get-tex-parameter.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/gl-teximage.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/mipmap-fbo.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-array-buffer-view.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgb565.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba4444.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba5551.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-data.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-uniform-binding-bugs.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-webgl.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-with-format-and-type.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-with-invalid-data.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-input-validation.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-sub-image-2d-bad-args.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-sub-image-2d.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texparameter-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-attachment-formats.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-clear.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-complete.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-formats-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-hd-dpi.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-npot.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-size-cube-maps.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-sub-image-cube-maps.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-transparent-pixels-initialized.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-upload-cube-maps.html: Added.
3:51 AM Changeset in webkit [142091] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

Web Inspector: highlight matching braces in DTE.
https://bugs.webkit.org/show_bug.cgi?id=108697

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-07
Reviewed by Pavel Feldman.

Source/WebCore:

Implement BraceMatcher class which for given position in textModel
will respond with enclosing brace pair for that position.
Make use of this class in DefaultTextEditor by handling
selectionChange event. Make use of this class in "_closingBlockOffset"
method of TextEditorMainPanel as this method implements similar
functionality.

New test: inspector/editor/brace-matcher.html

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._closingBlockOffset):
(WebInspector.TextEditorMainPanel.prototype._handleSelectionChange):
(WebInspector.TextEditorMainPanel.BraceHighlightController):
(WebInspector.TextEditorMainPanel.BraceHighlightController.prototype.handleSelectionChange):

  • inspector/front-end/TextEditorHighlighter.js:

(WebInspector.TextEditorHighlighter.prototype._highlightLines):

  • inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorModel.endsWithBracketRegex):
(WebInspector.TextEditorModel.endsWithBracketRegex.):

  • inspector/front-end/textEditor.css:

(.text-editor-brace-match):

LayoutTests:

New layout test to verify brace matching functionality. Fix some
layout test expectations as the patch removes braces from highlight
ranges.

  • inspector/editor/brace-matcher-expected.txt: Added.
  • inspector/editor/brace-matcher.html: Added.
  • inspector/editor/highlighter-basics-expected.txt:
  • inspector/editor/text-editor-long-line-expected.txt:
3:46 AM Changeset in webkit [142090] by jochen@chromium.org
  • 31 edits
    3 copies in trunk/Tools

[chromium] turn TestRunner library into a component build
https://bugs.webkit.org/show_bug.cgi?id=108466

Reviewed by Adam Barth.

To achieve this, we need to drop all dependencies on WTF.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTask.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
  • DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:

(AccessibilityUIElementList):

  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:

(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):

  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:

(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):

  • DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:

(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):

  • DumpRenderTree/chromium/TestRunner/src/CppVariant.h:

(CppVariant):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):

  • DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:

(WebTestRunner::NativeKeyCodeForWindowsKeyCode):

  • DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:

(WebTestRunner::MockGrammarCheck::checkGrammarOfString):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:

(WebTestRunner):
(MockGrammarCheck):

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:

(WebTestRunner::MockSpellCheck::spellCheckWord):
(WebTestRunner::MockSpellCheck::initializeIfNeeded):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:

(MockSpellCheck):

  • DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:

(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):

  • DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.

(isASCIIAlpha):
(isNotASCIIAlpha):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:

(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:

(TestPlugin):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner::TestRunner::deliverWebIntent):
(WebTestRunner::TestRunner::setBackingScaleFactor):
(WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
(WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
(WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
(WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:

(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):

  • DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):

  • DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:

(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):

  • DumpRenderTree/chromium/TestRunner/src/config.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
3:21 AM Changeset in webkit [142089] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r180752. Requested by
thakis_ via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-07

  • DEPS:
3:02 AM Changeset in webkit [142088] by abecsi@webkit.org
  • 8 edits in trunk

[Qt] Use GNU ar's thin archive format for intermediate static libs
https://bugs.webkit.org/show_bug.cgi?id=109052

Reviewed by Jocelyn Turcotte.

Source/JavaScriptCore:

Adjust project files that used activeBuildConfig()
to use targetSubDir().

Tools:

With debug builds we exceed the 4GiB limit of GNU ar when creating the WebCore
intermediate static library which results in build failure even with a x86_64
toolchain (http://sourceware.org/bugzilla/show_bug.cgi?id=14625).

When using a GNU toolchain we can use the thin archive format for these static
libraries which also has the benefit of not copying the object files, thus
drastically reducing disk usage and overall compile time.

Currently qmake does not support GNU ar's thin archive format so for
now we need to do the magic in the build system as a stopgap solution.

  • qmake/mkspecs/features/configure.prf:
  • qmake/mkspecs/features/default_post.prf:
  • qmake/mkspecs/features/functions.prf:
3:01 AM Changeset in webkit [142087] by rakuco@webkit.org
  • 5 edits in trunk/Source

[EFL][WK2] Refactoring initialization and shutdown codes of EFL libraries.
https://bugs.webkit.org/show_bug.cgi?id=97173

Reviewed by Kenneth Rohde Christiansen, signed-off by Benjamin Poulain.

Source/WebCore:

Remove codes to initialize and shutdown the EFL libraries from
RunLoopEfl.cpp. Initialization and shutdown will be done in the
ewk_main.cpp for ui process and WebProcessMainEfl.cpp for web
process.

No new tests. This patch doesn't change behavior.

  • platform/efl/RunLoopEfl.cpp:

(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):

Source/WebKit2:

Initialize and shutdown the EFL libraries in the ewk_main.cpp for
UIProcess and WebProcessMainEfl.cpp for WebProcess.

This allows us to shut down the libraries in a proper way, since
RunLoop persist until the process exits.

  • UIProcess/API/efl/ewk_main.cpp:

(ewk_init):
(ewk_shutdown):

  • WebProcess/efl/WebProcessMainEfl.cpp:

(WebKit::WebProcessMainEfl):

2:05 AM Changeset in webkit [142086] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed fix for inspector tests in debug.
m_frontend should be initialized in constructor.

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):

1:37 AM Changeset in webkit [142085] by pfeldman@chromium.org
  • 18 edits in branches/chromium/1364

Merge 140539

Web Inspector: only allow evaluateForTestInFrontend for front-ends under test.
https://bugs.webkit.org/show_bug.cgi?id=107523

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::isUnderTest):
(WebCore):
(WebCore::InspectorController::evaluateForTestInFrontend):

  • inspector/InspectorController.h:

(InspectorController):

  • inspector/InspectorFrontendClient.h:

(InspectorFrontendClient):

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::canAttachWindow):
(WebCore::InspectorFrontendClientLocal::isUnderTest):
(WebCore):

  • inspector/InspectorFrontendClientLocal.h:

(InspectorFrontendClientLocal):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::isUnderTest):
(WebCore):

  • inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/DOMExtension.js:
  • inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.canInspectWorkers):
(.WebInspector.InspectorFrontendHostStub.prototype.isUnderTest):

  • inspector/front-end/TestController.js:

(.invokeMethod):
(WebInspector.evaluateForTestInFrontend):

  • inspector/front-end/externs.js:

Source/WebKit/chromium:

  • public/WebDevToolsFrontendClient.h:

(WebKit::WebDevToolsFrontendClient::isUnderTest):
(WebDevToolsFrontendClient):

  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::isUnderTest):

  • src/InspectorFrontendClientImpl.h:

(InspectorFrontendClientImpl):

Tools:

  • DumpRenderTree/chromium/DRTDevToolsClient.cpp:

(DRTDevToolsClient::isUnderTest):
(DRTDevToolsClient::call):

  • DumpRenderTree/chromium/DRTDevToolsClient.h:

(DRTDevToolsClient):

TBR=pfeldman@chromium.org
Review URL: https://codereview.chromium.org/12224049

1:24 AM Changeset in webkit [142084] by falken@chromium.org
  • 4 edits
    249 deletes in trunk/LayoutTests

Rollout r142058 various crashes and timeouts on AppleMac and Chromium
https://bugs.webkit.org/show_bug.cgi?id=109152

Reviewed by Pavel Feldman.

Unreviewed gardening. r142058 added failing tests and marked many as
Skip or Failure but there are also Timeouts and Crashes causing
redness.

  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
  • webgl/conformance/canvas/buffer-offscreen-test-expected.txt: Removed.
  • webgl/conformance/canvas/buffer-offscreen-test.html: Removed.
  • webgl/conformance/canvas/buffer-preserve-test-expected.txt: Removed.
  • webgl/conformance/canvas/buffer-preserve-test.html: Removed.
  • webgl/conformance/canvas/drawingbuffer-test-expected.txt: Removed.
  • webgl/conformance/canvas/drawingbuffer-test.html: Removed.
  • webgl/conformance/canvas/to-data-url-test-expected.txt: Removed.
  • webgl/conformance/canvas/to-data-url-test.html: Removed.
  • webgl/conformance/context/context-attribute-preserve-drawing-buffer-expected.txt: Removed.
  • webgl/conformance/context/context-attribute-preserve-drawing-buffer.html: Removed.
  • webgl/conformance/context/context-creation-and-destruction-expected.txt: Removed.
  • webgl/conformance/context/context-creation-and-destruction.html: Removed.
  • webgl/conformance/glsl/functions/glsl-function-smoothstep-gentype-expected.txt: Removed.
  • webgl/conformance/glsl/functions/glsl-function-smoothstep-gentype.html: Removed.
  • webgl/conformance/glsl/literals/float_literal.vert-expected.txt: Removed.
  • webgl/conformance/glsl/literals/float_literal.vert.html: Removed.
  • webgl/conformance/glsl/misc/shader-uniform-packing-restrictions-expected.txt: Removed.
  • webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html: Removed.
  • webgl/conformance/glsl/misc/shader-varying-packing-restrictions-expected.txt: Removed.
  • webgl/conformance/glsl/misc/shader-varying-packing-restrictions.html: Removed.
  • webgl/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays-expected.txt: Removed.
  • webgl/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Removed.
  • webgl/conformance/glsl/misc/shader-with-global-variable-precision-mismatch-expected.txt: Removed.
  • webgl/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html: Removed.
  • webgl/conformance/glsl/misc/shader-with-non-reserved-words-expected.txt: Removed.
  • webgl/conformance/glsl/misc/shader-with-non-reserved-words.html: Removed.
  • webgl/conformance/glsl/misc/shader-with-short-circuiting-operators-expected.txt: Removed.
  • webgl/conformance/glsl/misc/shader-with-short-circuiting-operators.html: Removed.
  • webgl/conformance/glsl/misc/shader-with-similar-uniform-array-names-expected.txt: Removed.
  • webgl/conformance/glsl/misc/shader-with-similar-uniform-array-names.html: Removed.
  • webgl/conformance/glsl/misc/shaders-with-varyings-expected.txt: Removed.
  • webgl/conformance/glsl/misc/shaders-with-varyings.html: Removed.
  • webgl/conformance/glsl/variables/gl-pointcoord-expected.txt: Removed.
  • webgl/conformance/glsl/variables/gl-pointcoord.html: Removed.
  • webgl/conformance/more/conformance/quickCheckAPI-A-expected.txt: Removed.
  • webgl/conformance/more/conformance/quickCheckAPI-A.html: Removed.
  • webgl/conformance/more/conformance/quickCheckAPI-B1-expected.txt: Removed.
  • webgl/conformance/more/conformance/quickCheckAPI-B1.html: Removed.
  • webgl/conformance/more/conformance/quickCheckAPI-B2-expected.txt: Removed.
  • webgl/conformance/more/conformance/quickCheckAPI-B2.html: Removed.
  • webgl/conformance/more/conformance/quickCheckAPI-B3-expected.txt: Removed.
  • webgl/conformance/more/conformance/quickCheckAPI-B3.html: Removed.
  • webgl/conformance/more/conformance/quickCheckAPI-B4-expected.txt: Removed.
  • webgl/conformance/more/conformance/quickCheckAPI-B4.html: Removed.
  • webgl/conformance/more/conformance/quickCheckAPI-C-expected.txt: Removed.
  • webgl/conformance/more/conformance/quickCheckAPI-C.html: Removed.
  • webgl/conformance/more/conformance/quickCheckAPI-D_G-expected.txt: Removed.
  • webgl/conformance/more/conformance/quickCheckAPI-D_G.html: Removed.
  • webgl/conformance/more/conformance/quickCheckAPI-G_I-expected.txt: Removed.
  • webgl/conformance/more/conformance/quickCheckAPI-G_I.html: Removed.
  • webgl/conformance/more/conformance/quickCheckAPI-L_S-expected.txt: Removed.
  • webgl/conformance/more/conformance/quickCheckAPI-L_S.html: Removed.
  • webgl/conformance/more/conformance/quickCheckAPI-S_V-expected.txt: Removed.
  • webgl/conformance/more/conformance/quickCheckAPI-S_V.html: Removed.
  • webgl/conformance/more/functions/bufferDataBadArgs-expected.txt: Removed.
  • webgl/conformance/more/functions/bufferDataBadArgs.html: Removed.
  • webgl/conformance/more/functions/copyTexImage2D-expected.txt: Removed.
  • webgl/conformance/more/functions/copyTexImage2D.html: Removed.
  • webgl/conformance/more/functions/copyTexImage2DBadArgs-expected.txt: Removed.
  • webgl/conformance/more/functions/copyTexImage2DBadArgs.html: Removed.
  • webgl/conformance/more/functions/copyTexSubImage2D-expected.txt: Removed.
  • webgl/conformance/more/functions/copyTexSubImage2D.html: Removed.
  • webgl/conformance/more/functions/copyTexSubImage2DBadArgs-expected.txt: Removed.
  • webgl/conformance/more/functions/copyTexSubImage2DBadArgs.html: Removed.
  • webgl/conformance/more/functions/deleteBufferBadArgs-expected.txt: Removed.
  • webgl/conformance/more/functions/deleteBufferBadArgs.html: Removed.
  • webgl/conformance/more/functions/drawArrays-expected.txt: Removed.
  • webgl/conformance/more/functions/drawArrays.html: Removed.
  • webgl/conformance/more/functions/drawArraysOutOfBounds-expected.txt: Removed.
  • webgl/conformance/more/functions/drawArraysOutOfBounds.html: Removed.
  • webgl/conformance/more/functions/drawElements-expected.txt: Removed.
  • webgl/conformance/more/functions/drawElements.html: Removed.
  • webgl/conformance/more/functions/drawElementsBadArgs-expected.txt: Removed.
  • webgl/conformance/more/functions/drawElementsBadArgs.html: Removed.
  • webgl/conformance/more/functions/readPixelsBadArgs-expected.txt: Removed.
  • webgl/conformance/more/functions/readPixelsBadArgs.html: Removed.
  • webgl/conformance/more/functions/texImage2DBadArgs-expected.txt: Removed.
  • webgl/conformance/more/functions/texImage2DBadArgs.html: Removed.
  • webgl/conformance/more/functions/texImage2DHTML-expected.txt: Removed.
  • webgl/conformance/more/functions/texImage2DHTML.html: Removed.
  • webgl/conformance/more/functions/texSubImage2DBadArgs-expected.txt: Removed.
  • webgl/conformance/more/functions/texSubImage2DBadArgs.html: Removed.
  • webgl/conformance/more/functions/texSubImage2DHTML-expected.txt: Removed.
  • webgl/conformance/more/functions/texSubImage2DHTML.html: Removed.
  • webgl/conformance/ogles/GL/acos/acos_001_to_006-expected.txt: Removed.
  • webgl/conformance/ogles/GL/acos/acos_001_to_006.html: Removed.
  • webgl/conformance/ogles/GL/asin/asin_001_to_006-expected.txt: Removed.
  • webgl/conformance/ogles/GL/asin/asin_001_to_006.html: Removed.
  • webgl/conformance/ogles/GL/atan/atan_001_to_008-expected.txt: Removed.
  • webgl/conformance/ogles/GL/atan/atan_001_to_008.html: Removed.
  • webgl/conformance/ogles/GL/control_flow/control_flow_001_to_008-expected.txt: Removed.
  • webgl/conformance/ogles/GL/control_flow/control_flow_001_to_008.html: Removed.
  • webgl/conformance/ogles/GL/log/log_001_to_008-expected.txt: Removed.
  • webgl/conformance/ogles/GL/log/log_001_to_008.html: Removed.
  • webgl/conformance/ogles/GL/log2/log2_001_to_008-expected.txt: Removed.
  • webgl/conformance/ogles/GL/log2/log2_001_to_008.html: Removed.
  • webgl/conformance/ogles/GL/smoothstep/smoothstep_001_to_006-expected.txt: Removed.
  • webgl/conformance/ogles/GL/smoothstep/smoothstep_001_to_006.html: Removed.
  • webgl/conformance/programs/gl-bind-attrib-location-long-names-test-expected.txt: Removed.
  • webgl/conformance/programs/gl-bind-attrib-location-long-names-test.html: Removed.
  • webgl/conformance/programs/program-test-expected.txt: Removed.
  • webgl/conformance/programs/program-test.html: Removed.
  • webgl/conformance/reading/read-pixels-test-expected.txt: Removed.
  • webgl/conformance/reading/read-pixels-test.html: Removed.
  • webgl/conformance/renderbuffers/framebuffer-object-attachment-expected.txt: Removed.
  • webgl/conformance/renderbuffers/framebuffer-object-attachment.html: Removed.
  • webgl/conformance/rendering/gl-scissor-test-expected.txt: Removed.
  • webgl/conformance/rendering/gl-scissor-test.html: Removed.
  • webgl/conformance/rendering/more-than-65536-indices-expected.txt: Removed.
  • webgl/conformance/rendering/more-than-65536-indices.html: Removed.
  • webgl/conformance/rendering/multisample-corruption-expected.txt: Removed.
  • webgl/conformance/rendering/multisample-corruption.html: Removed.
  • webgl/conformance/rendering/point-size-expected.txt: Removed.
  • webgl/conformance/rendering/point-size.html: Removed.
  • webgl/conformance/state/gl-object-get-calls-expected.txt: Removed.
  • webgl/conformance/state/gl-object-get-calls.html: Removed.
  • webgl/conformance/textures/copy-tex-image-2d-formats-expected.txt: Removed.
  • webgl/conformance/textures/copy-tex-image-2d-formats.html: Removed.
  • webgl/conformance/textures/gl-pixelstorei-expected.txt: Removed.
  • webgl/conformance/textures/gl-pixelstorei.html: Removed.
  • webgl/conformance/textures/origin-clean-conformance-expected.txt: Removed.
  • webgl/conformance/textures/origin-clean-conformance.html: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-expected.txt: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565-expected.txt: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444-expected.txt: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551-expected.txt: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-expected.txt: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565-expected.txt: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444-expected.txt: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551-expected.txt: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image.html: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-expected.txt: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565-expected.txt: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444-expected.txt: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551-expected.txt: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html: Removed.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video.html: Removed.
  • webgl/conformance/textures/texture-active-bind-2-expected.txt: Removed.
  • webgl/conformance/textures/texture-active-bind-2.html: Removed.
  • webgl/conformance/textures/texture-active-bind-expected.txt: Removed.
  • webgl/conformance/textures/texture-active-bind.html: Removed.
  • webgl/conformance/textures/texture-mips-expected.txt: Removed.
  • webgl/conformance/textures/texture-mips.html: Removed.
  • webgl/conformance/textures/texture-npot-video-expected.txt: Removed.
  • webgl/conformance/textures/texture-npot-video.html: Removed.
  • webgl/conformance/textures/texture-size-expected.txt: Removed.
  • webgl/conformance/textures/texture-size-limit-expected.txt: Removed.
  • webgl/conformance/textures/texture-size-limit.html: Removed.
  • webgl/conformance/textures/texture-size.html: Removed.
  • webgl/conformance/uniforms/gl-uniform-arrays-expected.txt: Removed.
  • webgl/conformance/uniforms/gl-uniform-arrays.html: Removed.
  • webgl/conformance/uniforms/uniform-default-values-expected.txt: Removed.
  • webgl/conformance/uniforms/uniform-default-values.html: Removed.
  • webgl/conformance/uniforms/uniform-location-expected.txt: Removed.
  • webgl/conformance/uniforms/uniform-location.html: Removed.
  • webgl/conformance/uniforms/uniform-samplers-test-expected.txt: Removed.
  • webgl/conformance/uniforms/uniform-samplers-test.html: Removed.
  • webgl/resources/webgl_test_files/conformance/canvas/buffer-offscreen-test.html: Removed.
  • webgl/resources/webgl_test_files/conformance/canvas/buffer-preserve-test.html: Removed.
  • webgl/resources/webgl_test_files/conformance/canvas/drawingbuffer-test.html: Removed.
  • webgl/resources/webgl_test_files/conformance/canvas/to-data-url-test.html: Removed.
  • webgl/resources/webgl_test_files/conformance/context/context-attribute-preserve-drawing-buffer.html: Removed.
  • webgl/resources/webgl_test_files/conformance/context/context-creation-and-destruction.html: Removed.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-smoothstep-gentype.html: Removed.
  • webgl/resources/webgl_test_files/conformance/glsl/literals/float_literal.vert.html: Removed.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-uniform-packing-restrictions.html: Removed.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-varying-packing-restrictions.html: Removed.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Removed.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html: Removed.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-non-reserved-words.html: Removed.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-short-circuiting-operators.html: Removed.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-similar-uniform-array-names.html: Removed.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shaders-with-varyings.html: Removed.
  • webgl/resources/webgl_test_files/conformance/glsl/variables/gl-pointcoord.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-A.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B1.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B2.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B3.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B4.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-C.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-D_G.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-G_I.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-L_S.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-S_V.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/functions/bufferDataBadArgs.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/functions/copyTexImage2D.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/functions/copyTexImage2DBadArgs.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/functions/copyTexSubImage2D.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/functions/copyTexSubImage2DBadArgs.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/functions/deleteBufferBadArgs.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/functions/drawArrays.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/functions/drawArraysOutOfBounds.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/functions/drawElements.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/functions/drawElementsBadArgs.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/functions/readPixelsBadArgs.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/functions/texImage2DBadArgs.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/functions/texImage2DHTML.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DBadArgs.html: Removed.
  • webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DHTML.html: Removed.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_001_to_006.html: Removed.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_001_to_006.html: Removed.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_001_to_008.html: Removed.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/control_flow_001_to_008.html: Removed.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_001_to_008.html: Removed.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_001_to_008.html: Removed.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_001_to_006.html: Removed.
  • webgl/resources/webgl_test_files/conformance/programs/gl-bind-attrib-location-long-names-test.html: Removed.
  • webgl/resources/webgl_test_files/conformance/programs/program-test.html: Removed.
  • webgl/resources/webgl_test_files/conformance/reading/read-pixels-test.html: Removed.
  • webgl/resources/webgl_test_files/conformance/renderbuffers/framebuffer-object-attachment.html: Removed.
  • webgl/resources/webgl_test_files/conformance/rendering/gl-scissor-test.html: Removed.
  • webgl/resources/webgl_test_files/conformance/rendering/more-than-65536-indices.html: Removed.
  • webgl/resources/webgl_test_files/conformance/rendering/multisample-corruption.html: Removed.
  • webgl/resources/webgl_test_files/conformance/rendering/point-size.html: Removed.
  • webgl/resources/webgl_test_files/conformance/state/gl-object-get-calls.html: Removed.
  • webgl/resources/webgl_test_files/conformance/textures/copy-tex-image-2d-formats.html: Removed.
  • webgl/resources/webgl_test_files/conformance/textures/gl-pixelstorei.html: Removed.
  • webgl/resources/webgl_test_files/conformance/textures/origin-clean-conformance.html: Removed.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html: Removed.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html: Removed.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html: Removed.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html: Removed.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html: Removed.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html: Removed.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html: Removed.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image.html: Removed.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html: Removed.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html: Removed.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html: Removed.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video.html: Removed.
  • webgl/resources/webgl_test_files/conformance/textures/texture-active-bind-2.html: Removed.
  • webgl/resources/webgl_test_files/conformance/textures/texture-active-bind.html: Removed.
  • webgl/resources/webgl_test_files/conformance/textures/texture-mips.html: Removed.
  • webgl/resources/webgl_test_files/conformance/textures/texture-npot-video.html: Removed.
  • webgl/resources/webgl_test_files/conformance/textures/texture-size-limit.html: Removed.
  • webgl/resources/webgl_test_files/conformance/textures/texture-size.html: Removed.
  • webgl/resources/webgl_test_files/conformance/uniforms/gl-uniform-arrays.html: Removed.
  • webgl/resources/webgl_test_files/conformance/uniforms/uniform-default-values.html: Removed.
  • webgl/resources/webgl_test_files/conformance/uniforms/uniform-location.html: Removed.
  • webgl/resources/webgl_test_files/conformance/uniforms/uniform-samplers-test.html: Removed.
1:11 AM Changeset in webkit [142083] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing WebGL tests.

  • platform/qt/TestExpectations:
1:10 AM Changeset in webkit [142082] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix.

  • UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::processDidClose):
m_process can't be initialized nullptr yet. Use 0 instead of nullptr.

1:09 AM Changeset in webkit [142081] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: reduce number of native memory instrumentation categories
https://bugs.webkit.org/show_bug.cgi?id=109146

Reviewed by Pavel Feldman.

Merged some of memory instrumentation categories.

  • dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

  • platform/PlatformMemoryInstrumentation.cpp:

(WebCore):

1:03 AM Changeset in webkit [142080] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebCore/inspector/InspectorOverlay.cpp

Merge 141772

Web Inspector: take page scale factor into account when updating overlay.
https://bugs.webkit.org/show_bug.cgi?id=108831

Reviewed by Vsevolod Vlasov.

Otherwise, the ports that use page scale factor have broken overlay.

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::update):

TBR=pfeldman@chromium.org
Review URL: https://codereview.chromium.org/12217060

1:01 AM Changeset in webkit [142079] by falken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r142067.
http://trac.webkit.org/changeset/142067
https://bugs.webkit.org/show_bug.cgi?id=109147

adding Slow modifier did not help completely (Requested by
falken on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-07

  • platform/chromium/TestExpectations:
12:59 AM Changeset in webkit [142078] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Expanding failure expectation for fast/dom/Window/slow-unload-handler.html.
Adding failure expectation for the new fast/css/negative-text-indent-in-inline-block.html
layout tests.

  • platform/gtk/TestExpectations:
12:42 AM Changeset in webkit [142077] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

[V8] Remove V8GCController::m_edenNodes and make minor DOM GC more precise
https://bugs.webkit.org/show_bug.cgi?id=108579

Reviewed by Adam Barth.

Currently V8GCController::m_edenNodes stores a list of nodes whose
wrappers have been created since the latest GC. The reason why we
needed m_edenNodes is that there was no way to know a list of wrappers
in the new space of V8. By using m_edenNodes, we had been approximating
'wrappers in the new space' by 'wrappers that have been created since
the latest GC'.

Now V8 provides VisitHandlesForPartialDependence(), with which WebKit
can know a list of wrappers in the new space. By using the API, we can
remove V8GCController::m_edenNodes. The benefit is that (1) we no longer
need to keep m_edenNodes and that (2) it enables more precise minor
DOM GC (Remember that m_edenNodes was just an approximation).

Performance benchmark: https://bugs.webkit.org/attachment.cgi?id=185940
The benchmark runs 300 iterations, each of which creates 100000 elements.
The benchmark measures average, min, median, max and stdev of execution times
of the 300 iterations. This will tell us the worst-case overhead of this change.

Before:

mean=59.91ms, min=39ms, median=42ms, max=258ms, stdev=47.48ms

After:

mean=58.75ms, min=35ms, median=41ms, max=250ms, stdev=47.32ms

As shown above, I couldn't observe any performance regression.

No tests. No change in behavior.

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::setWrapperInObject):

  • bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::getWorldWithoutContextCheck):

  • bindings/v8/V8Binding.h:

(WebCore):
(WebCore::worldForEnteredContextIfIsolated):
(WebCore::worldForEnteredContextWithoutContextCheck):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):

  • bindings/v8/V8GCController.cpp:

(WebCore::gcTree):
(WebCore):
(MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::notifyFinished):
(WebCore::MajorGCWrapperVisitor::MajorGCWrapperVisitor):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):

  • bindings/v8/V8GCController.h:

(V8GCController):

12:40 AM Changeset in webkit [142076] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r141195): INPUT_MULTIPLE_FIELDS_UI: Space in a placeholder string is removed
https://bugs.webkit.org/show_bug.cgi?id=109132

Reviewed by Hajime Morita.

<input type=date> should be shown in Japanese UI as:
[ 年 /月/日]
But it is shown wrongly since r141195:
[年 /月/日]

We should use white-space:pre.

No new tests. This change is not testable in WebKit because this
requires a Japanese-localized UI string of Chromium.

  • css/html.css:

(input::-webkit-datetime-edit-fields-wrapper):
Use white-space:pre instead of nowrap.

12:38 AM Changeset in webkit [142075] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove DOMWindow::parseModalDialogFeatures()
https://bugs.webkit.org/show_bug.cgi?id=109139

Reviewed by Kent Tamura.

No one uses the method. FIXME is saying:

FIXME: We can remove this function once V8 showModalDialog is changed to use DOMWindow.

Given that V8's showModalDialog() is now using DOMWindow, we can remove it.

No tests. No change in behavior.

  • page/DOMWindow.cpp:
  • page/DOMWindow.h:

(DOMWindow):

12:38 AM Changeset in webkit [142074] by loislo@chromium.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: reduce native heap snapshot runtime memory footprint
https://bugs.webkit.org/show_bug.cgi?id=108824

Reviewed by Yury Semikhatsky.

New event was added into Memory domain addNativeSnapshotChunk.
The content of HeapGraphSerializer is completely rewritten according to new API.
Now it collects strings, nodes, edges and id2id map and pushes when the collected items count exceed a limit.
On the frontend side I added new method for the new event and fixed the postprocessing step.
MemoryInstrumentation was slightly changed. Now it reports base to real address map only after reporting the node with real address.

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::pushUpdateIfNeed):
(WebCore):
(WebCore::HeapGraphSerializer::pushUpdate):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::reportNodeImpl):
(WebCore::HeapGraphSerializer::reportEdge):
(WebCore::HeapGraphSerializer::reportEdgeImpl):
(WebCore::HeapGraphSerializer::reportLeaf):
(WebCore::HeapGraphSerializer::reportBaseAddress):
(WebCore::HeapGraphSerializer::finish):
(WebCore::HeapGraphSerializer::reportMemoryUsage):
(WebCore::HeapGraphSerializer::addString):
(WebCore::HeapGraphSerializer::toNodeId):
(WebCore::HeapGraphSerializer::addRootNode):

  • inspector/HeapGraphSerializer.h:

(HeapGraphSerializer):

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::processMemoryDistribution):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionMap):
(WebCore):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):
(WebCore::InspectorMemoryAgent::setFrontend):
(WebCore::InspectorMemoryAgent::clearFrontend):

  • inspector/InspectorMemoryAgent.h:

(InspectorMemoryAgent):

  • inspector/front-end/NativeHeapSnapshot.js:

(WebInspector.NativeHeapSnapshot):
(WebInspector.NativeHeapSnapshotNode.prototype.classIndex):
(WebInspector.NativeHeapSnapshotNode.prototype.id):
(WebInspector.NativeHeapSnapshotNode.prototype.name):
(WebInspector.NativeHeapSnapshotNode.prototype.serialize):

  • inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked):
(WebInspector.NativeSnapshotProfileHeader):
(WebInspector.NativeSnapshotProfileHeader.prototype.startSnapshotTransfer):
(WebInspector.NativeSnapshotProfileHeader.prototype.addNativeSnapshotChunk):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked):
(WebInspector.NativeMemoryBarChart.prototype._updateStats):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel):
(WebInspector.MemoryDispatcher):
(WebInspector.MemoryDispatcher.prototype.addNativeSnapshotChunk):

12:34 AM Changeset in webkit [142073] by Simon Hausmann
  • 4 edits
    2 deletes in trunk/Source/WebKit2

[Qt][WK2] Fold QtWebPageFindClient into QQuickWebViewPrivate
https://bugs.webkit.org/show_bug.cgi?id=108920

Reviewed by Jocelyn Turcotte, signed off for WK2 by Benjamin.

Employ the pattern suggested by Jocelyn to simply implement the C
callbacks directly using static functions.

  • Target.pri:
  • UIProcess/API/qt/qquickwebview.cpp:

(toQQuickWebViewPrivate):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::didFindString):
(QQuickWebViewPrivate::didFailToFindString):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

  • UIProcess/qt/QtWebPageFindClient.cpp: Removed.
  • UIProcess/qt/QtWebPageFindClient.h: Removed.
12:30 AM Changeset in webkit [142072] by haraken@chromium.org
  • 18 edits
    5 adds in trunk

WebKit's focus events are UIEvents (instead of FocusEvent) and thus don't expose .relatedTarget
https://bugs.webkit.org/show_bug.cgi?id=76216

Reviewed by Eric Seidel.

Spec: http://www.w3.org/TR/DOM-Level-3-Events/#events-FocusEvent

This patch creates a new FocusEvent class with a relatedTarget attribute.
Now when focusin or focusout events are dispatched, a FocusEvent is created with
the relatedTarget attribute set accordingly.

Source/WebCore:

Test: fast/events/related-target-focusevent.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/Event.cpp:

(WebCore::Event::isFocusEvent):
(WebCore):

  • dom/Event.h:

(Event):

  • dom/EventContext.cpp:

(WebCore::EventContext::handleLocalEvents):

  • dom/EventNames.in:
  • dom/FocusEvent.h: Added.

(WebCore):
(FocusEvent):
(WebCore::FocusEvent::create):
(WebCore::FocusEvent::relatedTarget):
(WebCore::FocusEvent::setRelatedTarget):
(WebCore::toFocusEvent):

  • dom/FocusEvent.idl: Added.
  • dom/Node.cpp:

(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):

LayoutTests:

  • fast/dom/shadow/shadow-boundary-events-expected.txt:
  • fast/dom/shadow/shadow-boundary-events.html:
  • fast/events/related-target-focusevent-expected.txt: Added.
  • fast/events/related-target-focusevent.html: Added.
12:25 AM Changeset in webkit [142071] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix style of RenderTheme.cpp and RenderThemeChromiumWin.h
https://bugs.webkit.org/show_bug.cgi?id=109137

Reviewed by Kentaro Hara.

No new tests. Just style fix.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore::RenderTheme::isControlStyled):
(WebCore::RenderTheme::adjustButtonStyle):
(WebCore::RenderTheme::systemColor):

  • rendering/RenderThemeChromiumWin.h:

(WebCore::ThemeData::ThemeData):
(ThemeData):
(RenderThemeChromiumWin):
(WebCore::RenderThemeChromiumWin::RenderThemeChromiumWin):
(WebCore::RenderThemeChromiumWin::~RenderThemeChromiumWin):

12:25 AM Changeset in webkit [142070] by Simon Hausmann
  • 6 edits
    8 adds in trunk

[Qt] Compile WTF tests of TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=108935

Reviewed by Kenneth Rohde Christiansen.

.:

Build gtest on Linux.

  • WebKit.pro:

Source/ThirdParty:

Add qmake build system .pro file for building gtest as static library.

  • gtest/gtest.pro: Added.

Tools:

Add initial stubs and files for building at least the WTF tests.
The WK2 tests need more platform code, in particular PlatformWebView
and injected bundle support.

  • TestWebKitAPI/TestWebKitAPI.pri: Added.
  • TestWebKitAPI/TestWebKitAPI.pro: Added.
  • TestWebKitAPI/Tests/WTF/WTF.pro: Added.
  • TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::InjectedBundleController::platformInitialize):

  • TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Added.

(Util):
(TestWebKitAPI::Util::run):
(TestWebKitAPI::Util::sleep):
(TestWebKitAPI::Util::createInjectedBundlePath):
(TestWebKitAPI::Util::createURLForResource):
(TestWebKitAPI::Util::URLForNonExistentResource):

  • TestWebKitAPI/qt/main.cpp: Added.

(main):

  • Tools.pro:
  • qmake/mkspecs/features/default_post.prf:
12:23 AM Changeset in webkit [142069] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix style of Chrome.h and Page.h
https://bugs.webkit.org/show_bug.cgi?id=109138

Reviewed by Ryosuke Niwa.

No new tests. Just style fixes.

  • page/Chrome.h:

(WebCore):
(Chrome):
(WebCore::Chrome::client):

  • page/Page.h:

(JSC):
(WebCore):
(WebCore::ArenaSize::ArenaSize):
(ArenaSize):
(Page):
(PageClients):
(WebCore::Page::theme):
(WebCore::Page::canStartMedia):
(WebCore::Page::editorClient):
(WebCore::Page::plugInClient):
(WebCore::Page::mainFrame):
(WebCore::Page::groupPtr):
(WebCore::Page::incrementSubframeCount):
(WebCore::Page::decrementSubframeCount):
(WebCore::Page::subframeCount):
(WebCore::Page::chrome):
(WebCore::Page::dragCaretController):
(WebCore::Page::dragController):
(WebCore::Page::focusController):
(WebCore::Page::contextMenuController):
(WebCore::Page::inspectorController):
(WebCore::Page::pointerLockController):
(WebCore::Page::validationMessageClient):
(WebCore::Page::settings):
(WebCore::Page::progress):
(WebCore::Page::backForward):
(WebCore::Page::featureObserver):
(WebCore::Page::viewMode):
(WebCore::Page::setTabKeyCyclesThroughElements):
(WebCore::Page::tabKeyCyclesThroughElements):
(WebCore::Page::scheduledRunLoopPairs):
(WebCore::Page::defersLoading):
(WebCore::Page::mediaVolume):
(WebCore::Page::pageScaleFactor):
(WebCore::Page::deviceScaleFactor):
(WebCore::Page::shouldSuppressScrollbarAnimations):
(WebCore::Page::pagination):
(WebCore::Page::isOnscreen):
(WebCore::Page::scriptedAnimationsSuspended):
(WebCore::Page::debugger):
(WebCore::Page::hasCustomHTMLTokenizerTimeDelay):
(WebCore::Page::customHTMLTokenizerTimeDelay):
(WebCore::Page::hasCustomHTMLTokenizerChunkSize):
(WebCore::Page::customHTMLTokenizerChunkSize):
(WebCore::Page::areMemoryCacheClientCallsEnabled):
(WebCore::Page::setEditable):
(WebCore::Page::isEditable):
(WebCore::Page::displayID):
(WebCore::Page::layoutMilestones):
(WebCore::Page::setIsPainting):
(WebCore::Page::isPainting):
(WebCore::Page::alternativeTextClient):
(WebCore::Page::checkSubframeCountConsistency):
(WebCore::Page::group):

Feb 6, 2013:

11:41 PM Changeset in webkit [142068] by mkwst@chromium.org
  • 3 edits
    9 adds in trunk

Entity-header extension headers honored on 304 responses.
https://bugs.webkit.org/show_bug.cgi?id=72414

Reviewed by Alexey Proskuryakov.

Source/WebCore:

This patch ports Chromium's network stack logic governing header
updates after resource revalidation. Generally, headers sent with 304
responses ought to update the original cached resource's headers.
Certain headers should never be sent with 304 responses, and we should
ignore them if a misconfigured server sends them anyway.

Currently, WebCore ignores all headers prefixed with 'content-'. This
patch adds 'x-content-' and 'x-webkit-' to the list, as well as specific
headers like 'upgrade', 'trailer', and others that the Chromium network
stack currently ignores.

The tests verify that those headers with visible effect are correctly
handled: 'x-frame-options', 'content-security-policy', and
'x-xss-protection'.

Tests: http/tests/security/XFrameOptions/x-frame-options-cached.html

http/tests/security/contentSecurityPolicy/cached-frame-csp.html
http/tests/security/xssAuditor/cached-frame.html

  • loader/cache/CachedResource.cpp:

(WebCore):
(WebCore::CachedResource::updateResponseAfterRevalidation):

This patch adds two arrays containing the specific headers to
ignore and the prefixes to ignore. These lists are processed in
shouldUpdateHeaderAfterRevalidation.
CachedResource::updateResponseAfterRevalidation relies on this new
method when processing revalidated resources.

  • loader/cache/CachedResource.cpp:

(WebCore):
(WebCore::shouldUpdateHeaderAfterRevalidation):
(WebCore::CachedResource::updateResponseAfterRevalidation):

LayoutTests:

  • http/tests/security/XFrameOptions/resources/nph-cached-xfo.pl: Added.
  • http/tests/security/XFrameOptions/x-frame-options-cached-expected.txt: Added.
  • http/tests/security/XFrameOptions/x-frame-options-cached.html: Added.
  • http/tests/security/contentSecurityPolicy/cached-frame-csp-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/cached-frame-csp.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/nph-cached-csp.pl: Added.
  • http/tests/security/xssAuditor/cached-frame-expected.txt: Added.
  • http/tests/security/xssAuditor/cached-frame.html: Added.
  • http/tests/security/xssAuditor/resources/nph-cached.pl: Added.
9:20 PM Changeset in webkit [142067] by falken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking all webgl/conformance tests as slow.

  • platform/chromium/TestExpectations:
9:19 PM Changeset in webkit [142066] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

9:16 PM Changeset in webkit [142065] by Lucas Forschler
  • 1 copy in tags/Safari-537.30

New Tag.

8:40 PM Changeset in webkit [142064] by weinig@apple.com
  • 11 edits in trunk/Source/WebKit2

Make CustomProtocolManagerProxy a MessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=108787

Reviewed by Anders Carlsson.

  • Shared/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::addMessageReceiver):
(WebKit::ChildProcessProxy::removeMessageReceiver):
(WebKit::ChildProcessProxy::dispatchMessage):
(WebKit::ChildProcessProxy::dispatchSyncMessage):

  • Shared/ChildProcessProxy.h:

Sink the MessageReceiverMap down into the ChildProcessProxy.

  • UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::DownloadProxyMap):
(WebKit::DownloadProxyMap::createDownloadProxy):
(WebKit::DownloadProxyMap::downloadFinished):
(WebKit::DownloadProxyMap::processDidClose):

  • UIProcess/Downloads/DownloadProxyMap.h:

Pass the ChildProcessProxy rather than the MessageReceiverMap to the constructor.

  • UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
  • UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.messages.in:
  • UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:

(WebKit::CustomProtocolManagerProxy::CustomProtocolManagerProxy):
Convert to a MessageReceiver.

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::createDownloadProxy):
(WebKit::NetworkProcessProxy::didReceiveMessage):
(WebKit::NetworkProcessProxy::didReceiveSyncMessage):

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
(WebKit::WebProcessProxy::createDownloadProxy):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):
Remove direct chaining to CustomProtocolManagerProxy.

7:14 PM Changeset in webkit [142063] by tsepez@chromium.org
  • 5 edits in trunk

document.referrer leakage with XSS Auditor page block
https://bugs.webkit.org/show_bug.cgi?id=109089

Reviewed by Adam Barth.

Source/WebCore:

Pass "about:blank" as referrer instead of "" so that the actual page
is not leaked when empty referrers are replaced later on in the
request.

  • html/parser/XSSAuditorDelegate.cpp:

(WebCore::XSSAuditorDelegate::didBlockScript):

LayoutTests:

Test prints the referrer to show it isn't leaked.

  • http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
  • http/tests/security/xssAuditor/full-block-script-tag.html:
6:50 PM Changeset in webkit [142062] by falken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking gl-vertexattribpointer.html as slow.

  • platform/chromium/TestExpectations:
6:43 PM Changeset in webkit [142061] by haraken@chromium.org
  • 31 edits in trunk/Source/WebCore

[V8] Make an Isolate parameter mandatory in GetTemplate() and GetRawTemplate()
https://bugs.webkit.org/show_bug.cgi?id=109026

Reviewed by Adam Barth.

Now it's time to kill an optional Isolate parameter.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNamedConstructorCallback):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::GetRawTemplate):
(WebCore::V8Float64Array::GetTemplate):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):
(WebCore::V8Float64Array::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::GetRawTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetRawTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetRawTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::GetRawTemplate):
(WebCore::V8TestEventTarget::GetTemplate):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):
(WebCore::V8TestEventTarget::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetRawTemplate):
(WebCore::V8TestException::GetTemplate):

  • bindings/scripts/test/V8/V8TestException.h:

(V8TestException):
(WebCore::V8TestException::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::GetRawTemplate):
(WebCore::V8TestInterface::GetTemplate):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):
(WebCore::V8TestInterface::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetRawTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::GetRawTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetRawTemplate):
(WebCore::V8TestNode::GetTemplate):

  • bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):
(WebCore::V8TestNode::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::GetRawTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::GetRawTemplate):
(WebCore::V8TestOverloadedConstructors::GetTemplate):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):
(WebCore::V8TestOverloadedConstructors::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::installPerContextPrototypeProperties):

  • bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::constructorForTypeSlowCase):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WebCore::WrapperTypeInfo::installPerContextPrototypeProperties):

6:00 PM Changeset in webkit [142060] by roger_fong@apple.com
  • 6 edits
    1 add in trunk/Source

Unreviewed. Touchups to VS2010 WebKit solution.
Fix an export generator script, modify some property sheets, add resouce file.
Add WinLauncher projects to solution.

  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorDebug.props:
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPostBuild.cmd:
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorRelease.props:
  • JavaScriptCore.vcxproj/resource.h: Added.
  • WebKit.vcxproj/WebKit.sln:
5:52 PM Changeset in webkit [142059] by roger_fong@apple.com
  • 1 edit
    8 copies
    15 adds in trunk/Tools

VS2010 WinLauncher project, property sheets and resources.
https://bugs.webkit.org/show_bug.cgi?id=107037.

Reviewed by Brent Fulgham.

  • WinLauncher/WinLauncher.vcxproj: Added.
  • WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Copied from WinLauncher/WinLauncher.ico.
  • WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Copied from WinLauncher/WinLauncherLauncher.rc.
  • WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Added.
  • WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Added.
  • WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.user: Added.
  • WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props: Added.
  • WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props: Added.
  • WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Copied from WinLauncher/WinLauncher.rc.
  • WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Added.
  • WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Added.
  • WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.user: Added.
  • WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Added.
  • WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props: Added.
  • WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Copied from WinLauncher/WinLauncherPostBuild.cmd.
  • WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Copied from WinLauncher/WinLauncherPreBuild.cmd.
  • WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props: Added.
  • WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Copied from WinLauncher/resource.h.
  • WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Added.
  • WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Added.
  • WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props: Added.
  • WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h: Copied from WinLauncher/WinLauncherLauncherResource.h.
  • WinLauncher/WinLauncher.vcxproj/small.ico: Copied from WinLauncher/small.ico.
5:35 PM Changeset in webkit [142058] by Gregg Tavares
  • 4 edits
    292 adds in trunk/LayoutTests

Adds failing WebGL Conformance Tests.
https://bugs.webkit.org/show_bug.cgi?id=109075

Reviewed by Kenneth Russell.

  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
  • webgl/conformance/canvas/buffer-offscreen-test-expected.txt: Added.
  • webgl/conformance/canvas/buffer-offscreen-test.html: Added.
  • webgl/conformance/canvas/buffer-preserve-test-expected.txt: Added.
  • webgl/conformance/canvas/buffer-preserve-test.html: Added.
  • webgl/conformance/canvas/drawingbuffer-test-expected.txt: Added.
  • webgl/conformance/canvas/drawingbuffer-test.html: Added.
  • webgl/conformance/canvas/to-data-url-test-expected.txt: Added.
  • webgl/conformance/canvas/to-data-url-test.html: Added.
  • webgl/conformance/context/context-attribute-preserve-drawing-buffer-expected.txt: Added.
  • webgl/conformance/context/context-attribute-preserve-drawing-buffer.html: Added.
  • webgl/conformance/context/context-creation-and-destruction-expected.txt: Added.
  • webgl/conformance/context/context-creation-and-destruction.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-smoothstep-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-smoothstep-gentype.html: Added.
  • webgl/conformance/glsl/literals/float_literal.vert-expected.txt: Added.
  • webgl/conformance/glsl/literals/float_literal.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-uniform-packing-restrictions-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html: Added.
  • webgl/conformance/glsl/misc/shader-varying-packing-restrictions-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-varying-packing-restrictions.html: Added.
  • webgl/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Added.
  • webgl/conformance/glsl/misc/shader-with-global-variable-precision-mismatch-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html: Added.
  • webgl/conformance/glsl/misc/shader-with-non-reserved-words-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-non-reserved-words.html: Added.
  • webgl/conformance/glsl/misc/shader-with-short-circuiting-operators-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-short-circuiting-operators.html: Added.
  • webgl/conformance/glsl/misc/shader-with-similar-uniform-array-names-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-similar-uniform-array-names.html: Added.
  • webgl/conformance/glsl/misc/shaders-with-varyings-expected.txt: Added.
  • webgl/conformance/glsl/misc/shaders-with-varyings.html: Added.
  • webgl/conformance/glsl/variables/gl-pointcoord-expected.txt: Added.
  • webgl/conformance/glsl/variables/gl-pointcoord.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-A-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-A.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B1-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B1.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B2-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B2.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B3-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B3.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B4-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B4.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-C-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-C.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-D_G-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-D_G.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-G_I-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-G_I.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-L_S-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-L_S.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-S_V-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-S_V.html: Added.
  • webgl/conformance/more/functions/bufferDataBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/bufferDataBadArgs.html: Added.
  • webgl/conformance/more/functions/copyTexImage2D-expected.txt: Added.
  • webgl/conformance/more/functions/copyTexImage2D.html: Added.
  • webgl/conformance/more/functions/copyTexImage2DBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/copyTexImage2DBadArgs.html: Added.
  • webgl/conformance/more/functions/copyTexSubImage2D-expected.txt: Added.
  • webgl/conformance/more/functions/copyTexSubImage2D.html: Added.
  • webgl/conformance/more/functions/copyTexSubImage2DBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/copyTexSubImage2DBadArgs.html: Added.
  • webgl/conformance/more/functions/deleteBufferBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/deleteBufferBadArgs.html: Added.
  • webgl/conformance/more/functions/drawArrays-expected.txt: Added.
  • webgl/conformance/more/functions/drawArrays.html: Added.
  • webgl/conformance/more/functions/drawArraysOutOfBounds-expected.txt: Added.
  • webgl/conformance/more/functions/drawArraysOutOfBounds.html: Added.
  • webgl/conformance/more/functions/drawElements-expected.txt: Added.
  • webgl/conformance/more/functions/drawElements.html: Added.
  • webgl/conformance/more/functions/drawElementsBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/drawElementsBadArgs.html: Added.
  • webgl/conformance/more/functions/readPixelsBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/readPixelsBadArgs.html: Added.
  • webgl/conformance/more/functions/texImage2DBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/texImage2DBadArgs.html: Added.
  • webgl/conformance/more/functions/texImage2DHTML-expected.txt: Added.
  • webgl/conformance/more/functions/texImage2DHTML.html: Added.
  • webgl/conformance/more/functions/texSubImage2DBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/texSubImage2DBadArgs.html: Added.
  • webgl/conformance/more/functions/texSubImage2DHTML-expected.txt: Added.
  • webgl/conformance/more/functions/texSubImage2DHTML.html: Added.
  • webgl/conformance/ogles/GL/acos/acos_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/acos/acos_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/asin/asin_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/asin/asin_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/atan/atan_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/atan/atan_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/control_flow/control_flow_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/control_flow/control_flow_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/log/log_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/log/log_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/log2/log2_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/log2/log2_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/smoothstep/smoothstep_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/smoothstep/smoothstep_001_to_006.html: Added.
  • webgl/conformance/programs/gl-bind-attrib-location-long-names-test-expected.txt: Added.
  • webgl/conformance/programs/gl-bind-attrib-location-long-names-test.html: Added.
  • webgl/conformance/programs/program-test-expected.txt: Added.
  • webgl/conformance/programs/program-test.html: Added.
  • webgl/conformance/reading/read-pixels-test-expected.txt: Added.
  • webgl/conformance/reading/read-pixels-test.html: Added.
  • webgl/conformance/renderbuffers/framebuffer-object-attachment-expected.txt: Added.
  • webgl/conformance/renderbuffers/framebuffer-object-attachment.html: Added.
  • webgl/conformance/rendering/gl-scissor-test-expected.txt: Added.
  • webgl/conformance/rendering/gl-scissor-test.html: Added.
  • webgl/conformance/rendering/more-than-65536-indices-expected.txt: Added.
  • webgl/conformance/rendering/more-than-65536-indices.html: Added.
  • webgl/conformance/rendering/multisample-corruption-expected.txt: Added.
  • webgl/conformance/rendering/multisample-corruption.html: Added.
  • webgl/conformance/rendering/point-size-expected.txt: Added.
  • webgl/conformance/rendering/point-size.html: Added.
  • webgl/conformance/state/gl-object-get-calls-expected.txt: Added.
  • webgl/conformance/state/gl-object-get-calls.html: Added.
  • webgl/conformance/textures/copy-tex-image-2d-formats-expected.txt: Added.
  • webgl/conformance/textures/copy-tex-image-2d-formats.html: Added.
  • webgl/conformance/textures/gl-pixelstorei-expected.txt: Added.
  • webgl/conformance/textures/gl-pixelstorei.html: Added.
  • webgl/conformance/textures/origin-clean-conformance-expected.txt: Added.
  • webgl/conformance/textures/origin-clean-conformance.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video.html: Added.
  • webgl/conformance/textures/texture-active-bind-2-expected.txt: Added.
  • webgl/conformance/textures/texture-active-bind-2.html: Added.
  • webgl/conformance/textures/texture-active-bind-expected.txt: Added.
  • webgl/conformance/textures/texture-active-bind.html: Added.
  • webgl/conformance/textures/texture-mips-expected.txt: Added.
  • webgl/conformance/textures/texture-mips.html: Added.
  • webgl/conformance/textures/texture-npot-video-expected.txt: Added.
  • webgl/conformance/textures/texture-npot-video.html: Added.
  • webgl/conformance/textures/texture-size-expected.txt: Added.
  • webgl/conformance/textures/texture-size-limit-expected.txt: Added.
  • webgl/conformance/textures/texture-size-limit.html: Added.
  • webgl/conformance/textures/texture-size.html: Added.
  • webgl/conformance/uniforms/gl-uniform-arrays-expected.txt: Added.
  • webgl/conformance/uniforms/gl-uniform-arrays.html: Added.
  • webgl/conformance/uniforms/uniform-default-values-expected.txt: Added.
  • webgl/conformance/uniforms/uniform-default-values.html: Added.
  • webgl/conformance/uniforms/uniform-location-expected.txt: Added.
  • webgl/conformance/uniforms/uniform-location.html: Added.
  • webgl/conformance/uniforms/uniform-samplers-test-expected.txt: Added.
  • webgl/conformance/uniforms/uniform-samplers-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/buffer-offscreen-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/buffer-preserve-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/drawingbuffer-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/to-data-url-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/context-attribute-preserve-drawing-buffer.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/context-creation-and-destruction.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-smoothstep-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/literals/float_literal.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-uniform-packing-restrictions.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-varying-packing-restrictions.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-non-reserved-words.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-short-circuiting-operators.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-similar-uniform-array-names.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shaders-with-varyings.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/variables/gl-pointcoord.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-A.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B1.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B2.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B3.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B4.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-C.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-D_G.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-G_I.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-L_S.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-S_V.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bufferDataBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/copyTexImage2D.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/copyTexImage2DBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/copyTexSubImage2D.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/copyTexSubImage2DBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/deleteBufferBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/drawArrays.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/drawArraysOutOfBounds.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/drawElements.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/drawElementsBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/readPixelsBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texImage2DBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texImage2DHTML.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DHTML.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/control_flow_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/programs/gl-bind-attrib-location-long-names-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/programs/program-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/reading/read-pixels-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/renderbuffers/framebuffer-object-attachment.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/gl-scissor-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/more-than-65536-indices.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/multisample-corruption.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/point-size.html: Added.
  • webgl/resources/webgl_test_files/conformance/state/gl-object-get-calls.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/copy-tex-image-2d-formats.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/gl-pixelstorei.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/origin-clean-conformance.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-active-bind-2.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-active-bind.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-mips.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-npot-video.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-size-limit.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-size.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/gl-uniform-arrays.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/uniform-default-values.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/uniform-location.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/uniform-samplers-test.html: Added.
5:01 PM Changeset in webkit [142057] by tdanderson@chromium.org
  • 24 edits
    9 adds in trunk

Add support for gesture scroll events that do not propagate to enclosing scrollables
https://bugs.webkit.org/show_bug.cgi?id=108849

Reviewed by Antonio Gomes.

Source/WebCore:

Tests: fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated.html

fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated.html
fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated.html

Rename RenderLayer::scrollByRecursively() to RenderLayer::scrollBy() and add a parameter
of type RenderLayer::ScrollPropagation to specify whether or not the scroll should
propagate to its parent by recursing. Implement RenderLayer::scrollByRecursively() as a
call to RenderLayer::scrollBy() with argument RenderLayer::ShouldPropagateScroll so
that all existing calls to the function still produce the correct behavior.

In EventHandler::handleGestureScrollUpdate(), call RenderLayer::scrollBy() with
argument RenderLayer::ShouldPropagateScroll if |gestureEvent| is a GestureScrollUpdate
or instead with argument RenderLayer::DontPropagateScroll if |gestureEvent| is a
GestureScrollUpdateWithoutPropagation.

  • dom/GestureEvent.cpp:

(WebCore::GestureEvent::create):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureScrollUpdate):

  • platform/PlatformEvent.h:
  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::gestureEvent):

  • platform/chromium/PopupContainer.cpp:

(WebCore::PopupContainer::handleGestureEvent):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollByRecursively):
(WebCore):
(WebCore::RenderLayer::scrollBy):

  • rendering/RenderLayer.h:

Source/WebKit/chromium:

Define the new event type GestureScrollUpdateWithoutPropagation.

  • public/WebInputEvent.h:

(WebKit::WebInputEvent::isGestureEventType):

  • src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::handleInputEvent):

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPluginContainerImpl.cpp:
  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

Tools:

Modify chromium's DRT EventSender to support the new event type
GestureScrollUpdateWithoutPropagation.

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::gestureScrollUpdateWithoutPropagation):
(WebTestRunner::EventSender::gestureEvent):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.h:

(EventSender):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:

(WebTestRunner::TestPlugin::handleInputEvent):

LayoutTests:

New tests added to ensure that GestureScrollUpdateWithoutPropagation events will not
propagate to the scrollable parent of their target when the target has no area
left to be scrolled.

Modified two chromium-specific plugin tests to ensure that the plugins receive
GestureScrollUpdate events when GestureScrollUpdateWithoutPropagation events are
dispatched to them.

  • fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated.html: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated.html: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated.html: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated-expected.txt: Added.
  • platform/chromium/plugins/gesture-events-expected.txt:
  • platform/chromium/plugins/gesture-events-scrolled-expected.txt:
  • platform/chromium/plugins/gesture-events-scrolled.html:
  • platform/chromium/plugins/gesture-events.html:
4:55 PM Changeset in webkit [142056] by ojan@chromium.org
  • 11 edits in trunk

[Chromium] table-section-overflow-clip-crash.html hits an assert
https://bugs.webkit.org/show_bug.cgi?id=108594

Reviewed by Levi Weintraub.

Source/WebCore:

When a counter calls setNeedsLayout, it also marks it's containing blocks
as needing layout, so we need to clear the setNeedsLayoutIsForbidden bit on the
containing blocks as well as the counter itself.

Also, use RAII objects for all the places where we clear this bit and make
the setter/getter for it private to RenderObject.

  • rendering/RenderCounter.cpp:

(WebCore::RenderCounter::computePreferredLogicalWidths):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::SetLayoutNeededForbiddenScope::SetLayoutNeededForbiddenScope):
(WebCore::RenderObject::markContainingBlocksForLayout):

  • rendering/RenderObject.h:

(SetLayoutNeededForbiddenScope):
(RenderObject):
(WebCore::RenderObject::isSetNeedsLayoutForbidden):
(WebCore::RenderObject::setNeedsLayoutIsForbidden):

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::computePreferredLogicalWidths):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::computePreferredLogicalWidths):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::computePreferredLogicalWidths):

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::computePreferredLogicalWidths):

LayoutTests:

  • platform/chromium/TestExpectations:
4:47 PM Changeset in webkit [142055] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

ASSERT(!m_findPageOverlay) in FindController.cpp after r140769.
https://bugs.webkit.org/show_bug.cgi?id=109105.

Reviewed by Tim Horton.

In r140769 we changed the way the overlay is destroyed,
therefore the assert is no longer valid and should be removed.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindUIAfterPageScroll):

4:41 PM Changeset in webkit [142054] by ojan@chromium.org
  • 3 edits
    2 adds in trunk

display:none file upload button crashes
https://bugs.webkit.org/show_bug.cgi?id=109102

Reviewed by Levi Weintraub.

Source/WebCore:

Test: fast/forms/file/display-none-upload-button.html

  • rendering/RenderFileUploadControl.cpp:

(WebCore::nodeWidth):
(WebCore::RenderFileUploadControl::paintObject):
Having an upload button doesn't mean we have a rendered upload button.
Null check the renderer before trying to access it.

LayoutTests:

  • fast/forms/file/display-none-upload-button-expected.txt: Added.
  • fast/forms/file/display-none-upload-button.html: Added.

Tests that we don't crash. Also exposes a bug that the baseline and height of
the input don't include the height of the filename text.

4:32 PM Changeset in webkit [142053] by schenney@chromium.org
  • 10 edits
    1 add
    1 delete in trunk/LayoutTests

[Chromium] Test expectations update for Skia change.

Unreviewed expectations update

Files that we were expecting to fail. Now being rebaselined.

  • platform/chromium-linux-x86/svg/text/text-viewbox-rescale-expected.png: Added.
  • platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
  • platform/chromium-linux/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-linux/svg/text/selection-styles-expected.png:
  • platform/chromium-linux/svg/text/text-viewbox-rescale-expected.png:
  • platform/chromium-mac-lion/svg/text/text-viewbox-rescale-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
  • platform/chromium-mac/svg/text/text-viewbox-rescale-expected.png:
  • platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
  • platform/efl/svg/batik/text/smallFonts-expected.png: Removed.
4:31 PM Changeset in webkit [142052] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Reset the border property for -webkit-slider-thumb in unknown-pseudo-element-matching test
https://bugs.webkit.org/show_bug.cgi?id=109101

We check that the style matches a pseudo element by setting its height to 1px.
Some user agents, like iOS, have default border styles that affect the minimum height,
so we need to reset those.

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-06
Reviewed by Joseph Pecoraro.

  • fast/css/unknown-pseudo-element-matching.html:
4:28 PM Changeset in webkit [142051] by commit-queue@webkit.org
  • 8 edits
    3 adds in trunk

Context's currentPath should check for passed type
https://bugs.webkit.org/show_bug.cgi?id=109097

Patch by Dirk Schulze <dschulze@adobe.com> on 2013-02-06
Reviewed by Dean Jackson.

Source/WebCore:

Add check for passed pointer and return earlier.

Test: fast/canvas/canvas-currentPath-crash.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setCurrentPath):

LayoutTests:

Add checks with different data types as value for canvas.currentPath.

  • fast/canvas/canvas-currentPath-crash-expected.txt: Added.
  • fast/canvas/canvas-currentPath-crash.html: Added.
  • fast/canvas/script-tests/canvas-currentPath-crash.js: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
4:18 PM Changeset in webkit [142050] by schenney@chromium.org
  • 11 edits
    2 adds
    2 deletes in trunk/LayoutTests

[Chromium] Test expectations update for Skia change.

Unreviewed expectations update

Files that we were expecting to fail. Now being rebaselined.

  • platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.png:
  • platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/chromium-linux/fast/text/justify-ideograph-vertical-expected.png:
  • platform/chromium-linux/svg/custom/shapes-supporting-markers-expected.png:
  • platform/chromium-linux/svg/custom/text-ctm-expected.png:
  • platform/chromium-mac-lion/svg/custom/shapes-supporting-markers-expected.png:
  • platform/chromium-mac/svg/custom/shapes-supporting-markers-expected.png:
  • platform/chromium-mac/svg/custom/text-ctm-expected.txt:
  • platform/chromium-win/svg/custom/shapes-supporting-markers-expected.png:
  • platform/chromium-win/svg/custom/text-ctm-expected.png:
  • platform/chromium-win/svg/custom/text-ctm-expected.txt: Removed.
  • platform/gtk/svg/custom/text-ctm-expected.txt: Removed.
  • svg/custom/text-ctm-expected.txt: Added.
4:15 PM Changeset in webkit [142049] by rafaelw@chromium.org
  • 4 edits in trunk

[HTMLTemplateElement] Non </template> end tags should be ignored in "template contents" insertion mode.
https://bugs.webkit.org/show_bug.cgi?id=109090

Reviewed by Adam Barth.

Source/WebCore:

https://dvcs.w3.org/hg/webcomponents/raw-file/38536d37fb82/spec/templates/index.html#template-contents-insertion-mode.

Test added to html5lib suite.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processEndTag):

LayoutTests:

  • html5lib/resources/template.dat:
3:59 PM Changeset in webkit [142048] by schenney@chromium.org
  • 15 edits
    1 add
    2 deletes in trunk/LayoutTests

[Chromium] Test expectations update for Skia change.

Unreviewed expectations update

Files that we were expecting to fail. Now being rebaslined.

  • platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-lr-expected.png: Removed.
  • platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
  • platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-rl-expected.png: Removed.
  • platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
  • platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.png:
  • platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.png:
  • platform/chromium-linux/fast/writing-mode/japanese-lr-text-expected.png:
  • platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.png:
  • platform/chromium-linux/fast/writing-mode/japanese-rl-text-expected.png:
  • platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
  • platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
  • platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
  • platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt: Added.
  • platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
  • platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
  • platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
3:51 PM Changeset in webkit [142047] by schenney@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

[Chromium] Test expectations update for Skia change.

Unreviewed expectations update

And these too. See change below.

  • platform/chromium-mac-lion/fast/writing-mode/japanese-rl-selection-expected.txt: Added.
  • platform/chromium-mac-lion/fast/writing-mode/japanese-rl-text-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/writing-mode/japanese-rl-selection-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/writing-mode/japanese-rl-text-expected.txt: Added.
3:50 PM Changeset in webkit [142046] by schenney@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Test expectations update for Skia change.

Unreviewed expectations update

Apparently there are width differences on the mac platforms. These were
clobbered qwhen I updated the 10.8 expectations.

  • platform/chromium-mac-lion/fast/writing-mode/japanese-lr-text-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/writing-mode/japanese-lr-text-expected.txt: Added.
3:47 PM Changeset in webkit [142045] by aelias@chromium.org
  • 4 edits in trunk/Source

Make ScrollView::paint() clip by visibleContentRect
https://bugs.webkit.org/show_bug.cgi?id=108888

Reviewed by Levi Weintraub.

When applyPageScaleFactorInCompositor or fixedVisibleContentRect
are used, frameRect() and visibleContentRect(true).size() are
no longer synonyms, and the latter is the one that should be
used for clipping paints.

New WebFrameTest: pageScaleFactorScalesPaintClip.

Source/WebCore:

  • platform/ScrollView.cpp:

(WebCore::ScrollView::paint):

Source/WebKit/chromium:

  • tests/WebFrameTest.cpp:
3:44 PM Changeset in webkit [142044] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Dispatch storage manager messages to the storage work queue
https://bugs.webkit.org/show_bug.cgi?id=109099

Reviewed by Andreas Kling.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::didReceiveMessageOnConnectionWorkQueue):
(WebKit::StorageManager::dispatchMessageOnStorageManagerQueue):
(WebKit):

  • UIProcess/Storage/StorageManager.h:

(StorageManager):

3:33 PM Changeset in webkit [142043] by commit-queue@webkit.org
  • 9 edits in trunk

Store the language internally instead of using lang attribute for WebVTT nodes
https://bugs.webkit.org/show_bug.cgi?id=108858

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-06
Reviewed by Eric Carlson.

Source/WebCore:

Only language webvtt elements should have a lang attribute so we have to store
the language internally in the element. Refactored the code to make
computeInheritedLanguage virtual.

Existing tests were modified to cover this case.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • html/track/WebVTTElement.cpp:

(WebCore::WebVTTElement::WebVTTElement):
(WebCore::WebVTTElement::cloneElementWithoutAttributesAndChildren):
(WebCore::WebVTTElement::createEquivalentHTMLElement): clone the internal language property.

  • html/track/WebVTTElement.h:

(WebCore::WebVTTElement::language):
(WebCore::WebVTTElement::setLanguage):

  • html/track/WebVTTParser.cpp: only set the lang attribute for language objects.

(WebCore::WebVTTParser::constructTreeFromToken):

LayoutTests:

  • media/track/captions-webvtt/styling-lang.vtt:
  • media/track/track-css-matching-lang-expected.txt:
  • media/track/track-css-matching-lang.html:
3:08 PM Changeset in webkit [142042] by leviw@chromium.org
  • 3 edits
    2 adds in trunk

Negative text indents can break RenderBlock's inline maximum preferred width calculation
https://bugs.webkit.org/show_bug.cgi?id=108973

Reviewed by Emil A Eklund.

Source/WebCore:

Change two quirks about to how we calculate a block's inline preferred width with
text-indent.

First, re-use text-indent that's first applied to floats on text that follows it.
This matches Layout, as otherwise we can prematurely wrap text when there's a negative
margin on a block starting with a float. This also matches FireFox.

Second, correct how the max preferred width is calculated in the presence of a negative
text-indent. If the text-indent is more negative than the first text line break, we
update the value to be the remainder. Previously, we added this remaining negative value
to subsequent minimum and maximum preferred width calculations (until the remainder was
gone). This is wrong for the max preferred width, as we're adding the negative value more
than once, and leads to a max preferred width that's smaller than our line.

Test: fast/css/negative-text-indent-in-inline-block.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

LayoutTests:

  • fast/css/negative-text-indent-in-inline-block-expected.html: Added.
  • fast/css/negative-text-indent-in-inline-block.html: Added.
3:06 PM Changeset in webkit [142041] by kerz@chromium.org
  • 2 edits in branches/chromium/1364

Revert 141898

Disable Fullscreen API on Android.

Disable the fullscreen API, as it is not working correctly on Android.

BUG=173664
Review URL: https://codereview.chromium.org/12208016

TBR=jknotten@chromium.org
Review URL: https://codereview.chromium.org/12225065

2:59 PM Changeset in webkit [142040] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/LayoutTests

We don't have the text-based repaint test harness on the branch.
<rdar://problem/12968804>

Reviewed by Tim Horton.

  • platform/mac/Skipped:
2:56 PM Changeset in webkit [142039] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/LayoutTests

<rdar://problem/12968605>

Reviewed by Enrica Casucci.

  • platform/mac-wk2/Skipped:
2:47 PM Changeset in webkit [142038] by Lucas Forschler
  • 1 edit
    1 add in branches/safari-536.28-branch/LayoutTests

Update WK2 test results.
<rdar://problem/12968040> Chopin test failure: http/tests/loading/remove-child-triggers-parser.html

Reviewed by Jeffrey Pfau.

  • platform/mac-wk2/http/tests/loading/remove-child-triggers-parser-expected.txt: Added.
2:46 PM Changeset in webkit [142037] by jpetsovits@rim.com
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Refactor renderContents() for cleaner code.
https://bugs.webkit.org/show_bug.cgi?id=109059
RIM PR 280374

Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.

The fact that we've got two renderContents() implementations
in BackingStore.cpp, one of which was tailored to just
being called from drawContents(), is a major annoyance.

With this patch, the regular renderContents() is modified
in a way so that drawContents() can make use of it as well.
This includes an API change for both functions which makes
it more flexible and enables further cleanups and improvements
to accuracy. The second, unloved renderContents() is removed.

The user-visible changes are improved (float) accuracy for
render offsets, clipping to exactly the dstRect that has
been specified, and the changed public drawContents() API.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::renderDirectToWindow):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(BlackBerry::WebKit::BackingStore::drawContents):

  • Api/BackingStore.h:

(Platform):
(Graphics):

  • Api/BackingStore_p.h:

(WebCore):
(BackingStorePrivate):

  • WebKitSupport/SurfacePool.cpp:

(BlackBerry::WebKit::SurfacePool::SurfacePool):
(BlackBerry::WebKit::SurfacePool::initialize):
(BlackBerry::WebKit::SurfacePool::destroyPlatformGraphicsContext):

  • WebKitSupport/SurfacePool.h:

(SurfacePool):

2:45 PM Changeset in webkit [142036] by Lucas Forschler
  • 2 edits in branches/safari-536.28-branch/LayoutTests

<rdar://problem/12967921>
Update test results.


Reviewed by Enrica Casucci.

  • editing/pasteboard/paste-noscript-xhtml-expected.txt:
2:44 PM Changeset in webkit [142035] by commit-queue@webkit.org
  • 31 edits
    3 deletes in trunk/Tools

Unreviewed, rolling out r142032.
http://trac.webkit.org/changeset/142032
https://bugs.webkit.org/show_bug.cgi?id=109095

component build still broken (Requested by jochen on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-06

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTask.h:

(WebTaskList):

  • DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
  • DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebTestInterfaces):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestProxyBase):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:

(AccessibilityUIElementList):

  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:

(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):

  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:

(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):

  • DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:

(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):

  • DumpRenderTree/chromium/TestRunner/src/CppVariant.h:

(CppVariant):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):

  • DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:

(WebTestRunner::NativeKeyCodeForWindowsKeyCode):

  • DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:

(MockGrammarCheck::checkGrammarOfString):

  • DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:

(MockGrammarCheck):

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:

(append):
(isNotASCIIAlpha):
(MockSpellCheck::spellCheckWord):
(MockSpellCheck::initializeIfNeeded):

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:

(MockSpellCheck):

  • DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:

(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):

  • DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:

(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:

(TestPlugin):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner):
(WebTestRunner::TestRunner::setBackingScaleFactor):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:

(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):

  • DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):

  • DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:

(WebTestRunner):
(WebTestRunner::WebTaskList::WebTaskList):
(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):

  • DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
2:33 PM Changeset in webkit [142034] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Expanding failure expectation for fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html.

  • platform/gtk/TestExpectations:
2:30 PM Changeset in webkit [142033] by mark.lam@apple.com
  • 2 edits in trunk/Source/WebCore

Fix broken release builds, greening the bots.
https://bugs.webkit.org/show_bug.cgi?id=107475.

Not reviewed.

No new tests.

  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::logOpenDatabaseError):

2:14 PM Changeset in webkit [142032] by jochen@chromium.org
  • 31 edits
    3 copies in trunk/Tools

[chromium] turn TestRunner library into a component build
https://bugs.webkit.org/show_bug.cgi?id=108466

Reviewed by Adam Barth.

To achieve this, we need to drop all dependencies on WTF.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTask.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
  • DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:

(AccessibilityUIElementList):

  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:

(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):

  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:

(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):

  • DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:

(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):

  • DumpRenderTree/chromium/TestRunner/src/CppVariant.h:

(CppVariant):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):

  • DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:

(WebTestRunner::NativeKeyCodeForWindowsKeyCode):

  • DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:

(WebTestRunner::MockGrammarCheck::checkGrammarOfString):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:

(WebTestRunner):
(MockGrammarCheck):

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:

(WebTestRunner::MockSpellCheck::spellCheckWord):
(WebTestRunner::MockSpellCheck::initializeIfNeeded):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:

(MockSpellCheck):

  • DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:

(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):

  • DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.

(isASCIIAlpha):
(isNotASCIIAlpha):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:

(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:

(TestPlugin):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner::TestRunner::deliverWebIntent):
(WebTestRunner::TestRunner::setBackingScaleFactor):
(WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
(WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
(WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
(WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:

(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):

  • DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):

  • DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:

(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):

  • DumpRenderTree/chromium/TestRunner/src/config.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
1:57 PM Changeset in webkit [142031] by commit-queue@webkit.org
  • 23 edits
    9 deletes in trunk

Unreviewed, rolling out r142025.
http://trac.webkit.org/changeset/142025
https://bugs.webkit.org/show_bug.cgi?id=109091

broke the build (Requested by tdanderson on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-06

Source/WebCore:

  • dom/GestureEvent.cpp:

(WebCore::GestureEvent::create):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureScrollUpdate):

  • platform/PlatformEvent.h:
  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::gestureEvent):

  • platform/chromium/PopupContainer.cpp:

(WebCore::PopupContainer::handleGestureEvent):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollByRecursively):

  • rendering/RenderLayer.h:

Source/WebKit/chromium:

  • public/WebInputEvent.h:

(WebKit::WebInputEvent::isGestureEventType):

  • src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::handleInputEvent):

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPluginContainerImpl.cpp:
  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

Tools:

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::gestureEvent):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.h:

(EventSender):

LayoutTests:

  • fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated-expected.txt: Removed.
  • fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated.html: Removed.
  • fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated-expected.txt: Removed.
  • fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated.html: Removed.
  • fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated-expected.txt: Removed.
  • fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated.html: Removed.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated-expected.txt: Removed.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated-expected.txt: Removed.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated-expected.txt: Removed.
  • platform/chromium/plugins/gesture-events-expected.txt:
  • platform/chromium/plugins/gesture-events-scrolled-expected.txt:
  • platform/chromium/plugins/gesture-events-scrolled.html:
  • platform/chromium/plugins/gesture-events.html:
1:51 PM Changeset in webkit [142030] by mark.lam@apple.com
  • 22 edits in trunk/Source/WebCore

Split openDatabase() between front and back end work.
https://bugs.webkit.org/show_bug.cgi?id=107475.

Reviewed by Anders Carlsson.

The main work of splitting DatabaseManager::openDatabase() is in
refactoring how DatabaseTracker::canEstablishDatabase() works. It used
to check for adequate space quota, and if the check fails, it would call
back into the client from inside canEstablishDatabase(). The call back
allows the client to update the quota (if appropriate). Thereafter,
canEstablishDatabase() will retry its quota check.

In a webkit2 world, we'll want to minimize the traffic between the
client (script side) and the server (sqlite db side), and ideally, we
don't want the server to call back to the client. Note: the
DatabaseTracker belongs on the server side.

To achieve this, we split canEstablishDatabase() into 2 parts: the
checks before the call back to the client, and the checks after.
The first part will retain the name canEstablishDatabase(), and the
second part will be named retryCanEstablishDatabase().
We also added a DatabaseServer::openDatabase() function that can be
called with a retry flag.

The client side DatabaseManager::openDatabase() will call
DatabaseServer::openDatabase(), which then calls canEstablishDatabase()
to do its quota check. If there is enough quota,
DatabaseServer::openDatabase() will proceed to open the backend database
without return to the client first. The opened database will be returned
to the client.

If DatabaseServer::openDatabase() finds inadequate quota the first time,
it will return with a DatabaseSizeExceededQuota error. The DatabaseManager
(on the client side) will check for this error and call back to its client
for an opportunity to increase the quota. Thereafter, the DatabaseManager
will call DatabaseServer::openDatabase() again. This time,
DatabaseServer::openDatabase() will call retryCanEstablishDatabase() to
check the quota, and then open the backend database if there is enough
quota.

No new tests.

  • Modules/webdatabase/AbstractDatabaseServer.h:
  • Modules/webdatabase/DOMWindowWebDatabase.cpp:

(WebCore::DOMWindowWebDatabase::openDatabase):

  • Modules/webdatabase/Database.cpp:

(WebCore::Database::create):

  • Modules/webdatabase/Database.h:

(Database):

  • Modules/webdatabase/DatabaseBackend.cpp:

(WebCore::DatabaseBackend::performOpenAndVerify):

  • Modules/webdatabase/DatabaseBackend.h:

(DatabaseBackend):

  • Modules/webdatabase/DatabaseBackendAsync.cpp:

(WebCore::DatabaseBackendAsync::openAndVerifyVersion):
(WebCore::DatabaseBackendAsync::performOpenAndVerify):

  • Modules/webdatabase/DatabaseBackendAsync.h:

(DatabaseBackendAsync):

  • Modules/webdatabase/DatabaseBackendSync.cpp:

(WebCore::DatabaseBackendSync::openAndVerifyVersion):

  • Modules/webdatabase/DatabaseBackendSync.h:

(DatabaseBackendSync):

  • Modules/webdatabase/DatabaseError.h:

(WebCore::ENUM_CLASS):

  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::exceptionCodeForDatabaseError):
(WebCore::DatabaseManager::openDatabaseBackend):
(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::openDatabaseSync):

  • Modules/webdatabase/DatabaseManager.h:

(DatabaseManager):

  • Modules/webdatabase/DatabaseServer.cpp:

(WebCore::DatabaseServer::openDatabase):
(WebCore::DatabaseServer::createDatabase):

  • Modules/webdatabase/DatabaseServer.h:
  • Modules/webdatabase/DatabaseSync.cpp:

(WebCore::DatabaseSync::create):

  • Modules/webdatabase/DatabaseSync.h:

(DatabaseSync):

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::hasAdequateQuotaForOrigin):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::retryCanEstablishDatabase):

  • Modules/webdatabase/DatabaseTracker.h:

(DatabaseTracker):

  • Modules/webdatabase/WorkerContextWebDatabase.cpp:

(WebCore::WorkerContextWebDatabase::openDatabase):
(WebCore::WorkerContextWebDatabase::openDatabaseSync):

  • Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::retryCanEstablishDatabase):

1:49 PM Changeset in webkit [142029] by tonyg@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix CompactHTMLToken's copy ctor to copy all fields
https://bugs.webkit.org/show_bug.cgi?id=109076

Reviewed by Adam Barth.

This was introduced by me in r142004. Without this patch we fail all tests when using the background parser.

Also don't use getters in copy ctor.

No new tests because no new functionality.

  • html/parser/CompactHTMLToken.cpp:

(WebCore::CompactHTMLToken::CompactHTMLToken):

1:42 PM Changeset in webkit [142028] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Chromium/Skia] Remove use of deprecated Skia names
https://bugs.webkit.org/show_bug.cgi?id=109085

Patch by Brian Salomon <bsalomon@google.com> on 2013-02-06
Reviewed by Stephen White.

Tested by every existing canvas2d test.

  • platform/chromium/support/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::grContext):

1:35 PM Changeset in webkit [142027] by dcheng@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Remove "config.h" header from WebUnitTests.cpp
https://bugs.webkit.org/show_bug.cgi?id=108966

Reviewed by Tony Chang.

This file includes headers from base/ in Chromium, and config.h
conflicts with base/logging.h. Rather than teaching certain files in
base/ not to #include base/logging.h, remove the config.h include
here. The ASSERT isn't really necessary, as attempting to run a null
test suite won't go very far anyway.

  • tests/WebUnitTests.cpp:

(WebKit::RunAllUnitTests):

1:30 PM Changeset in webkit [142026] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Rebaselining and adding a few failure expectations after r142015.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/dynamic/002-expected.txt:
1:26 PM Changeset in webkit [142025] by tdanderson@chromium.org
  • 23 edits
    9 adds in trunk

Add support for gesture scroll events that do not propagate to enclosing scrollables
https://bugs.webkit.org/show_bug.cgi?id=108849

Reviewed by Antonio Gomes.

Source/WebCore:

Tests: fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated.html

fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated.html
fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated.html

Rename RenderLayer::scrollByRecursively() to RenderLayer::scrollBy() and add a parameter
of type RenderLayer::ScrollPropagation to specify whether or not the scroll should
propagate to its parent by recursing. Implement RenderLayer::scrollByRecursively() as a
call to RenderLayer::scrollBy() with argument RenderLayer::ShouldPropagateScroll so
that all existing calls to the function still produce the correct behavior.

In EventHandler::handleGestureScrollUpdate(), call RenderLayer::scrollBy() with
argument RenderLayer::ShouldPropagateScroll if |gestureEvent| is a GestureScrollUpdate
or instead with argument RenderLayer::DontPropagateScroll if |gestureEvent| is a
GestureScrollUpdateWithoutPropagation.

  • dom/GestureEvent.cpp:

(WebCore::GestureEvent::create):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureScrollUpdate):

  • platform/PlatformEvent.h:
  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::gestureEvent):

  • platform/chromium/PopupContainer.cpp:

(WebCore::PopupContainer::handleGestureEvent):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollByRecursively):
(WebCore):
(WebCore::RenderLayer::scrollBy):

  • rendering/RenderLayer.h:

Source/WebKit/chromium:

Define the new event type GestureScrollUpdateWithoutPropagation.

  • public/WebInputEvent.h:

(WebKit::WebInputEvent::isGestureEventType):

  • src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::handleInputEvent):

  • src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

  • src/WebPluginContainerImpl.cpp:
  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::handleInputEvent):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):

Tools:

Modify chromium's DRT EventSender to support the new event type
GestureScrollUpdateWithoutPropagation.

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::gestureScrollUpdateWithoutPropagation):
(WebTestRunner::EventSender::gestureEvent):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.h:

(EventSender):

LayoutTests:

New tests added to ensure that GestureScrollUpdateNotPropagated events will not
propagate to the scrollable parent of their target when the target has no area
left to be scrolled.

Modified two chromium-specific plugin tests to ensure that the plugins receive
GestureScrollUpdate events when GestureScrollUpdateNotPropagated events are
dispatched to them.

  • fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated.html: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated.html: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated.html: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated-expected.txt: Added.
  • platform/chromium/plugins/gesture-events-expected.txt:
  • platform/chromium/plugins/gesture-events-scrolled-expected.txt:
  • platform/chromium/plugins/gesture-events-scrolled.html:
  • platform/chromium/plugins/gesture-events.html:
1:11 PM Changeset in webkit [142024] by rniwa@webkit.org
  • 4 edits in trunk

REGRESSION(r141136): Apple's internal PLT test suite doesn't finish
https://bugs.webkit.org/show_bug.cgi?id=108380

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Re-enable the main resource cache since the regression had been fixed in r141615.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

LayoutTests:

Re-enable tests that have been temporarily disabled.

  • platform/mac/TestExpectations:
1:01 PM Changeset in webkit [142023] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[TestResultServer] Adjust the name of the GTK 64-bit debug builder
https://bugs.webkit.org/show_bug.cgi?id=109016

Reviewed by Ojan Vafai.

  • TestResultServer/static-dashboards/builders.jsonp: The GTK 64-bit debug

builder was adjusted to build WebKit1 only, with the name changed accordingly.
Reflect that change here as well.

1:00 PM Changeset in webkit [142022] by zandobersek@gmail.com
  • 6 edits in trunk/Source/WTF

[WTFURL] Fix erroneous header inclusions in WTFURL code
https://bugs.webkit.org/show_bug.cgi?id=109040

Reviewed by Benjamin Poulain.

Include WTFURL API headers from files in Source/WTF/wtf/url/src
by specifying their relative path to Source/WTF.

  • GNUmakefile.am: The changes make it possible to compile the WTF library

without specifying both Source/WTF/wtf/url/api and Source/WTF/wtf/url/src
as inclusion directories in CPPFLAGS, so remove these two entries.

  • wtf/url/src/RawURLBuffer.h:
  • wtf/url/src/URLCanon.h: Include the URLParse.h header by specifying

only the base name as it's located in the same directory.

  • wtf/url/src/URLCanonQuery.cpp:
  • wtf/url/src/URLUtil.h:
12:58 PM Changeset in webkit [142021] by commit-queue@webkit.org
  • 13 edits
    4 adds in trunk

Implement 'vmax' from CSS3 values and units
https://bugs.webkit.org/show_bug.cgi?id=91440

Patch by Uday Kiran <udaykiran@motorola.com> on 2013-02-06
Reviewed by Antti Koivisto.

vmax is implemented as primitive length unit.
New length type ViewportPercentageMax is added and included support for fetching the value
of this viewport percentage unit based on current viewport size.

The specification related to this implementation is
http://dev.w3.org/csswg/css3-values/#viewport-relative-lengths.

Source/WebCore:

Tests: css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmax-absolute.html

css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmax.html

  • css/CSSGrammar.y.in: Added vmax support.
  • css/CSSParser.cpp: Parsing of vmax unit.

(WebCore::CSSParser::validUnit): Added vmax to valid units.
(WebCore::CSSParser::createPrimitiveNumericValue): Added vmax to primitive untis.
(WebCore::CSSParser::parseValidPrimitive): Creation of CSSPrimitive for vmax.
(WebCore::CSSParser::detectNumberToken): Parsing of vmax token.

  • css/CSSParserValues.cpp:

(WebCore::CSSParserValue::createCSSValue): Added support for vmax.

  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion): Added support for vmax.
(WebCore::unitCategory): Ditto.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Ditto.
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::customCssText): Added support for vmax.
(WebCore::CSSPrimitiveValue::viewportPercentageLength): Function to create the Length structure for the viewport-percentage unit types.
(WebCore::CSSPrimitiveValue::cloneForCSSOM):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isViewportPercentageLength): Checks whether the primitive value is ViewportPercentage Length.

  • css/CSSPrimitiveValue.idl: Added support for vmax.
  • css/LengthFunctions.cpp: Calcuation of length value based on the current viewport size.

(WebCore::minimumValueForLength):
(WebCore::valueForLength):
(WebCore::floatValueForLength):

  • platform/Length.h:

(WebCore::Length::isViewportPercentage): To check the Length is of type ViewportPercentage.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):

LayoutTests:

  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle-expected.txt:
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle.html:
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmax-absolute-expected.html: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmax-absolute.html: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmax-expected.html: Added.
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmax.html: Added.
12:56 PM Changeset in webkit [142020] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Walked through the WontFix test expectations, expanding them with the expected failure.
This forces the test to run but not complain as long as the failure is the same as expected.

  • platform/gtk/TestExpectations:
12:43 PM Changeset in webkit [142019] by nghanavatian@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

2013-02-06 Nima Ghanavatian <nghanavatian@rim.com>

[BlackBerry] Check range before use in parseBlockForSpellChecking
https://bugs.webkit.org/show_bug.cgi?id=109080

Reviewed by Yong Li.

PR291394
This was missed during patch webkit/5aea04f6ea625827. Since getRangeForSpellCheckWithFineGranularity
now returns null values, we need a check here before using the range object here as well.

Internally reviewed by Mike Fenton.

  • WebKitSupport/SpellingHandler.cpp: (BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
12:41 PM Changeset in webkit [142018] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

Suppress failures for minor pixel diffs which will be caused when https://codereview.chromium.org/12217047/ lands. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=104289

  • platform/chromium/TestExpectations:
12:40 PM Changeset in webkit [142017] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

Pass the document source URL to the pluginLoadPolicy callback
https://bugs.webkit.org/show_bug.cgi?id=109084
<rdar://problem/13154516>

Reviewed by Andreas Kling.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getPluginPath):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::pluginLoadPolicy):

  • UIProcess/WebUIClient.h:

(WebUIClient):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
(WebKit::WebPage::canPluginHandleResponse):

12:25 PM Changeset in webkit [142016] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Marking required tests as slow so the test runs are not interrupted when timeouts
occur in tests that would actually pass if given enough time.

  • platform/gtk/TestExpectations:
12:10 PM Changeset in webkit [142015] by commit-queue@webkit.org
  • 17 edits
    14 adds in trunk

When a block element is made inline positioned and has static left and right, it does not follow inline formatting context
https://bugs.webkit.org/show_bug.cgi?id=91665

Patch by Pravin D <pravind.2k4@gmail.com> on 2013-02-06
Reviewed by Julien Chaffraix.

Source/WebCore:

Out-of-flow-positioned elements have their display overriden to BLOCK. When a static block elements
changes to inline out-of-flow-positioned or vice-versa, the element current and previous display properties
are same. This causes the element to follow a wrong flow context(in this case Block context) and the element
is laid out incorrectly. The patch fixes the issue by reattaching the renderers of the node whenever either
position property changes or when its floating property changes.
Also the cases when an out-of-flow-positioned/floating element changes to static/non-floating element where
being specially handled. As reattaching the renderers in the above cases correctly handles the above cases,
special handling for such cases is no more required and the related code can be safely removed.

Reattaching renderers for the afore mentioned issues takes a different(longer) code path. Performance measurements
summary for the same is as follows:

% increase in time

Absolute-block-to-static-block 2.00
Absolute-inline-to-static-block 1.21
Absolute-inline-to-static-inline 1.18
Static-block-to-absolute-block 1.13
Static-inline-to-absolute-inline 1.35
Floating-block-non-floating-block 0.85
Floating-inline-non-floating-block 0.66
Floating-inline-non-floating-inline 0.57
Non-floating-block-floating-block 0.12
Non-floating-inline-floating-inline 1.36

Tests: fast/dynamic/absolute-positioned-to-static-positioned.html

fast/dynamic/floating-to-non-floating.html
fast/dynamic/non-floating-to-floating.html
fast/dynamic/static-positioned-to-absolute-positioned.html

  • dom/Node.cpp:

(WebCore::Node::diff):

Return detach in the following conditions:

1) Element changes to out-of-flow-positioned or vice-versa.
2) Element becomes floating or vice-versa.

  • rendering/RenderBlock.cpp:

(WebCore):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

  • rendering/RenderInline.cpp:

(WebCore):

  • rendering/RenderInline.h:

(RenderInline):

  • rendering/RenderObject.cpp:

(WebCore):
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::styleDidChange):

  • rendering/RenderObject.h:

(RenderObject):

The fix in Node::diff() obsoletes some code. The above deletion are part of this dead code cleanup.

LayoutTests:

  • fast/dynamic/absolute-positioned-to-static-positioned-expected.txt: Added.
  • fast/dynamic/absolute-positioned-to-static-positioned.html: Added.
  • fast/dynamic/floating-to-non-floating-expected.txt: Added.
  • fast/dynamic/floating-to-non-floating.html: Added.
  • fast/dynamic/non-floating-to-floating-expected.txt: Added.
  • fast/dynamic/non-floating-to-floating.html: Added.
  • fast/dynamic/static-positioned-to-absolute-positioned-expected.txt: Added.
  • fast/dynamic/static-positioned-to-absolute-positioned.html: Added.

Testcases for the patch.

  • fast/dynamic/resources/helper-bug91665.js: Added.
  • fast/dynamic/resources/style-bug91665.css: Added.

Common javascript functions and css classes used by the above testcases.

  • fast/css/first-letter-removed-added-expected.txt:

Previously failing sub-test is passing.

  • fullscreen/full-screen-fixed-pos-parent-expected.txt:

Change orthogonal to the current patch.

  • platform/mac/fast/dynamic/002-expected.txt:
  • platform/chromium-win/fast/dynamic/002-expected.txt:
  • platform/chromium/fast/dynamic/002-expected.txt:

Expected change. The testcase has a static block element followed by a text node wrapped
in an anonymous block. When the block element becomes floating, it is out of the flow context.
Thus the text node must no longer be wrapped by the anonymous block.

  • platform/chromium-mac/fast/repaint/absolute-position-change-containing-block-expected.png:
  • platform/chromium-mac/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png:

Progression. Previously we used to repaint the a much larger area as compared to the behavior
with the patch, which repaints only the area affected due to the change in style(position)
of certain elements.

  • platform/chromium/fast/repaint/absolute-position-change-containing-block-expected.png: Added.
  • platform/chromium/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Added.
  • platform/mac/fast/repaint/absolute-position-change-containing-block-expected.png: Added.
  • platform/mac/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Added.

Added platform specific images.

12:08 PM Changeset in webkit [142014] by Chris Fleizach
  • 4 edits
    2 adds in trunk

AX: if <html> has an ARIA attribute, it's exposed as an AXGroup
https://bugs.webkit.org/show_bug.cgi?id=109008

Reviewed by Ryosuke Niwa.

Source/WebCore:

If an <html> element had an ARIA attribute, it was being turned into an element
in the AX hierarchy. This was causing trouble for screen readers by inserting
an unexpected element in the navigation sequence.

Test: accessibility/html-html-element-is-ignored.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

LayoutTests:

  • accessibility/html-html-element-is-ignored-expected.txt: Added.
  • accessibility/html-html-element-is-ignored.html: Added.
  • platform/chromium/TestExpectations:
11:43 AM Changeset in webkit [142013] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Get rid of unneeded writeable preferences.

Reviewed by Anders Carlsson.

com.apple.HIToolbox.plist and com.apple.WebProcess.plist were made writeable very
early in WebKit2 development, before we moved a lot of functionality to UI process.
They don't appear to be needed any more.

Note that we do not even need to allow reading for com.apple.WebProcess.plist -
it's read at process initialization before we enter the sandbox, and services
have a different plist anyway.

  • WebProcess/com.apple.WebProcess.sb.in:
11:35 AM Changeset in webkit [142012] by shawnsingh@chromium.org
  • 3 edits
    3 adds in trunk

RenderLayer hasVisibleContent() has inconsistent semantics causing disappearing composited layers
https://bugs.webkit.org/show_bug.cgi?id=108118

Reviewed by Simon Fraser.

Source/WebCore:

RenderLayerBacking::hasVisibleNonCompositingDescendantLayers was
only checking whether direct children had visible content. As a
result, composited layers had wrong visibility status if only a
deeper descendant RenderLayer was visible.

Test: compositing/visibility/visibility-on-distant-descendant.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::hasVisibleNonCompositingDescendant): copied the original
implementation into this function; then added the RenderLayer
recursion as appropriate.
(WebCore):
(WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendantLayers):
This is now just a wrapper to the private static recursive
function.

LayoutTests:

  • compositing/visibility/visibility-on-distant-descendant-expected.png: Added.
  • compositing/visibility/visibility-on-distant-descendant-expected.txt: Added.
  • compositing/visibility/visibility-on-distant-descendant.html: Added.
11:07 AM Changeset in webkit [142011] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

[Chromium] WebWidget should expose a way to determine the start/end of the selection bounds
https://bugs.webkit.org/show_bug.cgi?id=108667

Patch by Chris Hopman <cjhopman@chromium.org> on 2013-02-06
Reviewed by Darin Fisher.

WebWidget::selectionBounds() returns the anchor and focus of the
selection. This matches the arguments to WebFrame::selectRange().
Add WebWidget::isSelectionAnchorFirst so that a caller can convert the
anchor/focus to start/end.

  • public/WebWidget.h:

(WebWidget):
(WebKit::WebWidget::isSelectionAnchorFirst):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::isSelectionAnchorFirst):
(WebKit):

  • src/WebViewImpl.h:
  • tests/WebViewTest.cpp:
10:56 AM Changeset in webkit [142010] by kerz@chromium.org
  • 2 edits in branches/chromium/1364/Source/WebKit/chromium

Merge 141540

[Chromium] WebViewTest.SetCompositionFromExistingText failing after r141479
https://bugs.webkit.org/show_bug.cgi?id=108543

Patch by Aurimas Liutikas <aurimas@chromium.org> on 2013-01-31
Reviewed by Ryosuke Niwa.

Fixing a bug that was uncovered after fixing http://trac.webkit.org/changeset/141479

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setCompositionFromExistingText):

  • tests/WebViewTest.cpp:

Re-enabling the test

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12233004

10:54 AM Changeset in webkit [142009] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Assertion failure on MiniBrowser exit
https://bugs.webkit.org/show_bug.cgi?id=108932

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-02-06
Reviewed by Anders Carlsson.

WorkQueue is now refcounted after r141497, so increase ref
count when a new job is scheduled and unref it when it finishes.

  • Platform/efl/WorkQueueEfl.cpp:

(WorkQueue::performWork):
(WorkQueue::performTimerWork):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):

10:44 AM Changeset in webkit [142008] by alecflett@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

IndexedDB: Stub out SharedBuffer version of put()
https://bugs.webkit.org/show_bug.cgi?id=108986

Reviewed by Darin Fisher.

This is part 1 of 3 to replace Vector<uint8_t> with SharedBuffer.

  • public/WebIDBDatabase.h:

(WebKit):
(WebKit::WebIDBDatabase::put):

10:35 AM Changeset in webkit [142007] by Gregg Tavares
  • 1 edit
    1567 adds in trunk/LayoutTests

Adds the WebGL Conformance Test ogles support files.
https://bugs.webkit.org/show_bug.cgi?id=109063

Reviewed by Kenneth Russell.

Note: This was reviewed offline because the patch was too large to upload to
bugs.webkit.org. It doesn't add any LayoutTests. It only adds support files.

  • webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_float_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_float_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_float_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_float_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_vec2_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_vec2_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_vec2_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_vec2_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_vec3_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_vec3_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_vec3_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_vec3_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_float_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_float_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_float_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_float_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_vec2_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_vec2_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_vec2_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_vec2_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_vec3_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_vec3_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_vec3_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_vec3_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/all/all_bvec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/all/all_bvec2_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/all/all_bvec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/all/all_bvec2_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/all/all_bvec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/all/all_bvec3_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/all/all_bvec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/all/all_bvec3_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/any/any_bvec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/any/any_bvec2_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/any/any_bvec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/any/any_bvec2_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/any/any_bvec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/any/any_bvec3_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/any/any_bvec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/any/any_bvec3_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/array/empty_empty_array_float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/array/empty_empty_array_float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/array/empty_uniform_array_float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/array/empty_uniform_array_float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/array/initfunc_empty_array_float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/array/initfunc_empty_array_float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_float_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_float_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_float_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_float_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_vec2_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_vec2_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_vec2_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_vec2_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_vec3_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_vec3_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_vec3_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_vec3_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_float_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_float_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_float_frag_xvaryyvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_float_frag_xvaryyvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_float_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_float_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_float_vert_xvaryyvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_float_vert_xvaryyvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec2_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec2_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec2_frag_xvaryyvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec2_frag_xvaryyvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec2_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec2_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec2_vert_xvaryyvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec2_vert_xvaryyvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec3_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec3_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec3_frag_xvaryyvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec3_frag_xvaryyvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec3_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec3_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec3_vert_xvaryyvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_vec3_vert_xvaryyvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxCombinedTextureImageUnits_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxCombinedTextureImageUnits_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxDrawBuffers_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxDrawBuffers_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxFragmentUniformVectors_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxFragmentUniformVectors_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxTextureImageUnits_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxTextureImageUnits_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxVaryingVectors_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxVaryingVectors_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxVertexAttribs_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxVertexAttribs_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxVertexTextureImageUnits_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxVertexTextureImageUnits_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxVertexUniformVectors_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/gl_MaxVertexUniformVectors_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biuDepthRange/DepthRange_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biuDepthRange/DepthRange_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CG_Data_Types_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CG_Standard_Library_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectBuiltInOveride_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectComma_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectConstFolding1_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectConstFolding2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectConstruct_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectExtension10_V100_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectExtension1_V100_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectExtension4_V100_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectFull_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectFuncOverload_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectFuncOverload_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectFunction1_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectModule_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectParse1_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectParse2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectParse2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectParseTest1_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectParseTest_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectPreprocess5_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectPreprocess8_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectPreprocess9_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectSwizzle1_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectSwizzle1_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectSwizzle2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectSwizzle2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectSwizzle3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/CorrectVersion_V100_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/DuplicateVersion1_V100_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/FunctionParam_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/Include_Preprocessor_Directive_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/Low_Level_Assembly_Reserved_Words_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/Main_Parameters_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/ParseTest3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/ParseTest4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/Permissive_Constant_Conversions_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/Permissive_Scalar_Vector_Expressions_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/TernaryOp_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/Texture_Rectangle_Samplers_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/array10_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/array11_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/array1_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/array2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/array3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/array4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/array5_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/array6_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/array7_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/array8_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/array9_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/attribute1_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/attribute2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/attribute_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/attribute_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/break_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/comma1_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/comma2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/comma2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/comma3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/comment_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/conditional1_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/conditional2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/conditional3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/constFunc_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/constructor1_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/constructor2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/constructor3_V100_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/continue_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType10_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType11_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType12_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType13_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType19_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType1_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType5_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType6_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType7_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType8_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/dataType9_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/default.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/default.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/dowhile_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/dvec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/dvec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/dvec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/extension2_V100_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/extension3_V100_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/extension5_V100_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/extension6_V100_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/extension7_V100_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/extension8_V100_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/extension9_V100_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/float2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/float3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/float4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/fragmentOnly1_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/fragmentOnly2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/fragmentOnly3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/fragmentOnly4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/fragmentOnly_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/function10_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/function1_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/function2_V100_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/function3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/function4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/function6_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/function7_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/function8_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/function9_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/hvec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/hvec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/hvec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/identifier1_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/identifier2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/identifier3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/if1_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/if2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/increment1_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/increment2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/increment3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/increment4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/increment6_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/main1_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/main2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/main3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/matrix_V100_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/normal_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/parser10_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/parser1_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/parser3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/parser4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/parser5_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/parser6_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/parser7_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/parser8_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/parser9_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/preprocess0_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/preprocess10_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/preprocess1_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/preprocess2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/preprocess3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/preprocess4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/preprocess6_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/preprocess7_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/scoping1_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/scoping2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct10_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct11_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct1_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct5_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct6_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct7_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct8_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/struct9_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/swizzle1_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/swizzle2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/swizzle3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/typecast_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/uniform1_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/uniform_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/varying1_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/varying2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/varying3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/varying_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/vector_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/version2_V100_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/version3_V100_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/vertexOnly2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/vertexOnly_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/vertex_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/while1_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/while2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/build/while_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/built_in_varying_array_out_of_bounds/gl_Color_array_index_out_of_bounds_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_float_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_float_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_float_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_float_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_vec2_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_vec2_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_vec2_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_vec2_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_vec3_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_vec3_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_vec3_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_vec3_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_float_frag_xvary_yconstquarter.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_float_frag_xvary_yconstquarter_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_float_vert_xvary_yconstquarter.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_float_vert_xvary_yconstquarter_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_vec2_frag_xvary_yconstquarter.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_vec2_frag_xvary_yconstquarter_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_vec2_vert_xvary_yconstquarter.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_vec2_vert_xvary_yconstquarter_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_vec3_frag_xvary_yconstquarter.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_vec3_frag_xvary_yconstquarter_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_vec3_vert_xvary_yconstquarter.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_vec3_vert_xvary_yconstquarter_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/for_break_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/for_break_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/for_continue_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/for_continue_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/for_nested_break_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/for_nested_break_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/for_nested_continue_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/for_nested_continue_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/nested_if_else_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/nested_if_else_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_float_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_float_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_float_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_float_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_vec2_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_vec2_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_vec2_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_vec2_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_vec3_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_vec3_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_vec3_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_vec3_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cross/cross_vec3_frag_xvaryyconst.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cross/cross_vec3_frag_xvaryyconst_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cross/cross_vec3_vert_xvaryyconst.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cross/cross_vec3_vert_xvaryyconst_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/default/default.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/default/default.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/default/default_textured.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/default/default_textured.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/default/expected.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_float_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_float_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_float_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_float_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_vec2_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_vec2_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_vec2_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_vec2_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_vec3_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_vec3_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_vec3_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_vec3_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/discard/discard_cond_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/discard/discard_cond_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/discard/discard_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_float_frag_xvaryyhalf.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_float_frag_xvaryyhalf_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_float_vert_xvaryyhalf.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_float_vert_xvaryyhalf_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_vec2_frag_xvaryyhalf.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_vec2_frag_xvaryyhalf_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_vec2_vert_xvaryyhalf.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_vec2_vert_xvaryyhalf_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_vec3_frag_xvaryyhalf.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_vec3_frag_xvaryyhalf_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_vec3_vert_xvaryyhalf.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_vec3_vert_xvaryyhalf_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_float_frag_xvaryyone.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_float_frag_xvaryyone_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_float_vert_xvaryyone.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_float_vert_xvaryyone_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_vec2_frag_xvaryyhalf.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_vec2_frag_xvaryyhalf_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_vec2_vert_xvaryyhalf.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_vec2_vert_xvaryyhalf_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_vec3_frag_xvaryythird.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_vec3_frag_xvaryythird_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_vec3_vert_xvaryythird.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_vec3_vert_xvaryythird_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_bvec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_bvec2_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_bvec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_bvec2_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_bvec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_bvec3_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_bvec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_bvec3_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_ivec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_ivec2_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_ivec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_ivec2_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_ivec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_ivec3_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_ivec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_ivec3_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_vec2_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_vec2_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_vec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_vec3_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_vec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_vec3_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_float_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_float_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_float_frag_xvaryneg.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_float_frag_xvaryneg_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_float_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_float_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_float_vert_xvaryneg.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_float_vert_xvaryneg_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec2_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec2_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec2_frag_xvaryneg.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec2_frag_xvaryneg_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec2_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec2_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec2_vert_xvaryneg.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec2_vert_xvaryneg_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec3_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec3_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec3_frag_xvaryneg.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec3_frag_xvaryneg_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec3_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec3_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec3_vert_xvaryneg.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_vec3_vert_xvaryneg_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_float_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_float_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_float_frag_xvaryneg.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_float_frag_xvaryneg_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_float_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_float_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_float_vert_xvaryneg.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_float_vert_xvaryneg_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec2_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec2_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec2_frag_xvaryneg.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec2_frag_xvaryneg_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec2_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec2_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec2_vert_xvaryneg.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec2_vert_xvaryneg_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec3_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec3_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec3_frag_xvaryneg.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec3_frag_xvaryneg_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec3_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec3_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec3_vert_xvaryneg.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_vec3_vert_xvaryneg_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_float_frag_nvaryiconst.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_float_frag_nvaryiconst_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_float_vert_nvaryiconst.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_float_vert_nvaryiconst_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_vec2_frag_nvaryiconst.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_vec2_frag_nvaryiconst_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_vec2_vert_nvaryiconst.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_vec2_vert_nvaryiconst_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_vec3_frag_nvaryiconst.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_vec3_frag_nvaryiconst_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_vec3_vert_nvaryiconst.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_vec3_vert_nvaryiconst_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_float_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_float_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_float_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_float_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_vec2_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_vec2_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_vec2_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_vec2_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_vec3_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_vec3_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_vec3_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_vec3_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_float_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_float_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_float_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_float_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_vec2_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_vec2_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_vec2_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_vec2_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_vec3_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_vec3_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_vec3_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_vec3_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/array_float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/array_float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_empty_bool_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_empty_bool_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_empty_bool_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_empty_bool_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_in_bool_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_in_bool_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_in_bool_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_in_bool_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_inout_bool_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_inout_bool_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_inout_bool_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_inout_bool_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_out_bool_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_out_bool_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_out_bool_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bool_empty_out_bool_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_empty_bvec4_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_empty_bvec4_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_empty_bvec4_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_empty_bvec4_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_in_bvec4_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_in_bvec4_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_in_bvec4_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_in_bvec4_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_inout_bvec4_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_inout_bvec4_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_inout_bvec4_bigarray_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_inout_bvec4_bigarray_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_inout_bvec4_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_inout_bvec4_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_out_bvec4_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_out_bvec4_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_out_bvec4_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/bvec4_empty_out_bvec4_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_empty_float_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_empty_float_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_empty_float_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_empty_float_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_in_float_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_in_float_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_in_float_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_in_float_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_inout_float_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_inout_float_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_inout_float_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_inout_float_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_out_float_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_out_float_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_out_float_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/float_empty_out_float_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_empty_int_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_empty_int_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_empty_int_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_empty_int_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_in_int_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_in_int_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_in_int_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_in_int_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_inout_int_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_inout_int_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_inout_int_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_inout_int_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_out_int_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_out_int_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_out_int_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/int_empty_out_int_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_empty_ivec4_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_empty_ivec4_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_empty_ivec4_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_empty_ivec4_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_in_ivec4_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_in_ivec4_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_in_ivec4_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_in_ivec4_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_inout_ivec4_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_inout_ivec4_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_inout_ivec4_bigarray_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_inout_ivec4_bigarray_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_inout_ivec4_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_inout_ivec4_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_out_ivec4_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_out_ivec4_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_out_ivec4_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/ivec4_empty_out_ivec4_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_empty_mat4_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_empty_mat4_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_empty_mat4_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_empty_mat4_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_in_mat4_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_in_mat4_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_in_mat4_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_in_mat4_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_inout_mat4_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_inout_mat4_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_inout_mat4_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_inout_mat4_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_out_mat4_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_out_mat4_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_out_mat4_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/mat4_empty_out_mat4_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/qualifiers_float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/qualifiers_float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/qualifiers_struct_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/qualifiers_struct_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_empty_vec4_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_empty_vec4_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_empty_vec4_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_empty_vec4_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_in_vec4_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_in_vec4_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_in_vec4_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_in_vec4_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_inout_vec4_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_inout_vec4_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_inout_vec4_bigarray_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_inout_vec4_bigarray_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_inout_vec4_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_inout_vec4_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_out_vec4_array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_out_vec4_array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_out_vec4_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/vec4_empty_out_vec4_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/void_empty_empty_void_empty_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/void_empty_empty_void_empty_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_w_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_xy_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_xy_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_z_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_z_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_z_frag_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FrontFacing/gl_FrontFacing_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_ivec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_ivec2_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_ivec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_ivec2_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_ivec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_ivec3_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_ivec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_ivec3_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_vec2_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_vec2_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_vec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_vec3_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_vec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_vec3_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_ivec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_ivec2_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_ivec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_ivec2_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_ivec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_ivec3_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_ivec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_ivec3_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_vec2_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_vec2_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_vec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_vec3_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_vec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_vec3_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_float_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_float_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_float_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_float_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_vec2_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_vec2_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_vec2_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_vec2_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_vec3_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_vec3_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_vec3_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_vec3_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_float_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_float_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_float_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_float_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_vec2_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_vec2_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_vec2_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_vec2_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_vec3_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_vec3_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_vec3_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_vec3_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_ivec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_ivec2_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_ivec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_ivec2_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_ivec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_ivec3_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_ivec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_ivec3_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_vec2_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_vec2_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_vec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_vec3_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_vec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_vec3_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_ivec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_ivec2_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_ivec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_ivec2_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_ivec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_ivec3_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_ivec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_ivec3_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_vec2_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_vec2_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_vec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_vec3_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_vec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_vec3_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_float_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_float_frag_xvary01.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_float_frag_xvary01_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_float_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_float_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_float_vert_xvary01.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_float_vert_xvary01_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_float_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec2_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec2_frag_xvary01.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec2_frag_xvary01_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec2_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec2_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec2_vert_xvary01.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec2_vert_xvary01_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec2_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec3_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec3_frag_xvary01.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec3_frag_xvary01_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec3_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec3_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec3_vert_xvary01.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec3_vert_xvary01_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_vec3_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_float_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_float_frag_xvary01.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_float_frag_xvary01_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_float_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_float_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_float_vert_xvary01.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_float_vert_xvary01_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_float_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec2_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec2_frag_xvary01.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec2_frag_xvary01_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec2_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec2_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec2_vert_xvary01.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec2_vert_xvary01_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec2_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec3_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec3_frag_xvary01.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec3_frag_xvary01_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec3_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec3_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec3_vert_xvary01.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec3_vert_xvary01_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_vec3_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/array_const_mat2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/array_const_mat2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/array_const_mat3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/array_const_mat3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/array_const_mat4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/array_const_mat4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat2_copy_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat2_copy_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat3_copy_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat3_copy_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat4_copy_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat4_copy_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/const_mat4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat2_2vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat2_2vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat2_4float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat2_4float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat2_copy_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat2_copy_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat2_float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat2_float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat3_3vec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat3_3vec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat3_9float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat3_9float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat3_copy_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat3_copy_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat3_float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat3_float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat4_16float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat4_16float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat4_4vec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat4_4vec4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat4_copy_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat4_copy_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat3/mat3arrayindirect0_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat3/mat3arrayindirect0_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat3/mat3arrayindirect1_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat3/mat3arrayindirect1_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat3/mat3arraysimple_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat3/mat3arraysimple_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/matrixMultComp_mat2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/matrixMultComp_mat2_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/matrixMultComp_mat2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/matrixMultComp_mat2_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/matrixMultComp_mat3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/matrixMultComp_mat3_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/matrixMultComp_mat3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/matrixMultComp_mat3_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_float_frag_xvary_yconsthalf.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_float_frag_xvary_yconsthalf_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_float_vert_xvary_yconsthalf.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_float_vert_xvary_yconsthalf_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_vec2_frag_xvary_yconsthalf.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_vec2_frag_xvary_yconsthalf_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_vec2_vert_xvary_yconsthalf.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_vec2_vert_xvary_yconsthalf_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_vec3_frag_xvary_yconsthalf.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_vec3_frag_xvary_yconsthalf_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_vec3_vert_xvary_yconsthalf.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_vec3_vert_xvary_yconsthalf_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_float_frag_xvary_yconsthalf.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_float_frag_xvary_yconsthalf_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_float_vert_xvary_yconsthalf.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_float_vert_xvary_yconsthalf_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_vec2_frag_xvary_yconsthalf.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_vec2_frag_xvary_yconsthalf_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_vec2_vert_xvary_yconsthalf.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_vec2_vert_xvary_yconsthalf_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_vec3_frag_xvary_yconsthalf.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_vec3_frag_xvary_yconsthalf_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_vec3_vert_xvary_yconsthalf.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_vec3_vert_xvary_yconsthalf_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_float_frag_xvary_yconsthalf_aconsthalf.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_float_frag_xvary_yconsthalf_aconsthalf_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_float_vert_xvary_yconsthalf_aconsthalf.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_float_vert_xvary_yconsthalf_aconsthalf_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_vec2_frag_xvary_yconsthalf_aconsthalf.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_vec2_frag_xvary_yconsthalf_aconsthalf_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_vec2_vert_xvary_yconsthalf_aconsthalf.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_vec2_vert_xvary_yconsthalf_aconsthalf_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_vec3_frag_xvary_yconsthalf_aconsthalf.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_vec3_frag_xvary_yconsthalf_aconsthalf_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_vec3_vert_xvary_yconsthalf_aconsthalf.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_vec3_vert_xvary_yconsthalf_aconsthalf_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_float_frag_xvary_yconst1.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_float_frag_xvary_yconst1_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_float_vert_xvary_yconst1.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_float_vert_xvary_yconst1_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_vec2_frag_xvary_yconst1.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_vec2_frag_xvary_yconst1_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_vec2_vert_xvary_yconst1.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_vec2_vert_xvary_yconst1_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_vec3_frag_xvary_yconst1.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_vec3_frag_xvary_yconst1_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_vec3_vert_xvary_yconst1.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_vec3_vert_xvary_yconst1_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_x_large_y_large_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_x_large_y_large_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_float_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_float_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_float_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_float_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_vec2_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_vec2_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_vec2_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_vec2_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_vec3_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_vec3_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_vec3_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_vec3_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/not/not_bvec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/not/not_bvec2_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/not/not_bvec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/not/not_bvec2_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/not/not_bvec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/not/not_bvec3_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/not/not_bvec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/not/not_bvec3_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_bvec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_bvec2_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_bvec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_bvec2_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_bvec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_bvec3_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_bvec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_bvec3_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_ivec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_ivec2_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_ivec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_ivec2_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_ivec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_ivec3_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_ivec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_ivec3_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_vec2_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_vec2_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_vec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_vec3_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_vec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_vec3_vert_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/addsubtract_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/addsubtract_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/assignments_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/assignments_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/division_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/division_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/equality_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/equality_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/logical_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/logical_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/multiplicative_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/multiplicative_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/postfixdecrement_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/postfixdecrement_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/postfixincrement_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/postfixincrement_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/prefixdecrement_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/prefixdecrement_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/prefixincrement_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/prefixincrement_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/relational_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/relational_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/selection_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/selection_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/unary_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/unary_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_frag_xconst2_yvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_frag_xconst2_yvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_frag_xconsthalf_yvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_frag_xconsthalf_yvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_frag_xvary_yconst2.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_frag_xvary_yconst2_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_frag_xvary_yconsthalf.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_frag_xvary_yconsthalf_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_vert_xconst2_yvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_vert_xconst2_yvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_vert_xconsthalf_yvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_vert_xconsthalf_yvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_vert_xvary_yconst2.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_vert_xvary_yconst2_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_vert_xvary_yconsthalf.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_float_vert_xvary_yconsthalf_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_frag_xconst2_yvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_frag_xconst2_yvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_frag_xconsthalf_yvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_frag_xconsthalf_yvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_frag_xvary_yconst2.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_frag_xvary_yconst2_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_frag_xvary_yconsthalf.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_frag_xvary_yconsthalf_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_vert_xconst2_yvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_vert_xconst2_yvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_vert_xconsthalf_yvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_vert_xconsthalf_yvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_vert_xvary_yconst2.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_vert_xvary_yconst2_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_vert_xvary_yconsthalf.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec2_vert_xvary_yconsthalf_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_frag_xconst2_yvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_frag_xconst2_yvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_frag_xconsthalf_yvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_frag_xconsthalf_yvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_frag_xvary_yconst2.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_frag_xvary_yconst2_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_frag_xvary_yconsthalf.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_frag_xvary_yconsthalf_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_vert_xconst2_yvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_vert_xconst2_yvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_vert_xconsthalf_yvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_vert_xconsthalf_yvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_vert_xvary_yconst2.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_vert_xvary_yconst2_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_vert_xvary_yconsthalf.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_vec3_vert_xvary_yconsthalf_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_float_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_float_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_float_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_float_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_vec2_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_vec2_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_vec2_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_vec2_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_vec3_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_vec3_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_vec3_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_vec3_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_float_frag_ivarynconst.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_float_frag_ivarynconst_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_float_vert_ivarynconst.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_float_vert_ivarynconst_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_vec2_frag_ivarynconst.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_vec2_frag_ivarynconst_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_vec2_vert_ivarynconst.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_vec2_vert_ivarynconst_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_vec3_frag_ivarynconst.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_vec3_frag_ivarynconst_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_vec3_vert_ivarynconst.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_vec3_vert_ivarynconst_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_float_frag_ivarynconst.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_float_frag_ivarynconst_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_float_vert_ivarynconst.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_float_vert_ivarynconst_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_vec2_frag_ivarynconst.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_vec2_frag_ivarynconst_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_vec2_vert_ivarynconst.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_vec2_vert_ivarynconst_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_vec3_frag_ivarynconst.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_vec3_frag_ivarynconst_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_vec3_vert_ivarynconst.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_vec3_vert_ivarynconst_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_float_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_float_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_float_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_float_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_vec2_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_vec2_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_vec2_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_vec2_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_vec3_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_vec3_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_vec3_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_vec3_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_float_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_float_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_float_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_float_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_vec2_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_vec2_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_vec2_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_vec2_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_vec3_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_vec3_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_vec3_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_vec3_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_float_frag_xvary_edgeconstquarter.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_float_frag_xvary_edgeconstquarter_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_float_vert_xvary_edgeconstquarter.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_float_vert_xvary_edgeconstquarter_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_vec2_frag_xvary_edgeconstquarter.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_vec2_frag_xvary_edgeconstquarter_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_vec2_vert_xvary_edgeconstquarter.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_vec2_vert_xvary_edgeconstquarter_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_vec3_frag_xvary_edgeconstquarter.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_vec3_frag_xvary_edgeconstquarter_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_vec3_vert_xvary_edgeconstquarter.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_vec3_vert_xvary_edgeconstquarter_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_float_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_float_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_float_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_float_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_vec2_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_vec2_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_vec2_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_vec2_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_vec3_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_vec3_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_vec3_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_vec3_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_float_frag_xvary_edgeconsthalf.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_float_frag_xvary_edgeconsthalf_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_float_vert_xvary_edgeconsthalf.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_float_vert_xvary_edgeconsthalf_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_vec2_frag_xvary_edgeconsthalf.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_vec2_frag_xvary_edgeconsthalf_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_vec2_vert_xvary_edgeconsthalf.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_vec2_vert_xvary_edgeconsthalf_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_vec3_frag_xvary_edgeconsthalf.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_vec3_frag_xvary_edgeconsthalf_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_vec3_vert_xvary_edgeconsthalf.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_vec3_vert_xvary_edgeconsthalf_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/nestedstructcomb_various_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/nestedstructcomb_various_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_bool_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_bool_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_bvec2bvec3bvec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_bvec2bvec3bvec4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_mat2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_mat2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_mat3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_mat3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_mat4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_mat4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_vec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_vec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_vec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_vec4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_bool_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_bool_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_bvec2bvec3bvec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_bvec2bvec3bvec4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_mat2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_mat2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_mat3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_mat3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_mat4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_mat4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_vec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_vec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_vec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structcopy_vec4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_bool_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_bool_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_bvec2bvec3bvec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_bvec2bvec3bvec4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_mat2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_mat2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_mat3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_mat3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_mat4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_mat4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_vec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_vec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_vec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/structnest_vec4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_bgr_1vec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_bgr_1vec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_br_g_1vec2_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_br_g_1vec2_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_gb_r_1vec2_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_gb_r_1vec2_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_grb_1vec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_grb_1vec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_ps_t_1vec2_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_ps_t_1vec2_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_pts_1vec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_pts_1vec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_rb_g_1vec2_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_rb_g_1vec2_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_rg_b_1vec2_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_rg_b_1vec2_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_rgb_1vec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_rgb_1vec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_sp_t_1vec2_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_sp_t_1vec2_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_st_p_1vec2_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_st_p_1vec2_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_stp_1vec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_stp_1vec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_tp_s_1vec2_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_tp_s_1vec2_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_tsp_1vec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_tsp_1vec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_xy_z_1vec2_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_xy_z_1vec2_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_xyz_1vec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_xyz_1vec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_xz_y_1vec2_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_xz_y_1vec2_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_yxz_1vec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_yxz_1vec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_yz_x_1vec2_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_yz_x_1vec2_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_zx_y_1vec2_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_zx_y_1vec2_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_zyx_1vec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec3_zyx_1vec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_ar_bg_2vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_ar_bg_2vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_arb_g_1vec3_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_arb_g_1vec3_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_arbg_1vec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_arbg_1vec4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_bar_g_1vec3_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_bar_g_1vec3_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_barg_1vec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_barg_1vec4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_br_ag_2vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_br_ag_2vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_gr_ab_2vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_gr_ab_2vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_gra_b_1vec3_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_gra_b_1vec3_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_grab_1vec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_grab_1vec4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_pqs_t_1vec3_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_pqs_t_1vec3_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_pqst_1vec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_pqst_1vec4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_ps_qt_2vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_ps_qt_2vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_qs_pt_2vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_qs_pt_2vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_qsp_t_1vec3_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_qsp_t_1vec3_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_qspt_1vec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_qspt_1vec4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_r_g_b_a_4float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_r_g_b_a_4float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_rg_ba_2vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_rg_ba_2vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_rgb_a_1vec3_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_rgb_a_1vec3_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_rgba_1vec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_rgba_1vec4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_s_t_p_q_4float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_s_t_p_q_4float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_st_pq_2vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_st_pq_2vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_stp_q_1vec3_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_stp_q_1vec3_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_stpq_1vec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_stpq_1vec4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_ts_qp_2vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_ts_qp_2vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_tsq_p_1vec3_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_tsq_p_1vec3_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_tsqp_1vec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_tsqp_1vec4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_wx_zy_2vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_wx_zy_2vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_wxz_y_1vec3_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_wxz_y_1vec3_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_wxzy_1vec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_wxzy_1vec4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_x_y_z_w_4float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_x_y_z_w_4float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_xy_zw_2vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_xy_zw_2vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_xyz_w_1vec3_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_xyz_w_1vec3_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_xyzw_1vec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_xyzw_1vec4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_yx_wz_2vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_yx_wz_2vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_yxw_z_1vec3_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_yxw_z_1vec3_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_yxwz_1vec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_yxwz_1vec4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_zwx_y_1vec3_1float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_zwx_y_1vec3_1float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_zwxy_1vec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_zwxy_1vec4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_zx_wy_2vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/vec4_zx_wy_2vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_float_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_float_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_float_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_float_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_vec2_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_vec2_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_vec2_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_vec2_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_vec3_frag_xvary.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_vec3_frag_xvary_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_vec3_vert_xvary.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_vec3_vert_xvary_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/bvec4_2int_2float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/bvec4_2int_2float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/ivec3_3int_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/ivec3_3int_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec2_2float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec2_2float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec2_vec3_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec2_vec3_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec3_float_vec2_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec3_float_vec2_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec3_vec2_float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec3_vec2_float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec3_vec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec3_vec4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec4_ivec4_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec4_ivec4_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec4_vec3_float_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec4_vec3_float_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/vec3array_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/vec3array_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/vec3arraydirect_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/vec3arraydirect_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/vec3arrayindirect_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/vec3arrayindirect_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/vec3single_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/vec3single_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/compressed_paletted_texture/compressed_paletted_texture.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/compressed_paletted_texture/compressed_paletted_texture.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/dFdx/dFdx_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/dFdx/dFdx_frag.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/dFdx/dFdx_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/dFdx/dFdx_frag_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/dFdy/dFdy_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/dFdy/dFdy_frag.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/dFdy/dFdy_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/dFdy/dFdy_frag_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/default_shaders/default.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/default_shaders/default.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/default_shaders/default_textured.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/default_shaders/default_textured.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag_dx.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag_dx.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag_dy.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag_dy.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag_ref_dx.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag_ref_dx.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag_ref_dy.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2ExtensionTests/fwidth/fwidth_frag_ref_dy.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/buffer_objects/buffer_objects.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/buffer_objects/buffer_objects.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/buffer_objects/buffer_objects_multitexturing.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/buffer_objects/buffer_objects_multitexturing.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/buffer_objects/buffer_objects_pointSize.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/buffer_objects/buffer_objects_pointSize.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/copy_texture/copy_texture.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/default_shaders/default.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/default_shaders/default.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/default_shaders/default_textured.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/default_shaders/default_textured.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/lighting_diffuse/lighting_diffuse.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/lighting_diffuse/lighting_diffuse.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/lighting_diffuse/lighting_diffuse_ref.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/lighting_diffuse/lighting_diffuse_ref.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/point_rasterization/point_rasterization.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/point_rasterization/point_rasterization.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/point_sprites/point_sprites.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/point_sprites/point_sprites.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/user_clip_planes/user_clip_planes.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2FixedTests/user_clip_planes/user_clip_planes.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/attach_shader/successfulcompile_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/attach_shader/successfulcompile_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/attach_shader/unsuccessfulcompile_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/attach_shader/unsuccessfulcompile_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/bind_attribute_location/brick.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/bind_attribute_location/brick.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/compile_shader/brick.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/compile_shader/texture.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/compile_shader/wood.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/compile_shader/wood.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/delete_object/successfulcompile_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/delete_object/successfulcompile_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/detach_shader/successfulcompile_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/detach_shader/successfulcompile_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/framebuffer_objects/fboShader0.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/framebuffer_objects/fboShader0.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_active_attribute/brick.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_active_attribute/brick_mat2.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_active_attribute/brick_mat3.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_active_attribute/brick_mat4.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_active_attribute/brick_vec.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_active_uniform/brick.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_active_uniform/brick.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_attribute_location/brick.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_attribute_location/brick.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_handle/successfulcompile_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_handle/successfulcompile_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_uniform_location/brick.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/get_uniform_location/brick.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetProgramInfoLog_2.0/simple.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetProgramInfoLog_2.0/simple.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetProgramiv_2.0/brick.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetProgramiv_2.0/brick.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetShaderInfoLog_2.0/simple.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetShaderInfoLog_2.0/simple.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetUniform/bvec_tests.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetUniform/bvec_tests.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetUniform/ivec_tests.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetUniform/ivec_tests.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetUniform/mat_tests.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetUniform/mat_tests.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetUniform/vec_tests.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetUniform/vec_tests.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetVertexAttrib/mat_tests.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetVertexAttrib/mat_tests2.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glGetVertexAttrib/vec_tests.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/1b_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/1b_vert.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/1b_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/1f_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/1f_vert.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/1f_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/1i_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/1i_vert.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/1i_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/21f_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/21i_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/22f_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/22i_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/23f_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/23i_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/24f_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/24i_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/2b_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/2b_vert.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/2b_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/2f_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/2f_vert.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/2f_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/2i_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/2i_vert.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/2i_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/2m_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/3b_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/3b_vert.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/3b_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/3f_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/3f_vert.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/3f_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/3i_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/3i_vert.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/3i_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/3m_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4b_firstthree_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4b_firstthree_vert.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4b_lastthree_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4b_lastthree_vert.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4b_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4f_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4f_vert.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4f_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4i_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4i_vert.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4i_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/4m_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/default.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/matrix2VSU.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/matrix2VSU.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/matrix2arrayVSU.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/matrix2arrayVSU.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/matrixVSU.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/glUniform/matrixVSU.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/link_program/successfulcompile_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/link_program/successfulcompile_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/link_program/unsuccessfulcompile_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/link_program/unsuccessfulcompile_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/precision_specifiers/precision_specifiers.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/precision_specifiers/precision_specifiers.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/relink_program/simple.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/relink_program/simple.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/shader_source/successfulcompile_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/shader_source/successfulcompile_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/shader_source/unsuccessfulcompile_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/shader_source/unsuccessfulcompile_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/three_uniforms/4f_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/use_program/successfulcompile_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/use_program/successfulcompile_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/use_program/unsuccessfulcompile_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/use_program/unsuccessfulcompile_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/validate_program/successfulcompile_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/validate_program/successfulcompile_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/validate_program/unsuccessfulcompile_frag.frag: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/validate_program/unsuccessfulcompile_vert.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL2Tests/vertex_program_point_size/point_size.vert: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/ogles-utils.js: Added.

(OpenGLESTestRunner):
(OpenGLESTestRunner.):

10:22 AM Changeset in webkit [142006] by nghanavatian@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Check for a valid range object before using it
https://bugs.webkit.org/show_bug.cgi?id=109058

Reviewed by Rob Buis.

PR291394
Crash occurs if makeRange returns null, since we are using this value without checking
its validity. We had an assert before which I'm replacing with just a check for null.

Internally reviewed by Mike Fenton.

  • WebKitSupport/SpellingHandler.cpp:

(BlackBerry::WebKit::SpellingHandler::getRangeForSpellCheckWithFineGranularity):

10:15 AM Changeset in webkit [142005] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk

[GStreamer] MediaPlayer's code is not easily reusable by other GStreamer-based players
https://bugs.webkit.org/show_bug.cgi?id=100261

.:

Patch by Jonathon Jongsma <jonathon.jongsma@collabora.com> on 2013-02-06
Reviewed by Philippe Normand

  • configure.ac: removed farstream requirement for now since it's

not actually used yet and makes it more difficult to build and test

Source/WebCore:

Refactor the media player implementation so that more of the
internal functionality can be shared between the current media
backend and the mediastream player backend. Common code is
broken out into a MediaPlayerPrivateGStreamerBase class, and
both MediaPlayerPrivateGStreamer and
StreamMediaPlayerPrivateGStreamer inherit from this base class.

Patch by Jonathon Jongsma <jonathon.jongsma@collabora.com> on 2013-02-06
Reviewed by Philippe Normand

No new tests since functionality is covered by existing media tests

  • GNUmakefile.list.am:
  • PlatformEfl.cmake:
  • Target.pri:
  • platform/graphics/gstreamer/FullscreenVideoControllerGStreamer.cpp:

(WebCore::FullscreenVideoControllerGStreamer::create):
(WebCore::FullscreenVideoControllerGStreamer::FullscreenVideoControllerGStreamer):

  • platform/graphics/gstreamer/FullscreenVideoControllerGStreamer.h:

(WebCore):
(FullscreenVideoControllerGStreamer):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::isLiveStream):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp: Added.

(WebCore):
(WebCore::greatestCommonDivisor):
(WebCore::mediaPlayerPrivateVolumeChangedCallback):
(WebCore::mediaPlayerPrivateVolumeChangeTimeoutCallback):
(WebCore::mediaPlayerPrivateMuteChangedCallback):
(WebCore::mediaPlayerPrivateMuteChangeTimeoutCallback):
(WebCore::mediaPlayerPrivateRepaintCallback):
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::naturalSize):
(WebCore::MediaPlayerPrivateGStreamerBase::setVolume):
(WebCore::MediaPlayerPrivateGStreamerBase::volume):
(WebCore::MediaPlayerPrivateGStreamerBase::notifyPlayerOfVolumeChange):
(WebCore::MediaPlayerPrivateGStreamerBase::volumeChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::networkState):
(WebCore::MediaPlayerPrivateGStreamerBase::readyState):
(WebCore::MediaPlayerPrivateGStreamerBase::sizeChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::setMuted):
(WebCore::MediaPlayerPrivateGStreamerBase::muted):
(WebCore::MediaPlayerPrivateGStreamerBase::notifyPlayerOfMute):
(WebCore::MediaPlayerPrivateGStreamerBase::muteChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::setSize):
(WebCore::MediaPlayerPrivateGStreamerBase::paint):
(WebCore::MediaPlayerPrivateGStreamerBase::enterFullscreen):
(WebCore::MediaPlayerPrivateGStreamerBase::exitFullscreen):
(WebCore::MediaPlayerPrivateGStreamerBase::supportsFullscreen):
(WebCore::MediaPlayerPrivateGStreamerBase::platformMedia):
(WebCore::MediaPlayerPrivateGStreamerBase::movieLoadType):
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):
(WebCore::MediaPlayerPrivateGStreamerBase::setStreamVolumeElement):
(WebCore::MediaPlayerPrivateGStreamerBase::decodedFrameCount):
(WebCore::MediaPlayerPrivateGStreamerBase::droppedFrameCount):
(WebCore::MediaPlayerPrivateGStreamerBase::audioDecodedByteCount):
(WebCore::MediaPlayerPrivateGStreamerBase::videoDecodedByteCount):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h: Added.

(WebCore):
(MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::supportsMuting):
(WebCore::MediaPlayerPrivateGStreamerBase::setVisible):
(WebCore::MediaPlayerPrivateGStreamerBase::hasSingleSecurityOrigin):
(WebCore::MediaPlayerPrivateGStreamerBase::maxTimeLoaded):
(WebCore::MediaPlayerPrivateGStreamerBase::canEnterFullscreen):
(WebCore::MediaPlayerPrivateGStreamerBase::mediaPlayer):
(WebCore::MediaPlayerPrivateGStreamerBase::audioSink):

  • platform/graphics/gtk/FullscreenVideoControllerGtk.cpp:

(WebCore::FullscreenVideoControllerGtk::FullscreenVideoControllerGtk):

  • platform/graphics/gtk/FullscreenVideoControllerGtk.h:

(FullscreenVideoControllerGtk):

9:50 AM Changeset in webkit [142004] by tonyg@chromium.org
  • 21 edits in trunk/Source

Call XSSAuditor's didBlockScript() for the threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=108726

Reviewed by Adam Barth.

Source/WebCore:

This patch causes us to call didBlockScript() on the main thread if the CompactHTML token has XSSInfo.
To do so, we:

  1. Rename DidBlockScriptRequest to XSSInfo.
  2. Add an OwnPtr<XSSInfo> field to CompactHTMLToken.
  3. Add an isSafeToSendToAnotherThread() method to String and KURL.

We don't yet populate didBlockScriptRequest on the background thread, but this should just work once we do.

No new tests because no new functionality.

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::pumpTokenizer): Update comment for rename.

  • html/parser/CompactHTMLToken.cpp:

(SameSizeAsCompactHTMLToken):
(WebCore::CompactHTMLToken::CompactHTMLToken): Add a copy constructor used by Vector.
(WebCore::CompactHTMLToken::isSafeToSendToAnotherThread): Include new m_xssInfo field in safety check.
(WebCore):
(WebCore::CompactHTMLToken::xssInfo): Added.
(WebCore::CompactHTMLToken::setXSSInfo): Added.

  • html/parser/CompactHTMLToken.h: Add an OwnPtr<XSSInfo> field to CompactHTMLToken.

(WebCore):
(CompactHTMLToken):
(WTF): Add VectorTraits necessary for copying Vector fields objects that contain an OwnPtr.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser): Add new didBlockScript() call.
(WebCore::HTMLDocumentParser::pumpTokenizer):

  • html/parser/XSSAuditor.cpp: Renaming.

(WebCore::XSSAuditor::filterToken):

  • html/parser/XSSAuditor.h: Renaming.

(WebCore):
(XSSAuditor):

  • html/parser/XSSAuditorDelegate.cpp:

(WebCore::XSSInfo::isSafeToSendToAnotherThread):
(WebCore):
(WebCore::XSSAuditorDelegate::didBlockScript):

  • html/parser/XSSAuditorDelegate.h:

(WebCore::XSSInfo::create):
(XSSInfo):
(WebCore::XSSInfo::XSSInfo):
(XSSAuditorDelegate):

  • platform/KURL.cpp:

(WebCore::KURL::isSafeToSendToAnotherThread): Added.
(WebCore):

  • platform/KURL.h:

(KURL):

  • platform/KURLGoogle.cpp:

(WebCore):
(WebCore::KURLGooglePrivate::isSafeToSendToAnotherThread): Added.

  • platform/KURLGooglePrivate.h:

(KURLGooglePrivate):

  • platform/KURLWTFURLImpl.h:

(WebCore::KURLWTFURLImpl::isSafeToSendToAnotherThread): Added.

Source/WTF:

This patch adds isSafeToSendToAnotherThread() methods to CString, String, ParsedURL and URLString.
These methods check to ensure there are 0 or 1 references.

  • wtf/text/CString.cpp:

(WTF::CString::isSafeToSendToAnotherThread): Added.
(WTF):

  • wtf/text/CString.h:

(CString):

  • wtf/text/WTFString.cpp:

(WTF::String::isSafeToSendToAnotherThread): Added.
(WTF):

  • wtf/text/WTFString.h:

(String):

  • wtf/url/api/ParsedURL.h:

(WTF::ParsedURL::isSafeToSendToAnotherThread): Added.

  • wtf/url/api/URLString.h:

(WTF::URLString::isSafeToSendToAnotherThread): Added.

9:27 AM Changeset in webkit [142003] by dino@apple.com
  • 9 edits in trunk

Minor updates to captions menu UI
https://bugs.webkit.org/show_bug.cgi?id=109005

Reviewed by Eric Carlson.

Now that we only have a single section in the captions menu, remove the
unnecessary wrapper element. Also update the UI for Mac so that the menu
grows in size dynamically, and change the text we display for a caption
that has neither label or language identifiers.

Covered by existing tests.

  • English.lproj/Localizable.strings: New string for an unknown caption label.
  • css/fullscreenQuickTime.css: New rules for the captions menu.

(video:-webkit-full-screen::-webkit-media-controls-closed-captions-container):
(video:-webkit-full-screen::-webkit-media-controls-closed-captions-track-list):

  • css/mediaControlsQuickTime.css: Ditto.

(video::-webkit-media-controls-closed-captions-container):
(video::-webkit-media-controls-closed-captions-track-list):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu):

Remove the <section> element container.

  • platform/LocalizedStrings.cpp:

(WebCore::textTrackNoLabelText): New string for an unknown caption label.

LayoutTests:

A caption track without a label or language is now given the menu
title 'Unknown'. Note also that the test includes some intentional
failure text.

  • media/video-controls-captions-trackmenu-localized.html:
  • platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
8:20 AM Changeset in webkit [142002] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[WK2][Win] Fix build after MessageID.h related changes and after r141619.
https://bugs.webkit.org/show_bug.cgi?id=108612

Patch by Simon Hausmann <simon.hausmann@digia.com>, Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-02-06
Reviewed by Anders Carlsson.

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::readEventHandler):
(CoreIPC::Connection::open):
(CoreIPC::Connection::sendOutgoingMessage):

  • Platform/WorkQueue.h:

(WorkQueue::WorkItemWin::queue):
(WorkItemWin):

  • Platform/win/SharedMemoryWin.cpp:

(WebKit::SharedMemory::Handle::decode):

  • Platform/win/WorkQueueWin.cpp:

(WorkQueue::handleCallback):
(WorkQueue::performWorkOnRegisteredWorkThread):

8:10 AM Changeset in webkit [142001] by schenney@chromium.org
  • 5 edits
    3 adds in trunk/LayoutTests

[Chromium] Test expectations update for Skia change.

Unreviewed expectations update

  • platform/chromium-mac/fast/writing-mode/japanese-lr-text-expected.png:
  • platform/chromium-mac/fast/writing-mode/japanese-lr-text-expected.txt: Added.
  • platform/chromium-mac/fast/writing-mode/japanese-rl-selection-expected.png:
  • platform/chromium-mac/fast/writing-mode/japanese-rl-selection-expected.txt: Added.
  • platform/chromium-mac/fast/writing-mode/japanese-rl-text-expected.png:
  • platform/chromium-mac/fast/writing-mode/japanese-rl-text-expected.txt: Added.
  • platform/chromium/TestExpectations:
7:52 AM Changeset in webkit [142000] by vsevik@chromium.org
  • 11 edits in trunk

Source/WebCore: Web Inspector: Remove isSnippet field from FileDescriptor and UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=109045

Reviewed by Pavel Feldman.

Snippets are now distinguished based on uiSourceCode project.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._supportsEnabledBreakpointsWhileEditing):

  • inspector/front-end/NavigatorView.js:
  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype._navigatorViewForUISourceCode):
(WebInspector.ScriptsNavigator.prototype.addUISourceCode):
(WebInspector.ScriptsNavigator.prototype.removeUISourceCode):
(WebInspector.ScriptsNavigator.prototype.revealUISourceCode):
(WebInspector.ScriptsNavigator.prototype.rename):
(WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._showFile):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):

  • inspector/front-end/SimpleWorkspaceProvider.js:

(WebInspector.SimpleWorkspaceProvider.prototype.addFile):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileForURL):

  • inspector/front-end/Workspace.js:

(WebInspector.FileDescriptor):
(WebInspector.Project.prototype._fileAdded):

LayoutTests: Web Inspector: Remove isSnippet field from FileDescriptor and UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=109045

Reviewed by Pavel Feldman.

  • inspector/debugger/scripts-file-selector.html:
  • inspector/debugger/scripts-sorting.html:
7:50 AM Changeset in webkit [141999] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r141983.
http://trac.webkit.org/changeset/141983
https://bugs.webkit.org/show_bug.cgi?id=109055

lots of new crashes in handlescope (Requested by gavinp on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-06

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::setWrapperInObject):

  • bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolated):

  • bindings/v8/V8Binding.h:

(WebCore):
(WebCore::worldForEnteredContextIfIsolated):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):

  • bindings/v8/V8GCController.cpp:

(WebCore::WrapperVisitor::WrapperVisitor):
(WebCore):
(WebCore::gcTree):
(WebCore::V8GCController::didCreateWrapperForNode):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):

  • bindings/v8/V8GCController.h:

(V8GCController):

6:43 AM Changeset in webkit [141998] by commit-queue@webkit.org
  • 31 edits
    3 deletes in trunk/Tools

Unreviewed, rolling out r141991.
http://trac.webkit.org/changeset/141991
https://bugs.webkit.org/show_bug.cgi?id=109047

Fails to compile on all Chromium platforms (Requested by
schenney on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-06

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTask.h:

(WebTaskList):

  • DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
  • DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebTestInterfaces):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestProxyBase):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:

(AccessibilityUIElementList):

  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:

(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):

  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:

(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):

  • DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:

(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):

  • DumpRenderTree/chromium/TestRunner/src/CppVariant.h:

(CppVariant):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):

  • DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:

(WebTestRunner::NativeKeyCodeForWindowsKeyCode):

  • DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:

(MockGrammarCheck::checkGrammarOfString):

  • DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:

(MockGrammarCheck):

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:

(append):
(isNotASCIIAlpha):
(MockSpellCheck::spellCheckWord):
(MockSpellCheck::initializeIfNeeded):

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:

(MockSpellCheck):

  • DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:

(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):

  • DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:

(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:

(TestPlugin):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner):
(WebTestRunner::TestRunner::setBackingScaleFactor):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:

(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):

  • DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):

  • DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:

(WebTestRunner):
(WebTestRunner::WebTaskList::WebTaskList):
(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):

  • DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
6:43 AM Changeset in webkit [141997] by schenney@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Add Skia code suppression flags to WebKit skia.gyp

Unreviewed.

This is step one in removing these flags. First we get them into
WebKit, then we can remove them from Chrome.

  • skia_webkit.gyp:
6:32 AM Changeset in webkit [141996] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Unreviewed, rolling out r141995.
http://trac.webkit.org/changeset/141995
https://bugs.webkit.org/show_bug.cgi?id=109046

May allow me to roll out the real problem (Requested by
schenney on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-06

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::sendWebIntentResponse):
(WebTestRunner::TestRunner::deliverWebIntent):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):

6:06 AM Changeset in webkit [141995] by jochen@chromium.org
  • 3 edits in trunk/Tools

[chromium] fix android build which doesn't support intents

Unreviewed build fix.

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::sendWebIntentResponse):
(WebTestRunner::TestRunner::deliverWebIntent):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):

5:37 AM Changeset in webkit [141994] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[WK2] New tests introduced in r100895 fail
https://bugs.webkit.org/show_bug.cgi?id=73913

Patch by Marja Hölttä <marja@chromium.org> on 2013-02-06
Reviewed by Jochen Eisinger.

The tests now work, because WTR supports HTTPS tests.

  • platform/wk2/TestExpectations:
5:32 AM Changeset in webkit [141993] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing WebGl test.

  • platform/qt/TestExpectations:
5:29 AM Changeset in webkit [141992] by loislo@chromium.org
  • 5 edits in trunk/Source

Web Inspector: Native Memory Instrumentation: assign class name to the heap graph node automatically
https://bugs.webkit.org/show_bug.cgi?id=107262

Reviewed by Yury Semikhatsky.

Source/JavaScriptCore:

Source/WTF:

We need a way to calculate class name for a pointer automatically.
Otherwise we need to write className manually in all the instrumentation methods.
And for all reported but not instrumented classes.

C++ can do that for us with help of typeid but unfortunatelly it requires rtti.
There is another way to do that. C++ preprocessor provides a define which has a function name.

For g++ and clang it is PRETTY_FUNCTION.
For MSVC it is FUNCTION.
The content of the string is a function signature.
We can use it because it has the name of the template argument.
The format is sligthly different. That's why I made two different parsers.
One for MSVC the other for GCC, Clang etc.
The other problem is the resulting binary size.
I made very simple function that does the only thing, returns the smallest possible function signature.
Unfortunatelly MSVC doesn't generate template argument name for functions.
It does this only for classes.

  • wtf/MemoryInstrumentation.cpp:

(WTF):
(WTF::className):
(WTF::MemoryClassInfo::callReportObjectInfo):
(WTF::MemoryClassInfo::init):

  • wtf/MemoryInstrumentation.h:

(WTF):
(WTF::FN::fn):
(WTF::fn):
(WTF::MemoryClassInfo::MemoryClassInfo):
(MemoryClassInfo):
(WTF::::reportObjectMemoryUsage):

5:11 AM Changeset in webkit [141991] by jochen@chromium.org
  • 31 edits
    3 copies in trunk/Tools

[chromium] turn TestRunner library into a component build
https://bugs.webkit.org/show_bug.cgi?id=108466

Reviewed by Adam Barth.

To achieve this, we need to drop all dependencies on WTF.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTask.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
  • DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:

(AccessibilityUIElementList):

  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:

(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):

  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:

(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):

  • DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:

(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):

  • DumpRenderTree/chromium/TestRunner/src/CppVariant.h:

(CppVariant):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):

  • DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:

(WebTestRunner::NativeKeyCodeForWindowsKeyCode):

  • DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:

(WebTestRunner::MockGrammarCheck::checkGrammarOfString):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:

(WebTestRunner):
(MockGrammarCheck):

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:

(WebTestRunner::MockSpellCheck::spellCheckWord):
(WebTestRunner::MockSpellCheck::initializeIfNeeded):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:

(MockSpellCheck):

  • DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:

(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):

  • DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.

(isASCIIAlpha):
(isNotASCIIAlpha):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:

(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:

(TestPlugin):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner::TestRunner::deliverWebIntent):
(WebTestRunner::TestRunner::setBackingScaleFactor):
(WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
(WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
(WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
(WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:

(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):

  • DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):

  • DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:

(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):

  • DumpRenderTree/chromium/TestRunner/src/config.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
5:09 AM Changeset in webkit [141990] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Optimize GlyphPage for case where all glyphs are available in the same font.
<http://webkit.org/b/108835>
<rdar://problem/13157042>

Reviewed by Antti Koivisto.

Let GlyphPage begin optimistically assuming that all its glyphs will be represented in
the same SimpleFontData*. In this (very common) case, only keep a single SimpleFontData*.

If glyphs from multiple fonts are mixed in one page, an array of per-glyph SimpleFontData*
is allocated transparently.

4.98 MB progression on Membuster3.

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::initializePage):

  • platform/graphics/GlyphPage.h:

(WebCore::GlyphPage::createUninitialized):
(WebCore::GlyphPage::createZeroedSystemFallbackPage):
(WebCore::GlyphPage::createCopiedSystemFallbackPage):

There are now three ways of constructing a GlyphPage, two of them are only used for
creating system fallback pages.

(WebCore::GlyphPage::setGlyphDataForIndex):

Hold off creating a SimpleFontData* array until we're sure there are two different
SimpleFontData* backing the glyphs in this page.
We don't store font data for glyph #0, instead we let the getters always return null for it.

(WebCore::GlyphPage::~GlyphPage):

Free the SimpleFontData* array if needed.

(WebCore::GlyphPage::glyphDataForCharacter):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::fontDataForCharacter):

The font data for glyph #0 is always a null pointer now.

(WebCore::GlyphPage::clearForFontData):

Updated for new storage format.

  • rendering/svg/SVGTextRunRenderingContext.cpp:

(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):

Fix bug where non-zero glyph was temporarily associated with null font data,
which triggered the new assertion in setGlyphDataForIndex().

5:04 AM Changeset in webkit [141989] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Follow up to r141979: do not consume Home/End.
Not reviewed.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.FilteredItemSelectionDialog.prototype._onKeyDown):

5:03 AM Changeset in webkit [141988] by vsevik@chromium.org
  • 7 edits in trunk

Web Inspector: Remove show script folders setting
https://bugs.webkit.org/show_bug.cgi?id=108940

Reviewed by Pavel Feldman.

Source/WebCore:

Removed showScriptFolders setting, the sources are never shown as a flat list in navigator anymore.

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView):
(WebInspector.NavigatorView.prototype._getOrCreateFolderTreeElement):

  • inspector/front-end/Settings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.GenericSettingsTab):

LayoutTests:

  • inspector/debugger/scripts-sorting-expected.txt:
  • inspector/debugger/scripts-sorting.html:
4:36 AM Changeset in webkit [141987] by commit-queue@webkit.org
  • 11 edits in trunk

Web Inspector: update javascriptsourcetokenizer to produce "whitespaces" token
https://bugs.webkit.org/show_bug.cgi?id=108945

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-06
Reviewed by Pavel Feldman.

Source/WebCore:

Update re2c grammar for SourceJavaScriptTokenizer to produce
"whitespace" token which holds consequtive whitespaces in it.

Updated existing tests expectations.

  • inspector/front-end/DOMSyntaxHighlighter.js:

(WebInspector.DOMSyntaxHighlighter.prototype.createSpan): Do not strip spaces from tokens with class "whitespaces".

  • inspector/front-end/SourceJavaScriptTokenizer.js: Regenerated.

(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):

  • inspector/front-end/SourceJavaScriptTokenizer.re2js:

LayoutTests:

Update test expectations so that they have "whitespace" token in
there.

  • inspector/editor/highlighter-basics-expected.txt:
  • inspector/editor/highlighter-chunk-limit-expected.txt:
  • inspector/editor/highlighter-long-line.html:
  • inspector/editor/text-editor-long-line-expected.txt:
  • inspector/syntax-highlight-html-expected.txt:
  • inspector/syntax-highlight-javascript-expected.txt:
4:27 AM Changeset in webkit [141986] by commit-queue@webkit.org
  • 4 edits in trunk

Web Inspector: refactor registerShortcuts method of DTE
https://bugs.webkit.org/show_bug.cgi?id=109031

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-06
Reviewed by Pavel Feldman.

Source/WebCore:

Implement _registerShortcuts method in TextEditorMainPanel which will
bind its private methods to the different key combinations. Refactor
method handlers handleUndoRedo, handleTabKeyPress and handleEnterKey
from public to private.

No new tests: no change in behaviour.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype._registerShortcuts): Remove bindings of TextEditorMainPanel methods
(WebInspector.DefaultTextEditor.prototype._handleKeyDown):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._registerShortcuts): Added.
(WebInspector.TextEditorMainPanel.prototype._handleUndoRedo):
(WebInspector.TextEditorMainPanel.prototype.handleKeyDown):

LayoutTests:

Fix helper method to correspond to refactoring of handleUndoRedo
method.

  • http/tests/inspector/live-edit-test.js:

(initialize_LiveEditTest.InspectorTest.undoSourceEditing):
(initialize_LiveEditTest):

4:07 AM Changeset in webkit [141985] by mkwst@chromium.org
  • 19 edits in trunk

Add an ENABLE_NOSNIFF feature flag.
https://bugs.webkit.org/show_bug.cgi?id=109029

Reviewed by Jochen Eisinger.

This new flag will control the behavior of 'X-Content-Type-Options: nosniff'
when processing script and other resource types.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
3:57 AM Changeset in webkit [141984] by tommyw@google.com
  • 23 edits
    16 adds in trunk

MediaStream API: Implement DTMF support in RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=106782

Reviewed by Adam Barth.

Source/Platform:

The WebRTC specification have added support for DTMF:
http://dev.w3.org/2011/webrtc/editor/webrtc.html#peer-to-peer-dtmf

Implementation wise this is implemented using the same pattern as RTCDataChannel;
where a RTCDTMFSenderHandler is created by the UA through a new method on
RTCPeerConnectionHandler.

  • Platform.gypi:
  • chromium/public/WebMediaStreamTrack.h:

(WebMediaStreamTrack):

  • chromium/public/WebRTCDTMFSenderHandler.h: Copied from Source/Platform/chromium/public/WebMediaStreamTrack.h.

(WebKit):
(WebRTCDTMFSenderHandler):
(WebKit::WebRTCDTMFSenderHandler::~WebRTCDTMFSenderHandler):

  • chromium/public/WebRTCDTMFSenderHandlerClient.h: Copied from Source/Platform/chromium/public/WebMediaStreamTrack.h.

(WebKit):
(WebRTCDTMFSenderHandlerClient):
(WebKit::WebRTCDTMFSenderHandlerClient::~WebRTCDTMFSenderHandlerClient):

  • chromium/public/WebRTCPeerConnectionHandler.h:

(WebKit):
(WebKit::WebRTCPeerConnectionHandler::createDTMFSender):

Source/WebCore:

The WebRTC specification have added support for DTMF:
http://dev.w3.org/2011/webrtc/editor/webrtc.html#peer-to-peer-dtmf

Implementation wise this is implemented using the same pattern as RTCDataChannel;
where a RTCDTMFSenderHandler is created by the UA through a new method on
RTCPeerConnectionHandler.

Test: fast/mediastream/RTCPeerConnection-dtmf.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCDTMFSender.cpp: Added.

(WebCore):
(WebCore::RTCDTMFSender::create):
(WebCore::RTCDTMFSender::RTCDTMFSender):
(WebCore::RTCDTMFSender::~RTCDTMFSender):
(WebCore::RTCDTMFSender::canInsertDTMF):
(WebCore::RTCDTMFSender::track):
(WebCore::RTCDTMFSender::toneBuffer):
(WebCore::RTCDTMFSender::insertDTMF):
(WebCore::RTCDTMFSender::didPlayTone):
(WebCore::RTCDTMFSender::interfaceName):
(WebCore::RTCDTMFSender::scriptExecutionContext):
(WebCore::RTCDTMFSender::stop):
(WebCore::RTCDTMFSender::eventTargetData):
(WebCore::RTCDTMFSender::ensureEventTargetData):
(WebCore::RTCDTMFSender::scheduleDispatchEvent):
(WebCore::RTCDTMFSender::scheduledEventTimerFired):

  • Modules/mediastream/RTCDTMFSender.h: Added.

(WebCore):
(RTCDTMFSender):
(WebCore::RTCDTMFSender::duration):
(WebCore::RTCDTMFSender::interToneGap):

  • Modules/mediastream/RTCDTMFSender.idl: Added.
  • Modules/mediastream/RTCDTMFToneChangeEvent.cpp: Copied from Source/Platform/chromium/public/WebMediaStreamTrack.h.

(WebCore):
(WebCore::RTCDTMFToneChangeEvent::create):
(WebCore::RTCDTMFToneChangeEvent::RTCDTMFToneChangeEvent):
(WebCore::RTCDTMFToneChangeEvent::~RTCDTMFToneChangeEvent):
(WebCore::RTCDTMFToneChangeEvent::tone):
(WebCore::RTCDTMFToneChangeEvent::interfaceName):

  • Modules/mediastream/RTCDTMFToneChangeEvent.h: Copied from Source/Platform/chromium/public/WebMediaStreamTrack.h.

(WebCore):
(RTCDTMFToneChangeEventInit):
(RTCDTMFToneChangeEvent):

  • Modules/mediastream/RTCDTMFToneChangeEvent.idl: Added.
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::createDataChannel):
(WebCore):
(WebCore::RTCPeerConnection::getStreamByTrackId):
(WebCore::RTCPeerConnection::createDTMFSender):

  • Modules/mediastream/RTCPeerConnection.h:

(WebCore):
(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • WebCore.gypi:
  • dom/EventNames.h:

(WebCore):

  • dom/EventNames.in:
  • dom/EventTargetFactory.in:
  • platform/chromium/support/WebMediaStreamTrack.cpp:

(WebKit::WebMediaStreamTrack::WebMediaStreamTrack):
(WebKit):

  • platform/mediastream/RTCDTMFSenderHandler.h: Copied from Source/Platform/chromium/public/WebMediaStreamTrack.h.

(WebCore):
(RTCDTMFSenderHandler):
(WebCore::RTCDTMFSenderHandler::~RTCDTMFSenderHandler):

  • platform/mediastream/RTCDTMFSenderHandlerClient.h: Copied from Source/Platform/chromium/public/WebMediaStreamTrack.h.

(WebCore):
(RTCDTMFSenderHandlerClient):
(WebCore::RTCDTMFSenderHandlerClient::~RTCDTMFSenderHandlerClient):

  • platform/mediastream/RTCPeerConnectionHandler.h:

(WebCore):
(RTCPeerConnectionHandler):

  • platform/mediastream/chromium/RTCDTMFSenderHandlerChromium.cpp: Copied from Source/Platform/chromium/public/WebMediaStreamTrack.h.

(WebCore):
(WebCore::RTCDTMFSenderHandlerChromium::create):
(WebCore::RTCDTMFSenderHandlerChromium::RTCDTMFSenderHandlerChromium):
(WebCore::RTCDTMFSenderHandlerChromium::~RTCDTMFSenderHandlerChromium):
(WebCore::RTCDTMFSenderHandlerChromium::setClient):
(WebCore::RTCDTMFSenderHandlerChromium::currentToneBuffer):
(WebCore::RTCDTMFSenderHandlerChromium::canInsertDTMF):
(WebCore::RTCDTMFSenderHandlerChromium::insertDTMF):
(WebCore::RTCDTMFSenderHandlerChromium::didPlayTone):

  • platform/mediastream/chromium/RTCDTMFSenderHandlerChromium.h: Copied from Source/Platform/chromium/public/WebMediaStreamTrack.h.

(WebCore):
(RTCDTMFSenderHandlerChromium):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:

(WebCore::RTCPeerConnectionHandlerChromium::createDTMFSender):
(WebCore):

  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:

(RTCPeerConnectionHandlerChromium):

Tools:

Adding Mock functionality for the DTMFSender.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.cpp: Added.

(DTMFSenderToneTask):
(DTMFSenderToneTask::DTMFSenderToneTask):
(MockWebRTCDTMFSenderHandler::MockWebRTCDTMFSenderHandler):
(MockWebRTCDTMFSenderHandler::setClient):
(MockWebRTCDTMFSenderHandler::currentToneBuffer):
(MockWebRTCDTMFSenderHandler::canInsertDTMF):
(MockWebRTCDTMFSenderHandler::insertDTMF):

  • DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.h: Copied from Source/Platform/chromium/public/WebMediaStreamTrack.h.

(MockWebRTCDTMFSenderHandler):
(MockWebRTCDTMFSenderHandler::taskList):
(MockWebRTCDTMFSenderHandler::clearToneBuffer):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::createDTMFSender):

  • DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:

(MockWebRTCPeerConnectionHandler):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-dtmf-expected.txt: Added.
  • fast/mediastream/RTCPeerConnection-dtmf.html: Added.
3:48 AM QtWebKitGardening edited by Csaba Osztrogonác
(diff)
3:40 AM Changeset in webkit [141983] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

[V8] Remove V8GCController::m_edenNodes and make minor DOM GC more precise
https://bugs.webkit.org/show_bug.cgi?id=108579

Reviewed by Adam Barth.

Currently V8GCController::m_edenNodes stores a list of nodes whose
wrappers have been created since the latest GC. The reason why we
needed m_edenNodes is that there was no way to know a list of wrappers
in the new space of V8. By using m_edenNodes, we had been approximating
'wrappers in the new space' by 'wrappers that have been created since
the latest GC'.

Now V8 provides VisitHandlesForPartialDependence(), with which WebKit
can know a list of wrappers in the new space. By using the API, we can
remove V8GCController::m_edenNodes. The benefit is that (1) we no longer
need to keep m_edenNodes and that (2) it enables more precise minor
DOM GC (Remember that m_edenNodes was just an approximation).

Performance benchmark: https://bugs.webkit.org/attachment.cgi?id=185940
The benchmark runs 300 iterations, each of which creates 100000 elements.
The benchmark measures average, min, median, max and stdev of execution times
of the 300 iterations. This will tell us the worst-case overhead of this change.

Before:

mean=59.91ms, min=39ms, median=42ms, max=258ms, stdev=47.48ms

After:

mean=58.75ms, min=35ms, median=41ms, max=250ms, stdev=47.32ms

As shown above, I couldn't observe any performance regression.

No tests. No change in behavior.

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::setWrapperInObject):

  • bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::getWorldWithoutContextCheck):

  • bindings/v8/V8Binding.h:

(WebCore):
(WebCore::worldForEnteredContextIfIsolated):
(WebCore::worldForEnteredContextWithoutContextCheck):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):

  • bindings/v8/V8GCController.cpp:

(WebCore::gcTree):
(WebCore):
(MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::notifyFinished):
(WebCore::MajorGCWrapperVisitor::MajorGCWrapperVisitor):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):

  • bindings/v8/V8GCController.h:

(V8GCController):

3:32 AM Changeset in webkit [141982] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk
[CSSRegions] Assertion failure in Node::detach (!renderer
renderer->inRenderFlowThread())

https://bugs.webkit.org/show_bug.cgi?id=104517

Patch by Mihai Maerean <Mihai Maerean> on 2013-02-06
Reviewed by Julien Chaffraix.

Source/WebCore:

The RenderObject::inRenderFlowThread bit could have become disconnected from the fact that the RenderObject
has (or not) an enclosing RenderFlowThread.
The cause of this was that, when setting or removing the parent of a RenderObject, the inRenderFlowThread flags
wasn't being set/reset for the children too.
This is now fixed by calling the new setInRenderFlowThreadIncludingDescendants.

The ASSERT was hit for anonymous blocks when detaching the document.

Test: fast/regions/detaching-regions-with-anonymous-blocks.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::setInRenderFlowThreadRecursive):
(WebCore):

  • rendering/RenderObject.h:

(WebCore::RenderObject::setParent):
(RenderObject):

LayoutTests:

The test adds an anonymous block in a region and detaches the body of document. The ASSERT is not hit anymore.

  • fast/regions/detaching-regions-with-anonymous-blocks-expected.txt: Added.
  • fast/regions/detaching-regions-with-anonymous-blocks.html: Added.
3:24 AM Changeset in webkit [141981] by commit-queue@webkit.org
  • 35 edits in trunk

Take referrer policy into account when clearing the referrer header
https://bugs.webkit.org/show_bug.cgi?id=86000

Patch by Marja Hölttä <marja@chromium.org> on 2013-02-06
Reviewed by Alexey Proskuryakov.

Source/WebCore:

The referrer should only be cleared when doing a https -> http redirect,
if the policy is "default". Otherwise the referrer should be left intact.

In order to do that, added a function for checking the policy in
NetworkingContext, and stored the NetworkingContext in ResourceHandle
(like some ports already did).

No new tests (unskipped old tests).

  • loader/FrameNetworkingContext.h:

(WebCore::FrameNetworkingContext::shouldClearReferrerOnHTTPSToHTTPRedirect):
(FrameNetworkingContext):

  • platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::BlobResourceHandle):

  • platform/network/NetworkingContext.h:

(NetworkingContext):

  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::ResourceHandle):
(WebCore::ResourceHandle::create):
(WebCore::ResourceHandle::context):
(WebCore):

  • platform/network/ResourceHandle.h:

(ResourceHandle):

  • platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(ResourceHandleInternal):

  • platform/network/blackberry/ResourceHandleBlackBerry.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willSendRequest):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

  • platform/network/chromium/ResourceHandle.cpp:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(WebCore::ResourceHandle::ResourceHandle):
(WebCore::ResourceHandle::create):
(WebCore::ResourceHandle::context):
(WebCore):
(WebCore::ResourceHandle::start):

  • platform/network/chromium/ResourceHandleInternal.h:

(WebCore):
(ResourceHandleInternal):
(WebCore::ResourceHandleInternal::context):

  • platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
(-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):

  • platform/network/qt/QNetworkReplyHandler.cpp:

(WebCore::QNetworkReplyHandler::redirect):

  • platform/network/qt/ResourceHandleQt.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::doRedirect):
(WebCore::ResourceHandle::start):

  • platform/network/win/ResourceHandleWin.cpp:

(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):

Source/WebKit2:

The referrer should only be cleared when doing a https -> http redirect,
if the policy is "default". Otherwise the referrer should be left intact.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::start):

  • NetworkProcess/SchedulableLoader.cpp:

(WebKit::SchedulableLoader::SchedulableLoader):

  • NetworkProcess/SchedulableLoader.h:

(WebKit::SchedulableLoader::shouldClearReferrerOnHTTPSToHTTPRedirect):
(SchedulableLoader):

  • NetworkProcess/SyncNetworkResourceLoader.cpp:

(WebKit::SyncNetworkResourceLoader::start):

  • NetworkProcess/mac/RemoteNetworkingContext.h:

(WebKit::RemoteNetworkingContext::create):
(RemoteNetworkingContext):

  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::shouldClearReferrerOnHTTPSToHTTPRedirect):
(WebKit):
(WebKit::RemoteNetworkingContext::RemoteNetworkingContext):

  • Shared/Network/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
(WebKit::NetworkResourceLoadParameters::encode):
(WebKit::NetworkResourceLoadParameters::decode):

  • Shared/Network/NetworkResourceLoadParameters.h:

(NetworkResourceLoadParameters):
(WebKit::NetworkResourceLoadParameters::shouldClearReferrerOnHTTPSToHTTPRedirect):

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::scheduleSubresourceLoad):
(WebKit::WebResourceLoadScheduler::schedulePluginStreamLoad):
(WebKit::WebResourceLoadScheduler::scheduleLoad):

  • WebProcess/Network/WebResourceLoadScheduler.h:

(WebResourceLoadScheduler):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::loadResourceSynchronously):

LayoutTests:

Unskip http/tests/security/referrer-policy-redirect-link.html

Skipping the tests on wk2, because other referrer policy tests are
skipped, too ( https://bugs.webkit.org/show_bug.cgi?id=73913 ).

  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wk2/TestExpectations:
2:27 AM Changeset in webkit [141980] by allan.jensen@digia.com
  • 2 edits
    11 deletes in trunk/LayoutTests

[Qt] Unskip working filter tests.

Unreviewed gardening

These tests work if we remove our failure expecting baselines.

  • platform/qt/TestExpectations:
  • platform/qt/css3/filters/filter-animation-expected.png: Removed.
  • platform/qt/css3/filters/filter-animation-expected.txt: Removed.
  • platform/qt/css3/filters/filter-animation-from-none-expected.png: Removed.
  • platform/qt/css3/filters/filter-animation-from-none-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-computed-style-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-expected.png: Removed.
  • platform/qt/css3/filters/filter-property-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-parsing-expected.txt: Removed.
  • platform/qt/css3/filters/filter-property-parsing-invalid-expected.txt: Removed.
  • platform/qt/css3/filters/filter-repaint-expected.png: Removed.
  • platform/qt/css3/filters/filter-repaint-expected.txt: Removed.
2:11 AM Changeset in webkit [141979] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: file selector list jumps as I type or move Up/Down
https://bugs.webkit.org/show_bug.cgi?id=108933

Reviewed by Vsevolod Vlasov.

Missing return was scheduling extra updates.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.FilteredItemSelectionDialog):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
(WebInspector.FilteredItemSelectionDialog.prototype._onKeyDown):
(WebInspector.FilteredItemSelectionDialog.prototype._updateSelection):

1:54 AM Changeset in webkit [141978] by mikhail.pozdnyakov@intel.com
  • 13 edits
    1 delete in trunk/Source/WebKit2

[EFL][WK2] Encapsulate Ewk View evas smart object code inside EwkView class
https://bugs.webkit.org/show_bug.cgi?id=108062

Reviewed by Kenneth Rohde Christiansen.

The Ewk View implementation is encapsulated within EwkView class.
Besides multiple refactoring of Ewk View evas smart object code was made.

  • UIProcess/API/C/efl/WKView.cpp:

(createWKView):

Aux function to share WKView creation implementation.

  • UIProcess/API/efl/EwkView.cpp:

(smartDataChanged):
(defaultSmartClassInstance):
(toSmartData):
(EwkView::initSmartClassInterface):
(EwkView::toEvasObject):
(EwkView::smartData):

Renamed and moved here from ewk_view.

(EwkViewEventHandler):
(EwkViewEventHandler::subscribe):
(EwkViewEventHandler::unsubscribe):
(::handleEvent):

Added a new template class to encapsulate Ewk View Evas events handling.

(EwkView::EwkView):
(EwkView::~EwkView):

Constructor and desctructor are private.

(EwkView::createEvasObject):

Added factory function for ewk view evas objects creation.

(EwkView::handleEvasObjectAdd):
(EwkView::handleEvasObjectDelete):
(EwkView::handleEvasObjectResize):
(EwkView::handleEvasObjectMove):
(EwkView::handleEvasObjectCalculate):
(EwkView::handleEvasObjectShow):
(EwkView::handleEvasObjectHide):
(EwkView::handleEvasObjectColorSet):

Evas_Smart_Class interface callbacks moved into the EwkView class.

(EwkView::handleEwkViewFocusIn):
(EwkView::handleEwkViewFocusOut):
(EwkView::handleEwkViewMouseWheel):
(EwkView::handleEwkViewMouseDown):
(EwkView::handleEwkViewMouseUp):
(EwkView::handleEwkViewMouseMove):
(EwkView::handleEwkViewKeyDown):
(EwkView::handleEwkViewKeyUp):

Ewk_View_Smart_Class interface callback moved into the EwkView class.

(EwkView::handleTouchDown):
(EwkView::handleTouchUp):
(EwkView::handleTouchMove):

Renamed.

(toEwkView):

Aux function to get the EwkView instance fromevas object.

(isViewEvasObject):

Aux function to check that given evas object is ewk view.

  • UIProcess/API/efl/EwkView.h:

(EwkView::evasObject):
(EwkView):

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_smart_class_set):
(ewk_view_smart_add):
(ewk_view_add_with_context):
(ewk_view_feed_touch_event):
(Ewk_Page_Contents_Context):

  • UIProcess/API/efl/ewk_view_private.h: Removed.
  • UIProcess/API/C/efl/WKView.cpp:

(WKViewCreate):
(WKViewCreateWithFixedLayout):
(WKViewCreateSnapshot):

  • UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::incorporateUpdate):

  • UIProcess/efl/ContextHistoryClientEfl.cpp:

(WebKit::ContextHistoryClientEfl::didNavigateWithNavigationData):
(WebKit::ContextHistoryClientEfl::didPerformClientRedirect):
(WebKit::ContextHistoryClientEfl::didPerformServerRedirect):
(WebKit::ContextHistoryClientEfl::didUpdateHistoryTitle):

  • UIProcess/efl/PageClientBase.cpp:

(WebKit::PageClientBase::processDidCrash):

  • UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didChangeBackForwardList):

  • UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::takeFocus):
(WebKit::PageUIClientEfl::focus):
(WebKit::PageUIClientEfl::unfocus):

  • UIProcess/efl/WebFullScreenManagerProxyEfl.cpp:

(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):

  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::viewWidget):

Updated due to changes in EwkView interface.

12:58 AM Performance Tests edited by rakuco@webkit.org
Small typo fix. (diff)
12:55 AM Changeset in webkit [141977] by haraken@chromium.org
  • 19 edits in trunk/Source/WebCore

[V8] Pass an Isolate to remaining GetTemplate()s
https://bugs.webkit.org/show_bug.cgi?id=109001

Reviewed by Adam Barth.

No tests. No change in behavior.

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedSecurityCheck): Because this method is a callback from V8,
we cannot change its signature to receive an Isolate.
(WebCore::V8DOMWindow::indexedSecurityCheck): Ditto.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateToV8Converters):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::createWrapper):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::createWrapper):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::createWrapper):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::createWrapper):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::createWrapper):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::createWrapper):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::createWrapper):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::createWrapper):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::createWrapper):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::createWrapper):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::createWrapper):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::createWrapper):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::createWrapper):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::createWrapper):

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::wrapInShadowObject):

12:30 AM EFLWebKitBuildBots edited by Christophe Dumez
Update my email information. (diff)
12:27 AM Changeset in webkit [141976] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r141961.
http://trac.webkit.org/changeset/141961
https://bugs.webkit.org/show_bug.cgi?id=109019

assertion failures on svn tests such as fonts-glyph-04-t.svg
(Requested by falken on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-06

  • platform/graphics/GlyphPage.h:

(WebCore::GlyphPage::create):
(WebCore::GlyphPage::glyphDataForCharacter):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::fontDataForCharacter):
(WebCore::GlyphPage::setGlyphDataForIndex):
(GlyphPage):
(WebCore::GlyphPage::copyFrom):
(WebCore::GlyphPage::clear):
(WebCore::GlyphPage::clearForFontData):
(WebCore::GlyphPage::GlyphPage):

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::initializePage):

12:23 AM Changeset in webkit [141975] by Christophe Dumez
  • 2 edits in trunk/Tools

Unreviewed. Update my email address in committers.py.

  • Scripts/webkitpy/common/config/committers.py:
12:04 AM Changeset in webkit [141974] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Skipping the newly-added tests in webgl/, the GTK builders are not
yet able to run these tests.

  • platform/gtk/TestExpectations:
12:00 AM Changeset in webkit [141973] by commit-queue@webkit.org
  • 10 edits
    2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r141964.
http://trac.webkit.org/changeset/141964
https://bugs.webkit.org/show_bug.cgi?id=109014

caused performance regression (Requested by hayato on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-05

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/DocumentRuleSets.cpp: Removed.
  • css/DocumentRuleSets.h: Removed.
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectRulesFromUserStyleSheets):
(WebCore):
(WebCore::makeRuleSet):
(WebCore::StyleResolver::resetAuthorStyle):
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::classNamesAffectedByRules):
(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::checkRegionStyle):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::reportMemoryUsage):

  • css/StyleResolver.h:

(StyleResolver):
(WebCore::StyleResolver::usesSiblingRules):
(WebCore::StyleResolver::usesFirstLineRules):
(WebCore::StyleResolver::usesBeforeAfterRules):
(WebCore::StyleResolver::hasSelectorForAttribute):
(WebCore::StyleResolver::hasSelectorForClass):
(WebCore::StyleResolver::hasSelectorForId):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

Feb 5, 2013:

11:44 PM Changeset in webkit [141972] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Add #if USE(V8) to Node::V8CollectableDuringMinorGCFlag
https://bugs.webkit.org/show_bug.cgi?id=109009

Reviewed by Kent Tamura.

Node flags should be saved. V8CollectableDuringMinorGCFlag is used by V8 only.

  • dom/Node.h:

(Node):

11:41 PM Changeset in webkit [141971] by Gregg Tavares
  • 2 edits
    24 adds in trunk/LayoutTests

Adds the WebGL Conformance Tests attrib folder.
https://bugs.webkit.org/show_bug.cgi?id=108901

Reviewed by Kenneth Russell.

  • platform/chromium/TestExpectations:
  • webgl/conformance/attribs/gl-disabled-vertex-attrib-expected.txt: Added.
  • webgl/conformance/attribs/gl-disabled-vertex-attrib.html: Added.
  • webgl/conformance/attribs/gl-enable-vertex-attrib-expected.txt: Added.
  • webgl/conformance/attribs/gl-enable-vertex-attrib.html: Added.
  • webgl/conformance/attribs/gl-vertex-attrib-expected.txt: Added.
  • webgl/conformance/attribs/gl-vertex-attrib-render-expected.txt: Added.
  • webgl/conformance/attribs/gl-vertex-attrib-render.html: Added.
  • webgl/conformance/attribs/gl-vertex-attrib-zero-issues-expected.txt: Added.
  • webgl/conformance/attribs/gl-vertex-attrib-zero-issues.html: Added.
  • webgl/conformance/attribs/gl-vertex-attrib.html: Added.
  • webgl/conformance/attribs/gl-vertexattribpointer-expected.txt: Added.
  • webgl/conformance/attribs/gl-vertexattribpointer-offsets-expected.txt: Added.
  • webgl/conformance/attribs/gl-vertexattribpointer-offsets.html: Added.
  • webgl/conformance/attribs/gl-vertexattribpointer.html: Added.
  • webgl/resources/webgl_test_files/conformance/attribs/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/attribs/gl-disabled-vertex-attrib.html: Added.
  • webgl/resources/webgl_test_files/conformance/attribs/gl-enable-vertex-attrib.html: Added.
  • webgl/resources/webgl_test_files/conformance/attribs/gl-vertex-attrib-render.html: Added.
  • webgl/resources/webgl_test_files/conformance/attribs/gl-vertex-attrib-zero-issues.html: Added.
  • webgl/resources/webgl_test_files/conformance/attribs/gl-vertex-attrib.html: Added.
  • webgl/resources/webgl_test_files/conformance/attribs/gl-vertexattribpointer-offsets.html: Added.
  • webgl/resources/webgl_test_files/conformance/attribs/gl-vertexattribpointer.html: Added.
11:07 PM Changeset in webkit [141970] by falken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Rebaseline navigator-detached-no-crash.html,
whose output is affected by the disabling of web intents in Chromium.

  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
10:09 PM Changeset in webkit [141969] by falken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Chromium disabled web intents.

  • platform/chromium/TestExpectations:
9:49 PM Changeset in webkit [141968] by tkent@chromium.org
  • 2 edits
    3 adds
    1 delete in trunk/LayoutTests

[Chromium] Split calendar-picker-key-operations.html into two
https://bugs.webkit.org/show_bug.cgi?id=109006

Reviewed by Kentaro Hara.

Split calendar-picker-key-operations.html into two parts:

  • OS-independent part (calendar-picker-key-operations.html), and
  • OS-dependent part (calendar-picker-f4-key.html).

We had some troubles when we updated calendar-picker-key-operations.html
because the behavior by F4 key is OS-dependent. We move the test for F4
key to new test.

  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-f4-key-expected.txt:

Added. It is expected that this contains FAIL line because we don't
support the F4 key behavior on OSX.

  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:

Removed. Now the result of calendar-picker-key-operations.html is OS-independent.

  • platform/chromium/fast/forms/calendar-picker/calendar-picker-f4-key-expected.txt: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-f4-key.html:

Added. Move from calendar-picker-key-operations.html.

  • platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:

Move the F4 key part to calendar-picker-f4-key.html.

9:16 PM Changeset in webkit [141967] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Add ending slashes automatically to file mappings.
https://bugs.webkit.org/show_bug.cgi?id=108936

Reviewed by Pavel Feldman.

  • inspector/front-end/SettingsScreen.js:

(WebInspector.WorkspaceSettingsTab.prototype._addFileMappingClicked):

9:12 PM Changeset in webkit [141966] by eric.carlson@apple.com
  • 10 edits in trunk/Source/WebCore

More updates to Caption user preferences
https://bugs.webkit.org/show_bug.cgi?id=108997

Reviewed by Dean Jackson.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::captionPreferencesChanged): Give the media controls a chance

to update for a preferences change.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateSizes): Add optional "force update"

param to force font size recalc even when the video size hasn't changed.

  • html/shadow/MediaControlElements.h:
  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::textTrackPreferencesChanged): New, force a font size recalc.

  • html/shadow/MediaControls.h:
  • html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties): Don't set width/size of cues

that use default positioning. Use "start" as the default alignment.

  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::captionsWindowCSS): Set padding when the window is visible

so it shows around the cue background.

(WebCore::CaptionUserPreferencesMac::captionsBackgroundCSS): Set padding to 0 when the background

is visible.

(WebCore::CaptionUserPreferencesMac::windowRoundedCornerRadiusCSS): Add "px" to the border radius

so it actually works.

  • rendering/RenderTextTrackCue.cpp:

(WebCore::RenderTextTrackCue::layout): Special case generic cues with default style.
(WebCore::RenderTextTrackCue::repositionGenericCue):

  • rendering/RenderTextTrackCue.h:
8:30 PM Changeset in webkit [141965] by mark.lam@apple.com
  • 2 edits in trunk/Source/WTF

Fix EnumClass so that it can be used with switch statements.
https://bugs.webkit.org/show_bug.cgi?id=109004.

Reviewed by Sam Weinig.

  • wtf/EnumClass.h:

(WTF::EnumClass::operator==):
(WTF::EnumClass::operator!=):
(WTF::EnumClass::operator<):
(WTF::EnumClass::operator<=):
(WTF::EnumClass::operator>):
(WTF::EnumClass::operator>=):
(EnumClass):
(WTF::EnumClass::operator Value):

8:28 PM Changeset in webkit [141964] by hayato@chromium.org
  • 10 edits
    2 adds in trunk/Source/WebCore

Split each RuleSet and feature out from StyleResolver into its own class.
https://bugs.webkit.org/show_bug.cgi?id=107777

Reviewed by Dimitri Glazkov.

Splitting each RuleSet and feature out from StyleResover into its onw class, DocumentRuleSets,
to manage them separately.

This is one of the attempts to try to resolve meta bug (bug 89879)
to lose StyleResolver's weight. We need further action to factor
StyleResolver to separate it into some classes cleanly.
See also https://bugs.webkit.org/show_bug.cgi?id=108890. A following patch will address that.

No tests. No change in behavior.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/DocumentRuleSets.cpp: Added.

(WebCore):
(WebCore::DocumentRuleSets::DocumentRuleSets):
(WebCore::DocumentRuleSets::~DocumentRuleSets):
(WebCore::DocumentRuleSets::initUserStyle): New helper to initialize each RuleSets.
(WebCore::DocumentRuleSets::collectRulesFromUserStyleSheets): Factored out from StyleResolver.
(WebCore::makeRuleSet): Ditto.
(WebCore::DocumentRuleSets::resetAuthorStyle): Ditto.
(WebCore::DocumentRuleSets::appendAuthorStyleSheets): Ditto.
(WebCore::DocumentRuleSets::collectFeatures): Ditto.
(WebCore::DocumentRuleSets::reportMemoryUsage): New methods to report memory usage. Factored out from StyleResolver.

  • css/DocumentRuleSets.h: Added.

(WebCore):
(DocumentRuleSets):
(WebCore::DocumentRuleSets::authorStyle): Moved from StyleResolver.
(WebCore::DocumentRuleSets::userStyle): Ditto.
(WebCore::DocumentRuleSets::features): Ditto.
(WebCore::DocumentRuleSets::sibling): Ditto.
(WebCore::DocumentRuleSets::uncommonAttribute): Ditto.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::appendAuthorStyleSheets): Now calls DocumentRuleSets::appendAuthorStyleSheets.
(WebCore::StyleResolver::matchAuthorRules): Use m_ruleSets.
(WebCore::StyleResolver::matchUserRules): Ditto.
(WebCore::StyleResolver::classNamesAffectedByRules): Ditto.
(WebCore::StyleResolver::locateCousinList): Ditto.
(WebCore::StyleResolver::canShareStyleWithElement): Ditto.
(WebCore::StyleResolver::locateSharedStyle): Ditto.
(WebCore::StyleResolver::styleForPage): Ditto.
(WebCore::StyleResolver::checkRegionStyle): Ditto.
(WebCore::StyleResolver::applyProperty): Ditto.
(WebCore::StyleResolver::reportMemoryUsage): Now calls DocumentRuleSets::reportMemoryUsage.

  • css/StyleResolver.h:

(WebCore::StyleResolver::scopeResolver):
(StyleResolver):
(WebCore::StyleResolver::ruleSets): accessor r to DocumentRuleSets.
(WebCore::StyleResolver::usesSiblingRules): Use m_ruleSets.
(WebCore::StyleResolver::usesFirstLineRules): Ditto.
(WebCore::StyleResolver::usesBeforeAfterRules): Ditto.
(WebCore::StyleResolver::hasSelectorForAttribute): Ditto.
(WebCore::StyleResolver::hasSelectorForClass): Ditto.
(WebCore::StyleResolver::hasSelectorForId): Ditto.

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

7:01 PM Changeset in webkit [141963] by jchaffraix@webkit.org
  • 5 edits
    2 adds in trunk

[CSS Grid Layout] Grid item's logical height is not properly recomputed after -webkit-grid-column / -webkit-grid-row changes
https://bugs.webkit.org/show_bug.cgi?id=108975

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-grid-layout/implicit-position-dynamic-change.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::clearContainingBlockOverrideSize):
(WebCore::RenderBox::clearOverrideContainingBlockContentLogicalHeight):

  • rendering/RenderBox.h:

Added clearOverrideContainingBlockContentLogicalHeight and updated clearContainingBlockOverrideSize
to use it.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::minContentForChild):
(WebCore::RenderGrid::maxContentForChild):
Added missing clearContainingBlockOverrideSize to ensure we don't use a previous layout's override.

LayoutTests:

  • fast/css-grid-layout/implicit-position-dynamic-change-expected.txt: Added.
  • fast/css-grid-layout/implicit-position-dynamic-change.html: Added.
6:53 PM Changeset in webkit [141962] by mhahnenberg@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

put_to_base should emit a Phantom for "value" across the ForceOSRExit
https://bugs.webkit.org/show_bug.cgi?id=108998

Reviewed by Oliver Hunt.

Otherwise, the OSR exit compiler could clobber it, which would lead to badness.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::tallyFrequentExitSites): Build fixes for when DFG debug logging is enabled.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock): Added extra Phantoms for the "value" field where needed.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile): Ditto.

6:48 PM Changeset in webkit [141961] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Optimize GlyphPage for case where all glyphs are available in the same font.
<http://webkit.org/b/108835>
<rdar://problem/13157042>

Reviewed by Antti Koivisto.

Let GlyphPage begin optimistically assuming that all its glyphs will be represented in
the same SimpleFontData*. In this (very common) case, only keep a single SimpleFontData*.

If glyphs from multiple fonts are mixed in one page, an array of per-glyph SimpleFontData*
is allocated transparently.

4.98 MB progression on Membuster3.

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::initializePage):

  • platform/graphics/GlyphPage.h:

(WebCore::GlyphPage::createUninitialized):
(WebCore::GlyphPage::createZeroedSystemFallbackPage):
(WebCore::GlyphPage::createCopiedSystemFallbackPage):

There are now three ways of constructing a GlyphPage, two of them are only used for
creating system fallback pages.

(WebCore::GlyphPage::setGlyphDataForIndex):

Hold off creating a SimpleFontData* array until we're sure there are two different
SimpleFontData* backing the glyphs in this page.
We don't store font data for glyph #0, instead we let the getters always return null for it.

(WebCore::GlyphPage::~GlyphPage):

Free the SimpleFontData* array if needed.

(WebCore::GlyphPage::glyphDataForCharacter):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::fontDataForCharacter):

The font data for glyph #0 is always a null pointer now.

(WebCore::GlyphPage::clearForFontData):

Updated for new storage format.

6:34 PM Changeset in webkit [141960] by tkent@chromium.org
  • 10 edits in trunk

INPUT_MULTIPLE_FIELDS_UI: Read-only inputs should be focusable
https://bugs.webkit.org/show_bug.cgi?id=108795

Reviewed by Kentaro Hara.

Source/WebCore:

According to the standard [1], readonly form controls should be focusable.

  • Sub-fields should be focusable if they are read-only. We should check isDisabled mainly.
  • All keyboard operations should not be handled if a field is disabled, and focus navigation keyboard operations should be handled even if a field is read-only.

[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#the-readonly-attribute

No new tests. Update
fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html
for the new behavior.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::isKeyboardFocusable):
Make <input> focusable even if it is read-only.

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::isFieldOwnerDisabled):
Separate isFieldOwnerDisabledOrReadOnly into two.
(WebCore::DateTimeEditElement::isFieldOwnerReadOnly): Ditto.
(WebCore::DateTimeEditElement::updateUIState):
We don't need to focus out if this is read-only.

  • html/shadow/DateTimeEditElement.h:

(DateTimeEditElement): Separate isFieldOwnerDisabledOrReadOnly into two.

  • html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::defaultEventHandler):
Skip handleKeyboardEvent if the field is disabled or the owner input is
disabled or read-only. handleKeyboardEvent handles editing key
operations.
(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler):
If this field is disabled or the owner input is disabled, all keyboard
inputs are ignored.
If this field is read-only, we handle only left and right arrows to
change focus, and skip down/up/backspace/del keys.
(WebCore::DateTimeFieldElement::isFieldOwnerDisabled):
A helper function to check disable state of the owner input.
(WebCore::DateTimeFieldElement::isFieldOwnerReadOnly):
A helper function to check read-only state of the owner input.
(WebCore::DateTimeFieldElement::isFocusable):
This field should be focusable if it is read-only and not disabled.

  • html/shadow/DateTimeFieldElement.h:

(FieldOwner): Separate isFieldOwnerDisabledOrReadOnly into two.
(DateTimeFieldElement):
Declare isFieldOwnerDisabled and isFieldOwnerReadOnly.

  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::handleKeyboardEvent):
Remove redundant isDisabled check. It is done in
DateTimeFieldElement::defaultEventHandler.

LayoutTests:

  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:
6:27 PM Changeset in webkit [141959] by commit-queue@webkit.org
  • 2 edits in trunk/Source/ThirdParty

Building with MinGW compiler dies with gtest errors
https://bugs.webkit.org/show_bug.cgi?id=108470

Patch by Paweł Forysiuk <tuxator@o2.pl> on 2013-02-05
Reviewed by Martin Robinson.

Variable Libraries_libgtest_la_CXXFLAGS blindly assumes that
pthreads will always be enabled. Make using pthreads for gtest
conditional on the build target.

  • gtest/GNUmakefile.am: Set Libraries_libgtest_la_CXXFLAGS accordingly to the build target.
6:21 PM Changeset in webkit [141958] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit/win

Unreviewed build fix.

  • WebKit.vcproj/WebKitExports.def.in:
6:15 PM Changeset in webkit [141957] by eric.carlson@apple.com
  • 11 edits in trunk

[Mac] Complete plumbing so captions menu can indicate track type
https://bugs.webkit.org/show_bug.cgi?id=108994

Reviewed by Dean Jackson.

Source/WebCore:

Plumb "isClosedCaptions" through to the Mac media engine.

Updated media/video-controls-captions-trackmenu-localized.html and results.

  • html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::isClosedCaptions): New, pass the call through to the private track.

  • html/track/InbandTextTrack.h:

(InbandTextTrack):

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Lose the member variable, this won't be accessed often enough

to make it worth caching the value.

  • html/track/TextTrack.h:

(WebCore::TextTrack::isClosedCaptions): Make virtual so derived classes can oveerride.

  • platform/graphics/InbandTextTrackPrivate.h:

(WebCore::InbandTextTrackPrivate::isClosedCaptions): New.

  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:

(WebCore::InbandTextTrackPrivateAVFObjC::isClosedCaptions): New.

LayoutTests:

Update test results now that the Mac media engine identifies CC tracks.

  • media/video-controls-captions-trackmenu-localized.html:
  • platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
6:10 PM Changeset in webkit [141956] by mark.lam@apple.com
  • 9 edits in trunk/Source/WebCore

Change DatabaseTask and DatabaseThread to work with DatabaseBackendAsync
instead of Database.
https://bugs.webkit.org/show_bug.cgi?id=108995.

Reviewed by Sam Weinig.

This change also moves the task inner classes from Database to
DatabaseBackendAsync.

No new tests.

  • Modules/webdatabase/Database.cpp:

(WebCore::Database::from):

  • Modules/webdatabase/Database.h:

(Database):

  • Modules/webdatabase/DatabaseBackend.h:

(DatabaseBackend):

  • Modules/webdatabase/DatabaseBackendAsync.h:

(DatabaseBackendAsync):

  • Modules/webdatabase/DatabaseTask.cpp:

(WebCore::DatabaseTask::DatabaseTask):
(WebCore::DatabaseBackendAsync::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::DatabaseBackendAsync::DatabaseOpenTask::doPerformTask):
(WebCore::DatabaseBackendAsync::DatabaseOpenTask::debugTaskName):
(WebCore::DatabaseBackendAsync::DatabaseCloseTask::DatabaseCloseTask):
(WebCore::DatabaseBackendAsync::DatabaseCloseTask::doPerformTask):
(WebCore::DatabaseBackendAsync::DatabaseCloseTask::debugTaskName):
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::doPerformTask):
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::debugTaskName):
(WebCore::DatabaseBackendAsync::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::DatabaseBackendAsync::DatabaseTableNamesTask::doPerformTask):
(WebCore::DatabaseBackendAsync::DatabaseTableNamesTask::debugTaskName):

  • Modules/webdatabase/DatabaseTask.h:

(WebCore::DatabaseTask::database):
(DatabaseTask):
(WebCore::DatabaseBackendAsync::DatabaseOpenTask::create):
(DatabaseBackendAsync::DatabaseOpenTask):
(WebCore::DatabaseBackendAsync::DatabaseCloseTask::create):
(DatabaseBackendAsync::DatabaseCloseTask):
(WebCore::DatabaseBackendAsync::DatabaseTableNamesTask::create):
(DatabaseBackendAsync::DatabaseTableNamesTask):

  • Modules/webdatabase/DatabaseThread.cpp:

(WebCore::DatabaseThread::databaseThread):
(WebCore::DatabaseThread::recordDatabaseOpen):
(WebCore::DatabaseThread::recordDatabaseClosed):
(WebCore::SameDatabasePredicate::SameDatabasePredicate):
(SameDatabasePredicate):
(WebCore::DatabaseThread::unscheduleDatabaseTasks):

  • Modules/webdatabase/DatabaseThread.h:

(DatabaseThread):

6:04 PM Changeset in webkit [141955] by oliver@apple.com
  • 2 edits in trunk/Source/WTF

2013-02-05 Oliver Hunt <oliver@apple.com>

Disable TCMalloc hardening as it's breaking leaks.

Reviewed by Gavin Barraclough.

  • wtf/FastMalloc.cpp:
5:42 PM Changeset in webkit [141954] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Explicitly destroy the WebMediaPlayer in WebMediaPlayerClientImpl's destructor
https://bugs.webkit.org/show_bug.cgi?id=108989

Patch by David Dorwin <ddorwin@chromium.org> on 2013-02-05
Reviewed by Kent Tamura.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):

5:36 PM Changeset in webkit [141953] by roger_fong@apple.com
  • 4 edits in trunk/Source/WebKit

Unreviewed. Get rid of redundant exports in export definitions file.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
  • WebKit.vcproj/WebKitExports.def.in:
5:32 PM Changeset in webkit [141952] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

[wk2] TiledCoreAnimationDrawingArea has one more layer in its CAContext when we're in the background
https://bugs.webkit.org/show_bug.cgi?id=108992
<rdar://problem/13087365>

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea): Add storage for m_isInWindow.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updateLayerHostingContext): Only set the root layer on our layer
hosting context if we're in the window when swapping out contexts.
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer): Update m_isInWindow, and set the root layer
of the layer hosting context (or unset it if we're out of the window).

5:06 PM Changeset in webkit [141951] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Crash at JSC::call when loading www.gap.com with JSVALUE32_64 Enabled
https://bugs.webkit.org/show_bug.cgi?id=108991

Reviewed by Oliver Hunt.

Changed the restoration from calleeGPR to nonArgGPR0 because the restoration of the return location
may step on calleeGPR is it happen to be nonArgGPR2.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgLinkClosureCall):

4:58 PM Changeset in webkit [141950] by mark.lam@apple.com
  • 9 edits in trunk/Source

Rename ENUM_CLASS_BEGIN() macro to ENUM_CLASS(), and make DatabaseType a strong enum.
https://bugs.webkit.org/show_bug.cgi?id=108988.

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests.

  • Modules/webdatabase/DatabaseBackend.cpp:

(WebCore::DatabaseBackend::DatabaseBackend):

  • Modules/webdatabase/DatabaseBackend.h:

(DatabaseBackend):

  • Modules/webdatabase/DatabaseBackendAsync.cpp:

(WebCore::DatabaseBackendAsync::DatabaseBackendAsync):

  • Modules/webdatabase/DatabaseBackendSync.cpp:

(WebCore::DatabaseBackendSync::DatabaseBackendSync):

  • Modules/webdatabase/DatabaseBasicTypes.h:

(WebCore::ENUM_CLASS):

  • Modules/webdatabase/DatabaseError.h:

(WebCore::ENUM_CLASS):

Source/WTF:

  • wtf/EnumClass.h:
4:48 PM Changeset in webkit [141949] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit

Unreviewed Visual Studio 2010 build correction.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Link export definitions out of date with ToT. Corrected.

4:28 PM Changeset in webkit [141948] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Remove deprecatedV8String() and deprecatedV8Integer()
https://bugs.webkit.org/show_bug.cgi?id=108919

Reviewed by Adam Barth.

No tests. No change in behavior.

  • bindings/v8/V8Binding.cpp:

(WebCore::toXPathNSResolver):

  • bindings/v8/V8Binding.h:
  • bindings/v8/custom/V8CustomXPathNSResolver.cpp:

(WebCore::V8CustomXPathNSResolver::create):
(WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver):
(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):

  • bindings/v8/custom/V8CustomXPathNSResolver.h:

(V8CustomXPathNSResolver):

4:05 PM Changeset in webkit [141947] by Vineet
  • 5 edits in trunk

formenctype to have empty string as default value.
https://bugs.webkit.org/show_bug.cgi?id=108969

Reviewed by Kent Tamura.

The spec says formEnctype should only have an invalid value default, not a missing value default.
Spec: http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-formenctype

http://www.whatwg.org/specs/web-apps/current-work/#attr-fs-formenctype

Source/WebCore:

No new tests. Covered by existing test case fast/forms/submit-form-attributes.html

  • html/HTMLFormControlElement.cpp: For the missing formEnctype attr return empty string.

(WebCore::HTMLFormControlElement::formEnctype):

LayoutTests:

  • fast/forms/submit-form-attributes-expected.txt:
  • fast/forms/submit-form-attributes.html: Modified test to behave as expected.
4:00 PM Changeset in webkit [141946] by haraken@chromium.org
  • 20 edits in trunk/Source

[V8] Reduce usage of deprecatedString() and deprecatedInteger()
https://bugs.webkit.org/show_bug.cgi?id=108909

Reviewed by Adam Barth.

Source/WebCore:

By passing an Isolate parameter around, we can reduce usage of
deprecated methods.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter):
(GenerateEventListenerCallback):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::addEventListenerCallback):
(WebCore::TestEventTargetV8Internal::removeEventListenerCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::addEventListenerCallback):
(WebCore::TestObjV8Internal::removeEventListenerCallback):

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::get):
(WebCore::set):
(WebCore::getNthValueOnKeyPath):
(WebCore::canInjectNthValueOnKeyPath):
(WebCore::ensureNthValueOnKeyPath):
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::canInjectIDBKeyIntoScriptValue):

  • bindings/v8/NPV8Object.cpp:

(WebCore::createValueListFromVariantArgs):
(_NPN_Invoke):
(_NPN_InvokeDefault):
(_NPN_SetProperty):
(_NPN_Construct):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::compileAndRunScript):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore):
(WebCore::ScriptProfiler::takeHeapSnapshot):

  • bindings/v8/ScriptSourceCode.cpp:

(WebCore::ScriptSourceCode::compileScript):

  • bindings/v8/ScriptSourceCode.h:

(ScriptSourceCode):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):

  • bindings/v8/V8NPUtils.cpp:

(WebCore::convertNPVariantToV8Object):

  • bindings/v8/V8NPUtils.h:

(WebCore):

  • bindings/v8/V8Utilities.cpp:

(WebCore::createHiddenDependency):
(WebCore::removeHiddenDependency):
(WebCore::transferHiddenDependency):

  • bindings/v8/V8Utilities.h:

(WebCore):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::addEventListenerCallback):
(WebCore::V8DOMWindow::removeEventListenerCallback):

Source/WebKit/chromium:

No tests. No change in behavior.

  • src/WebBindings.cpp:

(WebKit::WebBindings::toV8Value):

3:55 PM Changeset in webkit [141945] by haraken@chromium.org
  • 34 edits in trunk/Source

[V8] Make an Isolate parameter mandatory in HasInstance()
https://bugs.webkit.org/show_bug.cgi?id=108917

Reviewed by Adam Barth.

Source/WebCore:

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::HasInstance):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::HasInstance):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::HasInstance):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::HasInstance):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::HasInstance):

  • bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::HasInstance):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::HasInstance):

  • bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::HasInstance):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::HasInstance):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toWebGLUniformLocation):

Source/WebKit/chromium:

Because these methods do not have an Isolate, we have to call
v8::Isolate::GetCurrent().

No tests. No change in behavior.

  • src/WebArrayBuffer.cpp:

(WebKit::WebArrayBuffer::createFromV8Value):

  • src/WebArrayBufferView.cpp:

(WebKit::WebArrayBufferView::createFromV8Value):

  • src/WebBindings.cpp:

(WebKit::getRangeImpl):
(WebKit::getNodeImpl):
(WebKit::getElementImpl):
(WebKit::getArrayBufferImpl):
(WebKit::getArrayBufferViewImpl):
(WebKit::WebBindings::getRange):
(WebKit::WebBindings::getArrayBuffer):
(WebKit::WebBindings::getArrayBufferView):
(WebKit::WebBindings::getNode):
(WebKit::WebBindings::getElement):

3:43 PM Changeset in webkit [141944] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[JSC] Clean up CodeGeneratorJS.pm by introducing HasCustom{Getter,Setter,Method}
https://bugs.webkit.org/show_bug.cgi?id=108898

Reviewed by Sam Weinig.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(HasCustomGetter):
(HasCustomSetter):
(HasCustomMethod):

3:42 PM Changeset in webkit [141943] by danakj@chromium.org
  • 8 edits
    1 delete in trunk/Source

[chromium] Provide compositor offscreen context through the WebLayerTreeViewClient interface
https://bugs.webkit.org/show_bug.cgi?id=107776

Source/Platform:

Make "createGrGLInterface" the preferred virtual method for
WebGraphicsContext3D implementations to override. For now it
just calls the old method in its default implementation.

Reviewed by James Robinson.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::createGrGLInterface):

Source/WebCore:

Reviewed by James Robinson.

Allow the compositor thread's context to be retrieved on either thread,
so the main thread can create and pass the context to the impl thread
via its own mechanisms.

Move the code to bind the GrGLInterface to a WebGraphicsContext3D into
chromium's GraphicsContext3DPrivate. The chromium-side code will need
to implement this code itself.

  • platform/chromium/support/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore):
(WebCore::GraphicsContext3DPrivate::grContext):

  • platform/chromium/support/GraphicsContext3DPrivate.h:
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::getForImplThread):

Source/WebKit/chromium:

Reviewed by James Robinson.

  • WebKit.gyp:
  • src/WebGraphicsContext3D.cpp: Removed.
3:40 PM Changeset in webkit [141942] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

[CMake] Don't warn unused cmake variables which aren't used by cmake ports
https://bugs.webkit.org/show_bug.cgi?id=108761

Reviewed by Laszlo Gombos.

Ignore unused macro variables which aren't used by cmake ports.

  • Scripts/webkitdirs.pm:

(generateBuildSystemFromCMakeProject):

3:37 PM Changeset in webkit [141941] by jparent@chromium.org
  • 3 edits in trunk/Tools

Add cc_unittests to the dashboards
https://bugs.webkit.org/show_bug.cgi?id=108878

Reviewed by Dirk Pranke.

  • TestResultServer/static-dashboards/builders.js:

(loadBuildersList):

  • TestResultServer/static-dashboards/dashboard_base.js:

(currentBuilderGroupCategory):

3:24 PM Changeset in webkit [141940] by roger_fong@apple.com
  • 2 edits in trunk/Source/WTF

Unreviewed build fix.

  • wtf/FastMalloc.cpp:
3:05 PM Changeset in webkit [141939] by roger_fong@apple.com
  • 8 edits
    11 adds in trunk/Source

Add a JavaScriptCore Export Generator project.
https://bugs.webkit.org/show_bug.cgi?id=108971.

Reviewed by Brent Fulgham.

  • JavaScriptCore.vcxproj/JavaScriptCore.sln:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.filters: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.user: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorBuildCmd.cmd: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorCommon.props: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorDebug.props: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPostBuild.cmd: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPreBuild.cmd: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorRelease.props: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in: Added.
  • WebKit.vcxproj/WebKit.sln:
2:39 PM Changeset in webkit [141938] by tonyg@chromium.org
  • 4 edits in trunk/Source/WebCore

Continue making XSSAuditor thread safe: Remove dependency on the parser's tokenizer
https://bugs.webkit.org/show_bug.cgi?id=108666

Reviewed by Adam Barth.

This is the final dependency on the parser, so we remove that as well. Yay!

No new tests because no new functionality.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::pumpTokenizer): Pass m_tokenizer->shouldAllowCDATA()

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::XSSAuditor): Remove isMainThread() check because we have one in init() anyway.
Move m_isEnabled and m_documentURL initialization to init() because we have a Document* there.
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
(WebCore::XSSAuditor::filterStartToken):
(WebCore::XSSAuditor::filterEndToken):
(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::decodedSnippetForJavaScript):

  • html/parser/XSSAuditor.h:

(WebCore::FilterTokenRequest::FilterTokenRequest):
(FilterTokenRequest):
(XSSAuditor):

2:37 PM Changeset in webkit [141937] by enrica@apple.com
  • 4 edits in trunk/Source/WebCore

Make baseWritingDirectionForSelectionStart available to all platforms in the Editor class.
https://bugs.webkit.org/show_bug.cgi?id=108977.

Reviewed by Ryosuke Niwa.

Now that baseWritingDirectionForSelectionStart doesn't use
platform specific type anymore, we can make it available for
all platforms. This way it can be used for iOS as well.

No new tests, no functionality change.

  • editing/Editor.cpp:

(WebCore::Editor::baseWritingDirectionForSelectionStart): Added.

  • editing/Editor.h: Moved from PLATFORM(MAC).
  • editing/mac/EditorMac.mm: baseWritingDirectionForSelectionStart removed.
2:35 PM Changeset in webkit [141936] by Lucas Forschler
  • 4 edits in tags/Safari-537.29.1/Source

Versioning.

2:33 PM Changeset in webkit [141935] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Avoid String->AtomicString conversion in Attr::childrenChanged()
https://bugs.webkit.org/show_bug.cgi?id=108742

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-05
Reviewed by Andreas Kling.

  • dom/Attr.cpp:

(WebCore::Attr::childrenChanged): StringBuilder can output AtomicString directly.

2:32 PM Changeset in webkit [141934] by Lucas Forschler
  • 1 copy in tags/Safari-537.29.1

New Tag.

2:15 PM Changeset in webkit [141933] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Win7 port doesn't run WebGL.

  • platform/win/TestExpectations:
2:14 PM Changeset in webkit [141932] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Tidy up StackBounds
https://bugs.webkit.org/show_bug.cgi?id=108889

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-05
Reviewed by Ryosuke Niwa.

  • wtf/StackBounds.h:

(StackBounds):
(WTF::StackBounds::isSafeToRecurse):
(WTF::StackBounds::size):
Adopt a more conventional style for a multiline branch.

(WTF::StackBounds::StackBounds):
(WTF::StackBounds::current):
(WTF::StackBounds::recursionLimit):
Make those method private.

Making the constructor private ensure initialize() is alwasy called on any StackBounds.

2:14 PM Changeset in webkit [141931] by fpizlo@apple.com
  • 6 edits
    2 adds in trunk/Source/JavaScriptCore

DFG should have a precise view of jump targets
https://bugs.webkit.org/show_bug.cgi?id=108868

Reviewed by Oliver Hunt.

Previously, the DFG relied entirely on the CodeBlock's jump targets list for
determining when to break basic blocks. This worked great, except sometimes it
would be too conservative since the CodeBlock just says where the bytecode
generator inserted labels.

This change keeps the old jump target list in CodeBlock since it is still
valuable to the baseline JIT, but switches the DFG to use its own jump target
calculator. This ought to reduce pressure on the DFG simplifier, which would
previously do a lot of work to try to merge redundantly created basic blocks.
It appears to be a 1% progression on SunSpider.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/PreciseJumpTargets.cpp: Added.

(JSC):
(JSC::addSimpleSwitchTargets):
(JSC::computePreciseJumpTargets):

  • bytecode/PreciseJumpTargets.h: Added.

(JSC):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseCodeBlock):

2:08 PM Changeset in webkit [141930] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK][WK2] Unflag tests related to layoutTestController.setCustomPolicyDelegate
https://bugs.webkit.org/show_bug.cgi?id=108976

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-02-05
Reviewed by Martin Robinson.

  • platform/gtk-wk2/TestExpectations: Unflag

fast/loader/policy-delegate-action-hit-test-zoomed.html as it is
already passing (layoutTestController.setCustomPolicyDelegate was
implemented in r128600). Mark some tests related with
layoutTestController.setCustomPolicyDelegate as passing in WK2 but
failing in WK1.

2:04 PM Changeset in webkit [141929] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Enable shouldGesturesTriggerActive for Android
https://bugs.webkit.org/show_bug.cgi?id=96948

Patch by Yusuf Ozuysal <yusufo@google.com> on 2013-02-05
Reviewed by James Robinson.

We need this to fix performance issues we are getting because of touchstart
triggering hover/active states.

No new tests. The tests introduced in https://bugs.webkit.org/show_bug.cgi?id=96060
should run with the corrected behavior and would cover this change as well.

  • page/EventHandler.cpp:

(WebCore::shouldGesturesTriggerActive):

2:02 PM Changeset in webkit [141928] by mark.lam@apple.com
  • 31 edits
    8 adds in trunk/Source

Introduced back-end database classes + a few small fixes.
https://bugs.webkit.org/show_bug.cgi?id=108759.

Source/WebCore:

Reviewed by Brady Eidson.

  1. Added DatabaseBackendContext, DatabaseBackendAsync, and DatabaseBackendSync. These are backends for DatabaseContext, Database, and DatabaseSync respectively.
  2. Added DatabaseBase to hold common code between Database and DatabaseSync.
  3. Renamed a few functions.
  4. Cleaned up unneeded code in ~DatabaseSync().
  5. Added some FIXMEs as reminders or places to clean up when we're done refactoring.
  6. Moved the calling of ScriptController::initializeThreading() from the Database constructor to DatabaseManager::openDatabase(). This just moves the call earlier in the same code path. System initialization work (i.e. initializing script threading in this case) should be done by the manager instead of by each Database instance.

No new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/webdatabase/AbstractDatabaseServer.h:

(AbstractDatabaseServer):

  • Modules/webdatabase/Database.cpp:

(WebCore::Database::Database):
(WebCore::Database::backend):

  • Modules/webdatabase/Database.h:

(Database):

  • Modules/webdatabase/DatabaseBackend.cpp:

(WebCore::DatabaseBackend::DatabaseBackend):
(WebCore::DatabaseBackend::~DatabaseBackend):
(WebCore::DatabaseBackend::incrementalVacuumIfNeeded):

  • Modules/webdatabase/DatabaseBackend.h:

(DatabaseBackend):
(WebCore::DatabaseBackend::databaseContext):
(WebCore::DatabaseBackend::setFrontend):

  • Modules/webdatabase/DatabaseBackendAsync.cpp: Added.

(WebCore::DatabaseBackendAsync::DatabaseBackendAsync):

  • Modules/webdatabase/DatabaseBackendAsync.h: Added.

(DatabaseBackendAsync):

  • Modules/webdatabase/DatabaseBackendContext.cpp: Added.

(WebCore::DatabaseBackendContext::securityOrigin):
(WebCore::DatabaseBackendContext::isContextThread):

  • Modules/webdatabase/DatabaseBackendContext.h: Added.

(DatabaseBackendContext):
(WebCore::DatabaseBackendContext::scriptExecutionContext):

  • Modules/webdatabase/DatabaseBackendSync.cpp: Added.

(WebCore::DatabaseBackendSync::DatabaseBackendSync):
(WebCore::DatabaseBackendSync::~DatabaseBackendSync):

  • Modules/webdatabase/DatabaseBackendSync.h: Added.

(DatabaseBackendSync):

  • Modules/webdatabase/DatabaseBase.cpp: Added.

(WebCore::DatabaseBase::DatabaseBase):
(WebCore::DatabaseBase::scriptExecutionContext):
(WebCore::DatabaseBase::logErrorMessage):

  • Modules/webdatabase/DatabaseBase.h: Added.

(DatabaseBase):

  • Modules/webdatabase/DatabaseContext.cpp:

(WebCore::DatabaseContext::DatabaseContext):
(WebCore::DatabaseContext::backend):

  • Modules/webdatabase/DatabaseContext.h:

(DatabaseContext):

  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::openDatabaseSync):
(WebCore::DatabaseManager::hasOpenDatabases):
(WebCore::DatabaseManager::interruptAllDatabasesForContext):
(WebCore::DatabaseManager::getMaxSizeForDatabase):
(WebCore::DatabaseManager::logErrorMessage):

  • Modules/webdatabase/DatabaseManager.h:

(DatabaseManager):

  • Modules/webdatabase/DatabaseServer.cpp:

(WebCore::DatabaseServer::interruptAllDatabasesForContext):
(WebCore::DatabaseServer::canEstablishDatabase):

  • Modules/webdatabase/DatabaseServer.h:
  • Modules/webdatabase/DatabaseSync.cpp:

(WebCore::DatabaseSync::DatabaseSync):
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::backend):

  • Modules/webdatabase/DatabaseSync.h:

(DatabaseSync):

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::openTrackerDatabase):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::hasEntryForDatabase):
(WebCore::DatabaseTracker::interruptAllDatabasesForContext):
(WebCore::DatabaseTracker::populateOriginsIfNeeded):
(WebCore::DatabaseTracker::databaseNamesForOriginNoLock):
(WebCore::DatabaseTracker::detailsForNameAndOrigin):
(WebCore::DatabaseTracker::setDatabaseDetails):
(WebCore::DatabaseTracker::usageForOriginNoLock):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::addDatabase):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::isDeletingDatabaseOrOriginFor):
(WebCore::DatabaseTracker::canDeleteDatabase):
(WebCore::DatabaseTracker::isDeletingDatabase):
(WebCore::DatabaseTracker::canDeleteOrigin):
(WebCore::DatabaseTracker::isDeletingOrigin):
(WebCore::DatabaseTracker::recordDeletingOrigin):
(WebCore::DatabaseTracker::doneDeletingOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::deleteDatabaseFile):

  • Modules/webdatabase/DatabaseTracker.h:

(DatabaseTracker):

  • Modules/webdatabase/SQLTransaction.cpp:
  • Modules/webdatabase/SQLTransactionClient.cpp:

(WebCore::SQLTransactionClient::didExceedQuota):

  • Modules/webdatabase/SQLTransactionSync.cpp:
  • Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::prepareToOpenDatabase):
(WebCore::DatabaseTracker::failedToOpenDatabase):
(WebCore::DatabaseTracker::interruptAllDatabasesForContext):
(WebCore::DatabaseTracker::closeDatabasesImmediately):

  • Modules/webdatabase/chromium/SQLTransactionClientChromium.cpp:

(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExceedQuota):

  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

Reviewed by Brady Eidson.

  • src/DatabaseObserver.cpp:

(WebCore::DatabaseObserver::databaseOpened):
(WebCore::DatabaseObserver::databaseModified):
(WebCore::DatabaseObserver::databaseClosed):

1:58 PM Changeset in webkit [141927] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WTF

[WTFURL] Comparison between signed and unsigned integer expressions in URLUtil.cpp
https://bugs.webkit.org/show_bug.cgi?id=108955

Reviewed by Benjamin Poulain.

  • wtf/url/src/URLUtil.cpp:

(URLUtilities): Make the counter variable a signed integer to get rid of the warning.

1:44 PM Changeset in webkit [141926] by abarth@webkit.org
  • 10 edits in trunk

DumpRenderTree should be able to enable the threaded parser
https://bugs.webkit.org/show_bug.cgi?id=108970

Reviewed by Eric Seidel.

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setThreadedHTMLParser):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

Tools:

We can now enable the parser at runtime using --enable-threaded-html-parser.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:

(WebPreferences):

  • DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):
(WebTestRunner::WebPreferences::applyTo):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::setThreadedHTMLParser):
(TestShell):

1:41 PM Changeset in webkit [141925] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit

Unreviewed. Delete some errant preprocessor definitions.

  • WebKit.vcxproj/WebKit/WebKitCommon.props:
1:30 PM Changeset in webkit [141924] by roger_fong@apple.com
  • 3 edits
    3 copies
    41 adds in trunk/Source/WebKit

VS2010 WebKit projects, scripts, and property sheets.
https://bugs.webkit.org/show_bug.cgi?id=106989.

Reviewed by Brent Fulgham.

  • WebKit.vcxproj/Interfaces: Added.
  • WebKit.vcxproj/Interfaces/FixMIDLHeaders.pl: Copied from win/WebKit.vcproj/FixMIDLHeaders.pl.
  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj: Added.
  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters: Added.
  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj.user: Added.
  • WebKit.vcxproj/Interfaces/InterfacesCommon.props: Added.
  • WebKit.vcxproj/Interfaces/InterfacesDebug.props: Added.
  • WebKit.vcxproj/Interfaces/InterfacesPostBuild.cmd: Added.
  • WebKit.vcxproj/Interfaces/InterfacesPreBuild.cmd: Added.
  • WebKit.vcxproj/Interfaces/InterfacesRelease.props: Added.
  • WebKit.vcxproj/WebKit: Added.
  • WebKit.vcxproj/WebKit.sln:
  • WebKit.vcxproj/WebKit/WebKit.vcxproj: Added.
  • WebKit.vcxproj/WebKit/WebKit.vcxproj.filters: Added.
  • WebKit.vcxproj/WebKit/WebKit.vcxproj.user: Added.
  • WebKit.vcxproj/WebKit/WebKitApple.props: Added.
  • WebKit.vcxproj/WebKit/WebKitCFLite.props: Added.
  • WebKit.vcxproj/WebKit/WebKitCommon.props: Added.
  • WebKit.vcxproj/WebKit/WebKitDebug.props: Added.
  • WebKit.vcxproj/WebKit/WebKitDirectX.props: Added.
  • WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Added.
  • WebKit.vcxproj/WebKit/WebKitPreBuild.cmd: Added.
  • WebKit.vcxproj/WebKit/WebKitPreLink.cmd: Added.
  • WebKit.vcxproj/WebKit/WebKitRelease.props: Added.
  • WebKit.vcxproj/WebKit/resource.h: Copied from win/WebKit.vcproj/resource.h.
  • WebKit.vcxproj/WebKitExportGenerator: Added.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj: Added.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.filters: Added.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.user: Added.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorBuildCmd.cmd: Added.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorCommon.props: Added.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorDebug.props: Added.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPostBuild.cmd: Added.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPreBuild.cmd: Added.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorRelease.props: Added.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Copied from win/WebKit.vcproj/WebKitExports.def.in.
  • WebKit.vcxproj/WebKitGUID: Added.
  • WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj: Added.
  • WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters: Added.
  • WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.user: Added.
  • WebKit.vcxproj/WebKitGUID/WebKitGUIDCommon.props: Added.
  • WebKit.vcxproj/WebKitGUID/WebKitGUIDDebug.props: Added.
  • WebKit.vcxproj/WebKitGUID/WebKitGUIDPostBuild.cmd: Added.
  • WebKit.vcxproj/WebKitGUID/WebKitGUIDPreBuild.cmd: Added.
  • WebKit.vcxproj/WebKitGUID/WebKitGUIDRelease.props: Added.
1:26 PM Changeset in webkit [141923] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

WebKit clients should be able to override loading of blocked plug-ins
https://bugs.webkit.org/show_bug.cgi?id=108968
<rdar://problem/13154516>

Reviewed by Sam Weinig.

Replace the shouldInstantiatePlugin callback with a new pluginLoadPolicy which is called regardless
of whether the plug-in is blocked or not. This lets clients override the plug-in load policy and
force loading of blacklisted plug-ins (and vice versa).

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getPluginPath):

  • UIProcess/WebUIClient.cpp:

(WebKit::toWKPluginLoadPolicy):
(WebKit):
(WebKit::toPluginModuleLoadPolicy):
(WebKit::WebUIClient::pluginLoadPolicy):

  • UIProcess/WebUIClient.h:

(WebUIClient):

1:16 PM Changeset in webkit [141922] by nayankk@motorola.com
  • 8 edits in trunk

[WEBGL] Rename WEBKIT_WEBGL_depth_texture to WEBGL_depth_texture.
https://bugs.webkit.org/show_bug.cgi?id=108959

Reviewed by Kenneth Russell.

Source/WebCore:

WEBGL_depth_texture is official now. Hence remove the vendor prefix from
WEBKIT_WEBGL_depth_texture and rename this extension string to WEBGL_depth_texture.
Specification: http://www.khronos.org/registry/webgl/extensions/WEBGL_depth_texture/.

Tests already exists, modified them to test querying of unprefixed extension string.

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLDepthTexture.cpp:

(WebCore::WebGLDepthTexture::getName):

  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::getExtension):

LayoutTests:

  • fast/canvas/webgl/webgl-depth-texture.html:
1:14 PM Changeset in webkit [141921] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Make ConfigurationBuildDir include directories precede WebKitLibraries in JSC.
https://bugs.webkit.org/show_bug.cgi?id=108693.

Rubberstamped by Timothy Horton.

1:04 PM Changeset in webkit [141920] by jamesr@google.com
  • 2 edits in trunk/Source/Platform

[chromium] Remove optionalness of second parameter to WebLayerTreeView::setViewportSize
https://bugs.webkit.org/show_bug.cgi?id=108972

Reviewed by Adam Barth.

This was added to ease the transition of adding this parameter, but it's now always set.

  • chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):

12:58 PM Changeset in webkit [141919] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Rationalize the use of iOS/Mac #defines in Assertions.cpp
https://bugs.webkit.org/show_bug.cgi?id=108870

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-05
Reviewed by David Kilzer.

  • wtf/Assertions.cpp: Instead of using PLATFORM(MAC) and assume it works for iOS and OS X,

use CF as the guard for CFString. Similarily, USE_APPLE_SYSTEM_LOG guards code using ASL.

12:52 PM Changeset in webkit [141918] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore/JavaScriptCore.vcxproj

Unreviewed. VS2010 JavaScriptCore projects touch-ups.

12:49 PM Changeset in webkit [141917] by benjamin@webkit.org
  • 4 edits in trunk

Source/WTF: Make StringBuilder::toAtomicString() consistent with StringBuilder::toString() for strings of length zero
https://bugs.webkit.org/show_bug.cgi?id=108894

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-05
Reviewed by Andreas Kling.

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::toAtomicString): The function was returning the nullAtom for strings of length zero.
This is inconsistent with StringBuilder::toString() which always return an empty string.

This patch unifies the behavior.

Tools: Make StringBuilder::toAtomicString() consistent with StringBuilder::toString() for strings of null length
https://bugs.webkit.org/show_bug.cgi?id=108894

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-05
Reviewed by Andreas Kling.

  • TestWebKitAPI/Tests/WTF/StringBuilder.cpp:

Extend the tests to check toAtomicString() on an empty builder.

12:43 PM Changeset in webkit [141916] by mhahnenberg@apple.com
  • 4 edits in trunk/Source

Structure::m_outOfLineCapacity is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=108206

Reviewed by Darin Adler.

Simplifying the utility functions that we use since we don't need a
bunch of fancy templates for this one specific call site.

Source/JavaScriptCore:

  • runtime/Structure.h:

(JSC::Structure::outOfLineCapacity):

Source/WTF:

  • wtf/MathExtras.h:

(WTF::roundUpToPowerOfTwo):

12:41 PM Changeset in webkit [141915] by roger_fong@apple.com
  • 27 adds in trunk/Source/WebKit/win/WebKit.resources

Unreviewed. Copy some resource files for VS2010 solution.
https://bugs.webkit.org/show_bug.cgi?id=106989.

  • WebKit.resources/WebKit.rc: Added.
  • WebKit.resources/deleteButton.png: Added.
  • WebKit.resources/deleteButtonPressed.png: Added.
  • WebKit.resources/fsVideoAudioVolumeHigh.png: Added.
  • WebKit.resources/fsVideoAudioVolumeLow.png: Added.
  • WebKit.resources/fsVideoExitFullscreen.png: Added.
  • WebKit.resources/fsVideoPause.png: Added.
  • WebKit.resources/fsVideoPlay.png: Added.
  • WebKit.resources/missingImage.png: Added.
  • WebKit.resources/nullplugin.png: Added.
  • WebKit.resources/panEastCursor.png: Added.
  • WebKit.resources/panIcon.png: Added.
  • WebKit.resources/panNorthCursor.png: Added.
  • WebKit.resources/panNorthEastCursor.png: Added.
  • WebKit.resources/panNorthWestCursor.png: Added.
  • WebKit.resources/panSouthCursor.png: Added.
  • WebKit.resources/panSouthEastCursor.png: Added.
  • WebKit.resources/panSouthWestCursor.png: Added.
  • WebKit.resources/panWestCursor.png: Added.
  • WebKit.resources/searchCancel.png: Added.
  • WebKit.resources/searchCancelPressed.png: Added.
  • WebKit.resources/searchMagnifier.png: Added.
  • WebKit.resources/searchMagnifierResults.png: Added.
  • WebKit.resources/textAreaResizeCorner.png: Added.
  • WebKit.resources/verticalTextCursor.png: Added.
  • WebKit.resources/zoomInCursor.png: Added.
  • WebKit.resources/zoomOutCursor.png: Added.
12:38 PM Changeset in webkit [141914] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Objective-C API: testapi.mm should use ARC
https://bugs.webkit.org/show_bug.cgi?id=107838

Reviewed by Oliver Hunt.

In ToT testapi.mm uses the Obj-C garbage collector, which hides a lot of our object lifetime bugs.
We should enable ARC, since that is what most of our clients will be using. We use Xcode project
settings to make sure we don't try to compile ARC on 32-bit.

  • API/tests/testapi.mm:

(+[TestObject testObject]):
(testObjectiveCAPI):

12:34 PM Changeset in webkit [141913] by roger_fong@apple.com
  • 2 edits
    1 add in trunk/WebKitLibraries/win/tools

Unreviewed. VS2010 solution touch-ups.
Make common.props use a platform dependent preprocessor definition (WIN32 or X64).
Add a few base properties.
Create a temporary auto-version script for use by the VS2010 solution. Will be removed later.
https://bugs.webkit.org/show_bug.cgi?id=106949.

  • win/tools/scripts/auto-version2010.sh: Added.
  • win/tools/vsprops/common.props:
12:32 PM Changeset in webkit [141912] by Gregg Tavares
  • 1 edit
    18 adds in trunk/LayoutTests

Adds the WebGL Conformance Tests typedarrays folder.
https://bugs.webkit.org/show_bug.cgi?id=108907

Reviewed by Kenneth Russell.

  • webgl/conformance/typedarrays/array-buffer-crash-expected.txt: Added.
  • webgl/conformance/typedarrays/array-buffer-crash.html: Added.
  • webgl/conformance/typedarrays/array-buffer-view-crash-expected.txt: Added.
  • webgl/conformance/typedarrays/array-buffer-view-crash.html: Added.
  • webgl/conformance/typedarrays/array-unit-tests-expected.txt: Added.
  • webgl/conformance/typedarrays/array-unit-tests.html: Added.
  • webgl/conformance/typedarrays/data-view-crash-expected.txt: Added.
  • webgl/conformance/typedarrays/data-view-crash.html: Added.
  • webgl/conformance/typedarrays/data-view-test-expected.txt: Added.
  • webgl/conformance/typedarrays/data-view-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/typedarrays/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/typedarrays/array-buffer-crash.html: Added.
  • webgl/resources/webgl_test_files/conformance/typedarrays/array-buffer-view-crash.html: Added.
  • webgl/resources/webgl_test_files/conformance/typedarrays/array-unit-tests.html: Added.
  • webgl/resources/webgl_test_files/conformance/typedarrays/data-view-crash.html: Added.
  • webgl/resources/webgl_test_files/conformance/typedarrays/data-view-test.html: Added.
12:20 PM Changeset in webkit [141911] by Gregg Tavares
  • 1 edit
    45 adds in trunk/LayoutTests

Adds the WebGL Conformance Tests misc folder.
https://bugs.webkit.org/show_bug.cgi?id=108905

Reviewed by Kenneth Russell.

  • webgl/conformance/misc/bad-arguments-test-expected.txt: Added.
  • webgl/conformance/misc/bad-arguments-test.html: Added.
  • webgl/conformance/misc/boolean-argument-conversion-expected.txt: Added.
  • webgl/conformance/misc/boolean-argument-conversion.html: Added.
  • webgl/conformance/misc/delayed-drawing-expected.txt: Added.
  • webgl/conformance/misc/delayed-drawing.html: Added.
  • webgl/conformance/misc/error-reporting-expected.txt: Added.
  • webgl/conformance/misc/error-reporting.html: Added.
  • webgl/conformance/misc/functions-returning-strings-expected.txt: Added.
  • webgl/conformance/misc/functions-returning-strings.html: Added.
  • webgl/conformance/misc/instanceof-test-expected.txt: Added.
  • webgl/conformance/misc/instanceof-test.html: Added.
  • webgl/conformance/misc/invalid-passed-params-expected.txt: Added.
  • webgl/conformance/misc/invalid-passed-params.html: Added.
  • webgl/conformance/misc/is-object-expected.txt: Added.
  • webgl/conformance/misc/is-object.html: Added.
  • webgl/conformance/misc/null-object-behaviour-expected.txt: Added.
  • webgl/conformance/misc/null-object-behaviour.html: Added.
  • webgl/conformance/misc/object-deletion-behaviour-expected.txt: Added.
  • webgl/conformance/misc/object-deletion-behaviour.html: Added.
  • webgl/conformance/misc/shader-precision-format-expected.txt: Added.
  • webgl/conformance/misc/shader-precision-format.html: Added.
  • webgl/conformance/misc/type-conversion-test-expected.txt: Added.
  • webgl/conformance/misc/type-conversion-test.html: Added.
  • webgl/conformance/misc/uninitialized-test-expected.txt: Added.
  • webgl/conformance/misc/uninitialized-test.html: Added.
  • webgl/conformance/misc/webgl-specific-expected.txt: Added.
  • webgl/conformance/misc/webgl-specific.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/misc/bad-arguments-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/boolean-argument-conversion.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/delayed-drawing.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/error-reporting.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/functions-returning-strings.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/instanceof-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/invalid-passed-params.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/is-object.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/null-object-behaviour.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/object-deletion-behaviour.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/shader-precision-format.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/type-conversion-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/uninitialized-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/webgl-specific.html: Added.
12:09 PM Changeset in webkit [141910] by Gregg Tavares
  • 1 edit
    31 adds in trunk/LayoutTests

Adds the WebGL Conformance Tests buffers folder
https://bugs.webkit.org/show_bug.cgi?id=108902

Reviewed by Kenneth Russell.

  • webgl/conformance/buffers/buffer-bind-test-expected.txt: Added.
  • webgl/conformance/buffers/buffer-bind-test.html: Added.
  • webgl/conformance/buffers/buffer-data-array-buffer-expected.txt: Added.
  • webgl/conformance/buffers/buffer-data-array-buffer.html: Added.
  • webgl/conformance/buffers/element-array-buffer-delete-recreate-expected.txt: Added.
  • webgl/conformance/buffers/element-array-buffer-delete-recreate.html: Added.
  • webgl/conformance/buffers/index-validation-copies-indices-expected.txt: Added.
  • webgl/conformance/buffers/index-validation-copies-indices.html: Added.
  • webgl/conformance/buffers/index-validation-crash-with-buffer-sub-data-expected.txt: Added.
  • webgl/conformance/buffers/index-validation-crash-with-buffer-sub-data.html: Added.
  • webgl/conformance/buffers/index-validation-expected.txt: Added.
  • webgl/conformance/buffers/index-validation-large-buffer-expected.txt: Added.
  • webgl/conformance/buffers/index-validation-large-buffer.html: Added.
  • webgl/conformance/buffers/index-validation-verifies-too-many-indices-expected.txt: Added.
  • webgl/conformance/buffers/index-validation-verifies-too-many-indices.html: Added.
  • webgl/conformance/buffers/index-validation-with-resized-buffer-expected.txt: Added.
  • webgl/conformance/buffers/index-validation-with-resized-buffer.html: Added.
  • webgl/conformance/buffers/index-validation.html: Added.
  • webgl/resources/webgl_test_files/conformance/buffers/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/buffers/buffer-bind-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/buffers/buffer-data-array-buffer.html: Added.
  • webgl/resources/webgl_test_files/conformance/buffers/element-array-buffer-delete-recreate.html: Added.
  • webgl/resources/webgl_test_files/conformance/buffers/index-validation-copies-indices.html: Added.
  • webgl/resources/webgl_test_files/conformance/buffers/index-validation-crash-with-buffer-sub-data.html: Added.
  • webgl/resources/webgl_test_files/conformance/buffers/index-validation-large-buffer.html: Added.
  • webgl/resources/webgl_test_files/conformance/buffers/index-validation-verifies-too-many-indices.html: Added.
  • webgl/resources/webgl_test_files/conformance/buffers/index-validation-with-resized-buffer.html: Added.
  • webgl/resources/webgl_test_files/conformance/buffers/index-validation.html: Added.
11:47 AM Changeset in webkit [141909] by commit-queue@webkit.org
  • 21 edits in trunk/Source

Unreviewed, rolling out r141905.
http://trac.webkit.org/changeset/141905
https://bugs.webkit.org/show_bug.cgi?id=108963

"Broke mac build" (Requested by tonyg-cr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-05

Source/WebCore:

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::pumpTokenizer):

  • html/parser/CompactHTMLToken.cpp:

(SameSizeAsCompactHTMLToken):
(WebCore::isStringSafeToSendToAnotherThread):
(WebCore::CompactHTMLToken::isSafeToSendToAnotherThread):

  • html/parser/CompactHTMLToken.h:

(WebCore):
(CompactHTMLToken):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterToken):

  • html/parser/XSSAuditor.h:

(WebCore):
(XSSAuditor):

  • html/parser/XSSAuditorDelegate.cpp:

(WebCore::XSSAuditorDelegate::didBlockScript):

  • html/parser/XSSAuditorDelegate.h:

(WebCore::DidBlockScriptRequest::create):
(WebCore::DidBlockScriptRequest::DidBlockScriptRequest):
(XSSAuditorDelegate):

  • platform/KURL.cpp:
  • platform/KURL.h:

(KURL):

  • platform/KURLGoogle.cpp:

(WebCore::KURLGooglePrivate::reportMemoryUsage):

  • platform/KURLGooglePrivate.h:

(KURLGooglePrivate):

  • platform/KURLWTFURLImpl.h:

(WebCore::KURLWTFURLImpl::reportMemoryUsage):

Source/WTF:

  • wtf/text/CString.cpp:
  • wtf/text/CString.h:
  • wtf/text/WTFString.cpp:
  • wtf/text/WTFString.h:

(String):

  • wtf/url/api/ParsedURL.h:

(ParsedURL):

  • wtf/url/api/URLString.h:
11:38 AM Changeset in webkit [141908] by dominik.rottsches@intel.com
  • 2 edits in trunk/Source/WebCore

[HarfBuzz][Cairo] harfBuzzGetGlyph is slow and hot
https://bugs.webkit.org/show_bug.cgi?id=108941

Reviewed by Kenneth Rohde Christiansen.

The text to glyph conversion using Cairo is slow
due to expensive text codec conversion to UTF-8.
Additionally, the glyph lookup itself is expensive.

Inspired by the approach taken in HarfBuzzFaceSkia.cpp
I suggest to implement a similar caching mechanism to
accelerate this conversion.

Arabic line breaking test, under review in
bug 108948 shows about 58% improvement on my system
with this patch.

  • platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:

(WebCore::HarfBuzzFontData::HarfBuzzFontData):

New container structure that keeps pointers
to the cairo scaled font as well as the glyph cache.

(HarfBuzzFontData):
(WebCore):
(WebCore::harfBuzzGetGlyph): Using the new container structure for accessing the cache.
(WebCore::harfBuzzGetGlyphHorizontalAdvance): Using the new container structure for accessing the scaled font.
(WebCore::harfBuzzGetGlyphExtents): Ditto.
(WebCore::destroyHarfBuzzFontData): Destroying the container that held the pointers.
(WebCore::HarfBuzzFace::createFont):

Initializing the container structure with the pointers
to the cache that is held in HarfBuzzFace and the cairo scaled font.

11:26 AM Changeset in webkit [141907] by Martin Robinson
  • 1 copy in releases/WebKitGTK/webkit-1.11.5

Tag the WebKitGTK+ 1.11.5 release

11:15 AM Changeset in webkit [141906] by dominik.rottsches@intel.com
  • 2 edits
    1 add in trunk/PerformanceTests

Add a performance test for arabic line breaking
https://bugs.webkit.org/show_bug.cgi?id=108948

Reviewed by Eric Seidel.

Adding a perfomance test based to exercise the complex
font path used in rendering arabic script.

  • Layout/ArabicLineLayout.html: Added.
  • Skipped: New test skipped by default as per Ryosuke's request.
11:06 AM Changeset in webkit [141905] by tonyg@chromium.org
  • 21 edits in trunk/Source

Call XSSAuditor's didBlockScript() for the threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=108726

Reviewed by Adam Barth.

Source/WebCore:

This patch causes us to call didBlockScript() on the main thread if the CompactHTML token has XSSInfo.
To do so, we:

  1. Rename DidBlockScriptRequest to XSSInfo.
  2. Add an OwnPtr<XSSInfo> field to CompactHTMLToken.
  3. Add an isSafeToSendToAnotherThread() method to String and KURL.

We don't yet populate didBlockScriptRequest on the background thread, but this should just work once we do.

No new tests because no new functionality.

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::pumpTokenizer): Update comment for rename.

  • html/parser/CompactHTMLToken.cpp:

(SameSizeAsCompactHTMLToken):
(WebCore::CompactHTMLToken::CompactHTMLToken): Add a copy constructor used by Vector.
(WebCore::CompactHTMLToken::isSafeToSendToAnotherThread): Include new m_xssInfo field in safety check.
(WebCore):
(WebCore::CompactHTMLToken::xssInfo): Added.
(WebCore::CompactHTMLToken::setXSSInfo): Added.

  • html/parser/CompactHTMLToken.h: Add an OwnPtr<XSSInfo> field to CompactHTMLToken.

(WebCore):
(CompactHTMLToken):
(WTF): Add VectorTraits necessary for copying Vector fields objects that contain an OwnPtr.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser): Add new didBlockScript() call.
(WebCore::HTMLDocumentParser::pumpTokenizer):

  • html/parser/XSSAuditor.cpp: Renaming.

(WebCore::XSSAuditor::filterToken):

  • html/parser/XSSAuditor.h: Renaming.

(WebCore):
(XSSAuditor):

  • html/parser/XSSAuditorDelegate.cpp:

(WebCore::XSSInfo::isSafeToSendToAnotherThread):
(WebCore):
(WebCore::XSSAuditorDelegate::didBlockScript):

  • html/parser/XSSAuditorDelegate.h:

(WebCore::XSSInfo::create):
(XSSInfo):
(WebCore::XSSInfo::XSSInfo):
(XSSAuditorDelegate):

  • platform/KURL.cpp:

(WebCore::KURL::isSafeToSendToAnotherThread): Added.
(WebCore):

  • platform/KURL.h:

(KURL):

  • platform/KURLGoogle.cpp:

(WebCore):
(WebCore::KURLGooglePrivate::isSafeToSendToAnotherThread): Added.

  • platform/KURLGooglePrivate.h:

(KURLGooglePrivate):

  • platform/KURLWTFURLImpl.h:

(WebCore::KURLWTFURLImpl::isSafeToSendToAnotherThread): Added.

Source/WTF:

This patch adds isSafeToSendToAnotherThread() methods to CString, String, ParsedURL and URLString.
These methods check to ensure there are 0 or 1 references.

  • wtf/text/CString.cpp:

(WTF::CString::isSafeToSendToAnotherThread): Added.
(WTF):

  • wtf/text/CString.h:

(CString):

  • wtf/text/WTFString.cpp:

(WTF::String::isSafeToSendToAnotherThread): Added.
(WTF):

  • wtf/text/WTFString.h:

(String):

  • wtf/url/api/ParsedURL.h:

(WTF::ParsedURL::isSafeToSendToAnotherThread): Added.

  • wtf/url/api/URLString.h:

(WTF::URLString::isSafeToSendToAnotherThread): Added.

10:55 AM Changeset in webkit [141904] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Make overlay layers slow-scrolling
https://bugs.webkit.org/show_bug.cgi?id=108957

Patch by Sami Kyostila <skyostil@chromium.org> on 2013-02-05
Reviewed by James Robinson.

Since overlay layers get inserted on top of everything else, we must
mark them slow-scrolling to prevent all scroll input events to the rest
of the page from getting blocked. This is also more correct because
generally the overlay contents need to be repainted whenever the scroll
offset changes, and with this patch the painting happens in sync with
page scrolling.

10:44 AM Changeset in webkit [141903] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Scrolling performance drops doing page load
https://bugs.webkit.org/show_bug.cgi?id=108949

Patch by Andrew Lo <anlo@rim.com> on 2013-02-05
Reviewed by Yong Li.
Internally reviewed by Jakob Petsovits.

Internal PR 291390.
The intention of this code was to not update non-visible tiles during page load.

Before this patch, the code would update tiles that have already been rendered
during page load.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):

10:43 AM Changeset in webkit [141902] by bfulgham@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[Windows] Unreviewed VS2010 Build Correction after r141651

StructureRareData.h and StructureRareData.cpp files.

10:36 AM Changeset in webkit [141901] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

TextAutosizing: adjust the maximum difference between cluster text width and its descendant
width.
https://bugs.webkit.org/show_bug.cgi?id=108411

Source/WebCore:

Currently, if a render object is more than 200 CSS units shorter than its parent cluster, it
becomes a separate autosizing cluster (see https://bugs.webkit.org/show_bug.cgi?id=105188).
This doesn't work well for layouts when narrow nodes are related, like nested comments:
deeper comments are all shorter than the parent cluster and become autosized differently. To
avoid that the difference that makes a shorter descendant a new autosizing cluster is
adjusted each time the width difference is not greater than 50 CSS units from the previous
one. This allows nested comments, for example, to remain a part of the parent cluster and be
autosized with the same multiplier.

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-05
Reviewed by Kenneth Rohde Christiansen.

Tests:

fast/text-autosizing/nested-child.html

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizingClusterInfo::TextAutosizingClusterInfo):

Added a new field to store the current maximum width difference for the cluster.

(WebCore::TextAutosizer::isAutosizingCluster):

Uses the new field to determine if the current node is a separate cluster,
updates the maximum allowed width difference between the cluster and its descendant.

(WebCore::TextAutosizer::processContainer):
(WebCore::TextAutosizer::clusterShouldBeAutosized):
(WebCore::TextAutosizer::measureDescendantTextWidth):

Non-const reference passed to the methods above.

  • rendering/TextAutosizer.h: updated method parameters.

LayoutTests:

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-05
Reviewed by Kenneth Rohde Christiansen.

Tests that certain width difference doesn't make descendants separate clusters.

  • fast/text-autosizing/nested-child-expected.html: Added.
  • fast/text-autosizing/nested-child.html: Added.
10:30 AM Changeset in webkit [141900] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r141896.
http://trac.webkit.org/changeset/141896
https://bugs.webkit.org/show_bug.cgi?id=108956

crashes indexdb security tests (Requested by gavinp on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-05

  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::idbFactory):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

10:26 AM WebKit Team edited by Christophe Dumez
Update my affiliation. (diff)
10:07 AM Changeset in webkit [141899] by jochen@chromium.org
  • 3 edits in trunk/Tools

[chromium] remove methods from the WebTestRunner interface that are only used by WebTestProxyBase
https://bugs.webkit.org/show_bug.cgi?id=108926

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebKit):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

9:59 AM Changeset in webkit [141898] by jknotten@chromium.org
  • 2 edits in branches/chromium/1364

Disable Fullscreen API on Android.

Disable the fullscreen API, as it is not working correctly on Android.

BUG=173664
Review URL: https://codereview.chromium.org/12208016

9:55 AM Changeset in webkit [141897] by tonyg@chromium.org
  • 5 edits in trunk/Source/WebCore

Continue making XSSAuditor thread safe: Remove dependency on parser's sourceForToken and TextResourceDecoder
https://bugs.webkit.org/show_bug.cgi?id=108698

Reviewed by Adam Barth.

We'd like to be able to call filterToken() from the BackgroundHTMLParser where there is no HTMLDocumentParser. So we are removing the dependencies of
filterToken() on the HTMLDocumentParser. This patch brings us one step closer to removing the m_parser member from XSSAuditor by passing in the
TextResourceDecoder and HTMLSourceTracker to filterToken. To keep the number of parameters from blowing up, this introduces a FilterTokenRequest struct
to hold its arguments. We expect to add one more member to this struct.

No new tests because no new functionality.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::pumpTokenizer):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterToken):
(WebCore::XSSAuditor::filterStartToken):
(WebCore::XSSAuditor::filterCharacterToken):
(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::filterObjectToken):
(WebCore::XSSAuditor::filterParamToken):
(WebCore::XSSAuditor::filterEmbedToken):
(WebCore::XSSAuditor::filterAppletToken):
(WebCore::XSSAuditor::filterIframeToken):
(WebCore::XSSAuditor::filterMetaToken):
(WebCore::XSSAuditor::filterBaseToken):
(WebCore::XSSAuditor::filterFormToken):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
(WebCore::XSSAuditor::eraseAttributeIfInjected):
(WebCore::XSSAuditor::decodedSnippetForName):
(WebCore::XSSAuditor::decodedSnippetForAttribute):
(WebCore::XSSAuditor::decodedSnippetForJavaScript):

  • html/parser/XSSAuditor.h:

(WebCore):
(WebCore::FilterTokenRequest::FilterTokenRequest):
(FilterTokenRequest):
(XSSAuditor):

9:42 AM Changeset in webkit [141896] by pilgrim@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove idbFactory from WebKitPlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=106457

Reviewed by Adam Barth.

Now that https://codereview.chromium.org/12181010/ has landed, the
idbFactory method is no longer needed. (Embedders must now call
the new setIDBFactory method upon initialization.) Part of a
larger refactoring series; see tracking bug 82948.

  • public/platform/WebKitPlatformSupport.h:

(WebKit):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

9:21 AM Changeset in webkit [141895] by kerz@chromium.org
  • 5 edits
    4 copies in branches/chromium/1364

Merge 141093

REGRESSION: ChildrenAffectedBy flags lost between siblings which have child elements sharing style
https://bugs.webkit.org/show_bug.cgi?id=105672

Reviewed by Andreas Kling.

Source/WebCore:

Change in how childrenAffectedBy bits were stored made it easier to trigger an issue where childrenAffectedBy bits
were not set due to sharing of styles between cousin elements.

This patch fixes the issue by not sharing styles from children with parents who prevent sharing.

Tests: fast/selectors/cousin-stylesharing-adjacent-selector.html

fast/selectors/cousin-stylesharing-last-child-selector.html

  • css/StyleResolver.cpp:

(WebCore::parentElementPreventsSharing):
(WebCore::StyleResolver::locateCousinList):

  • dom/Element.cpp:

(WebCore::Element::hasFlagsSetDuringStylingOfChildren):

  • dom/Element.h:

(Element):

LayoutTests:

Two test cases by Philippe Wittenbergh that triggers the issue.

  • fast/selectors/cousin-stylesharing-adjacent-selector-expected.html: Added.
  • fast/selectors/cousin-stylesharing-adjacent-selector.html: Added.
  • fast/selectors/cousin-stylesharing-last-child-selector-expected.html: Added.
  • fast/selectors/cousin-stylesharing-last-child-selector.html: Added.

TBR=allan.jensen@digia.com
Review URL: https://codereview.chromium.org/12209019

7:52 AM Changeset in webkit [141894] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

r141788 won't build due to not having all changes needed by Node* change
https://bugs.webkit.org/show_bug.cgi?id=108944

Reviewed by David Kilzer.

Fixed three instances of integerResult(..., m_compileIndex) to be integerResult(..., node).

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForARMv7s):

7:48 AM Changeset in webkit [141893] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing test.
https://bugs.webkit.org/show_bug.cgi?id=108942.

  • platform/qt/TestExpectations:
7:34 AM Changeset in webkit [141892] by jocelyn.turcotte@digia.com
  • 4 edits in trunk

[Qt] REGRESSION(r137436): It made all inspector tests timeout on developer builds
https://bugs.webkit.org/show_bug.cgi?id=106554

Reviewed by Simon Hausmann.

.:

Explicitely link WebCore resources in the final DLL only on Windows to
support force_static_libs_as_shared on other platforms.

WebKit1 applications don't get the QtWebKit dynamic library loaded
since libQtWebKitWidgets doesn't depend on libQtWebKit if WebCore and
WebKit1 are dynamic libraries of their own.

  • Source/api.pri:

Source/WebCore:

  • Target.pri:
7:05 AM Changeset in webkit [141891] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: prevent crash, add required error string value
https://bugs.webkit.org/show_bug.cgi?id=108776

Patch by Peter Rybin <prybin@chromium.org> on 2013-02-05
Reviewed by Pavel Feldman.

Error string is assigned where missing, assert is added where empty string is
possible.

  • inspector/InjectedScriptBase.cpp:

(WebCore::InjectedScriptBase::makeEvalCall):

  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::injectedScriptForEval):

6:18 AM Changeset in webkit [141890] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Clicking a profile's title in the console loads about:blank.
https://bugs.webkit.org/show_bug.cgi?id=107949

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-02-05
Reviewed by Vsevolod Vlasov.

Quick fix for regression.

  • inspector/front-end/inspector.js:

Avoid "exit route" when URL is a profile URL.

5:54 AM Changeset in webkit [141889] by tkent@chromium.org
  • 4 edits
    2 adds in trunk

INPUT_MULTIPLE_FIELDS_UI: element.focus() should not focus on disabled sub-fields.
https://bugs.webkit.org/show_bug.cgi?id=108924

Reviewed by Kentaro Hara.

Source/WebCore:

The first field may be non-focusable. We should search sub-fields for
focusable one.

Test: fast/forms/date-multiple-fields/date-multiple-fields-focus.html

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::focusOnNextFocusableField):
Added. A private helper function.
(WebCore::DateTimeEditElement::focusIfNoFocus): Use focusOnNextFocusableField.
(WebCore::DateTimeEditElement::focusByOwner): Ditto.
(WebCore::DateTimeEditElement::focusOnNextField): Ditto.

  • html/shadow/DateTimeEditElement.h:

(DateTimeEditElement): Declare focusOnNextFocusableField.

LayoutTests:

  • fast/forms/date-multiple-fields/date-multiple-fields-focus-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-focus.html: Added.
5:52 AM Changeset in webkit [141888] by vsevik@chromium.org
  • 8 edits
    2 adds in trunk

Web Inspector: Create separate project for each file system added to inspector.
https://bugs.webkit.org/show_bug.cgi?id=108652

Reviewed by Pavel Feldman.

Source/WebCore:

Every file system added to web inspector is now represented by its own project in workspace.
FileSystemMapping changed accrodingly.

Test: inspector/file-system-mapping.html

  • inspector/front-end/FileMapping.js:

(WebInspector.FileMapping.prototype._entryURIPrefix):

  • inspector/front-end/FileSystemMapping.js:

(WebInspector.FileSystemMapping.prototype.fileForURI):
(WebInspector.FileSystemMapping.prototype.uriForFile):
(WebInspector.FileSystemMapping.prototype.uriPrefixForPathPrefix):
(WebInspector.FileSystemMappingImpl):
(WebInspector.FileSystemMappingImpl.prototype._loadFromSettings.get this):
(WebInspector.FileSystemMappingImpl.prototype._loadFromSettings):
(WebInspector.FileSystemMappingImpl.prototype._saveToSettings):
(WebInspector.FileSystemMappingImpl.prototype.set _fileSystemName):
(WebInspector.FileSystemMappingImpl.prototype.fileSystemId):
(WebInspector.FileSystemMappingImpl.prototype.addFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.removeFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.fileSystemPaths):
(WebInspector.FileSystemMappingImpl.prototype.fileForURI):
(WebInspector.FileSystemMappingImpl.prototype.uriForFile):
(WebInspector.FileSystemMappingImpl.prototype.uriPrefixForPathPrefix):

  • inspector/front-end/FileSystemWorkspaceProvider.js:

(WebInspector.FileSystemWorkspaceProvider):
(WebInspector.FileSystemWorkspaceProvider.prototype.innerCallback):
(WebInspector.FileSystemWorkspaceProvider.prototype.requestFileContent):
(WebInspector.FileSystemWorkspaceProvider.prototype.setFileContent):
(WebInspector.FileSystemWorkspaceProvider.prototype._populate.filesLoaded):
(WebInspector.FileSystemWorkspaceProvider.prototype._populate):
(WebInspector.FileSystemWorkspaceProvider.prototype._addFile):
(WebInspector.FileSystemWorkspaceProvider.prototype._removeFile):
(WebInspector.FileSystemWorkspaceProvider.prototype.reset):

  • inspector/front-end/IsolatedFileSystemModel.js:

(WebInspector.IsolatedFileSystemModel):
(WebInspector.IsolatedFileSystemModel.prototype._innerAddFileSystem):
(WebInspector.IsolatedFileSystemModel.prototype._fileSystemRemoved):

  • inspector/front-end/Workspace.js:

(WebInspector.Project.prototype.searchInFileContent):
(WebInspector.Project.prototype.dispose):
(WebInspector.Workspace.prototype.removeProject):

LayoutTests:

  • inspector/file-mapping.html:
  • inspector/file-system-mapping-expected.txt: Added.
  • inspector/file-system-mapping.html: Added.
5:28 AM WebKit Team edited by mario@webkit.org
(diff)
5:03 AM Changeset in webkit [141887] by tkent@chromium.org
  • 8 edits
    2 adds in trunk

INPUT_MULTIPLE_FIELDS_UI: Should not move focus if the element already has focus
https://bugs.webkit.org/show_bug.cgi?id=108914

Reviewed by Kentaro Hara.

Source/WebCore:

If timeInput.focus() is called when a sub-field of the time input
already has focus, we should not focus on the first sub-field of the
time input.

Test: fast/forms/time-multiple-fields/time-multiple-fields-focus.html

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::willCancelFocus): If
the input elment already has focused sub-field, we don't need to proceed
focus handling. FocusDirection check is required because we don't need
to do this in cases of sequential focus navigation.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType): Override InputType::willCancelFocus.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::focus):
Cancel focus if InputType::willCancelFocus returns true.

  • html/HTMLInputElement.h:

(HTMLInputElement): Override focus.

  • html/InputType.cpp:

(WebCore::InputType::willCancelFocus):
Add a default implementation. It returns false.

  • html/InputType.h:

(InputType): Declare willCancelFocus.

LayoutTests:

  • fast/forms/time-multiple-fields/time-multiple-fields-focus-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-focus.html: Added.
4:57 AM Changeset in webkit [141886] by allan.jensen@digia.com
  • 4 edits in trunk/Source/WebCore

[Qt] RGB -> BGR is wrong on big endian
https://bugs.webkit.org/show_bug.cgi?id=107560

Reviewed by Jocelyn Turcotte.

Replace the conversion to methods that make it clearer what is going on.
The routines are also optimized compared to the existing by avoiding going
over slow Color constructor.

Tested by existing tests in canvas and fast/canvas.

  • platform/graphics/Color.cpp:

(WebCore::colorFromPremultipliedARGB):

Cleanup.

(WebCore::premultipliedARGBFromColor):

Cleanup and correct for alpha = 0.

  • platform/graphics/Color.h:

(WebCore):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::copyColorToRGBA):
(WebCore::copyRGBAToColor):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):

4:41 AM Changeset in webkit [141885] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[TexMap] Use visible as initial value of backface-visibility-property.
https://bugs.webkit.org/show_bug.cgi?id=108875

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2013-02-05
Reviewed by Noam Rosenthal.

According to W3C spec, the initial value of backface-visibility-visibility is visible.
However TextureMapperLayer's initial value is false which means hidden.
So this patch is for changing the value to visible(true).

Covered by existing tests.

  • platform/graphics/texmap/TextureMapperLayer.h:

(WebCore::TextureMapperLayer::State::State): Change the initial value false to true
to use backface-visibility.

4:34 AM Changeset in webkit [141884] by aandrey@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Canvas] do not store a dropped trace log in backend
https://bugs.webkit.org/show_bug.cgi?id=108600

Reviewed by Pavel Feldman.

Clear memory immediately on dropping current trace log instead of waiting for the next capture command.

  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

4:04 AM Changeset in webkit [141883] by aandrey@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Canvas] UI is not restored properly when deleting a live recording profile
https://bugs.webkit.org/show_bug.cgi?id=108602

Reviewed by Pavel Feldman.

Cancel recording profile of canvas-type when deleting an alive trace log.
Drive-by: rename ProfileHeader.reset to ProfileHeader.dispose since it's called on header's destruction.

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileHeader.prototype.dispose):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileHeader.prototype.dispose):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):

2:58 AM Changeset in webkit [141882] by Simon Hausmann
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Replace more uses of WebPageProxy with WKPage in QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=108826

Reviewed by Kenneth Rohde Christiansen and signed off for WK2 by
Benjamin Poulain.

This patch converts a few more usages of WebPageProxy to functions in
the WKPage API.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):
(QQuickWebViewLegacyPrivate::zoomFactor):
(QQuickWebViewLegacyPrivate::setZoomFactor):
(QQuickWebViewExperimental::postMessage):
(QQuickWebViewExperimental::userAgent):
(QQuickWebViewExperimental::setUserAgent):
(QQuickWebViewExperimental::evaluateJavaScript):
(QQuickWebViewExperimental::findText):
(QQuickWebView::goBack):
(QQuickWebView::goForward):
(QQuickWebView::stop):
(QQuickWebView::reload):
(QQuickWebView::setUrl):
(QQuickWebView::canGoBack):
(QQuickWebView::canGoForward):
(QQuickWebView::loading):
(QQuickWebView::title):
(QQuickWebView::pageRef):
(QQuickWebView::loadHtml):
(QQuickWebView::runJavaScriptInMainFrame):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

2:33 AM QtWebKitGardening edited by Csaba Osztrogonác
(diff)
2:32 AM Changeset in webkit [141881] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a flaky crash expectation for a couple of tests.
Reclassifying the expectation for http/tests/media/video-play-stall.html as a flaky timeouting test.

  • platform/gtk/TestExpectations:
2:27 AM Changeset in webkit [141880] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Build is broken since r141543 for platforms without OpenGL
https://bugs.webkit.org/show_bug.cgi?id=108862

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-02-05
Reviewed by Simon Hausmann.

  • Target.pri:
2:26 AM Changeset in webkit [141879] by haraken@chromium.org
  • 20 edits in trunk/Source

Unreviewed, rolling out r141865.
http://trac.webkit.org/changeset/141865
https://bugs.webkit.org/show_bug.cgi?id=108909

webkit unit tests are broken

Source/WebCore:

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter):
(GenerateEventListenerCallback):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::addEventListenerCallback):
(WebCore::TestEventTargetV8Internal::removeEventListenerCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::addEventListenerCallback):
(WebCore::TestObjV8Internal::removeEventListenerCallback):

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::get):
(WebCore::set):
(WebCore::getNthValueOnKeyPath):
(WebCore::canInjectNthValueOnKeyPath):
(WebCore::ensureNthValueOnKeyPath):
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::canInjectIDBKeyIntoScriptValue):

  • bindings/v8/NPV8Object.cpp:

(WebCore::createValueListFromVariantArgs):
(_NPN_Invoke):
(_NPN_InvokeDefault):
(_NPN_SetProperty):
(_NPN_Construct):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::compileAndRunScript):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::takeHeapSnapshot):

  • bindings/v8/ScriptSourceCode.cpp:

(WebCore::ScriptSourceCode::compileScript):

  • bindings/v8/ScriptSourceCode.h:

(ScriptSourceCode):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):

  • bindings/v8/V8NPUtils.cpp:

(WebCore::convertNPVariantToV8Object):

  • bindings/v8/V8NPUtils.h:

(WebCore):

  • bindings/v8/V8Utilities.cpp:

(WebCore::createHiddenDependency):
(WebCore::removeHiddenDependency):
(WebCore::transferHiddenDependency):

  • bindings/v8/V8Utilities.h:

(WebCore):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::addEventListenerCallback):
(WebCore::V8DOMWindow::removeEventListenerCallback):

Source/WebKit/chromium:

  • src/WebBindings.cpp:

(WebKit::WebBindings::toV8Value):

2:20 AM Changeset in webkit [141878] by jochen@chromium.org
  • 2 edits in trunk/Tools

[chromium] remove unneccessary 0 checks for testRunner now that the TestRunner library owns it
https://bugs.webkit.org/show_bug.cgi?id=108923

Reviewed by Kentaro Hara.

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner):
(WebTestRunner::WebTestProxyBase::shouldBeginEditing):
(WebTestRunner::WebTestProxyBase::shouldEndEditing):
(WebTestRunner::WebTestProxyBase::shouldInsertNode):
(WebTestRunner::WebTestProxyBase::shouldInsertText):
(WebTestRunner::WebTestProxyBase::shouldChangeSelectedRange):
(WebTestRunner::WebTestProxyBase::shouldDeleteRange):
(WebTestRunner::WebTestProxyBase::shouldApplyStyle):
(WebTestRunner::WebTestProxyBase::didBeginEditing):
(WebTestRunner::WebTestProxyBase::didChangeSelection):
(WebTestRunner::WebTestProxyBase::didChangeContents):
(WebTestRunner::WebTestProxyBase::didEndEditing):
(WebTestRunner::WebTestProxyBase::createView):
(WebTestRunner::WebTestProxyBase::setStatusText):
(WebTestRunner::WebTestProxyBase::didStopLoading):
(WebTestRunner::WebTestProxyBase::isSmartInsertDeleteEnabled):
(WebTestRunner::WebTestProxyBase::isSelectTrailingWhitespaceEnabled):
(WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
(WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
(WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
(WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
(WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
(WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
(WebTestRunner::WebTestProxyBase::didReceiveTitle):
(WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
(WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
(WebTestRunner::WebTestProxyBase::didFailLoad):
(WebTestRunner::WebTestProxyBase::didFinishLoad):
(WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
(WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
(WebTestRunner::WebTestProxyBase::didRunInsecureContent):
(WebTestRunner::WebTestProxyBase::didDetectXSS):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
(WebTestRunner::WebTestProxyBase::willRequestResource):
(WebTestRunner::WebTestProxyBase::didCreateDataSource):
(WebTestRunner::WebTestProxyBase::willSendRequest):
(WebTestRunner::WebTestProxyBase::didReceiveResponse):
(WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
(WebTestRunner::WebTestProxyBase::didFailResourceLoad):
(WebTestRunner::WebTestProxyBase::runModalBeforeUnloadDialog):
(WebTestRunner::WebTestProxyBase::locationChangeDone):
(WebTestRunner::WebTestProxyBase::decidePolicyForNavigation):
(WebTestRunner::WebTestProxyBase::willCheckAndDispatchMessageEvent):

2:13 AM Changeset in webkit [141877] by mkwst@chromium.org
  • 15 edits in trunk/Source/WebCore

Cleanup: Use exceptionless Range::* methods rather than ignoring exceptions.
https://bugs.webkit.org/show_bug.cgi?id=108773

Reviewed by Darin Adler.

We often call Range::{start,end}{Container,Offset} with an ExceptionCode
that's completely ignored. In these cases, we should simply use the
exceptionless version of the method instead.

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::addMarker):

Here, I also moved parameters onto one line to make the
stylebot happy.

(WebCore::DocumentMarkerController::addTextMatchMarker):
(WebCore::DocumentMarkerController::setMarkersActive):

Dropped ignored ExceptionCode variable entirely.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::visiblePositionForIndex):

Can't drop the variable because of the selectNodeContents call.

  • editing/Editor.cpp:

(WebCore::Editor::canDeleteRange):

Dropped ignored ExceptionCode variable entirely.

(WebCore::Editor::advanceToNextMisspelling):

Can't drop the variable because of setStart/setEnd.

  • editing/EditorCommand.cpp:

(WebCore::unionDOMRanges):

Can't drop the variable because of compareBoundaryPoints.

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendNodeValue):

Dropped ignored ExceptionCode variable entirely.

  • editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingParagraph::offsetAsRange):
(WebCore::TextCheckingHelper::findFirstMisspelling):
(WebCore::TextCheckingHelper::findFirstGrammarDetail):
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::renderedText):
(WebCore::StyledMarkupAccumulator::stringValueForRange):

Dropped ignored ExceptionCode variable entirely.

  • editing/visible_units.cpp:

(WebCore::previousBoundary):

Can't drop the variable due to many other calls.

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::deleteFromDocument):
(WebCore::DOMSelection::containsNode):

For both these cases, the 'ASSERT(!ec)' after the statement I've
edited only checked the last occurance of the exception: that is,
if 'startXxx(ec)' threw an exception, it would be overwritten by
the 'setBaseAndExtend()' or 'compareBoundaryPoints()' exception.
Removing the exception parameters from the parameters' calls
shouldn't effect behavior.

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeSelection):

  • platform/mac/HTMLConverter.mm:

(+[WebHTMLConverter editingAttributedStringFromRange:]):

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::writeRange):

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeSelection):

  • platform/wince/PasteboardWinCE.cpp:

(WebCore::Pasteboard::writeSelection):

Dropped ignored ExceptionCode variable entirely.

2:10 AM Changeset in webkit [141876] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: introduce Memory.getDOMCounters
https://bugs.webkit.org/show_bug.cgi?id=108822

Reviewed by Pavel Feldman.

Introduced Memory.getDOMCounters command that returns number of Documents, Nodes
and JS event listeners in the inspected process.

  • inspector/Inspector.json:
  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getDOMCounters):
(WebCore):

  • inspector/InspectorMemoryAgent.h:

(InspectorMemoryAgent):

1:57 AM Changeset in webkit [141875] by kadam@inf.u-szeged.hu
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt][Wk2] Unreviewed gardening. Added platform specific expected.

  • platform/qt-5.0-wk2/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Update after r141459.
  • platform/qt-5.0-wk2/http/tests/cache/cancel-multiple-post-xhrs-expected.txt: Added update after r140174.
1:37 AM Changeset in webkit [141874] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: rename Image m_data member to m_encodedImageData for the consistency
https://bugs.webkit.org/show_bug.cgi?id=108913

Reviewed by Yury Semikhatsky.

No new tests because no API changes.

  • platform/graphics/Image.cpp:

(WebCore::Image::setData):
(WebCore::Image::reportMemoryUsage):

  • platform/graphics/Image.h:

(WebCore::Image::data):
(Image):

1:19 AM Changeset in webkit [141873] by morrita@google.com
  • 3 edits in trunk/Source/WebCore

Unreviewed Linux ASAN build fix for r141783.

  • platform/RefCountedSupplement.h:

(Wrapper):

  • platform/Supplementable.h:

(Supplement):

1:13 AM Changeset in webkit [141872] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Unreviewed: Fix broken SVG-disabled build.
https://bugs.webkit.org/show_bug.cgi?id=108916

The new enum value CSSPropertyWebkitGridAutoFlow was introduced in
r141787, and accidentally left out of CSSParser::parseValue's big
switch. This causes problems in non-SVG builds.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

1:10 AM Changeset in webkit [141871] by tommyw@google.com
  • 13 edits
    3 deletes in trunk

MediaStream API: Update RTCPeerConnections stream accessors to match the latest specification
https://bugs.webkit.org/show_bug.cgi?id=108179

Reviewed by Adam Barth.

Source/WebCore:

http://dev.w3.org/2011/webrtc/editor/webrtc.html#interface-definition
The attributes localStreams and remoteStreams have been changes to the methods
getLocalStreams() and getRemoteStreams() which return a native array instead.

Existing tests updated to cover patch.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/MediaStream.h:

(WebCore):

  • Modules/mediastream/MediaStreamList.cpp: Removed.
  • Modules/mediastream/MediaStreamList.h: Removed.
  • Modules/mediastream/MediaStreamList.idl: Removed.
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::addStream):
(WebCore::RTCPeerConnection::removeStream):
(WebCore::RTCPeerConnection::getLocalStreams):
(WebCore::RTCPeerConnection::getRemoteStreams):
(WebCore::RTCPeerConnection::didAddRemoteStream):
(WebCore::RTCPeerConnection::didRemoveRemoteStream):

  • Modules/mediastream/RTCPeerConnection.h:

(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • WebCore.gypi:

LayoutTests:

Updating tests for RTCPeerConnections new stream accessors.

  • fast/mediastream/RTCPeerConnection-AddRemoveStream-expected.txt:
  • fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
  • fast/mediastream/RTCPeerConnection-statsSelector-expected.txt:
  • fast/mediastream/RTCPeerConnection-statsSelector.html:
1:07 AM Changeset in webkit [141870] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt][EFL][WebGL] Webgl doesn't work on nvidia cards
https://bugs.webkit.org/show_bug.cgi?id=108059

Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2013-02-05
Reviewed by Kenneth Rohde Christiansen.

Commit r138327 fixed repainting issues on mesa3d GL library by re-binding
texture to the window after every glXSwapBuffer. Unfortunatelly re-bind
breaks rendering on NVidia cards with NVidia propiertary drivers.
This change limits texture re-binding only for mesa3d GL library.

No new tests. HW specific fix.

  • platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:

(WebCore::OffScreenRootWindow::isMesaGLX):
(OffScreenRootWindow):
(WebCore::GraphicsSurface::platformSwapBuffers):

1:05 AM Changeset in webkit [141869] by shinyak@chromium.org
  • 3 edits in trunk/LayoutTests

touch-event.html should check touchstartFiredInShadowDOM is true.
https://bugs.webkit.org/show_bug.cgi?id=108910

Reviewed by Hajime Morita.

We have to check touchstartFiredInShadowDOM is true so that we can assure touch event is in ShadowDOM.
This is a follow-up patch for http://trac.webkit.org/changeset/141054

  • fast/dom/shadow/touch-event-expected.txt:
  • fast/dom/shadow/touch-event.html:
12:55 AM Changeset in webkit [141868] by Martin Robinson
  • 4 edits in trunk

Update the NEWS and configuration in preparation for 1.11.5.

Reviewed by Philippe Normand.

.:

  • configure.ac:

Source/WebKit/gtk:

  • NEWS:
12:39 AM Changeset in webkit [141867] by commit-queue@webkit.org
  • 6 edits in trunk

Floating point precision error in AudioPannerNode.
https://bugs.webkit.org/show_bug.cgi?id=106001

Patch by Praveen Jadhav <praveen.j@samsung.com> on 2013-02-05
Reviewed by Kentaro Hara.

Specifications Update:
https://dvcs.w3.org/hg/audio/rev/69a39a516e45

Source/WebCore:

Conversion from double to float and back to double
results in precision error. Avoiding these conversions
will make sure that proper values are retained in the
parameters.

  • Modules/webaudio/PannerNode.h:

(WebCore::PannerNode::refDistance):
(WebCore::PannerNode::setRefDistance):
(WebCore::PannerNode::maxDistance):
(WebCore::PannerNode::setMaxDistance):
(WebCore::PannerNode::rolloffFactor):
(WebCore::PannerNode::setRolloffFactor):
(WebCore::PannerNode::coneInnerAngle):
(WebCore::PannerNode::setConeInnerAngle):
(WebCore::PannerNode::coneOuterAngle):
(WebCore::PannerNode::setConeOuterAngle):
(WebCore::PannerNode::coneOuterGain):
(WebCore::PannerNode::setConeOuterGain):

  • Modules/webaudio/PannerNode.idl:

LayoutTests:

New test scenarios are added to verify precision
error issues in PannerNode.

  • webaudio/pannernode-basic-expected.txt:
  • webaudio/pannernode-basic.html:
12:31 AM Changeset in webkit [141866] by tkent@chromium.org
  • 13 edits in trunk

INPUT_MULTIPLE_FIELDS_UI: Use disabled attribute internally instead of readonly attribute
https://bugs.webkit.org/show_bug.cgi?id=108911

Reviewed by Kentaro Hara.

Source/WebCore:

Use 'disabled' attribute for shadow elements for <input> with
multiple-fields UI instead of 'readonly' attribute because 'readonly'
attribute represents focusable-but-non-editable state in HTML though
we'd like to represent non-focusable-and-non-editable state.

The summary of changes:

  • Use 'disabled' attribute instead of 'readonly' attribute for DateTimeFieldElement,
  • Rename C++ functions for it,
  • Call isFocusable instead of isReadOnly to check focusable state.

No new tests. This doesn't make user-visible behavior changes.

  • css/html.css:

Replace [readonly] with [disabled] for sub-fields.

  • html/shadow/DateTimeEditElement.cpp:

(DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::visitField):
(WebCore::DateTimeEditBuilder::shouldDayOfMonthFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldHourFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldMillisecondFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldMinuteFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldSecondFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldYearFieldDisabled):
(WebCore::DateTimeEditElement::anyEditableFieldsHaveValues):
(WebCore::DateTimeEditElement::focusOnNextField): Use isFocusable.
(WebCore::DateTimeEditElement::focusOnPreviousField): Use isFocusable.

  • html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::isFocusable):
(WebCore::DateTimeFieldElement::isDisabled):
(WebCore::DateTimeFieldElement::setDisabled):

  • html/shadow/DateTimeFieldElement.h:

(DateTimeFieldElement): Make isFocusable public in order that
DateTimeEditElement can call it.

  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::handleKeyboardEvent):
(WebCore::DateTimeNumericFieldElement::setEmptyValue):

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::setEmptyValue):

LayoutTests:

  • fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html:
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html:
  • fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield.html:
  • fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html:
  • fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield.html:
12:20 AM Changeset in webkit [141865] by haraken@chromium.org
  • 20 edits in trunk/Source

[V8] Reduce usage of deprecatedString() and deprecatedInteger()
https://bugs.webkit.org/show_bug.cgi?id=108909

Reviewed by Adam Barth.

Source/WebCore:

By passing an Isolate parameter around, we can reduce usage of
deprecated methods.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter):
(GenerateEventListenerCallback):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::addEventListenerCallback):
(WebCore::TestEventTargetV8Internal::removeEventListenerCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::addEventListenerCallback):
(WebCore::TestObjV8Internal::removeEventListenerCallback):

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::get):
(WebCore::set):
(WebCore::getNthValueOnKeyPath):
(WebCore::canInjectNthValueOnKeyPath):
(WebCore::ensureNthValueOnKeyPath):
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::canInjectIDBKeyIntoScriptValue):

  • bindings/v8/NPV8Object.cpp:

(WebCore::createValueListFromVariantArgs):
(_NPN_Invoke):
(_NPN_InvokeDefault):
(_NPN_SetProperty):
(_NPN_Construct):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::compileAndRunScript):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore):
(WebCore::ScriptProfiler::takeHeapSnapshot):

  • bindings/v8/ScriptSourceCode.cpp:

(WebCore::ScriptSourceCode::compileScript):

  • bindings/v8/ScriptSourceCode.h:

(ScriptSourceCode):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):

  • bindings/v8/V8NPUtils.cpp:

(WebCore::convertNPVariantToV8Object):

  • bindings/v8/V8NPUtils.h:

(WebCore):

  • bindings/v8/V8Utilities.cpp:

(WebCore::createHiddenDependency):
(WebCore::removeHiddenDependency):
(WebCore::transferHiddenDependency):

  • bindings/v8/V8Utilities.h:

(WebCore):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::addEventListenerCallback):
(WebCore::V8DOMWindow::removeEventListenerCallback):

Source/WebKit/chromium:

No tests. No change in behavior.

  • src/WebBindings.cpp:

(WebKit::WebBindings::toV8Value):

12:03 AM Changeset in webkit [141864] by dino@apple.com
  • 14 edits
    2 moves
    1 add
    1 delete in trunk

[Mac] Captions menu should indicate language and type of track
https://bugs.webkit.org/show_bug.cgi?id=108882

Reviewed by Eric Carlson.

Source/WebCore:

On Mac, we want a specific format for menu items in a caption list. Since
other ports might want different formats, move the generation of the label
into CaptionsUserPreferences where it can be overridden.

This required CaptionsUserPreferences to become public on the PageGroup, so
it could be used when creating the menu. Also, since CaptionsUserPreferences
was hidden on Mountain Lion and below, be a little more specific about
which pieces can be seen on which builds.

Covered by existing media/video-controls-captions-trackmenu tests.

  • English.lproj/Localizable.strings: Remove textTrackClosedCaptionsText.
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu): Build only

one section and get the track's display name from the user preferences.

  • page/CaptionUserPreferences.h:

(WebCore::CaptionUserPreferences::displayNameForTrack): Default implementation of

virtual function that provides a label for a captions menu item.

  • page/CaptionUserPreferencesMac.h: Add the new virtual function, and expose just

a bit of this class outside 10.9 builds.

  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::CaptionUserPreferencesMac): Guard features for system version.
(WebCore::CaptionUserPreferencesMac::~CaptionUserPreferencesMac): Ditto.
(WebCore::CaptionUserPreferencesMac::displayNameForTrack): New OS X-specific method that

returns a string for the menu label.

  • page/PageGroup.cpp:

(WebCore::PageGroup::captionPreferences): Unguard for system version.

  • page/PageGroup.h: Make captionPreferences public.
  • platform/LocalizedStrings.cpp: Remove textTrackClosedCaptionsText - not needed any more.
  • platform/LocalizedStrings.h: Remove textTrackClosedCaptionsText.

LayoutTests:

Now that the captions menu can be labelled in a platform-specific way, move
the results into the platform directory. At the moment, they are skipped
everywhere but Mac. Also update the tests to the new menu structure, which
only has a single list of entries.

  • media/video-controls-captions-trackmenu-localized.html: Updated for new menu structure.
  • media/video-controls-captions-trackmenu-expected.txt: Removed.
  • media/video-controls-captions-trackmenu-localized-expected.txt: Removed.
  • media/video-controls-captions-trackmenu-sorted-expected.txt: Removed.
  • media/video-controls-captions-trackmenu-sorted.html: Updated for new menu structure.
  • media/video-controls-captions-trackmenu.html: Updated for new menu structure.
  • platform/mac/media/video-controls-captions-trackmenu-expected.txt: New platform specific results.
  • platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt: Ditto.
  • platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt: Ditto.
12:00 AM Changeset in webkit [141863] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

EWS bots don't remove untracked files after processing a patch
https://bugs.webkit.org/show_bug.cgi?id=108891

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-04
Reviewed by Adam Barth.

Added option to remove untracked files in the bot's repo.

  • EWSTools/start-queue.sh:

Feb 4, 2013:

11:39 PM Changeset in webkit [141862] by haraken@chromium.org
  • 31 edits in trunk/Source/WebCore

[V8] Pass an Isolate to V8DOMConfiguration
https://bugs.webkit.org/show_bug.cgi?id=108900

Reviewed by Adam Barth.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateToV8Converters):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::createWrapper):

  • bindings/scripts/test/V8/V8Float64Array.h:

(WebCore::V8Float64Array::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::createWrapper):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::V8TestActiveDOMObject::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::createWrapper):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::V8TestCustomNamedGetter::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::createWrapper):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::V8TestEventConstructor::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::createWrapper):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::V8TestEventTarget::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::createWrapper):

  • bindings/scripts/test/V8/V8TestException.h:

(WebCore::V8TestException::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::createWrapper):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::V8TestInterface::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
(WebCore::V8TestMediaQueryListListener::createWrapper):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::V8TestMediaQueryListListener::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::ConfigureV8TestNamedConstructorTemplate):
(WebCore::V8TestNamedConstructor::createWrapper):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::V8TestNamedConstructor::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::ConfigureV8TestNodeTemplate):
(WebCore::V8TestNode::createWrapper):

  • bindings/scripts/test/V8/V8TestNode.h:

(WebCore::V8TestNode::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextProperties):
(WebCore::V8TestObj::createWrapper):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::createWrapper):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(WebCore::V8TestOverloadedConstructors::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::createWrapper):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::V8TestSerializedScriptValueInterface::installPerContextProperties):

  • bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::batchConfigureAttributes):
(WebCore::V8DOMConfiguration::batchConfigureConstants):
(WebCore::V8DOMConfiguration::batchConfigureCallbacks):
(WebCore::V8DOMConfiguration::configureTemplate):

  • bindings/v8/V8DOMConfiguration.h:

(V8DOMConfiguration):
(WebCore::V8DOMConfiguration::configureAttribute):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow):

11:28 PM Changeset in webkit [141861] by morrita@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, skipping heap-snapshot-with-detached-dom-tree.html

  • platform/chromium/TestExpectations:
10:53 PM Changeset in webkit [141860] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Clean up CodeGeneratorV8.pm by introducing HasCustom{Getter,Setter,Method}
https://bugs.webkit.org/show_bug.cgi?id=108896

Reviewed by Adam Barth.

No tests. No change in generated code.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(HasCustomGetter):
(HasCustomSetter):
(HasCustomMethod):
(GetFunctionTemplateCallbackName):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(RequiresCustomSignature):

10:35 PM Changeset in webkit [141859] by morrita@google.com
  • 1 edit
    6 adds in trunk/LayoutTests

[Chromium] Unreviewed rebaselining.

  • platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt: Added.
  • platform/chromium-linux/compositing/overflow/updating-scrolling-content-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/scrolling-without-painting-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/updating-scrolling-content-expected.txt: Added.
10:20 PM Changeset in webkit [141858] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

Fix crash by <select> type change on focus
https://bugs.webkit.org/show_bug.cgi?id=108830

Reviewed by Abhishek Arya.

Source/WebCore:

Test: fast/forms/select/select-change-type-on-focus.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
focus() calls may change the renderer type.

LayoutTests:

  • fast/forms/select/select-change-type-on-focus-expected.txt: Added.
  • fast/forms/select/select-change-type-on-focus.html: Added.
10:08 PM Changeset in webkit [141857] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

[V8] Pass an Isolate to opaqueRootForGC()
https://bugs.webkit.org/show_bug.cgi?id=108886

Reviewed by Adam Barth.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateOpaqueRootForGC):
(GenerateHeader):

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::opaqueRootForGC):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WebCore::WrapperTypeInfo::opaqueRootForGC):

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::opaqueRootForGC):

9:56 PM Changeset in webkit [141856] by haraken@chromium.org
  • 7 edits in trunk/LayoutTests

Add missing tests for default values of event constructors
https://bugs.webkit.org/show_bug.cgi?id=108885

Reviewed by Adam Barth.

Spec: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-keyboardevent

  • fast/events/constructors/keyboard-event-constructor-expected.txt:
  • fast/events/constructors/keyboard-event-constructor.html:
  • fast/events/constructors/mouse-event-constructor-expected.txt:
  • fast/events/constructors/mouse-event-constructor.html:
  • fast/events/constructors/wheel-event-constructor-expected.txt:
  • fast/events/constructors/wheel-event-constructor.html:
9:22 PM Changeset in webkit [141855] by Gregg Tavares
  • 1 edit
    65 adds in trunk/LayoutTests

Add Support Files for WebGL Conformance Tests
https://bugs.webkit.org/show_bug.cgi?id=108731

Reviewed by Kenneth Russell.

These are the 'resource' files for the WebGL
Conformance Tests. Other CLs will add the
actual tests.

  • webgl/resources/webgl_test_files/conformance/resources/3x3.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/blue-1x1.jpg: Added.
  • webgl/resources/webgl_test_files/conformance/resources/boolUniformShader.vert: Added.
  • webgl/resources/webgl_test_files/conformance/resources/bug-32888-texture.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/floatUniformShader.vert: Added.
  • webgl/resources/webgl_test_files/conformance/resources/fragmentShader.frag: Added.
  • webgl/resources/webgl_test_files/conformance/resources/glsl-conformance-test.js: Added.

(GLSLConformanceTester):

  • webgl/resources/webgl_test_files/conformance/resources/glsl-feature-tests.css: Added.

(canvas):
(.shader-source):
(.shader-source li:nth-child(odd)):
(.shader-source li:nth-child(even)):
(.testimages):
(.testimages br):
(.testimages > div):
(IMG):

  • webgl/resources/webgl_test_files/conformance/resources/glsl-generator.js: Added.

(GLSLGenerator.):
(GLSLGenerator):

  • webgl/resources/webgl_test_files/conformance/resources/gray-ramp-256-with-128-alpha.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/gray-ramp-256.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/gray-ramp-default-gamma.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/gray-ramp-gamma0.1.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/gray-ramp-gamma1.0.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/gray-ramp-gamma2.0.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/gray-ramp-gamma4.0.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/gray-ramp-gamma9.0.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/gray-ramp.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/green-2x2-16bit.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/intArrayUniformShader.vert: Added.
  • webgl/resources/webgl_test_files/conformance/resources/intUniformShader.vert: Added.
  • webgl/resources/webgl_test_files/conformance/resources/matUniformShader.vert: Added.
  • webgl/resources/webgl_test_files/conformance/resources/noopUniformShader.frag: Added.
  • webgl/resources/webgl_test_files/conformance/resources/noopUniformShader.vert: Added.
  • webgl/resources/webgl_test_files/conformance/resources/npot-video.mp4: Added.
  • webgl/resources/webgl_test_files/conformance/resources/npot-video.theora.ogv: Added.
  • webgl/resources/webgl_test_files/conformance/resources/npot-video.webmvp8.webm: Added.
  • webgl/resources/webgl_test_files/conformance/resources/ogles-tests.css: Added.

(canvas):
(.shader-source):
(.shader-source li:nth-child(odd)):
(.shader-source li:nth-child(even)):
(.testimages):
(.testimages br):
(.testimages > div):
(IMG):

  • webgl/resources/webgl_test_files/conformance/resources/pnglib.js: Added.

(.):

  • webgl/resources/webgl_test_files/conformance/resources/red-green.mp4: Added.
  • webgl/resources/webgl_test_files/conformance/resources/red-green.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/red-green.theora.ogv: Added.
  • webgl/resources/webgl_test_files/conformance/resources/red-green.webmvp8.webm: Added.
  • webgl/resources/webgl_test_files/conformance/resources/red-indexed.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/samplerUniformShader.frag: Added.
  • webgl/resources/webgl_test_files/conformance/resources/small-square-with-cie-rgb-profile.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/small-square-with-colormatch-profile.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/small-square-with-colorspin-profile.jpg: Added.
  • webgl/resources/webgl_test_files/conformance/resources/small-square-with-colorspin-profile.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/small-square-with-e-srgb-profile.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/small-square-with-smpte-c-profile.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/small-square-with-srgb-iec61966-2.1-profile.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/structUniformShader.vert: Added.
  • webgl/resources/webgl_test_files/conformance/resources/tex-image-and-sub-image-2d-with-canvas.js: Added.

(.init):
(.setCanvasToRedGreen):
(.drawTextInCanvas):
(.setCanvasTo257x257):
(.setCanvasTo1x2):
(.else):
(.runOneIteration):
(.runTest.runNextTest):
(.runTest):
(generateTest):

  • webgl/resources/webgl_test_files/conformance/resources/tex-image-and-sub-image-2d-with-image-data.js: Added.

(.init):
(.runOneIteration):
(.runTest):
(generateTest):

  • webgl/resources/webgl_test_files/conformance/resources/tex-image-and-sub-image-2d-with-image.js: Added.

(.init):
(.runOneIteration):
(.runTestOnImage):
(.runTest.newImage.onload):
(.runTest):
(.runTest2.newImage.onload):
(.runTest2):
(.runTest3):
(generateTest):

  • webgl/resources/webgl_test_files/conformance/resources/tex-image-and-sub-image-2d-with-video.js: Added.

(debug):
(.init):
(.runOneIteration):
(.runTest):

  • webgl/resources/webgl_test_files/conformance/resources/vertexShader.vert: Added.
  • webgl/resources/webgl_test_files/conformance/resources/webgl-test-utils.js: Added.

(WebGLTestUtils):
(WebGLTestUtils.):

  • webgl/resources/webgl_test_files/conformance/resources/webgl-test.js: Added.

(webglTestLog):
(getGLErrorAsString):
(shouldGenerateGLError):
(glErrorShouldBe):

  • webgl/resources/webgl_test_files/conformance/resources/zero-alpha.png: Added.
  • webgl/resources/webgl_test_files/resources/desktop-gl-constants.js: Added.
  • webgl/resources/webgl_test_files/resources/js-test-post.js: Added.
  • webgl/resources/webgl_test_files/resources/js-test-pre.js: Added.

(.):
(reportTestResultsToHarness):
(notifyFinishedToHarness):
(description):
(debug):
(escapeHTML):
(testPassed):
(testFailed):
(areArraysEqual):
(isMinusZero):
(isResultCorrect):
(stringify):
(evalAndLog):
(shouldBe):
(shouldNotBe):
(shouldBeTrue):
(shouldBeFalse):
(shouldBeNaN):
(shouldBeNull):
(shouldBeEqualToString):
(shouldEvaluateTo):
(shouldBeNonZero):
(shouldBeNonNull):
(shouldBeUndefined):
(shouldBeDefined):
(shouldBeGreaterThanOrEqual):
(expectTrue):
(shouldThrow):
(assertMsg):
(gc.gcRec):
(gc):
(finishTest.epilogue.onload):
(finishTest):

  • webgl/resources/webgl_test_files/resources/js-test-style.css: Added.

(.pass):
(.fail):
(#console):

  • webgl/resources/webgl_test_files/resources/test-eval.js: Added.

(TestEval):

  • webgl/resources/webgl_test_files/resources/webgl-logo.png: Added.
  • webgl/resources/webgl_test_files/resources/webgl-test-harness.js: Added.

(WebGLTestHarnessModule.log):
(WebGLTestHarnessModule.try.request.onreadystatechange):
(WebGLTestHarnessModule.loadTextFileAsynchronous):
(WebGLTestHarnessModule.greaterThanOrEqualToVersion):
(WebGLTestHarnessModule.copyObject):
(WebGLTestHarnessModule.toCamelCase):
(WebGLTestHarnessModule.):
(WebGLTestHarnessModule.getFileListImpl):
(WebGLTestHarnessModule.var):
(WebGLTestHarnessModule.getFileList):
(WebGLTestHarnessModule.FilterURL):
(WebGLTestHarnessModule.TestFile):
(WebGLTestHarnessModule.Test):
(WebGLTestHarnessModule.TestHarness):
(WebGLTestHarnessModule.TestHarness.prototype.addFiles_):
(WebGLTestHarnessModule.TestHarness.prototype.runTests):
(WebGLTestHarnessModule.TestHarness.prototype.setTimeout):
(WebGLTestHarnessModule.TestHarness.prototype.clearTimeout):
(WebGLTestHarnessModule.TestHarness.prototype.startNextTest):
(WebGLTestHarnessModule.TestHarness.prototype.startTest):
(WebGLTestHarnessModule.TestHarness.prototype.getTest):
(WebGLTestHarnessModule.TestHarness.prototype.reportResults):
(WebGLTestHarnessModule.TestHarness.prototype.dequeTest):
(WebGLTestHarnessModule.TestHarness.prototype.notifyFinished):
(WebGLTestHarnessModule.TestHarness.prototype.timeout):
(WebGLTestHarnessModule.TestHarness.prototype.setTimeoutDelay):
(WebGLTestHarnessModule):

  • webgl/resources/webkit-webgl-test-harness.js: Added.

(.):

9:11 PM Changeset in webkit [141854] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r180583. Requested by
"Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-04

  • DEPS:
8:45 PM Changeset in webkit [141853] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Coordinated Graphics : disconnectCustomFilterProgram does not do anything.
https://bugs.webkit.org/show_bug.cgi?id=108807

Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2013-02-04
Reviewed by Anders Carlsson.

We need to add newly created WebCustomFilterProgramProxy to a hashset to
disconnect when CoordinatedLayerTreeHost gets destructed.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::checkCustomFilterProgramProxies):

8:40 PM Changeset in webkit [141852] by morrita@google.com
  • 4 edits
    4 copies
    2 moves
    5 adds in trunk/LayoutTests

[Chromium] Unreviewed rebaselining for r141769.

  • platform/chromium-mac-lion/compositing/overflow/nested-scrolling-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/nested-scrolling-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/overflow/nested-scrolling-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/nested-scrolling-expected.png: Added.
  • platform/chromium-mac/compositing/overflow/nested-scrolling-expected.png:
  • platform/chromium-mac/compositing/overflow/textarea-scroll-touch-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/nested-scrolling-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/textarea-scroll-touch-expected.txt: Added.
  • platform/chromium/compositing/overflow/scrolling-without-painting-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt.
  • platform/chromium/compositing/overflow/updating-scrolling-content-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt.
  • platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt.
  • platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt.
  • platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/scrolling-without-painting-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt.
  • platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/updating-scrolling-content-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt.
8:30 PM Changeset in webkit [141851] by james.wei@intel.com
  • 2 edits in trunk/Source/WebCore

Heap-buffer-overflow in WebCore::AudioBufferSourceNode::process
https://bugs.webkit.org/show_bug.cgi?id=108515

After calling setBuffer() with a buffer having a different number of
channels, there can in rare cases be a slight delay before the output
bus is updated to the new number of channels because of use of
tryLocks() in the context's updating system.
In this case, if the the buffer has just been changed and we're
not quite ready yet then just output silence.

Reviewed by Chris Rogers.

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::renderFromBuffer):

8:23 PM Changeset in webkit [141850] by simonjam@chromium.org
  • 8 edits in trunk/Source

[Chromium] Add a signal for when the body is inserted in the document
https://bugs.webkit.org/show_bug.cgi?id=108725

Reviewed by Adam Barth.

Source/WebCore:

This is an important signal for resource scheduling. We know we have enough to paint something,
so we can start kicking off image preloads.

Test: Chromium webkit_unit_tests

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLBodyElement):

  • loader/FrameLoaderClient.h:

(FrameLoaderClient):
(WebCore::FrameLoaderClient::dispatchWillInsertBody):

Source/WebKit/chromium:

  • public/WebFrameClient.h:

(WebFrameClient):
(WebKit::WebFrameClient::willInsertBody):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchWillInsertBody):
(WebKit):

  • src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

  • tests/WebFrameTest.cpp:
8:21 PM Changeset in webkit [141849] by benjamin@webkit.org
  • 47 edits in trunk

Kill suspendAnimation(), resumeAnimation() and numberOfActiveAnimations() from DRT/WTR; use Internals
https://bugs.webkit.org/show_bug.cgi?id=108741

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-04
Reviewed by Tony Chang.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Move suspendAnimations and resumeAnimations to group all the animation related
code together.

Add support for numberOfActiveAnimations, similarily to the feature previously defined
in TestRunner.

  • testing/Internals.cpp:

(WebCore::Internals::numberOfActiveAnimations):
(WebCore):
(WebCore::Internals::suspendAnimations):
(WebCore::Internals::resumeAnimations):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

  • WebView/WebFrame.mm:
  • WebView/WebFramePrivate.h:

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

  • WebKit.vcproj/WebKitExports.def.in:

Source/WebKit2:

Suspending and resuming application has been useless for a one. Someone just
"forgot" WebKit2.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
  • WebProcess/WebPage/WebFrame.cpp:
  • WebProcess/WebPage/WebFrame.h:

(WebFrame):

Tools:

Remove all support for suspendAnimation(), resumeAnimation() and numberOfActiveAnimations().

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:
  • DumpRenderTree/gtk/TestRunnerGtk.cpp:
  • DumpRenderTree/mac/TestRunnerMac.mm:
  • DumpRenderTree/qt/TestRunnerQt.cpp:
  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

  • DumpRenderTree/win/TestRunnerWin.cpp:
  • DumpRenderTree/wx/TestRunnerWx.cpp:
  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Update the tests to use WebCore Internals instead of the TestRunner.

  • animations/animation-controller-drt-api.html:
  • transitions/hang-with-bad-transition-list.html:
  • transitions/remove-transition-style.html:
  • transitions/repeated-firing-background-color.html:
  • transitions/zero-duration-with-non-zero-delay-end.html:
8:02 PM Changeset in webkit [141848] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Implement runBeforeUnloadConfirmPanel on EFL
https://bugs.webkit.org/show_bug.cgi?id=106979

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-02-04
Reviewed by Benjamin Poulain.

Implement runBeforeUnloadConfirmPanel() to support window.onbeforeunload.
We can show confirmation window when beforeunload event is fired.

  • UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::PageUIClientEfl):
(WebKit::PageUIClientEfl::runBeforeUnloadConfirmPanel):
(WebKit):

  • UIProcess/efl/PageUIClientEfl.h:

(PageUIClientEfl):

7:42 PM Changeset in webkit [141847] by thakis@chromium.org
  • 3 edits in trunk/Tools

[chromium] Try to get WebKit building with enable_web_intents set to 0 on Windows too.
https://bugs.webkit.org/show_bug.cgi?id=108887

Reviewed by Kentaro Hara.

This is a follow-up to http://trac.webkit.org/changeset/141614. The
Mac and Linux linkers didn't complain about the reference to
WebIntent in that function for some reason (probably because it's
a dead function that's stripped).

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

7:30 PM Changeset in webkit [141846] by nayankk@motorola.com
  • 6 edits in trunk/Source/WebCore

[WEBGL] Rename WEBKIT_WEBGL_compressed_texture_s3tc to WEBGL_compressed_texture_s3tc
https://bugs.webkit.org/show_bug.cgi?id=108866

Reviewed by Kenneth Russell.

WEBGL_compressed_texture_s3tc is one of the community approved WebGL extension.
Hence remove the vendor prefix from WEBKIT_WEBGL_compressed_texture_s3tc.
Specification: http://www.khronos.org/registry/webgl/extensions/WEBGL_compressed_texture_s3tc/

No tests currently present to test WEBKIT_WEBGL_compressed_texture_s3tc.

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLCompressedTextureS3TC.cpp:

(WebCore::WebGLCompressedTextureS3TC::getName):

  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::getExtension):

7:28 PM Changeset in webkit [141845] by nayankk@motorola.com
  • 18 edits in trunk

[WEBGL] Rename WEBKIT_WEBGL_lose_context to WEBGL_lose_context.
https://bugs.webkit.org/show_bug.cgi?id=108694

Reviewed by Kenneth Russell.

WEBGL_lose_context is one of the community approved WebGL extension.
Hence remove the vendor prefix from WEBKIT_WEBGL_lose_context extension.
Spefication: http://www.khronos.org/registry/webgl/extensions/WEBGL_lose_context/

Source/WebCore:

Tests already exists, modified them to verify the change in extension name.

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLLoseContext.cpp:

(WebCore::WebGLLoseContext::getName):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

LayoutTests:

  • fast/canvas/webgl/WebGLContextEvent.html:
  • fast/canvas/webgl/context-destroyed-crash.html:
  • fast/canvas/webgl/context-lost-expected.txt:
  • fast/canvas/webgl/context-lost-restored.html:
  • fast/canvas/webgl/context-lost.html:
  • platform/chromium-linux-x86/fast/canvas/webgl/context-lost-expected.txt:
  • platform/chromium-linux/fast/canvas/webgl/context-lost-expected.txt:
  • platform/chromium-mac/fast/canvas/webgl/context-lost-expected.txt:
  • platform/chromium-win-xp/fast/canvas/webgl/context-lost-expected.txt:
  • platform/chromium-win/fast/canvas/webgl/context-lost-expected.txt:
  • platform/chromium/platform/chromium/virtual/gpu/fast/canvas/webgl/context-lost-expected.txt:
6:57 PM Changeset in webkit [141844] by dino@apple.com
  • 4 edits in trunk/Source/WebCore

Default element styles are not always collected for sharing detection
https://bugs.webkit.org/show_bug.cgi?id=108404

Reviewed by Antti Koivisto.

The method ensureDefaultStyleSheetsForElement is run as we add elements
to the document. This may update the defaultStyle of the document, but
does not recollect any changes into the StyleResolver. This means that
style sharing might be overly ambitious, thinking it can share a style
for an element which was matched in the new rules. This showed up most
often in the Shadow Root for media elements, which would add a set of
style rules, but the shadow children would sometimes share styles even
when they shouldn't.

The fix is to detect if we need to collect after adding a
style for an element. This might cause a little more work, but
in my testing it doesn't happen very often.

Unfortunately it is hard to get a reproducible test for this.

  • css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement): As we load in

styles, keep track of whether or not we change the default style.

  • css/CSSDefaultStyleSheets.h:

(CSSDefaultStyleSheets): New boolean parameter indicating if the style has changed.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForElement): Collect features if the element

caused the default style to update.

(WebCore::StyleResolver::collectFeatures): Protect for null in updates.

6:25 PM Changeset in webkit [141843] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the issue that some possible source formats are ignored for float textures in texture packing for CG port
https://bugs.webkit.org/show_bug.cgi?id=108812

Patch by Jun Jiang <jun.a.jiang@intel.com> on 2013-02-04
Reviewed by Kenneth Russell.

Already covered by latest WebGL conformance test.

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore):

6:12 PM Changeset in webkit [141842] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

[EFL] Remove needless local variables in LocalizedStringsEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=108869

Reviewed by Kentaro Hara.

fromUTF8() returns static String. So, we don't need to use needless local variables.

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::contextMenuItemTagCopy):
(WebCore::contextMenuItemTagDelete):
(WebCore::contextMenuItemTagSelectAll):
(WebCore::contextMenuItemTagGoBack):
(WebCore::contextMenuItemTagGoForward):
(WebCore::contextMenuItemTagStop):
(WebCore::contextMenuItemTagCut):
(WebCore::contextMenuItemTagPaste):
(WebCore::contextMenuItemTagBold):
(WebCore::contextMenuItemTagItalic):
(WebCore::contextMenuItemTagUnderline):

6:11 PM Changeset in webkit [141841] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

WebGL: Move the format conversion for 16-bit per channel formats into Core Graphics port only
https://bugs.webkit.org/show_bug.cgi?id=108304

Patch by Jun Jiang <jun.a.jiang@intel.com> on 2013-02-04
Reviewed by Kenneth Russell.

Since the 16-bit per channel formats are only used for Core Graphics port in WebGL and not a standard to represent any file format that is widely used
for each platform, it is better to limit and hide this kinds of information and processing in CG specific code only.
It can make the code more clear and reduce the binary size for both CG port and non-CG port.

Already covered by current tests.

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore):

  • platform/graphics/GraphicsContext3D.h:

(GraphicsContext3D):
(WebCore::GraphicsContext3D::srcFormatComeFromDOMElementOrImageData):
(ImageExtractor):

  • platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

6:01 PM Changeset in webkit [141840] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

Allow TextTracks to be marked as closed captions
https://bugs.webkit.org/show_bug.cgi?id=108856

Reviewed by Darin Adler.

While this isn't exposed directly in markup, some platform media frameworks can
provide indication that a caption track is a closed caption. Expose such a flag
on TextTrack and platforms can show a different UI if they want to.

No tests - this isn't used elsewhere yet, nor exposed to the DOM.

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Initialise new member.

  • html/track/TextTrack.h:

(WebCore::TextTrack::isClosedCaptions): New member variable.
(WebCore::TextTrack::setIsClosedCaptions):

5:46 PM Changeset in webkit [141839] by jparent@chromium.org
  • 6 edits in trunk/Tools

Dashboard cleanup: Make builder a real dashboardSpecificParameter.
https://bugs.webkit.org/show_bug.cgi?id=108706

Reviewed by Dirk Pranke.

Add builder to g_defaultDashboardSpecificParameter maps for the
dashboards where it is used (flakiness, timeline, treemap).
Default it to null, and then update reads of it to check the
builder group's default if one is not set, rather than trying to
set and track this everywhere.
This allows us to remove tons of special-casing of builder parsing,
including where we used to add it to the query string even when the
user did not specify it.

  • TestResultServer/static-dashboards/dashboard_base.js:

(parseParameters):

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(generatePage):
(handleQueryParameterChange):

  • TestResultServer/static-dashboards/loader.js:

(.):

  • TestResultServer/static-dashboards/timeline_explorer.html:
  • TestResultServer/static-dashboards/treemap.html:
5:30 PM Changeset in webkit [141838] by jparent@chromium.org
  • 2 edits in trunk/Tools

Setting tests on flakiness dashboard should invalidate builder.
https://bugs.webkit.org/show_bug.cgi?id=108521

Reviewed by Dirk Pranke.

When you move into a cross builder view, builder should not still be
set. Currently, it is deleted from the internal state, but still shows
up in the url, causing the current state and the hash to not match.

To see this in action, load the flakiness dashboard, select a builder,
and then click on an individual test, to get into individual test view.
The url will still have the builder you selected listed, even though it
is cleared in the UI.

The fix is to consider 'tests' to be a parameter that invalidates builder.

  • TestResultServer/static-dashboards/flakiness_dashboard.js:
5:27 PM Changeset in webkit [141837] by commit-queue@webkit.org
  • 34 edits
    1 add in trunk

Make moveCaretTowardsWindowPoint not snap to the beginning/end when moved above/below editable
https://bugs.webkit.org/show_bug.cgi?id=107850

Patch by Chris Hopman <cjhopman@chromium.org> on 2013-02-04
Reviewed by Ojan Vafai.

Source/WebCore:

On Android, EditingBehavior::shouldMoveCaret[...] controls the
behavior of insertion handles. This change adds a new Android specific
editing behavior type.

The new EditingBehavior is the same as EditingUnixBehavior except for
EditingBehavior::shouldMoveCaret[...]. This new behavior fixes
WebFrame::moveCaretTowardsWindowPoint to not span to the
beginning/end.

  • editing/EditingBehavior.h:

(WebCore::EditingBehavior::shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom):
(WebCore::EditingBehavior::shouldAllowSpellingSuggestionsWithoutSelection):
(WebCore::EditingBehavior::shouldNavigateBackOnBackspace):

  • editing/EditingBehaviorTypes.h:
  • page/Settings.cpp:

(WebCore):
(WebCore::editingBehaviorTypeForPlatform):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setEditingBehavior):

Source/WebKit/chromium:

On Android, EditingBehavior::shouldMoveCaret[...] controls the
behavior of insertion handles. This change adds a new Android specific
editing behavior type so that we can change these settings independent
of behavior for other platforms.

  • public/WebSettings.h:
  • src/AssertMatchingEnums.cpp:

Just add the corresponding assertion for the new editing behavior.

  • public/WebSettings.h:
  • src/AssertMatchingEnums.cpp:
  • tests/WebFrameTest.cpp:
  • tests/data/move_caret.html: Added.

Add a test that moveCaretTowardsWindowPoint works as expected on
Android.

LayoutTests:

Test the new "android" editing behavior in the following tests:

  • editing/deleting/delete-ligature-003-expected.txt:
  • editing/deleting/delete-ligature-003.html:
  • editing/deleting/paragraph-in-preserveNewline-expected.txt:
  • editing/deleting/paragraph-in-preserveNewline.html:
  • editing/deleting/whitespace-pre-1-expected.txt:
  • editing/deleting/whitespace-pre-1.html:
  • editing/execCommand/script-tests/toggle-compound-styles.js:
  • editing/execCommand/toggle-compound-styles-expected.txt:
  • editing/selection/5354455-1-expected.txt:
  • editing/selection/5354455-1.html:
  • editing/selection/click-in-margins-inside-editable-div-expected.txt:
  • editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt:
  • editing/selection/context-menu-text-selection-expected.txt:
  • editing/selection/context-menu-text-selection.html:
  • editing/selection/extend-after-mouse-selection-expected.txt:
  • editing/selection/extend-after-mouse-selection.html:
  • editing/selection/programmatic-selection-on-mac-is-directionless-expected.txt:
  • editing/selection/programmatic-selection-on-mac-is-directionless.html:
  • editing/selection/rtl-move-selection-right-left-expected.txt:
  • editing/selection/rtl-move-selection-right-left.html:
  • editing/selection/script-tests/click-in-margins-inside-editable-div.js:
  • editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js:
  • editing/selection/selection-extend-should-not-move-across-caret-on-mac-expected.txt:
  • editing/selection/selection-extend-should-not-move-across-caret-on-mac.html:
5:20 PM Changeset in webkit [141836] by kenneth@webkit.org
  • 16 edits
    2 adds in trunk

[EFL][WK2] Introduce a WebView class as counterpart for WKViewRef
https://bugs.webkit.org/show_bug.cgi?id=107931

Reviewed by Anders Carlsson.

Source/WebKit2:

This is just one step of the new plan for the EFL API.

The plan is to move the public EFL-like API on top of the shared
WK2 C API, plus a few EFL extensions (WKView class mostly).

The EFL-like API can be seen as a convenience API which ties
well into EFL and which makes it easy to add web experiences
to existing and new EFL applications. It provides a smart object
like API and a Evas_Object based view.

For more advanced use cases, such as browser and runtime, it is
possible to use the WK* C API, which is gives more flexibility
while being more low level.

The idea is that the WKView class will not depend on Evas_Object
and X11 (future plan) unlike the current EFL-like API. This should
make it possible to use it for cases where none of these are
available.

This patch introduces the WebView class which serves as our
counterpart for the WKView class, and adds a few needed methods.

The EwkView owns the WebView class (and will be constructing it
in the near future when the EwkView class has been changed to
handle all smart object related code)

The clean up of the smart object related code as the proper
construction of EwkView and WebView will be done in follow-up
patches.

  • UIProcess/API/C/efl/WKAPICastEfl.h:

(WebKit):

The WKView API is not based on WebView and not Evas_Object*

  • UIProcess/API/C/efl/WKView.cpp:

(WKViewCreate):
(WKViewCreateWithFixedLayout):
(WKViewInitialize):
(WKViewGetPage):
(WKViewSetThemePath):
(WKViewSuspendActiveDOMObjectsAndAnimations):
(WKViewResumeActiveDOMObjectsAndAnimations):
(WKViewGetEvasObject):
(WKViewCreateSnapshot):

Add a few new WKView EFL C methods, and update existing
methods to reflect that the WKViewRef is now a WebView*

The construction methods will be rewritten when the smart
object construction has been solved.

  • UIProcess/API/C/efl/WKView.h:
  • UIProcess/efl/WebView.cpp: Added.

(WebKit):
(WebKit::WebView::WebView):
(WebKit::WebView::~WebView):
(WebKit::WebView::initialize):
(WebKit::WebView::setThemePath):
(WebKit::WebView::suspendActiveDOMObjectsAndAnimations):
(WebKit::WebView::resumeActiveDOMObjectsAndAnimations):

  • UIProcess/efl/WebView.h: Added.

(WebKit):
(WebView):
(WebKit::WebView::pageRef):
(WebKit::WebView::evasObject):
(WebKit::WebView::page):
(WebKit::WebView::type):

Add a new WebKit::WebView class for EFL.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::~EwkView):
(EwkView::wkPage):
(EwkView::setThemePath):
(EwkView::createGLSurface):

Base methods on C API instead of internal API as much
as currently possible.

  • UIProcess/API/efl/EwkView.h:

(WebKit):
(WebView):
(EwkView):
(EwkView::wkView):
(EwkView::page):

  • UIProcess/API/efl/ewk_view.cpp:

(createEwkView):
(ewk_view_base_add):
(ewk_view_smart_add):

Modify to return the EwkView class for now.

  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

Updated due to changed API.

Tools:

Change platformView to be a WKView and use WKViewGetEvasObject
for the places where an Evas_Object is needed.

Instead of extracting the Ecore_Evas* from the m_view we use
the m_window instead, which actually holds the it.

  • TestWebKitAPI/PlatformWebView.h:
  • TestWebKitAPI/efl/PlatformWebView.cpp:

(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::PlatformWebView::page):
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
(TestWebKitAPI::PlatformWebView::simulateMouseMove):
(TestWebKitAPI::PlatformWebView::simulateRightClick):

  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp:

(WTR::EventSenderProxy::sendTouchEvent):
(WTR::EventSenderProxy::setTouchModifier):

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::~PlatformWebView):
(WTR::PlatformWebView::resizeTo):
(WTR::PlatformWebView::page):
(WTR::PlatformWebView::focus):
(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):
(WTR::PlatformWebView::windowSnapshotImage):

5:17 PM Changeset in webkit [141835] by tkent@chromium.org
  • 13 edits
    2 adds in trunk

INPUT_MULTIPLE_FIELDS_UI: Focus order is not controllable by tabIndex attribute on <input>
https://bugs.webkit.org/show_bug.cgi?id=108447

Reviewed by Hajime Morita.

Source/WebCore:

We make <input> elements with the multiple-fields UI focusable.

  • However, we don't want to change the existing focus behavior for multiple-fields <input>. We'd like to focus on the last sub-field of an<input> with Shift + TAB focus navigation, and focus on the first sub-field of the <input> otherwise. So, we move focus immediately after the <input> gets focus.
  • We don't need the isFocusableByClickOnLabel hack any more. <input> elements with the multiple-fields UI are mouse-focusable.

Test: fast/forms/time-multiple-fields/time-multiple-fields-tabindex.html

  • html/InputType.h:

(InputType): Add FocusDirection argument to handleFocusEvent, and remove
unnecessary isFocusableByClickOnLabel and focus.

  • html/InputType.cpp:

(WebCore::InputType::handleFocusEvent): Ditto.

  • html/PasswordInputType.cpp:

(WebCore::PasswordInputType::handleFocusEvent): Follow the argument change.

  • html/PasswordInputType.h:

(PasswordInputType): Ditto.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::handleFocusEvent):
If this element gets focus by FocusDirectionBackward (it means the focus
is moved from the first sub-field of the element,) move the focus
backward once more. Otherwise, we focus on the first sub-filed of the
element.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isKeyboardFocusable):
Make this keyboard-focusable. We have a wrong test to ensure read-only
input does NOT get focus. We'll address it later.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isMouseFocusable):
Make this mouse-focusable.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType):

  • html/HTMLInputElement.h:

(HTMLInputElement): Remove defaultFocus, focus, and isFocusableByClickOnLabel.
Add missing OVERRIDE to handleFocusEvent.

  • html/HTMLInputElement.cpp: Remove unnecessary functions.

(WebCore::HTMLInputElement::handleFocusEvent):
Pass FocusDirection value to InputTYpe::handleFocusEvent.

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::defaultEventHandler):
Use isMouseFocusable().

  • html/HTMLElement.cpp: Remove unnecessary isFocusableByClickOnLabel.
  • html/HTMLElement.h: Ditto.

LayoutTests:

  • fast/forms/time-multiple-fields/time-multiple-fields-tabindex-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-tabindex.html: Added.
5:13 PM Changeset in webkit [141834] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Set up the storage manager as a connection queue
https://bugs.webkit.org/show_bug.cgi?id=108879

Reviewed by Sam Weinig.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::processWillOpenConnection):
Add the storage manager as a connection queue client.

(WebKit::StorageManager::processWillCloseConnection):
Remove the storage manager.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::processWillOpenConnection):
Call the storage manager.

(WebKit::WebContext::processWillCloseConnection):
Call the storage manager.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::connectionWillOpen):
Call the context.

(WebKit::WebProcessProxy::connectionWillClose):
Call the context.

(WebKit::WebProcessProxy::didFinishLaunching):
Remove a comment.

4:54 PM Changeset in webkit [141833] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Coordinated Graphics: crash in TiledBackingStore::adjustForContentsRect
https://bugs.webkit.org/show_bug.cgi?id=107639

Patch by Seulgi Kim <seulgikim@company100.net> on 2013-02-04
Reviewed by Kenneth Rohde Christiansen.

In TiledBackingStore::adjustForContentsRect method, inflating is not
needed when there is no intersections between the cover/keep rect and
the content rect.

No new tests, no change in functionality.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::adjustForContentsRect):

4:46 PM Changeset in webkit [141832] by senorblanco@chromium.org
  • 3 edits in trunk/Source/WebCore

[skia] Remove use of SkSingleInputImageFilter.
https://bugs.webkit.org/show_bug.cgi?id=108867

Reviewed by James Robinson.

This class is but a hollow shell of its former self, and has
been removed in Skia.

Covered by existing tests in css3/filters.

  • platform/graphics/filters/skia/DropShadowImageFilter.cpp:

(WebCore::DropShadowImageFilter::DropShadowImageFilter):
(WebCore::DropShadowImageFilter::onFilterImage):

  • platform/graphics/filters/skia/DropShadowImageFilter.h:
4:39 PM Changeset in webkit [141831] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION (r129478-r129480): http/tests/loading/text-content-type-with-binary-extension.html failing on Apple MountainLion Debug WK2 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=98527

The bug was fixed but the test was never removed from the Mac WK2 TestExpectations file.
Remove it now.

  • platform/mac-wk2/TestExpectations:
4:34 PM Changeset in webkit [141830] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Send message when creating and destroying StorageAreaProxy objects
https://bugs.webkit.org/show_bug.cgi?id=108874

Reviewed by Sam Weinig.

  • Shared/SecurityOriginData.cpp:

(WebKit::SecurityOriginData::fromSecurityOrigin):

  • Shared/SecurityOriginData.h:

(SecurityOriginData):
Add helper function for creating a SecurityOriginData object given a WebCore::SecurityOrigin object.

  • WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::generateStorageAreaID):
New function to create a unique storage area ID.

(WebKit::StorageAreaProxy::StorageAreaProxy):
Send a CreateStorageArea message.

(WebKit::StorageAreaProxy::~StorageAreaProxy):
Send a DestroyStorageArea message.

(WebKit::StorageAreaProxy::contains):
Remove this assertion for now, it fires too often.

  • WebProcess/Storage/StorageNamespaceProxy.h:

(WebKit::StorageNamespaceProxy::storageNamespaceID):
Add getter.

4:30 PM Changeset in webkit [141829] by commit-queue@webkit.org
  • 7 edits in trunk/Tools

Don't update author info in PrepareChangeLog and allow users to skip the PrepareChangeLog step entirely.
https://bugs.webkit.org/show_bug.cgi?id=108788

Patch by Timothy Loh <timloh@chromium.com> on 2013-02-04
Reviewed by Ryosuke Niwa.

As per discussion in Bug 74358, it's probably preferable to remove the
behaviour of updating the author details in a ChangeLog entry. We also
want to be able to skip preparing change logs (e.g. rebaselining many
tests), so a --no-prepare-changelogs option is added to webkit-patch.

  • Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLogEntry._parse_entry):
(ChangeLogEntry.date): Added

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:

(test_parse_log_entries_from_changelog):

  • Scripts/webkitpy/tool/commands/commandtest.py:

(CommandsTest.assert_execute_outputs):

  • Scripts/webkitpy/tool/steps/options.py:

(Options): Added --no-prepare-changelogs

  • Scripts/webkitpy/tool/steps/preparechangelog.py:

(PrepareChangeLog.options):
(PrepareChangeLog._merge_entries): date_line() gets the entire line, including
the author's name and email, but we only want to replace the date.
(PrepareChangeLog.run):

  • Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:

(PrepareChangeLogTest.test_resolve_existing_entry): Added tests for changed
authors. Removed unneeded variable.

4:28 PM Changeset in webkit [141828] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

[ Linux ] Mark media/track/track-cues-cuechange.html and media/track/track-cues-enter-exit.html as slow
https://bugs.webkit.org/show_bug.cgi?id=108876

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-04
Reviewed by Dirk Pranke.

Tests take ~5.4 seconds to run locally.
Timing out on the EWS bots but passing on the Webkit buildbots.
Marked tests as slow in TestExpectations.

  • platform/chromium/TestExpectations:
3:57 PM Changeset in webkit [141827] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Use C API inside EwkView
https://bugs.webkit.org/show_bug.cgi?id=108825

Reviewed by Anders Carlsson.

A straight-forward port towards the C API.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView): Use C API for common default preferences.
(EwkView::wkPage): Make it const and remove useless comment.
(EwkView::deviceScaleFactor):
(EwkView::title):
(EwkView::customTextEncodingName):
(EwkView::setCustomTextEncodingName):
(EwkView::informURLChange):

  • UIProcess/API/efl/EwkView.h:

(EwkView):

3:55 PM Changeset in webkit [141826] by haraken@chromium.org
  • 10 edits in trunk

Implement WheelEvent::deltaMode
https://bugs.webkit.org/show_bug.cgi?id=108455

Reviewed by Adam Barth.

Source/WebCore:

Per the spec, WheelEvent::deltaMode should return
DOM_DELTA_PIXEL or DOM_DELTA_LINE or DOM_DELTA_PAGE.

Spec: http://www.w3.org/TR/DOM-Level-3-Events/#events-wheelevents
https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-wheelevent

Test: fast/event/wheel-event-constructor.html

  • dom/WheelEvent.cpp:

(WebCore::WheelEventInit::WheelEventInit):
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
(WebCore::deltaMode):

  • dom/WheelEvent.h:

(WheelEventInit):
(WebCore::WheelEvent::create):
(WebCore::WheelEvent::deltaMode):
(WheelEvent):

  • dom/WheelEvent.idl:
  • page/EventHandler.cpp:

(WebCore::wheelGranularityToScrollGranularity):

Source/WebKit/chromium:

  • src/WebInputEventConversion.cpp:

(WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):

LayoutTests:

Per the spec, WheelEvent::deltaMode should return
DOM_DELTA_PIXEL or DOM_DELTA_LINE or DOM_DELTA_PAGE.

Spec: http://www.w3.org/TR/DOM-Level-3-Events/#events-wheelevents
https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-wheelevent

  • fast/events/constructors/wheel-event-constructor-expected.txt:
  • fast/events/constructors/wheel-event-constructor.html:
3:54 PM Changeset in webkit [141825] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove an unnecessary sandbox rule.

Reviewed by Sam Weinig.

  • WebProcess/com.apple.WebProcess.sb.in: We already have a file-read rule for /Library/Managed Preferences, no need for another rule for something inside it.
3:24 PM Changeset in webkit [141824] by beidson@apple.com
  • 5 edits in trunk/Source/WebKit2

WebProcess crashes handling repeated NetworkProcess crashes.
<rdar://problem/13049867> and https://bugs.webkit.org/show_bug.cgi?id=108861

Reviewed by Alexey Proskuryakov.

  • Rename the concept of "unschedulable loader" to "internally failed loader"
  • When the NetworkProcess crashes, add all outstanding ResourceLoaders into the unschedulable pile.
  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::WebResourceLoadScheduler):
(WebKit::WebResourceLoadScheduler::scheduleLoad):
(WebKit::WebResourceLoadScheduler::scheduleInternallyFailedLoad):
(WebKit::WebResourceLoadScheduler::internallyFailedLoadTimerFired):
(WebKit::WebResourceLoadScheduler::remove): Also remove a non-helpful, out of date comment.
(WebKit::WebResourceLoadScheduler::networkProcessCrashed):

  • WebProcess/Network/WebResourceLoadScheduler.h:

WebResourceLoader no longer responds to crashes directly, but now exposes its WebCore ResourceLoader:

  • WebProcess/Network/WebResourceLoader.cpp:
  • WebProcess/Network/WebResourceLoader.h:

(WebKit::WebResourceLoader::resourceLoader):

3:23 PM Changeset in webkit [141823] by jochen@chromium.org
  • 14 edits
    5 deletes in trunk/Tools

[chromium] Remove WebEventSender and WebAccessibilityController from public TestRunner API
https://bugs.webkit.org/show_bug.cgi?id=108467

Reviewed by Adam Barth.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebAccessibilityController.h: Removed.
  • DumpRenderTree/chromium/TestRunner/public/WebEventSender.h: Removed.
  • DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebTestRunner):
(WebTestInterfaces):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestRunner):
(WebTestProxyBase):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):
(WebTestRunner::TestInterfaces::setWebView):
(WebTestRunner::TestInterfaces::webView):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebAccessibilityController.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/WebEventSender.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::setWebView):
(WebTestRunner::WebTestInterfaces::setDelegate):
(WebTestRunner::WebTestInterfaces::bindTo):
(WebTestRunner::WebTestInterfaces::resetAll):
(WebTestRunner::WebTestInterfaces::setTestIsRunning):
(WebTestRunner::WebTestInterfaces::webView):
(WebTestRunner::WebTestInterfaces::testRunner):
(WebTestRunner::WebTestInterfaces::testInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::setInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp: Removed.
  • DumpRenderTree/chromium/TestShell.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:
3:19 PM Changeset in webkit [141822] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore

[Soup] Remove duplicate setting of first party for cookies
https://bugs.webkit.org/show_bug.cgi?id=108814

Reviewed by Martin Robinson.

Covered by existing tests.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::createSoupMessageForHandleAndRequest): there is no need to set
the first party for cookies here, since that is already done in
ResourceRequest::updateSoupMessage, which is called a few lines before.

3:18 PM Changeset in webkit [141821] by kov@webkit.org
  • 7 edits in trunk/Source/WebCore

[GStreamer][Soup] Let GStreamer provide the buffer data is downloaded to, to avoid copying
https://bugs.webkit.org/show_bug.cgi?id=105552

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-02-04
Reviewed by Philippe Normand.

Makes it possible for the GStreamer media backend to provide the buffer to which
the Soup networking backend will use to download data to. This makes copying
memory unnecessary when ResourceHandle hands data over to the media player's
StreamingClient. Thanks to Dan Winship for help designing the interface.

No behaviour change, covered by existing tests.

  • platform/graphics/gstreamer/GStreamerVersioning.cpp:

(createGstBufferForData): New helper to create a GstBuffer when
we have a data pointer and a length.
(getGstBufferSize): Abstract obtaining the size of the buffer, so the code
is cleaner while still working for both GST 0.10 and 1.0.
(setGstBufferSize): Ditto, but for setting the size.
(getGstBufferDataPointer): Ditto, but for grabbing the data pointer.
(mapGstBuffer): Convenience method to take care of mapping the buffer so that
we can provide the data pointer to ResourceHandle.
(unmapGstBuffer): Convenience method which takes care of unmapping the buffer
and properly freeing the GstMapInfo.

  • platform/graphics/gstreamer/GStreamerVersioning.h:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient): New methods.
(_WebKitWebSrcPrivate): We now store the GstBuffer we provided the data pointer from
so we can later unmap it and push it to the pipeline.
(webKitWebSrcDispose): Deal with the GstBuffer in case it exists when the source is
destroyed.
(webKitWebSrcStop): Also clear the GstBuffer in this case.
(StreamingClient::didReceiveData): Handle the hand-over of the buffer.
(StreamingClient::getBuffer): Provide ResourceHandle with a new GstBuffer's data pointer.

  • platform/network/ResourceHandleClient.h:

(ResourceHandleClient):
(WebCore::ResourceHandleClient::ResourceHandleClient): Constructor to initialize the buffer
member variable to 0.
(WebCore::ResourceHandleClient::~ResourceHandleClient): Destructor to free the buffer if it
has been allocated.
(WebCore::ResourceHandleClient::getBuffer): Default implementation which returns a
newly allocated char pointer.

  • platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(ResourceHandleInternal): Store actual buffer size, which is no longer a constant.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::cleanupSoupRequestOperation): Clear the buffer pointer, the life-cycle of the
buffer is handled by the ResourceHandleClient.
(WebCore::nextMultipartResponsePartCallback): Get a new buffer from the client before reading.
(WebCore::sendRequestCallback): Ditto.
(WebCore::readCallback): Ditto.

3:07 PM Changeset in webkit [141820] by andersca@apple.com
  • 15 edits in trunk/Source/WebKit2

Update message generation to use the new queue client semantics
https://bugs.webkit.org/show_bug.cgi?id=108865

Reviewed by Andreas Kling.

  • Scripts/webkit2/messages.py:

(connection_work_queue_message_statement):
(async_message_statement):
(generate_message_handler):

  • Scripts/webkit2/messages_unittest.py:
  • Shared/mac/SecItemShim.cpp:

(WebKit::SecItemShim::didReceiveMessageOnConnectionWorkQueue):

  • Shared/mac/SecItemShim.h:

(SecItemShim):

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::didReceiveMessageOnConnectionWorkQueue):

  • UIProcess/Storage/StorageManager.h:

(StorageManager):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessageOnConnectionWorkQueue):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

  • UIProcess/mac/SecItemShimProxy.cpp:

(WebKit::SecItemShimProxy::didReceiveMessageOnConnectionWorkQueue):

  • UIProcess/mac/SecItemShimProxy.h:

(SecItemShimProxy):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::didReceiveMessageOnConnectionWorkQueue):

  • WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessageOnConnectionWorkQueue):

  • WebProcess/WebProcess.h:

(WebProcess):

3:01 PM Changeset in webkit [141819] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Build fix for AtomicString on iOS

Unreviewed. The commit r141812 rely on isUIThread(), there is no such things
in the tree right now. Use pthread_main_np() until more thread handling is upstreamed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-04

  • wtf/text/AtomicString.cpp:

(WTF::AtomicStringTable::create):

2:49 PM Changeset in webkit [141818] by pilgrim@chromium.org
  • 6 edits
    1 move
    2 adds in trunk/Source

[Chromium] Move WorkerContextProxy to WebCore
https://bugs.webkit.org/show_bug.cgi?id=108847

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 106829.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • workers/chromium: Added.
  • workers/chromium/WorkerContextProxyChromium.cpp: Added.

(WebCore):
(WebCore::setWorkerContextProxyCreateFunction):
(WebCore::WorkerContextProxy::create):

  • workers/chromium/WorkerContextProxyChromium.h: Added.

(WebCore):

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/WebKit.cpp:

(WebKit::initializeWithoutV8):

  • src/WorkerContextProxy.cpp: Removed.
2:39 PM Changeset in webkit [141817] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

WebVTT <i>, <b> and <u> elements should have default styles
https://bugs.webkit.org/show_bug.cgi?id=107214

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-04
Reviewed by Darin Adler.

Source/WebCore:

Added default styles for basic webvtt object types.

Test: media/track/track-css-matching-default.html

  • css/mediaControls.css:

(video::-webkit-media-text-track-container b):
(video::-webkit-media-text-track-container u):
(video::-webkit-media-text-track-container i):

LayoutTests:

  • media/track/captions-webvtt/styling-default.vtt: Added.
  • media/track/track-css-matching-default-expected.txt: Added.
  • media/track/track-css-matching-default.html: Added.
2:36 PM Changeset in webkit [141816] by inferno@chromium.org
  • 47 edits in trunk/Source

Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
https://bugs.webkit.org/show_bug.cgi?id=108668

Reviewed by Eric Seidel.

Source/WebCore:

  • bindings/v8/SerializedScriptValue.cpp:
  • css/CSSCalculationValue.cpp:

(WebCore::CSSCalcExpressionNodeParser::parseCalc):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::fillImageSet):
(WebCore::CSSImageSetValue::customCssText):

  • css/CSSParserValues.h:

(WebCore::CSSParserString::operator[]):

  • css/CSSValueList.h:

(WebCore::CSSValueListInspector::item):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::ruleAt):
(WebCore::StyleSheetContents::wrapperInsertRule):
(WebCore::StyleSheetContents::wrapperDeleteRule):

  • dom/Document.cpp:

(WebCore::Document::processArguments):

  • dom/Element.cpp:

(WebCore::Element::removeAttributeInternal):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::removeAttribute):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::attributeItem):

  • dom/SpaceSplitString.h:

(WebCore::SpaceSplitStringData::operator[]):
(WebCore::SpaceSplitString::operator[]):

  • editing/TextIterator.cpp:

(WebCore::TextIterator::characterAt):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::removeFormElement):

  • html/HTMLSelectElementWin.cpp:

(WebCore::HTMLSelectElement::platformHandleKeydownEvent):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):

  • html/parser/HTMLFormattingElementList.cpp:

(WebCore::HTMLFormattingElementList::swapTo):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::styleSheetTextWithChangedStyle):

  • inspector/InspectorStyleTextEditor.cpp:

(WebCore::InspectorStyleTextEditor::replaceProperty):

  • inspector/InspectorValues.cpp:

(WebCore::InspectorArrayBase::get):

  • page/WindowFeatures.cpp:

(WebCore::WindowFeatures::WindowFeatures):

  • platform/audio/AudioArray.h:

(WebCore::AudioArray::at):

  • platform/audio/AudioFIFO.cpp:

(WebCore::AudioFIFO::findWrapLengths):

  • platform/graphics/GlyphPage.h:

(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::glyphAt):
(WebCore::GlyphPage::setGlyphDataForIndex):

  • platform/graphics/TextRun.h:

(WebCore::TextRun::operator[]):
(WebCore::TextRun::data8):
(WebCore::TextRun::data16):

  • platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::setDrawRange):

  • platform/graphics/openvg/TiledImageOpenVG.cpp:

(WebCore::TiledImageOpenVG::setTile):
(WebCore::TiledImageOpenVG::tile):

  • platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::decodeAtIndex):
(WebCore::ICOImageDecoder::imageTypeAtIndex):

  • platform/text/QuotedPrintable.cpp:

(WebCore::lengthOfLineEndingAtIndex):

  • platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::advance):

  • platform/win/WebCoreTextRenderer.cpp:

(WebCore::doDrawTextAtPoint):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):

Source/WebKit/chromium:

  • src/ContextFeaturesClientImpl.cpp:

(WebKit::ContextFeaturesCache::entryFor):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::selectFindMatch):

Source/WebKit2:

  • Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::HandleArray::operator[]):

Source/WTF:

  • wtf/AVLTree.h:

(WTF::AVLTreeDefaultBSet::operator[]):

  • wtf/BitArray.h:

(WTF::BitArray::set):
(WTF::BitArray::get):

  • wtf/FastBitVector.h:

(WTF::FastBitVector::set):
(WTF::FastBitVector::clear):
(WTF::FastBitVector::get):

  • wtf/FixedArray.h:

(WTF::FixedArray::operator[]):

  • wtf/RefCountedArray.h:

(WTF::RefCountedArray::at):

  • wtf/TypedArrayBase.h:

(WTF::TypedArrayBase::item):

  • wtf/text/StringBuffer.h:

(WTF::StringBuffer::operator[]):

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::operator[]):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::operator[]):

2:35 PM Changeset in webkit [141815] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r141809.
http://trac.webkit.org/changeset/141809
https://bugs.webkit.org/show_bug.cgi?id=108860

ARC isn't supported on 32-bit. (Requested by mhahnenberg on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-04

  • API/tests/testapi.mm:

(+[TestObject testObject]):
(testObjectiveCAPI):

2:33 PM Changeset in webkit [141814] by andersca@apple.com
  • 15 edits in trunk/Source/WebKit2

Change didReceiveMessageOnConnectionWorkQueue semantics
https://bugs.webkit.org/show_bug.cgi?id=108859

Reviewed by Sam Weinig.

Change didReceiveMessageOnConnectionWorkQueue to take a reference to an
OwnPtr<MessageDecoder>. This lets queue clients handle a message later, on a different
work queue for example. Also, get rid of the didHandleMessage boolean, since taking ownership
of the decoder implicitly means that the message was handled.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::processIncomingMessage):

  • Platform/CoreIPC/Connection.h:

(QueueClient):

  • Shared/mac/SecItemShim.cpp:

(WebKit::SecItemShim::didReceiveMessageOnConnectionWorkQueue):

  • Shared/mac/SecItemShim.h:

(SecItemShim):

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageManager):
(WebKit::StorageManager::didReceiveMessageOnConnectionWorkQueue):

  • UIProcess/Storage/StorageManager.h:

(WebKit):
(StorageManager):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessageOnConnectionWorkQueue):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

  • UIProcess/mac/SecItemShimProxy.cpp:

(WebKit::SecItemShimProxy::didReceiveMessageOnConnectionWorkQueue):

  • UIProcess/mac/SecItemShimProxy.h:

(SecItemShimProxy):

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::didReceiveMessageOnConnectionWorkQueue):

  • WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessageOnConnectionWorkQueue):

  • WebProcess/WebProcess.h:

(WebProcess):

2:28 PM Changeset in webkit [141813] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/12884778> Sandbox violation due to MediaAccessibility code trying to access ~/Library/Preferences/com.apple.mediaaccessibility.plist

Reviewed by Sam Weinig.

  • WebProcess/com.apple.WebProcess.sb.in:
2:20 PM Changeset in webkit [141812] by benjamin@webkit.org
  • 3 edits in trunk/Source/WTF

Upstream iOS's AtomicString
https://bugs.webkit.org/show_bug.cgi?id=108139

Reviewed by David Kilzer.

On iOS, WebCore can be executed from two different threads. To maintain consistency,
a few changes had been made:
-The main UI thread and the WebThread share the same AtomicStringTable.
-A spin lock is needed before any access to prevent any concurrent modification of the string table.

The spin lock also prevent race on the static initialization of the shared table.

  • wtf/Platform.h:

Introduce a new USE(WEB_THREAD) to scope changes related to iOS Web Thread.

  • wtf/text/AtomicString.cpp:

(AtomicStringTableLocker):
(WTF::AtomicStringTableLocker::AtomicStringTableLocker):
(WTF::AtomicStringTableLocker::~AtomicStringTableLocker):
(WTF::AtomicStringTable::create):
wtfThreadData() is not necessarily inlined on ARM. When it is not inlined, the old code
causes two call to the function. Instead, we can keep the value in register and pass it
to AtomicStringTable::create().
(WTF::stringTable):
(WTF::addToStringTable):
(WTF::AtomicString::addSlowCase):
(WTF::AtomicString::find):
(WTF::AtomicString::remove):

2:19 PM Changeset in webkit [141811] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

REGRESSION (r137607): Loading of archives as substitute data is broken
https://bugs.webkit.org/show_bug.cgi?id=108589

Reviewed by Alexey Proskuryakov.

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::resourceData): Return the content from

SubstituteData as mainResourceData if present.

2:18 PM Changeset in webkit [141810] by jchaffraix@webkit.org
  • 3 edits
    2 adds in trunk

[CSS Grid Layout] Heap-buffer-overflow in std::sort
https://bugs.webkit.org/show_bug.cgi?id=108834

Reviewed by Abhishek Arya.

Source/WebCore:

Test: fast/css-grid-layout/grid-strict-ordering-crash.html

  • rendering/RenderGrid.cpp:

(WebCore::sortByGridTrackGrowthPotential):
The std::sort documentation says that this function should define a *strict* weak ordering. Fixed the strict
part of the ordering. Also moved the function definition next to where it is needed and made the GridTrack
argument const (as it shouldn't modify them or std::sort will misbehave).

  • rendering/RenderGrid.cpp:

(WebCore::sortByGridTrackGrowthPotential):
(WebCore):

LayoutTests:

  • fast/css-grid-layout/grid-strict-ordering-crash-expected.txt: Added.
  • fast/css-grid-layout/grid-strict-ordering-crash.html: Added.

The test requires a column / row index above the Vector inline capacity to work (which is currently 16).
The values are much higher in case we decide to bump the inline capacity.

2:13 PM Changeset in webkit [141809] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Objective-C API: testapi.mm should use ARC
https://bugs.webkit.org/show_bug.cgi?id=107838

Reviewed by Oliver Hunt.

In ToT testapi.mm uses the Obj-C garbage collector, which hides a lot of our object lifetime bugs.
We should enable ARC, since that is what most of our clients will be using.

  • API/tests/testapi.mm:

(-[TestObject init]):
(-[TestObject dealloc]):
(+[TestObject testObject]):
(testObjectiveCAPI):

2:02 PM Changeset in webkit [141808] by Bruno de Oliveira Abinader
  • 2 edits in trunk/Tools

[EFL] Add "full screen" parameter to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=108850

Reviewed by Antonio Gomes.

Implements the {-F,--full-screen}={true,false} parameter to WebKit EFL's
MiniBrowser.

  • MiniBrowser/efl/main.c:

(window_create):
(elm_main):
Added '-F/--full-screen' parameter functionality.

1:49 PM Changeset in webkit [141807] by igor.o@sisa.samsung.com
  • 2 edits in trunk/Source/WebCore

[Texmap] Implement BGRA swizzling detection
https://bugs.webkit.org/show_bug.cgi?id=81103

For OpenGLES if the extension EXT_texture_format_BGRA8888 is supported
the internal and external formats need to be BGRA.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore):
(WebCore::driverSupportsExternalTextureBGRA):
(WebCore::driverSupportsSubImage):
(WebCore::BitmapTextureGL::didReset):

1:45 PM Changeset in webkit [141806] by commit-queue@webkit.org
  • 5 edits in trunk

class="cue" is getting some default style
https://bugs.webkit.org/show_bug.cgi?id=108752

Source/WebCore:

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-04
Reviewed by Dean Jackson.

The value variable inside the selector is used to store different information depending on the
type of the selector so we have to check explicitly that the selector we apply filtering to
matches a pseudo element.

Existing tests modified to cover this case.

  • css/RuleSet.cpp:

(WebCore::determinePropertyWhitelistType):

LayoutTests:

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-04
Reviewed by Dean Jackson.

  • media/track/track-css-property-whitelist-expected.txt:
  • media/track/track-css-property-whitelist.html:
1:37 PM Changeset in webkit [141805] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Objective-C API: ObjCCallbackFunction should retain the target of its NSInvocation
https://bugs.webkit.org/show_bug.cgi?id=108843

Reviewed by Darin Adler.

Currently, ObjCCallbackFunction doesn't retain the target of its NSInvocation. It needs to do
this to prevent crashes when trying to invoke a callback later on.

  • API/ObjCCallbackFunction.mm:

(ObjCCallbackFunction::ObjCCallbackFunction):
(ObjCCallbackFunction::~ObjCCallbackFunction):

1:34 PM Changeset in webkit [141804] by andersca@apple.com
  • 15 edits in trunk/Source/WebKit2

Add didCloseOnConnectionWorkQueue to Connection::QueueClient
https://bugs.webkit.org/show_bug.cgi?id=108853

Reviewed by Andreas Kling.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::connectionDidClose):

  • Platform/CoreIPC/Connection.h:

(QueueClient):

  • Shared/mac/SecItemShim.cpp:

(WebKit::SecItemShim::didCloseOnConnectionWorkQueue):

  • Shared/mac/SecItemShim.h:

(SecItemShim):

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::didCloseOnConnectionWorkQueue):
(WebKit):

  • UIProcess/Storage/StorageManager.h:

(StorageManager):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didCloseOnConnectionWorkQueue):
(WebKit):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

  • UIProcess/mac/SecItemShimProxy.cpp:

(WebKit::SecItemShimProxy::didCloseOnConnectionWorkQueue):

  • UIProcess/mac/SecItemShimProxy.h:

(SecItemShimProxy):

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::didCloseOnConnectionWorkQueue):
(WebKit):

  • WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didCloseOnConnectionWorkQueue):
(WebKit):

  • WebProcess/WebProcess.h:

(WebProcess):

1:31 PM Changeset in webkit [141803] by tsepez@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Binding Integrity crash in V8HTMLEmbedElement::createWrapper
https://bugs.webkit.org/show_bug.cgi?id=108841

Reviewed by Adam Barth.

  • html/HTMLEmbedElement.idl:

Quick change to IDL to disable binding check for now.

1:29 PM Changeset in webkit [141802] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[WK2] [Mac] Support drag in mouse events for WebKit2 EventSender
https://bugs.webkit.org/show_bug.cgi?id=68552

Skip another test that depends on setting eventSender.dragMode.

  • platform/wk2/TestExpectations:
1:29 PM Changeset in webkit [141801] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Out-of-view check of fixed position element in frame might still be incorrect on Mac when
page is scaled
https://bugs.webkit.org/show_bug.cgi?id=105049

These tests have started passing all the time on all the Lion and Mountain Lion Debug and
Release WK1 and WK2 testers. Remove the failing expectation.

  • platform/mac/TestExpectations:
1:28 PM Changeset in webkit [141800] by Martin Robinson
  • 9 edits in trunk/Source

Fix GTK+ 'make dist' in preparation for the 1.11.5 release.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Update the source lists.

Source/WebCore:

  • GNUmakefile.list.am:

Source/WebKit2:

  • GNUmakefile.am:
  • GNUmakefile.list.am:

Source/WTF:

  • GNUmakefile.list.am:
1:22 PM Changeset in webkit [141799] by enrica@apple.com
  • 11 edits in trunk/Source

Add specific EditActions for Bold and Italic commands.
https://bugs.webkit.org/show_bug.cgi?id=108842.
<rdar://problem/13098252>

Source/WebCore:

This change is required on iOS where we need to
identify the command in order to display the correct
message in the undo popup. It is also in line with
what we do for underline, which already has its own
separate EditAction.

Reviewed by Ryosuke Niwa.

No new tests. No behavior change.

  • editing/EditAction.h:
  • editing/EditorCommand.cpp:

(WebCore::executeToggleBold):
(WebCore::executeToggleItalic):

Source/WebKit/mac:

Reviewed by Ryosuke Niwa.

  • WebCoreSupport/WebEditorClient.mm:

(undoNameForEditAction):

Source/WebKit/qt:

Reviewed by Ryosuke Niwa.

  • WebCoreSupport/UndoStepQt.cpp:

(undoNameForEditAction):

Source/WebKit/win:

Reviewed by Ryosuke Niwa.

  • WebCoreSupport/WebEditorClient.cpp:

(undoNameForEditAction):

Source/WebKit2:

Reviewed by Ryosuke Niwa.

  • UIProcess/WebEditCommandProxy.cpp:

(WebKit::WebEditCommandProxy::nameForEditAction):

1:15 PM Changeset in webkit [141798] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1364

Merge 141127
BUG=172814
Review URL: https://codereview.chromium.org/12183027

1:12 PM Changeset in webkit [141797] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry]Adjust fatfinger detection rect size
https://bugs.webkit.org/show_bug.cgi?id=108678

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-02-04
Reviewed by Antonio Gomes.
RIM Bug 246976

We still need to clip the fatfinger detection rect to the viewport to
avoid wrong hitTest result.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::mouseEvent):

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::getNodesFromRect):

1:11 PM Changeset in webkit [141796] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Use a separate queue for the connection watchdog callback in the web process
https://bugs.webkit.org/show_bug.cgi?id=108844

Reviewed by Andreas Kling.

Don't pass the connection work queue to the didCloseOnConnectionWorkQueue callback.
Instead, create a new, temporary work queue where the exit call will be dispatched to.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::connectionDidClose):

  • Platform/CoreIPC/Connection.h:

(Connection):

  • Shared/ChildProcess.cpp:

(WebKit::didCloseOnConnectionWorkQueue):

1:00 PM Changeset in webkit [141795] by commit-queue@webkit.org
  • 6 edits in trunk

Implemet :lang() pseudo class support for the WebVTT ::cue pseudo element
https://bugs.webkit.org/show_bug.cgi?id=105478

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-04
Reviewed by Antti Koivisto.

Source/WebCore:

In WebVTT lang is preprocessed and stored in the lang attribute of the element,
so we access it instead of walking up the tree the way it is done in HTML.

Existing tests were modified to cover this case.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

LayoutTests:

  • media/track/captions-webvtt/styling-lang.vtt:
  • media/track/track-css-matching-lang-expected.txt:
  • media/track/track-css-matching-lang.html:
12:40 PM Changeset in webkit [141794] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1364

Merge 140975
BUG=167728
Review URL: https://codereview.chromium.org/12194024

12:37 PM Changeset in webkit [141793] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1364

Merge 141198
BUG=171830
Review URL: https://codereview.chromium.org/12178024

12:30 PM Changeset in webkit [141792] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Disable autoscrolling the main frame if main frame scrolling is disabled
https://bugs.webkit.org/show_bug.cgi?id=108848
<rdar://problem/13004059>

Reviewed by Simon Fraser.

Ensure that the main frame can scroll at all before allowing an autoscroll.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::canAutoscroll):

11:48 AM Changeset in webkit [141791] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

XSS Auditor bypass via svg tags and xlink:href
https://bugs.webkit.org/show_bug.cgi?id=84158

Source/WebCore:

This patch adds a test for the xlink:href attribute inside of
script tokens. The test is complicated by the namespacing; the
xlink hrefAttr qualified name does not contain a literal "xlink"
prefix but only the URI of the namespace.

Patch by Tom Sepez <tsepez@chromiium.org> on 2013-02-04
Reviewed by Adam Barth.

Test: http/tests/security/xssAuditor/svg-script-tag.html

  • html/parser/XSSAuditor.cpp:

(WebCore::findAttributeWithName):
(WebCore::XSSAuditor::filterScriptToken):

LayoutTests:

Patch by Tom Sepez <tsepez@chromiium.org> on 2013-02-04
Reviewed by Adam Barth.

  • http/tests/security/xssAuditor/svg-script-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/svg-script-tag.html: Added.
11:39 AM Changeset in webkit [141790] by eric.carlson@apple.com
  • 10 edits in trunk/Source/WebCore

Update CaptionUserPreferences
https://bugs.webkit.org/show_bug.cgi?id=108783

Reviewed by Dean Jackson.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateSizes): Mark font size as important

when necessary.

  • page/CaptionUserPreferences.h:

(WebCore::CaptionUserPreferences::setUserPrefersCaptions): New, allow a port to remember that

the user has chosen to see captions.

(WebCore::CaptionUserPreferences::setPreferredLanguage): New, allow a port to remember the

user's preferred caption language.

(WebCore::CaptionUserPreferences::preferredLanguages): New, return a Vector of the user's

preferred caption languages.

  • page/CaptionUserPreferencesMac.h:
  • page/CaptionUserPreferencesMac.mm:
  • page/PageGroup.cpp:

(WebCore::PageGroup::captionPreferences):
(WebCore::PageGroup::captionFontSizeScale):

  • page/PageGroup.h:
  • platform/Language.cpp:

(WebCore::userPreferredLanguagesOverride): New, return the user preferred languages override

used during testing.

  • platform/Language.h:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:

(WebCore::InbandTextTrackPrivateAVFObjC::kind):

11:26 AM Changeset in webkit [141789] by timothy_horton@apple.com
  • 6 edits in trunk/Source

Allow TiledCoreAnimationDrawingArea overlay layers to become tiled
https://bugs.webkit.org/show_bug.cgi?id=108729
<rdar://problem/13047546>

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea): Add didCommitChangesForLayer and storage for the
current PlatformLayer corresponding to m_pageOverlayLayer.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::flushLayers): Update the TileCache's visible rect.
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect): Forward exposed rect changes to the page overlay layer, if it's tiled.
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged): Forward scrollability changes to the page overlay layer, if it's tiled.
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer): Allow the page overlay layer to become tiled. Update its exposed rect and whether or not it respects the exposed rect if it's tiled upon creation.
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer): If a GraphicsLayer's platform layer changes (because it switched to or from a tiled layer), reparent it. If it's switching to a tiled layer, update the exposed rect and whether or not it should respect the exposed rect.

  • WebCore.exp.in:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::flushCompositingStateForThisLayerOnly): The "for this layer only" variant
of flushCompositingState wasn't informing its client that it committed changes for the layer.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): We now explicitly want to be able to have a
GraphicsLayerCA switch into or out of tiling while being unparented (we'll get a client callback and
swap out its parent ourselves).

11:18 AM Changeset in webkit [141788] by msaboff@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

For ARMv7s use integer divide instruction for divide and modulo when possible
https://bugs.webkit.org/show_bug.cgi?id=108840

Reviewed in person by Filip Pizlo.

Added ARMv7s integer divide path for ArithDiv and ArithMod where operands and results are integer.
This is patterned after the similar code for X86. Also added modulo power of 2 optimization
that uses logical and. Added sdiv and udiv to the ARMv7 disassembler. Put all the changes
behind #if CPU(APPLE_ARMV7S).

  • assembler/ARMv7Assembler.h:

(ARMv7Assembler):
(JSC::ARMv7Assembler::sdiv):
(JSC::ARMv7Assembler::udiv):

  • dfg/DFGCommon.h:

(JSC::DFG::isARMv7s):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForARMv7s):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

11:14 AM Changeset in webkit [141787] by jchaffraix@webkit.org
  • 13 edits
    2 adds in trunk

[CSS Grid Layout] Add parsing for grid-auto-flow
https://bugs.webkit.org/show_bug.cgi?id=108397

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-auto-flow-get-set.html

This change adds the parsing, application and conversion back through getComputedStyle
for the new property -webkit-grid-auto-flow, which accpets the following:

-webkit-grid-auto-flow: none | rows | columns

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Added code to convert the RenderStyle information back into a CSS value.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
Implemented parsing for -webkit-grid-auto-flow.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator GridAutoFlow):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Added the conversion operators, used for parsing and getComputedStyle.

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):
Added -webkit-grid-auto-flow to the list of the not inherited properties.

  • css/CSSPropertyNames.in:

Added the new value and keywords.

  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):
Added a handler for the new CSS property.

  • rendering/style/RenderStyle.h:

Added the usual getter / setter / initial function.

  • rendering/style/RenderStyleConstants.h:

Added a new enum GridAutoFlow to hold the parsed value.

  • rendering/style/StyleGridData.cpp:

(WebCore::StyleGridData::StyleGridData):

  • rendering/style/StyleGridData.h:

(WebCore::StyleGridData::operator==):
Updated after adding a new field for the GridAutoFlow value.

LayoutTests:

  • fast/css-grid-layout/grid-auto-flow-get-set-expected.txt: Added.
  • fast/css-grid-layout/grid-auto-flow-get-set.html: Added.
  • fast/css-grid-layout/resources/grid.css:

(.gridAutoFlowNone):
(.gridAutoFlowColumn):
(.gridAutoFlowRow):
Added these new classes to our common style.

11:01 AM Changeset in webkit [141786] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Check PrivateHeaders/JSBasePrivate.h for inappropriate macros
<http://webkit.org/b/108749>

Reviewed by Joseph Pecoraro.

PrivateHeaders/JSBasePrivate.h to list of headers to check in
"Check for Inappropriate Macros in External Headers" build phase
script.

10:59 AM Changeset in webkit [141785] by jochen@chromium.org
  • 5 edits
    1 move
    1 add
    1 delete in trunk/Tools

[chromium] remove WebTestPlugin from the public TestRunner API
https://bugs.webkit.org/show_bug.cgi?id=108467

Reviewed by Adam Barth.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebTestPlugin.h: Removed.
  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebKit):
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::createPlugin):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp.

(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner):
(WebTestRunner::TestPlugin::~TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::updateGeometry):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::parseOpacity):
(WebTestRunner::TestPlugin::parseBoolean):
(WebTestRunner::TestPlugin::initScene):
(WebTestRunner::TestPlugin::drawScene):
(WebTestRunner::TestPlugin::destroyScene):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleInputEvent):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):
(WebTestRunner::TestPlugin::create):
(WebTestRunner::TestPlugin::mimeType):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Added.

(WebTestRunner):
(TestPlugin):
(WebTestRunner::TestPlugin::scriptableObject):
(WebTestRunner::TestPlugin::canProcessDrag):
(WebTestRunner::TestPlugin::paint):
(WebTestRunner::TestPlugin::updateFocus):
(WebTestRunner::TestPlugin::updateVisibility):
(WebTestRunner::TestPlugin::acceptsInputEvents):
(WebTestRunner::TestPlugin::didReceiveResponse):
(WebTestRunner::TestPlugin::didReceiveData):
(WebTestRunner::TestPlugin::didFinishLoading):
(WebTestRunner::TestPlugin::didFailLoading):
(WebTestRunner::TestPlugin::didFinishLoadingFrameRequest):
(WebTestRunner::TestPlugin::didFailLoadingFrameRequest):
(WebTestRunner::TestPlugin::isPlaceholder):
(WebTestRunner::TestPlugin::prepareTexture):
(WebTestRunner::TestPlugin::context):
(Scene):
(WebTestRunner::TestPlugin::Scene::Scene):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::createPlugin):
(WebTestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createPlugin):

10:52 AM Changeset in webkit [141784] by pilgrim@chromium.org
  • 8 edits
    1 copy
    1 move
    1 add in trunk/Source

[Chromium] Move IDBFactoryBackendInterface to WebCore
https://bugs.webkit.org/show_bug.cgi?id=108638

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 106829.

Source/WebCore:

  • Modules/indexeddb/chromium: Added.
  • Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp: Added.

(WebCore):
(WebCore::setIDBFactoryBackendInterfaceCreateFunction):
(WebCore::IDBFactoryBackendInterface::create):

  • Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.h: Added.

(WebCore):

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/AssertMatchingEnums.cpp:
  • src/IDBFactoryBackendInterface.cpp: Removed.
  • src/IDBFactoryBackendProxy.h:
  • src/WebKit.cpp:

(WebKit::initializeWithoutV8):

10:43 AM Changeset in webkit [141783] by inferno@chromium.org
  • 45 edits in trunk/Source

Add ASSERT_WITH_SECURITY_IMPLICATION to detect bad cast in DOM, CSS, etc.
https://bugs.webkit.org/show_bug.cgi?id=108688

Reviewed by Eric Seidel.

Source/WebCore:

  • Modules/notifications/Notification.cpp:

(WebCore::Notification::Notification):
(WebCore::Notification::permission):
(WebCore::Notification::requestPermission):

  • Modules/speech/SpeechGrammar.cpp:

(WebCore::SpeechGrammar::setSrc):

  • Modules/speech/SpeechGrammarList.cpp:

(WebCore::SpeechGrammarList::addFromUri):

  • Modules/websockets/ThreadableWebSocketChannel.cpp:

(WebCore::ThreadableWebSocketChannel::create):

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::cellForColumnAndRow):

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::reattach):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::fillImageSet):

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::reattach):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::reattach):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):

  • css/StyleResolver.cpp:

(WebCore::createGridPosition):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):

  • css/WebKitCSSFilterRule.cpp:

(WebCore::WebKitCSSFilterRule::reattach):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::reattach):

  • css/WebKitCSSViewportRule.cpp:

(WebCore::WebKitCSSViewportRule::reattach):

  • editing/EditCommand.h:

(WebCore::toSimpleEditCommand):

  • editing/visible_units.cpp:

(WebCore::startOfParagraph):
(WebCore::endOfParagraph):

  • html/HTMLCollection.cpp:

(WebCore::LiveNodeListBase::setItemCache):

  • loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoader::create):
(WebCore::ThreadableLoader::loadResourceSynchronously):

  • loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):

  • page/Frame.cpp:

(WebCore::Frame::frameForWidget):

  • platform/RefCountedSupplement.h:

(WebCore::RefCountedSupplement::from):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitBlocks):
(WebCore::RenderBlock::firstLineBlock):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::createLineBoxes):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::positionForPoint):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::layoutChildBoxes):

  • testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::resetInternalsObject):

  • testing/v8/WebCoreTestSupport.cpp:

(WebCoreTestSupport::resetInternalsObject):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::addToWorkerDocuments):
(WebCore::SharedWorkerConnectTask::performTask):

  • workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

  • workers/WorkerContext.cpp:

(WebCore::CloseWorkerContextTask::performTask):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::MessageWorkerContextTask::performTask):
(WebCore::connectToWorkerContextInspectorTask):
(WebCore::disconnectFromWorkerContextInspectorTask):
(WebCore::dispatchOnInspectorBackendTask):

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::loadSynchronously):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadShutdownFinishTask::performTask):
(WebCore::WorkerThreadShutdownStartTask::performTask):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):

Source/WebKit/chromium:

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::allowIndexedDB):
(WebKit::getWebFrame):

  • src/LocalFileSystemChromium.cpp:

(WebCore::LocalFileSystem::deleteFileSystem):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::connectTask):
(WebKit::resumeWorkerContextTask):
(WebKit::connectToWorkerContextInspectorTask):
(WebKit::reconnectToWorkerContextInspectorTask):
(WebKit::disconnectFromWorkerContextInspectorTask):
(WebKit::dispatchOnInspectorBackendTask):

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:
10:35 AM Changeset in webkit [141782] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Made the documentation on the confirmed argument for the
WebView::script-confirm signal clearer about its type.

Reviewed by Martin Robinson.

  • webkit/webkitwebview.cpp:

(webkit_web_view_class_init):

10:34 AM Changeset in webkit [141781] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Use UNUSED_PARAM instead of C style comments.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::createStorageArea):

10:32 AM Changeset in webkit [141780] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Stop using libsoup in ewk_url_scheme_request
https://bugs.webkit.org/show_bug.cgi?id=108816

Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-04
Reviewed by Anders Carlsson.

As we are trying to minimize use of external dependencies in our WK2 EFL
API implementation, we should stop using libsoup in
ewk_url_scheme_request and use the WK2 C API instead.

  • UIProcess/API/efl/ewk_url_scheme_request.cpp:

(EwkUrlSchemeRequest::EwkUrlSchemeRequest):

10:29 AM Changeset in webkit [141779] by kov@webkit.org
  • 3 edits in trunk/Tools

Add a new method for obtaining a build-type-dependent path,
instead of modifying all call sites to pass it in.

Reviewed by Martin Robinson.

  • Scripts/run-gtk-tests:

(TestRunner.init): use the new method, which takes a tuple.
(TestRunner._setup_testing_environment): ditto.

  • gtk/common.py:

(get_build_path): accept a tuple that may include Release and
Debug as build types, for searching.
(build_path_for_build_types): new method that finds the path when
it is dependent on the build type.
(build_path): restore its original behaviour.

10:22 AM WebKitGTK/1.10.x edited by jdiggs@igalia.com
Add a new proposed item for 1.10.3 (diff)
10:21 AM Changeset in webkit [141778] by dominik.rottsches@intel.com
  • 2 edits in trunk/Source/WebCore

[Skia] Argument to HarfBuzzShaper::offsetForPosition unnecessarily truncated
https://bugs.webkit.org/show_bug.cgi?id=108479

Reviewed by Emil A Eklund.

Remove a FIXME that intended to solve the value truncation.
Should positively affect SVG text positioning.

No new tests, partially covered by manual test
ManualTests/harfbuzz-mouse-selection-crash.html.

  • platform/graphics/harfbuzz/FontHarfBuzz.cpp:

(WebCore::Font::offsetForPositionForComplexText):

10:19 AM Changeset in webkit [141777] by commit-queue@webkit.org
  • 26 edits in trunk

Web Inspector: Create a container class for SidebarPane instances
https://bugs.webkit.org/show_bug.cgi?id=108183

Source/WebCore:

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

SidebarPaneStack is responsible for pane title bar and expand/collapse behavior (previously handled by SidebarPane).
SidebarPanes are inserted into DOM lazily and can belong to more than one container.
SidebarPane is ready to be displayed in other types of containers (such as tabbed pane as requested in https://bugs.webkit.org/show_bug.cgi?id=107552).
There should be no visible changes except for one: DOM breakpoint pane expand/collapse state is no longer
shared between Elements and Sources sidebars.

  • inspector/front-end/AuditResultView.js:

(WebInspector.AuditResultView):

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._addBreakpoint):
(WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype.highlightBreakpoint):

  • inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.prototype.highlightBreakpoint):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.wasShown):
(WebInspector.ElementsPanel.prototype.updateStyles):
(WebInspector.ElementsPanel.prototype.updateMetrics):
(WebInspector.ElementsPanel.prototype.updateProperties):
(WebInspector.ElementsPanel.prototype.updateEventListeners):

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionSidebarPane):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onCreateSidebarPane):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.wasShown):

  • inspector/front-end/SidebarPane.js:

(WebInspector.SidebarPane):
(WebInspector.SidebarPane.prototype.title):
(WebInspector.SidebarPane.prototype.prepareContent):
(WebInspector.SidebarPane.prototype.expand):
(WebInspector.SidebarPane.prototype.onContentReady):
(WebInspector.SidebarPane.prototype.setExpandCallback):
(WebInspector.SidebarPane.prototype.setShowCallback):
(WebInspector.SidebarPane.prototype.wasShown):
(WebInspector.SidebarPaneStack):
(WebInspector.SidebarPaneStack.prototype.wasShown):
(WebInspector.SidebarPaneStack.prototype.addPane):
(WebInspector.SidebarPaneStack.prototype._addTitle):
(WebInspector.SidebarPaneStack.prototype._attachToPane):
(WebInspector.SidebarPaneStack.prototype._isExpanded):
(WebInspector.SidebarPaneStack.prototype._setExpanded):
(WebInspector.SidebarPaneStack.prototype._onPaneExpanded):
(WebInspector.SidebarPaneStack.prototype._collapsePane):
(WebInspector.SidebarPaneStack.prototype._togglePane):
(WebInspector.SidebarPaneStack.prototype._onTitleKeyDown):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype.set _createNewRule):
(WebInspector.ComputedStyleSidebarPane.prototype.prepareContent):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSidebarPane):
(WebInspector.WatchExpressionsSidebarPane.prototype.wasShown):
(WebInspector.WatchExpressionsSidebarPane.prototype.addExpression):
(WebInspector.WatchExpressionsSidebarPane.prototype._addButtonClicked):

  • inspector/front-end/inspector.css:

(.pane-title + .pane-title, .pane:not(.visible) + .pane-title, .pane-title:first-of-type):
(.pane-title):
(.pane-title:active):
(.pane-title::before):
(.pane-title.expanded::before):
(.pane-title > select):
(.pane-title > select:hover):
(.pane-title > select:active):
(.pane-title > select.select-settings):
(.pane-title > select.select-filter):
(.pane-title > select > option, .pane-title > select > hr):
(.pane-title > .pane-title-button):
(.pane-title > .pane-title-button:hover):
(.pane-title > .pane-title-button:active, .pane-title > .pane-title-button.toggled):
(.pane-title > .pane-title-button.add):
(.pane-title > .pane-title-button.element-state):
(.pane-title > .pane-title-button.refresh):
(.pane.visible > .body):
(.pane.visible:nth-last-of-type(1)):
(.panel-enabler-view button:not(.status-bar-item), .pane-title-button, button.show-all-nodes):
(.panel-enabler-view button:active:not(.status-bar-item), .pane-title-button:active, button.show-all-nodes:active):
(body.inactive .panel-enabler-view button:not(.status-bar-item), .panel-enabler-view button:disabled:not(.status-bar-item), body.inactive .pane-title-button, .pane-title-button:disabled, body.inactive button.show-all-nodes):

LayoutTests:

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.stylesCallback):
(initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed):

  • inspector/audits/audits-panel-functional-expected.txt:
  • inspector/audits/audits-panel-noimages-functional-expected.txt:
  • inspector/debugger/error-in-watch-expressions.html:
  • inspector/debugger/properties-special.html:
  • inspector/debugger/watch-expressions-panel-switch.html:
  • inspector/debugger/watch-expressions-preserve-expansion.html:
  • inspector/extensions/extensions-audits-api-expected.txt:
  • inspector/extensions/extensions-audits-content-script-expected.txt:
  • inspector/extensions/extensions-audits-expected.txt:
  • inspector/extensions/extensions-events.html:
  • inspector/extensions/extensions-sidebar.html:
  • inspector/styles/lazy-computed-style.html:
10:14 AM Changeset in webkit [141776] by kadam@inf.u-szeged.hu
  • 4 edits in trunk/LayoutTests

[Qt][Wk2] Unreviewed gardnening. Skip failing tests.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0-wk2/fast/multicol/shrink-to-column-height-for-pagination-expected.png: Update after r141459.
  • platform/qt-5.0-wk2/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Update after r141459.
9:45 AM Changeset in webkit [141775] by eae@chromium.org
  • 5 edits in trunk/Source/WebCore

Remove duplicate code in RenderBoxModelObject::computedCSSPadding*
https://bugs.webkit.org/show_bug.cgi?id=108707

Reviewed by Eric Seidel.

The computedCSSPaddingTop/Bottom/... methods in
RenderBoxModelObject all do pretty much exactly the same thing
yet share no code.

Break out shared code into computedCSSPadding method and have
the top/bottom/left/right/... ones call it with the appropriate
length value.

No new tests, no change in functionality.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::computedCSSPadding):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
(RenderBoxModelObject):

9:42 AM Changeset in webkit [141774] by commit-queue@webkit.org
  • 8 edits in trunk

Web Inspector: add round braces to javascript tokenizer
https://bugs.webkit.org/show_bug.cgi?id=108692

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

Source/WebCore:

Change SourceJavascriptTokenizer.re2js file to produce "brace-start"
and "brace-end" tokens for round braces.
Regenerate SourceJavascriptTokenizer.js according to new re2js file.

No new tests: no change in behaviour.

  • inspector/front-end/SourceJavaScriptTokenizer.js:

(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):

  • inspector/front-end/SourceJavaScriptTokenizer.re2js:

LayoutTests:

Updated test expectations to correspond to new tokens "brace-start"
and "brace-end" in javascript tokenizer.

  • inspector/editor/highlighter-basics-expected.txt:
  • inspector/editor/text-editor-long-line-expected.txt:
  • inspector/syntax-highlight-html-expected.txt:
  • inspector/syntax-highlight-javascript-expected.txt:
9:38 AM Changeset in webkit [141773] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Needs one-shot drawing synchronization flag should be set before rendering when resuming the backing store
https://bugs.webkit.org/show_bug.cgi?id=108760

Patch by Andrew Lo <anlo@rim.com> on 2013-02-04
Reviewed by Yong Li.
Internally reviewed by Arvid Nilsson.

Internal PR 286218.
When acquiring the backing store ownership in WebPagePrivate::resumeBackingStore
we need to set the needs one-shot drawing synchronization flag
before rendering, so that when the render is completed we
commit the root layer.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):

8:42 AM Changeset in webkit [141772] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: take page scale factor into account when updating overlay.
https://bugs.webkit.org/show_bug.cgi?id=108831

Reviewed by Vsevolod Vlasov.

Otherwise, the ports that use page scale factor have broken overlay.

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::update):

7:56 AM Changeset in webkit [141771] by commit-queue@webkit.org
  • 17 edits in trunk/Source/WebCore

[v8] explicit isolate parameter for MakeWeak calls
https://bugs.webkit.org/show_bug.cgi?id=108818

Patch by Dan Carney <dcarney@google.com> on 2013-02-04
Reviewed by Kentaro Hara.

No new tests. No change in functionality.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::weakCallback):

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::setWrapper):
(WebCore::DOMDataStore::set):
(WebCore::DOMDataStore::setWrapperInObject):
(DOMDataStore):

  • bindings/v8/DOMWrapperMap.h:

(WebCore::DOMWrapperMap::DOMWrapperMap):
(WebCore::DOMWrapperMap::set):
(WebCore::DOMWrapperMap::defaultWeakCallback):
(DOMWrapperMap):

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::isolatedWorldWeakCallback):
(WebCore::DOMWrapperWorld::makeContextWeak):

  • bindings/v8/ScriptState.cpp:

(WebCore::ScriptState::ScriptState):
(WebCore::ScriptState::weakReferenceCallback):

  • bindings/v8/ScriptState.h:

(ScriptState):

  • bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::weakEventListenerCallback):
(WebCore::V8AbstractEventListener::V8AbstractEventListener):
(WebCore::V8AbstractEventListener::setListenerObject):

  • bindings/v8/V8AbstractEventListener.h:

(V8AbstractEventListener):

  • bindings/v8/V8EventListener.cpp:

(WebCore::V8EventListener::V8EventListener):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::V8LazyEventListener):

  • bindings/v8/V8MutationCallback.cpp:

(WebCore::V8MutationCallback::V8MutationCallback):

  • bindings/v8/V8MutationCallback.h:

(WebCore::V8MutationCallback::create):
(WebCore::V8MutationCallback::weakCallback):

  • bindings/v8/V8NPObject.cpp:

(WebCore::V8NPTemplateMap::set):
(WebCore::V8NPTemplateMap::sharedInstance):
(WebCore::V8NPTemplateMap::V8NPTemplateMap):
(V8NPTemplateMap):
(WebCore::V8NPTemplateMap::weakCallback):
(WebCore::npObjectGetProperty):
(WebCore):
(WebCore::staticNPObjectMap):
(WebCore::weakNPObjectCallback):

  • bindings/v8/V8ValueCache.cpp:

(WebCore::cachedStringCallback):
(WebCore::StringCache::v8ExternalStringSlow):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::WeakReferenceCallback):
(WebCore::createInjectedScriptHostV8Wrapper):

  • bindings/v8/custom/V8MutationObserverCustom.cpp:

(WebCore::V8MutationObserver::constructorCallbackCustom):

7:00 AM Changeset in webkit [141770] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Source/WebKit2

[WK2][EFL] Weird stripe at the end of the page
https://bugs.webkit.org/show_bug.cgi?id=108820

Reviewed by Noam Rosenthal.

The page scroll bound was artificially enlarged by one causing the artifact appearance.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::boundContentsPositionAtScale):

6:45 AM Changeset in webkit [141769] by commit-queue@webkit.org
  • 15 edits
    1 move
    7 deletes in trunk

Disable -webkit-overflow-scrolling CSS attribute on Chromium
https://bugs.webkit.org/show_bug.cgi?id=108020

Patch by Sami Kyostila <skyostil@chromium.org> on 2013-02-04
Reviewed by James Robinson.

Now that we can automatically promote overflow elements to accelerated
scrolling layers there is no use for the -webkit-overflow-scrolling CSS
attribute any longer on Chromium.

Source/WebKit/chromium:

This patch enables composited overflow scrolling in
ScrollingCoordinatorChromiumTest. Because this also causes the overflow div
in non-fast-scrollable.html to become composited, we also need to modify that
test to opt it out of composited scrolling.

  • features.gypi:
  • tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
(WebKit::TEST_F):

  • tests/data/non-fast-scrollable.html:
  • tests/data/overflow-scrolling.html: Renamed from Source/WebKit/chromium/tests/data/touch-overflow-scrolling.html.

LayoutTests:

The following tests using -webkit-overflow-scroll are modified to also call
setAcceleratedCompositingForOverflowScrollEnabled(). This makes them test
meaningful things on also on platforms that do not support that CSS attribute.

  • compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor.html:
  • compositing/overflow/iframe-inside-overflow-clipping.html:
  • compositing/overflow/nested-scrolling.html:
  • compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor.html:
  • compositing/overflow/scrolling-content-clip-to-viewport.html:
  • compositing/overflow/scrolling-without-painting.html:
  • compositing/overflow/textarea-scroll-touch.html:
  • compositing/overflow/updating-scrolling-content.html:
  • platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt: Removed.
  • platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch.html: Removed.
  • platform/chromium-linux/compositing/overflow/nested-scrolling-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Removed.
  • platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.png: Removed.
  • platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.txt: Removed.
  • platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html: Removed.
  • platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt: Removed.
6:43 AM Changeset in webkit [141768] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Allow user to change dock side by dragging toolbar
https://bugs.webkit.org/show_bug.cgi?id=108073

Dragging toolbar to the right/bottom will change the dock side accordingly
instead of changing the inspector window height (if dock to right is available).

Patch by Dmitry Gozman <dgozman@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

No new tests, because of pure inspector UI change.

  • inspector/front-end/DockController.js:

(WebInspector.DockController.prototype.dockSide):

  • inspector/front-end/Toolbar.js:

(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype._isDockedToBottom):
(WebInspector.Toolbar.prototype._isUndocked):
(WebInspector.Toolbar.prototype._toolbarDragStart):
(WebInspector.Toolbar.prototype._toolbarDragEnd):
(WebInspector.Toolbar.prototype._toolbarDrag):
(WebInspector.Toolbar.prototype._toolbarDragMoveWindow):
(WebInspector.Toolbar.prototype._toolbarDragChangeDocking):
(WebInspector.Toolbar.prototype._toolbarDragChangeHeight):

  • inspector/front-end/UIUtils.js:

(WebInspector._elementDragStart):
(WebInspector._elementDragMove):
(WebInspector._cancelDragEvents):
(WebInspector._elementDragEnd):

6:35 AM Changeset in webkit [141767] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipping failing tests.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-02-04

  • platform/qt/TestExpectations:
6:23 AM Changeset in webkit [141766] by caseq@chromium.org
  • 4 edits in trunk

Web Inspector: sync list of console API methods to that used by auto-complete
https://bugs.webkit.org/show_bug.cgi?id=108804

Reviewed by Pavel Feldman.

  • push new method names from InjectedScriptSource to RuntimeModel;
  • add a comment to InjectedScriptSource noting the necessity of keeping lists in sync.
  • inspector/InjectedScriptSource.js:
  • inspector/front-end/RuntimeModel.js:

(WebInspector.RuntimeModel.prototype.receivedPropertyNames):
(WebInspector.RuntimeModel.prototype._completionsForExpression):

6:08 AM Changeset in webkit [141765] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Network] Minor refactorings.
https://bugs.webkit.org/show_bug.cgi?id=108162

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-02-04
Reviewed by Vsevolod Vlasov.

Apply minor refactorings to NetworkPanel.js
Add hint to statusbar selector buttons.

  • English.lproj/localizedStrings.js: Added hint string.
  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._createStatusBarItems): Ditto.
(WebInspector.NetworkLogView.prototype._makeHeaderFragment):
Applied minor refactoring.
(WebInspector.NetworkLogView.prototype._createStatusBarItems.createFilterElement):
Ditto.
(WebInspector.NetworkLogView.prototype._updateOffscreenRows): Ditto.
(WebInspector.NetworkPanel.prototype._onRowSizeChanged): Ditto.

5:55 AM Changeset in webkit [141764] by caseq@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: [CPU Profile] Apply minor refactorings and add JSDocs.
https://bugs.webkit.org/show_bug.cgi?id=108437

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

CPU Profile code has obsolete inline-comments to clarify types.
Currently we use JSDocs to specify types.

Also applied some minor refactorings.

  • inspector/front-end/BottomUpProfileDataGridTree.js:

(WebInspector.BottomUpProfileDataGridNode):
Added JSDocs. Removed profileView parameter.
(WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode):
Added JSDocs.
(WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild):
Ditto.
(WebInspector.BottomUpProfileDataGridNode.prototype._merge):
Ditto.
(WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
Do not pass profileView to constructor.
(WebInspector.BottomUpProfileDataGridTree):
Added JSDocs. Renamed parameters.
(WebInspector.BottomUpProfileDataGridTree.prototype.focus):
Added JSDocs.
(WebInspector.BottomUpProfileDataGridTree.prototype.exclude):
Ditto.

  • inspector/front-end/CPUProfileView.js: Removed unused getter/setter.

(WebInspector.CPUProfileView.prototype._getCPUProfileCallback):
Un-nested. Added JSDocs.
(WebInspector.CPUProfileView.prototype._getBottomUpProfileDataGridTree):
Added JSDocs. Turned to method from getter. Simplified.
(WebInspector.CPUProfileView.prototype._getTopDownProfileDataGridTree):
Added JSDocs. Turned to method from getter.
(WebInspector.CPUProfileView.prototype._assignParentsInProfile):
Optimized.

  • inspector/front-end/DataGrid.js: Added JSDocs.
  • inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode):
Added JSDocs. Removed profileView parameter.
(WebInspector.ProfileDataGridNode.prototype.createCell): Added JSDocs.
(WebInspector.ProfileDataGridNode.prototype.sort): Ditto.
(WebInspector.ProfileDataGridNode.prototype.insertChild): Ditto.
(WebInspector.ProfileDataGridNode.prototype.removeChild): Ditto.
(WebInspector.ProfileDataGridNode.prototype.removeChildren):
Added JSDocs. Removed parameter.
(WebInspector.ProfileDataGridNode.prototype.findChild): Added JSDocs.
(WebInspector.ProfileDataGridTree): Added JSDocs. Renamed parameter.

  • inspector/front-end/TopDownProfileDataGridTree.js:

(WebInspector.TopDownProfileDataGridNode):
Added JSDocs. Removed profileView parameter.
(WebInspector.TopDownProfileDataGridNode.prototype._sharedPopulate):
Do not pass profileView to constructor.
(WebInspector.TopDownProfileDataGridTree):
Added JSDocs. Renamed parameter.
(WebInspector.TopDownProfileDataGridTree.prototype.focus):
Added JSDocs.
(WebInspector.TopDownProfileDataGridTree.prototype.exclude):
Ditto.

5:48 AM Changeset in webkit [141763] by commit-queue@webkit.org
  • 24 edits in trunk/Source/WebCore

[v8] use toV8Fast in hand coded callbacks
https://bugs.webkit.org/show_bug.cgi?id=108817

Patch by Dan Carney <dcarney@google.com> on 2013-02-04
Reviewed by Kentaro Hara.

No new tests. No change in functionality.

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openCallback):
(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):

  • bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAccessorGetter):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::V8Event::dataTransferAccessorGetter):
(WebCore::V8Event::clipboardDataAccessorGetter):

  • bindings/v8/custom/V8FileReaderCustom.cpp:

(WebCore::V8FileReader::resultAccessorGetter):

  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore):
(WebCore::getNamedItems):
(WebCore::getItem):
(WebCore::V8HTMLAllCollection::namedPropertyGetter):
(WebCore::V8HTMLAllCollection::itemCallback):
(WebCore::V8HTMLAllCollection::namedItemCallback):
(WebCore::V8HTMLAllCollection::callAsFunctionCallback):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::V8HTMLCollection::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::V8HTMLElement::itemValueAccessorGetter):

  • bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp:

(WebCore):
(WebCore::getNamedItems):
(WebCore::V8HTMLFormControlsCollection::namedPropertyGetter):
(WebCore::V8HTMLFormControlsCollection::namedItemCallback):

  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:

(WebCore::V8HTMLFormElement::indexedPropertyGetter):
(WebCore::V8HTMLFormElement::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:

(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLLinkElementCustom.cpp:

(WebCore::V8HTMLLinkElement::sizesAccessorGetter):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore):
(WebCore::getNamedItems):
(WebCore::V8HTMLOptionsCollection::namedPropertyGetter):
(WebCore::V8HTMLOptionsCollection::namedItemCallback):
(WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):

  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::V8HTMLSelectElement::indexedPropertyGetter):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):
(WebCore::V8MessageEvent::portsAccessorGetter):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::V8NamedNodeMap::indexedPropertyGetter):
(WebCore::V8NamedNodeMap::namedPropertyGetter):

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::namedPropertyGetter):

  • bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore::V8PopStateEvent::stateAccessorGetter):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • bindings/v8/custom/V8StyleSheetListCustom.cpp:

(WebCore::V8StyleSheetList::namedPropertyGetter):

  • bindings/v8/custom/V8TrackEventCustom.cpp:

(WebCore::V8TrackEvent::trackAccessorGetter):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseAccessorGetter):

4:44 AM Changeset in webkit [141762] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

Remove duplicate entry from DumpRenderTree Xcode project

$ uniq Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj | diff -u - Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj | patch -p0 -R
patching file Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Remove duplicate.

4:41 AM Changeset in webkit [141761] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

Sort TestWebKitAPI Xcode project file

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4:36 AM Changeset in webkit [141760] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit2

Sort WebKit2 Xcode project file

  • WebKit2.xcodeproj/project.pbxproj:
4:32 AM Changeset in webkit [141759] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Remove duplicate entry from WebCore Xcode project

$ uniq Source/WebCore/WebCore.xcodeproj/project.pbxproj | diff -u - Source/WebCore/WebCore.xcodeproj/project.pbxproj | patch -p0 -R
patching file Source/WebCore/WebCore.xcodeproj/project.pbxproj

  • WebCore.xcodeproj/project.pbxproj: Remove duplicate.
4:30 AM Changeset in webkit [141758] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Sort WebCore Xcode project file

  • WebCore.xcodeproj/project.pbxproj:
4:26 AM Changeset in webkit [141757] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove duplicate entries from JavaScriptCore Xcode project

$ uniq Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj | diff -u - Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj | patch -p0 -R
patching file Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

4:21 AM Changeset in webkit [141756] by Simon Hausmann
  • 3 edits in trunk/Source/WebKit2

[WK2][Qt] Replace WebPageGroup usage for user scripts with WKPageGroupRef
https://bugs.webkit.org/show_bug.cgi?id=108651

Reviewed by Sam Weinig.

It's straight-forward port towards the C API.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):
(readUserScript):
(QQuickWebViewPrivate::updateUserScripts):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

4:21 AM Changeset in webkit [141755] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Sort JavaScriptCore Xcode project file

4:14 AM Changeset in webkit [141754] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WTF

Sort WTF Xcode project file

  • WTF.xcodeproj/project.pbxproj:
4:13 AM Changeset in webkit [141753] by ddkilzer@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Sort ANGLE Xcode project file.

  • ANGLE.xcodeproj/project.pbxproj:
3:34 AM Changeset in webkit [141752] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[v8] disable ascii check once latin-1 is enabled in v8
https://bugs.webkit.org/show_bug.cgi?id=108805

Patch by Dan Carney <dcarney@google.com> on 2013-02-04
Reviewed by Kentaro Hara.

No new tests. No change in functionality.

  • bindings/v8/V8ValueCache.cpp:

(WebCore::makeExternalString):

2:46 AM Changeset in webkit [141751] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: make tabbed pane header a relayout boundary.
https://bugs.webkit.org/show_bug.cgi?id=108650

Reviewed by Alexander Pavlov.

Otherwise, its measure width routine causes total reflow.

  • inspector/front-end/tabbedPane.css:

(.tabbed-pane-header):

2:27 AM Changeset in webkit [141750] by hayato@chromium.org
  • 9 edits
    2 adds in trunk/Source/WebCore

Split InspectorCSSOMWrappers out from StyleResolver.h into its own file.
https://bugs.webkit.org/show_bug.cgi?id=108797

Reviewed by Hajime Morita.

This is a following patch after r141373. Now we can have
InspectorCSSOMWrappers in its own file since CSSDefaultStyleSheets
was factored out from StyleResolver.cpp in r141733.

WebCore/inspector/ directory is used for basic inspector
functionalities. Therefore, I've put
InspectorCSSOMWrappers.{h,cpp} in WebCore/css/ rather than
WebCore/inspector/.

No new tests, refactoring only.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/InspectorCSSOMWrappers.cpp: Added.

(WebCore):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetIfNeeded):
(WebCore::InspectorCSSOMWrappers::collect):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetContents):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheets):
(WebCore::InspectorCSSOMWrappers::collectFromDocumentStyleSheetCollection):
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
(WebCore::InspectorCSSOMWrappers::reportMemoryUsage):

  • css/InspectorCSSOMWrappers.h: Added.

(WebCore):
(InspectorCSSOMWrappers):

  • css/StyleResolver.cpp:
  • css/StyleResolver.h:
1:33 AM Changeset in webkit [141749] by kbalazs@webkit.org
  • 21 edits
    1 add in trunk/Source

[Soup] Wrap SoupSession by NetworkStorageSession
https://bugs.webkit.org/show_bug.cgi?id=108615

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Implement NetworkStorageSession for ports using soup. It has been
separated from NetworkingContext, so now we have a default storage
session, which is the same as before but now wrapped with NetworkStorageSession,
and it can be overridden by the networking context.

No change in behavior so no new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • loader/CookieJar.cpp:

(WebCore):
Now we also get the storage session from the networking context
and not the other way.

  • platform/network/NetworkStorageSession.h:

(NetworkStorageSession):
(WebCore::NetworkStorageSession::setSoupSession):
(WebCore::NetworkStorageSession::soupSession):
Hold a SoupSession pointer for ports using soup. Added a setter because it is
necessary for API's that allow it to be specified per page, like EFL WK1.

  • platform/network/NetworkingContext.h:

(NetworkingContext):

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::cookieJarForSession):

  • platform/network/soup/NetworkStorageSessionSoup.cpp: Copied from Source/WebKit2/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp.

(WebCore::NetworkStorageSession::NetworkStorageSession):
(WebCore::NetworkStorageSession::defaultStorageSession):
(WebCore::NetworkStorageSession::createDefaultSession):
(WebCore::NetworkStorageSession::createPrivateBrowsingSession):
(WebCore::NetworkStorageSession::switchToNewTestingSession):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sessionFromContext):

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • loader/CookieJar.cpp:

(WebCore):

  • platform/network/NetworkStorageSession.h:

(NetworkStorageSession):
(WebCore::NetworkStorageSession::setSoupSession):
(WebCore::NetworkStorageSession::soupSession):

  • platform/network/NetworkingContext.h:

(NetworkingContext):

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::cookieJarForSession):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sessionFromContext):

Source/WebKit/efl:

Changed to hold the SoupSession pointer in a NetworkStorageSession
so we can pass it to WebCore. _Ewk_View_Private_Data has to be
changed for that reason.

  • WebCoreSupport/FrameNetworkingContextEfl.cpp:

(WebCore::FrameNetworkingContextEfl::storageSession):

  • WebCoreSupport/FrameNetworkingContextEfl.h:

(FrameNetworkingContextEfl):

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_soup_session_get):
(ewk_view_soup_session_set):
(EWKPrivate::storageSession):
(EWKPrivate):

  • ewk/ewk_view_private.h:

(EWKPrivate):

Source/WebKit/gtk:

  • WebCoreSupport/FrameNetworkingContextGtk.cpp:

(WebKit::FrameNetworkingContextGtk::storageSession):

  • WebCoreSupport/FrameNetworkingContextGtk.h:

(FrameNetworkingContextGtk):

Source/WebKit2:

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::WebFrameNetworkingContext::storageSession):

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext):

1:08 AM Changeset in webkit [141748] by tkent@chromium.org
  • 16 edits
    3 deletes in trunk/LayoutTests

[Chromium] Rebaseline for r141741
https://bugs.webkit.org/show_bug.cgi?id=108791

  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt: Removed.
  • platform/chromium-win-xp/fast/forms/date/date-appearance-l10n-expected.png:
  • platform/chromium-win-xp/fast/forms/datetime/datetime-appearance-l10n-expected.png:
  • platform/chromium-win-xp/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt: Removed.
  • platform/chromium-win-xp/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
  • platform/chromium-win-xp/fast/forms/month/month-appearance-l10n-expected.png:
  • platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Removed.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium/TestExpectations:
1:01 AM Changeset in webkit [141747] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: source location in statusbar has few bugs in it
https://bugs.webkit.org/show_bug.cgi?id=108748

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-04
Reviewed by Vsevolod Vlasov.

Call super method statusBarItems in SnippetJavaScriptSourceFrame class
and merge its results. Fix css styles for source location in statusbar
and rename its css class into a less confusing name.

No new test: no change in behaviour.

  • inspector/front-end/SnippetJavaScriptSourceFrame.js:

(WebInspector.SnippetJavaScriptSourceFrame.prototype.statusBarItems):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):

  • inspector/front-end/inspector.css:

(.source-frame-cursor-position):

12:26 AM Changeset in webkit [141746] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebCore

Cleanup: Normalize usage of ExceptionCode in ContainerNode::checkXxxChild()
https://bugs.webkit.org/show_bug.cgi?id=108766

Reviewed by Kentaro Hara.

This patch refactors checkAddChild and checkReplaceChild to remove the
creation of an extra ExceptionCode that's not necessary for the
desired behavior, and to bring the ExceptionCode usage into line with
the rest of WebKit (this was the only case where ExceptionCode was
assigned inside an 'if' statement's condition).

After this patch, 'ec' will always be assigned a value, even if the
result of 'checkAcceptChild' is 0. This would only change behavior if
'ec' was non-zero coming into the function, and 'checkAcceptChild'
returned 0. Since every callsite is either directly after an explicit
zeroing of 'ec', or after an 'if (ec)' clause, that case should never
appear. This patch, therefore, shouldn't visibly change WebKit's
behavior.

  • dom/ContainerNode.cpp:

(WebCore::checkAddChild):
(WebCore::checkReplaceChild):

Feb 3, 2013:

11:44 PM Changeset in webkit [141745] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Mark fast/dom/DOMImplementation/createDocument-with-used-doctype.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=108793

Unreviewed EFL gardening.

Mark fast/dom/DOMImplementation/createDocument-with-used-doctype.html as
flaky due to Bug 108058. It sometimes crashes on the bots.

Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-03

  • platform/efl-wk2/TestExpectations:
11:16 PM Changeset in webkit [141744] by ddkilzer@apple.com
  • 8 edits in trunk/Source

Upstream ENABLE_PDFKIT_PLUGIN settting
<http://webkit.org/b/108792>

Reviewed by Tim Horton.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN

on iOS since PDFKit is a Mac-only framework.

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN

on iOS since PDFKit is a Mac-only framework.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN

on iOS since PDFKit is a Mac-only framework.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN

on iOS since PDFKit is a Mac-only framework.

11:14 PM Changeset in webkit [141743] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Silently block one more directory needed for NSApplication initialization.

Reviewed by Sam Weinig.

  • WebProcess/com.apple.WebProcess.sb.in:
11:02 PM Changeset in webkit [141742] by tasak@google.com
  • 4 edits in trunk/Source/WebCore

Split per-resolve logic out from StyleResolver.
https://bugs.webkit.org/show_bug.cgi?id=96421

Reviewed by Eric Seidel.

Implemented class StyleResolver::State and added m_state to
StyleResolver. All member variables used for per-resolve logic are
moved into the state class.

No new tests, because just refactoring.

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • css/StyleResolver.cpp:

(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::sortMatchedRules):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::initElement):
(WebCore::StyleResolver::initForStyleResolve):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::updateFont):
(WebCore::StyleResolver::cacheBorderAndBackground):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::isLeftPage):
(WebCore::StyleResolver::applyPropertyToStyle):
(WebCore::StyleResolver::useSVGZoomRules):
(WebCore::createGridTrackBreadth):
(WebCore::createGridTrackMinMax):
(WebCore::createGridTrackGroup):
(WebCore::createGridTrackList):
(WebCore::StyleResolver::resolveVariables):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::StyleResolver::checkForTextSizeAdjust):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::setFontSize):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::cachedOrPendingStyleShaderFromValue):
(WebCore::StyleResolver::loadPendingShaders):
(WebCore::StyleResolver::parseCustomFilterTransformParameter):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingImages):
(WebCore::StyleResolver::reportMemoryUsage):

  • css/StyleResolver.h:

(WebCore::StyleResolver::style):
(WebCore::StyleResolver::parentStyle):
(WebCore::StyleResolver::rootElementStyle):
(WebCore::StyleResolver::element):
(WebCore::StyleResolver::setFontDescription):
(WebCore::StyleResolver::setZoom):
(WebCore::StyleResolver::setEffectiveZoom):
(WebCore::StyleResolver::setTextSizeAdjust):
(WebCore::StyleResolver::setWritingMode):
(WebCore::StyleResolver::setTextOrientation):
(WebCore::StyleResolver::hasParentNode):
(WebCore::StyleResolver::addMatchedRule):
(StyleResolver):
(State):
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::applyPropertyToRegularStyle):
(WebCore::StyleResolver::applyPropertyToVisitedLinkStyle):
Added "m_state." to access member variables used for per-resolve logic.

10:58 PM Changeset in webkit [141741] by tkent@chromium.org
  • 4 edits in trunk

Support setLangAttributeAwareFormControlUIEnabled on Chromium Windows XP
https://bugs.webkit.org/show_bug.cgi?id=108791

Reviewed by Kentaro Hara.

Source/WebCore:

We didn't support setLangAttributeAwareFormControlUIEnabled(true) on
Chromium Windows XP because of lack of LocaleNameToLCID API. This change
add manual mapping from locale names to LCIDs for Windows XP.

No new tests. This doesn't make any behavior changes in products, and
this improves some test results.

  • platform/text/win/LocaleWin.cpp:

(WebCore): Define NameToLCIDMap.
(WebCore::removeLastComponent):
Remove the last component separated with '-'.
(WebCore::ensureNameToLCIDMap):
Add locale names used in layout tests.
(WebCore::convertLocaleNameToLCID):
Find an appropriate LCID longest matching with the specified locale name.
(WebCore::LCIDFromLocale):
Use convertLocaleNameToLCID if LocaleNameToLCID is not available.

LayoutTests:

  • platform/chromium/TestExpectations:

Mark affected tests failure.
Actually we should be able to remove XP-specific test results for
them. We just mark them in this patch just in case, and do rebaseline
later.

10:17 PM Changeset in webkit [141740] by morrita@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, marking some as timing out.

  • platform/chromium/TestExpectations:
10:16 PM Changeset in webkit [141739] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

PatchLogs are not getting created on QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=108593

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-03
Reviewed by Eric Seidel.

Added missing "added" patch event to submit-to-ews handler.

  • QueueStatusServer/app.yaml:
  • QueueStatusServer/handlers/submittoews.py:

(SubmitToEWS._add_attachment_to_ews_queues):

10:11 PM Changeset in webkit [141738] by tkent@chromium.org
  • 24 edits in trunk/Source/WebCore

Add FocusDirection argument to HTMLTextFormControlElement::handleFocusEvent
https://bugs.webkit.org/show_bug.cgi?id=108775

Reviewed by Hajime Morita.

We'd like to add a FocusDirection argument to
HTMLTextFormControlElement::handleFocusEvent in order to fix Bug

  1. This is a preparation for it.

We need to add FocusDirection arguments to some focus-related functions
to pass it correctly when TAB or Shift+TAB is pressed.

No new tests. This doesn't make any behavior changes.

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
To pass the FocusDirection argument to handleFocusEvent, we need to add
it to dispatchFocusEvent too.

  • html/HTMLTextFormControlElement.h:

(HTMLTextFormControlElement):
Add FocusDirection arugment to dispatchFocusEvent.
(WebCore::HTMLTextFormControlElement::handleFocusEvent):
Add FocusDirection argument.

  • dom/Node.cpp:

(WebCore::Node::dispatchFocusEvent): Add FocusDirection argument.

  • dom/Node.h:

(Node): Ditto.

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode): Add FocusDirection argument in
order to pass it to Node::dispatchFocusEvent.

  • dom/Document.h:

(Document): Ditto.

  • page/FocusController.cpp:

(WebCore::dispatchEventsOnWindowAndFocusedNode):
Adjust Node::dispatchFocusEvent argument.
(WebCore::FocusController::advanceFocusInDocumentOrder):
Pass FocusDirectio to Element::focus.
(WebCore::FocusController::setFocusedNode):
Add FocusDirection argument in order to pass it to Document::setFocusedNode.
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
Pass FocusDirectio to Element::focus.

  • page/FocusController.h:

(FocusController): Add FocusDirection argument to setFocusedNode.

  • dom/Element.cpp:

(WebCore::Element::focus):
Add FocusDirection argument to pass it to FocusController::setFocusedNode.

  • dom/Element.h:

(Element): Ditto.

  • WebCore.exp.in:

Update FocusController::setFocusedNode and Document::setFocusedNode.

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::focus): Adjust FocusDirection argument.

  • html/HTMLLabelElement.h:

(HTMLLabelElement): Ditto.

  • html/HTMLLegendElement.cpp:

(WebCore::HTMLLegendElement::focus): Ditto.

  • html/HTMLLegendElement.h:

(HTMLLegendElement): Ditto.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::dispatchFocusEvent): Ditto.

  • html/HTMLSelectElement.h:

(HTMLSelectElement): Ditto.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultFocus):
Add FocusDirection argument in order to pass it from
HTMLInputElement::focus() to HTMLTextFormControlElement::focus().
(WebCore::HTMLInputElement::focus):
Pass the FocusDirection argument to InputType::focus. See above.
(WebCore::HTMLInputElement::handleFocusEvent):
Adjust FocusDirection argument.

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:

(WebCore::InputType::focus): Add FocusDirection argument.

  • html/InputType.h:

(InputType): Ditto.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::focus):
Add FocusDirection argument to follow InputType.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType): Ditto.

10:02 PM Changeset in webkit [141737] by morrita@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, marking terminate-during-sync-operation.html as timing out.

  • platform/chromium/TestExpectations:
9:59 PM Changeset in webkit [141736] by commit-queue@webkit.org
  • 16 edits in trunk/Source/WebKit

Fix build warning after r141473
https://bugs.webkit.org/show_bug.cgi?id=108782

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-03
Reviewed by Kentaro Hara.

Fix -Wunused-parameter build warning.

Source/WebKit/blackberry:

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::getClientPasteboardDataForRange):

Source/WebKit/chromium:

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::getClientPasteboardDataForRange):

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::getClientPasteboardDataForRange):

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::getClientPasteboardDataForRange):

Source/WebKit/qt:

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::getClientPasteboardDataForRange):

Source/WebKit/win:

  • WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::getClientPasteboardDataForRange):

Source/WebKit/wince:

  • WebCoreSupport/EditorClientWinCE.cpp:

(WebKit::EditorClientWinCE::getClientPasteboardDataForRange):

Source/WebKit/wx:

  • WebKitSupport/EditorClientWx.cpp:

(WebCore::EditorClientWx::getClientPasteboardDataForRange):

9:11 PM Changeset in webkit [141735] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk/Source/WebCore

Adds usage instrumentation for indexedDB
Includes new header file in project files

https://bugs.webkit.org/show_bug.cgi?id=107772

Patch by Kassy Coan <kassycoan@chromium.org> on 2013-02-03
Reviewed by Tony Chang.

Currently untestable. Has zero effect apart from histogramming.

  • GNUmakefile.list.am:
  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):

  • Modules/indexeddb/IDBHistograms.h: Added.

(WebCore):

  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
8:54 PM Changeset in webkit [141734] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Unreviewed. Add dstockwell as a contributor in comitters.py and to the watchlist for animation
https://bugs.webkit.org/show_bug.cgi?id=108777

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2013-02-03

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/watchlist:
8:53 PM Changeset in webkit [141733] by hayato@chromium.org
  • 8 edits
    2 adds in trunk/Source/WebCore

Split default style-sheet statics out from StyleResolver into its own class
https://bugs.webkit.org/show_bug.cgi?id=107780

Reviewed by Dimitri Glazkov.

Factored static variables and logic about default style sheets out from StyleResolver into its own class
CSSDefaultStyleSheets. This is a following patch after r141373.

No new tests, refactoring only.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/CSSDefaultStyleSheets.cpp: Added.

(WebCore):
(WebCore::elementCanUseSimpleDefaultStyle):
(WebCore::screenEval):
(WebCore::printEval):
(WebCore::parseUASheet):
(WebCore::CSSDefaultStyleSheets::initDefaultStyle):
(WebCore::CSSDefaultStyleSheets::loadFullDefaultStyle):
(WebCore::CSSDefaultStyleSheets::loadSimpleDefaultStyle):
(WebCore::CSSDefaultStyleSheets::viewSourceStyle):
(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

  • css/CSSDefaultStyleSheets.h: Added.

(WebCore):
(CSSDefaultStyleSheets):

  • css/StyleResolver.cpp:

(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::reportMemoryUsage):

8:27 PM FeatureFlags edited by tkent@chromium.org
Rename CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to … (diff)
8:25 PM Changeset in webkit [141732] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix build warning after r141648
https://bugs.webkit.org/show_bug.cgi?id=108784

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-03
Reviewed by Kentaro Hara.

Fix -Wunused-parameter build warning.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::createStorageArea):
(WebKit::StorageManager::destroyStorageArea):

8:04 PM Changeset in webkit [141731] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Do not call m_widgetClient->show() for WebHelperPlugin.
https://bugs.webkit.org/show_bug.cgi?id=108740

Patch by David Dorwin <ddorwin@chromium.org> on 2013-02-03
Reviewed by Kent Tamura.

The calls to m_widgetClient->show() and setFocus() do not appear to be
necessary, and the former causes problems on at least on platform.

  • src/WebHelperPluginImpl.cpp:

(WebKit::WebHelperPluginImpl::initialize): Removed calls to m_widgetClient->show() and setFocus().
(WebKit::WebHelperPluginImpl::setFocus): Should never be called.

7:22 PM Changeset in webkit [141730] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Simplify CodeGeneratorV8.pm by using InheritsExtendedAttribute("EventTarget")
https://bugs.webkit.org/show_bug.cgi?id=108441

Reviewed by Adam Barth.

A complicated condition in GetInternalFields() can be simplified
by using InheritsExtendedAttribute("EventTarget").

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GetInternalFields):

  • dom/EventTarget.idl: Added [EventTarget] which should have been added.
  • svg/SVGElementInstance.idl: Ditto.
7:09 PM Changeset in webkit [141729] by weinig@apple.com
  • 2 edits in trunk/Tools

Fix failing test.

  • TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:

(TestWebKitAPI::didFinishLoadForFrame):

6:55 PM Changeset in webkit [141728] by morrita@google.com
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Unreviewed rebaselining.

  • platform/chromium-mac-lion/fast/css/resize-corner-tracking-transformed-iframe-expected.png: Added.
6:16 PM Changeset in webkit [141727] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore

[Soup] Do not use local variables for the client
https://bugs.webkit.org/show_bug.cgi?id=108714

Reviewed by Martin Robinson.

Covered by existing tests, refactoring code only.

We have had problems in the past with the client being destroyed or
changed inside a method or function, and we ended up with a stale
pointer, leading to crashes. This refactoring is an effort to minimize
the possibility of hitting that same issue in the future.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::redirectSkipCallback): no longer use a local variable to hold
the client.
(WebCore::wroteBodyDataCallback): ditto.
(WebCore::nextMultipartResponsePartCallback): ditto.
(WebCore::sendRequestCallback): ditto.
(WebCore::closeCallback): ditto.
(WebCore::readCallback): ditto.

6:15 PM Changeset in webkit [141726] by morrita@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, marking grid-preferred-logical-widths.html as a fail.

  • platform/chromium/TestExpectations:
5:54 PM Changeset in webkit [141725] by morrita@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, marking block-test.html as a fail.

  • platform/chromium/TestExpectations:
5:37 PM Changeset in webkit [141724] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Skip editing/inserting/smart-link-when-caret-is-moved-before-URL.html
https://bugs.webkit.org/show_bug.cgi?id=85463

Test added in http://trac.webkit.org/changeset/141618 - requires that DRT or WKTR
implement setAutomaticLinkDetectionEnabled().

Unreviewed gardening.

  • platform/chromium/TestExpectations:
5:03 PM Changeset in webkit [141723] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Make ChangeLogEntry detect annotations by prepare-ChangeLog (Added/Removed/Copied from/Renamed from) as clean.
https://bugs.webkit.org/show_bug.cgi?id=108433

Patch by Timothy Loh <timloh@chromium.com> on 2013-02-03
Reviewed by Eric Seidel.

PrepareChangeLog is supposed to update the file/function list if we
haven't touched it, but the existing regex doesn't handle the
annotations prepare-ChangeLog adds (e.g. "Added.")

  • Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLogEntry.is_touched_files_text_clean):

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:

(test_is_touched_files_text_clean):

4:47 PM Changeset in webkit [141722] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

calendar-picker-key-operations.html is failing
https://bugs.webkit.org/show_bug.cgi?id=108566

Reviewed by Kentaro Hara.

  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:

Month.createFromDate supports only UTC Date. Use the Month constructor
with local year and local month.

4:43 PM Changeset in webkit [141721] by haraken@chromium.org
  • 18 edits in trunk/Source/WebCore

[V8] Pass an Isolate to HasInstance() (part 1)
https://bugs.webkit.org/show_bug.cgi?id=108617

Reviewed by Adam Barth.

This is one of efforts to pass an Isolate to GetTemplate().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(JSValueToNative):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::dispatchEventCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod8Callback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::constructor1Callback):
(WebCore::V8TestOverloadedConstructors::constructor2Callback):
(WebCore::V8TestOverloadedConstructors::constructor3Callback):

  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::visitNodeWrappers):

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::deserialize):

  • bindings/v8/V8Binding.cpp:

(WebCore::toDOMStringList):
(WebCore::toXPathNSResolver):

  • bindings/v8/V8Binding.h:

(WebCore):

  • bindings/v8/V8Collection.cpp:

(WebCore::toOptionsCollectionSetter):

  • bindings/v8/V8GCController.cpp:

(WebCore::WrapperVisitor::WrapperVisitor):
(WrapperVisitor):
(WebCore::V8GCController::majorGCPrologue):

  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):

  • bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):

4:01 PM Changeset in webkit [141720] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[GTK] Make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=108756

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2013-02-03
Reviewed by Kentaro Hara.

Source/WebCore:

  • GNUmakefile.list.am: Remove header files which no longer exist;

correct one which got added incorrectly.

Source/WebKit2:

  • GNUmakefile.list.am: Remove header files which no longer exist
3:53 PM Changeset in webkit [141719] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Pass an Isolate to HasInstance() (part 3)
https://bugs.webkit.org/show_bug.cgi?id=108622

Reviewed by Adam Barth.

This is one of efforts to pass an Isolate to GetTemplate().

No tests. No change in behavior.

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):
(WebCore::V8InjectedScriptHost::typeCallback):
(WebCore::V8InjectedScriptHost::getEventListenersCallback):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toWebGLUniformLocation):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::isDocumentType):
(WebCore::V8XMLHttpRequest::sendCallback):

3:26 PM Changeset in webkit [141718] by haraken@chromium.org
  • 13 edits in trunk/Source/WebCore

[V8] Pass an Isolate to HasInstance() (part 2)
https://bugs.webkit.org/show_bug.cgi?id=108620

Reviewed by Adam Barth.

This is one of efforts to pass an Isolate to GetTemplate().

No tests. No change in behavior.

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):

  • bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAccessorSetter):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallbackCustom):

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toCanvasStyle):
(WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorSetter):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::setDragImageCallback):

  • bindings/v8/custom/V8CryptoCustom.cpp:

(WebCore::V8Crypto::getRandomValuesCallback):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCallbackCustom):
(WebCore::V8DOMFormData::appendCallback):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallbackCustom):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):

  • bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAccessorSetter):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::addCallback):

  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::removeElement):

10:35 AM Changeset in webkit [141717] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebCore

Cleanup: 'ExceptionCode& ec', not 'ExceptionCode &ec'.
https://bugs.webkit.org/show_bug.cgi?id=108769

Reviewed by Eric Seidel.

Does what it says on the tin: reference parameters should read
'type& name', and this patch fixes the two occurances of 'type &name'
that cropped up for ExceptionCode.

Pure style change; no effect on behavior.

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):

5:37 AM Changeset in webkit [141716] by akling@apple.com
  • 8 edits in trunk/Source

Vector should consult allocator about ideal size when choosing capacity.
<http://webkit.org/b/108410>
<rdar://problem/13124002>

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

Remove assertion about Vector capacity that won't hold anymore since capacity()
may not be what you passed to reserveCapacity().
Also export WTF::fastMallocGoodSize() for Windows builds.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

Source/WTF:

Added WTF::fastMallocGoodSize(), a workalike/wrapper for OS X's malloc_good_size().
It returns the actual size of the block that will get allocated for a given byte size.

Vector's internal buffer now checks with the allocator if the resulting allocation
could actually house more objects and updates its capacity to make use of the space.

  • wtf/Deque.h:

(WTF::::expandCapacity):

  • wtf/FastMalloc.cpp:

(WTF::fastMallocGoodSize):

  • wtf/FastMalloc.h:
  • wtf/Vector.h:

(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):

4:17 AM Changeset in webkit [141715] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Mark inspector/debugger/source-frame-count.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=108768

Unreviewed EFL gardening.

Mark inspector/debugger/source-frame-count.html as flaky as it sometimes
crashes due to Bug 81574.

Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-03

  • platform/efl-wk2/TestExpectations:
2:48 AM Changeset in webkit [141714] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Mark a few more media tests as flaky due to gstreamer 1.0
https://bugs.webkit.org/show_bug.cgi?id=108765

Unreviewed EFL gardening.

Mark 2 more media tests as flaky since the update to gstreamer 1.0.
They sometimes crash in MediaPlayerPrivateGStreamer dtor.

Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-03

  • platform/efl/TestExpectations:
2:42 AM Changeset in webkit [141713] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[EFL] svg/custom/text-ctm.svg needs a baseline
https://bugs.webkit.org/show_bug.cgi?id=108764

Unreviewed EFL gardening.

Add baseline for svg/custom/text-ctm.svg that was added in r17879.

Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-03

  • platform/efl/svg/custom/text-ctm-expected.png: Added.
  • platform/efl/svg/custom/text-ctm-expected.txt: Added.
Note: See TracTimeline for information about the timeline view.