Context Navigation

← Previous Period
Next Period →

Timeline

Feb 11, 2013:

11:58 PM Changeset in webkit [142589] by commit-queue@webkit.org

4 edits in trunk/Tools

webkit-patch upload regenerates the WebCore ChangeLog every time it's called
https://bugs.webkit.org/show_bug.cgi?id=108983

Patch by Timothy Loh <timloh@chromium.com> on 2013-02-11
Reviewed by Ryosuke Niwa.

This patch puts the behaviour from Bug 74358 behind the flag (default=OFF)
--update-changelogs', and removes the flag --no-prepare-changelogs'.
The flag name change from prepare to update is since we still want to
prepare changelogs in the default case when none currently exist.

Scripts/webkitpy/tool/commands/commandtest.py:

(CommandsTest.assert_execute_outputs):

Scripts/webkitpy/tool/steps/options.py:

(Options):

Scripts/webkitpy/tool/steps/preparechangelog.py:

(PrepareChangeLog.options):
(PrepareChangeLog.run):

11:31 PM Changeset in webkit [142588] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Remove webintents from TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=109537

Unreviewed. webintents tests no longer exist.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-11

platform/efl/TestExpectations:

11:26 PM Changeset in webkit [142587] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[Qt][EFL][WebGL] Minor refactoring of GraphicsSurface/GraphicsSurfaceGLX
https://bugs.webkit.org/show_bug.cgi?id=108686

Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2013-02-11
Reviewed by Noam Rosenthal.

Remove unused platformSurface()/m_platformSurface from GraphicsSurface.
Move m_texture from GraphicsSurface to GLX GraphicsSurfacePrivate to match
Win and Mac implementations.

No new tests, refactoring only.

platform/graphics/surfaces/GraphicsSurface.cpp:

(WebCore::GraphicsSurface::GraphicsSurface):

platform/graphics/surfaces/GraphicsSurface.h:

(GraphicsSurface):

platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::swapBuffers):
(WebCore::GraphicsSurfacePrivate::surface):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::textureID):
(WebCore::GraphicsSurfacePrivate::clear):
(WebCore::GraphicsSurface::platformExport):
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
(WebCore::GraphicsSurface::platformDestroy):

11:24 PM Changeset in webkit [142586] by commit-queue@webkit.org

4 edits
3 adds in trunk

[EFL][WebGL] WebGL content is not painted after resizing the viewport.
https://bugs.webkit.org/show_bug.cgi?id=106358

Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2013-02-11
Reviewed by Noam Rosenthal.

Source/WebCore:

When page size changes and layer parameters get updated LayerTreeRenderer::setLayerState
clears the layer backing store and detaches the canvas surface from the layer. If the layer
size is not changed then the canvas is not recreated. This leaves the canvas detached from
the layer, but still referenced from m_surfaceBackingStores.
Don't assign layer backing store to layer in assignImageBackingToLayer if there is a canvas
surface already attached to the layer.

Test: fast/canvas/webgl/webgl-layer-update.html

platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::setLayerState):
(WebCore::CoordinatedGraphicsScene::assignImageBackingToLayer):

platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

LayoutTests:

Add test checking that canvas painting is correct if layer parameters were changed,
but webgl canvas didn't change.

fast/canvas/webgl/webgl-layer-update-expected.png: Added.
fast/canvas/webgl/webgl-layer-update-expected.txt: Added.
fast/canvas/webgl/webgl-layer-update.html: Added.

11:19 PM Changeset in webkit [142585] by jochen@chromium.org

5 edits in trunk/Tools

[chromium] move printPage() implementation to testRunner library
https://bugs.webkit.org/show_bug.cgi?id=109436

Reviewed by Adam Barth.

DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestRunner::WebTestProxy::showContextMenu):
(WebTestRunner::WebTestProxy::printPage):

DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner):
(WebTestRunner::WebTestProxyBase::printPage):

DumpRenderTree/chromium/WebViewHost.cpp:
DumpRenderTree/chromium/WebViewHost.h:

10:50 PM Changeset in webkit [142584] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Some placeholder paint order tests are passing now
https://bugs.webkit.org/show_bug.cgi?id=109164

Unreviewed efl gardening.

fast/forms/input-placeholder-paint-order.html and
fast/forms/textarea/textarea-placeholder-paint-order.html are passing now.

RenderTheme::shouldShowPlaceholderWhenFocused() returns true by r127723
and the expectations are added by r140149.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-11

platform/efl/TestExpectations:

10:49 PM Changeset in webkit [142583] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Remove editing/deleting/deletionUI-single-instance.html from TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=109538

Unreviewed. This test is removed by r142559.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-11

platform/efl/TestExpectations:

10:46 PM Changeset in webkit [142582] by commit-queue@webkit.org

7 edits
3 deletes in trunk

[Chromium] Get rid of WebAnimationController
https://bugs.webkit.org/show_bug.cgi?id=109235

Patch by James Robinson <jamesr@chromium.org> on 2013-02-11
Reviewed by Benjamin Poulain.

Source/WebKit/chromium:

public/WebAnimationController.h: Removed.
public/WebFrame.h:

(WebFrame):

src/WebAnimationControllerImpl.cpp: Removed.
src/WebAnimationControllerImpl.h: Removed.
src/WebFrameImpl.cpp:
src/WebFrameImpl.h:

(WebFrameImpl):

Tools:

DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):

DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

10:42 PM Changeset in webkit [142581] by jamesr@google.com

6 edits in trunk/Source

[chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=109403

Reviewed by Adam Barth.

Source/Platform:

webkit_unit_tests that need compositing support need only a simple WebLayerTreeView implementation, not the full
thing.

chromium/public/WebCompositorSupport.h:

(WebCompositorSupport):
(WebKit::WebCompositorSupport::createLayerTreeView):

chromium/public/WebUnitTestSupport.h:

(WebKit):
(WebUnitTestSupport):
(WebKit::WebUnitTestSupport::createLayerTreeViewForTesting):

Source/WebKit/chromium:

tests/GraphicsLayerChromiumTest.cpp:

(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):

tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::FakeWebViewClient::initializeLayerTreeView):

10:30 PM Changeset in webkit [142580] by eric.carlson@apple.com

22 edits
2 adds in trunk

[Mac] Track language selection should be sticky
https://bugs.webkit.org/show_bug.cgi?id=109466

Reviewed by Dean Jackson.

Source/autotools/symbols.filter: Export PageGroup::captionPreferences and Page::initGroup.

Source/WebCore:

Choosing a text track from the caption menu should make that track's language the
preferred caption language. Turning captions off from the menu should disable captions
in videos loaded subsequently.

OS X has system support for these settings, so changes made by DRT should not change the
settings on the user's system. Add support for all other ports in DRT only.

Test: media/track/track-user-preferences.html

WebCore.exp.in: Export PageGroup::captionPreferences().

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Use page()->group().captionPreferences().
(WebCore::HTMLMediaElement::attach): Ditto.
(WebCore::HTMLMediaElement::detach): Ditto.
(WebCore::HTMLMediaElement::userPrefersCaptions): Ditto.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Ditto. Update for

preferredLanguageFromList change.

(WebCore::HTMLMediaElement::toggleTrackAtIndex): Set user prefs for captions visible and

caption language as appropriate.

html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler): Remove unneeded comment.
(WebCore::MediaControlTextTrackContainerElement::updateSizes): Use page()->group().captionPreferences().

html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsApple::closedCaptionTracksChanged): Update caption menu button visibility.

page/CaptionUserPreferences.h:

(WebCore::CaptionUserPreferences::userPrefersCaptions): Support "testing" mode.
(WebCore::CaptionUserPreferences::setUserPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferences::registerForPreferencesChangedCallbacks): Ditto.
(WebCore::CaptionUserPreferences::unregisterForPreferencesChangedCallbacks): Ditto.
(WebCore::CaptionUserPreferences::setPreferredLanguage): Ditto.
(WebCore::CaptionUserPreferences::preferredLanguages): Ditto.
(WebCore::CaptionUserPreferences::testingMode): Ditto.
(WebCore::CaptionUserPreferences::setTestingMode): Ditto.
(WebCore::CaptionUserPreferences::CaptionUserPreferences): Ditto.

page/CaptionUserPreferencesMac.h:
page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::userPrefersCaptions): Support "testing" mode.
(WebCore::CaptionUserPreferencesMac::setUserPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferencesMac::userHasCaptionPreferences): Ditto.
(WebCore::CaptionUserPreferencesMac::registerForPreferencesChangedCallbacks): Change name from

registerForCaptionPreferencesChangedCallbacks. Support "testing" mode.

(WebCore::CaptionUserPreferencesMac::unregisterForPreferencesChangedCallbacks): Change name from

unregisterForCaptionPreferencesChangedCallbacks. Support "testing" mode.

(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Support "testing" mode.
(WebCore::CaptionUserPreferencesMac::captionFontSizeScale): Ditto.
(WebCore::CaptionUserPreferencesMac::setPreferredLanguage): Ditto.
(WebCore::CaptionUserPreferencesMac::preferredLanguages): Ditto. Return the platform override when set.

page/PageGroup.cpp:

(WebCore::PageGroup::registerForCaptionPreferencesChangedCallbacks): Remove because it is already

available from the caption preference object.

(WebCore::PageGroup::unregisterForCaptionPreferencesChangedCallbacks): Ditto.
(WebCore::PageGroup::userPrefersCaptions): Ditto.
(WebCore::PageGroup::userHasCaptionPreferences): Ditto.
(WebCore::PageGroup::captionFontSizeScale): Ditto.

page/PageGroup.h:

platform/Language.cpp:

(WebCore::preferredLanguageFromList): Take the list of preferred languages instead of assuming

the system list.

platform/Language.h:

testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState): Disable caption testing mode.
(WebCore::Internals::Internals): Enable caption testing mode so the user's system

preferences are not modified.

LayoutTests:

media/track/track-user-preferences-expected.txt: Added.
media/track/track-user-preferences.html: Added.

platform/chromium/TestExpectations: Skip new test, it depends on the track menu.
platform/efl/TestExpectations: Ditto.
platform/gtk/TestExpectations: Ditto.
platform/qt/TestExpectations: Ditto.
platform/win/TestExpectations: Ditto.

10:26 PM Changeset in webkit [142579] by commit-queue@webkit.org

11 edits in trunk/Source

Coordinated Graphics: Make CoordinatedGraphicsScene not know contents size.
https://bugs.webkit.org/show_bug.cgi?id=108922

Source/WebCore:

Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-11
Reviewed by Noam Rosenthal.

Currently, CoordinatedGraphicsScene has two methods to know contents
size: setContentsSize() and setVisibleContentsRect(). Contents size is
used when adjusting a scroll position, but adjustment is not needed
because EFL and Qt platform code (currently PageViewportController)
already adjusts a scroll position, and it is natural for each platform
to be in charge of adjusting. So this patch makes CoordinatedGraphicsScene
not know contents size.

In addition, now DrawingAreaProxy::coordinatedLayerTreeHostProxy() is only used
to get CoordinatedGraphicsScene.

This patch can only be tested manually since there is no automated
testing facilities for in-motion touch.
Test: ManualTests/fixed-position.html

ManualTests/nested-fixed-position.html

platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):

platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::setScrollPosition):
(WebCore::CoordinatedGraphicsScene::adjustPositionForFixedLayers):

platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

(CoordinatedGraphicsScene):

Source/WebKit2:

Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-11
Reviewed by Noam Rosenthal.
Signed off for WebKit2 by Benjamin Poulain.

In addition, now DrawingAreaProxy::coordinatedLayerTreeHostProxy() is only used
to get CoordinatedGraphicsScene.

UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::updateSize):

UIProcess/API/qt/raw/qrawwebview.cpp:

(QRawWebView::setSize):

UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:

(WebKit::CoordinatedLayerTreeHostProxy::setVisibleContentsRect):

UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:

(CoordinatedLayerTreeHostProxy):

UIProcess/efl/PageClientLegacyImpl.cpp:

(WebKit::PageClientLegacyImpl::didChangeContentsSize):

UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):

9:29 PM Changeset in webkit [142578] by commit-queue@webkit.org

9 edits in trunk/Source

Coordinated Graphics: remove the DidChangeScrollPosition message.
https://bugs.webkit.org/show_bug.cgi?id=108051

Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-11
Reviewed by Noam Rosenthal.
Signed off for WebKit2 by Benjamin Poulain.

Currently, we use the DidChangeScrollPosition message to send the scroll
position that WebCore used in this frame to UI Process. We had to have
some member variables for the DidChangeScrollPosition message.
However, we can send a scroll position via the DidRenderFrame message,
because CoordinatedGraphicsScene::m_renderedContentsScrollPosition is
updated at the moment of flushing. So we can remove the
DidChangeScrollPosition message and some redundant member variables.

Source/WebCore:

No tests. No change in behavior.

platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::flushLayerChanges):

platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

(CoordinatedGraphicsScene):

Source/WebKit2:

UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:

(WebKit::CoordinatedLayerTreeHostProxy::didRenderFrame):
(WebKit):

UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:

(CoordinatedLayerTreeHostProxy):

UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in: Remove the DidChangeScrollPosition message.
WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::flushPendingLayerChanges):

Send a scroll position via the DidChangeScrollPosition message.

(WebKit::CoordinatedLayerTreeHost::syncLayerState):

Don't send a scroll position because flushPendingLayerChanges() does
that. In addition, it is weird to check if we must send a scroll
position at the moment of sending the SyncLayerState message of every
layers.

(WebKit::CoordinatedLayerTreeHost::setVisibleContentsRect):

WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

9:11 PM Changeset in webkit [142577] by oliver@apple.com

2 edits in trunk/Source/WTF

Build fix.

8:55 PM Changeset in webkit [142576] by rniwa@webkit.org

40 edits in trunk

Disable delete button controller on non-Mac ports and delete EditorClient::shouldShowDeleteInterface
https://bugs.webkit.org/show_bug.cgi?id=109534

Reviewed by Anders Carlsson.

Source/WebCore:

editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::show):

editing/Editor.cpp:

(WebCore):

editing/Editor.h:

(Editor):

loader/EmptyClients.h:

(WebCore::EmptyEditorClient::shouldDeleteRange):
(EmptyEditorClient):
(WebCore::EmptyEditorClient::shouldShowDeleteInterface):

page/EditorClient.h:

(EditorClient):

Source/WebKit/blackberry:

WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore):

WebCoreSupport/EditorClientBlackBerry.h:

(EditorClientBlackBerry):

Source/WebKit/chromium:

src/EditorClientImpl.cpp:

(WebKit):

src/EditorClientImpl.h:

(EditorClientImpl):

Source/WebKit/efl:

WebCoreSupport/EditorClientEfl.cpp:

(WebCore):

WebCoreSupport/EditorClientEfl.h:

(EditorClientEfl):

Source/WebKit/gtk:

WebCoreSupport/EditorClientGtk.cpp:

(WebKit):

WebCoreSupport/EditorClientGtk.h:

(EditorClient):

webkit/webkitwebview.cpp:

(webkit_web_view_class_init):

Source/WebKit/mac:

WebCoreSupport/WebEditorClient.h:

Source/WebKit/qt:

WebCoreSupport/EditorClientQt.cpp:

(WebCore):

WebCoreSupport/EditorClientQt.h:

(EditorClientQt):

Source/WebKit/win:

WebCoreSupport/WebEditorClient.cpp:
WebCoreSupport/WebEditorClient.h:

(WebEditorClient):

Source/WebKit/wince:

WebCoreSupport/EditorClientWinCE.cpp:

(WebKit):

WebCoreSupport/EditorClientWinCE.h:

(EditorClientWinCE):

Source/WebKit/wx:

WebKitSupport/EditorClientWx.cpp:

(WebCore):

WebKitSupport/EditorClientWx.h:

(EditorClientWx):

Source/WebKit2:

WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit):

WebProcess/WebCoreSupport/WebEditorClient.h:

Source/WTF:

wtf/Platform.h:

Tools:

DumpRenderTree/gtk/EditingCallbacks.cpp:

(shouldShowDeleteInterfaceForElement):

8:43 PM Changeset in webkit [142575] by hayato@chromium.org

7 edits in trunk/Source/WebCore

Factor EventContext and introduces MouseOrFocusEventContext.
https://bugs.webkit.org/show_bug.cgi?id=109278

Reviewed by Dimitri Glazkov.

To supoort Touch event retargeting (bug 107800), we have to factor
event retargeting code so that it can support not only MouseEvent or FocusEvent,
but also other events.

This is the first attempt to refactor event retargeting code, a
separated patch from bug 109156. EventContext is now factored and
MouseOrFocusEventContext was introduced to support MouseEvent or
FocusEvent separately.

In following patches, I'll introduce TouchEventContext and
TouchEventDispatchMediator to support Touch event retargeting.

No new tests. No change in functionality.

dom/EventContext.cpp:

(WebCore::EventContext::EventContext): Factor relatedTarget out from EventContext into MouseOrFocusEventContext.
(WebCore::EventContext::~EventContext):
(WebCore):
(WebCore::EventContext::handleLocalEvents):
(WebCore::EventContext::isMouseOrFocusEventContext):
(WebCore::MouseOrFocusEventContext::MouseOrFocusEventContext): New. Handles MouseEvent's (or FocusEvent's) relatedTarget retargeting.
(WebCore::MouseOrFocusEventContext::~MouseOrFocusEventContext):
(WebCore::MouseOrFocusEventContext::handleLocalEvents):
(WebCore::MouseOrFocusEventContext::isMouseOrFocusEventContext):

dom/EventContext.h:

(EventContext):
(WebCore::EventContext::node):
(WebCore::EventContext::target):
(WebCore::EventContext::currentTargetSameAsTarget):
(WebCore):
(MouseOrFocusEventContext):
(WebCore::MouseOrFocusEventContext::relatedTarget):
(WebCore::MouseOrFocusEventContext::setRelatedTarget):

dom/EventDispatcher.cpp:

(WebCore::EventRelatedTargetAdjuster::adjust):
(WebCore::EventDispatcher::adjustRelatedTarget):
(WebCore::EventDispatcher::ensureEventPath): Renamad from ensureEventAncestors. Use the DOM Core terminology.
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtTarget):
(WebCore::EventDispatcher::dispatchEventAtBubbling):
(WebCore::EventDispatcher::dispatchEventPostProcess):
(WebCore::EventDispatcher::topEventContext):

dom/EventDispatcher.h:

(EventRelatedTargetAdjuster):
(EventDispatcher):

inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::eventHasListeners):
(WebCore::InspectorInstrumentation::willDispatchEventImpl):

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willDispatchEvent):

8:34 PM Changeset in webkit [142574] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[Curl] setCookiesFromDOM function does not save cookies to disk.
https://bugs.webkit.org/show_bug.cgi?id=109285

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-02-11
Reviewed by Brent Fulgham.

Write cookies to disk by using the Curl easy api.

platform/network/curl/CookieJarCurl.cpp:

(WebCore::setCookiesFromDOM):Write cookie to disk.

platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::getCurlShareHandle): Added method to get Curl share handle.
(WebCore::ResourceHandleManager::getCookieJarFileName): Added method to get cookie file name.

platform/network/curl/ResourceHandleManager.h: Added methods to get cookie file name, and Curl share handle.

8:32 PM Changeset in webkit [142573] by hayato@chromium.org

10 edits
2 adds in trunk/Source/WebCore

Split each RuleSet and feature out from StyleResolver into its own class.
https://bugs.webkit.org/show_bug.cgi?id=107777

Reviewed by Dimitri Glazkov.

Re-landing r141964, which was reverted in r141973, since r141964 seem to be innocent.

No tests. No change in behavior.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
css/CSSAllInOne.cpp:
css/DocumentRuleSets.cpp: Added.

(WebCore):
(WebCore::DocumentRuleSets::DocumentRuleSets):
(WebCore::DocumentRuleSets::~DocumentRuleSets):
(WebCore::DocumentRuleSets::initUserStyle): New helper to initialize each RuleSets.
(WebCore::DocumentRuleSets::collectRulesFromUserStyleSheets): Factored out from StyleResolver.
(WebCore::makeRuleSet): Ditto.
(WebCore::DocumentRuleSets::resetAuthorStyle): Ditto.
(WebCore::DocumentRuleSets::appendAuthorStyleSheets): Ditto.
(WebCore::DocumentRuleSets::collectFeatures): Ditto.
(WebCore::DocumentRuleSets::reportMemoryUsage): New methods to report memory usage. Factored out from StyleResolver.

css/DocumentRuleSets.h: Added.

(WebCore):
(DocumentRuleSets):
(WebCore::DocumentRuleSets::authorStyle): Moved from StyleResolver.
(WebCore::DocumentRuleSets::userStyle): Ditto.
(WebCore::DocumentRuleSets::features): Ditto.
(WebCore::DocumentRuleSets::sibling): Ditto.
(WebCore::DocumentRuleSets::uncommonAttribute): Ditto.

css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::appendAuthorStyleSheets): Now calls DocumentRuleSets::appendAuthorStyleSheets.
(WebCore::StyleResolver::matchAuthorRules): Use m_ruleSets.
(WebCore::StyleResolver::matchUserRules): Ditto.
(WebCore::StyleResolver::classNamesAffectedByRules): Ditto.
(WebCore::StyleResolver::locateCousinList): Ditto.
(WebCore::StyleResolver::canShareStyleWithElement): Ditto.
(WebCore::StyleResolver::locateSharedStyle): Ditto.
(WebCore::StyleResolver::styleForPage): Ditto.
(WebCore::StyleResolver::checkRegionStyle): Ditto.
(WebCore::StyleResolver::applyProperty): Ditto.
(WebCore::StyleResolver::reportMemoryUsage): Now calls DocumentRuleSets::reportMemoryUsage.

css/StyleResolver.h:

(WebCore::StyleResolver::scopeResolver):
(StyleResolver):
(WebCore::StyleResolver::ruleSets): accessor r to DocumentRuleSets.
(WebCore::StyleResolver::usesSiblingRules): Use m_ruleSets.
(WebCore::StyleResolver::usesFirstLineRules): Ditto.
(WebCore::StyleResolver::usesBeforeAfterRules): Ditto.
(WebCore::StyleResolver::hasSelectorForAttribute): Ditto.
(WebCore::StyleResolver::hasSelectorForClass): Ditto.
(WebCore::StyleResolver::hasSelectorForId): Ditto.

dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

8:24 PM Changeset in webkit [142572] by keishi@webkit.org

6 edits
3 adds in trunk

REGRESSION (r140778):Calendar Picker buttons are wrong when rtl
https://bugs.webkit.org/show_bug.cgi?id=109158

Reviewed by Kent Tamura.

Source/WebCore:

The calendar picker button's icon and position where wrong when rtl.

Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html

Resources/pagepopups/calendarPicker.css:

(.year-month-button-left .year-month-button): Use -webkit-margin-end so the margin is applide to the right side.
(.year-month-button-right .year-month-button): Use -webkit-margin-start so the margin is applide to the right side.
(.today-clear-area .today-button): Use -webkit-margin-end so the margin is applide to the right side.

Resources/pagepopups/calendarPicker.js:

(YearMonthController.prototype._attachLeftButtonsTo): Flip icon image when rtl.
(YearMonthController.prototype._attachRightButtonsTo): Ditto.

LayoutTests:

platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
platform/chromium/TestExpectations:
platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.txt: Added.
platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html: Added.

8:23 PM Changeset in webkit [142571] by aelias@chromium.org

5 edits in trunk/Source/WebKit/chromium

[chromium] Apply page scale to all WebInputEvent types
https://bugs.webkit.org/show_bug.cgi?id=109370

Reviewed by James Robinson.

Previously we only adjusted a few common input event types by page
scale, but in fact almost every position and size in WebInputEvents
requires it.

I also took the opportunity to change some WebGestureEvent members to
floats (which I checked causes no warnings in Chromium-side code with
GCC or Clang).

New WebInputEventConversionTest: InputEventsScaling

public/WebInputEvent.h:

(WebKit::WebGestureEvent::WebGestureEvent):

src/WebInputEventConversion.cpp:

(WebKit::widgetScaleFactor):
(WebKit):
(WebKit::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
(WebKit::PlatformTouchPointBuilder::PlatformTouchPointBuilder):
(WebKit::updateWebMouseEventFromWebCoreMouseEvent):
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
(WebKit::addTouchPoints):
(WebKit::WebTouchEventBuilder::WebTouchEventBuilder):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::hasTouchEventHandlersAt):
(WebKit::WebViewImpl::handleInputEvent):

tests/WebInputEventConversionTest.cpp:

(WebCore::TEST):
(WebCore):

8:22 PM Changeset in webkit [142570] by commit-queue@webkit.org

2 edits
1 delete in trunk/Source/WebCore

REGRESSION (r142549): Remove web intents code
https://bugs.webkit.org/show_bug.cgi?id=109532

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-11
Reviewed by Nico Weber.

Remove remaning code related to web intents.

No new tests, no change on behavior.

UseJSC.cmake:
bindings/js/JSIntentConstructor.cpp: Removed.

8:17 PM Changeset in webkit [142569] by commit-queue@webkit.org

6 edits in trunk/Source

Unreviewed, rolling out r142568.
http://trac.webkit.org/changeset/142568
https://bugs.webkit.org/show_bug.cgi?id=109541

Broke the build, won't compile. (Requested by alancutter on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-11

Source/Platform:

chromium/public/WebCompositorSupport.h:

(WebCompositorSupport):
(WebKit::WebCompositorSupport::createLayerTreeView):

chromium/public/WebUnitTestSupport.h:

Source/WebKit/chromium:

tests/GraphicsLayerChromiumTest.cpp:

(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):

tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::FakeWebViewClient::initializeLayerTreeView):

6:50 PM Changeset in webkit [142568] by jamesr@google.com

6 edits in trunk/Source

[chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=109403

Reviewed by Adam Barth.

Source/Platform:

webkit_unit_tests that need compositing support need only a simple WebLayerTreeView implementation, not the full
thing.

chromium/public/WebCompositorSupport.h:

(WebCompositorSupport):
(WebKit::WebCompositorSupport::createLayerTreeView):

chromium/public/WebUnitTestSupport.h:

(WebKit):
(WebUnitTestSupport):
(WebKit::WebUnitTestSupport::createLayerTreeViewForTesting):

Source/WebKit/chromium:

tests/GraphicsLayerChromiumTest.cpp:

(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):

tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::FakeWebViewClient::initializeLayerTreeView):

6:38 PM Changeset in webkit [142567] by kbr@google.com

2 edits in trunk/Source/WebCore

Add temporary typedef to ANGLEWebKitBridge to support incompatible API upgrade
https://bugs.webkit.org/show_bug.cgi?id=109127

Reviewed by Dean Jackson.

No new tests. Built and tested WebKit and Chromium with this change.

platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore):

Define temporary typedef spanning int -> size_t change.

(WebCore::getValidationResultValue):
(WebCore::getSymbolInfo):

Use temporary typedef.

6:38 PM Changeset in webkit [142566] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r181817. Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-11

DEPS:

6:06 PM Changeset in webkit [142565] by haraken@chromium.org

5 edits in trunk/Source/WebCore

[V8] ScheduledAction::m_context can be empty, so we shouldn't
retrieve an Isolate by using m_context->GetIsolate()
https://bugs.webkit.org/show_bug.cgi?id=109523

Reviewed by Adam Barth.

Chromium bug: https://code.google.com/p/chromium/issues/detail?id=175307#makechanges

Currently ScheduledAction is retrieving an Isolate by using m_context->GetIsolate().
This can crash because ScheduledAction::m_context can be empty. Specifically,
ScheduledAction::m_context is set to ScriptController::currentWorldContext(),
which can return an empty handle when a frame does not exist. In addition,
'if(context.IsEmpty())' in ScheduledAction.cpp implies that it can be empty.

Alternately, we should pass an Isolate explicitly when a ScheduledAction is instantiated.

No tests. The Chromium crash report doesn't provide enough information
to reproduce the bug.

bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::ScheduledAction):
(WebCore):
(WebCore::ScheduledAction::~ScheduledAction):

bindings/v8/ScheduledAction.h:

(ScheduledAction):

bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::WindowSetTimeoutImpl):

bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::SetTimeoutOrInterval):

5:58 PM Changeset in webkit [142564] by dgrogan@chromium.org

3 edits in trunk/Source/WebKit/chromium

IndexedDB: Add UnknownError to WebIDBDatabaseException
https://bugs.webkit.org/show_bug.cgi?id=109519

Reviewed by Adam Barth.

public/WebIDBDatabaseException.h:
src/AssertMatchingEnums.cpp:

5:52 PM Changeset in webkit [142563] by commit-queue@webkit.org

4 edits in trunk/Source

Build fix: r142549 broke EFL build
https://bugs.webkit.org/show_bug.cgi?id=109527

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-02-11
Reviewed by Kentaro Hara.

Source/WebCore:

No new tests, no change on behavior.

CMakeLists.txt:

Source/WebKit:

Build fix.

CMakeLists.txt:

5:42 PM Changeset in webkit [142562] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL] Build fix
https://bugs.webkit.org/show_bug.cgi?id=109518

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-02-11
Reviewed by Laszlo Gombos.

Fix EFL build by including PluginProcessConnectionManager.messages.in in
CMakeLists.txt

CMakeLists.txt:

5:35 PM Changeset in webkit [142561] by Simon Fraser

2 edits in trunk/Source/WebCore

REGRESSION (r142520?): Space no longer scrolls the page
https://bugs.webkit.org/show_bug.cgi?id=109526

Reviewed by Tim Horton.

ScrollingTree::updateTreeFromStateNode() used to bail early when it had
no children (no fixed or sticky elements), but that left updateAfterChildren()
uncalled. Fix by always calling updateAfterChildren(), which updates the scroll
position.

page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateTreeFromStateNode):

5:31 PM Changeset in webkit [142560] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Remove extra early-return in FrameView::setScrollPosition

Rubber-stamped by Simon Fraser.

page/FrameView.cpp:

(WebCore::FrameView::setScrollPosition):

5:31 PM Changeset in webkit [142559] by rniwa@webkit.org

6 edits
3 moves
4 deletes in trunk/LayoutTests

Move deletionUI tests into platform/mac
https://bugs.webkit.org/show_bug.cgi?id=109517

Reviewed by Benjamin Poulain.

Moved deletionUI tests into platform/mac since Mac is the only port that ships this feature.

editing/deleting/5408255-expected.txt: Removed.
editing/deleting/5408255.html: Removed.
editing/deleting/deletionUI-single-instance.html: Removed.
platform/chromium/editing/deleting/deletionUI-single-instance-expected.png: Removed.
platform/chromium/editing/deleting/deletionUI-single-instance-expected.txt: Removed.
platform/efl/TestExpectations:
platform/mac/editing/deleting/deletionUI-click-on-delete-button-expected.txt: Copied from LayoutTests/editing/deleting/5408255-expected.txt.
platform/mac/editing/deleting/deletionUI-click-on-delete-button.html: Copied from LayoutTests/editing/deleting/5408255.html.
platform/mac/editing/deleting/deletionUI-single-instance.html: Copied from LayoutTests/editing/deleting/deletionUI-single-instance.html.
platform/qt-mac/TestExpectations:
platform/qt/editing/deleting/deletionUI-single-instance-expected.png: Removed.
platform/qt/editing/deleting/deletionUI-single-instance-expected.txt: Removed.
platform/win/TestExpectations:
platform/wincairo/TestExpectations:
platform/wk2/TestExpectations:

5:29 PM Changeset in webkit [142558] by arko@motorola.com

2 edits in trunk/Source/WebCore

[Microdata] Fix crash after r141034 in chromuim port
https://bugs.webkit.org/show_bug.cgi?id=109514

Reviewed by Ryosuke Niwa.

Added V8SkipVTableValidation extended attribute to skip
VTable validation check for DOMSettableTokenList interface.

This patch fixes below test failures:
Tests: fast/dom/MicroData/domsettabletokenlist-attributes-add-token.html

fast/dom/MicroData/domsettabletokenlist-attributes-out-of-range-index.html
fast/dom/MicroData/element-with-empty-itemprop.html
fast/dom/MicroData/itemprop-add-remove-tokens.html
fast/dom/MicroData/itemprop-for-an-element-must-be-correct.html
fast/dom/MicroData/itemprop-must-be-read-only.html
fast/dom/MicroData/itemprop-reflected-by-itemProp-property.html
fast/dom/MicroData/itemref-add-remove-tokens.html
fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property.html
fast/dom/MicroData/itemref-for-an-element-must-be-correct.html
fast/dom/MicroData/itemref-must-be-read-only.html
fast/dom/MicroData/itemtype-add-remove-tokens.html
fast/dom/MicroData/itemtype-attribute-test.html
fast/dom/MicroData/microdata-domtokenlist-attribute-add-remove-tokens.html
fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name.html
fast/dom/MicroData/propertynodelist-add-remove-itemprop-tokens.html
fast/dom/MicroData/propertynodelist-add-remove-itemref-tokens.html

html/DOMSettableTokenList.idl:

5:20 PM Changeset in webkit [142557] by oliver@apple.com

4 edits in trunk/Source/JavaScriptCore

Make JSC API more NULL tolerant
https://bugs.webkit.org/show_bug.cgi?id=109515

Reviewed by Mark Hahnenberg.

We do so much marshalling for the C API these days anyway that a single null
check isn't a performance issue. Yet the existing "null is unsafe" behaviour
leads to crashes in embedding applications whenever there's an untested code
path, so it seems having defined behaviour is superior.

API/APICast.h:

(toJS):
(toJSForGC):

API/JSObjectRef.cpp:

(JSObjectIsFunction):
(JSObjectCallAsFunction):
(JSObjectIsConstructor):
(JSObjectCallAsConstructor):

API/tests/testapi.c:

(main):

5:09 PM Changeset in webkit [142556] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Fix build.

WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::didReceiveMessageOnConnectionWorkQueue):

WebProcess/WebProcess.cpp:

5:07 PM Changeset in webkit [142555] by abarth@webkit.org

8 edits
2 adds in trunk

Load event fires too early with threaded HTML parser (take 2)
https://bugs.webkit.org/show_bug.cgi?id=109485

Reviewed by Eric Seidel.

Source/WebCore:

This patch restores the code that was removed in
http://trac.webkit.org/changeset/142492 and adds code to
DocumentLoader.cpp to avoid the regression.

dom/Document.cpp:

(WebCore::Document::hasActiveParser):
(WebCore::Document::decrementActiveParserCount):

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::isLoadingInAPISense):

LayoutTests:

This patch also fixes a bug whereby removing an iframe during the load
event would trigger DumpRenderTree to dump the test in the middle of
the load event. We now wait until the load event is over.

compositing/iframes/remove-iframe-crash-expected.txt:
fast/frames/iframe-access-screen-of-deleted-expected.txt:
fast/frames/remove-frame-during-load-event-expected.txt: Added.
fast/frames/remove-frame-during-load-event.html: Added.
http/tests/misc/xslt-bad-import-expected.txt:

5:05 PM Changeset in webkit [142554] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, adding a FIXME to remind ourselves of a bug.
https://bugs.webkit.org/show_bug.cgi?id=109487

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):

4:55 PM Changeset in webkit [142553] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

[GTK] Build fix.
https://bugs.webkit.org/show_bug.cgi?id=109516

Patch by Seulgi Kim <seulgikim@company100.net> on 2013-02-11
Reviewed by Csaba Osztrogonác.

PluginProcessConnectionManagerMessages are omitted from messages list.

GNUmakefile.list.am:

4:53 PM Changeset in webkit [142552] by eric@webkit.org

7 edits in trunk/Source/WebCore

Fold HTMLTokenizerState back into HTMLTokenizer now that MarkupTokenizerBase is RFG
https://bugs.webkit.org/show_bug.cgi?id=109502

Reviewed by Tony Gentilcore.

Just a search replace of HTMLTokenizerState with HTMLTokenizer and moving the enum.
This restores us to the peacefull world pre-NEW_XML.

html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::forcePlaintextForTextDocument):
(WebCore::BackgroundHTMLParser::simulateTreeBuilder):

html/parser/HTMLDocumentParser.cpp:

(WebCore::tokenizerStateForContextElement):
(WebCore::HTMLDocumentParser::forcePlaintextForTextDocument):
(WebCore::HTMLDocumentParser::pumpTokenizer):

html/parser/HTMLTokenizer.cpp:

(WebCore::isEndTagBufferingState):
(WebCore):
(WebCore::HTMLTokenizer::reset):
(WebCore::HTMLTokenizer::flushEmitAndResumeIn):
(WebCore::HTMLTokenizer::nextToken):
(WebCore::HTMLTokenizer::updateStateFor):

html/parser/HTMLTokenizer.h:

(HTMLTokenizer):
(WebCore::HTMLTokenizer::create):
(WebCore::HTMLTokenizer::shouldSkipNullCharacters):
(WebCore::HTMLTokenizer::emitEndOfFile):

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):

html/parser/TextViewSourceParser.cpp:

(WebCore::TextViewSourceParser::TextViewSourceParser):

4:49 PM Changeset in webkit [142551] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r181787. Requested by
thakis_ via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-11

DEPS:

4:46 PM Changeset in webkit [142550] by haraken@chromium.org

2 edits in trunk/Source/WebCore

Build fix after r142528
https://bugs.webkit.org/show_bug.cgi?id=109520

Reviewed by Eric Seidel.

r142528 changed GIFImageReader from a struct to a class.
We also need to fix a forward declaration.

No tests.

platform/image-decoders/gif/GIFImageDecoder.h:

4:39 PM Changeset in webkit [142549] by thakis@chromium.org

40 edits
52 deletes in trunk

Remove web intents code
https://bugs.webkit.org/show_bug.cgi?id=109501

Reviewed by Eric Seidel.

See thread "Removing ENABLE(WEB_INTENTS) code" on webkit-dev.

Source/WebCore:

DerivedSources.make:
Modules/intents/DOMWindowIntents.cpp: Removed.
Modules/intents/DOMWindowIntents.h: Removed.
Modules/intents/DOMWindowIntents.idl: Removed.
Modules/intents/DeliveredIntent.cpp: Removed.
Modules/intents/DeliveredIntent.h: Removed.
Modules/intents/DeliveredIntent.idl: Removed.
Modules/intents/Intent.cpp: Removed.
Modules/intents/Intent.h: Removed.
Modules/intents/Intent.idl: Removed.
Modules/intents/IntentRequest.cpp: Removed.
Modules/intents/IntentRequest.h: Removed.
Modules/intents/IntentResultCallback.h: Removed.
Modules/intents/IntentResultCallback.idl: Removed.
Modules/intents/NavigatorIntents.cpp: Removed.
Modules/intents/NavigatorIntents.h: Removed.
Modules/intents/NavigatorIntents.idl: Removed.
WebCore.gyp/WebCore.gyp:
WebCore.gypi:
bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):

bindings/v8/custom/V8IntentCustom.cpp: Removed.
html/HTMLElementsAllInOne.cpp:
html/HTMLIntentElement.cpp: Removed.
html/HTMLIntentElement.h: Removed.
html/HTMLIntentElement.idl: Removed.
loader/EmptyClients.cpp:
loader/EmptyClients.h:

(EmptyFrameLoaderClient):

loader/FrameLoaderClient.h:

(WebCore):

page/DOMWindow.idl:

Source/WebKit/chromium:

WebKit.gyp:
features.gypi:
public/WebDeliveredIntentClient.h: Removed.
public/WebFrame.h:

(WebKit):
(WebFrame):

public/WebFrameClient.h:

(WebKit):

public/WebIntent.h: Removed.
public/WebIntentRequest.h: Removed.
public/WebIntentServiceInfo.h: Removed.
public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

src/DeliveredIntentClientImpl.cpp: Removed.
src/DeliveredIntentClientImpl.h: Removed.
src/FrameLoaderClientImpl.cpp:
src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

src/WebFrameImpl.cpp:
src/WebFrameImpl.h:

(WebKit):
(WebFrameImpl):

src/WebIntent.cpp: Removed.
src/WebIntentRequest.cpp: Removed.
src/WebIntentServiceInfo.cpp: Removed.
src/WebRuntimeFeatures.cpp:

Tools:

DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

DumpRenderTree/TestRunner.h:

(TestRunner):

DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebKit):

DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebKit):
(WebTestRunner::WebTestProxy::didEndEditing):

DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):

DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
DumpRenderTree/chromium/WebViewHost.cpp:
DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

DumpRenderTree/efl/TestRunnerEfl.cpp:
DumpRenderTree/gtk/TestRunnerGtk.cpp:
DumpRenderTree/mac/TestRunnerMac.mm:
DumpRenderTree/win/TestRunnerWin.cpp:
DumpRenderTree/wx/TestRunnerWx.cpp:
Scripts/webkitperl/FeatureList.pm:

LayoutTests:

webintents/intent-tag-expected.txt: Removed.
webintents/intent-tag.html: Removed.
webintents/resources/pass.html: Removed.
webintents/resources/web-intents-reload-orig.html: Removed.
webintents/resources/web-intents-testing.js: Removed.
webintents/web-intents-api-expected.txt: Removed.
webintents/web-intents-api.html: Removed.
webintents/web-intents-delivery-expected.txt: Removed.
webintents/web-intents-delivery-reuse-expected.txt: Removed.
webintents/web-intents-delivery-reuse.html: Removed.
webintents/web-intents-delivery.html: Removed.
webintents/web-intents-failure-expected.txt: Removed.
webintents/web-intents-failure.html: Removed.
webintents/web-intents-invoke-expected.txt: Removed.
webintents/web-intents-invoke-port-expected.txt: Removed.
webintents/web-intents-invoke-port.html: Removed.
webintents/web-intents-invoke.html: Removed.
webintents/web-intents-obj-constructor-expected.txt: Removed.
webintents/web-intents-obj-constructor.html: Removed.
webintents/web-intents-reload-expected.txt: Removed.
webintents/web-intents-reload.html: Removed.
webintents/web-intents-reply-expected.txt: Removed.
webintents/web-intents-reply.html: Removed.

4:36 PM Changeset in webkit [142548] by schenney@chromium.org

1 edit
2 adds in trunk/LayoutTests

SVG DOM manipulation crash
https://bugs.webkit.org/show_bug.cgi?id=108709

Reviewed by Eric Seidel.

Adding a test for the case where an SVG <use> tree is rebuild due to
one event listener and a subsequent listener tries to access it. This
does not crash in WebKit but has caused problems in browser code where
the listener tries to access and use toNode on the target of the
event. The test prevents regressions and gives automated security
tests something to work on.

svg/custom/use-listener-append-crash-expected.txt: Added.
svg/custom/use-listener-append-crash.html: Added.

4:33 PM Changeset in webkit [142547] by eric@webkit.org

2 edits in trunk/Source/WebCore

Fix Mac build after http://trac.webkit.org/changeset/142535.

Unreviewed build fix.

html/parser/HTMLTokenizer.h:

(WebCore::HTMLTokenizer::emitAndReconsumeIn):

4:32 PM Changeset in webkit [142546] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Make WebCore Derived Sources work with SDK identifiers too
https://bugs.webkit.org/show_bug.cgi?id=109324

Patch by David Farler <dfarler@apple.com> on 2013-02-11
Reviewed by Sam Weinig.

WebCore.xcodeproj/project.pbxproj: Pass SDKROOT to make for DerivedSources.make

4:31 PM Changeset in webkit [142545] by zmo@google.com

2 edits in trunk/Source/WebCore

WEBGL_compressed_texture_s3tc extension can be enabled even when not supported
https://bugs.webkit.org/show_bug.cgi?id=109508

Reviewed by Kenneth Russell.

html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::getExtension): Check whether the extension support is there before returning the extension pointer.

4:29 PM Changeset in webkit [142544] by fpizlo@apple.com

15 edits
6 adds in trunk

Strange bug in DFG OSR in JSC
https://bugs.webkit.org/show_bug.cgi?id=109491

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Int32ToDouble was being injected after a side-effecting operation and before a SetLocal. Anytime we
inject something just before a SetLocal we should be aware that the previous operation may have been
a side-effect associated with the current code origin. Hence, we should use a forward exit.
Int32ToDouble does not do forward exits by default.

This patch adds a forward-exiting form of Int32ToDouble, for use in SetLocal Int32ToDouble injections.
Changed the CSE and other things to treat these nodes identically, but for the exit strategy to be
distinct (Int32ToDouble -> backward, ForwardInt32ToDouble -> forward). The use of the NodeType for
signaling exit direction is not "great" but it's what we use in other places already (like
ForwardCheckStructure).

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::int32ToDoubleCSE):
(CSEPhase):
(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGCommon.h:
dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixDoubleEdge):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):

dfg/DFGNode.h:

(JSC::DFG::Node::willHaveCodeGenOrOSR):

dfg/DFGNodeType.h:

(DFG):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):

dfg/DFGSpeculativeJIT.h:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::reconstruct):

LayoutTests:

Reviewed by Mark Hahnenberg.

Added one version of the test (dfg-int32-to-double-on-set-local-and-exit) that is based
exactly on Gabor's original test, and another that ought to fail even if I fix other bugs
in the future (see https://bugs.webkit.org/show_bug.cgi?id=109511).

fast/js/dfg-int32-to-double-on-set-local-and-exit-expected.txt: Added.
fast/js/dfg-int32-to-double-on-set-local-and-exit.html: Added.
fast/js/dfg-int32-to-double-on-set-local-and-sometimes-exit-expected.txt: Added.
fast/js/dfg-int32-to-double-on-set-local-and-sometimes-exit.html: Added.
fast/js/script-tests/dfg-int32-to-double-on-set-local-and-exit.js: Added.

(checkpoint):
(func1):
(func2):
(func3):
(test):

fast/js/script-tests/dfg-int32-to-double-on-set-local-and-sometimes-exit.js: Added.

(checkpoint):
(func1):
(func2):
(func3):
(test):

4:27 PM Changeset in webkit [142543] by Lucas Forschler

5 edits in branches/safari-534.59-branch/Source

Versioning.

4:21 PM Changeset in webkit [142542] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

[WK2] setMinimumLayoutWidth should bail if there's no WebProcess
https://bugs.webkit.org/show_bug.cgi?id=109512
<rdar://problem/13093627>

Reviewed by Anders Carlsson.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setMinimumLayoutWidth):

4:10 PM Changeset in webkit [142541] by Lucas Forschler

1 copy in branches/safari-534.59-branch

New Branch.

4:08 PM Changeset in webkit [142540] by andersca@apple.com

5 edits in trunk/Source/WebKit2

PluginProcessConnectionManager should be a QueueClient
https://bugs.webkit.org/show_bug.cgi?id=109496

Reviewed by Andreas Kling.

WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::didReceiveMessageOnConnectionWorkQueue):
(WebKit):
(WebKit::PluginProcessConnectionManager::didCloseOnConnectionWorkQueue):

WebProcess/Plugins/PluginProcessConnectionManager.h:

(PluginProcessConnectionManager):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeConnection):

WebProcess/WebProcess.h:

(WebProcess):

4:07 PM Changeset in webkit [142539] by eae@chromium.org

3 edits
2 adds in trunk

Change RenderFrameSet::paint to use m-rows/m_cols directly.
https://bugs.webkit.org/show_bug.cgi?id=108503

Source/WebCore:

Reviewed by Eric Seidel.

Test: fast/frames/invalid-frameset.html

rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::paint):

LayoutTests:

Reviewed by Eric Seidel.

Add test for how we render an invalid frameset.

fast/frames/invalid-frameset-expected.html: Added.
fast/frames/invalid-frameset.html: Added.

4:01 PM Changeset in webkit [142538] by yoli@rim.com

2 edits in trunk/Source/WebCore

XMLHttpRequestProgressEventThrottle::resume() always schedules timer even when unnecessary
https://bugs.webkit.org/show_bug.cgi?id=105348

Reviewed by Alexey Proskuryakov.

Let resume() clear the defer flag and return if there is deferred events to dispatch.

No new tests as this should not affect existing cross-platform behavior. It should be
OK as long as it doesn't break anything.

xml/XMLHttpRequestProgressEventThrottle.cpp:

(WebCore::XMLHttpRequestProgressEventThrottle::resume):

3:54 PM Changeset in webkit [142537] by ddkilzer@apple.com

2 edits in trunk/Source/WTF

[iOS] Upstream changes to Platform.h
<http://webkit.org/b/109459>

Reviewed by Benjamin Poulain.

wtf/Platform.h:
Changes for armv7s.
Add ENABLE() definitions for DASHBOARD_SUPPORT and WEBGL.
Re-sort USE() macros.
Remove ENABLE() macros for JIT, LLINT and YARR_JIT to enable on iOS Simulator. They are already defined below.
Turn off HAVE(HOSTED_CORE_ANIMATION) for iOS.
Turn on USE(COREMEDIA) for iOS 6.0 and later.

3:53 PM Changeset in webkit [142536] by oliver@apple.com

3 edits in trunk/Source/WTF

Harden FastMalloc (again)
https://bugs.webkit.org/show_bug.cgi?id=109334

Reviewed by Mark Hahnenberg.

Re-implement hardening of linked lists in TCMalloc.

In order to keep heap introspection working, we need to thread the
heap entropy manually as the introspection process can't use the
address of a global in determining the mask. Given we now have to
thread a value through anyway, I've stopped relying on ASLR for entropy
and am simply using arc4random() on darwin, and time + ASLR everywhere
else.

I've also made an explicit struct type for the FastMalloc singly linked
lists, as it seemed like the only way to reliably distinguish between
void*'s that were lists vs. void* that were not. This also made it
somewhat easier to reason about things across processes.

Verified that all the introspection tools work as expected.

wtf/FastMalloc.cpp:

(WTF::internalEntropyValue):
(WTF):
(HardenedSLL):
(WTF::HardenedSLL::create):
(WTF::HardenedSLL::null):
(WTF::HardenedSLL::setValue):
(WTF::HardenedSLL::value):
(WTF::HardenedSLL::operator!):
(WTF::HardenedSLL::operator UnspecifiedBoolType):
(TCEntry):
(WTF::SLL_Next):
(WTF::SLL_SetNext):
(WTF::SLL_Push):
(WTF::SLL_Pop):
(WTF::SLL_PopRange):
(WTF::SLL_PushRange):
(WTF::SLL_Size):
(PageHeapAllocator):
(WTF::PageHeapAllocator::Init):
(WTF::PageHeapAllocator::New):
(WTF::PageHeapAllocator::Delete):
(WTF::PageHeapAllocator::recordAdministrativeRegions):
(WTF::Span::next):
(WTF::Span::remoteNext):
(WTF::Span::prev):
(WTF::Span::setNext):
(WTF::Span::setPrev):
(Span):
(WTF::DLL_Init):
(WTF::DLL_Remove):
(WTF::DLL_IsEmpty):
(WTF::DLL_Length):
(WTF::DLL_Prepend):
(TCMalloc_Central_FreeList):
(WTF::TCMalloc_Central_FreeList::enumerateFreeObjects):
(WTF::TCMalloc_Central_FreeList::entropy):
(TCMalloc_PageHeap):
(WTF::TCMalloc_PageHeap::init):
(WTF::TCMalloc_PageHeap::scavenge):
(WTF::TCMalloc_PageHeap::New):
(WTF::TCMalloc_PageHeap::AllocLarge):
(WTF::TCMalloc_PageHeap::Carve):
(WTF::TCMalloc_PageHeap::Delete):
(WTF::TCMalloc_PageHeap::ReturnedBytes):
(WTF::TCMalloc_PageHeap::Check):
(WTF::TCMalloc_PageHeap::CheckList):
(WTF::TCMalloc_PageHeap::ReleaseFreeList):
(TCMalloc_ThreadCache_FreeList):
(WTF::TCMalloc_ThreadCache_FreeList::Init):
(WTF::TCMalloc_ThreadCache_FreeList::empty):
(WTF::TCMalloc_ThreadCache_FreeList::Push):
(WTF::TCMalloc_ThreadCache_FreeList::PushRange):
(WTF::TCMalloc_ThreadCache_FreeList::PopRange):
(WTF::TCMalloc_ThreadCache_FreeList::Pop):
(WTF::TCMalloc_ThreadCache_FreeList::enumerateFreeObjects):
(TCMalloc_ThreadCache):
(WTF::TCMalloc_Central_FreeList::Init):
(WTF::TCMalloc_Central_FreeList::ReleaseListToSpans):
(WTF::TCMalloc_Central_FreeList::ReleaseToSpans):
(WTF::TCMalloc_Central_FreeList::InsertRange):
(WTF::TCMalloc_Central_FreeList::RemoveRange):
(WTF::TCMalloc_Central_FreeList::FetchFromSpansSafe):
(WTF::TCMalloc_Central_FreeList::FetchFromSpans):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Init):
(WTF::TCMalloc_ThreadCache::Deallocate):
(WTF::TCMalloc_ThreadCache::FetchFromCentralCache):
(WTF::TCMalloc_ThreadCache::ReleaseToCentralCache):
(WTF::TCMalloc_ThreadCache::InitModule):
(WTF::TCMalloc_ThreadCache::NewHeap):
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

wtf/MallocZoneSupport.h:

(RemoteMemoryReader):

3:52 PM Changeset in webkit [142535] by eric@webkit.org

10 edits
1 delete in trunk/Source/WebCore

Fold MarkupTokenizerBase into HTMLTokenizer now that it is the only subclass
https://bugs.webkit.org/show_bug.cgi?id=109499

Reviewed by Adam Barth.

For great justice. And sanity.
Epic amount of template code deleted.

GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::HTMLTokenizer):

html/parser/HTMLTokenizer.h:

(HTMLTokenizer):
(Checkpoint):
(WebCore::HTMLTokenizer::state):
(WebCore::HTMLTokenizer::setState):
(WebCore::HTMLTokenizer::shouldSkipNullCharacters):
(WebCore::HTMLTokenizer::bufferCharacter):
(WebCore::HTMLTokenizer::emitAndResumeIn):
(WebCore::HTMLTokenizer::emitAndReconsumeIn):
(WebCore::HTMLTokenizer::emitEndOfFile):
(WebCore::HTMLTokenizer::haveBufferedCharacterToken):

xml/parser/MarkupTokenizerBase.h: Removed.

3:48 PM Changeset in webkit [142534] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Text Autosizing] Collect narrow descendants and process them separately. Refactoring for
a change to follow.
https://bugs.webkit.org/show_bug.cgi?id=109054

Preparational change to combine narrow descendants of the same autosizing cluster into
groups by the width difference between the descendant and the block containing all text of
the parent autosizing cluster. The groups will be autosized with the same multiplier.

For example, on sites with a sidebar, sometimes the paragraphs next to the sidebar will have
a large margin individually applied (via a CSS selector), causing them all to individually
appear narrower than their enclosing blockContainingAllText. Rather than making each of
these paragraphs into a separate cluster, we eventually want to be able to merge them back
together into one (or a few) descendant clusters.

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-11
Reviewed by Julien Chaffraix.

No behavioral changes thus no new tests or test changes.

rendering/TextAutosizer.cpp:

(TextAutosizingClusterInfo): Vector of narrow descendants.
(WebCore::TextAutosizer::processCluster): Process narrow descendants separately.
(WebCore::TextAutosizer::processContainer):

Remember narrow descendants of the parent cluster for later processing.

3:47 PM Changeset in webkit [142533] by enrica@apple.com

15 edits in trunk/Source

Source/WebCore: Add ENABLE_DELETION_UI to control the use of the deletion UI.
https://bugs.webkit.org/show_bug.cgi?id=109463.

Reviewed by Ryosuke Niwa.

This patch adds #if ENABLE(DELETION_UI) in every spot where
DeleteButtonController is used. This class is now only instantiated
if the feature is enabled. I've also done some cleanup in the
DeleteButtonController class, removing unused methods and making
private some methods only used internally to the class.
Both DeleteButtonController and DeleteButton classes are now excluded
from the compilation if the feature is not enabled.

No new tests, no change of functionality.

dom/ContainerNode.cpp:

(WebCore::ContainerNode::cloneChildNodes):

editing/CompositeEditCommand.cpp:

(WebCore::EditCommandComposition::unapply):
(WebCore::EditCommandComposition::reapply):
(WebCore::CompositeEditCommand::apply):

editing/DeleteButton.cpp:
editing/DeleteButtonController.cpp:
editing/DeleteButtonController.h: Some cleanup.

(WebCore::DeleteButtonController::enabled): Made private.

editing/EditCommand.cpp:

(WebCore::EditCommand::EditCommand):

editing/Editor.cpp:

(WebCore::Editor::notifyComponentsOnChangedSelection):
(WebCore::Editor::Editor):
(WebCore::Editor::rangeForPoint):
(WebCore::Editor::deviceScaleFactorChanged):

editing/Editor.h:
editing/htmlediting.cpp: avoidIntersectionWithNode is

used only if the feature is enabled.

editing/htmlediting.h:
editing/markup.cpp:

(WebCore::createMarkup):
(WebCore::createFragmentFromNodes):

rendering/RenderTable.cpp: Removed unnecessary include

fo DeleteButtonController.h

Source/WTF: Add ENABLE_DELETION_UI to control the use of the deletion UI.
https://bugs.webkit.org/show_bug.cgi?id=109463.

ENABLE_DELETION_UI is set to 1 by default for
all ports. It is explicitly enabled for MAC and disabled for iOS.

Reviewed by Ryosuke Niwa.

wtf/Platform.h:

3:42 PM Changeset in webkit [142532] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

Unreviewed WK2 buildfix after r142518.

DerivedSources.pri:

3:34 PM Changeset in webkit [142531] by rafaelw@chromium.org

5 edits in trunk

[HTMLTemplateElement] <template> inside of <head> may not create <body> if EOF is hit
https://bugs.webkit.org/show_bug.cgi?id=109338

Reviewed by Adam Barth.

Source/WebCore:

This patch adds the logic to clear the stack of open elements back to the first <template> when EOF
is hit. This allows a <body> to be generated if the initial <template> was opened inside of <head>.

Tests added to html5lib.

html/parser/HTMLTreeBuilder.cpp:

(WebCore):
(WebCore::HTMLTreeBuilder::popAllTemplates):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processEndOfFile):

html/parser/HTMLTreeBuilder.h:

(HTMLTreeBuilder):

LayoutTests:

html5lib/resources/template.dat:

3:34 PM Changeset in webkit [142530] by fpizlo@apple.com

8 edits in trunk/Source/JavaScriptCore

NonStringCell and Object are practically the same thing for the purpose of speculation
https://bugs.webkit.org/show_bug.cgi?id=109492

Reviewed by Mark Hahnenberg.

Removed isNonStringCellSpeculation, and made all callers use isObjectSpeculation.

Changed isNonStringCellOrOtherSpeculation to be isObjectOrOtherSpeculation.

I believe this is correct because even weird object types like JSNotAnObject end up
being "objects" from the standpoint of our typesystem. Anyway, the assumption that
"is cell but not a string" equates to "object" is an assumption that is already made
in other places in the system so there's little value in being paranoid about it.

bytecode/SpeculatedType.h:

(JSC::isObjectSpeculation):
(JSC::isObjectOrOtherSpeculation):

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

dfg/DFGNode.h:

(Node):
(JSC::DFG::Node::shouldSpeculateObjectOrOther):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):

dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

3:28 PM Changeset in webkit [142529] by akling@apple.com

2 edits in trunk/Source/WebCore

RenderText::isAllCollapsibleWhitespace() shouldn't upconvert string to 16-bit.
<http://webkit.org/b/109354>

Reviewed by Eric Seidel.

254 KB progression on Membuster3.

rendering/RenderText.cpp:

(WebCore::RenderText::isAllCollapsibleWhitespace):

3:21 PM Changeset in webkit [142528] by hclam@chromium.org

4 edits in trunk/Source/WebCore

Fix code style violations in GIFImageReader.{cc|h}
https://bugs.webkit.org/show_bug.cgi?id=109007

Reviewed by Stephen White.

This is just a style clean up for GIFImageReader.{cc|h}.

There's going to be a lot changes in these two files and style check
will add a lot of noise in later reviews. Fix style problems first.

There is no change in logic at all. Just style fixes.

No new tests.

platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::repetitionCount):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::initFrameBuffer):

platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::outputRow):
(GIFImageReader::doLZW):
(GIFImageReader::read):

platform/image-decoders/gif/GIFImageReader.h:

(GIFFrameContext):
(GIFFrameContext::GIFFrameContext):
(GIFFrameContext::~GIFFrameContext):
(GIFImageReader::GIFImageReader):
(GIFImageReader::~GIFImageReader):
(GIFImageReader):
(GIFImageReader::imagesCount):
(GIFImageReader::loopCount):
(GIFImageReader::globalColormap):
(GIFImageReader::globalColormapSize):
(GIFImageReader::frameContext):

3:17 PM Changeset in webkit [142527] by commit-queue@webkit.org

15 edits
2 adds in trunk

[CSS Exclusions] Handle shape-outside changing a float's overhang behavior
https://bugs.webkit.org/show_bug.cgi?id=106927

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-02-11
Reviewed by Julien Chaffraix.

Source/WebCore:

When the position on a shape outside causes a float to spill out into
another block than it's container, it was not being drawn correctly. It
became apparent that in order to fix this properly, the approach to
positioning shape outsides and floats needed to be changed. The new
approach also fixes some other outstanding issues, like hit detection.

When a float has a shape outside, inline and float layout happens
using the exclusion shape bounds instead of the float's box. The
effect of this is that the float itself no longer has any effect on
layout, both with respect to positioning of the float's siblings as
well as positioning the float's box. This means that when the float is
positioned, it is the shape's box that must obey the positioning rules
for floats. When the shape is given a position relative to the float's
box, the rules for float positioning determine where the shape sits
in the parent, causing the float's box to be offset by the position of
the shape. Since the float's box does not affect layout (due to the
shape), this is similar to relative positioning in that the offset is
a paint time occurrence.

So the new approach is to implement positioning of shape outside on
floats similar to how relative positioning is implemented, using a
RenderLayer.

This is also tested by the existing tests for shape outside on floats positioning.

Test: fast/exclusions/shape-outside-floats/shape-outside-floats-overhang.html

rendering/ExclusionShapeOutsideInfo.h:

(WebCore::ExclusionShapeOutsideInfo::shapeLogicalOffset): Utility method to create a LayoutSize for computing the layer offset.
(ExclusionShapeOutsideInfo):

rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState): Check for floats with shape outside as well as in flow positioning.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::flipFloatForWritingModeForChild): Remove old positioning implementation.
(WebCore::RenderBlock::paintFloats): Remove old positioning implementation.
(WebCore::RenderBlock::blockSelectionGaps): Check for floats with shape outside as well as in flow positioning.
(WebCore::RenderBlock::positionNewFloats): Remove old positioning implementation.
(WebCore::RenderBlock::addOverhangingFloats): Remove FIXME.
(WebCore::positionForPointRespectingEditingBoundaries): Check for floats with shape outside as well as in flow positioning.

rendering/RenderBlock.h:

(RenderBlock): Remove old positioning implementation.
(WebCore::RenderBlock::xPositionForFloatIncludingMargin): Remove old positioning implementation.
(WebCore::RenderBlock::yPositionForFloatIncludingMargin): Remove old positioning implementation.

rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer): Check for floats with shape outside as well as in flow positioning.
(WebCore::RenderBox::offsetFromContainer): Check for floats with shape outside as well as in flow positioning.
(WebCore::RenderBox::computeRectForRepaint): Check for floats with shape outside as well as in flow positioning.
(WebCore::RenderBox::layoutOverflowRectForPropagation): Check for floats with shape outside as well as in flow positioning.

rendering/RenderBox.h: Make floats with shape outside get a layer.
rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintOffset): Method to return in flow

positioning offset + offset from shape outside on floats.

rendering/RenderBoxModelObject.h:

(RenderBoxModelObject): Add paintOffset method.

rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint): Check for floats with shape outside as well as in flow positioning.
(WebCore::RenderInline::computeRectForRepaint): Check for floats with shape outside as well as in flow positioning.
(WebCore::RenderInline::mapLocalToContainer): Check for floats with shape outside as well as in flow positioning.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition): Check for floats with shape outside as well as in flow positioning.
(WebCore::RenderLayer::calculateClipRects): Check for floats with shape outside as well as in flow positioning.

rendering/RenderLayer.h:

(WebCore::RenderLayer::paintOffset): Rename offsetForInFlowPosition to reflect that it's not just for

in flow positioning, it also reflects shape outside position on floats.

(RenderLayer):

rendering/RenderObject.h:

(WebCore::RenderObject::hasPaintOffset): Determines if this object is in flow positioined or is a float with shape outside.

rendering/style/RenderStyle.h: Add hasPaintOffset method, analagous to method with same name on RenderObject.

LayoutTests:

This is also tested by the existing tests for shape outside on floats positioning.

fast/exclusions/shape-outside-floats/shape-outside-floats-overhang-expected.html: Added.
fast/exclusions/shape-outside-floats/shape-outside-floats-overhang.html: Added.

3:13 PM Changeset in webkit [142526] by timothy_horton@apple.com

7 edits
2 adds in trunk

FrameView::setScrollPosition should clamp scroll position before handing it to
ScrollingCoordinator instead of depending on ScrollView to do this
https://bugs.webkit.org/show_bug.cgi?id=109497
<rdar://problem/12631789>

Reviewed by Simon Fraser.

Clamp scroll position before handing it to ScrollingCoordinator. Also, like ScrollView does,
bail out if we've already scrolled to the clamped scroll position.

Test: platform/mac-wk2/tiled-drawing/clamp-out-of-bounds-scrolls.html

page/FrameView.cpp:

(WebCore::FrameView::setScrollPosition):

Adjust some test results which previously expected out-of-bounds scrolling to happen.

Add a test that ensures that out-of-bounds scrolling doesn't happen.

platform/mac-wk2/tiled-drawing/clamp-out-of-bounds-scrolls-expected.txt: Added.
platform/mac-wk2/tiled-drawing/clamp-out-of-bounds-scrolls.html: Added.
platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-expected.txt:
platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-in-view-expected.txt:
platform/mac-wk2/tiled-drawing/sticky/negative-scroll-offset-expected.txt:
platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:

3:11 PM Changeset in webkit [142525] by abarth@webkit.org

3 edits
2 adds in trunk

The threaded HTML parser should pass all the fast/parser tests
https://bugs.webkit.org/show_bug.cgi?id=109486

Reviewed by Tony Gentilcore.

Source/WebCore:

This patch fixes the last two test failures in fast/parser, which were
crashes caused by not having a tokenizer when document.close() was
called. (The tokenizer is created lazily by calls to document.write,
which might not happen before document.close).

fast/parser/document-close-iframe-load.html
fast/parser/document-close-nested-iframe-load.html

In addition, I've added a new test to make sure we flush the tokenizer
properly in these cases.

Test: fast/parser/document-close-iframe-load-partial-entity.html

html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::prepareToStopParsing):
(WebCore::HTMLDocumentParser::pumpTokenizer):

LayoutTests:

fast/parser/document-close-iframe-load-partial-entity-expected.txt: Added.
fast/parser/document-close-iframe-load-partial-entity.html: Added.

3:07 PM Changeset in webkit [142524] by Bruno de Oliveira Abinader

3 edits in trunk/Source/WebCore

[texmap] Implement frames-per-second debug counter
https://bugs.webkit.org/show_bug.cgi?id=107942

Reviewed by Noam Rosenthal.

Adds FPS counter via WEBKIT_SHOW_FPS=<interval> environment variable,
where <interval> is the period in seconds (i.e. =1.5) between FPS
updates on screen. It is measured by counting
CoordinatedGraphicsScene::paintTo* calls and is painted using
drawRepaintCounter() after TextureMapperLayer has finished painting its
contents.

Visual debugging feature, no need for new tests.

platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::CoordinatedGraphicsScene):
(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebCore::CoordinatedGraphicsScene::paintToGraphicsContext):
(WebCore::CoordinatedGraphicsScene::updateFPS):

platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

3:00 PM Changeset in webkit [142523] by jchaffraix@webkit.org

6 edits in trunk/LayoutTests

Unreviewed Chromium rebaselining after r142500.

platform/chromium-linux/fast/repaint/selection-after-remove-expected.png:
platform/chromium-mac-lion/fast/repaint/selection-after-remove-expected.png:
platform/chromium-mac-snowleopard/fast/repaint/selection-after-remove-expected.png:
platform/chromium-mac/fast/repaint/selection-after-remove-expected.png:
platform/chromium-win/fast/repaint/selection-after-remove-expected.png:

Slight painting regression that brings us back to pre-r132591 baselines.

3:00 PM Changeset in webkit [142522] by eric@webkit.org

11 edits
1 delete in trunk/Source/WebCore

Fold MarkupTokenBase into HTMLToken now that it has no other subclasses
https://bugs.webkit.org/show_bug.cgi?id=109483

Reviewed by Adam Barth.

This deletes an epic amount of template yuck, as well as removes
a vtable !?! from HTMLToken.

This paves the way for further cleanup of HTMLToken now that we
can see the whole object at once.
We'll also probably re-create an HTMLToken.cpp again, now that we're
free from the chains of template nonsense.

GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
html/parser/HTMLToken.h:

(WebCore::findAttributeInVector):
(WebCore):
(HTMLToken):
(Attribute):
(Range):
(WebCore::HTMLToken::HTMLToken):
(WebCore::HTMLToken::clear):
(WebCore::HTMLToken::isUninitialized):
(WebCore::HTMLToken::type):
(WebCore::HTMLToken::makeEndOfFile):
(WebCore::HTMLToken::startIndex):
(WebCore::HTMLToken::endIndex):
(WebCore::HTMLToken::setBaseOffset):
(WebCore::HTMLToken::end):
(WebCore::HTMLToken::data):
(WebCore::HTMLToken::isAll8BitData):
(WebCore::HTMLToken::name):
(WebCore::HTMLToken::appendToName):
(WebCore::HTMLToken::nameString):
(WebCore::HTMLToken::selfClosing):
(WebCore::HTMLToken::setSelfClosing):
(WebCore::HTMLToken::beginStartTag):
(WebCore::HTMLToken::beginEndTag):
(WebCore::HTMLToken::addNewAttribute):
(WebCore::HTMLToken::beginAttributeName):
(WebCore::HTMLToken::endAttributeName):
(WebCore::HTMLToken::beginAttributeValue):
(WebCore::HTMLToken::endAttributeValue):
(WebCore::HTMLToken::appendToAttributeName):
(WebCore::HTMLToken::appendToAttributeValue):
(WebCore::HTMLToken::attributes):
(WebCore::HTMLToken::eraseValueOfAttribute):
(WebCore::HTMLToken::ensureIsCharacterToken):
(WebCore::HTMLToken::characters):
(WebCore::HTMLToken::appendToCharacter):
(WebCore::HTMLToken::comment):
(WebCore::HTMLToken::beginComment):
(WebCore::HTMLToken::appendToComment):
(WebCore::HTMLToken::eraseCharacters):

html/parser/HTMLTokenTypes.h:
html/parser/XSSAuditor.h:
xml/parser/MarkupTokenBase.h: Removed.

2:58 PM Changeset in webkit [142521] by barraclough@apple.com

7 edits in trunk/Source

PluginProcess should quit immediately if idle in response to low-memory notifications
https://bugs.webkit.org/show_bug.cgi?id=109103
<rdar://problem/12679827>

Reviewed by Brady Eidson.

Source/WebCore:

This patch allows a process to set a custom callback for low memory warnings
(defaulting to the current behaviour, as implemented in releaseMemory).

platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::MemoryPressureHandler):

Initialize m_lowMemoryHandler to releaseMemory.

(WebCore::MemoryPressureHandler::install):
(WebCore::MemoryPressureHandler::uninstall):
(WebCore::MemoryPressureHandler::holdOff):

Cleaned up spacing.

(WebCore::MemoryPressureHandler::releaseMemory):

Added null implementation for non-Mac builds.

platform/MemoryPressureHandler.h:

(WebCore::MemoryPressureHandler::setLowMemoryHandler):

Added method to set m_lowMemoryHandler.

platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::respondToMemoryPressure):

Changed to call releaseMemory via m_lowMemoryHandler.

Source/WebKit2:

PluginProcess now installs a MemoryPressureHandler for the process, providing
a custom callback which will call terminate if appropriate (if the plugin is not
currently in use).

PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::lowMemoryHandler):

Custom callback to terminate if appropriate.

(WebKit::PluginProcess::initializeProcess):

Install the MemoryPressureHandler.

(WebKit::PluginProcess::shouldTerminate):

This method now also needs to be callable in situations where it might return false.

PluginProcess/PluginProcess.h:

(PluginProcess):

Added declaration for lowMemoryHandler.

2:57 PM Changeset in webkit [142520] by Simon Fraser

13 edits in trunk/Source/WebCore

REGRESSION (r133807): Sticky-position review bar on bugzilla review page is jumpy
https://bugs.webkit.org/show_bug.cgi?id=104276
<rdar://problem/12827187>

Reviewed by Tim Horton.

When committing new scrolling tree state, if the root node has a scroll
position update, we would handle that before updating the state of child
nodes (with possibly new viewport constraints). That would cause incorrect
child layer updates.

Fix by adding a second 'update' phase that happens after child nodes,
and moving the scroll position update into that.

Scrolling tests only dump the state tree, so cannot test the bug.

page/FrameView.cpp:

(WebCore::FrameView::setScrollPosition): If the scroll position didn't
actually change, don't request a scroll position update from the ScrollingCoordinator.

page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateTreeFromStateNode): Keep track of the scrolling node so
that we can call updateAfterChildren() on it.

page/scrolling/ScrollingTreeNode.h:

(ScrollingTreeNode):
(WebCore::ScrollingTreeNode::updateAfterChildren):

page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):

page/scrolling/ScrollingTreeScrollingNode.h:

(ScrollingTreeScrollingNode):

page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::updateViewportConstrainedNode):
In the current bug the scrolling tree was scheduled for commit because of a
scroll position request, but if only the viewport constraints change, we also need
to commit the tree.

page/scrolling/mac/ScrollingTreeFixedNode.h:

(ScrollingTreeFixedNode):

page/scrolling/mac/ScrollingTreeFixedNode.mm:

(WebCore::ScrollingTreeFixedNode::updateBeforeChildren):

page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:

(ScrollingTreeScrollingNodeMac):

page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::updateBeforeChildren):
(WebCore::ScrollingTreeScrollingNodeMac::updateAfterChildren): Move code here
that updates things that have to happen after children.

page/scrolling/mac/ScrollingTreeStickyNode.h:

(ScrollingTreeStickyNode):

page/scrolling/mac/ScrollingTreeStickyNode.mm:

(WebCore::ScrollingTreeStickyNode::updateBeforeChildren):

2:47 PM Changeset in webkit [142519] by benjamin@webkit.org

2 edits in trunk/Source/WebKit/win

Build fix for Windows after r142509

WebKit.vcproj/WebKitExports.def.in:

2:40 PM Changeset in webkit [142518] by andersca@apple.com

9 edits
1 add in trunk/Source/WebKit2

Move the PluginProcessCrashed message to PluginProcessConnectionManager
https://bugs.webkit.org/show_bug.cgi?id=109493

Reviewed by Andreas Kling.

This is in preparation for making PluginProcessConnectionManager a connection queue client.

DerivedSources.make:
UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::didClose):

WebKit2.xcodeproj/project.pbxproj:
WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::pluginProcessCrashed):

WebProcess/Plugins/PluginProcessConnectionManager.h:

(PluginProcessConnectionManager):

WebProcess/Plugins/PluginProcessConnectionManager.messages.in: Added.
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessageOnConnectionWorkQueue):
(WebKit::WebProcess::webResourceLoadScheduler):

WebProcess/WebProcess.h:

(WebProcess):

WebProcess/WebProcess.messages.in:

2:33 PM Changeset in webkit [142517] by roger_fong@apple.com

2 edits in trunk/Source/WebCore

Unreviewed. Build fix for Win7 Release.
Because of InspectorAllInOne.cpp static globals must be named differently in files included by InspectorAllInOne.
This was the case for UserInitiatedProfileName. Also removed the repeated HeapProfileType definition in
InspectorHeapProfilerAgent.cpp since it wasn't being used anyways.

inspector/InspectorHeapProfilerAgent.cpp:

(WebCore):
(WebCore::InspectorHeapProfilerAgent::takeHeapSnapshot):

2:24 PM Changeset in webkit [142516] by fmalita@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r181770.

DEPS:

2:23 PM Changeset in webkit [142515] by fpizlo@apple.com

9 edits in trunk/Source/JavaScriptCore

DFG CompareEq(a, null) and CompareStrictEq(a, const) are unsound with respect to constant folding
https://bugs.webkit.org/show_bug.cgi?id=109387

Reviewed by Oliver Hunt and Mark Hahnenberg.

Lock in the decision to use a non-speculative constant comparison as early as possible
and don't let the CFA change it by folding constants. This might be a performance
penalty on some really weird code (FWIW, I haven't seen this on benchmarks), but on
the other hand it completely side-steps the unsoundness that the bug speaks of.

Rolling back in after adding 32-bit path.

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::isConstantForCompareStrictEq):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGNodeType.h:

(DFG):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileStrictEq):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

2:22 PM Changeset in webkit [142514] by tonyg@chromium.org

2 edits in trunk/Source/WebCore

SegmentedString's copy ctor should copy all fields
https://bugs.webkit.org/show_bug.cgi?id=109477

Reviewed by Adam Barth.

This fixes http/tests/inspector-enabled/document-write.html (and likely others) for the threaded HTML parser.

No new tests because covered by existing tests.

platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::SegmentedString):

2:13 PM Changeset in webkit [142513] by jsbell@chromium.org

8 edits
3 adds in trunk

IndexedDB: database connections don't close after versionchange transaction aborts
https://bugs.webkit.org/show_bug.cgi?id=102298

Reviewed by Tony Chang.

Source/WebCore:

Per spec, close the database if the "versionchange" transaction aborts.

Tests: storage/indexeddb/aborted-versionchange-closes.html

storage/indexeddb/lazy-index-population.html
storage/objectstore-basics.html

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::onAbort): Tell the IDBDatabase (connection) to close if
this was a "versionchange" transaction.

LayoutTests:

Added dedicated test, updated tests dependent on buggy behavior.

storage/indexeddb/aborted-versionchange-closes-expected.txt: Added.
storage/indexeddb/aborted-versionchange-closes.html: Added.
storage/indexeddb/lazy-index-population-expected.txt:
storage/indexeddb/lazy-index-population.html: Remove manual closing.
storage/indexeddb/objectstore-basics-expected.txt:
storage/indexeddb/objectstore-basics-workers-expected.txt:
storage/indexeddb/resources/aborted-versionchange-closes.js: Added.
storage/indexeddb/resources/objectstore-basics.js: Removed dependency on bug.

1:59 PM Changeset in webkit [142512] by Christophe Dumez

7 edits in trunk

[EFL] fast/forms/number/number-l10n-input.html is failing
https://bugs.webkit.org/show_bug.cgi?id=109440

Reviewed by Laszlo Gombos.

Source/WebCore:

Use LocaleICU instead of LocaleNone on EFL port. The EFL
port already depends on ICU library and we get additional
functionality this way.

No new tests, already covered by existing tests.

CMakeLists.txt:
PlatformBlackBerry.cmake:
PlatformEfl.cmake:
PlatformWinCE.cmake:

LayoutTests:

Unskip fast/forms/number/number-l10n-input.html on EFL port
now that it passes.

platform/efl/TestExpectations:

1:48 PM Changeset in webkit [142511] by bfulgham@webkit.org

2 edits in trunk/Source/WebKit

Rename Visual Studio solution folders to avoid conflicts with project names
https://bugs.webkit.org/show_bug.cgi?id=109484

Reviewed by Tim Horton.

WebKit.vcxproj/WebKit.sln: Rename several solution folders (e.g.,

WTF, WebCore, WebKit, JavaScriptCore) so that they do not conflict
with projects using the same name.

1:48 PM Changeset in webkit [142510] by abarth@webkit.org

2 edits in trunk/LayoutTests

Remove failure expectation now that this test is passing.

platform/chromium/TestExpectations:

1:41 PM Changeset in webkit [142509] by benjamin@webkit.org

51 edits in trunk

Kill TestRunner::setMinimumTimerInterval; implement the feature with InternalSettings
https://bugs.webkit.org/show_bug.cgi?id=109349

Reviewed by Sam Weinig.

Source/autotools/symbols.filter:

Source/WebCore:

Expose setMinimumTimerInterval() and implement the backup/restore to keep
a consistent state between tests.

testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setMinimumTimerInterval):
(WebCore):

testing/InternalSettings.h:

(Backup):
(InternalSettings):

testing/InternalSettings.idl:

Source/WebKit/gtk:

WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

WebView/WebView.mm:
WebView/WebViewPrivate.h:

Source/WebKit/qt:

WebCoreSupport/DumpRenderTreeSupportQt.cpp:
WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit2:

WebProcess/InjectedBundle/API/c/WKBundle.cpp:
WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:
WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

Tools:

Get rid of TestRunner's setMinimumTimerInterval and all the related functions.

This also fixes an oddity:
TestRunners were initialized with a minimum timer interval of 10 milliseconds instead
of using the default value. All with the same copy of an outdated comment.

DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

DumpRenderTree/TestRunner.h:

(TestRunner):

DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):

DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):
(WebTestRunner::WebPreferences::applyTo):

DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::reset):

DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

DumpRenderTree/efl/TestRunnerEfl.cpp:
DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

DumpRenderTree/gtk/TestRunnerGtk.cpp:
DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

DumpRenderTree/mac/TestRunnerMac.mm:
DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

DumpRenderTree/qt/TestRunnerQt.cpp:
DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting):

DumpRenderTree/win/TestRunnerWin.cpp:
DumpRenderTree/wx/TestRunnerWx.cpp:
WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

WebKitTestRunner/InjectedBundle/TestRunner.cpp:
WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Update the tests to use InternalSettings.

fast/dom/timer-increase-min-interval-and-reset-part-1.html:
fast/dom/timer-increase-min-interval-repeating.html:
fast/dom/timer-increase-min-interval.html:
fast/dom/timer-increase-then-decrease-min-interval-repeating.html:
fast/dom/timer-increase-then-decrease-min-interval.html:

1:39 PM Changeset in webkit [142508] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG TypeOf implementation should have its backend code aligned to what the CFA does
https://bugs.webkit.org/show_bug.cgi?id=109385

Reviewed by Sam Weinig.

The problem was that if we ended up trying to constant fold, but didn't succeed
because of prediction mismatches, then we would also fail to do filtration.

Rearranged the control flow in the CFA to fix that.

As far as I know, this is asymptomatic - it's sort of OK for the CFA to prove less
things, which is what the bug was.

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

1:34 PM Changeset in webkit [142507] by dino@apple.com

24 edits in trunk

Source/WebCore: Source/WebCore: Snapshotted plug-in should use shadow root
https://bugs.webkit.org/show_bug.cgi?id=108284

Reviewed by Simon Fraser.

Take three - relanding after rollout in r142400 that was caused by a global
selector interfering with CSS Instrumentation in the Inspector.

A snapshotted plugin needs to indicate to the user that it can be clicked
to be restarted. Previously this was done with an image that had embedded
text. Instead, we now use an internal shadow root to embed some markup that
will display instructions that can be localised.

The UA stylesheet for plug-ins provides a default styling for the label, which
can be overridden by ports.

In the process, RenderSnapshottedPlugIn no longer inherits from RenderEmbeddedObject,
since it is only responsible for drawing a paused plug-in. The snapshot creation
can work with the default renderer, but a shadow root requires something like
RenderBlock in order to draw its children. We swap from one renderer to another when
necessary either by creating the shadow root or by explicitly detaching and attaching
the plugin element.

Unfortunately this is difficult to test, because the snapshotting requires
time to execute, and also a PluginView to be instantiated.

css/plugIns.css:

(object::-webkit-snapshotted-plugin-content): New rules for a default label style.

platform/LocalizedStrings.cpp: Make sure all ports have plugin strings, now it is called.
platform/LocalizedStrings.h:
platform/blackberry/LocalizedStringsBlackBerry.cpp:
platform/chromium/LocalizedStringsChromium.cpp:
platform/efl/LocalizedStringsEfl.cpp:
platform/gtk/LocalizedStringsGtk.cpp:
platform/qt/LocalizedStringsQt.cpp:

html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler): Take into account the fact
that RenderSnapshottedPlugIn no longer is an embedded object.

html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): New default values in constructor.
(WebCore::HTMLPlugInElement::defaultEventHandler): Make sure to call base class.
(WebCore::HTMLPlugInElement::willRecalcStyle): No need to reattach if we're a snapshot.
(WebCore::HTMLPlugInImageElement::createRenderer): If we're showing a snapshot, create such

a renderer, otherwise use the typical plug-in path.

(WebCore::HTMLPlugInImageElement::updateSnapshot): Keep a record of the snapshot, since we'll

need to give it to the renderer.

(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Build a subtree that will display a label.

html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement): New member variable to record the snapshot image and whether the label

should show immediately.

(WebCore::HTMLPlugInImageElement::swapRendererTimerFired): The callback function triggered when we need

to swap to the Shadow Root.

(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): The user has tapped on the snapshot so the plugin

in being recreated. Make sure we reattach so that a plugin renderer will be created.

(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Make sure we set the right

displayState for snapshots.

html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement): The new methods listed above.
(WebCore::HTMLPlugInImageElement::setShouldShowSnapshotLabelAutomatically): Indicates whether or not

a snapshot should be immediately labeled.

page/ChromeClient.h: No need for plugInStartLabelImage any more.

rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): New inheritance.
(WebCore::RenderSnapshottedPlugIn::paint): If we're in the background paint phase, render the snapshot image.
(WebCore::RenderSnapshottedPlugIn::paintSnapshotImage): Rename.
(WebCore::RenderSnapshottedPlugIn::paintSnapshot): Rename.
(WebCore::RenderSnapshottedPlugIn::paintSnapshotWithLabel): Rename. No need for label sizes.
(WebCore::RenderSnapshottedPlugIn::getCursor):
(WebCore::RenderSnapshottedPlugIn::handleEvent): The renderer doesn't restart the plug-in any more. Tell the element and it will do it.

rendering/RenderSnapshottedPlugIn.h:

(RenderSnapshottedPlugIn): New inheritance. Some method renaming.

Source/WebKit2: Snapshotted plug-in should use shadow root
https://bugs.webkit.org/show_bug.cgi?id=108284

Reviewed by Simon Fraser.

Take three of this commit - after rollout in r142400 and r142405.
We no longer have any need for plugInStartLabelImage.

WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: Remove plugInStartLabelImage.
WebProcess/InjectedBundle/InjectedBundlePageUIClient.h: Ditto.
WebProcess/WebCoreSupport/WebChromeClient.cpp: Ditto.
WebProcess/WebCoreSupport/WebChromeClient.h: Ditto.

Tools: Remove use of plugInStartLabelImage
https://bugs.webkit.org/show_bug.cgi?id=108273

Reviewed by Simon Fraser.

Take two - after rollout in r142405.
Removed plugInStartLabelImage entry from client structure.

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

1:29 PM Changeset in webkit [142506] by mkwst@chromium.org

4 edits
2 adds in trunk

CSP reports for blocked 'data:' URLs should report the scheme only.
https://bugs.webkit.org/show_bug.cgi?id=109429

Reviewed by Adam Barth.

Source/WebCore:

https://dvcs.w3.org/hg/content-security-policy/rev/001dc8e8bcc3 changed
the CSP 1.1 spec to require that blocked URLs that don't refer to
generally resolvable schemes (e.g. 'data:', 'javascript:', etc.) be
stripped down to their scheme in violation reports.

Test: http/tests/security/contentSecurityPolicy/report-blocked-data-uri.html

page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation):

If the blocked URL is a web-resolvable scheme, apply the current
stripping logic to it, otherwise, strip it to the scheme only.

platform/KURL.h:

(KURL):

Move KURL::isHierarchical() out into KURL's public API.

LayoutTests:

http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt: Added.
http/tests/security/contentSecurityPolicy/report-blocked-data-uri.html: Added.

1:28 PM Changeset in webkit [142505] by Simon Fraser

5 edits in trunk/Source/WebCore

ScrollingTree node maps keep getting larger
https://bugs.webkit.org/show_bug.cgi?id=109348

Reviewed by Sam Weinig.

When navigating between pages, nodes would get left in the ScrollingTree's
node map, and the ScrollingStateTree's node map, so these would get larger
and larger as you browse.

Simplify map maintenance by clearing the map when setting a new root node
(which happens on the first commit of a new page). Also, don't keep root nodes
around, but create them afresh for each page, which simplifies their ID
management.

This is closer to the original behavior; keeping the root nodes around was
a fix for bug 99668, but we avoid regressing that fix by bailing early
from frameViewLayoutUpdated() if there is no root state node (we'll get
called again anyway).

This now allows state nodeIDs to be purely read-only.

page/scrolling/ScrollingStateNode.h:
page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::ScrollingStateTree):
(WebCore::ScrollingStateTree::attachNode):
(WebCore::ScrollingStateTree::clear):
(WebCore::ScrollingStateTree::removeNode):

page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateTreeFromStateNode):

page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated):

1:28 PM Changeset in webkit [142504] by Simon Fraser

5 edits in trunk/Source/WebCore

Move m_stateNodeMap from ScrollingCoordinatorMac to ScrollingStateTree
https://bugs.webkit.org/show_bug.cgi?id=109361

Reviewed by Sam Weinig.

The map of scrolling node IDs to ScollingStateNodes was maintained by
ScrollingCoordinatorMac, rather than ScrollingStateTree. This is different
from the ScrollingTree (which owns its node map), and added some amount
of to-and-fro between ScrollingStateTree and ScrollingCoordinatorMac.

Having ScrollingCoordinatorMac maintain the map of IDs to state nodes
simplifies things.

No behavior change.

page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::attachNode):
(WebCore::ScrollingStateTree::detachNode):
(WebCore::ScrollingStateTree::clear):
(WebCore::ScrollingStateTree::removeNode):
(WebCore::ScrollingStateTree::stateNodeForID):

page/scrolling/ScrollingStateTree.h:

(ScrollingStateTree): Remove some stale comments.
(WebCore::ScrollingStateTree::removedNodes):

page/scrolling/mac/ScrollingCoordinatorMac.h:

(ScrollingCoordinatorMac):

page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinatorMac::recomputeWheelEventHandlerCountForFrameView):
(WebCore::ScrollingCoordinatorMac::frameViewRootLayerDidChange):
(WebCore::ScrollingCoordinatorMac::requestScrollPositionUpdate):
(WebCore::ScrollingCoordinatorMac::attachToStateTree):
(WebCore::ScrollingCoordinatorMac::detachFromStateTree):
(WebCore::ScrollingCoordinatorMac::clearStateTree):
(WebCore::ScrollingCoordinatorMac::updateScrollingNode):
(WebCore::ScrollingCoordinatorMac::updateViewportConstrainedNode):

1:26 PM Changeset in webkit [142503] by mrowe@apple.com

2 edits in trunk/Source/WebCore

Build fix.

platform/mac/PlatformSpeechSynthesizerMac.mm: Fix the case in the include.

1:26 PM Changeset in webkit [142502] by andersca@apple.com

3 edits in trunk/Source/WebKit2

The plug-in process connection manager doesn't need to be heap allocated
https://bugs.webkit.org/show_bug.cgi?id=109479

Reviewed by Andreas Kling.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::pluginProcessConnectionManager):
(WebKit::WebProcess::pluginProcessCrashed):

WebProcess/WebProcess.h:

(WebKit):
(WebProcess):

1:24 PM Changeset in webkit [142501] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r181742. Requested by
fmalita_ via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-11

DEPS:

1:11 PM Changeset in webkit [142500] by jchaffraix@webkit.org

7 edits
2 adds in trunk

Regression(r131539): Heap-use-after-free in WebCore::RenderBlock::willBeDestroyed
https://bugs.webkit.org/show_bug.cgi?id=107189

Reviewed by Abhishek Arya.

Source/WebCore:

Test: fast/dynamic/continuation-detach-crash.html

This patch reverts r131539 and the following changes (r132591 and r139664).
This means we redo detaching from the bottom-up which solves the regression.
It fixes the attached test case as we re-attach child nodes before detaching
the parent. It seems wrong to do but this avoid a stale continuation.

dom/ContainerNode.cpp:

(WebCore::ContainerNode::detach): Detach the children first, then ourself.

dom/Node.cpp:

(WebCore::Node::detach): Clear the renderer instead of ASSERT'ing.

rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed): Removed the code to clear the associated node's renderer.
(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):

rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):
Moved the repainting logic back into removeChildNode from destroyAndCleanupAnonymousWrappers.
(WebCore::RenderObjectChildList::destroyLeftoverChildren): Re-added the code to clear the associated node's
renderer.

rendering/RenderTextFragment.cpp:

(WebCore::RenderTextFragment::setText): Re-added the code to set the associated node's renderer.

dom/ContainerNode.cpp:

(WebCore::ContainerNode::detach):

dom/Node.cpp:

(WebCore::Node::detach):

rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):
(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):

rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::destroyLeftoverChildren):
(WebCore::RenderObjectChildList::removeChildNode):

rendering/RenderTextFragment.cpp:

(WebCore::RenderTextFragment::setText):

LayoutTests:

fast/dynamic/continuation-detach-crash-expected.txt: Added.
fast/dynamic/continuation-detach-crash.html: Added.

1:04 PM Changeset in webkit [142499] by tony@chromium.org

47 edits
2 adds in trunk

Move setFrameFlatteningEnabled from layoutTestController to window.internals.settings
https://bugs.webkit.org/show_bug.cgi?id=87149

Reviewed by Simon Fraser.

Source/WebKit2:

WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Add setFrameFlatteningEnabled to the list of overridable values.

Tools:

Remove testRunner.setFrameFlatteningEnabled from DRT and WTR. WebKit API
methods are left because there may be users of it. Add a test for Apple Mac
to ensure that the API for the preference still works using overridePreference.

DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

DumpRenderTree/TestRunner.h:

(TestRunner):

DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):

DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
DumpRenderTree/efl/TestRunnerEfl.cpp:
DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

DumpRenderTree/gtk/TestRunnerGtk.cpp:
DumpRenderTree/mac/TestRunnerMac.mm:
DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

DumpRenderTree/qt/TestRunnerQt.cpp:
DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

DumpRenderTree/win/TestRunnerWin.cpp:
DumpRenderTree/wx/TestRunnerWx.cpp:
WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:
WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Update tests to use internal.settings.setFrameFlatteningEnabled, which is automatically
generated from Settings.in.
Add a Mac only test that uses overridePreference to test the API.

fast/frames/flattening/crash-svg-document.html:
fast/frames/flattening/frameset-flattening-advanced.html:
fast/frames/flattening/frameset-flattening-grid.html:
fast/frames/flattening/frameset-flattening-simple.html:
fast/frames/flattening/frameset-flattening-subframe-resize.html:
fast/frames/flattening/frameset-flattening-subframesets.html:
fast/frames/flattening/iframe-flattening-crash.html:
fast/frames/flattening/iframe-flattening-fixed-height.html:
fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout.html:
fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:
fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html:
fast/frames/flattening/iframe-flattening-fixed-width-and-height.html:
fast/frames/flattening/iframe-flattening-fixed-width.html:
fast/frames/flattening/iframe-flattening-nested.html:
fast/frames/flattening/iframe-flattening-offscreen.html:
fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html:
fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html:
fast/frames/flattening/iframe-flattening-out-of-view.html:
fast/frames/flattening/iframe-flattening-selection-crash.html:
fast/frames/flattening/iframe-flattening-simple.html:
fast/frames/flattening/iframe-tiny.html:
fast/spatial-navigation/snav-iframe-flattening-simple.html:
fast/text-autosizing/narrow-iframe-flattened.html:
http/tests/misc/iframe-flattening-3level-nesting-with-blocking-resource.html:
platform/chromium/TestExpectations: Chromium doesn't use frame flattening on mobile either.
plugins/frameset-with-plugin-frame.html:
fast/frames/flattening/crash-svg-document.html:
fast/frames/flattening/frameset-flattening-advanced.html:
fast/frames/flattening/frameset-flattening-grid.html:
fast/frames/flattening/frameset-flattening-simple.html:
fast/frames/flattening/frameset-flattening-subframe-resize.html:
fast/frames/flattening/frameset-flattening-subframesets.html:
fast/frames/flattening/iframe-flattening-crash.html:
fast/frames/flattening/iframe-flattening-fixed-height.html:
fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout.html:
fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:
fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html:
fast/frames/flattening/iframe-flattening-fixed-width-and-height.html:
fast/frames/flattening/iframe-flattening-fixed-width.html:
fast/frames/flattening/iframe-flattening-nested.html:
fast/frames/flattening/iframe-flattening-offscreen.html:
fast/frames/flattening/iframe-flattening-out-of-view-and-scroll.html:
fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html:
fast/frames/flattening/iframe-flattening-out-of-view.html:
fast/frames/flattening/iframe-flattening-selection-crash.html:
fast/frames/flattening/iframe-flattening-simple.html:
fast/frames/flattening/iframe-tiny.html:
fast/spatial-navigation/snav-iframe-flattening-simple.html:
fast/text-autosizing/narrow-iframe-flattened.html:
http/tests/misc/iframe-flattening-3level-nesting-with-blocking-resource.html:
platform/chromium/TestExpectations:
platform/mac/fast/frames/flattening/set-preference-expected.txt: Added.
platform/mac/fast/frames/flattening/set-preference.html: Added.
plugins/frameset-with-plugin-frame.html:

12:43 PM Changeset in webkit [142498] by commit-queue@webkit.org

8 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r142491.
http://trac.webkit.org/changeset/142491
https://bugs.webkit.org/show_bug.cgi?id=109470

broke the 32 bit build (Requested by jessieberlin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-11

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGNodeType.h:

(DFG):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileStrictEq):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

12:41 PM Changeset in webkit [142497] by eric@webkit.org

14 edits
1 add in trunk/Source/WebCore

Make WebVTTTokenizer stop inheriting from MarkupTokenizerBase
https://bugs.webkit.org/show_bug.cgi?id=109411

Reviewed by Adam Barth.

Moved InputStreamPreprocessor into its own header file so it can be
used by both WebVTTTokenizer and HTMLTokenizer.

Also split out kEndOfFileMarker from InputStreamPreprocessor<T> so that
it can be used w/o a specific instantiation of the template class.
This also made it possible to fix three old fixmes about wanting to share
that constant.

Again, separating WebVTT code from Markup* base classes made it simpler
at the cost of a little copy/paste code. WebVTT tokenization is remarkably
simple compared to HTML.

This will make it immediately possible to pull MarkupTokenizerBase up into
HTMLTokenizer and further simplify the code.

GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::markEndOfFile):

html/parser/HTMLInputStream.h:

(WebCore::HTMLInputStream::markEndOfFile):

html/parser/HTMLTokenizer.cpp:

(WebCore::HTMLTokenizer::nextToken):

html/parser/InputStreamPreprocessor.h: Added.

(WebCore):
(InputStreamPreprocessor):
(WebCore::InputStreamPreprocessor::InputStreamPreprocessor):
(WebCore::InputStreamPreprocessor::nextInputCharacter):
(WebCore::InputStreamPreprocessor::peek):
(WebCore::InputStreamPreprocessor::advance):
(WebCore::InputStreamPreprocessor::skipNextNewLine):
(WebCore::InputStreamPreprocessor::reset):
(WebCore::InputStreamPreprocessor::shouldTreatNullAsEndOfFileMarker):

html/track/WebVTTTokenizer.cpp:

(WebCore::WebVTTTokenizer::WebVTTTokenizer):
(WebCore::WebVTTTokenizer::nextToken):

html/track/WebVTTTokenizer.h:

(WebVTTTokenizer):
(WebCore::WebVTTTokenizer::haveBufferedCharacterToken):
(WebCore::WebVTTTokenizer::bufferCharacter):
(WebCore::WebVTTTokenizer::emitAndResumeIn):
(WebCore::WebVTTTokenizer::emitEndOfFile):
(WebCore::WebVTTTokenizer::shouldSkipNullCharacters):

xml/parser/MarkupTokenizerBase.h:

(MarkupTokenizerBase):
(WebCore::MarkupTokenizerBase::bufferCharacter):

12:37 PM Changeset in webkit [142496] by fmalita@chromium.org

2 edits in trunk/Source/Platform

[Chromium] FilterTypeSaturatingBrightness enum
https://bugs.webkit.org/show_bug.cgi?id=109380

Introduce a new WebFilterOperation::FilterType enum (FilterTypeSaturatingBrightness)
to support existing interntal clients which rely on the current saturating brightness
behavior (in preparation of switching to the new brightness implementation).

Reviewed by James Robinson.

chromium/public/WebFilterOperation.h:

(WebKit::WebFilterOperation::amount):
(WebKit::WebFilterOperation::createSaturatingBrightnessFilter):
(WebKit::WebFilterOperation::setAmount):

12:36 PM Changeset in webkit [142495] by roger_fong@apple.com

2 edits in trunk/Tools

Unreviewed. Windows 7 Debug mode build fix.

DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:

12:23 PM Changeset in webkit [142494] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

[Chromium] Replace correct misspelled range in WebKit::WebFrameImpl::replaceMisspelledRange
https://bugs.webkit.org/show_bug.cgi?id=108513

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-11
Reviewed by Tony Chang.

WebKit::WebFrameImpl::replaceMisspelledRange is going to be used by Chromium instead of
WebKit::WebFrameImpl::replaceSelection for correcting misspellings. The current implementation
of WebKit::WebFrameImpl::replaceMisspelledRange sometimes replaces the wrong range. This change
uses Range::create instead of TextIterator::rangeFromLocationAndLength to select the correct
range. This change also disables smart replace in WebKit::WebFrameImpl::replaceMisspelledRange
to avoid introducing spaces around misspellings.

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::replaceMisspelledRange): Replace correct misspelled range.

tests/WebFrameTest.cpp: Add unit test for WebKit::WebFrameImpl::replaceMisspelledRange method.

11:53 AM Changeset in webkit [142493] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[WK2][Notifications] Missing early return in populateCopyOfNotificationPermissions
https://bugs.webkit.org/show_bug.cgi?id=108459

Patch by Claudio Saavedra <Claudio Saavedra> on 2013-02-11
Reviewed by Alexey Proskuryakov.

UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::populateCopyOfNotificationPermissions):
Providers might return 0 and we will end up with a null-pointer dereference.
Early check against this.

11:48 AM Changeset in webkit [142492] by abarth@webkit.org

3 edits
2 adds in trunk

document.write during window.onload can trigger DumpRenderTree to dump the render tree
https://bugs.webkit.org/show_bug.cgi?id=109465

Reviewed by Eric Seidel.

Source/WebCore:

This patch is a partial revert of
http://trac.webkit.org/changeset/142378. It's not safe to call
checkComplete during the load event. We'll need to find another way of
calling checkComplete at the right time.

Test: fast/parser/document-write-during-load.html

dom/Document.cpp:

(WebCore::Document::decrementActiveParserCount):

LayoutTests:

fast/parser/document-write-during-load-expected.txt: Added.
fast/parser/document-write-during-load.html: Added.

11:21 AM Changeset in webkit [142491] by fpizlo@apple.com

8 edits in trunk/Source/JavaScriptCore

DFG CompareEq(a, null) and CompareStrictEq(a, const) are unsound with respect to constant folding
https://bugs.webkit.org/show_bug.cgi?id=109387

Reviewed by Oliver Hunt.

Lock in the decision to use a non-speculative constant comparison as early as possible
and don't let the CFA change it by folding constants. This might be a performance
penalty on some really weird code (FWIW, I haven't seen this on benchmarks), but on
the other hand it completely side-steps the unsoundness that the bug speaks of.

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::isConstantForCompareStrictEq):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGNodeType.h:

(DFG):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileStrictEq):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

11:13 AM Changeset in webkit [142490] by Christophe Dumez

2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark fast/flexbox/line-clamp-link-after-ellipsis.html as failing
on EFL port. This test was introduced in r142335.

platform/efl/TestExpectations:

10:16 AM Changeset in webkit [142489] by Csaba Osztrogonác

2 edits in trunk/Source/JavaScriptCore

Unreviewed fix after r13954 for !ENABLE(JIT) builds.

llint/LowLevelInterpreter.cpp:

10:15 AM Changeset in webkit [142488] by caseq@chromium.org

4 edits
2 adds in trunk

Web Inspector: Timeline: invalidate and force locations are same for Layout records caused by style recalculaiton
https://bugs.webkit.org/show_bug.cgi?id=109294

Reviewed by Pavel Feldman.

Source/WebCore:

Use the stack that caused style recalculation as a cause for relayout performed due to
layout invalidation caused by style recalculation.

inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.Record):

LayoutTests:

inspector/timeline/timeline-layout-reason-expected.txt: Added.
inspector/timeline/timeline-layout-reason.html: Added.
inspector/timeline/timeline-test.js:

(initialize_Timeline.step2):
(initialize_Timeline.InspectorTest.evaluateWithTimeline): Extracted "performActions" step from performActionsAndPrint()
(initialize_Timeline.):
(initialize_Timeline.InspectorTest.performActionsAndPrint):
(initialize_Timeline.InspectorTest.findPresentationRecord.findByType):
(initialize_Timeline.InspectorTest.findPresentationRecord):

10:11 AM Changeset in webkit [142487] by commit-queue@webkit.org

2 edits in trunk/Tools

[BlackBerry] Set mouse document position for mouse event in DRT.
https://bugs.webkit.org/show_bug.cgi?id=109094.

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-02-11
Reviewed by Rob Buis.

RIM PR 246976.
Internally Reviewed by Nima Ghanavatian & Genevieve Mak.

Set mouse document position when we create mouse event in DRT.

DumpRenderTree/blackberry/EventSender.cpp:

(setMouseEventDocumentPos):
(mouseDownCallback):
(mouseUpCallback):
(mouseMoveToCallback):

10:05 AM Changeset in webkit [142486] by caseq@chromium.org

7 edits in trunk

Web Inspector: [Extension API] adjust inspectedWindow.eval() callback parameters to expose non-exceptional error
https://bugs.webkit.org/show_bug.cgi?id=108640

Reviewed by Vsevolod Vlasov.

Source/WebCore:

only set first parameter to eval() callback iff expression successfully evaluates;
use object, not bool as second parameter;
pass exceptions and extension errors as second parameter if evaluate failed;
minor drive-by changes in ExtensionAPI utilities.

inspector/front-end/ExtensionAPI.js:

(injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression):
(injectedExtensionAPI.InspectedWindow.prototype.):
(injectedExtensionAPI.InspectedWindow.prototype.eval):
(injectedExtensionAPI.extractCallbackArgument):

inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype.):
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
(WebInspector.ExtensionStatus):

LayoutTests:

Rebase tests following change in exception parameter to inspectedWindow.eval() callback.

inspector/extensions/extensions-eval-expected.txt:
inspector/extensions/extensions-eval.html:
inspector/extensions/extensions-sidebar-expected.txt:

10:01 AM Changeset in webkit [142485] by caseq@chromium.org

6 edits in trunk

Web Inspector: [Extensions API] expose ExtensionServerClient to tests so tests use same port as extensions API
https://bugs.webkit.org/show_bug.cgi?id=109443

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Promote extensionServer var to the outer closure, so it may be accessed by platform-specific (or test) code.

inspector/front-end/ExtensionAPI.js:

(buildExtensionAPIInjectedScript):

LayoutTests:

replace additional message ports used for evaluating code in front-end with normal extension transport.

http/tests/inspector/extensions-test.js:

(initialize_ExtensionsTest.window.buildPlatformExtensionAPI):
(initialize_ExtensionsTest.InspectorTest._replyToExtension):
(initialize_ExtensionsTest.onEvaluate):

http/tests/inspector/resources/extension-main.js:
inspector/extensions/extensions-audits.html:

9:54 AM Changeset in webkit [142484] by eric@webkit.org

2 edits in trunk/Source/WebCore

Move WebVTTToken off of MarkupTokenBase
https://bugs.webkit.org/show_bug.cgi?id=109410

Reviewed by Tony Gentilcore.

This introduces a small amount of "copy/paste" code
but actually makes WebVTTToken much smaller and simpler!
This also frees the HTMLParser to have its Token class
back to itself so we can tune it to make HTML faster.

html/track/WebVTTToken.h:

(WebVTTToken):
(WebCore::WebVTTToken::WebVTTToken):
(WebCore::WebVTTToken::appendToName):
(WebCore::WebVTTToken::type):
(WebCore::WebVTTToken::name):
(WebCore::WebVTTToken::ensureIsCharacterToken):
(WebCore::WebVTTToken::appendToCharacter):
(WebCore::WebVTTToken::beginEmptyStartTag):
(WebCore::WebVTTToken::beginStartTag):
(WebCore::WebVTTToken::beginEndTag):
(WebCore::WebVTTToken::beginTimestampTag):
(WebCore::WebVTTToken::makeEndOfFile):
(WebCore::WebVTTToken::clear):

9:28 AM Changeset in webkit [142483] by jsbell@chromium.org

6 edits
3 adds in trunk

[V8] IndexedDB: Minor GC can collect IDBDatabase wrapper with versionchange handler
https://bugs.webkit.org/show_bug.cgi?id=108670

Reviewed by Kentaro Hara.

Source/WebCore:

Prevent IDBDatabase's wrapper from being GC'd while the database is open if it has
listeners, as those listeners may close the database in response to events.

Also, removed extraneous super-calls from hasPendingActivity() overrides.

Test: storage/indexeddb/database-wrapper.html

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::hasPendingActivity): Implemented.

Modules/indexeddb/IDBDatabase.h: Declared.
Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::hasPendingActivity): Simplified.

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::hasPendingActivity): Simplified.

LayoutTests:

storage/indexeddb/database-wrapper-expected.txt: Added.
storage/indexeddb/database-wrapper.html: Added.
storage/indexeddb/resources/database-wrapper.js: Added.

(test):
(openDB):
(onUpgradeNeeded):
(openSuccess.get request.onsuccess):
(onVersionChange):
(collectGarbage):
(openAgain):
(onBlocked):
(openAgainSuccess):

9:17 AM Changeset in webkit [142482] by mifenton@rim.com

6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add form navigation control state tracking.
https://bugs.webkit.org/show_bug.cgi?id=109300

Reviewed by Rob Buis.

Add form navigation control state tracking.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::focusNextField):
(WebKit):
(BlackBerry::WebKit::WebPage::focusPreviousField):
(BlackBerry::WebKit::WebPage::submitForm):

Api/WebPage.h:
Api/WebPageClient.h:
WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::updateFormState):

WebKitSupport/InputHandler.h:

(InputHandler):

9:01 AM Changeset in webkit [142481] by rgabor@webkit.org

5 edits in trunk/Source/JavaScriptCore

JSC build failing with verbose debug mode
https://bugs.webkit.org/show_bug.cgi?id=109441

Reviewed by Darin Adler.

Fixing some verbose messages which caused build errors.

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::mergeToSuccessors):

dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::performBlockCFA):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):

dfg/DFGPredictionInjectionPhase.cpp:

(JSC::DFG::PredictionInjectionPhase::run):

8:52 AM Changeset in webkit [142480] by eric@webkit.org

4 edits in trunk/Source/WebCore

Remove AttributeBase now that NEW_XML is gone
https://bugs.webkit.org/show_bug.cgi?id=109408

Reviewed by Adam Barth.

Just deleting code. HTMLToken::Attribute is now just
the real class and not a typedef.

html/parser/CompactHTMLToken.cpp:

(WebCore::CompactHTMLToken::CompactHTMLToken):

html/parser/HTMLTokenizer.cpp:

(WebCore::AtomicHTMLToken::nameForAttribute):

xml/parser/MarkupTokenBase.h:

(WebCore):
(MarkupTokenBase):
(Attribute):
(Range):

8:24 AM Changeset in webkit [142479] by commit-queue@webkit.org

2 edits in trunk/Tools

[BlackBerry] Add graphics subdirectory to include path.
https://bugs.webkit.org/show_bug.cgi?id=109437

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2013-02-11
Reviewed by Rob Buis.

Add browser/platform/graphics to include path.

Internal review by Jeff Rogers.

Scripts/webkitdirs.pm:

(blackberryCMakeArguments):

8:19 AM Changeset in webkit [142478] by Christophe Dumez

2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip fast/forms/number/number-l10n-input.html that was added in r142122
but fails on EFL port.

platform/efl/TestExpectations:

8:06 AM Changeset in webkit [142477] by Christophe Dumez

2 edits in trunk/Tools

[EFL][WKTR] Regression(r141836) fast/dom/Window/mozilla-focus-blur.html started failing
https://bugs.webkit.org/show_bug.cgi?id=109438

Reviewed by Kenneth Rohde Christiansen.

Some refactoring in r141836 caused the view not to get focus if the focused
frame is not the main one. The idea of the code was to remove focus from the
view if the focused frame was not the main one, and then focus the view again.
However, after the refactoring, the second step never happened: Focus was
removed but not given again.

WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::focus):

8:00 AM Changeset in webkit [142476] by vsevik@chromium.org

3 edits in trunk/LayoutTests

Unreviewed revert test fix attempt and skip it.

inspector/editor/text-editor-home-button.html:
platform/chromium/TestExpectations:

7:58 AM Changeset in webkit [142475] by eric@webkit.org

2 edits in trunk/Source/WebCore

Rename PreloadTask to StartTagScanner to match its purpose
https://bugs.webkit.org/show_bug.cgi?id=109406

Reviewed by Sam Weinig.

As discussed in bug 107807.

html/parser/HTMLPreloadScanner.cpp:

(WebCore::StartTagScanner::StartTagScanner):
(WebCore::StartTagScanner::processAttributes):
(WebCore::HTMLPreloadScanner::processToken):

7:50 AM Changeset in webkit [142474] by vsevik@chromium.org

13 edits
1 move in trunk

Web Inspector: WebInspector.Project refactorings.
https://bugs.webkit.org/show_bug.cgi?id=109433

Reviewed by Alexander Pavlov.

Source/WebCore:

This change prepares Workspace and Project to migration to project-per-domain mode for network based projects.
Renamed WebInspector.WorkspaceProvider to WebInspector.ProjectDelegate.
Renamed Project.name() to Project.id() and delegated it to project delegate.
Added Project.displayName() method that is delegated to project delegate.
SimpleWorkspaceProvider is now responsible for creation of SimpleWorkspaceDelegates and
isolates various mappings from Project/ProjectDelegate concept.
UISourceCode is now created based on path in the project.
UISourceCode uri is now calculated based on project and path (right now uri is equal to path).

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/compile-front-end.py:
inspector/front-end/FileSystemProjectDelegate.js: Renamed from Source/WebCore/inspector/front-end/FileSystemWorkspaceProvider.js.

(WebInspector.FileSystemProjectDelegate):
(WebInspector.FileSystemProjectDelegate.prototype.id):
(WebInspector.FileSystemProjectDelegate.prototype.type):
(WebInspector.FileSystemProjectDelegate.prototype.displayName):
(WebInspector.FileSystemProjectDelegate.prototype.innerCallback):
(WebInspector.FileSystemProjectDelegate.prototype.requestFileContent):
(WebInspector.FileSystemProjectDelegate.prototype.setFileContent):
(WebInspector.FileSystemProjectDelegate.prototype.contentCallback):
(WebInspector.FileSystemProjectDelegate.prototype.searchInFileContent):
(WebInspector.FileSystemProjectDelegate.prototype._contentTypeForPath):
(WebInspector.FileSystemProjectDelegate.prototype._populate.filesLoaded):
(WebInspector.FileSystemProjectDelegate.prototype._populate):
(WebInspector.FileSystemProjectDelegate.prototype._addFile):
(WebInspector.FileSystemProjectDelegate.prototype._removeFile):
(WebInspector.FileSystemProjectDelegate.prototype.reset):
(WebInspector.FileSystemUtils):
(WebInspector.FileSystemUtils.errorHandler):
(WebInspector.FileSystemUtils.requestFileSystem):
(.fileSystemLoaded):
(.innerCallback):
(WebInspector.FileSystemUtils.requestFilesRecursive):
(.fileEntryLoaded):
(.fileLoaded):
(.readerLoadEnd):
(WebInspector.FileSystemUtils.requestFileContent):
(.fileWriterCreated.fileTruncated):
(.fileWriterCreated):
(.writerEnd):
(WebInspector.FileSystemUtils.setFileContent):
(WebInspector.FileSystemUtils._getDirectory):
(.toArray):
(WebInspector.FileSystemUtils._readDirectory):
(WebInspector.FileSystemUtils._requestEntries):

inspector/front-end/IsolatedFileSystemModel.js:

(WebInspector.IsolatedFileSystemModel.prototype._innerAddFileSystem):

inspector/front-end/SimpleWorkspaceProvider.js:

(WebInspector.SimpleProjectDelegate):
(WebInspector.SimpleProjectDelegate.prototype.id):
(WebInspector.SimpleProjectDelegate.prototype.displayName):
(WebInspector.SimpleProjectDelegate.prototype.requestFileContent):
(WebInspector.SimpleProjectDelegate.prototype.setFileContent):
(WebInspector.SimpleProjectDelegate.prototype.searchInFileContent):
(WebInspector.SimpleProjectDelegate.prototype.addFile):
(WebInspector.SimpleProjectDelegate.prototype._uniquePath):
(WebInspector.SimpleProjectDelegate.prototype.removeFile):
(WebInspector.SimpleProjectDelegate.prototype.reset):
(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.uriForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.addUniqueFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.removeFile):
(WebInspector.SimpleWorkspaceProvider.prototype.reset):

inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.path):
(WebInspector.UISourceCode.prototype.uri):

inspector/front-end/WebKit.qrc:
inspector/front-end/Workspace.js:

(WebInspector.FileDescriptor):
(WebInspector.ProjectDelegate):
(WebInspector.ProjectDelegate.prototype.id):
(WebInspector.ProjectDelegate.prototype.displayName):
(WebInspector.ProjectDelegate.prototype.requestFileContent):
(WebInspector.ProjectDelegate.prototype.setFileContent):
(WebInspector.ProjectDelegate.prototype.searchInFileContent):
(WebInspector.Project):
(WebInspector.Project.prototype.id):
(WebInspector.Project.prototype.type):
(WebInspector.Project.prototype.displayName):
(WebInspector.Project.prototype.isServiceProject):
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype._reset):
(WebInspector.Project.prototype.uiSourceCode):
(WebInspector.Project.prototype.uiSourceCodeForOriginURL):
(WebInspector.Project.prototype.uiSourceCodeForURI):
(WebInspector.Project.prototype.uiSourceCodes):
(WebInspector.Project.prototype.requestFileContent):
(WebInspector.Project.prototype.setFileContent):
(WebInspector.Project.prototype.searchInFileContent):
(WebInspector.Project.prototype.dispose):
(WebInspector.Workspace.prototype.uiSourceCode):
(WebInspector.Workspace.prototype.uiSourceCodeForURI):
(WebInspector.Workspace.prototype.addProject):
(WebInspector.Workspace.prototype.removeProject):
(WebInspector.Workspace.prototype.project):
(WebInspector.Workspace.prototype.uiSourceCodes):
(WebInspector.Workspace.prototype.projectForUISourceCode):

inspector/front-end/inspector.html:

LayoutTests:

inspector/debugger/live-edit-breakpoints.html:
inspector/uisourcecode-revisions.html:

7:45 AM Changeset in webkit [142473] by yurys@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: fix closure compiler warnings in the profiler code
https://bugs.webkit.org/show_bug.cgi?id=109432

Reviewed by Pavel Feldman.

Updated type annotations to match the code.

inspector/front-end/NativeMemorySnapshotView.js:
inspector/front-end/ProfilesPanel.js:

7:44 AM Changeset in webkit [142472] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[QT] Regression (r142444): Broke qt linux minimal build
https://bugs.webkit.org/show_bug.cgi?id=109423

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2013-02-11
Reviewed by Kenneth Rohde Christiansen.

Test: cssom/cssvalue-comparison.html

css/CSSValue.cpp:

(WebCore::CSSValue::equals):

7:40 AM Changeset in webkit [142471] by commit-queue@webkit.org

7 edits
1 add in trunk/Source/WebCore

Web Inspector: introduce WebInspector.TextUtils
https://bugs.webkit.org/show_bug.cgi?id=109289

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-11
Reviewed by Pavel Feldman.

Add new WebInspector.TextUtils file and extract commonly used
text-operation subroutines from DefaultTextEditor into it.

No new tests: no change in behaviour.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/compile-front-end.py:
inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.TokenHighlighter.prototype._isWord):
(WebInspector.DefaultTextEditor.WordMovementController.prototype._rangeForCtrlArrowMove):
(WebInspector.TextEditorMainPanel.BraceHighlightController.prototype.handleSelectionChange):

inspector/front-end/TextUtils.js: Added.

(WebInspector.TextUtils.isStopChar):
(WebInspector.TextUtils.isWordChar):
(WebInspector.TextUtils.isSpaceChar):
(WebInspector.TextUtils.isWord):
(WebInspector.TextUtils.isBraceChar):

inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:

7:26 AM Changeset in webkit [142470] by Christophe Dumez

4 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline fast/dynamic/002.html on EFL port after r142015.
Skip several compositing test cases that started failing after r142112.
Skip several new Kronos WebGL conformance tests that are failing on EFL WK2.

platform/efl-wk2/TestExpectations:
platform/efl/fast/dynamic/002-expected.png:
platform/efl/fast/dynamic/002-expected.txt:

7:12 AM Changeset in webkit [142469] by Bruno de Oliveira Abinader

2 edits in trunk/Websites/webkit.org

Add basysKom to domainAffiliations in team.html
https://bugs.webkit.org/show_bug.cgi?id=109306

Reviewed by Laszlo Gombos.

team.html:

7:09 AM Changeset in webkit [142468] by mikhail.pozdnyakov@intel.com

2 edits in trunk/Websites/webkit.org

Add intel.com to team.html
https://bugs.webkit.org/show_bug.cgi?id=109424

Reviewed by Kenneth Rohde Christiansen.

team.html:

7:05 AM Changeset in webkit [142467] by zandobersek@gmail.com

2 edits in trunk/Tools

[GTK] Don't generate documentation if building neither WebKit1 nor WebKit2
https://bugs.webkit.org/show_bug.cgi?id=109420

Reviewed by Philippe Normand.

Don't generate the GTK documentation if neither of the WebKit1 and WebKit2
layers was built. This just results in unnecessary errors being spewed out
by the gtkdoc utilities.

Scripts/webkitdirs.pm:

(buildAutotoolsProject):

7:03 AM Changeset in webkit [142466] by zandobersek@gmail.com

1 edit in trunk/Source/WebCore

Adding the svn:ignore property that the previous commit (done through webkit-patch) failed to.

6:59 AM Changeset in webkit [142465] by zandobersek@gmail.com

1 edit in trunk/ChangeLog

Source/WebCore: Modified property svn:ignore, adding GNUmakefile.features.am

to the list of paths to be ignored.

6:47 AM Changeset in webkit [142464] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk/TestExpectations: Adding a failure expectation for the

cssom/cssvalue-comparison.html, the test was added in r142444 and is failing
due to CSS image-set functionality not yet enabled in the GTK port.

6:43 AM Changeset in webkit [142463] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

[GTK][Clang] Build errors in LocalizedStringsGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=109418

Reviewed by Philippe Normand.

Use the C++ isfinite(float) and abs(float) (instead of fabsf(float))
methods by including the WTF MathExtras.h header. Use a static cast to
an integer type on the float return value of the abs(float) method call
instead of the C-style cast.

No new tests - no new functiolnality.

platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::localizedMediaTimeDescription):

6:42 AM Changeset in webkit [142462] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

Unreviewed build fix for the WTFURL backend of KURL.

platform/KURL.cpp:

(WebCore::KURL::isSafeToSendToAnotherThread): m_urlImpl is of RefPtr type so use
the appropriate operator on it when calling the isSafeToSendToAnotherThread method.

5:55 AM Changeset in webkit [142461] by mkwst@chromium.org

3 edits in trunk/Source/WebCore

Range::collapsed callers should explicitly ASSERT_NO_EXCEPTION.
https://bugs.webkit.org/show_bug.cgi?id=108921

Reviewed by Jochen Eisinger.

For clarity and consistency, this patch adjusts Range::collapsed() to
drop the default value of the ExceptionCode parameter it accepts. The
three call sites that called the method with no arguments (all part of
Editor::rangeOfString) will now explicitly ASSERT_NO_EXCEPTION.

dom/Range.h:

(Range):

editing/Editor.cpp:

(WebCore::Editor::rangeOfString):

5:54 AM Changeset in webkit [142460] by commit-queue@webkit.org

32 edits
2 adds in trunk

Web Inspector: Split Profiler domain in protocol into Profiler and HeapProfiler
https://bugs.webkit.org/show_bug.cgi?id=108653

Patch by Alexei Filippov <alph@chromium.org> on 2013-02-11
Reviewed by Yury Semikhatsky.

Currently CPU and heap profilers share the same domain 'Profiler' in the protocol.
In fact these two profile types have not too much in common. So put each into its own domain.
It should also help when Profiles panel gets split into several tools.
This is the phase 1 which adds InspectorHeapProfilerAgent but doesn't
change the original InspectorProfilerAgent.

PerformanceTests:

inspector/heap-snapshot-performance-test.js:

(test.performanceTest.cleanup):

Source/WebCore:

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
inspector/Inspector.json:
inspector/InspectorAllInOne.cpp:
inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

inspector/InspectorHeapProfilerAgent.cpp: Added.

(WebCore):
(WebCore::InspectorHeapProfilerAgent::create):
(WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):
(WebCore::InspectorHeapProfilerAgent::~InspectorHeapProfilerAgent):
(WebCore::InspectorHeapProfilerAgent::resetState):
(WebCore::InspectorHeapProfilerAgent::resetFrontendProfiles):
(WebCore::InspectorHeapProfilerAgent::setFrontend):
(WebCore::InspectorHeapProfilerAgent::clearFrontend):
(WebCore::InspectorHeapProfilerAgent::restore):
(WebCore::InspectorHeapProfilerAgent::collectGarbage):
(WebCore::InspectorHeapProfilerAgent::createSnapshotHeader):
(WebCore::InspectorHeapProfilerAgent::hasHeapProfiler):
(WebCore::InspectorHeapProfilerAgent::getProfileHeaders):
(WebCore::InspectorHeapProfilerAgent::getHeapSnapshot):
(WebCore::InspectorHeapProfilerAgent::removeProfile):
(WebCore::InspectorHeapProfilerAgent::takeHeapSnapshot):
(WebCore::InspectorHeapProfilerAgent::getObjectByHeapObjectId):
(WebCore::InspectorHeapProfilerAgent::getHeapObjectId):
(WebCore::InspectorHeapProfilerAgent::reportMemoryUsage):

inspector/InspectorHeapProfilerAgent.h: Added.

(WebCore):
(InspectorHeapProfilerAgent):
(WebCore::InspectorHeapProfilerAgent::clearProfiles):

inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):

inspector/InstrumentingAgents.h:

(WebCore):
(InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorHeapProfilerAgent):
(WebCore::InstrumentingAgents::setInspectorHeapProfilerAgent):

inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

inspector/front-end/HeapSnapshotDataGrids.js:
inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):

inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapProfileHeader.prototype.startSnapshotTransfer):
(WebInspector.HeapProfileHeader.prototype.saveToFile.onOpen):
(WebInspector.HeapProfileHeader.prototype.saveToFile):

inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._clearProfiles):
(WebInspector.ProfilesPanel.prototype._garbageCollectButtonClicked):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
(WebInspector.ProfilesPanel.prototype._populateProfiles.var):
(WebInspector.ProfilesPanel.prototype._populateProfiles.populateCallback):
(WebInspector.ProfilesPanel.prototype._populateProfiles):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilesPanel.prototype.revealInView):
(WebInspector.HeapProfilerDispatcher):
(WebInspector.HeapProfilerDispatcher.prototype.addProfileHeader):
(WebInspector.HeapProfilerDispatcher.prototype.addHeapSnapshotChunk):
(WebInspector.HeapProfilerDispatcher.prototype.finishHeapSnapshot):
(WebInspector.HeapProfilerDispatcher.prototype.resetProfiles):
(WebInspector.HeapProfilerDispatcher.prototype.reportHeapSnapshotProgress):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._garbageCollectButtonClicked):

inspector/front-end/inspector.js:

(WebInspector.doLoadedDone):

Source/WebKit/chromium:

src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgent::shouldInterruptForMessage):

LayoutTests:

inspector-protocol/heap-profiler/resources/heap-snapshot-common.js:

(InspectorTest.takeHeapSnapshot.InspectorTest.eventHandler.string_appeared_here):
(InspectorTest.takeHeapSnapshot):

inspector-protocol/nmi-webaudio-leak-test.html:
inspector/profiler/heap-snapshot-get-profile-crash.html:
inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
inspector/profiler/heap-snapshot-loader.html:
inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest):

5:51 AM Changeset in webkit [142459] by mkwst@chromium.org

2 edits in trunk/Source/WebCore

Use IGNORE_EXCEPTION for Editor::countMatchesForText's ignored exceptions.
https://bugs.webkit.org/show_bug.cgi?id=109372

Reviewed by Jochen Eisinger.

Rather than implicitly ignoring exceptions, we should use the
IGNORE_EXCEPTION macro for clarity.

editing/Editor.cpp:

(WebCore::Editor::countMatchesForText):

5:12 AM Changeset in webkit [142458] by Christophe Dumez

2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline EFL expectation for fast/js/global-constructors.html after
r142205.

platform/efl/fast/js/global-constructors-expected.txt:

4:55 AM Changeset in webkit [142457] by kadam@inf.u-szeged.hu

2 edits in trunk/Source/WebCore

[Qt] Unreviewed. Fix minimal build after r142444.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-02-11

css/CSSValue.cpp:

(WebCore::CSSValue::equals):

4:47 AM Changeset in webkit [142456] by vsevik@chromium.org

2 edits in trunk/LayoutTests

Unreviewed r142439 follow-up: test fix.

inspector/editor/text-editor-home-button.html:

4:46 AM Changeset in webkit [142455] by Antoine Quint

2 edits in trunk/Tools

Unreviewed change to add myself to the Inspector IDLs watchlist.

Scripts/webkitpy/common/config/watchlist:

4:44 AM Changeset in webkit [142454] by Christophe Dumez

6 edits in trunk/Source

[EFL] Stop using smart pointers for Ecore_Timer
https://bugs.webkit.org/show_bug.cgi?id=109409

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Stop using a smart pointer for Ecore_Timer in RunLoop::TimerBase. This
is a bad idea because the timer handle becomes invalid as soon as the
timer callback returns ECORE_CALLBACK_CANCEL. This may lead to crashes
on destruction because OwnPtr calls ecore_timer_del() on an invalid
handle.

No new tests, already covered by exiting tests.

platform/RunLoop.h:

(TimerBase):

platform/efl/RunLoopEfl.cpp:

(WebCore::RunLoop::TimerBase::timerFired):
(WebCore::RunLoop::TimerBase::start):
(WebCore::RunLoop::TimerBase::stop):

Source/WTF:

Remove support in OwnPtr for EFL's Ecore_Timer. It is a bad idea to use
OwnPtr for Ecore_Timer because the timer handle may become invalid.

wtf/OwnPtrCommon.h:

(WTF):

wtf/efl/OwnPtrEfl.cpp:

4:38 AM Changeset in webkit [142453] by Christophe Dumez

2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark 2 webgl/conformance test cases as crashing on EFL WK2.

platform/efl-wk2/TestExpectations:

4:15 AM Changeset in webkit [142452] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Allow SplitView to keep the sidebar size as a fraction of the container size
https://bugs.webkit.org/show_bug.cgi?id=109414

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-11
Reviewed by Vsevolod Vlasov.

SplitView now interprets defaultSidebarWidth and defaultSidebarHeight values between 0 and 1 as
fractions of the total container size. The sidebar then will grow or shrink along with the container.
When the sidebar is resized manually the updated ratio is stored in the settings.

inspector/front-end/SplitView.js:

(WebInspector.SplitView):
(WebInspector.SplitView.prototype._removeAllLayoutProperties):
(WebInspector.SplitView.prototype._updateTotalSize):
(WebInspector.SplitView.prototype._innerSetSidebarSize):
(WebInspector.SplitView.prototype._saveSidebarSize):

3:51 AM Changeset in webkit [142451] by commit-queue@webkit.org

5 edits
1 copy
2 moves
2 adds in trunk/Tools

[GTK][EFL] Shares WebKit-GTK's DumpRenderTree accessibility implementation with other Webkit ports
https://bugs.webkit.org/show_bug.cgi?id=105007

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-02-11
Reviewed by Martin Robinson.

Shares specific ATK's accessibility implementation.
Keeps platform specific methods in EFL and GTK's directories.

DumpRenderTree/atk/AccessibilityCallbacks.h: Renamed from Tools/DumpRenderTree/gtk/AccessibilityCallbacks.h.
DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Renamed from Tools/DumpRenderTree/gtk/AccessibilityCallbacks.cpp.

(printAccessibilityEvent):
(axObjectEventListener):
(connectAccessibilityCallbacks):
(disconnectAccessibilityCallbacks):

DumpRenderTree/atk/AccessibilityControllerAtk.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.

(AccessibilityController::AccessibilityController):
(AccessibilityController::~AccessibilityController):
(AccessibilityController::elementAtPoint):
(AccessibilityController::setLogFocusEvents):
(AccessibilityController::setLogScrollingStartEvents):
(AccessibilityController::setLogValueChangeEvents):
(AccessibilityController::setLogAccessibilityEvents):
(AccessibilityController::addNotificationListener):
(AccessibilityController::removeNotificationListener):

DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp.

(coreAttributeToAtkAttribute):
(roleToString):
(replaceCharactersForResults):
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):
(AccessibilityUIElement::getLinkedUIElements):
(AccessibilityUIElement::getDocumentLinks):
(AccessibilityUIElement::getChildren):
(AccessibilityUIElement::getChildrenWithRange):
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
(AccessibilityUIElement::childrenCount):
(AccessibilityUIElement::elementAtPoint):
(AccessibilityUIElement::linkedUIElementAtIndex):
(AccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElement::indexOfChild):
(attributeSetToString):
(AccessibilityUIElement::allAttributes):
(AccessibilityUIElement::attributesOfLinkedUIElements):
(AccessibilityUIElement::attributesOfDocumentLinks):
(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(AccessibilityUIElement::attributesOfChildren):
(AccessibilityUIElement::parameterizedAttributeNames):
(AccessibilityUIElement::role):
(AccessibilityUIElement::subrole):
(AccessibilityUIElement::roleDescription):
(AccessibilityUIElement::title):
(AccessibilityUIElement::description):
(AccessibilityUIElement::stringValue):
(AccessibilityUIElement::language):
(AccessibilityUIElement::x):
(AccessibilityUIElement::y):
(AccessibilityUIElement::width):
(AccessibilityUIElement::height):
(AccessibilityUIElement::clickPointX):
(AccessibilityUIElement::clickPointY):
(AccessibilityUIElement::orientation):
(AccessibilityUIElement::intValue):
(AccessibilityUIElement::minValue):
(AccessibilityUIElement::maxValue):
(AccessibilityUIElement::valueDescription):
(checkElementState):
(AccessibilityUIElement::isEnabled):
(AccessibilityUIElement::insertionPointLineNumber):
(AccessibilityUIElement::isPressActionSupported):
(AccessibilityUIElement::isIncrementActionSupported):
(AccessibilityUIElement::isDecrementActionSupported):
(AccessibilityUIElement::isRequired):
(AccessibilityUIElement::isFocused):
(AccessibilityUIElement::isSelected):
(AccessibilityUIElement::hierarchicalLevel):
(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):
(AccessibilityUIElement::isExpanded):
(AccessibilityUIElement::isChecked):
(AccessibilityUIElement::attributesOfColumnHeaders):
(AccessibilityUIElement::attributesOfRowHeaders):
(AccessibilityUIElement::attributesOfColumns):
(AccessibilityUIElement::attributesOfRows):
(AccessibilityUIElement::attributesOfVisibleCells):
(AccessibilityUIElement::attributesOfHeader):
(AccessibilityUIElement::indexInTable):
(indexRangeInTable):
(AccessibilityUIElement::rowIndexRange):
(AccessibilityUIElement::columnIndexRange):
(AccessibilityUIElement::lineForIndex):
(AccessibilityUIElement::boundsForRange):
(AccessibilityUIElement::stringForRange):
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringRangeIsMisspelled):
(AccessibilityUIElement::uiElementForSearchPredicate):
(AccessibilityUIElement::cellForColumnAndRow):
(AccessibilityUIElement::selectedTextRange):
(AccessibilityUIElement::setSelectedTextRange):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::numberAttributeValue):
(AccessibilityUIElement::boolAttributeValue):
(AccessibilityUIElement::isAttributeSettable):
(AccessibilityUIElement::isAttributeSupported):
(alterCurrentValue):
(AccessibilityUIElement::increment):
(AccessibilityUIElement::decrement):
(AccessibilityUIElement::press):
(AccessibilityUIElement::showMenu):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::ariaOwnsElementAtIndex):
(AccessibilityUIElement::ariaFlowToElementAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::rowAtIndex):
(AccessibilityUIElement::disclosedByRow):
(AccessibilityUIElement::accessibilityValue):
(AccessibilityUIElement::documentEncoding):
(AccessibilityUIElement::documentURI):
(AccessibilityUIElement::url):
(AccessibilityUIElement::addNotificationListener):
(AccessibilityUIElement::removeNotificationListener):
(AccessibilityUIElement::isFocusable):
(AccessibilityUIElement::isSelectable):
(AccessibilityUIElement::isMultiSelectable):
(AccessibilityUIElement::isSelectedOptionActive):
(AccessibilityUIElement::isVisible):
(AccessibilityUIElement::isOffScreen):
(AccessibilityUIElement::isCollapsed):
(AccessibilityUIElement::isIgnored):
(AccessibilityUIElement::hasPopup):
(AccessibilityUIElement::takeFocus):
(AccessibilityUIElement::takeSelection):
(AccessibilityUIElement::addSelection):
(AccessibilityUIElement::removeSelection):
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):

DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers, libraries, new sources.
DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(AccessibilityController::focusedElement):
(AccessibilityController::rootElement):
(AccessibilityController::accessibleElementById):

DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::helpText):

GNUmakefile.am: Adds renamed sources.

3:49 AM Changeset in webkit [142450] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: highlight DOM nodes on hover while debugging
https://bugs.webkit.org/show_bug.cgi?id=109355

Reviewed by Vsevolod Vlasov.

Along with showing the popover, highlight the remote object as node.

inspector/front-end/ObjectPopoverHelper.js:

(WebInspector.ObjectPopoverHelper.prototype.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
(WebInspector.ObjectPopoverHelper.prototype._onHideObjectPopover):

3:42 AM Changeset in webkit [142449] by haraken@chromium.org

2 edits in trunk/LayoutTests

Unreviewed gardening. Marked editing/spelling/spellcheck-async.html
as [ Pass Failure ].

platform/chromium/TestExpectations:

3:36 AM Changeset in webkit [142448] by haraken@chromium.org

2 edits in trunk/LayoutTests

Unreviewed gardening. Added [Timeout] to http/tests/misc/window-dot-stop.html.

platform/chromium/TestExpectations:

3:29 AM Changeset in webkit [142447] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: displaying whitespace characters is broken
https://bugs.webkit.org/show_bug.cgi?id=109412

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-11
Reviewed by Vsevolod Vlasov.

Add "pointer-events: none" rule for pseudo-class "before", which
maintains rendering of whitespace characters.

No new tests.

inspector/front-end/inspectorSyntaxHighlight.css:

(.webkit-whitespace::before):

3:17 AM Changeset in webkit [142446] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adjusted expectations for two flaky crashers.
Removed failure expectations for tests that pass.

platform/gtk/TestExpectations:

3:05 AM Changeset in webkit [142445] by apavlov@chromium.org

10 edits
4 adds
2 deletes in trunk

Web Inspector: Implement position-based sourcemapping for stylesheets
https://bugs.webkit.org/show_bug.cgi?id=109168

Source/WebCore:

Reviewed by Vsevolod Vlasov.

This change introduces support for position-based source maps for CSS stylesheets.
Sourcemaps and originating resources (sass, scss, etc.) are loaded synchronously
upon the CSS UISourceCode addition. RangeBasedSourceMap is removed as it is not used.

Test: http/tests/inspector/stylesheet-source-mapping.html

inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.setSourceMapping):
(WebInspector.CSSStyleModel.prototype.rawLocationToUILocation):
(WebInspector.CSSStyleModel.LiveLocation.prototype.uiLocation):
(WebInspector.CSSLocation):
(WebInspector.CSSProperty):
(WebInspector.CSSProperty.parsePayload):

inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping):
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.loadSourceMapForScript):

inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSourceMapping):
(WebInspector.SASSSourceMapping.prototype._styleSheetChanged.callback):
(WebInspector.SASSSourceMapping.prototype._styleSheetChanged):
(WebInspector.SASSSourceMapping.prototype._reloadCSS):
(WebInspector.SASSSourceMapping.prototype._resourceAdded.didRequestContent):
(WebInspector.SASSSourceMapping.prototype._resourceAdded):
(WebInspector.SASSSourceMapping.prototype._loadAndProcessSourceMap):
(WebInspector.SASSSourceMapping.prototype.loadSourceMapForStyleSheet):
(WebInspector.SASSSourceMapping.prototype._bindUISourceCode):
(WebInspector.SASSSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.SASSSourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.SASSSourceMapping.prototype._reset):

inspector/front-end/SourceMap.js:

(WebInspector.SourceMap):
(WebInspector.SourceMap.load):
(WebInspector.SourceMap.prototype.findEntry):
(WebInspector.SourceMap.prototype.findEntryReversed):
(WebInspector.SourceMap.prototype._parseMap):

inspector/front-end/StylesSourceMapping.js:

(WebInspector.StylesSourceMapping):
(WebInspector.StylesSourceMapping.prototype._bindUISourceCode):

inspector/front-end/inspector.js:

LayoutTests:

Added test for the stylesheet source mappings, followed the API changes,
removed RangeBasedSourceMap tests as this type of sourcemap is gone.

Reviewed by Vsevolod Vlasov.

http/tests/inspector/compiler-script-mapping-expected.txt:
http/tests/inspector/compiler-script-mapping.html:
http/tests/inspector/resources/example.css.map: Added.
http/tests/inspector/resources/example.scss: Added.
http/tests/inspector/stylesheet-source-mapping-expected.txt: Added.
http/tests/inspector/stylesheet-source-mapping.html: Added.
inspector/styles/range-based-mapping-expected.txt: Removed.
inspector/styles/range-based-mapping.html: Removed.

3:00 AM Changeset in webkit [142444] by commit-queue@webkit.org

69 edits
2 adds in trunk

Implement CSSValue::equals(const CSSValue&) to optimise CSSValue comparison
https://bugs.webkit.org/show_bug.cgi?id=102901

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2013-02-11
Reviewed by Antti Koivisto.

Source/WebCore:

Added comparison method to CSSValue and its children, so that the
css values could be compared efficiently. Before this patch, CSSValue
objects were compared using strings that were generated by the cssText() method.

Test: cssom/cssvalue-comparison.html

css/CSSAspectRatioValue.cpp:

(WebCore::CSSAspectRatioValue::equals):
(WebCore):

css/CSSAspectRatioValue.h:

(CSSAspectRatioValue):

css/CSSBasicShapes.cpp:

(WebCore::CSSBasicShapeRectangle::equals):
(WebCore):
(WebCore::CSSBasicShapeCircle::equals):
(WebCore::CSSBasicShapeEllipse::equals):
(WebCore::CSSBasicShapePolygon::equals):

css/CSSBasicShapes.h:

(CSSBasicShapeRectangle):
(CSSBasicShapeCircle):
(CSSBasicShapeEllipse):
(CSSBasicShapePolygon):

css/CSSBorderImageSliceValue.cpp:

(WebCore::CSSBorderImageSliceValue::equals):
(WebCore):

css/CSSBorderImageSliceValue.h:

(CSSBorderImageSliceValue):

css/CSSCalculationValue.cpp:

(WebCore::CSSCalcValue::equals):
(WebCore):
(WebCore::CSSCalcPrimitiveValue::equals):
(CSSCalcPrimitiveValue):
(WebCore::CSSCalcPrimitiveValue::type):
(WebCore::CSSCalcBinaryOperation::equals):
(CSSCalcBinaryOperation):
(WebCore::CSSCalcBinaryOperation::type):

css/CSSCalculationValue.h:

(WebCore::CSSCalcExpressionNode::equals):
(CSSCalcExpressionNode):
(CSSCalcValue):

css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::equals):
(WebCore):

css/CSSCanvasValue.h:

(CSSCanvasValue):

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForSidesShorthand):

css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::equals):
(WebCore):

css/CSSCrossfadeValue.h:

(CSSCrossfadeValue):

css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::equals):
(WebCore):

css/CSSCursorImageValue.h:

(CSSCursorImageValue):

css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::equals):
(WebCore):

css/CSSFontFaceSrcValue.h:

(CSSFontFaceSrcValue):

css/CSSFunctionValue.cpp:

(WebCore::CSSFunctionValue::equals):
(WebCore):

css/CSSFunctionValue.h:

(CSSFunctionValue):

css/CSSGradientValue.cpp:

(WebCore::CSSLinearGradientValue::equals):
(WebCore):
(WebCore::CSSRadialGradientValue::equals):

css/CSSGradientValue.h:

(WebCore::CSSGradientColorStop::operator==):
(CSSLinearGradientValue):
(CSSRadialGradientValue):

css/CSSImageValue.cpp:

(WebCore::CSSImageValue::equals):
(WebCore):

css/CSSImageValue.h:

(CSSImageValue):

css/CSSInheritedValue.h:

(WebCore::CSSInheritedValue::equals):
(CSSInheritedValue):

css/CSSInitialValue.h:

(WebCore::CSSInitialValue::equals):
(CSSInitialValue):

css/CSSLineBoxContainValue.h:

(WebCore::CSSLineBoxContainValue::equals):

css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::equals):
(WebCore):

css/CSSPrimitiveValue.h:

(CSSPrimitiveValue):

css/CSSReflectValue.cpp:

(WebCore::CSSReflectValue::equals):
(WebCore):

css/CSSReflectValue.h:

(CSSReflectValue):

css/CSSTimingFunctionValue.cpp:

(WebCore::CSSCubicBezierTimingFunctionValue::equals):
(WebCore):
(WebCore::CSSStepsTimingFunctionValue::equals):

css/CSSTimingFunctionValue.h:

(WebCore::CSSLinearTimingFunctionValue::equals):
(CSSLinearTimingFunctionValue):
(CSSCubicBezierTimingFunctionValue):
(CSSStepsTimingFunctionValue):

css/CSSUnicodeRangeValue.cpp:

(WebCore::CSSUnicodeRangeValue::equals):
(WebCore):

css/CSSUnicodeRangeValue.h:

(CSSUnicodeRangeValue):

css/CSSValue.cpp:

(WebCore):
(WebCore::compareCSSValues):
(WebCore::CSSValue::equals):

css/CSSValue.h:

(CSSValue):
(WebCore):
(WebCore::compareCSSValueVector):
(WebCore::compareCSSValuePtr):

css/CSSValueList.cpp:

(WebCore::CSSValueList::removeAll):
(WebCore::CSSValueList::hasValue):
(WebCore::CSSValueList::equals):
(WebCore):

css/CSSValueList.h:

(CSSValueList):

css/CSSVariableValue.h:

(WebCore::CSSVariableValue::equals):
(CSSVariableValue):

css/Counter.h:

(Counter):
(WebCore::Counter::equals):

css/DashboardRegion.h:

(WebCore::DashboardRegion::equals):

css/FontFeatureValue.cpp:

(WebCore::FontFeatureValue::equals):
(WebCore):

css/FontFeatureValue.h:

(FontFeatureValue):

css/FontValue.cpp:

(WebCore::FontValue::equals):
(WebCore):

css/FontValue.h:

(FontValue):

css/MediaQueryExp.h:

(WebCore::MediaQueryExp::operator==):

css/Pair.h:

(WebCore::Pair::equals):
(Pair):

css/Rect.h:

(WebCore::RectBase::equals):
(RectBase):

css/ShadowValue.cpp:

(WebCore::ShadowValue::equals):
(WebCore):

css/ShadowValue.h:

(ShadowValue):

css/StylePropertySet.cpp:

(WebCore::StylePropertySet::get4Values):
(WebCore::StylePropertySet::propertyMatches):

css/WebKitCSSArrayFunctionValue.cpp:

(WebCore::WebKitCSSArrayFunctionValue::equals):
(WebCore):

css/WebKitCSSArrayFunctionValue.h:

(WebKitCSSArrayFunctionValue):

css/WebKitCSSFilterValue.cpp:

(WebCore::WebKitCSSFilterValue::equals):
(WebCore):

css/WebKitCSSFilterValue.h:

(WebKitCSSFilterValue):

css/WebKitCSSMixFunctionValue.cpp:

(WebCore::WebKitCSSMixFunctionValue::equals):
(WebCore):

css/WebKitCSSMixFunctionValue.h:

(WebKitCSSMixFunctionValue):

css/WebKitCSSSVGDocumentValue.cpp:

(WebCore::WebKitCSSSVGDocumentValue::equals):
(WebCore):

css/WebKitCSSSVGDocumentValue.h:

(WebKitCSSSVGDocumentValue):

css/WebKitCSSShaderValue.cpp:

(WebCore::WebKitCSSShaderValue::equals):
(WebCore):

css/WebKitCSSShaderValue.h:

(WebKitCSSShaderValue):

css/WebKitCSSTransformValue.h:

(WebCore::WebKitCSSTransformValue::equals):

editing/EditingStyle.cpp:

(WebCore::HTMLAttributeEquivalent::valueIsPresentInStyle):

svg/SVGColor.cpp:

(WebCore::SVGColor::equals):
(WebCore):

svg/SVGColor.h:

(SVGColor):

svg/SVGPaint.cpp:

(WebCore::SVGPaint::equals):
(WebCore):

svg/SVGPaint.h:

(SVGPaint):

LayoutTests:

New layout test to verify that CSSValue objects comparison works properly.

cssom/cssvalue-comparison-expected.txt: Added.
cssom/cssvalue-comparison.html: Added.

2:24 AM Changeset in webkit [142443] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Web Inspector] Network panel, sort by "transferSize" instead of "resourceSize".
https://bugs.webkit.org/show_bug.cgi?id=109142.

Patch by Pan Deng <pan.deng@intel.com> on 2013-02-11
Reviewed by Vsevolod Vlasov.

Sort by "transferSize" as it is the primary rather than "resoureSize".

No new tests.

inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.SizeComparator):

2:22 AM Changeset in webkit [142442] by haraken@chromium.org

2 edits in trunk/LayoutTests

Unreviewed gardening. Mark svg/custom/foreign-object-skew.svg
as [ ImageOnlyFailure Pass ].

platform/chromium/TestExpectations:

2:11 AM Changeset in webkit [142441] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Web Inspector: [Resources] Prefactorings in DataGrid and CookieTable
https://bugs.webkit.org/show_bug.cgi?id=109141

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-02-11
Reviewed by Vsevolod Vlasov.

1) Make deleteCookie method static and move to WebInspector.Cookie
2) Replace resfreshCallback getter/setter in DataGrid with
constructor parameter

inspector/front-end/CookieItemsView.js: Adopt changes.
inspector/front-end/CookieParser.js:

(WebInspector.Cookie.prototype.remove): Moved from CookiesTable.

inspector/front-end/CookiesTable.js: Adopt changes.
inspector/front-end/DataGrid.js:

Replace setter with constructor parameter.

1:39 AM Changeset in webkit [142440] by commit-queue@webkit.org

7 edits in trunk

Web Inspector: Don't throw exceptions in WebInspector.Color
https://bugs.webkit.org/show_bug.cgi?id=104835

Source/WebCore:

Patch by John J. Barton <johnjbarton@chromium.org> on 2013-02-11
Reviewed by Vsevolod Vlasov.

WebInspector.Color.parse() returns a Color from a string, or null;
Ctor calls now call parse();
In the StylesSideBarPane, test null rather than catch(e).

Added case to inspector/styles/styles-invalid-color-values.html

inspector/front-end/Color.js:

(WebInspector.Color):
(WebInspector.Color.parse):
(WebInspector.Color.fromRGBA):
(WebInspector.Color.fromRGB):
(WebInspector.Color.prototype.toString):
(WebInspector.Color.prototype._parse.this.alpha.set 0):
(WebInspector.Color.prototype._parse.this.nickname.set 2):
(WebInspector.Color.prototype._parse.this.hsla.set 1):
(WebInspector.Color.prototype._parse.this.rgba.set 0):
(WebInspector.Color.prototype._parse.set WebInspector):
(WebInspector.Color.prototype._parse):

inspector/front-end/Spectrum.js:

(WebInspector.Spectrum.prototype.get color):

inspector/front-end/StylesSidebarPane.js:

LayoutTests:

Patch by John J. Barton <johnjbarton@chromium.org> on 2013-02-11
Reviewed by Vsevolod Vlasov.

Added case to test parsing 'none' from border style

inspector/styles/styles-invalid-color-values-expected.txt:
inspector/styles/styles-invalid-color-values.html:

1:34 AM Changeset in webkit [142439] by commit-queue@webkit.org

7 edits
2 adds in trunk

Web Inspector: home button behaviour is wrong in DTE
https://bugs.webkit.org/show_bug.cgi?id=109154

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-11
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Handle home key shortcut explicitly in TextEditorMainPanel.

New test: inspector/editor/text-editor-home-button.html

inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._registerShortcuts):
(WebInspector.TextEditorMainPanel.prototype._handleHomeKey):

LayoutTests:

Add layout test to verify home button behaviour. Exclude this test on
platforms that do not have eventSender object in test shell.

inspector/editor/editor-test.js:

(initialize_EditorTests.lineWithCursor):
(initialize_EditorTests.InspectorTest.textWithSelection): Added helper method to add selection symbols in text.

inspector/editor/text-editor-home-button-expected.txt: Added.
inspector/editor/text-editor-home-button.html: Added.
platform/efl/TestExpectations:
platform/mac/TestExpectations:
platform/qt/TestExpectations:

1:04 AM Changeset in webkit [142438] by jochen@chromium.org

3 edits in trunk/Tools

[chromium] clear the webcache from within the TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109405

Reviewed by Kentaro Hara.

DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::resetAll):

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::resetTestController):

1:02 AM Changeset in webkit [142437] by jochen@chromium.org

3 edits in trunk/Tools

[chromium] add a destructor to EventSender
https://bugs.webkit.org/show_bug.cgi?id=109401

Reviewed by Kentaro Hara.

Otherwise, the compiler will automatically generate a destructor, for
which we need to unnecessarily include WebContextMenuData.h in the
header.

DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::~EventSender):

DumpRenderTree/chromium/TestRunner/src/EventSender.h:

(WebKit):
(EventSender):

12:36 AM Changeset in webkit [142436] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK gardening

platform/gtk/TestExpectations: Flagging media tests affected

by bug 108682

12:27 AM Changeset in webkit [142435] by kadam@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip faling test.
https://bugs.webkit.org/show_bug.cgi?id=109353.

platform/qt/TestExpectations:

12:06 AM Changeset in webkit [142434] by inferno@chromium.org

33 edits in trunk/Source

Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
https://bugs.webkit.org/show_bug.cgi?id=108981

Reviewed by Eric Seidel.

Source/WebCore:

Modules/mediastream/RTCStatsResponse.cpp:

(WebCore::RTCStatsResponse::addElement):
(WebCore::RTCStatsResponse::addStatistic):

Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::skipBuffer):

css/CSSCalculationValue.cpp:

(WebCore::CSSCalcExpressionNodeParser::parseValueMultiplicativeExpression):
(WebCore::CSSCalcExpressionNodeParser::parseAdditiveValueExpression):

css/WebKitCSSTransformValue.cpp:

(WebCore::transformValueToCssString):

editing/TextIterator.cpp:

(WebCore::SearchBuffer::search):

html/HTMLElement.cpp:

(WebCore::parseColorStringWithCrazyLegacyRules):

html/ImageData.cpp:

(WebCore::ImageData::ImageData):

html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement):

html/track/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::add):

platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::getSomeData):

platform/SharedBufferChunkReader.cpp:

(WebCore::SharedBufferChunkReader::nextChunk):

platform/audio/HRTFDatabase.cpp:

(WebCore::HRTFDatabase::getKernelsFromAzimuthElevation):

platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::initializePage):

platform/graphics/Region.cpp:

(WebCore::Region::Shape::segments_end):

platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::getValues):

platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::inputEffect):

platform/text/TextCodecUTF8.cpp:

(WebCore::TextCodecUTF8::decode):

platform/text/mac/TextCodecMac.cpp:

(WebCore::TextCodecMac::decode):

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::checkFloatsInCleanLine):

svg/SVGAnimatedTypeAnimator.h:

(WebCore::SVGAnimatedTypeAnimator::executeAction):

svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::calculatePercentForSpline):

svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::findInstanceTime):

Source/WebKit/chromium:

src/AutofillPopupMenuClient.cpp:

(WebKit::AutofillPopupMenuClient::getSuggestion):
(WebKit::AutofillPopupMenuClient::getLabel):
(WebKit::AutofillPopupMenuClient::getIcon):
(WebKit::AutofillPopupMenuClient::removeSuggestionAtIndex):
(WebKit::AutofillPopupMenuClient::valueChanged):
(WebKit::AutofillPopupMenuClient::selectionChanged):

src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::shouldRunModalDialogDuringPageDismissal):

Source/WTF:

wtf/BitVector.h:

(WTF::BitVector::quickGet):
(WTF::BitVector::quickSet):
(WTF::BitVector::quickClear):

wtf/DecimalNumber.h:

(WTF::DecimalNumber::DecimalNumber):

wtf/SegmentedVector.h:

(WTF::SegmentedVector::ensureSegment):

wtf/StringPrintStream.cpp:

(WTF::StringPrintStream::vprintf):

wtf/Vector.h:

(WTF::::insert):
(WTF::::remove):

wtf/dtoa/utils.h:

(WTF::double_conversion::StringBuilder::SetPosition):
(WTF::double_conversion::StringBuilder::AddSubstring):

Feb 10, 2013:

11:24 PM Changeset in webkit [142433] by Chris Fleizach

12 edits
2 adds in trunk

WebSpeech: Implement basic speaking/finished speaking behavior
https://bugs.webkit.org/show_bug.cgi?id=107135

Reviewed by Sam Weinig.

Source/WebCore:

Implements the basic functionality of speaking utterances.

In the WebCore side, it manages the speech queue the way the spec defines
(that is, new jobs are appended to a queue and wait for other jobs to finish).

On the Mac side, it instantiates a synthesizer and handles the callbacks for when
jobs are finished. It sends those jobs back to WebCore to dispatch the right events.

Test: platform/mac/fast/speechsynthesis/speech-synthesis-speak.html

Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::SpeechSynthesis):
(WebCore::SpeechSynthesis::paused):
(WebCore::SpeechSynthesis::startSpeakingImmediately):
(WebCore::SpeechSynthesis::speak):
(WebCore):
(WebCore::SpeechSynthesis::fireEvent):
(WebCore::SpeechSynthesis::handleSpeakingCompleted):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didFinishSpeaking):
(WebCore::SpeechSynthesis::speakingErrorOccurred):

Modules/speech/SpeechSynthesis.h:

(WebCore):
(WebCore::SpeechSynthesis::speaking):
(SpeechSynthesis):

Modules/speech/SpeechSynthesisEvent.cpp:

(WebCore::SpeechSynthesisEvent::create):
(WebCore):
(WebCore::SpeechSynthesisEvent::SpeechSynthesisEvent):

Modules/speech/SpeechSynthesisEvent.h:

(SpeechSynthesisEvent):
(WebCore::SpeechSynthesisEvent::interfaceName):

Modules/speech/SpeechSynthesisUtterance.h:

(WebCore::SpeechSynthesisUtterance::startTime):
(WebCore::SpeechSynthesisUtterance::setStartTime):
(SpeechSynthesisUtterance):

platform/PlatformSpeechSynthesisUtterance.cpp:

(WebCore::PlatformSpeechSynthesisUtterance::PlatformSpeechSynthesisUtterance):

platform/PlatformSpeechSynthesisUtterance.h:

(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::setVolume):
(WebCore::PlatformSpeechSynthesisUtterance::setRate):
(WebCore::PlatformSpeechSynthesisUtterance::setPitch):
(WebCore::PlatformSpeechSynthesisUtterance::startTime):
(WebCore::PlatformSpeechSynthesisUtterance::setStartTime):
(WebCore::PlatformSpeechSynthesisUtterance::client):

platform/PlatformSpeechSynthesizer.cpp:

(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):

platform/PlatformSpeechSynthesizer.h:

(PlatformSpeechSynthesizerClient):
(WebCore::PlatformSpeechSynthesizer::client):
(PlatformSpeechSynthesizer):

platform/mac/PlatformSpeechSynthesizerMac.mm:

(-[WebSpeechSynthesisWrapper initWithSpeechSynthesizer:WebCore::]):
(-[WebSpeechSynthesisWrapper dealloc]):
(-[WebSpeechSynthesisWrapper convertRateToWPM:]):
(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore::PlatformSpeechSynthesizer::speak):

LayoutTests:

platform/mac/fast/speechsynthesis/speech-synthesis-speak-expected.txt: Added.
platform/mac/fast/speechsynthesis/speech-synthesis-speak.html: Added.

11:06 PM EFLWebKitBuildBots edited by Christophe Dumez

(diff)

11:04 PM EFLWebKitBuildBots edited by Christophe Dumez

(diff)

10:54 PM Changeset in webkit [142432] by haraken@chromium.org

2 edits in trunk/LayoutTests

Unreviewed gardening. Rebaselined an image.

platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:

10:53 PM Changeset in webkit [142431] by haraken@chromium.org

2 edits in trunk/LayoutTests

Unreviewed gardening. Marked http/tests/css/css-image-loading.html as SLOW.

platform/chromium/TestExpectations:

10:47 PM Changeset in webkit [142430] by haraken@chromium.org

2 edits in trunk/LayoutTests

Unreviewed gardening. Rebaselined an image.

platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:

10:38 PM Changeset in webkit [142429] by commit-queue@webkit.org

2 edits in trunk/Websites/webkit.org

Add adobe.com to team.html
https://bugs.webkit.org/show_bug.cgi?id=109396

Patch by Dirk Schulze <dschulze@adobe.com> on 2013-02-10
Reviewed by Laszlo Gombos.

team.html:

9:16 PM Changeset in webkit [142428] by weinig@apple.com

22 edits in trunk/Source/WebKit2

Make the Plug-in XPCService build work even when building in Xcode
<rdar://problem/13011186>
https://bugs.webkit.org/show_bug.cgi?id=109392

Reviewed by Anders Carlsson.

Configurations/DebugRelease.xcconfig:

Add a DEBUG_OR_RELEASE variable to test against.

Configurations/PluginService.32.xcconfig:
Configurations/PluginService.64.xcconfig:

In non-production builds, don't link against WebKit2, so that we don't get warnings about WebKit2.framework
not containing the right architectures. This is ok, as these services are not used in non-production builds.

NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info.plist:
NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/NetworkServiceMain.Development.mm:
NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist:
NetworkProcess/EntryPoint/mac/XPCService/NetworkService/NetworkServiceMain.mm:
PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist:
PluginProcess/EntryPoint/mac/XPCService/PluginService.32/PluginService.32.Main.mm:
PluginProcess/EntryPoint/mac/XPCService/PluginService.64/Info.plist:
PluginProcess/EntryPoint/mac/XPCService/PluginService.64/PluginService.64.Main.mm:
PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/PluginService.Development.Main.mm:
WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/WebContentServiceMain.Development.mm:
WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
WebProcess/EntryPoint/mac/XPCService/WebContentService/WebContentServiceMain.mm:

Switch off the the old idiom of defining a macro for the initializer function, and instead set
it in the Info.plist, so the XPCServiceBootstrapper can grab it.

Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h:

(WebKit::XPCServiceEventHandler):

Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.h:

(WebKit::XPCServiceEventHandler):
Get the entry point from the bundle, rather than the macro. This is not only a bit less gross,
but also allows us to build without having linked against WebKit2.framework.

UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::shouldUseXPC):
Re-enable using XPC for plug-ins.

WebKit2.xcodeproj/project.pbxproj:

Update project.

9:14 PM Changeset in webkit [142427] by eric@webkit.org

15 edits
2 adds in trunk/Source/WebCore

Make the existing HTMLPreloadScanner threading-aware
https://bugs.webkit.org/show_bug.cgi?id=107807

Reviewed by Adam Barth.

The HTMLPreloadScanner and CSSPreloadScanner do a number of things.
CSSPreloadScanner is mostly just a helper class for HTMLPreloadScanner.
HTMLPreloadScanner runs its own copy of the HTMLTokenizer and uses
HTMLTokenizer::updateStateFor to emulate enough of the TreeBuilder
to get a realistic stream of tokens. It does some additional TreeBuilder
emulation, including tracking template tags and base tags, but mostly
just scans the token stream for start-tags and looks for URLs in them.
It tracks when it has seen a <style> tag and starts sending all character tokens
to the CSSPreloadScanner until a </style> tag is seen.
It also (unfortunately) knows some about the loader guts and how to construct
a proper CachedResourcRequest and issue a preload.

This patch changes the model so that the preload scanners only know how to produce
PreloadRequest objects and append them to a passed-in vector.

This changes the preload-scanner behavior so that preloads are now all issued in one large
batch at the end of scanning, instead of as we hit each resource. It's possible that
we'll wait to instead check for preload requests more often, at a possible tradeoff
to tokenizing speed.

An alternate approach might be to pass in a preload-delegate of sorts which knew how
to either build a vector, or send requests immediately. For now the build-a-vector-always
approach seems clean, and does not seem to slow down our PerformanceTest microbenchmarks at least.

This patch has 2 main pieces:

Remove Document and (and loader) dependencies from HTMLPreloadScanner/CSSPreloadScanner This is done through introduction of a new HTMLResourcePreloader class which holds a Document* and knows how to talk to the CachedResourceLoader.
Clean-up HTMLPreloadScanners token-loop to not be tied to having a Tokenizer. (On a background thead, the HTMLPreloadScanner won't own the tokenizer, it will just

be passed in tokens and expected to issue loads if necessary.)

This passes all of the LayoutTests using the main thread parser.

This patch does not make the HTMLPreloadScanner 100% ready for threading
(it still uses AtomicString which is currently not-OK on the parser thread)
but it's very close. Two further (already written) patches will complete this.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.xcodeproj/project.pbxproj:
html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::CSSPreloadScanner):
(WebCore::CSSPreloadScanner::scan):
(WebCore::CSSPreloadScanner::emitRule):

html/parser/CSSPreloadScanner.h:

(CSSPreloadScanner):

html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::appendCurrentInputStreamToPreloadScannerAndScan):

html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):

html/parser/HTMLPreloadScanner.cpp:

(WebCore::isStartTag):
(WebCore):
(WebCore::isStartOrEndTag):
(WebCore::PreloadTask::processAttributes):
(WebCore::PreloadTask::charset):
(PreloadTask):
(WebCore::PreloadTask::resourceType):
(WebCore::PreloadTask::shouldPreload):
(WebCore::PreloadTask::createPreloadRequest):
(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):
(WebCore::HTMLPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::processPossibleTemplateTag):
(WebCore::HTMLPreloadScanner::processPossibleStyleTag):
(WebCore::HTMLPreloadScanner::processPossibleBaseTag):
(WebCore::HTMLPreloadScanner::processToken):

html/parser/HTMLPreloadScanner.h:

(HTMLPreloadScanner):

html/parser/HTMLResourcePreloader.cpp: Added.

(WebCore):
(WebCore::isStringSafeToSendToAnotherThread):
(WebCore::PreloadRequest::isSafeToSendToAnotherThread):
(WebCore::PreloadRequest::completeURL):
(WebCore::PreloadRequest::resourceRequest):
(WebCore::HTMLResourcePreloader::preload):

html/parser/HTMLResourcePreloader.h: Added.

(WebCore):
(PreloadRequest):
(WebCore::PreloadRequest::create):
(WebCore::PreloadRequest::PreloadRequest):
(HTMLResourcePreloader):
(WebCore::HTMLResourcePreloader::HTMLResourcePreloader):
(WebCore::HTMLResourcePreloader::createWeakPtr):

loader/cache/CachedResourceRequest.h:

8:37 PM Changeset in webkit [142426] by haraken@chromium.org

2 edits in trunk/LayoutTests

Unreviewed gardening. Rebaselined an image.

platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:

8:29 PM Changeset in webkit [142425] by commit-queue@webkit.org

2 edits in trunk/Websites/webkit.org

Add sisa.samsung.com to team.html
https://bugs.webkit.org/show_bug.cgi?id=109394

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-02-10
Reviewed by Dirk Schulze.

team.html:

8:14 PM Changeset in webkit [142424] by haraken@chromium.org

11 edits in trunk/Source/WebCore

[V8] Rename isolated() to getWorld(), rename worldForEnteredContextIfIsolated() to worldForEnteredContext()
https://bugs.webkit.org/show_bug.cgi?id=109039

Reviewed by Adam Barth.

This is a follow-up patch for r141983.
Rename methods for consistency.

No tests. No change in behavior.

bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

bindings/v8/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::getWorld):

bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
(WebCore::ScriptController::currentWorldContext):

bindings/v8/V8Binding.h:

(WebCore::worldForEnteredContext):

bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::wrap):

bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::wrap):

bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::wrap):

bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::constructorCallbackCustom):

6:54 PM Changeset in webkit [142423] by aelias@chromium.org

2 edits in trunk/Source/WebCore

[chromium] Fix Android scrollbar size
https://bugs.webkit.org/show_bug.cgi?id=109374

Reviewed by James Robinson.

This shrinks scrollbars to 3 device-independent pixels (usually 6
physical pixels) and deletes the edge fade. Although the Android
system theme does have an edge fade, it's a much sharper cliff
than we had (against black, the colors go 64 -> 64 -> 52 -> 21 -> 0)
and I can't perceive any difference compared with no fade at all.

No new tests (due for rewrite in a week anyway).

platform/chromium/ScrollbarThemeChromiumAndroid.cpp:

(WebCore):
(WebCore::ScrollbarThemeChromiumAndroid::paintThumb):

6:38 PM Changeset in webkit [142422] by commit-queue@webkit.org

18 edits in trunk/Source/WebKit/chromium

[chromium] Enable more of webkit_unit_tests in component builds
https://bugs.webkit.org/show_bug.cgi?id=109369

Patch by James Robinson <jamesr@chromium.org> on 2013-02-10
Reviewed by Darin Fisher.

Updates all webkit_unit_tests (except for LevelDBTest) to go through the Platform API instead of directly
calling into webkit_support so they work in component builds.

WebKit.gyp:
tests/AssociatedURLLoaderTest.cpp:
tests/EventListenerTest.cpp:
tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::createWebViewAndLoad):
(QuitTask):
(WebKit::FrameTestHelpers::QuitTask::run):
(FrameTestHelpers):
(WebKit::FrameTestHelpers::runPendingTasks):

tests/FrameTestHelpers.h:

(FrameTestHelpers):

tests/ListenerLeakTest.cpp:
tests/PopupMenuTest.cpp:
tests/PrerenderingTest.cpp:
tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::ScrollingCoordinatorChromiumTest::~ScrollingCoordinatorChromiumTest):
(WebKit::ScrollingCoordinatorChromiumTest::navigateTo):

tests/URLTestHelpers.cpp:

(WebKit::URLTestHelpers::registerMockedURLLoad):

tests/WebFrameTest.cpp:
tests/WebImageTest.cpp:

(WebKit::readFile):

tests/WebPageNewSerializerTest.cpp:
tests/WebPageSerializerTest.cpp:
tests/WebPluginContainerTest.cpp:

(WebKit::WebPluginContainerTest::TearDown):
(WebKit::TEST_F):

tests/WebViewTest.cpp:

5:29 PM Changeset in webkit [142421] by haraken@chromium.org

2 edits in trunk/LayoutTests

Unreviewed gardening. Marked fast/frames/seamless/seamless-inherited-origin.html as FAIL.

platform/chromium/TestExpectations:

5:23 PM Changeset in webkit [142420] by haraken@chromium.org

2 edits in trunk/LayoutTests

Unreviewed gardening. Rebaselined svg/custom/foreign-object-skew.svg.

platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:

5:16 PM Changeset in webkit [142419] by haraken@chromium.org

7 edits in trunk/Source/WebCore

[V8] Remove V8GCController::m_edenNodes and make minor DOM GC more precise
https://bugs.webkit.org/show_bug.cgi?id=108579

Reviewed by Adam Barth.

Currently V8GCController::m_edenNodes stores a list of nodes whose
wrappers have been created since the latest GC. The reason why we
needed m_edenNodes is that there was no way to know a list of wrappers
in the new space of V8. By using m_edenNodes, we had been approximating
'wrappers in the new space' by 'wrappers that have been created since
the latest GC'.

Now V8 provides VisitHandlesForPartialDependence(), with which WebKit
can know a list of wrappers in the new space. By using the API, we can
remove V8GCController::m_edenNodes. The benefit is that (1) we no longer
need to keep m_edenNodes and that (2) it enables more precise minor
DOM GC (Remember that m_edenNodes was just an approximation).

Performance benchmark: https://bugs.webkit.org/attachment.cgi?id=185940
The benchmark runs 300 iterations, each of which creates 100000 elements.
The benchmark measures average, min, median, max and stdev of execution times
of the 300 iterations. This will tell us the worst-case overhead of this change.

Before:

mean=59.91ms, min=39ms, median=42ms, max=258ms, stdev=47.48ms

After:

mean=58.75ms, min=35ms, median=41ms, max=250ms, stdev=47.32ms

As shown above, I couldn't observe any performance regression.

No tests. No change in behavior.

bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::setWrapperInObject):

bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::getWorldWithoutContextCheck):

bindings/v8/V8Binding.h:

(WebCore):
(WebCore::worldForEnteredContextIfIsolated):
(WebCore::worldForEnteredContextWithoutContextCheck):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):

bindings/v8/V8GCController.cpp:

(WebCore::gcTree):
(WebCore):
(MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::notifyFinished):
(WebCore::MajorGCWrapperVisitor::MajorGCWrapperVisitor):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):

bindings/v8/V8GCController.h:

(V8GCController):

1:50 PM Changeset in webkit [142418] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r181645. Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-10

DEPS:

1:04 PM Changeset in webkit [142417] by commit-queue@webkit.org

6 edits in trunk

Consolidate the way WTF_USE_PTHREADS is enabled
https://bugs.webkit.org/show_bug.cgi?id=108191

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-02-10
Reviewed by Benjamin Poulain.

Remove duplicated definition of WTF_USE_PTHREADS.

WTF_USE_PTHREADS is defined to 1 on all OS(UNIX) environments in
Platform.h.

Source/cmake/OptionsBlackBerry.cmake:
Source/cmake/OptionsEfl.cmake:

Source/WTF:

Define WTF_USE_PTHREADS to 1 on all OS(UNIX) environments.

WTF.gyp/WTF.gyp: Remove duplicated definition of WTF_USE_PTHREADS.
wtf/Platform.h:

12:11 PM Changeset in webkit [142416] by timothy_horton@apple.com

3 edits
5 adds in trunk

REGRESSION (r132422): Page content and scrollbars are incorrectly offset after restoring a page from the page cache
https://bugs.webkit.org/show_bug.cgi?id=109317
<rdar://problem/12649131>

Reviewed by Simon Fraser.

Mark all scrolling that occurs beneath FrameView::layout as programmatic.

Test: platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html

page/FrameView.cpp:

(WebCore::FrameView::layout):

Add a test that ensures that scroll position is correctly restored for pages coming out of the page cache when tiled drawing is enabled.

platform/mac-wk2/tiled-drawing/resources/go-back.html: Added.
platform/mac-wk2/tiled-drawing/resources/scroll-and-load-page.html: Added.
platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html: Added.

11:54 AM Changeset in webkit [142415] by timothy_horton@apple.com

2 edits in trunk/Tools

Unreviewed attempted build fix for Gtk after r142412

WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::PlatformWebView):

11:51 AM Changeset in webkit [142414] by commit-queue@webkit.org

2 edits in trunk/Tools

Unreviewed, rolling out r142413.
http://trac.webkit.org/changeset/142413
https://bugs.webkit.org/show_bug.cgi?id=109383

didn't fix the gtk build (Requested by thorton on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-10

WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

11:40 AM Changeset in webkit [142413] by timothy_horton@apple.com

2 edits in trunk/Tools

Unreviewed attempted build fix for Gtk after r142412

WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

11:27 AM Changeset in webkit [142412] by timothy_horton@apple.com

7 edits in trunk/Tools

WKTR should propagate view creation options to opened windows
https://bugs.webkit.org/show_bug.cgi?id=109381

Reviewed by Simon Fraser.

WebKitTestRunner/PlatformWebView.h:

(WTR::PlatformWebView::options):
Add storage and a getter for PlatformWebView's creation options dictionary.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
Propagate creation options from parent to child PlatformWebView when creating subwindows.

WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView):

WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::PlatformWebView):

WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):

WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):
Store creation options on the PlatformWebView.

10:26 AM Changeset in webkit [142411] by Martin Robinson

2 edits in trunk/Source/JavaScriptCore

Fix the GTK+ gyp build

JavaScriptCore.gypi: Update the source list to accurately

reflect what's in the repository and remove the offsets extractor
from the list of JavaScriptCore files. It's only used to build
the extractor binary.

10:18 AM Changeset in webkit [142410] by tkent@chromium.org

2 edits in trunk/Source/WebCore

[Mac] Fix release build failure by recent reverts

WebCore.exp.in:

9:55 AM Changeset in webkit [142409] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Add back code that was accidentally removed when moving plug-in enumeration back to the main thread
https://bugs.webkit.org/show_bug.cgi?id=109379

Reviewed by Andreas Kling.

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPlugins):

9:48 AM Changeset in webkit [142408] by mitz@apple.com

2 edits in trunk/Source/WebKit/mac

Added *.pdf to EXCLUDED_SOURCE_FILE_NAMES_iphoneos.

Rubber-stamped by Anders Carlsson.

Configurations/WebKit.xcconfig:

9:33 AM Changeset in webkit [142407] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

platform/gtk/TestExpectations: Remove duplicate test expectation

for media/track/track-in-band-style.html.

9:29 AM Changeset in webkit [142406] by Philippe Normand

9 edits in trunk

[GStreamer] media/video-controls-fullscreen-volume.html crashes
https://bugs.webkit.org/show_bug.cgi?id=108682

Reviewed by Martin Robinson.

Source/WebCore:

Clean up various signal handlers and avoid bad interaction between
the FullscreenVideoControllerGStreamer and its subclasses,
especially when the platform video window is created.

platform/graphics/gstreamer/FullscreenVideoControllerGStreamer.cpp:

(WebCore::FullscreenVideoControllerGStreamer::enterFullscreen):
Initialize the window before connecting to the volume/mute
signals. This ensures that the signals won't ever interfere with
an inexisting window.

platform/graphics/gstreamer/GStreamerGWorld.cpp:

(WebCore::GStreamerGWorld::~GStreamerGWorld): Remove GstBus
synchronous handler function.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
Disconnect from volume/mute signals.
(WebCore::MediaPlayerPrivateGStreamerBase::setStreamVolumeElement):
Keep a trace of volume/mute signal handlers.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

Various forward type declarations to avoid un-necessary header includes.
(MediaPlayerPrivateGStreamerBase):

platform/graphics/gtk/FullscreenVideoControllerGtk.cpp:

(WebCore::FullscreenVideoControllerGtk::FullscreenVideoControllerGtk):
(WebCore::FullscreenVideoControllerGtk::volumeChanged): Bail out
if volume button hasn't been created yet.
(WebCore::FullscreenVideoControllerGtk::muteChanged): Ditto.

LayoutTests:

platform/gtk/TestExpectations: Unflag now passing tests.

8:39 AM Changeset in webkit [142405] by tkent@chromium.org

5 edits in trunk

Unreviewed, rolling out r142347.
http://trac.webkit.org/changeset/142347
https://bugs.webkit.org/show_bug.cgi?id=108273

Because a depending change r142343 was rolled out.

Source/WebKit2:

WebProcess/InjectedBundle/API/c/WKBundlePage.h:
WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::plugInStartLabelTitle):
(WebKit::InjectedBundlePageUIClient::plugInStartLabelSubtitle):

Tools:

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

8:04 AM Changeset in webkit [142404] by akling@apple.com

5 edits in trunk/Source/WebCore

RenderStyle should use copy-on-write inheritance for NinePieceImage.
<http://webkit.org/b/109366>

Reviewed by Antti Koivisto.

Refactor NinePieceImage to hold a copy-on-write DataRef like other RenderStyle substructures.
This allows us to avoids copying the NinePieceImageData when one RenderStyle inherits from another
but modifies something in the substructure holding the NinePieceImage (typically StyleSurroundData.)

Also made RenderStyle not copy-on-write its StyleSurroundData prematurely when doing a no-op write
to a border-image related value.

1.23 MB progression on Membuster3.

rendering/style/NinePieceImage.cpp:

(WebCore::defaultData):
(WebCore::NinePieceImage::NinePieceImage):
(WebCore::NinePieceImageData::NinePieceImageData):
(WebCore::NinePieceImageData::operator==):

rendering/style/NinePieceImage.h:

(WebCore::NinePieceImageData::create):
(WebCore::NinePieceImageData::copy):
(NinePieceImageData):
(NinePieceImage):
(WebCore::NinePieceImage::operator==):
(WebCore::NinePieceImage::operator!=):
(WebCore::NinePieceImage::hasImage):
(WebCore::NinePieceImage::image):
(WebCore::NinePieceImage::setImage):
(WebCore::NinePieceImage::imageSlices):
(WebCore::NinePieceImage::setImageSlices):
(WebCore::NinePieceImage::fill):
(WebCore::NinePieceImage::setFill):
(WebCore::NinePieceImage::borderSlices):
(WebCore::NinePieceImage::setBorderSlices):
(WebCore::NinePieceImage::outset):
(WebCore::NinePieceImage::setOutset):
(WebCore::NinePieceImage::horizontalRule):
(WebCore::NinePieceImage::setHorizontalRule):
(WebCore::NinePieceImage::verticalRule):
(WebCore::NinePieceImage::setVerticalRule):
(WebCore::NinePieceImage::copyImageSlicesFrom):
(WebCore::NinePieceImage::copyBorderSlicesFrom):
(WebCore::NinePieceImage::copyOutsetFrom):
(WebCore::NinePieceImage::copyRepeatFrom):
(WebCore::NinePieceImage::setMaskDefaults):
(WebCore::NinePieceImage::computeOutset):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setBorderImageSource):
(WebCore::RenderStyle::setBorderImageSlices):
(WebCore::RenderStyle::setBorderImageWidth):
(WebCore::RenderStyle::setBorderImageOutset):

rendering/style/RenderStyle.h:

7:05 AM Changeset in webkit [142403] by tkent@chromium.org

2 edits in trunk/Tools

[Chromium] Build fix for r142371
https://bugs.webkit.org/show_bug.cgi?id=109313

DumpRenderTree/chromium/TestRunner/src/EventSender.h:

(WebKit):

6:33 AM Changeset in webkit [142402] by tkent@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=109376

platform/chromium/TestExpectations:

fast/frames/seamless/seamless-inherited-origin.html is failing on debug bots.

6:26 AM Changeset in webkit [142401] by Philippe Normand

2 edits in trunk/LayoutTests

Unreviewed, GTK gardening.

platform/gtk/TestExpectations: Flag new failing media/track test.

6:24 AM Changeset in webkit [142400] by tkent@chromium.org

21 edits in trunk/Source

Unreviewed, rolling out r142343.
http://trac.webkit.org/changeset/142343
https://bugs.webkit.org/show_bug.cgi?id=108284

It might make inspector/profiler/selector-profiler-url.html
crashy.

Source/WebCore:

WebCore.exp.in:
css/plugIns.css:

(p):

html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler):

html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::createRenderer):
(WebCore::HTMLPlugInImageElement::willRecalcStyle):
(WebCore::HTMLPlugInImageElement::updateSnapshot):
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot):
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):

html/HTMLPlugInImageElement.h:

(WebCore):
(HTMLPlugInImageElement):

page/ChromeClient.h:

(WebCore::ChromeClient::plugInStartLabelImage):

platform/LocalizedStrings.cpp:
platform/LocalizedStrings.h:
platform/blackberry/LocalizedStringsBlackBerry.cpp:
platform/chromium/LocalizedStringsChromium.cpp:
platform/efl/LocalizedStringsEfl.cpp:

(WebCore):

platform/gtk/LocalizedStringsGtk.cpp:

(WebCore):

platform/qt/LocalizedStringsQt.cpp:
rendering/RenderSnapshottedPlugIn.cpp:

(WebCore):
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):
(WebCore::RenderSnapshottedPlugIn::paint):
(WebCore::RenderSnapshottedPlugIn::paintReplaced):
(WebCore::RenderSnapshottedPlugIn::paintSnapshot):
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshot):
(WebCore::RenderSnapshottedPlugIn::startLabelImage):
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshotWithLabel):
(WebCore::RenderSnapshottedPlugIn::getCursor):
(WebCore::RenderSnapshottedPlugIn::handleEvent):
(WebCore::RenderSnapshottedPlugIn::tryToFitStartLabel):

rendering/RenderSnapshottedPlugIn.h:

Source/WebKit2:

WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::plugInStartLabelImage):
(WebKit):

WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:

(InjectedBundlePageUIClient):

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::plugInStartLabelImage):
(WebKit):

WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

6:13 AM Changeset in webkit [142399] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

Refactor the way HAVE_XXX macros are set
https://bugs.webkit.org/show_bug.cgi?id=108132

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-02-10
Reviewed by Benjamin Poulain.

OS(WINDOWS) and OS(UNIX) are so broadly defined that for each
builds exactly one of them is enabled. Use this assumption to
cleanup Platform.h.

wtf/Platform.h:

5:44 AM Changeset in webkit [142398] by akling@apple.com

3 edits in trunk/Source/WebCore

RenderText: Access characters through m_text instead of caching data pointers separately.
<http://webkit.org/b/109357>

Reviewed by Antti Koivisto.

Go through RenderText::m_text.impl() instead of caching the character data pointer.
RenderText should never have a null String in m_text so it's safe to access impl() directly.
We have assertions for this since before.

Removing this pointer shrinks RenderText by 8 bytes, allowing it to fit into a snugger size class.
749 KB progression on Membuster3.

rendering/RenderText.cpp:

(SameSizeAsRenderText):
(WebCore::RenderText::RenderText):
(WebCore::RenderText::setTextInternal):

rendering/RenderText.h:

(WebCore::RenderText::is8Bit):
(WebCore::RenderText::characters8):
(WebCore::RenderText::characters16):
(WebCore::RenderText::characterAt):
(WebCore::RenderText::operator[]):
(RenderText):

5:01 AM Changeset in webkit [142397] by tkent@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=92941

platform/chromium/TestExpectations:

accessibility/loading-iframe-updates-axtree.html is [ Timeout ].

4:49 AM FeatureFlags edited by tkent@chromium.org

Remove GLIB_SUPPORT, add ENCRYPTED_MEDiA_V2 and NOSNIFF (diff)

4:42 AM Changeset in webkit [142396] by Christophe Dumez

2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip fast/encoding/parser-tests-*.html tests now that the crashes
have been fixed by r142385.

platform/efl-wk2/TestExpectations:

3:23 AM Changeset in webkit [142395] by commit-queue@webkit.org

18 edits in trunk

Rename ENABLE(GLIB_SUPPORT) to USE(GLIB)
https://bugs.webkit.org/show_bug.cgi?id=104266

Patch by Jae Hyun Park <jae.park08@gmail.com> on 2013-02-10
Reviewed by Philippe Normand.

Using USE(GLIB) instead of ENABLE(GLIB_SUPPORT) is more consistent with
the existing macro naming conventions.

From Platform.h
USE() - use a particular third-party library or optional OS service
ENABLE() - turn on a specific feature of WebKit

Source/autotools/SetupAutoconfHeader.m4:
Source/cmake/OptionsEfl.cmake:

Source/WebCore:

No new tests, no new functionality.

WebCore.pri:

Source/WebKit/gtk:

gyp/Configuration.gypi:

Source/WebKit/mac:

WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _close]):

WebView/WebViewData.h:
WebView/WebViewInternal.h:

Source/WTF:

WTF.pri:
wtf/Platform.h:
wtf/gobject/GOwnPtr.cpp:
wtf/gobject/GOwnPtr.h:
wtf/gobject/GRefPtr.cpp:
wtf/gobject/GRefPtr.h:

2:44 AM Changeset in webkit [142394] by zandobersek@gmail.com

3 edits in trunk/Tools

gtkdoc-scangobj throwing warnings when using Clang, causes generate-gtkdoc to fail
https://bugs.webkit.org/show_bug.cgi?id=109315

Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-02-10
Reviewed by Philippe Normand.

GNUmakefile.am: Define the CC environment variable to the CC compiler that the whole

project was configured to use. This ensures both the regular build and the gtkdoc-scangobj
program use the same compiler.

gtk/generate-gtkdoc: Add '-Qunused-arguments' to the CFLAGS in case we're using Clang. This

forces Clang to suppress unused arguments warnings that can unnecessarily cause generate-gtkdoc
script to fail.

2:42 AM Changeset in webkit [142393] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit2

[WebKit2][Gtk] Remove the fullscreen manager proxy message receiver upon invalidating
https://bugs.webkit.org/show_bug.cgi?id=109352

Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-02-10
Reviewed by Sam Weinig.

As added for the Mac port in r142160 due to the changes in the same revision, remove
the fullscreen manager proxy as a message receiver. Also fixes a failing unit test.

UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:

(WebKit::WebFullScreenManagerProxy::invalidate):

2:40 AM Changeset in webkit [142392] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

[GTK] Build errors in TextureMapperShaderProgram.cpp when compiling with Clang
https://bugs.webkit.org/show_bug.cgi?id=109321

Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-02-10
Reviewed by Noam Rosenthal.

Clang is reporting errors due to non-constant expressions that cannot be narrowed
from double to float type in initializer list when constructing a matrix of GC3Dfloat
numbers. To avoid this every parameter is passed through an explicit GC3Dfloat constructor.

No new tests - no new functionality.

platform/graphics/texmap/TextureMapperShaderProgram.cpp:

(WebCore::TextureMapperShaderProgram::setMatrix):

2:00 AM Changeset in webkit [142391] by Philippe Normand

2 edits in trunk/Source/WebCore

[GStreamer] audio is muted when playback rate is between 0.8 and 2.0
https://bugs.webkit.org/show_bug.cgi?id=109362

Reviewed by Martin Robinson.

Don't mute sound if the audio pitch is preserved. If this is not
the case mute it if it's too extreme, as the HTML5 spec recommends.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::setRate):

12:36 AM Changeset in webkit [142390] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[WK2] Fix build on PLUGIN_ARCHITECTURE(UNSUPPORTED) after r142314
https://bugs.webkit.org/show_bug.cgi?id=109364

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-02-10
Reviewed by Simon Hausmann.

void NetscapePlugin::platformPreInitialize() is need to be added to NetscapePluginNone.cpp.

WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:

(WebKit::NetscapePlugin::platformPreInitialize):
(WebKit):

Feb 9, 2013:

11:37 PM Changeset in webkit [142389] by Joseph Pecoraro

2 edits in trunk/Tools

Make TestWebKitAPI work for iOS
https://bugs.webkit.org/show_bug.cgi?id=108978

Patch by David Farler <dfarler@apple.com> on 2013-02-09
Reviewed by Joseph Pecoraro.

TestWebKitAPI/Configurations/Base.xcconfig:

Added back FRAMEWORK_SEARCH_PATHS for Lion builds.

11:09 PM Changeset in webkit [142388] by jamesr@google.com

2 edits
1 add in trunk/Source/Platform

[chromium] Enable more of webkit_unit_tests in component builds
https://bugs.webkit.org/show_bug.cgi?id=109369

Reviewed by Darin Fisher.

Add a set of testing APIs to a WebUnitTestSupport interface available off of Platform for unit tests to access
in component builds.

chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::unitTestSupport):

chromium/public/WebUnitTestSupport.h: Added.

(WebKit):
(WebUnitTestSupport):
(WebKit::WebUnitTestSupport::registerMockedURL):
(WebKit::WebUnitTestSupport::registerMockedErrorURL):
(WebKit::WebUnitTestSupport::unregisterMockedURL):
(WebKit::WebUnitTestSupport::unregisterAllMockedURLs):
(WebKit::WebUnitTestSupport::serveAsynchronousMockedRequests):
(WebKit::WebUnitTestSupport::webKitRootDir):

10:41 PM Changeset in webkit [142387] by akling@apple.com

3 edits in trunk/Source/JavaScriptCore

Shrink-wrap UnlinkedCodeBlock members.
<http://webkit.org/b/109368>

Reviewed by Oliver Hunt.

Rearrange the members of UnlinkedCodeBlock to avoid unnecessary padding on 64-bit.
Knocks ~600 KB off of the Membuster3 peak.

bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):

bytecode/UnlinkedCodeBlock.h:

(UnlinkedCodeBlock):

10:26 PM Changeset in webkit [142386] by jamesr@google.com

3 edits in trunk/LayoutTests

Chromium gardening

platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
platform/chromium/TestExpectations:

10:11 PM Changeset in webkit [142385] by dmazzoni@google.com

4 edits in trunk

fast/encoding/parser-tests-*.html tests sometimes crash
https://bugs.webkit.org/show_bug.cgi?id=108058

Reviewed by Chris Fleizach.

Source/WebCore:

To avoid calling accessibilityIsIgnored while the render
tree is unstable, call accessibilityIsIgnored in the
notification timer handler, only for childrenChanged
notifications.

This exposed a problem where notifications queued on
objects can fire after the object has been deleted; fix that
by checking the object's id, which is always set to 0 when
removed from the tree.

Covered by existing tests.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::notificationPostTimerFired):

LayoutTests:

Make test less brittle by (1) giving the iframe an aria-role so
it's never ignored, and (2) using accessibilityElementById instead
of assuming an element is in a specific place in the AX tree.

accessibility/loading-iframe-updates-axtree.html:

7:48 PM Changeset in webkit [142384] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

Unreviewed, rolling out r137328.
http://trac.webkit.org/changeset/137328
https://bugs.webkit.org/show_bug.cgi?id=109367

causes memory usage to balloon if connection queue is filling
faster than sending (Requested by kling on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-09

Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::ArgumentEncoder):
(CoreIPC::ArgumentEncoder::grow):

Platform/CoreIPC/ArgumentEncoder.h:

(CoreIPC::ArgumentEncoder::buffer):
(ArgumentEncoder):

4:50 PM Changeset in webkit [142383] by eric.carlson@apple.com

3 edits in trunk/Source/WebCore

[Mac] Do not assume MediaAccessibility framework is installed
https://bugs.webkit.org/show_bug.cgi?id=109365

Reviewed by Sam Weinig.

page/CaptionUserPreferencesMac.h:
page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::userPrefersCaptions): Call the base class if the framework

is not available.

(WebCore::CaptionUserPreferencesMac::setUserPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferencesMac::userHasCaptionPreferences): Ditto.
(WebCore::CaptionUserPreferencesMac::registerForCaptionPreferencesChangedCallbacks): Ditto.
(WebCore::CaptionUserPreferencesMac::unregisterForCaptionPreferencesChangedCallbacks): Ditto.
(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Ditto.
(WebCore::CaptionUserPreferencesMac::captionFontSizeScale): Ditto.
(WebCore::CaptionUserPreferencesMac::setPreferredLanguage): Ditto.
(WebCore::CaptionUserPreferencesMac::preferredLanguages): Ditto.

3:06 PM Changeset in webkit [142382] by dmazzoni@google.com

39 edits in trunk/Source/WebCore

AX: move isIgnored caching to AXObject
https://bugs.webkit.org/show_bug.cgi?id=109322

Reviewed by Chris Fleizach.

There's some benefit to caching accessibilityIsIgnored
(using AXComputedObjectAttributeCache) for more than just
AXRenderObject, so move the caching code to AXObject.

AXObject now has a protected virtual method
computeAccessibilityIsIgnored, and all subclasses
override that instead.

No new tests.

accessibility/AccessibilityImageMapLink.h:

(AccessibilityImageMapLink):
(WebCore::AccessibilityImageMapLink::computeAccessibilityIsIgnored):

accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::computeAccessibilityIsIgnored):

accessibility/AccessibilityList.h:

(AccessibilityList):

accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::computeAccessibilityIsIgnored):

accessibility/AccessibilityListBox.h:

(AccessibilityListBox):

accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::computeAccessibilityIsIgnored):

accessibility/AccessibilityListBoxOption.h:

(AccessibilityListBoxOption):

accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::computeAccessibilityIsIgnored):
(WebCore::AccessibilityMediaTimeDisplay::computeAccessibilityIsIgnored):

accessibility/AccessibilityMediaControls.h:

(AccessibilityMediaControl):
(WebCore::AccessibilityMediaControlsContainer::computeAccessibilityIsIgnored):
(AccessibilityMediaTimeDisplay):

accessibility/AccessibilityMenuList.h:

(WebCore::AccessibilityMenuList::computeAccessibilityIsIgnored):

accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::computeAccessibilityIsIgnored):

accessibility/AccessibilityMenuListOption.h:

(AccessibilityMenuListOption):

accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::computeAccessibilityIsIgnored):

accessibility/AccessibilityMenuListPopup.h:

(AccessibilityMenuListPopup):

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored):

accessibility/AccessibilityNodeObject.h:

(AccessibilityNodeObject):

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::accessibilityIsIgnored):
(WebCore):

accessibility/AccessibilityObject.h:

(AccessibilityObject):
(WebCore::AccessibilityObject::computeAccessibilityIsIgnored):

accessibility/AccessibilityProgressIndicator.cpp:

(WebCore::AccessibilityProgressIndicator::computeAccessibilityIsIgnored):

accessibility/AccessibilityProgressIndicator.h:

(AccessibilityProgressIndicator):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::computeAccessibilityIsIgnored):

accessibility/AccessibilityScrollView.h:

(AccessibilityScrollView):

accessibility/AccessibilityScrollbar.h:

(WebCore::AccessibilityScrollbar::computeAccessibilityIsIgnored):

accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::computeAccessibilityIsIgnored):
(WebCore::AccessibilitySliderThumb::computeAccessibilityIsIgnored):

accessibility/AccessibilitySlider.h:

(AccessibilitySlider):
(AccessibilitySliderThumb):

accessibility/AccessibilitySpinButton.h:

(WebCore::AccessibilitySpinButton::computeAccessibilityIsIgnored):
(WebCore::AccessibilitySpinButtonPart::computeAccessibilityIsIgnored):

accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::computeAccessibilityIsIgnored):

accessibility/AccessibilityTable.h:

(AccessibilityTable):

accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::computeAccessibilityIsIgnored):

accessibility/AccessibilityTableCell.h:

(AccessibilityTableCell):

accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::computeAccessibilityIsIgnored):

accessibility/AccessibilityTableColumn.h:

(AccessibilityTableColumn):

accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore::AccessibilityTableHeaderContainer::computeAccessibilityIsIgnored):

accessibility/AccessibilityTableHeaderContainer.h:

(AccessibilityTableHeaderContainer):

accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::computeAccessibilityIsIgnored):

accessibility/AccessibilityTableRow.h:

(AccessibilityTableRow):

2:53 PM Changeset in webkit [142381] by commit-queue@webkit.org

10 edits
1 copy
1 move
1 add in trunk

Make TestWebKitAPI work for iOS
https://bugs.webkit.org/show_bug.cgi?id=108978

Patch by David Farler <dfarler@apple.com> on 2013-02-09
Reviewed by David Kilzer.

Source/WebCore:

Tests already exist - refactor only.

WebCore.exp.in: Lumped ZNK7WebCore4KURL7hasPathEv with related methods.
platform/KURL.cpp: Inlined hasPath() into the header
platform/KURL.h: Inlined hasPath() into the header

Tools:

Makefile: Added TestWebKitAPI to iOS MODULES list.
TestWebKitAPI/Configurations/Base.xcconfig:
Include FeatureDefines
Removed VALID_ARCHS
Removed FRAMEWORK_SEARCH_PATHS - allows building against other SDKs
Excluded source files per platform
TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
framework and library switches per platform
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Remove explicit framework and library linking (moved to xcconfigs)
Added iOS main.mm
TestWebKitAPI/config.h:
Guard importing Cocoa.h and WebKit2_C.h on iOS
TestWebKitAPI/ios/mainIOS.mm: Copied from Tools/TestWebKitAPI/mac/main.mm.
TestWebKitAPI/mac/mainMac.mm: Renamed from Tools/TestWebKitAPI/mac/main.mm.

1:00 PM Changeset in webkit [142380] by schenney@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Reverting earlier change now

Unreviewed expectations.

platform/chromium/TestExpectations: Removed all the expectations added earlier.

12:13 PM Changeset in webkit [142379] by jschuh@chromium.org

2 edits in trunk/Tools

[CHROMIUM] Suppress c4267 build warnings for Win64 tests
https://bugs.webkit.org/show_bug.cgi?id=109359

Reviewed by Abhishek Arya.

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

11:34 AM Changeset in webkit [142378] by abarth@webkit.org

8 edits in trunk/Source/WebCore

Load event fires too early with threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=108984

Reviewed by Eric Seidel.

Previously, the DocumentLoader would always be on the stack when the
HTMLDocumentParser was processing data from the network. The
DocumentLoader would then tell isLoadingInAPISense not to fire the load
event. Now that we process data asynchronously with the threaded
parser, the DocumentLoader is not always on the stack, which means we
need to delay the load event using the clause that asks the parser
whether it is processing data.

Unfortunately, that clause is fragile because we can check for load
completion while we're switching parsers between the network-created
parser and a script-created parser. To avoid accidentially triggerin
the load event during these "gaps," this patch introduces a counter on
document to record how many parsers are active on the stack. While
that numer is non-zero, we'll delay the load event. When that number
reaches zero, we'll check for load complete.

That last step is required because the DocumentLoader::finishLoading
method is no longer guarunteed to check for load complete after calling
finish on the parser because the finish operation might complete
asynchronously.

After this patch, the threaded parser passes all but four fast/parser
tests.

dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::hasActiveParser):
(WebCore):
(WebCore::Document::decrementActiveParserCount):

dom/Document.h:

(Document):
(WebCore::Document::incrementActiveParserCount):

html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):

html/parser/HTMLParserScheduler.cpp:

(WebCore::ActiveParserSession::ActiveParserSession):
(WebCore):
(WebCore::ActiveParserSession::~ActiveParserSession):
(WebCore::PumpSession::PumpSession):
(WebCore::PumpSession::~PumpSession):

html/parser/HTMLParserScheduler.h:

(WebCore):
(ActiveParserSession):
(PumpSession):

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::isLoadingInAPISense):

11:33 AM Changeset in webkit [142377] by fpizlo@apple.com

33 edits
6 adds in trunk/Source/JavaScriptCore

DFG should allow phases to break Phi's and then have one phase to rebuild them
https://bugs.webkit.org/show_bug.cgi?id=108414

Reviewed by Mark Hahnenberg.

Introduces two new DFG forms: LoadStore and ThreadedCPS. These are described in
detail in DFGCommon.h.

Consequently, DFG phases no longer have to worry about preserving data flow
links between basic blocks. It is generally always safe to request that the
graph be dethreaded (Graph::dethread), which brings it into LoadStore form, where
the data flow is implicit. In this form, only liveness-at-head needs to be
preserved.

All of the machinery for "threading" the graph to introduce data flow between
blocks is now moved out of the bytecode parser and into the CPSRethreadingPhase.
All phases that previously did this maintenance themselves now just rely on
being able to dethread the graph. The one exception is the structure check
hoising phase, which operates over a threaded graph and preserves it, for the
sake of performance.

Also moved two other things into their own phases: unification (previously found
in the parser) and prediction injection (previously found in various places).

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
bytecode/Operands.h:

(Operands):
(JSC::Operands::sizeFor):
(JSC::Operands::atFor):

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):

dfg/DFGAllocator.h:

(JSC::DFG::::allocateSlow):

dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

dfg/DFGBasicBlockInlines.h:

(DFG):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::parseBlock):
(DFG):
(JSC::DFG::ByteCodeParser::parse):

dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::killUnreachable):
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
(CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::fixJettisonedPredecessors):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

dfg/DFGCPSRethreadingPhase.cpp: Added.

(DFG):
(CPSRethreadingPhase):
(JSC::DFG::CPSRethreadingPhase::CPSRethreadingPhase):
(JSC::DFG::CPSRethreadingPhase::run):
(JSC::DFG::CPSRethreadingPhase::freeUnnecessaryNodes):
(JSC::DFG::CPSRethreadingPhase::clearVariablesAtHeadAndTail):
(JSC::DFG::CPSRethreadingPhase::addPhiSilently):
(JSC::DFG::CPSRethreadingPhase::addPhi):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeSetLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeSetArgument):
(JSC::DFG::CPSRethreadingPhase::canonicalizeLocalsInBlock):
(JSC::DFG::CPSRethreadingPhase::canonicalizeLocalsInBlocks):
(JSC::DFG::CPSRethreadingPhase::propagatePhis):
(JSC::DFG::CPSRethreadingPhase::PhiStackEntry::PhiStackEntry):
(PhiStackEntry):
(JSC::DFG::CPSRethreadingPhase::phiStackFor):
(JSC::DFG::performCPSRethreading):

dfg/DFGCPSRethreadingPhase.h: Added.

(DFG):

dfg/DFGCSEPhase.cpp:

(CSEPhase):
(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGCommon.cpp:

(WTF):
(WTF::printInternal):

dfg/DFGCommon.h:

(JSC::DFG::logCompilationChanges):
(DFG):
(WTF):

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

dfg/DFGDriver.cpp:

(JSC::DFG::compile):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dethread):
(JSC::DFG::Graph::collectGarbage):

dfg/DFGGraph.h:

(JSC::DFG::Graph::performSubstitution):
(Graph):
(JSC::DFG::Graph::performSubstitutionForEdge):
(JSC::DFG::Graph::convertToConstant):

dfg/DFGNode.h:

(JSC::DFG::Node::convertToPhantomLocal):
(Node):
(JSC::DFG::Node::convertToGetLocal):
(JSC::DFG::Node::hasVariableAccessData):

dfg/DFGNodeType.h:

(DFG):

dfg/DFGPhase.cpp:

(JSC::DFG::Phase::beginPhase):

dfg/DFGPhase.h:

(JSC::DFG::runAndLog):

dfg/DFGPredictionInjectionPhase.cpp: Added.

(DFG):
(PredictionInjectionPhase):
(JSC::DFG::PredictionInjectionPhase::PredictionInjectionPhase):
(JSC::DFG::PredictionInjectionPhase::run):
(JSC::DFG::performPredictionInjection):

dfg/DFGPredictionInjectionPhase.h: Added.

(DFG):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::run):
(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

dfg/DFGUnificationPhase.cpp: Added.

(DFG):
(UnificationPhase):
(JSC::DFG::UnificationPhase::UnificationPhase):
(JSC::DFG::UnificationPhase::run):
(JSC::DFG::performUnification):

dfg/DFGUnificationPhase.h: Added.

(DFG):

dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::dumpGraphIfAppropriate):

dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::setUpCall):

runtime/JSCJSValue.cpp:

(JSC::JSValue::dump):

runtime/JSString.h:

(JSString):

runtime/Options.h:

(JSC):

11:29 AM Changeset in webkit [142376] by rniwa@webkit.org

2 edits in trunk/Tools

Add a link to EFL perf bot on build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=109342

Reviewed by Gyuyoung Kim.

Added.

BuildSlaveSupport/build.webkit.org-config/templates/root.html:

11:19 AM Changeset in webkit [142375] by mkwst@chromium.org

39 edits in trunk/Source/WebCore

Use IGNORE_EXCEPTION for initialized, but unused, ExceptionCodes.
https://bugs.webkit.org/show_bug.cgi?id=109295

Reviewed by Darin Adler.

The monster patch in http://wkbug.com/108771 missed an entire class of
ignored exceptions. It only dealt with call sites that never initialized
the ExceptionCode variable, on the assumption that only such call sites
would ignore the variable's value.

That was a flawed assumption: a large number of sites that initialize the
ExceptionCode to 0 ignore it regardless. This patch deals with the
almost-as-large set of callsites that initialize the variable, pass it to
a function, and then never touch it again.

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::forceClose):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::ariaSelectedTextRange):
(WebCore::AccessibilityRenderObject::visiblePositionForIndex):
(WebCore::AccessibilityRenderObject::indexForVisiblePosition):

accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getSelectionOffsetsForObject):

accessibility/atk/WebKitAccessibleUtil.cpp:

(selectionBelongsToObject):

dom/Node.cpp:

(WebCore::Node::textRects):

editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::hide):

editing/EditingStyle.cpp:

(WebCore::EditingStyle::styleAtSelectionStart):

editing/Editor.cpp:

(WebCore::Editor::canDeleteRange):
(WebCore::Editor::pasteAsPlainText):
(WebCore::Editor::pasteAsFragment):
(WebCore::Editor::shouldDeleteRange):
(WebCore::Editor::dispatchCPPEvent):
(WebCore::Editor::setComposition):
(WebCore::Editor::advanceToNextMisspelling):
(WebCore::isFrameInRange):

editing/EditorCommand.cpp:

(WebCore::expandSelectionToGranularity):

editing/MergeIdenticalElementsCommand.cpp:

(WebCore::MergeIdenticalElementsCommand::doApply):

editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::doUnapply):

editing/SplitTextNodeCommand.cpp:

(WebCore::SplitTextNodeCommand::doApply):

editing/TextCheckingHelper.cpp:

(WebCore::expandToParagraphBoundary):
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
(WebCore::TextCheckingHelper::isUngrammatical):
(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):

editing/TextInsertionBaseCommand.cpp:

(WebCore::dispatchBeforeTextInsertedEvent):
(WebCore::canAppendNewLineFeedToSelection):

editing/TextIterator.cpp:

(WebCore::findPlainText):

editing/htmlediting.cpp:

(WebCore::extendRangeToWrappingNodes):
(WebCore::isNodeVisiblyContainedWithin):

editing/visible_units.cpp:

(WebCore::nextBoundary):

html/FileInputType.cpp:

(WebCore::FileInputType::createShadowSubtree):

html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement):

html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::setText):

html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::setText):

html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::didCompleteLoad):

html/RangeInputType.cpp:

(WebCore::RangeInputType::createShadowSubtree):

html/SearchInputType.cpp:

(WebCore::SearchInputType::createShadowSubtree):

html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):

html/track/TextTrackList.cpp:

(TextTrackList::asyncEventTimerFired):

inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::patchDocument):

inspector/InspectorDatabaseAgent.cpp:

(WebCore):

inspector/InspectorFileSystemAgent.cpp:

(WebCore):

page/DOMSelection.cpp:

(WebCore::DOMSelection::addRange):

page/DragController.cpp:

(WebCore::DragController::dispatchTextInputEventFor):

page/EventHandler.cpp:

(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::handleTouchEvent):

page/FrameActionScheduler.cpp:

(WebCore::EventFrameAction::fire):

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):

svg/SVGDocument.cpp:

(WebCore::SVGDocument::dispatchZoomEvent):
(WebCore::SVGDocument::dispatchScrollEvent):

svg/SVGLength.cpp:

(WebCore::SVGLength::SVGLength):
(WebCore::SVGLength::value):

xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::exitText):

xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::parse):
(WebCore::XMLDocumentParser::startDocument):
(WebCore::XMLDocumentParser::parseCharacters):

11:11 AM Changeset in webkit [142374] by Christophe Dumez

2 edits in trunk/Tools

Unreviewed. Update my IRC nickname in committers.py.

Scripts/webkitpy/common/config/committers.py:

11:09 AM Changeset in webkit [142373] by commit-queue@webkit.org

3 edits in trunk/Tools

build-webkit: document sdk, debug, release, device, and simulator options
https://bugs.webkit.org/show_bug.cgi?id=109221

Patch by David Farler <dfarler@apple.com> on 2013-02-09
Reviewed by David Kilzer.

Scripts/build-webkit: Add options to usage
Scripts/webkitdirs.pm: Remove --deploy and --devel checks

11:07 AM WebKit Team edited by Christophe Dumez

Update my IRC nickname (diff)

11:05 AM Changeset in webkit [142372] by senorblanco@chromium.org

6 edits in trunk/Source/WebCore

[skia] Fix memory management in SkiaImageFilterBuilder and friends.
https://bugs.webkit.org/show_bug.cgi?id=109326

Sadly, skia has no official ref-counted pointers, so we must make do
with SkAutoTUnref.

Reviewed by James Robinson.

Correctness covered by existing tests in css3/filters.

platform/graphics/filters/skia/FEBlendSkia.cpp:

(WebCore::FEBlend::createImageFilter):

platform/graphics/filters/skia/FEComponentTransferSkia.cpp:

(WebCore::FEComponentTransfer::createImageFilter):

platform/graphics/filters/skia/FELightingSkia.cpp:

(WebCore::FELighting::createImageFilter):
Adopt refs produced by the build() pass with SkAutoTUnref.

platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp:

(WebCore::SkiaImageFilterBuilder::~SkiaImageFilterBuilder):
Unref the builder's hashmap effect pointers.
(WebCore::SkiaImageFilterBuilder::build):
Ref the pointer returned to the caller, and use SkAutoTUnref
internally while building the tree.

platform/graphics/filters/skia/SkiaImageFilterBuilder.h:

(SkiaImageFilterBuilder):
Add a destructor to SkiaImageFilterBuilder.

11:01 AM Changeset in webkit [142371] by jochen@chromium.org

8 edits in trunk/Tools

[chromium] move context menu data tracking to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109313

Reviewed by Adam Barth.

DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebKit):
(WebTestDelegate):

DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebKit):
(WebTestRunner::WebTestProxy::showContextMenu):

DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::setContextMenuData):
(WebTestRunner::EventSender::contextClick):

DumpRenderTree/chromium/TestRunner/src/EventSender.h:

(WebKit):
(EventSender):

DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::showContextMenu):
(WebTestRunner):

DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::showContextMenu):

DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

10:55 AM Changeset in webkit [142370] by jochen@chromium.org

9 edits in trunk/Tools

[chromium] move methods that change initial testRunner state to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109043

Reviewed by Adam Barth.

DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebKit):

DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner):

DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::configureForTestWithURL):
(WebTestRunner):

DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(WebKit):
(TestInterfaces):

DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::showDevTools):
(WebTestRunner):
(WebTestRunner::TestRunner::showWebInspector):

DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::configureForTestWithURL):

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::runFileTest):

10:41 AM Changeset in webkit [142369] by thakis@chromium.org

2 edits in trunk/Tools

Add myself as a reviewer. (Yay!!!!!)
https://bugs.webkit.org/show_bug.cgi?id=109110

Unreviewed.

Scripts/webkitpy/common/config/committers.py:

10:35 AM Changeset in webkit [142368] by dmazzoni@google.com

4 edits in trunk/Source/WebCore

AX: Rename AXObject::cachedIsIgnoredValue to lastKnownIsIgnoredValue
https://bugs.webkit.org/show_bug.cgi?id=108238

Reviewed by Chris Fleizach.

Simple refactoring, no new tests.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::childrenChanged):

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::AccessibilityObject):
(WebCore::AccessibilityObject::lastKnownIsIgnoredValue):
(WebCore::AccessibilityObject::setLastKnownIsIgnoredValue):
(WebCore::AccessibilityObject::notifyIfIgnoredValueChanged):

accessibility/AccessibilityObject.h:

(AccessibilityObject):

10:34 AM Changeset in webkit [142367] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[Text Autosizing] Cleanup change: converter the pointer argument to be a reference since
non-null pointer is always expected.
https://bugs.webkit.org/show_bug.cgi?id=109079

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-09
Reviewed by Kenneth Rohde Christiansen.

Cleanup change, no need to add new tests or modify the existing ones.

rendering/TextAutosizer.cpp:

Changed parameter from a pointer to a reference in the methods below.

(WebCore::TextAutosizer::processSubtree):
(WebCore::TextAutosizer::processCluster):
(WebCore::TextAutosizer::processContainer):
(WebCore::TextAutosizer::isNarrowDescendant):
(WebCore::TextAutosizer::isWiderDescendant):
(WebCore::TextAutosizer::isAutosizingCluster):
(WebCore::TextAutosizer::clusterShouldBeAutosized):
(WebCore::TextAutosizer::measureDescendantTextWidth):

rendering/TextAutosizer.h: updated method prototypes.

10:15 AM Changeset in webkit [142366] by rafael.lobo@openbossa.org

10 edits
1 copy
5 adds in trunk/Source/WebCore

[TexMap] Separate classes per file in TextureMapperBackingStore.h
https://bugs.webkit.org/show_bug.cgi?id=109333

Reviewed by Noam Rosenthal.

TextureMapperBackingStore.h had the classes TextureMapperBackingStore,
TextureMapperTiledBackingStore, TextureMapperSurfaceBackingStore and
TextureMapperTile which was quite confusing. Now each one has its
own header and its own source file.

No new tests needed, refactoring only.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
platform/graphics/texmap/GraphicsLayerTextureMapper.h:
platform/graphics/texmap/TextureMapperBackingStore.cpp:
platform/graphics/texmap/TextureMapperBackingStore.h:
platform/graphics/texmap/TextureMapperSurfaceBackingStore.cpp: Added.

(WebCore):
(WebCore::TextureMapperSurfaceBackingStore::setGraphicsSurface):
(WebCore::TextureMapperSurfaceBackingStore::swapBuffersIfNeeded):
(WebCore::TextureMapperSurfaceBackingStore::texture):
(WebCore::TextureMapperSurfaceBackingStore::paintToTextureMapper):

platform/graphics/texmap/TextureMapperSurfaceBackingStore.h: Added.

(WebCore):
(TextureMapperSurfaceBackingStore):
(WebCore::TextureMapperSurfaceBackingStore::create):
(WebCore::TextureMapperSurfaceBackingStore::~TextureMapperSurfaceBackingStore):
(WebCore::TextureMapperSurfaceBackingStore::TextureMapperSurfaceBackingStore):

platform/graphics/texmap/TextureMapperTile.cpp: Added.

(WebCore):
(WebCore::TextureMapperTile::updateContents):
(WebCore::TextureMapperTile::paint):

platform/graphics/texmap/TextureMapperTile.h: Added.

(WebCore):
(TextureMapperTile):
(WebCore::TextureMapperTile::texture):
(WebCore::TextureMapperTile::rect):
(WebCore::TextureMapperTile::setTexture):
(WebCore::TextureMapperTile::setRect):
(WebCore::TextureMapperTile::~TextureMapperTile):
(WebCore::TextureMapperTile::TextureMapperTile):

platform/graphics/texmap/TextureMapperTiledBackingStore.cpp: Copied from Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp.

(WebCore):
(WebCore::TextureMapperTiledBackingStore::TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):
(WebCore::TextureMapperTiledBackingStore::adjustedTransformForRect):
(WebCore::TextureMapperTiledBackingStore::paintToTextureMapper):
(WebCore::TextureMapperTiledBackingStore::drawBorder):
(WebCore::TextureMapperTiledBackingStore::drawRepaintCounter):
(WebCore::TextureMapperTiledBackingStore::createOrDestroyTilesIfNeeded):
(WebCore::TextureMapperTiledBackingStore::updateContents):
(WebCore::TextureMapperTiledBackingStore::texture):

platform/graphics/texmap/TextureMapperTiledBackingStore.h: Added.

(WebCore):
(TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::create):
(WebCore::TextureMapperTiledBackingStore::~TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::setContentsToImage):
(WebCore::TextureMapperTiledBackingStore::rect):

platform/graphics/texmap/coordinated/CoordinatedBackingStore.h:
platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

10:02 AM Changeset in webkit [142365] by pdr@google.com

3 edits
2 adds in trunk

Sanitize m_keyTimes for paced value animations
https://bugs.webkit.org/show_bug.cgi?id=108828

Reviewed by Dirk Schulze.

Source/WebCore:

SVG animations with calcMode=paced calculate new m_keyTimes in
SVGAnimationElement::calculateKeyTimesForCalcModePaced() because paced animations do not
specify keyTimes. If an error occurs while calculating m_keyTimes, and there exists
user-specified values, a crash could occur because the user-specified values were not
sanitized.

This change clears user-specified keyTimes before calculating new ones.

Test: svg/animations/animate-keytimes-crash.html

svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::calculateKeyTimesForCalcModePaced):

LayoutTests:

svg/animations/animate-keytimes-crash-expected.html: Added.
svg/animations/animate-keytimes-crash.html: Added.

9:54 AM Changeset in webkit [142364] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Set mouse document position for mouse event in updateCursor.
https://bugs.webkit.org/show_bug.cgi?id=109094.

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-02-09
Reviewed by Rob Buis.

RIM PR 246976
Internally Reviewed by Genevieve Mak.

BlackBerry::Platform::MouseEvent have document viewport and document
content position as members. When we create the event, we should initial
them as well.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::updateCursor):

9:52 AM Changeset in webkit [142363] by eric@webkit.org

6 edits in trunk/Source/WebCore

Fix TextDocumentParser to play nice with threading
https://bugs.webkit.org/show_bug.cgi?id=109240

Reviewed by Adam Barth.

Before the HTML5 parser re-write the text document parser
was completely custom. With the HTML5 parser, we just made
the TextDocumentParser use the HTMLDocumentParser with an
artificial script tag.

However, our solution was slightly over-engineered to avoid
lying about the column numbers of the first line of the text document
during parsing. :)

This change makes us use a simpler (and threading-compatible)
solution by just inserting a real "<pre>" tag into the
input stream instead of hacking one together with the treebuilder
and manually setting the Tokenizer state.

fast/parser/empty-text-resource.html covers this case.

html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::TextDocumentParser):
(WebCore::TextDocumentParser::insertFakePreElement):

9:28 AM Changeset in webkit [142362] by schenney@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to last-known good revision. Really this time.

DEPS: 181594

9:21 AM Changeset in webkit [142361] by schenney@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to last-known good revision.
Requested by "Stephen Chenney" <schenney@chromium.org> via
sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-09

DEPS:

9:05 AM Changeset in webkit [142360] by schenney@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Trying to turn the build.webkit.org builders greener

Unreviewed expectations.

We seem to have an issue with build.webkit.org test bots and
Chromium.WebKit test bots doing different things. This is temporary
until we figure out what went wrong.

platform/chromium/TestExpectations: Re-adding all the changes due to Skia flags.

7:37 AM Changeset in webkit [142359] by tkent@chromium.org

3 edits in trunk/Source/WebCore

Add missing copyright header
https://bugs.webkit.org/show_bug.cgi?id=107507

Resources/pagepopups/chromium/calendarPickerChromium.css:
Resources/pagepopups/chromium/pickerCommonChromium.css:

7:25 AM Changeset in webkit [142358] by tkent@chromium.org

3 edits
2 adds in trunk

Fix crash by img[ismap] with content property
https://bugs.webkit.org/show_bug.cgi?id=108702

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/dom/HTMLAnchorElement/anchor-ismap-crash.html

html/HTMLAnchorElement.cpp:

(WebCore::appendServerMapMousePosition):
Check if the renderer of an img element is RenderImage.

LayoutTests:

fast/dom/HTMLAnchorElement/anchor-ismap-crash-expected.txt: Added.
fast/dom/HTMLAnchorElement/anchor-ismap-crash.html: Added.

7:16 AM Changeset in webkit [142357] by tkent@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Test expectation update.

platform/chromium/TestExpectations:

Correct encrypted-media-v2-*.html expectation.

7:14 AM Changeset in webkit [142356] by mkwst@chromium.org

5 edits in trunk/Source/WebCore

Drop ExceptionCode from IDB's directionToString and modeToString.
https://bugs.webkit.org/show_bug.cgi?id=109143

Reviewed by Jochen Eisinger.

No caller of either IDBCursor::directionToString or
IDBTransaction::modeToString makes use of the ExceptionCode these
methods require. This patch removes the 'ExceptionCode&' parameter from
both methods and their callsites.

Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::direction):
(WebCore::IDBCursor::directionToString):

Drop the 'ExceptionCode&' parameter, and replace the 'TypeError'
exception previously generated with ASSERT_NOT_REACHED.

Modules/indexeddb/IDBCursor.h:
Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::mode):
(WebCore::IDBTransaction::modeToString):

Drop the 'ExceptionCode&' parameter, and replace the 'TypeError'
exception previously generated with ASSERT_NOT_REACHED.

Modules/indexeddb/IDBTransaction.h:

7:10 AM Changeset in webkit [142355] by commit-queue@webkit.org

12 edits
1 copy
1 add
2 deletes in trunk

[EFL][Qt][WebGL] Share the common code between GraphicsSurfaceGLX and X11WindowResources.
https://bugs.webkit.org/show_bug.cgi?id=106666

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-09
Reviewed by Kenneth Rohde Christiansen.

Covered by existing WebGL tests.

This patch removes any duplicate code in X11WindowResources and
GraphicsSurfaceGLX. No new functionality is added.

PlatformEfl.cmake:
Target.pri:
platform/graphics/surfaces/egl/EGLConfigSelector.cpp:

(WebCore::EGLConfigSelector::pixmapContextConfig):

platform/graphics/surfaces/egl/EGLConfigSelector.h:

(EGLConfigSelector):

platform/graphics/surfaces/egl/EGLSurface.cpp:

(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
(WebCore::EGLWindowTransportSurface::destroy):
(WebCore::EGLWindowTransportSurface::setGeometry):

platform/graphics/surfaces/egl/EGLSurface.h:

(WebCore):
(EGLWindowTransportSurface):

platform/graphics/surfaces/glx/GLXConfigSelector.h:

(WebCore::GLXConfigSelector::GLXConfigSelector):
(WebCore::GLXConfigSelector::visualInfo):
(WebCore::GLXConfigSelector::pBufferContextConfig):
(WebCore::GLXConfigSelector::createSurfaceConfig):
(GLXConfigSelector):

platform/graphics/surfaces/glx/GLXContext.cpp:

(WebCore::initializeARBExtensions):
(WebCore::GLXOffScreenContext::GLXOffScreenContext):
(WebCore::GLXOffScreenContext::initialize):
(WebCore::GLXOffScreenContext::platformReleaseCurrent):
(WebCore::GLXOffScreenContext::freeResources):

platform/graphics/surfaces/glx/GLXContext.h:

(GLXOffScreenContext):

platform/graphics/surfaces/glx/GLXSurface.cpp:

(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurface::setGeometry):
(WebCore::GLXTransportSurface::destroy):
(WebCore::GLXPBuffer::initialize):

platform/graphics/surfaces/glx/GLXSurface.h:

(GLXTransportSurface):
(GLXPBuffer):

platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:

(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::initialize):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::createPixmap):
(WebCore::GraphicsSurfacePrivate::display):
(WebCore::GraphicsSurfacePrivate::flags):
(WebCore::GraphicsSurfacePrivate::clear):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
No new functionality added. Made changes to take the common code into use.

platform/graphics/surfaces/glx/X11WindowResources.h: Removed.
platform/graphics/surfaces/glx/X11Helper.cpp: Renamed from Source/WebCore/platform/graphics/surfaces/glx/X11WindowResources.cpp.

(WebCore):
(WebCore::DisplayConnection::DisplayConnection):
(DisplayConnection):
(WebCore::DisplayConnection::~DisplayConnection):
(WebCore::DisplayConnection::display):
(OffScreenRootWindow):
(WebCore::OffScreenRootWindow::OffScreenRootWindow):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::OffScreenRootWindow::rootWindow):
(WebCore::X11Helper::resizeWindow):
(WebCore::X11Helper::createOffScreenWindow):
(WebCore::X11Helper::destroyWindow):
(WebCore::X11Helper::isXRenderExtensionSupported):
(WebCore::X11Helper::nativeDisplay):
(WebCore::X11Helper::offscreenRootWindow):

platform/graphics/surfaces/glx/X11Helper.h: Added.

(WebCore):
(WebCore::handleXPixmapCreationError):
(X11Helper):
(ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::~ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::isValidOperation):
Moved common code from GraphicsSurfaceGLX to X11Helper.

6:58 AM Changeset in webkit [142354] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk/TestExpectations: Adding a failure expectation for the test introduced in r142335.

6:31 AM Changeset in webkit [142353] by Christophe Dumez

4 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline fast/text/international/bidi-ignored-for-first-child-inline.html
after r142152.

platform/efl/TestExpectations:
platform/efl/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
platform/efl/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:

3:51 AM Changeset in webkit [142352] by Philippe Normand

2 edits in trunk

Unreviewed, another GTK+ build fix after r142343.

Source/autotools/symbols.filter: Expose the InlineBox delete operator.

1:58 AM Changeset in webkit [142351] by commit-queue@webkit.org

7 edits
2 adds in trunk

Web Inspector: show whitespace characters in DTE
https://bugs.webkit.org/show_bug.cgi?id=108947

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-09
Reviewed by Pavel Feldman.

Source/WebCore:

New test: inspector/editor/text-editor-show-whitespaces.html

Split consecutive whitespace characters into groups of 16, 8, 4, 2 and 1 and
add ::before pseudoclass for this groups which contains necessary
amount of "dots" (u+00b7). Add a setting "Show whitespace" for this
option in "Sources" section of "General" tab.

English.lproj/localizedStrings.js:
inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype.wasShown):
(WebInspector.TextEditorMainPanel.prototype.willHide):
(WebInspector.TextEditorMainPanel.prototype._renderRanges):
(WebInspector.TextEditorMainPanel.prototype._renderWhitespaceCharsWithFixedSizeSpans):
(WebInspector.TextEditorMainPanel.prototype._paintLine):

inspector/front-end/Settings.js:
inspector/front-end/SettingsScreen.js:

(WebInspector.GenericSettingsTab):

inspector/front-end/inspectorSyntaxHighlight.css:

(.webkit-whitespace-1::before):
(.webkit-whitespace-2::before):
(.webkit-whitespace-4::before):
(.webkit-whitespace-8::before):
(.webkit-whitespace-16::before):
(.webkit-whitespace::before):

LayoutTests:

Add layout test to verify whitespace highlight functionality.

inspector/editor/text-editor-show-whitespace-expected.txt: Added.
inspector/editor/text-editor-show-whitespace.html: Added.

Feb 8, 2013:

10:13 PM Changeset in webkit [142350] by weinig@apple.com

2 edits in trunk/Source/WebKit2

Fix ASSERT when the Web Content Process crashes
https://bugs.webkit.org/show_bug.cgi?id=109346

Reviewed by Simon Fraser.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidCrash):
We need to remove ourselves as a message receiver before calling out to the client, as
the client might want to re-add us (as Safari does).

9:52 PM Changeset in webkit [142349] by eric.carlson@apple.com

16 edits
2 adds in trunk

[Mac] respect in-band caption color
https://bugs.webkit.org/show_bug.cgi?id=109203

Reviewed by Dean Jackson.

Source/WebCore:

Test: media/track/track-in-band-style.html

WebCore.xcodeproj/project.pbxproj: Add HTMLDivElement.h to private headers because it is

included by HTMLTextElement, which is included by HTMLMediaElement.h, which is included
by files in WebKit/WebKit2.

html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::addGenericCue): Set cue colors if necessary.

html/track/TextTrackCue.h:

(WebCore::TextTrackCue::element): New, accessor for the cue element so it can be styled.

html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties): Set container and cue background

color if necessary.

(WebCore::TextTrackCueGeneric::operator==): Compare cue colors.

html/track/TextTrackCueGeneric.h:

(WebCore::TextTrackCueGeneric::foregroundColor): Add color accessors.
(WebCore::TextTrackCueGeneric::setForegroundColor):
(WebCore::TextTrackCueGeneric::backgroundColor):
(WebCore::TextTrackCueGeneric::setBackgroundColor):

page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::registerForCaptionPreferencesChangedCallbacks): Always

regenerate override CSS when an element registers for callbacks.

(WebCore::CaptionUserPreferencesMac::captionsWindowCSS): Drive by fix of "window color" padding.
(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Log the stylesheet generated

for easier debugging.

platform/graphics/InbandTextTrackPrivateClient.h:

(WebCore::GenericCueData::foregroundColor): Add color getters/setters.
(WebCore::GenericCueData::setForegroundColor):
(WebCore::GenericCueData::backgroundColor):
(WebCore::GenericCueData::setBackgroundColor):

platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::makeRGBA32FromARGBCFArray): Initialize a RGBA32 from a CFArray of color values.
(WebCore::InbandTextTrackPrivateAVF::processCueAttributes): Process cue colors.

LayoutTests:

media/track/track-in-band-style-expected.txt: Added.
media/track/track-in-band-style.html: Added.

platform/chromium/TestExpectations: Skip new test.
platform/efl/TestExpectations: Ditto.
platform/gtk/TestExpectations: Ditto.
platform/mac/TestExpectations: Ditto.
platform/qt/TestExpectations: Ditto.
platform/win/TestExpectations: Ditto.

9:17 PM Changeset in webkit [142348] by benjamin@webkit.org

49 edits
1 delete in trunk

Move workerThreadCount from TestRunner to WebCore Internals
https://bugs.webkit.org/show_bug.cgi?id=109239

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-08
Reviewed by Darin Adler.

Source/autotools/symbols.filter:

Source/WebCore:

Add the new read-only property workerThreadCount.

testing/Internals.cpp:

(WebCore::Internals::workerThreadCount):
(WebCore):

testing/Internals.h:

(Internals):

testing/Internals.idl:

Source/WebKit:

WebKit.xcodeproj/project.pbxproj:

Source/WebKit/efl:

WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Get rid of WebWorkersPrivate, which was only needed for DRT.

WebKit.exp:
Workers/WebWorkersPrivate.h: Removed.
Workers/WebWorkersPrivate.mm: Removed.

Source/WebKit/qt:

WebCoreSupport/DumpRenderTreeSupportQt.cpp:
WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

WebKit.vcproj/WebKitExports.def.in:

Source/WebKit2:

WebProcess/InjectedBundle/API/c/WKBundle.cpp:
WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:
WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

WebProcess/WebPage/WebFrame.cpp: Remove a useless #include.

Tools:

DumpRenderTree/TestRunner.cpp:

(TestRunner::staticValues):

DumpRenderTree/TestRunner.h:

(TestRunner):

DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):

DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

DumpRenderTree/efl/TestRunnerEfl.cpp:
DumpRenderTree/gtk/TestRunnerGtk.cpp:
DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::webHistoryItemCount):

DumpRenderTree/qt/TestRunnerQt.cpp:
DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

DumpRenderTree/win/TestRunnerWin.cpp:
DumpRenderTree/wx/TestRunnerWx.cpp:
WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:
WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

Update the tests testRunner->internals.

fast/workers/resources/dedicated-worker-lifecycle.js:

(runTests.worker.onmessage):
(runTests):
(orphanedWorkerExited.worker.onmessage):
(orphanedWorkerExited):

fast/workers/resources/worker-lifecycle.js:

(runTests.worker.onmessage):
(runTests):

fast/workers/resources/worker-util.js:

(.return):
(waitUntilThreadCountMatches):

fast/workers/worker-close-more.html:
http/tests/workers/resources/worker-util.js:

(.return):
(waitUntilThreadCountMatches):

8:21 PM Changeset in webkit [142347] by dino@apple.com

5 edits in trunk

Remove use of plugInStartLabelImage
https://bugs.webkit.org/show_bug.cgi?id=108273

Reviewed by Simon Fraser.

Source/WebKit2:

Remove any use of plugInStartLabelImage. While there, implement plugInStartLabelTitle
and plugInStartLabelSubtitle to return the values from the client.
implement them.

WebProcess/InjectedBundle/API/c/WKBundlePage.h: Remove callback and entry from client structure.
WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: Remove plugInStartLabelImage.

(WebKit::InjectedBundlePageUIClient::plugInStartLabelTitle): Ask the client bundle for value.
(WebKit::InjectedBundlePageUIClient::plugInStartLabelSubtitle): Ditto.

Tools:

Removed plugInStartLabelImage entry from client structure.

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

8:04 PM Changeset in webkit [142346] by dino@apple.com

2 edits in trunk

Only a fool would cut and paste from a terminal showing truncated git logs.
I am that fool.

Export the full symbol for InlineBox::nodeAtPoint.

Source/autotools/symbols.filter:

7:58 PM Changeset in webkit [142345] by dino@apple.com

2 edits in trunk

Snapshotted plug-in should use shadow root
https://bugs.webkit.org/show_bug.cgi?id=108284

Unreviewed GTK+ build fix.

Source/autotools/symbols.filter: Export InlineBox symbols.

7:42 PM Changeset in webkit [142344] by timothy@apple.com

2 edits in trunk/Tools

Fix the WebInspectorAPI watch list.

Reviewed by Joseph Pecoraro.

Scripts/webkitpy/common/config/watchlist: Fix the regrexs.

Added InjectedScriptSource.js and Console.idl.

7:29 PM Changeset in webkit [142343] by dino@apple.com

21 edits in trunk/Source

Source/WebCore: Snapshotted plug-in should use shadow root
https://bugs.webkit.org/show_bug.cgi?id=108284

Reviewed by Simon Fraser.

Take two! This time with updated exports file.

The UA stylesheet for plug-ins provides a default styling for the label, which
can be overridden by ports.

Unfortunately this is difficult to test, because the snapshotting requires
time to execute, and also a PluginView to be instantiated.

WebCore.exp.in: Export the InlineBox interface.

css/plugIns.css:

(object::-webkit-snapshotted-plugin-content): New rules for a default label style.

platform/LocalizedStrings.cpp: Make sure all ports have plugin strings, now it is called.
platform/LocalizedStrings.h:
platform/blackberry/LocalizedStringsBlackBerry.cpp:
platform/chromium/LocalizedStringsChromium.cpp:
platform/efl/LocalizedStringsEfl.cpp:
platform/gtk/LocalizedStringsGtk.cpp:
platform/qt/LocalizedStringsQt.cpp:

html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler): Take into account the fact
that RenderSnapshottedPlugIn no longer is an embedded object.

html/HTMLPlugInImageElement.cpp:

a renderer, otherwise use the typical plug-in path.

(WebCore::HTMLPlugInImageElement::updateSnapshot): Keep a record of the snapshot, since we'll

need to give it to the renderer.

(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Build a subtree that will display a label.

html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement): New member variable to record the snapshot image and whether the label

should show immediately.

(WebCore::HTMLPlugInImageElement::swapRendererTimerFired): The callback function triggered when we need

to swap to the Shadow Root.

(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): The user has tapped on the snapshot so the plugin

in being recreated. Make sure we reattach so that a plugin renderer will be created.

(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Make sure we set the right

displayState for snapshots.

html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement): The new methods listed above.
(WebCore::HTMLPlugInImageElement::setShouldShowSnapshotLabelAutomatically): Indicates whether or not

a snapshot should be immediately labeled.

page/ChromeClient.h: No need for plugInStartLabelImage any more.

rendering/RenderSnapshottedPlugIn.cpp:

rendering/RenderSnapshottedPlugIn.h:

(RenderSnapshottedPlugIn): New inheritance. Some method renaming.

Source/WebKit2:

WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:

(InjectedBundlePageUIClient):

WebProcess/WebCoreSupport/WebChromeClient.cpp:
WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

7:08 PM Changeset in webkit [142342] by Gregg Tavares

2 edits in trunk/LayoutTests

Disable All WebGL Tests on WebKit for Windows
https://bugs.webkit.org/show_bug.cgi?id=109207

Unreviewed expectations update.

platform/win/TestExpectations:

6:42 PM Changeset in webkit [142341] by dino@apple.com

20 edits in trunk/Source

Rolling out r142333 and r142337 which broke Mac Release builds.

6:40 PM Changeset in webkit [142340] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r142337.
http://trac.webkit.org/changeset/142337
https://bugs.webkit.org/show_bug.cgi?id=109339

Breaking Mac release builds (Requested by dino_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-08

rendering/RenderSnapshottedPlugIn.h:

6:34 PM Changeset in webkit [142339] by andersca@apple.com

9 edits in trunk/Source/WebKit2

Move plug-in enumeration back to the main thread
https://bugs.webkit.org/show_bug.cgi?id=109337
<rdar://problem/12015046>

Reviewed by Andreas Kling.

Plug-in enumeration was moved to a separate work queue to improve responsiveness, but
doing so lead to crashes when WebKit1 would enumerate plug-ins on the main thread at the same time.
Bug <rdar://problem/13185819> tracks fixing the responsiveness issue by spawning a plug-in process
and have it do the enumeration.

Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::getPluginInfoFromCarbonResources):

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::connectionWillOpen):
(WebKit::WebProcessProxy::connectionWillClose):
(WebKit::WebProcessProxy::getPlugins):

UIProcess/WebProcessProxy.h:

(WebCore):
(WebProcessProxy):

UIProcess/WebProcessProxy.messages.in:
WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit):
(WebKit::WebPlatformStrategies::populatePluginCache):

WebProcess/WebProcess.cpp:
WebProcess/WebProcess.h:

(WebProcess):

WebProcess/WebProcess.messages.in:

6:20 PM Changeset in webkit [142338] by timothy_horton@apple.com

7 edits in trunk/LayoutTests

Some tiled drawing tests use scalePageBy() incorrectly
https://bugs.webkit.org/show_bug.cgi?id=109336

Rubber-stamped by Simon Fraser.

scalePageBy takes (scale, x, y). Some of the tiled drawing tests are incorrectly handing them (scale, scale).
Adjust the tests and the expected results.

platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed.html:
platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed-expected.txt:
platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed.html:
platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled.html:
platform/mac-wk2/tiled-drawing/tiled-drawing-zoom.html:

6:07 PM Changeset in webkit [142337] by dino@apple.com

2 edits in trunk/Source/WebCore

Attempted Mac and GTK build fix after r142333.

rendering/RenderSnapshottedPlugIn.h: Include InlineBox.h.

5:58 PM Changeset in webkit [142336] by msaboff@apple.com

2 edits in trunk/Source/WTF

ARM_NEON Inline Assembly for copyLCharsFromUCharSource() inefficient for aligned destinations
https://bugs.webkit.org/show_bug.cgi?id=109335

Reviewed by Filip Pizlo.

Change a "do while" to a "while" so that we don't copy single characters to align the
destination when it is already aligned.

wtf/text/ASCIIFastPath.h:

(WTF::copyLCharsFromUCharSource):

5:48 PM Changeset in webkit [142335] by aestes@apple.com

4 edits
2 adds
2 deletes in trunk

Restore pre-r118852 behavior for EllipsisBox::nodeAtPoint()
https://bugs.webkit.org/show_bug.cgi?id=109277

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/flexbox/line-clamp-link-after-ellipsis.html

Roll out r118852. Enough time has passed that this can't be done
mechanically, so transcribe the old method definition to current
WebCore interfaces.

rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::markupBox): EllipsisBox no longer has
m_markupBox, so break the logic for finding the markup box from
paintMarkupBox() into its own function.
(WebCore::EllipsisBox::paintMarkupBox): Call markupBox().
(WebCore::EllipsisBox::nodeAtPoint): Transcribe the pre-r118852 implementation.

rendering/EllipsisBox.h:

(EllipsisBox): Declare markupBox().

LayoutTests:

Remove test added by r118852 and add a test that verifies the original
expected behavior.

fast/css/text-overflow-ellipsis-hit-test-expected.txt: Removed.
fast/css/text-overflow-ellipsis-hit-test.html: Removed.
fast/flexbox/line-clamp-link-after-ellipsis-expected.txt: Added.
fast/flexbox/line-clamp-link-after-ellipsis.html: Added.

5:32 PM Changeset in webkit [142334] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

[Mac] In-band closed caption tracks are not always initialized correctly
https://bugs.webkit.org/show_bug.cgi?id=109323

Reviewed by Dean Jackson.

No new tests, makes existing tests less flakey.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Create and configure legible output

here instad of in tracksChanged.

(WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible): Do nothing in a build with

in-band track support.

(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Move legible output creation to

createAVPlayerItem, don't set look at track media type to see if the movie has captions
when we have support for in-band captions.

5:24 PM Changeset in webkit [142333] by dino@apple.com

20 edits in trunk/Source

Snapshotted plug-in should use shadow root
https://bugs.webkit.org/show_bug.cgi?id=108284

Reviewed by Simon Fraser.

Source/WebCore:

The UA stylesheet for plug-ins provides a default styling for the label, which
can be overridden by ports.

Unfortunately this is difficult to test, because the snapshotting requires
time to execute, and also a PluginView to be instantiated.

css/plugIns.css:

(object::-webkit-snapshotted-plugin-content): New rules for a default label style.

platform/LocalizedStrings.cpp: Make sure all ports have plugin strings, now it is called.
platform/LocalizedStrings.h:
platform/blackberry/LocalizedStringsBlackBerry.cpp:
platform/chromium/LocalizedStringsChromium.cpp:
platform/efl/LocalizedStringsEfl.cpp:
platform/gtk/LocalizedStringsGtk.cpp:
platform/qt/LocalizedStringsQt.cpp:

html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler): Take into account the fact
that RenderSnapshottedPlugIn no longer is an embedded object.

html/HTMLPlugInImageElement.cpp:

a renderer, otherwise use the typical plug-in path.

(WebCore::HTMLPlugInImageElement::updateSnapshot): Keep a record of the snapshot, since we'll

need to give it to the renderer.

(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Build a subtree that will display a label.

html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement): New member variable to record the snapshot image and whether the label

should show immediately.

(WebCore::HTMLPlugInImageElement::swapRendererTimerFired): The callback function triggered when we need

to swap to the Shadow Root.

(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): The user has tapped on the snapshot so the plugin

in being recreated. Make sure we reattach so that a plugin renderer will be created.

(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Make sure we set the right

displayState for snapshots.

html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement): The new methods listed above.
(WebCore::HTMLPlugInImageElement::setShouldShowSnapshotLabelAutomatically): Indicates whether or not

a snapshot should be immediately labeled.

page/ChromeClient.h: No need for plugInStartLabelImage any more.

rendering/RenderSnapshottedPlugIn.cpp:

rendering/RenderSnapshottedPlugIn.h:

(RenderSnapshottedPlugIn): New inheritance. Some method renaming.

Source/WebKit2:

We no longer have any need for plugInStartLabelImage.

WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: Remove plugInStartLabelImage.
WebProcess/InjectedBundle/InjectedBundlePageUIClient.h: Ditto.
WebProcess/WebCoreSupport/WebChromeClient.cpp: Ditto.
WebProcess/WebCoreSupport/WebChromeClient.h: Ditto.

4:45 PM Changeset in webkit [142332] by schenney@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Expectation modification after r142327

Unreviewed expectations update.

The test from "Bring WebKit up to speed with latest Encrypted Media spec" is slow.

platform/chromium/TestExpectations:

4:41 PM Changeset in webkit [142331] by schenney@chromium.org

1 edit
2 adds
2 deletes in trunk/LayoutTests

[Chromium] Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

A remaining textual fix.

editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
platform/chromium-mac/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.

4:28 PM Changeset in webkit [142330] by jpfau@apple.com

2 edits
1 delete in trunk/LayoutTests

[Mac] Unreviewed rebaseline

platform/mac-lion/compositing/visible-rect/iframe-no-layers-expected.txt: Removed.
platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:

4:20 PM Changeset in webkit [142329] by haraken@chromium.org

7 edits in trunk/Source/WebCore

{FocusIn,FocusOut,Focus,Blur}EventDispatchMediator should be in FocusEvent.cpp
https://bugs.webkit.org/show_bug.cgi?id=109265

Reviewed by Dimitri Glazkov.

Conventionally we put XXXEventDispatchMediator to XXXEvent.cpp.
We should move {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator to FocusEvent.cpp.

No tests. No change in behavior.

dom/EventDispatchMediator.cpp:
dom/EventDispatchMediator.h:
dom/FocusEvent.cpp:

(WebCore::FocusEventDispatchMediator::create):
(WebCore):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::create):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):

dom/FocusEvent.h:

(WebCore):
(FocusEventDispatchMediator):
(BlurEventDispatchMediator):
(FocusInEventDispatchMediator):
(FocusOutEventDispatchMediator):

dom/UIEvent.cpp:
dom/UIEvent.h:

4:13 PM Changeset in webkit [142328] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

Unreviewed build fix. MSVC (and other compilers) need a default: case in switch statement.

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::notificationName):

3:31 PM Changeset in webkit [142327] by jer.noble@apple.com

30 edits
8 copies
16 adds in trunk

Bring WebKit up to speed with latest Encrypted Media spec.
https://bugs.webkit.org/show_bug.cgi?id=97037

Reviewed by Eric Carlson.

Source/JavaScriptCore:

Define the ENABLE_ENCRYPTED_MEDIA_V2 setting.

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

The most recent version of the Encrypted Media Extensions spec breaks functionality out of the
HTMLMediaElement and into new MediaKeys and MediaKeySession classes. Since the CDM functionality
has been pulled out of the media element, we create a proxy CDM class and factory system for
creating specific CDM key system implementations. The spec also breaks out MediaKeyEvent
into distinct event classes, MediaKeyNeededEvent and MediaKeyMessageEvent, for needkey and
keymessage events, respectively.

Tests: media/encrypted-media/encrypted-media-v2-events.html

media/encrypted-media/encrypted-media-v2-syntax.html

CDM is a proxy class (a la MediaPlayer) for a specific CDMPrivateInterface implementation. A CDM
implementation is registered with the CDMFactory and will be created if that implementation supports
the key system passed into the MediaKeys constructor. CDMSession is a pure-virtual interface exposed
by concrete CDMPrivate subclasses. Its lifetime is owned by MediaKeySession.

Modules/encryptedmedia/CDM.cpp: Added.

(WebCore::installedCDMFactories): Initialize all the known CDM subtypes. Ports will add CDM implementations here.
(WebCore::CDM::registerCDMFactory): Registers a new CDMFactory using the passed in function pointers.
(WebCore::CDMFactoryForKeySystem): Return the first CDM factory which supports the requested key system.
(WebCore::CDM::supportsKeySystem): Walk the installed CDMs and ask if the given key system is supported.
(WebCore::CDM::supportsKeySystemMIMETypeAndCodec): Ditto, with an additional MIME type and codec string.
(WebCore::CDM::create): Simple constructor wrapper.
(WebCore::CDM::CDM): Simple constructor; calls bestCDMForKeySystem() to create it's private implementation.
(WebCore::CDM::~CDM): Simple destructor.
(WebCore::CDM::createSession): Creates a new CDMSession.

Modules/encryptedmedia/CDM.h: Added.

(WebCore::CDM::keySystem): Simple accessor for m_keySystem.
(WebCore::CDMSession::CDMSession): Simple constructor.
(WebCore::CDMSession::~CDMSession): Simple destructor.

Modules/encryptedmedia/CDMPrivate.h: Added.

(WebCore::CDMPrivateInterface::CDMPrivateInterface): Simple constructor.
(WebCore::CDMPrivateInterface::~CDMPrivateInterface): Simple destructor.

The new classes, MediaKeyMessageEvent and MediaKeyNeededEvent, take distinct subsets of the initializers of
the original MediaKeyMessageEvent.

Modules/encryptedmedia/MediaKeyMessageEvent.cpp: Copied from Source/WebCore/html/MediaKeyEvent.cpp.

(WebCore::MediaKeyMessageEventInit::MediaKeyMessageEventInit): Initializer now only takes message and destinationURL

parameters.

(WebCore::MediaKeyMessageEvent::MediaKeyMessageEvent): Simple constructor.
(WebCore::MediaKeyMessageEvent::~MediaKeyMessageEvent): Simple destructor.
(WebCore::MediaKeyMessageEvent::interfaceName): Standard interfaceName.

Modules/encryptedmedia/MediaKeyMessageEvent.h: Copied from Source/WebCore/html/MediaKeyEvent.h.

(WebCore::MediaKeyMessageEvent::create): Simple construction wrapper.
(WebCore::MediaKeyMessageEvent::message): Simple accessor for m_message.
(WebCore::MediaKeyMessageEvent::destinationURL): Simple accessor for m_destinationURL.

Modules/encryptedmedia/MediaKeyMessageEvent.idl: Copied from Source/WebCore/html/MediaKeyEvent.idl.
Modules/encryptedmedia/MediaKeyNeededEvent.cpp: Copied from Source/WebCore/html/MediaKeyEvent.h.

(WebCore::MediaKeyNeededEventInit::MediaKeyNeededEventInit): Initializer now only takes initData parameter.
(WebCore::MediaKeyNeededEvent::MediaKeyNeededEvent): Simple constructor.
(WebCore::MediaKeyNeededEvent::~MediaKeyNeededEvent): Simple destructor.
(WebCore::MediaKeyNeededEvent::interfaceName): Standard interfaceName.

Modules/encryptedmedia/MediaKeyNeededEvent.h: Copied from Source/WebCore/html/MediaKeyEvent.h.

(WebCore::MediaKeyNeededEvent::create): Simple construction wrapper.
(WebCore::MediaKeyNeededEvent::initData): Simple accessor for m_initData.

Modules/encryptedmedia/MediaKeyNeededEvent.idl: Copied from Source/WebCore/html/MediaKeyEvent.idl.

MediaKeySession is a new class that maps keys and key requests to a given session ID:

Modules/encryptedmedia/MediaKeySession.cpp: Added.

(WebCore::MediaKeySession::create): Simple construction wrapper.
(WebCore::MediaKeySession::MediaKeySession): Simple constructor.
(WebCore::MediaKeySession::~MediaKeySession): Simple destructor; calls close().
(WebCore::MediaKeySession::setError): Simple setter for m_error;
(WebCore::MediaKeySession::close): Tell the CDM to clear any saved session keys.
(WebCore::MediaKeySession::generateKeyRequest): Start a one-shot timer, handled in keyRequestTimerFired.
(WebCore::MediaKeySession::keyRequestTimerFired): Follow the steps in the spec; ask the CDM to generate a key request.
(WebCore::MediaKeySession::addKey): Start a one-shot timer, handled in addKeyTimerFired.
(WebCore::MediaKeySession::addKeyTimerFired): Follow the steps in the spec; provide the key data to the CDM.

Modules/encryptedmedia/MediaKeySession.h: Added.

(WebCore::MediaKeySession::keySystem): Simple accessor for m_keySystem.
(WebCore::MediaKeySession::sessionId): Simple accessor for m_sessionId.
(WebCore::MediaKeySession::error): Simple accessor for m_error;

Modules/encryptedmedia/MediaKeySession.idl:

MediaKeySession inherits from EventTarget, and must override the pure virtual functions in that class:

Modules/encryptedmedia/MediaKeySession.cpp: Added.

(WebCore::MediaKeySession::interfaceName):

Modules/encryptedmedia/MediaKeySession.h: Added.

(WebCore::MediaKeySession::refEventTarget):
(WebCore::MediaKeySession::derefEventTarget):
(WebCore::MediaKeySession::eventTargetData):
(WebCore::MediaKeySession::ensureEventTargetData):
(WebCore::MediaKeySession::scriptExecutionContext):

MediaKeys is a new class that encapsulates a CDM and a number of key sessions:

Modules/encryptedmedia/MediaKeys.cpp: Added.

(WebCore::MediaKeys::create): Throw an exception if the key system parameter is unsupported; create a CDM object

and a new MediaKeys session.

(WebCore::MediaKeys::MediaKeys): Simple constructor.
(WebCore::MediaKeys::~MediaKeys): Simple destructor.
(WebCore::MediaKeys::createSession): Follow the spec and create a new key session.

Modules/encryptedmedia/MediaKeys.h: Added.
Modules/encryptedmedia/MediaKeys.idl: Copied from Source/WebCore/html/MediaError.idl.

Provide a new interface to HTMLMediaElement for MediaPlayer which does not require a sessionId or a key system:

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::keyNeeded):

MediaKeyError now has a systemCode parameter and member variable.

html/MediaKeyError.h:

(WebCore::MediaKeyError::create): Take a systemCode parameter with a default (0) value.
(WebCore::MediaKeyError::MediaKeyError): Ditto.
(WebCore::MediaKeyError::systemCode): Simple accessor for m_systemCode.

html/MediaKeyError.idl:

Add new methods to HTMLMediaElement to support MediaKeys. Support different initializer
for the MediaKeyNeededEvent.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setMediaKeys): Simple setter for m_mediaKeys.
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded): This version takes fewer parameters

than the deprecated version.

html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::mediaKeys): Simple accessor for m_mediaKeys.

html/HTMLMediaElement.idl: Add the mediaKeys attribute.

Add an ENABLE(ENCRYPTED_MEDIA_V2) check to the existing ENABLE(ENCRYPTED_MEDIA) one:

html/MediaError.h:
html/MediaError.idl:
platform/graphics/MediaPlayer.cpp:

(WebCore::bestMediaEngineForTypeAndCodecs):
(WebCore::MediaPlayer::supportsType):

platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayer::keyNeeded): This version takes fewer parameters than the

deprecated version.

Support the new version of canPlayType which takes an extra parameter:

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::registerMediaEngine):
(WebCore::MediaPlayerPrivateAVFoundationObjC::extendedSupportsType):

platform/graphics/mac/MediaPlayerPrivateQTKit.h:
platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::registerMediaEngine):
(WebCore::MediaPlayerPrivateQTKit::extendedSupportsType):

Add a mock CDM for use within DRT and WKTR to test the MediaKeys and MediaKeySession
APIs and events:

testing/Internals.cpp:

(WebCore::Internals::initializeMockCDM): Add the MockCDM class to the CDM factories.

testing/Internals.h:
testing/Internals.idl: Add the initializeMockCDM() method.
testing/MockCDM.cpp: Added.

(WebCore::MockCDM::supportsKeySystem): Only supports the 'com.webcore.mock' key system.
(WebCore::MockCDM::supportsMIMEType): Only supports the 'video/mock' mime type.
(WebCore::initDataPrefix): Static method which returns a Uint8Array containing 'mock'.
(WebCore::keyPrefix): Static method which returns a Uint8Array containing 'key'.
(WebCore::keyRequest): Static method which returns a Uint8Array containing 'request'.
(WebCore::generateSessionId): Return a monotonically increasing number.
(WebCore::MockCDMSession::MockCDMSession): Simple constructor.
(WebCore::MockCDMSession::generateKeyRequest): Ignores the parameters and returns a keyRequest() array.
(WebCore::MockCDMSession::releaseKeys): No-op.
(WebCore::MockCDMSession::addKey): Checks that the key starts with the keyPrefix() array.

testing/MockCDM.h: Added.

(WebCore::MockCDM::create):
(WebCore::MockCDM::~MockCDM): Simple destructor.
(WebCore::MockCDM::MockCDM): Simple constructor.

Add the new classes to the built system:

Configurations/FeatureDefines.xcconfig:
DerivedSources.make:
WebCore.exp.in:
WebCore.xcodeproj/project.pbxproj:

Miscelaneous changes:

dom/EventNames.in: Add the two new event types, MediaKeyMessageEvent and MediaKeyNeededEvent.
dom/EventTargetFactory.in: Add the new EventTarget, MediaKeySession.
page/DOMWindow.idl: Add constructors for the new classes to the window object.

Source/WTF:

Define the ENABLE_ENCRYPTED_MEDIA_V2 setting.

wtf/Platform.h:

LayoutTests:

Added new tests for the updated Encrypted Media Extensions spec.

media/encrypted-media/encrypted-media-v2-events-expected.txt: Added.
media/encrypted-media/encrypted-media-v2-events.html: Added.
media/encrypted-media/encrypted-media-v2-syntax-expected.txt: Added.
media/encrypted-media/encrypted-media-v2-syntax.html: Added.
platform/Chromium/TestExpectations: Skip the new media/encrypted-media/ v2 tests.
platform/mac/media/encrypted-media/encrypted-media-can-play-type-expected.txt: Added.

3:04 PM Changeset in webkit [142326] by rakuco@webkit.org

2 edits in trunk/Source/WebKit2

[WK2] Fix the build on !Mac after r142314.
https://bugs.webkit.org/show_bug.cgi?id=109327

Reviewed by Benjamin Poulain.

WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformPreInitialize): Add a stub for
the newly-added function.

WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformPreInitialize):
(WebKit):

3:02 PM Changeset in webkit [142325] by schenney@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Why does this test always fail to be correctly rebaselined during mass updates?

platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:

2:48 PM Changeset in webkit [142324] by jsbell@chromium.org

3 edits in trunk/LayoutTests

IndexedDB: De-flake open-during-transaction layout test
https://bugs.webkit.org/show_bug.cgi?id=109072

Reviewed by Tony Chang.

This test was observed to be flaky in local runs; sometimes the transaction
would terminate after the third open() call rather than the second, resulting
in a TEXT difference. Added code to keep the transaction alive until all of
the open() calls are complete, and changed expectations to match.

storage/indexeddb/open-during-transaction-expected.txt:
storage/indexeddb/resources/open-during-transaction.js:

2:35 PM Changeset in webkit [142323] by schenney@chromium.org

11 edits
1 add
4 deletes in trunk/LayoutTests

[Chromium] Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Cleaning up the remaining failures. With luck this is it, although probably not.

platform/chromium-linux-x86/fast/backgrounds/size/contain-and-cover-expected.png: Removed.
platform/chromium-linux/fast/hidpi/video-controls-in-hidpi-expected.png:
platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
platform/chromium-linux/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
platform/chromium-linux/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
platform/chromium-linux/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
platform/chromium-mac-lion/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
platform/chromium-mac-lion/fast/backgrounds/size/contain-and-cover-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png: Removed.
platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
platform/chromium-win-xp/media/video-zoom-controls-expected.png: Removed.
platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
platform/chromium-win/media/video-zoom-controls-expected.png:

2:18 PM Changeset in webkit [142322] by schenney@chromium.org

611 edits
3 adds
1 delete in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 19. The last, except for cleanup. Too many to list.

platform/chromium/TestExpectations:

1:46 PM Changeset in webkit [142321] by schenney@chromium.org

457 edits
10 adds
14 deletes in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 18. SVG all but dynamic-updates and custom tests. List omitted
except for changes touching other ports.

platform/chromium/TestExpectations:
platform/efl-wk2/svg/css/circle-in-mask-with-shadow-expected.png: Added.
platform/efl-wk2/svg/css/group-with-shadow-expected.png: Added.
platform/efl-wk2/svg/css/text-gradient-shadow-expected.png: Added.
platform/efl/svg/batik/text/textEffect-expected.png: Removed.
platform/efl/svg/batik/text/textEffect2-expected.png: Removed.
platform/efl/svg/batik/text/textProperties2-expected.png: Removed.
platform/efl/svg/css/circle-in-mask-with-shadow-expected.png: Removed.
platform/efl/svg/css/group-with-shadow-expected.png: Removed.
platform/efl/svg/css/text-gradient-shadow-expected.png: Removed.
platform/mac/svg/batik/text/textPosition2-expected.txt: Removed.
platform/win-future/svg/batik/text/textPosition2-expected.txt: Added.
svg/batik/text/textPosition2-expected.txt: Replaced.

1:45 PM Changeset in webkit [142320] by Chris Fleizach

9 edits
8 copies
1 move in trunk/Source/WebCore

Refactor platform-specific code in SpeechSynthesis
https://bugs.webkit.org/show_bug.cgi?id=107414

Reviewed by Sam Weinig.

Refactor WebSpeech code to use a platform mechanism to provide access to platform resources.

Modules/speech/DOMWindowSpeechSynthesis.cpp:

(WebCore::DOMWindowSpeechSynthesis::from):

Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::SpeechSynthesis):
(WebCore):
(WebCore::SpeechSynthesis::voicesDidChange):
(WebCore::SpeechSynthesis::getVoices):
(WebCore::SpeechSynthesis::pending):
(WebCore::SpeechSynthesis::speaking):
(WebCore::SpeechSynthesis::paused):
(WebCore::SpeechSynthesis::speak):
(WebCore::SpeechSynthesis::cancel):
(WebCore::SpeechSynthesis::pause):
(WebCore::SpeechSynthesis::resume):

Modules/speech/SpeechSynthesis.h:

(WebCore):
(SpeechSynthesis):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didFinishSpeaking):
(WebCore::SpeechSynthesis::speakingErrorOccurred):

Modules/speech/SpeechSynthesisUtterance.cpp:

(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):

Modules/speech/SpeechSynthesisUtterance.h:

(WebCore::SpeechSynthesisUtterance::text):
(WebCore::SpeechSynthesisUtterance::setText):
(WebCore::SpeechSynthesisUtterance::lang):
(WebCore::SpeechSynthesisUtterance::setLang):
(WebCore::SpeechSynthesisUtterance::voiceURI):
(WebCore::SpeechSynthesisUtterance::setVoiceURI):
(WebCore::SpeechSynthesisUtterance::volume):
(WebCore::SpeechSynthesisUtterance::setVolume):
(WebCore::SpeechSynthesisUtterance::rate):
(WebCore::SpeechSynthesisUtterance::setRate):
(WebCore::SpeechSynthesisUtterance::pitch):
(WebCore::SpeechSynthesisUtterance::setPitch):
(SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::platformUtterance):

Modules/speech/SpeechSynthesisVoice.cpp:

(WebCore::SpeechSynthesisVoice::create):
(WebCore::SpeechSynthesisVoice::SpeechSynthesisVoice):

Modules/speech/SpeechSynthesisVoice.h:

(SpeechSynthesisVoice):
(WebCore::SpeechSynthesisVoice::voiceURI):
(WebCore::SpeechSynthesisVoice::name):
(WebCore::SpeechSynthesisVoice::lang):
(WebCore::SpeechSynthesisVoice::localService):
(WebCore::SpeechSynthesisVoice::isDefault):

Modules/speech/mac/SpeechSynthesisMac.mm:
WebCore.xcodeproj/project.pbxproj:
platform/PlatformSpeechSynthesis.h: Added.

(WebCore):
(PlatformSpeechSynthesis):

platform/PlatformSpeechSynthesisUtterance.cpp: Added.

(WebCore):
(WebCore::PlatformSpeechSynthesisUtterance::PlatformSpeechSynthesisUtterance):

platform/PlatformSpeechSynthesisUtterance.h: Added.

(WebCore):
(PlatformSpeechSynthesisUtteranceClient):
(WebCore::PlatformSpeechSynthesisUtteranceClient::~PlatformSpeechSynthesisUtteranceClient):
(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::text):
(WebCore::PlatformSpeechSynthesisUtterance::setText):
(WebCore::PlatformSpeechSynthesisUtterance::lang):
(WebCore::PlatformSpeechSynthesisUtterance::setLang):
(WebCore::PlatformSpeechSynthesisUtterance::voiceURI):
(WebCore::PlatformSpeechSynthesisUtterance::setVoiceURI):
(WebCore::PlatformSpeechSynthesisUtterance::volume):
(WebCore::PlatformSpeechSynthesisUtterance::setVolume):
(WebCore::PlatformSpeechSynthesisUtterance::rate):
(WebCore::PlatformSpeechSynthesisUtterance::setRate):
(WebCore::PlatformSpeechSynthesisUtterance::pitch):
(WebCore::PlatformSpeechSynthesisUtterance::setPitch):

platform/PlatformSpeechSynthesisVoice.cpp: Added.

(WebCore):
(WebCore::PlatformSpeechSynthesisVoice::create):
(WebCore::PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice):

platform/PlatformSpeechSynthesisVoice.h: Added.

(WebCore):
(PlatformSpeechSynthesisVoice):
(WebCore::PlatformSpeechSynthesisVoice::voiceURI):
(WebCore::PlatformSpeechSynthesisVoice::name):
(WebCore::PlatformSpeechSynthesisVoice::lang):
(WebCore::PlatformSpeechSynthesisVoice::localService):
(WebCore::PlatformSpeechSynthesisVoice::isDefault):

platform/PlatformSpeechSynthesizer.cpp: Added.

(WebCore):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):

platform/PlatformSpeechSynthesizer.h: Added.

(WebCore):
(PlatformSpeechSynthesizerClient):
(WebCore::PlatformSpeechSynthesizerClient::~PlatformSpeechSynthesizerClient):
(PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::voiceList):

platform/mac/PlatformSpeechSynthesisMac.mm: Added.

(WebCore):
(WebCore::PlatformSpeechSynthesis::create):
(WebCore::PlatformSpeechSynthesis::PlatformSpeechSynthesis):
(WebCore::PlatformSpeechSynthesis::platformSpeak):

platform/mac/PlatformSpeechSynthesizerMac.mm: Added.

(WebCore):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(WebCore::PlatformSpeechSynthesizer::speak):

1:41 PM Changeset in webkit [142319] by barraclough@apple.com

8 edits in trunk/Source/JavaScriptCore

Objective-C API for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=105889

Reviewed by Joseph Pecoraro

Following up on review comments, mostly typos.

API/JSBlockAdaptor.h:
API/JSBlockAdaptor.mm:

(-[JSBlockAdaptor blockFromValue:inContext:withException:]):

API/JSContext.h:
API/JSExport.h:
API/JSValue.h:
API/JSValue.mm:
API/JSWrapperMap.mm:

(selectorToPropertyName):
(-[JSWrapperMap classInfoForClass:]):
(-[JSWrapperMap wrapperForObject:]):

1:18 PM Changeset in webkit [142318] by schenney@chromium.org

666 edits
2 adds in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 17. SVG W3C tests. List omitted.

platform/chromium/TestExpectations:

1:04 PM Changeset in webkit [142317] by jpfau@apple.com

2 edits in trunk/LayoutTests

[Mac] Unreviewed, fix test expectation for a test only crashing in debug mode

platform/mac/TestExpectations:

1:00 PM Changeset in webkit [142316] by schenney@chromium.org

37 edits
33 deletes in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 16. Everything done but SVG, and cleanup.

platform/chromium-linux-x86/tables/mozilla/bugs/bug138725-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug18359-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug2479-2-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug2479-3-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug26178-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug28928-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug29326-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug33855-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug39209-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug4382-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug4429-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug44505-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug46368-1-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug46368-2-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug51037-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug51727-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug52505-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug52506-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug60749-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug68912-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug7342-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug92647-2-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/bugs/bug96334-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/collapsing_borders: Removed.
platform/chromium-linux-x86/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/core: Removed.
platform/chromium-linux-x86/tables/mozilla/core/margins-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/dom: Removed.
platform/chromium-linux-x86/tables/mozilla/dom/tableDom-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/other: Removed.
platform/chromium-linux-x86/tables/mozilla/other/move_row-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla_expected_failures/collapsing_borders: Removed.
platform/chromium-linux-x86/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla_expected_failures/core: Removed.
platform/chromium-linux-x86/tables/mozilla_expected_failures/core/captions1-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla_expected_failures/core/captions2-expected.png: Removed.
platform/chromium-linux-x86/transforms/2d/zoom-menulist-expected.png: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug138725-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug26178-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug39209-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug4429-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug51727-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug52505-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug52506-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug60749-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug68912-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
platform/chromium-linux/tables/mozilla/core/margins-expected.png:
platform/chromium-linux/tables/mozilla/dom/tableDom-expected.png:
platform/chromium-linux/tables/mozilla/other/move_row-expected.png:
platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
platform/chromium-linux/transforms/2d/zoom-menulist-expected.png:
platform/chromium/TestExpectations:

12:54 PM Changeset in webkit [142315] by schenney@chromium.org

48 edits
12 deletes in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 15. platform/. Too many to list.

platform/chromium/TestExpectations:

12:46 PM Changeset in webkit [142314] by andersca@apple.com

6 edits in trunk/Source/WebKit2

Work around a bug in Flash where NSException objects can be released too early
https://bugs.webkit.org/show_bug.cgi?id=109242
<rdar://problem/13003470>

Reviewed by Darin Adler.

Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::NetscapePluginModule::determineQuirks):
Set the new plug-in quirk.

Shared/Plugins/PluginQuirks.h:

Add a new plug-in quirk.

WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::initialize):
Call platformPreInitialize.

WebProcess/Plugins/Netscape/NetscapePlugin.h:

(NetscapePlugin):
Add platformPreInitialize.

WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NSException_release):
Add new empty function.

(WebKit::NetscapePlugin::platformPreInitialize):
Patch -[NSException release] to be a no-op.

12:45 PM Changeset in webkit [142313] by schenney@chromium.org

178 edits
1 add
28 deletes in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 14. Remaining tests up to platform in sorted order. Too many to list.

platform/chromium/TestExpectations:

12:35 PM Changeset in webkit [142312] by schenney@chromium.org

153 edits
13 adds
62 deletes in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 13. Last of the fast tests. Too many to list. Still listing efl changes.

platform/chromium/TestExpectations:
platform/chromium/fast/repaint/gradients-em-stops-repaint-expected.png: Removed.
platform/efl-wk2/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
platform/efl-wk2/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
platform/efl-wk2/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
platform/efl-wk2/fast/repaint/shadow-multiple-vertical-expected.png: Added.
platform/efl-wk2/fast/text: Added.
platform/efl-wk2/fast/text/stroking-decorations-expected.png: Added.
platform/efl-wk2/fast/text/stroking-expected.png: Added.
platform/efl-wk2/fast/transforms: Added.
platform/efl-wk2/fast/transforms/shadows-expected.png: Added.
platform/efl-wk2/fast/transforms/transformed-focused-text-input-expected.png: Added.
platform/efl/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
platform/efl/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
platform/efl/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
platform/efl/fast/repaint/shadow-multiple-vertical-expected.png: Removed.
platform/efl/fast/text/stroking-decorations-expected.png: Removed.
platform/efl/fast/text/stroking-expected.png: Removed.
platform/efl/fast/transforms/shadows-expected.png: Removed.
platform/efl/fast/transforms/transformed-focused-text-input-expected.png: Removed.
platform/mac/fast/replaced/three-selects-break-expected.png: Removed.

12:24 PM Changeset in webkit [142311] by dino@apple.com

4 edits in trunk/Source/WebCore

Put snapshotting label text into localizable strings
https://bugs.webkit.org/show_bug.cgi?id=108268

Reviewed by Simon Fraser.

In preparation for a snapshotted plug-in using a ShadowRoot, allow
its label to be localized.

English.lproj/Localizable.strings:
platform/LocalizedStrings.cpp:

(WebCore::snapshottedPlugInLabelTitle): New method for returning title.
(WebCore::snapshottedPlugInLabelSubtitle): New method for returning subtitle.

platform/LocalizedStrings.h:

12:23 PM Changeset in webkit [142310] by dino@apple.com

4 edits in trunk/Source

Do not register autostart for plugins from file:// (or nowhere)
https://bugs.webkit.org/show_bug.cgi?id=108271

Reviewed by Tim Horton.

Source/WebCore:

If the page url origin is treated as a local URL, don't attempt
to add it to the auto-start list.

html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::userDidClickSnapshot):

Source/WebKit2:

If the pageOrigin is the empty string don't add
it to the auto-start origin list for snapshotting.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::addPlugInAutoStartOrigin):

12:18 PM Changeset in webkit [142309] by commit-queue@webkit.org

2 edits in trunk

Update .gitignore for vim swap files.
https://bugs.webkit.org/show_bug.cgi?id=109252

Patch by Seulgi Kim <seulgikim@company100.net> on 2013-02-08
Reviewed by Dirk Pranke.

When opening the same files multiple with vim, vim creates a .*.sw[a-p]
file as the swap file.

.gitignore:

11:48 AM Changeset in webkit [142308] by schenney@chromium.org

266 edits
4 adds
94 deletes in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 12. More fast tests. Too many to list.

platform/chromium/TestExpectations:

11:41 AM Changeset in webkit [142307] by roger_fong@apple.com

20 edits
3 adds
20 deletes in trunk

Unreviewed. VS2010 WebKit Solution touchups.
Remove all .user files.
Add some build scripts to QTMovieWin that were forgotten about earlier.
Update the OpenSource WebKit solution to include DumpRenderTree and related projects.

WebKit.vcxproj: Added properties svn:ignore, svn:ignore, svn:ignore, svn:ignore and svn:ignore.
WebKit.vcxproj/Interfaces: Added property svn:ignore.
WebKit.vcxproj/Interfaces/Interfaces.vcxproj.user: Removed.
WebKit.vcxproj/WebKit: Added property svn:ignore.
WebKit.vcxproj/WebKit.sln:
WebKit.vcxproj/WebKit/WebKit.vcxproj.user: Removed.
WebKit.vcxproj/WebKitExportGenerator: Added property svn:ignore.
WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.user: Removed.
WebKit.vcxproj/WebKitGUID: Added property svn:ignore.
WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.user: Removed.
WebCore.vcxproj: Added properties svn:ignore and svn:ignore.
WebCore.vcxproj/QTMovieWin: Added property svn:ignore.
WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj.user: Removed.
WebCore.vcxproj/QTMovieWin/QTMovieWinPostBuild.cmd: Added.
WebCore.vcxproj/QTMovieWin/QTMovieWinPreBuild.cmd: Added.
WebCore.vcxproj/QTMovieWin/QTMovieWinPreLink.cmd: Added.
WebCore.vcxproj/WebCore.vcxproj.user: Removed.
WebCore.vcxproj/WebCoreGenerated.vcxproj.user: Removed.
JavaScriptCore.vcxproj: Added properties svn:ignore, svn:ignore, svn:ignore, svn:ignore, svn:ignore, svn:ignore, svn:ignore and svn:ignore.
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.user: Removed.
JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator: Added property svn:ignore.
JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.user: Removed.
JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj.user: Removed.
JavaScriptCore.vcxproj/LLInt/LLIntAssembly: Added property svn:ignore.
JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj.user: Removed.
JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets: Added property svn:ignore.
JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj.user: Removed.
JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor: Added property svn:ignore.
JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj.user: Removed.
JavaScriptCore.vcxproj/jsc: Added property svn:ignore.
JavaScriptCore.vcxproj/jsc/jsc.vcxproj.user: Removed.
JavaScriptCore.vcxproj/testRegExp: Added property svn:ignore.
JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj.user: Removed.
JavaScriptCore.vcxproj/testapi: Added property svn:ignore.
JavaScriptCore.vcxproj/testapi/testapi.vcxproj.user: Removed.
DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff: Added property svn:ignore.
DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin: Added property svn:ignore.
WinLauncher/WinLauncher.vcxproj: Added property svn:ignore.
WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.user: Removed.
WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.user: Removed.
WTF.vcxproj: Added property svn:ignore.
WTF.vcxproj/WTF.vcxproj.user: Removed.
WTF.vcxproj/WTFGenerated.vcxproj.user: Removed.

11:30 AM Changeset in webkit [142306] by schenney@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Flakey test expectations update

Unreviewed gardening.

platform/chromium/TestExpectations:

11:30 AM Changeset in webkit [142305] by abarth@webkit.org

7 edits in trunk/Source

Use WeakPtrs to communicate between the HTMLDocumentParser and the BackgroundHTMLParser
https://bugs.webkit.org/show_bug.cgi?id=107190

Reviewed by Eric Seidel.

Source/WebCore:

This patch replaces the parser map with WeakPtr. We now use WeakPtrs to
communicate from the main thread to the background thread. (We were
already using WeakPtrs to communicate from the background thread to the
main thread.) This change lets us remove a bunch of boilerplate code.

html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::stop):
(WebCore):

html/parser/BackgroundHTMLParser.h:

(WebCore::BackgroundHTMLParser::create):
(BackgroundHTMLParser):

html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::didFailSpeculation):
(WebCore::HTMLDocumentParser::startBackgroundParser):
(WebCore::HTMLDocumentParser::stopBackgroundParser):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::finish):

html/parser/HTMLDocumentParser.h:

(WebCore):
(HTMLDocumentParser):

Source/WTF:

Add the ability to create an unbound weak reference. This facility lets
you start sending messages to a WeakPtr on another thread before the
object backing the WeakPtr has actually been created.

wtf/WeakPtr.h:

(WTF::WeakReference::createUnbound):
(WTF::WeakReference::bindTo):
(WeakReference):
(WTF::WeakReference::WeakReference):
(WTF::WeakPtr::WeakPtr):
(WeakPtr):
(WTF::WeakPtrFactory::WeakPtrFactory):
(WeakPtrFactory):
(WTF::WeakPtrFactory::revokeAll):

11:09 AM Changeset in webkit [142304] by schenney@chromium.org

274 edits
17 adds
80 deletes in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 11. Some fast tests. Elided.

platform/chromium/TestExpectations:

10:45 AM Changeset in webkit [142303] by roger_fong@apple.com

2 edits
3 copies
1 move
35 adds in trunk

DumpRenderTree, ImageDiff and TestNetscapePlugin projects, property sheets and resources for VS2010 solution.
https://bugs.webkit.org/show_bug.cgi?id=107034.

Reviewed by Brent Fulgham.

DumpRenderTree/DumpRenderTree.vcxproj: Added.
DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree: Added.
DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj: Added.
DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters: Added.
DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props: Added.
DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props: Added.
DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props: Added.
DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Added.
DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props: Added.
DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props: Added.
DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props: Added.
DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Added.
DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Added.
DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props: Added.
DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff: Added.
DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj: Added.
DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props: Added.
DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props: Added.
DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj: Added.
DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props: Added.
DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props: Added.
DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props: Added.
DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPostBuild.cmd: Added.
DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd: Added.
DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props: Added.
DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin: Added.
DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def: Copied from DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def.
DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc: Copied from DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc.
DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj: Added.
DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters: Added.
DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props: Added.
DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props: Added.
DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPostBuild.cmd: Added.
DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd: Added.
DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props: Added.
DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h: Copied from DumpRenderTree/TestNetscapePlugIn/win/resource.h.
DumpRenderTree/TestNetscapePlugIn/Tests/win/CallJSThatDestroysPlugin.cpp: Copied from DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp.
DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Removed.

VS2010 WebCore TestSupport project.

WebCore.vcxproj/WebCoreTestSupport.vcxproj: Added.
WebCore.vcxproj/WebCoreTestSupport.vcxproj.filters: Added.

10:42 AM GStreamer edited by Martin Robinson

(diff)

10:11 AM GStreamer/GStreamerOnMac created by Martin Robinson

10:09 AM Changeset in webkit [142302] by schenney@chromium.org

4 edits
1 add
2 deletes in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 10. Mac 10.6 results were wrong. This simplifies things a lot.

fast/repaint/scale-page-shrink-expected.png: Added.
platform/chromium-mac-snowleopard/fast/repaint/background-scaling-expected.png:
platform/chromium-mac-snowleopard/fast/repaint/scale-page-shrink-expected.png:
platform/chromium-mac-snowleopard/fast/repaint/transform-absolute-in-positioned-container-expected.png:
platform/chromium/fast/repaint/scale-page-shrink-expected.png: Removed.
platform/mac/fast/repaint/scale-page-shrink-expected.png: Removed.

10:08 AM GStreamer created by Martin Robinson

10:06 AM Changeset in webkit [142301] by schenney@chromium.org

19 edits in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 9. These were rebaselined earlier before all the bots were done.

platform/chromium-mac-lion/svg/batik/text/smallFonts-expected.png:
platform/chromium-mac-lion/svg/batik/text/textDecoration-expected.png:
platform/chromium-mac-lion/svg/batik/text/textFeatures-expected.png:
platform/chromium-mac-lion/svg/custom/shapes-supporting-markers-expected.png:
platform/chromium-mac-lion/svg/text/selection-styles-expected.png:
platform/chromium-mac-snowleopard/svg/batik/text/smallFonts-expected.png:
platform/chromium-mac-snowleopard/svg/batik/text/textDecoration-expected.png:
platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png:
platform/chromium-mac/svg/batik/text/smallFonts-expected.png:
platform/chromium-mac/svg/batik/text/textDecoration-expected.png:
platform/chromium-mac/svg/batik/text/textFeatures-expected.png:
platform/chromium-mac/svg/custom/shapes-supporting-markers-expected.png:
platform/chromium-mac/svg/text/selection-styles-expected.png:
platform/chromium-win/svg/batik/text/smallFonts-expected.png:
platform/chromium-win/svg/batik/text/textDecoration-expected.png:
platform/chromium-win/svg/batik/text/textFeatures-expected.png:
platform/chromium-win/svg/custom/shapes-supporting-markers-expected.png:
platform/chromium-win/svg/text/selection-styles-expected.png:

10:04 AM Changeset in webkit [142300] by schenney@chromium.org

1 edit
2 adds
2 deletes in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 8. Outstanding mac failure.

editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
platform/chromium/editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.

10:01 AM Changeset in webkit [142299] by schenney@chromium.org

1 edit
2 deletes in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 7. Outstanding failing linux tests

platform/chromium-linux-x86/fast/forms/button-generated-content-expected.png: Removed.
platform/chromium-linux-x86/fast/forms/button-inner-block-reuse-expected.png: Removed.

9:59 AM Changeset in webkit [142298] by commit-queue@webkit.org

6 edits
5 adds in trunk/Source

[GTK] Add an experimental gyp build
https://bugs.webkit.org/show_bug.cgi?id=109003

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-08
Reviewed by Gustavo Noronha Silva.

Source/JavaScriptCore:

JavaScriptCore.gypi: Update the list of source files to include those

necessary for the GTK+ build.

Source/WebKit/gtk:

Add an experimental gyp build for WebKitGTK+. Currently only libjavascriptcoregtk,
jsc, and minidom build (and only on platforms for that support bash). To use the
build simply run:

$ gyp --generator-output=build --depth=. Source/WebKit/gtk/gyp/JavaScriptCore.gyp

Then enter the build directory and run make.

gyp/Configuration.gypi: Added.
gyp/JavaScriptCore.gyp: Added.
gyp/WTF.gyp: Added.
gyp/generate-derived-sources.sh: Added.

Source/WTF:

WTF.gyp/WTF.gyp: Filter out MetaAllocator.(cpp/h) from the Chromium

build. It's only necessary for GTK+.

WTF.gypi: Add MetaAllocator to the build for WebKitGTK+.

9:58 AM Changeset in webkit [142297] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[GTK][AC] GraphicsLayerActor code clean up after clutter version up.
https://bugs.webkit.org/show_bug.cgi?id=109304

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-08
Reviewed by Gustavo Noronha Silva.

This patch cleans up GraphicsLayerActor functions by using new clutter apis
and makes existing functions simple & readable.

No new tests since no change in functionality

platform/graphics/clutter/GraphicsLayerActor.cpp:

(_GraphicsLayerActorPrivate):
(graphicsLayerActorApplyTransform):
(graphicsLayerActorPaint):
(graphicsLayerActorDraw):
(graphicsLayerActorUpdateTexture):
(drawLayerContents):
(graphicsLayerActorNew):
(graphicsLayerActorInvalidateRectangle):
(graphicsLayerActorSetTransform):
(graphicsLayerActorSetAnchorPoint):
(graphicsLayerActorGetAnchorPoint):
(graphicsLayerActorSetScrollPosition):

platform/graphics/clutter/PlatformClutterAnimation.h:

9:58 AM Changeset in webkit [142296] by schenney@chromium.org

2 edits in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 6. Outstanding failing linux tests

platform/chromium-linux/fast/writing-mode/japanese-rl-text-expected.png:

9:55 AM Changeset in webkit [142295] by schenney@chromium.org

1126 edits
2 adds
188 deletes in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 5. Editing expectations.

File list truncated to remove the hundreds of files that have been updated.

platform/chromium/TestExpectations: Removed the temp expectations and re-added one mac failure case
platform/efl-wk1/editing/selection: Added.
platform/efl-wk1/editing/selection/move-by-character-6-expected.png: Added.
platform/efl/editing/selection/move-by-character-6-expected.png: Removed.

9:35 AM Changeset in webkit [142294] by kadam@inf.u-szeged.hu

3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Update platform specific expected files after r142280.

platform/qt/fast/block/float/024-expected.txt: Update after r142280.
platform/qt/fast/block/margin-collapse/empty-clear-blocks-expected.txt: Update after r142280.

9:32 AM Changeset in webkit [142293] by Lucas Forschler

4 edits in tags/Safari-537.30.1/Source

Versioning.

9:29 AM Changeset in webkit [142292] by Lucas Forschler

1 copy in tags/Safari-537.30.1

New Tag.

9:28 AM Changeset in webkit [142291] by senorblanco@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Remove effect-reference-hw from test expectations, since it's now passing.
https://bugs.webkit.org/show_bug.cgi?id=104289

platform/chromium/TestExpectations:

9:12 AM Changeset in webkit [142290] by tkent@chromium.org

5 edits in trunk

[Chromium] Disable ENABLE_INPUT_TYPE_DATETIME
https://bugs.webkit.org/show_bug.cgi?id=109272

Reviewed by Kentaro Hara.

Source/WebKit/chromium:

We enabled this flag for desktop Chromium, but disabled the feature by a
runtime flag. We disables the compile flag too because we have no plan
to ship it in near future.

features.gypi: Remove ENABLE_INPUT_TYPE_DATETIME.

LayoutTests:

platform/chromium/TestExpectations:

Skip fast/forms/datetime and datetime-multiple-fields

9:05 AM Changeset in webkit [142289] by commit-queue@webkit.org

4 edits in trunk

Source/WebCore: Fix and test for missing return statement

RTCPeerConnection.getStats() failed when remote stats were instantiated.
https://bugs.webkit.org/show_bug.cgi?id=109292

Patch by Harald Alvestrand <hta@google.com> on 2013-02-08
Reviewed by Adam Barth.

Tested by extending the existing mock's behaviour.

Modules/mediastream/RTCStatsReport.cpp:

(WebCore::RTCStatsReport::addElement):

Tools: Fix and test for missing return

RTCPeerConnection.getStats() fails when remote stats are instantiated.
https://bugs.webkit.org/show_bug.cgi?id=109292

Patch by Harald Alvestrand <hta@google.com> on 2013-02-08
Reviewed by Adam Barth.

DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::getStats):

8:57 AM Changeset in webkit [142288] by tommyw@google.com

6 edits
2 deletes in trunk

MediaStream API: Removing the deprecated WebMediaStreamDescriptor and WebMediaStreamComponent shims
https://bugs.webkit.org/show_bug.cgi?id=109296

Reviewed by Adam Barth.

Source/Platform:

Platform.gypi:
chromium/public/WebMediaStreamComponent.h: Removed.
chromium/public/WebMediaStreamDescriptor.h: Removed.

Tools:

DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.cpp:

(MockWebRTCDTMFSenderHandler::MockWebRTCDTMFSenderHandler):

DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.h:

(MockWebRTCDTMFSenderHandler):

DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:

(MockWebRTCPeerConnectionHandler::createDTMFSender):

8:40 AM Changeset in webkit [142287] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[Text Autosizing] Split isAutosizingCluster into three independent checks
https://bugs.webkit.org/show_bug.cgi?id=109093

Refactoring to create more flexible version of isAutosizingCluster since there're more types
of autosizing cluster now: narrower than the parent cluster, wider than the parent cluster
and the one that doesn't depend on the parent cluster.

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-08
Reviewed by Kenneth Rohde Christiansen.

Refactoring, no test changes.

rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::isNarrowDescendant):

Separate check for the container to be of the narrow-descendant type. Was a part of
isAutosizingCluster().

(WebCore::TextAutosizer::isWiderDescendant):

Separate check for the container to be of the wider-descendant type. Was a part of
isAutosizingCluster().

(WebCore::TextAutosizer::isIndependentDescendant):

Separate check for the container to be autosized separately from the ancestor cluster.
Checks for conditions independent of the aforementioned cluster.

(WebCore::TextAutosizer::isAutosizingCluster):

Handy method to check all separate conditions together.

(WebCore::TextAutosizer::processSubtree):
(WebCore::TextAutosizer::processCluster):
(WebCore::TextAutosizer::processContainer):
(WebCore::TextAutosizer::clusterShouldBeAutosized):
(WebCore::TextAutosizer::measureDescendantTextWidth):
(WebCore::TextAutosizer::findFirstTextLeafNotInCluster):

The methods above were updated to use new functions/arguments.

rendering/TextAutosizer.h:

Updated/added method definitions.

8:27 AM Changeset in webkit [142286] by schenney@chromium.org

46 edits
6 adds
18 deletes in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 4. CSS expectations.

platform/chromium-linux-x86/css1/box_properties: Removed.
platform/chromium-linux-x86/css1/box_properties/acid_test-expected.png: Removed.
platform/chromium-linux-x86/css2.1/t09-c5526c-display-00-e-expected.png: Removed.
platform/chromium-linux-x86/css3/images: Removed.
platform/chromium-linux-x86/css3/images/cross-fade-overflow-position-expected.png: Removed.
platform/chromium-linux-x86/css3/selectors3/html: Removed.
platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-161-expected.png: Removed.
platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-19b-expected.png: Removed.
platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-25-expected.png: Removed.
platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-64-expected.png: Removed.
platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-70-expected.png: Removed.
platform/chromium-linux-x86/css3/selectors3/xhtml: Removed.
platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-161-expected.png: Removed.
platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-19b-expected.png: Removed.
platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-25-expected.png: Removed.
platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-64-expected.png: Removed.
platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-70-expected.png: Removed.
platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-161-expected.png: Removed.
platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-19b-expected.png: Removed.
platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-25-expected.png: Removed.
platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-64-expected.png: Removed.
platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-70-expected.png: Removed.
platform/chromium-linux/compositing/overflow/theme-affects-visual-overflow-expected.png:
platform/chromium-linux/compositing/video/video-controls-layer-creation-expected.png:
platform/chromium-linux/css1/box_properties/acid_test-expected.png:
platform/chromium-linux/css2.1/t0505-c16-descendant-01-e-expected.png:
platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.png:
platform/chromium-linux/css3/images/cross-fade-overflow-position-expected.png: Removed.
platform/chromium-linux/css3/masking/clip-path-circle-filter-expected.png:
platform/chromium-linux/css3/masking/clip-path-circle-overflow-expected.png:
platform/chromium-linux/css3/masking/clip-path-ellipse-expected.png:
platform/chromium-linux/css3/selectors3/html/css3-modsel-161-expected.png:
platform/chromium-linux/css3/selectors3/html/css3-modsel-19b-expected.png:
platform/chromium-linux/css3/selectors3/html/css3-modsel-25-expected.png:
platform/chromium-linux/css3/selectors3/html/css3-modsel-64-expected.png:
platform/chromium-linux/css3/selectors3/html/css3-modsel-70-expected.png:
platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-15c-expected.png: Added.
platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-161-expected.png:
platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-25-expected.png:
platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-64-expected.png:
platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-70-expected.png:
platform/chromium-linux/css3/selectors3/xml/css3-modsel-161-expected.png:
platform/chromium-linux/css3/selectors3/xml/css3-modsel-19b-expected.png:
platform/chromium-linux/css3/selectors3/xml/css3-modsel-25-expected.png:
platform/chromium-linux/css3/selectors3/xml/css3-modsel-64-expected.png:
platform/chromium-linux/css3/selectors3/xml/css3-modsel-70-expected.png:
platform/chromium-mac-lion/compositing/video/video-controls-layer-creation-expected.png:
platform/chromium-mac-lion/css2.1/t0505-c16-descendant-01-e-expected.png:
platform/chromium-mac-lion/css3/images: Removed.
platform/chromium-mac-lion/css3/images/cross-fade-overflow-position-expected.png: Removed.
platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-15c-expected.png: Added.
platform/chromium-mac-snowleopard/compositing/video/video-controls-layer-creation-expected.png:
platform/chromium-mac-snowleopard/css2.1/t0505-c16-descendant-01-e-expected.png:
platform/chromium-mac-snowleopard/css3/images/cross-fade-overflow-position-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-15c-expected.png: Added.
platform/chromium-mac/compositing/video/video-controls-layer-creation-expected.png:
platform/chromium-mac/css2.1/t0505-c16-descendant-01-e-expected.png:
platform/chromium-mac/css2.1/t0505-c16-descendant-01-e-expected.txt: Added.
platform/chromium-mac/css3/images/cross-fade-overflow-position-expected.png:
platform/chromium-mac/css3/masking/clip-path-circle-filter-expected.png:
platform/chromium-mac/css3/masking/clip-path-circle-overflow-expected.png:
platform/chromium-mac/css3/masking/clip-path-ellipse-expected.png:
platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-15c-expected.png:
platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-15c-expected.txt:
platform/chromium-mac/css3/selectors3/xml/css3-modsel-15c-expected.png:
platform/chromium-mac/css3/selectors3/xml/css3-modsel-15c-expected.txt:
platform/chromium-win-xp/css3/images: Removed.
platform/chromium-win-xp/css3/images/cross-fade-overflow-position-expected.png: Removed.
platform/chromium-win-xp/css3/selectors3: Removed.
platform/chromium-win/compositing/video/video-controls-layer-creation-expected.png:
platform/chromium-win/css2.1/t0505-c16-descendant-01-e-expected.png:
platform/chromium-win/css2.1/t0505-c16-descendant-01-e-expected.txt:
platform/chromium-win/css3/images/cross-fade-overflow-position-expected.png:
platform/chromium-win/css3/masking/clip-path-circle-filter-expected.png:
platform/chromium-win/css3/masking/clip-path-circle-overflow-expected.png:
platform/chromium-win/css3/masking/clip-path-ellipse-expected.png:
platform/chromium-win/css3/selectors3/xhtml/css3-modsel-15c-expected.png: Added.
platform/chromium-win/css3/selectors3/xhtml/css3-modsel-15c-expected.txt: Added.
platform/chromium/TestExpectations:
platform/chromium/css2.1/t0505-c16-descendant-01-e-expected.txt: Removed.
platform/chromium/css3/selectors3/xhtml/css3-modsel-15c-expected.png: Removed.
platform/chromium/css3/selectors3/xhtml/css3-modsel-15c-expected.txt: Removed.

8:17 AM Changeset in webkit [142285] by commit-queue@webkit.org

3 edits in trunk

[GTK] Include files from DerivedSources/webkitdom for introspection
https://bugs.webkit.org/show_bug.cgi?id=108631

Patch by Tomas Popela <tpopela@redhat.com> on 2013-02-08
Reviewed by Martin Robinson.

Include files from DerivedSources/webkitdom for introspection

/Source/WebKit/gtk/GNUmakefile.am:
/Source/WebKit2/GNUmakefile.am:

8:15 AM Changeset in webkit [142284] by Martin Robinson

2 edits
9 adds in trunk

[GTK] Split configure.ac into reusable portions
https://bugs.webkit.org/show_bug.cgi?id=109246

Reviewed by Philippe Normand.

Split up configure.ac into sections based on different "phases"
of configuration. This should make it easier to find what you are
looking for as well as creating a "right" place to put things.
A nice side effect of this is that we can share the different
modules with a gyp build.

Source/autotools/CheckSystemAndBasicDependencies.m4: Added.
Source/autotools/FindDependencies.m4: Added.
Source/autotools/PrintBuildConfiguration.m4: Added.
Source/autotools/ReadCommandLineArguments.m4: Added.
Source/autotools/SetupAutoconfHeader.m4: Added.
Source/autotools/SetupAutomake.m4: Added.
Source/autotools/SetupCompilerFlags.m4: Added.
Source/autotools/SetupLibtool.m4: Added.
Source/autotools/Versions.m4: Added.
configure.ac:

8:09 AM Changeset in webkit [142283] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Extension sever should use Workspace.projectForType() instead of Workspace.project()
https://bugs.webkit.org/show_bug.cgi?id=109301

Reviewed by Alexander Pavlov.

inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onGetPageResources):

8:09 AM Changeset in webkit [142282] by schenney@chromium.org

22 edits
6 adds
9 deletes in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 3. Remaining expected failures that had platform-specific supppressions

platform/chromium-linux-x86/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Removed.
platform/chromium-linux-x86/fast/gradients/css3-linear-angle-gradients-expected.png: Removed.
platform/chromium-linux/fast/css/background-clip-radius-values-expected.png:
platform/chromium-linux/fast/css/nested-rounded-corners-expected.png:
platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
platform/chromium-linux/fast/frames/iframe-scaling-with-scroll-expected.png:
platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.png:
platform/chromium-linux/fast/replaced/border-radius-clip-content-edge-expected.png:
platform/chromium-mac-lion/editing/pasteboard/emacs-cntl-y-001-expected.png: Added.
platform/chromium-mac-lion/editing/pasteboard/emacs-ctrl-a-k-y-expected.png: Added.
platform/chromium-mac-lion/fast/css/nested-rounded-corners-expected.png:
platform/chromium-mac-lion/fast/dom/52776-expected.png:
platform/chromium-mac-lion/fast/frames/iframe-scaling-with-scroll-expected.png:
platform/chromium-mac-lion/fast/gradients/css3-linear-angle-gradients-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/css/nested-rounded-corners-expected.png:
platform/chromium-mac-snowleopard/fast/dom/52776-expected.png:
platform/chromium-mac-snowleopard/fast/gradients/css3-linear-angle-gradients-expected.png: Removed.
platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png: Removed.
platform/chromium-mac/editing/pasteboard/emacs-cntl-y-001-expected.png: Added.
platform/chromium-mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.png: Added.
platform/chromium-mac/fast/css/background-clip-radius-values-expected.png:
platform/chromium-mac/fast/css/nested-rounded-corners-expected.png:
platform/chromium-mac/fast/dom/52776-expected.png:
platform/chromium-mac/fast/gradients/css3-linear-angle-gradients-expected.png:
platform/chromium-mac/fast/replaced/border-radius-clip-content-edge-expected.png: Added.
platform/chromium-mac/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Removed.
platform/chromium-win-xp/fast/gradients/css3-linear-angle-gradients-expected.png: Removed.
platform/chromium-win/fast/css/background-clip-radius-values-expected.png:
platform/chromium-win/fast/css/nested-rounded-corners-expected.png:
platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
platform/chromium-win/fast/gradients/css3-linear-angle-gradients-expected.png:
platform/chromium-win/fast/replaced/border-radius-clip-content-edge-expected.png: Added.
platform/chromium/TestExpectations:
platform/chromium/editing/pasteboard/emacs-cntl-y-001-expected.png: Removed.
platform/chromium/editing/pasteboard/emacs-ctrl-a-k-y-expected.png: Removed.

8:04 AM Changeset in webkit [142281] by yurys@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: simplify Memory.getDOMNodeCount implementation
https://bugs.webkit.org/show_bug.cgi?id=108821

Reviewed by Alexander Pavlov.

Removed Memory.getDOMNodeCount command from the protocol. Memory.getDOMCounters
should be used instead.

inspector/Inspector.json:
inspector/InspectorMemoryAgent.cpp:
inspector/InspectorMemoryAgent.h:

(InspectorMemoryAgent):

7:59 AM Changeset in webkit [142280] by kadam@inf.u-szeged.hu

9 edits
1 copy
1 add in trunk/LayoutTests

[Qt] Reviewin Qt TestExpectations. Rebaseline and unskip passing tests.

platform/qt/TestExpectations:
platform/qt/svg/css/arrow-with-shadow-expected.png:
platform/qt/svg/css/arrow-with-shadow-expected.txt:
platform/qt/svg/css/clippath-with-shadow-expected.png:
platform/qt/svg/css/clippath-with-shadow-expected.txt:
platform/qt/svg/css/composite-shadow-text-expected.png:
platform/qt/svg/custom/simple-text-double-shadow-expected.png:
platform/qt/svg/custom/simple-text-double-shadow-expected.txt:
platform/qt/svg/repaint/repaint-webkit-svg-shadow-expected.png: Copied from LayoutTests/platform/qt/svg/css/clippath-with-shadow-expected.png.
platform/qt/svg/repaint/repaint-webkit-svg-shadow-expected.txt: Added.

7:46 AM Changeset in webkit [142279] by schenney@chromium.org

16 edits
2 adds
2 deletes in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 2. Failing Linux tests with no expectations

platform/chromium-linux/fast/forms/button-generated-content-expected.png:
platform/chromium-linux/fast/forms/button-inner-block-reuse-expected.png:
platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.png:
platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.png:
platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
platform/chromium-linux/fast/text/justify-ideograph-vertical-expected.png:
platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.png:
platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.png:
platform/chromium-linux/fast/writing-mode/japanese-lr-text-expected.png:
platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.png:
platform/chromium-linux/svg/batik/text/smallFonts-expected.png:
platform/chromium-linux/svg/batik/text/textDecoration-expected.png:
platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
platform/chromium-linux/svg/custom/shapes-supporting-markers-expected.png:
platform/chromium-linux/svg/text/selection-styles-expected.png:
platform/efl-wk2/fast/repaint: Added.
platform/efl-wk2/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
platform/efl/fast/repaint/japanese-rl-selection-clear-expected.png: Removed.
platform/efl/svg/batik/text/textDecoration-expected.png: Removed.

7:44 AM Changeset in webkit [142278] by yurys@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: refactor MemoryStatistics.js
https://bugs.webkit.org/show_bug.cgi?id=109299

Reviewed by Vsevolod Vlasov.

Extracted functionality specific to DOM counter graphs drawing into
separate methods on MemoryStatistics class.
Introduced CounterUIBase base class for DOMCounterUI that contains
functionality which can be shared with native memory graph.

inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics):
(WebInspector.CounterUIBase):
(WebInspector.CounterUIBase.prototype.updateCurrentValue):
(WebInspector.CounterUIBase.prototype.clearCurrentValueAndMarker):
(WebInspector.CounterUIBase.prototype.get visible):
(WebInspector.DOMCounterUI):
(WebInspector.DOMCounterUI.prototype.discardImageUnderMarker):
(WebInspector.MemoryStatistics.prototype._onMouseOut):
(WebInspector.MemoryStatistics.prototype._clearCurrentValueAndMarker):
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):
(WebInspector.MemoryStatistics.prototype._updateCurrentValue):
(WebInspector.MemoryStatistics.prototype._highlightCurrentPositionOnGraphs):
(WebInspector.MemoryStatistics.prototype._restoreImageUnderMarker):
(WebInspector.MemoryStatistics.prototype._saveImageUnderMarker):
(WebInspector.MemoryStatistics.prototype._drawMarker):
(WebInspector.MemoryStatistics.prototype._clear):
(WebInspector.MemoryStatistics.prototype._discardImageUnderMarker):

7:36 AM Changeset in webkit [142277] by schenney@chromium.org

25 edits
7 adds
6 deletes in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 1. Some tests that have existing expectations.

editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
fast/repaint/transform-absolute-in-positioned-container-expected.txt: Added.
platform/chromium-linux-x86/editing/input: Removed.
platform/chromium-linux/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
platform/chromium-linux/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
platform/chromium-linux/editing/input/reveal-caret-of-multiline-input-expected.png:
platform/chromium-linux/fast/repaint/transform-absolute-in-positioned-container-expected.png:
platform/chromium-mac-lion/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
platform/chromium-mac-lion/editing/input/caret-at-the-edge-of-input-expected.png:
platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-input-expected.png:
platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
platform/chromium-mac-snowleopard/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
platform/chromium-mac-snowleopard/editing/input/reveal-caret-of-multiline-input-expected.png:
platform/chromium-mac/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
platform/chromium-mac/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
platform/chromium-mac/editing/input/caret-at-the-edge-of-input-expected.png:
platform/chromium-mac/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
platform/chromium-mac/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
platform/chromium-mac/editing/input/reveal-caret-of-multiline-input-expected.png:
platform/chromium-win-xp/editing/input: Removed.
platform/chromium-win/editing/input/caret-at-the-edge-of-contenteditable-expected.png:
platform/chromium-win/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
platform/chromium-win/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
platform/chromium-win/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
platform/chromium-win/editing/input/reveal-caret-of-multiline-input-expected.png:
platform/chromium-win/editing/input/reveal-caret-of-multiline-input-expected.txt:
platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.png:
platform/chromium/TestExpectations:
platform/chromium/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Removed.
platform/efl-wk1/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Removed.
platform/efl-wk2/editing/input: Added.
platform/efl-wk2/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
platform/efl/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Removed.
platform/gtk/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Removed.

7:07 AM Changeset in webkit [142276] by kadam@inf.u-szeged.hu

3 edits
1 add in trunk/LayoutTests

[Qt] Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=109209.

platform/qt/TestExpectations:
platform/qt/fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Added after r142152.
platform/qt/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt: Added after r142152.

7:02 AM Changeset in webkit [142275] by benm@google.com

2 edits in branches/chromium/1364/Source/WebKit/chromium

Merge 141904

[chromium] Make overlay layers slow-scrolling
https://bugs.webkit.org/show_bug.cgi?id=108957

Patch by Sami Kyostila <skyostil@chromium.org> on 2013-02-05
Reviewed by James Robinson.

Since overlay layers get inserted on top of everything else, we must
mark them slow-scrolling to prevent all scroll input events to the rest
of the page from getting blocked. This is also more correct because
generally the overlay contents need to be repainted whenever the scroll
offset changes, and with this patch the painting happens in sync with
page scrolling.

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12210085

6:50 AM Changeset in webkit [142274] by kadam@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt][Wk2] Unreviewed gardening. Skip failing tests.
https://bugs.webkit.org/show_bug.cgi?id=109291.

platform/qt-5.0-wk2/TestExpectations:

6:42 AM Changeset in webkit [142273] by schenney@chromium.org

11 edits
25 adds in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

These are tests that failed due to bad expectations.

platform/chromium-linux/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png:
platform/chromium-mac-lion/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
platform/chromium-mac-lion/svg/as-background-image/svg-as-background-5-expected.png:
platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png:
platform/chromium-mac/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png: Added.
platform/chromium-mac/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png: Added.
platform/chromium-mac/platform/chromium/rubberbanding/custom-scrollbars-se-expected.png: Added.
platform/chromium-mac/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png: Added.
platform/chromium-mac/platform/chromium/rubberbanding/overhang-ne-expected.png: Added.
platform/chromium-mac/platform/chromium/rubberbanding/overhang-nw-expected.png: Added.
platform/chromium-mac/platform/chromium/rubberbanding/overhang-se-expected.png: Added.
platform/chromium-mac/platform/chromium/rubberbanding/overhang-sw-expected.png: Added.
platform/chromium-win/platform/chromium/rubberbanding: Added.
platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png: Added.
platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.txt: Added.
platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png: Added.
platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.txt: Added.
platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-se-expected.png: Added.
platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-se-expected.txt: Added.
platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png: Added.
platform/chromium-win/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.txt: Added.
platform/chromium-win/platform/chromium/rubberbanding/overhang-ne-expected.png: Added.
platform/chromium-win/platform/chromium/rubberbanding/overhang-ne-expected.txt: Added.
platform/chromium-win/platform/chromium/rubberbanding/overhang-nw-expected.png: Added.
platform/chromium-win/platform/chromium/rubberbanding/overhang-nw-expected.txt: Added.
platform/chromium-win/platform/chromium/rubberbanding/overhang-se-expected.png: Added.
platform/chromium-win/platform/chromium/rubberbanding/overhang-se-expected.txt: Added.
platform/chromium-win/platform/chromium/rubberbanding/overhang-sw-expected.png: Added.
platform/chromium-win/platform/chromium/rubberbanding/overhang-sw-expected.txt: Added.
platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.png:
platform/chromium-win/svg/custom/embedding-external-svgs-expected.png:
platform/chromium-win/svg/custom/pointer-events-text-expected.png:
platform/chromium/TestExpectations:

6:23 AM Changeset in webkit [142272] by schenney@chromium.org

2 edits in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed gardening.

platform/chromium/TestExpectations: Last of the Win failures.

6:21 AM Changeset in webkit [142271] by mkwst@chromium.org

66 edits in trunk/Source/WebCore

Add a new IGNORE_EXCEPTION helper to ignore ExceptionCodes when they are expected but uninteresting
https://bugs.webkit.org/show_bug.cgi?id=108771

Reviewed by Eric Seidel.

In cases where the ExceptionCode passed into a function is completely
ignored, this patch replaces it with a new IGNORE_EXCEPTION macro. This
makes our expectations about possible exceptions (or lack thereof)
explicit, rather than relying on implicit assumptions about whether a
variable is intentionally uninitialized or not. It also removes
knowledge about the internals of ExceptionCodes (that they're currently
ints, for instance) from code that shouldn't care, which will help with
future refactorings.

The implementation is entirely based upon ASSERT_NO_EXCEPTION, and
shouldn't have any visible effect on the web. As long as all the
current tests pass, we're good.

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::uncaughtExceptionInEventHandler):

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::stop):

Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::processBuffer):

dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

dom/ExceptionCodePlaceholder.h:

(WebCore):

dom/Node.cpp:

(WebCore::Node::normalize):

dom/Text.cpp:

(WebCore::Text::replaceWholeText):

editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::insertDictatedText):

editing/AppendNodeCommand.cpp:

(WebCore::AppendNodeCommand::doApply):
(WebCore::AppendNodeCommand::doUnapply):

editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt):

editing/DeleteFromTextNodeCommand.cpp:

(WebCore::DeleteFromTextNodeCommand::doUnapply):

editing/Editor.cpp:

(WebCore::dispatchEditableContentChangedEvents):
(WebCore::Editor::applyEditingStyleToElement):

editing/EditorCommand.cpp:

(WebCore::executeFormatBlock):

editing/FormatBlockCommand.cpp:

(WebCore::FormatBlockCommand::elementForFormatBlockCommand):

editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):

editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::doApplyForSingleParagraph):

editing/InsertNodeBeforeCommand.cpp:

(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):

editing/RemoveCSSPropertyCommand.cpp:

(WebCore::RemoveCSSPropertyCommand::doApply):
(WebCore::RemoveCSSPropertyCommand::doUnapply):

editing/RemoveNodeCommand.cpp:

(WebCore::RemoveNodeCommand::doApply):
(WebCore::RemoveNodeCommand::doUnapply):

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):

editing/TextIterator.cpp:

(WebCore::TextIterator::getLocationAndLengthFromRange):

editing/WrapContentsInDummySpanCommand.cpp:

(WebCore::WrapContentsInDummySpanCommand::executeApply):
(WebCore::WrapContentsInDummySpanCommand::doUnapply):

editing/htmlediting.cpp:

(WebCore::comparePositions):

editing/markup.cpp:

(WebCore::highestAncestorToWrapMarkup):

html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::appendEntry):
(WebCore::FTPDirectoryDocumentParser::createTDForFilename):
(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
(WebCore::FTPDirectoryDocumentParser::createBasicDocument):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::rewind):
(WebCore::HTMLMediaElement::returnToRealtime):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::percentLoaded):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::mediaPlayerDurationChanged):
(WebCore::HTMLMediaElement::applyMediaFragmentURI):

html/HTMLOutputElement.cpp:

(WebCore::HTMLOutputElement::setTextContentInternal):

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::remove):

html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::createTHead):
(WebCore::HTMLTableElement::deleteTHead):
(WebCore::HTMLTableElement::createTFoot):
(WebCore::HTMLTableElement::deleteTFoot):
(WebCore::HTMLTableElement::createCaption):
(WebCore::HTMLTableElement::deleteCaption):

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::setDefaultValue):

html/ImageDocument.cpp:

(WebCore::ImageDocument::createDocumentStructure):

html/InputType.cpp:

(WebCore::InputType::stepUpFromRenderer):

html/MediaController.cpp:

(MediaController::bringElementUpToSpeed):
(MediaController::asyncEventTimerFired):

html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):
(WebCore::MediaDocument::replaceMediaElementTimerFired):

html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent):

html/TimeRanges.cpp:

(TimeRanges::contain):
(TimeRanges::nearest):

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImageFromRect):

html/shadow/MediaControlElementTypes.cpp:

(WebCore::MediaControlSeekButtonElement::seekTimerFired):

html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):
(WebCore::MediaControlStatusDisplayElement::update):
(WebCore::MediaControlRewindButtonElement::defaultEventHandler):
(WebCore::MediaControlTimelineElement::defaultEventHandler):

html/shadow/MediaControls.cpp:

(WebCore::MediaControls::updateCurrentTimeDisplay):
(WebCore::MediaControls::createTextTrackDisplay):

html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsApple::updateCurrentTimeDisplay):

html/shadow/MediaControlsBlackBerry.cpp:

(WebCore::MediaControlEmbeddedPanelElement::setPosition):
(WebCore::MediaControlEmbeddedPanelElement::resetPosition):
(WebCore::MediaControlFullscreenTimelineElement::defaultEventHandler):
(WebCore::MediaControlsBlackBerry::updateCurrentTimeDisplay):

html/shadow/MediaControlsChromium.cpp:

(WebCore::MediaControlsChromium::updateCurrentTimeDisplay):

html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::addGenericCue):

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):

inspector/InspectorHistory.cpp:

(WebCore::InspectorHistory::markUndoableState):

inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::replayXHR):

page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):

page/DOMWindow.cpp:

(WebCore::didAddStorageEventListener):

page/DragController.cpp:

(WebCore::documentFragmentFromDragData):

page/EventHandler.cpp:

(WebCore::EventHandler::dispatchDragEvent):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::handleTextInputEvent):

page/Page.cpp:

(WebCore::Page::findStringMatchingRanges):

platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintMediaSliderTrack):

platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::percentLoaded):

platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::paintMediaSliderTrack):

platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::getDataSelection):
(WebCore::documentFragmentWithImageResource):
(WebCore::Pasteboard::documentFragment):

platform/mac/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
(-[WebVideoFullscreenHUDWindowController setVolume:]):

platform/qt/RenderThemeQt.cpp:

(WebCore::RenderThemeQt::paintMediaSliderTrack):

rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::getRanges):

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMediaSliderTrack):

svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::detachTarget):

xml/XMLTreeViewer.cpp:

(WebCore::XMLTreeViewer::transformDocumentToTreeView):

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::endElementNs):

xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::parseEndElement):

6:14 AM Changeset in webkit [142270] by schenney@chromium.org

2 edits in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed gardening.

platform/chromium/TestExpectations: Adding Mac rubberbanding failures

6:10 AM Changeset in webkit [142269] by vsevik@chromium.org

25 edits in trunk

Web Inspector: Introduce workspace provider/project type, encapsulate uri creation in SimpleWorkspaceProvider.
https://bugs.webkit.org/show_bug.cgi?id=109282

Reviewed by Alexander Pavlov.

Source/WebCore:

SimpleWorkspaceProvider now fully takes care of creating uri based on project/workspace provider type.
This is the first step on the way to project-per-domain mode for non file system project types.
Workspace is now partly aware of the possibility that several projects with the same type exist.
Drive-by: ScriptsPanel now uses FileMapping to show anchor location properly.

inspector/front-end/DefaultScriptMapping.js:

(WebInspector.DefaultScriptMapping):
(WebInspector.DefaultScriptMapping.prototype.addScript):

inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onGetPageResources):

inspector/front-end/FileMapping.js:

(WebInspector.FileMapping.prototype.uriForURL):

inspector/front-end/FileSystemWorkspaceProvider.js:

(WebInspector.FileSystemWorkspaceProvider.prototype.type):

inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._supportsEnabledBreakpointsWhileEditing):

inspector/front-end/LiveEditSupport.js:

(WebInspector.LiveEditSupport):
(WebInspector.LiveEditSupport.prototype.uiSourceCodeForLiveEdit):

inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):

inspector/front-end/ScriptsNavigator.js:

(WebInspector.ScriptsNavigator.prototype._navigatorViewForUISourceCode):
(WebInspector.ScriptsNavigator.prototype.revealUISourceCode):
(WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._projectWillReset):
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):

inspector/front-end/SimpleWorkspaceProvider.js:

(WebInspector.SimpleWorkspaceProvider):
(WebInspector.SimpleWorkspaceProvider.uriForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.type):
(WebInspector.SimpleWorkspaceProvider.prototype.addFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype.addUniqueFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):
(WebInspector.SimpleWorkspaceProvider.prototype._uniqueURI):

inspector/front-end/Workspace.js:

(WebInspector.WorkspaceProvider.prototype.type):
(WebInspector.Project.prototype.type):
(WebInspector.Project.prototype.isServiceProject):
(WebInspector.Workspace.prototype.uiSourceCodeForOriginURL):
(WebInspector.Workspace.prototype.uiSourceCodesForProjectType):
(WebInspector.Workspace.prototype.projectsForType):

inspector/front-end/inspector.js:

LayoutTests:

http/tests/inspector-enabled/dynamic-scripts.html:
http/tests/inspector/compiler-script-mapping.html:
http/tests/inspector/workspace-test.js:

(initialize_WorkspaceTest.InspectorTest.createWorkspace):

inspector/debugger/breakpoint-manager.html:
inspector/debugger/dynamic-scripts.html:
inspector/debugger/script-snippet-model.html:
inspector/debugger/scripts-file-selector.html:
inspector/debugger/scripts-panel.html:
inspector/debugger/scripts-sorting-expected.txt:
inspector/debugger/scripts-sorting.html:
inspector/uisourcecode-revisions.html:

5:55 AM Changeset in webkit [142268] by kov@webkit.org

2 edits in trunk/Source/WebKit/gtk/po

Updated French translation
https://bugs.webkit.org/show_bug.cgi?id=106229

Patch by Alexandre Franke <alexandre.franke@gmail.com> on 2013-02-08
Rubber-stamped by Gustavo Noronha.

fr.po: updated.

5:49 AM Changeset in webkit [142267] by schenney@chromium.org

2 edits in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed gardening.

platform/chromium/TestExpectations: Outstanding Win failures

5:41 AM Changeset in webkit [142266] by schenney@chromium.org

2 edits in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed gardening.

platform/chromium/TestExpectations: One more to get all bots green again ready for rebaselining.

5:35 AM Changeset in webkit [142265] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GTK][AC] GraphicsLayerClutter doesn't need to recalculate its position after changing anchor position.
https://bugs.webkit.org/show_bug.cgi?id=109226

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-08
Reviewed by Gustavo Noronha Silva.

Clutter has a different coordinate system from mac port's, so we don't need to
recalulate GraphicsLayer position after changing its anchor position.

Covered by existing ac tests.

platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::GraphicsLayerClutter::updateGeometry):

5:16 AM Changeset in webkit [142264] by schenney@chromium.org

2 edits in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed gardening.

platform/chromium/TestExpectations: Modified a MountainLion expectation

5:05 AM Changeset in webkit [142263] by schenney@chromium.org

2 edits in trunk/LayoutTests

Expectations as a result of removing Skia code suppressions

Unreviewed gardening.

platform/chromium/TestExpectations:

5:04 AM Changeset in webkit [142262] by mkwst@chromium.org

4 edits in trunk/Source/WebCore

Migrate ExceptionCode ASSERTs in IDB to ASSERT_NO_EXCEPTION.
https://bugs.webkit.org/show_bug.cgi?id=109266

Reviewed by Jochen Eisinger.

The pattern:

ExceptionCode ec = 0;
methodThatGeneratesException(ec);
ASSERT(!ec);

is more clearly and succinctly written as:

methodThatGeneratesException(ASSERT_NO_EXCEPTION);

This patch replaces the occurances of the former in IDB code that never
touch 'ec' again with the latter. No change in behavior should result
from this refactoring.

Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::advance):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::deleteFunction):

These methods checked the value of the ExceptionCode without first
initializing it to 0. Now the ExceptionCode is explicitly set to 0
before doing potentially exception-generating work.

(WebCore::IDBCursor::direction):

Modules/indexeddb/IDBObjectStore.cpp:

(WebCore):

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::mode):

Replace the above pattern with ASSERT_NO_EXCEPTION.

4:54 AM Changeset in webkit [142261] by mkwst@chromium.org

7 edits in trunk/Source/WebCore

Migrate ExceptionCode ASSERTs in SVG to ASSERT_NO_EXCEPTION.
https://bugs.webkit.org/show_bug.cgi?id=109267

Reviewed by Jochen Eisinger.

The pattern:

ExceptionCode ec = 0;
methodThatGeneratesException(ec);
ASSERT(!ec);

is more clearly and succinctly written as:

methodThatGeneratesException(ASSERT_NO_EXCEPTION);

This patch replaces the occurances of the former in SVG code that never
touch 'ec' again with the latter. No change in behavior should result
from this refactoring.

svg/SVGLength.cpp:

(WebCore::SVGLength::SVGLength):
(WebCore::SVGLength::setValue):

This method checked the value of the ExceptionCode without first
initializing it to 0. Now it initializes before doing potentially
exception-generating work.

rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::initialBaselineShiftValue):
(WebCore::SVGRenderStyle::initialKerning):
(WebCore::SVGRenderStyle::initialStrokeDashOffset):
(WebCore::SVGRenderStyle::initialStrokeWidth):

svg/SVGAnimatedLength.cpp:

(WebCore::sharedSVGLength):
(WebCore::SVGAnimatedLengthAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):

svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):

svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::textLengthAnimated):

svg/animation/SVGSMILElement.cpp:

(WebCore::constructQualifiedName):

Replace the above pattern with ASSERT_NO_EXCEPTION.

4:45 AM Changeset in webkit [142260] by akling@apple.com

2 edits in trunk/Source/JavaScriptCore

JSC: Lower minimum PropertyTable size.
<http://webkit.org/b/109247>

Reviewed by Darin Adler.

Lower the minimum table size for PropertyTable from 16 to 8.
3.32 MB progression on Membuster3 (a ~13% reduction in memory used by PropertyTables.)

runtime/PropertyMapHashTable.h:

(PropertyTable):
(JSC::PropertyTable::sizeForCapacity):

4:42 AM Changeset in webkit [142259] by vsevik@chromium.org

13 edits in trunk

Web Inspector: Replace workspace with project in UISourceCode constructor.
https://bugs.webkit.org/show_bug.cgi?id=109256

Reviewed by Alexander Pavlov.

Source/WebCore:

Replaced workspace with project in UISourceCode constructor since every UISourceCode
operation is delegated to project anyway.

inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.project):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype.requestOriginalContent):
(WebInspector.UISourceCode.prototype._commitContent):
(WebInspector.UISourceCode.prototype.searchInContent):

inspector/front-end/Workspace.js:

(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype.requestFileContent):
(WebInspector.Project.prototype.setFileContent):
(WebInspector.Project.prototype.searchInFileContent):

LayoutTests:

inspector/debugger/breakpoint-manager-expected.txt:
inspector/debugger/breakpoint-manager.html:
inspector/debugger/script-formatter-search.html:
inspector/debugger/scripts-file-selector.html:
inspector/debugger/scripts-panel.html:
inspector/debugger/scripts-sorting.html:
inspector/debugger/ui-source-code-display-name.html:
inspector/debugger/ui-source-code.html:
inspector/uisourcecode-revisions.html:

4:39 AM Changeset in webkit [142258] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r142205.

4:22 AM Changeset in webkit [142257] by schenney@chromium.org

4 edits in trunk

Remove Skia code suppressions

Unreviewed enabling of existing optimizations

Removing all skia_webkit.gyp code suppressions and adding expectations
for the failures.

Source/WebKit/chromium:

skia_webkit.gyp:

LayoutTests:

platform/chromium/TestExpectations:

4:10 AM Changeset in webkit [142256] by caio.oliveira@openbossa.org

2 edits in trunk/Tools

Update my entries in the watchlist

Unreviewed.

Scripts/webkitpy/common/config/watchlist:

4:08 AM Changeset in webkit [142255] by schenney@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Adjusting expectations for two failures.

Unreviewed Chromium expectations

platform/chromium/TestExpectations:

3:58 AM Changeset in webkit [142254] by Patrick Gansterer

2 edits in trunk/Source/WebCore

Build fix for Windows after r141981.

platform/network/win/ResourceHandleWin.cpp:

(WebCore::ResourceHandle::loadResourceSynchronously):

3:51 AM Changeset in webkit [142253] by jochen@chromium.org

7 edits in trunk/Tools

[chromium] copy normalizeLayoutTestURL code to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109269

Reviewed by Kent Tamura.

The method doesn't have any external dependencies, so there's no reason
it should be on the delegate. It's still required by TestShell, however,
by making a copy, we can avoid implementing this in content shell.

DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestDelegate):

DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:

(WebTestRunner::WebPermissions::allowImage):
(WebTestRunner::WebPermissions::allowScriptFromSource):

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::windowCount):

DumpRenderTree/chromium/TestShell.h:
DumpRenderTree/chromium/WebViewHost.cpp:
DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

3:45 AM Changeset in webkit [142252] by rakuco@webkit.org

1 edit in trunk/Tools/MiniBrowser/efl/main.c

Unreviewed, forced commit to trigger an EFL bot cycle

3:15 AM Changeset in webkit [142251] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Unreviewed, rolling out r141695 and r141697.
http://trac.webkit.org/changeset/141695
http://trac.webkit.org/changeset/141697
https://bugs.webkit.org/show_bug.cgi?id=109279

broke on-disk buffering for http(s) media (Requested by philn
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-08

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::load):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcGetProtocols):
(webKitWebSrcSetUri):

2:17 AM Changeset in webkit [142250] by commit-queue@webkit.org

37 edits in trunk/Source

[v8] isolate parameter added to all v8::peristent calls
https://bugs.webkit.org/show_bug.cgi?id=109268

Patch by Dan Carney <dcarney@google.com> on 2013-02-08
Reviewed by Kentaro Hara.

Source/WebCore:

No new tests. No change in functionality.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateDomainSafeFunctionGetter):
(GenerateNamedConstructorCallback):
(GenerateImplementation):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::GetRawTemplate):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::V8TestActiveDOMObject::GetRawTemplate):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetRawTemplate):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetRawTemplate):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::GetRawTemplate):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetRawTemplate):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::GetRawTemplate):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetRawTemplate):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::GetRawTemplate):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetRawTemplate):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::GetRawTemplate):

bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::GetRawTemplate):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetRawTemplate):

bindings/v8/DOMWrapperMap.h:

(WebCore::DOMWrapperMap::clear):

bindings/v8/DOMWrapperWorld.cpp:

(WebCore::isolatedWorldWeakCallback):
(WebCore::DOMWrapperWorld::makeContextWeak):

bindings/v8/NPV8Object.cpp:

(WebCore::freeV8NPObject):
(WebCore::npCreateV8ScriptObject):

bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::~ScheduledAction):

bindings/v8/ScopedPersistent.h:

(WebCore::ScopedPersistent::ScopedPersistent):
(WebCore::ScopedPersistent::set):
(WebCore::ScopedPersistent::clear):

bindings/v8/ScriptWrappable.h:

(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::disposeWrapper):
(WebCore::ScriptWrappable::weakCallback):

bindings/v8/V8Binding.cpp:

(WebCore::createRawTemplate):

bindings/v8/V8Binding.h:

(WebCore):

bindings/v8/V8GCController.cpp:

(WebCore::gcTree):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):

bindings/v8/V8GCController.h:

(V8GCController):

bindings/v8/V8HiddenPropertyName.cpp:

(WebCore::V8HiddenPropertyName::createString):

bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

bindings/v8/V8NPObject.cpp:

(WebCore::V8NPTemplateMap::dispose):
(WebCore::npObjectGetProperty):
(WebCore::createV8ObjectForNPObject):

bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::dispose):
(WebCore::V8PerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8PerContextData::constructorForTypeSlowCase):

bindings/v8/V8ValueCache.cpp:

(WebCore::makeExternalString):

bindings/v8/WrapperTypeInfo.h:

(WebCore::WrapperConfiguration::configureWrapper):

bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::wrapInShadowObject):

bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::V8HTMLImageElementConstructor::GetTemplate):

bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::WeakReferenceCallback):
(WebCore::createInjectedScriptHostV8Wrapper):

bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAccessorGetter):
(WebCore::V8Location::replaceAccessorGetter):
(WebCore::V8Location::assignAccessorGetter):

Source/WebKit/chromium:

tests/WebFrameTest.cpp:

1:56 AM Changeset in webkit [142249] by rakuco@webkit.org

2 edits in trunk/Tools

[EFL] Make the Performance bot also build WebKit.
https://bugs.webkit.org/show_bug.cgi?id=109273

Reviewed by Philippe Normand.

There has not been much benefit in fetching binaries compiled by
another bot; it makes the build bot take 6 to 7 minutes to upload
the binaries to build.webkit.org, we need to manually override
LD_LIBRARY_PATH to find the compiled libraries and still have
other path-related problems.

Since we have enough horsepower in the perf bot, let's experiment
with building WebKit there instead.

BuildSlaveSupport/build.webkit.org-config/config.json:

1:34 AM Changeset in webkit [142248] by tkent@chromium.org

41 edits in trunk/Source/WebCore

Adjust usage of ENABLE flags to enable whole content
https://bugs.webkit.org/show_bug.cgi?id=109270

Reviewed by Eric Seidel.

Our common usage of ENABLE flags to enable whole content of files is:

For .cpp files:

#include "config.h"
#if ENABLE(FOOBAR)
#include "FooBar.h"

For .h files:

#ifndef FooBar_h
#define FooBar_h
#if ENABLE(FOOBAR)

Fix files which have uncommon usage, and fix CodeGeneratorV8.pm so that
it generates the common pattern. Note that CodeGeneratorJS.pm already
generates code in this order.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeaderContentHeader):
(GenerateImplementationContentHeader):

bindings/scripts/test/V8/V8TestCallback.cpp:
bindings/scripts/test/V8/V8TestCallback.h:
bindings/scripts/test/V8/V8TestInterface.cpp:
bindings/scripts/test/V8/V8TestInterface.h:
bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
html/BaseMultipleFieldsDateAndTimeInputType.h:
html/ColorInputType.cpp:
html/ColorInputType.h:
html/DateInputType.cpp:
html/DateTimeInputType.cpp:
html/DateTimeInputType.h:
html/DateTimeLocalInputType.cpp:
html/HTMLAudioElement.cpp:
html/HTMLAudioElement.h:
html/HTMLDataListElement.cpp:
html/HTMLDialogElement.cpp:
html/HTMLDialogElement.h:
html/HTMLMediaElement.cpp:
html/HTMLMediaElement.h:
html/HTMLMeterElement.cpp:
html/HTMLProgressElement.cpp:
html/HTMLSourceElement.cpp:
html/HTMLSourceElement.h:
html/HTMLTrackElement.cpp:
html/HTMLTrackElement.h:
html/HTMLVideoElement.cpp:
html/HTMLVideoElement.h:
html/MonthInputType.cpp:
html/TimeInputType.cpp:
html/WeekInputType.cpp:
html/shadow/DateTimeFieldElement.h:
html/shadow/DetailsMarkerControl.cpp:
html/shadow/MeterShadowElement.cpp:
html/shadow/ProgressShadowElement.cpp:
rendering/RenderDetailsMarker.cpp:
rendering/RenderInputSpeech.cpp:
rendering/RenderMeter.cpp:
rendering/RenderProgress.cpp:

1:12 AM Changeset in webkit [142247] by mkwst@chromium.org

26 edits in trunk/Source/WebCore

Replace ExceptionCode assertions with ASSERT_NO_EXCEPTION macro.
https://bugs.webkit.org/show_bug.cgi?id=109044

Reviewed by Darin Adler.

The pattern:

ExceptionCode ec = 0;
methodThatGeneratesException(ec);
ASSERT(!ec);

is more clearly and succinctly written as:

methodThatGeneratesException(ASSERT_NO_EXCEPTION);

This patch replaces the occurances of the former that never touch 'ec'
again with the latter. It does the same for 'ASSERT(ec == 0);' (and, as
a drive-by, replaces 'ASSERT(ec == 0)' with 'ASSERT(!ec)' in places
where it does indeed matter that 'ec' get set properly.

No change in behavior should result from this refactoring.

dom/ContainerNode.cpp:

(WebCore::ContainerNode::takeAllChildrenFrom):

dom/Document.cpp:

(WebCore::Document::setTitle):

dom/MessagePort.cpp:

(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::disentanglePorts):

editing/DeleteButtonController.cpp:

(WebCore::enclosingDeletableElement):
(WebCore::DeleteButtonController::createDeletionUI):

Replaced inline ASSERT with ASSERT_NO_EXCEPTION.

(WebCore::DeleteButtonController::show):

Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.

editing/EditorCommand.cpp:

(WebCore::unionDOMRanges):

editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment):
(WebCore::ReplacementFragment::removeNode):
(WebCore::ReplacementFragment::insertNodeBefore):
(WebCore::ReplacementFragment::insertFragmentForTestRendering):
(WebCore::ReplacementFragment::restoreAndRemoveTestRenderingNodesToFragment):
(WebCore::ReplaceSelectionCommand::insertAsListItems):

editing/SplitTextNodeCommand.cpp:

(WebCore::SplitTextNodeCommand::doUnapply):

editing/TextIterator.cpp:

(WebCore::CharacterIterator::range):
(WebCore::BackwardsCharacterIterator::range):
(WebCore::TextIterator::rangeFromLocationAndLength):
(WebCore::collapsedToBoundary):

editing/htmlediting.cpp:

(WebCore::createTabSpanElement):

editing/mac/EditorMac.mm:

(WebCore::Editor::fontForSelection):
(WebCore::Editor::fontAttributesForSelectionStart):

editing/markup.cpp:

(WebCore::createMarkup):
(WebCore::trimFragment):
(WebCore::createFragmentFromMarkupWithContext):
(WebCore::fillContainerFromString):
(WebCore::createFragmentFromText):
(WebCore::createFragmentFromNodes):

html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree):

Replaced inline ASSERT with ASSERT_NO_EXCEPTION.

html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):

Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updatePlaceholderText):

html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::indexForVisiblePosition):
(WebCore::HTMLTextFormControlElement::setInnerTextValue):

html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::updatePlaceholderText):

html/ValidationMessage.cpp:

(WebCore::ValidationMessage::buildBubbleTree):

html/shadow/MediaControlElementTypes.cpp:

(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::getCookies):

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::addRule):

loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::dispatchDOMEvent):

page/DOMSelection.cpp:

(WebCore::DOMSelection::deleteFromDocument):

page/DragController.cpp:

(WebCore::prepareClipboardForImageDrag):

rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::visiblePositionForIndex):

Replaced inline ASSERT with ASSERT_NO_EXCEPTION.

1:03 AM Changeset in webkit [142246] by falken@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Adjusting expectations for two hidpi tests.
https://bugs.webkit.org/show_bug.cgi?id=96441

platform/chromium/TestExpectations:

1:00 AM Changeset in webkit [142245] by kadam@inf.u-szeged.hu

3 edits
1 delete in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing tests.

platform/qt-5.0/fast/js/global-constructors-expected.txt: Removed.
platform/qt/TestExpectations:
platform/qt/fast/js/global-constructors-expected.txt: Added after r142149.

12:57 AM Changeset in webkit [142244] by commit-queue@webkit.org

4 edits in trunk/LayoutTests

[EFL] Mark some tests as passing with incorrect expectations
https://bugs.webkit.org/show_bug.cgi?id=109173

Unreviewed EFL gardening.

Add new category for TestExpectations: PASSING TESTS WITH INCORRECT EXPECTATIONS.

Currently, the tests are passing with their generated incorrect expectations.
It should be checked if the test starts failing. It means, the test can be passing now.

Below tests are marked as passing tests with incorrect expectations.

fast/forms/basic-textareas-quirks.html
fast/forms/input-disabled-color.html
fast/forms/input-readonly-dimmed.html
fast/forms/listbox-hit-test-zoomed.html
fast/forms/menulist-narrow-width.html
fast/forms/menulist-style-color.html
fast/forms/plaintext-mode-2.html
fast/forms/search-cancel-button-style-sharing.html
fast/forms/search-rtl.html
fast/forms/select-baseline.html
fast/forms/select-style.html
fast/forms/zoomed-controls.html

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-08

platform/efl-wk1/TestExpectations:
platform/efl-wk2/TestExpectations:
platform/efl/TestExpectations:

12:25 AM Changeset in webkit [142243] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Web Inspector: disable profile type switching while profile in progress
https://bugs.webkit.org/show_bug.cgi?id=109178

Patch by Alexei Filippov <alph@chromium.org> on 2013-02-08
Reviewed by Yury Semikhatsky.

Disables profile type selection controls when a profiling session
is in progress.

inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):

inspector/front-end/ProfileLauncherView.js:

(WebInspector.ProfileLauncherView.prototype._updateControls):

inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.toggleRecordButton):

12:24 AM Changeset in webkit [142242] by loislo@chromium.org

2 edits in trunk/Source/WTF

Web Inspector: Native Memory Instrumentation: reportBaseAddress needs to be called after the reportNode. So it may reuse the node index for the real address.
https://bugs.webkit.org/show_bug.cgi?id=109051

Reviewed by Yury Semikhatsky.

wtf/MemoryInstrumentation.cpp:

(WTF::MemoryInstrumentation::WrapperBase::processPointer):

12:18 AM Changeset in webkit [142241] by loislo@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: adjust chunk transfer size for better speed.
https://bugs.webkit.org/show_bug.cgi?id=109263

Reviewed by Yury Semikhatsky.

The chunk size is changed from 100 to 10000.
addString counts only first 256 symbols of the string.o

inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::pushUpdateIfNeeded):
(WebCore::HeapGraphSerializer::addString):

inspector/front-end/NativeMemorySnapshotView.js:

12:05 AM Changeset in webkit [142240] by haraken@chromium.org

9 edits in trunk

Support a relatedTarget attribute on focus/blur events
https://bugs.webkit.org/show_bug.cgi?id=109176

Reviewed by Ojan Vafai.

In bug 76216, we supported a relatedTarget attribute on
focusin/focusout events. We should also support it on focus/blur events.

See http://lists.w3.org/Archives/Public/www-dom/2012OctDec/0061.html
for the www-dom discussion.

Source/WebCore:

Test: fast/dom/shadow/shadow-boundary-events.html

fast/events/related-target-focusevent.html

dom/EventDispatchMediator.cpp:

(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):

dom/EventDispatchMediator.h:

(FocusEventDispatchMediator):
(BlurEventDispatchMediator):

dom/Node.cpp:

(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchFocusEvent):
(WebCore::Node::dispatchBlurEvent):

LayoutTests:

fast/dom/shadow/shadow-boundary-events-expected.txt:
fast/dom/shadow/shadow-boundary-events.html:
fast/events/related-target-focusevent-expected.txt:
fast/events/related-target-focusevent.html:

Feb 7, 2013:

11:58 PM Changeset in webkit [142239] by yurys@chromium.org

13 edits in trunk

Web Inspector: reduce number of native memory instrumentation categories
https://bugs.webkit.org/show_bug.cgi?id=109146

Reviewed by Pavel Feldman.

Source/WebCore:

Merged some of memory instrumentation categories.

dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):

inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

platform/PlatformMemoryInstrumentation.cpp:

(WebCore):

LayoutTests:

Updated tests to use new memory categories.

inspector-protocol/nmi-webaudio-expected.txt:
inspector-protocol/nmi-webaudio-leak-test-expected.txt:
inspector-protocol/nmi-webaudio-leak-test.html:
inspector-protocol/nmi-webaudio.html:
inspector/profiler/memory-instrumentation-cached-images-expected.txt:
inspector/profiler/memory-instrumentation-cached-images.html:
inspector/profiler/memory-instrumentation-canvas-expected.txt:
inspector/profiler/memory-instrumentation-canvas.html:

11:47 PM Changeset in webkit [142238] by falken@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Flakiness on table-cell-before-after-content-around-table-row.html
https://bugs.webkit.org/show_bug.cgi?id=109262

An assert is sometimes hit in WebCore::RenderTableCell::styleDidChange.

platform/chromium/TestExpectations:

11:38 PM Changeset in webkit [142237] by jochen@chromium.org

31 edits
3 copies in trunk/Tools

[chromium] turn TestRunner library into a component build
https://bugs.webkit.org/show_bug.cgi?id=108466

Reviewed by Adam Barth.

To achieve this, we need to drop all dependencies on WTF.

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
DumpRenderTree/chromium/TestRunner/public/WebTask.h:
DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):

DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:

(AccessibilityUIElementList):

DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:

(WebTestRunner::CppBoundClass::~CppBoundClass):
(WebTestRunner::CppBoundClass::invoke):
(WebTestRunner::CppBoundClass::getProperty):
(WebTestRunner::CppBoundClass::setProperty):
(WebTestRunner::CppBoundClass::bindCallback):
(WebTestRunner::CppBoundClass::bindGetterCallback):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::getAsCppVariant):

DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:

(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):

DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:

(WebTestRunner::CppVariant::toString):
(WebTestRunner::CppVariant::toInt32):
(WebTestRunner::CppVariant::toDouble):
(WebTestRunner::CppVariant::toBoolean):
(WebTestRunner::CppVariant::toStringVector):
(WebTestRunner::CppVariant::invoke):
(WebTestRunner::CppVariant::invokeDefault):

DumpRenderTree/chromium/TestRunner/src/CppVariant.h:

(CppVariant):

DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::reset):
(WebTestRunner::EventSender::mouseDown):
(WebTestRunner::EventSender::mouseUp):
(WebTestRunner::EventSender::mouseMoveTo):
(WebTestRunner::EventSender::keyDown):
(WebTestRunner::EventSender::dispatchMessage):
(WebTestRunner::EventSender::leapForward):
(WebTestRunner::EventSender::replaySavedEvents):
(WebTestRunner::makeMenuItemStringsFor):
(WebTestRunner::EventSender::contextClick):
(WebTestRunner::EventSender::beginDragWithFiles):
(WebTestRunner::EventSender::addTouchPoint):
(WebTestRunner::EventSender::releaseTouchPoint):
(WebTestRunner::EventSender::updateTouchPoint):
(WebTestRunner::EventSender::cancelTouchPoint):
(WebTestRunner::EventSender::sendCurrentTouchEvent):
(WebTestRunner::EventSender::gestureEvent):

DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:

(WebTestRunner::NativeKeyCodeForWindowsKeyCode):

DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:

(WebTestRunner::MockGrammarCheck::checkGrammarOfString):
(WebTestRunner):

DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:

(WebTestRunner):
(MockGrammarCheck):

DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:

(WebTestRunner::MockSpellCheck::spellCheckWord):
(WebTestRunner::MockSpellCheck::initializeIfNeeded):
(WebTestRunner):

DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:

(MockSpellCheck):

DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:

(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):

DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.

(isASCIIAlpha):
(isNotASCIIAlpha):

DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):

DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:

(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):

DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:

(TestPlugin):

DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
(WebTestRunner::TestRunner::WorkQueue::processWork):
(WebTestRunner::TestRunner::WorkQueue::reset):
(WebTestRunner::TestRunner::WorkQueue::addWork):
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::policyDelegateDone):
(WebTestRunner::TestRunner::findString):
(WebTestRunner::TestRunner::setTextSubpixelPositioning):
(WebTestRunner::TestRunner::overridePreference):
(WebTestRunner::TestRunner::deliverWebIntent):
(WebTestRunner::TestRunner::setBackingScaleFactor):
(WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
(WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
(WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
(WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):

DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):

DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:

(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):

DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):

DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:

(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):

DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):

DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
(WebTestRunner::WebTestProxyBase::spellCheckClient):
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):

DumpRenderTree/chromium/TestRunner/src/config.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.

11:35 PM Changeset in webkit [142236] by mkwst@chromium.org

5 edits in trunk

Reviewed by Eric Seidel.

Source/WebCore:

Seamless documents currently render incorrectly when their content fills
the width of the container into which they're placed. Because FrameView
assumes that the container's size is properly set before the first pass
of layout, vertical scrollbars are incorrectly forced onto seamless
content, because seamless sets the container's height to 0 before
handing it off to FrameView for layout. The scrollbars make the
available width for the seamless document ~15px smaller than it should
be, resulting in content getting bumped to the next line.

This patch special-cases FrameView::calculateScrollbarModesForLayout in
order to force scrollbars off for seamless documents with a full visible
height of 0px. Once the layout pass has grabbed the content height and
applied it to the visible height, scrollbars will again be applicable.

The change should be covered by rebaselines for the newly-passing
results in fast/frame/seamless-{float,inline}.html

page/FrameView.cpp:

(WebCore::FrameView::calculateScrollbarModesForLayout):

If we're rendering a seamless document, and the full visible height
is 0, and the vertical scrollbar would otherwise be ScrollbarAuto,
then force ScrollbarAlwaysOff.

LayoutTests:

fast/frames/seamless/seamless-float-expected.txt:
fast/frames/seamless/seamless-inline-expected.txt:

Rebaseline the now-passing bits of these tests.

11:34 PM Changeset in webkit [142235] by alokp@chromium.org

2 edits
2 copies
9 adds in trunk/LayoutTests

Unreviewed rebaseline.

platform/mac-lion/compositing/visible-rect/iframe-no-layers-expected.txt: Copied from LayoutTests/platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt.
platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt:
platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt: Copied from LayoutTests/platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt.
platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt: Added.
platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt: Added.
platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt: Added.
platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt: Added.
platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt: Added.
platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt: Added.

11:18 PM Changeset in webkit [142234] by tkent@chromium.org

3 edits
2 adds in trunk

document.activeElement should not return a non-focusable element
https://bugs.webkit.org/show_bug.cgi?id=86707

Reviewed by Hajime Morita.

Source/WebCore:

This is based on a patch by Arpita Bahuguna.

Test: fast/dom/HTMLDocument/set-focus-on-valid-element.html

dom/Document.cpp:

(WebCore::Document::setFocusedNode):
Added check for verifying that the node to be focused is
focusable. However, this check should be skipped for HTMLPlugInElement
because it has special behavior.

LayoutTests:

fast/dom/HTMLDocument/set-focus-on-valid-element-expected.txt: Added.
fast/dom/HTMLDocument/set-focus-on-valid-element.html: Added.

This test verifies that document.activeElement does not return an
invalid or non-focusable element.

11:08 PM Changeset in webkit [142233] by zandobersek@gmail.com

2 edits in trunk/Tools

Unreviewed followup to r142232.

Work around a bug in jhbuild that was incorrectly composing the source
package URL by adjusting slightly the repository and module paths.

gtk/jhbuild.modules:

10:46 PM Changeset in webkit [142232] by zandobersek@gmail.com

2 edits in trunk/Tools

Use a mirror for the sourceware.org repo used in jhbuild

Unreviewed.

The ftp://sourceware.org site is down, causing errors when running jhbuild
and subsequently failing complete builds on the builders. Use the mirrors.kernel.org
mirror to get sources for the desired libffi dependency.

gtk/jhbuild.modules:

10:42 PM Changeset in webkit [142231] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Web Inspector: Fix front-end compilation warnings related to WebInspector.SidebarPane
https://bugs.webkit.org/show_bug.cgi?id=109259

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-07
Reviewed by Vsevolod Vlasov.

inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.Proxy):

inspector/front-end/SidebarPane.js:

10:41 PM Changeset in webkit [142230] by ddkilzer@apple.com

2 edits in trunk/Source/WTF

Fix #endif comment from r142163 and r142183

wtf/MainThread.h:

(WTF): s/PLATFORM/USE/

10:15 PM Changeset in webkit [142229] by falken@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening. Two webgl/conformance/context tests are timing out.

See https://bugs.webkit.org/show_bug.cgi?id=109114

platform/chromium/TestExpectations:

10:05 PM Changeset in webkit [142228] by zoltan@webkit.org

1 edit
7 deletes in trunk/LayoutTests

Cleaning up after r142208
https://bugs.webkit.org/show_bug.cgi?id=109228

Unreviewed.

The commit-queue didn't remove these files for some reason. Removing them manually.

platform/chromium-mac-lion/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
platform/chromium-mac/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
platform/chromium-win/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.

9:47 PM Changeset in webkit [142227] by charles.wei@torchmobile.com.cn

2 edits in trunk/Source/WebKit/blackberry

webpage needs null check in BackingStore::setCurrentBackingStoreOwner
https://bugs.webkit.org/show_bug.cgi?id=109253

Reviewed by George Staikos.

Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::setCurrentBackingStoreOwner):

9:37 PM Changeset in webkit [142226] by haraken@chromium.org

3 edits in trunk/Source/WebCore

[V8] enum V8HiddenPropertyCreationType is not used
https://bugs.webkit.org/show_bug.cgi?id=109250

Reviewed by Adam Barth.

V8HiddenPropertyCreationType is always NewSymbol. We can remove the enum.

No tests. No change in behavior.

bindings/v8/V8HiddenPropertyName.cpp:

(WebCore::hiddenReferenceName):

bindings/v8/V8HiddenPropertyName.h:

(WebCore):

9:32 PM Changeset in webkit [142225] by commit-queue@webkit.org

11 edits in trunk/Source

Unreviewed, rolling out r142212.
http://trac.webkit.org/changeset/142212
https://bugs.webkit.org/show_bug.cgi?id=109255

Causes ASSERT(!m_installed) on launch (Requested by smfr on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-07

Source/WebCore:

WebCore.exp.in:
platform/MemoryPressureHandler.cpp:

(WebCore):
(WebCore::MemoryPressureHandler::respondToMemoryPressure):

platform/MemoryPressureHandler.h:

(MemoryPressureHandler):

platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::respondToMemoryPressure):

Source/WebKit/mac:

WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(WebInstallMemoryPressureHandler):

Source/WebKit2:

PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::initializeProcess):
(WebKit::PluginProcess::shouldTerminate):

PluginProcess/PluginProcess.h:

(PluginProcess):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

9:03 PM Changeset in webkit [142224] by alokp@chromium.org

5 edits
1 move
4 adds in trunk/LayoutTests

Rebaseline text output for contentOpaque
https://bugs.webkit.org/show_bug.cgi?id=108656

Unreviewed rebaseline.

platform/chromium-mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
platform/chromium/TestExpectations:
platform/chromium/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Renamed from LayoutTests/platform/chromium-win/compositing/visibility/visibility-image-layers-dynamic-expected.txt.
platform/mac/TestExpectations:
platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt: Added.

8:59 PM Changeset in webkit [142223] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

NamedFlowCollection should be a ContextDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=99239

Patch by Hanyee Kim <choco@company100.net> on 2013-02-07
Reviewed by Adam Barth

This patch removes the raw pointer of Document in NamedFlowCollection.
It could be replaced with ContextDestructionObserver.
ContextDestructionObserver has the pointer and clears the pointer
automatically when the document is destroyed.

dom/Document.cpp:

(WebCore::Document::~Document):

dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::NamedFlowCollection):
(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):
(WebCore::NamedFlowCollection::document):
(WebCore):

dom/NamedFlowCollection.h:

(NamedFlowCollection):

8:29 PM Changeset in webkit [142222] by gyuyoung.kim@samsung.com

2 edits in trunk/Source/WebKit2

[EFL][WK2] Remove dead code after r142169
https://bugs.webkit.org/show_bug.cgi?id=109251

Reviewed by Benjamin Poulain.

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):

8:16 PM Changeset in webkit [142221] by dino@apple.com

2 edits in trunk/Source/WebCore

Followup review suggestions from Alexey Proskuryakov on
https://bugs.webkit.org/show_bug.cgi?id=109215

Don't provide a charset on embedded SVG, especially
with incorrect syntax :)

css/mediaControlsQuickTime.css:

(video::-webkit-media-controls-toggle-closed-captions-button):
(video::-webkit-media-controls-closed-captions-track-list li.selected):
(video::-webkit-media-controls-closed-captions-track-list li.selected:hover):

7:01 PM Changeset in webkit [142220] by mary.wu@torchmobile.com.cn

3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Enable non-video element enter/exit fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=108314

Reviewed by Antonio Gomes.

Webkit support non-video element (like div) to enter/exit
fullscreen. We should pass this capability in blackberry porting.

RIM PR 256370, internally reviewed by Max Feil.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::clearDocumentData):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPage::notifyFullScreenVideoExited):
(BlackBerry::WebKit::WebPagePrivate::enterFullscreenForNode):
(BlackBerry::WebKit::WebPagePrivate::exitFullscreenForNode):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::adjustFullScreenElementDimensionsIfNeeded):

Api/WebPage_p.h:

(WebPagePrivate):

6:41 PM Changeset in webkit [142219] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Gtk] RunLoop::run shuold run current thread's run loop.
https://bugs.webkit.org/show_bug.cgi?id=107887

Patch by Seulgi Kim <seulgikim@company100.net> on 2013-02-07
Reviewed by Martin Robinson.

Currently, RunLoop in Gtk can use just main thread's event loop.
But the other ports are implemented to use RunLoop in sub threads.

This patch makes RunLoop constructor create new context, not use default
context.
But in the main thread still uses default context to use main event loop
since there is some codes using glib directly (e.g. in
LayerTreeHostGtk::scheduleLayerFlush).

No new tests. There is no case that uses RunLoop in off the main thread
yet.

platform/gtk/RunLoopGtk.cpp:

(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::run):

6:29 PM Changeset in webkit [142218] by falken@chromium.org

1 edit
1 move in trunk/LayoutTests

Unreviewed gardening. Rebaseline bidi-ignored-for-first-child-inline.html
which was failing on Chromium Mac after r142152.

platform/chromium-mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt: Renamed from LayoutTests/platform/chromium/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt.

6:11 PM Changeset in webkit [142217] by haraken@chromium.org

9 edits in trunk/Source/WebCore

[V8] Move V8DOMWrapper::setNamedHiddenReference() to V8HiddenPropertyName.h
https://bugs.webkit.org/show_bug.cgi?id=109186

Reviewed by Adam Barth.

V8HiddenPropertyName.h is a right place for setNamedHiddenReference().

No tests. No change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):

bindings/v8/V8DOMWrapper.cpp:
bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

bindings/v8/V8HiddenPropertyName.cpp:

(WebCore::V8HiddenPropertyName::hiddenReferenceName):
(WebCore::V8HiddenPropertyName::setNamedHiddenReference):
(WebCore):

bindings/v8/V8HiddenPropertyName.h:

(V8HiddenPropertyName):
(WebCore::V8HiddenPropertyName::V8HiddenPropertyName):

bindings/v8/custom/V8MessageChannelCustom.cpp:

(WebCore::V8MessageChannel::constructorCallbackCustom):

bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

5:42 PM Changeset in webkit [142216] by commit-queue@webkit.org

5 edits in trunk/LayoutTests

Unreviewed, rolling out r142113.
http://trac.webkit.org/changeset/142113
https://bugs.webkit.org/show_bug.cgi?id=109244

tests started failing after r142081 was rolled out in r142166
(Requested by falken on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-07

inspector/profiler/memory-instrumentation-cached-images-expected.txt:
inspector/profiler/memory-instrumentation-cached-images.html:
inspector/profiler/memory-instrumentation-canvas-expected.txt:
inspector/profiler/memory-instrumentation-canvas.html:

5:40 PM Changeset in webkit [142215] by esprehn@chromium.org

10 edits in trunk

getComputedStyle() doesn't report intermediate values during a transition of a pseudo element
https://bugs.webkit.org/show_bug.cgi?id=106535

Reviewed by Ojan Vafai.

Source/WebCore:

Element::computedStyle and CSSComputedStyleDeclaration::getPropertyCSSValue
should use the PseudoElement and it's renderer if they exist so that
querying the computed style while an animation is running returns
the intermediate values.

No new tests, updated existing tests.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::styledNode): Added, returns either the PseudoElement or the Node.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Updated to use styledNode.

css/CSSComputedStyleDeclaration.h:

(CSSComputedStyleDeclaration):

dom/Element.cpp:

(WebCore::Element::computedStyle): Check the PseudoElement, not just the cached pseudo style.

dom/ElementRareData.h:

(WebCore::ElementRareData::pseudoElement): Remove ASSERT_NOT_REACHED so passing other pseudos returns 0.

LayoutTests:

Update tests to also check getComputedStyle during animations and transitions.

fast/css-generated-content/pseudo-animation-expected.txt:
fast/css-generated-content/pseudo-animation.html:
fast/css-generated-content/pseudo-transition-expected.txt:
fast/css-generated-content/pseudo-transition.html:

5:28 PM Changeset in webkit [142214] by tkent@chromium.org

4 edits in trunk

[Chromium-Android] Disable input[type=datetime]
https://bugs.webkit.org/show_bug.cgi?id=107614

Reviewed by Kentaro Hara.

Source/WebKit/chromium:

Reason:
http://lists.webkit.org/pipermail/webkit-dev/2013-January/023404.html

features.gypi:

Disable ENABLE_INPUT_TYPE_DATETIME because of a wrong UI.
We enable it for non-Android ports but the runtime flag for it is
disabled by default. The runtime flag is enabled only in DumpRenderTree.

LayoutTests:

platform/chromium/TestExpectations:

Tetsts in fast/forms/datetime/ fail.

5:23 PM Changeset in webkit [142213] by mark.lam@apple.com

2 edits in trunk/Source/WebCore

Add a comment about how the SQLTransaction state machine works.
https://bugs.webkit.org/show_bug.cgi?id=109243.

Rubber stamped by Anders Carlsson.

No new tests.

Modules/webdatabase/SQLTransactionBackend.cpp:

5:22 PM Changeset in webkit [142212] by barraclough@apple.com

11 edits in trunk/Source

PluginProcess should quit immediately if idle in response to low-memory notifications
https://bugs.webkit.org/show_bug.cgi?id=109103
<rdar://problem/12679827>

Reviewed by Darin Adler.

Source/WebCore:

This patch allows a process to set a custom callback for low memory warnings
(defaulting to the current behaviour, as implemented in releaseMemory).

MemoryPressureHandler::install is currently used for two purposes - it is
called when first initializing a low memory handler for a process, and also
used to reinstall the handler (on a delay) after the notification has occured.
Since reinstallation doesn't change the callback, split these behaviours out -
MemoryPressureHandler::initialize is added to initialization, and accepts a
custom callback, install in made private.

WebCore.exp.in:
- Added export for releaseMemory.
platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::releaseMemory):

Added null implementation for non-Mac builds.

platform/MemoryPressureHandler.h:

(WebCore::MemoryPressureHandler::initialize):

distinguish initialization from reinstallations, allow handler to be set.

(MemoryPressureHandler):

Added m_lowMemoryHandler function pointer member variable.

platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::respondToMemoryPressure):

Call m_lowMemoryHandler instead of releaseMemory.

Source/WebKit/mac:

WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

MemoryPressureHandler::install is now called via MemoryPressureHandler::initialize.

(WebInstallMemoryPressureHandler):

MemoryPressureHandler::install is now called via MemoryPressureHandler::initialize.

Source/WebKit2:

PluginProcess now initializes a MemoryPressureHandler for the process, providing
a custom callback which will call terminate if appropriate (if the plugin is not
currently in use).

PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::lowMemoryHandler):

Custom callback to terminate if appropriate.

(WebKit::PluginProcess::initializeProcess):

Initialize the MemoryPressureHandler.

(WebKit::PluginProcess::shouldTerminate):

This method now also needs to be callable in situations where it might return false.

PluginProcess/PluginProcess.h:

(PluginProcess):

Added declaration for lowMemoryHandler.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

MemoryPressureHandler::install is now called via MemoryPressureHandler::initialize.

5:13 PM Changeset in webkit [142211] by jpfau@apple.com

2 edits in trunk/LayoutTests

[Mac] Unreviewed, skip crashing test

platform/mac/TestExpectations:

5:07 PM Changeset in webkit [142210] by roger_fong@apple.com

4 edits in trunk/Source/WebKit

Unreviewed. Corrections the exports definition file.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
WebKit.vcproj/WebKitExports.def.in:

5:06 PM Changeset in webkit [142209] by haraken@chromium.org

3 edits in trunk/Source/WebCore

[V8] #ifndef NDEBUG is redundant for assertContextHasCorrectPrototype()
https://bugs.webkit.org/show_bug.cgi?id=109167

Reviewed by Andreas Kling.

Given that assertContextHasCorrectPrototype() is anyway empty in a release
build, we don't need to surround it with #ifndef NDEBUG.

No tests. No change in behavior.

bindings/v8/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::assertContextHasCorrectPrototype):

bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolated):

4:59 PM Changeset in webkit [142208] by zoltan@webkit.org

2 edits
1 add
5 deletes in trunk/LayoutTests

[CSS Regions] Turn selecting-text-through-different-region-flows test into a reftest
https://bugs.webkit.org/show_bug.cgi?id=109228

Reviewed by Eric Seidel.

Simplify and turn the test into a reftest, remove the unnecessary expected files.

fast/regions/selecting-text-through-different-region-flows-expected.html: Added.
fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
fast/regions/selecting-text-through-different-region-flows.html:
platform/chromium-linux/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
platform/chromium-mac-lion/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
platform/chromium-win/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
platform/chromium-win/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
platform/efl/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
platform/gtk/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.
platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.png: Removed.
platform/qt/fast/regions/selecting-text-through-different-region-flows-expected.txt: Removed.

4:56 PM Changeset in webkit [142207] by commit-queue@webkit.org

7 edits in trunk

Makefiles should work for arbitrary SDKs and architectures on Apple ports
https://bugs.webkit.org/show_bug.cgi?id=107863

Patch by David Farler <dfarler@apple.com> on 2013-02-07
Reviewed by Mark Rowe.

Makefile:

Allow SDKROOT, ARCHS outside of $(ARGS).
Setting ARCHS => ONLY_ACTIVE_ARCH=NO.

Makefile.shared: options to webkitdirs based on SDKROOT
Source/Makefile: don't build WebKit2 for iOS

Tools:

DumpRenderTree/Makefile: SDKROOT=iphone* => -target All-iOS
Makefile: Only build some projects for iOS

4:51 PM Changeset in webkit [142206] by commit-queue@webkit.org

3 edits
2 adds in trunk

Chromium: Hang parsing bidi control chars on Mac OS X 10.6
https://bugs.webkit.org/show_bug.cgi?id=108877

This was broken a while ago by:

https://bugs.webkit.org/show_bug.cgi?id=83045

On 10.6, CoreText will not produce any runs covering the
Unicode BiDi RTL mark control char, which causes an infinite
loop in ComplexTextController::indexOfCurrentRun() due to no
run covering the character at offset 0.

This patch fixes that issue by finding the earliest run
explicitly via the minimum stringBegin() index instead of
relying on a run existing that covers offset 0.

Fixes hang on many BiDi wikipedia pages on Chromium/Mac10.6.
Chromium bug: http://crbug.com/167844

Source/WebCore:

New test in the same style as the harfbuzz-buffer-overrun.html
test (in the same folder).

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2013-02-07
Reviewed by Eric Seidel.

Test: fast/text/international/rtl-mark.html

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::indexOfCurrentRun):

LayoutTests:

New test in the same style as harfbuzz-buffer-overrun.html
in the same folder.

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2013-02-07
Reviewed by Eric Seidel.

fast/text/international/rtl-mark-expected.txt: Added.
fast/text/international/rtl-mark.html: Added.

4:37 PM Changeset in webkit [142205] by haraken@chromium.org

12 edits
2 adds in trunk

Implement FocusEvent constructor
https://bugs.webkit.org/show_bug.cgi?id=109170

Reviewed by Adam Barth.

Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm

FocusEvent constructor should be implemented under a DOM4_EVENTS_CONSTRUCTOR
flag, which is enabled on Chromium and Safari.

Source/WebCore:

Test: fast/events/constructors/focus-event-constructor.html

dom/FocusEvent.cpp:

(WebCore::FocusEventInit::FocusEventInit):
(WebCore):
(WebCore::FocusEvent::FocusEvent):

dom/FocusEvent.h:

(FocusEventInit):
(WebCore):
(WebCore::FocusEvent::create):
(FocusEvent):

dom/FocusEvent.idl:
page/DOMWindow.idl:

LayoutTests:

fast/dom/constructed-objects-prototypes-expected.txt:
fast/events/constructors/focus-event-constructor-expected.txt: Added.
fast/events/constructors/focus-event-constructor.html: Added.
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/qt/TestExpectations:
platform/win/TestExpectations:
platform/wincairo/TestExpectations:

4:35 PM Changeset in webkit [142204] by esprehn@chromium.org

6 edits
2 adds in trunk

HTML parser should queue MutationRecords for its operations
https://bugs.webkit.org/show_bug.cgi?id=89351

Reviewed by Eric Seidel.

Source/WebCore:

Generate mutation records inside the parser. This is done by using a
ChildListMutationScope in the ContainerNode::parser* methods and then
adding delivery before each <script> element would be processed by
the parser.

Test: fast/dom/MutationObserver/parser-mutations.html

dom/ContainerNode.cpp:

(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserRemoveChild):
(WebCore::ContainerNode::parserAppendChild):

html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::executeParsingBlockingScript):
(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::execute):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForLoad):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForStylesheets):
(WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing):
(WebCore::HTMLScriptRunner::runScript):

LayoutTests:

Add new test mutation records in the parser and fix shadow-dom.html
test since it used setTimeout and sometimes could observe parser
mutations.

fast/dom/MutationObserver/parser-mutations-expected.txt: Added.
fast/dom/MutationObserver/parser-mutations.html: Added.
fast/dom/MutationObserver/shadow-dom-expected.txt:
fast/dom/MutationObserver/shadow-dom.html:

4:34 PM Changeset in webkit [142203] by roger_fong@apple.com

8 edits in trunk

Unreviewed. More VS2010 WebKit solution touchups.

win/tools/vsprops/common.props:

Move an ignored warning from a project to common properties.

WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj:
WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.filters:

Make WebKitExports.def.in be treated as a custom build file so that changes to it cause the exports to be rebuilt.

JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.filters:

Make JavaScriptCoreExports.def.in be treated as a custom build file so that changes to it cause the exports to be rebuilt.

4:30 PM Changeset in webkit [142202] by haraken@chromium.org

2 edits in trunk/Source/WebCore

Fix FIXMEs in WindowFeatures.h
https://bugs.webkit.org/show_bug.cgi?id=109151

Reviewed by Adam Barth.

FIXME: We can delete this constructor once V8 showModalDialog is changed to use DOMWindow.

This FIXME is not right. The WindowFeatures() constructor is used by
other ports too (e.g. WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp).
So we should remove the FIXME.

FIXME: We can make these functions private non-member functions once V8 showModalDialog is changed to use DOMWindow.

Given that V8 now uses DOMWindow in showModalDialog(), we can make the
methods private.

No tests. No change in behavior.

page/WindowFeatures.h:

(WebCore):
(WebCore::WindowFeatures::WindowFeatures):
(WindowFeatures):

4:27 PM Changeset in webkit [142201] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Fix build warning after r142017
https://bugs.webkit.org/show_bug.cgi?id=109119

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-07
Reviewed by Alexey Proskuryakov.

Use UNUSED_PARAM macro to fix -Wunused-parameter build warning.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getPluginPath):

4:24 PM Changeset in webkit [142200] by abarth@webkit.org

4 edits
4 adds in trunk

fast/parser/document-write-noscript.html fails for threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=109237

Reviewed by Eric Seidel.

Source/WebCore:

If there are multiple calls to document.write in an external script, we
need to wait for them all to complete before invalidating the
speculative tokens. Instead of doing this when we unwind the
document.write call stack, we do this when we're about to resume
parsing after script execution.

Test: fast/parser/document-write-basic.html

html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):

LayoutTests:

This tests basic document.write functionality. There doesn't appear to
be another fast/parser test that covers this basic case (although it's
convered in some more complicated test cases incidentally.)

fast/parser/document-write-basic-expected.txt: Added.
fast/parser/document-write-basic.html: Added.

4:18 PM Changeset in webkit [142199] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix build when compiling with css3-text and css3-conditional-rules feature flags enabled.
https://bugs.webkit.org/show_bug.cgi?id=109217

Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-02-07
Reviewed by Benjamin Poulain.

css/InspectorCSSOMWrappers.cpp:

(WebCore::InspectorCSSOMWrappers::collect):

4:06 PM Changeset in webkit [142198] by tkent@chromium.org

5 edits
6 adds in trunk

REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute
https://bugs.webkit.org/show_bug.cgi?id=109136

Patch by Keishi Hattori <keishi@webkit.org> on 2013-02-07
Reviewed by Kent Tamura.

Source/WebCore:

Calendar picker was using the "Clear" button to calculate the window width.
Since it doesn't exist when the input element has a required attribute,
it was throwing an error. This patch fixes the width calculating logic.

Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html

platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html

Resources/pagepopups/calendarPicker.css:

(.today-clear-area):

Resources/pagepopups/calendarPicker.js:

(CalendarPicker.prototype.fixWindowSize): Fixing the logic to calculate
the width. We don't want to use clear button because it doesn't exist
when a value is required.

LayoutTests:

platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.txt: Added.
platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html: Added.
platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.txt: Added.
platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html: Added.
platform/chromium/TestExpectations:

4:03 PM Changeset in webkit [142197] by tdanderson@chromium.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Flings should not bubble up to enclosing scrollables when main-thread touch scrolling
https://bugs.webkit.org/show_bug.cgi?id=108719

Reviewed by Eric Seidel.

In the event of a main-thread touch fling, dispatch a series of
GestureScrollUpdateWithoutPropagation events defined in
https://bugs.webkit.org/show_bug.cgi?id=108849 (instead of
GestureScrollUpdate events) so that the fling does not
propagate to enclosing scrollables.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::scrollBy):

3:59 PM Changeset in webkit [142196] by Lucas Forschler

1 edit in branches/safari-536.28-branch/LayoutTests/platform/mac-wk2/Skipped

Skip test -> <rdar://problem/12968012>

3:58 PM Changeset in webkit [142195] by tdanderson@chromium.org

4 edits
6 adds in trunk

Non-scrollable divs and non-scrollable iframes can scroll with touch
https://bugs.webkit.org/show_bug.cgi?id=109087

Reviewed by Eric Seidel.

Source/WebCore:

Tests: fast/events/touch/gesture/touch-gesture-noscroll-div.html

fast/events/touch/gesture/touch-gesture-noscroll-iframe.html

When finding a candidate for a scrollable node in
EventHandler::handleGestureScrollUpdate(), select the document node
if it is reached before any scrollable element when walking up the DOM
tree. Also ensure that calling RenderLayer::scrollBy() for a document
node does not result in scrolling if the element is not scrollable.

page/EventHandler.cpp:

(WebCore::closestScrollableNodeCandidate):
(WebCore::EventHandler::handleGestureScrollUpdate):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollBy):

LayoutTests:

Two new layout tests added to demonstrate that the changes to
RenderLayer::scrollBy() and closestScrollableNodeCandidate() in
EventHandler.cpp are both necessary to ensure that non-scrollable
divs and non-scrollable iframes cannot be scrolled with touch.

fast/events/touch/gesture/touch-gesture-noscroll-div-expected.txt: Added.
fast/events/touch/gesture/touch-gesture-noscroll-div.html: Added.
fast/events/touch/gesture/touch-gesture-noscroll-iframe-expected.txt: Added.
fast/events/touch/gesture/touch-gesture-noscroll-iframe.html: Added.
platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-div-expected.txt: Added.
platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-iframe-expected.txt: Added.

3:52 PM Changeset in webkit [142194] by mark.lam@apple.com

1 edit
4 adds in trunk/Source/WebCore

Introduce SQLTransactionBackend and SQLTransactionBackendSync [Part 2].
https://bugs.webkit.org/show_bug.cgi?id=109109.

Reviewed by Anders Carlsson.

Adding back the new SQLTransaction and SQLTransactionSync files.

No new tests.

Modules/webdatabase/SQLTransaction.cpp: Added.

(WebCore::SQLTransaction::create):
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::from):

Modules/webdatabase/SQLTransaction.h: Added.

(SQLTransaction):

Modules/webdatabase/SQLTransactionSync.cpp: Added.

(WebCore::SQLTransactionSync::create):
(WebCore::SQLTransactionSync::SQLTransactionSync):
(WebCore::SQLTransactionSync::from):

Modules/webdatabase/SQLTransactionSync.h: Added.

(SQLTransactionSync):

3:49 PM Changeset in webkit [142193] by mark.lam@apple.com

16 edits
4 moves in trunk/Source/WebCore

Introduce SQLTransactionBackend and SQLTransactionBackendSync.
https://bugs.webkit.org/show_bug.cgi?id=109109.

Reviewed by Anders Carlsson.

Renamed SQLTransaction and SQLTransactionSync to SQLTransactionBackend and SQLTransactionBackendSync respectively.
Added back SQLTransaction and SQLTransactionSync as new files, and have their classes extends their respective backends. This is a stop gap measure to keep things working until the front-end and back-end can be properly split. Note: these files will be committed in a subsequent commit to ensure that the patching goes smoothly.
Where needed, I made use of new SQLTransaction::from() and SQLTransactionSync::from() static methods that "get" the front-end transactions from the back-ends. This is also a stop gap measure to keep things working until the proper refactoring is complete.
Fixed up pre-existing style checker violations that are now detected on code that were touched during my renaming.
Added the back-end files to all the build files.

No new tests.

CMakeLists.txt:
GNUmakefile.list.am:
Modules/webdatabase/Database.cpp:

(WebCore::Database::scheduleTransactionStep):

Modules/webdatabase/Database.h:

(Database):

Modules/webdatabase/DatabaseBackend.h:

(DatabaseBackend):

Modules/webdatabase/DatabaseTask.cpp:

(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::DatabaseTransactionTask):

Modules/webdatabase/DatabaseTask.h:

(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::create):
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::transaction):
(DatabaseBackendAsync::DatabaseTransactionTask):

Modules/webdatabase/SQLTransaction.cpp: Removed.
Modules/webdatabase/SQLTransaction.h: Removed.
Modules/webdatabase/SQLTransactionBackend.cpp: Copied from Source/WebCore/Modules/webdatabase/SQLTransaction.cpp.

(WebCore::SQLTransactionBackend::SQLTransactionBackend):
(WebCore::SQLTransactionBackend::~SQLTransactionBackend):
(WebCore::SQLTransactionBackend::executeSQL):
(WebCore::SQLTransactionBackend::enqueueStatement):
(WebCore::SQLTransactionBackend::debugStepName):
(WebCore::SQLTransactionBackend::checkAndHandleClosedOrInterruptedDatabase):
(WebCore::SQLTransactionBackend::performNextStep):
(WebCore::SQLTransactionBackend::performPendingCallback):
(WebCore::SQLTransactionBackend::notifyDatabaseThreadIsShuttingDown):
(WebCore::SQLTransactionBackend::acquireLock):
(WebCore::SQLTransactionBackend::lockAcquired):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):
(WebCore::SQLTransactionBackend::deliverTransactionCallback):
(WebCore::SQLTransactionBackend::scheduleToRunStatements):
(WebCore::SQLTransactionBackend::runStatements):
(WebCore::SQLTransactionBackend::getNextStatement):
(WebCore::SQLTransactionBackend::runCurrentStatement):
(WebCore::SQLTransactionBackend::handleCurrentStatementError):
(WebCore::SQLTransactionBackend::deliverStatementCallback):
(WebCore::SQLTransactionBackend::deliverQuotaIncreaseCallback):
(WebCore::SQLTransactionBackend::postflightAndCommit):
(WebCore::SQLTransactionBackend::deliverSuccessCallback):
(WebCore::SQLTransactionBackend::cleanupAfterSuccessCallback):
(WebCore::SQLTransactionBackend::handleTransactionError):
(WebCore::SQLTransactionBackend::deliverTransactionErrorCallback):
(WebCore::SQLTransactionBackend::cleanupAfterTransactionErrorCallback):

Modules/webdatabase/SQLTransactionBackend.h: Copied from Source/WebCore/Modules/webdatabase/SQLTransaction.h.

(SQLTransactionBackend):

Modules/webdatabase/SQLTransactionBackendSync.cpp: Copied from Source/WebCore/Modules/webdatabase/SQLTransactionSync.cpp.

(WebCore::SQLTransactionBackendSync::SQLTransactionBackendSync):
(WebCore::SQLTransactionBackendSync::~SQLTransactionBackendSync):
(WebCore::SQLTransactionBackendSync::executeSQL):
(WebCore::SQLTransactionBackendSync::begin):
(WebCore::SQLTransactionBackendSync::execute):
(WebCore::SQLTransactionBackendSync::commit):
(WebCore::SQLTransactionBackendSync::rollback):

Modules/webdatabase/SQLTransactionBackendSync.h: Copied from Source/WebCore/Modules/webdatabase/SQLTransactionSync.h.

(SQLTransactionBackendSync):

Modules/webdatabase/SQLTransactionCoordinator.cpp:

(WebCore::getDatabaseIdentifier):
(WebCore::SQLTransactionCoordinator::processPendingTransactions):
(WebCore::SQLTransactionCoordinator::acquireLock):
(WebCore::SQLTransactionCoordinator::releaseLock):
(WebCore::SQLTransactionCoordinator::shutdown):

Modules/webdatabase/SQLTransactionCoordinator.h:

(SQLTransactionCoordinator):
(WebCore::SQLTransactionCoordinator::SQLTransactionCoordinator):
(CoordinationInfo):

Modules/webdatabase/SQLTransactionSync.cpp: Removed.
Modules/webdatabase/SQLTransactionSync.h: Removed.
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:

3:45 PM Changeset in webkit [142192] by tkent@chromium.org

4 edits in trunk/Source/WebKit/chromium

[Chromium] Add a flag to enable native form validation message
https://bugs.webkit.org/show_bug.cgi?id=109134

Reviewed by Adam Barth.

public/WebRuntimeFeatures.h:

(WebRuntimeFeatures): Add enableNativeValidationMessage and
isNativeValidationMessageEnabled.

src/WebRuntimeFeatures.cpp:

(WebKit): Add nativeValidationMessageEnabled.
(WebKit::WebRuntimeFeatures::enableNativeValidationMessage): Added.
(WebKit::WebRuntimeFeatures::isNativeValidationMessageEnabled): Addedd.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
Fill Page::PageClients::validationMessageClient if the flag is true.

3:42 PM Changeset in webkit [142191] by dino@apple.com

6 edits in trunk/Source/WebCore

Use new speech bubble artwork for captions menu button
https://bugs.webkit.org/show_bug.cgi?id=109215

Reviewed by Eric Carlson.

Rather than call into RenderTheme to display this button, embed artwork
into the CSS. This means we can remove some uncalled methods in
RenderTheme.

css/mediaControlsQuickTime.css:

(video::-webkit-media-controls-toggle-closed-captions-button): New background image using SVG.

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint): Don't call the specific painter for the CC button.

rendering/RenderTheme.h: Remove unused function.
rendering/RenderThemeMac.h: Ditto.
rendering/RenderThemeMac.mm: Ditto.

3:32 PM Changeset in webkit [142190] by Michelangelo De Simone

4 edits
2 adds in trunk

[CSS Shaders] Add the last blending step
https://bugs.webkit.org/show_bug.cgi?id=104012

Source/WebCore:

The resulting blended color in mix() is now weighted according to
the original element's backdrop alpha value.

Reviewed by Dean Jackson.

Test: css3/filters/custom/custom-filter-blend-fractional-destination-alpha.html

platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::rewriteMixFragmentShader):

LayoutTests:

Added a test to check the correct blending in presence of a transparent backdrop.

Reviewed by Dean Jackson.

css3/filters/custom/custom-filter-blend-fractional-destination-alpha-expected.html: Added.
css3/filters/custom/custom-filter-blend-fractional-destination-alpha.html: Added.
platform/mac/TestExpectations: This test is currently skipped on Mac for slight color

differences, please see the relevant bug: http://webkit.org/b/107487

3:29 PM Changeset in webkit [142189] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

Fix two exports of WebCore symbols on iOS
https://bugs.webkit.org/show_bug.cgi?id=109238

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07
Reviewed by David Kilzer.

WebCore.exp.in: Export wkCTFontTransformGlyphs but not

wkCGContextDrawsWithCorrectShadowOffsets on iOS.

3:25 PM Changeset in webkit [142188] by roger_fong@apple.com

2 edits in trunk/Tools

Unreviewed. Another temporary EWS bot fix. It'll totally work this time.

Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

3:20 PM Changeset in webkit [142187] by commit-queue@webkit.org

3 edits
2 adds in trunk

[CSS Exclusions] Ignore ExclusionPolygon edges above minLogicalIntervalTop
https://bugs.webkit.org/show_bug.cgi?id=107566

Patch by Hans Muller <hmuller@adobe.com> on 2013-02-07
Reviewed by David Hyatt.

Source/WebCore:

Improve ExclusionPolygon::firstIncludedIntervalLogicalTop() performance by only
creating offset edges for polygon edges that are below the horizontal minLogicalIntervalTop
line. In other words, don't bother creating offset edges that can't define the polygon's
first fit location.

Test: fast/exclusions/shape-inside/shape-inside-first-fit-004.html

rendering/ExclusionPolygon.cpp:

(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): Don't create offset edges for polygon edges above minLogicalIntervalTop.

LayoutTests:

Added a simple polygonal shape-inside test where only a subset of the polygon edges
should contribute to each line's offset edges.

fast/exclusions/shape-inside/shape-inside-first-fit-004-expected.html: Added.
fast/exclusions/shape-inside/shape-inside-first-fit-004.html: Added.

3:19 PM Changeset in webkit [142186] by jer.noble@apple.com

3 edits in trunk/Source/WebCore

Improve logging of MediaPlayerPrivateAVFoundation Notifications.
https://bugs.webkit.org/show_bug.cgi?id=109223

Reviewed by Eric Carlson.

Convert the existing Notification enum to an expandable macro. Then add a
Logging-only function which stringifies the enums.

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore):
(WebCore::notificationName):
(WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification):
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification):

platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

3:17 PM Changeset in webkit [142185] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add layout test verifying role, subrole, and role description for all HTML elements and ARIA roles
https://bugs.webkit.org/show_bug.cgi?id=109027

Patch by James Craig <jcraig@apple.com> on 2013-02-07
Reviewed by Chris Fleizach.

New layout test verifies AXRole, AXSubrole, and AXRoleDescription for all HTML elements and ARIA roles.

platform/mac/accessibility/role-subrole-roledescription-expected.txt: Added.
platform/mac/accessibility/role-subrole-roledescription.html: Added.

3:11 PM Changeset in webkit [142184] by mhahnenberg@apple.com

3 edits in trunk/Source/JavaScriptCore

Objective-C API: testapi.mm should use ARC
https://bugs.webkit.org/show_bug.cgi?id=107838

Reviewed by Mark Rowe.

Removing the changes to the Xcode project file and moving the equivalent flags into
the ToolExecutable xcconfig file.

Configurations/ToolExecutable.xcconfig:
JavaScriptCore.xcodeproj/project.pbxproj:

2:53 PM Changeset in webkit [142183] by benjamin@webkit.org

2 edits in trunk/Source/WTF

Fix an incorrect comment from r142163

Unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07

wtf/MainThread.h:

I accidentally copied PLATFORM(IOS) instead of USE(WEB_THREAD) for the #ifdef closing.

2:52 PM Changeset in webkit [142182] by roger_fong@apple.com

2 edits in trunk/Tools

Unreviewed. Fix syntax error in runtests.py.

Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

2:44 PM Changeset in webkit [142181] by bfulgham@webkit.org

2 edits
1 delete in trunk/Source/JavaScriptCore

[Windows] Unreviewed Visual Studio 2010 build fixes after r142179.

JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in: Correct changed symbols
JavaScriptCore.vcxproj/JavaScriptCoreExports.def: Removed autogenerated file.

2:33 PM Changeset in webkit [142180] by roger_fong@apple.com

2 edits in trunk/Tools

Temporary fix for Win EWS bots.
Don't build DRT since it has already been built in the build step.

Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

2:08 PM Changeset in webkit [142179] by Martin Robinson

11 edits in trunk

[GTK] Cleanup command-line defines
https://bugs.webkit.org/show_bug.cgi?id=109213

Reviewed by Xan Lopez.

GNUmakefile.am: Remove references to flags that are now provided

by autotoolsconfig.h

configure.ac: Add new AC_DEFINE invocations for flags that were

before manually appended to the compiler CPPFLAGS and clump all
AC_DEFINE invocations together.

Source/WebCore:

GNUmakefile.am: Remove references to flags that are now handled

via autotoolsconfig.h.

Source/WebKit/gtk:

GNUmakefile.am: Remove references to flags that are now provided

by autotoolsconfig.h

Source/WebKit2:

GNUmakefile.am: Remove references to flags that are now

provided by autotoolsconfig.h.

Tools:

TestWebKitAPI/config.h: Include the autotoolsconfig.h header to pick

up defines from autoconf.

2:04 PM Changeset in webkit [142178] by rniwa@webkit.org

2 edits in trunk/Tools

git.svn_revision doesn't fetch the same revision as svn.svn_revision
https://bugs.webkit.org/show_bug.cgi?id=108684

Reviewed by Dirk Pranke.

Always call git log on the checkout root.

Scripts/webkitpy/common/checkout/scm/git.py:

(Git.svn_revision):

1:58 PM Changeset in webkit [142177] by tsepez@chromium.org

2 edits in trunk/Source/WebCore

[V8] Binding Integrity crash in V8MediaStream::createWrapper
https://bugs.webkit.org/show_bug.cgi?id=109211

Reviewed by Adam Barth.

Patch suppresses a chrome crasher.

Modules/mediastream/MediaStream.idl:

1:55 PM Changeset in webkit [142176] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

[Mac] decrease in-band caption advance notice interval
https://bugs.webkit.org/show_bug.cgi?id=109190

Reviewed by Simon Fraser.

No new tests, no observable change in behavior.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Request cues 2 seconds in advance.

1:49 PM Changeset in webkit [142175] by roger_fong@apple.com

2 edits in trunk/Tools

Unreviewed. Patch for testing Win EWS bots.

Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

1:44 PM Changeset in webkit [142174] by zandobersek@gmail.com

3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk/TestExpectations: Adding a failure expectation for a test in r142122.
platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r142149.

1:39 PM Changeset in webkit [142173] by gavinp@chromium.org

31 edits
3 deletes in trunk/Tools

Unreviewed, rolling out r142165.
http://trac.webkit.org/changeset/142165
https://bugs.webkit.org/show_bug.cgi?id=108466

Broke linux_aura builds.

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
DumpRenderTree/chromium/TestRunner/public/WebTask.h:

(WebTaskList):

DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebTestInterfaces):

DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestProxyBase):

DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):

DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:

(AccessibilityUIElementList):

DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:

DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:

(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):

DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:

DumpRenderTree/chromium/TestRunner/src/CppVariant.h:

(CppVariant):

DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:

(WebTestRunner::NativeKeyCodeForWindowsKeyCode):

DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:

(MockGrammarCheck::checkGrammarOfString):

DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:

(MockGrammarCheck):

DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:

(append):
(isNotASCIIAlpha):
(MockSpellCheck::spellCheckWord):
(MockSpellCheck::initializeIfNeeded):

DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:

(MockSpellCheck):

DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:

(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):

DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):

DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:

DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:

(TestPlugin):

DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):

DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:

(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):

DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):

DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:

(WebTestRunner):
(WebTestRunner::WebTaskList::WebTaskList):
(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):

DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):

DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

DumpRenderTree/chromium/TestRunner/src/config.h: Removed.

1:37 PM Changeset in webkit [142172] by commit-queue@webkit.org

5 edits in trunk

[GTK][AC] Clutter required version up to 1.12
https://bugs.webkit.org/show_bug.cgi?id=109037

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-07
Reviewed by Martin Robinson.

The clutter requried version is changed to 1.12.

configure.ac:

Source/WebCore:

Replace deprecated clutter apis with new ones.

No new tests, since this patch is minor refactoring.

platform/graphics/clutter/GraphicsLayerActor.cpp:

(graphicsLayerActorSetAnchorPoint):

platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::idleDestroy):
(WebCore::GraphicsLayerClutter::updateSublayerList):

1:34 PM Changeset in webkit [142171] by benjamin@webkit.org

53 edits
4 adds
4 deletes in trunk

Move pauseAnimation/pauseTransition from TestRunner to Internals
https://bugs.webkit.org/show_bug.cgi?id=109107

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07
Reviewed by Anders Carlsson.

Source/WebCore:

Tests: animations/animation-internals-api-multiple-keyframes.html

animations/animation-internals-api.html

testing/Internals.cpp:

(WebCore::Internals::pauseAnimationAtTimeOnElement):
(WebCore):
(WebCore::Internals::pauseTransitionAtTimeOnElement):

testing/Internals.h:

(Internals):

testing/Internals.idl:

Source/WebKit/efl:

WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

WebView/WebFrame.mm:
WebView/WebFramePrivate.h:

Source/WebKit/qt:

WebCoreSupport/DumpRenderTreeSupportQt.cpp:
WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit2:

WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
WebProcess/WebPage/WebFrame.cpp:
WebProcess/WebPage/WebFrame.h:

(WebFrame):

Tools:

DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

DumpRenderTree/TestRunner.h:
DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):

DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

DumpRenderTree/efl/TestRunnerEfl.cpp:
DumpRenderTree/gtk/TestRunnerGtk.cpp:
DumpRenderTree/mac/TestRunnerMac.mm:
DumpRenderTree/qt/TestRunnerQt.cpp:
DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

DumpRenderTree/win/TestRunnerWin.cpp:
DumpRenderTree/wx/TestRunnerWx.cpp:
WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:
WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

Change the tests with the following:
-Use the methods on Internals instead of TestRunner.
-Adapt the calls to pass a particular element instead of an ID.
-Remove feature detection. Having Internals implies having the feature.

animations/animation-hit-test-transform.html:
animations/animation-hit-test.html:
animations/animation-internals-api-expected.txt: Renamed from LayoutTests/animations/animation-drt-api-expected.txt.
animations/animation-internals-api-multiple-keyframes-expected.txt: Renamed from LayoutTests/animations/animation-drt-api-multiple-keyframes-expected.txt.
animations/animation-internals-api-multiple-keyframes.html: Renamed from LayoutTests/animations/animation-drt-api-multiple-keyframes.html.
animations/animation-internals-api.html: Renamed from LayoutTests/animations/animation-drt-api.html.
animations/change-keyframes-name.html:
animations/change-transform-style-during-animation.html:
animations/missing-from-to-transforms.html:
animations/missing-from-to.html:
animations/resources/animation-test-helpers.js:

(checkExpectedValue):
(startTest):

css3/calc/transitions-dependent.html:
fast/dom/shadow/transition-on-shadow-host-with-distributed-node.html:
transitions/opacity-transition-zindex.html:
transitions/resources/transition-test-helpers.js:

(expected):

transitions/transition-drt-api-delay.html:
transitions/transition-drt-api.html:
transitions/transition-hit-test-transform.html:
transitions/transition-hit-test.html:

1:26 PM Changeset in webkit [142170] by gavinp@chromium.org

20 edits in trunk/Source/WebCore

Unreviewed, rolling out r142155.
http://trac.webkit.org/changeset/142155
https://bugs.webkit.org/show_bug.cgi?id=82888

cr/win build broke.

bindings/js/JSClipboardCustom.cpp:

(WebCore::JSClipboard::types):

bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::typesAccessorGetter):

dom/Clipboard.h:

(Clipboard):

platform/blackberry/ClipboardBlackBerry.cpp:

(WebCore::ClipboardBlackBerry::types):

platform/blackberry/ClipboardBlackBerry.h:

(ClipboardBlackBerry):

platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::types):

platform/chromium/ChromiumDataObject.h:

(ChromiumDataObject):

platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::types):

platform/chromium/ClipboardChromium.h:

(ClipboardChromium):

platform/efl/ClipboardEfl.cpp:

(WebCore::ClipboardEfl::types):

platform/efl/ClipboardEfl.h:

(ClipboardEfl):

platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::types):

platform/gtk/ClipboardGtk.h:

(ClipboardGtk):

platform/mac/ClipboardMac.h:

(ClipboardMac):

platform/mac/ClipboardMac.mm:

(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):

platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::types):

platform/qt/ClipboardQt.h:

(ClipboardQt):

platform/win/ClipboardWin.cpp:

(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):

platform/win/ClipboardWin.h:

(ClipboardWin):

1:20 PM Changeset in webkit [142169] by mikhail.pozdnyakov@intel.com

22 edits in trunk/Source/WebKit2

[WK2][EFL] Removal of non coordinated graphics code path from WK2 EFL
https://bugs.webkit.org/show_bug.cgi?id=109165

Reviewed by Anders Carlsson.

Removed non coordinated graphics code path from WK2 EFL as it was not used by
anyone and caused a lot of preprocessor macros in the code making it less readable.

UIProcess/API/efl/EvasGLContext.cpp:
UIProcess/API/efl/EvasGLContext.h:

(WebKit::EvasGLContext::context):

UIProcess/API/efl/EvasGLSurface.cpp:
UIProcess/API/efl/EvasGLSurface.h:

(WebKit::EvasGLSurface::surface):

Removed also 'inline' and 'const' keywords from functions declaration,
as both EvasGLContext::context() and EvasGLSurface::surface()
are defined inside their classes and return mutable pointer.

UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::transformFromScene):
(EwkView::transformToScreen):
(EwkView::coordinatedGraphicsScene):
(EwkView::displayTimerFired):
(EwkView::scheduleUpdateDisplay): Renamed from EwkView::update().
(EwkView::exitAcceleratedCompositingMode):
(EwkView::handleEvasObjectCalculate):
(EwkView::takeSnapshot):

UIProcess/API/efl/EwkView.h:

(WebCore):
(EwkView):

UIProcess/API/efl/SnapshotImageGL.cpp:

(getImageSurfaceFromFrameBuffer):

UIProcess/API/efl/SnapshotImageGL.h:
UIProcess/API/efl/ewk_view.cpp:
UIProcess/efl/PageClientBase.cpp:

(WebKit::PageClientBase::setViewNeedsDisplay):
(WebKit::PageClientBase::updateAcceleratedCompositingMode):

UIProcess/efl/PageClientBase.h:

(PageClientBase):

UIProcess/efl/PageClientDefaultImpl.cpp:

(WebKit::PageClientDefaultImpl::didCommitLoad):
(WebKit::PageClientDefaultImpl::updateViewportSize):
(WebKit::PageClientDefaultImpl::didChangeViewportProperties):
(WebKit::PageClientDefaultImpl::didChangeContentsSize):
(WebKit::PageClientDefaultImpl::pageTransitionViewportReady):

UIProcess/efl/PageClientDefaultImpl.h:

(PageClientDefaultImpl):

UIProcess/efl/PageClientLegacyImpl.cpp:

(WebKit::PageClientLegacyImpl::didCommitLoad):
(WebKit::PageClientLegacyImpl::updateViewportSize):
(WebKit::PageClientLegacyImpl::didChangeViewportProperties):
(WebKit::PageClientLegacyImpl::didChangeContentsSize):
(WebKit::PageClientLegacyImpl::pageDidRequestScroll):
(WebKit::PageClientLegacyImpl::didRenderFrame):
(WebKit::PageClientLegacyImpl::pageTransitionViewportReady):

UIProcess/efl/PageClientLegacyImpl.h:

(PageClientLegacyImpl):

UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
(WebKit::PageLoadClientEfl::PageLoadClientEfl):

UIProcess/efl/PageLoadClientEfl.h:

(PageLoadClientEfl):

UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
(WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):

UIProcess/efl/PageViewportControllerClientEfl.h:
UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):

1:13 PM Changeset in webkit [142168] by commit-queue@webkit.org

11 edits
8 adds in trunk

Add support for parsing of -webkit-background-blend-mode
https://bugs.webkit.org/show_bug.cgi?id=108547

Patch by Rik Cabanier <cabanier@adobe.com> on 2013-02-07
Reviewed by David Hyatt.

Source/WebCore:

Added parsing and general CSS handling of -webkit-background-blend-mode per
https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#background-blend-mode

Tests: css3/compositing/background-blend-mode-property-parsing.html

css3/compositing/background-blend-mode-property.html

css/CSSComputedStyleDeclaration.cpp: Built value for getComputedStyle.

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSParser.cpp: Parsed and stored value of -webkit-background-blend-mode.

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillProperty):

css/CSSProperty.cpp: Listed -webkit-background-blend-mode as a non-inherited property.

(WebCore::CSSProperty::isInheritedProperty):

css/CSSPropertyNames.in: Added -webkit-background-blend-mode as a CSS property.
css/CSSToStyleMap.cpp: Mapped background blend mode from CSS value to enum.

(WebCore::CSSToStyleMap::mapFillBlendMode):
(WebCore):

css/CSSToStyleMap.h: Added function declaration 'mapFillBlendMode'.

(CSSToStyleMap):

css/StyleBuilder.cpp: Set up propery handler for -webkit-background-blend-mode.

(WebCore::StyleBuilder::StyleBuilder):

rendering/style/FillLayer.cpp: Added code to store and retrieve the blend mode from a layer.

(WebCore::FillLayer::FillLayer):
(WebCore::FillLayer::operator=):
(WebCore::FillLayer::operator==):
(WebCore::FillLayer::fillUnsetProperties):

rendering/style/FillLayer.h: Added function definitions to manage blend mode in a layer.

(WebCore::FillLayer::blendMode):
(WebCore::FillLayer::isBlendModeSet):
(WebCore::FillLayer::setBlendMode):
(WebCore::FillLayer::clearBlendMode):
(WebCore::FillLayer::initialFillBlendMode):
(FillLayer):

LayoutTests:

Added parsing and general CSS handling of -webkit-background-blend-mode per
https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#background-blend-mode

css3/compositing/background-blend-mode-property-expected.txt: Added.
css3/compositing/background-blend-mode-property-parsing-expected.txt: Added.
css3/compositing/background-blend-mode-property-parsing.html: Added.
css3/compositing/background-blend-mode-property.html: Added.
css3/compositing/script-tests/background-blend-mode-property-parsing.js: Added.

(jsWrapperClass):
(shouldBeType):
(testBlendModeRule):

css3/compositing/script-tests/background-blend-mode-property.js: Added.

(testblendmode):

css3/compositing/background-blend-mode-property-expected.txt: Added.
css3/compositing/background-blend-mode-property-parsing-expected.txt: Added.
css3/compositing/background-blend-mode-property-parsing.html: Added.
css3/compositing/background-blend-mode-property.html: Added.
css3/compositing/script-tests/background-blend-mode-property-parsing.js: Added.

(jsWrapperClass):
(shouldBeType):
(testBlendModeRule):

css3/compositing/script-tests/background-blend-mode-property.js: Added.

(testblendmode):

platform/chromium/css3/compositing/background-blend-mode-property-expected.txt: Added.
platform/chromium/css3/compositing/background-blend-mode-property-parsing-expected.txt: Added.

1:10 PM Changeset in webkit [142167] by gavinp@chromium.org

6 edits
2 deletes in trunk

Unreviewed, rolling out r142142.
http://trac.webkit.org/changeset/142142
https://bugs.webkit.org/show_bug.cgi?id=109154

Source/WebCore:

Mac expectations were not right. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio-leak-test.html and http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio.html .

inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._registerShortcuts):

LayoutTests:

Mac expectations were not right. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Feditor%2Ftext-editor-home-button.html

inspector/editor/text-editor-home-button-expected.txt: Removed.
inspector/editor/text-editor-home-button.html: Removed.
platform/efl/TestExpectations:
platform/mac/TestExpectations:
platform/qt/TestExpectations:

1:03 PM Changeset in webkit [142166] by gavinp@chromium.org

4 edits in trunk/Source/WebCore

Unreviewed, rolling out r142081.
http://trac.webkit.org/changeset/142081
https://bugs.webkit.org/show_bug.cgi?id=109146

The patch caused a crash in inspector-protocol/nmi-webaudio*.html .

See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio-leak-test.html and http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnmi-webaudio.html .

dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):

inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

platform/PlatformMemoryInstrumentation.cpp:

(WebCore):

12:58 PM Changeset in webkit [142165] by jochen@chromium.org

31 edits
3 copies in trunk/Tools

[chromium] turn TestRunner library into a component build
https://bugs.webkit.org/show_bug.cgi?id=108466

Reviewed by Adam Barth.

To achieve this, we need to drop all dependencies on WTF.

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
DumpRenderTree/chromium/TestRunner/public/WebTask.h:
DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):

DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:

(AccessibilityUIElementList):

DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:

DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:

(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):

DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:

DumpRenderTree/chromium/TestRunner/src/CppVariant.h:

(CppVariant):

DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:

(WebTestRunner::NativeKeyCodeForWindowsKeyCode):

DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:

(WebTestRunner::MockGrammarCheck::checkGrammarOfString):
(WebTestRunner):

DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:

(WebTestRunner):
(MockGrammarCheck):

DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:

(WebTestRunner::MockSpellCheck::spellCheckWord):
(WebTestRunner::MockSpellCheck::initializeIfNeeded):
(WebTestRunner):

DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:

(MockSpellCheck):

DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:

(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):

DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.

(isASCIIAlpha):
(isNotASCIIAlpha):

DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):

DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:

DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:

(TestPlugin):

DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):

DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:

(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):

DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):

DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:

(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):

DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):

DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

DumpRenderTree/chromium/TestRunner/src/config.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.

12:50 PM Changeset in webkit [142164] by commit-queue@webkit.org

7 edits
2 adds in trunk

[CSS Exclusions] shape-inside does not properly handle padding or border
https://bugs.webkit.org/show_bug.cgi?id=102715

Patch by Bear Travis <betravis@adobe.com> on 2013-02-07
Reviewed by David Hyatt.

Source/WebCore:

This patch positions the exclusion shape based on the value of the css box sizing
property. Geometry calculations happen in the shape coordinate space. For layout,
these coordinates are translated to the border-box coordinate system by adding
the appropriate offsets.

Test: fast/exclusions/shape-inside/shape-inside-box-sizing.html

rendering/ExclusionShapeInfo.cpp:

(WebCore::::computedShape): Pass m_shapeLogicalWidth to the exclusion shape
geometry code.

rendering/ExclusionShapeInfo.h:

(WebCore::ExclusionShapeInfo::setShapeSize): Adjust block layout dimensions to
shape dimensions when checking to see if the shape geometry must be recalculated.
(WebCore::ExclusionShapeInfo::shapeLogicalTop): Account for layout offsets.
(WebCore::ExclusionShapeInfo::shapeLogicalBottom): Ditto.
(WebCore::ExclusionShapeInfo::shapeLogicalLeft): Ditto.
(WebCore::ExclusionShapeInfo::shapeLogicalRight): Ditto.
(WebCore::ExclusionShapeInfo::logicalTopOffset): Return the offset from the logical
top of the border box to the logical top of the shape.
(WebCore::ExclusionShapeInfo::logicalLeftOffset): Return the offset from the logical
left of the border box to the logical left of the shape.
(ExclusionShapeInfo):

rendering/ExclusionShapeInsideInfo.cpp:

(WebCore::ExclusionShapeInsideInfo::computeSegmentsForLine): Adjust line top to
be in shape coordinates.
(WebCore::ExclusionShapeInsideInfo::adjustLogicalLineTop): Ditto.

rendering/ExclusionShapeInsideInfo.h:

(WebCore::ExclusionShapeInsideInfo::lineOverlapsShapeBounds): Use consistent
coordinate system (border box) to test for whether a line overlaps a shape.
(WebCore::ExclusionShapeInsideInfo::logicalLineTop): Include the logical offset
from the border box.
(WebCore::ExclusionShapeInsideInfo::logicalLineBottom): Ditto.

LayoutTests:

Test that borders and padding are properly accounted for when laying out text in
a shape inside.

fast/exclusions/shape-inside/shape-inside-bottom-edge.html: Modified to no longer

use padding.

fast/exclusions/shape-inside/shape-inside-box-sizing-expected.html: Added.
fast/exclusions/shape-inside/shape-inside-box-sizing.html: Added.

12:35 PM Changeset in webkit [142163] by benjamin@webkit.org

8 edits in trunk/Source

Upstream iOS isWebThread() and isUIThread()
https://bugs.webkit.org/show_bug.cgi?id=109130

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-07
Reviewed by Sam Weinig.

Source/WebCore:

bindings/objc/WebScriptObject.mm:

(+[WebScriptObject initialize]):

platform/mac/SharedBufferMac.mm:

(+[WebCoreSharedBufferData initialize]):
#ifdef out the legacy initialization as it is not correct when
using a WebThread.

Source/WTF:

On iOS, it is sometimes necessary to differenciate the thread running WebCore,
and the thread running the UI. This patch upstream those functions.

wtf/MainThread.cpp:
wtf/MainThread.h:

Disable the legacy initializer as it is incorrect when using the WebThread to run WebCore.
(WTF::isWebThread):
(WTF::isUIThread):
Return true when the current thread is the Web/UI thread.

wtf/mac/MainThreadMac.mm:

(WTF::isUIThread):
(WTF::isWebThread):

wtf/text/AtomicString.cpp:

(WTF::AtomicStringTable::create):
Use the newly added methods.

12:22 PM Changeset in webkit [142162] by fpizlo@apple.com

5 edits in trunk/Source/JavaScriptCore

DFG::ByteCodeParser should do surgical constant folding to reduce load on the optimization fixpoint
https://bugs.webkit.org/show_bug.cgi?id=109000

Reviewed by Oliver Hunt.

Previously our source parser's ASTBuilder did some surgical constant folding, but it
didn't cover some cases. It was particularly incapable of doing constant folding for
cases where we do some minimal loop peeling in the bytecode generator - since it
didn't "see" those constants prior to the peeling. Example:

for (var i = 0; i < 4; ++i)

things;

This will get peeled just a bit by the bytecode generator, so that the "i < 4" is
duplicated both at the top of the loop and the bottom. This means that we have a
constant comparison: "0 < 4", which the bytecode generator emits without any further
thought.

The DFG optimization fixpoint of course folds this and simplifies the CFG
accordingly, but this incurs a compile-time cost. The purpose of this change is to
do some surgical constant folding in the DFG's bytecode parser, so that such
constructs reduce load on the CFG simplifier and the optimization fixpoint. The goal
is not to cover all cases, since the DFG CFA and CFG simplifier have a powerful
sparse conditional constant propagation that we can always fall back on. Instead the
goal is to cover enough cases that for common small functions we don't have to
perform such transformations, thereby reducing compile times.

This also refactors m_inlineStackEntry->m_inlineCallFrame to be a handy method call
and also adds the notion of a TriState-based JSValue::pureToBoolean(). Both of these
things are used by the folder.

As well, care has been taken to make sure that the bytecode parser only does folding
that is statically provable, and that doesn't arise out of speculation. This means
we cannot fold on data flow that crosses inlining boundaries. On the other hand, the
folding that the bytecode parser uses doesn't require phantoming anything. Such is
the trade-off: for anything that we do need phantoming, we defer it to the
optimization fixpoint.

Slight SunSpider speed-up.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::flushArgumentsAndCapturedVariables):
(JSC::DFG::ByteCodeParser::toInt32):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::inlineCallFrame):
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::canFold):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::getScope):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

dfg/DFGNode.h:

(JSC::DFG::Node::isStronglyProvedConstantIn):
(Node):

runtime/JSCJSValue.h:
runtime/JSCJSValueInlines.h:

(JSC::JSValue::pureToBoolean):
(JSC):

12:02 PM Changeset in webkit [142161] by vivek.vg@samsung.com

6 edits in trunk/Source/WebCore

Web Inspector: CPU pegged when inspecting LocalStorage that mutates.
https://bugs.webkit.org/show_bug.cgi?id=107937

Reviewed by Yury Semikhatsky.

The DOM storage agent will fire an event to the frontend based on the action
performed on the storage. Based on this action, the front-end will just add/update/remove
the entry in the view. This enhances the front-end responsiveness as the round trip
for fetching the storage entries has been eliminated.

Existing test: LayoutTests/inspector/storage-panel-dom-storage-update.html should verify the change

inspector/Inspector.json:
inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):

inspector/front-end/DOMStorage.js:

(WebInspector.DOMStorageModel.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageModel.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageModel.prototype._domStorageItemAdded):
(WebInspector.DOMStorageModel.prototype._domStorageItemUpdated):
(WebInspector.DOMStorageDispatcher.prototype.domStorageItemsCleared):
(WebInspector.DOMStorageDispatcher.prototype.domStorageItemRemoved):
(WebInspector.DOMStorageDispatcher.prototype.domStorageItemAdded):
(WebInspector.DOMStorageDispatcher.prototype.domStorageItemUpdated):

inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView):
(WebInspector.DOMStorageItemsView.prototype.wasShown):
(WebInspector.DOMStorageItemsView.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageItemsView.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageItemsView.prototype._domStorageItemAdded):
(WebInspector.DOMStorageItemsView.prototype._domStorageItemUpdated):
(WebInspector.DOMStorageItemsView.prototype._update):
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
(WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
(WebInspector.DOMStorageItemsView.prototype._editingCallback):
(WebInspector.DOMStorageItemsView.prototype._deleteCallback):

inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._showDOMStorage.get if):
(WebInspector.ResourcesPanel.prototype._showDOMStorage):

11:58 AM Changeset in webkit [142160] by weinig@apple.com

20 edits in trunk/Source/WebKit2

Make WebPageProxy and sub-objects MessageReceivers
https://bugs.webkit.org/show_bug.cgi?id=108785

Reviewed by Anders Carlsson.

UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:

(WebKit::CoordinatedLayerTreeHostProxy::CoordinatedLayerTreeHostProxy):
(WebKit::CoordinatedLayerTreeHostProxy::~CoordinatedLayerTreeHostProxy):

UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:

(CoordinatedLayerTreeHostProxy):

UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::~DrawingAreaProxy):
(WebKit::DrawingAreaProxy::contentsRect):

UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::setVisibleContentsRect):

UIProcess/DrawingAreaProxy.messages.in:
UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::setVisibleContentsRect):

UIProcess/DrawingAreaProxyImpl.h:
UIProcess/WebFullScreenManagerProxy.cpp:

(WebKit::WebFullScreenManagerProxy::WebFullScreenManagerProxy):

UIProcess/WebFullScreenManagerProxy.h:

(WebFullScreenManagerProxy):

UIProcess/WebFullScreenManagerProxy.messages.in:
UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::invalidate):

UIProcess/WebInspectorProxy.h:
UIProcess/WebInspectorProxy.messages.in:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::inspector):
(WebKit::WebPageProxy::fullScreenManager):
(WebKit::WebPageProxy::processDidCrash):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):

UIProcess/mac/WebFullScreenManagerProxyMac.mm:

(WebKit::WebFullScreenManagerProxy::invalidate):

11:48 AM Changeset in webkit [142159] by commit-queue@webkit.org

35 edits in trunk/Source/WebCore

[v8] move persistent::new and ::dispose into same class
https://bugs.webkit.org/show_bug.cgi?id=109065

Patch by Dan Carney <dcarney@google.com> on 2013-02-07
Reviewed by Adam Barth.

No new tests. No change in functionality.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::createWrapper):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::createWrapper):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::createWrapper):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):
(WebCore::V8TestEventConstructor::createWrapper):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::createWrapper):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::createWrapper):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::constructorCallback):
(WebCore::V8TestInterface::createWrapper):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::createWrapper):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):
(WebCore::V8TestNamedConstructor::createWrapper):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::constructorCallback):
(WebCore::V8TestNode::createWrapper):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::constructorCallback):
(WebCore::V8TestObj::createWrapper):

bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::constructor1Callback):
(WebCore::V8TestOverloadedConstructors::constructor2Callback):
(WebCore::V8TestOverloadedConstructors::constructor3Callback):
(WebCore::V8TestOverloadedConstructors::constructor4Callback):
(WebCore::V8TestOverloadedConstructors::createWrapper):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
(WebCore::V8TestSerializedScriptValueInterface::createWrapper):

bindings/v8/DOMDataStore.cpp:
bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::setWrapper):
(DOMDataStore):
(WebCore::DOMDataStore::set):
(WebCore::DOMDataStore::setWrapperInObject):

bindings/v8/DOMWrapperMap.h:

(WebCore::DOMWrapperMap::get):
(WebCore::DOMWrapperMap::set):
(WebCore::DOMWrapperMap::removeAndDispose):
(WebCore::DOMWrapperMap::defaultWeakCallback):

bindings/v8/ScriptWrappable.h:

(WebCore::ScriptWrappable::wrapper):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::reportMemoryUsage):
(ScriptWrappable):
(WebCore::ScriptWrappable::disposeWrapper):
(WebCore::ScriptWrappable::weakCallback):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow):

bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):
(WebCore::V8DOMWrapper::associateObjectWithWrapper):

bindings/v8/V8NPObject.cpp:

(WebCore::weakNPObjectCallback):
(WebCore::createV8ObjectForNPObject):
(WebCore::forgetV8ObjectForNPObject):

bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::initializeContextIfNeeded):

bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WrapperConfiguration):
(WebCore::WrapperConfiguration::configureWrapper):
(WebCore::buildWrapperConfiguration):

bindings/v8/custom/V8ArrayBufferCustom.cpp:

(WebCore::V8ArrayBuffer::constructorCallbackCustom):

bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::wrapArrayBufferView):
(WebCore::constructWebGLArray):

bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallbackCustom):

bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCallbackCustom):

bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallbackCustom):

bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

bindings/v8/custom/V8IntentCustom.cpp:

(WebCore::V8Intent::constructorCallbackCustom):

bindings/v8/custom/V8MessageChannelCustom.cpp:

(WebCore::V8MessageChannel::constructorCallbackCustom):

bindings/v8/custom/V8MutationObserverCustom.cpp:

(WebCore::V8MutationObserver::constructorCallbackCustom):

bindings/v8/custom/V8WebKitPointCustom.cpp:

(WebCore::V8WebKitPoint::constructorCallbackCustom):

bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::constructorCallbackCustom):

11:31 AM Changeset in webkit [142158] by zandobersek@gmail.com

7 edits in trunk

[Autotools] Remove uses of Automake FARSTREAM_(CFLAGS|LIBS) variables, USE_FARSTREAM conditional
https://bugs.webkit.org/show_bug.cgi?id=109198

Reviewed by Martin Robinson.

GNUmakefile.am: The USE_FARSTREAM conditional is being removed while the WTF_USE_FARSTREAM

define is currently a no-op.

configure.ac: Don't set the Automake conditional as it's currently not needed due

to checking for Farstream dependency being removed in r142005.

Source/WebCore:

GNUmakefile.am: Remove FARSTREAM_CFLAGS variable, it's not set to anything.

Source/WebKit2:

GNUmakefile.am: Remove the FARSTREAM_(CFLAGS|LIBS) variables, they're

not set to anything.

11:19 AM Changeset in webkit [142157] by kenneth@webkit.org

8 edits in trunk/Source/WebKit2

[WK2][EFL] Add WKView methods related to background drawing
https://bugs.webkit.org/show_bug.cgi?id=109159

Reviewed by Anders Carlsson.

UIProcess/API/C/efl/WKView.cpp:

(WKViewSetDrawsBackground):
(WKViewGetDrawsBackground):
(WKViewSetDrawsTransparentBackground):
(WKViewGetDrawsTransparentBackground):

UIProcess/efl/WebView.cpp:

(WebKit::WebView::setDrawsBackground):
(WebKit):
(WebKit::WebView::drawsBackground):
(WebKit::WebView::setDrawsTransparentBackground):
(WebKit::WebView::drawsTransparentBackground):

UIProcess/efl/WebView.h:

(WebView):

UIProcess/API/C/efl/WKView.h:

New methods added

UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::displayTimerFired):
(EwkView::handleEvasObjectColorSet):

UIProcess/API/efl/EwkView.h:

(EwkView):

UIProcess/API/efl/ewk_view.cpp:

(ewk_view_draws_page_background_set):

Remove the unneeded m_setDrawsBackground and replace
it with the WKView setting.

11:04 AM Changeset in webkit [142156] by commit-queue@webkit.org

2 edits in trunk/Tools

Do not check enum's casing for WebKit2 C API.
https://bugs.webkit.org/show_bug.cgi?id=109128

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-02-07
Reviewed by Kenneth Rohde Christiansen.

Add "-readability/enum_casing" for WebKit2 C APIs because we use word
which starts with non-capital letter 'k' for types of enums.

Scripts/webkitpy/style/checker.py:

11:00 AM Changeset in webkit [142155] by Vineet

20 edits in trunk/Source/WebCore

Consider replacing return type of Clipboard::types() from ListHashSet<String> to Vector<String>
https://bugs.webkit.org/show_bug.cgi?id=82888

Reviewed by Kentaro Hara.

As part of removing custom bindings of types Array Clipboard::types() needs to return
Vector<String> than ListHashSet<String>

No new tests. Existing test should pass with this change as no behavoural changes.

bindings/js/JSClipboardCustom.cpp: Replace data type from ListHashSet<> to Vector<>.

(WebCore::JSClipboard::types):

bindings/v8/custom/V8ClipboardCustom.cpp: Ditto.

(WebCore::V8Clipboard::typesAccessorGetter): Ditto.

dom/Clipboard.h: Ditto.
platform/blackberry/ClipboardBlackBerry.cpp: Ditto.

(WebCore::ClipboardBlackBerry::types):

platform/blackberry/ClipboardBlackBerry.h: Ditto.
platform/chromium/ChromiumDataObject.cpp: Ditto.

(WebCore::ChromiumDataObject::types):

platform/chromium/ChromiumDataObject.h: Ditto.
platform/chromium/ClipboardChromium.cpp: Ditto.

(WebCore::ClipboardChromium::types):

platform/chromium/ClipboardChromium.h: Ditto.
platform/efl/ClipboardEfl.cpp: Ditto.

(WebCore::ClipboardEfl::types):

platform/efl/ClipboardEfl.h: Ditto.
platform/gtk/ClipboardGtk.cpp: Ditto.

(WebCore::ClipboardGtk::types):

platform/gtk/ClipboardGtk.h: Ditto.
platform/mac/ClipboardMac.h: Ditto.
platform/mac/ClipboardMac.mm: Ditto.

(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::ClipboardMac::types):

platform/qt/ClipboardQt.cpp: Ditto.

(WebCore::ClipboardQt::types):

platform/qt/ClipboardQt.h: Ditto.
platform/win/ClipboardWin.cpp: Ditto.

(WebCore::addMimeTypesForFormat):
(WebCore::ClipboardWin::types):

platform/win/ClipboardWin.h: Ditto.

10:57 AM Changeset in webkit [142154] by haraken@chromium.org

3 edits in trunk/Source/WebCore

[V8] StringCache::m_stringCache should be HashMap<StringImpl*, Persistent<String>>
https://bugs.webkit.org/show_bug.cgi?id=109123

Reviewed by Adam Barth.

Currently StringCache::m_stringCache is implemented as
HashMap<StringImpl*, v8::String*>. Given that v8::String*
can change when a GC is triggered, it is dangerous to store a raw pointer.
We should use HashMap<StringImpl*, v8::Persistent<v8::String>> instead.

This is a possible fix for an IndexedDB crash (https://bugs.webkit.org/show_bug.cgi?id=105363),
although I'm not sure if this patch fixes the crash. (I couldn't reproduce the crash.)

No tests. This change highly depends on GC behavior and thus it is
difficult to make a reliable test case.

bindings/v8/V8ValueCache.cpp:

(WebCore::makeExternalString):

bindings/v8/V8ValueCache.h:

(StringCache):

10:49 AM Changeset in webkit [142153] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL][WK2] EWK2UnitTestBase.ewk_view_page_contents_get API test is sometimes failing
https://bugs.webkit.org/show_bug.cgi?id=108634

Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-07
Reviewed by Alexey Proskuryakov.

Use more robust data validation in EWK2UnitTestBase.ewk_view_page_contents_get
so that the test passes consistently. The issue was that the header before the
data includes the current date. Depending on the date, the data may start at a
different index in the returned string. Instead of hardcoding the data start
index in the test, we now use String::contains().

UIProcess/API/efl/tests/test_ewk2_view.cpp:

(PageContentsCallback):
(TEST_F):

10:48 AM Changeset in webkit [142152] by robert@webkit.org

9 edits
4 adds in trunk

CSS 2.1 failure: floats-149 fails
https://bugs.webkit.org/show_bug.cgi?id=95772

Reviewed by David Hyatt.

Source/WebCore:

Treat inlines that contain nothing but empty inlines as empty too so that they get a linebox.

Tests: fast/inline/inline-with-empty-inline-children.html

css2.1/20110323/floats-149.htm

rendering/InlineIterator.h:

(WebCore::isEmptyInline):

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Now that empty inlines get a linebox any out-of-flow
objects inside an empty inline (on a line that is otherwise empty) won't get positioned while skipping
through leading whitespace.

LayoutTests:

css2.1/20110323/floats-149-expected.html: Added.
css2.1/20110323/floats-149.htm: Added.
fast/inline/inline-with-empty-inline-children-expected.txt: Added.
fast/inline/inline-with-empty-inline-children.html: Added.
platform/chromium-win/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:

10:39 AM Changeset in webkit [142151] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[WinCairo] Compile fix after r141981
https://bugs.webkit.org/show_bug.cgi?id=109184

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-02-07
Reviewed by Brent Fulgham.

platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::loadResourceSynchronously):

10:24 AM Changeset in webkit [142150] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[BlackBerry] Cookie database isn't loaded into memory in some rare cases
https://bugs.webkit.org/show_bug.cgi?id=109202
PR 286189

Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-02-07
Reviewed by Yong Li.
Internally Reviewed by Konrad Piascik.

If a get/setCookie call is made before the database is loaded, or if there's some
kind of error that causes the loading of the database to fail in the constructor
of CookieManager, the browser will get into a state where it seems like cookie is
permanenty disabled.

Instead of logging the errors and redispatching the setCookie, we should do a force sync
to load the cookie database before continuing.

Since the bug is so difficult to reproduce (I never did so myself), I did the follow test
to make sure the code path is correct:
1) Make sure original implementation is retained - open and loading done in the constructor
2) Removed opening and loading in constructor, the new calls in get/setcookies loaded the db just fine (although with
an initial lag because we are blocking WKT while performing SQLite options).
3) Removed loading in constructor, the new calls loaded the db just fine.

platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:

(WebCore::CookieDatabaseBackingStore::openAndLoadDatabaseSynchronously):
(WebCore):

platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:

(CookieDatabaseBackingStore):

platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::setCookies):
(WebCore::CookieManager::getCookie):
(WebCore::CookieManager::generateHtmlFragmentForCookies):
(WebCore::CookieManager::getRawCookies):

10:21 AM Changeset in webkit [142149] by mvujovic@adobe.com

3 edits
5 moves
1 add
2 deletes in trunk

[CSS Shaders] Add WebKitCSSFilterRule to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=109082

Source/WebCore:

Reviewed by Dean Jackson.

Add an entry for WebKitCSSFilterRuleConstructor in DOMWindow.idl.

Tests: css3/filters/custom-with-at-rule-syntax/parsing-at-rule-invalid.html

css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid.html

page/DOMWindow.idl:

LayoutTests:

Move the at-rule parsing tests to the recently added folder named
"custom-with-at-rule-parsing".

Remove the "custom-filter" prefix from the test filenames to
match the new convention.

Update the tests to use the "shouldHaveConstructor" JS helper function instead of the
"shouldBeType" JS helper function. Among other things, using "shouldHaveConstructor" tests
that window.WebKitCSSFilterRule is defined. "shouldHaveConstructor" has the same
behavior in JSC and V8, unlike "shouldBeType". Therefore, remove the Chromium-specific text
expectation file that was previously needed for "shouldBeType".

Reviewed by Dean Jackson.

css3/filters/custom-with-at-rule-syntax/parsing-at-rule-invalid-expected.txt: Renamed from LayoutTests/css3/filters/custom/custom-filter-parsing-at-rule-invalid-expected.txt.
css3/filters/custom-with-at-rule-syntax/parsing-at-rule-invalid.html: Renamed from LayoutTests/css3/filters/custom/custom-filter-parsing-at-rule-invalid.html.
css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid-expected.txt: Added.
css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid.html: Renamed from LayoutTests/css3/filters/custom/custom-filter-parsing-at-rule-valid.html.
css3/filters/custom-with-at-rule-syntax/script-tests/parsing-at-rule-invalid.js: Renamed from LayoutTests/css3/filters/script-tests/custom-filter-parsing-at-rule-invalid.js.

(testInvalidFilterAtRule):

css3/filters/custom-with-at-rule-syntax/script-tests/parsing-at-rule-valid.js: Renamed from LayoutTests/css3/filters/script-tests/custom-filter-parsing-at-rule-valid.js.

(testFilterAtRule):
(testNestedRules):
(checkRule):

css3/filters/custom/custom-filter-parsing-at-rule-valid-expected.txt: Removed.
platform/chromium/css3/filters/custom/custom-filter-parsing-at-rule-valid-expected.txt: Removed.

10:14 AM Changeset in webkit [142148] by vsevik@chromium.org

5 edits in trunk

Web Inspector: Remove unused workspace field from NetworkUISourceCodeProvider
https://bugs.webkit.org/show_bug.cgi?id=109201

Reviewed by Pavel Feldman.

Source/WebCore:

inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider):

inspector/front-end/inspector.js:

LayoutTests:

inspector/debugger/network-uisourcecode-provider.html:

10:12 AM Changeset in webkit [142147] by jberlin@webkit.org

3 edits in trunk/Source/WebCore

REGRESSION(r142003): Duplicate "Unknown" strings in LocalizedStrings.cpp not distinguished
by key
https://bugs.webkit.org/show_bug.cgi?id=109196

Reviewed by Eric Carlson.

English.lproj/Localizable.strings:

Updated for the changes.

platform/LocalizedStrings.cpp:

(WebCore::unknownFileSizeText):
Add a key.
(WebCore::textTrackNoLabelText):
Ditto.

10:04 AM Changeset in webkit [142146] by zherczeg@webkit.org

2 edits in trunk/Source/JavaScriptCore

Invalid code is generated for storing constants with baseindex addressing modes on ARM traditional.
https://bugs.webkit.org/show_bug.cgi?id=109050

Reviewed by Oliver Hunt.

The S! scratch register is reused, but it should contain the constant value.

assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::baseIndexTransfer32):
(JSC::ARMAssembler::baseIndexTransfer16):

10:03 AM Changeset in webkit [142145] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: linkifyResourceAsNode produced anchor should not prefer resources to scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=109197

Reviewed by Pavel Feldman.

Javascript syntax errors in console are now linkified so that they show sources panel by default.

inspector/front-end/ResourceUtils.js:

(WebInspector.linkifyResourceAsNode):

9:55 AM Changeset in webkit [142144] by commit-queue@webkit.org

16 edits in trunk/Source

Web Inspector: Add settings checkbox for composited layer borders
https://bugs.webkit.org/show_bug.cgi?id=109096

Patch by Eberhard Graether <egraether@google.com> on 2013-02-07
Reviewed by Pavel Feldman.

This change adds a checkbox to show composited layer borders to the WebInspector's
rendering settings and plumbs the setting to Chromium's WebLayerTreeView. The setting
is visible if InspectorClient::canShowDebugBorders() returns true.

Source/Platform:

chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):
(WebKit::WebLayerTreeView::setShowDebugBorders):

Source/WebCore:

No new tests.

English.lproj/localizedStrings.js:
inspector/Inspector.json:
inspector/InspectorClient.h:

(WebCore::InspectorClient::canShowDebugBorders):
(WebCore::InspectorClient::setShowDebugBorders):
(InspectorClient):

inspector/InspectorPageAgent.cpp:

(PageAgentState):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::canShowDebugBorders):
(WebCore):
(WebCore::InspectorPageAgent::setShowDebugBorders):

inspector/InspectorPageAgent.h:
inspector/front-end/Settings.js:
inspector/front-end/SettingsScreen.js:

(WebInspector.GenericSettingsTab):
(WebInspector.GenericSettingsTab.prototype.get _showDebugBordersChanged):

inspector/front-end/inspector.js:

(WebInspector.doLoadedDone):

Source/WebKit/chromium:

src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::canShowDebugBorders):
(WebKit):
(WebKit::InspectorClientImpl::setShowDebugBorders):

src/InspectorClientImpl.h:

(InspectorClientImpl):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setShowDebugBorders):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

src/WebViewImpl.h:

9:51 AM Changeset in webkit [142143] by gavinp@chromium.org

12 edits
3 adds in trunk

Unreviewed, rolling out r142141.
http://trac.webkit.org/changeset/142141
https://bugs.webkit.org/show_bug.cgi?id=108990

Reland r142112, will update Chromium expectations and create a
Chromium bug instead for the crash.

ManualTests/remove-fixed-position-but-keep-compositing.html: Added.

Source/WebCore:

CMakeLists.txt:
Target.pri:
WebCore.pri:
page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::create):

page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp: Added.

(WebCore):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::ScrollingCoordinatorCoordinatedGraphics):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::setLayerIsFixedToContainerLayer):

page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h: Added.

(WebCore):
(ScrollingCoordinatorCoordinatedGraphics):

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setFixedToViewport):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::flushCompositingState):

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):

Source/WebKit2:

WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl):

9:46 AM Changeset in webkit [142142] by commit-queue@webkit.org

6 edits
2 adds in trunk

Web Inspector: home button behaviour is wrong in DTE
https://bugs.webkit.org/show_bug.cgi?id=109154

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-07
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Handle home key shortcut explicitly in TextEditorMainPanel.

New test: inspector/editor/text-editor-home-button.html

inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._registerShortcuts):
(WebInspector.TextEditorMainPanel.prototype._handleHomeKey):

LayoutTests:

Add layout test to verify home button behaviour. Exclude this test on
platforms that do not have eventSender object in test shell.

inspector/editor/text-editor-home-button-expected.txt: Added.
inspector/editor/text-editor-home-button.html: Added.
platform/efl/TestExpectations:
platform/mac/TestExpectations:
platform/qt/TestExpectations:

9:32 AM Changeset in webkit [142141] by gavinp@chromium.org

12 edits
3 deletes in trunk

Unreviewed, rolling out r142112.
http://trac.webkit.org/changeset/142112
https://bugs.webkit.org/show_bug.cgi?id=108990

The new test scrollingcoordinator/non-fast-scrollable-region-transformed- iframe.html crashes on Lion.

See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=scrollingcoordinator%2Fnon-fast-scrollable-region-transformed-iframe.html

ManualTests/remove-fixed-position-but-keep-compositing.html: Removed.

Source/WebCore:

CMakeLists.txt:
Target.pri:
WebCore.pri:
page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::create):

page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp: Removed.
page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h: Removed.
platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::flushCompositingState):

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient):
(WebCore::CoordinatedGraphicsLayer::setFixedToViewport):

Source/WebKit2:

WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::updateOffsetFromViewportForSelf):
(WebKit):
(WebKit::updateOffsetFromViewportForLayer):
(WebKit::CoordinatedLayerTreeHost::syncFixedLayers):

WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl):

9:29 AM Changeset in webkit [142140] by allan.jensen@digia.com

5 edits in trunk

Scrollbars misplaced with accelerated compositing for overflow scroll
https://bugs.webkit.org/show_bug.cgi?id=108625

Reviewed by Simon Fraser.

Source/WebCore:

Scrollbars require their own layer if overflow scroll is composited,
otherwise the scrollbars would be rendered on the content layer and
not fixed to the viewport.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::requiresHorizontalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresVerticalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresScrollCornerLayer):

LayoutTests:

Update the results for the one test that explicitly set accelerated compositing for overflow scroll,
and used to have bad results for non-chromium. The new baselines are almost identical to chomium baseline.

platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:

9:18 AM Changeset in webkit [142139] by mkwst@chromium.org

2 edits in trunk/Source/WebCore

Don't ASSERT things about uninitialized variables.
https://bugs.webkit.org/show_bug.cgi?id=109187

Reviewed by Jochen Eisinger.

Rather than ASSERTing that an uninitialized ExceptionCode is non-zero
after some method executes, we should use the ASSERT_NO_EXCEPTION macro.

editing/markup.cpp:

(WebCore::removeElementPreservingChildren):

9:17 AM Changeset in webkit [142138] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Web Inspector: [Regression] breakpoint condition not editable
https://bugs.webkit.org/show_bug.cgi?id=109183

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-07
Reviewed by Vsevolod Vlasov.

Improve TextEditorMainPanel.selection() method to return null if the
selection is set inside of decoration element.

No new tests.

inspector/front-end/DOMExtension.js:

(Node.prototype.enclosingNodeOrSelfWithClass): Improve to add iteration boundary.

inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype.selection):

8:58 AM Changeset in webkit [142137] by jpetsovits@rim.com

4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix all flicker caused by empty/incomplete geometries.
https://bugs.webkit.org/show_bug.cgi?id=108951
RIM PR 286925

Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.

The main idea for this patch is that whenever we adopt
a new backingstore geometry that doesn't contain any
rendered tiles, or VisibleZoom render jobs that need more
tiles to be rendered to be considered complete, we'll then
suspend blitting until there is valid content to show.

This main idea is codified as checks for empty buffers
in adoptAsFrontState(), and checks for the current state
of the render queue after rendering content in render().
However, as BackingStore objects with disabled surface pools
or pure use of accelerated compositing also swap geometries
in some circumstances, the use of suspend counters grows
increasingly fragile.

To make this patch more resilient against regressions,
the current suspend counter is complemented with several
explicit conditions for suspending screen updates,
and both subsequently combined into a single cached
boolean value telling the UI thread whether or not to
suspend. In the future, other suspend calls can be
migrated to this "state machine" design as well,
potentially phasing out the suspend counter altogether.

The immediate result is that there will be no flashing
of background color between page loads or after discarding
tiles on scale changes until the content has been rendered.

Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::suspendBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::suspendScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::adoptAsFrontState):
(BlackBerry::WebKit::BackingStorePrivate::setCurrentBackingStoreOwner):
(BlackBerry::WebKit::BackingStore::releaseOwnedBackingStoreMemory):

Api/BackingStore_p.h:

(BackingStorePrivate):

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setVisible):
(BlackBerry::WebKit::WebPagePrivate::setCompositorDrawsRootLayer):

8:46 AM Changeset in webkit [142136] by mikhail.pozdnyakov@intel.com

2 edits in trunk/Source/WebCore

[WK2][EFL][QT]REGRESSION(r142045): Scrolling is broken
https://bugs.webkit.org/show_bug.cgi?id=109185

Reviewed by Kenneth Rohde Christiansen.

This patch is disabling paints clipping logic added at r142045 for the case
when the view should render the entire contents (case of using tiled backing store).

No new tests, covered by plenty of existing manual tests that allow scrolling
(for example fixed-position.html).

platform/ScrollView.cpp:

(WebCore::ScrollView::paint):

8:42 AM Changeset in webkit [142135] by kadam@inf.u-szeged.hu

26 edits
1 add in trunk/LayoutTests

[Qt] Unreviewed gardening. Added platform specific expected files after r140693.
https://bugs.webkit.org/show_bug.cgi?id=107567.

platform/qt/TestExpectations:
platform/qt/css2.1/t0505-c16-descendant-01-e-expected.png:
platform/qt/css2.1/t0505-c16-descendant-01-e-expected.txt:
platform/qt/editing/selection/extend-by-sentence-001-expected.png:
platform/qt/editing/selection/extend-by-sentence-001-expected.txt:
platform/qt/fast/inline/drawStyledEmptyInlines-expected.png:
platform/qt/fast/inline/drawStyledEmptyInlines-expected.txt:
platform/qt/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
platform/qt/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt:
platform/qt/fast/text/capitalize-empty-generated-string-expected.png:
platform/qt/fast/text/capitalize-empty-generated-string-expected.txt:
platform/qt/fast/text/whitespace/006-expected.png:
platform/qt/fast/text/whitespace/006-expected.txt:
platform/qt/fast/text/whitespace/007-expected.png:
platform/qt/fast/text/whitespace/007-expected.txt:
platform/qt/svg/batik/text/xmlSpace-expected.png:
platform/qt/svg/batik/text/xmlSpace-expected.txt:
platform/qt/svg/carto.net/combobox-expected.png:
platform/qt/svg/carto.net/combobox-expected.txt:
platform/qt/tables/mozilla/bugs/bug113235-3-expected.png:
platform/qt/tables/mozilla/bugs/bug113235-3-expected.txt:
platform/qt/tables/mozilla/bugs/bug1188-expected.png:
platform/qt/tables/mozilla/bugs/bug1188-expected.txt:
platform/qt/tables/mozilla/bugs/bug1318-expected.png:
platform/qt/tables/mozilla/bugs/bug1318-expected.txt:

8:42 AM Changeset in webkit [142134] by Csaba Osztrogonác

2 edits in trunk/Tools

Unreviewed warning fix.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(BuildAndTestFactory.init):
(DownloadAndPerfTestWebKit2Factory.init):

8:42 AM Changeset in webkit [142133] by Csaba Osztrogonác

2 edits in trunk/Tools

Unreviewed typo fix after r142121.

BuildSlaveSupport/build.webkit.org-config/config.json:

8:39 AM Changeset in webkit [142132] by pfeldman@chromium.org

10 edits in trunk/Source/WebCore

Web Inspector: Show elements and sources sidebar panes in a tabbed pane when they are below the main pane
https://bugs.webkit.org/show_bug.cgi?id=107552

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-07
Reviewed by Pavel Feldman.

Removed the aspect ratio detection logic and implemented explicit user action "Split Horizontally" available
in Elements and Sources panels. When split horizontally the sidebar panes are organized into a tabbed pane.
This user action is behind an experimental flag.

No new tests.

inspector/front-end/ContextMenu.js:

(WebInspector.ContextMenu.prototype.show):

inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.prototype.createProxy):
(WebInspector.DOMBreakpointsSidebarPane.prototype.onContentReady):
(WebInspector.DOMBreakpointsSidebarPane.Proxy):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype.expanded):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype.expand):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype.collapse):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype.onContentReady):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype.wasShown):
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype._reattachBody):

inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._populateContextMenu):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._clearInterface):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
(WebInspector.ScriptsPanel.prototype._contextMenuEventFired):

inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

inspector/front-end/SidebarPane.js:

(WebInspector.SidebarPane):
(WebInspector.SidebarPane.prototype.prepareContent):
(WebInspector.SidebarPane.prototype.expanded):
(WebInspector.SidebarPane.prototype.expand):
(WebInspector.SidebarPane.prototype.collapse):
(WebInspector.SidebarPane.prototype.onContentReady):
(WebInspector.SidebarPane.prototype._setExpandCallback):
(WebInspector.SidebarPaneStack.prototype.addPane):
(WebInspector.SidebarPaneStack.prototype.activePaneId):
(WebInspector.SidebarPaneStack.prototype.setActivePaneId):
(WebInspector.SidebarPaneStack.prototype._setExpanded):
(WebInspector.SidebarPaneStack.prototype._onPaneExpanded):
(WebInspector.SidebarPaneStack.prototype._collapsePane):
(WebInspector.SidebarTabbedPane):
(WebInspector.SidebarTabbedPane.prototype.addPane):
(WebInspector.SidebarTabbedPane.prototype.activePaneId):
(WebInspector.SidebarTabbedPane.prototype.setActivePaneId):
(WebInspector.SidebarPaneGroup):
(WebInspector.SidebarPaneGroup.prototype.setStacked):
(WebInspector.SidebarPaneGroup.prototype.addPane):
(WebInspector.SidebarPaneGroup.prototype.attachToPanel):
(WebInspector.SidebarPaneGroup.prototype.populateContextMenu.toggleSplitDirection):
(WebInspector.SidebarPaneGroup.prototype.get _contextMenuEventFired):
(WebInspector.SidebarPaneGroup.prototype._onSplitDirectionSettingChanged):

inspector/front-end/SidebarView.js:

(WebInspector.SidebarView):
(WebInspector.SidebarView.prototype._updateSidebarElementStyle):
(WebInspector.SidebarView.prototype.setVertical):
(WebInspector.SidebarView.prototype.onResize):

inspector/front-end/StylesSidebarPane.js:

(WebInspector.ComputedStyleSidebarPane.prototype.wasShown):
(WebInspector.ComputedStyleSidebarPane.prototype.prepareContent):

inspector/front-end/inspector.css:

(.sidebar-pane .section .properties, .event-bar .event-properties):
(.pane-title):
(.sidebar-pane-toolbar):
(.sidebar-pane-toolbar > *):
(.sidebar-pane-toolbar > select):
(.sidebar-pane-toolbar > select:hover):
(.sidebar-pane-toolbar > select:active):
(.sidebar-pane-toolbar > select.select-settings):
(.sidebar-pane-toolbar > select.select-filter):
(.sidebar-pane-toolbar > select > option, .sidebar-pane-toolbar > select > hr):
(.sidebar-pane-toolbar > .pane-title-button):
(.sidebar-pane-toolbar > .pane-title-button:hover):
(.sidebar-pane-toolbar > .pane-title-button:active, .sidebar-pane-toolbar > .pane-title-button.toggled):
(.sidebar-pane-toolbar > .pane-title-button.add):
(.sidebar-pane-toolbar > .pane-title-button.element-state):
(.sidebar-pane-toolbar > .pane-title-button.refresh):
(.sidebar-pane):
(.sidebar-pane > .body):
(.sidebar-pane > .body .info):
(.sidebar-pane > .body .placard + .info):
(.sidebar-pane.visible > .body):
(.sidebar-pane > .body .breakpoint-condition):
(.sidebar-pane.visible:nth-last-of-type(1)):
(.sidebar-pane-subtitle):
(.sidebar-pane-subtitle input, .section .header input[type=checkbox]):
(.sidebar-pane .breakpoint-hit):

8:38 AM Changeset in webkit [142131] by zandobersek@gmail.com

2 edits in trunk

[GTK] configure.ac requires a cleanup
https://bugs.webkit.org/show_bug.cgi?id=99272

Reviewed by Martin Robinson.

Clean up configure.ac. While there is no strict style guideline determined
for this file the changes enforce the usual indentation of four spaces along
with line wrapping at 130 characters and grammar fixes/updates.

configure.ac:

8:37 AM Changeset in webkit [142130] by gavinp@chromium.org

5 edits
6 deletes in trunk

Unreviewed, rolling out r142111.
http://trac.webkit.org/changeset/142111
https://bugs.webkit.org/show_bug.cgi?id=108055

win7 bot didn't display Arabic, see http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=platform%2Fchromium%2Ffast%2Fforms%2Fcalendar-picker%2Fcalendar-picker-appearance-required-ar.html

Source/WebCore:

Resources/pagepopups/calendarPicker.css:

(.today-clear-area .today-button):

Resources/pagepopups/calendarPicker.js:

(CalendarPicker.prototype.fixWindowSize):

LayoutTests:

platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Removed.
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Removed.
platform/chromium/TestExpectations:
platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.txt: Removed.
platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html: Removed.
platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.txt: Removed.
platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html: Removed.

8:31 AM Changeset in webkit [142129] by caio.oliveira@openbossa.org

2 edits in trunk/Source/WTF

[Qt] Fix build without 3D_GRAPHICS
https://bugs.webkit.org/show_bug.cgi?id=109194

Reviewed by Noam Rosenthal.

Now that Coordinated Graphics was moved to WebCore, we need to explicitly enable
it when we have 3D_GRAPHICS. This dependency was implicitly by the fact that
3D_GRAPHICS is a dependency of WebKit2 and Coordinated Graphics was only
available there. This should fix build for Qt SH4 Linux.

wtf/Platform.h:

8:30 AM Changeset in webkit [142128] by vsevik@chromium.org

5 edits in trunk

Web Inspector: [Regression] Map.size() returns negative values.
https://bugs.webkit.org/show_bug.cgi?id=109174

Reviewed by Yury Semikhatsky.

Source/WebCore:

inspector/front-end/utilities.js:

LayoutTests:

inspector/map-expected.txt:
inspector/map.html:

8:25 AM Changeset in webkit [142127] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: break details are only rendered upon first debugger pause.
https://bugs.webkit.org/show_bug.cgi?id=109193

Reviewed by Vsevolod Vlasov.

inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype.update):

8:22 AM Changeset in webkit [142126] by gavinp@chromium.org

35 edits in trunk/Source/WebCore

Unreviewed, rolling out r142118.
http://trac.webkit.org/changeset/142118
https://bugs.webkit.org/show_bug.cgi?id=109044

Broke SVG! Oh noes!

Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::direction):

Modules/indexeddb/IDBObjectStore.cpp:

(WebCore):

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::mode):

dom/ContainerNode.cpp:

(WebCore::ContainerNode::takeAllChildrenFrom):

dom/Document.cpp:

(WebCore::Document::setTitle):

dom/MessagePort.cpp:

(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::disentanglePorts):

editing/DeleteButtonController.cpp:

(WebCore::enclosingDeletableElement):
(WebCore::DeleteButtonController::createDeletionUI):
(WebCore::DeleteButtonController::show):

editing/EditorCommand.cpp:

(WebCore::unionDOMRanges):

editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

editing/ReplaceSelectionCommand.cpp:

editing/SplitTextNodeCommand.cpp:

(WebCore::SplitTextNodeCommand::doUnapply):

editing/TextIterator.cpp:

(WebCore::CharacterIterator::range):
(WebCore::BackwardsCharacterIterator::range):
(WebCore::TextIterator::rangeFromLocationAndLength):
(WebCore::collapsedToBoundary):

editing/htmlediting.cpp:

(WebCore::createTabSpanElement):

editing/mac/EditorMac.mm:

(WebCore::Editor::fontForSelection):
(WebCore::Editor::fontAttributesForSelectionStart):

editing/markup.cpp:

html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree):

html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updatePlaceholderText):

html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::indexForVisiblePosition):
(WebCore::HTMLTextFormControlElement::setInnerTextValue):

html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::updatePlaceholderText):

html/ValidationMessage.cpp:

(WebCore::ValidationMessage::buildBubbleTree):

html/shadow/MediaControlElementTypes.cpp:

(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::getCookies):

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::addRule):

loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::dispatchDOMEvent):

page/DOMSelection.cpp:

(WebCore::DOMSelection::deleteFromDocument):

page/DragController.cpp:

(WebCore::prepareClipboardForImageDrag):

rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::visiblePositionForIndex):

rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::initialBaselineShiftValue):
(WebCore::SVGRenderStyle::initialKerning):
(WebCore::SVGRenderStyle::initialStrokeDashOffset):
(WebCore::SVGRenderStyle::initialStrokeWidth):

svg/SVGAnimatedLength.cpp:

(WebCore::sharedSVGLength):
(WebCore::SVGAnimatedLengthAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):

svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):

svg/SVGLength.cpp:

(WebCore::SVGLength::SVGLength):

svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::textLengthAnimated):

svg/animation/SVGSMILElement.cpp:

(WebCore::constructQualifiedName):

8:21 AM WebKitGTK/1.10.x edited by Martin Robinson

(diff)

8:19 AM WebKitGTK/1.10.x edited by Martin Robinson

(diff)

8:04 AM Changeset in webkit [142125] by vivek.vg@samsung.com

3 edits in trunk/Tools

[Qt] QtTestBrowser should provide option to enable/disable Javascript
https://bugs.webkit.org/show_bug.cgi?id=107461

Reviewed by Jocelyn Turcotte.

Option to enable/disable Javascript would be handy option to test
certain functionalities of web pages with/without Javascript.

QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::createChrome):
(LauncherWindow::toggleJavaScriptEnabled):

QtTestBrowser/launcherwindow.h:

(LauncherWindow):

7:56 AM Changeset in webkit [142124] by haraken@chromium.org

2 edits in trunk/Source/WebCore

Remove #if USE(V8) from IDBRequest.h
https://bugs.webkit.org/show_bug.cgi?id=109163

Reviewed by Andreas Kling.

The header included inside the #if USE(V8) macro is not used.
We can simply remove it.

No tests. No change in behavior.

Modules/indexeddb/IDBRequest.h:

7:53 AM Changeset in webkit [142123] by schenney@chromium.org

3 edits in trunk/Source/WebCore

GraphicsContext::drawImageBuffer is inefficient
https://bugs.webkit.org/show_bug.cgi?id=104367

Reviewed by Dirk Schulze.

This patch converts all of the drawImage and drawImageBuffer
convenience methods (those that take parameters of various types) to
invoke the implementing method (that takes FloatRect src and dest)
directly, rather than through the next-most-convenient method as was
done previously. This will knock some layers off the stack compared
to the existing code, and may remove one or two constructor invocations.
This may be slightly more efficient, and also makes debugging simpler.

Also removes the unused drawImage method that takes and IntRect source
area and IntRect destination. It is not invoked anywhere in a standard
WebKit checkout.

No new tests. No change in functionality, just refactoring.

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage): Modify all the convenience versions to call
the implementing version directly.
(WebCore::GraphicsContext::drawImageBuffer): Modify all the convenience versions
to call the implementing version directly.

platform/graphics/GraphicsContext.h:

(GraphicsContext): Remove IntRect, IntRect version of drawImage.

7:46 AM Changeset in webkit [142122] by tkent@chromium.org

3 edits
2 adds in trunk

Conversion from localized numbers to HTML numbers should accept not only localized numbers but also HTML numbers
https://bugs.webkit.org/show_bug.cgi?id=109160

Reviewed by Kentaro Hara.

Source/WebCore:

For example, A French user needs to specify a number to a number input
field. He might use a local decimal point, like 3,141592, or he might
use the standard decimal point like 3.141592. We had better accept both
of them.

We accepted both last year, but we changed the behavior so that we
accept only localized numbers because we had some cases where an input
string can be recognized as both of a localized number and the standard
number. e.g. 3.141 is 3141 in French locale and 3.141 in the
standard. Now we introduce a simple rule that we don't accept group
separator at all. So users won't confuse even if we accept both of
decimal points.

Test: fast/forms/number/number-l10n-input.html

platform/text/PlatformLocale.cpp:

(WebCore::Locale::convertFromLocalizedNumber):
If the specified string contains invalid characters including group
separators, just return the specified string.

LayoutTests:

fast/forms/number/number-l10n-input-expected.txt: Added.
fast/forms/number/number-l10n-input.html: Added.

7:35 AM Changeset in webkit [142121] by rakuco@webkit.org

2 edits in trunk/Tools

[EFL] Add a WebKit2 Performance bot.
https://bugs.webkit.org/show_bug.cgi?id=109188

Reviewed by Csaba Osztrogonác.

BuildSlaveSupport/build.webkit.org-config/config.json: Add the

efl-linux-perf-1 slave (a 64-bit Release WK2 Perf bot), and make
the "EFL Linux 64-bit Release" bot trigger it.

7:24 AM Changeset in webkit [142120] by commit-queue@webkit.org

11 edits in trunk

[BlackBerry] CHHW - Characters that are using 32 bits encoding get trunked to 16bits
https://bugs.webkit.org/show_bug.cgi?id=109126
PR 292540

Source/WebCore:

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-02-07
Reviewed by Yong Li.

Change char code to 4 bytes.
Need to convert UTF32 key char to UTF16 before constructing a WTF::String.

platform/PlatformKeyboardEvent.h:

(WebCore::PlatformKeyboardEvent::unmodifiedCharacter):
(PlatformKeyboardEvent):

platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:

(WebCore::keyIdentifierForBlackBerryCharacter):
(WebCore::windowsKeyCodeForBlackBerryCharacter):
(WebCore::adjustCharacterFromOS):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

Source/WebKit/blackberry:

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-02-07
Reviewed by Yong Li.
Internally reviewed by Mike Fenton.

Key char is UTF32 encoded, should be 4 bytes.

Api/WebPage.cpp:

(BlackBerry::WebKit::handleScrolling):

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::handleKeyboardInput):

WebKitSupport/InputHandler.h:

(InputHandler):

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::directionOfPointRelativeToRect):
(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
(BlackBerry::WebKit::shouldExtendSelectionInDirection):
(BlackBerry::WebKit::directionalVisiblePositionAtExtentOfBox):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):

WebKitSupport/SelectionHandler.h:

(SelectionHandler):

Tools:

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-02-07
Reviewed by Yong Li.

Change char code to 4 bytes.

DumpRenderTree/blackberry/EventSender.cpp:

(keyDownCallback):

7:21 AM Changeset in webkit [142119] by senorblanco@chromium.org

8 edits
4 adds in trunk/LayoutTests

[chromium] New baselines for GPU-accelerated reference filters tests. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=104289

platform/chromium-linux/css3/filters/effect-reference-hw-expected.png: Added.
platform/chromium-linux/css3/filters/effect-reference-ordering-hw-expected.png:
platform/chromium-mac-lion/css3/filters/effect-reference-hw-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-reference-hw-expected.txt: Added.
platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
platform/chromium-mac/css3/filters/effect-reference-hw-expected.txt:
platform/chromium-mac/css3/filters/effect-reference-ordering-hw-expected.png:
platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
platform/chromium-win/css3/filters/effect-reference-ordering-hw-expected.png:
platform/chromium/TestExpectations:

7:14 AM Changeset in webkit [142118] by mkwst@chromium.org

35 edits in trunk/Source/WebCore

Replace ExceptionCode assertions with ASSERT_NO_EXCEPTION macro.
https://bugs.webkit.org/show_bug.cgi?id=109044

Reviewed by Darin Adler.

The pattern:

ExceptionCode ec = 0;
methodThatGeneratesException(ec);
ASSERT(!ec);

is more clearly and succinctly written as:

methodThatGeneratesException(ASSERT_NO_EXCEPTION);

No change in behavior should result from this refactoring.

Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::direction):

Modules/indexeddb/IDBObjectStore.cpp:

(WebCore):

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::mode):

dom/ContainerNode.cpp:

(WebCore::ContainerNode::takeAllChildrenFrom):

dom/Document.cpp:

(WebCore::Document::setTitle):

dom/MessagePort.cpp:

(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::disentanglePorts):

editing/DeleteButtonController.cpp:

(WebCore::enclosingDeletableElement):
(WebCore::DeleteButtonController::createDeletionUI):

Replaced inline ASSERT with ASSERT_NO_EXCEPTION.

(WebCore::DeleteButtonController::show):

Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.

editing/EditorCommand.cpp:

(WebCore::unionDOMRanges):

editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren):

editing/ReplaceSelectionCommand.cpp:

editing/SplitTextNodeCommand.cpp:

(WebCore::SplitTextNodeCommand::doUnapply):

editing/TextIterator.cpp:

(WebCore::CharacterIterator::range):
(WebCore::BackwardsCharacterIterator::range):
(WebCore::TextIterator::rangeFromLocationAndLength):
(WebCore::collapsedToBoundary):

editing/htmlediting.cpp:

(WebCore::createTabSpanElement):

editing/mac/EditorMac.mm:

(WebCore::Editor::fontForSelection):
(WebCore::Editor::fontAttributesForSelectionStart):

editing/markup.cpp:

html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtree):

Replaced inline ASSERT with ASSERT_NO_EXCEPTION.

html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):

Replaced 'ASSERT(ec == 0)' with 'ASSERT(!ec)' to match the style guide.

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updatePlaceholderText):

html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::indexForVisiblePosition):
(WebCore::HTMLTextFormControlElement::setInnerTextValue):

html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::updatePlaceholderText):

html/ValidationMessage.cpp:

(WebCore::ValidationMessage::buildBubbleTree):

html/shadow/MediaControlElementTypes.cpp:

(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::getCookies):

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::addRule):

loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::dispatchDOMEvent):

page/DOMSelection.cpp:

(WebCore::DOMSelection::deleteFromDocument):

page/DragController.cpp:

(WebCore::prepareClipboardForImageDrag):

rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::visiblePositionForIndex):

rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::initialBaselineShiftValue):
(WebCore::SVGRenderStyle::initialKerning):
(WebCore::SVGRenderStyle::initialStrokeDashOffset):
(WebCore::SVGRenderStyle::initialStrokeWidth):

svg/SVGAnimatedLength.cpp:

(WebCore::sharedSVGLength):
(WebCore::SVGAnimatedLengthAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):

svg/SVGAnimatedLengthList.cpp:

(WebCore::SVGAnimatedLengthListAnimator::addAnimatedTypes):
(WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):

svg/SVGLength.cpp:

(WebCore::SVGLength::SVGLength):

svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::textLengthAnimated):

svg/animation/SVGSMILElement.cpp:

(WebCore::constructQualifiedName):

Replaced inline ASSERT with ASSERT_NO_EXCEPTION.

7:08 AM Changeset in webkit [142117] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Reader Mode: Opening two links quickly from reader mode causes browser bad state
https://bugs.webkit.org/show_bug.cgi?id=109124

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2013-02-07
Reviewed by Yong Li.

RIM BUG 291246 Internally reviewed by YongLi.
Move the WebPageGroupLoadDeferrer object from ChromeClientBlackBerry::createWindow()
into WebPageClientImpl::createWindow() to make it more close to its protecting place.

WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::createWindow):

7:07 AM Changeset in webkit [142116] by mifenton@rim.com

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Send type details with IMF mask as part of focus gained.
https://bugs.webkit.org/show_bug.cgi?id=109086

Reviewed by Yong Li.

PR 292609.

Add masking options based on VKB type to the IMF mask.

Reviewed Internally by Nima Ghanavatian.

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::addInputStyleMaskForKeyboardType):
(WebKit):
(BlackBerry::WebKit::InputHandler::setElementFocused):

7:05 AM Changeset in webkit [142115] by mary.wu@torchmobile.com.cn

3 edits in trunk/Source/WebCore

[BlackBerry] Export mimeType in NetworkJob
https://bugs.webkit.org/show_bug.cgi?id=109002

Reviewed by Yong Li.

NetworkJob will analysize resource mimetype and set it to resourceResponse,
we will pass it on to be used by other Streams like download stream.

RIM bug# 284408, internally reviewed by Liam Quinn.

platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::mimeType):
(WebCore):

platform/network/blackberry/NetworkJob.h:

(NetworkJob):

7:00 AM Changeset in webkit [142114] by commit-queue@webkit.org

20 edits
3 adds in trunk

Web Inspector: support JavaScript variable mutation in protocol and V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=107829

Source/WebCore:

A new command is added to protocol description and the call is passed through
debugger agent through injected script and debugger script down to V8 mirror
API. JSC bindings got a thorw exception stub.

Only declarative JavaScript scopes are supported (local, closure, catch). Other
scopes (global, with) are not supported by V8 and not supported by protocol, because
manual approach (direct property assigment) is available for them in form of evaluate
commands and is more desirable because of a complex nature of operation (it can throw
exception in several cases such as exception in setter function).

Patch by Peter Rybin <prybin@chromium.org> on 2013-02-07
Reviewed by Pavel Feldman.

Test: inspector-protocol/debugger-setVariableValue.html

bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::setFunctionVariableValue):
(WebCore):

bindings/js/JSJavaScriptCallFrameCustom.cpp:

(WebCore::JSJavaScriptCallFrame::setVariableValue):
(WebCore):

bindings/v8/DebuggerScript.js:

(.):

bindings/v8/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::setVariableValue):
(WebCore):

bindings/v8/JavaScriptCallFrame.h:

(JavaScriptCallFrame):

bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setFunctionVariableValue):
(WebCore):

bindings/v8/ScriptDebugServer.h:

(ScriptDebugServer):

bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::setFunctionVariableValueCallback):
(WebCore):

bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:

(WebCore::V8JavaScriptCallFrame::setVariableValueCallback):
(WebCore):

inspector/InjectedScript.cpp:

(WebCore::InjectedScript::setVariableValue):
(WebCore):

inspector/InjectedScript.h:

(InjectedScript):

inspector/InjectedScriptHost.idl:
inspector/InjectedScriptSource.js:

(.):

inspector/Inspector.json:
inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::setVariableValue):
(WebCore):

inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

inspector/JavaScriptCallFrame.idl:

LayoutTests:

Patch by Peter Rybin <prybin@chromium.org> on 2013-02-07
Reviewed by Pavel Feldman.

inspector-protocol/debugger-setVariableValue-expected.txt: Added.
inspector-protocol/debugger-setVariableValue.html: Added.
inspector/console/command-line-api-expected.txt:
platform/chromium/inspector-protocol/debugger-setVariableValue-expected.txt: Added.

6:56 AM Changeset in webkit [142113] by yurys@chromium.org

5 edits in trunk/LayoutTests

Web Inspector: reduce number of native memory instrumentation categories
https://bugs.webkit.org/show_bug.cgi?id=109146

Reviewed by Pavel Feldman.

Fix layout tests that started failing after r142081.

inspector/profiler/memory-instrumentation-cached-images-expected.txt:
inspector/profiler/memory-instrumentation-cached-images.html:
inspector/profiler/memory-instrumentation-canvas-expected.txt:
inspector/profiler/memory-instrumentation-canvas.html:

6:47 AM Changeset in webkit [142112] by caio.oliveira@openbossa.org

12 edits
4 adds in trunk

[CoordinatedGraphics] Use ScrollingCoordinator to track fixed layers
https://bugs.webkit.org/show_bug.cgi?id=108990

Reviewed by Noam Rosenthal.

Add a new test that allow us to remove the fixed positioning of a layer but still keeping
it compositing. Coordinated Graphics had a bug where the CoordinatedSceneGraph would still
count this layer as fixed position.

ManualTests/remove-fixed-position-but-keep-compositing.html: Added.

Source/WebCore:

Reviewed by Noam Rosenthal.

WebCore keeps ScrollingCoordinator up-to-date about whether layers are fixed or not, so we
don't need to traverse the tree every frame to get this information.

The function ScrollingCoordinator::setLayerIsFixedToContainerLayer() is called when
RenderLayerBacking is updating its graphics layers.

The new code also works in new situations where the previous was broken: if a layer changed
from being fixed to not fixed (but still kept as a layer for other reasons), the layer will
be correctly updated. Previous implementation only had logic to mark layers as fixed, but
not the other way round. A manual test was added to illustrate the solved problem.

Testing was done with the existing manual tests that make use of "position:fixed". Automatic
tests are mostly not affected by this because usage of this information affects only the
UseFixedLayout mode, not used by default in WebKitTestRunner. Work to improve this situation
will be tracked in bug https://bugs.webkit.org/show_bug.cgi?id=109175.

CMakeLists.txt:
Target.pri:
WebCore.pri:
page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::create): create specific version of ScrollingCoordinator.

page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp: Added.

(WebCore):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::ScrollingCoordinatorCoordinatedGraphics):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::setLayerIsFixedToContainerLayer):
update layer information using existing hook in ScrollingCoordinator.

page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h: Added.

(WebCore):
(ScrollingCoordinatorCoordinatedGraphics):

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setFixedToViewport): now that setting viewport is not
embedded in the synchronization work, we need to mark the layer so it is updated in the
next frame.
(WebCore):
(WebCore::CoordinatedGraphicsLayer::flushCompositingState): remove call to syncFixedLayers().

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient): remove now unused syncFixedLayers() from client.
(CoordinatedGraphicsLayer):

Source/WebKit2:

Reviewed by Noam Rosenthal.
Signed off for WebKit2 by Simon Fraser.

WebCore keeps ScrollingCoordinator up-to-date about whether layers are fixed or not, so we
don't need to traverse the tree every frame to get this information.

WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp: remove

syncFixedLayers() and its helper functions. Those were used to identify the fixed layers
and are not needed anymore.

WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl): enable the scrolling coordinator usage for
Coordinated Graphics.

6:42 AM Changeset in webkit [142111] by keishi@webkit.org

5 edits
6 adds in trunk

Source/WebCore: REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute
https://bugs.webkit.org/show_bug.cgi?id=109136

Reviewed by Kent Tamura.

Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html

platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html

Resources/pagepopups/calendarPicker.css:

(.today-clear-area):

Resources/pagepopups/calendarPicker.js:

(CalendarPicker.prototype.fixWindowSize): Fixing the logic to calculate
the width. We don't want to use clear button because it doesn't exist
when a value is required.

LayoutTests: REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute
https://bugs.webkit.org/show_bug.cgi?id=108055

Reviewed by Kent Tamura.

platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.txt: Added.
platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html: Added.
platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.txt: Added.
platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html: Added.
platform/chromium/TestExpectations:

6:32 AM Changeset in webkit [142110] by kadam@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing test.

platform/qt/TestExpectations:

6:20 AM Changeset in webkit [142109] by gavinp@chromium.org

31 edits
3 deletes in trunk/Tools

Unreviewed, rolling out r142090.
http://trac.webkit.org/changeset/142090
https://bugs.webkit.org/show_bug.cgi?id=108466

lots of selection expectations failures

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
DumpRenderTree/chromium/TestRunner/public/WebTask.h:

(WebTaskList):

DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebTestInterfaces):

DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestProxyBase):

DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):

DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:

(AccessibilityUIElementList):

DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:

DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:

(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):

DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:

DumpRenderTree/chromium/TestRunner/src/CppVariant.h:

(CppVariant):

DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:

(WebTestRunner::NativeKeyCodeForWindowsKeyCode):

DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:

(MockGrammarCheck::checkGrammarOfString):

DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:

(MockGrammarCheck):

DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:

(append):
(isNotASCIIAlpha):
(MockSpellCheck::spellCheckWord):
(MockSpellCheck::initializeIfNeeded):

DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:

(MockSpellCheck):

DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:

(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):

DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):

DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:

DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:

(TestPlugin):

DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):

DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:

(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):

DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):

DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:

DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):

DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

DumpRenderTree/chromium/TestRunner/src/config.h: Removed.

6:14 AM Changeset in webkit [142108] by kov@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed build fix. libWebCore.la needs to be relinked when
symbols.filter changes.

GNUmakefile.am: add symbols.filter as a dependency for the

libWebCore.la library.

5:56 AM Changeset in webkit [142107] by vsevik@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: Closure compilation fixes
https://bugs.webkit.org/show_bug.cgi?id=109131

Reviewed by Yury Semikhatsky.

inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):

inspector/front-end/FileSystemMapping.js:

(WebInspector.FileSystemMappingImpl.prototype.uriPrefixForPathPrefix):

inspector/front-end/IsolatedFileSystemModel.js:

(WebInspector.IsolatedFileSystemModel.prototype._fileSystemRemoved):

inspector/front-end/SidebarPane.js:

5:51 AM Changeset in webkit [142106] by kadam@inf.u-szeged.hu

3 edits
2 adds in trunk/LayoutTests

[Qt] Unreviwed gardening. Rebaselining and skipping new failures.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-02-07

platform/qt/TestExpectations:
platform/qt/fast/dynamic/002-expected.txt:
platform/qt/fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated-expected.txt: Added.
platform/qt/fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated-expected.txt: Added.

5:48 AM Changeset in webkit [142105] by kov@webkit.org

2 edits in trunk

Unreviewed build fix after r141196 for 32 bits autotools.

Source/autotools/symbols.filter: restore 32 bits version of the

WebCore::TextIterator::getLocationAndLengthFromRange(WebCore::Node*,
WebCore::Range const*, unsigned int&, unsigned int&) symbol.

5:47 AM Changeset in webkit [142104] by Gregg Tavares

1 edit
30 adds in trunk/LayoutTests

Add WebGL Conformance Tests state, renderbuffers, and reading folders.
https://bugs.webkit.org/show_bug.cgi?id=109121

Reviewed by Kenneth Russell.

webgl/conformance/reading/read-pixels-pack-alignment-expected.txt: Added.
webgl/conformance/reading/read-pixels-pack-alignment.html: Added.
webgl/conformance/renderbuffers/framebuffer-state-restoration-expected.txt: Added.
webgl/conformance/renderbuffers/framebuffer-state-restoration.html: Added.
webgl/conformance/renderbuffers/framebuffer-test-expected.txt: Added.
webgl/conformance/renderbuffers/framebuffer-test.html: Added.
webgl/conformance/renderbuffers/renderbuffer-initialization-expected.txt: Added.
webgl/conformance/renderbuffers/renderbuffer-initialization.html: Added.
webgl/conformance/state/gl-enable-enum-test-expected.txt: Added.
webgl/conformance/state/gl-enable-enum-test.html: Added.
webgl/conformance/state/gl-enum-tests-expected.txt: Added.
webgl/conformance/state/gl-enum-tests.html: Added.
webgl/conformance/state/gl-get-calls-expected.txt: Added.
webgl/conformance/state/gl-get-calls.html: Added.
webgl/conformance/state/gl-geterror-expected.txt: Added.
webgl/conformance/state/gl-geterror.html: Added.
webgl/conformance/state/gl-getstring-expected.txt: Added.
webgl/conformance/state/gl-getstring.html: Added.
webgl/resources/webgl_test_files/conformance/reading/00_test_list.txt: Added.
webgl/resources/webgl_test_files/conformance/reading/read-pixels-pack-alignment.html: Added.
webgl/resources/webgl_test_files/conformance/renderbuffers/00_test_list.txt: Added.
webgl/resources/webgl_test_files/conformance/renderbuffers/framebuffer-state-restoration.html: Added.
webgl/resources/webgl_test_files/conformance/renderbuffers/framebuffer-test.html: Added.
webgl/resources/webgl_test_files/conformance/renderbuffers/renderbuffer-initialization.html: Added.
webgl/resources/webgl_test_files/conformance/state/00_test_list.txt: Added.
webgl/resources/webgl_test_files/conformance/state/gl-enable-enum-test.html: Added.
webgl/resources/webgl_test_files/conformance/state/gl-enum-tests.html: Added.
webgl/resources/webgl_test_files/conformance/state/gl-get-calls.html: Added.
webgl/resources/webgl_test_files/conformance/state/gl-geterror.html: Added.
webgl/resources/webgl_test_files/conformance/state/gl-getstring.html: Added.

5:37 AM Changeset in webkit [142103] by haraken@chromium.org

7 edits in trunk/Source/WebCore

Unreviewed, rolling out r142077.
http://trac.webkit.org/changeset/142077
https://bugs.webkit.org/show_bug.cgi?id=108579

fast/filesystem/workers/file-writer-empty-blob.html is broken

bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::setWrapperInObject):

bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolated):

bindings/v8/V8Binding.h:

(WebCore):
(WebCore::worldForEnteredContextIfIsolated):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):

bindings/v8/V8GCController.cpp:

(WebCore::WrapperVisitor::WrapperVisitor):
(WebCore):
(WebCore::gcTree):
(WebCore::V8GCController::didCreateWrapperForNode):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):

bindings/v8/V8GCController.h:

(V8GCController):

5:36 AM Changeset in webkit [142102] by Gregg Tavares

1 edit
29 adds in trunk/LayoutTests

Add WebGL Conformance Tests rendering folder.
https://bugs.webkit.org/show_bug.cgi?id=109122

Reviewed by Kenneth Russell.

webgl/conformance/rendering/culling-expected.txt: Added.
webgl/conformance/rendering/culling.html: Added.
webgl/conformance/rendering/draw-arrays-out-of-bounds-expected.txt: Added.
webgl/conformance/rendering/draw-arrays-out-of-bounds.html: Added.
webgl/conformance/rendering/draw-elements-out-of-bounds-expected.txt: Added.
webgl/conformance/rendering/draw-elements-out-of-bounds.html: Added.
webgl/conformance/rendering/gl-clear-expected.txt: Added.
webgl/conformance/rendering/gl-clear.html: Added.
webgl/conformance/rendering/gl-drawelements-expected.txt: Added.
webgl/conformance/rendering/gl-drawelements.html: Added.
webgl/conformance/rendering/gl-scissor-fbo-test-expected.txt: Added.
webgl/conformance/rendering/gl-scissor-fbo-test.html: Added.
webgl/conformance/rendering/line-loop-tri-fan-expected.txt: Added.
webgl/conformance/rendering/line-loop-tri-fan.html: Added.
webgl/conformance/rendering/simple-expected.txt: Added.
webgl/conformance/rendering/simple.html: Added.
webgl/conformance/rendering/triangle-expected.txt: Added.
webgl/conformance/rendering/triangle.html: Added.
webgl/resources/webgl_test_files/conformance/rendering/00_test_list.txt: Added.
webgl/resources/webgl_test_files/conformance/rendering/culling.html: Added.
webgl/resources/webgl_test_files/conformance/rendering/draw-arrays-out-of-bounds.html: Added.
webgl/resources/webgl_test_files/conformance/rendering/draw-elements-out-of-bounds.html: Added.
webgl/resources/webgl_test_files/conformance/rendering/gl-clear.html: Added.
webgl/resources/webgl_test_files/conformance/rendering/gl-drawelements.html: Added.
webgl/resources/webgl_test_files/conformance/rendering/gl-scissor-fbo-test.html: Added.
webgl/resources/webgl_test_files/conformance/rendering/line-loop-tri-fan.html: Added.
webgl/resources/webgl_test_files/conformance/rendering/simple.html: Added.
webgl/resources/webgl_test_files/conformance/rendering/triangle.html: Added.
webgl/resources/webgl_test_files/conformance/rendering/vertex-texture-fetch.html: Added.

5:20 AM Changeset in webkit [142101] by senorblanco@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

DEPS:

5:05 AM Changeset in webkit [142100] by Gregg Tavares

1 edit
25 adds in trunk/LayoutTests

Add WebGL Conformance Tests programs folder.
https://bugs.webkit.org/show_bug.cgi?id=109120

Reviewed by Kenneth Russell.

webgl/conformance/programs/get-active-test-expected.txt: Added.
webgl/conformance/programs/get-active-test.html: Added.
webgl/conformance/programs/gl-bind-attrib-location-test-expected.txt: Added.
webgl/conformance/programs/gl-bind-attrib-location-test.html: Added.
webgl/conformance/programs/gl-get-active-attribute-expected.txt: Added.
webgl/conformance/programs/gl-get-active-attribute.html: Added.
webgl/conformance/programs/gl-get-active-uniform-expected.txt: Added.
webgl/conformance/programs/gl-get-active-uniform.html: Added.
webgl/conformance/programs/gl-getshadersource-expected.txt: Added.
webgl/conformance/programs/gl-getshadersource.html: Added.
webgl/conformance/programs/gl-shader-test-expected.txt: Added.
webgl/conformance/programs/gl-shader-test.html: Added.
webgl/conformance/programs/invalid-UTF-16-expected.txt: Added.
webgl/conformance/programs/invalid-UTF-16.html: Added.
webgl/conformance/programs/use-program-crash-with-discard-in-fragment-shader-expected.txt: Added.
webgl/conformance/programs/use-program-crash-with-discard-in-fragment-shader.html: Added.
webgl/resources/webgl_test_files/conformance/programs/00_test_list.txt: Added.
webgl/resources/webgl_test_files/conformance/programs/get-active-test.html: Added.
webgl/resources/webgl_test_files/conformance/programs/gl-bind-attrib-location-test.html: Added.
webgl/resources/webgl_test_files/conformance/programs/gl-get-active-attribute.html: Added.
webgl/resources/webgl_test_files/conformance/programs/gl-get-active-uniform.html: Added.
webgl/resources/webgl_test_files/conformance/programs/gl-getshadersource.html: Added.
webgl/resources/webgl_test_files/conformance/programs/gl-shader-test.html: Added.
webgl/resources/webgl_test_files/conformance/programs/invalid-UTF-16.html: Added.
webgl/resources/webgl_test_files/conformance/programs/use-program-crash-with-discard-in-fragment-shader.html: Added.

5:01 AM Changeset in webkit [142099] by tonyg@chromium.org

9 edits in trunk/Source/WebCore

Call XSSAuditor.filterToken() from threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=107603

Reviewed by Adam Barth.

With this patch we now pass 180 of 182 tests in http/tests/security/xssAuditor.

We do this by creating aan XSSAuditor on the main thread and passing ownership of them to the BackgroundHTMLParser upon its creation.

Then the background thread calls filterToken() and stores the resulting XSSInfo (if any) on the CompactHTMLToken for the main thread to handle.

This involved trimming the XSSAuditor to only depend on the TextEncoding instead of the whole TextResourceDecoder.

No new tests because covered by existing tests.

html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(WebCore::BackgroundHTMLParser::createPartial):

html/parser/BackgroundHTMLParser.h:

(WebCore):
(WebCore::BackgroundHTMLParser::create):
(BackgroundHTMLParser):

html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::startBackgroundParser):

html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::start):
(WebCore::HTMLSourceTracker::end):

html/parser/HTMLSourceTracker.h: Change the HTMLInputStream args to SegmentedString because the background thread only has a BackgroundHTMLInputStream.

(HTMLSourceTracker):

html/parser/HTMLViewSourceParser.cpp:

(WebCore::HTMLViewSourceParser::pumpTokenizer):

html/parser/XSSAuditor.cpp:

(WebCore::fullyDecodeString):
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init): Copies necessary to make isSafeToSendToAnotherThread() happy.
(WebCore::XSSAuditor::decodedSnippetForName):
(WebCore::XSSAuditor::decodedSnippetForAttribute):
(WebCore::XSSAuditor::decodedSnippetForJavaScript):
(WebCore::XSSAuditor::isSafeToSendToAnotherThread): Check that all String and KURL members are safe to send to another thread.
(WebCore):

html/parser/XSSAuditor.h:

(WebCore):
(WebCore::FilterTokenRequest::FilterTokenRequest):
(FilterTokenRequest):
(XSSAuditor):

4:57 AM Changeset in webkit [142098] by Gregg Tavares

1 edit
38 adds in trunk/LayoutTests

Add WebGL Conformance Tests context folder.
https://bugs.webkit.org/show_bug.cgi?id=109114

Reviewed by Kenneth Russell.

webgl/conformance/context/constants-expected.txt: Added.
webgl/conformance/context/constants.html: Added.
webgl/conformance/context/context-attributes-alpha-depth-stencil-antialias-expected.txt: Added.
webgl/conformance/context/context-attributes-alpha-depth-stencil-antialias.html: Added.
webgl/conformance/context/context-lost-expected.txt: Added.
webgl/conformance/context/context-lost-restored-expected.txt: Added.
webgl/conformance/context/context-lost-restored.html: Added.
webgl/conformance/context/context-lost.html: Added.
webgl/conformance/context/context-release-upon-reload-expected.txt: Added.
webgl/conformance/context/context-release-upon-reload.html: Added.
webgl/conformance/context/context-release-with-workers-expected.txt: Added.
webgl/conformance/context/context-release-with-workers.html: Added.
webgl/conformance/context/context-type-test-expected.txt: Added.
webgl/conformance/context/context-type-test.html: Added.
webgl/conformance/context/incorrect-context-object-behaviour-expected.txt: Added.
webgl/conformance/context/incorrect-context-object-behaviour.html: Added.
webgl/conformance/context/methods-expected.txt: Added.
webgl/conformance/context/methods.html: Added.
webgl/conformance/context/premultiplyalpha-test-expected.txt: Added.
webgl/conformance/context/premultiplyalpha-test.html: Added.
webgl/conformance/context/resource-sharing-test-expected.txt: Added.
webgl/conformance/context/resource-sharing-test.html: Added.
webgl/resources/webgl_test_files/conformance/context/00_test_list.txt: Added.
webgl/resources/webgl_test_files/conformance/context/constants.html: Added.
webgl/resources/webgl_test_files/conformance/context/context-attributes-alpha-depth-stencil-antialias.html: Added.
webgl/resources/webgl_test_files/conformance/context/context-lost-restored.html: Added.
webgl/resources/webgl_test_files/conformance/context/context-lost.html: Added.
webgl/resources/webgl_test_files/conformance/context/context-release-upon-reload.html: Added.
webgl/resources/webgl_test_files/conformance/context/context-release-with-workers.html: Added.
webgl/resources/webgl_test_files/conformance/context/context-type-test.html: Added.
webgl/resources/webgl_test_files/conformance/context/incorrect-context-object-behaviour.html: Added.
webgl/resources/webgl_test_files/conformance/context/methods.html: Added.
webgl/resources/webgl_test_files/conformance/context/premultiplyalpha-test.html: Added.
webgl/resources/webgl_test_files/conformance/context/resource-sharing-test.html: Added.
webgl/resources/webgl_test_files/conformance/context/resources/context-release-child-with-worker.html: Added.
webgl/resources/webgl_test_files/conformance/context/resources/context-release-upon-reload-child.html: Added.
webgl/resources/webgl_test_files/conformance/context/resources/context-release-worker.js: Added.

4:43 AM Changeset in webkit [142097] by Gregg Tavares

1 edit
17 adds in trunk/LayoutTests

Add WebGL Conformance Tests uniforms folder.
https://bugs.webkit.org/show_bug.cgi?id=109112

Reviewed by Kenneth Russell.

webgl/conformance/uniforms/gl-uniform-bool-expected.txt: Added.
webgl/conformance/uniforms/gl-uniform-bool.html: Added.
webgl/conformance/uniforms/gl-uniformmatrix4fv-expected.txt: Added.
webgl/conformance/uniforms/gl-uniformmatrix4fv.html: Added.
webgl/conformance/uniforms/gl-unknown-uniform-expected.txt: Added.
webgl/conformance/uniforms/gl-unknown-uniform.html: Added.
webgl/conformance/uniforms/null-uniform-location-expected.txt: Added.
webgl/conformance/uniforms/null-uniform-location.html: Added.
webgl/resources/webgl_test_files/conformance/uniforms/00_test_list.txt: Added.
webgl/resources/webgl_test_files/conformance/uniforms/gl-uniform-bool.html: Added.
webgl/resources/webgl_test_files/conformance/uniforms/gl-uniform-packing-restrictions.html: Added.
webgl/resources/webgl_test_files/conformance/uniforms/gl-uniform-struct-unused.html: Added.
webgl/resources/webgl_test_files/conformance/uniforms/gl-uniform-unused-array-elements-get-truncated.html: Added.
webgl/resources/webgl_test_files/conformance/uniforms/gl-uniformmatrix4fv.html: Added.
webgl/resources/webgl_test_files/conformance/uniforms/gl-unknown-uniform.html: Added.
webgl/resources/webgl_test_files/conformance/uniforms/null-uniform-location.html: Added.
webgl/resources/webgl_test_files/conformance/uniforms/out-of-bounds-uniform-array-access.html: Added.

4:39 AM Changeset in webkit [142096] by Gregg Tavares

1 edit
22 adds in trunk/LayoutTests

Add WebGL Conformance Tests canvas folder.
https://bugs.webkit.org/show_bug.cgi?id=109113

Reviewed by Kenneth Russell.

webgl/conformance/canvas/canvas-test-expected.txt: Added.
webgl/conformance/canvas/canvas-test.html: Added.
webgl/conformance/canvas/canvas-zero-size-expected.txt: Added.
webgl/conformance/canvas/canvas-zero-size.html: Added.
webgl/conformance/canvas/drawingbuffer-hd-dpi-test-expected.txt: Added.
webgl/conformance/canvas/drawingbuffer-hd-dpi-test.html: Added.
webgl/conformance/canvas/drawingbuffer-static-canvas-test-expected.txt: Added.
webgl/conformance/canvas/drawingbuffer-static-canvas-test.html: Added.
webgl/conformance/canvas/framebuffer-bindings-unaffected-on-resize-expected.txt: Added.
webgl/conformance/canvas/framebuffer-bindings-unaffected-on-resize.html: Added.
webgl/conformance/canvas/texture-bindings-unaffected-on-resize-expected.txt: Added.
webgl/conformance/canvas/texture-bindings-unaffected-on-resize.html: Added.
webgl/conformance/canvas/viewport-unchanged-upon-resize-expected.txt: Added.
webgl/conformance/canvas/viewport-unchanged-upon-resize.html: Added.
webgl/resources/webgl_test_files/conformance/canvas/00_test_list.txt: Added.
webgl/resources/webgl_test_files/conformance/canvas/canvas-test.html: Added.
webgl/resources/webgl_test_files/conformance/canvas/canvas-zero-size.html: Added.
webgl/resources/webgl_test_files/conformance/canvas/drawingbuffer-hd-dpi-test.html: Added.
webgl/resources/webgl_test_files/conformance/canvas/drawingbuffer-static-canvas-test.html: Added.
webgl/resources/webgl_test_files/conformance/canvas/framebuffer-bindings-unaffected-on-resize.html: Added.
webgl/resources/webgl_test_files/conformance/canvas/texture-bindings-unaffected-on-resize.html: Added.
webgl/resources/webgl_test_files/conformance/canvas/viewport-unchanged-upon-resize.html: Added.

4:34 AM Changeset in webkit [142095] by michael.bruning@digia.com

6 edits
2 deletes in trunk/Source/WebKit2

[Qt][WK2] Fold QtWebPageLoadClient into QQuickWebViewPrivate and move to C API.
https://bugs.webkit.org/show_bug.cgi?id=108473

Reviewed by Simon Hausmann.
Signed off for WebKit2 by Benjamin Poulain.

This patch removes the QtWebPageLoadClient and moves the functionality into the
QQuickWebViewPrivate as most callback methods are calling the private webview
indirectly anyway.

The patch also moves as much of the functionality to the C API as is possible with
the current C API.

Target.pri:
UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::didStartProvisionalLoadForFrame):
(QQuickWebViewPrivate::didReceiveServerRedirectForProvisionalLoadForFrame):
(QQuickWebViewPrivate::didFailLoad):
(QQuickWebViewPrivate::didCommitLoadForFrame):
(QQuickWebViewPrivate::didFinishLoadForFrame):
(QQuickWebViewPrivate::didSameDocumentNavigationForFrame):
(QQuickWebViewPrivate::didReceiveTitleForFrame):
(QQuickWebViewPrivate::didStartProgress):
(QQuickWebViewPrivate::didChangeProgress):
(QQuickWebViewPrivate::didFinishProgress):
(QQuickWebViewPrivate::didChangeBackForwardList):
(QQuickWebViewPrivate::setTransparentBackground):
(QQuickWebViewPrivate::transparentBackground):
(QQuickWebViewPrivate::loadProgressDidChange):

UIProcess/API/qt/qquickwebview_p.h:

(WebKit):

UIProcess/API/qt/qquickwebview_p_p.h:

(WebKit):
(QQuickWebViewPrivate):

UIProcess/qt/QtWebError.cpp:

(WebKit::QtWebError::url):

UIProcess/qt/QtWebPageLoadClient.cpp: Removed.
UIProcess/qt/QtWebPageLoadClient.h: Removed.

4:21 AM Changeset in webkit [142094] by commit-queue@webkit.org

8 edits
2 adds in trunk/Source

[GTK][AC] Implement opacity animation with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=108961

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-07
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Implement opacity animation with clutter ac backend.
Almost all implementations of GraphicsLayerClutter are based on mac port's one.
PlatformClutterAnimation interfaces are also similar with mac port, but they are implemented
with native clutter APIs.
This patch includes only opacity animation related changes, so many APIs might be empty.
Remained animations like rotation and translate will be dealt in another patches.

Covered by existing animation tests.

GNUmakefile.list.am:
platform/graphics/clutter/GraphicsLayerActor.cpp:

(graphicsLayerActorGetAnimationForKey):

platform/graphics/clutter/GraphicsLayerActor.h:
platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore):
(WebCore::propertyIdToString):
(WebCore::animationIdentifier):
(WebCore::animationHasStepsTimingFunction):
(WebCore::GraphicsLayerClutter::setOpacity):
(WebCore::GraphicsLayerClutter::updateAnimations):
(WebCore::GraphicsLayerClutter::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerClutter::setupAnimation):
(WebCore::GraphicsLayerClutter::timingFunctionForAnimationValue):
(WebCore::GraphicsLayerClutter::createBasicAnimation):
(WebCore::GraphicsLayerClutter::createKeyframeAnimation):
(WebCore::GraphicsLayerClutter::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerClutter::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):
(WebCore::GraphicsLayerClutter::createAnimationFromKeyframes):
(WebCore::GraphicsLayerClutter::addAnimation):
(WebCore::GraphicsLayerClutter::removeClutterAnimationFromLayer):
(WebCore::GraphicsLayerClutter::pauseClutterAnimationOnLayer):
(WebCore::GraphicsLayerClutter::setAnimationOnLayer):
(WebCore::GraphicsLayerClutter::setAnimationEndpoints):
(WebCore::GraphicsLayerClutter::setAnimationKeyframes):
(WebCore::GraphicsLayerClutter::animatedLayer):

platform/graphics/clutter/GraphicsLayerClutter.h:

(GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::LayerPropertyAnimation::LayerPropertyAnimation):
(LayerPropertyAnimation):
(WebCore::GraphicsLayerClutter::AnimationProcessingAction::AnimationProcessingAction):
(AnimationProcessingAction):

platform/graphics/clutter/PlatformClutterAnimation.cpp: Added.

(WebCore):
(WebCore::timelineStartedCallback):
(WebCore::toClutterAnimationMode):
(WebCore::PlatformClutterAnimation::stringToAnimatedPropertyType):
(WebCore::PlatformClutterAnimation::create):
(WebCore::PlatformClutterAnimation::PlatformClutterAnimation):
(WebCore::PlatformClutterAnimation::~PlatformClutterAnimation):
(WebCore::PlatformClutterAnimation::supportsValueFunction):
(WebCore::PlatformClutterAnimation::beginTime):
(WebCore::PlatformClutterAnimation::setBeginTime):
(WebCore::PlatformClutterAnimation::duration):
(WebCore::PlatformClutterAnimation::setDuration):
(WebCore::PlatformClutterAnimation::speed):
(WebCore::PlatformClutterAnimation::setSpeed):
(WebCore::PlatformClutterAnimation::timeOffset):
(WebCore::PlatformClutterAnimation::setTimeOffset):
(WebCore::PlatformClutterAnimation::repeatCount):
(WebCore::PlatformClutterAnimation::setRepeatCount):
(WebCore::PlatformClutterAnimation::autoreverses):
(WebCore::PlatformClutterAnimation::setAutoreverses):
(WebCore::PlatformClutterAnimation::fillMode):
(WebCore::PlatformClutterAnimation::setFillMode):
(WebCore::PlatformClutterAnimation::setTimingFunction):
(WebCore::PlatformClutterAnimation::copyTimingFunctionFrom):
(WebCore::PlatformClutterAnimation::isRemovedOnCompletion):
(WebCore::PlatformClutterAnimation::setRemovedOnCompletion):
(WebCore::PlatformClutterAnimation::isAdditive):
(WebCore::PlatformClutterAnimation::setAdditive):
(WebCore::PlatformClutterAnimation::valueFunction):
(WebCore::PlatformClutterAnimation::setValueFunction):
(WebCore::PlatformClutterAnimation::setFromValue):
(WebCore::PlatformClutterAnimation::copyFromValueFrom):
(WebCore::PlatformClutterAnimation::setToValue):
(WebCore::PlatformClutterAnimation::copyToValueFrom):
(WebCore::PlatformClutterAnimation::setValues):
(WebCore::PlatformClutterAnimation::copyValuesFrom):
(WebCore::PlatformClutterAnimation::setKeyTimes):
(WebCore::PlatformClutterAnimation::copyKeyTimesFrom):
(WebCore::PlatformClutterAnimation::setTimingFunctions):
(WebCore::PlatformClutterAnimation::copyTimingFunctionsFrom):
(WebCore::PlatformClutterAnimation::animationDidStart):
(WebCore::PlatformClutterAnimation::timeline):
(WebCore::PlatformClutterAnimation::addOpacityTransition):
(WebCore::PlatformClutterAnimation::addAnimationForKey):
(WebCore::PlatformClutterAnimation::removeAnimationForKey):

platform/graphics/clutter/PlatformClutterAnimation.h: Added.

(WebCore):
(PlatformClutterAnimation):
(WebCore::PlatformClutterAnimation::animationType):

Source/WebKit/gtk:

Add AnimationTrigger for ac compositing.

WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::allowedCompositingTriggers):

4:18 AM Changeset in webkit [142093] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

Add null check to editable in moveCaretSelectionTowardsWindowPoint
https://bugs.webkit.org/show_bug.cgi?id=108962

Patch by David Trainor <dtrainor@chromium.org> on 2013-02-07
Reviewed by Eric Seidel.

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):

tests/WebFrameTest.cpp:

3:57 AM Changeset in webkit [142092] by Gregg Tavares

1 edit
85 adds in trunk/LayoutTests

Add WebGL Conformance Tests texture folder.
https://bugs.webkit.org/show_bug.cgi?id=109111

Reviewed by Kenneth Russell.

webgl/conformance/textures/compressed-tex-image-expected.txt: Added.
webgl/conformance/textures/compressed-tex-image.html: Added.
webgl/conformance/textures/copy-tex-image-and-sub-image-2d-expected.txt: Added.
webgl/conformance/textures/copy-tex-image-and-sub-image-2d.html: Added.
webgl/conformance/textures/gl-get-tex-parameter-expected.txt: Added.
webgl/conformance/textures/gl-get-tex-parameter.html: Added.
webgl/conformance/textures/gl-teximage-expected.txt: Added.
webgl/conformance/textures/gl-teximage.html: Added.
webgl/conformance/textures/mipmap-fbo-expected.txt: Added.
webgl/conformance/textures/mipmap-fbo.html: Added.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-array-buffer-view-expected.txt: Added.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-array-buffer-view.html: Added.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data-expected.txt: Added.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgb565-expected.txt: Added.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgb565.html: Added.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba4444-expected.txt: Added.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba4444.html: Added.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba5551-expected.txt: Added.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba5551.html: Added.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-data.html: Added.
webgl/conformance/textures/tex-image-and-uniform-binding-bugs-expected.txt: Added.
webgl/conformance/textures/tex-image-and-uniform-binding-bugs.html: Added.
webgl/conformance/textures/tex-image-webgl-expected.txt: Added.
webgl/conformance/textures/tex-image-webgl.html: Added.
webgl/conformance/textures/tex-image-with-format-and-type-expected.txt: Added.
webgl/conformance/textures/tex-image-with-format-and-type.html: Added.
webgl/conformance/textures/tex-image-with-invalid-data-expected.txt: Added.
webgl/conformance/textures/tex-image-with-invalid-data.html: Added.
webgl/conformance/textures/tex-input-validation-expected.txt: Added.
webgl/conformance/textures/tex-input-validation.html: Added.
webgl/conformance/textures/tex-sub-image-2d-bad-args-expected.txt: Added.
webgl/conformance/textures/tex-sub-image-2d-bad-args.html: Added.
webgl/conformance/textures/tex-sub-image-2d-expected.txt: Added.
webgl/conformance/textures/tex-sub-image-2d.html: Added.
webgl/conformance/textures/texparameter-test-expected.txt: Added.
webgl/conformance/textures/texparameter-test.html: Added.
webgl/conformance/textures/texture-attachment-formats-expected.txt: Added.
webgl/conformance/textures/texture-attachment-formats.html: Added.
webgl/conformance/textures/texture-clear-expected.txt: Added.
webgl/conformance/textures/texture-clear.html: Added.
webgl/conformance/textures/texture-complete-expected.txt: Added.
webgl/conformance/textures/texture-complete.html: Added.
webgl/conformance/textures/texture-formats-test-expected.txt: Added.
webgl/conformance/textures/texture-formats-test.html: Added.
webgl/conformance/textures/texture-hd-dpi-expected.txt: Added.
webgl/conformance/textures/texture-hd-dpi.html: Added.
webgl/conformance/textures/texture-npot-expected.txt: Added.
webgl/conformance/textures/texture-npot.html: Added.
webgl/conformance/textures/texture-size-cube-maps-expected.txt: Added.
webgl/conformance/textures/texture-size-cube-maps.html: Added.
webgl/conformance/textures/texture-sub-image-cube-maps-expected.txt: Added.
webgl/conformance/textures/texture-sub-image-cube-maps.html: Added.
webgl/conformance/textures/texture-transparent-pixels-initialized-expected.txt: Added.
webgl/conformance/textures/texture-transparent-pixels-initialized.html: Added.
webgl/conformance/textures/texture-upload-cube-maps-expected.txt: Added.
webgl/conformance/textures/texture-upload-cube-maps.html: Added.
webgl/resources/webgl_test_files/conformance/textures/00_test_list.txt: Added.
webgl/resources/webgl_test_files/conformance/textures/compressed-tex-image.html: Added.
webgl/resources/webgl_test_files/conformance/textures/copy-tex-image-and-sub-image-2d.html: Added.
webgl/resources/webgl_test_files/conformance/textures/gl-get-tex-parameter.html: Added.
webgl/resources/webgl_test_files/conformance/textures/gl-teximage.html: Added.
webgl/resources/webgl_test_files/conformance/textures/mipmap-fbo.html: Added.
webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-array-buffer-view.html: Added.
webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgb565.html: Added.
webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba4444.html: Added.
webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba5551.html: Added.
webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-data.html: Added.
webgl/resources/webgl_test_files/conformance/textures/tex-image-and-uniform-binding-bugs.html: Added.
webgl/resources/webgl_test_files/conformance/textures/tex-image-webgl.html: Added.
webgl/resources/webgl_test_files/conformance/textures/tex-image-with-format-and-type.html: Added.
webgl/resources/webgl_test_files/conformance/textures/tex-image-with-invalid-data.html: Added.
webgl/resources/webgl_test_files/conformance/textures/tex-input-validation.html: Added.
webgl/resources/webgl_test_files/conformance/textures/tex-sub-image-2d-bad-args.html: Added.
webgl/resources/webgl_test_files/conformance/textures/tex-sub-image-2d.html: Added.
webgl/resources/webgl_test_files/conformance/textures/texparameter-test.html: Added.
webgl/resources/webgl_test_files/conformance/textures/texture-attachment-formats.html: Added.
webgl/resources/webgl_test_files/conformance/textures/texture-clear.html: Added.
webgl/resources/webgl_test_files/conformance/textures/texture-complete.html: Added.
webgl/resources/webgl_test_files/conformance/textures/texture-formats-test.html: Added.
webgl/resources/webgl_test_files/conformance/textures/texture-hd-dpi.html: Added.
webgl/resources/webgl_test_files/conformance/textures/texture-npot.html: Added.
webgl/resources/webgl_test_files/conformance/textures/texture-size-cube-maps.html: Added.
webgl/resources/webgl_test_files/conformance/textures/texture-sub-image-cube-maps.html: Added.
webgl/resources/webgl_test_files/conformance/textures/texture-transparent-pixels-initialized.html: Added.
webgl/resources/webgl_test_files/conformance/textures/texture-upload-cube-maps.html: Added.

3:51 AM Changeset in webkit [142091] by commit-queue@webkit.org

8 edits
2 adds in trunk

Web Inspector: highlight matching braces in DTE.
https://bugs.webkit.org/show_bug.cgi?id=108697

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-07
Reviewed by Pavel Feldman.

Source/WebCore:

Implement BraceMatcher class which for given position in textModel
will respond with enclosing brace pair for that position.
Make use of this class in DefaultTextEditor by handling
selectionChange event. Make use of this class in "_closingBlockOffset"
method of TextEditorMainPanel as this method implements similar
functionality.

New test: inspector/editor/brace-matcher.html

inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._closingBlockOffset):
(WebInspector.TextEditorMainPanel.prototype._handleSelectionChange):
(WebInspector.TextEditorMainPanel.BraceHighlightController):
(WebInspector.TextEditorMainPanel.BraceHighlightController.prototype.handleSelectionChange):

inspector/front-end/TextEditorHighlighter.js:

(WebInspector.TextEditorHighlighter.prototype._highlightLines):

inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorModel.endsWithBracketRegex):
(WebInspector.TextEditorModel.endsWithBracketRegex.):

inspector/front-end/textEditor.css:

(.text-editor-brace-match):

LayoutTests:

New layout test to verify brace matching functionality. Fix some
layout test expectations as the patch removes braces from highlight
ranges.

inspector/editor/brace-matcher-expected.txt: Added.
inspector/editor/brace-matcher.html: Added.
inspector/editor/highlighter-basics-expected.txt:
inspector/editor/text-editor-long-line-expected.txt:

3:46 AM Changeset in webkit [142090] by jochen@chromium.org

31 edits
3 copies in trunk/Tools

[chromium] turn TestRunner library into a component build
https://bugs.webkit.org/show_bug.cgi?id=108466

Reviewed by Adam Barth.

To achieve this, we need to drop all dependencies on WTF.

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
DumpRenderTree/chromium/TestRunner/public/WebTask.h:
DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

(WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
(WebTestRunner::AccessibilityUIElementList::getOrCreate):
(WebTestRunner::AccessibilityUIElementList::createRoot):

DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:

(AccessibilityUIElementList):

DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:

DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h:

(WebTestRunner):
(CppBoundClass):
(WebTestRunner::CppBoundClass::bindProperty):
(WebTestRunner::CppBoundClass::bindFallbackCallback):
(WebTestRunner::CppBoundClass::bindFallbackMethod):

DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp:

DumpRenderTree/chromium/TestRunner/src/CppVariant.h:

(CppVariant):

DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp:

(WebTestRunner::NativeKeyCodeForWindowsKeyCode):

DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:

(WebTestRunner::MockGrammarCheck::checkGrammarOfString):
(WebTestRunner):

DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h:

(WebTestRunner):
(MockGrammarCheck):

DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:

(WebTestRunner::MockSpellCheck::spellCheckWord):
(WebTestRunner::MockSpellCheck::initializeIfNeeded):
(WebTestRunner):

DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:

(MockSpellCheck):

DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:

(WebTestRunner::SpellCheckClient::checkTextOfParagraph):
(WebTestRunner::SpellCheckClient::finishLastTextCheck):

DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.

(isASCIIAlpha):
(isNotASCIIAlpha):

DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):

DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:

DumpRenderTree/chromium/TestRunner/src/TestPlugin.h:

(TestPlugin):

DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebTestRunner::TestRunner::WorkQueue::isEmpty):
(TestRunner):

DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:

(WebTestRunner::TextInputController::markedRange):
(WebTestRunner::TextInputController::selectedRange):
(WebTestRunner::TextInputController::firstRectForCharacterRange):

DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):

DumpRenderTree/chromium/TestRunner/src/WebTask.cpp:

(WebTestRunner::WebTaskList::~WebTaskList):
(WebTestRunner::WebTaskList::registerTask):
(WebTestRunner::WebTaskList::unregisterTask):
(WebTestRunner::WebTaskList::revokeAll):

DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::testInterfaces):

DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

DumpRenderTree/chromium/TestRunner/src/config.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.

3:21 AM Changeset in webkit [142089] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r180752. Requested by
thakis_ via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-07

DEPS:

3:02 AM Changeset in webkit [142088] by abecsi@webkit.org

8 edits in trunk

[Qt] Use GNU ar's thin archive format for intermediate static libs
https://bugs.webkit.org/show_bug.cgi?id=109052

Reviewed by Jocelyn Turcotte.

Source/JavaScriptCore:

Adjust project files that used activeBuildConfig()
to use targetSubDir().

JavaScriptCore.pri:
LLIntOffsetsExtractor.pro:
Target.pri:

Tools:

With debug builds we exceed the 4GiB limit of GNU ar when creating the WebCore
intermediate static library which results in build failure even with a x86_64
toolchain (http://sourceware.org/bugzilla/show_bug.cgi?id=14625).

When using a GNU toolchain we can use the thin archive format for these static
libraries which also has the benefit of not copying the object files, thus
drastically reducing disk usage and overall compile time.

Currently qmake does not support GNU ar's thin archive format so for
now we need to do the magic in the build system as a stopgap solution.

qmake/mkspecs/features/configure.prf:
qmake/mkspecs/features/default_post.prf:
qmake/mkspecs/features/functions.prf:

3:01 AM Changeset in webkit [142087] by rakuco@webkit.org

5 edits in trunk/Source

[EFL][WK2] Refactoring initialization and shutdown codes of EFL libraries.
https://bugs.webkit.org/show_bug.cgi?id=97173

Reviewed by Kenneth Rohde Christiansen, signed-off by Benjamin Poulain.

Source/WebCore:

Remove codes to initialize and shutdown the EFL libraries from
RunLoopEfl.cpp. Initialization and shutdown will be done in the
ewk_main.cpp for ui process and WebProcessMainEfl.cpp for web
process.

No new tests. This patch doesn't change behavior.

platform/efl/RunLoopEfl.cpp:

(WebCore::RunLoop::RunLoop):
(WebCore::RunLoop::~RunLoop):

Source/WebKit2:

Initialize and shutdown the EFL libraries in the ewk_main.cpp for
UIProcess and WebProcessMainEfl.cpp for WebProcess.

This allows us to shut down the libraries in a proper way, since
RunLoop persist until the process exits.

UIProcess/API/efl/ewk_main.cpp:

(ewk_init):
(ewk_shutdown):

WebProcess/efl/WebProcessMainEfl.cpp:

(WebKit::WebProcessMainEfl):

2:05 AM Changeset in webkit [142086] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed fix for inspector tests in debug.
m_frontend should be initialized in constructor.

inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):

1:37 AM Changeset in webkit [142085] by pfeldman@chromium.org

18 edits in branches/chromium/1364

Merge 140539

Web Inspector: only allow evaluateForTestInFrontend for front-ends under test.
https://bugs.webkit.org/show_bug.cgi?id=107523

Reviewed by Yury Semikhatsky.

Source/WebCore:

inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::isUnderTest):
(WebCore):
(WebCore::InspectorController::evaluateForTestInFrontend):

inspector/InspectorController.h:
(InspectorController):

inspector/InspectorFrontendClient.h:
(InspectorFrontendClient):

inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::canAttachWindow):
(WebCore::InspectorFrontendClientLocal::isUnderTest):
(WebCore):

inspector/InspectorFrontendClientLocal.h:
(InspectorFrontendClientLocal):

inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::isUnderTest):
(WebCore):

inspector/InspectorFrontendHost.h:
(InspectorFrontendHost):

inspector/InspectorFrontendHost.idl:
inspector/front-end/DOMExtension.js:
inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub.prototype.canInspectWorkers):
(.WebInspector.InspectorFrontendHostStub.prototype.isUnderTest):

inspector/front-end/TestController.js:
(.invokeMethod):
(WebInspector.evaluateForTestInFrontend):

inspector/front-end/externs.js:
Source/WebKit/chromium:

public/WebDevToolsFrontendClient.h:
(WebKit::WebDevToolsFrontendClient::isUnderTest):
(WebDevToolsFrontendClient):

src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::isUnderTest):

src/InspectorFrontendClientImpl.h:
(InspectorFrontendClientImpl):

Tools:

DumpRenderTree/chromium/DRTDevToolsClient.cpp:
(DRTDevToolsClient::isUnderTest):
(DRTDevToolsClient::call):

DumpRenderTree/chromium/DRTDevToolsClient.h:
(DRTDevToolsClient):

TBR=pfeldman@chromium.org
Review URL: https://codereview.chromium.org/12224049

1:24 AM Changeset in webkit [142084] by falken@chromium.org

4 edits
249 deletes in trunk/LayoutTests

Rollout r142058 various crashes and timeouts on AppleMac and Chromium
https://bugs.webkit.org/show_bug.cgi?id=109152

Reviewed by Pavel Feldman.

Unreviewed gardening. r142058 added failing tests and marked many as
Skip or Failure but there are also Timeouts and Crashes causing
redness.

platform/chromium/TestExpectations:
platform/mac/TestExpectations:
platform/win/TestExpectations:
webgl/conformance/canvas/buffer-offscreen-test-expected.txt: Removed.
webgl/conformance/canvas/buffer-offscreen-test.html: Removed.
webgl/conformance/canvas/buffer-preserve-test-expected.txt: Removed.
webgl/conformance/canvas/buffer-preserve-test.html: Removed.
webgl/conformance/canvas/drawingbuffer-test-expected.txt: Removed.
webgl/conformance/canvas/drawingbuffer-test.html: Removed.
webgl/conformance/canvas/to-data-url-test-expected.txt: Removed.
webgl/conformance/canvas/to-data-url-test.html: Removed.
webgl/conformance/context/context-attribute-preserve-drawing-buffer-expected.txt: Removed.
webgl/conformance/context/context-attribute-preserve-drawing-buffer.html: Removed.
webgl/conformance/context/context-creation-and-destruction-expected.txt: Removed.
webgl/conformance/context/context-creation-and-destruction.html: Removed.
webgl/conformance/glsl/functions/glsl-function-smoothstep-gentype-expected.txt: Removed.
webgl/conformance/glsl/functions/glsl-function-smoothstep-gentype.html: Removed.
webgl/conformance/glsl/literals/float_literal.vert-expected.txt: Removed.
webgl/conformance/glsl/literals/float_literal.vert.html: Removed.
webgl/conformance/glsl/misc/shader-uniform-packing-restrictions-expected.txt: Removed.
webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html: Removed.
webgl/conformance/glsl/misc/shader-varying-packing-restrictions-expected.txt: Removed.
webgl/conformance/glsl/misc/shader-varying-packing-restrictions.html: Removed.
webgl/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays-expected.txt: Removed.
webgl/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Removed.
webgl/conformance/glsl/misc/shader-with-global-variable-precision-mismatch-expected.txt: Removed.
webgl/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html: Removed.
webgl/conformance/glsl/misc/shader-with-non-reserved-words-expected.txt: Removed.
webgl/conformance/glsl/misc/shader-with-non-reserved-words.html: Removed.
webgl/conformance/glsl/misc/shader-with-short-circuiting-operators-expected.txt: Removed.
webgl/conformance/glsl/misc/shader-with-short-circuiting-operators.html: Removed.
webgl/conformance/glsl/misc/shader-with-similar-uniform-array-names-expected.txt: Removed.
webgl/conformance/glsl/misc/shader-with-similar-uniform-array-names.html: Removed.
webgl/conformance/glsl/misc/shaders-with-varyings-expected.txt: Removed.
webgl/conformance/glsl/misc/shaders-with-varyings.html: Removed.
webgl/conformance/glsl/variables/gl-pointcoord-expected.txt: Removed.
webgl/conformance/glsl/variables/gl-pointcoord.html: Removed.
webgl/conformance/more/conformance/quickCheckAPI-A-expected.txt: Removed.
webgl/conformance/more/conformance/quickCheckAPI-A.html: Removed.
webgl/conformance/more/conformance/quickCheckAPI-B1-expected.txt: Removed.
webgl/conformance/more/conformance/quickCheckAPI-B1.html: Removed.
webgl/conformance/more/conformance/quickCheckAPI-B2-expected.txt: Removed.
webgl/conformance/more/conformance/quickCheckAPI-B2.html: Removed.
webgl/conformance/more/conformance/quickCheckAPI-B3-expected.txt: Removed.
webgl/conformance/more/conformance/quickCheckAPI-B3.html: Removed.
webgl/conformance/more/conformance/quickCheckAPI-B4-expected.txt: Removed.
webgl/conformance/more/conformance/quickCheckAPI-B4.html: Removed.
webgl/conformance/more/conformance/quickCheckAPI-C-expected.txt: Removed.
webgl/conformance/more/conformance/quickCheckAPI-C.html: Removed.
webgl/conformance/more/conformance/quickCheckAPI-D_G-expected.txt: Removed.
webgl/conformance/more/conformance/quickCheckAPI-D_G.html: Removed.
webgl/conformance/more/conformance/quickCheckAPI-G_I-expected.txt: Removed.
webgl/conformance/more/conformance/quickCheckAPI-G_I.html: Removed.
webgl/conformance/more/conformance/quickCheckAPI-L_S-expected.txt: Removed.
webgl/conformance/more/conformance/quickCheckAPI-L_S.html: Removed.
webgl/conformance/more/conformance/quickCheckAPI-S_V-expected.txt: Removed.
webgl/conformance/more/conformance/quickCheckAPI-S_V.html: Removed.
webgl/conformance/more/functions/bufferDataBadArgs-expected.txt: Removed.
webgl/conformance/more/functions/bufferDataBadArgs.html: Removed.
webgl/conformance/more/functions/copyTexImage2D-expected.txt: Removed.
webgl/conformance/more/functions/copyTexImage2D.html: Removed.
webgl/conformance/more/functions/copyTexImage2DBadArgs-expected.txt: Removed.
webgl/conformance/more/functions/copyTexImage2DBadArgs.html: Removed.
webgl/conformance/more/functions/copyTexSubImage2D-expected.txt: Removed.
webgl/conformance/more/functions/copyTexSubImage2D.html: Removed.
webgl/conformance/more/functions/copyTexSubImage2DBadArgs-expected.txt: Removed.
webgl/conformance/more/functions/copyTexSubImage2DBadArgs.html: Removed.
webgl/conformance/more/functions/deleteBufferBadArgs-expected.txt: Removed.
webgl/conformance/more/functions/deleteBufferBadArgs.html: Removed.
webgl/conformance/more/functions/drawArrays-expected.txt: Removed.
webgl/conformance/more/functions/drawArrays.html: Removed.
webgl/conformance/more/functions/drawArraysOutOfBounds-expected.txt: Removed.
webgl/conformance/more/functions/drawArraysOutOfBounds.html: Removed.
webgl/conformance/more/functions/drawElements-expected.txt: Removed.
webgl/conformance/more/functions/drawElements.html: Removed.
webgl/conformance/more/functions/drawElementsBadArgs-expected.txt: Removed.
webgl/conformance/more/functions/drawElementsBadArgs.html: Removed.
webgl/conformance/more/functions/readPixelsBadArgs-expected.txt: Removed.
webgl/conformance/more/functions/readPixelsBadArgs.html: Removed.
webgl/conformance/more/functions/texImage2DBadArgs-expected.txt: Removed.
webgl/conformance/more/functions/texImage2DBadArgs.html: Removed.
webgl/conformance/more/functions/texImage2DHTML-expected.txt: Removed.
webgl/conformance/more/functions/texImage2DHTML.html: Removed.
webgl/conformance/more/functions/texSubImage2DBadArgs-expected.txt: Removed.
webgl/conformance/more/functions/texSubImage2DBadArgs.html: Removed.
webgl/conformance/more/functions/texSubImage2DHTML-expected.txt: Removed.
webgl/conformance/more/functions/texSubImage2DHTML.html: Removed.
webgl/conformance/ogles/GL/acos/acos_001_to_006-expected.txt: Removed.
webgl/conformance/ogles/GL/acos/acos_001_to_006.html: Removed.
webgl/conformance/ogles/GL/asin/asin_001_to_006-expected.txt: Removed.
webgl/conformance/ogles/GL/asin/asin_001_to_006.html: Removed.
webgl/conformance/ogles/GL/atan/atan_001_to_008-expected.txt: Removed.
webgl/conformance/ogles/GL/atan/atan_001_to_008.html: Removed.
webgl/conformance/ogles/GL/control_flow/control_flow_001_to_008-expected.txt: Removed.
webgl/conformance/ogles/GL/control_flow/control_flow_001_to_008.html: Removed.
webgl/conformance/ogles/GL/log/log_001_to_008-expected.txt: Removed.
webgl/conformance/ogles/GL/log/log_001_to_008.html: Removed.
webgl/conformance/ogles/GL/log2/log2_001_to_008-expected.txt: Removed.
webgl/conformance/ogles/GL/log2/log2_001_to_008.html: Removed.
webgl/conformance/ogles/GL/smoothstep/smoothstep_001_to_006-expected.txt: Removed.
webgl/conformance/ogles/GL/smoothstep/smoothstep_001_to_006.html: Removed.
webgl/conformance/programs/gl-bind-attrib-location-long-names-test-expected.txt: Removed.
webgl/conformance/programs/gl-bind-attrib-location-long-names-test.html: Removed.
webgl/conformance/programs/program-test-expected.txt: Removed.
webgl/conformance/programs/program-test.html: Removed.
webgl/conformance/reading/read-pixels-test-expected.txt: Removed.
webgl/conformance/reading/read-pixels-test.html: Removed.
webgl/conformance/renderbuffers/framebuffer-object-attachment-expected.txt: Removed.
webgl/conformance/renderbuffers/framebuffer-object-attachment.html: Removed.
webgl/conformance/rendering/gl-scissor-test-expected.txt: Removed.
webgl/conformance/rendering/gl-scissor-test.html: Removed.
webgl/conformance/rendering/more-than-65536-indices-expected.txt: Removed.
webgl/conformance/rendering/more-than-65536-indices.html: Removed.
webgl/conformance/rendering/multisample-corruption-expected.txt: Removed.
webgl/conformance/rendering/multisample-corruption.html: Removed.
webgl/conformance/rendering/point-size-expected.txt: Removed.
webgl/conformance/rendering/point-size.html: Removed.
webgl/conformance/state/gl-object-get-calls-expected.txt: Removed.
webgl/conformance/state/gl-object-get-calls.html: Removed.
webgl/conformance/textures/copy-tex-image-2d-formats-expected.txt: Removed.
webgl/conformance/textures/copy-tex-image-2d-formats.html: Removed.
webgl/conformance/textures/gl-pixelstorei-expected.txt: Removed.
webgl/conformance/textures/gl-pixelstorei.html: Removed.
webgl/conformance/textures/origin-clean-conformance-expected.txt: Removed.
webgl/conformance/textures/origin-clean-conformance.html: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-expected.txt: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565-expected.txt: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444-expected.txt: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551-expected.txt: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-expected.txt: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565-expected.txt: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444-expected.txt: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551-expected.txt: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-image.html: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-expected.txt: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565-expected.txt: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444-expected.txt: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551-expected.txt: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html: Removed.
webgl/conformance/textures/tex-image-and-sub-image-2d-with-video.html: Removed.
webgl/conformance/textures/texture-active-bind-2-expected.txt: Removed.
webgl/conformance/textures/texture-active-bind-2.html: Removed.
webgl/conformance/textures/texture-active-bind-expected.txt: Removed.
webgl/conformance/textures/texture-active-bind.html: Removed.
webgl/conformance/textures/texture-mips-expected.txt: Removed.
webgl/conformance/textures/texture-mips.html: Removed.
webgl/conformance/textures/texture-npot-video-expected.txt: Removed.
webgl/conformance/textures/texture-npot-video.html: Removed.
webgl/conformance/textures/texture-size-expected.txt: Removed.
webgl/conformance/textures/texture-size-limit-expected.txt: Removed.
webgl/conformance/textures/texture-size-limit.html: Removed.
webgl/conformance/textures/texture-size.html: Removed.
webgl/conformance/uniforms/gl-uniform-arrays-expected.txt: Removed.
webgl/conformance/uniforms/gl-uniform-arrays.html: Removed.
webgl/conformance/uniforms/uniform-default-values-expected.txt: Removed.
webgl/conformance/uniforms/uniform-default-values.html: Removed.
webgl/conformance/uniforms/uniform-location-expected.txt: Removed.
webgl/conformance/uniforms/uniform-location.html: Removed.
webgl/conformance/uniforms/uniform-samplers-test-expected.txt: Removed.
webgl/conformance/uniforms/uniform-samplers-test.html: Removed.
webgl/resources/webgl_test_files/conformance/canvas/buffer-offscreen-test.html: Removed.
webgl/resources/webgl_test_files/conformance/canvas/buffer-preserve-test.html: Removed.
webgl/resources/webgl_test_files/conformance/canvas/drawingbuffer-test.html: Removed.
webgl/resources/webgl_test_files/conformance/canvas/to-data-url-test.html: Removed.
webgl/resources/webgl_test_files/conformance/context/context-attribute-preserve-drawing-buffer.html: Removed.
webgl/resources/webgl_test_files/conformance/context/context-creation-and-destruction.html: Removed.
webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-smoothstep-gentype.html: Removed.
webgl/resources/webgl_test_files/conformance/glsl/literals/float_literal.vert.html: Removed.
webgl/resources/webgl_test_files/conformance/glsl/misc/shader-uniform-packing-restrictions.html: Removed.
webgl/resources/webgl_test_files/conformance/glsl/misc/shader-varying-packing-restrictions.html: Removed.
webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Removed.
webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html: Removed.
webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-non-reserved-words.html: Removed.
webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-short-circuiting-operators.html: Removed.
webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-similar-uniform-array-names.html: Removed.
webgl/resources/webgl_test_files/conformance/glsl/misc/shaders-with-varyings.html: Removed.
webgl/resources/webgl_test_files/conformance/glsl/variables/gl-pointcoord.html: Removed.
webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-A.html: Removed.
webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B1.html: Removed.
webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B2.html: Removed.
webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B3.html: Removed.
webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B4.html: Removed.
webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-C.html: Removed.
webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-D_G.html: Removed.
webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-G_I.html: Removed.
webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-L_S.html: Removed.
webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-S_V.html: Removed.
webgl/resources/webgl_test_files/conformance/more/functions/bufferDataBadArgs.html: Removed.
webgl/resources/webgl_test_files/conformance/more/functions/copyTexImage2D.html: Removed.
webgl/resources/webgl_test_files/conformance/more/functions/copyTexImage2DBadArgs.html: Removed.
webgl/resources/webgl_test_files/conformance/more/functions/copyTexSubImage2D.html: Removed.
webgl/resources/webgl_test_files/conformance/more/functions/copyTexSubImage2DBadArgs.html: Removed.
webgl/resources/webgl_test_files/conformance/more/functions/deleteBufferBadArgs.html: Removed.
webgl/resources/webgl_test_files/conformance/more/functions/drawArrays.html: Removed.
webgl/resources/webgl_test_files/conformance/more/functions/drawArraysOutOfBounds.html: Removed.
webgl/resources/webgl_test_files/conformance/more/functions/drawElements.html: Removed.
webgl/resources/webgl_test_files/conformance/more/functions/drawElementsBadArgs.html: Removed.
webgl/resources/webgl_test_files/conformance/more/functions/readPixelsBadArgs.html: Removed.
webgl/resources/webgl_test_files/conformance/more/functions/texImage2DBadArgs.html: Removed.
webgl/resources/webgl_test_files/conformance/more/functions/texImage2DHTML.html: Removed.
webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DBadArgs.html: Removed.
webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DHTML.html: Removed.
webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_001_to_006.html: Removed.
webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_001_to_006.html: Removed.
webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_001_to_008.html: Removed.
webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/control_flow_001_to_008.html: Removed.
webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_001_to_008.html: Removed.
webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_001_to_008.html: Removed.
webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_001_to_006.html: Removed.
webgl/resources/webgl_test_files/conformance/programs/gl-bind-attrib-location-long-names-test.html: Removed.
webgl/resources/webgl_test_files/conformance/programs/program-test.html: Removed.
webgl/resources/webgl_test_files/conformance/reading/read-pixels-test.html: Removed.
webgl/resources/webgl_test_files/conformance/renderbuffers/framebuffer-object-attachment.html: Removed.
webgl/resources/webgl_test_files/conformance/rendering/gl-scissor-test.html: Removed.
webgl/resources/webgl_test_files/conformance/rendering/more-than-65536-indices.html: Removed.
webgl/resources/webgl_test_files/conformance/rendering/multisample-corruption.html: Removed.
webgl/resources/webgl_test_files/conformance/rendering/point-size.html: Removed.
webgl/resources/webgl_test_files/conformance/state/gl-object-get-calls.html: Removed.
webgl/resources/webgl_test_files/conformance/textures/copy-tex-image-2d-formats.html: Removed.
webgl/resources/webgl_test_files/conformance/textures/gl-pixelstorei.html: Removed.
webgl/resources/webgl_test_files/conformance/textures/origin-clean-conformance.html: Removed.
webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html: Removed.
webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html: Removed.
webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html: Removed.
webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html: Removed.
webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html: Removed.
webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html: Removed.
webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html: Removed.
webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image.html: Removed.
webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html: Removed.
webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html: Removed.
webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html: Removed.
webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video.html: Removed.
webgl/resources/webgl_test_files/conformance/textures/texture-active-bind-2.html: Removed.
webgl/resources/webgl_test_files/conformance/textures/texture-active-bind.html: Removed.
webgl/resources/webgl_test_files/conformance/textures/texture-mips.html: Removed.
webgl/resources/webgl_test_files/conformance/textures/texture-npot-video.html: Removed.
webgl/resources/webgl_test_files/conformance/textures/texture-size-limit.html: Removed.
webgl/resources/webgl_test_files/conformance/textures/texture-size.html: Removed.
webgl/resources/webgl_test_files/conformance/uniforms/gl-uniform-arrays.html: Removed.
webgl/resources/webgl_test_files/conformance/uniforms/uniform-default-values.html: Removed.
webgl/resources/webgl_test_files/conformance/uniforms/uniform-location.html: Removed.
webgl/resources/webgl_test_files/conformance/uniforms/uniform-samplers-test.html: Removed.

1:11 AM Changeset in webkit [142083] by kadam@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing WebGL tests.

platform/qt/TestExpectations:

1:10 AM Changeset in webkit [142082] by gyuyoung.kim@samsung.com

2 edits in trunk/Source/WebKit2

Unreviewed build fix.

UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::processDidClose):
m_process can't be initialized nullptr yet. Use 0 instead of nullptr.

1:09 AM Changeset in webkit [142081] by yurys@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: reduce number of native memory instrumentation categories
https://bugs.webkit.org/show_bug.cgi?id=109146

Reviewed by Pavel Feldman.

Merged some of memory instrumentation categories.

dom/WebCoreMemoryInstrumentation.cpp:

(WebCore):

inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.MemoryBlockViewProperties._initialize):

platform/PlatformMemoryInstrumentation.cpp:

(WebCore):

1:03 AM Changeset in webkit [142080] by pfeldman@chromium.org

1 edit in branches/chromium/1364/Source/WebCore/inspector/InspectorOverlay.cpp

Merge 141772

Web Inspector: take page scale factor into account when updating overlay.
https://bugs.webkit.org/show_bug.cgi?id=108831

Reviewed by Vsevolod Vlasov.

Otherwise, the ports that use page scale factor have broken overlay.

inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::update):

TBR=pfeldman@chromium.org
Review URL: https://codereview.chromium.org/12217060

1:01 AM Changeset in webkit [142079] by falken@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, rolling out r142067.
http://trac.webkit.org/changeset/142067
https://bugs.webkit.org/show_bug.cgi?id=109147

adding Slow modifier did not help completely (Requested by
falken on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-07

platform/chromium/TestExpectations:

12:59 AM Changeset in webkit [142078] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Expanding failure expectation for fast/dom/Window/slow-unload-handler.html.
Adding failure expectation for the new fast/css/negative-text-indent-in-inline-block.html
layout tests.

platform/gtk/TestExpectations:

12:42 AM Changeset in webkit [142077] by haraken@chromium.org

7 edits in trunk/Source/WebCore

[V8] Remove V8GCController::m_edenNodes and make minor DOM GC more precise
https://bugs.webkit.org/show_bug.cgi?id=108579

Reviewed by Adam Barth.

Before:

mean=59.91ms, min=39ms, median=42ms, max=258ms, stdev=47.48ms

After:

mean=58.75ms, min=35ms, median=41ms, max=250ms, stdev=47.32ms

As shown above, I couldn't observe any performance regression.

No tests. No change in behavior.

bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::setWrapperInObject):

bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::getWorldWithoutContextCheck):

bindings/v8/V8Binding.h:

(WebCore):
(WebCore::worldForEnteredContextIfIsolated):
(WebCore::worldForEnteredContextWithoutContextCheck):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):

bindings/v8/V8GCController.cpp:

bindings/v8/V8GCController.h:

(V8GCController):

12:40 AM Changeset in webkit [142076] by tkent@chromium.org

2 edits in trunk/Source/WebCore

REGRESSION(r141195): INPUT_MULTIPLE_FIELDS_UI: Space in a placeholder string is removed
https://bugs.webkit.org/show_bug.cgi?id=109132

Reviewed by Hajime Morita.

<input type=date> should be shown in Japanese UI as:
[ 年 /月/日]
But it is shown wrongly since r141195:
[年 /月/日]

We should use white-space:pre.

No new tests. This change is not testable in WebKit because this
requires a Japanese-localized UI string of Chromium.

css/html.css:

(input::-webkit-datetime-edit-fields-wrapper):
Use white-space:pre instead of nowrap.

12:38 AM Changeset in webkit [142075] by haraken@chromium.org

3 edits in trunk/Source/WebCore

Remove DOMWindow::parseModalDialogFeatures()
https://bugs.webkit.org/show_bug.cgi?id=109139

Reviewed by Kent Tamura.

No one uses the method. FIXME is saying:

FIXME: We can remove this function once V8 showModalDialog is changed to use DOMWindow.

Given that V8's showModalDialog() is now using DOMWindow, we can remove it.

No tests. No change in behavior.

page/DOMWindow.cpp:
page/DOMWindow.h:

(DOMWindow):

12:38 AM Changeset in webkit [142074] by loislo@chromium.org

10 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: reduce native heap snapshot runtime memory footprint
https://bugs.webkit.org/show_bug.cgi?id=108824

Reviewed by Yury Semikhatsky.

New event was added into Memory domain addNativeSnapshotChunk.
The content of HeapGraphSerializer is completely rewritten according to new API.
Now it collects strings, nodes, edges and id2id map and pushes when the collected items count exceed a limit.
On the frontend side I added new method for the new event and fixed the postprocessing step.
MemoryInstrumentation was slightly changed. Now it reports base to real address map only after reporting the node with real address.

inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::pushUpdateIfNeed):
(WebCore):
(WebCore::HeapGraphSerializer::pushUpdate):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::reportNodeImpl):
(WebCore::HeapGraphSerializer::reportEdge):
(WebCore::HeapGraphSerializer::reportEdgeImpl):
(WebCore::HeapGraphSerializer::reportLeaf):
(WebCore::HeapGraphSerializer::reportBaseAddress):
(WebCore::HeapGraphSerializer::finish):
(WebCore::HeapGraphSerializer::reportMemoryUsage):
(WebCore::HeapGraphSerializer::addString):
(WebCore::HeapGraphSerializer::toNodeId):
(WebCore::HeapGraphSerializer::addRootNode):

inspector/HeapGraphSerializer.h:

(HeapGraphSerializer):

inspector/Inspector.json:
inspector/InspectorController.cpp:

(WebCore::InspectorController::processMemoryDistribution):

inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionMap):
(WebCore):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):
(WebCore::InspectorMemoryAgent::setFrontend):
(WebCore::InspectorMemoryAgent::clearFrontend):

inspector/InspectorMemoryAgent.h:

(InspectorMemoryAgent):

inspector/front-end/NativeHeapSnapshot.js:

(WebInspector.NativeHeapSnapshot):
(WebInspector.NativeHeapSnapshotNode.prototype.classIndex):
(WebInspector.NativeHeapSnapshotNode.prototype.id):
(WebInspector.NativeHeapSnapshotNode.prototype.name):
(WebInspector.NativeHeapSnapshotNode.prototype.serialize):

inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked):
(WebInspector.NativeSnapshotProfileHeader):
(WebInspector.NativeSnapshotProfileHeader.prototype.startSnapshotTransfer):
(WebInspector.NativeSnapshotProfileHeader.prototype.addNativeSnapshotChunk):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeMemoryProfileType.prototype.buttonClicked):
(WebInspector.NativeMemoryBarChart.prototype._updateStats):

inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel):
(WebInspector.MemoryDispatcher):
(WebInspector.MemoryDispatcher.prototype.addNativeSnapshotChunk):

12:34 AM Changeset in webkit [142073] by Simon Hausmann

4 edits
2 deletes in trunk/Source/WebKit2

[Qt][WK2] Fold QtWebPageFindClient into QQuickWebViewPrivate
https://bugs.webkit.org/show_bug.cgi?id=108920

Reviewed by Jocelyn Turcotte, signed off for WK2 by Benjamin.

Employ the pattern suggested by Jocelyn to simply implement the C
callbacks directly using static functions.

Target.pri:
UIProcess/API/qt/qquickwebview.cpp:

(toQQuickWebViewPrivate):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::didFindString):
(QQuickWebViewPrivate::didFailToFindString):

UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

UIProcess/qt/QtWebPageFindClient.cpp: Removed.
UIProcess/qt/QtWebPageFindClient.h: Removed.

12:30 AM Changeset in webkit [142072] by haraken@chromium.org

18 edits
5 adds in trunk

WebKit's focus events are UIEvents (instead of FocusEvent) and thus don't expose .relatedTarget
https://bugs.webkit.org/show_bug.cgi?id=76216

Reviewed by Eric Seidel.

Spec: http://www.w3.org/TR/DOM-Level-3-Events/#events-FocusEvent

This patch creates a new FocusEvent class with a relatedTarget attribute.
Now when focusin or focusout events are dispatched, a FocusEvent is created with
the relatedTarget attribute set accordingly.

Source/WebCore:

Test: fast/events/related-target-focusevent.html

CMakeLists.txt:
DerivedSources.cpp:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
dom/DOMAllInOne.cpp:
dom/Event.cpp:

(WebCore::Event::isFocusEvent):
(WebCore):

dom/Event.h:

(Event):

dom/EventContext.cpp:

(WebCore::EventContext::handleLocalEvents):

dom/EventNames.in:
dom/FocusEvent.h: Added.

(WebCore):
(FocusEvent):
(WebCore::FocusEvent::create):
(WebCore::FocusEvent::relatedTarget):
(WebCore::FocusEvent::setRelatedTarget):
(WebCore::toFocusEvent):

dom/FocusEvent.idl: Added.
dom/Node.cpp:

(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):

LayoutTests:

fast/dom/shadow/shadow-boundary-events-expected.txt:
fast/dom/shadow/shadow-boundary-events.html:
fast/events/related-target-focusevent-expected.txt: Added.
fast/events/related-target-focusevent.html: Added.

12:25 AM Changeset in webkit [142071] by tkent@chromium.org

3 edits in trunk/Source/WebCore

Fix style of RenderTheme.cpp and RenderThemeChromiumWin.h
https://bugs.webkit.org/show_bug.cgi?id=109137

Reviewed by Kentaro Hara.

No new tests. Just style fix.

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore::RenderTheme::isControlStyled):
(WebCore::RenderTheme::adjustButtonStyle):
(WebCore::RenderTheme::systemColor):

rendering/RenderThemeChromiumWin.h:

(WebCore::ThemeData::ThemeData):
(ThemeData):
(RenderThemeChromiumWin):
(WebCore::RenderThemeChromiumWin::RenderThemeChromiumWin):
(WebCore::RenderThemeChromiumWin::~RenderThemeChromiumWin):

12:25 AM Changeset in webkit [142070] by Simon Hausmann

6 edits
8 adds in trunk

[Qt] Compile WTF tests of TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=108935

Reviewed by Kenneth Rohde Christiansen.

Build gtest on Linux.

WebKit.pro:

Source/ThirdParty:

Add qmake build system .pro file for building gtest as static library.

gtest/gtest.pro: Added.

Tools:

Add initial stubs and files for building at least the WTF tests.
The WK2 tests need more platform code, in particular PlatformWebView
and injected bundle support.

TestWebKitAPI/TestWebKitAPI.pri: Added.
TestWebKitAPI/TestWebKitAPI.pro: Added.
TestWebKitAPI/Tests/WTF/WTF.pro: Added.
TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::InjectedBundleController::platformInitialize):

TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Added.

(Util):
(TestWebKitAPI::Util::run):
(TestWebKitAPI::Util::sleep):
(TestWebKitAPI::Util::createInjectedBundlePath):
(TestWebKitAPI::Util::createURLForResource):
(TestWebKitAPI::Util::URLForNonExistentResource):

TestWebKitAPI/qt/main.cpp: Added.

(main):

Tools.pro:
qmake/mkspecs/features/default_post.prf:

12:23 AM Changeset in webkit [142069] by tkent@chromium.org

3 edits in trunk/Source/WebCore

Fix style of Chrome.h and Page.h
https://bugs.webkit.org/show_bug.cgi?id=109138

Reviewed by Ryosuke Niwa.

No new tests. Just style fixes.

page/Chrome.h:

(WebCore):
(Chrome):
(WebCore::Chrome::client):

page/Page.h:

(JSC):
(WebCore):
(WebCore::ArenaSize::ArenaSize):
(ArenaSize):
(Page):
(PageClients):
(WebCore::Page::theme):
(WebCore::Page::canStartMedia):
(WebCore::Page::editorClient):
(WebCore::Page::plugInClient):
(WebCore::Page::mainFrame):
(WebCore::Page::groupPtr):
(WebCore::Page::incrementSubframeCount):
(WebCore::Page::decrementSubframeCount):
(WebCore::Page::subframeCount):
(WebCore::Page::chrome):
(WebCore::Page::dragCaretController):
(WebCore::Page::dragController):
(WebCore::Page::focusController):
(WebCore::Page::contextMenuController):
(WebCore::Page::inspectorController):
(WebCore::Page::pointerLockController):
(WebCore::Page::validationMessageClient):
(WebCore::Page::settings):
(WebCore::Page::progress):
(WebCore::Page::backForward):
(WebCore::Page::featureObserver):
(WebCore::Page::viewMode):
(WebCore::Page::setTabKeyCyclesThroughElements):
(WebCore::Page::tabKeyCyclesThroughElements):
(WebCore::Page::scheduledRunLoopPairs):
(WebCore::Page::defersLoading):
(WebCore::Page::mediaVolume):
(WebCore::Page::pageScaleFactor):
(WebCore::Page::deviceScaleFactor):
(WebCore::Page::shouldSuppressScrollbarAnimations):
(WebCore::Page::pagination):
(WebCore::Page::isOnscreen):
(WebCore::Page::scriptedAnimationsSuspended):
(WebCore::Page::debugger):
(WebCore::Page::hasCustomHTMLTokenizerTimeDelay):
(WebCore::Page::customHTMLTokenizerTimeDelay):
(WebCore::Page::hasCustomHTMLTokenizerChunkSize):
(WebCore::Page::customHTMLTokenizerChunkSize):
(WebCore::Page::areMemoryCacheClientCallsEnabled):
(WebCore::Page::setEditable):
(WebCore::Page::isEditable):
(WebCore::Page::displayID):
(WebCore::Page::layoutMilestones):
(WebCore::Page::setIsPainting):
(WebCore::Page::isPainting):
(WebCore::Page::alternativeTextClient):
(WebCore::Page::checkSubframeCountConsistency):
(WebCore::Page::group):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed