Timeline
Mar 8, 2013:
- 10:40 PM Changeset in webkit [145305] by
-
- 5 edits8 adds in trunk
REGRESSION(r140907): Incorrect baseline for cells with media content during load
https://bugs.webkit.org/show_bug.cgi?id=108357
Reviewed by Julien Chaffraix.
Source/WebCore:
If a cell has replaced content, the intrinsic height of its content can change between layouts. If that's the case then the intrinsic padding we used
for layout (the padding required to push the contents of the cell down to the row's baseline) is included in the new height and baseline and makes both
of them wrong. So if a cell's content's intrinsic height has changed push the new content up into the intrinsic padding and relayout so that the rest of
table and row layout can use the correct baseline and height for this cell.
Tests: fast/css/vertical-align-baseline-rowspan-012.html
http/tests/css/vertical-align-baseline-after-image-load-2.html
http/tests/css/vertical-align-baseline-after-image-load-3.html
http/tests/css/vertical-align-baseline-after-image-load.html
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::layout):
- rendering/RenderTableCell.h:
(WebCore::RenderTableCell::isBaselineAligned):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
LayoutTests:
- fast/css/vertical-align-baseline-rowspan-012-expected.html: Added.
- fast/css/vertical-align-baseline-rowspan-012.html: Added.
- http/tests/css/vertical-align-baseline-after-image-load-2-expected.html: Added.
- http/tests/css/vertical-align-baseline-after-image-load-2.html: Added.
- http/tests/css/vertical-align-baseline-after-image-load-3-expected.html: Added.
- http/tests/css/vertical-align-baseline-after-image-load-3.html: Added.
- http/tests/css/vertical-align-baseline-after-image-load-expected.html: Added.
- http/tests/css/vertical-align-baseline-after-image-load.html: Added.
- 10:37 PM Changeset in webkit [145304] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION: Intermittent crash in SpeechSynthesis::didFinishSpeaking
https://bugs.webkit.org/show_bug.cgi?id=111613
Reviewed by Ryosuke Niwa.
This crash happens when the mock synthesizer utterance variable gets cleared
before the speakingFinished timer happens. I don't see how that could happen
but I was able to make a similar problem happen when cancel is called twice.
This adds in a few more asserts and common sense checks. I'm hoping it will
illuminate the problem further.
- platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
(WebCore::PlatformSpeechSynthesizerMock::speak):
(WebCore::PlatformSpeechSynthesizerMock::cancel):
- 9:54 PM Changeset in webkit [145303] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX: Make WebCore link for iOS
- WebCore.exp.in:
- Add ENABLE(RUBBER_BAND) for FrameView::setWantsLayerForTopOverHangArea(bool) and FrameView::setWantsLayerForBottomOverHangArea(bool).
- Move FloatPoint::FloatPoint(_NSPoint const&) to !PLATFORM(IOS) section.
- 9:54 PM Changeset in webkit [145302] by
-
- 5 edits in trunk/Websites/bugs.webkit.org
(CVE-2013-0786) [SECURITY] build_subselect() leaks the existence of products and components you cannot access
<https://bugzilla.mozilla.org/show_bug.cgi?id=824399>
<exp2://Ticket/14465628>
Applied "v5 patch, 3.6" to bugs.webkit.org.
- Bugzilla/Config/GroupSecurity.pm:
(get_param_list):
- buglist.cgi:
- report.cgi:
- template/en/default/admin/params/groupsecurity.html.tmpl:
- 9:54 PM Changeset in webkit [145301] by
-
- 3 edits in trunk/Websites/bugs.webkit.org
(CVE-2013-0785) [SECURITY] XSS in show_bug.cgi when using an invalid page format
<https://bugzilla.mozilla.org/show_bug.cgi?id=842038>
<exp2://Ticket/14465628>
Applied "patch for 3.6 and 4.0, v1" to bugs.webkit.org.
- Bugzilla/Template.pm:
(get_format):
- show_bug.cgi:
- 9:20 PM May 2013 Meeting edited by
- Add myself to pixel->ref test conversion Hackathon; also add an option … (diff)
- 9:11 PM May 2013 Meeting edited by
- Rename a topic. (diff)
- 9:04 PM May 2013 Meeting edited by
- Added "Reduce the amount of knowledge you need in order to contribute … (diff)
- 8:50 PM May 2013 Meeting edited by
- (diff)
- 8:31 PM Changeset in webkit [145300] by
-
- 9 edits in trunk
Unreviewed, rolling out r145254, r145264, and r145288.
http://trac.webkit.org/changeset/145254
http://trac.webkit.org/changeset/145264
http://trac.webkit.org/changeset/145288
https://bugs.webkit.org/show_bug.cgi?id=111917
Test breakage hints at conceptual unsoundness (Requested by ap
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-08
Source/WebKit2:
- NetworkProcess/SchedulableLoader.cpp:
(WebKit::SchedulableLoader::invalidateSandboxExtensions):
- Shared/Downloads/Download.cpp:
(WebKit::Download::didFinish):
(WebKit::Download::didFail):
(WebKit::Download::didCancel):
- Shared/SandboxExtension.h:
(SandboxExtension):
(WebKit::SandboxExtension::invalidate):
- Shared/WebMemorySampler.cpp:
(WebKit::WebMemorySampler::stop):
- Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtension::SandboxExtension):
(WebKit::SandboxExtension::invalidate):
(WebKit::SandboxExtension::consume):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):
(WebKit::WebPage::SandboxExtensionTracker::invalidate):
(WebKit::WebPage::SandboxExtensionTracker::setPendingProvisionalSandboxExtension):
(WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad):
(WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad):
LayoutTests:
- platform/mac-wk2/TestExpectations:
- 6:51 PM Changeset in webkit [145299] by
-
- 16 edits8 adds in trunk
DFG overflow check elimination is too smart for its own good
https://bugs.webkit.org/show_bug.cgi?id=111832
Source/JavaScriptCore:
Reviewed by Oliver Hunt and Gavin Barraclough.
This improves overflow check elimination in three ways:
1) It reduces the amount of time the compiler will spend doing it.
2) It fixes bugs where overflow check elimination was overzealous. Precisely, for a binary operation
over @a and @b where both @a and @b will type check that their inputs (@a->children, @b->children)
are int32's and then perform a possibly-overflowing operation, we must be careful not to assume
that @a's non-int32 parts don't matter if at the point that @a runs we have as yet not proved that
@b->children are int32's and that hence @b might produce a large enough result that doubles would
start chopping low bits. The specific implication of this is that for a binary operation to not
propagate that it cares about non-int32 parts (NodeUsedAsNumber), we must prove that at least one
of the inputs is guaranteed to produce a result within 232 and that there won't be a tower of such
operations large enough to ultimately produce a double greater than 252 (roughly). We achieve the
latter by disabling this optimization for very large basic blocks. It's noteworthy that blocks that
large won't even make it into the DFG currently.
3) It makes the overflow check elimination more precise for cases where the inputs to an Add or Sub
are the outputs of a bit-op. For example in (@a + (@b | 0)) | 0, we don't need to propagate
NodeUsedAsNumber to either @a or @b.
This is neutral on V8v7 and a slight speed-up on compile time benchmarks.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::refine):
- dfg/DFGBackwardsPropagationPhase.cpp: Added.
(DFG):
(BackwardsPropagationPhase):
(JSC::DFG::BackwardsPropagationPhase::BackwardsPropagationPhase):
(JSC::DFG::BackwardsPropagationPhase::run):
(JSC::DFG::BackwardsPropagationPhase::isNotNegZero):
(JSC::DFG::BackwardsPropagationPhase::isNotZero):
(JSC::DFG::BackwardsPropagationPhase::isWithinPowerOfTwoForConstant):
(JSC::DFG::BackwardsPropagationPhase::isWithinPowerOfTwoNonRecursive):
(JSC::DFG::BackwardsPropagationPhase::isWithinPowerOfTwo):
(JSC::DFG::BackwardsPropagationPhase::mergeDefaultFlags):
(JSC::DFG::BackwardsPropagationPhase::propagate):
(JSC::DFG::performBackwardsPropagation):
- dfg/DFGBackwardsPropagationPhase.h: Added.
(DFG):
- dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::run):
(JSC::DFG::CPSRethreadingPhase::clearIsLoadedFrom):
(CPSRethreadingPhase):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocalFor):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGNodeFlags.cpp:
(JSC::DFG::dumpNodeFlags):
(DFG):
- dfg/DFGNodeFlags.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGUnificationPhase.cpp:
(JSC::DFG::UnificationPhase::run):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeIsLoadedFrom):
(VariableAccessData):
(JSC::DFG::VariableAccessData::setIsLoadedFrom):
(JSC::DFG::VariableAccessData::isLoadedFrom):
LayoutTests:
Reviewed by Oliver Hunt and Gavin Barraclough.
- fast/js/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int-expected.txt: Added.
- fast/js/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.html: Added.
- fast/js/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers-expected.txt: Added.
- fast/js/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.js: Added.
(foo):
(bar):
- fast/js/script-tests/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.js: Added.
(foo):
(bar):
- 6:29 PM Changeset in webkit [145298] by
-
- 13 edits16 adds2 deletes in trunk/LayoutTests
Update chromium baselines for transforms/3d/point-mapping
- platform/chromium-linux-x86/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
- platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
- platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
- platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
- platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
- platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-expected.png:
- platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
- platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png:
- platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
- platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
- platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
- platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
- platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
- platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png:
- platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
- platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
- platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
- platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
- platform/chromium-win-xp/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
- platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
- platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
- platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png:
- platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Removed.
- platform/chromium/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Removed.
- 5:48 PM Changeset in webkit [145297] by
-
- 5 edits in trunk
[CSS Grid Layout] Resolve grid-{end|after} integer against the end|after edge
https://bugs.webkit.org/show_bug.cgi?id=111885
Reviewed by Tony Chang.
Source/WebCore:
The current code resolves grid-end (resp. grid-after) <integer>'s format against the start
(resp. before) axis. The specification changed so that they are resolved against their matching
axis.
Test: fast/css-grid-layout/grid-auto-flow-resolution.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::maximumIndexInDirection):
Updated the code to do the grid sizing measurement without resolveGridPositionsFromStyle. That's required
as resolveGridPositionsFromStyle requires the grid to be sized.
(WebCore::RenderGrid::placeItemsOnGrid):
Added a comment about not recomputing after grid growth. This issue was raised to www-style
(http://lists.w3.org/Archives/Public/www-style/2013Mar/0182.html).
(WebCore::RenderGrid::resolveGridPositionsFromStyle):
Added an ASSERT now that we don't call it during grid construction. Also added some code to pass
the side of the GridPosition we give to resolveGridPositionFromStyle.
(WebCore::RenderGrid::resolveGridPositionFromStyle):
Updated the code to resolve the grid position against the right side.
- rendering/RenderGrid.h:
Added GridPositionSide and updated resolveGridPositionFromStyle's signature.
LayoutTests:
- fast/css-grid-layout/grid-auto-flow-resolution-expected.txt:
Moar passing tests!
- 5:37 PM Changeset in webkit [145296] by
-
- 17 edits14 deletes in trunk
Unreviewed, rolling out r142015.
http://trac.webkit.org/changeset/142015
https://bugs.webkit.org/show_bug.cgi?id=111904
The change caused 2 major regressions (bug 111091 and bug
111595) and Pravin doesn't have time to investigate them
(Requested by jchaffraix on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-08
Source/WebCore:
- dom/Node.cpp:
(WebCore::Node::diff):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::childBecameNonInline):
(WebCore):
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::childBecameNonInline):
(RenderBoxModelObject):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::childBecameNonInline):
(WebCore):
- rendering/RenderInline.h:
(RenderInline):
- rendering/RenderObject.cpp:
(WebCore):
(WebCore::RenderObject::handleDynamicFloatPositionChange):
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::styleDidChange):
- rendering/RenderObject.h:
(RenderObject):
LayoutTests:
- fast/css/first-letter-removed-added-expected.txt:
- fast/dynamic/absolute-positioned-to-static-positioned-expected.txt: Removed.
- fast/dynamic/absolute-positioned-to-static-positioned.html: Removed.
- fast/dynamic/floating-to-non-floating-expected.txt: Removed.
- fast/dynamic/floating-to-non-floating.html: Removed.
- fast/dynamic/non-floating-to-floating-expected.txt: Removed.
- fast/dynamic/non-floating-to-floating.html: Removed.
- fast/dynamic/resources/helper-bug91665.js: Removed.
- fast/dynamic/resources/style-bug91665.css: Removed.
- fast/dynamic/static-positioned-to-absolute-positioned-expected.txt: Removed.
- fast/dynamic/static-positioned-to-absolute-positioned.html: Removed.
- fullscreen/full-screen-fixed-pos-parent-expected.txt:
- platform/chromium-mac/fast/repaint/absolute-position-change-containing-block-expected.png:
- platform/chromium-mac/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png:
- platform/chromium-win/fast/dynamic/002-expected.txt:
- platform/chromium/fast/dynamic/002-expected.txt:
- platform/chromium/fast/repaint/absolute-position-change-containing-block-expected.png: Removed.
- platform/chromium/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Removed.
- platform/mac/fast/dynamic/002-expected.txt:
- platform/mac/fast/repaint/absolute-position-change-containing-block-expected.png: Removed.
- platform/mac/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Removed.
- 5:31 PM Changeset in webkit [145295] by
-
- 6 edits in trunk
Don't snapshot Java plugins
https://bugs.webkit.org/show_bug.cgi?id=111899
Reviewed by Tim Horton.
Top-level:
Export MIMETypeRegistry::isJavaAppletMIMEType symbol.
- Source/autotools/symbols.filter:
Source/WebCore:
Export MIMETypeRegistry::isJavaAppletMIMEType symbol.
- WebCore.exp.in:
Source/WebKit2:
If the plugin is Java, return true from shouldAlwaysAutoStart.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::shouldAlwaysAutoStart): Check the mimetype for Java.
- 5:31 PM Changeset in webkit [145294] by
-
- 2 edits in trunk/Tools
Cleanup: Remove dead code.
https://bugs.webkit.org/show_bug.cgi?id=111900
Reviewed by Dirk Pranke.
Treemap overrides a global function that used to be in
dashboard_base, but was removed months ago in
https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
no caller.
- TestResultServer/static-dashboards/treemap.html:
- 5:29 PM Changeset in webkit [145293] by
-
- 4 edits in trunk
[HTMLTemplateElement] processTemplateEndTag() needs to check for template in html scope
https://bugs.webkit.org/show_bug.cgi?id=111880
Reviewed by Eric Seidel.
Source/WebCore:
Currently, </template> handling exits with an error if there is not a template tag "in scope"
which will be true if there is a table (for instance) below a template. This makes it so that
the search (correctly) examines the entire element stack.
Tests added to html5lib testing library.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processTemplateEndTag):
LayoutTests:
- html5lib/resources/template.dat:
- 5:06 PM Changeset in webkit [145292] by
-
- 19 edits2 adds in trunk/Source/WebCore
BackgroundHTMLParser should be able to atomize well-known strings
https://bugs.webkit.org/show_bug.cgi?id=107337
Reviewed by Adam Barth.
Testing this patch easily requires applying bug 107236 locally
to remove all the rendering noise from Parser/html-threaded-parser.html.
This patch adds a new class HTMLIdentifier which allows us to avoid
allocating strings for known tag/attribute names from HTMLNames.
There is still a lot of meat on this bone, but I think it's important to
land something "smallish" to start and iterate from there.
This took Parser/html-threaded-parser.html from:
median= 443.726500002 ms, stdev= 7.25002679952 ms, min= 430.244000047 ms, max= 455.511000007 ms
to:
median= 427.849500004 ms, stdev= 9.96967058292 ms, min= 417.914000049 ms, max= 461.528000014 ms
on my MBP.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- html/parser/AtomicHTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::tokenExitsForeignContent):
(WebCore::tokenExitsSVG):
(WebCore::tokenExitsMath):
(WebCore::BackgroundHTMLParser::simulateTreeBuilder):
- html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::scan):
- html/parser/CSSPreloadScanner.h:
(WebCore):
(CSSPreloadScanner):
- html/parser/CompactHTMLToken.cpp:
(SameSizeAsCompactHTMLToken):
(WebCore::CompactHTMLToken::CompactHTMLToken):
- html/parser/CompactHTMLToken.h:
(WebCore::CompactHTMLToken::Attribute::Attribute):
(Attribute):
(WebCore::CompactHTMLToken::data):
(WebCore::CompactHTMLToken::publicIdentifier):
(CompactHTMLToken):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::startBackgroundParser):
- html/parser/HTMLIdentifier.cpp: Added.
(WebCore):
(WebCore::identifierTable):
(WebCore::HTMLIdentifier::hasIndex):
(WebCore::HTMLIdentifier::findIndex):
(WebCore::nameForIndex):
(WebCore::HTMLIdentifier::asString):
(WebCore::HTMLIdentifier::asStringImpl):
(WebCore::HTMLIdentifier::addNames):
(WebCore::HTMLIdentifier::init):
- html/parser/HTMLIdentifier.h: Added.
(WebCore):
(HTMLIdentifier):
(WebCore::HTMLIdentifier::HTMLIdentifier):
(WebCore::HTMLIdentifier::isSafeToSendToAnotherThread):
- html/parser/HTMLParserIdioms.cpp:
(WebCore::threadSafeEqual):
(WebCore::threadSafeMatch):
- html/parser/HTMLParserIdioms.h:
(WebCore):
(WebCore::threadSafeHTMLNamesMatch):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::tagIdFor):
(WebCore::TokenPreloadScanner::StartTagScanner::match):
(TokenPreloadScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
- html/parser/HTMLPreloadScanner.h:
- 4:56 PM Changeset in webkit [145291] by
-
- 6 edits in tags/Safari-537.33.2/Source
Merged r145247. <rdar://problem/13383659>
- 4:53 PM Changeset in webkit [145290] by
-
- 4 edits in tags/Safari-537.33.2/Source
Versioning.
- 4:49 PM Changeset in webkit [145289] by
-
- 1 copy in tags/Safari-537.33.2
New Tag.
- 4:42 PM Changeset in webkit [145288] by
-
- 2 edits in trunk/LayoutTests
Add a failing test expectation per bug 111901.
- platform/mac-wk2/TestExpectations:
- 4:29 PM Changeset in webkit [145287] by
-
- 3 edits3 copies in trunk/LayoutTests
Update a few more chromium baselines.
- platform/chromium-mac-lion/editing/pasteboard/paste-text-016-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt.
- platform/chromium-mac/editing/pasteboard/paste-text-016-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt.
- platform/chromium-win-xp/editing/pasteboard/paste-text-016-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt.
- platform/chromium-win-xp/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt:
- 4:17 PM Changeset in webkit [145286] by
-
- 4 edits in branches/safari-536.29-branch/Source
Versioning.
- 4:15 PM Changeset in webkit [145285] by
-
- 1 copy in tags/Safari-536.29.6
New Tag.
- 4:15 PM Changeset in webkit [145284] by
-
- 5 edits in branches/safari-534.59-branch/Source
Versioning.
- 4:14 PM Changeset in webkit [145283] by
-
- 1 copy in tags/Safari-534.59.2
New Tag.
- 4:10 PM Changeset in webkit [145282] by
-
- 3 edits in branches/safari-536.29-branch/Source/WebKit2
Windows build fix #2.
<rdar://problem/13380471> REGRESSION: Debussy Windows broken after merging http://trac.webkit.org/changeset/144831
Reviewed by Roger Fong.
- win/WebKit2.def:
- win/WebKit2.vcproj:
- 3:57 PM Changeset in webkit [145281] by
-
- 2 edits in branches/safari-536.29-branch/Source/WebKit2
Windows build fix.
<rdar://problem/13380471> REGRESSION: Debussy Windows broken after merging http://trac.webkit.org/changeset/144831
Reviewed by Roger Fong.
- win/WebKit2.def:
- 3:47 PM Changeset in webkit [145280] by
-
- 3 edits in trunk/Source/WebCore
Check to ensure MultisampleRenderbuffer creation succeeds
https://bugs.webkit.org/show_bug.cgi?id=111780
Patch by Brandon Jones <bajones@google.com> on 2013-03-08
Reviewed by Dean Jackson.
On OSX systems using AMD graphics chips the allocation of large
Multisample Renderbuffers in Chromium would fail without any indication
of failure. Attempting to draw to the buffer resulted in garbage being
rendered onscreen. This could be reproduced by opening a full-page
WebGL app and pressing (Command + "-") several times. This patch adds an
additional check during DrawingBuffer resize to verify that the resized
buffer is valid.
- platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore):
(WebCore::DrawingBuffer::checkBufferIntegrity):
(WebCore::DrawingBuffer::reset):
- platform/graphics/gpu/DrawingBuffer.h:
(DrawingBuffer):
- 3:45 PM Changeset in webkit [145279] by
-
- 19 edits3 deletes in trunk
Implemented new API for RTCStatsReport object.
https://bugs.webkit.org/show_bug.cgi?id=110333
Source/Platform:
Patch by Harald Alvestrand <hta@chromium.org> on 2013-03-08
Reviewed by Adam Barth.
- chromium/public/WebRTCStatsResponse.h:
(WebKit::WebRTCStatsResponse::WebRTCStatsResponse):
(WebRTCStatsResponse):
Source/WebCore:
Removed RTCStatsElement object, moved its interface to
RTCStatsReport. Preserved some interfaces for
backwards compatibility; will be removed in a later patch.
Patch by Harald Alvestrand <hta@chromium.org> on 2013-03-08
Reviewed by Adam Barth.
Tested by extensions to RTCPeerConnection-stats test.
- Modules/mediastream/RTCStatsElement.cpp: Removed.
- Modules/mediastream/RTCStatsElement.h: Removed.
- Modules/mediastream/RTCStatsElement.idl: Removed.
- Modules/mediastream/RTCStatsReport.cpp:
(WebCore::RTCStatsReport::create):
(WebCore::RTCStatsReport::RTCStatsReport):
(WebCore):
(WebCore::RTCStatsReport::names):
(WebCore::RTCStatsReport::local):
(WebCore::RTCStatsReport::remote):
(WebCore::RTCStatsReport::addStatistic):
(WebCore::RTCStatsReport::addElement):
- Modules/mediastream/RTCStatsReport.h:
(RTCStatsReport):
(WebCore::RTCStatsReport::timestamp):
(WebCore::RTCStatsReport::id):
(WebCore::RTCStatsReport::stat):
- Modules/mediastream/RTCStatsReport.idl:
- Modules/mediastream/RTCStatsResponse.cpp:
(WebCore::RTCStatsResponse::namedItem):
(WebCore):
(WebCore::RTCStatsResponse::addReport):
(WebCore::RTCStatsResponse::addStatistic):
- Modules/mediastream/RTCStatsResponse.h:
(RTCStatsResponse):
- Modules/mediastream/RTCStatsResponse.idl:
- WebCore.gypi:
- platform/chromium/support/WebRTCStatsResponse.cpp:
(WebKit::WebRTCStatsResponse::addReport):
(WebKit):
(WebKit::WebRTCStatsResponse::addStatistic):
(WebKit::WebRTCStatsResponse::addElement):
- platform/mediastream/RTCStatsResponseBase.h:
(RTCStatsResponseBase):
Tools:
Patch by Harald Alvestrand <hta@chromium.org> on 2013-03-08
Reviewed by Adam Barth.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
(WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
LayoutTests:
Patch by Harald Alvestrand <hta@chromium.org> on 2013-03-08
Reviewed by Adam Barth.
- fast/mediastream/RTCPeerConnection-stats-expected.txt:
- fast/mediastream/RTCPeerConnection-stats.html:
- 3:40 PM Changeset in webkit [145278] by
-
- 4 edits7 copies36 adds in trunk/LayoutTests
Chromium rebaselines and expectations updates.
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
- platform/chromium-linux/compositing/tiling/rotated-tiled-clamped-expected.png: Added.
- platform/chromium-linux/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-mac/compositing/tiling/rotated-tiled-clamped-expected.png: Added.
- platform/chromium-mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.png: Added.
- platform/chromium-mac/platform/chromium/compositing/rubberbanding/transform-overhang-ne-expected.png: Added.
- platform/chromium-mac/platform/chromium/compositing/rubberbanding/transform-overhang-nw-expected.png: Added.
- platform/chromium-mac/platform/chromium/compositing/rubberbanding/transform-overhang-se-expected.png: Added.
- platform/chromium-mac/platform/chromium/compositing/rubberbanding/transform-overhang-size-change-expected.png: Added.
- platform/chromium-mac/platform/chromium/compositing/rubberbanding/transform-overhang-sw-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-scroll-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
- platform/chromium-win/compositing/tiling/rotated-tiled-clamped-expected.png: Added.
- platform/chromium-win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-scroll-expected.txt: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium/TestExpectations:
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.txt: Added.
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.txt: Added.
- platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.txt: Added.
- 3:39 PM Changeset in webkit [145277] by
-
- 6 edits in trunk/Source/WebCore
Free up background parser's checkpoints when speculation succeeds
https://bugs.webkit.org/show_bug.cgi?id=110547
Reviewed by Adam Barth.
This should be a memory (and possible perf) win while parsing
pages, as we will no longer hold multiple copies of every
source byte during the whole parse.
Many LayoutTests exercise this code path, and I've manually (debugger and printf)
that we're hitting this code, but we'll have to wait for the memory/perf bots
to tell us if this shows up as a win.
We only bother to message the parser at the end of a speculation chain, so as not
to send too many messages to the background parser.
- html/parser/BackgroundHTMLInputStream.cpp:
(WebCore::BackgroundHTMLInputStream::BackgroundHTMLInputStream):
(WebCore::BackgroundHTMLInputStream::invalidateCheckpointsUpThrough):
(WebCore):
(WebCore::BackgroundHTMLInputStream::rewindTo):
- html/parser/BackgroundHTMLInputStream.h:
(BackgroundHTMLInputStream):
(Checkpoint):
(WebCore::BackgroundHTMLInputStream::Checkpoint::isNull):
(WebCore::BackgroundHTMLInputStream::Checkpoint::clear):
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::passedCheckpoint):
(WebCore):
- html/parser/BackgroundHTMLParser.h:
(BackgroundHTMLParser):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
- 3:27 PM Changeset in webkit [145276] by
-
- 3 edits1 add in trunk
[chromium] Keydown event for 'shift+alt' returns win keycode instead of 'alt'
https://bugs.webkit.org/show_bug.cgi?id=111112
Patch by Chandra Shekar Vallala <brk376@motorola.com> on 2013-03-08
Reviewed by Tony Chang.
.:
Return windows keycode of Alt incase of GDK_META_L, GDK_META_R.
Try press Shift then alt key. The test passes if the shiftKey, altKey values
of JSKeyEvent are true and keycode/which is 18.
- ManualTests/shift-alt-key-event.html: Added.
Source/WebCore:
Return windows keycode of Alt incase of GDK_META_L, GDK_META_R. This matches
the firefox behaviour in linux platform.
Added Manual Test : ManualTests/shift-alt-key-event.html
Try press Shift then alt key. The test passes if the shiftKey, altKey values
of JSKeyEvent are true and keycode/which is 18.
- platform/chromium/KeyCodeConversionGtk.cpp:
(WebCore::windowsKeyCodeForKeyEvent):
- 3:11 PM Changeset in webkit [145275] by
-
- 20 edits5 copies in branches/chromium/1364
Merge 144236
Plugin in iframe may not display
https://bugs.webkit.org/show_bug.cgi?id=109879
Patch by John Bauman <jbauman@chromium.org> on 2013-02-27
Reviewed by Simon Fraser.
Source/WebCore:
Changing the cliprect on a layer containing an iframe may change the
cliprect of plugins inside the iframe, so recursively tell all plugins
in iframes that their cliprect has changed after doing layout on the
outer frame.
Test: plugins/plugin-clip-subframe.html
- platform/ScrollView.cpp:
(WebCore::ScrollView::clipRectChanged):
- platform/ScrollView.h:
- platform/Widget.h:
(WebCore::Widget::clipRectChanged):
- plugins/PluginView.cpp:
(WebCore::PluginView::clipRectChanged):
- plugins/PluginView.h:
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
Source/WebKit/chromium:
Use clipRectChanged to update the geometry.
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::clipRectChanged):
- src/WebPluginContainerImpl.h:
Source/WebKit/mac:
Ensure NetscapePluginWidget informs the plugin view of the cliprect change directly.
- Plugins/WebBaseNetscapePluginView.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(NetscapePluginWidget::clipRectChanged):
Source/WebKit2:
Update geometry when cliprect changes.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::clipRectChanged):
- WebProcess/Plugins/PluginView.h:
Tools:
LogNPPSetWindow will be used with other ports as well.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
LayoutTests:
Use log-npp-set-window to ensure plugin clip changes correctly.
- platform/mac-wk2/plugins/plugin-clip-subframe-expected.txt: Added.
- platform/mac/plugins/plugin-clip-subframe-expected.txt: Added.
- plugins/plugin-clip-subframe-expected.txt: Added.
- plugins/plugin-clip-subframe.html: Added.
- plugins/resources/plugin-clip-subframe-iframe.html: Added.
BUG=168900
TBR=jbauman@chromium.org
Review URL: https://codereview.chromium.org/12475008
- 2:57 PM Changeset in webkit [145274] by
-
- 18 edits1 copy1 move14 adds in trunk/LayoutTests
Update some more chromium compositor pixel baselines.
- platform/chromium-linux/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-linux/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- platform/chromium-linux/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-linux/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
- platform/chromium-linux/compositing/reflections/load-video-in-reflection-expected.png:
- platform/chromium-linux/compositing/reflections/nested-reflection-anchor-point-expected.png:
- platform/chromium-mac-lion/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-mac-lion/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-mac-lion/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
- platform/chromium-mac-lion/compositing/reflections/load-video-in-reflection-expected.png:
- platform/chromium-mac-lion/compositing/reflections/nested-reflection-anchor-point-expected.png:
- platform/chromium-mac-snowleopard/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-mac-snowleopard/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
- platform/chromium-mac-snowleopard/compositing/reflections/load-video-in-reflection-expected.png:
- platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-anchor-point-expected.png:
- platform/chromium-mac/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-mac/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-mac/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
- platform/chromium-mac/compositing/reflections/load-video-in-reflection-expected.png:
- platform/chromium-mac/compositing/reflections/nested-reflection-anchor-point-expected.png:
- platform/chromium-win/compositing/masks/simple-composited-mask-expected.png:
- platform/chromium-win/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
- platform/chromium-win/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
- platform/chromium-win/compositing/reflections/load-video-in-reflection-expected.png:
- platform/chromium-win/compositing/reflections/nested-reflection-anchor-point-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
- platform/chromium/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.txt: Added.
- platform/chromium/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.txt: Added.
- platform/efl-wk2/compositing/reflections/nested-reflection-anchor-point-expected.png: Renamed from LayoutTests/platform/efl/compositing/reflections/nested-reflection-anchor-point-expected.png.
- 2:45 PM Changeset in webkit [145273] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r187037. Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-08
- DEPS:
- 2:41 PM Changeset in webkit [145272] by
-
- 2 edits in trunk/Tools
[chromium] use custom freetype on linux asan builds again
https://bugs.webkit.org/show_bug.cgi?id=111884
Reviewed by Tony Chang.
We no longer need the workaround after chromium r186540.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 2:38 PM Changeset in webkit [145271] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. AppleWin port.
- platform/win/TestExpectations:
- 2:36 PM Changeset in webkit [145270] by
-
- 2 edits in trunk/Tools
Warning about the user not having edit rights on Bugzilla is confusing new contributors
https://bugs.webkit.org/show_bug.cgi?id=111798
Reviewed by Dirk Pranke.
Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
- 2:32 PM May 2013 Meeting edited by
- Add a new topic (diff)
- 2:26 PM Changeset in webkit [145269] by
-
- 6 edits3 deletes in trunk/LayoutTests
Update baselines for a few chromium compositor tests.
- platform/chromium-linux/compositing/checkerboard-expected.png: Removed.
- platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-mac-lion/compositing/checkerboard-expected.png: Removed.
- platform/chromium-mac/compositing/checkerboard-expected.png:
- platform/chromium-mac/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-win/compositing/checkerboard-expected.png: Removed.
- platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium/TestExpectations:
- 2:19 PM Changeset in webkit [145268] by
-
- 3 edits2 adds in trunk
CSP: 'eval()' is blocked in report-only mode.
https://bugs.webkit.org/show_bug.cgi?id=111867
Reviewed by Adam Barth.
Source/WebCore:
Setting a 'Content-Security-Policy-Report-Only' header should not have
any effect on what a page actually executes. Currently, however, setting
a 'script-src' directive that doesn't whitelist 'unsafe-eval' actually
blocks 'eval()' on the page. This patch fixes that by checking whether
we're in report-only mode before turning 'eval()' off inside the script
engine.
This leaves us in a weird state, however. We don't currently have any
mechanism of explaining to the VM that we just want to be notified of
'eval()' usage. I've filed http://wkbug.com/111869 to cover this
aspect.
Test: http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode.html
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::didReceiveHeader):
For each policy we parse, check that we're only turning off eval in
the VM when we're in enforce mode. If we're in report-only mode,
skip it.
LayoutTests:
- http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode.html: Added.
- 2:09 PM Changeset in webkit [145267] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13338743> Fix sandbox profile preprocessor flags for compatibility with new clang.
Reviewed by Alexey Proskuryakov.
Patch by Bob Wilson.
- DerivedSources.make: Only use -traditional when we have to work around old behavior of -std=c89.
- 1:47 PM Changeset in webkit [145266] by
-
- 3 edits1 delete in trunk/LayoutTests
Update baselines for string prototypes fixed by v8-i18n roll 164:171
- platform/chromium/fast/js/kde/function_length-expected.txt: Removed.
- platform/chromium/fast/js/kde/inbuilt_function_tostring-expected.txt:
- platform/chromium/fast/js/string-prototype-properties-expected.txt:
- 1:45 PM Changeset in webkit [145265] by
-
- 3 edits2 adds in trunk
REGRESSION (r143643): <button> should support ::first-line and ::first-letter
https://bugs.webkit.org/show_bug.cgi?id=111782
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-08
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/forms/button-first-line-first-letter.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::firstLineBlock):
(WebCore::findFirstLetterBlock):
Add isRenderButton to the first-line and first-letter checks that
don't allow ::first-* styles for flexbox.
LayoutTests:
- fast/forms/button-first-line-first-letter-expected.html: Added.
- fast/forms/button-first-line-first-letter.html: Added.
- 1:25 PM Changeset in webkit [145264] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix for EFL, GTK and Qt after r145254.
- Shared/SandboxExtension.h:
(WebKit::SandboxExtension::revoke):
- 1:20 PM Changeset in webkit [145263] by
-
- 2 edits in trunk/LayoutTests
Layout Test fast/dom/HTMLMeterElement/meter-element-crash.html is failing
https://bugs.webkit.org/show_bug.cgi?id=88131
Reviewed by Tony Chang.
This test was calling setTimeout(..., 0) in a <script> block before the end of the document.
The timeout sometimes fired before parsing the rest of the document and sometimes after,
depending on when the parser yielded. This moves the <script> block to the end of the document
so it always runs after parsing the rest of the test, which is the more common and expected
behavior.
- fast/dom/HTMLMeterElement/meter-element-crash.html:
- 1:14 PM Changeset in webkit [145262] by
-
- 2 edits in trunk/Source/WebKit
Build fix for AppleWin VS2010.
- WebKit.vcxproj/FeatureDefines.props:
- 1:11 PM Changeset in webkit [145261] by
-
- 1 edit3 adds in trunk/LayoutTests
Added a regression test for raw parsing speed
https://bugs.webkit.org/show_bug.cgi?id=111808
Reviewed by Oliver Hunt.
- fast/js/regress/nested-function-parsing-random.html: Added.
- fast/js/regress/script-tests/nested-function-parsing-random.js: Added.
(randomIdent): Use randomness to defeat caching.
- 1:11 PM Changeset in webkit [145260] by
-
- 3 edits in trunk/Source/WebCore
Removed an out-of-date comment from SharedTimer
https://bugs.webkit.org/show_bug.cgi?id=111875
Reviewed by Mark Hahnenberg.
Even if we surround each call to an ObjC interface with an autorelease
pool, it's still nice to have one at top-level entry points like
timers, to avoid turning a single mistake into a long-term leak.
- platform/ios/SharedTimerIOS.mm:
(WebCore::timerFired):
- platform/mac/SharedTimerMac.mm:
(WebCore::timerFired):
- 1:04 PM Changeset in webkit [145259] by
-
- 2 edits6 adds in trunk/LayoutTests
Chromium gardening.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
- platform/chromium-linux/editing/pasteboard/paste-text-016-expected.txt: Added.
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
- platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-016-expected.txt: Added.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
- platform/chromium/TestExpectations:
- 1:02 PM Changeset in webkit [145258] by
-
- 12 edits1 delete in trunk
[chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
https://bugs.webkit.org/show_bug.cgi?id=111632
Patch by James Robinson <jamesr@chromium.org> on 2013-03-08
Reviewed by Adrienne Walker.
Source/Platform:
Neither of these are used any more. All callbacks from the compositor are handled by
the embedder and plumbed (where appropriate) through the WebWidget/WebView APIs. All
settings are handled by the embedder.
- Platform.gypi:
- chromium/public/WebLayerTreeView.h:
(WebKit):
- chromium/public/WebLayerTreeViewClient.h: Removed.
- chromium/public/WebUnitTestSupport.h:
(WebKit):
Source/WebKit/chromium:
- public/WebWidgetClient.h:
(WebWidgetClient):
(WebKit::WebWidgetClient::initializeLayerTreeView):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
- src/WebViewImpl.h:
- tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::FakeWebViewClient::initializeLayerTreeView):
Tools:
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::initializeLayerTreeView):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 12:56 PM Changeset in webkit [145257] by
-
- 9 edits13 adds in trunk/LayoutTests
Mac rebaseline after r145242. I'm really hoping that the optimization didn't mess this up.
- css1/box_properties/margin_bottom-expected.txt: Replaced.
- css1/box_properties/margin_top-expected.txt: Replaced.
- css1/box_properties/padding_bottom-expected.txt: Replaced.
- css1/box_properties/padding_top-expected.txt: Replaced.
- css1/color_and_background/background_attachment-expected.txt: Replaced.
- platform/mac/css1/formatting_model/vertical_formatting-expected.txt:
- platform/mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
- platform/mac/css3/flexbox/flexbox-baseline-expected.txt:
- platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
- platform/mac/tables/mozilla/bugs/bug126742-expected.txt:
- platform/mac/tables/mozilla/bugs/bug69187-expected.txt:
- platform/win-future/css1: Added.
- platform/win-future/css1/box_properties: Added.
- platform/win-future/css1/box_properties/margin_bottom-expected.txt: Added.
- platform/win-future/css1/box_properties/margin_top-expected.txt: Added.
- platform/win-future/css1/box_properties/padding_bottom-expected.txt: Added.
- platform/win-future/css1/box_properties/padding_top-expected.txt: Added.
- platform/win-future/css1/color_and_background: Added.
- platform/win-future/css1/color_and_background/background_attachment-expected.txt: Added.
- 12:47 PM Changeset in webkit [145256] by
-
- 2 edits in trunk/Source/WebKit2
non-Mac ports build fix after r145235.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::createInspectorPageGroup):
- 12:40 PM Changeset in webkit [145255] by
-
- 31 edits in trunk
[Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
https://bugs.webkit.org/show_bug.cgi?id=111297
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
The 'view-mode' Media Feature spec is implemented in WebCore but
there is no WebKit support for it on Mac.
Because of this, we always lie and report a windowed view mode.
This patch add a feature flag for the feature and disable it on
Mac so that we stop reporting incorrect default values.
- WebCore.exp.in:
- css/CSSValueKeywords.in:
- css/MediaFeatureNames.h:
(MediaFeatureNames):
- css/MediaQueryEvaluator.cpp:
- css/MediaQueryExp.cpp:
(WebCore::featureWithCSSValueID):
(WebCore::featureWithoutValue):
- page/Page.cpp:
(WebCore::Page::Page):
- page/Page.h:
(Page):
Source/WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
Source/WTF:
- wtf/FeatureDefines.h: Add a new feature flag for the view-mode
CSS media: ENABLE_VIEW_MODE_CSS_MEDIA.
Tools:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setViewModeMediaFeature):
LayoutTests:
- platform/mac/TestExpectations:
Mark the view-mode tests as failing to track any regression
or crash in this area.
- 12:25 PM Changeset in webkit [145254] by
-
- 7 edits in trunk/Source/WebKit2
Make it possible to reuse sandbox extensions
https://bugs.webkit.org/show_bug.cgi?id=111883
Reviewed by Anders Carlsson.
Replaced invalidate() with revoke().
We now count how many times consume() was called, and keep the extension active
for as long as revoke() hasn't been called as many times. Also, we only permanently
destroy the extension in destructor.
This allows for properly keeping extensions in NetworkBlobRegistry for as long as
they are needed.
- NetworkProcess/SchedulableLoader.cpp: (WebKit::SchedulableLoader::invalidateSandboxExtensions):
- Shared/Downloads/Download.cpp: (WebKit::Download::didFinish): (WebKit::Download::didFail): (WebKit::Download::didCancel):
- Shared/SandboxExtension.h: (SandboxExtension):
- Shared/WebMemorySampler.cpp: (WebKit::WebMemorySampler::stop):
- Shared/mac/SandboxExtensionMac.mm: (WebKit::SandboxExtension::SandboxExtension): (WebKit::SandboxExtension::revoke): (WebKit::SandboxExtension::consume):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::performDragControllerAction): (WebKit::WebPage::SandboxExtensionTracker::invalidate): (WebKit::WebPage::SandboxExtensionTracker::setPendingProvisionalSandboxExtension): (WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad): (WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad):
- 12:11 PM Changeset in webkit [145253] by
-
- 9 edits4 adds in trunk
After sending message, Mail changes formatting
https://bugs.webkit.org/show_bug.cgi?id=111360
Reviewed by Enrica Casucci.
Source/WebCore:
Added makeInsertedContentRoundTrippableWithHTMLTreeBuilder to move prohibited children (e.g. p, h1, etc...)
out of paragraph elements to run immediately after the fragment insertion. This function splits trees and
moves prohibited children out of paragraph elements to keep the tree isomorphic under HTML serialization and
parsing. Unfortunately, there are many other DOM tree constructs we need to fix to make the subtree truly
isomorphic but this is a step forward.
Test: editing/pasteboard/pasting-into-p-should-not-nest-p.html
- editing/ReplaceSelectionCommand.cpp:
(WebCore::isProhibitedParagraphChild): Added. Matches the list at
https://dvcs.w3.org/hg/editing/raw-file/57abe6d3cb60/editing.html#prohibited-paragraph-child
except main element, which is currently missing in the specification.
(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder): Added.
(WebCore::ReplaceSelectionCommand::moveNodeOutOfAncestor): Added.
(WebCore::ReplaceSelectionCommand::doApply): Call moveProhibitedChildrenOutOfParagraphElements.
- editing/ReplaceSelectionCommand.h:
(ReplaceSelectionCommand):
LayoutTests:
Added a regression test, demonstrating that a paragraph element is not nested after a paste.
Also rebaselined multiple tests that had been exhibiting this bug in their expected results.
- editing/pasteboard/block-wrappers-necessary-expected.txt:
- editing/pasteboard/paste-table-001-expected.txt:
- editing/pasteboard/paste-text-011-expected.txt:
- editing/pasteboard/paste-text-015-expected.txt:
- editing/pasteboard/pasting-into-p-should-not-nest-p-expected.txt: Added.
- editing/pasteboard/pasting-into-p-should-not-nest-p.html: Added.
- editing/pasteboard/pasting-into-h6-should-not-nest-h6-expected.txt: Added.
- editing/pasteboard/pasting-into-h6-should-not-nest-h6.html: Added.
- platform/mac/editing/pasteboard/paste-text-016-expected.txt:
- 11:58 AM Changeset in webkit [145252] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r186991. Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-08
- DEPS:
- 11:34 AM Changeset in webkit [145251] by
-
- 58 edits18 adds20 deletes in trunk/LayoutTests
Unreviewed chromium mac/win rebaselines for r145242.
- css1/basic/inheritance-expected.txt: Added.
- css1/box_properties/clear_float-expected.txt: Added.
- css1/box_properties/margin-expected.txt: Added.
- css1/box_properties/padding-expected.txt: Added.
- css1/font_properties/font_weight-expected.txt: Added.
- fast/css-generated-content/015-expected.txt: Added.
- fast/css/h1-in-section-elements-expected.txt: Added.
- platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Removed.
- platform/chromium-mac-lion/css1/box_properties/clear_float-expected.png:
- platform/chromium-mac-lion/css1/box_properties/padding-expected.png:
- platform/chromium-mac-lion/css1/font_properties/font_weight-expected.png:
- platform/chromium-mac-lion/css3/flexbox/flexbox-baseline-expected.png:
- platform/chromium-mac-lion/fast/css/h1-in-section-elements-expected.png:
- platform/chromium-mac-lion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Removed.
- platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug126742-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug69187-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug73321-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug73321-expected.txt: Added.
- platform/chromium-mac-snowleopard/css1/basic/inheritance-expected.png:
- platform/chromium-mac-snowleopard/css1/box_properties/padding-expected.png:
- platform/chromium-mac-snowleopard/css1/color_and_background/background_attachment-expected.png:
- platform/chromium-mac-snowleopard/css1/font_properties/font_weight-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
- platform/chromium-mac-snowleopard/css3/flexbox/flexbox-baseline-expected.png:
- platform/chromium-mac-snowleopard/fast/css/h1-in-section-elements-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Removed.
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug126742-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug69187-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug73321-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug73321-expected.txt: Added.
- platform/chromium-mac/css1/basic/inheritance-expected.txt: Removed.
- platform/chromium-mac/css1/box_properties/clear_float-expected.png:
- platform/chromium-mac/css1/box_properties/clear_float-expected.txt: Removed.
- platform/chromium-mac/css1/box_properties/margin-expected.txt: Removed.
- platform/chromium-mac/css1/box_properties/margin_bottom-expected.txt: Added.
- platform/chromium-mac/css1/box_properties/margin_top-expected.txt: Added.
- platform/chromium-mac/css1/box_properties/padding-expected.png:
- platform/chromium-mac/css1/box_properties/padding-expected.txt: Removed.
- platform/chromium-mac/css1/box_properties/padding_bottom-expected.txt: Added.
- platform/chromium-mac/css1/box_properties/padding_top-expected.txt: Added.
- platform/chromium-mac/css1/color_and_background/background_attachment-expected.txt: Added.
- platform/chromium-mac/css1/font_properties/font_weight-expected.png:
- platform/chromium-mac/css1/font_properties/font_weight-expected.txt: Removed.
- platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.txt:
- platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
- platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.png:
- platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.txt:
- platform/chromium-mac/fast/css-generated-content/015-expected.txt: Removed.
- platform/chromium-mac/fast/css/h1-in-section-elements-expected.png:
- platform/chromium-mac/fast/css/h1-in-section-elements-expected.txt: Removed.
- platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Removed.
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug126742-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug126742-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug69187-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug69187-expected.txt:
- platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.txt: Added.
- platform/chromium-win/css1/basic/inheritance-expected.png:
- platform/chromium-win/css1/box_properties/clear_float-expected.png:
- platform/chromium-win/css1/box_properties/margin_top-expected.png:
- platform/chromium-win/css1/font_properties/font_weight-expected.png:
- platform/chromium-win/css3/flexbox/flexbox-baseline-expected.png:
- platform/chromium-win/fast/css/h1-in-section-elements-expected.png:
- platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
- platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
- platform/chromium-win/tables/mozilla/bugs/bug126742-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug69187-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug73321-expected.png:
- platform/chromium/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Removed.
- platform/chromium/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
- platform/chromium/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
- platform/mac/css1/basic/inheritance-expected.txt: Removed.
- platform/mac/css1/box_properties/clear_float-expected.txt: Removed.
- platform/mac/css1/box_properties/margin-expected.txt: Removed.
- platform/mac/css1/box_properties/padding-expected.txt: Removed.
- platform/mac/css1/font_properties/font_weight-expected.txt: Removed.
- platform/mac/fast/css-generated-content/015-expected.txt: Removed.
- platform/mac/fast/css/h1-in-section-elements-expected.txt: Removed.
- 11:28 AM Changeset in webkit [145250] by
-
- 10 edits7 adds14 deletes in trunk/LayoutTests
Unreviewed apple rebaselines for r145242.
- css1/box_properties/margin_bottom-expected.txt: Added.
- css1/box_properties/margin_top-expected.txt: Added.
- css1/box_properties/padding_bottom-expected.txt: Added.
- css1/box_properties/padding_top-expected.txt: Added.
- css1/color_and_background/background_attachment-expected.txt: Added.
- platform/chromium-mac/css1/box_properties/margin_bottom-expected.txt: Removed.
- platform/chromium-mac/css1/box_properties/margin_top-expected.txt: Removed.
- platform/chromium-mac/css1/box_properties/padding_bottom-expected.txt: Removed.
- platform/chromium-mac/css1/box_properties/padding_top-expected.txt: Removed.
- platform/chromium-mac/css1/color_and_background/background_attachment-expected.txt: Removed.
- platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.txt: Removed.
- platform/chromium/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug73321-expected.txt: Removed.
- platform/mac-lion/css1/box_properties: Removed.
- platform/mac/css1/basic/inheritance-expected.txt:
- platform/mac/css1/box_properties/clear_float-expected.txt:
- platform/mac/css1/box_properties/margin-expected.txt:
- platform/mac/css1/box_properties/margin_bottom-expected.txt: Removed.
- platform/mac/css1/box_properties/margin_top-expected.txt: Removed.
- platform/mac/css1/box_properties/padding-expected.txt:
- platform/mac/css1/box_properties/padding_bottom-expected.txt: Removed.
- platform/mac/css1/box_properties/padding_top-expected.txt: Removed.
- platform/mac/css1/color_and_background/background_attachment-expected.txt: Removed.
- platform/mac/css1/font_properties/font_weight-expected.txt:
- platform/mac/fast/css-generated-content/015-expected.txt:
- platform/mac/fast/css/h1-in-section-elements-expected.txt:
- platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
- platform/mac/tables/mozilla/bugs/bug73321-expected.txt:
- tables/mozilla/bugs/bug73321-expected.txt: Added.
- 11:28 AM WebKitGTK/2.0.x edited by
- (diff)
- 11:26 AM Changeset in webkit [145249] by
-
- 9 edits2 adds3 deletes in releases/WebKitGTK/webkit-2.0
Merge r143604 - [GTK] Move feature overriding to the configure phase
https://bugs.webkit.org/show_bug.cgi?id=110293
Reviewed by Gustavo Noronha Silva.
.:
Rework the feature overrides logic so all feature defines go into a
header rather than the command line. This has a few benefits. Most
notably, we can reuse the header in the gyp build. Another nice result
is that changes to the configuration automatically result in a full
rebuild and Debug and Release builds can have different configurations.
All feature define processing happens now during the configuration phase,
instead of when running autogen.sh. This means that we need to distribute
the feature processing script.
- GNUmakefile.am: Read feature defines from WebKitFeatures.txt when kicking
off a build. Also include generate-feature-defines-files in the distribution.
- Source/autotools/SetupAutoconfHeader.m4: Remove an extra ENABLE_3D_RENDERING
from the autoconf header, as it is already provided by the feature configuration.
- Source/autotools/SetupWebKitFeatures.m4: Added.
- Source/autotools/webkitfeature.m4: Removed. The functionality has been moved
to SetupWebKitFeatures.m4.
- autogen.sh: Remove the call to override-feature-defines.
- configure.ac: Now include SetupWebKitFeatures.
Source/WebCore:
- GNUmakefile.am: No longer include GNUmakefile.features.am. We don't
have to process the result of this file or do any modification of
feature_defines_override, because this variable is gone.
Tools:
- Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary): Rename the feature file to
WebKitFeatureOverrides.txt to better match the other filenames used in
the new feature processing.
- gtk/generate-feature-defines-files: Added. A script which takes as an argument
the default features, overrides them with the contents of WebKitFeatureOverrrides.txt
and writes WebKitFeatures.txt and WebKitFeatures.h.
- gtk/override-feature-defines: Removed.
- 11:15 AM Changeset in webkit [145248] by
-
- 9 edits in trunk/Source/WebCore
AtomicHTMLToken should not be heap allocated or RefCounted
https://bugs.webkit.org/show_bug.cgi?id=111250
Reviewed by Adam Barth.
It was clearly an oversight on our part to ever make AtomicHTMLToken ref-counted.
We don't need the actual "token" saved, just enough of it to recreate a fake token.
This removed many more mallocs than I thought it would, for a nice little speed win.
Before:
median= 450.482999993 ms, stdev= 7.2381436538 ms, min= 436.084999994 ms, max= 464.968999964 ms
After:
median= 436.41600004 ms, stdev= 5.71435647554 ms, min= 427.160999971 ms, max= 446.753000026 ms
- html/parser/AtomicHTMLToken.h:
(AtomicHTMLToken):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::createElementFromSavedToken):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::constructTreeFromHTMLToken):
(WebCore::HTMLDocumentParser::constructTreeFromCompactHTMLToken):
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::isHTMLIntegrationPoint):
- html/parser/HTMLFormattingElementList.cpp:
(WebCore):
(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):
(WebCore::HTMLFormattingElementList::ensureNoahsArkCondition):
- html/parser/HTMLStackItem.h:
(WebCore::HTMLStackItem::create):
(WebCore::HTMLStackItem::localName):
(WebCore::HTMLStackItem::attributes):
(WebCore::HTMLStackItem::getAttributeItem):
(HTMLStackItem):
(WebCore::HTMLStackItem::hasLocalName):
(WebCore::HTMLStackItem::hasTagName):
(WebCore::HTMLStackItem::HTMLStackItem):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::processFakeEndTag):
(WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::defaultForBeforeHead):
(WebCore::HTMLTreeBuilder::defaultForInHead):
(WebCore::HTMLTreeBuilder::defaultForInHeadNoscript):
(WebCore::HTMLTreeBuilder::defaultForAfterHead):
- html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement):
- 10:57 AM Changeset in webkit [145247] by
-
- 6 edits in trunk/Source
Makefile fixes.
- WTF.vcxproj/WTF.make:
- JavaScriptCore.vcxproj/JavaScriptCore.make:
- WebCore.vcxproj/WebCore.make:
- 10:53 AM Changeset in webkit [145246] by
-
- 4 edits in tags/Safari-537.33.1/Source
Versioning.
- 10:49 AM WebKitGTK/2.0.x edited by
- (diff)
- 10:43 AM Changeset in webkit [145245] by
-
- 1 copy in tags/Safari-537.33.1
New Tag.
- 10:42 AM Changeset in webkit [145244] by
-
- 5 edits in trunk/Source/WebKit2
[WK2][GTK] Invalid request returned by webkit_download_get_request if called before download starts
https://bugs.webkit.org/show_bug.cgi?id=111574
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-08
Reviewed by Alexey Proskuryakov.
webkit_download_get_request() creates the WebKitURIRequest object
on demand using the ResourceRequest from the DownloadProxy. The
ResourceRequest of the DownloadProxy is set in
DownloadProxy::didStart(), so if we call
webkit_download_get_request() before didStart we return an invalid
WebKitURIRequest created from a NULL ResourceRequest. This is not
a problem for downloads started in the web process, because we
create the WebKitDownload after DownloadProxy::didStart(). For
downloads started manually with webkit_web_context_download_uri()
we need to create download object with the ResourceRequest passed
to the DownloadProxy.
- UIProcess/API/gtk/WebKitDownload.cpp:
(webkitDownloadCreateForRequest): New helper function for
downloads started manually to created them with a given
ResourceRequest.
- UIProcess/API/gtk/WebKitDownloadPrivate.h:
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextStartDownload): Use
webkitDownloadCreateForRequest().
- UIProcess/API/gtk/tests/TestDownloads.cpp:
(testDownloadLocalFile):
(testDownloadLocalFileError):
(testDownloadRemoteFile):
(testDownloadRemoteFileError):
(testPolicyResponseDownload):
- 10:33 AM Changeset in webkit [145243] by
-
- 2 edits in trunk/LayoutTests
Skip editing/selection/drag-list-item.html on Mac WebKit2 since drag and drop is not supported
in WebKitTestRunner yet.
- platform/mac-wk2/TestExpectations:
- 10:30 AM Changeset in webkit [145242] by
-
- 34 edits2 adds in trunk
[sub-pixel] Rounding error in table cell height calculation causes unnecessary scrollbar
https://bugs.webkit.org/show_bug.cgi?id=111794
Source/WebCore:
Reviewed by Levi Weintraub.
In RenderTableCell::logicalHeightForRowSizing the
adjustedLogicalHeight is calculated from the logicalHeight and
intrinsic padding and is then returned and floored. This can
cause cause the cell to be slightly smaller (0.5px) than the
element it contains.
Test: fast/sub-pixel/table-cell-height.html
- rendering/RenderTableCell.h:
(WebCore::RenderTableCell::logicalHeightForRowSizing):
Change to use pixelSnapped version of logicalHeight method and
change signature to return int as the only caller immediately
down-casts the result to an int.
LayoutTests:
Reviewed by Levi Weintraub.
Add test for zoomed-in table containing block child.
- fast/sub-pixel/table-cell-height-expected.html: Added.
- fast/sub-pixel/table-cell-height.html: Added.
- 10:27 AM Changeset in webkit [145241] by
-
- 3 edits2 adds in trunk
RenderFullScreen needs to clear override sizes when exiting full screen
https://bugs.webkit.org/show_bug.cgi?id=111775
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-08
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fullscreen/full-screen-with-flex-item.html
- rendering/RenderFullScreen.cpp:
(RenderFullScreen::unwrapRenderer):
RenderFullScreen is a flexbox, so it will potentially set override
sizes on its children while in fullscreen mode. When we exit
fullscreen mode, we need to clear this override size, otherwise the
the leftover override size may affect layout. See the testcase for an
example.
LayoutTests:
- fullscreen/full-screen-with-flex-item-expected.txt: Added.
- fullscreen/full-screen-with-flex-item.html: Added.
- 10:26 AM LayoutUnit edited by
- Removed note about FractionalLayoutUnit typedef as it has since been … (diff)
- 10:25 AM Changeset in webkit [145240] by
-
- 7 edits2 adds in trunk
[CSS Grid Layout] Handle 2 positions with one 'auto' properly
https://bugs.webkit.org/show_bug.cgi?id=111653
Reviewed by Tony Chang.
Source/WebCore:
The rendering code was making the assumption that we have one position.
Thus it couldn't fully match what the specification wants as the 2 opposite
positions are required to resolve either position in several cases (e.g.
1 / span 2, auto / 'c').
This change introduces resolveGridPositionsFromStyle to do both opposite
positions resolution in one pass and thus handling more cases.
Test: fast/css-grid-layout/grid-item-spanning-resolution.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::maximumIndexInDirection):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
Updated the above functions to rely on resolveGridPositionsFromStyle.
(WebCore::RenderGrid::resolveGridPositionsFromStyle):
Added this new function that handle the correct resolution.
(WebCore::RenderGrid::resolveGridPositionFromStyle):
Updated the ASSERT to match the new code flow.
- rendering/RenderGrid.h:
(WebCore::RenderGrid::GridSpan::GridSpan):
Introduced this new struct to hold the 2 positions along one axis.
LayoutTests:
- fast/css-grid-layout/grid-auto-flow-resolution-expected.txt:
- fast/css-grid-layout/grid-auto-flow-resolution.html:
- fast/css-grid-layout/grid-item-spanning-resolution-expected.txt: Added.
- fast/css-grid-layout/grid-item-spanning-resolution.html: Added.
Extended and added a new test. Most of the new testing is failing as it
requires other changes to land. This will help us track our progress
towards fully supporting the new syntax and padding.
- fast/css-grid-layout/resources/grid.css:
Added the 2 new classes.
- 10:12 AM Changeset in webkit [145239] by
-
- 3 edits6 adds in trunk
RenderTextControlSingleLine should not assume that its text element has a renderer
https://bugs.webkit.org/show_bug.cgi?id=111826
Reviewed by Ojan Vafai.
Source/WebCore:
Tests: fast/forms/search/search-autoscroll-hidden-decoration-container-crash.html
fast/forms/search/search-hide-decoration-container-crash.html
fast/forms/search/search-scroll-hidden-decoration-container-crash.html
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::controlClipRect):
(WebCore::RenderTextControlSingleLine::autoscroll):
(WebCore::RenderTextControlSingleLine::scroll):
LayoutTests:
- fast/forms/search/search-autoscroll-hidden-decoration-container-crash-expected.txt: Added.
- fast/forms/search/search-autoscroll-hidden-decoration-container-crash.html: Added.
- fast/forms/search/search-hide-decoration-container-crash-expected.txt: Added.
- fast/forms/search/search-hide-decoration-container-crash.html: Added.
- fast/forms/search/search-scroll-hidden-decoration-container-crash-expected.txt: Added.
- fast/forms/search/search-scroll-hidden-decoration-container-crash.html: Added.
- 10:06 AM Changeset in webkit [145238] by
-
- 9 edits in trunk/Source
IndexedDB: Use WeakPtr for Factory-to-BackingStore reference
https://bugs.webkit.org/show_bug.cgi?id=111459
Reviewed by Adam Barth.
Source/WebCore:
IDBFactoryBackendImpl maintains a map of backing stores - if another database in the same
origin is opened, the backing store instance must be re-used). This was a map to raw
pointers so that the backing store can be collected when all database references are
dropped. The map was maintained manually by passing the factory to the IDBBackingStore which
would add/remove itself on creation/destruction.
Replace this with a HashMap<WeakPtr<T>>. This simplifies the plumbing; map entries
"leak" but are purged on subsequent opens.
Added webkit_unit_test (Chromium port) to verify refcounts.
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::IDBBackingStore): No need to notify factory of lifetime.
(WebCore::IDBBackingStore::~IDBBackingStore): Ditto.
(WebCore::IDBBackingStore::open): Ditto.
- Modules/indexeddb/IDBBackingStore.h: No reference to the factory, but...
(WebCore::IDBBackingStore::createWeakPtr): Do need to expose weak pointers for the factory to hold.
- Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::cleanWeakMap): Helper function to scrub a HashMap<WeakPtr<T>> of empty pointers.
May move to WTF when we've learned how general it is, or come up with a dedicated WeakPtrHashMap type.
(WebCore::IDBFactoryBackendImpl::openBackingStore): WeakPtr fu.
- Modules/indexeddb/IDBFactoryBackendImpl.h:
(IDBFactoryBackendImpl): Remove plumbing methods.
Source/WebKit/chromium:
Add new test that verifies refcounts.
- WebKit.gyp: Don't include files depending on webkit_support.
- tests/IDBBackingStoreTest.cpp:
(WebCore::IDBBackingStoreTest::SetUp): No need for dummy factory.
(MockIDBFactoryBackend): Allow access to protected openBackingStore method.
(WebCore::TEST): Add new test that verifies refcounts.
- tests/IDBCleanupOnIOErrorTest.cpp:
(WebCore::TEST): No need for dummy factory.
- 9:42 AM Changeset in webkit [145237] by
-
- 3 edits3 copies in branches/chromium/1410
Merge 144894
Crash during middle mouse click when page is removed
https://bugs.webkit.org/show_bug.cgi?id=111489
Reviewed by Hajime Morrita.
Source/WebCore:
Check for a null page that can happen if we remove the document from the DOM.
The other methods in EventHandler also check for a null page.
Test: editing/pasteboard/selection-paste-crash.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handlePasteGlobalSelection):
LayoutTests:
- editing/pasteboard/resources/selection-paste-crash.html: Added.
- editing/pasteboard/selection-paste-crash-expected.txt: Added.
- editing/pasteboard/selection-paste-crash.html: Added.
TBR=tony@chromium.org
Review URL: https://codereview.chromium.org/12510009
- 9:38 AM Changeset in webkit [145236] by
-
- 4 edits in trunk/Source/WebKit2
<rdar://problem/13363499> Blobs are not cleaned up when WebProcess terminates
https://bugs.webkit.org/show_bug.cgi?id=111803
Reviewed by Brady Eidson.
Track which blobs were created for each connection, and unregister them when
the connection closes.
Normally, this happens when a document is destroyed through PublicURLManager
in WebProcess. But we don't get there when the web process crashes, or is terminated
without waiting for document destruction.
- NetworkProcess/FileAPI/NetworkBlobRegistry.cpp: (WebKit::NetworkBlobRegistry::registerBlobURL): (WebKit::NetworkBlobRegistry::unregisterBlobURL): (WebKit::NetworkBlobRegistry::connectionToWebProcessDidClose):
- NetworkProcess/FileAPI/NetworkBlobRegistry.h:
- NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::didClose): (WebKit::NetworkConnectionToWebProcess::registerBlobURL): (WebKit::NetworkConnectionToWebProcess::registerBlobURLFromURL): (WebKit::NetworkConnectionToWebProcess::unregisterBlobURL):
- 9:35 AM WebKitGTK/2.0.x edited by
- (diff)
- 9:33 AM WebKitGTK/2.0.x edited by
- (diff)
- 9:30 AM Changeset in webkit [145235] by
-
- 3 edits in trunk/Source/WebKit2
Make the WebKit2 Web Inspector use tiled drawing and accelerated drawing.
<rdar://problem/12676223>
Reviewed by David Kilzer.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::createInspectorPageGroup): Call setAcceleratedDrawingEnabled with true on 10.8+.
- UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorWKView _shouldUseTiledDrawingArea]): Added. Return YES on 10.8+.
- 9:29 AM Changeset in webkit [145234] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[GTK][WK2] Fix compilation warning missing-field-initializers in webkit-2.0 stable branch
https://bugs.webkit.org/show_bug.cgi?id=111863
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-08
Reviewed by Martin Robinson.
- UIProcess/API/gtk/WebKitUIClient.cpp:
(attachUIClientToView): Include missing initializer for pluginLoadPolicy.
- 9:19 AM Changeset in webkit [145233] by
-
- 3 edits2 adds in trunk
@media queries do not take zooming into account
https://bugs.webkit.org/show_bug.cgi?id=53186
Patch by John Mellor <johnme@chromium.org> on 2013-03-08
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Fixes @media width and height to take into account full page zoom, by
adding code to MediaQueryEvaluator's width/heightMediaFeatureEval,
corresponding to the existing code in Element::clientWidth which makes
document.documentElement.clientWidth take into account page zoom.
Test: fast/media/mq-width-pagezoom.html
- css/MediaQueryEvaluator.cpp:
(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):
LayoutTests:
- fast/media/mq-width-pagezoom-expected.html: Added.
- fast/media/mq-width-pagezoom.html: Added.
- 9:12 AM Changeset in webkit [145232] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Add stubs for DNSResolveQueue platform specific methods
https://bugs.webkit.org/show_bug.cgi?id=111841
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.
Add empty implementations of
DNSResolveQueue::platformProxyIsEnabledInSystemPreferences() and
DNSResolveQueue::platformResolve() to DNSBlackBerry.cpp to make it
build.
- platform/network/blackberry/DNSBlackBerry.cpp:
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::DNSResolveQueue::platformResolve):
- 8:59 AM Changeset in webkit [145231] by
-
- 7 edits in trunk
[Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
https://bugs.webkit.org/show_bug.cgi?id=111814
Reviewed by Ryosuke Niwa.
Tools:
Add the needed supportedActions() attribute to WKTestRunner.
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::supportedActions):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::supportedActions):
LayoutTests:
- platform/mac-wk2/TestExpectations:
- 8:55 AM WebKitGTK/2.0.x edited by
- Add new change on track (diff)
- 8:33 AM Changeset in webkit [145230] by
-
- 3 edits in trunk/Source/WebKit2
Coordinated Graphics: Handle scrolling correctly.
https://bugs.webkit.org/show_bug.cgi?id=111406
Patch by Huang Dongsung <luxtella@company100.net> on 2013-03-08
Reviewed by Simon Fraser.
Coordinated Graphics deals with fast scrolling and slow scrolling in the same
routine, so WebChromeClient::invalidateContentsForSlowScroll() should call
DrawingArea:scroll().
When CoordinatedLayerTreeHost::scrollNonCompositedContents() is called, we
should call scheduleLayerFlush() to notify to UI Process. In addition, when we
don't use fixed layout, we should call setNonCompositedContentsNeedDisplay() to
update non composited contents.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::invalidateContentsForSlowScroll):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::scrollNonCompositedContents):
- 8:28 AM Changeset in webkit [145229] by
-
- 2 edits in trunk/Source/WebCore
Adding a hook to collect data for a Google UMA histogram to track when
m_needsCompositedScrolling is turned on and off.
https://bugs.webkit.org/show_bug.cgi?id=111725
Reviewed by Julien Chaffraix.
We want to keep track of this information to quantify the effects of a
few patches that will cause us to opt in to composited scrolling.
Specifically, we want to measure the effects of
https://bugs.webkit.org/show_bug.cgi?id=109302,
https://bugs.webkit.org/show_bug.cgi?id=109966,
https://bugs.webkit.org/show_bug.cgi?id=109591, and
https://bugs.webkit.org/show_bug.cgi?id=107618.
We do this by measuring a per-layer boolean value, and comparing the
ratio between number of layers opted in and number of layers that remain
uncomposited. We hope the relative number of layers opting in will
increase after the relevant patches land and are enabled.
Unfortunately implementing extra statistics is impractical at the
moment since most of the actionable relevant data is expensive to
compute. For example, it would be useful to know if the layers that opt
out do so because of invisible or non-overlapping layers that cause a
potential stacking container's children to be discontiguous, because we
would potentially be able to mitigate the problem. However, this would
add considerable overhead to perform overlap testing just to gather
data.
No new tests (no change in behaviour).
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateNeedsCompositedScrolling):
Patch by Glenn Hartmann <hartmanng@chromium.org> on 2013-03-08
- 8:28 AM Changeset in webkit [145228] by
-
- 2 edits2 adds in trunk/LayoutTests
Unreviewed EFL gardening.
Update platform expectations for failing tests after r145024 and r145067.
- platform/efl/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Added.
- platform/efl/fast/forms/datalist/input-list-expected.txt:
- platform/efl/fast/forms/validationMessage-expected.txt: Added.
- 8:06 AM Changeset in webkit [145227] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip failing tests on EFL bots.
- platform/efl/TestExpectations:
- 8:00 AM Changeset in webkit [145226] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] GraphicsContext: rename addRoundedRectClip to clipRoundedRect
https://bugs.webkit.org/show_bug.cgi?id=111852
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.
This changed in r139353.
- platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
(WebCore::GraphicsContext::clipRoundedRect):
- 7:59 AM Changeset in webkit [145225] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Add BlendMode parameter to GraphicsContext::setPlatformCompositeOperation
https://bugs.webkit.org/show_bug.cgi?id=111840
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.
This parameter was added in r137011.
- platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
(WebCore::GraphicsContext::setPlatformCompositeOperation):
- 7:57 AM Changeset in webkit [145224] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Remove unused GraphicsContext::addInnerRoundedRectClip()
https://bugs.webkit.org/show_bug.cgi?id=111838
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.
This was removed in r139138.
- platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
- 7:56 AM Changeset in webkit [145223] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] GraphicsContext: add fillRule parameter to clip() and canvasClip()
https://bugs.webkit.org/show_bug.cgi?id=111836
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.
This parameter was added in r139967.
- platform/graphics/blackberry/PathBlackBerry.cpp:
(WebCore):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
- 7:51 AM Changeset in webkit [145222] by
-
- 3 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening. Unskip now passing compositing tests.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt/TestExpectations:
- platform/qt/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
- 7:39 AM Changeset in webkit [145221] by
-
- 12 edits in trunk
Web Inspector: Get rid of file system ids and use file pathes as uri for file based uiSourceCodes.
https://bugs.webkit.org/show_bug.cgi?id=111753
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/FileSystemMapping.js:
(WebInspector.FileSystemMappingImpl):
(WebInspector.FileSystemMappingImpl.prototype._loadFromSettings.get this):
(WebInspector.FileSystemMappingImpl.prototype._loadFromSettings):
(WebInspector.FileSystemMappingImpl.prototype._saveToSettings):
(WebInspector.FileSystemMappingImpl.prototype.set addFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.removeFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.fileSystemPaths):
(WebInspector.FileSystemMappingImpl.prototype.fileSystemPathForPrefix):
- inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate.projectId):
(WebInspector.FileSystemProjectDelegate.prototype.id):
(WebInspector.FileSystemProjectDelegate.prototype.fileSystemPath):
(WebInspector.FileSystemWorkspaceProvider):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemAdded):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemRemoved):
(WebInspector.FileSystemWorkspaceProvider.prototype.fileSystemPath):
- inspector/front-end/IsolatedFileSystemManager.js:
(WebInspector.IsolatedFileSystemManager.prototype._innerAddFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype._fileSystemRemoved):
- inspector/front-end/Workspace.js:
(WebInspector.Workspace.prototype.uiSourceCodeForURL):
LayoutTests:
- inspector/file-system-mapping-expected.txt:
- inspector/file-system-mapping.html:
- inspector/file-system-project-expected.txt:
- inspector/workspace-mapping-expected.txt:
- inspector/workspace-mapping.html:
- 7:25 AM Changeset in webkit [145220] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Polish TabbedEditorContaner and ScriptsNavigator behavior.
https://bugs.webkit.org/show_bug.cgi?id=111732
Reviewed by Pavel Feldman.
Resources matching inspectedPageURL are always expanded in NavigatorView now.
Snippets tab in scripts navigator is not automatically opened anymore.
Cleared saved TabbedEditorContainer history because it might have been corrupted due to errors in earlier versions.
Snippets are not revealed in TabbedEditorContainer anymore unless they were actually selected by user or there is no other tabs opened.
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView):
(WebInspector.NavigatorView.prototype.addUISourceCode):
(WebInspector.NavigatorView.prototype._inspectedURLChanged):
(WebInspector.NavigatorView.prototype.revealUISourceCode):
(WebInspector.NavigatorView.prototype.removeUISourceCode):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.uiSourceCode):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.reveal):
- inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype.revealUISourceCode):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._showFile):
- inspector/front-end/Settings.js:
(WebInspector.VersionController.prototype._updateVersionFrom1To2):
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype.addUISourceCode.tabId.this._tabIds.get this):
(WebInspector.TabbedEditorContainer.prototype.addUISourceCode):
(WebInspector.TabbedEditorContainer.History.prototype._rebuildItemIndex):
- 7:14 AM Changeset in webkit [145219] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/TestExpectations: Skip test after r145195.
- 7:11 AM Changeset in webkit [145218] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Add shortcut for running a snippet.
https://bugs.webkit.org/show_bug.cgi?id=111680
Reviewed by Pavel Feldman.
Added Ctrl/Cmd+Enter as a shortcut for running a snippet.
- inspector/front-end/SnippetJavaScriptSourceFrame.js:
(WebInspector.SnippetJavaScriptSourceFrame):
(WebInspector.SnippetJavaScriptSourceFrame.prototype._runButtonClicked):
(WebInspector.SnippetJavaScriptSourceFrame.prototype._runSnippet):
(WebInspector.SnippetJavaScriptSourceFrame.prototype._onKeyDown):
- 7:05 AM Changeset in webkit [145217] by
-
- 2 edits in trunk/Tools
[EFL] Memory leak at WKViewClientWebProcessCallbacks API test
https://bugs.webkit.org/show_bug.cgi?id=111851
Reviewed by Kenneth Rohde Christiansen.
- TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
(TestWebKitAPI::TEST):
Fixed WKURLRef instance leaking.
- 6:37 AM Changeset in webkit [145216] by
-
- 3 edits2 adds in trunk
Prevent infinite loop in SVG use cycle detection
https://bugs.webkit.org/show_bug.cgi?id=111822
Reviewed by Stephen Chenney.
Source/WebCore:
SVG use cycle detection depended on idForStyleResolution() which differs from
getIdAttribute() in quirks mode. During use tree cycle detection, this difference
resulted in an infinite loop because idForStyleResolution() used lower-cased id
attributes. This patch removes an existing fixme for this and switches to using
getIdAttribute().
Test: svg/custom/use-cycle-detection.html
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::hasCycleUseReferencing):
LayoutTests:
- svg/custom/use-cycle-detection-expected.html: Added.
- svg/custom/use-cycle-detection.html: Added.
- 6:32 AM Changeset in webkit [145215] by
-
- 3 edits2 adds in trunk
When we set word-wrap: break-word and xml:space="preserve" to svg text element, the text is collapsed.
https://bugs.webkit.org/show_bug.cgi?id=111675
Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2013-03-08
Reviewed by Stephen Chenney.
Source/WebCore:
RenderSVGText define its size when it laid out its first line at SVGRootInlineBox::computePerCharacterLayoutInformation().
In the following spec, SVG don't perform automatic line break or word wrapping.
http://www.w3.org/TR/SVG/text.html#Introduction
SVG performs no automatic line breaking or word wrapping.
However, when we set word-wrap: break-word and xml:space="preserve" to svg text element, RenderBlock::LineBreaker::nextLineBreak() breaks the text.
This make single character lines and make RenderSVGText narrow.
We must ignore word-wrap property to make the text a single line.
We always disable break words and break all in nextLineBreak() when the object is SVGInlineText.
Test: svg/text/preserve-break-word.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak): Disable break words and break all when we process SVG Text.
LayoutTests:
Test combination of xml:space="preserve" and word-wrap: break-word to SVG Text.
These text should not be collapsed.
- svg/text/preserve-break-word-expected.html: Added.
- svg/text/preserve-break-word.html: Added.
- 6:23 AM Changeset in webkit [145214] by
-
- 2 edits in trunk/Source/WebCore
[Qt] HTML5 video - sound volume bar out of widget
https://bugs.webkit.org/show_bug.cgi?id=108213
Reviewed by Jocelyn Turcotte.
Since we use Safari shadow DOM for media controls, follow
the overall layout of Safari media control CSS.
- css/mediaControlsQt.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
(audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
(audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
(audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
(audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
- 6:13 AM Changeset in webkit [145213] by
-
- 4 edits in trunk/Source/WebKit2
[WK2][EFL] Remove EwkView::setImageData()
https://bugs.webkit.org/show_bug.cgi?id=111849
Reviewed by Andreas Kling.
EwkView::setImageData() removed as it is not used at the moment
(it used to be part of eliminated non coord graphics code path).
- UIProcess/API/efl/EwkView.cpp:
- UIProcess/API/efl/EwkView.h:
(EwkView):
- UIProcess/cairo/BackingStoreCairo.cpp:
(WebKit::BackingStore::incorporateUpdate):
- 6:12 AM Changeset in webkit [145212] by
-
- 3 edits1 copy in trunk/LayoutTests
Allow platform-dependent strings for validationMessage property
https://bugs.webkit.org/show_bug.cgi?id=111846
Reviewed by Kentaro Hara.
Do not check matching with fixed strings in validationMessage.html
test. We print validationMessage values in the test instead.
We'd like to change user-visible strings at our own discretion.
- fast/forms/validationMessage-expected.txt:
Note that many platforms don't have a dedicated message for
badInput and uses the same message as typeMismatch for now.
- fast/forms/validationMessage.html:
- platform/chromium/fast/forms/validationMessage-expected.txt:
Chromium has a dedicated one for badInput.
- 5:43 AM Changeset in webkit [145211] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] QWebSettings::clearMemoryCaches should release FastMalloc's free pages to OS
https://bugs.webkit.org/show_bug.cgi?id=111605
Patch by Arunprasad Rajkumar <arunprasadr@nds.com> on 2013-03-08
Reviewed by Jocelyn Turcotte.
- Api/qwebsettings.cpp:
(QWebSettings::clearMemoryCaches):
- 5:24 AM Changeset in webkit [145210] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Doesn't build with QtMultimedia
https://bugs.webkit.org/show_bug.cgi?id=111847
Reviewed by Jocelyn Turcotte.
Fix include.
- platform/graphics/qt/MediaPlayerPrivateQt.h:
- 5:18 AM Changeset in webkit [145209] by
-
- 4 edits1 add in trunk
[EFL] [WK2] Some authentication tests fail in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=106407
Reviewed by Kenneth Rohde Christiansen.
Tools:
Add patch from upstream for libsoup 2.40 to fix several authentication
test cases.
- efl/jhbuild.modules:
- efl/patches/libsoup-2.40-auth-fix.patch: Added.
LayoutTests:
Unskip several authentication test cases now that we cherry-picked
the needed libsoup fix from upstream.
- platform/efl-wk2/TestExpectations:
- 4:12 AM Changeset in webkit [145208] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r145200.
- 3:36 AM May 2013 Meeting edited by
- (diff)
- 3:25 AM Changeset in webkit [145207] by
-
- 4 edits in trunk/Source/WebCore
[EFL][Qt] REGRESSION(r144787): A fixed element lags when scrolling and wheeling.
https://bugs.webkit.org/show_bug.cgi?id=111829
Patch by Huang Dongsung <luxtella@company100.net> on 2013-03-08
Reviewed by Noam Rosenthal.
Currently, flagsChanged deals with all boolean flags. It introduces this bug
because when another flag (i.e. preserves3D) is changed, fixedToViewport is set
to false. So this patch updates all flags when at least one flag is changed.
In addition, this patch amends isScrollable code to match other flags.
This patch can only be tested manually since there is no automated
testing facilities for in-motion touch.
Test: ManualTests/fixed-position.html
ManualTests/nested-fixed-position.html
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setScrollableArea):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::setLayerState):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):
- 3:20 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:19 AM Changeset in webkit [145206] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r144982 - [GTK][WK2] Implement WebInspector::localizedStringsURL() to return the file URL of localizedStrings.js
https://bugs.webkit.org/show_bug.cgi?id=111448
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-06
Reviewed by Alexey Proskuryakov.
Implement WebInspector::localizedStringsURL() method to return the
file URL of the localizedStrings.js.
This prevents printing warnings about "Localized string not found" in
the console.
- WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspector::localizedStringsURL):
- 3:09 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:08 AM Changeset in webkit [145205] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk
Merge r144943 - Link the webkit_tests to XRENDER_LIBS.
This solves the linking failure when building against gtk2 like:
usr/lib/gcc/i586-suse-linux/4.7/../../../../i586-suse-linux/bin/ld:
Source/WebCore/platform/gtk/Programs_unittests_testcopyandpaste-GtkVersioning.o:
undefined reference to symbol 'XFree'
/usr/lib/gcc/i586-suse-linux/4.7/../../../../i586-suse-linux/bin/ld:
note: 'XFree' is defined in DSO /usr/lib/libX11.so.6 so try adding it
to the linker command line
/usr/lib/libX11.so.6: could not read symbols: Invalid operation
https://bugs.webkit.org/show_bug.cgi?id=111572
Patch by Dominique Leuenberger <dimstar@opensuse.org> on 2013-03-06
Reviewed by Gustavo Noronha Silva.
- GNUmakefile.am:
- 3:01 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:00 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:00 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:58 AM Changeset in webkit [145204] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore
Merge r144936 - [soup] session cookies are not correctly reported in getRawCookies()
https://bugs.webkit.org/show_bug.cgi?id=111584
Reviewed by Martin Robinson.
As per libsoup documentation, SoupCookie->expires is NULL for session cookies.
However, the soup implementation for getRawCookies() does not check for NULL
case before passing the value to soup_date_to_time_t(), which leads to run time
warnings.
We should also pass true for WebCore::Cookie's session argument if
SoupCookie->expires is NULL. The current implementation reports the cookie as a
session one if soup_cookie_jar_is_persistent(jar) returns true, which is
inaccurate.
No new tests, no behavior change for layout tests as Web Inspector currently
ignores the "session" member and uses expires/max-age instead to deduce it.
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::getRawCookies):
- 2:55 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:54 AM Changeset in webkit [145203] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0
Merge r144969 - [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
https://bugs.webkit.org/show_bug.cgi?id=82866
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-06
Reviewed by Martin Robinson.
Source/WebKit2:
Test was failing because of new media controls needs more space to be
painted than just 10x10 pixels. This is similar to r144070.
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewMouseTarget): Modified HTML in order to give more space to the media controls.
Tools:
- Scripts/run-gtk-tests:
(TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
it is passing now.
- 2:40 AM Changeset in webkit [145202] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Memory leak in webkit_web_view_load_request() in WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=111160
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-08
Reviewed by Benjamin Poulain.
leakRef() is used for the returned PassRefPtr without taking the
ownership of the leaked ref.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_load_request): Use RefPtr local variable.
- 2:29 AM Changeset in webkit [145201] by
-
- 2 edits in trunk
[Autotools] Remove definitions of unnecessary Automake conditionals
https://bugs.webkit.org/show_bug.cgi?id=111830
Reviewed by Philippe Normand.
The following Automake conditionals are not used anywhere and should have their
definitions in SetupAutomake.m4 removed:
ENABLE_GAMEPAD, ENABLE_XSLT, ENABLE_GEOLOCATION, ENABLE_SVG_FONTS,
ENABLE_OPCODE_STATS, ENABLE_CSS_FILTERS, ENABLE_CSS_SHADERS.
- Source/autotools/SetupAutomake.m4:
- 2:08 AM Changeset in webkit [145200] by
-
- 2 edits in trunk/Tools
[GTK] Enable Web Audio in development builds
https://bugs.webkit.org/show_bug.cgi?id=111831
Reviewed by Philippe Normand.
Web Audio is already quite well supported on the GTK port but still has a few issues
that must be addressed before it is enabled by default. Despite that it should be enabled
in development builds just so we are up-to-date with future feature infrastructure changes.
The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
that's an obvious goal before enabling the feature in release builds.
- Scripts/webkitperl/FeatureList.pm:
- 2:06 AM Changeset in webkit [145199] by
-
- 5 edits in trunk
[GTK] Remove media stream support from the configuration options
https://bugs.webkit.org/show_bug.cgi?id=111813
Reviewed by Philippe Normand.
Remove the media-stream configuration flag. The feature is incomplete and
thus unsupported, so it really shouldn't be possible to enable it.
- Source/autotools/PrintBuildConfiguration.m4:
- Source/autotools/ReadCommandLineArguments.m4:
- Source/autotools/SetupAutomake.m4:
- Source/autotools/SetupWebKitFeatures.m4:
- 2:04 AM Changeset in webkit [145198] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Skipping the tests in inspector-protocol/layers as they rely on compositing support
which is not available on the GTK builders.
Adding failure expectations for tests that regressed with r145100.
- platform/gtk/TestExpectations:
- 2:01 AM Changeset in webkit [145197] by
-
- 3 edits in trunk/Source/WebCore
Remove dead label code in snapshotted plugin
https://bugs.webkit.org/show_bug.cgi?id=111781
Reviewed by Tim Horton.
Since ports can use the shadow tree to do label display,
there is no need for the hardcoded timers in RenderSnapshottedPlugin.
- rendering/RenderSnapshottedPlugIn.cpp: Remove label flags and timers.
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):
(WebCore::RenderSnapshottedPlugIn::~RenderSnapshottedPlugIn):
(WebCore::RenderSnapshottedPlugIn::updateSnapshot):
(WebCore::RenderSnapshottedPlugIn::handleEvent):
- rendering/RenderSnapshottedPlugIn.h:
(RenderSnapshottedPlugIn):
Conflicts:
Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp
- 2:01 AM Changeset in webkit [145196] by
-
- 13 edits2 adds in trunk
Implement a custom appearance for the snapshotted plugin background
https://bugs.webkit.org/show_bug.cgi?id=108368
Reviewed by NOBODY (OOPS!).
Source/WebCore:
After https://bugs.webkit.org/show_bug.cgi?id=108284 (r142507), a
snapshotted plugin was no longer drawing the background of the
label blurred. Since the snapshot content was now a shadow tree,
it wasn't feasible to pre-blur a region of the snapshot: the label
could be any size and in any location, with ports being able to
override the appearance through their UA style sheet.
Instead we now use one of the elements in the tree, the snapshot-overlay,
as a hook where ports can add any effect they want. This could be simply
a border, or a transparent mask, or even a CSS filter. We introduce a custom
CSS appearance "snapshotted-plugin-overlay", which could be added to the
element in the injected UA stylesheet. This calls into RenderTheme in
the same way that custom controls do.
Meanwhile, in RenderThemeMac, we implement the appearance by drawing the
content of the plugin snapshot into the background of the element. That
way we can add effects in CSS.
Test: plugins/snapshot-appearance.html
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Handle SnapshottedPluginOverlayPart.
- css/CSSValueKeywords.in: New appearance value snapshotted-plugin-overlay.
- platform/ThemeTypes.h: New value SnapshottedPluginOverlayPart.
- html/HTMLPlugInElement.h:
(WebCore::toHTMLPlugInElement): Add safer casting helpers.
- html/HTMLPlugInImageElement.h:
(WebCore::toHTMLPlugInImageElement): Ditto.
- rendering/RenderSnapshottedPlugIn.cpp: Remove the code for handling
the blur directly in the renderer.
(WebCore::RenderSnapshottedPlugIn::paint): Simplify the paint logic since we're
no longer trying to blur here.
(WebCore::RenderSnapshottedPlugIn::paintSnapshot): Ditto.
- rendering/RenderSnapshottedPlugIn.h: Remove the methods that were trying
to blur the image directly.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint): Call paintSnapshottedPluginOverlay.
- rendering/RenderTheme.h:
(WebCore::RenderTheme::paintSnapshottedPluginOverlay): New virtual method with default implementation.
- rendering/RenderThemeMacShared.h:
(RenderThemeMacShared): Override paintSnapshottedPluginOverlay.
- rendering/RenderThemeMacShared.mm:
(WebCore::RenderThemeMacShared::paintSnapshottedPluginOverlay): Implement a custom render path
that takes the snapshot image from the node's parent, and draws it into the background.
Along the way make sure we're actually using the right type of element (an HTMLPlugInImageElement).
LayoutTests:
Toggles our new snapshotted-plugin-overlay appearance, to make sure it
isn't getting applied to non-plugins.
- plugins/snapshot-appearance-expected.html: Added.
- plugins/snapshot-appearance.html: Added.
- 1:58 AM Changeset in webkit [145195] by
-
- 5 edits2 adds in trunk
Improve drag&drop of list items in contentEditable divs
https://bugs.webkit.org/show_bug.cgi?id=111556
Reviewed by Ryosuke Niwa.
Source/WebCore:
A single fully selected <li> should generate the same markup as if
we were selecting some of them, i.e., we should preserve the list
structure and appearance.
Test: editing/selection/drag-list-item.html
- editing/htmlediting.cpp:
(WebCore::isListItem): modified constness.
- editing/htmlediting.h:
(WebCore): ditto.
- editing/markup.cpp:
(WebCore::highestAncestorToWrapMarkup):
LayoutTests:
Added a new test case. The test performs 2 drag&drops, first of
all a selection of a single list item, and secondly a selection of
two list items. It checks that both behave the same way, i.e, the
whole <li> is moved and not only the text.
- editing/selection/drag-list-item-expected.txt: Added.
- editing/selection/drag-list-item.html: Added.
- 1:44 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:27 AM Changeset in webkit [145194] by
-
- 4 edits in trunk/Source
Cache flush problem on ARMv7 JSC
https://bugs.webkit.org/show_bug.cgi?id=111441
Reviewed by Zoltan Herczeg.
Not proper cache flush causing random crashes on ARMv7 Linux with V8 tests.
The problem is similar to https://bugs.webkit.org/show_bug.cgi?id=77712.
Change the cache fulsh mechanism similar to ARM traditinal and revert the
temporary fix.
Source/JavaScriptCore:
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::cacheFlush):
Source/WTF:
- wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::decommit):
- 1:21 AM Changeset in webkit [145193] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] LayerTiler: rename currentFrameHasAlpha as currentFrameKnownToBeOpaque
https://bugs.webkit.org/show_bug.cgi?id=111828
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-08
Reviewed by Carlos Garcia Campos.
This changed in r141637.
- platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
- 1:17 AM Changeset in webkit [145192] by
-
- 2 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening.
- 12:56 AM Changeset in webkit [145191] by
-
- 2 edits in trunk/Source/WebCore
Fix a couple of typos, unreviewed.
- 12:29 AM Changeset in webkit [145190] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Use OwnPtr for CredentialBackingStore members
https://bugs.webkit.org/show_bug.cgi?id=111737
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.
It simplifies the code a bit.
- platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::CredentialBackingStore::~CredentialBackingStore):
(WebCore::CredentialBackingStore::open):
(WebCore::CredentialBackingStore::certMgrWrapper):
- platform/network/blackberry/CredentialBackingStore.h:
(CredentialBackingStore):
- 12:00 AM Changeset in webkit [145189] by
-
- 2 edits in trunk/Tools
[chromium] delay clearing the TestRunners until the main view was deleted
https://bugs.webkit.org/show_bug.cgi?id=111823
Reviewed by Eric Seidel.
During WebViewHost::shutdown, we navigate the WebView to about:blank.
This may call into the test runners which assume that the delegate is
always non-NULL.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::~TestShell):
Mar 7, 2013:
- 11:57 PM Changeset in webkit [145188] by
-
- 2 edits in trunk/Source/WebCore
MemoryPressureHandler should fully flush the WebCore & NS URL caches
https://bugs.webkit.org/show_bug.cgi?id=111827
Rubber Stamped by Geoff Garen
When the handler is fired we should free as much memory as possible.
- platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::releaseMemory):
- fully flush the WebCore & NS URL caches
- 11:55 PM Changeset in webkit [145187] by
-
- 3 edits in trunk/Tools
Sheriffbot whois command can't search by full name
https://bugs.webkit.org/show_bug.cgi?id=111825
Patch by Alan Cutter <alancutter@chromium.org> on 2013-03-07
Reviewed by Eric Seidel.
Allowed multiple arguments to Sheriffbot's whois command.
Updated test expectations.
- Scripts/webkitpy/tool/bot/irc_command.py:
(Whois.execute):
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_whois):
- 11:52 PM WebKitGTK/2.0.x edited by
- (diff)
- 11:46 PM WebKitGTK/2.0.x edited by
- (diff)
- 11:41 PM WebKitGTK/2.0.x edited by
- (diff)
- 11:37 PM Changeset in webkit [145186] by
-
- 58 edits1 copy3 adds2 deletes in trunk
Update calendar picker UI
https://bugs.webkit.org/show_bug.cgi?id=109439
Reviewed by Kent Tamura.
.:
- ManualTests/forms/calendar-picker.html: New test file with more options.
- ManualTests/forms/date-suggestion-picker.html: Copied from ManualTests/forms/calendar-picker.html. Old one kept for dat/time suggestion picker testing.
Source/WebCore:
This patch changes the calendar picker UI.
Added tests to existing calendar picker tests.
Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup.html
- Resources/pagepopups/calendarPicker.css:
(body):
(.rtl):
(.scroll-view):
(.scroll-view-content):
(.list-cell):
(.list-cell.hidden):
(.day-cell):
(.week-number-cell):
(.day-cell.today):
(.day-cell.highlighted):
(.day-cell.highlighted.disabled):
(.day-cell.selected):
(.day-cell.disabled):
(.day-cell.current-month):
(.calendar-table-view):
(.preparing .calendar-table-view:focus):
(.week-day-label):
(.week-number-label):
(.calendar-table-header-view):
(.calendar-picker):
(.calendar-header-view):
(.calendar-title):
(.rtl .calendar-title):
(.month-popup-button:disabled):
(.month-popup-button):
(.month-popup-button .disclosure-triangle):
(.month-popup-button .disclosure-triangle svg):
(.today-button::after):
(.calendar-navigation-button):
(.year-list-view):
(.year-list-cell):
(.year-list-cell .label):
(.year-list-cell .month-chooser):
(.month-buttons-row):
(.month-button):
(.month-button.highlighted):
(.scrubby-scroll-bar):
(.scrubby-scroll-thumb):
(.month-popup-view):
(.year-list-view .scrubby-scroll-bar):
(.rtl .year-list-view .scrubby-scroll-bar):
- Resources/pagepopups/calendarPicker.js:
(setGlobalParams): Sets the global params.
(initialize):
(openCalendarPicker):
(CalendarHeaderView.prototype.onNavigationButtonClick): Fix typo.
(CalendarPicker):
(CalendarPicker.prototype.onWindowResize): We want to have the "preparing" class applied
to cancel css transitions while setting up the calendar picker so we can avoid flaky pixel tests.
(CalendarPicker.prototype.onYearListViewDidHide): The user clicked on a month so hide the month popup.
(CalendarPicker.prototype.onYearListViewDidSelectMonth): Change the current month in response to the month popup.
(CalendarPicker.prototype.attachTo): We want the calendar table focused when the calendar picker first opens.
(CalendarPicker.prototype.cleanup): Clean up any event listeners or elements attached to nodes outside of this.element.
(CalendarPicker.prototype.onMonthPopupButtonClick): Open the month popup in response to the month popup button being clicked.
(CalendarPicker.prototype._setConfig): Configures the calendar picker.
(CalendarPicker.prototype.currentMonth): The currently shown month.
(CalendarPicker.prototype.setCurrentMonth): Scrolls the calendar table to the given month. Use the navigation behavior param to specify if you want a transition animation.
(CalendarPicker.prototype.adjustHeight): Adjusts the height so its just tall enough to fit the current month. If the month picker is open, fit that.
(CalendarPicker.prototype.selection): Currently selected date range.
(CalendarPicker.prototype.highlight): Currently highlighted date range.
(CalendarPicker.prototype.firstVisibleDay): Returns the first visible day ignoring scroll animation (i.e. this is the first visible day when the scroll animation is done).
(CalendarPicker.prototype.lastVisibleDay): Returns the last visible day ignoring scroll animation.
(CalendarPicker.prototype.selectRangeContainingDay): Sets the selection to the date range containing the given day.
(CalendarPicker.prototype.highlightRangeContainingDay): Sets the highlight to the date range containing the given day.
(CalendarPicker.prototype.setSelection): Sets the selection to the given date range.
(CalendarPicker.prototype._setHighlight): Sets the highlight to the given date range.
(CalendarPicker.prototype._stepMismatch): Just moving.
(CalendarPicker.prototype._outOfRange): Ditto.
(CalendarPicker.prototype.isValid): Returns true if the given date range is a valid selection.
(CalendarPicker.prototype.isValidDay): Returns true if the day is part of a valid selection.
(CalendarPicker.prototype._moveHighlight): Moves the highlight to the given date range if possible. Returns true if it succeeds.
(CalendarPicker.prototype.onCalendarTableKeyDown): Handles the arrow keys, etc.
(CalendarPicker.prototype.width):
(CalendarPicker.prototype.height):
(CalendarPicker.prototype.setHeight):
(CalendarPicker.prototype.onBodyKeyDown): Handles esc/m/y/d.
- Resources/pagepopups/chromium/calendarPickerChromium.css:
(.calendar-table-view:focus):
(.preparing .calendar-table-view:focus):
Source/WebKit/chromium:
- src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument): Adding shortMonthLabels property.
LayoutTests:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt: Removed.
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt: Removed.
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations-expected.txt:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-key-operations-expected.txt:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-key-operations-expected.txt:
- platform/chromium/TestExpectations:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-datetimelocal-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-datetimelocal.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-pre-100-year-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-pre-100-year.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-with-step-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-with-step.html:
- platform/chromium/fast/forms/calendar-picker/date-picker-events-expected.txt:
- platform/chromium/fast/forms/calendar-picker/date-picker-events.html:
- platform/chromium/fast/forms/calendar-picker/datetimelocal-picker-events-expected.txt:
- platform/chromium/fast/forms/calendar-picker/datetimelocal-picker-events.html:
- platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html:
- platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations.html:
- platform/chromium/fast/forms/calendar-picker/month-picker-with-step-expected.txt:
- platform/chromium/fast/forms/calendar-picker/month-picker-with-step.html:
- platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:
(currentMonth):
(highlightedValue):
(selectedValue):
(skipAnimation):
(hoverOverDayCellAt):
(clickDayCellAt):
- platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html:
- platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations.html:
- platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html:
- platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-key-operations.html:
- platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-key-operations.html:
- 11:30 PM Changeset in webkit [145185] by
-
- 3 edits in trunk/Source/WebKit2
[EFL] EwkView should keep css position instead of scroll position in device pixel.
https://bugs.webkit.org/show_bug.cgi?id=110847
Patch by Huang Dongsung <luxtella@company100.net> on 2013-03-07
Reviewed by Kenneth Rohde Christiansen.
Signed off for WebKit2 by Benjamin Poulain.
There are bugs that some code expect that EwkView::pagePosition() returns css
position while others expect that it returns scroll position in device pixel.
In addition, some code call EwkView::setPagePosition() with css position while
others call it with scroll position in device pixel.
This patch makes all code use setPagePosition() and pagePosition() with
UI pixels (a.k.a Density Independent Pixel).
- UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::setViewportPosition):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::paintToCairoSurface):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::transformToScene):
(WebKit::WebView::pageDidRequestScroll):
- 11:17 PM Changeset in webkit [145184] by
-
- 10 edits in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=111801
https://bugs.webkit.org/show_bug.cgi?id=111801
Reviewed by Geoff Garen.
Move unnecessary includes out of headers.
- NetworkProcess/HostRecord.h:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
- NetworkProcess/NetworkProcess.cpp:
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
- NetworkProcess/NetworkResourceLoadScheduler.h:
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/SchedulableLoader.cpp:
- NetworkProcess/SchedulableLoader.h:
- NetworkProcess/SyncNetworkResourceLoader.cpp:
- 11:10 PM Changeset in webkit [145183] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Remove unused return value after r122962
https://bugs.webkit.org/show_bug.cgi?id=111821
Patch by Seokju Kwon <Seokju Kwon> on 2013-03-07
Reviewed by Pavel Feldman.
No new tests.
- inspector/front-end/ConsolePanel.js:
(WebInspector.ConsolePanel.prototype.jumpToPreviousSearchResult):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):
- 11:02 PM Changeset in webkit [145182] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: compositing/rtl/rtl-iframe-absolute-overflow.html
- 10:29 PM Changeset in webkit [145181] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: fast/js/exception-sequencing-binops2.html
- 9:51 PM Changeset in webkit [145180] by
-
- 8 edits in trunk/Source
Unreviewed, rolling out r145166.
http://trac.webkit.org/changeset/145166
https://bugs.webkit.org/show_bug.cgi?id=111819
build break - no symbol
webkit_support::CreateScopedTempDirectory() (Requested by
hayato on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-07
Source/WebCore:
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::IDBBackingStore):
(WebCore::IDBBackingStore::~IDBBackingStore):
(WebCore::IDBBackingStore::open):
- Modules/indexeddb/IDBBackingStore.h:
(WebCore):
(IDBBackingStore):
- Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::addIDBBackingStore):
(WebCore):
(WebCore::IDBFactoryBackendImpl::removeIDBBackingStore):
(WebCore::IDBFactoryBackendImpl::openBackingStore):
- Modules/indexeddb/IDBFactoryBackendImpl.h:
(IDBFactoryBackendImpl):
Source/WebKit/chromium:
- tests/IDBBackingStoreTest.cpp:
(WebCore::IDBBackingStoreTest::SetUp):
(IDBBackingStoreTest):
- tests/IDBCleanupOnIOErrorTest.cpp:
(WebCore::TEST):
- 9:49 PM Changeset in webkit [145179] by
-
- 6 edits1 delete in trunk/Source
Source/ThirdParty: Replace Mersenne Twister RNG with a simple but fast RNG
https://bugs.webkit.org/show_bug.cgi?id=111533
Patch by Andrew Bortz <andrew@abortz.net> on 2013-03-07
Reviewed by Adam Barth.
This code is no longer used.
- mt19937ar.c: Removed.
Source/WTF: Replace Mersenne Twister random number generator with a simpler one.
https://bugs.webkit.org/show_bug.cgi?id=111533
Patch by Andrew Bortz <andrew@abortz.net> on 2013-03-07
Reviewed by Adam Barth.
The new generator is only a single line long, but passes all the Diehard
statistical tests and runs ~3x faster than the Mersenne Twister, with a
guaranteed cycle length of 264 and only 8 bytes of state.
- wtf/Platform.h: Mersenne Twister defines are no longer needed
- wtf/RandomNumber.cpp:
(WTF::Internal::initializeRandomNumber): State initialization
(WTF::Internal::randomNumber): Actual implementation
(WTF::randomNumber): We don't need to fall back on rand()-based generator anymore,
so this code is greatly simplified.
- wtf/RandomNumber.h:
- wtf/RandomNumberSeed.h:
(WTF::initializeRandomNumberGenerator): This code is no longer needed.
Additionally, the code had an error, since rand() returns 32-bits, so each
initializationBuffer's upper 16-bits has more bits set than random.
- 8:48 PM Changeset in webkit [145178] by
-
- 2 edits in trunk/LayoutTests
Add Mac WebKit2 test expectations per bugs 111814 and 111815.
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2013-03-07
- platform/mac-wk2/TestExpectations:
- 8:31 PM Changeset in webkit [145177] by
-
- 2 edits in trunk/LayoutTests
Add Mac WebKit2 test expectations per bugs 111814 and 111815.
- platform/mac-wk2/TestExpectations:
- 8:29 PM Changeset in webkit [145176] by
-
- 2 edits in trunk/Tools
Add Nils Barth and Koji Hara to committers.py
https://bugs.webkit.org/show_bug.cgi?id=111806
Patch by Nils Barth <nbarth@chromium.org> on 2013-03-07
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/config/committers.py:
- 8:25 PM Changeset in webkit [145175] by
-
- 5 edits in trunk
Custom Elements: CustomElement constructor shouldn't share function instance
https://bugs.webkit.org/show_bug.cgi?id=111807
Reviewed by Kentaro Hara.
Source/WebCore:
Adaptor functions of custom elements unintentionally share the instance.
This fix gives new one for each.
Test: Updated fast/dom/custom/document-register-basic.html
- bindings/v8/V8AdaptorFunction.cpp:
(WebCore::V8AdaptorFunction::wrap):
LayoutTests:
- fast/dom/custom/document-register-basic-expected.txt:
- fast/dom/custom/document-register-basic.html:
- 8:24 PM Changeset in webkit [145174] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/win/TestExpectations: Remove duplication of svg/custom/foreign-object-skew.svg.
- 8:11 PM Changeset in webkit [145173] by
-
- 5 edits in trunk/Tools
run-pert-tests should have a --test-runner-count option
https://bugs.webkit.org/show_bug.cgi?id=111726
Reviewed by Ryosuke Niwa.
Add --test-runner-count option to run-perf-tests, with default value of 4.
This option allows command line configuration of the number of times to invoke
the test runner (serially, not in parallel) when running a specific test in
a test set.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
(PerfTest.init): Rename process_run_count to test_runner_count (throughout).
(PerfTest.run): Rename process_run_count to test_runner_count.
(SingleProcessPerfTest.init): Add test_runner_count optional argument.
(ChromiumStylePerfTest.init): Add test_runner_count optional argument.
(ReplayPerfTest.init): Add test_runner_count optional argument.
(PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args): Add '--test-runner-count' option.
(PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
- Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
(MainTest._test_run_with_json_output): Add optional compare_logs argument.
(MainTest.test_run_with_repeat):
(MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.test_default_args): Add test for default option argument values.
(MainTest.test_parse_args): Add test for test-runner-count option parsing.
- 7:52 PM Changeset in webkit [145172] by
-
- 6 edits in trunk
Reading border radius from style property returns in wrong order.
https://bugs.webkit.org/show_bug.cgi?id=110853
Source/WebCore:
Patch by Jared Wyles <wyles@adobe.com> on 2013-03-07
Reviewed by Ryosuke Niwa
Updating the order of border-radius to return in the order specified
in http://www.w3.org/TR/css3-background/#the-border-radius
Tests updated in LayoutTests/fast/borders/border-radius-parsing.html
Changed the expectations in LayoutTests/inspector/elements/elements-panel-styles-expected.txt
Compat information -
jQuery's css function favours using getComputedStyle for elements so that should not be impacted.
Zepto does check for the element on style first so may be a slight concern there.
- css/StylePropertyShorthand.cpp:
(WebCore::borderRadiusShorthand):
LayoutTests:
Patch by Jared Wyles <wyles@adobe.com> on 2013-03-07
Reviewed by Ryosuke Niwa
- fast/borders/border-radius-parsing-expected.txt:
- fast/borders/border-radius-parsing.html:
- inspector/elements/elements-panel-styles-expected.txt:
- 7:01 PM Changeset in webkit [145171] by
-
- 3 edits in trunk/Source/JavaScriptCore
REGRESSION (r143759): 40% JSBench regression, 20% Octane/closure regression, 40% Octane/jquery regression, 2% Octane regression
https://bugs.webkit.org/show_bug.cgi?id=111797
Reviewed by Oliver Hunt.
The bot's testing configuration stresses the cache's starting guess
of 1MB.
This patch removes any starting guess, and just uses wall clock time
to discover the initial working set size of an app, in code size.
- runtime/CodeCache.cpp:
(JSC::CodeCacheMap::pruneSlowCase): Update our timer as we go.
Also fixed a bug where pruning from 0 to 0 would hang -- that case is
a possibility now that we start with a capacity of 0.
- runtime/CodeCache.h:
(CodeCacheMap):
(JSC::CodeCacheMap::CodeCacheMap):
(JSC::CodeCacheMap::add):
(JSC::CodeCacheMap::prune): Don't prune if we're in the middle of
discovering the working set size of an app, in code size.
- 6:29 PM Changeset in webkit [145170] by
-
- 4 edits in trunk/Source/WebKit/mac
Add didFocusTextField:inFrame to WebFormDelegate
https://bugs.webkit.org/show_bug.cgi?id=111804
Reviewed by Dan Bernstein.
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::focusedNodeChanged):
- WebView/WebFormDelegate.h:
- WebView/WebFormDelegate.m:
(-[WebFormDelegate didFocusTextField:inFrame:]):
- 6:24 PM Changeset in webkit [145169] by
-
- 13 edits in trunk/Source
Resizing Cappuccino is very laggy on WebKit since Safari 5.1
<http://webkit.org/b/71354>
<rdar://problem/10565998>
Reviewed by Anders Carlsson.
Source/WebCore:
- WebCore.exp.in: Export FloatPoint(const NSPoint&)
Source/WebKit2:
On Mac, we already cache the window rect through the WindowAndViewFramesChanged
message, so simply return that in WebChromeClient::windowRect() instead of
sending a synchronous query to the UIProcess.
If a programmatic resize is requested, we bypass the cache until we've received
a new WindowAndViewFramesChanged message. This compromise allows us to return
cached rects in the common case, and handles creating a new window and immediately
resizing it gracefully.
Changed WindowAndViewFramesChanged to pass FloatRect/FloatPoint rather than
IntRect/IntPoint to match the ChromeClient::windowRect() return type.
- UIProcess/API/mac/WKView.mm:
(-[WKView _updateWindowAndViewFrames]):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::windowAndViewFramesChanged):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::windowAndViewFramesChanged):
- WebProcess/Plugins/PluginView.h:
(PluginView):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::setWindowRect):
(WebKit::WebChromeClient::windowRect):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::sendSetWindowFrame):
(WebKit::WebPage::windowAndViewFramesChanged):
- WebProcess/WebPage/WebPage.h:
(WebPage):
(WebKit::WebPage::windowFrameInScreenCoordinates):
(WebKit::WebPage::viewFrameInWindowCoordinates):
(WebKit::WebPage::hasCachedWindowFrame):
(WebKit::WebPage::accessibilityPosition):
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):
- 6:08 PM Changeset in webkit [145168] by
-
- 27 edits8 deletes in trunk
Remove desktop version of -webkit-text-size-adjust property.
<http://webkit.org/b/56543>
<rdar://problem/9150203>
Reviewed by Simon Fraser.
Source/WebCore:
This property existed to support a number of Apple-internal clients of WebKit.
We no longer need this property, and since it's clashing with a mobile version of the
same property with different meaning, let's remove it altogether from the desktop build.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLengthDouble):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/StyleBuilder.cpp:
(WebCore::ApplyPropertyLineHeight::applyValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::updateFont):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyProperty):
- css/StyleResolver.h:
(StyleResolver):
- css/svg.css:
- editing/EditingStyle.cpp:
- inspector/front-end/inspector.css:
(#console-messages):
- inspector/front-end/resourcesPanel.css:
(.storage-view.query):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):
LayoutTests:
- editing/pasteboard/5078739.html:
- editing/pasteboard/data-transfer-items-expected.txt:
- editing/pasteboard/onpaste-text-html-expected.txt:
- fast/css/font-size-nan.svg:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/css/getComputedStyle/resources/property-names.js:
- fast/css/ignore-text-zoom.html: Removed.
- fast/css/text-rendering-priority.html:
- fast/events/ondrop-text-html-expected.txt:
- platform/chromium-linux/fast/css/ignore-text-zoom-expected.png: Removed.
- platform/chromium-mac-lion/fast/css/ignore-text-zoom-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/css/ignore-text-zoom-expected.png: Removed.
- platform/chromium-mac/fast/css/ignore-text-zoom-expected.png: Removed.
- platform/chromium-win/fast/css/ignore-text-zoom-expected.png: Removed.
- platform/chromium-win/fast/css/ignore-text-zoom-expected.txt: Removed.
- platform/chromium/fast/css/ignore-text-zoom-expected.txt: Removed.
- platform/efl/fast/css/ignore-text-zoom-expected.png: Removed.
- platform/efl/fast/css/ignore-text-zoom-expected.txt: Removed.
- platform/gtk/fast/css/ignore-text-zoom-expected.png: Removed.
- platform/gtk/fast/css/ignore-text-zoom-expected.txt: Removed.
- platform/mac/fast/css/ignore-text-zoom-expected.png: Removed.
- platform/mac/fast/css/ignore-text-zoom-expected.txt: Removed.
- platform/qt/fast/css/ignore-text-zoom-expected.png: Removed.
- platform/qt/fast/css/ignore-text-zoom-expected.txt: Removed.
- 5:47 PM Changeset in webkit [145167] by
-
- 2 edits in trunk/Source/WebKit2
Don't try to create a sandbox extension when path is empty
https://bugs.webkit.org/show_bug.cgi?id=111788
Reviewed by Anders Carlsson.
- Shared/FileAPI/BlobRegistrationData.cpp:
(WebKit::BlobRegistrationData::BlobRegistrationData): Skip File objects with empty
paths to avoid logging an error to console.
- 5:42 PM Changeset in webkit [145166] by
-
- 8 edits in trunk/Source
IndexedDB: Use WeakPtr for Factory-to-BackingStore reference
https://bugs.webkit.org/show_bug.cgi?id=111459
Reviewed by Adam Barth.
Source/WebCore:
IDBFactoryBackendImpl maintains a map of backing stores - if another database in the same
origin is opened, the backing store instance must be re-used). This was a map to raw
pointers so that the backing store can be collected when all database references are
dropped. The map was maintained manually by passing the factory to the IDBBackingStore which
would add/remove itself on creation/destruction.
Replace this with a HashMap<WeakPtr<>>. This simplifies the plumbing; map entries
"leak" but are purged on subsequent opens.
Added webkit_unit_test (Chromium port) to verify refcounts.
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::IDBBackingStore): No need to notify factory of lifetime.
(WebCore::IDBBackingStore::~IDBBackingStore): Ditto.
(WebCore::IDBBackingStore::open): Ditto.
- Modules/indexeddb/IDBBackingStore.h: No reference to the factory, but...
(WebCore::IDBBackingStore::createWeakPtr): Do need to expose weak pointers for the factory to hold.
- Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::cleanWeakMap): Helper function to scrub a HashMap<WeakPtr<T>> of empty pointers.
May move to WTF when we've learned how general it is, or come up with a dedicated WeakPtrHashMap type.
(WebCore::IDBFactoryBackendImpl::openBackingStore): WeakPtr fu.
- Modules/indexeddb/IDBFactoryBackendImpl.h:
(IDBFactoryBackendImpl): Remove plumbing methods.
Source/WebKit/chromium:
Added tests to verify refcounts on backing stores, update method signatures.
- tests/IDBBackingStoreTest.cpp:
(WebCore::IDBBackingStoreTest::SetUp): No dummy factory needed.
(MockIDBFactoryBackend): Expose protected method to tests.
(WebCore::TEST): Added BackingStoreLifetime test.
- tests/IDBCleanupOnIOErrorTest.cpp: No dummy factory needed.
- 5:36 PM Changeset in webkit [145165] by
-
- 2 edits in trunk/LayoutTests
Fix commented out code in LayoutTests/http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html
https://bugs.webkit.org/show_bug.cgi?id=111800
Unreviewed.
- http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html:
- 5:31 PM Changeset in webkit [145164] by
-
- 5 edits in trunk/Source/WebKit2
WebPageProxy::exceededDatabaseQuota() needs to be serialized.
https://bugs.webkit.org/show_bug.cgi?id=111631.
Reviewed by Geoffrey Garen.
Previously, WebPageProxy::exceededDatabaseQuota() is called synchronously
with script execution in the WebProcess. Hence, it is never called in a
recursive manner.
In webkit2, we can have multiple WebProcesses concurrently triggering a
call to this function. While the function is waiting on feedback from a
UI dialog, the wait loop may re-enter the function to service a second
request to call this function from another WebProcess. This results in
problems where some of the WebProcesses will not get a proper reply, and
therefore hangs perpetually waiting for a non-forthcoming reply.
This changeset changes the function to queue the requests and ensure
that we do not recursively callback to the UI client.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
- UIProcess/WebPageProxy.cpp:
(ExceededDatabaseQuotaRecords):
(Record):
(WebKit::ExceededDatabaseQuotaRecords::areBeingProcessed):
(WebKit::ExceededDatabaseQuotaRecords::ExceededDatabaseQuotaRecords):
(WebKit::ExceededDatabaseQuotaRecords::~ExceededDatabaseQuotaRecords):
(WebKit::ExceededDatabaseQuotaRecords::shared):
(WebKit::ExceededDatabaseQuotaRecords::createRecord):
(WebKit::ExceededDatabaseQuotaRecords::add):
(WebKit::ExceededDatabaseQuotaRecords::next):
(WebKit::WebPageProxy::exceededDatabaseQuota):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- 5:31 PM Changeset in webkit [145163] by
-
- 14 edits in trunk/Source
[BlackBerry] RefCounting ParsedCookie to avoid SegFaults
https://bugs.webkit.org/show_bug.cgi?id=111761
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-03-07
Reviewed by Rob Buis.
Source/WebCore:
Making necessary changes to ref count the ParsedCookie object.
Tested using the opera cookie test suite and the BB Browser cookie test suite.
Tested using the browser, visiting popular sites such as facebook, reddit, google etc
to ensure cookie functionality isn't changed.
- loader/blackberry/CookieJarBlackBerry.cpp:
(WebCore::getRawCookies):
- platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:
(WebCore::CookieDatabaseBackingStore::insert):
(WebCore::CookieDatabaseBackingStore::update):
(WebCore::CookieDatabaseBackingStore::remove):
(WebCore::CookieDatabaseBackingStore::getCookiesFromDatabase):
(WebCore::CookieDatabaseBackingStore::invokeGetCookiesWithLimit):
(WebCore::CookieDatabaseBackingStore::invokeSendChangesToDatabase):
(WebCore::CookieDatabaseBackingStore::addToChangeQueue):
- platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:
(CookieDatabaseBackingStore):
- platform/blackberry/CookieManager.cpp:
(WebCore::cookieSorter):
(WebCore::CookieManager::setCookies):
(WebCore::CookieManager::getCookie):
(WebCore::CookieManager::generateHtmlFragmentForCookies):
(WebCore::CookieManager::getRawCookies):
(WebCore::CookieManager::checkAndTreatCookie):
(WebCore::CookieManager::addCookieToMap):
(WebCore::CookieManager::getBackingStoreCookies):
(WebCore::CookieManager::findOrCreateCookieMap):
(WebCore::CookieManager::removeCookieWithName):
(WebCore::CookieManager::cookieLimitCleanUp):
- platform/blackberry/CookieManager.h:
- platform/blackberry/CookieMap.cpp:
(WebCore::CookieMap::addOrReplaceCookie):
(WebCore::CookieMap::removeCookieAtIndex):
(WebCore::CookieMap::removeCookie):
(WebCore::CookieMap::getAllCookies):
(WebCore::CookieMap::removeOldestCookie):
(WebCore::CookieMap::deleteAllCookiesAndDomains):
(WebCore::CookieMap::getAllChildCookies):
- platform/blackberry/CookieMap.h:
(CookieMap):
- platform/blackberry/CookieParser.cpp:
(WebCore):
(WebCore::CookieParser::parse):
(WebCore::CookieParser::parseOneCookie):
- platform/blackberry/CookieParser.h:
(CookieParser):
- platform/blackberry/ParsedCookie.cpp:
- platform/blackberry/ParsedCookie.h:
(ParsedCookie):
(WebCore::ParsedCookie::create):
Source/WebKit/blackberry:
Making necessary changes to ref-count the ParsedCookie object.
- Api/WebCookieJar.cpp:
(BlackBerry::WebKit::WebCookieJar::cookies):
- 5:12 PM Changeset in webkit [145162] by
-
- 7 edits3 adds in trunk
Heap-use-after-free in WebCore::HTMLMediaElement::~HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=110623
Reviewed by Kentaro Hara.
Source/WebCore:
Test: http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html
- bindings/v8/V8GCController.cpp: Fix MinorGCWrapperVisitor so it doesn't collect ActiveDOMObjects
that have pending activity.
- html/HTMLAudioElement.h:
(HTMLAudioElement): Removed hasPendingActivity() now that this is handled by the base class.
- html/HTMLAudioElement.idl: Removed ActiveDOMObject annotation since HTMLMediaElement now has it.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::hasPendingActivity): Update implementation to return true if the media
has audio and is playing. This brings the code into
compliance with the detached element behavior outlined
in the HTML5 spec.
- html/HTMLMediaElement.idl: Added ActiveDOMObject annotation so that all derived classes are
considered ActiveDOMObjects.
LayoutTests:
- http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal-expected.txt: Added.
- http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html: Added.
- http/tests/misc/resources/delete-frame-during-readystatechange-frame-with-gc-after-video-removal.html: Added.
- 5:10 PM Changeset in webkit [145161] by
-
- 7 edits in trunk/Source
CFNetwork cache partitioning does not work properly on subdomains
https://bugs.webkit.org/show_bug.cgi?id=111772
Reviewed by David Kilzer.
Source/WebCore:
Ensure that the cache partitioning is done over the top privately-controlled domain for the NSURLRequest.
Not possible to test with current automated test tools, must be tested manually.
- loader/cache/MemoryCache.cpp: Remove extraneous calls to partitionName
(WebCore):
(WebCore::MemoryCache::add):
(WebCore::MemoryCache::revalidationSucceeded):
(WebCore::MemoryCache::resourceForRequest):
(WebCore::MemoryCache::evict):
(WebCore::MemoryCache::removeResourcesWithOrigin):
- platform/network/cf/ResourceRequest.h: Put top privately-controlled domain reduction code into ResourceRequest::partitionName
(ResourceRequest):
(WebCore::ResourceRequest::cachePartition):
(WebCore::ResourceRequest::setCachePartition): Pre-process the partition name
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore):
(WebCore::ResourceRequest::partitionName):
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdatePlatformRequest): Use a UTF-8 version of the cache partition name
Source/WebKit2:
Ensure that the CFString is UTF-8 so that WKCFURLCacheCopyAllHostNamesInPersistentStoreForPartition will always work.
- WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:
(WebKit::partitionName): Create a UTF-8 CFString explicitly
- 5:06 PM Changeset in webkit [145160] by
-
- 2 edits in trunk/LayoutTests
Roll out an accidentally committed change I made for local testing.
- http/tests/misc/empty-file-formdata.html:
- 5:06 PM Changeset in webkit [145159] by
-
- 2 edits in trunk/Source/WebCore
Compute WebGL context attributes from DrawingBuffer when it is used
https://bugs.webkit.org/show_bug.cgi?id=111666
Reviewed by James Robinson.
Fixed computation of antialias flag when DrawingBuffer is used.
No new tests; covered by existing tests. Ran WebGL conformance
tests on desktop Linux and Android to test.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::getContextAttributes):
Query DrawingBuffer, when used, for antialias flag.
- 4:59 PM Changeset in webkit [145158] by
-
- 2 edits in trunk/Tools
Add myself to reviewers.py
https://bugs.webkit.org/show_bug.cgi?id=111757
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-07
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/config/committers.py:
- 4:59 PM Changeset in webkit [145157] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: fast/events/before-unload-adopt-subframe-to-outside.html
- 4:57 PM Changeset in webkit [145156] by
-
- 11 edits in trunk/Source
Need API to draw custom overhang area
https://bugs.webkit.org/show_bug.cgi?id=111679
-and corresponding-
<rdar://problem/13291415>
Reviewed by Simon Fraser.
Source/WebCore:
This will allow clients to put custom images into the top or bottom overhang area.
New FrameView API takes a bool indicating whether the client wants a top/bottom
overhang layer. If the bool is true, the overhang layer will be returned.
- WebCore.exp.in:
- page/FrameView.cpp:
(WebCore::FrameView::setWantsLayerForTopOverHangArea):
(WebCore::FrameView::setWantsLayerForBottomOverHangArea):
- page/FrameView.h:
(FrameView):
Keep member variables for the top and bottom overhang layers. Create them if
necessary, and update them if the root layer changes.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateRootLayerPosition):
(WebCore::RenderLayerCompositor::updateLayerForTopOverhangArea):
(WebCore::RenderLayerCompositor::updateLayerForBottomOverhangArea):
(WebCore::RenderLayerCompositor::reportMemoryUsage):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
Source/WebKit2:
The new API is WKBundlePageSetTopOverhangImage() and
WKBundlePageSetBottomOverhangImage(). When the API is called, WebPage will get
GraphicsLayers for the appropriate area from FrameView, and then set the image as
the contents of the layer.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetTopOverhangImage):
(WKBundlePageSetBottomOverhangImage):
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::setTopOverhangImage):
(WebKit):
(WebKit::WebPage::setBottomOverhangImage):
- 4:54 PM Changeset in webkit [145155] by
-
- 1 edit3 adds in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium-linux/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt: Added.
- 4:53 PM Changeset in webkit [145154] by
-
- 4 edits in trunk/Source
Reduce page cache size on Mac
https://bugs.webkit.org/show_bug.cgi?id=111795
Rubber stamped by Geoff Garen
5 entries is unnecessarily large; research show 3 should suffice.
On a low memory warning we should clear this completely.
Source/WebCore:
- platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::releaseMemory):
- clear the page cache completely
Source/WebKit2:
- Shared/CacheModel.cpp:
(WebKit::calculateCacheSizes):
- reduce maximum to 3.
- 4:44 PM Changeset in webkit [145153] by
-
- 3 edits in trunk/LayoutTests
Adding id attribute test for MediaStream
https://bugs.webkit.org/show_bug.cgi?id=111526
Reviewed by Kentaro Hara.
Spec: http://dev.w3.org/2011/webrtc/editor/getusermedia.html#widl-MediaStream-id
The id strings must only use characters in the ranges U+0021, U+0023 to U+0027,
U+002A to U+002B, U+002D to U+002E, U+0030 to U+0039, U+0041 to U+005A,
U+005E to U+007E, and must be 36 characters long.
- fast/mediastream/MediaStreamConstructor-expected.txt:
- fast/mediastream/MediaStreamConstructor.html:
- 4:38 PM Changeset in webkit [145152] by
-
- 4 edits in trunk/Tools
run-perf-tests should have a --repeat option
https://bugs.webkit.org/show_bug.cgi?id=100030
Reviewed by Ryosuke Niwa.
Add --repeat option to run-perf-tests, with default value of 1. When greater
than 1, runs test set specified number of times. Note that multiple runs are
not aggregated for statistical purposes.
Incidentally fixed typo: s/suceeds/succeeds/.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args): Add repeat option.
(PerfTestsRunner.run): Add outer repeat loop.
(PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
(PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
- Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
(MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
(MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
(MainTest.test_run_with_json_output): Fix typo.
(MainTest.test_run_with_description): Fix typo.
(MainTest.test_run_respects_no_results): Fix typo.
(MainTest.test_run_with_slave_config_json): Fix typo.
(MainTest.test_run_with_multiple_repositories): Fix typo.
(MainTest.test_run_with_upload_json): Fix typo.
(MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
(MainTest.test_run_with_repeat): Added new test for repeat count semantics.
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.test_parse_args): Add test for repeat option parsing.
- 4:26 PM Changeset in webkit [145151] by
-
- 2 edits in trunk/LayoutTests
border-fit should happen at layout time rather than paint time
https://bugs.webkit.org/show_bug.cgi?id=111606
Unreviewed. Skipping some broken tests.
- platform/mac/TestExpectations:
- 4:19 PM Changeset in webkit [145150] by
-
- 3 edits in trunk/Source/JavaScriptCore
Crash when updating predictions below JSC::arrayProtoFuncForEach on tuaw.com article
https://bugs.webkit.org/show_bug.cgi?id=111777
Reviewed by Filip Pizlo.
Moved register allocations to be above any generated control flow so that any
resulting spill would be visible to all subsequently generated code.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compile):
- 3:54 PM Changeset in webkit [145149] by
-
- 5 edits in branches/safari-534.59-branch/Source
Versioning.
- 3:54 PM Changeset in webkit [145148] by
-
- 14 edits4 moves in trunk/Source/WebCore
Rename Mac's TileCache to TileController, and WebTileCacheLayer to WebTiledBackingLayer
https://bugs.webkit.org/show_bug.cgi?id=111779
Reviewed by Tim Horton.
"TileCache" was a name conflict in downstream code, so rename it to TileController.
The layer that has a TileController is now a WebTiledBackingLayer (which fits with
the TiledBacking API that TileController exposes).
Also renamed the flags in PlatformCALayer to match.
Rename only, no behavior change.
- WebCore.xcodeproj/project.pbxproj:
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::logExposedUnfilledArea):
- platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::shouldUseTiledBacking):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::platformCALayerShowRepaintCounter):
(WebCore::GraphicsLayerCA::platformCALayerDidCreateTiles):
(WebCore::GraphicsLayerCA::updateVisibleRect):
(WebCore::GraphicsLayerCA::getDebugBorderInfo):
(WebCore::GraphicsLayerCA::requiresTiledLayer):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/ca/PlatformCALayer.h:
(WebCore::PlatformCALayer::usesTiledBackingLayer):
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::PlatformCALayer):
(PlatformCALayer::~PlatformCALayer):
(PlatformCALayer::tiledBacking):
- platform/graphics/ca/mac/TileController.h: Renamed from Source/WebCore/platform/graphics/ca/mac/TileCache.h.
- platform/graphics/ca/mac/WebTileLayer.h:
(TileController):
- platform/graphics/ca/mac/WebTileLayer.mm:
(-[WebTileLayer drawInContext:]):
(-[WebTileLayer setTileController:WebCore::]):
(-[WebTileLayer logFilledFreshTile]):
- platform/graphics/ca/mac/WebTiledBackingLayer.h: Renamed from Source/WebCore/platform/graphics/ca/mac/WebTileCacheLayer.h.
- platform/graphics/ca/mac/WebTiledBackingLayer.mm: Renamed from Source/WebCore/platform/graphics/ca/mac/WebTileCacheLayer.mm.
- platform/graphics/mac/WebLayer.mm:
(drawLayerContents):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::shouldUseTiledBacking):
(WebCore::RenderLayerBacking::adjustTiledBackingCoverage):
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
- rendering/RenderLayerBacking.h:
(WebCore::RenderLayerBacking::usingTiledBacking):
(RenderLayerBacking):
(WebCore::RenderLayerBacking::hasTiledBackingFlatteningLayer):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidLayout):
(WebCore::RenderLayerCompositor::rootFixedBackgroundsChanged):
(WebCore::RenderLayerCompositor::supportsFixedRootBackgroundCompositing):
- 3:52 PM Changeset in webkit [145147] by
-
- 1 copy in tags/Safari-534.59.1
New Tag.
- 3:48 PM Changeset in webkit [145146] by
-
- 2 edits in trunk/Tools
showAllRuns checkbox no longer works on the stats dashboard
https://bugs.webkit.org/show_bug.cgi?id=111673
Reviewed by Ojan Vafai.
Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
so we were trying to index into an undefined object.
- TestResultServer/static-dashboards/dashboard_base.js:
(invalidateQueryParameters):
- 3:45 PM Changeset in webkit [145145] by
-
- 4 edits3 adds in trunk
DFG should not get corrupted IR in the case of code that is dead, unreachable, and contains a chain of nodes that use each other in an untyped way
https://bugs.webkit.org/show_bug.cgi?id=111783
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
Unreachable code is not touched by CFA and so thinks that even untyped uses are checked.
But dead untyped uses don't need checks and hence don't need to be Phantom'd. The DCE knew
this in findTypeCheckRoot() but not in eliminateIrrelevantPhantomChildren(), leading to a
Phantom node that had another Phantom node as one of its kids.
- dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::eliminateIrrelevantPhantomChildren):
LayoutTests:
Reviewed by Mark Hahnenberg.
- fast/js/dfg-dead-unreachable-code-with-chain-of-dead-unchecked-nodes-expected.txt: Added.
- fast/js/dfg-dead-unreachable-code-with-chain-of-dead-unchecked-nodes.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-dead-unreachable-code-with-chain-of-dead-unchecked-nodes.js: Added.
(foo.bar):
(foo):
- 3:42 PM Changeset in webkit [145144] by
-
- 2 edits in trunk/Tools
[Chromium] Update #include for WebStorageNamespace.h
https://bugs.webkit.org/show_bug.cgi?id=111748
Reviewed by Adam Barth.
In anticipation of removing
WK/chromium/public/WebStorageNamespace.h (once downstream
references have been updated)
- DumpRenderTree/chromium/WebViewHost.cpp:
- 3:11 PM Changeset in webkit [145143] by
-
- 2 edits in trunk/Source/JavaScriptCore
The DFG fixpoint is not strictly profitable, and should be straight-lined
https://bugs.webkit.org/show_bug.cgi?id=111764
Reviewed by Oliver Hunt and Geoffrey Garen.
The DFG previously ran optimizations to fixpoint because there exists a circular dependency:
CSE depends on CFG simplification: CFG simplification merges blocks, and CSE is block-local.
CFG simplification depends on CFA and constant folding: constant folding reveals branches on
constants.
CFA depends on CSE: CSE reveals must-alias relationships by proving that two operations
always produce identical values.
Arguments simplification also depends on CSE, but it ought not depend on anything else.
Hence we get a cycle like: CFA -> folding -> CFG -> CSE -> CFA.
Note that before we had sparse conditional CFA, we also had CFA depending on CFG. This ought
not be the case anymore: CFG simplification should not by itself lead to better CFA results.
My guess is that the weakest link in this cycle is CFG -> CSE. CSE cuts both ways: if you
CSE too much then you increase register pressure. Hence it's not clear that you always want
to CSE after simplifying control flow. This leads to an order of optimization as follows:
CSE -> arguments -> CFA -> folding -> CFG
This is a 2.5% speed-up on SunSpider, a 4% speed-up on V8Spider, a possible 0.3% slow-down
on V8v7, nothing on Kraken, and 1.2% speed-up in the JSRegress geomean. I'll take a 2.5%
speed-up over a 0.3% V8v7 speed-up.
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- 2:52 PM Changeset in webkit [145142] by
-
- 5 edits5 adds in trunk
FormData should allow setting filename to empty
https://bugs.webkit.org/show_bug.cgi?id=111687
Reviewed by Brady Eidson.
Tests: http/tests/local/formdata/send-form-data-with-empty-blob-filename.html
http/tests/local/formdata/send-form-data-with-empty-file-filename.html
- platform/network/FormData.cpp: (WebCore::FormData::appendKeyValuePairItems): Missing value is a null string. If the string is empty, we should treat is as authoritative.
- 2:40 PM Changeset in webkit [145141] by
-
- 8 edits in trunk/Tools
run-perf-tests fails due to svn_revision not working on a pure git clone
https://bugs.webkit.org/show_bug.cgi?id=110839
Reviewed by Ryosuke Niwa.
Previously we would call git svn find-rev to look up the commit for
a given revision, and that'll hang in a pure git checkout.
This patch changes the way we look up svn revisions in a git
repository to use git log --grep 'git-svn-id', which is much faster
than grepping ourselves. It also renames timestamp_of_latest_commit()
to timestamp_of_revision() in order to accurately reflect what
the method is doing. Note that this patch only changes the logic
inside latest_revision() and svn_revision(). I'll file a separate
bug to change git_commit_from_svn_revision().
This patch also contains some fixes to unit tests that had bit-rotted
or were otherwise fragile, so that test-webkitpy --all would pass
cleanly, and a fix to outputcapture so that
test-webkitpy -p would work correctly again.
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.svn_revision):
(Git.timestamp_of_revision):
- Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.svn_revision):
(SCM.timestamp_of_revision):
- Scripts/webkitpy/common/checkout/scm/scm_mock.py:
(MockSCM.timestamp_of_revision):
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(_shared_test_commit_with_message):
(test_commit_without_authorization):
(test_timestamp_of_revision):
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.timestamp_of_revision):
- Scripts/webkitpy/common/system/outputcapture.py: Importing unittest2 directly may not be safe if this module is imported before the autoinstaller gets a chance to set things up properly. We don't actually need unittest2 here.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_results_dict):
- 2:37 PM Changeset in webkit [145140] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening AppleWin port.
- platform/win/TestExpectations:
- 2:33 PM Changeset in webkit [145139] by
-
- 5 edits in trunk
REGRESSION: fast/border/border-fit-2.html needs updating
https://bugs.webkit.org/show_bug.cgi?id=111776
Reviewed by Simon Fraser.
Source/WebCore:
This test is incorrectly shrinking the border image now.
We need to apply some clamping to the border-fit like the
old code did. The pixel results *are* still changing though,
since a layout-time shrinkage will not result in right-aligned
boxes in an LTR block when the left edge gets chopped. We'll
have to see if this behavioral change ends up being a problem,
but for now we'll rebaseline and assume it will be ok.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::fitBorderToLinesIfNeeded):
LayoutTests:
- platform/mac/fast/borders/border-fit-2-expected.png:
- platform/mac/fast/borders/border-fit-2-expected.txt:
- 2:32 PM Changeset in webkit [145138] by
-
- 4 edits in branches/safari-536.29-branch/Source
Versioning.
- 2:31 PM Changeset in webkit [145137] by
-
- 1 copy in tags/Safari-536.29.5
New Tag.
- 2:21 PM Changeset in webkit [145136] by
-
- 5 edits2 adds in trunk
Web Inspector: provide reasons why a layer was composited in the LayerTreeAgent
https://bugs.webkit.org/show_bug.cgi?id=111703
Source/WebCore:
Introduce a new LayerTree.reasonsForCompositingLayer(layerId) method which returns
the list of reasons why the provided layer was composited as an object with an
optional property for each possible reason. The RenderLayerCompositor already knows
how to provide this information via its own reasonsForCompositing() method, and we
process the returned bitmask to populate the object sent to the front-end.
Reviewed by Timothy Hatcher.
Test: inspector-protocol/layers/layers-compositing-reasons.html
- inspector/Inspector.json:
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):
(WebCore):
- inspector/InspectorLayerTreeAgent.h:
(InspectorLayerTreeAgent):
LayoutTests:
New test for LayerTree.reasonsForCompositingLayer(layerId).
Reviewed by Timothy Hatcher.
- inspector-protocol/layers/layers-compositing-reasons-expected.txt: Added.
- inspector-protocol/layers/layers-compositing-reasons.html: Added.
- 2:13 PM Changeset in webkit [145135] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: http/tests/security/cross-origin-css.html
- 2:07 PM Changeset in webkit [145134] by
-
- 2 edits1 move in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium-mac/fast/repaint/border-fit-lines-expected.txt: Renamed from LayoutTests/platform/chromium/fast/repaint/border-fit-lines-expected.txt.
- platform/chromium-win/fast/repaint/border-fit-lines-expected.txt:
- 2:02 PM Changeset in webkit [145133] by
-
- 9 edits in trunk/Source
Add a didFocusTextField callback to the injected bundle form client
https://bugs.webkit.org/show_bug.cgi?id=111771
Reviewed by Andreas Kling.
Source/WebCore:
Export a symbol needed by WebKit2.
- WebCore.exp.in:
Source/WebKit2:
Add a new client callback that's invoked whenever a text input field is focused.
- Shared/APIClientTraits.cpp:
(WebKit):
- Shared/APIClientTraits.h:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
(WebKit::InjectedBundlePageFormClient::didFocusTextField):
(WebKit):
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
(InjectedBundlePageFormClient):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::focusedNodeChanged):
- 2:01 PM Changeset in webkit [145132] by
-
- 2 edits2 moves2 deletes in trunk/LayoutTests
Unreviewed gardening.
- fast/borders/border-fit-expected.txt: Renamed from LayoutTests/platform/chromium/fast/borders/border-fit-expected.txt.
- platform/chromium-mac/fast/borders/border-fit-expected.txt: Renamed from LayoutTests/platform/mac/fast/borders/border-fit-expected.txt.
- platform/chromium-win/fast/borders/border-fit-expected.txt:
- platform/efl/fast/borders/border-fit-expected.txt: Removed.
- platform/gtk/fast/borders/border-fit-expected.txt: Removed.
- 1:53 PM Changeset in webkit [145131] by
-
- 6 edits in trunk/Source
[chromium] Stop using WebTransformationMatrix on WebLayer
https://bugs.webkit.org/show_bug.cgi?id=111635
Reviewed by Adrienne Walker.
Source/Platform:
WebLayer supports setting transforms by using either SkMatrix44 or WebTransformationMatrix,
both of which are wrappers around 16 doubles. There's no need to have both.
- chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
Source/WebCore:
Switches over to the SkMatrix44 transform setters.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::transformToSkMatrix44):
Utility for convering a WebCore::TransformationMatrix to an SkMatrix44.
Will move to a more common location once it gets more callers.
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):
Source/WebKit/chromium:
- src/LinkHighlight.cpp:
(WebKit::LinkHighlight::computeEnclosingCompositingLayer):
- tests/GraphicsLayerChromiumTest.cpp:
(GraphicsLayerChromiumTest):
- 1:50 PM Changeset in webkit [145130] by
-
- 6 edits in trunk
[EFL] Bump libsoup dependency to 2.40.3 to fix regressions
https://bugs.webkit.org/show_bug.cgi?id=111756
Reviewed by Kenneth Rohde Christiansen.
.:
Update libsoup required version to v2.40.3 for EFL port.
- Source/cmake/OptionsEfl.cmake:
Tools:
Bump libsoup to v2.40.3 to fix the regressions introduced by
previous v2.40.0 bump.
- efl/jhbuild.modules:
LayoutTests:
Unskip several tests that are passing after the libsoup dependency
bump to 2.40.3.
- platform/efl/TestExpectations:
- 1:40 PM Changeset in webkit [145129] by
-
- 3 edits in trunk/Source/JavaScriptCore
Build fix for AppleWin VS2010.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- 1:29 PM Changeset in webkit [145128] by
-
- 2 edits in trunk/Tools
Re-enable Win EWS tests.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 1:27 PM Changeset in webkit [145127] by
-
- 3 edits in trunk/Source/WebCore
[Mac] allow iOS to use CaptionUserPreferencesMac
https://bugs.webkit.org/show_bug.cgi?id=111770
Reviewed by Dean Jackson.
No new tests, covered by existing tests.
- page/CaptionUserPreferencesMac.h:
- page/CaptionUserPreferencesMac.mm:
(WebCore::userCaptionPreferencesChangedNotificationCallback): Respond to notifications on
the web thread.
- 1:24 PM Changeset in webkit [145126] by
-
- 5 edits in trunk/Source/WebCore
Move side-effects on hover/active state out of hit-testing
https://bugs.webkit.org/show_bug.cgi?id=98168
Reviewed by Julien Chaffraix.
Original patch by Allan Sandfeld Jensen; I'm just tweaking things.
Document::updateHoverActiveState is currently called during hit testing
to update the hover and active states of elements effected by mouse
movements (or their keyboard equivalents). This conflates the hit test
algorithm itself with side-effects associated with specific use-cases.
This conflation makes it very difficult to reuse the hover/active logic
for things other than hit testing. 'mouseenter'/'mouseleave' events[1]
are one example of a feature that would be simple to implement on top of
this existing logic if we split it out from the hit testing path, and
instead call it explicitly when necessary. An explicit split between
hit testing and its side-effects will also enable us to simplify the
logic in future patches with well-named parameters, rather than relying
on stuffing properties into HitTestRequest.
This patch drops the call to Document::updateHoverActiveState from
RenderView::hitTest, and adjusts the three call-sites in EventHandler
to explicitly call out to it rather than Document::updateStyleIfNeeded.
The latter call is still necessary but has been folded into
updateHoverActiveState, as the former is never called without calling
the latter.
- dom/Document.h:
- dom/Document.cpp:
(WebCore::Document::updateHoverActiveState):
First, this function must now only be called from contexts that were
performing a read/write hit-test: the code asserts this
precondition.
Second, rather than accepting a HitTestResult, the function accepts
an Element* from which to begin the hover/active chain changes.
Third, we have to explicitly update the hover/active states for
documents between the updated element and the top-level document.
The hit-testing logic was taking care of this for us, now we need to
take care of it ourselves.
Fourth, call out to updateStyleIfNeeded rather than making our
caller do so. The calls were always paired; now that's explicit.
(WebCore::Document::prepareMouseEvent):
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::hoverTimerFired):
Call out to updateHoverActiveState rather than updateStyleIfNeeded.
- rendering/RenderView.cpp:
(WebCore::RenderView::hitTest):
Drop the call to updateHoverActiveState.
- 1:18 PM Changeset in webkit [145125] by
-
- 4 edits in trunk/Source/WebKit/chromium
[Chromium] Update some #includes for WebMessagePortChannel.h
https://bugs.webkit.org/show_bug.cgi?id=111752
Reviewed by James Robinson.
In anticipation of removing
WK/chromium/public/WebMessagePortChannel.h (once all downstream
references have been updated)
- public/WebDOMMessageEvent.h:
- public/WebFrame.h:
- public/WebSharedWorkerClient.h:
- 1:08 PM Changeset in webkit [145124] by
-
- 1 edit3 adds in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Added.
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt: Added.
- platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt: Added.
- 12:59 PM Changeset in webkit [145123] by
-
- 5 edits5 deletes in trunk
Unreviewed, rolling out r145097.
http://trac.webkit.org/changeset/145097
https://bugs.webkit.org/show_bug.cgi?id=111765
Triggers an ASSERT in the Chromium port (Requested by abarth
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-07
Source/WebCore:
- html/FileInputType.cpp:
(WebCore::FileInputType::appendFormData):
- platform/network/FormData.cpp:
(WebCore::FormData::appendKeyValuePairItems):
LayoutTests:
- http/tests/local/formdata/send-form-data-with-empty-blob-filename-expected.txt: Removed.
- http/tests/local/formdata/send-form-data-with-empty-blob-filename.html: Removed.
- http/tests/local/formdata/send-form-data-with-empty-file-filename-expected.txt: Removed.
- http/tests/local/formdata/send-form-data-with-empty-file-filename.html: Removed.
- http/tests/xmlhttprequest/resources/multipart-post-echo-filenames.php: Removed.
- platform/wk2/TestExpectations:
- 12:58 PM Changeset in webkit [145122] by
-
- 2 edits1 add in trunk/Tools
[nrwt] handle corrupt http server pid files cleanly
https://bugs.webkit.org/show_bug.cgi?id=111628
Reviewed by Eric Seidel.
If the pid file from a previous http server is corrupt for some
reason, NRWT will just raise errors and not clean it up or recover.
This patch fixes that to at least delete the pid file and
not throw; not that we may still have stale http servers left on
the system, since there's no way to know which pid to kill if
the file was corrupted.
- Scripts/webkitpy/layout_tests/servers/http_server_base.py:
(HttpServerBase.start):
(HttpServerBase.stop):
(HttpServerBase._remove_pid_file):
- Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
(TestHttpServerBase):
(TestHttpServerBase.test_corrupt_pid_file):
- 12:55 PM Changeset in webkit [145121] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Prevent text selection inside Colour and Date/Time input fields
https://bugs.webkit.org/show_bug.cgi?id=111733
Reviewed by Rob Buis.
PR 305194.
Prevent selection for popup input fields as they are buttons.
Informally Reviewed Gen Mak.
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
- 12:49 PM Changeset in webkit [145120] by
-
- 2 edits in branches/safari-536.29-branch/Source/WebCore
Merged r145013. <rdar://problem/13370880>
- 12:43 PM Changeset in webkit [145119] by
-
- 20 edits4 adds in trunk/Source/JavaScriptCore
Objective-C API: Need a good way to reference event handlers without causing cycles
https://bugs.webkit.org/show_bug.cgi?id=111088
Reviewed by Geoffrey Garen.
JSManagedValue is like a special kind of weak value. When you create a JSManagedValue, you can
supply an Objective-C object as its "owner". As long as the Objective-C owner object remains
alive and its wrapper remains accessible to the JSC garbage collector (e.g. by being marked by
the global object), the reference to the JavaScript value is strong. As soon as the Objective-C
owner is deallocated or its wrapper becomes inaccessible to the garbage collector, the reference
becomes weak.
If you do not supply an owner or you use the weakValueWithValue: convenience class method, the
returned JSManagedValue behaves as a normal weak reference.
This new class allows clients to maintain references to JavaScript values in the Objective-C
heap without creating reference cycles/leaking memory.
- API/JSAPIWrapperObject.cpp: Added.
(JSC):
(JSC::::createStructure):
(JSC::JSAPIWrapperObject::JSAPIWrapperObject): This is a special JSObject for the Objective-C API that knows
for the purposes of garbage collection/marking that it wraps an opaque Objective-C object.
(JSC::JSAPIWrapperObject::visitChildren): We add the pointer to the wrapped Objective-C object to the set of
opaque roots so that the weak handle owner for JSManagedValues can find it later.
- API/JSAPIWrapperObject.h: Added.
(JSC):
(JSAPIWrapperObject):
(JSC::JSAPIWrapperObject::wrappedObject):
(JSC::JSAPIWrapperObject::setWrappedObject):
- API/JSBase.cpp:
(JSSynchronousGarbageCollect):
- API/JSBasePrivate.h:
- API/JSCallbackObject.cpp:
(JSC):
- API/JSCallbackObject.h:
(JSC::JSCallbackObject::destroy): Moved this to the header so that we don't get link errors with JSAPIWrapperObject.
- API/JSContext.mm:
(-[JSContext initWithVirtualMachine:]): We weren't adding manually allocated/initialized JSVirtualMachine objects to
the global cache of virtual machines. The init methods handle this now rather than contextWithGlobalContextRef, since
not everyone is guaranteed to use the latter.
(-[JSContext initWithGlobalContextRef:]):
(+[JSContext contextWithGlobalContextRef:]):
- API/JSManagedValue.h: Added.
- API/JSManagedValue.mm: Added.
(JSManagedValueHandleOwner):
(managedValueHandleOwner):
(+[JSManagedValue weakValueWithValue:]):
(+[JSManagedValue managedValueWithValue:owner:]):
(-[JSManagedValue init]): We explicitly call the ARC entrypoints to initialize/get the weak owner field since we don't
use ARC when building our framework.
(-[JSManagedValue initWithValue:]):
(-[JSManagedValue initWithValue:owner:]):
(-[JSManagedValue dealloc]):
(-[JSManagedValue value]):
(-[JSManagedValue weakOwner]):
(JSManagedValueHandleOwner::isReachableFromOpaqueRoots): If the Objective-C owner is still alive (i.e. loading the weak field
returns non-nil) and that value was added to the set of opaque roots by the wrapper for that Objective-C owner, then the the
JSObject to which the JSManagedObject refers is still alive.
- API/JSObjectRef.cpp: We have to add explicit checks for the JSAPIWrapperObject, just like the other types of JSCallbackObjects.
(JSObjectGetPrivate):
(JSObjectSetPrivate):
(JSObjectGetPrivateProperty):
(JSObjectSetPrivateProperty):
(JSObjectDeletePrivateProperty):
- API/JSValue.mm:
(objectToValueWithoutCopy):
- API/JSValueRef.cpp:
(JSValueIsObjectOfClass):
- API/JSVirtualMachine.mm:
(-[JSVirtualMachine initWithContextGroupRef:]):
(+[JSVirtualMachine virtualMachineWithContextGroupRef:]):
- API/JSWrapperMap.mm:
(wrapperFinalize):
(makeWrapper): This is our own internal version of JSObjectMake which creates JSAPIWrapperObjects, the Obj-C API
version of JSCallbackObjects.
(createObjectWithCustomBrand):
(-[JSObjCClassInfo wrapperForObject:]):
(tryUnwrapObjcObject):
- API/JavaScriptCore.h:
- API/tests/testapi.mm: Added new tests for the strong and weak uses of JSManagedValue in the context of an
onclick handler for an Objective-C object inserted into a JSContext.
(-[TextXYZ setWeakOnclick:]):
(-[TextXYZ setOnclick:]):
(-[TextXYZ weakOnclick]):
(-[TextXYZ onclick]):
(-[TextXYZ click]):
- CMakeLists.txt: Various build system additions.
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/JSGlobalObject.cpp: Added the new canonical Structure for the JSAPIWrapperObject class.
(JSC::JSGlobalObject::reset):
(JSC):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSGlobalObject):
(JSC::JSGlobalObject::objcWrapperObjectStructure):
- 12:18 PM Changeset in webkit [145118] by
-
- 26 edits2 copies in branches/chromium/1410
Merge 144350
Focus ring for a child layer is incorrectly offset by ancestor composited layer's position
https://bugs.webkit.org/show_bug.cgi?id=110895
Reviewed by Simon Fraser.
Source/WebCore:
Test: compositing/sub-layer-focus-ring.html
The problem occurs in RenderBlock::addFocusRingRects() where the absolute position of a sub-layer is used to calculate the focus ring rect of the layer.
Should use the relative position to the current paintContainer instead.
To fix the issue:
- RenderLayer passes LayerPaintingInfo.rootLayer to PaintInfo.paintContainer
- Let RenderObject::paintFocusRing() and RenderObject::paintOutline() take PaintInfo instead of GraphicsContext* so that the paintContainer can be passed
- RenderBlock::addFocusRingRects() uses localToContainerPoint(FloatPoint(), paintContainer) instead of localToAbsolute() to calculate the focus ring rect of a sublayer.
- rendering/PaintInfo.h:
(WebCore):
(WebCore::PaintInfo::PaintInfo): Add a field paintContainer (the RenderLayerModelObject which originates the current painting)
(PaintInfo):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::paintContinuationOutlines):
(WebCore::RenderBlock::addFocusRingRects): Use the added paintContainer parameter to calculate the relative offset of the child layer.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintBackgroundForFragments): Pass LayerPaintingInfo.rootLayer to PaintInfo.paintContainer.
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase): Ditto.
(WebCore::RenderLayer::paintOutlineForFragments): Ditto.
(WebCore::RenderLayer::paintMaskForFragments): Ditto.
- rendering/RenderLayer.cpp:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::paintFocusRing): Now takes PaintInfo instead of GraphicsContext*. Pass paintInfo.paintContainer to addFocusRingRects().
(WebCore::RenderObject::paintOutline): Now takes PaintInfo instead of GraphicsContext*.
(WebCore::RenderObject::absoluteFocusRingQuads):
- rendering/RenderObject.h:
(WebCore::RenderObject::addFocusRingRects): Add paintContainer parameter.
LayoutTests:
New ref test for the bug.
- compositing/sub-layer-focus-ring-expected.html: Added.
- compositing/sub-layer-focus-ring.html: Added.
TBR=wangxianzhu@chromium.org
Review URL: https://codereview.chromium.org/12641003
- 12:08 PM Changeset in webkit [145117] by
-
- 3 edits in trunk/LayoutTests
Image rebaselines after r145104.
- platform/chromium-mac/fast/table/border-collapsing/cached-change-row-border-width-expected.png:
- platform/chromium-mac/fast/table/border-collapsing/cached-change-tbody-border-width-expected.png:
- 12:04 PM Changeset in webkit [145116] by
-
- 7 edits2 adds in trunk
AX: Can't activate links with VoiceOver in Safari
https://bugs.webkit.org/show_bug.cgi?id=111755
Reviewed by Tim Horton.
Source/WebCore:
VoiceOver is relying on the press action being the first action in the list. We changed
that order inadvertently recently, which confuses VoiceOver.
Test: platform/mac/accessibility/press-action-is-first.html
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityActionNames]):
Tools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(supportedActionsCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
(AccessibilityUIElement):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::supportedActions):
LayoutTests:
- platform/mac/accessibility/press-action-is-first-expected.txt: Added.
- platform/mac/accessibility/press-action-is-first.html: Added.
- 12:03 PM Changeset in webkit [145115] by
-
- 208 edits in trunk
Unreviewed, rolling out r145083.
http://trac.webkit.org/changeset/145083
https://bugs.webkit.org/show_bug.cgi?id=110733
caused lots crashes in http/tests/security/xssAuditor/* tests
Source/WebCore:
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
- html/parser/XSSAuditor.h:
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript):
- html/parser/XSSAuditorDelegate.h:
(WebCore::XSSInfo::create):
(XSSInfo):
(WebCore::XSSInfo::XSSInfo):
LayoutTests:
- fast/frames/xss-auditor-handles-file-urls-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-unset-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-unset-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-unset-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-empty-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-invalid-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt:
- http/tests/security/xssAuditor/base-href-control-char-expected.txt:
- http/tests/security/xssAuditor/base-href-expected.txt:
- http/tests/security/xssAuditor/base-href-null-char-expected.txt:
- http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
- http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt:
- http/tests/security/xssAuditor/block-does-not-leak-referrer-expected.txt:
- http/tests/security/xssAuditor/cached-frame-expected.txt:
- http/tests/security/xssAuditor/cookie-injection-expected.txt:
- http/tests/security/xssAuditor/dom-write-URL-expected.txt:
- http/tests/security/xssAuditor/dom-write-location-expected.txt:
- http/tests/security/xssAuditor/dom-write-location-inline-event-expected.txt:
- http/tests/security/xssAuditor/dom-write-location-javascript-URL-expected.txt:
- http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt:
- http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt:
- http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/embed-tag-expected.txt:
- http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
- http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
- http/tests/security/xssAuditor/form-action-expected.txt:
- http/tests/security/xssAuditor/formaction-on-button-expected.txt:
- http/tests/security/xssAuditor/formaction-on-input-expected.txt:
- http/tests/security/xssAuditor/full-block-base-href-expected.txt:
- http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
- http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
- http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt:
- http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
- http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
- http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-cross-domain-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
- http/tests/security/xssAuditor/get-from-iframe-expected.txt:
- http/tests/security/xssAuditor/iframe-injection-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-url-encoded-expected.txt:
- http/tests/security/xssAuditor/iframe-onload-GBK-char-expected.txt:
- http/tests/security/xssAuditor/iframe-onload-in-svg-tag-expected.txt:
- http/tests/security/xssAuditor/iframe-srcdoc-expected.txt:
- http/tests/security/xssAuditor/img-onerror-GBK-char-expected.txt:
- http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt:
- http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding-expected.txt:
- http/tests/security/xssAuditor/img-onerror-non-ASCII-char-expected.txt:
- http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-default-encoding-expected.txt:
- http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-expected.txt:
- http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt:
- http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt:
- http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt:
- http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt:
- http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
- http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt:
- http/tests/security/xssAuditor/javascript-link-control-char-expected.txt:
- http/tests/security/xssAuditor/javascript-link-expected.txt:
- http/tests/security/xssAuditor/javascript-link-null-char-expected.txt:
- http/tests/security/xssAuditor/javascript-link-one-plus-one-expected.txt:
- http/tests/security/xssAuditor/javascript-link-url-encoded-expected.txt:
- http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt:
- http/tests/security/xssAuditor/link-onclick-control-char-expected.txt:
- http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
- http/tests/security/xssAuditor/link-onclick-expected.txt:
- http/tests/security/xssAuditor/link-onclick-null-char-expected.txt:
- http/tests/security/xssAuditor/link-opens-new-window-expected.txt:
- http/tests/security/xssAuditor/malformed-HTML-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-1-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-2-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-3-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-4-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-5-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-6-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-7-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-8-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-9-expected.txt:
- http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
- http/tests/security/xssAuditor/object-tag-expected.txt:
- http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
- http/tests/security/xssAuditor/open-attribute-body-expected.txt:
- http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
- http/tests/security/xssAuditor/open-iframe-src-01-expected.txt:
- http/tests/security/xssAuditor/open-iframe-src-02-expected.txt:
- http/tests/security/xssAuditor/open-iframe-src-03-expected.txt:
- http/tests/security/xssAuditor/open-script-src-01-expected.txt:
- http/tests/security/xssAuditor/open-script-src-02-expected.txt:
- http/tests/security/xssAuditor/open-script-src-03-expected.txt:
- http/tests/security/xssAuditor/open-script-src-04-expected.txt:
- http/tests/security/xssAuditor/post-from-iframe-expected.txt:
- http/tests/security/xssAuditor/property-escape-comment-01-expected.txt:
- http/tests/security/xssAuditor/property-escape-comment-02-expected.txt:
- http/tests/security/xssAuditor/property-escape-comment-03-expected.txt:
- http/tests/security/xssAuditor/property-escape-entity-01-expected.txt:
- http/tests/security/xssAuditor/property-escape-entity-02-expected.txt:
- http/tests/security/xssAuditor/property-escape-entity-03-expected.txt:
- http/tests/security/xssAuditor/property-escape-expected.txt:
- http/tests/security/xssAuditor/property-escape-long-expected.txt:
- http/tests/security/xssAuditor/property-escape-quote-01-expected.txt:
- http/tests/security/xssAuditor/property-escape-quote-02-expected.txt:
- http/tests/security/xssAuditor/property-escape-quote-03-expected.txt:
- http/tests/security/xssAuditor/report-script-tag-expected.txt:
- http/tests/security/xssAuditor/report-script-tag-full-block-expected.txt:
- http/tests/security/xssAuditor/script-tag-Big5-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode-expected.txt:
- http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-expected.txt:
- http/tests/security/xssAuditor/script-tag-Big5-char2-expected.txt:
- http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt:
- http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt:
- http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt:
- http/tests/security/xssAuditor/script-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-convoluted-expected.txt:
- http/tests/security/xssAuditor/script-tag-entities-expected.txt:
- http/tests/security/xssAuditor/script-tag-expected.txt:
- http/tests/security/xssAuditor/script-tag-inside-svg-tag-expected.txt:
- http/tests/security/xssAuditor/script-tag-inside-svg-tag2-expected.txt:
- http/tests/security/xssAuditor/script-tag-inside-svg-tag3-expected.txt:
- http/tests/security/xssAuditor/script-tag-null-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt:
- http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-post-expected.txt:
- http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-redirect-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode2-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode3-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode4-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-actual-comma-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-comma-01-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-comma-02-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-data-url-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-data-url2-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-data-url3-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-01-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-02-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-03-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment5-expected.txt:
- http/tests/security/xssAuditor/svg-animate-expected.txt:
- http/tests/security/xssAuditor/svg-script-tag-expected.txt:
- http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt:
- http/tests/security/xssAuditor/xss-filter-bypass-long-string-expected.txt:
- http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-02-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
- platform/chromium/http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt:
- 12:00 PM Changeset in webkit [145114] by
-
- 4 edits4 adds in trunk
[CSS Shaders] Implement hue and saturation non-separable blend modes
https://bugs.webkit.org/show_bug.cgi?id=109464
Source/WebCore:
Added the following GLSL helper functions to the CustomFilterValidatedProgram:
- css_Sat(C): returns the saturation for the color C
- css_SetSat(C, s): sets the saturation s on the color C
- css_SetSatHelper(Cmin, Cmid, Cmax, s): helper function for css_SetSat
The above functions are being used for the "hue" and "saturation" non-separable
blend modes, the relevant spec for such modes is at URL:
https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blendingnonseparable
Reviewed by Dean Jackson.
Tests: css3/filters/custom/custom-filter-nonseparable-blend-mode-hue.html
css3/filters/custom/custom-filter-nonseparable-blend-mode-saturation.html
- platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::blendFunctionString):
LayoutTests:
Added relevant tests for the "hue" and "saturation" non-separable blend modes.
These tests are currently skipped on Mac due to a slight color difference; please see relevant bug: http://webkit.org/b/107487.
Reviewed by Dean Jackson.
- css3/filters/custom/custom-filter-nonseparable-blend-mode-hue-expected.html: Added.
- css3/filters/custom/custom-filter-nonseparable-blend-mode-hue.html: Added.
- css3/filters/custom/custom-filter-nonseparable-blend-mode-saturation-expected.html: Added.
- css3/filters/custom/custom-filter-nonseparable-blend-mode-saturation.html: Added.
- platform/mac/TestExpectations:
- 11:53 AM Changeset in webkit [145113] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium-mac/fast/borders/border-radius-with-box-shadow-01-expected.png: Added.
- platform/chromium-win/fast/borders/border-radius-with-box-shadow-01-expected.png: Added.
- 11:43 AM Changeset in webkit [145112] by
-
- 26 edits2 deletes in branches/chromium/1410
Revert 145087
Merge 144350
Focus ring for a child layer is incorrectly offset by ancestor composited layer's position
https://bugs.webkit.org/show_bug.cgi?id=110895
Reviewed by Simon Fraser.
Source/WebCore:
Test: compositing/sub-layer-focus-ring.html
The problem occurs in RenderBlock::addFocusRingRects() where the absolute position of a sub-layer is used to calculate the focus ring rect of the layer.
Should use the relative position to the current paintContainer instead.
To fix the issue:
- RenderLayer passes LayerPaintingInfo.rootLayer to PaintInfo.paintContainer
- Let RenderObject::paintFocusRing() and RenderObject::paintOutline() take PaintInfo instead of GraphicsContext* so that the paintContainer can be passed
- RenderBlock::addFocusRingRects() uses localToContainerPoint(FloatPoint(), paintContainer) instead of localToAbsolute() to calculate the focus ring rect of a sublayer.
- rendering/PaintInfo.h:
(WebCore):
(WebCore::PaintInfo::PaintInfo): Add a field paintContainer (the RenderLayerModelObject which originates the current painting)
(PaintInfo):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::paintContinuationOutlines):
(WebCore::RenderBlock::addFocusRingRects): Use the added paintContainer parameter to calculate the relative offset of the child layer.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintBackgroundForFragments): Pass LayerPaintingInfo.rootLayer to PaintInfo.paintContainer.
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase): Ditto.
(WebCore::RenderLayer::paintOutlineForFragments): Ditto.
(WebCore::RenderLayer::paintMaskForFragments): Ditto.
- rendering/RenderLayer.cpp:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::paintFocusRing): Now takes PaintInfo instead of GraphicsContext*. Pass paintInfo.paintContainer to addFocusRingRects().
(WebCore::RenderObject::paintOutline): Now takes PaintInfo instead of GraphicsContext*.
(WebCore::RenderObject::absoluteFocusRingQuads):
- rendering/RenderObject.h:
(WebCore::RenderObject::addFocusRingRects): Add paintContainer parameter.
LayoutTests:
New ref test for the bug.
- compositing/sub-layer-focus-ring-expected.html: Added.
- compositing/sub-layer-focus-ring.html: Added.
TBR=wangxianzhu@chromium.org
Review URL: https://codereview.chromium.org/12616003
TBR=wangxianzhu@chromium.org
Review URL: https://codereview.chromium.org/12545020
- 11:40 AM Changeset in webkit [145111] by
-
- 2 edits in trunk/LayoutTests
IndexedDB: Make test behavior deterministic in multiprocess ports
https://bugs.webkit.org/show_bug.cgi?id=111643
Reviewed by Tony Chang.
Root cause is documented in wkbug.com/111642 but as a stop-gap - ensure
that this test doesn't fail flakily in multiprocess ports by moving the
last part of the test out of a limbo zone.
- storage/indexeddb/resources/index-multientry.js: Run subsequent part of
test in open's "success" handler rather than transaction's "complete" handler.
- 11:20 AM Changeset in webkit [145110] by
-
- 2 edits in trunk/Tools
Windows debug layout tests are crashing like crazy again.
Disable tests on Win EWS bots temporarily.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 11:18 AM Changeset in webkit [145109] by
-
- 1 edit1 delete in trunk/Source/WebKit/chromium
[Chromium] Remove WK/chromium/public/WebStorageArea.h
https://bugs.webkit.org/show_bug.cgi?id=111744
Reviewed by James Robinson.
File moved to new Platform/ directory. All references have already
been updated (including downstream).
- public/WebStorageArea.h: Removed.
- 11:13 AM Changeset in webkit [145108] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Update some #includes for WebFileInfo.h in WK/chromium/src/
https://bugs.webkit.org/show_bug.cgi?id=111741
Reviewed by James Robinson.
In preparation for removing WK/chromium/public/WebFileInfo.h.
- src/AssertMatchingEnums.cpp:
- 11:07 AM Changeset in webkit [145107] by
-
- 3 edits in trunk/Tools
Make EWS bots build and test in release.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- 11:03 AM Changeset in webkit [145106] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [ACE] set correct font
https://bugs.webkit.org/show_bug.cgi?id=111747
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-07
Reviewed by Pavel Feldman.
No new tests.
Set class "source-code" for the ace editor element.
- inspector/front-end/AceTextEditor.js:
(WebInspector.AceTextEditor):
- 11:03 AM Changeset in webkit [145105] by
-
- 10 edits14 moves30 adds29 deletes in releases/WebKitGTK/webkit-2.0
Merge 145081 - [GTK] Enable translations for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=111398
Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2013-03-07.
Reviewed by Martin Robinson.
- GNUmakefile.am: adjust path for i18n GNUmakefile.am.
- configure.ac: generate the i18n makefile unconditionally, the translations are
used by both WebKitGTK+ and WebKit2GTK+.
Source/WebCore:
- GNUmakefile.am: distribute po files.
- platform/gtk/po/POTFILES.in: adjust paths for translatable files.
Source/WebCore/platform/gtk/po:
- GNUmakefile.am: Renamed from Source/WebKit/gtk/po/GNUmakefile.am.
- POTFILES.in: Renamed from Source/WebKit/gtk/po/POTFILES.in.
- README: Renamed from Source/WebKit/gtk/po/README.
- ar.po: Renamed from Source/WebKit/gtk/po/ar.po.
- as.po: Renamed from Source/WebKit/gtk/po/as.po.
- bg.po: Renamed from Source/WebKit/gtk/po/bg.po.
- cs.po: Renamed from Source/WebKit/gtk/po/cs.po.
- de.po: Renamed from Source/WebKit/gtk/po/de.po.
- el.po: Renamed from Source/WebKit/gtk/po/el.po.
- en_CA.po: Renamed from Source/WebKit/gtk/po/en_CA.po.
- en_GB.po: Renamed from Source/WebKit/gtk/po/en_GB.po.
- eo.po: Renamed from Source/WebKit/gtk/po/eo.po.
- es.po: Renamed from Source/WebKit/gtk/po/es.po.
- et.po: Renamed from Source/WebKit/gtk/po/et.po.
- eu.po: Renamed from Source/WebKit/gtk/po/eu.po.
- fr.po: Renamed from Source/WebKit/gtk/po/fr.po.
- gl.po: Renamed from Source/WebKit/gtk/po/gl.po.
- gu.po: Renamed from Source/WebKit/gtk/po/gu.po.
- he.po: Renamed from Source/WebKit/gtk/po/he.po.
- hi.po: Renamed from Source/WebKit/gtk/po/hi.po.
- hu.po: Renamed from Source/WebKit/gtk/po/hu.po.
- id.po: Renamed from Source/WebKit/gtk/po/id.po.
- it.po: Renamed from Source/WebKit/gtk/po/it.po.
- ko.po: Renamed from Source/WebKit/gtk/po/ko.po.
- lt.po: Renamed from Source/WebKit/gtk/po/lt.po.
- lv.po: Renamed from Source/WebKit/gtk/po/lv.po.
- mr.po: Renamed from Source/WebKit/gtk/po/mr.po.
- nb.po: Renamed from Source/WebKit/gtk/po/nb.po.
- nl.po: Renamed from Source/WebKit/gtk/po/nl.po.
- pa.po: Renamed from Source/WebKit/gtk/po/pa.po.
- pl.po: Renamed from Source/WebKit/gtk/po/pl.po.
- pt.po: Renamed from Source/WebKit/gtk/po/pt.po.
- pt_BR.po: Renamed from Source/WebKit/gtk/po/pt_BR.po.
- ro.po: Renamed from Source/WebKit/gtk/po/ro.po.
- ru.po: Renamed from Source/WebKit/gtk/po/ru.po.
- sl.po: Renamed from Source/WebKit/gtk/po/sl.po.
- sr.po: Renamed from Source/WebKit/gtk/po/sr.po.
- sr@latin.po: Renamed from Source/WebKit/gtk/po/sr@latin.po.
- sv.po: Renamed from Source/WebKit/gtk/po/sv.po.
- uk.po: Renamed from Source/WebKit/gtk/po/uk.po.
- vi.po: Renamed from Source/WebKit/gtk/po/vi.po.
- zh_CN.po: Renamed from Source/WebKit/gtk/po/zh_CN.po.
Source/WebKit2:
- GNUmakefile.am: define PACKAGE_LOCALE_DIR when building WebProcess's main module.
- WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk): register the i18n domain name, and prefer UTF-8, since
we're GTK+; at the moment we're just using the same name as WebKitGTK+, pro: the
translation module can be reused, con: you can't have different versions of
WebKitGTK+ and WebKit2GTK+ installed, because the module would not be fit for reuse
in that case.
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::childSetupFunction): do not set LC_ALL environment variable explicitly,
the child process will already inherit the environment of the parent, which should
have all the variables set properly.
Conflicts:
configure.ac
- 11:02 AM WebKitGTK/2.0.x edited by
- (diff)
- 10:59 AM Changeset in webkit [145104] by
-
- 7 edits in trunk
Recalculate borders at the beginning of table layout
https://bugs.webkit.org/show_bug.cgi?id=111634
Reviewed by Julien Chaffraix.
Source/WebCore:
Doing it in convertStyleLogicalWidthToComputedWidth missed some dynamic
relayout cases. I confirmed that the new results match the results we
would get if we set the border width initially instead of dynamically.
- rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::layout):
LayoutTests:
- fast/table/border-collapsing/cached-change-row-border-width-expected.png:
- fast/table/border-collapsing/cached-change-row-border-width-expected.txt:
- fast/table/border-collapsing/cached-change-tbody-border-width-expected.png:
- fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt:
- 10:57 AM Changeset in webkit [145103] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: http/tests/css/shared-stylesheet-mutation-preconstruct.html
- 10:47 AM Changeset in webkit [145102] by
-
- 1 edit1 delete in trunk/Source/WebKit/chromium
[Chromium] Remove WK/chromium/public/WebWorkerRunLoop.h
https://bugs.webkit.org/show_bug.cgi?id=111740
Reviewed by James Robinson.
No longer needed; all references have been updated to new version
in top-level Platform/ directory.
- public/WebWorkerRunLoop.h: Removed.
- 10:45 AM Changeset in webkit [145101] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r186592. Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-07
- DEPS:
- 10:41 AM Changeset in webkit [145100] by
-
- 6 edits2 adds in trunk
Source/WebCore: border-fit-adjust should happen at layout time rather than paint time
https://bugs.webkit.org/show_bug.cgi?id=111606
<rdar://problem/13101714>
Reviewed by Antti Koivisto.
In order for border-fit-adjust to be accurate in more cases, it needs
to be a layout-time adjustment rather than a paint-time adjustment.
Specifically there are cases where an LTR adjusted box was right-aligned
by its container, and without genuinely shrinking the size of the box,
we end up chopping off the right edge but not shifting the box to the
right to compensate.
This patch changes border-fit-adjust to now do the adjustment using
the override width mechanism and a second layout pass instead of just
hacking painting.
Test: fast/block/border-fit-with-right-alignment.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
Calls fitBorderToLinesIfNeeded at the end of layout to do a second
layout pass if the adjustment needs to be made.
(WebCore::RenderBlock::fitBorderToLinesIfNeeded):
Renamed borderFitAdjust to fitBorderToLinesIfNeeded and made it
non-virtual, since it's no longer called from RenderBox code. Changed it
to do a relayout using override widths if an adjustment is needed.
- rendering/RenderBlock.h:
(RenderBlock):
Renamed borderFitAdjust to fitBorderToLinesIfNeeded and made it
non-virtual.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::paintMask):
Removed the paint-time border-fit adjustment.
(WebCore::RenderBox::computeLogicalWidthInRegion):
Use the override width when border-fit is set to lines.
- rendering/RenderBox.h:
(RenderBox):
Remove the virtual borderFitAdjust method.
LayoutTests: border-fit should happen at layout time rather than paint time
https://bugs.webkit.org/show_bug.cgi?id=111606
<rdar://problem/13101714>
Reviewed by Antti Koivisto.
- fast/block/border-fit-with-right-alignment-expected.html: Added.
- fast/block/border-fit-with-right-alignment.html: Added.
- 10:37 AM Changeset in webkit [145099] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Update some #includes for WebVideoFrame.h
https://bugs.webkit.org/show_bug.cgi?id=111739
Reviewed by James Robinson.
In anticipation of removing WebVideoFrame.h from WK/chromium/public/.
- public/WebMediaPlayer.h:
- 10:35 AM Changeset in webkit [145098] by
-
- 7 edits2 adds in trunk
REGRESSION(r143727): Clicking / selecting inside an <embed> is broken
https://bugs.webkit.org/show_bug.cgi?id=111217
Reviewed by Julien Chaffraix.
Source/WebCore:
Hit-testing into child frames need to happen in RenderPart, otherwise
we will miss frame views in <embed> and <object> elements.
Test: fast/dom/nodesFromRect/nodesFromRect-embedded-frame-content.html
- rendering/RenderFrameBase.cpp:
- rendering/RenderFrameBase.h:
(RenderFrameBase):
- rendering/RenderPart.cpp:
(WebCore::RenderPart::nodeAtPoint):
- rendering/RenderPart.h:
(RenderPart):
LayoutTests:
Test rect and point based hit-testing inside embed and object child frames.
- fast/dom/nodesFromRect/nodesFromRect-embedded-frame-content-expected.txt: Added.
- fast/dom/nodesFromRect/nodesFromRect-embedded-frame-content.html: Added.
- fast/dom/nodesFromRect/resources/nodesFromRect.js:
(checkPoint):
- 10:25 AM Changeset in webkit [145097] by
-
- 5 edits5 adds in trunk
FormData should allow setting filename to empty
https://bugs.webkit.org/show_bug.cgi?id=111687
Reviewed by Brady Eidson.
Tests: http/tests/local/formdata/send-form-data-with-empty-blob-filename.html
http/tests/local/formdata/send-form-data-with-empty-file-filename.html
- html/FileInputType.cpp: (WebCore::FileInputType::appendFormData): Use a Blob for empty file input, not a hacky File with empty path.
- platform/network/FormData.cpp: (WebCore::FormData::appendKeyValuePairItems): Missing value is a null string. If the string is empty, we should treat is as authoritative.
- 10:23 AM Changeset in webkit [145096] by
-
- 2 edits in trunk/Source/WebKit2
Null-check the page overlay before trying to use it.
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scroll):
- 10:17 AM Changeset in webkit [145095] by
-
- 2 edits in trunk/LayoutTests
inspector/debugger/debugger-expand-scope.html sometimes fails on Apple MountainLion Release WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=111754
Skipping this test so that Mac EWS can catch up.
- platform/mac/TestExpectations:
- 10:15 AM Changeset in webkit [145094] by
-
- 2 edits in branches/safari-534.59-branch/Source/WebKit2
<rdar://problem/13368674> - Bogus MESSAGE_CHECK in WebPageProxy::unavailablePluginButtonClicked
Rubberstamped by Alexey Proskuryakov.
I also checked all of my recent merges to make sure I didn't include any other MESSAGE_CHECKs in
lieu of MESSAGE_CHECK_URL.
I didn't.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::unavailablePluginButtonClicked):
- 10:12 AM Changeset in webkit [145093] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [CodeMirror] dublicated horizontal scroll
https://bugs.webkit.org/show_bug.cgi?id=111712
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-07
Reviewed by Pavel Feldman.
Set a box-sizing css property on all codemirror elements to
"content-box".
No new tests.
- inspector/front-end/cm/cmdevtools.css:
(.CodeMirror *):
- 10:03 AM Changeset in webkit [145092] by
-
- 2 edits in trunk/LayoutTests
Chromium, mac-wk2 and mac need new baselines after fixing paint phases for composited scrolling.
https://bugs.webkit.org/show_bug.cgi?id=107952
New baseline for Mac.
- platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- 9:58 AM Changeset in webkit [145091] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Remove WebView's sharedGraphicsContext3D method.
https://bugs.webkit.org/show_bug.cgi?id=111499
Reviewed by James Robinson.
- public/WebView.h:
(WebView):
- src/WebViewImpl.cpp:
- src/WebViewImpl.h:
(WebViewImpl):
- 9:39 AM Changeset in webkit [145090] by
-
- 14 edits in trunk/LayoutTests
Remove GC code duplication in http/tests LayoutTests.
https://bugs.webkit.org/show_bug.cgi?id=111589
Reviewed by Kentaro Hara, Alexey Proskuryakov.
Replaced duplicated GC logic in various tests with a function call to the implementation
in /js-test-resources/js-test-pre.js
- http/tests/appcache/destroyed-frame.html:
- http/tests/media/media-source/video-media-source-sourcebufferlist-crash.html:
- http/tests/misc/async-script.html:
- http/tests/misc/embed-image-load-outlives-gc-without-crashing.html:
- http/tests/misc/image-input-type-outlives-gc-without-crashing.html:
- http/tests/misc/image-load-outlives-gc-without-crashing.html:
- http/tests/misc/javascript-url-stop-loaders.html:
- http/tests/misc/object-image-load-outlives-gc-without-crashing.html:
- http/tests/misc/svg-image-load-outlives-gc-without-crashing.html:
- http/tests/misc/video-poster-image-load-outlives-gc-without-crashing.html:
- http/tests/security/detached-sandboxed-frame-access.html:
- http/tests/websocket/tests/hybi/websocket-pending-activity.html:
- http/tests/xmlhttprequest/event-listener-gc.html:
- 9:28 AM Changeset in webkit [145089] by
-
- 5 edits in branches/chromium/1410
Merge 144463
Web Inspector: [Regression] Snippets renaming is broken.
https://bugs.webkit.org/show_bug.cgi?id=111181
Reviewed by Alexander Pavlov.
Source/WebCore:
- inspector/front-end/NavigatorView.js:
- inspector/front-end/ScriptSnippetModel.js:
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.rename):
LayoutTests:
- inspector/debugger/script-snippet-model.html:
TBR=vsevik@chromium.org
BUG=179368
Review URL: https://codereview.chromium.org/12622003
- 9:23 AM Changeset in webkit [145088] by
-
- 1 edit in branches/chromium/1410/Source/WebCore/inspector/front-end/CPUProfileView.js
Merge 143438
Web Inspector: [Regression] Search in ProfilesPanel is broken
https://bugs.webkit.org/show_bug.cgi?id=110312
Reviewed by Pavel Feldman.
- inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileView.prototype.matchesQuery):
(WebInspector.CPUProfileView.prototype.performSearch):
TBR=vsevik@chromium.org
BUG=179316
Review URL: https://codereview.chromium.org/12626002
- 9:19 AM Changeset in webkit [145087] by
-
- 26 edits2 copies in branches/chromium/1410
Merge 144350
Focus ring for a child layer is incorrectly offset by ancestor composited layer's position
https://bugs.webkit.org/show_bug.cgi?id=110895
Reviewed by Simon Fraser.
Source/WebCore:
Test: compositing/sub-layer-focus-ring.html
The problem occurs in RenderBlock::addFocusRingRects() where the absolute position of a sub-layer is used to calculate the focus ring rect of the layer.
Should use the relative position to the current paintContainer instead.
To fix the issue:
- RenderLayer passes LayerPaintingInfo.rootLayer to PaintInfo.paintContainer
- Let RenderObject::paintFocusRing() and RenderObject::paintOutline() take PaintInfo instead of GraphicsContext* so that the paintContainer can be passed
- RenderBlock::addFocusRingRects() uses localToContainerPoint(FloatPoint(), paintContainer) instead of localToAbsolute() to calculate the focus ring rect of a sublayer.
- rendering/PaintInfo.h:
(WebCore):
(WebCore::PaintInfo::PaintInfo): Add a field paintContainer (the RenderLayerModelObject which originates the current painting)
(PaintInfo):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::paintContinuationOutlines):
(WebCore::RenderBlock::addFocusRingRects): Use the added paintContainer parameter to calculate the relative offset of the child layer.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintBackgroundForFragments): Pass LayerPaintingInfo.rootLayer to PaintInfo.paintContainer.
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase): Ditto.
(WebCore::RenderLayer::paintOutlineForFragments): Ditto.
(WebCore::RenderLayer::paintMaskForFragments): Ditto.
- rendering/RenderLayer.cpp:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::paintFocusRing): Now takes PaintInfo instead of GraphicsContext*. Pass paintInfo.paintContainer to addFocusRingRects().
(WebCore::RenderObject::paintOutline): Now takes PaintInfo instead of GraphicsContext*.
(WebCore::RenderObject::absoluteFocusRingQuads):
- rendering/RenderObject.h:
(WebCore::RenderObject::addFocusRingRects): Add paintContainer parameter.
LayoutTests:
New ref test for the bug.
- compositing/sub-layer-focus-ring-expected.html: Added.
- compositing/sub-layer-focus-ring.html: Added.
TBR=wangxianzhu@chromium.org
Review URL: https://codereview.chromium.org/12616003
- 9:15 AM Changeset in webkit [145086] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Styles sidebar pane toolbar disappears in horizontal split mode.
https://bugs.webkit.org/show_bug.cgi?id=111735
Reviewed by Pavel Feldman.
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._splitVertically):
- inspector/front-end/elementsPanel.css:
(.sidebar-pane.composite .metrics-and-computed .sidebar-pane-toolbar):
- 9:11 AM Changeset in webkit [145085] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] QWebSettings::clearMemoryCaches should clear JS garbage
https://bugs.webkit.org/show_bug.cgi?id=111094
Patch by Arunprasad Rajkumar <arunprasadr@nds.com> on 2013-03-07
Reviewed by Jocelyn Turcotte.
- Api/qwebsettings.cpp:
(QWebSettings::clearMemoryCaches):
- 8:58 AM Changeset in webkit [145084] by
-
- 10 edits in trunk
[GTK] Limit the supported compilers to GCC >= 4.7 and Clang >= 3.0
https://bugs.webkit.org/show_bug.cgi?id=109932
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-03-07
Reviewed by Martin Robinson.
.:
- Source/autotools/CheckSystemAndBasicDependencies.m4: Strictly check for one of the two compilers.
- Source/autotools/SetupCompilerFlags.m4: Set up C++11-specific compiler flags. Force the C99 standard for the C code.
Use the -Qunused-arguments flag when using Clang, it reduces irrelevant errors when using ccache.
Source/WebCore:
- GNUmakefile.am: Replace references to SYMBOL_VISIBILITY_INLINES and SYMBOL_VISIBILITY variables with the actual flags.
They are now available by default due to the limited set of supported compilers.
- bindings/gobject/GNUmakefile.am: Ditto.
Source/WebKit/gtk:
- GNUmakefile.am: Replace references to SYMBOL_VISIBILITY_INLINES and SYMBOL_VISIBILITY variables with the actual flags.
They are now available by default due to the limited set of supported compilers.
Source/WebKit2:
- GNUmakefile.am: Replace references to SYMBOL_VISIBILITY_INLINES and SYMBOL_VISIBILITY variables with the actual flags.
They are now available by default due to the limited set of supported compilers.
- 8:39 AM Changeset in webkit [145083] by
-
- 208 edits in trunk
XSSAuditor should send only one console error when blocking a page.
https://bugs.webkit.org/show_bug.cgi?id=110733
Reviewed by Daniel Bates.
Source/WebCore:
Currently, we send two console errors when XSSAuditor blocks a page:
"Refused to execute a JavaScript script. Source code of script found
within request.\n", and "Entire page will be blocked.".
We should only send one message, tuning it properly for the context, and
including the URL of the page effected by the XSSAuditor's work.
Covered by rebaselines of all the XSSAuditor and 'reflected-xss' tests.
- html/parser/XSSAuditor.cpp:
- html/parser/XSSAuditor.h:
(WebCore::XSSAuditor::XSSAuditor):
Add two booleans to track the headers used to set the XSSAuditor state.
(WebCore::XSSAuditor::init):
Save a copy of the document's URL even if we're not generating a
report upon violation: we'll need it for the console messages. Also
populate the didSendValidXXXHeader booleans for use later.
(WebCore::XSSAuditor::filterToken):
Add detail about the header status to the constructed XSSInfo object.
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::buildConsoleError):
Move message construction out into a separate inlined function, as
it's becoming complex.
(WebCore::XSSAuditorDelegate::didBlockScript):
Fold the "Entire page will be blocked" message into the main console
error.
- html/parser/XSSAuditorDelegate.h:
(WebCore::XSSInfo::create):
(WebCore::XSSInfo::XSSInfo):
Add detail about header status to XSSInfo in order to correctly
construct the console error.
LayoutTests:
- fast/frames/xss-auditor-handles-file-urls-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-unset-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-unset-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-unset-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-empty-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-filter-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reflected-xss-invalid-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL-expected.txt:
- http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt:
- http/tests/security/xssAuditor/base-href-control-char-expected.txt:
- http/tests/security/xssAuditor/base-href-expected.txt:
- http/tests/security/xssAuditor/base-href-null-char-expected.txt:
- http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
- http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt:
- http/tests/security/xssAuditor/block-does-not-leak-referrer-expected.txt:
- http/tests/security/xssAuditor/cached-frame-expected.txt:
- http/tests/security/xssAuditor/cookie-injection-expected.txt:
- http/tests/security/xssAuditor/dom-write-URL-expected.txt:
- http/tests/security/xssAuditor/dom-write-location-expected.txt:
- http/tests/security/xssAuditor/dom-write-location-inline-event-expected.txt:
- http/tests/security/xssAuditor/dom-write-location-javascript-URL-expected.txt:
- http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt:
- http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt:
- http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/embed-tag-expected.txt:
- http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
- http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
- http/tests/security/xssAuditor/formaction-on-button-expected.txt:
- http/tests/security/xssAuditor/formaction-on-input-expected.txt:
- http/tests/security/xssAuditor/form-action-expected.txt:
- http/tests/security/xssAuditor/full-block-base-href-expected.txt:
- http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
- http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
- http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt:
- http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
- http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
- http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-cross-domain-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
- http/tests/security/xssAuditor/get-from-iframe-expected.txt:
- http/tests/security/xssAuditor/iframe-injection-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt:
- http/tests/security/xssAuditor/iframe-javascript-url-url-encoded-expected.txt:
- http/tests/security/xssAuditor/iframe-onload-GBK-char-expected.txt:
- http/tests/security/xssAuditor/iframe-onload-in-svg-tag-expected.txt:
- http/tests/security/xssAuditor/iframe-srcdoc-expected.txt:
- http/tests/security/xssAuditor/img-onerror-GBK-char-expected.txt:
- http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt:
- http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding-expected.txt:
- http/tests/security/xssAuditor/img-onerror-non-ASCII-char-expected.txt:
- http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-default-encoding-expected.txt:
- http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-expected.txt:
- http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt:
- http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt:
- http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt:
- http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt:
- http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
- http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt:
- http/tests/security/xssAuditor/javascript-link-control-char-expected.txt:
- http/tests/security/xssAuditor/javascript-link-expected.txt:
- http/tests/security/xssAuditor/javascript-link-null-char-expected.txt:
- http/tests/security/xssAuditor/javascript-link-one-plus-one-expected.txt:
- http/tests/security/xssAuditor/javascript-link-url-encoded-expected.txt:
- http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt:
- http/tests/security/xssAuditor/link-onclick-control-char-expected.txt:
- http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
- http/tests/security/xssAuditor/link-onclick-expected.txt:
- http/tests/security/xssAuditor/link-onclick-null-char-expected.txt:
- http/tests/security/xssAuditor/link-opens-new-window-expected.txt:
- http/tests/security/xssAuditor/malformed-HTML-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-1-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-2-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-3-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-4-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-5-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-6-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-7-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-8-expected.txt:
- http/tests/security/xssAuditor/malformed-xss-protection-header-9-expected.txt:
- http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-expected.txt:
- http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
- http/tests/security/xssAuditor/object-tag-expected.txt:
- http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
- http/tests/security/xssAuditor/open-attribute-body-expected.txt:
- http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
- http/tests/security/xssAuditor/open-iframe-src-01-expected.txt:
- http/tests/security/xssAuditor/open-iframe-src-02-expected.txt:
- http/tests/security/xssAuditor/open-script-src-01-expected.txt:
- http/tests/security/xssAuditor/open-script-src-02-expected.txt:
- http/tests/security/xssAuditor/open-script-src-03-expected.txt:
- http/tests/security/xssAuditor/open-script-src-04-expected.txt:
- http/tests/security/xssAuditor/post-from-iframe-expected.txt:
- http/tests/security/xssAuditor/property-escape-comment-01-expected.txt:
- http/tests/security/xssAuditor/property-escape-comment-02-expected.txt:
- http/tests/security/xssAuditor/property-escape-comment-03-expected.txt:
- http/tests/security/xssAuditor/property-escape-entity-01-expected.txt:
- http/tests/security/xssAuditor/property-escape-entity-02-expected.txt:
- http/tests/security/xssAuditor/property-escape-entity-03-expected.txt:
- http/tests/security/xssAuditor/property-escape-expected.txt:
- http/tests/security/xssAuditor/property-escape-long-expected.txt:
- http/tests/security/xssAuditor/property-escape-quote-01-expected.txt:
- http/tests/security/xssAuditor/property-escape-quote-02-expected.txt:
- http/tests/security/xssAuditor/property-escape-quote-03-expected.txt:
- http/tests/security/xssAuditor/report-script-tag-expected.txt:
- http/tests/security/xssAuditor/report-script-tag-full-block-expected.txt:
- http/tests/security/xssAuditor/script-tag-Big5-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode-expected.txt:
- http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-expected.txt:
- http/tests/security/xssAuditor/script-tag-Big5-char2-expected.txt:
- http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt:
- http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt:
- http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt:
- http/tests/security/xssAuditor/script-tag-control-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-convoluted-expected.txt:
- http/tests/security/xssAuditor/script-tag-entities-expected.txt:
- http/tests/security/xssAuditor/script-tag-expected.txt:
- http/tests/security/xssAuditor/script-tag-inside-svg-tag-expected.txt:
- http/tests/security/xssAuditor/script-tag-inside-svg-tag2-expected.txt:
- http/tests/security/xssAuditor/script-tag-inside-svg-tag3-expected.txt:
- http/tests/security/xssAuditor/script-tag-null-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt:
- http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-post-expected.txt:
- http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-redirect-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode2-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode3-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode4-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-actual-comma-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-comma-01-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-comma-02-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-data-url-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-data-url2-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-data-url3-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-01-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-02-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-source-unterminated-03-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-trailing-comment5-expected.txt:
- http/tests/security/xssAuditor/svg-script-tag-expected.txt:
- http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt:
- http/tests/security/xssAuditor/xss-filter-bypass-long-string-expected.txt:
- http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-02-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
- http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
- platform/chromium/http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt:
- 8:28 AM Changeset in webkit [145082] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Add some more compilation annotations to NavigatorView
https://bugs.webkit.org/show_bug.cgi?id=111730
Reviewed by Alexander Pavlov.
- inspector/front-end/NavigatorView.js:
- 8:25 AM Changeset in webkit [145081] by
-
- 10 edits14 moves30 adds29 deletes in trunk
[GTK] Enable translations for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=111398
Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2013-03-07.
Reviewed by Martin Robinson.
- GNUmakefile.am: adjust path for i18n GNUmakefile.am.
- configure.ac: generate the i18n makefile unconditionally, the translations are
used by both WebKitGTK+ and WebKit2GTK+.
Source/WebCore:
- GNUmakefile.am: distribute po files.
- platform/gtk/po/POTFILES.in: adjust paths for translatable files.
Source/WebCore/platform/gtk/po:
- GNUmakefile.am: Renamed from Source/WebKit/gtk/po/GNUmakefile.am.
- POTFILES.in: Renamed from Source/WebKit/gtk/po/POTFILES.in.
- README: Renamed from Source/WebKit/gtk/po/README.
- ar.po: Renamed from Source/WebKit/gtk/po/ar.po.
- as.po: Renamed from Source/WebKit/gtk/po/as.po.
- bg.po: Renamed from Source/WebKit/gtk/po/bg.po.
- cs.po: Renamed from Source/WebKit/gtk/po/cs.po.
- de.po: Renamed from Source/WebKit/gtk/po/de.po.
- el.po: Renamed from Source/WebKit/gtk/po/el.po.
- en_CA.po: Renamed from Source/WebKit/gtk/po/en_CA.po.
- en_GB.po: Renamed from Source/WebKit/gtk/po/en_GB.po.
- eo.po: Renamed from Source/WebKit/gtk/po/eo.po.
- es.po: Renamed from Source/WebKit/gtk/po/es.po.
- et.po: Renamed from Source/WebKit/gtk/po/et.po.
- eu.po: Renamed from Source/WebKit/gtk/po/eu.po.
- fr.po: Renamed from Source/WebKit/gtk/po/fr.po.
- gl.po: Renamed from Source/WebKit/gtk/po/gl.po.
- gu.po: Renamed from Source/WebKit/gtk/po/gu.po.
- he.po: Renamed from Source/WebKit/gtk/po/he.po.
- hi.po: Renamed from Source/WebKit/gtk/po/hi.po.
- hu.po: Renamed from Source/WebKit/gtk/po/hu.po.
- id.po: Renamed from Source/WebKit/gtk/po/id.po.
- it.po: Renamed from Source/WebKit/gtk/po/it.po.
- ko.po: Renamed from Source/WebKit/gtk/po/ko.po.
- lt.po: Renamed from Source/WebKit/gtk/po/lt.po.
- lv.po: Renamed from Source/WebKit/gtk/po/lv.po.
- mr.po: Renamed from Source/WebKit/gtk/po/mr.po.
- nb.po: Renamed from Source/WebKit/gtk/po/nb.po.
- nl.po: Renamed from Source/WebKit/gtk/po/nl.po.
- pa.po: Renamed from Source/WebKit/gtk/po/pa.po.
- pl.po: Renamed from Source/WebKit/gtk/po/pl.po.
- pt.po: Renamed from Source/WebKit/gtk/po/pt.po.
- pt_BR.po: Renamed from Source/WebKit/gtk/po/pt_BR.po.
- ro.po: Renamed from Source/WebKit/gtk/po/ro.po.
- ru.po: Renamed from Source/WebKit/gtk/po/ru.po.
- sl.po: Renamed from Source/WebKit/gtk/po/sl.po.
- sr.po: Renamed from Source/WebKit/gtk/po/sr.po.
- sr@latin.po: Renamed from Source/WebKit/gtk/po/sr@latin.po.
- sv.po: Renamed from Source/WebKit/gtk/po/sv.po.
- uk.po: Renamed from Source/WebKit/gtk/po/uk.po.
- vi.po: Renamed from Source/WebKit/gtk/po/vi.po.
- zh_CN.po: Renamed from Source/WebKit/gtk/po/zh_CN.po.
Source/WebKit2:
- GNUmakefile.am: define PACKAGE_LOCALE_DIR when building WebProcess's main module.
- WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk): register the i18n domain name, and prefer UTF-8, since
we're GTK+; at the moment we're just using the same name as WebKitGTK+, pro: the
translation module can be reused, con: you can't have different versions of
WebKitGTK+ and WebKit2GTK+ installed, because the module would not be fit for reuse
in that case.
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::childSetupFunction): do not set LC_ALL environment variable explicitly,
the child process will already inherit the environment of the parent, which should
have all the variables set properly.
- 8:09 AM Changeset in webkit [145080] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [CodeMirror] update codemirror to version 3.1
https://bugs.webkit.org/show_bug.cgi?id=111711
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-07
Reviewed by Vsevolod Vlasov.
Update code mirror experimental editor to version 3.1
No new tests.
- inspector/front-end/cm/codemirror.css:
(.CodeMirror div.CodeMirror-cursor):
(.CodeMirror div.CodeMirror-secondarycursor):
(.CodeMirror.cm-keymap-fat-cursor div.CodeMirror-cursor):
(.CodeMirror.cm-keymap-fat-cursor div.CodeMirror-cursor:not(#nonsense_id)):
(.CodeMirror div.CodeMirror-cursor.CodeMirror-overwrite):
(.CodeMirror-gutters):
(.CodeMirror-linewidget):
(.CodeMirror-widget):
(.CodeMirror-focused div.CodeMirror-cursor):
(@media print):
- inspector/front-end/cm/codemirror.js:
(window.CodeMirror):
(window.CodeMirror.):
- 7:54 AM Changeset in webkit [145079] by
-
- 2 edits in trunk/Source/WebCore
OpenGLShims: fix check for ANGLE GLES2 extensions
https://bugs.webkit.org/show_bug.cgi?id=111656
Patch by Sergio Correia <Sergio Correia> on 2013-03-07
Reviewed by Simon Hausmann.
The check for ANGLE GLES2 extensions is currently being overriden
with checks for APPLE extensions in lookupOpenGLFunctionAddress().
No new tests. No user visible behavior changed.
- platform/graphics/OpenGLShims.cpp:
(WebCore::lookupOpenGLFunctionAddress):
- 7:43 AM Changeset in webkit [145078] by
-
- 2 edits in trunk/Source/WebCore
Rename visible_units.h to VisibleUnits.h in WebCore.vcxproj.filters
<http://webkit.org/b/111426>
- WebCore.vcxproj/WebCore.vcxproj.filters: Rename visible_units.h
to VisibleUnits.h and re-sort.
- 7:36 AM Changeset in webkit [145077] by
-
- 5 edits in trunk/Source
Web Inspector: Support a shortcut for reloading front-end in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=111709
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/buildSystemOnly.js:
- inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
Source/WebKit/chromium:
- src/js/DevTools.js:
- 7:35 AM Changeset in webkit [145076] by
-
- 11 edits in trunk/Source/WebCore
Web Inspector: Support setting up file system mappings from scripts panel context menu.
https://bugs.webkit.org/show_bug.cgi?id=111583
Reviewed by Pavel Feldman.
Added context menu items to set up network - file system mappings from sources panel.
Implemented mapping add/remove methods on Workspace.
Added a dialog suggesting to reload front-end after making such changes.
- English.lproj/localizedStrings.js:
- inspector/front-end/FileSystemMapping.js:
(WebInspector.FileSystemMappingImpl.prototype.fileSystemPath):
- inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemRemoved):
(WebInspector.FileSystemWorkspaceProvider.prototype.fileSystemPath):
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype.onEnter):
(WebInspector.FilteredItemSelectionDialog.prototype.setQuery):
(WebInspector.SelectUISourceCodeDialog):
(WebInspector.SelectUISourceCodeDialog.prototype.uiSourceCodeSelected):
(WebInspector.SelectUISourceCodeDialog.prototype.filterProject):
(WebInspector.SelectUISourceCodeDialog.prototype.filterUISourceCode):
(WebInspector.SelectUISourceCodeDialog.prototype.selectItem):
(WebInspector.SelectUISourceCodeDialog.prototype._uiSourceCodeAdded):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.prototype.uiSourceCodeSelected):
(WebInspector.OpenResourceDialog.prototype.filterProject):
(WebInspector.SelectUISourceCodeForProjectTypeDialog):
(WebInspector.SelectUISourceCodeForProjectTypeDialog.prototype.uiSourceCodeSelected):
(WebInspector.SelectUISourceCodeForProjectTypeDialog.prototype.filterProject):
(WebInspector.SelectUISourceCodeForProjectTypeDialog.show):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._mapFileSystemToNetwork.mapFileSystemToNetwork):
(WebInspector.ScriptsPanel.prototype._mapFileSystemToNetwork):
(WebInspector.ScriptsPanel.prototype._removeNetworkMapping):
(WebInspector.ScriptsPanel.prototype._mapNetworkToFileSystem.mapNetworkToFileSystem):
(WebInspector.ScriptsPanel.prototype._mapNetworkToFileSystem):
(WebInspector.ScriptsPanel.prototype.):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeMappingItems):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
- inspector/front-end/SettingsScreen.js:
(WebInspector.WorkspaceSettingsTab):
(WebInspector.WorkspaceSettingsTab.prototype.wasShown):
(WebInspector.WorkspaceSettingsTab.prototype._reset):
- inspector/front-end/ViewportControl.js:
(WebInspector.ViewportControl.prototype.refresh):
- inspector/front-end/Workspace.js:
(WebInspector.Workspace.prototype.addMapping):
(WebInspector.Workspace.prototype.removeMapping):
- inspector/front-end/externs.js:
(WebInspector.suggestReload):
- inspector/front-end/inspector.js:
(WebInspector.suggestReload):
- 7:32 AM Changeset in webkit [145075] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Add support for frontend reloading
https://bugs.webkit.org/show_bug.cgi?id=111727
Reviewed by Pavel Feldman.
This patch adds support for frontend reloading including:
- making sure no messages are sent to backend once frontend started reloading
- updating frontend url with up-to-date dockSide query parameter value.
- inspector/front-end/InspectorBackend.js:
(InspectorBackendClass.prototype.sendMessageObjectToBackend):
(InspectorBackendClass.prototype.disconnect):
- inspector/front-end/externs.js:
(WebInspector.reload):
- inspector/front-end/inspector.js:
(WebInspector.reload):
- 7:28 AM Changeset in webkit [145074] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Change profile start button caption depending on profile type.
https://bugs.webkit.org/show_bug.cgi?id=111698
Change the start profiling button caption to "Snapshot" for
snapshot-like profile types, e.g. JS heap snapshot, native memory snapshot.
Patch by Alexei Filippov <alph@chromium.org> on 2013-03-07
Reviewed by Yury Semikhatsky.
- English.lproj/localizedStrings.js:
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotProfileType.prototype.isInstantProfile):
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeSnapshotProfileType.prototype.isInstantProfile):
(WebInspector.NativeMemoryProfileType.prototype.isInstantProfile):
- inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView):
(WebInspector.ProfileLauncherView.prototype.addProfileType):
(WebInspector.ProfileLauncherView.prototype._updateControls):
(WebInspector.MultiProfileLauncherView.prototype._updateControls):
(WebInspector.MultiProfileLauncherView.prototype._profileTypeChanged):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileType.prototype.isInstantProfile):
- 7:25 AM Changeset in webkit [145073] by
-
- 3 edits in trunk/Source/WebCore
[texmap] Remove direct access to clip state from clip stack
https://bugs.webkit.org/show_bug.cgi?id=111630
Reviewed by Allan Sandfeld Jensen.
As we are now monitoring the clip state from
TextureMapperGL/BitmapTextureGL, have direct access to clip state object
would eventually make it dirty without properly setting the
'clipStateDirty' flag. This bug intends to substitute direct access with
auxiliary functions which would set the clip state dirty when necessary.
No new tests. No user visible behavior changed.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::ClipStack::intersect):
(WebCore::TextureMapperGL::ClipStack::setStencilIndex):
(WebCore::TextureMapperGL::drawBorder):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::beginScissorClip):
(WebCore::TextureMapperGL::beginClip):
Replaced direct access with auxiliary functions.
- platform/graphics/texmap/TextureMapperGL.h:
(ClipStack): Removed ClipStack::current() function.
(WebCore::TextureMapperGL::ClipStack::getStencilIndex): Added.
(WebCore::TextureMapperGL::ClipStack::isCurrentScissorBoxEmpty): Added.
- 7:20 AM Changeset in webkit [145072] by
-
- 2 edits in trunk/Tools
[chromium] don't track the top loading frame if no layout test is currently running
https://bugs.webkit.org/show_bug.cgi?id=111716
Reviewed by Kentaro Hara.
In DRT, we synchronously stop the test and start loading the next test
URL. However, in content_shell, this happens asynchronously. It's
important that the top loading frame is not changed due to stray
navigation events before the next test starts.
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::setTopLoadingFrame):
- 6:23 AM Changeset in webkit [145071] by
-
- 3 edits in trunk/Source/WebCore
[Texturemapper] transform-style 'flat' value is broken
https://bugs.webkit.org/show_bug.cgi?id=111566
Reviewed by Allan Sandfeld Jensen.
After changes from r144290, the CSS3 'transform-styles' property, when
used with 'flat' value, resulted in non-stenciled rendering inside
clipped area - vide example from Surfin' Safari blog:
https://www.webkit.org/blog-files/3d-transforms/transform-style.html
This patch forces the clip state to be applied when binding the default
surface.
No new tests. No user visible behavior changed.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::ClipStack::apply):
(WebCore::TextureMapperGL::ClipStack::applyIfNeeded): Added.
Moved state cache check from apply() to applyIfNeeded().
(WebCore::BitmapTextureGL::clearIfNeeded):
(WebCore::BitmapTextureGL::bind):
(WebCore::TextureMapperGL::beginScissorClip):
(WebCore::TextureMapperGL::beginClip):
(WebCore::TextureMapperGL::endClip):
- platform/graphics/texmap/TextureMapperGL.h:
(ClipStack):
Use applyIfNeeded() to check for clip state before clipping.
- 6:22 AM Changeset in webkit [145070] by
-
- 4 edits in trunk/Source/WebKit/gtk
[GTK] Expose "ShouldRespectImageOrientation" setting into WebKitWebSettings
https://bugs.webkit.org/show_bug.cgi?id=111414
Patch by Tomas Popela <tpopela@redhat.com> on 2013-03-07
Reviewed by Carlos Garcia Campos.
We should expose ShouldRespectImageOrientation setting into
WebKitWebSettings. When it is enabled, the images are shown with right
orientation regarding to images EXIF data.
- webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
- webkit/webkitwebsettingsprivate.h:
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
- 6:22 AM Changeset in webkit [145069] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: refactoring: move TextEditorModel.Indent enum into TextUtils
https://bugs.webkit.org/show_bug.cgi?id=111715
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-07
Reviewed by Pavel Feldman.
Move WebInspector.TextEditorModel.Indent into WebInspector.TextUtils namespace.
No new tests: no change in behaviour.
- inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
- inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):
- inspector/front-end/TextUtils.js:
- 6:17 AM Changeset in webkit [145068] by
-
- 2 edits in trunk/Source/WebKit/chromium
Web Inspector: Add more diagnostics output to testRendererProcessNativeMemorySize
https://bugs.webkit.org/show_bug.cgi?id=111599
Patch by Alexei Filippov <alph@chromium.org> on 2013-03-07
Reviewed by Yury Semikhatsky.
Add the process size to the test output.
- src/js/Tests.js:
- 6:00 AM Changeset in webkit [145067] by
-
- 16 edits5 adds in trunk
Fix painting phases for composited scrolling
https://bugs.webkit.org/show_bug.cgi?id=107618
Reviewed by Simon Fraser.
With composited scrolling, the scrolling contents layer paints the
foreground and the main graphics layer paints the background. This
causes a few problems:
1) If we create a foreground layer, we end up with two layers painting
the foreground phase.
2) Focus rings / outlines paint into the foreground layer, so they end
up moving around with the scrolling contents.
3) Neg z-order descendants paint in the the main graphics layer and
will therefore not scroll.
To deal with 1) we need to stop painting the foreground into both the
foreground and scrolling contents layers. We also need to ensure that
the foreground layer is the right size and has the right offset from
renderer if we're on the composited scrolling path.
To deal with 2) and 3), I have added a new graphics layer painting phase
flag -- GraphicsLayerPaintCompositedScroll -- and applied it to two
layers in the subtree created by RenderLayerBacking. This ultimately
affects the paint phase passed to RenderLayer::paintLayerContents and
allows us to paint the focus rings, outlines and negative z-order
descendants into the proper layers.
Source/WebCore:
Tests: compositing/overflow/composited-scrolling-paint-phases.html
compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents.html
compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer.html
- page/Frame.h: Added a flag for including painting phases in the layer tree dump.
(WebCore::GraphicsLayer::dumpProperties):
Can now dump painting phase information, but only if requested.
- platform/graphics/GraphicsLayerClient.h: Added a new entry to GraphicsLayerPaintingPhaseFlags for comp-scroll.
(WebCore::RenderLayer::paintLayerContents):
Updated the logic to account for the new comp-scroll-related paint
phase flag.
- rendering/RenderLayer.h: Added the RenderLayer painting phase counterpart to GraphicsLayerPaintCompositedScroll.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
Ensures that the foreground layer is sized correctly for comp-scroll.
(WebCore::RenderLayerBacking::updateScrollingLayers):
If we have a foreground layer, the scrolling contents layer no
longer gets assigned the foreground painting phase.
(WebCore::RenderLayerBacking::paintingPhaseForPrimaryLayer):
If we're comp-scrolling, then the primary layer gets the new phase.
(WebCore::RenderLayerBacking::paintIntoLayer):
Simply translates the new graphics layer painting phase to its
render layer counterpart.
(WebCore::RenderLayerCompositor::layerTreeAsText):
- testing/Internals.cpp:
(WebCore::Internals::layerTreeAsText):
- testing/Internals.h:
- testing/Internals.idl: The above changes are solely plumbing to allow layout tests to request that paint phase information be included in the layer tree dump.
LayoutTests:
- compositing/overflow/composited-scrolling-paint-phases-expected.txt: Added.
- compositing/overflow/composited-scrolling-paint-phases.html: Added.
- platform/mac/compositing/overflom/composited-scrolling-paint-phases-expected.txt: Added. This is a text-based test that checks that the graphics layer painting phases are correct with composited scrolling + foreground layers.
- compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents.html: Added.
- compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer.html: Added. These tests cover cases 2) and 3) above.
- platform/chromium/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations: These have been updated to reflect the missing baselines.
- 5:52 AM Changeset in webkit [145066] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Use Qt5.1 supportedMimeTypes methods.
https://bugs.webkit.org/show_bug.cgi?id=111185
Reviewed by Jocelyn Turcotte.
Uses the supportedMimeTypes() methods from QImageReader and QImageWriter when available.
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):
- 5:36 AM Changeset in webkit [145065] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Flame Chart. Stick item color to the function.
https://bugs.webkit.org/show_bug.cgi?id=111697
Reviewed by Yury Semikhatsky.
Different nodes associated with a single function have to use the same color.
Minor polish: do not filter out (idle) and (program) items. They were big due to an error on v8 side.
Set minimum width to 0 for more precise picture.
- inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._rootNodes):
(WebInspector.FlameChart.prototype.draw):
(WebInspector.FlameChart.prototype._drawNode):
(WebInspector.FlameChart.prototype._drawBar):
- 4:55 AM Changeset in webkit [145064] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [ACE] gutter size should be fixed.
https://bugs.webkit.org/show_bug.cgi?id=111576
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-07
Reviewed by Pavel Feldman.
Add a custom ace editor build that supports setFixedGutterWidth configuration
parameter and switch this setting on.
No new tests.
- inspector/front-end/AceTextEditor.js:
(WebInspector.AceTextEditor): Switch fixedGutterWidth setting on.
- inspector/front-end/ace/ace.js:
(.):
- 4:34 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:15 AM Changeset in webkit [145063] by
-
- 1 copy in releases/WebKitGTK/webkit-1.11.91
Tagging the WebKitGTK+ 1.11.91 release
- 3:52 AM Changeset in webkit [145062] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0
Unreviewed. Update NEWS and Versions.m4 for 1.11.91 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 1.11.91.
- 3:49 AM Changeset in webkit [145061] by
-
- 15 edits4 deletes in trunk/Source/WebCore
Unreviewed, rolling out r145059.
http://trac.webkit.org/changeset/145059
https://bugs.webkit.org/show_bug.cgi?id=111707
crash webkit build (Requested by tasak on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-07
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
- css/DocumentRuleSets.cpp:
(WebCore::ShadowDistributedRules::collectMatchRequests):
- css/DocumentRuleSets.h:
- css/ElementRuleCollector.cpp: Removed.
- css/ElementRuleCollector.h: Removed.
- css/PageRuleCollector.cpp: Removed.
- css/PageRuleCollector.h: Removed.
- css/StyleResolver.cpp:
(WebCore::leftToRightDeclaration):
(WebCore):
(WebCore::rightToLeftDeclaration):
(WebCore::StyleResolver::State::ensureRuleList):
(WebCore::StyleResolver::State::clear):
(WebCore::StyleResolver::addMatchedProperties):
(WebCore::StyleResolver::addElementStyleProperties):
(MatchingUARulesScope):
(WebCore::MatchingUARulesScope::MatchingUARulesScope):
(WebCore::MatchingUARulesScope::~MatchingUARulesScope):
(WebCore::MatchingUARulesScope::isMatchingUARules):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::compareRules):
(WebCore::StyleResolver::sortMatchedRules):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::State::initForStyleResolve):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):
(WebCore::comparePageRules):
(WebCore::StyleResolver::matchPageRules):
(WebCore::checkPageSelectorComponents):
(WebCore::StyleResolver::matchPageRulesForList):
(WebCore::StyleResolver::isLeftPage):
(WebCore::StyleResolver::isFirstPage):
(WebCore::StyleResolver::pageName):
- css/StyleResolver.h:
(WebCore::MatchRequest::MatchRequest):
(MatchRequest):
(StyleResolver):
(MatchResult):
(WebCore::StyleResolver::State::State):
(State):
(WebCore::StyleResolver::State::takeRuleList):
(WebCore::StyleResolver::State::setSameOriginOnly):
(WebCore::StyleResolver::State::isSameOriginOnly):
(WebCore::StyleResolver::State::pseudoStyleRequest):
(WebCore::StyleResolver::State::setMode):
(WebCore::StyleResolver::State::mode):
(WebCore::StyleResolver::State::matchedRules):
(WebCore::StyleResolver::State::addMatchedRule):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willMatchRule):
- inspector/InspectorCSSAgent.h:
(WebCore):
(InspectorCSSAgent):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willMatchRuleImpl):
- inspector/InspectorInstrumentation.h:
(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willMatchRule):
- 3:43 AM Changeset in webkit [145060] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Rebaselined run-bindings-tests.
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
- 3:19 AM Changeset in webkit [145059] by
-
- 15 edits4 copies in trunk/Source/WebCore
[Refactoring] Implement RuleCollector
https://bugs.webkit.org/show_bug.cgi?id=109916
Reviewed by Antti Koivisto.
Implemented rule collector for an element and collector for a page.
Not all members in class State are required entire while resolving
a style.
No new tests, because just refactoring.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
Added ElementRuleCollector and PageRuleCollector.
- css/DocumentRuleSets.cpp:
(WebCore::ShadowDistributedRules::collectMatchRequests):
Since behaviorAtBoundary is a state owned by ElementRuleCollector,
removed from here.
- css/DocumentRuleSets.h:
(WebCore::ShadowDistributedRules::isEmpty):
Added to quickly check whether there exist any ShadowDistributedRules
or not.
- css/ElementRuleCollector.cpp: Copied from Source/WebCore/css/StyleResolver.cpp.
(WebCore):
(WebCore::ElementRuleCollector::matchedResult):
(WebCore::ElementRuleCollector::matchedRuleList):
(WebCore::ElementRuleCollector::addMatchedRule):
(WebCore::ElementRuleCollector::clearMatchedRules):
(WebCore::ElementRuleCollector::ensureRuleList):
(WebCore::ElementRuleCollector::addElementStyleProperties):
(WebCore::ElementRuleCollector::collectMatchingRules):
(WebCore::ElementRuleCollector::collectMatchingRulesForRegion):
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
(WebCore::ElementRuleCollector::matchScopedAuthorRules):
(WebCore::ElementRuleCollector::matchHostRules):
(WebCore::ElementRuleCollector::matchShadowDistributedRules):
(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchUserRules):
(WebCore::ElementRuleCollector::matchUARules):
(WebCore::ElementRuleCollector::ruleMatches):
(WebCore::ElementRuleCollector::collectMatchingRulesForList):
(WebCore::ElementRuleCollector::sortMatchedRules):
(WebCore::ElementRuleCollector::matchAllRules):
Moved these methods from StyleResolver to this class.
(WebCore::ElementRuleCollector::hasAnyMatchingRules):
This method is used for checking whether a given element can share
a cache.
- css/ElementRuleCollector.h: Copied from Source/WebCore/css/StyleResolver.h.
(WebCore):
(WebCore::ElementRuleCollector::ElementRuleCollector):
Use styleResolver instance to initialize its member variables, i.e.
SelectorFilter, RuleSets, InspectorCSSOMWrappers, and
StyleScopedResolver.
(ElementRuleCollector):
(WebCore::ElementRuleCollector::setMode):
(WebCore::ElementRuleCollector::setPseudoStyleRequest):
(WebCore::ElementRuleCollector::setSameOriginOnly):
(WebCore::ElementRuleCollector::setRegionForStyling):
Mode, SameOriginOnly, RegionForStyling are only used while collecting
matched rules.
(WebCore::ElementRuleCollector::setMedium):
Need to know which default stylesheet should be looked up.
(WebCore::ElementRuleCollector::document):
- css/PageRuleCollector.cpp: Copied from Source/WebCore/css/StyleResolver.cpp.
(WebCore::comparePageRules):
(WebCore::PageRuleCollector::isLeftPage):
(WebCore::PageRuleCollector::isFirstPage):
(WebCore::PageRuleCollector::pageName):
(WebCore::PageRuleCollector::matchAllPageRules):
(WebCore::PageRuleCollector::matchPageRules):
(WebCore::checkPageSelectorComponents):
(WebCore::PageRuleCollector::matchPageRulesForList):
Moved from StyleResolver.
- css/PageRuleCollector.h: Copied from Source/WebCore/css/StyleResolver.h.
(WebCore):
(WebCore::PageRuleCollector::PageRuleCollector):
(PageRuleCollector):
(WebCore::PageRuleCollector::matchedResult):
- css/StyleResolver.cpp:
(WebCore):
(WebCore::StyleResolver::State::clear):
(WebCore::StyleResolver::MatchResult::addMatchedProperties):
(WebCore::StyleResolver::State::initForStyleResolve):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::applyMatchedProperties):
- css/StyleResolver.h:
(WebCore::MatchRequest::MatchRequest):
Removed behaviorAtBoundary. Instead, ElementRuleCollector have the
state.
(MatchRequest):
(WebCore::StyleResolver::selectorFilter):
Added to obtain SelectorFilter in ElementRuleCollector's constructor.
(StyleResolver):
(MatchResult):
(WebCore::StyleResolver::State::State):
To pass ASSERT in StyleResolver::applyProperties, need to keep
m_regionForStyling.
(State):
(WebCore::StyleResolver::State::regionForStyling):
(WebCore::StyleResolver::State::useSVGZoomRules):
(WebCore::StyleResolver::hasSelectorForId):
(WebCore):
(WebCore::checkRegionSelector):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willMatchRule):
Removed StyleResolver from its parameter list. Instead, added
InspectorCSSOMWrappers and DocumentStyleSheetCollection.
- inspector/InspectorCSSAgent.h:
(WebCore):
(InspectorCSSAgent):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willMatchRuleImpl):
- inspector/InspectorInstrumentation.h:
(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willMatchRule):
- 2:41 AM Changeset in webkit [145058] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [ACE] add experimental breakpoint support
https://bugs.webkit.org/show_bug.cgi?id=111573
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-07
Reviewed by Pavel Feldman.
No new tests.
- Implement attributes model for ace editor. Update attribute
locations by handling onTextChange event from editor.
- Implement breakpoints atop of attributes model.
- inspector/front-end/AceTextEditor.js:
(WebInspector.AceTextEditor):
(WebInspector.AceTextEditor.prototype._updateBreakpoints):
(WebInspector.AceTextEditor.prototype._updateLineAttributes):
(WebInspector.AceTextEditor.prototype._onTextChange):
(WebInspector.AceTextEditor.prototype.addBreakpoint):
(WebInspector.AceTextEditor.prototype.removeBreakpoint):
(WebInspector.AceTextEditor.prototype.getAttribute):
(WebInspector.AceTextEditor.prototype.setAttribute):
(WebInspector.AceTextEditor.prototype.removeAttribute):
- inspector/front-end/ace/acedevtools.css:
(.ace-editor-container):
(.ace_gutter-cell.webkit-breakpoint):
(.ace_gutter-cell.webkit-breakpoint-conditional):
(.ace_gutter-cell.webkit-breakpoint-disabled):
(.ace_gutter-cell):
- 2:39 AM Changeset in webkit [145057] by
-
- 9 edits2 adds in trunk
Web Inspector: identify layers for CSS generated content in LayerTreeAgent
https://bugs.webkit.org/show_bug.cgi?id=111551
Source/WebCore:
Layers can be associated with pseudo elements, elements that are generated
when ::before or ::after pseudo-classes are used to style an element and
provide additional rendering using the CSS "content" property. In order to
identify that a layer is associated to a pseudo element, we add a new set of
optional properties on the Layer object: "isGeneratedContent", "pseudoElementId"
and "pseudoClass".
We need to provide the "pseudoElementId" for the same reason we provide a
"nodeId" for the Layer. This is so that the front-end can identify that a
layer whose "layerId" may have changed between two layer tree updates is
used to render content for the same pseudo element.
In the instance that a layer is rendering generated content, we also set
the "nodeId" to be the generating node's id. The generating node is the
node in the DOM that the user styled using ::before or ::after pseudo-classes.
We also add the pseudo-class used as the "pseudoClass" property such that the
front-end may provide useful information to the user about what type of
pseudo-class yielded the generation of this layer. We also deal with the
possibility that the layer is a reflection for a pseudo element.
Since pseudo elements are not part of the user-visible DOM, and thus can't be
pushed to the front-end, we maintain a special ID hash map in the LayerTreeAgent.
In order to be able to unbind a pseudo element id and a pseudo element, we add a
destructor method to PseudoElement and provide a new instrumentation call so that
the LayerTreeAgent may be notified of a PseudoElement being destroyed. This
reflects the principle we use to update the RenderLayer bindings when a
RenderLayer is destroyed, as notified by the RenderLayerCompositor.
Reviewed by Simon Fraser.
Test: inspector-protocol/layers/layers-generated-content.html
- dom/PseudoElement.cpp:
(WebCore::PseudoElement::~PseudoElement): New destructor used to notify
InspectorInstrumentation of a PseudoElement being destroyed, such that
it can eventually be relayed to the InspectorLayerTreeAgent.
(WebCore):
- dom/PseudoElement.h:
(PseudoElement):
- inspector/Inspector.json: Add the new PseudoElementId type used for
the new "pseudoElementId" property on Layer, to which we also add the
"isGeneratedContent" and "pseudoClass" properties.
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::pseudoElementDestroyedImpl):
- inspector/InspectorInstrumentation.h:
(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::pseudoElementDestroyed): New method
called in the PseudoElement destructor used to relay the fact that a
PseudoElement was destroyed to the InspectorLayerTreeAgent.
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::reset): Clear the new PseudoElement
identifier maps.
(WebCore::InspectorLayerTreeAgent::pseudoElementDestroyed): Remove any
identifier binding for the provided PseudoElement being destroyed.
(WebCore):
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer): Set the new
"isGeneratedContent", "pseudoElementId" and "pseudoClass" properties on
the Layer object for layers associated with a pseudo element.
(WebCore::InspectorLayerTreeAgent::bind): Use emptyString() instead of "".
(WebCore::InspectorLayerTreeAgent::unbind): Use an iterator instead of a
get() and remove() combination in order to reduce lookups and mimick the
code written for unbindPseudoElement().
(WebCore::InspectorLayerTreeAgent::bindPseudoElement): Binds the provided
PseudoElement to a unique identifier.
(WebCore::InspectorLayerTreeAgent::unbindPseudoElement): Unbinds the
provided PseudoElement from its unique identifier.
- inspector/InspectorLayerTreeAgent.h:
(InspectorLayerTreeAgent):
LayoutTests:
New tests for layers associated with pseudo elements.
Reviewed by Simon Fraser.
- inspector-protocol/layers/layers-generated-content-expected.txt: Added.
- inspector-protocol/layers/layers-generated-content.html: Added.
- 2:08 AM Changeset in webkit [145056] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardneing. Skipped some failing tests.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt/TestExpectations:
- 2:06 AM Changeset in webkit [145055] by
-
- 29 edits13 adds in trunk
Add clear button to date/time input types
https://bugs.webkit.org/show_bug.cgi?id=111319
Reviewed by Kent Tamura.
Source/WebCore:
We want to remove the clear button from the calendar picker (Bug 109439)
so we are adding the clear button to the right side of the input element.
Tests: fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-change-and-input-events.html
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-change-and-input-events.html
fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-change-and-input-events.html
fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-change-and-input-events.html
fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-change-and-input-events.html
- CMakeLists.txt: Added ClearButtonElement.cpp
- GNUmakefile.list.am: Ditto.
- Target.pri: Ditto.
- WebCore.gypi: Ditto.
- WebCore.vcproj/WebCore.vcproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- css/html.css:
(input::-webkit-clear-button): Styles for the clear button.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::editControlValueChanged):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::BaseMultipleFieldsDateAndTimeInputType):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::~BaseMultipleFieldsDateAndTimeInputType):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::destroyShadowSubtree):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::disabledAttributeChanged):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::requiredAttributeChanged): Hide clear button if the value is required.
(WebCore):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::readonlyAttributeChanged):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::focusAndSelectClearButtonOwner): Called on mouse down on clear button.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::shouldClearButtonRespondToMouseEvents):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::clearValue):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateClearButtonVisibility): We want to hide the clear button if the value is required or the value is empty.
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateClearButtonVisibility):
(WebCore):
(WebCore::HTMLInputElement::requiredAttributeChanged):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/InputType.cpp:
(WebCore::InputType::requiredAttributeChanged): Notifies the InputType that the required attribute has changed.
(WebCore):
(WebCore::InputType::updateClearButtonVisibility):
- html/InputType.h:
(InputType):
- html/shadow/ClearButtonElement.cpp: Added.
(WebCore):
(WebCore::ClearButtonElement::ClearButtonElement):
(WebCore::ClearButtonElement::create):
(WebCore::ClearButtonElement::detach):
(WebCore::ClearButtonElement::releaseCapture): Stop capturing mouse events.
(WebCore::ClearButtonElement::defaultEventHandler):
- html/shadow/ClearButtonElement.h: Added.
(WebCore):
(ClearButtonElement):
(ClearButtonOwner):
(WebCore::ClearButtonElement::ClearButtonOwner::~ClearButtonOwner):
(WebCore::ClearButtonElement::removeClearButtonOwner):
(WebCore::ClearButtonElement::isMouseFocusable):
LayoutTests:
- fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-change-and-input-events-expected.txt: Added.
- fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-change-and-input-events.html: Added.
- fast/forms/date-multiple-fields/date-multiple-fields-mouse-events-expected.txt:
- fast/forms/date-multiple-fields/date-multiple-fields-mouse-events.html:
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-change-and-input-events-expected.txt: Added.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-change-and-input-events.html: Added.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events-expected.txt:
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events.html:
- fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-change-and-input-events-expected.txt: Added.
- fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-change-and-input-events.html: Added.
- fast/forms/month-multiple-fields/month-multiple-fields-mouse-events-expected.txt:
- fast/forms/month-multiple-fields/month-multiple-fields-mouse-events.html:
- fast/forms/resources/common-clearbutton-change-and-input-events.js: Added.
(.testInput.onchange):
(.testInput.oninput):
(testClearButtonChangeAndInputEvents):
- fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-change-and-input-events-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-change-and-input-events.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-mouse-events-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-mouse-events.html:
- fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll.html:
- fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-change-and-input-events-expected.txt: Added.
- fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-change-and-input-events.html: Added.
- fast/forms/week-multiple-fields/week-multiple-fields-mouse-events-expected.txt:
- fast/forms/week-multiple-fields/week-multiple-fields-mouse-events.html:
- platform/chromium/TestExpectations:
- 1:49 AM Changeset in webkit [145054] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Refactorings: Prepare SuggestBox for reuse.
https://bugs.webkit.org/show_bug.cgi?id=111301
Reviewed by Alexander Pavlov.
1) Remove userEnteredText from delegate interface.
Pass prefix to updateSuggestions instead.
2) Clarify that suggestions array is never null.
- inspector/front-end/SuggestBox.js:
(WebInspector.SuggestBox): Renamed parameter/member.
(WebInspector.SuggestBox.prototype._updateItems):
Minor readability changes.
(WebInspector.SuggestBox.prototype._canShowBox):
Use userEnteredText parameter.
(WebInspector.SuggestBox.prototype.updateSuggestions):
Pass userEnteredText to _canShowBox.
- inspector/front-end/DatabaseQueryView.js: Fix JSDocs.
- inspector/front-end/RuntimeModel.js: Ditto.
- inspector/front-end/TextPrompt.js: Ditto.
(WebInspector.TextPrompt.prototype._completionsReady):
Pass userEnteredText to updateSuggestions.
- 1:29 AM Changeset in webkit [145053] by
-
- 5 edits6 adds in trunk
TextTrackRegion Constructor
https://bugs.webkit.org/show_bug.cgi?id=110511
Reviewed by Adam Barth.
Source/WebCore:
This is an initial patch for implementing the TextTrackRegion
defined in the "WebVTT Extension: Regions for rendering cue groups":
https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/region.html
The feature components are hidden behind the WEBVTT_REGIONS flag
and is currently disabled by default in all ports and tests skipped.
Test: media/track/regions-webvtt/text-track-region-constructor.html
- WebCore.gypi: Added files to be included for building Chromium with
feature enabled (it is disabled by default).
- html/track/TextTrackRegion.cpp: Added.
(WebCore):
(WebCore::TextTrackRegion::TextTrackRegion):
(WebCore::TextTrackRegion::~TextTrackRegion):
(WebCore::TextTrackRegion::setId): Setter.
(WebCore::TextTrackRegion::setWidth): Setter.
(WebCore::TextTrackRegion::setHeight): Setter.
(WebCore::TextTrackRegion::setRegionAnchorX): Setter.
(WebCore::TextTrackRegion::setRegionAnchorY): Setter.
(WebCore::TextTrackRegion::setViewportAnchorX): Setter.
(WebCore::TextTrackRegion::setViewportAnchorY): Setter.
(WebCore::TextTrackRegion::scroll): Getter. Internally, the scroll
value is stored as a boolean, but when returned is converted to either
the empty string or "up".
(WebCore::TextTrackRegion::setScroll): Setter.
(WebCore::TextTrackRegion::setRegionSettings): Not used yet (see b/109818)
- html/track/TextTrackRegion.h: Added.
(WebCore):
(TextTrackRegion):
(WebCore::TextTrackRegion::create):
(WebCore::TextTrackRegion::track): Getter.
(WebCore::TextTrackRegion::id): Getter.
(WebCore::TextTrackRegion::width): Getter.
(WebCore::TextTrackRegion::height): Getter.
(WebCore::TextTrackRegion::regionAnchorX): Getter.
(WebCore::TextTrackRegion::regionAnchorY): Getter.
(WebCore::TextTrackRegion::viewportAnchorX): Getter.
(WebCore::TextTrackRegion::viewportAnchorY): Getter.
(WebCore::TextTrackRegion::regionSettings): Getter, used only internally (see b/109818).
- html/track/TextTrackRegion.idl: Added.
- page/DOMWindow.idl: Constructor support.
LayoutTests:
- TestExpectations:
- media/track/regions-webvtt/text-track-region-constructor-expected.txt: Added.
- media/track/regions-webvtt/text-track-region-constructor.html: Added.
- 1:05 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:04 AM Changeset in webkit [145052] by
-
- 11 edits12 adds in trunk
ConvertThis should be turned into Identity based on predictions in Fixup, rather than based on proofs in ConstantFolding
https://bugs.webkit.org/show_bug.cgi?id=111674
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
This gets rid of the speculated forms of ConvertThis in the backend, and has Fixup
convert them to either Identity(Object:@child) if the child is predicted object, or
Phantom(Other:@child) ; WeakJSConstant(global this object) if it's predicted Other.
The goal of this is to ensure that the optimization fixpoint doesn't create
Identity's, since doing so requires a rerun of CSE. So far this isn't a speed-up
but I'm hoping this will be a step towards reducing the need to rerun the fixpoint
so as to ultimately reduce compile times.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGAssemblyHelpers.h:
(AssemblyHelpers):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(FixupPhase):
(JSC::DFG::FixupPhase::observeUseKindOnNode):
(JSC::DFG::FixupPhase::setUseKindAndUnboxIfProfitable):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::globalThisObjectFor):
(Graph):
- dfg/DFGNode.h:
(Node):
(JSC::DFG::Node::convertToIdentity):
(JSC::DFG::Node::convertToWeakConstant):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
LayoutTests:
Reviewed by Oliver Hunt.
- fast/js/dfg-convert-this-object-then-exit-on-other-expected.txt: Added.
- fast/js/dfg-convert-this-object-then-exit-on-other.html: Added.
- fast/js/dfg-convert-this-other-then-exit-on-object-expected.txt: Added.
- fast/js/dfg-convert-this-other-then-exit-on-object.html: Added.
- fast/js/dfg-convert-this-polymorphic-object-then-exit-on-other-expected.txt: Added.
- fast/js/dfg-convert-this-polymorphic-object-then-exit-on-other.html: Added.
- fast/js/dfg-convert-this-polymorphic-object-then-exit-on-string-expected.txt: Added.
- fast/js/dfg-convert-this-polymorphic-object-then-exit-on-string.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-convert-this-object-then-exit-on-other.js: Added.
(foo):
- fast/js/script-tests/dfg-convert-this-other-then-exit-on-object.js: Added.
(foo):
- fast/js/script-tests/dfg-convert-this-polymorphic-object-then-exit-on-other.js: Added.
(foo):
- fast/js/script-tests/dfg-convert-this-polymorphic-object-then-exit-on-string.js: Added.
(foo):
- 1:03 AM Changeset in webkit [145051] by
-
- 6 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Revert "[GTK] When the WebProcess crashes, a signal should be emitted"
This reverts commit r144902. The API is problematic.
- 12:52 AM Changeset in webkit [145050] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
- 12:51 AM Changeset in webkit [145049] by
-
- 2 edits in trunk/Source/WebCore
[v8] remove latin-1 transition flag
https://bugs.webkit.org/show_bug.cgi?id=111692
Patch by Dan Carney <dcarney@google.com> on 2013-03-07
Reviewed by Jochen Eisinger.
No new tests. No change in functionality.
- bindings/v8/V8ValueCache.cpp:
(WebCore::makeExternalString):
- 12:27 AM Changeset in webkit [145048] by
-
- 5 edits in trunk
Web Inspector: NavigatorView should show (program) for uiSourceCodes with empty name.
https://bugs.webkit.org/show_bug.cgi?id=111691
Reviewed by Alexander Pavlov.
Source/WebCore:
Made String.prototype methods return string literal, not String object.
- inspector/front-end/utilities.js:
(String.prototype.escapeCharacters):
LayoutTests:
- inspector/debugger/navigator-view-expected.txt:
- inspector/debugger/navigator-view.html:
- 12:18 AM Changeset in webkit [145047] by
-
- 2 edits in trunk/Source/JavaScriptCore
Children method in LLINT AST Not class should return [@child]
https://bugs.webkit.org/show_bug.cgi?id=90740
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-03-07
Reviewed by Filip Pizlo.
- offlineasm/ast.rb: Fixed the return value of the children method in the Not AST class.
- 12:15 AM WebKitGTK/2.0.x edited by
- Move landed patch to proposed merges (diff)
- 12:12 AM Changeset in webkit [145046] by
-
- 7 edits3 copies in trunk/Source/WebKit/chromium
[chromium] expose UserGestureToken via WebKit API so PPAPI plugins can correctly consume it
https://bugs.webkit.org/show_bug.cgi?id=104268
Reviewed by Darin Fisher.
Currently, the PPAPI creates a WebScopedUserGesture up to 10 seconds
after a call with an currently active user gesture was made. It should
use the newly added WebUserGestureToken to make sure this user gesture
is not consumed multiple times.
We can't require a WebUserGestureToken for a WebScopedUserGesture, since
e.g. the extension API needs to be able to create a WebScopedUserGesture
out of the blue.
- WebKit.gyp:
- WebKit.gypi:
- public/WebScopedUserGesture.h:
(WebKit):
(WebKit::WebScopedUserGesture::WebScopedUserGesture):
(WebScopedUserGesture):
- public/WebUserGestureIndicator.h:
(WebKit):
(WebUserGestureIndicator):
- public/WebUserGestureToken.h: Copied from Source/WebKit/chromium/public/WebScopedUserGesture.h.
(WebCore):
(WebKit):
(WebUserGestureToken):
(WebKit::WebUserGestureToken::WebUserGestureToken):
(WebKit::WebUserGestureToken::operator=):
(WebKit::WebUserGestureToken::~WebUserGestureToken):
(WebKit::WebUserGestureToken::isNull):
- src/WebScopedUserGesture.cpp:
(WebKit::WebScopedUserGesture::initializeWithToken):
(WebKit):
- src/WebUserGestureIndicator.cpp:
(WebKit::WebUserGestureIndicator::currentUserGestureToken):
(WebKit):
- src/WebUserGestureToken.cpp: Copied from Source/WebKit/chromium/src/WebUserGestureIndicator.cpp.
(WebKit):
(WebKit::WebUserGestureToken::WebUserGestureToken):
(WebKit::WebUserGestureToken::operator WebCore::UserGestureToken*):
(WebKit::WebUserGestureToken::assign):
(WebKit::WebUserGestureToken::reset):
- tests/WebUserGestureTokenTest.cpp: Copied from Source/WebKit/chromium/src/WebUserGestureIndicator.cpp.
(WebCore):
(WebCore::TEST):
- 12:08 AM Changeset in webkit [145045] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Cmd+L (Go-to-Line) masks Go to location bar action
https://bugs.webkit.org/show_bug.cgi?id=111357
Reviewed by Pavel Feldman.
Allow panel shortcut handlers to bubble event.
- inspector/front-end/GoToLineDialog.js:
(WebInspector.GoToLineDialog.install): Minor refactoring, added JSDocs.
(WebInspector.GoToLineDialog._show): Added JSDocs and return value.
- inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.handleShortcut):
Mark event as handled iff handler returned true.
- inspector/front-end/ScriptsPanel.js: Added return values to handlers.
- inspector/front-end/TimelinePanel.js: Ditto.
Mar 6, 2013:
- 11:52 PM Changeset in webkit [145044] by
-
- 3 edits3 adds in trunk
Box-shadow displayed improperly with border-radius.
https://bugs.webkit.org/show_bug.cgi?id=111256
Reviewed by Simon Fraser.
Source/WebCore:
RoundedRect::adjustRadii doesn't adjust radii correctly, because
the method compares maxRadiusWidth with maxRadiusHeight. However,
we have to compare maxRadiusWidth / rect.width() with
maxRadiusHeight / rect.height().
Test: fast/borders/border-radius-with-box-shadow-01.html
- platform/graphics/RoundedRect.cpp:
(WebCore::RoundedRect::adjustRadii):
Should check which ratio is smaller.
LayoutTests:
- fast/borders/border-radius-with-box-shadow-01-expected.txt: Added.
- fast/borders/border-radius-with-box-shadow-01.html: Added.
- platform/chromium-linux/fast/borders/border-radius-with-box-shadow-01-expected.png: Added.
- 11:49 PM Changeset in webkit [145043] by
-
- 2 edits in trunk/Source/WebCore
[V8] Preprocess constant values to avoid a "static_cast<signed int>" in CodeGeneratorV8.
https://bugs.webkit.org/show_bug.cgi?id=111625
Reviewed by Kentaro Hara.
When processing constants in IDL files, CodeGeneratorV8 currently runs
the values through 'static_cast<signed int>' in the generated code. We
can avoid this miniscule bit of overhead by preprocessing the hex value
in Perl when generating the code.
The FIXME has been in the code since it originally landed in 2009[1].
Now's as good a time as any to take care of it.
[1]: http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm?rev=144976#L2933
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
If we're presented with a string which begins with '0x', run it
through some fairly obtuse Perlisms to first convert from a hex
string to an integer ('hex($value)'), "pack" the integer as an
unsigned integer ('pack("I", ...)'), and then "unpack" it as a
signed integer ('unpack("i", ...)'). Because that's _of course_
how you would do things.
- 11:25 PM Changeset in webkit [145042] by
-
- 2 edits in trunk/Source/WebKit2
SandboxExtension::createHandle raises an uncaught Objective-C exception if path is empty
https://bugs.webkit.org/show_bug.cgi?id=111689
Reviewed by Filip Pizlo.
- Shared/mac/SandboxExtensionMac.mm: (WebKit::SandboxExtension::createHandle): Use a function from WebCore platform layer instead of Foundation one equivalent. We already do this elsewhere in this file.
- 10:47 PM Changeset in webkit [145041] by
-
- 2 edits in trunk/Source/WebCore
WebKit does not build without accelerated compositing after Changeset 144823
https://bugs.webkit.org/show_bug.cgi?id=111597
Patch by Paweł Forysiuk <tuxator@o2.pl> on 2013-03-06
Reviewed by Kentaro Hara.
Properly guard functions ifdefed in ScrollingCoordinator.h.
Remove redundant checks and fallback code inside those functions.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::scrollLayerForScrollableArea):
(WebCore::ScrollingCoordinator::horizontalScrollbarLayerForScrollableArea):
(WebCore::ScrollingCoordinator::verticalScrollbarLayerForScrollableArea):
(WebCore):
- 10:32 PM Changeset in webkit [145040] by
-
- 11 edits2 moves in trunk/Source/WebCore
Custom Elements Refactoring: CustomElementConstructor API shouldn't bound to HTMLElement
https://bugs.webkit.org/show_bug.cgi?id=111678
Reviewed by Kentaro Hara.
The latest Custom Elements standard supports non-HTML custom elements. Even though current implementation
support only HTML, it'd be better off to make API generic enough to support them.
This change
- eliminates HTMLElement from the API signature by replacing it with Element, and
- rename V8HTMLCustomElement to V8CustomElement.
No new tests, just changing signatures and a class name.
- WebCore.gypi:
- bindings/v8/V8CustomElement.cpp: Renamed from Source/WebCore/bindings/v8/V8HTMLCustomElement.cpp.
(WebCore):
(WebCore::findWrapperTypeOf):
(WebCore::V8CustomElement::createWrapper):
- bindings/v8/V8CustomElement.h: Renamed from Source/WebCore/bindings/v8/V8HTMLCustomElement.h.
(WebCore):
(V8CustomElement):
(WebCore::V8CustomElement::toV8):
(WebCore::V8CustomElement::wrap):
(WebCore::HTMLCustomElement::wrap):
- bindings/v8/custom/V8CustomElementConstructorCustom.cpp:
(WebCore::V8CustomElementConstructor::callAsFunctionCallback):
- dom/CustomElementConstructor.cpp:
(WebCore::CustomElementConstructor::createElement):
- dom/CustomElementConstructor.h:
(WebCore):
(CustomElementConstructor):
- dom/CustomElementRegistry.cpp:
(WebCore::CustomElementRegistry::constructorOf):
(WebCore::CustomElementRegistry::createElement):
- dom/CustomElementRegistry.h:
(WebCore):
(CustomElementRegistry):
- dom/Document.cpp: Ensured that the document is an HTML.
(WebCore::Document::registerElement):
- dom/Document.idl:
- dom/make_names.pl:
(printWrapperFactoryCppFile):
- html/HTMLDocument.idl: Moved an API to Document.idl
- 9:58 PM Changeset in webkit [145039] by
-
- 2 edits in trunk/Source/WebKit2
[wk2] Page overlays shouldn't dirty the entire layer when flushing if the main frame can't scroll
https://bugs.webkit.org/show_bug.cgi?id=111662
<rdar://problem/13355808>
Reviewed by Simon Fraser.
Instead of setNeedsDisplay()ing the whole page overlay layer every time through
TCADA::flushLayers, do it at scroll time instead. Repainting on scroll is
necessary to keep things painted in the right place when we scroll (the overlay
is fixed to the size of the view), but is quite wasteful in apps that don’t scroll.
This works with threaded scrolling because overlay installation forces us
into main-thread scrolling mode.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scroll):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
- 9:55 PM Changeset in webkit [145038] by
-
- 2 edits in trunk/Source/WebCore
TileCache debug minimap should fit inside the intersection of the visible rect and exposed rect
https://bugs.webkit.org/show_bug.cgi?id=111655
<rdar://problem/13355773>
Reviewed by Simon Fraser.
If content clips to the exposed rect, make the TileCache minimap fit in the exposed rect too.
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::commitTreeState):
- platform/graphics/TiledBacking.h:
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::updateTileCoverageMap):
- 9:54 PM Changeset in webkit [145037] by
-
- 2 edits in trunk/Source/WebKit2
[wk2] Page overlays should use the accelerated drawing setting instead of hardcoding it on
https://bugs.webkit.org/show_bug.cgi?id=111654
<rdar://problem/13364085>
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
- 9:49 PM Changeset in webkit [145036] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r144726.
http://trac.webkit.org/changeset/144726
https://bugs.webkit.org/show_bug.cgi?id=111681
caused performance regression for Dromaeo attribute tests.
(Requested by arpitab on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-06
Source/WebCore:
- dom/Element.h:
(WebCore::ElementData::getAttributeItemIndex):
LayoutTests:
- fast/dom/Element/getAttribute-case-insensitivity-expected.txt: Removed.
- fast/dom/Element/getAttribute-case-insensitivity.html: Removed.
- 9:20 PM Changeset in webkit [145035] by
-
- 6 edits in trunk
File.lastModifiedDate() should return the current date/time if the file date/time is not available
https://bugs.webkit.org/show_bug.cgi?id=111403
Reviewed by Kent Tamura.
Source/WebCore:
Per the recent File API spec change:
http://www.w3.org/TR/2012/WD-FileAPI-20121025/#dfn-lastModifiedDate
Test: http/tests/local/fileapi/script-tests/file-last-modified-after-delete.js:
- fileapi/File.cpp:
(WebCore::File::lastModifiedDate): Changed to return the current date/time instead null if the valid file date/time is not available.
- fileapi/File.h:
(File):
LayoutTests:
- http/tests/local/fileapi/file-last-modified-after-delete-expected.txt: Updated.
- http/tests/local/fileapi/script-tests/file-last-modified-after-delete.js: Updated.
- 8:54 PM Changeset in webkit [145034] by
-
- 2 edits in trunk/Source/WebCore
Make RuleData support up to 8191 selectors
https://bugs.webkit.org/show_bug.cgi?id=111663
Patch by Philippe Liard <pliard@chromium.org> on 2013-03-06
Reviewed by Andreas Kling.
r125294 made RuleData consume less memory by replacing a pointer with
an index encoded on 12 bits.
This unfortunately breaks Chrome for Android (and others) when a lot of
CSS is used or more precisely when selectorIndex cannot be stored on 12
bits.
Threfore this change decreases the number of bits used to store
m_position by 1 (from 19 to 18) and adds this extra bit to
m_selectorIndex so that values up to 8191 can be stored safely without
overflowing.
- css/RuleSet.h:
(RuleData):
- 8:47 PM Changeset in webkit [145033] by
-
- 5 edits in trunk/Source/WebKit/chromium
[chromium] Fix typo: destoryPage() => destroyPage()
https://bugs.webkit.org/show_bug.cgi?id=111664
Patch by David Dorwin <ddorwin@chromium.org> on 2013-03-06
Reviewed by Kentaro Hara.
- src/WebHelperPluginImpl.cpp:
(WebKit::WebHelperPluginImpl::closeHelperPlugin):
(WebKit::WebHelperPluginImpl::destroyPage):
- src/WebHelperPluginImpl.h:
(WebHelperPluginImpl):
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::destroyPage):
(WebKit::WebPagePopupImpl::close):
(WebKit::WebPagePopupImpl::closePopup):
- src/WebPagePopupImpl.h:
(WebPagePopupImpl):
- 8:47 PM Changeset in webkit [145032] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Remove unused code from contextmenu of element panel
https://bugs.webkit.org/show_bug.cgi?id=111658
Patch by Seokju Kwon <Seokju Kwon> on 2013-03-06
Reviewed by Pavel Feldman.
No new tests (no functional changes).
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._contextMenuEventFired.set get var):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.populateContextMenu):
- 8:46 PM Changeset in webkit [145031] by
-
- 6 edits in trunk
Source/WebKit: Unreviewed partial roll-out of r145003. Disable
ENABLE_CURSOR_VISIBILITY on win.
- WebKit.vcxproj/FeatureDefines.props:
WebKitLibraries: Unreviewed roll-out of r145011.
- win/tools/vsprops/FeatureDefines.vsprops:
LayoutTests: Unreviewed gardening.
- platform/win/TestExpectations:
- 8:39 PM Changeset in webkit [145030] by
-
- 1 copy in tags/Safari-537.33
New Tag.
- 7:51 PM Changeset in webkit [145029] by
-
- 19 edits in trunk
[CSS Grid Layout] Extend our grammar to support 2 positions for grid-{row|column}
https://bugs.webkit.org/show_bug.cgi?id=110777
Reviewed by Tony Chang.
Source/WebCore:
Now that we support all the logical grid properties, we can change grid-{row|column}
into shorthands. That's what this change does along with extending our parsing support
to handle 2 positions.
Tests: fast/css-grid-layout/grid-item-column-row.html
fast/css-grid-layout/grid-item-end-after-get-set.html
fast/css-grid-layout/grid-item-start-before-get-set.html
- css/CSSComputedStyleDeclaration.cpp:
Removed grid-{row|column} from computedProperties as they are shorthands (see comments
at computedProperties definition).
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForGridShorthand):
Switched to using the StylePropertyShorthand and reusing the existing longhand code.
- css/CSSComputedStyleDeclaration.h:
Added getCSSPropertyValuesForGridShorthand.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridItemPositionShorthand):
Added custom parsing for the shorthand, that builds on top of the longhand code.
- css/CSSParser.h:
Added parseGridItemPositionShorthand.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Removed the previous handling as shorthand are expanded at parse time.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
Added the new shorthands to the list.
- css/StylePropertyShorthand.cpp:
(WebCore::webkitGridColumnShorthand):
(WebCore::webkitGridRowShorthand):
(WebCore::shorthandForProperty):
- css/StylePropertyShorthand.h:
Registered grid-{row|column} as shorthands.
LayoutTests:
- fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
- fast/css-grid-layout/grid-item-column-row-get-set.html:
- fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
- fast/css-grid-layout/grid-item-end-after-get-set.html:
- fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
- fast/css-grid-layout/grid-item-start-before-get-set.html:
Extended the following test to ensure that grid-{row|column} are a
shortand for resp. grid-{before|after} and grid-{start|end}.
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
Removed grid-{row|column} as they are now shorthands so they don't appear
in the list of supported properties.
- 7:48 PM Changeset in webkit [145028] by
-
- 11 edits1 add in trunk/Tools
Dashboard cleanup: Move all dashboard ui related code into ui.js.
https://bugs.webkit.org/show_bug.cgi?id=111621
Reviewed by Ojan Vafai.
Creates ui.js, a package for the common UI code the various
dashboards use. HTML generation is now in the ui.html namespace
and popup handling is in ui.popup.
Also moves the event listening for popups to ui.popup.show and
removes it on ui.popup.hid rather than having listener always
around.
- TestResultServer/static-dashboards/aggregate_results.html:
- TestResultServer/static-dashboards/dashboard_base.js:
- TestResultServer/static-dashboards/flakiness_dashboard.html:
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(showPopupForBuild):
(htmlForNavBar):
(generatePageForIndividualTests.if):
(generatePageForIndividualTests):
- TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- TestResultServer/static-dashboards/run-embedded-unittests.html:
- TestResultServer/static-dashboards/run-unittests.html:
- TestResultServer/static-dashboards/timeline_explorer.html:
- TestResultServer/static-dashboards/treemap.html:
- TestResultServer/static-dashboards/ui.js: Added.
(.):
- 7:46 PM Changeset in webkit [145027] by
-
- 4 edits in trunk/Source
[Chromium] Fix byte ordering bugs reading back WebGL canvases' content on Android
https://bugs.webkit.org/show_bug.cgi?id=111661
Reviewed by James Robinson.
Source/Platform:
- chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):
Better documented contract of readBackFrameBuffer.
Source/WebCore:
No new tests; covered by existing tests. Ran WebGL conformance
tests on Android and desktop Linux to verify fix.
- platform/chromium/support/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
Avoid incorrect byte swap on Android and other OSs which don't
swizzle R and B channels.
- 7:43 PM Changeset in webkit [145026] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: fast/js/exception-sequencing-binops.html
- 7:32 PM Changeset in webkit [145025] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Improve warning messages when input value is out of range.
https://bugs.webkit.org/show_bug.cgi?id=111534
Reviewed by Laszlo Gombos.
Show input value range when user inputs greater or less value.
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore::validationMessageRangeOverflowText):
(WebCore::validationMessageRangeUnderflowText):
- 7:25 PM Changeset in webkit [145024] by
-
- 5 edits in trunk/Source
[EFL][WK2] Enable interactive form validation for email and url input type validation
https://bugs.webkit.org/show_bug.cgi?id=111026
Reviewed by Laszlo Gombos.
WebKit EFL can check if input value is valid by enabling this feature.
Source/WebCore:
- platform/efl/LocalizedStringsEfl.cpp: Change validation messages of email and url the same with chromium port.
(WebCore::validationMessageTypeMismatchForEmailText):
(WebCore::validationMessageTypeMismatchForMultipleEmailText):
(WebCore::validationMessageTypeMismatchForURLText):
- platform/efl/RenderThemeEfl.cpp: Add type checking conditions for email and url.
(WebCore::RenderThemeEfl::supportsDataListUI):
Source/WebKit2:
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
- 7:22 PM Changeset in webkit [145023] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: media/encrypted-media/encrypted-media-events.html
- 7:03 PM Changeset in webkit [145022] by
-
- 2 edits in trunk/Source/WTF
Build fix: PageAllocationAligned no longer has executable flag
https://bugs.webkit.org/show_bug.cgi?id=111659
Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-03-06
Reviewed by Kentaro Hara.
Build fix: use false as parameter to execution flag.
- wtf/PageAllocationAligned.cpp:
(WTF::PageAllocationAligned::allocate):
- 6:30 PM Changeset in webkit [145021] by
-
- 3 edits in trunk/Source/WebCore
Remove WebCore::Node::isActiveNode() since it isn't called anywhere.
https://bugs.webkit.org/show_bug.cgi?id=111646
Reviewed by Kentaro Hara.
No new tests. This removes dead code.
- dom/Node.h:
(Node):
- html/HTMLAudioElement.h:
- 6:22 PM Changeset in webkit [145020] by
-
- 2 edits in trunk/Source/WTF
AtomicStringImpls are not safe to send between threads
https://bugs.webkit.org/show_bug.cgi?id=111652
Reviewed by Benjamin Poulain.
We don't have this problem yet, but it's good to be safe.
- wtf/text/WTFString.cpp:
(WTF::String::isSafeToSendToAnotherThread):
- 6:16 PM Changeset in webkit [145019] by
-
- 7 edits in branches/chromium/1364/Source/WebCore
Merge 139854
[V8] Make an Isolate parameter mandatory in SerializedScriptValue::deserialize()
https://bugs.webkit.org/show_bug.cgi?id=106916
Reviewed by Adam Barth.
This is one of steps to remove optional Isolate parameters.
No tests. No change in behavior.
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::deserialize):
(WebCore):
(WebCore::SerializedScriptValue::deserializeForInspector):
- bindings/v8/SerializedScriptValue.h:
(SerializedScriptValue):
- bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::stateAccessorGetter):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
- bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter):
TBR=haraken@chromium.org
Review URL: https://codereview.chromium.org/12560005
- 6:14 PM Changeset in webkit [145018] by
-
- 3 edits in trunk/Source/WTF
Don't give PageAllocationAligned the option to allocate executable memory
https://bugs.webkit.org/show_bug.cgi?id=111657
Reviewed by Geoffrey Garen.
- wtf/PageAllocationAligned.cpp:
(WTF::PageAllocationAligned::allocate):
- wtf/PageAllocationAligned.h:
(PageAllocationAligned):
- 5:39 PM Changeset in webkit [145017] by
-
- 2 edits1 delete in trunk/LayoutTests
Unreviewed gardening AppleWin port.
- platform/win/TestExpectations:
- platform/win/cssom: Removed.
- platform/win/cssom/cssvalue-comparison-expected.txt: Removed.
- 5:31 PM Changeset in webkit [145016] by
-
- 2 edits in branches/chromium/1410/Source/WebCore
Merge 145013
Crash in SVGViewSpec::viewTarget
https://bugs.webkit.org/show_bug.cgi?id=111648
Reviewed by Philip Rogers.
- svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::viewTarget):
TBR=inferno@chromium.org
Review URL: https://codereview.chromium.org/12562002
- 5:29 PM Changeset in webkit [145015] by
-
- 2 edits in branches/chromium/1364/Source/WebCore
Merge 145013
Crash in SVGViewSpec::viewTarget
https://bugs.webkit.org/show_bug.cgi?id=111648
Reviewed by Philip Rogers.
- svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::viewTarget):
TBR=inferno@chromium.org
Review URL: https://codereview.chromium.org/12424003
- 5:27 PM Changeset in webkit [145014] by
-
- 13 edits2 copies in trunk
[EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
https://bugs.webkit.org/show_bug.cgi?id=110584
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-06
Reviewed by Gyuyoung Kim.
Source/WebKit/efl:
Adds support for help text in DumpRenderTree.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::accessibilityHelpText):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Adds missing implementation of AccessibilityControllerEfl
and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
so that it can make accessibilityController as a js object.
- DumpRenderTree/AccessibilityController.h:
(AccessibilityController):
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
(AccessibilityController::childElementById): Moved declaration to base class.
Implementation can be shared among other ports.
- DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
(AccessibilityController::focusedElement):
(AccessibilityController::rootElement):
(AccessibilityController::accessibleElementById):
- DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
(AccessibilityUIElement::helpText):
- DumpRenderTree/efl/CMakeLists.txt:
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::DumpRenderTreeChrome):
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
(DumpRenderTreeChrome::onWindowObjectCleared):
(DumpRenderTreeChrome::accessibilityController):
- DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
- DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
LayoutTests:
Unskipping LayoutTests/accessibility folder.
Added failure tests. Skipping those with missing expected results.
- platform/efl-wk1/TestExpectations:
- 5:25 PM WebKit Team edited by
- (diff)
- 5:24 PM Changeset in webkit [145013] by
-
- 2 edits in trunk/Source/WebCore
Crash in SVGViewSpec::viewTarget
https://bugs.webkit.org/show_bug.cgi?id=111648
Reviewed by Philip Rogers.
- svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::viewTarget):
- 5:17 PM Changeset in webkit [145012] by
-
- 30 edits in trunk
WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
https://bugs.webkit.org/show_bug.cgi?id=42696
Reviewed by Andreas Kling.
Source/WebCore:
Since the method acts directly on a WebCore element and strictly test
HTMLInputElement::shouldAutoComplete(), the test function is moved to internals.
- testing/Internals.cpp:
(WebCore::Internals::elementShouldAutoComplete):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Source/WebKit/qt:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Tools:
- DumpRenderTree/TestRunner.cpp:
(TestRunner::staticFunctions):
- DumpRenderTree/TestRunner.h:
(TestRunner):
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/efl/TestRunnerEfl.cpp:
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
- DumpRenderTree/mac/TestRunnerMac.mm:
- DumpRenderTree/qt/TestRunnerQt.cpp:
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):
- DumpRenderTree/win/TestRunnerWin.cpp:
- DumpRenderTree/wx/TestRunnerWx.cpp:
LayoutTests:
- security/set-form-autocomplete-attribute.html: Update the test.
- platform/wk2/TestExpectations: Unskip it for WebKit2.
- 5:16 PM Changeset in webkit [145011] by
-
- 2 edits in trunk/WebKitLibraries
Unreviewed build fix. Add ENABLE_CURSOR_VISIBILITY to the list of FEATURE_DEFINES for
(non-Cairo) Windows builds.
- win/tools/vsprops/FeatureDefines.vsprops:
- 5:15 PM Changeset in webkit [145010] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r143931): set-cookie-on-redirect.html still breaking subsequent tests
https://bugs.webkit.org/show_bug.cgi?id=111650
Unreviewed gardening.
- platform/mac/TestExpectations:
- 5:04 PM Changeset in webkit [145009] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: platform/chromium/fast/events/intercept-postmessage.html
- 4:58 PM Changeset in webkit [145008] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r144748-r144750): sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.1_T2.html failing on Apple MountainLion Debug WK1 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=111647
Unreviewed skip in test expectations for Mac.
- platform/mac/TestExpectations:
- 4:35 PM Changeset in webkit [145007] by
-
- 16 edits in trunk/Source
[Mac] Synthetic ResourceResponses cannot be sent over IPC without losing most information
https://bugs.webkit.org/show_bug.cgi?id=111623
Reviewed by Brady Eidson.
- Shared/WebCoreArgumentCoders.cpp:
- Shared/WebCoreArgumentCoders.h: (CoreIPC::::encode): Made the decision on whether to serialize WebCore data in ResourceResponse dynamic. If the platform data is out of date, we need both (because some platforms use encodePlatformData() to pass additional information). (CoreIPC::::decode): Decode platform data first, because this overwrites the ResourceResponse.
- Shared/mac/WebCoreArgumentCodersMac.mm: (CoreIPC::::encodePlatformData): Don't encode NSURLResponse if it's out of date. We may have a bad NSURLResponse with 0 status code given to client, but it was almost certainly the same on sending side. WebCore doesn't mutate real responses - it either keeps them as is, or builds entirely synthetic ones.
- 4:32 PM Changeset in webkit [145006] by
-
- 4 edits2 deletes in trunk/Source
[chromium] Remove WebSharedGraphicsContext3D class
https://bugs.webkit.org/show_bug.cgi?id=111492
Reviewed by James Robinson.
Source/Platform:
- Platform.gypi:
- chromium/public/WebSharedGraphicsContext3D.h: Removed.
Source/WebCore:
Removing dead code, no new tests.
- WebCore.gypi:
- platform/chromium/support/WebSharedGraphicsContext3D.cpp: Removed.
- 4:31 PM Changeset in webkit [145005] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening: rebaselines.
- platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
- platform/chromium-win/svg/custom/foreign-object-skew-expected.png:
- platform/chromium-win/svg/custom/foreign-object-skew-expected.txt:
- 4:29 PM Changeset in webkit [145004] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Don't get callbacks or create GrContext from unowned WebGraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=111638
Reviewed by James Robinson.
If the context is not owned, it's lifetime is not guaranteed, and by the time
the GraphicsContext3D is destroyed, the WGC3D can already be deleted.
When the context is not owned by the GraphicsContext3D, then don't clean it up
in the destructor or set up callbacks, as these are the owner's responsibility.
- platform/chromium/support/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::grContext):
(WebCore::GraphicsContext3DPrivate::setContextLostCallback):
(WebCore::GraphicsContext3DPrivate::setErrorMessageCallback):
- 4:27 PM Changeset in webkit [145003] by
-
- 38 edits2 adds in trunk
Default mouse cursor behavior should be auto-hide for full screen video with custom controls
https://bugs.webkit.org/show_bug.cgi?id=107601
Reviewed by Beth Dakin.
Source/WebCore:
Test: fullscreen/video-cursor-auto-hide.html
To facilitate automatically hiding the mouse cursor after a certain amount of idle mouse
time, add a new CSS property '-webkit-cursor-visibility', and handle that value inside of
EventHandler. When that value is present, the EventHandler will start a timer which, when
fired, will set the view's cursor to the None cursor. Subsequent mouse moves will either
cancel the timer, or reset the auto-hide timer.
Add a new CSS property, '-webkit-cursor-visibility':
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ECursorVisibility):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Add a rule for video descendants of full screen elements to auto-hide the cursor on hover:
- css/fullscreen.css:
(:-webkit-full-screen video:hover):
Add a new timer, m_autoHideCursorTimer, to control resetting the view's cursor to None after
enough mouse idle time has passed.
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::~EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::startAutoHideCursorTimer):
(WebCore::EventHandler::cancelAutoHideCursorTimer):
(WebCore::EventHandler::autoHideCursorTimerFired):
- page/EventHandler.h:
Make FrameView::isActive() a public function (like it is in its superclass).
- page/FrameView.h:
(FrameView):
Move the definition for timeWithoutMouseMovementBeforeHidingControls from page->theme()
to page->settings() and allow that setting to be overridden in InternalSettings for
testing purposes:
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/Settings.h:
(WebCore::Settings::setTimeWithoutMouseMovementBeforeHidingControls):
(WebCore::Settings::timeWithoutMouseMovementBeforeHidingControls):
- rendering/RenderTheme.h:
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setTimeWithoutMouseMovementBeforeHidingControls):
- testing/InternalSettings.h:
(InternalSettings):
- testing/InternalSettings.idl:
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::startHideFullscreenControlsTimer):
Add support to FeatureObserver for CURSOR_VISIBILITY:
- page/FeatureObserver.h:
Enable the feature flag:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit:
Enable the CURSOR_VISIBILITY feature.
- WebKit.vcxproj/FeatureDefines.props:
Source/WebKit/mac:
Enable the CURSOR_VISIBILITY feature.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Enable the CURSOR_VISIBILITY feature.
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
Enable the CURSOR_VISIBILITY feature.
- wtf/FeatureDefines.h:
LayoutTests:
- fullscreen/video-cursor-auto-hide-expected.txt: Added.
- fullscreen/video-cursor-auto-hide.html: Added.
Add an expected failing result in platforms which do not enable CURSOR_VISIBILITY.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- 4:27 PM Changeset in webkit [145002] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Return m_inspectorFilesPath if it is not null
https://bugs.webkit.org/show_bug.cgi?id=111633
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-06
Reviewed by Martin Robinson.
Added missing return in InspectorClient::inspectorFilesPath().
- WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::inspectorFilesPath):
- 4:26 PM Changeset in webkit [145001] by
-
- 4 edits in trunk
Full screen from an iframe with a z-index style will allow siblings with higher z-index to overlay full screen content.
https://bugs.webkit.org/show_bug.cgi?id=111637
Reviewed by Simon Fraser.
Source/WebCore:
No new tests; updated fullscreen/full-screen-iframe-zIndex.html to expose bug.
Pages with explicit z-index: styles on their iframes will override the default z-index: UA style when
elements within that iframe enter full screen mode. Mark the UA style as !important so as to not allow
iframe siblings with higher z-index styles to overlay the full screen element.
- css/fullscreen.css:
(:-webkit-full-screen):
LayoutTests:
- fullscreen/full-screen-iframe-zIndex.html:
- 4:25 PM Changeset in webkit [145000] by
-
- 23 edits in trunk/Source/JavaScriptCore
Bring back eager resolution of function scoped variables
https://bugs.webkit.org/show_bug.cgi?id=111497
Reviewed by Geoffrey Garen.
This reverts the get/put_scoped_var part of the great non-local
variable resolution refactoring. This still leaves all the lazy
variable resolution logic as it's necessary for global property
resolution, and i don't want to make the patch bigger than it
already is.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
(CodeBlock):
- bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::generateFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::codeBlockFor):
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
- bytecode/UnlinkedCodeBlock.h:
(JSC):
(UnlinkedFunctionExecutable):
(UnlinkedCodeBlock):
(JSC::UnlinkedCodeBlock::usesGlobalObject):
(JSC::UnlinkedCodeBlock::setGlobalObjectRegister):
(JSC::UnlinkedCodeBlock::globalObjectRegister):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::ResolveResult::checkValidity):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitLoadGlobalObject):
(JSC):
(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::resolveConstDecl):
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveBase):
(JSC::BytecodeGenerator::emitResolveBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithBaseForPut):
(JSC::BytecodeGenerator::emitResolveWithThis):
(JSC::BytecodeGenerator::emitGetStaticVar):
(JSC::BytecodeGenerator::emitPutStaticVar):
- bytecompiler/BytecodeGenerator.h:
(JSC::ResolveResult::lexicalResolve):
(JSC::ResolveResult::isStatic):
(JSC::ResolveResult::depth):
(JSC::ResolveResult::index):
(ResolveResult):
(JSC::ResolveResult::ResolveResult):
(BytecodeGenerator):
- bytecompiler/NodesCodegen.cpp:
(JSC::ResolveNode::isPure):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::PostfixNode::emitResolve):
(JSC::TypeOfResolveNode::emitBytecode):
(JSC::PrefixNode::emitResolve):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::debugFail):
- dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
(JSC::DFG::canInlineOpcode):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
(JIT):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_scoped_var):
(JSC):
(JSC::JIT::emit_op_put_scoped_var):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_scoped_var):
(JSC):
(JSC::JIT::emit_op_put_scoped_var):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/CodeCache.cpp:
(JSC::CodeCache::getCodeBlock):
(JSC::CodeCache::getProgramCodeBlock):
(JSC::CodeCache::getEvalCodeBlock):
- runtime/CodeCache.h:
(JSC):
(CodeCache):
- runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::createEvalCodeBlock):
- runtime/JSGlobalObject.h:
(JSGlobalObject):
- runtime/Options.cpp:
(JSC::Options::initialize):
- 4:24 PM Changeset in webkit [144999] by
-
- 1 edit1 move1 add12 deletes in trunk/LayoutTests
editing/pasteboard/paste-4035648-fix.html should be a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=111639
Reviewed by Levi Weintraub.
Converted the test. Also renamed it to line-feed-between-br-and-b-should-not-reorder-pasted-content.html
to reflect the semantics of the test, and also added more description per radar bug.
- editing/pasteboard/line-feed-between-br-and-b-should-not-reorder-pasted-content-expected.txt: Added.
- editing/pasteboard/line-feed-between-br-and-b-should-not-reorder-pasted-content.html: Copied from
LayoutTests/editing/pasteboard/paste-4035648-fix.html.
- editing/pasteboard/paste-4035648-fix.html: Removed.
- platform/chromium-linux/editing/pasteboard/paste-4035648-fix-expected.png: Removed.
- platform/chromium-mac-lion/editing/pasteboard/paste-4035648-fix-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/paste-4035648-fix-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-4035648-fix-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-4035648-fix-expected.txt: Removed.
- platform/chromium/editing/pasteboard/paste-4035648-fix-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-4035648-fix-expected.png: Removed.
- platform/gtk/editing/pasteboard/paste-4035648-fix-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-4035648-fix-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-4035648-fix-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-4035648-fix-expected.png: Removed.
- platform/qt/editing/pasteboard/paste-4035648-fix-expected.txt: Removed.
- 4:14 PM Changeset in webkit [144998] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: fast/dom/Window/window-special-properties.html
- 4:11 PM Changeset in webkit [144997] by
-
- 3 edits in trunk/Tools
Re-enable WinEWS test and decrease iterations before clean build back to 10.
- EWSTools/start-queue-win.sh:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 4:10 PM Changeset in webkit [144996] by
-
- 2 edits in trunk/LayoutTests
ASSERTION FAILED: m_tokenizer->state() == HTMLTokenizer::DataState
https://bugs.webkit.org/show_bug.cgi?id=110546
Unreviewed change to test expectations while the above bug is open.
- platform/mac/TestExpectations:
- 4:07 PM Changeset in webkit [144995] by
-
- 7 edits2 adds in trunk
InsertUnorderedList can lead to lost content and assertions in moveParagraphs
https://bugs.webkit.org/show_bug.cgi?id=111228
Reviewed by Ryosuke Niwa.
Source/WebCore:
When a list is wrapped in a presentational inline like a b tag, we'd create markup that included
everything up to the b tag from moveParagraphs when intending to only move the contents of the
list item. This could make it impossible to remove content from a list and trigger loss of
editable text.
Test: editing/execCommand/insert-remove-block-list-inside-presentational-inline.html
- editing/EditingStyle.cpp:
(WebCore::elementMatchesAndPropertyIsNotInInlineStyleDecl): Ensure there's an inline style
before calling propertyExistsInStyle.
(WebCore::HTMLElementEquivalent::propertyExistsInStyle): Removing null check for style.
All callers ensure this value isn't null.
- editing/markup.cpp:
(WebCore::highestAncestorToWrapMarkup): Avoid going over RenderBlocks when finding the highest
presentational ancestor to avoid leaving the bounds of the original paragraph.
LayoutTests:
- editing/deleting/pruning-after-merge-1-expected.txt:
- editing/execCommand/insert-remove-block-list-inside-presentational-inline-expected.txt: Added.
- editing/execCommand/insert-remove-block-list-inside-presentational-inline.html: Added.
- editing/pasteboard/paste-and-sanitize-expected.txt:
- editing/pasteboard/paste-and-sanitize.html:
- 3:56 PM Changeset in webkit [144994] by
-
- 3 edits1 add in trunk
[V8] Use implicit references instead of object groups to keep registered MutationObservers alive
https://bugs.webkit.org/show_bug.cgi?id=111382
Reviewed by Adam Barth.
.:
- ManualTests/mutation-observer-leaks-nodes.html: Added.
Source/WebCore:
Two-phase approach to implicit references: after grouping objects
together, add an implicit reference between each registered node's
group and the MutationObserver's group (which includes wrappers from
all worlds).
Also changed many uses of v8::Value to v8::Object where we know we're
dealing with Object and the V8 API expects them.
Test: ManualTests/mutation-observer-leaks-nodes.html
- bindings/v8/V8GCController.cpp:
(WebCore::ImplicitConnection::ImplicitConnection):
(WebCore::ImplicitConnection::wrapper):
(ImplicitConnection):
(WebCore::ImplicitReference::ImplicitReference): Wrapper class holding a parent who should have an implicit reference to a child.
(ImplicitReference):
(WebCore::operator<): Needed for std::sort() call to avoid the overhead of using a HashMap
(WebCore::WrapperGrouper::addObjectWrapperToGroup):
(WebCore::WrapperGrouper::addNodeWrapperToGroup):
(WebCore::WrapperGrouper::addImplicitReference):
(WrapperGrouper):
(WebCore::WrapperGrouper::apply):
- 3:25 PM Changeset in webkit [144993] by
-
- 4 edits in tags/Safari-537.31.15/Source
Versioning.
- 3:22 PM Changeset in webkit [144992] by
-
- 1 copy in tags/Safari-537.31.15
New Tag.
- 3:14 PM Changeset in webkit [144991] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, roll out http://trac.webkit.org/changeset/144989
I think we want the assertion that I removed.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::merge):
(JSC::DFG::AbstractState::mergeVariableBetweenBlocks):
- dfg/DFGAbstractState.h:
(AbstractState):
- 3:08 PM Changeset in webkit [144990] by
-
- 2 edits in trunk
Build fix. Fixes problems building code that uses deprecated functions from GTK+ 2,
such as RenderThemeGtk2.cpp, in debug mode. RenderThemeGtk2.cpp tries to allow usage
of deprecated functions by undefining GTK_DISABLE_DEPRECATED, but it ended up being
redefined because autotoolsconfig.h was included again by headers that came after
config.h.
Reviewed by Martin Robinson.
- Source/autotools/SetupWebKitFeatures.m4: add checks to ensure the
autotoolsconfig.h header is only included once.
- 3:04 PM Changeset in webkit [144989] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG::AbstractState::merge() is still more complicated than it needs to be
https://bugs.webkit.org/show_bug.cgi?id=111619
Reviewed by Mark Hahnenberg.
This method is the one place where we still do some minimal amount of liveness pruning, but the style with
which it is written is awkward, and it makes an assertion about variablesAtTail that will be invalidated
by https://bugs.webkit.org/show_bug.cgi?id=111539.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::merge):
(JSC::DFG::AbstractState::mergeVariableBetweenBlocks):
- dfg/DFGAbstractState.h:
(AbstractState):
- 2:56 PM Changeset in webkit [144988] by
-
- 5 edits in trunk/Source
Source/WebCore: Modify log method in V8DOMActivityLogger so that the apiName and
extraInfo arguments are of type const String& instead of const char*.
This change gets rid of some of the memory ownership issues that arise
with char* pointers.
https://bugs.webkit.org/show_bug.cgi?id=111483
Patch by Ankur Taly <ataly@google.com> on 2013-03-06
Reviewed by Adam Barth.
There are no new tests as there is no change in behavior.
- bindings/v8/V8DOMActivityLogger.h:
(WebCore::V8DOMActivityLogger::log):
Source/WebKit/chromium: Modify log method in WebDOMActivityLogger so that the apiName and
extraInfo arguments are of type const WebString& instead of const char*.
This change gets rid of some of the memory ownership issues that arise
with char* pointers.
https://bugs.webkit.org/show_bug.cgi?id=111483
Patch by Ankur Taly <ataly@google.com> on 2013-03-06
Reviewed by Adam Barth.
There are no new tests as there is no change in behavior.
- public/WebDOMActivityLogger.h: Added property svn:eol-style.
(WebKit::WebDOMActivityLogger::log):
- src/WebDOMActivityLogger.cpp: Added property svn:eol-style.
(WebKit::DOMActivityLoggerContainer::log):
- 2:55 PM Changeset in webkit [144987] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: compositing/rtl/..
- 2:52 PM Changeset in webkit [144986] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r186511. Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-06
- DEPS:
- 2:44 PM Changeset in webkit [144985] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening of AppleWin port.
- platform/win/TestExpectations:
- 2:35 PM Changeset in webkit [144984] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: svg/css/font-face-crash.html
- 2:33 PM Changeset in webkit [144983] by
-
- 2 edits in branches/safari-534.59-branch/Source/WebKit2
<rdar://problem/13360535> - Bogus MESSAGE_CHECK in WebPageProxy::getPluginPath
Rubberstamped by Anders Carlsson.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getPluginPath): Nuke a bogus MESSAGE_CHECK.
- 2:26 PM Changeset in webkit [144982] by
-
- 2 edits in trunk/Source/WebKit2
[GTK][WK2] Implement WebInspector::localizedStringsURL() to return the file URL of localizedStrings.js
https://bugs.webkit.org/show_bug.cgi?id=111448
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-06
Reviewed by Alexey Proskuryakov.
Implement WebInspector::localizedStringsURL() method to return the
file URL of the localizedStrings.js.
This prevents printing warnings about "Localized string not found" in
the console.
- WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspector::localizedStringsURL):
- 2:24 PM Changeset in webkit [144981] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: svg/custom/foreign-object-skew.svg
- 2:24 PM Changeset in webkit [144980] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] |m_gestureScrollOnImplThread| is not reset to false following the end of a fling on the fast path
https://bugs.webkit.org/show_bug.cgi?id=111390
Reviewed by James Robinson.
If there is a fast path gesture scroll which turns into a fling, the member
|m_gestureScrollOnImplThread| is not reset to false once the fling ends. As a
result, GestureScrollUpdate events belonging to a subsequent scroll are always
handled on the fast path, even if they should have been handled on the slow
path instead.
- src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::cancelCurrentFling):
- src/WebCompositorInputHandlerImpl.h:
(WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::isGestureScrollOnImplThread):
- tests/WebCompositorInputHandlerImplTest.cpp:
(WebKit::TEST_F):
(WebKit):
- 2:22 PM Changeset in webkit [144979] by
-
- 4 edits in branches/safari-536.29-branch/Source
Versioning.
- 2:20 PM Changeset in webkit [144978] by
-
- 1 copy in tags/Safari-536.29.4
New Tag.
- 2:12 PM Changeset in webkit [144977] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Selection handles don't drag to expand correctly for RTL languages
https://bugs.webkit.org/show_bug.cgi?id=111618
Reviewed by Rob Buis.
PR 303712
If we are using a RTL language, we should ensure that the selection handles are angled the right way.
Further, when expanding the selection, the start and end handles should be appropriately set so that
expansion in the natural direction is possible.
Internally reviewed by Mike Fenton.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::SelectionHandler):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- WebKitSupport/SelectionHandler.h:
(SelectionHandler):
- 1:38 PM Changeset in webkit [144976] by
-
- 5 edits in trunk/Source/WebCore
Use SkTypeface API directly, rather than (soon to be private) SkFontHost
https://bugs.webkit.org/show_bug.cgi?id=111588
Reviewed by Stephen White.
No new tests, as existing tests in fast/writing-mode exercise this code.
e.g. japanese-rl-text-with-broken-font.html
vertical-subst-font-vert-no-dflt.html
- platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::emSizeInFontUnits):
(WebCore::FontPlatformData::openTypeTable):
- platform/graphics/harfbuzz/HarfBuzzFaceSkia.cpp:
(WebCore::harfBuzzSkiaGetTable):
(WebCore::HarfBuzzFace::createFace):
- platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformInit):
- 1:35 PM Changeset in webkit [144975] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] REGRESSION(r143582): API test EWK2UnitTestBase.ewk_view_contents_size_changed failing
https://bugs.webkit.org/show_bug.cgi?id=110608
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-06
Reviewed by Kenneth Rohde Christiansen.
Test was expecting ContentsSizeChanged signal from ViewClientEfl, but
WebView was not calling client callback if useFixedLayout() is true.
This patch prevent early return if useFixedLayout() is true and call
client callback didChangeContentsSize(), which will emit the signal.
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didChangeContentsSize):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::didChangeContentsSize):
- 1:25 PM Changeset in webkit [144974] by
-
- 6 edits in trunk
Source/WebCore: Cleanup in multipart FormData sending code.
https://bugs.webkit.org/show_bug.cgi?id=111603
Patch by Victor Costan <costan@gmail.com> on 2013-03-06
Reviewed by Alexey Proskuryakov.
No new tests. This is cleanup.
- platform/network/FormDataBuilder.cpp:
(WebCore::appendQuotedString): use proper types (e.g, size_t instead of
unsigned long)
LayoutTests: Cleanup in multipart FormData tests.
https://bugs.webkit.org/show_bug.cgi?id=111603
Patch by Victor Costan <costan@gmail.com> on 2013-03-06
Reviewed by Alexey Proskuryakov.
- http/tests/local/formdata/resources/send-form-data-common.js:
(sendFormData): JavaScript style cleanup.
(testSendingFormData): JavaScript style, bugfix in checking if
eventSender.beginDragWithFiles needs to be called.
- http/tests/local/formdata/send-form-data-with-filename-expected.txt: Better test description.
- http/tests/local/formdata/send-form-data-with-filename.html: Better test description.
- 1:23 PM Changeset in webkit [144973] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG should not run full CSE after the optimization fixpoint, since it really just wants store elimination
https://bugs.webkit.org/show_bug.cgi?id=111536
Reviewed by Oliver Hunt and Mark Hahnenberg.
The fixpoint will do aggressive load elimination and pure CSE. There's no need to do it after the fixpoint.
On the other hand, the fixpoint does not profit from doing store elimination (except for SetLocal/Flush).
Previously we had CSE do both, and had it avoid doing some store elimination during the fixpoint by querying
the fixpoint state. This changes CSE to be templated on mode - either NormalCSE or StoreElimination - so
that we explicitly put it into one of those modes depending on where we call it from. The goal is to reduce
time spent doing load elimination after the fixpoint, since that is just wasted cycles.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::CSEPhase):
(JSC::DFG::CSEPhase::run):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::performBlockCSE):
(JSC::DFG::performCSE):
(DFG):
(JSC::DFG::performStoreElimination):
- dfg/DFGCSEPhase.h:
(DFG):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- 1:21 PM Changeset in webkit [144972] by
-
- 2 edits in trunk/Source/WebCore
Threaded HTML parser should use 8 bit strings for attributes
https://bugs.webkit.org/show_bug.cgi?id=111610
Reviewed by Eric Seidel.
This fixes a 27% regression in dromaeo_jslibattrjquery on the threaded HTML parser vs. the main thread parser.
No new tests because no new functionality.
- html/parser/CompactHTMLToken.cpp:
(WebCore::CompactHTMLToken::CompactHTMLToken):
- 1:16 PM Changeset in webkit [144971] by
-
- 2 edits in trunk/Source/WTF
Make fastmalloc use guardpages
https://bugs.webkit.org/show_bug.cgi?id=111353
Reviewed by Anders Carlsson.
Add PROT_NONE pages at the beginning and end of every
mmap call made by fastmalloc.
- wtf/TCSystemAlloc.cpp:
(TryMmap):
- 1:12 PM Changeset in webkit [144970] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Express webkit_unit_tests' dependency on DumpRenderTree.pak in gyp
https://bugs.webkit.org/show_bug.cgi?id=111508
Patch by James Robinson <jamesr@chromium.org> on 2013-03-06
Reviewed by Dirk Pranke.
Some tests in webkit_unit_tests, for example WebPageSerializerTest.HTMLNodes, depend on localizable resources
from a pak file. Since unit tests initialize for testing with the same webkit_support functions as layout tests
they end up using DumpRenderTree.pak, but this dependency isn't listed explicitly in the gyp so if you manage to
run webkit_unit_tests without building DumpRenderTree first these tests just crash.
This adds a dependency from webkit_unit_tests to DumpRenderTree_resources so the pak is always built. It's a bit
weird for a gyp file in Source/WebKit/chromium/ to reach into Tools/DumpRenderTree, but I can't think of
anything better.
- WebKitUnitTests.gyp:
- 1:09 PM Changeset in webkit [144969] by
-
- 4 edits in trunk
[WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
https://bugs.webkit.org/show_bug.cgi?id=82866
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-06
Reviewed by Martin Robinson.
Source/WebKit2:
Test was failing because of new media controls needs more space to be
painted than just 10x10 pixels. This is similar to r144070.
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewMouseTarget): Modified HTML in order to give more space to the media controls.
Tools:
- Scripts/run-gtk-tests:
(TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
it is passing now.
- 1:00 PM Changeset in webkit [144968] by
-
- 3 edits in trunk/Tools
Dashboard cleanup: remove dashboard time logging.
https://bugs.webkit.org/show_bug.cgi?id=111608
Reviewed by Dirk Pranke.
Remove logTime. It was never accurate, and the dev tools
have better ways to measure this if anyone cares to look
into dashboard perf.
- TestResultServer/static-dashboards/dashboard_base.js:
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(processTestRunsForBuilder):
(appendHTML):
- 12:58 PM Changeset in webkit [144967] by
-
- 3 edits in branches/chromium/1410
Merge 144789
REGRESSION(r142191): Fix closed caption buttons for ports still using the painting path.
https://bugs.webkit.org/show_bug.cgi?id=111109
Reviewed by Eric Carlson.
Source/WebCore:
Covered by following tests:
media/track/track-cue-rendering-horizontal.html
media/track/track-cue-rendering-vertical.html
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
- rendering/RenderTheme.h:
(WebCore::RenderTheme::paintMediaToggleClosedCaptionsButton):
LayoutTests:
- platform/chromium/TestExpectations:
TBR=scherkus@chromium.org
Review URL: https://codereview.chromium.org/12463019
- 12:45 PM Changeset in webkit [144966] by
-
- 2 edits in trunk/Tools
[chromium] making DumpRenderTree_resources a separate bundle breaks xcode
https://bugs.webkit.org/show_bug.cgi?id=111509
Reviewed by Dirk Pranke.
Add DumpRenderTree.pak to DumpRenderTree.app again.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 12:42 PM Changeset in webkit [144965] by
-
- 2 edits in trunk/LayoutTests
Add a flaky crash test expectation to platform/mac/fast/speechsynthesis/speech-synthesis-cancel.html
on Mac per 111613.
- platform/mac/TestExpectations:
- 12:31 PM Changeset in webkit [144964] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: animations/animation-delay-changed.html
- 12:24 PM Changeset in webkit [144963] by
-
- 6 edits in trunk/LayoutTests
fast/css/hover-update.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=111592
Reviewed by Ryosuke Niwa.
Speculative fix for a flaky test. The test sometimes fails on slower machines (mostly debug).
Re-check the results in a loop for up to 200ms to see if the :hover pseudo style applies.
Also force a layout after changing the style, which should also trigger the :hover style.
- fast/css/hover-update.html:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- 12:16 PM Changeset in webkit [144962] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening: svg/custom/foreign-object-skew.svg
- platform/chromium/TestExpectations:
- 12:09 PM Changeset in webkit [144961] by
-
- 5 edits in trunk/Source/WebCore
More cleanup in GIFImageReader
https://bugs.webkit.org/show_bug.cgi?id=111137
Reviewed by Stephen White.
Refactor GIFImageReaderReader with the following changes:
+ Separate GIFLZWContext for decoding states.
+ Replace unsigned char* with Vector<unsigned char>
There is no change in code behavior and just refactoring.
No new tests. This is covered by existing GIFImageReaderTest.
I also did a local testing on a 50k image corpus and showed no regression.
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::haveDecodedRow):
- platform/image-decoders/gif/GIFImageDecoder.h:
(GIFImageDecoder):
- platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::outputRow):
(GIFImageReader::doLZW):
(GIFImageReader::decodeInternal):
(GIFImageReader::prepareLZWContext):
- platform/image-decoders/gif/GIFImageReader.h:
(GIFFrameContext):
(GIFFrameContext::GIFFrameContext):
(GIFFrameContext::~GIFFrameContext):
(GIFLZWContext):
(GIFLZWContext::GIFLZWContext):
(GIFImageReader):
- 12:05 PM Changeset in webkit [144960] by
-
- 2 edits in trunk/Source/WebKit2
[wk2] Page Overlays: Hook up the layer border/repaint counter setting to the overlay layer
https://bugs.webkit.org/show_bug.cgi?id=111547
<rdar://problem/13355801>
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
Keep the page overlay layer's debug border and repaint counter settings updated.
- 11:51 AM Changeset in webkit [144959] by
-
- 4 edits in trunk/Source/WebCore
Fix typo'd MainThreadScrollingBecauseOfStyleIndictaion
https://bugs.webkit.org/show_bug.cgi?id=111557
Reviewed by Geoff Garen.
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::commitTreeState):
- platform/graphics/TiledBacking.h:
- platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::updateTileCoverageMap):
- 11:48 AM Changeset in webkit [144958] by
-
- 3 edits in trunk/Source/WebKit2
Joing the adoptNS/adoptCF/adoptRef club.
https://bugs.webkit.org/show_bug.cgi?id=111467
Reviewed by Darin Adler.
Responding to review comments by Darin Adler.
- NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcess):
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess): Tighten up this code
by reducing extraneous local variables.
- 11:43 AM Changeset in webkit [144957] by
-
- 3 edits in trunk/Source/JavaScriptCore
Pack Structure members better.
<http://webkit.org/b/111593>
<rdar://problem/13359200>
Reviewed by Mark Hahnenberg.
Shrink Structure by 8 bytes (now at 104 bytes) on 64-bit by packing the members better.
- runtime/Structure.cpp:
(JSC::Structure::Structure):
- runtime/Structure.h:
(Structure):
- 11:34 AM Changeset in webkit [144956] by
-
- 2 edits1 add13 deletes in trunk/LayoutTests
editing/pasteboard/paste-table-cells.html should be a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=111491
Reviewed by Levi Weintraub.
Converted the test.
- editing/pasteboard/paste-table-cells-expected.txt: Added.
- editing/pasteboard/paste-table-cells.html:
- platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.png: Removed.
- platform/chromium-mac-lion/editing/pasteboard/paste-table-cells-expected.png: Removed.
- platform/chromium-mac-snowleopard/editing/pasteboard/paste-table-cells-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-table-cells-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-table-cells-expected.txt: Removed.
- platform/chromium/editing/pasteboard/paste-table-cells-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-table-cells-expected.png: Removed.
- platform/gtk/editing/pasteboard/paste-table-cells-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-table-cells-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-table-cells-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-table-cells-expected.png: Removed.
- platform/qt/editing/pasteboard/paste-table-cells-expected.txt: Removed.
- 11:31 AM Changeset in webkit [144955] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Use the new authenticationChallenge API in WebPage
https://bugs.webkit.org/show_bug.cgi?id=111542
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-06
Reviewed by Rob Buis.
Use the new API that expects requestURL and isProxy parameters.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
- Api/WebPageClient.h:
- 11:29 AM Changeset in webkit [144954] by
-
- 4 edits11 adds22 deletes in trunk/LayoutTests
Unreviewed chromium windows rebaselines for r144837.
- platform/chromium-linux/fast/invalid/017-expected.txt: Removed.
- platform/chromium-linux/fast/invalid/018-expected.txt: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
- platform/chromium-mac-lion/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/chromium-win/fast/invalid/017-expected.txt:
- platform/chromium-win/fast/invalid/018-expected.txt:
- platform/chromium-win/tables/mozilla/bugs/bug113235-2-expected.txt:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
- platform/chromium/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/efl/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
- platform/mac-lion/tables/mozilla/bugs: Removed.
- platform/mac-lion/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
- platform/mac-lion/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/mac-wk2/tables/mozilla/bugs: Removed.
- platform/mac-wk2/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
- platform/mac-wk2/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/mac/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
- platform/qt/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
- platform/win-future/tables: Added.
- platform/win-future/tables/mozilla: Added.
- platform/win-future/tables/mozilla/bugs: Added.
- platform/win-future/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
- platform/win-future/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/win-future/tables/mozilla_expected_failures: Added.
- platform/win-future/tables/mozilla_expected_failures/bugs: Added.
- platform/win-future/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
- tables/mozilla/bugs/bug113235-2-expected.txt: Replaced.
- tables/mozilla/bugs/bug9024-expected.txt: Replaced.
- tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Replaced.
- 11:28 AM Changeset in webkit [144953] by
-
- 18 edits in trunk/Source
Removed some dead code in the page cache
https://bugs.webkit.org/show_bug.cgi?id=111525
Reviewed by Alexey Proskuryakov.
Page cache autorelease doesn't exist anymore, so there's no need to keep
around these olds hacks.
../WebCore:
- WebCore.exp.in:
- history/PageCache.cpp:
(WebCore::PageCache::PageCache):
(WebCore):
- history/PageCache.h:
(PageCache):
- page/Settings.cpp:
(WebCore::Settings::setUsesPageCache):
- platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::releaseMemory):
- platform/qt/QtTestSupport.cpp:
(WebKit::QtTestSupport::clearMemoryCaches):
../WebKit/blackberry:
- Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::clearMemoryCaches):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::destroy):
../WebKit/efl:
- ewk/ewk_settings.cpp:
(ewk_settings_memory_cache_clear):
../WebKit/mac:
This fixes <rdar://problem/4886761> Fix bizarre WebWindowWatcher policy in WebHistoryItem.
- History/WebHistoryItem.mm:
(+[WebHistoryItem _releaseAllPendingPageCaches]):
- History/WebHistoryItemInternal.h:
- Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics autoreleasedPageCount]):
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
- 11:28 AM Changeset in webkit [144952] by
-
- 1 edit in branches/chromium/1410/Source/WebCore/platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp
Merge 144688
[chromium] Form controls on composited layers are not painted properly
https://bugs.webkit.org/show_bug.cgi?id=111366
Reviewed by James Robinson.
Set PlatformContextSkia::m_drawingToImageBuffer which is used as a hint to properly blend GDI-painted bitmap.
- platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
TBR=alokp@chromium.org
Review URL: https://codereview.chromium.org/12425009
- 11:08 AM Changeset in webkit [144951] by
-
- 6 edits2 adds in trunk
[chromium] introduce WebUserGestureIndicator
https://bugs.webkit.org/show_bug.cgi?id=111531
Reviewed by Adam Barth.
Source/WebKit/chromium:
Currently, an embedder needs to have a WebFrame to check whether a
user gesture is being processed and to consume a user gesture. However,
the user gesture state is independed of a frame.
- WebKit.gyp:
- public/WebFrame.h:
(WebFrame):
- public/WebUserGestureIndicator.h: Added.
(WebKit):
(WebUserGestureIndicator):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::isProcessingUserGesture):
(WebKit::WebFrameImpl::consumeUserGesture):
- src/WebUserGestureIndicator.cpp: Added.
(WebKit):
(WebKit::WebUserGestureIndicator::isProcessingUserGesture):
(WebKit::WebUserGestureIndicator::consumeUserGesture):
Tools:
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createView):
- 11:05 AM Changeset in webkit [144950] by
-
- 13 edits2 deletes in trunk
Unreviewed, rolling out r144924.
http://trac.webkit.org/changeset/144924
https://bugs.webkit.org/show_bug.cgi?id=109908
caused multiple crashes in inspector/debugger tests
Source/WebCore:
- bindings/js/JSInjectedScriptHostCustom.cpp:
- bindings/js/ScriptObject.h:
- bindings/v8/ScriptObject.h:
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
- inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::create):
(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::disconnect):
- inspector/InjectedScriptHost.h:
(WebCore):
(InjectedScriptHost):
- inspector/InjectedScriptHost.idl:
- inspector/InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::InjectedScriptManager):
(WebCore::InjectedScriptManager::discardInjectedScripts):
(WebCore::InjectedScriptManager::discardInjectedScriptsFor):
- inspector/InjectedScriptManager.h:
(InjectedScriptManager):
- inspector/InjectedScriptSource.js:
(.):
LayoutTests:
- inspector-protocol/persistent-id-expected.txt: Removed.
- inspector-protocol/persistent-id.html: Removed.
- inspector/console/command-line-api-expected.txt:
- 10:55 AM Changeset in webkit [144949] by
-
- 34 edits in trunk/Source
Introduce new message sources for logging.
https://bugs.webkit.org/show_bug.cgi?id=110968
Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-06
Reviewed by Pavel Feldman.
Source/WebCore:
Added SecurityMessageSource, RenderingMessageSource, StorageMessageSource, AppCacheMessageSource, CSSMessageSource.
Changed some logging lines to contain more descriptive message source.
- Modules/webdatabase/DatabaseBase.cpp:
(WebCore::DatabaseBase::logErrorMessage):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::logErrorMessage):
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::fail):
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::canExecuteScripts):
- css/MediaList.cpp:
(WebCore::addResolutionWarningMessageToConsole):
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::executeScript):
(WebCore::ScriptElement::notifyFinished):
- dom/ViewportArguments.cpp:
(WebCore::reportViewportWarning):
- html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::validateInteractively):
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseAttribute):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::getImageData):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::printWarningToConsole):
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init):
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript):
- inspector/ConsoleMessage.cpp:
(WebCore::messageSourceValue):
- inspector/Inspector.json:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::reportLocalLoadFailed):
(WebCore::createWindow):
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::notifyFinished):
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::responseReceived):
- loader/MixedContentChecker.cpp:
(WebCore::MixedContentChecker::logWarning):
- loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::corsPolicyPreventedLoad):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::abort):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::printAccessDeniedMessage):
- page/Console.cpp:
(WebCore::printMessageSourceAndLevelPrefix):
- page/ConsoleTypes.h:
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::logToConsole):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchMessageEventWithOriginCheck):
- page/PointerLockController.cpp:
(WebCore::PointerLockController::requestPointerLock):
- svg/SVGDocumentExtensions.cpp:
(WebCore::reportMessage):
Source/WebKit/mac:
- WebCoreSupport/WebChromeClient.mm:
- WebView/WebUIDelegatePrivate.h:
- 10:51 AM Changeset in webkit [144948] by
-
- 3 edits2 adds in trunk
SVG pattern to pattern reference does not work if first pattern has a child node
https://bugs.webkit.org/show_bug.cgi?id=111586
Reviewed by Philip Rogers.
Source/WebCore:
SVGPatternElement::collectPatternAttributes should test for child elements, not child nodes.
Tests: svg/custom/pattern-reference-expected.svg
svg/custom/pattern-reference.svg
- svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::collectPatternAttributes):
LayoutTests:
- svg/custom/pattern-reference-expected.svg: Added.
- svg/custom/pattern-reference.svg: Added.
- 10:50 AM Changeset in webkit [144947] by
-
- 5 edits1 copy in branches/chromium/1410/Source
Merge 144323
IndexedDB: IO error when checking schema should destroy LevelDB directory
https://bugs.webkit.org/show_bug.cgi?id=110675
Reviewed by Adam Barth.
Source/WebCore:
Also some refactoring to remove IDBBackingStore's dependence on
static LevelDBDatabase methods. This facilitated the unit test.
New unit test - IDBIOErrorTest.CleanUpTest
- Modules/indexeddb/IDBBackingStore.cpp:
(DefaultLevelDBFactory):
Wraps the previous behavior.
(WebCore::IDBBackingStore::open):
The default parameter provides the previous behavior, which is what
non-tests want.
- Modules/indexeddb/IDBBackingStore.h:
- platform/leveldb/LevelDBDatabase.h:
Source/WebKit/chromium:
- WebKit.gyp:
This was cargo-culted. The component build wouldn't run otherwise.
- WebKit.gypi:
- tests/IDBCleanupOnIOErrorTest.cpp: Added.
TBR=dgrogan@chromium.org
Review URL: https://codereview.chromium.org/12549003
- 10:46 AM Changeset in webkit [144946] by
-
- 2 edits in trunk/Source/Platform
[chromium] Remove the contents of WebVideoFrame class
https://bugs.webkit.org/show_bug.cgi?id=106037
Reviewed by James Robinson.
This class becomes an empty base class now, used only for the API
boundary.
- chromium/public/WebVideoFrame.h:
(WebKit):
- 10:37 AM Changeset in webkit [144945] by
-
- 6 edits3 adds in trunk/Source/WebKit2
Track sandbox extensions for blobs in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=111484
Reviewed by Sam Weinig.
- WebKit2.xcodeproj/project.pbxproj:
- NetworkProcess/FileAPI: Added.
- NetworkProcess/FileAPI/NetworkBlobRegistry.cpp: Added.
- NetworkProcess/FileAPI/NetworkBlobRegistry.h: Added. Added a registry that wraps normal in-process "BlobRegistryImpl", and also tracks sandbox extensions for blobs. It will also track process connections, so that blobs could be removed when a process crashes.
- NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::registerBlobURL): (WebKit::NetworkConnectionToWebProcess::registerBlobURLFromURL): (WebKit::NetworkConnectionToWebProcess::unregisterBlobURL): Use NetworkBlobRegistry.
- NetworkProcess/SchedulableLoader.h:
- NetworkProcess/SchedulableLoader.cpp: (WebKit::SchedulableLoader::SchedulableLoader): Add extensions for blobs, both in request URL and in request data. (WebKit::SchedulableLoader::consumeSandboxExtensions): Request may now have multiple extensions. (WebKit::SchedulableLoader::invalidateSandboxExtensions): Ditto.
- Shared/FileAPI/BlobRegistrationData.cpp: Fixed extension creation - actually store the result.
- 10:20 AM Changeset in webkit [144944] by
-
- 2 edits in trunk/LayoutTests
Add a flaky failure expectation to fast/css/hover-update.html on Mac per bug 111592.
- platform/mac/TestExpectations:
- 10:15 AM WebKitGTK/2.0.x edited by
- (diff)
- 10:11 AM Changeset in webkit [144943] by
-
- 2 edits in trunk/Source/WebKit/gtk
Link the webkit_tests to XRENDER_LIBS.
This solves the linking failure when building against gtk2 like:
usr/lib/gcc/i586-suse-linux/4.7/../../../../i586-suse-linux/bin/ld:
Source/WebCore/platform/gtk/Programs_unittests_testcopyandpaste-GtkVersioning.o:
undefined reference to symbol 'XFree'
/usr/lib/gcc/i586-suse-linux/4.7/../../../../i586-suse-linux/bin/ld:
note: 'XFree' is defined in DSO /usr/lib/libX11.so.6 so try adding it
to the linker command line
/usr/lib/libX11.so.6: could not read symbols: Invalid operation
https://bugs.webkit.org/show_bug.cgi?id=111572
Patch by Dominique Leuenberger <dimstar@opensuse.org> on 2013-03-06
Reviewed by Gustavo Noronha Silva.
- GNUmakefile.am:
- 10:10 AM Changeset in webkit [144942] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix Windows build after r144910.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 10:05 AM Changeset in webkit [144941] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r186371. Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-06
- DEPS:
- 9:53 AM Changeset in webkit [144940] by
-
- 7 edits1 add in trunk/Tools
sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
https://bugs.webkit.org/show_bug.cgi?id=73482
Patch by Alan Cutter <alancutter@chromium.org> on 2013-03-06
Reviewed by Ryosuke Niwa.
Added input checking to the UpdateChromiumDEPS step.
Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
- Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
(RollChromiumDEPS):
(RollChromiumDEPS._parse_args):
(RollChromiumDEPS.execute):
- Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
(IRCCommandTest.test_roll_chromium_deps):
- Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
(IRCBotTest.test_roll_chromium_deps_to_lkgr):
- Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
- Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
(UpdateChromiumDEPS._fetch_last_known_good_revision):
(UpdateChromiumDEPS):
(UpdateChromiumDEPS._parse_revision_number):
(UpdateChromiumDEPS._validate_revisions):
(UpdateChromiumDEPS.run):
- Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
(UpdateChromiumDEPSTest):
(UpdateChromiumDEPSTest.test_parse_revision_number):
- Scripts/webkitpy/tool/commands/roll.py: Updated help text.
(RollChromiumDEPS):
(PostChromiumDEPSRoll):
- 9:41 AM Changeset in webkit [144939] by
-
- 8 edits in trunk/Source/JavaScriptCore
DFG should not check if nodes are shouldGenerate prior to DCE
https://bugs.webkit.org/show_bug.cgi?id=111520
Reviewed by Geoffrey Garen.
All nodes are live before DCE. We don't need to check that they aren't, because they
definitely will be.
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::int32ToDoubleCSE):
(JSC::DFG::CSEPhase::constantCSE):
(JSC::DFG::CSEPhase::weakConstantCSE):
(JSC::DFG::CSEPhase::getCalleeLoadElimination):
(JSC::DFG::CSEPhase::getArrayLengthElimination):
(JSC::DFG::CSEPhase::globalVarLoadElimination):
(JSC::DFG::CSEPhase::scopedVarLoadElimination):
(JSC::DFG::CSEPhase::globalVarWatchpointElimination):
(JSC::DFG::CSEPhase::globalVarStoreElimination):
(JSC::DFG::CSEPhase::scopedVarStoreElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkStructureElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::putByOffsetStoreElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::checkArrayElimination):
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::getMyScopeLoadElimination):
(JSC::DFG::CSEPhase::getLocalLoadElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
- 9:39 AM Changeset in webkit [144938] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix unused parameter warnings in ARM assembler
https://bugs.webkit.org/show_bug.cgi?id=111433
Reviewed by Kentaro Hara.
- assembler/ARMAssembler.h: Remove unreachable revertJump() after r143346.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::moveIntsToDouble): Remove unused scratch parameter instead of UNUSED_PARAM.
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32): Remove unused fpTemp parameter.
(JSC::MacroAssemblerARM::revertJumpReplacementToPatchableBranchPtrWithPatch): Remove unused parameters.
- 9:32 AM Changeset in webkit [144937] by
-
- 4 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Added new baseline after r144837.
- platform/qt/fast/invalid/017-expected.txt:
- platform/qt/fast/invalid/018-expected.txt:
- platform/qt/tables/mozilla/bugs/bug113235-2-expected.txt:
- platform/qt/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
- 9:29 AM WebKitGTK/2.0.x edited by
- (diff)
- 9:25 AM Changeset in webkit [144936] by
-
- 2 edits in trunk/Source/WebCore
[soup] session cookies are not correctly reported in getRawCookies()
https://bugs.webkit.org/show_bug.cgi?id=111584
Reviewed by Martin Robinson.
As per libsoup documentation, SoupCookie->expires is NULL for session cookies.
However, the soup implementation for getRawCookies() does not check for NULL
case before passing the value to soup_date_to_time_t(), which leads to run time
warnings.
We should also pass true for WebCore::Cookie's session argument if
SoupCookie->expires is NULL. The current implementation reports the cookie as a
session one if soup_cookie_jar_is_persistent(jar) returns true, which is
inaccurate.
No new tests, no behavior change for layout tests as Web Inspector currently
ignores the "session" member and uses expires/max-age instead to deduce it.
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::getRawCookies):
- 9:14 AM Changeset in webkit [144935] by
-
- 4 edits2 adds in trunk
REGRESSION(r111639): delayed animation start can be postponed
https://bugs.webkit.org/show_bug.cgi?id=108582
Source/WebCore:
Query the animation timer directly for the time it will next fire rather than
trying to cache the interval. Previous approach was incorrect -- as time advanced
it was possible for the interval to jump beyond the next service time.
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2013-03-06
Reviewed by Darin Adler.
Test: animations/animation-delay-changed.html
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
(WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer):
(WebCore::AnimationControllerPrivate::updateAnimationTimer):
- page/animation/AnimationControllerPrivate.h:
(AnimationControllerPrivate): Remove m_previousTimeToNextService
LayoutTests:
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2013-03-06
Reviewed by Darin Adler.
- animations/animation-delay-changed-expected.txt: Added.
- animations/animation-delay-changed.html: Added.
- 9:07 AM HackingGtk edited by
- (diff)
- 9:04 AM HackingGtk edited by
- (diff)
- 8:54 AM WebKitGTK/2.0.x edited by
- (diff)
- 8:51 AM Changeset in webkit [144934] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [ACE] show execution line in Ace editor
https://bugs.webkit.org/show_bug.cgi?id=111575
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-06
Reviewed by Pavel Feldman.
Highlight execution line by the means of Ace full line markers.
No new tests.
- inspector/front-end/AceTextEditor.js:
(WebInspector.AceTextEditor.prototype.setExecutionLine):
(WebInspector.AceTextEditor.prototype.clearExecutionLine):
(WebInspector.AceTextEditor.prototype.setSelection):
- inspector/front-end/ace/acedevtools.css:
(.ace-editor-container):
(.webkit-execution-line):
- 8:42 AM WebKitGTK/2.0.x edited by
- (diff)
- 8:39 AM WebKitGTK/2.0.x edited by
- (diff)
- 8:39 AM WebKitGTK/2.0.x edited by
- (diff)
- 8:38 AM WebKitGTK/2.0.x edited by
- (diff)
- 8:28 AM Changeset in webkit [144933] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/efl/TestExpectations: Adjusting the expectation for fast/workers/shared-worker-load-error.html.
- platform/gtk/TestExpectations: Add an expectation for a test added in r144824.
- 8:28 AM Changeset in webkit [144932] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: fix closure compiler warnings in the profiler code
https://bugs.webkit.org/show_bug.cgi?id=111581
Reviewed by Vsevolod Vlasov.
Added missing annotations. Replaced NativeProfileLauncherView with
ProfileLauncherView.
- inspector/InjectedScriptExterns.js:
(InjectedScriptHost.prototype.objectId):
(InjectedScriptHost.prototype.releaseObjectId):
- inspector/front-end/FlameChart.js:
(WebInspector.FlameChart.prototype._forEachNode):
- inspector/front-end/ProfileLauncherView.js:
- inspector/front-end/ProfilesPanel.js:
- 8:00 AM Changeset in webkit [144931] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Pass String::StrictConversion instead of true to String::utf8()
https://bugs.webkit.org/show_bug.cgi?id=111546
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-06
Reviewed by Rob Buis.
String::utf8() API changed in r134173.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::notifyChallengeResult):
- 7:48 AM Changeset in webkit [144930] by
-
- 2 edits in trunk/Source/WebCore
Remove the (dead) code for handling shorthands in StyleResolver / StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=111505
Unreviewed minimal build fix.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Put CSSPropertyWebkitWrap under the proper if-guard.
- 7:45 AM Changeset in webkit [144929] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed follow up to r144928: front-end closure compilation fixes.
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.JavaScriptOutlineDialog.prototype.dispose):
(WebInspector.OpenResourceDialog.prototype.dispose):
- inspector/front-end/StyleSheetOutlineDialog.js:
(WebInspector.StyleSheetOutlineDialog.prototype.dispose):
- 7:34 AM Changeset in webkit [144928] by
-
- 5 edits in trunk
Web Inspector: Update open resource dialog when new uiSourceCodes are loaded.
https://bugs.webkit.org/show_bug.cgi?id=111327
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog):
(WebInspector.FilteredItemSelectionDialog.prototype.willHide):
(WebInspector.FilteredItemSelectionDialog.prototype._itemsLoaded):
(WebInspector.FilteredItemSelectionDialog.prototype._updateAfterItemsLoaded):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems.compareFunction):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
(WebInspector.SelectionDialogContentProvider.prototype.dispose):
(WebInspector.JavaScriptOutlineDialog.prototype._didBuildOutlineChunk):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.prototype.requestItems):
(WebInspector.OpenResourceDialog.prototype._filterUISourceCode):
(WebInspector.OpenResourceDialog.prototype._uiSourceCodeAdded):
(WebInspector.OpenResourceDialog.prototype.dispose):
- inspector/front-end/StyleSheetOutlineDialog.js:
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems):
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems.didGetStyleSheet):
LayoutTests:
- inspector/filtered-item-selection-dialog-filtering.html:
- 7:23 AM Changeset in webkit [144927] by
-
- 9 edits2 adds in trunk/Source/WebCore
Web Inspector: Move sidebar-specific styles to a separate file.
https://bugs.webkit.org/show_bug.cgi?id=111173
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-06
Reviewed by Pavel Feldman.
- WebCore.gypi:
- inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane):
(WebInspector.EventListenerBreakpointsSidebarPane):
- inspector/front-end/NativeBreakpointsSidebarPane.js:
(WebInspector.NativeBreakpointsSidebarPane):
- inspector/front-end/SidebarPane.js:
(WebInspector.SidebarPaneTitle):
(WebInspector.SidebarPaneStack):
(WebInspector.SidebarTabbedPane):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/breakpointsList.css: Added.
(.sidebar-pane > .body .breakpoint-condition):
(#breakpoint-condition-input):
(ol.breakpoint-list):
(.breakpoints-list-deactivated):
(.breakpoint-list li):
(.breakpoint-list li:hover):
(.breakpoint-list .checkbox-elem):
(.breakpoint-list .source-text):
(.sidebar-pane .breakpoint-hit):
(li.breakpoint-hit .breakpoint-hit-marker):
(.event-listener-breakpoints .event-category):
(.event-listener-breakpoints.properties-tree .children li):
(.event-listener-breakpoints .checkbox-elem):
- inspector/front-end/elementsPanel.css:
(.panel.elements .sidebar-pane-toolbar > select):
(.panel.elements .sidebar-pane-toolbar > select:hover):
(.panel.elements .sidebar-pane-toolbar > select:active):
(.panel.elements .sidebar-pane-toolbar > select.select-settings):
(.panel.elements .sidebar-pane-toolbar > select.select-filter):
(.panel.elements .sidebar-pane-toolbar > select > option, .panel.elements .sidebar-pane-toolbar > select > hr):
- inspector/front-end/inspector.css:
(.event-bar .event-properties):
- inspector/front-end/scriptsPanel.css:
(.workers-list > li):
(a.worker-item):
(a.worker-item:hover):
- inspector/front-end/sidebarPane.css: Added.
(.sidebar-pane):
(.sidebar-pane > .body):
(.sidebar-pane > .body .info):
(.sidebar-pane > .body .placard + .info):
(.sidebar-pane.visible > .body):
(.sidebar-pane .section .properties):
(.sidebar-tabbed-pane .tabbed-pane-header):
(.sidebar-pane-stack > .sidebar-pane.visible:nth-last-of-type(1)):
(.sidebar-pane-title):
(.sidebar-pane-title + .sidebar-pane-title, .pane:not(.visible) + .sidebar-pane-title, .sidebar-pane-title:first-of-type):
(.sidebar-pane-title:active):
(.sidebar-pane-title::before):
(.sidebar-pane-title.expanded::before):
(.sidebar-pane-toolbar):
(.sidebar-pane-toolbar > *):
(.sidebar-pane-toolbar > .pane-title-button):
(.sidebar-pane-toolbar > .pane-title-button:hover):
(.sidebar-pane-toolbar > .pane-title-button:active, .sidebar-pane-toolbar > .pane-title-button.toggled):
(.sidebar-pane-toolbar > .pane-title-button.add):
(.sidebar-pane-toolbar > .pane-title-button.element-state):
(.sidebar-pane-toolbar > .pane-title-button.refresh):
(.sidebar-pane-subtitle):
(body.platform-windows .sidebar-pane-subtitle):
(.sidebar-pane-subtitle input, .section .header input[type=checkbox]):
- 7:20 AM Changeset in webkit [144926] by
-
- 2 edits in trunk/Source/WebKit/chromium
Web Inspector: test that "importScript" is used only in module heads.
https://bugs.webkit.org/show_bug.cgi?id=111548
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-06
Reviewed by Pavel Feldman.
Test that output file after all inlines does not have any 'importScript(s)' statements.
- scripts/inline_js_imports.py:
(main):
- 7:20 AM Changeset in webkit [144925] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Combine style-related panes into a single tab when Elements panel is split horizontally.
https://bugs.webkit.org/show_bug.cgi?id=111550
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-06
Reviewed by Pavel Feldman.
Grouping the Elements sidebar panes into two tabbed panes proved to be
confusing and inconvenient. Put all the Elements sidebar panes into a single tabbed pane.
Combined Styles, Computed Style and Metrics into a single pane.
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._splitVertically):
(WebInspector.ElementsPanel.prototype.addExtensionSidebarPane):
- inspector/front-end/elementsPanel.css:
(.sidebar-pane.composite):
(.sidebar-pane.composite > .body):
(.sidebar-pane.composite .metrics):
(.sidebar-pane.composite .sidebar-pane-toolbar):
(.sidebar-pane.composite .sidebar-pane-toolbar > .sidebar-pane-subtitle):
(.sidebar-pane.composite .styles-section.read-only):
- 7:18 AM Changeset in webkit [144924] by
-
- 13 edits2 adds in trunk
Web Inspector: support stable remote object ids
https://bugs.webkit.org/show_bug.cgi?id=109908
Reviewed by Pavel Feldman.
Source/WebCore:
Introduced a map from javascript object to its id. It guarantees
that object is assined id only once (unless it is explicitely
released). The map is per execution context and is stored in
InjectedScriptManager.
Test: inspector-protocol/persistent-id.html
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::objectId):
(WebCore):
(WebCore::JSInjectedScriptHost::releaseObjectId):
- bindings/js/ScriptObject.h:
(WTF):
(WTF::ScriptObjectHash::hash):
(WTF::ScriptObjectHash::equal):
(ScriptObjectHash):
- bindings/v8/ScriptObject.h:
(WTF):
(WTF::ScriptObjectHash::hash):
(WTF::ScriptObjectHash::equal):
(ScriptObjectHash):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::objectIdMethodCustom):
(WebCore):
(WebCore::V8InjectedScriptHost::releaseObjectIdMethodCustom):
- inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::create):
(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::disconnect):
(WebCore::InjectedScriptHost::objectId):
(WebCore):
(WebCore::InjectedScriptHost::releaseObjectId):
- inspector/InjectedScriptHost.h:
(WebCore):
(InjectedScriptHost):
- inspector/InjectedScriptHost.idl:
- inspector/InjectedScriptManager.cpp:
(InjectedScriptManager::ObjectIdMap):
(WebCore::InjectedScriptManager::ObjectIdMap::ObjectIdMap):
(WebCore::InjectedScriptManager::ObjectIdMap::objectId):
(WebCore::InjectedScriptManager::ObjectIdMap::releaseObjectId):
(WebCore):
(WebCore::InjectedScriptManager::InjectedScriptManager):
(WebCore::InjectedScriptManager::discardInjectedScripts):
(WebCore::InjectedScriptManager::discardInjectedScriptsFor):
(WebCore::InjectedScriptManager::objectId):
(WebCore::InjectedScriptManager::releaseObjectId):
- inspector/InjectedScriptManager.h:
(InjectedScriptManager):
- inspector/InjectedScriptSource.js:
(.):
LayoutTests:
Test that same object will have same id if requested several times.
- inspector-protocol/persistent-id-expected.txt: Added.
- inspector-protocol/persistent-id.html: Added.
- inspector/console/command-line-api-expected.txt:
- 7:09 AM Changeset in webkit [144923] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Use CachedResource::resourceBuffer() instead of CachedResource::data()
https://bugs.webkit.org/show_bug.cgi?id=111555
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-06
Reviewed by Rob Buis.
CachedResource::data() was renamed to
CachedResource::resourceBuffer() in r130947.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
- 7:07 AM Changeset in webkit [144922] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove some unneeded header includes
https://bugs.webkit.org/show_bug.cgi?id=111545
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-06
Reviewed by Rob Buis.
- WebCoreSupport/CredentialTransformData.cpp:
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- 7:05 AM Changeset in webkit [144921] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Use hasTagName instead of hasLocalName in CredentialTransformData
https://bugs.webkit.org/show_bug.cgi?id=111544
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-06
Reviewed by Rob Buis.
hasLocalName() expects an AtomicString, but we are passing a
HTMLName which is a QualifiedName.
- WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::findPasswordFormFields): Use
hasTagName() instead of hasLocalName().
- 6:47 AM Changeset in webkit [144920] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
https://bugs.webkit.org/show_bug.cgi?id=111571
Gardening; added accessibility failure tests.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-06
- platform/efl-wk2/TestExpectations:
- 6:30 AM Changeset in webkit [144919] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r144617): Wrong usage of overwritten variable in toDOMWindow (V8Binding.cpp)
https://bugs.webkit.org/show_bug.cgi?id=111565
Patch by Marja Hölttä <marja@chromium.org> on 2013-03-06
Reviewed by Jochen Eisinger.
In toDOMWindow, the variable "global" was first nuked, and then used again. This
change was introduced in r144617.
No new tests (no functional changes).
- bindings/v8/V8Binding.cpp:
(WebCore::toDOMWindow):
- 6:29 AM Changeset in webkit [144918] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Illegal narrowing in tst_qwebhistory
https://bugs.webkit.org/show_bug.cgi?id=111562
Reviewed by Jocelyn Turcotte.
The bytearray in tst_QWebHistory::restoreIncompatibleVersion1 has integer
values higher than 127 assigned into an array of signed chars. This causes
compiler errors in C++11 since it assigns constants (>127) that does not
fit the destination (-128 to 127)
- tests/qwebhistory/tst_qwebhistory.cpp:
(tst_QWebHistory::restoreIncompatibleVersion1):
- 6:16 AM Changeset in webkit [144917] by
-
- 2 edits in trunk/Source/WTF
Typo in inline function in ByteOrder.h
https://bugs.webkit.org/show_bug.cgi?id=111473
Patch by Paweł Forysiuk <tuxator@o2.pl> on 2013-03-06
Reviewed by Benjamin Poulain.
- wtf/ByteOrder.h:
(ntohs):
- 6:07 AM Changeset in webkit [144916] by
-
- 8 edits in trunk/Source/WebCore
Web Inspector: use regular eval instead of injectScript for front-end extension API
https://bugs.webkit.org/show_bug.cgi?id=111529
Reviewed by Pavel Feldman.
Removed InjectedScriptManager::injectScript and replaced all of it calls
except the actual script injection with ScriptController::executeScript.
- inspector/InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::injectedScriptFor):
- inspector/InjectedScriptManager.h:
(InjectedScriptManager):
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::didClearWindowObjectInWorld):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype._emulateTouchEventsChanged.get if):
- inspector/front-end/ExtensionAPI.js:
(buildExtensionAPIInjectedScript):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onReload):
- 6:06 AM Changeset in webkit [144915] by
-
- 2 edits in trunk/Tools
[Qt][MiniBrowser] Touch mocking broken for chained getures
https://bugs.webkit.org/show_bug.cgi?id=111430
Reviewed by Jocelyn Turcotte.
Make it possible again to use touch mocking to test gesture chains
like pan->pinch->pan->pinch without lifting the primary "finger".
For this to work we need to track the pressed mouse buttons and
only synthesize touch release events when the ctrl key is released
if no mouse button is pressed. Else the pressed mouse button(s)
should result in a stationary touch point in a touch update event.
Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
to check for the state of the ctrl key modifier instead of getting
it from the mouse events.
- MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::MiniBrowserApplication):
(MiniBrowserApplication::notify):
- 6:02 AM Changeset in webkit [144914] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Fix the Mac build after r144787
https://bugs.webkit.org/show_bug.cgi?id=111569
Reviewed by Csaba Osztrogonác.
Use uint_64 explicitly instead of size_t.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
- 6:02 AM Changeset in webkit [144913] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Do not disable C++0x
https://bugs.webkit.org/show_bug.cgi?id=111559
Reviewed by Kenneth Rohde Christiansen.
- WebCore.pri:
- 5:31 AM Changeset in webkit [144912] by
-
- 6 edits in trunk/Source/WebCore
Remove the (dead) code for handling shorthands in StyleResolver / StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=111505
Reviewed by Alexis Menard.
The CSS parsing code expands shorthands (with the exception of 'font') to their longhands.
This means that all the code in StyleResolver / StyleBuilder to handle shorthands is basically
dead and shouldn't be there. The reason for it to be is that people didn't know about shorthands
expansion and thus copied existing code.
This change addresses both issues by removing the code and adding ASSERTs that should prevent people
from adding more dead code.
Refactoring, covered by existing tests.
- css/StylePropertyShorthand.h: Added isExpandedShorthand.
- css/StylePropertyShorthand.cpp:
(WebCore::isExpandedShorthand):
Added this function that ignores 'font' as it is the only shorthand that is no consistently expanded
to account for system fonts.
- css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
Removed the shorthands.
- css/StyleBuilder.h:
(WebCore::StyleBuilder::setPropertyHandler):
Added ASSERTs that people don't add shorthand handling.
- css/StyleResolver.cpp:
(WebCore::isValidVisitedLinkProperty):
Removed all the shorthands (shouldn't be reachable unless the ASSERT in applyProperty
triggers).
(WebCore::StyleResolver::applyProperty):
Removed all shorthand handling code, moved the shorthands together and added some ASSERT
to ensure people don't abuse the code and re-add some of it back by mistake.
- 5:00 AM Changeset in webkit [144911] by
-
- 48 edits2 moves in trunk/Source
Rename WebCore/editing/visible_units.* to VisibleUnits.*
https://bugs.webkit.org/show_bug.cgi?id=111426
Reviewed by Alexey Proskuryakov.
Source/WebCore:
No new tests. Just a refactoring.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AccessibilityNodeObject.cpp:
- accessibility/AccessibilityObject.cpp:
- accessibility/AccessibilityRenderObject.cpp:
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
- dom/Position.cpp:
- dom/Range.cpp:
- editing/AlternativeTextController.cpp:
- editing/ApplyBlockElementCommand.cpp:
- editing/ApplyStyleCommand.cpp:
- editing/CompositeEditCommand.cpp:
- editing/DeleteSelectionCommand.cpp:
- editing/EditingAllInOne.cpp:
- editing/EditingStyle.cpp:
- editing/Editor.cpp:
- editing/FormatBlockCommand.cpp:
- editing/FrameSelection.cpp:
- editing/IndentOutdentCommand.cpp:
- editing/InsertLineBreakCommand.cpp:
- editing/InsertListCommand.cpp:
- editing/InsertParagraphSeparatorCommand.cpp:
- editing/InsertTextCommand.cpp:
- editing/ReplaceSelectionCommand.cpp:
- editing/SurroundingText.cpp:
- editing/TextCheckingHelper.cpp:
- editing/TextIterator.cpp:
- editing/TypingCommand.cpp:
- editing/VisiblePosition.cpp:
- editing/VisibleSelection.cpp:
- editing/VisibleUnits.cpp: Copied from Source/WebCore/editing/visible_units.cpp.
- editing/VisibleUnits.h: Copied from Source/WebCore/editing/visible_units.h.
- editing/htmlediting.cpp:
- editing/markup.cpp:
- editing/visible_units.cpp: Removed.
- editing/visible_units.h: Removed.
- page/Frame.cpp:
- page/mac/FrameMac.mm:
- platform/win/EditorWin.cpp:
Source/WebKit/mac:
- WebView/WebFrame.mm:
Source/WebKit2:
- WebProcess/WebPage/mac/WebPageMac.mm:
- 4:52 AM Changeset in webkit [144910] by
-
- 14 edits1 add in trunk/Source/JavaScriptCore
Unused Structure property tables waste 14MB on Membuster.
<http://webkit.org/b/110854>
<rdar://problem/13292104>
Reviewed by Geoffrey Garen.
Turn PropertyTable into a GC object and have Structure drop unpinned tables when marking.
14 MB progression on Membuster3.
This time it should stick; I've been through all the tests with COLLECT_ON_EVERY_ALLOCATION.
The issue with the last version was that Structure::m_offset could be used uninitialized
when re-materializing a previously GC'd property table, causing some sanity checks to fail.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
Added PropertyTable.cpp.
- runtime/PropertyTable.cpp: Added.
(JSC::PropertyTable::create):
(JSC::PropertyTable::clone):
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::destroy):
(JSC::PropertyTable::~PropertyTable):
(JSC::PropertyTable::visitChildren):
Moved marking of property table values here from Structure::visitChildren().
- runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::get):
Move m_cell to a local before using it multiple times. This avoids a multiple-access race when
Structure::checkOffsetConsistency() is used in assertions on the main thread while a marking thread
zaps the property table.
- runtime/Structure.h:
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):
- runtime/StructureInlines.h:
(JSC::Structure::propertyTable):
Added a getter for the Structure's PropertyTable that ASSERTs GC currently isn't active.
Because GC can zap an unpinned property table at any time, it's not entirely safe to access it.
Renamed the variable itself to m_propertyTableUnsafe to force call sites into explaining themselves.
(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::checkOffsetConsistency):
Moved these out of Structure.h to break header dependency cycle between Structure/PropertyTable.
- runtime/Structure.cpp:
(JSC::Structure::visitChildren):
Null out m_propertyTable if the table is unpinned. This'll cause the table to get GC'd.
(JSC::Structure::takePropertyTableOrCloneIfPinned):
Added for setting up the property table in a new transition, this code is now shared between
addPropertyTransition() and nonPropertyTransition().
- runtime/JSGlobalData.h:
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
Add a global propertyTableStructure.
- runtime/PropertyMapHashTable.h:
(PropertyTable):
(JSC::PropertyTable::createStructure):
(JSC::PropertyTable::copy):
Make PropertyTable a GC object.
- runtime/Structure.cpp:
(JSC::Structure::dumpStatistics):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::sealTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::isSealed):
(JSC::Structure::isFrozen):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::pin):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::despecifyAllFunctions):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):
(JSC::Structure::createPropertyMap):
(JSC::Structure::getPropertyNamesFromStructure):
(JSC::Structure::checkConsistency):
- 4:41 AM Changeset in webkit [144909] by
-
- 2 edits in trunk/Source/WebKit2
DataReference::vector() should be const.
https://bugs.webkit.org/show_bug.cgi?id=109928
Reviewed by Anders Carlsson.
- Platform/CoreIPC/DataReference.h:
(CoreIPC::DataReference::vector):
- 4:14 AM Changeset in webkit [144908] by
-
- 4 edits in trunk
Do not add CSSPropertyBorderImage shorthand part of the property list when parsing CSS border property
https://bugs.webkit.org/show_bug.cgi?id=111481
Reviewed by Julien Chaffraix.
Source/WebCore:
After http://trac.webkit.org/changeset/135848 and more generally we do not
add shorthand directly into the property list used afterwards to build
StylePropertySet but we rather expand the shorthand to add the
longhands. CSSPropertyBorderImage is a shorthand and it should follow
that rule, so when we successfully parsed CSS border property and we
should reset border-image then we should reset the longhands too.
Test: LayoutTests/inspector/styles/styles-new-API-expected.txt which
reflects the fact that we add longhands instead of the shorthand. All
the other tests should not regress.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
LayoutTests:
As now border-image is expanded when we sucessfully parsed a CSS border,
this test needs to be updated to reflect that the longhands are now
part of the declarated style.
- inspector/styles/styles-new-API-expected.txt:
- 4:14 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:07 AM Changeset in webkit [144907] by
-
- 22 edits3 copies1 add in trunk/Source
Accelerated overflow scrolling for Coordinated Graphics.
https://bugs.webkit.org/show_bug.cgi?id=110323
Source/WebCore:
Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2013-03-06
Reviewed by Noam Rosenthal.
A scroll offset is applied to individual layers on UI process and the
web process is notified assynchronously.
The new API WKCoordinatedScene may be used to scroll layers in the UI process.
Tests will be added on bug #111140.
Scrolling coordinator is used to provide a ScrollableArea to CoordinatedGraphicsLayer.
- page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:
(WebCore::ScrollingCoordinatorCoordinatedGraphics::scrollableAreaScrollLayerDidChange):
(WebCore):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::willDestroyScrollableArea):
- page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:
(ScrollingCoordinatorCoordinatedGraphics):
GraphicsLayerTextureMapper is responsible for receiving the 'did commit' messages and to pass
them to its TextureMapperLayer on the appropriated time.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::didCommitScrollOffset):
(WebCore):
(WebCore::GraphicsLayerTextureMapper::setIsScrollable):
(WebCore::GraphicsLayerTextureMapper::commitLayerChanges):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(WebCore::GraphicsLayerTextureMapper::setScrollClient):
(WebCore::GraphicsLayerTextureMapper::setID):
(GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::isScrollable):
TextureMapperLayer is responsible for applying the requested scroll offset and for
sending the commit messages to web process. It is also able to hittest layers and identify
the ones that are scrollable.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::hitTest):
(WebCore):
(WebCore::TextureMapperLayer::scrollableLayerHitTestCondition):
(WebCore::TextureMapperLayer::findScrollableContentsLayerAt):
(WebCore::TextureMapperLayer::mapScrollOffset):
(WebCore::TextureMapperLayer::commitScrollOffset):
(WebCore::TextureMapperLayer::scrollBy):
(WebCore::TextureMapperLayer::didCommitScrollOffset):
- platform/graphics/texmap/TextureMapperLayer.h:
(TextureMapperLayer):
(ScrollingClient):
(WebCore::TextureMapperLayer::TextureMapperLayer):
(WebCore::TextureMapperLayer::setID):
(WebCore::TextureMapperLayer::id):
(WebCore::TextureMapperLayer::setScrollClient):
(WebCore::TextureMapperLayer::setIsScrollable):
(WebCore::TextureMapperLayer::isScrollable):
(WebCore::TextureMapperLayer::adjustedPosition):
CoordinatedGraphicsLayer receives the commit messages and updates its ScrollableArea.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::setScrollableArea):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::commitScrollOffset):
(WebCore::CoordinatedGraphicsLayer::resetLayerState):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
(WebCore):
(CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::isScrollable):
CoordinatedGraphicsScene receives the commit messages from TextureMapperLayer and
dispatches them on the main thread. It also has a new method that is used to find
the topmost scrollable layer at a given point.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::setLayerState):
(WebCore::CoordinatedGraphicsScene::createLayer):
(WebCore::CoordinatedGraphicsScene::dispatchCommitScrollOffset):
(WebCore):
(WebCore::CoordinatedGraphicsScene::commitScrollOffset):
(WebCore::CoordinatedGraphicsScene::findScrollableContentsLayerAt):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
(WebCore):
(CoordinatedGraphicsSceneClient):
(CoordinatedGraphicsScene):
New fields have been added to CoordinatedGraphicsLayerState.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
(CoordinatedGraphicsLayerState):
Source/WebKit2:
Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2013-03-06
Reviewed by Noam Rosenthal.
Signed off for WebKit2 by Simon Fraser.
A scroll offset is applied to individual layers on UI process and the
web process is notified assynchronously.
The new API WKCoordinatedScene may be used to scroll layers in the UI process.
- CMakeLists.txt:
Encoding and decoding the new members of CoordinatedGraphicsLayerState.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
Adding acceleratedCompositingForOverflowScrollEnabled to WebPreferencesStore.
- Shared/WebPreferencesStore.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
New API WKCoordinatedScene is used to scroll layers on UI side.
- UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp:
- UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.h:
- UIProcess/CoordinatedGraphics/WKCoordinatedSceneAPICast.h:
A new message is used to send scroll commit messages to web process.
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::commitScrollOffset):
(WebKit):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(CoordinatedLayerTreeHostProxy):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::~CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::detachLayer):
(WebKit::CoordinatedLayerTreeHost::createGraphicsLayer):
(WebKit::CoordinatedLayerTreeHost::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHost::purgeBackingStores):
(WebKit::CoordinatedLayerTreeHost::commitScrollOffset):
(WebKit):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(CoordinatedLayerTreeHost):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.messages.in:
- 3:59 AM Changeset in webkit [144906] by
-
- 5 edits2 adds in trunk/LayoutTests
[EFL] Unreviewed gardening
Added new baselines after r144837 and marked as failures
some pasteboard tests that we don't support yet.
- platform/efl/TestExpectations:
- platform/efl/fast/invalid/017-expected.txt:
- platform/efl/fast/invalid/018-expected.txt:
- platform/efl/tables/mozilla/bugs/bug113235-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/efl/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
- 3:22 AM Changeset in webkit [144905] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip authentication test that is now passing on EFL port.
- platform/efl/TestExpectations:
- 2:51 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 2:48 AM Changeset in webkit [144904] by
-
- 4 edits3 adds in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding a failure expectation for a test added in r144877.
- platform/gtk/fast/invalid/017-expected.txt: Rebaselining after r144837.
- platform/gtk/fast/invalid/018-expected.txt: Ditto.
- platform/gtk/tables/mozilla/bugs/bug113235-2-expected.txt: Added. Ditto.
- platform/gtk/tables/mozilla/bugs/bug9024-expected.txt: Added. Ditto.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added. Ditto.
- 2:48 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:47 AM Changeset in webkit [144903] by
-
- 3 edits4 adds in releases/WebKitGTK/webkit-2.0
Merge r144706 - REGRESSION (r143643): Buttons containing floats render differently
https://bugs.webkit.org/show_bug.cgi?id=110933
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-04
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/forms/button-with-float.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
Also include new flexbox as a renderer that needs to enclose
overhanging floats. Flex boxes establish a block formatting context,
so they need to contain floats:
http://dev.w3.org/csswg/css3-flexbox/#flex-items
LayoutTests:
- css3/flexbox/float-inside-flexitem-expected.html: Added.
- css3/flexbox/float-inside-flexitem.html: Added.
- fast/forms/button-with-float-expected.html: Added.
- fast/forms/button-with-float.html: Added.
- 2:38 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:36 AM Changeset in webkit [144902] by
-
- 6 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[GTK] When the WebProcess crashes, a signal should be emitted
https://bugs.webkit.org/show_bug.cgi?id=105180
Patch by Xan Lopez <Xan Lopez> on 2013-03-06
Reviewed by Carlos Garcia Campos.
Emit a "web-process-crashed" signal when the WebProcess crashes. This
is useful, for example, to show an error page in a web browser
like Chrome does.
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
(processDidCrash):
(attachLoaderClientToView):
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextWebProcessCrashed):
- UIProcess/API/gtk/WebKitWebContextPrivate.h:
- UIProcess/API/gtk/tests/TestWebExtensions.cpp:
(testWebExtensionGetTitle):
(webProcessCrashedCallback):
(testWebExtensionAbortProcess):
(beforeAll):
- UIProcess/API/gtk/tests/WebExtensionTest.cpp:
(methodCallCallback):
- 2:16 AM WebKitGTK/2.0.x edited by
- Move patch that already landed to proposed merges (diff)
- 1:59 AM Changeset in webkit [144901] by
-
- 4 edits4 moves1 add in trunk
REGGRESSION (r142112): It made compositing tests fail on EFL, Qt.
https://bugs.webkit.org/show_bug.cgi?id=109291
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Report we support fixed layers.
- page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:
(WebCore::ScrollingCoordinatorCoordinatedGraphics::supportsFixedPositionLayers):
(ScrollingCoordinatorCoordinatedGraphics):
LayoutTests:
Unskip now passing test, and move baselines specific to having no scrolling-coordinator to WK1.
- platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png.
- platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt.
- platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png.
- platform/qt-5.0-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Renamed from LayoutTests/platform/qt/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt.
- platform/qt-5.0-wk2/TestExpectations:
- 1:54 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:53 AM Changeset in webkit [144900] by
-
- 14 edits4 adds in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[GTK] Add WebKitWebViewGroup to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=111265
Reviewed by Martin Robinson.
In the current API the settings are always shared by all web
views, because they are always created on the default page
group. This makes impossible to have different settings on
different web views. Expose the page group in the API,
so that users can create web views on a group different than the
default one to have their own settings.
- GNUmakefile.list.am: Add new files to compilation.
- UIProcess/API/gtk/WebKitSettings.cpp:
(webkitSettingsGetPreferences): Helper private method to get the
WebPreferences wrapped by a WebKitSettings object.
- UIProcess/API/gtk/WebKitSettingsPrivate.h:
- UIProcess/API/gtk/WebKitWebContext.cpp:
(_WebKitWebContextPrivate): Add a default WebKitWebViewGroup.
(webkitWebContextCreatePageForWebView): Create the WebPageProxy
with the WebPageGroup of the given WebKitWebViewGroup.
(webkitWebContextGetDefaultWebViewGroup): Helper private method to
get the default WebKitWebViewGroup.
- UIProcess/API/gtk/WebKitWebContextPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(_WebKitWebViewPrivate): Add a WebKitWebViewGroup in case the view
is created with a group.
(webkitWebViewUpdateSettings): Keep a reference of the group
settings to be able to disconnect the signals when the settings
object is replaced in the view group and connect to the signals
for the custom settings.
(webkitWebViewSettingsChanged): Disconnect the signals for the
previous settings and set the new settings.
(webkitWebViewDisconnectSettingsChangedSignalHandler): Disconnect
notify::settings signal of WebKitWebViewGroup.
(webkitWebViewConstructed): Pass the current WebKitWebViewGroup to
webkitWebContextCreatePageForWebView().
(webkitWebViewSetProperty): Add setter for group property.
(webkitWebViewGetProperty): Add getter for group property.
(webkitWebViewDispose): Call
webkitWebViewDisconnectSettingsChangedSignalHandler().
(webkit_web_view_class_init): Add WebKitWebView:group property.
(webkitWebViewHandleAuthenticationChallenge): Use
webkit_web_view_get_settings().
(webkit_web_view_new_with_group): Create a new web view with the
given WebKitWebViewGroup.
(webkit_web_view_get_group): Return the current WebKitWebViewGroup
or the default one if the view was not created with
webkit_web_view_new_with_group().
(webkit_web_view_set_settings): Set the settings of the current
WebKitWebViewGroup.
(webkit_web_view_get_settings): Get the settings of the current
WebKitWebViewGroup.
(webkit_web_view_set_zoom_level): Use
webkit_web_view_get_settings().
(webkit_web_view_get_zoom_level): Ditto.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/WebKitWebViewGroup.cpp: Added.
(_WebKitWebViewGroupPrivate):
(webkitWebViewGroupSetProperty):
(webkitWebViewGroupGetProperty):
(webkitWebViewGroupConstructed):
(webkit_web_view_group_class_init):
(webkitWebViewGroupAttachSettingsToPageGroup): Set the
WebPreferences of the current WebKitSettings to the WebPageGroup.
(webkitWebViewGroupCreate): Create a new WebKitWebViewGroup for
the given WebPageGroup.
(webkitWebViewGroupGetPageGroup): Helper private method to get the
WebPageGroup wrapped by the WebKitWebViewGroup.
(webkit_web_view_group_new): Create a new WebKitWebViewGroup.
(webkit_web_view_group_get_name): Return the name of a
WebKitWebViewGroup.
(webkit_web_view_group_get_settings): Get the settins of a
WebKitWebViewGroup.
(webkit_web_view_group_set_settings): Set new settings of a
WebKitWebViewGroup.
- UIProcess/API/gtk/WebKitWebViewGroup.h: Added.
(_WebKitWebViewGroup):
(_WebKitWebViewGroupClass):
- UIProcess/API/gtk/WebKitWebViewGroupPrivate.h: Added.
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add
WebKitWebViewGroup section.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
- UIProcess/API/gtk/docs/webkit2gtk.types: Add
webkit_web_view_group_get_type.
- UIProcess/API/gtk/tests/GNUmakefile.am: Add new files to
compilation.
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewSettings): We can't watch settings in the default view
group anymore, because they are not released with the web view but
with the web context that is freed after the Test destructor.
- UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp: Added.
(testWebViewGroupDefault):
(testWebViewGroupNewGroup):
(testWebViewNewWithGroup):
(testWebViewGroupSettings):
(beforeAll):
(afterAll):
- UIProcess/API/gtk/webkit2.h: Include WebKitWebViewGroup.h.
- 1:35 AM Changeset in webkit [144899] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Convert from device view size to UI view size only in EwkView.
https://bugs.webkit.org/show_bug.cgi?id=110197
Patch by Huang Dongsung <luxtella@company100.net> on 2013-03-06
Reviewed by Kenneth Rohde Christiansen.
Signed off for WebKit2 by Benjamin Poulain.
Device scale factor is a property of the physical display, so only EwkView
should deal with converting device view size to UI (a.k.a Density Independent Pixel)
view size. It increases readability because we can regard a view size in
other classes (e.g. WebView, PageViewportController, WebPage) except for
EwkView as UI size.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::setDeviceScaleFactor):
(EwkView::setDeviceSize):
(EwkView::size):
(EwkView::deviceSize):
(EwkView::scheduleUpdateDisplay):
(EwkView::createGLSurface):
(EwkView::handleEvasObjectCalculate):
- UIProcess/API/efl/EwkView.h:
(EwkView):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::paintToCurrentGLContext):
(WebKit::WebView::updateViewportSize):
- 1:27 AM Changeset in webkit [144898] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Use Vector::reserveInitialCapacity() in WebEventFactory::createWebTouchEvent()
https://bugs.webkit.org/show_bug.cgi?id=111530
Reviewed by Benjamin Poulain.
In WebEventFactory::createWebTouchEvent(), when constructing the vector of touch points,
we already know in advance the total number of touch points. Therefore, we should
leverage WTF::Vector::reserveInitialCapacity() and WTF::Vector::uncheckedAppend() to save
some capacity checks.
- Shared/efl/WebEventFactory.cpp:
(WebKit::WebEventFactory::createWebTouchEvent):
- 1:23 AM Changeset in webkit [144897] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: Delete http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html
- 1:16 AM Changeset in webkit [144896] by
-
- 6 edits3 deletes in trunk
Unreviewed, rolling out r144859.
http://trac.webkit.org/changeset/144859
https://bugs.webkit.org/show_bug.cgi?id=111519
Introduced a test that calls non-exist function on non-
Chromium ports and crash on Chromium (Requested by rniwa on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-06
Source/WebCore:
- html/HTMLAudioElement.h:
(WebCore::HTMLAudioElement::hasPendingActivity):
(HTMLAudioElement):
- html/HTMLAudioElement.idl:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::hasPendingActivity):
- html/HTMLMediaElement.idl:
LayoutTests:
- http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal-expected.txt: Removed.
- http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html: Removed.
- http/tests/misc/resources/delete-frame-during-readystatechange-frame-with-gc-after-video-removal.html: Removed.
- 12:59 AM Changeset in webkit [144895] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Could not open Profiles panel.
https://bugs.webkit.org/show_bug.cgi?id=111535
Reviewed by Alexander Pavlov.
- inspector/front-end/CPUProfileView.js:
- inspector/front-end/ProfilesPanel.js:
- 12:29 AM Changeset in webkit [144894] by
-
- 3 edits3 adds in trunk
Crash during middle mouse click when page is removed
https://bugs.webkit.org/show_bug.cgi?id=111489
Reviewed by Hajime Morrita.
Source/WebCore:
Check for a null page that can happen if we remove the document from the DOM.
The other methods in EventHandler also check for a null page.
Test: editing/pasteboard/selection-paste-crash.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handlePasteGlobalSelection):
LayoutTests:
- editing/pasteboard/resources/selection-paste-crash.html: Added.
- editing/pasteboard/selection-paste-crash-expected.txt: Added.
- editing/pasteboard/selection-paste-crash.html: Added.
- 12:12 AM WebKitGTK/2.0.x edited by
- (diff)
- 12:11 AM Changeset in webkit [144893] by
-
- 10 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[GTK] Add WebKitWebPage::send-request signal to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=83681
Reviewed by Martin Robinson.
Add WebKitWebPage::send-request signal emitted in willSendRequest
callback to allow web process extensions to modify requests before
they are sent or cancel the resource load.
- UIProcess/API/gtk/WebKitURIRequest.cpp:
(webkitURIRequestSetProperty): Use webkit_uri_request_set_uri() to
set the new URI.
(webkit_uri_request_class_init): Make URI property construct
instead of construct-only, since it can be updated once
constructed. It should never be NULL, so set default value to
about:blank instad of NULL.
(webkit_uri_request_set_uri): New public method to set the URI of
the WebKitURIRequest.
- UIProcess/API/gtk/WebKitURIRequest.h: Allow to include this file
from webkit-web-extension.h.
- UIProcess/API/gtk/WebKitURIResponse.h: Ditto.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add
webkit_uri_request_set_uri.
- UIProcess/API/gtk/tests/TestResources.cpp:
(testWebResourceSendRequest):
(serverCallback):
(beforeAll):
- UIProcess/API/gtk/tests/WebExtensionTest.cpp:
(sendRequestCallback):
(pageCreatedCallback):
- UIProcess/API/gtk/webkit2marshal.list:
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(willSendRequestForFrame): Emit WebKitWebPage::send-request and
return early if the load is cancelled.
(webkit_web_page_class_init): Add WebKitWebPage::send-request signal.
- WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h:
- 12:04 AM Changeset in webkit [144892] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][EFL] Enable asynchronous spell checking by default
https://bugs.webkit.org/show_bug.cgi?id=111295
Reviewed by Benjamin Poulain.
Asynchronous spell checking feature is disabled by default for wk2 platforms.
It means all requests of spell checking are sent synchronously.
WebKit-EFL implements requestCheckingOfString method which allows
to check spelling asynchronously.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
Mar 5, 2013:
- 11:59 PM Changeset in webkit [144891] by
-
- 21 edits in trunk/Source/WebCore
Replace shouldLazyAttach bool with an enum for readability
https://bugs.webkit.org/show_bug.cgi?id=111503
Reviewed by Dimitri Glazkov.
No behavioral change.
- bindings/cpp/WebDOMNodeCustom.cpp:
(WebDOMNode::insertBefore):
(WebDOMNode::replaceChild):
(WebDOMNode::appendChild):
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::insertBefore):
(WebCore::JSNode::replaceChild):
(WebCore::JSNode::appendChild):
- bindings/v8/custom/V8NodeCustom.cpp:
(WebCore):
(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):
- dom/ContainerNode.cpp:
(WebCore):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):
(WebCore::updateTreeAfterInsertion):
- dom/ContainerNode.h:
(ContainerNode):
- dom/Node.cpp:
(WebCore::Node::insertBefore):
(WebCore::Node::replaceChild):
(WebCore::Node::appendChild):
- dom/Node.h:
(Node):
- editing/AppendNodeCommand.cpp:
(WebCore::AppendNodeCommand::doApply):
- editing/InsertNodeBeforeCommand.cpp:
(WebCore::InsertNodeBeforeCommand::doApply):
- html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::createControls):
- html/shadow/MediaControlsBlackBerry.cpp:
(WebCore::MediaControlsBlackBerry::createControls):
- html/shadow/MediaControlsChromium.cpp:
(WebCore::MediaControlsChromium::initializeControls):
- html/shadow/MediaControlsChromiumAndroid.cpp:
(WebCore::MediaControlsChromiumAndroid::createControls):
- 11:57 PM WebKitGTK/2.0.x edited by
- (diff)
- 11:54 PM Changeset in webkit [144890] by
-
- 6 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[GTK][WK2] Add WebKitWebPage::webkit_web_page_get_uri to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=111288
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-05
Reviewed by Carlos Garcia Campos.
Add new property URI to WebKitWebPage providing a method
webkit_web_page_get_uri to get it and the signal "notify::uri" to
monitor changes in the URI.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Include new method in
GTK+ doc.
- UIProcess/API/gtk/tests/TestLoaderClient.cpp:
(testWebPageURI):
(beforeAll):
(afterAll): Add test to check that WebKitWebPage URI matches with
WebKitWebView value. The tests is listening for changes in WebKitWebPage
URI via D-Bus and checks that value is the same than WebKitWebView URI.
It also checks that the order of the URIs in a redirection is right.
- UIProcess/API/gtk/tests/WebExtensionTest.cpp:
(uriChangedCallback):
(pageCreatedCallback): Add new D-Bus signal "URIChanged" connected to
"notify::uri" signal of WebKitWebPage.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(_WebKitWebPagePrivate): Add new URI attribute.
(webkitWebPageSetURI): Method to set the URI and emit the "notify:uri"
signal if it has changed.
(didStartProvisionalLoadForFrame): At this point it use the unreachable
URL from provisional document loader if any. Otherwise, it uses the URL
from provisional document loader.
(didReceiveServerRedirectForProvisionalLoadForFrame): In the case of
redirections it works like for didStartProvisionalLoadForFrame getting
the unreachable URL if any.
(didSameDocumentNavigationForFrame): In this case it gets the URL from
the document loader.
(webkitWebPageGetProperty): Add code related to URI property.
(webkit_web_page_class_init): Add bits related to URI property.
(webkitWebPageCreate): Implement callbacks to monitor URI changes.
(webkit_web_page_get_uri): Return URI attribute.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h: Add new method
header.
- 11:53 PM Changeset in webkit [144889] by
-
- 5 edits in trunk/Source/WebCore
Custom Elements: CustomElementConstructor::m_name doesn't have any good use.
https://bugs.webkit.org/show_bug.cgi?id=111523
Reviewed by Kentaro Hara.
This change removes CustomElementConstructor::m_name and renames
m_tagName to m_name. Now generated function name is same as interface name.
Originally, m_name was added to specify the generated constructor
name. An early version of custom element allows to give the name,
but it no longer says anything about that.
The rename is to align the semantics of type extension mechanism
of Custom Elements, where the name of a custom element isn't
necessarily a tag name.
No new tests. Just removing old code.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- dom/CustomElementConstructor.cpp:
(WebCore::CustomElementConstructor::create):
(WebCore::CustomElementConstructor::CustomElementConstructor):
(WebCore::CustomElementConstructor::createElement):
- dom/CustomElementConstructor.h:
(CustomElementConstructor):
(WebCore::CustomElementConstructor::name):
- dom/CustomElementRegistry.cpp:
(WebCore::CustomElementRegistry::registerElement):
- 11:43 PM Changeset in webkit [144888] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Flame Chart. Provide node context info in a popover when mouse hovers over a flame chart item.
https://bugs.webkit.org/show_bug.cgi?id=111442
Reviewed by Yury Semikhatsky.
FlameChart is a canvas so it is not possible to attach the popover to the items on it.
It would be a bit tricky to support an offset due to complex behaviour of the popover.
The simplest solution is to create a fake anchor element and move it to the right position.
- inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._getPopoverAnchor):
(WebInspector.FlameChart.prototype._showPopover):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype.findNodeCallback):
(WebInspector.FlameChart.prototype._coordinatesToNode):
(WebInspector.FlameChart.prototype.onResize):
- inspector/front-end/flameChart.css:
(.flame-chart .item-anchor):
- 11:37 PM Changeset in webkit [144887] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Ensure right format is used in SnapshotImageGL.
https://bugs.webkit.org/show_bug.cgi?id=111333
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-05
Reviewed by Benjamin Poulain.
GL_BGRA format is not standard for glReadPixels with GLES.
This patch ensures that GL_RGBA is used in SnapshotImageGL
while using GLES.
- UIProcess/API/efl/SnapshotImageGL.cpp:
(getImageSurfaceFromFrameBuffer):
- 11:32 PM Changeset in webkit [144886] by
-
- 3 edits in trunk/Source/JavaScriptCore
Get rid of the invert argument to SpeculativeJIT::jumpSlowForUnwantedArrayMode
https://bugs.webkit.org/show_bug.cgi?id=105624
Reviewed by Oliver Hunt.
All callers pass invert = false, which is the default value of the argument. So, get
rid of the argument and fold away all code that checks it.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- 10:59 PM Changeset in webkit [144885] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed buildfix after r144787. Add missing USE(GRAPHICS_SURFACE) guards.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::setLayerState):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):
- 10:54 PM Changeset in webkit [144884] by
-
- 2 edits in trunk/Source/WebCore
Autoreleased cached pages slow down the PLT by 2%
https://bugs.webkit.org/show_bug.cgi?id=111522
Reviewed by Filip Pizlo.
Let's stop doing that.
2% PLT speedup.
- history/PageCache.cpp:
(WebCore::PageCache::remove):
- 10:43 PM Changeset in webkit [144883] by
-
- 1 edit3 moves in trunk/LayoutTests
Make toggle-unlink.html test Mac specific behaviour
https://bugs.webkit.org/show_bug.cgi?id=111321
Reviewed by Ryosuke Niwa.
A new test for Windows behavior will have to be added once bug
110487 is landed.
- editing/execCommand/script-tests/toggle-unlink-mac.js: Renamed
from
LayoutTests/editing/execCommand/script-tests/toggle-unlink.js.
Also set editing behaviour to Mac.
- editing/execCommand/toggle-unlink-mac-expected.txt: Renamed from
LayoutTests/editing/execCommand/toggle-unlink-expected.txt.
- editing/execCommand/toggle-unlink-mac.html: Renamed from
LayoutTests/editing/execCommand/toggle-unlink.html.
- 10:27 PM Changeset in webkit [144882] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
Patch by Vsevolod Vlasov <vsevik@chromium.org> on 2013-03-05
- platform/chromium/TestExpectations:
- 10:09 PM Changeset in webkit [144881] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations update.
- platform/chromium/TestExpectations:
- 9:48 PM Changeset in webkit [144880] by
-
- 2 edits in trunk/LayoutTests
Add a flaky crash test expectation to editing/selection/selection-invalid-offset.html
on Mac per bug 111521.
- platform/mac/TestExpectations:
- 9:32 PM Changeset in webkit [144879] by
-
- 2 edits6 adds in trunk/LayoutTests
Add test coverage for DCE and type checks.
Rubber stamped by Geoffrey Garen.
- fast/js/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null-and-decrement-expected.txt: Added.
- fast/js/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null-and-decrement.html: Added.
- fast/js/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null-expected.txt: Added.
- fast/js/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null-and-decrement.js: Added.
(foo):
- fast/js/script-tests/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null.js: Added.
(foo):
- 9:23 PM Changeset in webkit [144878] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html
- 9:16 PM Changeset in webkit [144877] by
-
- 19 edits2 adds in trunk
[Shadow] Implements event re-targeting for Touch Events.
https://bugs.webkit.org/show_bug.cgi?id=107800
Reviewed by Dimitri Glazkov.
Source/WebCore:
So far, Touch Events have been intentionally disabled in shadow
tree since it allows users to access internal nodes in shadow tree
by accessing Touch Event's information.
This patch re-targets all individual touch point's target in
TouchList (touches, targetTouches and changedTouches) owned by a Touch Event
before the Touch Event is dispatched so that we won't break an
upper boundary of shadow DOM.
Touch Events re-targeting is similar to that of Mouse Events
re-targeting. The difference is that a Touch Event can have more
than one related target because of multiple touches. We must
re-target all individual touch points which can be referred from
the Touch Event.
Now, Touch Events can be fired in shadow tree. I've removed the
existing limitation.
Test: fast/dom/shadow/touch-event-retargeting.html
- dom/EventContext.cpp:
(WebCore::EventContext::isTouchEventContext):
(WebCore):
(WebCore::TouchEventContext::TouchEventContext):
(WebCore::TouchEventContext::~TouchEventContext):
(WebCore::TouchEventContext::handleLocalEvents):
(WebCore::TouchEventContext::isTouchEventContext):
(WebCore::TouchEventContext::checkReachability): Used for assertion of reachability for each Touch point.
- dom/EventContext.h:
(WebCore):
(EventContext):
(TouchEventContext): Introduced to hold necessary information for re-targeting Touch event.
(WebCore::TouchEventContext::touches):
(WebCore::TouchEventContext::targetTouches):
(WebCore::TouchEventContext::changedTouches):
(WebCore::EventContext::isReachable):
- dom/EventRetargeter.cpp:
(WebCore::EventRetargeter::calculateEventPath):
(WebCore::EventRetargeter::adjustForTouchEvent):
(WebCore):
(WebCore::EventRetargeter::adjustTouchList):
(WebCore::EventRetargeter::adjustForRelatedTarget):
(WebCore::EventRetargeter::calculateAdjustedNodes): Updated so that this can be used for Touch point re-targeting.
(WebCore::EventRetargeter::buildRelatedNodeMap):
- dom/EventRetargeter.h:
(WebCore):
(EventRetargeter):
- dom/Node.cpp:
(WebCore::Node::dispatchEvent):
(WebCore):
(WebCore::Node::dispatchTouchEvent):
- dom/Node.h:
(WebCore):
(Node):
- dom/Touch.cpp:
(WebCore::Touch::Touch):
(WebCore):
(WebCore::Touch::cloneWithNewTarget):
- dom/Touch.h:
(Touch):
- dom/TouchEvent.cpp:
(WebCore::TouchEventDispatchMediator::create):
(WebCore):
(WebCore::TouchEventDispatchMediator::TouchEventDispatchMediator):
(WebCore::TouchEventDispatchMediator::event):
(WebCore::TouchEventDispatchMediator::dispatchEvent):
- dom/TouchEvent.h:
(TouchEvent):
(WebCore::TouchEvent::setTouches):
(WebCore::TouchEvent::setTargetTouches):
(WebCore::TouchEvent::setChangedTouches):
(TouchEventDispatchMediator):
(WebCore):
(WebCore::toTouchEvent):
- dom/TouchList.cpp:
(WebCore::TouchList::item):
(WebCore):
- dom/TouchList.h:
(TouchList):
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultInFrame): Removed the limitation. Adjusting is no longer done here.
(WebCore::EventHandler::handleTouchEvent):
LayoutTests:
- fast/dom/shadow/resources/event-dispatching.js:
(recordEvent):
(dumpTouchList):
(sortDispatchedEvent):
(showSandboxTree):
- fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt:
- fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node.html:
- fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt:
- fast/dom/shadow/touch-event-retargeting-expected.txt: Added.
- fast/dom/shadow/touch-event-retargeting.html: Added.
- 8:49 PM Changeset in webkit [144876] by
-
- 2 edits3 adds in trunk/LayoutTests
Add test coverage for DCE and type checks.
Rubber stampted by Geoffrey Garen.
- fast/js/dfg-cfg-simplify-eliminate-set-local-type-check-then-typeof-expected.txt: Added.
- fast/js/dfg-cfg-simplify-eliminate-set-local-type-check-then-typeof.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-cfg-simplify-eliminate-set-local-type-check-then-typeof.js: Added.
(foo):
- 8:27 PM Changeset in webkit [144875] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. AppleWin port.
- platform/win/TestExpectations:
- 8:22 PM Changeset in webkit [144874] by
-
- 2 edits3 adds in trunk/LayoutTests
DFG may infer an edge to be a double-using edge and then later experience multiple-personality disorder with respect to that particular decision
https://bugs.webkit.org/show_bug.cgi?id=109393
Rubber stamped by Geoffrey Garen.
- fast/js/dfg-double-addition-simplify-to-int-expected.txt: Added.
- fast/js/dfg-double-addition-simplify-to-int.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-double-addition-simplify-to-int.js: Added.
(foo):
- 8:17 PM Changeset in webkit [144873] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed gardening. AppleWin port.
- platform/win/cssom: Added.
- platform/win/cssom/cssvalue-comparison-expected.txt: Added.
- 8:04 PM Changeset in webkit [144872] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. AppleWin port.
Patch by Roger Fong <roger_fong@apple.com> on 2013-03-05
- platform/win/TestExpectations:
- platform/win/fast/forms/number: Added.
- platform/win/fast/forms/number/number-l10n-input-expected.txt: Added.
- 7:59 PM Changeset in webkit [144871] by
-
- 2 edits2 adds in trunk/LayoutTests
Unreviewed gardening. AppleWin port.
- platform/win/TestExpectations:
- platform/win/fast/forms/number: Added.
- platform/win/fast/forms/number/number-l10n-input-expected.txt: Added.
- 7:54 PM Changeset in webkit [144870] by
-
- 2 edits in trunk/Tools
[chromium] don't use custom freetype on linux asan for now
https://bugs.webkit.org/show_bug.cgi?id=111516
Unreviewed, build fix.
Turns out the custom lib is getting picked up by other binaries
on our bot, which is bad.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 7:52 PM Changeset in webkit [144869] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: plugins/plugin-clip-subframe.html
- 7:28 PM Changeset in webkit [144868] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: fast/regions/region-style-in-columns.html
- 7:27 PM Changeset in webkit [144867] by
-
- 2 edits in trunk/Tools
[chromium] making DumpRenderTree_resources a separate bundle breaks xcode
https://bugs.webkit.org/show_bug.cgi?id=111509
Unreviewed, build fix.
Actually comment out the flag :(.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 7:07 PM Changeset in webkit [144866] by
-
- 2 edits in trunk/Tools
[chromium] making DumpRenderTree_resources a separate bundle breaks xcode
https://bugs.webkit.org/show_bug.cgi?id=111509
Unreviewed, build fix.
r144863 appears to have broken the xcode build; I'm temporarily
trying this instead, and if this doesn't work, I'll revert the
other changes.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 6:52 PM Changeset in webkit [144865] by
-
- 6 edits in trunk/Source/WebCore
[Custom Elements][V8] Custom Element doesn't need its own WrapperTypeInfo
https://bugs.webkit.org/show_bug.cgi?id=111411
Reviewed by Kentaro Hara.
No new tests. No observable change yet.
This is a preparation for Bug 110436, where WebKit is going to
allow any HTML element to be a superclass of custom elements.
This change eliminates WrapperTypeInfo for custom element. Instead
of that, the wrapper of a custom element picks WrapperTypeInfo
from most descendant built-in HTML element. For example, think about
following hierarchy:
- ... <- HTMLElement <- HTMLDivElememnt <- ExistingCustomElement <- NewCustomElement
In this case, both ExistingCustomElement and NewCustomElement has
HTMLDivElememnt's type info. This is because HTMLDivElememnt is
the most descendant (or "the nearest") built-in HTML
element. (HTMLElement isn't the most descendant.
ExistingCustomElement isn't a built-in.)
Using such WrapperTypeInfos, created custom element wrappers can
get appropriate set of method and properties regardless of its
super-elements.
This change tells the prototype object of each built-in object
which WrapperTypeInfo the native backing wants:
HTMLDivElememnt.prototype knows V8HTMLDivElement::info for
example. The pointer to the type info is stored into an internal
field. On wrapper construction, createWrapper() walks up the
prototype chain and pick the first one.
- bindings/v8/V8DOMConfiguration.cpp:
(WebCore::V8DOMConfiguration::configureTemplate):
- bindings/v8/V8HTMLCustomElement.cpp:
(WebCore::findWrapperTypeOf):
(WebCore::V8HTMLCustomElement::createWrapper):
- bindings/v8/V8HTMLCustomElement.h:
- bindings/v8/V8PerContextData.cpp:
(WebCore::V8PerContextData::constructorForTypeSlowCase):
- bindings/v8/WrapperTypeInfo.h:
(WebCore):
- 6:51 PM Changeset in webkit [144864] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix an incorrect comment. The comment was a holdover from a work-in-progress version of this code.
- dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::run):
- 6:37 PM Changeset in webkit [144863] by
-
- 2 edits in trunk/Tools
[chromium] build a DumpRenderTree.pak even on windows
https://bugs.webkit.org/show_bug.cgi?id=111504
Reviewed by Tony Chang.
The Chromium Aura build uses the default theme to draw
controls, and that theme requires the ui ResourceBundle
to be initialized. On every other platform, we build
a DumpRenderTree.pak that works for this, but on Windows we
still compile the resources directly into DRT. As a first step,
let's build the pak file. I will then need to land a patch
in Chromium to actually load it. Then I can go back and move
the resources over to just use the .pak file and no longer need
the .rc's.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 6:27 PM Changeset in webkit [144862] by
-
- 33 edits8 adds in trunk
DFG DCE might eliminate checks unsoundly
https://bugs.webkit.org/show_bug.cgi?id=109389
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
This gets rid of all eager reference counting, and does all dead code elimination
in one phase - the DCEPhase. This phase also sets up the node reference counts,
which are then used not just for DCE but also register allocation and stack slot
allocation.
Doing this required a number of surgical changes in places that previously relied
on always having liveness information. For example, the structure check hoisting
phase must now consult whether a VariableAccessData is profitable for unboxing to
make sure that it doesn't try to do hoisting on set SetLocals. The arguments
simplification phase employs its own light-weight liveness analysis. Both phases
previously just used reference counts.
The largest change is that now, dead nodes get turned into Phantoms. Those
Phantoms will retain those child edges that are not proven. This ensures that any
type checks performed by a dead node remain even after the node is killed. On the
other hand, this Phantom conversion means that we need special handling for
SetLocal. I decided to make the four forms of SetLocal explicit:
MovHint(@a, rK): Just indicates that node @a contains the value that would have
now been placed into virtual register rK. Does not actually cause @a to be
stored into rK. This would have previously been a dead SetLocal with @a
being live. MovHints are always dead.
ZombieHint(rK): Indicates that at this point, register rK will contain a dead
value and OSR should put Undefined into it. This would have previously been
a dead SetLocal with @a being dead also. ZombieHints are always dead.
MovHintAndCheck(@a, rK): Identical to MovHint except @a is also type checked,
according to whatever UseKind the edge to @a has. The type check is always a
forward exit. MovHintAndChecks are always live, since they are
NodeMustGenerate. Previously this would have been a dead SetLocal with a
live @a, and the check would have disappeared. This is one of the bugs that
this patch solves.
SetLocal(@a, rK): This still does exactly what it does now, if the SetLocal is
live.
Basically this patch makes it so that dead SetLocals eventually decay to MovHint,
ZombieHint, or MovHintAndCheck depending on the situation. If the child @a is
also dead, then you get a ZombieHint. If the child @a is live but the SetLocal
has a type check and @a's type hasn't been proven to have that type then you get
a MovHintAndCheck. Otherwise you get a MovHint.
This is performance neutral.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
(JSC::DFG::AbstractState::mergeStateAtTail):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
(ArgumentsSimplificationPhase):
(JSC::DFG::ArgumentsSimplificationPhase::removeArgumentsReferencingPhantomChild):
- dfg/DFGBasicBlock.h:
(BasicBlock):
- dfg/DFGBasicBlockInlines.h:
(DFG):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::insertPhiNode):
(JSC::DFG::ByteCodeParser::emitFunctionChecks):
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::run):
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
- dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::run):
(JSC::DFG::CPSRethreadingPhase::addPhiSilently):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGCommon.cpp:
(WTF::printInternal):
(WTF):
- dfg/DFGCommon.h:
(WTF):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):
(JSC::DFG::ConstantFoldingPhase::paintUnreachableCode):
- dfg/DFGDCEPhase.cpp: Added.
(DFG):
(DCEPhase):
(JSC::DFG::DCEPhase::DCEPhase):
(JSC::DFG::DCEPhase::run):
(JSC::DFG::DCEPhase::findTypeCheckRoot):
(JSC::DFG::DCEPhase::countEdge):
(JSC::DFG::DCEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::performDCE):
- dfg/DFGDCEPhase.h: Added.
(DFG):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
(JSC::DFG::FixupPhase::blessArrayOperation):
(JSC::DFG::FixupPhase::fixIntEdge):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):
(JSC::DFG::FixupPhase::truncateConstantToInt32):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::dump):
(DFG):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::changeChild):
(JSC::DFG::Graph::changeEdge):
(JSC::DFG::Graph::compareAndSwap):
(JSC::DFG::Graph::clearAndDerefChild):
(JSC::DFG::Graph::performSubstitution):
(JSC::DFG::Graph::performSubstitutionForEdge):
(Graph):
(JSC::DFG::Graph::substitute):
- dfg/DFGInsertionSet.h:
(InsertionSet):
- dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::convertToConstant):
(JSC::DFG::Node::convertToGetLocalUnlinked):
(JSC::DFG::Node::containsMovHint):
(Node):
(JSC::DFG::Node::hasVariableAccessData):
(JSC::DFG::Node::willHaveCodeGenOrOSR):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compileMovHintAndCheck):
(DFG):
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
(JSC::DFG::StructureCheckHoistingPhase::shouldConsiderForHoisting):
(StructureCheckHoistingPhase):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
LayoutTests:
Reviewed by Oliver Hunt.
- fast/js/dfg-arguments-osr-exit-multiple-blocks-before-exit-expected.txt: Added.
- fast/js/dfg-arguments-osr-exit-multiple-blocks-before-exit.html: Added.
- fast/js/dfg-arguments-osr-exit-multiple-blocks-expected.txt: Added.
- fast/js/dfg-arguments-osr-exit-multiple-blocks.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-arguments-osr-exit-multiple-blocks-before-exit.js: Added.
(baz):
(foo):
(bar):
- fast/js/script-tests/dfg-arguments-osr-exit-multiple-blocks.js: Added.
(baz):
(foo):
(bar):
- 6:15 PM Changeset in webkit [144861] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: inspector/console/command-line-api-inspect.html
- 6:13 PM Changeset in webkit [144860] by
-
- 2 edits in trunk/Source/WebKit2
Each web process truncates the disk cache to zero on launch
https://bugs.webkit.org/show_bug.cgi?id=111467
Reviewed by Darin Adler.
Let's not do that.
- WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- 6:11 PM Changeset in webkit [144859] by
-
- 6 edits3 adds in trunk
Heap-use-after-free in WebCore::HTMLMediaElement::~HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=110623
Reviewed by Eric Seidel.
Source/WebCore:
Test: http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html
- html/HTMLAudioElement.h:
(HTMLAudioElement):
- html/HTMLAudioElement.idl:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::hasPendingActivity):
- html/HTMLMediaElement.idl:
LayoutTests:
- http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal-expected.txt: Added.
- http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html: Added.
- http/tests/misc/resources/delete-frame-during-readystatechange-frame-with-gc-after-video-removal.html: Added.
- 5:47 PM Changeset in webkit [144858] by
-
- 6 edits2 adds in trunk
AX: Support aria-posinset/setsize
https://bugs.webkit.org/show_bug.cgi?id=109725
Reviewed by Tim Horton.
Source/WebCore:
Expose aria-setsize and aria-posinset through accessibility.
Right now only the Mac platform exposes them.
Test: platform/mac/accessibility/aria-setsize-posinset.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsARIASetSize):
(WebCore):
(WebCore::AccessibilityObject::supportsARIAPosInset):
(WebCore::AccessibilityObject::ariaSetSize):
(WebCore::AccessibilityObject::ariaPosInset):
- accessibility/AccessibilityObject.h:
(AccessibilityObject):
- accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- html/HTMLAttributeNames.in:
LayoutTests:
- platform/mac/accessibility/aria-setsize-posinset-expected.txt: Added.
- platform/mac/accessibility/aria-setsize-posinset.html: Added.
- 5:41 PM Changeset in webkit [144857] by
-
- 2 edits in trunk/WebKitLibraries
Remove deprecated process suppression assertion SPI from WebKitSystemInterface
https://bugs.webkit.org/show_bug.cgi?id=111501
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-03-05
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=111387 replaced all usage of
WKNSProcessInfoProcessAssertionWithTypes() with
-[NSProcessInfo beginSuspensionOfSystemBehaviors:]. Hence, remove
the now deprecated SPI.
- WebKitSystemInterface.h: Remove
WKNSProcessInfoProcessAssertionWithTypes and associated declarations.
- 5:41 PM ScalesAndZooms edited by
- (diff)
- 5:29 PM Changeset in webkit [144856] by
-
- 10 edits1 add in trunk/Source
[chromium] Scroll deltas should be floats
https://bugs.webkit.org/show_bug.cgi?id=111465
Reviewed by James Robinson.
This converts the remaining scroll delta fields to floats so that
we no longer lose precision due to DIP conversion. The natural
type for deltas is WebFloatSize, which was missing, so I also created
that type based on the existing WebSize header.
Source/Platform:
- Platform.gypi:
- chromium/public/WebFloatSize.h: Added.
(WebKit):
(WebFloatSize):
(WebKit::WebFloatSize::isEmpty):
(WebKit::WebFloatSize::WebFloatSize):
(WebKit::WebFloatSize::operator=):
(WebKit::WebFloatSize::operator WebCore::FloatSize):
(WebKit::WebFloatSize::operator gfx::SizeF):
(WebKit::WebFloatSize::operator gfx::Vector2dF):
(WebKit::operator==):
(WebKit::operator!=):
- chromium/public/WebGestureCurveTarget.h:
(WebKit::WebGestureCurveTarget::scrollBy):
(WebGestureCurveTarget):
- chromium/public/WebInputHandlerClient.h:
(WebKit::WebInputHandlerClient::scrollByIfPossible):
(WebInputHandlerClient):
Source/WebKit/chromium:
- src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
(WebKit::WebCompositorInputHandlerImpl::touchpadFlingScroll):
(WebKit::WebCompositorInputHandlerImpl::scrollBy):
- src/WebCompositorInputHandlerImpl.h:
(WebCompositorInputHandlerImpl):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::scrollBy):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/WebCompositorInputHandlerImplTest.cpp:
(MockWebInputHandlerClient):
(WebKit::TEST_F):
- 5:19 PM Changeset in webkit [144855] by
-
- 2 edits9 adds5 deletes in trunk/LayoutTests
Unreviewed apple rebaselines for r144837.
- fast/invalid/017-expected.txt: Added.
- fast/invalid/018-expected.txt: Added.
- platform/chromium-mac/fast/invalid/017-expected.txt: Removed.
- platform/chromium-mac/fast/invalid/018-expected.txt: Removed.
- platform/mac-lion/tables/mozilla/bugs: Added.
- platform/mac-lion/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
- platform/mac-lion/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/mac-lion/tables/mozilla_expected_failures: Removed.
- platform/mac-wk2/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
- platform/mac-wk2/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/mac/fast/invalid/017-expected.txt: Removed.
- platform/mac/fast/invalid/018-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/mac/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
- 5:17 PM Changeset in webkit [144854] by
-
- 1 edit13 adds3 deletes in trunk/LayoutTests
Unreviewed chromium rebaselines for r144837.
- platform/chromium-linux/fast/invalid/017-expected.txt: Added.
- platform/chromium-linux/fast/invalid/018-expected.txt: Added.
- platform/chromium-linux/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
- platform/chromium-linux/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
- platform/chromium-mac-lion/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/chromium-mac/fast/invalid/017-expected.txt: Added.
- platform/chromium-mac/fast/invalid/018-expected.txt: Added.
- platform/chromium-mac/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
- platform/chromium-mac/tables/mozilla/bugs/bug9024-expected.txt: Added.
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
- platform/chromium/fast/invalid/017-expected.txt: Removed.
- platform/chromium/fast/invalid/018-expected.txt: Removed.
- platform/chromium/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
- platform/chromium/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Replaced.
- 5:12 PM Changeset in webkit [144853] by
-
- 5 edits2 adds in trunk
Source/WebCore: [WinCairo] Support for cookies is incomplete
https://bugs.webkit.org/show_bug.cgi?id=110147
Expired and HttpOnly cookies no longer accessible from JavaScript.
Cookies set in JavaScript now have correct domain/path.
Patch by Peter Nelson <peter@peterdn.com> on 2013-03-05
Reviewed by Brent Fulgham.
Test: http/tests/cookies/http-get-cookie-set-in-js.html
- platform/network/curl/CookieJarCurl.cpp:
(WebCore):
(WebCore::addMatchingCurlCookie):
(WebCore::getNetscapeCookieFormat):
(WebCore::setCookiesFromDOM):
(WebCore::cookieRequestHeaderFieldValue):
LayoutTests: [WinCairo] Support for cookies is incomplete
https://bugs.webkit.org/show_bug.cgi?id=110147
Patch by Peter Nelson <peter@peterdn.com> on 2013-03-05
Reviewed by Brent Fulgham.
Re-enabled cookie tests for WinCairo.
Added test to check whether cookie set in HTTP response is accessible in JS.
- http/tests/cookies/http-get-cookie-set-in-js-expected.txt: Added.
- http/tests/cookies/http-get-cookie-set-in-js.html: Added.
- http/tests/cookies/resources/cookies-test-pre.js:
(clearAllCookies): Cookies set in JS now correctly cleared.
- platform/wincairo/TestExpectations:
- 5:10 PM Changeset in webkit [144852] by
-
- 4 edits in trunk/LayoutTests
Unreviewed. AppleWin gardening.
- platform/win/TestExpectations:
- platform/win/css3/filters/effect-reference-expected.txt:
- platform/win/css3/filters/effect-reference-hw-expected.txt:
- 5:08 PM Changeset in webkit [144851] by
-
- 3 edits in trunk/Source/WebKit2
Reset the values if there is a quota error
https://bugs.webkit.org/show_bug.cgi?id=111500
Reviewed by Beth Dakin.
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::didSetItem):
(WebKit::StorageAreaProxy::resetValues):
(WebKit):
- WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
- 4:59 PM Changeset in webkit [144850] by
-
- 3 edits in trunk/Source/WebKit2
Keep track of pending value changes in StorageAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=111496
Reviewed by Beth Dakin.
Add a HashCountedSet to keep track of the number of pending value
changes for a given key. If we get incoming storage events from other
processes while we have pending value changes, ignore the events.
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::setItem):
(WebKit::StorageAreaProxy::didSetItem):
(WebKit::StorageAreaProxy::dispatchStorageEvent):
(WebKit::StorageAreaProxy::shouldApplyChangesForKey):
(WebKit):
- WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
- 4:36 PM Changeset in webkit [144849] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Fix mac clang build with long long
https://bugs.webkit.org/show_bug.cgi?id=111495
Unreviewed fix for mac build.
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::IDBBackingStore):
- 4:35 PM Changeset in webkit [144848] by
-
- 2 edits in trunk/Source
Fix mac clang build with long long
https://bugs.webkit.org/show_bug.cgi?id=111495
Unreviewed fix for mac build.
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::IDBBackingStore):
- 4:26 PM Changeset in webkit [144847] by
-
- 13 edits in trunk/LayoutTests
Unreviewed rebaseline of media/track/track-cue-rendering-*.html
https://bugs.webkit.org/show_bug.cgi?id=111388
- platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png:
- platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png:
- platform/chromium-mac-lion/media/track/track-cue-rendering-horizontal-expected.png:
- platform/chromium-mac-lion/media/track/track-cue-rendering-vertical-expected.png:
- platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.png:
- platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.png:
- platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png:
- platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.png:
- platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png:
- platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png:
- platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png:
- platform/chromium/TestExpectations:
- 4:19 PM Changeset in webkit [144846] by
-
- 3 edits in trunk/Source/WebCore
Add V8Document.h include when the V8 code generator creates a toV8(Document*) call.
https://bugs.webkit.org/show_bug.cgi?id=111486
Reviewed by Adam Barth.
No new tests. This doesn't change user visible behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructor):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
- 4:18 PM Changeset in webkit [144845] by
-
- 9 edits1 add in trunk/Tools
Dashboard cleanup: move string utilities into their own namespace.
https://bugs.webkit.org/show_bug.cgi?id=111485
Reviewed by Ojan Vafai.
One of many pieces to clean up dashboard_base.
Moves string utility functions into separate file (string.js) and into their own namespace rather than cluttering up the global scope.
- TestResultServer/static-dashboards/aggregate_results.html:
- TestResultServer/static-dashboards/dashboard_base.js:
(isTreeMap):
(isFlakinessDashboard):
- TestResultServer/static-dashboards/flakiness_dashboard.html:
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(determineWKPlatform):
(chromiumPlatform):
(platformAndBuildType):
(substringList):
(individualTestsForSubstringList):
(filterBugs):
(populateExpectationsData):
(processMissingTestsWithExpectations):
(processMissingAndExtraExpectations):
(htmlForSingleTestRow):
(.dummyNode.onload):
(expectationsTitle):
- TestResultServer/static-dashboards/run-embedded-unittests.html:
- TestResultServer/static-dashboards/run-unittests.html:
- TestResultServer/static-dashboards/string.js: Added.
- TestResultServer/static-dashboards/timeline_explorer.html:
- TestResultServer/static-dashboards/treemap.html:
- 4:17 PM Changeset in webkit [144844] by
-
- 4 edits in branches/safari-536.29-branch/Source
Versioning.
- 4:16 PM Changeset in webkit [144843] by
-
- 2 edits in trunk/Source/JavaScriptCore
Objective-C API: JSValue should implement init and return nil in exceptional cases
https://bugs.webkit.org/show_bug.cgi?id=111487
Reviewed by Darin Adler.
- API/JSValue.mm:
(-[JSValue init]): We return nil here because there is no way to get the instance into a coherent state
without a JSContext.
(-[JSValue initWithValue:inContext:]): Similarly, we should also return nil here if either of the arguments is 0.
- 4:15 PM Changeset in webkit [144842] by
-
- 14 edits in trunk
[EFL] Build break with latest EFL libraries
https://bugs.webkit.org/show_bug.cgi?id=111028
Reviewed by Dirk Pranke.
.:
In latest EFL trunk, include path of ecore sub modules are changed from
ecore-1 to ecore-XXX-1.
So, this patch adds missing ECORE_XXX_INCLUDE_DIRS.
- Source/cmake/FindEcore.cmake: Added additional path suffixes to find include directories of ecore-XXX
- Source/cmake/FindElementary.cmake: Checked Ecore_Con dependency which Elementary requires.
- Source/cmake/OptionsEfl.cmake: Made Imf and Imf_Evas mandatory.
Source/WebKit:
- PlatformEfl.cmake: Added ECORE_X_INCLUDE_DIRS.
Source/WebKit2:
- PlatformEfl.cmake: Added ECORE_XXX_INCLUDE_DIRS.
Source/WTF:
- wtf/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS.
Tools:
- MiniBrowser/efl/CMakeLists.txt: Added ECORE_XXX_INCLUDE_DIRS.
- TestWebKitAPI/PlatformEfl.cmake: Ditto.
- WebKitTestRunner/PlatformEfl.cmake: Ditto.
- 4:11 PM Changeset in webkit [144841] by
-
- 3 edits1 add in trunk
Fix default background of a dragged image.
https://bugs.webkit.org/show_bug.cgi?id=110512
Reviewed by Tony Chang.
.:
- ManualTests/drag-background-with-padding.html: Added.
Source/WebCore:
Transparent background color (particularly visible in the padding
of an element) was not being respected. The solution is to
initially fill the drag image with transparent instead of white,
so that any color background works correctly. This patch does not
affect Apple Mac or Win platforms, given that this part of the
code is #if guarded from those platforms.
Manual test added:
ManualTests/drag-background-with-padding.html
Infrastructure for retrieving the drag image for pixel testing
does not yet exist.
- page/Frame.cpp:
(WebCore::Frame::nodeImage):
- 4:10 PM Changeset in webkit [144840] by
-
- 3 edits in trunk/Tools
Increase number of WinEWS iterations to 20.
Don't reboot after each iteration set.
Make EWS bots just build temporarily so that the queue catches up again.
- EWSTools/start-queue-win.sh:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 4:05 PM Changeset in webkit [144839] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: /inspector/debugger/debugger-script-preprocessor.html
- 4:01 PM Changeset in webkit [144838] by
-
- 2 edits in trunk/Source/WebKit2
Use a named parameter for whether a quota error ocurred or not
https://bugs.webkit.org/show_bug.cgi?id=111490
Reviewed by Beth Dakin.
This is clearer than setItem returning true on error.
Also, actually set the item in the storage map.
- UIProcess/Storage/StorageManager.cpp:
(StorageManager::StorageArea):
(WebKit::StorageManager::StorageArea::setItem):
(WebKit::StorageManager::setItem):
- 3:59 PM Changeset in webkit [144837] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: i < size(), UNKNOWN in WebCore::RenderTableSection::layout
https://bugs.webkit.org/show_bug.cgi?id=108838
Source/WebCore:
Reviewed by Levi Weintraub.
Ensure that RenderTable::recalcSections is called when moving a
TableSection by calling setNeedsSectionRecalc in addChild for
TableSections.
Test: fullscreen/full-screen-table-section.html
- rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
LayoutTests:
Reviewed by Levi Weintraub.
Add test for calling requestFullscreen on an element with a
table-section display type.
- fullscreen/full-screen-table-section-expected.txt: Added.
- fullscreen/full-screen-table-section.html: Added.
- 3:58 PM Changeset in webkit [144836] by
-
- 1 copy in tags/Safari-536.29.3
New Tag.
- 3:57 PM Changeset in webkit [144835] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skip tests on Windows to make EWS bots happier.
- platform/win/TestExpectations:
- 3:50 PM Changeset in webkit [144834] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: fullscreen/full-screen-iframe-allowed-prexied.
- 3:50 PM Changeset in webkit [144833] by
-
- 18 edits in trunk/Source
Upgrade ANGLE to r1987
https://bugs.webkit.org/show_bug.cgi?id=111381
Reviewed by Dean Jackson.
Source/ThirdParty/ANGLE:
- include/GLSLANG/ShaderLang.h:
- src/common/version.h:
- src/compiler/Compiler.cpp:
(TCompiler::TCompiler):
(TCompiler::Init):
(TCompiler::compile):
- src/compiler/ParseHelper.h:
(TParseContext):
- src/compiler/ShHandle.h:
(TCompiler):
- src/compiler/ShaderLang.cpp:
(ShInitBuiltInResources):
- src/compiler/UnfoldShortCircuit.cpp:
(sh::UnfoldShortCircuit::visitSelection):
- src/compiler/glslang.l:
- src/compiler/glslang.y:
- src/compiler/glslang_lex.cpp:
(glslang_scan):
- src/compiler/glslang_tab.cpp:
Updated ANGLE to r1987.
Source/WebCore:
Covered by existing tests. Ran WebGL conformance tests in Safari
to ensure correct operation of patch.
- platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::initializeANGLE):
Changed all ports to query for highp support in fragment
shaders and conditionally enable it in ANGLE shader translator.
- 3:46 PM Changeset in webkit [144832] by
-
- 5 edits in trunk
Use new assertion API for process suppression on Mac
https://bugs.webkit.org/show_bug.cgi?id=111387
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-03-05
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
- Shared/ChildProcess.h:
(WebKit::ChildProcess::processSuppressionEnabled): Rename
m_processVisibleAssertion to m_processSuppressionAssertion.
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::setProcessSuppressionEnabled): Ditto. And,
replace calls to WKNSProcessInfoProcessAssertionWithTypes() with call to
-[NSProcessInfo beginSuspensionOfSystemBehaviors:].
WebKitLibraries:
Add WKProcessSuppressionSystemBehaviors constant for use in WebKit2 to
take a process suppression assertion.
- WebKitSystemInterface.h:
- 3:45 PM Changeset in webkit [144831] by
-
- 10 edits2 adds in branches/safari-536.29-branch/Source/WebKit2
<rdar://problem/13345073>
- 3:43 PM WikiStart edited by
- Added a link to wiki:"May 2013 Meeting" (diff)
- 3:42 PM May 2013 Meeting created by
- Add 2013 contributor's meeting page
- 3:33 PM Changeset in webkit [144830] by
-
- 4 edits1 add in trunk/Source
IndexedDB: Add IDBBackingStoreTest
https://bugs.webkit.org/show_bug.cgi?id=111233
Reviewed by Adam Barth.
Source/WebCore:
These are tweaks to make IDBBackingStore more easily testable.
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::IDBBackingStore): Allow use without a backing store.
Source/WebKit/chromium:
Add some really simple IDBBackingStore tests
as a seed for additional tests later.
- WebKit.gypi:
- tests/IDBBackingStoreTest.cpp: Added.
- 3:31 PM Changeset in webkit [144829] by
-
- 5 edits in trunk/Source/WebKit2
Move storageType() to StorageAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=111488
Reviewed by Andreas Kling.
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::StorageAreaProxy):
(WebKit::StorageAreaProxy::storageType):
(WebKit::StorageAreaProxy::disabledByPrivateBrowsingInFrame):
- WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
- WebProcess/Storage/StorageNamespaceProxy.cpp:
- WebProcess/Storage/StorageNamespaceProxy.h:
- 3:31 PM Changeset in webkit [144828] by
-
- 2 edits in trunk/LayoutTests
Remove old Mac test expectations for the bug 106412.
- platform/mac/TestExpectations:
- 3:15 PM Changeset in webkit [144827] by
-
- 14 edits in trunk
[chromium] Move check for threaded compositing from WebCompositorSupport to Platform
https://bugs.webkit.org/show_bug.cgi?id=111386
Reviewed by Adrienne Walker.
Source/Platform:
This moves the query for if threaded compositing is enabled from WebCompositorSupport
to Platform. This is part of an effort to remove statefulness on WebCompositorSupport
and because it's much easier to override Platform functions for different tests.
- chromium/public/Platform.h:
(WebKit::Platform::isThreadedCompositingEnabled):
(Platform):
- chromium/public/WebCompositorSupport.h:
Source/WebCore:
This moves checks for whether threaded compositing is enabled from WebCompositorSupport
to Platform. In the case of Canvas2DLayerBridge, the check is moved completely out of
the class to make it easier for tests to specify the threaded configuration to use in the test.
- platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
- platform/graphics/chromium/Canvas2DLayerBridge.h:
(WebCore::Canvas2DLayerBridge::create):
(Canvas2DLayerBridge):
- platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::createAcceleratedCanvas):
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::scheduleAnimation):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::scheduleComposite):
- tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):
- tests/Canvas2DLayerManagerTest.cpp:
(FakeCanvas2DLayerBridge::FakeCanvas2DLayerBridge):
Tools:
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
- 3:13 PM WebKit Team edited by
- Move pdr@google.com to the reviewers list (diff)
- 3:04 PM Changeset in webkit [144826] by
-
- 4 edits in trunk/Source/WebCore
Split up the storage event dispatch functions further
https://bugs.webkit.org/show_bug.cgi?id=111482
Reviewed by Beth Dakin.
Add new functions for dispatching storage events to a set of frames.
- storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::dispatchStorageEvent):
- storage/StorageEventDispatcher.cpp:
(WebCore::StorageEventDispatcher::dispatchSessionStorageEvents):
(WebCore::StorageEventDispatcher::dispatchLocalStorageEvents):
(WebCore):
(WebCore::StorageEventDispatcher::dispatchSessionStorageEventsToFrames):
(WebCore::StorageEventDispatcher::dispatchLocalStorageEventsToFrames):
- storage/StorageEventDispatcher.h:
(WebCore):
(StorageEventDispatcher):
- 2:53 PM Changeset in webkit [144825] by
-
- 4 edits2 adds in trunk
Crash when ImageLoader deletes Element inside SVGImageElement
https://bugs.webkit.org/show_bug.cgi?id=111085
Reviewed by Abhishek Arya.
Source/WebCore:
Elements with ImageLoader objects associated with them may have their
final reference held by the ImageLoader (to allow events to be sent
and handled). Any call on Element that causes the ImageLoader to
dispatch events might then result in the final deref of the Element
itself, thus leaving all the Element's "this" pointers up the stack
pointing to invalid memory.
This change puts the deref of the Element on a timer so that, if the
deref is called via a method on Element, the call stack will unwind
before the deref occurs.
Test: svg/custom/image-with-attr-change-after-delete-crash.html
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::ImageLoader): Initialize a timer
(WebCore::ImageLoader::updatedHasPendingEvent): Put deref of the
element on a oneShotTimer, with appropriate assertions and checks to
ensure we only ref/deref once.
(WebCore::ImageLoader::timerFired): Deref the element when the timer fires.
- loader/ImageLoader.h:
(ImageLoader): Define a timer for controlling deref of the element.
LayoutTests:
- svg/custom/image-with-attr-change-after-delete-crash-expected.txt: Added.
- svg/custom/image-with-attr-change-after-delete-crash.html: Added.
- 2:48 PM Changeset in webkit [144824] by
-
- 5 edits2 adds in trunk
Web Inspector: identify reflection layers in LayerTreeAgent
https://bugs.webkit.org/show_bug.cgi?id=111419
Source/WebCore:
We add a new property "isReflection" to the Layer objects returned
to the front-end to indicate whether the layer was created to host
the reflection for an element. When this new property is true, the
"nodeId" property is set to point to the reflected element's node
id, since there is no node per-se directly associated with this layer.
We also change the "bounds" property to return absolute page coordinates
such that the front-end can use this information to highlight that
region in the page since metrics would otherwise be unavailable.
Reviewed by Dean Jackson.
Test: inspector-protocol/layers/layers-reflected-content.html
- inspector/Inspector.json:
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
LayoutTests:
New test for reflection layers and an updated output for the
existing layersForNode() test since we changed the coordinates
for the "bounds" property to be absolute instead of local.
Reviewed by Dean Jackson.
- inspector-protocol/layers/layers-for-node-expected.txt:
- inspector-protocol/layers/layers-reflected-content-expected.txt: Added.
- inspector-protocol/layers/layers-reflected-content.html: Added.
- 2:47 PM Changeset in webkit [144823] by
-
- 3 edits in trunk/Source/WebCore
[WinCairo] Compile fix after r144024.
https://bugs.webkit.org/show_bug.cgi?id=111306
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-03-05
Reviewed by James Robinson.
- page/scrolling/ScrollingCoordinator.cpp: Added guard for USE(ACCELERATED_COMPOSITING).
- page/scrolling/ScrollingCoordinator.h: Added guard for USE(ACCELERATED_COMPOSITING).
- 2:46 PM Changeset in webkit [144822] by
-
- 2 edits in trunk/Tools
Copy dictionary to the external storage before running layout test on android
https://bugs.webkit.org/show_bug.cgi?id=111480
Patch by Min Qin <qinmin@chromium.org> on 2013-03-05
Reviewed by Adam Barth.
TestWebKitPlatformSupport now needs to read an external dictionary file.
This file does not exist on the device. We need to copy it before running layout tests.
- Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
(ChromiumAndroidDriver._push_platform_resources):
- 2:44 PM Changeset in webkit [144821] by
-
- 4 edits1 add in trunk/Source
keydown and keyup events have zero keycode for some numeric pad keys under Chromium on Linux
https://bugs.webkit.org/show_bug.cgi?id=85642
Source/WebCore:
Add missing key mappings for GDK_KP_Begin, GDK_KP_Insert, GDK_KP_Delete and GDK_ISO_Level3_Shift.
Patch by James Weatherall <wez@chromium.org> on 2013-03-05
Reviewed by Ojan Vafai.
- platform/chromium/KeyCodeConversionGtk.cpp:
(WebCore::windowsKeyCodeForKeyEvent):
Source/WebKit/chromium:
Add tests to verify that the fixed keys generate the same keyCode values as their equivalents.
Patch by James Weatherall <wez@chromium.org> on 2013-03-05
Reviewed by Ojan Vafai.
- WebKit.gypi:
- tests/KeyCodeConversionTestGtk.cpp: Added.
(WebCore):
(WebCore::TEST):
- 2:35 PM Changeset in webkit [144820] by
-
- 37 edits1 copy in trunk/Source
IndexedDB: Properly refactor frontend/backend code by #includes
https://bugs.webkit.org/show_bug.cgi?id=110653
Reviewed by Dimitri Glazkov.
Source/WebCore:
IndexedDB has a distinct backend and frontend, with well defined
*Interface / *Callbacks classes distinguishing them, respectively.
This makes sure that the frontend and backend do not include each
other and fixes build problems that occurred as a result.
Specifically this moves enums out of IDBCursor and IDBTransaction
into IndexedDB.h in a new WebCore::IndexedDB namespace.
No new tests, as this is just a refactor.
Source/WebKit/chromium:
Clean up the frontend/backend WebIDB* implementations to
match the changes to webkit.
- 2:30 PM Changeset in webkit [144819] by
-
- 8 edits in trunk
Clear associated cache partitions when deleting origins' cache
https://bugs.webkit.org/show_bug.cgi?id=111383
Reviewed by Maciej Stachowiak.
Source/WebCore:
Clear the cache partitions associated with the origin being cleared.
Not possible to test with current automated test tools, must be tested manually.
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::removeResourcesWithOrigin):
Source/WebKit2:
Clear the cache partitions associated with the origin being cleared.
- WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:
(WebKit):
(WebKit::partitionName):
(WebKit::WebResourceCacheManager::clearCFURLCacheForHostNames):
WebKitLibraries:
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- 2:25 PM Changeset in webkit [144818] by
-
- 11 edits3 copies2 moves1 add in trunk/LayoutTests
Rebaseline text output for opaque GraphicsLayers
https://bugs.webkit.org/show_bug.cgi?id=109507
Unreviewed rebaseline.
- compositing/contents-opaque/contents-opaque-background-color-expected.txt:
- compositing/contents-opaque/contents-opaque-layer-opacity-expected.txt:
- compositing/contents-opaque/contents-opaque-layer-transform-expected.txt:
- platform/chromium/TestExpectations:
- platform/chromium/compositing/contents-opaque/contents-opaque-background-color-expected.txt: Copied from LayoutTests/compositing/contents-opaque/contents-opaque-background-color-expected.txt.
- platform/chromium/compositing/contents-opaque/contents-opaque-layer-opacity-expected.txt: Copied from LayoutTests/compositing/contents-opaque/contents-opaque-layer-opacity-expected.txt.
- platform/chromium/compositing/contents-opaque/contents-opaque-layer-transform-expected.txt: Copied from LayoutTests/compositing/contents-opaque/contents-opaque-layer-transform-expected.txt.
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt: Renamed from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt.
- platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt: Renamed from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt.
- platform/efl/TestExpectations:
- platform/efl/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- 2:18 PM Changeset in webkit [144817] by
-
- 4 edits3 adds35 deletes in trunk/LayoutTests
editing/pasteboard/paste-text-005.html, paste-text-006.html, and paste-text-007.html should be dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=111466
Reviewed by Levi Weintraub.
- editing/pasteboard/paste-text-005-expected.txt: Added.
- editing/pasteboard/paste-text-005.html:
- editing/pasteboard/paste-text-006-expected.txt: Added.
- editing/pasteboard/paste-text-006.html:
- editing/pasteboard/paste-text-007-expected.txt: Added.
- editing/pasteboard/paste-text-007.html:
- platform/chromium-linux/editing/pasteboard/paste-text-005-expected.png: Removed.
- platform/chromium-linux/editing/pasteboard/paste-text-006-expected.png: Removed.
- platform/chromium-linux/editing/pasteboard/paste-text-007-expected.png: Removed.
- platform/chromium-mac-lion/editing/pasteboard/paste-text-005-expected.png: Removed.
- platform/chromium-mac-lion/editing/pasteboard/paste-text-006-expected.png: Removed.
- platform/chromium-mac-lion/editing/pasteboard/paste-text-007-expected.png: Removed.
- platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-005-expected.txt: Removed.
- platform/chromium-mac/editing/pasteboard/paste-text-005-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/paste-text-006-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/paste-text-007-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-005-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-005-expected.txt: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-006-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-006-expected.txt: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-007-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-text-007-expected.txt: Removed.
- platform/chromium/editing/pasteboard/paste-text-005-expected.txt: Removed.
- platform/chromium/editing/pasteboard/paste-text-006-expected.txt: Removed.
- platform/chromium/editing/pasteboard/paste-text-007-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-text-005-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-text-006-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-text-007-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-text-005-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-text-005-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-text-006-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-text-006-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-text-007-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-text-007-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-text-005-expected.png: Removed.
- platform/qt/editing/pasteboard/paste-text-005-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-text-006-expected.png: Removed.
- platform/qt/editing/pasteboard/paste-text-006-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-text-007-expected.png: Removed.
- platform/qt/editing/pasteboard/paste-text-007-expected.txt: Removed.
- platform/win/editing/pasteboard/paste-text-005-expected.txt: Removed.
- 2:04 PM Changeset in webkit [144816] by
-
- 3 edits in trunk/Source/WebCore
Inline min/maxInstrinsicLogicalWidth functions
https://bugs.webkit.org/show_bug.cgi?id=111399
Reviewed by Tony Chang.
Turns out these functions don't need to be public and only
have one caller. This patch is in preparation for supporting
intrinsic widths on tables, which will need to pass in the
border and padding width as an argument.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::fillAvailableMeasure):
(WebCore::RenderBox::computeIntrinsicLogicalWidthUsing):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
- rendering/RenderBox.h:
- 2:04 PM Changeset in webkit [144815] by
-
- 2 edits1 add13 deletes in trunk/LayoutTests
editing/pasteboard/paste-table-003.html should be a dump-as-text test
https://bugs.webkit.org/show_bug.cgi?id=111400
Reviewed by Levi Weintraub.
Convert the test to a dump-as-text test. The output is much easier to understand now.
Also moved the test description out of the root element so that it won't be repeated
multiple times in the output.
- editing/pasteboard/paste-table-003-expected.txt: Added.
- editing/pasteboard/paste-table-003.html:
- platform/chromium-linux/editing/pasteboard/paste-table-003-expected.png: Removed.
- platform/chromium-mac-lion/editing/pasteboard/paste-table-003-expected.png: Removed.
- platform/chromium-mac-snowleopard/editing/pasteboard/paste-table-003-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/paste-table-003-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-table-003-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/paste-table-003-expected.txt: Removed.
- platform/chromium/editing/pasteboard/paste-table-003-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-table-003-expected.png: Removed.
- platform/gtk/editing/pasteboard/paste-table-003-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-table-003-expected.png: Removed.
- platform/mac/editing/pasteboard/paste-table-003-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-table-003-expected.png: Removed.
- platform/qt/editing/pasteboard/paste-table-003-expected.txt: Removed.
- 2:02 PM Changeset in webkit [144814] by
-
- 4 edits2 adds in trunk
Cue line-height property shouldn't be inherited from the video element
https://bugs.webkit.org/show_bug.cgi?id=111262
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/track-cue-rendering-on-resize.html
- css/mediaControls.css:
(video::-webkit-media-text-track-container): Set the default font size
and family using the "font" property to also reset the line-height property.
LayoutTests:
- media/track/captions-webvtt/captions-snap-to-lines-set.vtt: Updated.
- media/track/track-cue-rendering-on-resize-expected.txt: Added.
- media/track/track-cue-rendering-on-resize.html: Added.
- 1:48 PM Changeset in webkit [144813] by
-
- 6 edits1 delete in trunk/Source/WebCore
IndexedDB: Remove some unused binding code
https://bugs.webkit.org/show_bug.cgi?id=111463
Reviewed by Adam Barth.
IDBRequest got a custom V8 getter for |request| to help diagnose an issue, but the
root cause was found/fixed (http://wkbug.com/110916 and http://wkbug.com/110206) so
remove it. Also, IDBKey was marked ScriptWrappable but it is now explicitly converted
to a ScriptValue before it gets anywhere near the binding code, so remove that too.
Finally, createIDBKeyFromValue doesn't need to be exposed from IDBBindingUtilities.
No new tests - just removing dead code.
- Modules/indexeddb/IDBKey.h: No need for ScriptWrappable.
- Modules/indexeddb/IDBRequest.idl: Remove custom binding (root cause of bug found).
- WebCore.gypi: Ditto.
- bindings/js/IDBBindingUtilities.h: Don't expose internal createIDBKeyFromValue().
- bindings/v8/IDBBindingUtilities.h: Ditto.
- bindings/v8/custom/V8IDBRequestCustom.cpp: Removed.
- 1:47 PM Changeset in webkit [144812] by
-
- 27 edits2 adds in branches/safari-534.59-branch/Source/WebKit2
534.59 branch needs to handle API clients with a non-zero version number
<rdar://problem/13348902> and https://bugs.webkit.org/show_bug.cgi?id=111475
Reviewed by Anders Carlsson.
This patch:
1 - Adds the APIClient and APIClientTraits versioning mechanism from ToT to the branch.
2 - Updates most APIClients to have a current version of 0.
3 - Updates the WKPageLoaderClient and WKPageUIClient to have non-zero current versions.
4 - Allows non-zero versioned clients through the calls to WKPageSetPageLoaderClient and WKPageSetPageUIClient.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageLoaderClient): Allow non-zero clients through.
(WKPageSetPageUIClient): Ditto.
Add the client traits mechanism and implement traits for the two clients that have a non-zero current version:
- Shared/APIClientTraits.cpp: Added.
- Shared/APIClientTraits.h: Added.
Allow for setting versioned clients using those client traits:
- Shared/APIClient.h:
(WebKit::APIClient::initialize):
(WebKit::APIClient::client):
Update the APIClient templatization for all APIClients to pass their current version:
- UIProcess/WebContextInjectedBundleClient.h:
- UIProcess/WebCookieManagerProxyClient.h:
- UIProcess/WebDatabaseManagerProxyClient.h:
- UIProcess/WebDownloadClient.h:
- UIProcess/WebFindClient.h:
- UIProcess/WebFormClient.h:
- UIProcess/WebGeolocationProvider.h:
- UIProcess/WebHistoryClient.h:
- UIProcess/WebIconDatabaseClient.h:
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageContextMenuClient.h:
- UIProcess/WebPolicyClient.h:
- UIProcess/WebResourceLoadClient.h:
- UIProcess/WebUIClient.h:
- WebProcess/InjectedBundle/InjectedBundleClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebKit2.xcodeproj/project.pbxproj:
- 1:41 PM Changeset in webkit [144811] by
-
- 2 edits in trunk/Source/WTF
Fix cast-align warning in ASCIIFastPath.h on ARM
https://bugs.webkit.org/show_bug.cgi?id=111436
Reviewed by Benjamin Poulain.
- wtf/text/ASCIIFastPath.h:
(WTF::charactersAreAllASCII):
- 1:38 PM Changeset in webkit [144810] by
-
- 37 edits1 delete in trunk/Source
Unreviewed, rolling out r144798.
http://trac.webkit.org/changeset/144798
https://bugs.webkit.org/show_bug.cgi?id=111478
"broke chromium windows build" (Requested by dpranke on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-05
Source/WebCore:
- GNUmakefile.list.am:
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::Cursor::continueFunction):
(WebCore::objectStoreCursorOptions):
(WebCore::indexCursorOptions):
(WebCore::IDBBackingStore::openObjectStoreCursor):
(WebCore::IDBBackingStore::openObjectStoreKeyCursor):
(WebCore::IDBBackingStore::openIndexKeyCursor):
(WebCore::IDBBackingStore::openIndexCursor):
- Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::create):
(WebCore::IDBCursor::IDBCursor):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::stringToDirection):
(WebCore::IDBCursor::directionToString):
- Modules/indexeddb/IDBCursor.h:
(IDBCursor):
- Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::deleteFunction):
(WebCore::IDBCursorBackendImpl::CursorPrefetchIterationOperation::perform):
- Modules/indexeddb/IDBCursorBackendImpl.h:
(WebCore::IDBCursorBackendImpl::create):
(WebCore::IDBCursorBackendImpl::value):
(IDBCursorBackendImpl):
- Modules/indexeddb/IDBCursorBackendInterface.h:
(WebCore):
- Modules/indexeddb/IDBCursorWithValue.cpp:
(WebCore::IDBCursorWithValue::create):
(WebCore::IDBCursorWithValue::IDBCursorWithValue):
- Modules/indexeddb/IDBCursorWithValue.h:
(IDBCursorWithValue):
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::transaction):
- Modules/indexeddb/IDBDatabase.h:
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::GetOperation::create):
(WebCore::GetOperation::GetOperation):
(GetOperation):
(WebCore::OpenCursorOperation::create):
(WebCore::OpenCursorOperation::OpenCursorOperation):
(OpenCursorOperation):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::createIndex):
(WebCore::IDBDatabaseBackendImpl::deleteIndex):
(WebCore::IDBDatabaseBackendImpl::get):
(WebCore::GetOperation::perform):
(WebCore::IDBDatabaseBackendImpl::put):
(WebCore::PutOperation::perform):
(WebCore::IDBDatabaseBackendImpl::setIndexKeys):
(WebCore::IDBDatabaseBackendImpl::openCursor):
(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteRange):
(WebCore::DeleteRangeOperation::perform):
(WebCore::IDBDatabaseBackendImpl::clear):
(WebCore::IDBDatabaseBackendImpl::transactionStarted):
(WebCore::IDBDatabaseBackendImpl::transactionFinished):
(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndAbortFired):
(WebCore::IDBDatabaseBackendImpl::transactionFinishedAndCompleteFired):
(WebCore::IDBDatabaseBackendImpl::createTransaction):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
- Modules/indexeddb/IDBDatabaseBackendInterface.h:
- Modules/indexeddb/IDBFactory.h:
- Modules/indexeddb/IDBIndex.cpp:
(WebCore):
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore):
(WebCore::IDBObjectStore::openCursor):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::setCursorDetails):
(WebCore::IDBRequest::setResultCursor):
(WebCore::IDBRequest::onSuccess):
- Modules/indexeddb/IDBRequest.h:
(IDBRequest):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::create):
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::stringToMode):
(WebCore::IDBTransaction::modeToString):
- Modules/indexeddb/IDBTransaction.h:
(WebCore::IDBTransaction::isReadOnly):
(WebCore::IDBTransaction::isVersionChange):
(IDBTransaction):
- Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::create):
(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
- Modules/indexeddb/IDBTransactionBackendImpl.h:
(IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::mode):
- Modules/indexeddb/IDBTransactionCoordinator.cpp:
(WebCore::IDBTransactionCoordinator::processStartedTransactions):
(WebCore::IDBTransactionCoordinator::canRunTransaction):
- Modules/indexeddb/IndexedDB.h: Removed.
- Target.pri:
- WebCore.gypi:
Source/WebKit/chromium:
- src/AssertMatchingEnums.cpp:
- src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::openCursor):
- src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
- src/WebIDBCallbacksImpl.cpp:
- src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::openCursor):
- tests/IDBAbortOnCorruptTest.cpp:
- tests/IDBDatabaseBackendTest.cpp:
- tests/IDBFakeBackingStore.h:
- 1:37 PM Changeset in webkit [144809] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/efl/TestExpectations: Unskipping the fast/workers/shared-worker-load-error.html layout test
and adding a flaky timeout expectation for it. Looking for testing data from the EFL port on this test.
- 1:15 PM Changeset in webkit [144808] by
-
- 7 edits in trunk
MediaStream API: Allow local and remote descriptions to be accessed after close
https://bugs.webkit.org/show_bug.cgi?id=111437
Reviewed by Adam Barth.
Source/WebCore:
It's quite clear in the standard that the getters should still return the old value.
Also overhauling the state setters a bit to check if the new state is different.
Existing tests expanded to cover patch.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::localDescription):
(WebCore::RTCPeerConnection::remoteDescription):
(WebCore::RTCPeerConnection::changeSignalingState):
(WebCore::RTCPeerConnection::changeIceGatheringState):
(WebCore::RTCPeerConnection::changeIceConnectionState):
LayoutTests:
Expanding tests to check the new behaviour.
- fast/mediastream/RTCPeerConnection-localDescription-expected.txt:
- fast/mediastream/RTCPeerConnection-localDescription.html:
- fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt:
- fast/mediastream/RTCPeerConnection-remoteDescription.html:
- 1:14 PM Changeset in webkit [144807] by
-
- 2 edits in trunk/LayoutTests
Multiple html5lib Layout Tests are slow since r144032
https://bugs.webkit.org/show_bug.cgi?id=110876
Reviewed by Tony Chang.
Skip the html5lib tests when in debug mode. The -data variants
almost always timeout due to v8 boot-up time:
https://code.google.com/p/v8/issues/detail?id=2567
These timeouts sometimes manifest as failures, and we've even
seen crashes (with empty stacks!?) of these tests on Win and Mac in Debug, so
skipping them until they run in a reasonable time and can
be debugged further.
- platform/chromium/TestExpectations:
- 1:12 PM Changeset in webkit [144806] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: expectations for transitions/transitions-parsing.html
- 1:11 PM Changeset in webkit [144805] by
-
- 11 edits in trunk/Source
Add FrameLoaderClient::didAccessInitialDocument
https://bugs.webkit.org/show_bug.cgi?id=107963
Source/WebCore:
Notifies the FrameLoaderClient if another page accesses the
initial empty document of a main frame. In this case, it is
no longer safe to display the provisional URL.
Only takes effect for PLATFORM(CHROMIUM), since no other platforms
listen to the notification.
Reviewed by Adam Barth.
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::setSecurityToken):
Use default token for initial document.
- bindings/v8/custom/V8DOMWindowCustom.cpp:
Notify loader if initial document is accessed.
(WebCore::V8DOMWindow::namedSecurityCheck):
(WebCore::V8DOMWindow::indexedSecurityCheck):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::didAccessInitialDocument):
(WebCore):
- loader/FrameLoader.h:
(FrameLoader):
- loader/FrameLoaderClient.h:
(FrameLoaderClient):
(WebCore::FrameLoaderClient::didAccessInitialDocument):
Source/WebKit/chromium:
Notifies WebFrameClient if another page accesses the initial
empty document of a main frame. In this case, it is no longer
safe to display the provisional URL.
Reviewed by Adam Barth.
- public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::didAccessInitialDocument):
- src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didAccessInitialDocument):
(WebKit):
- src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):
- tests/WebFrameTest.cpp:
- 1:08 PM Changeset in webkit [144804] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Fix assertion in CookieManager::getBackingStoreCookies
https://bugs.webkit.org/show_bug.cgi?id=111468
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-03-05
Reviewed by Rob Buis.
Internally reviewed by Konrad Piascik.
The assert in getBackingStoreCookies could be giving out false positives now
that we have our fixes for cookie loading in PR 286189. The cookie store could
be half loaded if the first cookie get/set call happens before the db is fully loaded.
A full webkit sync call to reload the database will cause the assert to be hit.
Safer to flush everything out and try again.
- platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::getBackingStoreCookies):
- 1:07 PM Changeset in webkit [144803] by
-
- 4 edits in branches/safari-536.29-branch/Source
Versioning.
- 12:57 PM Changeset in webkit [144802] by
-
- 2 edits in trunk/Tools
[chromium] DRT crashes in an Aura/Win build
https://bugs.webkit.org/show_bug.cgi?id=111394
Reviewed by Tony Chang.
When building (and running) with use_aura=1, we assume that
we're using the default theme engine, but DRT creates the
DRTWin theme engine and overwrites the default, leading to crashes
in basically every test from the mismatch.
This fix gets us down to at least "lots of crashes" :).
- DumpRenderTree/chromium/TestShellWin.cpp:
(platformInit):
- 12:44 PM Changeset in webkit [144801] by
-
- 8 edits in trunk/Source/WebCore
CompactHTMLToken does not need an XSSInfo pointer
https://bugs.webkit.org/show_bug.cgi?id=111423
Reviewed by Eric Seidel.
The CompactHTMLToken should remain as small as possible because it is copied. This shrinks the size by one pointer
by moving a relatively uncommon attribute out to its own Vector.
No new tests because no new functionality.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::checkThatXSSInfosAreSafeToSendToAnotherThread):
(WebCore):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):
- html/parser/BackgroundHTMLParser.h:
(BackgroundHTMLParser):
- html/parser/CompactHTMLToken.cpp:
(SameSizeAsCompactHTMLToken):
(WebCore::CompactHTMLToken::isSafeToSendToAnotherThread):
- html/parser/CompactHTMLToken.h:
(WebCore):
(CompactHTMLToken):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
- html/parser/HTMLDocumentParser.h:
(ParsedChunk):
- html/parser/XSSAuditorDelegate.h:
(XSSInfo):
(WebCore):
- 12:31 PM Changeset in webkit [144800] by
-
- 4 edits in trunk/Source/WebCore
Split StorageEventDispatcher::dispatch into two functions
https://bugs.webkit.org/show_bug.cgi?id=111464
Reviewed by Beth Dakin.
Split StorageEventDispatcher::dispatch into dispatchSessionStorageEvent and
dispatchLocalStorageEvent and make StorageAreaImpl::dispatchStorageEvent call
the right function based on the storage area type.
- storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::dispatchStorageEvent):
- storage/StorageEventDispatcher.cpp:
(WebCore::StorageEventDispatcher::dispatchSessionStorageEvent):
(WebCore):
(WebCore::StorageEventDispatcher::dispatchLocalStorageEvent):
- storage/StorageEventDispatcher.h:
(StorageEventDispatcher):
- 12:27 PM Changeset in webkit [144799] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Unreviewed build fix after r144024.
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::scrollLayerForScrollableArea): Handle
case of not using Accelerated Compositing
(WebCore::ScrollingCoordinator::horizontalScrollbarLayerForScrollableArea):
(WebCore::ScrollingCoordinator::verticalScrollbarLayerForScrollableArea): Ditto.
- 12:11 PM Changeset in webkit [144798] by
-
- 37 edits1 copy in trunk/Source
IndexedDB: Properly refactor frontend/backend code by #includes
https://bugs.webkit.org/show_bug.cgi?id=110653
Reviewed by Dimitri Glazkov.
Source/WebCore:
IndexedDB has a distinct backend and frontend, with well defined
*Interface / *Callbacks classes distinguishing them, respectively.
This makes sure that the frontend and backend do not include each
other and fixes build problems that occurred as a result.
Specifically this moves enums out of IDBCursor and IDBTransaction
into IndexedDB.h in a new WebCore::IndexedDB namespace.
No new tests, as this is just a refactor.
Source/WebKit/chromium:
Clean up the frontend/backend WebIDB* implementations to
match the changes to webkit.
- 12:09 PM Changeset in webkit [144797] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening
Unreviewed gardening
- platform/chromium/TestExpectations:
- 11:57 AM Changeset in webkit [144796] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r186200. Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-05
- DEPS:
- 11:56 AM Changeset in webkit [144795] by
-
- 6 edits in trunk/Source
ContainerNode::setActive should not sleep for 100ms on platforms that do not implement synchronous repaint(true) semantics
https://bugs.webkit.org/show_bug.cgi?id=87054
Patch by James Robinson <jamesr@chromium.org> on 2013-03-05
Reviewed by Darin Adler.
Source/WebCore:
Adds a new ChromeClient function to query if the platform supports the immediate parameter
to the invalidation APIs and guards the synchronous repaint logic in ContainerNode::setActive()
with it.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::setActive):
- page/ChromeClient.h:
(WebCore::ChromeClient::supportsImmediateInvalidation):
Source/WebKit/mac:
The Mac WebKit1 port supports immediate invalidations.
- WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::supportsImmediateInvalidation):
- 11:49 AM Changeset in webkit [144794] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][EFL] WebPageProxy::setThemePath() should check that the page is valid
https://bugs.webkit.org/show_bug.cgi?id=109917
Reviewed by Alexey Proskuryakov.
WebPageProxy::setThemePath() should check that the page is valid before
sending IPC message.
- UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::setThemePath):
- 11:49 AM Changeset in webkit [144793] by
-
- 1 edit1 move1 add13 deletes in trunk/LayoutTests
editing/pasteboard/5247341.html should be a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=111397
Reviewed by Darin Adler.
Convert the test to use dump-as-markup.js. Also rename it to preserve-line-break-at-end-of-pasted-content
to reflect the content of the test.
- editing/pasteboard/5247341.html: Removed.
- editing/pasteboard/preserve-line-break-at-end-of-pasted-content-expected.txt: Added.
- editing/pasteboard/preserve-line-break-at-end-of-pasted-content.html: Copied from LayoutTests/editing/pasteboard/5247341.html.
- platform/chromium-linux/editing/pasteboard/5247341-expected.png: Removed.
- platform/chromium-mac-lion/editing/pasteboard/5247341-expected.png: Removed.
- platform/chromium-mac-snowleopard/editing/pasteboard/5247341-expected.png: Removed.
- platform/chromium-mac/editing/pasteboard/5247341-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/5247341-expected.png: Removed.
- platform/chromium-win/editing/pasteboard/5247341-expected.txt: Removed.
- platform/chromium/editing/pasteboard/5247341-expected.txt: Removed.
- platform/gtk/editing/pasteboard/5247341-expected.png: Removed.
- platform/gtk/editing/pasteboard/5247341-expected.txt: Removed.
- platform/mac/editing/pasteboard/5247341-expected.png: Removed.
- platform/mac/editing/pasteboard/5247341-expected.txt: Removed.
- platform/qt/editing/pasteboard/5247341-expected.png: Removed.
- platform/qt/editing/pasteboard/5247341-expected.txt: Removed.
- 11:43 AM Changeset in webkit [144792] by
-
- 1 copy in tags/Safari-536.29.2
New Tag.
- 11:43 AM Changeset in webkit [144791] by
-
- 3 edits in trunk/Source/WebCore
Simplify storage event dispatch somewhat
https://bugs.webkit.org/show_bug.cgi?id=111461
Reviewed by Beth Dakin.
Add a StorageAreaImpl::dispatchStorageEvent to avoid replicating the calls to
StorageEventDispatcher::dispatch there times. This is in preparation for changing the
interface of StorageEventDispatcher so it can be used by WebKit2.
- storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::setItem):
(WebCore::StorageAreaImpl::removeItem):
(WebCore::StorageAreaImpl::clear):
(WebCore::StorageAreaImpl::dispatchStorageEvent):
- storage/StorageAreaImpl.h:
Reindent.
- 11:41 AM Changeset in webkit [144790] by
-
- 3 edits2 adds in trunk
Fix some crashes in render sliders
https://bugs.webkit.org/show_bug.cgi?id=111458
Reviewed by Ojan Vafai.
Source/WebCore:
Fix some cases where we assumed the renderer is a renderBox.
Test: fast/forms/range/slider-inline-crash.html
- html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderContainer::layout): Use renderBox() which will return 0 if the renderer is not a RenderBox.
(WebCore::SliderThumbElement::setPositionFromPoint): Bail out early if renderBox() is 0.
LayoutTests:
- fast/forms/range/slider-inline-crash-expected.txt: Added.
- fast/forms/range/slider-inline-crash.html: Added.
- 11:37 AM Changeset in webkit [144789] by
-
- 5 edits in trunk
REGRESSION(r142191): Fix closed caption buttons for ports still using the painting path.
https://bugs.webkit.org/show_bug.cgi?id=111109
Reviewed by Eric Carlson.
Source/WebCore:
Covered by following tests:
media/track/track-cue-rendering-horizontal.html
media/track/track-cue-rendering-vertical.html
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
- rendering/RenderTheme.h:
(WebCore::RenderTheme::paintMediaToggleClosedCaptionsButton):
LayoutTests:
- platform/chromium/TestExpectations:
- 11:17 AM Changeset in webkit [144788] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13269245> Crashes creating WebKit processes in WKSandboxExtensionConsume
https://bugs.webkit.org/show_bug.cgi?id=111456
Reviewed by Anders Carlsson.
It's too late to be draconian about this condition here, crashing doesn't help
diagnose what went wrong when creating a sandbox extension.
Other SandboxExtension functions already have null checks for WKSandboxExtensionRef,
and so should consumePermanently().
- Shared/mac/SandboxExtensionMac.mm: (WebKit::SandboxExtension::createHandle): For now, added logging when extension creation fails. If that proves insufficiently helpful in practice, we can change to a CRASH() later. (WebKit::SandboxExtension::createHandleForTemporaryFile): Ditto. (WebKit::SandboxExtension::consumePermanently): Gracefully fail if there is no extension to consume.
- 11:16 AM Changeset in webkit [144787] by
-
- 17 edits1 add1 delete in trunk/Source
Coordinated Graphics: CoordinatedGraphicsLayer makes CoordinatedGraphicsScene perform via CoordinatedGraphicsState.
https://bugs.webkit.org/show_bug.cgi?id=108294
Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2013-03-05
Reviewed by Anders Carlsson.
Source/WebCore:
CoordinatedLayerTreeHostProxy has too many IPC messages (e.g. SyncCanvas and
CreateTile), and there is a long function chain from CoordinatedGraphicsLayer to
CoordinatedGraphicsScene (4 classes).
If we want to add a new message, we need to add similar functions into 4 classes.
Now CoordinatedLayerTreeHost has only one IPC message for CoordinatedGraphicsLayer:
CommitCoordinatedGraphicsState.
CoordinatedGraphicsLayer makes CoordinatedGraphicsScene run as follows:
- CoordinatedGraphicsLayer makes a CoordinatedGraphicsLayerState.
- CoordinatedLayerTreeHost stores all LayerStates.
- CoordinatedLayerTreeHost sends GraphicsState includes LayerStates to CoordinatedLayerTreeHostProxy
at the moment of flushing via CommitCoordinatedGraphicsState message.
- CoordinatedGraphicsScene applies all state changes to layers.
There is one big behavior change. All states changes (e.g.
UpdateTiles, SetLayerChildren, and etc..) are performed at the same time, when
CoordinatedGraphicsScene::commitCoordinatedGraphicsState is called.
This patch is based on Dongsung Huang, and Noam's work in
https://bugs.webkit.org/show_bug.cgi?id=108294
No new tests, covered by existing tests.
- Target.pri:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setPosition):
(WebCore::CoordinatedGraphicsLayer::setAnchorPoint):
(WebCore::CoordinatedGraphicsLayer::setSize):
(WebCore::CoordinatedGraphicsLayer::setTransform):
(WebCore::CoordinatedGraphicsLayer::setChildrenTransform):
(WebCore::CoordinatedGraphicsLayer::setPreserves3D):
(WebCore::CoordinatedGraphicsLayer::setMasksToBounds):
(WebCore::CoordinatedGraphicsLayer::setDrawsContent):
(WebCore::CoordinatedGraphicsLayer::setContentsVisible):
(WebCore::CoordinatedGraphicsLayer::setContentsOpaque):
(WebCore::CoordinatedGraphicsLayer::setBackfaceVisibility):
(WebCore::CoordinatedGraphicsLayer::setOpacity):
(WebCore::CoordinatedGraphicsLayer::setContentsRect):
(WebCore::CoordinatedGraphicsLayer::setFilters):
(WebCore::CoordinatedGraphicsLayer::setContentsToSolidColor):
(WebCore::CoordinatedGraphicsLayer::setShowDebugBorder):
(WebCore::CoordinatedGraphicsLayer::setShowRepaintCounter):
(WebCore::CoordinatedGraphicsLayer::setMaskLayer):
(WebCore::CoordinatedGraphicsLayer::setReplicatedByLayer):
(WebCore::CoordinatedGraphicsLayer::setFixedToViewport):
(WebCore::CoordinatedGraphicsLayer::syncChildren):
(WebCore::CoordinatedGraphicsLayer::syncFilters):
(WebCore::CoordinatedGraphicsLayer::syncImageBacking):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
(WebCore::CoordinatedGraphicsLayer::setDebugBorder):
(WebCore::CoordinatedGraphicsLayer::syncAnimations):
(WebCore::CoordinatedGraphicsLayer::syncCanvas):
(WebCore::CoordinatedGraphicsLayer::destroyCanvasIfNeeded):
(WebCore::CoordinatedGraphicsLayer::createCanvasIfNeeded):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
(WebCore::CoordinatedGraphicsLayer::resetLayerState):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::releaseImageBackingIfNeeded):
(WebCore::CoordinatedGraphicsLayer::setRootLayer):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStorePaintEnd):
(WebCore::CoordinatedGraphicsLayer::createTile):
(WebCore::CoordinatedGraphicsLayer::updateTile):
(WebCore::CoordinatedGraphicsLayer::removeTile):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::createCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::syncCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::destroyCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerRepaintCountIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerChildrenIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerFiltersIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerState):
(WebCore::CoordinatedGraphicsScene::deleteLayer):
(WebCore::CoordinatedGraphicsScene::createTilesIfNeeded):
(WebCore::CoordinatedGraphicsScene::removeTilesIfNeeded):
(WebCore::CoordinatedGraphicsScene::updateTilesIfNeeded):
(WebCore::CoordinatedGraphicsScene::assignImageBackingToLayer):
(WebCore::CoordinatedGraphicsScene::commitSceneState):
(WebCore::CoordinatedGraphicsScene::setLayerAnimationsIfNeeded):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
(WebCore):
(CoordinatedGraphicsScene):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h: Added.
(WebCore):
(TileUpdateInfo):
(TileCreationInfo):
(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):
(CoordinatedGraphicsLayerState):
(CoordinatedGraphicsState):
- platform/graphics/texmap/coordinated/CoordinatedImageBacking.h:
- platform/graphics/texmap/coordinated/CoordinatedLayerInfo.h: Removed.
- platform/graphics/texmap/coordinated/SurfaceUpdateInfo.h:
Source/WebKit2:
There are two changes in WK2.
- Change CoordinatedLayerTreeHostProxy to use CoordinatedGraphicsState.
- Add encode/decode of CoordinatedGraphicsState in CoordinatedGraphicsArgumentCoders.
This patch is based on Dongsung Huang, and Noam's work in
https://bugs.webkit.org/show_bug.cgi?id=108294
No new tests, covered by existing tests.
- Scripts/webkit2/messages.py:
(headers_for_type):
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
Encoding UpdateImageBacking and CreateUpdateAtlas can fail when
encoding WebCoordinatedSurface::Handle fails, but we don't
recover in the case.
(CoreIPC::::decode):
(CoreIPC):
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
(WebCore):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
(WebKit::CoordinatedLayerTreeHostProxy::commitCoordinatedGraphicsState):
(WebKit):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
(WebCore):
(CoordinatedLayerTreeHostProxy):
(WebKit::CoordinatedLayerTreeHostProxy::coordinatedGraphicsScene):
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::flushPendingLayerChanges):
(WebKit::CoordinatedLayerTreeHost::initializeRootCompositingLayerIfNeeded):
(WebKit::CoordinatedLayerTreeHost::syncLayerState):
(WebKit::CoordinatedLayerTreeHost::prepareCustomFilterProxiesIfNeeded):
(WebKit):
(WebKit::CoordinatedLayerTreeHost::updateImageBacking):
(WebKit::CoordinatedLayerTreeHost::setBackgroundColor):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(CoordinatedLayerTreeHost):
- 11:13 AM Changeset in webkit [144786] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed. AppleWin VS2010 build fix.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- rendering/RenderingAllInOne.cpp:
- 11:07 AM Changeset in webkit [144785] by
-
- 4 edits1 move in trunk
Add html-parser-threaded perf test now that the threaded parser is enabled by default
https://bugs.webkit.org/show_bug.cgi?id=111200
Reviewed by Ryosuke Niwa.
PerformanceTests:
The old srcdoc test no longer triggers the threaded parser due to compatibility fixes.
- Parser/html-parser-threaded.html: Renamed from PerformanceTests/Parser/html-parser-srcdoc.html.
- Skipped: Unfortunately this new test is still skipped too.
Tools:
Had to teach run-perf-tests to ignore one more warning.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
- 11:07 AM Changeset in webkit [144784] by
-
- 18 edits1 delete in trunk
[chromium] Clean up WebWidget / WebLayerTreeView interactions
https://bugs.webkit.org/show_bug.cgi?id=109125
Patch by James Robinson <jamesr@chromium.org> on 2013-03-05
Reviewed by Adrienne Walker.
Source/Platform:
This deprecates most of the calls on WebLayerTreeViewClient since these interactions are handled
entirely on the embedder side of the interface now.
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
- chromium/public/WebLayerTreeViewClient.h:
(WebLayerTreeViewClient):
(WebKit::WebLayerTreeViewClient::willBeginFrame):
(WebKit::WebLayerTreeViewClient::didBeginFrame):
(WebKit::WebLayerTreeViewClient::applyScrollAndScale):
(WebKit::WebLayerTreeViewClient::layout):
(WebKit::WebLayerTreeViewClient::didRecreateOutputSurface):
(WebKit::WebLayerTreeViewClient::createInputHandler):
(WebKit::WebLayerTreeViewClient::createOutputSurface):
(WebKit::WebLayerTreeViewClient::willCommit):
(WebKit::WebLayerTreeViewClient::didCommit):
(WebKit::WebLayerTreeViewClient::didCommitAndDrawFrame):
(WebKit::WebLayerTreeViewClient::didCompleteSwapBuffers):
Source/WebKit/chromium:
This removes most of the compositing control flow logic from WebViewImpl since
it is now handled in the embedding layer (by the implementation of WebViewClient/WebWidgetClient).
- public/WebViewClient.h:
- public/WebWidget.h:
(WebKit):
(WebKit::WebWidget::animate):
(WebWidget):
(WebKit::WebWidget::didExitCompositingMode):
(WebKit::WebWidget::createInputHandler):
(WebKit::WebWidget::applyScrollAndScale):
(WebKit::WebWidget::instrumentBeginFrame):
(WebKit::WebWidget::instrumentWillBeginFrame):
(WebKit::WebWidget::instrumentDidCancelFrame):
(WebKit::WebWidget::instrumentDidBeginFrame):
(WebKit::WebWidget::instrumentWillComposite):
- src/WebHelperPluginImpl.cpp:
- src/WebHelperPluginImpl.h:
(WebHelperPluginImpl):
- src/WebPagePopupImpl.cpp:
- src/WebPagePopupImpl.h:
(WebPagePopupImpl):
- src/WebPopupMenuImpl.cpp:
- src/WebPopupMenuImpl.h:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::instrumentWillBeginFrame):
(WebKit::WebViewImpl::instrumentDidBeginFrame):
(WebKit::WebViewImpl::instrumentDidCancelFrame):
(WebKit::WebViewImpl::instrumentWillComposite):
(WebKit):
(WebKit::WebViewImpl::updateBatteryStatus):
(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::didExitCompositingMode):
- src/WebViewImpl.h:
- tests/WebLayerTreeViewTestCommon.h:
(MockWebLayerTreeViewClient):
- 11:05 AM Changeset in webkit [144783] by
-
- 2 edits in trunk/Tools
Update list of builders for test results server
https://bugs.webkit.org/show_bug.cgi?id=111166
Reviewed by Ojan Vafai.
- TestResultServer/static-dashboards/builders.jsonp:
- 10:54 AM Changeset in webkit [144782] by
-
- 2 edits in tags/Safari-537.31.14/Source/WebCore
Merged r143490. <rdar://problem/13341434>
- 10:49 AM Changeset in webkit [144781] by
-
- 15 edits in tags/Safari-537.31.14/Source
Merged r143428. <rdar://problem/13341434>
- 10:30 AM Changeset in webkit [144780] by
-
- 1 edit1 add in trunk/Tools
[GTK] Move basic dependency installation to a script
https://bugs.webkit.org/show_bug.cgi?id=110692
Patch by Martin Robinson <mrobinson@igalia.com> and Tomas Popela <tpopela@redhat.com> on 2013-03-05
Reviewed by Gustavo Noronha Silva.
- gtk/install-dependencies: Added. A Script which installs all dependencies
necessary for building for Debian-based distributions and Fedora.
- 10:29 AM Changeset in webkit [144779] by
-
- 2 edits in trunk/Source/WebKit2
Follow up to https://bugs.webkit.org/show_bug.cgi?id=111453, forgot to mark the files as Private.
- WebKit2.xcodeproj/project.pbxproj:
- 10:28 AM Changeset in webkit [144778] by
-
- 4 edits in tags/Safari-537.31.14/Source
Versioning.
- 10:26 AM Changeset in webkit [144777] by
-
- 9 edits1 copy2 moves in trunk/Source/WebKit2
Elevate accessors of C-SPI API variants to Objective-C SPI
https://bugs.webkit.org/show_bug.cgi?id=111453
<rdar://problem/13340357>
Reviewed by Alexey Proskuryakov.
- Shared/mac/ObjCObjectGraphCoders.mm:
- UIProcess/API/mac/WKBrowsingContextControllerInternal.h:
- UIProcess/API/mac/WKBrowsingContextControllerPrivate.h:
- UIProcess/API/mac/WKBrowsingContextGroup.mm:
- UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Renamed from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupInternal.h.
- UIProcess/API/mac/WKProcessGroup.mm:
- UIProcess/API/mac/WKProcessGroupPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroupInternal.h.
- UIProcess/API/mac/WKView.mm:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
(-[WKWebProcessPlugInController _bundleRef]):
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInPrivate.h: Renamed from Source/WebKit2/UIProcess/API/mac/WKProcessGroupInternal.h.
Add access to C-SPI WebKit types as Objective-C SPI.
- 10:19 AM Changeset in webkit [144776] by
-
- 11 edits2 adds in trunk
[CSS Exclusions] shape-outside on floats for polygon shapes
https://bugs.webkit.org/show_bug.cgi?id=98676
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-03-05
Reviewed by David Hyatt.
Source/WebCore:
Implement support for polygonal shape-outside on floats. The basic
tack taken here is to keep using the bounding box of the shape to
position the float, but to compute the offset (caused by the shape)
from the bounding box for each line when creating and positioning
other inline content.
Test: fast/exclusions/shape-outside-floats/shape-outside-floats-simple-polygon.html
- rendering/ExclusionShapeInfo.cpp:
(WebCore):
(WebCore::::computedShape): Add new template parameter.
(WebCore::::logicalTopOffset): Add new template parameter.
(WebCore::::computeSegmentsForLine): Move here from
ExclusionShapeInsideInfo, since ExclusionShapeOutsideInfo needs it
as well. Make virtual since there is slightly different behavior
between each class even though the vast majority of the code is
common.
- rendering/ExclusionShapeInfo.h:
(WebCore):
(WebCore::ExclusionShapeInfo::~ExclusionShapeInfo): Since
computeSegmentsForLine is virtual, the destructor must be virtual
as well.
(ExclusionShapeInfo): Add new data members to support
computeSegmentsForLine.
(WebCore::ExclusionShapeInfo::shapeLogicalRight): Fix bug, the logical
right is based off of maxX, not y. (it's a logical bounding box!)
(WebCore::ExclusionShapeInfo::logicalLineTop): Moved from
ExclusionShapeInsideInfo for use by computeSegmentsForLine and
lineOverlapsShapeBounds.
(WebCore::ExclusionShapeInfo::logicalLineBottom): Moved from
ExclusionShapeInsideInfo for use by computeSegmentsForLine and
lineOverlapsShapeBounds.
(WebCore::ExclusionShapeInfo::lineOverlapsShapeBounds): Moved from
ExclusionShapeInsideInfo for use by computeSegmentsForLine.
- rendering/ExclusionShapeInsideInfo.cpp: Moved common code from
computeSegmentsForLine into ExclusionShapeInfo.
- rendering/ExclusionShapeInsideInfo.h:
(WebCore): Moved some methods to ExclusionShapeInfo.
(ExclusionShapeInsideInfo): Update for new template parameter.
(WebCore::ExclusionShapeInsideInfo::compyteSegmentsForLine): Override
superclass method to clear the segment ranges. Segement ranges
aren't used by shape outside, and have some complex dependencies
that make it very hard to try and move up into ExclusionShapeInfo.
(WebCore::ExclusionShapeInsideInfo::ExclusionShapeInsideInfo): Update
for new template parameter.
- rendering/ExclusionShapeOutsideInfo.cpp:
(WebCore::ExclusionShapeOutsideInfo::isEnabledFor): Add polygons as a
supported shape.
(WebCore::ExclusionShapeOutsideInfo::computeSegmentsForLine): Override
superclass method to not recompute if it isn't needed (this isn't
straightfoward for shape inside, which is why it isn't common),
and to save the left and right offsets caused by the shape
outside, since that's all that is needed to properly do layout in
the case of floats.
- rendering/ExclusionShapeOutsideInfo.h:
(WebCore::ExclusionShapeOutsideInfo::shapeLogicalOffset): Reformat to
be on a single line, like most other methods of it's type in
WebKit headers.
(ExclusionShapeOutsideInfo): Update for new template parameter.
(WebCore::ExclusionShapeOutsideInfo::logicalLeftOffsetForLine):
Accessor method to get the left offset between the shape and the
shape's bounding box.
(WebCore::ExclusionShapeOutsideInfo::logicalRightOffsetForLine):
Accessor method to get the left offset between the shape and the
shape's bounding box.
(WebCore::ExclusionShapeOutsideInfo::ExclusionShapeOutsideInfo):
Update for new template parameter.
- rendering/RenderBlock.cpp:
(WebCore::::collectIfNeeded): Save the last float encountered so that
the shape outside offset can be accounted for.
(WebCore::RenderBlock::logicalLeftOffsetForLine): Account for the
shape outside offset on the outermost float.
(WebCore::RenderBlock::logicalRightOffsetForLine): Account for the
shape outside offset on the outermost float.
- rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter):
Initialize the lastFloat member.
(WebCore::RenderBlock::FloatIntervalSearchAdapter::lastFloat): Get the
last float encountered.
(FloatIntervalSearchAdapter): Add a pointer to the last float
encountered. Note that the variable is mutable because
collectIfNeeded is declared as a const method even though it isn't
(it uses loopholes to update m_offset and m_heightRemaining).
Instead of trying to come up with a hack to stick with the
loopholes, I decided to be explicit about it.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Take
into account the offset from any polygonal shape outside.
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak): Add a FIXME
because the current code will not work properly with stacked
floats that have polygonal shape outside.
LayoutTests:
Simple test for floats with polygonal shape-outside.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-polygon-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-polygon.html: Added.
- 10:18 AM Changeset in webkit [144775] by
-
- 2 edits in trunk/Tools
Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
https://bugs.webkit.org/show_bug.cgi?id=111440
Reviewed by Adrienne Walker.
Remove unnecessary WebCompositorSupport::shutdown call
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
- 10:06 AM Changeset in webkit [144774] by
-
- 1 copy in tags/Safari-537.31.14
New Tag.
- 10:05 AM Changeset in webkit [144773] by
-
- 13 edits in trunk/Source/WebCore
[New Multicolumn] Autogenerate regions for columns.
https://bugs.webkit.org/show_bug.cgi?id=111363
Reviewed by Dean Jackson.
In CSS Regions, we lay out the regions first, and then
we put the flow thread into the regions. This model doesn't
really work for multicolumn layout, which needs to be able
to auto-generate new regions lazily in response to the flow
thread asking for regions at particular offsets.
With the multi-column model, where the regions can't just occur
anywhere, its ok not to lay them out before the flow thread, as
long as we have at least given them the correct size.
This patch changes the layout algorithm for columns to:
(1) Size any existing regions (without worrying about placement).
(2) Lay out the flow thread (generating and sizing regions lazily
that need to be created).
(3) Lay out the regions (to give them correct placement and to
compute overflow correctly for the multi-column block that contains
the regions).
There are no new tests, since there are no behavioral changes. This
is just groundwork for being able to add new sets in response to
spans, balancing, and nested pagination contexts.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::layoutBlockChild):
- rendering/RenderBlock.h:
(RenderBlock):
Since we want to be able to call determineLogicalLeftPositionForChild
to place the flow thread properly, and we don't want to apply a layout
delta (flow threads repaint themselves), we parameterize the method
here so that it can be called without applying a layout delta.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::addRegionToThread):
(WebCore::RenderFlowThread::removeRegionFromThread):
These methods are only used by RenderMultiColumnFlowThread, since
RenderNamedFlowThread overrides them. Remove the code that invalidates
the flow threads region set as regions come and go, since that is now
going to be expected with auto-generation.
(WebCore::RenderFlowThread::validateRegions):
Refactor the code in RenderFlowThread::layout that validates the regions
into its own method, so that we can re-validate regions at any time
after generating new ones.
(WebCore::RenderFlowThread::layout):
Changed to move the region validation code into its own function that is
now called from here.
(WebCore::RenderFlowThread::updateLogicalWidth):
Don't assert if a region set needs layout.
(WebCore::RenderFlowThread::computeLogicalHeight):
Ditto. Don't assert if a region set needs layout. That's expected now.
(WebCore::RenderFlowThread::regionAtBlockOffset):
Add code to regionAtBlockOffset to auto-generate regions up to
the offset. This ensures the region that is being asked for
exists.
(WebCore::RenderFlowThread::pageLogicalTopForOffset):
(WebCore::RenderFlowThread::pageLogicalWidthForOffset):
(WebCore::RenderFlowThread::pageLogicalHeightForOffset):
(WebCore::RenderFlowThread::pageRemainingLogicalHeightForOffset):
These functions are no longer const, since the act of asking for
pagination offsets can cause us to generate new regions.
(WebCore::RenderFlowThread::mapFromFlowToRegion):
Modified to turn auto-generation off, since this is not really
a "layout-time" function.
(WebCore::RenderFlowThread::logicalWidthChangedInRegions):
Modified to not assert if a region set needs layout, since that is
expected now.
- rendering/RenderFlowThread.h:
Changes to remove const from the methods that can trigger region
auto-generation.
- rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::styleDidChange):
Make sure to propagate style changes down into the regions. I don't know
of any correctness bugs around this, but I figured I'd be thorough.
(WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):
We no longer build a column set aggressively. We wait for the flow thread
to ask us for a region at a particular offset, and only then do we
build the set.
(WebCore::RenderMultiColumnBlock::addChild):
Now that we lay out the flow thread as a special excluded child, we don't
care about the ordering of it relative to the region children.
(WebCore::RenderMultiColumnBlock::layoutSpecialExcludedChild):
We now lay out the flow thread as a special excluded child (like the legend
of a fieldset).
- rendering/RenderMultiColumnBlock.h:
(RenderMultiColumnBlock):
Add new overrides like layoutSpecialExcludedChild.
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::initialLogicalWidth):
Set the flow thread to the initial column width even when no regions exist
yet. This way we ensure the width is right even when we don't have any
regions yet.
(WebCore::RenderMultiColumnFlowThread::autoGenerateRegionsToBlockOffset):
This method handles autogenerating the new region for a given offset.
Right now it's simplistic, since we only have one column set. This method
will be enhanced in future patches when we start supporting multiple column
sets.
- rendering/RenderMultiColumnFlowThread.h:
(RenderMultiColumnFlowThread):
Adding new method declarations like autoGenerateRegionsToBlockOffset.
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::updateLogicalWidth):
Since regions lay out after flow threads, we don't need to make
setFlowThreadPortionRect virtual any longer. We can just get our column set's
width correct immediately. This is the same logic, just moved into updateLogicalWidth().
- rendering/RenderMultiColumnSet.h:
Remove setFlowThreadPortionRect override, since the function can just be simple
and non-virtual in RenderRegion now.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::layoutBlock):
Don't ever invalidate region sets in response to our size changing during layout. Since
our size is always determined outside of layout now, we don't need to do any of
these checks.
- rendering/RenderRegion.h:
(WebCore::RenderRegion::setFlowThreadPortionRect):
Changed to be non-virtual now that RenderMultiColumnSet doesn't need to override.
- 10:05 AM Changeset in webkit [144772] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Authentication credentials lost when opening a new tab
https://bugs.webkit.org/show_bug.cgi?id=111445
PR 286627
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-03-05
Reviewed by Rob Buis.
Internally Reviewed by Lianghui Chen.
Prevent changing the private mode boolean value in didChangeSettings if the value
hasn't changed.
Setting the private mode value of credentialstorage every time didChangeSettings gets
called causes the session credential mapping to be cleared on every tab change in
non-private mode.
Tested changing tabs after logging into a site using the HTTP Basic Auth protocol to see
if the credentials are cleared. Also ensured the functionality of private mode is not changed.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- 9:54 AM Changeset in webkit [144771] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] FatFinger pairs the wrong element with fatfinger rect part.
https://bugs.webkit.org/show_bug.cgi?id=111444
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-03-05
Reviewed by Rob Buis.
Internal PR 266214
Internally reviewed by Genevieve Mak.
Instead of subtracting with the element region, we should get the remaining
rect by find the intersect region of element region and fatfinger detection
region.
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::checkForClickableElement):
- 9:42 AM Changeset in webkit [144770] by
-
- 18 edits1 add in trunk/Source
Make AsyncFileReader work without ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=111376
Reviewed by Anders Carlsson.
- WebCore.xcodeproj/project.pbxproj: Added MainThreadTask.h.
- dom/ScriptExecutionContext.cpp:
- dom/ScriptExecutionContext.h: Removed fileThread(). Creating a thread for every context that acesses files appears wasteful and unnecessary.
- fileapi/AsyncFileStream.h:
- fileapi/AsyncFileStream.cpp: (WebCore::createFileThread): FileThread is now a singleton. (WebCore::fileThread): Ditto. (WebCore::AsyncFileStream::AsyncFileStream): (WebCore::AsyncFileStream::create): (WebCore::didStart): (WebCore::AsyncFileStream::startOnFileThread): (WebCore::AsyncFileStream::stop): (WebCore::derefProxyOnMainThread): (WebCore::AsyncFileStream::stopOnFileThread): (WebCore::didGetSize): (WebCore::AsyncFileStream::getSizeOnFileThread): (WebCore::didOpen): (WebCore::AsyncFileStream::openForReadOnFileThread): (WebCore::AsyncFileStream::openForWriteOnFileThread): (WebCore::didRead): (WebCore::AsyncFileStream::readOnFileThread): (WebCore::didWrite): (WebCore::AsyncFileStream::writeOnFileThread): (WebCore::didTruncate): (WebCore::AsyncFileStream::truncateOnFileThread): Use callOnMainThread() instead of posting messages through a context. We never used other threads, and don't plan to.
- loader/ResourceLoader.cpp:
- loader/ResourceLoader.h: We no longer need this pseudo-client call to create an AsyncFileStream, now that we don't need to get a ScriptExecutionContext somewhere.
- platform/MainThreadTask.h: Added. This implements callOnMainThread with multiple strongly typed arguments. Closely based on CrossThreadTask.h.
- platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::BlobResourceHandle): Create AsyncFileStream directly.
- platform/network/ResourceHandleClient.h: Removed createAsyncFileStream().
- 9:35 AM Changeset in webkit [144769] by
-
- 2 edits in trunk/Source/WebCore
Update the localizable strings file.
Rubber-stamped by Anders Carlsson.
- English.lproj/Localizable.strings:
- 9:32 AM Changeset in webkit [144768] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13345116> REGRESSION: Child processes get access to user cache
and temporary directories instead of private ones
Reviewed by Sam Weinig.
- Shared/mac/ChildProcessMac.mm: (WebKit::ChildProcess::initializeSandbox): Restore the correct order of calls, so sandbox parameters respect WebKit pseudo containers.
- 9:26 AM Changeset in webkit [144767] by
-
- 14 edits1 delete in trunk/Source/JavaScriptCore
Unreviewed, rolling out r144708.
http://trac.webkit.org/changeset/144708
https://bugs.webkit.org/show_bug.cgi?id=111447
random assertion crashes in inspector tests on qt+mac bots
(Requested by kling on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-05
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
(JSGlobalData):
- runtime/PropertyMapHashTable.h:
(PropertyTable):
(JSC::PropertyTable::PropertyTable):
(JSC):
(JSC::PropertyTable::~PropertyTable):
(JSC::PropertyTable::copy):
- runtime/PropertyTable.cpp: Removed.
- runtime/Structure.cpp:
(JSC::Structure::dumpStatistics):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::sealTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::isSealed):
(JSC::Structure::isFrozen):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::pin):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::despecifyAllFunctions):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):
(JSC::Structure::createPropertyMap):
(JSC::Structure::getPropertyNamesFromStructure):
(JSC::Structure::visitChildren):
(JSC::Structure::checkConsistency):
- runtime/Structure.h:
(JSC):
(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):
(JSC::Structure::checkOffsetConsistency):
(Structure):
- runtime/StructureInlines.h:
(JSC::Structure::get):
- runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::get):
- 9:24 AM Changeset in webkit [144766] by
-
- 4 edits2 adds in trunk
AX: aria-label does not override text content on iOS
https://bugs.webkit.org/show_bug.cgi?id=111222
Reviewed by David Kilzer.
Source/WebCore:
Make iOS use the same text alternative computation that Mac is using. The main difference
is that description and title need to be concatenated, because iOS doesn't have two attributes
to return those values.
Test: platform/iphone-simulator/accessibility/aria-label-with-internal-text.html
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper stringValueShouldBeUsedInLabel]):
(-[WebAccessibilityObjectWrapper accessibilityLabel]):
(-[WebAccessibilityObjectWrapper accessibilityHint]):
- accessibility/mac/WebAccessibilityObjectWrapperBase.h:
LayoutTests:
- platform/iphone-simulator/accessibility/aria-label-with-internal-text-expected.txt: Added.
- platform/iphone-simulator/accessibility/aria-label-with-internal-text.html: Added.
- 9:08 AM Changeset in webkit [144765] by
-
- 4 edits in trunk
Unreviewed build fix.
.:
- GNUmakefile.am: remove bad path for generate-feature-defines-files from EXTRA_DIST.
Tools:
- GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
- 8:58 AM Changeset in webkit [144764] by
-
- 8 edits in trunk/Source
BUILD FIX (r144698): Only enable SPEECH_SYNTHESIS for Mac
<http://webkit.org/b/106742>
Fixes the following build failures:
Undefined symbols for architecture i386:
"ZTVN7WebCore25PlatformSpeechSynthesizerE", referenced from:
ZN7WebCore25PlatformSpeechSynthesizerC2EPNS_31PlatformSpeechSynthesizerClientE in PlatformSpeechSynthesizer.o
NOTE: a missing vtable usually means the first non-inline virtual member function has no definition.
"ZN7WebCore25PlatformSpeechSynthesizer19initializeVoiceListEv", referenced from:
ZN7WebCore25PlatformSpeechSynthesizerC2EPNS_31PlatformSpeechSynthesizerClientE in PlatformSpeechSynthesizer.o
ld: symbol(s) not found for architecture i386
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
- Fix definition of ENABLE_ENCRYPTED_MEDIA_V2_macosx to match other FeatureDefines.xcconfig files.
- Only set ENABLE_SPEECH_SYNTHESIS for the macosx platform.
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- Only set ENABLE_SPEECH_SYNTHESIS for the macosx platform.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
- Only set ENABLE_SPEECH_SYNTHESIS for the macosx platform.
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- Only set ENABLE_SPEECH_SYNTHESIS for the macosx platform.
- 8:58 AM Changeset in webkit [144763] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: registered new MIME type application/font-woff for WOFF fonts.
https://bugs.webkit.org/show_bug.cgi?id=111418
The WOFF MIME Type was formally registered as application/font-woff (FINALLY):
http://www.iana.org/assignments/media-types/application/font-woff
Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-05
Reviewed by Pavel Feldman.
- inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager):
(WebInspector.NetworkDispatcher.prototype._updateNetworkRequestWithResponse):
- 8:27 AM Changeset in webkit [144762] by
-
- 10 edits2 adds in trunk
[CSS Grid Layout] Add parsing for grid-{end|after}
https://bugs.webkit.org/show_bug.cgi?id=111372
Reviewed by Tony Chang.
Source/WebCore:
Test: fast/css-grid-layout/grid-item-end-after-get-set.html
This change adds the proper support for grid-{end|after}. It doesn't update
grid-{row|column} to be a shorthand for both grid-{before|start} and grid-{after|end}
though.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Added the new properties to our known properties. Also added
support for getComputedStyle.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
Added parsing for the new properties.
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
The new properties are not inherited.
- css/CSSPropertyNames.in:
Added the new properties.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Added code to handle applying them to our style.
- rendering/style/RenderStyle.h:
- rendering/style/StyleGridItemData.cpp:
(WebCore::StyleGridItemData::StyleGridItemData):
- rendering/style/StyleGridItemData.h:
(WebCore::StyleGridItemData::operator==):
(StyleGridItemData):
Updated our representation to store the new properties.
LayoutTests:
- fast/css-grid-layout/grid-item-end-after-get-set-expected.txt: Added.
- fast/css-grid-layout/grid-item-end-after-get-set.html: Added.
Note that some of the test fails as we don't treat grid-{row|column} as a shorthand.
- 8:06 AM Changeset in webkit [144761] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed follow-up to r144756, fix broken inspector-less build.
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willWriteHTML):
- 7:54 AM Changeset in webkit [144760] by
-
- 21 edits2 adds in trunk
Improve robustness of WebSQL quota management.
https://bugs.webkit.org/show_bug.cgi?id=110600.
Reviewed by Geoffrey Garen.
Source/WebCore:
- Introduced the OriginLock for synchronizing write access to the database origin directory. This allows us to more accurately compute the disk usage.
The OriginLock uses a mutex to provide mutual exclusion between
threads and a file lock for mutual exclusion between processes.
The file lock part is conditional on USE(FILE_LOCK).
The mutex mutual exclusion also serves to ensure that only 1 thread
can write to a sqlite database at one time.
- Change the SQLTransactionCoordinator to only allow one write transaction to an origin instead of one write transaction per database. This is needed in order to accurately compute the disk usage. It is also necessary so that the OriginLock does not deadlock itself (as would be the case if concurrent write transactions to different databases in the same origin are allowed).
- Fix DatabaseTracker::getMaxSizeForDatabase() to check for when disk usage may exceed the quota, and ensure that we will return an appropriate max database size.
Disk usage can exceed the usage if it is already near the quota limit
but have not exceeded it yet. If a new database is opened in that
origin, it may bump the usage above the quota, but should not
continually repeat this. Subsequent attempts to open a database
will find that the quota is already exhausted and fail.
There is still a race condition pertaining to the tracker database
getting out of sync that may still enable runaway growth in the
database sizes. That issue only manifest in a multi-process
environment, and will be fixed in another changeset.
- Fixed a bug in SQLStatement to check if the errorCallback exists before invoking it.
No new layout tests. A quota-test.html was attached to bugzilla for manual
testing of multi-tab concurrent consumption of storage resource, and also
to test handling situations when the user deletes the database files while
the script is still using the database.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::originLockFor):
(WebCore::DatabaseTracker::deleteOriginLockFor):
(WebCore::DatabaseTracker::deleteOrigin):
- Modules/webdatabase/DatabaseTracker.h:
- Modules/webdatabase/OriginLock.cpp: Added.
(WebCore::OriginLock::lockFileNameForPath):
(WebCore::OriginLock::OriginLock):
(WebCore::OriginLock::~OriginLock):
(WebCore::OriginLock::lock):
(WebCore::OriginLock::unlock):
- Modules/webdatabase/OriginLock.h: Added.
- Modules/webdatabase/SQLStatement.cpp:
(WebCore::SQLStatement::performCallback):
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::doCleanup):
(WebCore::SQLTransactionBackend::computeNextStateAndCleanupIfNeeded):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):
(WebCore::SQLTransactionBackend::postflightAndCommit):
(WebCore::SQLTransactionBackend::cleanupAfterTransactionErrorCallback):
(WebCore::SQLTransactionBackend::acquireOriginLock):
(WebCore::SQLTransactionBackend::releaseOriginLockIfNeeded):
- Modules/webdatabase/SQLTransactionBackend.h:
(SQLTransactionBackend):
- Modules/webdatabase/SQLTransactionCoordinator.cpp:
(WebCore::getDatabaseIdentifier):
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- config.h:
- platform/FileSystem.h:
- platform/posix/FileSystemPOSIX.cpp:
(WebCore::lockFile):
(WebCore::unlockFile):
LayoutTests:
- storage/websql/multiple-databases-garbage-collection.js:
- This test runs 2 transactions on 2 databases (1 each). The 2 databases are named "persistent" and "forgotten". The test executes the transaction on "persistent" first, but expects the transaction on "forgotten" to finish first. This is because "forgotten"'s transaction is a smaller one. The new changes to SQLTransactionCoordinator now ensures that a write transaction must completes before another is started for databases in the same origin. Hence, the previously expected result will no longer be true.
Regardless, the purpose of the test is not to test the order of
completion but that resources are reclaimed. So, I'm changing the test
to start the "forgotten" transaction first followed by the "persistent"
transaction. This ensures that the test will yield consistent results
even when run on ports that may allow more than one write transaction
to run at the same time.
- 7:29 AM Changeset in webkit [144759] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: move PopoverContentHelper from TimelinePresentationModel.js to Popover.js.
https://bugs.webkit.org/show_bug.cgi?id=111431
Reviewed by Yury Semikhatsky.
class WebInspector.TimelinePresentationModel.PopoverContentHelper was renamed to WebInspector.PopoverContentHelper.
Style names were changed accordingly.
- inspector/front-end/Popover.js:
(WebInspector.PopoverContentHelper):
(WebInspector.PopoverContentHelper.prototype.contentTable):
(WebInspector.PopoverContentHelper.prototype._createCell):
(WebInspector.PopoverContentHelper.prototype.appendTextRow):
(WebInspector.PopoverContentHelper.prototype.appendElementRow):
(WebInspector.PopoverContentHelper.prototype.appendStackTrace):
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.generateMainThreadBarPopupContent):
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
(WebInspector.TimelinePresentationModel.generatePopupContentForFrame):
(WebInspector.TimelinePresentationModel.generatePopupContentForFrameStatistics):
- inspector/front-end/popover.css:
(.popover-details):
(.popover-function-name):
(.popover-stacktrace-title):
(.popover-details-row-title):
(.popover-details-row-data):
(.popover-details-title):
- inspector/front-end/timelinePanel.css:
- 7:00 AM Changeset in webkit [144758] by
-
- 3 edits in trunk/Tools
[Qt][MiniBrowser] Improve the update of touch indicators
https://bugs.webkit.org/show_bug.cgi?id=111429
Reviewed by Jocelyn Turcotte.
MiniBrowserApplication::sendTouchEvent sends an empty list
to BrowserWindow::updateVisualMockTouchPoints if the control
button is released, in which case the touch indicators should
be hidden so that we never end up with a leftover indicator
sticking on the screen.
This patch also simplifies the lookup of the indicator items by
replacing the findChild search in the item tree with a QHash
that stores the touch ID's and the pointers to the corresponding
indicator items.
- MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
- MiniBrowser/qt/BrowserWindow.h:
(BrowserWindow):
- 6:54 AM Changeset in webkit [144757] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: remove "Live native memory chart" experiment
https://bugs.webkit.org/show_bug.cgi?id=111432
Reviewed by Alexander Pavlov.
Removed support for live native memory chart.
- English.lproj/localizedStrings.js:
- inspector/front-end/NativeMemorySnapshotView.js:
- inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/nativeMemoryProfiler.css:
- 6:09 AM Changeset in webkit [144756] by
-
- 10 edits in trunk
Web Inspector: remove length parameter from Parse HTML timeline event
https://bugs.webkit.org/show_bug.cgi?id=111421
Reviewed by Yury Semikhatsky.
Source/WebCore:
- remove length parameter in all instrumentation methods used to emit ParseHTML timeline event;
- drive-by style fixes.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore::HTMLDocumentParser::pumpTokenizer):
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willWriteHTMLImpl):
(WebCore::InspectorInstrumentation::didWriteHTMLImpl):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willWriteHTML):
(WebCore::InspectorInstrumentation::didWriteHTML):
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willWriteHTML):
(WebCore::InspectorTimelineAgent::didWriteHTML):
- inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
- inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createParseHTMLData):
- inspector/TimelineRecordFactory.h:
(TimelineRecordFactory):
LayoutTests:
- removed length field from ParseHTML data in expectations.
- inspector/timeline/timeline-parse-html-expected.txt:
- 6:06 AM Changeset in webkit [144755] by
-
- 2 edits in trunk/Source/WebKit/chromium
Web Inspector: Add a renderer process memory size test.
https://bugs.webkit.org/show_bug.cgi?id=111337
Patch by Alexei Filippov <alph@chromium.org> on 2013-03-05
Reviewed by Yury Semikhatsky.
The test checks that the renderer process memory size
is obtained from the browser and reported to the inspector
frontend correctly.
- src/js/Tests.js:
(.TestSuite.prototype.testRendererProcessNativeMemorySize.checkFuzzyValue):
(.TestSuite.prototype.testRendererProcessNativeMemorySize.step2):
- 5:58 AM Changeset in webkit [144754] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: allow each profiler panel to have own landing page
https://bugs.webkit.org/show_bug.cgi?id=111298
Patch by Alexei Filippov <alph@chromium.org> on 2013-03-05
Reviewed by Yury Semikhatsky.
Refactor profiler landing page to allow different profiler panels to have own landing pages.
- MultiProfileLauncherView is inherited from ProfileLauncherView
- Native memory distribution profiler has got a custom page.
No new tests: code refactoring.
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype.get profile):
(WebInspector.HeapSnapshotView.prototype.get baseProfile):
(WebInspector.HeapSnapshotView.prototype._profiles):
- inspector/front-end/NativeMemorySnapshotView.js:
- inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView):
(WebInspector.ProfileLauncherView.prototype.addProfileType):
(WebInspector.ProfileLauncherView.prototype._controlButtonClicked):
(WebInspector.ProfileLauncherView.prototype._updateControls):
(WebInspector.ProfileLauncherView.prototype.profileStarted):
(WebInspector.ProfileLauncherView.prototype.profileFinished):
(WebInspector.MultiProfileLauncherView):
(WebInspector.MultiProfileLauncherView.prototype.addProfileType):
(WebInspector.MultiProfileLauncherView.prototype._profileTypeChanged):
(WebInspector.NativeProfileLauncherView):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._createLauncherView):
(WebInspector.CPUProfilerPanel):
(WebInspector.CSSSelectorProfilerPanel):
(WebInspector.HeapProfilerPanel):
(WebInspector.CanvasProfilerPanel):
(WebInspector.MemoryChartProfilerPanel):
(WebInspector.MemoryChartProfilerPanel.prototype._createLauncherView):
(WebInspector.NativeMemoryProfilerPanel):
- inspector/front-end/profilesPanel.css:
(.panel-enabler-view.profile-launcher-view button:not(.status-bar-item)):
- 5:33 AM Changeset in webkit [144753] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Clarify some StylesSidebarPanel and CSSMetadata JSDocs.
https://bugs.webkit.org/show_bug.cgi?id=111427
Reviewed by Alexander Pavlov.
Goal: reflect in JSDoc that non-null array is passed to completionsReady callback.
- inspector/front-end/CSSMetadata.js:
Added JSDocs, avoided possible NPEs.
- inspector/front-end/StylesSidebarPane.js:
Fixed JSDocs, removed unused assignment.
- 5:29 AM Changeset in webkit [144752] by
-
- 21 edits in trunk
[WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled
https://bugs.webkit.org/show_bug.cgi?id=81042
Reviewed by Enrica Casucci.
Source/WebKit2:
Expose WK2 setting to enable/disabled asynchronous spell checking.
It's used by WebKitTestRunner to reset the setting at the beginning
of the test.
WebKit2 ports might be interested in this setting if they are going
to enable this feature.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetAsynchronousSpellCheckingEnabled):
(WKPreferencesGetAsynchronousSpellCheckingEnabled):
- UIProcess/API/C/WKPreferences.h:
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetAsynchronousSpellCheckingEnabled):
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setAsynchronousSpellCheckingEnabled):
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
Add setAsynchronousSpellCheckingEnabled implementation for
WebKitTestRunner to have the possibility to test asynchronous
spell checking implementation from bug 109577.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setAsynchronousSpellCheckingEnabled):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
LayoutTests:
Gardening of the asynchronous spell checking tests.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
Some tests need to be skipped as they require features not
implemented for EFL yet (pasteboard, grammar checking, text replacement).
- platform/gtk-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/qt-5.0-wk2/TestExpectations:
Skip asynchronous spell checking for GTK+, Mac, Qt unless
they implement TextChecker::requestCheckingOfText.
- platform/wk2/TestExpectations:
Remove asynchronous spell checking tests from global wk2's
as they are passing for EFL.
- 5:29 AM Changeset in webkit [144751] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX (r144727): Change type of columnRange and rowRange to pair<unsigned, unsigned>
<http://webkit.org/b/110050>
Fixes the following build failures:
Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:741:30: error: non-const lvalue reference to type 'pair<unsigned int, unsigned int>' cannot bind to a value of unrelated type 'pair<int, int>'
tableCell->rowIndexRange(rowRange);
~
In file included from Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:33:
Source/WebCore/accessibility/AccessibilityTableCell.h:47:58: note: passing argument to parameter 'rowRange' here
virtual void rowIndexRange(pair<unsigned, unsigned>& rowRange);
Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:742:33: error: non-const lvalue reference to type 'pair<unsigned int, unsigned int>' cannot bind to a value of unrelated type 'pair<int, int>'
tableCell->columnIndexRange(columnRange);
In file included from Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:33:
Source/WebCore/accessibility/AccessibilityTableCell.h:49:61: note: passing argument to parameter 'columnRange' here
virtual void columnIndexRange(pair<unsigned, unsigned>& columnRange);
Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:804:30: error: non-const lvalue reference to type 'pair<unsigned int, unsigned int>' cannot bind to a value of unrelated type 'pair<int, int>'
tableCell->rowIndexRange(rowRange);
~
In file included from Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:33:
Source/WebCore/accessibility/AccessibilityTableCell.h:47:58: note: passing argument to parameter 'rowRange' here
virtual void rowIndexRange(pair<unsigned, unsigned>& rowRange);
Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:818:33: error: non-const lvalue reference to type 'pair<unsigned int, unsigned int>' cannot bind to a value of unrelated type 'pair<int, int>'
tableCell->columnIndexRange(columnRange);
In file included from Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:33:
Source/WebCore/accessibility/AccessibilityTableCell.h:49:61: note: passing argument to parameter 'columnRange' here
virtual void columnIndexRange(pair<unsigned, unsigned>& columnRange);
4 errors generated.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityHeaderElements]):
(-[WebAccessibilityObjectWrapper accessibilityRowRange]):
(-[WebAccessibilityObjectWrapper accessibilityColumnRange]):
- 5:00 AM FeatureFlags edited by
- FONT_LOAD_EVENTS (diff)
- 4:53 AM Changeset in webkit [144750] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Clean up animated scroll/zoom code in WebPagePrivate
https://bugs.webkit.org/show_bug.cgi?id=111373
Patch by Andrew Lo <anlo@rim.com> on 2013-03-05
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.
Internal PR 285468.
Have WebPageClient pass the final scale and position to WebPage when a zoom/scroll
animation finishes, rather than keeping those values as instance variables in
WebPagePrivate.
Rename some functions & variables to reflect that they are used for both block zoom
and generic zoom/scroll animations.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
(BlackBerry::WebKit::WebPage::zoomAnimationFinished):
(BlackBerry::WebKit::WebPagePrivate::resetBlockZoom):
(BlackBerry::WebKit::WebPage::blockZoom):
(BlackBerry::WebKit::WebPagePrivate::animateToScaleAndDocumentScrollPosition):
- Api/WebPage.h:
- Api/WebPageClient.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- 4:23 AM Changeset in webkit [144749] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [refactoring] set frame identifiers in timeline records early, do not keep them in event stack
https://bugs.webkit.org/show_bug.cgi?id=111345
Reviewed by Pavel Feldman.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::pushGCEventRecords):
(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::setFrameIdentifier):
(WebCore):
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
(WebCore::InspectorTimelineAgent::commitFrameRecord):
- inspector/InspectorTimelineAgent.h:
(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
(TimelineRecordEntry):
(InspectorTimelineAgent):
- 4:17 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:34 AM Changeset in webkit [144748] by
-
- 16 edits in trunk
MediaStream API: Add the getStreamById method on RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=111311
Reviewed by Adam Barth.
Source/Platform:
Added an initial initialize method which doesn't take an id;
the id will be generated for you.
- chromium/public/WebMediaStream.h:
(WebMediaStream):
Source/WebCore:
Adding the missing method on RTCPeerConnection defined here:
http://dev.w3.org/2011/webrtc/editor/webrtc.html#widl-RTCPeerConnection-getStreamById-MediaStream-DOMString-streamId
Existing tests have been extended to cover patch.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::getStreamById):
(WebCore):
- Modules/mediastream/RTCPeerConnection.h:
(RTCPeerConnection):
- Modules/mediastream/RTCPeerConnection.idl:
- platform/chromium/support/WebMediaStream.cpp:
(WebKit::WebMediaStream::initialize):
(WebKit):
- platform/mediastream/MediaStreamSource.cpp:
(WebCore::MediaStreamSource::setReadyState):
Tools:
Changing mocks to be more realistic.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
(WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
(WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
- DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
(WebTestRunner::WebUserMediaClientMock::requestUserMedia):
LayoutTests:
- fast/mediastream/MediaStream-add-remove-tracks.html:
- fast/mediastream/RTCPeerConnection-AddRemoveStream-expected.txt:
- fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
- 3:31 AM Changeset in webkit [144747] by
-
- 5 edits3 adds in trunk
Web Inspector: allow retrieval of composited layers in a given DOM subtree
https://bugs.webkit.org/show_bug.cgi?id=111312
Source/WebCore:
Introduce the LayerTreeAgent.layersForNode(node) method allowing the front-end
to gather all composited layers associated with nodes in the subtree of which
the provided node is the root.
In order to gather the layers in the subtree, we first traverse the node's
renderer's RenderObject hierarchy and whenever we encounter a RenderObject
that has a RenderLayer, we then traverse that renderLayer's RenderLayer
hierarchy. This allows for a quick path through the relevant objects we're
gathering.
Layers gathered will push the node to which they're associated, allowing a
nodeId for this layer to be listed in the Layer object sent to the front-end.
It is crucial to be able to provide a nodeId as well as a layerId for a Layer
object in order to be able to correctly assess mutations in the layer tree.
For instance, it is expected that a node's layer be replaced by a new layer
to represent a slightly different rendering of its content, but the front-end
should be able to represent this layer as an object for which only certain
attributes have changed (like the "paintCount" property).
Layer objects also indicate whether they're associated to a node hosted in a
shadow tree (the optional "isInShadowTree" property) in order for the front-end
to be able to only show this layer if the option to show nodes hosted in shadow
tree is enabled.
Finally, since we're only gathering composited layers, we're removing the
"isLayerComposited" property and removing the optional flag on the "paintCount",
"memory" and "compositedBounds" properties.
Reviewed by Simon Fraser.
Test: inspector-protocol/layers/layers-for-node.html
- inspector/Inspector.json:
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::layersForNode):
(WebCore):
(WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderObjectHierarchy):
(WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderLayerHierarchy):
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
(WebCore::InspectorLayerTreeAgent::idForNode):
- inspector/InspectorLayerTreeAgent.h:
(InspectorLayerTreeAgent):
LayoutTests:
New test for the LayerTree.layersForNode() method.
Reviewed by Simon Fraser.
- inspector-protocol/layers/layers-for-node-expected.txt: Added.
- inspector-protocol/layers/layers-for-node.html: Added.
- 2:53 AM Changeset in webkit [144746] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: use timestamps consistent with rest of Timeline in WebSocket events.
https://bugs.webkit.org/show_bug.cgi?id=111344
- create web socket related records in a manner consistent with the rest of timeline.
Reviewed by Pavel Feldman.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didCreateWebSocket):
(WebCore::InspectorTimelineAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorTimelineAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorTimelineAgent::didDestroyWebSocket):
- inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
- 2:38 AM Changeset in webkit [144745] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][EFL] Add requestCheckingOfString implementation.
https://bugs.webkit.org/show_bug.cgi?id=108172
Reviewed by Hajime Morrita.
Provide implementation of 'requestCheckingOfString' for WK2-EFL.
It uses the unified text checker feature.
- UIProcess/efl/TextCheckerEfl.cpp:
(WebKit::TextChecker::requestCheckingOfString):
- 2:27 AM Changeset in webkit [144744] by
-
- 6 edits2 adds in trunk
[CSS Regions] Crash when MathML used in CSS Regions
https://bugs.webkit.org/show_bug.cgi?id=110686
Reviewed by David Hyatt.
Source/WebCore:
The MathML blocks trigger a children layout when computing the preferred widths. This happens to determine the preferred
logical heights of the children. When the layout reaches the line boxes computation the preferred width of the containing block
is requested. Because it wasn't computed, the layout of the children is started again to determine the preferred logical heights.
This causes an infinite recursion and triggers a stack overflow.
The patch introduces a new RAII utility class that disables fragmentation when the constructor is called and restores it
on the destructor. This class is used when computing the preferred height for the children of a MathML block.
Test: fast/regions/mathml-crash.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::setFlowThreadStateIncludingDescendants): Do not cross RenderFlowThread boundaries when updating the flow thread
state flag. The innermost flow threads need to manage their descendants flag values.
- rendering/RenderView.cpp:
(WebCore::FragmentationDisabler::FragmentationDisabler):
(WebCore):
(WebCore::FragmentationDisabler::~FragmentationDisabler):
- rendering/RenderView.h:
(FragmentationDisabler):
(WebCore):
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::computeChildrenPreferredLogicalHeights):
LayoutTests:
Add a test to verify regions and MathML do not crash.
- fast/regions/mathml-crash-expected.txt: Added.
- fast/regions/mathml-crash.html: Added.
- 2:05 AM Changeset in webkit [144743] by
-
- 10 edits2 adds in trunk/Source/WebCore
Cleanup: Move HitTestLocation and HitTestResult into separate files.
https://bugs.webkit.org/show_bug.cgi?id=111294
Reviewed by Allan Sandfeld Jensen.
HitTestLocation and HitTestResult currently both live in
HitTestResult.h. That makes things more difficult to understand than
they should be, and violates the one-class-one-file principle that
WebKit generally follows. Happily, it's fairly trivial to fix.
This should have no visible change; it's strictly an internal
refactoring. It doesn't even touch any implementation code: we're
just moving bits from one place to another.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Hey, look: a new file! Let's add it to six different build systems! :)
- rendering/HitTestLocation.cpp: Added.
(WebCore):
(WebCore::HitTestLocation::HitTestLocation):
(WebCore::HitTestLocation::~HitTestLocation):
(WebCore::HitTestLocation::operator=):
(WebCore::HitTestLocation::move):
(WebCore::HitTestLocation::intersectsRect):
(WebCore::HitTestLocation::intersects):
(WebCore::HitTestLocation::rectForPoint):
- rendering/HitTestLocation.h: Added.
(WebCore):
(HitTestLocation):
(WebCore::HitTestLocation::point):
(WebCore::HitTestLocation::roundedPoint):
(WebCore::HitTestLocation::region):
(WebCore::HitTestLocation::isRectBasedTest):
(WebCore::HitTestLocation::isRectilinear):
(WebCore::HitTestLocation::boundingBox):
(WebCore::HitTestLocation::topPadding):
(WebCore::HitTestLocation::rightPadding):
(WebCore::HitTestLocation::bottomPadding):
(WebCore::HitTestLocation::leftPadding):
(WebCore::HitTestLocation::transformedPoint):
(WebCore::HitTestLocation::transformedRect):
- rendering/HitTestResult.cpp:
- rendering/HitTestResult.h:
Move all this code from HitTestResult.* to HitTestLocation.*.
- rendering/RenderBlock.cpp:
Include HitTestLocation.h.
- 1:30 AM Changeset in webkit [144742] by
-
- 5 edits in trunk/Source/WebCore
Refactor UserGestureIndicator::Token to be a top-level class
https://bugs.webkit.org/show_bug.cgi?id=111412
Reviewed by Nico Weber.
This will allow for forward declaring the class in a public WebKit
API header. The goal is to enable the embedder to hold on to a
UserGestureToken.
- dom/UserGestureIndicator.cpp:
(WebCore::UserGestureIndicator::UserGestureIndicator):
(WebCore::UserGestureIndicator::currentToken):
- dom/UserGestureIndicator.h:
(UserGestureToken):
(WebCore::UserGestureToken::~UserGestureToken):
(WebCore):
(UserGestureIndicator):
- page/DOMTimer.h:
(DOMTimer):
- page/EventHandler.h:
- 1:15 AM Changeset in webkit [144741] by
-
- 2 edits in trunk/Source/WebCore
Remove redundant code in Document::updateHoverActiveState.
https://bugs.webkit.org/show_bug.cgi?id=111303
Reviewed by Darin Adler.
Document::updateHoverActiveState currently looks for touchrelease events
and explictly clears out the hover state for all nodes between the
currently hovered node and the top of the hover chain. This is actually
redundant with the logic in the rest of the function; we can simplify by
setting the Element* we're working with to 0, which causes the later
loops to do the necessary work.
There should be no web-visible effect from this change; it should simply
make this function less complex.
Extracted from Allan Sandfeld Jensen's original patch to wkbug.com/98168
- dom/Document.cpp:
(WebCore::Document::updateHoverActiveState):
Set innerElementInDocument to 0 rather than walking the hover chain
and clearing it when we see a touchrelease event. The rest of the
code in this function will have the same effect.
- 1:03 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:02 AM Changeset in webkit [144740] by
-
- 8 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r144652 - [GTK] Some WebKit2 GTK+ unit tests are failing in 32 bits bot
https://bugs.webkit.org/show_bug.cgi?id=111346
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-04
Reviewed by Martin Robinson.
The problem is the use of a temporary CString object in the macro
g_assert_cmpstr. It's a common mistake because we usually forget
that g_assert_cmpstr is not a function but a macro, that expands
to multiple lines. This patch adds a new macro ASSERT_CMP_CSTRING
with the same implementation that g_assert_cmpstr, but using
CStrings instead of const char*. It fixes all the cases where a
temporary CString was used in g_assert_cmpstr, and uses the new
macro also for the cases where we were caching the CString just
for g_assert_cmpstr.
- UIProcess/API/gtk/tests/TestDownloads.cpp:
(testDownloadRemoteFile):
- UIProcess/API/gtk/tests/TestInspectorServer.cpp:
(testInspectorServerPageList):
- UIProcess/API/gtk/tests/TestLoaderClient.cpp:
- UIProcess/API/gtk/tests/TestMain.h:
- UIProcess/API/gtk/tests/TestResources.cpp:
- UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:
(testGetFaviconURI):
- UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(assertThatUserAgentIsSentInHeaders):
(testWebKitSettingsUserAgent):
- 12:46 AM Changeset in webkit [144739] by
-
- 2 edits in trunk/Tools
Add content shell bots to garden-o-matic for general failurse
https://bugs.webkit.org/show_bug.cgi?id=111168
Reviewed by Adam Barth.
All but the WebKit (Content Shell) Android bot is stable enough. While
they're not green yet, there must not be any non-layout test failures on
them.
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
(.):
- 12:31 AM Changeset in webkit [144738] by
-
- 2 edits in trunk/Source/WebCore
[V8] Remove unused custom indexedPropertyGetter
https://bugs.webkit.org/show_bug.cgi?id=111409
Patch by Koji Hara <kojih@chromium.org> on 2013-03-05
Reviewed by Kentaro Hara.
Remove unused custom indexedPropertyGetter.
There are 9 custom indexedPropertyGetter, including an unused one(NamedNodeMap).
This commit assures all existing custom indexedPropertyGetter(for V8) are used.
No new tests. Simple refactoring.
- bindings/v8/custom/V8NamedNodeMapCustom.cpp: Remove indexedPropertyGetter
- 12:30 AM Changeset in webkit [144737] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL gardening.
Skip failing tests on EFL bots.
- platform/efl/TestExpectations:
- 12:14 AM Changeset in webkit [144736] by
-
- 2 edits in trunk/LayoutTests
Unreviewed; updating test expectations.
fast/regions/seamless-iframe-flowed-into-regions.html is failing not only with debug build.
- platform/chromium/TestExpectations:
- 12:08 AM Changeset in webkit [144735] by
-
- 14 edits in trunk/Source/WebCore
ShadowRoot needs guardRef() and guardDeref()
https://bugs.webkit.org/show_bug.cgi?id=109777
Reviewed by Dimitri Glazkov.
This change moves m_guardRefCount from Document to TreeScope,
which allows ShadowRoot to be guarded by guardRef() mechanism as
Document. After r137524, Node referes TreeScope instead of
Document. This is natural consequence of the change: It no longer
makes sense to guardRef() Document pointer from Node.
Detail:
- Document::m_guardRefCount and related funcdtions are moved to TreeScope
- Document::removedLastRef is factored out into TreeScope::removedLastRefToScope(), TreeScope::dispose() and Docuent::dispose(). ShadowRoot also got its own dispose() implementation.
- Moved guardRef() and guardDeref() calls to TreeScope and Node. Note that there are two "guarded" TreeScope references. One is Node::m_treeScope and another is TreeScope::m_parentTreeScope. The guarded-ref management is now encapsulated in these two classes.
No new tests. Covered by existing tests.
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::dispose): Extracted from removedLastRef()
- dom/Document.h:
(WebCore::Node::isTreeScope):
(WebCore::Node::Node):
- dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::DocumentFragment): Remove ASSERT() and move it to ...
(WebCore::DocumentFragment::create): ... here, to allow NULL document from ShadowRoot.
- dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::removedLastRef):
- dom/Node.h:
(WebCore::Node::setTreeScope):
- dom/Element.cpp:
(WebCore::Element::ensureAttr): This has been wrong and is fixed in this revision since the incorrectness is unveiled by this change.
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot): Passed NULL document to superclass. This aligns what Document is doing.
(WebCore::ShadowRoot::dispose): Added.
- dom/ShadowRoot.h:
(ShadowRoot):
- dom/TreeScope.cpp:
(SameSizeAsTreeScope):
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::~TreeScope):
(WebCore::TreeScope::dispose): Added.
(WebCore::TreeScope::setParentTreeScope):
(WebCore::TreeScope::deletionHasBegun):
(WebCore::TreeScope::beginDeletion):
(WebCore::TreeScope::refCount): Added.
- dom/TreeScope.h: Turned m_rootNode to Node* from ContainerNode* for Node::isTreeScope to be inlined.
(WebCore::TreeScope::guardRef): Pulled up from Document.
(WebCore::TreeScope::guardDeref): Ditto.
(WebCore::TreeScope::hasGuardRefCount): Added to hide m_guardRefCount.
(WebCore::TreeScope::deletionHasBegun): Added.
(WebCore::TreeScope::beginDeletion): Added.
(WebCore::TreeScope::removedLastRefToScope): Pulled up from Document.
- dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):
Mar 4, 2013:
- 11:59 PM Changeset in webkit [144734] by
-
- 2 edits in trunk/LayoutTests
2013-03-04 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed, adding crashing test to the expectations.
- platform/chromium/TestExpectations:
- 11:56 PM Changeset in webkit [144733] by
-
- 2 edits in trunk/Tools
[chromium] remove deprecated WebTestRunner::setFocus API
https://bugs.webkit.org/show_bug.cgi?id=111354
Reviewed by James Robinson.
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestDelegate):
- 11:44 PM Changeset in webkit [144732] by
-
- 3 edits2 adds in trunk
getPropertyValue for -webkit-text-stroke returns null, should compute the shorthand value
https://bugs.webkit.org/show_bug.cgi?id=111018
Patch by Uday Kiran <udaykiran@motorola.com> on 2013-03-04
Reviewed by Alexander Pavlov.
Source/WebCore:
Test: fast/css/getPropertyValue-webkit-text-stroke.html
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
LayoutTests:
Added test for getPropertyValue("-webkit-text-stroke").
- fast/css/getPropertyValue-webkit-text-stroke-expected.txt: Added.
- fast/css/getPropertyValue-webkit-text-stroke.html: Added.
- 11:42 PM Changeset in webkit [144731] by
-
- 7 edits in trunk/Tools
Run the bindings generation tests on EWS and CQ bots
https://bugs.webkit.org/show_bug.cgi?id=111358
Reviewed by Adam Barth.
The tests are super fast and not flaky.
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.run_bindings_tests_command):
- Scripts/webkitpy/common/config/ports_mock.py:
(MockPort.run_webkit_tests_command):
(MockPort):
(MockPort.run_bindings_tests_command):
- Scripts/webkitpy/tool/commands/download_unittest.py:
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- Scripts/webkitpy/tool/steps/runtests_unittest.py:
(RunTestsTest.test_webkit_run_unit_tests):
- Scripts/webkitpy/tool/steps/steps_unittest.py:
- 11:33 PM Changeset in webkit [144730] by
-
- 3 edits2 adds in trunk
getPropertyValue for -webkit-columns returns null, should compute the shorthand value
https://bugs.webkit.org/show_bug.cgi?id=111011
Patch by Uday Kiran <udaykiran@motorola.com> on 2013-03-04
Reviewed by Alexander Pavlov.
Source/WebCore:
Test: fast/css/getPropertyValue-columns.html
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
LayoutTests:
Added test for getPropertyValue("-webkit-columns").
- fast/css/getPropertyValue-columns-expected.txt: Added.
- fast/css/getPropertyValue-columns.html: Added.
- 11:31 PM Changeset in webkit [144729] by
-
- 5 edits in trunk
Web Inspector: Do not accumulate file system files, add them to workspace immediately
https://bugs.webkit.org/show_bug.cgi?id=111325
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate.prototype.populate.fileLoaded):
(WebInspector.FileSystemProjectDelegate.prototype.populate):
- inspector/front-end/IsolatedFileSystem.js:
(WebInspector.IsolatedFileSystem.prototype.innerCallback):
(WebInspector.IsolatedFileSystem.prototype.requestFilesRecursive):
LayoutTests:
- inspector/file-system-project.html:
- 11:20 PM Changeset in webkit [144728] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Windows build fix attempt.
floor method is ambigious so explicitly specify the type.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):
- 11:13 PM Changeset in webkit [144727] by
-
- 16 edits2 adds in trunk
AX: cellForColumnAndRow fails for tables with hidden table cells
https://bugs.webkit.org/show_bug.cgi?id=110050
Reviewed by Tim Horton.
Source/WebCore:
If a table had hidden cells, then accessibility code was being confused in a few ways.
1) The cellForColumnAndRow method would return the wrong information since that was
using the RenderTableSection to retrieve a cell, which did not have the same data as the AXTable
2) The way we were adding children made it impossible to determine column and row range because we
would skip rows that had hidden children
3) AccessibilityARIAGrid and AccessibilityTable were using different methods for cellForColumnAndRow
The fix does a few things to make things right:
1) Always add an accessibility row, even if there are no visible cells in that row.
2) Have one method for AXTable and AXARIAGrid for cellForColumnAndRow.
3) Change cellForColumnAndRow to query the accessibility children rather than the RenderTableSection in determining the row, col info.
4) cellForColumnAndRow should use unsigned values instead of int values.
Test: accessibility/table-with-hidden-head-section.html
- accessibility/AccessibilityARIAGrid.cpp:
(WebCore):
- accessibility/AccessibilityARIAGrid.h:
(AccessibilityARIAGrid):
- accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::rowIndexRange):
(WebCore::AccessibilityARIAGridCell::columnIndexRange):
- accessibility/AccessibilityARIAGridCell.h:
(AccessibilityARIAGridCell):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::cellForColumnAndRow):
- accessibility/AccessibilityTable.h:
(WebCore):
(AccessibilityTable):
- accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::rowIndexRange):
(WebCore::AccessibilityTableCell::columnIndexRange):
- accessibility/AccessibilityTableCell.h:
(AccessibilityTableCell):
- accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
(webkitAccessibleTableGetColumnAtIndex):
(webkitAccessibleTableGetRowAtIndex):
(webkitAccessibleTableGetColumnExtentAt):
(webkitAccessibleTableGetRowExtentAt):
(webkitAccessibleTableGetColumnHeader):
(webkitAccessibleTableGetRowHeader):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- rendering/RenderTableSection.h:
(RenderTableSection):
(WebCore::RenderTableSection::rowRendererAt):
Source/WebKit/chromium:
- src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::cellColumnIndex):
(WebKit::WebAccessibilityObject::cellColumnSpan):
(WebKit::WebAccessibilityObject::cellRowIndex):
(WebKit::WebAccessibilityObject::cellRowSpan):
LayoutTests:
- accessibility/table-with-hidden-head-section-expected.txt: Added.
- accessibility/table-with-hidden-head-section.html: Added.
- platform/chromium/TestExpectations:
- 10:57 PM Changeset in webkit [144726] by
-
- 3 edits2 adds in trunk
getAttribute does not behave correctly for mixed-case attributes on HTML elements
https://bugs.webkit.org/show_bug.cgi?id=105713
Patch by Arpita Bahuguna <a.bah@samsung.com> on 2013-03-04
Reviewed by Andreas Kling.
Source/WebCore:
getAttribute() and getAttributeNode() APIs do not convert the
passed attribute name to lowercase before comparing against the
existing attributes.
The specification however states that the passed name should
be converted to ASCII lowercase before checking for the existence
of the given attribute. [www.w3.org/TR/domcore/#dom-element-getattribute]
Test: fast/dom/Element/getAttribute-case-insensitivity.html
- dom/Element.h:
(WebCore::ElementData::getAttributeItemIndex):
getAttributeItemIndex() accepts a bool param 'shouldIgnoreAttributeCase'
which specifies whether the attribute's case should be ignored
before comparison. But inspite of this param's value we still carry
out a case sensitive search.
Have modified the same to convert the passed attribute's name to
lowercase if 'shouldIgnoreAttributeCase' is true.
LayoutTests:
- fast/dom/Element/getAttribute-case-insensitivity-expected.txt: Added.
- fast/dom/Element/getAttribute-case-insensitivity.html: Added.
Layout test added for verifying that getAttribute() and getAttributeNode()
APIs convert the passed attribute name to lowercase before comparing
against the existing attributes.
- 10:35 PM Changeset in webkit [144725] by
-
- 7 edits in trunk/Source
[Chromium] Add runtime flag for font load events
https://bugs.webkit.org/show_bug.cgi?id=111296
Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-04
Reviewed by Kent Tamura.
Add a runtime feature flag for FontLoader interface (disabled by default),
and enable ENABLE_FONT_LOAD_EVENTS build flag for chromium.
Source/WebCore:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setFontLoadEventsEnabled):
(WebCore::RuntimeEnabledFeatures::fontLoadEventsEnabled):
Source/WebKit/chromium:
- features.gypi:
- public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableFontLoadEvents):
(WebKit):
(WebKit::WebRuntimeFeatures::isFontLoadEventsEnabled):
- 10:31 PM Changeset in webkit [144724] by
-
- 5 edits in trunk/LayoutTests
[V8] Add LayoutTests for SerializedScriptValue Int32/Uint32 cases
https://bugs.webkit.org/show_bug.cgi?id=111364
Reviewed by Kentaro Hara.
A lack of layout tests for SerializedScriptValue special cases let
crbug.com/179280 slip in and out un-noticed. Rectify the situation.
- platform/chromium/fast/storage/serialized-script-value-expected.txt:
- platform/chromium/fast/storage/serialized-script-value.html:
- storage/indexeddb/structured-clone-expected.txt:
- storage/indexeddb/structured-clone.html:
- 10:14 PM Changeset in webkit [144723] by
-
- 15 edits3 copies3 adds in trunk
WEBGL_compressed_texture_atc implementation
https://bugs.webkit.org/show_bug.cgi?id=110496
Patch by Brandon Jones <bajones@google.com> on 2013-03-04
Reviewed by Kenneth Russell.
Source/WebCore:
Test: webgl/conformance/extensions/webgl-compressed-texture-atc.html
Exposes the WEBGL_compressed_texture_atc extension, but is unverified since no desktop hardware supports
the format that I am aware of. Should enable mobile ports to expose the format, however.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
- html/canvas/WebGLCompressedTextureATC.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(WebCore::WebGLCompressedTextureATC::WebGLCompressedTextureATC):
(WebCore::WebGLCompressedTextureATC::~WebGLCompressedTextureATC):
(WebCore::WebGLCompressedTextureATC::getName):
(WebCore::WebGLCompressedTextureATC::create):
(WebCore::WebGLCompressedTextureATC::supported):
- html/canvas/WebGLCompressedTextureATC.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(WebGLCompressedTextureATC):
- html/canvas/WebGLCompressedTextureATC.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):
- html/canvas/WebGLRenderingContext.h:
(WebCore):
(WebGLRenderingContext):
- platform/graphics/Extensions3D.h:
LayoutTests:
- webgl/conformance/extensions/webgl-compressed-texture-atc-expected.txt: Added.
- webgl/conformance/extensions/webgl-compressed-texture-atc.html: Added.
- webgl/resources/webgl_test_files/conformance/extensions/webgl-compressed-texture-atc.html: Added.
- 10:12 PM Changeset in webkit [144722] by
-
- 3 edits2 adds in trunk
Web Inspector: Exceptions when WebInspector run in hosted mode.
https://bugs.webkit.org/show_bug.cgi?id=111326
Reviewed by Pavel Feldman.
Source/WebCore:
There is bug in commands code generation in InspectorBackend.js
As a consequence all protocol enums have wrong names and cause
exception when refererenced.
Currently protocol enums are referenced only from NetworkManager.
Test: inspector/inspector-backend-commands-generation.html
- inspector/front-end/InspectorBackend.js:
(InspectorBackendClass.prototype.loadFromJSONIfNeeded):
Use static method to generate code.
(InspectorBackendClass._generateCommands):
Extracted from loadFromJSONIfNeeded. Typo fixed.
LayoutTests:
Test runtime commands code generator output.
- inspector/inspector-backend-commands-generation-expected.txt: Added.
- inspector/inspector-backend-commands-generation.html: Added.
- 10:09 PM Changeset in webkit [144721] by
-
- 1 copy in tags/Safari-536.29.1
New Tag.
- 10:04 PM Changeset in webkit [144720] by
-
- 12 edits in trunk/Source
Source/Platform: Add audio hardware support for multi-channel by implementing AudioDestinationNode.maxChannelCount
https://bugs.webkit.org/show_bug.cgi?id=111385
Reviewed by James Robinson.
- chromium/public/Platform.h:
(WebKit::Platform::audioHardwareOutputChannels):
Source/WebCore: Add audio hardware support for multi-channel output by implementing AudioDestinationNode.maxChannelCount
https://bugs.webkit.org/show_bug.cgi?id=111385
Reviewed by James Robinson.
See specification details for .maxChannelCount:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioDestinationNode
- Modules/webaudio/AudioDestinationNode.h:
(WebCore::AudioDestinationNode::maxChannelCount):
- Modules/webaudio/AudioDestinationNode.idl:
- Modules/webaudio/AudioNode.h:
Implement .maxChannelCount attribute.
(AudioNode):
- Modules/webaudio/DefaultAudioDestinationNode.h:
- Modules/webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::initialize):
(WebCore::DefaultAudioDestinationNode::createDestination):
(WebCore::DefaultAudioDestinationNode::enableInput):
Call to createDestination() now takes no argument.
Instead we maintain a member variable for the input device ID.
(WebCore::DefaultAudioDestinationNode::maxChannelCount):
(WebCore::DefaultAudioDestinationNode::setChannelCount):
Check port-specific hardware support for maxChannelCount(),
and allow setting the channel count based on what the hardware
supports.
- platform/audio/AudioDestination.h:
(AudioDestination):
- platform/audio/chromium/AudioDestinationChromium.cpp:
(WebCore::AudioDestination::maxChannelCount):
(WebCore::AudioDestinationChromium::render):
Call into chromium WebKit API: audioHardwareOutputChannels().
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestination::maxChannelCount):
Add basic implementation for maxChannelCount() only supporting stereo output.
- platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestination::maxChannelCount):
Add basic implementation for maxChannelCount() only supporting stereo output.
Later, the mac port can support more than this with some small improvements to AudioDestinationMac.
- 9:55 PM Changeset in webkit [144719] by
-
- 2 edits in trunk/Tools
run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
https://bugs.webkit.org/show_bug.cgi?id=111384
Reviewed by Ryosuke Niwa.
Sometimes I want to know why various LayoutTests are slow
without having to convert them into PerformanceTests in order
to use our fancy profiling. The Driver already knows how to
do the right thing, we just need to expose the options to the user.
Handling of these options is already unittested in the perftests_unittest.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 9:31 PM Changeset in webkit [144718] by
-
- 2 edits in branches/chromium/1410/Source/WebCore
Merge 144437
Web Inspector: [DataGrid] Columns are misaligned after rows being refreshed.
https://bugs.webkit.org/show_bug.cgi?id=111077
Reviewed by Pavel Feldman.
Analysis: DataGridNode.refresh removes all cells and then recreates them.
The issue is that mandatory "corner" cell is not recreated.
- inspector/front-end/DataGrid.js:
(WebInspector.DataGridNode.prototype.refresh):
Added "corner" cell restoration code.
TBR=eustas@chromium.org
Review URL: https://codereview.chromium.org/12414004
- 9:27 PM Changeset in webkit [144717] by
-
- 2 edits in trunk/Source/WebKit/mac
BUILD FIX (r144662): Import JSBase.h in WebFrameLoadDelegate.h
<http://webkit.org/b/111269>
Fixes the following build failure:
In file included from Source/WebKit/ios/DefaultDelegates/WebDefaultFrameLoadDelegate.m:11:
In file included from Source/WebKit/mac/WebView/WebFrameLoadDelegatePrivate.h:29:
Source/WebKit/mac/WebView/WebFrameLoadDelegate.h:41:5: error: 'JSC_OBJC_API_ENABLED' is not defined, evaluates to 0 [-Werror,-Wundef]
#if JSC_OBJC_API_ENABLED
Source/WebKit/mac/WebView/WebFrameLoadDelegate.h:207:5: error: 'JSC_OBJC_API_ENABLED' is not defined, evaluates to 0 [-Werror,-Wundef]
#if JSC_OBJC_API_ENABLED
2 errors generated.
- WebView/WebFrameLoadDelegate.h: Include JSBase.h.
- 9:24 PM Changeset in webkit [144716] by
-
- 3 edits2 adds in trunk/Tools
check-webkit-style says "Have to enable auto props in the subversion config file"
https://bugs.webkit.org/show_bug.cgi?id=107724
Patch by Alan Cutter <alancutter@chromium.org> on 2013-03-04
Reviewed by Tony Chang.
Added a standard svn config file for WebKit developers to use.
Updated the style and commit queue bot build scripts to load this file.
- EWSTools/GoogleComputeEngine/build-commit-queue.sh:
- EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
- EWSTools/configure-svn-config.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
- svn-config: Added.
- 9:23 PM Changeset in webkit [144715] by
-
- 19 edits in trunk/LayoutTests
Rebaseline 4 virtual/softwarecompositing tests.
Unreviewed rebaseline of test expectations.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png:
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/vertical-scroll-composited-expected.png:
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
- 8:57 PM Changeset in webkit [144714] by
-
- 6 edits2 adds in trunk
Background HTML parser can rewind the tokenizer after end-of-file
https://bugs.webkit.org/show_bug.cgi?id=111365
Reviewed by Eric Seidel.
Source/WebCore:
Prior to this patch, it was possible to call didFailSpeculation after
processing the end-of-file token because checkForSpeculationFailure
didn't zero out m_tokenizer in some control paths.
This patch renames checkForSpeculationFailure to validateSpeculations
and ensures that it always takes ownership of the main thread's
HTMLTokenizer.
This patch also adds a number of ASSERTs to make sure the parser state
machine stays in the correct configuration (e.g., that we don't have a
main thread tokenizer while we're supposed to be tokenizing on the
background thread).
Test: fast/parser/document-write-fighting-eof.html
- html/parser/BackgroundHTMLInputStream.cpp:
(WebCore::BackgroundHTMLInputStream::rewindTo):
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::append):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::validateSpeculations):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
- html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
LayoutTests:
- fast/parser/document-write-fighting-eof.html: Added.
- 8:37 PM Changeset in webkit [144713] by
-
- 3 edits2 adds in trunk
Make sure that clearOwnerNode also clears StyleResolver references (via didMutate).
https://bugs.webkit.org/show_bug.cgi?id=109446
Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-03-04
Reviewed by Eric Seidel.
Source/WebCore:
Test: fast/css/stylesheet.innerHTML-calls-didmutate.html
- css/CSSStyleSheet.h:
LayoutTests:
- fast/css/stylesheet.innerHTML-calls-didmutate-expected.txt: Added.
- fast/css/stylesheet.innerHTML-calls-didmutate.html: Added.
- 7:49 PM Changeset in webkit [144712] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r185990. Requested by
jamesr_ via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-04
- DEPS:
- 7:40 PM Changeset in webkit [144711] by
-
- 2 edits in trunk/Source/WebCore
Unreviewd build fix after r144701.
- platform/EventTracer.cpp:
(WebCore::EventTracer::initialize):
- 7:23 PM Changeset in webkit [144710] by
-
- 2 edits in trunk/Source/WebCore
Fix some style issues in RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=111369
Patch by Min Qin <qinmin@chromium.org> on 2013-03-04
Reviewed by Simon Fraser.
Just style fix, no test needed
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::frameViewDidScroll):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
- 7:17 PM Changeset in webkit [144709] by
-
- 3 edits in trunk/Source/WebCore
Revert changes to RenderLayer::scrollByRecursively() that were added for gesture-scrolling
https://bugs.webkit.org/show_bug.cgi?id=111007
Reviewed by Simon Fraser.
Due to http://trac.webkit.org/changeset/144519 landing, the changes made to RenderLayer in
http://trac.webkit.org/changeset/142057,
http://trac.webkit.org/changeset/140177, and
http://trac.webkit.org/changeset/142195
are no longer necessary (as RenderLayer::scrollByRecursively() is not used for
gesture-scrolling) and should be reverted.
No change in behavior, so no new tests needed.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollByRecursively):
- rendering/RenderLayer.h:
- 7:05 PM Changeset in webkit [144708] by
-
- 14 edits1 add in trunk/Source/JavaScriptCore
Unused Structure property tables waste 14MB on Membuster.
<http://webkit.org/b/110854>
<rdar://problem/13292104>
Reviewed by Geoffrey Garen.
Turn PropertyTable into a GC object and have Structure drop unpinned tables when marking.
14 MB progression on Membuster3.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
Added PropertyTable.cpp.
- runtime/PropertyTable.cpp: Added.
(JSC::PropertyTable::create):
(JSC::PropertyTable::clone):
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::destroy):
(JSC::PropertyTable::~PropertyTable):
(JSC::PropertyTable::visitChildren):
Moved marking of property table values here from Structure::visitChildren().
- runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::get):
Move m_cell to a local before using it multiple times. This avoids a multiple-access race when
Structure::checkOffsetConsistency() is used in assertions on the main thread while a marking thread
zaps the property table.
- runtime/Structure.h:
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):
- runtime/StructureInlines.h:
(JSC::Structure::propertyTable):
Added a getter for the Structure's PropertyTable that ASSERTs GC currently isn't active.
Because GC can zap an unpinned property table at any time, it's not entirely safe to access it.
Renamed the variable itself to m_propertyTableUnsafe to force call sites into explaining themselves.
(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::checkOffsetConsistency):
Moved these out of Structure.h to break header dependency cycle between Structure/PropertyTable.
- runtime/Structure.cpp:
(JSC::Structure::visitChildren):
Null out m_propertyTable if the table is unpinned. This'll cause the table to get GC'd.
- runtime/JSGlobalData.h:
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
Add a global propertyTableStructure.
- runtime/PropertyMapHashTable.h:
(PropertyTable):
(JSC::PropertyTable::createStructure):
(JSC::PropertyTable::copy):
Make PropertyTable a GC object.
- runtime/Structure.cpp:
(JSC::Structure::dumpStatistics):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::sealTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::isSealed):
(JSC::Structure::isFrozen):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::pin):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::despecifyAllFunctions):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):
(JSC::Structure::createPropertyMap):
(JSC::Structure::getPropertyNamesFromStructure):
(JSC::Structure::checkConsistency):
- 6:48 PM Changeset in webkit [144707] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r144701.
- platform/EventTracer.cpp:
(WebCore::EventTracer::initialize):
- 6:46 PM Changeset in webkit [144706] by
-
- 3 edits4 adds in trunk
REGRESSION (r143643): Buttons containing floats render differently
https://bugs.webkit.org/show_bug.cgi?id=110933
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-04
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/forms/button-with-float.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
Also include new flexbox as a renderer that needs to enclose
overhanging floats. Flex boxes establish a block formatting context,
so they need to contain floats:
http://dev.w3.org/csswg/css3-flexbox/#flex-items
LayoutTests:
- css3/flexbox/float-inside-flexitem-expected.html: Added.
- css3/flexbox/float-inside-flexitem.html: Added.
- fast/forms/button-with-float-expected.html: Added.
- fast/forms/button-with-float.html: Added.
- 6:34 PM Changeset in webkit [144705] by
-
- 4 edits in trunk/Tools
[chromium] Switch to new webkit_support::CreateLayerTreeView interface
https://bugs.webkit.org/show_bug.cgi?id=111285
Patch by James Robinson <jamesr@chromium.org> on 2013-03-04
Reviewed by Adrienne Walker.
This removes the need for WebCompositorSupport::initialize and exposes
slightly fewer entry points across the repository boundary.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
- DumpRenderTree/chromium/TestShell.h:
(TestShell::webCompositorThread):
(TestShell):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::initializeLayerTreeView):
- 5:58 PM Changeset in webkit [144704] by
-
- 1 edit2 adds in trunk/PerformanceTests
Add PerformanceTest for document startup via iframe append/remove
https://bugs.webkit.org/show_bug.cgi?id=111389
Reviewed by Kentaro Hara.
We'd like pages with lots of iframes to be fast.
This test shows that at least for V8/Chromium we spend
all our time booting v8.
On my 32-core linux machine I see about 70 runs/sec in
Release and 5 runs/sec in Debug.
- DOM/iframe-append-remove.html: Added.
- 5:54 PM Changeset in webkit [144703] by
-
- 2 edits in trunk/Source/WebCore
Support WebSpeech - Speech Synthesis
https://bugs.webkit.org/show_bug.cgi?id=106742
Build fix.
- Modules/speech/SpeechSynthesis.cpp:
- 5:45 PM Changeset in webkit [144702] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r144595.
http://trac.webkit.org/changeset/144595
https://bugs.webkit.org/show_bug.cgi?id=90341
Causing multiple crashes in fast/dom/Element/* tests (hits
assert in Attr.cp:215)
Source/WebCore:
- dom/Element.cpp:
(WebCore::Element::setAttributeNode):
LayoutTests:
- fast/dom/Element/setAttributeNode-case-insensitivity-expected.txt: Removed.
- fast/dom/Element/setAttributeNode-case-insensitivity.html: Removed.
- 5:42 PM Changeset in webkit [144701] by
-
- 9 edits in trunk/Source
[chromium] Implement TRACE_EVENT macros for sampling profiling
https://bugs.webkit.org/show_bug.cgi?id=110932
Reviewed by Adam Barth.
We are implementing TRACE_EVENT macros for sampling profiling.
It works in the following mechanism:
- Chromium defines global state variables for sampling profiling.
(i.e. g_trace_state0, g_trace_state1, g_trace_state2 in trace_event.h)
- WebKit gets the addresses of the global state variables at the
initialization step. (i.e. EventTracer::initialize())
- WebKit updates the global states by using TRACE_EVENT_SAMPLING_STATE()
macros every time WebKit changes its state. (e.g. DOM attribute
getters/setters/methods)
- A sampling thread running in Chrome reads the global states
periodically and visualizes the profiling results into about://tracing.
This patch implements (1) a WebKit API to get the addresses of
the global states and (2) the TRACE_EVENT_SAMPLING_STATE() macro.
Source/Platform:
- chromium/public/Platform.h:
(Platform):
(WebKit::Platform::getTraceSamplingState):
Source/WebCore:
No tests. The sampling profiler is not enabled in Chrome by default.
I manually inserted TRACE_EVENT_SAMPLING_STATE() macros and
confirmed that the sampling profiling is working as expected.
- platform/EventTracer.cpp:
(WebCore::EventTracer::initialize):
(WebCore::EventTracer::getTraceCategoryEnabledFlag):
(WebCore):
- platform/EventTracer.h:
(WebCore):
(EventTracer):
- platform/chromium/EventTracerChromium.cpp:
(WebCore):
(WebCore::EventTracer::initialize):
- platform/chromium/TraceEvent.h:
Source/WebKit/chromium:
- src/WebKit.cpp:
(WebKit::initializeWithoutV8):
- 5:39 PM FeatureFlags edited by
- (diff)
- 5:17 PM Changeset in webkit [144700] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: touch-gesture-noscroll-body-* are failing on mac.
- 5:16 PM Changeset in webkit [144699] by
-
- 2 edits in trunk/Tools
Unreviewed. Get rid of some AppleWin VS2010 build warnings.
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
- 5:13 PM Changeset in webkit [144698] by
-
- 11 edits in trunk
Support WebSpeech - Speech Synthesis
https://bugs.webkit.org/show_bug.cgi?id=106742
Reviewed by Simon Fraser.
Source/JavaScriptCore:
Enable speech synthesis for the Mac.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Enable speech synthesis for the Mac.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
Enable speech synthesis for the Mac.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Enable speech synthesis for the Mac.
- Configurations/FeatureDefines.xcconfig:
LayoutTests:
Unskip speech synthesis tests.
- fast/dom/script-tests/constructed-objects-prototypes.js:
(constructorPropertiesOnWindow):
- platform/mac/TestExpectations:
- 4:55 PM Changeset in webkit [144697] by
-
- 2 edits in trunk/Tools
BUILD FIX (r144657): Fix DumpRenderTree build failure on iOS
Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm:95:29: error: class method '+stringWithJSStringRef:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
NSString *idAttribute = [NSString stringWithJSStringRef:idAttributeRef];
~
1 error generated.
- DumpRenderTree/ios/AccessibilityControllerIOS.mm: Import
AccessibilityCommonMac.h.
- 4:42 PM Changeset in webkit [144696] by
-
- 20 edits3 adds in trunk
<link rel="apple-touch-icon"> tag is not honored on CNN.com, workflowy.com etc
https://bugs.webkit.org/show_bug.cgi?id=109061
Patch by Ruslan Abdikeev <aruslan@chromium.org> on 2013-03-04
Reviewed by Adam Barth.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
Test: fast/dom/icon-url-list-apple-touch.html
Added iconTypes parameter to Document::iconURLs().
Added Document::shortcutIconURLs() with original semantics of iconURLs().
Fixed IconController.cpp to provide iconTypesMask to iconURLs().
Renamed iconTypes to iconTypesMask to make the meaning clearer.
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::shortcutIconURLs):
(WebCore):
(WebCore::Document::iconURLs):
- dom/Document.h:
(Document):
- loader/icon/IconController.cpp:
(WebCore::IconController::iconURL):
(WebCore::IconController::urlsForTypes):
- testing/Internals.cpp:
(WebCore::Internals::iconURLs):
(WebCore::Internals::shortcutIconURLs):
(WebCore):
(WebCore::Internals::allIconURLs):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Added test for apple-touch-icon in allIconURLs().
Changed iconURLs() to shortcutIconURLs().
- fast/dom/icon-url-change.html:
- fast/dom/icon-url-list-apple-touch-expected.txt: Added.
- fast/dom/icon-url-list-apple-touch.html: Added.
- fast/dom/icon-url-list.html:
- fast/dom/icon-url-property.html:
- 4:31 PM Changeset in webkit [144695] by
-
- 4 edits in trunk/Source/WebKit2
UI process storage areas should hold on to storage maps
https://bugs.webkit.org/show_bug.cgi?id=111374
Reviewed by Beth Dakin.
Pass the session storage quota size through to the storage area constructor and
create a StorageMap with the given quota size.
- UIProcess/Storage/StorageManager.cpp:
(StorageManager::StorageArea):
(WebKit::StorageManager::StorageArea::create):
(WebKit::StorageManager::StorageArea::StorageArea):
(StorageManager::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::create):
(WebKit::StorageManager::SessionStorageNamespace::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::getOrCreateStorageArea):
(WebKit::StorageManager::createSessionStorageNamespace):
(WebKit::StorageManager::createSessionStorageNamespaceInternal):
- UIProcess/Storage/StorageManager.h:
(StorageManager):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
- 4:22 PM Changeset in webkit [144694] by
-
- 3 edits3 adds in trunk
Cache partitioning does not affect iframe MainResources
https://bugs.webkit.org/show_bug.cgi?id=111022
Reviewed by David Kilzer.
Source/WebCore:
Set the partition of a main resource request if in a subframe.
Test: http/tests/cache/partitioned-cache-iframe.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURL):
LayoutTests:
These tests results are for the case in which the cache is not
partitioned, as no shipping ports have cache partitioning enabled
- http/tests/cache/partitioned-cache-iframe-expected.txt: Added.
- http/tests/cache/partitioned-cache-iframe.html: Added.
- http/tests/cache/resources/random-cached-iframe.cgi: Added.
- 3:51 PM Changeset in webkit [144693] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix after r144675.
Work around picky/old C++ compilers by separating the '>>' in
nested templates with a space.
- UIProcess/Storage/StorageManager.cpp:
(StorageManager::StorageArea):
- 3:51 PM Changeset in webkit [144692] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/chromium/TestExpectations: Marking all html5lib/generated/ as crashing.
- 3:47 PM Changeset in webkit [144691] by
-
- 7 edits in trunk/Source/WebKit2
More work on UI side storage
https://bugs.webkit.org/show_bug.cgi?id=111370
Reviewed by Andreas Kling.
Add a DispatchStorageEvent message and begin hooking it up.
- UIProcess/Storage/StorageManager.cpp:
(StorageManager::StorageArea):
(WebKit::StorageManager::StorageArea::setItem):
(WebKit):
(WebKit::StorageManager::StorageArea::dispatchEvents):
(WebKit::StorageManager::setItem):
(WebKit::StorageManager::findStorageArea):
- UIProcess/Storage/StorageManager.h:
(StorageManager):
- UIProcess/Storage/StorageManager.messages.in:
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::setItem):
(WebKit::StorageAreaProxy::dispatchStorageEvent):
(WebKit):
- WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
- WebProcess/Storage/StorageAreaProxy.messages.in:
- 3:45 PM Changeset in webkit [144690] by
-
- 2 edits in trunk/Source/WebCore
AX: user agent shadow roots for plugins should be 'accessible'
https://bugs.webkit.org/show_bug.cgi?id=111339
Reviewed by Tim Horton.
If a plugin element uses a user agent shadow element, we should make that shadow element
into a button with the title and subtitle put together, and use that as the label. This
will probably be the best accessibility experience.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
- 3:45 PM Changeset in webkit [144689] by
-
- 1 edit2 adds in trunk/LayoutTests
CSS3 calc: identify divide by zero cases at parse time
https://bugs.webkit.org/show_bug.cgi?id=80411
Patch by Alan Cutter <alancutter@chromium.org> on 2013-03-04
Reviewed by Tony Chang.
Added tests to check whether divide by 0 cases are caught.
- css3/calc/catch-divide-by-0-expected.txt: Added.
- css3/calc/catch-divide-by-0.html: Added.
- 3:36 PM Changeset in webkit [144688] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Form controls on composited layers are not painted properly
https://bugs.webkit.org/show_bug.cgi?id=111366
Reviewed by James Robinson.
Set PlatformContextSkia::m_drawingToImageBuffer which is used as a hint to properly blend GDI-painted bitmap.
- platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
- 3:25 PM Changeset in webkit [144687] by
-
- 3 edits in trunk/Source/WebCore
Give ViewportConstraints classes copy constructors
https://bugs.webkit.org/show_bug.cgi?id=111367
Reviewed by Beth Dakin.
Downstream code requires that ViewportConstraints objects have
copy constructors, so add them.
Also clean up some redundant initialization of stack objects
in RenderLayerCompositor.
No behavior change.
- page/scrolling/ScrollingConstraints.h:
(WebCore::ViewportConstraints::ViewportConstraints):
(ViewportConstraints):
(WebCore::FixedPositionViewportConstraints::FixedPositionViewportConstraints):
(FixedPositionViewportConstraints):
(WebCore::StickyPositionViewportConstraints::StickyPositionViewportConstraints):
(StickyPositionViewportConstraints):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeFixedViewportConstraints):
(WebCore::RenderLayerCompositor::computeStickyViewportConstraints):
- 3:23 PM Changeset in webkit [144686] by
-
- 2 edits in tags/Safari-537.31.13/Source/WebKit2
Merge r144659. <rdar://problem/13326713>
- 3:21 PM Changeset in webkit [144685] by
-
- 2 edits in branches/safari-534.59-branch/Source/WebKit2
Merge r144114
2013-02-26 Anders Carlsson <andersca@apple.com>
Fix a copy/paste error in WebLoaderClient::didBlockInsecurePluginVersion
https://bugs.webkit.org/show_bug.cgi?id=110914
<rdar://problem/13297581>
Reviewed by Beth Dakin.
Pass kWKErrorCodeInsecurePlugInVersion to the pluginDidFail callback.
- UIProcess/WebLoaderClient.cpp: (WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
- 3:19 PM Changeset in webkit [144684] by
-
- 2 edits in branches/safari-536.29-branch/Source/WebKit2
Merge 144114
2013-02-26 Anders Carlsson <andersca@apple.com>
Fix a copy/paste error in WebLoaderClient::didBlockInsecurePluginVersion
https://bugs.webkit.org/show_bug.cgi?id=110914
<rdar://problem/13297581>
Reviewed by Beth Dakin.
Pass kWKErrorCodeInsecurePlugInVersion to the pluginDidFail callback.
- UIProcess/WebLoaderClient.cpp: (WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
- 3:12 PM Changeset in webkit [144683] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. AppleWin build fix.
- html/parser/XSSAuditor.cpp:
(WebCore::isSemicolonSeparatedAttribute):
- 3:09 PM Changeset in webkit [144682] by
-
- 3 edits in trunk/Source/WebCore
CSSParser: Avoid temporary String when parsing hex colors.
<http://webkit.org/b/111341>
Reviewed by Anders Carlsson.
Templatize CSSParser::fastParseColor() so we can pass a CSSParserString as the color name.
This avoids creating a temporary WTF::String from the parser string.
- css/CSSParser.cpp:
(WebCore::CSSParser::fastParseColor):
- css/CSSParser.h:
- css/CSSParserValues.h:
(CSSParserString):
- 3:07 PM Changeset in webkit [144681] by
-
- 13 edits1 copy1 add in trunk
[CSS Grid Layout] Add parsing for grid-{start|before}
https://bugs.webkit.org/show_bug.cgi?id=110988
Reviewed by Tony Chang.
Source/WebCore:
Test: fast/css-grid-layout/grid-item-start-before-get-set.html
Refactored how we store internally grid-{row|column} to be based on grid-{before|start}.
This is required as grid-{row|column} are shorthands for resp. grid-{before|after} and grid-{start|end}
in the specification and will also be in the code. That means a lot of methods were renamed to be more
aligned with the new design.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Added the code to parse, apply and get back the new properties. Also
some renaming after the internal naming change below.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::maximumIndexInDirection):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::autoPlacementMajorAxisPositionForChild):
(WebCore::RenderGrid::autoPlacementMinorAxisPositionForChild):
- rendering/style/RenderStyle.h:
- rendering/style/StyleGridItemData.cpp:
(WebCore::StyleGridItemData::StyleGridItemData):
- rendering/style/StyleGridItemData.h:
(WebCore::StyleGridItemData::operator==):
Updated the naming now that we manipulate grid-{before|start} instead of grid-{row|column}.
LayoutTests:
- fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
- fast/css-grid-layout/grid-item-column-row-get-set.html:
Extended the test to make sure that both grid-column (resp. grid-row) and grid-start (resp. grid-before) are
in sync.
- fast/css-grid-layout/grid-item-start-before-get-set-expected.txt: Added.
- fast/css-grid-layout/grid-item-start-before-get-set.html: Added
Add this test for grid-{start|before}, similar to LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html.
- 2:44 PM Changeset in webkit [144680] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed build fix: wrap references to PluginInfoStore with
guards for platforms which do not enable NETSCAPE_PLUGIN_AP.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
- UIProcess/WebContext.h:
- 2:41 PM Changeset in webkit [144679] by
-
- 8 edits2 adds in trunk
WebSpeech: change voiceURI to voice
https://bugs.webkit.org/show_bug.cgi?id=110773
Reviewed by Tim Horton.
Source/WebCore:
Change the voiceURI property to a voice property that takes a SpeechSynthesisVoice.
This was recently added to the errata of the WebSpeech spec.
Test: platform/mac/fast/speechsynthesis/speech-synthesis-utterance-uses-voice.html
- Modules/speech/SpeechSynthesisUtterance.cpp:
(WebCore):
(WebCore::SpeechSynthesisUtterance::voice):
(WebCore::SpeechSynthesisUtterance::setVoice):
- Modules/speech/SpeechSynthesisUtterance.h:
(SpeechSynthesisUtterance):
- Modules/speech/SpeechSynthesisUtterance.idl:
- Modules/speech/SpeechSynthesisVoice.h:
(WebCore::SpeechSynthesisVoice::platformVoice):
(SpeechSynthesisVoice):
- platform/PlatformSpeechSynthesisUtterance.cpp:
(WebCore::PlatformSpeechSynthesisUtterance::PlatformSpeechSynthesisUtterance):
- platform/PlatformSpeechSynthesisUtterance.h:
(WebCore::PlatformSpeechSynthesisUtterance::voice):
(WebCore::PlatformSpeechSynthesisUtterance::setVoice):
(PlatformSpeechSynthesisUtterance):
- platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
LayoutTests:
- platform/mac/fast/speechsynthesis/speech-synthesis-utterance-uses-voice-expected.txt: Added.
- platform/mac/fast/speechsynthesis/speech-synthesis-utterance-uses-voice.html: Added.
- 2:29 PM Changeset in webkit [144678] by
-
- 2 edits in branches/safari-536.29-branch/Source/WebKit2
Merge 144659
2013-03-04 Anders Carlsson <andersca@apple.com>
Complete the plug-in URL string before sending it to the UI process
https://bugs.webkit.org/show_bug.cgi?id=111355
<rdar://problem/13326713>
Reviewed by Andreas Kling.
If the URL is not absolute, we won't be able to find it by path extension in the plug-in info store.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::unavailablePluginButtonClicked):
- 2:28 PM Changeset in webkit [144677] by
-
- 5 edits2 adds in trunk
Filename passed to FormData.append() takes precedence over filename in
File.
https://bugs.webkit.org/show_bug.cgi?id=111255
Patch by Victor Costan <costan@gmail.com> on 2013-03-04
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: http/tests/local/formdata/send-form-data-with-filename.html
- platform/network/FormData.cpp:
(WebCore::FormData::appendKeyValuePairItems): changed to implement the
behavior in the XMLHttpRequest W3C spec.
LayoutTests:
(runTest):
- http/tests/local/formdata/send-form-data-with-filename-expected.txt: Added.
- http/tests/local/formdata/send-form-data-with-filename.html: Added.
- http/tests/local/formdata/send-form-data-with-sliced-file-expected.txt: Updated
to reflect the behavior specified in the XMLHttpRequest W3C spec.
- platform/wk2/TestExpectations: newly added test doesn't work in
WebKit2 because beginDragWithFiles is not implemented
- 2:26 PM Changeset in webkit [144676] by
-
- 2 edits in branches/safari-534.59-branch/Source/WebKit2
Merge r144659
2013-03-04 Anders Carlsson <andersca@apple.com>
Complete the plug-in URL string before sending it to the UI process
https://bugs.webkit.org/show_bug.cgi?id=111355
<rdar://problem/13326713>
Reviewed by Andreas Kling.
If the URL is not absolute, we won't be able to find it by path extension in the plug-in info store.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::unavailablePluginButtonClicked):
- 2:25 PM Changeset in webkit [144675] by
-
- 3 edits in trunk/Source/WebKit2
Create and destroy storage areas in the UI process
https://bugs.webkit.org/show_bug.cgi?id=111361
Reviewed by Sam Weinig.
- UIProcess/Storage/StorageManager.cpp:
(StorageManager::StorageArea):
Keep track of listener connection and storage area ID pairs.
(WebKit::StorageManager::StorageArea::~StorageArea):
Assert that we don't have any listeners left.
(WebKit::StorageManager::StorageArea::addListener):
Add the pair to the set of listeners.
(WebKit::StorageManager::StorageArea::removeListener):
Remove the pair from the set of listeners.
(WebKit::StorageManager::SessionStorageNamespace::getOrCreateStorageArea):
Given an origin, look up or create the storage area.
(WebKit::StorageManager::createStorageArea):
Create the storage area if it doesn't already exist.
(WebKit::StorageManager::destroyStorageArea):
Look up the storage area and destroy it.
- UIProcess/Storage/StorageManager.h:
Add a map of open storage areas.
- 2:16 PM Changeset in webkit [144674] by
-
- 3 edits2 adds in trunk
Canvas and DOM go out of sync
https://bugs.webkit.org/show_bug.cgi?id=107701
Patch by Alexis Hetu <sugoi@chromium.org> on 2013-03-04
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/canvas/canvas-overflow-hidden-animation.html
Added an update of the current compositor from the layer's stacking
container when the layer itself isn't a stacking container.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateAfterLayout):
Added an update of the stacking container of the owning layer of the
layer backing when the owning layer isn't a stacking container itself.
LayoutTests:
Added a new layout test for moving an object (a div) within a div that
has the "overflow:hidden" property.
- fast/canvas/canvas-overflow-hidden-animation-expected.html: Added.
- fast/canvas/canvas-overflow-hidden-animation.html: Added.
- 2:15 PM Changeset in webkit [144673] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Roll chromium DEPS 185662 -> 185963
Roll roll roll the deps
Gently from downstream.
Merrily merrily merrily merrily
Green bots are but a dream.
- DEPS:
- 2:08 PM Changeset in webkit [144672] by
-
- 10 edits in trunk/Source/WebKit2
Add API to allow WK2 clients to query the list of installed plug-ins.
https://bugs.webkit.org/show_bug.cgi?id=111245
Reviewed by Alexey Proskuryakov.
Add API in WKContext, implemented by WebContext, that allows callers to register a callback
retrieve an array containing installed plugin information. This API is exposed through WebContext
because it owns the PluginInfoStore used to fulfill the request.
Bump the WKContextClient API by 1:
- Shared/APIClientTraits.cpp:
- Shared/APIClientTraits.h:
- UIProcess/API/C/WKContext.h:
Add a client protocol to PluginInfoStore to notify the client when plugIn information has been
successfully loaded:
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::PluginInfoStore): Initialize m_client to 0.
(WebKit::PluginInfoStore::loadPluginsIfNecessary): If the client is present, notify after loading the plugin store.
- UIProcess/Plugins/PluginInfoStore.h:
(WebKit::PluginInfoStoreClient::~PluginInfoStoreClient): Default destructor.
(WebKit::PluginInfoStoreClient::PluginInfoStoreClient): Default constructor.
(WebKit::PluginInfoStore::setClient): Simple setter.
(WebKit::PluginInfoStore::client): Simple getter.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext): Set self as the client of PluginInfoStore.
(WebKit::WebContext::~WebContext): Clear the client of PluginInfoStore.
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins): Pass the callback to own client.
- UIProcess/WebContext.h:
- UIProcess/WebContextClient.cpp:
(WebKit::WebContextClient::plugInInformationBecameAvailable): Pass the callback to the registered WK callback, if present.
- UIProcess/WebContextClient.h:
- 2:05 PM Changeset in webkit [144671] by
-
- 9 edits in trunk/Source/WebCore
Small BlobResourceHandle cleanup
https://bugs.webkit.org/show_bug.cgi?id=111352
Reviewed by Sam Weinig.
- Don't use PassRefPtr<BlobStorageData> when ownership is not being passed.
- Added OVERRIDE to some functions.
- Added const to ResourceHandle::firstRequest().
- platform/network/BlobRegistryImpl.cpp:
(WebCore::loadResourceSynchronously):
(WebCore::BlobRegistryImpl::createResourceHandle):
(WebCore::BlobRegistryImpl::getBlobDataFromURL):
- platform/network/BlobRegistryImpl.h:
(BlobRegistryImpl):
- platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::createAsync):
(WebCore::BlobResourceHandle::loadResourceSynchronously):
- platform/network/BlobResourceHandle.h:
(BlobResourceHandle):
- platform/network/FormData.cpp:
(WebCore::appendBlobResolved):
- platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::firstRequest):
- platform/network/ResourceHandle.h:
(ResourceHandle):
- 1:54 PM Changeset in webkit [144670] by
-
- 17 edits in trunk/Source/WebKit2
PDFPlugin: Hook up Services
https://bugs.webkit.org/show_bug.cgi?id=111246
<rdar://problem/13062672>
Reviewed by Alexey Proskuryakov.
Make the Application->Services menu work when the focused selection is a PDFPlugin.
- Shared/EditorState.cpp:
(WebKit::EditorState::encode):
(WebKit::EditorState::decode):
- Shared/EditorState.h:
(WebKit::EditorState::EditorState):
(EditorState):
Add isInPlugin property to EditorState.
- UIProcess/API/mac/WKView.mm:
(-[WKView validRequestorForSendType:returnType:]):
If the selection is currently in a Plugin, we only currently have the ability
to retrieve the selection as a plain-text string, so restrict sendType to NSStringPboardType.
- WebProcess/Plugins/PDF/SimplePDFPlugin.h:
- WebProcess/Plugins/Plugin.h:
- WebProcess/Plugins/PluginView.h:
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
Add getStringSelection.
- WebProcess/Plugins/PDF/PDFLayerControllerDetails.h:
Add pdfLayerController:didChangeSelection: delegate method.
- WebProcess/Plugins/PDF/PDFPlugin.h:
(PDFPlugin):
Add getStringSelection and notifySelectionChanged.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFLayerControllerDelegate pdfLayerController:didChangeSelection:]):
Forward selection change notifications to our PDFPlugin.
(WebKit::PDFPlugin::notifySelectionChanged):
Forward selection change notifications to our WebPage.
(WebKit::PDFPlugin::getStringSelection):
Retrieve PDFLayerController's selection as a plain text string.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::countFindMatches):
(WebKit::PluginView::findString):
Drive-bys, check for existance and initialization of the plugin before using it.
(WebKit::PluginView::getStringSelection): Added.
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
Use didChangeSelection instead of sending the EditorStateChanged message directly.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):
If a plugin is focused and has a selection, return a EditorState that reflects that.
Since PDFs aren't editable (when editing annotations, the plugin doesn't have focus),
I'm not adding support for the editing-related properties when a plugin has focus.
(WebKit::WebPage::focusedPluginViewForFrame):
(WebKit::WebPage::pluginViewForFrame):
Make these class methods instead of static functions so we can use them from
WebPageMac too, instead of duplicating code there.
(WebKit::WebPage::didChangeSelection): Added.
- WebProcess/WebPage/WebPage.h:
Add didChangeSelection and [focused]PluginViewForFrame.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::getStringSelectionForPasteboard):
Defer to the focused plugin (if it exists) when retrieving the plain-text selection.
- 1:54 PM Changeset in webkit [144669] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Introduce WebInspector.EventTarget interface for interfaces that dispatch events.
https://bugs.webkit.org/show_bug.cgi?id=111320
Reviewed by Pavel Feldman.
- inspector/front-end/Object.js:
(WebInspector.EventTarget):
(WebInspector.EventTarget.prototype.addEventListener):
(WebInspector.EventTarget.prototype.removeEventListener):
(WebInspector.EventTarget.prototype.removeAllListeners):
(WebInspector.EventTarget.prototype.hasEventListeners):
(WebInspector.EventTarget.prototype.dispatchEventToListeners):
- inspector/front-end/ResourceScriptMapping.js:
- inspector/front-end/UISourceCode.js:
- inspector/front-end/Workspace.js:
(WebInspector.ProjectDelegate.prototype.searchInFileContent):
- 1:47 PM Changeset in webkit [144668] by
-
- 8 edits in trunk/Source
Remove contextInternalContext from JSContextInternal.h
https://bugs.webkit.org/show_bug.cgi?id=111356
Reviewed by Geoffrey Garen.
We don't need it any more since we have globalContextRef in JSContext.
Source/JavaScriptCore:
- API/JSContext.mm:
- API/JSContextInternal.h:
- API/JSValue.mm:
(+[JSValue valueWithBool:inContext:]):
(+[JSValue valueWithDouble:inContext:]):
(+[JSValue valueWithInt32:inContext:]):
(+[JSValue valueWithUInt32:inContext:]):
(+[JSValue valueWithNewObjectInContext:]):
(+[JSValue valueWithNewArrayInContext:]):
(+[JSValue valueWithNewRegularExpressionFromPattern:flags:inContext:]):
(+[JSValue valueWithNewErrorFromMessage:inContext:]):
(+[JSValue valueWithNullInContext:]):
(+[JSValue valueWithUndefinedInContext:]):
(-[JSValue toBool]):
(-[JSValue toDouble]):
(-[JSValue toNumber]):
(-[JSValue toString]):
(-[JSValue toDate]):
(-[JSValue toArray]):
(-[JSValue toDictionary]):
(-[JSValue valueForProperty:]):
(-[JSValue setValue:forProperty:]):
(-[JSValue deleteProperty:]):
(-[JSValue hasProperty:]):
(-[JSValue valueAtIndex:]):
(-[JSValue setValue:atIndex:]):
(-[JSValue isUndefined]):
(-[JSValue isNull]):
(-[JSValue isBoolean]):
(-[JSValue isNumber]):
(-[JSValue isString]):
(-[JSValue isObject]):
(-[JSValue isEqualToObject:]):
(-[JSValue isEqualWithTypeCoercionToObject:]):
(-[JSValue isInstanceOf:]):
(-[JSValue callWithArguments:]):
(-[JSValue constructWithArguments:]):
(-[JSValue invokeMethod:withArguments:]):
(valueToObject):
(objectToValueWithoutCopy):
(objectToValue):
(-[JSValue initWithValue:inContext:]):
(-[JSValue dealloc]):
(-[JSValue description]):
- API/JSWrapperMap.mm:
(createObjectWithCustomBrand):
(-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]):
(-[JSObjCClassInfo wrapperForObject:]):
(-[JSWrapperMap jsWrapperForObject:]):
- API/ObjCCallbackFunction.mm:
(ObjCCallbackFunction::call):
(objCCallbackFunctionForInvocation):
Source/WebKit/mac:
- WebView/WebScriptWorld.mm:
(+[WebScriptWorld scriptWorldForJavaScriptContext:]):
- 1:44 PM Changeset in webkit [144667] by
-
- 3 edits2 adds in trunk
XSSAuditor bypass with --> comment syntax.
https://bugs.webkit.org/show_bug.cgi?id=111349
Reviewed by Adam Barth.
Source/WebCore:
Test: http/tests/security/xssAuditor/open-iframe-src-03.html
- html/parser/XSSAuditor.cpp:
(WebCore::isTerminatingCharacter):
Adds ">" to the list of terminating characters, so that comments of
the form --> end the snippet we seek to match.
LayoutTests:
- http/tests/security/xssAuditor/open-iframe-src-03-expected.txt: Added.
- http/tests/security/xssAuditor/open-iframe-src-03.html: Added.
- 1:42 PM Changeset in webkit [144666] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Modal dialogs sometimes lose focus.
https://bugs.webkit.org/show_bug.cgi?id=111317
Reviewed by Pavel Feldman.
setCurrentFocusElement doesn't give focus to an element anymore
if modal glass pane is shown and element is not inside it.
- inspector/front-end/Dialog.js:
(WebInspector.Dialog):
(WebInspector.Dialog.prototype._hide):
- inspector/front-end/InspectorView.js:
(WebInspector.InspectorView.prototype.defaultFocusedElement):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.defaultFocusedElement):
- inspector/front-end/UIUtils.js:
(WebInspector.GlassPane):
(WebInspector.GlassPane.prototype.dispose):
(WebInspector.setCurrentFocusElement):
- inspector/front-end/dialog.css:
- 1:39 PM Changeset in webkit [144665] by
-
- 1 edit3 copies in branches/chromium/1410
Merge 144196
REGRESSION (r134631) of border-radius percentage with border pixel
https://bugs.webkit.org/show_bug.cgi?id=110889
Reviewed by Simon Fraser.
Source/WebCore:
Fixing background color filling to handle "non renderable" rounded
rectangles.
Test: fast/borders/border-radius-percent.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
LayoutTests:
Adding new pixel test to verify the correct rendering of
rounded rectangle backgrounds with inner border radii that
exceed the dimensions of the inner edge of the border.
- fast/borders/border-radius-percent-expected.txt: Added.
- fast/borders/border-radius-percent.html: Added.
- platform/chromium-linux/fast/borders/border-radius-percent-expected.png: Added.
- platform/chromium/TestExpectations:
TBR=junov@google.com
Review URL: https://codereview.chromium.org/12390064
- 1:38 PM Changeset in webkit [144664] by
-
- 12 edits2 adds in trunk
[WK2][EFL] Add callbacks to the WKViewClient to handle Web Process crash and relaunch
https://bugs.webkit.org/show_bug.cgi?id=109828
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Providing WKViewClient with Web Process crash and Web Process relaunch
callbacks brings better design as WebView should not be aware of
EFL-specific code handling the corresponding events.
The implementation of the mentioned Web Process callbacks was also added.
- UIProcess/API/C/efl/WKView.cpp:
(WKViewSetThemePath):
- UIProcess/API/C/efl/WKView.h:
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::webProcessCrashed):
(WebKit):
(WebKit::ViewClientEfl::webProcessDidRelaunch):
(WebKit::ViewClientEfl::ViewClientEfl):
- UIProcess/efl/ViewClientEfl.h:
(ViewClientEfl):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::setThemePath):
Accepts WTF::String instead of WKStringRef as it is
more appropriate for C++ API implementation class.
(WebKit::WebView::processDidCrash):
(WebKit::WebView::didRelaunchProcess):
- UIProcess/efl/WebView.h:
(WebView):
- UIProcess/efl/WebViewClient.cpp:
(WebKit::WebViewClient::webProcessCrashed):
(WebKit):
(WebKit::WebViewClient::webProcessDidRelaunch):
- UIProcess/efl/WebViewClient.h:
Tools:
Added API test for newly added Web Process crash and Web Process relaunch WKViewClient
callbacks.
- TestWebKitAPI/CMakeLists.txt:
Tests located in 'TestWebKitAPI/Tests/WebKit2' subdirectories are also
considered.
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::webProcessCrashed):
(TestWebKitAPI::webProcessDidRelaunch):
(TestWebKitAPI::setViewClient):
(TestWebKitAPI::TEST):
- 1:16 PM Changeset in webkit [144663] by
-
- 5 edits in trunk/Source
Unreviewed. AppleWin build fix.
- WebKit.vcxproj/FeatureDefines.props:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- WebCore.vcxproj/WebCore.vcxproj:
- 1:11 PM Changeset in webkit [144662] by
-
- 4 edits in trunk/Source
JSC_OBJC_API_ENABLED should be removed from FeatureDefines.h
https://bugs.webkit.org/show_bug.cgi?id=111269
Reviewed by Mark Hahnenberg.
Source/WebKit/mac:
Include JavaScriptCore/JSBase.h for the definition of JSC_OBJC_API_ENABLED.
- WebView/WebDelegateImplementationCaching.h:
Source/WTF:
JSC_OBJC_API_ENABLED flag was added to FeatureDefines.h (r143637)
so that it could be used in WebCore.exp.in to determine whether
or not we should be exporting certain symbols based on whether
the WebKit-related portion of the JSC ObjC API was enabled.
It turned out conditionally including certain symbols didn't
work when building fat binaries, so it's not even necessary any more.
- wtf/FeatureDefines.h: Remove JSC_OBJC_API_ENABLED.
- 1:02 PM Changeset in webkit [144661] by
-
- 4 edits in trunk/Source/WebCore
[v8] add isolate parameter to heap statistics calls
https://bugs.webkit.org/show_bug.cgi?id=111308
Patch by Dan Carney <dcarney@google.com> on 2013-03-04
Reviewed by Jochen Eisinger.
No new tests.
- bindings/v8/ScriptGCEvent.cpp:
(WebCore::ScriptGCEvent::getHeapSize):
(WebCore::ScriptGCEvent::getUsedHeapSize):
- bindings/v8/V8AdaptorFunction.cpp:
(WebCore::V8AdaptorFunction::getTemplate):
- bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::checkMemoryUsage):
- 12:42 PM Changeset in webkit [144660] by
-
- 4 edits in trunk/Source
[chromium] remove deprecated hyphenation methods from Platform
https://bugs.webkit.org/show_bug.cgi?id=111101
Reviewed by Adam Barth.
Source/Platform:
- chromium/public/Platform.h:
(Platform):
Source/WebCore:
- platform/text/chromium/Hyphenation.cpp:
(WebCore::canHyphenate):
(WebCore::lastHyphenLocation):
- 12:33 PM Changeset in webkit [144659] by
-
- 2 edits in trunk/Source/WebKit2
Complete the plug-in URL string before sending it to the UI process
https://bugs.webkit.org/show_bug.cgi?id=111355
<rdar://problem/13326713>
Reviewed by Andreas Kling.
If the URL is not absolute, we won't be able to find it by path extension in the plug-in info store.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
- 12:22 PM Changeset in webkit [144658] by
-
- 5 edits in branches/safari-534.59-branch
<rdar://problem/13337144> - Update 536.29 branch Loader and UI client layouts
Rubberstamped by Anders Carlsson.
Source/WebKit2:
- UIProcess/API/C/WKPage.h:
Tools:
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
- 12:07 PM Changeset in webkit [144657] by
-
- 4 edits3 adds in trunk/Tools
AX: Upstream iOS Accessibility DumpRenderTree changes
https://bugs.webkit.org/show_bug.cgi?id=111220
Reviewed by David Kilzer.
Upstream the iOS changes for accessibility in DumpRenderTree.
- DumpRenderTree/AccessibilityUIElement.cpp:
(headerElementAtIndexCallback):
(linkedElementCallback):
(elementsForRangeCallback):
(increaseTextSelectionCallback):
(decreaseTextSelectionCallback):
(assistiveTechnologySimulatedFocusCallback):
(stringForSelectionCallback):
(getIPhoneLabelCallback):
(getIPhoneHintCallback):
(getIPhoneValueCallback):
(getIPhoneIdentifierCallback):
(getIPhoneTraitsCallback):
(getIPhoneIsElementCallback):
(getIPhoneElementTextPositionCallback):
(getIPhoneElementTextLengthCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
(AccessibilityUIElement):
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/ios: Added.
- DumpRenderTree/ios/AccessibilityControllerIOS.mm: Added.
(AccessibilityController::AccessibilityController):
(AccessibilityController::~AccessibilityController):
(AccessibilityController::elementAtPoint):
(AccessibilityController::focusedElement):
(AccessibilityController::rootElement):
(findAccessibleObjectById):
(AccessibilityController::accessibleElementById):
(AccessibilityController::setLogFocusEvents):
(AccessibilityController::setLogScrollingStartEvents):
(AccessibilityController::setLogValueChangeEvents):
(AccessibilityController::setLogAccessibilityEvents):
(AccessibilityController::addNotificationListener):
(AccessibilityController::removeNotificationListener):
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added.
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):
(concatenateAttributeAndValue):
(AccessibilityUIElement::iphoneLabel):
(AccessibilityUIElement::iphoneHint):
(AccessibilityUIElement::iphoneValue):
(AccessibilityUIElement::iphoneIdentifier):
(AccessibilityUIElement::iphoneTraits):
(AccessibilityUIElement::iphoneIsElement):
(AccessibilityUIElement::iphoneElementTextPosition):
(AccessibilityUIElement::iphoneElementTextLength):
(AccessibilityUIElement::url):
(AccessibilityUIElement::x):
(AccessibilityUIElement::y):
(AccessibilityUIElement::width):
(AccessibilityUIElement::height):
(AccessibilityUIElement::clickPointX):
(AccessibilityUIElement::clickPointY):
(AccessibilityUIElement::getChildren):
(AccessibilityUIElement::getChildrenWithRange):
(AccessibilityUIElement::childrenCount):
(AccessibilityUIElement::elementAtPoint):
(AccessibilityUIElement::indexOfChild):
(AccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElement::headerElementAtIndex):
(AccessibilityUIElement::linkedElement):
(AccessibilityUIElement::linkedUIElementAtIndex):
(AccessibilityUIElement::ariaOwnsElementAtIndex):
(AccessibilityUIElement::ariaFlowToElementAtIndex):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::rowAtIndex):
(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(AccessibilityUIElement::disclosedByRow):
(AccessibilityUIElement::increaseTextSelection):
(AccessibilityUIElement::decreaseTextSelection):
(AccessibilityUIElement::stringForSelection):
(AccessibilityUIElement::stringForRange):
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringRangeIsMisspelled):
(AccessibilityUIElement::elementsForRange):
(AccessibilityUIElement::getLinkedUIElements):
(AccessibilityUIElement::getDocumentLinks):
(AccessibilityUIElement::attributesOfLinkedUIElements):
(AccessibilityUIElement::attributesOfDocumentLinks):
(AccessibilityUIElement::attributesOfChildren):
(AccessibilityUIElement::allAttributes):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::isPressActionSupported):
(AccessibilityUIElement::isIncrementActionSupported):
(AccessibilityUIElement::isDecrementActionSupported):
(AccessibilityUIElement::boolAttributeValue):
(AccessibilityUIElement::isAttributeSettable):
(AccessibilityUIElement::isAttributeSupported):
(AccessibilityUIElement::parameterizedAttributeNames):
(AccessibilityUIElement::role):
(AccessibilityUIElement::subrole):
(AccessibilityUIElement::roleDescription):
(AccessibilityUIElement::title):
(AccessibilityUIElement::description):
(AccessibilityUIElement::orientation):
(AccessibilityUIElement::stringValue):
(AccessibilityUIElement::language):
(AccessibilityUIElement::helpText):
(AccessibilityUIElement::intValue):
(AccessibilityUIElement::minValue):
(AccessibilityUIElement::maxValue):
(AccessibilityUIElement::valueDescription):
(AccessibilityUIElement::insertionPointLineNumber):
(AccessibilityUIElement::isEnabled):
(AccessibilityUIElement::isRequired):
(AccessibilityUIElement::isFocused):
(AccessibilityUIElement::isSelected):
(AccessibilityUIElement::isExpanded):
(AccessibilityUIElement::isChecked):
(AccessibilityUIElement::hierarchicalLevel):
(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):
(AccessibilityUIElement::lineForIndex):
(AccessibilityUIElement::boundsForRange):
(AccessibilityUIElement::attributesOfColumnHeaders):
(AccessibilityUIElement::attributesOfRowHeaders):
(AccessibilityUIElement::attributesOfColumns):
(AccessibilityUIElement::attributesOfRows):
(AccessibilityUIElement::attributesOfVisibleCells):
(AccessibilityUIElement::attributesOfHeader):
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
(AccessibilityUIElement::indexInTable):
(AccessibilityUIElement::rowIndexRange):
(AccessibilityUIElement::columnIndexRange):
(AccessibilityUIElement::cellForColumnAndRow):
(AccessibilityUIElement::selectedTextRange):
(AccessibilityUIElement::assistiveTechnologySimulatedFocus):
(AccessibilityUIElement::setSelectedTextRange):
(AccessibilityUIElement::increment):
(AccessibilityUIElement::decrement):
(AccessibilityUIElement::showMenu):
(AccessibilityUIElement::press):
(AccessibilityUIElement::accessibilityValue):
(AccessibilityUIElement::documentEncoding):
(AccessibilityUIElement::documentURI):
(_accessibilityNotificationCallback):
(AccessibilityUIElement::addNotificationListener):
(AccessibilityUIElement::removeNotificationListener):
(AccessibilityUIElement::isFocusable):
(AccessibilityUIElement::isSelectable):
(AccessibilityUIElement::isMultiSelectable):
(AccessibilityUIElement::isSelectedOptionActive):
(AccessibilityUIElement::isVisible):
(AccessibilityUIElement::isOffScreen):
(AccessibilityUIElement::isCollapsed):
(AccessibilityUIElement::isIgnored):
(AccessibilityUIElement::hasPopup):
(AccessibilityUIElement::takeFocus):
(AccessibilityUIElement::takeSelection):
(AccessibilityUIElement::addSelection):
(AccessibilityUIElement::removeSelection):
(AccessibilityUIElement::uiElementForSearchPredicate):
(AccessibilityUIElement::numberAttributeValue):
- 12:06 PM Changeset in webkit [144656] by
-
- 2 edits in trunk/Source/WebCore
Use initialization from literal for MediaFeatureNames
https://bugs.webkit.org/show_bug.cgi?id=111283
Reviewed by Andreas Kling.
- css/MediaFeatureNames.cpp:
(WebCore::MediaFeatureNames::init):
Initialization from literal is faster and use less memory. The names are
defined statically in MediaFeatureNames.h.
Also use the NotNull placement new to avoid a branch on silly allocators.
- 11:45 AM Changeset in webkit [144655] by
-
- 2 edits in trunk/LayoutTests
(tests) flexbox/resources.css should use unprefixed properties, for firefox
https://bugs.webkit.org/show_bug.cgi?id=111010
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-04
Reviewed by Tony Chang.
Search & replace to remove -moz- prefixes, as per
https://developer.mozilla.org/en-US/docs/CSS/Using_CSS_flexible_boxes:
"Gecko implementation is unprefixed (and is no longer behind a
preference as of Firefox 20)"
- css3/flexbox/resources/flexbox.css:
(.flexbox):
(.inline-flexbox):
(.flex-none):
(.flex-auto):
(.flex-one):
(.row):
(.row-reverse):
(.column):
(.column-reverse):
(.wrap):
(.wrap-reverse):
(.align-content-flex-start):
(.align-content-flex-end):
(.align-content-center):
(.align-content-space-between):
(.align-content-space-around):
(.align-content-stretch):
(.align-items-flex-start):
(.align-items-flex-end):
(.align-items-center):
(.align-items-baseline):
(.align-items-stretch):
(.align-self-auto):
(.align-self-flex-start):
(.align-self-flex-end):
(.align-self-center):
(.align-self-baseline):
(.align-self-stretch):
(.justify-content-flex-start):
(.justify-content-flex-end):
(.justify-content-center):
(.justify-content-space-between):
(.justify-content-space-around):
- 11:44 AM Changeset in webkit [144654] by
-
- 2 edits in trunk/Source/Platform
[chromium] Add ability to wait on async upload completion
https://bugs.webkit.org/show_bug.cgi?id=110987
Reviewed by James Robinson.
Add a graphics context entry point for waiting on asynchronous upload
completion. The wait is performed server-side so the call is
non-blocking.
See https://codereview.chromium.org/12210129/
- chromium/public/WebGraphicsContext3D.h:
(WebKit::WebGraphicsContext3D::waitAsyncTexImage2DCHROMIUM):
- 11:42 AM Changeset in webkit [144653] by
-
- 7 edits in branches/safari-536.29-branch
<rdar://problem/13337144> - Update 536.29 branch Loader and UI client layouts
Reviewed by Anders Carlsson.
Source/WebKit2:
- Shared/APIClientTraits.cpp:
- Shared/APIClientTraits.h:
- UIProcess/API/C/WKPage.h:
Tools:
- MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
- 11:32 AM Changeset in webkit [144652] by
-
- 8 edits in trunk/Source/WebKit2
[GTK] Some WebKit2 GTK+ unit tests are failing in 32 bits bot
https://bugs.webkit.org/show_bug.cgi?id=111346
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-04
Reviewed by Martin Robinson.
The problem is the use of a temporary CString object in the macro
g_assert_cmpstr. It's a common mistake because we usually forget
that g_assert_cmpstr is not a function but a macro, that expands
to multiple lines. This patch adds a new macro ASSERT_CMP_CSTRING
with the same implementation that g_assert_cmpstr, but using
CStrings instead of const char*. It fixes all the cases where a
temporary CString was used in g_assert_cmpstr, and uses the new
macro also for the cases where we were caching the CString just
for g_assert_cmpstr.
- UIProcess/API/gtk/tests/TestDownloads.cpp:
(testDownloadRemoteFile):
- UIProcess/API/gtk/tests/TestInspectorServer.cpp:
(testInspectorServerPageList):
- UIProcess/API/gtk/tests/TestLoaderClient.cpp:
- UIProcess/API/gtk/tests/TestMain.h:
- UIProcess/API/gtk/tests/TestResources.cpp:
- UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:
(testGetFaviconURI):
- UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(assertThatUserAgentIsSentInHeaders):
(testWebKitSettingsUserAgent):
- 11:30 AM Changeset in webkit [144651] by
-
- 29 edits in trunk/Source/WebCore
[V8] Unreviewed. Rebaselined run-bindings-tests following r144617
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
- bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::TestActiveDOMObjectV8Internal::TestActiveDOMObjectDomainSafeFunctionSetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::GetTemplate):
- bindings/scripts/test/V8/V8TestException.h:
(V8TestException):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
- bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
(WebCore::ConfigureV8TestNamedConstructorTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructorConstructor):
(V8TestNamedConstructor):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::ConfigureV8TestNodeTemplate):
(WebCore::V8TestNode::GetTemplate):
- bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::installPerContextPrototypeProperties):
- bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(V8TestOverloadedConstructors):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
- bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
- bindings/scripts/test/V8/V8TestTypedefs.h:
(V8TestTypedefs):
- 11:20 AM Changeset in webkit [144650] by
-
- 2 edits in tags/Safari-537.31.13/Source/WebCore
Merged r144577. <rdar://problem/13328176>
- 11:04 AM Changeset in webkit [144649] by
-
- 4 edits1 delete in trunk/Source
Unreviewed, rolling out r144562.
http://trac.webkit.org/changeset/144562
https://bugs.webkit.org/show_bug.cgi?id=85642
Caused KeyPadInsert faluires in webkit_unittests
Source/WebCore:
- platform/chromium/KeyCodeConversionGtk.cpp:
(WebCore::windowsKeyCodeForKeyEvent):
Source/WebKit/chromium:
- WebKit.gypi:
- tests/KeyCodeConversionTestGtk.cpp: Removed.
- 11:01 AM Changeset in webkit [144648] by
-
- 4 edits in tags/Safari-537.31.13/Source
Versioning.
- 10:59 AM Changeset in webkit [144647] by
-
- 3 edits2 adds in trunk
getComputedStyle not implemented for -webkit-columns shorthand
https://bugs.webkit.org/show_bug.cgi?id=111236
Patch by Uday Kiran <udaykiran@motorola.com> on 2013-03-04
Reviewed by Alexis Menard.
Source/WebCore:
Implement getComputedStyle for -webkit-columns shorthand.
Test: fast/css/getComputedStyle/getComputedStyle-webkit-columns-shorthand.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
LayoutTests:
Add test to check getComputedStyle for -webkit-columns.
- fast/css/getComputedStyle/getComputedStyle-webkit-columns-shorthand-expected.txt: Added.
- fast/css/getComputedStyle/getComputedStyle-webkit-columns-shorthand.html: Added.
- 10:56 AM Changeset in webkit [144646] by
-
- 5 edits in trunk/Source
Add support for 8 bit TextRuns on Chromium Linux & Mac
https://bugs.webkit.org/show_bug.cgi?id=99393
Reviewed by Eric Seidel.
Source/WebCore:
Adding support for 8 bit TextRuns for Mac and Linux Chromium. To accomplish this,
8 bit text runs are upconverted to 16 bit in the complex text path during string
normalization, as HarfBuzz operates on UChars.
Windows has platfom assumptions that TextRuns are 16 bit that need to be addressed
before enabling this optimization.
No new tests. No change in behavior.
(WebCore::HarfBuzzShaperBase::setNormalizedBuffer):
- platform/graphics/harfbuzz/HarfBuzzShaperBase.h:
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::normalizeCharacters):
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
Source/WebKit/chromium:
Enabling 8 bit text runs for Linux and Mac platforms.
- features.gypi:
- 10:50 AM Changeset in webkit [144645] by
-
- 1 copy in tags/Safari-537.31.13
New Tag.
- 10:49 AM Changeset in webkit [144644] by
-
- 5 edits in trunk
transition-property property and transition shorthand property doesn't accept "all, all".
https://bugs.webkit.org/show_bug.cgi?id=111201
Reviewed by Simon Fraser.
Source/WebCore:
Relax the parsing of transition-property to allow all, all as a value.
It is not very useful per say but it is possible by the spec and we
align with Firefox, IE and Opera.
Test: LayoutTests/transitions/transitions-parsing.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseAnimationProperty):
LayoutTests:
Updated the tests to cover the bug.
- transitions/transitions-parsing-expected.txt:
- transitions/transitions-parsing.html:
- 10:34 AM Changeset in webkit [144643] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Add a new dependency on jsr-305 for Android
https://bugs.webkit.org/show_bug.cgi?id=111340
Unreviewed build fix; new Android dependency. This is
currently breaking gyp generation on the Android bots.
- DEPS:
- 10:23 AM Changeset in webkit [144642] by
-
- 2 edits in trunk/Source/WebCore
Don't apply page scale to clipRect if applyPageScaleFactorInCompositor is set to true
https://bugs.webkit.org/show_bug.cgi?id=111229
Patch by Min Qin <qinmin@chromium.org> on 2013-03-04
Reviewed by Simon Fraser.
If applyPageScaleFactorInCompositor is set to true, webcore should use css coordinates.
As a result, we shouldn't apply page scale to clipRect in RenderLayerCompositor.
Layout tests set the flag to false, so we don't have anything to test against.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMap):
- 9:46 AM Changeset in webkit [144641] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add simple vector traits for JSC::Identifier.
<http://webkit.org/b/111323>
Reviewed by Geoffrey Garen.
Identifiers are really just Strings, giving them simple vector traits makes
Vector move them with memcpy() instead of churning the refcounts.
- runtime/Identifier.h:
(WTF):
- 9:41 AM Changeset in webkit [144640] by
-
- 12 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Upstream selection start animation.
https://bugs.webkit.org/show_bug.cgi?id=111335
Patch by Iris Wu <shuwu@rim.com> on 2013-03-04
Reviewed by Rob Buis.
PR 219960
To indicate selection starts, we draw an overlay rect larger than
the selected word at the start of selection. Then shrink it down
to the actual size.
Reviewed Internally by Genevieve Mak and Andrew Lo and Mike Fenton.
- Api/WebAnimation.cpp:
(BlackBerry::WebKit::WebAnimation::shrinkAnimation):
(WebKit):
- Api/WebAnimation.h:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::selectionHighlight):
(WebKit):
- Api/WebPage.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- Api/WebTapHighlight.h:
- WebKitSupport/DefaultTapHighlight.cpp:
(WebKit):
(BlackBerry::WebKit::shrinkAnimationName):
(BlackBerry::WebKit::DefaultTapHighlight::draw):
- WebKitSupport/DefaultTapHighlight.h:
(DefaultTapHighlight):
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::cancelSelection):
(BlackBerry::WebKit::textGranularityFromSelectionExpansionType):
(WebKit):
(BlackBerry::WebKit::SelectionHandler::selectNodeIfFatFingersResultIsLink):
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
- WebKitSupport/SelectionHandler.h:
(SelectionHandler):
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
- 9:29 AM Changeset in webkit [144639] by
-
- 8 edits in trunk
ASSERTION FAILED: m_clipRectsCache->m_respectingOverflowClip[clipRectsType] == (clipRectsContext.respectOverflowClip == RespectOverflowClip) in RenderLayer.
https://bugs.webkit.org/show_bug.cgi?id=108257
Reviewed by David Hyatt.
Source/WebCore:
With composited scrolling we paint both with and without respecting
overflow clip. To prevent collisions in the clip cache, and to prevent
throwing away cached clips unnecessarily, we keep two copies of the
clip cache -- one for when overflow clip is respected, and one for
when it isn't.
No new tests. Covered by existing tests (in debug):
compositing/overflow/automatically-opt-into-composited-scrolling.html
compositing/overflow/composited-scrolling-creates-a-stacking-container.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateClipRects):
No longer asserts that our 'respect overflow clip' status is
consistent. It also gets and sets the clip cache using the clip rect
context rather than just the clip rect type.
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::parentClipRects):
(WebCore::RenderLayer::clearClipRects):
(WebCore::ClipRectsCache::ClipRectsCache):
(WebCore::ClipRectsCache::getClipRects):
(WebCore::ClipRectsCache::setClipRects):
(WebCore::ClipRectsCache::getIndex):
Get and set the cached clip rects using the context rather than
type.
(WebCore::RenderLayer::clipRects):
We now cache twice as many clip rects.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
ShouldRespectOverflowClip was moved out of RenderLayer.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateClipRects):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::parentClipRects):
(WebCore::RenderLayer::clearClipRects):
- rendering/RenderLayer.h:
(WebCore::ClipRectsCache::ClipRectsCache):
(WebCore::ClipRectsCache::getClipRects):
(WebCore::ClipRectsCache::setClipRects):
(ClipRectsCache):
(WebCore::ClipRectsCache::getIndex):
(WebCore::RenderLayer::clipRects):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
LayoutTests:
- platform/efl-wk2/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt-5.0-wk2/TestExpectations:
- 9:24 AM Changeset in webkit [144638] by
-
- 7 edits in trunk/Source
Remove unused return value from SourceBufferPrivate::abort() and WebSourceBuffer::abort().
https://bugs.webkit.org/show_bug.cgi?id=111195
Reviewed by Adam Barth.
Source/WebCore:
No new tests. No user visible behavior changed.
- platform/graphics/SourceBufferPrivate.h:
(SourceBufferPrivate):
Source/WebKit/chromium:
- public/WebSourceBuffer.h:
(WebSourceBuffer):
- src/SourceBufferPrivateImpl.cpp:
(WebKit::SourceBufferPrivateImpl::abort):
- src/SourceBufferPrivateImpl.h:
(SourceBufferPrivateImpl):
- src/WebMediaPlayerClientImpl.cpp:
(WebSourceBufferImpl):
(WebKit::WebSourceBufferImpl::abort):
- 9:16 AM Changeset in webkit [144637] by
-
- 2 edits in trunk/Source/WebCore
[New Multicolumn] Eliminate the unique multicolumn flow thread style creation function
https://bugs.webkit.org/show_bug.cgi?id=111338
Reviewed by Allan Jensen.
There is nothing special about a multi-column flow thread style now, so we can just
use the existing anonymous style creation function.
- rendering/RenderMultiColumnBlock.cpp:
(WebCore):
(WebCore::RenderMultiColumnBlock::addChild):
- 9:06 AM Changeset in webkit [144636] by
-
- 9 edits in trunk/Source/WebCore
[GTK] WebCore::returnString is unsafe and should be removed!
https://bugs.webkit.org/show_bug.cgi?id=110423
Reviewed by Martin Robinson.
Remove returnString() and replace it in callers with a new
function that will cache and return the values of string
properties for ATK interfaces in the private section of the
wrapper AtkObject WebKitAccessible.
- accessibility/atk/WebKitAccessibleUtil.cpp: Remove returnString().
- accessibility/atk/WebKitAccessibleUtil.h: Ditto.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(_WebKitAccessiblePrivate): New private structure to store cached
values of string property for the different ATK interfaces.
(cacheAndReturnAtkProperty): New helper function to make sure the
returned const gchar* value is previously cached in the private
section of the wrapper AtkObject.
(webkitAccessibleGetName): Use the new helper function.
(webkitAccessibleGetDescription): Ditto.
(webkitAccessibleInit): Initialize pointer to private structure.
(webkitAccessibleFinalize): Remove unneeded code.
(webkitAccessibleClassInit): Add private struct to class type/
- accessibility/atk/WebKitAccessibleWrapperAtk.h:
(_WebKitAccessible): New member pointing to the private structure,
made the new helper function cacheAndReturnAtkProperty() available
to external callers (implementation files for ATK interfaces).
(AtkCachedProperty): New enum to allow reusing code when calling
cacheAndReturnAtkProperty() to cache and return different properties.
- accessibility/atk/WebKitAccessibleInterfaceAction.cpp:
(webkitAccessibleActionGetKeybinding): Replace calls to returnString()
with calls to the new helper function cacheAndReturnAtkProperty().
(webkitAccessibleActionGetName): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceDocument.cpp:
(documentAttributeValue): Ditto.
(webkitAccessibleDocumentGetLocale): Ditto.
- accessibility/atk/WebKitAccessibleInterfaceImage.cpp:
(webkitAccessibleImageGetImageDescription): Ditto.
Remove returnString() from WebKitAccessibleHyperlink (which is not
an AtkObject, but a GObject) as well, replacing it in callers with
simple code that will cache and return the required values in the
private section of these kind of objects.
- accessibility/atk/WebKitAccessibleHyperlink.cpp:
(_WebKitAccessibleHyperlinkPrivate): Added two new fields to cache
string values for the key binding and name properties from the
AtkAction interface, which is implemented by AtkHyperlink.
(webkitAccessibleHyperlinkActionGetKeybinding): Cache the string
value for the key binding before returning a const gchar* pointer.
(webkitAccessibleHyperlinkActionGetName): Ditto.
(webkitAccessibleHyperlinkGetURI): Do not cache the URI here, as
this function returns a gchar* that will be owned by the caller.
- 9:04 AM Changeset in webkit [144635] by
-
- 7 edits in trunk/Tools
[chromium] pass all focus handling methods through the WebTestDelegate
https://bugs.webkit.org/show_bug.cgi?id=111328
Reviewed by Nico Weber.
In content_shell, the focus handling is asynchronous. To allow for
switching the focus synchronously between WebViews, we need to intercept
didFocus and didBlur and forward it to the WebTestDelegate.
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestDelegate):
(WebTestRunner::WebTestDelegate::setFocus):
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebTestRunner::WebTestProxy::didFocus):
(WebTestRunner::WebTestProxy::didBlur):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::setWindowIsKey):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::didFocus):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::didBlur):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didFocus):
(WebViewHost::didBlur):
(WebViewHost::setFocus):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 8:50 AM Changeset in webkit [144634] by
-
- 2 edits in trunk/Source/WebCore
[Curl] Compile fix after r144216
https://bugs.webkit.org/show_bug.cgi?id=111305
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-03-04
Reviewed by Brent Fulgham.
- platform/network/curl/ResourceRequest.h:
(WebCore::ResourceRequest::cfURLRequest): Added new parameter.
- 8:43 AM Changeset in webkit [144633] by
-
- 5 edits2 adds in trunk
[New Multicolumn] Make sure region styling works for columns inside regions.
https://bugs.webkit.org/show_bug.cgi?id=111276
Reviewed by Sam Weinig.
Source/WebCore:
Test: fast/regions/region-styling-in-columns.html
- rendering/RenderFlowThread.cpp:
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):
- rendering/RenderFlowThread.h:
(CurrentRenderFlowThreadMaintainer):
Fix the CurrentRenderFlowThreadMaintainer so that it saves off the old render flow thread
and restores it when done. This effectively makes flow thread layout a push/pop stack,
since with in-flow threads, this is allowed. We assert that a nested flow thread is
in-flow to preserve the invariant that you can't nest CSS Regions flow thread.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::computeChildrenStyleInRegion):
Add isInFlowRenderFlowThread() to the anonymous check to make sure a style gets made
for the nested flow thread.
LayoutTests:
- fast/regions/region-style-in-columns-expected.html: Added.
- fast/regions/region-style-in-columns.html: Added.
- 8:36 AM Changeset in webkit [144632] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: WebInspector.AceTextEditor throws a warning
https://bugs.webkit.org/show_bug.cgi?id=111315
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-04
Reviewed by Pavel Feldman.
Add WebInspector.AceTextEditor to externs.js to suppress closure
compilation warning.
No new tests: no change in behaviour.
- inspector/front-end/externs.js:
(WebInspector.AceTextEditor):
- 8:22 AM Changeset in webkit [144631] by
-
- 4 edits in trunk/Source/WebCore
Fix debug build under certain configurations, cause was
http://trac.webkit.org/changeset/144624.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):
- inspector/InspectorLayerTreeAgent.h:
(WebCore):
(WebCore::InspectorLayerTreeAgent::create):
(InspectorLayerTreeAgent):
- 8:22 AM Changeset in webkit [144630] by
-
- 2 edits in trunk/Source/WTF
Deque: Free internal buffer in clear().
<http://webkit.org/b/111316>
<rdar://problem/13336675>
Reviewed by Antti Koivisto.
525 kB progression on Membuster3.
- wtf/Deque.h:
(WTF::::clear):
- 8:21 AM Changeset in webkit [144629] by
-
- 37 edits4 copies76 adds in trunk/LayoutTests
[Qt][WK2] Unreviewed gardening. Updated platform specific expected files and png results.
- platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
- platform/qt-5.0-wk2/css3/compositing/effect-background-blend-mode-expected.png: Added.
- platform/qt-5.0-wk2/css3/compositing/effect-background-blend-mode-expected.txt: Added.
- platform/qt-5.0-wk2/css3/filters/composited-reflected-expected.png:
- platform/qt-5.0-wk2/css3/filters/composited-reflected-expected.txt: Added.
- platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png:
- platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.txt: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
- platform/qt-5.0-wk2/fast/clip/overflow-border-radius-composited-expected.png: Added.
- platform/qt-5.0-wk2/fast/clip/overflow-border-radius-composited-expected.txt: Added.
- platform/qt-5.0-wk2/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/vertical-rl/float-multicol-expected.txt: Added.
- platform/qt-5.0-wk2/fast/overflow/position-fixed-transform-clipping-expected.png: Added.
- platform/qt-5.0-wk2/fast/overflow/position-fixed-transform-clipping-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-in-regions-expected.png:
- platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/reflection-repaint-test-expected.png:
- platform/qt-5.0-wk2/fast/repaint/reflection-repaint-test-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/region-painting-invalidation-expected.png:
- platform/qt-5.0-wk2/fast/repaint/region-painting-invalidation-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/region-painting-via-layout-expected.png:
- platform/qt-5.0-wk2/fast/repaint/region-painting-via-layout-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-absolute-layer-with-reflection-expected.png:
- platform/qt-5.0-wk2/fast/repaint/scroll-absolute-layer-with-reflection-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png:
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.png:
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png:
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-reflected-layer-expected.png:
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-reflected-layer-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png:
- platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
- platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.txt: Added.
- platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.png: Added.
- platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.txt: Added.
- platform/qt-5.0-wk2/fast/ruby/position-after-expected.png: Added.
- platform/qt-5.0-wk2/fast/ruby/position-after-expected.txt: Added.
- platform/qt-5.0-wk2/fast/table/border-collapsing/004-vertical-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/border-collapsing/004-vertical-expected.txt: Added.
- platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
- platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
- platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
- platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
- platform/qt-5.0-wk2/svg/custom/visibility-override-filter-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png.
- platform/qt-5.0-wk2/svg/custom/visibility-override-filter-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.txt: Added.
- platform/qt-5.0-wk2/svg/filters/big-sized-filter-2-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/big-sized-filter-2-expected.txt: Added.
- platform/qt-5.0-wk2/svg/filters/filterRes1-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png.
- platform/qt-5.0-wk2/svg/filters/filterRes1-expected.txt: Added.
- platform/qt-5.0-wk2/svg/filters/filterRes3-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png.
- platform/qt-5.0-wk2/svg/filters/filterRes3-expected.txt: Added.
- platform/qt-5.0-wk2/svg/filters/parent-children-with-same-filter-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png.
- platform/qt-5.0-wk2/svg/filters/parent-children-with-same-filter-expected.txt: Added.
- platform/qt-5.0-wk2/svg/filters/shadow-on-filter-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/shadow-on-filter-expected.txt: Added.
- platform/qt-5.0-wk2/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
- platform/qt-5.0-wk2/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
- platform/qt-5.0-wk2/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
- platform/qt-5.0-wk2/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Added.
- platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.png:
- platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt: Added.
- 8:04 AM Changeset in webkit [144628] by
-
- 2 edits in trunk/Tools
[GTK] No need to manually add system paths to jhbuildrc
https://bugs.webkit.org/show_bug.cgi?id=110850
Reviewed by Gustavo Noronha Silva.
- gtk/jhbuildrc: Remove calls to addpath() for items that jhbuild
already takes care of.
- 7:53 AM Changeset in webkit [144627] by
-
- 2 edits in trunk/Source/WebCore
[Qt] REGRESSION(r141240) Crash in PluginPackage::fetchInfo
https://bugs.webkit.org/show_bug.cgi?id=111322
Reviewed by Simon Hausmann.
Do not try to load blacklisted plugins.
- plugins/qt/PluginPackageQt.cpp:
(WebCore::PluginPackage::fetchInfo):
- 7:09 AM Changeset in webkit [144626] by
-
- 15 edits in trunk
transition properties can't be found in CSSStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=110011
Reviewed by Antti Koivisto.
Source/WebCore:
The previous approach for handling the unprefixing was to alias the
unprefixed properties with the prefixed ones in CSSPropertyNames.in.
Unfortunately it will alias the properties in the parsing code which will just
identically parse the two versions. This means that when we populate StylePropertySet
we do not have information whether we just parsed the prefixed, the
unprefixed properties or we parsed both. The patch takes another
approach by creating two distinct sets of properties (unprefixed and
prefixed). Each properties have their own id and we now handle them in
the parsing code as disctints properties and add both versions to the
declared style. In order to avoid properties getting out of sync,
this patch adds few facilities to StylePropertySet to update the
prefixed and the unprefixed entries. Finally the style resolution
happens only for the prefixed version (to limit the size of this patch)
and the unprefixed versions are not resolved. This is to avoid creating
the animation objects twice for the resolved style.
Test : transitions/transitions-parsing.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::addPropertyWithPrefixingVariant): Always add the
prefixed and the unprefixed property even if only one is specified.
(WebCore):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTransitionShorthand): Add both prefixed and
unprefixed longhands to the declarated style.
(WebCore::CSSParser::parseAnimationProperty):
- css/CSSParser.h:
(CSSParser):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSProperty.h:
(WebCore:: prefixingVariantForPropertyId): This function takes a given
property id and returns its prefixed or unprefixed id if it exists. If
not it returns the same id.
(WebCore):
- css/CSSPropertyNames.in:
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::removeProperty): Remove
also the prefixed or unprefixed shorthand if it exists.
(WebCore):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet:: appendPrefixingVariantProperty):
(WebCore::StylePropertySet::setPrefixingVariantProperty): If it
exists a unprefixed or prefixed counterpart of the property we're
trying to set, then we update the other one.
(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::mergeAndOverrideOnConflict):
- css/StylePropertySet.h:
(StylePropertySet):
- css/StylePropertyShorthand.cpp:
(WebCore::transitionShorthand):
(WebCore):
(WebCore::shorthandForProperty): Define the transitions unprefixed
longhands.
- css/StylePropertyShorthand.h:
(WebCore):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty): StyleBuilder will handle the
resolution and the creation of the animations for the style. As the
declarated style now contains declarations for the prefixed and
unprefixed property we do not want to resolve two times and create duplicate animations.
Therefore when we try to resolve the unprefixed version we just bail out.
LayoutTests:
Updated layout test to cover the bug.
- transitions/transitions-parsing-expected.txt:
- transitions/transitions-parsing.html:
- 7:07 AM Changeset in webkit [144625] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: CPU Flame Chart: reveal profiler DataGrid node when user clicks on a FlameChart item.
https://bugs.webkit.org/show_bug.cgi?id=111309
Reviewed by Yury Semikhatsky.
- inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileView.prototype._revealProfilerNode):
- inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._onClick):
- 6:07 AM Changeset in webkit [144624] by
-
- 7 edits4 deletes in trunk
Web Inspector: remove existing LayerTreeAgent protocol APIs
https://bugs.webkit.org/show_bug.cgi?id=111251
Source/WebCore:
In order to eventually provide a more useful API for the LayerTreeAgent
that will be done in followup bugs, we remove the current API exposed by
the agent providing a clean slate that will make future patches easier
to read. Additionally, we remove the "childLayers" property on the Layer
object since we will no longer be providing a hierarchy of layers, but
rather a flat list of layers attached to a node and its descendants.
No new tests since we're removing the APIs exposed by the LayerTreeAgent.
Subsequent patches will add tests as new APIs are added.
Reviewed by Timothy Hatcher.
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorDOMAgent.h:
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
- inspector/InspectorLayerTreeAgent.h:
(InspectorLayerTreeAgent):
LayoutTests:
Remove existing tests since they're testing API that we're
removing.
Reviewed by Timothy Hatcher.
- inspector-protocol/layer-tree-expected.txt: Removed.
- inspector-protocol/layer-tree-generated-content-expected.txt: Removed.
- inspector-protocol/layer-tree-generated-content.html: Removed.
- inspector-protocol/layer-tree.html: Removed.
- 5:54 AM Changeset in webkit [144623] by
-
- 5 edits in trunk
MediaStream.ended must return true when it is created with ended tracks.
https://bugs.webkit.org/show_bug.cgi?id=111293
Reviewed by Kentaro Hara.
Source/WebCore:
Spec: http://dev.w3.org/2011/webrtc/editor/getusermedia.html#MediaStream-ended
When a MediaStream object is created, its ended attribute must be set to false,
unless it is being created using the MediaStream() constructor whose arguments
are lists of MediaStreamTrack objects that are all ended, in which case the
MediaStream object must be created with its ended attribute set to true.
Test: fast/mediastream/MediaStreamConstructor.html
- platform/mediastream/MediaStreamDescriptor.h:
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):
LayoutTests:
- fast/mediastream/MediaStreamConstructor-expected.txt:
- fast/mediastream/MediaStreamConstructor.html:
- 5:34 AM Changeset in webkit [144622] by
-
- 3 edits2 adds in trunk
Web Inspector: Adding new rules broken if a <style> tag is added to document dynamically
https://bugs.webkit.org/show_bug.cgi?id=111299
Reviewed by Pavel Feldman.
Source/WebCore:
The CSSStyleSheet instance should be retrieved directly from the HTMLStyleElement just created,
not from the document.styleSheets list.
Test: inspector/styles/add-new-rule-with-style-after-body.html
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
LayoutTests:
- inspector/styles/add-new-rule-with-style-after-body-expected.txt: Added.
- inspector/styles/add-new-rule-with-style-after-body.html: Added.
- 5:15 AM Changeset in webkit [144621] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Unreviewed. Fix for closure type annotations.
- inspector/front-end/FlameChart.js:
- 5:07 AM Changeset in webkit [144620] by
-
- 4 edits in trunk/Source/WebCore
[EFL] Build fix when compiling with GLES2 support enabled.
https://bugs.webkit.org/show_bug.cgi?id=111291
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-04
Reviewed by Kenneth Rohde Christiansen.
This patch fixes build issues when compiling with GLES2
support. As part of the fix the patch removes Evas specific
workaround of using GLX with EGL in PlatformContext as GLES2
is the main target with EGL.
- platform/graphics/OpenGLESShims.h:
- platform/graphics/opengl/GLPlatformContext.cpp:
(WebCore::GLCurrentContextWrapper::GLCurrentContextWrapper):
- platform/graphics/texmap/TextureMapper.h:
- 5:00 AM Changeset in webkit [144619] by
-
- 2 edits in trunk/Tools
[chromium] TestWebKitAPI WTF.StringHasher_addCharacters is broken on Chromium Android
https://bugs.webkit.org/show_bug.cgi?id=111284
Disabling the failing two tests on Android.
Reviewed by Jochen Eisinger.
- TestWebKitAPI/Tests/WTF/StringHasher.cpp:
(TestWebKitAPI):
(TestWebKitAPI::TEST):
- 4:39 AM Changeset in webkit [144618] by
-
- 9 edits2 adds in trunk/Source/WebCore
Web Inspector: implement Flame Chart for CPU profiler.
https://bugs.webkit.org/show_bug.cgi?id=111162
Reviewed by Yury Semikhatsky.
It is an initial implementation. The next step is to provide
function names and other stats about the hovered item.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- inspector/compile-front-end.py:
- inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileView.prototype._getCPUProfileCallback):
- inspector/front-end/FlameChart.js: Added.
(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype.findNodeCallback):
(WebInspector.FlameChart.prototype._coordinatesToNode):
(WebInspector.FlameChart.prototype.onResize):
(WebInspector.FlameChart.prototype._rootNodes):
(WebInspector.FlameChart.prototype.draw):
(WebInspector.FlameChart.prototype._drawNode):
(WebInspector.FlameChart.prototype._forEachNode):
(WebInspector.FlameChart.prototype._drawBar):
(WebInspector.FlameChart.prototype.update):
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/flameChart.css: Added.
(.flame-chart):
- 4:26 AM Changeset in webkit [144617] by
-
- 25 edits in trunk/Source/WebCore
[V8] Add a "context type" parameter to GetTemplate and ConfigureV8SomethingTemplate functions
https://bugs.webkit.org/show_bug.cgi?id=110875
The parameter will later be used for generating specialized V8
bindings for the 3 different world types (main world, isolated
work, worker).
Patch by Marja Hölttä <marja@chromium.org> on 2013-03-04
Reviewed by Kentaro Hara.
No new tests (no changes in behavior yet).
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateDomainSafeFunctionSetter):
(GenerateNormalAttrGetter):
(GenerateNamedConstructor):
(GenerateImplementation):
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
- bindings/v8/DOMDataStore.h:
(DOMDataStore):
- bindings/v8/DOMWrapperWorld.cpp:
(WebCore):
(WebCore::DOMWrapperWorld::setInitializingWindow):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::contextHasCorrectPrototype):
- bindings/v8/DOMWrapperWorld.h:
(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::getWorld):
- bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
- bindings/v8/PageScriptDebugServer.cpp:
(WebCore::retrieveFrameWithGlobalObjectCheck):
- bindings/v8/V8AdaptorFunction.cpp:
(WebCore::V8AdaptorFunction::getTemplate):
(WebCore::V8AdaptorFunction::wrap):
- bindings/v8/V8AdaptorFunction.h:
(V8AdaptorFunction):
- bindings/v8/V8Binding.cpp:
(WebCore::toDOMWindow):
(WebCore::toScriptExecutionContext):
(WebCore::worldType):
(WebCore):
(WebCore::worldTypeInMainThread):
- bindings/v8/V8Binding.h:
(WebCore):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::clearForNavigation):
(WebCore::V8DOMWindowShell::installDOMWindow):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::createWrapper):
- bindings/v8/V8Initializer.cpp:
(WebCore::findFrame):
- bindings/v8/V8PerContextData.cpp:
(WebCore::V8PerContextData::constructorForTypeSlowCase):
- bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::controllerForContext):
- bindings/v8/WrapperTypeInfo.h:
(WebCore::WrapperTypeInfo::getTemplate):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::eventAttrGetterCustom):
(WebCore::V8DOMWindow::eventAttrSetterCustom):
(WebCore::V8DOMWindow::toStringMethodCustom):
(WebCore::V8DOMWindow::namedSecurityCheck):
(WebCore::V8DOMWindow::indexedSecurityCheck):
(WebCore::toV8):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::wrapInShadowObject):
- bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::V8HTMLImageElementConstructor::GetTemplate):
- bindings/v8/custom/V8HTMLImageElementConstructor.h:
(V8HTMLImageElementConstructor):
- bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::createInjectedScriptHostV8Wrapper):
(WebCore::InjectedScriptManager::canAccessInspectedWindow):
- bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::initMessageEventMethodCustom):
- 4:13 AM Changeset in webkit [144616] by
-
- 2 edits in trunk/LayoutTests
2013-03-04 Kinuko Yasuda <kinuko@chromium.org>
[Chromium] Unreviewed, removing failure test expectations for passing tests.
- platform/chromium/TestExpectations:
- 3:45 AM Changeset in webkit [144615] by
-
- 6 edits9 adds in trunk/Source
Web Inspector: add Ace editor experiment
https://bugs.webkit.org/show_bug.cgi?id=111191
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-04
Reviewed by Pavel Feldman.
Source/WebCore:
No new tests.
Add Ace text editor experiment.
- WebCore.gypi:
- inspector/front-end/AceTextEditor.js: Added.
- inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
- inspector/front-end/ace/ace.js: Added.
- inspector/front-end/ace/acedevtools.css: Added.
- inspector/front-end/ace/mode_css.js: Added.
- inspector/front-end/ace/mode_html.js: Added.
- inspector/front-end/ace/mode_javascript.js: Added.
- inspector/front-end/ace/theme_textmate.js: Added.
- inspector/front-end/ace/LICENSE.txt: Added.
Source/WebKit/chromium:
Add target to concatenate js files for Ace Text Editor.
- WebKit.gyp:
- 3:40 AM Changeset in webkit [144614] by
-
- 22 edits in trunk
Add build flag for FontLoader
https://bugs.webkit.org/show_bug.cgi?id=111289
Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-04
Reviewed by Benjamin Poulain.
Add ENABLE_FONT_LOAD_EVENTS build flag (disabled by default).
.:
- Source/autotools/SetupWebKitFeatures.m4:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/chromium:
- features.gypi:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
- 3:25 AM Changeset in webkit [144613] by
-
- 4 edits2 adds in trunk
XSSAuditor should strip dangerous attributes from SMIL animation elements.
https://bugs.webkit.org/show_bug.cgi?id=111071
Reviewed by Adam Barth.
Source/WebCore:
SMIL animation elements can, amusingly enough, animate the 'href' of a
link. This patch teaches XSSAuditor how to deal with the
semicolon-separated 'animation[values]' attribute in order to ensure
that it doesn't contain JavaScript URLs that could be animated into
place for an unsuspecting user to click on.
Test: http/tests/security/xssAuditor/svg-animate.html
- html/parser/XSSAuditor.cpp:
(WebCore::isSemicolonSeparatedAttribute): Added.
This returns true if the given attribute is SVGNames::valuesAttr,
but makes it possible to easily extend the list with additional
attributes with this strange property.
(WebCore::semicolonSeparatedValueContainsJavaScriptURL): Added.
Given a semicolon-separated string, determine if it contains any
JavaScript URLs.
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
When looking for dangerousness, determine whether or not we should
be comparing against each member of a semicolon-separated list.
LayoutTests:
- http/tests/security/xssAuditor/resources/echo-intertag.pl:
Add a new mode that dumps an element and its attributes, which is a
bit more robust than adding a new mode for each attribute type we're
interested in.
- http/tests/security/xssAuditor/svg-animate-expected.txt: Added.
- http/tests/security/xssAuditor/svg-animate.html: Added.
- 3:09 AM Changeset in webkit [144612] by
-
- 1 edit16 adds in trunk/Source/WebCore
[BlackBerry] New files for BlackBerry::Platform::Graphics::GraphicsContext integration
https://bugs.webkit.org/show_bug.cgi?id=111153
Reviewed by Rob Buis.
BlackBerry PR 293208
This patch contains contributions from many members of the BlackBerry
WebKit team:
Rob Buis
Robin Cao
Eli Fidler
Mike Lattanzio
Yong Li
Maxim Mogilnitsky
Joshua Netterfield
Arvid Nilsson
Jakob Petsovits
Konrad Piascik
Jeff Rogers
Artem Simonov
Filip Spacek
George Staikos
Covered by existing tests.
- platform/graphics/blackberry/FontBlackBerry.cpp: Added.
(FSFixedToFloat):
(FloatToFSFixed):
(WebCore):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::drawGlyphs):
(WebCore::Font::canReturnFallbackFontsForComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::canExpandAroundIdeographsInComplexText):
- platform/graphics/blackberry/FontCacheBlackBerry.cpp: Added.
(WebCore):
(WebCore::FontCache::platformInit):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::getTraitsInFamily):
(WebCore::getFamilyNameStringFromFontDescriptionAndFamily):
(WebCore::fontWeightToFontconfigWeight):
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/blackberry/FontCustomPlatformData.h: Added.
(WebCore):
(FontCustomPlatformData):
- platform/graphics/blackberry/FontCustomPlatformDataBlackBerry.cpp: Added.
(WebCore):
(WebCore::FontCustomPlatformData::FontCustomPlatformData):
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::FontCustomPlatformData::supportsFormat):
(WebCore::createFontCustomPlatformData):
- platform/graphics/blackberry/FontPlatformDataBlackBerry.cpp: Added.
(WebCore):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::~FontPlatformData):
(WebCore::FontPlatformData::name):
(WebCore::FontPlatformData::applyState):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):
(WebCore::FontPlatformData::platformIsEqual):
(WebCore::FontPlatformData::description):
(WebCore::FontPlatformData::harfbuzzFace):
(WebCore::FontPlatformData::scaledFont):
(WebCore::FontPlatformData::setFakeBold):
(WebCore::FontPlatformData::setFakeItalic):
(WebCore::FontPlatformData::platformFontHandle):
(WebCore::FontPlatformData::isFixedPitch):
- platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp: Added.
(WebCore):
(WorldTypeScopedPtr):
(WebCore::WorldTypeScopedPtr::WorldTypeScopedPtr):
(WebCore::WorldTypeScopedPtr::~WorldTypeScopedPtr):
(WebCore::WorldTypeScopedPtr::get):
(WebCore::GlyphPage::fill):
- platform/graphics/blackberry/GradientBlackBerry.cpp: Added.
(WebCore):
(WebCore::totalStopsNeeded):
(WebCore::fillStops):
(WebCore::Gradient::platformGradient):
(WebCore::Gradient::platformDestroy):
(WebCore::Gradient::fill):
(WebCore::Gradient::setPlatformGradientSpaceTransform):
- platform/graphics/blackberry/GraphicsContextBlackBerry.cpp: Added.
(WebCore):
(GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::platformContext):
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::setIsAcceleratedContext):
(WebCore::GraphicsContext::isAcceleratedContext):
(WebCore::GraphicsContext::getCTM):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::clearPlatformShadow):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineDash):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::GraphicsContext::setMiterLimit):
(WebCore::GraphicsContext::setAlpha):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipConvexPolygon):
(WebCore::GraphicsContext::addRoundedRectClip):
(WebCore::GraphicsContext::clipOutRoundedRect):
(WebCore::GraphicsContext::clipBounds):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setPlatformTextDrawingMode):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformStrokeStyle):
(WebCore::GraphicsContext::setPlatformStrokeThickness):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformCompositeOperation):
(WebCore::GraphicsContext::setPlatformShouldAntialias):
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::imageInterpolationQuality):
- platform/graphics/blackberry/ITypeUtils.h: Added.
(floatToITypeFixed):
(intToITypeFixed):
(iTypeFixedToFloat):
- platform/graphics/blackberry/ImageBufferBlackBerry.cpp: Added.
(WebCore):
(WebCore::makeBufferCurrent):
(WebCore::getImageDataInternal):
(WebCore::ImageBufferData::getImageData):
(WebCore::flushAndDraw):
(WebCore::ImageBufferData::draw):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::~ImageBuffer):
(WebCore::ImageBuffer::context):
(WebCore::ImageBuffer::platformLayer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
- platform/graphics/blackberry/ImageBufferDataBlackBerry.h: Added.
(WebCore):
(ImageBufferData):
- platform/graphics/blackberry/PathBlackBerry.cpp: Added.
(WebCore):
(WebCore::scratchContext):
(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore::Path::operator=):
(WebCore::Path::currentPoint):
(WebCore::Path::contains):
(WebCore::Path::strokeContains):
(WebCore::Path::translate):
(WebCore::Path::boundingRect):
(WebCore::Path::strokeBoundingRect):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArcTo):
(WebCore::Path::closeSubpath):
(WebCore::Path::addArc):
(WebCore::Path::addRect):
(WebCore::Path::addEllipse):
(WebCore::Path::platformAddPathForRoundedRect):
(WebCore::Path::clear):
(WebCore::Path::isEmpty):
(WebCore::Path::hasCurrentPoint):
(WebCore::Path::apply):
(WebCore::Path::transform):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawLineForDocumentMarker):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):
- platform/graphics/blackberry/PatternBlackBerry.cpp: Added.
(WebCore):
(WebCore::Pattern::platformDestroy):
(WebCore::Pattern::platformPattern):
(WebCore::Pattern::setPlatformPatternSpaceTransform):
- platform/graphics/blackberry/PlatformSupport.cpp: Added.
(WebCore):
(WebCore::PlatformSupport::getFontFamilyForCharacters):
- platform/graphics/blackberry/PlatformSupport.h: Added.
(WebCore):
(PlatformSupport):
(FontFamily):
- platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp: Added.
(WebCore):
(WebCore::FSFixedToFloat):
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformCharWidthInit):
(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
(WebCore::SimpleFontData::containsCharacters):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):
- 2:12 AM Changeset in webkit [144611] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Marking a few layout tests as flaky.
- 2:07 AM Changeset in webkit [144610] by
-
- 3 edits2 adds2 deletes in trunk
MediaStream API: local addTrack() and removeTrack() operations should not fire events.
https://bugs.webkit.org/show_bug.cgi?id=111079
Reviewed by Adam Barth.
Source/WebCore:
Removed the scheduling of "addtrack" and "removetrack" events by
addTrack and removeTrack(). Replaced the test since the old test was
driven by the event firing removed by this patch.
Test: fast/mediastream/MediaStream-add-remove-tracks.html
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
LayoutTests:
Replaced the test since the old test was driven by the event firing
removed by this patch.
- fast/mediastream/MediaStream-add-remove-tracks-expected.txt: Added.
- fast/mediastream/MediaStream-add-remove-tracks.html: Added.
- fast/mediastream/MediaStreamTrackList-expected.txt: Removed.
- fast/mediastream/MediaStreamTrackList.html: Removed.
- 1:39 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:37 AM Changeset in webkit [144609] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[GTK][WK2] Add document-loaded signal to WebKitWebPage
https://bugs.webkit.org/show_bug.cgi?id=110614
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-04
Reviewed by Carlos Garcia Campos.
Add a new signal document-loaded to WebKitWebPage that will be emitted
when the DOM document has been loaded.
- UIProcess/API/gtk/tests/TestWebExtensions.cpp:
(documentLoadedCallback):
(testDocumentLoadedSignal):
(beforeAll): Add test for document-loaded signal.
- UIProcess/API/gtk/tests/WebExtensionTest.cpp:
(documentLoadedCallback):
(pageCreatedCallback):
(methodCallCallback): Add new D-Bus signal DocumentLoaded in order to
test document-loaded signal.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkit_web_page_class_init):
(webkitWebPageCreate): Add document-loaded signal and emit it when
didFinishDocumentLoadForFrame is called.
- 1:36 AM Changeset in webkit [144608] by
-
- 5 edits in trunk
Web Inspector: touchmove not emulated inside iframe
https://bugs.webkit.org/show_bug.cgi?id=111292
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Move fake touch event dispatching from mouseMoved() into handleMouseMoveEvent()
and bail out earlier from dispatchSyntheticTouchEventIfEnabled() when the event
should be dispatched on a subframe.
- page/EventHandler.cpp:
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):
LayoutTests:
- fast/events/touch/emulated-touch-iframe.html:
- fast/events/touch/resources/emulated-touch-iframe2.html:
- 1:33 AM Changeset in webkit [144607] by
-
- 15 edits in trunk/Source/WebCore
Long URLs in error messages should be shortened
https://bugs.webkit.org/show_bug.cgi?id=111133
Reviewed by Jochen Eisinger.
When generating console messages, we're often copying the page's URL
in order to add detail about where the error occurred. Generally, this
is fine, but in edge cases (multi-meg 'data:' URLs), we're using far
more memory than we should, and impacting performance.
This patch adds an 'elidedString()' method to KURL for use in this
sort of case; when generating console messages, we should insert the
elided URL rather than the full URL.
This shouldn't change any visible behavior; we're already visually
eliding URLs in console messages for URLs above 150 characters. This
patch simply changes the underlying string to ensure that no URL is
over 1k in length to begin with.
- platform/KURL.cpp:
(WebCore::KURL::elidedString): Added.
- platform/KURL.h:
An exciting new method that gives you the same result as string()
for URLs less than 1k long, and elides the middle of URLs longer
than 1k by replacing everything but the first and last 0.5k with
"...".
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::canExecuteScripts):
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
(WebCore::WebSocket::send):
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::fail):
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::canExecuteScripts):
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::executeScript):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canPlayType):
(WebCore::HTMLMediaElement::isSafeToLoadURL):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
(WebCore::createWindow):
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::willSendRequest):
(WebCore::MainResourceLoader::responseReceived):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFail):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::printAccessDeniedMessage):
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
(WebCore::CSPDirectiveList::allowScriptNonce):
(WebCore::CSPDirectiveList::allowPluginType):
Use 'KURL::elidedString()' rather than 'KURL::string()'
- loader/MixedContentChecker.cpp:
(WebCore::MixedContentChecker::logWarning):
Here, we're doing the same as above, but it enables us to throw
away the asUTF8() function entirely by switching to makeString
rather than String::format.
- 1:22 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:19 AM Changeset in webkit [144606] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r144070 - [WK2][GTK] REGRESSION (r143463): unit test failure in WebKit2APITests/TestContextMenu
https://bugs.webkit.org/show_bug.cgi?id=110869
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-02-26
Reviewed by Martin Robinson.
Test was failing because of new media controls needs more space to be
painted than just 10x10 pixels.
- UIProcess/API/gtk/tests/TestContextMenu.cpp:
(testContextMenuDefaultMenu): Modified test in order to give more space
to the media controls.
- 1:18 AM WebKitGTK/2.0.x edited by
- Add some changes on track for WK2 (diff)
- 12:37 AM Changeset in webkit [144605] by
-
- 8 edits1 add in trunk/Source
Web Inspector: add runtime flag to determine if inspector's source files were flattened.
https://bugs.webkit.org/show_bug.cgi?id=111184
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-04
Reviewed by Pavel Feldman.
Source/WebCore:
- Add a file "buildSystemOnly.js" which will be included into
devtools.html only by GYP build system. This script sets a single flag
which essentially means that inspector source files were run
through a build system and flattened.
- Update "importScript" and "registerRequiredCSS" functions to correct
paths according to the "flattenImports" flag.
No new tests: no change in behaviour.
- WebCore.gypi:
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
- inspector/front-end/View.js:
(WebInspector.View.prototype.registerRequiredCSS):
- inspector/front-end/buildSystemOnly.js: Added.
- inspector/front-end/utilities.js:
Source/WebKit/chromium:
Included "buildSystemOnly.js" in devtools.html by generate_devtools_html.py script.
- WebKit.gyp:
- scripts/generate_devtools_html.py: Add script tag to include buildSystemOnly.js
(write_devtools_html):
- 12:36 AM Changeset in webkit [144604] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=111290
- platform/qt/TestExpectations: Skipped failing test after r144461.
- 12:06 AM Changeset in webkit [144603] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Fix front-end compilation
https://bugs.webkit.org/show_bug.cgi?id=111286
Reviewed by Alexander Pavlov.
- inspector/InjectedScriptSource.js:
- inspector/front-end/FileSystemProjectDelegate.js:
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype.removeUISourceCode):
(WebInspector.NavigatorTreeNode.prototype.reset):
(WebInspector.NavigatorFolderTreeNode.prototype.didAddChild):
