Timeline



Mar 18, 2013:

11:46 PM Changeset in webkit [146183] by timothy_horton@apple.com
  • 14 edits in trunk/Source/WebKit2

[wk2] Should support multiple page overlays, like the API suggests
https://bugs.webkit.org/show_bug.cgi?id=112505
<rdar://problem/13424796>

Reviewed by Simon Fraser.

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::didInstallPageOverlay):
(WebKit::DrawingArea::didUninstallPageOverlay):
(WebKit::DrawingArea::setPageOverlayNeedsDisplay):
(WebKit::DrawingArea::setPageOverlayOpacity):
Add PageOverlay argument.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::didInstallPageOverlay):
(WebKit::DrawingAreaImpl::didUninstallPageOverlay):
(WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay):
(WebKit::DrawingAreaImpl::setPageOverlayOpacity):
Add PageOverlay argument, forward it to LayerTreeHost.
(WebKit::DrawingAreaImpl::display):
Paint all of the PageOverlays that WebPage knows about.

  • WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::setNeedsDisplay):
(WebKit::PageOverlay::fadeAnimationTimerFired):
Pass the relevant PageOverlay into the DrawingArea methods that now take it.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::drawPageOverlay):
Take the PageOverlay to draw as an argument.
(WebKit::WebPage::installPageOverlay):
(WebKit::WebPage::uninstallPageOverlay):
Allow (un)installation of multiple PageOverlays.
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::mouseEventSyncForTesting):
Hit-test PageOverlays in reverse order of installation (most recently installed should be topmost).

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::drawPageOverlay): Take the PageOverlay to draw as an argument.
(WebKit::WebPage::hasPageOverlay): Return true if we have any number of overlays.
(WebKit::WebPage::pageOverlays): Return the whole vector of overlays.

  • WebProcess/WebPage/mac/LayerTreeHostMac.h:

Add PageOverlay argument to a few methods.
Add storage for a map of PageOverlay->GraphicsLayers.

  • WebProcess/WebPage/mac/LayerTreeHostMac.mm:

(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplayInRect):
(WebKit::LayerTreeHostMac::sizeDidChange):
(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
Operate on all installed PageOverlays, not just the most recently installed one.

(WebKit::LayerTreeHostMac::didInstallPageOverlay):
(WebKit::LayerTreeHostMac::didUninstallPageOverlay):
Forward the passed-in PageOverlay on to createPageOverlayLayer/destroyPageOverlayLayer.

(WebKit::LayerTreeHostMac::setPageOverlayNeedsDisplay):
Look up the GraphicsLayer for the PageOverlay we need to dirty, and dirty it.

(WebKit::LayerTreeHostMac::paintContents):
Find the PageOverlay corresponding to the GraphicsLayer that we're painting, and ask WebPage to paint it.
While not ideal (crawling the map), the vast majority of the time there will only be one entry.

(WebKit::LayerTreeHostMac::initialize):
Create layers for all of WebPage's active PageOverlays.

(WebKit::LayerTreeHostMac::createPageOverlayLayer):
Stick the newly-created GraphicsLayer into the m_pageOverlayLayers map.
Also, drive-by add support for accelerated overlays and debug borders/repaint counters in overlays.

(WebKit::LayerTreeHostMac::destroyPageOverlayLayer):
Remove the relevant overlay from the m_pageOverlayLayers map and tear it down.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):
Add PageOverlay argument to a few methods.
Add storage for a map of PageOverlay->GraphicsLayers.
Add storage for a map of GraphicsLayer->CALayers.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):
Pass PageOverlay argument on to createPageOverlayLayer.

(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):
Pass PageOverlay argument on to destroyPageOverlayLayer.
Refrain from re-enabling threaded scrolling if there are still more overlays installed.

(WebKit::TiledCoreAnimationDrawingArea::setPageOverlayNeedsDisplay):
Look up the GraphicsLayer for the PageOverlay we need to dirty, and dirty it.

(WebKit::TiledCoreAnimationDrawingArea::paintContents):
Find the PageOverlay corresponding to the GraphicsLayer that we're painting, and ask WebPage to paint it.
While not ideal (crawling the map), the vast majority of the time there will only be one entry.

(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged):
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
Operate on all installed PageOverlays, not just the most recently installed one.

(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
Stick the newly-created GraphicsLayer into the m_pageOverlayLayers map.
Also, add its platformLayer to our m_pageOverlayPlatformLayers map.

(WebKit::TiledCoreAnimationDrawingArea::destroyPageOverlayLayer):
Remove the relevant overlay from the m_pageOverlayLayers and m_pageOverlayPlatformLayers maps and tear it down.

(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer):
When we commit changes for the layer, if the GraphicsLayer's backing platform CALayer
has changed out from under us (we have a reference to the previous one in the m_pageOverlayPlatformLayers map),
the GraphicsLayer has probably switched to/from a tiled layer, and we need to swap out the
layer we have inserted into the root layer. We need to keep the layer ordering consistent with
installation order, as well.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::didInstallPageOverlay):
Assert if we try to install more than one page overlay into a CoordinatedLayerTreeHost,
as this patch does not implement multiple overlay support for Coordinated Graphics.
Keep track of the current PageOverlay so that paintContents can hand WebPage the right one.
(WebKit::CoordinatedLayerTreeHost::didUninstallPageOverlay): Remove our reference to the PageOverlay.
(WebKit::CoordinatedLayerTreeHost::setPageOverlayNeedsDisplay): Add unused PageOverlay argument.
(WebKit::CoordinatedLayerTreeHost::setPageOverlayOpacity): Add unused PageOverlay argument.
(WebKit::CoordinatedLayerTreeHost::paintContents): Hand WebPage the PageOverlay we're currently displaying.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

(CoordinatedLayerTreeHost): Add PageOverlay* argument to relevant functions, and storage for m_pageOverlay.

11:17 PM Changeset in webkit [146182] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Styles] The "inherit" property value should be suggested for all properties
https://bugs.webkit.org/show_bug.cgi?id=112662

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/CSSMetadata.js:

(WebInspector.CSSMetadata.keywordsForProperty):

11:17 PM Changeset in webkit [146181] by levin@chromium.org
  • 3 edits
    1 add in trunk/LayoutTests

Change icon-url-property test for platforms which don't support dumpIconChanges.
https://bugs.webkit.org/show_bug.cgi?id=112660

Reviewed by Simon Fraser.

Add the baseline for mac and remove the test failure.

  • fast/dom/icon-url-property.html:
  • platform/mac/TestExpectations:
  • platform/mac/fast/dom/icon-url-property-expected.txt: Added.
10:41 PM Changeset in webkit [146180] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Media playhead button is sometimes 1px wider: media/video-playing-and-pause.html flakey
https://bugs.webkit.org/show_bug.cgi?id=112659

  • platform/mac/TestExpectations:
10:23 PM Changeset in webkit [146179] by fpizlo@apple.com
  • 6 edits
    6 adds in trunk

DFG ToString generic cases should work correctly
https://bugs.webkit.org/show_bug.cgi?id=112654
<rdar://problem/13447250>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileToStringOnCell):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

  • fast/js/dfg-to-string-on-cell-expected.txt: Added.
  • fast/js/dfg-to-string-on-cell.html: Added.
  • fast/js/dfg-to-string-on-value-expected.txt: Added.
  • fast/js/dfg-to-string-on-value.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-to-string-on-cell.js: Added.

(foo):

  • fast/js/script-tests/dfg-to-string-on-value.js: Added.

(foo):

9:42 PM Changeset in webkit [146178] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for 32 bit builds.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

9:15 PM Changeset in webkit [146177] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX (r146088): ResourceRequest::cfURLRequest() is defined twice on iOS
<http://webkit.org/b/112387>

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::cfURLRequest): Move method into
!USE(CFNETWORK) section since it's also defined in
cf/ResourceRequestCFNet.cpp on iOS.

9:00 PM Changeset in webkit [146176] by Simon Fraser
  • 2 edits in trunk/LayoutTests

fast/dom/icon-url-property.html fails on Mac after r146173

  • platform/mac/TestExpectations:
8:50 PM Changeset in webkit [146175] by hclam@chromium.org
  • 5 edits in trunk/Source/WebCore

[chromium] More tracing in deferred image decoding
https://bugs.webkit.org/show_bug.cgi?id=112648

Reviewed by James Robinson.

Adding more trace events for a couple things in deferred image decoding path:

  • Time span for each lock pixels of SkPixelRef.
  • Time spent on decoding, scaling and pruning. Also the stack trace for these events.
  • Memory usage and number of cached entries.
  • Number of decode & scale operations done per image.

No test as this just add tracing information and no behavior change.

  • platform/graphics/chromium/ImageDecodingStore.cpp:

(WebCore::ImageDecodingStore::prune):
(WebCore::ImageDecodingStore::insertCacheInternal):
(WebCore::ImageDecodingStore::removeFromCacheInternal):

  • platform/graphics/chromium/ImageFrameGenerator.cpp:

(WebCore::ImageFrameGenerator::ImageFrameGenerator):
(WebCore::ImageFrameGenerator::decodeAndScale):
(WebCore::ImageFrameGenerator::tryToScale):
(WebCore::ImageFrameGenerator::tryToResumeDecodeAndScale):
(WebCore::ImageFrameGenerator::tryToDecodeAndScale):
(WebCore::ImageFrameGenerator::decode):

  • platform/graphics/chromium/ImageFrameGenerator.h:

(ImageFrameGenerator):

  • platform/graphics/chromium/LazyDecodingPixelRef.cpp:

(WebCore::LazyDecodingPixelRef::onLockPixels):
(WebCore::LazyDecodingPixelRef::onUnlockPixels):
(WebCore::LazyDecodingPixelRef::PrepareToDecode):

8:22 PM Changeset in webkit [146174] by msaboff@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

EFL: Unsafe branch detected in compilePutByValForFloatTypedArray()
https://bugs.webkit.org/show_bug.cgi?id=112609

Reviewed by Geoffrey Garen.

Created local valueFPR and scratchFPR and filled them with valueOp.fpr() and scratch.fpr()
respectively so that if valueOp.fpr() causes a spill during allocation, it occurs before the
branch and also to follow convention. Added register allocation checks to FPRTemporary.
Cleaned up a couple of other places to follow the "AllocatVirtualRegType foo, get machine
reg from foo" pattern.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::fprAllocate):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::convertToDouble):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

8:00 PM Changeset in webkit [146173] by levin@chromium.org
  • 3 edits in trunk/LayoutTests

Dump icon change events in the icon-url-property test.
https://bugs.webkit.org/show_bug.cgi?id=112647

Reviewed by Jochen Eisinger.

This allows us to check that the didChangeIcon callback
is being done when it should be done. This test stopped
testing that in r122806 but it did before that.

  • fast/dom/icon-url-property-expected.txt:
  • fast/dom/icon-url-property.html:
7:38 PM Changeset in webkit [146172] by kbr@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Generalized suppression for flaky
fast/js/repeat-cached-vm-reentry.html .

  • platform/chromium/TestExpectations:
7:26 PM Changeset in webkit [146171] by kbr@google.com
  • 3 edits in trunk/LayoutTests

Unreviewed rebaselining after r146167.

  • platform/chromium-win/css3/flexbox/flexbox-baseline-margins-expected.png:
  • platform/chromium-win/fast/layers/scroll-rect-to-visible-expected.png:
7:12 PM Changeset in webkit [146170] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

[iOS] Make a UChar string equal() based on the LChar version
https://bugs.webkit.org/show_bug.cgi?id=112495

Reviewed by David Kilzer.

  • wtf/text/StringImpl.h:

(WTF::equal):
Create a equal() function for UChar based on the work done for LChar.

On A6, this is a speed up of about 40% for any string of 2 or more characters.
It is slower by 8% on a single UChar comparison.

6:45 PM Changeset in webkit [146169] by cevans@google.com
  • 5 edits in branches/chromium/1410/Source/WebCore/bindings/v8

Merge 144458
BUG=150737
Review URL: https://codereview.chromium.org/12926003

6:28 PM Changeset in webkit [146168] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests after r146161.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjEnumAttr):
(WebCore::jsTestObjPrototypeFunctionMethodWithEnumArg):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):

6:07 PM Changeset in webkit [146167] by commit-queue@webkit.org
  • 10 edits in trunk

[chromium] Small pixel differences in scroll bars after r145844
https://bugs.webkit.org/show_bug.cgi?id=112384

Patch by Robert Flack <flackr@chromium.org> on 2013-03-18
Reviewed by Kenneth Russell.

Source/WebCore:

Tests: fast/forms/basic-textareas-quirks.html

fast/forms/basic-textareas.html
fast/overflow/overflow-x-y.html
fast/parser/open-comment-in-textarea.html
fast/replaced/width100percent-textarea.html

  • platform/chromium/ScrollbarThemeChromium.cpp:

(WebCore::ScrollbarThemeChromium::trackRect):

LayoutTests:

  • platform/chromium-linux/fast/forms/basic-textareas-expected.png:
  • platform/chromium-linux/fast/forms/basic-textareas-quirks-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-x-y-expected.png:
  • platform/chromium-linux/fast/parser/open-comment-in-textarea-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-textarea-expected.png:
  • platform/chromium-win/fast/forms/basic-textareas-quirks-expected.png:
6:04 PM Changeset in webkit [146166] by Simon Fraser
  • 2 edits in trunk/LayoutTests

fast/css/lang-mapped-to-webkit-locale-dynamic.xhtml is flakey

  • platform/mac/TestExpectations:
5:46 PM Changeset in webkit [146165] by bfulgham@webkit.org
  • 3 edits in trunk/Source/WebCore

[WinCairo] Unreviewed build correction.

The "ImageDecoder.h" file was improperly tagged as a source file to
build, causing a build failure on initial build attempts. Subsequent
or incremental builds would work.

  • WebCore.vcxproj/WebCore.vcxproj: Exclude CG-specific font files.

Switch 'ImageDecoder.h' to proper source file type.

  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
5:44 PM Changeset in webkit [146164] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

DFG should inline binary string concatenations (i.e. ValueAdd with string children)
https://bugs.webkit.org/show_bug.cgi?id=112599

Reviewed by Oliver Hunt.

This does as advertised: if you do x + y where x and y are strings, you'll get
a fast inlined JSRopeString allocation (along with whatever checks are necessary).
It also does good things if either x or y (or both) are StringObjects, or some
other thing like StringOrStringObject. It also lays the groundwork for making this
fast if either x or y are numbers, or some other reasonably-cheap-to-convert
value.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(FixupPhase):
(JSC::DFG::FixupPhase::isStringObjectUse):
(JSC::DFG::FixupPhase::convertStringAddUse):
(JSC::DFG::FixupPhase::attemptToMakeFastStringAdd):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileAdd):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::emitAllocateJSCell):
(JSC::DFG::SpeculativeJIT::emitAllocateJSObject):

  • runtime/JSString.h:

(JSC::JSString::offsetOfFlags):
(JSString):
(JSRopeString):
(JSC::JSRopeString::offsetOfFibers):

5:37 PM Changeset in webkit [146163] by jamesr@google.com
  • 4 edits
    2 deletes in trunk/Source

[chromium] Remove unused type WebTransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=112634

Reviewed by Adam Barth.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebTransformationMatrix.h: Removed.

Source/WebCore:

  • WebCore.gypi:
  • platform/chromium/support/WebTransformationMatrix.cpp: Removed.
5:34 PM Changeset in webkit [146162] by Simon Fraser
  • 2 edits in trunk/LayoutTests

fast/events/pageshow-pagehide.html sometimes crashes.
https://bugs.webkit.org/show_bug.cgi?id=81291

  • platform/mac-wk2/TestExpectations:
5:33 PM Changeset in webkit [146161] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebCore

Add IDL 'enum' support to CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=112475

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-18
Reviewed by Kentaro Hara.

This adds support for enumerations in JS, adding validation checking
to setters.
It also does validation checking to methods, and a new method
methodWithEnumArg in TestObj.idl

Test: bindings/scripts/test/TestObj.idl

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GenerateParametersCheck):
(NativeToJSValue):

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::methodWithEnumArg):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_method_with_enum_arg):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjEnumAttr):
(WebCore::setJSTestObjEnumAttr):
(WebCore::jsTestObjPrototypeFunctionMethodWithEnumArg):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj methodWithEnumArg:]):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::methodWithEnumArgMethod):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::methodWithEnumArgMethodCallback):
(WebCore::ConfigureV8TestObjTemplate):

5:28 PM Changeset in webkit [146160] by Simon Fraser
  • 2 edits in trunk/LayoutTests

plugins/private-browsing-mode.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=112646

  • platform/mac/TestExpectations:
5:27 PM Changeset in webkit [146159] by kbr@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed suppression for flaky test.
https://bugs.webkit.org/show_bug.cgi?id=112643

  • platform/chromium/TestExpectations:
5:24 PM Changeset in webkit [146158] by Simon Fraser
  • 2 edits in trunk/LayoutTests

editing/deleting/paste-with-transparent-background-color.html
sometimes asserts.

  • platform/mac/TestExpectations:
5:20 PM Changeset in webkit [146157] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

JSC_NATIVE_FUNCTION() takes an identifier for the name and then uses #name, which is unsafe if name was already #define'd to something else
https://bugs.webkit.org/show_bug.cgi?id=112639

Reviewed by Michael Saboff.

Change it to take a string instead.

  • runtime/JSObject.h:

(JSC):

  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::finishCreation):

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):

5:17 PM Changeset in webkit [146156] by morrita@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

Older shadow root rendered in incorrect order when multiple shadow roots containing style tags have been constructed
https://bugs.webkit.org/show_bug.cgi?id=93752

The bug was already fixed in some point. This change just adds a regression test to cover the reported problem.

Reviewed by Dimitri Glazkov.

  • fast/dom/shadow/multiple-shadowroots-with-empty-styles-expected.html: Added.
  • fast/dom/shadow/multiple-shadowroots-with-empty-styles.html: Added.
5:13 PM Changeset in webkit [146155] by Simon Fraser
  • 2 edits in trunk/Tools

Style tweeks to default.css.

Rubber-stamped by David Kilzer.

Give visited links a different color to other links, so you can
see which builds you've viewed.

Make the <small> text less tiny.

  • BuildSlaveSupport/build.webkit.org-config/public_html/default.css:

(small):
(a:link,a:visited,a:active):
(a:visited):

5:12 PM Changeset in webkit [146154] by weinig@apple.com
  • 11 edits in trunk/Source

Need a bundle SPI to generate a snapshot of a specific DOM node (like [DOMNode renderedImage])
<rdar://problem/13148631>
https://bugs.webkit.org/show_bug.cgi?id=110034

Reviewed by Tim Horton.

Source/WebCore:

  • WebCore.exp.in:

Add some necessary exports.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleCopySnapshotWithOptions):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:

Add WKBundleNodeHandleCopySnapshotWithOptions function.

  • WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:
  • WebProcess/InjectedBundle/API/mac/WKDOMNodePrivate.h:

Fix conversion method between WKDOMNode and WKBundleNodeHandleRef to have the same
name in the header and implementation.

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::imageForRect):
(WebKit):
(WebKit::InjectedBundleNodeHandle::renderedImage):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:

Add implementation of WKBundleNodeHandleCopySnapshotWithOptions.

  • Shared/ImageOptions.h:

(WebKit::snapshotOptionsToImageOptions):

  • WebProcess/WebPage/WebPage.cpp:

Move snapshotOptionsToImageOptions conversion function to a location where
it can be shared.

5:10 PM Changeset in webkit [146153] by bfulgham@webkit.org
  • 7 edits
    10 adds in trunk/Source/WebCore

[WinCairo] Build WebCore under VS2010
https://bugs.webkit.org/show_bug.cgi?id=112637

Reviewed by Tim Horton.

  • WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj: Extend project

with WinCairo-specific build targets.

  • WebCore.vcxproj/QTMovieWin/QTMovieWinCairoDebug.props: Added.
  • WebCore.vcxproj/QTMovieWin/QTMovieWinCairoRelease.props: Added.
  • WebCore.vcxproj/WebCore.vcxproj: Update to build WinCairo version

of code.

  • WebCore.vcxproj/WebCoreCURL.props: Added.
  • WebCore.vcxproj/WebCoreCairo.props: Added.
  • WebCore.vcxproj/WebCoreDebugWinCairo.props: Added.
  • WebCore.vcxproj/WebCoreGenerated.vcxproj:
  • WebCore.vcxproj/WebCoreGeneratedDebugWinCairo.props: Added.
  • WebCore.vcxproj/WebCoreGeneratedReleaseWinCairo.props: Added.
  • WebCore.vcxproj/WebCoreGeneratedWinCairo.make: Added.
  • WebCore.vcxproj/WebCoreGeneratedWinCairoCommon.props: Added.
  • WebCore.vcxproj/WebCoreReleaseWinCairo.props: Added.
  • WebCore.vcxproj/WebCoreTestSupport.vcxproj:
  • WebCorePrefix.h: Update header to not include Apple-specific

headers during WinCairo build.

4:54 PM Changeset in webkit [146152] by jsbell@chromium.org
  • 3 edits in trunk/Source/WebCore

IDB Cursor continue moves one item at a time
https://bugs.webkit.org/show_bug.cgi?id=109972

Reviewed by Tony Chang.

IndexedDB: Use seek on the underlying levelDB iterator to implement the continue operation
on a cursor, instead of advancing one item at a time. On a simple test in Chrome - open a
key cursor on an index w/ 100 items, then do continue(50), rinse and repeat - this cuts the
time 50% (850c/s to 1700c/s). (Original patch c/o Pankaj Kakkar <pankaj@google.com>)

Covered by existing storage/indexeddb cursor tests; just a performance optimization.

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBBackingStore::Cursor::continueFunction): Special case first iteration w/ key
to use leveldb seek (forward cursors only, since reverse seek isn't exposed).
(WebCore::ObjectStoreKeyCursorImpl::encodeKey): Helper for encoding key to seek to.
(WebCore::ObjectStoreCursorImpl::encodeKey): Ditto.
(WebCore::IndexKeyCursorImpl::encodeKey): Ditto.
(WebCore::IndexCursorImpl::encodeKey): Ditto.
(WebCore::objectStoreCursorOptions): Store IDs for encodeKey() to use.
(WebCore::indexCursorOptions): Ditto.

  • Modules/indexeddb/IDBBackingStore.h:

(CursorOptions): Storage for IDs.
(Cursor): Add encodeKey() to interface.

4:52 PM Changeset in webkit [146151] by ap@apple.com
  • 8 edits in trunk/Source/WebCore

MessagePortChannel::EventData should not be exposed
https://bugs.webkit.org/show_bug.cgi?id=112635

Reviewed by Geoff Garen.

MessagePortChannel::EventData is an implementation detail that's only needed to
store events in MessageQueue. Other existing code already gets away without it,
just passing message and ports separately.

  • dom/MessagePort.cpp: (WebCore::MessagePort::postMessage): (WebCore::MessagePort::dispatchMessages):
  • dom/MessagePortChannel.cpp:
  • dom/MessagePortChannel.h:
  • dom/default/PlatformMessagePortChannel.cpp: (WebCore::PlatformMessagePortChannel::EventData::create): (WebCore::PlatformMessagePortChannel::EventData::EventData): (WebCore::MessagePortChannel::postMessageToRemote): (WebCore::MessagePortChannel::tryGetMessageFromRemote):
  • dom/default/PlatformMessagePortChannel.h: (WebCore::PlatformMessagePortChannel::EventData::message): (WebCore::PlatformMessagePortChannel::EventData::channels): (PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage): (WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty):
  • dom/default/chromium/PlatformMessagePortChannelChromium.cpp: (WebCore::MessagePortChannel::postMessageToRemote): (WebCore::MessagePortChannel::tryGetMessageFromRemote): (WebCore::PlatformMessagePortChannel::postMessageToRemote): (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
  • dom/default/chromium/PlatformMessagePortChannelChromium.h:
4:51 PM FeatureFlags edited by tkent@chromium.org
VIEW_MODE_CSS_MEDIA (diff)
4:42 PM Changeset in webkit [146150] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
https://bugs.webkit.org/show_bug.cgi?id=112494

Reviewed by Dirk Pranke.

Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
Also merged two pairs of methods to cleanup the code.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner.run): Merged _upload_and_show_results.
(PerfTestsRunner._generate_results): Merged _generate_output_files.

4:31 PM Changeset in webkit [146149] by cevans@google.com
  • 6 edits
    2 copies in branches/chromium/1410

Merge 145423
BUG=177686
Review URL: https://codereview.chromium.org/12573007

4:22 PM Changeset in webkit [146148] by dpranke@chromium.org
  • 2 edits in trunk/Tools

[chromium] build xdisplaycheck when building DRT
https://bugs.webkit.org/show_bug.cgi?id=112636

Reviewed by Tony Chang.

It appears that we need xdisplaycheck to be built in order for
Xvfb to be started correctly on the bots, and DRT was missing
a dependency on it. This may be the cause of the ASAN bot not
starting up properly (it only builds DRT).

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4:17 PM Changeset in webkit [146147] by tsepez@chromium.org
  • 2 edits in trunk/Source/WebCore

[v8] Suppress binding integrity check of HTMLContentElement.
https://bugs.webkit.org/show_bug.cgi?id=112613

Reviewed by Adam Barth.

Patch is correct so long as fast/dom/shadow/content-element-user-agent-shadow.html
continues to pass.

  • html/shadow/HTMLContentElement.idl:
4:16 PM Changeset in webkit [146146] by Simon Fraser
  • 1 edit
    1 delete in trunk/LayoutTests

Remove failing Windows-specific result; this test passes now.

  • platform/win/media/nodesFromRect-shadowContent-expected.txt: Removed.
4:10 PM Changeset in webkit [146145] by dmazzoni@google.com
  • 4 edits in trunk/Source/WebCore

Support Windows HTMLSelectElement keystrokes on Chromium win
https://bugs.webkit.org/show_bug.cgi?id=112460

Reviewed by Kent Tamura.

Compile in the windows-specific variant of
HTMLSelectElement::platformHandleKeydownEvent
on Chromium win, in addition to PLATFORM(WIN).

  • WebCore.gypi:

Add html/HTMLSelectElementWin.cpp.

  • html/HTMLSelectElement.cpp:

Don't compile generic platformHandleKeydownEvent on
Chromium win.

  • html/HTMLSelectElementWin.cpp:

Only compile platformHandleKeydownEvent on Windows.
Fix compile error in assertion.

(WebCore):

4:10 PM Changeset in webkit [146144] by bfulgham@webkit.org
  • 2 edits
    3 adds in trunk/Source/JavaScriptCore

[WinCairo] Get build working under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112604

Reviewed by Tim Horton.

build target (standard version links against CoreFoundation.lib
instead of CFLite.lib).

4:08 PM Changeset in webkit [146143] by akling@apple.com
  • 3 edits in trunk/Source/WebKit2

[WK2][Mac] Don't consider empty window frames cacheable.
<http://webkit.org/b/112631>
<rdar://problem/13384894>

Reviewed by Anders Carlsson.

If the UI client overrides getWindowFrame() and returns an empty rect, send that over
to the web process and mark it as uncached. This forces the next ChromeClient::windowRect()
call to synchronously retrieve the window frame from the other side.

Fixes an issue with the Mac Web Inspector which uses empty rects to signify that there is
no known window frame yet. In this case, we should not be falling back to the native frame.

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::windowAndViewFramesChanged):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowAndViewFramesChanged):

4:05 PM Changeset in webkit [146142] by Simon Fraser
  • 2 edits in trunk/LayoutTests

fast/loader/document-with-fragment-url-4.html sometimes asserts
https://bugs.webkit.org/show_bug.cgi?id=97124

  • platform/mac-wk2/TestExpectations:
3:54 PM Changeset in webkit [146141] by mkwst@chromium.org
  • 6 edits
    1 copy
    3 adds in trunk

CSP 1.1: Schemeless source expressions match HTTPS resources on HTTP sites.
https://bugs.webkit.org/show_bug.cgi?id=112573

Reviewed by Adam Barth.

Source/WebCore:

Currently, the directive 'script-src example.com' would match only
scripts served from 'http://example.com' when served on an HTTP site,
and only scripts served from 'https://example.com' when served on an
HTTPS site. This patch changes the matching behavior for ports that
have enabled CSP_NEXT in order to encourage use of HTTPS resources by
allow schemeless source expressions to match HTTPS origins when on
HTTP sites.

Thread: http://lists.w3.org/Archives/Public/public-webappsec/2013Mar/0013.html
Spec change: https://dvcs.w3.org/hg/content-security-policy/rev/a7dc8820946e

Test: http/tests/security/contentSecurityPolicy/source-list-parsing-10.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPSource::CSPSource):

Pass the current policy into CSPSource so that we can check the
protected resource's scheme inside schemeMatches, rather than
overwriting the source expression's scheme before creating the
CSPSource.

(WebCore::CSPSource::schemeMatches):

If CSP_NEXT is enabled, ensure that HTTPS resources match the
HTTP scheme when loaded on HTTP pages with schemaless source
expressions.

(WebCore::CSPSource::portMatches):

Check the port against the URL's scheme: if m_scheme isn't
empty, this will match it. If m_scheme is empty, we can't
do a strict match against it, nor can we do a strict match
against the protected resource's port. Checking the URL's
port against the default port for its scheme solves this
problem elegantly.

(WebCore::CSPSourceList::parse):
(WebCore::CSPSourceList::addSourceSelf):

Pass in the policy when creating a CSPSource object.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/resources/multiple-iframe-test.js:

Add support for full URLs in this type of test, which enables loading
scripts from hosts other than the current page's.

  • http/tests/security/contentSecurityPolicy/source-list-parsing-01-expected.txt:
  • http/tests/security/contentSecurityPolicy/source-list-parsing-01.html:

Drops a test from the first parsing group, as it's better grouped
with the new test added below.

  • http/tests/security/contentSecurityPolicy/source-list-parsing-10-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/source-list-parsing-10.html: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-01.html.

Adds a new test that checks HTTPS scripts loaded against a
schemeless source expression.

  • platform/chromium/http/tests/security/contentSecurityPolicy/source-list-parsing-10-expected.txt: Added.
  • platform/gtk/http/tests/security/contentSecurityPolicy/source-list-parsing-10-expected.txt: Added.

This patch has different behavior for ports that enable CSP_NEXT,
currently Chromium and GTK.

3:51 PM Changeset in webkit [146140] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

Text track cues do not update sizes when entering or exiting full screen.
https://bugs.webkit.org/show_bug.cgi?id=112472

Reviewed by Eric Carlson.

The style properties of the TextCueBoxes were not being updated after the size of the video bounds changed.
Because getDisplayTree() will not do it when the cue itself has not changed, explicitly call videoSizeDidChange()
from updateSizes().

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateSizes): call videoSizeDidChange() on every active cue.

  • html/track/TextTrackCue.h:

(WebCore::TextTrackCue::hasDisplayTree): returns whether or not the cue has created a display tree without side effects.
(WebCore::TextTrackCue::videoSizeDidChange): Overridable empty method.

  • html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGeneric::videoSizeDidChange): Update the CSS height attribute of the cue box using the new video size.

  • html/track/TextTrackCueGeneric.h:
3:49 PM Changeset in webkit [146139] by levin@chromium.org
  • 7 edits in trunk/Tools

Implement icon change notification dump for Chromium's test shell.
https://bugs.webkit.org/show_bug.cgi?id=112614

This was previously implemented for some other platforms in r58111
and r116547.

In r122806, fast/dom/icon-url-property.html stopped using it, but
it is useful for tests, so I plan to re-add it to that test again.

Reviewed by Jochen Eisinger.

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that

icon change notifications from WebKit may be logged in test output.

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
(WebTestRunner::TestRunner::reset): Clear the new dump variable.
(WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
(WebTestRunner):
(WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::didChangeIcon):
(WebTestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didChangeIcon): Add the output about changing the icon.

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

3:48 PM Changeset in webkit [146138] by cevans@google.com
  • 3 edits
    2 copies in branches/chromium/1410

Merge 145481
BUG=183741
Review URL: https://codereview.chromium.org/12886025

3:47 PM Changeset in webkit [146137] by mkwst@chromium.org
  • 4 edits
    24 adds in trunk

CSP 1.1: Add 'effective-directive' to violation reports.
https://bugs.webkit.org/show_bug.cgi?id=112568

Reviewed by Adam Barth.

Source/WebCore:

https://dvcs.w3.org/hg/content-security-policy/rev/bc2bb0e5072a
introduced an 'effective-directive' field on CSP violation reports,
which allows developers to distinguish between resource types when
'default-src' is the violated directive.

This patch implements the new field behind the CSP_NEXT flag.

Test: http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
(WebCore::CSPDirectiveList::reportViolation):

These methods now accept an additional parameter to pipe the
effective directive from the initial callsite down into
ContentSecurityPolicy::reportViolation.

(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
(WebCore::CSPDirectiveList::checkNonceAndReportViolation):
(WebCore::CSPDirectiveList::checkMediaTypeAndReportViolation):
(WebCore::CSPDirectiveList::checkInlineAndReportViolation):
(WebCore::CSPDirectiveList::allowScriptFromSource):
(WebCore::CSPDirectiveList::allowObjectFromSource):
(WebCore::CSPDirectiveList::allowChildFrameFromSource):
(WebCore::CSPDirectiveList::allowImageFromSource):
(WebCore::CSPDirectiveList::allowStyleFromSource):
(WebCore::CSPDirectiveList::allowFontFromSource):
(WebCore::CSPDirectiveList::allowMediaFromSource):
(WebCore::CSPDirectiveList::allowConnectToSource):
(WebCore::CSPDirectiveList::allowFormAction):

These methods now pass the effective directive name down
into checkSourceAndReportViolation or reportViolation.

(WebCore::ContentSecurityPolicy::reportViolation):

  • page/ContentSecurityPolicy.h:

This method now accepts a new parameter that carries
the effective directive name. If CSP_NEXT is enabled,
the field is added to the violation report before it's
sent out into the world.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive.html: Added.

A new test that ensures that 'default-src' doesn't show up in the
effective directive field, even if it's the directive that was
actually violated.

  • platform/chromium/http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt: Added.
  • platform/chromium/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt: Added.
  • platform/chromium/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt: Added.
  • platform/chromium/http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt: Added.
  • platform/chromium/http/tests/security/contentSecurityPolicy/report-only-expected.txt: Added.
  • platform/chromium/http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt: Added.
  • platform/chromium/http/tests/security/contentSecurityPolicy/report-only-report-uri-missing-expected.txt: Added.
  • platform/chromium/http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Added.
  • platform/chromium/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Added.
  • platform/chromium/http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt: Added.
  • platform/chromium/http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt: Added.
  • platform/gtk/http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt: Added.
  • platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt: Added.
  • platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt: Added.
  • platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt: Added.
  • platform/gtk/http/tests/security/contentSecurityPolicy/report-only-expected.txt: Added.
  • platform/gtk/http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt: Added.
  • platform/gtk/http/tests/security/contentSecurityPolicy/report-only-report-uri-missing-expected.txt: Added.
  • platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Added.
  • platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Added.
  • platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt: Added.
  • platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt: Added.

This patch changes the output of violation reports for ports that
have enabled CSP_NEXT. At the moment, I think that's Chromium and
GTK only.

3:43 PM Changeset in webkit [146136] by cevans@google.com
  • 16 edits in branches/chromium/1410/Source

Merge 145453
BUG=183741
Review URL: https://codereview.chromium.org/12918021

3:43 PM Changeset in webkit [146135] by wjmaclean@chromium.org
  • 6 edits in trunk/Source

Source/Platform: [chromium] Remove code that relies on boundsContainsPageScale().
https://bugs.webkit.org/show_bug.cgi?id=112465

The boundsContainsPageScale() API is going away, remove code that
depends on it.

Reviewed by James Robinson.

  • chromium/public/WebContentLayer.h:

(WebContentLayer):

Source/WebCore: [chromium] Remove NCCH code that relies on boundsContainsPageScale().
https://bugs.webkit.org/show_bug.cgi?id=112465

Reviewed by James Robinson.

The boundsContainsPageScale() API is going away, remove code that
depends on it. Uses existing tests as no behaviour change.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setAppliesPageScale):
(WebCore::GraphicsLayerChromium::appliesPageScale):

Source/WebKit/chromium: [chromium] Remove NCCH code that relies on boundsContainsPageScale().
https://bugs.webkit.org/show_bug.cgi?id=112465

Reviewed by James Robinson.

The boundContainsPageScale API is going away, remove code that relies
on it.

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setViewport):

3:36 PM Changeset in webkit [146134] by kbr@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Suppressed flaky test.
https://bugs.webkit.org/show_bug.cgi?id=112629

  • platform/chromium/TestExpectations:
3:33 PM Changeset in webkit [146133] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Another flakey iframe flattening test.

  • platform/mac/TestExpectations:
3:31 PM Changeset in webkit [146132] by alecflett@chromium.org
  • 11 edits in trunk/Source

IndexedDB: Protect against key prefix overflows
https://bugs.webkit.org/show_bug.cgi?id=111138

Reviewed by Tony Chang.

Source/WebCore:

This reworks the boundary checking for all databaseId,
objectStoreId, and indexId, including negative and
zero-based ids. All entrypoints into IDBLevelDBCoding
are protected with explicit checks and all internal
uses of KeyPrefix are protected with ASSERTs in the
various constructors.

Tests: WebKit unit tests IDBBackingStoreTest.cpp in WebKit/chromium

  • Modules/indexeddb/IDBBackingStore.h: Make all public methods boolean-based for errors.
  • Modules/indexeddb/IDBLevelDBCoding.h: Add methods for checking databaseId, objectStoreId, and indexId.

Source/WebKit/chromium:

Add tests for invalid indexIds in basic get/put operations.

3:24 PM Changeset in webkit [146131] by roger_fong@apple.com
  • 4 edits in trunk/Source

AppleWin VS2010 Debug configuration build fix..

  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj:
3:20 PM Changeset in webkit [146130] by ap@apple.com
  • 4 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=112627
MessagePort::disentangle() takes an ExceptionCode argument without any need

Reviewed by Geoffrey Garen.

MessagePort::disentangle() is called in two places. One has ASSERT_NO_EXCEPTION,
and another fails to check the exception, but clearly cannot get one.

This function is also not exposed to bindings.

  • dom/MessagePort.cpp:

(WebCore::MessagePort::disentangle):
(WebCore::MessagePort::disentanglePorts):

  • dom/MessagePort.h:
  • workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):
Also removed some unhelpful comments.

3:07 PM Changeset in webkit [146129] by wangxianzhu@chromium.org
  • 13 edits
    3 adds in trunk

Variant of non-primary fell-back SVGFont causes crash.
https://bugs.webkit.org/show_bug.cgi?id=112367

Reviewed by Stephen Chenney.

Source/WebCore:

Don't go to PlatformFontData path for SimpleFontData::createScaledFontData()
for SVG fonts.

Test: svg/css/font-face-variant-crash.html

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::~SimpleFontData):
(WebCore::SimpleFontData::createScaledFontData): Don't go to PlatformFontData path for SVG fonts.
(WebCore):

  • platform/graphics/SimpleFontData.h:

(SimpleFontData): Added createScaledFontData and renamed the original createScaledFontData to platformCreateScaledFontData.

BTW, Removed unreferenced commonInit.

  • platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Renamed from createScaledFontData.

  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

  • platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

  • platform/graphics/skia/SimpleFontDataSkia.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

  • platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

  • platform/graphics/wince/SimpleFontDataWinCE.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

  • platform/graphics/wx/SimpleFontDataWx.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

LayoutTests:

  • resources/SpaceOnly.otf: Added. A font containing only the space glyph for testing font fallback.
  • svg/css/font-face-variant-crash-expected.txt: Added.
  • svg/css/font-face-variant-crash.html: Added.
3:02 PM Changeset in webkit [146128] by vcarbune@chromium.org
  • 4 edits
    3 adds in trunk

Determine text direction for rendering a TextTrackCue
https://bugs.webkit.org/show_bug.cgi?id=79749

Reviewed by Levi Weintraub.

Source/WebCore:

The rendering rules for WebVTT cues are slightly different
depending on the directionality determined from the characters
of the cue text. This patch implements the preliminary step
to be able to take directionality into account.

It iterates through the cue characters and setting the CSS
directionality to the one of the first strong directional character.

Test: media/track/track-cue-rendering-rtl.html

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCueBox::applyCSSProperties): Applies the determined
direction.
(WebCore::TextTrackCue::TextTrackCue): Sets the default value for the
display direction.
(WebCore::isCueParagraphSeparator): Tests for explicit unicode characters
that are paragraph separators.
(WebCore):
(WebCore::TextTrackCue::determineTextDirection): Determined the direction
by the first strong directional character found.
(WebCore::TextTrackCue::calculateDisplayParameters): Updated.
(WebCore::TextTrackCue::getCSSWritingDirection): Return the determined CSS
writing direction.

  • html/track/TextTrackCue.h:

(TextTrackCue):

LayoutTests:

  • media/track/captions-webvtt/captions-rtl.vtt: Added.
  • media/track/track-cue-rendering-rtl-expected.txt: Added.
  • media/track/track-cue-rendering-rtl.html: Added.
2:43 PM Changeset in webkit [146127] by jparent@chromium.org
  • 3 edits
    2 copies in trunk/Tools

Cleanup: Move js for treemap and aggregate_results into own js files.
https://bugs.webkit.org/show_bug.cgi?id=112618

Reviewed by Dirk Pranke.

No functional changes, just moving the code into separate js file
rather than inlined in the html, so we can test it, make it more
modular, etc. Other dashboard types are already done this way.

  • TestResultServer/static-dashboards/aggregate_results.html:
  • TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.

(generatePage):
(handleValidHashParameter):
(htmlForBuilder):
(rawValuesHTML):
(chartHTML):
(filteredValues):
(chart):
(htmlForRevisionRows):
(wrapHTMLInTable):
(htmlForSummaryTable):
(valuesPerExpectation):
(htmlForTestType):
(htmlForTableRow):
(extendedEncode):

  • TestResultServer/static-dashboards/treemap.html:
  • TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.

(humanReadableTime):
(convertToWebTreemapFormat):
(reverseSortByAverage):
(generatePage):
(focusPath):
(.switch.return):
(handleQueryParameterChange):
(extractName):
(fullName):
(handleFocus.):
(handleFocus):

2:35 PM Changeset in webkit [146126] by kbr@google.com
  • 3 edits
    12 deletes in trunk/LayoutTests

Unreviewed gardening. Marked flaky tests, removed obsolete
expectations, and fixed flaky test fast/innerHTML/innerHTML-iframe.html .
https://bugs.webkit.org/show_bug.cgi?id=97816
https://bugs.webkit.org/show_bug.cgi?id=112306
https://bugs.webkit.org/show_bug.cgi?id=112621

  • fast/innerHTML/innerHTML-iframe.html:
  • platform/chromium-android/platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
  • platform/chromium-android/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
  • platform/chromium-android/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
  • platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
  • platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
  • platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
  • platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
  • platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
  • platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
  • platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
  • platform/chromium/TestExpectations:
2:30 PM Changeset in webkit [146125] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
https://bugs.webkit.org/show_bug.cgi?id=112622

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/tool/steps/haslanded_unittest.py:

(HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.

2:28 PM Changeset in webkit [146124] by zandobersek@gmail.com
  • 4 edits in trunk/Tools

[NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=112619

Reviewed by Dirk Pranke.

When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
directory and then fall back to the generic LayoutTests/platform/gtk directory.

  • Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
Port._webkit_baseline_path method.

  • Scripts/webkitpy/layout_tests/port/gtk_unittest.py:

(GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
(GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
that are expected based on the builder name.

2:28 PM Changeset in webkit [146123] by bfulgham@webkit.org
  • 10 edits
    3 adds in trunk/Source/JavaScriptCore

[WinCairo] Get build working under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112604

Reviewed by Tim Horton.

Debug_WinCairo and Release_WinCairo using CFLite.

  • JavaScriptCore.vcxproj/JavaScriptCoreCFLite.props: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreDebugCFLite.props: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj:

Add Debug_WinCairo and Release_WinCairo build targets to
make sure headers are copied to proper build folder.

Add Debug_WinCairo and Release_WinCairo build targets to
make sure headers are copied to proper build folder.

  • JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj:

Ditto.

  • JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj:

Ditto.

2:16 PM Changeset in webkit [146122] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Skip some tests on Windows.

  • platform/win/TestExpectations:
2:09 PM Changeset in webkit [146121] by bfulgham@webkit.org
  • 3 edits in trunk/Source/WTF

[WinCairo] Get build working under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112604

Reviewed by Tim Horton.

  • WTF.vcxproj/WTF.vcxproj: Add Debug_WinCairo and Release_WinCairo

targets so headers get copied to appropriate build folder.

  • WTF.vcxproj/WTFGenerated.vcxproj: Ditto.
2:08 PM Changeset in webkit [146120] by bfulgham@webkit.org
  • 2 edits
    1 add in trunk/Source/WebKit

[WinCairo] Build WinCairo port under VS2010
https://bugs.webkit.org/show_bug.cgi?id=112604

Reviewed by Tim Horton.

  • WebKit.vcxproj/WebKit.sln: Add Debug_WinCairo and Release_WinCairo

build targets. No other changes in this patch.

  • WebKit.vcxproj/FeatureDefinesCairo.props: Add parallel property

sheet for WinCairo version of build.

1:57 PM Changeset in webkit [146119] by Simon Fraser
  • 2 edits in trunk/LayoutTests

ASSERTION FAILED: !NoEventDispatchAssertion::isEventDispatchForbidden()
https://bugs.webkit.org/show_bug.cgi?id=112620

  • platform/mac/TestExpectations:
1:57 PM Changeset in webkit [146118] by Simon Fraser
  • 2 edits in trunk/LayoutTests

http/tests/navigation/navigation-redirect-schedule-crash.html asserts sometimes
https://bugs.webkit.org/show_bug.cgi?id=112617

  • platform/mac/TestExpectations:
1:56 PM Changeset in webkit [146117] by hans@chromium.org
  • 3 edits
    2 adds in trunk

Fix GridTrackSize::operator==
https://bugs.webkit.org/show_bug.cgi?id=112501

Reviewed by Eric Seidel.

Source/WebCore:

There was a missing "other." in the function.

This was found by experimenting with a potential new Clang warning.

Test: fast/css-grid-layout/grid-dynamic-updates-relayout.html

  • rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::operator==):

LayoutTests:

Add a test to check that style changes cause relayout correctly.

  • fast/css-grid-layout/grid-dynamic-updates-relayout-expected.txt: Added.
  • fast/css-grid-layout/grid-dynamic-updates-relayout.html: Added.
1:48 PM Changeset in webkit [146116] by alecflett@chromium.org
  • 3 edits in trunk

Inspector: [Chromium] http/tests/inspector/indexeddb/database-data.html ASSERT on Win7 following r133855
https://bugs.webkit.org/show_bug.cgi?id=101618

Deactivate transactions created by the inspector, before
they are reactivated by IndexedDB. This puts transactions
in an identical state as when they are created by scripts.

Reviewed by Vsevolod Vlasov.

Test: http/tests/inspector/indexeddb/database-data.html

  • inspector/InspectorIndexedDBAgent.cpp: Make transactions inactive upon leaving the inspector code.
1:45 PM Changeset in webkit [146115] by jpfau@apple.com
  • 5 edits
    12 adds in trunk

Allow blocking of application cache in third-party contexts
https://bugs.webkit.org/show_bug.cgi?id=112288

Reviewed by Adam Barth.

Source/WebCore:

Return early if we can't access the application cache due to security
restrictions.

Tests: http/tests/security/cross-origin-appcache-allowed.html

http/tests/security/cross-origin-appcache.html
http/tests/security/same-origin-appcache-blocked.html

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::selectCache):
(WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):

  • page/SecurityOrigin.h:

(WebCore::SecurityOrigin::canAccessApplicationCache):

LayoutTests:

  • http/tests/security/cross-origin-appcache-allowed-expected.txt: Added.
  • http/tests/security/cross-origin-appcache-allowed.html: Added.
  • http/tests/security/cross-origin-appcache-expected.txt: Added.
  • http/tests/security/cross-origin-appcache.html: Added.
  • http/tests/security/resources/cross-origin-iframe-for-appcache-allowed.html: Added.
  • http/tests/security/resources/cross-origin-iframe-for-appcache.html: Added.
  • http/tests/security/resources/manifest-for-appcache-allowed.manifest: Added.
  • http/tests/security/resources/manifest-for-appcache-blocked.manifest: Added.
  • http/tests/security/resources/manifest-for-appcache.manifest: Added.
  • http/tests/security/resources/same-origin-iframe-for-appcache-blocked.html: Added.
  • http/tests/security/same-origin-appcache-blocked-expected.txt: Added.
  • http/tests/security/same-origin-appcache-blocked.html: Added.
  • platform/chromium/TestExpectations:
1:37 PM Changeset in webkit [146114] by Simon Fraser
  • 2 edits in trunk/LayoutTests

plugins/plugin-clip-subframe.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=112616

  • platform/mac/TestExpectations:
1:28 PM Changeset in webkit [146113] by tony@chromium.org
  • 4 edits
    2 copies in branches/chromium/1410

Merge 142928 "Crash when selecting a HarfBuzz text run with SVG ..."

Crash when selecting a HarfBuzz text run with SVG fonts included
https://bugs.webkit.org/show_bug.cgi?id=109833

Reviewed by Tony Chang.

Source/WebCore:

There is an assert in SimpleFontData::applyTransforms that should not
be there, as the code is valid for SVG fonts. If we get past this,
then the HarfBuzz text run shaping code assumes that font data has a
SkTypeface member, and SVG fonts do not. So we crash there too.

For now, we fix the crashes. This still leaves incorrect selection
rectangles in this situation, on all platforms, tracked in
https://bugs.webkit.org/show_bug.cgi?id=108133

Test: svg/css/font-face-crash.html

  • platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::applyTransforms): Remove ASSERT_NOT_REACHED as the code can legally be reached for SVG fonts.

  • platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Check for SVG fonts in the text run, and abort if we find them.

LayoutTests:

Only known to crash on Chromium Linux (without the patch), but other platforms may be affected.

  • svg/css/font-face-crash-expected.txt: Added.
  • svg/css/font-face-crash.html: Added.

TBR=schenney@chromium.org
Review URL: https://codereview.chromium.org/12919016

1:27 PM Changeset in webkit [146112] by vsevik@chromium.org
  • 5 edits in trunk

Web Inspector: Script should know nothing about disabled source mappings.
https://bugs.webkit.org/show_bug.cgi?id=112580

Reviewed by Pavel Feldman.

Source/WebCore:

ResourceScriptMapping handles diverged uiSourceCodes internally now.

Tested in inspector/debugger/live-edit-breakpoints.html already.

  • inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._hasMergedToVM):
(WebInspector.ResourceScriptMapping.prototype._hasDivergedFromVM):

  • inspector/front-end/Script.js:

(WebInspector.Script.prototype.rawLocationToUILocation):

LayoutTests:

  • inspector/debugger/breakpoint-manager.html:
1:26 PM Changeset in webkit [146111] by pilgrim@chromium.org
  • 17 edits
    1 copy in trunk

[Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
https://bugs.webkit.org/show_bug.cgi?id=112571

Reviewed by Adam Barth.

Source/Platform:

New top-level enum (not tied to WebFileSystem class) will allow
easier refactoring of filesystem methods within the Platform/
directory. (All changes are behind an #ifdef so we can sync
required changes in embedders.)

  • chromium/public/WebFileSystemType.h: new file

(WebKit):

  • Platform.gypi:
  • chromium/public/WebFileSystem.h:
  • chromium/public/WebFileSystemType.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.

(WebKit):

Source/WebKit/chromium:

Update function declarations for new WebFileSystemType enum. (All
changes are behind an #ifdef so we can sync required changes in embedders.)

  • public/WebCommonWorkerClient.h:

(WebCommonWorkerClient):
(WebKit::WebCommonWorkerClient::openFileSystem):

  • public/WebFrame.h:

(WebFrame):

  • public/WebFrameClient.h:

(WebFrameClient):
(WebKit::WebFrameClient::openFileSystem):
(WebKit::WebFrameClient::deleteFileSystem):

  • src/LocalFileSystemChromium.cpp:

(WebCore):
(WebCore::openFileSystemHelper):
(WebCore::LocalFileSystem::deleteFileSystem):

  • src/WebFrameImpl.cpp:

(WebKit):
(WebKit::WebFrameImpl::createFileSystem):
(WebKit::WebFrameImpl::createSerializableFileSystem):
(WebKit::WebFrameImpl::createFileEntry):

  • src/WebFrameImpl.h:

(WebFrameImpl):

  • src/WebWorkerClientImpl.cpp:

(WebKit):
(WebKit::WebWorkerClientImpl::openFileSystem):

  • src/WebWorkerClientImpl.h:
  • src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit):
(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):

  • src/WorkerFileSystemCallbacksBridge.h:

(WorkerFileSystemCallbacksBridge):

Tools:

Update function declarations for new WebFileSystemType enum. (All
changes are behind an #ifdef so we can sync required changes in embedders.)

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::openFileSystem):
(WebViewHost::deleteFileSystem):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

1:25 PM Changeset in webkit [146110] by ap@apple.com
  • 3 edits in trunk/Source/WebCore

Update MessagePort terminology to match HTML5
https://bugs.webkit.org/show_bug.cgi?id=112611

Reviewed by Anders Carlsson.

Transferable objects are "neutered" when transfered. Cloning is a different operation.

  • dom/MessagePort.cpp:

(WebCore::MessagePort::disentanglePorts):

  • dom/MessagePort.h:

(WebCore::MessagePort::isEntangled):
(WebCore::MessagePort::isNeutered):

1:23 PM Changeset in webkit [146109] by roger_fong@apple.com
  • 5 edits in trunk/Source

AppleWin VS2010 build fix.

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
1:23 PM Changeset in webkit [146108] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Another asserting test.

  • platform/mac/TestExpectations:
1:18 PM Changeset in webkit [146107] by Simon Fraser
  • 3 edits in trunk/LayoutTests

Mark a couple of asserty tests as such.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
12:56 PM Changeset in webkit [146106] by jparent@chromium.org
  • 3 edits
    1 copy in trunk/Tools

Cleanup: Move timeline_exporer js out of html file into js.
https://bugs.webkit.org/show_bug.cgi?id=112188

Reviewed by Dirk Pranke.

Moves the javascript out of the html file and into a new js file.
This follows the format of flakiness_dashboard.{html|js}.

Also moves code from dashboard_base that is used only by this one
dashboard, and makes it private to the dashboard.

  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/timeline_explorer.html:
  • TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.

(generatePage):
(initCurrentBuilderTestResults):
(shouldShowWebKitRevisionsOnly):
(updateTimelineForBuilder.):
(updateTimelineForBuilder):
(selectBuild):
(updateBuildIndicator):
(.addRow):
(.addNumberRow):
(.inspectorNode.getElementsByTagName.0.onclick):
(.inspectorNode.getElementsByTagName.1.onclick):
(.inspectorNode.getElementsByTagName.2.onclick):
(updateBuildInspector):
(showResultsDelta):
(decompressResults.addFlakyDelta):
(decompressResults):

12:45 PM Changeset in webkit [146105] by kbr@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Added expectation for failing test.
https://bugs.webkit.org/show_bug.cgi?id=112610

  • platform/chromium/TestExpectations:
12:43 PM Changeset in webkit [146104] by commit-queue@webkit.org
  • 7 edits
    20 adds in trunk

[css3-text] Add rendering support for -webkit-text-underline-position
https://bugs.webkit.org/show_bug.cgi?id=102795

Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-03-18
Reviewed by Levi Weintraub.

Source/WebCore:

This patch implements rendering support for values [ auto | alphabetic | under ]
of CSS3 property text-underline-position. We don't fully match the specification
as we don't support [ left | right ] and this is left for another implementation
as the rendering will need to be added.

Tests: fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html

fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic.html
fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto.html
fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow.html
fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeMaxLogicalTop): Added method to compute maximal logical top among all chidren of
this InlineTextBox.

  • rendering/InlineFlowBox.h:

(InlineFlowBox):

  • rendering/InlineTextBox.cpp:

(WebCore::computeUnderlineOffset): Added method to compute offset for text-underline-position property.
(WebCore::InlineTextBox::paintDecoration): Paint decoration at position calculated using computeUnderlineOffset().

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::alignBoxesInBlockDirection): Call method to compute maximal logical top among all
children of this RootInlineBox.

  • rendering/RootInlineBox.h:

(RootInlineBox):
(WebCore::RootInlineBox::maxLogicalTop): Added getter for m_maxLogicalTop class member.

  • rendering/style/RenderStyle.h: Added the usual getter / setter / initial methods for text-underline-position

property

LayoutTests:

Added text-underline-position tests for 'text-underline-position' CSS3
property, with 'webkit' prefix.

  • fast/css3-text/css3-text-decoration/text-underline-position/style.css: Added.
  • fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all-expected.txt: Added.
  • fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html: Added.
  • fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic-expected.txt: Added.
  • fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic.html: Added.
  • fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto-expected.txt: Added.
  • fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto.html: Added.
  • fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-expected.txt: Added.
  • fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow-expected.txt: Added.
  • fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow.html: Added.
  • fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under.html: Added.
  • platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all-expected.png: Added.
  • platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic-expected.png: Added.
  • platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto-expected.png: Added.
  • platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-expected.png: Added.
  • platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow-expected.png: Added.
12:32 PM Changeset in webkit [146103] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Convert old flexbox uses in html.css to new flexbox (non-<select>)
https://bugs.webkit.org/show_bug.cgi?id=110837

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-18
Reviewed by Ojan Vafai.

No new tests (No change in behaviour)

  • css/html.css:

(input::-webkit-clear-button):
Missed this one in the original patch.

12:26 PM Changeset in webkit [146102] by james.wei@intel.com
  • 6 edits in trunk/Source/WebCore

AudioBasicProcessorNode need to check for deferred updating of output channels
https://bugs.webkit.org/show_bug.cgi?id=112544

There can in rare cases be a slight delay before the output
bus is updated to the new number of channels because of tryLocks() in the
context's updating system but the processor already updated to the new
number of channels, so need to check the channel number before processing.

Reviewed by Chris Rogers.

  • Modules/webaudio/AudioBasicProcessorNode.cpp:

(WebCore::AudioBasicProcessorNode::process):

  • Modules/webaudio/WaveShaperProcessor.cpp:

(WebCore::WaveShaperProcessor::process):

  • platform/audio/AudioDSPKernelProcessor.cpp:

(WebCore::AudioDSPKernelProcessor::AudioDSPKernelProcessor):

  • platform/audio/AudioDSPKernelProcessor.h:

(WebCore::AudioDSPKernelProcessor::numberOfChannels):
(AudioDSPKernelProcessor):

  • platform/audio/AudioProcessor.h:

(WebCore::AudioProcessor::AudioProcessor):
(AudioProcessor):

12:20 PM Changeset in webkit [146101] by dpranke@chromium.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r145272.
http://trac.webkit.org/changeset/145272
https://bugs.webkit.org/show_bug.cgi?id=111884

Turns out the ASAN build is still broken; possibly there's
something still setting LD_LIBRARY_PATH, or possibly there's
something else wrong. In the meantime, we need it to work again.

  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
12:11 PM Changeset in webkit [146100] by msaboff@apple.com
  • 4 edits
    9 adds in trunk

Potentially unsafe register allocations in DFG code generation
https://bugs.webkit.org/show_bug.cgi?id=112477

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Moved allocation of temporary GPRs to be before any generated branches in the functions below.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):

LayoutTests:

New tests added to verify proper operation of
SpeculativeJIT::compileObjectToObjectOrOtherEquality,
SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality
and SpeculativeJIT::compileObjectOrOtherLogicalNot.

  • fast/js/dfg-compare-final-object-to-final-object-or-other-expected.txt: Added.
  • fast/js/dfg-compare-final-object-to-final-object-or-other.html: Added.
  • fast/js/dfg-logical-not-final-object-or-other-expected.txt: Added.
  • fast/js/dfg-logical-not-final-object-or-other.html: Added.
  • fast/js/dfg-peephole-compare-final-object-to-final-object-or-other-expected.txt: Added.
  • fast/js/dfg-peephole-compare-final-object-to-final-object-or-other.html: Added.
  • fast/js/script-tests/dfg-compare-final-object-to-final-object-or-other.js: Added.
  • fast/js/script-tests/dfg-logical-not-final-object-or-other.js: Added.
  • fast/js/script-tests/dfg-peephole-compare-final-object-to-final-object-or-other.js: Added.
12:05 PM Changeset in webkit [146099] by aelias@chromium.org
  • 7 edits
    2 copies in branches/chromium/1410

Merge 145954 "TextIterator emits LF for a br element inside an e..."

TextIterator emits LF for a br element inside an empty input element
https://bugs.webkit.org/show_bug.cgi?id=112275

Patch by Aurimas Liutikas <aurimas@chromium.org> on 2013-03-15
Reviewed by Ryosuke Niwa.

Source/WebCore:

Adding a check to avoid emiting LF for br elements inside a shadow tree
of an input element.

Test: editing/text-iterator/basic-iteration.html

editing/text-iterator/basic-iteration-shadowdom.html

  • editing/TextIterator.cpp:

(WebCore::shouldEmitNewlineForNode):
(WebCore::TextIterator::handleNonTextNode):
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
(WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode):
(WebCore::SimplifiedBackwardsTextIterator::exitNode):

  • editing/TextIterator.h:

(SimplifiedBackwardsTextIterator):

LayoutTests:

  • editing/text-iterator/basic-iteration-expected.txt: Extended to add two more cases.
  • editing/text-iterator/basic-iteration-shadowdom-expected.txt: Added.
  • editing/text-iterator/basic-iteration-shadowdom.html: Added.
  • editing/text-iterator/script-tests/basic-iteration.js: Extended to add two mroe cases.
  • platform/mac/TestExpectations:

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12780019

12:04 PM Changeset in webkit [146098] by jchaffraix@webkit.org
  • 3 edits
    2 adds in trunk

[CSS Grid Layout] Fix StyleGridData::operator==
https://bugs.webkit.org/show_bug.cgi?id=112574

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-auto-flow-update.html

  • rendering/style/StyleGridData.h:

(WebCore::StyleGridData::operator==):
Fixed a bad comparison that would make us ignore grid-auto-flow changes.

LayoutTests:

  • fast/css-grid-layout/grid-auto-flow-update-expected.txt: Added.
  • fast/css-grid-layout/grid-auto-flow-update.html: Added.
11:55 AM Changeset in webkit [146097] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit/win

Fix typo on Windows following r145849 that was causing DRT to crash 100% of the time.

  • WebView.cpp:

(WebView::setSmartInsertDeleteEnabled):
(WebView::setSelectTrailingWhitespaceEnabled):

11:52 AM Changeset in webkit [146096] by kbr@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marked flaky tests.
https://bugs.webkit.org/show_bug.cgi?id=112598
https://bugs.webkit.org/show_bug.cgi?id=112601
https://bugs.webkit.org/show_bug.cgi?id=112603

  • platform/chromium/TestExpectations:
11:41 AM Changeset in webkit [146095] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Mac build fix after http://trac.webkit.org/changeset/146088

  • NetworkProcess/mac/NetworkResourceLoaderMac.mm:

(WebKit::NetworkResourceLoader::platformDidReceiveResponse):

11:39 AM Changeset in webkit [146094] by rafaelw@chromium.org
  • 2 edits in trunk/Source/WebCore

[HTMLTemplateElement] parseError check in processTemplateEndTag should use hasTagName, not hasLocalName
https://bugs.webkit.org/show_bug.cgi?id=112591

Reviewed by Adam Barth.

No tests needed, change is unobservable.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processTemplateEndTag):

11:34 AM Changeset in webkit [146093] by rniwa@webkit.org
  • 2 edits in trunk/Tools

delete-stale-build-files is too aggressive
https://bugs.webkit.org/show_bug.cgi?id=112595

Reviewed by Tim Horton.

It appears that whitelisting file extensions to keep is not a good idea.
Blacklist files to delete instead, and only delete .o files for now.
We can add more file extensions as needed.

  • BuildSlaveSupport/delete-stale-build-files:
11:33 AM Changeset in webkit [146092] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Prevent text selection inside Colour and Date/Time input fields
https://bugs.webkit.org/show_bug.cgi?id=111733

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
Reviewed by Rob Buis.

Fix missing brace.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

11:32 AM Changeset in webkit [146091] by jknotten@chromium.org
  • 5 edits
    2 adds in trunk/Source/WebKit/chromium

[Chromium] Compositor is applying scroll offset using 'programmatic' API
https://bugs.webkit.org/show_bug.cgi?id=109712

Reviewed by James Robinson.

Ensure that the compositor uses non-programmatic APIs to scroll and
scale.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::updateMainFrameScrollPosition):
(WebKit):
(WebKit::WebViewImpl::applyScrollAndScale):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/WebFrameTest.cpp:
  • tests/WebViewTest.cpp:
  • tests/data/long_scroll.html: Added.
  • tests/data/short_scroll.html: Added.
11:29 AM Changeset in webkit [146090] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add Proximity Detector.
https://bugs.webkit.org/show_bug.cgi?id=112278

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
Reviewed by Rob Buis.

Fix variable names so they actually match the function
declarations.

Fix call to rectForPoint(), which was moved from HitTestResult to
HitTestLocation in r117091 and r126859.

  • WebKitSupport/ProximityDetector.cpp:

(BlackBerry::WebKit::ProximityDetector::findBestPoint):

11:09 AM Changeset in webkit [146089] by fpizlo@apple.com
  • 43 edits
    51 adds in trunk

DFG string conversions and allocations should be inlined
https://bugs.webkit.org/show_bug.cgi?id=112376

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

This turns new String(), String(), String.prototype.valueOf(), and
String.prototype.toString() into intrinsics. It gives the DFG the ability to handle
conversions from StringObject to JSString and vice-versa, and also gives it the
ability to handle cases where a variable may be either a StringObject or a JSString.
To do this, I added StringObject to value profiling (and removed the stale
distinction between Myarguments and Foreignarguments). I also cleaned up ToPrimitive
handling, using some of the new functionality but also taking advantage of the
existence of Identity(String:@a).

This is a 2% SunSpider speed-up. Also there are some speed-ups on V8v7 and Kraken.
On microbenchmarks that stress new String() this is a 14x speed-up.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::hasExitSite):
(JSC):

  • bytecode/DFGExitProfile.cpp:

(JSC::DFG::ExitProfile::hasExitSite):
(DFG):

  • bytecode/DFGExitProfile.h:

(ExitProfile):
(JSC::DFG::ExitProfile::hasExitSite):

  • bytecode/ExitKind.cpp:

(JSC::exitKindToString):

  • bytecode/ExitKind.h:
  • bytecode/SpeculatedType.cpp:

(JSC::dumpSpeculation):
(JSC::speculationToAbbreviatedString):
(JSC::speculationFromClassInfo):

  • bytecode/SpeculatedType.h:

(JSC):
(JSC::isStringObjectSpeculation):
(JSC::isStringOrStringObjectSpeculation):

  • create_hash_table:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

  • dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::filterEdgeByUse):

  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::emitArgumentPhantoms):
(DFG):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::putStructureStoreElimination):

  • dfg/DFGEdge.h:

(JSC::DFG::Edge::shift):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):
(FixupPhase):
(JSC::DFG::FixupPhase::canOptimizeStringObjectAccess):
(JSC::DFG::FixupPhase::observeUseKindOnNode):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::hasGlobalExitSite):
(Graph):
(JSC::DFG::Graph::hasExitSite):
(JSC::DFG::Graph::clobbersWorld):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToToString):
(Node):
(JSC::DFG::Node::hasStructure):
(JSC::DFG::Node::shouldSpeculateStringObject):
(JSC::DFG::Node::shouldSpeculateStringOrStringObject):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileToStringOnCell):
(DFG):
(JSC::DFG::SpeculativeJIT::compileNewStringObject):
(JSC::DFG::SpeculativeJIT::speculateObject):
(JSC::DFG::SpeculativeJIT::speculateObjectOrOther):
(JSC::DFG::SpeculativeJIT::speculateString):
(JSC::DFG::SpeculativeJIT::speculateStringObject):
(JSC::DFG::SpeculativeJIT::speculateStringOrStringObject):
(JSC::DFG::SpeculativeJIT::speculate):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(DFG):
(JSC::DFG::SpeculativeJIT::speculateStringObjectForStructure):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGUseKind.cpp:

(WTF::printInternal):

  • dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):

  • interpreter/CallFrame.h:

(JSC::ExecState::regExpPrototypeTable):

  • runtime/CommonIdentifiers.h:
  • runtime/Intrinsic.h:
  • runtime/JSDestructibleObject.h:

(JSDestructibleObject):
(JSC::JSDestructibleObject::classInfoOffset):

  • runtime/JSGlobalData.cpp:

(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/JSObject.cpp:
  • runtime/JSObject.h:

(JSC):

  • runtime/JSWrapperObject.h:

(JSC::JSWrapperObject::allocationSize):
(JSWrapperObject):
(JSC::JSWrapperObject::internalValueOffset):
(JSC::JSWrapperObject::internalValueCellOffset):

  • runtime/StringPrototype.cpp:

(JSC):
(JSC::StringPrototype::finishCreation):
(JSC::StringPrototype::create):

  • runtime/StringPrototype.h:

(StringPrototype):

LayoutTests:

Reviewed by Geoffrey Garen.

  • fast/js/dfg-to-string-bad-toString-expected.txt: Added.
  • fast/js/dfg-to-string-bad-toString.html: Added.
  • fast/js/dfg-to-string-bad-valueOf-expected.txt: Added.
  • fast/js/dfg-to-string-bad-valueOf.html: Added.
  • fast/js/dfg-to-string-int-expected.txt: Added.
  • fast/js/dfg-to-string-int-or-string-expected.txt: Added.
  • fast/js/dfg-to-string-int-or-string.html: Added.
  • fast/js/dfg-to-string-int.html: Added.
  • fast/js/dfg-to-string-side-effect-clobbers-toString-expected.txt: Added.
  • fast/js/dfg-to-string-side-effect-clobbers-toString.html: Added.
  • fast/js/dfg-to-string-side-effect-expected.txt: Added.
  • fast/js/dfg-to-string-side-effect.html: Added.
  • fast/js/dfg-to-string-toString-becomes-bad-expected.txt: Added.
  • fast/js/dfg-to-string-toString-becomes-bad-with-dictionary-string-prototype-expected.txt: Added.
  • fast/js/dfg-to-string-toString-becomes-bad-with-dictionary-string-prototype.html: Added.
  • fast/js/dfg-to-string-toString-becomes-bad.html: Added.
  • fast/js/dfg-to-string-toString-in-string-expected.txt: Added.
  • fast/js/dfg-to-string-toString-in-string.html: Added.
  • fast/js/dfg-to-string-valueOf-becomes-bad-expected.txt: Added.
  • fast/js/dfg-to-string-valueOf-becomes-bad.html: Added.
  • fast/js/dfg-to-string-valueOf-in-string-expected.txt: Added.
  • fast/js/dfg-to-string-valueOf-in-string.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/regress/script-tests/string-concat-object.js: Added.

(foo):

  • fast/js/regress/script-tests/string-concat-pair-object.js: Added.

(foo):

  • fast/js/regress/script-tests/string-concat-pair-simple.js: Added.

(foo):

  • fast/js/regress/script-tests/string-concat-simple.js: Added.

(foo):

  • fast/js/regress/script-tests/string-cons-repeat.js: Added.

(foo):

  • fast/js/regress/script-tests/string-cons-tower.js: Added.

(foo):

  • fast/js/regress/string-concat-object-expected.txt: Added.
  • fast/js/regress/string-concat-object.html: Added.
  • fast/js/regress/string-concat-pair-object-expected.txt: Added.
  • fast/js/regress/string-concat-pair-object.html: Added.
  • fast/js/regress/string-concat-pair-simple-expected.txt: Added.
  • fast/js/regress/string-concat-pair-simple.html: Added.
  • fast/js/regress/string-concat-simple-expected.txt: Added.
  • fast/js/regress/string-concat-simple.html: Added.
  • fast/js/regress/string-cons-repeat-expected.txt: Added.
  • fast/js/regress/string-cons-repeat.html: Added.
  • fast/js/regress/string-cons-tower-expected.txt: Added.
  • fast/js/regress/string-cons-tower.html: Added.
  • fast/js/script-tests/dfg-to-string-bad-toString.js: Added.

(String.prototype.toString):
(foo):

  • fast/js/script-tests/dfg-to-string-bad-valueOf.js: Added.

(String.prototype.valueOf):
(foo):

  • fast/js/script-tests/dfg-to-string-int-or-string.js: Added.

(foo):

  • fast/js/script-tests/dfg-to-string-int.js: Added.

(foo):

  • fast/js/script-tests/dfg-to-string-side-effect-clobbers-toString.js: Added.

(foo):

  • fast/js/script-tests/dfg-to-string-side-effect.js: Added.

(foo):

  • fast/js/script-tests/dfg-to-string-toString-becomes-bad-with-dictionary-string-prototype.js: Added.

(foo):
(.String.prototype.toString):

  • fast/js/script-tests/dfg-to-string-toString-becomes-bad.js: Added.

(foo):
(.String.prototype.toString):

  • fast/js/script-tests/dfg-to-string-toString-in-string.js: Added.

(foo):
(.argument.toString):

  • fast/js/script-tests/dfg-to-string-valueOf-becomes-bad.js: Added.

(foo):
(.String.prototype.valueOf):

  • fast/js/script-tests/dfg-to-string-valueOf-in-string.js: Added.

(foo):
(.argument.valueOf):

11:05 AM Changeset in webkit [146088] by beidson@apple.com
  • 13 edits
    1 add in trunk/Source

NetworkProcess should send vm_copied, mmap'ed memory to WebProcesses when a
resource is already in the disk cache.
<rdar://problem/13414153> and https://bugs.webkit.org/show_bug.cgi?id=112387

Reviewed by Geoff Garen.

Source/WebCore:

No new tests (No change in behavior).

  • WebCore.exp.in:

Add a CFURLRequestRef accessor even in the mac NSURL-based loader:

  • platform/network/cf/ResourceRequest.h:
  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::cfURLRequest):

Source/WebKit2:

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::sendAbortingOnFailure):
(WebKit::NetworkResourceLoader::didReceiveResponse): After notifying about the response,

call platformDidReceiveResponse.

  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/mac/NetworkResourceLoaderMac.mm: Added.

(WebKit::NetworkResourceLoader::platformDidReceiveResponse): Attempt to pull a filesystem

mmap'ed buffer from the CFNetwork cache and - if it exists - abort the traditional load
and send that to the WebProcess instead.

(WebKit::NetworkResourceLoader:: fileBackedResourceMinimumSize): For now, use the VM page size.

  • NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcess): Set the threshold for what

should be backed by a file on disk instead of stored in the database.

Change SharedMemory to do a vm_copy if a previously existing buffer is being passed in:

  • Platform/SharedMemory.h:
  • Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::create):
(WebKit::SharedMemory::createWithVMCopy):

  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::shareableResourceDeallocate):
(WebKit::createShareableResourceDeallocator):
(WebKit::WebResourceLoader::didReceiveResource): Create a special CFDataRef whose buffer is

backed by a ShareableResource to send to the ResourceLoader in one chunk.

  • Shared/ShareableResource.h: Fix some comments.
  • WebKit2.xcodeproj/project.pbxproj:
11:01 AM Changeset in webkit [146087] by dino@apple.com
  • 3 edits
    2 adds in trunk

Only add wordspacing when kerning to actual word ends
https://bugs.webkit.org/show_bug.cgi?id=112507
<rdar://problem/12945869>

Reviewed by Enrica Casucci.

Source/WebCore:

When measuring text, we currently include any word spacing in
the result (it's removed later). When kerning is active, we
were adding the word spacing to every wordMeasurement instance
whether or not it is a separate word. For example, a nested
<span> element would get a wordMeasurement, even though it
should not always get word spacing.

Test: fast/text/word-space-with-kerning-3.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun): Test if the current character
referenced by the wordMeasurement is a space character, and add word
spacing only then.

LayoutTests:

  • fast/text/word-space-with-kerning-3-expected.html: Added.
  • fast/text/word-space-with-kerning-3.html: Added.
10:57 AM Changeset in webkit [146086] by tony@chromium.org
  • 56 edits in trunk

[chromium] Default background color of listboxes should be white
https://bugs.webkit.org/show_bug.cgi?id=112480

Reviewed by Ojan Vafai.

Source/WebCore:

I think it was an accident that list boxes got the grey background color as a
side effect of trying to get the button styling. In the default GTK+ theme on
Ubuntu, list boxes get a white background. Win and OS X also use white as the
default color.

No new tests, covered by existing pixel tests.

  • css/themeChromiumLinux.css:

Narrow the CSS rule that overrides the background color specified in html.css.
We only want to use the button color when a select is using button styling.

LayoutTests:

Update pixel results with list boxes.

  • platform/chromium-linux/fast/css/text-transform-select-expected.png:
  • platform/chromium-linux/fast/css/text-transform-select-expected.txt:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label05-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label05-expected.txt:
  • platform/chromium-linux/fast/forms/disabled-select-change-index-expected.png:
  • platform/chromium-linux/fast/forms/disabled-select-change-index-expected.txt:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.txt:
  • platform/chromium-linux/fast/forms/hidden-listbox-expected.txt:
  • platform/chromium-linux/fast/forms/listbox-bidi-align-expected.png:
  • platform/chromium-linux/fast/forms/listbox-bidi-align-expected.txt:
  • platform/chromium-linux/fast/forms/listbox-clip-expected.png:
  • platform/chromium-linux/fast/forms/listbox-clip-expected.txt:
  • platform/chromium-linux/fast/forms/listbox-hit-test-zoomed-expected.png:
  • platform/chromium-linux/fast/forms/listbox-hit-test-zoomed-expected.txt:
  • platform/chromium-linux/fast/forms/listbox-scrollbar-incremental-load-expected.png:
  • platform/chromium-linux/fast/forms/listbox-scrollbar-incremental-load-expected.txt:
  • platform/chromium-linux/fast/forms/listbox-width-change-expected.png:
  • platform/chromium-linux/fast/forms/listbox-width-change-expected.txt:
  • platform/chromium-linux/fast/forms/option-strip-whitespace-expected.png:
  • platform/chromium-linux/fast/forms/option-strip-whitespace-expected.txt:
  • platform/chromium-linux/fast/forms/select-block-background-expected.png:
  • platform/chromium-linux/fast/forms/select-block-background-expected.txt:
  • platform/chromium-linux/fast/forms/select-change-listbox-size-expected.png:
  • platform/chromium-linux/fast/forms/select-change-listbox-size-expected.txt:
  • platform/chromium-linux/fast/forms/select-change-popup-to-listbox-expected.png:
  • platform/chromium-linux/fast/forms/select-change-popup-to-listbox-expected.txt:
  • platform/chromium-linux/fast/forms/select-initial-position-expected.png:
  • platform/chromium-linux/fast/forms/select-initial-position-expected.txt:
  • platform/chromium-linux/fast/forms/select-item-background-clip-expected.png:
  • platform/chromium-linux/fast/forms/select-item-background-clip-expected.txt:
  • platform/chromium-linux/fast/forms/select-list-box-with-height-expected.png:
  • platform/chromium-linux/fast/forms/select-list-box-with-height-expected.txt:
  • platform/chromium-linux/fast/forms/select-listbox-multiple-no-focusring-expected.png:
  • platform/chromium-linux/fast/forms/select-listbox-multiple-no-focusring-expected.txt:
  • platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png:
  • platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt:
  • platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.png:
  • platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.txt:
  • platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png:
  • platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.txt:
  • platform/chromium-linux/fast/repaint/select-option-background-color-expected.png:
  • platform/chromium-linux/fast/repaint/select-option-background-color-expected.txt:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.txt:
  • platform/chromium-linux/fast/text/drawBidiText-expected.png:
  • platform/chromium-linux/fast/text/drawBidiText-expected.txt:
  • platform/chromium-linux/fast/text/international/bidi-listbox-atsui-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-listbox-atsui-expected.txt:
  • platform/chromium-linux/fast/text/international/bidi-listbox-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-listbox-expected.txt:
  • platform/chromium-linux/fast/text/updateNewFont-expected.png:
  • platform/chromium-linux/fast/text/updateNewFont-expected.txt:
10:53 AM Changeset in webkit [146085] by kbr@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r146079.
http://trac.webkit.org/changeset/146079
https://bugs.webkit.org/show_bug.cgi?id=112594

many timeline tests failed. (Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-18

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.setMode):
(WebInspector.TimelineOverviewPane.prototype._setFrameMode):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
(WebInspector.TimelineOverviewPane.prototype.zoomToFrame):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.TimelineOverviewPane.prototype.windowLeft):
(WebInspector.TimelineOverviewPane.prototype.windowRight):
(WebInspector.TimelineOverviewPane.prototype._updateWindow):

10:49 AM Changeset in webkit [146084] by peter@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] The <select> element on Android should also switch to new-flexbox
https://bugs.webkit.org/show_bug.cgi?id=112559

Reviewed by Ojan Vafai.

Following r145959, also update themeChromiumAndroid.css to use the new
flexible box CSS properties. Covered by existing tests.

  • css/themeChromiumAndroid.css:

(select[size][multiple]):

10:38 AM Changeset in webkit [146083] by reni@webkit.org
  • 3 edits
    2 adds in trunk

Source/WebCore: Assertion faulire in SVGAnimatedPath.
https://bugs.webkit.org/show_bug.cgi?id=106428

Reviewed by Allan Sandfeld Jensen.

The asserts are too restricted. The size must be greater or equal to 1.

Test: svg/animations/animated-path-via-use-debug-crash.svg

  • svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPathAnimator::resetAnimValToBaseVal):

LayoutTests: Assertion faulire in SVGAnimatedPath
https://bugs.webkit.org/show_bug.cgi?id=106428

Reviewed by Allan Sandfeld Jensen.

  • svg/animations/animated-path-via-use-debug-crash.svg: Added.
10:34 AM Changeset in webkit [146082] by Simon Fraser
  • 4 edits in trunk

[Mac] Some tests intermittently asserts in SharedBuffer::releasePurgeableBuffer()
https://bugs.webkit.org/show_bug.cgi?id=105986

Source/WebCore:

Reviewed by Brady Eidson.

A ResourceBuffer's SharedBuffer can be vended out to other clients,
for example Images, so there's no guarantee that when the
ResourceBuffer only has one ref its SharedBuffer will also have just one.
When this assumption was broken, SharedBuffer::releasePurgeableBuffer()
would assert.

Ideally SharedBuffer would be entirely encapsulated by ResourceBuffer to
avoid this problem, but ResourceBuffer can't be used by code in platform/.

Fix by having ResourceBuffer::createPurgeableBuffer() refuse to make
a purgeable buffer if the sharedBuffer has more than one ref.

Tested by existing tests.

  • loader/ResourceBuffer.cpp:

(WebCore::ResourceBuffer::createPurgeableBuffer):

LayoutTests:

Reviewed by Brady Eidson.

Remove expected Crashes for tests which should be fixed by this change.

  • platform/mac/TestExpectations:
10:28 AM Changeset in webkit [146081] by Simon Fraser
  • 5 edits in trunk/Tools

Disable accessibility notifications after each test
https://bugs.webkit.org/show_bug.cgi?id=112579

Reviewed by Tim Horton.

In WebKitTestRunner, if any tests triggered accessibility notifications,
the global notification handler would thereafter be active, and fire
notifications for all subsequent tests.

Fix by implementing AccessibilityController::resetToConsistentState() for
Mac, and using it to clear the global notification handler.

  • WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
  • WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:

(WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
(WTR::AccessibilityController::removeNotificationListener): Explicitly call
-stopObserving so that unregistering the observer doesn't rely on object lifetimes
(e.g. because of -autorelease).
(WTR::AccessibilityController::logAccessibilityEvents): Stub.
(WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
if there is one.

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:

Add -stopObserving

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:

(-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
(-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
center.

10:28 AM Changeset in webkit [146080] by kbr@google.com
  • 5 edits in trunk/LayoutTests

Unreviewed. Added new test expectations after r146072.
https://bugs.webkit.org/show_bug.cgi?id=112562

  • platform/chromium-mac-lion/tables/mozilla/bugs/bug73321-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug73321-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug73321-expected.png:
10:16 AM Changeset in webkit [146079] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: move _timelineGrid && _timelineOverviewWindow from TimelineOverviewPane into a new class OverviewGrid.
https://bugs.webkit.org/show_bug.cgi?id=112584

Reviewed by Pavel Feldman.

It is the first path in the set.
The end goal is to extract OverviewGrid with window selectors
into a separate class in separate file and reuse it in CPU FlameChart.

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.OverviewGrid):
(WebInspector.OverviewGrid.prototype.get grid):
(WebInspector.OverviewGrid.prototype.get clientWidth):
(WebInspector.OverviewGrid.prototype.showItemsGraphsElement):
(WebInspector.OverviewGrid.prototype.hideItemsGraphsElement):
(WebInspector.OverviewGrid.prototype.updateDividers):
(WebInspector.OverviewGrid.prototype.addEventDividers):
(WebInspector.OverviewGrid.prototype.removeEventDividers):
(WebInspector.OverviewGrid.prototype.setWindowPosition):
(WebInspector.OverviewGrid.prototype.reset):
(WebInspector.OverviewGrid.prototype.get windowLeft):
(WebInspector.OverviewGrid.prototype.get windowRight):
(WebInspector.OverviewGrid.prototype.setWindow):
(WebInspector.OverviewGrid.prototype.addEventListener):
(WebInspector.TimelineOverviewPane.prototype.setMode):
(WebInspector.TimelineOverviewPane.prototype._setFrameMode):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
(WebInspector.TimelineOverviewPane.prototype.zoomToFrame):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.TimelineOverviewPane.prototype.windowLeft):
(WebInspector.TimelineOverviewPane.prototype.windowRight):
(WebInspector.TimelineOverviewPane.prototype._updateWindow):

10:14 AM Changeset in webkit [146078] by danakj@chromium.org
  • 2 edits in trunk/Tools

[chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
https://bugs.webkit.org/show_bug.cgi?id=112392

Reviewed by James Robinson.

Removes the command line flag option from DRT.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

10:03 AM Changeset in webkit [146077] by antonm@chromium.org
  • 2 edits in trunk/LayoutTests

Update test expectations.

Unreviewed gardening.

  • platform/chromium/TestExpectations:
10:03 AM Changeset in webkit [146076] by dgrogan@chromium.org
  • 1 edit in branches/chromium/1410/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp

Merge 145824 "IndexedDB: Histogram leveldb open errors."

IndexedDB: Histogram leveldb open errors.
https://bugs.webkit.org/show_bug.cgi?id=112307

Reviewed by Tony Chang.

No new tests, I don't know if there's a good way to test histograms.

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::open):

TBR=dgrogan@chromium.org
Review URL: https://codereview.chromium.org/12779020

10:01 AM Changeset in webkit [146075] by mikhail.pozdnyakov@intel.com
  • 7 edits in trunk/Source/WebKit2

[WK2][EFL] Fix code wrapping WKPageGroupRef
https://bugs.webkit.org/show_bug.cgi?id=112364

Reviewed by Alexey Proskuryakov.

The patch fixes following problems in EWK2 WKPageGroupRef wrapping
code: firstly it makes sure that there is only one EwkPageGroup
instance per WKPageGroup instance, secondly it allows web page to
to use the default page group (which is implicitly created inside
web context).

  • UIProcess/API/C/efl/WKView.cpp:

(createWKView):

Now may pass '0' page group as a WebView creation argument so
that the default page group is used.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::createEvasObject):

  • UIProcess/API/efl/EwkView.h:

(EwkView):

Web view should be created before page group, so they are rearranged
inside class declaration.

  • UIProcess/API/efl/ewk_page_group.cpp:

(pageGroupMap):

A map to track corresponding EwkPageGroup and WKPageGroup
instances.

(EwkPageGroup::findOrCreateWrapper):

Returns the same EwkPageGroup instance for the same WKPageGroup
instance.

(EwkPageGroup::create):
(EwkPageGroup::EwkPageGroup):

Now there is only one constructor accepting WKPageGroupRef.

(EwkPageGroup::~EwkPageGroup):

  • UIProcess/API/efl/ewk_page_group_private.h:

(EwkPageGroup):

  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

9:56 AM Changeset in webkit [146074] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

[V8] Crash when accessing onclick attribute of document from XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=112585

Reviewed by Eric Seidel.

Source/WebCore:

This ASSERT was bogus. The frame can be 0 for frameless documents, like
those created by XMLHttpRequest. When there is no frame, we act as if
JavaScript was disabled, which it is.

Test: fast/events/xhr-onclick-crash.html

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

LayoutTests:

  • fast/events/resources/onclick.html: Added.
  • fast/events/xhr-onclick-crash-expected.txt: Added.
  • fast/events/xhr-onclick-crash.html: Added.
9:54 AM Changeset in webkit [146073] by hmuller@adobe.com
  • 3 edits
    4 adds in trunk

[CSS Exclusions] Specifying polygonal -webkit-shape-inside value can crash browser (debug mode)
https://bugs.webkit.org/show_bug.cgi?id=112157

Reviewed by David Hyatt.

Source/WebCore:

Corrected the code which maps exclusion segments to pairs of InlineIterators. We now handle the
cases where the end of the line occurs within an exclusion segment or when it occurs before
the last exclusion segment has been reached. This can occur when a non-convex polygonal shape-inside
breaks a line up into two segments, but the shape-inside element's content only fills (or partially
fills) the first exclusion shape segment.

Tests: fast/exclusions/shape-inside/shape-inside-partial-fill-001.html

fast/exclusions/shape-inside/shape-inside-partial-fill-002.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):

LayoutTests:

Added tests with a polygonal shape-inside exclusion shape, where multiple shape
segments exist on one line, but the line's text either partially or completely
fills only the first exclusion shape segment.

  • fast/exclusions/shape-inside/shape-inside-partial-fill-001-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-partial-fill-001.html: Added.
  • fast/exclusions/shape-inside/shape-inside-partial-fill-002-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-partial-fill-002.html: Added.
9:16 AM Changeset in webkit [146072] by eae@chromium.org
  • 4 edits
    2 adds in trunk

Change RenderTableCell to use pixelSnappedSize when painting
https://bugs.webkit.org/show_bug.cgi?id=112562

Reviewed by Eric Seidel.

Source/WebCore:

Change the paining code in RenderTableCell to use the pixel snapped size
to ensure consistent rounding given that the location was rounded during
layout.

It is currently constructing a paint rect by taking the rounded location
and the precise size and then pixel snapping it. This causes the size to
be rounded incorrectly. By instead using the pixel snapped size the
rounding problem can be avoided.

Test: fast/sub-pixel/table-cell-background.html

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintCollapsedBorders):
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
(WebCore::RenderTableCell::paintBoxDecorations):
(WebCore::RenderTableCell::paintMask):

LayoutTests:

Add test for painting of cell backgrounds on a sub-pixel boundary.

  • fast/sub-pixel/table-cell-background-expected.html: Added.
  • fast/sub-pixel/table-cell-background.html: Added.
  • platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png:
9:16 AM Changeset in webkit [146071] by fpizlo@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

ObjectPrototype properties should be eagerly created rather than lazily via static tables
https://bugs.webkit.org/show_bug.cgi?id=112539

Reviewed by Oliver Hunt.

This is the first part of https://bugs.webkit.org/show_bug.cgi?id=112233. Rolling this
in first since it's the less-likely-to-be-broken part.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • interpreter/CallFrame.h:

(JSC::ExecState::objectConstructorTable):

  • runtime/CommonIdentifiers.h:
  • runtime/JSGlobalData.cpp:

(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/JSObject.cpp:

(JSC::JSObject::putDirectNativeFunction):
(JSC):

  • runtime/JSObject.h:

(JSObject):
(JSC):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/ObjectPrototype.cpp:

(JSC):
(JSC::ObjectPrototype::finishCreation):
(JSC::ObjectPrototype::create):

  • runtime/ObjectPrototype.h:

(ObjectPrototype):

9:13 AM Changeset in webkit [146070] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

Access settings.defaultVideoPosterURL
https://bugs.webkit.org/show_bug.cgi?id=112378

Patch by Tao Bai <michaelbai@chromium.org> on 2013-03-18
Reviewed by Dimitri Glazkov.

The defaultVideoPosterURL setting has been added in
https://bugs.webkit.org/show_bug.cgi?id=110263,
this added methods to access it in Chromium.
The settings will be used by Android WebView API
WebChromeClient.getDefaultVideoPoster()

  • public/WebSettings.h: add setDefaultVideoPosterURL
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setDefaultVideoPosterURL): set defaultVideoPosterURL

  • src/WebSettingsImpl.h: add setDefaultVideoPosterURL
9:12 AM Changeset in webkit [146069] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Need to use const String in HTMLVideoElement::posterImageURL
https://bugs.webkit.org/show_bug.cgi?id=112317

Patch by Tao Bai <michaelbai@chromium.org> on 2013-03-18
Reviewed by Andreas Kling.

No behavioral changes.

This is the followup of https://bugs.webkit.org/show_bug.cgi?id=110263
Need to use String instead of const AtomicString& which means we will do an extra hash lookup

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::posterImageURL): Change to use String for url

8:49 AM Changeset in webkit [146068] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl/TestExpectations: Remove

editing/pasteboard/paste-4035648-fix.html from the skipped list after
r144999.

8:33 AM Changeset in webkit [146067] by zandobersek@gmail.com
  • 4 edits
    3 adds in trunk

[GTK] plugins/plugin-clip-subframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112570

Reviewed by Martin Robinson.

Tools:

  • GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.

LayoutTests:

  • platform/gtk-wk2/plugins/plugin-clip-subframe-expected.txt: Added the required baseline.
  • platform/gtk/TestExpectations: Removing the failure expectation.
  • platform/gtk/plugins/plugin-clip-subframe-expected.txt: Added the required baseline.
8:11 AM Changeset in webkit [146066] by eustas@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Settings] Register "?" shortcut.
https://bugs.webkit.org/show_bug.cgi?id=112545

Reviewed by Vsevolod Vlasov.

F1 and "?" (show shortcuts page) are not mentioned on shortcuts page.

  • English.lproj/localizedStrings.js: Added string.
  • inspector/front-end/inspector.js: Registered F1 / "?" shortcut.
8:09 AM CoordinatedGraphicsSystem edited by Csaba Osztrogonác
update broken URLs (diff)
7:27 AM Changeset in webkit [146065] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Add USE(PLATFORM_STRATEGIES) ifdefs to StorageNamespace.cpp
https://bugs.webkit.org/show_bug.cgi?id=112004

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-18
Reviewed by Rob Buis.

Check if platform strategies is enabled before using it, falling
back to StorageNamespaceImpl if it isn't.

  • storage/StorageNamespace.cpp:

(WebCore::StorageNamespace::localStorageNamespace):
(WebCore::StorageNamespace::sessionStorageNamespace):

7:23 AM WebKitGTK/2.0.x edited by Philippe Normand
(diff)
7:18 AM Changeset in webkit [146064] by Philippe Normand
  • 4 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r145831 - [GStreamer] simulateAudioInterruption needs to be guarded by ENABLE(VIDEO)"
https://bugs.webkit.org/show_bug.cgi?id=112358

Guarded with ENABLE(VIDEO) to prevent problems when it is not
enabled.

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

7:15 AM Changeset in webkit [146063] by Philippe Normand
  • 13 edits
    2 adds in releases/WebKitGTK/webkit-2.0

Merge r145811 - [GStreamer] Stopping playback of html5 media when receiving a higher priority audio event needs implementation
https://bugs.webkit.org/show_bug.cgi?id=91611

Source/WebCore:

React to REQUEST_STATE GStreamer message to stop the pipeline when
a higher priority stream is played. When this happens, states are
updated accordingly.

A method was added in the MediaPlayer class and internals to allow
the the test runner to simulate an audio interruption.

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

Test: media/media-higher-prio-audio-stream.html

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore):
(MediaPlayer):
(WebCore::MediaPlayer::simulateAudioInterruption): New method
delegating an audio interruption to the private backend to
simulate the use-case where an external application needs
exclusive access to the audio device.

  • platform/graphics/MediaPlayerPrivate.h:

(MediaPlayerPrivateInterface):
(WebCore::MediaPlayerPrivateInterface::simulateAudioInterruption):
Added default empty method in the common private header.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore):
(WebCore::MediaPlayerPrivateGStreamer::createAudioSink):
(WebCore::setAudioStreamPropertiesCallback): Hooked to child-added
signal on the audio sink, delegates on setAudioStreamProperties.
(WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
Sets the audio stream properties.
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
Initializes the new attribute.
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
Disconnects autoaudiosink signal.
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
Changed logging.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Reacting to
the REQUEST_STATE message.
(WebCore::MediaPlayerPrivateGStreamer::simulateAudioInterruption):
Added. Injects the REQUEST_STATE message to the pipeline.
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Updating the
playback state if REQUEST_STATE.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer): Added new method and attribute.

  • testing/Internals.h:
  • testing/Internals.idl:
  • testing/Internals.cpp:

(WebCore):
(WebCore::Internals::simulateAudioInterruption): Added to call the
method to stop the element because of a higher prio stream at the
tests.

LayoutTests:

Created test, expected result and updated other ports
expectations.

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

  • media/media-higher-prio-audio-stream-expected.txt: Added.
  • media/media-higher-prio-audio-stream.html: Added.
  • platform/chromium/TestExpectations: Skipped the new test.
  • platform/mac/TestExpectations: Skipped the new test.
  • platform/qt/TestExpectations: Skipped the new test for Mac and

Win.

7:13 AM Changeset in webkit [146062] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: TabbedEditorContainer does not restore last shown file on reload sometimes.
https://bugs.webkit.org/show_bug.cgi?id=112561

Reviewed by Alexander Pavlov.

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype.addUISourceCode):

6:56 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
6:43 AM Changeset in webkit [146061] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] EditorClientBlackBerry: fix access to WebPage attribute
https://bugs.webkit.org/show_bug.cgi?id=112556

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
Reviewed by Rob Buis.

This changed in r145849 and broke the BlackBerry build.

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::smartInsertDeleteEnabled):
(WebCore::EditorClientBlackBerry::isSelectTrailingWhitespaceEnabled):

6:24 AM WebKitGTK/2.0.x edited by kov@webkit.org
(diff)
6:22 AM Changeset in webkit [146060] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-2.0

Merge 146059 - [GTK] Exports leveldb symbols
https://bugs.webkit.org/show_bug.cgi?id=112526

Reviewed by Carlos Garcia Campos.

  • Source/autotools/symbols.filter: make leveldb symbols local.
6:19 AM Changeset in webkit [146059] by kov@webkit.org
  • 2 edits in trunk

[GTK] Exports leveldb symbols
https://bugs.webkit.org/show_bug.cgi?id=112526

Reviewed by Carlos Garcia Campos.

  • Source/autotools/symbols.filter: make leveldb symbols local.
6:05 AM Changeset in webkit [146058] by anilsson@rim.com
  • 7 edits in trunk/Source

[BlackBerry] Detach overlays from page when compositor is detached
https://bugs.webkit.org/show_bug.cgi?id=112424

Reviewed by Rob Buis.

PR 309160

Source/WebCore:

Expose a method to retrieve a compositing thread layer's client.

No change in behavior, no new tests.

  • platform/graphics/blackberry/LayerCompositingThread.h:

(WebCore::LayerCompositingThread::client):

Source/WebKit/blackberry:

If not detached properly, the overlays would have a dangling pointer to
the page.

  • Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::~WebOverlayPrivateCompositingThread):

  • Api/WebOverlay_p.h:

(BlackBerry::WebKit::WebOverlayPrivate::setClient):
(WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::overlay):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::overlayDestroyed):
(WebOverlayPrivateCompositingThread):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::detach):
(BlackBerry::WebKit::WebPageCompositorPrivate::setPage):
(WebKit):
(BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):

  • Api/WebPageCompositor_p.h:

(BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
(BlackBerry::WebKit::WebPageCompositorPrivate::detachOverlays):
(WebPageCompositorPrivate):

5:52 AM Changeset in webkit [146057] by eustas@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Resources] Local Storage: duplicate keys are processed inappropriately.
https://bugs.webkit.org/show_bug.cgi?id=112402

Reviewed by Alexander Pavlov.

When user creates new items or renames existing one some existing item
may be overriden. If value is changed, then frontend will receive
notification and update record appropriately.

If item value hasn't been changed, then no notification comes.
But UI still expect / rely on this notification.

With this patch the "no notification" scenario is fixed:
duplicate items are removed.

Another scenario is when update notification comes when we started
editing value (after entering / renaming key). In this case
selected node should not be changed to leave user in editing mode.

  • inspector/front-end/DOMStorageItemsView.js:

Added workarounds for "no notification" and "useless notification".

5:25 AM Companies and Organizations that have contributed to WebKit edited by allan.jensen@digia.com
(diff)
4:59 AM Changeset in webkit [146056] by allan.jensen@digia.com
  • 3 edits in trunk/Source/WebCore

Clean up RenderFrameSet::nodeAtPoint
https://bugs.webkit.org/show_bug.cgi?id=112450

Reviewed by Eric Seidel.

Remove handling of resizing framesets from RenderFrameSet::nodeAtPoint.
The code has been incorrect since a mistake in r18333 (December 2006),
but has been dead code since r17770 (November 2006) where the then new
EventHandler started taking care of routing events to resizing FrameSets.

Since this was the only special feature of RenderFrameSet::nodeAtPoint,
the method has been removed.

  • rendering/RenderFrameSet.cpp:
  • rendering/RenderFrameSet.h:

(RenderFrameSet):

4:48 AM Changeset in webkit [146055] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

The 'formnovalidate' attribute doesn't work correctly on button elements with child elements
https://bugs.webkit.org/show_bug.cgi?id=112541

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-18
Reviewed by Kent Tamura.

Source/WebCore:

Fix a bug where formnovalidate attribute of <button> is not honored
if the target of the click event is an element nested within the button.

Test: fast/forms/interactive-validation-formnovalidate-child.html

  • html/HTMLFormElement.cpp:

(WebCore::submitElementFromEvent): Looks for the nearest FormControlElement ancestor of the event target.

LayoutTests:

  • fast/forms/interactive-validation-formnovalidate-child-expected.txt: Added.
  • fast/forms/interactive-validation-formnovalidate-child.html: Added.
4:45 AM Changeset in webkit [146054] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r145951 - [GTK] Enforce the C++11 standard when compiling WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112169

Reviewed by Gustavo Noronha Silva.

With a limited set of supported compilers the WebKit2 source code can now
be built with the C++11 language standard enforced.

  • GNUmakefile.am:
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(injectedBundleDirectory): Adjust the string literals concatenation, moving away from empty strings
(which C++11 refuses to handle as concatenation operators) and using whitespace instead.

  • UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:

(WebKit::WebInspectorServer::platformResourceForPath): Ditto.

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::inspectorFilesBasePath): Ditto.

4:36 AM Changeset in webkit [146053] by gyuyoung.kim@samsung.com
  • 14 edits in trunk/LayoutTests

Unreviewed EFL rebaseline after r146050.

  • platform/efl/fast/css/input-search-padding-expected.txt:
  • platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/efl/fast/css/text-overflow-input-expected.txt:
  • platform/efl/fast/forms/box-shadow-override-expected.txt:
  • platform/efl/fast/forms/control-restrict-line-height-expected.txt:
  • platform/efl/fast/forms/input-appearance-height-expected.txt:
  • platform/efl/fast/forms/placeholder-position-expected.txt:
  • platform/efl/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/efl/fast/forms/search-styled-expected.txt:
  • platform/efl/fast/forms/search-vertical-alignment-expected.txt:
  • platform/efl/fast/forms/searchfield-heights-expected.txt:
  • platform/efl/fast/repaint/search-field-cancel-expected.txt:
  • platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
4:02 AM Changeset in webkit [146052] by keishi@webkit.org
  • 4 edits
    6 adds in trunk

Add touch support to the calendar picker
https://bugs.webkit.org/show_bug.cgi?id=112256

Reviewed by Kent Tamura.

Source/WebCore:

This patch increases the hit target sizes for touch and adds touch event
support to the scroll view, scroll bar and navigation button.

Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-touch-operations.html

platform/chromium/fast/forms/calendar-picker/month-picker-touch-operations.html
platform/chromium/fast/forms/calendar-picker/week-picker-touch-operations.html

  • Resources/pagepopups/calendarPicker.js:

(hasInaccuratePointingDevice):
(Animator): Super class for TransitionAnimator and FlingGestureAnimator.
(Animator.prototype.start):
(Animator.prototype.stop):
(Animator.prototype.onAnimationFrame):
(TransitionAnimator): Same as the old Animator. Transition from one value to another.
(TransitionAnimator.prototype.setFrom):
(TransitionAnimator.prototype.start):
(TransitionAnimator.prototype.stop):
(TransitionAnimator.prototype.setTo):
(TransitionAnimator.prototype.onAnimationFrame):
(FlingGestureAnimator):Animates the fling scroll.
(FlingGestureAnimator.prototype._valueAtTime): Returns the value at the given time.
(FlingGestureAnimator.prototype._velocityAtTime): Returns the value change velocity at the given time.
(FlingGestureAnimator.prototype._timeAtVelocity): Returns the time when the value is changing at the given velocity.
(FlingGestureAnimator.prototype.start):
(FlingGestureAnimator.prototype.onAnimationFrame):
(ScrollView): Added support for touch gesture scrolling.
(ScrollView.prototype.onTouchStart):
(ScrollView.prototype.onWindowTouchMove):
(ScrollView.prototype.onWindowTouchEnd):
(ScrollView.prototype.onFlingGestureAnimatorStep):
(ScrollView.prototype.scrollTo):
(ScrubbyScrollBar): Added support for touch.
(ScrubbyScrollBar.prototype.onTouchStart):
(ScrubbyScrollBar.prototype.onWindowTouchMove):
(ScrubbyScrollBar.prototype.onWindowTouchEnd):
(ScrubbyScrollBar.prototype._setThumbPositionFromEventPosition): Accept MouseEvent or Touch.
(ScrubbyScrollBar.prototype.onMouseDown):
(ScrubbyScrollBar.prototype.onWindowMouseMove):
(ScrubbyScrollBar.prototype.onWindowMouseUp):
(YearListCell):
(YearListView):
(YearListView.prototype.onTouchStart):
(YearListView.prototype._animateRow):
(CalendarNavigationButton): Add touch support for long press.
(CalendarNavigationButton.prototype.onTouchStart):
(CalendarNavigationButton.prototype.onWindowTouchEnd):
(CalendarNavigationButton.prototype.onMouseDown):
(CalendarNavigationButton.prototype.onWindowMouseUp):
(CalendarTableView): Disable touch gesture scrolling in the calendar table.

LayoutTests:

  • platform/chromium/fast/forms/calendar-picker/calendar-picker-touch-operations-expected.txt: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-touch-operations.html: Added.
  • platform/chromium/fast/forms/calendar-picker/month-picker-touch-operations-expected.txt: Added.
  • platform/chromium/fast/forms/calendar-picker/month-picker-touch-operations.html: Added.
  • platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:

(hoverOverMonthPopupButton):
(clickMonthPopupButton): Use hoverOverMonthPopupButton.

  • platform/chromium/fast/forms/calendar-picker/week-picker-touch-operations-expected.txt: Added.
  • platform/chromium/fast/forms/calendar-picker/week-picker-touch-operations.html: Added.
3:52 AM Changeset in webkit [146051] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] BackingStoreClient: remove unnecessary call to toElement()
https://bugs.webkit.org/show_bug.cgi?id=112547

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
Reviewed by Carlos Garcia Campos.

  • WebKitSupport/BackingStoreClient.cpp:

(BlackBerry::WebKit::BackingStoreClient::absoluteRect):

3:13 AM Changeset in webkit [146050] by gyuyoung.kim@samsung.com
  • 9 edits in trunk

[EFL] Cancel mark on search field is not displayed
https://bugs.webkit.org/show_bug.cgi?id=94880

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

adjustSearchFieldCancelButtonStyle() doesn't set style width and height for search cancel button.
So, the button isn't showing up in search input field. Besides the button size should be scaled based
on the font size as chromium, qt, and blackberry ports.

Tests: fast/forms/search-cancel-button-style-sharing.html

fast/forms/search-rtl.html

  • platform/efl/RenderThemeEfl.cpp:

(WebCore):
(WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):

LayoutTests:

Rebaseline expected results related to search cancel button.

  • platform/efl-wk1/TestExpectations: These tests don't work with WK1 pixel test yet.
  • platform/efl/TestExpectations:
  • platform/efl/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/efl/fast/forms/search-rtl-expected.png:
  • platform/efl/fast/forms/search-rtl-expected.txt:
2:57 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
2:47 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
2:46 AM Changeset in webkit [146049] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

[GTK] Add methods to add a user style sheet to the WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=99081

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-03-18
Reviewed by Carlos Garcia Campos.

Add methods to WebKitWebViewGroup to add and remove user style sheets.
This allows clients to inject style sheets into pages with a set of
rules for when those style sheets apply.

  • UIProcess/API/gtk/WebKitWebViewGroup.cpp:

(toImmutableArray): Added this helper which converts the GList* parameters into
ImmutableArrays for use with the WebKit2 internal API.
(webkit_web_view_group_add_user_style_sheet): Added new API for adding a style sheet.
(webkit_web_view_group_remove_all_user_style_sheets): Add new API for clearing out all style sheets.

  • UIProcess/API/gtk/WebKitWebViewGroup.h: Added new method declarations.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Added new API to the documentation.
  • UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp: Added a test for the new API.

(isStyleSheetInjectedForURLAtPath): Function to check whether the style sheet has been injected for a given URL.
(fillURLListFromPaths): Helper which converts paths passed via varargs into a whitelist or blacklist.
(removeOldInjectedStyleSheetsAndResetLists): Function to start afresh.
(testWebViewGroupInjectedStyleSheet): The actual test.
(serverCallback): Server callback for use with the test. We cannot use loadHTML or
loadAlternateHTML, because that checks the whitelist and blacklist against about:blank.
(beforeAll): Initialize the server and new test.
(afterAll): Clean up the server.

2:40 AM Changeset in webkit [146048] by yurys@chromium.org
  • 11 edits in trunk

Web Inspector: Native Memory Timeline affects the performace even if was switched off.
https://bugs.webkit.org/show_bug.cgi?id=112428

Reviewed by Pavel Feldman.

Source/WebCore:

Whether to include DOM counters and native memory statistics is now
configured using Timeline.start parameters instead of sending separate
commands Timeline.setIncludeDomCounters and Timeline.setIncludeNativeMemoryStatistics.

  • inspector/Inspector.json:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::restore):
(WebCore::InspectorTimelineAgent::start):

  • inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

  • inspector/front-end/DOMCountersGraph.js:

(WebInspector.DOMCountersGraph):

  • inspector/front-end/NativeMemoryGraph.js:

(WebInspector.NativeMemoryGraph):

  • inspector/front-end/TimelineManager.js:

(WebInspector.TimelineManager.prototype.start):

  • inspector/front-end/TimelineModel.js:

(WebInspector.TimelineModel.prototype.startRecord):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.get _toggleTimelineButtonClicked):

LayoutTests:

  • http/tests/inspector/timeline-test.js: chaned Timeline.start parameters

to match previous behavior.

2:32 AM Changeset in webkit [146047] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Exception in timeline DOMCounters
https://bugs.webkit.org/show_bug.cgi?id=112427

Reviewed by Pavel Feldman.

Do not update marker on DOM counters graph if the graphs haven't been
drawn yet.

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):

2:28 AM Changeset in webkit [146046] by li.yin@intel.com
  • 5 edits in trunk

Mediastream.ended should return true when all tracks were removed.
https://bugs.webkit.org/show_bug.cgi?id=112528

Reviewed by Kentaro Hara.

Source/WebCore:

Spec: http://dev.w3.org/2011/webrtc/editor/getusermedia.html#widl-MediaStream-ended
When all tracks have been removed, it should return true as well as all the tracks
were ended.

Test: fast/mediastream/MediaStream-add-remove-tracks.html

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::removeTrack):

LayoutTests:

  • fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
  • fast/mediastream/MediaStream-add-remove-tracks.html:
2:21 AM Changeset in webkit [146045] by caseq@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: make number of stack frames to capture in Timeline a setting
https://bugs.webkit.org/show_bug.cgi?id=110619

Reviewed by Pavel Feldman.

  • factor out creation of input type="text" control for better reuse;
  • add timelineLimitStackFramesFlag & timelineStackFramesToCapture settings;
  • English.lproj/localizedStrings.js: add "Frames to capture" and "Limit number of captured JS stack frames"
  • inspector/front-end/Settings.js: add 2 settings;

(WebInspector.Settings):

  • inspector/front-end/SettingsScreen.js: UI for the setting;

(WebInspector.GenericSettingsTab):
(WebInspector.GenericSettingsTab.prototype.get _createCSSAutoReloadControls.validateReloadTimeout):

  • inspector/front-end/TimelineModel.js: pass the setting value to back-end.
2:07 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
2:06 AM Changeset in webkit [146044] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

[WebKit2][GTK] Initialize gettext also in the UIProcess side
https://bugs.webkit.org/show_bug.cgi?id=112489

Patch by Gustavo Noronha Silva <gns@gnome.org> on 2013-03-18
Reviewed by Carlos Garcia Campos.

  • UIProcess/API/gtk/WebKitPrivate.cpp:

(wkInitialize): set text domain and codeset for the library on
process startup, the first one is required for translations to be
found when not installed on the main system directories searched
by gettext, the second one is to please glib and GTK+

2:05 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
2:04 AM Changeset in webkit [146043] by Carlos Garcia Campos
  • 41 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge r145936 - Unreviewed, build fix. Also gather translatable strings from WebKit2 files.

  • POTFILES.in: added WebKit2GTK+ files that have translatable strings.
  • ar.po: regenerated.
  • as.po: ditto.
  • bg.po: ditto.
  • cs.po: ditto.
  • de.po: ditto.
  • el.po: ditto.
  • en_CA.po: ditto.
  • en_GB.po: ditto.
  • eo.po: ditto.
  • es.po: ditto.
  • et.po: ditto.
  • eu.po: ditto.
  • fr.po: ditto.
  • gl.po: ditto.
  • gu.po: ditto.
  • he.po: ditto.
  • hi.po: ditto.
  • hu.po: ditto.
  • id.po: ditto.
  • it.po: ditto.
  • ko.po: ditto.
  • lt.po: ditto.
  • lv.po: ditto.
  • mr.po: ditto.
  • nb.po: ditto.
  • nl.po: ditto.
  • pa.po: ditto.
  • pl.po: ditto.
  • pt.po: ditto.
  • pt_BR.po: ditto.
  • ro.po: ditto.
  • ru.po: ditto.
  • sl.po: ditto.
  • sr.po: ditto.
  • sr@latin.po: ditto.
  • sv.po: ditto.
  • uk.po: ditto.
  • vi.po: ditto.
  • zh_CN.po: ditto.
1:52 AM Changeset in webkit [146042] by zarvai@inf.u-szeged.hu
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk1/TestExpectations:
  • platform/qt/TestExpectations:
1:37 AM Changeset in webkit [146041] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r146035.
http://trac.webkit.org/changeset/146035
https://bugs.webkit.org/show_bug.cgi?id=112540

fails to build on Windows: singned/unsigned mismatch at ln. 53
of html\HTMLSelectElementWin.cpp (Requested by antonm on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-18

  • WebCore.gypi:
  • html/HTMLSelectElement.cpp:

(WebCore):

  • html/HTMLSelectElementWin.cpp:
1:33 AM Changeset in webkit [146040] by haraken@chromium.org
  • 8 edits in trunk

Unreviewed, rolling out r146033.
http://trac.webkit.org/changeset/146033
https://bugs.webkit.org/show_bug.cgi?id=112521

web audio tests are broken

Source/WebCore:

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::AudioNode):

  • Modules/webaudio/AudioNode.h:
  • Modules/webaudio/AudioScheduledSourceNode.h:
  • Modules/webaudio/ScriptProcessorNode.idl:

LayoutTests:

  • webaudio/javascriptaudionode-expected.txt:
  • webaudio/javascriptaudionode.html:
1:17 AM Changeset in webkit [146039] by antonm@chromium.org
  • 3 edits in trunk/LayoutTests

Update test expectations.

Unreviewed gardening.

  • platform/chromium-win/fast/forms/color/input-appearance-color-expected.png:
  • platform/chromium/TestExpectations:
1:01 AM Changeset in webkit [146038] by dominicc@chromium.org
  • 6 edits in trunk

A placeholder renderer should not be taken to imply the existence of a text renderer in single line text controls
https://bugs.webkit.org/show_bug.cgi?id=112410

Reviewed by Tony Chang.

Source/WebCore:

The assumption that if a text control had a placeholder renderer
then it also had a text renderer is not valid. If
::-webkit-textfield-decoration-controller is set to display: none;
a single line text control's decoration container renderer and
hence text renderer are not created. This change handles this
corner case where a text control has a placeholder renderer but
not a text renderer.

Tests: fast/forms/search/search-hide-decoration-container-crash.html (Updated)

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::fixPlaceholderRenderer):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):

LayoutTests:

Update search-hide-decoration-container-crash.html to exercise
non-null placeholder renderers and null text renderers.

Cases where neither are rendered already get coverage in
search-scroll-hidden-decoration-container-crash.html and
search-autoscroll-hidden-decoration-container-crash.html.

  • fast/forms/search/search-hide-decoration-container-crash.html:
  • fast/forms/search/search-hide-decoration-container-crash-expected.txt:
12:55 AM Changeset in webkit [146037] by dominicc@chromium.org
  • 5 edits
    2 adds in trunk

[Shadow] offsetParent should never return nodes in user agent Shadow DOM to script
https://bugs.webkit.org/show_bug.cgi?id=112530

Reviewed by Elliott Sprehn.

Source/WebCore:

Test: fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html

  • dom/Element.cpp:

(WebCore::Element::bindingsOffsetParent): Filter nodes in UA shadows.

  • dom/Element.h:

(Element): Add bindingsOffsetParent.

  • dom/Element.idl: bindingsOffsetParent is the implementation of offsetParent.

LayoutTests:

  • fast/dom/shadow/offset-parent-does-not-leak-ua-shadow-expected.txt: Added.
  • fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html: Added.
12:17 AM WebKitGTK/2.0.x edited by Manuel Rego Casasnovas
Add new change on track (diff)

Mar 17, 2013:

11:40 PM Changeset in webkit [146036] by vsevik@chromium.org
  • 1 edit in branches/chromium/1410/Source/WebCore/inspector/front-end/inspector.css

Merge (partial, css only) 143224 "Web Inspector: hide vertical-sidebar-split in dock..."

Web Inspector: hide vertical-sidebar-split in dock-to-right mode behind single experimental flag.
https://bugs.webkit.org/show_bug.cgi?id=110119

Reviewed by Vsevolod Vlasov.

Removed context menus, made it toggle automatically upon dock orientation change.

  • inspector/front-end/inspector.css:

TBR=pfeldman@chromium.org
BUG=196537
Review URL: https://codereview.chromium.org/12895003

11:25 PM Changeset in webkit [146035] by dmazzoni@google.com
  • 4 edits in trunk/Source/WebCore

Support Windows HTMLSelectElement keystrokes on Chromium win
https://bugs.webkit.org/show_bug.cgi?id=112460

Reviewed by Kent Tamura.

Compile in the windows-specific variant of
HTMLSelectElement::platformHandleKeydownEvent
on Chromium win, in addition to PLATFORM(WIN).

  • WebCore.gypi:

Add html/HTMLSelectElementWin.cpp.

  • html/HTMLSelectElement.cpp:

Don't compile generic platformHandleKeydownEvent on
Chromium win.

  • html/HTMLSelectElementWin.cpp:

Only compile platformHandleKeydownEvent on Windows.

(WebCore):

10:54 PM Changeset in webkit [146034] by Simon Fraser
  • 3 edits in trunk/LayoutTests

Mark some more tests as flakey, or asserting in debug.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
10:51 PM Changeset in webkit [146033] by commit-queue@webkit.org
  • 8 edits in trunk

ScriptProcessorNode is garbage collected while still active if unreachable
https://bugs.webkit.org/show_bug.cgi?id=112521

Patch by Russell McClellan <russell.mcclellan@gmail.com> on 2013-03-17
Reviewed by Kentaro Hara.

Source/WebCore:

Fix for issue where ScriptProcessorNodes (and AudioNode js wrappers generally)
would be garbage collected before their time. Made AudioNode an ActiveDOMElement
marked pending if there are any open audio connections.

Test: webaudio/javascriptaudionode.html

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::hasPendingActivity): it's pending (and thus not GCed)
if it has open audio connections.

  • Modules/webaudio/AudioNode.h: AudioNode is now an ActiveDOMElement
  • Modules/webaudio/AudioScheduledSourceNode.h: added a using declaration

to avoid function name hiding.

  • Modules/webaudio/ScriptProcessorNode.idl: AudioNode is an ActiveDOMElement

LayoutTests:

  • webaudio/javascriptaudionode-expected.txt:
  • webaudio/javascriptaudionode.html:
10:26 PM Changeset in webkit [146032] by commit-queue@webkit.org
  • 11 edits in trunk

INPUT_MULTIPLE_FIELDS_UI: Step-up/-down of minute/second/millisecond fields should respect min/max attributes
https://bugs.webkit.org/show_bug.cgi?id=112527

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-17
Reviewed by Kent Tamura.

Source/WebCore:

Make step-up/-down of the minute, second, and millisecond field
respect the min/max attributes of the element.
Note that it still accepts any keyboard inputs (the element
becomes 'invalid' state when out-of-range values entered).
Also, disable these fields when there is only single possible value.

Tests: fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html

fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html

  • html/shadow/DateTimeEditElement.cpp:

(DateTimeEditBuilder): Add fields for min/max of minute/second/millisecond.
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder): Set min/max for the fields.
(WebCore::DateTimeEditBuilder::visitField): Pass min/max parameters to the field constructors.
(WebCore::DateTimeEditBuilder::shouldHourFieldDisabled): Does not disable if minute, second, millisecond fields are all disabled, because we need at least one editable field.
(WebCore::DateTimeEditBuilder::shouldMillisecondFieldDisabled): Disables if min, max, and value are equal.
(WebCore::DateTimeEditBuilder::shouldMinuteFieldDisabled): Ditto.
(WebCore::DateTimeEditBuilder::shouldSecondFieldDisabled): Ditto.

  • html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeDayFieldElement::DateTimeDayFieldElement):
(WebCore::DateTimeHourFieldElementBase::DateTimeHourFieldElementBase):
(WebCore::DateTimeHour11FieldElement::DateTimeHour11FieldElement):
(WebCore::DateTimeHour12FieldElement::DateTimeHour12FieldElement):
(WebCore::DateTimeHour23FieldElement::DateTimeHour23FieldElement):
(WebCore::DateTimeHour24FieldElement::DateTimeHour24FieldElement):
(WebCore::DateTimeMillisecondFieldElement::DateTimeMillisecondFieldElement):
(WebCore::DateTimeMillisecondFieldElement::create):
(WebCore::DateTimeMinuteFieldElement::DateTimeMinuteFieldElement):
(WebCore::DateTimeMinuteFieldElement::create):
(WebCore::DateTimeMonthFieldElement::DateTimeMonthFieldElement):
(WebCore::DateTimeSecondFieldElement::DateTimeSecondFieldElement):
(WebCore::DateTimeSecondFieldElement::create):
(WebCore::DateTimeWeekFieldElement::DateTimeWeekFieldElement):
(WebCore::DateTimeYearFieldElement::DateTimeYearFieldElement):

  • html/shadow/DateTimeFieldElements.h:

(DateTimeDayFieldElement):
(DateTimeHourFieldElementBase):
(DateTimeHour11FieldElement):
(DateTimeHour12FieldElement):
(DateTimeHour23FieldElement):
(DateTimeHour24FieldElement):
(DateTimeMillisecondFieldElement): Add minimum/maximum parameters.
(DateTimeMinuteFieldElement): Add minimum/maximum parameters.
(DateTimeMonthFieldElement):
(DateTimeSecondFieldElement): Add minimum/maximum parameters.
(DateTimeWeekFieldElement):
(DateTimeYearFieldElement):

  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
(WebCore::DateTimeNumericFieldElement::formatValue): Use hard-limit value instead of m_range.maximum, because millisecond field with max<100 will be displayed in two digits otherwise.
(WebCore::DateTimeNumericFieldElement::setValueAsInteger):

  • html/shadow/DateTimeNumericFieldElement.h:

(DateTimeNumericFieldElement): Changed to have hard limits as a data member.

LayoutTests:

  • fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield-expected.txt:
  • fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html:
  • fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt:
  • fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:
8:28 PM Changeset in webkit [146031] by abarth@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove unused WebNode::hasEventListeners API
https://bugs.webkit.org/show_bug.cgi?id=112529

Reviewed by James Robinson.

This API no longer has any callers and can be removed.

  • public/WebNode.h:
  • src/WebNode.cpp:
7:21 PM Changeset in webkit [146030] by ap@apple.com
  • 3 edits in trunk/Source/WebCore

Encapsulate PlatformMessagePortChannel a little better yet
https://bugs.webkit.org/show_bug.cgi?id=112479

Reviewed by Sam Weinig.

  • dom/MessagePortChannel.h: We no longer expose PlatformMessagePortChannel in

public functions in cross-platform code.

  • dom/default/PlatformMessagePortChannel.cpp:

(WebCore::MessagePortChannel::createChannel): Tweaked the factory method to avoid
using the old create() function.
(WebCore::MessagePortChannel::~MessagePortChannel): Removed an unhelpful comment.

6:15 PM WebKitGTK/2.0.x edited by kov@webkit.org
(diff)
5:38 PM Changeset in webkit [146029] by tkent@chromium.org
  • 10 edits in trunk

INPUT_MULTIPLE_FIELDS_UI: Don't update shadow tree by updating any attribute
https://bugs.webkit.org/show_bug.cgi?id=111990

Reviewed by Hajime Morrita.

Source/WebCore:

Bug detail:
Typing '1' then '1' into an hour field doesn't set the field to
'11' if an attribute is updated during these two keyboard inputs
because we always re-construct a shadow DOM tree by updating any
attributes and a shadow node records keyboard input state.

How to fix:
We should not re-construct a shadow DOM tree by updating
unaffected attributes. For example, we should re-construct it by
updating 'min' attribute, but we should not by updating 'class'
attribute.
We have InputType::updateInnerTextValue call in parseAttribute for
text field input types. The multiple fields input types
re-construct shadow DOM tree in updateInnerTextValue. The
updateInnerTextValue call is unnecessary for the multiple fields
input types, and we should call it when it is necessary. So, we
add InputType::attributeChange and text field input types call
updateInnerTextValue in it, and other input types don't.
Also, multiple fields input types need to call
updateInnerTextValue by 'value' attribute change. We add
InputType::valueAttributeChanged.

Tests: Update
fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html. The
value attribute change behavior is covered by
time-multiple-fields-change-layout-by-value.html and
time-multiple-fields-spinbutton-change-and-input-events.html.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseAttribute):

  • Add a valueAttributeChanged call.
  • Calls InputType::attributeChanged
  • html/InputType.cpp:

(WebCore::InputType::attributeChanged): Added an empty implementation.
(WebCore::InputType::valueAttributeChanged): Ditto.

  • html/InputType.h:

(InputType): Declare attributeChanged and valueAttributeChanged.

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::attributeChanged):
Added. Always call updateInnerTextValue.

  • html/TextFieldInputType.h:

(TextFieldInputType): Declare attributeChanged.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::valueAttributeChanged):
Added. Re-construct shadow DOM tree if the input has no dirty value.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType): Declare valueAttributeChanged.

LayoutTests:

  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:
4:58 PM Changeset in webkit [146028] by rafaelw@chromium.org
  • 6 edits in trunk

[HTMLTemplateElement] prevent </template> from matching "template" in a non-HTML tags on the stack of open elements
https://bugs.webkit.org/show_bug.cgi?id=112487

Reviewed by Adam Barth.

Source/WebCore:

When processing an end template tag, the parser now pops until a "template" tag is parsed, but now ensures that
the "template" it pops is in the HTML namespace.

Tests added to the html5lib test suite.

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::popUntil):
(WebCore):
(WebCore::HTMLElementStack::popUntilPopped):

  • html/parser/HTMLElementStack.h:

(HTMLElementStack):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processTemplateEndTag):

LayoutTests:

  • html5lib/resources/template.dat:
4:06 PM Changeset in webkit [146027] by Simon Fraser
  • 2 edits in trunk/LayoutTests

fast/frames/flattening/frameset-flattening-subframesets.html is flakey

  • platform/mac/TestExpectations:
2:40 PM Changeset in webkit [146026] by keishi@webkit.org
  • 14 edits in trunk/LayoutTests

Add tests for calendar picker month popup
https://bugs.webkit.org/show_bug.cgi?id=112107

Adding tests to check if mouse and keyboard operations work on the month popup.

Reviewed by Kent Tamura.

  • platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations-expected.txt:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html:
  • platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt:
  • platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html:
  • platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations-expected.txt:
  • platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations.html:
  • platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:

(clickMonthPopupButton): Clicks the month popup button to open the month popup.
(clickYearListCell): Clicks the year list cell for the given year to reveal the month buttons.
(hoverOverMonthButton): Moves the mouse over to the month button for the given month.
(clickMonthButton): Clicks the month button for the given month.
(checkYearListViewScrollOffset): Checks the year list view scroll offset and returns the difference from the last time it was called.

  • platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt:
  • platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html:
  • platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations-expected.txt:
  • platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations.html:
2:39 PM Changeset in webkit [146025] by abarth@webkit.org
  • 16 edits
    15 deletes in trunk

Legacy CSS vendor prefixes should only work for Dashboard
https://bugs.webkit.org/show_bug.cgi?id=111890

Reviewed by Eric Seidel.

Source/WebCore:

Our experience with the Chromium port is that these legacy CSS vendor
prefixes (-apple- and -khtml-) are not needed for web compatibility.
There is reason to believe, however, that they are needed for
compatibility with Mac OS X Dashboard widgets.

This patch makes the code for these legacy CSS vendor prefixes
enabled at runtime and only enables them when running in Dashboard
compatibility mode. This is the first step towards the plan outlined in
https://lists.webkit.org/pipermail/webkit-dev/2013-March/024085.html.

This patch also removes support for ENABLE(LEGACY_CSS_VENDOR_PREFIXES)
from the V8 bindings because V8 is never used with Dashboard.

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setLegacyCSSVendorPrefixesEnabled):
(WebCore::RuntimeEnabledFeatures::legacyCSSVendorPrefixesEnabled):

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::getCSSPropertyNamePrefix):
(WebCore::cssPropertyIDForJSCSSPropertyName):

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(WebCore::cssPropertyInfo):

  • css/CSSParser.cpp:

(WebCore::CSSParser::rewriteSpecifiers):

Source/WebKit/mac:

Enable legacy CSS vendor prefixes when we've been asked to turn on
Dashboard compatibility mode.

  • WebView/WebView.mm:

(-[WebView _setDashboardBehavior:to:]):

LayoutTests:

  • inspector/styles/vendor-prefixes-expected.txt:
    • Update results to show our new behavior now that -apple- and -khtml- are not supported.
  • platform/mac/TestExpectations:
    • Skip a test that is testing that we support -apple- prefixes.
  • platform/mac/fast/css/dashboard-region-parser.html:
    • Update test to use -webkit- rather than -apple-.
1:54 PM Changeset in webkit [146024] by Simon Fraser
  • 2 edits in trunk/LayoutTests

fast/frames/sandboxed-iframe-navigation-allowed.html sometimes
asserts in debug.

  • platform/mac/TestExpectations:
1:09 PM Changeset in webkit [146023] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX (r145592): AutodrainedPool.h moved to WTF
<http://webkit.org/b/112171>

Fixes the following build failure:

Source/WebCore/platform/audio/mac/AudioBusMac.mm:32:9: fatal error: 'AutodrainedPool.h' file not found
#import "AutodrainedPool.h"


1 error generated.

  • platform/audio/mac/AudioBusMac.mm: Fix include.
11:40 AM Changeset in webkit [146022] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding failure expectations for the two reftests added in r145982, failing due to disabled subpixel layout.
Triaging/enhancing failure expectations for spellcheck tests after r145940.

  • platform/gtk/TestExpectations:
11:15 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
11:13 AM WebKitGTK/2.0.x edited by kov@webkit.org
(diff)
11:13 AM Changeset in webkit [146021] by kov@webkit.org
  • 6 edits in releases/WebKitGTK/webkit-2.0/Source

Merge 146017 - [GTK] Fix and improve dist hooks for translations
https://bugs.webkit.org/show_bug.cgi?id=112519

Reviewed by Carlos Garcia Campos.

Source/WebCore:

  • GNUmakefile.am: move translation-related rules and lists to the po directory's

GNUmakefile.am.

Source/WebCore/platform/gtk/po:

  • GNUmakefile.am: move dist-related rules here; also move translation-related files

to this file's EXTRA_DIST, making sure to only list the files we actually want
shipped, so junk such as .orig, .rej and backup files do not end up in the tarball.

Source/WebKit/gtk:

  • GNUmakefile.am: removed left-over translation files from EXTRA_DIST
11:12 AM Changeset in webkit [146020] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-2.0

Merge 144990 - Build fix. Fixes problems building code that uses deprecated functions from GTK+ 2,
such as RenderThemeGtk2.cpp, in debug mode. RenderThemeGtk2.cpp tries to allow usage
of deprecated functions by undefining GTK_DISABLE_DEPRECATED, but it ended up being
redefined because autotoolsconfig.h was included again by headers that came after
config.h.

Reviewed by Martin Robinson.

  • Source/autotools/SetupWebKitFeatures.m4: add checks to ensure the

autotoolsconfig.h header is only included once.

11:11 AM Changeset in webkit [146019] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add reload button (and F5 accelerator) to the GtkLauncher toolbar
https://bugs.webkit.org/show_bug.cgi?id=112442

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-03-17
Reviewed by Gustavo Noronha Silva.

  • GtkLauncher/main.c:

(reloadCb):
(createToolbar):
(createWindow):

11:11 AM Changeset in webkit [146018] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r146011 - [GTK] Invalid charset encoding using when substituting a misspelled word in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112517

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-17
Reviewed by Alexey Proskuryakov.

The problem is that we are creating the WebContextMenuItemData
with the GtkAction label as UTF-8.

  • UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::contextMenuItemActivatedCallback): Use String::fromUTF8()
to convert the GtkAction label to UTF-16.

11:10 AM Changeset in webkit [146017] by kov@webkit.org
  • 6 edits in trunk/Source

[GTK] Fix and improve dist hooks for translations
https://bugs.webkit.org/show_bug.cgi?id=112519

Reviewed by Carlos Garcia Campos.

Source/WebCore:

  • GNUmakefile.am: move translation-related rules and lists to the po directory's

GNUmakefile.am.

Source/WebCore/platform/gtk/po:

  • GNUmakefile.am: move dist-related rules here; also move translation-related files

to this file's EXTRA_DIST, making sure to only list the files we actually want
shipped, so junk such as .orig, .rej and backup files do not end up in the tarball.

Source/WebKit/gtk:

  • GNUmakefile.am: removed left-over translation files from EXTRA_DIST
11:06 AM Changeset in webkit [146016] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r146010 - [ENCHANT] Invalid charset encoding used for spelling guess context menu items
https://bugs.webkit.org/show_bug.cgi?id=112516

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-17
Reviewed by Gustavo Noronha Silva.

Convert spelling guesses returned by enchant to UTF-16 before
passing them to WebCore.

  • platform/text/enchant/TextCheckerEnchant.cpp:

(WebCore::TextCheckerEnchant::getGuessesForWord): Use
String::fromUTF8().

10:22 AM Changeset in webkit [146015] by Simon Fraser
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=97124
Mark a couple of WK2 tests as possibly asserting in debug.

  • platform/mac-wk2/TestExpectations:
10:14 AM Changeset in webkit [146014] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

Move font-family applying code to StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=112441

Reviewed by Allan Sandfeld Jensen.

Many of the font related properties were moved to StyleBuilder in r87362
two years ago. Move font-family as well so that all font properties are
handled the same way.

No new tests, no change in functionality.

  • css/StyleBuilder.cpp:

(ApplyPropertyFontFamily):
(WebCore::ApplyPropertyFontFamily::applyInheritValue):
(WebCore::ApplyPropertyFontFamily::applyInitialValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontFamily::createHandler):
(WebCore::StyleBuilder::StyleBuilder):
Add ApplyPropertyFontFamily for CSSPropertyFontFamily.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
Remove CSSPropertyFontFamily from the giant switch statement.

10:12 AM Changeset in webkit [146013] by danakj@chromium.org
  • 2 edits in trunk/Source/Platform

[chromium] Remove the zoom filter operation ifdef
https://bugs.webkit.org/show_bug.cgi?id=112390

Reviewed by Darin Fisher.

This ifdef is not needed once the change that introduced it is
rolled into chromium, and the chromium side guards on the ifdef
are removed. Then it just does nothing and should be deleted.

  • chromium/public/WebFilterOperation.h:
10:12 AM Changeset in webkit [146012] by abarth@webkit.org
  • 1 edit in branches/chromium/1441/Source/WebCore/rendering/RenderLayer.cpp

Revert 143825 "RenderLayer::scrollTo() should call FrameLoaderCl..."

RenderLayer::scrollTo() should call FrameLoaderClient::didChangeScrollOffset()
https://bugs.webkit.org/show_bug.cgi?id=110673
-and corresponding-
<rdar://problem/13258596>

Reviewed by Sam Weinig.

FrameLoaderClient::didChangeScrollOffset() doesn't get called for web pages that
have overflow on the body. We can easily address this by calling it at the
end of RenderLayer::scrollTo().

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):

TBR=Beth Dakin
Review URL: https://codereview.chromium.org/12851007

9:49 AM Changeset in webkit [146011] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Invalid charset encoding using when substituting a misspelled word in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112517

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-17
Reviewed by Alexey Proskuryakov.

The problem is that we are creating the WebContextMenuItemData
with the GtkAction label as UTF-8.

  • UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::contextMenuItemActivatedCallback): Use String::fromUTF8()
to convert the GtkAction label to UTF-16.

9:25 AM Changeset in webkit [146010] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[ENCHANT] Invalid charset encoding used for spelling guess context menu items
https://bugs.webkit.org/show_bug.cgi?id=112516

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-17
Reviewed by Gustavo Noronha Silva.

Convert spelling guesses returned by enchant to UTF-16 before
passing them to WebCore.

  • platform/text/enchant/TextCheckerEnchant.cpp:

(WebCore::TextCheckerEnchant::getGuessesForWord): Use
String::fromUTF8().

9:21 AM Changeset in webkit [146009] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Mark some more tests as asserting in debug, because of
https://bugs.webkit.org/show_bug.cgi?id=105986

  • platform/mac/TestExpectations:
9:11 AM Changeset in webkit [146008] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Occasional assertion in JSNPObject::invalidate() running plugins/object-embed-plugin-scripting.html
https://bugs.webkit.org/show_bug.cgi?id=112518

Mark this test as [ Crash Pass ] in debug.

  • platform/mac/TestExpectations:
9:09 AM WebKitGTK/2.0.x edited by kov@webkit.org
(diff)
9:09 AM WebKitGTK/2.0.x edited by kov@webkit.org
(diff)
7:35 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
3:44 AM Changeset in webkit [146007] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Source/WebCore

[EFL] Provide default cursor groups as cursor.edc
https://bugs.webkit.org/show_bug.cgi?id=112403

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-03-17
Reviewed by Gyuyoung Kim.

This patch provides a cursor.edc to use the CSS cursor images files in the
WebCore/Resources directory. cursor.edc is included in the default.edc
so that views can use it by default.

  • platform/efl/DefaultTheme/CMakeLists.txt:
  • platform/efl/DefaultTheme/default.edc:
  • platform/efl/DefaultTheme/widget/cursor/cursor.edc: Added.
2:17 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)

Mar 16, 2013:

11:46 PM Changeset in webkit [146006] by psolanki@apple.com
  • 8 edits in trunk/Source

Disable High DPI Canvas on iOS
https://bugs.webkit.org/show_bug.cgi?id=112511

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
10:26 PM Changeset in webkit [146005] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r145898.
http://trac.webkit.org/changeset/145898
https://bugs.webkit.org/show_bug.cgi?id=112512

Causing flakiness on webkit_unit_tests on android bots on
chromium.webkit and chromium.linux (Requested by jochen on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-16

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::applyScrollAndScale):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/WebFrameTest.cpp:
  • tests/WebViewTest.cpp:
2:26 PM Changeset in webkit [146004] by Simon Fraser
  • 2 edits in trunk/LayoutTests

http/tests/notifications/legacy/window-show-on-click.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=112499

  • platform/mac/TestExpectations:
1:47 PM Changeset in webkit [146003] by hans@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Remove redundant checks from WebInputEvent::isGestureEventType
https://bugs.webkit.org/show_bug.cgi?id=112503

Reviewed by Darin Fisher.

GesturePinchBegin, GesturePinchEnd and GesturePinchUpdate were checked
for twice.

This was found by experimenting with a potential new Clang warning.

  • public/WebInputEvent.h:

(WebKit::WebInputEvent::isGestureEventType):

12:43 PM Changeset in webkit [146002] by Simon Fraser
  • 2 edits in trunk/LayoutTests

inspector/elements/highlight-node-scaled.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=112502

Mark this test as flakey.

  • platform/mac/TestExpectations:
12:32 PM Changeset in webkit [146001] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Reflected video elements hit assertion
https://bugs.webkit.org/show_bug.cgi?id=112490

Disable reflections on video again, since there's some bad behavior
caused by an underlying system framework.

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::clone):

12:20 PM Changeset in webkit [146000] by Simon Fraser
  • 2 edits in trunk/LayoutTests

svg/batik/paints/gradientLimit.svg is flakey. Also fix
a couple of recent typos in TestExpectations.

  • platform/mac/TestExpectations:
12:10 PM Changeset in webkit [145999] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Notification test is flakey
https://bugs.webkit.org/show_bug.cgi?id=112499

  • platform/mac/TestExpectations:
12:10 PM Changeset in webkit [145998] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Another slow sputnik test.

  • platform/mac/TestExpectations:
11:19 AM Changeset in webkit [145997] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Fix typos. Also mark fast/frames/flattening/frameset-flattening-advanced.html
as flakey.

  • platform/mac/TestExpectations:
11:00 AM Changeset in webkit [145996] by Simon Fraser
  • 2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=93560

These WebGL tests are flakey on Lion too.

  • platform/mac-lion/TestExpectations:
10:56 AM Changeset in webkit [145995] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Change fast/events/controlclick-no-onclick.html to be a skip rather than a fail,
since it times out.

  • platform/mac-wk2/TestExpectations:
10:08 AM Changeset in webkit [145994] by tsepez@chromium.org
  • 3 edits
    2 adds in trunk

[v8] Disable binding integrity check for WebCore::Text
https://bugs.webkit.org/show_bug.cgi?id=112462

Reviewed by Kentaro Hara.

Source/WebCore:

Test: fast/dom/split-cdata.xml

  • dom/Text.idl:

LayoutTests:

  • fast/dom/split-cdata-expected.txt: Added.
  • fast/dom/split-cdata.xml: Added.
9:43 AM Changeset in webkit [145993] by mkwst@chromium.org
  • 2 edits
    10 adds
    2 deletes in trunk/LayoutTests

fast/frames/sandboxed-iframe-scripting is flakey
https://bugs.webkit.org/show_bug.cgi?id=112482

Reviewed by Simon Fraser.

Tests that rely on multiple 'iframe' elements loading in a specific
order are a Bad Idea™. This patch splits
'fast/frames/sandboxed-iframe-scripting.html' out into five tests, and
changes two of them (#2 and #4) to use message passing in order to
test in a way that 'js-test-{pre,post}' can cleanly report.

  • fast/frames/sandboxed-iframe-scripting-01-expected.txt: Added.
  • fast/frames/sandboxed-iframe-scripting-01.html: Added.
  • fast/frames/sandboxed-iframe-scripting-02-expected.txt: Added.
  • fast/frames/sandboxed-iframe-scripting-02.html: Added.
  • fast/frames/sandboxed-iframe-scripting-03-expected.txt: Added.
  • fast/frames/sandboxed-iframe-scripting-03.html: Added.
  • fast/frames/sandboxed-iframe-scripting-04-expected.txt: Added.
  • fast/frames/sandboxed-iframe-scripting-04.html: Added.
  • fast/frames/sandboxed-iframe-scripting-05-expected.txt: Added.
  • fast/frames/sandboxed-iframe-scripting-05.html: Added.
  • fast/frames/sandboxed-iframe-scripting-expected.txt: Removed.
  • fast/frames/sandboxed-iframe-scripting.html: Removed.
  • platform/mac/TestExpectations:

Remove the skipped test, since it no longer exists.

9:41 AM Changeset in webkit [145992] by jochen@chromium.org
  • 2 edits in trunk/LayoutTests

Update test expectations for content shell.

Unreviewed gardening.

  • platform/chromium/ContentShellTestExpectations:
8:50 AM Changeset in webkit [145991] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Mark some ref tests as failing on Lion.

  • platform/mac-lion/TestExpectations:
8:45 AM Changeset in webkit [145990] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Mark some more sputnik tests as slow in debug.

  • platform/mac/TestExpectations:
7:26 AM BadContent edited by zandobersek@gmail.com
Blacklist a spamming account. (diff)
4:21 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
4:18 AM Changeset in webkit [145989] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r145808 - [GTK] Wrong ASSERT in AudioDestinationGstreamer::stop
https://bugs.webkit.org/show_bug.cgi?id=112344

Patch by Xan Lopez <xlopez@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

Correct erroneous ASSERT, we want both member variables to exist.

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::stop):

1:51 AM Changeset in webkit [145988] by Chris Fleizach
  • 27 edits
    2 adds in trunk

AX: aria-hidden on container does not hide descendant popup buttons
https://bugs.webkit.org/show_bug.cgi?id=112373

Reviewed by Ryosuke Niwa.

Source/WebCore:

There are a number of subclass AX objects that implement accessibilityIsIgnored()
to always return false. This means that even if their parent is aria-hidden=true
they still show up in the tree.

This re-organizes this base case of aria-hidden into AccessibilityObject so that
it can be re-used by these special subclasses where appropriate.

Test: accessibility/aria-hidden-hides-all-elements.html

  • accessibility/AccessibilityImageMapLink.h:

(WebCore::AccessibilityImageMapLink::isImageMapLink):

  • accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityListBox.cpp:

(WebCore):

  • accessibility/AccessibilityListBox.h:

(AccessibilityListBox):

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::computeAccessibilityIsIgnored):
(WebCore::AccessibilityMediaControlsContainer::computeAccessibilityIsIgnored):
(WebCore::AccessibilityMediaTimeDisplay::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityMediaControls.h:

(AccessibilityMediaControlsContainer):

  • accessibility/AccessibilityMenuList.h:

(WebCore::AccessibilityMenuList::roleValue):

  • accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityMockObject.cpp:

(WebCore::AccessibilityMockObject::computeAccessibilityIsIgnored):
(WebCore):

  • accessibility/AccessibilityMockObject.h:

(AccessibilityMockObject):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::accessibilityIsIgnoredDefaultForObject):
(WebCore):
(WebCore::AccessibilityObject::ariaIsHidden):
(WebCore::AccessibilityObject::accessibilityIsIgnoredBase):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):

  • accessibility/AccessibilityProgressIndicator.cpp:

(WebCore::AccessibilityProgressIndicator::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredBase):
(WebCore::AccessibilityRenderObject::addImageMapChildren):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/AccessibilityScrollbar.h:

(AccessibilityScrollbar):

  • accessibility/AccessibilitySlider.cpp:

(WebCore):
(WebCore::AccessibilitySliderThumb::computeAccessibilityIsIgnored):

  • accessibility/AccessibilitySlider.h:

(AccessibilitySlider):

  • accessibility/AccessibilitySpinButton.h:

(WebCore::AccessibilitySpinButton::roleValue):
(AccessibilitySpinButtonPart):

LayoutTests:

  • accessibility/aria-hidden-hides-all-elements-expected.txt: Added.
  • accessibility/aria-hidden-hides-all-elements.html: Added.
12:43 AM Changeset in webkit [145987] by rniwa@webkit.org
  • 1 edit
    4 adds
    1 delete in trunk/LayoutTests

Mac rebaseline after r145977.

  • platform/chromium-mac/platform/mac/fast: Added.
  • platform/chromium-mac/platform/mac/fast/forms: Added.
  • platform/chromium-mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Added.
  • platform/chromium/platform/mac/fast/forms: Removed.
  • platform/chromium/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Removed.
  • platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Added.

Mar 15, 2013:

11:16 PM Changeset in webkit [145986] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Mark two media/track tests as flakey. Tracked by webkit.org/b/112492

  • platform/mac/TestExpectations:
10:58 PM Changeset in webkit [145985] by Simon Fraser
  • 1 edit
    1 delete in trunk/LayoutTests

Remove result in platform/mac/platform/mac

  • platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Removed.
10:06 PM Changeset in webkit [145984] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Fix typo in TestExpectations file.

  • platform/mac/TestExpectations:
9:56 PM Changeset in webkit [145983] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Reflected video elements hit assertion on Lion
https://bugs.webkit.org/show_bug.cgi?id=112490

Disable the new reflected video functionality added in r145915
on Lion because of a nasty re-entrancy problem. Tracked by bug 112490.

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::clone):

9:40 PM Changeset in webkit [145982] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

[CSS Exclusions] shape-outside on floats for circle and ellipse shapes
https://bugs.webkit.org/show_bug.cgi?id=98673

Source/WebCore:

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-03-15
Reviewed by Dirk Schulze.

Enable circles and ellipses for shape-outside on floats. Most of the
code already supports them, just needed to turn them on and add tests.

Tests: fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle.html

fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse.html

  • rendering/ExclusionShapeOutsideInfo.cpp:

(WebCore::ExclusionShapeOutsideInfo::isEnabledFor): Enable circles and

ellipses. Also add a check for if the RenderBox is floating, since
that test should have been there all along, as shape outside is
only supported on floats for now.

LayoutTests:

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-03-15
Reviewed by Dirk Schulze.

Tests for circles and ellipses on floats.

  • fast/exclusions/resources/rounded-rectangle.js:

(defined): Helper function to test and see if a js value is defined.
(convertToRoundedRect): Convert a circle or ellipse dimensions to a rounded rect.
(generateShapeOutsideOnFloat): Add ability to generate circles and

ellipses, since they are just special cases of rounded rectangles.

(generateSimulatedShapeOutsideOnFloat): Add ability to simulate

circles and ellipses, by treating them as rounded rectangles. Also
fix minor style issue with an if statement.

(xOutset): Remove unneeded condition in if statement.

  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle-expected.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse-expected.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse.html: Added.
9:37 PM Changeset in webkit [145981] by Simon Fraser
  • 2 edits in trunk/Tools

REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
https://bugs.webkit.org/show_bug.cgi?id=112205

Disable this API test until Geoff can fix it.

  • TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:

(TestWebKitAPI::TEST):

8:49 PM Changeset in webkit [145980] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Rebaseline after r145977.

  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
8:47 PM Changeset in webkit [145979] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Rebaseline after r145977.

  • platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
8:25 PM Changeset in webkit [145978] by kbr@google.com
  • 13 edits in trunk/LayoutTests

Unreviewed new baselines after r145977.
https://bugs.webkit.org/show_bug.cgi?id=110837

  • platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
7:27 PM Changeset in webkit [145977] by commit-queue@webkit.org
  • 159 edits in trunk

Convert old flexbox uses in html.css to new flexbox (non-<select>)
https://bugs.webkit.org/show_bug.cgi?id=110837

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-15
Reviewed by Ojan Vafai.

Source/WebCore:

Covered by existing tests.

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):
After we set our descendants' heights, we need to mark them for
layout.
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
Use new-flexbox style setters.

  • css/html.css:

(input::-webkit-textfield-decoration-container):
(input[type="search"]::-webkit-search-cancel-button):
(input[type="search"]::-webkit-search-decoration):
(input[type="search"]::-webkit-search-results-decoration):
(input[type="search"]::-webkit-search-results-button):
(input::-webkit-inner-spin-button):
(input::-webkit-input-speech-button):
(textarea):
(input[type="file"]):
(input[type="color"]::-webkit-color-swatch-wrapper):
(input[type="color"]::-webkit-color-swatch):
(::-webkit-validation-bubble-message):
(::-webkit-validation-bubble-text-block):

  • css/themeWin.css:

(input[type="search"]::-webkit-search-results-decoration):
(input[type="search"]::-webkit-search-results-button):
Convert -webkit-box to -webkit-flex and adjust related properties.
Notably switch to auto margins for centering the speech button as well
as the search result and cancel buttons to stay compatible with the
previous centering behaviour. This does not produce visible
differences but eliminates the render tree dump changes.

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerContainer::TextControlInnerContainer):
(WebCore):
(WebCore::TextControlInnerContainer::create):
(WebCore::TextControlInnerContainer::createRenderer):

  • html/shadow/TextControlInnerElements.h:

(TextControlInnerContainer):
(WebCore):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControlInnerContainer::RenderTextControlInnerContainer):
(WebCore):
(WebCore::RenderTextControlInnerContainer::~RenderTextControlInnerContainer):

  • rendering/RenderTextControl.h:

(WebCore):
(RenderTextControlInnerContainer):
Create a new DOM element & renderer type for the textfield-decoration
div (the direct child of the <input> in the shadow dom if we have a
special input field). This is necessary because new-flexbox uses a
different algorithm for calculating the baseline, which would
otherwise cause an <input> and an <input type=search> to not be
aligned with each other.
The new renderer just calls back to RenderBlock for calculating the
baseline.

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):
Make sure to mark renderers as needing layout when we change their
style. This didn't use to be necessary because old-flexbox relayouts
children even when they are not marked for needing layout.
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
Use new-flexbox CSS properties.

  • html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::decorate):
Use new-flexbox CSS properties.

LayoutTests:

  • fast/forms/placeholder-position-expected.txt:
  • platform/chromium-linux/fast/css/input-search-padding-expected.txt:
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-linux/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-linux/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-linux/fast/forms/search-styled-expected.txt:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-mac-lion/fast/forms/search-rtl-expected.txt:
  • platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.txt:
  • platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.txt:
  • platform/chromium-mac/fast/css/text-overflow-input-expected.txt:
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-mac/fast/forms/search-rtl-expected.txt:
  • platform/chromium-mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/chromium-mac/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/css/input-search-padding-expected.txt:
  • platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/chromium-win/fast/css/text-overflow-input-expected.txt:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-win/fast/forms/control-restrict-line-height-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-win/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/chromium-win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/chromium-win/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-position-expected.txt:
  • platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/chromium-win/fast/forms/search-rtl-expected.txt:
  • platform/chromium-win/fast/forms/search-styled-expected.txt:
  • platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
  • platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
  • platform/chromium-win/fast/repaint/search-field-cancel-expected.txt:
  • platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-win/fast/speech/speech-bidi-rendering-expected.txt:
  • platform/chromium/fast/css/input-search-padding-expected.txt:
  • platform/chromium/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/chromium/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/chromium/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
  • platform/chromium/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/chromium/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/chromium/fast/forms/search-rtl-expected.txt:
  • platform/chromium/fast/forms/search-styled-expected.txt:
  • platform/chromium/fast/repaint/search-field-cancel-expected.txt:
  • platform/chromium/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/chromium/fast/speech/speech-bidi-rendering-expected.txt:
  • platform/efl/fast/css/input-search-padding-expected.txt:
  • platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/efl/fast/css/text-overflow-input-expected.txt:
  • platform/efl/fast/forms/box-shadow-override-expected.txt:
  • platform/efl/fast/forms/control-restrict-line-height-expected.txt:
  • platform/efl/fast/forms/input-appearance-height-expected.txt:
  • platform/efl/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
  • platform/efl/fast/forms/placeholder-position-expected.txt:
  • platform/efl/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/efl/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/efl/fast/forms/search-rtl-expected.txt:
  • platform/efl/fast/forms/search-styled-expected.txt:
  • platform/efl/fast/forms/search-vertical-alignment-expected.txt:
  • platform/efl/fast/forms/searchfield-heights-expected.txt:
  • platform/efl/fast/forms/validation-message-appearance-expected.txt:
  • platform/efl/fast/repaint/search-field-cancel-expected.txt:
  • platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/gtk/fast/css/text-overflow-input-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/gtk/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/gtk/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
  • platform/gtk/fast/forms/placeholder-position-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:
  • platform/gtk/fast/forms/validation-message-appearance-expected.txt:
  • platform/gtk/fast/repaint/search-field-cancel-expected.txt:
  • platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/gtk/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/mac/fast/css/input-search-padding-expected.txt:
  • platform/mac/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/mac/fast/css/text-overflow-input-expected.txt:
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-styled-expected.txt:
  • platform/mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/mac/fast/forms/searchfield-heights-expected.txt:
  • platform/mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/mac/fast/repaint/search-field-cancel-expected.txt:
  • platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/mac/fast/speech/speech-bidi-rendering-expected.txt:
  • platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/css/input-search-padding-expected.txt:
  • platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/qt/fast/css/text-overflow-input-expected.txt:
  • platform/qt/fast/forms/box-shadow-override-expected.txt:
  • platform/qt/fast/forms/control-restrict-line-height-expected.txt:
  • platform/qt/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/qt/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/qt/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
  • platform/qt/fast/forms/placeholder-position-expected.txt:
  • platform/qt/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/qt/fast/forms/search-rtl-expected.txt:
  • platform/qt/fast/forms/search-styled-expected.txt:
  • platform/qt/fast/forms/search-vertical-alignment-expected.txt:
  • platform/qt/fast/repaint/search-field-cancel-expected.txt:
  • platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/qt/fast/speech/input-appearance-searchandspeech-expected.txt:

Automated search & replace of RenderDeprecatedFlexibleBox ->
RenderFlexibleBox

  • platform/mac/fast/forms/color/input-appearance-color-expected.txt:
  • platform/chromium-mac/fast/forms/color/input-appearance-color-expected.txt:
  • platform/chromium-win/fast/forms/color/input-appearance-color-expected.txt:
  • platform/chromium-linux/fast/forms/color/input-appearance-color-expected.png:

This test shows a minor layout difference (less spacing between
paragraphs with an <input type=color>). The underlying reason is
alignment/baseline-differences with the new flexbox code, and the new
behaviour makes more sense in general (this becomes obvious when
putting text or a <input type=text> next to an <input type=color>).

  • platform/chromium/TestExpectations:

Mark input-appearance-color as needing rebaseline on Mac/Win. All
non-Chromium ports ignore fast/forms/color because the feature isn't
enabled, so their TestExpectations need no update.

7:22 PM Changeset in webkit [145976] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r188504. Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-15

  • DEPS:
7:13 PM Changeset in webkit [145975] by kbr@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed attempted build fix for Chromium Windows after r145929.
Verified this fix builds and works on Linux.
https://bugs.webkit.org/show_bug.cgi?id=96798

  • bindings/v8/V8Binding.cpp:

(WebCore):

6:22 PM Changeset in webkit [145974] by Simon Fraser
  • 3 edits
    2 adds in trunk/LayoutTests

Added some expected results that should be the same across platforms.
Removed some tests needing rebaseline from Mac TestExpectations.

  • compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.txt: Added.
  • compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.txt: Added.
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
6:20 PM Changeset in webkit [145973] by Nate Chapin
  • 5 edits in trunk/Source/WebCore

Merge MainResourceLoader::willSendRequest into DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=109757

This is one of the steps to merging MainResourceLoader entirely into
DocumentLoader, given the lack of clear division of responsibility
between the two.

Reviewed by Antti Koivisto.

No new tests, refactor only.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::mainResourceData):
(WebCore::DocumentLoader::isPostOrRedirectAfterPost):
(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::callContinueAfterNavigationPolicy):
(WebCore::DocumentLoader::continueAfterNavigationPolicy):
(WebCore::DocumentLoader::startLoadingMainResource):

  • loader/DocumentLoader.h:
  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::resourceData):
(WebCore::MainResourceLoader::redirectReceived):
(WebCore::MainResourceLoader::continueAfterContentPolicy):
(WebCore::MainResourceLoader::reportMemoryUsage):
(WebCore::MainResourceLoader::handleSubstituteDataLoadNow):
(WebCore::MainResourceLoader::load):

  • loader/MainResourceLoader.h:

(WebCore::MainResourceLoader::takeIdentifierFromResourceLoader): Temporarily

exposed for moving from a normal load to SubstituteData load on redirect.

6:11 PM Changeset in webkit [145972] by zmo@google.com
  • 2 edits in trunk/Source/WebCore

Disable EXT_draw_buffers WebGL extension on Mac
https://bugs.webkit.org/show_bug.cgi?id=112486

Reviewed by Kenneth Russell.

  • html/canvas/EXTDrawBuffers.cpp:

(WebCore::EXTDrawBuffers::supported):

5:54 PM Changeset in webkit [145971] by kbr@google.com
  • 1 edit
    6 adds in trunk/LayoutTests

Unreviewed addition of expectations for test added in r145915.

  • platform/chromium-mac-lion/compositing/video/video-reflection-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/video/video-reflection-expected.png: Added.
  • platform/chromium-mac/compositing/video/video-reflection-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/video/video-reflection-expected.png: Added.
  • platform/chromium-win/compositing/video/video-reflection-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/video/video-reflection-expected.png: Added.
5:43 PM Changeset in webkit [145970] by danakj@chromium.org
  • 5 edits
    9 deletes in trunk

[chromium] Remove the background filter blur layout tests
https://bugs.webkit.org/show_bug.cgi?id=112372

Reviewed by James Robinson.

Source/WebCore:

Remove the now-unused hacks to regression test the background
filter blur compositor feature.

  • testing/Internals.cpp:
  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

LayoutTests:

Given that we now have the ability to write pixel tests directly against
the compositor, these tests are no longer needed to guard against
regressions, and have been duplicated for the compositor as pixel tests
in https://codereview.chromium.org/12518026/ and
https://codereview.chromium.org/12518026/.

  • platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
  • platform/chromium/compositing/filters/background-filter-blur-expected.txt: Removed.
  • platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
  • platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.txt: Removed.
  • platform/chromium/compositing/filters/background-filter-blur-off-axis.html: Removed.
  • platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
  • platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt: Removed.
  • platform/chromium/compositing/filters/background-filter-blur-outsets.html: Removed.
  • platform/chromium/compositing/filters/background-filter-blur.html: Removed.
5:37 PM Changeset in webkit [145969] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Mark fast/frames/sandboxed-iframe-scripting as flakey.

webkit.org/b/104848 supposedly fixed fast/frames/sandboxed-iframe-parsing-space-characters.html,
so remove it.

  • platform/mac/TestExpectations:
5:36 PM Changeset in webkit [145968] by anilsson@rim.com
  • 16 edits in trunk/Source/WebKit/blackberry

[BlackBerry] BlackBerry::Platform::Graphics::GraphicsContext integration related changes in Source/WebKit/blackberry
https://bugs.webkit.org/show_bug.cgi?id=112467

Reviewed by Rob Buis.

PR 293208

This patch contains contributions from many members of the BlackBerry
WebKit team:

Mike Lattanzio
Arvid Nilsson
Jakob Petsovits
Konrad Piascik
Jeff Rogers
Filip Spacek

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::compositeContents):
(BlackBerry::WebKit::BackingStorePrivate::tileSize):

  • Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayPrivate::drawContents):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::paintContents):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToImage):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::clearUploadedContents):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToColor):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::removeFromParent):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):

  • Api/WebOverlay.h:
  • Api/WebOverlayClient.h:
  • Api/WebOverlay_p.h:

(WebOverlayPrivate):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showDebugBorders):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showRepaintCounter):
(WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::image):
(WebOverlayPrivateCompositingThread):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):

  • WebKitSupport/BackingStoreTile.cpp:

(BlackBerry::WebKit::TileBuffer::~TileBuffer):
(BlackBerry::WebKit::TileBuffer::nativeBuffer):
(BlackBerry::WebKit::TileBuffer::paintBackground):

  • WebKitSupport/DefaultTapHighlight.cpp:

(BlackBerry::WebKit::DefaultTapHighlight::paintContents):
(BlackBerry::WebKit::DefaultTapHighlight::showDebugBorders):
(WebKit):
(BlackBerry::WebKit::DefaultTapHighlight::showRepaintCounter):

  • WebKitSupport/DefaultTapHighlight.h:

(DefaultTapHighlight):

  • WebKitSupport/InspectorOverlayBlackBerry.cpp:

(BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
(WebKit):
(BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):

  • WebKitSupport/InspectorOverlayBlackBerry.h:

(InspectorOverlay):

  • WebKitSupport/SelectionOverlay.cpp:

(BlackBerry::WebKit::SelectionOverlay::draw):
(BlackBerry::WebKit::SelectionOverlay::hide):
(BlackBerry::WebKit::SelectionOverlay::paintContents):
(BlackBerry::WebKit::SelectionOverlay::showDebugBorders):
(WebKit):
(BlackBerry::WebKit::SelectionOverlay::showRepaintCounter):

  • WebKitSupport/SelectionOverlay.h:

(SelectionOverlay):

  • WebKitSupport/SurfacePool.cpp:

(BlackBerry::WebKit::SurfacePool::createPlatformGraphicsContext):
(BlackBerry::WebKit::SurfacePool::destroyPlatformGraphicsContext):
(BlackBerry::WebKit::SurfacePool::waitForBuffer):
(BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
(BlackBerry::WebKit::SurfacePool::destroyPlatformSync):

  • WebKitSupport/SurfacePool.h:
5:20 PM Changeset in webkit [145967] by jochen@chromium.org
  • 7 edits
    1 delete in trunk

plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
https://bugs.webkit.org/show_bug.cgi?id=112478

Reviewed by Tony Chang.

There is nothing that ensures that the log messages from the plugin
come in before the layout test finished loading.

Tools:

  • DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:

(PassDifferentNPPStruct::NPP_SetWindow):

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_SetWindow):

LayoutTests:

  • platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt: Removed.
  • plugins/netscape-plugin-setwindow-size-2.html:
  • plugins/netscape-plugin-setwindow-size.html:
  • plugins/pass-different-npp-struct.html:
4:52 PM Changeset in webkit [145966] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Mark some more sputnik tests as slow in debug.

  • platform/mac/TestExpectations:
4:40 PM Changeset in webkit [145965] by ap@apple.com
  • 4 edits in trunk/Source/WebCore

Reduce amount of platform specific code in MessagePortChannel
https://bugs.webkit.org/show_bug.cgi?id=112469

Reviewed by Sam Weinig.

  • dom/MessagePortChannel.h: Ifdefed out an unused channel() function, except for Chromium, where it is used. We certainly don't want to expose this implementation detail as a public function.
  • dom/default/PlatformMessagePortChannel.h: Removed functions that are no longer delegated. Made class contents all public, as it's now basically a data storage for MessagePortChannel.
  • dom/default/PlatformMessagePortChannel.cpp: (WebCore::MessagePortChannel::createChannel): (WebCore::MessagePortChannel::~MessagePortChannel): (WebCore::MessagePortChannel::entangleIfOpen): (WebCore::MessagePortChannel::disentangle): (WebCore::MessagePortChannel::postMessageToRemote): (WebCore::MessagePortChannel::tryGetMessageFromRemote): (WebCore::MessagePortChannel::close): (WebCore::MessagePortChannel::isConnectedTo): (WebCore::MessagePortChannel::hasPendingActivity): (WebCore::MessagePortChannel::locallyEntangledPort): (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::entangledChannel): Moved code from PlatformMessagePortChannel to MessagePortChannel. Added some FIXMEs.
4:36 PM Changeset in webkit [145964] by Simon Fraser
  • 2 edits in trunk/LayoutTests

New baseline for this test on Lion.

  • platform/mac-lion/platform/mac/fast/text/vertical-no-sideways-expected.txt:
4:30 PM Changeset in webkit [145963] by timothy@apple.com
  • 4 edits in trunk/Source

Disable suppressesIncrementalRendering for the Web Inspector.

This ends up causing the Inspector to show blank for a couple seconds before
it does its first paint. During that time the bare window chrome is showing
when the Inspector's background and other simple elements count be painting.
This causes the Inspector to look like it is loading slower than reality.

Source/WebKit/mac:

https://bugs.webkit.org/show_bug.cgi?id=112300
rdar://problem/13412219

Reviewed by Geoff Garen.

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController init]): Disable suppressesIncrementalRendering.

Source/WebKit2:

https://bugs.webkit.org/show_bug.cgi?id=112300
rdar://problem/13412219

Reviewed by Geoff Garen.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::createInspectorPageGroup): Disable suppressesIncrementalRendering.

4:30 PM Changeset in webkit [145962] by anilsson@rim.com
  • 6 edits in trunk/Source

[BlackBerry] Expose the compositing thread layer's draw rectangle to aid hit testing
https://bugs.webkit.org/show_bug.cgi?id=112255

Reviewed by Rob Buis.

PR 308284.
Reviewed internally by Yongxin Dai.

Source/WebCore:

Add a getter for the layer renderer of a compositing thread layer.

No change in behavior, no new tests.

  • platform/graphics/blackberry/LayerCompositingThread.h:

(WebCore::LayerCompositingThread::layerRenderer):

Source/WebKit/blackberry:

The cached draw rectangle is useful for hit testing. Add a getter for
this compositing thread layer property to the public WebOverlay API.
We name this getter using terminology familiar from the
ViewportAccessor interface, to clarify which coordinate system the
getter uses (pixel coordinates relative to the viewport).

Note that WebKit-thread flavor of WebOverlay is not currently used by
any API client and is marked obsolete. It is used internally in WebKit,
but for that case using GraphicsLayer directly works well. This will
allow the complexity of WebOverlay to be significantly reduced in the
future, by removing the WebKit-thread flavor entirely.

  • Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlay::pixelViewportRect):
(WebKit):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::pixelViewportRect):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):

  • Api/WebOverlay.h:

(WebKit):

  • Api/WebOverlay_p.h:

(WebOverlayPrivate):
(WebOverlayPrivateWebKitThread):
(WebOverlayPrivateCompositingThread):

4:29 PM Changeset in webkit [145961] by timothy@apple.com
  • 6 edits in trunk/Source/WebKit2

Delay creating the Inspector window so we don't cause a CoreIPC deadlock.

Other changes include:

  • Create the Inspector WKView at the correct size so it does not need to resize later when added to the window.
  • Update the minimum and initial window sizes to better match the new UI.
  • Store the Inspector window frame in WebKit preferences so each page group can have different saved window frames. Handy for inspecting the Inspector.

https://bugs.webkit.org/show_bug.cgi?id=112300
rdar://problem/13412219

Reviewed by Geoff Garen.

  • Shared/WebPreferencesStore.cpp:

(WebKit::defaultValueForKey):
Added FOR_EACH_WEBKIT_STRING_PREFERENCE_NOT_IN_WEBCORE.

  • Shared/WebPreferencesStore.h:

(FOR_EACH_WEBKIT_STRING_PREFERENCE_NOT_IN_WEBCORE):
Added. Needed to keep WebPage::updatePreferences for trying to set WebCore::Settings.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::minimumWindowWidth):
(WebKit::WebInspectorProxy::initialWindowWidth):
Bumped the values to work better with the new UI.

  • UIProcess/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::windowFrameDidChange):
Added.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(-[WKWebInspectorProxyObjCAdapter windowDidMove:]):
(-[WKWebInspectorProxyObjCAdapter windowDidResize:]):
Call WebInspectorProxy::windowFrameDidChange.

(WebKit::WebInspectorProxy::createInspectorWindow):
Use the preferences for the page group to get the window frame.

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Stop calling platformAttach or createInspectorWindow, do it in platformOpen.

(WebKit::WebInspectorProxy::platformOpen):
Call platformAttach or createInspectorWindow here instead.

(WebKit::WebInspectorProxy::windowFrameDidChange):
Added. Store the frame in the page group's preferences.

(WebKit::WebInspectorProxy::platformAttach):
(WebKit::WebInspectorProxy::platformDetach):
Remove code that called setHidden:. We don't need to do that anymore.

4:18 PM Changeset in webkit [145960] by Lucas Forschler
  • 2 edits in tags/Safari-537.34/Source/WebCore

Merged r145958. <rdar://problem/13434350>

4:14 PM Changeset in webkit [145959] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Convert <select> to new-flexbox
https://bugs.webkit.org/show_bug.cgi?id=112395

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-15
Reviewed by Ojan Vafai.

Covered by existing tests.

  • css/html.css:

(select):
(select[size][multiple]):
(select[size="1"]):
Use new-style flexbox properties.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::RenderMenuList):
(WebCore::RenderMenuList::createInnerBlock):
(WebCore::RenderMenuList::adjustInnerStyle):
(WebCore::RenderMenuList::removeChild):
RenderDeprecatedFlexibleBox -> RenderFlexibleBox, and use the
new-style flexbox properties. Use margin:auto for centering to get
the old safe-centering behavior.

  • rendering/RenderMenuList.h:

(RenderMenuList):
Inherit from RenderFlexibleBox. Override baseline methods to call the
RenderBlock methods

4:11 PM Changeset in webkit [145958] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r145820): Stop over-retaining CFDataRefs in SharedBuffer::maybeTransferPlatformData()
https://bugs.webkit.org/show_bug.cgi?id=112474

Reviewed by Simon Fraser.

Transfer ownership of m_cfData to the local variable rather than leaking a reference.

  • platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::maybeTransferPlatformData):

4:01 PM Changeset in webkit [145957] by fsamuel@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Focus Plugin on TouchStart
https://bugs.webkit.org/show_bug.cgi?id=112385

Reviewed by Adam Barth.

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::handleMouseEvent):

  • src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

4:00 PM Changeset in webkit [145956] by Lucas Forschler
  • 2 edits in branches/safari-536.30-branch/Source/WebCore

Merged r136062. <rdar://problem/13334906>

3:54 PM Changeset in webkit [145955] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

New context extensions restored improperly
https://bugs.webkit.org/show_bug.cgi?id=112156

Patch by Rajeev Sarvaria <rsarvaria@blackberry.com> on 2013-03-15
Reviewed by Rob Buis.

Sets up extensions after new context is created for restoration.
Previous extensions set up is lost when context is initially lost.

Cannot create a test as change is not visible from the web. When a context
is lost, WebGLRenderingContext drops m_context. Upon restoration a new context
object is created without available extensions initialized. Calling isEnabled
within setupFlags leads to the eventual initialization of extensions for the
new context.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

3:22 PM Changeset in webkit [145954] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

TextIterator emits LF for a br element inside an empty input element
https://bugs.webkit.org/show_bug.cgi?id=112275

Patch by Aurimas Liutikas <aurimas@chromium.org> on 2013-03-15
Reviewed by Ryosuke Niwa.

Source/WebCore:

Adding a check to avoid emiting LF for br elements inside a shadow tree
of an input element.

Test: editing/text-iterator/basic-iteration.html

editing/text-iterator/basic-iteration-shadowdom.html

  • editing/TextIterator.cpp:

(WebCore::shouldEmitNewlineForNode):
(WebCore::TextIterator::handleNonTextNode):
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
(WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode):
(WebCore::SimplifiedBackwardsTextIterator::exitNode):

  • editing/TextIterator.h:

(SimplifiedBackwardsTextIterator):

LayoutTests:

  • editing/text-iterator/basic-iteration-expected.txt: Extended to add two more cases.
  • editing/text-iterator/basic-iteration-shadowdom-expected.txt: Added.
  • editing/text-iterator/basic-iteration-shadowdom.html: Added.
  • editing/text-iterator/script-tests/basic-iteration.js: Extended to add two mroe cases.
  • platform/mac/TestExpectations:
3:19 PM Changeset in webkit [145953] by anilsson@rim.com
  • 8 edits
    1 add in trunk/Source

[BlackBerry] Allow an embedder to position child windows using window coordinates
https://bugs.webkit.org/show_bug.cgi?id=112236

Reviewed by Rob Buis.

PR 232752

Source/WebCore:

The LayerCompositingThread can now position the video window using
either document or window coordinates.

The LayerRenderer class gets a new client interface. This allows us to
avoid state duplication by delegating decisions directly to the client,
which can then be in charge of the (one and only) state.

The context is moved over to the client, as well as delegation of the
decision on whether to clear the surface every frame.

Also, the decision on which coordinate system to use for positioning
child windows is delegated to the client interface.

No new tests, not testable using DRT.

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::drawTextures):

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::create):
(WebCore::LayerRenderer::LayerRenderer):
(WebCore::LayerRenderer::setViewport):
(WebCore::LayerRenderer::compositeLayers):
(WebCore::LayerRenderer::toWebKitWindowCoordinates):
(WebCore::LayerRenderer::makeContextCurrent):

  • platform/graphics/blackberry/LayerRenderer.h:

(WebCore):
(LayerRenderer):
(WebCore::LayerRenderer::client):

  • platform/graphics/blackberry/LayerRendererClient.h: Added.

(Graphics):
(WebCore):
(LayerRendererClient):
(WebCore::LayerRendererClient::~LayerRendererClient):

Source/WebKit/blackberry:

Child windows used to always be positioned in document coordinates,
which requires the
BlackBerry::Platform::Graphics::Window::virtualRect() of the parent
window to be kept in sync with the document visible content rect.
This is easy if there's a one-to-one correspondence between windows
and scrollable frames.

However, for an embedder that can display an entire scene graph (where
the web page is just one of the nodes) in one window, several
scrollable nodes may be present in that window, and it's difficult to
know which scrollable node to sync the virtualRect with. It could also
lead to conflicts, if two scrollable nodes have child windows.

For the latter scenario, it makes more sense to use window coordinates
to place child windows.

The internal default is to use document coordinates, for legacy
reasons.

When an external WebPageCompositor is attached, we switch to using
window coordinates instead of document coordinates by default. The
behavior is still configurable using the new public
setChildWindowPlacement method.

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
(BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
(BlackBerry::WebKit::WebPageCompositorPrivate::shouldClearSurfaceBeforeCompositing):
(WebKit):
(BlackBerry::WebKit::WebPageCompositorPrivate::shouldChildWindowsUseDocumentCoordinates):
(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::setChildWindowPlacement):

  • Api/WebPageCompositor.h:
  • Api/WebPageCompositor_p.h:

(BlackBerry::WebKit::WebPageCompositorPrivate::setChildWindowPlacement):
(WebPageCompositorPrivate):

3:13 PM Changeset in webkit [145952] by pdr@google.com
  • 2 edits
    2 copies in branches/chromium/1410

Merge 145726 "Fix body background image geometry calculation"

Fix body background image geometry calculation
https://bugs.webkit.org/show_bug.cgi?id=112226

Reviewed by Stephen Chenney.

Source/WebCore:

Images that depend on a container size require a call to set the container size before
rendering, and a call to look up the correct image during painting.

The body's renderer is special in that it may not be the renderer that actually paints its
background. This patch fixes a bug where the correct RenderObject was used for looking up
the image, but not for setting the container size. This fixes SVG background images on body.

Test: svg/as-background-image/svg-as-background-body.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

This change introduces clientForBackgroundImage in the background geometry calculation.
This is very similar to how the client is looked up in paintFillLayerExtended.

  • rendering/RenderBoxModelObject.h:

The new signature for calculateBackgroundImageGeometry now mirrors
paintFillLayerExtended, containing a parameter for the correct background renderer.

(RenderBoxModelObject):

LayoutTests:

This test is required to have a repeating background, as we optimize non-repeating
backgrounds so the bug is not hit. A light green color is used so the text is still
readable, and gridlines are present to prove the correct container size is being used.

  • svg/as-background-image/svg-as-background-body-expected.html: Added.
  • svg/as-background-image/svg-as-background-body.html: Added.

TBR=pdr@google.com
Review URL: https://codereview.chromium.org/12712011

3:12 PM Changeset in webkit [145951] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebKit2

[GTK] Enforce the C++11 standard when compiling WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112169

Reviewed by Gustavo Noronha Silva.

With a limited set of supported compilers the WebKit2 source code can now
be built with the C++11 language standard enforced.

  • GNUmakefile.am:
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(injectedBundleDirectory): Adjust the string literals concatenation, moving away from empty strings
(which C++11 refuses to handle as concatenation operators) and using whitespace instead.

  • UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:

(WebKit::WebInspectorServer::platformResourceForPath): Ditto.

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::inspectorFilesBasePath): Ditto.

3:11 PM Changeset in webkit [145950] by Lucas Forschler
  • 3 edits in branches/safari-536.30-branch/Source/WebCore

Merged r132970. <rdar://problem/13335073>

3:09 PM Changeset in webkit [145949] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

[iOS] Update StringImpl's equal to have a single version on all supported Apple CPUs
https://bugs.webkit.org/show_bug.cgi?id=112400

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-15
Reviewed by Michael Saboff.

  • wtf/text/StringImpl.h:

(WTF::equal):
Tweak the code to make it work on older Apple CPUs:
-Use external "ouput" variable instead of the registers R9 and R12. This gets rid

of some register pressure previously imposed on the compiler. (Clang nicely
choose R9 and R12 when needed, following iOS ABI).

-Instead of using "R3" for storing the length / 4, update the length by -4 on

each iteration and work in the negative space for the tail. This frees one register
which is then used for isEqual.

-Get rid of the unconditional branch from the loop. By using subs and working in the

negative space, we can test for the Carry flag to jump back to the next LDR.

3:05 PM Changeset in webkit [145948] by Simon Fraser
  • 2 edits in trunk/Tools

Have the mac port support per_test_timeout in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=112466

Reviewed by Dirk Pranke.

Both WTR and DRT handle --timeout arguments, so we can
have the scripts pass the timeout values down to the tools.

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.supports_per_test_timeout):

2:57 PM Changeset in webkit [145947] by akling@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Don't also clone StructureRareData when cloning Structure.
<http://webkit.org/b/111672>

Reviewed by Mark Hahnenberg.

We were cloning a lot of StructureRareData with only the previousID pointer set since
the enumerationCache is not shared between clones.

Let the Structure copy constructor decide whether it wants to clone the rare data.
The decision is made by StructureRareData::needsCloning() and will currently always
return false, since StructureRareData only holds on to caches at present.
This may change in the future as more members are added to StructureRareData.

  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::cloneRareDataFrom):

  • runtime/StructureInlines.h:

(JSC::Structure::create):

2:55 PM Changeset in webkit [145946] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding failure expectations for IDB tests that regressed with r145929.
2:52 PM Changeset in webkit [145945] by mhahnenberg@apple.com
  • 24 edits
    9 deletes in trunk

Roll out r145838
https://bugs.webkit.org/show_bug.cgi?id=112458

Unreviewed. Requested by Filip Pizlo.

Source/JavaScriptCore:

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • dfg/DFGOperations.cpp:
  • interpreter/CallFrame.h:

(JSC::ExecState::objectPrototypeTable):

  • jit/JITStubs.cpp:

(JSC::getByVal):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::getByVal):

  • runtime/CommonIdentifiers.h:
  • runtime/JSCell.cpp:

(JSC):

  • runtime/JSCell.h:

(JSCell):

  • runtime/JSCellInlines.h:

(JSC):
(JSC::JSCell::fastGetOwnProperty):

  • runtime/JSGlobalData.cpp:

(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/JSObject.cpp:

(JSC):

  • runtime/JSObject.h:

(JSObject):
(JSC):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/ObjectPrototype.cpp:

(JSC):
(JSC::ObjectPrototype::finishCreation):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):

  • runtime/ObjectPrototype.h:

(JSC::ObjectPrototype::create):
(ObjectPrototype):

  • runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::findWithString):

  • runtime/Structure.h:

(Structure):

  • runtime/StructureInlines.h:

(JSC::Structure::get):

LayoutTests:

  • fast/js/regress/script-tests/string-lookup-hit-identifier.js: Removed.
  • fast/js/regress/script-tests/string-lookup-hit.js: Removed.
  • fast/js/regress/script-tests/string-lookup-miss.js: Removed.
  • fast/js/regress/string-lookup-hit-expected.txt: Removed.
  • fast/js/regress/string-lookup-hit-identifier-expected.txt: Removed.
  • fast/js/regress/string-lookup-hit-identifier.html: Removed.
  • fast/js/regress/string-lookup-hit.html: Removed.
  • fast/js/regress/string-lookup-miss-expected.txt: Removed.
  • fast/js/regress/string-lookup-miss.html: Removed.
2:52 PM Changeset in webkit [145944] by jochen@chromium.org
  • 7 edits in trunk/Source

Expose whether a UserGestureToken still has gestures via WebKit API
https://bugs.webkit.org/show_bug.cgi?id=112342

Reviewed by Adam Barth.

Source/WebCore:

  • dom/UserGestureIndicator.cpp:
  • dom/UserGestureIndicator.h:

(UserGestureToken):

Source/WebKit/chromium:

  • public/WebUserGestureToken.h:

(WebUserGestureToken):

  • src/WebUserGestureToken.cpp:

(WebKit::WebUserGestureToken::hasGestures):
(WebKit):

  • tests/WebUserGestureTokenTest.cpp:

(WebCore::TEST):

2:50 PM Changeset in webkit [145943] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebCore

Convert inspector to new-flexbox
https://bugs.webkit.org/show_bug.cgi?id=112399

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-15
Reviewed by Ojan Vafai.

No new tests, refactoring.

  • inspector/front-end/auditsPanel.css:

(.audit-launcher-view .audit-launcher-view-content):
(.audit-launcher-view div.button-container):
(.audit-launcher-view div.button-container > button):

  • inspector/front-end/dialog.css:

(.dialog):

  • inspector/front-end/elementsPanel.css:

(.sidebar-pane.composite .metrics):

  • inspector/front-end/helpScreen.css:

(.help-window-main):
(.help-content):

  • inspector/front-end/inspector.css:

(#toolbar):
(#toolbar-controls):
(#toolbar-dropdown .scrollable-content):
(#toolbar-dropdown .toolbar-item):
(.toolbar-item.close-left, .toolbar-item.close-right):

  • inspector/front-end/nativeMemoryProfiler.css:

(.memory-pie-chart-container):
(.memory-pie-chart):

  • inspector/front-end/networkPanel.css:

(.network-item-view.visible):

  • inspector/front-end/panelEnablerView.css:

(.panel-enabler-view .flexible-space):

  • inspector/front-end/profilesPanel.css:

(.profile-launcher-view-content):
(.control-profiling):

  • inspector/front-end/splitView.css:

(.sidebar-overlay):

  • inspector/front-end/tabbedPane.css:

(.tabbed-pane):
(.tabbed-pane-content):
Replace -webkit-box with -webkit-flex, -webkit-box-orient with
-webkit-flex-direction, etc.

2:37 PM Changeset in webkit [145942] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-536.30-branch

Merged r132724. <rdar://problem/13335007>

2:30 PM Changeset in webkit [145941] by Lucas Forschler
  • 6 edits in branches/safari-536.30-branch

Merged r132511. <rdar://problem/13334997>

2:28 PM Changeset in webkit [145940] by commit-queue@webkit.org
  • 30 edits in trunk

Source/WebCore: Remove unused unified textchecker variable
https://bugs.webkit.org/show_bug.cgi?id=112362

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-03-15
Reviewed by Tony Chang.

The variable m_originalUnifiedSpellCheckerEnabled is never used. The generated
code from Settings.in already backs up and restores unified textchecker setting.

  • testing/InternalSettings.h: Remove unusued m_originalUnifiedSpellCheckerEnabled variable.

Tools: Remove setAsynchronousSpellCheckingEnabled from test runners
https://bugs.webkit.org/show_bug.cgi?id=112362

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-03-15
Reviewed by Tony Chang.

Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
in internals.settings, so all ports can share it.

  • DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
  • DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
  • DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
  • DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
  • DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
  • DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
  • DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
  • DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
  • DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.

LayoutTests: Move setAsynchronousSpellCheckingEnabled to internals.settings
https://bugs.webkit.org/show_bug.cgi?id=112362

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-03-15
Reviewed by Tony Chang.

Changed the tests from using testRunner.setAsynchronousSpellCheckingEnabled(bool)
with port-specific implementations to use internals.settings.setAsynchronousSpellCheckingEnabled(bool)
with one common implementation, similar to internals.settings.setUnifiedTextCheckerEnabled(bool).
Changed the tests to not reset these settings when they finish, because the test harness resets
the settings automatically.

  • editing/spelling/grammar-markers-hidpi.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
  • editing/spelling/grammar-markers.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
  • editing/spelling/grammar-paste.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
  • editing/spelling/resources/util.js: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
  • editing/spelling/script-tests/spellcheck-paste.js: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
  • editing/spelling/spellcheck-async-mutation.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
  • editing/spelling/spellcheck-async-remove-frame.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
  • editing/spelling/spellcheck-async.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
  • editing/spelling/spellcheck-paste-disabled.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
  • editing/spelling/spellcheck-queue.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
  • editing/spelling/spellcheck-sequencenum.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
  • editing/spelling/spelling-marker-description.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
  • platform/chromium/editing/spelling/delete-misspelled-word.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
  • platform/chromium/editing/spelling/move-cursor-to-misspelled-word.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
2:26 PM Changeset in webkit [145939] by Lucas Forschler
  • 2 edits in branches/safari-536.30-branch/Source/WebCore

Merge 132287. <rdar://problem/13335000>

2:16 PM Changeset in webkit [145938] by Lucas Forschler
  • 3 edits
    3 adds in branches/safari-536.30-branch

Merge 131709. <rdar://problem/13334885>

2:13 PM Changeset in webkit [145937] by ojan@chromium.org
  • 4 edits
    2 adds in trunk

Auto height column flexboxes with border and padding are too short
https://bugs.webkit.org/show_bug.cgi?id=112398

Reviewed by Tony Chang.

Source/WebCore:

Test: css3/flexbox/auto-height-column-with-border-and-padding.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::mainAxisContentExtent):
computeLogicalHeight expects that you pass in the border-box logicalHeight, not
the contentLogicalHeight. Since we subtract the border, padding and scrollbar height from
the returned m_extent, if we pass in the contentLogicalHeight and the flexbox is auto-sized
then we end up incorrectly subtracting border, padding and scrollbar height from the
contentLogicalHeight.

LayoutTests:

  • css3/flexbox/auto-height-column-with-border-and-padding-expected.html: Added.
  • css3/flexbox/auto-height-column-with-border-and-padding.html: Added.
  • css3/flexbox/resources/flexbox.css:

(.flex-one-one-auto):

2:06 PM Changeset in webkit [145936] by kov@webkit.org
  • 41 edits in trunk/Source/WebCore/platform/gtk/po

Unreviewed, build fix. Also gather translatable strings from WebKit2 files.

  • POTFILES.in: added WebKit2GTK+ files that have translatable strings.
  • ar.po: regenerated.
  • as.po: ditto.
  • bg.po: ditto.
  • cs.po: ditto.
  • de.po: ditto.
  • el.po: ditto.
  • en_CA.po: ditto.
  • en_GB.po: ditto.
  • eo.po: ditto.
  • es.po: ditto.
  • et.po: ditto.
  • eu.po: ditto.
  • fr.po: ditto.
  • gl.po: ditto.
  • gu.po: ditto.
  • he.po: ditto.
  • hi.po: ditto.
  • hu.po: ditto.
  • id.po: ditto.
  • it.po: ditto.
  • ko.po: ditto.
  • lt.po: ditto.
  • lv.po: ditto.
  • mr.po: ditto.
  • nb.po: ditto.
  • nl.po: ditto.
  • pa.po: ditto.
  • pl.po: ditto.
  • pt.po: ditto.
  • pt_BR.po: ditto.
  • ro.po: ditto.
  • ru.po: ditto.
  • sl.po: ditto.
  • sr.po: ditto.
  • sr@latin.po: ditto.
  • sv.po: ditto.
  • uk.po: ditto.
  • vi.po: ditto.
  • zh_CN.po: ditto.
1:34 PM Changeset in webkit [145935] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

[iOS] Fix the length pass to memcmp in the fallback versions of String's equal
https://bugs.webkit.org/show_bug.cgi?id=112463

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-15
Reviewed by Ryosuke Niwa.

  • wtf/text/StringImpl.h:

(WTF::equal): It might be a good idea to compare the full UChar strings...

1:33 PM Changeset in webkit [145934] by timothy_horton@apple.com
  • 7 edits in trunk/Source/WebCore

RenderSnapshottedPlugIn can't be a RenderBlock (what if it's display: inline?)
https://bugs.webkit.org/show_bug.cgi?id=112432
<rdar://problem/13187211>

Reviewed by Simon Fraser and Dean Jackson.

Re-use code from PLUGIN_PROXY_FOR_VIDEO to allow RenderEmbeddedObject to lay out its children,
and make RenderSnapshottedPlugIn a RenderEmbeddedObject subclass once again. This will ensure that
RenderSnapshottedPlugIn lays itself out in the page the same as the RenderEmbeddedObject it replaces did,
preventing snapshotted plug-ins from breaking the layout when they are display: inline.

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler):
RenderSnapshottedPlugIn is a RenderEmbeddedObject subclass again, so we need to check
for it when we have a RenderEmbeddedObject, instead of when we don't.

  • page/FrameView.cpp:

(WebCore::FrameView::updateWidget):
Ditto.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::layout):
(WebCore::RenderEmbeddedObject::canHaveChildren):
Allow RenderEmbeddedObject to have and lay out children if it is a RenderSnapshottedPlugIn.
Also, preserve the code that allows children if it is a media element and PLUGIN_PROXY_FOR_VIDEO is enabled.
Don't call addWidgetToUpdate for instances which will never have a widget, like RenderSnapshottedPlugIn.

  • rendering/RenderEmbeddedObject.h:

(RenderEmbeddedObject):
We need canHaveChildren() and children() and m_children now.
Add canHaveWidget(), which returns true. Subclasses can override if need be.

  • rendering/RenderSnapshottedPlugIn.h: Add canHaveWidget(), which is false for RenderSnapshottedPlugIn.
  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):
(WebCore::RenderSnapshottedPlugIn::layout):
(WebCore::RenderSnapshottedPlugIn::getCursor):
Make RenderSnapshottedPlugIn a RenderEmbeddedObject.

(WebCore::RenderSnapshottedPlugIn::paint):
Paint our children.

1:24 PM Changeset in webkit [145933] by msaboff@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Cleanup of DFG and Baseline JIT debugging code
https://bugs.webkit.org/show_bug.cgi?id=111871

Reviewed by Geoffrey Garen.

Fixed various debug related issue in baseline and DFG JITs. See below.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgLinkClosureCall): Used pointerDump() to handle when calleeCodeBlock is NULL.

  • dfg/DFGScratchRegisterAllocator.h: Now use ScratchBuffer::activeLengthPtr() to get

pointer to scratch register length.
(JSC::DFG::ScratchRegisterAllocator::preserveUsedRegistersToScratchBuffer):
(JSC::DFG::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBuffer):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkConsistency): Added missing case labels for DataFormatOSRMarker,
DataFormatDead, and DataFormatArguments and made them RELEASE_ASSERT_NOT_REACHED();

  • jit/JITCall.cpp:

(JSC::JIT::privateCompileClosureCall): Used pointerDump() to handle when calleeCodeBlock is NULL.

  • jit/JITCall32_64.cpp:

(JSC::JIT::privateCompileClosureCall): Used pointerDump() to handle when calleeCodeBlock is NULL.

  • runtime/JSGlobalData.h:

(JSC::ScratchBuffer::ScratchBuffer): Fixed buffer allocation alignment to
be on a double boundary.
(JSC::ScratchBuffer::setActiveLength):
(JSC::ScratchBuffer::activeLength):
(JSC::ScratchBuffer::activeLengthPtr):

1:12 PM Changeset in webkit [145932] by morrita@google.com
  • 34 edits
    2 adds in trunk

[Custom Elements] Any HTMLElement subclass should become a superclass of custom element
https://bugs.webkit.org/show_bug.cgi?id=110436

Reviewed by Dimitri Glazkov.

Source/WebCore:

This change introduces "type extension" concept of custom elements.
With the type extension, each custom elements are able to inherit
from not only HTMLElement, but also any HTML element. To make it work,
this change extends the plumbing.

This change does following changes:

Data structure:

  • Let CustomElementConstructor objects being keyed by pair of (element name, local name) as the standard requries, instead of just using single name. See CustomElementRegistry::ConstructorMap and CustomElementRegistry::find().
  • Creates mapping from WrapperTypeInfo to element name. This map can be looked-up by generated functions like findHTMLTagNameOfV8Type(). With this table, WebKit can determine the custom element local name of given prototype object. See make_names.pl. Note that V8 prototype object knows associated WrapperTypeInfo. See r144865.

Hooking up element lifecyle:

  • Create appropriate C++ instance for each custom element. Before this change, the C++ backend of custom elements were always HTMLUnknownElements or HTMLElement. See CustomElementConstructor::createElement() and ElementFactories in make_names.pl.
  • Hooks up element construction and element wrapper creation for custom element "before" non-custom case instead of "after" that. We do this because custom element needs to override non-custom case when @is attribute is given for otherwise-non-custom elements like <div is=x-bar>. See make_names.pl.
  • Gives @is attributes to elements if needed. See setTypeExtension() call sites like Document::createElement(), Document::createElementtNS() and CustomElementConstructor::createElementt()

Test: fast/dom/custom/document-register-type-extensions.html

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/scripts/test/V8/V8Float64Array.h:
  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:
  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
  • bindings/scripts/test/V8/V8TestEventConstructor.h:
  • bindings/scripts/test/V8/V8TestEventTarget.h:
  • bindings/scripts/test/V8/V8TestException.h:
  • bindings/scripts/test/V8/V8TestInterface.h:
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
  • bindings/scripts/test/V8/V8TestNamedConstructor.h:
  • bindings/scripts/test/V8/V8TestNode.h:
  • bindings/scripts/test/V8/V8TestObj.h:
  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
  • bindings/scripts/test/V8/V8TestTypedefs.h:
  • bindings/v8/CustomElementHelpers.cpp:

(WebCore::hasValidPrototypeChain):
(WebCore::CustomElementHelpers::isValidPrototypeParameter):
(WebCore::CustomElementHelpers::findLocalName):
(WebCore):
(WebCore::CustomElementHelpers::findWrapperType):

  • bindings/v8/CustomElementHelpers.h:

(CustomElementHelpers):

  • bindings/v8/V8CustomElement.cpp:

(WebCore::V8CustomElement::createWrapper):

  • bindings/v8/V8CustomElement.h:

(V8CustomElement):
(WebCore::V8CustomElement::wrap):
(WebCore::V8CustomElement::constructorOf):

  • bindings/v8/WrapperTypeInfo.h:

(WrapperTypeTraits): Added.

  • bindings/v8/custom/V8CustomElementConstructorCustom.cpp:

(WebCore::V8CustomElementConstructor::callAsFunctionCallback):

  • dom/CustomElementConstructor.cpp:

(WebCore::CustomElementConstructor::create):
(WebCore::CustomElementConstructor::CustomElementConstructor):
(WebCore::CustomElementConstructor::createElement):
(WebCore::setTypeExtension):

  • dom/CustomElementConstructor.h:

(CustomElementConstructor):
(WebCore::CustomElementConstructor::document):
(WebCore::CustomElementConstructor::typeName):
(WebCore::CustomElementConstructor::localName):

  • dom/CustomElementRegistry.cpp:

(WebCore::nameIncludesHyphen):
(WebCore::CustomElementRegistry::isValidName):
(WebCore::CustomElementRegistry::registerElement):
(WebCore::CustomElementRegistry::findFor):
(WebCore::CustomElementRegistry::find):
(WebCore::CustomElementRegistry::createElement):

  • dom/CustomElementRegistry.h:

(CustomElementRegistry):

  • dom/Document.cpp:

(WebCore::Document::createElement):
(WebCore::Document::createElementNS):
(WebCore::Document::registerElement):

  • dom/Document.h:

(Document):
(WebCore::Document::registry): Moved from Document.cpp to be inlined.

  • dom/Document.idl:
  • dom/make_names.pl:

(printFactoryCppFile):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):

  • html/HTMLAttributeNames.in: Added @is attribute

LayoutTests:

  • fast/dom/custom/document-register-basic-expected.txt:
  • fast/dom/custom/document-register-basic.html:
  • fast/dom/custom/document-register-type-extensions-expected.txt: Added.
  • fast/dom/custom/document-register-type-extensions.html: Added.
12:33 PM Changeset in webkit [145931] by msaboff@apple.com
  • 7 edits in trunk/Source

Add runtime check for improper register allocations in DFG
https://bugs.webkit.org/show_bug.cgi?id=112380

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added framework to check for register allocation within a branch source - target range. All register allocations
are saved using the offset in the code stream where the allocation occurred. Later when a jump is linked, the
currently saved register allocations are checked to make sure that they didn't occur in the range of code that was
jumped over. This protects against the case where an allocation could have spilled register contents to free up
a register and that spill only occurs on one path of a many through the code. A subsequent fill of the spilled
register may load garbage. See https://bugs.webkit.org/show_bug.cgi?id=111777 for one such bug.
This code is protected by the compile time check of #if ENABLE(DFG_REGISTER_ALLOCATION_VALIDATION).
The check is only done during the processing of SpeculativeJIT::compile(Node* node) and its callees.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::Jump::link): Invoke register allocation checks using source and target of link.
(JSC::AbstractMacroAssembler::Jump::linkTo): Invoke register allocation checks using source and target of link.
(AbstractMacroAssembler):
(RegisterAllocationOffset): New helper class to store the instruction stream offset and compare against a
jump range.
(JSC::AbstractMacroAssembler::RegisterAllocationOffset::RegisterAllocationOffset):
(JSC::AbstractMacroAssembler::RegisterAllocationOffset::check):
(JSC::AbstractMacroAssembler::addRegisterAllocationAtOffset):
(JSC::AbstractMacroAssembler::clearRegisterAllocationOffsets):
(JSC::AbstractMacroAssembler::checkRegisterAllocationAgainstBranchRange):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::allocate):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

Source/WTF:

  • wtf/Platform.h: Added new ENABLE_DFG_REGISTER_ALLOCATION_VALIDATION compilation flag to

enable generation of register allocation checking. This is on for debug builds.

12:03 PM Changeset in webkit [145930] by ap@apple.com
  • 20 edits in trunk/Source/WebCore

Minor cleanup in worker code
https://bugs.webkit.org/show_bug.cgi?id=112455

Reviewed by Anders Carlsson.

  • Added OVERRIDE keywords.
  • Toned down FIXMEs about single MessagePort versions of functions. It's not a given that we'll want to get rid of them even when implementing array versions.
  • Explicitly marked virtual destructors as virtual.
  • dom/MessageEvent.cpp:
  • dom/MessageEvent.h:
  • workers/Worker.cpp:
  • workers/Worker.h: Removed an unused version of postMessage() that took no MessagePorts. This makes it less confusing why MessagePortArray is passed by pointer, and not by reference.
  • workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::~DedicatedWorkerContext):
  • workers/DedicatedWorkerContext.h: Added a destructor instead of an implicit one. Removed an unused version of postMessage() that took no MessagePorts.
  • workers/SharedWorker.h: Removed an unused virtual function (thank you OVERRIDE!)
  • dom/MessagePort.cpp:
  • dom/MessagePort.h:
  • loader/WorkerThreadableLoader.h:
  • page/DOMWindow.h:
  • workers/AbstractWorker.h:
  • workers/DedicatedWorkerThread.h:
  • workers/SharedWorkerContext.h:
  • workers/SharedWorkerThread.h:
  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerObjectProxy.h:
  • workers/WorkerScriptLoader.h:
11:58 AM Changeset in webkit [145929] by jsbell@chromium.org
  • 27 edits
    2 copies
    1 add in trunk

[V8] Binding: Implement EnforceRange IDL Attribute for long long conversions
https://bugs.webkit.org/show_bug.cgi?id=96798

Reviewed by Kentaro Hara.

Source/WebCore:

Implement [EnforceRange] attribute for V8 bindings, which specifies throwing behavior
on conversions outside int/uint 32/64 ranges and edge cases like NaNs and Infinities.
Conversely, conversions without this attribute should *not* throw.

Tests: fast/js/webidl-type-mapping.html:

fast/dom/non-numeric-values-numeric-parameters.html
fast/js/script-tests/select-options-add.html
storage/indexeddb/intversion-bad-parameters.html

  • Modules/indexeddb/IDBCursor.cpp: Remove custom range enforcement for advance()
  • Modules/indexeddb/IDBCursor.h: Adjust type to match WebIDL.
  • Modules/indexeddb/IDBCursor.idl: Specify [EnforceRange] and type matches spec WebIDL.
  • Modules/indexeddb/IDBFactory.cpp: Remove custom range enforcement for open()
  • Modules/indexeddb/IDBFactory.h: Adjust type to match WebIDL.
  • Modules/indexeddb/IDBFactory.idl: Specify [EnforceRange] and type matches spec WebIDL.
  • bindings/scripts/CodeGeneratorJS.pm:

(JSValueToNative): Add FIXME to support [EnforceRange]

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter): Handle [EnforceRange] in attribute setters
(GenerateParametersCheck): Handle [EnforceRange] in parameters.
(JSValueToNative): Pass EnforceRange to toInt() functions as appropriate.

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/TestObj.idl: Tests w/ [EnforceRange]
  • bindings/scripts/test/V8/V8TestObj.cpp: Updated expectations
  • bindings/scripts/test/V8/V8TestTypedefs.cpp: Updated expectations.
  • bindings/v8/V8Binding.cpp: Overloads for toInt() variants that handle constraints.

(WebCore::toInt32):
(WebCore::toUInt32):
(WebCore::toInt64):
(WebCore::toUInt64):

  • bindings/v8/V8Binding.h: Ditto, plus helpers for callers not expecting errors.

(WebCore::toInt32):
(WebCore::toUInt32):
(WebCore::toInt64):
(WebCore::toUInt64):

  • bindings/v8/V8BindingMacros.h: Helper macros for type conversions that may throw.
  • testing/TypeConversions.h: Added new members with EnforceRange constraint.
  • testing/TypeConversions.idl: Ditto.

LayoutTests:

Some of the tests for HTMLOptionsCollection.add() assumed it should throw for
Infinities and NaNs, but this is not what the DOM+WebIDL specs say. (Firefox doesn't throw
so this does not appear to be a web-compat issue.) This updates the tests/expectations so
that V8 passes. JSC expectations are FAIL in a few places since it still incorrectly throws
on Infinity/NaN -> int32 conversion (existing tests) and does not implement EnforceRange
(new tests).

Tne non-numeric-values-numeric-parameters test was also broken for NaN testing, reporting
incorrect results which hid some of this behavior.

  • fast/dom/non-numeric-values-numeric-parameters-expected.txt: Failing behavior for JSC.
  • fast/dom/script-tests/non-numeric-values-numeric-parameters.js: HTMLOptionsCollection.add()

should not throw on NaNs/Infinities.

  • fast/js/script-tests/select-options-add.js: Ditto.
  • fast/js/select-options-add-expected.txt: Failing behavior for JSC.
  • fast/js/webidl-type-mapping-expected.txt: Ditto.
  • fast/js/webidl-type-mapping.html: Added test cases for [EnforceRange]
  • platform/chromium/fast/dom/non-numeric-values-numeric-parameters-expected.txt: Added - passing behavior for V8.
  • platform/chromium/fast/js/select-options-add-expected.txt: Ditto.
  • platform/chromium/fast/js/webidl-type-mapping-expected.txt: Added.
  • storage/indexeddb/intversion-bad-parameters-expected.txt: Added non-finite test cases.
  • storage/indexeddb/resources/intversion-bad-parameters.js: Ditto.
11:58 AM Changeset in webkit [145928] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-536.30-branch

Merged r130999. <rdar://problem/13334880>

11:52 AM Changeset in webkit [145927] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Marking sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.8_Arguments_Object/S10.1.8_A3_T2.html
as a Slow test.

  • platform/mac/TestExpectations:
11:47 AM Changeset in webkit [145926] by eustas@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Network] Refine JSDocs in NetworkRequest.js
https://bugs.webkit.org/show_bug.cgi?id=112412

Reviewed by Vsevolod Vlasov.

Return types for some members are confusing (Object).

  • inspector/front-end/NetworkManager.js: Fixed JSDocs.
  • inspector/front-end/NetworkRequest.js: Ditto. Plus minor refactorings.
11:43 AM Changeset in webkit [145925] by Simon Fraser
  • 2 edits in trunk/Tools

Fix the stupid unit tests.

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(test_sample_process):

11:26 AM Changeset in webkit [145924] by aestes@apple.com
  • 4 edits
    2 adds in trunk

REGRESSION (r127277): CSS URIs with multi-byte Unicode escape sequences fail to parse
https://bugs.webkit.org/show_bug.cgi?id=112436

Reviewed by Michael Saboff.

Source/WebCore:

r127277 modified the CSS parser to use 8-bit strings when possible.
However, it failed to handle URIs that contain Unicode escape sequences
that expand to multi-byte characters. Not only would the URI fail to
parse, but so would the remainder of the input string.

Fix this by producing a 16-bit result when we detect a URI with a
multi-byte Unicode escape, like we do for identifiers and other strings.

Test: fast/css/url-with-multi-byte-unicode-escape.html

  • css/CSSParser.cpp:

(WebCore::checkAndSkipString): Changed to be a free function since it
doesn't access CSSParser's internal state.
(WebCore::CSSParser::findURI): Added a function that consolidates the
logic of finding the start and end pointers of the URI and the quote
character (if encountered), starting at the current character.
(WebCore::CSSParser::parseURIInternal): Removed duplicated logic for
finding the URI bounds (this now lives in findURI()) and logic for
setting the token type and updating the current character (this now
lives in parseURI()).
(WebCore::CSSParser::parseURI): Find the URI and parse it. If a
multi-byte Unicode escape is encountered, rewind to the beginning of
the URI and re-parse with a 16-bit string as the destination.

  • css/CSSParser.h:

LayoutTests:

  • fast/css/url-with-multi-byte-unicode-escape-expected.txt: Added.
  • fast/css/url-with-multi-byte-unicode-escape.html: Added.
11:16 AM Changeset in webkit [145923] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r188418. Requested by
"Adam Barth" <abarth@webkit.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-15

  • DEPS:
11:10 AM Changeset in webkit [145922] by akling@apple.com
  • 8 edits
    1 delete in trunk/Source/WebCore

[JSC] Remove custom WebAudio mark functions that we can generate instead.
<http://webkit.org/b/110976>

Reviewed by Eric Carlson.

Remove custom JSC mark functions for AudioContext and ScriptProcessorNode since they
are trivial to generate.

  • Modules/webaudio/AudioContext.idl:
  • Modules/webaudio/ScriptProcessorNode.idl:
  • GNUmakefile.list.am:
  • UseJSC.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSAudioContextCustom.cpp:
  • bindings/js/JSScriptProcessorNodeCustom.cpp: Removed.
11:08 AM Changeset in webkit [145921] by kareng@chromium.org
  • 62 edits in branches/chromium/1441/Source

Revert 145802 "[V8] Store main world and non-main world template..."

[V8] Store main world and non-main world templates separately.
https://bugs.webkit.org/show_bug.cgi?id=111724

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-14
Reviewed by Jochen Eisinger.

This is needed for generating specialized bindings for the main
world (bug 110874).

Source/WebCore:

No new tests (updated existing bindings tests).

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
(GenerateImplementation):
(JSValueToNative):
(CreateCustomSignature):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooMethod):
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionMethod):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::dispatchEventMethod):
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):

  • bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Method):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):

  • bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsMethod):
(WebCore::TestObjV8Internal::longMethodWithArgsMethod):
(WebCore::TestObjV8Internal::objMethodWithArgsMethod):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsMethod):
(WebCore::TestObjV8Internal::overloadedMethod1Method):
(WebCore::TestObjV8Internal::overloadedMethod2Method):
(WebCore::TestObjV8Internal::overloadedMethod8Method):
(WebCore::TestObjV8Internal::overloadedMethodMethod):
(WebCore::TestObjV8Internal::convert1Method):
(WebCore::TestObjV8Internal::convert2Method):
(WebCore::TestObjV8Internal::convert4Method):
(WebCore::TestObjV8Internal::convert5Method):
(WebCore::TestObjV8Internal::variadicNodeMethodMethod):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::TestOverloadedConstructorsV8Internal::constructor1):
(WebCore::TestOverloadedConstructorsV8Internal::constructor2):
(WebCore::TestOverloadedConstructorsV8Internal::constructor3):
(WebCore::TestOverloadedConstructorsV8Internal::constructor):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

  • bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::funcMethod):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):

  • bindings/scripts/test/V8/V8TestTypedefs.h:

(V8TestTypedefs):

  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::visitNodeWrappers):

  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/V8AdaptorFunction.cpp:

(WebCore::V8AdaptorFunction::getTemplate):

  • bindings/v8/V8Binding.cpp:

(WebCore::toDOMStringList):
(WebCore::toXPathNSResolver):

  • bindings/v8/V8Binding.h:

(WebCore):
(WebCore::toRefPtrNativeArray):

  • bindings/v8/V8Collection.cpp:

(WebCore::toOptionsCollectionSetter):

  • bindings/v8/V8GCController.cpp:
  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):
(WebCore::V8PerIsolateData::hasPrivateTemplate):
(WebCore::V8PerIsolateData::privateTemplate):
(WebCore::V8PerIsolateData::rawTemplate):
(WebCore::V8PerIsolateData::hasInstance):

  • bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::rawTemplateMap):
(V8PerIsolateData):
(WebCore::V8PerIsolateData::templateMap):

  • bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):

  • bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAttrSetterCustom):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCustom):

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toCanvasStyle):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::setDragImageMethodCustom):

  • bindings/v8/custom/V8CryptoCustom.cpp:

(WebCore::V8Crypto::getRandomValuesMethodCustom):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCustom):
(WebCore::V8DOMFormData::appendMethodCustom):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCustom):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateMethodCustom):

  • bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAttrSetterCustom):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::addMethodCustom):

  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::removeElement):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::isHTMLAllCollectionMethodCustom):
(WebCore::V8InjectedScriptHost::typeMethodCustom):
(WebCore::V8InjectedScriptHost::getEventListenersMethodCustom):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::removeChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::opaqueRootForGC):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toWebGLUniformLocation):
(WebCore::V8WebGLRenderingContext::getAttachedShadersMethodCustom):
(WebCore::V8WebGLRenderingContext::getProgramParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getShaderParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getUniformMethodCustom):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::isDocumentType):
(WebCore::V8XMLHttpRequest::sendMethodCustom):

Source/WebKit/chromium:

  • src/WebArrayBuffer.cpp:

(WebKit::WebArrayBuffer::createFromV8Value):

  • src/WebArrayBufferView.cpp:

(WebKit::WebArrayBufferView::createFromV8Value):

  • src/WebBindings.cpp:

(WebKit::getRangeImpl):
(WebKit::getNodeImpl):
(WebKit::getElementImpl):
(WebKit::getArrayBufferImpl):
(WebKit::getArrayBufferViewImpl):

TBR=commit-queue@webkit.org

11:05 AM Changeset in webkit [145920] by kareng@chromium.org
  • 1 add in branches/chromium/1441/codereview.settings

for drovering

11:04 AM Changeset in webkit [145919] by kareng@chromium.org
  • 1 copy in branches/chromium/1441

branching for 1441 to revert top crasher.

11:03 AM Changeset in webkit [145918] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix. Rename local variable which was colliding with class method.

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::clone):

11:00 AM Changeset in webkit [145917] by jsbell@chromium.org
  • 4 edits in trunk/Source

IndexedDB: Handle success events arriving after context stopped
https://bugs.webkit.org/show_bug.cgi?id=112451

Reviewed by Tony Chang.

Source/WebCore:

In multiprocess ports, events from the back-end can arrive in the form of
onXXX() calls after the script execution context has stopped. These need to
be ignored. This was already done in most cases, but missing for two overloads
of IDBRequest::onSuccess() - void and int64_t.

Test: webkit_unit_test IDBRequestTest.EventsAfterStopping

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess): Early return if context has stopped.
(WebCore::IDBRequest::onSuccessInternal): ASSERT() that callers have checked context.

Source/WebKit/chromium:

  • tests/IDBRequestTest.cpp:

(WebKit::TEST_F): Add cases for onSuccess() and onSuccess(int64_t)

10:59 AM Changeset in webkit [145916] by Simon Fraser
  • 8 edits in trunk

Collect samples for unresponsive web processes
https://bugs.webkit.org/show_bug.cgi?id=112409

Tools:

Reviewed by Tim Horton.

When we detect that a subprocess was unresponsive, run the 'sample'
tool on that process, for the Mac port.

The sample will be linked to from the results.html page, next
to the crash log link.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._look_for_new_crash_logs): Before looking for crash logs,
look for samples on disk.

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(TestResultWriter):
(TestResultWriter.copy_sample_file): Teach TestResultWriter about
-sample.txt files, and have it copy their contents to a new file
next to the test that spawned them (as we do for crash logs).

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.look_for_new_samples): Base class does nothing for sampling.

  • Scripts/webkitpy/layout_tests/port/driver.py:

(Driver._check_for_driver_crash): Kick off a sample if we detected
that the subprocess was unresponsive.

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.sample_file_path): Utility to generate the file path
to the generated sample files at the top level of layout-test-results.
(MacPort.look_for_new_crash_logs): Fix typo
(MacPort.look_for_new_samples): New function to find sample files.
(MacPort.sample_process): Use the utility function to get the file path.

LayoutTests:

Reviewed by Tim Horton.

Add links for samples, which some platforms will show for unresponsive WebProcess timeouts.

  • fast/harness/results.html:
10:58 AM Changeset in webkit [145915] by jer.noble@apple.com
  • 6 edits
    3 adds in trunk

REGRESSION: -webkit-box-reflect does not show on video elements
https://bugs.webkit.org/show_bug.cgi?id=112397

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/video/video-reflection.html

Support cloning specific CALayer subtypes in PlatformCALayer,
which allows reflections to work correctly for those layer types.
Specifically, add support for cloning AVPlayerLayer layers.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::cloneLayer): Moved most of the

implementation to PlatformCALayer::clone().

  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::PlatformCALayer): Set the layerType to

LayerTypeAVPlayerLayer if the PlatformLayer parameter is an
AVPlayerLayer.

(PlatformCALayer::clone): Moved from GraphicsLayerCA::cloneLayer().

Copy the player value to the new layer, if the current layer is
a LayerTypeAVPlayerLayer.

(PlatformCALayer::playerLayer):

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::clone): Moved from GraphicsLayerCA::cloneLayer().

May want to add support for AVCFPlayerLayers in the future.

LayoutTests:

  • compositing/video/video-reflection-expected.png: Added.
  • compositing/video/video-reflection-expected.txt: Added.
  • compositing/video/video-reflection.html: Added.
10:45 AM Changeset in webkit [145914] by Nate Chapin
  • 46 edits in trunk/Source

Hide MainResourceLoader from the outside world
https://bugs.webkit.org/show_bug.cgi?id=109971

Reviewed by Adam Barth.

Source/WebCore:

No new tests, refactor only.

  • WebCore.exp.in:
  • dom/Document.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/MediaDocument.cpp:
  • html/PluginDocument.cpp:
  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::mainResourceLoader):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::receivedData):
(WebCore::DocumentLoader::setMainResourceDataBufferingPolicy):

  • loader/DocumentLoader.h:
  • loader/EmptyClients.h:
  • loader/FrameLoader.cpp:
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.cpp:
  • loader/appcache/ApplicationCacheGroup.cpp:
  • loader/appcache/ApplicationCacheHost.cpp:

Source/WebKit/blackberry:

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):

  • WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

Source/WebKit/chromium:

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::convertMainResourceLoadToDownload):

  • src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::convertMainResourceLoadToDownload):

  • WebCoreSupport/FrameLoaderClientEfl.h:

(FrameLoaderClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::convertMainResourceLoadToDownload):

  • WebCoreSupport/FrameLoaderClientGtk.h:

(FrameLoaderClient):

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::convertMainResourceLoadToDownload):

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::convertMainResourceLoadToDownload):

  • WebCoreSupport/FrameLoaderClientQt.h:

(FrameLoaderClientQt):

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::convertMainResourceLoadToDownload):

  • WebFrame.h:

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::convertMainResourceLoadToDownload):

  • WebCoreSupport/FrameLoaderClientWinCE.h:

(FrameLoaderClientWinCE):

Source/WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::convertMainResourceLoadToDownload):

  • WebKitSupport/FrameLoaderClientWx.h:

(FrameLoaderClientWx):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::convertMainResourceLoadToDownload):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::convertMainResourceLoadToDownload):

  • WebProcess/WebPage/WebFrame.h:

(WebFrame):

10:31 AM Changeset in webkit [145913] by inferno@chromium.org
  • 77 edits in trunk/Source

Replace static_casts with to* helper functions.
https://bugs.webkit.org/show_bug.cgi?id=112401

Reviewed by Stephen Chenney.

to* helper functions are preferred over static_cast calls since they
help to catch bad casts easily on the testing infrastructure.

Source/WebCore:

  • accessibility/AccessibilityObject.cpp:

(WebCore::appendAccessibilityObject):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::visiblePositionForPoint):

  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::documentFrameView):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):

  • accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::pluginScriptObjectFromPluginViewBase):

  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::setJavaScriptPaused):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::createScriptInstanceForWidget):

  • bindings/js/ScriptControllerQt.cpp:

(WebCore::ScriptController::createScriptInstanceForWidget):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::createScriptInstanceForWidget):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::appendFormData):

  • page/EventHandler.cpp:

(WebCore::EventHandler::subframeForTargetNode):
(WebCore::EventHandler::passGestureEventToWidget):

  • page/Frame.cpp:

(WebCore::Frame::frameForWidget):

  • page/FrameView.cpp:

(WebCore::collectFrameViewChildren):
(WebCore::FrameView::hasCustomScrollbars):
(WebCore::FrameView::convertToContainingView):
(WebCore::FrameView::convertFromContainingView):
(WebCore::FrameView::removeChild):

  • page/FrameView.h:

(WebCore::toFrameView):
(WebCore):

  • page/Page.cpp:

(WebCore::Page::collectPluginViews):

  • page/chromium/EventHandlerChromium.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

  • page/efl/EventHandlerEfl.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

  • page/gtk/EventHandlerGtk.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passWheelEventToWidget):

  • page/qt/EventHandlerQt.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):

  • page/win/EventHandlerWin.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

  • page/wx/EventHandlerWx.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

  • platform/ScrollView.h:

(WebCore::toScrollView):
(WebCore):

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::isScrollViewScrollbar):
(WebCore::Scrollbar::mouseUp):
(WebCore::Scrollbar::axObjectCache):

  • platform/Widget.h:

(WebCore::Widget::isScrollView):

  • platform/blackberry/PlatformScreenBlackBerry.cpp:

(WebCore::toUserSpace):

  • platform/efl/ScrollbarEfl.cpp:

(ScrollbarEfl::setParent):

  • platform/qt/PlatformSupportQt.cpp:

(WebCore::PlatformSupport::popupsAllowed):
(WebCore::PlatformSupport::pluginScriptableObject):

  • plugins/IFrameShimSupport.cpp:

(WebCore::getPluginOcclusions):

  • plugins/PluginView.h:

(WebCore::toPluginView):
(WebCore):

  • plugins/PluginViewBase.h:

(WebCore::PluginViewBase::isPluginViewBase):
(PluginViewBase):
(WebCore::toPluginViewBase):
(WebCore):

  • plugins/blackberry/PluginViewBlackBerry.cpp:

(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::updateBuffer):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleScrollEvent):
(WebCore::PluginView::calculateClipRect):
(WebCore::PluginView::handleFullScreenAllowedEvent):
(WebCore::PluginView::handleFullScreenExitEvent):
(WebCore::PluginView::setParent):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformGetValue):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformDestroy):
(WebCore::PluginView::setBackgroundPlay):

  • plugins/blackberry/PluginViewPrivateBlackBerry.cpp:

(WebCore::PluginViewPrivate::setVisibleRects):
(WebCore::PluginViewPrivate::showKeyboard):
(WebCore::PluginViewPrivate::requestFullScreen):
(WebCore::PluginViewPrivate::requestCenterFitZoom):
(WebCore::PluginViewPrivate::lockOrientation):
(WebCore::PluginViewPrivate::unlockOrientation):
(WebCore::PluginViewPrivate::preventIdle):

  • plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::updatePluginWidget):

  • plugins/mac/PluginViewMac.mm:

(WebCore::PluginView::platformStart):

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::updatePluginWidget):

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paintIntoTransformedContext):
(WebCore::PluginView::paintWindowedPluginIntoContext):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::snapshot):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::addLayoutOverflow):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::allowsAcceleratedCompositing):
(WebCore::RenderEmbeddedObject::viewCleared):
(WebCore::RenderEmbeddedObject::nodeAtPoint):
(WebCore::RenderEmbeddedObject::scroll):

  • rendering/RenderFlexibleBox.h:

(WebCore::toRenderFlexibleBox):
(WebCore):

  • rendering/RenderFrame.cpp:

(WebCore::RenderFrame::viewCleared):

  • rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::layoutWithFlattening):

  • rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::contentRootRenderer):
(WebCore::RenderIFrame::layoutSeamlessly):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):

  • rendering/RenderPart.cpp:

(WebCore::RenderPart::requiresAcceleratedCompositing):
(WebCore::RenderPart::embeddedContentBox):
(WebCore::RenderPart::nodeAtPoint):

  • rendering/RenderRuby.cpp:

(WebCore::rubyBeforeBlock):
(WebCore::rubyAfterBlock):
(WebCore::lastRubyRun):
(WebCore::findRubyRunParent):

  • rendering/RenderTreeAsText.cpp:

(WebCore::write):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paintContents):
(WebCore::RenderWidget::setOverlapTestResult):
(WebCore::RenderWidget::updateWidgetPosition):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::frameForNode):
(BlackBerry::WebKit::needsLayoutRecursive):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::redirectDataToPlugin):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusPluginElementVisible):

Source/WebKit/chromium:

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::scrollRect):
(WebKit::WebPluginContainerImpl::setWantsWheelEvents):
(WebKit::WebPluginContainerImpl::handleMouseEvent):

  • tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::TEST_F):

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::redirectDataToPlugin):

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::redirectDataToPlugin):

Source/WebKit/mac:

  • WebView/WebRenderNode.mm:

(copyRenderNode):

  • WebView/WebView.mm:

(-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::redirectDataToPlugin):

Source/WebKit/win:

  • WebCoreSupport/EmbeddedWidget.cpp:

(EmbeddedWidget::frameRectsChanged):

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::redirectDataToPlugin):

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::redirectDataToPlugin):

Source/WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::redirectDataToPlugin):

Source/WebKit2:

  • Shared/WebRenderObject.cpp:

(WebKit::WebRenderObject::WebRenderObject):

10:11 AM Changeset in webkit [145912] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] acceleration_backend_description does not concatenate "(gles2"
https://bugs.webkit.org/show_bug.cgi?id=112405

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-03-15
Reviewed by Martin Robinson.

In FindDependencies.m4, acceleration_backend_description string does not
concatenate if there is a space between the operator and the operand.

  • Source/autotools/FindDependencies.m4:
10:07 AM Changeset in webkit [145911] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Source/WebCore: [Texmap] REGRESSION (r144190): Failure at style with preserve-3d and opacity
https://bugs.webkit.org/show_bug.cgi?id=112370

According to spec, we avoid masking and clipping when preserves-3d is enabled.
However, opacity should still work.
Allowing opacity when preserves-3d is on.

Patch by No'am Rosenthal <Noam Rosenthal> on 2013-03-15
Reviewed by Caio Marcelo de Oliveira Filho.

Test: compositing/overlap-blending/preserves3d-opacity.html

  • platform/graphics/texmap/TextureMapperGL.cpp:
  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintRecursive):

LayoutTests: [Texmap] REGRESSION (r144190): Failure at style with webkit-transform and opacity
https://bugs.webkit.org/show_bug.cgi?id=112370

Patch by No'am Rosenthal <Noam Rosenthal> on 2013-03-15
Reviewed by Caio Marcelo de Oliveira Filho.

New ref-test for opacity+preserves-3d.

  • compositing/overlap-blending/preserves3d-opacity-expected.html: Added.
  • compositing/overlap-blending/preserves3d-opacity.html: Added.
9:56 AM Changeset in webkit [145910] by Lucas Forschler
  • 4 edits in tags/Safari-537.34/Source

Versioning

9:51 AM Changeset in webkit [145909] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Get rid of useless forward declaration.
https://bugs.webkit.org/show_bug.cgi?id=112449

Patch by Konrad Piascik <kpiascik@blackberry.com> on 2013-03-15
Reviewed by Stephen Chenney.

No behavioural change

  • svg/SVGRectElement.cpp:
9:26 AM Changeset in webkit [145908] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: make CPU profiler show timings using the same time unit [ms]
https://bugs.webkit.org/show_bug.cgi?id=112356

That makes it much easier to compare values when looking at the data.

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-15
Reviewed by Yury Semikhatsky.

  • inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):

9:24 AM Changeset in webkit [145907] by peter@chromium.org
  • 17 edits in trunk/Source/WebCore

Implement support for nullable types in the bindings generator
https://bugs.webkit.org/show_bug.cgi?id=111728

Reviewed by Kentaro Hara.

This patch adds support for nullable types in the bindings
generator, as described in section 3.10.22 of WebIDL:

http://dev.w3.org/2006/webapi/WebIDL/#idl-nullable-type

interface MyInterface {

readonly attribute boolean? value; true, false or null.

};

The IDL Parser has been modified to record whether attributes are
nullable. Question marks from the type will always be stripped
from the domAttribute->signature->type field. Once support for
this has been completely implemented, we'll be able to remove a
bunch of custom bindings, i.e. those of Device Orientation.

Any getter for an attribute which returns a nullable type will be
called with an additional attribute (passed by reference) named
"isNull". This will be the last argument passed to the method,
unless an exception code (ec) argument will be passed as well.

The CPP, GObject and ObjC bindings will not change behavior following
this patch, although they have been modified to call the WebCore
methods for nullable attributes with the correct signature. The
V8 and JS binding generators do have modified behavior, in that they
will actually return v8Null/jsNull when isNull == true.

Tested by existing binding tests and the new nullable attribute
tests in the bindings/scripts/test/ directory.

  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperty):
(GenerateFunction):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):

  • bindings/scripts/IDLParser.pm:

(typeHasNullableSuffix):
(typeRemoveNullableSuffix):
(parseAttributeRest):
(parseOptionalOrRequiredArgument):
(parseAttributeRestOld):

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::nullableDoubleAttribute):
(WebDOMTestObj::nullableLongAttribute):
(WebDOMTestObj::nullableBooleanAttribute):
(WebDOMTestObj::nullableStringAttribute):
(WebDOMTestObj::nullableLongSettableAttribute):
(WebDOMTestObj::setNullableLongSettableAttribute):
(WebDOMTestObj::nullableStringValue):
(WebDOMTestObj::setNullableStringValue):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_get_nullable_double_attribute):
(webkit_dom_test_obj_get_nullable_long_attribute):
(webkit_dom_test_obj_get_nullable_boolean_attribute):
(webkit_dom_test_obj_get_nullable_string_attribute):
(webkit_dom_test_obj_get_nullable_long_settable_attribute):
(webkit_dom_test_obj_set_nullable_long_settable_attribute):
(webkit_dom_test_obj_get_nullable_string_value):
(webkit_dom_test_obj_set_nullable_string_value):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjNullableDoubleAttribute):
(WebCore::jsTestObjNullableLongAttribute):
(WebCore::jsTestObjNullableBooleanAttribute):
(WebCore::jsTestObjNullableStringAttribute):
(WebCore::jsTestObjNullableLongSettableAttribute):
(WebCore::jsTestObjNullableStringValue):
(WebCore::setJSTestObjNullableLongSettableAttribute):
(WebCore::setJSTestObjNullableStringValue):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj nullableDoubleAttribute]):
(-[DOMTestObj nullableLongAttribute]):
(-[DOMTestObj nullableBooleanAttribute]):
(-[DOMTestObj nullableStringAttribute]):
(-[DOMTestObj nullableLongSettableAttribute]):
(-[DOMTestObj setNullableLongSettableAttribute:]):
(-[DOMTestObj nullableStringValue]):
(-[DOMTestObj setNullableStringValue:]):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::nullableDoubleAttributeAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::nullableDoubleAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableLongAttributeAttrGetter):
(WebCore::TestObjV8Internal::nullableLongAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableBooleanAttributeAttrGetter):
(WebCore::TestObjV8Internal::nullableBooleanAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableStringAttributeAttrGetter):
(WebCore::TestObjV8Internal::nullableStringAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableLongSettableAttributeAttrGetter):
(WebCore::TestObjV8Internal::nullableLongSettableAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableLongSettableAttributeAttrSetter):
(WebCore::TestObjV8Internal::nullableLongSettableAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::nullableStringValueAttrGetter):
(WebCore::TestObjV8Internal::nullableStringValueAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableStringValueAttrSetter):
(WebCore::TestObjV8Internal::nullableStringValueAttrSetterCallback):
(WebCore):

8:37 AM Changeset in webkit [145906] by commit-queue@webkit.org
  • 64 edits in trunk/Source

[V8] Store main world and non-main world templates separately.
https://bugs.webkit.org/show_bug.cgi?id=111724

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-15
Reviewed by Jochen Eisinger.

This is needed for generating specialized bindings for the main
world (bug 110874).

Source/WebCore:

No new tests (updated existing bindings tests).

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
(GenerateImplementation):
(JSValueToNative):
(CreateCustomSignature):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooMethod):
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):
(WebCore):
(WebCore::V8Float64Array::HasInstanceInAnyWorld):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionMethod):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):
(WebCore):
(WebCore::V8TestActiveDOMObject::HasInstanceInAnyWorld):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):
(WebCore):
(WebCore::V8TestCustomNamedGetter::HasInstanceInAnyWorld):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):
(WebCore):
(WebCore::V8TestEventConstructor::HasInstanceInAnyWorld):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::dispatchEventMethod):
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):
(WebCore):
(WebCore::V8TestEventTarget::HasInstanceInAnyWorld):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):
(WebCore):
(WebCore::V8TestException::HasInstanceInAnyWorld):

  • bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Method):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):
(WebCore):
(WebCore::V8TestInterface::HasInstanceInAnyWorld):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):
(WebCore):
(WebCore::V8TestMediaQueryListListener::HasInstanceInAnyWorld):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):
(WebCore):
(WebCore::V8TestNamedConstructor::HasInstanceInAnyWorld):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):
(WebCore):
(WebCore::V8TestNode::HasInstanceInAnyWorld):

  • bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsMethod):
(WebCore::TestObjV8Internal::longMethodWithArgsMethod):
(WebCore::TestObjV8Internal::objMethodWithArgsMethod):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsMethod):
(WebCore::TestObjV8Internal::overloadedMethod1Method):
(WebCore::TestObjV8Internal::overloadedMethod2Method):
(WebCore::TestObjV8Internal::overloadedMethod8Method):
(WebCore::TestObjV8Internal::overloadedMethodMethod):
(WebCore::TestObjV8Internal::convert1Method):
(WebCore::TestObjV8Internal::convert2Method):
(WebCore::TestObjV8Internal::convert4Method):
(WebCore::TestObjV8Internal::convert5Method):
(WebCore::TestObjV8Internal::variadicNodeMethodMethod):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):
(WebCore):
(WebCore::V8TestObj::HasInstanceInAnyWorld):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::TestOverloadedConstructorsV8Internal::constructor1):
(WebCore::TestOverloadedConstructorsV8Internal::constructor2):
(WebCore::TestOverloadedConstructorsV8Internal::constructor3):
(WebCore::TestOverloadedConstructorsV8Internal::constructor):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):
(WebCore):
(WebCore::V8TestOverloadedConstructors::HasInstanceInAnyWorld):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):
(WebCore):
(WebCore::V8TestSerializedScriptValueInterface::HasInstanceInAnyWorld):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

  • bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::funcMethod):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):
(WebCore):
(WebCore::V8TestTypedefs::HasInstanceInAnyWorld):

  • bindings/scripts/test/V8/V8TestTypedefs.h:

(V8TestTypedefs):

  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::visitNodeWrappers):

  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/V8AdaptorFunction.cpp:

(WebCore::V8AdaptorFunction::getTemplate):

  • bindings/v8/V8Binding.cpp:

(WebCore::toDOMStringList):
(WebCore::toXPathNSResolver):

  • bindings/v8/V8Binding.h:

(WebCore):
(WebCore::toRefPtrNativeArray):

  • bindings/v8/V8Collection.cpp:

(WebCore::toOptionsCollectionSetter):

  • bindings/v8/V8GCController.cpp:
  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):
(WebCore::V8PerIsolateData::hasPrivateTemplate):
(WebCore::V8PerIsolateData::privateTemplate):
(WebCore::V8PerIsolateData::rawTemplate):
(WebCore::V8PerIsolateData::hasInstance):

  • bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::rawTemplateMap):
(V8PerIsolateData):
(WebCore::V8PerIsolateData::templateMap):

  • bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):

  • bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAttrSetterCustom):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCustom):

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toCanvasStyle):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::setDragImageMethodCustom):

  • bindings/v8/custom/V8CryptoCustom.cpp:

(WebCore::V8Crypto::getRandomValuesMethodCustom):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCustom):
(WebCore::V8DOMFormData::appendMethodCustom):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCustom):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateMethodCustom):

  • bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAttrSetterCustom):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::addMethodCustom):

  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::removeElement):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::isHTMLAllCollectionMethodCustom):
(WebCore::V8InjectedScriptHost::typeMethodCustom):
(WebCore::V8InjectedScriptHost::getEventListenersMethodCustom):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::removeChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::opaqueRootForGC):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toWebGLUniformLocation):
(WebCore::V8WebGLRenderingContext::getAttachedShadersMethodCustom):
(WebCore::V8WebGLRenderingContext::getProgramParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getShaderParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getUniformMethodCustom):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::isDocumentType):
(WebCore::V8XMLHttpRequest::sendMethodCustom):

Source/WebKit/chromium:

  • src/WebArrayBuffer.cpp:

(WebKit::WebArrayBuffer::createFromV8Value):

  • src/WebArrayBufferView.cpp:

(WebKit::WebArrayBufferView::createFromV8Value):

  • src/WebBindings.cpp:

(WebKit::getRangeImpl):
(WebKit::getNodeImpl):
(WebKit::getElementImpl):
(WebKit::getArrayBufferImpl):
(WebKit::getArrayBufferViewImpl):

7:14 AM Changeset in webkit [145905] by commit-queue@webkit.org
  • 64 edits in trunk/Source

Unreviewed, rolling out r145802.
http://trac.webkit.org/changeset/145802
https://bugs.webkit.org/show_bug.cgi?id=112444

This broke Chrome. (Requested by marja on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-15

Source/WebCore:

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
(GenerateImplementation):
(JSValueToNative):
(CreateCustomSignature):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooMethod):
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionMethod):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::dispatchEventMethod):
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):

  • bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Method):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):

  • bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsMethod):
(WebCore::TestObjV8Internal::longMethodWithArgsMethod):
(WebCore::TestObjV8Internal::objMethodWithArgsMethod):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsMethod):
(WebCore::TestObjV8Internal::overloadedMethod1Method):
(WebCore::TestObjV8Internal::overloadedMethod2Method):
(WebCore::TestObjV8Internal::overloadedMethod8Method):
(WebCore::TestObjV8Internal::overloadedMethodMethod):
(WebCore::TestObjV8Internal::convert1Method):
(WebCore::TestObjV8Internal::convert2Method):
(WebCore::TestObjV8Internal::convert4Method):
(WebCore::TestObjV8Internal::convert5Method):
(WebCore::TestObjV8Internal::variadicNodeMethodMethod):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::TestOverloadedConstructorsV8Internal::constructor1):
(WebCore::TestOverloadedConstructorsV8Internal::constructor2):
(WebCore::TestOverloadedConstructorsV8Internal::constructor3):
(WebCore::TestOverloadedConstructorsV8Internal::constructor):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

  • bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::funcMethod):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):

  • bindings/scripts/test/V8/V8TestTypedefs.h:

(V8TestTypedefs):

  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::visitNodeWrappers):

  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/V8AdaptorFunction.cpp:

(WebCore::V8AdaptorFunction::getTemplate):

  • bindings/v8/V8Binding.cpp:

(WebCore::toDOMStringList):
(WebCore::toXPathNSResolver):

  • bindings/v8/V8Binding.h:

(WebCore::toRefPtrNativeArray):
(WebCore):

  • bindings/v8/V8Collection.cpp:

(WebCore::toOptionsCollectionSetter):

  • bindings/v8/V8GCController.cpp:
  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):
(WebCore::V8PerIsolateData::hasPrivateTemplate):
(WebCore::V8PerIsolateData::privateTemplate):
(WebCore::V8PerIsolateData::rawTemplate):
(WebCore::V8PerIsolateData::hasInstance):

  • bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::rawTemplateMap):
(WebCore::V8PerIsolateData::templateMap):
(V8PerIsolateData):

  • bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):

  • bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAttrSetterCustom):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCustom):

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toCanvasStyle):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::setDragImageMethodCustom):

  • bindings/v8/custom/V8CryptoCustom.cpp:

(WebCore::V8Crypto::getRandomValuesMethodCustom):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCustom):
(WebCore::V8DOMFormData::appendMethodCustom):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCustom):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateMethodCustom):

  • bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAttrSetterCustom):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::addMethodCustom):

  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::removeElement):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::isHTMLAllCollectionMethodCustom):
(WebCore::V8InjectedScriptHost::typeMethodCustom):
(WebCore::V8InjectedScriptHost::getEventListenersMethodCustom):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::removeChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::opaqueRootForGC):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toWebGLUniformLocation):
(WebCore::V8WebGLRenderingContext::getAttachedShadersMethodCustom):
(WebCore::V8WebGLRenderingContext::getProgramParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getShaderParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getUniformMethodCustom):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::isDocumentType):
(WebCore::V8XMLHttpRequest::sendMethodCustom):

Source/WebKit/chromium:

  • src/WebArrayBuffer.cpp:

(WebKit::WebArrayBuffer::createFromV8Value):

  • src/WebArrayBufferView.cpp:

(WebKit::WebArrayBufferView::createFromV8Value):

  • src/WebBindings.cpp:

(WebKit::getRangeImpl):
(WebKit::getNodeImpl):
(WebKit::getElementImpl):
(WebKit::getArrayBufferImpl):
(WebKit::getArrayBufferViewImpl):

7:05 AM Changeset in webkit [145904] by commit-queue@webkit.org
  • 38 edits in trunk/Source/WebCore

Unreviewed, rolling out r145896.
http://trac.webkit.org/changeset/145896
https://bugs.webkit.org/show_bug.cgi?id=112443

Chrome broken by r145802 and this builds on top of it.
(Requested by marja on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-15

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetterCallback):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetterCallback):
(GenerateNormalAttrSetter):
(GenerateNamedConstructor):
(GenerateBatchedAttributeData):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(GenerateCallbackImplementation):
(GenerateFunctionCallString):
(CreateCustomSignature):
(NativeToJSValue):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):

  • bindings/scripts/test/V8/V8Float64Array.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):
(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):

  • bindings/scripts/test/V8/V8TestException.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(TestInterfaceV8Internal):
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
(WebCore::ConfigureV8TestNamedConstructorTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::ConfigureV8TestNodeTemplate):
(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):

  • bindings/scripts/test/V8/V8TestNode.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(TestObjV8Internal):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):

  • bindings/scripts/test/V8/V8TestTypedefs.h:

(WebCore):

  • bindings/v8/DOMDataStore.h:

(DOMDataStore):

  • bindings/v8/V8DOMConfiguration.cpp:
  • bindings/v8/V8DOMConfiguration.h:

(V8DOMConfiguration):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • bindings/v8/custom/V8EventTargetCustom.cpp:
  • bindings/v8/custom/V8IDBAnyCustom.cpp:
  • bindings/v8/custom/V8MicroDataItemValueCustom.cpp:
  • bindings/v8/custom/V8WorkerContextCustom.cpp:
6:52 AM Changeset in webkit [145903] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk/Source/WebCore

[BlackBerry] Remove PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=112438

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-15
Reviewed by Rob Buis.

This class only contains getFontFamilyForCharacters(), which was
moved from PlatformSupport to FontCache in r129257.

This patch does the same for the BlackBerry port.

  • platform/graphics/FontCache.h:

(FontCache):

  • platform/graphics/blackberry/FontCacheBlackBerry.cpp:

(WebCore::FontCache::getFontFamilyForCharacters):
(WebCore):
(WebCore::FontCache::getFontDataForCharacters):

  • platform/graphics/blackberry/PlatformSupport.cpp: Removed.
  • platform/graphics/blackberry/PlatformSupport.h: Removed.
6:50 AM Changeset in webkit [145902] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] FontPlatformData: remove TextOrientation parameter
https://bugs.webkit.org/show_bug.cgi?id=112135

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-15
Reviewed by Rob Buis.

I forgot to remove the #include "TextOrientation.h" line as
well. This file no longer exists.

  • platform/graphics/blackberry/FontCustomPlatformData.h:
6:35 AM Changeset in webkit [145901] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

DataGrid should reveal and select next/previous DataGridNode upon deletion of selected node
https://bugs.webkit.org/show_bug.cgi?id=112404

Patch by Sankeerth V S <sankeerth.vs@samsung.com> on 2013-03-15
Reviewed by Vsevolod Vlasov.

No new tests as this is a UI related change.

While deleting the entries of the data grid by clicking on 'Delete'
status bar button, deletion of selected node should trigger selection of
next possible (backward/forward) DataGridNode.

  • inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._keyDown):
(WebInspector.DataGrid.prototype.changeNodeAfterDeletion):

6:29 AM Changeset in webkit [145900] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Draw timeline grid over flame chart items.
https://bugs.webkit.org/show_bug.cgi?id=112439

Reviewed by Pavel Feldman.

I've used WebInspector.TimelineGrid

  • inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.Calculator):
(WebInspector.FlameChart.Calculator.prototype._updateBoundaries):
(WebInspector.FlameChart.Calculator.prototype.computePosition):
(WebInspector.FlameChart.Calculator.prototype.formatTime):
(WebInspector.FlameChart.Calculator.prototype.maximumBoundary):
(WebInspector.FlameChart.Calculator.prototype.minimumBoundary):
(WebInspector.FlameChart.Calculator.prototype.boundarySpan):
(WebInspector.FlameChart.prototype.update):

5:48 AM Changeset in webkit [145899] by allan.jensen@digia.com
  • 4 edits in trunk

[Qt] Build error with building with Qt 5.1
https://bugs.webkit.org/show_bug.cgi?id=112435

Reviewed by Noam Rosenthal.

QAccessibleWidget has moved to private.

.:

  • Source/widgetsapi.pri:

Source/WebKit/qt:

  • WidgetApi/qwebviewaccessible_p.h:
5:32 AM Changeset in webkit [145898] by jknotten@chromium.org
  • 5 edits in trunk/Source/WebKit/chromium

[Chromium] Compositor is applying scroll offset using 'programmatic' API
https://bugs.webkit.org/show_bug.cgi?id=109712

Reviewed by James Robinson.

Ensure that the compositor uses non-programmatic APIs to scroll and
scale.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::updateMainFrameScrollPosition):
(WebKit):
(WebKit::WebViewImpl::applyScrollAndScale):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/WebFrameTest.cpp:
  • tests/WebViewTest.cpp:
5:21 AM Changeset in webkit [145897] by caseq@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed -- remove test expectations for timeline-receive-response-event and remove
another source of flakiness in the test.

  • inspector/timeline/timeline-receive-response-event.html:
  • platform/chromium/TestExpectations:
4:45 AM WebKitGTK/2.0.x edited by Philippe Normand
(diff)
4:14 AM Changeset in webkit [145896] by commit-queue@webkit.org
  • 38 edits in trunk/Source/WebCore

[V8] Add machinery for generating specialized bindings for the main world
https://bugs.webkit.org/show_bug.cgi?id=111417

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-15
Reviewed by Kentaro Hara.

The new specialized bindings will be faster, because they don't need to
do the "main world, isolated world or a worker" check, but can right
away assume that we're in the main world.

This patch generates main world bindings for getters and setters.

No new tests (updated existing bindings tests).

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetterCallback):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetterCallback):
(GenerateNormalAttrSetter):
(GenerateNamedConstructor):
(GenerateBatchedAttributeData):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(GenerateCallbackImplementation):
(GenerateFunctionCallString):
(CreateCustomSignature):
(NativeToJSValue):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):

  • bindings/scripts/test/V8/V8Float64Array.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingAttrAttrGetterForMainWorld):
(TestActiveDOMObjectV8Internal):
(WebCore::TestActiveDOMObjectV8Internal::excitingAttrAttrGetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::TestEventConstructorV8Internal::attr1AttrGetterForMainWorld):
(TestEventConstructorV8Internal):
(WebCore::TestEventConstructorV8Internal::attr1AttrGetterCallbackForMainWorld):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetterForMainWorld):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::TestExceptionV8Internal::nameAttrGetterForMainWorld):
(TestExceptionV8Internal):
(WebCore::TestExceptionV8Internal::nameAttrGetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):

  • bindings/scripts/test/V8/V8TestException.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStaticReadOnlyAttrAttrGetterForMainWorld):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStaticReadOnlyAttrAttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrSetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrSetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
(WebCore::ConfigureV8TestNamedConstructorTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::ConfigureV8TestNodeTemplate):
(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):

  • bindings/scripts/test/V8/V8TestNode.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyLongAttrAttrGetterForMainWorld):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::readOnlyLongAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::staticReadOnlyLongAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::staticReadOnlyLongAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::staticStringAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::staticStringAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enumAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::enumAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enumAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::enumAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::shortAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::shortAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::shortAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::shortAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::longAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::longAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::longAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::longAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::longLongAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::longLongAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::longLongAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::longLongAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::testObjAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::testObjAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::testObjAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::testObjAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::createAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::createAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::createAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::createAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::customAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::customAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr1AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr1AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr1AttrSetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr1AttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr2AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr2AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr2AttrSetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr2AttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr3AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr3AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr3AttrSetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr3AttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::anyAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::anyAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::anyAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::anyAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrSetterForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrSetterForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::floatArrayAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::floatArrayAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::floatArrayAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::floatArrayAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::doubleArrayAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::doubleArrayAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::doubleArrayAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::doubleArrayAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::contentDocumentAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::contentDocumentAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::mutablePointAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::mutablePointAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::mutablePointAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::mutablePointAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::immutablePointAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::immutablePointAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::immutablePointAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::immutablePointAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::strawberryAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::strawberryAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::strawberryAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::strawberryAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::strictFloatAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::strictFloatAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::strictFloatAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::strictFloatAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::descriptionAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::descriptionAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::idAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::idAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::idAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::idAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::hashAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::hashAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::replaceableAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::replaceableAttributeAttrGetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrGetterForMainWorld):
(TestSerializedScriptValueInterfaceV8Internal):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrGetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrSetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrSetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::readonlyValueAttrGetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::readonlyValueAttrGetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::portsAttrGetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::portsAttrGetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

  • bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrGetterForMainWorld):
(TestTypedefsV8Internal):
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrSetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrGetterForMainWorld):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrSetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrGetterForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrGetterForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrGetterForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrGetterForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrSetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):

  • bindings/scripts/test/V8/V8TestTypedefs.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::getWrapperForMainWorld):
(DOMDataStore):

  • bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::addToTemplate):
(WebCore):

  • bindings/v8/V8DOMConfiguration.h:

(V8DOMConfiguration):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::toV8ForMainWorld):
(WebCore):

  • bindings/v8/custom/V8EventTargetCustom.cpp:

(WebCore::toV8ForMainWorld):
(WebCore):

  • bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8ForMainWorld):
(WebCore):

  • bindings/v8/custom/V8MicroDataItemValueCustom.cpp:

(WebCore::toV8ForMainWorld):
(WebCore):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::toV8ForMainWorld):
(WebCore):

4:07 AM Changeset in webkit [145895] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Unreviewed trivial DRT ASSERT fix

r145805 erroneously added setController calls for device orientation/motion
mock clients. Those ASSERT, the controller ctor already calls setController
on the client.

  • WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::initializeWebCorePage):

3:46 AM Changeset in webkit [145894] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. xOffset calculates incorrectly when chart width less that canvas.width.
https://bugs.webkit.org/show_bug.cgi?id=112423

Reviewed by Yury Semikhatsky.

I extracted xOffset assigment procedure into a separate function.

Drive by fix: size and posion of anchor element was adjusted.
Drive by fix: we will not paint item if it is not visible.

  • inspector/front-end/FlameChart.js:

(WebInspector.FlameChart.prototype._maxXOffset):
(WebInspector.FlameChart.prototype._setXOffset):
(WebInspector.FlameChart.prototype._canvasDragging):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype._adjustXOffset):
(WebInspector.FlameChart.prototype._adjustXScale):
(WebInspector.FlameChart.prototype.draw):

3:40 AM Changeset in webkit [145893] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Texmap] Change brightness filter to match new spec
https://bugs.webkit.org/show_bug.cgi?id=112422

New filters spec specifies an intercept of 0 instead of 1.
This is already done for the software version in http://trac.webkit.org/changeset/139770.
This patch adjusts the value for the accelerated version.

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-03-15
Reviewed by Allan Sandfeld Jensen.

Filter tests are currently disabled on Qt/GTK/EFL, but they would need to be rebaselined once enabled.

  • platform/graphics/texmap/TextureMapperShaderProgram.cpp:
3:22 AM Changeset in webkit [145892] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Call release() when a RefPtr is returned.
https://bugs.webkit.org/show_bug.cgi?id=112420

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-03-15
Reviewed by Eric Seidel.

release() should be called on a RefPtr to convert it to a PassRefPtr.

No new tests needed, no behavior changes.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseImageResolution):
(WebCore::CSSParser::parseImageSet):

3:18 AM Changeset in webkit [145891] by eustas@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Network] InitiatorComparator is not reflexive/antisymmetric.
https://bugs.webkit.org/show_bug.cgi?id=112341

Reviewed by Vsevolod Vlasov.

When both objects do not have initiator: f(a, b) = f(b, a) = -1
Furthermore: redirected responses are mixed with "other".

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
Remember "displayed" initiator type.
(WebInspector.NetworkDataGridNode.InitiatorComparator):
Recall "diaplayed" initiator type for more precise comparison.

3:17 AM Changeset in webkit [145890] by zeno.albisser@digia.com
  • 4 edits in trunk/Tools

[Qt] Remove simple getters and setters from TestRunnerQt
https://bugs.webkit.org/show_bug.cgi?id=112343

Reviewed by Benjamin Poulain.

The removed functions and boolean members
are being replaced by the implementations in the
generic TestRunner.h.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(DumpRenderTree::dumpFrameScrollPosition):
(DumpRenderTree::dumpFramesAsText):
(DumpRenderTree::dump):
(DumpRenderTree::titleChanged):
(DumpRenderTree::dumpDatabaseQuota):
(DumpRenderTree::dumpApplicationCacheQuota):
(DumpRenderTree::statusBarMessage):
(DumpRenderTree::createWindow):

  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunnerQt::reset):

  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

3:08 AM Changeset in webkit [145889] by caseq@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: show image decode performed off main thread on timeline
https://bugs.webkit.org/show_bug.cgi?id=111159

Reviewed by Pavel Feldman.

  • add handling of Decode Image event to TimelineTraceEventProcessorr;
  • only log platform events for the main thread;
  • extract constants for trace events produced by platform instrumentation.
  • inspector/InspectorTimelineAgent.cpp:

(TimelineRecordType):

  • inspector/InspectorTimelineAgent.h:

(TimelineRecordType):

  • inspector/TimelineTraceEventProcessor.cpp:

(WebCore::TimelineTraceEventProcessor::TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::onImageDecodeBegin):
(WebCore):
(WebCore::TimelineTraceEventProcessor::onImageDecodeEnd):

  • inspector/TimelineTraceEventProcessor.h:

(TimelineTraceEventProcessor):

  • platform/PlatformInstrumentation.cpp:

(WebCore):

  • platform/PlatformInstrumentation.h:

(PlatformInstrumentation):
(WebCore):
(WebCore::PlatformInstrumentation::willDecodeImage):
(WebCore::PlatformInstrumentation::didDecodeImage):
(WebCore::PlatformInstrumentation::willResizeImage):
(WebCore::PlatformInstrumentation::didResizeImage):

1:38 AM Changeset in webkit [145888] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. When user zooms the chart, the point under cursor has to be the zooming center.
https://bugs.webkit.org/show_bug.cgi?id=112417

Reviewed by Yury Semikhatsky.

It converts the cursor position into time,
changes the scale factor and calculates the new offset for the canvas.

  • inspector/front-end/FlameChart.js:

(WebInspector.FlameChart.prototype._adjustXScale):
(WebInspector.FlameChart.prototype._onMouseWheel):

1:33 AM Changeset in webkit [145887] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding a failure expectation for the reftest added in r145847

that is failing due to disabled subpixel layout on the GTK port.

1:28 AM Changeset in webkit [145886] by eustas@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Network] Sort columns context menu items alphabetically.
https://bugs.webkit.org/show_bug.cgi?id=112321

Reviewed by Pavel Feldman.

Problem: columns are presented in "natural" order,
so it is hard to find specific item.

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._getConfigurableColumnIDs):
Generate list of column IDs sorted alphabetically.
(WebInspector.NetworkLogView.prototype._contextMenu):
Use alphabetically sorted list of column IDs.

1:24 AM Changeset in webkit [145885] by tasak@google.com
  • 4 edits
    2 adds in trunk

Crash at RenderStyle::inheritFrom reported by fuzzer
https://bugs.webkit.org/show_bug.cgi?id=112322

Reviewed by Hajime Morrita.

Source/WebCore:

pseudoStyleForElement should check whether a parent style of a given
element is available or not. If a given element's parent is
an insertion point whose reset-style-inheritance is true, the parent
style is not available. Need to use defaultStyleForElement.

Test: fast/dom/shadow/insertion-point-resetStyleInheritance-with-pseudo-element-crash.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForElement):
Removed cloneForParent. Instead, made m_state own parentStyle, i.e.
changed m_parentStyle in class State from RenderStyle* to
RefPtr<RenderStyle>.
(WebCore::StyleResolver::pseudoStyleForElement):
If an actual parent style of a given element is not available, use
defaultStyleForElement. This is the same logic as styleForElement.

  • css/StyleResolver.h:

(WebCore::StyleResolver::State::setParentStyle):
Modified the parameter to use PassRefPtr<RenderStyle>.
(WebCore::StyleResolver::State::parentStyle):
(State):

LayoutTests:

  • fast/dom/shadow/insertion-point-resetStyleInheritance-with-pseudo-element-crash-expected.txt: Added.
  • fast/dom/shadow/insertion-point-resetStyleInheritance-with-pseudo-element-crash.html: Added.
1:08 AM Changeset in webkit [145884] by mihnea@adobe.com
  • 3 edits
    2 adds in trunk

[CSS Regions] Selecting text inside an empty region causes selection outside the region area
https://bugs.webkit.org/show_bug.cgi?id=107752

Reviewed by David Hyatt.

Source/WebCore:

When performing hit testing inside a flow thread, we need to make sure that
we actually hit some node from the flow thread content and not the flow thread
itself (which would set the hit test result node to the document node, allowing
wrong selection of content outside the empty region).

Test: fast/regions/selecting-text-in-empty-region.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):

LayoutTests:

Add test showing that you cannot select content outside a empty region (without flow thread content).

  • fast/regions/selecting-text-in-empty-region-expected.txt: Added.
  • fast/regions/selecting-text-in-empty-region.html: Added.
1:06 AM Changeset in webkit [145883] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Texmap] layerRect should be used instead of contents rect for scrollable layer hit tests.
https://bugs.webkit.org/show_bug.cgi?id=112413

Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2013-03-15
Reviewed by Noam Rosenthal.

Using layerRect() instead of m_state.contentsRect for scrollable layer hit test.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::scrollableLayerHitTestCondition):

1:04 AM Changeset in webkit [145882] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Update the link on build.webkit.org to refer to perf.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=112416

Reviewed by Philip Rogers.

Updated the link. Also updated the template to use HTML5 DOCTYPE.

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
12:13 AM Changeset in webkit [145881] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
https://bugs.webkit.org/show_bug.cgi?id=112394

Patch by Tobias Mueller <tobiasmue@gnome.org> on 2013-03-15
Reviewed by Philippe Normand.

  • GtkLauncher/main.c:

(main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER

12:13 AM Changeset in webkit [145880] by mikhail.pozdnyakov@intel.com
  • 7 edits in trunk/Source/WebKit2

[WK2][EFL] Get rid of WebPageProxy::viewWidget() method
https://bugs.webkit.org/show_bug.cgi?id=112289

Reviewed by Alexey Proskuryakov.

Web page should not be aware of platform-specific view.

  • UIProcess/API/efl/EwkView.cpp:

(wkPageToEvasObjectMap):
(EwkView::EwkView):
(EwkView::~EwkView):
(EwkView::toEvasObject):

EwkView::toEvasObject() relies on static map rather than on
removed WebPageProxy::viewWidget() method.

  • UIProcess/API/efl/EwkView.h:
  • UIProcess/API/efl/ewk_text_checker.cpp:

(uniqueSpellDocumentTag):

  • UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::incorporateUpdate):

Now uses EwkView::toEvasObject().

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/efl/WebPageProxyEfl.cpp:

Removed WebPageProxy::viewWidget() method.

Mar 14, 2013:

11:28 PM Changeset in webkit [145879] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

11:26 PM Changeset in webkit [145878] by Lucas Forschler
  • 1 copy in tags/Safari-537.34

New Tag.

11:22 PM Changeset in webkit [145877] by dominicc@chromium.org
  • 2 edits in trunk/Source/WebCore

Redundant if statement in RenderTextControlSingleLine::layout should be removed
https://bugs.webkit.org/show_bug.cgi?id=112406

Reviewed by Andreas Kling.

Covered by existing tests added in r145239.

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):

11:01 PM Changeset in webkit [145876] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r145864.
http://trac.webkit.org/changeset/145864
https://bugs.webkit.org/show_bug.cgi?id=112408

should fix XMLDocumentParser instead of CSSDefaultStyleSheet
(Requested by tasak on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-14

Source/WebCore:

  • css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

LayoutTests:

  • fast/css/ensure-default-style-sheets-crash-expected.txt: Removed.
  • fast/css/ensure-default-style-sheets-crash.xhtml: Removed.
10:29 PM Changeset in webkit [145875] by eustas@chromium.org
  • 16 edits in trunk/Source/WebCore

Web Inspector: [DataGrid] Specify columns with array of descriptors.
https://bugs.webkit.org/show_bug.cgi?id=112338

Reviewed by Pavel Feldman.

Currently columns are specified by Object that maps
column identifiers to column descriptors. Iteration order over
Object keys is not guaranteed.

Array should be used to specify column order.

  • inspector/front-end/DataGrid.js: Change consrtructor parameter type.
  • inspector/front-end/ApplicationCacheItemsView.js: Adopt changes.
  • inspector/front-end/CPUProfileView.js: Ditto.
  • inspector/front-end/CSSSelectorProfileView.js: Ditto.
  • inspector/front-end/CanvasProfileView.js: Ditto.
  • inspector/front-end/CookieItemsView.js: Ditto.
  • inspector/front-end/CookiesTable.js: Ditto.
  • inspector/front-end/DOMStorageItemsView.js: Ditto.
  • inspector/front-end/DirectoryContentView.js: Ditto.
  • inspector/front-end/HeapSnapshot.js: Ditto.
  • inspector/front-end/HeapSnapshotDataGrids.js: Ditto.
  • inspector/front-end/IndexedDBViews.js: Ditto.
  • inspector/front-end/NativeMemorySnapshotView.js: Ditto.
  • inspector/front-end/NetworkPanel.js: Ditto.
  • inspector/front-end/ResourceWebSocketFrameView.js: Ditto.
10:26 PM Changeset in webkit [145874] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Support scrolling by dragging.
https://bugs.webkit.org/show_bug.cgi?id=112346

Reviewed by Yury Semikhatsky.

Drag hander was added. It seems that simple repaint works well.
When the user starts dragging we hide the popover, change offset
and do update for the new canvas image.
Drive by change: Due to new way of scrolling the canvas I changed
the behaiviour of the wheel events. Now wheel scrolls if Shift key pressed
and zooms if not.

  • inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._startCanvasDragging):
(WebInspector.FlameChart.prototype._canvasDragging):
(WebInspector.FlameChart.prototype._endCanvasDragging):
(WebInspector.FlameChart.prototype._onMouseWheel):

10:14 PM Changeset in webkit [145873] by hayato@chromium.org
  • 12 edits in trunk

[Shadow Dom]: Non Bubbling events in ShadowDOM dispatch in an incorrect order
https://bugs.webkit.org/show_bug.cgi?id=112214

Reviewed by Dimitri Glazkov.

Source/WebCore:

Fix the order of event dispatching for Shadow DOM.

So far, an event whose event phase should be set to AT_TARGET,
e.g. event at shadow hosts, is dispatched in bubbling phase in the
whole event path. This patch fixed the order of event dispatching
so that an event whose event phase must be set to AT_TARGET phase
is dispatched in capturing phase rather than bubbling phase.

The spec is here:
https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#event-dispatch

5.5 Event Dispatch says:

  • When capturing, which entails processing step 3 of the event

dispatch algorithm, the Event eventPhase attribute must return
AT_TARGET if the relative target is same as the node on which
event listeners are invoked

  • When bubbling, which entails

processing step 6 of the event dispatch algorithm, the event
listeners must not be invoked on a node if it is the same as its
relative target

No new tests. Update existing layout tests.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtBubbling):

LayoutTests:

  • fast/dom/shadow/cppevent-in-shadow-expected.txt:
  • fast/dom/shadow/cppevent-input-in-shadow-expected.txt:
  • fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt:
  • fast/dom/shadow/shadow-boundary-events-expected.txt:
  • fast/dom/shadow/shadow-boundary-events.html:
  • fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt:
  • fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes-expected.txt:
  • fast/dom/shadow/shadow-dom-event-dispatching-non-distributed-nodes-expected.txt:
  • fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt:
9:47 PM Changeset in webkit [145872] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: Chromium TestExpectations cleanup prepared by kbr@

  • platform/chromium/TestExpectations:
9:25 PM Changeset in webkit [145871] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

Backspace/delete at start of table cell shouldn't step out of cell
https://bugs.webkit.org/show_bug.cgi?id=35372

Patch by Shezan Baig <Shezan Baig> on 2013-03-14
Reviewed by Ryosuke Niwa.

Source/WebCore:

Make Delete and ForwardDelete commands be no-ops if we are at the first
position or last position of a table cell respectively.

Tests: editing/deleting/backspace-at-table-cell-beginning.html

editing/deleting/forward-delete-at-table-cell-ending.html

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):

LayoutTests:

  • editing/deleting/backspace-at-table-cell-beginning-expected.txt: Added.
  • editing/deleting/backspace-at-table-cell-beginning.html: Added.
  • editing/deleting/forward-delete-at-table-cell-ending-expected.txt: Added.
  • editing/deleting/forward-delete-at-table-cell-ending.html: Added.
8:37 PM Changeset in webkit [145870] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

Clickable area is incorrect for elements with border-radius
https://bugs.webkit.org/show_bug.cgi?id=95373

Patch by Xidorn Quan <quanxunzhen@gmail.com> on 2013-03-14
Reviewed by Simon Fraser.

Source/WebCore:

As RenderBlock doesn't see rounded rect which comes from border-radius
in nodeAtPoint, the rounded corner seems to have an 'invisible' square
box which catches hits. So we added check on whether hitTestPoint also
intersects the rounded rect when hasBorderRadius is set.

This patch is based on Takashi Sakamoto's work in
https://bugs.webkit.org/show_bug.cgi?id=95373

Test: fast/borders/border-radius-position.html

  • platform/graphics/FloatQuad.cpp:

(WebCore):
(WebCore::lineIntersectsCircle):
(WebCore::FloatQuad::intersectsCircle):
(WebCore::FloatQuad::intersectsEllipse):

  • platform/graphics/FloatQuad.h:

(FloatQuad):

  • platform/graphics/RoundedRect.cpp:

(WebCore::RoundedRect::intersectsQuad):
(WebCore):

  • platform/graphics/RoundedRect.h:

(RoundedRect):

  • rendering/HitTestLocation.cpp:

(WebCore::HitTestLocation::intersects):
(WebCore):

  • rendering/HitTestLocation.h:

(HitTestLocation):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):

LayoutTests:

This test is based on Takashi Sakamoto's work in
https://bugs.webkit.org/show_bug.cgi?id=95373

  • fast/borders/border-radius-position-expected.txt: Added.
  • fast/borders/border-radius-position.html: Added.
8:30 PM Changeset in webkit [145869] by akling@apple.com
  • 12 edits in trunk

REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
<http://webkit.org/b/111815>
<rdar://problem/13380145>

Reviewed by Anders Carlsson.

Source/WebKit2:

Call getWindowFrame() to see if the UI client wants to override the window frame before sending
a WindowAndViewFramesChanged message to the web process.
This fixes a glitch in WTR and the Web Inspector where incorrect window frames were being used.

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::windowAndViewFramesChanged):

Tools:

Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.

  • WebKitTestRunner/PlatformWebView.h:

(PlatformWebView):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::didInitializeClients):

LayoutTests:

  • platform/mac-wk2/TestExpectations:
7:41 PM Changeset in webkit [145868] by commit-queue@webkit.org
  • 8 edits in trunk/LayoutTests

plugins/plugin-clip-subframe.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=112324

Patch by John Bauman <jbauman@chromium.org> on 2013-03-14
Reviewed by Ryosuke Niwa.

Ignore duplicate SetWindow calls with identical arguments. Plugins
will ignore these so they're not a problem, and they can cause
flakiness on mac-wk2.

  • platform/chromium-linux/plugins/plugin-clip-subframe-expected.txt:
  • platform/chromium-mac/plugins/plugin-clip-subframe-expected.txt:
  • platform/chromium-win/plugins/plugin-clip-subframe-expected.txt:
  • platform/mac-wk2/plugins/plugin-clip-subframe-expected.txt:
  • platform/mac/plugins/plugin-clip-subframe-expected.txt:
  • plugins/plugin-clip-subframe-expected.txt:
  • plugins/resources/plugin-clip-subframe-iframe.html:
7:18 PM Changeset in webkit [145867] by dominicc@chromium.org
  • 1 edit
    6 copies in branches/chromium/1410

[Chromium] Unreviewed, merge r145239.

7:08 PM Changeset in webkit [145866] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: Crash when removing aria-menu item from DOM
https://bugs.webkit.org/show_bug.cgi?id=112396

Reviewed by Tim Horton.

Source/WebCore:

Prevent nil access to items in the ARIA menu flow when deleting
objects from the DOM.

Test: accessibility/menu-item-crash.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::siblingWithAriaRole):
(WebCore::AccessibilityNodeObject::menuButtonForMenu):

LayoutTests:

  • accessibility/menu-item-crash-expected.txt: Added.
  • accessibility/menu-item-crash.html: Added.
7:02 PM Changeset in webkit [145865] by hayato@chromium.org
  • 6 edits
    2 adds in trunk

[Shadow]: left side of ::-webkit-distributed selector not working as expected
https://bugs.webkit.org/show_bug.cgi?id=110825

Reviewed by Dimitri Glazkov.

Source/WebCore:

Make functional pseudo distributed elements work even when a left side element has specifiers.

Test: fast/dom/shadow/distributed-pseudo-element-specifiers-in-left-side.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::rewriteSpecifiersWithNamespaceIfNeeded):
Make it call rewriteSpecifiersForShadowDistributed() if required.

(WebCore::CSSParser::rewriteSpecifiersWithElementName):
Updated so that it can generate a correct chain of
CSSParserSelectors even when '::distributed()' is used with an
element, which might be empty, with specifiers.

e.g. When parsing a selector of 'content.content-class::-webkit-distributed(div)', the following happens:

  1. rewriteSpecifiersWithElementName(...) is called with:

elementName is: "content"
specifiers is: [.content-class] -> [::-webkit-distributed]

  1. Looking for a distributed pseudo element in the specifiers and found it at the end of tagHistory chain of the specifiers.
  1. The result of calling specifiers->prependTagSelector(tag) is:

specifiers is: [content] -> [.content-class] -> [::-webkit-distributed]

  1. rewriteSpecifiersForShadowDistributed() is called with:

specifiers is: [content] -> [.content-class] -> [::-webkit-distributed]
distributedPseudoElementSelector is: [::-webkit-distributed]

  1. An argumentSelector of the distributedPseudoElementSelector is:

argumentSelector is: [div]

  1. Remove the distributed pseudo element selector from the specifiers.

specifiers is: [content] -> [.content-class]

Note that one pseudo-element may appear per complex selector
and the pseudo-element may appear only if the subject of the
selector is the last compound selector in the selector.

  1. Append specifiers to the end of the argument selector with a relation of ShadowDistributed:

argumentSelector is: [div] -(ShadowDistributed)-> [content] -> [.content-class]

  1. Returns the argument selector as a return value.

(WebCore::CSSParser::rewriteSpecifiersForShadowDistributed): As explained.

  • css/CSSParserValues.cpp:

(WebCore):
(WebCore::CSSParserSelector::findDistributedPseudoElementSelector):

  • css/CSSParserValues.h:

(CSSParserSelector):
(WebCore::CSSParserSelector::clearTagHistory):

LayoutTests:

  • fast/dom/shadow/distributed-pseudo-element-specifiers-in-left-side-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-specifiers-in-left-side.html: Added.
6:50 PM Changeset in webkit [145864] by tasak@google.com
  • 3 edits
    2 adds in trunk

Crash at CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement reported by fuzzer
https://bugs.webkit.org/show_bug.cgi?id=112328

Reviewed by Dimitri Glazkov.

Source/WebCore:

ensureDefaultStyleSheets should check whether page() is null or not.

Test: fast/css/ensure-default-style-sheets-crash.xhtml

  • css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

LayoutTests:

  • fast/css/ensure-default-style-sheets-crash-expected.txt: Added.
  • fast/css/ensure-default-style-sheets-crash.xhtml: Added.
5:52 PM Changeset in webkit [145863] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][MiniBrowser] Add a search field to the MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=112122

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-03-14
Reviewed by Kenneth Rohde Christiansen.

Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.

  • MiniBrowser/efl/main.c:

(_Browser_Window):
(search_box_show):
(search_box_hide):
(on_key_down):
(on_url_changed):
(on_search_field_aborted):
(on_search_field_activated):
(on_search_field_clicked):
(on_search_backward_button_clicked):
(on_search_forward_button_clicked):
(window_create):

5:51 PM Changeset in webkit [145862] by kbr@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed test expectations update. Expanded suppression.

  • platform/chromium/TestExpectations:
5:48 PM Changeset in webkit [145861] by jparent@chromium.org
  • 8 edits in trunk/Tools

Cleanup: Remove g_resourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=112305

Reviewed by Dirk Pranke.

Removing another global.

Now, each dashboard creates its own loader, rather than having
a general global one.

Remove usage of g_resourceLoader.isLoadingComplete from
handleLocationChange by ensuring that handleLocationChange is
never called before the loader is done. It was called in two
places before: 1 was from the callback when the loader is done,
so that was obviously true, and the other was from onhashchange,
where it would just return rather than running. Instead, lets
only register the onhashchange handler once the loader is
setup, so the check is no longer necessary.

Remove isLoadingComplete since it is now unused.

Callback for loader is now initializeHistory, rather than just
handleLocationChange which will set up the hashchange handler now.
This will all eventually be moving to a new History object.

  • TestResultServer/static-dashboards/aggregate_results.html:
  • TestResultServer/static-dashboards/dashboard_base.js:

(handleLocationChange):
(intializeHistory):
(decompressResults):

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(generatePage):

  • TestResultServer/static-dashboards/loader.js:

(.):

  • TestResultServer/static-dashboards/loader_unittests.js:
  • TestResultServer/static-dashboards/timeline_explorer.html:
  • TestResultServer/static-dashboards/treemap.html:
5:45 PM Changeset in webkit [145860] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r145000): Crash loading arstechnica.com when Safari Web Inspector is open
https://bugs.webkit.org/show_bug.cgi?id=111868

Reviewed by Antti Koivisto.

Don't allow non-local property lookup when the debugger is enabled.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::resolve):

5:10 PM Changeset in webkit [145859] by commit-queue@webkit.org
  • 4 edits in trunk

Build: Remove XSLT option and depend hard on XSLT.
You will now not be able to give --disable-xslt or --enable-xslt
because it is not optional anymore.
https://bugs.webkit.org/show_bug.cgi?id=112368

Patch by Tobias Mueller <tobiasmue@gnome.org> on 2013-03-14
Reviewed by Martin Robinson.

  • Source/autotools/FindDependencies.m4:

Always check for libxslt

  • Source/autotools/PrintBuildConfiguration.m4:

Removed printing out the value of XSLT

  • Source/autotools/ReadCommandLineArguments.m4:

Removed reading XSLT options

5:07 PM Changeset in webkit [145858] by kbr@google.com
  • 1 edit
    8 adds in trunk/LayoutTests

Unreviewed gardening. Added images for new test.

  • platform/chromium-mac-lion/platform/chromium/scrollbars/short-scrollbar-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/scrollbars/short-scrollbar-expected.png: Added.
  • platform/chromium-mac/platform/chromium/scrollbars/short-scrollbar-expected.png: Added.
  • platform/chromium-win/platform/chromium/scrollbars/short-scrollbar-expected.png: Added.
5:02 PM Changeset in webkit [145857] by jamesr@google.com
  • 20 edits in trunk/LayoutTests

Fix flaky layout tests that rely on setTimeout()s firing after <body> is parsed
https://bugs.webkit.org/show_bug.cgi?id=112306

Reviewed by Eric Seidel.

These tests all rely in one way or another on the body of a setTimeout set in an inline <script> in the <head>
firing after the <body> element is generated by the HTML parser. This is a flaky pattern since the HTML parser
may yield when parsing a </script> or when runnnig out of bytes from the network. In practice, this pattern used
to be not terribly flaky for layout tests loaded from disk unless there was a large GC pause. However, since the
threaded HTML parser yields more frequently when hitting a </script> this flakes more.

These tests were found by identifying layout tests that call setTimeout before the document's body exists by
modifying the code, then intersecting that set with tests that are flaky on the chromium flakiness dashboard.

  • editing/inserting/insert-text-into-empty-frameset-crash.html:
  • editing/style/apply-style-crash.html:
  • fast/block/float/float-originating-line-deleted-crash.html:
  • fast/block/float/floats-not-cleared-crash.html:
  • fast/block/line-layout/inline-box-wrapper-crash.html:
  • fast/css/positioned-in-relative-position-inline-crash.html:
  • fast/css/user-stylesheet-crash.html:
  • fast/encoding/script-in-head.html:
  • fast/forms/textarea-placeholder-relayout-assertion.html:
  • fast/frames/seamless/seamless-form-get.html:
  • fast/frames/seamless/seamless-form-post-named.html:
  • fast/frames/seamless/seamless-window-location-href.html:
  • fast/frames/seamless/seamless-window-location-replace.html:
  • fast/inline/update-always-create-line-boxes-full-layout-crash.html:
  • fast/innerHTML/innerHTML-iframe.html:
  • fast/js/same-origin-subframe-about-blank.html:
  • fast/multicol/span/removal-of-multicol-span-crash.html:
  • fast/text/international/bidi-neutral-in-mixed-direction-run-crash.html:
  • fast/writing-mode/overhanging-float-legend-crash.html:
4:40 PM May 2013 Meeting edited by benjamin@webkit.org
(diff)
4:33 PM Changeset in webkit [145856] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Check to ensure MultisampleRenderbuffer creation succeeds
https://bugs.webkit.org/show_bug.cgi?id=111780

Patch by Brandon Jones <bajones@google.com> on 2013-03-14
Reviewed by Kenneth Russell.

On OSX systems using AMD graphics chips the allocation of large
Multisample Renderbuffers in Chromium would fail without any indication
of failure. Attempting to draw to the buffer resulted in garbage being
rendered onscreen. This could be reproduced by opening a full-page
WebGL app and pressing (Command + "-") several times. This patch adds an
additional check during DrawingBuffer resize to verify that the resized
buffer is valid.

  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore):
(WebCore::DrawingBuffer::checkBufferIntegrity):
(WebCore::DrawingBuffer::reset):

  • platform/graphics/gpu/DrawingBuffer.h:

(DrawingBuffer):

4:29 PM Changeset in webkit [145855] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] Make zoom filter independent of the layer size.
https://bugs.webkit.org/show_bug.cgi?id=112221

Reviewed by Stephen White.

Source/Platform:

Make the zoom filter hold a zoom amount and an inset.

  • chromium/public/WebFilterOperation.h:

(WebKit::WebFilterOperation::zoomInset):
(WebFilterOperation):
(WebKit::WebFilterOperation::createZoomFilter):
(WebKit::WebFilterOperation::setZoomInset):
(WebKit::WebFilterOperation::WebFilterOperation):

Source/WebKit/chromium:

  • tests/FilterOperationsTest.cpp:

(WebKit):
(WebKit::TEST):

4:22 PM May 2013 Meeting edited by rniwa@webkit.org
Add "improving wiki pages" as a hackathon (diff)
3:43 PM Changeset in webkit [145854] by enrica@apple.com
  • 6 edits
    1 add in trunk

Character orientation should follow UTR50 specs for vertical layout.
https://bugs.webkit.org/show_bug.cgi?id=112213
<rdar://problem/12880943>

Reviewed by Ryosuke Niwa.

Source/WebCore:

platform/mac/fast/text/vertical-no-sideways.html: Modified to cover samples
of the additional character ranges that should not be rotated in vertical layout.
Added pixel results.

This patch modifies shouldIgnoreRotation to include all the characters that
should not be rotated sideways in vertical layout according to the UTR50 draft 6
specifications. It also fixes rotation for Emojii.

  • platform/graphics/FontFastPath.cpp:

(WebCore::shouldIgnoreRotation):
(WebCore::isInRange): Added.

  • platform/graphics/mac/FontMac.mm:

(WebCore::showGlyphsWithAdvances): Adds the proper transforms to ensure
Emojii also are drawn correctly upright.

LayoutTests:

  • platform/mac/fast/text/vertical-no-sideways.html: Modified to cover samples

of the additional character ranges that should not be rotated in vertical layout.

  • platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt:
  • platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.png: Added.
3:30 PM Changeset in webkit [145853] by Lucas Forschler
  • 5 edits in branches/safari-534.59-branch/Source

Versioning.

3:30 PM Changeset in webkit [145852] by Lucas Forschler
  • 1 copy in tags/Safari-534.59.6

New Tag.

3:16 PM Changeset in webkit [145851] by Lucas Forschler
  • 16 edits in branches/safari-534.59-branch

Merged r138606. <rdar://problem/13424275>

3:10 PM Changeset in webkit [145850] by kbr@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed test expectations updates. Suppressed a couple of
failures and adjusted a couple of existing expectations.

  • platform/chromium/TestExpectations:
3:07 PM HackingGtk edited by mrobinson@webkit.org
Cleaned up old information, conglomerated links at the top (diff)
2:54 PM Changeset in webkit [145849] by commit-queue@webkit.org
  • 76 edits in trunk

Add selectTrailingWhitespaceEnabled setting to WebCore::Page
https://bugs.webkit.org/show_bug.cgi?id=109404

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-14
Reviewed by Tony Chang.

Source/WebCore:

Covered by
editing/selection/doubleclick-inline-first-last-contenteditable.html.

  • page/Settings.cpp:

(WebCore): Configure default value for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled seetings as they are different in
Chromium port depending on the OS.

  • page/Settings.in: Add new setting.

Source/WebKit/blackberry:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

Remove code related to DRT as it is not needed anymore.

  • Api/DumpRenderTreeClient.h:
  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::smartInsertDeleteEnabled):
(WebCore::EditorClientBlackBerry::isSelectTrailingWhitespaceEnabled):

Source/WebKit/chromium:

Use new Page settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled and update API accordingly.

WebSettings API is required by DRT in order to set the proper default
values which are different from browser defaults.

  • public/WebSettings.h: Add new API to manage smartInsertDeleteEnabled

and selectTrailingWhitespaceEnabled settings.

  • public/WebViewClient.h: Remove API related to smartInsertDeleteEnabled

and selectTrailingWhitespaceEnabled as they will be managed from page
settings from now on.

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::smartInsertDeleteEnabled):
(WebKit::EditorClientImpl::isSelectTrailingWhitespaceEnabled): Use new
settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

  • src/WebSettingsImpl.cpp: Implement methods establishing the page

settings.
(WebKit::WebSettingsImpl::setSelectTrailingWhitespaceEnabled):
(WebKit):
(WebKit::WebSettingsImpl::setSmartInsertDeleteEnabled):

  • src/WebSettingsImpl.h:

(WebSettingsImpl): Implement new API to manage the new settings.

Source/WebKit/efl:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

Remove code related to DRT as it is not needed anymore.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.h:
  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::smartInsertDeleteEnabled):
(WebCore::EditorClientEfl::isSelectTrailingWhitespaceEnabled):
(WebCore::EditorClientEfl::EditorClientEfl):

  • WebCoreSupport/EditorClientEfl.h:

(EditorClientEfl):

Source/WebKit/gtk:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

Remove code related to DRT as it is not needed anymore.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::smartInsertDeleteEnabled):
(WebKit::EditorClient::isSelectTrailingWhitespaceEnabled):
(WebKit::EditorClient::EditorClient):

  • WebCoreSupport/EditorClientGtk.h:

(EditorClient):

Source/WebKit/mac:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::smartInsertDeleteEnabled):
(WebEditorClient::isSelectTrailingWhitespaceEnabled):

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]): Initialize
settings from NSUserDefaults.
(-[WebView setSelectTrailingWhitespaceEnabled:]):
(-[WebView isSelectTrailingWhitespaceEnabled]):
(-[WebView setSmartInsertDeleteEnabled:]):
(-[WebView smartInsertDeleteEnabled]):

  • WebView/WebViewData.h:
  • WebView/WebViewData.mm:

(-[WebViewPrivate init]):

Source/WebKit/qt:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

Remove code related to DRT as it is not needed anymore.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:
  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::smartInsertDeleteEnabled):
(WebCore::EditorClientQt::toggleSmartInsertDelete):
(WebCore::EditorClientQt::isSelectTrailingWhitespaceEnabled):
(WebCore::EditorClientQt::EditorClientQt):

  • WebCoreSupport/EditorClientQt.h:

(EditorClientQt):

Source/WebKit/win:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

  • WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::smartInsertDeleteEnabled):
(WebEditorClient::isSelectTrailingWhitespaceEnabled):

  • WebView.cpp:

(WebView::WebView):
(WebView::setSmartInsertDeleteEnabled):
(WebView::smartInsertDeleteEnabled):
(WebView::setSelectTrailingWhitespaceEnabled):
(WebView::isSelectTrailingWhitespaceEnabled):

  • WebView.h:

(WebView):

Source/WebKit/wince:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

  • WebCoreSupport/EditorClientWinCE.cpp:

(WebKit::EditorClientWinCE::smartInsertDeleteEnabled):
(WebKit::EditorClientWinCE::isSelectTrailingWhitespaceEnabled):

Source/WebKit/wx:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

  • WebKitSupport/EditorClientWx.cpp:

(WebCore::EditorClientWx::smartInsertDeleteEnabled):
(WebCore::EditorClientWx::isSelectTrailingWhitespaceEnabled):

Tools:

Removes all the code related to smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled settings as they will be managed from
internals from now on.

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(WebKit):
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):

  • DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:

(DumpRenderTree):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestRunner::WebTestProxy::didStopLoading):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::applyTo): Set default values for
smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
Chromium DRT default values are different from Chromium browser.

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:
  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/TestRunnerGtk.cpp:
  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

  • DumpRenderTree/mac/TestRunnerMac.mm:
  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

  • DumpRenderTree/qt/TestRunnerQt.cpp:
  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting):

  • DumpRenderTree/win/TestRunnerWin.cpp:
  • DumpRenderTree/wx/TestRunnerWx.cpp:

LayoutTests:

Replace testRunner.setSelectTrailingWhitespaceEnabled by
internals.settings.setSelectTrailingWhitespaceEnabled in tests.

Be sure that trailingWhitespaceEnabled and
selectTrailingWhitespaceEnabled are set to opposite values as they are
mutually exclusive.

  • editing/deleting/smart-editing-disabled.html:
  • editing/selection/doubleclick-beside-cr-span.html:
  • editing/selection/doubleclick-whitespace-crash.html:
  • editing/selection/doubleclick-whitespace-img-crash.html:
  • editing/selection/doubleclick-whitespace.html:
  • editing/selection/script-tests/doubleclick-inline-first-last-contenteditable.js:
  • editing/spelling/resources/util.js:

(initSpellTest):

  • editing/spelling/spelling-double-clicked-word-with-underscores.html:
  • editing/spelling/spelling-double-clicked-word.html:
  • platform/wk2/TestExpectations: Unflag

editing/selection/doubleclick-inline-first-last-contenteditable.html
as it passes now.

2:14 PM Changeset in webkit [145848] by mhahnenberg@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Objective-C API: Objective-C functions exposed to JavaScript have the wrong type (object instead of function)
https://bugs.webkit.org/show_bug.cgi?id=105892

Reviewed by Geoffrey Garen.

Changed ObjCCallbackFunction to subclass JSCallbackFunction which already has all of the machinery to call
functions using the C API. Since ObjCCallbackFunction is now a JSCell, we changed the old implementation of
ObjCCallbackFunction to be the internal implementation and keep track of all the proper data so that we
don't have to put all of that in the header, which will now be included from C++ files (e.g. JSGlobalObject.cpp).

  • API/JSCallbackFunction.cpp: Change JSCallbackFunction to allow subclassing. Originally it was internally

passing its own Structure up the chain of constructors, but we now want to be able to pass other Structures as well.
(JSC::JSCallbackFunction::JSCallbackFunction):
(JSC::JSCallbackFunction::create):

  • API/JSCallbackFunction.h:

(JSCallbackFunction):

  • API/JSWrapperMap.mm: Changed interface to tryUnwrapBlock.

(tryUnwrapObjcObject):

  • API/ObjCCallbackFunction.h:

(ObjCCallbackFunction): Moved into the JSC namespace, just like JSCallbackFunction.
(JSC::ObjCCallbackFunction::createStructure): Overridden so that the correct ClassInfo gets used since we have
a destructor.
(JSC::ObjCCallbackFunction::impl): Getter for the internal impl.

  • API/ObjCCallbackFunction.mm:

(JSC::ObjCCallbackFunctionImpl::ObjCCallbackFunctionImpl): What used to be ObjCCallbackFunction is now
ObjCCallbackFunctionImpl. It handles the Objective-C specific parts of managing callback functions.
(JSC::ObjCCallbackFunctionImpl::~ObjCCallbackFunctionImpl):
(JSC::objCCallbackFunctionCallAsFunction): Same as the old one, but now it casts to ObjCCallbackFunction and grabs the impl
rather than using JSObjectGetPrivate.
(JSC::ObjCCallbackFunction::ObjCCallbackFunction): New bits to allow being part of the JSCell hierarchy.
(JSC::ObjCCallbackFunction::create):
(JSC::ObjCCallbackFunction::destroy):
(JSC::ObjCCallbackFunctionImpl::call): Handles the actual invocation, just like it used to.
(objCCallbackFunctionForInvocation):
(tryUnwrapBlock): Changed to check the ClassInfo for inheritance directly, rather than going through the C API call.

  • API/tests/testapi.mm: Added new test to make sure that doing Function.prototype.toString.call(f) won't result in

an error when f is an Objective-C method or block underneath the covers.

  • runtime/JSGlobalObject.cpp: Added new Structure for ObjCCallbackFunction.

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::objcCallbackFunctionStructure):

2:10 PM Changeset in webkit [145847] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[CSS Exclusions] shape-outside on floats for rounded rectangle shapes
https://bugs.webkit.org/show_bug.cgi?id=100299

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-03-14
Reviewed by Dirk Schulze.

Adding tests for rounded rectangles. The code already supports them,
but that was more of a happy accident. These tests makes it more
likely to stay that way.

  • fast/exclusions/resources/rounded-rectangle.js:

(xOutset): Function to determine the offset for the outside shape.
(generateShapeOutsideOnFloat): Generate a shape outside on a float.
(generateSimulatedShapeOutsideOnFloat): Simulate a shape outside on a

float using a large number of smaller floats.

  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-expected.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle.html: Added.
2:05 PM Changeset in webkit [145846] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

[WebKit2] Only preprocess sandbox profiles if we're building for the OS X SDK
https://bugs.webkit.org/show_bug.cgi?id=112330

Reviewed by David Kilzer.

We shouldn't preprocess sandbox profiles just because the computer
we're building on is a Mac. We should only do it if we're actually
building for the OS X SDK.

  • DerivedSources.make: Check if $PLATFORM_NAME is macosx rather than if

$OS is MACOS.

1:56 PM Changeset in webkit [145845] by weinig@apple.com
  • 10 edits in trunk/Source/WebKit2

Support private browsing on a per-page basis
<rdar://problem/11969491>

Reviewed by Timothy Horton.

Adds WKPageSetOverridePrivateBrowsingEnabled and WKPageGetOverridePrivateBrowsingEnabled.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:

(WebPageCreationParameters):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetOverridePrivateBrowsingEnabled):
(WKPageGetOverridePrivateBrowsingEnabled):

  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setOverridePrivateBrowsingEnabled):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::overridePrivateBrowsingEnabled):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::updatePreferences):
(WebKit::WebPage::setOverridePrivateBrowsingEnabled):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Pipe through.

1:49 PM Changeset in webkit [145844] by commit-queue@webkit.org
  • 8 edits
    4 adds in trunk

[chromium] Short scrollbar has empty track rect even when buttons have no size.
https://bugs.webkit.org/show_bug.cgi?id=102580

Patch by Robert Flack <flackr@chromium.org> on 2013-03-14
Reviewed by James Robinson.

When computing the scrollbar track rect, don't assume the button's height is the track width.

Source/WebCore:

Test: platform/chromium/scrollbars/short-scrollbar.html
Note however that this doesn't expose the bug on any tested platforms and mock scrollbars
don't use ScrollbarThemeChromium.cpp. Manually running this test on linux chromiumos will
show the now present scrollbar track and thumb.

  • platform/chromium/ScrollbarThemeChromium.cpp:

(WebCore::ScrollbarThemeChromium::trackRect):

LayoutTests:

  • platform/chromium-linux/fast/forms/basic-textareas-expected.png:
  • platform/chromium-linux/fast/forms/basic-textareas-quirks-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-x-y-expected.png:
  • platform/chromium-linux/fast/parser/open-comment-in-textarea-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-textarea-expected.png:
  • platform/chromium-linux/platform/chromium/scrollbars/short-scrollbar-expected.png: Added.
  • platform/chromium/scrollbars/short-scrollbar-expected.txt: Added.
  • platform/chromium/scrollbars/short-scrollbar.html: Added.
1:29 PM Changeset in webkit [145843] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Show syntax highlight for application/javascript in Resource Preview tab
https://bugs.webkit.org/show_bug.cgi?id=112355

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-14
Reviewed by Pavel Feldman.

No new tests.

Return canonical mimeType in requestContent method of
NetworkRequest.js

  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype.requestContent):

1:14 PM Changeset in webkit [145842] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Objective-C API: Nested dictionaries are not converted properly in the Objective-C binding
https://bugs.webkit.org/show_bug.cgi?id=112377

Reviewed by Oliver Hunt.

Accidental reassignment of the root task in the container conversion logic was causing the last
array or dictionary processed to be returned in the case of nested containers.

  • API/JSValue.mm:

(containerValueToObject):

  • API/tests/testapi.mm:
1:08 PM Changeset in webkit [145841] by commit-queue@webkit.org
  • 12 edits in trunk

[EFL] Use CROSS_PLATFORM_CONTEXT_MENU
https://bugs.webkit.org/show_bug.cgi?id=111877

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2013-03-14
Reviewed by Caio Marcelo de Oliveira Filho.

.:

  • Source/cmake/OptionsEfl.cmake: add -DWTF_USE_CROSS_PLATFORM_CONTEXT_MENUS=1

Source/WebCore:

Now EFL uses the CROSS_PLATFORM_CONTEXT_MENUS
USE flag. This flag provides a full cross-platform
representation of a ContextMenu and a ContextMenuItem.
The embedder can then decide how to show this and neither
WebCore nor WebCore/platform need to know any platform
specific code about the menus, even though they could.

No new tests needed, no behavior changes.

  • platform/ContextMenu.h:

(ContextMenu):

  • platform/ContextMenuItem.h:

(WebCore):

  • platform/PlatformMenuDescription.h:

(WebCore):

  • platform/efl/ContextMenuEfl.cpp:

(WebCore::ContextMenu::ContextMenu):
(WebCore::ContextMenu::getContextMenuItems):
(WebCore::ContextMenu::createPlatformContextMenuFromItems):
(WebCore::ContextMenu::platformContextMenu):

  • platform/efl/ContextMenuItemEfl.cpp:

(WebCore::ContextMenuItem::platformContextMenuItem):

Source/WebKit/efl:

Adjust ContextMenuClient to use the CROSS_PLATFORM_CONTEXT_MENUS USE flag
by implementing customizeMenu() instead of getCustomMenuFromDefaultItems()
and by calling coreMenu->items() instead of coreMenu->platformDescription().

  • WebCoreSupport/ContextMenuClientEfl.cpp:

(WebCore::ContextMenuClientEfl::customizeMenu):

  • WebCoreSupport/ContextMenuClientEfl.h:

(ContextMenuClientEfl):

  • ewk/ewk_contextmenu.cpp:

(ewk_context_menu_new):

1:04 PM Changeset in webkit [145840] by jchaffraix@webkit.org
  • 4 edits in trunk/Source/WebCore

[CSS Grid Layout] resolveContentBasedTrackSizingFunctions should iterate over the grid items not the grid tracks
https://bugs.webkit.org/show_bug.cgi?id=112299

Reviewed by Tony Chang.

Our initial implementation would iterate over the grid tracks. This was equivalent as no items were spanning but
once grid items spans, they start to contribute to several grid tracks differently. This change aligns our code
with what the specification does.

One upside of doing a grid items' iteration is that the complexity should be better in all cases as we don't do
a full grid walking (which is potentially quadratic), only some extra grid tracks' iteration (which are linear).

Refactoring, there should be no change in behavior.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
Moved the |availableLogicalSpace| update into resolveContentBasedTrackSizingFunctions. This simplifies and consolidate our handling.

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
Updated the core loop to iterator over grid items and not grid tracks. This idea is that now resolveContentBasedTrackSizingFunctionsForItems
uses a filtering function to only process the appropriate grid tracks.

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Updated to filter the grid tracks here (this matches the |TracksForGrowth| spec logic that is merely a filtering function).

  • rendering/RenderGrid.h:

Added a new typedef and updated resolveContentBasedTrackSizingFunctionsForItems to use it.

  • rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::hasMinOrMaxContentMinTrackBreadth):
(WebCore::GridTrackSize::hasMaxContentMinTrackBreadth):
(WebCore::GridTrackSize::hasMinOrMaxContentMaxTrackBreadth):
(WebCore::GridTrackSize::hasMaxContentMaxTrackBreadth):
Added the following filtering function, which matches the values from |TracksForGrowth| in the specification.

12:55 PM Changeset in webkit [145839] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0

Unreviewed. Pre-release version bump.

  • Source/autotools/Versions.m4: Bump version to 1.11.92 for people

already using the webkit-2.0 branch.

12:42 PM Changeset in webkit [145838] by fpizlo@apple.com
  • 24 edits
    9 adds in trunk

JSObject fast by-string access optimizations should work even on the prototype chain, and even when the result is undefined
https://bugs.webkit.org/show_bug.cgi?id=112233

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Extended the existing fast access path for String keys to work over the entire prototype chain,
not just the self access case. This will fail as soon as it sees an object that intercepts
getOwnPropertySlot, so this patch also ensures that ObjectPrototype does not fall into that
category. This is accomplished by making ObjectPrototype eagerly reify all of its properties.
This is safe for ObjectPrototype because it's so common and we expect all of its properties to
be reified for any interesting programs anyway. A new idiom for adding native functions to
prototypes is introduced, which ought to work well for any other prototypes that we wish to do
this conversion for.

This is a >60% speed-up in the case that you frequently do by-string lookups that "miss", i.e.
they don't turn up anything.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • dfg/DFGOperations.cpp:
  • interpreter/CallFrame.h:

(JSC::ExecState::objectConstructorTable):

  • jit/JITStubs.cpp:

(JSC::getByVal):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::getByVal):

  • runtime/CommonIdentifiers.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::getByStringSlow):
(JSC):

  • runtime/JSCell.h:

(JSCell):

  • runtime/JSCellInlines.h:

(JSC):
(JSC::JSCell::getByStringAndKey):
(JSC::JSCell::getByString):

  • runtime/JSGlobalData.cpp:

(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/JSObject.cpp:

(JSC::JSObject::putDirectNativeFunction):
(JSC):

  • runtime/JSObject.h:

(JSObject):
(JSC):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/ObjectPrototype.cpp:

(JSC):
(JSC::ObjectPrototype::finishCreation):
(JSC::ObjectPrototype::create):

  • runtime/ObjectPrototype.h:

(ObjectPrototype):

  • runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::findWithString):

  • runtime/Structure.h:

(Structure):

  • runtime/StructureInlines.h:

(JSC::Structure::get):
(JSC):

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/js/regress/script-tests/string-lookup-hit-identifier.js: Added.

(result):

  • fast/js/regress/script-tests/string-lookup-hit.js: Added.

(result):

  • fast/js/regress/script-tests/string-lookup-miss.js: Added.

(result):

  • fast/js/regress/string-lookup-hit-expected.txt: Added.
  • fast/js/regress/string-lookup-hit-identifier-expected.txt: Added.
  • fast/js/regress/string-lookup-hit-identifier.html: Added.
  • fast/js/regress/string-lookup-hit.html: Added.
  • fast/js/regress/string-lookup-miss-expected.txt: Added.
  • fast/js/regress/string-lookup-miss.html: Added.
12:35 PM Changeset in webkit [145837] by Carlos Garcia Campos
  • 1 edit
    1 add in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Unreviewed build fix. Add missing file.

  • UIProcess/API/gtk/WebKitForwardDeclarations.h: Added.
12:18 PM Changeset in webkit [145836] by Carlos Garcia Campos
  • 12 edits
    1 delete in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Split WebKitDefines.h in two files.

Reviewed by Gustavo Noronha Silva.

The WebKitDefines.h header has been split moving the forward
declarations specific to the UI process API to a new file
WebKitForwardDeclarations.h. This way we can share the
WebKitDefines.h header and remove the WebKitWebExtensionDefines.h
header used in the web extensions API.

  • GNUmakefile.list.am:
  • UIProcess/API/gtk/WebKitContextMenu.h:
  • UIProcess/API/gtk/WebKitContextMenuItem.h:
  • UIProcess/API/gtk/WebKitDefines.h:
  • UIProcess/API/gtk/WebKitDownload.h:
  • UIProcess/API/gtk/WebKitFindController.h:
  • UIProcess/API/gtk/WebKitPrintOperation.h:
  • UIProcess/API/gtk/WebKitURISchemeRequest.h:
  • UIProcess/API/gtk/WebKitWebView.h:
  • WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.h:
  • WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionDefines.h: Removed.
  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h:
12:13 PM Changeset in webkit [145835] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r188004. Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-14

  • DEPS:
12:06 PM Changeset in webkit [145834] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Gradient: don't use the default setPlatformGradientSpaceTransform()
https://bugs.webkit.org/show_bug.cgi?id=112246

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-14
Reviewed by Xan Lopez.

BlackBerry has its own implementation.

  • platform/graphics/Gradient.cpp:

(WebCore):

11:52 AM Changeset in webkit [145833] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/qt

[Qt][WK1] REGRESSION(r145784): Blend tests are failing
https://bugs.webkit.org/show_bug.cgi?id=112333

Patch by Rik Cabanier <cabanier@adobe.com> on 2013-03-14
Reviewed by Ryosuke Niwa.

Added code to passed compositing prefence to WebCore.

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):

  • Api/qwebsettings.h:
11:38 AM Changeset in webkit [145832] by kbr@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed expectations updates for a couple of failing tests.

  • platform/chromium/TestExpectations:
11:37 AM Changeset in webkit [145831] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[GStreamer] simulateAudioInterruption needs to be guarded by ENABLE(VIDEO)"
https://bugs.webkit.org/show_bug.cgi?id=112358

Guarded with ENABLE(VIDEO) to prevent problems when it is not
enabled.

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

11:32 AM Changeset in webkit [145830] by fmalita@chromium.org
  • 15 edits in trunk/Source/WebCore

Tighten up the type bounds for SVGPropertyInfo callback parameters
https://bugs.webkit.org/show_bug.cgi?id=111786

Reviewed by Philip Rogers.

Update SVGPropertyInfo's callbacks to pass SVGElement* parameters instead of void*. This
allows us to perform some ASSERT-based type checking before downcasting in implementors.

To avoid adding virtual methods unused in release builds to the base class (and overrides
in descendants), for subtypes lacking polymorphic type markers (isXXX()) the check is
performed using hasTagName() instead.

The patch is also removing the lookupOrCreateWrapperForAnimatedProperty() SVGPropertyInfo
callback for SVGViewSpec properties, because

a) it doesn't appear to be reachable (SVGViewSpec doesn't have a backing element and
thus cannot have an associated animator)

b) it interferes with the parameter specialization described above (SVGViewSpec does not
inherit from SVGElement)

No new tests, refactoring only.

  • svg/SVGElement.cpp:

(WebCore::SVGElement::synchronizeRequiredFeatures):
(WebCore::SVGElement::synchronizeRequiredExtensions):
(WebCore::SVGElement::synchronizeSystemLanguage):

  • svg/SVGElement.h:

(SVGElement):

  • svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::synchronizeOrientType):
(WebCore::SVGMarkerElement::lookupOrCreateOrientTypeWrapper):

  • svg/SVGMarkerElement.h:

(SVGMarkerElement):
(WebCore::toSVGMarkerElement):
(WebCore):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::lookupOrCreateDWrapper):
(WebCore::SVGPathElement::synchronizeD):

  • svg/SVGPathElement.h:

(SVGPathElement):
(WebCore::toSVGPathElement):
(WebCore):

  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::synchronizePoints):
(WebCore::SVGPolyElement::lookupOrCreatePointsWrapper):

  • svg/SVGPolyElement.h:

(SVGPolyElement):
(WebCore::toSVGPolyElement):
(WebCore):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::synchronizeTextLength):
(WebCore::SVGTextContentElement::lookupOrCreateTextLengthWrapper):

  • svg/SVGTextContentElement.h:

(SVGTextContentElement):
(WebCore::toSVGTextContentElement):
(WebCore):
Change SVGPropertyInfo callback params to SVGElement* and replace static casts with
conversion wrappers. Implement conversion wrappers where needed.

  • svg/SVGViewSpec.cpp:

(WebCore::SVGViewSpec::viewBoxPropertyInfo):
(WebCore::SVGViewSpec::preserveAspectRatioPropertyInfo):
(WebCore::SVGViewSpec::transformPropertyInfo):
(WebCore::SVGViewSpec::lookupOrCreateViewBoxWrapper):
(WebCore::SVGViewSpec::lookupOrCreatePreserveAspectRatioWrapper):
(WebCore::SVGViewSpec::lookupOrCreateTransformWrapper):

  • svg/SVGViewSpec.h:

(SVGViewSpec):
Remove SVGPropertyInfo-based lookupOrCreate* callbacks and updated the methods' parameters
to SVGViewSpec*. Remove now-unneeded casts.

  • svg/properties/SVGAnimatedPropertyMacros.h:

(WebCore):

  • svg/properties/SVGPropertyInfo.h:

(WebCore):
(SVGPropertyInfo):
Update callback declarations.

11:20 AM Changeset in webkit [145829] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Add tools/protoc_wrapper to directories pulled in Chromium-in-WebKit configuration
https://bugs.webkit.org/show_bug.cgi?id=112363

Patch by James Robinson <jamesr@chromium.org> on 2013-03-14
Reviewed by Kenneth Russell.

Chromium r187704 added a reference to this script to src/gpu/gpu.gyp, which we pull in the Chromium-in-WebKit
configuration. This adds the script to DEPS so we can roll past that rev.

  • DEPS:
10:40 AM Changeset in webkit [145828] by fpizlo@apple.com
  • 5 edits
    3 adds in trunk

DFG bytecode parser is too aggressive about getting rid of GetLocals on captured variables
https://bugs.webkit.org/show_bug.cgi?id=112287
<rdar://problem/13342340>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finalizeUnconditionally):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getLocal):

LayoutTests:

  • fast/js/dfg-captured-var-get-local-expected.txt: Added.
  • fast/js/dfg-captured-var-get-local.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-captured-var-get-local.js: Added.

(foo):

10:38 AM Changeset in webkit [145827] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Move platform-specific typedefs to PlatformMenuDescription.h
https://bugs.webkit.org/show_bug.cgi?id=111876

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2013-03-14
Reviewed by Caio Marcelo de Oliveira Filho.

Source/WebCore:

Cross platform Context Menu platform-specific typedefs fit better
in PlatformMenuDescription.h and should not be part of the classes
ContextMenu and ContextMenuItem. We have also renamed them to
PlatformContextMenu and PlatformContextMenuItem instead of NativeMenu
and NativeMenuItem respectively.

No new tests needed since no behavior has changed.

  • platform/ContextMenu.h:

(ContextMenu):

  • platform/ContextMenuItem.h:

(ContextMenuItem):

  • platform/PlatformMenuDescription.h:

(WebCore):

  • platform/efl/ContextMenuEfl.cpp:

(WebCore::ContextMenu::createPlatformContextMenuFromItems):
(WebCore::ContextMenu::platformContextMenu):

  • platform/efl/ContextMenuItemEfl.cpp:

(WebCore::ContextMenuItem::platformContextMenuItem):

  • platform/win/ContextMenuItemWin.cpp:

(WebCore):
(WebCore::ContextMenuItem::platformContextMenuItem):

  • platform/win/ContextMenuWin.cpp:

(WebCore::ContextMenu::createPlatformContextMenuFromItems):
(WebCore::ContextMenu::platformContextMenu):

Source/WebKit/win:

Rename NativeMenuItem to PlatformContextMenuItem and the getter
function call.

  • WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::customizeMenu):
(WebContextMenuClient::contextMenuItemSelected):

  • WebView.cpp:

(WebView::handleContextMenuEvent):

10:27 AM Changeset in webkit [145826] by jer.noble@apple.com
  • 18 edits in trunk/Source/WebCore

Crash in DumpRenderTree at com.apple.WebCore: WebCore::CaptionUserPreferences::captionPreferencesChanged + 185
https://bugs.webkit.org/show_bug.cgi?id=112051

Reviewed by Eric Carlson.

No new tests; fixes a crash during media/video-controls-captions-trackmenu.html.

Instead of relying on a registration system which can fail when an element's document does not have a page,
Elements will register for captionPreferencesChanged() notifications directly with their owning Document.
CaptionUserPreferences, in turn, will notify all Documents in its PageGroup, rather than only directly
registered listeners.

  • dom/Document.cpp:

(WebCore::Document::registerForCaptionPreferencesChangedCallbacks): Added. Notify the CaptionUserPreferences that someone

is interested in captionPreferencesChanged notfications.

(WebCore::Document::unregisterForCaptionPreferencesChangedCallbacks): Added.
(WebCore::Document::captionPreferencesChanged): Added. Pass to all registered elements.

  • dom/Document.h:
  • dom/Element.h:

(WebCore::Element::captionPreferencesChanged): Added. Empty; intended

to be overridden by subclasses.

  • history/CachedPage.cpp:

(WebCore::CachedPage::CachedPage): Initialize m_needsCaptionPreferenceChanged member.
(WebCore::CachedPage::restore): Call captionPreferencesChanged() if necessary.

  • history/CachedPage.h:

(WebCore::CachedPage::markForCaptionPreferencesChanged): Set the m_needsCaptionPreferenceChanged member.

  • history/PageCache.cpp:

(WebCore::PageCache::markPagesForCaptionPreferencesChanged): Pass to every CachedPage.

  • history/PageCache.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Register with the Document.
(WebCore::HTMLMediaElement::~HTMLMediaElement): Unregister with same.
(WebCore::HTMLMediaElement::attach): Remove previous registration call.

  • html/HTMLMediaElement.h:
  • page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::captionPreferencesChanged): Pass to the

PageGroup.

  • page/CaptionUserPreferences.h:

(WebCore::CaptionUserPreferences::setInterestedInCaptionPreferenceChanges):

Empty; intended to be overridden by subclasses.

  • page/CaptionUserPreferencesMac.h:
  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::setInterestedInCaptionPreferenceChanges):

Renamed from registerForPreferencesChangedCallbacks().

(WebCore::CaptionUserPreferencesMac::captionPreferencesChanged):

Replace call to havePreferenceChangeListeners() with m_listeningForPreferenceChanges.

  • page/Page.cpp:

(WebCore::Page::captionPreferencesChanged):

Pass to every contained Document.

  • page/Page.h:
  • page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::captionPreferencesChanged): Pass to the PageGroup.

  • page/CaptionUserPreferences.h:
  • page/PageGroup.cpp:

(WebCore::PageGroup::captionPreferencesChanged): Pass to every page, as well as pages in the PageCache.

  • page/PageGroup.h:
10:11 AM Changeset in webkit [145825] by tdanderson@chromium.org
  • 1 edit in branches/chromium/1410/LayoutTests/platform/chromium/TestExpectations

Merge 144700 "Unreviewed gardening."

Just merged https://codereview.chromium.org/12817006/ into the 26 milestone. I am also
merging this in order to suppress two test failures on chromium-mac. These tests are
no cause for concern (since chromium-mac does not use the scrolling code I have
changed) and these will be given new baselines in a future milestone. See
https://code.google.com/p/chromium/issues/detail?id=174255

Unreviewed gardening.

  • platform/chromium/TestExpectations: touch-gesture-noscroll-body-* are failing on mac.

TBR=tdanderson@chromium.org
Review URL: https://codereview.chromium.org/12870005

10:08 AM Changeset in webkit [145824] by dgrogan@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Histogram leveldb open errors.
https://bugs.webkit.org/show_bug.cgi?id=112307

Reviewed by Tony Chang.

No new tests, I don't know if there's a good way to test histograms.

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::open):

10:06 AM Changeset in webkit [145823] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed flakiness fix following r145727: filter out coalescing records while dumping timeline record structure.

  • inspector/timeline/timeline-receive-response-event.html:
10:01 AM Changeset in webkit [145822] by robert@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r145305) Performance: 1.3% mac-release-10.6-webkit-latest/intl2/times/t change after rev 145300
https://bugs.webkit.org/show_bug.cgi?id=112125

Reviewed by Julien Chaffraix.

When detecting cases where a loaded image may need to move up into the padding created by the row's baseline
we don't need to do anything if the row doesn't have a baseline yet.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::layout):

9:55 AM Changeset in webkit [145821] by tdanderson@chromium.org
  • 12 edits
    12 copies in branches/chromium/1410

Merge 144519 "EventHandler::handleGestureScrollUpdate() should i..."

EventHandler::handleGestureScrollUpdate() should invoke the user-generated scroll routines
so its behavior matches other user-initiated scrolls
https://bugs.webkit.org/show_bug.cgi?id=109769

Reviewed by James Robinson.

Source/WebCore:

To ensure that the scrolling behavior of GestureScrollUpdate events are consistent with
the scrolling behavior of mousewheel events, use the existing user-generated scroll logic
instead of calling into RenderLayer::scrollByRecursively(). This patch fixes the bug
reported in https://bugs.webkit.org/show_bug.cgi?id=109316, where the example page can
be scrolled using touch but cannot be scrolled using mousewheels.

Note that this patch does not use any of the mousewheel event-handling code.

Tests: fast/events/touch/gesture/touch-gesture-noscroll-body-propagated.html

fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden.html
fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden.html
fast/events/touch/gesture/touch-gesture-noscroll-body.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureScrollBegin):
(WebCore::EventHandler::handleGestureScrollUpdate):
(WebCore::EventHandler::sendScrollEventToView):

By calling this function at the start of handleGestureScrollUpdate() in the case
where |m_scrollGestureHandlingNode| is null, we ensure that the scroll updates
can still scroll the page itself, if possible.

(WebCore):
(WebCore::EventHandler::clearGestureScrollNodes):

  • page/EventHandler.h:

(EventHandler):

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::setHasPreciseScrollingDeltas):

Source/WebKit/chromium:

Clear the nodes corresponding to a fling scroll event when the event ends.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateAnimations):

LayoutTests:

Four new layout tests have been added and touch-gesture-scroll-page.html has been
modified to demonstrate that this patch fixes two existing bugs. See the inline
comments below for details.

Because I am now using the existing user-generated scroll logic, the delta for a single
GestureScrollUpdate event will not be propagated to the parent of the targeted node
unless the targeted node has no remaining scrollable area. So the changes to the
existing layout tests have been made to ensure that the targeted node has been fully
scrolled before subsequent GestureScrollUpdate events will scroll the parent(s) of
the targeted node.

I have also removed the function recordScroll() from the existing layout tests
because this function already exists in the included file resources/gesture-helpers.js.

  • fast/events/touch/gesture/touch-gesture-noscroll-body-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-noscroll-body-propagated-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-noscroll-body-propagated.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
  • fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
  • fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
  • fast/events/touch/gesture/touch-gesture-noscroll-body.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
  • fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated.html:
  • fast/events/touch/gesture/touch-gesture-scroll-div-propagated.html:
  • fast/events/touch/gesture/touch-gesture-scroll-div-twice-propagated.html:
  • fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated.html:
  • fast/events/touch/gesture/touch-gesture-scroll-iframe-propagated.html:
  • fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated.html:
  • fast/events/touch/gesture/touch-gesture-scroll-page-propagated.html:
  • fast/events/touch/gesture/touch-gesture-scroll-page.html:

I modified this layout test in order to add test coverage for another bug
which is fixed by this patch: if the hit test performed on a GestureScrollBegin
does not target a specific node, the subsequent GestureScrollUpdate events should
still attempt to scroll the page itself. This is consistent with how mousewheel
events behave.

  • platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-propagated-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden-expected.txt: Added.

These four new layout tests verify that a non-scrollable body will not scroll,
as reported in https://bugs.webkit.org/show_bug.cgi?id=109316.

TBR=tdanderson@chromium.org
Review URL: https://codereview.chromium.org/12817006

9:28 AM Changeset in webkit [145820] by beidson@apple.com
  • 12 edits in trunk/Source/WebCore

Add a mode to ResourceLoader that takes SharedBuffers instead of raw pointers and lengths.
<rdar://problem/13416953> and https://bugs.webkit.org/show_bug.cgi?id=112310

Reviewed by Andy Estes.

No new tests (No independently testable change in behavior).

Many of the tested platforms deliver data buffers to their ResourceHandles from objects
that encapsulate a data buffer such as NSData (Mac), CFDataRef (CF), or QByteArray (qt).

If those platforms also augmented SharedBuffer to wrap their native object (which Mac/CF do)
and there existed ResourceLoader callbacks to take that SharedBuffer instead of char* + length,
then many resource loads could avoid a useless copy.

At least on Mac, there are some extremely important behind-the-scenes optimizations for NS/CFData
that will be a more important win than simply avoiding a copy.

This patch adds that SharedBuffer-based callback with the hope that all platforms could find a
way to use a buffer-encapsulating object going forward, and we could therefore deprecate the
char* + length version of didReceiveData.

  • platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::didReceiveBuffer): Add a didReceiveBuffer callback that takes

a SharedBuffer object. The default implementation passes raw bytes + length to didReceiveData.

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::addDataOrBuffer): Replacing addData(), optionally adding the data from

either a data+length or SharedBuffer

(WebCore::ResourceLoader::didReceiveData): Pipe to didReceiveDataOrBuffer.
(WebCore::ResourceLoader::didReceiveBuffer): Pipe to didReceiveDataOrBuffer.
(WebCore::ResourceLoader::didReceiveDataOrBuffer): Single chokepoint for receiving data.

  • loader/ResourceLoader.h: Add OVERRIDE to all of the ResourceHandleClient methods to help catch future mistakes. Remove "virtual" from methods that didn't need it. Make "addData" into "addDataOrBuffer" and make it private.
  • loader/NetscapePlugInStreamLoader.cpp:

(WebCore::NetscapePlugInStreamLoader::didReceiveData): Pipe to didReceiveDataOrBuffer.
(WebCore::NetscapePlugInStreamLoader::didReceiveBuffer): Pipe to didReceiveDataOrBuffer.
(WebCore::NetscapePlugInStreamLoader::didReceiveDataOrBuffer): Single chokepoint for receiving data.

  • loader/NetscapePlugInStreamLoader.h:
  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveData): Pipe to didReceiveDataOrBuffer.
(WebCore::SubresourceLoader::didReceiveBuffer): Pipe to didReceiveDataOrBuffer.
(WebCore::SubresourceLoader::didReceiveDataOrBuffer): Single chokepoint for receiving data. Also,

rely on ResourceLoader's base implementation for notifying the ResourceLoadNotifier.

  • loader/SubresourceLoader.h:
  • loader/ResourceBuffer.cpp:

(WebCore::ResourceBuffer::append): Add a mode that appends a SharedBuffer.

  • loader/ResourceBuffer.h:
  • platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::maybeTransferPlatformData): Fix a bug where appending data to a CFData-backed

SharedBuffer would re-enter maybeTransferPlatformData and blow out the stack.

  • platform/network/mac/ResourceHandleMac.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): Send a wrapped NSData

to didReceiveBuffer() instead of sending its char* and length to didReceiveData()

9:14 AM Changeset in webkit [145819] by yurys@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: nuke bottom up CPU profile calculation on backend
https://bugs.webkit.org/show_bug.cgi?id=112351

Reviewed by Pavel Feldman.

Removed code that builds bottom-up CPU profile on the inspector
backend. Bottom-up view is already built on the front-end from
the top-down profile data.

  • bindings/js/ScriptProfile.cpp:
  • bindings/js/ScriptProfile.h:

(ScriptProfile):

  • bindings/v8/ScriptProfile.cpp:

(WebCore::ScriptProfile::buildInspectorObjectForHead):

  • bindings/v8/ScriptProfile.h:

(ScriptProfile):

  • inspector/Inspector.json:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getCPUProfile):

9:08 AM Changeset in webkit [145818] by inferno@chromium.org
  • 88 edits in trunk/Source

Replace static_casts with to* helper functions.
https://bugs.webkit.org/show_bug.cgi?id=112296

Reviewed by Kentaro Hara.

to* helper functions are preferred over static_cast calls since they
help to catch bad casts easily on the testing infrastructure.

Source/WebCore:

  • accessibility/AXObjectCache.cpp:

(WebCore::nodeHasRole):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::hasAttribute):
(WebCore::AccessibilityObject::getAttribute):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::anchorElement):
(WebCore::AccessibilityRenderObject::helpText):
(WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
(WebCore::AccessibilityRenderObject::titleUIElement):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::accessKey):
(WebCore::AccessibilityRenderObject::setElementAttributeValue):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::activeDescendant):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
(WebCore::AccessibilityRenderObject::correspondingLabelForControlElement):
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):
(WebCore::AccessibilityRenderObject::setAccessibleName):
(WebCore::AccessibilityRenderObject::stringRoleForMSAA):

  • bindings/gobject/WebKitDOMBinding.cpp:

(WebKit::createWrapper):

  • bindings/js/JSClipboardCustom.cpp:

(WebCore::JSClipboard::setDragImage):

  • bindings/js/JSElementCustom.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::createWrapperInline):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::setDragImageMethodCustom):

  • bindings/v8/custom/V8ElementCustom.cpp:

(WebCore::wrap):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::wrap):

  • dom/Document.cpp:

(WebCore::Document::importNode):
(WebCore::Document::recalcStyle):
(WebCore::Document::setFocusedNode):
(WebCore::Document::updateFocusAppearanceTimerFired):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):

  • dom/Element.cpp:

(WebCore::Element::offsetParent):
(WebCore::Element::boundsInRootViewSpace):
(WebCore::Element::getBoundingClientRect):
(WebCore::Element::recalcStyle):
(WebCore::Element::computeInheritedLanguage):
(WebCore::Element::lastElementChild):

  • dom/LiveNodeList.cpp:

(WebCore::LiveNodeList::namedItem):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::normalize):
(WebCore::Node::rootEditableElement):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::ancestorElement):
(WebCore::appendAttributeDesc):

  • dom/Position.cpp:

(WebCore::Position::element):

  • dom/Range.cpp:

(WebCore::Range::getBorderAndTextQuads):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::queryFirst):
(WebCore::SelectorDataList::execute):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::recalcStyle):

  • dom/StaticHashSetNodeList.cpp:

(WebCore::StaticHashSetNodeList::namedItem):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
(WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
(WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):

  • editing/Editor.cpp:

(WebCore::Editor::applyEditingStyleToBodyElement):

  • editing/FrameSelection.cpp:

(WebCore::removingNodeRemovesPosition):

  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::outdentParagraph):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::entityMaskForText):
(WebCore::MarkupAccumulator::appendStartMarkup):
(WebCore::MarkupAccumulator::appendEndMarkup):

  • editing/ModifySelectionListLevel.cpp:

(WebCore::IncreaseSelectionListLevelCommand::doApply):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::haveSameTagName):
(WebCore::handleStyleSpansBeforeInsertion):
(WebCore::ReplaceSelectionCommand::doApply):

  • editing/SplitTextNodeContainingElementCommand.cpp:

(WebCore::SplitTextNodeContainingElementCommand::doApply):

  • editing/TextIterator.cpp:

(WebCore::TextIterator::advance):

  • editing/htmlediting.cpp:

(WebCore::unsplittableElementForPosition):
(WebCore::enclosingTableCell):

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::wrapWithNode):
(WebCore::createMarkupInternal):
(WebCore::createFragmentFromMarkupWithContext):
(WebCore::isPlainTextMarkup):
(WebCore::createFragmentFromText):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::insertAdjacentElement):
(WebCore::contextElementForInsertion):

  • html/HTMLFormControlElement.cpp:

(WebCore::focusPostAttach):
(WebCore::updateFromElementCallback):

  • html/HTMLFormElement.cpp:

(WebCore::submitElementFromEvent):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::updateSnapshotInfo):

  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::addRange):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::closestFormAncestor):

  • html/shadow/MediaControlElementTypes.cpp:

(WebCore::toParentMediaElement):

  • html/shadow/TextFieldDecorationElement.h:

(WebCore::toTextFieldDecorationElement):

  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::createDigest):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::didInvalidateStyleAttr):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::inlineStyleSheetText):

  • mathml/MathMLElement.h:

(WebCore::toMathMLElement):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):

  • page/DragController.cpp:

(WebCore::elementUnderMouse):
(WebCore::DragController::startDrag):

  • page/FocusController.cpp:

(WebCore::FocusController::advanceFocusInDocumentOrder):

  • page/Frame.cpp:

(WebCore::Frame::searchForLabelsBeforeElement):

  • page/FrameView.cpp:

(WebCore::FrameView::updateWidget):

  • page/SpatialNavigation.cpp:

(WebCore::rectToAbsoluteCoordinates):

  • page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::sendTransitionEvent):

  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::sendAnimationEvent):

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintMediaFullscreenButton):
(WebCore::RenderThemeEfl::paintMediaMuteButton):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter):

  • rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::calcViewport):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::getElementById):

  • svg/SVGUseElement.cpp:

(WebCore::isDisallowedElement):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::buildPendingResource):

  • xml/XPathStep.cpp:

(WebCore::XPath::nodeMatchesBasicTest):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::parseEndElement):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::setNodeFocus):
(BlackBerry::WebKit::WebPagePrivate::adjustFullScreenElementDimensionsIfNeeded):

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):

  • WebKitSupport/BackingStoreClient.cpp:

(BlackBerry::WebKit::BackingStoreClient::absoluteRect):

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::toTextControlElement):
(BlackBerry::WebKit::DOMSupport::selectionContainerElement):

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::getRelevantInfoFromCachedHitTest):
(BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::focusedNodeChanged):
(BlackBerry::WebKit::InputHandler::willOpenPopupForNode):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::elementForTapHighlight):

Source/WebKit/chromium:

  • src/WebDocument.cpp:

(WebKit::WebDocument::images):

  • src/WebElement.cpp:

(WebKit::WebElement::operator PassRefPtr<Element>):

  • src/WebPageSerializer.cpp:

(WebCore::retrieveResourcesForFrame):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setFocus):
(WebKit::WebViewImpl::clearFocusedNode):
(WebKit::WebViewImpl::scrollFocusedNodeIntoView):
(WebKit::WebViewImpl::scrollFocusedNodeIntoRect):

Source/WebKit/gtk:

  • webkit/webkitwebview.cpp:

(webkit_web_view_query_tooltip):

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.mm:

(applyAppleDictionaryApplicationQuirkNonInlinePart):

  • WebView/WebHTMLRepresentation.mm:

(searchForLabelsBeforeElement):

Source/WebKit/qt:

  • Api/qwebelement.cpp:

(QWebElement::firstChild):
(QWebElement::lastChild):
(QWebElement::nextSibling):
(QWebElement::previousSibling):
(QWebElementCollection::at):
(QWebElementCollection::toList):

  • WebCoreSupport/QWebFrameAdapter.cpp:

(QWebHitTestResultPrivate::elementForInnerNode):

Source/WebKit/win:

  • WebView.cpp:

(WebView::enterFullscreenForNode):

Source/WebKit2:

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::elementBounds):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::containsAnyFormElements):

9:02 AM Changeset in webkit [145817] by pfeldman@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed: chromium expectations updated.

  • platform/chromium/TestExpectations:
8:50 AM Changeset in webkit [145816] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: keep deprecated function stubs in InspectorFrontendHost.
https://bugs.webkit.org/show_bug.cgi?id=112347

Reviewed by Vsevolod Vlasov.

In order to open older front-ends in newer hosts, we need to keep stubs
for deprecated functions. Longer term, we need to wrap all calls to InspectorFrontendHost in the front-end.

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::canInspectWorkers):
(WebCore):
(WebCore::InspectorFrontendHost::hiddenPanels):

  • inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

  • inspector/InspectorFrontendHost.idl:
8:31 AM Changeset in webkit [145815] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Fixed styles pane visibility when docked to right.
https://bugs.webkit.org/show_bug.cgi?id=112348

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-14
Reviewed by Pavel Feldman.

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._splitVertically):

  • inspector/front-end/SidebarPane.js:

(WebInspector.SidebarPane.prototype.setExpandCallback):
(WebInspector.SidebarPaneTitle):
(WebInspector.SidebarTabbedPane.prototype.addPane):

8:25 AM Changeset in webkit [145814] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] GraphicsContext3D: implement ImageExtractor::extractImage()
https://bugs.webkit.org/show_bug.cgi?id=112242

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-14
Reviewed by Rob Buis.

In r136282 GraphicsContext3D::getImageData() was refactored in a
new class called ImageExtractor.

This patch implements the necessary changes for the BlackBerry
port, which is still using the old API.

  • platform/graphics/GraphicsContext3D.h:

(ImageExtractor):

  • platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::~ImageExtractor):
(WebCore):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

8:18 AM Changeset in webkit [145813] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Disable DRT on Windows

Reviewed by Jocelyn Turcotte.

We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.

  • qmake/mkspecs/features/configure.prf:
8:15 AM Changeset in webkit [145812] by commit-queue@webkit.org
  • 14 edits
    6 adds in trunk

[EFL][WK2] Add an API for adding and removing user style sheets from a page group
https://bugs.webkit.org/show_bug.cgi?id=110728

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-03-14
Reviewed by Gyuyoung Kim.

Source/WebKit2:

This patch implements EwkPageGroup API to provide the interface of WKPageGroup. Using the EwkPageGroup,
applications may create the views with a page group for the specific identifier. Also, this patch
encapsulates the APIs WKPageGroupAddUserStyleSheet and WKPageGroupRemoveAllUserStyleSheets behind
the EwkPageGroup class for adding and removing user style sheets from a page group. WKArrayCreateWithEinaList()
is added as a generic WKArray creation API from Eina_List.

  • PlatformEfl.cmake:
  • UIProcess/API/C/efl/WKView.cpp:

(createWKView):

  • UIProcess/API/efl/EWebKit2.h:
  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::createEvasObject):

  • UIProcess/API/efl/EwkView.h:

(EwkView::ewkPageGroup):
(EwkView):

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_smart_add):
(ewk_view_page_group_get):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::EWK2UnitTestBase::SetUp):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:

(EWK2UnitTest::EWK2UnitTestBase::setWebView):

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

Tools:

Use the page group to create the view object.

  • MiniBrowser/efl/main.c:

(window_create):

7:39 AM Changeset in webkit [145811] by commit-queue@webkit.org
  • 13 edits
    2 adds in trunk

[GStreamer] Stopping playback of html5 media when receiving a higher priority audio event needs implementation
https://bugs.webkit.org/show_bug.cgi?id=91611

Source/WebCore:

React to REQUEST_STATE GStreamer message to stop the pipeline when
a higher priority stream is played. When this happens, states are
updated accordingly.

A method was added in the MediaPlayer class and internals to allow
the the test runner to simulate an audio interruption.

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

Test: media/media-higher-prio-audio-stream.html

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore):
(MediaPlayer):
(WebCore::MediaPlayer::simulateAudioInterruption): New method
delegating an audio interruption to the private backend to
simulate the use-case where an external application needs
exclusive access to the audio device.

  • platform/graphics/MediaPlayerPrivate.h:

(MediaPlayerPrivateInterface):
(WebCore::MediaPlayerPrivateInterface::simulateAudioInterruption):
Added default empty method in the common private header.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore):
(WebCore::MediaPlayerPrivateGStreamer::createAudioSink):
(WebCore::setAudioStreamPropertiesCallback): Hooked to child-added
signal on the audio sink, delegates on setAudioStreamProperties.
(WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
Sets the audio stream properties.
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
Initializes the new attribute.
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
Disconnects autoaudiosink signal.
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
Changed logging.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Reacting to
the REQUEST_STATE message.
(WebCore::MediaPlayerPrivateGStreamer::simulateAudioInterruption):
Added. Injects the REQUEST_STATE message to the pipeline.
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Updating the
playback state if REQUEST_STATE.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer): Added new method and attribute.

  • testing/Internals.h:
  • testing/Internals.idl:
  • testing/Internals.cpp:

(WebCore):
(WebCore::Internals::simulateAudioInterruption): Added to call the
method to stop the element because of a higher prio stream at the
tests.

LayoutTests:

Created test, expected result and updated other ports
expectations.

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

  • media/media-higher-prio-audio-stream-expected.txt: Added.
  • media/media-higher-prio-audio-stream.html: Added.
  • platform/chromium/TestExpectations: Skipped the new test.
  • platform/mac/TestExpectations: Skipped the new test.
  • platform/qt/TestExpectations: Skipped the new test for Mac and

Win.

7:28 AM WebKitGTK/2.0.x edited by Philippe Normand
(diff)
7:04 AM Changeset in webkit [145810] by allan.jensen@digia.com
  • 3 edits in trunk/Source/WebCore

[Qt] Add support for tiled shadow blur
https://bugs.webkit.org/show_bug.cgi?id=90082

Reviewed by Noam Rosenthal.

Use the optimized ShadowBlur::drawRectShadow as long as we do not
have a rotating transform. Such a transform would go through the
slow path in ShadowBlur anyway, and would end up using a transformed
TransparencyLayer with an alphaMap which causes scaling artifacts
for us.

Tested by fast/canvas/canvas-scale-fillRect-shadow.html
and fast/canvas/canvas-transforms-fillRect-shadow.html

  • platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::drawInsetShadowWithTiling):

Handle scaling transforms when shadows ignore transforms.

(WebCore::ShadowBlur::drawRectShadowWithTiling):

Ditto.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::fillRect):

6:59 AM Changeset in webkit [145809] by caseq@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: do not aggregate non-main thread timeline events, handle them in a generic fashion
https://bugs.webkit.org/show_bug.cgi?id=112172

Reviewed by Vsevolod Vlasov.

  • build nested event trees for non-main thread events similar to how it's done on the main thread;
  • drop aggregation logic for Rasterize events;
  • extract time conversion logic so that it may be reused in TimelineTraceEventProcessor.
  • English.lproj/localizedStrings.js: drive-by: drop duplicate line.
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::TimelineTimeConverter::reset):
(WebCore):
(WebCore::InspectorTimelineAgent::pushGCEventRecords):
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::sendEvent):
(WebCore::InspectorTimelineAgent::timestamp):

  • inspector/InspectorTimelineAgent.h:

(TimelineTimeConverter):
(WebCore::TimelineTimeConverter::TimelineTimeConverter):
(WebCore::TimelineTimeConverter::fromMonotonicallyIncreasingTime):
(WebCore):
(InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::timeConverter):

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createBackgroundRecord):
(WebCore):

  • inspector/TimelineRecordFactory.h:

(TimelineRecordFactory):

  • inspector/TimelineTraceEventProcessor.cpp:

(WebCore::TimelineRecordStack::TimelineRecordStack):
(WebCore):
(WebCore::TimelineRecordStack::addScopedRecord):
(WebCore::TimelineRecordStack::closeScopedRecord):
(WebCore::TimelineRecordStack::addInstantRecord):
(WebCore::TimelineRecordStack::isOpenRecordOfType):
(WebCore::TimelineRecordStack::send):
(WebCore::TimelineTraceEventProcessor::TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::onBeginFrame):
(WebCore::TimelineTraceEventProcessor::onRasterTaskBegin):
(WebCore::TimelineTraceEventProcessor::onRasterTaskEnd):
(WebCore::TimelineTraceEventProcessor::createRecord):

  • inspector/TimelineTraceEventProcessor.h:

(TimelineRecordStack):
(WebCore::TimelineRecordStack::Entry::Entry):
(Entry):
(WebCore::TimelineRecordStack::TimelineRecordStack):
(WebCore):
(WebCore::TimelineTraceEventProcessor::TimelineThreadState::TimelineThreadState):
(TimelineThreadState):
(TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::TraceEvent::TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::isNull):
(WebCore::TimelineTraceEventProcessor::threadState):

6:56 AM Changeset in webkit [145808] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Wrong ASSERT in AudioDestinationGstreamer::stop
https://bugs.webkit.org/show_bug.cgi?id=112344

Patch by Xan Lopez <xlopez@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

Correct erroneous ASSERT, we want both member variables to exist.

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::stop):

6:36 AM Changeset in webkit [145807] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Support scroll and zoom with help of mouse wheel.
https://bugs.webkit.org/show_bug.cgi?id=112337

Reviewed by Yury Semikhatsky.

New member variable _xOffset were introduced.

  • inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype._adjustXOffset):
(WebInspector.FlameChart.prototype._adjustXScale):
(WebInspector.FlameChart.prototype._onMouseWheel):
(WebInspector.FlameChart.prototype._coordinatesToNodeIndex):
(WebInspector.FlameChart.prototype.onResize):
(WebInspector.FlameChart.prototype.draw):
(WebInspector.FlameChart.prototype._scheduleUpdate):
(WebInspector.FlameChart.prototype.update):

5:58 AM BadContent edited by zandobersek@gmail.com
Blacklist a spamming account. (diff)
5:29 AM Changeset in webkit [145806] by kbalazs@webkit.org
  • 3 edits in trunk/Source/WebCore

[Texmap] Synchronize layers only if the layer has been changed.
https://bugs.webkit.org/show_bug.cgi?id=112095

Patch by No'am Rosenthal <Noam Rosenthal> on 2013-03-14
Reviewed by Allan Sandfeld Jensen.

A regression was introduced in r144787, causing an infinite IPC commitState/renderNextFrame
loop.
This patch fixes this by making sure we only commit layer states that have actual pending
changes.

No new tests, this is an optimization.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:

(CoordinatedGraphicsLayerState):
(WebCore::CoordinatedGraphicsLayerState::hasPendingChanges):

4:52 AM Changeset in webkit [145805] by Simon Hausmann
  • 23 edits in trunk

[Qt] Improve the handling of mock geolocation, device orientation and motion clients

Reviewed by Tor Arne Vestbø.

The mock versions of these web facing features should be instantiated when
running in DumpRenderTree only. In order for them to work, no extra Qt modules
such as QtLocation are actually needed.

This patch decouples enabling device orientation/motion and geolocation from
the underlying Qt modules and makes them available in developer builds
(!production_build) and backed by mock backends when running in drt.

So if the Qt 5 modules are available, they'll be used (unless drtRun). For
developers the web facing features are always enabled (although requests will
time out) and the mock backends are enabled inside DRT, allowing for the layout
tests to run with less dependencies.

In addition this also enables the mock device motion client, which was
previously never instantiated.

.:

  • Source/widgetsapi.pri:

Source/WebCore:

  • Target.pri:
  • WebCore.pri:

Source/WebKit:

  • WebKit1.pri:
  • WebKit1.pro:

Source/WebKit/qt:

  • WebCoreSupport/QWebFrameAdapter.cpp:

(QWebFrameAdapter::_q_orientationChanged):

  • WebCoreSupport/QWebFrameAdapter.h:
  • WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::initializeWebCorePage):

  • WebCoreSupport/QWebPageAdapter.h:
  • WidgetApi/qwebframe.cpp:

(QWebFrame::QWebFrame):

  • WidgetApi/qwebpage.cpp:

(QWebPage::setFeaturePermission):

Source/WebKit2:

  • Target.pri:
  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

  • UIProcess/qt/WebGeolocationProviderQt.cpp:
  • WebKit2.pri:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

Tools:

  • qmake/mkspecs/features/features.prf:
4:46 AM Changeset in webkit [145804] by zeno.albisser@digia.com
  • 4 edits in trunk/Tools

[Qt] Removing no-ops and simple setters/getters from TestRunnerQt
https://bugs.webkit.org/show_bug.cgi?id=112340

Reviewed by Simon Hausmann.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(DumpRenderTree::dump):

Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().

(DumpRenderTree::dumpApplicationCacheQuota):

  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunnerQt::reset):

  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

4:26 AM Changeset in webkit [145803] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[TexMap] Painting into area of composited tile not cleared
https://bugs.webkit.org/show_bug.cgi?id=112268

Reviewed by Kenneth Rohde Christiansen.

Clip painting to the area that has been cleared, so we
do not accidentally overpaint other areas.

Can be observed in ManualTests/scrollbars/scrollbars-in-composited-layers.html.

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::updateContents):

4:12 AM Changeset in webkit [145802] by commit-queue@webkit.org
  • 64 edits in trunk/Source

[V8] Store main world and non-main world templates separately.
https://bugs.webkit.org/show_bug.cgi?id=111724

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-14
Reviewed by Jochen Eisinger.

This is needed for generating specialized bindings for the main
world (bug 110874).

Source/WebCore:

No new tests (updated existing bindings tests).

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
(GenerateImplementation):
(JSValueToNative):
(CreateCustomSignature):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooMethod):
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionMethod):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::dispatchEventMethod):
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):

  • bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Method):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):

  • bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsMethod):
(WebCore::TestObjV8Internal::longMethodWithArgsMethod):
(WebCore::TestObjV8Internal::objMethodWithArgsMethod):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsMethod):
(WebCore::TestObjV8Internal::overloadedMethod1Method):
(WebCore::TestObjV8Internal::overloadedMethod2Method):
(WebCore::TestObjV8Internal::overloadedMethod8Method):
(WebCore::TestObjV8Internal::overloadedMethodMethod):
(WebCore::TestObjV8Internal::convert1Method):
(WebCore::TestObjV8Internal::convert2Method):
(WebCore::TestObjV8Internal::convert4Method):
(WebCore::TestObjV8Internal::convert5Method):
(WebCore::TestObjV8Internal::variadicNodeMethodMethod):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::TestOverloadedConstructorsV8Internal::constructor1):
(WebCore::TestOverloadedConstructorsV8Internal::constructor2):
(WebCore::TestOverloadedConstructorsV8Internal::constructor3):
(WebCore::TestOverloadedConstructorsV8Internal::constructor):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

  • bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::funcMethod):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):

  • bindings/scripts/test/V8/V8TestTypedefs.h:

(V8TestTypedefs):

  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::visitNodeWrappers):

  • bindings/v8/SerializedScriptValue.cpp:
  • bindings/v8/V8AdaptorFunction.cpp:

(WebCore::V8AdaptorFunction::getTemplate):

  • bindings/v8/V8Binding.cpp:

(WebCore::toDOMStringList):
(WebCore::toXPathNSResolver):

  • bindings/v8/V8Binding.h:

(WebCore):
(WebCore::toRefPtrNativeArray):

  • bindings/v8/V8Collection.cpp:

(WebCore::toOptionsCollectionSetter):

  • bindings/v8/V8GCController.cpp:
  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):
(WebCore::V8PerIsolateData::hasPrivateTemplate):
(WebCore::V8PerIsolateData::privateTemplate):
(WebCore::V8PerIsolateData::rawTemplate):
(WebCore::V8PerIsolateData::hasInstance):

  • bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::rawTemplateMap):
(V8PerIsolateData):
(WebCore::V8PerIsolateData::templateMap):

  • bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):

  • bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAttrSetterCustom):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCustom):

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toCanvasStyle):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::setDragImageMethodCustom):

  • bindings/v8/custom/V8CryptoCustom.cpp:

(WebCore::V8Crypto::getRandomValuesMethodCustom):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCustom):
(WebCore::V8DOMFormData::appendMethodCustom):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCustom):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateMethodCustom):

  • bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAttrSetterCustom):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::addMethodCustom):

  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::removeElement):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::isHTMLAllCollectionMethodCustom):
(WebCore::V8InjectedScriptHost::typeMethodCustom):
(WebCore::V8InjectedScriptHost::getEventListenersMethodCustom):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::removeChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::opaqueRootForGC):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toWebGLUniformLocation):
(WebCore::V8WebGLRenderingContext::getAttachedShadersMethodCustom):
(WebCore::V8WebGLRenderingContext::getProgramParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getShaderParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getUniformMethodCustom):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::isDocumentType):
(WebCore::V8XMLHttpRequest::sendMethodCustom):

Source/WebKit/chromium:

  • src/WebArrayBuffer.cpp:

(WebKit::WebArrayBuffer::createFromV8Value):

  • src/WebArrayBufferView.cpp:

(WebKit::WebArrayBufferView::createFromV8Value):

  • src/WebBindings.cpp:

(WebKit::getRangeImpl):
(WebKit::getNodeImpl):
(WebKit::getElementImpl):
(WebKit::getArrayBufferImpl):
(WebKit::getArrayBufferViewImpl):

3:51 AM Changeset in webkit [145801] by mkwst@chromium.org
  • 3 edits in trunk/Source/WebCore

Explicitly send only one report via XSSAuditorDelegate.
https://bugs.webkit.org/show_bug.cgi?id=111964

Reviewed by Adam Barth.

This patch pulls the XSSAuditor report generation out into a separate
function in XSSAuditorDelegate::generateViolationReport, and moves the
call to that function into the "have we already notified folks about
violations on this page?" block. This both clarifies the flow in
XSSAuditorDelegate::didBlockScript, and ensures that only one violation
report will be sent per page, which regressed in r145695.

Existing tests verify that reports are generated and sent correctly.

We have no tests for the latter condition: the XSSAuditor tests
currently verify that a report showed up, but they can't verify that
no report appeared without sitting around for a few more than a few
seconds on every run.

  • html/parser/XSSAuditorDelegate.cpp:

(WebCore::XSSAuditorDelegate::generateViolationReport):

Pull the report generation logic out to this new function.

(WebCore::XSSAuditorDelegate::didBlockScript):

Move the report generation call into the block that ensures it only
executes for the first violation.

3:07 AM Changeset in webkit [145800] by zeno.albisser@digia.com
  • 4 edits in trunk/Tools

[Qt] Port DRT to use TestRunner::dumpAsText()
https://bugs.webkit.org/show_bug.cgi?id=112260

Reviewed by Benjamin Poulain.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::open):
(WebCore::methodNameStringForFailedTest):

Change parameter from type TestRunnerQt* to TestRunner*.

(WebCore::DumpRenderTree::dump):

TestRunnerQt::shouldDumpPixels() always returned true in our case.
Instead we should rely on TestRunner::generatePixelResults().

  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunnerQt::reset):

  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

2:49 AM Changeset in webkit [145799] by zarvai@inf.u-szeged.hu
  • 3 edits
    1 delete in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk1/TestExpectations: Skip failing tests after r145784.
  • platform/qt-5.0-wk2/fast/repaint/focus-ring-expected.txt: Removed.
  • platform/qt/fast/repaint/focus-ring-expected.txt: Rebaselining after r145708.
2:43 AM Changeset in webkit [145798] by sergio@webkit.org
  • 15 edits
    1 move
    4 adds
    1 delete in trunk

Empty list items after drag&drop in contentEditable divs
https://bugs.webkit.org/show_bug.cgi?id=110610

Reviewed by Ryosuke Niwa.

Source/WebCore:

Perform a cleanup after moving operations. This will mainly prune
extra placeholders left by the editing algorithms. Also do not
leave empty <li> when moving them around inside a list element.

Tests: editing/pasteboard/cleanup-on-move.html

editing/pasteboard/drag-list-item.html

  • editing/MoveSelectionCommand.cpp:

(WebCore::MoveSelectionCommand::doApply): perform
cleanupAfterDeletion().

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::insertAsListItems): do not
insert an empty list item.

  • editing/MoveSelectionCommand.cpp:

(WebCore::MoveSelectionCommand::doApply):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::insertAsListItems):

LayoutTests:

Some placeholders should not be left after performing a cleanup in
move operations, this includes the empty list items generated when
moving around list items inside a list.

I'm also moving drag-list-item.html to editing/pasteboard because
it fits much better there than under editing/selection.

  • editing/pasteboard/cleanup-on-move-expected.txt: Added.
  • editing/pasteboard/cleanup-on-move.html: Added.
  • editing/pasteboard/drag-list-item-expected.txt: Renamed from LayoutTests/editing/selection/drag-list-item-expected.txt.
  • editing/pasteboard/drag-list-item.html: Renamed from LayoutTests/editing/selection/drag-list-item.html.
  • editing/pasteboard/resources/select-and-drag.js: Added.

(selectAndDragToTarget): Selects nodes and drops them after a target node.

  • editing/pasteboard/drag-drop-list-expected.txt: Removed an empty <li>.
  • editing/pasteboard/paste-list-004-expected.txt: Removed 2 empty <li>.
  • editing/pasteboard/paste-list-004.html: Ditto.
  • editing/selection/4895428-1-expected.txt: Removed a <br>.
  • editing/selection/4895428-4-expected.txt: Ditto.
  • fast/events/ondragenter-expected.txt: Removed a blank line.
  • platform/chromium/fast/events/ondragenter-expected.txt: Ditto.
  • platform/efl/TestExpectations: Added cleanup-on-move.html to the skipped list.
  • platform/mac-wk2/TestExpectations: Ditto.
  • platform/qt/TestExpectations: Ditto.
  • platform/win/fast/events/ondragenter-expected.txt: Removed a blank line.
2:25 AM Changeset in webkit [145797] by eric@webkit.org
  • 11 edits
    5 adds in trunk

Threaded HTML Parser should limit speculation to avoid using too much memory
https://bugs.webkit.org/show_bug.cgi?id=112069

Reviewed by Adam Barth.

Source/WebCore:

This is a speculative fix for memory issues seen in:
https://code.google.com/p/chromium/issues/detail?id=180819

This also fixed https://bugs.webkit.org/show_bug.cgi?id=110546
as a side-effect of simplifying the m_currentChunk handling.

We now tell the background html parser every time we start
a chunk on the main thread (instead of end), which greatly
simplified the checkpoint cleanup code from:
https://trac.webkit.org/changeset/145277

The cost for this is now we have more messages going to the
background thread (and postTask acquires a lock to write to the
message queue). Chromium has more advanced (lock-less) primatives
for message posting, which we'll hopefully add to WebKit in
furture patches.

The outstanding chunks limit has not been tuned. But it makes sense that
we should not keeping infinite speculative tokens around for
large documents with slow-to-load scripts.

  • html/parser/BackgroundHTMLInputStream.cpp:

(WebCore::BackgroundHTMLInputStream::BackgroundHTMLInputStream):
(WebCore::BackgroundHTMLInputStream::invalidateCheckpointsBefore):
(WebCore):
(WebCore::BackgroundHTMLInputStream::rewindTo):

  • html/parser/BackgroundHTMLInputStream.h:

(BackgroundHTMLInputStream):
(WebCore::BackgroundHTMLInputStream::outstandingCheckpointCount):
(Checkpoint):
(WebCore::BackgroundHTMLInputStream::Checkpoint::isNull):
(WebCore::BackgroundHTMLInputStream::Checkpoint::clear):

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore):
(WebCore::BackgroundHTMLParser::startedChunkWithCheckpoint):
(WebCore::BackgroundHTMLParser::pumpTokenizer):

  • html/parser/BackgroundHTMLParser.h:

(BackgroundHTMLParser):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::validateSpeculations):
(WebCore::HTMLDocumentParser::discardSpeculationsAndResumeFrom):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):

  • html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):

LayoutTests:

Test that this fixes https://bugs.webkit.org/show_bug.cgi?id=110546 for the threaded parser.
Ports using the main-thread parser are expected to fail (ASSERT in Debug).

  • fast/parser/document-write-partial-entity-before-load-expected.txt: Added.
  • fast/parser/document-write-partial-entity-before-load.html: Added.
  • fast/parser/external-script-document-write-expected.txt: Added.
  • fast/parser/external-script-document-write.html: Added.
  • fast/parser/resources/external-script-document-write.js: Added.
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
2:00 AM Changeset in webkit [145796] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Minor changes for the popover.
https://bugs.webkit.org/show_bug.cgi?id=112331

Reviewed by Yury Semikhatsky.

popover timeout needs to be decreased a bit.
hidePopover call in onMouseMove doesn't necessary.
We have to keep anchor element unmodified if the hovered item didn't changed.

  • inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._onMouseMove):

1:57 AM Changeset in webkit [145795] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Fix detection of Intel Mac OS X platform on Intel Mac 64-bit
https://bugs.webkit.org/show_bug.cgi?id=112312

Patch by Jonathan Liu <net147@gmail.com> on 2013-03-14
Reviewed by Simon Hausmann.

Source/WebCore:

  • platform/gtk/UserAgentGtk.cpp:

(WebCore::platformVersionForUAString):

Source/WebKit/efl:

  • ewk/ewk_settings.cpp:

(_ewk_settings_webkit_os_version_get):

Source/WebKit/wx:

  • WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::agentOS):

1:38 AM Changeset in webkit [145794] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Layout Test plugins/plugin-clip-subframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=111514

Patch by John Bauman <jbauman@chromium.org> on 2013-03-14
Reviewed by Ryosuke Niwa.

Rebaseline test result due to chromium r185729. Also try to force
layout in test to prevent flakiness on win-dbg.

  • platform/chromium-mac/plugins/plugin-clip-subframe-expected.txt:
  • platform/chromium/TestExpectations:
  • plugins/plugin-clip-subframe.html:
1:37 AM Changeset in webkit [145793] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Adding a couple of failure expectations for flaky
tests on the debug builder.

  • platform/gtk/TestExpectations:
1:18 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
1:16 AM Changeset in webkit [145792] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] InRegionScrollableArea: fix call to visibleContentRect()
https://bugs.webkit.org/show_bug.cgi?id=112244

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-14
Reviewed by Rob Buis.

Since r143295 visibleContentRect() receives an enum, not a boolean.

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

12:50 AM Changeset in webkit [145791] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

[GTK] The style of visited links doesn't change in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112175

Reviewed by Martin Robinson.

The problem is that visited links were not tracked by the web
process. There's a web process initial parameter to set whether
web process should track visited links or not and it's disabled by
default.

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformInitializeWebProcess): Always set
shouldTrackVisitedLinks to true.

12:38 AM Changeset in webkit [145790] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Rewrite drawing procedure for better performance.
https://bugs.webkit.org/show_bug.cgi?id=112264

Reviewed by Yury Semikhatsky.

I traverses the profile tree in calculateTimelineData and calculates all the sizes and colors.
Later in draw code we lineary pass the array and draw items.
Also we could easily swap to another format of the profile.

  • inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._nodeCount):
(WebInspector.FlameChart.prototype._calculateTimelineData.appendReversedArray):
(WebInspector.FlameChart.prototype._calculateTimelineData):
(WebInspector.FlameChart.prototype._getPopoverAnchor):
(WebInspector.FlameChart.prototype._showPopover):
(WebInspector.FlameChart.prototype._hidePopover):
(WebInspector.FlameChart.prototype._onClick):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype._coordinatesToNodeIndex):
(WebInspector.FlameChart.prototype.onResize):
(WebInspector.FlameChart.prototype.draw):

12:30 AM Changeset in webkit [145789] by alice.liu@apple.com
  • 17 edits in trunk/Source

Add to HistoryItem a way to know if its underlying CachedPage has expired.
https://bugs.webkit.org/show_bug.cgi?id=110652

Reviewed by Brady Eidson.

Source/WebCore:

  • WebCore.exp.in: Added WebCore::HistoryItem::isInPageCache and hasCachedPageExpired.
  • history/CachedPage.cpp: Add a data member, m_expirationTime, and a function, hasExpired().
  • history/CachedPage.h:
  • history/HistoryItem.cpp:

(WebCore::HistoryItem::hasCachedPageExpired): Added. returns m_cachedPage's expiration state.

  • history/HistoryItem.h:
  • history/PageCache.cpp:

(WebCore::PageCache::get): Address the fixme about not using WebKitBackForwardCacheExpirationIntervalKey.

  • page/Settings.in: Add backForwardCacheExpirationInterval to the automatically generated setters for Settings.

Source/WebKit/mac:

  • History/WebHistoryItem.mm:

(-[WebHistoryItem _isInPageCache]): Added. Just calls and returns core imple's function.
(-[WebHistoryItem _hasCachedPageExpired]): Same thing.

  • History/WebHistoryItemPrivate.h:
  • WebView/WebPreferences.mm:

(-[WebPreferences _backForwardCacheExpirationInterval]): Address fixme, now that WebCore::Settings
has getters and setters with default value.

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): call setBackForwardCacheExpirationInterval similar to other settings.

Source/WebKit2:

Hook up hasCachedPageExpired in InjectedBundle's BackForwardListItem.

  • WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp:

(WKBundleBackForwardListItemHasCachedPageExpired):

  • WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.h:
  • WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:

(WebKit::InjectedBundleBackForwardListItem::hasCachedPageExpired):

Note: See TracTimeline for information about the timeline view.