Timeline
Mar 20, 2013:
- 11:35 PM Changeset in webkit [146441] by
-
- 165 edits21 adds18 deletes in trunk/LayoutTests
[chromium] Rebaseline most "needs rebaseline" sections of Chromium test expectations, and fix a few other wrong expectations.
https://bugs.webkit.org/show_bug.cgi?id=11645
https://bugs.webkit.org/show_bug.cgi?id=89826
https://bugs.webkit.org/show_bug.cgi?id=96597
https://bugs.webkit.org/show_bug.cgi?id=97325
https://bugs.webkit.org/show_bug.cgi?id=101396
https://bugs.webkit.org/show_bug.cgi?id=102624
https://bugs.webkit.org/show_bug.cgi?id=103149
https://bugs.webkit.org/show_bug.cgi?id=106746
https://bugs.webkit.org/show_bug.cgi?id=107339
https://bugs.webkit.org/show_bug.cgi?id=109439
https://bugs.webkit.org/show_bug.cgi?id=110654
https://bugs.webkit.org/show_bug.cgi?id=111319
https://bugs.webkit.org/show_bug.cgi?id=112755
http://crbug.com/67416
http://crbug.com/148638
Unreviewed, test expectations update.
- css2.1/20110323/replaced-elements-001-expected.txt: Removed.
- fast/css/empty-generated-content-expected.txt: Added.
- fast/css/word-space-extra-expected.txt: Added.
- fast/table/025-expected.txt: Added.
- platform/chromium-linux-x86/css3/masking: Added.
- platform/chromium-linux-x86/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
- platform/chromium-linux-x86/fast/forms/date: Removed.
- platform/chromium-linux-x86/fast/forms/time: Removed.
- platform/chromium-linux-x86/platform/chromium/fast: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Removed.
- platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Removed.
- platform/chromium-linux/css3/masking/clip-path-circle-relative-overflow-expected.png:
- platform/chromium-linux/fast/css/word-space-extra-expected.txt: Removed.
- platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-lion/css2.1/20110323/replaced-elements-001-expected.png:
- platform/chromium-mac-lion/css3/masking: Added.
- platform/chromium-mac-lion/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
- platform/chromium-mac-lion/fast/css/word-space-extra-expected.png: Added.
- platform/chromium-mac-lion/fast/multicol/vertical-rl/float-multicol-expected.png:
- platform/chromium-mac-lion/fast/table/025-expected.png: Added.
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-snowleopard/css2.1/20110323/replaced-elements-001-expected.png:
- platform/chromium-mac-snowleopard/css3/masking: Added.
- platform/chromium-mac-snowleopard/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/word-space-extra-expected.png:
- platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/float-multicol-expected.png:
- platform/chromium-mac-snowleopard/fast/table/025-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac/css2.1/20110323/replaced-elements-001-expected.png:
- platform/chromium-mac/css3/masking/clip-path-circle-relative-overflow-expected.png:
- platform/chromium-mac/fast/css/word-space-extra-expected.png:
- platform/chromium-mac/fast/css/word-space-extra-expected.txt: Removed.
- platform/chromium-mac/fast/multicol/vertical-rl/float-multicol-expected.png:
- platform/chromium-mac/fast/table/025-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win-xp/css3/masking: Added.
- platform/chromium-win-xp/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Removed.
- platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Removed.
- platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.png:
- platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.txt:
- platform/chromium-win/css3/masking/clip-path-circle-relative-overflow-expected.png:
- platform/chromium-win/fast/css/empty-generated-content-expected.txt:
- platform/chromium-win/fast/css/word-space-extra-expected.png:
- platform/chromium-win/fast/css/word-space-extra-expected.txt:
- platform/chromium-win/fast/events/stopPropagation-submit-expected.txt: Added.
- platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
- platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.txt:
- platform/chromium-win-xp/css2.1/20110323/replaced-elements-001-expected.png: Added.
- platform/chromium/TestExpectations:
- platform/chromium/css3/filters/filter-property-parsing-expected.txt: Replaced.
- platform/chromium/fast/css/empty-generated-content-expected.txt: Removed.
- platform/chromium/fast/table/025-expected.txt: Removed.
- platform/mac/css2.1/20110323/replaced-elements-001-expected.txt: Removed.
- platform/mac/fast/css/empty-generated-content-expected.txt: Removed.
- platform/mac/fast/css/word-space-extra-expected.txt: Removed.
- platform/mac/fast/table/025-expected.txt: Removed.
- platform/win-future/css2.1: Added.
- platform/win-future/css2.1/20110323: Added.
- platform/win-future/css2.1/20110323/replaced-elements-001-expected.txt: Added.
- platform/win/fast/css/empty-generated-content-expected.txt: Removed.
- 11:22 PM Changeset in webkit [146440] by
-
- 2 edits in trunk/LayoutTests
Add a flaky crash test expectation per bug 112881.
- platform/win/TestExpectations:
- 11:16 PM Changeset in webkit [146439] by
-
- 11 edits5 moves1 add1 delete in trunk/Tools
[chromium] move WebThemeEngine implementations to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=112751
Reviewed by Adam Barth.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebKit):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::themeEngine):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(WebKit):
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::themeEngine):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
(WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
(WebTestRunner):
(WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
(WebTestRunner::WebTestThemeControlWin::box):
(WebTestRunner::WebTestThemeControlWin::line):
(WebTestRunner::WebTestThemeControlWin::triangle):
(WebTestRunner::WebTestThemeControlWin::roundRect):
(WebTestRunner::WebTestThemeControlWin::oval):
(WebTestRunner::WebTestThemeControlWin::circle):
(WebTestRunner::WebTestThemeControlWin::nestedBoxes):
(WebTestRunner::WebTestThemeControlWin::markState):
(WebTestRunner::WebTestThemeControlWin::draw):
(WebTestRunner::WebTestThemeControlWin::drawTextField):
(WebTestRunner::WebTestThemeControlWin::drawProgressBar):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
(WebTestRunner):
(WebTestThemeControlWin):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
(WebTestRunner):
(WebTestThemeEngineMac):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
(+[FakeActiveWindow alwaysActiveWindow]):
(+[FakeActiveWindow alwaysInactiveWindow]):
(-[FakeActiveWindow initWithActiveControls:]):
(-[FakeActiveWindow _hasActiveControls]):
(WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
(WebTestRunner):
(WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
(WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
(WebTestRunner::WebTestThemeEngineWin::paintButton):
(WebTestRunner):
(WebTestRunner::WebTestThemeEngineWin::paintMenuList):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
(WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
(WebTestRunner::WebTestThemeEngineWin::paintTextField):
(WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
(WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
(WebTestRunner::WebTestThemeEngineWin::getSize):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
(WebTestRunner):
(WebTestThemeEngineWin):
(WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
- DumpRenderTree/chromium/TestShell.h:
(WebKit):
- DumpRenderTree/chromium/TestShellMac.mm:
(platformInit):
- DumpRenderTree/chromium/TestShellWin.cpp:
(platformInit):
- DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
- 10:59 PM Changeset in webkit [146438] by
-
- 5 edits in trunk/Source/WebCore
Make GraphicsLayerCA::backingStoreMemoryEstimate() give a better estimate for tiled layers
https://bugs.webkit.org/show_bug.cgi?id=112864
Reviewed by Tim Horton.
If a GraphicsLayerCA has TiledBacking, ask the TiledBacking how
much memory it's using for tiles, rather than just using
height * width * 4.
Implement retainedTileBackingStoreMemory() in the TileController,
summing the memory used by parented tiles.
The original code was incorrectly multiplying by contentsScale
only once rather than twice (2x contents scale uses 4x as much memory).
- platform/graphics/TiledBacking.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::backingStoreMemoryEstimate):
- platform/graphics/ca/mac/TileController.h:
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::retainedTileBackingStoreMemory):
- 10:53 PM Changeset in webkit [146437] by
-
- 65 edits1 delete in trunk/LayoutTests
[Chromium] Test expectation update for r145055
https://bugs.webkit.org/show_bug.cgi?id=111319
- platform/chromium-linux-x86/fast/forms/time/time-appearance-pseudo-elements-expected.png: Removed.
- platform/chromium-linux/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-linux/fast/forms/date/date-appearance-l10n-expected.png:
- platform/chromium-linux/fast/forms/date/date-appearance-pseudo-elements-expected.png:
- platform/chromium-linux/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
- platform/chromium-linux/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
- platform/chromium-linux/fast/forms/month/month-appearance-basic-expected.png:
- platform/chromium-linux/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-linux/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-linux/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium-linux/fast/forms/time/time-appearance-pseudo-elements-expected.png:
- platform/chromium-linux/fast/forms/week/week-appearance-basic-expected.png:
- platform/chromium-linux/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-mac-lion/fast/forms/date/date-appearance-l10n-expected.png:
- platform/chromium-mac-lion/fast/forms/date/date-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
- platform/chromium-mac-lion/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
- platform/chromium-mac-lion/fast/forms/month/month-appearance-basic-expected.png:
- platform/chromium-mac-lion/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium-mac-lion/fast/forms/time/time-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-lion/fast/forms/week/week-appearance-basic-expected.png:
- platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-l10n-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-pseudo-elements-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-l10n-expected.png:
- platform/chromium-mac/fast/forms/date/date-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
- platform/chromium-mac/fast/forms/month/month-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-mac/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/time/time-appearance-pseudo-elements-expected.png:
- platform/chromium-mac/fast/forms/week/week-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium-win-xp/fast/forms/date/date-appearance-l10n-expected.png:
- platform/chromium-win-xp/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
- platform/chromium-win-xp/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-win/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/date/date-appearance-l10n-expected.png:
- platform/chromium-win/fast/forms/date/date-appearance-pseudo-elements-expected.png:
- platform/chromium-win/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
- platform/chromium-win/fast/forms/month/month-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/month/month-appearance-l10n-expected.png:
- platform/chromium-win/fast/forms/month/month-appearance-pseudo-elements-expected.png:
- platform/chromium-win/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/time/time-appearance-pseudo-elements-expected.png:
- platform/chromium-win/fast/forms/week/week-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/week/week-appearance-pseudo-elements-expected.png:
- platform/chromium/TestExpectations:
- 10:48 PM WebKit Team edited by
- (diff)
- 9:57 PM Changeset in webkit [146436] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r189497. Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20
- DEPS:
- 9:05 PM Changeset in webkit [146435] by
-
- 2 edits2 adds in trunk/LayoutTests
[chromium] Test expectations updates, and rebaseline to parallel r143389.
https://bugs.webkit.org/show_bug.cgi?id=62754
https://bugs.webkit.org/show_bug.cgi?id=99984
https://bugs.webkit.org/show_bug.cgi?id=111004
https://bugs.webkit.org/show_bug.cgi?id=112288
https://bugs.webkit.org/show_bug.cgi?id=112755
Unreviewed, test expectations updates.
- platform/chromium-win/svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
- platform/chromium-win/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
- platform/chromium/TestExpectations:
- 8:43 PM Changeset in webkit [146434] by
-
- 6 edits8 adds in trunk/LayoutTests
Rebaseline some of my recent test changes
https://bugs.webkit.org/show_bug.cgi?id=112843
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-20
Reviewed by Ojan Vafai.
- platform/chromium-mac-lion/css3/flexbox/button-expected.png: Added.
- platform/chromium-mac-lion/fast/forms/color/input-appearance-color-expected.png:
- platform/chromium-mac-snowleopard/css3/flexbox/button-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/forms/color/input-appearance-color-expected.png:
- platform/chromium-mac/css3/flexbox/button-expected.png: Added.
- platform/chromium-mac/css3/flexbox/button-expected.txt: Added.
- platform/chromium-mac/fast/forms/color/input-appearance-color-expected.png:
- platform/chromium-mac/fast/forms/color/input-appearance-color-expected.txt:
- platform/chromium-win/css3/flexbox/button-expected.png: Added.
- platform/chromium-win/css3/flexbox/button-expected.txt: Added.
- platform/chromium/TestExpectations:
- 8:35 PM Changeset in webkit [146433] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r146418.
http://trac.webkit.org/changeset/146418
https://bugs.webkit.org/show_bug.cgi?id=112872
It turns out that these sub pixel tests still do fail on Mac
(Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20
- platform/mac/TestExpectations:
- 7:47 PM Changeset in webkit [146432] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Remove test cases which need to do rebaseline in EFL TestExpectations.
- platform/efl/TestExpectations:
- 7:43 PM Changeset in webkit [146431] by
-
- 10 edits1 delete in trunk/Source
Unreviewed, rolling out r146419.
http://trac.webkit.org/changeset/146419
https://bugs.webkit.org/show_bug.cgi?id=112870
Broke many tests on debug builds (Requested by rniwa_ on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20
Source/WebCore:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/scripts/action_makenames.py:
(main):
- bindings/scripts/StaticString.pm: Removed.
- dom/QualifiedName.cpp:
(WebCore::createQualifiedName):
- dom/QualifiedName.h:
(WebCore):
- dom/make_names.pl:
(printNamesCppFile):
(printDefinitions):
Source/WTF:
- wtf/text/StringImpl.h:
(StringImpl):
- 7:42 PM Changeset in webkit [146430] by
-
- 14 edits1 delete in trunk
[JSC] Implement EnforceRange IDL attribute for integer conversions
https://bugs.webkit.org/show_bug.cgi?id=112506
Patch by Michael Pruett <michael@68k.org> on 2013-03-20
Reviewed by Kentaro Hara.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
Implement the EnforceRange attribute for JSC bindings.
The EnforceRange attribute requires a type error to be thrown when
converting an ECMAScript number which is beyond the representable
range of the IDL integer type.
Tests: fast/js/webidl-type-mapping.html
storage/indexeddb/cursor-advance-workers.html
storage/indexeddb/cursor-advance.html
storage/indexeddb/intversion-bad-parameters.html
- WebCore.exp.in:
- bindings/js/JSDOMBinding.cpp:
(WebCore):
(WebCore::enforceRange):
(WebCore::toInt32EnforceRange):
(WebCore::toUInt32EnforceRange):
(WebCore::toInt64):
(WebCore::toUInt64):
- bindings/js/JSDOMBinding.h:
(WebCore::toInt32):
(WebCore):
(WebCore::toUInt32):
- bindings/scripts/CodeGeneratorJS.pm:
(JSValueToNative):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetPrototypeFunctionItem):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
(WebCore::setJSTestObjLongAttr):
(WebCore::setJSTestObjLongLongAttr):
(WebCore::setJSTestObjUnsignedLongLongAttr):
(WebCore::setJSTestObjReflectedIntegralAttr):
(WebCore::setJSTestObjReflectedUnsignedIntegralAttr):
(WebCore::setJSTestObjReflectedCustomIntegralAttr):
(WebCore::setJSTestObjAttrWithGetterException):
(WebCore::setJSTestObjAttrWithSetterException):
(WebCore::setJSTestObjWithScriptStateAttribute):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):
(WebCore::setJSTestObjStrawberry):
(WebCore::setJSTestObjId):
(WebCore::setJSTestObjNullableLongSettableAttribute):
(WebCore::setJSTestObjNullableStringValue):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionLongMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::setJSTestTypedefsUnsignedLongLongAttr):
(WebCore::setJSTestTypedefsAttrWithGetterException):
(WebCore::setJSTestTypedefsAttrWithSetterException):
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
LayoutTests:
- fast/js/webidl-type-mapping-expected.txt:
- platform/chromium/fast/js/webidl-type-mapping-expected.txt: Removed.
- 7:33 PM Changeset in webkit [146429] by
-
- 3 edits in trunk/Source/JavaScriptCore
[QNX][ARM] REGRESSION(r135330): Various failures in Octane
https://bugs.webkit.org/show_bug.cgi?id=112863
Patch by Cosmin Truta <ctruta@blackberry.com> on 2013-03-20
Reviewed by Yong Li.
This was fixed in http://trac.webkit.org/changeset/146396 on Linux only.
Enable this fix on QNX.
- assembler/ARMv7Assembler.h:
(ARMv7Assembler):
(JSC::ARMv7Assembler::replaceWithJump):
(JSC::ARMv7Assembler::maxJumpReplacementSize):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::revertJumpReplacementToBranchPtrWithPatch):
- 7:26 PM Changeset in webkit [146428] by
-
- 2 edits in trunk/LayoutTests
Add flaky test expectations to compositing/geometry/limit-layer-bounds-fixed.html
and fast/dom/MutationObserver/database-callback-delivery.html on Windows per bugs
112867 and 112868.
- platform/win/TestExpectations:
- 6:51 PM Changeset in webkit [146427] by
-
- 4 edits2 adds in trunk
Gesture events should include AllowShadowContent in hit testing
https://bugs.webkit.org/show_bug.cgi?id=112073
Reviewed by Dimitri Glazkov.
Source/WebCore:
Support gesture events for Shadow DOM.
Now 'gesturetap' events can be correctly dispatched in shadow trees.
Test: fast/dom/shadow/gesture-tap.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
LayoutTests:
- fast/dom/shadow/gesture-tap-expected.txt: Added.
- fast/dom/shadow/gesture-tap.html: Added.
- fast/dom/shadow/resources/event-dispatching.js:
(addEventListeners):
- 6:46 PM Changeset in webkit [146426] by
-
- 2 edits3 adds in trunk/LayoutTests
Should add test for bug #112694
https://bugs.webkit.org/show_bug.cgi?id=112859
Reviewed by Filip Pizlo.
New regression test to check that eliminating a var arg DFG Node (array in this case) doesn't
cause a ASSERT or crash.
- fast/js/dfg-array-dead-expected.txt: Added.
- fast/js/dfg-array-dead.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-array-dead.js: Added.
- 6:44 PM Changeset in webkit [146425] by
-
- 4 edits in trunk/Source
Versioning.
- 6:44 PM Changeset in webkit [146424] by
-
- 2 edits in trunk/LayoutTests
Mac rebaseline after r146415. I somehow missed the 1px difference.
- platform/mac/svg/custom/text-ctm-expected.txt:
- 6:39 PM Changeset in webkit [146423] by
-
- 1 copy in tags/Safari-537.35
New tag.
- 5:49 PM Changeset in webkit [146422] by
-
- 5 edits in trunk/Source
../ThirdParty: [WinCairo] Build WinCairo port under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112861
Reviewed by Tim Horton.
- gtest/msvc/gtest-md.vcxproj: Add WinCairo targets.
../WebKit: [WinCairo] Top-level solution change to build under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112861.
Reviewed by Tim Horton.
- WebKit.vcxproj/WebKit.sln: Add final set of WinCairo build
targets.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Add #if/def guards around some media-specific exports that
are not provided by the WinCairo port.
- 5:43 PM Changeset in webkit [146421] by
-
- 2 edits in trunk/LayoutTests
[chromium] Update test expectations to more closely match reality.
https://bugs.webkit.org/show_bug.cgi?id=106609
https://code.google.com/p/chromium/issues/detail?id=222140
Unreviewed, test expectations update.
- platform/chromium/TestExpectations:
- 5:36 PM Changeset in webkit [146420] by
-
- 3 edits1 add in trunk/Tools
[WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
New property sheet that does not link against CoreFoundation and
CFNetwork.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
Use new TestWebKitAPICommonWinCairo property sheet.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
Ditto.
- 5:31 PM Changeset in webkit [146419] by
-
- 10 edits1 add in trunk/Source
HTMLNames should construct strings at compile time
https://bugs.webkit.org/show_bug.cgi?id=112831
Reviewed by Darin Adler.
Source/WebCore:
This patch teaches make_names how to construct strings at compile time,
eliminating a large number of startup mallocs.
- WebCore.gyp/WebCore.gyp:
- WebCore.gyp/scripts/action_makenames.py:
- Teach the Chromium build how to deal with Perl modules.
- bindings/scripts/StaticString.pm: Added.
- A Perl module for constructing static strings.
(GenerateStrings):
(GenerateValidateStrings):
- dom/QualifiedName.cpp:
(WebCore::createQualifiedName):
- createQualifiedName now takes an already-constructed StringImpl object.
- dom/QualifiedName.h:
- dom/make_names.pl:
(valueForName):
(namesToStrings):
(printNamesCppFile):
(printDefinitions):
- Teach make_names how to use StaticString.pm.
Source/WTF:
- wtf/text/StringImpl.h:
(StringImpl):
(StaticASCIILiteral):
- This struct lets us construct StringImpl objects at compile time.
(WTF::StringImpl::assertValidHash):
- This function lets us sanity check StringImpl objects created from StaticData.
- 5:20 PM Changeset in webkit [146418] by
-
- 2 edits in trunk/LayoutTests
Remove entires added by r138484 now that these tests pass on Mac.
- platform/mac/TestExpectations:
- 5:09 PM Changeset in webkit [146417] by
-
- 6 edits in trunk/Source/WebCore
Remove unnecessary calls to Node::disabled for <meter>, <progress>, and <output>
https://bugs.webkit.org/show_bug.cgi?id=112767
Reviewed by Kent Tamura.
This is part of a refactoring to move Node::disabled to HTMLFormControlElement::disabled.
The concept of disabled is just a form control element one.
HTMLMeterElement, HTMLOutputElement, and HTMLProgressElement never
have disabled() return true, so we can remove the call. In addition,
HTMLMeterElement and HTMLProgressElement no longer inherit from
HTMLFormControlElement, so we don't need to override supportsFocus.
No new tests because no behavior change.
- html/HTMLMeterElement.cpp:
- html/HTMLMeterElement.h:
- html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::supportsFocus):
- html/HTMLProgressElement.cpp:
- html/HTMLProgressElement.h:
- 5:08 PM Changeset in webkit [146416] by
-
- 4 edits3 adds in trunk/Tools
[WinCairo] Unreviewed build fix for VS2010.
Had to add WinCairo-specific property sheets to deal with some
library and path differences with the main Apple port.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
- 5:06 PM Changeset in webkit [146415] by
-
- 2 edits in trunk/LayoutTests
Remove an entry added in r141645 as this test is now passing.
- platform/mac/TestExpectations:
- 5:03 PM Changeset in webkit [146414] by
-
- 3 edits in trunk/LayoutTests
fast/css/empty-generated-content.html needs to be rebaselined after 104462
https://bugs.webkit.org/show_bug.cgi?id=104595
- platform/mac/TestExpectations:
- platform/mac/fast/css/empty-generated-content-expected.txt:
- 4:53 PM Changeset in webkit [146413] by
-
- 6 edits in trunk/LayoutTests
Rebaseline expected results added in r143389 so that they have alpha values.
- platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- svg/as-image/image-preserveAspectRatio-all-expected.png:
- svg/filters/feImage-preserveAspectRatio-all-expected.png:
- 4:49 PM Changeset in webkit [146412] by
-
- 2 edits in trunk/LayoutTests
Remove test expectations added in r133786 as these tests are now passing.
- platform/mac/TestExpectations:
- 4:46 PM Changeset in webkit [146411] by
-
- 2 edits in trunk/LayoutTests
inspector/debugger/debugger-reload-on-pause.html assertion failure on Mac after r141136
https://bugs.webkit.org/show_bug.cgi?id=109232
Unreviewed. Remove the test expectation entry since this test hasn't been crashing lately.
- platform/mac/TestExpectations:
- 4:41 PM Changeset in webkit [146410] by
-
- 3 edits1 copy in trunk/LayoutTests
Mac rebaseline intended to be done in r146409 for r144096.
- platform/mac/TestExpectations:
- platform/mac/css2.1/20110323/replaced-elements-001-expected.png:
- platform/mac/css2.1/20110323/replaced-elements-001-expected.txt: Copied from LayoutTests/css2.1/20110323/replaced-elements-001-expected.txt.
- 4:31 PM Changeset in webkit [146409] by
-
- 3 edits2 copies in trunk/LayoutTests
Mac rebaseline after r144096.
- platform/mac/TestExpectations:
- platform/mac/css3/flexbox/button-expected.png: Copied from LayoutTests/css3/flexbox/button-expected.png.
- platform/mac/css3/flexbox/button-expected.txt: Copied from LayoutTests/css3/flexbox/button-expected.txt.
- platform/mac/svg/custom/foreign-object-skew-expected.png:
- 4:20 PM Changeset in webkit [146408] by
-
- 18 edits9 adds in trunk
Source/WebCore: [css3-text] Parsing -webkit-each-line value for text-indent from css3-text
https://bugs.webkit.org/show_bug.cgi?id=109021
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-03-20
Reviewed by Julien Chaffraix.
"each-line" is added for text-indent in CSS3.
http://dev.w3.org/csswg/css3-text/#each-line
This patch is the parsing part to support each-line value for text-indent.
"each-line" means "Indentation affects the first line of the block
container as well as each line after a forced line break, but does
not affect lines after a soft wrap break."
It's prefixed and guarded by CSS3_TEXT flag.
Tests: fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited.html
fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
style.getPropertyCSSValue(text-indent) returns CSSPrimitiveValue when text-indent has only <length>
or <percentage> value, but returns CSSValueList when text-indent also has -webkit-each-line.
- css/CSSParser.cpp:
(WebCore::isSimpleLengthPropertyID): Removed CSSPropertyTextIndent case.
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTextIndent): Added.
- css/CSSParser.h:
Parsed <length> or <percentage> with -webkit-each-line for text-indent.
- css/CSSValueKeywords.in: Added new -webkit-each-line keyword.
- css/StyleBuilder.cpp:
(ApplyPropertyTextIndent): Added.
(WebCore::ApplyPropertyTextIndent::applyInheritValue):
(WebCore::ApplyPropertyTextIndent::applyInitialValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
(WebCore::ApplyPropertyTextIndent::createHandler):
(WebCore::StyleBuilder::StyleBuilder):
Added codes to handle applying text-indent offset and -webkit-each-line option to our style.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h: Added enum TextIndentLine.
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h: Added m_textIndentLine.
(StyleRareInheritedData):
Added the usual getter / setter / initial methods for m_textIndentLine.
LayoutTests: [css3-text] Parsing -webkit-each-line value for text-indent from css3-text
https://bugs.webkit.org/show_bug.cgi?id=109021
"each-line" is added for text-indent in CSS3.
http://dev.w3.org/csswg/css3-text/#each-line
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-03-20
Reviewed by Julien Chaffraix.
- fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-expected.txt: Added.
- fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited-expected.txt: Added.
- fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited.html: Added.
- fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html: Added.
- fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent-inherited.js: Added.
(testComputedStyle):
(ownValueTest):
(inheritanceTest):
- fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent.js: Added.
(testElementStyle):
(testComputedStyle):
(valueSettingTest):
(invalidValueSettingTest):
- platform/chromium/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt-mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 4:16 PM Changeset in webkit [146407] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix indentation of JSString.h
Rubber stamped by Mark Hahnenberg.
- runtime/JSString.h:
- 4:04 PM Changeset in webkit [146406] by
-
- 3 edits in trunk/LayoutTests
dialog-enabled.html and dialog-disabled.html don't really test what they think they do
https://bugs.webkit.org/show_bug.cgi?id=112848
Reviewed by Adam Barth.
- fast/dom/HTMLDialogElement/dialog-disabled.html:
- fast/dom/HTMLDialogElement/dialog-enabled.html:
Set the dialog element enabled setting before parsing <dialog> element.
- 4:03 PM Changeset in webkit [146405] by
-
- 4 edits in trunk/LayoutTests
Mac rebaseline after r142152.
- platform/mac/TestExpectations:
- platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
- platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
- 3:52 PM Changeset in webkit [146404] by
-
- 24 edits in trunk/LayoutTests
Mac rebaseline after r140693.
- editing/selection/extend-by-sentence-001-expected.txt:
- platform/mac/TestExpectations:
- platform/mac/css2.1/t0505-c16-descendant-01-e-expected.png:
- platform/mac/css2.1/t0505-c16-descendant-01-e-expected.txt:
- platform/mac/editing/selection/extend-by-sentence-001-expected.png:
- platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt:
- platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
- platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt:
- platform/mac/fast/text/capitalize-empty-generated-string-expected.png:
- platform/mac/fast/text/capitalize-empty-generated-string-expected.txt:
- platform/mac/fast/text/whitespace/006-expected.png:
- platform/mac/fast/text/whitespace/006-expected.txt:
- platform/mac/fast/text/whitespace/007-expected.png:
- platform/mac/fast/text/whitespace/007-expected.txt:
- platform/mac/svg/batik/text/xmlSpace-expected.png:
- platform/mac/svg/batik/text/xmlSpace-expected.txt:
- platform/mac/svg/carto.net/combobox-expected.png:
- platform/mac/tables/mozilla/bugs/bug113235-3-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1188-expected.png:
- platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1318-expected.png:
- platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
- svg/carto.net/combobox-expected.txt:
- 3:43 PM Changeset in webkit [146403] by
-
- 2 edits2 adds in trunk/LayoutTests
Mac rebaseline after r139282.
- fast/repaint/caret-with-transformation-expected.png: Added.
- fast/repaint/caret-with-transformation-expected.txt: Added.
- 3:40 PM Changeset in webkit [146402] by
-
- 9 edits in trunk
[WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112849
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-20
Reviewed by Sam Weinig.
Source/WebKit2:
The code was added in r137148 for the sole purpose of testing,
and it is not even being properly tested.
Remove the code until someone actually implement the feature in WebKit2.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCanShowMIMEType):
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
(WebPage):
Tools:
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- 3:39 PM Changeset in webkit [146401] by
-
- 1 edit3 adds in trunk/LayoutTests
"" + x where x is not a string should be optimized by the DFG to some manner of ToString conversion
https://bugs.webkit.org/show_bug.cgi?id=112845
Reviewed by Mark Hahnenberg.
- fast/js/regress/empty-string-plus-int-expected.txt: Added.
- fast/js/regress/empty-string-plus-int.html: Added.
- fast/js/regress/script-tests/empty-string-plus-int.js: Added.
(foo):
- 3:37 PM Changeset in webkit [146400] by
-
- 4 edits in trunk/Source/JavaScriptCore
"" + x where x is not a string should be optimized by the DFG to some manner of ToString conversion
https://bugs.webkit.org/show_bug.cgi?id=112845
Reviewed by Mark Hahnenberg.
I like to do "" + x. So I decided to make DFG recognize it, and related idioms.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupToPrimitive):
(FixupPhase):
(JSC::DFG::FixupPhase::fixupToString):
(JSC::DFG::FixupPhase::attemptToMakeFastStringAdd):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::resultOfToPrimitive):
(DFG):
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGPredictionPropagationPhase.h:
(DFG):
- 3:36 PM Changeset in webkit [146399] by
-
- 10 edits7 adds in trunk
Correct coordinated scrolling for RTL iframe and overflow:scroll
https://bugs.webkit.org/show_bug.cgi?id=112088
Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-03-20
Reviewed by James Robinson.
Source/WebCore:
This patch adds appropriate offset in ScrollingCoordinatorChromium to
adjust impl-side scroll position to the range [0, maxPos - minPos].
This also corrects RenderLayer to return correct scroll position for RTL,
explained below:
There are 2 commonly used scroll offset coordinate systems in WebCore.
- The scroll offset is the amount that needs to be translated when painting child elements in a RenderBox. The value can be negative when there is negative overflow (for RTL). The range will be within [overflow_top_left_corner, overflow_bottom_right_corner - client_size]. This system is mainly used for painting and layer positioning.
- The scroll offset will be always non-negative, and the range will be within [0, content_size - client_size]. This system is mainly used for scrollbars.
scrollOrigin is defined to convert between the two systems. scrollOrigin is always
non-negative, and equivalent to -overflow_top_left_corner.
The first system is used for ScrollableArea::scrollPosition/minimumScrollPosition/
maximumScrollPosition function family. So is it implemented in ScrollView/Frameview.
RenderLayer errorneously implemented scrollPosition in the second system,
and worse, returned minimumScrollPosition/maximumScrollPosition were totally non-sense.
This patch corrects RenderLayer to use the first coordinate system.
Test: compositing/rtl/rtl-overflow-scrolling.html
ScrollingCoordinatorChromiumTest.rtlIframe
- page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorChromium::scrollableAreaScrollLayerDidChange):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollPosition):
(WebCore::RenderLayer::minimumScrollPosition):
(WebCore::RenderLayer::maximumScrollPosition):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
Source/WebKit/chromium:
Added test to ensure RTL iframe has appropriate impl-side scroll position.
- tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::TEST_F):
(WebKit):
- tests/data/rtl-iframe-inner.html: Added.
- tests/data/rtl-iframe.html: Added.
LayoutTests:
This patch corrects scrollOrigin compensation for composited overflow:scroll.
compositing/rtl/rtl-overflow-scrolling.html is added to verify RTL divs
can be correctly scrolled to the left under accelerated scrolling mode.
fast/css/sticky/inline-sticky-abspos-child.html is modified to avoid sub-pixel
issue with Ahem font.
- compositing/rtl/rtl-overflow-scrolling-expected.png: Added.
- compositing/rtl/rtl-overflow-scrolling-expected.txt: Added.
- compositing/rtl/rtl-overflow-scrolling.html: Added.
- fast/css/sticky/inline-sticky-abspos-child-expected.html:
- fast/css/sticky/inline-sticky-abspos-child.html:
- platform/chromium/TestExpectations:
- platform/mac/compositing/rtl/rtl-overflow-scrolling-expected.txt: Added.
- 3:33 PM Changeset in webkit [146398] by
-
- 10 edits6 adds in trunk/Tools
[WinCairo] Build WebKit Tools under VS2010
https://bugs.webkit.org/show_bug.cgi?id=112821
Reviewed by Tim Horton.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
Add WinCairo-specific build target.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
Add WinCairo-specific build target.
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
Add WinCairo-specific build target.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
WinCairo-specific build target.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
- WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
specific build target.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
WinCairo-specific build target.
- win/record-memory/record-memory.vcxproj: Add WinCairo target.
- win/record-memory/record-memoryDebugWinCairo.props: Added.
- win/record-memory/record-memoryReleaseWinCairo.props: Added.
- 3:19 PM Changeset in webkit [146397] by
-
- 9 edits in trunk/LayoutTests
Mac rebaseline after r140202.
- editing/input/caret-at-the-edge-of-contenteditable-expected.png:
- editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
- editing/input/reveal-caret-of-multiline-input-expected.png:
- fast/spatial-navigation/snav-div-overflow-scrol-hidden-expected.txt:
- platform/mac/TestExpectations:
- platform/mac/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
- platform/mac/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
- platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt:
- 3:07 PM Changeset in webkit [146396] by
-
- 3 edits in trunk/Source/JavaScriptCore
ARMv7 replaceWithJump ASSERT failure after r135330.
https://bugs.webkit.org/show_bug.cgi?id=103146
Reviewed by Filip Pizlo.
On Linux, the 24 bit distance range of jumps sometimes does not
enough to cover all targets addresses. This patch supports jumps
outside of this range using a mov/movt/bx 10 byte long sequence.
- assembler/ARMv7Assembler.h:
(ARMv7Assembler):
(JSC::ARMv7Assembler::revertJumpTo_movT3movtcmpT2):
(JSC::ARMv7Assembler::nopw):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::replaceWithJump):
(JSC::ARMv7Assembler::maxJumpReplacementSize):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::revertJumpReplacementToBranchPtrWithPatch):
- 3:05 PM Changeset in webkit [146395] by
-
- 2 edits in branches/safari-536.30-branch/Tools
Unreviewed. Merge the latest delete-stale-build-files to make bots green.
- BuildSlaveSupport/delete-stale-build-files:
- 3:01 PM Changeset in webkit [146394] by
-
- 4 edits in trunk/Source
REGRESSION(r145592): AutodrainedPool.h. RunLoopTimer.h, SchedulePair.h are being copied into
the wrong location
https://bugs.webkit.org/show_bug.cgi?id=112833
Reviewed by Darin Adler.
Source/WebCore:
Fix an incorrect include path.
- loader/DocumentLoader.h:
RunLoopTimer.h lives in wtf as of r145592.
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
Make sure those three headers are copied with the rest of the WTF headers.
- 2:58 PM Changeset in webkit [146393] by
-
- 3 edits2 adds in trunk
Crash in Document::setFocusedNode if the frame of new focused node is detached in 'change' event handler
https://bugs.webkit.org/show_bug.cgi?id=112653
Reviewed by Dimitri Glazkov.
Source/WebCore:
Test: fast/frames/detach-frame-during-focus.html
- page/FocusController.cpp:
(WebCore::FocusController::setFocusedNode):
A oldDocument->setFocusedNode call might dispatch a 'change' event for
an old focused node, and an event handler code might detach the
newFocusedFrame. So we should check it. Without the check, the following
newDocument->setFocusedNode call would crash because of null
Frame::page().
LayoutTests:
- fast/frames/detach-frame-during-focus-expected.txt: Added.
- fast/frames/detach-frame-during-focus.html: Added.
- 2:41 PM Changeset in webkit [146392] by
-
- 3 edits in trunk/Source/JavaScriptCore
Objective-C API: Fix over-releasing in allocateConstructorAndPrototypeWithSuperClassInfo:
https://bugs.webkit.org/show_bug.cgi?id=112832
Reviewed by Geoffrey Garen.
If either the m_constructor or m_prototype (but not both) is collected, we will call
allocateConstructorAndPrototypeWithSuperClassInfo, which will create a new object to replace the one
that was collected, but at the end of the method we call release on both of them.
This is incorrect since we autorelease the JSValue in the case that the object doesn't need to be
reallocated. Thus we'll end up overreleasing later during the drain of the autorelease pool.
- API/JSWrapperMap.mm:
(objectWithCustomBrand): We no longer alloc here. We instead call the JSValue valueWithValue class method,
which autoreleases for us.
(-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]): We no longer call release on the
constructor or prototype JSValues.
- API/tests/testapi.mm: Added a new test that crashes on ToT due to over-releasing.
- 2:36 PM Changeset in webkit [146391] by
-
- 2 edits in trunk/Source/WebCore
Assertion in LegacyWebArchive::create() in editing tests
https://bugs.webkit.org/show_bug.cgi?id=112642
Reviewed by Simon Fraser.
Address Simon's review comment. Don't convert String to MIMEType just to convert it back to String.
- platform/mac/PasteboardMac.mm:
(WebCore::fragmentFromWebArchive):
- 2:26 PM Changeset in webkit [146390] by
-
- 9 edits1 add in trunk
[GTK] Build ANGLE sources into a separate library from libWebCore.la
https://bugs.webkit.org/show_bug.cgi?id=112778
Reviewed by Martin Robinson.
.:
- GNUmakefile.am: Include the GNUmakefile.am covering the libANGLE.la library.
Source/ThirdParty/ANGLE:
- GNUmakefile.am: Added, sets up the libANGLE.la library.
Source/WebCore:
No new tests - no change in functionality.
- GNUmakefile.list.am: Remove the ANGLE sources listing, it's now placed in the ANGLE-specific GNUmakefile.am.
Source/WebKit/gtk:
- GNUmakefile.am: Add libLevelDB.la to the libwebkitgtk library if using the OpenGL accelerated backend.
Source/WebKit2:
- GNUmakefile.am: Add libLevelDB.la to the libwebkit2gtk library if using the OpenGL accelerated backend.
- 2:24 PM Changeset in webkit [146389] by
-
- 2 edits in trunk/Source/WebCore
Assertion in LegacyWebArchive::create() in editing tests
https://bugs.webkit.org/show_bug.cgi?id=112642
Reviewed by Enrica Casucci.
It's possible for clipboard to be overriden between the time we retrieve clipboard types and the time
we actually retrieve the Web archive buffer. Add a null check to take this into account.
Also extracted fragmentFromWebArchive for clarity.
- platform/mac/PasteboardMac.mm:
(WebCore::fragmentFromWebArchive): Extracted.
(WebCore::Pasteboard::documentFragment):
- 2:16 PM Changeset in webkit [146388] by
-
- 30 edits in branches/safari-536.30-branch/LayoutTests
<rdar://problem/13465764> Many merged tests are failing
Rubber stamped by Mark Rowe.
Change all instances of "testRunner" back to "layoutTestController".
- editing/style/apply-style-crash.html:
- fast/backgrounds/background-clip-text-on-body.html:
- fast/backgrounds/transformed-body-background.html:
- fast/backgrounds/transformed-body-html-background.html:
- fast/backgrounds/transformed-html-body-background.html:
- fast/block/colspan-under-button-crash.html:
- fast/block/float/float-not-removed-from-pre-block.html:
- fast/block/line-layout/double-line-break-obj-removal-crash.html:
- fast/canvas/canvas-measureText.html:
- fast/css-generated-content/bug-106384.html:
- fast/css/image-set-value-not-removed-crash.html:
- fast/dom/Geolocation/watchPosition-unique.html:
- fast/dom/ready-state-change-crash.html:
- fast/dom/window-load-crash.html:
- fast/forms/textarea/textarea-autofocus-removal-while-focusing-with-style.html:
- fast/frames/frame-unload-crash2.html:
- fast/images/crossfade-client-not-removed-crash.html:
- fast/js/concat-large-strings-crash.html:
- fast/js/concat-large-strings-crash2.html:
- fast/multicol/continuation-crash.html:
- fast/multicol/float-not-removed-crash.html:
- fast/multicol/span/list-multi-column-crash.html:
- fast/parser/foster-parent-adopted.html:
- fast/parser/foster-parent-adopted2.html:
- http/tests/security/xssAuditor/script-tag-with-actual-comma.html:
- http/tests/security/xssAuditor/script-tag-with-source-data-url3.html:
- plugins/plugin-remove-readystatechange.html:
- svg/animations/animate-keytimes-crash.html:
- svg/custom/elementTimeControl-nan-crash.html:
- 2:13 PM Changeset in webkit [146387] by
-
- 3 edits2 adds in trunk
WebSpeech: Crash in WebCore::PlatformSpeechSynthesisUtterance::client / WebCore::SpeechSynthesis::didResumeSpeaking
https://bugs.webkit.org/show_bug.cgi?id=112728
Reviewed by Tim Horton.
When cancel() is called, there was a delay in the platform returning and saying speech was finished, which caused
the m_currentSpeechUtterance variable to get deallocated but not cleared.
This patch fixes up the management of the utterances in SpeechSynthesis and the Mac platform given that
we can't rely on the platform to return immediately on a stop speaking job.
Test: platform/mac/fast/speechsynthesis/speech-synthesis-cancel-crash.html
- Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::cancel):
(WebCore::SpeechSynthesis::resume):
- platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper cancel]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:willSpeakWord:ofString:]):
- 1:55 PM Changeset in webkit [146386] by
-
- 3 edits in trunk/Tools
API test gardening AppleWin port.
The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
- TestWebKitAPI/win/TestWebKitAPI.vcproj:
- 1:47 PM Changeset in webkit [146385] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix Mac release build.
- page/CaptionUserPreferencesMac.mm:
(WebCore::languageIdentifier):
- 1:45 PM Changeset in webkit [146384] by
-
- 1 copy in branches/dfgFourthTier
Unreviewed, branch for work on https://bugs.webkit.org/show_bug.cgi?id=112836
- 1:43 PM Changeset in webkit [146383] by
-
- 8 edits in trunk/Source/JavaScriptCore
It's called "Hash Consing" not "Hash Consting"
https://bugs.webkit.org/show_bug.cgi?id=112768
Rubber stamped by Mark Hahnenberg.
See http://en.wikipedia.org/wiki/Hash_consing
- heap/GCThreadSharedData.cpp:
(JSC::GCThreadSharedData::GCThreadSharedData):
(JSC::GCThreadSharedData::reset):
- heap/GCThreadSharedData.h:
(GCThreadSharedData):
- heap/SlotVisitor.cpp:
(JSC::SlotVisitor::SlotVisitor):
(JSC::SlotVisitor::setup):
(JSC::SlotVisitor::reset):
(JSC::JSString::tryHashConsLock):
(JSC::JSString::releaseHashConsLock):
(JSC::JSString::shouldTryHashCons):
(JSC::SlotVisitor::internalAppend):
- heap/SlotVisitor.h:
(SlotVisitor):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
- runtime/JSGlobalData.h:
(JSGlobalData):
(JSC::JSGlobalData::haveEnoughNewStringsToHashCons):
(JSC::JSGlobalData::resetNewStringsSinceLastHashCons):
- runtime/JSString.h:
(JSC::JSString::finishCreation):
(JSString):
(JSC::JSString::isHashConsSingleton):
(JSC::JSString::clearHashConsSingleton):
(JSC::JSString::setHashConsSingleton):
- 1:29 PM Changeset in webkit [146382] by
-
- 18 edits in trunk/Source/JavaScriptCore
DFG implementation of op_strcat should inline rope allocations
https://bugs.webkit.org/show_bug.cgi?id=112780
Reviewed by Oliver Hunt.
This gets rid of the StrCat node and adds a MakeRope node. The MakeRope node can
take either two or three operands, and allocates a rope string with either two or
three fibers. (The magic choice of three children for non-VarArg nodes happens to
match exactly with the magic choice of three fibers for rope strings.)
ValueAdd on KnownString is replaced with MakeRope with two children.
StrCat gets replaced by an appropriate sequence of MakeRope's.
MakeRope does not do the dynamic check to see if its children are empty strings.
This is replaced by a static check, instead. The downside is that we may use more
memory if the strings passed to MakeRope turn out to dynamically be empty. The
upside is that we do fewer checks in the cases where either the strings are not
empty, or where the strings are statically known to be empty. I suspect both of
those cases are more common, than the case where the string is dynamically empty.
This also results in some badness for X86. MakeRope needs six registers if it is
allocating a three-rope. We don't have six registers to spare on X86. Currently,
the code side-steps this problem by just never usign three-ropes in optimized
code on X86. All other architectures, including X86_64, don't have this problem.
This is a shocking speed-up. 9% progressions on both V8/splay and
SunSpider/date-format-xparb. 1% progression on V8v7 overall, and ~0.5% progression
on SunSpider. 2x speed-up on microbenchmarks that test op_strcat.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGAdjacencyList.h:
(AdjacencyList):
(JSC::DFG::AdjacencyList::removeEdge):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::removeArgumentsReferencingPhantomChild):
- dfg/DFGBackwardsPropagationPhase.cpp:
(JSC::DFG::BackwardsPropagationPhase::propagate):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::eliminateIrrelevantPhantomChildren):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::createToString):
(JSC::DFG::FixupPhase::attemptToForceStringArrayModeByToStringConversion):
(JSC::DFG::FixupPhase::convertStringAddUse):
(FixupPhase):
(JSC::DFG::FixupPhase::convertToMakeRope):
(JSC::DFG::FixupPhase::fixupMakeRope):
(JSC::DFG::FixupPhase::attemptToMakeFastStringAdd):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileMakeRope):
(DFG):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateCellOperand::~SpeculateCellOperand):
(JSC::DFG::SpeculateCellOperand::gpr):
(JSC::DFG::SpeculateCellOperand::use):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/JSString.h:
(JSRopeString):
- 1:25 PM Changeset in webkit [146381] by
-
- 7 edits11 adds in trunk/Source/WebKit
[WinCairo] Build the WebKit.dll under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112759
Reviewed by Tim Horton.
- WebKit.vcxproj/Interfaces/Interfaces.vcxproj: Update project to
build WinCairo variant using new property sheets.
- WebKit.vcxproj/Interfaces/InterfacesDebugWinCairo.props: Added.
- WebKit.vcxproj/Interfaces/InterfacesReleaseWinCairo.props: Added.
- WebKit.vcxproj/WebKit.sln: Update solution to use WinCairo
build targets for WebKit.dll-related projects.
- WebKit.vcxproj/WebKit/WebKit.vcxproj: Update project to build
WinCairo variant using new property sheets.
- WebKit.vcxproj/WebKit/cURL.props: Added.
- WebKit.vcxproj/WebKit/WebKitDebugWinCairo.props: Added.
- WebKit.vcxproj/WebKit/WebKitReleaseWinCairo.props: Added.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj:
Update project to build WinCairo variant using new property sheets.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorDebugWinCairo.props: Added.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorReleaseWinCairo.props: Added.
- WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj: Update project to
build WinCairo variant using new property sheets.
- WebKit.vcxproj/WebKitGUID/WebKitGUIDDebugWinCairo.props: Added.
- WebKit.vcxproj/WebKitGUID/WebKitGUIDReleaseWinCairo.props: Added.
- WebKit.vcxproj/WinCairo.props: Added.
- WebKit.vcxproj/debug_wincairo.props: Added.
- 1:13 PM Changeset in webkit [146380] by
-
- 36 edits in trunk
Allow ports specific text track menu
https://bugs.webkit.org/show_bug.cgi?id=112800
Reviewed by Dean Jackson.
Source/WebCore:
No new tests, existing tests updated for changes.
- English.lproj/Localizable.strings: Add localizable strings for text track names.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): userPrefersCaptions -> shouldShowCaptions.
(WebCore::HTMLMediaElement::setSelectedTextTrack): toggleTrackAtIndex -> setSelectedTextTrack.
(WebCore::HTMLMediaElement::userPrefersCaptions): userPrefersCaptions -> shouldShowCaptions.
(WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind): Get preferences from CaptionUserPreferences
instead of from Settings.
(WebCore::HTMLMediaElement::setSelectedTextTrack): Renamed from toggleTrackAtIndex. Now takes
a TextTrack* instead of an int.
(WebCore::HTMLMediaElement::captionPreferencesChanged): Don't force a recalculation unless
captions are enabled/disabled to avoid unnecessary thrash.
- html/HTMLMediaElement.h:
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler): Use the menu to track
map instead of just the track index.
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay): Build and configure the
menu from the menu to track map.
(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu): Start with a list
of tracks already sorted according to platform specific rules. Build a menu to track map
so tracks are retained while the menu is visible.
- html/shadow/MediaControlElements.h:
- html/shadow/MediaControls.cpp:
(WebCore::MediaControls::textTrackPreferencesChanged): Call closedCaptionTracksChanged so the
track menu will be rebuilt before it is shown again.
- html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::containsOnlyForcedSubtitles): New, passthrough to the private track.
(WebCore::InbandTextTrack::isMainProgramContent): Ditto.
(WebCore::InbandTextTrack::isEasyToRead): Ditto.
- html/track/InbandTextTrack.h:
- html/track/TextTrack.h:
- html/track/TextTrackList.cpp:
(WebCore::TextTrackList::contains): New.
- html/track/TextTrackList.h:
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::CaptionUserPreferences): Pull in from .h ditto.
(WebCore::CaptionUserPreferences::~CaptionUserPreferences): Ditto.
(WebCore::CaptionUserPreferences::shouldShowCaptions): Renamed from userPrefersCaptions.
(WebCore::CaptionUserPreferences::setShouldShowCaptions): New.
(WebCore::CaptionUserPreferences::userPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferences::setUserPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferences::userPrefersSubtitles): Ditto.
(WebCore::CaptionUserPreferences::setUserPrefersSubtitles): Ditto.
(WebCore::CaptionUserPreferences::userPrefersTextDescriptions): Ditto.
(WebCore::CaptionUserPreferences::setUserPrefersTextDescriptions): Ditto.
(WebCore::CaptionUserPreferences::displayNameForTrack): Ditto.
(WebCore::CaptionUserPreferences::sortedTrackListForMenu): Ditto.
- page/CaptionUserPreferences.h:
- page/CaptionUserPreferencesMac.h:
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::shouldShowCaptions): Renamed from userPrefersCaptions.
(WebCore::CaptionUserPreferencesMac::userPrefersCaptions): New.
(WebCore::CaptionUserPreferences::userPrefersSubtitles): Ditto.
(WebCore::trackDisplayName): Update logic used to build track title.
(WebCore::CaptionUserPreferencesMac::displayNameForTrack): Call trackDisplayName.
(WebCore::textTrackCompare): Text track title sort comparison function.
(WebCore::CaptionUserPreferencesMac::sortedTrackListForMenu): New. Sort the list of tracks
according to title, language, and user preferences.
- platform/Language.cpp:
(WebCore::displayNameForLanguageLocale): Don't leak the CFLocale.
- platform/LocalizedStrings.cpp:
(WebCore::textTrackCountryAndLanguageMenuItemText): New.
(WebCore::textTrackLanguageMenuItemText): Ditto.
(WebCore::closedCaptionTrackMenuItemText): Ditto.
(WebCore::sdhTrackMenuItemText): Ditto.
(WebCore::easyReaderTrackMenuItemText): Ditto.
- platform/LocalizedStrings.h:
- platform/graphics/InbandTextTrackPrivate.h:
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
(WebCore::InbandTextTrackPrivateAVFObjC::containsOnlyForcedSubtitles): New, return AVFoundation property.
(WebCore::InbandTextTrackPrivateAVFObjC::isMainProgramContent): Ditto.
(WebCore::InbandTextTrackPrivateAVFObjC::isEasyToRead): Ditto.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::setShouldDisplayTrackKind): Set setting via CaptionUserPreferences
instead of from Settings.
(WebCore::InternalSettings::shouldDisplayTrackKind): Get setting from CaptionUserPreferences
instead of from Settings.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add new exports.
- win/WebKit.vcproj/WebKitExports.def.in: Ditto.
LayoutTests:
- media/track/track-user-preferences-expected.txt:
- media/track/track-user-preferences.html:
- media/video-controls-captions-trackmenu-localized.html:
- media/video-controls-captions-trackmenu-sorted.html:
- media/video-controls-captions-trackmenu.html:
- platform/mac/media/video-controls-captions-trackmenu-expected.txt:
- platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
- platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:
- 1:07 PM Changeset in webkit [146379] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Clean up TemporaryLinkStubs.cpp
https://bugs.webkit.org/show_bug.cgi?id=112820
Reviewed by Philippe Normand.
Clean up the TemporaryLinkStubs.cpp file, removing unnecessary includes and prettifying the code.
No new tests - no new functionality.
- platform/gtk/TemporaryLinkStubs.cpp:
(WebCore):
(WebCore::getSupportedKeySizes):
(WebCore::signedPublicKeyAndChallengeString):
(WebCore::userIdleTime):
- 12:27 PM Changeset in webkit [146378] by
-
- 8 edits in trunk/Source
Remove PlatformEvent::GestureDoubleTap
https://bugs.webkit.org/show_bug.cgi?id=93045
Patch by Yufeng Shen <miletus@chromium.org> on 2013-03-20
Reviewed by Antonio Gomes.
Source/WebCore:
PlatformEvent::GestureDoubleTap is not currently
used in WebCore and replaced by GestureTap with
tap count 2, so remove it.
Test: We are removing something that is not used, so
no new test. All existing tests pass.
- dom/GestureEvent.cpp:
(WebCore::GestureEvent::create):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
- platform/PlatformEvent.h:
- platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::handleGestureEvent):
Source/WebKit/chromium:
PlatformEvent::GestureDoubleTap is not currently
used in WebCore so remove it.
- src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
- 12:22 PM Changeset in webkit [146377] by
-
- 7 edits in trunk/Source/WebCore
Move repaint methods from RenderObject to RenderBox
https://bugs.webkit.org/show_bug.cgi?id=112773
Reviewed by Julien Chaffraix.
repaintOverhangingFloats and repaintDuringLayoutIfMoved are only ever called
on RenderBoxes, so don't need to be on RenderObject. This also lets us
devirtualize repaintDuringLayoutIfMoved.
- rendering/RenderBox.h:
(WebCore::RenderBox::repaintOverhangingFloats):
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- 12:22 PM Changeset in webkit [146376] by
-
- 2 edits in trunk/Tools
Test fix for Win EWS bots, catch various errors and restart script if necessary.
- EWSTools/start-queue-win.sh:
- 12:19 PM Changeset in webkit [146375] by
-
- 3 edits in trunk/Source/WebCore
Add a feature observer for RenderDeprecatedFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=112740
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-20
Reviewed by Tony Chang.
No new tests - only adding measurements.
- page/FeatureObserver.h:
Add constants for RenderDeprecatedFlexibleBox, and add separate
constants for its use in the UI and in extensions.
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox):
Call FeatureObserver. Check the document()->url() to see which
constant to use.
- 12:09 PM Changeset in webkit [146374] by
-
- 2 edits in trunk/Tools
Unreviewed, add myself to committers.py.
- 11:56 AM Changeset in webkit [146373] by
-
- 2 edits in trunk/Source/WebCore
Autosize should use documentRect height instead of scrollHeight
https://bugs.webkit.org/show_bug.cgi?id=112770
Reviewed by David Levin.
Autosizing fails to compute the correct height if the root element is very
small but the document has significant overflow.
No new tests; autosizing is not currently exposed in a testable way on Mac.
- page/FrameView.cpp:
(WebCore::FrameView::autoSizeIfEnabled):
- 11:56 AM Changeset in webkit [146372] by
-
- 2 edits in trunk/Source/WTF
FastMalloc scavenge timer specifies an overly narrow leeway value.
Reviewed by Alexey Proskuryakov.
There's no need to allow only 1ms of leeway on a 2s timer.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::initializeScavenger): Bump the leeway window
to 10% of the scavenge timer.
- 11:50 AM Changeset in webkit [146371] by
-
- 3 edits8 adds in trunk
[CSS Grid Layout] Improper repainting when grid item change their position
https://bugs.webkit.org/show_bug.cgi?id=112749
Reviewed by Ojan Vafai.
Source/WebCore:
Tests: fast/css-grid-layout/grid-element-change-columns-repaint.html
fast/css-grid-layout/grid-element-change-rows-repaint.html
fast/css-grid-layout/grid-item-change-column-repaint.html
fast/css-grid-layout/grid-item-change-row-repaint.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutGridItems):
Added a call to repaintDuringLayoutIfMoved to repaint moving grid items.
LayoutTests:
- fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt: Added.
- fast/css-grid-layout/grid-element-change-columns-repaint.html: Added.
- fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt: Added.
- fast/css-grid-layout/grid-element-change-rows-repaint.html: Added.
Those are added testing for the grid element's change. They were already passing due to
the LayoutRepainter in RenderGrid::layoutBlock.
- fast/css-grid-layout/grid-item-change-column-repaint-expected.txt: Added.
- fast/css-grid-layout/grid-item-change-column-repaint.html: Added.
- fast/css-grid-layout/grid-item-change-row-repaint-expected.txt: Added.
- fast/css-grid-layout/grid-item-change-row-repaint.html: Added.
New testing, was failing before this change.
- 11:35 AM Changeset in webkit [146370] by
-
- 1 edit in branches/chromium/1447/Source/WebCore/bindings/v8/V8LazyEventListener.cpp
Merge 146344 "[v8] unsafe persistent access in V8LazyEventListener"
[v8] unsafe persistent access in V8LazyEventListener
https://bugs.webkit.org/show_bug.cgi?id=112807
Patch by Dan Carney <dcarney@google.com> on 2013-03-20
Reviewed by Kentaro Hara.
No new tests.
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::toObjectWrapper):
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12512013
- 11:34 AM Changeset in webkit [146369] by
-
- 1 add in branches/chromium/1447/codereview.settings
for drovering
- 11:33 AM Changeset in webkit [146368] by
-
- 1 copy in branches/chromium/1447
branching to merge a v8 fix
- 11:24 AM Changeset in webkit [146367] by
-
- 2 edits in trunk/Source/WebKit
AppleWin VS2010 build fix.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 11:20 AM Changeset in webkit [146366] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] compositing/iframes/scroll-fixed-transformed-element.html fails in manual testing
https://bugs.webkit.org/show_bug.cgi?id=112806
Reviewed by Antonio Gomes.
PR 283363
When scrolling the iframe, the position: fixed element is correctly
positioned, that is, as if it was fixed with respect to the iframe's
viewport. When scrolling the main frame however, the fixed pos element
was positioned as if it was fixed with respect to the main frame's
viewport.
Fixed by falling back to using the WebKit-thread scroll position for
fixed positioning in LayerRenderer, if the override doesn't have a
position currently set, i.e. if we are not currently scrolling the
iframe.
The effects of the bug are only visual, i.e. not detectable by DRT.
Manually testable using compositing/iframes/scroll-fixed-transformed-element.html
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::updateLayersRecursive):
- 11:17 AM Changeset in webkit [146365] by
-
- 2 edits in trunk/Source/WebCore
[V8] Simplify implementation of EnforceRange conversions
https://bugs.webkit.org/show_bug.cgi?id=112758
Patch by Michael Pruett <michael@68k.org> on 2013-03-20
Reviewed by Kentaro Hara.
Factor out EnforceRange conversion into a helper function.
Simplify calculation for truncation.
Tests: fast/js/webidl-type-mapping.html
storage/indexeddb/cursor-advance.html
storage/indexeddb/cursor-advance-workers.html
storage/indexeddb/intversion-bad-parameters.html
- bindings/v8/V8Binding.cpp:
(WebCore::enforceRange):
(WebCore):
(WebCore::toInt32):
(WebCore::toUInt32):
(WebCore::toInt64):
(WebCore::toUInt64):
- 11:06 AM Changeset in webkit [146364] by
-
- 9 edits in trunk/Source
Remove Local/Remote and RTCStatsElement from WebRTCStats API
https://bugs.webkit.org/show_bug.cgi?id=112678
Patch by Harald Alvestrand <hta@google.com> on 2013-03-20
Reviewed by Adam Barth.
Source/Platform:
- chromium/public/WebRTCStatsResponse.h:
(WebRTCStatsResponse):
Source/WebCore:
Pure removal, remaining functionality covered by existing test.
- Modules/mediastream/RTCStatsReport.cpp:
- Modules/mediastream/RTCStatsReport.h:
(RTCStatsReport):
- Modules/mediastream/RTCStatsResponse.cpp:
- Modules/mediastream/RTCStatsResponse.h:
(RTCStatsResponse):
- platform/chromium/support/WebRTCStatsResponse.cpp:
- platform/mediastream/RTCStatsResponseBase.h:
(RTCStatsResponseBase):
- 10:56 AM Changeset in webkit [146363] by
-
- 2 edits in trunk
[Qt] Define MODULE_VERSION
https://bugs.webkit.org/show_bug.cgi?id=112808
Reviewed by Allan Sandfeld Jensen.
Upstream http://codereview.qt-project.org/49052
Use 5.2.0 as this is the next release that will be branched from trunk.
- .qmake.conf:
- 10:33 AM Changeset in webkit [146362] by
-
- 2 edits in trunk/Source/WebCore
ASSERTION FAILED: !m_renderingAutomaticPullNodes.size()
https://bugs.webkit.org/show_bug.cgi?id=112777
Reviewed by Chris Rogers.
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::~AudioContext):
- 10:28 AM Changeset in webkit [146361] by
-
- 13 edits2 adds in trunk
Copy-paste should not spellcheck when continuous spellcheck is turned off
https://bugs.webkit.org/show_bug.cgi?id=112464
Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-03-20
Reviewed by Ryosuke Niwa.
.:
- Source/autotools/symbols.filter: Export WebCore::Editor::isContinuousSpellCheckingEnabled() and WebCore::Editor::toggleContinuousSpellChecking() for use by internals.
Source/WebCore:
Test: editing/spelling/spellcheck-paste-continuous-disabled.html
- WebCore.exp.in: Export WebCore::Editor::isContinuousSpellCheckingEnabled() and WebCore::Editor::toggleContinuousSpellChecking() for use by internals.
- WebCore.order: Export WebCore::Editor::isContinuousSpellCheckingEnabled() and WebCore::Editor::toggleContinuousSpellChecking() for use by internals.
- editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment): Do not spellcheck if continuous spellcheck is turned off.
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState): Leave continuous spellcheck turned on after a test.
(WebCore::Internals::setContinuousSpellCheckingEnabled): Let tests enable and disable continuous spellcheck.
(WebCore):
- testing/Internals.h: Let tests enable and disable continuous spellcheck.
(Internals):
- testing/Internals.idl: Let tests enable and disable continuous spellcheck.
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in: Export WebCore::Editor::isContinuousSpellCheckingEnabled() and WebCore::Editor::toggleContinuousSpellChecking() for use by internals.
LayoutTests:
- editing/spelling/spellcheck-paste-continuous-disabled-expected.txt: Added expected results for pasting when continuous spellcheck is turned off.
- editing/spelling/spellcheck-paste-continuous-disabled.html: Added a test for pasting with continuous spellcheck turned off.
- platform/mac-wk2/TestExpectations: Skip spellcheck-paste-continuous-disabled.html, because it is a slight modification of spellcheck-paste-disabled.html, which is also skipped in mac-wk2.
- 10:22 AM Changeset in webkit [146360] by
-
- 9 edits2 adds in trunk
Add support for MediaSource::isTypeSupported()
https://bugs.webkit.org/show_bug.cgi?id=112301
Reviewed by Darin Fisher.
Source/Platform:
- chromium/public/WebMimeRegistry.h:
(WebMimeRegistry): Added supportsMediaSourceMIMEType() method.
Source/WebCore:
Test: http/tests/media/media-source/video-media-source-is-type-supported.html
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::addSourceBuffer): Added isTypeSupported() call to verify parameters
pass into this method.
(WebCore::MediaSource::isTypeSupported):
(WebCore):
- Modules/mediasource/MediaSource.h:
(MediaSource):
- Modules/mediasource/MediaSource.idl: Added isTypeSupported().
- platform/MIMETypeRegistry.h:
(MIMETypeRegistry): Added isSupportedMediaSourceMIMEType().
- platform/chromium/MIMETypeRegistryChromium.cpp:
(WebCore):
(WebCore::MIMETypeRegistry::isSupportedMediaSourceMIMEType): Implemented in terms of WebMimeRegistry::isSupportedMediaSourceMIMEType.
LayoutTests:
- http/tests/media/media-source/video-media-source-is-type-supported-expected.txt: Added. Reflects Chromium expectations.
Valid MP4 type strings will return true
instead of false in Chrome builds.
- http/tests/media/media-source/video-media-source-is-type-supported.html: Added.
- 10:18 AM Changeset in webkit [146359] by
-
- 2 edits in trunk/Tools
Unreviewed. Adding another email for me.
- Scripts/webkitpy/common/config/committers.py:
- 9:56 AM Changeset in webkit [146358] by
-
- 3 edits in trunk/Source/WebCore
[WinCairo] Unreviewed VS2010 build correction.
- WebCore.vcxproj/WebCore.vcxproj: Enable build of NetworkStorageSessionStub.cpp
for WinCairo port.
- WebCore.vcxproj/WebCore.vcxproj.filters: Correct build type of
CookieJarCurl from 'custom' to 'C++ source file'
- 9:55 AM Changeset in webkit [146357] by
-
- 2 edits in trunk/Source/WebCore
[V8] Rename DOMDataStore::isMainWorldObject
https://bugs.webkit.org/show_bug.cgi?id=112817
Patch by Marja Hölttä <marja@chromium.org> on 2013-03-20
Reviewed by Jochen Eisinger.
No new tests (no changes in functionality).
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::getWrapperFast):
(WebCore::DOMDataStore::getWrapper):
(WebCore::DOMDataStore::getWrapperForMainWorld):
(WebCore::DOMDataStore::setWrapper):
(WebCore::DOMDataStore::canExistInWorker):
- 9:49 AM Changeset in webkit [146356] by
-
- 4 edits in trunk/Source/WebKit2
[Qt][WK2] Clean up sanity checks related to gesture recognition
https://bugs.webkit.org/show_bug.cgi?id=112679
Reviewed by Jocelyn Turcotte.
The only callers of the panGestureActive and pinchGestureActive member
functions of the page viewport controller client are event delivery
related sanity check assers, thus they can be replaced by checking
for the corresponding internal states and therefore the superfluous
members can be removed.
Also update other asserts in the page viewport controller client to
be more accurate about the expected states.
- UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::animateContentRectVisible):
(WebKit::PageViewportControllerClientQt::touchBegin):
(WebKit::PageViewportControllerClientQt::panGestureStarted):
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
- UIProcess/qt/PageViewportControllerClientQt.h:
(PageViewportControllerClientQt):
- UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::handleInputEvent):
- 9:45 AM Changeset in webkit [146355] by
-
- 6 edits in trunk/Source/WebKit2
[Qt][WK2] Refactor handling of content suspension to properly cover corner cases
https://bugs.webkit.org/show_bug.cgi?id=111751
Reviewed by Jocelyn Turcotte.
The current suspend / resume infrastructure turned out to be insufficient to cover
all corner cases during transitions between gestures of complex gesture chains.
The requirements for robust suspend / resume handling are:
- Keep the content suspended while the user is continuously interacting,
eg. does not lift the finger between transition from a pan to a pinch gesture
and vice versa.
- The content should not be suspended unnecessarily (like for a tap gesture),
only during panning and scroll animation (flick), as well as pinch zoom and scale
animation (also includes double-tap-to-zoom).
- The content should never end up stuck in suspended state after long gesture
chains and continuous interaction.
This patch reintroduces reference counting based suspension in form of a new
ViewportInteractionTracker member class to make it possible to reliably control the
suspend / resume cycles during scrolling and scaling.
During continuous gestures, while the user is interacting, the reference count is
increased without actually suspending the content to prevent resuming unnecessarily
during continuous interaction. At the same time this also assures that the page is
not suspended for simple tap gestures, which was a side-effect of the previous
approach based on update deferrers.
The newly added functionality replaces boolean members that tried to achive the
above requirements.
Additionally this patch also removes the redundant m_hasSuspendedContent member
from the PageViewportController since WebPageProxy already keeps this information.
- UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::pageDidRequestScroll):
(WebKit::PageViewportController::updateMinimumScaleToFit):
- UIProcess/PageViewportController.h:
(PageViewportController):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::areActiveDOMObjectsAndAnimationsSuspended):
- UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::PageViewportControllerClientQt):
(WebKit::PageViewportControllerClientQt::ViewportInteractionTracker::begin):
(WebKit):
(WebKit::PageViewportControllerClientQt::ViewportInteractionTracker::end):
(WebKit::PageViewportControllerClientQt::animateContentRectVisible):
(WebKit::PageViewportControllerClientQt::flickMoveStarted):
(WebKit::PageViewportControllerClientQt::flickMoveEnded):
(WebKit::PageViewportControllerClientQt::pageItemPositionChanged):
(WebKit::PageViewportControllerClientQt::scaleAnimationStateChanged):
(WebKit::PageViewportControllerClientQt::touchBegin):
(WebKit::PageViewportControllerClientQt::touchEnd):
(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
(WebKit::PageViewportControllerClientQt::pinchGestureRequestUpdate):
(WebKit::PageViewportControllerClientQt::pinchGestureEnded):
(WebKit::PageViewportControllerClientQt::pinchGestureCancelled):
(WebKit::PageViewportControllerClientQt::didChangeContentsSize):
- UIProcess/qt/PageViewportControllerClientQt.h:
(ViewportInteractionTracker):
(WebKit::PageViewportControllerClientQt::ViewportInteractionTracker::ViewportInteractionTracker):
(WebKit::PageViewportControllerClientQt::ViewportInteractionTracker::inProgress):
(PageViewportControllerClientQt):
- 9:19 AM Changeset in webkit [146354] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Flame Chart. Provide Overview pane for better user expirience.
https://bugs.webkit.org/show_bug.cgi?id=112496
Reviewed by Yury Semikhatsky.
This patch implements basic part of Overview Pane in FlameChart.
The idea of the patch is to move everything into chart-container element.
And put OverviewGrid into new overview-container element.
Drive by change: fix the layout of the flame chart elements.
Drive by change: fix the drag window & drag resizer mechanics
for the case when the parent element has zero offsetLeft.
- inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.OverviewCalculator):
(WebInspector.FlameChart.OverviewCalculator.prototype._updateBoundaries):
(WebInspector.FlameChart.OverviewCalculator.prototype.computePosition):
(WebInspector.FlameChart.OverviewCalculator.prototype.formatTime):
(WebInspector.FlameChart.OverviewCalculator.prototype.maximumBoundary):
(WebInspector.FlameChart.OverviewCalculator.prototype.minimumBoundary):
(WebInspector.FlameChart.OverviewCalculator.prototype.boundarySpan):
(WebInspector.FlameChart.prototype._onWindowChanged):
(WebInspector.FlameChart.prototype._adjustXScale):
(WebInspector.FlameChart.prototype.update):
- inspector/front-end/OverviewGrid.js:
(WebInspector.OverviewGrid.Window):
(WebInspector.OverviewGrid.Window.prototype._resizerElementStartDragging):
(WebInspector.OverviewGrid.Window.prototype._leftResizeElementDragging):
(WebInspector.OverviewGrid.Window.prototype._rightResizeElementDragging):
(WebInspector.OverviewGrid.Window.prototype._startWindowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._windowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._endWindowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._setWindowPosition):
(WebInspector.OverviewGrid.Window.prototype._onMouseWheel):
(WebInspector.OverviewGrid.WindowSelector):
- inspector/front-end/TimelineOverviewPane.js:
- inspector/front-end/flameChart.css:
(.chart-container .item-anchor):
(.overview-container):
(.chart-container):
(#flame-chart-overview-grid .resources-dividers-label-bar):
- inspector/front-end/inspectorCommon.css:
(.resources-divider-label):
- 9:07 AM Changeset in webkit [146353] by
-
- 7 edits in trunk/Source/WebCore
Web Inspector: Plumbing CSS warnings
https://bugs.webkit.org/show_bug.cgi?id=111334
Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-20
Reviewed by Pavel Feldman.
Adding a framework for plumbing CSS warnings from CSSParser/grammar to the Inspector console.
- css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::syntaxError):
(WebCore):
(WebCore::CSSParser::isLoggingErrors):
(WebCore::CSSParser::logError):
- css/CSSParser.h:
(CSSParser):
(CSSParser::Location):
(WebCore):
- css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::parseAuthorStyleSheet):
(WebCore::StyleSheetContents::parseString):
(WebCore::StyleSheetContents::parseStringAtLine):
- css/StyleSheetContents.h:
(StyleSheetContents):
- dom/StyleElement.cpp:
(WebCore::StyleElement::createSheet):
- page/PageConsole.cpp:
(WebCore::PageConsole::addMessage):
- 9:05 AM Changeset in webkit [146352] by
-
- 1 edit1 delete in trunk/LayoutTests
[Qt] Qt 4.8 expected results removal from Trunk.
Reviewed by Csaba Osztrogonác.
- platform/qt-4.8/TestExpectations: Removed.
- platform/qt-4.8/css1/text_properties/text_transform-expected.txt: Removed.
- platform/qt-4.8/editing/selection/regional-indicators-expected.txt: Removed.
- platform/qt-4.8/fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt: Removed.
- platform/qt-4.8/fast/dom/Range/surround-contents-font-face-crash-expected.txt: Removed.
- platform/qt-4.8/fast/dom/xml-parser-error-message-crash-expected.txt: Removed.
- platform/qt-4.8/fast/encoding/dumpAsText/utf-16-no-bom-expected.txt: Removed.
- platform/qt-4.8/fast/events/xsl-onload-expected.txt: Removed.
- platform/qt-4.8/fast/parser/xml-colon-entity-expected.txt: Removed.
- platform/qt-4.8/fast/parser/xml-declaration-missing-ending-mark-expected.txt: Removed.
- platform/qt-4.8/fast/parser/xslt-with-html-expected.txt: Removed.
- platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png: Removed.
- platform/qt-4.8/fast/text/find-kana-expected.txt: Removed.
- platform/qt-4.8/fast/text/find-russian-expected.txt: Removed.
- platform/qt-4.8/fast/text/find-soft-hyphen-expected.txt: Removed.
- platform/qt-4.8/fast/url/path-expected.txt: Removed.
- platform/qt-4.8/fast/xsl/subframe-location-expected.txt: Removed.
- platform/qt-4.8/fast/xsl/transform-to-html-expected.txt: Removed.
- platform/qt-4.8/fast/xsl/utf8-chunks-expected.txt: Removed.
- platform/qt-4.8/fast/xsl/xslt-bad-import-uri-expected.txt: Removed.
- platform/qt-4.8/fast/xsl/xslt-doc-noenc-expected.txt: Removed.
- platform/qt-4.8/fast/xsl/xslt-entity-enc-expected.txt: Removed.
- platform/qt-4.8/fast/xsl/xslt-entity-expected.png: Removed.
- platform/qt-4.8/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Removed.
- platform/qt-4.8/fast/xsl/xslt-recursion-expected.txt: Removed.
- platform/qt-4.8/http/tests/misc/location-test-xsl-style-sheet-expected.txt: Removed.
- platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-allowed-expected.txt: Removed.
- platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt: Removed.
- platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2-expected.txt: Removed.
- platform/qt-4.8/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.png: Removed.
- platform/qt-4.8/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.txt: Removed.
- platform/qt-4.8/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.png: Removed.
- platform/qt-4.8/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.txt: Removed.
- platform/qt-4.8/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Removed.
- platform/qt-4.8/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Removed.
- platform/qt-4.8/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Removed.
- platform/qt-4.8/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Removed.
- platform/qt-4.8/http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt: Removed.
- platform/qt-4.8/http/tests/xmlhttprequest/methods-expected.txt: Removed.
- platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Removed.
- platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-expected.txt: Removed.
- platform/qt-4.8/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Removed.
- platform/qt-4.8/svg/custom/bug45331-expected.png: Removed.
- platform/qt-4.8/svg/custom/bug45331-expected.txt: Removed.
- platform/qt-4.8/svg/custom/bug78807-expected.txt: Removed.
- platform/qt-4.8/svg/custom/use-invalid-html-expected.txt: Removed.
- platform/qt-4.8/svg/custom/use-invalid-style-expected.txt: Removed.
- platform/qt-4.8/svg/hixie/error/dumpAsText/004-expected.txt: Removed.
- platform/qt-4.8/svg/hixie/error/dumpAsText/005-expected.txt: Removed.
- 8:59 AM Changeset in webkit [146351] by
-
- 27 edits in trunk
[Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
https://bugs.webkit.org/show_bug.cgi?id=112605
Reviewed by James Robinson.
Source/WebCore:
Deleting all the code that was used for propagating and supporting
the Chromium setting for disabling deferred 2d canvas rendering.
No new tests: Affected code paths covered by existing tests.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer):
- html/HTMLCanvasElement.h:
- page/Settings.in:
- platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create):
(ImageBuffer):
- platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
(WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::prepareForDraw):
(WebCore::Canvas2DLayerBridge::storageAllocatedForRecordingChanged):
(WebCore::Canvas2DLayerBridge::storageAllocatedForRecording):
(WebCore::Canvas2DLayerBridge::freeMemoryIfPossible):
(WebCore::Canvas2DLayerBridge::flush):
(WebCore::Canvas2DLayerBridge::skCanvas):
(WebCore::Canvas2DLayerBridge::prepareTexture):
(WebCore::Canvas2DLayerBridge::contextAcquired):
- platform/graphics/chromium/Canvas2DLayerBridge.h:
(WebCore::Canvas2DLayerBridge::create):
(Canvas2DLayerBridge):
- platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::createAcceleratedCanvas):
(WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/wince/ImageBufferWinCE.cpp:
(WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/wx/ImageBufferWx.cpp:
(WebCore::ImageBuffer::ImageBuffer):
Source/WebKit/chromium:
Deleting all the code that was used for propagating and supporting
the Chromium setting for disabling deferred 2d canvas rendering.
- public/WebSettings.h:
(WebKit::WebSettings::setDeferred2dCanvasEnabled):
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setDeferred2dCanvasEnabled):
- tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):
- tests/Canvas2DLayerManagerTest.cpp:
(FakeCanvas2DLayerBridge::FakeCanvas2DLayerBridge):
Tools:
Deleting all the code that was used for propagating and supporting
the Chromium setting for disabling deferred 2d canvas rendering.
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
- DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
(WebTestRunner::WebPreferences::applyTo):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
(TestShell::runFileTest):
- DumpRenderTree/chromium/TestShell.h:
(TestShell):
LayoutTests:
Marked some 2d canvas tests as failing. These tests are using the
two point radial gradient API. The bug was already present in
chromium. Starts getting detected in DRT with this change.
Related: crbug.com/222140
- 8:42 AM Changeset in webkit [146350] by
-
- 6 edits in trunk
Drop full URLs from cross-domain access errors caused by 'document.domain' mismatches.
https://bugs.webkit.org/show_bug.cgi?id=112813
Reviewed by Timothy Hatcher.
Source/WebCore:
Following up on http://wkbug.com/112042, this patch brings 'document.domain'
mismatch error messages into line with the newly origin-only default
message. There will probably be two or three more patches in this series
just to keep the rebaselines down to something managably reviewable.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::crossDomainAccessErrorMessage):
Move the default message redefinition up out of the final 'return' so
that 'document.domain' mismatch errors grab the new text.
LayoutTests:
- http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
- http/tests/security/cross-frame-access-child-explicit-domain-expected.txt:
- http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:
- 8:40 AM Changeset in webkit [146349] by
-
- 10 edits in trunk/Source
Web Inspector: Add promptText param to Page.handleJavaScriptDialog
https://bugs.webkit.org/show_bug.cgi?id=112706
Patch by Ken Kania <kkania@chromium.org> on 2013-03-20
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/Inspector.json:
- inspector/InspectorClient.h:
(WebCore::InspectorClient::handleJavaScriptDialog):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::handleJavaScriptDialog):
- inspector/InspectorPageAgent.h:
Source/WebKit/chromium:
- src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::handleJavaScriptDialog):
- src/InspectorClientImpl.h:
(InspectorClientImpl):
- src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
- src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):
- 8:28 AM Changeset in webkit [146348] by
-
- 1 copy in releases/WebKitGTK/webkit-1.11.92
Tagging the WebKitGTK+ 1.11.92 release
- 8:10 AM Changeset in webkit [146347] by
-
- 3 edits in trunk/Tools
[Qt] Qt 4.8 tool related stuff removal from webkitpy.
https://bugs.webkit.org/show_bug.cgi?id=112699.
Reviewed by Adam Barth.
- Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._search_paths):
(QtPort._port_specific_expectations_files):
- Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest):
(QtPortTest._assert_search_path):
(QtPortTest._assert_expectations_files):
- 8:09 AM Changeset in webkit [146346] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0
Unreviewed. Update NEWS and Versions.m4 for 1.11.92 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 1.11.92.
- 7:59 AM Changeset in webkit [146345] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix SourceFrame.js compilation warning
https://bugs.webkit.org/show_bug.cgi?id=112804
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-20
Reviewed by Yury Semikhatsky.
No new tests: no change in behavior.
- Explicitly parse lineNumber from object property name.
- Add type annotations to ensure addMessageToSource is monomorphic.
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.clearMessages):
- 7:34 AM Changeset in webkit [146344] by
-
- 2 edits in trunk/Source/WebCore
[v8] unsafe persistent access in V8LazyEventListener
https://bugs.webkit.org/show_bug.cgi?id=112807
Patch by Dan Carney <dcarney@google.com> on 2013-03-20
Reviewed by Kentaro Hara.
No new tests.
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::toObjectWrapper):
- 7:32 AM Changeset in webkit [146343] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Enable appropriate vertex attribute arrays in LayerRenderer::useProgram()
https://bugs.webkit.org/show_bug.cgi?id=112757
Reviewed by Rob Buis.
PR 306465
Make the LayerRenderer and associated code more bullet-proof when it
comes to enabling vertex attribute arrays, by enabling them already
when LayerRenderer::useProgram() is called. This fixes a bug where the
video hole punch rectangle wasn't punched when preceding rendering
caused the vertex attribute array at index 0 to be disabled, such as
when rendering the text selection overlay immediately before video.
A number of places where the position attribute index was hard-coded
to 0 were also fixed. This causes no change in behavior, the position
attribute was really at 0, but nonetheless that shouldn't be hardcoded.
The effects of this patch are only manually testable.
- platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::compositeBuffer):
(WebCore::LayerRenderer::drawColor):
(WebCore::LayerRenderer::drawDebugBorder):
(WebCore::LayerRenderer::drawHolePunchRect):
(WebCore::LayerRenderer::compositeLayersRecursive):
(WebCore::LayerRenderer::useProgram):
- 7:30 AM Changeset in webkit [146342] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: [CodeMirror] implement highlightRange method
https://bugs.webkit.org/show_bug.cgi?id=112802
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-20
Reviewed by Vsevolod Vlasov.
- Implement highlightRange/removeHighlight methods in
CodeMirrorTextEditor.
- Update TextEditor interface closure annotations.
No new tests.
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.prototype.removeHighlight):
(WebInspector.CodeMirrorTextEditor.prototype.highlightRange):
- inspector/front-end/DefaultTextEditor.js:
- inspector/front-end/TextEditor.js:
- 7:28 AM Changeset in webkit [146341] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [CodeMirror] show source location for codemirror text editor
https://bugs.webkit.org/show_bug.cgi?id=112798
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-20
Reviewed by Vsevolod Vlasov.
No new tests.
- Implement CodeMirrorTextEditor.copyRange method
- Fire "selectionChange" event for text editor delegate from
CodeMirrorTextEditor.
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.copyRange):
(WebInspector.CodeMirrorTextEditor.prototype._cursorActivity):
- 7:18 AM Changeset in webkit [146340] by
-
- 7 edits in trunk
[Qt] Enable kerning by default
https://bugs.webkit.org/show_bug.cgi?id=112704
Reviewed by Jocelyn Turcotte.
Source/WebKit/qt:
Enable default kerning when fast kerning is available.
To support layout tests that depend on kerning being off by default,
a method is added to DumpRenderTreeSupportQt to reset the default.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::resetDefaultTypesettingFeatures):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
- WebCoreSupport/InitWebCoreQt.cpp:
(WebKit::initializeWebKitQt):
Tools:
Disable kerning by default, since some reference test expectations
expect kerning to be default off.
- DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunnerQt::reset):
- WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
- 7:06 AM Changeset in webkit [146339] by
-
- 2 edits in trunk/Source/JavaScriptCore
Implement and32 on MIPS platform
https://bugs.webkit.org/show_bug.cgi?id=112665
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-03-20
Reviewed by Zoltan Herczeg.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::and32): Added missing method.
(MacroAssemblerMIPS):
- 6:38 AM Changeset in webkit [146338] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0
Unreviewed. Fix make distcheck.
- GNUmakefile.am: Add WebKitFeatures.txt and WebKitFeatures.h to
DISTCLEANFILES.
- 6:29 AM Changeset in webkit [146337] by
-
- 3 edits in trunk/Tools
[Qt] Remove empty function stubs from TestRunnerQt.
https://bugs.webkit.org/show_bug.cgi?id=112799
We are reducing the code in TestRunnerQt step by step,
in order to finally replace all of it with the generic
TestRunner implementation.
This patch removes several simple function stubs that
currently do not implement any actual functionality.
Reviewed by Kenneth Rohde Christiansen.
- DumpRenderTree/qt/TestRunnerQt.cpp:
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):
- 6:24 AM WebKitGTK/2.0.x edited by
- (diff)
- 6:21 AM Changeset in webkit [146336] by
-
- 1 edit1 add in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merged 146335 - [or] Updated WebKitGTK+ Translation for Odia [or] language.
https://bugs.webkit.org/show_bug.cgi?id=103037
Patch by Manoj Kumar Giri <mgiri@redhat.com> on 2013-03-20
Rubber-stamped by Gustavo Noronha Silva (kov).
- or.po: Added.
- 6:16 AM Changeset in webkit [146335] by
-
- 1 edit1 add in trunk/Source/WebCore/platform/gtk/po
[or] Updated WebKitGTK+ Translation for Odia [or] language.
https://bugs.webkit.org/show_bug.cgi?id=103037
Patch by Manoj Kumar Giri <mgiri@redhat.com> on 2013-03-20
Rubber-stamped by Gustavo Noronha Silva (kov).
- or.po: Added.
- 6:08 AM Changeset in webkit [146334] by
-
- 4 edits in trunk
Unreviewed, rolling out r146331.
http://trac.webkit.org/changeset/146331
https://bugs.webkit.org/show_bug.cgi?id=112795
Does not work as expected (Requested by carewolf on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20
Source/WebCore:
- platform/graphics/qt/FontQt.cpp:
(WebCore::Font::initFormatForTextLayout):
LayoutTests:
- platform/qt/TestExpectations:
- 5:43 AM Changeset in webkit [146333] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Resources] Local Storage: "Add item" row height doesn't match underlying grid.
https://bugs.webkit.org/show_bug.cgi?id=112433
Reviewed by Pavel Feldman.
Fixed cell height to correspond grid step.
- inspector/front-end/dataGrid.css:
(.data-grid td): Fixed cell height to correspond grid step.
- 5:26 AM Changeset in webkit [146332] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
https://bugs.webkit.org/show_bug.cgi?id=112687
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-20
Reviewed by Kenneth Rohde Christiansen.
Hide the SearchBar by default on window creation.
- MiniBrowser/efl/main.c:
(window_create):
- 4:53 AM Changeset in webkit [146331] by
-
- 4 edits in trunk
[Qt] New fast/text/word-space-with-kerning-3.html fails on Qt
https://bugs.webkit.org/show_bug.cgi?id=112668
Reviewed by Jocelyn Turcotte.
Source/WebCore:
Kerning is on by default in Qt. This means we need to disable it
when WebCore does not request it.
- platform/graphics/qt/FontQt.cpp:
(WebCore::Font::initFormatForTextLayout):
LayoutTests:
- platform/qt/TestExpectations:
- 4:51 AM Changeset in webkit [146330] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: OverviewGrid rename classes according to names of js classes.
https://bugs.webkit.org/show_bug.cgi?id=112786
Reviewed by Yury Semikhatsky.
It is a part of meta bug 'extract OverviewGrid from TimelineOverviewPane'.
As the last step it renames timeline-...... classes to overview-grid-...... classes
and moves them to inspectorCommon.css
- inspector/front-end/OverviewGrid.js:
(WebInspector.OverviewGrid):
(WebInspector.OverviewGrid.Window):
(WebInspector.OverviewGrid.Window.prototype._startWindowSelectorDragging):
(WebInspector.OverviewGrid.WindowSelector):
(WebInspector.OverviewGrid.WindowSelector.prototype._createSelectorElement):
- inspector/front-end/inspectorCommon.css:
(.overview-grid-window-selector):
(.overview-grid-window):
(.overview-grid-dividers-background):
(.overview-grid-window-rulers):
(.overview-grid-window-resizer):
- inspector/front-end/timelinePanel.css:
(.timeline-frame-overview .overview-grid-window):
(.timeline-frame-overview .overview-grid-dividers-background):
- 4:50 AM Changeset in webkit [146329] by
-
- 11 edits5 moves1 add1 delete in trunk/Tools
Unreviewed, rolling out r146304.
http://trac.webkit.org/changeset/146304
https://bugs.webkit.org/show_bug.cgi?id=112788
to many expectations to update (Requested by antonm on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebKit):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
- DumpRenderTree/chromium/TestShell.h:
(WebKit):
- DumpRenderTree/chromium/TestShellMac.mm:
(platformInit):
- DumpRenderTree/chromium/TestShellWin.cpp:
(platformInit):
- DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
(WebThemeControlDRTWin::WebThemeControlDRTWin):
(WebThemeControlDRTWin::~WebThemeControlDRTWin):
(WebThemeControlDRTWin::box):
(WebThemeControlDRTWin::line):
(WebThemeControlDRTWin::triangle):
(WebThemeControlDRTWin::roundRect):
(WebThemeControlDRTWin::oval):
(WebThemeControlDRTWin::circle):
(WebThemeControlDRTWin::nestedBoxes):
(WebThemeControlDRTWin::markState):
(WebThemeControlDRTWin::draw):
(WebThemeControlDRTWin::drawTextField):
(WebThemeControlDRTWin::drawProgressBar):
- DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
(WebThemeControlDRTWin):
- DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
(WebThemeEngineDRTMac):
- DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
(+[FakeActiveWindow alwaysActiveWindow]):
(+[FakeActiveWindow alwaysInactiveWindow]):
(-[FakeActiveWindow initWithActiveControls:]):
(-[FakeActiveWindow _hasActiveControls]):
(WebThemeEngineDRTMac::paintScrollbarThumb):
(stateToHIEnableState):
(WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
(WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
- DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
(webRectToSkIRect):
(drawControl):
(drawTextField):
(drawProgressBar):
(WebThemeEngineDRTWin::paintButton):
(WebThemeEngineDRTWin::paintMenuList):
(WebThemeEngineDRTWin::paintScrollbarArrow):
(WebThemeEngineDRTWin::paintScrollbarThumb):
(WebThemeEngineDRTWin::paintScrollbarTrack):
(WebThemeEngineDRTWin::paintSpinButton):
(WebThemeEngineDRTWin::paintTextField):
(WebThemeEngineDRTWin::paintTrackbar):
(WebThemeEngineDRTWin::paintProgressBar):
(WebThemeEngineDRTWin::getSize):
- DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
(WebThemeEngineDRTWin):
(WebThemeEngineDRTWin::WebThemeEngineDRTWin):
- 4:43 AM Changeset in webkit [146328] by
-
- 3 edits1 delete in trunk/LayoutTests
Unreviewed, rolling out r146315.
http://trac.webkit.org/changeset/146315
https://bugs.webkit.org/show_bug.cgi?id=112789
followup to 146304 rollout (Requested by antonm on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20
- platform/chromium-mac-snowleopard/css1/box_properties/border_right_inline-expected.png:
- platform/chromium-win-xp/css1/box_properties/border_right_inline-expected.png: Removed.
- platform/chromium-win/css1/box_properties/border_right_inline-expected.png:
- 4:41 AM Changeset in webkit [146327] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r146316.
http://trac.webkit.org/changeset/146316
https://bugs.webkit.org/show_bug.cgi?id=112790
followup to 146304 rollout (Requested by antonm on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20
- platform/chromium-win/fast/layers/scroll-with-transform-composited-layer-expected.png:
- 4:31 AM Changeset in webkit [146326] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Switch Drawer animation from JavaScript to CSS transitions.
https://bugs.webkit.org/show_bug.cgi?id=112586
This is prerequisite to make Drawer work in overlay mode.
Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-20
Reviewed by Vsevolod Vlasov.
- inspector/front-end/Drawer.js:
(WebInspector.Drawer):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide.this.animationFinished):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype.immediatelyFinishAnimation):
(WebInspector.Drawer.prototype._getAnimationStyles):
- inspector/front-end/UIUtils.js:
- inspector/front-end/inspector.css:
(.animate-slow *):
(.animate #main):
(.animate #floating-status-bar-container):
(.animate #drawer):
(.animate #bottom-status-bar-container > *):
- 4:30 AM Changeset in webkit [146325] by
-
- 18 edits in trunk
Web Inspector: [DataGrid] Refactorings.
https://bugs.webkit.org/show_bug.cgi?id=112690
Reviewed by Pavel Feldman.
Source/WebCore:
- Avoid using string literals;
- Remove unused notifications; turn "populate" to method invocation;
- Replace some getters with regular functions.
- inspector/front-end/DataGrid.js: Applied refactorings.
- inspector/front-end/ApplicationCacheItemsView.js: Adopted changes.
- inspector/front-end/BottomUpProfileDataGridTree.js: Ditto.
- inspector/front-end/CPUProfileView.js: Ditto.
- inspector/front-end/CSSSelectorProfileView.js: Ditto.
- inspector/front-end/CookiesTable.js: Ditto.
- inspector/front-end/DirectoryContentView.js: Ditto.
- inspector/front-end/HeapSnapshotDataGrids.js: Ditto.
- inspector/front-end/HeapSnapshotGridNodes.js: Ditto.
- inspector/front-end/NativeMemorySnapshotView.js: Ditto.
- inspector/front-end/NetworkPanel.js: Ditto.
- inspector/front-end/ProfileDataGridTree.js: Ditto.
- inspector/front-end/ResourceWebSocketFrameView.js: Ditto.
- inspector/front-end/TopDownProfileDataGridTree.js: Ditto.
- inspector/front-end/dataGrid.css: Ditto.
LayoutTests:
Adopted changes.
- inspector/profiler/heap-snapshot-test.js: Adopted changes.
- 4:22 AM Changeset in webkit [146324] by
-
- 7 edits in trunk
[Qt] Support -webkit-font-smoothing
https://bugs.webkit.org/show_bug.cgi?id=106009
Reviewed by Jocelyn Turcotte.
Source/WebCore:
Set QFont antialiasing settings based on the font smoothing settings in FontDescription.
- platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
Source/WebKit/qt:
Export an interface so DRT can also disable font-smoothing like WTR does.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setShouldUseFontSmoothing):
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Tools:
Set shouldUseFontSmoothing to false to match WebKitTestRunner.
- DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunnerQt::reset):
- 4:05 AM Changeset in webkit [146323] by
-
- 1 edit3 adds in trunk/LayoutTests
[Qt] Unreviewed rebaselining after r146206.
The webgl-composite-modes test started failing due to
the newly introduced more restrictive pixel tolerance.
It turns out that the expectation was created without multisampling
enabled. However, Qt does implement this.
- platform/qt/fast/canvas/webgl/webgl-composite-modes-expected.png: Added.
- platform/qt/fast/canvas/webgl/webgl-composite-modes-expected.txt: Added.
- 4:04 AM Changeset in webkit [146322] by
-
- 2 edits in trunk/Source/WebKit/efl
ewk_settings_memory_cache_clear should clear JS garbage and release FastMalloc's free pages to OS
https://bugs.webkit.org/show_bug.cgi?id=112536
Patch by Jose Lejin PJ <jose.lejin@gmail.com> on 2013-03-20
Reviewed by Gyuyoung Kim.
Added changes to clear JS garbage and release FastMalloc's free pages to OS
while calling ewk_settings_memory_cache_clear API.
- ewk/ewk_settings.cpp:
(ewk_settings_memory_cache_clear):
- 3:15 AM Changeset in webkit [146321] by
-
- 3 edits in trunk/LayoutTests
[EFL] accessibility/aria-scrollbar-role.html is failing
https://bugs.webkit.org/show_bug.cgi?id=111989
Unreviewed EFL gardening
accessibility/aria-scrollbar-role.html passes after r146312.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-20
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- 3:01 AM Changeset in webkit [146320] by
-
- 6 edits1 add in trunk
[EFL] Disable REQUEST_ANIMATION_FRAME_TIMER to render a new animation frame.
https://bugs.webkit.org/show_bug.cgi?id=112114
Patch by JungJik Lee <jungjik.lee@samsung.com> on 2013-03-20
Reviewed by Kenneth Rohde Christiansen.
.:
Add a manual test to check the running of scripted transition animation.
- ManualTests/animation/transition-on-and-offscreen-animation.html: Added.
Source/WebKit/efl:
Add dummy functions for WK1.
Example test case: ManualTests/animation/transition-on-and-offscreen-animation.html
- WebCoreSupport/ChromeClientEfl.cpp: Add dummy functions for WK1.
(WebCore):
(WebCore::ChromeClientEfl::scheduleAnimation):
(WebCore::ChromeClientEfl::serviceScriptedAnimations):
- WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
Source/WTF:
The issue is that if the animation starts outside of the area covered by keepRects,
the web process does not create tiles of the animation layer and the layer moves
without having any tiles. In order to fix this issue, CoordinatedLayerHost must call
scheduleLayerFlush to create new tiles when the layer enters the area covered by keepRect.
However EFL port didn't call scheduleLayerFlush periodically for animation.
We can tie scripted animations with synchronization of the layer and that already
has been implemented in r123786 by Qt port. This patch is for activating r123786 patch.
The testing is covered by ManualTests/animation/transition-on-and-offscreen-animation.html
- wtf/Platform.h: Disable REQUEST_ANIMATION_FRAME_TIMER.
- 3:01 AM Changeset in webkit [146319] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Allow toolbar customization
https://bugs.webkit.org/show_bug.cgi?id=112440
Adds a tools menu item that allows the user to show/hide
inspector panels on the toolbar.
Patch by Alexei Filippov <alph@chromium.org> on 2013-03-20
Reviewed by Yury Semikhatsky.
- inspector/front-end/InspectorView.js:
- inspector/front-end/Settings.js:
(WebInspector.Settings):
(WebInspector.ExperimentsSettings):
- inspector/front-end/Toolbar.js:
(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype.addPanel):
(WebInspector.Toolbar.prototype._isPanelVisibleByDefault):
(WebInspector.Toolbar.prototype.set _hidePanel):
(WebInspector.Toolbar.prototype._showPanel):
(WebInspector.Toolbar.prototype._togglePanelsMenu):
- inspector/front-end/inspector.css:
(#toolbar-panels-menu):
(#toolbar-panels-menu:hover):
(#toolbar-panels-menu:active):
- inspector/front-end/inspector.html:
- 2:09 AM Changeset in webkit [146318] by
-
- 26 edits in trunk/Source
Source/JavaScriptCore: Fix incorrect debugger column number value.
https://bugs.webkit.org/show_bug.cgi?id=112741.
Reviewed by Oliver Hunt.
- In lexer, parser, and debugger code, renamed column to charPosition.
- Convert the charPosition to the equivalent column number before passing it to the debugger.
- Changed ScopeNodes to take both a startLocation and an endLocation. This allows FunctionBodyNodes, ProgramNodes, and EvalNodess to emit correct debug hooks with correct starting line and column numbers.
- Fixed the Lexer to not reset the charPosition (previously columnNumber) in Lexer::lex().
- JavaScriptCore.order:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitExpressionInfo):
- bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::toArgumentList):
(JSC::ConstStatementNode::emitBytecode):
(JSC::EmptyStatementNode::emitBytecode):
(JSC::DebuggerStatementNode::emitBytecode):
(JSC::ExprStatementNode::emitBytecode):
(JSC::VarStatementNode::emitBytecode):
(JSC::IfNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::SwitchNode::emitBytecode):
(JSC::LabelNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):
(JSC::TryNode::emitBytecode):
(JSC::ProgramNode::emitBytecode):
(JSC::EvalNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::debug):
- convert charPosition to column for the debugger.
- interpreter/Interpreter.h:
- jit/JITStubs.cpp:
(DEFINE_STUB_FUNCTION(void, op_debug)):
- llint/LLIntSlowPaths.cpp:
(LLINT_SLOW_PATH_DECL(slow_op_debug)):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createBlockStatement):
(JSC::ASTBuilder::createExprStatement):
(JSC::ASTBuilder::createIfStatement):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createReturnStatement):
(JSC::ASTBuilder::createBreakStatement):
(JSC::ASTBuilder::createContinueStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createSwitchStatement):
(JSC::ASTBuilder::createWhileStatement):
(JSC::ASTBuilder::createDoWhileStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::createThrowStatement):
(JSC::ASTBuilder::createDebugger):
(JSC::ASTBuilder::createConstStatement):
- parser/Lexer.cpp:
(JSC::::setCode):
(JSC::::internalShift):
(JSC::::shift):
(JSC::::lex):
- parser/Lexer.h:
(JSC::Lexer::currentCharPosition):
(Lexer):
(JSC::::lexExpectIdentifier):
- parser/NodeConstructors.h:
(JSC::Node::Node):
- parser/Nodes.cpp:
(JSC::StatementNode::setLoc):
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):
- parser/Nodes.h:
(JSC::Node::charPosition):
(Node):
(StatementNode):
(JSC::StatementNode::lastLine):
(ScopeNode):
(JSC::ScopeNode::startLine):
(JSC::ScopeNode::startCharPosition):
(ProgramNode):
(EvalNode):
(FunctionBodyNode):
- parser/Parser.cpp:
(JSC::::Parser):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):
- parser/Parser.h:
(JSC::::parse):
- parser/ParserTokens.h:
(JSC::JSTokenLocation::JSTokenLocation):
(JSTokenLocation):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createFunctionBody):
Source/WTF: Introducing String::reverseFindLineTerminator().
https://bugs.webkit.org/show_bug.cgi?id=112741.
Reviewed by Oliver Hunt.
This is needed by the JSC debugger code for computing column numbers.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::reverseFindLineTerminator):
- wtf/text/StringImpl.h:
(StringImpl):
(WTF::reverseFindLineTerminator):
- wtf/text/WTFString.h:
(WTF::String::reverseFindLineTerminator):
- 2:08 AM Changeset in webkit [146317] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Settings] Add "storage" parameter to WebInspector.Setting
https://bugs.webkit.org/show_bug.cgi?id=112667
Reviewed by Pavel Feldman.
New parameter will allow more options on how long setting will persist.
Possible options are: localStorage, sessionStorage and no-storage.
Additional change: use delete instead of .removeItem to make it possible
use any object as storage.
- inspector/front-end/Settings.js:
Added "storage" parameter and used is instead of "window.localStorage".
- 1:55 AM Changeset in webkit [146316] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Chromium gardening.
Rebaselining after r146304.
- platform/chromium-win/fast/layers/scroll-with-transform-composited-layer-expected.png:
- 1:43 AM Changeset in webkit [146315] by
-
- 3 edits1 add in trunk/LayoutTests
Unreviewed Chromium gardening.
Rebaselining after r146304.
- platform/chromium-mac-snowleopard/css1/box_properties/border_right_inline-expected.png:
- platform/chromium-win-xp/css1/box_properties/border_right_inline-expected.png: Added.
- platform/chromium-win/css1/box_properties/border_right_inline-expected.png:
- 1:38 AM Changeset in webkit [146314] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Network] Fix the bug of WebSocketFrameView crash.
https://bugs.webkit.org/show_bug.cgi?id=112771.
Patch by Pan Deng <pan.deng@intel.com> on 2013-03-20
Reviewed by Pavel Feldman.
WebSocketFrameView crashes when websocket receives an error message, this
patch fixes this problem, and error message will be shown in dataGrid as expected.
No new tests.
- inspector/front-end/ResourceWebSocketFrameView.js:
(WebInspector.ResourceWebSocketFrameView): Handle the errorMessage case.
- 1:34 AM Changeset in webkit [146313] by
-
- 6 edits in trunk/Source/WebCore
Remove remainings of obsolete LogLevels and MessageSources from inspector JS part.
https://bugs.webkit.org/show_bug.cgi?id=112709
By the way tuned messagesources in ApplicationCacheGroup.
Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-20
Reviewed by Pavel Feldman.
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.toMessageElement):
(WebInspector.ConsoleMessageImpl.prototype.toString):
- inspector/front-end/ConsoleModel.js:
- inspector/front-end/ExtensionAPI.js:
(defineCommonExtensionSymbols):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onAddConsoleMessage):
(WebInspector.ExtensionServer.prototype._makeConsoleMessage):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFinishLoading):
(WebCore::ApplicationCacheGroup::didFail):
- 1:12 AM Changeset in webkit [146312] by
-
- 7 edits in trunk
[GTK] accessibility/aria-scrollbar-role.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98358
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-20
Reviewed by Martin Robinson.
Source/WebCore:
Adds support for checking an orientation attribute of accessibility object.
AccessibilityObject that represents ScrollBar element should be ATK_VALUE type.
ScrollBar element can be considered as a Range Widget that is able to expose some
range values.
Test: accessibility/aria-scrollbar-role.html
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(setAtkStateSetFromCoreObject):
(getInterfaceMaskFromObject):
Tools:
Adds support for checking accessibility object's orientation.
Orientation is checked by retrieving proper state of accessibility object.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(checkElementState):
(AccessibilityUIElement::orientation):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::orientation):
LayoutTests:
Fixed failing test.
- platform/gtk/TestExpectations:
- 1:07 AM Changeset in webkit [146311] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fixing a typo in libLevelDB_la_CFLAGS assignment - cxflags -> cflags.
- GNUmakefile.am:
- 1:03 AM Changeset in webkit [146310] by
-
- 3 edits2 adds in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining after r146305.
- platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/gtk/http/tests/security/contentSecurityPolicy/1.1: Added.
- platform/gtk/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt: Added.
- 12:52 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 12:51 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 12:43 AM Changeset in webkit [146309] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r146089): It broke 20 sputnik tests on ARM traditional and Thumb2
https://bugs.webkit.org/show_bug.cgi?id=112676
Rubber-stamped by Filip Pizlo.
Add one more EABI_32BIT_DUMMY_ARG to make DFG JIT ARM EABI compatible
again after r146089 similar to https://bugs.webkit.org/show_bug.cgi?id=84449
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- 12:16 AM Changeset in webkit [146308] by
-
- 3 edits2 adds in trunk
Absolute position div without width specified does not reflow its text when it is moved (and computed width changes)
https://bugs.webkit.org/show_bug.cgi?id=112052
Source/WebCore:
Reviewed by Emil A Eklund.
If a positioned block has auto width then any movement means the block needs to be resized.
Test: fast/block/positioned-block-auto-width-movement.html
- rendering/style/RenderStyle.cpp:
(WebCore::positionedObjectMoved):
(WebCore::RenderStyle::diff):
LayoutTests:
Reviewed by Emil A Eklund.
- fast/block/positioned-block-auto-width-movement-expected.html: Added.
- fast/block/positioned-block-auto-width-movement.html: Added.
- 12:08 AM Changeset in webkit [146307] by
-
- 30 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[GTK] Add padding to all public class structs for future expansion without breaking ABI
https://bugs.webkit.org/show_bug.cgi?id=112565
Reviewed by Gustavo Noronha Silva.
Use 4 pointers for most of the classes that are unlikely to grow
and 8 for WebKitWebView and WebKitWebContext.
- UIProcess/API/gtk/WebKitBackForwardList.h:
(_WebKitBackForwardListClass):
- UIProcess/API/gtk/WebKitBackForwardListItem.h:
(_WebKitBackForwardListItemClass):
- UIProcess/API/gtk/WebKitContextMenu.h:
(_WebKitContextMenuClass):
- UIProcess/API/gtk/WebKitContextMenuItem.h:
(_WebKitContextMenuItemClass):
- UIProcess/API/gtk/WebKitCookieManager.h:
(_WebKitCookieManagerClass):
- UIProcess/API/gtk/WebKitDownload.h:
(_WebKitDownloadClass):
- UIProcess/API/gtk/WebKitFaviconDatabase.h:
(_WebKitFaviconDatabaseClass):
- UIProcess/API/gtk/WebKitFileChooserRequest.h:
(_WebKitFileChooserRequestClass):
- UIProcess/API/gtk/WebKitFindController.h:
(_WebKitFindControllerClass):
- UIProcess/API/gtk/WebKitFormSubmissionRequest.h:
(_WebKitFormSubmissionRequestClass):
- UIProcess/API/gtk/WebKitGeolocationPermissionRequest.h:
(_WebKitGeolocationPermissionRequestClass):
- UIProcess/API/gtk/WebKitHitTestResult.h:
(_WebKitHitTestResultClass):
- UIProcess/API/gtk/WebKitNavigationPolicyDecision.h:
(_WebKitNavigationPolicyDecisionClass):
- UIProcess/API/gtk/WebKitPlugin.h:
(_WebKitPluginClass):
- UIProcess/API/gtk/WebKitPolicyDecision.h:
(_WebKitPolicyDecisionClass):
- UIProcess/API/gtk/WebKitPrintOperation.h:
(_WebKitPrintOperationClass):
- UIProcess/API/gtk/WebKitResponsePolicyDecision.h:
(_WebKitResponsePolicyDecisionClass):
- UIProcess/API/gtk/WebKitSecurityManager.h:
(_WebKitSecurityManagerClass):
- UIProcess/API/gtk/WebKitSettings.h:
(_WebKitSettingsClass):
- UIProcess/API/gtk/WebKitURIRequest.h:
(_WebKitURIRequestClass):
- UIProcess/API/gtk/WebKitURIResponse.h:
(_WebKitURIResponseClass):
- UIProcess/API/gtk/WebKitURISchemeRequest.h:
(_WebKitURISchemeRequestClass):
- UIProcess/API/gtk/WebKitWebContext.h:
(_WebKitWebContextClass):
- UIProcess/API/gtk/WebKitWebInspector.h:
(_WebKitWebInspectorClass):
- UIProcess/API/gtk/WebKitWebResource.h:
(_WebKitWebResourceClass):
- UIProcess/API/gtk/WebKitWebView.h:
(_WebKitWebViewClass):
- UIProcess/API/gtk/WebKitWebViewBase.h:
(_WebKitWebViewBaseClass):
- UIProcess/API/gtk/WebKitWebViewGroup.h:
(_WebKitWebViewGroupClass):
- UIProcess/API/gtk/WebKitWindowProperties.h:
(_WebKitWindowPropertiesClass):
Mar 19, 2013:
- 11:37 PM Changeset in webkit [146306] by
-
- 13 edits2 adds in trunk/Source/WebCore
Unreviewed, rolling out r146301.
http://trac.webkit.org/changeset/146301
https://bugs.webkit.org/show_bug.cgi?id=112776
Caused hundreds of tests to hit assertions on Windows debug
bots (Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-19
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::mainResourceLoader):
(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::mainResourceData):
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::handleSubstituteDataLoadNow):
(WebCore::DocumentLoader::continueAfterNavigationPolicy):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::continueAfterContentPolicy):
(WebCore::DocumentLoader::reportMemoryUsage):
(WebCore::DocumentLoader::receivedData):
(WebCore::DocumentLoader::clearMainResourceLoader):
(WebCore::DocumentLoader::setDefersLoading):
(WebCore::DocumentLoader::setMainResourceDataBufferingPolicy):
(WebCore::DocumentLoader::addSubresourceLoader):
(WebCore::DocumentLoader::isLoadingMainResource):
(WebCore):
(WebCore::DocumentLoader::maybeLoadEmpty):
(WebCore::DocumentLoader::startLoadingMainResource):
- loader/DocumentLoader.h:
(WebCore):
(DocumentLoader):
- loader/MainResourceLoader.cpp: Added.
(WebCore):
(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::~MainResourceLoader):
(WebCore::MainResourceLoader::create):
(WebCore::MainResourceLoader::clearResource):
(WebCore::MainResourceLoader::frameLoader):
(WebCore::MainResourceLoader::request):
(WebCore::MainResourceLoader::resourceData):
(WebCore::MainResourceLoader::redirectReceived):
(WebCore::MainResourceLoader::responseReceived):
(WebCore::MainResourceLoader::dataReceived):
(WebCore::MainResourceLoader::notifyFinished):
(WebCore::MainResourceLoader::reportMemoryUsage):
(WebCore::MainResourceLoader::load):
(WebCore::MainResourceLoader::setDefersLoading):
(WebCore::MainResourceLoader::defersLoading):
(WebCore::MainResourceLoader::setDataBufferingPolicy):
(WebCore::MainResourceLoader::loader):
(WebCore::MainResourceLoader::identifier):
- loader/MainResourceLoader.h: Added.
(WebCore):
(MainResourceLoader):
(WebCore::MainResourceLoader::cachedMainResource):
(WebCore::MainResourceLoader::documentLoader):
- loader/mac/DocumentLoaderMac.cpp:
(WebCore::DocumentLoader::schedule):
(WebCore::DocumentLoader::unschedule):
- 11:23 PM Changeset in webkit [146305] by
-
- 12 edits4 adds in trunk
CSP 1.1: Stub out SecurityPolicyViolationEvent interface.
https://bugs.webkit.org/show_bug.cgi?id=112681
Reviewed by Adam Barth.
Source/WebCore:
A first pass at a SecurityPolicyViolationEvent interface is defined in
CSP 1.1's editor's draft[1]. This patch puts the big components into
place so that we can start getting some implementation experience with
the new event interface as it's defined, and feed that back into the
working group.
Here, we're only defining the interface, and creating a listener on the
Document. Events aren't yet being fired when Content Security Policy
violations occur. I'll tackle that in a future patch; adding files is
a big enough annoyance to do it separately.
This patch has only two web-visible impacts:
- Document objects now have an 'onsecuritypolicyviolation' attribute.
- A SecurityPolicyViolationEvent constructor is accessible on the Window object.
Ports that have not enabled the CSP_NEXT flag should experience no change.
[1]: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#securitypolicyviolationevent-events
Test: http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics.html
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Wow! A new file! This is so exciting! I'm going to tell ALL my build
systems about this!
- dom/Document.h:
- dom/Document.idl:
Define an 'onsecuritypolicyviolation' event handler on Document objects.
- dom/EventNames.h:
- dom/EventNames.in:
Define a 'securitypolicyviolation' event type.
- dom/SecurityPolicyViolationEvent.h: Added.
(WebCore::SecurityPolicyViolationEventInit::SecurityPolicyViolationEventInit):
(SecurityPolicyViolationEventInit):
(SecurityPolicyViolationEvent):
(WebCore::SecurityPolicyViolationEvent::create):
(WebCore::SecurityPolicyViolationEvent::documentURI):
(WebCore::SecurityPolicyViolationEvent::referrer):
(WebCore::SecurityPolicyViolationEvent::blockedURI):
(WebCore::SecurityPolicyViolationEvent::violatedDirective):
(WebCore::SecurityPolicyViolationEvent::effectiveDirective):
(WebCore::SecurityPolicyViolationEvent::originalPolicy):
(WebCore::SecurityPolicyViolationEvent::sourceURL):
(WebCore::SecurityPolicyViolationEvent::lineNumber):
(WebCore::SecurityPolicyViolationEvent::interfaceName):
(WebCore::SecurityPolicyViolationEvent::SecurityPolicyViolationEvent):
- dom/SecurityPolicyViolationEvent.idl: Added.
Define the SecurityPolicyViolationEvent's IDL, and then create all the
boilerplate necessary to properly initialize a SecurityPolicyViolationEvent
object with the relevant properties.
- page/DOMWindow.idl:
Add the new SecurityPolicyViolationEvent constructor to the Window object
so it's available on a page.
LayoutTests:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics.html: Added.
Simple test which checks only that events are created correctly,
and that the event handler exists on Document. We'll test the
real functionality once we wire the event up to the handler.
- 10:59 PM Changeset in webkit [146304] by
-
- 11 edits5 moves1 add1 delete in trunk/Tools
[chromium] move WebThemeEngine implementations to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=112751
Reviewed by Adam Barth.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebKit):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::themeEngine):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(WebKit):
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::themeEngine):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
(WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
(WebTestRunner):
(WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
(WebTestRunner::WebTestThemeControlWin::box):
(WebTestRunner::WebTestThemeControlWin::line):
(WebTestRunner::WebTestThemeControlWin::triangle):
(WebTestRunner::WebTestThemeControlWin::roundRect):
(WebTestRunner::WebTestThemeControlWin::oval):
(WebTestRunner::WebTestThemeControlWin::circle):
(WebTestRunner::WebTestThemeControlWin::nestedBoxes):
(WebTestRunner::WebTestThemeControlWin::markState):
(WebTestRunner::WebTestThemeControlWin::draw):
(WebTestRunner::WebTestThemeControlWin::drawTextField):
(WebTestRunner::WebTestThemeControlWin::drawProgressBar):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
(WebTestRunner):
(WebTestThemeControlWin):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
(WebTestRunner):
(WebTestThemeEngineMac):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
(+[FakeActiveWindow alwaysActiveWindow]):
(+[FakeActiveWindow alwaysInactiveWindow]):
(-[FakeActiveWindow initWithActiveControls:]):
(-[FakeActiveWindow _hasActiveControls]):
(WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
(WebTestRunner):
(WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
(WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
(WebTestRunner::WebTestThemeEngineWin::paintButton):
(WebTestRunner):
(WebTestRunner::WebTestThemeEngineWin::paintMenuList):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
(WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
(WebTestRunner::WebTestThemeEngineWin::paintTextField):
(WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
(WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
(WebTestRunner::WebTestThemeEngineWin::getSize):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
(WebTestRunner):
(WebTestThemeEngineWin):
(WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
- DumpRenderTree/chromium/TestShell.h:
(WebKit):
- DumpRenderTree/chromium/TestShellMac.mm:
(platformInit):
- DumpRenderTree/chromium/TestShellWin.cpp:
(platformInit):
- DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
- 10:13 PM Changeset in webkit [146303] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Timeline] Tune status bar UI for limited-width window.
https://bugs.webkit.org/show_bug.cgi?id=112702
Reviewed by Pavel Feldman.
Reduce filter titles when there is not enough space.
- inspector/front-end/TimelinePanel.js: Add classnames to elements.
- inspector/front-end/timelinePanel.css: Specify "flex" behaviour.
- 9:31 PM Changeset in webkit [146302] by
-
- 3 edits in trunk/LayoutTests
Qt and GTK+ rebaselines after r146272.
- css3/flexbox/flexbox-baseline-expected.txt:
- platform/qt/css3/flexbox/flexbox-baseline-expected.txt:
- 9:21 PM Changeset in webkit [146301] by
-
- 13 edits2 deletes in trunk/Source/WebCore
Merge MainResourceLoader into DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=104969
Reviewed by Adam Barth.
No new tests, refactor only.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::mainResourceLoader):
(WebCore::DocumentLoader::~DocumentLoader): Move main resource clearing from
~MainResourceLoader.
(WebCore::DocumentLoader::mainResourceData):
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::notifyFinished): Moved from MainResourceLoader::notifyFinished.
(WebCore):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::handleSubstituteDataLoadNow):
(WebCore::DocumentLoader::redirectReceived):
(WebCore::DocumentLoader::continueAfterNavigationPolicy):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::continueAfterContentPolicy):
(WebCore::DocumentLoader::reportMemoryUsage):
(WebCore::DocumentLoader::dataReceived):
(WebCore::DocumentLoader::clearMainResourceLoader):
(WebCore::DocumentLoader::setDefersLoading):
(WebCore::DocumentLoader::setMainResourceDataBufferingPolicy):
(WebCore::DocumentLoader::addSubresourceLoader):
(WebCore::DocumentLoader::maybeLoadEmpty):
(WebCore::DocumentLoader::startLoadingMainResource): Don't keep separate checks
for normal and empty loads, just use a single boolean.
- loader/DocumentLoader.h:
(WebCore::DocumentLoader::isLoadingMainResource):
- loader/MainResourceLoader.cpp: Removed.
- loader/MainResourceLoader.h: Removed.
- loader/mac/DocumentLoaderMac.cpp:
(WebCore::DocumentLoader::schedule):
(WebCore::DocumentLoader::unschedule):
- 9:16 PM Changeset in webkit [146300] by
-
- 9 edits in trunk
Move testRunner.setTouchDragDropEnabled to internals.settings
https://bugs.webkit.org/show_bug.cgi?id=112739
Reviewed by Adam Barth.
Tools:
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner): Remove unnecessary code.
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
(WebTestRunner::WebPreferences::applyTo): Always set to false.
LayoutTests:
Update tests to use internals.settings. This testRunner method was only exposed on
Chromium, but now that Settings.in generates internals.settings setters, we can
use that instead.
- fast/events/touch/gesture/long-press-on-draggable-element-in-iframe-triggers-drag.html:
- fast/events/touch/gesture/long-press-on-draggable-element-in-nested-iframes-triggers-drag.html:
- fast/events/touch/gesture/long-press-on-draggable-element-triggers-drag.html:
- touchadjustment/touch-links-longpress.html:
- 9:08 PM Changeset in webkit [146299] by
-
- 14 edits in trunk
[Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
https://bugs.webkit.org/show_bug.cgi?id=112754
Reviewed by Darin Fisher.
Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
now that it's always defined.
Source/WebKit/chromium:
- public/WebCommonWorkerClient.h:
(WebCommonWorkerClient):
- public/WebFrame.h:
(WebFrame):
- public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::openFileSystem):
(WebKit::WebFrameClient::deleteFileSystem):
- src/LocalFileSystemChromium.cpp:
(WebCore):
(WebCore::openFileSystemHelper):
(WebCore::LocalFileSystem::deleteFileSystem):
- src/WebFrameImpl.cpp:
- src/WebFrameImpl.h:
(WebFrameImpl):
- src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::openFileSystem):
- src/WebWorkerClientImpl.h:
- src/WorkerFileSystemCallbacksBridge.cpp:
- src/WorkerFileSystemCallbacksBridge.h:
(WorkerFileSystemCallbacksBridge):
Tools:
- DumpRenderTree/chromium/WebViewHost.cpp:
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 9:00 PM Changeset in webkit [146298] by
-
- 3 edits in trunk/LayoutTests
Fix expected results added in r146224.
- fast/events/touch/gesture/gesture-tap-hover-clear-expected.txt:
- fast/events/touch/gesture/gesture-tap-on-hover-element-expected.txt:
- 8:32 PM Changeset in webkit [146297] by
-
- 2 edits in trunk/LayoutTests
Mac rebaseline after r146272.
- platform/mac/css3/flexbox/flexbox-baseline-expected.txt:
- 7:51 PM Changeset in webkit [146296] by
-
- 11 edits in trunk/LayoutTests
Rebaselines after r146272.
- platform/chromium-mac-lion/css3/flexbox/flexbox-baseline-expected.png:
- platform/chromium-mac-snowleopard/css3/flexbox/flexbox-baseline-expected.png:
- platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.png:
- platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.txt:
- platform/chromium-win/css3/flexbox/flexbox-baseline-expected.png:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- 7:38 PM Changeset in webkit [146295] by
-
- 3 edits in trunk/Source/WebCore
Cache a pointer to V8DOMActivityLogger in PerContextData.
https://bugs.webkit.org/show_bug.cgi?id=112719
Patch by Ankur Taly <ataly@google.com> on 2013-03-19
Reviewed by Kentaro Hara.
Adds a data member (and getter, setter methods) to V8PerContextData
that holds a pointer to a V8DOMActivityLogger. This member is set while
initializing the context for a V8DOMWindowShell. Ownership of the pointer
is still retained by the HashMap in DOMWrapperWorld.
As a result of this patch, subsequent patches that will implement logging
for DOM API access (See bug 107207) will be able to obtain a reference to
the logger directly from PerContextData. This will benefit performance as it
will be faster than looking up the logger in the DOMActivityLoggerMap in
DOMWrapperWorld.
There are no new tests as there is no change in behavior.
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initializeIfNeeded):
- bindings/v8/V8PerContextData.h:
(WebCore::V8PerContextData::activityLogger):
(V8PerContextData):
(WebCore::V8PerContextData::setActivityLogger):
- 7:14 PM Changeset in webkit [146294] by
-
- 2 edits in trunk/LayoutTests
Windows rebaseline after r146284.
- platform/win/fast/dom/icon-url-property-expected.txt:
- 7:12 PM Changeset in webkit [146293] by
-
- 11 edits5 moves1 add1 delete in trunk/Tools
Unreviewed, rolling out r146290.
http://trac.webkit.org/changeset/146290
https://bugs.webkit.org/show_bug.cgi?id=112751
Broke Chromium Mac build.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebKit):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
- DumpRenderTree/chromium/TestShell.h:
(WebKit):
- DumpRenderTree/chromium/TestShellMac.mm:
(platformInit):
- DumpRenderTree/chromium/TestShellWin.cpp:
(platformInit):
- DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
(WebThemeControlDRTWin::WebThemeControlDRTWin):
(WebThemeControlDRTWin::~WebThemeControlDRTWin):
(WebThemeControlDRTWin::box):
(WebThemeControlDRTWin::line):
(WebThemeControlDRTWin::triangle):
(WebThemeControlDRTWin::roundRect):
(WebThemeControlDRTWin::oval):
(WebThemeControlDRTWin::circle):
(WebThemeControlDRTWin::nestedBoxes):
(WebThemeControlDRTWin::markState):
(WebThemeControlDRTWin::draw):
(WebThemeControlDRTWin::drawTextField):
(WebThemeControlDRTWin::drawProgressBar):
- DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
(WebThemeControlDRTWin):
- DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
(WebThemeEngineDRTMac):
- DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
(+[FakeActiveWindow alwaysActiveWindow]):
(+[FakeActiveWindow alwaysInactiveWindow]):
(-[FakeActiveWindow initWithActiveControls:]):
(-[FakeActiveWindow _hasActiveControls]):
(WebThemeEngineDRTMac::paintScrollbarThumb):
(stateToHIEnableState):
(WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
(WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
- DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
(webRectToSkIRect):
(drawControl):
(drawTextField):
(drawProgressBar):
(WebThemeEngineDRTWin::paintButton):
(WebThemeEngineDRTWin::paintMenuList):
(WebThemeEngineDRTWin::paintScrollbarArrow):
(WebThemeEngineDRTWin::paintScrollbarThumb):
(WebThemeEngineDRTWin::paintScrollbarTrack):
(WebThemeEngineDRTWin::paintSpinButton):
(WebThemeEngineDRTWin::paintTextField):
(WebThemeEngineDRTWin::paintTrackbar):
(WebThemeEngineDRTWin::paintProgressBar):
(WebThemeEngineDRTWin::getSize):
- DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
(WebThemeEngineDRTWin):
(WebThemeEngineDRTWin::WebThemeEngineDRTWin):
- 7:11 PM Changeset in webkit [146292] by
-
- 3 edits in trunk/Source/WebCore
do not use string reference for enum support in CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=112760
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-19
Reviewed by Kentaro Hara.
Do use string references in generated JS bindings for enum values.
Test: bindings/scripts/test/TestObj.idl
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateParametersCheck):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjEnumAttr):
(WebCore::jsTestObjPrototypeFunctionMethodWithEnumArg):
- 7:08 PM Changeset in webkit [146291] by
-
- 8 edits1 add in trunk
[EFL] canvas-fallback-content.html is failing
https://bugs.webkit.org/show_bug.cgi?id=111998
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-19
Reviewed by Chris Fleizach.
Tools:
Adds support for getting platform name.
- DumpRenderTree/TestRunner.cpp:
(TestRunner::staticValues):
- DumpRenderTree/TestRunner.h:
(TestRunner):
- DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::platformName):
LayoutTests:
Fixed failing test. The reason of failure is different accessibility role for combobox element.
- accessibility/canvas-fallback-content.html: Use platform specific role.
- platform/efl-wk1/TestExpectations: Unskipped.
- platform/efl-wk2/TestExpectations: Unskipped.
- platform/efl/accessibility/canvas-fallback-content-expected.txt: Added.
- 6:58 PM Changeset in webkit [146290] by
-
- 11 edits5 moves1 add1 delete in trunk/Tools
[chromium] move WebThemeEngine implementations to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=112751
Reviewed by Adam Barth.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebKit):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::themeEngine):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(WebKit):
(TestInterfaces):
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::themeEngine):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
(WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
(WebTestRunner):
(WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
(WebTestRunner::WebTestThemeControlWin::box):
(WebTestRunner::WebTestThemeControlWin::line):
(WebTestRunner::WebTestThemeControlWin::triangle):
(WebTestRunner::WebTestThemeControlWin::roundRect):
(WebTestRunner::WebTestThemeControlWin::oval):
(WebTestRunner::WebTestThemeControlWin::circle):
(WebTestRunner::WebTestThemeControlWin::nestedBoxes):
(WebTestRunner::WebTestThemeControlWin::markState):
(WebTestRunner::WebTestThemeControlWin::draw):
(WebTestRunner::WebTestThemeControlWin::drawTextField):
(WebTestRunner::WebTestThemeControlWin::drawProgressBar):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
(WebTestRunner):
(WebTestThemeControlWin):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
(WebTestRunner):
(WebTestThemeEngineMac):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
(+[FakeActiveWindow alwaysActiveWindow]):
(+[FakeActiveWindow alwaysInactiveWindow]):
(-[FakeActiveWindow initWithActiveControls:]):
(-[FakeActiveWindow _hasActiveControls]):
(WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
(WebTestRunner):
(WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
(WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
(WebTestRunner::WebTestThemeEngineWin::paintButton):
(WebTestRunner):
(WebTestRunner::WebTestThemeEngineWin::paintMenuList):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
(WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
(WebTestRunner::WebTestThemeEngineWin::paintTextField):
(WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
(WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
(WebTestRunner::WebTestThemeEngineWin::getSize):
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
(WebTestRunner):
(WebTestThemeEngineWin):
(WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
- DumpRenderTree/chromium/TestShell.h:
(WebKit):
- DumpRenderTree/chromium/TestShellMac.mm:
(platformInit):
- DumpRenderTree/chromium/TestShellWin.cpp:
(platformInit):
- DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
- 6:56 PM Changeset in webkit [146289] by
-
- 4 edits in trunk/LayoutTests
Unreviewed rebaselining after r146279.
- platform/chromium-linux/fast/replaced/border-radius-clip-content-edge-expected.png:
- platform/chromium-mac/fast/replaced/border-radius-clip-content-edge-expected.png:
- platform/chromium-win/fast/replaced/border-radius-clip-content-edge-expected.png:
- 6:47 PM Changeset in webkit [146288] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark fast/canvas/canvas-toDataURL-webp.html as failing
https://bugs.webkit.org/show_bug.cgi?id=93310
Unreviewed test expectations update.
libwebp will be updated to 0.3.0 in chrome changing the encoder
output after which this test will need to be rebaselined.
Patch by James Zern <jzern@chromium.org> on 2013-03-19
- platform/chromium/TestExpectations:
- 6:43 PM Changeset in webkit [146287] by
-
- 1 edit38 deletes in trunk/LayoutTests
Remove the test results and expectations for win-wk2
https://bugs.webkit.org/show_bug.cgi?id=112510
Reviewed by Tim Horton.
- platform/win-wk2/TestExpectations: Removed.
- platform/win-wk2/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: Removed.
- platform/win-wk2/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: Removed.
- platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt: Removed.
- platform/win-wk2/editing/deleting/delete-ws-fixup-003-expected.txt: Removed.
- platform/win-wk2/editing/deleting/delete-ws-fixup-004-expected.txt: Removed.
- platform/win-wk2/editing/selection/after-line-break-expected.txt: Removed.
- platform/win-wk2/editing/selection/caret-ltr-right-expected.png: Removed.
- platform/win-wk2/editing/selection/caret-ltr-right-expected.txt: Removed.
- platform/win-wk2/editing/selection/caret-rtl-2-left-expected.png: Removed.
- platform/win-wk2/editing/selection/caret-rtl-2-left-expected.txt: Removed.
- platform/win-wk2/editing/selection/drag-text-delay-expected.txt: Removed.
- platform/win-wk2/fast/css/pseudo-any-expected.txt: Removed.
- platform/win-wk2/fast/forms/textfield-overflow-expected.txt: Removed.
- platform/win-wk2/fast/repaint/japanese-rl-selection-clear-expected.txt: Removed.
- platform/win-wk2/fast/ruby/after-block-doesnt-crash-expected.txt: Removed.
- platform/win-wk2/fast/ruby/after-table-doesnt-crash-expected.txt: Removed.
- platform/win-wk2/fast/ruby/before-block-doesnt-crash-expected.txt: Removed.
- platform/win-wk2/fast/ruby/before-table-doesnt-crash-expected.txt: Removed.
- platform/win-wk2/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Removed.
- platform/win-wk2/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Removed.
- platform/win-wk2/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Removed.
- platform/win-wk2/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed.
- platform/win-wk2/http/tests/inspector-enabled/database-open-expected.txt: Removed.
- platform/win-wk2/platform/win/inverted-colors/non-composited-expected.png: Removed.
- platform/win-wk2/platform/win/inverted-colors/non-composited-expected.txt: Removed.
- platform/win-wk2/platform/win/plugins/windowless-paint-rect-coordinates-expected.txt: Removed.
- platform/win-wk2/plugins/npruntime/embed-property-equality-expected.txt: Removed.
- platform/win-wk2/plugins/resize-from-plugin-expected.txt: Removed.
- platform/win-wk2/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Removed.
- platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Removed.
- platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Removed.
- platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Removed.
- platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Removed.
- platform/win-wk2/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Removed.
- platform/win-wk2/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Removed.
- platform/win-wk2/svg/text/bidi-text-query-expected.png: Removed.
- platform/win-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Removed.
- 6:23 PM Changeset in webkit [146286] by
-
- 2 edits in trunk/LayoutTests
Add failing test expectations on Windows per bugs 112764 and 112766.
- platform/win/TestExpectations:
- 6:10 PM Changeset in webkit [146285] by
-
- 2 edits in trunk/Source/WebCore
Make RLC::haveNonMainLayersWithTiledBacking() public and fix the name
https://bugs.webkit.org/show_bug.cgi?id=112763
Reviewed by Tim Horton.
Downstream code needs to call hasNonMainLayersWithTiledBacking().
- rendering/RenderLayerCompositor.h:
(WebCore::RenderLayerCompositor::hasNonMainLayersWithTiledBacking):
(RenderLayerCompositor):
- 6:09 PM Changeset in webkit [146284] by
-
- 5 edits in trunk
FrameLoader::didChangeIcons isn't called when the favicon is changed.
https://bugs.webkit.org/show_bug.cgi?id=112080
Reviewed by Dmitry Titov.
Source/WebCore:
Test: fast/dom/icon-url-property.html
- dom/Document.cpp:
(WebCore::Document::addIconURL): Made the callback for didChangeIcons
happen whenever there are favicon changes instead of filtering it
and have to be in sync about what hosts care about. As far as I could
tell no hosts rely on this callback except for Chromium, so in general
doing less work here may potentially help a small amount for other
ports.
LayoutTests:
- fast/dom/icon-url-property-expected.txt:
- fast/dom/icon-url-property.html: Add some more calls
to trigger didChangeIcons callbacks.
- 5:57 PM Changeset in webkit [146283] by
-
- 5 edits2 deletes in trunk
Don't throw on infinity or NaN index in HTMLOptionsCollection.add()
https://bugs.webkit.org/show_bug.cgi?id=112612
Patch by Michael Pruett <michael@68k.org> on 2013-03-19
Reviewed by Kentaro Hara.
Source/WebCore:
HTMLOptionsCollection.add() should not throw a type error when
its optional index argument is infinity or NaN. Such values
should instead be converted to 0 with no error.
Tests: fast/dom/non-numeric-values-numeric-parameters.html
fast/js/select-options-add.html
- bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::add):
LayoutTests:
- fast/dom/non-numeric-values-numeric-parameters-expected.txt:
- fast/js/select-options-add-expected.txt:
- platform/chromium/fast/dom/non-numeric-values-numeric-parameters-expected.txt: Removed.
- platform/chromium/fast/js/select-options-add-expected.txt: Removed.
- 5:27 PM Changeset in webkit [146282] by
-
- 3 edits2 adds in trunk
Security: Heap-use-after-free in WebCore::AXObjectCache::getOrCreate
https://bugs.webkit.org/show_bug.cgi?id=112044
Reviewed by Chris Fleizach.
Source/WebCore:
Always call recalcSectionsIfNeeded before accessing
table sections.
Test: accessibility/table-remove-cell-crash.html
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::addChildren):
LayoutTests:
Adds test showing a crash / assertion failure if a cell is
deleted from a table and the table's AX object is accessed.
- accessibility/table-remove-cell-crash-expected.txt: Added.
- accessibility/table-remove-cell-crash.html: Added.
- 5:21 PM Changeset in webkit [146281] by
-
- 3 edits in trunk/Source/WebCore
[v8] add IDL 'enum' in DOM methods
https://bugs.webkit.org/show_bug.cgi?id=112644
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-19
Reviewed by Kentaro Hara.
This adds V8 support for enumerations in method parameters.
Test: bindings/scripts/test/TestObj.idl
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::methodWithEnumArgMethod):
- 5:19 PM Changeset in webkit [146280] by
-
- 23 edits9 deletes in trunk/Source
Unreviewed, rolling out r146277.
http://trac.webkit.org/changeset/146277
https://bugs.webkit.org/show_bug.cgi?id=111695
Broke Chromium Android build
Source/Platform:
- Platform.gypi:
- chromium/public/Platform.h:
(WebKit):
- chromium/public/WebSpeechSynthesisUtterance.h: Removed.
- chromium/public/WebSpeechSynthesisVoice.h: Removed.
- chromium/public/WebSpeechSynthesizer.h: Removed.
- chromium/public/WebSpeechSynthesizerClient.h: Removed.
Source/WebCore:
- Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::boundaryEventOccurred):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didPauseSpeaking):
(WebCore::SpeechSynthesis::didResumeSpeaking):
(WebCore::SpeechSynthesis::didFinishSpeaking):
(WebCore::SpeechSynthesis::speakingErrorOccurred):
(WebCore):
- Modules/speech/SpeechSynthesis.h:
(SpeechSynthesis):
- Modules/speech/SpeechSynthesisUtterance.cpp:
(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::setVoice):
- Modules/speech/SpeechSynthesisUtterance.h:
(WebCore::SpeechSynthesisUtterance::text):
(WebCore::SpeechSynthesisUtterance::setText):
(WebCore::SpeechSynthesisUtterance::lang):
(WebCore::SpeechSynthesisUtterance::setLang):
(WebCore::SpeechSynthesisUtterance::volume):
(WebCore::SpeechSynthesisUtterance::setVolume):
(WebCore::SpeechSynthesisUtterance::rate):
(WebCore::SpeechSynthesisUtterance::setRate):
(WebCore::SpeechSynthesisUtterance::pitch):
(WebCore::SpeechSynthesisUtterance::setPitch):
(WebCore::SpeechSynthesisUtterance::startTime):
(WebCore::SpeechSynthesisUtterance::setStartTime):
(WebCore::SpeechSynthesisUtterance::platformUtterance):
(SpeechSynthesisUtterance):
- Modules/speech/SpeechSynthesisVoice.h:
- WebCore.exp.in:
- WebCore.gypi:
- platform/PlatformSpeechSynthesis.h:
(PlatformSpeechSynthesis):
- platform/PlatformSpeechSynthesisUtterance.cpp:
- platform/PlatformSpeechSynthesisUtterance.h:
(PlatformSpeechSynthesisUtterance):
- platform/PlatformSpeechSynthesisVoice.cpp:
(WebCore::PlatformSpeechSynthesisVoice::create):
- platform/PlatformSpeechSynthesisVoice.h:
(PlatformSpeechSynthesisVoice):
- platform/PlatformSpeechSynthesizer.cpp:
(WebCore::PlatformSpeechSynthesizer::create):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore):
- platform/PlatformSpeechSynthesizer.h:
(PlatformSpeechSynthesizerClient):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(PlatformSpeechSynthesizer):
- platform/chromium/PlatformSpeechSynthesizerChromium.cpp: Removed.
- platform/chromium/support/WebSpeechSynthesisUtterance.cpp: Removed.
- platform/chromium/support/WebSpeechSynthesisVoice.cpp: Removed.
- platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp: Removed.
- platform/chromium/support/WebSpeechSynthesizerClientImpl.h: Removed.
- platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore::PlatformSpeechSynthesizer::speak):
- platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::create):
(WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
(WebCore::PlatformSpeechSynthesizerMock::speak):
- platform/mock/PlatformSpeechSynthesizerMock.h:
(PlatformSpeechSynthesizerMock):
Source/WebKit/chromium:
- features.gypi:
- 5:17 PM Changeset in webkit [146279] by
-
- 11 edits2 adds in trunk
Don't compute background obscuration on every repaint
https://bugs.webkit.org/show_bug.cgi?id=112457
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/backgrounds/obscured-background-child-style-change.html
It is generally enough to compute background obscuration status once per layout rather than doing it on every repaint.
Since there are fewer layouts than repaints this will allow more expensive checks in the future.
With this patch adds caching and invalidation of the obscuration status.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layout):
Invalidate the obscuration status on layout.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
Invalidate the parent obscuration status if there is repaint-only style change (often background related).
Tested by the new fast/css/obscured-background-child-style-change.html.
(WebCore::RenderBox::layout):
(WebCore::RenderBox::computeBackgroundIsKnownToBeObscured):
- rendering/RenderBox.h:
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged):
(WebCore::RenderImage::notifyFinished):
(WebCore::RenderImage::boxShadowShouldBeAppliedToBackground):
(WebCore::RenderImage::computeBackgroundIsKnownToBeObscured):
Use CachedImage::currentFrameKnownToBeOpaque which ensures that the frame is decoded and we get the real status.
Tested by an additional case in fast/css/obscured-background-child-style-change.html.
- rendering/RenderImage.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange):
- rendering/RenderObject.h:
(WebCore::RenderObject::hasBoxDecorations):
(WebCore::RenderObject::computeBackgroundIsKnownToBeObscured):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(RenderObjectBitfields):
(WebCore::RenderObject::RenderObjectBitfields::boxDecorationState):
(WebCore::RenderObject::RenderObjectBitfields::setBoxDecorationState):
Combine box decoration bit and the obscuration status so we only need one extra bit.
(WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
(WebCore::RenderObject::setHasBoxDecorations):
(WebCore::RenderObject::invalidateBackgroundObscurationStatus):
(WebCore::RenderObject::backgroundIsKnownToBeObscured):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::layout):
LayoutTests:
- fast/backgrounds/obscured-background-child-style-change-expected.html: Added.
- fast/backgrounds/obscured-background-child-style-change.html: Added.
- fast/repaint/obscured-background-no-repaint.html:
- 4:46 PM Changeset in webkit [146278] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Selection overlay is sometimes in wrong position.
https://bugs.webkit.org/show_bug.cgi?id=112748
Patch by Andrew Lo <anlo@rim.com> on 2013-03-19
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.
Internal PR 305384.
Translate by parent's offset when drawing selection overlay.
- WebKitSupport/SelectionOverlay.cpp:
(BlackBerry::WebKit::SelectionOverlay::paintContents):
- 4:26 PM Changeset in webkit [146277] by
-
- 22 edits9 adds in trunk/Source
Implement Web Speech Synthesis for Chromium
https://bugs.webkit.org/show_bug.cgi?id=111695
Reviewed by Adam Barth.
Source/Platform:
Exposes a platform API that the embedder can implement to
provide speech synthesis for the Chromium port.
- Platform.gypi:
- chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::speechSynthesizer):
- chromium/public/WebSpeechSynthesisUtterance.h: Added.
(WebKit):
(WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::~WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::operator=):
(WebKit::WebSpeechSynthesisUtterance::isNull):
- chromium/public/WebSpeechSynthesisVoice.h: Added.
(WebCore):
(WebKit):
(WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::~WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::operator=):
- chromium/public/WebSpeechSynthesizer.h: Added.
(WebKit):
(WebSpeechSynthesizer):
(WebKit::WebSpeechSynthesizer::~WebSpeechSynthesizer):
- chromium/public/WebSpeechSynthesizerClient.h: Added.
(WebKit):
(WebSpeechSynthesizerClient):
(WebKit::WebSpeechSynthesizerClient::~WebSpeechSynthesizerClient):
Source/WebCore:
Straightforward implementation of speech synthesis
for Chromium by exposing interfaces for the platform
to implement.
- Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::boundaryEventOccurred):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didPauseSpeaking):
(WebCore::SpeechSynthesis::didResumeSpeaking):
(WebCore::SpeechSynthesis::didFinishSpeaking):
(WebCore::SpeechSynthesis::speakingErrorOccurred):
(WebCore):
- Modules/speech/SpeechSynthesis.h:
(SpeechSynthesis):
- Modules/speech/SpeechSynthesisUtterance.cpp:
(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore):
(WebCore::SpeechSynthesisUtterance::~SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::setVoice):
- Modules/speech/SpeechSynthesisUtterance.h:
(SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::text):
(WebCore::SpeechSynthesisUtterance::setText):
(WebCore::SpeechSynthesisUtterance::lang):
(WebCore::SpeechSynthesisUtterance::setLang):
(WebCore::SpeechSynthesisUtterance::volume):
(WebCore::SpeechSynthesisUtterance::setVolume):
(WebCore::SpeechSynthesisUtterance::rate):
(WebCore::SpeechSynthesisUtterance::setRate):
(WebCore::SpeechSynthesisUtterance::pitch):
(WebCore::SpeechSynthesisUtterance::setPitch):
(WebCore::SpeechSynthesisUtterance::startTime):
(WebCore::SpeechSynthesisUtterance::setStartTime):
(WebCore::SpeechSynthesisUtterance::platformUtterance):
- Modules/speech/SpeechSynthesisVoice.h:
(WebCore::SpeechSynthesisVoice::~SpeechSynthesisVoice):
- WebCore.exp.in:
- WebCore.gypi:
- platform/PlatformSpeechSynthesis.h:
(PlatformSpeechSynthesis):
- platform/PlatformSpeechSynthesisUtterance.cpp:
(WebCore):
(WebCore::PlatformSpeechSynthesisUtterance::create):
- platform/PlatformSpeechSynthesisUtterance.h:
(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::setClient):
- platform/PlatformSpeechSynthesisVoice.cpp:
(WebCore):
(WebCore::PlatformSpeechSynthesisVoice::create):
(WebCore::PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice):
- platform/PlatformSpeechSynthesisVoice.h:
(PlatformSpeechSynthesisVoice):
(WebCore::PlatformSpeechSynthesisVoice::setVoiceURI):
(WebCore::PlatformSpeechSynthesisVoice::setName):
(WebCore::PlatformSpeechSynthesisVoice::setLang):
(WebCore::PlatformSpeechSynthesisVoice::setLocalService):
(WebCore::PlatformSpeechSynthesisVoice::setIsDefault):
- platform/PlatformSpeechSynthesizer.cpp:
(WebCore::PlatformSpeechSynthesizer::create):
(WebCore::PlatformSpeechSynthesizer::setVoiceList):
(WebCore):
- platform/PlatformSpeechSynthesizer.h:
(WebKit):
(PlatformSpeechSynthesizerClient):
(PlatformSpeechSynthesizer):
- platform/chromium/PlatformSpeechSynthesizerChromium.cpp: Added.
(WebCore):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(WebCore::PlatformSpeechSynthesizer::speak):
(WebCore::PlatformSpeechSynthesizer::pause):
(WebCore::PlatformSpeechSynthesizer::resume):
(WebCore::PlatformSpeechSynthesizer::cancel):
- platform/chromium/support/WebSpeechSynthesisUtterance.cpp: Added.
(WebKit):
(WebKit::WebSpeechSynthesisUtterance::WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::operator=):
(WebKit::WebSpeechSynthesisUtterance::assign):
(WebKit::WebSpeechSynthesisUtterance::reset):
(WebKit::WebSpeechSynthesisUtterance::operator PassRefPtr<PlatformSpeechSynthesisUtterance>):
(WebKit::WebSpeechSynthesisUtterance::operator PlatformSpeechSynthesisUtterance*):
(WebKit::WebSpeechSynthesisUtterance::text):
(WebKit::WebSpeechSynthesisUtterance::lang):
(WebKit::WebSpeechSynthesisUtterance::voice):
(WebKit::WebSpeechSynthesisUtterance::volume):
(WebKit::WebSpeechSynthesisUtterance::rate):
(WebKit::WebSpeechSynthesisUtterance::pitch):
(WebKit::WebSpeechSynthesisUtterance::startTime):
- platform/chromium/support/WebSpeechSynthesisVoice.cpp: Added.
(WebKit):
(WebKit::WebSpeechSynthesisVoice::assign):
(WebKit::WebSpeechSynthesisVoice::reset):
(WebKit::WebSpeechSynthesisVoice::setVoiceURI):
(WebKit::WebSpeechSynthesisVoice::setName):
(WebKit::WebSpeechSynthesisVoice::setLanguage):
(WebKit::WebSpeechSynthesisVoice::setIsLocalService):
(WebKit::WebSpeechSynthesisVoice::setIsDefault):
(WebKit::WebSpeechSynthesisVoice::operator PassRefPtr<WebCore::PlatformSpeechSynthesisVoice>):
- platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp: Added.
(WebCore):
(WebCore::WebSpeechSynthesizerClientImpl::WebSpeechSynthesizerClientImpl):
(WebCore::WebSpeechSynthesizerClientImpl::~WebSpeechSynthesizerClientImpl):
(WebCore::WebSpeechSynthesizerClientImpl::setVoiceList):
(WebCore::WebSpeechSynthesizerClientImpl::didStartSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didFinishSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didPauseSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didResumeSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::speakingErrorOccurred):
(WebCore::WebSpeechSynthesizerClientImpl::wordBoundaryEventOccurred):
(WebCore::WebSpeechSynthesizerClientImpl::sentenceBoundaryEventOccurred):
- platform/chromium/support/WebSpeechSynthesizerClientImpl.h: Added.
(WebCore):
(WebSpeechSynthesizerClientImpl):
- platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::speak):
- platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
(WebCore::PlatformSpeechSynthesizerMock::speak):
- platform/mock/PlatformSpeechSynthesizerMock.h:
(PlatformSpeechSynthesizerMock):
- 4:17 PM Changeset in webkit [146276] by
-
- 2 edits in trunk/Source/WebCore
Another build fix after r146220.
- English.lproj/localizedStrings.js:
- 4:16 PM Changeset in webkit [146275] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r146164): It made all inspector tests timeout on ARM traditional
https://bugs.webkit.org/show_bug.cgi?id=112697
Unreviewed gardening, skip _all_ inspector test to be able catch new regressions.
- platform/qt-arm/TestExpectations:
- 4:12 PM Changeset in webkit [146274] by
-
- 11 edits2 adds in trunk
[CSS Grid Layout] Add parsing for grid-auto-{row|column}
https://bugs.webkit.org/show_bug.cgi?id=112724
Reviewed by Tony Chang.
Source/WebCore:
This change is a first step towards handling grid-auto-{row|column}.
For now, only the parsing, storing and getComputedStyle bits are implemented.
In order to do so without duplicating code, the functions handling <track-size>
(named <track-minmax> in the code based on a previous version of the grammar)
have been tweaked to be called in a standalone fashion. The code was also
updated to match the grammar more closely:
- <track-minmax> is now <track-size>.
- <track-group> was renmoved, folded into <track-list>.
Test: fast/css-grid-layout/grid-auto-columns-rows-get-set.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForGridTrackSize):
Renamed from valueForGridTrackMinMax.
(WebCore::valueForGridTrackList):
Folded valueForGridTrackGroup here.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
Added the parsing for grid-auto-{rows|columns}.
(WebCore::CSSParser::parseGridTrackSize):
Renamed from parseGridTrackMinMax. Changed to return the parsed value (or 0 in case of
error). This enables us to reuse it in parseValue. Note that this function now moves
the parser value list instead of the caller.
(WebCore::CSSParser::parseGridTrackList):
Updated after parseGridTrackSize changes and parseGridTrackGroup removal.
- css/CSSParser.h: Updated the names.
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
Added the 2 new non-inherited properties.
- css/StyleResolver.cpp:
(WebCore::createGridTrackSize):
Renamed from createGridTrackMinMax. Also simplified to ensure code reuse (applyProperty hands
down a CSSValue) and consistency (the state wasn't consistently the last argument).
(WebCore::createGridTrackList):
Folded createGridTrackGroup into this function.
(WebCore::StyleResolver::applyProperty):
Added the code for the new properties.
- rendering/style/RenderStyle.h:
- rendering/style/StyleGridData.cpp:
(WebCore::StyleGridData::StyleGridData):
- rendering/style/StyleGridData.h:
(WebCore::StyleGridData::operator==):
Added the storage and boiler-plate code for the new properties.
LayoutTests:
- fast/css-grid-layout/grid-auto-columns-rows-get-set-expected.txt: Added.
- fast/css-grid-layout/grid-auto-columns-rows-get-set.html: Added.
- 4:07 PM Changeset in webkit [146273] by
-
- 3 edits in trunk/Source/WebCore
Removed a using declaration to avoid name conflicts
https://bugs.webkit.org/show_bug.cgi?id=112752
Reviewed by Ryosuke Niwa.
- html/ClassList.cpp: Put the using declaration here instead.
- html/ClassList.h: Don't put a using declaration in this header because
it can cause name conflicts with SVGNames.
- 3:37 PM Changeset in webkit [146272] by
-
- 13 edits4 adds in trunk
Make intrinsic size keywords on flexboxes work
https://bugs.webkit.org/show_bug.cgi?id=112652
Reviewed by Tony Chang.
Source/WebCore:
Tests: fast/css-intrinsic-dimensions/intrinsic-sized-column-flex-items.html
fast/css-intrinsic-dimensions/intrinsic-sized-flex-items.html
- platform/Length.h:
(WebCore::Length::isSpecifiedOrIntrinsic):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::constrainLogicalWidthInRegionByMinMax):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
Pass in the Length so that RenderFlexibleBox can call this method and avoid
doing a bunch of code duplication.
- rendering/RenderBox.h:
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):
Instead of just calling valueForLength, call computeLogicalWidthInRegionUsing so that
we properly resolve intrinsic Length types. Incidentally, this should also make viewport
percentage units work.
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):
Resolve intrinsic min/max Lengths. Also, instead of calling minPreferredLogicalWidth for the
min-width: auto case, call computeMainAxisExtentForChild to correctly compute the min intrinsic size.
LayoutTests:
- fast/css-intrinsic-dimensions/intrinsic-sized-column-flex-items-expected.txt: Added.
- fast/css-intrinsic-dimensions/intrinsic-sized-column-flex-items.html: Added.
- fast/css-intrinsic-dimensions/intrinsic-sized-flex-items-expected.txt: Added.
- fast/css-intrinsic-dimensions/intrinsic-sized-flex-items.html: Added.
- platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.png:
- platform/chromium-win/css3/flexbox/flexbox-baseline-expected.txt:
This looks like a rounding difference. The new result matches the non-column result
in this same test, so it looks more correct to me.
- 3:30 PM Changeset in webkit [146271] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the Windows build.
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::hasValidAttributeType): Qualify the
namespace to avoid conflicts.
- 3:27 PM Changeset in webkit [146270] by
-
- 2 edits in trunk/Source/WebCore
Windows build fix after r146264.
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::hasValidAttributeType):
- 3:27 PM Changeset in webkit [146269] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Hook up scroll position to proximity detector
https://bugs.webkit.org/show_bug.cgi?id=112743
Patch by Iris Wu <shuwu@blackberry.com> on 2013-03-19
Reviewed by Rob Buis.
PR 243385
Reviewed Internally By Genevieve Mak.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(BlackBerry::WebKit::WebPage::adjustDocumentScrollPosition):
(WebKit):
- Api/WebPage.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- 3:22 PM Changeset in webkit [146268] by
-
- 3 edits in trunk/Source/JavaScriptCore
Crash when loading http://www.jqchart.com/jquery/gauges/RadialGauge/LiveData
https://bugs.webkit.org/show_bug.cgi?id=112694
Reviewed by Filip Pizlo.
We were trying to convert an NewArray to a Phantom, but convertToPhantom doesn't handle
nodes with variable arguments. Added code to insert a Phantom node in front of all the
live children of a var args node. Added ASSERT not var args for convertToPhantom to
catch any other similar cases. Added a new convertToPhantomUnchecked() for converting
var arg nodes.
- dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::run):
- dfg/DFGNode.h:
(Node):
(JSC::DFG::Node::setOpAndDefaultNonExitFlags): Added ASSERT(!(m_flags & NodeHasVarArgs))
(JSC::DFG::Node::setOpAndDefaultNonExitFlagsUnchecked):
(JSC::DFG::Node::convertToPhantomUnchecked):
- 3:16 PM Changeset in webkit [146267] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r146223): chromium asserts/crashes in DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=112745
Reviewed by Kenneth Russell.
Fixes layout tests on chromium debug
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::mainReceivedError): Frame might be detached, get
defersLoading() from mainResourceLoader().
(WebCore::DocumentLoader::responseReceived): RefPtr got dropped, it's really needed.
(WebCore::DocumentLoader::receivedData): Frame might be detached, get
defersLoading() from mainResourceLoader().
(WebCore::DocumentLoader::cancelMainResourceLoad): The ResourceError parameter
can be null if coming from the WebKit layer, we should have a default just in case.
- 3:03 PM Changeset in webkit [146266] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skipping plugin snapshot tests temporarily to work out compositing issues.
- platform/mac-wk2/TestExpectations:
- 2:55 PM Changeset in webkit [146265] by
-
- 16 edits1 add in trunk
[EFL][WK2] Separate WebView further from EwkView
https://bugs.webkit.org/show_bug.cgi?id=111591
Reviewed by Caio Marcelo de Oliveira Filho.
Source/WebKit2:
Main points are:
- WKView API has no dependency on EFL types
- WebView class does not store the Evas_Object
- UIProcess/API/C/efl/WKView.cpp:
(WKViewCreate):
WKView creation does not require any EFL objects to be passed.
- UIProcess/API/C/efl/WKView.h:
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::create):
WKViewRef is passed to EwkView constructor from outside rather than
created inside.
(EwkView::webView):
- UIProcess/API/efl/EwkView.h:
(EwkView):
(EwkView::wkView):
(EwkView::page):
EwkView keeps WKViewRef rather than pointer to WebView class.
- UIProcess/API/efl/ewk_view_private.h: Added.
(EWKViewCreate):
(EWKViewGetWKView):
Added private API to create ewk view evas object and return its WKViewRef.
- UIProcess/API/efl/ewk_view.cpp:
(ewkCreateEvasObject):
(ewk_view_smart_add):
(ewk_view_add):
(ewk_view_add_with_context):
- UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Updated accordingly to the new APIs.
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::WebView):
(WebKit::WebView::create):
(WebKit):
(WebKit::WebView::setEwkView):
(WebKit::WebView::isViewFocused):
(WebKit::WebView::isViewVisible):
- UIProcess/efl/WebView.h:
(WebView):
Implementation of updated WKView API.
Tools:
Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
since we can afford it having EWKViewGetWKView() private API to access WKView.
- TestWebKitAPI/PlatformWebView.h:
- TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/efl/PlatformWebView.cpp:
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::PlatformWebView::page):
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
(TestWebKitAPI::PlatformWebView::simulateMouseMove):
(TestWebKitAPI::PlatformWebView::simulateRightClick):
- WebKitTestRunner/PlatformWebView.h:
- WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR::EventSenderProxy::dispatchEvent):
(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::sendTouchEvent):
(WTR::EventSenderProxy::setTouchModifier):
- WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::~PlatformWebView):
(WTR::PlatformWebView::resizeTo):
(WTR::PlatformWebView::page):
(WTR::PlatformWebView::focus):
(WTR::PlatformWebView::windowSnapshotImage):
- 2:51 PM Changeset in webkit [146264] by
-
- 44 edits in trunk
Refactored script content removal in the fragment parser for clarity and speed
https://bugs.webkit.org/show_bug.cgi?id=112734
Reviewed by Enrica Casucci.
Source/WebCore:
- WebCore.exp.in: Export!
- dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::parseHTML):
(WebCore::DocumentFragment::parseXML):
- dom/DocumentFragment.h:
(DocumentFragment): Updated for rename of FragmentScriptingPermission to
ParserContentPolicy.
- dom/Element.cpp:
(WebCore::isEventHandlerAttribute):
(WebCore::Element::isJavaScriptURLAttribute):
(WebCore::Element::isJavaScriptAttribute): Fixed a FIXME by factoring
out some helper functions that reuse isURLAttribute(). This makes our
attribute removal slightly more precise, as reflected in test changes.
(WebCore::Element::stripJavaScriptAttributes): Factored this function out
of parserSetAttributes to clarify that the parser is responsible for
fully removing scripts before inserting anything into the DOM.
Now that this is a helper function, we can avoid doing any work in the
common case, where script content is allowed. Also, when we do have to
strip attributes, we use "two finger compaction" to avoid copying the
vector, and to avoid O(N) vector removal operations when there is
something to remove.
(WebCore::Element::parserSetAttributes):
- dom/Element.h:
- dom/FragmentScriptingPermission.h:
(WebCore::scriptingContentIsAllowed):
(WebCore::disallowScriptingContent):
(WebCore::pluginContentIsAllowed):
(WebCore::allowPluginContent): Renamed for clarity, and added some helper
functions for reading values out of this enum.
- dom/ScriptableDocumentParser.cpp:
(WebCore::ScriptableDocumentParser::ScriptableDocumentParser): Moved
a settings check into the parser constructor so we're sure that all
clients get the right behavior.
- dom/ScriptableDocumentParser.h:
(WebCore::ScriptableDocumentParser::parserContentPolicy):
(ScriptableDocumentParser):
- editing/markup.cpp:
(WebCore::createFragmentFromMarkup):
(WebCore::createFragmentFromMarkupWithContext):
(WebCore::createFragmentForInnerOuterHTML):
(WebCore::createContextualFragment):
- editing/markup.h: Updated for renames.
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isURLAttribute): Fixed a bug where
isURLAttribute would ignore href attributes in other namespaces, like
xlink:href.
- html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::isURLAttribute): Same bug.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::isURLAttribute): Fixed a logic error where HTMLElement
wouldn't call through to its base class.
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::isURLAttribute): Same isURLAttribute namespace
bug as above.
- html/parser/HTMLConstructionSite.cpp:
(WebCore::setAttributes): Helper function for optionally stripping
disallowed attributes before setting them on an element. This helps all
clients get the right behavior without sprinkling checks everywhere.
(WebCore::HTMLConstructionSite::HTMLConstructionSite):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::insertScriptElement): Don't schedule the
element for insertion into the document if the element is forbidden. This
is slightly clearer than leaving an empty forbidden element in the document.
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
- html/parser/HTMLConstructionSite.h:
(HTMLConstructionSite):
(WebCore::HTMLConstructionSite::parserContentPolicy):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
(WebCore::HTMLDocumentParser::parseDocumentFragment):
- html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
(WebCore::HTMLDocumentParser::create):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
Updated for renames and interface changes above.
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag): Removed isParsingFragment()
checks to make it possible to use ParserContentPolicy in more places.
Removed call to removeChildren() because, if an element is forbidden,
we fully remove the element now. This brings behavior for <script>
elements in line with behavior for plug-in elements. It also brings
behavior of the HTML parser in line with behavior of the XML parser.
- html/parser/HTMLTreeBuilder.h:
(WebCore::HTMLTreeBuilder::create):
(FragmentParsingContext):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElement):
- platform/blackberry/PasteboardBlackBerry.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asFragment):
- platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::documentFragment):
- platform/qt/DragDataQt.cpp:
(WebCore::DragData::asFragment):
- platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::fragmentFromCFHTML):
(WebCore::fragmentFromHTML):
- platform/wx/PasteboardWx.cpp:
(WebCore::Pasteboard::documentFragment): Updated for renames and interface
changes.
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::isURLAttribute): Fixed a bug where SVG anchor
elements didn't identify their URL attributes.
- svg/SVGAElement.h:
(SVGAElement):
- xml/XMLErrors.cpp:
(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock): No need to disallow
scripting attributes here because we're creating the attributes
ourselves and we know they're not scripting attributes.
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::parseDocumentFragment):
- xml/parser/XMLDocumentParser.h:
(WebCore::XMLDocumentParser::create):
(XMLDocumentParser): Updated for renames and interface changes above.
Removed the 8 inline capacity in the attribute vector so we could share
helper functions with the HTML parser, which didn't have it.
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::setAttributes):
(WebCore):
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::handleNamespaceAttributes):
(WebCore::handleElementAttributes):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):
- xml/parser/XMLDocumentParserQt.cpp:
(WebCore::setAttributes):
(WebCore):
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::handleNamespaceAttributes):
(WebCore::handleElementAttributes):
(WebCore::XMLDocumentParser::parseStartElement):
(WebCore::XMLDocumentParser::parseEndElement): Same changes as for the
HTML parser.
LayoutTests:
Updated tests to improve coverage and reflect behavior tweaks to improve
clarity.
- editing/pasteboard/paste-noscript-expected.txt:
- The "href", "source", and "action" attributes are fully removed now, instead of being set to the empty string, because for clarity we fully remove script attributes instead of setting their values to the empty string.
- The "formaction" attribute on the form control is not removed because, even though it seems to contain javascript content, the formaction attribute doesn't map to anything on a form element, and won't ever run as script.
- I added a button with a "formaction" attribute, to verify that it does get stripped, since this is the case where the "formaction" attribute can run as script.
- editing/pasteboard/paste-noscript-svg-expected.txt:
- The "xlink:href" attribute is fully removed now. See above.
- editing/pasteboard/paste-noscript-xhtml-expected.txt:
- editing/pasteboard/paste-noscript.html:
- The "href", "source", and "action" attributes are fully removed now. See above.
- The <script> element is fully removed now. See above.
- The "formaction" attribute on the form control is not removed. See above.
- I added a button with a "formaction" attribute. See above.
- editing/pasteboard/paste-visible-script-expected.txt:
- The <script> elements are fully removed now. See above.
- editing/pasteboard/resources/paste-noscript-content.html:
- The "formaction" attribute on the form control is not removed. See above.
- I added a button with a "formaction" attribute. See above.
- 2:49 PM Changeset in webkit [146263] by
-
- 3 edits3 adds in trunk
Crash in SpeculativeJIT::fillSpeculateIntInternal<false> on http://bellard.org/jslinux
https://bugs.webkit.org/show_bug.cgi?id=112738
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixIntEdge): We shouldn't be killing this node because it could be
referenced by other people.
LayoutTests:
- fast/js/dfg-rshift-by-zero-eliminate-valuetoint32-expected.txt: Added.
- fast/js/dfg-rshift-by-zero-eliminate-valuetoint32.html: Added.
- fast/js/script-tests/dfg-rshift-by-zero-eliminate-valuetoint32.js: Added.
(f):
- 2:45 PM Changeset in webkit [146262] by
-
- 14 edits in trunk/Source/WebCore
Clean up static_casts for SVG renderers
https://bugs.webkit.org/show_bug.cgi?id=111651
Reviewed by Abhishek Arya.
toRenderSVGPath and toRenderSVGFilter are preferred over static_casts because bad casts can
be caught on our testing infrastructure. This patch replaces all static_casts for
RenderSVGPath and RenderSVGFilter with toRenderSVGPath and toRenderSVGFilter, respectively.
This patch also adds FIXME to the remaining toRenderSVG* instances that are missing.
No new tests as this is covered with existing tests.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
This call is currently safe due to the element->hasTagName(SVGNames::clipPathTag) check.
- rendering/svg/RenderSVGPath.h:
(WebCore):
(WebCore::toRenderSVGPath):
- rendering/svg/RenderSVGResourceFilter.h:
(WebCore):
(WebCore::toRenderSVGFilter):
- rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::styleDidChange):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::addResourceForClientInvalidation):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::repaintRectForRendererInLocalCoordinatesExcludingSVGShadow):
(WebCore::SVGRenderSupport::rendererHasSVGShadow):
(WebCore::SVGRenderSupport::setRendererHasSVGShadow):
- rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::~SVGRenderingContext):
This cast was not correct! Thankfully it was not required anyway.
- svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::svgAttributeChanged):
This cast was not correct!
- svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::svgAttributeChanged):
This cast was not correct!
- svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::svgAttributeChanged):
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::pathSegListChanged):
(WebCore::SVGPathElement::getBBox):
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::svgAttributeChanged):
- svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::svgAttributeChanged):
- 2:40 PM Changeset in webkit [146261] by
-
- 2 edits in trunk/Tools
Changes to VS2010 project files should only trigger builds on Windows bots.
https://bugs.webkit.org/show_bug.cgi?id=112731
Reviewed by Timothy Horton.
- BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
(_should_file_trigger_build):
- 2:30 PM Changeset in webkit [146260] by
-
- 2 edits in trunk/Source/WebCore
RenderLayer::scrollTo() should call FrameLoaderClient::didChangeScrollOffset()
https://bugs.webkit.org/show_bug.cgi?id=110673
Reviewed by Simon Fraser.
FrameLoaderClient::didChangeScrollOffset() should be called whenever something is
actually being scrolled.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
- 2:17 PM Changeset in webkit [146259] by
-
- 41 edits in trunk/Source/WebCore
[V8] Add machinery for generating specialized bindings for the main world
https://bugs.webkit.org/show_bug.cgi?id=111417
Patch by Marja Hölttä <marja@chromium.org> on 2013-03-19
Reviewed by Jochen Eisinger.
The new specialized bindings will be faster, because they don't need to
do the "main world, isolated world or a worker" check, but can right
away assume that we're in the main world.
Added an IDL attribute (V8PerWorldBindings) to define which
attribute getters / setters to specialize.
This patch generates main world bindings for getters and setters of Node
and Element. (The possibility to generate bindings for callbacks will be
added later.)
No new tests (updated existing bindings tests).
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetterCallback):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetterCallback):
(GenerateNormalAttrSetter):
(GenerateNamedConstructor):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(GenerateCallbackImplementation):
(GenerateFunctionCallString):
(CreateCustomSignature):
(NativeToJSValue):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):
- bindings/scripts/test/V8/V8Float64Array.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
- bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
- bindings/scripts/test/V8/V8TestException.cpp:
(WebCore):
(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):
- bindings/scripts/test/V8/V8TestException.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):
- bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
- bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
(WebCore::ConfigureV8TestNamedConstructorTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
- bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::ConfigureV8TestNodeTemplate):
(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):
- bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):
(WebCore::V8TestObj::installPerContextProperties):
- bindings/scripts/test/V8/V8TestObj.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
- bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):
- bindings/scripts/test/V8/V8TestTypedefs.h:
(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):
- bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::getWrapperForMainWorld):
(DOMDataStore):
- bindings/v8/V8DOMConfiguration.cpp:
(WebCore::V8DOMConfiguration::batchConfigureAttributes):
(WebCore::V8DOMConfiguration::configureTemplate):
- bindings/v8/V8DOMConfiguration.h:
(BatchedAttribute):
(V8DOMConfiguration):
(WebCore::V8DOMConfiguration::configureAttribute):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::toV8ForMainWorld):
(WebCore):
- bindings/v8/custom/V8EventTargetCustom.cpp:
(WebCore::toV8ForMainWorld):
(WebCore):
- bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8ForMainWorld):
(WebCore):
- bindings/v8/custom/V8MicroDataItemValueCustom.cpp:
(WebCore::toV8ForMainWorld):
(WebCore):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::toV8ForMainWorld):
(WebCore):
- dom/Element.idl:
- dom/Node.idl:
- 2:12 PM Changeset in webkit [146258] by
-
- 2 edits in branches/chromium/1410/Source/WebCore/Modules/webaudio
Merge 143565
BUG=174137
Review URL: https://codereview.chromium.org/12478015
- 2:12 PM Changeset in webkit [146257] by
-
- 3 edits in trunk/Source/WebCore
FeatureObserver: Measure X-Frame-Options usage.
https://bugs.webkit.org/show_bug.cgi?id=112670
Reviewed by Adam Barth.
This patch adds three FeatureObserver entries to gather information
about 'X-Frame-Options' usage in general, and in particular usage
and potential misunderstanding of the 'SAMEORIGIN' value.
Three entries are added:
- XFrameOptions measures the raw number of 'X-Frame-Options' headers.
- XFrameOptionsSameOrigin measures the number of those headers that set the value to 'SAMEORIGIN'.
- XFrameOptionsSameOriginWithBadAncestorChain measures the number of occasions in which the frame passed the "top-only" origin check we're currently performing, but would have failed a more strict check against poisoned ancestor chains (that is, an ancestor chain that looks like 'example.com' -> 'evil.com' -> 'example.com').
Mozilla is considering changing 'SAMEORIGIN's behavior to block the
latter loophole[1], and the UI Safety spec is considering dropping
'top-only' entirely[2]. This data will inform those decisions.
[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=725490
[2]: http://lists.w3.org/Archives/Public/public-webappsec/2013Mar/0007.html
This doesn't change web-visible behavior; it only adds histograms
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
When processing an 'X-Frame-Options' header's value, call out to
FeatureObserver when relevant to increment the correct histogram
entries.
- page/FeatureObserver.h:
Added three entries to the FeatureObserver enum: XFrameOptions,
XFrameOptionsSameOrigin, and XFrameOptionsSameOriginWithBadAncestorChain.
Each is explained above.
- 2:00 PM Changeset in webkit [146256] by
-
- 3 edits in trunk/Tools
Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
- Scripts/webkitpy/tool/steps/runtests_unittest.py:
(RunTestsTest.test_webkit_run_unit_tests):
- 1:59 PM Changeset in webkit [146255] by
-
- 2 edits in trunk/Source/JavaScriptCore
2013-03-19 Oliver Hunt <oliver@apple.com>
RELEASE_ASSERT fires in exception handler lookup
RS=Geoff Garen.
Temporarily switch this RELEASE_ASSERT into a regular ASSERT
as currently this is producing fairly bad crashiness.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::handlerForBytecodeOffset):
- 1:51 PM Changeset in webkit [146254] by
-
- 14 edits2 adds in trunk/Tools
Dashboards: Introduce history namespace and unit tests.
https://bugs.webkit.org/show_bug.cgi?id=112645
Reviewed by Ojan Vafai.
Laying the framework for introducing the new history object and
namespace. This moves only static functions into the history
namespace, and moves corresponding unit tests into seperate
unit test file.
- TestResultServer/static-dashboards/aggregate_results.html:
- TestResultServer/static-dashboards/dashboard_base.js:
(parseCrossDashboardParameters):
(parseDashboardSpecificParameters):
(parseParameters):
- TestResultServer/static-dashboards/flakiness_dashboard.html:
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(.switch.return):
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- TestResultServer/static-dashboards/history.js: Added.
- TestResultServer/static-dashboards/history_unittests.js: Added.
- TestResultServer/static-dashboards/loader.js:
(.):
- TestResultServer/static-dashboards/run-embedded-unittests.html:
- TestResultServer/static-dashboards/run-unittests.html:
- TestResultServer/static-dashboards/timeline_explorer.html:
- TestResultServer/static-dashboards/timeline_explorer.js:
- TestResultServer/static-dashboards/treemap.html:
- TestResultServer/static-dashboards/treemap.js:
(.switch.return):
- TestResultServer/static-dashboards/ui.js:
- 1:45 PM Changeset in webkit [146253] by
-
- 2 edits1 add in trunk/Source/WebCore
GenerateHashValue should be usable outside CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=112736
Reviewed by Benjamin Poulain.
GenerateHashValue is not specific to CodeGeneratorJS.pm. Instead, the
function matches the StringHash used in WTF. This patch moves the
function into a separate Perl module so that it can be used by other
Perl scripts. For example, I plan to use this function to compute the
hash value for HTMLNames at compile time rather than at startup.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHashTable):
- bindings/scripts/Hash.pm: Added.
(leftShift):
(GenerateHashValue):
- 1:35 PM Changeset in webkit [146252] by
-
- 2 edits in trunk/WebKitLibraries
[WinCairo] Unreviewed build fix.
- win/tools/vsprops/FeatureDefinesCairo.vsprops: This file was out
of sync with the main Windows build, and the VS2010 version of the
WinCairo port, preventing consistent builds.
- 1:34 PM Changeset in webkit [146251] by
-
- 2 edits in trunk/Source/Platform
[Chromium] Flip WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
https://bugs.webkit.org/show_bug.cgi?id=112726
Reviewed by Adam Barth.
Now that all embedders respect this ifdef, we can safely define it
to get everything to use the new top-level WebFileSystemType enum.
- chromium/public/WebFileSystemType.h:
- 1:30 PM Changeset in webkit [146250] by
-
- 12 edits6 adds in trunk
Source/WebCore: Allow PlugIn Snapshotting to be tested
https://bugs.webkit.org/show_bug.cgi?id=98696
Reviewed by Tim Horton.
Expose a new setting maximumPlugInSnapshotAttempts that can
be set by testing scripts.
Tests: plugins/snapshotting/restart.html
plugins/snapshotting/simple.html
- page/Settings.in:
Source/WebKit2: Allow PlugIn Snapshotting to be tested
https://bugs.webkit.org/show_bug.cgi?id=98696
Reviewed by Tim Horton.
Use the new maximumPlugInSnapshotAttempts setting rather than a hardcoded
value. At the same time, if this value is 0, then snapshot immediately
(don't wait to get a snapshot and test it).
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::didInitializePlugin): Snapshot immediately if maximum attempts are 0.
(WebKit::PluginView::pluginSnapshotTimerFired): Use setting rather than file local variable.
LayoutTests: Allow PlugIn Snapshotting to be tested
https://bugs.webkit.org/show_bug.cgi?id=98696
<rdar://problem/12456731>
Reviewed by Tim Horton.
Two new simple tests for plugin snapshotting. One that makes
sure the plugin was snapshotted (looks for the RenderSnapshottedPlugin)
and one that restarts a snapshotted plugin by clicking.
Since this feature is currently only enabled in WebKit2, the tests
are skipped everywhere else.
- platform/chromium/TestExpectations: Skip plugins/snapshotting.
- platform/efl/TestExpectations: Ditto.
- platform/gtk/TestExpectations: Ditto.
- platform/mac-wk2/TestExpectations: Ditto.
- platform/mac-wk2/plugins/snapshotting/restart-expected.txt: Added.
- platform/mac-wk2/plugins/snapshotting/simple-expected.txt: Added.
- platform/mac/TestExpectations: Skip plugins/snapshotting.
- platform/qt/TestExpectations: Ditto.
- platform/win/TestExpectations: Ditto.
- plugins/snapshotting/restart.html: Added.
- plugins/snapshotting/simple.html: Added.
- 1:27 PM Changeset in webkit [146249] by
-
- 3 edits in trunk/Tools
svn-apply has trouble applying a patch that adds a Windows newline to EOF
https://bugs.webkit.org/show_bug.cgi?id=112732
Reviewed by Eric Seidel.
Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
of an existing file cannot be applied.
In particular, svn-{apply, unapply} compensate for differences in line endings
by converting the line endings in a diff to match the line endings in the target
file. The diff(1) command precedes the last line of a diff that adds a newline
character to the end of a file with the special character sequence "\n
No newline at end of file\n"
Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
when applying this modified diff. Instead, svn-{apply, unapply} should not modify
the newline characters in this special character sequence to match the line endings
in the target file.
- Scripts/VCSUtils.pm:
(parseDiff):
- Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
Added tests:
- "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
- "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
- "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
- "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
(escapeNewLineCharacters): Added.
(toMacLineEndings): Added.
- 1:23 PM Changeset in webkit [146248] by
-
- 5 edits in trunk/Source
Restarting a snapshotted plugin should restart all plugins from the same domain on the page
https://bugs.webkit.org/show_bug.cgi?id=112725
Reviewed by Tim Horton.
Source/WebCore:
If the user restarts a snapshotted plugin, then typically they will
want to restart all similar plugins on the page, where similarity
is defined by the domain of the content. Or in other words, since clients
will typically add a restarted plugin to the list of autostarting
domain hashes, we should start the other plugins that would autostart
on reload.
When a snapshotted plugin gets the user click telling it to restart, it iterates
over every frame in the document looking for domain hashes similar to its own.
It then manually restarts each of the paused plugins.
- html/HTMLPlugInImageElement.cpp:
(WebCore::addPlugInsFromNodeListMatchingOriginHash): Static helper function
that builds a list of plugins to restart.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): After restarting itself,
the plugin looks for all other similar snapshotted plugins in the page.
(WebCore::HTMLPlugInImageElement::restartSnapshottedPlugIn): Splits out the actual
restart functionality, to make it separate from plugins that were manually
restarted and thus probably want to forward a delayed click event.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): New method restartSnapshottedPlugIn.
Source/WebKit2:
When we add a plugin domain hash to the list of sites that autostart, we
send a message to our owning process. That message might not return before
another plugin queries if it is in the list. So, before we send the message,
add the current hash to the list with a very small timeout. That way the
response will be to either extend the timeout, or not add the hash (in which
case it will expire soon).
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::addPlugInAutoStartOrigin):
- 1:23 PM Changeset in webkit [146247] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG should optimize StringObject.length and StringOrStringObject.length
https://bugs.webkit.org/show_bug.cgi?id=112658
Reviewed by Mark Hahnenberg.
Implemented by injecting a ToString(StringObject:@a) or ToString(StringOrStringObject:@a) prior
to GetArrayLength with ArrayMode(Array::String) if @a is predicted StringObject or
StringOrStringObject.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::createToString):
(FixupPhase):
(JSC::DFG::FixupPhase::attemptToForceStringArrayModeByToStringConversion):
(JSC::DFG::FixupPhase::convertStringAddUse):
- 1:22 PM Changeset in webkit [146246] by
-
- 2 edits in trunk/Source/WebKit/mac
Another Mac build fix attempt after r146239.
- WebCoreSupport/WebFrameNetworkingContext.h:
(WebFrameNetworkingContext):
- 1:16 PM Changeset in webkit [146245] by
-
- 1 copy in tags/Safari-534.59.7
New tag.
- 1:16 PM Changeset in webkit [146244] by
-
- 1 copy in tags/Safari-536.29.10
New tag.
- 1:09 PM Changeset in webkit [146243] by
-
- 4 edits in branches/safari-536.29-branch/Source
Versioning.
- 1:04 PM Changeset in webkit [146242] by
-
- 2 edits in trunk/Source/WebKit/mac
Mac build fix attempt after r146239.
- WebCoreSupport/WebFrameNetworkingContext.h:
- 12:55 PM Changeset in webkit [146241] by
-
- 5 edits in branches/safari-534.59-branch/Source
Versioning.
- 12:55 PM Changeset in webkit [146240] by
-
- 11 edits4 deletes in trunk
[chromium] Remove compositor settings that don't go through WebKit
https://bugs.webkit.org/show_bug.cgi?id=112718
Patch by James Robinson <jamesr@chromium.org> on 2013-03-19
Reviewed by Adam Barth.
Source/WebKit/chromium:
This removes settings that used to propagate through WebLayerTreeView::Settings by way of WebViewImpl but are
now directly set by the embedder.
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
Tools:
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
- DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
(WebTestRunner::WebPreferences::reset):
(WebTestRunner::WebPreferences::applyTo):
- DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
- DumpRenderTree/chromium/TestShell.h:
(TestShell):
LayoutTests:
- platform/chromium/compositing/accelerated-drawing/alpha-expected.png: Removed.
- platform/chromium/compositing/accelerated-drawing/alpha-expected.txt: Removed.
- platform/chromium/compositing/accelerated-drawing/alpha.html: Removed.
- platform/chromium/compositing/accelerated-drawing/svg-filters.html: Removed.
- 12:39 PM Changeset in webkit [146239] by
-
- 5 edits in trunk/Source/WebCore
Merge MainResourceLoader's SubstituteData loading + others into DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=112722
Part of the ongoing effort to merge MainResourceLoader entirely
into DocumentLoader.
Reviewed by Antti Koivisto.
No new tests, refactor only.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::mainReceivedError): Moved from MainResourceLoader::receivedError
and the failure case in MainResourceLoader::notifyFinished.
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::handleSubstituteDataLoadNow): Moved from MainResourceLoader.
(WebCore::DocumentLoader::startDataLoadTimer): Moved from MainResourceLoader.
(WebCore::DocumentLoader::handleSubstituteDataLoadSoon): Moved from MainResourceLoader.
(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::continueAfterNavigationPolicy):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::receivedData):
(WebCore::DocumentLoader::startLoadingMainResource): Most of MainResourceLoader::load
moved here.
(WebCore::DocumentLoader::cancelMainResourceLoad): MainResourceLoader::cancel
moved here.
- loader/DocumentLoader.h:
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::notifyFinished):
(WebCore::MainResourceLoader::reportMemoryUsage):
(WebCore::MainResourceLoader::load):
(WebCore::MainResourceLoader::identifier):
- loader/MainResourceLoader.h:
- 12:36 PM Changeset in webkit [146238] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r146220. Add the missing ]'s.
- English.lproj/localizedStrings.js:
- 12:29 PM Changeset in webkit [146237] by
-
- 7 edits1 add in trunk/Source
GIFImageReader to count frames and decode in one pass
https://bugs.webkit.org/show_bug.cgi?id=111144
Reviewed by Stephen White.
Source/WebCore:
OBJECTIVE
This change has the objective of improving performance reading GIF
files. This implementation can parse the entire GIF file in one pass
and saves information about each frame, such that decoding in a later
pass does not need to parse the file again.
This change fixes the performance problem of decoding GIF files when
they are received very slowly. Existing implementation creates a new
GIFImageReader for counting frames for every time it is notified that
new data has been received, this has O(n2) behavior when data is
received very slowly.
ALGORITHM
This implementation divides the decoding process into two separate
steps: parse and LZW decoding.
In the parse step, the state machine is similar to the existing
implementation. However this algorithm does not perform any decoding
while scanning through the file. Intead it creates a new data structure
for caching all frame information and the corresponding LZW blocks.
If a full decode is requested then LZW decoding is performed. This
implementation looks through all frame information saved and decodes
each frame sequentially until the target frame is reached.
Because of the separation of parse and decode, each frame can be
decoded separately. This paves the way to support seeking in GIF files.
TESTING
Added a new unit test to cover progressively decoding a GIF image.
There are already GIF unit tests for functional testing.
Exhaustive testing was done locally with a corpus of 60k images.
I mixed the corpus with some generated bad data and truncated files.
The results was bit-identical when compared to the previous
implementation.
These was also no crashing when decoding the entire corpus.
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::GIFImageDecoder):
(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::repetitionCount):
(WebCore::GIFImageDecoder::decode):
- platform/image-decoders/gif/GIFImageDecoder.h:
(GIFImageDecoder):
- platform/image-decoders/gif/GIFImageReader.cpp:
(GIFLZWContext::outputRow):
(GIFLZWContext::doLZW):
(GIFFrameContext::decode):
(GIFImageReader::decode):
(GIFImageReader::parse):
(GIFImageReader::addFrameIfNecessary):
(GIFLZWContext::prepareToDecode):
- platform/image-decoders/gif/GIFImageReader.h:
There is a lot of reshuffling in GIFLZWContext and GIFFrameContext.
These changes has the goal of having GIFLZWContext be a pure decoding
state machine. GIFFrameContext is mostly a read-only container for
frame information. With all these changes we can decode each
GIFFrameContext independently.
The ownership pattern is:
GIFImageReader owns GIFFrameContext owns GIFLZWContext.
(GIFLZWContext::GIFLZWContext):
(GIFLZWContext):
(GIFLZWContext::hasRemainingRows):
GIFLZWContext is moved to the top of file.
(GIFLZWBlock):
(GIFLZWBlock::GIFLZWBlock):
New data structure to save block position and size.
(GIFFrameContext):
(GIFFrameContext::GIFFrameContext):
(GIFFrameContext::~GIFFrameContext):
(GIFFrameContext::addLzwBlock):
(GIFFrameContext::isComplete):
(GIFFrameContext::isHeaderDefined):
(GIFFrameContext::isDataSizeDefined):
(GIFFrameContext::setComplete):
(GIFFrameContext::setHeaderDefined):
(GIFFrameContext::setDataSize):
Now owns GIFLZWContext for decoding.
(GIFImageReader::GIFImageReader):
(GIFImageReader::~GIFImageReader):
(GIFImageReader::imagesCount):
(GIFImageReader::frameContext):
(GIFImageReader):
(GIFImageReader::parseFailed):
(GIFImageReader::isFirstFrame):
Owns a list of GIFFrameContxt.
Source/WebKit/chromium:
Added a new GIF unit test for progressive decoding. The test is to verify
that continually re-decoding an image one additional byte at a time produces
the same outputs as repeatedly decoding (with brand new decoders) truncated
versions of the image that are one byte longer each time.
- tests/GIFImageDecoderTest.cpp:
(WebKit::TEST):
- 12:25 PM Changeset in webkit [146236] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed gardening of AppleWin port.
- platform/win/fast/dom/icon-url-property-expected.txt: Added.
- platform/win/fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt: Added.
- 12:19 PM Changeset in webkit [146235] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r189038. Requested by
"Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-19
- DEPS:
- 12:18 PM Changeset in webkit [146234] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r146101.
https://bugs.webkit.org/show_bug.cgi?id=111884
re-enable custom freetype on asan; this needs to be on
now that the bot is running lucid.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 12:14 PM Changeset in webkit [146233] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Don't handle keyboard scrolling shortcuts in webkit
https://bugs.webkit.org/show_bug.cgi?id=112716
Informally Reviewed by Mike Fenton (mifenton@rim.com)
Patch by Chris Hutten-Czapski <chutten@blackberry.com> on 2013-03-19
Reviewed by Rob Buis.
The comment is right, this isn't the correct place to handle keyboard
scrolling shortcuts. That's what we have clients for.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::keyEvent):
- 12:03 PM Changeset in webkit [146232] by
-
- 2 edits in trunk/LayoutTests
[Chromium] IndexedDB: index-duplicate-keypaths test is flaky under content_shell
https://bugs.webkit.org/show_bug.cgi?id=112723
Reviewed by Tony Chang.
Root cause is a race between the "versionchange" transaction's "complete" event
being dispatched to script and the "success" call arriving from the back-end
which updates the metadata. Tracked as https://bugs.webkit.org/show_bug.cgi?id=111642
- storage/indexeddb/resources/index-duplicate-keypaths.js:
(testCollideAutoIncrementSetup): Trigger test from open's onsuccess...
(testCollideAutoIncrement): ... rather than transaction's oncomplete.
- 11:59 AM Changeset in webkit [146231] by
-
- 3 edits in trunk/Source/WebCore
[WinCairo] Unreviewed build correction for WebCore library.
- WebCore.vcxproj/WebCore.vcxproj: Exclude CG-specific frame source
from WinCairo build.
- WebCore.vcxproj/WebCoreGeneratedWinCairo.make: Pass correct
parameter to build-generated-files.sh for WinCairo build.
- 11:50 AM Changeset in webkit [146230] by
-
- 2 edits in trunk/Source/WTF
Fix the WTF gyp build for GTK+.
- WTF.gyp/WTFGTK.gyp: Skip files with CF in the name.
- 11:47 AM Changeset in webkit [146229] by
-
- 2 edits in trunk/Source/Platform
[chromium] Remove deprecated/unused bits of WebLayerTreeView
https://bugs.webkit.org/show_bug.cgi?id=112714
Patch by James Robinson <jamesr@chromium.org> on 2013-03-19
Reviewed by Adam Barth.
- chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
- 11:45 AM Changeset in webkit [146228] by
-
- 5 edits in trunk/Source/WebCore
Implement onRefEncodedData for lazy pixel refs.
This allows printToSkPicture to write the original
encoded data to the stream.
Add a method to ImageFrameGenerator to copy its
data, which is used by onRefEncodedData.
https://bugs.webkit.org/show_bug.cgi?id=110759
Patch by Leon Scroggins <scroggo@chromium.org> on 2013-03-19
Reviewed by Stephen White.
No new tests. New functionality is for testing purposes
(creating SKP files).
- platform/graphics/chromium/ImageFrameGenerator.cpp:
(WebCore::ImageFrameGenerator::data):
(WebCore):
- platform/graphics/chromium/ImageFrameGenerator.h:
(ImageFrameGenerator):
- platform/graphics/chromium/LazyDecodingPixelRef.cpp:
(WebCore::LazyDecodingPixelRef::isClipped):
(WebCore):
(WebCore::LazyDecodingPixelRef::onRefEncodedData):
- platform/graphics/chromium/LazyDecodingPixelRef.h:
(LazyDecodingPixelRef):
- 11:39 AM Changeset in webkit [146227] by
-
- 5 edits2 adds in trunk
Separate SVG image size and container size
https://bugs.webkit.org/show_bug.cgi?id=112651
Reviewed by Stephen Chenney.
Source/WebCore:
Previously, SVG images could retain their cached size between reloads due to a bug where an
old container size would be re-used if the image's new container size was not available yet.
This patch changes SVGImage::size() to return the intrinsic size of the image before a
container size has been set. SVGImageCache::imageSizeForRenderer will now return the
image's intrinsic size instead of a cached value if the container size cannot be looked up.
In javascript, querying [SVGImage].width will now return either the image's intrinsic size
or the size of 'imageForContainer'.
Test: svg/as-image/svg-container-size-after-reload.html
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::containerSize):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::dataChanged):
- svg/graphics/SVGImage.h:
The member variable 'm_intrinsicSize' has been added to track the image's intrinsic
size. This term can be found in: http://www.w3.org/TR/css3-images/#default-sizing
- svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::imageSizeForRenderer):
(WebCore::SVGImageCache::imageForRenderer):
In both of these functions, image has been renamed to imageForContainer here to clarify
that the cached container size is being returned, not the image's intrinsic size.
LayoutTests:
- svg/as-image/svg-container-size-after-reload-expected.txt: Added.
- svg/as-image/svg-container-size-after-reload.html: Added.
- 11:31 AM Changeset in webkit [146226] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] When selecting an object, assign focus to new node instead of clearing previous focused node
https://bugs.webkit.org/show_bug.cgi?id=112707
Patch by Andy Chen <andchen@blackberry.com> on 2013-03-19
Reviewed by Rob Buis.
In SelectionHandler, when selecting a new object, we should set focus
to the anchor node of selection instead of removing it from the old input.
In InputHandler, when focusedNodeChanged is called, if the new node is
not an Element node, we need to set focus to its Element parent node,
instead of removing focus from the old node.
PR 304631
Internally reviewed by Mike Fenton.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::focusedNodeChanged):
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectObject):
- 11:23 AM Changeset in webkit [146225] by
-
- 3 edits in trunk/Source/WebCore
IndexedDB: Use integer plumbing for deleteDatabase onVersionChange calls
https://bugs.webkit.org/show_bug.cgi?id=112715
Reviewed by Tony Chang.
When deleteDatabase on the back-end needs to send the front-end an
onVersionChange notification it does so using the string overload. That's
the only remaining use of that overload and we'd like to delete it. Switch
to using the integer overload, with an already defined special value.
This will unblock http://wkbug.com/112712 to delete the dead code.
No new tests - no functional change.
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::onVersionChange): Map NoIntVersion to null.
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::deleteDatabase): Call integer overload.
- 11:20 AM Changeset in webkit [146224] by
-
- 3 edits6 adds in trunk
Hover effects from a GestureTapDown are dismissed by a GestureTap on the hover element
https://bugs.webkit.org/show_bug.cgi?id=103283
Reviewed by Antonio Gomes.
Source/WebCore:
On a GestureTap event over an element that was made visible as a hover effect, the
GestureTap should be applied to that element and the hover effects should not be dismissed.
A GestureTap or a mouse move to a location outside of the element should still dismiss the
hover effects.
Tests: fast/events/touch/gesture/gesture-tap-hover-clear.html
fast/events/touch/gesture/gesture-tap-on-hover-element.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
LayoutTests:
Two layout tests added. See descriptions inline.
- fast/events/touch/gesture/gesture-tap-hover-clear-expected.txt: Added.
- fast/events/touch/gesture/gesture-tap-hover-clear.html: Added.
Tests that a GestureTap or a mouse move outside of the hovered element
clears its hover effects.
- fast/events/touch/gesture/gesture-tap-on-hover-element-expected.txt: Added.
- fast/events/touch/gesture/gesture-tap-on-hover-element.html: Added.
Tests that a GestureTap on an element which has been made visible as
a hover effect is dispatched to the element and does not dismiss the
hover effect.
- platform/chromium/fast/events/touch/gesture/gesture-tap-hover-clear-expected.txt: Added.
- platform/chromium/fast/events/touch/gesture/gesture-tap-on-hover-element-expected.txt: Added.
- 11:13 AM Changeset in webkit [146223] by
-
- 6 edits2 copies in branches/chromium/1410
Merge 145735 "REGRESSION(r137607): Redirecting a post to a get then reloading triggers resubmit warning"
.: Expose symbols for internals
https://bugs.webkit.org/show_bug.cgi?id=112194
Reviewed by Alexey Proskuryakov.
- Source/autotools/symbols.filter:
Source/WebCore: REGRESSION(r137607): Redirecting a post to a get then reloading triggers resubmit warning
https://bugs.webkit.org/show_bug.cgi?id=112194
Reviewed by Alexey Proskuryakov.
Test: http/tests/navigation/post-redirect-get-reload.php
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest): Matching urls aren't a reliable way of checking whether
we are in a redirect. Check redirectResponse.isNull() instead.
- testing/Internals.cpp:
(WebCore::Internals::forceReload): Expose a means of forcing a reload like one a user generates for testing.
Note that testRunner.queueReload() does this, but is not supported after the initial load completes,
which makes it unsuitable for this case.
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit/win: Expose symbols for internals
https://bugs.webkit.org/show_bug.cgi?id=112194
Reviewed by Alexey Proskuryakov.
- WebKit.vcproj/WebKitExports.def.in:
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=112194.
Reviewed by Alexey Proskuryakov.
- http/tests/navigation/post-redirect-get-reload-expected.txt: Added.
- http/tests/navigation/post-redirect-get-reload.php: Added.
TBR=Nate Chapin
Review URL: https://codereview.chromium.org/12568009
- 10:52 AM Changeset in webkit [146222] by
-
- 4 edits in trunk
[BlackBerry] Enable USE_SYSTEM_MALLOC by default
https://bugs.webkit.org/show_bug.cgi?id=112365
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-19
Reviewed by Benjamin Poulain.
Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
harcoding it in wtf/Platform.h
Source/WTF:
- wtf/Platform.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 10:47 AM Changeset in webkit [146221] by
-
- 3 edits in trunk/LayoutTests
Assertion in LegacyWebArchive::create() in editing tests
https://bugs.webkit.org/show_bug.cgi?id=112642
editing/pasteboard/5780697-1.html is also a flakey assertion.
Move to mac-wk2 beacuse these only seem to happen in WK2.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 10:43 AM Changeset in webkit [146220] by
-
- 17 edits in trunk/Source/WebCore
Web Inspector: Fix menu items capitalization.
https://bugs.webkit.org/show_bug.cgi?id=112553
The context menu items should be correctly capitalized.
Patch by Alexei Filippov <alph@chromium.org> on 2013-03-19
Reviewed by Pavel Feldman.
- English.lproj/localizedStrings.js:
- inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._emptyElementContextMenu):
(WebInspector.XHRBreakpointsSidebarPane.prototype._emptyElementContextMenu):
(WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu):
- inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.Placard.prototype._placardContextMenu):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._handleContextMenuEvent.get var):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent.set get contextMenu):
- inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu):
- inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype._contextMenuInDataTable):
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._contextMenuEventFired.set get var):
(WebInspector.ElementsPanel.prototype.appendApplicableItems):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
- inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype.appendApplicableItems):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._handleContextMenuEvent):
(WebInspector.ProfilesPanel.prototype.appendApplicableItems):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.FileSystemListTreeElement.prototype._handleContextMenuEvent):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeMappingItems):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
(WebInspector.ScriptsPanel.prototype._appendFunctionItems):
- inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPaneTab.prototype._tabContextMenu):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._contextMenu):
- inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype._emptyElementContextMenu):
(WebInspector.WatchExpressionTreeElement.prototype.populateContextMenu):
- 10:31 AM Changeset in webkit [146219] by
-
- 2 edits in trunk/LayoutTests
ASSERTION FAILED: m_scheduledTasksAreSuspended
https://bugs.webkit.org/show_bug.cgi?id=97124
Mark fast/loader/dynamic-iframe-extra-back-forward-item.html as sometimes crashing in debug.
- platform/mac-wk2/TestExpectations:
- 10:29 AM Changeset in webkit [146218] by
-
- 12 edits in trunk
Inspector: IndexedDB clear button and menu item
https://bugs.webkit.org/show_bug.cgi?id=112066
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Adds a button that can clear the contents of an objectStore from
the IDBDataView, and a context menu from the ResourcesPanel that
can do the same.
This also disables the Refresh button from the IDBDataView, so there
is at least some visual feedback that the refresh button is working.
Tests: http/tests/inspector/indexeddb/database-data.html
- inspector/Inspector.json: New API clearObjectStore.
- inspector/InspectorIndexedDBAgent.cpp: Implementation of clearObjectStore
(WebCore):
(ClearObjectStoreListener): Calls the original closure after the objectStore is cleared.
(ClearObjectStore): Initiates the clear operation after the DB opens.
- inspector/front-end/IndexedDBModel.js: Exposes clearObjectStore to the Model API.
(WebInspector.IDBDataView): Add clear button and enable/disable clear and refresh buttons appropriately.
- inspector/front-end/ResourcesPanel.js: Add a menu item and refresh the displayed data after the clear.
- inspector/front-end/inspector.css: Add a style to show the right button for clear.
LayoutTests:
Add extra methods to test clearing the database after populating it.
- 10:26 AM Changeset in webkit [146217] by
-
- 2 edits in trunk/LayoutTests
[Mac] Flaky crash in SliderThumbElement::defaultEventHandler on fast/forms/range/slider-delete-while-dragging-thumb.html
https://bugs.webkit.org/show_bug.cgi?id=108223
- platform/mac/TestExpectations:
- 10:08 AM Changeset in webkit [146216] by
-
- 5 edits in trunk/Source/WebCore
Merge MainResourceLoader::responseReceived into DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=112593
Part of the ongoing effort to merge MainResourceLoader entirely
into DocumentLoader.
Reviewed by Adam Barth.
No new tests, refactor only.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::finishedLoading): The only thing left in
MainResourceLoader related to this function was a RefPtr which indirectly
protected DocumentLoader. Move the RefPtr here and protect DocumentLoader directly.
(WebCore::DocumentLoader::responseReceived): Moved from MainResourceLoader.
(WebCore::DocumentLoader::callContinueAfterContentPolicy): Moved from MainResourceLoader.
(WebCore::DocumentLoader::continueAfterContentPolicy): Moved from MainResourceLoader.
(WebCore::DocumentLoader::interruptedForPolicyChangeError): Moved from MainResourceLoader.
(WebCore::DocumentLoader::stopLoadingForPolicyChange): Moved from MainResourceLoader.
(WebCore::DocumentLoader::receivedData):
(WebCore::DocumentLoader::cancelMainResourceLoad):
- loader/DocumentLoader.h:
(WebCore::DocumentLoader::isLoadingMultipartContent): Store multipart bit here.
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::cancel):
(WebCore::MainResourceLoader::responseReceived):
(WebCore::MainResourceLoader::notifyFinished):
- loader/MainResourceLoader.h:
- 10:06 AM Changeset in webkit [146215] by
-
- 2 edits in trunk/Source/WebCore
Cleanup defaultUnifiedTextCheckerEnabled type
https://bugs.webkit.org/show_bug.cgi?id=112640
Reviewed by Adam Barth.
It's a bool setting. I accidentally declared the default value as a double
in r139202.
No new tests, this is a refactor/code cleanup.
- page/Settings.cpp:
(WebCore): Switch from double to a bool.
- 9:56 AM Changeset in webkit [146214] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Increase DataGrid default font size.
https://bugs.webkit.org/show_bug.cgi?id=112692
Patch by Alexei Filippov <alph@chromium.org> on 2013-03-19
Reviewed by Pavel Feldman.
The default font of 10px is too small. Most instances of DataGrid set
font to 11px.
- inspector/front-end/dataGrid.css:
(.data-grid table):
- 9:49 AM Changeset in webkit [146213] by
-
- 3 edits in trunk/Source/WebCore
Refactor conditions for setCompositingLayersNeedRebuild in RenderLayer::styleChanged
https://bugs.webkit.org/show_bug.cgi?id=112606
Reviewed by Simon Fraser.
To fix bug 109098 [1], we will need to add more conditions for calling
RenderLayerCompositor::setCompositingLayersNeedRebuild in RenderLayer::styleChanged.
Adding more non-trivial conditions will make this block of code even harder to follow.
This patch refactors the current conditions into functions:
needsCompositingLayersRebuiltForClip
needsCompositingLayersRebuiltForOverflow
In bug 109098 [1], I'm planning to add:
needsCompositingLayersRebuiltForFilters
[1]: https://bugs.webkit.org/show_bug.cgi?id=109098
No new tests. Just refactoring.
- rendering/RenderLayer.cpp:
(WebCore):
(WebCore::RenderLayer::needsCompositingLayersRebuiltForClip):
(WebCore::RenderLayer::needsCompositingLayersRebuiltForOverflow):
This is a method and not a file static function because it needs to look at the
RenderLayer's stackingContainer(), which is a private method.
(WebCore::RenderLayer::styleChanged):
- rendering/RenderLayer.h:
(RenderLayer):
- 9:20 AM Changeset in webkit [146212] by
-
- 2 edits in trunk/Source/WebKit/chromium
Web Inspector: Remove flaky part of testRendererProcessNativeMemorySize test.
https://bugs.webkit.org/show_bug.cgi?id=112703
Patch by Alexei Filippov <alph@chromium.org> on 2013-03-19
Reviewed by Yury Semikhatsky.
The memory increase size check happened to be flaky. Remove it.
- src/js/Tests.js:
(.TestSuite.prototype.testRendererProcessNativeMemorySize.step1):
(.TestSuite.prototype.testRendererProcessNativeMemorySize):
- 9:17 AM Changeset in webkit [146211] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening,
- 9:06 AM Changeset in webkit [146210] by
-
- 2 edits in trunk/PerformanceTests
Web Inspector: Fix heap profiler performance tests.
https://bugs.webkit.org/show_bug.cgi?id=112701
Patch by Alexei Filippov <alph@chromium.org> on 2013-03-19
Reviewed by Yury Semikhatsky.
The tests were broken by profile types refactoring.
- inspector/heap-snapshot-performance-test.js:
(test.performanceTest.step0):
(test.performanceTest.step1):
- 9:00 AM Changeset in webkit [146209] by
-
- 4 edits in trunk/Source/WebCore
[Qt] Support kerning in fast path font rendering
https://bugs.webkit.org/show_bug.cgi?id=106013
Reviewed by Jocelyn Turcotte.
To support kerning in the fast font path we need to implement SimpleFontData::applyTransforms.
This patch changes the types used by the fast path GlyphBuffer to match those used by Qt,
and implements SimpleFontData::applyTransforms using QRawFont::advancesForGlyphIndexes.
- platform/graphics/GlyphBuffer.h:
(GlyphBufferAdvance):
(WebCore::GlyphBufferAdvance::GlyphBufferAdvance):
(WebCore::GlyphBufferAdvance::setWidth):
(WebCore::GlyphBufferAdvance::width):
(WebCore::GlyphBufferAdvance::height):
(WebCore::GlyphBuffer::add):
- platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::applyTransforms):
- platform/graphics/WidthIterator.h:
(WebCore::WidthIterator::supportsTypesettingFeatures):
- 8:54 AM Changeset in webkit [146208] by
-
- 26 edits2 adds in trunk/Source
Web Inspector: split Console into two entities, a web-facing bound object and page console.
https://bugs.webkit.org/show_bug.cgi?id=111578
Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-19
Reviewed by Vsevolod Vlasov.
Otherwise, a lot of logging in WebCore needs to go through the DOMWindow which is unnecessary.
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.order:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
- bindings/v8/custom/V8CustomXPathNSResolver.cpp:
(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
- dom/Document.cpp:
(WebCore::Document::addConsoleMessage):
(WebCore::Document::addMessage):
- inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::muteConsole):
(WebCore::PageDebuggerAgent::unmuteConsole):
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::muteConsole):
(WebCore::PageRuntimeAgent::unmuteConsole):
- page/Console.cpp:
(WebCore::internalAddMessage):
- page/Console.h:
(WebCore):
(Console):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::pageConsole):
(WebCore):
(WebCore::DOMWindow::dispatchMessageEventWithOriginCheck):
(WebCore::DOMWindow::printErrorMessage):
- page/DOMWindow.h:
(WebCore):
(DOMWindow):
- page/Page.cpp:
(WebCore::Page::Page):
- page/Page.h:
(WebCore):
(WebCore::Page::console):
(Page):
- page/PageConsole.cpp: Added.
(WebCore::PageConsole::PageConsole):
(WebCore):
(WebCore::PageConsole::~PageConsole):
(WebCore::PageConsole::printSourceURLAndLine):
(WebCore::PageConsole::printMessageSourceAndLevelPrefix):
(WebCore::PageConsole::addMessage):
(WebCore::PageConsole::mute):
(WebCore::PageConsole::unmute):
(WebCore::PageConsole::shouldPrintExceptions):
(WebCore::PageConsole::setShouldPrintExceptions):
- page/PageConsole.h: Copied from Source/WebCore/page/Console.h.
(WebCore):
(PageConsole):
(WebCore::PageConsole::create):
(WebCore::PageConsole::page):
- xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::parseString):
- xml/XSLTProcessorLibxslt.cpp:
(WebCore::XSLTProcessor::parseErrorFunc):
(WebCore::docLoaderFunc):
Source/WebKit/mac:
- Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics shouldPrintExceptions]):
(+[WebCoreStatistics setShouldPrintExceptions:]):
- 8:47 AM Changeset in webkit [146207] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Fix WebKit2 builds after r146193
https://bugs.webkit.org/show_bug.cgi?id=112700
Reviewed by Martin Robinson.
Apply changes to the LayerTreeHostGtk class that are analogous to changes made in r146193
to the LayerTreeHostMac class, namely introducing a PageOverlayLayersMap and using that as
the source of GraphicsLayer objects that should be operated on, making it possible to
support multiple page overlays.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::initialize):
(WebKit::LayerTreeHostGtk::invalidate):
(WebKit::LayerTreeHostGtk::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHostGtk::setNonCompositedContentsNeedDisplayInRect):
(WebKit::LayerTreeHostGtk::sizeDidChange):
(WebKit::LayerTreeHostGtk::didInstallPageOverlay):
(WebKit::LayerTreeHostGtk::didUninstallPageOverlay):
(WebKit::LayerTreeHostGtk::setPageOverlayNeedsDisplay):
(WebKit::LayerTreeHostGtk::paintContents):
(WebKit::LayerTreeHostGtk::flushPendingLayerChanges):
(WebKit::LayerTreeHostGtk::createPageOverlayLayer):
(WebKit::LayerTreeHostGtk::destroyPageOverlayLayer):
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
(LayerTreeHostGtk):
- 8:39 AM Changeset in webkit [146206] by
-
- 2 edits in trunk/Tools
[Qt] Make ImageDiff similar to Chromium's ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=94782
Based on patch by Csaba Osztrogonác.
Reviewed by Jocelyn Turcotte.
The diff image is generated with bright red indicating errors, but letting the base image
shine through so the context of the error-pixel can be identified.
- DumpRenderTree/qt/ImageDiff.cpp:
(main):
- 8:18 AM Changeset in webkit [146205] by
-
- 2 edits in trunk
[Qt] QStyle: Set State_Enabled by default when painting style widgets.
https://bugs.webkit.org/show_bug.cgi?id=112688
Patch by David Rosca <nowrep@gmail.com> on 2013-03-19
Reviewed by Jocelyn Turcotte.
All Qt style widgets were painted with a disabled state, even when
they actually were enabled.
This change fixes it by setting State_Enabled as a default state,
which is then correctly removed when element is disabled.
- Source/WebCore/platform/qt/RenderThemeQStyle.cpp:
- 7:47 AM Changeset in webkit [146204] by
-
- 9 edits1 add in trunk/Source/WebCore
Web Inspector: move OverviewGrid and OverviewWindow into separate file.
https://bugs.webkit.org/show_bug.cgi?id=112693
Reviewed by Yury Semikhatsky.
It is the third patch for the meta bug "Web Inspector: meta bug: extract OverviewGrid from TimelineOverviewPane"
It just moves the OverviewGrid and the related classes into its own file.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- inspector/compile-front-end.py:
- inspector/front-end/OverviewGrid.js: Added.
(WebInspector.OverviewGrid):
(WebInspector.OverviewGrid.prototype.itemsGraphsElement):
(WebInspector.OverviewGrid.prototype.insertBeforeItemsGraphsElement):
(WebInspector.OverviewGrid.prototype.clientWidth):
(WebInspector.OverviewGrid.prototype.showItemsGraphsElement):
(WebInspector.OverviewGrid.prototype.hideItemsGraphsElement):
(WebInspector.OverviewGrid.prototype.updateDividers):
(WebInspector.OverviewGrid.prototype.addEventDividers):
(WebInspector.OverviewGrid.prototype.removeEventDividers):
(WebInspector.OverviewGrid.prototype.setWindowPosition):
(WebInspector.OverviewGrid.prototype.reset):
(WebInspector.OverviewGrid.prototype.windowLeft):
(WebInspector.OverviewGrid.prototype.windowRight):
(WebInspector.OverviewGrid.prototype.setWindow):
(WebInspector.OverviewGrid.prototype.addEventListener):
(WebInspector.OverviewGrid.Window):
(WebInspector.OverviewGrid.Window.prototype.reset):
(WebInspector.OverviewGrid.Window.prototype._leftResizeElementDragging):
(WebInspector.OverviewGrid.Window.prototype._rightResizeElementDragging):
(WebInspector.OverviewGrid.Window.prototype._startWindowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._windowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._endWindowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._startWindowDragging):
(WebInspector.OverviewGrid.Window.prototype._windowDragging):
(WebInspector.OverviewGrid.Window.prototype._endWindowDragging):
(WebInspector.OverviewGrid.Window.prototype._moveWindow):
(WebInspector.OverviewGrid.Window.prototype._resizeWindowLeft):
(WebInspector.OverviewGrid.Window.prototype._resizeWindowRight):
(WebInspector.OverviewGrid.Window.prototype._resizeWindowMaximum):
(WebInspector.OverviewGrid.Window.prototype._setWindow):
(WebInspector.OverviewGrid.Window.prototype._setWindowPosition):
(WebInspector.OverviewGrid.Window.prototype._onMouseWheel):
(WebInspector.OverviewGrid.Window.prototype._zoom):
(WebInspector.OverviewGrid.WindowSelector):
(WebInspector.OverviewGrid.WindowSelector.prototype._createSelectorElement):
(WebInspector.OverviewGrid.WindowSelector.prototype._close):
(WebInspector.OverviewGrid.WindowSelector.prototype._updatePosition):
- inspector/front-end/TimelineOverviewPane.js:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
- 7:28 AM Changeset in webkit [146203] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Monospace font does not render in proper sizes
https://bugs.webkit.org/show_bug.cgi?id=93263
Reviewed by Jocelyn Turcotte.
Do not force fonts to use integer metrics. This was necessary when the fast font path
only worked in integer but is now hindering accurate metrics. This is also required to
make kerning in the fast-path look acceptable
Only enabled for Qt 5.1+ to avoid changing all the baselines for 5.0.
- platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
- 7:13 AM Changeset in webkit [146202] by
-
- 5 edits3 adds in trunk
Web Inspector: Add iframe option to inspectedWindow.eval() extension API
https://bugs.webkit.org/show_bug.cgi?id=106811
Patch by John J. Barton <johnjbarton@chromium.org> on 2013-03-19
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Add a new case to the options processing in inspectedWindow.eval(), look
for option.frameURL <string> and/or option.scriptExecutionContext: <string>, find the
matching JS context in the runtimeModel, and call evaluate() in that
context; or error if the context is not found.
Test: http/tests/inspector/extensions-iframe-eval.html
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
(WebInspector.ExtensionServer.prototype.):
(WebInspector.ExtensionServer.prototype.evaluate):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype.frames):
Added read access to _frames
- inspector/front-end/RuntimeModel.js:
(WebInspector.RuntimeModel.prototype.contextListByFrame):
Added access to a frame's contextList, removed contextByFrameAndSecurityOrigin()
(WebInspector.FrameExecutionContextList.prototype.mainWorldContext):
Added access to frame's mainWorldContext, rather than implicit first context.
Now we can go from ResourceTreeModel -> frame -> contextList then either
mainWorldContext() or contextBySecurityOrigin() to access contexts.
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype.):
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
(WebInspector.ExtensionServer.prototype.evaluate):
- inspector/front-end/ResourceTreeModel.js:
- inspector/front-end/RuntimeModel.js:
(WebInspector.RuntimeModel.prototype.contextListByFrame):
(WebInspector.FrameExecutionContextList.prototype.mainWorldContext):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onReload):
(WebInspector.ExtensionServer.prototype.resolveURLToFrame.hasMatchingURL):
(WebInspector.ExtensionServer.prototype.):
(WebInspector.ExtensionServer.prototype.evaluate):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype.frames):
- inspector/front-end/RuntimeModel.js:
(WebInspector.RuntimeModel.prototype.contextListByFrame):
(WebInspector.FrameExecutionContextList.prototype.mainWorldContext):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype.resolveURLToFrame.hasMatchingURL):
(WebInspector.ExtensionServer.prototype.):
(WebInspector.ExtensionServer.prototype.evaluate):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype.frames):
- inspector/front-end/RuntimeModel.js:
(WebInspector.RuntimeModel.prototype.contextListByFrame):
(WebInspector.FrameExecutionContextList.prototype.mainWorldContext):
LayoutTests:
New tests for evaluate in iframe options in extension API
- http/tests/inspector/extensions-iframe-eval-expected.txt: Added.
- http/tests/inspector/extensions-iframe-eval.html: Added.
- http/tests/inspector/resources/extensions-frame-eval.html: Added.
- 6:22 AM Changeset in webkit [146201] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip a failing tests after r146174 and r146178.
- platform/qt/TestExpectations:
- 5:54 AM Changeset in webkit [146200] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: rename TimelineOverviewWindow to OverviewGrid.Window and fix names for constants.
https://bugs.webkit.org/show_bug.cgi?id=112685
Reviewed by Yury Semikhatsky.
It is the second patch which extracts OverviewGrid from TimelineOverviewPane.
It renames internal components of OverviewGrid.
WebInspector.TimelineOverviewWindow -> WebInspector.OverviewGrid.Window
WebInspector.TimelineOverviewWindow.WindowSelector -> WebInspector.OverviewGrid.WindowSelector
and moves constants from WebInspector.TimelineOverviewWindow namespace to WebInspector.OverviewGrid namespace
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.OverviewGrid):
(WebInspector.OverviewGrid.Window):
(WebInspector.OverviewGrid.Window.prototype._startWindowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._endWindowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._startWindowDragging):
(WebInspector.OverviewGrid.Window.prototype._windowDragging):
(WebInspector.OverviewGrid.Window.prototype._moveWindow):
(WebInspector.OverviewGrid.Window.prototype._resizeWindowRight):
(WebInspector.OverviewGrid.Window.prototype._setWindowPosition):
(WebInspector.OverviewGrid.Window.prototype._onMouseWheel):
(WebInspector.OverviewGrid.Window.prototype._zoom):
(WebInspector.OverviewGrid.WindowSelector):
(WebInspector.OverviewGrid.WindowSelector.prototype._createSelectorElement):
- 4:46 AM Changeset in webkit [146199] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: move _timelineGrid && _timelineOverviewWindow from TimelineOverviewPane into a new class OverviewGrid.
https://bugs.webkit.org/show_bug.cgi?id=112584
Reviewed by Pavel Feldman.
It is the first path in the set.
The end goal is to extract OverviewGrid with window selectors
into a separate class in separate file and reuse it in CPU FlameChart.
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.OverviewGrid):
(WebInspector.OverviewGrid.prototype.get grid):
(WebInspector.OverviewGrid.prototype.get clientWidth):
(WebInspector.OverviewGrid.prototype.showItemsGraphsElement):
(WebInspector.OverviewGrid.prototype.hideItemsGraphsElement):
(WebInspector.OverviewGrid.prototype.updateDividers):
(WebInspector.OverviewGrid.prototype.addEventDividers):
(WebInspector.OverviewGrid.prototype.removeEventDividers):
(WebInspector.OverviewGrid.prototype.setWindowPosition):
(WebInspector.OverviewGrid.prototype.reset):
(WebInspector.OverviewGrid.prototype.get windowLeft):
(WebInspector.OverviewGrid.prototype.get windowRight):
(WebInspector.OverviewGrid.prototype.setWindow):
(WebInspector.OverviewGrid.prototype.addEventListener):
(WebInspector.TimelineOverviewPane.prototype.setMode):
(WebInspector.TimelineOverviewPane.prototype._setFrameMode):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
(WebInspector.TimelineOverviewPane.prototype.zoomToFrame):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.TimelineOverviewPane.prototype.windowLeft):
(WebInspector.TimelineOverviewPane.prototype.windowRight):
(WebInspector.TimelineOverviewPane.prototype._updateWindow):
- 4:43 AM Changeset in webkit [146198] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Add Inspector.targetCrashed event to Inspector protocol.
https://bugs.webkit.org/show_bug.cgi?id=112669
Added Inspector.targetCrashed event and handled it on the front end.
Showing a modal dialog similar to the one displayed when the remote
debugging target is disconnected.
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-19
Reviewed by Pavel Feldman.
- English.lproj/localizedStrings.js:
- inspector/Inspector.json:
- inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreenUntilReload):
(WebInspector.HelpScreenUntilReload.prototype.willHide):
- inspector/front-end/inspector.js:
(WebInspector.targetCrashed):
- 4:05 AM Changeset in webkit [146197] by
-
- 2 edits in trunk/Tools
[Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
Rubber-stamped by Csaba Osztrogonác.
Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
since the latter might not cover the former.
- QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::print):
- 3:05 AM Changeset in webkit [146196] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Wrong guard USE(GLX) in RedirectedXCompositeWindow
https://bugs.webkit.org/show_bug.cgi?id=112600
Reviewed by Martin Robinson.
Replace USE(GLX) condition with USE(OPENGL) && PLATFORM(X11).
- platform/gtk/RedirectedXCompositeWindow.cpp: Updated guard.
- platform/gtk/RedirectedXCompositeWindow.h: Ditto.
- 2:32 AM Changeset in webkit [146195] by
-
- 3 edits in trunk/Source/JavaScriptCore
Implement and32 on ARMv7 and ARM traditional platforms
https://bugs.webkit.org/show_bug.cgi?id=112663
Reviewed by Zoltan Herczeg.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::and32): Add missing method.
(MacroAssemblerARM):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::and32): Add missing method.
(MacroAssemblerARMv7):
- 2:30 AM Changeset in webkit [146194] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip some failing tests.
- platform/qt-5.0-wk1/TestExpectations:
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt/TestExpectations:
- 2:27 AM Changeset in webkit [146193] by
-
- 14 edits in trunk/Source/WebKit2
[wk2] Should support multiple page overlays, like the API suggests
https://bugs.webkit.org/show_bug.cgi?id=112505
<rdar://problem/13424796>
Reviewed by Simon Fraser.
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/LayerTreeHost.h:
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::didInstallPageOverlay):
(WebKit::DrawingArea::didUninstallPageOverlay):
(WebKit::DrawingArea::setPageOverlayNeedsDisplay):
(WebKit::DrawingArea::setPageOverlayOpacity):
Add PageOverlay argument.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::didInstallPageOverlay):
(WebKit::DrawingAreaImpl::didUninstallPageOverlay):
(WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay):
(WebKit::DrawingAreaImpl::setPageOverlayOpacity):
Add PageOverlay argument, forward it to LayerTreeHost.
(WebKit::DrawingAreaImpl::display):
Paint all of the PageOverlays that WebPage knows about.
- WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::setNeedsDisplay):
(WebKit::PageOverlay::fadeAnimationTimerFired):
Pass the relevant PageOverlay into the DrawingArea methods that now take it.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::drawPageOverlay):
Take the PageOverlay to draw as an argument.
(WebKit::WebPage::installPageOverlay):
(WebKit::WebPage::uninstallPageOverlay):
Allow (un)installation of multiple PageOverlays.
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::mouseEventSyncForTesting):
Hit-test PageOverlays in reverse order of installation (most recently installed should be topmost).
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::drawPageOverlay): Take the PageOverlay to draw as an argument.
(WebKit::WebPage::hasPageOverlay): Return true if we have any number of overlays.
(WebKit::WebPage::pageOverlays): Return the whole vector of overlays.
- WebProcess/WebPage/mac/LayerTreeHostMac.h:
Add PageOverlay argument to a few methods.
Add storage for a map of PageOverlay->GraphicsLayers.
- WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplayInRect):
(WebKit::LayerTreeHostMac::sizeDidChange):
(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
Operate on all installed PageOverlays, not just the most recently installed one.
(WebKit::LayerTreeHostMac::didInstallPageOverlay):
(WebKit::LayerTreeHostMac::didUninstallPageOverlay):
Forward the passed-in PageOverlay on to createPageOverlayLayer/destroyPageOverlayLayer.
(WebKit::LayerTreeHostMac::setPageOverlayNeedsDisplay):
Look up the GraphicsLayer for the PageOverlay we need to dirty, and dirty it.
(WebKit::LayerTreeHostMac::paintContents):
Find the PageOverlay corresponding to the GraphicsLayer that we're painting, and ask WebPage to paint it.
While not ideal (crawling the map), the vast majority of the time there will only be one entry.
(WebKit::LayerTreeHostMac::initialize):
Create layers for all of WebPage's active PageOverlays.
(WebKit::LayerTreeHostMac::createPageOverlayLayer):
Stick the newly-created GraphicsLayer into the m_pageOverlays map.
Also, drive-by add support for accelerated overlays and debug borders/repaint counters in overlays.
(WebKit::LayerTreeHostMac::destroyPageOverlayLayer):
Remove the relevant overlay from the m_pageOverlays map and tear it down.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
Add PageOverlay argument to a few methods.
Add storage for a map of PageOverlay->GraphicsLayers.
Add storage for a map of GraphicsLayer->CALayers.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):
Pass PageOverlay argument on to createPageOverlayLayer.
(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):
Pass PageOverlay argument on to destroyPageOverlayLayer.
Refrain from re-enabling threaded scrolling if there are still more overlays installed.
(WebKit::TiledCoreAnimationDrawingArea::setPageOverlayNeedsDisplay):
Look up the GraphicsLayer for the PageOverlay we need to dirty, and dirty it.
(WebKit::TiledCoreAnimationDrawingArea::paintContents):
Find the PageOverlay corresponding to the GraphicsLayer that we're painting, and ask WebPage to paint it.
While not ideal (crawling the map), the vast majority of the time there will only be one entry.
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged):
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
Operate on all installed PageOverlays, not just the most recently installed one.
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
Stick the newly-created GraphicsLayer into the m_pageOverlays map.
Also, add its platformLayer to our m_pageOverlayPlatformLayers map.
(WebKit::TiledCoreAnimationDrawingArea::destroyPageOverlayLayer):
Remove the relevant overlay from the m_pageOverlays and m_pageOverlayPlatformLayers maps and tear it down.
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer):
When we commit changes for the layer, if the GraphicsLayer's backing platform CALayer
has changed out from under us (we have a reference to the previous one in the m_pageOverlayPlatformLayers map),
the GraphicsLayer has probably switched to/from a tiled layer, and we need to swap out the
layer we have inserted into the root layer. We need to keep the layer ordering consistent with
installation order, as well.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::didInstallPageOverlay):
Assert if we try to install more than one page overlay into a CoordinatedLayerTreeHost,
as this patch does not implement multiple overlay support for Coordinated Graphics.
Keep track of the current PageOverlay so that paintContents can hand WebPage the right one.
(WebKit::CoordinatedLayerTreeHost::didUninstallPageOverlay): Remove our reference to the PageOverlay.
(WebKit::CoordinatedLayerTreeHost::setPageOverlayNeedsDisplay): Add unused PageOverlay argument.
(WebKit::CoordinatedLayerTreeHost::setPageOverlayOpacity): Add unused PageOverlay argument.
(WebKit::CoordinatedLayerTreeHost::paintContents): Hand WebPage the PageOverlay we're currently displaying.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(CoordinatedLayerTreeHost): Add PageOverlay* argument to relevant functions, and storage for m_pageOverlay.
- 2:09 AM Changeset in webkit [146192] by
-
- 4 edits2 adds in trunk
[CSSRegions] Crash reflowing content in variable width regions
https://bugs.webkit.org/show_bug.cgi?id=112515
Reviewed by David Hyatt.
Source/WebCore:
When removing floats during relayout of a line in a paginated context,
we have to make sure that the floats collection actually has elements before
accessing the last float from the collection.
This situation arises when a block had floats in a previous layout and after
they were removed, m_floatingObjects is not destroyed, only emptied.
Test: fast/regions/crash-reflow-inline-content-in-variable-width-regions.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeFloatingObjectsBelow):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
LayoutTests:
- fast/regions/crash-reflow-inline-content-in-variable-width-regions-expected.txt: Added.
- fast/regions/crash-reflow-inline-content-in-variable-width-regions.html: Added.
- 2:06 AM Changeset in webkit [146191] by
-
- 14 edits1 add in trunk
Web Inspector: Debugger scripts should visually differ from network/filesystem files in workspace.
https://bugs.webkit.org/show_bug.cgi?id=112552
Reviewed by Pavel Feldman.
Source/WebCore:
Extracted ContentProviderBasedProjectDelegate from SimpleProjectDelegate.
Implemented DebuggerProjectDelegate for DefaultScriptMapping.
Debugger scripts are now added to workspace with a name starting with [VM] and ending with scriptId.
Added yellow background to debugger scripts editor.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/ContentProviderBasedProjectDelegate.js: Added.
- inspector/front-end/DefaultScriptMapping.js:
(WebInspector.DefaultScriptMapping):
(WebInspector.DefaultScriptMapping.prototype.addScript):
(WebInspector.DefaultScriptMapping.prototype._debuggerReset):
(WebInspector.DebuggerProjectDelegate):
(WebInspector.DebuggerProjectDelegate.prototype.id):
(WebInspector.DebuggerProjectDelegate.prototype.type):
(WebInspector.DebuggerProjectDelegate.prototype.displayName):
(WebInspector.DebuggerProjectDelegate.prototype.addScript):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
- inspector/front-end/ParsedURL.js:
(WebInspector.ParsedURL.splitURL):
- inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleProjectDelegate):
(WebInspector.SimpleProjectDelegate.prototype.addFile):
(WebInspector.SimpleProjectDelegate.prototype._ensureUniquePath):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/Workspace.js:
(WebInspector.Workspace.prototype.uiSourceCodeForURL):
- inspector/front-end/inspector.html:
- inspector/front-end/javaScriptSourceFrame.css: Added.
(.source-frame-debugger-script):
LayoutTests:
- inspector/debugger/live-edit-breakpoints-expected.txt:
- 1:58 AM Changeset in webkit [146190] by
-
- 14 edits in trunk/Source/WebKit2
Unreviewed, rolling out r146183.
http://trac.webkit.org/changeset/146183
https://bugs.webkit.org/show_bug.cgi?id=112673
Caused a few dozens of editing tests to fail on Mac WK2
(Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-19
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::didInstallPageOverlay):
(WebKit::CoordinatedLayerTreeHost::didUninstallPageOverlay):
(WebKit::CoordinatedLayerTreeHost::setPageOverlayNeedsDisplay):
(WebKit::CoordinatedLayerTreeHost::setPageOverlayOpacity):
(WebKit::CoordinatedLayerTreeHost::paintContents):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(CoordinatedLayerTreeHost):
- WebProcess/WebPage/DrawingArea.h:
(WebKit):
(WebKit::DrawingArea::didInstallPageOverlay):
(WebKit::DrawingArea::didUninstallPageOverlay):
(WebKit::DrawingArea::setPageOverlayNeedsDisplay):
(WebKit::DrawingArea::setPageOverlayOpacity):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::didInstallPageOverlay):
(WebKit::DrawingAreaImpl::didUninstallPageOverlay):
(WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay):
(WebKit::DrawingAreaImpl::setPageOverlayOpacity):
(WebKit::DrawingAreaImpl::display):
- WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
- WebProcess/WebPage/LayerTreeHost.h:
(LayerTreeHost):
(WebKit::LayerTreeHost::setPageOverlayOpacity):
- WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::setNeedsDisplay):
(WebKit::PageOverlay::fadeAnimationTimerFired):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::drawPageOverlay):
(WebKit::WebPage::installPageOverlay):
(WebKit::WebPage::uninstallPageOverlay):
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::mouseEventSyncForTesting):
- WebProcess/WebPage/WebPage.h:
(WebKit):
(WebPage):
(WebKit::WebPage::hasPageOverlay):
- WebProcess/WebPage/mac/LayerTreeHostMac.h:
(WebKit):
(LayerTreeHostMac):
- WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplayInRect):
(WebKit::LayerTreeHostMac::sizeDidChange):
(WebKit::LayerTreeHostMac::didInstallPageOverlay):
(WebKit::LayerTreeHostMac::didUninstallPageOverlay):
(WebKit::LayerTreeHostMac::setPageOverlayNeedsDisplay):
(WebKit::LayerTreeHostMac::paintContents):
(WebKit::LayerTreeHostMac::initialize):
(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
(WebKit::LayerTreeHostMac::createPageOverlayLayer):
(WebKit::LayerTreeHostMac::destroyPageOverlayLayer):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):
(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):
(WebKit::TiledCoreAnimationDrawingArea::setPageOverlayNeedsDisplay):
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
(WebKit::TiledCoreAnimationDrawingArea::paintContents):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged):
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::destroyPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer):
- 1:41 AM WebKitGTK/2.0.x edited by
- Add new change on track (diff)
- 1:08 AM Changeset in webkit [146189] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
spelling-changed-text.html passes after r145849.
- platform/efl/TestExpectations:
- 1:07 AM Changeset in webkit [146188] by
-
- 7 edits1 add in trunk/Source/WebCore
Web Inspector: [CodeMirror] add smart braces functionality
https://bugs.webkit.org/show_bug.cgi?id=112138
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-19
Reviewed by Vsevolod Vlasov.
No new tests.
Add closebrackets add-on to codemirror which implements smart braces
functionality and guard this setting with the "Text Editor smart
braces" experiment.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- inspector/front-end/CodeMirrorTextEditor.js:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/cm/closebrackets.js: Added.
(.):
- 1:04 AM Changeset in webkit [146187] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Avoid forcing text editor resize
https://bugs.webkit.org/show_bug.cgi?id=112581
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-19
Reviewed by Vsevolod Vlasov.
No new tests.
Avoid unnecessary text editor resizing by removing line decoration
via removeDecoration method instead of DOM remove operation.
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.clearMessages):
(WebInspector.SourceFrame.prototype._setTextEditorDecorations):
- 1:03 AM Changeset in webkit [146186] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: [CodeMirror] fix cursor movements
https://bugs.webkit.org/show_bug.cgi?id=112555
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-19
Reviewed by Vsevolod Vlasov.
No new tests.
- Update CodeMirror to ToT to include its improved cursor movement
- Add a small keymap to force cursor stop on both line endings and line
starts.
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.FixWordMovement):
(WebInspector.CodeMirrorTextEditor.FixWordMovement.moveRight):
- inspector/front-end/cm/codemirror.css:
(.CodeMirror div.CodeMirror-cursor):
(.CodeMirror.cm-keymap-fat-cursor div.CodeMirror-cursor):
(.CodeMirror):
- inspector/front-end/cm/codemirror.js:
(window.CodeMirror):
(window.CodeMirror.):
- 1:01 AM GStreamer edited by
- (diff)
- 12:56 AM Changeset in webkit [146185] by
-
- 2 edits in trunk/Source/WebCore
[chromium] Regression(143825): select elements don't open when there is a marquee on the page
https://bugs.webkit.org/show_bug.cgi?id=111278
Unreviewed.
This patch is a rollout of http://trac.webkit.org/changeset/143825. The
original patch caused a regression in the Chromium port.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
- 12:54 AM GStreamer/GStreamerOnMac edited by
- (diff)
- 12:50 AM Changeset in webkit [146184] by
-
- 3 edits2 adds in trunk
Web Inspector: [Styles] Matching @host rule children are not displayed
https://bugs.webkit.org/show_bug.cgi?id=112664
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Process host rules' contents akin to media rules' when handling the CSS model and source data.
Test: platform/chromium/inspector/styles/host-rules.html
- inspector/InspectorStyleSheet.cpp:
(flattenSourceData):
(WebCore::asCSSRuleList):
LayoutTests:
- platform/chromium/inspector/styles/host-rules-expected.txt: Added.
- platform/chromium/inspector/styles/host-rules.html: Added.
Mar 18, 2013:
- 11:46 PM Changeset in webkit [146183] by
-
- 14 edits in trunk/Source/WebKit2
[wk2] Should support multiple page overlays, like the API suggests
https://bugs.webkit.org/show_bug.cgi?id=112505
<rdar://problem/13424796>
Reviewed by Simon Fraser.
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/LayerTreeHost.h:
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::didInstallPageOverlay):
(WebKit::DrawingArea::didUninstallPageOverlay):
(WebKit::DrawingArea::setPageOverlayNeedsDisplay):
(WebKit::DrawingArea::setPageOverlayOpacity):
Add PageOverlay argument.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::didInstallPageOverlay):
(WebKit::DrawingAreaImpl::didUninstallPageOverlay):
(WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay):
(WebKit::DrawingAreaImpl::setPageOverlayOpacity):
Add PageOverlay argument, forward it to LayerTreeHost.
(WebKit::DrawingAreaImpl::display):
Paint all of the PageOverlays that WebPage knows about.
- WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::setNeedsDisplay):
(WebKit::PageOverlay::fadeAnimationTimerFired):
Pass the relevant PageOverlay into the DrawingArea methods that now take it.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::drawPageOverlay):
Take the PageOverlay to draw as an argument.
(WebKit::WebPage::installPageOverlay):
(WebKit::WebPage::uninstallPageOverlay):
Allow (un)installation of multiple PageOverlays.
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::mouseEventSyncForTesting):
Hit-test PageOverlays in reverse order of installation (most recently installed should be topmost).
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::drawPageOverlay): Take the PageOverlay to draw as an argument.
(WebKit::WebPage::hasPageOverlay): Return true if we have any number of overlays.
(WebKit::WebPage::pageOverlays): Return the whole vector of overlays.
- WebProcess/WebPage/mac/LayerTreeHostMac.h:
Add PageOverlay argument to a few methods.
Add storage for a map of PageOverlay->GraphicsLayers.
- WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplayInRect):
(WebKit::LayerTreeHostMac::sizeDidChange):
(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
Operate on all installed PageOverlays, not just the most recently installed one.
(WebKit::LayerTreeHostMac::didInstallPageOverlay):
(WebKit::LayerTreeHostMac::didUninstallPageOverlay):
Forward the passed-in PageOverlay on to createPageOverlayLayer/destroyPageOverlayLayer.
(WebKit::LayerTreeHostMac::setPageOverlayNeedsDisplay):
Look up the GraphicsLayer for the PageOverlay we need to dirty, and dirty it.
(WebKit::LayerTreeHostMac::paintContents):
Find the PageOverlay corresponding to the GraphicsLayer that we're painting, and ask WebPage to paint it.
While not ideal (crawling the map), the vast majority of the time there will only be one entry.
(WebKit::LayerTreeHostMac::initialize):
Create layers for all of WebPage's active PageOverlays.
(WebKit::LayerTreeHostMac::createPageOverlayLayer):
Stick the newly-created GraphicsLayer into the m_pageOverlayLayers map.
Also, drive-by add support for accelerated overlays and debug borders/repaint counters in overlays.
(WebKit::LayerTreeHostMac::destroyPageOverlayLayer):
Remove the relevant overlay from the m_pageOverlayLayers map and tear it down.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
Add PageOverlay argument to a few methods.
Add storage for a map of PageOverlay->GraphicsLayers.
Add storage for a map of GraphicsLayer->CALayers.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):
Pass PageOverlay argument on to createPageOverlayLayer.
(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):
Pass PageOverlay argument on to destroyPageOverlayLayer.
Refrain from re-enabling threaded scrolling if there are still more overlays installed.
(WebKit::TiledCoreAnimationDrawingArea::setPageOverlayNeedsDisplay):
Look up the GraphicsLayer for the PageOverlay we need to dirty, and dirty it.
(WebKit::TiledCoreAnimationDrawingArea::paintContents):
Find the PageOverlay corresponding to the GraphicsLayer that we're painting, and ask WebPage to paint it.
While not ideal (crawling the map), the vast majority of the time there will only be one entry.
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged):
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
Operate on all installed PageOverlays, not just the most recently installed one.
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
Stick the newly-created GraphicsLayer into the m_pageOverlayLayers map.
Also, add its platformLayer to our m_pageOverlayPlatformLayers map.
(WebKit::TiledCoreAnimationDrawingArea::destroyPageOverlayLayer):
Remove the relevant overlay from the m_pageOverlayLayers and m_pageOverlayPlatformLayers maps and tear it down.
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer):
When we commit changes for the layer, if the GraphicsLayer's backing platform CALayer
has changed out from under us (we have a reference to the previous one in the m_pageOverlayPlatformLayers map),
the GraphicsLayer has probably switched to/from a tiled layer, and we need to swap out the
layer we have inserted into the root layer. We need to keep the layer ordering consistent with
installation order, as well.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::didInstallPageOverlay):
Assert if we try to install more than one page overlay into a CoordinatedLayerTreeHost,
as this patch does not implement multiple overlay support for Coordinated Graphics.
Keep track of the current PageOverlay so that paintContents can hand WebPage the right one.
(WebKit::CoordinatedLayerTreeHost::didUninstallPageOverlay): Remove our reference to the PageOverlay.
(WebKit::CoordinatedLayerTreeHost::setPageOverlayNeedsDisplay): Add unused PageOverlay argument.
(WebKit::CoordinatedLayerTreeHost::setPageOverlayOpacity): Add unused PageOverlay argument.
(WebKit::CoordinatedLayerTreeHost::paintContents): Hand WebPage the PageOverlay we're currently displaying.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(CoordinatedLayerTreeHost): Add PageOverlay* argument to relevant functions, and storage for m_pageOverlay.
- 11:17 PM Changeset in webkit [146182] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Styles] The "inherit" property value should be suggested for all properties
https://bugs.webkit.org/show_bug.cgi?id=112662
Reviewed by Vsevolod Vlasov.
- inspector/front-end/CSSMetadata.js:
(WebInspector.CSSMetadata.keywordsForProperty):
- 11:17 PM Changeset in webkit [146181] by
-
- 3 edits1 add in trunk/LayoutTests
Change icon-url-property test for platforms which don't support dumpIconChanges.
https://bugs.webkit.org/show_bug.cgi?id=112660
Reviewed by Simon Fraser.
Add the baseline for mac and remove the test failure.
- fast/dom/icon-url-property.html:
- platform/mac/TestExpectations:
- platform/mac/fast/dom/icon-url-property-expected.txt: Added.
- 10:41 PM Changeset in webkit [146180] by
-
- 2 edits in trunk/LayoutTests
Media playhead button is sometimes 1px wider: media/video-playing-and-pause.html flakey
https://bugs.webkit.org/show_bug.cgi?id=112659
- platform/mac/TestExpectations:
- 10:23 PM Changeset in webkit [146179] by
-
- 6 edits6 adds in trunk
DFG ToString generic cases should work correctly
https://bugs.webkit.org/show_bug.cgi?id=112654
<rdar://problem/13447250>
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileToStringOnCell):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
LayoutTests:
- fast/js/dfg-to-string-on-cell-expected.txt: Added.
- fast/js/dfg-to-string-on-cell.html: Added.
- fast/js/dfg-to-string-on-value-expected.txt: Added.
- fast/js/dfg-to-string-on-value.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-to-string-on-cell.js: Added.
(foo):
- fast/js/script-tests/dfg-to-string-on-value.js: Added.
(foo):
- 9:42 PM Changeset in webkit [146178] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix for 32 bit builds.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 9:15 PM Changeset in webkit [146177] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX (r146088): ResourceRequest::cfURLRequest() is defined twice on iOS
<http://webkit.org/b/112387>
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::cfURLRequest): Move method into
!USE(CFNETWORK) section since it's also defined in
cf/ResourceRequestCFNet.cpp on iOS.
- 9:00 PM Changeset in webkit [146176] by
-
- 2 edits in trunk/LayoutTests
fast/dom/icon-url-property.html fails on Mac after r146173
- platform/mac/TestExpectations:
- 8:50 PM Changeset in webkit [146175] by
-
- 5 edits in trunk/Source/WebCore
[chromium] More tracing in deferred image decoding
https://bugs.webkit.org/show_bug.cgi?id=112648
Reviewed by James Robinson.
Adding more trace events for a couple things in deferred image decoding path:
- Time span for each lock pixels of SkPixelRef.
- Time spent on decoding, scaling and pruning. Also the stack trace for these events.
- Memory usage and number of cached entries.
- Number of decode & scale operations done per image.
No test as this just add tracing information and no behavior change.
- platform/graphics/chromium/ImageDecodingStore.cpp:
(WebCore::ImageDecodingStore::prune):
(WebCore::ImageDecodingStore::insertCacheInternal):
(WebCore::ImageDecodingStore::removeFromCacheInternal):
- platform/graphics/chromium/ImageFrameGenerator.cpp:
(WebCore::ImageFrameGenerator::ImageFrameGenerator):
(WebCore::ImageFrameGenerator::decodeAndScale):
(WebCore::ImageFrameGenerator::tryToScale):
(WebCore::ImageFrameGenerator::tryToResumeDecodeAndScale):
(WebCore::ImageFrameGenerator::tryToDecodeAndScale):
(WebCore::ImageFrameGenerator::decode):
- platform/graphics/chromium/ImageFrameGenerator.h:
(ImageFrameGenerator):
- platform/graphics/chromium/LazyDecodingPixelRef.cpp:
(WebCore::LazyDecodingPixelRef::onLockPixels):
(WebCore::LazyDecodingPixelRef::onUnlockPixels):
(WebCore::LazyDecodingPixelRef::PrepareToDecode):
- 8:22 PM Changeset in webkit [146174] by
-
- 5 edits in trunk/Source/JavaScriptCore
EFL: Unsafe branch detected in compilePutByValForFloatTypedArray()
https://bugs.webkit.org/show_bug.cgi?id=112609
Reviewed by Geoffrey Garen.
Created local valueFPR and scratchFPR and filled them with valueOp.fpr() and scratch.fpr()
respectively so that if valueOp.fpr() causes a spill during allocation, it occurs before the
branch and also to follow convention. Added register allocation checks to FPRTemporary.
Cleaned up a couple of other places to follow the "AllocatVirtualRegType foo, get machine
reg from foo" pattern.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::fprAllocate):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::convertToDouble):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 8:00 PM Changeset in webkit [146173] by
-
- 3 edits in trunk/LayoutTests
Dump icon change events in the icon-url-property test.
https://bugs.webkit.org/show_bug.cgi?id=112647
Reviewed by Jochen Eisinger.
This allows us to check that the didChangeIcon callback
is being done when it should be done. This test stopped
testing that in r122806 but it did before that.
- fast/dom/icon-url-property-expected.txt:
- fast/dom/icon-url-property.html:
- 7:38 PM Changeset in webkit [146172] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Generalized suppression for flaky
fast/js/repeat-cached-vm-reentry.html .
- platform/chromium/TestExpectations:
- 7:26 PM Changeset in webkit [146171] by
-
- 3 edits in trunk/LayoutTests
Unreviewed rebaselining after r146167.
- platform/chromium-win/css3/flexbox/flexbox-baseline-margins-expected.png:
- platform/chromium-win/fast/layers/scroll-rect-to-visible-expected.png:
- 7:12 PM Changeset in webkit [146170] by
-
- 2 edits in trunk/Source/WTF
[iOS] Make a UChar string equal() based on the LChar version
https://bugs.webkit.org/show_bug.cgi?id=112495
Reviewed by David Kilzer.
- wtf/text/StringImpl.h:
(WTF::equal):
Create a equal() function for UChar based on the work done for LChar.
On A6, this is a speed up of about 40% for any string of 2 or more characters.
It is slower by 8% on a single UChar comparison.
- 6:45 PM Changeset in webkit [146169] by
-
- 5 edits in branches/chromium/1410/Source/WebCore/bindings/v8
Merge 144458
BUG=150737
Review URL: https://codereview.chromium.org/12926003
- 6:28 PM Changeset in webkit [146168] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Rebaselined run-bindings-tests after r146161.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjEnumAttr):
(WebCore::jsTestObjPrototypeFunctionMethodWithEnumArg):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
- 6:07 PM Changeset in webkit [146167] by
-
- 10 edits in trunk
[chromium] Small pixel differences in scroll bars after r145844
https://bugs.webkit.org/show_bug.cgi?id=112384
Patch by Robert Flack <flackr@chromium.org> on 2013-03-18
Reviewed by Kenneth Russell.
Source/WebCore:
Tests: fast/forms/basic-textareas-quirks.html
fast/forms/basic-textareas.html
fast/overflow/overflow-x-y.html
fast/parser/open-comment-in-textarea.html
fast/replaced/width100percent-textarea.html
- platform/chromium/ScrollbarThemeChromium.cpp:
(WebCore::ScrollbarThemeChromium::trackRect):
LayoutTests:
- platform/chromium-linux/fast/forms/basic-textareas-expected.png:
- platform/chromium-linux/fast/forms/basic-textareas-quirks-expected.png:
- platform/chromium-linux/fast/overflow/overflow-x-y-expected.png:
- platform/chromium-linux/fast/parser/open-comment-in-textarea-expected.png:
- platform/chromium-linux/fast/replaced/width100percent-textarea-expected.png:
- platform/chromium-win/fast/forms/basic-textareas-quirks-expected.png:
- 6:04 PM Changeset in webkit [146166] by
-
- 2 edits in trunk/LayoutTests
fast/css/lang-mapped-to-webkit-locale-dynamic.xhtml is flakey
- platform/mac/TestExpectations:
- 5:46 PM Changeset in webkit [146165] by
-
- 3 edits in trunk/Source/WebCore
[WinCairo] Unreviewed build correction.
The "ImageDecoder.h" file was improperly tagged as a source file to
build, causing a build failure on initial build attempts. Subsequent
or incremental builds would work.
- WebCore.vcxproj/WebCore.vcxproj: Exclude CG-specific font files.
Switch 'ImageDecoder.h' to proper source file type.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- 5:44 PM Changeset in webkit [146164] by
-
- 8 edits in trunk/Source/JavaScriptCore
DFG should inline binary string concatenations (i.e. ValueAdd with string children)
https://bugs.webkit.org/show_bug.cgi?id=112599
Reviewed by Oliver Hunt.
This does as advertised: if you do x + y where x and y are strings, you'll get
a fast inlined JSRopeString allocation (along with whatever checks are necessary).
It also does good things if either x or y (or both) are StringObjects, or some
other thing like StringOrStringObject. It also lays the groundwork for making this
fast if either x or y are numbers, or some other reasonably-cheap-to-convert
value.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(FixupPhase):
(JSC::DFG::FixupPhase::isStringObjectUse):
(JSC::DFG::FixupPhase::convertStringAddUse):
(JSC::DFG::FixupPhase::attemptToMakeFastStringAdd):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileAdd):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::emitAllocateJSCell):
(JSC::DFG::SpeculativeJIT::emitAllocateJSObject):
- runtime/JSString.h:
(JSC::JSString::offsetOfFlags):
(JSString):
(JSRopeString):
(JSC::JSRopeString::offsetOfFibers):
- 5:37 PM Changeset in webkit [146163] by
-
- 4 edits2 deletes in trunk/Source
[chromium] Remove unused type WebTransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=112634
Reviewed by Adam Barth.
Source/Platform:
- Platform.gypi:
- chromium/public/WebTransformationMatrix.h: Removed.
Source/WebCore:
- WebCore.gypi:
- platform/chromium/support/WebTransformationMatrix.cpp: Removed.
- 5:34 PM Changeset in webkit [146162] by
-
- 2 edits in trunk/LayoutTests
fast/events/pageshow-pagehide.html sometimes crashes.
https://bugs.webkit.org/show_bug.cgi?id=81291
- platform/mac-wk2/TestExpectations:
- 5:33 PM Changeset in webkit [146161] by
-
- 12 edits in trunk/Source/WebCore
Add IDL 'enum' support to CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=112475
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-18
Reviewed by Kentaro Hara.
This adds support for enumerations in JS, adding validation checking
to setters.
It also does validation checking to methods, and a new method
methodWithEnumArg in TestObj.idl
Test: bindings/scripts/test/TestObj.idl
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateParametersCheck):
(NativeToJSValue):
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::methodWithEnumArg):
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_method_with_enum_arg):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjEnumAttr):
(WebCore::setJSTestObjEnumAttr):
(WebCore::jsTestObjPrototypeFunctionMethodWithEnumArg):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj methodWithEnumArg:]):
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::methodWithEnumArgMethod):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::methodWithEnumArgMethodCallback):
(WebCore::ConfigureV8TestObjTemplate):
- 5:28 PM Changeset in webkit [146160] by
-
- 2 edits in trunk/LayoutTests
plugins/private-browsing-mode.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=112646
- platform/mac/TestExpectations:
- 5:27 PM Changeset in webkit [146159] by
-
- 2 edits in trunk/LayoutTests
Unreviewed suppression for flaky test.
https://bugs.webkit.org/show_bug.cgi?id=112643
- platform/chromium/TestExpectations:
- 5:24 PM Changeset in webkit [146158] by
-
- 2 edits in trunk/LayoutTests
editing/deleting/paste-with-transparent-background-color.html
sometimes asserts.
- platform/mac/TestExpectations:
- 5:20 PM Changeset in webkit [146157] by
-
- 4 edits in trunk/Source/JavaScriptCore
JSC_NATIVE_FUNCTION() takes an identifier for the name and then uses #name, which is unsafe if name was already #define'd to something else
https://bugs.webkit.org/show_bug.cgi?id=112639
Reviewed by Michael Saboff.
Change it to take a string instead.
- runtime/JSObject.h:
(JSC):
- runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::finishCreation):
- runtime/StringPrototype.cpp:
(JSC::StringPrototype::finishCreation):
- 5:17 PM Changeset in webkit [146156] by
-
- 1 edit2 adds in trunk/LayoutTests
Older shadow root rendered in incorrect order when multiple shadow roots containing style tags have been constructed
https://bugs.webkit.org/show_bug.cgi?id=93752
The bug was already fixed in some point. This change just adds a regression test to cover the reported problem.
Reviewed by Dimitri Glazkov.
- fast/dom/shadow/multiple-shadowroots-with-empty-styles-expected.html: Added.
- fast/dom/shadow/multiple-shadowroots-with-empty-styles.html: Added.
- 5:13 PM Changeset in webkit [146155] by
-
- 2 edits in trunk/Tools
Style tweeks to default.css.
Rubber-stamped by David Kilzer.
Give visited links a different color to other links, so you can
see which builds you've viewed.
Make the <small> text less tiny.
- BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
(small):
(a:link,a:visited,a:active):
(a:visited):
- 5:12 PM Changeset in webkit [146154] by
-
- 11 edits in trunk/Source
Need a bundle SPI to generate a snapshot of a specific DOM node (like [DOMNode renderedImage])
<rdar://problem/13148631>
https://bugs.webkit.org/show_bug.cgi?id=110034
Reviewed by Tim Horton.
Source/WebCore:
- WebCore.exp.in:
Add some necessary exports.
Source/WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(WKBundleNodeHandleCopySnapshotWithOptions):
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
Add WKBundleNodeHandleCopySnapshotWithOptions function.
- WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:
- WebProcess/InjectedBundle/API/mac/WKDOMNodePrivate.h:
Fix conversion method between WKDOMNode and WKBundleNodeHandleRef to have the same
name in the header and implementation.
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::imageForRect):
(WebKit):
(WebKit::InjectedBundleNodeHandle::renderedImage):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
Add implementation of WKBundleNodeHandleCopySnapshotWithOptions.
- Shared/ImageOptions.h:
(WebKit::snapshotOptionsToImageOptions):
- WebProcess/WebPage/WebPage.cpp:
Move snapshotOptionsToImageOptions conversion function to a location where
it can be shared.
- 5:10 PM Changeset in webkit [146153] by
-
- 7 edits10 adds in trunk/Source/WebCore
[WinCairo] Build WebCore under VS2010
https://bugs.webkit.org/show_bug.cgi?id=112637
Reviewed by Tim Horton.
- WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj: Extend project
with WinCairo-specific build targets.
- WebCore.vcxproj/QTMovieWin/QTMovieWinCairoDebug.props: Added.
- WebCore.vcxproj/QTMovieWin/QTMovieWinCairoRelease.props: Added.
- WebCore.vcxproj/WebCore.vcxproj: Update to build WinCairo version
of code.
- WebCore.vcxproj/WebCoreCURL.props: Added.
- WebCore.vcxproj/WebCoreCairo.props: Added.
- WebCore.vcxproj/WebCoreDebugWinCairo.props: Added.
- WebCore.vcxproj/WebCoreGenerated.vcxproj:
- WebCore.vcxproj/WebCoreGeneratedDebugWinCairo.props: Added.
- WebCore.vcxproj/WebCoreGeneratedReleaseWinCairo.props: Added.
- WebCore.vcxproj/WebCoreGeneratedWinCairo.make: Added.
- WebCore.vcxproj/WebCoreGeneratedWinCairoCommon.props: Added.
- WebCore.vcxproj/WebCoreReleaseWinCairo.props: Added.
- WebCore.vcxproj/WebCoreTestSupport.vcxproj:
- WebCorePrefix.h: Update header to not include Apple-specific
headers during WinCairo build.
- 4:54 PM Changeset in webkit [146152] by
-
- 3 edits in trunk/Source/WebCore
IDB Cursor continue moves one item at a time
https://bugs.webkit.org/show_bug.cgi?id=109972
Reviewed by Tony Chang.
IndexedDB: Use seek on the underlying levelDB iterator to implement the continue operation
on a cursor, instead of advancing one item at a time. On a simple test in Chrome - open a
key cursor on an index w/ 100 items, then do continue(50), rinse and repeat - this cuts the
time 50% (850c/s to 1700c/s). (Original patch c/o Pankaj Kakkar <pankaj@google.com>)
Covered by existing storage/indexeddb cursor tests; just a performance optimization.
- Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::Cursor::continueFunction): Special case first iteration w/ key
to use leveldb seek (forward cursors only, since reverse seek isn't exposed).
(WebCore::ObjectStoreKeyCursorImpl::encodeKey): Helper for encoding key to seek to.
(WebCore::ObjectStoreCursorImpl::encodeKey): Ditto.
(WebCore::IndexKeyCursorImpl::encodeKey): Ditto.
(WebCore::IndexCursorImpl::encodeKey): Ditto.
(WebCore::objectStoreCursorOptions): Store IDs for encodeKey() to use.
(WebCore::indexCursorOptions): Ditto.
- Modules/indexeddb/IDBBackingStore.h:
(CursorOptions): Storage for IDs.
(Cursor): Add encodeKey() to interface.
- 4:52 PM Changeset in webkit [146151] by
-
- 8 edits in trunk/Source/WebCore
MessagePortChannel::EventData should not be exposed
https://bugs.webkit.org/show_bug.cgi?id=112635
Reviewed by Geoff Garen.
MessagePortChannel::EventData is an implementation detail that's only needed to
store events in MessageQueue. Other existing code already gets away without it,
just passing message and ports separately.
- dom/MessagePort.cpp: (WebCore::MessagePort::postMessage): (WebCore::MessagePort::dispatchMessages):
- dom/MessagePortChannel.cpp:
- dom/MessagePortChannel.h:
- dom/default/PlatformMessagePortChannel.cpp: (WebCore::PlatformMessagePortChannel::EventData::create): (WebCore::PlatformMessagePortChannel::EventData::EventData): (WebCore::MessagePortChannel::postMessageToRemote): (WebCore::MessagePortChannel::tryGetMessageFromRemote):
- dom/default/PlatformMessagePortChannel.h: (WebCore::PlatformMessagePortChannel::EventData::message): (WebCore::PlatformMessagePortChannel::EventData::channels): (PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage): (WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty):
- dom/default/chromium/PlatformMessagePortChannelChromium.cpp: (WebCore::MessagePortChannel::postMessageToRemote): (WebCore::MessagePortChannel::tryGetMessageFromRemote): (WebCore::PlatformMessagePortChannel::postMessageToRemote): (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
- dom/default/chromium/PlatformMessagePortChannelChromium.h:
- 4:51 PM FeatureFlags edited by
- VIEW_MODE_CSS_MEDIA (diff)
- 4:42 PM Changeset in webkit [146150] by
-
- 2 edits in trunk/Tools
Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
https://bugs.webkit.org/show_bug.cgi?id=112494
Reviewed by Dirk Pranke.
Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
Also merged two pairs of methods to cleanup the code.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.run): Merged _upload_and_show_results.
(PerfTestsRunner._generate_results): Merged _generate_output_files.
- 4:31 PM Changeset in webkit [146149] by
-
- 6 edits2 copies in branches/chromium/1410
Merge 145423
BUG=177686
Review URL: https://codereview.chromium.org/12573007
- 4:22 PM Changeset in webkit [146148] by
-
- 2 edits in trunk/Tools
[chromium] build xdisplaycheck when building DRT
https://bugs.webkit.org/show_bug.cgi?id=112636
Reviewed by Tony Chang.
It appears that we need xdisplaycheck to be built in order for
Xvfb to be started correctly on the bots, and DRT was missing
a dependency on it. This may be the cause of the ASAN bot not
starting up properly (it only builds DRT).
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 4:17 PM Changeset in webkit [146147] by
-
- 2 edits in trunk/Source/WebCore
[v8] Suppress binding integrity check of HTMLContentElement.
https://bugs.webkit.org/show_bug.cgi?id=112613
Reviewed by Adam Barth.
Patch is correct so long as fast/dom/shadow/content-element-user-agent-shadow.html
continues to pass.
- html/shadow/HTMLContentElement.idl:
- 4:16 PM Changeset in webkit [146146] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove failing Windows-specific result; this test passes now.
- platform/win/media/nodesFromRect-shadowContent-expected.txt: Removed.
- 4:10 PM Changeset in webkit [146145] by
-
- 4 edits in trunk/Source/WebCore
Support Windows HTMLSelectElement keystrokes on Chromium win
https://bugs.webkit.org/show_bug.cgi?id=112460
Reviewed by Kent Tamura.
Compile in the windows-specific variant of
HTMLSelectElement::platformHandleKeydownEvent
on Chromium win, in addition to PLATFORM(WIN).
- WebCore.gypi:
Add html/HTMLSelectElementWin.cpp.
- html/HTMLSelectElement.cpp:
Don't compile generic platformHandleKeydownEvent on
Chromium win.
- html/HTMLSelectElementWin.cpp:
Only compile platformHandleKeydownEvent on Windows.
Fix compile error in assertion.
(WebCore):
- 4:10 PM Changeset in webkit [146144] by
-
- 2 edits3 adds in trunk/Source/JavaScriptCore
[WinCairo] Get build working under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112604
Reviewed by Tim Horton.
- JavaScriptCore.vcxproj/testapi/testapi.vcxproj: Use CFLite-specific
build target (standard version links against CoreFoundation.lib
instead of CFLite.lib).
- JavaScriptCore.vcxproj/testapi/testapiCommonCFLite.props: Added.
- JavaScriptCore.vcxproj/testapi/testapiDebugCFLite.props: Added.
- JavaScriptCore.vcxproj/testapi/testapiReleaseCFLite.props: Added.
- 4:08 PM Changeset in webkit [146143] by
-
- 3 edits in trunk/Source/WebKit2
[WK2][Mac] Don't consider empty window frames cacheable.
<http://webkit.org/b/112631>
<rdar://problem/13384894>
Reviewed by Anders Carlsson.
If the UI client overrides getWindowFrame() and returns an empty rect, send that over
to the web process and mark it as uncached. This forces the next ChromeClient::windowRect()
call to synchronously retrieve the window frame from the other side.
Fixes an issue with the Mac Web Inspector which uses empty rects to signify that there is
no known window frame yet. In this case, we should not be falling back to the native frame.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::windowAndViewFramesChanged):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowAndViewFramesChanged):
- 4:05 PM Changeset in webkit [146142] by
-
- 2 edits in trunk/LayoutTests
fast/loader/document-with-fragment-url-4.html sometimes asserts
https://bugs.webkit.org/show_bug.cgi?id=97124
- platform/mac-wk2/TestExpectations:
- 3:54 PM Changeset in webkit [146141] by
-
- 6 edits1 copy3 adds in trunk
CSP 1.1: Schemeless source expressions match HTTPS resources on HTTP sites.
https://bugs.webkit.org/show_bug.cgi?id=112573
Reviewed by Adam Barth.
Source/WebCore:
Currently, the directive 'script-src example.com' would match only
scripts served from 'http://example.com' when served on an HTTP site,
and only scripts served from 'https://example.com' when served on an
HTTPS site. This patch changes the matching behavior for ports that
have enabled CSP_NEXT in order to encourage use of HTTPS resources by
allow schemeless source expressions to match HTTPS origins when on
HTTP sites.
Thread: http://lists.w3.org/Archives/Public/public-webappsec/2013Mar/0013.html
Spec change: https://dvcs.w3.org/hg/content-security-policy/rev/a7dc8820946e
Test: http/tests/security/contentSecurityPolicy/source-list-parsing-10.html
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPSource::CSPSource):
Pass the current policy into CSPSource so that we can check the
protected resource's scheme inside schemeMatches, rather than
overwriting the source expression's scheme before creating the
CSPSource.
(WebCore::CSPSource::schemeMatches):
If CSP_NEXT is enabled, ensure that HTTPS resources match the
HTTP scheme when loaded on HTTP pages with schemaless source
expressions.
(WebCore::CSPSource::portMatches):
Check the port against the URL's scheme: if m_scheme isn't
empty, this will match it. If m_scheme is empty, we can't
do a strict match against it, nor can we do a strict match
against the protected resource's port. Checking the URL's
port against the default port for its scheme solves this
problem elegantly.
(WebCore::CSPSourceList::parse):
(WebCore::CSPSourceList::addSourceSelf):
Pass in the policy when creating a CSPSource object.
LayoutTests:
- http/tests/security/contentSecurityPolicy/resources/multiple-iframe-test.js:
Add support for full URLs in this type of test, which enables loading
scripts from hosts other than the current page's.
- http/tests/security/contentSecurityPolicy/source-list-parsing-01-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-01.html:
Drops a test from the first parsing group, as it's better grouped
with the new test added below.
- http/tests/security/contentSecurityPolicy/source-list-parsing-10-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/source-list-parsing-10.html: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-01.html.
Adds a new test that checks HTTPS scripts loaded against a
schemeless source expression.
- platform/chromium/http/tests/security/contentSecurityPolicy/source-list-parsing-10-expected.txt: Added.
- platform/gtk/http/tests/security/contentSecurityPolicy/source-list-parsing-10-expected.txt: Added.
This patch has different behavior for ports that enable CSP_NEXT,
currently Chromium and GTK.
- 3:51 PM Changeset in webkit [146140] by
-
- 5 edits in trunk/Source/WebCore
Text track cues do not update sizes when entering or exiting full screen.
https://bugs.webkit.org/show_bug.cgi?id=112472
Reviewed by Eric Carlson.
The style properties of the TextCueBoxes were not being updated after the size of the video bounds changed.
Because getDisplayTree() will not do it when the cue itself has not changed, explicitly call videoSizeDidChange()
from updateSizes().
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateSizes): call videoSizeDidChange() on every active cue.
- html/track/TextTrackCue.h:
(WebCore::TextTrackCue::hasDisplayTree): returns whether or not the cue has created a display tree without side effects.
(WebCore::TextTrackCue::videoSizeDidChange): Overridable empty method.
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGeneric::videoSizeDidChange): Update the CSS height attribute of the cue box using the new video size.
- html/track/TextTrackCueGeneric.h:
- 3:49 PM Changeset in webkit [146139] by
-
- 7 edits in trunk/Tools
Implement icon change notification dump for Chromium's test shell.
https://bugs.webkit.org/show_bug.cgi?id=112614
This was previously implemented for some other platforms in r58111
and r116547.
In r122806, fast/dom/icon-url-property.html stopped using it, but
it is useful for tests, so I plan to re-add it to that test again.
Reviewed by Jochen Eisinger.
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
icon change notifications from WebKit may be logged in test output.
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
(WebTestRunner::TestRunner::reset): Clear the new dump variable.
(WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
(WebTestRunner):
(WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::didChangeIcon):
(WebTestRunner):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didChangeIcon): Add the output about changing the icon.
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 3:48 PM Changeset in webkit [146138] by
-
- 3 edits2 copies in branches/chromium/1410
Merge 145481
BUG=183741
Review URL: https://codereview.chromium.org/12886025
- 3:47 PM Changeset in webkit [146137] by
-
- 4 edits24 adds in trunk
CSP 1.1: Add 'effective-directive' to violation reports.
https://bugs.webkit.org/show_bug.cgi?id=112568
Reviewed by Adam Barth.
Source/WebCore:
https://dvcs.w3.org/hg/content-security-policy/rev/bc2bb0e5072a
introduced an 'effective-directive' field on CSP violation reports,
which allows developers to distinguish between resource types when
'default-src' is the violated directive.
This patch implements the new field behind the CSP_NEXT flag.
Test: http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive.html
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
(WebCore::CSPDirectiveList::reportViolation):
These methods now accept an additional parameter to pipe the
effective directive from the initial callsite down into
ContentSecurityPolicy::reportViolation.
(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
(WebCore::CSPDirectiveList::checkNonceAndReportViolation):
(WebCore::CSPDirectiveList::checkMediaTypeAndReportViolation):
(WebCore::CSPDirectiveList::checkInlineAndReportViolation):
(WebCore::CSPDirectiveList::allowScriptFromSource):
(WebCore::CSPDirectiveList::allowObjectFromSource):
(WebCore::CSPDirectiveList::allowChildFrameFromSource):
(WebCore::CSPDirectiveList::allowImageFromSource):
(WebCore::CSPDirectiveList::allowStyleFromSource):
(WebCore::CSPDirectiveList::allowFontFromSource):
(WebCore::CSPDirectiveList::allowMediaFromSource):
(WebCore::CSPDirectiveList::allowConnectToSource):
(WebCore::CSPDirectiveList::allowFormAction):
These methods now pass the effective directive name down
into checkSourceAndReportViolation or reportViolation.
(WebCore::ContentSecurityPolicy::reportViolation):
- page/ContentSecurityPolicy.h:
This method now accepts a new parameter that carries
the effective directive name. If CSP_NEXT is enabled,
the field is added to the violation report before it's
sent out into the world.
LayoutTests:
- http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive.html: Added.
A new test that ensures that 'default-src' doesn't show up in the
effective directive field, even if it's the directive that was
actually violated.
- platform/chromium/http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt: Added.
- platform/chromium/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt: Added.
- platform/chromium/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt: Added.
- platform/chromium/http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt: Added.
- platform/chromium/http/tests/security/contentSecurityPolicy/report-only-expected.txt: Added.
- platform/chromium/http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt: Added.
- platform/chromium/http/tests/security/contentSecurityPolicy/report-only-report-uri-missing-expected.txt: Added.
- platform/chromium/http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Added.
- platform/chromium/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Added.
- platform/chromium/http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt: Added.
- platform/chromium/http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt: Added.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt: Added.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt: Added.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt: Added.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt: Added.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-only-expected.txt: Added.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt: Added.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-only-report-uri-missing-expected.txt: Added.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Added.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Added.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt: Added.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt: Added.
This patch changes the output of violation reports for ports that
have enabled CSP_NEXT. At the moment, I think that's Chromium and
GTK only.
- 3:43 PM Changeset in webkit [146136] by
-
- 16 edits in branches/chromium/1410/Source
Merge 145453
BUG=183741
Review URL: https://codereview.chromium.org/12918021
- 3:43 PM Changeset in webkit [146135] by
-
- 6 edits in trunk/Source
Source/Platform: [chromium] Remove code that relies on boundsContainsPageScale().
https://bugs.webkit.org/show_bug.cgi?id=112465
The boundsContainsPageScale() API is going away, remove code that
depends on it.
Reviewed by James Robinson.
- chromium/public/WebContentLayer.h:
(WebContentLayer):
Source/WebCore: [chromium] Remove NCCH code that relies on boundsContainsPageScale().
https://bugs.webkit.org/show_bug.cgi?id=112465
Reviewed by James Robinson.
The boundsContainsPageScale() API is going away, remove code that
depends on it. Uses existing tests as no behaviour change.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setAppliesPageScale):
(WebCore::GraphicsLayerChromium::appliesPageScale):
Source/WebKit/chromium: [chromium] Remove NCCH code that relies on boundsContainsPageScale().
https://bugs.webkit.org/show_bug.cgi?id=112465
Reviewed by James Robinson.
The boundContainsPageScale API is going away, remove code that relies
on it.
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setViewport):
- 3:36 PM Changeset in webkit [146134] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Suppressed flaky test.
https://bugs.webkit.org/show_bug.cgi?id=112629
- platform/chromium/TestExpectations:
- 3:33 PM Changeset in webkit [146133] by
-
- 2 edits in trunk/LayoutTests
Another flakey iframe flattening test.
- platform/mac/TestExpectations:
- 3:31 PM Changeset in webkit [146132] by
-
- 11 edits in trunk/Source
IndexedDB: Protect against key prefix overflows
https://bugs.webkit.org/show_bug.cgi?id=111138
Reviewed by Tony Chang.
Source/WebCore:
This reworks the boundary checking for all databaseId,
objectStoreId, and indexId, including negative and
zero-based ids. All entrypoints into IDBLevelDBCoding
are protected with explicit checks and all internal
uses of KeyPrefix are protected with ASSERTs in the
various constructors.
Tests: WebKit unit tests IDBBackingStoreTest.cpp in WebKit/chromium
- Modules/indexeddb/IDBBackingStore.h: Make all public methods boolean-based for errors.
- Modules/indexeddb/IDBLevelDBCoding.h: Add methods for checking databaseId, objectStoreId, and indexId.
Source/WebKit/chromium:
Add tests for invalid indexIds in basic get/put operations.
- 3:24 PM Changeset in webkit [146131] by
-
- 4 edits in trunk/Source
AppleWin VS2010 Debug configuration build fix..
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj:
- 3:20 PM Changeset in webkit [146130] by
-
- 4 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=112627
MessagePort::disentangle() takes an ExceptionCode argument without any need
Reviewed by Geoffrey Garen.
MessagePort::disentangle() is called in two places. One has ASSERT_NO_EXCEPTION,
and another fails to check the exception, but clearly cannot get one.
This function is also not exposed to bindings.
- dom/MessagePort.cpp:
(WebCore::MessagePort::disentangle):
(WebCore::MessagePort::disentanglePorts):
- dom/MessagePort.h:
- workers/SharedWorker.cpp:
(WebCore::SharedWorker::create):
Also removed some unhelpful comments.
- 3:07 PM Changeset in webkit [146129] by
-
- 13 edits3 adds in trunk
Variant of non-primary fell-back SVGFont causes crash.
https://bugs.webkit.org/show_bug.cgi?id=112367
Reviewed by Stephen Chenney.
Source/WebCore:
Don't go to PlatformFontData path for SimpleFontData::createScaledFontData()
for SVG fonts.
Test: svg/css/font-face-variant-crash.html
- platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::~SimpleFontData):
(WebCore::SimpleFontData::createScaledFontData): Don't go to PlatformFontData path for SVG fonts.
(WebCore):
- platform/graphics/SimpleFontData.h:
(SimpleFontData): Added createScaledFontData and renamed the original createScaledFontData to platformCreateScaledFontData.
BTW, Removed unreferenced commonInit.
- platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Renamed from createScaledFontData.
- platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
- platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
- platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
- platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
- platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
- platform/graphics/wince/SimpleFontDataWinCE.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
- platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
LayoutTests:
- resources/SpaceOnly.otf: Added. A font containing only the space glyph for testing font fallback.
- svg/css/font-face-variant-crash-expected.txt: Added.
- svg/css/font-face-variant-crash.html: Added.
- 3:02 PM Changeset in webkit [146128] by
-
- 4 edits3 adds in trunk
Determine text direction for rendering a TextTrackCue
https://bugs.webkit.org/show_bug.cgi?id=79749
Reviewed by Levi Weintraub.
Source/WebCore:
The rendering rules for WebVTT cues are slightly different
depending on the directionality determined from the characters
of the cue text. This patch implements the preliminary step
to be able to take directionality into account.
It iterates through the cue characters and setting the CSS
directionality to the one of the first strong directional character.
Test: media/track/track-cue-rendering-rtl.html
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCueBox::applyCSSProperties): Applies the determined
direction.
(WebCore::TextTrackCue::TextTrackCue): Sets the default value for the
display direction.
(WebCore::isCueParagraphSeparator): Tests for explicit unicode characters
that are paragraph separators.
(WebCore):
(WebCore::TextTrackCue::determineTextDirection): Determined the direction
by the first strong directional character found.
(WebCore::TextTrackCue::calculateDisplayParameters): Updated.
(WebCore::TextTrackCue::getCSSWritingDirection): Return the determined CSS
writing direction.
- html/track/TextTrackCue.h:
(TextTrackCue):
LayoutTests:
- media/track/captions-webvtt/captions-rtl.vtt: Added.
- media/track/track-cue-rendering-rtl-expected.txt: Added.
- media/track/track-cue-rendering-rtl.html: Added.
- 2:43 PM Changeset in webkit [146127] by
-
- 3 edits2 copies in trunk/Tools
Cleanup: Move js for treemap and aggregate_results into own js files.
https://bugs.webkit.org/show_bug.cgi?id=112618
Reviewed by Dirk Pranke.
No functional changes, just moving the code into separate js file
rather than inlined in the html, so we can test it, make it more
modular, etc. Other dashboard types are already done this way.
- TestResultServer/static-dashboards/aggregate_results.html:
- TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
(generatePage):
(handleValidHashParameter):
(htmlForBuilder):
(rawValuesHTML):
(chartHTML):
(filteredValues):
(chart):
(htmlForRevisionRows):
(wrapHTMLInTable):
(htmlForSummaryTable):
(valuesPerExpectation):
(htmlForTestType):
(htmlForTableRow):
(extendedEncode):
- TestResultServer/static-dashboards/treemap.html:
- TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
(humanReadableTime):
(convertToWebTreemapFormat):
(reverseSortByAverage):
(generatePage):
(focusPath):
(.switch.return):
(handleQueryParameterChange):
(extractName):
(fullName):
(handleFocus.):
(handleFocus):
- 2:35 PM Changeset in webkit [146126] by
-
- 3 edits12 deletes in trunk/LayoutTests
Unreviewed gardening. Marked flaky tests, removed obsolete
expectations, and fixed flaky test fast/innerHTML/innerHTML-iframe.html .
https://bugs.webkit.org/show_bug.cgi?id=97816
https://bugs.webkit.org/show_bug.cgi?id=112306
https://bugs.webkit.org/show_bug.cgi?id=112621
- fast/innerHTML/innerHTML-iframe.html:
- platform/chromium-android/platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
- platform/chromium-android/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
- platform/chromium-android/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
- platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
- platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
- platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
- platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
- platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
- platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
- platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
- platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
- platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
- platform/chromium/TestExpectations:
- 2:30 PM Changeset in webkit [146125] by
-
- 2 edits in trunk/Tools
[webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
https://bugs.webkit.org/show_bug.cgi?id=112622
Reviewed by Dirk Pranke.
- Scripts/webkitpy/tool/steps/haslanded_unittest.py:
(HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
- 2:28 PM Changeset in webkit [146124] by
-
- 4 edits in trunk/Tools
[NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=112619
Reviewed by Dirk Pranke.
When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
directory and then fall back to the generic LayoutTests/platform/gtk directory.
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
Port._webkit_baseline_path method.
- Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
(GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
(GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
that are expected based on the builder name.
- 2:28 PM Changeset in webkit [146123] by
-
- 10 edits3 adds in trunk/Source/JavaScriptCore
[WinCairo] Get build working under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112604
Reviewed by Tim Horton.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Add build targets for
Debug_WinCairo and Release_WinCairo using CFLite.
- JavaScriptCore.vcxproj/JavaScriptCoreCFLite.props: Added.
- JavaScriptCore.vcxproj/JavaScriptCoreDebugCFLite.props: Added.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj:
Add Debug_WinCairo and Release_WinCairo build targets to
make sure headers are copied to proper build folder.
- JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj: Ditto.
- JavaScriptCore.vcxproj/JavaScriptCoreReleaseCFLite.props: Added.
- JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj:
Add Debug_WinCairo and Release_WinCairo build targets to
make sure headers are copied to proper build folder.
- JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj:
Ditto.
- JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj:
Ditto.
- JavaScriptCore.vcxproj/jsc/jsc.vcxproj: Ditto.
- JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj: Ditto.
- JavaScriptCore.vcxproj/testapi/testapi.vcxproj: Ditto.
- 2:16 PM Changeset in webkit [146122] by
-
- 2 edits in trunk/LayoutTests
Skip some tests on Windows.
- platform/win/TestExpectations:
- 2:09 PM Changeset in webkit [146121] by
-
- 3 edits in trunk/Source/WTF
[WinCairo] Get build working under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112604
Reviewed by Tim Horton.
- WTF.vcxproj/WTF.vcxproj: Add Debug_WinCairo and Release_WinCairo
targets so headers get copied to appropriate build folder.
- WTF.vcxproj/WTFGenerated.vcxproj: Ditto.
- 2:08 PM Changeset in webkit [146120] by
-
- 2 edits1 add in trunk/Source/WebKit
[WinCairo] Build WinCairo port under VS2010
https://bugs.webkit.org/show_bug.cgi?id=112604
Reviewed by Tim Horton.
- WebKit.vcxproj/WebKit.sln: Add Debug_WinCairo and Release_WinCairo
build targets. No other changes in this patch.
- WebKit.vcxproj/FeatureDefinesCairo.props: Add parallel property
sheet for WinCairo version of build.
- 1:57 PM Changeset in webkit [146119] by
-
- 2 edits in trunk/LayoutTests
ASSERTION FAILED: !NoEventDispatchAssertion::isEventDispatchForbidden()
https://bugs.webkit.org/show_bug.cgi?id=112620
- platform/mac/TestExpectations:
- 1:57 PM Changeset in webkit [146118] by
-
- 2 edits in trunk/LayoutTests
http/tests/navigation/navigation-redirect-schedule-crash.html asserts sometimes
https://bugs.webkit.org/show_bug.cgi?id=112617
- platform/mac/TestExpectations:
- 1:56 PM Changeset in webkit [146117] by
-
- 3 edits2 adds in trunk
Fix GridTrackSize::operator==
https://bugs.webkit.org/show_bug.cgi?id=112501
Reviewed by Eric Seidel.
Source/WebCore:
There was a missing "other." in the function.
This was found by experimenting with a potential new Clang warning.
Test: fast/css-grid-layout/grid-dynamic-updates-relayout.html
- rendering/style/GridTrackSize.h:
(WebCore::GridTrackSize::operator==):
LayoutTests:
Add a test to check that style changes cause relayout correctly.
- fast/css-grid-layout/grid-dynamic-updates-relayout-expected.txt: Added.
- fast/css-grid-layout/grid-dynamic-updates-relayout.html: Added.
- 1:48 PM Changeset in webkit [146116] by
-
- 3 edits in trunk
Inspector: [Chromium] http/tests/inspector/indexeddb/database-data.html ASSERT on Win7 following r133855
https://bugs.webkit.org/show_bug.cgi?id=101618
Deactivate transactions created by the inspector, before
they are reactivated by IndexedDB. This puts transactions
in an identical state as when they are created by scripts.
Reviewed by Vsevolod Vlasov.
Test: http/tests/inspector/indexeddb/database-data.html
- inspector/InspectorIndexedDBAgent.cpp: Make transactions inactive upon leaving the inspector code.
- 1:45 PM Changeset in webkit [146115] by
-
- 5 edits12 adds in trunk
Allow blocking of application cache in third-party contexts
https://bugs.webkit.org/show_bug.cgi?id=112288
Reviewed by Adam Barth.
Source/WebCore:
Return early if we can't access the application cache due to security
restrictions.
Tests: http/tests/security/cross-origin-appcache-allowed.html
http/tests/security/cross-origin-appcache.html
http/tests/security/same-origin-appcache-blocked.html
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::selectCache):
(WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
- page/SecurityOrigin.h:
(WebCore::SecurityOrigin::canAccessApplicationCache):
LayoutTests:
- http/tests/security/cross-origin-appcache-allowed-expected.txt: Added.
- http/tests/security/cross-origin-appcache-allowed.html: Added.
- http/tests/security/cross-origin-appcache-expected.txt: Added.
- http/tests/security/cross-origin-appcache.html: Added.
- http/tests/security/resources/cross-origin-iframe-for-appcache-allowed.html: Added.
- http/tests/security/resources/cross-origin-iframe-for-appcache.html: Added.
- http/tests/security/resources/manifest-for-appcache-allowed.manifest: Added.
- http/tests/security/resources/manifest-for-appcache-blocked.manifest: Added.
- http/tests/security/resources/manifest-for-appcache.manifest: Added.
- http/tests/security/resources/same-origin-iframe-for-appcache-blocked.html: Added.
- http/tests/security/same-origin-appcache-blocked-expected.txt: Added.
- http/tests/security/same-origin-appcache-blocked.html: Added.
- platform/chromium/TestExpectations:
- 1:37 PM Changeset in webkit [146114] by
-
- 2 edits in trunk/LayoutTests
plugins/plugin-clip-subframe.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=112616
- platform/mac/TestExpectations:
- 1:28 PM Changeset in webkit [146113] by
-
- 4 edits2 copies in branches/chromium/1410
Merge 142928 "Crash when selecting a HarfBuzz text run with SVG ..."
Crash when selecting a HarfBuzz text run with SVG fonts included
https://bugs.webkit.org/show_bug.cgi?id=109833
Reviewed by Tony Chang.
Source/WebCore:
There is an assert in SimpleFontData::applyTransforms that should not
be there, as the code is valid for SVG fonts. If we get past this,
then the HarfBuzz text run shaping code assumes that font data has a
SkTypeface member, and SVG fonts do not. So we crash there too.
For now, we fix the crashes. This still leaves incorrect selection
rectangles in this situation, on all platforms, tracked in
https://bugs.webkit.org/show_bug.cgi?id=108133
Test: svg/css/font-face-crash.html
- platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::applyTransforms): Remove ASSERT_NOT_REACHED as the code can legally be reached for SVG fonts.
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Check for SVG fonts in the text run, and abort if we find them.
LayoutTests:
Only known to crash on Chromium Linux (without the patch), but other platforms may be affected.
- svg/css/font-face-crash-expected.txt: Added.
- svg/css/font-face-crash.html: Added.
TBR=schenney@chromium.org
Review URL: https://codereview.chromium.org/12919016
- 1:27 PM Changeset in webkit [146112] by
-
- 5 edits in trunk
Web Inspector: Script should know nothing about disabled source mappings.
https://bugs.webkit.org/show_bug.cgi?id=112580
Reviewed by Pavel Feldman.
Source/WebCore:
ResourceScriptMapping handles diverged uiSourceCodes internally now.
Tested in inspector/debugger/live-edit-breakpoints.html already.
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._hasMergedToVM):
(WebInspector.ResourceScriptMapping.prototype._hasDivergedFromVM):
- inspector/front-end/Script.js:
(WebInspector.Script.prototype.rawLocationToUILocation):
LayoutTests:
- inspector/debugger/breakpoint-manager.html:
- 1:26 PM Changeset in webkit [146111] by
-
- 17 edits1 copy in trunk
[Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
https://bugs.webkit.org/show_bug.cgi?id=112571
Reviewed by Adam Barth.
Source/Platform:
New top-level enum (not tied to WebFileSystem class) will allow
easier refactoring of filesystem methods within the Platform/
directory. (All changes are behind an #ifdef so we can sync
required changes in embedders.)
- chromium/public/WebFileSystemType.h: new file
(WebKit):
- Platform.gypi:
- chromium/public/WebFileSystem.h:
- chromium/public/WebFileSystemType.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.
(WebKit):
Source/WebKit/chromium:
Update function declarations for new WebFileSystemType enum. (All
changes are behind an #ifdef so we can sync required changes in embedders.)
- public/WebCommonWorkerClient.h:
(WebCommonWorkerClient):
(WebKit::WebCommonWorkerClient::openFileSystem):
- public/WebFrame.h:
(WebFrame):
- public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::openFileSystem):
(WebKit::WebFrameClient::deleteFileSystem):
- src/LocalFileSystemChromium.cpp:
(WebCore):
(WebCore::openFileSystemHelper):
(WebCore::LocalFileSystem::deleteFileSystem):
- src/WebFrameImpl.cpp:
(WebKit):
(WebKit::WebFrameImpl::createFileSystem):
(WebKit::WebFrameImpl::createSerializableFileSystem):
(WebKit::WebFrameImpl::createFileEntry):
- src/WebFrameImpl.h:
(WebFrameImpl):
- src/WebWorkerClientImpl.cpp:
(WebKit):
(WebKit::WebWorkerClientImpl::openFileSystem):
- src/WebWorkerClientImpl.h:
- src/WorkerFileSystemCallbacksBridge.cpp:
(WebKit):
(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
- src/WorkerFileSystemCallbacksBridge.h:
(WorkerFileSystemCallbacksBridge):
Tools:
Update function declarations for new WebFileSystemType enum. (All
changes are behind an #ifdef so we can sync required changes in embedders.)
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::openFileSystem):
(WebViewHost::deleteFileSystem):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 1:25 PM Changeset in webkit [146110] by
-
- 3 edits in trunk/Source/WebCore
Update MessagePort terminology to match HTML5
https://bugs.webkit.org/show_bug.cgi?id=112611
Reviewed by Anders Carlsson.
Transferable objects are "neutered" when transfered. Cloning is a different operation.
- dom/MessagePort.cpp:
(WebCore::MessagePort::disentanglePorts):
- dom/MessagePort.h:
(WebCore::MessagePort::isEntangled):
(WebCore::MessagePort::isNeutered):
- 1:23 PM Changeset in webkit [146109] by
-
- 5 edits in trunk/Source
AppleWin VS2010 build fix.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 1:23 PM Changeset in webkit [146108] by
-
- 2 edits in trunk/LayoutTests
Another asserting test.
- platform/mac/TestExpectations:
- 1:18 PM Changeset in webkit [146107] by
-
- 3 edits in trunk/LayoutTests
Mark a couple of asserty tests as such.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 12:56 PM Changeset in webkit [146106] by
-
- 3 edits1 copy in trunk/Tools
Cleanup: Move timeline_exporer js out of html file into js.
https://bugs.webkit.org/show_bug.cgi?id=112188
Reviewed by Dirk Pranke.
Moves the javascript out of the html file and into a new js file.
This follows the format of flakiness_dashboard.{html|js}.
Also moves code from dashboard_base that is used only by this one
dashboard, and makes it private to the dashboard.
- TestResultServer/static-dashboards/dashboard_base.js:
- TestResultServer/static-dashboards/timeline_explorer.html:
- TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
(generatePage):
(initCurrentBuilderTestResults):
(shouldShowWebKitRevisionsOnly):
(updateTimelineForBuilder.):
(updateTimelineForBuilder):
(selectBuild):
(updateBuildIndicator):
(.addRow):
(.addNumberRow):
(.inspectorNode.getElementsByTagName.0.onclick):
(.inspectorNode.getElementsByTagName.1.onclick):
(.inspectorNode.getElementsByTagName.2.onclick):
(updateBuildInspector):
(showResultsDelta):
(decompressResults.addFlakyDelta):
(decompressResults):
- 12:45 PM Changeset in webkit [146105] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Added expectation for failing test.
https://bugs.webkit.org/show_bug.cgi?id=112610
- platform/chromium/TestExpectations:
- 12:43 PM Changeset in webkit [146104] by
-
- 7 edits20 adds in trunk
[css3-text] Add rendering support for -webkit-text-underline-position
https://bugs.webkit.org/show_bug.cgi?id=102795
Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-03-18
Reviewed by Levi Weintraub.
Source/WebCore:
This patch implements rendering support for values [ auto | alphabetic | under ]
of CSS3 property text-underline-position. We don't fully match the specification
as we don't support [ left | right ] and this is left for another implementation
as the rendering will need to be added.
Tests: fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html
fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic.html
fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto.html
fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow.html
fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under.html
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeMaxLogicalTop): Added method to compute maximal logical top among all chidren of
this InlineTextBox.
- rendering/InlineFlowBox.h:
(InlineFlowBox):
- rendering/InlineTextBox.cpp:
(WebCore::computeUnderlineOffset): Added method to compute offset for text-underline-position property.
(WebCore::InlineTextBox::paintDecoration): Paint decoration at position calculated using computeUnderlineOffset().
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::alignBoxesInBlockDirection): Call method to compute maximal logical top among all
children of this RootInlineBox.
- rendering/RootInlineBox.h:
(RootInlineBox):
(WebCore::RootInlineBox::maxLogicalTop): Added getter for m_maxLogicalTop class member.
- rendering/style/RenderStyle.h: Added the usual getter / setter / initial methods for text-underline-position
property
LayoutTests:
Added text-underline-position tests for 'text-underline-position' CSS3
property, with 'webkit' prefix.
- fast/css3-text/css3-text-decoration/text-underline-position/style.css: Added.
- fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all-expected.txt: Added.
- fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html: Added.
- fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic-expected.txt: Added.
- fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic.html: Added.
- fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto-expected.txt: Added.
- fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto.html: Added.
- fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-expected.txt: Added.
- fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow-expected.txt: Added.
- fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow.html: Added.
- fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under.html: Added.
- platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all-expected.png: Added.
- platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic-expected.png: Added.
- platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto-expected.png: Added.
- platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-expected.png: Added.
- platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow-expected.png: Added.
- 12:32 PM Changeset in webkit [146103] by
-
- 2 edits in trunk/Source/WebCore
Convert old flexbox uses in html.css to new flexbox (non-<select>)
https://bugs.webkit.org/show_bug.cgi?id=110837
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-18
Reviewed by Ojan Vafai.
No new tests (No change in behaviour)
- css/html.css:
(input::-webkit-clear-button):
Missed this one in the original patch.
- 12:26 PM Changeset in webkit [146102] by
-
- 6 edits in trunk/Source/WebCore
AudioBasicProcessorNode need to check for deferred updating of output channels
https://bugs.webkit.org/show_bug.cgi?id=112544
There can in rare cases be a slight delay before the output
bus is updated to the new number of channels because of tryLocks() in the
context's updating system but the processor already updated to the new
number of channels, so need to check the channel number before processing.
Reviewed by Chris Rogers.
- Modules/webaudio/AudioBasicProcessorNode.cpp:
(WebCore::AudioBasicProcessorNode::process):
- Modules/webaudio/WaveShaperProcessor.cpp:
(WebCore::WaveShaperProcessor::process):
- platform/audio/AudioDSPKernelProcessor.cpp:
(WebCore::AudioDSPKernelProcessor::AudioDSPKernelProcessor):
- platform/audio/AudioDSPKernelProcessor.h:
(WebCore::AudioDSPKernelProcessor::numberOfChannels):
(AudioDSPKernelProcessor):
- platform/audio/AudioProcessor.h:
(WebCore::AudioProcessor::AudioProcessor):
(AudioProcessor):
- 12:20 PM Changeset in webkit [146101] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r145272.
http://trac.webkit.org/changeset/145272
https://bugs.webkit.org/show_bug.cgi?id=111884
Turns out the ASAN build is still broken; possibly there's
something still setting LD_LIBRARY_PATH, or possibly there's
something else wrong. In the meantime, we need it to work again.
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- 12:11 PM Changeset in webkit [146100] by
-
- 4 edits9 adds in trunk
Potentially unsafe register allocations in DFG code generation
https://bugs.webkit.org/show_bug.cgi?id=112477
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Moved allocation of temporary GPRs to be before any generated branches in the functions below.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
LayoutTests:
New tests added to verify proper operation of
SpeculativeJIT::compileObjectToObjectOrOtherEquality,
SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality
and SpeculativeJIT::compileObjectOrOtherLogicalNot.
- fast/js/dfg-compare-final-object-to-final-object-or-other-expected.txt: Added.
- fast/js/dfg-compare-final-object-to-final-object-or-other.html: Added.
- fast/js/dfg-logical-not-final-object-or-other-expected.txt: Added.
- fast/js/dfg-logical-not-final-object-or-other.html: Added.
- fast/js/dfg-peephole-compare-final-object-to-final-object-or-other-expected.txt: Added.
- fast/js/dfg-peephole-compare-final-object-to-final-object-or-other.html: Added.
- fast/js/script-tests/dfg-compare-final-object-to-final-object-or-other.js: Added.
- fast/js/script-tests/dfg-logical-not-final-object-or-other.js: Added.
- fast/js/script-tests/dfg-peephole-compare-final-object-to-final-object-or-other.js: Added.
- 12:05 PM Changeset in webkit [146099] by
-
- 7 edits2 copies in branches/chromium/1410
Merge 145954 "TextIterator emits LF for a br element inside an e..."
TextIterator emits LF for a br element inside an empty input element
https://bugs.webkit.org/show_bug.cgi?id=112275
Patch by Aurimas Liutikas <aurimas@chromium.org> on 2013-03-15
Reviewed by Ryosuke Niwa.
Source/WebCore:
Adding a check to avoid emiting LF for br elements inside a shadow tree
of an input element.
Test: editing/text-iterator/basic-iteration.html
editing/text-iterator/basic-iteration-shadowdom.html
- editing/TextIterator.cpp:
(WebCore::shouldEmitNewlineForNode):
(WebCore::TextIterator::handleNonTextNode):
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
(WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode):
(WebCore::SimplifiedBackwardsTextIterator::exitNode):
- editing/TextIterator.h:
(SimplifiedBackwardsTextIterator):
LayoutTests:
- editing/text-iterator/basic-iteration-expected.txt: Extended to add two more cases.
- editing/text-iterator/basic-iteration-shadowdom-expected.txt: Added.
- editing/text-iterator/basic-iteration-shadowdom.html: Added.
- editing/text-iterator/script-tests/basic-iteration.js: Extended to add two mroe cases.
- platform/mac/TestExpectations:
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12780019
- 12:04 PM Changeset in webkit [146098] by
-
- 3 edits2 adds in trunk
[CSS Grid Layout] Fix StyleGridData::operator==
https://bugs.webkit.org/show_bug.cgi?id=112574
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/css-grid-layout/grid-auto-flow-update.html
- rendering/style/StyleGridData.h:
(WebCore::StyleGridData::operator==):
Fixed a bad comparison that would make us ignore grid-auto-flow changes.
LayoutTests:
- fast/css-grid-layout/grid-auto-flow-update-expected.txt: Added.
- fast/css-grid-layout/grid-auto-flow-update.html: Added.
- 11:55 AM Changeset in webkit [146097] by
-
- 2 edits in trunk/Source/WebKit/win
Fix typo on Windows following r145849 that was causing DRT to crash 100% of the time.
- WebView.cpp:
(WebView::setSmartInsertDeleteEnabled):
(WebView::setSelectTrailingWhitespaceEnabled):
- 11:52 AM Changeset in webkit [146096] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Marked flaky tests.
https://bugs.webkit.org/show_bug.cgi?id=112598
https://bugs.webkit.org/show_bug.cgi?id=112601
https://bugs.webkit.org/show_bug.cgi?id=112603
- platform/chromium/TestExpectations:
- 11:41 AM Changeset in webkit [146095] by
-
- 2 edits in trunk/Source/WebKit2
Mac build fix after http://trac.webkit.org/changeset/146088
- NetworkProcess/mac/NetworkResourceLoaderMac.mm:
(WebKit::NetworkResourceLoader::platformDidReceiveResponse):
- 11:39 AM Changeset in webkit [146094] by
-
- 2 edits in trunk/Source/WebCore
[HTMLTemplateElement] parseError check in processTemplateEndTag should use hasTagName, not hasLocalName
https://bugs.webkit.org/show_bug.cgi?id=112591
Reviewed by Adam Barth.
No tests needed, change is unobservable.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processTemplateEndTag):
- 11:34 AM Changeset in webkit [146093] by
-
- 2 edits in trunk/Tools
delete-stale-build-files is too aggressive
https://bugs.webkit.org/show_bug.cgi?id=112595
Reviewed by Tim Horton.
It appears that whitelisting file extensions to keep is not a good idea.
Blacklist files to delete instead, and only delete .o files for now.
We can add more file extensions as needed.
- BuildSlaveSupport/delete-stale-build-files:
- 11:33 AM Changeset in webkit [146092] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Prevent text selection inside Colour and Date/Time input fields
https://bugs.webkit.org/show_bug.cgi?id=111733
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
Reviewed by Rob Buis.
Fix missing brace.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- 11:32 AM Changeset in webkit [146091] by
-
- 5 edits2 adds in trunk/Source/WebKit/chromium
[Chromium] Compositor is applying scroll offset using 'programmatic' API
https://bugs.webkit.org/show_bug.cgi?id=109712
Reviewed by James Robinson.
Ensure that the compositor uses non-programmatic APIs to scroll and
scale.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::updateMainFrameScrollPosition):
(WebKit):
(WebKit::WebViewImpl::applyScrollAndScale):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/WebFrameTest.cpp:
- tests/WebViewTest.cpp:
- tests/data/long_scroll.html: Added.
- tests/data/short_scroll.html: Added.
- 11:29 AM Changeset in webkit [146090] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Add Proximity Detector.
https://bugs.webkit.org/show_bug.cgi?id=112278
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
Reviewed by Rob Buis.
Fix variable names so they actually match the function
declarations.
Fix call to rectForPoint(), which was moved from HitTestResult to
HitTestLocation in r117091 and r126859.
- WebKitSupport/ProximityDetector.cpp:
(BlackBerry::WebKit::ProximityDetector::findBestPoint):
- 11:09 AM Changeset in webkit [146089] by
-
- 43 edits51 adds in trunk
DFG string conversions and allocations should be inlined
https://bugs.webkit.org/show_bug.cgi?id=112376
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
This turns new String(), String(), String.prototype.valueOf(), and
String.prototype.toString() into intrinsics. It gives the DFG the ability to handle
conversions from StringObject to JSString and vice-versa, and also gives it the
ability to handle cases where a variable may be either a StringObject or a JSString.
To do this, I added StringObject to value profiling (and removed the stale
distinction between Myarguments and Foreignarguments). I also cleaned up ToPrimitive
handling, using some of the new functionality but also taking advantage of the
existence of Identity(String:@a).
This is a 2% SunSpider speed-up. Also there are some speed-ups on V8v7 and Kraken.
On microbenchmarks that stress new String() this is a 14x speed-up.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::hasExitSite):
(JSC):
- bytecode/DFGExitProfile.cpp:
(JSC::DFG::ExitProfile::hasExitSite):
(DFG):
- bytecode/DFGExitProfile.h:
(ExitProfile):
(JSC::DFG::ExitProfile::hasExitSite):
- bytecode/ExitKind.cpp:
(JSC::exitKindToString):
- bytecode/ExitKind.h:
- bytecode/SpeculatedType.cpp:
(JSC::dumpSpeculation):
(JSC::speculationToAbbreviatedString):
(JSC::speculationFromClassInfo):
- bytecode/SpeculatedType.h:
(JSC):
(JSC::isStringObjectSpeculation):
(JSC::isStringOrStringObjectSpeculation):
- create_hash_table:
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGAbstractState.h:
(JSC::DFG::AbstractState::filterEdgeByUse):
- dfg/DFGByteCodeParser.cpp:
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::emitArgumentPhantoms):
(DFG):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::putStructureStoreElimination):
- dfg/DFGEdge.h:
(JSC::DFG::Edge::shift):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):
(FixupPhase):
(JSC::DFG::FixupPhase::canOptimizeStringObjectAccess):
(JSC::DFG::FixupPhase::observeUseKindOnNode):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::hasGlobalExitSite):
(Graph):
(JSC::DFG::Graph::hasExitSite):
(JSC::DFG::Graph::clobbersWorld):
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToToString):
(Node):
(JSC::DFG::Node::hasStructure):
(JSC::DFG::Node::shouldSpeculateStringObject):
(JSC::DFG::Node::shouldSpeculateStringOrStringObject):
- dfg/DFGNodeType.h:
(DFG):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileToStringOnCell):
(DFG):
(JSC::DFG::SpeculativeJIT::compileNewStringObject):
(JSC::DFG::SpeculativeJIT::speculateObject):
(JSC::DFG::SpeculativeJIT::speculateObjectOrOther):
(JSC::DFG::SpeculativeJIT::speculateString):
(JSC::DFG::SpeculativeJIT::speculateStringObject):
(JSC::DFG::SpeculativeJIT::speculateStringOrStringObject):
(JSC::DFG::SpeculativeJIT::speculate):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(DFG):
(JSC::DFG::SpeculativeJIT::speculateStringObjectForStructure):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGUseKind.cpp:
(WTF::printInternal):
- dfg/DFGUseKind.h:
(JSC::DFG::typeFilterFor):
- interpreter/CallFrame.h:
(JSC::ExecState::regExpPrototypeTable):
- runtime/CommonIdentifiers.h:
- runtime/Intrinsic.h:
- runtime/JSDestructibleObject.h:
(JSDestructibleObject):
(JSC::JSDestructibleObject::classInfoOffset):
- runtime/JSGlobalData.cpp:
(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
- runtime/JSGlobalData.h:
(JSGlobalData):
- runtime/JSObject.cpp:
- runtime/JSObject.h:
(JSC):
- runtime/JSWrapperObject.h:
(JSC::JSWrapperObject::allocationSize):
(JSWrapperObject):
(JSC::JSWrapperObject::internalValueOffset):
(JSC::JSWrapperObject::internalValueCellOffset):
- runtime/StringPrototype.cpp:
(JSC):
(JSC::StringPrototype::finishCreation):
(JSC::StringPrototype::create):
- runtime/StringPrototype.h:
(StringPrototype):
LayoutTests:
Reviewed by Geoffrey Garen.
- fast/js/dfg-to-string-bad-toString-expected.txt: Added.
- fast/js/dfg-to-string-bad-toString.html: Added.
- fast/js/dfg-to-string-bad-valueOf-expected.txt: Added.
- fast/js/dfg-to-string-bad-valueOf.html: Added.
- fast/js/dfg-to-string-int-expected.txt: Added.
- fast/js/dfg-to-string-int-or-string-expected.txt: Added.
- fast/js/dfg-to-string-int-or-string.html: Added.
- fast/js/dfg-to-string-int.html: Added.
- fast/js/dfg-to-string-side-effect-clobbers-toString-expected.txt: Added.
- fast/js/dfg-to-string-side-effect-clobbers-toString.html: Added.
- fast/js/dfg-to-string-side-effect-expected.txt: Added.
- fast/js/dfg-to-string-side-effect.html: Added.
- fast/js/dfg-to-string-toString-becomes-bad-expected.txt: Added.
- fast/js/dfg-to-string-toString-becomes-bad-with-dictionary-string-prototype-expected.txt: Added.
- fast/js/dfg-to-string-toString-becomes-bad-with-dictionary-string-prototype.html: Added.
- fast/js/dfg-to-string-toString-becomes-bad.html: Added.
- fast/js/dfg-to-string-toString-in-string-expected.txt: Added.
- fast/js/dfg-to-string-toString-in-string.html: Added.
- fast/js/dfg-to-string-valueOf-becomes-bad-expected.txt: Added.
- fast/js/dfg-to-string-valueOf-becomes-bad.html: Added.
- fast/js/dfg-to-string-valueOf-in-string-expected.txt: Added.
- fast/js/dfg-to-string-valueOf-in-string.html: Added.
- fast/js/jsc-test-list:
- fast/js/regress/script-tests/string-concat-object.js: Added.
(foo):
- fast/js/regress/script-tests/string-concat-pair-object.js: Added.
(foo):
- fast/js/regress/script-tests/string-concat-pair-simple.js: Added.
(foo):
- fast/js/regress/script-tests/string-concat-simple.js: Added.
(foo):
- fast/js/regress/script-tests/string-cons-repeat.js: Added.
(foo):
- fast/js/regress/script-tests/string-cons-tower.js: Added.
(foo):
- fast/js/regress/string-concat-object-expected.txt: Added.
- fast/js/regress/string-concat-object.html: Added.
- fast/js/regress/string-concat-pair-object-expected.txt: Added.
- fast/js/regress/string-concat-pair-object.html: Added.
- fast/js/regress/string-concat-pair-simple-expected.txt: Added.
- fast/js/regress/string-concat-pair-simple.html: Added.
- fast/js/regress/string-concat-simple-expected.txt: Added.
- fast/js/regress/string-concat-simple.html: Added.
- fast/js/regress/string-cons-repeat-expected.txt: Added.
- fast/js/regress/string-cons-repeat.html: Added.
- fast/js/regress/string-cons-tower-expected.txt: Added.
- fast/js/regress/string-cons-tower.html: Added.
- fast/js/script-tests/dfg-to-string-bad-toString.js: Added.
(String.prototype.toString):
(foo):
- fast/js/script-tests/dfg-to-string-bad-valueOf.js: Added.
(String.prototype.valueOf):
(foo):
- fast/js/script-tests/dfg-to-string-int-or-string.js: Added.
(foo):
- fast/js/script-tests/dfg-to-string-int.js: Added.
(foo):
- fast/js/script-tests/dfg-to-string-side-effect-clobbers-toString.js: Added.
(foo):
- fast/js/script-tests/dfg-to-string-side-effect.js: Added.
(foo):
- fast/js/script-tests/dfg-to-string-toString-becomes-bad-with-dictionary-string-prototype.js: Added.
(foo):
(.String.prototype.toString):
- fast/js/script-tests/dfg-to-string-toString-becomes-bad.js: Added.
(foo):
(.String.prototype.toString):
- fast/js/script-tests/dfg-to-string-toString-in-string.js: Added.
(foo):
(.argument.toString):
- fast/js/script-tests/dfg-to-string-valueOf-becomes-bad.js: Added.
(foo):
(.String.prototype.valueOf):
- fast/js/script-tests/dfg-to-string-valueOf-in-string.js: Added.
(foo):
(.argument.valueOf):
- 11:05 AM Changeset in webkit [146088] by
-
- 13 edits1 add in trunk/Source
NetworkProcess should send vm_copied, mmap'ed memory to WebProcesses when a
resource is already in the disk cache.
<rdar://problem/13414153> and https://bugs.webkit.org/show_bug.cgi?id=112387
Reviewed by Geoff Garen.
Source/WebCore:
No new tests (No change in behavior).
- WebCore.exp.in:
Add a CFURLRequestRef accessor even in the mac NSURL-based loader:
- platform/network/cf/ResourceRequest.h:
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::cfURLRequest):
Source/WebKit2:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::sendAbortingOnFailure):
(WebKit::NetworkResourceLoader::didReceiveResponse): After notifying about the response,
call platformDidReceiveResponse.
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/mac/NetworkResourceLoaderMac.mm: Added.
(WebKit::NetworkResourceLoader::platformDidReceiveResponse): Attempt to pull a filesystem
mmap'ed buffer from the CFNetwork cache and - if it exists - abort the traditional load
and send that to the WebProcess instead.
(WebKit::NetworkResourceLoader:: fileBackedResourceMinimumSize): For now, use the VM page size.
- NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcess): Set the threshold for what
should be backed by a file on disk instead of stored in the database.
Change SharedMemory to do a vm_copy if a previously existing buffer is being passed in:
- Platform/SharedMemory.h:
- Platform/mac/SharedMemoryMac.cpp:
(WebKit::SharedMemory::create):
(WebKit::SharedMemory::createWithVMCopy):
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::shareableResourceDeallocate):
(WebKit::createShareableResourceDeallocator):
(WebKit::WebResourceLoader::didReceiveResource): Create a special CFDataRef whose buffer is
backed by a ShareableResource to send to the ResourceLoader in one chunk.
- Shared/ShareableResource.h: Fix some comments.
- WebKit2.xcodeproj/project.pbxproj:
- 11:01 AM Changeset in webkit [146087] by
-
- 3 edits2 adds in trunk
Only add wordspacing when kerning to actual word ends
https://bugs.webkit.org/show_bug.cgi?id=112507
<rdar://problem/12945869>
Reviewed by Enrica Casucci.
Source/WebCore:
When measuring text, we currently include any word spacing in
the result (it's removed later). When kerning is active, we
were adding the word spacing to every wordMeasurement instance
whether or not it is a separate word. For example, a nested
<span> element would get a wordMeasurement, even though it
should not always get word spacing.
Test: fast/text/word-space-with-kerning-3.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::setLogicalWidthForTextRun): Test if the current character
referenced by the wordMeasurement is a space character, and add word
spacing only then.
LayoutTests:
- fast/text/word-space-with-kerning-3-expected.html: Added.
- fast/text/word-space-with-kerning-3.html: Added.
- 10:57 AM Changeset in webkit [146086] by
-
- 56 edits in trunk
[chromium] Default background color of listboxes should be white
https://bugs.webkit.org/show_bug.cgi?id=112480
Reviewed by Ojan Vafai.
Source/WebCore:
I think it was an accident that list boxes got the grey background color as a
side effect of trying to get the button styling. In the default GTK+ theme on
Ubuntu, list boxes get a white background. Win and OS X also use white as the
default color.
No new tests, covered by existing pixel tests.
- css/themeChromiumLinux.css:
Narrow the CSS rule that overrides the background color specified in html.css.
We only want to use the button color when a select is using button styling.
LayoutTests:
Update pixel results with list boxes.
- platform/chromium-linux/fast/css/text-transform-select-expected.png:
- platform/chromium-linux/fast/css/text-transform-select-expected.txt:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label05-expected.png:
- platform/chromium-linux/fast/forms/HTMLOptionElement_label05-expected.txt:
- platform/chromium-linux/fast/forms/disabled-select-change-index-expected.png:
- platform/chromium-linux/fast/forms/disabled-select-change-index-expected.txt:
- platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
- platform/chromium-linux/fast/forms/form-element-geometry-expected.txt:
- platform/chromium-linux/fast/forms/hidden-listbox-expected.txt:
- platform/chromium-linux/fast/forms/listbox-bidi-align-expected.png:
- platform/chromium-linux/fast/forms/listbox-bidi-align-expected.txt:
- platform/chromium-linux/fast/forms/listbox-clip-expected.png:
- platform/chromium-linux/fast/forms/listbox-clip-expected.txt:
- platform/chromium-linux/fast/forms/listbox-hit-test-zoomed-expected.png:
- platform/chromium-linux/fast/forms/listbox-hit-test-zoomed-expected.txt:
- platform/chromium-linux/fast/forms/listbox-scrollbar-incremental-load-expected.png:
- platform/chromium-linux/fast/forms/listbox-scrollbar-incremental-load-expected.txt:
- platform/chromium-linux/fast/forms/listbox-width-change-expected.png:
- platform/chromium-linux/fast/forms/listbox-width-change-expected.txt:
- platform/chromium-linux/fast/forms/option-strip-whitespace-expected.png:
- platform/chromium-linux/fast/forms/option-strip-whitespace-expected.txt:
- platform/chromium-linux/fast/forms/select-block-background-expected.png:
- platform/chromium-linux/fast/forms/select-block-background-expected.txt:
- platform/chromium-linux/fast/forms/select-change-listbox-size-expected.png:
- platform/chromium-linux/fast/forms/select-change-listbox-size-expected.txt:
- platform/chromium-linux/fast/forms/select-change-popup-to-listbox-expected.png:
- platform/chromium-linux/fast/forms/select-change-popup-to-listbox-expected.txt:
- platform/chromium-linux/fast/forms/select-initial-position-expected.png:
- platform/chromium-linux/fast/forms/select-initial-position-expected.txt:
- platform/chromium-linux/fast/forms/select-item-background-clip-expected.png:
- platform/chromium-linux/fast/forms/select-item-background-clip-expected.txt:
- platform/chromium-linux/fast/forms/select-list-box-with-height-expected.png:
- platform/chromium-linux/fast/forms/select-list-box-with-height-expected.txt:
- platform/chromium-linux/fast/forms/select-listbox-multiple-no-focusring-expected.png:
- platform/chromium-linux/fast/forms/select-listbox-multiple-no-focusring-expected.txt:
- platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png:
- platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt:
- platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.png:
- platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.txt:
- platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png:
- platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.txt:
- platform/chromium-linux/fast/repaint/select-option-background-color-expected.png:
- platform/chromium-linux/fast/repaint/select-option-background-color-expected.txt:
- platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
- platform/chromium-linux/fast/replaced/replaced-breaking-expected.txt:
- platform/chromium-linux/fast/text/drawBidiText-expected.png:
- platform/chromium-linux/fast/text/drawBidiText-expected.txt:
- platform/chromium-linux/fast/text/international/bidi-listbox-atsui-expected.png:
- platform/chromium-linux/fast/text/international/bidi-listbox-atsui-expected.txt:
- platform/chromium-linux/fast/text/international/bidi-listbox-expected.png:
- platform/chromium-linux/fast/text/international/bidi-listbox-expected.txt:
- platform/chromium-linux/fast/text/updateNewFont-expected.png:
- platform/chromium-linux/fast/text/updateNewFont-expected.txt:
- 10:53 AM Changeset in webkit [146085] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r146079.
http://trac.webkit.org/changeset/146079
https://bugs.webkit.org/show_bug.cgi?id=112594
many timeline tests failed. (Requested by loislo on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-18
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.setMode):
(WebInspector.TimelineOverviewPane.prototype._setFrameMode):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
(WebInspector.TimelineOverviewPane.prototype.zoomToFrame):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.TimelineOverviewPane.prototype.windowLeft):
(WebInspector.TimelineOverviewPane.prototype.windowRight):
(WebInspector.TimelineOverviewPane.prototype._updateWindow):
- 10:49 AM Changeset in webkit [146084] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] The <select> element on Android should also switch to new-flexbox
https://bugs.webkit.org/show_bug.cgi?id=112559
Reviewed by Ojan Vafai.
Following r145959, also update themeChromiumAndroid.css to use the new
flexible box CSS properties. Covered by existing tests.
- css/themeChromiumAndroid.css:
(select[size][multiple]):
- 10:38 AM Changeset in webkit [146083] by
-
- 3 edits2 adds in trunk
Source/WebCore: Assertion faulire in SVGAnimatedPath.
https://bugs.webkit.org/show_bug.cgi?id=106428
Reviewed by Allan Sandfeld Jensen.
The asserts are too restricted. The size must be greater or equal to 1.
Test: svg/animations/animated-path-via-use-debug-crash.svg
- svg/SVGAnimatedPath.cpp:
(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPathAnimator::resetAnimValToBaseVal):
LayoutTests: Assertion faulire in SVGAnimatedPath
https://bugs.webkit.org/show_bug.cgi?id=106428
Reviewed by Allan Sandfeld Jensen.
- svg/animations/animated-path-via-use-debug-crash.svg: Added.
- 10:34 AM Changeset in webkit [146082] by
-
- 4 edits in trunk
[Mac] Some tests intermittently asserts in SharedBuffer::releasePurgeableBuffer()
https://bugs.webkit.org/show_bug.cgi?id=105986
Source/WebCore:
Reviewed by Brady Eidson.
A ResourceBuffer's SharedBuffer can be vended out to other clients,
for example Images, so there's no guarantee that when the
ResourceBuffer only has one ref its SharedBuffer will also have just one.
When this assumption was broken, SharedBuffer::releasePurgeableBuffer()
would assert.
Ideally SharedBuffer would be entirely encapsulated by ResourceBuffer to
avoid this problem, but ResourceBuffer can't be used by code in platform/.
Fix by having ResourceBuffer::createPurgeableBuffer() refuse to make
a purgeable buffer if the sharedBuffer has more than one ref.
Tested by existing tests.
- loader/ResourceBuffer.cpp:
(WebCore::ResourceBuffer::createPurgeableBuffer):
LayoutTests:
Reviewed by Brady Eidson.
Remove expected Crashes for tests which should be fixed by this change.
- platform/mac/TestExpectations:
- 10:28 AM Changeset in webkit [146081] by
-
- 5 edits in trunk/Tools
Disable accessibility notifications after each test
https://bugs.webkit.org/show_bug.cgi?id=112579
Reviewed by Tim Horton.
In WebKitTestRunner, if any tests triggered accessibility notifications,
the global notification handler would thereafter be active, and fire
notifications for all subsequent tests.
Fix by implementing AccessibilityController::resetToConsistentState() for
Mac, and using it to clear the global notification handler.
- WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
(WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
(WTR::AccessibilityController::removeNotificationListener): Explicitly call
-stopObserving so that unregistering the observer doesn't rely on object lifetimes
(e.g. because of -autorelease).
(WTR::AccessibilityController::logAccessibilityEvents): Stub.
(WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
if there is one.
- WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
Add -stopObserving
- WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
(-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
(-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
center.
- 10:28 AM Changeset in webkit [146080] by
-
- 5 edits in trunk/LayoutTests
Unreviewed. Added new test expectations after r146072.
https://bugs.webkit.org/show_bug.cgi?id=112562
- platform/chromium-mac-lion/tables/mozilla/bugs/bug73321-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug73321-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug73321-expected.png:
- 10:16 AM Changeset in webkit [146079] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: move _timelineGrid && _timelineOverviewWindow from TimelineOverviewPane into a new class OverviewGrid.
https://bugs.webkit.org/show_bug.cgi?id=112584
Reviewed by Pavel Feldman.
It is the first path in the set.
The end goal is to extract OverviewGrid with window selectors
into a separate class in separate file and reuse it in CPU FlameChart.
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.OverviewGrid):
(WebInspector.OverviewGrid.prototype.get grid):
(WebInspector.OverviewGrid.prototype.get clientWidth):
(WebInspector.OverviewGrid.prototype.showItemsGraphsElement):
(WebInspector.OverviewGrid.prototype.hideItemsGraphsElement):
(WebInspector.OverviewGrid.prototype.updateDividers):
(WebInspector.OverviewGrid.prototype.addEventDividers):
(WebInspector.OverviewGrid.prototype.removeEventDividers):
(WebInspector.OverviewGrid.prototype.setWindowPosition):
(WebInspector.OverviewGrid.prototype.reset):
(WebInspector.OverviewGrid.prototype.get windowLeft):
(WebInspector.OverviewGrid.prototype.get windowRight):
(WebInspector.OverviewGrid.prototype.setWindow):
(WebInspector.OverviewGrid.prototype.addEventListener):
(WebInspector.TimelineOverviewPane.prototype.setMode):
(WebInspector.TimelineOverviewPane.prototype._setFrameMode):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
(WebInspector.TimelineOverviewPane.prototype.zoomToFrame):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.TimelineOverviewPane.prototype.windowLeft):
(WebInspector.TimelineOverviewPane.prototype.windowRight):
(WebInspector.TimelineOverviewPane.prototype._updateWindow):
- 10:14 AM Changeset in webkit [146078] by
-
- 2 edits in trunk/Tools
[chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
https://bugs.webkit.org/show_bug.cgi?id=112392
Reviewed by James Robinson.
Removes the command line flag option from DRT.
- DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
- 10:03 AM Changeset in webkit [146077] by
-
- 2 edits in trunk/LayoutTests
Update test expectations.
Unreviewed gardening.
- platform/chromium/TestExpectations:
- 10:03 AM Changeset in webkit [146076] by
-
- 1 edit in branches/chromium/1410/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp
Merge 145824 "IndexedDB: Histogram leveldb open errors."
IndexedDB: Histogram leveldb open errors.
https://bugs.webkit.org/show_bug.cgi?id=112307
Reviewed by Tony Chang.
No new tests, I don't know if there's a good way to test histograms.
- platform/leveldb/LevelDBDatabase.cpp:
(WebCore::LevelDBDatabase::open):
TBR=dgrogan@chromium.org
Review URL: https://codereview.chromium.org/12779020
- 10:01 AM Changeset in webkit [146075] by
-
- 7 edits in trunk/Source/WebKit2
[WK2][EFL] Fix code wrapping WKPageGroupRef
https://bugs.webkit.org/show_bug.cgi?id=112364
Reviewed by Alexey Proskuryakov.
The patch fixes following problems in EWK2 WKPageGroupRef wrapping
code: firstly it makes sure that there is only one EwkPageGroup
instance per WKPageGroup instance, secondly it allows web page to
to use the default page group (which is implicitly created inside
web context).
- UIProcess/API/C/efl/WKView.cpp:
(createWKView):
Now may pass '0' page group as a WebView creation argument so
that the default page group is used.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::createEvasObject):
- UIProcess/API/efl/EwkView.h:
(EwkView):
Web view should be created before page group, so they are rearranged
inside class declaration.
- UIProcess/API/efl/ewk_page_group.cpp:
(pageGroupMap):
A map to track corresponding EwkPageGroup and WKPageGroup
instances.
(EwkPageGroup::findOrCreateWrapper):
Returns the same EwkPageGroup instance for the same WKPageGroup
instance.
(EwkPageGroup::create):
(EwkPageGroup::EwkPageGroup):
Now there is only one constructor accepting WKPageGroupRef.
(EwkPageGroup::~EwkPageGroup):
- UIProcess/API/efl/ewk_page_group_private.h:
(EwkPageGroup):
- UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
- 9:56 AM Changeset in webkit [146074] by
-
- 3 edits3 adds in trunk
[V8] Crash when accessing onclick attribute of document from XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=112585
Reviewed by Eric Seidel.
Source/WebCore:
This ASSERT was bogus. The frame can be 0 for frameless documents, like
those created by XMLHttpRequest. When there is no frame, we act as if
JavaScript was disabled, which it is.
Test: fast/events/xhr-onclick-crash.html
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
LayoutTests:
- fast/events/resources/onclick.html: Added.
- fast/events/xhr-onclick-crash-expected.txt: Added.
- fast/events/xhr-onclick-crash.html: Added.
- 9:54 AM Changeset in webkit [146073] by
-
- 3 edits4 adds in trunk
[CSS Exclusions] Specifying polygonal -webkit-shape-inside value can crash browser (debug mode)
https://bugs.webkit.org/show_bug.cgi?id=112157
Reviewed by David Hyatt.
Source/WebCore:
Corrected the code which maps exclusion segments to pairs of InlineIterators. We now handle the
cases where the end of the line occurs within an exclusion segment or when it occurs before
the last exclusion segment has been reached. This can occur when a non-convex polygonal shape-inside
breaks a line up into two segments, but the shape-inside element's content only fills (or partially
fills) the first exclusion shape segment.
Tests: fast/exclusions/shape-inside/shape-inside-partial-fill-001.html
fast/exclusions/shape-inside/shape-inside-partial-fill-002.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
LayoutTests:
Added tests with a polygonal shape-inside exclusion shape, where multiple shape
segments exist on one line, but the line's text either partially or completely
fills only the first exclusion shape segment.
- fast/exclusions/shape-inside/shape-inside-partial-fill-001-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-partial-fill-001.html: Added.
- fast/exclusions/shape-inside/shape-inside-partial-fill-002-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-partial-fill-002.html: Added.
- 9:16 AM Changeset in webkit [146072] by
-
- 4 edits2 adds in trunk
Change RenderTableCell to use pixelSnappedSize when painting
https://bugs.webkit.org/show_bug.cgi?id=112562
Reviewed by Eric Seidel.
Source/WebCore:
Change the paining code in RenderTableCell to use the pixel snapped size
to ensure consistent rounding given that the location was rounded during
layout.
It is currently constructing a paint rect by taking the rounded location
and the precise size and then pixel snapping it. This causes the size to
be rounded incorrectly. By instead using the pixel snapped size the
rounding problem can be avoided.
Test: fast/sub-pixel/table-cell-background.html
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintCollapsedBorders):
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
(WebCore::RenderTableCell::paintBoxDecorations):
(WebCore::RenderTableCell::paintMask):
LayoutTests:
Add test for painting of cell backgrounds on a sub-pixel boundary.
- fast/sub-pixel/table-cell-background-expected.html: Added.
- fast/sub-pixel/table-cell-background.html: Added.
- platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png:
- 9:16 AM Changeset in webkit [146071] by
-
- 14 edits in trunk/Source/JavaScriptCore
ObjectPrototype properties should be eagerly created rather than lazily via static tables
https://bugs.webkit.org/show_bug.cgi?id=112539
Reviewed by Oliver Hunt.
This is the first part of https://bugs.webkit.org/show_bug.cgi?id=112233. Rolling this
in first since it's the less-likely-to-be-broken part.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- interpreter/CallFrame.h:
(JSC::ExecState::objectConstructorTable):
- runtime/CommonIdentifiers.h:
- runtime/JSGlobalData.cpp:
(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
- runtime/JSGlobalData.h:
(JSGlobalData):
- runtime/JSObject.cpp:
(JSC::JSObject::putDirectNativeFunction):
(JSC):
- runtime/JSObject.h:
(JSObject):
(JSC):
- runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
- runtime/ObjectPrototype.cpp:
(JSC):
(JSC::ObjectPrototype::finishCreation):
(JSC::ObjectPrototype::create):
- runtime/ObjectPrototype.h:
(ObjectPrototype):
- 9:13 AM Changeset in webkit [146070] by
-
- 4 edits in trunk/Source/WebKit/chromium
Access settings.defaultVideoPosterURL
https://bugs.webkit.org/show_bug.cgi?id=112378
Patch by Tao Bai <michaelbai@chromium.org> on 2013-03-18
Reviewed by Dimitri Glazkov.
The defaultVideoPosterURL setting has been added in
https://bugs.webkit.org/show_bug.cgi?id=110263,
this added methods to access it in Chromium.
The settings will be used by Android WebView API
WebChromeClient.getDefaultVideoPoster()
- public/WebSettings.h: add setDefaultVideoPosterURL
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setDefaultVideoPosterURL): set defaultVideoPosterURL
- src/WebSettingsImpl.h: add setDefaultVideoPosterURL
- 9:12 AM Changeset in webkit [146069] by
-
- 2 edits in trunk/Source/WebCore
Need to use const String in HTMLVideoElement::posterImageURL
https://bugs.webkit.org/show_bug.cgi?id=112317
Patch by Tao Bai <michaelbai@chromium.org> on 2013-03-18
Reviewed by Andreas Kling.
No behavioral changes.
This is the followup of https://bugs.webkit.org/show_bug.cgi?id=110263
Need to use String instead of const AtomicString& which means we will do an extra hash lookup
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::posterImageURL): Change to use String for url
- 8:49 AM Changeset in webkit [146068] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
- platform/efl/TestExpectations: Remove
editing/pasteboard/paste-4035648-fix.html from the skipped list after
r144999.
- 8:33 AM Changeset in webkit [146067] by
-
- 4 edits3 adds in trunk
[GTK] plugins/plugin-clip-subframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112570
Reviewed by Martin Robinson.
Tools:
- GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
LayoutTests:
- platform/gtk-wk2/plugins/plugin-clip-subframe-expected.txt: Added the required baseline.
- platform/gtk/TestExpectations: Removing the failure expectation.
- platform/gtk/plugins/plugin-clip-subframe-expected.txt: Added the required baseline.
- 8:11 AM Changeset in webkit [146066] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Settings] Register "?" shortcut.
https://bugs.webkit.org/show_bug.cgi?id=112545
Reviewed by Vsevolod Vlasov.
F1 and "?" (show shortcuts page) are not mentioned on shortcuts page.
- English.lproj/localizedStrings.js: Added string.
- inspector/front-end/inspector.js: Registered F1 / "?" shortcut.
- 8:09 AM CoordinatedGraphicsSystem edited by
- update broken URLs (diff)
- 7:27 AM Changeset in webkit [146065] by
-
- 2 edits in trunk/Source/WebCore
Add USE(PLATFORM_STRATEGIES) ifdefs to StorageNamespace.cpp
https://bugs.webkit.org/show_bug.cgi?id=112004
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-18
Reviewed by Rob Buis.
Check if platform strategies is enabled before using it, falling
back to StorageNamespaceImpl if it isn't.
- storage/StorageNamespace.cpp:
(WebCore::StorageNamespace::localStorageNamespace):
(WebCore::StorageNamespace::sessionStorageNamespace):
- 7:23 AM WebKitGTK/2.0.x edited by
- (diff)
- 7:18 AM Changeset in webkit [146064] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore
Merge r145831 - [GStreamer] simulateAudioInterruption needs to be guarded by ENABLE(VIDEO)"
https://bugs.webkit.org/show_bug.cgi?id=112358
Guarded with ENABLE(VIDEO) to prevent problems when it is not
enabled.
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.
- 7:15 AM Changeset in webkit [146063] by
-
- 13 edits2 adds in releases/WebKitGTK/webkit-2.0
Merge r145811 - [GStreamer] Stopping playback of html5 media when receiving a higher priority audio event needs implementation
https://bugs.webkit.org/show_bug.cgi?id=91611
Source/WebCore:
React to REQUEST_STATE GStreamer message to stop the pipeline when
a higher priority stream is played. When this happens, states are
updated accordingly.
A method was added in the MediaPlayer class and internals to allow
the the test runner to simulate an audio interruption.
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.
Test: media/media-higher-prio-audio-stream.html
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore):
(MediaPlayer):
(WebCore::MediaPlayer::simulateAudioInterruption): New method
delegating an audio interruption to the private backend to
simulate the use-case where an external application needs
exclusive access to the audio device.
- platform/graphics/MediaPlayerPrivate.h:
(MediaPlayerPrivateInterface):
(WebCore::MediaPlayerPrivateInterface::simulateAudioInterruption):
Added default empty method in the common private header.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore):
(WebCore::MediaPlayerPrivateGStreamer::createAudioSink):
(WebCore::setAudioStreamPropertiesCallback): Hooked to child-added
signal on the audio sink, delegates on setAudioStreamProperties.
(WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
Sets the audio stream properties.
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
Initializes the new attribute.
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
Disconnects autoaudiosink signal.
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
Changed logging.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Reacting to
the REQUEST_STATE message.
(WebCore::MediaPlayerPrivateGStreamer::simulateAudioInterruption):
Added. Injects the REQUEST_STATE message to the pipeline.
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Updating the
playback state if REQUEST_STATE.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer): Added new method and attribute.
- testing/Internals.h:
- testing/Internals.idl:
- testing/Internals.cpp:
(WebCore):
(WebCore::Internals::simulateAudioInterruption): Added to call the
method to stop the element because of a higher prio stream at the
tests.
LayoutTests:
Created test, expected result and updated other ports
expectations.
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.
- media/media-higher-prio-audio-stream-expected.txt: Added.
- media/media-higher-prio-audio-stream.html: Added.
- platform/chromium/TestExpectations: Skipped the new test.
- platform/mac/TestExpectations: Skipped the new test.
- platform/qt/TestExpectations: Skipped the new test for Mac and
Win.
- 7:13 AM Changeset in webkit [146062] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: TabbedEditorContainer does not restore last shown file on reload sometimes.
https://bugs.webkit.org/show_bug.cgi?id=112561
Reviewed by Alexander Pavlov.
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype.addUISourceCode):
- 6:56 AM WebKitGTK/2.0.x edited by
- (diff)
- 6:43 AM Changeset in webkit [146061] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] EditorClientBlackBerry: fix access to WebPage attribute
https://bugs.webkit.org/show_bug.cgi?id=112556
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
Reviewed by Rob Buis.
This changed in r145849 and broke the BlackBerry build.
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::smartInsertDeleteEnabled):
(WebCore::EditorClientBlackBerry::isSelectTrailingWhitespaceEnabled):
- 6:24 AM WebKitGTK/2.0.x edited by
- (diff)
- 6:22 AM Changeset in webkit [146060] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0
Merge 146059 - [GTK] Exports leveldb symbols
https://bugs.webkit.org/show_bug.cgi?id=112526
Reviewed by Carlos Garcia Campos.
- Source/autotools/symbols.filter: make leveldb symbols local.
- 6:19 AM Changeset in webkit [146059] by
-
- 2 edits in trunk
[GTK] Exports leveldb symbols
https://bugs.webkit.org/show_bug.cgi?id=112526
Reviewed by Carlos Garcia Campos.
- Source/autotools/symbols.filter: make leveldb symbols local.
- 6:05 AM Changeset in webkit [146058] by
-
- 7 edits in trunk/Source
[BlackBerry] Detach overlays from page when compositor is detached
https://bugs.webkit.org/show_bug.cgi?id=112424
Reviewed by Rob Buis.
PR 309160
Source/WebCore:
Expose a method to retrieve a compositing thread layer's client.
No change in behavior, no new tests.
- platform/graphics/blackberry/LayerCompositingThread.h:
(WebCore::LayerCompositingThread::client):
Source/WebKit/blackberry:
If not detached properly, the overlays would have a dangling pointer to
the page.
- Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::~WebOverlayPrivateCompositingThread):
- Api/WebOverlay_p.h:
(BlackBerry::WebKit::WebOverlayPrivate::setClient):
(WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::overlay):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::overlayDestroyed):
(WebOverlayPrivateCompositingThread):
- Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::detach):
(BlackBerry::WebKit::WebPageCompositorPrivate::setPage):
(WebKit):
(BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
- Api/WebPageCompositor_p.h:
(BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
(BlackBerry::WebKit::WebPageCompositorPrivate::detachOverlays):
(WebPageCompositorPrivate):
- 5:52 AM Changeset in webkit [146057] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Resources] Local Storage: duplicate keys are processed inappropriately.
https://bugs.webkit.org/show_bug.cgi?id=112402
Reviewed by Alexander Pavlov.
When user creates new items or renames existing one some existing item
may be overriden. If value is changed, then frontend will receive
notification and update record appropriately.
If item value hasn't been changed, then no notification comes.
But UI still expect / rely on this notification.
With this patch the "no notification" scenario is fixed:
duplicate items are removed.
Another scenario is when update notification comes when we started
editing value (after entering / renaming key). In this case
selected node should not be changed to leave user in editing mode.
- inspector/front-end/DOMStorageItemsView.js:
Added workarounds for "no notification" and "useless notification".
- 5:25 AM Companies and Organizations that have contributed to WebKit edited by
- (diff)
- 4:59 AM Changeset in webkit [146056] by
-
- 3 edits in trunk/Source/WebCore
Clean up RenderFrameSet::nodeAtPoint
https://bugs.webkit.org/show_bug.cgi?id=112450
Reviewed by Eric Seidel.
Remove handling of resizing framesets from RenderFrameSet::nodeAtPoint.
The code has been incorrect since a mistake in r18333 (December 2006),
but has been dead code since r17770 (November 2006) where the then new
EventHandler started taking care of routing events to resizing FrameSets.
Since this was the only special feature of RenderFrameSet::nodeAtPoint,
the method has been removed.
- rendering/RenderFrameSet.cpp:
- rendering/RenderFrameSet.h:
(RenderFrameSet):
- 4:48 AM Changeset in webkit [146055] by
-
- 3 edits2 adds in trunk
The 'formnovalidate' attribute doesn't work correctly on button elements with child elements
https://bugs.webkit.org/show_bug.cgi?id=112541
Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-18
Reviewed by Kent Tamura.
Source/WebCore:
Fix a bug where formnovalidate attribute of <button> is not honored
if the target of the click event is an element nested within the button.
Test: fast/forms/interactive-validation-formnovalidate-child.html
- html/HTMLFormElement.cpp:
(WebCore::submitElementFromEvent): Looks for the nearest FormControlElement ancestor of the event target.
LayoutTests:
- fast/forms/interactive-validation-formnovalidate-child-expected.txt: Added.
- fast/forms/interactive-validation-formnovalidate-child.html: Added.
- 4:45 AM Changeset in webkit [146054] by
-
- 5 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r145951 - [GTK] Enforce the C++11 standard when compiling WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112169
Reviewed by Gustavo Noronha Silva.
With a limited set of supported compilers the WebKit2 source code can now
be built with the C++11 language standard enforced.
- GNUmakefile.am:
- UIProcess/API/gtk/WebKitWebContext.cpp:
(injectedBundleDirectory): Adjust the string literals concatenation, moving away from empty strings
(which C++11 refuses to handle as concatenation operators) and using whitespace instead.
- UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::platformResourceForPath): Ditto.
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::inspectorFilesBasePath): Ditto.
- 4:36 AM Changeset in webkit [146053] by
-
- 14 edits in trunk/LayoutTests
Unreviewed EFL rebaseline after r146050.
- platform/efl/fast/css/input-search-padding-expected.txt:
- platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
- platform/efl/fast/css/text-overflow-input-expected.txt:
- platform/efl/fast/forms/box-shadow-override-expected.txt:
- platform/efl/fast/forms/control-restrict-line-height-expected.txt:
- platform/efl/fast/forms/input-appearance-height-expected.txt:
- platform/efl/fast/forms/placeholder-position-expected.txt:
- platform/efl/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/efl/fast/forms/search-styled-expected.txt:
- platform/efl/fast/forms/search-vertical-alignment-expected.txt:
- platform/efl/fast/forms/searchfield-heights-expected.txt:
- platform/efl/fast/repaint/search-field-cancel-expected.txt:
- platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
- 4:02 AM Changeset in webkit [146052] by
-
- 4 edits6 adds in trunk
Add touch support to the calendar picker
https://bugs.webkit.org/show_bug.cgi?id=112256
Reviewed by Kent Tamura.
Source/WebCore:
This patch increases the hit target sizes for touch and adds touch event
support to the scroll view, scroll bar and navigation button.
Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-touch-operations.html
platform/chromium/fast/forms/calendar-picker/month-picker-touch-operations.html
platform/chromium/fast/forms/calendar-picker/week-picker-touch-operations.html
- Resources/pagepopups/calendarPicker.js:
(hasInaccuratePointingDevice):
(Animator): Super class for TransitionAnimator and FlingGestureAnimator.
(Animator.prototype.start):
(Animator.prototype.stop):
(Animator.prototype.onAnimationFrame):
(TransitionAnimator): Same as the old Animator. Transition from one value to another.
(TransitionAnimator.prototype.setFrom):
(TransitionAnimator.prototype.start):
(TransitionAnimator.prototype.stop):
(TransitionAnimator.prototype.setTo):
(TransitionAnimator.prototype.onAnimationFrame):
(FlingGestureAnimator):Animates the fling scroll.
(FlingGestureAnimator.prototype._valueAtTime): Returns the value at the given time.
(FlingGestureAnimator.prototype._velocityAtTime): Returns the value change velocity at the given time.
(FlingGestureAnimator.prototype._timeAtVelocity): Returns the time when the value is changing at the given velocity.
(FlingGestureAnimator.prototype.start):
(FlingGestureAnimator.prototype.onAnimationFrame):
(ScrollView): Added support for touch gesture scrolling.
(ScrollView.prototype.onTouchStart):
(ScrollView.prototype.onWindowTouchMove):
(ScrollView.prototype.onWindowTouchEnd):
(ScrollView.prototype.onFlingGestureAnimatorStep):
(ScrollView.prototype.scrollTo):
(ScrubbyScrollBar): Added support for touch.
(ScrubbyScrollBar.prototype.onTouchStart):
(ScrubbyScrollBar.prototype.onWindowTouchMove):
(ScrubbyScrollBar.prototype.onWindowTouchEnd):
(ScrubbyScrollBar.prototype._setThumbPositionFromEventPosition): Accept MouseEvent or Touch.
(ScrubbyScrollBar.prototype.onMouseDown):
(ScrubbyScrollBar.prototype.onWindowMouseMove):
(ScrubbyScrollBar.prototype.onWindowMouseUp):
(YearListCell):
(YearListView):
(YearListView.prototype.onTouchStart):
(YearListView.prototype._animateRow):
(CalendarNavigationButton): Add touch support for long press.
(CalendarNavigationButton.prototype.onTouchStart):
(CalendarNavigationButton.prototype.onWindowTouchEnd):
(CalendarNavigationButton.prototype.onMouseDown):
(CalendarNavigationButton.prototype.onWindowMouseUp):
(CalendarTableView): Disable touch gesture scrolling in the calendar table.
LayoutTests:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-touch-operations-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-touch-operations.html: Added.
- platform/chromium/fast/forms/calendar-picker/month-picker-touch-operations-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/month-picker-touch-operations.html: Added.
- platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:
(hoverOverMonthPopupButton):
(clickMonthPopupButton): Use hoverOverMonthPopupButton.
- platform/chromium/fast/forms/calendar-picker/week-picker-touch-operations-expected.txt: Added.
- platform/chromium/fast/forms/calendar-picker/week-picker-touch-operations.html: Added.
- 3:52 AM Changeset in webkit [146051] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] BackingStoreClient: remove unnecessary call to toElement()
https://bugs.webkit.org/show_bug.cgi?id=112547
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
Reviewed by Carlos Garcia Campos.
- WebKitSupport/BackingStoreClient.cpp:
(BlackBerry::WebKit::BackingStoreClient::absoluteRect):
- 3:13 AM Changeset in webkit [146050] by
-
- 9 edits in trunk
[EFL] Cancel mark on search field is not displayed
https://bugs.webkit.org/show_bug.cgi?id=94880
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
adjustSearchFieldCancelButtonStyle() doesn't set style width and height for search cancel button.
So, the button isn't showing up in search input field. Besides the button size should be scaled based
on the font size as chromium, qt, and blackberry ports.
Tests: fast/forms/search-cancel-button-style-sharing.html
fast/forms/search-rtl.html
- platform/efl/RenderThemeEfl.cpp:
(WebCore):
(WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
LayoutTests:
Rebaseline expected results related to search cancel button.
- platform/efl-wk1/TestExpectations: These tests don't work with WK1 pixel test yet.
- platform/efl/TestExpectations:
- platform/efl/fast/forms/search-cancel-button-style-sharing-expected.png:
- platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/efl/fast/forms/search-rtl-expected.png:
- platform/efl/fast/forms/search-rtl-expected.txt:
- 2:57 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:47 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:46 AM Changeset in webkit [146049] by
-
- 5 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[GTK] Add methods to add a user style sheet to the WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=99081
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-03-18
Reviewed by Carlos Garcia Campos.
Add methods to WebKitWebViewGroup to add and remove user style sheets.
This allows clients to inject style sheets into pages with a set of
rules for when those style sheets apply.
- UIProcess/API/gtk/WebKitWebViewGroup.cpp:
(toImmutableArray): Added this helper which converts the GList* parameters into
ImmutableArrays for use with the WebKit2 internal API.
(webkit_web_view_group_add_user_style_sheet): Added new API for adding a style sheet.
(webkit_web_view_group_remove_all_user_style_sheets): Add new API for clearing out all style sheets.
- UIProcess/API/gtk/WebKitWebViewGroup.h: Added new method declarations.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Added new API to the documentation.
- UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp: Added a test for the new API.
(isStyleSheetInjectedForURLAtPath): Function to check whether the style sheet has been injected for a given URL.
(fillURLListFromPaths): Helper which converts paths passed via varargs into a whitelist or blacklist.
(removeOldInjectedStyleSheetsAndResetLists): Function to start afresh.
(testWebViewGroupInjectedStyleSheet): The actual test.
(serverCallback): Server callback for use with the test. We cannot use loadHTML or
loadAlternateHTML, because that checks the whitelist and blacklist against about:blank.
(beforeAll): Initialize the server and new test.
(afterAll): Clean up the server.
- 2:40 AM Changeset in webkit [146048] by
-
- 11 edits in trunk
Web Inspector: Native Memory Timeline affects the performace even if was switched off.
https://bugs.webkit.org/show_bug.cgi?id=112428
Reviewed by Pavel Feldman.
Source/WebCore:
Whether to include DOM counters and native memory statistics is now
configured using Timeline.start parameters instead of sending separate
commands Timeline.setIncludeDomCounters and Timeline.setIncludeNativeMemoryStatistics.
- inspector/Inspector.json:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::restore):
(WebCore::InspectorTimelineAgent::start):
- inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
- inspector/front-end/DOMCountersGraph.js:
(WebInspector.DOMCountersGraph):
- inspector/front-end/NativeMemoryGraph.js:
(WebInspector.NativeMemoryGraph):
- inspector/front-end/TimelineManager.js:
(WebInspector.TimelineManager.prototype.start):
- inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel.prototype.startRecord):
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.get _toggleTimelineButtonClicked):
LayoutTests:
- http/tests/inspector/timeline-test.js: chaned Timeline.start parameters
to match previous behavior.
- 2:32 AM Changeset in webkit [146047] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Exception in timeline DOMCounters
https://bugs.webkit.org/show_bug.cgi?id=112427
Reviewed by Pavel Feldman.
Do not update marker on DOM counters graph if the graphs haven't been
drawn yet.
- inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):
- 2:28 AM Changeset in webkit [146046] by
-
- 5 edits in trunk
Mediastream.ended should return true when all tracks were removed.
https://bugs.webkit.org/show_bug.cgi?id=112528
Reviewed by Kentaro Hara.
Source/WebCore:
Spec: http://dev.w3.org/2011/webrtc/editor/getusermedia.html#widl-MediaStream-ended
When all tracks have been removed, it should return true as well as all the tracks
were ended.
Test: fast/mediastream/MediaStream-add-remove-tracks.html
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::removeTrack):
LayoutTests:
- fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
- fast/mediastream/MediaStream-add-remove-tracks.html:
- 2:21 AM Changeset in webkit [146045] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: make number of stack frames to capture in Timeline a setting
https://bugs.webkit.org/show_bug.cgi?id=110619
Reviewed by Pavel Feldman.
- factor out creation of input type="text" control for better reuse;
- add timelineLimitStackFramesFlag & timelineStackFramesToCapture settings;
- English.lproj/localizedStrings.js: add "Frames to capture" and "Limit number of captured JS stack frames"
- inspector/front-end/Settings.js: add 2 settings;
(WebInspector.Settings):
- inspector/front-end/SettingsScreen.js: UI for the setting;
(WebInspector.GenericSettingsTab):
(WebInspector.GenericSettingsTab.prototype.get _createCSSAutoReloadControls.validateReloadTimeout):
- inspector/front-end/TimelineModel.js: pass the setting value to back-end.
- 2:07 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:06 AM Changeset in webkit [146044] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[WebKit2][GTK] Initialize gettext also in the UIProcess side
https://bugs.webkit.org/show_bug.cgi?id=112489
Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2013-03-18
Reviewed by Carlos Garcia Campos.
- UIProcess/API/gtk/WebKitPrivate.cpp:
(wkInitialize): set text domain and codeset for the library on
process startup, the first one is required for translations to be
found when not installed on the main system directories searched
by gettext, the second one is to please glib and GTK+
- 2:05 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:04 AM Changeset in webkit [146043] by
-
- 41 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge r145936 - Unreviewed, build fix. Also gather translatable strings from WebKit2 files.
- POTFILES.in: added WebKit2GTK+ files that have translatable strings.
- ar.po: regenerated.
- as.po: ditto.
- bg.po: ditto.
- cs.po: ditto.
- de.po: ditto.
- el.po: ditto.
- en_CA.po: ditto.
- en_GB.po: ditto.
- eo.po: ditto.
- es.po: ditto.
- et.po: ditto.
- eu.po: ditto.
- fr.po: ditto.
- gl.po: ditto.
- gu.po: ditto.
- he.po: ditto.
- hi.po: ditto.
- hu.po: ditto.
- id.po: ditto.
- it.po: ditto.
- ko.po: ditto.
- lt.po: ditto.
- lv.po: ditto.
- mr.po: ditto.
- nb.po: ditto.
- nl.po: ditto.
- pa.po: ditto.
- pl.po: ditto.
- pt.po: ditto.
- pt_BR.po: ditto.
- ro.po: ditto.
- ru.po: ditto.
- sl.po: ditto.
- sr.po: ditto.
- sr@latin.po: ditto.
- sv.po: ditto.
- uk.po: ditto.
- vi.po: ditto.
- zh_CN.po: ditto.
- 1:52 AM Changeset in webkit [146042] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk1/TestExpectations:
- platform/qt/TestExpectations:
- 1:37 AM Changeset in webkit [146041] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r146035.
http://trac.webkit.org/changeset/146035
https://bugs.webkit.org/show_bug.cgi?id=112540
fails to build on Windows: singned/unsigned mismatch at ln. 53
of html\HTMLSelectElementWin.cpp (Requested by antonm on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-18
- WebCore.gypi:
- html/HTMLSelectElement.cpp:
(WebCore):
- html/HTMLSelectElementWin.cpp:
- 1:33 AM Changeset in webkit [146040] by
-
- 8 edits in trunk
Unreviewed, rolling out r146033.
http://trac.webkit.org/changeset/146033
https://bugs.webkit.org/show_bug.cgi?id=112521
web audio tests are broken
Source/WebCore:
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::AudioNode):
- Modules/webaudio/AudioNode.h:
- Modules/webaudio/AudioScheduledSourceNode.h:
- Modules/webaudio/ScriptProcessorNode.idl:
LayoutTests:
- webaudio/javascriptaudionode-expected.txt:
- webaudio/javascriptaudionode.html:
- 1:17 AM Changeset in webkit [146039] by
-
- 3 edits in trunk/LayoutTests
Update test expectations.
Unreviewed gardening.
- platform/chromium-win/fast/forms/color/input-appearance-color-expected.png:
- platform/chromium/TestExpectations:
- 1:01 AM Changeset in webkit [146038] by
-
- 6 edits in trunk
A placeholder renderer should not be taken to imply the existence of a text renderer in single line text controls
https://bugs.webkit.org/show_bug.cgi?id=112410
Reviewed by Tony Chang.
Source/WebCore:
The assumption that if a text control had a placeholder renderer
then it also had a text renderer is not valid. If
::-webkit-textfield-decoration-controller is set to display: none;
a single line text control's decoration container renderer and
hence text renderer are not created. This change handles this
corner case where a text control has a placeholder renderer but
not a text renderer.
Tests: fast/forms/search/search-hide-decoration-container-crash.html (Updated)
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::fixPlaceholderRenderer):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
LayoutTests:
Update search-hide-decoration-container-crash.html to exercise
non-null placeholder renderers and null text renderers.
Cases where neither are rendered already get coverage in
search-scroll-hidden-decoration-container-crash.html and
search-autoscroll-hidden-decoration-container-crash.html.
- fast/forms/search/search-hide-decoration-container-crash.html:
- fast/forms/search/search-hide-decoration-container-crash-expected.txt:
- 12:55 AM Changeset in webkit [146037] by
-
- 5 edits2 adds in trunk
[Shadow] offsetParent should never return nodes in user agent Shadow DOM to script
https://bugs.webkit.org/show_bug.cgi?id=112530
Reviewed by Elliott Sprehn.
Source/WebCore:
Test: fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html
- dom/Element.cpp:
(WebCore::Element::bindingsOffsetParent): Filter nodes in UA shadows.
- dom/Element.h:
(Element): Add bindingsOffsetParent.
- dom/Element.idl: bindingsOffsetParent is the implementation of offsetParent.
LayoutTests:
- fast/dom/shadow/offset-parent-does-not-leak-ua-shadow-expected.txt: Added.
- fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html: Added.
- 12:17 AM WebKitGTK/2.0.x edited by
- Add new change on track (diff)
Mar 17, 2013:
- 11:40 PM Changeset in webkit [146036] by
-
- 1 edit in branches/chromium/1410/Source/WebCore/inspector/front-end/inspector.css
Merge (partial, css only) 143224 "Web Inspector: hide vertical-sidebar-split in dock..."
Web Inspector: hide vertical-sidebar-split in dock-to-right mode behind single experimental flag.
https://bugs.webkit.org/show_bug.cgi?id=110119
Reviewed by Vsevolod Vlasov.
Removed context menus, made it toggle automatically upon dock orientation change.
- inspector/front-end/inspector.css:
TBR=pfeldman@chromium.org
BUG=196537
Review URL: https://codereview.chromium.org/12895003
- 11:25 PM Changeset in webkit [146035] by
-
- 4 edits in trunk/Source/WebCore
Support Windows HTMLSelectElement keystrokes on Chromium win
https://bugs.webkit.org/show_bug.cgi?id=112460
Reviewed by Kent Tamura.
Compile in the windows-specific variant of
HTMLSelectElement::platformHandleKeydownEvent
on Chromium win, in addition to PLATFORM(WIN).
- WebCore.gypi:
Add html/HTMLSelectElementWin.cpp.
- html/HTMLSelectElement.cpp:
Don't compile generic platformHandleKeydownEvent on
Chromium win.
- html/HTMLSelectElementWin.cpp:
Only compile platformHandleKeydownEvent on Windows.
(WebCore):
- 10:54 PM Changeset in webkit [146034] by
-
- 3 edits in trunk/LayoutTests
Mark some more tests as flakey, or asserting in debug.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 10:51 PM Changeset in webkit [146033] by
-
- 8 edits in trunk
ScriptProcessorNode is garbage collected while still active if unreachable
https://bugs.webkit.org/show_bug.cgi?id=112521
Patch by Russell McClellan <russell.mcclellan@gmail.com> on 2013-03-17
Reviewed by Kentaro Hara.
Source/WebCore:
Fix for issue where ScriptProcessorNodes (and AudioNode js wrappers generally)
would be garbage collected before their time. Made AudioNode an ActiveDOMElement
marked pending if there are any open audio connections.
Test: webaudio/javascriptaudionode.html
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::hasPendingActivity): it's pending (and thus not GCed)
if it has open audio connections.
- Modules/webaudio/AudioNode.h: AudioNode is now an ActiveDOMElement
- Modules/webaudio/AudioScheduledSourceNode.h: added a using declaration
to avoid function name hiding.
- Modules/webaudio/ScriptProcessorNode.idl: AudioNode is an ActiveDOMElement
LayoutTests:
- webaudio/javascriptaudionode-expected.txt:
- webaudio/javascriptaudionode.html:
- 10:26 PM Changeset in webkit [146032] by
-
- 11 edits in trunk
INPUT_MULTIPLE_FIELDS_UI: Step-up/-down of minute/second/millisecond fields should respect min/max attributes
https://bugs.webkit.org/show_bug.cgi?id=112527
Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-17
Reviewed by Kent Tamura.
Source/WebCore:
Make step-up/-down of the minute, second, and millisecond field
respect the min/max attributes of the element.
Note that it still accepts any keyboard inputs (the element
becomes 'invalid' state when out-of-range values entered).
Also, disable these fields when there is only single possible value.
Tests: fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html
fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html
- html/shadow/DateTimeEditElement.cpp:
(DateTimeEditBuilder): Add fields for min/max of minute/second/millisecond.
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder): Set min/max for the fields.
(WebCore::DateTimeEditBuilder::visitField): Pass min/max parameters to the field constructors.
(WebCore::DateTimeEditBuilder::shouldHourFieldDisabled): Does not disable if minute, second, millisecond fields are all disabled, because we need at least one editable field.
(WebCore::DateTimeEditBuilder::shouldMillisecondFieldDisabled): Disables if min, max, and value are equal.
(WebCore::DateTimeEditBuilder::shouldMinuteFieldDisabled): Ditto.
(WebCore::DateTimeEditBuilder::shouldSecondFieldDisabled): Ditto.
- html/shadow/DateTimeFieldElements.cpp:
(WebCore::DateTimeDayFieldElement::DateTimeDayFieldElement):
(WebCore::DateTimeHourFieldElementBase::DateTimeHourFieldElementBase):
(WebCore::DateTimeHour11FieldElement::DateTimeHour11FieldElement):
(WebCore::DateTimeHour12FieldElement::DateTimeHour12FieldElement):
(WebCore::DateTimeHour23FieldElement::DateTimeHour23FieldElement):
(WebCore::DateTimeHour24FieldElement::DateTimeHour24FieldElement):
(WebCore::DateTimeMillisecondFieldElement::DateTimeMillisecondFieldElement):
(WebCore::DateTimeMillisecondFieldElement::create):
(WebCore::DateTimeMinuteFieldElement::DateTimeMinuteFieldElement):
(WebCore::DateTimeMinuteFieldElement::create):
(WebCore::DateTimeMonthFieldElement::DateTimeMonthFieldElement):
(WebCore::DateTimeSecondFieldElement::DateTimeSecondFieldElement):
(WebCore::DateTimeSecondFieldElement::create):
(WebCore::DateTimeWeekFieldElement::DateTimeWeekFieldElement):
(WebCore::DateTimeYearFieldElement::DateTimeYearFieldElement):
- html/shadow/DateTimeFieldElements.h:
(DateTimeDayFieldElement):
(DateTimeHourFieldElementBase):
(DateTimeHour11FieldElement):
(DateTimeHour12FieldElement):
(DateTimeHour23FieldElement):
(DateTimeHour24FieldElement):
(DateTimeMillisecondFieldElement): Add minimum/maximum parameters.
(DateTimeMinuteFieldElement): Add minimum/maximum parameters.
(DateTimeMonthFieldElement):
(DateTimeSecondFieldElement): Add minimum/maximum parameters.
(DateTimeWeekFieldElement):
(DateTimeYearFieldElement):
- html/shadow/DateTimeNumericFieldElement.cpp:
(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
(WebCore::DateTimeNumericFieldElement::formatValue): Use hard-limit value instead of m_range.maximum, because millisecond field with max<100 will be displayed in two digits otherwise.
(WebCore::DateTimeNumericFieldElement::setValueAsInteger):
- html/shadow/DateTimeNumericFieldElement.h:
(DateTimeNumericFieldElement): Changed to have hard limits as a data member.
LayoutTests:
- fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html:
- fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:
- 8:28 PM Changeset in webkit [146031] by
-
- 3 edits in trunk/Source/WebKit/chromium
[Chromium] Remove unused WebNode::hasEventListeners API
https://bugs.webkit.org/show_bug.cgi?id=112529
Reviewed by James Robinson.
This API no longer has any callers and can be removed.
- public/WebNode.h:
- src/WebNode.cpp:
- 7:21 PM Changeset in webkit [146030] by
-
- 3 edits in trunk/Source/WebCore
Encapsulate PlatformMessagePortChannel a little better yet
https://bugs.webkit.org/show_bug.cgi?id=112479
Reviewed by Sam Weinig.
- dom/MessagePortChannel.h: We no longer expose PlatformMessagePortChannel in
public functions in cross-platform code.
- dom/default/PlatformMessagePortChannel.cpp:
(WebCore::MessagePortChannel::createChannel): Tweaked the factory method to avoid
using the old create() function.
(WebCore::MessagePortChannel::~MessagePortChannel): Removed an unhelpful comment.
- 6:15 PM WebKitGTK/2.0.x edited by
- (diff)
- 5:38 PM Changeset in webkit [146029] by
-
- 10 edits in trunk
INPUT_MULTIPLE_FIELDS_UI: Don't update shadow tree by updating any attribute
https://bugs.webkit.org/show_bug.cgi?id=111990
Reviewed by Hajime Morrita.
Source/WebCore:
Bug detail:
Typing '1' then '1' into an hour field doesn't set the field to
'11' if an attribute is updated during these two keyboard inputs
because we always re-construct a shadow DOM tree by updating any
attributes and a shadow node records keyboard input state.
How to fix:
We should not re-construct a shadow DOM tree by updating
unaffected attributes. For example, we should re-construct it by
updating 'min' attribute, but we should not by updating 'class'
attribute.
We have InputType::updateInnerTextValue call in parseAttribute for
text field input types. The multiple fields input types
re-construct shadow DOM tree in updateInnerTextValue. The
updateInnerTextValue call is unnecessary for the multiple fields
input types, and we should call it when it is necessary. So, we
add InputType::attributeChange and text field input types call
updateInnerTextValue in it, and other input types don't.
Also, multiple fields input types need to call
updateInnerTextValue by 'value' attribute change. We add
InputType::valueAttributeChanged.
Tests: Update
fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html. The
value attribute change behavior is covered by
time-multiple-fields-change-layout-by-value.html and
time-multiple-fields-spinbutton-change-and-input-events.html.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
- Add a valueAttributeChanged call.
- Calls InputType::attributeChanged
- html/InputType.cpp:
(WebCore::InputType::attributeChanged): Added an empty implementation.
(WebCore::InputType::valueAttributeChanged): Ditto.
- html/InputType.h:
(InputType): Declare attributeChanged and valueAttributeChanged.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::attributeChanged):
Added. Always call updateInnerTextValue.
- html/TextFieldInputType.h:
(TextFieldInputType): Declare attributeChanged.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::valueAttributeChanged):
Added. Re-construct shadow DOM tree if the input has no dirty value.
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType): Declare valueAttributeChanged.
LayoutTests:
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:
- 4:58 PM Changeset in webkit [146028] by
-
- 6 edits in trunk
[HTMLTemplateElement] prevent </template> from matching "template" in a non-HTML tags on the stack of open elements
https://bugs.webkit.org/show_bug.cgi?id=112487
Reviewed by Adam Barth.
Source/WebCore:
When processing an end template tag, the parser now pops until a "template" tag is parsed, but now ensures that
the "template" it pops is in the HTML namespace.
Tests added to the html5lib test suite.
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::popUntil):
(WebCore):
(WebCore::HTMLElementStack::popUntilPopped):
- html/parser/HTMLElementStack.h:
(HTMLElementStack):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processTemplateEndTag):
LayoutTests:
- html5lib/resources/template.dat:
- 4:06 PM Changeset in webkit [146027] by
-
- 2 edits in trunk/LayoutTests
fast/frames/flattening/frameset-flattening-subframesets.html is flakey
- platform/mac/TestExpectations:
- 2:40 PM Changeset in webkit [146026] by
-
- 14 edits in trunk/LayoutTests
Add tests for calendar picker month popup
https://bugs.webkit.org/show_bug.cgi?id=112107
Adding tests to check if mouse and keyboard operations work on the month popup.
Reviewed by Kent Tamura.
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html:
- platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html:
- platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations.html:
- platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:
(clickMonthPopupButton): Clicks the month popup button to open the month popup.
(clickYearListCell): Clicks the year list cell for the given year to reveal the month buttons.
(hoverOverMonthButton): Moves the mouse over to the month button for the given month.
(clickMonthButton): Clicks the month button for the given month.
(checkYearListViewScrollOffset): Checks the year list view scroll offset and returns the difference from the last time it was called.
- platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html:
- platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations-expected.txt:
- platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations.html:
- 2:39 PM Changeset in webkit [146025] by
-
- 16 edits15 deletes in trunk
Legacy CSS vendor prefixes should only work for Dashboard
https://bugs.webkit.org/show_bug.cgi?id=111890
Reviewed by Eric Seidel.
Source/WebCore:
Our experience with the Chromium port is that these legacy CSS vendor
prefixes (-apple- and -khtml-) are not needed for web compatibility.
There is reason to believe, however, that they are needed for
compatibility with Mac OS X Dashboard widgets.
This patch makes the code for these legacy CSS vendor prefixes
enabled at runtime and only enables them when running in Dashboard
compatibility mode. This is the first step towards the plan outlined in
https://lists.webkit.org/pipermail/webkit-dev/2013-March/024085.html.
This patch also removes support for ENABLE(LEGACY_CSS_VENDOR_PREFIXES)
from the V8 bindings because V8 is never used with Dashboard.
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setLegacyCSSVendorPrefixesEnabled):
(WebCore::RuntimeEnabledFeatures::legacyCSSVendorPrefixesEnabled):
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::getCSSPropertyNamePrefix):
(WebCore::cssPropertyIDForJSCSSPropertyName):
- bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::cssPropertyInfo):
- css/CSSParser.cpp:
(WebCore::CSSParser::rewriteSpecifiers):
Source/WebKit/mac:
Enable legacy CSS vendor prefixes when we've been asked to turn on
Dashboard compatibility mode.
- WebView/WebView.mm:
(-[WebView _setDashboardBehavior:to:]):
LayoutTests:
- inspector/styles/vendor-prefixes-expected.txt:
- Update results to show our new behavior now that -apple- and -khtml- are not supported.
- platform/mac/TestExpectations:
- Skip a test that is testing that we support -apple- prefixes.
- platform/mac/fast/css/dashboard-region-parser.html:
- Update test to use -webkit- rather than -apple-.
- 1:54 PM Changeset in webkit [146024] by
-
- 2 edits in trunk/LayoutTests
fast/frames/sandboxed-iframe-navigation-allowed.html sometimes
asserts in debug.
- platform/mac/TestExpectations:
- 1:09 PM Changeset in webkit [146023] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX (r145592): AutodrainedPool.h moved to WTF
<http://webkit.org/b/112171>
Fixes the following build failure:
Source/WebCore/platform/audio/mac/AudioBusMac.mm:32:9: fatal error: 'AutodrainedPool.h' file not found
#import "AutodrainedPool.h"
1 error generated.
- platform/audio/mac/AudioBusMac.mm: Fix include.
- 11:40 AM Changeset in webkit [146022] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding failure expectations for the two reftests added in r145982, failing due to disabled subpixel layout.
Triaging/enhancing failure expectations for spellcheck tests after r145940.
- platform/gtk/TestExpectations:
- 11:15 AM WebKitGTK/2.0.x edited by
- (diff)
- 11:13 AM WebKitGTK/2.0.x edited by
- (diff)
- 11:13 AM Changeset in webkit [146021] by
-
- 6 edits in releases/WebKitGTK/webkit-2.0/Source
Merge 146017 - [GTK] Fix and improve dist hooks for translations
https://bugs.webkit.org/show_bug.cgi?id=112519
Reviewed by Carlos Garcia Campos.
Source/WebCore:
- GNUmakefile.am: move translation-related rules and lists to the po directory's
GNUmakefile.am.
Source/WebCore/platform/gtk/po:
- GNUmakefile.am: move dist-related rules here; also move translation-related files
to this file's EXTRA_DIST, making sure to only list the files we actually want
shipped, so junk such as .orig, .rej and backup files do not end up in the tarball.
Source/WebKit/gtk:
- GNUmakefile.am: removed left-over translation files from EXTRA_DIST
- 11:12 AM Changeset in webkit [146020] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0
Merge 144990 - Build fix. Fixes problems building code that uses deprecated functions from GTK+ 2,
such as RenderThemeGtk2.cpp, in debug mode. RenderThemeGtk2.cpp tries to allow usage
of deprecated functions by undefining GTK_DISABLE_DEPRECATED, but it ended up being
redefined because autotoolsconfig.h was included again by headers that came after
config.h.
Reviewed by Martin Robinson.
- Source/autotools/SetupWebKitFeatures.m4: add checks to ensure the
autotoolsconfig.h header is only included once.
- 11:11 AM Changeset in webkit [146019] by
-
- 2 edits in trunk/Tools
Add reload button (and F5 accelerator) to the GtkLauncher toolbar
https://bugs.webkit.org/show_bug.cgi?id=112442
Patch by Morten Stenshorne <mstensho@opera.com> on 2013-03-17
Reviewed by Gustavo Noronha Silva.
- GtkLauncher/main.c:
(reloadCb):
(createToolbar):
(createWindow):
- 11:11 AM Changeset in webkit [146018] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r146011 - [GTK] Invalid charset encoding using when substituting a misspelled word in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112517
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-17
Reviewed by Alexey Proskuryakov.
The problem is that we are creating the WebContextMenuItemData
with the GtkAction label as UTF-8.
- UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::contextMenuItemActivatedCallback): Use String::fromUTF8()
to convert the GtkAction label to UTF-16.
- 11:10 AM Changeset in webkit [146017] by
-
- 6 edits in trunk/Source
[GTK] Fix and improve dist hooks for translations
https://bugs.webkit.org/show_bug.cgi?id=112519
Reviewed by Carlos Garcia Campos.
Source/WebCore:
- GNUmakefile.am: move translation-related rules and lists to the po directory's
GNUmakefile.am.
Source/WebCore/platform/gtk/po:
- GNUmakefile.am: move dist-related rules here; also move translation-related files
to this file's EXTRA_DIST, making sure to only list the files we actually want
shipped, so junk such as .orig, .rej and backup files do not end up in the tarball.
Source/WebKit/gtk:
- GNUmakefile.am: removed left-over translation files from EXTRA_DIST
- 11:06 AM Changeset in webkit [146016] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore
Merge r146010 - [ENCHANT] Invalid charset encoding used for spelling guess context menu items
https://bugs.webkit.org/show_bug.cgi?id=112516
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-17
Reviewed by Gustavo Noronha Silva.
Convert spelling guesses returned by enchant to UTF-16 before
passing them to WebCore.
- platform/text/enchant/TextCheckerEnchant.cpp:
(WebCore::TextCheckerEnchant::getGuessesForWord): Use
String::fromUTF8().
- 10:22 AM Changeset in webkit [146015] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=97124
Mark a couple of WK2 tests as possibly asserting in debug.
- platform/mac-wk2/TestExpectations:
- 10:14 AM Changeset in webkit [146014] by
-
- 3 edits in trunk/Source/WebCore
Move font-family applying code to StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=112441
Reviewed by Allan Sandfeld Jensen.
Many of the font related properties were moved to StyleBuilder in r87362
two years ago. Move font-family as well so that all font properties are
handled the same way.
No new tests, no change in functionality.
- css/StyleBuilder.cpp:
(ApplyPropertyFontFamily):
(WebCore::ApplyPropertyFontFamily::applyInheritValue):
(WebCore::ApplyPropertyFontFamily::applyInitialValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontFamily::createHandler):
(WebCore::StyleBuilder::StyleBuilder):
Add ApplyPropertyFontFamily for CSSPropertyFontFamily.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Remove CSSPropertyFontFamily from the giant switch statement.
- 10:12 AM Changeset in webkit [146013] by
-
- 2 edits in trunk/Source/Platform
[chromium] Remove the zoom filter operation ifdef
https://bugs.webkit.org/show_bug.cgi?id=112390
Reviewed by Darin Fisher.
This ifdef is not needed once the change that introduced it is
rolled into chromium, and the chromium side guards on the ifdef
are removed. Then it just does nothing and should be deleted.
- chromium/public/WebFilterOperation.h:
- 10:12 AM Changeset in webkit [146012] by
-
- 1 edit in branches/chromium/1441/Source/WebCore/rendering/RenderLayer.cpp
Revert 143825 "RenderLayer::scrollTo() should call FrameLoaderCl..."
RenderLayer::scrollTo() should call FrameLoaderClient::didChangeScrollOffset()
https://bugs.webkit.org/show_bug.cgi?id=110673
-and corresponding-
<rdar://problem/13258596>
Reviewed by Sam Weinig.
FrameLoaderClient::didChangeScrollOffset() doesn't get called for web pages that
have overflow on the body. We can easily address this by calling it at the
end of RenderLayer::scrollTo().
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
TBR=Beth Dakin
Review URL: https://codereview.chromium.org/12851007
- 9:49 AM Changeset in webkit [146011] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Invalid charset encoding using when substituting a misspelled word in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112517
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-17
Reviewed by Alexey Proskuryakov.
The problem is that we are creating the WebContextMenuItemData
with the GtkAction label as UTF-8.
- UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::contextMenuItemActivatedCallback): Use String::fromUTF8()
to convert the GtkAction label to UTF-16.
- 9:25 AM Changeset in webkit [146010] by
-
- 2 edits in trunk/Source/WebCore
[ENCHANT] Invalid charset encoding used for spelling guess context menu items
https://bugs.webkit.org/show_bug.cgi?id=112516
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-17
Reviewed by Gustavo Noronha Silva.
Convert spelling guesses returned by enchant to UTF-16 before
passing them to WebCore.
- platform/text/enchant/TextCheckerEnchant.cpp:
(WebCore::TextCheckerEnchant::getGuessesForWord): Use
String::fromUTF8().
- 9:21 AM Changeset in webkit [146009] by
-
- 2 edits in trunk/LayoutTests
Mark some more tests as asserting in debug, because of
https://bugs.webkit.org/show_bug.cgi?id=105986
- platform/mac/TestExpectations:
- 9:11 AM Changeset in webkit [146008] by
-
- 2 edits in trunk/LayoutTests
Occasional assertion in JSNPObject::invalidate() running plugins/object-embed-plugin-scripting.html
https://bugs.webkit.org/show_bug.cgi?id=112518
Mark this test as [ Crash Pass ] in debug.
- platform/mac/TestExpectations:
- 9:09 AM WebKitGTK/2.0.x edited by
- (diff)
- 9:09 AM WebKitGTK/2.0.x edited by
- (diff)
- 7:35 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:44 AM Changeset in webkit [146007] by
-
- 3 edits2 adds in trunk/Source/WebCore
[EFL] Provide default cursor groups as cursor.edc
https://bugs.webkit.org/show_bug.cgi?id=112403
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-03-17
Reviewed by Gyuyoung Kim.
This patch provides a cursor.edc to use the CSS cursor images files in the
WebCore/Resources directory. cursor.edc is included in the default.edc
so that views can use it by default.
- platform/efl/DefaultTheme/CMakeLists.txt:
- platform/efl/DefaultTheme/default.edc:
- platform/efl/DefaultTheme/widget/cursor/cursor.edc: Added.
- 2:17 AM WebKitGTK/2.0.x edited by
- (diff)
Mar 16, 2013:
- 11:46 PM Changeset in webkit [146006] by
-
- 8 edits in trunk/Source
Disable High DPI Canvas on iOS
https://bugs.webkit.org/show_bug.cgi?id=112511
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 10:26 PM Changeset in webkit [146005] by
-
- 5 edits in trunk/Source/WebKit/chromium
Unreviewed, rolling out r145898.
http://trac.webkit.org/changeset/145898
https://bugs.webkit.org/show_bug.cgi?id=112512
Causing flakiness on webkit_unit_tests on android bots on
chromium.webkit and chromium.linux (Requested by jochen on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-16
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::applyScrollAndScale):
- src/WebViewImpl.h:
(WebViewImpl):
- tests/WebFrameTest.cpp:
- tests/WebViewTest.cpp:
- 2:26 PM Changeset in webkit [146004] by
-
- 2 edits in trunk/LayoutTests
http/tests/notifications/legacy/window-show-on-click.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=112499
- platform/mac/TestExpectations:
- 1:47 PM Changeset in webkit [146003] by
-
- 2 edits in trunk/Source/WebKit/chromium
Remove redundant checks from WebInputEvent::isGestureEventType
https://bugs.webkit.org/show_bug.cgi?id=112503
Reviewed by Darin Fisher.
GesturePinchBegin, GesturePinchEnd and GesturePinchUpdate were checked
for twice.
This was found by experimenting with a potential new Clang warning.
- public/WebInputEvent.h:
(WebKit::WebInputEvent::isGestureEventType):
- 12:43 PM Changeset in webkit [146002] by
-
- 2 edits in trunk/LayoutTests
inspector/elements/highlight-node-scaled.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=112502
Mark this test as flakey.
- platform/mac/TestExpectations:
- 12:32 PM Changeset in webkit [146001] by
-
- 2 edits in trunk/Source/WebCore
Reflected video elements hit assertion
https://bugs.webkit.org/show_bug.cgi?id=112490
Disable reflections on video again, since there's some bad behavior
caused by an underlying system framework.
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::clone):
- 12:20 PM Changeset in webkit [146000] by
-
- 2 edits in trunk/LayoutTests
svg/batik/paints/gradientLimit.svg is flakey. Also fix
a couple of recent typos in TestExpectations.
- platform/mac/TestExpectations:
- 12:10 PM Changeset in webkit [145999] by
-
- 2 edits in trunk/LayoutTests
Notification test is flakey
https://bugs.webkit.org/show_bug.cgi?id=112499
- platform/mac/TestExpectations:
- 12:10 PM Changeset in webkit [145998] by
-
- 2 edits in trunk/LayoutTests
Another slow sputnik test.
- platform/mac/TestExpectations:
- 11:19 AM Changeset in webkit [145997] by
-
- 2 edits in trunk/LayoutTests
Fix typos. Also mark fast/frames/flattening/frameset-flattening-advanced.html
as flakey.
- platform/mac/TestExpectations:
- 11:00 AM Changeset in webkit [145996] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=93560
These WebGL tests are flakey on Lion too.
- platform/mac-lion/TestExpectations:
- 10:56 AM Changeset in webkit [145995] by
-
- 2 edits in trunk/LayoutTests
Change fast/events/controlclick-no-onclick.html to be a skip rather than a fail,
since it times out.
- platform/mac-wk2/TestExpectations:
- 10:08 AM Changeset in webkit [145994] by
-
- 3 edits2 adds in trunk
[v8] Disable binding integrity check for WebCore::Text
https://bugs.webkit.org/show_bug.cgi?id=112462
Reviewed by Kentaro Hara.
Source/WebCore:
Test: fast/dom/split-cdata.xml
- dom/Text.idl:
LayoutTests:
- fast/dom/split-cdata-expected.txt: Added.
- fast/dom/split-cdata.xml: Added.
- 9:43 AM Changeset in webkit [145993] by
-
- 2 edits10 adds2 deletes in trunk/LayoutTests
fast/frames/sandboxed-iframe-scripting is flakey
https://bugs.webkit.org/show_bug.cgi?id=112482
Reviewed by Simon Fraser.
Tests that rely on multiple 'iframe' elements loading in a specific
order are a Bad Idea™. This patch splits
'fast/frames/sandboxed-iframe-scripting.html' out into five tests, and
changes two of them (#2 and #4) to use message passing in order to
test in a way that 'js-test-{pre,post}' can cleanly report.
- fast/frames/sandboxed-iframe-scripting-01-expected.txt: Added.
- fast/frames/sandboxed-iframe-scripting-01.html: Added.
- fast/frames/sandboxed-iframe-scripting-02-expected.txt: Added.
- fast/frames/sandboxed-iframe-scripting-02.html: Added.
- fast/frames/sandboxed-iframe-scripting-03-expected.txt: Added.
- fast/frames/sandboxed-iframe-scripting-03.html: Added.
- fast/frames/sandboxed-iframe-scripting-04-expected.txt: Added.
- fast/frames/sandboxed-iframe-scripting-04.html: Added.
- fast/frames/sandboxed-iframe-scripting-05-expected.txt: Added.
- fast/frames/sandboxed-iframe-scripting-05.html: Added.
- fast/frames/sandboxed-iframe-scripting-expected.txt: Removed.
- fast/frames/sandboxed-iframe-scripting.html: Removed.
- platform/mac/TestExpectations:
Remove the skipped test, since it no longer exists.
- 9:41 AM Changeset in webkit [145992] by
-
- 2 edits in trunk/LayoutTests
Update test expectations for content shell.
Unreviewed gardening.
- platform/chromium/ContentShellTestExpectations:
- 8:50 AM Changeset in webkit [145991] by
-
- 2 edits in trunk/LayoutTests
Mark some ref tests as failing on Lion.
- platform/mac-lion/TestExpectations:
- 8:45 AM Changeset in webkit [145990] by
-
- 2 edits in trunk/LayoutTests
Mark some more sputnik tests as slow in debug.
- platform/mac/TestExpectations:
- 7:26 AM BadContent edited by
- Blacklist a spamming account. (diff)
- 4:21 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:18 AM Changeset in webkit [145989] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore
Merge r145808 - [GTK] Wrong ASSERT in AudioDestinationGstreamer::stop
https://bugs.webkit.org/show_bug.cgi?id=112344
Patch by Xan Lopez <xlopez@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.
Correct erroneous ASSERT, we want both member variables to exist.
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestinationGStreamer::stop):
- 1:51 AM Changeset in webkit [145988] by
-
- 27 edits2 adds in trunk
AX: aria-hidden on container does not hide descendant popup buttons
https://bugs.webkit.org/show_bug.cgi?id=112373
Reviewed by Ryosuke Niwa.
Source/WebCore:
There are a number of subclass AX objects that implement accessibilityIsIgnored()
to always return false. This means that even if their parent is aria-hidden=true
they still show up in the tree.
This re-organizes this base case of aria-hidden into AccessibilityObject so that
it can be re-used by these special subclasses where appropriate.
Test: accessibility/aria-hidden-hides-all-elements.html
- accessibility/AccessibilityImageMapLink.h:
(WebCore::AccessibilityImageMapLink::isImageMapLink):
- accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::computeAccessibilityIsIgnored):
- accessibility/AccessibilityListBox.cpp:
(WebCore):
- accessibility/AccessibilityListBox.h:
(AccessibilityListBox):
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::computeAccessibilityIsIgnored):
- accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControl::computeAccessibilityIsIgnored):
(WebCore::AccessibilityMediaControlsContainer::computeAccessibilityIsIgnored):
(WebCore::AccessibilityMediaTimeDisplay::computeAccessibilityIsIgnored):
- accessibility/AccessibilityMediaControls.h:
(AccessibilityMediaControlsContainer):
- accessibility/AccessibilityMenuList.h:
(WebCore::AccessibilityMenuList::roleValue):
- accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::computeAccessibilityIsIgnored):
- accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::computeAccessibilityIsIgnored):
- accessibility/AccessibilityMockObject.cpp:
(WebCore::AccessibilityMockObject::computeAccessibilityIsIgnored):
(WebCore):
- accessibility/AccessibilityMockObject.h:
(AccessibilityMockObject):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::accessibilityIsIgnoredDefaultForObject):
(WebCore):
(WebCore::AccessibilityObject::ariaIsHidden):
(WebCore::AccessibilityObject::accessibilityIsIgnoredBase):
- accessibility/AccessibilityObject.h:
(AccessibilityObject):
- accessibility/AccessibilityProgressIndicator.cpp:
(WebCore::AccessibilityProgressIndicator::computeAccessibilityIsIgnored):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredBase):
(WebCore::AccessibilityRenderObject::addImageMapChildren):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
- accessibility/AccessibilityScrollbar.h:
(AccessibilityScrollbar):
- accessibility/AccessibilitySlider.cpp:
(WebCore):
(WebCore::AccessibilitySliderThumb::computeAccessibilityIsIgnored):
- accessibility/AccessibilitySlider.h:
(AccessibilitySlider):
- accessibility/AccessibilitySpinButton.h:
(WebCore::AccessibilitySpinButton::roleValue):
(AccessibilitySpinButtonPart):
LayoutTests:
- accessibility/aria-hidden-hides-all-elements-expected.txt: Added.
- accessibility/aria-hidden-hides-all-elements.html: Added.
- 12:43 AM Changeset in webkit [145987] by
-
- 1 edit4 adds1 delete in trunk/LayoutTests
Mac rebaseline after r145977.
- platform/chromium-mac/platform/mac/fast: Added.
- platform/chromium-mac/platform/mac/fast/forms: Added.
- platform/chromium-mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Added.
- platform/chromium/platform/mac/fast/forms: Removed.
- platform/chromium/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Removed.
- platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Added.
