Timeline
Mar 26, 2013:
- 11:39 PM Changeset in webkit [146967] by
-
- 3 edits2 adds in trunk
[shadow] styleForText should consider the case where parent node has no style
https://bugs.webkit.org/show_bug.cgi?id=113275
Source/WebCore:
If a text node is distributed, its parent node for rendering and
styling might have no style. In the case, styleForText should return
default style.
Reviewed by Hajime Morrita.
Test: fast/dom/shadow/text-node-distributed-crash.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForText):
Check whether a parent node has any style or not. If not, return
default style. This is the same behavior as styleForElement.
LayoutTests:
Reviewed by Hajime Morrita.
- fast/dom/shadow/text-node-distributed-crash-expected.txt: Added.
- fast/dom/shadow/text-node-distributed-crash.html: Added.
- 11:02 PM Changeset in webkit [146966] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Rebaseline fast/replaced/border-radius-clip-content-edge.html
- platform/chromium-win/fast/replaced/border-radius-clip-content-edge-expected.png:
- 10:03 PM Changeset in webkit [146965] by
-
- 2 edits in trunk/Source/WebCore
Make SocketStreamHandle (Chromium port) fully use IPC window in send()
https://bugs.webkit.org/show_bug.cgi?id=113304
Patch by Takeshi Yoshino <tyoshino@chromium.org> on 2013-03-26
Reviewed by Kent Tamura.
socket_stream of Chromium buffers send data up to 32KiB (exact) bytes.
However, SocketStreamHandleInternal::send() method now keeps in-flight
send data not greater than m_maxPendingSendAllowed - 1 that is
32KiB - 1. This means that SocketStreamHandleInternal consumes the
buffered data in SocketStreamHandleBase by 32KiB - 1. It makes memory
copy operations unaligned unnecessarily. It should just use the
allowed size fully.
- platform/network/chromium/SocketStreamHandle.cpp:
(WebCore::SocketStreamHandleInternal::send):
(WebCore):
- 8:49 PM Changeset in webkit [146964] by
-
- 2 edits in trunk/Source/WTF
RefCountedArray needs a size based constructor
https://bugs.webkit.org/show_bug.cgi?id=113277
Reviewed by Benjamin Poulain.
Simple patch to add a size based constructor for RefCountedArray
so that we can create an sharable array without a copy.
- wtf/RefCountedArray.h:
(RefCountedArray):
(WTF::RefCountedArray::RefCountedArray):
- 8:02 PM Changeset in webkit [146963] by
-
- 3 edits in trunk/LayoutTests
Rebaseline expectations for fast/replaced/border-radius-clip-content-edge.html
Unreviewed rebaseline of test expectations after r146955
- platform/chromium-linux/fast/replaced/border-radius-clip-content-edge-expected.png:
- platform/chromium-mac/fast/replaced/border-radius-clip-content-edge-expected.png:
- 7:49 PM Changeset in webkit [146962] by
-
- 2 edits in trunk/Source/WebKit/mac
Unreviewed attempted cr-mac build fix.
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 7:40 PM Changeset in webkit [146961] by
-
- 41 edits in trunk/Source
Allow ShadowContents in HitTests by default.
https://bugs.webkit.org/show_bug.cgi?id=113171
Reviewed by Dimitri Glazkov.
Source/WebCore:
HitTestRequest is widely used in WebCore, but AllowShadowContents
flag is not turned on by default. In most places, we can set the
flag on.
This change makes HitTests allow shadow contents by default.
To track all existing HitTests which do not allow shadow contents,
and discourage such a HitTest in the future, I've introduced
disallowShadowContenet flag so that callers must turn on this flag
explicitly if they want to disallow shadow contents in their HitTests.
This change should be refactoring and should not include any
behavior changes. After this change, we'll investigate each place
where disallowShadowContents is used step by step and get rid of
the flag if it is okay to remove.
No new tests, no behavior change.
- dom/Document.h:
(Document):
- dom/TreeScope.cpp:
(WebCore::nodeFromPoint):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::contains):
- page/DragController.cpp:
(WebCore::elementUnderMouse):
(WebCore::DragController::canProcessDrag):
(WebCore::DragController::startDrag):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::updateSelectionForMouseDrag):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::isInsideScrollbar):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureLongPress):
(WebCore::EventHandler::handleGestureScrollBegin):
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::hoverTimerFired):
(WebCore::EventHandler::dragSourceEndedAt):
(WebCore::EventHandler::handleDrag):
(WebCore::EventHandler::handleTouchEvent):
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):
- page/EventHandler.h:
(EventHandler):
- page/FocusController.cpp:
(WebCore::updateFocusCandidateIfNeeded):
- page/Frame.cpp:
(WebCore::Frame::visiblePositionForPoint):
- page/TouchDisambiguation.cpp:
(WebCore::findGoodTouchTargets):
- rendering/HitTestRequest.h:
(WebCore::HitTestRequest::disallowsShadowContent):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::hitTestClipContent):
- testing/Internals.cpp:
(WebCore::Internals::nodesFromRect):
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::hitTestResult):
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::getNodesFromRect):
- WebKitSupport/ProximityDetector.cpp:
(BlackBerry::WebKit::ProximityDetector::findBestPoint):
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
Source/WebKit/chromium:
- src/ContextMenuClientImpl.cpp:
(WebKit::selectMisspelledWord):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::visiblePositionForWindowPoint):
- src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::isRectTopmost):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::computeBlockBounds):
(WebKit::WebViewImpl::bestTapNode):
Source/WebKit/efl:
- ewk/ewk_frame.cpp:
(ewk_frame_hit_test_new):
Source/WebKit/gtk:
- webkit/webkitwebinspector.cpp:
(webkit_web_inspector_inspect_coordinates):
- webkit/webkitwebview.cpp:
(prepareMouseEventForFrame):
(webkit_web_view_get_hit_test_result):
Source/WebKit/mac:
- WebView/WebFrame.mm:
(-[WebFrame elementAtPoint:]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView elementAtPoint:allowShadowContent:]):
Source/WebKit/qt:
- WebCoreSupport/QWebFrameAdapter.cpp:
(QWebFrameAdapter::hitTestContent):
Source/WebKit/win:
- WebView.cpp:
(WebView::gestureNotify):
Source/WebKit2:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::hitTest):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::highlightPotentialActivation):
(WebKit::WebPage::findZoomableAreaForPoint):
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::shouldDelayWindowOrderingEvent):
(WebKit::WebPage::acceptsFirstMouse):
- 7:20 PM Changeset in webkit [146960] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Memory leak in WebPagePrivate.cpp - NavigatorContentUtilsClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=112996
Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-03-26
Reviewed by Rob Buis.
PR 312552
Internally Reviewed by Anthony Scian.
NavigatorContentUtilsClientBlackBerry is new'ed in WebPagePrivate::init(),
but not deleted anywhere. Fixed by creating an OwnPtr for it.
Also fixed some webkit-style errors.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
- Api/WebPage_p.h:
(WebCore):
(WebPagePrivate):
- 7:20 PM Changeset in webkit [146959] by
-
- 5 edits2 copies2 deletes in branches/chromium/1410
Merge 146940 "Non-paintsContent fixed position layer should not ..."
Non-paintsContent fixed position layer should not cause slow scrolling
https://bugs.webkit.org/show_bug.cgi?id=113238
Reviewed by James Robinson.
Source/WebCore:
Added NotCompositedForNoVisibleContent in ViewportConstrainedNotCompositedReason and set it in RLC.
Test: compositing/layer-creation/fixed-position-no-content-scroll-reason.html
- rendering/RenderLayer.h: Add NotCompositedForNoVisibleContent.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition): Set NotCompositedForNoVisibleContent reason when the fixed position layer has no visible content.
LayoutTests:
- compositing/layer-creation/fixed-position-no-content-scroll-reason-expected.txt: Added.
- compositing/layer-creation/fixed-position-no-content-scroll-reason.html: Copied from LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html. Test case for the bug.
- compositing/layer-creation/fixed-position-in-view-dynamic.html: Set background of fixed layer to distinguish out-of-view case from no-content case.
- compositing/layer-creation/fixed-position-out-of-view-dynamic.html: Ditto.
- compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html: Ditto.
- platform/chromium/compositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Removed. This was a wrong rebaseline related to this bug.
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Removed. This was a wrong rebaseline related to this bug.
TBR=wangxianzhu@chromium.org
Review URL: https://codereview.chromium.org/12499009
- 6:22 PM Changeset in webkit [146958] by
-
- 2 edits in trunk/LayoutTests
Greening the mac bots.
https://bugs.webkit.org/show_bug.cgi?id=113361.
Not Reviewed.
- platform/mac/TestExpectations:
- 6:21 PM Changeset in webkit [146957] by
-
- 6 edits5 deletes in trunk/Source
[chromium] Remove the WebVideoFrame, WebVideoFrameProvider, WebStreamTextureClient, and WebVideoLayer classes.
https://bugs.webkit.org/show_bug.cgi?id=112483
Reviewed by James Robinson.
Source/Platform:
These classes are no longer used, so remove them. And remove APIs
to provide them.
- Platform.gypi:
- chromium/public/WebCompositorSupport.h:
(WebKit):
- chromium/public/WebVideoFrame.h: Removed.
- chromium/public/WebVideoFrameProvider.h: Removed.
- chromium/public/WebVideoLayer.h: Removed.
Source/WebKit/chromium:
These classes are no longer used, so remove them.
- WebKit.gyp:
- public/WebMediaPlayer.h:
(WebKit):
(WebMediaPlayer):
- public/WebStreamTextureClient.h: Removed.
- public/WebVideoFrame.h: Removed.
- 6:20 PM Changeset in webkit [146956] by
-
- 14 edits in trunk
[ca] Tell CA to clean up unused resources if a given WebProcess won't be drawing
https://bugs.webkit.org/show_bug.cgi?id=107539
<rdar://problem/13032692>
Reviewed by Simon Fraser.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Update WebCoreSystemInterface.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Initially move the Page out of the window if necessary;
Page defaults to in-window, which is wrong in many cases - we depend on
Page::isInWindow being accurate to decide whether WebPage::setIsInWindow is actually
a state change or not.
(WebKit::WebPage::setIsInWindow):
- WebProcess/WebProcess.cpp: Inform WebProcess when we go on/off screen.
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::pageDidMoveOnscreen): Keep track of the number of on-screen pages in this process.
(WebKit::WebProcess::pageWillMoveOffscreen): If the number of on-screen pages drops to zero, clean up unused rendering resources.
- WebProcess/WebProcess.h:
Update WebSystemInterface.
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- 6:00 PM Changeset in webkit [146955] by
-
- 10 edits in trunk
Test if non-immediate descendants obscure background
https://bugs.webkit.org/show_bug.cgi?id=113137
Reviewed by Simon Fraser.
Source/WebCore:
The current obscuration test only covers immediate children. We can find more cases by looking deeper into descendants.
The patch makes the test sufficiently smart to stop a heavy fully obscured gif animation on micrsoft.com.
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::animationAdvanced):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
Invalidate parents to max test depth.
(WebCore::RenderBox::backgroundPaintedExtent):
Background painting is pixel snapped.
(WebCore::isCandidateForOpaquenessTest):
(WebCore::RenderBox::foregroundIsKnownToBeOpaqueInRect):
Separate foreground testing and make it recursive.
Add fast bailout for common static positioned case.
Remove maximum child count, the fast bailouts should prevent long tests.
Add maximum depth so we know how deep we need to invalidate in styleDidChange.
(WebCore::RenderBox::computeBackgroundIsKnownToBeObscured):
(WebCore):
- rendering/RenderBox.h:
(RenderBox):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::foregroundIsKnownToBeOpaqueInRect):
(WebCore):
(WebCore::RenderImage::computeBackgroundIsKnownToBeObscured):
- rendering/RenderImage.h:
(RenderImage):
LayoutTests:
- fast/backgrounds/obscured-background-child-style-change-expected.html:
- fast/backgrounds/obscured-background-child-style-change.html:
- fast/repaint/obscured-background-no-repaint-expected.txt:
- fast/repaint/obscured-background-no-repaint.html:
- 5:59 PM Changeset in webkit [146954] by
-
- 2 edits in trunk/Source/WebCore
Regression (r145601): out-of-bounds read in line breaking / new width cache
https://bugs.webkit.org/show_bug.cgi?id=113347
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-26
Reviewed by Geoffrey Garen.
The values zero and 0xffff have special values with the default HashTraits. Those values
are also valid values for UChar.
To avoid any table inconsitency, switch from UChar to uint32_t as the key type for
the WidthCache's single char map. The traits is also changed to allow zero as a normal
value.
This makes no space or time change over the previous code because:
-The struct KeyValuePair was already 64bits due to the ABI alignment restrictions on floats.
-The two hashes take the same number of instructions.
- platform/graphics/WidthCache.h:
(WidthCache):
- 5:43 PM Changeset in webkit [146953] by
-
- 3 edits in trunk/Source/WebCore
Make HTMLProgressElement::isDeterminate private
https://bugs.webkit.org/show_bug.cgi?id=113299
Reviewed by Kentaro Hara.
The only callsite of isDeterminate outside of HTMLProgressElement
is in StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes,
and we can replace it with Element::shouldAppearIndeterminate.
No new tests. Just a refactoring.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
Use Element::shouldAppearIndeterminate.
- html/HTMLProgressElement.h:
(HTMLProgressElement): Make isDeterminate private.
- 5:17 PM Changeset in webkit [146952] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r190706. Requested by
danakj_ via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-26
- DEPS:
- 5:15 PM Changeset in webkit [146951] by
-
- 2 edits in trunk/Source/WTF
Compile fix - OS(WINDOWS), not OS(WIN).
- wtf/ProcessID.h:
(WTF::getCurrentProcessID):
- 5:12 PM Changeset in webkit [146950] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Histogram cause of LevelDB write errors
https://bugs.webkit.org/show_bug.cgi?id=113350
Reviewed by Tony Chang.
Add histogram for source of LevelDB errors on Write in addition to
Open.
No new tests - no good way to test histogram code.
- platform/leveldb/LevelDBDatabase.cpp:
(WebCore::histogramLevelDBError):
(WebCore):
(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::write):
- 5:11 PM Changeset in webkit [146949] by
-
- 3 edits2 adds in trunk
WebKit does not expose @required or @aria-required as AXRequired on select elements
https://bugs.webkit.org/show_bug.cgi?id=113339
Reviewed by Tim Horton.
Source/WebCore:
Make sure button types can return the AXRequired attribute.
Tests: platform/mac/accessibility/aria-required-popup-button.html
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
LayoutTests:
- platform/mac/accessibility/aria-required-popup-button-expected.txt: Added.
- platform/mac/accessibility/aria-required-popup-button.html: Added.
- 5:09 PM Changeset in webkit [146948] by
-
- 2 edits in trunk/Source/WTF
Fix compile for OS(WIN) != PLATFORM(WIN)
https://bugs.webkit.org/show_bug.cgi?id=113356
Reviewed by Tim Horton.
- wtf/ProcessID.h:
(WTF::getCurrentProcessID):
- 5:03 PM Changeset in webkit [146947] by
-
- 5 edits6 adds in trunk
REGRESSION: Sometimes, operations on proven strings ignore changes to the string prototype
https://bugs.webkit.org/show_bug.cgi?id=113353
<rdar://problem/13510778>
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg and Geoffrey Garen.
ToString should call speculateStringObject() even if you know that it's a string object, since
it calls it to also get the watchpoint. Note that even with this change, if you do
Phantom(Check:StringObject:@a), it might get eliminated just because we proved that @a is a
string object (thereby eliminating the prototype watchpoint); that's fine since ToString is
MustGenerate and never decays to Phantom.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileToStringOnCell):
(JSC::DFG::SpeculativeJIT::speculateStringObject):
(JSC::DFG::SpeculativeJIT::speculateStringOrStringObject):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::speculateStringObjectForStructure):
LayoutTests:
Reviewed by Mark Hahnenberg and Geoffrey Garen.
- fast/js/jsc-test-list:
- fast/js/dfg-phantom-base-expected.txt: Added.
- fast/js/dfg-phantom-base.html: Added.
- fast/js/dfg-to-string-toString-becomes-bad-with-check-structure-expected.txt: Added.
- fast/js/dfg-to-string-toString-becomes-bad-with-check-structure.html: Added.
- 4:52 PM Changeset in webkit [146946] by
-
- 12 edits4 adds in trunk
When a primary plugin is restarted, also start similar plugins
https://bugs.webkit.org/show_bug.cgi?id=113265
Reviewed by Tim Horton.
Source/WebCore:
If we detect a primary plugin that is snapshotted, we immediately restart it.
When this happens, we should also restart any other plugins that
match the same origin and type. This allows sites with a lot of
(geometrically) nearby plugins to behave as if they are a single big plugin.
Tests: plugins/snapshotting/autoplay-similar-to-dominant-after-delay.html
plugins/snapshotting/autoplay-similar-to-dominant.html
- WebCore.exp.in: Export mimeTypeFromURL.
- html/HTMLPlugInImageElement.cpp:
(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin): Use loadedMimeType helper.
(WebCore::HTMLPlugInImageElement::restartSimilarPlugIns): New method, which copied the
existing code from userDidClickSnapshot.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Move the similar plugin detection
out into another function and call it.
(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Call restartSimilarPlugIns.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Use loadedMimeType helper.
- html/HTMLPlugInImageElement.h: Declaration of restartSimilarPlugIns.
(WebCore::HTMLPlugInImageElement::loadedMimeType): New helper method since this
code was being often duplicated.
Source/WebKit2:
Remember the origin of the primary plugin, so that we can
autostart anything that is similar.
- WebProcess/WebCoreSupport/WebPlugInClient.cpp:
(WebKit::WebPlugInClient::WebPlugInClient): Keep a pointer to the WebPage.
(WebKit::WebPlugInClient::shouldAutoStartFromOrigin): Pass the page onto the process.
- WebProcess/WebCoreSupport/WebPlugInClient.h:
(WebPlugInClient): New member variable for the WebPage we were created with.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::determinePrimarySnapshottedPlugIn): Remember the origin information
for the primary plugin.
(WebKit::WebPage::matchesPrimaryPlugIn): Returns true if we're seeing something that
looks like the primary plugin.
- WebProcess/WebPage/WebPage.h: New method matchesPrimaryPlugIn.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin): Check if the page thinks this is
the primary plugin.
- WebProcess/WebProcess.h: Accept a reference to the page in shouldPlugInAutoStartFromOrigin.
LayoutTests:
Two new tests. The first has one big plugin (that should be detected as the primary)
and then a few smaller versions (which should autostart along with the primary).
The second has one big plugin, and then adds a similar one after a short delay.
- platform/mac-wk2/plugins/snapshotting/autoplay-similar-to-dominant-after-delay-expected.txt: Added.
- platform/mac-wk2/plugins/snapshotting/autoplay-similar-to-dominant-expected.txt: Added.
- plugins/snapshotting/autoplay-similar-to-dominant-after-delay.html: Added.
- plugins/snapshotting/autoplay-similar-to-dominant.html: Added.
- 4:45 PM Changeset in webkit [146945] by
-
- 3 edits in trunk/Source/JavaScriptCore
REGRESSION(r144131): It made fast/js/regress/string-repeat-arith.html assert on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=112106
Rubber stamped by Filip Pizlo.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32): Get rid of the case for constants because
we would have done constant folding anyways on a ValueToInt32.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean): Fixed a random compile error with this flag enabled.
- 4:01 PM Changeset in webkit [146944] by
-
- 2 edits in tags/Safari-537.35.1/Source/WebCore
Rollout r146806. <rdar://problem/13202277>
- 3:50 PM Changeset in webkit [146943] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Fix test after r146938. Since CSS Exclusions is still an experimental feature, shape-inside-on-nested-container-with-unresolved-height.html
test should enable CSS Exclusions for the testrunners first.
- fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html: Set CSSExclisions enabled for DRT/WTR.
- 3:21 PM Changeset in webkit [146942] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Marked compositing/rtl/rtl-iframe-* tests as ImageOnlyFailure instead of Failure.
- platform/chromium/TestExpectations:
- 3:20 PM Changeset in webkit [146941] by
-
- 2 edits in trunk/Source/WebCore
[Windows, WinCairo] Scroll offset being applied to plugins during print operations.
https://bugs.webkit.org/show_bug.cgi?id=39889
Reviewed by Anders Carlsson.
This must be tested manually. See the issue for details.
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paintWindowedPluginIntoContext):
Revise the Windows implementation of the PluginView class
paintWindowedPluginIntoContext to use the containing window
position when computing the plugin's position for printing.
- 3:12 PM Changeset in webkit [146940] by
-
- 7 edits1 copy1 add2 deletes in trunk
Non-paintsContent fixed position layer should not cause slow scrolling
https://bugs.webkit.org/show_bug.cgi?id=113238
Reviewed by James Robinson.
Source/WebCore:
Added NotCompositedForNoVisibleContent in ViewportConstrainedNotCompositedReason and set it in RLC.
Test: compositing/layer-creation/fixed-position-no-content-scroll-reason.html
- rendering/RenderLayer.h: Add NotCompositedForNoVisibleContent.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition): Set NotCompositedForNoVisibleContent reason when the fixed position layer has no visible content.
LayoutTests:
- compositing/layer-creation/fixed-position-no-content-scroll-reason-expected.txt: Added.
- compositing/layer-creation/fixed-position-no-content-scroll-reason.html: Copied from LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html. Test case for the bug.
- compositing/layer-creation/fixed-position-in-view-dynamic.html: Set background of fixed layer to distinguish out-of-view case from no-content case.
- compositing/layer-creation/fixed-position-out-of-view-dynamic.html: Ditto.
- compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html: Ditto.
- platform/chromium/compositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Removed. This was a wrong rebaseline related to this bug.
- platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Removed. This was a wrong rebaseline related to this bug.
- 3:09 PM Changeset in webkit [146939] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Marked compositing/iframes/scrolling-iframe.html flaky on all platforms.
- platform/chromium/TestExpectations:
- 3:08 PM Changeset in webkit [146938] by
-
- 3 edits2 adds in trunk
[CSS Exclusions] The radius of a circle should be computed based on the shorter available dimension
https://bugs.webkit.org/show_bug.cgi?id=113255
Reviewed by Julien Chaffraix.
When we decide what should be the radius of a circle, we should choose the smallest available space. For instance when the
width or height is not resolvable for the circle we should not have a radius for it. This change modifies the behavior to
use the smaller available space, so we won't render unnecessary circle shapes.
Source/WebCore:
Test: fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html
- rendering/ExclusionShape.cpp:
(WebCore::ExclusionShape::createExclusionShape):
LayoutTests:
- fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html: Added.
- 3:04 PM Changeset in webkit [146937] by
-
- 2 edits in trunk/Source/WebCore
Make the Web Inspector console work in strict mode with JavaScriptCore.
https://webkit.org/b/65829
rdar://problem/11271238
Reviewed by Joseph Pecoraro.
- inspector/InjectedScriptSource.js:
(InjectedScript.prototype._evaluateOn): Don't use 'eval' parameter (it isn't
allowed in strict mode). Swap window.eval with our known eval instead.
- 3:03 PM Changeset in webkit [146936] by
-
- 23 edits in trunk/LayoutTests
Clean up last failing expectations from solid color layer patch.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- 3:03 PM Changeset in webkit [146935] by
-
- 8 edits in trunk/Source
Heap-use-after-free regression
https://bugs.webkit.org/show_bug.cgi?id=113337
Reviewed by Abhishek Arya and Alexey Proskuryakov.
Source/WebCore:
Use RefPtr instead of raw pointer in m_associatedFormControls.
- dom/Document.cpp:
(WebCore::Document::didAssociateFormControlsTimerFired):
- dom/Document.h:
(Document):
- loader/EmptyClients.h:
(WebCore::EmptyChromeClient::didAssociateFormControls):
- page/ChromeClient.h:
(WebCore::ChromeClient::didAssociateFormControls):
Source/WebKit/chromium:
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::didAssociateFormControls):
- src/ChromeClientImpl.h:
(ChromeClientImpl):
- 2:46 PM Changeset in webkit [146934] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Include accelerated compositing layers in screen captures.
https://bugs.webkit.org/show_bug.cgi?id=113335
Patch by Mike Lattanzio <mlattanzio@blackberry.com> on 2013-03-26
Reviewed by Rob Buis.
PR# 280374
Include accelerated compositing layers in screen captures.
Reviewed Internally By: Jakob Petsovits
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(BlackBerry::WebKit::BackingStore::drawContents):
- Api/BackingStore_p.h:
- 2:46 PM Changeset in webkit [146933] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSC_enableProfiler=true should also cause JSGlobalData to save the profiler output somewhere
https://bugs.webkit.org/show_bug.cgi?id=113144
Reviewed by Geoffrey Garen.
Forgot to include Geoff's requested change in the original commit.
- profiler/ProfilerDatabase.cpp:
(Profiler):
- 2:43 PM Changeset in webkit [146932] by
-
- 14 edits1 add in trunk/Source
JSC_enableProfiler=true should also cause JSGlobalData to save the profiler output somewhere
https://bugs.webkit.org/show_bug.cgi?id=113144
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
Added the ability to save profiler output with JSC_enableProfiler=true. It will save it
to the current directory, or JSC_PROFILER_PATH if the latter was specified.
This works by saving the Profiler::Database either when it is destroyed or atexit(),
whichever happens first.
This allows use of the profiler from any WebKit client.
- jsc.cpp:
(jscmain):
- profiler/ProfilerDatabase.cpp:
(Profiler):
(JSC::Profiler::Database::Database):
(JSC::Profiler::Database::~Database):
(JSC::Profiler::Database::registerToSaveAtExit):
(JSC::Profiler::Database::addDatabaseToAtExit):
(JSC::Profiler::Database::removeDatabaseFromAtExit):
(JSC::Profiler::Database::performAtExitSave):
(JSC::Profiler::Database::removeFirstAtExitDatabase):
(JSC::Profiler::Database::atExitCallback):
- profiler/ProfilerDatabase.h:
(JSC::Profiler::Database::databaseID):
(Database):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
Source/WTF:
Reviewed by Geoffrey Garen.
I got tired of the fact that getpid(2) is not a syscall on Windows (unless you do
_getpid() I believe), so I wrote a header that abstracts it. I also changed existing
code that uses getpid() to use WTF::getCurrentProcessID().
- GNUmakefile.list.am:
- WTF.gypi:
- WTF.pro:
- WTF.vcproj/WTF.vcproj:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::dumpProfile):
- wtf/ProcessID.h: Added.
(WTF):
(WTF::getCurrentProcessID):
- wtf/text/StringImpl.cpp:
(WTF::StringStats::printStats):
- 2:42 PM Changeset in webkit [146931] by
-
- 2 edits in trunk/Source/WebKit2
Follow-up to:
<rdar://problem/13194263> Crashes in NetworkProcess due to threading issues
https://bugs.webkit.org/show_bug.cgi?id=113256
Reviewed by Mark Rowe.
- NetworkProcess/NetworkResourceLoader.h: Added some forgotten OVERRIDEs.
- 2:29 PM Changeset in webkit [146930] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Set mouse document position for mouse event in updateCursor
https://bugs.webkit.org/show_bug.cgi?id=109094
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-03-26
Reviewed by Rob Buis.
Internally Reviewed by Jakob Petsovits.
Mouse content position should be in document coordinate.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::updateCursor):
- 2:27 PM Changeset in webkit [146929] by
-
- 24 edits2 copies1 add in trunk/Source
<rdar://problem/13194263> Crashes in NetworkProcess due to threading issues
https://bugs.webkit.org/show_bug.cgi?id=113256
Reviewed by Brady Eidson.
Added a new code path in ResourceHandle/ResourceHandleClient that doesn't need
blocking calls. Implemented it for NSURLConnection by changing NSOperationQueue
version to forward calls to main thread.
- 2:26 PM Changeset in webkit [146928] by
-
- 2 edits in trunk/Source/WebKit2
[wk2] Don't send intrinsic content size updates more than once per runloop
https://bugs.webkit.org/show_bug.cgi?id=113258
<rdar://problem/13492038>
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
Only start the zero-delay timer if it's not already active.
- 2:13 PM Changeset in webkit [146927] by
-
- 2 edits in trunk/LayoutTests
Convert test from UTF-16 to UTF-8
Rubber stamped by James Robinson.
- fast/dom/34176.html: Convert from little endian UTF-16 to UTF-8
to make git diff happy.
- 1:40 PM Changeset in webkit [146926] by
-
- 3 edits in trunk/Tools
Flakiness dashboard: simplify logic around which tests to show.
https://bugs.webkit.org/show_bug.cgi?id=113250
Reviewed by Ojan Vafai.
The different filters for showing results are only used for layout
tests, otherwise, we show everything.
Change the defaults to false (what layout tests used), and only
look at the values when viewing layout tests.
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(htmlForTestsWithExpectationsButNoFailures):
(shouldHideTest):
- 1:33 PM Changeset in webkit [146925] by
-
- 21 edits10 copies1 add1 delete in trunk/LayoutTests
Rebaseline text output for opaque GraphicsLayers
https://bugs.webkit.org/show_bug.cgi?id=109507
Unreviewed rebaseline.
- platform/chromium-linux-x86/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Removed.
- platform/chromium-linux/compositing/overflow/composited-scrolling-paint-phases-expected.txt:
- platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
- platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
- platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
- platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-mac/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-win/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt.
- platform/chromium/TestExpectations:
- platform/chromium/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt.
- platform/chromium/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt.
- platform/chromium/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt.
- platform/chromium/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt.
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt:
- platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt.
- platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt.
- platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt.
- platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt.
- 1:29 PM Changeset in webkit [146924] by
-
- 15 edits in trunk/Source
Autogenerate the scrollAnimatorEnabled setting in Settings.in
https://bugs.webkit.org/show_bug.cgi?id=113253
Reviewed by James Robinson.
Source/WebCore:
Convert scrollAnimatorEnabled into an autogenerated setting. This involves renaming
the setter from setEnableScrollAnimator(bool) to setScrollAnimatorEnabled(bool) and
updating the callers. I didn't change any WebKit API methods.
Also remove the code in InternalSettings since it's never used and will now be
autogenerated with proper resetting code.
No new tests, this is a refactor and should compile.
- page/Settings.cpp:
(WebCore::Settings::Settings): Remove code that is now autogenerated.
- page/Settings.h:
(Settings): Remove code that is now autogenerated.
- page/Settings.in: Add entry for scrollAnimatorEnabled.
- testing/InternalSettings.cpp: Remove unused code.
- testing/InternalSettings.h: Remove unused code.
- testing/InternalSettings.idl: Remove unused code.
Source/WebKit/chromium:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setEnableScrollAnimator): Update call to WebCore to use setScrollAnimatorEnabled(bool).
Source/WebKit/gtk:
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings): Update call to WebCore to use setScrollAnimatorEnabled(bool).
(webkit_web_view_settings_notify): Update call to WebCore to use setScrollAnimatorEnabled(bool).
Source/WebKit/qt:
- Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply): Update call to WebCore to use setScrollAnimatorEnabled(bool).
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setUseFixedLayout): Update call to WebCore to use setScrollAnimatorEnabled(bool).
(WebKit::WebPage::updatePreferences): Update call to WebCore to use setScrollAnimatorEnabled(bool).
- 1:05 PM Changeset in webkit [146923] by
-
- 2 edits in trunk/LayoutTests
Remove stray newline. This newline is messing up mozilla's test harness
and we share this file with them via html5lib.
- html5lib/resources/template.dat:
- 1:04 PM Changeset in webkit [146922] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] In RSSFilterStream, don't swallow headers when there's no body
https://bugs.webkit.org/show_bug.cgi?id=113334
Patch by Joe Mason <jmason@blackberry.com> on 2013-03-26
Reviewed by Rob Buis.
RIM PR 316345
When receiving an HTTP response that has a Content-Type header such as text/xml, but no
body, RSSFilterStream::notifyHeadersReceived reads the Content-Type as "potential RSS", and
calls saveHeaders. It expects to sniff the body in notifyDataReceived to see if it's RSS,
and then call sendSavedHeaders to pass on the headers. But since there is no body,
notifyDataReceived is never called. So call sendSavedHeaders in notifyClose too (it will not
send them again if they were already sent.)
- platform/network/blackberry/rss/RSSFilterStream.cpp:
(WebCore::RSSFilterStream::notifyClose):
- 12:48 PM Changeset in webkit [146921] by
-
- 2 edits in trunk/Tools
Update bots on test-results.appspot
https://bugs.webkit.org/show_bug.cgi?id=113333
Patch by Isaac Levy <ilevy@google.com> on 2013-03-26
Reviewed by Ojan Vafai.
- TestResultServer/static-dashboards/builders.jsonp:
- 12:46 PM WebKitGTK/2.0.x edited by
- (diff)
- 12:44 PM Changeset in webkit [146920] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0
[GTK] Bump required versions of some dependencies
https://bugs.webkit.org/show_bug.cgi?id=113282
Reviewed by Martin Robinson.
This patch updates the following dependencies:
- libsoup 2.42.0: is the current stable release.
- glib 2.36.0: libsoup 2.42 requires 2.35.0, but we don't want to depend on unstable versions and 2.36 is the next stable version after 2.35.
- gtk+ 3.6.0: this is the previous stable release. We don't currently have any code using newer API, so we will be able to remove all the #ifdefed code.
- at-spi2 2.5.3: is the version required by gtk+ 3.6.
- GObject introspection 1.32.0: is the version required by gtk+ 3.6.
- Pango 1.32.0: it's the current stable version and the first one depending on Harfbuzz.
- Fontconfig 2.5: required by pango 1.32.0 when using Harfbuzz.
- gtk+ 2.24.10: it allows us to remove a lot of deprecated code and #ifdefs.
- Source/autotools/Versions.m4:
- 12:41 PM Changeset in webkit [146919] by
-
- 9 edits in branches/chromium/1453/Source
Revert 146672 "Add client callbacks to notify of changes of asso..."
Add client callbacks to notify of changes of associated from controls
https://bugs.webkit.org/show_bug.cgi?id=110375
Patch by Dane Wallinga <dgwallinga@chromium.org> on 2013-03-22
Reviewed by Ryosuke Niwa.
Source/WebCore:
Hook FormAssociatedElement, HTMLFormElement to notify EditorClient of form changes after a page has loaded.
Will be used to add autofill support for ajax-y webpages. e.g if while filling out a form, new fields
are dynamically created, autofill can know to re-query the autofill server and keep going.
https://bugs.webkit.org/show_bug.cgi?id=110375
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::didAssociateFormControl):
(WebCore):
(WebCore::Document::didAssociateFormControlsTimerFired):
- dom/Document.h:
(Document):
added method didAssociateFormControl, which batches form changes
and calls out to ChromeClient on a timer.
- html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::resetFormOwner):
(WebCore::FormAssociatedElement::formAttributeChanged):
(WebCore):
- html/FormAssociatedElement.h:
(FormAssociatedElement):
add calls to Document::didAssociateFormControl when form changes
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::insertedInto):
(WebCore):
- html/HTMLFormElement.h:
add call to Document::didAssociateFormControl
- loader/EmptyClients.h:
(EmptyChromeClient):
(WebCore::EmptyChromeClient::didAssociateFormControls):
(WebCore::EmptyChromeClient::shouldNotifyOnFormChanges):
- page/ChromeClient.h:
(ChromeClient):
add new method didAssociateFormControls
Source/WebKit/chromium:
Implement form association methods of ChromeClient
to inform autofill of form changes after a page has loaded
- public/WebAutofillClient.h:
(WebAutofillClient):
(WebKit::WebAutofillClient::didAssociateInput):
(WebKit::WebAutofillClient::didAddForm):
(WebKit::WebAutofillClient::didAssociateFormControls):
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::didAssociateFormControls):
(WebKit):
(WebKit::ChromeClientImpl::shouldNotifyOnFormChanges):
- src/ChromeClientImpl.h:
(ChromeClientImpl):
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12670015
- 12:30 PM Changeset in webkit [146918] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Faster drawer animation.
https://bugs.webkit.org/show_bug.cgi?id=113330
250ms -> 100ms
Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-26
Reviewed by Pavel Feldman.
- inspector/front-end/inspector.css:
(.animate #main):
(.animate #floating-status-bar-container):
(.animate #drawer):
(.animate #bottom-status-bar-container > *):
- 12:12 PM Changeset in webkit [146917] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Expose setSelectionIncludesAltImageText in WebSettings
https://bugs.webkit.org/show_bug.cgi?id=113316
Reviewed by Dimitri Glazkov.
Enabling this setting allows plain text clipboard content to include alt
text like on Firefox and IE10.
- public/WebSettings.h:
(WebSettings):
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setSelectionIncludesAltImageText):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
- 12:04 PM Changeset in webkit [146916] by
-
- 2 edits in trunk/LayoutTests
Remove some entries since those tests have been passing.
Also update the test expectations for the bug 113227 flaky since they're passing most of the time.
- platform/mac/TestExpectations:
- 12:01 PM Changeset in webkit [146915] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Fails to start QtWebProcess.exe if installed in a path containing spaces
https://bugs.webkit.org/show_bug.cgi?id=113328
Reviewed by Jocelyn Turcotte.
Downstream bugreport: https://bugreports.qt-project.org/browse/QTBUG-30249
We use QProcess::start() with a commandline string to start the web process
and the string is treated by QProcess as a whitespace delimeted list of the
command and the arguments, thus we have to escape the path to the process
binaries so that if the path contains spaces we still run the appropriate
command.
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess):
- 11:57 AM Changeset in webkit [146914] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] QML WebView asserts when double clicking a link
https://bugs.webkit.org/show_bug.cgi?id=113329
Reviewed by Jocelyn Turcotte.
Downstream bugreport: https://bugreports.qt-project.org/browse/QTBUG-30288
Remove an erroneous assert which is no longer valid if
mouse gestures are enabled.
- UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::handleInputEvent):
- 11:43 AM Changeset in webkit [146913] by
-
- 3 edits in trunk/Source/WebKit2
[wk2] Don't send intrinsic content size updates more than once per runloop
https://bugs.webkit.org/show_bug.cgi?id=113258
<rdar://problem/13492038>
Reviewed by Anders Carlsson.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
Add a zero-delay timer for intrinsic content size updates.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Add a zero-delay timer for intrinsic content size updates.
(WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
Start our new one-shot zero-delay timer.
(WebKit::TiledCoreAnimationDrawingArea::updateIntrinsicContentSizeTimerFired):
Inform the WebPage that the intrinsic content size has changed.
- 11:30 AM Changeset in webkit [146912] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Unreviewed Build fix.
- platform/graphics/win/FontCustomPlatformDataCairo.h:
(FontCustomPlatformData): Correct signature in header to match
required implementation.
- 11:21 AM Changeset in webkit [146911] by
-
- 8 edits in trunk/Source
[BlackBerry] Scrolling up and down can cause the screen to flash black
https://bugs.webkit.org/show_bug.cgi?id=113269
Reviewed by Rob Buis.
PR 296106
Source/WebCore:
The LayerRenderer should never clear before drawing the layers, from
now on that's the responsibility of the caller.
Only manually testable.
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::setViewport):
- platform/graphics/blackberry/LayerRendererClient.h:
(LayerRendererClient):
Source/WebKit/blackberry:
Various flaws in the code could conspire to make the screen cleared to
black before rendering the web page. This only happened when the
BackingStore was inactive, and the LayerTiler takes on the job of
drawing the root layer. When tiles are missing, this made the
"checkerboard" effect especially noticeable since black color was seen
where the tile should have been. It would be better to clear to the web
page background color.
This was actually the intent of the code, but when the document
background color was invalid, we would still use it instead of the
background color from settings. Also, the LayerRenderer would clear to
black when WebPageCompositorPrivate::drawsRootLayer() was true.
Fixed by falling back to the settings background color when the
document background color is invalid, and removing the clearing code
from the LayerRenderer entirely. The appropriate clear already happens
near the beginning of BackingStorePrivate::blitVisibleContents().
Also slightly cleaned up the code for managing the background color.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
(BlackBerry::WebKit::WebPagePrivate::updateBackgroundColor):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::documentBackgroundColor):
- Api/WebPageCompositor.cpp:
- Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):
- Api/WebPage_p.h:
(WebPagePrivate):
- 11:10 AM Changeset in webkit [146910] by
-
- 5 edits in trunk
[Qt] editing/pasteboard/can-read-in-dragstart-event.html and /can-read-in-copy-and-cut-events.html are crashing
https://bugs.webkit.org/show_bug.cgi?id=113126
Reviewed by Jocelyn Turcotte.
Source/WebCore:
Make it possible to read from a writable Clipboard.
Test: editing/pasteboard/can-read-in-copy-and-cut-events.html
- platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::getData):
(WebCore::ClipboardQt::types):
(WebCore::ClipboardQt::files):
(WebCore::ClipboardQt::readClipboardData):
(WebCore::ClipboardQt::hasData):
(WebCore::ClipboardQt::items):
- platform/qt/ClipboardQt.h:
(ClipboardQt):
LayoutTests:
Unskip now working editing/pasteboard/can-read-in-copy-and-cut-events.html.
The other test still needs better drag-and-drop support in DRT.
- platform/qt/TestExpectations:
- 11:01 AM Changeset in webkit [146909] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Unreviewed build correction.
- platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData): Update
method signature to match CG variant.
- 10:59 AM Changeset in webkit [146908] by
-
- 14 edits2 deletes in trunk/Source
Code duplication between HTTPParsers and HTTPValidation
https://bugs.webkit.org/show_bug.cgi?id=113283
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Merged isValidHTTPToken() from HTTPValidation.h and isRFC2616Token() from
HTTPParsers.h. They were doing exactly the same thing and their
implementation was almost the same.
Removed HTTPValidation.* and moved remaining code to HTTPParsers.* as this
seems like the proper place and it seems odd to keep HTTPValidation for
just one function.
No new tests, no behavior change for layout tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/network/HTTPParsers.cpp:
(WebCore::isValidHTTPHeaderValue):
(WebCore):
(WebCore::isValidHTTPToken): Implementation is slightly simplified based on
isValidHTTPToken() from HTTPValidation.cpp. (c >= 0x80 c == 0x7F) is replaced by (c >= 0x7F). (c <= 0x1F c == ' ' c == '\t') is replaced by (c <= 0x20). Those expressions are shorter but equivalent.
(WebCore::contentDispositionType):
- platform/network/HTTPParsers.h:
- platform/network/HTTPValidation.cpp: Removed.
- platform/network/HTTPValidation.h: Removed.
- xml/XMLHttpRequest.cpp: Stop including HTTPValidation.h.
Source/WebKit/chromium:
- src/AssociatedURLLoader.cpp: Include HTTPParsers.h instead
of HTTPValidation.h to use isValidHTTPToken().
- 10:58 AM Changeset in webkit [146907] by
-
- 17 edits4 adds in trunk
Implement overtype mode for editable content
https://bugs.webkit.org/show_bug.cgi?id=112126
Reviewed by Ryosuke Niwa.
Source/WebCore:
Tests: editing/execCommand/overtype-support.html
editing/execCommand/overtype.html
Add a new Overwrite command to the editor. This command will
perform overtype operations when enabled instead of "normal" text
insertions. As IE does, we maintain a single toggle state in the
editor (enabled/disabled) for all the editable content in the
page.
This new command will be only available for richly editable
content via keybindings or the context menu. For testing purposes
it is also accessible via internals.
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::replaceTextInNode): Use RefPtr for
local variables.
- editing/Editor.cpp:
(WebCore::Editor::Editor):
- editing/Editor.h:
(WebCore::Editor::isOverwriteModeEnabled):
(WebCore::Editor::toggleOverwriteModeEnabled):
(Editor): Added two new functions and a new attribute.
- editing/EditorCommand.cpp:
(WebCore::executeToggleOverwrite): Enables/disables overwrite mode.
(WebCore):
(WebCore::createCommandMap): New OverWrite command.
- editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::setEndingSelectionWithoutValidation):
Refactored from performTrivialReplace(), shared by
performOverwrite().
(WebCore):
(WebCore::InsertTextCommand::performTrivialReplace):
(WebCore::InsertTextCommand::performOverwrite):
(WebCore::InsertTextCommand::doApply): Perform overwrite if enabled.
- editing/InsertTextCommand.h:
(InsertTextCommand):
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState): Reset OverWrite mode
to false.
(WebCore::Internals::isOverwriteModeEnabled):
(WebCore):
(WebCore::Internals::toggleOverwriteModeEnabled): Provide access
to overwrite functionality in Editor for testing purposes.
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit/mac:
Added the OverWrite editing command to the WebCore editing
commands lists.
- WebView/WebHTMLView.mm:
- WebView/WebView.h:
- WebView/WebView.mm:
LayoutTests:
Two new layout tests for the new overtype mode. We use
overtype-support.html to check that the Overwrite command is not
exported to JavaScript but accessible through Internals. The
overtype.html one is used to test the actual behaviour of the
command.
The new command was also added to enabling-and-selection-2.js to
check that it is only available for richly editable content.
- editing/execCommand/enabling-and-selection-2-expected.txt:
Updated expectations for OverWrite command.
- editing/execCommand/overtype-expected.txt: Added.
- editing/execCommand/overtype-support-expected.txt: Added.
- editing/execCommand/overtype-support.html: Added.
- editing/execCommand/overtype.html: Added.
- editing/execCommand/script-tests/enabling-and-selection-2.js:
Added a check for OverWrite command.
- 10:44 AM Changeset in webkit [146906] by
-
- 6 edits in trunk/Source
[BlackBerry] WebOverlay::pixelViewportRect() should return pixel viewport coordinates
https://bugs.webkit.org/show_bug.cgi?id=113263
Reviewed by Rob Buis.
PR 312404
Source/WebCore:
Fix WebOverlay::pixelViewportRect() to return the pixel viewport rect
instead of the window rect. These are different if the web page is
rendered starting at a window coordinate other than 0,0. The clip rect
encodes the position we're rendered at, and can be used to translate
the rect expressed in window coordinates to the pixel viewport
coordinate system.
Also perform some cleanup of related code.
Only manually testable.
- platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::getTransformedHolePunchRect):
(WebCore::LayerCompositingThread::drawTextures):
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::toPixelCoordinates):
(WebCore):
(WebCore::LayerRenderer::toWindowCoordinates):
(WebCore::LayerRenderer::toPixelViewportCoordinates):
(WebCore::LayerRenderer::toDocumentViewportCoordinates):
(WebCore::LayerRenderer::updateLayersRecursive):
- platform/graphics/blackberry/LayerRenderer.h:
(LayerRenderer):
Source/WebKit/blackberry:
Fixed by returning pixel viewport coordinates instead of window
coordinates.
- Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):
- 10:31 AM Changeset in webkit [146905] by
-
- 5 edits in trunk
Unreviewed, rolling out r146901.
http://trac.webkit.org/changeset/146901
https://bugs.webkit.org/show_bug.cgi?id=113321
Was landed to soon (Requested by pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-26
Source/WebCore:
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.):
(WebInspector.ConsoleView.prototype.filter):
(WebInspector.ConsoleView.prototype._scheduleScrollIntoView.scrollIntoView):
(WebInspector.ConsoleView.prototype._scheduleScrollIntoView):
(WebInspector.ConsoleView.prototype._consoleMessageAdded):
(WebInspector.ConsoleView.prototype._appendConsoleMessage):
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent.monitoringXHRItemAction):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent.get preserveLogItemAction):
(WebInspector.ConsoleView.prototype._shouldBeVisible):
(WebInspector.ConsoleView.prototype._updateMessageList):
(WebInspector.ConsoleView.prototype._promptKeyDown):
(WebInspector.ConsoleView.prototype._printResult):
(WebInspector.ConsoleCommand.prototype.highlightSearchResults):
- inspector/front-end/inspector.css:
(.console-warning-level, .console-error-level, .console-log-level, .console-debug-level):
(.filter-all .console-debug-level, .filter-debug .console-debug-level):
(.filter-all .console-debug-level.repeated-message, .filter-debug .console-debug-level.repeated-message):
LayoutTests:
- inspector/console/console-preserve-log.html:
- 10:24 AM Changeset in webkit [146904] by
-
- 4 edits in trunk
HTMLStackItem should include <template> as a special tag
https://bugs.webkit.org/show_bug.cgi?id=113016
Reviewed by Eric Seidel.
Source/WebCore:
New test added to html5lib suite.
- html/parser/HTMLStackItem.h:
(WebCore::HTMLStackItem::isSpecialNode):
LayoutTests:
- html5lib/resources/template.dat:
- 10:22 AM Changeset in webkit [146903] by
-
- 6 edits in trunk
Web Inspector: Distinguish breakpoints and breakpoint locations in BreakpointManager API
https://bugs.webkit.org/show_bug.cgi?id=113311
Reviewed by Pavel Feldman.
Source/WebCore:
Made independent handling of breakpoints and breakpoint location in breakpoint manager consistent.
JavaScriptSourceFrame now removes breakpoints originally set in it based on primary UI location.
- inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.breakpointsForUISourceCode):
(WebInspector.BreakpointManager.prototype.allBreakpoints):
(WebInspector.BreakpointManager.prototype.breakpointLocationsForUISourceCode):
(WebInspector.BreakpointManager.prototype.allBreakpointLocations):
(WebInspector.BreakpointManager.prototype._projectWillReset.get for):
(WebInspector.BreakpointManager.prototype._projectWillReset):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.onUISourceCodeContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype._restoreBreakpointsAfterEditing):
(WebInspector.JavaScriptSourceFrame.prototype._removeAllBreakpoints):
LayoutTests:
- inspector/debugger/live-edit-breakpoints-expected.txt:
- inspector/debugger/live-edit-breakpoints.html:
- 10:21 AM Changeset in webkit [146902] by
-
- 2 edits in trunk/Source/WebKit2
bundle-ids need to be sanitized before using them in filesystem paths
https://bugs.webkit.org/show_bug.cgi?id=113030
<rdar://problem/13300254>
Patch by Simon Cooper <scooper@apple.com> on 2013-03-26
Reviewed by Alexey Proskuryakov.
When choosing / looking for a specialized Sandbox for a Plugin the
bundle-id needs to be sanitized before using it to construct a
filesystem name to look up. The “/“ character should not be allowed
and transformed into something else, in this case a “:”
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::loadSandboxProfile):
- 10:12 AM Changeset in webkit [146901] by
-
- 5 edits in trunk
Web Inspector: Remove remainings of CSS-based console message filtering.
https://bugs.webkit.org/show_bug.cgi?id=112710
Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-26
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.get this):
(WebInspector.ConsoleView.prototype.):
(WebInspector.ConsoleView.prototype.filter):
(WebInspector.ConsoleView.prototype._consoleMessageAdded):
(WebInspector.ConsoleView.prototype._appendConsoleMessage):
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._shouldBeVisible):
(WebInspector.ConsoleView.prototype._updateMessageList):
(WebInspector.ConsoleView.prototype._promptKeyDown):
(WebInspector.ConsoleView.prototype._printResult):
(WebInspector.ConsoleCommand.prototype.highlightSearchResults):
- inspector/front-end/inspector.css:
(.console-debug-level.repeated-message):
LayoutTests:
- inspector/console/console-preserve-log.html:
- 10:09 AM Changeset in webkit [146900] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: refactor code duplication: WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements
https://bugs.webkit.org/show_bug.cgi?id=113211
Patch by Peter Rybin <prybin@chromium.org> on 2013-03-26
Reviewed by Yury Semikhatsky.
A new method WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements is added and used
from 2 sites.
- inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection.prototype.update.callback):
(WebInspector.ObjectPropertiesSection.prototype.update):
(WebInspector.ObjectPropertiesSection.prototype.updateProperties):
(.callback):
(WebInspector.ObjectPropertyTreeElement.populate):
(WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements):
- inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype.update.appendResult):
(WebInspector.WatchExpressionsSection.prototype.update):
- 10:04 AM Changeset in webkit [146899] by
-
- 2 edits in trunk/Source/WebCore
HTTPHeaderMap::copyData() could call uncheckedAppend()
https://bugs.webkit.org/show_bug.cgi?id=113279
Reviewed by Alexey Proskuryakov.
HTTPHeaderMap::copyData() calls reserveInitialCapacity() on the Vector
but then appends items using append() function. Since we already know
the capacity is sufficient, it is more efficient to call uncheckedAppend()
instead to bypass capacity checks.
No new tests, no behavior change for layout tests.
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::copyData):
- 10:01 AM Changeset in webkit [146898] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: UISourceCodes are leaking on reload sometimes.
https://bugs.webkit.org/show_bug.cgi?id=113310
Reviewed by Pavel Feldman.
- inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._projectWillReset.get for):
(WebInspector.BreakpointManager.prototype._projectWillReset):
- inspector/front-end/ConsoleModel.js:
(WebInspector.ConsoleModel.prototype.clearMessages):
- 9:45 AM Changeset in webkit [146897] by
-
- 4 edits2 adds in trunk
Web Inspector: [Elements] Unable to "Edit as HTML" XHTML/SVG documents.
https://bugs.webkit.org/show_bug.cgi?id=113290
Reviewed by Pavel Feldman.
Source/WebCore:
DOMPatchSupport has been slightly augmented to handle XML (XHTML and SVG) documents.
Test: inspector/elements/set-outer-html-for-xhtml.xhtml
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::patchDocument):
(WebCore::DOMPatchSupport::patchNode):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setOuterHTML): Let HTML, XHTML, and SVG documents through.
LayoutTests:
- inspector/elements/set-outer-html-for-xhtml-expected.txt: Added.
- inspector/elements/set-outer-html-for-xhtml.xhtml: Added.
- 9:14 AM Changeset in webkit [146896] by
-
- 5 edits in trunk
https://bugs.webkit.org/show_bug.cgi?id=113164
Custom Elements: readyCallback should be called for outerHTML and insertAdjecentHTML
Source/WebCore:
These APIs also create new elements thus should have V8DeliverCustomElementCallbacks attribute.
Reviewed by Dimitri Glazkov.
Test: Updated lifecycle-ready-creation-api.html.
- html/HTMLElement.idl:
LayoutTests:
Reviewed by Dimitri Glazkov.
- fast/dom/custom/lifecycle-ready-creation-api-expected.txt:
- fast/dom/custom/lifecycle-ready-creation-api.html:
- 9:10 AM Changeset in webkit [146895] by
-
- 2 edits in trunk/LayoutTests
Fix incorrect test name in content shell expectations
Unreviewed. Typing is hard.
- platform/chromium/ContentShellTestExpectations:
- 9:05 AM Changeset in webkit [146894] by
-
- 2 edits in trunk/Source/WebKit/chromium
Convert WebInputEvent::GestureDoubleTap to PlatformEvent::NoType
https://bugs.webkit.org/show_bug.cgi?id=113215
In bug 93045 we removed PlatformEvent::GestureDoubleTap since now DoubleTap gesture
is implemented as a Tap gesture with tap_count = 2.
In WebViewImpl::handleGestureEvent(), a PlatformEvent is built from the WebGestureEvent
regardless, even though the PlatfromEvent will never reach the WebCore. DoubleTap, in
our case, is only handled in WebViewImpl for doube-tap-to-zoom, will also go through
conversion in WebInpuEventConversion.cpp::PlatformGestureEventBuilder() and reach
ASSERT_NOT_REACHED()
This patch converts WebGestureEvent::DoubleTap to PlatformEvent::NoType, this makes the
conversion list from WebInputEvent to PlatformEvent complete and we don't need a special
handling for the DoubleTap event in WebViewImpl::handleGestureEvent()
Patch by Yufeng Shen <miletus@chromium.org> on 2013-03-26
Reviewed by Antonio Gomes.
- src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
- 9:02 AM Changeset in webkit [146893] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. WebInspector: remove unnecessary method.
- inspector/front-end/OverviewGrid.js:
(WebInspector.OverviewGrid.Window):
- 9:00 AM Changeset in webkit [146892] by
-
- 8 edits in branches/chromium/1453/Source/WebCore
Revert 146744 "Refactoring: Pull Node::disabled() and Node::isIn..."
Refactoring: Pull Node::disabled() and Node::isInert() down to Element.
https://bugs.webkit.org/show_bug.cgi?id=112085
Reviewed by Hajime Morrita.
Node is too low a level for these methods. The plan is to rename
Element::disabled to isDisabledFormControl and to remove
Element::isEnabledFormControl.
No new tests, just refactoring.
- dom/Element.cpp:
(WebCore::Element::disabled):
(WebCore):
(WebCore::Element::isInert):
- dom/Element.h:
(Element):
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchSimulatedClick):
- dom/GestureEvent.cpp:
(WebCore::GestureEventDispatchMediator::dispatchEvent):
- dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent):
- dom/Node.cpp:
(WebCore::Node::handleLocalEvents):
(WebCore::Node::willRespondToMouseMoveEvents):
(WebCore::Node::willRespondToMouseClickEvents):
(WebCore::Node::willRespondToTouchEvents):
- dom/Node.h:
(Node):
TBR=falken@chromium.org
Review URL: https://codereview.chromium.org/12703032
- 8:57 AM Changeset in webkit [146891] by
-
- 33 edits in branches/chromium/1453/Source/WebCore
Revert 146726 "AXObjectCache gets recreated during document tear..."
AXObjectCache gets recreated during document tear-down.
https://bugs.webkit.org/show_bug.cgi?id=112525
Reviewed by Simon Fraser.
In many cases, a document's AXObjectCache was being created after the
document had detached, which is wasteful and could potentially lead to
crashes because the AXObjectCache has a timer and relies on its document
to exist.
This patch provides a way to get the existing AX object cache, instead of
always creating a new one.
It moves the accessibilityEnabled() checks into the axObjectCache retrieval
for easier readability.
It adds a number of ASSERTs to vieryf that only the correct (top) document is used
for cache manipulation.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::stopCachingComputedObjectAttributes):
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::~ContainerNode):
- dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::clearAXObjectCache):
(WebCore::Document::existingAXObjectCache):
(WebCore::Document::axObjectCache):
(WebCore::Document::setFocusedNode):
- dom/Document.h:
(Document):
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
- dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::isEditableToAccessibility):
(WebCore::Node::attach):
(WebCore::Node::rootEditableElement):
(WebCore::Node::didMoveToNewDocument):
- editing/AppendNodeCommand.cpp:
(WebCore::sendAXTextChangedIgnoringLineBreaks):
- editing/DeleteFromTextNodeCommand.cpp:
(WebCore::DeleteFromTextNodeCommand::doApply):
(WebCore::DeleteFromTextNodeCommand::doUnapply):
- editing/Editor.cpp:
(WebCore::Editor::respondToChangedContents):
(WebCore::Editor::markAndReplaceFor):
- editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):
- editing/InsertNodeBeforeCommand.cpp:
(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):
- editing/atk/FrameSelectionAtk.cpp:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
- editing/chromium/FrameSelectionChromium.cpp:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
- editing/mac/FrameSelectionMac.mm:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setChecked):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::optionElementChildrenChanged):
(WebCore::HTMLSelectElement::setRecalcListItems):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setInnerTextValue):
- html/InputType.cpp:
(WebCore::InputType::applyStep):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::handleKeydownEvent):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
- page/FocusController.cpp:
(WebCore::FocusController::setInitialFocus):
- page/Frame.cpp:
(WebCore::Frame::disconnectOwnerElement):
- page/FrameView.cpp:
(WebCore::FrameView::removeFromAXObjectCache):
(WebCore::FrameView::layout):
(WebCore::FrameView::scrollToAnchor):
(WebCore::FrameView::axObjectCache):
- platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::~Scrollbar):
(WebCore):
(WebCore::Scrollbar::existingAXObjectCache):
- platform/Scrollbar.h:
(Scrollbar):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::deleteLineBoxTree):
(WebCore::RenderBlock::createRootInlineBox):
(WebCore::RenderBlock::createAndAppendRootInlineBox):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::selectionChanged):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::addChild):
(WebCore::RenderMenuList::didUpdateActiveOption):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::willBeDestroyed):
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
- rendering/RenderText.cpp:
(WebCore::RenderText::setText):
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::willBeDestroyed):
TBR=Chris Fleizach
Review URL: https://codereview.chromium.org/12703031
- 8:54 AM Changeset in webkit [146890] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Flame Chart. Scroll dividers together with underlying chart.
http://bugs.webkit.org/show_bug.cgi?id=113080
Reviewed by Pavel Feldman.
- inspector/front-end/FlameChart.js:
(WebInspector.FlameChart.Calculator.prototype.grandMinimumBoundary):
(WebInspector.FlameChart.prototype._canvasDragging):
- inspector/front-end/TimelineGrid.js:
(WebInspector.TimelineGrid.prototype.updateDividers):
- 8:53 AM Changeset in webkit [146889] by
-
- 1 add in branches/chromium/1453/codereview.settings
for drovering
- 8:52 AM Changeset in webkit [146888] by
-
- 1 copy in branches/chromium/1453
hopefully m27 branch
- 8:36 AM Changeset in webkit [146887] by
-
- 2 edits in trunk/Source/JavaScriptCore
ArrayMode should not consider SpecOther when refining the base
https://bugs.webkit.org/show_bug.cgi?id=113271
Reviewed by Geoffrey Garen.
9% speed-up on Octane/pdfjs.
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::refine):
- 8:22 AM Changeset in webkit [146886] by
-
- 5 edits4 adds in trunk
CSP 1.1: Experiment with 'base-uri' directive.
https://bugs.webkit.org/show_bug.cgi?id=113307
Reviewed by Jochen Eisinger.
Source/WebCore:
The 'base-uri' directive was introduced[1] as an experimental directive
in CSP 1.1 after a bit of discussion[2][3]. The exact semantics will
likely change, but it would be good for us to get some implementation
experience with the API as currently specified, and to allow folks to
play with the implementation to determine whether it meets the
requirements the way we think it might.
This patch is a first pass at that implementation: it will have no
effect on ports that haven't enabled the CSP_NEXT flag.
[1]: https://dvcs.w3.org/hg/content-security-policy/rev/4b89c246ea16
[2]: http://lists.w3.org/Archives/Public/public-webappsec/2012Oct/0022.html
[3]: http://lists.w3.org/Archives/Public/public-webappsec/2013Feb/0074.html
Tests: http/tests/security/contentSecurityPolicy/1.1/base-uri-allow.html
http/tests/security/contentSecurityPolicy/1.1/base-uri-deny.html
- dom/Document.cpp:
(WebCore::Document::processBaseElement):
Check that the new base URI is allowed by CSP before using it as
the document's base URI.
- page/ContentSecurityPolicy.cpp:
Add a constant for the new directive name (and, as a drive-by, split
the list into CSP 1.0 and CSP 1.1 for clarity).
(CSPDirectiveList):
Add a property to hold the base URI policy directive value.
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
Customize the error message iff we're dealing with 'base-uri'.
(WebCore::CSPDirectiveList::allowBaseURI):
Check the given URI against the 'base-uri' directive's value,
exactly as we do for every other source-list type of directive.
(WebCore::CSPDirectiveList::addDirective):
Accept 'base-uri' as a valid directive iff CSP_NEXT is set, and
the embedder has opted-in via the runtime flag.
(WebCore::ContentSecurityPolicy::allowBaseURI):
Expose an API method on ContentSecurityPolicy to check URIs against
the 'base-uri' directive's value.
LayoutTests:
- http/tests/security/contentSecurityPolicy/1.1/base-uri-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/base-uri-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/base-uri-deny-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/base-uri-deny.html: Added.
- 8:21 AM Changeset in webkit [146885] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Main frame fixed divs not positioned correctly
https://bugs.webkit.org/show_bug.cgi?id=112889
Reviewed by Carlos Garcia Campos.
PR 283363
This was a regression from bug #112806. It caused main frame fixed
handling to enter the iframe/scrollable div code path in LayerRenderer.
Fixed by not setting the container for fixed flag on the main frame,
the LayerRenderer expects this flag to be set only on non-mainframe
containers.
Only manually testable.
- page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.cpp:
(WebCore::scrollLayerForFrame):
(WebCore):
(WebCore::ScrollingCoordinatorBlackBerry::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinatorBlackBerry::setLayerIsFixedToContainerLayer):
- 8:17 AM Changeset in webkit [146884] by
-
- 2 edits in trunk/Source/WebCore
FormData::deepCopy() could use Vector::uncheckedAppend()
https://bugs.webkit.org/show_bug.cgi?id=113309
Reviewed by Kenneth Rohde Christiansen.
FormData::deepCopy() calls reserveInitialCapacity() on the Vector but then uses the
regular append() method. This patch switches to using uncheckedAppend() method
instead to bypass capacity checks as we already know it is sufficient.
No new tests, no behavior change.
- platform/network/FormData.cpp:
(WebCore::FormData::deepCopy):
- 8:15 AM Changeset in webkit [146883] by
-
- 13 edits in trunk
Unreviewed, rolling out r146879.
http://trac.webkit.org/changeset/146879
https://bugs.webkit.org/show_bug.cgi?id=113312
Multiple layout test crashes in
WebCore::RenderListItem::updateListMarkerNumbers (Requested by
yurys on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-26
Source/WebCore:
- dom/Node.cpp:
- dom/Node.h:
(Node):
- dom/NodeTraversal.cpp:
- dom/NodeTraversal.h:
(ElementTraversal):
(NodeTraversal):
- html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::attach):
- html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::updateItemValues):
(WebCore::HTMLOListElement::recalculateItemCount):
- rendering/RenderCounter.cpp:
(WebCore::previousInPreOrder):
(WebCore::previousSiblingOrParent):
(WebCore::parentElement):
(WebCore::nextInPreOrder):
- rendering/RenderListItem.cpp:
(WebCore::enclosingList):
(WebCore::RenderListItem::nextListItem):
(WebCore::previousListItem):
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::explicitValueChanged):
(WebCore::previousOrNextItem):
(WebCore::RenderListItem::updateListMarkerNumbers):
- rendering/RenderListItem.h:
(RenderListItem):
LayoutTests:
- fast/dom/shadow/shadow-and-list-elements-expected.html:
- fast/lists/positioned-count-crash-expected.txt:
- 8:06 AM Changeset in webkit [146882] by
-
- 6 edits3 adds in trunk
remoeveAllEventListeners() should be called to shadow trees
https://bugs.webkit.org/show_bug.cgi?id=113037
Reviewed by Dimitri Glazkov.
Source/WebCore:
Document::removeAllEventListeners() doesn't traverse shadow tree, but we should.
This change override Element::removeAllEventListeners() so that it cleans its shadow trees up.
Test: fast/dom/shadow/shadow-tree-listener-clearance.html
- dom/Element.cpp:
(WebCore::Element::removeAllEventListeners):
(WebCore):
- dom/Element.h:
(Element):
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::removeAllEventListeners): Added.
(WebCore):
- dom/ElementShadow.h:
(ElementShadow):
LayoutTests:
- fast/dom/shadow/resources/shadow-tree-listener-clearance-frame.html: Added.
- fast/dom/shadow/shadow-tree-listener-clearance-expected.txt: Added.
- fast/dom/shadow/shadow-tree-listener-clearance.html: Added.
- 8:04 AM Changeset in webkit [146881] by
-
- 1 edit1 add1 delete in trunk/LayoutTests
Unreviewed. Updated test expectations for compositing/geometry/fixed-in-composited.html
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Removed.
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
- 7:52 AM Changeset in webkit [146880] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] UIProcess should initialize WebCoreSystemInterface.
https://bugs.webkit.org/show_bug.cgi?id=113300
The WebCoreSystemInterface is necessary to detect supported
mime types on Mac OS. In particular it is needed for download
support.
This patch fixes in particular the previously failing
Qt API qmltest WebViewDownload::test_downloadRequest.
The test was crashing when using QTKit, because functions
in WebCoreSystemInterface could not be resolved on the UIProcess side.
Reviewed by Jocelyn Turcotte.
- UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
- 6:53 AM Changeset in webkit [146879] by
-
- 13 edits in trunk
Use DOM ordering for list counts
https://bugs.webkit.org/show_bug.cgi?id=110352
Reviewed by Elliott Sprehn.
Source/WebCore:
Currently the list items ordering is made by traversing the render tree. This gives bad results for:
- list items flown inside regions because they are not rendered as descendants of their DOM list ancestors.
- list items matched to insertion points inside a shadow tree. The insertion point may be a child of a
list so the numbering gets broken.
To implement correct DOM ordering I've taken into account the fact that pseudo-elements can have display: list-item
so they should be included when traversing the DOM tree. I've added helper methods on the NodeTraversal
namespace that should allow easily traversing the tree including the pseudo-elements (e.g. firstChildWithPseudo
for an element with pseudo-before will return the before PseudoElement). Using these helper methods I've implemented
pre-order traversal methods aware of the pseudo-elements.
An effect of this change is how the list items inside shadow tree update their counting. With the patch, if there's
no <ol> or <ul> element on the ancestor chain of a <li> element to the shadow root, the list node will be considered the
first parent of the <li> or the shadow root if there is no ancestor.
The RenderListItem class now makes use of this new method of traversal, replacing the one based on the render tree.
To simplify the CSS counters implementation, I've changed the traversal functions inside RenderCounter to also make use
of this method. The CSS counters and the list items now have the same traversal algorithm.
In later patches I'll add tests that should cover the regions and shadow DOM use cases.
Tests bug for shadow DOM: https://bugs.webkit.org/show_bug.cgi?id=113193
Tests bug for regions: https://bugs.webkit.org/show_bug.cgi?id=103975
Tests: no new tests is this patch; added the correct expectations for fast/lists/positioned-count-crash.html
and fast/dom/shadow/shadow-and-list-elements.html
- dom/Node.cpp:
(WebCore::Node::pseudoAwarePreviousSibling):
(WebCore):
(WebCore::Node::pseudoAwareNextSibling):
(WebCore::Node::pseudoAwareFirstChild):
(WebCore::Node::pseudoAwareLastChild):
- dom/Node.h:
(Node):
- dom/NodeTraversal.cpp:
(WebCore):
(WebCore::NodeTraversal::previousIncludingPseudo):
(NodeTraversal):
(WebCore::NodeTraversal::nextIncludingPseudo):
(WebCore::NodeTraversal::nextIncludingPseudoSkippingChildren):
- dom/NodeTraversal.h:
(ElementTraversal):
(NodeTraversal):
(WebCore::ElementTraversal::previousIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudoSkippingChildren):
(WebCore::ElementTraversal::pseudoAwarePreviousSibling):
- html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::attach):
- html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::updateItemValues):
(WebCore::HTMLOListElement::recalculateItemCount):
- rendering/RenderCounter.cpp:
(WebCore::previousInPreOrder):
(WebCore::previousSiblingOrParent):
(WebCore::parentElement):
(WebCore::nextInPreOrder):
- rendering/RenderListItem.cpp:
(WebCore):
(WebCore::enclosingList):
(WebCore::RenderListItem::nextListItem):
(WebCore::previousListItem):
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::explicitValueChanged):
(WebCore::previousOrNextItem):
(WebCore::RenderListItem::updateListMarkerNumbers):
- rendering/RenderListItem.h:
(RenderListItem):
LayoutTests:
The fast/dom/shadow/shadow-and-list-elements-expected.html has changed because the list items
inside the shadow tree no longer see the root <ol> element.
The test fast/lists/positioned-count-crash.html has the correct rendering after changing
the list counting to be in DOM order.
- fast/dom/shadow/shadow-and-list-elements-expected.html:
- fast/lists/positioned-count-crash-expected.txt:
- 6:51 AM Changeset in webkit [146878] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Poor rounding in GraphicsContext::drawLineForText
https://bugs.webkit.org/show_bug.cgi?id=113301
Reviewed by Jocelyn Turcotte.
Round the position of the line decoration, so lines on subpixel
coordinates are not always rounded up.
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawLineForText):
- 6:45 AM Changeset in webkit [146877] by
-
- 256 edits6 copies1 add in trunk/LayoutTests
[Qt] Unreviewed gardening. Updating PNG expected results. Making pixel test bot happier after r146206.
- platform/qt/svg/custom/mask-excessive-malloc-expected.png:
- platform/qt/svg/custom/mask-inside-defs-expected.png:
- platform/qt/svg/custom/massive-coordinates-expected.png:
- platform/qt/svg/custom/missing-xlink-expected.png:
- platform/qt/svg/custom/non-circular-marker-reference-expected.png:
- platform/qt/svg/custom/object-sizing-expected.png:
- platform/qt/svg/custom/path-bad-data-expected.png:
- platform/qt/svg/custom/path-update-expected.png:
- platform/qt/svg/custom/pattern-no-pixelation-expected.png:
- platform/qt/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
- platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.png:
- platform/qt/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png:
- platform/qt/svg/custom/pattern-y-offset-expected.png:
- platform/qt/svg/custom/percentage-of-html-parent-expected.png:
- platform/qt/svg/custom/pointer-events-image-css-transform-expected.png:
- platform/qt/svg/custom/pointer-events-image-expected.png:
- platform/qt/svg/custom/pointer-events-path-expected.png:
- platform/qt/svg/custom/pointer-events-text-css-transform-expected.png:
- platform/qt/svg/custom/pointer-events-text-expected.png:
- platform/qt/svg/custom/poly-identify-expected.png:
- platform/qt/svg/custom/polyline-hittest-expected.png:
- platform/qt/svg/custom/polyline-invalid-points-expected.png:
- platform/qt/svg/custom/relative-sized-content-with-resources-expected.png:
- platform/qt/svg/custom/rootelement-expected.png:
- platform/qt/svg/custom/rootmost-svg-xy-attrs-expected.png:
- platform/qt/svg/custom/second-inline-text-expected.png:
- platform/qt/svg/custom/shape-rendering-expected.png:
- platform/qt/svg/custom/sheet-title-expected.png:
- platform/qt/svg/custom/stroke-fallback-expected.png:
- platform/qt/svg/custom/svg-float-border-padding-expected.png:
- platform/qt/svg/custom/svg-fonts-in-html-expected.png:
- platform/qt/svg/custom/svg-fonts-segmented-expected.png:
- platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.png:
- platform/qt/svg/custom/svgpolyparser-extra-space-expected.png:
- platform/qt/svg/custom/text-dom-01-f-expected.png:
- platform/qt/svg/custom/text-filter-expected.png:
- platform/qt/svg/custom/text-hit-test-expected.png:
- platform/qt/svg/custom/text-letter-spacing-expected.png:
- platform/qt/svg/custom/text-linking-expected.png:
- platform/qt/svg/custom/text-whitespace-handling-expected.png:
- platform/qt/svg/custom/text-x-dx-lists-expected.png:
- platform/qt/svg/custom/text-x-dy-lists-expected.png:
- platform/qt/svg/custom/text-x-override-in-tspan-child-expected.png:
- platform/qt/svg/custom/transform-removeAttributeNS-expected.png:
- platform/qt/svg/custom/transform-scale-parse-expected.png:
- platform/qt/svg/custom/use-clipped-transform-expected.png:
- platform/qt/svg/custom/use-dynamic-append-expected.png:
- platform/qt/svg/custom/use-font-face-crash-expected.png:
- platform/qt/svg/custom/use-nested-transform-expected.png:
- platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.png:
- platform/qt/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
- platform/qt/svg/custom/use-on-g-containing-symbol-expected.png:
- platform/qt/svg/custom/use-on-g-containing-use-expected.png:
- platform/qt/svg/custom/use-on-g-expected.png:
- platform/qt/svg/custom/use-on-rect-expected.png:
- platform/qt/svg/custom/use-on-symbol-expected.png:
- platform/qt/svg/custom/use-on-text-expected.png:
- platform/qt/svg/custom/use-on-use-expected.png:
- platform/qt/svg/custom/use-transform-expected.png:
- platform/qt/svg/custom/viewport-no-width-height-expected.png:
- platform/qt/svg/custom/viewport-update-expected.png:
- platform/qt/svg/custom/visibility-override-clip-expected.png:
- platform/qt/svg/custom/visibility-override-expected.png:
- platform/qt/svg/custom/visibility-override-mask-expected.png:
- platform/qt/svg/custom/width-full-percentage-expected.png:
- platform/qt/svg/custom/xml-stylesheet-expected.png:
- platform/qt/svg/dom/SVGLengthList-insertItemBefore-expected.png:
- platform/qt/svg/dom/SVGPathSegList-cloning-expected.png:
- platform/qt/svg/filters/animate-fill-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug219693-1-expected.png.
- platform/qt/svg/filters/big-sized-filter-expected.png:
- platform/qt/svg/filters/feColorMatrix-offset-expected.png:
- platform/qt/svg/filters/feColorMatrix-saturate-expected.png:
- platform/qt/svg/filters/feDropShadow-subregion-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug219693-1-expected.png.
- platform/qt/svg/filters/feGaussianBlur-subregion-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug219693-1-expected.png.
- platform/qt/svg/filters/filter-empty-g-expected.png:
- platform/qt/svg/filters/filter-on-filter-for-text-expected.png:
- platform/qt/svg/filters/filter-on-tspan-expected.png:
- platform/qt/svg/filters/filter-placement-issue-expected.png:
- platform/qt/svg/filters/filter-source-position-expected.png:
- platform/qt/svg/filters/filterRes2-expected.png:
- platform/qt/svg/foreignObject/clip-expected.png: Copied from LayoutTests/platform/qt/svg/custom/transform-scale-parse-expected.png.
- platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png:
- platform/qt/svg/foreignObject/filter-expected.png: Copied from LayoutTests/platform/qt/svg/custom/transform-scale-parse-expected.png.
- platform/qt/svg/foreignObject/mask-expected.png: Copied from LayoutTests/platform/qt/svg/custom/transform-scale-parse-expected.png.
- platform/qt/svg/foreignObject/svg-document-as-direct-child-expected.png:
- platform/qt/svg/foreignObject/svg-document-in-html-document-expected.png:
- platform/qt/svg/hixie/cascade/001-broken-expected.png:
- platform/qt/svg/hixie/error/012-expected.png:
- platform/qt/svg/hixie/error/013-expected.png:
- platform/qt/svg/hixie/links/001-expected.png:
- platform/qt/svg/hixie/mixed/003-expected.png:
- platform/qt/svg/hixie/shapes/path/001-expected.png:
- platform/qt/svg/hixie/text/001-expected.png:
- platform/qt/svg/hixie/text/003-expected.png:
- platform/qt/svg/hixie/transform/001-expected.png:
- platform/qt/svg/hixie/viewbox/preserveAspectRatio/001-expected.png:
- platform/qt/svg/hixie/viewbox/preserveAspectRatio/002-expected.png:
- platform/qt/svg/text/bidi-embedded-direction-expected.png:
- platform/qt/svg/text/kerning-expected.png:
- platform/qt/svg/text/scaled-font-expected.png:
- platform/qt/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
- platform/qt/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
- platform/qt/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png:
- platform/qt/svg/text/small-fonts-in-html5-expected.png:
- platform/qt/svg/text/text-align-04-b-expected.png:
- platform/qt/svg/text/text-align-05-b-expected.png:
- platform/qt/svg/text/text-deco-01-b-expected.png:
- platform/qt/svg/text/text-path-middle-align-expected.png:
- platform/qt/svg/text/text-text-04-t-expected.png:
- platform/qt/svg/text/text-text-06-t-expected.png:
- platform/qt/svg/text/text-text-07-t-expected.png:
- platform/qt/svg/text/textPathBoundsBug-expected.png:
- platform/qt/svg/wicd/rightsizing-grid-expected.png:
- platform/qt/svg/wicd/test-rightsizing-a-expected.png:
- platform/qt/svg/wicd/test-rightsizing-b-expected.png:
- platform/qt/svg/wicd/test-scalable-background-image1-expected.png:
- platform/qt/svg/wicd/test-scalable-background-image2-expected.png:
- platform/qt/svg/zoom/page/zoom-background-image-tiled-expected.png:
- platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
- platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
- platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png:
- platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
- platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.png:
- platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
- platform/qt/svg/zoom/page/zoom-svg-as-object-expected.png:
- platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
- platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
- platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
- platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png:
- platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
- platform/qt/tables/layering/paint-test-layering-1-expected.png:
- platform/qt/tables/layering/paint-test-layering-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug101201-expected.png:
- platform/qt/tables/mozilla/bugs/bug102145-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug102145-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug102145-3-expected.png:
- platform/qt/tables/mozilla/bugs/bug102145-4-expected.png:
- platform/qt/tables/mozilla/bugs/bug10269-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug10296-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug10296-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug103533-expected.png:
- platform/qt/tables/mozilla/bugs/bug1055-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug106158-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug106795-expected.png:
- platform/qt/tables/mozilla/bugs/bug106816-expected.png:
- platform/qt/tables/mozilla/bugs/bug109043-expected.png:
- platform/qt/tables/mozilla/bugs/bug11321-expected.png:
- platform/qt/tables/mozilla/bugs/bug113235-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug113235-3-expected.png:
- platform/qt/tables/mozilla/bugs/bug11384q-expected.png:
- platform/qt/tables/mozilla/bugs/bug11384s-expected.png:
- platform/qt/tables/mozilla/bugs/bug1163-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug1188-expected.png:
- platform/qt/tables/mozilla/bugs/bug11944-expected.png:
- platform/qt/tables/mozilla/bugs/bug119786-expected.png:
- platform/qt/tables/mozilla/bugs/bug1224-expected.png:
- platform/qt/tables/mozilla/bugs/bug12709-expected.png:
- platform/qt/tables/mozilla/bugs/bug127267-expected.png:
- platform/qt/tables/mozilla/bugs/bug128229-expected.png:
- platform/qt/tables/mozilla/bugs/bug131020-expected.png:
- platform/qt/tables/mozilla/bugs/bug131020_iframe-expected.png:
- platform/qt/tables/mozilla/bugs/bug13118-expected.png:
- platform/qt/tables/mozilla/bugs/bug1318-expected.png:
- platform/qt/tables/mozilla/bugs/bug13196-expected.png:
- platform/qt/tables/mozilla/bugs/bug133756-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug133948-expected.png:
- platform/qt/tables/mozilla/bugs/bug137388-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug139524-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug14159-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug14929-expected.png:
- platform/qt/tables/mozilla/bugs/bug15247-expected.png:
- platform/qt/tables/mozilla/bugs/bug154780-expected.png:
- platform/qt/tables/mozilla/bugs/bug157890-expected.png:
- platform/qt/tables/mozilla/bugs/bug15933-expected.png:
- platform/qt/tables/mozilla/bugs/bug16012-expected.png:
- platform/qt/tables/mozilla/bugs/bug16252-expected.png:
- platform/qt/tables/mozilla/bugs/bug17138-expected.png:
- platform/qt/tables/mozilla/bugs/bug17587-expected.png:
- platform/qt/tables/mozilla/bugs/bug1800-expected.png:
- platform/qt/tables/mozilla/bugs/bug1802-expected.png:
- platform/qt/tables/mozilla/bugs/bug1802s-expected.png:
- platform/qt/tables/mozilla/bugs/bug1818-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug1818-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug1818-4-expected.png:
- platform/qt/tables/mozilla/bugs/bug18359-expected.png:
- platform/qt/tables/mozilla/bugs/bug18664-expected.png:
- platform/qt/tables/mozilla/bugs/bug18955-expected.png:
- platform/qt/tables/mozilla/bugs/bug19061-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug19061-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug194024-expected.png:
- platform/qt/tables/mozilla/bugs/bug19599-expected.png:
- platform/qt/tables/mozilla/bugs/bug2050-expected.png:
- platform/qt/tables/mozilla/bugs/bug20579-expected.png:
- platform/qt/tables/mozilla/bugs/bug20804-expected.png:
- platform/qt/tables/mozilla/bugs/bug21299-expected.png:
- platform/qt/tables/mozilla/bugs/bug215629-expected.png:
- platform/qt/tables/mozilla/bugs/bug219693-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug219693-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug221784-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug221784-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug222846-expected.png:
- platform/qt/tables/mozilla/bugs/bug2267-expected.png:
- platform/qt/tables/mozilla/bugs/bug23072-expected.png:
- platform/qt/tables/mozilla/bugs/bug23299-expected.png:
- platform/qt/tables/mozilla/bugs/bug24627-expected.png:
- platform/qt/tables/mozilla/bugs/bug2469-expected.png:
- platform/qt/tables/mozilla/bugs/bug2479-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug24880-expected.png:
- platform/qt/tables/mozilla/bugs/bug25074-expected.png:
- platform/qt/tables/mozilla/bugs/bug25086-expected.png:
- platform/qt/tables/mozilla/bugs/bug2509-expected.png:
- platform/qt/tables/mozilla/bugs/bug25367-expected.png:
- platform/qt/tables/mozilla/bugs/bug25663-expected.png:
- platform/qt/tables/mozilla/bugs/bug2684-expected.png:
- platform/qt/tables/mozilla/bugs/bug27038-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug27038-3-expected.png:
- platform/qt/tables/mozilla/bugs/bug2773-expected.png:
- platform/qt/tables/mozilla/bugs/bug2886-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug28928-expected.png:
- platform/qt/tables/mozilla/bugs/bug29058-3-expected.png:
- platform/qt/tables/mozilla/bugs/bug29429-expected.png:
- platform/qt/tables/mozilla/bugs/bug2981-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug2981-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug2997-expected.png:
- platform/qt/tables/mozilla/bugs/bug3037-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug3037-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug30418-expected.png:
- platform/qt/tables/mozilla/bugs/bug30559-expected.png:
- platform/qt/tables/mozilla/bugs/bug30692-expected.png:
- platform/qt/tables/mozilla/bugs/bug3103-expected.png:
- platform/qt/tables/mozilla/bugs/bug32205-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug32205-3-expected.png:
- platform/qt/tables/mozilla/bugs/bug32447-expected.png:
- platform/qt/tables/mozilla/bugs/bug3260-expected.png:
- platform/qt/tables/mozilla/bugs/bug32841-expected.png:
- platform/qt/tables/mozilla/bugs/bug3309-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug3309-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug34538-expected.png:
- platform/qt/tables/mozilla/bugs/bug3454-expected.png:
- platform/qt/tables/mozilla/bugs/bug3681-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug3681-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug38916-expected.png:
- platform/qt/tables/mozilla/bugs/bug3977-expected.png:
- platform/qt/tables/mozilla/bugs/bug41890-expected.png:
- platform/qt/tables/mozilla/bugs/bug42187-expected.png:
- platform/qt/tables/mozilla/bugs/bug4284-expected.png:
- platform/qt/tables/mozilla/bugs/bug43039-expected.png:
- platform/qt/tables/mozilla/bugs/bug4382-expected.png:
- platform/qt/tables/mozilla/bugs/bug43854-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug43854-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug4427-expected.png:
- platform/qt/tables/mozilla/bugs/bug45055-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug4523-expected.png:
- platform/qt/tables/mozilla/bugs/bug45350-expected.png:
- platform/qt/tables/mozilla/bugs/bug45486-expected.png:
- platform/qt/tables/mozilla/bugs/bug46268-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug46268-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug46268-5-expected.png:
- platform/qt/tables/mozilla/bugs/bug46268-expected.png:
- platform/qt/tables/mozilla/bugs/bug46368-1-expected.png:
- platform/qt/tables/mozilla/bugs/bug46368-2-expected.png:
- 6:29 AM Changeset in webkit [146876] by
-
- 2 edits5 adds in trunk/LayoutTests
[Qt] Unreviewed gardneing. Unskipped and Updated inspector tests after r146863.
- platform/qt/TestExpectations:
- platform/qt/inspector/console/console-eval-syntax-error-expected.txt: Added.
- platform/qt/inspector/debugger/debugger-pause-in-eval-script-expected.txt: Added.
- platform/qt/inspector/extensions/extensions-eval-expected.txt: Added.
- 6:22 AM Changeset in webkit [146875] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Decorations in several consecutive lines are not moved correctly in DTE.
https://bugs.webkit.org/show_bug.cgi?id=113296
Reviewed by Pavel Feldman.
Separated removing and adding decorations so that moved decorations are not removed when next line is processed.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorGutterPanel.prototype.textChanged):
- 6:17 AM Changeset in webkit [146874] by
-
- 2 edits in trunk/Source/WebCore
Remove references to non-chromium entries from WebCore.gypi (part 2)
https://bugs.webkit.org/show_bug.cgi?id=103124
Reviewed by Pavel Feldman.
- WebCore.gypi: removed unused references to gtk, cf, win and mac
- 5:31 AM Changeset in webkit [146873] by
-
- 2 edits in trunk/Tools
Unreviewed GTK gardening.
- Scripts/run-gtk-tests:
(TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
- 5:08 AM Changeset in webkit [146872] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Fix tst_QWebElement::render() API test
https://bugs.webkit.org/show_bug.cgi?id=65243
Reviewed by Jocelyn Turcotte.
Unmark the passing part of this testcase.
- tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement::render):
- 5:01 AM Changeset in webkit [146871] by
-
- 9 edits in trunk/Source
Unreviewed, rolling out r146767.
http://trac.webkit.org/changeset/146767
https://bugs.webkit.org/show_bug.cgi?id=113295
Rolling out until nicer fonts / sizes are chosen (Requested by
pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-26
Source/WebCore:
- inspector/front-end/dataGrid.css:
(.data-grid table):
(.data-grid td):
- inspector/front-end/inspector.css:
(.toolbar-label):
(body.show-toolbar-icons .toolbar-label):
(.console-message .bubble):
(li .status .bubble):
(.source-frame-breakpoint-message):
(.soft-context-menu):
(.drawer-header-close-button):
- inspector/front-end/inspectorCommon.css:
(body):
- inspector/front-end/networkLogView.css:
(.network-log-grid.data-grid td):
(.network-log-grid.data-grid.small td):
- inspector/front-end/tabbedPane.css:
(.tabbed-pane-header-tab):
(.tabbed-pane-header-tab-close-button):
- inspector/front-end/timelinePanel.css:
(.timeline-tree-item .count):
(.timeline-records-stats, .storage-application-cache-status, .storage-application-cache-connectivity):
(.memory-counter-sidebar-info):
(.memory-counter-value):
Source/WebKit/chromium:
- src/js/devTools.css:
- 4:57 AM Changeset in webkit [146870] by
-
- 287 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebaselining. Making pixel test bot happier after r146206.
- platform/qt/svg/W3C-SVG-1.1/animate-elem-28-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-29-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-32-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-77-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-85-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/color-prof-01-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1/color-prop-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/color-prop-02-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1/color-prop-03-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/coords-units-02-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/coords-units-03-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1/interact-dom-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/linking-a-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/linking-a-02-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/linking-a-03-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/linking-a-05-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/linking-a-07-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/linking-uri-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/linking-uri-02-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/linking-uri-03-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/masking-path-05-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/painting-fill-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/painting-fill-04-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/painting-fill-05-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/paths-data-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/paths-data-05-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/paths-data-07-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/paths-data-09-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/paths-data-12-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/paths-data-13-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/paths-data-14-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/paths-data-15-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/render-elems-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/render-elems-02-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/render-elems-03-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/render-elems-06-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/render-elems-07-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/render-elems-08-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/script-handle-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/script-handle-02-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/script-handle-03-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/shapes-line-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-cond-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-cond-03-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-defs-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-dom-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-dom-02-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-dom-03-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-frag-03-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-frag-04-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-frag-05-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-frag-06-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-group-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-group-02-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-group-03-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-image-03-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-image-05-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-image-07-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-image-08-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-image-09-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-use-03-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/struct-use-05-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/styling-css-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/styling-css-02-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/styling-css-03-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/styling-css-04-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1/styling-css-05-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/styling-css-06-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/styling-pres-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-align-05-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-text-04-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-text-06-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-text-08-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1/text-tref-01-b-expected.png:
- platform/qt/svg/as-background-image/animated-svg-as-background-expected.png:
- platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
- platform/qt/svg/as-background-image/same-image-two-instances-background-image-expected.png:
- platform/qt/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
- platform/qt/svg/as-border-image/svg-as-border-image-2-expected.png:
- platform/qt/svg/as-border-image/svg-as-border-image-expected.png:
- platform/qt/svg/as-image/image-respects-pageScaleFactor-expected.png:
- platform/qt/svg/as-image/same-image-two-instances-expected.png:
- platform/qt/svg/batik/filters/feTile-expected.png:
- platform/qt/svg/batik/paints/patternRegions-expected.png:
- platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.png:
- platform/qt/svg/batik/text/textEffect-expected.png:
- platform/qt/svg/batik/text/textEffect3-expected.png:
- platform/qt/svg/batik/text/textLayout-expected.png:
- platform/qt/svg/batik/text/textOnPath3-expected.png:
- platform/qt/svg/batik/text/textStyles-expected.png:
- platform/qt/svg/batik/text/xmlSpace-expected.png:
- platform/qt/svg/clip-path/clip-in-mask-expected.png:
- platform/qt/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png:
- platform/qt/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png:
- platform/qt/svg/clip-path/clip-path-childs-clipped-expected.png:
- platform/qt/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png:
- platform/qt/svg/clip-path/clip-path-clipped-expected.png:
- platform/qt/svg/clip-path/clip-path-clipped-nonzero-expected.png:
- platform/qt/svg/clip-path/clip-path-css-transform-1-expected.png:
- platform/qt/svg/clip-path/clip-path-css-transform-2-expected.png:
- platform/qt/svg/clip-path/clip-path-objectBoundingBox-expected.png:
- platform/qt/svg/clip-path/clip-path-on-clipped-use-expected.png:
- platform/qt/svg/clip-path/clip-path-on-g-and-child-expected.png:
- platform/qt/svg/clip-path/clip-path-on-g-expected.png:
- platform/qt/svg/clip-path/clip-path-on-svg-and-child-expected.png:
- platform/qt/svg/clip-path/clip-path-on-svg-expected.png:
- platform/qt/svg/clip-path/clip-path-recursive-call-by-child-expected.png:
- platform/qt/svg/clip-path/clip-path-recursive-call-expected.png:
- platform/qt/svg/clip-path/clip-path-transform-1-expected.png:
- platform/qt/svg/clip-path/clip-path-transform-2-expected.png:
- platform/qt/svg/clip-path/clip-path-use-as-child-expected.png:
- platform/qt/svg/clip-path/clip-path-userSpaceOnUse-expected.png:
- platform/qt/svg/clip-path/clip-path-with-different-unittypes-expected.png:
- platform/qt/svg/clip-path/clip-path-with-different-unittypes2-expected.png:
- platform/qt/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png:
- platform/qt/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png:
- platform/qt/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png:
- platform/qt/svg/css/css-box-min-width-expected.png:
- platform/qt/svg/css/group-with-shadow-expected.png:
- platform/qt/svg/css/mask-with-shadow-expected.png:
- platform/qt/svg/css/path-gradient-stroke-shadow-expected.png:
- platform/qt/svg/css/rect-gradient-stroke-shadow-expected.png:
- platform/qt/svg/custom/SVGMatrix-interface-expected.png:
- platform/qt/svg/custom/SVGNumber-interface-expected.png:
- platform/qt/svg/custom/SVGPoint-interface-expected.png:
- platform/qt/svg/custom/SVGRect-interface-expected.png:
- platform/qt/svg/custom/alignment-baseline-modes-expected.png:
- platform/qt/svg/custom/bug45331-expected.png:
- platform/qt/svg/custom/circular-marker-reference-2-expected.png:
- platform/qt/svg/custom/class-baseValue-expected.png:
- platform/qt/svg/custom/clip-mask-negative-scale-expected.png:
- platform/qt/svg/custom/clip-path-referencing-use-expected.png:
- platform/qt/svg/custom/clip-path-with-transform-expected.png:
- platform/qt/svg/custom/conditional-processing-outside-switch-expected.png:
- platform/qt/svg/custom/container-opacity-clip-viewBox-expected.png:
- platform/qt/svg/custom/control-points-for-S-and-T-expected.png:
- platform/qt/svg/custom/convolution-crash-expected.png:
- platform/qt/svg/custom/create-metadata-element-expected.png:
- platform/qt/svg/custom/createelement-expected.png:
- platform/qt/svg/custom/display-none-expected.png:
- platform/qt/svg/custom/dominant-baseline-hanging-expected.png:
- platform/qt/svg/custom/dominant-baseline-modes-expected.png:
- platform/qt/svg/custom/dynamic-svg-document-creation-expected.png:
- platform/qt/svg/custom/embedding-external-svgs-expected.png:
- platform/qt/svg/custom/empty-clip-path-expected.png:
- platform/qt/svg/custom/evt-onload-expected.png:
- platform/qt/svg/custom/fill-SVGPaint-interface-expected.png:
- platform/qt/svg/custom/fill-fallback-expected.png:
- platform/qt/svg/custom/fill-update-expected.png:
- platform/qt/svg/custom/fractional-rects-expected.png:
- platform/qt/svg/custom/getPresentationAttribute-expected.png:
- platform/qt/svg/custom/getscreenctm-in-mixed-content-expected.png:
- platform/qt/svg/custom/getsvgdocument-expected.png:
- platform/qt/svg/custom/gradient-attr-update-expected.png:
- platform/qt/svg/custom/gradient-cycle-detection-expected.png:
- platform/qt/svg/custom/gradient-rotated-bbox-expected.png:
- platform/qt/svg/custom/gradient-stop-corner-cases-expected.png:
- platform/qt/svg/custom/group-opacity-expected.png:
- platform/qt/svg/custom/hit-test-with-br-expected.png:
- platform/qt/svg/custom/image-parent-translation-expected.png:
- platform/qt/svg/custom/image-rescale-scroll-expected.png:
- platform/qt/svg/custom/image-with-aspect-ratio-stretch-expected.png:
- platform/qt/svg/custom/image-with-transform-clip-filter-expected.png:
- platform/qt/svg/custom/inner-svg-hit-test-expected.png:
- platform/qt/svg/custom/invalid-fill-expected.png:
- platform/qt/svg/custom/invalid-fill-hex-expected.png:
- platform/qt/svg/custom/invalid-lengthlist-expected.png:
- platform/qt/svg/custom/invalid-stroke-hex-expected.png:
- platform/qt/svg/custom/invalid-uri-stroke-expected.png:
- platform/qt/svg/custom/invisible-text-after-scrolling-expected.png:
- platform/qt/svg/custom/junk-data-expected.png:
- platform/qt/svg/custom/large-bounding-box-percents-expected.png:
- platform/qt/svg/custom/linking-a-03-b-transform-expected.png:
- platform/qt/svg/custom/linking-a-03-b-viewBox-expected.png:
- platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
- platform/qt/svg/custom/linking-uri-01-b-expected.png:
- platform/qt/svg/custom/marker-changes-expected.png:
- platform/qt/svg/custom/marker-empty-path-expected.png:
- platform/qt/svg/custom/mask-changes-expected.png:
- 4:52 AM Changeset in webkit [146869] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix unused parameter warnings in JITInlines.h
https://bugs.webkit.org/show_bug.cgi?id=112560
Reviewed by Zoltan Herczeg.
- jit/JITInlines.h:
(JSC::JIT::beginUninterruptedSequence):
(JSC::JIT::endUninterruptedSequence):
(JSC):
- 4:49 AM Changeset in webkit [146868] by
-
- 2 edits in trunk/Tools
[Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
https://bugs.webkit.org/show_bug.cgi?id=113287
Reviewed by Jocelyn Turcotte.
- Scripts/run-qtwebkit-tests:
(Options.init):
- 4:37 AM Changeset in webkit [146867] by
-
- 3 edits2 adds in trunk
Unable to insert a paragraph in between some text whose previous sibling is a non-editable block.
https://bugs.webkit.org/show_bug.cgi?id=113007
Patch by Arpita Bahuguna <a.bah@samsung.com> on 2013-03-26
Reviewed by Ryosuke Niwa.
Source/WebCore:
Unable to insert a line break in between a text that follows a
non-editable block but is itself contained within an editable
block.
While comparing the positions from the start block till the
insertion position, we should ignore the nodes that do not
generate a visiblePosition for the position before the node.
This ultimately results in an assert within comparePositions().
For this case, the firstChild of the start block is a text
node with no renderer which would thus not generate a candidate
position for itself.
There is also no candidate previous to it, and since
the position after it lies within a different editable element (root),
no candidate after it as well.
Such a point will thus return a null visiblePosition.
Test: editing/inserting/insert-paragraph-between-text.html
- editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
Added a check to verify the generated visiblePosition (for the
position before the node) prior to carrying out a comparison with
the insertion point.
LayoutTests:
- editing/inserting/insert-paragraph-between-text-expected.txt: Added.
- editing/inserting/insert-paragraph-between-text.html: Added.
Added a layout test case for verifying the behavior when trying
to insert a line break between an editable text with a non-editable
block as it's previous sibling.
- 4:23 AM Changeset in webkit [146866] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: OverviewGrid. Dragged window may change its width due to accumulating rounding error.
https://bugs.webkit.org/show_bug.cgi?id=113138
Reviewed by Pavel Feldman.
The old version had problem with rounding because it recalculates the window size on each event.
The new version just calculates the dragging delta and moves the window
to the new position based on the initial values and the delta.
- inspector/front-end/OverviewGrid.js:
(WebInspector.OverviewGrid.Window.prototype._startWindowDragging):
(WebInspector.OverviewGrid.Window.prototype._windowDragging):
(WebInspector.OverviewGrid.Window.prototype._onMouseWheel):
- 3:44 AM Changeset in webkit [146865] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Memory leak in UserMediaClientImpl
https://bugs.webkit.org/show_bug.cgi?id=112998
Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-03-26
Reviewed by Rob Buis.
PR 312559
Internally Reviewed by Anthony Scian.
Should destroy itself in UserMediaClientImpl::pageDestroyed(), as other
XXClientBlackBerry did, like GeolocationClientBlackBerry::geolocationDestroyed().
- WebCoreSupport/UserMediaClientImpl.cpp:
(WebCore::UserMediaClientImpl::pageDestroyed):
- 3:41 AM Changeset in webkit [146864] by
-
- 6 edits in trunk
[EFL] Enable IndexedDB by default
https://bugs.webkit.org/show_bug.cgi?id=107248
Patch by Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> on 2013-03-26
Reviewed by Laszlo Gombos.
.:
- Source/cmake/OptionsEfl.cmake:
Enable IndexedDB by default on EFL.
Tools:
- Scripts/webkitperl/FeatureList.pm:
Enable IndexedDB by default on EFL.
LayoutTests:
- platform/efl/TestExpectations:
Unskip the tests now that IndexDB is enabled (except the ones
that actually fail).
- 3:39 AM Changeset in webkit [146863] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- 1:43 AM Changeset in webkit [146862] by
-
- 10 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebaselining after r146814.
- platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
- platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
- platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt:
- platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
- platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-positioned-expected.txt:
- platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
- platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-transformed-expected.txt:
- platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
- platform/qt-5.0-wk1/compositing/layer-creation/scroll-partial-update-expected.txt:
- 1:40 AM Changeset in webkit [146861] by
-
- 3 edits in trunk/Tools
Sheriffbot should explain rollout failures in a human readable form.
https://bugs.webkit.org/show_bug.cgi?id=107092
Patch by Alan Cutter <alancutter@chromium.org> on 2013-03-26
Reviewed by Ryosuke Niwa.
Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
- Scripts/webkitpy/tool/bot/irc_command.py:
(Rollout._check_diff_failure):
(Rollout.execute):
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_rollout):
- 1:26 AM Changeset in webkit [146860] by
-
- 11 edits in trunk/Source/WebCore
Rename HTMLInputElement::isIndeterminate to Element::shouldAppearIndeterminate
https://bugs.webkit.org/show_bug.cgi?id=113264
Reviewed by Kentaro Hara.
HTMLInputElement had indeterminate() and isIndeterminate(). It's very
confusing.
Because indeterminate is a public DOM function and isIndeterminate is
for CSS and rendering, we rename isIndetermiante to
shouldAppearIndeterminate. Also, HTMLProgressElement, which support
:indeterminate pseudo class, should follow it. We add
shouldAppearIndeterminate to Element.
No new tests. Just a refactoring.
- dom/Element.cpp:
(WebCore::Element::shouldAppearIndeterminate): Added. Returns false.
- dom/Element.h:
(Element): Declare shouldAppearIndeterminate.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::shouldAppearIndeterminate):
Renamed from isIndeterminate.
- html/HTMLInputElement.h:
(HTMLInputElement): Rename isIndeterminate to shouldAppearIndeterminate,
and overrides Element::shouldAppearIndeterminate.
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::shouldAppearIndeterminate): Added.
- html/HTMLProgressElement.h: Add shouldAppearIndeterminate.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isIndeterminate):
Use shouldAppearIndeterminate.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne): Ditto.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithControl): Ditto.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isIndeterminate): Ditto.
- 1:21 AM Changeset in webkit [146859] by
-
- 2 edits in trunk/Tools
Unreviewed GTK gardening.
- Scripts/run-gtk-tests:
(TestRunner): Skipping a failing unit test after r146518.
- 1:20 AM Changeset in webkit [146858] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [FlameChart] Make function bar highlighted consistent with cursor.
https://bugs.webkit.org/show_bug.cgi?id=113266.
Patch by Pan Deng <pan.deng@intel.com> on 2013-03-26
Reviewed by Vsevolod Vlasov.
In Flamechart, the highlighted function bar is not consistent with cursor sometimes,
reason is that time range that converted from cursor position is truncated by floor.
Actually float value is expected to compare with function startTime and duration.
No new tests.
- inspector/front-end/FlameChart.js:
(WebInspector.FlameChart.prototype._coordinatesToNodeIndex): Remove floor
- 1:09 AM Changeset in webkit [146857] by
-
- 4 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adjusting expectation for inspector/debugger/live-edit-breakpoints.html after r146840.
- platform/gtk/fast/text/international/khmer-selection-expected.txt: Rebaselining after r146778.
- platform/gtk/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt: Rebaselining
after r146763.
- 12:54 AM Changeset in webkit [146856] by
-
- 3 edits2 adds in trunk
[CSSRegions]: Crash accessing offsetParent for contentNodes inside a flow thread
https://bugs.webkit.org/show_bug.cgi?id=112730
Reviewed by Levi Weintraub.
Source/WebCore:
When computing the offsetParent for an element inside a flow thread, do not
let the algorithm process past the flow thread boundaries, until we figure out
the proper behavior. When reaching the flow thread, offsetParent will return 0,
thus preventing the assert while calling toElement inside Element::offsetParent.
The attached test sets the ground work and will be changed to match the right behavior.
For now, it makes sure we do not crash or return HTMLDocument as offsetParent for
elements inside the flow thread.
Test: fast/regions/offsetParent-in-flow-thread.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::offsetParent):
LayoutTests:
- fast/regions/offsetParent-in-flow-thread-expected.txt: Added.
- fast/regions/offsetParent-in-flow-thread.html: Added.
- 12:51 AM Changeset in webkit [146855] by
-
- 6 edits2 deletes in trunk/Source/WebCore
Remove HarfBuzzShaperBase
https://bugs.webkit.org/show_bug.cgi?id=112087
Reviewed by Martin Robinson.
Folding HarfBuzzShaperBase into HarfBuzzShaper since
there is no harfbuzz-old vs. harfbuzz-ng distinction anymore.
No new tests, no change in behavior.
- GNUmakefile.list.am: Removing HarfBuzzShaperBase.*
- PlatformEfl.cmake: Removing HarfBuzzShaperBase.*
- WebCore.gypi: Removing HarfBuzzShaperBase.*
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp: Folding base class members and methods into HarfBuzzShaper.
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::normalizeSpacesAndMirrorChars):
(WebCore):
(WebCore::HarfBuzzShaper::setNormalizedBuffer):
(WebCore::HarfBuzzShaper::isWordEnd):
(WebCore::HarfBuzzShaper::determineWordBreakSpacing):
(WebCore::HarfBuzzShaper::setPadding):
- platform/graphics/harfbuzz/HarfBuzzShaper.h: Folding base class members and methods into HarfBuzzShaper.
(HarfBuzzShaper):
(WebCore::HarfBuzzShaper::isCodepointSpace):
- platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp: Removed.
- platform/graphics/harfbuzz/HarfBuzzShaperBase.h: Removed.
- 12:33 AM Changeset in webkit [146854] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. Rebaseline fast/canvas/canvas-toDataURL-webp.html
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-toDataURL-webp-expected.png:
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-toDataURL-webp-expected.png:
Mar 25, 2013:
- 11:39 PM Changeset in webkit [146853] by
-
- 6 edits2 adds in trunk
Listening touch events on ShadowRoot can crash.
https://bugs.webkit.org/show_bug.cgi?id=113035
Reviewed by Kentaro Hara.
Source/WebCore:
TreeScope destructor clears a document reference on ShadowRoot but
destructors of ContainerNode and Node assumed it being available
and tried to access it for some cleanup purposes.
This change extracts such cleanup to Node::willBeDeletedFrom() and
calls it from ShadowRoot dtor before the document reference gets cleared.
Test: fast/dom/shadow/shadow-root-touch-listener-crash.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::~ContainerNode): Adopted willBeDeletedFrom()
- dom/Node.cpp:
(WebCore::Node::~Node): Adopted willBeDeletedFrom()
(WebCore::Node::willBeDeletedFrom): Extracted from Node and ContainerNode
(WebCore):
- dom/Node.h:
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::~ShadowRoot): Adopted willBeDeletedFrom()
LayoutTests:
- fast/dom/shadow/shadow-root-touch-listener-crash-expected.txt: Added.
- fast/dom/shadow/shadow-root-touch-listener-crash.html: Added.
- 11:35 PM Changeset in webkit [146852] by
-
- 2 edits in trunk/Tools
Remove Lion leaks builder
https://bugs.webkit.org/show_bug.cgi?id=113252
Reviewed by Andreas Kling.
Removed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 11:35 PM Changeset in webkit [146851] by
-
- 6 edits2 deletes in trunk/Source/WebCore
Custom Elements Refactoring: The name V8CustomElement is confusing.
https://bugs.webkit.org/show_bug.cgi?id=113165
Reviewed by Kent Tamura.
This change moves functions from V8CustomElement to CustomElementHelpers and
removes V8CustomElement. V8CustomElement is just a heritage of old design
and no longer makes sense.
No new tests. No behavior change.
- WebCore.gypi:
- bindings/v8/CustomElementHelpers.cpp:
(WebCore::CustomElementHelpers::createWrapper):
(WebCore):
- bindings/v8/CustomElementHelpers.h:
(CustomElementHelpers):
(WebCore::CustomElementHelpers::wrap):
(WebCore):
(WebCore::CustomElementHelpers::constructorOf):
- bindings/v8/V8CustomElement.cpp: Removed.
- bindings/v8/V8CustomElement.h: Removed.
- bindings/v8/custom/V8CustomElementConstructorCustom.cpp:
(WebCore::V8CustomElementConstructor::callAsFunctionCallback):
- dom/make_names.pl:
(printWrapperFactoryCppFile):
- 11:07 PM Changeset in webkit [146850] by
-
- 5 edits1 add1 delete in trunk/LayoutTests
Update a few more chromium compositor baselines.
- platform/chromium-linux/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
- platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Removed.
- 9:51 PM Changeset in webkit [146849] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Timeline] Records sidebar is clipped.
https://bugs.webkit.org/show_bug.cgi?id=113177
Reviewed by Pavel Feldman.
Analysis: depending on CSS injection order sidebar rule that overwrites
"bottom" property may win.
Fix: make timeline-specific rule "important".
- inspector/front-end/timelinePanel.css:
(.timeline .sidebar): Make "bottom" value "important".
- 9:04 PM Changeset in webkit [146848] by
-
- 4 edits in trunk/LayoutTests
[chromium] Rebaseline canvas-toDataURL-webp test expectations
https://bugs.webkit.org/show_bug.cgi?id=93310
Unreviewed test expectations update.
- platform/chromium-mac/fast/canvas/canvas-toDataURL-webp-expected.png:
- platform/chromium-win/fast/canvas/canvas-toDataURL-webp-expected.png:
- platform/chromium/TestExpectations:
- 8:28 PM Changeset in webkit [146847] by
-
- 35 edits in trunk
Rename ENABLE_INPUT_TYPE_DATETIME
https://bugs.webkit.org/show_bug.cgi?id=113254
Reviewed by Kentaro Hara.
Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
Actually I'd like to remove the code, but we shouldn't remove it yet
because we shipped products with it on some platforms.
.:
- Source/autotools/SetupWebKitFeatures.m4:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
- css/html.css:
- html/DateTimeInputType.cpp:
- html/DateTimeInputType.h:
- html/InputType.cpp:
(WebCore::createInputTypeFactoryMap):
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataEnableFeatures.in:
Source/WebKit/chromium:
- src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableInputTypeDateTime):
(WebKit::WebRuntimeFeatures::isInputTypeDateTimeEnabled):
- tests/WebViewTest.cpp:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.props:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.props:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
LayoutTests:
- platform/chromium/TestExpectations:
- 8:19 PM Changeset in webkit [146846] by
-
- 4 edits in trunk/LayoutTests
REGRESSION(r146657): NRWT shouldn't report image only failures when pixel tests are disabled
https://bugs.webkit.org/show_bug.cgi?id=113261
Reviewed by Dirk Pranke.
Fixed the bug by treating ['TEXT', 'IMAGE'] as a flaky pass when the pixel tests is disabled
since the second token implies that we've forced pixel tests in retry and didn't have text failures.
- fast/harness/resources/results-test.js:
- fast/harness/results.html:
- fast/harness/results-expected.txt:
- 8:13 PM Changeset in webkit [146845] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] add needReferer in WebPage load() api
https://bugs.webkit.org/show_bug.cgi?id=113167
Reviewed by Rob Buis.
PR310175, internally reviewed by Joe Mason.
Sometimes when client load request, it need to add referer with current frame like
save link/image in option menu, so we add needRef in load() interface in webpage.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPage::load):
(BlackBerry::WebKit::WebPage::loadExtended):
(BlackBerry::WebKit::WebPage::loadFile):
(BlackBerry::WebKit::WebPage::download):
- Api/WebPage.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- 8:11 PM Changeset in webkit [146844] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update Efl test expectations to mark new test as failing.
Efl doesn't implement the Pasteboard class.
- platform/efl/TestExpectations: Mark editing/pasteboard/copy-image-with-alt-text.html as failing
- 8:02 PM Changeset in webkit [146843] by
-
- 7 edits1 delete in trunk/Source
[chromium] Move ownership of compositor VideoLayer to WebMediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=112971
Reviewed by James Robinson.
Source/Platform:
Defines REMOVE_WEBVIDEOFRAME in related headers to enable this code
path in chromium.
- chromium/public/WebVideoFrame.h:
- chromium/public/WebVideoFrameProvider.h:
Source/WebKit/chromium:
This moves ownership of the compositor's video layer over to the
implementation of WebMediaPlayer, as well as all interaction
between the media player system and the compositor layer or its
interfaces such as cc::VideoFrameProvider.
Now, the WebMediaPlayer implementation calls setWebLayer() to
provide the WebLayer* to the WebMediaPlayerClientImpl so that
it can be inserted into the GraphicsLayer tree appropriately.
Defines REMOVE_WEBVIDEOFRAME in related headers to enable this code
path in chromium.
Once chromium removes its use of WebVideoFrame and its related
classes, we can remove them from WebKit entirely.
- WebKit.gypi:
- public/WebMediaPlayer.h:
(WebKit):
- public/WebMediaPlayerClient.h:
- public/WebStreamTextureClient.h:
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::setWebLayer):
(WebKit::WebMediaPlayerClientImpl::loadRequested):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::paint):
(WebKit::WebMediaPlayerClientImpl::needsWebLayer):
(WebKit::WebMediaPlayerClientImpl::supportsAcceleratedRendering):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::create):
(WebKit::WebMediaPlayerClientImpl::supportsType):
- src/WebMediaPlayerClientImpl.h:
(WebKit):
(WebMediaPlayerClientImpl):
- tests/WebMediaPlayerClientImplTest.cpp: Removed.
- 7:51 PM Changeset in webkit [146842] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r190515. Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-25
- DEPS:
- 7:43 PM Changeset in webkit [146841] by
-
- 20 edits3 copies1 add10 deletes in trunk/LayoutTests
Update more expectations and baselines for r146826
- platform/chromium-linux-x86/compositing/iframes/scrolling-iframe-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/iframes/scrolling-iframe-expected.txt.
- platform/chromium-linux/compositing/iframes/scrolling-iframe-expected.txt:
- platform/chromium-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/chromium-mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
- platform/chromium-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Removed.
- platform/chromium-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt: Removed.
- platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-expected.txt: Removed.
- platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Removed.
- platform/chromium-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
- platform/chromium-win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
- platform/chromium-win/compositing/layer-creation/scroll-partial-update-expected.txt: Removed.
- platform/chromium-win/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
- platform/chromium-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/compositing/backing/no-backing-for-clip-expected.txt: Removed.
- platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt: Removed.
- platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt: Removed.
- platform/chromium/compositing/iframes/become-overlapped-iframe-expected.txt:
- platform/chromium/compositing/iframes/composited-parent-iframe-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe2-expected.txt:
- platform/chromium/compositing/iframes/connect-compositing-iframe3-expected.txt:
- platform/chromium/compositing/iframes/enter-compositing-iframe-expected.txt:
- platform/chromium/compositing/iframes/iframe-resize-expected.txt:
- platform/chromium/compositing/iframes/iframe-size-from-zero-expected.txt:
- platform/chromium/compositing/iframes/overlapped-iframe-expected.txt:
- platform/chromium/compositing/iframes/resizer-expected.txt:
- platform/chromium/compositing/iframes/scrolling-iframe-expected.txt:
- platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Removed.
- platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt: Removed.
- platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
- 7:35 PM Changeset in webkit [146840] by
-
- 9 edits5 adds in trunk
Make the Web Inspector console work in strict mode with JavaScriptCore.
https://webkit.org/b/65829
rdar://problem/11271238
Reviewed by Oliver Hunt.
Source/WebCore:
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::evaluate):
Return the evalFunction directly.
- inspector/InjectedScriptHost.h:
(WebCore::InjectedScriptHost::evaluateReturnsEvalFunction):
Added. Return true on JSC and false on V8.
- inspector/InjectedScriptHost.idl:
Added evaluateReturnsEvalFunction and change evaluate to an attribute on JSC.
- inspector/InjectedScriptSource.js:
(InjectedScript.prototype._evaluateOn): Change from using 'with' statements to creating
a closure that evaluates the expression. The command line APIs are passed as parameters
to the closure so they are in scope but not injected. This allows the code evaluated in
the console to stay in strict mode (if is was already set), or to get strict mode by
prefixing expressions with 'use strict';.
LayoutTests:
- inspector/debugger/mutation-observer-suspend-while-paused.html: Tweaked.
- inspector/console/command-line-api-expected.txt: Updated.
- platform/mac/http/tests/inspector/console-resource-errors-expected.txt: Added.
- platform/mac/http/tests/inspector/console-websocket-error-expected.txt: Updated.
- platform/mac/inspector/console/console-eval-syntax-error-expected.txt: Added.
- platform/mac/inspector/debugger/debugger-pause-in-eval-script-expected.txt: Added.
- platform/mac/inspector/extensions/extensions-eval-expected.txt: Added.
Added new expectations to match the new console evaluate approach.
- 7:14 PM Changeset in webkit [146839] by
-
- 3 edits4 copies2 moves5 adds10 deletes in trunk/LayoutTests
Update chromium baselines for windows related to r146826
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
- platform/chromium-linux/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
- platform/chromium-linux/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
- platform/chromium-mac-lion/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
- platform/chromium-mac/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
- platform/chromium-mac/compositing/geometry/preserve-3d-switching-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
- platform/chromium-win-xp/compositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
- platform/chromium-win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
- platform/chromium-win/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Removed.
- platform/chromium/compositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
- platform/chromium/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
- platform/chromium/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/compositing/geometry/object-clip-rects-assertion-expected.txt.
- 7:02 PM Changeset in webkit [146838] by
-
- 2 edits in trunk/Tools
Remove one more line that was intended to be removed in r146657.
- Scripts/webkitpy/layout_tests/models/test_run_results.py:
(summarize_results):
- 6:44 PM Changeset in webkit [146837] by
-
- 4 edits in trunk
Unreviewed, rolling out r146816, r146821, and r146830.
http://trac.webkit.org/changeset/146816
http://trac.webkit.org/changeset/146821
http://trac.webkit.org/changeset/146830
https://bugs.webkit.org/show_bug.cgi?id=113262
Broke all the Windows tests (Requested by rfong on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-25
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
LayoutTests:
- platform/win/TestExpectations:
- 6:36 PM Changeset in webkit [146836] by
-
- 2 edits in trunk/LayoutTests
Revert bad change to expectation from r146826
- compositing/geometry/object-clip-rects-assertion-expected.txt:
- 6:33 PM Changeset in webkit [146835] by
-
- 25 edits2 adds in trunk
Image alt text not included in plain-text version when copying
https://bugs.webkit.org/show_bug.cgi?id=11200
Reviewed by Ryosuke Niwa.
Source/WebCore:
Add a setting to enable copying image alt text to the clipboard and drag and drop pasteboard.
This setting is disabled by default, so each port can enable if they want to match IE10 and
Firefox's behavior.
Test: editing/pasteboard/copy-image-with-alt-text.html
- editing/Editor.cpp:
(WebCore::Editor::cut): Explicitly ask that the selection on the pasteboard as being for the clipboard.
(WebCore::Editor::copy): Explicitly ask that the selection on the pasteboard as being for the clipboard.
(WebCore::Editor::selectedText): Add a private version of selectedText() that can choose between having image alt text or not.
(WebCore::Editor::selectedTextForClipboard): Ask for image alt text if the setting is enabled.
- editing/Editor.h:
- editing/TextIterator.cpp:
(WebCore::TextIterator::TextIterator): Add a bool to keep track of whether or not to emit image alt text.
(WebCore::TextIterator::handleReplacedElement): If there's alt text, point the iterator to it.
- editing/TextIterator.h:
(TextIterator):
- editing/mac/EditorMac.mm:
(WebCore::Editor::takeFindStringFromSelection): Use the same text as on the clipboard.
(WebCore::Editor::writeSelectionToPasteboard): Don't include image alt text since this is
used by Services.
(WebCore::Editor::stringSelectionForPasteboard): Don't include image alt text since this is
used by Services.
- page/DragController.cpp:
(WebCore::DragController::startDrag): Use image alt text (matches Firefox).
- page/Settings.in: Add a setting that disables image alt text by default.
- platform/Pasteboard.h:
- platform/blackberry/PasteboardBlackBerry.cpp:
(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
- platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::writeRange): Use clipboard text when writing ranges (used by d&d).
- platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
- platform/efl/PasteboardEfl.cpp:
(WebCore::Pasteboard::writeSelection): Update function param.
- platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::writeRange): Use clipboard text when writing ranges (used by d&d).
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
- platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::writeRange): Use clipboard text when writing ranges (used by d&d).
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::getStringSelection): Use ShouldSerializeSelectedTextForClipboard to determine whether the selected
text is for the clipboard or not.
(WebCore::Pasteboard::writeSelectionForTypes): Pass ShouldSerializeSelectedTextForClipboard through.
(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
- platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::writeRange): Use clipboard text when writing ranges (used by d&d).
- platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
- platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::writeRange): Use clipboard text when writing ranges (used by d&d).
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
- platform/wince/PasteboardWinCE.cpp:
(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
- platform/wx/PasteboardWx.cpp:
(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.
- rendering/RenderImage.h:
(WebCore::RenderImage::altText): Add a getter for the alt text.
LayoutTests:
- editing/pasteboard/copy-image-with-alt-text-expected.txt: Added.
- editing/pasteboard/copy-image-with-alt-text.html: Added.
- 6:23 PM Changeset in webkit [146834] by
-
- 3 edits9 moves13 adds2 deletes in trunk/LayoutTests
Update chromium mac 10.6 and 10.8 baselines for r146826.
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
- platform/chromium-mac-lion/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/composited-in-columns-expected.txt: Removed.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
- platform/chromium-mac/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
- platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css3/filters/filtered-compositing-descendant-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-clip-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-perspective-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-perspective-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/composited-in-columns-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/compositing/geometry/composited-in-columns-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-overflow-root-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/preserve-3d-switching-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/layer-creation/scroll-partial-update-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/crash-reparent-tiled-layer-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/tiling/crash-reparent-tiled-layer-expected.txt.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-resize-expected.txt.
- platform/chromium-win/compositing/geometry/composited-in-columns-expected.txt: Renamed from LayoutTests/platform/chromium/compositing/geometry/composited-in-columns-expected.txt.
- platform/chromium-win/css3/filters/filtered-compositing-descendant-expected.txt: Renamed from LayoutTests/platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt.
- 6:02 PM Changeset in webkit [146833] by
-
- 10 edits2 deletes in trunk/Source/WebCore
Remove autostart hashing code from WebCore
https://bugs.webkit.org/show_bug.cgi?id=113242
Reviewed by Tim Horton.
Remove PlugInOriginHash and all the related build entries.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLPlugInImageElement.cpp:
- plugins/PlugInOriginHash.cpp: Removed.
- plugins/PlugInOriginHash.h: Removed.
- 5:40 PM Changeset in webkit [146832] by
-
- 7 edits7 adds in trunk/LayoutTests
[chromium] Rebaselining, etc.
https://bugs.webkit.org/show_bug.cgi?id=109507
https://bugs.webkit.org/show_bug.cgi?id=112927
Unreviewed, test expectations update.
- platform/chromium-mac-lion/css3/filters/effect-reference-expected.txt: Added.
- platform/chromium-mac-lion/css3/filters/effect-reference-hw-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.txt: Added.
- platform/chromium-mac-snowleopard/css3/filters/effect-reference-hw-expected.txt: Added.
- platform/chromium-mac/compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt:
- platform/chromium-mac/css3/filters/effect-reference-expected.png:
- platform/chromium-mac/css3/filters/effect-reference-expected.txt:
- platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
- platform/chromium-mac/css3/filters/effect-reference-hw-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-opacity-transition-expected.txt: Added.
- platform/chromium-win-xp/fast/text/international/bold-bengali-expected.png: Added.
- platform/chromium-win-xp/fast/text/international/bold-bengali-expected.txt: Added.
- platform/chromium/TestExpectations:
- 5:36 PM Changeset in webkit [146831] by
-
- 4 edits in trunk/Source/JavaScriptCore
Offlineasm cloop backend compiles op+branch incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=113146.
Reviewed by Geoffrey Garen.
- dfg/DFGRepatch.h:
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):
- These functions never return when the DFG is dsiabled, not just when asserts are enabled. Changing the attribute from NO_RETURN_DUE_TO_ASSERT to NO_RETURN.
- llint/LLIntOfflineAsmConfig.h:
- Added some #defines needed to get the cloop building again.
- offlineasm/cloop.rb:
- Fix cloopEmitOpAndBranchIfOverflow() and cloopEmitOpAndBranch() to emit code that unconditionally executes the specified operation before doing the conditional branch.
- 5:27 PM Changeset in webkit [146830] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Wrong place to enable RuntimeEnabledFeature for Windows.
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- 5:14 PM Changeset in webkit [146829] by
-
- 3 edits3 adds in trunk
JSObject::enterDictionaryIndexingMode doesn't have a case for ALL_BLANK_INDEXING_TYPES
https://bugs.webkit.org/show_bug.cgi?id=113236
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- runtime/JSObject.cpp:
(JSC::JSObject::enterDictionaryIndexingMode): We forgot blank indexing types.
LayoutTests:
New test case that tests calling Object.freeze on Array.prototype.
- fast/js/enter-dictionary-indexing-mode-with-blank-indexing-type-expected.txt: Added.
- fast/js/enter-dictionary-indexing-mode-with-blank-indexing-type.html: Added.
- fast/js/script-tests/enter-dictionary-indexing-mode-with-blank-indexing-type.js: Added.
- 5:11 PM Changeset in webkit [146828] by
-
- 7 edits1 move29 adds5 deletes in trunk/LayoutTests
Update chromium baselines for r146826
- platform/chromium-linux-x86/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
- platform/chromium-linux-x86/css3/filters/filtered-compositing-descendant-expected.txt: Added.
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Added.
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
- platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
- platform/chromium-linux/compositing/geometry/fixed-in-composited-expected.png:
- platform/chromium-linux/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
- platform/chromium-linux/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
- platform/chromium-linux/css3/filters/filtered-compositing-descendant-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
- platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Added.
- platform/chromium-mac-lion/compositing/geometry/composited-in-columns-expected.txt: Added.
- platform/chromium-mac-lion/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
- platform/chromium-mac-lion/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
- platform/chromium-mac-lion/css3/filters/filtered-compositing-descendant-expected.txt: Added.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-clip-expected.txt: Added.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-perspective-expected.txt: Added.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/composited-in-columns-expected.txt: Added.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Added.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Added.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/preserve-3d-switching-expected.txt: Added.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/layer-creation/scroll-partial-update-expected.txt: Added.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
- platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Added.
- platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
- platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
- platform/chromium-win/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
- platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
- 4:46 PM Changeset in webkit [146827] by
-
- 3 edits in trunk/Tools
No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
Re-enable WinEWS tests.
- Scripts/webkitpy/common/config/ports.py:
(WinPort.run_bindings_tests_command):
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 4:34 PM Changeset in webkit [146826] by
-
- 128 edits11 deletes in trunk
[chromium] Support GraphicsLayer::setContentsToSolidColor
https://bugs.webkit.org/show_bug.cgi?id=104396
Reviewed by Adrienne Walker.
Source/WebCore:
This enables and implements the GraphicsLayer::setContentsToSolidColor
path for Chromium.
Tested by reftests in compositing/background-color/ and several other
compositing/ tests.
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::supportsBackgroundColorContent):
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToSolidColor):
(WebCore):
- platform/graphics/chromium/GraphicsLayerChromium.h:
(WebKit):
(GraphicsLayerChromium):
Source/WebKit/chromium:
Updates some unit tests for better include discipline.
- tests/GraphicsLayerChromiumTest.cpp:
- tests/ImageLayerChromiumTest.cpp:
- 4:30 PM Changeset in webkit [146825] by
-
- 8 edits3 copies2 adds in trunk
TextTrack Extension for WebVTT Regions
https://bugs.webkit.org/show_bug.cgi?id=109820
Reviewed by Eric Carlson.
Source/WebCore:
Implemented the TextTrackRegionList and extended TextTrack with
methods required for proper interaction with TextTrackRegion objects.
Test: media/track/regions-webvtt/text-track-region-list.html
- WebCore.gypi: Added files for proper building of TextTrackRegionList.
- html/track/TextTrack.cpp:
(WebCore::TextTrack::TextTrack):
(WebCore):
(WebCore::TextTrack::ensureTextTrackRegionList): Method for creating a
TextTrackRegionList associated with the current track, if it does exist
already.
(WebCore::TextTrack::regions): Getter for the regions object.
(WebCore::TextTrack::addRegion): Method for adding a region.
(WebCore::TextTrack::removeRegion): Method for removing a region.
- html/track/TextTrack.h:
(WebCore):
(TextTrack):
- html/track/TextTrack.idl: Added methods specific for region handling.
- html/track/TextTrackRegion.cpp:
(WebCore::TextTrackRegion::TextTrackRegion): Initialized the track member variable.
(WebCore::TextTrackRegion::setTrack): Added internal setter for the track attribute.
(WebCore):
(WebCore::TextTrackRegion::updateParametersFromRegion): Method to copy the parameters
from a different region object.
- html/track/TextTrackRegion.h: Added track member variable and copy method.
(WebCore::TextTrackRegion::track): Getter retrieves now the member variable.
(TextTrackRegion):
- html/track/TextTrackRegionList.cpp: Implemented methods required by the IDL.
(WebCore):
(WebCore::TextTrackRegionList::TextTrackRegionList):
(WebCore::TextTrackRegionList::length):
(WebCore::TextTrackRegionList::item):
(WebCore::TextTrackRegionList::getRegionById):
(WebCore::TextTrackRegionList::add):
(WebCore::TextTrackRegionList::remove):
(WebCore::TextTrackRegionList::clear):
- html/track/TextTrackRegionList.h:
(WebCore):
(TextTrackRegionList):
(WebCore::TextTrackRegionList::create):
(WebCore::TextTrackRegionList::~TextTrackRegionList):
- html/track/TextTrackRegionList.idl: IDL defined by the specification.
LayoutTests:
- media/track/regions-webvtt/text-track-region-list-expected.txt: Added.
- media/track/regions-webvtt/text-track-region-list.html: Added.
- 4:29 PM Changeset in webkit [146824] by
-
- 7 edits1 add in trunk/Source
Unreviewed, rolling out r146819.
http://trac.webkit.org/changeset/146819
https://bugs.webkit.org/show_bug.cgi?id=113249
broke component build (Requested by danakj on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-25
Source/Platform:
- chromium/public/WebVideoFrame.h:
Source/WebKit/chromium:
- WebKit.gypi:
- public/WebMediaPlayerClient.h:
(WebKit):
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::disableAcceleratedCompositing):
(WebKit::WebMediaPlayerClientImpl::loadRequested):
(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::paint):
(WebKit::WebMediaPlayerClientImpl::supportsAcceleratedRendering):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::create):
(WebKit::WebMediaPlayerClientImpl::supportsType):
- src/WebMediaPlayerClientImpl.h:
(WebKit):
(WebMediaPlayerClientImpl):
- tests/WebMediaPlayerClientImplTest.cpp: Added.
(WebKit):
(FakeWebMediaPlayerClientImpl):
(WebKit::FakeWebMediaPlayerClientImpl::create):
(WebKit::FakeWebMediaPlayerClientImpl::FakeWebMediaPlayerClientImpl):
(FakeVideoFrameProviderClient):
(WebKit::FakeVideoFrameProviderClient::create):
(WebKit::FakeVideoFrameProviderClient::~FakeVideoFrameProviderClient):
(WebKit::FakeVideoFrameProviderClient::didReceiveFrame):
(WebKit::FakeVideoFrameProviderClient::didUpdateMatrix):
(WebKit::FakeVideoFrameProviderClient::stopUsingProvider):
(WebKit::FakeVideoFrameProviderClient::provider):
(WebKit::FakeVideoFrameProviderClient::FakeVideoFrameProviderClient):
(WebKit::TEST):
- 4:27 PM Changeset in webkit [146823] by
-
- 20 edits in trunk/Source
Cleanup plugin snapshotting autostart decision making
https://bugs.webkit.org/show_bug.cgi?id=113231
Reviewed by Tim Horton.
Source/WebCore:
Move the code that creates a hash of plugin origin info
out of WebCore. All WebCore needs to do now is simply ask its
host layer whether or not a tuple of (pluginOrigin, pageOrigin, mimeType)
should autostart or not.
As a drive-by, the code in subframeLoaderWillCreatePlugIn was not quite
restarting properly when the displayState was Restarting or
RestartingWithPendingMouseClick. It still worked most of the time, but usually
because the code ran soon after a mouse click. Now it should be explicit and
also allowed us to be more clear about snapshotting at the end of the method.
- html/HTMLPlugInElement.h: No more pluginOriginHash().
- html/HTMLPlugInImageElement.cpp:
(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin): Change signature to accept the tuple
described above, and compare strings rather than hashes.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Tell host layer the origin
info rather than hash info.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Remember the url that
the plugin was loaded from. Make some of the logging messages more clear. Test for
plugin and page origin rather than hash.
- html/HTMLPlugInImageElement.h:
(WebCore::HTMLPlugInImageElement::loadedUrl): New loadedURL member function.
- page/PlugInClient.h:
(PlugInClient): Change signature of virtual class to accept origin and mimeType info
rather than hash.
Source/WebKit2:
Two major changes to the way snapshotting plugins may autostart.
The first is that previously WebCore was keeping a hash that
represented the combination of page origin, plugin origin and
mime type. WebKit was responsible for deciding if that particular
hash should autostart. Now, WebKit keeps the hash, and WebCore
just asks us whether the combination of origins and mimetype
should start immediately. You can see this change the in WebPluginClient
and WebProcess APIs.
The second change is that we now keep two types of structures
around to decide whether a plugin should autostart. One is the
existing page + plugin origin combination. The other is simply
the plugin origin, which allows plugins from major providers
to autostart no matter what page they were embedded on.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode): Encode the new parameter.
(WebKit::WebProcessCreationParameters::decode): Decode the new parameter.
- Shared/WebProcessCreationParameters.h: Also keep a list of strings around.
- UIProcess/API/C/WKContext.cpp:
(WKContextSetPlugInAutoStartOrigins): The C API to send the list of plugin
origins over to the context.
- UIProcess/API/C/WKContext.h:
- UIProcess/Plugins/PlugInAutoStartProvider.cpp:
(WebKit::PlugInAutoStartProvider::addAutoStartOriginHash): Renamed from addAutoStartOrigin.
No functional change other than new names for members.
(WebKit::PlugInAutoStartProvider::autoStartOriginHashesCopy): Ditto.
(WebKit::PlugInAutoStartProvider::autoStartOriginsTableCopy): Ditto.
(WebKit::PlugInAutoStartProvider::setAutoStartOriginsTable): Ditto.
(WebKit::PlugInAutoStartProvider::setAutoStartOriginsArray): New method that converts the
incoming ImmutableArray into a Vector of Strings.
(WebKit::PlugInAutoStartProvider::didReceiveUserInteraction): Rename for new members.
- UIProcess/Plugins/PlugInAutoStartProvider.h: Renaming member variables. Adding
some typedefs to clean up code.
(WebKit::PlugInAutoStartProvider::autoStartOrigins): New accessor.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess): Renaming, and copy the new parameter into the process creation.
(WebKit::WebContext::addPlugInAutoStartOriginHash): Renaming.
(WebKit::WebContext::setPlugInAutoStartOriginHashes): Renaming.
(WebKit::WebContext::setPlugInAutoStartOrigins): New method.
- UIProcess/WebContext.h: Adds the new setPlugInAutoStartOrigin method.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::didInitializePlugin): Drive-by fix that was attempting to restart plugins
that were in the process of restarting.
(WebKit::PluginView::pluginDidReceiveUserInteraction): Temporarily suspend update of
expiration time if the user interacts with a plugin.
- WebProcess/WebCoreSupport/WebPlugInClient.cpp:
(WebKit::WebPlugInClient::shouldAutoStartFromOrigin): Renaming.
(WebKit::WebPlugInClient::didStartFromOrigin): Ditto.
- WebProcess/WebCoreSupport/WebPlugInClient.h: Renaming.
- WebProcess/WebProcess.cpp: Drive-by - noticed that we forgot to count seconds in
a timeout threshold.
(WebKit::WebProcess::initializeWebProcess): Also add the list of origins when we initialize.
(WebKit::addCaseFoldedCharacters): Copied from WebCore - adds a String to a hash input.
(WebKit::hashForPlugInOrigin): Copied from WebCore - hashing function.
(WebKit::WebProcess::isPlugInAutoStartOriginHash): Renaming.
(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin): Check the list of pure origins first. If
that fails, fall back to the hash list of pairs.
(WebKit::WebProcess::plugInDidStartFromOrigin): Renaming.
(WebKit::WebProcess::didAddPlugInAutoStartOriginHash): Ditto.
(WebKit::WebProcess::resetPlugInAutoStartOriginHashes): Ditto.
(WebKit::WebProcess::plugInDidReceiveUserInteraction): Ditto.
- WebProcess/WebProcess.h: Renaming some methods, but also adding the input of the new
origin-only list.
- WebProcess/WebProcess.messages.in: Renaming a message.
- 4:07 PM Changeset in webkit [146822] by
-
- 4 edits in trunk
Unreviewed, rolling out r146793.
http://trac.webkit.org/changeset/146793
https://bugs.webkit.org/show_bug.cgi?id=113248
Fix did not work (Requested by rfong on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-25
Source/WebCore:
- bindings/scripts/preprocessor.pm:
(applyPreprocessor):
Tools:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 3:58 PM Changeset in webkit [146821] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Disable fast/exclusions and fast/regions tests on Windows.
https://bugs.webkit.org/show_bug.cgi?id=113244
- platform/win/TestExpectations:
- 3:51 PM Changeset in webkit [146820] by
-
- 14 edits3 copies3 adds in trunk
WEBGL_compressed_texture_pvrtc needs implementation
https://bugs.webkit.org/show_bug.cgi?id=110497
Patch by Brandon Jones <bajones@google.com> on 2013-03-25
Reviewed by Kenneth Russell.
Source/WebCore:
Test: webgl/conformance/extensions/webgl-compressed-texture-pvrtc.html
Exposes the WEBGL_compressed_texture_pvrtc extension, but is unverified since no desktop hardware supports
the format that I am aware of. Should enable mobile ports to expose the format, however.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
- html/canvas/WebGLCompressedTexturePVRTC.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(WebCore::WebGLCompressedTexturePVRTC::WebGLCompressedTexturePVRTC):
(WebCore::WebGLCompressedTexturePVRTC::~WebGLCompressedTexturePVRTC):
(WebCore::WebGLCompressedTexturePVRTC::getName):
(WebCore::WebGLCompressedTexturePVRTC::create):
(WebCore::WebGLCompressedTexturePVRTC::supported):
- html/canvas/WebGLCompressedTexturePVRTC.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(WebGLCompressedTexturePVRTC):
- html/canvas/WebGLCompressedTexturePVRTC.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):
- html/canvas/WebGLRenderingContext.h:
(WebCore):
(WebGLRenderingContext):
LayoutTests:
- webgl/conformance/extensions/webgl-compressed-texture-pvrtc-expected.txt: Added.
- webgl/conformance/extensions/webgl-compressed-texture-pvrtc.html: Added.
- webgl/resources/webgl_test_files/conformance/extensions/webgl-compressed-texture-pvrtc.html: Added.
- 3:48 PM Changeset in webkit [146819] by
-
- 7 edits1 delete in trunk/Source
[chromium] Move ownership of compositor VideoLayer to WebMediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=112971
Reviewed by James Robinson.
Source/Platform:
Defines REMOVE_WEBVIDEOFRAME in related headers to enable this code
path in chromium.
- chromium/public/WebVideoFrame.h:
- chromium/public/WebVideoFrameProvider.h:
Source/WebKit/chromium:
This moves ownership of the compositor's video layer over to the
implementation of WebMediaPlayer, as well as all interaction
between the media player system and the compositor layer or its
interfaces such as cc::VideoFrameProvider.
Now, the WebMediaPlayer implementation calls setWebLayer() to
provide the WebLayer* to the WebMediaPlayerClientImpl so that
it can be inserted into the GraphicsLayer tree appropriately.
Defines REMOVE_WEBVIDEOFRAME in related headers to enable this code
path in chromium.
Once chromium removes its use of WebVideoFrame and its related
classes, we can remove them from WebKit entirely.
- WebKit.gypi:
- public/WebMediaPlayer.h:
(WebKit):
- public/WebMediaPlayerClient.h:
- public/WebStreamTextureClient.h:
- src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::setWebLayer):
(WebKit::WebMediaPlayerClientImpl::loadRequested):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::paint):
(WebKit::WebMediaPlayerClientImpl::needsWebLayer):
(WebKit::WebMediaPlayerClientImpl::supportsAcceleratedRendering):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::create):
(WebKit::WebMediaPlayerClientImpl::supportsType):
- src/WebMediaPlayerClientImpl.h:
(WebKit):
(WebMediaPlayerClientImpl):
- tests/WebMediaPlayerClientImplTest.cpp: Removed.
- 3:18 PM Changeset in webkit [146818] by
-
- 2 edits in trunk/WebKitLibraries
Unreviewed. Also enable CSS_REGIONS and EXCLUSIONS for VS2010 solution.
- win/tools/vsprops/FeatureDefines.props:
- 3:08 PM Changeset in webkit [146817] by
-
- 5 edits in trunk/Tools
REGRESSION(r146657): Test failures reported incorrectly
https://bugs.webkit.org/show_bug.cgi?id=113223
Reviewed by Dirk Pranke.
The bug was caused by BuildBotPrinter not taking the new behavior into account.
Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run):
- Scripts/webkitpy/layout_tests/models/test_run_results.py:
(RunDetails.init):
(summarize_results): Remove the line I intended to remove in r146657.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(logging_run): Return details instead of the exit code.
(run_and_capture): Ditto.
(RunTest.test_full_results_html):
(RunTest.test_hung_thread):
(RunTest.test_no_tests_found):
(RunTest.test_no_tests_found_2):
(RunTest.test_repeat_each_iterations_num_tests):
(RunTest.test_run_singly_actually_runs_tests):
(RunTest.test_test_list):
(RunTest.test_missing_and_unexpected_results):
(RunTest.test_pixel_test_directories):
(RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
(RunTest.test_crash_with_stderr):
(RunTest.test_no_image_failure_with_image_diff):
(RunTest.test_crash_log):
(RunTest.test_exit_after_n_failures_upload):
(RunTest.test_results_directory_absolute):
(RunTest.test_results_directory_relative):
(RunTest.test_retrying_and_flaky_tests):
(RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
(RunTest.test_retrying_uses_retries_directory):
(RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
(RunTest.test_output_diffs):
(EndToEndTest.test_reftest_with_two_notrefs):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):
- Scripts/webkitpy/layout_tests/views/buildbot_results.py:
(BuildBotPrinter.print_results):
(BuildBotPrinter.print_unexpected_results):
(BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
when we forced pixel tests in retry (i.e. pixel test was initially disabled).
- 2:01 PM Changeset in webkit [146816] by
-
- 6 edits in trunk
Enable CSS_REGIONS and CSS_EXCLUSIONS and related tests.
https://bugs.webkit.org/show_bug.cgi?id=87519
Reviewed by Timothy Horton.
- win/tools/vsprops/FeatureDefines.vsprops:
- platform/win/TestExpectations:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
- 1:53 PM Changeset in webkit [146815] by
-
- 2 edits in trunk/Source/WebCore
Remove unused code from Frame class destructor
https://bugs.webkit.org/show_bug.cgi?id=113181
Reviewed by Alexey Proskuryakov.
No new tests. No new functionality.
- page/Frame.cpp:
(WebCore::Frame::~Frame):
Removed the code which could never have been executed
as m_view had been set to '0'.
- 1:41 PM Changeset in webkit [146814] by
-
- 21 edits in trunk/LayoutTests
Don't use video to trigger compositing for layout tests
https://bugs.webkit.org/show_bug.cgi?id=113228
Reviewed by Adrienne Walker.
These tests used <video> to trigger compositing because a 3d identity
transform would have affected the overlap map differently. This is
no longer the case, so use translateZ(0) to trigger compositing instead,
which makes these tests more reliable and faster.
- compositing/geometry/limit-layer-bounds-clipping-ancestor.html:
- compositing/geometry/limit-layer-bounds-fixed-positioned.html:
- compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt:
- compositing/geometry/limit-layer-bounds-opacity-transition.html:
- compositing/geometry/limit-layer-bounds-overflow-repaint.html:
- compositing/geometry/limit-layer-bounds-overflow-root.html:
- compositing/geometry/limit-layer-bounds-positioned-transition.html:
- compositing/geometry/limit-layer-bounds-positioned.html:
- compositing/geometry/limit-layer-bounds-transformed-overflow.html:
- compositing/geometry/limit-layer-bounds-transformed.html:
- compositing/layer-creation/scroll-partial-update-expected.txt:
- compositing/layer-creation/scroll-partial-update.html:
- platform/chromium-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt:
- platform/chromium-win/compositing/layer-creation/scroll-partial-update-expected.txt:
- platform/chromium/TestExpectations:
- platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt:
- 1:38 PM Changeset in webkit [146813] by
-
- 1 edit2 copies in tags/Safari-537.35.1/LayoutTests
Merged r146685. <rdar://problem/13475726>
- 1:36 PM Changeset in webkit [146812] by
-
- 8 edits in tags/Safari-537.35.1/Source
Merged r146679. <rdar://problem/13475726>
- 1:33 PM Changeset in webkit [146811] by
-
- 2 edits in tags/Safari-537.35.1/Source/WebCore
Merged r146563. <rdar://problem/13435161>
- 1:30 PM Changeset in webkit [146810] by
-
- 5 edits in tags/Safari-537.35.1/Source/WebKit2
Merged r146551. <rdar://problem/13355759>
- 1:28 PM Changeset in webkit [146809] by
-
- 2 edits in tags/Safari-537.35.1/Source/WebKit2
Merged r146542. <rdar://problem/13355808>
- 1:26 PM Changeset in webkit [146808] by
-
- 2 edits in trunk/LayoutTests
[chromium] Sheriffing.
https://bugs.webkit.org/show_bug.cgi?id=112927
https://bugs.webkit.org/show_bug.cgi?id=113067
https://bugs.webkit.org/show_bug.cgi?id=113129
Unreviewed, test expectation updates.
Removed crash expectations for fixed bug; added fail expectations for
results the bot won't give us; marked a test as slow.
- platform/chromium/TestExpectations:
- 1:26 PM Changeset in webkit [146807] by
-
- 4 edits in tags/Safari-537.35.1/Source/WebKit2
Merged r146539. <rdar://problem/13355808>
- 1:23 PM Changeset in webkit [146806] by
-
- 2 edits in tags/Safari-537.35.1/Source/WebCore
Merged r146373. <rdar://problem/13202277>
- 1:16 PM Changeset in webkit [146805] by
-
- 3 edits2 adds in trunk
Incorrect parsing due to hash collision
https://bugs.webkit.org/show_bug.cgi?id=113235
Reviewed by Adam Barth.
Source/WebCore:
Test: fast/parser/tag-hash-collision.html
- html/parser/HTMLIdentifier.cpp:
(WebCore::HTMLIdentifier::findIndex):
LayoutTests:
- fast/parser/tag-hash-collision-expected.txt: Added.
- fast/parser/tag-hash-collision.html: Added.
- 1:15 PM Changeset in webkit [146804] by
-
- 4 edits in branches/safari-536.30-branch/LayoutTests
<rdar://problem/13465764> Many merged tests are failing
Update three more tests that use "testRunner" instead of "layoutTestController".
- fast/block/float/intruding-float-not-removed-writing-mode.xhtml:
- mhtml/shared_buffer_bug.mht:
- svg/custom/use-invalidate-click-crash.xhtml:
- 1:14 PM Changeset in webkit [146803] by
-
- 2 edits in trunk/Source/WebCore
Compile without SVG will fail
https://bugs.webkit.org/show_bug.cgi?id=113234
Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-03-25
Reviewed by Timothy Hatcher.
Only make the cast to SVGStyleElement if we have SVG support built.
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
- 1:11 PM Changeset in webkit [146802] by
-
- 2 edits in trunk/Source/WebCore
Enable STORE_FONT_CUSTOM_PLATFORM_DATA for all platforms
https://bugs.webkit.org/show_bug.cgi?id=108438
Reviewed by Andreas Kling.
Remove the conditional code so it is turned on for all platforms.
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::~CachedFont):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::platformDataFromCustomData):
(WebCore::CachedFont::allClientsRemoved):
(WebCore::CachedFont::reportMemoryUsage):
- 1:10 PM Changeset in webkit [146801] by
-
- 4 edits in trunk
REGRESSION(r146380): media/track/track-user-preferences.html
https://bugs.webkit.org/show_bug.cgi?id=113083
Reviewed by Jer Noble.
Source/WebCore:
Ignore track change notifications triggered by automatic track selection so the
configuration is not changed.
No new tests, this fixes an existing test.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::configureTextTrackGroup): Clear m_processingPreferenceChange after all
track configuration is finished.
(WebCore::HTMLMediaElement::configureTextTrackDisplay): Do nothing if m_processingPreferenceChange
is true.
LayoutTests:
- platform/mac/TestExpectations: Remove test from expectations.
- 1:06 PM Changeset in webkit [146800] by
-
- 2 edits in trunk/Source/WebCore
[GTK] [gyp] Build the final piece of WebCore
https://bugs.webkit.org/show_bug.cgi?id=113216
Reviewed by Nico Weber.
- WebCore.gyp/WebCoreGTK.gyp: Add the rest of the WebCore source files to the WebCore build target.
- 1:00 PM WebKitGTK/2.0.x edited by
- (diff)
- 12:57 PM Changeset in webkit [146799] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[WK2][GTK] MiniBrowser won't play video in <embed> tag
https://bugs.webkit.org/show_bug.cgi?id=113107
Reviewed by Martin Robinson.
The wrong clip region is used for windowed plugins, because it's
translated to window frame coords again.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformGeometryDidChange): Do not move
the current clip region.
- 12:45 PM Changeset in webkit [146798] by
-
- 2 edits in trunk/Source/WebCore
[GTK] [gyp] Adding support for building WebCore rendering
https://bugs.webkit.org/show_bug.cgi?id=113213
Reviewed by Gustavo Noronha Silva.
- WebCore.gyp/WebCoreGTK.gyp: Build the rendering directory into a shared library.
- 12:37 PM Changeset in webkit [146797] by
-
- 12 edits in trunk/Tools
Dashboard refactor: Move cross dashboard history related code into history.js.
https://bugs.webkit.org/show_bug.cgi?id=113104
Reviewed by Ojan Vafai.
All functions relating to cross dashboard behavior move from being
globals to methods on the history.History object. Names stay the same,
except many are made private, ones that should have been constants now
are, and the long standing TODO to change "currentState" to
dashboardSpecificState is done.
We now create a global history object in dashboard_base, as an
intermediate measure. Once the dashboard specific code is
added to history, each DB will need to create its own, and this
global will be eliminated.
- TestResultServer/static-dashboards/aggregate_results.js:
(handleValidHashParameter):
(htmlForBuilder):
(rawValuesHTML):
- TestResultServer/static-dashboards/dashboard_base.js:
(parseDashboardSpecificParameters):
(defaultValue):
(currentBuilderGroupCategory):
(currentBuilderGroupName):
(handleLocationChange):
(expectationsMap):
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(generatePage):
(.switch.return):
(platformAndBuildType):
(individualTests):
(substringList):
(processMissingAndExtraExpectations):
(pathToFailureLog):
(showPopupForBuild):
(htmlForTestsWithExpectationsButNoFailures):
(shouldHideTest):
(isCrossBuilderView):
(tableHeaders):
(htmlForSingleTestRow):
(htmlForTableColumnHeader):
(generatePageForExpectationsUpdate):
(handleUpdate):
(nextUpdate):
(setUpdateIndex):
(htmlForIndividualTestOnAllBuildersWithResultsLinks):
(.appendExpectationsItem):
(loadExpectations):
(.dummyNode.onload):
(loadExpectationsLayoutTests):
(appendExpectations):
(htmlForNavBar):
(checkBoxToToggleState):
(linkHTMLToToggleState):
(generatePageForBuilder):
(isInvalidKeyForCrossBuilderView):
(handleQueryParameterChange):
(showLegend):
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(resetGlobals):
(test):
- TestResultServer/static-dashboards/history.js:
(.):
- TestResultServer/static-dashboards/history_unittests.js:
- TestResultServer/static-dashboards/loader.js:
(.):
- TestResultServer/static-dashboards/loader_unittests.js:
- TestResultServer/static-dashboards/timeline_explorer.js:
(generatePage):
(initCurrentBuilderTestResults):
(selectBuild):
(showResultsDelta):
- TestResultServer/static-dashboards/treemap.js:
(generatePage):
(.switch.return):
(handleFocus):
- TestResultServer/static-dashboards/ui.js:
- 12:16 PM Changeset in webkit [146796] by
-
- 3 edits in trunk/Source/WebCore
Remove TextIterator argumentless constructor
https://bugs.webkit.org/show_bug.cgi?id=113226
Reviewed by Ryosuke Niwa.
The TextIterator argumentless constructors are never used and wouldn't be useful
since you can't specify a range.
No new tests, removing dead code. There should be no behavior change.
- editing/TextIterator.cpp: Remove constructors.
- editing/TextIterator.h:
(TextIterator):
(SimplifiedBackwardsTextIterator):
(CharacterIterator):
(BackwardsCharacterIterator):
(WordAwareIterator):
- 12:05 PM Changeset in webkit [146795] by
-
- 3 edits3 adds in trunk
Enabled canvas.getContext("webgl") on Desktop Chrome
https://bugs.webkit.org/show_bug.cgi?id=113079
Patch by Brandon Jones <bajones@chromium.org> on 2013-03-25
Reviewed by Dean Jackson.
Test: fast/canvas/webgl/webgl-unprefixed-context-id.html
- bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextMethodCustom):
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
- 11:51 AM Changeset in webkit [146794] by
-
- 3 edits in trunk/LayoutTests
Windows rebaseline after r146779.
- platform/win/css3/filters/effect-reference-expected.txt:
- platform/win/css3/filters/effect-reference-hw-expected.txt:
- 11:43 AM Changeset in webkit [146793] by
-
- 4 edits in trunk
Unreviewed. Remove some suspicious looking code in an attempt to fix EWS bots.
Enable WinEWS test again.
- bindings/scripts/preprocessor.pm:
(applyPreprocessor):
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 11:40 AM Changeset in webkit [146792] by
-
- 2 edits in branches/safari-536.30-branch/LayoutTests
Merge r136586.
2012-12-04 Florin Malita <fmalita@chromium.org>
Unreviewed gardening - add missing js-test-pre.js include to avoid use-href-update-crash.svg
failures on platforms that do not define gc().
- svg/custom/use-href-update-crash.svg:
- 11:36 AM Changeset in webkit [146791] by
-
- 4 edits in tags/Safari-537.35.1/Source
Versioning.
- 11:31 AM Changeset in webkit [146790] by
-
- 1 copy in tags/Safari-537.35.1
New Tag.
- 11:19 AM Changeset in webkit [146789] by
-
- 2 edits in trunk/Source/WebCore
[GTK] [gyp] Add support for building the platform directory
https://bugs.webkit.org/show_bug.cgi?id=113212
Reviewed by Nico Weber.
- WebCore.gyp/WebCoreGTK.gyp: Add support for building the platform directory including
two libraries, one for platform and one for geometry files. This follows the approach
of Chromium.
- 11:13 AM Changeset in webkit [146788] by
-
- 6 edits in trunk/LayoutTests
Mac rebaselines after r146779. Also add failing expectations for 4 transition tests per bug 113223.
- platform/mac/TestExpectations:
- platform/mac/css3/filters/effect-reference-expected.png:
- platform/mac/css3/filters/effect-reference-expected.txt:
- platform/mac/css3/filters/effect-reference-hw-expected.png:
- platform/mac/css3/filters/effect-reference-hw-expected.txt:
- 10:57 AM Changeset in webkit [146787] by
-
- 4 edits in trunk
Swap both the error and change event queue before processing fullscreen events
https://bugs.webkit.org/show_bug.cgi?id=113194
Reviewed by Jer Noble.
Source/WebCore:
While processing the change events, not only new change events but
also new error events might get generated. However, for the timer, we
should only process preexisting events.
This is covered by fullscreen/full-screen-restrictions.html which times
out depending on the delay between requesting fullscreen and granting
fullscreen.
- dom/Document.cpp:
(WebCore::Document::fullScreenChangeDelayTimerFired):
LayoutTests:
- platform/chromium/TestExpectations:
- 9:51 AM Changeset in webkit [146786] by
-
- 215 edits3 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebaselining. Making pixel test bot happier after r146206.
- platform/qt/fast/replaced/max-width-percent-expected.png:
- platform/qt/fast/replaced/maxheight-percent-expected.png:
- platform/qt/fast/replaced/maxheight-pxs-expected.png:
- platform/qt/fast/replaced/maxwidth-percent-expected.png:
- platform/qt/fast/replaced/maxwidth-pxs-expected.png:
- platform/qt/fast/replaced/minheight-percent-expected.png:
- platform/qt/fast/replaced/minheight-pxs-expected.png:
- platform/qt/fast/replaced/minwidth-percent-expected.png:
- platform/qt/fast/replaced/minwidth-pxs-expected.png:
- platform/qt/fast/replaced/object-align-hspace-vspace-expected.png:
- platform/qt/fast/replaced/percent-height-in-anonymous-block-in-table-expected.png:
- platform/qt/fast/replaced/percent-height-in-anonymous-block-widget-expected.png:
- platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
- platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png:
- platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
- platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png:
- platform/qt/fast/replaced/width100percent-button-expected.png:
- platform/qt/fast/ruby/ruby-inline-table-expected.png:
- platform/qt/fast/runin/001-expected.png:
- platform/qt/fast/runin/generated-expected.png:
- platform/qt/fast/runin/runin-generated-before-content-expected.png:
- platform/qt/fast/selectors/016-expected.png:
- platform/qt/fast/selectors/017-expected.png:
- platform/qt/fast/selectors/061-expected.png:
- platform/qt/fast/selectors/062-expected.png:
- platform/qt/fast/selectors/064-expected.png:
- platform/qt/fast/table/003-expected.png:
- platform/qt/fast/table/023-expected.png:
- platform/qt/fast/table/027-vertical-expected.png:
- platform/qt/fast/table/038-vertical-expected.png:
- platform/qt/fast/table/040-expected.png:
- platform/qt/fast/table/040-vertical-expected.png:
- platform/qt/fast/table/100-percent-cell-width-expected.png:
- platform/qt/fast/table/add-before-anonymous-child-expected.png:
- platform/qt/fast/table/auto-100-percent-width-expected.png:
- platform/qt/fast/table/border-collapsing/002-vertical-expected.png:
- platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-expected.png:
- platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png:
- platform/qt/fast/table/border-collapsing/equal-precedence-resolution-expected.png:
- platform/qt/fast/table/cell-absolute-child-expected.png:
- platform/qt/fast/table/click-near-anonymous-table-expected.png:
- platform/qt/fast/table/empty-cells-expected.png:
- platform/qt/fast/table/empty-table-percent-height-expected.png:
- platform/qt/fast/table/fixed-granular-cols-expected.png:
- platform/qt/fast/table/fixed-with-auto-with-colspan-expected.png:
- platform/qt/fast/table/generated-caption-expected.png:
- platform/qt/fast/table/insert-before-anonymous-ancestors-expected.png:
- platform/qt/fast/table/mozilla-bug10296-vertical-align-1-expected.png:
- platform/qt/fast/table/mozilla-bug10296-vertical-align-2-expected.png:
- platform/qt/fast/table/row-height-recalc-expected.png:
- platform/qt/fast/table/rtl-cell-display-none-assert-expected.png:
- platform/qt/fast/table/stale-grid-crash-expected.png:
- platform/qt/fast/table/table-and-parts-outline-expected.png:
- platform/qt/fast/table/table-display-types-vertical-expected.png:
- platform/qt/fast/table/text-field-baseline-expected.png:
- platform/qt/fast/table/unused-percent-heights-expected.png:
- platform/qt/fast/text/backslash-to-yen-sign-expected.png:
- platform/qt/fast/text/basic/001-expected.png:
- platform/qt/fast/text/basic/002-expected.png:
- platform/qt/fast/text/basic/004-expected.png:
- platform/qt/fast/text/basic/008-expected.png:
- platform/qt/fast/text/basic/009-expected.png:
- platform/qt/fast/text/basic/011-expected.png:
- platform/qt/fast/text/basic/012-expected.png:
- platform/qt/fast/text/basic/generic-family-changes-expected.png:
- platform/qt/fast/text/basic/generic-family-reset-expected.png:
- platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.png:
- platform/qt/fast/text/capitalize-empty-generated-string-expected.png:
- platform/qt/fast/text/complex-text-opacity-expected.png:
- platform/qt/fast/text/fake-italic-expected.png:
- platform/qt/fast/text/fallback-traits-fixup-expected.png:
- platform/qt/fast/text/firstline/001-expected.png:
- platform/qt/fast/text/font-initial-expected.png:
- platform/qt/fast/text/hyphenate-limit-before-after-expected.png:
- platform/qt/fast/text/international/arabic-justify-expected.png:
- platform/qt/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
- platform/qt/fast/text/international/hindi-whitespace-expected.png:
- platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
- platform/qt/fast/text/justified-selection-at-edge-expected.png:
- platform/qt/fast/text/justified-selection-expected.png:
- platform/qt/fast/text/line-breaks-after-white-space-expected.png:
- platform/qt/fast/text/shadow-no-blur-expected.png:
- platform/qt/fast/text/shadow-translucent-fill-expected.png:
- platform/qt/fast/text/softHyphen-expected.png:
- platform/qt/fast/text/unicode-variation-selector-expected.png:
- platform/qt/fast/text/wbr-in-pre-crash-expected.png:
- platform/qt/fast/text/wbr-styled-expected.png:
- platform/qt/fast/text/whitespace/002-expected.png:
- platform/qt/fast/text/whitespace/020-expected.png:
- platform/qt/fast/text/whitespace/021-expected.png:
- platform/qt/fast/text/whitespace/022-expected.png:
- platform/qt/fast/text/whitespace/025-expected.png:
- platform/qt/fast/text/whitespace/027-expected.png:
- platform/qt/fast/text/whitespace/030-expected.png:
- platform/qt/fast/text/whitespace/nbsp-mode-and-linewraps-expected.png:
- platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
- platform/qt/fast/text/whitespace/pre-break-word-expected.png:
- platform/qt/fast/text/whitespace/pre-wrap-last-char-expected.png:
- platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.png:
- platform/qt/fast/text/word-break-expected.png:
- platform/qt/fast/text/zero-font-size-expected.png:
- platform/qt/fast/transforms/bounding-rect-zoom-expected.png:
- platform/qt/fast/transforms/diamond-expected.png:
- platform/qt/fast/transforms/matrix-01-expected.png:
- platform/qt/fast/transforms/matrix-02-expected.png:
- platform/qt/fast/transforms/overflow-with-transform-expected.png:
- platform/qt/fast/transforms/skew-with-unitless-zero-expected.png:
- platform/qt/fast/transforms/transform-on-inline-expected.png:
- platform/qt/fast/transforms/transform-positioned-ancestor-expected.png:
- platform/qt/fast/transforms/transformed-document-element-expected.png:
- platform/qt/fast/transforms/transforms-with-opacity-expected.png:
- platform/qt/fast/writing-mode/block-level-images-expected.png:
- platform/qt/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
- platform/qt/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
- platform/qt/fast/writing-mode/box-shadow-vertical-lr-expected.png:
- platform/qt/fast/writing-mode/box-shadow-vertical-rl-expected.png:
- platform/qt/fast/writing-mode/english-bt-text-expected.png:
- platform/qt/fast/writing-mode/english-rl-text-expected.png:
- platform/qt/fast/writing-mode/horizontal-bt-replaced-selection-expected.png:
- platform/qt/fast/writing-mode/vertical-lr-replaced-selection-expected.png:
- platform/qt/fast/writing-mode/vertical-rl-replaced-selection-expected.png:
- platform/qt/fast/xsl/document-function-expected.png:
- platform/qt/fonts/cursive-expected.png:
- platform/qt/fonts/default-expected.png:
- platform/qt/fonts/fantasy-expected.png:
- platform/qt/fonts/monospace-expected.png:
- platform/qt/fonts/sans-serif-expected.png:
- platform/qt/fonts/serif-expected.png:
- platform/qt/http/tests/local/file-url-sent-as-referer-expected.png:
- platform/qt/http/tests/misc/frame-access-during-load-expected.png:
- platform/qt/http/tests/misc/iframe404-expected.png:
- platform/qt/http/tests/navigation/postredirect-basic-expected.png:
- platform/qt/http/tests/navigation/postredirect-goback1-expected.png:
- platform/qt/http/tests/uri/css-href-expected.png:
- platform/qt/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png:
- platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png:
- platform/qt/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png:
- platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png:
- platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png:
- platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png:
- platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png:
- platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png:
- platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png:
- platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
- platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
- platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
- platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png:
- platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png:
- platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png:
- platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
- platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
- platform/qt/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png:
- platform/qt/ietestcenter/css3/text/textshadow-003-expected.png:
- platform/qt/ietestcenter/css3/text/textshadow-005-expected.png:
- platform/qt/ietestcenter/css3/text/textshadow-007-expected.png:
- platform/qt/ietestcenter/css3/text/textshadow-008-expected.png:
- platform/qt/ietestcenter/css3/text/textshadow-009-expected.png:
- platform/qt/ietestcenter/css3/text/textshadow-010-expected.png:
- platform/qt/platform/qt/fast/forms/button-line-break-expected.png:
- platform/qt/printing/return-from-printing-mode-expected.png:
- platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
- platform/qt/scrollbars/listbox-scrollbar-combinations-expected.png:
- platform/qt/scrollbars/overflow-scrollbar-combinations-expected.png:
- platform/qt/scrollbars/scrollbars-on-positioned-content-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-02-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-13-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-20-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-21-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-25-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png:
- platform/qt/svg/W3C-SVG-1.1/animate-elem-27-t-expected.png:
- 9:49 AM Changeset in webkit [146785] by
-
- 17 edits in trunk/Source/WebCore
[V8] Generate specialized callbacks for the main world
https://bugs.webkit.org/show_bug.cgi?id=112430
Patch by Marja Hölttä <marja@chromium.org> on 2013-03-25
Reviewed by Kentaro Hara.
The new specialized bindings will be faster, because they don't need to
do the "main world, isolated world or a worker" check, but can right
away assume that we're in the main world.
This patch generates main world bindings for getters and setters for a
small amount of frequently used functions / functions used by Dromaeo.
Added tests to TestObj.idl and updated bindings tests.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateOverloadedFunction):
(GenerateFunctionCallback):
(GenerateFunction):
(GenerateParametersCheck):
(GenerateSingleConstructorCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):
(GenerateFunctionCallString):
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::perWorldAttributeAttrGetter):
(WebCore::TestObjV8Internal::perWorldAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::perWorldAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::perWorldAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetter):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::perWorldMethodMethod):
(WebCore::TestObjV8Internal::perWorldMethodMethodForMainWorld):
(WebCore::TestObjV8Internal::perWorldMethodMethodCallback):
(WebCore::TestObjV8Internal::perWorldMethodMethodCallbackForMainWorld):
(WebCore::TestObjV8Internal::overloadedPerWorldMethod1Method):
(WebCore::TestObjV8Internal::overloadedPerWorldMethod1MethodForMainWorld):
(WebCore::TestObjV8Internal::overloadedPerWorldMethod2Method):
(WebCore::TestObjV8Internal::overloadedPerWorldMethod2MethodForMainWorld):
(WebCore::TestObjV8Internal::overloadedPerWorldMethodMethod):
(WebCore::TestObjV8Internal::overloadedPerWorldMethodMethodForMainWorld):
(WebCore::TestObjV8Internal::overloadedPerWorldMethodMethodCallback):
(WebCore::TestObjV8Internal::overloadedPerWorldMethodMethodCallbackForMainWorld):
(WebCore):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore):
- bindings/v8/V8DOMConfiguration.cpp:
(WebCore::V8DOMConfiguration::batchConfigureCallbacks):
(WebCore::V8DOMConfiguration::configureTemplate):
- bindings/v8/V8DOMConfiguration.h:
(BatchedMethod):
(V8DOMConfiguration):
- dom/Document.idl:
- dom/Element.idl:
- dom/Node.idl:
- page/DOMWindow.idl:
- 9:47 AM Changeset in webkit [146784] by
-
- 3 edits1 add in trunk
Don't allow drags to start after a mouse press that creates a context menu
https://bugs.webkit.org/show_bug.cgi?id=112079
Reviewed by Tony Chang.
.:
- ManualTests/context-menu-during-drag-selection.html: Added.
Source/WebCore:
This appears to be the intent of the original code anyway (the comments in the corresponding
context menu handlers indicate that they set m_mousePressed to false in order to suppress
drags from starting). Since exact platform behavior differs quite a bit in this area, this
will also make the behavior more consistent across different WebKit implementations.
Manually testable using context-menu-during-drag-selection.html.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDraggedEvent):
- 9:36 AM Changeset in webkit [146783] by
-
- 2 edits1 add in trunk/LayoutTests
[Chromium] Rebaseline svg/custom/marker-orient-auto
Unreviewed rebaseline of test expectations.
- platform/chromium-linux-x86/svg/custom/marker-orient-auto-expected.png: Added.
- platform/chromium/TestExpectations:
- 9:29 AM Changeset in webkit [146782] by
-
- 6 edits in trunk
Web Inspector: [Regression] Provisional breakpoints are not shown on reload.
https://bugs.webkit.org/show_bug.cgi?id=113210
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._restoreBreakpoints):
(WebInspector.BreakpointManager.prototype._projectWillReset.get for):
(WebInspector.BreakpointManager.prototype._projectWillReset):
(WebInspector.BreakpointManager.prototype._breakpointResolved):
- inspector/front-end/utilities.js:
LayoutTests:
- inspector/debugger/breakpoint-manager-expected.txt:
- inspector/debugger/breakpoint-manager.html:
- 9:28 AM Changeset in webkit [146781] by
-
- 8 edits in trunk
Web Inspector: Remove console warnings for *_ prefixed CSS styles
https://bugs.webkit.org/show_bug.cgi?id=113175
Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-25
Reviewed by Pavel Feldman.
Source/WebCore:
Added separate error message for syntax CSS error in declaration list when no property detected.
Added filter for messages starting with '*'.
- css/CSSGrammar.y.in:
LayoutTests:
- inspector/console/console-css-warnings-expected.txt:
- inspector/console/console-css-warnings.html:
- 9:16 AM Changeset in webkit [146780] by
-
- 2 edits in trunk/LayoutTests
Triage more test failures on content_shell
Unreviewed gardening.
- platform/chromium/ContentShellTestExpectations:
- 9:10 AM Changeset in webkit [146779] by
-
- 9 edits1 add in trunk
Integration of the Skia displacement mapping into WebKit
https://bugs.webkit.org/show_bug.cgi?id=112927
Patch by Alexis Hetu <sugoi@chromium.org> on 2013-03-25
Reviewed by Stephen White.
Added displacement mapping to effect-reference.html and
effect-reference-hw.html
- WebCore.gypi:
- platform/graphics/filters/FEDisplacementMap.h:
(FEDisplacementMap):
Adding Skia specific declarations
- platform/graphics/filters/skia/FEDisplacementMapSkia.cpp: Added.
(WebCore):
(WebCore::toSkiaMode):
Provides conversion between the WebKit displacement mapping mode and
the Skia displacement mapping mode
(WebCore::FEDisplacementMap::platformApplySkia):
Displacement through the Skia API. (Accelerated only for now)
(WebCore::FEDisplacementMap::createImageFilter):
Displacement image filter creation through the Skia API.
- 9:05 AM Changeset in webkit [146778] by
-
- 3 edits2 deletes in trunk/Tools
[HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
https://bugs.webkit.org/show_bug.cgi?id=112166
HarfBuzz 0.9.14 merged my patch for icu detection without
pkg-config files, as needed by for example Ubuntu 12.04.
This obsoletes our local workaround. Removed it for GTK and EFL.
Reviewed by Martin Robinson.
- efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
- efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
- gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
- gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
- 9:01 AM Changeset in webkit [146777] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Graduate some new Inspector APIs to public
https://bugs.webkit.org/show_bug.cgi?id=113176
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-25
Reviewed by Pavel Feldman.
Summary of changes:
DOM.highlightNode.nodeId: required parameter is now optional
Input: domain has been added
Runtime.enable: command has been added
Runtime.executionContextCreated: event has been added
Page.clearGeolocationOverride: command has been added
Page.setGeolocationOverride: command has been added
Page.captureScreenshot: command has been added
Debugger.setBreakpointByUrl.locations: optional response parameter is now required
- inspector/Inspector.json:
- 8:56 AM Changeset in webkit [146776] by
-
- 341 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Updated expected png results.
- platform/qt/css3/selectors3/xhtml/css3-modsel-146a-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-146b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-147a-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-147b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-14c-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-14e-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-15-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-150-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-153-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-159-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-15c-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-16-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-161-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-168-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-168a-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-169-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-169a-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-172a-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-172b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-173a-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-173b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-18-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-181-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-183-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-18b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-19-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-20-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-21-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-22-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-28-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-28b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-29-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-29b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-3-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-30-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-31-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-32-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-33-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-34-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-35-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-36-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-37-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-38-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-39-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-39a-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-39b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-39c-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-3a-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-41-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-41a-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-42-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-42a-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-43-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-43b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-44-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-44b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-45-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-45b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-46-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-46b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-47-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-48-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-49-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-51-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-52-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-53-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-54-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-55-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-56-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-57-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-57b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-59-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-60-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-61-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-62-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-63-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-64-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-65-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-66-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-67-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-7-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-72-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-72b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-73-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-73b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-74-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-74b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-75-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-75b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-76-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-76b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-77-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-77b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-78-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-78b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-79-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-8-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-80-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-81-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-81b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-82-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-82b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-87-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-87b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-9-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-90-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-90b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-93-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-94-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-94b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-95-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-96-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-96b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-97-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-97b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-98-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-98b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-99-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-99b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-d4-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-1-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-10-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-100-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-100b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-101-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-101b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-102-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-102b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-103-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-103b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-104-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-104b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-105-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-105b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-106-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-106b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-107-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-107b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-108-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-108b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-109-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-109b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-11-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-110-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-110b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-111-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-111b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-112-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-112b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-113-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-113b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-114-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-114b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-115-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-115b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-116-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-116b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-117-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-117b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-118-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-119-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-120-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-121-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-122-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-123-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-124-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-124b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-125-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-125b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-126-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-126b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-127-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-127b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-128-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-128b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-129-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-129b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-13-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-130-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-130b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-131-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-131b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-132-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-132b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-133-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-133b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-134-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-134b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-135-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-135b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-136-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-136b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-137-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-137b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-138-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-138b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-139-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-139b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-14-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-140-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-140b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-141-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-141b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-142-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-142b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-143-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-143b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-145a-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-145b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-146a-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-146b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-147a-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-147b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-14c-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-14e-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-15-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-150-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-153-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-159-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-15c-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-16-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-161-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-168-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-168a-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-169-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-169a-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-172a-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-172b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-173a-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-173b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-18-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-181-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-183-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-18b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-19-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-19b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-20-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-21-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-22-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-23-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-24-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-28-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-28b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-29-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-29b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-3-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-30-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-31-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-32-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-33-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-34-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-35-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-36-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-37-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-38-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-39-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-39a-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-39b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-39c-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-3a-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-41-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-41a-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-42-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-42a-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-43-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-43b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-44-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-44b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-45-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-45b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-46-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-46b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-47-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-48-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-49-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-51-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-52-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-53-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-54-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-55-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-56-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-57-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-57b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-59-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-60-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-61-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-62-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-63-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-64-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-65-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-66-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-67-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-68-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-69-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-7-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-72-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-72b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-73-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-73b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-74-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-74b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-75-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-75b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-76-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-76b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-77-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-77b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-78-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-78b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-79-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-8-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-80-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-81-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-81b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-82-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-82b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-87-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-87b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-9-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-90-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-90b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-93-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-94-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-94b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-95-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-96-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-96b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-97-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-97b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-98-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-98b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-99-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-99b-expected.png:
- platform/qt/css3/selectors3/xml/css3-modsel-d4-expected.png:
- platform/qt/css3/unicode-bidi-isolate-basic-expected.png:
- 8:34 AM Changeset in webkit [146775] by
-
- 198 edits5 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Updated expected png resutls after r146206.
- platform/qt/css3/compositing/effect-background-blend-mode-expected.png: Added.
- platform/qt/css3/css3-modsel-33-expected.png:
- platform/qt/css3/css3-modsel-35-expected.png:
- platform/qt/css3/css3-modsel-36-expected.png:
- platform/qt/css3/css3-modsel-37-expected.png:
- platform/qt/css3/filters/custom/custom-filter-color-matrix-expected.png: Added.
- platform/qt/css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Added.
- platform/qt/css3/filters/effect-invert-hw-expected.png:
- platform/qt/css3/filters/filter-repaint-child-layers-expected.png: Added.
- platform/qt/css3/filters/nested-filter-expected.png:
- platform/qt/css3/filters/regions-expanding-expected.png:
- platform/qt/css3/flexbox/flexbox-baseline-expected.png:
- platform/qt/css3/images/cross-fade-background-size-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-1-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-10-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-11-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-13-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-14-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-14c-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-14e-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-15-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-150-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-159-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-16-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-161-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-168-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-168a-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-169-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-169a-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-18-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-181-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-183-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-18b-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-19-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-19b-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-20-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-21-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-22-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-23-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-24-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-28-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-28b-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-29-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-29b-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-30-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-31-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-32-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-33-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-34-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-35-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-36-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-37-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-38-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-39-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-39a-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-39b-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-39c-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-3a-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-41-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-41a-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-42-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-42a-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-43-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-43b-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-44-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-44b-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-45-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-45b-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-46-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-46b-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-54-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-55-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-56-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-59-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-60-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-61-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-62-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-63-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-64-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-65-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-66-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-67-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-68-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-69-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-7-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-72-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-72b-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-73-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-73b-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-74-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-74b-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-75-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-75b-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-76-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-76b-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-77-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-77b-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-78-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-78b-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-79-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-8-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-80-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-81-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-81b-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-82-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-82b-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-87-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-87b-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-9-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-90-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-90b-expected.png:
- platform/qt/css3/selectors3/html/css3-modsel-d4-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-1-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-10-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-100-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-100b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-101-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-101b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-102-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-102b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-103-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-103b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-104-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-104b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-105-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-105b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-106-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-106b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-107-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-107b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-108-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-108b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-109-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-109b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-11-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-110-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-110b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-111-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-111b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-112-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-112b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-113-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-113b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-114-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-114b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-115-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-115b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-116-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-116b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-117-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-117b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-118-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-119-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-120-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-121-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-122-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-123-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-124-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-124b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-125-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-125b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-126-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-126b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-127-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-127b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-128-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-128b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-129-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-129b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-13-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-130-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-130b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-131-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-131b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-132-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-132b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-133-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-133b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-134-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-134b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-135-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-135b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-136-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-136b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-137-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-137b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-138-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-138b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-139-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-139b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-14-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-140-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-140b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-141-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-141b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-142-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-142b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-143-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-143b-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-145a-expected.png:
- platform/qt/css3/selectors3/xhtml/css3-modsel-145b-expected.png:
- 8:25 AM Changeset in webkit [146774] by
-
- 2 edits in trunk/Source/WTF
WTF::binarySearchImpl() should compile with -Wshorten-64-to-32
<http://webkit.org/b/113170>
Reviewed by Dan Bernstein.
Fixes the following build failure:
/usr/local/include/wtf/StdLibExtras.h:190:30: error: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32]
int pos = (size - 1) >> 1;
~~~
1 error generated.
- wtf/StdLibExtras.h:
(WTF::binarySearchImpl): Switch type from int to size_t.
- 8:09 AM Changeset in webkit [146773] by
-
- 123 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Updated expected png results r146206.
- platform/qt-5.0-wk2/css2.1/t0905-c414-flt-01-d-g-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/t1004-c5524-width-00-b-g-expected.png: Added.
- platform/qt/css2.1/20110323/absolute-non-replaced-height-001-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-height-002-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-height-008-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-max-height-002-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-max-height-008-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-001-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-002-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-003-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-004-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-005-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-006-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-007-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-008-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-009-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-010-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-011-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-012-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-013-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-014-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-015-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-016-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-017-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-018-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-019-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-020-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-021-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-022-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-023-expected.png:
- platform/qt/css2.1/20110323/absolute-non-replaced-width-024-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-height-001-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-height-008-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-height-009-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-height-010-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-height-016-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-height-017-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-height-022-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-height-023-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-height-024-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-height-029-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-height-030-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-height-031-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-001-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-006-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-008-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-013-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-015-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-020-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-022-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-027-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-029-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-034-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-036-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-041-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-043-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-048-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-050-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-055-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-057-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-062-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-064-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-069-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-071-expected.png:
- platform/qt/css2.1/20110323/absolute-replaced-width-076-expected.png:
- platform/qt/css2.1/20110323/block-non-replaced-height-001-expected.png:
- platform/qt/css2.1/20110323/block-non-replaced-height-002-expected.png:
- platform/qt/css2.1/20110323/block-non-replaced-height-005-expected.png:
- platform/qt/css2.1/20110323/block-non-replaced-height-006-expected.png:
- platform/qt/css2.1/20110323/block-non-replaced-width-005-expected.png:
- platform/qt/css2.1/20110323/block-non-replaced-width-006-expected.png:
- platform/qt/css2.1/20110323/block-non-replaced-width-007-expected.png:
- platform/qt/css2.1/20110323/block-replaced-height-001-expected.png:
- platform/qt/css2.1/20110323/block-replaced-width-001-expected.png:
- platform/qt/css2.1/20110323/block-replaced-width-006-expected.png:
- platform/qt/css2.1/20110323/border-conflict-style-079-expected.png:
- platform/qt/css2.1/20110323/border-conflict-style-088-expected.png:
- platform/qt/css2.1/20110323/border-spacing-applies-to-015-expected.png:
- platform/qt/css2.1/20110323/empty-inline-003-expected.png:
- platform/qt/css2.1/20110323/float-non-replaced-width-007-expected.png:
- platform/qt/css2.1/20110323/float-non-replaced-width-008-expected.png:
- platform/qt/css2.1/20110323/float-non-replaced-width-009-expected.png:
- platform/qt/css2.1/20110323/float-non-replaced-width-010-expected.png:
- platform/qt/css2.1/20110323/float-non-replaced-width-011-expected.png:
- platform/qt/css2.1/20110323/float-non-replaced-width-012-expected.png:
- platform/qt/css2.1/20110323/float-replaced-height-001-expected.png:
- platform/qt/css2.1/20110323/float-replaced-width-006-expected.png:
- platform/qt/css2.1/20110323/float-replaced-width-011-expected.png:
- platform/qt/css2.1/20110323/floating-replaced-height-008-expected.png:
- platform/qt/css2.1/20110323/inline-block-non-replaced-width-002-expected.png:
- platform/qt/css2.1/20110323/inline-block-non-replaced-width-003-expected.png:
- platform/qt/css2.1/20110323/inline-block-non-replaced-width-004-expected.png:
- platform/qt/css2.1/20110323/inline-block-replaced-height-001-expected.png:
- platform/qt/css2.1/20110323/inline-block-replaced-height-008-expected.png:
- platform/qt/css2.1/20110323/inline-block-replaced-width-001-expected.png:
- platform/qt/css2.1/20110323/inline-block-replaced-width-006-expected.png:
- platform/qt/css2.1/20110323/inline-replaced-height-001-expected.png:
- platform/qt/css2.1/20110323/inline-replaced-height-008-expected.png:
- platform/qt/css2.1/20110323/inline-replaced-width-001-expected.png:
- platform/qt/css2.1/20110323/inline-replaced-width-006-expected.png:
- platform/qt/css2.1/20110323/inline-replaced-width-014-expected.png:
- platform/qt/css2.1/20110323/inline-replaced-width-015-expected.png:
- platform/qt/css2.1/20110323/margin-applies-to-010-expected.png:
- platform/qt/css2.1/20110323/replaced-intrinsic-001-expected.png:
- platform/qt/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
- platform/qt/css2.1/20110323/table-caption-002-expected.png:
- platform/qt/css2.1/20110323/table-caption-optional-001-expected.png:
- platform/qt/css2.1/20110323/table-caption-optional-002-expected.png:
- platform/qt/css2.1/20110323/table-height-algorithm-023-expected.png:
- platform/qt/css2.1/20110323/table-height-algorithm-024-expected.png:
- platform/qt/css2.1/20110323/width-non-replaced-inline-001-expected.png:
- platform/qt/css2.1/t051103-c21-activ-ln-00-e-i-expected.png:
- platform/qt/css2.1/t051103-c21-hover-ln-00-e-i-expected.png:
- platform/qt/css2.1/t060403-c21-pseu-cls-00-e-i-expected.png:
- platform/qt/css2.1/t060403-c21-pseu-id-00-e-i-expected.png:
- platform/qt/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
- platform/qt/css2.1/t1202-counters-08-b-expected.png:
- platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
- platform/qt/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
- platform/qt/css2.1/t1508-c527-font-07-b-expected.png:
- platform/qt/css2.1/t170602-bdr-conflct-w-41-d-expected.png:
- platform/qt/css2.1/t170602-bdr-conflct-w-42-d-expected.png:
- platform/qt/css2.1/t170602-bdr-conflct-w-43-d-expected.png:
- platform/qt/css2.1/t170602-bdr-conflct-w-49-d-expected.png:
- 7:50 AM Changeset in webkit [146772] by
-
- 68 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Updated png results after r146206.
- platform/qt/css1/basic/class_as_selector-expected.png:
- platform/qt/css1/basic/comments-expected.png:
- platform/qt/css1/basic/contextual_selectors-expected.png:
- platform/qt/css1/basic/grouping-expected.png:
- platform/qt/css1/basic/id_as_selector-expected.png:
- platform/qt/css1/box_properties/acid_test-expected.png:
- platform/qt/css1/box_properties/border_bottom_inline-expected.png:
- platform/qt/css1/box_properties/border_bottom_width-expected.png:
- platform/qt/css1/box_properties/border_bottom_width_inline-expected.png:
- platform/qt/css1/box_properties/border_color-expected.png:
- platform/qt/css1/box_properties/border_color_inline-expected.png:
- platform/qt/css1/box_properties/border_inline-expected.png:
- platform/qt/css1/box_properties/border_left_inline-expected.png:
- platform/qt/css1/box_properties/border_left_width_inline-expected.png:
- platform/qt/css1/box_properties/border_right-expected.png:
- platform/qt/css1/box_properties/border_right_width_inline-expected.png:
- platform/qt/css1/box_properties/border_style_inline-expected.png:
- platform/qt/css1/box_properties/border_top_inline-expected.png:
- platform/qt/css1/box_properties/border_top_width-expected.png:
- platform/qt/css1/box_properties/border_top_width_inline-expected.png:
- platform/qt/css1/box_properties/border_width-expected.png:
- platform/qt/css1/box_properties/border_width_inline-expected.png:
- platform/qt/css1/box_properties/clear-expected.png:
- platform/qt/css1/box_properties/float-expected.png:
- platform/qt/css1/box_properties/float_elements_in_series-expected.png:
- platform/qt/css1/box_properties/height-expected.png:
- platform/qt/css1/box_properties/margin-expected.png:
- platform/qt/css1/box_properties/margin_bottom-expected.png:
- platform/qt/css1/box_properties/margin_bottom_inline-expected.png:
- platform/qt/css1/box_properties/margin_left_inline-expected.png:
- platform/qt/css1/box_properties/margin_right_inline-expected.png:
- platform/qt/css1/box_properties/margin_top-expected.png:
- platform/qt/css1/box_properties/margin_top_inline-expected.png:
- platform/qt/css1/box_properties/padding-expected.png:
- platform/qt/css1/box_properties/padding_left_inline-expected.png:
- platform/qt/css1/box_properties/padding_right_inline-expected.png:
- platform/qt/css1/box_properties/padding_top-expected.png:
- platform/qt/css1/box_properties/padding_top_inline-expected.png:
- platform/qt/css1/box_properties/width-expected.png:
- platform/qt/css1/classification/list_style-expected.png:
- platform/qt/css1/classification/list_style_image-expected.png:
- platform/qt/css1/classification/list_style_position-expected.png:
- platform/qt/css1/classification/list_style_type-expected.png:
- platform/qt/css1/classification/white_space-expected.png:
- platform/qt/css1/color_and_background/background-expected.png:
- platform/qt/css1/color_and_background/background_attachment-expected.png:
- platform/qt/css1/color_and_background/background_color-expected.png:
- platform/qt/css1/color_and_background/background_image-expected.png:
- platform/qt/css1/color_and_background/color-expected.png:
- platform/qt/css1/font_properties/font_family-expected.png:
- platform/qt/css1/font_properties/font_size-expected.png:
- platform/qt/css1/font_properties/font_style-expected.png:
- platform/qt/css1/font_properties/font_variant-expected.png:
- platform/qt/css1/font_properties/font_weight-expected.png:
- platform/qt/css1/formatting_model/canvas-expected.png:
- platform/qt/css1/formatting_model/floating_elements-expected.png:
- platform/qt/css1/formatting_model/height_of_lines-expected.png:
- platform/qt/css1/formatting_model/horizontal_formatting-expected.png:
- platform/qt/css1/formatting_model/replaced_elements-expected.png:
- platform/qt/css1/text_properties/letter_spacing-expected.png:
- platform/qt/css1/text_properties/line_height-expected.png:
- platform/qt/css1/text_properties/text_align-expected.png:
- platform/qt/css1/text_properties/vertical_align-expected.png:
- platform/qt/css1/text_properties/word_spacing-expected.png:
- platform/qt/css1/units/color_units-expected.png:
- platform/qt/css1/units/length_units-expected.png:
- platform/qt/css1/units/percentage_units-expected.png:
- 7:42 AM Changeset in webkit [146771] by
-
- 4 edits in trunk
Web Inspector: [Timeline] set glue records mode off by default
https://bugs.webkit.org/show_bug.cgi?id=113189
Reviewed by Pavel Feldman.
Source/WebCore:
- inspector/front-end/TimelinePanel.js: /glueRecordsSetting/s/true/false/
LayoutTests:
- inspector/timeline/timeline-receive-response-event.html: enable glue records mode for the test.
- 7:29 AM QtWebKitBuildBots edited by
- Removing Amazon bot after its shutdown. (diff)
- 7:27 AM Changeset in webkit [146770] by
-
- 5 edits in trunk/Source/WebCore
[EFL] Fix build break when media source is enabled
https://bugs.webkit.org/show_bug.cgi?id=113143
Unreviewed. Build error needs to be fixed in order to start to implement
media source functionality.
- CMakeLists.txt:
- platform/efl/MIMETypeRegistryEfl.cpp:
(WebCore):
(WebCore::MIMETypeRegistry::isSupportedMediaSourceMIMEType):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore):
(WebCore::MediaPlayerPrivateGStreamer::load):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
- 7:26 AM Changeset in webkit [146769] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Toggling breakpoint with shortcut should be freezed as well while editing.
https://bugs.webkit.org/show_bug.cgi?id=113188
Reviewed by Pavel Feldman.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.toggleBreakpointOnCurrentLine):
- 7:23 AM Changeset in webkit [146768] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Remove unneeded code from JavaScriptSourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=113182
Reviewed by Pavel Feldman.
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
- 6:56 AM Changeset in webkit [146767] by
-
- 9 edits in trunk/Source
Web Inspector: Fonts refactoring
https://bugs.webkit.org/show_bug.cgi?id=113047
Patch by Alexei Filippov <alph@chromium.org> on 2013-03-25
Reviewed by Pavel Feldman.
Unify fonts usage across inspector.
Make inspector default font depend on platform.
Source/WebCore:
- inspector/front-end/dataGrid.css:
(.data-grid table):
(.data-grid td):
- inspector/front-end/inspector.css:
(.toolbar-label):
(body.show-toolbar-icons .toolbar-label):
(.console-message .bubble):
(li .status .bubble):
(.source-frame-breakpoint-message):
(.soft-context-menu):
- inspector/front-end/inspectorCommon.css:
(body):
- inspector/front-end/networkLogView.css:
(.network-log-grid.data-grid td):
(.network-log-grid.data-grid.small td):
- inspector/front-end/tabbedPane.css:
(.tabbed-pane-header-tab):
(select.tabbed-pane-header-tabs-drop-down-select):
- inspector/front-end/timelinePanel.css:
(.memory-counter-value):
Source/WebKit/chromium:
- src/js/devTools.css:
(body.platform-linux):
(body.platform-mac):
(body.platform-windows):
- 6:54 AM Changeset in webkit [146766] by
-
- 4 edits in trunk/Source/WebKit2
[Qt] Qml WebKit needs preferences to change security knobs
https://bugs.webkit.org/show_bug.cgi?id=111979
Patch by Maxim Ermilov <maxim.ermilov@canonical.com> on 2013-03-25
Reviewed by Jocelyn Turcotte.
- UIProcess/API/qt/qwebpreferences.cpp:
(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::universalAccessFromFileURLsAllowed):
(QWebPreferences::setUniversalAccessFromFileURLsAllowed):
(QWebPreferences::fileAccessFromFileURLsAllowed):
(QWebPreferences::setFileAccessFromFileURLsAllowed):
- UIProcess/API/qt/qwebpreferences_p.h:
- UIProcess/API/qt/qwebpreferences_p_p.h:
- 6:52 AM Changeset in webkit [146765] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Use generate-inspector-protocol-version to list valid public API changes
https://bugs.webkit.org/show_bug.cgi?id=113148
Added --show-changes command line option.
Used existing compare_schemas method to do a reverse compare.
Fixed a number of small problems (missing domain name in the message,
incorrect error messages for command parameters).
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-25
Reviewed by Pavel Feldman.
- inspector/generate-inspector-protocol-version:
(named_list_to_map):
(removed):
(required):
(compare_schemas):
(compare_domains):
(compare_commands):
(compare_events):
(compare_params_list):
(compare_types):
(self_test):
(self_test.create_test_schema_1):
(self_test.create_test_schema_2):
(self_test.is_subset):
(self_test.errors_match):
(main):
- 6:42 AM Changeset in webkit [146764] by
-
- 17 edits9 adds in trunk
Support Quota API in Workers
https://bugs.webkit.org/show_bug.cgi?id=112972
Reviewed by Adam Barth.
Source/WebCore:
Tests: fast/workers/shared-worker-storagequota-query-usage.html
fast/workers/worker-storagequota-query-usage.html
- Modules/quota/WorkerNavigatorStorageQuota.cpp: Added.
- Modules/quota/WorkerNavigatorStorageQuota.h: Added.
- Modules/quota/WorkerNavigatorStorageQuota.idl: Added.
- WebCore.gypi: Add entries for WorkerNavigatorStorageQuota.
- page/WorkerNavigator.h: Add a Navigator supplement that extends the worker navigator.
LayoutTests:
- fast/workers/resources/shared-worker-common.js:
(handleMessage): Allow port to be dynamically discovered from self.
- fast/workers/resources/storagequota-query-usage.js: Added.
(worker.onmessage):
- fast/workers/resources/worker-storagequota-query-usage.js: Added.
(requestUsage.errorCallback):
(requestUsage.usageCallback):
(requestUsage):
- fast/workers/shared-worker-storagequota-query-usage-expected.txt: Added.
- fast/workers/shared-worker-storagequota-query-usage.html: Added.
- fast/workers/worker-storagequota-query-usage-expected.txt: Added.
- fast/workers/worker-storagequota-query-usage.html: Added.
- 6:39 AM Changeset in webkit [146763] by
-
- 15 edits in trunk
CSP 1.1: Rename SecurityPolicyViolationEvent::sourceURL to ::sourceFile.
https://bugs.webkit.org/show_bug.cgi?id=113033
Reviewed by Jochen Eisinger.
Source/WebCore:
Bringing our experimental implementation into line with the spec, which
has landed on the de facto standard name Gecko has been sending out for
years and years.
Spec: https://dvcs.w3.org/hg/content-security-policy/rev/e44f4003e158
Thread: http://lists.w3.org/Archives/Public/public-webappsec/2013Mar/0087.html
- dom/SecurityPolicyViolationEvent.h:
(SecurityPolicyViolationEventInit):
(WebCore::SecurityPolicyViolationEvent::sourceFile):
(WebCore::SecurityPolicyViolationEvent::SecurityPolicyViolationEvent):
(SecurityPolicyViolationEvent):
- dom/SecurityPolicyViolationEvent.idl:
- page/ContentSecurityPolicy.cpp:
(WebCore::gatherSecurityPolicyViolationEventData):
s/sourceURL/sourceFile/
LayoutTests:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image.html:
- 6:10 AM Changeset in webkit [146762] by
-
- 8 edits20 adds in trunk
[CSS Filters] Using negative drop-shadow radius values has slow performance
https://bugs.webkit.org/show_bug.cgi?id=107848
Source/WebCore:
Setting negative blur radius values in drop-shadow() and box-shadow() led to
significant rendering performance loss. The invalid value overflowed and the
embedder became unresponsive for few seconds.
This impacted SVG too (SVGFEDropShadow and SVGFEGaussianBlur).
Reviewed by Dirk Schulze.
Tests: css3/filters/effect-drop-shadow-negative-radius.html
fast/box-shadow/box-shadow-parsing-invalid.html
svg/filters/feDropShadow-negative-deviation-expected.svg
svg/filters/feDropShadow-negative-deviation.svg
svg/filters/feDropShadow-zero-deviation.svg
svg/filters/feGaussianBlur-negative-deviation-expected.svg
svg/filters/feGaussianBlur-negative-deviation.svg
svg/filters/feGaussianBlur-zero-deviation.svg
- css/CSSParser.cpp:
(WebCore::CSSParser::parseShadow): Negative values are skipped during parsing: as per
CSS Background and Borders specs, negative values shall not be allowed.
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::calculateUnscaledKernelSize): Added "non-negative" assertion for
negative deviations.
- svg/SVGFEDropShadowElement.cpp:
(WebCore::SVGFEDropShadowElement::build): If a negative standard deviation is encountered, don't
build the filter and returns earlier, this avoids unnecessary calls: FEGaussianBlur is not being
created with wrong and potentially overflowing values.
- svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::build): Ditto.
LayoutTests:
Added a whole set of new tests for both CSS and SVG to assess the correctness of
blur(), drop-shadow() and box-shadow() blur radius values.
Reviewed by Dirk Schulze.
- css3/filters/effect-drop-shadow-negative-radius-expected.html: Added.
- css3/filters/effect-drop-shadow-negative-radius.html: Added.
- css3/filters/filter-property-parsing-invalid-expected.txt:
- css3/filters/script-tests/filter-property-parsing-invalid.js:
- fast/box-shadow/box-shadow-parsing-invalid-expected.txt: Added.
- fast/box-shadow/box-shadow-parsing-invalid.html: Added.
- fast/box-shadow/script-tests/box-shadow-parsing-invalid.js: Added.
(testInvalidFilterRule):
- platform/chromium/svg/filters/feDropShadow-zero-deviation-expected.png: Added.
- platform/chromium/svg/filters/feDropShadow-zero-deviation-expected.txt: Added.
- platform/chromium/svg/filters/feGaussianBlur-zero-deviation-expected.png: Added.
- platform/chromium/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Added.
- platform/mac/svg/filters/feDropShadow-zero-deviation-expected.png: Added.
- platform/mac/svg/filters/feDropShadow-zero-deviation-expected.txt: Added.
- platform/mac/svg/filters/feGaussianBlur-zero-deviation-expected.png: Added.
- platform/mac/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Added.
- svg/filters/feDropShadow-negative-deviation-expected.svg: Added.
- svg/filters/feDropShadow-negative-deviation.svg: Added.
- svg/filters/feDropShadow-zero-deviation.svg: Added.
- svg/filters/feGaussianBlur-negative-deviation-expected.svg: Added.
- svg/filters/feGaussianBlur-negative-deviation.svg: Added.
- svg/filters/feGaussianBlur-zero-deviation.svg: Added.
- 6:06 AM Changeset in webkit [146761] by
-
- 2 edits in trunk/Source/WebCore
[Qt] REGRESSION(r146630): 8 text related test asserts on debug builds
https://bugs.webkit.org/show_bug.cgi?id=113179
Reviewed by Jocelyn Turcotte.
Test if range.start is within the valid range before testing the value at that point.
- platform/graphics/qt/FontQt.cpp:
(WebCore::Font::initFormatForTextLayout):
- 5:55 AM Changeset in webkit [146760] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Properly handle the rule addition to an XML or SVG document.
https://bugs.webkit.org/show_bug.cgi?id=113185
Reviewed by Pavel Feldman.
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
- 5:38 AM Changeset in webkit [146759] by
-
- 6 edits3 adds in trunk
Web Inspector: support changing local variables in frontend
https://bugs.webkit.org/show_bug.cgi?id=112470
Patch by Peter Rybin <prybin@chromium.org> on 2013-03-25
Reviewed by Yury Semikhatsky.
Source/WebCore:
ScopeRef type is added to RemoteObject and setPropertyValue is patched accordingly.
Test: inspector/debugger/debugger-change-variable.html
- inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.CallFrame.prototype.get id):
- inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate.didGetDetails):
(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate):
- inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromScopePayload):
(WebInspector.RemoteObject.prototype.):
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.setVariableValueCallback):
(WebInspector.RemoteObject.prototype._setDeclarativeVariableValue):
(WebInspector.ScopeRef):
- inspector/front-end/ScopeChainSidebarPane.js:
(WebInspector.ScopeChainSidebarPane.prototype.update):
LayoutTests:
- inspector/debugger/debugger-change-variable-expected.txt: Added.
- inspector/debugger/debugger-change-variable.html: Added.
- platform/chromium/inspector/debugger/debugger-change-variable-expected.txt: Added.
- 5:20 AM Changeset in webkit [146758] by
-
- 5 edits3 copies8 adds in trunk
CSP 1.1: Strip URLs in SecurityPolicyViolationEvents, just as we do for POSTed violation reports.
https://bugs.webkit.org/show_bug.cgi?id=113039
Reviewed by Jochen Eisinger.
Source/WebCore:
I'd originally assumed that we didn't need to be quite so careful when
handing URLs to JavaScript via SecurityPolicyViolationEvents. This was
a mistake. Cross-origin URLs aren't accessible to JavaScript currently
and there's no reason that we should begin exposing them via an event.
This patch extracts the stripping logic from the existing reports into
stripURLForUseInReport(), and uses that new method when populating the
event and report objects.
Relatedly, we were doing the wrong thing with 'file:' URLs, which this
patch made clear. Now they're treated the same as 'data:' et al.
Spec: https://dvcs.w3.org/hg/content-security-policy/rev/45f6ccaba0ef
Tests: http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script.html
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image.html
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script.html
http/tests/security/contentSecurityPolicy/report-blocked-file-uri.html
- page/ContentSecurityPolicy.cpp:
(WebCore::stripURLForUseInReport):
Extract the logic from blockedURI out into a reusable method:
cross-origin URLs are stripped down to the ASCII serialization of
their origin, and non-heirarchical (and 'file:') URLs are stripped
down to the ASCII serialization of their protocol.
(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):
Use ::stripURLForUseInReport for blockedURL and sourceFile
attributes in these two methods.
LayoutTests:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt.
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt.
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt.
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image.html:
- http/tests/security/contentSecurityPolicy/resources/securitypolicyviolation-test.js: Added.
Updating tests to cover cross-origin scenarios: load cross-origin
images, and cross-origin scripts that inject images. The former
should strip the image URL down to the origin, the latter the
script URL.
- http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/report-blocked-file-uri.html: Added.
- platform/chromium/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Added.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Added.
This patch changes the behavior of 'file:' URLs to behave similarly
to 'data:'/'blob:', etc. We weren't previously testing this, now we
are. We need platform-specific results for Chromium and GTK, since
those ports have enabled CSP_NEXT, which adds a field to the report.
- 4:35 AM Changeset in webkit [146757] by
-
- 8 edits in trunk/Source/WebCore
Web Inspector: Fix JSDocs.
https://bugs.webkit.org/show_bug.cgi?id=113025
Reviewed by Pavel Feldman.
Next version of JS compiler finds more inconsistencies
and ambiguous declarations.
Some of them are resolved in this patch.
- inspector/InjectedScriptSource.js: Fix JSDocs.
- inspector/front-end/ConsoleModel.js: Ditto.
- inspector/front-end/CookieParser.js: Ditto.
- inspector/front-end/FileContentView.js: Ditto.
- inspector/front-end/HeapSnapshotView.js: Ditto.
- inspector/front-end/IndexedDBModel.js: Ditto.
- inspector/front-end/ProfilesPanelDescriptor.js: Ditto.
- inspector/front-end/utilities.js: Ditto.
- 4:30 AM Changeset in webkit [146756] by
-
- 196 edits1 copy14 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Making pixel test bot happier after r146206.
- platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.png:
- platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.png:
- platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png:
- platform/qt/fast/frames/flattening/iframe-flattening-fixed-height-expected.png:
- platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png:
- platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.png:
- platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-expected.png:
- platform/qt/fast/frames/flattening/iframe-flattening-offscreen-expected.png:
- platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-expected.png:
- platform/qt/fast/frames/flattening/iframe-flattening-simple-expected.png:
- platform/qt/fast/frames/frame-scrolling-attribute-expected.png:
- platform/qt/fast/frames/frameset-style-recalc-expected.png:
- platform/qt/fast/frames/iframe-scrolling-attribute-expected.png:
- platform/qt/fast/frames/iframe-with-frameborder-expected.png:
- platform/qt/fast/frames/viewsource-attribute-expected.png:
- platform/qt/fast/gradients/background-clipped-expected.png:
- platform/qt/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
- platform/qt/fast/gradients/crash-on-zero-radius-expected.png:
- platform/qt/fast/gradients/radial-centered-expected.png:
- platform/qt/fast/html/details-nested-1-expected.png:
- platform/qt/fast/html/details-nested-2-expected.png:
- platform/qt/fast/html/details-writing-mode-expected.png:
- platform/qt/fast/html/font-weight-bold-for-b-and-strong-expected.png:
- platform/qt/fast/html/link-rel-stylesheet-expected.png:
- platform/qt/fast/html/listing-expected.png:
- platform/qt/fast/html/marquee-scroll-expected.png:
- platform/qt/fast/html/marquee-scrollamount-expected.png:
- platform/qt/fast/images/image-map-anchor-children-expected.png:
- platform/qt/fast/images/imagemap-circle-focus-ring-expected.png:
- platform/qt/fast/images/imagemap-focus-ring-expected.png:
- platform/qt/fast/images/imagemap-focus-ring-outline-color-expected.png:
- platform/qt/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png:
- platform/qt/fast/images/imagemap-focus-ring-zoom-expected.png:
- platform/qt/fast/images/imagemap-polygon-focus-ring-expected.png:
- platform/qt/fast/inline-block/001-expected.png:
- platform/qt/fast/inline-block/002-expected.png:
- platform/qt/fast/inline-block/003-expected.png:
- platform/qt/fast/inline-block/006-expected.png:
- platform/qt/fast/inline-block/14498-positionForCoordinates-expected.png:
- platform/qt/fast/inline-block/contenteditable-baseline-expected.png:
- platform/qt/fast/inline-block/tricky-baseline-expected.png:
- platform/qt/fast/inline/25277-2-expected.png:
- platform/qt/fast/inline/25277-expected.png:
- platform/qt/fast/inline/continuation-outlines-with-layers-2-expected.png:
- platform/qt/fast/inline/drawStyledEmptyInlines-expected.png:
- platform/qt/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
- platform/qt/fast/inline/emptyInlinesWithinLists-expected.png:
- platform/qt/fast/inline/inline-continuation-borders-expected.png:
- platform/qt/fast/inline/inline-focus-ring-expected.png:
- platform/qt/fast/inline/inline-text-quirk-bpm-expected.png:
- platform/qt/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png:
- platform/qt/fast/inline/long-wrapped-line-expected.png:
- platform/qt/fast/inline/nested-top-alignment-expected.png:
- platform/qt/fast/inline/vertical-align-text-bottom-expected.png:
- platform/qt/fast/invalid/003-expected.png:
- platform/qt/fast/invalid/004-expected.png:
- platform/qt/fast/invalid/010-expected.png:
- platform/qt/fast/invalid/014-expected.png:
- platform/qt/fast/invalid/016-expected.png:
- platform/qt/fast/invalid/019-expected.png:
- platform/qt/fast/invalid/021-expected.png:
- platform/qt/fast/invalid/missing-address-end-tag-expected.png:
- platform/qt/fast/invalid/missing-dl-end-tag-expected.png:
- platform/qt/fast/invalid/missing-dt-end-tag-expected.png:
- platform/qt/fast/invalid/missing-font-end-tag-expected.png:
- platform/qt/fast/invalid/nestedh3s-expected.png:
- platform/qt/fast/invalid/td-inside-object-expected.png:
- platform/qt/fast/layers/inline-dirty-z-order-lists-expected.png:
- platform/qt/fast/layers/opacity-transforms-expected.png:
- platform/qt/fast/layers/remove-only-this-layer-update-expected.png:
- platform/qt/fast/line-grid/line-align-left-edges-expected.png:
- platform/qt/fast/line-grid/line-align-right-edges-expected.png:
- platform/qt/fast/line-grid/line-grid-floating-expected.png:
- platform/qt/fast/line-grid/line-grid-into-floats-expected.png:
- platform/qt/fast/line-grid/line-grid-positioned-expected.png:
- platform/qt/fast/lists/001-expected.png:
- platform/qt/fast/lists/001-vertical-expected.png:
- platform/qt/fast/lists/002-expected.png:
- platform/qt/fast/lists/002-vertical-expected.png:
- platform/qt/fast/lists/007-expected.png:
- platform/qt/fast/lists/007-vertical-expected.png:
- platform/qt/fast/lists/008-expected.png:
- platform/qt/fast/lists/008-vertical-expected.png:
- platform/qt/fast/lists/anonymous-items-expected.png:
- platform/qt/fast/lists/big-list-marker-expected.png:
- platform/qt/fast/lists/li-br-expected.png:
- platform/qt/fast/lists/li-style-alpha-huge-value-crash-expected.png:
- platform/qt/fast/lists/list-item-line-height-expected.png:
- platform/qt/fast/lists/list-style-none-crash-expected.png:
- platform/qt/fast/lists/ol-display-types-expected.png:
- platform/qt/fast/lists/ol-start-parsing-expected.png:
- platform/qt/fast/lists/olstart-expected.png:
- platform/qt/fast/multicol/block-axis-horizontal-bt-expected.png:
- platform/qt/fast/multicol/block-axis-horizontal-tb-expected.png:
- platform/qt/fast/multicol/block-axis-vertical-lr-expected.png:
- platform/qt/fast/multicol/block-axis-vertical-rl-expected.png:
- platform/qt/fast/multicol/client-rects-expected.png:
- platform/qt/fast/multicol/column-break-with-balancing-expected.png:
- platform/qt/fast/multicol/column-count-with-rules-expected.png:
- platform/qt/fast/multicol/float-avoidance-expected.png:
- platform/qt/fast/multicol/float-paginate-complex-expected.png:
- platform/qt/fast/multicol/float-paginate-expected.png:
- platform/qt/fast/multicol/layers-in-multicol-expected.png:
- platform/qt/fast/multicol/margin-collapse-expected.png:
- platform/qt/fast/multicol/max-height-columns-block-expected.png:
- platform/qt/fast/multicol/overflow-across-columns-expected.png:
- platform/qt/fast/multicol/overflow-unsplittable-expected.png:
- platform/qt/fast/multicol/paginate-block-replaced-expected.png:
- platform/qt/fast/multicol/positioned-split-expected.png:
- platform/qt/fast/multicol/positive-leading-expected.png:
- platform/qt/fast/multicol/progression-reverse-expected.png:
- platform/qt/fast/multicol/shadow-breaking-expected.png:
- platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
- platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.png:
- platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
- platform/qt/fast/multicol/span/span-as-nested-inline-block-child-expected.png:
- platform/qt/fast/multicol/table-margin-collapse-expected.png:
- platform/qt/fast/multicol/table-vertical-align-expected.png:
- platform/qt/fast/multicol/unsplittable-inline-block-expected.png:
- platform/qt/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
- platform/qt/fast/multicol/vertical-lr/column-count-with-rules-expected.png:
- platform/qt/fast/multicol/vertical-lr/float-multicol-expected.png:
- platform/qt/fast/multicol/vertical-lr/float-paginate-expected.png:
- platform/qt/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png:
- platform/qt/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
- platform/qt/fast/multicol/vertical-rl/column-count-with-rules-expected.png:
- platform/qt/fast/multicol/vertical-rl/float-multicol-expected.png:
- platform/qt/fast/multicol/vertical-rl/float-paginate-expected.png:
- platform/qt/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png:
- platform/qt/fast/overflow/001-expected.png:
- platform/qt/fast/overflow/002-expected.png:
- platform/qt/fast/overflow/003-expected.png:
- platform/qt/fast/overflow/004-expected.png:
- platform/qt/fast/overflow/007-expected.png:
- platform/qt/fast/overflow/008-expected.png:
- platform/qt/fast/overflow/dynamic-hidden-expected.png:
- platform/qt/fast/overflow/float-in-relpositioned-expected.png:
- platform/qt/fast/overflow/hidden-scrollbar-resize-expected.png:
- platform/qt/fast/overflow/line-clamp-expected.png:
- platform/qt/fast/overflow/overflow-auto-table-expected.png:
- platform/qt/fast/overflow/overflow-float-stacking-expected.png:
- platform/qt/fast/overflow/overflow-focus-ring-expected.png:
- platform/qt/fast/overflow/overflow-rtl-vertical-expected.png:
- platform/qt/fast/overflow/overflow-stacking-expected.png:
- platform/qt/fast/overflow/paged-x-div-with-column-gap-expected.png:
- platform/qt/fast/overflow/position-fixed-transform-clipping-expected.png:
- platform/qt/fast/overflow/scrollbar-position-update-expected.png:
- platform/qt/fast/overflow/table-overflow-float-expected.png:
- platform/qt/fast/overflow/trailing-float-linebox-expected.png:
- platform/qt/fast/parser/001-expected.png:
- platform/qt/fast/parser/broken-comments-vs-parsing-mode-expected.png:
- platform/qt/fast/parser/entity-comment-in-style-expected.png:
- platform/qt/fast/parser/nofoo-tags-inside-paragraph-expected.png:
- platform/qt/fast/parser/open-comment-in-style-expected.png:
- platform/qt/fast/reflections/inline-crash-expected.png:
- platform/qt/fast/reflections/opacity-reflection-transform-expected.png:
- platform/qt/fast/reflections/reflection-masks-expected.png:
- platform/qt/fast/reflections/reflection-masks-opacity-expected.png:
- platform/qt/fast/reflections/reflection-masks-outset-expected.png:
- platform/qt/fast/reflections/reflection-nesting-expected.png:
- platform/qt/fast/reflections/reflection-overflow-hidden-expected.png:
- platform/qt/fast/regions/flow-content-basic-expected.png:
- platform/qt/fast/regions/flow-content-basic-vertical-expected.png:
- platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.png:
- platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png:
- platform/qt/fast/regions/overflow-in-uniform-regions-dynamic-expected.png:
- platform/qt/fast/regions/overflow-in-variable-width-regions-expected.png:
- platform/qt/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
- platform/qt/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png:
- platform/qt/fast/regions/overflow-rtl-in-variable-width-regions-expected.png:
- platform/qt/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
- platform/qt/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png:
- platform/qt/fast/regions/region-style-block-background-color-expected.png:
- platform/qt/fast/regions/region-style-block-background-color2-expected.png:
- platform/qt/fast/regions/text-region-split-small-pagination-expected.png:
- platform/qt/fast/regions/top-overflow-out-of-second-region-expected.png:
- platform/qt/fast/regions/webkit-flow-double-pagination-float-push-expected.png:
- platform/qt/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png:
- platform/qt/fast/regions/webkit-flow-float-unable-to-push-expected.png:
- platform/qt/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png:
- platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png:
- platform/qt/fast/repaint/background-misaligned-expected.png:
- platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png:
- platform/qt/fast/repaint/focus-layers-expected.png:
- platform/qt/fast/repaint/scale-page-shrink-expected.png:
- platform/qt/fast/repaint/transform-absolute-child-expected.png:
- platform/qt/fast/repaint/transform-absolute-in-positioned-container-expected.png:
- platform/qt/fast/repaint/transform-relative-position-expected.png:
- platform/qt/fast/repaint/transform-replaced-shadows-expected.png:
- platform/qt/fast/replaced/004-expected.png:
- platform/qt/fast/replaced/absolute-position-percentage-height-expected.png:
- platform/qt/fast/replaced/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
- platform/qt/fast/replaced/absolute-position-with-auto-width-and-left-and-right-expected.png:
- platform/qt/fast/replaced/applet-display-none-expected.png:
- platform/qt/fast/replaced/image-resize-width-expected.png:
- 4:05 AM Changeset in webkit [146755] by
-
- 2 edits in trunk/Source/WebCore
Cleanup: Tiny nits in ContentSecurityPolicy::reportViolation.
https://bugs.webkit.org/show_bug.cgi?id=112784
Reviewed by Jochen Eisinger.
Just cleanup of three tiny nits I ran across in
ContentSecurityPolicy::reportViolation while doing other work.
- 'directiveText' and 'effectiveDirective' can't be empty; we pass in values at every callsite. We can safely remove the 'isEmpty()' checks. Moreover, even if they could possibly somehow be empty, we should still include those empty strings in the report, rather than dropping the values entirely.
- We don't need to hold 'document->referrer()' in a temp variable.
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation):
- 3:55 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:28 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:26 AM Changeset in webkit [146754] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
E: webkitgtk3 missing-sentinel Source/[...]/TestMain.cpp:47 g_build_filename takes a NULL sentinel.
https://bugs.webkit.org/show_bug.cgi?id=113036
Patch by Dominique Leuenberger <dimstar@opensuse.org> on 2013-03-25
Reviewed by Martin Robinson.
- UIProcess/API/gtk/tests/TestMain.cpp:
(removeNonEmptyDirectory):
- 2:50 AM Changeset in webkit [146753] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Overview] Make "drag-to-move" feature more discoverable.
https://bugs.webkit.org/show_bug.cgi?id=113032
Reviewed by Pavel Feldman.
To move overview window user could drag-n-drop over
time "ribbon" on OverviewGrid.
This feature is hard to discover.
Setting "move" cursor will make this feature more discoverable.
- inspector/front-end/inspectorCommon.css:
Set "move" cursor to draggable area.
- inspector/front-end/OverviewGrid.js: Ditto.
- 2:33 AM Changeset in webkit [146752] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Profiles] Remove unused private member.
https://bugs.webkit.org/show_bug.cgi?id=113015
Reviewed by Pavel Feldman.
_profileGroupsForLinks is not used anymore.
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._reset): Removed unused member.
- 2:33 AM Changeset in webkit [146751] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardneing. Skip two tests, because they are failing with timed out.
- platform/qt/TestExpectations:
- 2:01 AM Changeset in webkit [146750] by
-
- 2 edits in trunk/LayoutTests
Mark fast/css/font-family-pictograph.html as flaky on Linux
- platform/chromium/TestExpectations:
- 1:55 AM Changeset in webkit [146749] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Exception when turning on pretty print without any displayed source in the editor
https://bugs.webkit.org/show_bug.cgi?id=113136
Patch by PhistucK <phistuck@chromium.org> on 2013-03-25
Reviewed by Vsevolod Vlasov.
No new tests.
Added a check for the existence of currently edited document.
- inspector/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
- 1:47 AM Changeset in webkit [146748] by
-
- 2 edits in trunk/Source/WebCore
[CSSRegions] Remove RenderRegion::printRegionObjectsStyles
https://bugs.webkit.org/show_bug.cgi?id=113081
Reviewed by Tony Chang.
No change in functionality, remove unused function..
- rendering/RenderRegion.h:
- 1:45 AM Changeset in webkit [146747] by
-
- 2 edits in trunk/Source/WebCore
[Texmap] Memory leak when closing a tab
https://bugs.webkit.org/show_bug.cgi?id=112127
Patch by Hurnjoo Lee <hurnjoo.lee@samsung.com> on 2013-03-25
Reviewed by Noam Rosenthal.
When closing a tab, if there are any updates pending in CoordinatedGraphicsScene's
render queue, the scene is not freed because reference count of m_scene is not zero.
No new tests.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::detach): When bind updates in CoordinatedGraphicsScene,
the reference count of m_scene is increasing, if m_renderQueue is not empty
before closing tab, then m_scene is never freed.
Hence, when closing tab, need to clear m_renderQueue explicitly in order to
destroy m_scene.
- 1:21 AM Changeset in webkit [146746] by
-
- 3 edits10 adds in trunk
Clear button visibility is not updated when restoring form state
https://bugs.webkit.org/show_bug.cgi?id=113172
Source/WebCore:
Clear button wasn't showing up when restoring form state.
Reviewed by Kent Tamura.
Tests: fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore.html
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore.html
fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore.html
fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore.html
fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore.html
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::restoreFormControlState):
LayoutTests:
Reviewed by Kent Tamura.
- fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
- fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore.html: Added.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore.html: Added.
- fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
- fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore.html: Added.
- fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
- fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore.html: Added.
- 12:45 AM Changeset in webkit [146745] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Settings] Use registry to track settings objects.
https://bugs.webkit.org/show_bug.cgi?id=113008
Reviewed by Pavel Feldman.
Currently .createSetting creates new instance any time it is invoked.
When one instance saves value, the other instance do not know about it.
To resolve this issue we can use registry to make .createSetting return
same object for specific key.
- inspector/front-end/Settings.js:
(WebInspector.Settings.prototype.createSetting): Use registry.
Mar 24, 2013:
- 9:58 PM Changeset in webkit [146744] by
-
- 9 edits in trunk/Source/WebCore
Refactoring: Pull Node::disabled() and Node::isInert() down to Element.
https://bugs.webkit.org/show_bug.cgi?id=112085
Reviewed by Hajime Morrita.
Node is too low a level for these methods. The plan is to rename
Element::disabled to isDisabledFormControl and to remove
Element::isEnabledFormControl.
No new tests, just refactoring.
- dom/Element.cpp:
(WebCore::Element::disabled):
(WebCore):
(WebCore::Element::isInert):
- dom/Element.h:
(Element):
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchSimulatedClick):
- dom/GestureEvent.cpp:
(WebCore::GestureEventDispatchMediator::dispatchEvent):
- dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent):
- dom/Node.cpp:
(WebCore::Node::handleLocalEvents):
(WebCore::Node::willRespondToMouseMoveEvents):
(WebCore::Node::willRespondToMouseClickEvents):
(WebCore::Node::willRespondToTouchEvents):
- dom/Node.h:
(Node):
- 9:27 PM Changeset in webkit [146743] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark canvas-toDataURL-webp.html imageOnlyFailure
https://bugs.webkit.org/show_bug.cgi?id=113169
Unreviewed test expectations update.
Start generating test images on the bots now that libwebp 0.3.0
has landed in chromium webkit.
- platform/chromium/TestExpectations:
- 8:55 PM Changeset in webkit [146742] by
-
- 2 edits in trunk/LayoutTests
[chromium] fast/text/international/danda-space.html is failing
https://bugs.webkit.org/show_bug.cgi?id=113169
Unreviewed test expectations update.
- platform/chromium/TestExpectations:
- 7:15 PM Changeset in webkit [146741] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge 146740 - [l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=113113
Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-03-24
Reviewed by Gustavo Noronha Silva (kov).
- pl.po: updated translation.
- 7:14 PM Changeset in webkit [146740] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=113113
Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-03-24
Reviewed by Gustavo Noronha Silva (kov).
- pl.po: updated translation.
- 6:57 PM Changeset in webkit [146739] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Roll chromium deps to 190311.
https://bugs.webkit.org/show_bug.cgi?id=113161
Unreviewed, rolling deps.
- DEPS:
- 5:38 PM Changeset in webkit [146738] by
-
- 1 edit2 adds in trunk/LayoutTests
[Shadow] Add a test of insertionParent for <shadow> element.
https://bugs.webkit.org/show_bug.cgi?id=113021
Reviewed by Dimitri Glazkov.
- fast/dom/shadow/insertion-parent-shadow-expected.txt: Added.
- fast/dom/shadow/insertion-parent-shadow.html: Added.
- 5:36 PM Changeset in webkit [146737] by
-
- 4 edits in trunk/Source
GIFImageReader should reports parsing error to client
https://bugs.webkit.org/show_bug.cgi?id=113141
Reviewed by Stephen White.
Source/WebCore:
GIFImageReader nows reports parsing error to client (GIFImageDecoder) such that errors can be handled.
In the case of corrupted GIF images GIFImageReader will be deleted and decoding will fail.
Unit test is updated to reflect change in behavior.
Tested with a local corpus which showed better handling of corrupted GIF images.
- platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::decode):
Source/WebKit/chromium:
Updated unit test that runs on a broken GIF image file, decoding should fail.
- tests/GIFImageDecoderTest.cpp:
(WebKit::TEST):
- 4:37 PM Changeset in webkit [146736] by
-
- 5 edits in trunk/Source
[chromium] Wire windows scrollByPage enum up to compositor thread input handling
https://bugs.webkit.org/show_bug.cgi?id=113117
Reviewed by Adrienne Walker.
Source/Platform:
- chromium/public/WebInputHandlerClient.h:
Source/WebKit/chromium:
- src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
- tests/WebCompositorInputHandlerImplTest.cpp:
(MockWebInputHandlerClient):
- 4:15 PM Changeset in webkit [146735] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r190276. Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-24
- DEPS:
- 3:45 PM Changeset in webkit [146734] by
-
- 12 edits2 adds in trunk/Source/JavaScriptCore
HandleSet should use HeapBlocks for storing handles
https://bugs.webkit.org/show_bug.cgi?id=113145
Reviewed by Geoffrey Garen.
- GNUmakefile.list.am: Build project changes.
- JavaScriptCore.gypi: Ditto.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Ditto.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
- JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
- heap/BlockAllocator.cpp: Rename the RegionSet to m_fourKBBlockRegionSet because there are
too many block types to include them all in the name now.
(JSC::BlockAllocator::BlockAllocator):
- heap/BlockAllocator.h:
(BlockAllocator): Add the appropriate override for regionSetFor.
(JSC::WeakBlock):
(JSC::MarkStackSegment):
(JSC::HandleBlock):
- heap/HandleBlock.h: Added.
(HandleBlock): New class for HandleBlocks.
(JSC::HandleBlock::blockFor): Static method to get the block of the given HandleNode pointer. Allows
us to quickly figure out which HandleSet the HandleNode belongs to without storing the pointer to it
in the HandleNode.
(JSC::HandleBlock::handleSet): Getter.
- heap/HandleBlockInlines.h: Added.
(JSC::HandleBlock::create):
(JSC::HandleBlock::HandleBlock):
(JSC::HandleBlock::payloadEnd):
(JSC::HandleBlock::payload):
(JSC::HandleBlock::nodes):
(JSC::HandleBlock::nodeAtIndex):
(JSC::HandleBlock::nodeCapacity):
- heap/HandleSet.cpp:
(JSC::HandleSet::~HandleSet):
(JSC::HandleSet::grow):
- heap/HandleSet.h:
(HandleNode): Move the internal Node class from HandleSet to be its own public class so it can be
used by HandleBlock.
(HandleSet): Add a typedef so that Node refers to the new HandleNode class.
(JSC::HandleSet::toHandle):
(JSC::HandleSet::toNode):
(JSC::HandleSet::allocate):
(JSC::HandleSet::deallocate):
(JSC::HandleNode::HandleNode):
(JSC::HandleNode::slot):
(JSC::HandleNode::handleSet): Use the new blockFor static function to get the right HandleBlock and lookup
the HandleSet.
(JSC::HandleNode::setPrev):
(JSC::HandleNode::prev):
(JSC::HandleNode::setNext):
(JSC::HandleNode::next):
(JSC::HandleSet::forEachStrongHandle):
- heap/Heap.h: Friend HandleSet so that it can access the BlockAllocator when allocating HandleBlocks.
- 12:16 PM Changeset in webkit [146733] by
-
- 9 edits2 copies in branches/chromium/1451/Source/WebCore
Revert 146458 "[EFL][WebGL] Implement a common GraphicsSurface I..."
[EFL][WebGL] Implement a common GraphicsSurface Implementation.
https://bugs.webkit.org/show_bug.cgi?id=111759
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-21
Reviewed by Kenneth Rohde Christiansen.
Covered by existing WebGL tests.
This is in preparation to add transport surface support for GLES2.
This patch makes it easy to share the core logic of using
Transport Surface and client on GLX and GLES2 backends without
any code duplication.
- PlatformEfl.cmake:
- platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::releaseResources):
(WebCore::GraphicsContext3DPrivate::prepareBuffer):
(WebCore::GraphicsContext3DPrivate::createGraphicsSurface):
(WebCore::GraphicsContext3DPrivate::didResizeCanvas):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
- platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
TransportSurface related code is moved to GraphicsSurfaceCommon.
As GraphicsSurface is deleted on resize, added logic to ensure that
current buffer is not deleted before having the shared buffer
with correct size. This would avoid any flashing during resize.
- platform/graphics/opengl/GLPlatformSurface.cpp:
(WebCore::GLPlatformSurface::createTransportSurface):
- platform/graphics/opengl/GLPlatformSurface.h:
- platform/graphics/surfaces/efl/GLTransportSurface.cpp: Renamed from Source/WebCore/platform/graphics/surfaces/GLTransportSurface.cpp.
(WebCore):
(WebCore::GLTransportSurface::GLTransportSurface):
(WebCore::GLTransportSurface::~GLTransportSurface):
(WebCore::GLTransportSurface::updateContents):
(WebCore::GLTransportSurface::setGeometry):
(WebCore::GLTransportSurface::destroy):
(WebCore::GLTransportSurface::draw):
(WebCore::GLTransportSurface::bindArrayBuffer):
(WebCore::GLTransportSurface::updateTransformationMatrix):
(WebCore::GLTransportSurface::initializeShaderProgram):
(WebCore::GLTransportSurfaceClient::createTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::~GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::destroy):
(WebCore::GLTransportSurfaceClient::prepareTexture):
(WebCore::GLTransportSurfaceClient::createTexture):
- platform/graphics/surfaces/efl/GLTransportSurface.h: Renamed from Source/WebCore/platform/graphics/surfaces/GLTransportSurface.h.
(WebCore):
(GLTransportSurface):
(GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::texture):
(WebCore::GLTransportSurfaceClient::hasAlpha):
Moved TransportSurface to EFL folder as this is being used by EFL port only.
Added a base class for TransportSurfaceClient.
- platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp: Added.
(WebCore):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::destroy):
(WebCore::GraphicsSurfacePrivate::initializeTransportSurface):
(WebCore::GraphicsSurfacePrivate::makeContextCurrent):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(WebCore::GraphicsSurfacePrivate::handle):
(WebCore::GraphicsSurfacePrivate::updateClientBuffer):
(WebCore::GraphicsSurfacePrivate::flags):
(WebCore::GraphicsSurfacePrivate::rect):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurfacePrivate::textureId):
(WebCore::GraphicsSurfacePrivate::initializeClient):
(WebCore::GraphicsSurface::platformExport):
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformCopyToGLTexture):
(WebCore::GraphicsSurface::platformCopyFromTexture):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
(WebCore::GraphicsSurface::platformFrontBuffer):
(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformSize):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):
(WebCore::GraphicsSurface::platformDestroy):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):
GraphicsSurface implementation to be shared by both GLX and GLES2.
- platform/graphics/surfaces/egl/EGLSurface.cpp:
(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
- platform/graphics/surfaces/egl/EGLSurface.h:
(EGLWindowTransportSurface):
- platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore):
(WebCore::resolveGLMethods):
(WebCore::isMesaGLX):
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurfaceClient::GLXTransportSurfaceClient):
(WebCore::GLXTransportSurfaceClient::~GLXTransportSurfaceClient):
(WebCore::GLXTransportSurfaceClient::destroy):
(WebCore::GLXTransportSurfaceClient::prepareTexture):
- platform/graphics/surfaces/glx/GLXSurface.h:
(GLXTransportSurface):
(GLXTransportSurfaceClient):
(WebCore):
GLXTransportSurfaceClient implementation.
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/13046002
- 12:13 PM Changeset in webkit [146732] by
-
- 1 add in branches/chromium/1451/codereview.settings
for drovering
- 12:12 PM Changeset in webkit [146731] by
-
- 1 copy in branches/chromium/1451
branching to revert a change for canary.
- 8:57 AM Changeset in webkit [146730] by
-
- 4 edits in trunk/Source/WebCore
[EFL] Add support to check for current Drawable.
https://bugs.webkit.org/show_bug.cgi?id=113103
Patch by KondapallyKalyan <kalyan.kondapally@intel.com> on 2013-03-24
Reviewed by Kenneth Rohde Christiansen.
Covered by existing WebGL tests.
In MakeCurrent we do an early return if it is
the current GL context but ignore Surface. This
patch fixes the issue, we now check for both
context and surface before doing an early return
in MakeCurrent.
- platform/graphics/opengl/GLPlatformContext.cpp:
(WebCore::GLPlatformContext::makeCurrent):
(WebCore::GLPlatformContext::releaseCurrent):
(WebCore::GLPlatformContext::destroy):
- platform/graphics/opengl/GLPlatformSurface.cpp:
(WebCore):
(WebCore::GLPlatformSurface::isCurrentDrawable):
(WebCore::GLPlatformSurface::onMakeCurrent):
- platform/graphics/opengl/GLPlatformSurface.h:
- 8:47 AM Changeset in webkit [146729] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX (r146704): Settings::setHiddenPageDOMTimerThrottlingEnabled() isn't always built
<http://webkit.org/b/112308>
- WebCore.exp.in: Export
Settings::setHiddenPageDOMTimerThrottlingEnabled()
conditionally based on ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING).
- 7:43 AM Changeset in webkit [146728] by
-
- 2 edits in trunk/Source/WebCore
[EFL] NetworkStateNotifier::updateState() is called too often
https://bugs.webkit.org/show_bug.cgi?id=113152
Reviewed by Kenneth Rohde Christiansen.
Wait until we have read all the data on the Netlink socket before
reporting a possible network interface change. This way, we make
sure we don't call NetworkStateNotifier::updateState() several
times in a row for no reason.
We also call NetworkStateNotifier::updateState() only if we get a
RTM_NEWADDR event and we are currently offline, or if we get a
RTM_DELADDR and we are currently online. This avoids calling
NetworkStateNotifier::updateState() uselessly as there is no way
the online state can change otherwise.
No new tests, no behavior change for layout tests.
- platform/network/efl/NetworkStateNotifierEfl.cpp:
(WebCore::NetworkStateNotifier::readSocketCallback):
- 3:36 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:20 AM Changeset in webkit [146727] by
-
- 5 edits2 adds in trunk
AX: Crash in WebCore::AccessibilitySpinButton::incrementButton()
https://bugs.webkit.org/show_bug.cgi?id=111582
Reviewed by Tim Horton.
Source/WebCore:
There are two ways to create a spin button: from a textfield counter or from ARIA.
If an ARIA spin button is created, it was returning true for isSpinButton, so we were
casting to the other kind of spin button, leading to a crash.
We need to be more specific about our class types.
Test: platform/mac/accessibility/aria-spinbutton-crash.html
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isNativeSpinButton):
- accessibility/AccessibilitySpinButton.h:
(WebCore::AccessibilitySpinButton::isNativeSpinButton):
(WebCore::toAccessibilitySpinButton):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
LayoutTests:
- platform/mac/accessibility/aria-spinbutton-crash-expected.txt: Added.
- platform/mac/accessibility/aria-spinbutton-crash.html: Added.
- 12:37 AM Changeset in webkit [146726] by
-
- 34 edits in trunk/Source/WebCore
AXObjectCache gets recreated during document tear-down.
https://bugs.webkit.org/show_bug.cgi?id=112525
Reviewed by Simon Fraser.
In many cases, a document's AXObjectCache was being created after the
document had detached, which is wasteful and could potentially lead to
crashes because the AXObjectCache has a timer and relies on its document
to exist.
This patch provides a way to get the existing AX object cache, instead of
always creating a new one.
It moves the accessibilityEnabled() checks into the axObjectCache retrieval
for easier readability.
It adds a number of ASSERTs to vieryf that only the correct (top) document is used
for cache manipulation.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::stopCachingComputedObjectAttributes):
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::~ContainerNode):
- dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::clearAXObjectCache):
(WebCore::Document::existingAXObjectCache):
(WebCore::Document::axObjectCache):
(WebCore::Document::setFocusedNode):
- dom/Document.h:
(Document):
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
- dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::isEditableToAccessibility):
(WebCore::Node::attach):
(WebCore::Node::rootEditableElement):
(WebCore::Node::didMoveToNewDocument):
- editing/AppendNodeCommand.cpp:
(WebCore::sendAXTextChangedIgnoringLineBreaks):
- editing/DeleteFromTextNodeCommand.cpp:
(WebCore::DeleteFromTextNodeCommand::doApply):
(WebCore::DeleteFromTextNodeCommand::doUnapply):
- editing/Editor.cpp:
(WebCore::Editor::respondToChangedContents):
(WebCore::Editor::markAndReplaceFor):
- editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):
- editing/InsertNodeBeforeCommand.cpp:
(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):
- editing/atk/FrameSelectionAtk.cpp:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
- editing/chromium/FrameSelectionChromium.cpp:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
- editing/mac/FrameSelectionMac.mm:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setChecked):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::optionElementChildrenChanged):
(WebCore::HTMLSelectElement::setRecalcListItems):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setInnerTextValue):
- html/InputType.cpp:
(WebCore::InputType::applyStep):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::handleKeydownEvent):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
- page/FocusController.cpp:
(WebCore::FocusController::setInitialFocus):
- page/Frame.cpp:
(WebCore::Frame::disconnectOwnerElement):
- page/FrameView.cpp:
(WebCore::FrameView::removeFromAXObjectCache):
(WebCore::FrameView::layout):
(WebCore::FrameView::scrollToAnchor):
(WebCore::FrameView::axObjectCache):
- platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::~Scrollbar):
(WebCore):
(WebCore::Scrollbar::existingAXObjectCache):
- platform/Scrollbar.h:
(Scrollbar):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::deleteLineBoxTree):
(WebCore::RenderBlock::createRootInlineBox):
(WebCore::RenderBlock::createAndAppendRootInlineBox):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::selectionChanged):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::addChild):
(WebCore::RenderMenuList::didUpdateActiveOption):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::willBeDestroyed):
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
- rendering/RenderText.cpp:
(WebCore::RenderText::setText):
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::willBeDestroyed):
Mar 23, 2013:
- 10:50 PM Changeset in webkit [146725] by
-
- 13 edits in trunk
Drop full URLs from cross-origin access errors caused by sandboxing.
https://bugs.webkit.org/show_bug.cgi?id=113029
Reviewed by Timothy Hatcher.
Source/WebCore:
Following up on http://wkbug.com/112042, this patch brings cross-origin
access error messages into line with the newly origin-only default
message, and changes the error message text to explicitly refer to the
missing 'allow-same-origin' sandbox flag that's the root cause of the
error.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::crossDomainAccessErrorMessage):
Note that we're using the origin of the frames' URLs rather than
their actual origin in these messages. This seems like a reasonable
thing to do, since we know that at least one of the two origins will
be "null" in this scenario.
LayoutTests:
- http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-expected.txt:
- http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
- http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt:
- http/tests/security/sandboxed-iframe-origin-add-expected.txt:
- http/tests/security/sandboxed-iframe-origin-remove-expected.txt:
- http/tests/security/xss-DENIED-sandboxed-iframe-expected.txt:
- platform/chromium/http/tests/security/sandboxed-iframe-modify-self-expected.txt:
- platform/chromium/http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt:
- 9:48 PM Changeset in webkit [146724] by
-
- 21 edits9 adds in trunk/Source
Implement Web Speech Synthesis for Chromium
https://bugs.webkit.org/show_bug.cgi?id=111695
Reviewed by Adam Barth.
Source/Platform:
Exposes a platform API that the embedder can implement to
provide speech synthesis for the Chromium port.
- Platform.gypi:
- chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::speechSynthesizer):
- chromium/public/WebSpeechSynthesisUtterance.h: Added.
(WebKit):
(WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::~WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::operator=):
(WebKit::WebSpeechSynthesisUtterance::isNull):
- chromium/public/WebSpeechSynthesisVoice.h: Added.
(WebCore):
(WebKit):
(WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::~WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::operator=):
- chromium/public/WebSpeechSynthesizer.h: Added.
(WebKit):
(WebSpeechSynthesizer):
(WebKit::WebSpeechSynthesizer::~WebSpeechSynthesizer):
- chromium/public/WebSpeechSynthesizerClient.h: Added.
(WebKit):
(WebSpeechSynthesizerClient):
(WebKit::WebSpeechSynthesizerClient::~WebSpeechSynthesizerClient):
Source/WebCore:
Straightforward implementation of speech synthesis
for Chromium by exposing interfaces for the platform
to implement.
- Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::boundaryEventOccurred):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didPauseSpeaking):
(WebCore::SpeechSynthesis::didResumeSpeaking):
(WebCore::SpeechSynthesis::didFinishSpeaking):
(WebCore::SpeechSynthesis::speakingErrorOccurred):
(WebCore):
- Modules/speech/SpeechSynthesis.h:
(SpeechSynthesis):
- Modules/speech/SpeechSynthesisUtterance.cpp:
(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore):
(WebCore::SpeechSynthesisUtterance::~SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::setVoice):
- Modules/speech/SpeechSynthesisUtterance.h:
(SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::text):
(WebCore::SpeechSynthesisUtterance::setText):
(WebCore::SpeechSynthesisUtterance::lang):
(WebCore::SpeechSynthesisUtterance::setLang):
(WebCore::SpeechSynthesisUtterance::volume):
(WebCore::SpeechSynthesisUtterance::setVolume):
(WebCore::SpeechSynthesisUtterance::rate):
(WebCore::SpeechSynthesisUtterance::setRate):
(WebCore::SpeechSynthesisUtterance::pitch):
(WebCore::SpeechSynthesisUtterance::setPitch):
(WebCore::SpeechSynthesisUtterance::startTime):
(WebCore::SpeechSynthesisUtterance::setStartTime):
(WebCore::SpeechSynthesisUtterance::platformUtterance):
- Modules/speech/SpeechSynthesisVoice.h:
(WebCore::SpeechSynthesisVoice::~SpeechSynthesisVoice):
- WebCore.exp.in:
- WebCore.gypi:
- platform/PlatformSpeechSynthesis.h:
(PlatformSpeechSynthesis):
- platform/PlatformSpeechSynthesisUtterance.cpp:
(WebCore):
(WebCore::PlatformSpeechSynthesisUtterance::create):
- platform/PlatformSpeechSynthesisUtterance.h:
(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::setClient):
- platform/PlatformSpeechSynthesisVoice.cpp:
(WebCore):
(WebCore::PlatformSpeechSynthesisVoice::create):
(WebCore::PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice):
- platform/PlatformSpeechSynthesisVoice.h:
(PlatformSpeechSynthesisVoice):
(WebCore::PlatformSpeechSynthesisVoice::setVoiceURI):
(WebCore::PlatformSpeechSynthesisVoice::setName):
(WebCore::PlatformSpeechSynthesisVoice::setLang):
(WebCore::PlatformSpeechSynthesisVoice::setLocalService):
(WebCore::PlatformSpeechSynthesisVoice::setIsDefault):
- platform/PlatformSpeechSynthesizer.cpp:
(WebCore::PlatformSpeechSynthesizer::create):
(WebCore::PlatformSpeechSynthesizer::setVoiceList):
(WebCore):
- platform/PlatformSpeechSynthesizer.h:
(WebKit):
(PlatformSpeechSynthesizerClient):
(PlatformSpeechSynthesizer):
- platform/chromium/PlatformSpeechSynthesizerChromium.cpp: Added.
(WebCore):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(WebCore::PlatformSpeechSynthesizer::speak):
(WebCore::PlatformSpeechSynthesizer::pause):
(WebCore::PlatformSpeechSynthesizer::resume):
(WebCore::PlatformSpeechSynthesizer::cancel):
- platform/chromium/support/WebSpeechSynthesisUtterance.cpp: Added.
(WebKit):
(WebKit::WebSpeechSynthesisUtterance::WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::operator=):
(WebKit::WebSpeechSynthesisUtterance::assign):
(WebKit::WebSpeechSynthesisUtterance::reset):
(WebKit::WebSpeechSynthesisUtterance::operator PassRefPtr<PlatformSpeechSynthesisUtterance>):
(WebKit::WebSpeechSynthesisUtterance::operator PlatformSpeechSynthesisUtterance*):
(WebKit::WebSpeechSynthesisUtterance::text):
(WebKit::WebSpeechSynthesisUtterance::lang):
(WebKit::WebSpeechSynthesisUtterance::voice):
(WebKit::WebSpeechSynthesisUtterance::volume):
(WebKit::WebSpeechSynthesisUtterance::rate):
(WebKit::WebSpeechSynthesisUtterance::pitch):
(WebKit::WebSpeechSynthesisUtterance::startTime):
- platform/chromium/support/WebSpeechSynthesisVoice.cpp: Added.
(WebKit):
(WebKit::WebSpeechSynthesisVoice::assign):
(WebKit::WebSpeechSynthesisVoice::reset):
(WebKit::WebSpeechSynthesisVoice::setVoiceURI):
(WebKit::WebSpeechSynthesisVoice::setName):
(WebKit::WebSpeechSynthesisVoice::setLanguage):
(WebKit::WebSpeechSynthesisVoice::setIsLocalService):
(WebKit::WebSpeechSynthesisVoice::setIsDefault):
(WebKit::WebSpeechSynthesisVoice::operator PassRefPtr<WebCore::PlatformSpeechSynthesisVoice>):
- platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp: Added.
(WebCore):
(WebCore::WebSpeechSynthesizerClientImpl::WebSpeechSynthesizerClientImpl):
(WebCore::WebSpeechSynthesizerClientImpl::~WebSpeechSynthesizerClientImpl):
(WebCore::WebSpeechSynthesizerClientImpl::setVoiceList):
(WebCore::WebSpeechSynthesizerClientImpl::didStartSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didFinishSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didPauseSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didResumeSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::speakingErrorOccurred):
(WebCore::WebSpeechSynthesizerClientImpl::wordBoundaryEventOccurred):
(WebCore::WebSpeechSynthesizerClientImpl::sentenceBoundaryEventOccurred):
- platform/chromium/support/WebSpeechSynthesizerClientImpl.h: Added.
(WebCore):
(WebSpeechSynthesizerClientImpl):
- platform/mac/PlatformSpeechSynthesizerMac.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::speak):
- platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
(WebCore::PlatformSpeechSynthesizerMock::speak):
- platform/mock/PlatformSpeechSynthesizerMock.h:
(PlatformSpeechSynthesizerMock):
- 6:24 PM Changeset in webkit [146723] by
-
- 4 edits in trunk
[Qt] editing/pasteboard/can-read-in-dragstart-event.html and /can-read-in-copy-and-cut-events.html are crashing
https://bugs.webkit.org/show_bug.cgi?id=113126
Reviewed by Ryosuke Niwa.
Source/WebCore:
The ClipboardQt implementation only allows reading or writing, not both. Attempting to read
when the clipboard is only writable will lead to a crash since the corresponding member will
be null. To prevent crashes, change the asserts to early returns. In the long term, the
correct fix is to unify the m_readableData and m_writableData members.
No new tests since no functionality in Qt port should change.
- platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::getData):
(WebCore::ClipboardQt::types):
(WebCore::ClipboardQt::files):
LayoutTests:
- platform/qt/TestExpectations:
- 1:18 PM Changeset in webkit [146722] by
-
- 2 edits in trunk/Source/WebKit2
Added a setting for whether JavaScript markup is enabled
https://bugs.webkit.org/show_bug.cgi?id=112999
Rolled out a line from r146664 that was left over from before I adopted
the Settings.in way of adding a new setting.
Reviewed by Ryosuke Niwa.
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): No need
to initialize / override -- Settings.in settings do this automatically.
Also, dydx noticed that this line of code had a typo, and was totaly wrong.
- 10:47 AM Changeset in webkit [146721] by
-
- 6 edits in trunk/Source
[GTK][Regression] webkit_dom_html_table_element_insert_row returns value that doesn't pass WEBKIT_DOM_IS_HTML_TABLE_ROW_ELEMENT macro
https://bugs.webkit.org/show_bug.cgi?id=111714
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-23
Reviewed by Martin Robinson.
Source/WebCore:
Add custom kit implementation for HTMLElements so that the HTML
wrappers are used in that case instead of wrapHTMLElement.
- bindings/gobject/WebKitDOMBinding.cpp:
(WebKit::kit):
(WebKit):
- bindings/gobject/WebKitDOMBinding.h:
(WebCore):
(WebKit):
- bindings/scripts/CodeGeneratorGObject.pm:
(UsesManualKitImplementation):
Source/WebKit/gtk:
Add test that checks webkit_dom_html_table_element_insert_row() to
also preproduce this issue.
- tests/testdomdocument.c:
(test_dom_document_insert_row):
(main):
- 7:44 AM Changeset in webkit [146720] by
-
- 2 edits in trunk/Source/WebCore
Revert "BUILD FIX (r146667): ResourceRequest constructor in SynchronousLoaderClient.cpp is ambiguous on iOS"
This is platform-agnositic code, so the previous solution won't work.
- 7:41 AM Changeset in webkit [146719] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX (r146667): ResourceRequest constructor in SynchronousLoaderClient.cpp is ambiguous on iOS
Fixes the following build failure:
Source/WebCore/platform/network/SynchronousLoaderClient.cpp:52:15: error: conversion from 'int' to 'const WebCore::ResourceRequest' is ambiguous
request = 0;
In file included from Source/WebCore/platform/network/SynchronousLoaderClient.cpp:30:
In file included from Source/WebCore/platform/network/ResourceHandle.h:37:
In file included from Source/WebCore/platform/network/ios/QuickLook.h:13:
Source/WebCore/platform/network/cf/ResourceRequest.h:79:9: note: candidate constructor
ResourceRequest(NSURLRequest *);
Source/WebCore/platform/network/cf/ResourceRequest.h:83:9: note: candidate constructor
ResourceRequest(CFURLRequestRef cfRequest)
1 error generated.
- platform/network/SynchronousLoaderClient.cpp:
(WebCore::SynchronousLoaderClient::willSendRequest): If
USE(CFNETWORK) is defined, use static_cast<CFURLRequestRef>(0),
otherwise use static_cast<NSURLRequest *>(0).
- 7:16 AM Changeset in webkit [146718] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX (r146687): setDefaultMIMEType() is unused in ResourceHandleCFNet.cpp on iOS
Fixes the following build failure:
Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:98:13: error: unused function 'setDefaultMIMEType' [-Werror,-Wunused-function]
static void setDefaultMIMEType(CFURLResponseRef response)
1 error generated.
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::setDefaultMIMEType): Add #if !PLATFORM(MAC)/#endif
guard.
Mar 22, 2013:
- 11:36 PM Changeset in webkit [146717] by
-
- 2 edits in trunk/LayoutTests
[chromium] Stupid picky bug syntax...
Unreviewed, test expectations updates.
- platform/chromium/TestExpectations:
- 10:58 PM Changeset in webkit [146716] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark flaky test.
https://bugs.webkit.org/show_bug.cgi?id=113129
Unreviewed, test expectations updates.
- platform/chromium/TestExpectations:
- 10:47 PM Changeset in webkit [146715] by
-
- 4 edits2 deletes in trunk/LayoutTests
[chromium] Last bits of post-Skia-change fallout, plus other bits.
https://bugs.webkit.org/show_bug.cgi?id=109507
https://bugs.webkit.org/show_bug.cgi?id=113067
https://bugs.webkit.org/show_bug.cgi?id=113128
https://code.google.com/p/chromium/issues/detail?id=67442
Unreviewed, test expectations updates.
Deleted a few new baselines added during Skia rebaselining that were
existing expected failures from bug 109507 whose failure lines were
left in TestExpectations.
Added a flaky test and a failing test (which for some reason has no new
baselines so I can't rebaseline), and removed a passing test.
Re-added some "Pass" expectations I'd previously removed, as they're
necessary after all.
- platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Removed.
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt:
- platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt:
- platform/chromium/TestExpectations:
- platform/chromium/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Removed.
- 9:59 PM Changeset in webkit [146714] by
-
- 2 edits in trunk/LayoutTests
Add a timeout expectation to media/track/track-prefer-captions.html after
r146380 on GTK+. The failure is tracked by http://webkit.org/b/113127
- platform/gtk/TestExpectations:
- 9:54 PM Changeset in webkit [146713] by
-
- 2 edits in trunk/LayoutTests
Add crash test expectations to tests added in r146644.
The failures are tracked by http://webkit.org/b/113126
- platform/qt/TestExpectations:
- 9:51 PM Changeset in webkit [146712] by
-
- 2 edits in trunk/Source/JavaScriptCore
BUILD FIX (r145119): Make JSValue* properties default to (assign)
<rdar://problem/13380794>
Reviewed by Mark Hahnenberg.
Fixes the following build failures:
Source/JavaScriptCore/API/tests/testapi.mm:106:1: error: no 'assign', 'retain', or 'copy' attribute is specified - 'assign' is assumed [-Werror,-Wobjc-property-no-attribute]
@property JSValue *onclick;
Source/JavaScriptCore/API/tests/testapi.mm:106:1: error: default property attrib ute 'assign' not appropriate for non-GC object [-Werror,-Wobjc-property-no-attribute]
Source/JavaScriptCore/API/tests/testapi.mm:107:1: error: no 'assign', 'retain', or 'copy' attribute is specified - 'assign' is assumed [-Werror,-Wobjc-property-no-attribute]
@property JSValue *weakOnclick;
Source/JavaScriptCore/API/tests/testapi.mm:107:1: error: default property attribute 'assign' not appropriate for non-GC object [-Werror,-Wobjc-property-no-attribute]
4 errors generated.
- API/tests/testapi.mm: Default to (assign) for JSValue*
properties.
- 9:20 PM Changeset in webkit [146711] by
-
- 2 edits in trunk/Source/JavaScriptCore
testLeakingPrototypesAcrossContexts added in r146682 doesn't compile on Win and fails on Mac
https://bugs.webkit.org/show_bug.cgi?id=113125
Reviewed by Mark Hahnenberg
Remove the test added in r146682 as it's now failing on Mac.
This is the test that was causing a compilation failure on Windows.
- API/tests/testapi.c:
(main):
- 8:35 PM Changeset in webkit [146710] by
-
- 4 edits in trunk/Source/WebKit
The second part of the build fix for r146702. This should do it.
I had to see the mangled name for the new signature.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
- 8:34 PM Changeset in webkit [146709] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark canvas-toDataURL-webp.html imageOnlyFailure Pass
https://bugs.webkit.org/show_bug.cgi?id=93310
Unreviewed test expectations update.
libwebp will be updated to 0.3.0 in chrome, changing the encoder
output, after which these test results will need to be updated.
- platform/chromium/TestExpectations:
- 8:24 PM Changeset in webkit [146708] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix the typo: WIN -> WINDOWS.
- API/tests/testapi.c:
(main):
- 8:12 PM Changeset in webkit [146707] by
-
- 2 edits in trunk/Source/JavaScriptCore
I really can't figure out what's wrong with this one.
Temporarily disable the test added by r146682 on Windows since it doesn't compile.
- API/tests/testapi.c:
(main):
- 8:09 PM Changeset in webkit [146706] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark more tests as crashing.
https://bugs.webkit.org/show_bug.cgi?id=113067
Unreviewed, test expectations update.
- platform/chromium/TestExpectations:
- 7:50 PM Changeset in webkit [146705] by
-
- 4 edits in trunk/Source/WebKit
Build fix attempt after r146702.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
- 7:15 PM Changeset in webkit [146704] by
-
- 19 edits in trunk
Add runtime setting for hidden page DOM timer throttling and CSS animation suspension
https://bugs.webkit.org/show_bug.cgi?id=112308
Reviewed by Gavin Barraclough.
Source/WebCore:
No new tests. Only adding settings to enable/disable existing features
and hence existing tests suffice.
- WebCore.exp.in:
- page/Page.cpp:
(WebCore::Page::setVisibilityState): Check if DOM timer throttling
and CSS animation suspension are enabled before turning them on.
(WebCore::Page::hiddenPageDOMTimerThrottlingStateChanged): Start or stop
DOM timer throttling based on page visibility and the new setting state.
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged): Ditto
for CSS animation suspension.
- page/Page.h:
- page/Settings.cpp:
(WebCore::Settings::Settings): Initialize the flags for enabling hidden
page DOM timer throttling and CSS animation suspension to false.
(WebCore::Settings::setHiddenPageDOMTimerThrottlingEnabled): Update flag
and notify page that the state of the setting has changed.
(WebCore::Settings::setHiddenPageCSSAnimationSuspensionEnabled): Ditto.
- page/Settings.h:
(WebCore::Settings::hiddenPageDOMTimerThrottlingEnabled):
(WebCore::Settings::hiddenPageCSSAnimationSuspensionEnabled):
Source/WebKit/mac:
Add private preference for enabling/disabling hidden page DOM timer
throttling and CSS animation suspension. The preference should be
disabled by default to avoid compatibility issues.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences hiddenPageDOMTimerThrottlingEnabled]):
(-[WebPreferences setHiddenPageDOMTimerThrottlingEnabled:]):
(-[WebPreferences hiddenPageCSSAnimationSuspensionEnabled]):
(-[WebPreferences setHiddenPageCSSAnimationSuspensionEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
Add private preference for enabling/disabling hidden page DOM timer
throttling and CSS animation suspension. The preference should be
enabled by default only on Mac, where WebKit2 is a private API and
hence compatibility is less of a issue.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetHiddenPageDOMTimerThrottlingEnabled):
(WKPreferencesGetHiddenPageDOMTimerThrottlingEnabled):
(WKPreferencesSetHiddenPageCSSAnimationSuspensionEnabled):
(WKPreferencesGetHiddenPageCSSAnimationSuspensionEnabled):
- UIProcess/API/C/WKPreferencesPrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Allow
WebKitTestRunner to override hiddenPageDOMTimerThrottlingEnabled.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
LayoutTests:
Hidden page DOM timer throttling is disabled by default in WebKit1 and
in WebKit2 for platforms other than Mac. Override the preference to
enable it during the test.
- fast/dom/timer-throttling-hidden-page.html:
- 7:01 PM Changeset in webkit [146703] by
-
- 2 edits in trunk/Tools
Unreviewed. Move self from contributor to committer list.
- Scripts/webkitpy/common/config/committers.py:
- 6:35 PM Changeset in webkit [146702] by
-
- 7 edits in trunk/Source
Remove 2 bad branches from StringHash::equal() and CaseFoldingHash::equal()
https://bugs.webkit.org/show_bug.cgi?id=113003
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-22
Reviewed by Eric Seidel.
Source/WebCore:
Fix two unfortunate use of StringHash and use the correct StringImpl function.
- html/parser/HTMLParserIdioms.cpp:
(WebCore::threadSafeEqual):
- html/parser/HTMLTreeBuilderSimulator.cpp:
(WebCore::tokenExitsSVG):
Source/WTF:
StringHash::equal() and CaseFoldingHash::equal() were both testing for
the nullity of the two input pointers. The catch is: neither traits handle
null pointers, and any client code would have crashed on hash(), before equal()
is called.
Consequently, the two branches had a pass rate of zero when called from a HashMap code.
The function is also never inlined because it is too big (the code of equal() for characters
is always inlined, causing the function to be quite big).
This patch introduces two new functions in the StringImpl API: equalNonNull() and
equalIgnoringCaseNonNull(). Those functions are similar to their equal() equivalent
but make the assumtion the input is never null.
The functions are used for StringHash to avoid the useless branches.
- wtf/text/StringHash.h:
(WTF::StringHash::equal):
(WTF::CaseFoldingHash::equal):
- wtf/text/StringImpl.cpp:
(WTF::stringImplContentEqual):
(WTF::equal):
(WTF::equalNonNull):
(WTF::equalIgnoringCase):
(WTF::equalIgnoringCaseNonNull):
(WTF::equalIgnoringNullity):
- wtf/text/StringImpl.h:
(WTF::equalIgnoringCase):
- 6:19 PM Changeset in webkit [146701] by
-
- 2 edits in trunk/Source/WebCore
Set the cache partition property on CFURLRequests
https://bugs.webkit.org/show_bug.cgi?id=113116
Patch by Jeffrey Pfau
Reviewed by David Kilzer.
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
- 6:17 PM Changeset in webkit [146700] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Test expectations after Skia changes
Unreviewed expectations update.
Adding bug numbers for two failing tests.
- platform/chromium/TestExpectations:
- 6:10 PM Changeset in webkit [146699] by
-
- 81 edits6 adds5 deletes in trunk/LayoutTests
[Chromium] Test expectations after Skia changes
Unreviewed expectations update.
The rest.
- platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
- platform/chromium-linux/fast/borders/border-radius-with-box-shadow-01-expected.png:
- platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png:
- platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
- platform/chromium-linux/fast/box-shadow/box-shadow-clipped-slices-expected.png:
- platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.png:
- platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
- platform/chromium-linux/fast/box-shadow/inset-expected.png:
- platform/chromium-linux/fast/box-shadow/scaled-box-shadow-expected.png: Added.
- platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.png:
- platform/chromium-mac-lion/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
- platform/chromium-mac-lion/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
- platform/chromium-mac-lion/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
- platform/chromium-mac-lion/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
- platform/chromium-mac-lion/editing/selection/select-text-overflow-ellipsis-expected.png:
- platform/chromium-mac-lion/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
- platform/chromium-mac-lion/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
- platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
- platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
- platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
- platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
- platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
- platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
- platform/chromium-mac-lion/fast/backgrounds/animated-svg-as-mask-expected.png:
- platform/chromium-mac-lion/fast/borders/border-antialiasing-expected.png:
- platform/chromium-mac-lion/fast/borders/border-radius-split-inline-expected.png:
- platform/chromium-mac-lion/fast/box-shadow/basic-shadows-expected.png:
- platform/chromium-mac-lion/fast/box-shadow/box-shadow-transformed-expected.png:
- platform/chromium-mac-lion/fast/box-shadow/inset-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/select-text-overflow-ellipsis-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
- platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/border-radius-split-inline-expected.png:
- platform/chromium-mac-snowleopard/fast/box-shadow/basic-shadows-expected.png:
- platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-transformed-expected.png:
- platform/chromium-mac/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
- platform/chromium-mac/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
- platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
- platform/chromium-mac/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
- platform/chromium-mac/editing/selection/select-text-overflow-ellipsis-expected.png:
- platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.png:
- platform/chromium-mac/fast/borders/border-antialiasing-expected.png:
- platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png:
- platform/chromium-mac/fast/borders/border-radius-with-box-shadow-01-expected.png:
- platform/chromium-mac/fast/borders/border-radius-with-box-shadow-expected.png:
- platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
- platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png:
- platform/chromium-mac/fast/box-shadow/box-shadow-radius-expected.png:
- platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png:
- platform/chromium-mac/fast/box-shadow/inset-box-shadow-radius-expected.png:
- platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
- platform/chromium-mac/fast/box-shadow/inset-expected.png:
- platform/chromium-mac/fast/box-shadow/scaled-box-shadow-expected.png:
- platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png:
- platform/chromium-mac/fast/box-shadow/shadow-tiling-artifact-expected.png:
- platform/chromium-mac/fast/box-shadow/single-pixel-shadow-expected.png:
- platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
- platform/chromium-win/fast/borders/border-radius-with-box-shadow-01-expected.png:
- platform/chromium-win/fast/borders/border-radius-with-box-shadow-expected.png:
- platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
- platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
- platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
- platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png:
- platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png:
- platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
- platform/chromium-win/fast/box-shadow/inset-expected.png:
- platform/chromium-win/fast/box-shadow/scaled-box-shadow-expected.png:
- platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
- platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.png:
- platform/chromium-win/fast/box-shadow/single-pixel-shadow-expected.png:
- platform/chromium/TestExpectations:
- platform/efl-wk2/fast/borders/border-radius-split-inline-expected.png: Added.
- platform/efl-wk2/fast/box-shadow/basic-shadows-expected.png: Added.
- platform/efl-wk2/fast/box-shadow/box-shadow-transformed-expected.png: Added.
- platform/efl-wk2/fast/box-shadow/inset-expected.png: Added.
- platform/efl-wk2/fast/box-shadow/scaled-box-shadow-expected.png: Added.
- platform/efl/fast/borders/border-radius-split-inline-expected.png: Removed.
- platform/efl/fast/box-shadow/basic-shadows-expected.png: Removed.
- platform/efl/fast/box-shadow/box-shadow-transformed-expected.png: Removed.
- platform/efl/fast/box-shadow/inset-expected.png: Removed.
- platform/efl/fast/box-shadow/scaled-box-shadow-expected.png: Removed.
- 6:09 PM Changeset in webkit [146698] by
-
- 3 edits in trunk/Source/JavaScriptCore
Another build fix (after r146693) for r146682.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 6:07 PM Changeset in webkit [146697] by
-
- 4 edits4 adds in trunk
[CSS Grid Layout] content-sized row tracks with percentage logical height grid items don't resolve properly
https://bugs.webkit.org/show_bug.cgi?id=113085
Reviewed by Tony Chang.
Source/WebCore:
The core issue is that because overrideContainingBlockLogicalHeight() is unset in
logicalContentHeightForChild, RenderBox::computePercentageLogicalHeight would try to
resolve percentage logical height against the grid element (wrong containing block
as a grid item's containing block is the grid area).
Tests: fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html
fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::logicalContentHeightForChild):
Set our override logical height to -1, so that we don't try to constrain a grid item's logical height
based on resolving (badly) its percentage.
LayoutTests:
- fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution-expected.txt:
Updated the result to pass.
- fast/css-grid-layout/grid-item-multiple-minmax-content-resolution-expected.txt: Added.
- fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html: Added.
- fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution-expected.txt: Added.
- fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html: Added.
Added more testing to ensure that we properly do the resolution.
- 6:03 PM Changeset in webkit [146696] by
-
- 65 edits2 adds1 delete in trunk/LayoutTests
[Chromium] Test expectations after Skia changes
Unreviewed expectations update.
fast/canvas/...
fast/css/...
fast/forms/...
fast/multicol/...
- platform/chromium-linux/fast/canvas/canvas-incremental-repaint-expected.png:
- platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png:
- platform/chromium-linux/fast/css/color-correction-on-box-shadow-expected.png:
- platform/chromium-linux/fast/css/color-correction-on-text-shadow-expected.png:
- platform/chromium-linux/fast/css/font-family-pictograph-expected.png:
- platform/chromium-linux/fast/css/font-family-pictograph-expected.txt:
- platform/chromium-linux/fast/css/shadow-multiple-expected.png:
- platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
- platform/chromium-mac-lion/fast/canvas/canvas-incremental-repaint-expected.png:
- platform/chromium-mac-lion/fast/css/color-correction-on-box-shadow-expected.png:
- platform/chromium-mac-lion/fast/css/color-correction-on-text-shadow-expected.png:
- platform/chromium-mac-lion/fast/css/empty-pseudo-class-expected.png:
- platform/chromium-mac-lion/fast/css/first-child-pseudo-class-expected.png:
- platform/chromium-mac-lion/fast/css/first-of-type-pseudo-class-expected.png:
- platform/chromium-mac-lion/fast/css/last-child-pseudo-class-expected.png:
- platform/chromium-mac-lion/fast/css/last-of-type-pseudo-class-expected.png:
- platform/chromium-mac-lion/fast/css/only-child-pseudo-class-expected.png:
- platform/chromium-mac-lion/fast/css/only-of-type-pseudo-class-expected.png:
- platform/chromium-mac-lion/fast/css/shadow-multiple-expected.png:
- platform/chromium-mac-lion/fast/dynamic/text-combine-expected.png:
- platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-mac-lion/fast/line-grid/line-grid-contains-value-expected.png:
- platform/chromium-mac-lion/fast/multicol/nested-columns-expected.png:
- platform/chromium-mac-lion/fast/multicol/shadow-breaking-expected.png:
- platform/chromium-mac-snowleopard/fast/css/color-correction-on-box-shadow-expected.png:
- platform/chromium-mac-snowleopard/fast/css/color-correction-on-text-shadow-expected.png:
- platform/chromium-mac-snowleopard/fast/css/empty-pseudo-class-expected.png:
- platform/chromium-mac-snowleopard/fast/css/first-child-pseudo-class-expected.png:
- platform/chromium-mac-snowleopard/fast/css/first-of-type-pseudo-class-expected.png:
- platform/chromium-mac-snowleopard/fast/css/last-child-pseudo-class-expected.png:
- platform/chromium-mac-snowleopard/fast/css/last-of-type-pseudo-class-expected.png:
- platform/chromium-mac-snowleopard/fast/css/only-child-pseudo-class-expected.png:
- platform/chromium-mac-snowleopard/fast/css/only-of-type-pseudo-class-expected.png:
- platform/chromium-mac-snowleopard/fast/css/shadow-multiple-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-mac-snowleopard/fast/line-grid/line-grid-contains-value-expected.png:
- platform/chromium-mac-snowleopard/fast/multicol/nested-columns-expected.png:
- platform/chromium-mac-snowleopard/fast/multicol/shadow-breaking-expected.png:
- platform/chromium-mac/fast/canvas/canvas-incremental-repaint-expected.png:
- platform/chromium-mac/fast/css/box-shadow-and-border-radius-expected.png:
- platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.png:
- platform/chromium-mac/fast/css/color-correction-on-text-shadow-expected.png:
- platform/chromium-mac/fast/css/empty-pseudo-class-expected.png:
- platform/chromium-mac/fast/css/first-child-pseudo-class-expected.png:
- platform/chromium-mac/fast/css/first-of-type-pseudo-class-expected.png:
- platform/chromium-mac/fast/css/last-child-pseudo-class-expected.png:
- platform/chromium-mac/fast/css/last-of-type-pseudo-class-expected.png:
- platform/chromium-mac/fast/css/only-child-pseudo-class-expected.png:
- platform/chromium-mac/fast/css/only-of-type-pseudo-class-expected.png:
- platform/chromium-mac/fast/css/shadow-multiple-expected.png:
- platform/chromium-mac/fast/dynamic/text-combine-expected.png:
- platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-mac/fast/line-grid/line-grid-contains-value-expected.png:
- platform/chromium-mac/fast/multicol/nested-columns-expected.png:
- platform/chromium-mac/fast/multicol/shadow-breaking-expected.png:
- platform/chromium-win/fast/canvas/canvas-incremental-repaint-expected.png:
- platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png:
- platform/chromium-win/fast/css/color-correction-on-box-shadow-expected.png:
- platform/chromium-win/fast/css/color-correction-on-text-shadow-expected.png:
- platform/chromium-win/fast/css/shadow-multiple-expected.png:
- platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
- platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
- platform/chromium/TestExpectations:
- platform/efl-wk2/fast/multicol: Added.
- platform/efl-wk2/fast/multicol/shadow-breaking-expected.png: Added.
- platform/efl/fast/multicol/shadow-breaking-expected.png: Removed.
- 5:52 PM Changeset in webkit [146695] by
-
- 44 edits9 adds17 deletes in trunk/LayoutTests
[Chromium] Test expectations after Skia changes
Unreviewed expectations update.
fast/repaint/...
fast/ruby/...
- fast/repaint/moving-shadow-on-container-expected.png: Added.
- fast/repaint/search-field-cancel-expected.txt: Added.
- platform/chromium-linux-x86/fast/repaint/moving-shadow-on-container-expected.png: Removed.
- platform/chromium-linux/fast/repaint/box-shadow-h-expected.png:
- platform/chromium-linux/fast/repaint/box-shadow-v-expected.png:
- platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.png:
- platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.png:
- platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.png:
- platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
- platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.png:
- platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-mac-lion/fast/repaint/box-shadow-h-expected.png:
- platform/chromium-mac-lion/fast/repaint/box-shadow-v-expected.png:
- platform/chromium-mac-lion/fast/repaint/moving-shadow-on-container-expected.png:
- platform/chromium-mac-lion/fast/repaint/moving-shadow-on-path-expected.png:
- platform/chromium-mac-lion/fast/repaint/scale-page-shrink-expected.png: Added.
- platform/chromium-mac-lion/fast/repaint/search-field-cancel-expected.png: Added.
- platform/chromium-mac-lion/fast/repaint/shadow-multiple-horizontal-expected.png:
- platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
- platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-vertical-expected.png:
- platform/chromium-mac-lion/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/box-shadow-h-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/box-shadow-v-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-container-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/scale-page-shrink-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.png:
- platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/ruby/base-shorter-than-text-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/ruby/base-shorter-than-text-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/ruby/position-after-expected.png:
- platform/chromium-mac/fast/repaint/box-shadow-h-expected.png:
- platform/chromium-mac/fast/repaint/box-shadow-v-expected.png:
- platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.png:
- platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png:
- platform/chromium-mac/fast/repaint/scale-page-shrink-expected.png: Added.
- platform/chromium-mac/fast/repaint/search-field-cancel-expected.png: Added.
- platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
- platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
- platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
- platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-mac/fast/repaint/transform-replaced-shadows-expected.png:
- platform/chromium-mac/fast/ruby/position-after-expected.png:
- platform/chromium-win-xp/fast/repaint/box-shadow-h-expected.png: Removed.
- platform/chromium-win-xp/fast/repaint/box-shadow-v-expected.png: Removed.
- platform/chromium-win-xp/fast/repaint/moving-shadow-on-container-expected.png: Removed.
- platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.txt: Removed.
- platform/chromium-win/fast/repaint/box-shadow-h-expected.png:
- platform/chromium-win/fast/repaint/box-shadow-v-expected.png:
- platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.png:
- platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
- platform/chromium-win/fast/repaint/search-field-cancel-expected.png:
- platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
- platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
- platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
- platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
- platform/chromium-win/fast/repaint/transform-replaced-shadows-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/fast/repaint/search-field-cancel-expected.png: Removed.
- platform/chromium/fast/repaint/search-field-cancel-expected.txt: Removed.
- platform/efl-wk2/fast/repaint/moving-shadow-on-container-expected.png: Added.
- platform/efl-wk2/fast/repaint/moving-shadow-on-path-expected.png: Added.
- platform/efl-wk2/fast/repaint/transform-replaced-shadows-expected.png: Added.
- platform/efl/fast/repaint/moving-shadow-on-container-expected.png: Removed.
- platform/efl/fast/repaint/moving-shadow-on-path-expected.png: Removed.
- platform/efl/fast/repaint/transform-replaced-shadows-expected.png: Removed.
- platform/gtk/fast/repaint/moving-shadow-on-container-expected.png: Removed.
- platform/mac/fast/repaint/moving-shadow-on-container-expected.png: Removed.
- platform/mac/fast/repaint/search-field-cancel-expected.txt: Removed.
- 5:45 PM Changeset in webkit [146694] by
-
- 7 edits in trunk/Source/WebCore
Check WEBGL_draw_buffers requirements before exposing the extension
https://bugs.webkit.org/show_bug.cgi?id=112359
Reviewed by Kenneth Russell.
- html/canvas/EXTDrawBuffers.cpp:
(WebCore::EXTDrawBuffers::supported): call satisfies*().
(WebCore::EXTDrawBuffers::drawBuffersEXT):
(WebCore):
(WebCore::EXTDrawBuffers::satisfiesWebGLRequirements): check WebGL requirements.
- html/canvas/EXTDrawBuffers.h:
(EXTDrawBuffers):
- html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::getDrawBuffer):
(WebCore):
- html/canvas/WebGLFramebuffer.h:
(WebGLFramebuffer):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateFramebufferFuncParameters):
(WebCore::WebGLRenderingContext::getMaxDrawBuffers):
(WebCore::WebGLRenderingContext::getMaxColorAttachments):
(WebCore::WebGLRenderingContext::setBackDrawBuffer):
(WebCore::WebGLRenderingContext::restoreCurrentFramebuffer):
(WebCore::WebGLRenderingContext::restoreCurrentTexture2D):
(WebCore::WebGLRenderingContext::supportsDrawBuffers): a cached version of EXTDrawBuffers::supports()
- html/canvas/WebGLRenderingContext.h:
(WebGLRenderingContext):
- 5:44 PM Changeset in webkit [146693] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed. AppleWin build fix.
- JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
- JavaScriptCore.vcxproj/copy-files.cmd:
- 5:37 PM Changeset in webkit [146692] by
-
- 41 edits6 adds3 deletes in trunk/LayoutTests
[Chromium] Test expectations after Skia changes
Unreviewed expectations update.
fast/text/...
- platform/chromium-linux/fast/text/emphasis-avoid-ruby-expected.png: Added.
- platform/chromium-linux/fast/text/shadow-translucent-fill-expected.png:
- platform/chromium-linux/fast/text/stroking-decorations-expected.png:
- platform/chromium-linux/fast/text/stroking-expected.png:
- platform/chromium-linux/fast/transforms/shadows-expected.png:
- platform/chromium-mac-lion/fast/text/decorations-with-text-combine-expected.png:
- platform/chromium-mac-lion/fast/text/international/bold-bengali-expected.png:
- platform/chromium-mac-lion/fast/text/international/text-spliced-font-expected.png:
- platform/chromium-mac-lion/fast/text/international/vertical-text-glyph-test-expected.png:
- platform/chromium-mac-lion/fast/text/justify-ideograph-vertical-expected.png:
- platform/chromium-mac-lion/fast/text/orientation-sideways-expected.png:
- platform/chromium-mac-lion/fast/text/shadow-translucent-fill-expected.png:
- platform/chromium-mac-lion/fast/text/stroking-decorations-expected.png:
- platform/chromium-mac-lion/fast/text/stroking-expected.png:
- platform/chromium-mac-lion/fast/text/whitespace/024-expected.png:
- platform/chromium-mac-lion/fast/transforms/shadows-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-001-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-002-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-003-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/bold-bengali-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/text-spliced-font-expected.png:
- platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.png:
- platform/chromium-mac-snowleopard/fast/text/justify-ideograph-vertical-expected.png:
- platform/chromium-mac-snowleopard/fast/text/shadow-translucent-fill-expected.png:
- platform/chromium-mac-snowleopard/fast/text/whitespace/024-expected.png:
- platform/chromium-mac/fast/text/decorations-with-text-combine-expected.png:
- platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.png:
- platform/chromium-mac/fast/text/shadow-translucent-fill-expected.png:
- platform/chromium-mac/fast/text/stroking-decorations-expected.png:
- platform/chromium-mac/fast/text/stroking-expected.png:
- platform/chromium-mac/fast/text/whitespace/024-expected.png:
- platform/chromium-mac/fast/transforms/shadows-expected.png:
- platform/chromium-win-xp/fast/text/stroking-decorations-expected.png:
- platform/chromium-win-xp/fast/text/stroking-expected.png:
- platform/chromium-win/fast/text/international/bold-bengali-expected.png:
- platform/chromium-win/fast/text/international/bold-bengali-expected.txt:
- platform/chromium-win/fast/text/shadow-translucent-fill-expected.png:
- platform/chromium-win/fast/text/stroking-decorations-expected.png:
- platform/chromium-win/fast/text/stroking-expected.png:
- platform/chromium-win/fast/transforms/shadows-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/fast/text/international/bold-bengali-expected.png: Removed.
- platform/efl-wk2/fast/text/shadow-translucent-fill-expected.png: Added.
- platform/efl/fast/text/shadow-translucent-fill-expected.png: Removed.
- platform/qt-unknown/fast: Added.
- platform/qt-unknown/fast/text: Added.
- platform/qt-unknown/fast/text/international: Added.
- platform/qt-unknown/fast/text/international/text-spliced-font-expected.png: Added.
- platform/qt/fast/text/international/text-spliced-font-expected.png: Removed.
- 5:31 PM Changeset in webkit [146691] by
-
- 6 edits in trunk/Tools
EWS should use a human readable port name when uploading layout test archives
https://bugs.webkit.org/show_bug.cgi?id=113099
Reviewed by Dirk Pranke.
Use new port's object's name() method to report human readable port names.
This will also help us resolving the bug to apply layout test results posted by EWS.
- Scripts/webkitpy/tool/bot/botinfo.py:
(BotInfo.init): Take port's name.
(BotInfo.summary_text):
- Scripts/webkitpy/tool/bot/botinfo_unittest.py:
(BotInfoTest.test_summary_text):
- Scripts/webkitpy/tool/bot/flakytestreporter.py:
(FlakyTestReporter.init): Preserve the old behavior since we don't have a real port object here.
- Scripts/webkitpy/tool/commands/queues.py:
(PatchProcessingQueue.init): Initialize self._port.
(PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
and use that for the attachment filename and the comment posted.
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
"mac-snowleopard" as expected for TestPort.
- 5:26 PM Changeset in webkit [146690] by
-
- 4 edits in trunk/LayoutTests
[Chromium] Test expectations after Skia changes
Unreviewed expectations update.
One I missed.
- platform/chromium-mac-lion/svg/custom/preserve-aspect-ratio-syntax-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/preserve-aspect-ratio-syntax-expected.png:
- platform/chromium-mac/svg/custom/preserve-aspect-ratio-syntax-expected.png:
- 5:24 PM Changeset in webkit [146689] by
-
- 2 edits in trunk/Tools
Unreviewed. Fix AppleWin port following https://bugs.webkit.org/show_bug.cgi?id=113100.
Patch by Alexey Proskuryakov.
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
- 5:21 PM Changeset in webkit [146688] by
-
- 2 edits in trunk/Source/JavaScriptCore
-[TinyDOMNode dealloc] should call [super dealloc] when ARC is not enabled
https://bugs.webkit.org/show_bug.cgi?id=113054
Reviewed by Geoffrey Garen.
- API/tests/testapi.mm:
(-[TinyDOMNode dealloc]):
- 5:14 PM Changeset in webkit [146687] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix AppleWin port following https://bugs.webkit.org/show_bug.cgi?id=113100.
Patch by Alexey Proskuryakov.
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
- 5:10 PM Changeset in webkit [146686] by
-
- 2 edits in trunk/Source/WebKit/gtk
Trivial fixes to the gyp-build autogen.sh script.
Reviewed by Martin Robinson (mrobinson).
- gyp/autogen.sh: add /bin/sh -e as hashbang, so stricter shells will be happy to
run the script; deal with automake exiting with an error code because there is no
Makefile.am for it to work on.
- 5:00 PM Changeset in webkit [146685] by
-
- 1 edit2 adds in trunk/LayoutTests
Plugin Snapshotting: Auto-start dominant plugins
https://bugs.webkit.org/show_bug.cgi?id=113111
<rdar://problem/13475726>
Reviewed by Dean Jackson.
Add a test for http://trac.webkit.org/changeset/146679.
- platform/mac-wk2/plugins/snapshotting/autoplay-dominant-expected.txt: Added.
- plugins/snapshotting/autoplay-dominant.html: Added.
- 4:58 PM Changeset in webkit [146684] by
-
- 3 edits2 adds in trunk
REGRESSION (r146272): layout issues for flex boxes that have -webkit-flex-wrap: wrap
https://bugs.webkit.org/show_bug.cgi?id=113071
Reviewed by Ojan Vafai.
Source/WebCore:
The refactor in r139535 introduced this bug, where a variable name wasn't updated properly.
In combination with r146272, this bug became more visible when nesting multiline flexboxen.
Test: css3/flexbox/multiline-min-preferred-width.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths): We want the width of the widest
flexitem, the value in m_minPreferredWidth isn't relevant. Also update the comment for max
preferred width.
LayoutTests:
- css3/flexbox/multiline-min-preferred-width-expected.txt: Added.
- css3/flexbox/multiline-min-preferred-width.html: Added.
- 4:56 PM Changeset in webkit [146683] by
-
- 3 edits4 adds in trunk
[CSS Shaders] Clamp css_MixColor before the blending and compositing steps
https://bugs.webkit.org/show_bug.cgi?id=113088
Reviewed by Dean Jackson.
Source/WebCore:
The blending and compositing operations from the spec [1] expect that they are operating on
valid color inputs, in the range [0.0, 1.0]. Thus, we should clamp the css_MixColor input to
this range to avoid implementation-dependent behavior for invalid color inputs.
[1]: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blending
Tests: css3/filters/custom/custom-filter-clamp-css-mix-color-negative.html
css3/filters/custom/custom-filter-clamp-css-mix-color.html
- platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::rewriteMixFragmentShader):
Clamp css_MixColor as clampedMixColor before using it in the blending and compositing
steps.
LayoutTests:
- css3/filters/custom/custom-filter-clamp-css-mix-color-expected.html: Added.
- css3/filters/custom/custom-filter-clamp-css-mix-color-negative-expected.html: Added.
- css3/filters/custom/custom-filter-clamp-css-mix-color-negative.html: Added.
- css3/filters/custom/custom-filter-clamp-css-mix-color.html: Added.
- 4:49 PM Changeset in webkit [146682] by
-
- 10 edits in trunk/Source/JavaScriptCore
opaqueJSClassData should be cached on JSGlobalObject, not the JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=113086
Reviewed by Geoffrey Garen.
opaqueJSClassData stores cached prototypes for JSClassRefs in the C API. It doesn't make sense to
share these prototypes within a JSGlobalData across JSGlobalObjects, and in fact doing so will cause
a leak of the original JSGlobalObject that these prototypes were created in. Therefore we should move
this cache to JSGlobalObject where it belongs and where it won't cause memory leaks.
- API/JSBase.cpp: Needed to add an extern "C" so that testapi.c can use the super secret GC function.
- API/JSClassRef.cpp: We now grab the cached context data from the global object rather than the global data.
(OpaqueJSClass::contextData):
- API/JSClassRef.h: Remove this header because it's unnecessary and causes circular dependencies.
- API/tests/testapi.c: Added a new test that makes sure that using the same JSClassRef in two different contexts
doesn't cause leaks of the original global object.
(leakFinalize):
(nestedAllocateObject): This is a hack to bypass the conservative scan of the GC, which was unnecessarily marking
objects and keeping them alive, ruining the test result.
(testLeakingPrototypesAcrossContexts):
(main):
- API/tests/testapi.mm: extern "C" this so we can continue using it here.
- runtime/JSGlobalData.cpp: Remove JSClassRef related stuff.
(JSC::JSGlobalData::~JSGlobalData):
- runtime/JSGlobalData.h:
(JSGlobalData):
- runtime/JSGlobalObject.h: Add the stuff that JSGlobalData had. We add it to JSGlobalObjectRareData so that
clients who don't use the C API don't have to pay the memory cost of this extra HashMap.
(JSGlobalObject):
(JSGlobalObjectRareData):
(JSC::JSGlobalObject::opaqueJSClassData):
- 4:48 PM Changeset in webkit [146681] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Add WebCoreDOM to the gyp build
https://bugs.webkit.org/show_bug.cgi?id=112737
Reviewed by Nico Weber.
- WebCore.gyp/WebCoreGTK.gyp: Add WebCoreDOM to the gyp build.
- 4:47 PM Changeset in webkit [146680] by
-
- 3 edits in trunk/Source
[GTK] Add WebCoreHTML to the gyp build
https://bugs.webkit.org/show_bug.cgi?id=112727
Reviewed by Nico Weber.
- WebCore.gyp/WebCoreGTK.gyp: Add support for building all files under
the HTML directory. This includes splitting off common WebCore dependencies
into an aggregate target and adding a top-level WebCore target.
- 4:43 PM Changeset in webkit [146679] by
-
- 8 edits in trunk/Source
Plugin Snapshotting: Auto-start dominant plugins
https://bugs.webkit.org/show_bug.cgi?id=113111
<rdar://problem/13475726>
Reviewed by Dean Jackson.
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler):
Acknowledge the new "Restarting" DisplayState.
- html/HTMLPlugInElement.h:
Rename PlayingWithPendingMouseClick to RestartingWithPendingMouseClick for accuracy.
Add "Restarting" DisplayState, so we can be aware that the plugin is intentionally restarting and not re-snapshot it.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Remove m_isPrimarySnapshottedPlugIn.
(WebCore::classNameForShadowRoot): Remove m_isPrimarySnapshottedPlugIn.
(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Restart the plugin when it becomes primary.
(WebCore::HTMLPlugInImageElement::updateSnapshotInfo): Remove m_isPrimarySnapshottedPlugIn.
(WebCore::HTMLPlugInImageElement::restartSnapshottedPlugIn):
Move the plugin to Restarting unless it's already marked as PendingMouseClick.
(WebCore::HTMLPlugInImageElement::simulatedMouseClickTimerFired): Match the PlayingWithPendingMouseClick rename.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Don't snapshot if we're restarting.
- html/HTMLPlugInImageElement.h: Remove m_isPrimarySnapshottedPlugIn.
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::paint): Acknowledge the new "Restarting" DisplayState.
(WebCore::RenderSnapshottedPlugIn::getCursor): Acknowledge the new "Restarting" DisplayState.
(WebCore::RenderSnapshottedPlugIn::handleEvent): Match the PlayingWithPendingMouseClick rename.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::didInitializePlugin):
(WebKit::PluginView::paint):
(WebKit::PluginView::invalidateRect):
(WebKit::PluginView::isAcceleratedCompositingEnabled):
Acknowledge the new "Restarting" DisplayState.
- 4:43 PM Changeset in webkit [146678] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark test as expected to timeout.
https://bugs.webkit.org/show_bug.cgi?id=113114
Unreviewed, test expectations update.
- platform/chromium/TestExpectations:
- 4:40 PM Changeset in webkit [146677] by
-
- 8 edits2 copies in trunk/Source
[GTK] Add support for building the WebCore bindings to the gyp build
https://bugs.webkit.org/show_bug.cgi?id=112638
Reviewed by Nico Weber.
Source/JavaScriptCore:
- JavaScriptCore.gyp/JavaScriptCoreGTK.gyp: Export all include directories to direct
dependents and fix the indentation of the libjavascriptcore target.
Source/WebCore:
Add targets, actions, and rules for building the WebCore bindings. This is
the first part of the WebCoreGTK build.
- WebCore.gyp/ConvertFileToHeaderWithCharacterArray.gypi: Added.
- WebCore.gyp/MakeNames.gypi: Added.
- WebCore.gyp/WebCoreGTK.gyp: Added WebCore bindings build. This has been adapted
from the Chromium build.
- WebCore.gypi: Updated list of derived sources files and added a parameter
for adjusting the location of the built files. We don't want to force the
Mac build to change, but we'd still like to reuse the scripts that the
Chromium build uses.
Source/WebKit/gtk:
- gyp/Configuration.gypi.in: Added options for enabling SVG and setting the location of
the WebCore derived sources.
- gyp/run-gyp: Include the gyp scripts directory on the Python path and make the WebCoreGTK
gyp file the default for the build.
- 4:29 PM Changeset in webkit [146676] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] [gyp] Expose a few more compiler defines for the gyp build
https://bugs.webkit.org/show_bug.cgi?id=113109
Reviewed by Gustavo Noronha Silva.
- gyp/Configuration.gypi.in: Expose the version number string and data
directory to the gyp build as command-line arguments.
- 4:28 PM Changeset in webkit [146675] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] [gyp] Feature defines are not space separated
https://bugs.webkit.org/show_bug.cgi?id=113108
Reviewed by Gustavo Noronha Silva.
- gyp/configure.ac: Properly export feature defines for gyp during
configure phase.
- 4:23 PM Changeset in webkit [146674] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Build fix in InputHandler
https://bugs.webkit.org/show_bug.cgi?id=113092
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-03-22
Reviewed by Rob Buis.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
- 4:12 PM Changeset in webkit [146673] by
-
- 2 edits in trunk/Source/WebKit2
After switching to another space and back, video races to catch up with audio
https://bugs.webkit.org/show_bug.cgi?id=113006
Reviewed by Anders Carlsson.
Add an observer for the NSWorkspaceActiveSpaceDidChangeNotification notification, and trigger
a visibility update when that notification is observed.
- UIProcess/API/mac/WKView.mm:
(-[WKView dealloc]): Unregister the observer.
(-[WKView _activeSpaceDidChange:]): Notify the view that its visibility may have changed.
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]): Add the observer.
- 4:11 PM Changeset in webkit [146672] by
-
- 11 edits in trunk/Source
Add client callbacks to notify of changes of associated from controls
https://bugs.webkit.org/show_bug.cgi?id=110375
Patch by Dane Wallinga <dgwallinga@chromium.org> on 2013-03-22
Reviewed by Ryosuke Niwa.
Source/WebCore:
Hook FormAssociatedElement, HTMLFormElement to notify EditorClient of form changes after a page has loaded.
Will be used to add autofill support for ajax-y webpages. e.g if while filling out a form, new fields
are dynamically created, autofill can know to re-query the autofill server and keep going.
https://bugs.webkit.org/show_bug.cgi?id=110375
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::didAssociateFormControl):
(WebCore):
(WebCore::Document::didAssociateFormControlsTimerFired):
- dom/Document.h:
(Document):
added method didAssociateFormControl, which batches form changes
and calls out to ChromeClient on a timer.
- html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::resetFormOwner):
(WebCore::FormAssociatedElement::formAttributeChanged):
(WebCore):
- html/FormAssociatedElement.h:
(FormAssociatedElement):
add calls to Document::didAssociateFormControl when form changes
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::insertedInto):
(WebCore):
- html/HTMLFormElement.h:
add call to Document::didAssociateFormControl
- loader/EmptyClients.h:
(EmptyChromeClient):
(WebCore::EmptyChromeClient::didAssociateFormControls):
(WebCore::EmptyChromeClient::shouldNotifyOnFormChanges):
- page/ChromeClient.h:
(ChromeClient):
add new method didAssociateFormControls
Source/WebKit/chromium:
Implement form association methods of ChromeClient
to inform autofill of form changes after a page has loaded
- public/WebAutofillClient.h:
(WebAutofillClient):
(WebKit::WebAutofillClient::didAssociateInput):
(WebKit::WebAutofillClient::didAddForm):
(WebKit::WebAutofillClient::didAssociateFormControls):
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::didAssociateFormControls):
(WebKit):
(WebKit::ChromeClientImpl::shouldNotifyOnFormChanges):
- src/ChromeClientImpl.h:
(ChromeClientImpl):
- 4:04 PM Changeset in webkit [146671] by
-
- 3 edits in branches/chromium/1410/Source/WebCore
Merge 145856 "Check to ensure MultisampleRenderbuffer creation s..."
Check to ensure MultisampleRenderbuffer creation succeeds
https://bugs.webkit.org/show_bug.cgi?id=111780
Patch by Brandon Jones <bajones@google.com> on 2013-03-14
Reviewed by Kenneth Russell.
On OSX systems using AMD graphics chips the allocation of large
Multisample Renderbuffers in Chromium would fail without any indication
of failure. Attempting to draw to the buffer resulted in garbage being
rendered onscreen. This could be reproduced by opening a full-page
WebGL app and pressing (Command + "-") several times. This patch adds an
additional check during DrawingBuffer resize to verify that the resized
buffer is valid.
- platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore):
(WebCore::DrawingBuffer::checkBufferIntegrity):
(WebCore::DrawingBuffer::reset):
- platform/graphics/gpu/DrawingBuffer.h:
(DrawingBuffer):
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12843018
- 4:02 PM Changeset in webkit [146670] by
-
- 139 edits14 adds11 deletes in trunk/LayoutTests
[Chromium] Test expectations after Skia changes
Unreviewed expectations update.
The next round.
Too many files to list, plus ...
- platform/chromium/TestExpectations:
- 4:00 PM Changeset in webkit [146669] by
-
- 11 edits in trunk/Source/JavaScriptCore
Fix some minor issues in the DFG's profiling of heap accesses
https://bugs.webkit.org/show_bug.cgi?id=113010
Reviewed by Goeffrey Garen.
1) If a CodeBlock gets jettisoned by GC, we should count the exit sites.
2) If a CodeBlock clears a structure stub during GC, it should record this, and
the DFG should prefer to not inline that access (i.e. treat it as if it had an
exit site).
3) If a PutById was seen by the baseline JIT, and the JIT attempted to cache it,
but it chose not to, then assume that it will take slow path.
4) If we frequently exited because of a structure check on a weak constant,
don't try to inline that access in the future.
5) Treat all exits that were counted as being frequent.
81% speed-up on Octane/gbemu. Small speed-ups elsewhere, and no regressions.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finalizeUnconditionally):
(JSC):
(JSC::CodeBlock::resetStubDuringGCInternal):
(JSC::CodeBlock::reoptimize):
(JSC::CodeBlock::jettison):
(JSC::ProgramCodeBlock::jettisonImpl):
(JSC::EvalCodeBlock::jettisonImpl):
(JSC::FunctionCodeBlock::jettisonImpl):
(JSC::CodeBlock::tallyFrequentExitSites):
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::tallyFrequentExitSites):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::StructureStubInfo):
(StructureStubInfo):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):
- dfg/DFGOSRExit.h:
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSite):
(OSRExit):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/Options.h:
(JSC):
- 3:49 PM Changeset in webkit [146668] by
-
- 2 edits in trunk/Source/WTF
Name correctly the argument of StringImpl::setIsAtomic()
https://bugs.webkit.org/show_bug.cgi?id=113000
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-22
Reviewed by Geoffrey Garen.
- wtf/text/StringImpl.h:
(WTF::StringImpl::setIsAtomic):
The argument was probably an unfortunate copy-paste from setIsIdentifier().
Fix the name.
- 3:44 PM Changeset in webkit [146667] by
-
- 7 edits5 adds in trunk/Source/WebCore
Split ResourceHandleMac into multiple files
https://bugs.webkit.org/show_bug.cgi?id=113100
Reviewed by Geoff Garen.
It's grown too big to navigate, and I'm going to make WebCoreResourceHandleAsDelegate
substantially more complicated yet.
- Mechanically moved WebCoreResourceHandleAsDelegate into separate files.
- Refactored WebCoreSynchronousLoaderClient to be cross-platform, and moved it into separate files.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/network/SynchronousLoaderClient.cpp: Added.
- platform/network/SynchronousLoaderClient.h: Added.
- platform/network/cf/ResourceHandleCFNet.cpp:
- platform/network/mac/SynchronousLoaderClient.mm: Added.
- platform/network/mac/WebCoreResourceHandleAsDelegate.h: Added.
- platform/network/mac/WebCoreResourceHandleAsDelegate.mm: Added.
- 3:38 PM Changeset in webkit [146666] by
-
- 491 edits17 adds13 deletes in trunk/LayoutTests
[Chromium] Test expectation after Skia changes
Unreviewed expectations update.
SVG and Compositing tests
Too many files to list, plus ...
- platform/chromium/TestExpectations:
- 3:24 PM Changeset in webkit [146665] by
-
- 2 edits in trunk/LayoutTests
Fix the expected image result as r78910 committed a bad expected result.
See http://trac.webkit.org/changeset/78910/trunk/LayoutTests/platform/mac/editing/deleting/deletionUI-single-instance-expected.png
- platform/mac/editing/deleting/deletionUI-single-instance-expected.png:
- 3:19 PM Changeset in webkit [146664] by
-
- 10 edits in trunk/Source
Added a setting for whether JavaScript markup is enabled
https://bugs.webkit.org/show_bug.cgi?id=112999
Reviewed by Maciej Stachowiak.
This setting is useful for clients that want protection from script
injection attacks.
../WebCore:
- page/Settings.h:
(Settings): Clarified which clients should call canExecuteScripts().
- page/Settings.in: Added the new setting.
../WebKit2:
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesGetJavaScriptMarkupEnabled):
(WKPreferencesSetJavaScriptMarkupEnabled):
(WKPreferencesGetJavaScriptEnabled):
- UIProcess/API/C/WKPreferences.h:
- UIProcess/API/mac/WKBrowsingContextGroup.mm:
(-[WKBrowsingContextGroup allowsJavaScriptMarkup]):
(-[WKBrowsingContextGroup setAllowsJavaScriptMarkup:]):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Plumbed through to API.
- 3:19 PM Changeset in webkit [146663] by
-
- 2 edits in trunk/LayoutTests
Add a failing test expectation to media/track/track-prefer-captions.html on Windows after r146647.
The failure is tracked by the bug 113106.
- platform/win/TestExpectations:
- 3:06 PM Changeset in webkit [146662] by
-
- 2 edits in trunk/LayoutTests
[Win] editing/pasteboard/can-read-in-copy-and-cut-events.html fails
https://bugs.webkit.org/show_bug.cgi?id=113102
Skip a test added by r146644 since writing into clipboard is not supported on Windows port.
- platform/win/TestExpectations:
- 3:04 PM Changeset in webkit [146661] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix.
- bindings/scripts/preprocessor.pm:
(applyPreprocessor):
- 3:03 PM Changeset in webkit [146660] by
-
- 2 edits8 adds in trunk/LayoutTests
Update svg/custom/marker-orient-auto expectations
Unreviewed update of test expectations.
- platform/chromium-mac-lion/svg/custom/marker-orient-auto-expected.png: Added.
- platform/chromium-mac-lion/svg/custom/marker-orient-auto-expected.txt: Added.
- platform/chromium-mac-snowleopard/svg/custom/marker-orient-auto-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/marker-orient-auto-expected.txt: Added.
- platform/chromium-mac/svg/custom/marker-orient-auto-expected.png: Added.
- platform/chromium-mac/svg/custom/marker-orient-auto-expected.txt: Added.
- platform/chromium-win/svg/custom/marker-orient-auto-expected.png: Added.
- platform/chromium-win/svg/custom/marker-orient-auto-expected.txt: Added.
- platform/chromium/TestExpectations:
- 2:14 PM Changeset in webkit [146659] by
-
- 2 edits in trunk/LayoutTests
Add failing test expectations for two more position: sticky tests to make Mac EWS happy.
- platform/mac/TestExpectations:
- 2:12 PM Changeset in webkit [146658] by
-
- 3 edits in branches/safari-536.30-branch/LayoutTests
Update results where white-space changed because of the change from testRunner" to "layoutTestController.
- fast/block/float/float-not-removed-from-pre-block-expected.txt:
- fast/css/image-set-value-not-removed-crash-expected.txt:
- 2:05 PM Changeset in webkit [146657] by
-
- 9 edits in trunk
NRWT: Enable pixel tests when retrying tests
https://bugs.webkit.org/show_bug.cgi?id=112898
Reviewed by Dirk Pranke.
Tools:
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
if we've forced pixel tests in the retry.
(Manager._run_tests):
(Manager._clean_up_run): Fixed the capitalizations.
(Manager._force_pixel_tests_if_needed): Added.
- Scripts/webkitpy/layout_tests/models/test_run_results.py:
(_interpret_test_failures): Now that this function maybe called multiple times, only set
'image_diff_percent' if it doesn't already exist.
(summarize_results): When the first attempt resulted in a text failure and the second attempt
resulted in image and text failures and we've forced to run pixel tests in the retry run,
treat this as a regular regression instead of a flakiness.
Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
run had image diffs.
- Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
(summarized_results):
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
Also removed some dead code.
(RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
is set and pixel_tests_enabled is set to false.
(EndToEndTest.test_reftest_with_two_notrefs):
LayoutTests:
Link to images and image diff in retries when they're only available in retries.
- fast/harness/resources/results-test.js: Added a test case.
- fast/harness/results-expected.txt:
- fast/harness/results.html:
(imageResultsCell): Extracted from tableRow.
(tableRow): Split the actual result into two tokens (first attempt and retry),
and then check if the image failure was detected in the first attempt. If not,
add hyperlinks to the actual results in the retry run.
- 2:00 PM Changeset in webkit [146656] by
-
- 2 edits in trunk/LayoutTests
Update svg/custom/marker-orient-auto-expected test expectation.
Unreviewed update of test expectations.
- platform/chromium/TestExpectations:
- 1:59 PM Changeset in webkit [146655] by
-
- 4 edits in trunk/LayoutTests
[Chromium] Test expectation after Skia changes
Unreviewed expectations update.
One more not-expected failure, fixed.
- platform/chromium-mac-lion/fast/multicol/vertical-lr/nested-columns-expected.png:
- platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/nested-columns-expected.png:
- platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.png:
- 1:57 PM Changeset in webkit [146654] by
-
- 3 edits4 adds in trunk/LayoutTests
[Chromium] Test expectation after Skia changes
Unreviewed expectations update.
Some more currently failing (not expected) tests.
- platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-clear-expected.png:
- platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
- platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-repaint-expected.png:
- platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
- platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
- 1:51 PM Changeset in webkit [146653] by
-
- 4 edits3 adds in trunk
DFG folding of PutById to SimpleReplace should consider the specialized function case
https://bugs.webkit.org/show_bug.cgi?id=113093
Reviewed by Geoffrey Garen and Mark Hahnenberg.
Source/JavaScriptCore:
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
LayoutTests:
- fast/js/dfg-cfa-prove-put-by-id-simple-when-storing-to-specialized-function-expected.txt: Added.
- fast/js/dfg-cfa-prove-put-by-id-simple-when-storing-to-specialized-function.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-cfa-prove-put-by-id-simple-when-storing-to-specialized-function.js: Added.
(foo):
(baz):
(fuzz):
- 1:41 PM Changeset in webkit [146652] by
-
- 2 edits in trunk/LayoutTests
Add failing test expectations to the test added by r146644 on Mac.
The failure is tracked by http://webkit.org/b/113094.
- platform/mac/TestExpectations:
- 1:36 PM Changeset in webkit [146651] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Force kill gcc-3.exe during bindings generation tests to avoid process hangs.
This problem is occuring on the WinEWS bots where there are somehow multiple gcc-3 processes existing at the same time.
This is a speculative fix. There should only be 1 gcc-3.exe process running at a time ever.
- bindings/scripts/preprocessor.pm:
(applyPreprocessor):
- 1:34 PM Changeset in webkit [146650] by
-
- 5 edits in trunk/Tools
Make it possible to run layout tests on Retina MBP
https://bugs.webkit.org/show_bug.cgi?id=93673
Reviewed by Ryosuke Niwa.
Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
windows on 2x machines still run at 1x.
- DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
Reset the window resolution to 1x on creation.
- DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
- DumpRenderTree/mac/DumpRenderTreeWindow.mm:
(-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
(WTR::PlatformWebView::PlatformWebView):
Add NSWindow details, reset the window resolution to 1x on creation.
- 1:30 PM Changeset in webkit [146649] by
-
- 6 edits in branches/safari-536.30-branch/LayoutTests
<rdar://problem/13465764> Many merged tests are failing
Change all instances of "testRunner" back to "layoutTestController" in svg files, which
my initial commit missed.
- fast/css/font-size-nan.svg:
- svg/custom/stale-resource-data-crash.svg:
- svg/custom/use-href-update-crash.svg:
- svg/custom/use-rebuild-resources-crash.svg:
- svg/text/alt-glpyh-on-fallback-font-crash.svg:
- 1:28 PM Changeset in webkit [146648] by
-
- 1 edit in branches/chromium/1410/Source/WebCore/rendering/RenderLayerCompositor.cpp
Merge 144642 "Don't apply page scale to clipRect if applyPageSca..."
Don't apply page scale to clipRect if applyPageScaleFactorInCompositor is set to true
https://bugs.webkit.org/show_bug.cgi?id=111229
Patch by Min Qin <qinmin@chromium.org> on 2013-03-04
Reviewed by Simon Fraser.
If applyPageScaleFactorInCompositor is set to true, webcore should use css coordinates.
As a result, we shouldn't apply page scale to clipRect in RenderLayerCompositor.
Layout tests set the flag to false, so we don't have anything to test against.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMap):
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12797016
- 1:24 PM Changeset in webkit [146647] by
-
- 11 edits in trunk/Source/WebCore
Cleanup text track selection logic
https://bugs.webkit.org/show_bug.cgi?id=113062
Reviewed by Jer Noble.
No new tests, covered by existing tests.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind): Remove.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Don't look at track attributes directly,
use captionPreferences->textTrackSelectionScore to calculate track rank.
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Set m_processingPreferenceChange here
instead of in captionPreferencesChanged.
(WebCore::HTMLMediaElement::captionPreferencesChanged): Don't suppress calls to setClosedCaptionsVisible,
existing code already makes sure we don't do unnecessary work.
- html/HTMLMediaElement.h:
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Drive by cleanup, don't
process inactive cues.
- html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::changedClosedCaptionsVisibility): Call resetTrackListMenu instead
of updateDisplay so we only mark the menu as needing a recalculation and do the work when
it is displayed.
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::shouldShowCaptions): When in testing mode, return true if
the caption or subtitle preference has been set.
(WebCore::CaptionUserPreferences::setShouldShowCaptions): In testing mode, clear the caption
and subtitle preference when passed false.
(WebCore::CaptionUserPreferences::textTrackSelectionScore): Calculate the track score based on
track type preference and preferred language.
(WebCore::CaptionUserPreferences::textTrackLanguageSelectionScore): Score a track according to
the language presence and position in the preferred languages list.
- page/CaptionUserPreferences.h:
- page/CaptionUserPreferencesMac.h:
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Calculate track language score
according to user preferences.
- platform/Language.cpp:
(WebCore::indexOfBestMatchingLanguageInList): Repurposed the static bestMatchingLanguage
function to return the location of a language in a Vector.
(WebCore::preferredLanguageFromList): Removed.
- platform/Language.h:
- 1:16 PM Changeset in webkit [146646] by
-
- 3 edits in trunk/Source/WebCore
Build fix for TransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=113087
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-03-22
Reviewed by Martin Robinson.
This is a trivial build fix for clutter ac backend. Clutter AC backend doesn't use
TextureMapper so there is nowhere including TransformationMatrix.h.
For the reason, we include it explicitly.
No new tests because of no functionality change.
- platform/graphics/clutter/GraphicsContext3DPrivate.cpp:
- platform/graphics/clutter/GraphicsContext3DPrivate.h:
(WebCore):
- 1:14 PM Changeset in webkit [146645] by
-
- 2 edits in trunk/Source/WebCore
Coordinates.idl lacks Conditional=GEOLOCATION
https://bugs.webkit.org/show_bug.cgi?id=112949
Patch by Steve Block <steveblock@chromium.org> on 2013-03-22
Reviewed by Steve Block.
No new tests, build optimization only.
- page/Coordinates.idl: Added GEOLOCATION conditional guard.
- 1:04 PM Changeset in webkit [146644] by
-
- 12 edits4 adds in trunk
Data store should be readable in dragstart/copy/cut events
https://bugs.webkit.org/show_bug.cgi?id=23695
Reviewed by Tony Chang.
Source/WebCore:
There were several events where data could be written but not read back due to the fact that
different Clipboard method implementations checked permissions inconsistently. This patch
adds helper methods to check if an operation is permitted on a Clipboard and refactors all
direct comparisons against Clipboard::m_policy to use the new helpers instead. This fixes
several bugs where Clipboard::types and Clipboard::getData are not usable inside the
aforementioned events.
Tests: editing/pasteboard/can-read-in-copy-and-cut-events.html
editing/pasteboard/can-read-in-dragstart-event.html
- dom/Clipboard.cpp:
(WebCore::Clipboard::canReadTypes): Formerly restricted to ClipboardReadable and
ClipboardTypesReadable; now allows ClipboardWritable as
well.
(WebCore::Clipboard::canReadData): Formerly restricted to ClipboardReadable; now allows
ClipboardWritable as well.
(WebCore::Clipboard::canWriteData):
(WebCore::Clipboard::canSetDragImage):
(WebCore::Clipboard::hasFileOfType):
(WebCore::Clipboard::hasStringOfType):
(WebCore::Clipboard::setDropEffect):
(WebCore::Clipboard::setEffectAllowed):
- dom/Clipboard.h:
(Clipboard):
- platform/blackberry/ClipboardBlackBerry.cpp:
(WebCore::ClipboardBlackBerry::clearData):
(WebCore::ClipboardBlackBerry::clearAllData):
(WebCore::ClipboardBlackBerry::getData):
(WebCore::ClipboardBlackBerry::setData):
(WebCore::ClipboardBlackBerry::types):
- platform/chromium/ClipboardChromium.cpp:
(WebCore::DataTransferItemPolicyWrapper::kind):
(WebCore::DataTransferItemPolicyWrapper::type):
(WebCore::DataTransferItemPolicyWrapper::getAsString):
(WebCore::DataTransferItemPolicyWrapper::getAsFile):
(WebCore::ClipboardChromium::clearData):
(WebCore::ClipboardChromium::clearAllData):
(WebCore::ClipboardChromium::getData):
(WebCore::ClipboardChromium::setData):
(WebCore::ClipboardChromium::types):
(WebCore::ClipboardChromium::files):
(WebCore::ClipboardChromium::setDragImage):
- platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::clearData):
(WebCore::ClipboardGtk::clearAllData):
(WebCore::ClipboardGtk::getData):
(WebCore::ClipboardGtk::setData):
(WebCore::ClipboardGtk::types):
(WebCore::ClipboardGtk::files):
(WebCore::ClipboardGtk::setDragImage):
- platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::clearData):
(WebCore::ClipboardMac::clearAllData):
(WebCore::ClipboardMac::getData):
(WebCore::ClipboardMac::setData):
(WebCore::ClipboardMac::types):
(WebCore::ClipboardMac::files):
(WebCore::ClipboardMac::setDragImage):
- platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::clearData):
(WebCore::ClipboardQt::clearAllData):
(WebCore::ClipboardQt::getData):
(WebCore::ClipboardQt::setData):
(WebCore::ClipboardQt::types):
(WebCore::ClipboardQt::files):
(WebCore::ClipboardQt::setDragImage):
(WebCore::ClipboardQt::items):
- platform/qt/DataTransferItemListQt.cpp:
(WebCore::DataTransferItemListQt::length):
(WebCore::DataTransferItemListQt::item):
(WebCore::DataTransferItemListQt::deleteItem):
(WebCore::DataTransferItemListQt::clear):
(WebCore::DataTransferItemListQt::add):
- platform/qt/DataTransferItemQt.cpp:
(WebCore::DataTransferItemQt::getAsString):
- platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::clearData):
(WebCore::ClipboardWin::clearAllData):
(WebCore::ClipboardWin::getData):
(WebCore::ClipboardWin::setData):
(WebCore::ClipboardWin::types):
(WebCore::ClipboardWin::files):
(WebCore::ClipboardWin::setDragImage):
LayoutTests:
- editing/pasteboard/can-read-in-copy-and-cut-events-expected.txt: Added.
- editing/pasteboard/can-read-in-copy-and-cut-events.html: Added.
- editing/pasteboard/can-read-in-dragstart-event-expected.txt: Added.
- editing/pasteboard/can-read-in-dragstart-event.html: Added.
- 1:00 PM Changeset in webkit [146643] by
-
- 16 edits1 add in trunk/LayoutTests
[Chromium] Test expectation after Skia changes
Unreviewed expectations update.
Only the things failing on the bots, not already accounted for.
- platform/chromium-linux/fast/text/international/danda-space-expected.png:
- platform/chromium-mac-lion/fast/multicol/vertical-rl/nested-columns-expected.png:
- platform/chromium-mac-lion/fast/ruby/base-shorter-than-text-expected.png:
- platform/chromium-mac-lion/fast/text/emphasis-combined-text-expected.png:
- platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.png:
- platform/chromium-mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/nested-columns-expected.png:
- platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.png:
- platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.png:
- platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
- platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
- platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
- platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png:
- platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/chromium/TestExpectations:
- 12:44 PM Changeset in webkit [146642] by
-
- 2 edits in trunk/Source/WebCore
[CSS Regions] Remove pushLayoutState(RenderFlowThread*) from RenderView
https://bugs.webkit.org/show_bug.cgi?id=113084
Reviewed by Dirk Schulze.
Remove void pushLayoutState(RenderFlowThread*, bool regionsChanged) from RenderView.h because it's not used.
Tests: Code cleanup. No tests needed.
- rendering/RenderView.h:
(RenderView):
- 12:34 PM Changeset in webkit [146641] by
-
- 3 edits in trunk/Source/WebKit/blackberry
Check focused node reference when traversing through history
https://bugs.webkit.org/show_bug.cgi?id=113082
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-03-22
Reviewed by Rob Buis.
PR312101
Check if we have a valid node and document before attempting to access its frame and
frame selection. This is causing issues when going back to a page after a redirect
where a stale pointer is used.
Further, the focused node should be changed after the frame is fully loaded.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::restoreViewState):
- 12:23 PM Changeset in webkit [146640] by
-
- 7 edits in trunk/Source/WebCore
[EFL] Fix build issues to enable CSS Filter and Shaders support.
https://bugs.webkit.org/show_bug.cgi?id=111274
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-22
Reviewed by Noam Rosenthal.
This is in preperation to enable CSS Filter and Shaders support.
This patch fixes related build issues to enable the support.
- platform/graphics/surfaces/efl/GLTransportSurface.cpp:
- platform/graphics/texmap/TextureMapper.cpp:
- platform/graphics/texmap/TextureMapper.h:
(WebCore):
- platform/graphics/texmap/TextureMapperGL.cpp:
- platform/graphics/texmap/TextureMapperGL.h:
(WebCore):
- platform/graphics/texmap/TextureMapperShaderProgram.h:
- 12:11 PM Changeset in webkit [146639] by
-
- 2 edits in trunk/LayoutTests
[chromium] Remove Android platform expectations from Chromium TestExpectations.
(Too many bug URLs to list)
Unreivewed, test expectations update.
- platform/chromium/TestExpectations:
- 12:01 PM Changeset in webkit [146638] by
-
- 4 edits in trunk/Source/WebCore
Implement isEnabledFormControl() for SliderThumbElement and SpinButtonElement in terms of disabled()
https://bugs.webkit.org/show_bug.cgi?id=112993
Reviewed by Kent Tamura.
This is an intermediate step for refactoring Node::disabled and
Element::isEnabledFormControl. All classes that override
isEnabledFormControl just return !disabled(), except for
SliderThumbElement and SpinButtonElement. This patch changes those two
classes to do so, which shows that the two functions are redundant and
easy to refactor into a single function in a subsequent patch.
No new tests, there should be no behavior change.
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::disabled):
(WebCore):
(WebCore::SliderThumbElement::isEnabledFormControl):
- html/shadow/SliderThumbElement.h:
(SliderThumbElement):
- html/shadow/SpinButtonElement.h: The check of shadowHost() is
necessary because it can be detached by JavaScript that runs during
event handling (see r76566)
- 11:47 AM Changeset in webkit [146637] by
-
- 4 edits in trunk/Source
[GTK] Include the right GL header for GLES2
https://bugs.webkit.org/show_bug.cgi?id=113034
Reviewed by Martin Robinson.
Include GLES2/gl2.h when using GLES2.
Source/WebKit/gtk:
- WebCoreSupport/AcceleratedCompositingContextGL.cpp:
Source/WebKit2:
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
- 11:38 AM Changeset in webkit [146636] by
-
- 2 edits in branches/safari-536.30-branch/LayoutTests
Add the newline at end of the test results, apparently lost when merging r131709.
- fast/forms/textarea/textarea-autofocus-removal-while-focusing-with-style-expected.txt:
- 11:30 AM Changeset in webkit [146635] by
-
- 3 edits2 copies in branches/chromium/1410
Merge 146227 "Separate SVG image size and container size"
Separate SVG image size and container size
https://bugs.webkit.org/show_bug.cgi?id=112651
Reviewed by Stephen Chenney.
Source/WebCore:
Previously, SVG images could retain their cached size between reloads due to a bug where an
old container size would be re-used if the image's new container size was not available yet.
This patch changes SVGImage::size() to return the intrinsic size of the image before a
container size has been set. SVGImageCache::imageSizeForRenderer will now return the
image's intrinsic size instead of a cached value if the container size cannot be looked up.
In javascript, querying [SVGImage].width will now return either the image's intrinsic size
or the size of 'imageForContainer'.
Test: svg/as-image/svg-container-size-after-reload.html
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::containerSize):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::dataChanged):
- svg/graphics/SVGImage.h:
The member variable 'm_intrinsicSize' has been added to track the image's intrinsic
size. This term can be found in: http://www.w3.org/TR/css3-images/#default-sizing
- svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::imageSizeForRenderer):
(WebCore::SVGImageCache::imageForRenderer):
In both of these functions, image has been renamed to imageForContainer here to clarify
that the cached container size is being returned, not the image's intrinsic size.
LayoutTests:
- svg/as-image/svg-container-size-after-reload-expected.txt: Added.
- svg/as-image/svg-container-size-after-reload.html: Added.
TBR=pdr@google.com
Review URL: https://codereview.chromium.org/13008026
- 11:28 AM Changeset in webkit [146634] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Hit Test doesn't need to be active
https://bugs.webkit.org/show_bug.cgi?id=113072
Patch by Genevieve Mak <gmak@rim.com> on 2013-03-22
Reviewed by Rob Buis.
Reviewed Internally By Mike Lattanzio.
PR #306074
- WebKitSupport/ProximityDetector.cpp:
(BlackBerry::WebKit::ProximityDetector::findBestPoint):
- 11:27 AM Changeset in webkit [146633] by
-
- 6 edits2 adds in trunk/Source/WebKit/chromium
[chromium] Support Quota API in Worker
https://bugs.webkit.org/show_bug.cgi?id=112713
Hook up WebKit side of queryUsageAndQuota. Tests
and WebCore code will come in https://bugs.webkit.org/show_bug.cgi?id=112972
Reviewed by David Levin.
- WebKit.gyp:
- public/WebCommonWorkerClient.h:
(WebKit::WebCommonWorkerClient::queryUsageAndQuota):
- src/StorageQuotaChromium.cpp:
(WebCore::StorageQuota::queryUsageAndQuota):
(WebCore::StorageQuota::requestQuota):
- src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::queryUsageAndQuota):
(WebKit):
- src/WebWorkerClientImpl.h:
- src/WorkerStorageQuotaCallbacksBridge.cpp: Added.
(WebKit):
(MainThreadStorageQuotaCallbacks):
(WebKit::MainThreadStorageQuotaCallbacks::createLeakedPtr):
(WebKit::MainThreadStorageQuotaCallbacks::~MainThreadStorageQuotaCallbacks):
(WebKit::MainThreadStorageQuotaCallbacks::didQueryStorageUsageAndQuota):
(WebKit::MainThreadStorageQuotaCallbacks::didFail):
(WebKit::MainThreadStorageQuotaCallbacks::didGrantStorageQuota):
(WebKit::MainThreadStorageQuotaCallbacks::MainThreadStorageQuotaCallbacks):
(WorkerStorageQuotaContextObserver):
(WebKit::WorkerStorageQuotaContextObserver::create):
(WebKit::WorkerStorageQuotaContextObserver::notifyStop):
(WebKit::WorkerStorageQuotaContextObserver::WorkerStorageQuotaContextObserver):
(WebKit::WorkerStorageQuotaCallbacksBridge::stop):
(WebKit::WorkerStorageQuotaCallbacksBridge::cleanUpAfterCallback):
(WebKit::WorkerStorageQuotaCallbacksBridge::WorkerStorageQuotaCallbacksBridge):
(WebKit::WorkerStorageQuotaCallbacksBridge::~WorkerStorageQuotaCallbacksBridge):
(WebKit::WorkerStorageQuotaCallbacksBridge::postQueryUsageAndQuotaToMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::queryUsageAndQuotaOnMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::didFailOnMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::didQueryStorageUsageAndQuotaOnMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::didFailOnWorkerThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::didQueryStorageUsageAndQuotaOnWorkerThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::runTaskOnMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::runTaskOnWorkerThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::dispatchTaskToMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::mayPostTaskToWorker):
- src/WorkerStorageQuotaCallbacksBridge.h: Added.
(WebCore):
(WebKit):
(WorkerStorageQuotaCallbacksBridge):
(WebKit::WorkerStorageQuotaCallbacksBridge::create):
- 11:13 AM Changeset in webkit [146632] by
-
- 2 edits in trunk/LayoutTests
Add a failure test expectation to media/track/track-user-preferences.html after r146380.
The failure is tracked by the webkit.org/b/113083.
- platform/mac/TestExpectations:
- 11:08 AM Changeset in webkit [146631] by
-
- 2 edits in branches/safari-536.30-branch/LayoutTests
Merge r135523 to get the updated test results.
2012-11-22 Daniel Bates <dbates@webkit.org>
JavaScript fails to concatenate large strings
<https://bugs.webkit.org/show_bug.cgi?id=102963>
Update test result.
- fast/js/concat-large-strings-crash-expected.txt:
- 10:51 AM Changeset in webkit [146630] by
-
- 5 edits in trunk
[Qt] New fast/text/word-space-with-kerning-3.html fails on Qt.
https://bugs.webkit.org/show_bug.cgi?id=112668
Reviewed by Jocelyn Turcotte.
Source/WebCore:
Qt adds word-spacing to leading spaces, but WebCore only expects
us to add for trailing spaces. We only corrected for this in width
calculation but do need to also do it for drawing.
Instead of subtracting the extra word-spacing we now configure the
FormatRange not to apply to leading spaces. This means this behavior
will be applied everywhere reliably.
- platform/graphics/Font.h:
(Font):
- platform/graphics/qt/FontQt.cpp:
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::initFormatForTextLayout):
LayoutTests:
- platform/qt/TestExpectations:
- 10:41 AM Changeset in webkit [146629] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r146540?): Crashes in storage/indexeddb/factory-basics-workers.html, storage/indexeddb/transaction-error.html
https://bugs.webkit.org/show_bug.cgi?id=113019
Reviewed by Tony Chang.
Also manifesting flakily under Chromium's content_shell. It's an ASSERT being hit in
the IDBTransaction destructor. The cause was r146540 which allows a stopped context
to reclaim script wrappers. This allows the IDBTransaction to be deref'd at times where
it previously would have just leaked. Modulate the destructor assertions to account
for this case.
No new tests; failures already manifest as flaky crashes in some ports.
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::~IDBTransaction): If context is stopped, expected state
transitions/cleanup may not have occurred before destructor runs.
- 10:34 AM Changeset in webkit [146628] by
-
- 4 edits in trunk/Source
IndexedDB: Histogram available disk space on attempt to open database
https://bugs.webkit.org/show_bug.cgi?id=112862
Reviewed by Tony Chang.
Source/Platform:
- chromium/public/Platform.h:
(WebKit::Platform::availableDiskSpaceInBytes):
(Platform):
Source/WebCore:
ChromeOS suspects they might be hitting disk corruption when the disks
are nearly full. This patch logs the available space to either the
"success" or the "fail" histogram as appropriate so that the
distributions can be compared.
No new tests - I don't know of a good way to test histograms. Local
printf testing didn't turn up any bugs.
- platform/leveldb/LevelDBDatabase.cpp:
(WebCore::HistogramFreeSpace):
(WebCore):
(WebCore::LevelDBDatabase::open):
- 10:11 AM Changeset in webkit [146627] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Selection overlay clipped incorrectly
https://bugs.webkit.org/show_bug.cgi?id=113069
Patch by Andrew Lo <anlo@rim.com> on 2013-03-22
Reviewed by George Staikos.
Internally reviewed by Arvid Nilsson.
As a follow-up to r146278, the clip rect also needs to be
adjusted by the parent's offset when drawing the
selection overlay.
- WebKitSupport/SelectionOverlay.cpp:
(BlackBerry::WebKit::SelectionOverlay::paintContents):
- 10:05 AM Changeset in webkit [146626] by
-
- 5 edits3 adds in trunk
REGRESSION (r146239): Reproducible crash in WebCore::DocumentLoader::responseReceived.
https://bugs.webkit.org/show_bug.cgi?id=112811
Reviewed by Brady Eidson.
Source/WebCore:
Test: http/tests/cache/x-frame-options-304.html
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::switchClientsToRevalidatedResource):
- loader/cache/CachedRawResource.h:
LayoutTests:
- http/tests/cache/resources/x-frame-options.php: Added.
- http/tests/cache/x-frame-options-304-expected.txt: Added.
- http/tests/cache/x-frame-options-304.html: Added.
- 10:03 AM Changeset in webkit [146625] by
-
- 3 edits in trunk/Tools
Leak bots shouldn't build
https://bugs.webkit.org/show_bug.cgi?id=112774
Reviewed by Simon Fraser.
Since leak bots use regular debug builds, there is no need to build on these bots.
Simply downloading builds will dramatically improve the cycle time of these bots.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
TestFactory instead of BuildAndTestFactory.
- 9:58 AM Changeset in webkit [146624] by
-
- 2 edits in trunk/LayoutTests
Add flaky crash expectations on some media tests per bugs 113075 and 113076.
- platform/win/TestExpectations:
- 9:41 AM Changeset in webkit [146623] by
-
- 10 edits3 copies in branches/chromium/1410
Merge 146129 "Variant of non-primary fell-back SVGFont causes cr..."
Variant of non-primary fell-back SVGFont causes crash.
https://bugs.webkit.org/show_bug.cgi?id=112367
Reviewed by Stephen Chenney.
Source/WebCore:
Don't go to PlatformFontData path for SimpleFontData::createScaledFontData()
for SVG fonts.
Test: svg/css/font-face-variant-crash.html
- platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::~SimpleFontData):
(WebCore::SimpleFontData::createScaledFontData): Don't go to PlatformFontData path for SVG fonts.
(WebCore):
- platform/graphics/SimpleFontData.h:
(SimpleFontData): Added createScaledFontData and renamed the original createScaledFontData to platformCreateScaledFontData.
BTW, Removed unreferenced commonInit.
- platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Renamed from createScaledFontData.
- platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
- platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
- platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
- platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
- platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
- platform/graphics/wince/SimpleFontDataWinCE.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
- platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
LayoutTests:
- resources/SpaceOnly.otf: Added. A font containing only the space glyph for testing font fallback.
- svg/css/font-face-variant-crash-expected.txt: Added.
- svg/css/font-face-variant-crash.html: Added.
- 9:24 AM Changeset in webkit [146622] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION: -webkit-box-reflect does not show on video elements
https://bugs.webkit.org/show_bug.cgi?id=112397
Reviewed by Eric Carlson.
Work around the ASSERTs generated when setting an AVPlayerLayer's player property
during a CA flush by setting the player property during the next runloop, outside
of a CA flush.
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::clone):
- 9:22 AM Changeset in webkit [146621] by
-
- 3 edits in trunk/Source/WebCore
[Curl] Performance fix, avoid loading cookie file on every request.
https://bugs.webkit.org/show_bug.cgi?id=113023
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-03-22
Reviewed by Brent Fulgham.
We currently load the cookie file on every request, and when setting cookies from JavaScript, by using the option CURLOPT_COOKIEFILE.
This is very inefficient as the cookie file can get quite large, and file I/O is slow.
It is sufficient to load the cookie file on startup, as we use a shared cookie database between the requests.
- platform/network/curl/CookieJarCurl.cpp:
(WebCore::setCookiesFromDOM): Avoid loading cookie file when setting cookies from JavaScript.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::initializeHandle): Avoid loading cookie file on every request.
(WebCore::ResourceHandleManager::initCookieSession): Load the cookie file to shared database on startup.
- 9:08 AM Changeset in webkit [146620] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Update Input field Background Color
https://bugs.webkit.org/show_bug.cgi?id=113063
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-03-22
Reviewed by George Staikos.
RIM PR 307463.
Internally reviewed by Ed Baker.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintTextFieldOrTextAreaOrSearchField):
- 8:56 AM Changeset in webkit [146619] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: FlameChart. Draw function names over flame chart bar if they fit into the bar.
https://bugs.webkit.org/show_bug.cgi?id=113052
Reviewed by Vsevolod Vlasov.
The draw function will draw the bar title if the text is less than bar width.
Unfortunately almost all the projects which need to be profiled
use long function names with dots. So if the function name has dots and
doesn't fit into the space then prepareTitle will try to drop the prefix before dot.
If the title has no dots then the function will strip the tail of the title.
- inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype.draw):
(WebInspector.FlameChart.prototype._prepareTitle):
- 8:55 AM Changeset in webkit [146618] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Update test expectations for a bunch of softwarecompositing tests.
- platform/chromium/TestExpectations:
- 8:44 AM Changeset in webkit [146617] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Add "hidden" attribute to the recently added APIs in Inspector.json
https://bugs.webkit.org/show_bug.cgi?id=113061
Added "hidden": true to the APIs introduced since version 1.0.
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-22
Reviewed by Pavel Feldman.
- inspector/Inspector.json:
- 8:39 AM Changeset in webkit [146616] by
-
- 4 edits in trunk
Source/WebKit/chromium: Skia flag removal to enable bug fixes and performance improvements.
Unreviewed code enabling.
- skia_webkit.gyp:
LayoutTests: Enabling Skia features/modifications.
Unreviewed Chromium expectations, all of which will be removed later today.
- platform/chromium/TestExpectations:
- 8:22 AM Changeset in webkit [146615] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Correctly implement scrollToLine, revealLine and setSelection on CodeMirror editor.
https://bugs.webkit.org/show_bug.cgi?id=113028
Reviewed by Pavel Feldman.
Added focus event handler to CodeMirror editor view elememnt to support inspector's focus model.
Added selection and scroll listeners to correctly save editor scroll and selection in history.
Implemented revealLine, scrollToLine and setSelection.
Note: CodeMirror's coordsChar method does not work correctly in "local" mode, implemented as binary search
as a temporary workaround.
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.defaultFocusedElement):
(WebInspector.CodeMirrorTextEditor.prototype._handleElementFocus):
(WebInspector.CodeMirrorTextEditor.prototype.revealLine):
(WebInspector.CodeMirrorTextEditor.prototype._coordsChar):
(WebInspector.CodeMirrorTextEditor.prototype._topScrolledLine):
(WebInspector.CodeMirrorTextEditor.prototype._bottomScrolledLine):
(WebInspector.CodeMirrorTextEditor.prototype._scroll):
(WebInspector.CodeMirrorTextEditor.prototype._selectionChange):
(WebInspector.CodeMirrorTextEditor.prototype.scrollToLine):
(WebInspector.CodeMirrorTextEditor.prototype.setSelection):
(WebInspector.CodeMirrorTextEditor.prototype.copyRange):
- inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.copyRange):
- 8:16 AM Changeset in webkit [146614] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: [Regression] Editor scroll is not restored after inspector reload.
https://bugs.webkit.org/show_bug.cgi?id=113027
Reviewed by Pavel Feldman.
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.wasShown):
(WebInspector.SourceFrame.prototype._isEditorShowing):
(WebInspector.SourceFrame.prototype._innerHighlightLineIfNeeded):
(WebInspector.SourceFrame.prototype._innerRevealLineIfNeeded):
(WebInspector.SourceFrame.prototype._innerScrollToLineIfNeeded):
(WebInspector.SourceFrame.prototype._innerSetSelectionIfNeeded):
- 8:15 AM WebKitGTK/2.0.x edited by
- Add bug 113036 to the list. (diff)
- 8:04 AM Changeset in webkit [146613] by
-
- 5 edits in trunk/Source/WebCore
[Qt] Fix build with OPENCL 1.2
https://bugs.webkit.org/show_bug.cgi?id=113056
Reviewed by Kenneth Rohde Christiansen.
Switch qmake checks to the modern style which means we can enable OpenCL with
WEBKIT_CONFIG+=opencl.
Upgrade OpenCL 1.1 clCreateImage2D to OpenCL 1.2 clCreateImage calls.
- Target.pri:
- WebCore.pri:
- platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::createOpenCLImageResult):
- platform/graphics/gpu/opencl/FilterContextOpenCL.cpp:
(WebCore::FilterContextOpenCL::createOpenCLImage):
- 7:59 AM WebKitGTK/2.0.x edited by
- (diff)
- 7:57 AM Changeset in webkit [146612] by
-
- 1 edit1 add in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge 146611 - Telugu [te] language translation submission for WebKitGTK+ HEAD
https://bugs.webkit.org/show_bug.cgi?id=103052
Patch by Krishnababu Krothapalli <kkrothap@redhat.com> on 2013-03-22
Reviewed by Gustavo Noronha Silva (kov).
- te.po: Added.
- 7:54 AM Changeset in webkit [146611] by
-
- 1 edit1 add in trunk/Source/WebCore/platform/gtk/po
Telugu [te] language translation submission for WebKitGTK+ HEAD
https://bugs.webkit.org/show_bug.cgi?id=103052
Patch by Krishnababu Krothapalli <kkrothap@redhat.com> on 2013-03-22
Reviewed by Gustavo Noronha Silva (kov).
- te.po: Added.
- 7:45 AM Changeset in webkit [146610] by
-
- 8 edits1 add2 deletes in trunk/LayoutTests
Unreviewed chromium rebaselines for r146600.
- platform/chromium-mac-lion/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
- platform/chromium-mac-lion/fast/transforms/bounding-rect-zoom-expected.txt: Removed.
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Added.
- platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.png:
- platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.txt:
- platform/chromium-mac/fast/transforms/bounding-rect-zoom-expected.txt:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
- 7:42 AM Changeset in webkit [146609] by
-
- 2 edits in trunk/Source/WebCore
[GTK][AC] Opacity animation doesn't work with clutter backend
https://bugs.webkit.org/show_bug.cgi?id=110347
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-03-22
Reviewed by Gustavo Noronha Silva.
The static casting in ternary operator doesn't change actual inputted argument type.
So I replaced it with if-else statement.
Covered by existing animation tests.
- platform/graphics/clutter/PlatformClutterAnimation.cpp:
(WebCore::PlatformClutterAnimation::addClutterTransitionForProperty):
(WebCore::PlatformClutterAnimation::addClutterKeyframeTransitionForProperty):
- 7:38 AM Changeset in webkit [146608] by
-
- 3 edits in trunk/Source/WebCore
[GTK][AC] Add removing animations procedure with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=110607
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-03-22
Reviewed by Gustavo Noronha Silva.
This changes is based on mac port implementation. The only different thing is
that updateAnimations is called explicitly in destructor of GraphicsLayerClutter
to remove uncommitted animations. Because even though we call notifyFlushRequired
to remove existing animations in removeAnimation(), removeClutterAnimationFromLayer
has been never reached since the root layer is destroyed before. It means
that we haven't lost a change to remove actual animations from clutterActor.
Covered by existing animation tests.
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::removeAnimation):
(WebCore):
(WebCore::GraphicsLayerClutter::removeClutterAnimationFromLayer):
- platform/graphics/clutter/GraphicsLayerClutter.h:
(WebCore::GraphicsLayerClutter::animationIsRunning):
(GraphicsLayerClutter):
- 7:28 AM Changeset in webkit [146607] by
-
- 2 edits in trunk/Source/WebCore
[EFL][WebGL] Optimize AlphaOp for HTMLVideoElement input.
https://bugs.webkit.org/show_bug.cgi?id=113049
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-22
Reviewed by Kenneth Rohde Christiansen.
Covered by existing tests.
Changeset 137397 implemented optimisation to avoid any
unnecessary Unmultiply or Premultiply operation in unpack/pack
provided the Image source is from HTMLVideoElement. This patch
enables the same for EFL port.
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- 7:27 AM Changeset in webkit [146606] by
-
- 8 edits5 adds in trunk/LayoutTests
Unreviewed chromium and apple mac rebaselines for r146600.
- platform/chromium-mac-lion/fast/text/international/bidi-layout-across-linebreak-expected.png:
- platform/chromium-mac-lion/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
- platform/chromium-mac-lion/fast/transforms/bounding-rect-zoom-expected.txt: Added.
- platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
- platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
- platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
- platform/chromium-win/fast/transforms/bounding-rect-zoom-expected.txt: Removed.
- platform/chromium/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
- platform/chromium/fast/transforms/bounding-rect-zoom-expected.txt: Added.
- platform/mac/fast/text/international/bidi-layout-across-linebreak-expected.txt:
- platform/mac/fast/transforms/bounding-rect-zoom-expected.txt:
- 7:24 AM Changeset in webkit [146605] by
-
- 2 edits in trunk/Source/WebKit2
Fix an assert when opening the Web Inspector window for the first time.
rdar://problem/13471765
https://webkit.org/b/113053
Reviewed by Eric Carlson.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::createInspectorWindow): Assign m_inspectorWindow
earlier so it is ready for when center is called and windowDidMove: gets called.
- 7:22 AM Changeset in webkit [146604] by
-
- 2 edits in trunk/Source/JavaScriptCore
BUILD FIX (r146558): Build testapi.mm with ARC enabled for armv7s
<http://webkit.org/b/112608>
Fixes the following build failure:
Source/JavaScriptCore/API/tests/testapi.mm:205:1: error: method possibly missing a [super dealloc] call [-Werror,-Wobjc-missing-super-calls]
}
1 error generated.
- Configurations/ToolExecutable.xcconfig: Enable ARC for armv7s
architecture.
- 6:53 AM Changeset in webkit [146603] by
-
- 2 edits in trunk/Source/JavaScriptCore
Revert "BUILD FIX (r146558): Call [super dealloc] from -[TinyDOMNode dealloc]"
This fixes a build failure introduced by this change:
Source/JavaScriptCore/API/tests/testapi.mm:206:6: error: ARC forbids explicit message send of 'dealloc'
[super dealloc];
~
1 error generated.
Not sure why this didn't fail locally on my Mac Pro.
- API/tests/testapi.mm:
(-[TinyDOMNode dealloc]): Remove call to [super dealloc].
- 6:46 AM Changeset in webkit [146602] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Missed one in r146589.
- platform/qt/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Rebaselining after r146531.
- 6:43 AM Changeset in webkit [146601] by
-
- 13 edits in trunk
Source/WebCore: Clean up the speech recognintion API
https://bugs.webkit.org/show_bug.cgi?id=112916
Reviewed by Adam Barth.
This patch cleans away deprecated parts, fixes so that stop() can be called more than once and adds
the missing emma attribute on SpeechRecognitionEvent (which is always null).
Patch covered by existing tests.
- Modules/speech/SpeechRecognition.cpp:
(WebCore::SpeechRecognition::stopFunction):
(WebCore::SpeechRecognition::abort):
(WebCore::SpeechRecognition::didEnd):
(WebCore::SpeechRecognition::SpeechRecognition):
- Modules/speech/SpeechRecognition.h:
(SpeechRecognition):
- Modules/speech/SpeechRecognitionEvent.cpp:
(WebCore::SpeechRecognitionEvent::createResult):
(WebCore::SpeechRecognitionEvent::createNoMatch):
(WebCore::SpeechRecognitionEvent::SpeechRecognitionEvent):
- Modules/speech/SpeechRecognitionEvent.h:
(WebCore):
(SpeechRecognitionEventInit):
(SpeechRecognitionEvent):
(WebCore::SpeechRecognitionEvent::emma):
- Modules/speech/SpeechRecognitionEvent.idl:
Source/WebKit/chromium: Clean up the speach recognintion API
https://bugs.webkit.org/show_bug.cgi?id=112916
Reviewed by Adam Barth.
- public/WebSpeechRecognizerClient.h:
- src/SpeechRecognitionClientProxy.cpp:
- src/SpeechRecognitionClientProxy.h:
(SpeechRecognitionClientProxy):
LayoutTests: Clean up the speech recognintion API
https://bugs.webkit.org/show_bug.cgi?id=112916
Reviewed by Adam Barth.
- fast/events/constructors/speech-recognition-event-constructor-expected.txt:
- fast/events/constructors/speech-recognition-event-constructor.html:
- 6:40 AM Changeset in webkit [146600] by
-
- 8 edits2 adds in trunk
Floor cell widths in AutoTableLayout::recalcColumn
https://bugs.webkit.org/show_bug.cgi?id=112922
Reviewed by Levi Weintraub.
Source/WebCore:
Table cells widths are floored to ensure even distribution of available
space across columns. The code path that computes the width of the
_table_ failed to take this into account and thus can over report the
total width of the table.
Test: fast/sub-pixel/table-with-subpixel-cell-size.html
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn): Floor width to match column sizing logic.
LayoutTests:
Add test for table with subpixel cells and update existing baselines as needed.
- fast/sub-pixel/table-with-subpixel-cell-size-expected.html: Added.
- fast/sub-pixel/table-with-subpixel-cell-size.html: Added.
- platform/chromium-linux/fast/text/international/bidi-layout-across-linebreak-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
- platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.txt:
- platform/chromium-win/fast/transforms/bounding-rect-zoom-expected.txt:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
- 6:35 AM Changeset in webkit [146599] by
-
- 2 edits in trunk/Source/JavaScriptCore
BUILD FIX (r146558): Call [super dealloc] from -[TinyDOMNode dealloc]
<http://webkit.org/b/112608>
Fixes the following build failure:
Source/JavaScriptCore/API/tests/testapi.mm:205:1: error: method possibly missing a [super dealloc] call [-Werror,-Wobjc-missing-super-calls]
}
1 error generated.
- API/tests/testapi.mm:
(-[TinyDOMNode dealloc]): Call [super dealloc].
- 6:27 AM Changeset in webkit [146598] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX (r146208): Export shouldPrintExceptions methods for iOS
Fixes the following build failure:
Undefined symbols for architecture i386:
"ZN7WebCore11PageConsole24setShouldPrintExceptionsEb", referenced from:
+[WebCoreStatistics setShouldPrintExceptions:] in WebCoreStatistics.o
"ZN7WebCore11PageConsole21shouldPrintExceptionsEv", referenced from:
+[WebCoreStatistics shouldPrintExceptions] in WebCoreStatistics.o
ld: symbol(s) not found for architecture i386
clang: error: linker command failed with exit code 1 (use -v to see invocation)
- WebCore.exp.in: Move symbols so they're exported for iOS as
well.
- 6:18 AM Changeset in webkit [146597] by
-
- 6 edits2 adds in trunk/Source/WebKit
[BlackBerry] Add custom BackForwardList client implementation
https://bugs.webkit.org/show_bug.cgi?id=113024
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-22
Reviewed by Rob Buis.
PR 310030
Internally reviewed by Joe Mason.
Source/WebKit:
- PlatformBlackBerry.cmake: Add new files to compilation.
Source/WebKit/blackberry:
Adds a new class BackForwardListBlackBerry that implements
BackForwardList client and wraps the BackForwardListImpl including
the BlackBerry specific changes to notify the API layer when the
BackForwardList changes.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init): Create a
BackForwardListBlackBerry.
(BlackBerry::WebKit::WebPage::getBackForwardList): Use
BackForwardListBlackBerry instead of BackForwardListImpl.
(BlackBerry::WebKit::WebPage::clearBackForwardList): Ditto.
- WebCoreSupport/BackForwardListBlackBerry.cpp: Added.
(WebCore):
(WebCore::BackForwardListBlackBerry::BackForwardListBlackBerry):
(WebCore::BackForwardListBlackBerry::~BackForwardListBlackBerry):
(WebCore::BackForwardListBlackBerry::current):
(WebCore::BackForwardListBlackBerry::notifyBackForwardListChanged):
(WebCore::BackForwardListBlackBerry::addItem):
(WebCore::BackForwardListBlackBerry::goToItem):
(WebCore::BackForwardListBlackBerry::itemAtIndex):
(WebCore::BackForwardListBlackBerry::backListCount):
(WebCore::BackForwardListBlackBerry::forwardListCount):
(WebCore::BackForwardListBlackBerry::isActive):
(WebCore::BackForwardListBlackBerry::close):
(WebCore::BackForwardListBlackBerry::clear):
(WebCore::BackForwardListBlackBerry::entries):
(WebCore::BackForwardListBlackBerry::currentItem):
- WebCoreSupport/BackForwardListBlackBerry.h: Added.
(WebKit):
(WebCore):
(BackForwardListBlackBerry):
(WebCore::BackForwardListBlackBerry::create):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
- WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):
- 5:32 AM Changeset in webkit [146596] by
-
- 1 edit1 add in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge 146594 - [kn] Kannada Translation for webkit
https://bugs.webkit.org/show_bug.cgi?id=106301
Patch by Shankar Prasad <svenkate@redhat.com> on 2013-03-22
Reviewed by Gustavo Noronha Silva (kov).
- kn.po: Added.
- 5:32 AM Changeset in webkit [146595] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge 146474 - [l10n] [mr] Updated WebKitGTK+ Translation(s) in Marathi [mr] language
https://bugs.webkit.org/show_bug.cgi?id=103035
Patch by Sandeep Shedmake <sshedmak@redhat.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).
- mr.po: updated.
- 5:31 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:29 AM Changeset in webkit [146594] by
-
- 1 edit1 add in trunk/Source/WebCore/platform/gtk/po
[kn] Kannada Translation for webkit
https://bugs.webkit.org/show_bug.cgi?id=106301
Patch by Shankar Prasad <svenkate@redhat.com> on 2013-03-22
Reviewed by Gustavo Noronha Silva (kov).
- kn.po: Added.
- 5:24 AM Changeset in webkit [146593] by
-
- 2 edits in trunk/Tools
[Qt] Fix the TestWebKitAPI build
https://bugs.webkit.org/show_bug.cgi?id=113044
Reviewed by Tor Arne Vestbø.
The generate-forwarding-headers script would only be run
after the targets in InjectedBundle.pri since the second
addStrictSubdirOrderBetween call in
Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
the derived_sources -> injected_bundle order in SUBDIRS.
Fix it by only moving the dependent target at the end of
SUBDIRS, don't touch its dependency.
- qmake/mkspecs/features/functions.prf:
- 5:14 AM Changeset in webkit [146592] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix Chromium Win compilation after r146583.
- bindings/v8/CustomElementHelpers.cpp:
(WebCore::CustomElementHelpers::invokeReadyCallbackIfNeeded):
- 5:04 AM Changeset in webkit [146591] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Flame Chart. Chart has to be zoomed around the mouse pointer.
https://bugs.webkit.org/show_bug.cgi?id=113031
Reviewed by Yury Semikhatsky.
Overview grid is able to zoom around the mouse pointer.
So the simplest way is to translate x coordinate of the mouse pointer hovered over the chart
to x coordinate in term of overview window and pass it to the zoom function.
Minor unrelated fix: draw small border at bottom of the overview grid.
- inspector/front-end/FlameChart.js:
(WebInspector.FlameChart.prototype._onMouseWheel):
- inspector/front-end/OverviewGrid.js:
(WebInspector.OverviewGrid.prototype.zoom):
- inspector/front-end/flameChart.css:
(#flame-chart-overview-container):
- 4:58 AM Changeset in webkit [146590] by
-
- 2 edits in trunk/Source/WebCore
[Texmap] TextureMapperImageBuffer should not use rendering code for filters.
https://bugs.webkit.org/show_bug.cgi?id=113040
Patch by No'am Rosenthal <Noam Rosenthal> on 2013-03-22
Reviewed by Kenneth Rohde Christiansen.
Disable TextureMapperImageBuffer filters, until they can be done the right way.
This should only disrupt accelerated filters in fallback mode, which is a very rare
use case.
No new testable functionality.
- platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::applyFilters):
- 4:54 AM Changeset in webkit [146589] by
-
- 3 edits8 moves8 deletes in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebaselining after r146469 and r146531. Cleaning up duplicated expecteds.
- platform/qt-5.0-wk1/compositing/iframes/iframe-size-from-zero-expected.txt:
- platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Removed.
- platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Removed.
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Removed.
- platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Removed.
- platform/qt/compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-expected.png.
- platform/qt/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt.
- platform/qt/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png.
- platform/qt/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt.
- platform/qt/compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-expected.png.
- platform/qt/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt.
- platform/qt/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png.
- platform/qt/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt.
- platform/qt/css3/filters/effect-reference-expected.txt:
- 4:29 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:26 AM Changeset in webkit [146588] by
-
- 5 edits in trunk
Web Inspector: Report more CSS errors
https://bugs.webkit.org/show_bug.cgi?id=113022
Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-22
Reviewed by Pavel Feldman.
Source/WebCore:
Reporting next few CSS syntax errors in declaration_list.
- css/CSSGrammar.y.in:
LayoutTests:
- inspector/console/console-css-warnings-expected.txt:
- inspector/console/console-css-warnings.html:
- 4:00 AM Changeset in webkit [146587] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: use individual samples to construct CPU profile flame chart
https://bugs.webkit.org/show_bug.cgi?id=112569
Reviewed by Pavel Feldman.
Added an optional array of samples to the CPU profile returned over the
protocol. Each sample is id of the profile node corresponding to the top frame
of the sample's stack trace. The array of samples if present is used to draw
the flame chart on the CPU profile panel, otherwise flame chart is drawn based
on the aggregated profile data.
- bindings/js/ScriptProfile.cpp:
(WebCore::ScriptProfile::buildInspectorObjectForSamples):
- bindings/js/ScriptProfile.h:
(ScriptProfile):
- bindings/v8/ScriptProfile.cpp:
(WebCore::buildInspectorObjectFor):
(WebCore):
(WebCore::ScriptProfile::buildInspectorObjectForSamples):
- bindings/v8/ScriptProfile.h:
(ScriptProfile):
- bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::start):
- inspector/Inspector.json:
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::getCPUProfile):
- inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileView.prototype._getCPUProfileCallback):
(WebInspector.CPUProfileView.prototype._buildIdToNodeMap):
- inspector/front-end/FlameChart.js:
(WebInspector.FlameChart.prototype._calculateTimelineData):
- 3:34 AM Changeset in webkit [146586] by
-
- 2 edits in trunk
Cannot run All Source (target WebProcess) on Xcode.
https://bugs.webkit.org/show_bug.cgi?id=111042
Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2013-03-22
Reviewed by Alexey Proskuryakov.
WebProcessShim is renamed by r139066.
However, WebProcessShim is not renamed to SecItemShim in WebKit.xcworkspace.
This make WebProcess.app load WebProcessShim.dylib, and it cause dyld loading error.
- WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme: Renamed WebProcessShim to SecItemShim.
- 3:08 AM Changeset in webkit [146585] by
-
- 14 edits1 move1 delete in trunk/Source/WebCore
Use generated bindings for the Coordinates type used by Geolocation
https://bugs.webkit.org/show_bug.cgi?id=112975
Patch by Steve Block <steveblock@chromium.org> on 2013-03-22
Reviewed by Kentaro Hara.
No new tests, refactoring only.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/geolocation/Coordinates.cpp: Renamed from Source/WebCore/bindings/js/JSCoordinatesCustom.cpp.
(WebCore):
(WebCore::Coordinates::altitude):
(WebCore::Coordinates::altitudeAccuracy):
(WebCore::Coordinates::heading):
(WebCore::Coordinates::speed):
- Modules/geolocation/Coordinates.h:
(Coordinates):
- Modules/geolocation/Coordinates.idl:
- Target.pri:
- UseJSC.cmake:
- UseV8.cmake:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/v8/custom/V8CoordinatesCustom.cpp: Removed.
- 3:04 AM Changeset in webkit [146584] by
-
- 16 edits12 adds in trunk
INPUT_MULTIPLE_FIELDS_UI: Incomplete datetime format should fallback to default
https://bugs.webkit.org/show_bug.cgi?id=113005
Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-22
Reviewed by Kent Tamura.
Source/WebCore:
Use fallback format when datetime format from locale is not complete.
Tests: fast/forms/date-multiple-fields/date-multiple-fields-fallback-format.html
fast/forms/datetime-multiple-fields/datetime-multiple-fields-fallback-format.html
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format.html
fast/forms/month-multiple-fields/month-multiple-fields-fallback-format.html
fast/forms/time-multiple-fields/time-multiple-fields-fallback-format.html
fast/forms/week-multiple-fields/week-multiple-fields-fallback-format.html
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(DateTimeFormatValidator): A helper class that parses datetime format and tests existence of fields.
(WebCore::DateTimeFormatValidator::DateTimeFormatValidator):
(WebCore::DateTimeFormatValidator::visitField):
(WebCore::DateTimeFormatValidator::validateFormat): Parses datetime format and validates by calling BaseMultipleFieldsDateAndTimeInputType::isValidFormat.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue): Checks if dateTimeFormat is valid, and uses fallback format if not.
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType): Declare isValidFormat.
- html/DateInputType.cpp:
(WebCore::DateInputType::isValidFormat): Added.
- html/DateInputType.h:
(DateInputType):
- html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::isValidFormat): Added.
- html/DateTimeInputType.h:
(DateTimeInputType):
- html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::isValidFormat): Added.
- html/DateTimeLocalInputType.h:
(DateTimeLocalInputType):
- html/MonthInputType.cpp:
(WebCore::MonthInputType::isValidFormat): Added.
- html/MonthInputType.h:
(MonthInputType):
- html/TimeInputType.cpp:
(WebCore::TimeInputType::isValidFormat): Added.
- html/TimeInputType.h:
(TimeInputType):
- html/WeekInputType.cpp:
(WebCore::WeekInputType::isValidFormat): Added.
- html/WeekInputType.h:
(WeekInputType):
LayoutTests:
- fast/forms/date-multiple-fields/date-multiple-fields-fallback-format-expected.txt: Added.
- fast/forms/date-multiple-fields/date-multiple-fields-fallback-format.html: Added.
- fast/forms/datetime-multiple-fields/datetime-multiple-fields-fallback-format-expected.txt: Added.
- fast/forms/datetime-multiple-fields/datetime-multiple-fields-fallback-format.html: Added.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format-expected.txt: Added.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format.html: Added.
- fast/forms/month-multiple-fields/month-multiple-fields-fallback-format-expected.txt: Added.
- fast/forms/month-multiple-fields/month-multiple-fields-fallback-format.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-fallback-format-expected.txt: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-fallback-format.html: Added.
- fast/forms/week-multiple-fields/week-multiple-fields-fallback-format-expected.txt: Added.
- fast/forms/week-multiple-fields/week-multiple-fields-fallback-format.html: Added.
- 2:54 AM Changeset in webkit [146583] by
-
- 24 edits14 adds in trunk
Custom Elements: "readyCallback" lifecycle callback should be called.
https://bugs.webkit.org/show_bug.cgi?id=112538
Reviewed by Elliott Sprehn.
Source/WebCore:
This change allows each custom element definition to hook up its instantiation,
namely "readyCallback" lifecycle callback.
The change has two parts:
- 1. Tracking which Element objects to be created.
- 2. Invoking appropriate JavaScript functions, which are readyCallback(), before the Element object is visible from page script.
For 1, CustomElementRegistry maintains list of "callback
invocaions". Each list item ("invocation") tracks the element
which has a lifecycle callback to be invoked. Each invocation is
registered when - Any custom element C++ object is instantiated.
See changes on CustomElementConstructor.cpp.
This also happens when @is attribute is set by the parser or node
cloning routine, which can turn a non-custom element into a
type-extended custom element. See changes on Element.cpp.
For 2, CustomElementRegistry basically follows what
MutationObserver is doing, and introduces a method called
deliverLifecycleCallbacks(). This function flushes all pending
callback invocations. You can think it as a dual of
MutationObserver::deliverAllMutations().
The delivery function is called places where MutationObserver's
deliverAllMutations() is called. In addition, it is also called
just before returning from a set of DOM APIs. For example, it is
called just before createElement() returns, so that possibly
created custom element becomes ready through its readyCallback().
Such APIs get "V8DeliverCustomElementCallbacks" IDL attribute. In
principle, APIs which can create new custom element instnaces are
marked. See CustomElementRegistry::CallbackDeliveryScope and
changes on CodeGeneratorV8.pm.
We need this extra work because the readyCallback() needs to give
an illusion so that JavaScript programmers feel like the
readyCallback() callback being called just after it is created,
instead of called on arbitrary late timing like MutationObserver
notifications.
Tests: fast/dom/custom/lifecycle-ready-createElement-recursion.html
fast/dom/custom/lifecycle-ready-createElement-reentrancy.html
fast/dom/custom/lifecycle-ready-creation-api.html
fast/dom/custom/lifecycle-ready-innerHTML.html
fast/dom/custom/lifecycle-ready-parser-only.html
fast/dom/custom/lifecycle-ready-parser-script.html
fast/dom/custom/lifecycle-ready-paste.html
- bindings/scripts/CodeGeneratorV8.pm:
- Hooked up CallbackDeliveryScope through V8DeliverCustomElementCallbacks attriute.
(GenerateCustomElementInvocationScopeIfNeeded):
(GenerateNormalAttrSetter):
(GenerateFunction):
- bindings/scripts/IDLAttributes.txt:
- bindings/v8/CustomElementHelpers.cpp:
(WebCore::CustomElementHelpers::invokeReadyCallbackIfNeeded):
(WebCore::CustomElementHelpers::invokeReadyCallbacksIfNeeded):
- bindings/v8/CustomElementHelpers.h:
(CustomElementHelpers):
- bindings/v8/V8RecursionScope.cpp: Added deliverAllLifecycleCallbacks()
(WebCore::V8RecursionScope::didLeaveScriptContext):
- dom/CustomElementConstructor.cpp:
(WebCore::CustomElementConstructor::createElement):
(WebCore::CustomElementConstructor::createElementInternal):
- dom/CustomElementConstructor.h:
(WebCore::CustomElementConstructor::isExtended):
(CustomElementConstructor):
- dom/CustomElementRegistry.cpp: Adding element tracking and invocation execution.
(WebCore::CustomElementInvocation::CustomElementInvocation):
(WebCore::CustomElementInvocation::~CustomElementInvocation):
(WebCore::activeCustomElementRegistries):
(WebCore::CustomElementRegistry::~CustomElementRegistry):
(WebCore::CustomElementRegistry::didGiveTypeExtension):
(WebCore::CustomElementRegistry::didCreateElement):
(WebCore::CustomElementRegistry::activate):
(WebCore::CustomElementRegistry::deactivate):
(WebCore::CustomElementRegistry::deliverLifecycleCallbacks):
(WebCore::CustomElementRegistry::deliverAllLifecycleCallbacks):
- dom/CustomElementRegistry.h:
(CustomElementInvocation):
(WebCore::CustomElementInvocation::element):
(CallbackDeliveryScope):
(WebCore::CustomElementRegistry::CallbackDeliveryScope::CallbackDeliveryScope):
(WebCore::CustomElementRegistry::CallbackDeliveryScope::~CallbackDeliveryScope):
(CustomElementRegistry):
(WebCore::CustomElementRegistry::deliverAllLifecycleCallbacksIfNeeded):
- dom/Document.cpp:
(WebCore::Document::createElement):
(WebCore::Document::didCreateCustomElement):
- dom/Document.h:
(Document):
- dom/Document.idl:
- dom/Element.cpp:
(WebCore::Element::attributeChangedFromParserOrByCloning): Added to catch @is attribute
(WebCore::Element::parserSetAttributes):
(WebCore::Element::cloneAttributesFromElement):
- dom/Element.h:
- dom/Node.idl:
- dom/ShadowRoot.idl:
- html/HTMLElement.idl:
- html/parser/HTMLScriptRunner.cpp: Added deliverAllLifecycleCallbacks()
(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::runScript):
Source/WebKit/chromium:
- src/WebKit.cpp: Added deliverAllLifecycleCallbacks()
Source/WTF:
- wtf/HashSet.h:
(WTF::copyToVector): Generalized to let it accept variants like ListHahsSet instead of only HashSet.
LayoutTests:
- fast/dom/custom/lifecycle-ready-createElement-recursion-expected.txt: Added.
- fast/dom/custom/lifecycle-ready-createElement-recursion.html: Added.
- fast/dom/custom/lifecycle-ready-createElement-reentrancy-expected.txt: Added.
- fast/dom/custom/lifecycle-ready-createElement-reentrancy.html: Added.
- fast/dom/custom/lifecycle-ready-creation-api-expected.txt: Added.
- fast/dom/custom/lifecycle-ready-creation-api.html: Added.
- fast/dom/custom/lifecycle-ready-innerHTML-expected.txt: Added.
- fast/dom/custom/lifecycle-ready-innerHTML.html: Added.
- fast/dom/custom/lifecycle-ready-parser-only-expected.html: Added.
- fast/dom/custom/lifecycle-ready-parser-only.html: Added.
- fast/dom/custom/lifecycle-ready-parser-script-expected.txt: Added.
- fast/dom/custom/lifecycle-ready-parser-script.html: Added.
- fast/dom/custom/lifecycle-ready-paste-expected.txt: Added.
- fast/dom/custom/lifecycle-ready-paste.html: Added.
- 2:29 AM Changeset in webkit [146582] by
-
- 18 edits in trunk
MediaStream API: Finalize the RTCPeerConnection states
https://bugs.webkit.org/show_bug.cgi?id=112792
Reviewed by Adam Barth.
Source/Platform:
- chromium/public/WebRTCPeerConnectionHandlerClient.h:
Source/WebCore:
This patch finalized the RTCPeerConnection state and events. These changes
have not yet pushed out to the editors draft; but they are uncontroversial
and agreed upon.
readyState will be deleted; please use the replacement signalingState which is already available.
onstatechange -> onsignalingstatechange
onicechange -> oniceconnectionstatechange
ongatheringchange will be deleted since oniceconnectionstatechange can be used for the same purpose.
RTCIceConnectionState::"starting" -> RTCIceConnectionState::"new"
Patch covered by modified tests.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::iceConnectionState):
(WebCore::RTCPeerConnection::changeSignalingState):
(WebCore::RTCPeerConnection::changeIceGatheringState):
(WebCore::RTCPeerConnection::changeIceConnectionState):
- Modules/mediastream/RTCPeerConnection.h:
(RTCPeerConnection):
- Modules/mediastream/RTCPeerConnection.idl:
- dom/EventNames.h:
(WebCore):
- platform/mediastream/RTCPeerConnectionHandlerClient.h:
Source/WebKit/chromium:
- src/AssertMatchingEnums.cpp:
LayoutTests:
- fast/mediastream/RTCPeerConnection-datachannel.html:
- fast/mediastream/RTCPeerConnection-dtmf.html:
- fast/mediastream/RTCPeerConnection-events-expected.txt:
- fast/mediastream/RTCPeerConnection-events.html:
- fast/mediastream/RTCPeerConnection-ice.html:
- fast/mediastream/RTCPeerConnection-state-expected.txt:
- fast/mediastream/RTCPeerConnection-state.html:
- 2:23 AM Changeset in webkit [146581] by
-
- 2 edits in trunk/Tools
[EFL][WK2] View is not focused when fullscreen mode toggled
https://bugs.webkit.org/show_bug.cgi?id=113009
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-22
Reviewed by Laszlo Gombos.
Set focus on view when fullscreen mode enabled/disabled
by FullScreen API.
- MiniBrowser/efl/main.c:
(on_fullscreen_accept):
(on_fullscreen_deny):
- 2:20 AM Changeset in webkit [146580] by
-
- 4 edits in trunk/Source/WebCore
Prefer 'KURL(ParsedURLString, String)' when dealing with known-good data.
https://bugs.webkit.org/show_bug.cgi?id=112965
Reviewed by Alexey Proskuryakov.
In https://bugs.webkit.org/show_bug.cgi?id=112783#c6, Adam noted that
it would be possible to use 'KURL(ParsedURLString, [url])' rather than
'KURL(KURL(), [url])', since we knew that the URL in question is a
value and absolute URL. This patch fixes the obvious instances of this
pattern; there are several more 'KURL(KURL(), String)' calls in
WebCore but these were the only places I was reasonably sure that bad
data couldn't creep in.
- dom/Document.cpp:
(WebCore::Document::updateBaseURL):
'documentURI' is pulled from 'url()->string()'. It's safe.
- page/ContentSecurityPolicy.cpp:
(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):
'CallFrame::sourceURL()' is a known valid/absolute URL.
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::createFromDatabaseIdentifier):
(WebCore::SecurityOrigin::create):
The strings constructed here are certainly valid.
- 2:17 AM Changeset in webkit [146579] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Unskip a now passing test after r146393.
https://bugs.webkit.org/show_bug.cgi?id=112904.
- platform/qt/TestExpectations:
- 2:09 AM Changeset in webkit [146578] by
-
- 3 edits1 add in trunk/LayoutTests
[EFL] New baseline for accessibility/platform-name.html
https://bugs.webkit.org/show_bug.cgi?id=113018
Unreviewed EFL gardening
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-22
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- platform/efl/accessibility/platform-name-expected.txt: Added.
- 2:00 AM Changeset in webkit [146577] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Flame Chart. move overview window when user scrolls the chart.
https://bugs.webkit.org/show_bug.cgi?id=113014
Reviewed by Yury Semikhatsky.
I found that I could use scaling mechanics in OverviewGrid for scaling the chart.
But the dragging part was not so simple due to the different approaches in
OverviewGrid and FlameChart. OverviewGrid used _windowLeft and _windowRight
when FlameChart used _xOffset and _xScaleFactor and width.
It was not practical and I rewrote the FlameChart mechanics
and now it also uses _windowLeft _windowRight.
- inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.Calculator.prototype._updateBoundaries):
(WebInspector.FlameChart.Calculator.prototype.computePosition):
(WebInspector.FlameChart.prototype._onWindowChanged):
(WebInspector.FlameChart.prototype._startCanvasDragging):
(WebInspector.FlameChart.prototype._canvasDragging):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype._onMouseWheel):
(WebInspector.FlameChart.prototype._coordinatesToNodeIndex):
(WebInspector.FlameChart.prototype._drawOverviewCanvas):
(WebInspector.FlameChart.prototype.draw):
(WebInspector.FlameChart.prototype._updateBoundaries):
(WebInspector.FlameChart.prototype.update):
- inspector/front-end/OverviewGrid.js:
(WebInspector.OverviewGrid.prototype.setWindowPosition):
(WebInspector.OverviewGrid.prototype.setWindow):
(WebInspector.OverviewGrid.prototype.addEventListener):
(WebInspector.OverviewGrid.prototype.zoom):
(WebInspector.OverviewGrid.Window.prototype._zoom):
- inspector/front-end/inspectorCommon.css:
(.overview-grid-window-rulers):
- 1:56 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:52 AM Changeset in webkit [146576] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Tools
Merge r146504 - [GTK] generate-feature-defines-files is incompatible with Python3
https://bugs.webkit.org/show_bug.cgi?id=112956
Reviewed by Martin Robinson.
Make the generate-feature-defines-files compatible with Python3 by calling the items()
method on the dictionary objects when iterating through said dictionaries.
- gtk/generate-feature-defines-files:
(write_feature_defines_header):
(write_flattened_feature_defines_file):
- 1:38 AM Changeset in webkit [146575] by
-
- 6 edits1 move in trunk/Source/WebCore
Move GeolocationClient.h to Modules/geolocation/
https://bugs.webkit.org/show_bug.cgi?id=112997
Patch by Steve Block <steveblock@chromium.org> on 2013-03-22
Reviewed by Kentaro Hara.
No new tests, no functional change.
- GNUmakefile.list.am:
- Modules/geolocation/GeolocationClient.h: Renamed from Source/WebCore/page/GeolocationClient.h.
(WebCore):
(GeolocationClient):
(WebCore::GeolocationClient::~GeolocationClient):
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- 1:29 AM Changeset in webkit [146574] by
-
- 2 edits in trunk/LayoutTests
Add a flaky crash test expectations on Mac WebKit2 per bug 113020.
- platform/mac-wk2/TestExpectations:
- 1:24 AM Changeset in webkit [146573] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Skipping fast/dom/custom tests as the custom elements support is not yet enabled
on the GTK port. Adding crashing expectations for two IDB tests that regressed with r146540.
- 1:12 AM Changeset in webkit [146572] by
-
- 35 edits14 deletes in trunk
Unreviewed, rolling out r146534 and r146565.
http://trac.webkit.org/changeset/146534
http://trac.webkit.org/changeset/146565
https://bugs.webkit.org/show_bug.cgi?id=113017
"r146534 caused perf regression on Chromium Linux x64"
(Requested by yurys on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-22
Source/WebCore:
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrSetter):
(GenerateOverloadedFunction):
(GenerateFunctionCallback):
(GenerateFunction):
(GenerateParametersCheck):
(GenerateSingleConstructorCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):
(GenerateFunctionCallString):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
- bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore):
- bindings/v8/CustomElementHelpers.cpp:
- bindings/v8/CustomElementHelpers.h:
(WebCore):
(CustomElementHelpers):
- bindings/v8/V8DOMConfiguration.cpp:
(WebCore::V8DOMConfiguration::batchConfigureCallbacks):
(WebCore::V8DOMConfiguration::configureTemplate):
- bindings/v8/V8DOMConfiguration.h:
(BatchedMethod):
(V8DOMConfiguration):
- bindings/v8/V8RecursionScope.cpp:
(WebCore::V8RecursionScope::didLeaveScriptContext):
- dom/CustomElementConstructor.cpp:
(WebCore::CustomElementConstructor::createElement):
- dom/CustomElementConstructor.h:
(CustomElementConstructor):
- dom/CustomElementRegistry.cpp:
(WebCore::CustomElementRegistry::~CustomElementRegistry):
- dom/CustomElementRegistry.h:
(WebCore):
(CustomElementRegistry):
- dom/Document.cpp:
(WebCore::Document::createElement):
(WebCore::Document::registerElement):
- dom/Document.h:
- dom/Document.idl:
- dom/Element.cpp:
(WebCore::Element::parserSetAttributes):
(WebCore::Element::cloneAttributesFromElement):
- dom/Element.h:
- dom/Element.idl:
- dom/Node.idl:
- dom/ShadowRoot.idl:
- html/HTMLElement.idl:
- html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::runScript):
Source/WebKit/chromium:
- src/WebKit.cpp:
Source/WTF:
- wtf/HashSet.h:
(WTF):
(WTF::copyToVector):
LayoutTests:
- fast/dom/custom/lifecycle-ready-createElement-recursion-expected.txt: Removed.
- fast/dom/custom/lifecycle-ready-createElement-recursion.html: Removed.
- fast/dom/custom/lifecycle-ready-createElement-reentrancy-expected.txt: Removed.
- fast/dom/custom/lifecycle-ready-createElement-reentrancy.html: Removed.
- fast/dom/custom/lifecycle-ready-creation-api-expected.txt: Removed.
- fast/dom/custom/lifecycle-ready-creation-api.html: Removed.
- fast/dom/custom/lifecycle-ready-innerHTML-expected.txt: Removed.
- fast/dom/custom/lifecycle-ready-innerHTML.html: Removed.
- fast/dom/custom/lifecycle-ready-parser-only-expected.html: Removed.
- fast/dom/custom/lifecycle-ready-parser-only.html: Removed.
- fast/dom/custom/lifecycle-ready-parser-script-expected.txt: Removed.
- fast/dom/custom/lifecycle-ready-parser-script.html: Removed.
- fast/dom/custom/lifecycle-ready-paste-expected.txt: Removed.
- fast/dom/custom/lifecycle-ready-paste.html: Removed.
- 1:07 AM Changeset in webkit [146571] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Memory leak in AudioFileReader::createBus()
https://bugs.webkit.org/show_bug.cgi?id=112925
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-22
Reviewed by Martin Robinson.
Adopt the reference returned by g_timeout_source_new()
to fix a memory leak.
No new tests. No change in behavior.
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::createBus):
- 12:52 AM Changeset in webkit [146570] by
-
- 11 edits2 moves in trunk/Source/WebCore
Move page/Coordinates.[h|idl] to Modules/geolocation/
https://bugs.webkit.org/show_bug.cgi?id=112945
Patch by Steve Block <steveblock@chromium.org> on 2013-03-22
Reviewed by Kentaro Hara.
No new tests, no functional change.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Modules/geolocation/Coordinates.h: Renamed from Source/WebCore/page/Coordinates.h.
(WebCore):
(Coordinates):
(WebCore::Coordinates::create):
(WebCore::Coordinates::isolatedCopy):
(WebCore::Coordinates::latitude):
(WebCore::Coordinates::longitude):
(WebCore::Coordinates::altitude):
(WebCore::Coordinates::accuracy):
(WebCore::Coordinates::altitudeAccuracy):
(WebCore::Coordinates::heading):
(WebCore::Coordinates::speed):
(WebCore::Coordinates::canProvideAltitude):
(WebCore::Coordinates::canProvideAltitudeAccuracy):
(WebCore::Coordinates::canProvideHeading):
(WebCore::Coordinates::canProvideSpeed):
(WebCore::Coordinates::Coordinates):
- Modules/geolocation/Coordinates.idl: Renamed from Source/WebCore/page/Coordinates.idl.
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- 12:41 AM Changeset in webkit [146569] by
-
- 2 edits in trunk/LayoutTests
Add a flaky test failure expectation per bug 113012.
- platform/win/TestExpectations:
- 12:36 AM Changeset in webkit [146568] by
-
- 3 edits in trunk/Source/JavaScriptCore
Leak bots erroneously report JSC::WatchpointSet as leaking
https://bugs.webkit.org/show_bug.cgi?id=107781
Reviewed by Filip Pizlo.
Since leaks doesn't support tagged pointers, avoid using it by flipping the bit flag to indicate
the entry is "fat". We set the flag when the entry is NOT fat; i.e. slim.
Replaced FatFlag by SlimFlag and initialized m_bits with this flag to indicate that the entry is
initially "slim".
- runtime/SymbolTable.cpp:
(JSC::SymbolTableEntry::copySlow): Don't set FatFlag since it has been replaced by SlimFlag.
(JSC::SymbolTableEntry::inflateSlow): Ditto.
- runtime/SymbolTable.h:
(JSC::SymbolTableEntry::Fast::Fast): Set SlimFlag by default.
(JSC::SymbolTableEntry::Fast::isNull): Ignore SlimFlag.
(JSC::SymbolTableEntry::Fast::isFat): An entry is fat when m_bits is not entirely zero and SlimFlag
is not set.
(JSC::SymbolTableEntry::SymbolTableEntry): Set SlimFlag by default.
(JSC::SymbolTableEntry::SymbolTableEntry::getFast): Set SlimFlag when creating Fast from a fat entry.
(JSC::SymbolTableEntry::isNull): Ignore SlimFlag.
(JSC::SymbolTableEntry::FatEntry::FatEntry): Strip SlimFlag.
(JSC::SymbolTableEntry::isFat): An entry is fat when m_bits is not entirely zero and SlimFlag is unset.
(JSC::SymbolTableEntry::fatEntry): Don't strip FatFlag as this flag doesn't exist anymore.
(JSC::SymbolTableEntry::pack): Preserve SlimFlag.
(JSC::SymbolTableIndexHashTraits): empty value is no longer zero so don't set emptyValueIsZero true.
- 12:25 AM WebKitGTK/2.0.x edited by
- (diff)
- 12:19 AM Changeset in webkit [146567] by
-
- 2 edits in trunk/LayoutTests
Final Mac rebaseline attempt for r146531 since r146564 wasn't enough.
I'm sorry I made a huge mess here.
- platform/mac/compositing/rtl/rtl-fixed-expected.txt:
- 12:09 AM Changeset in webkit [146566] by
-
- 2 edits in trunk/LayoutTests
[chromium] Mark virtual/gpu/fast/canvas/canvas-toDataURL-webp.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=93310
Unreviewed test expectations update.
libwebp will be updated to 0.3.0 in chrome changing the encoder
output after which this test will need to be rebaselined.
Patch by James Zern <jzern@chromium.org> on 2013-03-22
- platform/chromium/TestExpectations:
