Timeline
Apr 4, 2013:
- 11:55 PM Changeset in webkit [147714] by
-
- 1 edit1 delete in trunk/Source/WebKit
Remove Webkit/chromium
https://bugs.webkit.org/show_bug.cgi?id=113998
Reviewed by Ryosuke Niwa.
O Knights of Ni, you are just and fair, and we will return with a shrubbery.
- chromium: Removed.
- 11:46 PM Changeset in webkit [147713] by
-
- 2 edits in trunk/Source/WebCore
WinCairo build fails to link.
https://bugs.webkit.org/show_bug.cgi?id=113873
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-04-04
Reviewed by Brent Fulgham.
Removed double guards for USE(ACCELERATED_COMPOSITING),
and moved methods out of USE(ACCELERATED_COMPOSITING) guard to fix linker errors.
- page/FrameView.cpp:
(WebCore::FrameView::setWantsLayerForTopOverHangArea):
(WebCore::FrameView::setWantsLayerForBottomOverHangArea):
(WebCore::FrameView::setWantsLayerForHeader):
(WebCore::FrameView::setWantsLayerForFooter):
(WebCore::FrameView::setHeaderHeight):
(WebCore::FrameView::setFooterHeight):
- 11:39 PM Changeset in webkit [147712] by
-
- 1 edit2 deletes in trunk
Remove the top level gyp directory and Platform/chromium
https://bugs.webkit.org/show_bug.cgi?id=113999
Reviewed by Benjamin Poulain.
.:
- Source/Platform: Removed.
- Source/gyp: Removed.
Source/Platform:
- Platform.gyp: Removed.
- Platform.gyp/.gitignore: Removed.
- Platform.gyp/Platform.gyp: Removed.
- Platform.gypi: Removed.
- chromium: Removed.
- chromium/public: Removed.
- chromium/public/Platform.h: Removed.
- chromium/public/WebAnimation.h: Removed.
- chromium/public/WebAnimationCurve.h: Removed.
- chromium/public/WebAnimationDelegate.h: Removed.
- chromium/public/WebAudioBus.h: Removed.
- chromium/public/WebAudioDestinationConsumer.h: Removed.
- chromium/public/WebAudioDevice.h: Removed.
- chromium/public/WebBlobData.h: Removed.
- chromium/public/WebBlobRegistry.h: Removed.
- chromium/public/WebCString.h: Removed.
- chromium/public/WebCanvas.h: Removed.
- chromium/public/WebClipboard.h: Removed.
- chromium/public/WebColor.h: Removed.
- chromium/public/WebCommon.h: Removed.
- chromium/public/WebCompositorOutputSurface.h: Removed.
- chromium/public/WebCompositorSupport.h: Removed.
- chromium/public/WebContentLayer.h: Removed.
- chromium/public/WebContentLayerClient.h: Removed.
- chromium/public/WebCookie.h: Removed.
- chromium/public/WebCookieJar.h: Removed.
- chromium/public/WebData.h: Removed.
- chromium/public/WebDiscardableMemory.h: Removed.
- chromium/public/WebDragData.h: Removed.
- chromium/public/WebExternalTextureLayer.h: Removed.
- chromium/public/WebExternalTextureLayerClient.h: Removed.
- chromium/public/WebFileError.h: Removed.
- chromium/public/WebFileInfo.h: Removed.
- chromium/public/WebFileSystem.h: Removed.
- chromium/public/WebFileSystemCallbacks.h: Removed.
- chromium/public/WebFileSystemEntry.h: Removed.
- chromium/public/WebFileSystemType.h: Removed.
- chromium/public/WebFileUtilities.h: Removed.
- chromium/public/WebFilterOperation.h: Removed.
- chromium/public/WebFilterOperations.h: Removed.
- chromium/public/WebFlingAnimator.h: Removed.
- chromium/public/WebFloatAnimationCurve.h: Removed.
- chromium/public/WebFloatKeyframe.h: Removed.
- chromium/public/WebFloatPoint.h: Removed.
- chromium/public/WebFloatQuad.h: Removed.
- chromium/public/WebFloatRect.h: Removed.
- chromium/public/WebFloatSize.h: Removed.
- chromium/public/WebGamepad.h: Removed.
- chromium/public/WebGamepads.h: Removed.
- chromium/public/WebGestureCurve.h: Removed.
- chromium/public/WebGestureCurveTarget.h: Removed.
- chromium/public/WebGraphicsContext3D.h: Removed.
- chromium/public/WebGraphicsMemoryAllocation.h: Removed.
- chromium/public/WebGraphicsMemoryStats.h: Removed.
- chromium/public/WebHTTPBody.h: Removed.
- chromium/public/WebHTTPHeaderVisitor.h: Removed.
- chromium/public/WebHTTPLoadInfo.h: Removed.
- chromium/public/WebHyphenator.h: Removed.
- chromium/public/WebImage.h: Removed.
- chromium/public/WebImageLayer.h: Removed.
- chromium/public/WebInputHandler.h: Removed.
- chromium/public/WebInputHandlerClient.h: Removed.
- chromium/public/WebLayer.h: Removed.
- chromium/public/WebLayerPositionConstraint.h: Removed.
- chromium/public/WebLayerScrollClient.h: Removed.
- chromium/public/WebLayerTreeView.h: Removed.
- chromium/public/WebLocalizedString.h: Removed.
- chromium/public/WebMediaConstraints.h: Removed.
- chromium/public/WebMediaStream.h: Removed.
- chromium/public/WebMediaStreamCenter.h: Removed.
- chromium/public/WebMediaStreamCenterClient.h: Removed.
- chromium/public/WebMediaStreamSource.h: Removed.
- chromium/public/WebMediaStreamSourcesRequest.h: Removed.
- chromium/public/WebMediaStreamTrack.h: Removed.
- chromium/public/WebMessagePortChannel.h: Removed.
- chromium/public/WebMessagePortChannelClient.h: Removed.
- chromium/public/WebMimeRegistry.h: Removed.
- chromium/public/WebNonCopyable.h: Removed.
- chromium/public/WebPluginListBuilder.h: Removed.
- chromium/public/WebPoint.h: Removed.
- chromium/public/WebPrerender.h: Removed.
- chromium/public/WebPrerenderingSupport.h: Removed.
- chromium/public/WebPrivateOwnPtr.h: Removed.
- chromium/public/WebPrivatePtr.h: Removed.
- chromium/public/WebRTCConfiguration.h: Removed.
- chromium/public/WebRTCDTMFSenderHandler.h: Removed.
- chromium/public/WebRTCDTMFSenderHandlerClient.h: Removed.
- chromium/public/WebRTCDataChannelHandler.h: Removed.
- chromium/public/WebRTCDataChannelHandlerClient.h: Removed.
- chromium/public/WebRTCICECandidate.h: Removed.
- chromium/public/WebRTCPeerConnectionHandler.h: Removed.
- chromium/public/WebRTCPeerConnectionHandlerClient.h: Removed.
- chromium/public/WebRTCSessionDescription.h: Removed.
- chromium/public/WebRTCSessionDescriptionRequest.h: Removed.
- chromium/public/WebRTCStatsRequest.h: Removed.
- chromium/public/WebRTCStatsResponse.h: Removed.
- chromium/public/WebRTCVoidRequest.h: Removed.
- chromium/public/WebRect.h: Removed.
- chromium/public/WebReferrerPolicy.h: Removed.
- chromium/public/WebRenderingStats.h: Removed.
- chromium/public/WebScreenInfo.h: Removed.
- chromium/public/WebScrollbar.h: Removed.
- chromium/public/WebScrollbarLayer.h: Removed.
- chromium/public/WebScrollbarThemeGeometry.h: Removed.
- chromium/public/WebScrollbarThemePainter.h: Removed.
- chromium/public/WebSize.h: Removed.
- chromium/public/WebSocketStreamError.h: Removed.
- chromium/public/WebSocketStreamHandle.h: Removed.
- chromium/public/WebSocketStreamHandleClient.h: Removed.
- chromium/public/WebSolidColorLayer.h: Removed.
- chromium/public/WebSpeechSynthesisUtterance.h: Removed.
- chromium/public/WebSpeechSynthesisVoice.h: Removed.
- chromium/public/WebSpeechSynthesizer.h: Removed.
- chromium/public/WebSpeechSynthesizerClient.h: Removed.
- chromium/public/WebStorageArea.h: Removed.
- chromium/public/WebStorageNamespace.h: Removed.
- chromium/public/WebString.h: Removed.
- chromium/public/WebThread.h: Removed.
- chromium/public/WebThreadSafeData.h: Removed.
- chromium/public/WebTransformAnimationCurve.h: Removed.
- chromium/public/WebTransformKeyframe.h: Removed.
- chromium/public/WebTransformOperations.h: Removed.
- chromium/public/WebURL.h: Removed.
- chromium/public/WebURLError.h: Removed.
- chromium/public/WebURLLoadTiming.h: Removed.
- chromium/public/WebURLLoader.h: Removed.
- chromium/public/WebURLLoaderClient.h: Removed.
- chromium/public/WebURLRequest.h: Removed.
- chromium/public/WebURLResponse.h: Removed.
- chromium/public/WebUnitTestSupport.h: Removed.
- chromium/public/WebVector.h: Removed.
- chromium/public/WebWorkerRunLoop.h: Removed.
- chromium/public/android: Removed.
- chromium/public/android/WebSandboxSupport.h: Removed.
- chromium/public/android/WebThemeEngine.h: Removed.
- chromium/public/default: Removed.
- chromium/public/default/WebThemeEngine.h: Removed.
- chromium/public/linux: Removed.
- chromium/public/linux/WebFontFamily.h: Removed.
- chromium/public/linux/WebFontInfo.h: Removed.
- chromium/public/linux/WebFontRenderStyle.h: Removed.
- chromium/public/linux/WebSandboxSupport.h: Removed.
- chromium/public/mac: Removed.
- chromium/public/mac/WebSandboxSupport.h: Removed.
- chromium/public/mac/WebThemeEngine.h: Removed.
- chromium/public/win: Removed.
- chromium/public/win/WebSandboxSupport.h: Removed.
- chromium/public/win/WebThemeEngine.h: Removed.
- chromium/src: Removed.
- chromium/src/Platform.cpp: Removed.
- chromium/src/WebActiveGestureAnimation.cpp: Removed.
- chromium/src/WebActiveGestureAnimation.h: Removed.
- chromium/src/WebCString.cpp: Removed.
- chromium/src/WebFilterOperation.cpp: Removed.
- chromium/src/WebFilterOperations.cpp: Removed.
- chromium/src/WebFloatQuad.cpp: Removed.
- chromium/src/WebPrerenderingSupport.cpp: Removed.
- chromium/src/WebString.cpp: Removed.
- 11:20 PM Changeset in webkit [147711] by
-
- 2 edits in trunk/Tools
Remove ChromiumPublicApi pattern, and cc/message rules for it.
- Scripts/webkitpy/common/config/watchlist:
- 11:05 PM Changeset in webkit [147710] by
-
- 37 edits in trunk/Source/WebCore
Remove code for 10.5 and earlier from Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=113754
Reviewed by Benjamin Poulain.
Removed the code for 10.5 and removed if-def for 10.6.
- WebCore.xcodeproj/project.pbxproj:
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):
- platform/LocalizedStrings.cpp:
(WebCore::imageTitle):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setAllowsFontSmoothing):
- platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPattern):
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::clear):
- platform/graphics/cg/PathCG.cpp:
(WebCore::Path::boundingRect):
- platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore):
(WebCore::FontPlatformData::ctFont):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::supportsFullscreen):
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
- platform/graphics/mac/FontCacheMac.mm:
(WebCore):
(WebCore::fontCacheRegisteredFontsChangedNotificationCallback):
(WebCore::FontCache::platformInit):
- platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::supportsFullscreen):
(WebCore::MediaPlayerPrivateQTKit::setClosedCaptionsVisible):
(WebCore::MediaPlayerPrivateQTKit::cacheMovieScale):
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
- platform/graphics/mac/WebLayer.h:
- platform/mac/CursorMac.mm:
(WebCore::Cursor::ensurePlatformCursor):
- platform/mac/DisplaySleepDisabler.cpp:
(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
(WebCore):
- platform/mac/DisplaySleepDisabler.h:
(DisplaySleepDisabler):
- platform/mac/EmptyProtocolDefinitions.h:
- platform/mac/HTMLConverter.h:
- platform/mac/HTMLConverter.mm:
- platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenuMac::populate):
- platform/mac/ScrollElasticityController.mm:
(systemUptime):
- platform/mac/SharedTimerMac.mm:
(PowerObserver):
(WebCore::PowerObserver::PowerObserver):
(WebCore::PowerObserver::~PowerObserver):
(WebCore::PowerObserver::didReceiveSystemPowerNotification):
- platform/mac/SuddenTermination.mm:
- platform/mac/WebCoreFullScreenWindow.mm:
(-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):
- platform/mac/WebFontCache.mm:
(+[WebFontCache getTraits:inFamily:]):
(+[WebFontCache internalFontWithFamily:traits:weight:size:]):
- platform/mac/WebVideoFullscreenController.mm:
(SOFT_LINK_POINTER):
(-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
- platform/mac/WebVideoFullscreenHUDWindowController.mm:
(createControlWithMediaUIControlType):
(-[WebVideoFullscreenHUDWindowController windowDidLoad]):
- platform/network/Credential.h:
- platform/network/cf/DNSCFNet.cpp:
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
- platform/network/cf/ProxyServerCFNet.cpp:
(WebCore):
(WebCore::proxyServersForURL):
- platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::chooseProxy):
- platform/network/mac/AuthenticationMac.mm:
(WebCore):
- platform/network/mac/WebCoreURLResponse.mm:
(WebCore::adjustMIMETypeIfNecessary):
- platform/text/TextChecking.h:
(WebCore):
- 10:36 PM Changeset in webkit [147709] by
-
- 3 edits in trunk/Tools
Temporarily disable the Python unittests broken by the commit queue not running layout tests
https://bugs.webkit.org/show_bug.cgi?id=113997
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Ryosuke Niwa.
Disable the tests until Ryosuke gets the time and hardware to have
a testing commit-queue.
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(CommitQueueTaskTest):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(CommitQueueTest):
- 10:24 PM Changeset in webkit [147708] by
-
- 2 edits in trunk/Source/WebCore
Qt build fix attempt after r147684.
- html/canvas/CanvasRenderingContext.cpp:
- 10:17 PM Changeset in webkit [147707] by
-
- 2 edits in trunk/Tools
Remove Chromium builders from build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=113990
Reviewed by Benjamin Poulain.
Land the part to disable triggering of Chromium builders first so that we may start
deleting more Chromium code that breaks the update step.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 9:57 PM Changeset in webkit [147706] by
-
- 1 edit1 delete in trunk
Nixed the defunct chromium folder from ManualTests
https://bugs.webkit.org/show_bug.cgi?id=113995
Reviewed by Benjamin Poulain.
- ManualTests/chromium: Removed.
- ManualTests/chromium/autofill-popup-shiftupdown.hml: Removed.
- ManualTests/chromium/drag-image-accounts-for-device-scale.html: Removed.
- ManualTests/chromium/modifiers-during-drag-and-drop.html: Removed.
- ManualTests/chromium/no-autofill-on-readonly.html: Removed.
- ManualTests/chromium/onchange-reload-popup.html: Removed.
- ManualTests/chromium/popup-menu-crash.html: Removed.
- ManualTests/chromium/select-close-popup-value-change.html: Removed.
- ManualTests/chromium/suggestions-popup-font-change.html: Removed.
- 9:53 PM Changeset in webkit [147705] by
-
- 2 edits in trunk/Tools
Remove Chromium's DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=113989
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Kent Tamura.
On second thought, let's not go to Camelot. It is a silly place.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
- 9:46 PM Changeset in webkit [147704] by
-
- 1 edit1 delete in trunk/Tools
Nixed the defunct chromium folder from DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=113993
Reviewed by Ryosuke Niwa.
- DumpRenderTree/chromium: Removed.
- DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
- DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
- DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
- DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
- DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
- DumpRenderTree/chromium/ImageDiff.cpp: Removed.
- DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
- DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
- DumpRenderTree/chromium/MockPlatform.cpp: Removed.
- DumpRenderTree/chromium/MockPlatform.h: Removed.
- DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
- DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
- DumpRenderTree/chromium/Task.cpp: Removed.
- DumpRenderTree/chromium/Task.h: Removed.
- DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
- DumpRenderTree/chromium/TestEventPrinter.h: Removed.
- DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
- DumpRenderTree/chromium/TestNavigationController.h: Removed.
- DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
- DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
- DumpRenderTree/chromium/TestRunner: Removed.
- DumpRenderTree/chromium/TestRunner/public: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
- DumpRenderTree/chromium/TestRunner/src: Removed.
- DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
- DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
- DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
- DumpRenderTree/chromium/TestShell.cpp: Removed.
- DumpRenderTree/chromium/TestShell.h: Removed.
- DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
- DumpRenderTree/chromium/TestShellMac.mm: Removed.
- DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
- DumpRenderTree/chromium/TestShellStub.cpp: Removed.
- DumpRenderTree/chromium/TestShellWin.cpp: Removed.
- DumpRenderTree/chromium/TestShellX11.cpp: Removed.
- DumpRenderTree/chromium/WebViewHost.cpp: Removed.
- DumpRenderTree/chromium/WebViewHost.h: Removed.
- DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
- DumpRenderTree/chromium/android_main_fonts.xml: Removed.
- DumpRenderTree/chromium/config.h: Removed.
- DumpRenderTree/chromium/fonts.conf: Removed.
- 9:40 PM Changeset in webkit [147703] by
-
- 1 edit1 delete in trunk/Source/WTF
Nixed the defunct chromium folder from WTF
https://bugs.webkit.org/show_bug.cgi?id=113992
Reviewed by Ryosuke Niwa.
- wtf/chromium: Removed.
- wtf/chromium/ChromiumThreading.h: Removed.
- wtf/chromium/MainThreadChromium.cpp: Removed.
- 9:39 PM Changeset in webkit [147702] by
-
- 2 edits in trunk/Source/WebCore
alternateFamilyName should return a null, not an empty value
https://bugs.webkit.org/show_bug.cgi?id=113987
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Anders Carlsson.
The string object corresponding semantically to "no-value" is
a null string, not an empty string.
Fix alternateFamilyName() accordingly.
- platform/graphics/FontCache.cpp:
(WebCore::alternateFamilyName):
(WebCore::FontCache::getCachedFontPlatformData):
- 8:46 PM Changeset in webkit [147701] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] DOMSupport::isFixedPositionOrHasFixedPositionAncestor stops traversing render tree when it hits an iframe element
https://bugs.webkit.org/show_bug.cgi?id=113944
Patch by Andrew Lo <anlo@rim.com> on 2013-04-04
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
Internal PR 320732.
When checking whether a RenderObject is fixed position or has a fixed position
ancestor, we traverse the render tree upwards.
When we reach the root of the tree, check whether the root is an
iframe and has an element owner. If so, we also need to continue iterating
up the tree from the owner to see if the iframe is a descendant of a fixed
position element.
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isFixedPositionOrHasFixedPositionAncestor):
- 7:52 PM Changeset in webkit [147700] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Add support for getting page contents as string
https://bugs.webkit.org/show_bug.cgi?id=106752
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-04-04
Reviewed by Andreas Kling.
Modified ewk_view_page_contents_get() API to get page contents as string.
EWK_PAGE_CONTENTS_TYPE_STRING is added to Ewk_Page_Contents_Type.
Now, we can use both EWK_PAGE_CONTENTS_TYPE_MHTML and EWK_PAGE_CONTENTS_TYPE_STRING
for getting page contents.
- UIProcess/API/efl/ewk_view.cpp:
(Ewk_Page_Contents_Context):
(ewkViewPageContentsAsMHTMLCallback):
(ewkViewPageContentsAsStringCallback):
(ewk_view_page_contents_get):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(PageContentsAsMHTMLCallback):
(PageContentsAsStringCallback):
(TEST_F):
- 7:51 PM Changeset in webkit [147699] by
-
- 1 edit1 add7 deletes in trunk/LayoutTests
Change class_as_selector-expected.html to be a ref-test
https://bugs.webkit.org/show_bug.cgi?id=113970
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Geoffrey Garen.
The test checks style can be applied to text with a CSS class.
The reference is done by applying a style attribute directly
on each element.
- css1/basic/class_as_selector-expected.html: Added.
- platform/efl/css1/basic/class_as_selector-expected.png: Removed.
- platform/efl/css1/basic/class_as_selector-expected.txt: Removed.
- platform/gtk/css1/basic/class_as_selector-expected.txt: Removed.
- platform/mac/css1/basic/class_as_selector-expected.png: Removed.
- platform/mac/css1/basic/class_as_selector-expected.txt: Removed.
- platform/qt/css1/basic/class_as_selector-expected.png: Removed.
- platform/qt/css1/basic/class_as_selector-expected.txt: Removed.
- 7:48 PM Changeset in webkit [147698] by
-
- 2 edits in trunk/LayoutTests
Unskip 3 backface-visibility tests on OS X
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
- platform/mac/TestExpectations:
The 3 pixel tests pass on WebKit1 and WebKit2.
- 7:43 PM Changeset in webkit [147697] by
-
- 2 edits in trunk/Websites/webkit.org
Update WebKit.org's contact page
https://bugs.webkit.org/show_bug.cgi?id=113968
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Geoffrey Garen.
- contact.html:
-Add a direct link to our archives on Gmane.
-References the ports mailing-lists. This may reduces the emails
erroneously sent to webkit-dev.
-Add a link to our "reporting bug page".
-Get rid of the link to CIA. The website is dead.
- 7:39 PM Changeset in webkit [147696] by
-
- 1 edit1 delete in trunk/Tools
Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
Rubber stamped by Benjamin Poulain.
- RebaselineQueueServer: Removed.
- RebaselineQueueServer/app.yaml: Removed.
- RebaselineQueueServer/handlers: Removed.
- RebaselineQueueServer/handlers/init.py: Removed.
- RebaselineQueueServer/handlers/builderqueue.py: Removed.
- RebaselineQueueServer/handlers/pages.py: Removed.
- RebaselineQueueServer/index.yaml: Removed.
- RebaselineQueueServer/main.py: Removed.
- RebaselineQueueServer/model: Removed.
- RebaselineQueueServer/model/init.py: Removed.
- RebaselineQueueServer/model/queueentry.py: Removed.
- RebaselineQueueServer/static: Removed.
- RebaselineQueueServer/static/builder-frame-empty.html: Removed.
- RebaselineQueueServer/static/styles.css: Removed.
- RebaselineQueueServer/templates: Removed.
- RebaselineQueueServer/templates/builder-picker.html: Removed.
- RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
- RebaselineQueueServer/templates/builder-queue-list.html: Removed.
- RebaselineQueueServer/templates/home.html: Removed.
- 7:35 PM Changeset in webkit [147695] by
-
- 3 edits in trunk/Tools
Fix setup-commit-queue and temporarily disable testing on commit-queue
https://bugs.webkit.org/show_bug.cgi?id=113979
Reviewed by Benjamin Poulain.
Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
- EWSTools/setup-commit-queue.sh:
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
(CommitQueueTask.run):
- 6:32 PM WebKit Team edited by
- Updates yosin@'s knowledge area (diff)
- 6:29 PM Changeset in webkit [147694] by
-
- 2 edits in trunk/Source/WebCore
Work around a bug in the bindings generation script.
- WebCore.xcodeproj/project.pbxproj:
- 6:25 PM Changeset in webkit [147693] by
-
- 4 edits in trunk/Source/WebCore
Don't dispatch delayed click if snapshotted plugin was triggered by a click on the label
https://bugs.webkit.org/show_bug.cgi?id=113982
Reviewed by Tim Horton.
We regressed the way clicks were sent on to restarted plugins when we moved to a
Shadow Root - we were always sending the click. We should only send the click
on if the user clicked on the main plugin content, and not send it when you
click directly on the label.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Keep a reference to the container and label.
(WebCore::HTMLPlugInImageElement::partOfSnapshotLabel): New method that detects if a Node was part
of the snapshot label.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Only record the event if you should forward it on.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): New parameter to userDidClickSnapshot and member variables for shadow content.
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::handleEvent): Ask the plugin if the clicked target was the snapshot label.
- 5:59 PM Changeset in webkit [147692] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed EFL build fix.
Add missing include for FloatRect.h.
- platform/efl/PlatformScreenEfl.cpp:
- 5:54 PM Changeset in webkit [147691] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix.
- platform/graphics/GlyphPageTreeNode.cpp:
- 5:44 PM Changeset in webkit [147690] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed EFL build fix.
We had undefined reference to `JSC::CodeOrigin::maximumBytecodeIndex'.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::findClosureCallForReturnPC):
(JSC::CodeBlock::bytecodeOffset):
- 5:37 PM Changeset in webkit [147689] by
-
- 3 edits in trunk/Source/WebCore
Another build fix.
- platform/graphics/FontCache.cpp:
- platform/graphics/SimpleFontData.cpp:
- 5:28 PM Changeset in webkit [147688] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- WebCore.xcodeproj/project.pbxproj:
- 5:26 PM Changeset in webkit [147687] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Adjust fatfinger result priority
https://bugs.webkit.org/show_bug.cgi?id=113957
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-04-04
Reviewed by Rob Buis.
RIM PR 224781
Internally Reviewed by Genevieve Mak.
Change fatfigner algorithm, return the clickable element rather than
its parent anchor. Modify taphighlight and context menu node selection
accordingly.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::findBestPoint):
- WebKitSupport/FatFingers.h:
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::elementForTapHighlight):
- 5:15 PM Changeset in webkit [147686] by
-
- 2 edits in trunk/Source/WebCore
Removed empty files from the build
https://bugs.webkit.org/show_bug.cgi?id=113978
Reviewed by Anders Carlsson.
Anders made a list of all the empty files that are slowing down the Mac
build, and I grepped them away.
- WebCore.xcodeproj/project.pbxproj:
- 5:08 PM Changeset in webkit [147685] by
-
- 2 edits in trunk/Tools
temporarily make flakiness dashboard work again webkit.org bots
https://bugs.webkit.org/show_bug.cgi?id=113972
Reviewed by Ojan Vafai.
This patch disables the chromium.org layout test bots TestExpectations
parsing temporarily until we can work out the right way to split into
two instances for webkit.org and chromium.org and figure out which
code to delete where :).
- TestResultServer/static-dashboards/flakiness_dashboard.js:
- 5:08 PM Changeset in webkit [147684] by
-
- 42 edits1 copy1 add in trunk/Source/WebCore
Prune unneeded header #includes
https://bugs.webkit.org/show_bug.cgi?id=113973
Reviewed by Geoffrey Garen.
Reduce the amount of headers included by other headers by:
- Moving implicit and explicit constructors and destructors into .cpp files so member variable constructors/destructors don't have to be declared.
- Move CachedResourceClient subclasses out into separate headers so that their respective CachedResource subclasses don't have to be included by the classes that derive from those subclasses.
- Remove headers that were never needed in the first place.
- Modules/webaudio/AudioContext.h:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMWindowCustom.cpp:
- css/CSSFontFaceSource.h:
- html/canvas/CanvasPattern.cpp:
(WebCore::CanvasPattern::create):
(WebCore::CanvasPattern::CanvasPattern):
(WebCore::CanvasPattern::~CanvasPattern):
- html/canvas/CanvasPattern.h:
(WebCore::CanvasPattern::pattern):
(WebCore::CanvasPattern::originClean):
- html/parser/HTMLScriptRunner.h:
- loader/ImageLoader.h:
- loader/LinkLoader.h:
- loader/TextTrackLoader.h:
- loader/cache/CachedFont.cpp:
- loader/cache/CachedFont.h:
- loader/cache/CachedFontClient.h: Added.
(WebCore::CachedFontClient::~CachedFontClient):
(WebCore::CachedFontClient::expectedType):
(WebCore::CachedFontClient::resourceClientType):
(WebCore::CachedFontClient::fontLoaded):
- loader/cache/CachedResourceHandle.cpp:
(WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::setResource):
- loader/cache/CachedResourceHandle.h:
(WebCore::CachedResourceHandleBase::get):
(WebCore::CachedResourceHandleBase::operator!):
(WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType):
(WebCore::CachedResourceHandleBase::operator=):
(WebCore::CachedResourceHandle::CachedResourceHandle):
(WebCore::CachedResourceHandle::get):
(WebCore::CachedResourceHandle::operator->):
(WebCore::CachedResourceHandle::operator=):
(WebCore::CachedResourceHandle::operator==):
(WebCore::CachedResourceHandle::operator!=):
(WebCore::operator==):
(WebCore::operator!=):
- loader/cache/CachedSVGDocument.h:
- loader/cache/CachedSVGDocumentReference.h:
- loader/cache/CachedSVGDocumentClient.h: Added.
(WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::expectedType):
(WebCore::CachedSVGDocumentClient::resourceClientType):
- loader/cache/CachedStyleSheetClient.h:
- platform/PlatformScreen.h:
- platform/audio/HRTFElevation.cpp:
- platform/audio/HRTFKernel.cpp:
(WebCore::HRTFKernel::fftSize):
- platform/audio/HRTFKernel.h:
- platform/audio/ReverbConvolverStage.cpp:
(WebCore::ReverbConvolverStage::~ReverbConvolverStage):
- platform/audio/ReverbConvolverStage.h:
- platform/graphics/FontPlatformData.h:
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/Path.cpp:
- platform/graphics/Path.h:
- platform/graphics/Pattern.cpp:
- platform/graphics/Pattern.h:
- platform/graphics/filters/FilterOperation.cpp:
(WebCore::ReferenceFilterOperation::ReferenceFilterOperation):
(WebCore::ReferenceFilterOperation::~ReferenceFilterOperation):
(WebCore::ReferenceFilterOperation::setCachedSVGDocumentReference):
- platform/graphics/filters/FilterOperation.h:
- platform/graphics/transforms/AffineTransform.h:
- plugins/DOMMimeType.h:
- rendering/RenderLayerFilterInfo.h:
- rendering/style/StyleCachedShader.h:
- svg/SVGFEImageElement.h:
- svg/SVGFontFaceUriElement.h:
- svg/SVGUseElement.h:
- xml/parser/XMLDocumentParser.h:
- 4:59 PM Changeset in webkit [147683] by
-
- 7 edits in trunk/Source
[Cairo] Stop passing raw pointers to BitmapImage::create()
https://bugs.webkit.org/show_bug.cgi?id=113945
Reviewed by Martin Robinson.
Source/WebCore:
BitmapImage::create() was updated in r147643 to take a PassRefPtr<cairo_surface_t>
in argument instead of a cairo_surface_t*. This patch updates several call sites
so that they now pass in a smart pointer instead of a raw one to avoid silent
converting from cairo_surface_t* to PassRefPtr<cairo_surface_t>.
No new tests, no behavior change.
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBufferData::ImageBufferData): Use RefPtr to m_surface to avoid manual
memory handling.
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::~ImageBuffer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):
- platform/graphics/cairo/ImageBufferDataCairo.h:
(ImageBufferData):
- platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
(ImageGStreamer::ImageGStreamer):
- platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::ImageBuffer::toDataURL):
Source/WebKit2:
Pass a smart pointer in to BitmapImage::create() instead of a raw one
for the cairo surface. The factory method prototype was updated for
cairo in r147643.
- Shared/cairo/ShareableBitmapCairo.cpp:
(WebKit::ShareableBitmap::createImage):
- 4:57 PM Changeset in webkit [147682] by
-
- 4 edits2 adds in trunk
Page content missing when flipping from an empty layer to a tiled layer
https://bugs.webkit.org/show_bug.cgi?id=113977
<rdar://problem/13444219>
Source/WebCore:
Reviewed by Tim Horton.
Some articles on USA Today were missing content on load, when a large GraphicsLayer
which did not draw content needed to draw content (and become tiled in the process).
The bug was an ordering dependency in GraphicsLayerCA::commitLayerChangesBeforeSublayers().
swapFromOrToTiledLayer() sets some dirty flags, but for some properties which have
already been committed in the current flush cycle.
Fix by moving the swapFromOrToTiledLayer() to the top of the commit, which is
safe since it only consults GraphicsLayer properties, not CALayer properties.
Test: compositing/tiling/empty-to-tiled.html
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::updateLayerDrawsContent):
(WebCore::GraphicsLayerCA::updateContentsScale):
- platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
LayoutTests:
Reviewed by Tim Horton.
Ref test that adds visible content to a larger layer.
- compositing/tiling/empty-to-tiled-expected.html: Added.
- compositing/tiling/empty-to-tiled.html: Added.
- 4:56 PM Changeset in webkit [147681] by
-
- 2 edits in trunk/Source/WebCore
Regression(r147639) Causes assertion hit in HashTable
https://bugs.webkit.org/show_bug.cgi?id=113954
Reviewed by Benjamin Poulain.
Lookup the key in the hash table again after the recursive call to
getCachedFontPlatformData() as it may have altered the hash map and
invalidated the previous iterator we had.
No new tests, covered by existing tests.
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::getCachedFontPlatformData):
- 4:52 PM Changeset in webkit [147680] by
-
- 2 edits in trunk/Tools
Fix webkitpy tests after r147678.
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(CommitQueueTest.test_commit_queue):
(test_manual_reject_during_processing):
- 4:35 PM Changeset in webkit [147679] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, fix a test and some results missed in r147675
- media/media-captions-expected.txt:
- media/video-controls-captions-trackmenu-localized.html:
- platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
- 4:18 PM Changeset in webkit [147678] by
-
- 2 edits1 add in trunk/Tools
The commit queue should use Mac MountainLion port
https://bugs.webkit.org/show_bug.cgi?id=113971
Reviewed by Lucas Forschler.
- EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
- Scripts/webkitpy/tool/commands/queues.py:
(CommitQueue):
- 4:16 PM Changeset in webkit [147677] by
-
- 5 edits in trunk/Source/JavaScriptCore
Stop pretending that statements return a value
https://bugs.webkit.org/show_bug.cgi?id=113969
Reviewed by Oliver Hunt.
Expressions have an intrinsic value, which they return to their parent
in the AST.
Statements just execute for effect in sequence.
This patch moves emitBytecode into the ExpressionNode and StatementNode
subclasses, and changes the SatementNode subclass to return void. This
eliminates some cruft where we used to return 0, or try to save a bogus
register and return it, as if a statement had a consuming parent in the
AST.
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitNode):
(BytecodeGenerator):
(JSC::BytecodeGenerator::emitNodeInConditionContext):
- bytecompiler/NodesCodegen.cpp:
(JSC::ConstStatementNode::emitBytecode):
(JSC::BlockNode::emitBytecode):
(JSC::EmptyStatementNode::emitBytecode):
(JSC::DebuggerStatementNode::emitBytecode):
(JSC::ExprStatementNode::emitBytecode):
(JSC::VarStatementNode::emitBytecode):
(JSC::IfNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::CaseClauseNode::emitBytecode):
(JSC::CaseBlockNode::emitBytecodeForBlock):
(JSC::SwitchNode::emitBytecode):
(JSC::LabelNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):
(JSC::TryNode::emitBytecode):
(JSC::ScopeNode::emitStatementsBytecode):
(JSC::ProgramNode::emitBytecode):
(JSC::EvalNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):
(JSC::FuncDeclNode::emitBytecode):
- parser/NodeConstructors.h:
(JSC::PropertyListNode::PropertyListNode):
(JSC::ArgumentListNode::ArgumentListNode):
- parser/Nodes.h:
(Node):
(ExpressionNode):
(StatementNode):
(ConstStatementNode):
(BlockNode):
(EmptyStatementNode):
(DebuggerStatementNode):
(ExprStatementNode):
(VarStatementNode):
(IfNode):
(IfElseNode):
(DoWhileNode):
(WhileNode):
(ForNode):
(ForInNode):
(ContinueNode):
(BreakNode):
(ReturnNode):
(WithNode):
(LabelNode):
(ThrowNode):
(TryNode):
(ProgramNode):
(EvalNode):
(FunctionBodyNode):
(FuncDeclNode):
(CaseBlockNode):
(SwitchNode):
- 3:57 PM Changeset in webkit [147676] by
-
- 2 edits in trunk/LayoutTests
Make fast/events/tabindex-focus-blur-all.html disallow Java so the test runs the same regardless of platform/port
https://bugs.webkit.org/show_bug.cgi?id=113950
Patch by Dave Michael <dmichael@chromium.org> on 2013-04-04
Reviewed by Jer Noble.
This hopefully fixes the test failure seen on Apple Mountain Lion WK2:
http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r147640%20(7636)/results.html
that was introduced in https://bugs.webkit.org/show_bug.cgi?id=32292
- fast/events/resources/tabindex-focus-blur-all.js: Make the test disallow Java execution. Otherwise, <applet> is focusible on platforms that support Java by default and not focusible elsewhere.
- 3:23 PM Changeset in webkit [147675] by
-
- 35 edits in trunk
[Mac] add "automatic" text track menu item
https://bugs.webkit.org/show_bug.cgi?id=113822
Reviewed by Jer Noble.
Source/WebCore:
No new tests, existing tests updated.
- English.lproj/Localizable.strings: Add new track menu item.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_captionDisplayMode.
(WebCore::HTMLMediaElement::finishParsingChildren): LoadTextTrackResource -> ConfigureTextTracks.
(WebCore::HTMLMediaElement::scheduleDelayedAction): Ditto.
(WebCore::HTMLMediaElement::loadTimerFired): Ditto.
(WebCore::HTMLMediaElement::loadInternal): Ditto. Flag the caption menu as invalid so it will
be rebuilt again.
(WebCore::HTMLMediaElement::mediaPlayerDidAddTrack): LoadTextTrackResource -> ConfigureTextTracks.
(WebCore::HTMLMediaElement::didAddTrack): Ditto.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Deal with new track display modes.
(WebCore::HTMLMediaElement::HTMLMediaElement::hasClosedCaptions): Minor cleanup.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Add some logging.
(WebCore::HTMLMediaElement::configureTextTracks): Call updateActiveTextTrackCues so cue display
is updated.
(WebCore::HTMLMediaElement::captionPreferencesChanged): Deal with new track display modes.
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Add some logging.
- html/HTMLMediaElement.h: Ditto.
- html/shadow/MediaControlElementTypes.cpp: Remove trackIndexAttributeName and trackListIndexForElement.
- html/shadow/MediaControlElementTypes.h: Ditto.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler): Don't use track index,
everything we need is in the track<->element map now.
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay): Ditto. Always rebuild the
track list because clear the map each time the menu goes away because it refs every track.
(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu): Don't set the track
index attribute on the menu items, just use the map.
- html/shadow/MediaControlElements.h:
- html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::changedClosedCaptionsVisibility): resetTrackListMenu is gone.
(WebCore::MediaControlsApple::reset): Ditto.
(WebCore::MediaControlsApple::closedCaptionTracksChanged): Ditto.
- html/track/TextTrack.cpp:
(WebCore::TextTrack::captionMenuOffItem): New, static TextTrack used for the menu "Off" item.
(WebCore::TextTrack::captionMenuAutomaticItem): New, static TextTrack used for the menu "Automatic" item.
- html/track/TextTrack.h:
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::shouldShowCaptions): Removed, we use captionDisplayMode instead.
(WebCore::CaptionUserPreferences::captionDisplayMode): New.
(WebCore::CaptionUserPreferences::setCaptionDisplayMode): New.
(WebCore::CaptionUserPreferences::setPreferredLanguage): Make the parameter a const reference.
(WebCore::CaptionUserPreferences::textTrackSelectionScore): Return 0 if the user doesn't want
captions or subtitles.
(WebCore::CaptionUserPreferences::textTrackLanguageSelectionScore): Take language as a parameter
instead of assuming that it is always the entire language list.
- page/CaptionUserPreferences.h:
- page/CaptionUserPreferencesMac.h:
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::shouldShowCaptions): Removed, we use captionDisplayMode instead.
(WebCore::CaptionUserPreferencesMac::captionDisplayMode): New.
(WebCore::CaptionUserPreferencesMac::setCaptionDisplayMode): New.
(WebCore::CaptionUserPreferencesMac::setPreferredLanguage): Make the parameter a const reference.
(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Deal with "Automatic" mode.
captions or subtitles.
(WebCore::CaptionUserPreferences::textTrackLanguageSelectionScore): Take language as a parameter
instead of assuming that it is always the entire language list.
(WebCore::CaptionUserPreferencesMac::sortedTrackListForMenu): Insert "Off" and "Automatic" items.
- platform/LocalizedStrings.cpp:
(WebCore::textTrackAutomaticMenuItemText): New.
- platform/LocalizedStrings.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::languageOfPrimaryAudioTrack): New.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Return the language
of the main audio track.
LayoutTests:
- media/media-captions.html: Opportunistic fix - don't look at state until we get the 'canplaythrough'
event because the media engine state may not have been processed until that time.
- media/track/track-cue-container-rendering-position.html: Don't assume that a cue has been
rendered immediately when the 'canplaythrough' event comes through.
- media/track/track-cue-rendering-mode-changed.html: Ditto.
- media/track/track-in-band-expected.txt: Don't check if cues have loaded, it doesn't matter
for this test.
- media/track/track-in-band.html: Ditto.
- media/track/track-user-preferences-expected.txt: Changed name of utility function from
menuIndexForLanguage to indexOfMenuItemBeginningWith.
- media/track/track-user-preferences.html: Move menuIndexForLanguage to trackmenu-test.js and
change name to indexOfMenuItemBeginningWith. Clarify the message logged when a track loads
but it should not.
- media/trackmenu-test.js: Move some functions here from track-user-preferences.html
(trackMenuList):
(indexOfMenuItemBeginningWith):
(selectCaptionMenuItem):
- media/video-controls-captions-trackmenu-sorted.html: Update for new menu item.
- media/video-controls-captions-trackmenu.html: Ditto.
- platform/mac/media/video-controls-captions-trackmenu-expected.txt: Ditto.
- platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt: Ditto.
- 3:20 PM Changeset in webkit [147674] by
-
- 1 edit3 deletes in trunk/LayoutTests
[EFL] Unreviewed gardening. Rebaseline after r147588. Remove overridden pixel results.
- platform/efl/fast/text/international/003-expected.png: Removed.
- platform/efl/fast/text/international/text-combine-image-test-expected.png: Removed.
- platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Removed.
- 3:01 PM Changeset in webkit [147673] by
-
- 1 edit6 adds in trunk/LayoutTests
[EFL] Unreviewed gardening. Rebaseline after r147588. Update pixel expectations.
- platform/efl-wk1/fast/text/international/003-expected.png: Added.
- platform/efl-wk1/fast/text/international/text-combine-image-test-expected.png: Added.
- platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
- platform/efl-wk2/fast/text/international/003-expected.png: Added.
- platform/efl-wk2/fast/text/international/text-combine-image-test-expected.png: Added.
- platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
- 2:57 PM Changeset in webkit [147672] by
-
- 2 edits in trunk/Tools
turn off running tests on chromium linux EWS bots
https://bugs.webkit.org/show_bug.cgi?id=113959
Reviewed by Geoffrey Garen.
Now that the Chromium port is no longer being maintained
there's little point in running the tests. Soon we should
just shut this bot off altogether.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(ChromiumLinuxEWS):
- 2:57 PM Changeset in webkit [147671] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r146580): Assertion using SecurityOrigin::create, URL string is not valid
https://bugs.webkit.org/show_bug.cgi?id=113961
Reviewed by Geoff Garen.
- page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::createFromDatabaseIdentifier): (WebCore::SecurityOrigin::create): Don't use ParsedURLString, because http://host:80/ is normalized to http://host/, so it's not a parsed URL string.
- 2:25 PM Changeset in webkit [147670] by
-
- 4 edits3 adds in trunk
Exception stack unwinding doesn't handle inline callframes correctly
https://bugs.webkit.org/show_bug.cgi?id=113952
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
The basic problem here is that the exception stack unwinding was
attempting to be "clever" and avoid doing a correct stack walk
as it "knew" inline callframes couldn't have exception handlers.
This used to be safe as the exception handling machinery was
designed to fail gently and just claim that no handler existed.
This was "safe" and even "correct" inasmuch as we currently
don't run any code with exception handlers through the dfg.
This patch fixes the logic by simply making everything uniformly
use the safe stack walking machinery, and making the correct
boundary checks occur everywhere that they should.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::findClosureCallForReturnPC):
(JSC::CodeBlock::bytecodeOffset):
- interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::getCallerInfo):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::retrieveCallerFromVMCode):
LayoutTests:
Yay tests!
- fast/js/js-correct-exception-handler-expected.txt: Added.
- fast/js/js-correct-exception-handler.html: Added.
- fast/js/script-tests/js-correct-exception-handler.js: Added.
(throwEventually):
(f.g):
(f):
(test):
- 2:16 PM Changeset in webkit [147669] by
-
- 2 edits in trunk/Source/JavaScriptCore
Removed a defunct comment
https://bugs.webkit.org/show_bug.cgi?id=113948
Reviewed by Oliver Hunt.
This is also a convenient way to test the EWS.
- bytecompiler/BytecodeGenerator.cpp:
(JSC):
- 2:08 PM Changeset in webkit [147668] by
-
- 1 edit7 adds3 deletes in trunk/LayoutTests
[EFL] Unreviewed gardening. Rebaseline after r147588.
- platform/efl-wk1/fast/text/international: Added.
- platform/efl-wk1/fast/text/international/003-expected.txt: Added.
- platform/efl-wk1/fast/text/international/text-combine-image-test-expected.txt: Added.
- platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
- platform/efl-wk2/fast/text/international/003-expected.txt: Added.
- platform/efl-wk2/fast/text/international/text-combine-image-test-expected.txt: Added.
- platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
- platform/efl/fast/text/international/003-expected.txt: Removed.
- platform/efl/fast/text/international/text-combine-image-test-expected.txt: Removed.
- platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
- 1:52 PM Changeset in webkit [147667] by
-
- 5 edits in trunk
Unreviewed, rolling out r147662.
http://trac.webkit.org/changeset/147662
https://bugs.webkit.org/show_bug.cgi?id=113955
The change r147662 breaks fast/regions/fixed-pos-elem-in-
region.html (Requested by benjaminp on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-04
Source/WebCore:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineLogicalWidth):
LayoutTests:
- fast/inline/inline-with-empty-inline-children-expected.txt:
- fast/inline/inline-with-empty-inline-children.html:
- 1:46 PM Changeset in webkit [147666] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. AppleWin port gardening.
- platform/win/TestExpectations:
- 1:19 PM Changeset in webkit [147665] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. AppleWin port gardening.
- platform/win/TestExpectations:
- platform/win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- 12:58 PM Changeset in webkit [147664] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r147373): Auto-sizing doesn't always respect minimum width changes
https://bugs.webkit.org/show_bug.cgi?id=113947
<rdar://problem/13579024>
Reviewed by Anders Carlsson.
Reset the FrameView size to the minimum auto-sizing size
before performing auto-sizing. We were already resetting the height,
but not the width, instead using the FrameView's current width.
This means that changing the minimum width without also manually
resizing the FrameView will never see the width change.
Auto-sizing tests are not working on Mac yet.
- page/FrameView.cpp:
(WebCore::FrameView::autoSizeIfEnabled):
- 12:26 PM Changeset in webkit [147663] by
-
- 5 edits12 deletes in trunk/Source
[GTK] Remove the gyp build
https://bugs.webkit.org/show_bug.cgi?id=113942
Reviewed by Gustavo Noronha Silva.
Source/JavaScriptCore:
- JavaScriptCore.gyp/JavaScriptCoreGTK.gyp: Removed.
- JavaScriptCore.gyp/redirect-stdout.sh: Removed.
Source/ThirdParty/ANGLE:
- ANGLE.gyp/ANGLE.gyp: Removed.
- ANGLE.gypi: Removed.
Source/WebCore:
- WebCore.gyp/WebCoreGTK.gyp: Removed.
Source/WebKit/gtk:
- gyp/Configuration.gypi.in: Removed.
- gyp/Dependencies.gyp: Removed.
- gyp/GNUmakefile: Removed.
- gyp/autogen.sh: Removed.
- gyp/configure.ac: Removed.
- gyp/run-gyp: Removed.
Source/WTF:
- WTF.gyp/WTFGTK.gyp: Removed.
- 12:23 PM Changeset in webkit [147662] by
-
- 5 edits in trunk
REGRESSION(r142152): Text wraps in menu
https://bugs.webkit.org/show_bug.cgi?id=113706
Reviewed by David Hyatt.
Source/WebCore:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineLogicalWidth): Empty inline elements add their inline border/padding/margin to the width of the
line when we iterate through them in nextLineBreak(), so no need to add them again here when climbing back up
from their first child looking for border/padding/margin to add. (An empty inline element can have floating children.)
LayoutTests:
- fast/inline/inline-with-empty-inline-children-expected.txt:
- fast/inline/inline-with-empty-inline-children.html:
- 12:15 PM Changeset in webkit [147661] by
-
- 2 edits in trunk/Source/WebCore
Changing typing style with font size delta overrides the previous font size delta
https://bugs.webkit.org/show_bug.cgi?id=113923
Reviewed by Andreas Kling.
The bug was caused by a new font size delta value overriding the old one as
opposed to being added to the old value. Fixed that in overrideWithStyle.
Also made overrideWithStyle share code with mergeStyle since there is already
code to merge text-decorations there.
Unfortunately, adding a test for this fix proved to be hard because we don't
expose any API to directly set typing style.
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::overrideWithStyle): Use mergeStyle.
(WebCore::EditingStyle::mergeStyle): Add font size deltas as opposed to simply
using the new value.
- 12:05 PM Changeset in webkit [147660] by
-
- 4 edits2 adds in trunk
AX:File upload button has wrong label
https://bugs.webkit.org/show_bug.cgi?id=113924
Reviewed by David Kilzer.
Source/WebCore:
Allow the label and value to be returned for file upload controls on iOS.
Due to the different AX APIs, we can expose a bit more information on iOS.
Test: platform/iphone-simulator/accessibility/file-upload-button.html
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper stringValueShouldBeUsedInLabel]):
(-[WebAccessibilityObjectWrapper fileUploadButtonReturnsValueInTitle]):
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase fileUploadButtonReturnsValueInTitle]):
(-[WebAccessibilityObjectWrapperBase accessibilityTitle]):
LayoutTests:
- platform/iphone-simulator/accessibility/file-upload-button-expected.txt: Added.
- platform/iphone-simulator/accessibility/file-upload-button.html: Added.
- 11:52 AM Changeset in webkit [147659] by
-
- 8 edits in trunk/Source
Expose settings to disable plugin snapshotting autostart and primary detection
https://bugs.webkit.org/show_bug.cgi?id=113918
Reviewed by Tim Horton.
Source/WebCore:
Three new settings:
- snapshotAllPlugIns: Do not apply any heuristics - immediately snapshot a plugin.
- primaryPlugInSnapshotDetectionEnabled: Toggle snapshotting the "main" plugin in the page.
- autostartOriginPlugInSnapshottingEnabled: Toggle snapshotting based on URL origins.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Don't tell the host that we've started
if the autostartOriginPlugInSnapshottingEnabled is false.
(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Don't restart a primary
plugin if primaryPlugInSnapshotDetectionEnabled is false.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Snapshot immediately if
snapshotAllPlugIns is true. Also, don't test for autostart if
autostartOriginPlugInSnapshottingEnabled is false.
- page/Settings.in: Three new settings values.
Source/WebKit2:
Three new settings: snapshotAllPlugIns, primaryPlugInSnapshotDetectionEnabled and
autostartOriginPlugInSnapshottingEnabled.
These are exposed via WKPreferences (WebKit2 only, since that's the only port actively
using the feature).
- Shared/WebPreferencesStore.h: Add macros for new settings.
- UIProcess/API/C/WKPreferences.cpp: Getters and setters for new settings.
(WKPreferencesSetSnapshotAllPlugIns):
(WKPreferencesGetSnapshotAllPlugIns):
(WKPreferencesSetAutostartOriginPlugInSnapshottingEnabled):
(WKPreferencesGetAutostartOriginPlugInSnapshottingEnabled):
(WKPreferencesSetPrimaryPlugInSnapshotDetectionEnabled):
(WKPreferencesGetPrimaryPlugInSnapshotDetectionEnabled):
- UIProcess/API/C/WKPreferencesPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Forward settings updates.
(WebKit::WebPage::addPluginView): Don't run primary plugin detection if the setting is false.
(WebKit::WebPage::didFinishLoad): Ditto.
- 11:31 AM Changeset in webkit [147658] by
-
- 4 edits in trunk/Source/JavaScriptCore
Simplified bytecode generation by merging prefix and postfix nodes
https://bugs.webkit.org/show_bug.cgi?id=113925
Reviewed by Filip Pizlo.
PostfixNode now inherits from PrefixNode, so when we detect that we're
in a context where postifx and prefix are equivalent, PostFixNode can
just call through to PrefixNode codegen, instead of duplicating the
logic.
- bytecompiler/NodesCodegen.cpp:
(JSC::PostfixNode::emitResolve):
(JSC::PostfixNode::emitBracket):
(JSC::PostfixNode::emitDot):
- parser/NodeConstructors.h:
(JSC::PostfixNode::PostfixNode):
- parser/Nodes.h:
(JSC):
(PrefixNode):
(PostfixNode):
- 11:25 AM Changeset in webkit [147657] by
-
- 2 edits in trunk/Tools
Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
- Scripts/webkitpy/common/config/watchlist:
- 11:22 AM Changeset in webkit [147656] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-win-xp
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:22 AM Changeset in webkit [147655] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-win
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:22 AM Changeset in webkit [147654] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Remove skia code from PluginViewBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=113936
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-04
Reviewed by Rob Buis.
Skia is not used anymore by the BlackBerry port.
- plugins/blackberry/PluginViewBlackBerry.cpp:
(WebCore::PluginView::paint):
- 11:22 AM Changeset in webkit [147653] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-mac-snowleopard
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:19 AM Changeset in webkit [147652] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-mac-mountainlion
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:19 AM Changeset in webkit [147651] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-mac-lion
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:19 AM Changeset in webkit [147650] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-mac
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:19 AM Changeset in webkit [147649] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-linux-x86
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:19 AM Changeset in webkit [147648] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-linux
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:19 AM Changeset in webkit [147647] by
-
- 1 delete in trunk/LayoutTests/platform/chromium-android
Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.
- 11:17 AM Changeset in webkit [147646] by
-
- 1 delete in trunk/LayoutTests/platform/chromium
Removed Chromium layout test results.\n\nReviewed by Anders Carlsson.\n\nI'm using a direct svn http command to try to reduce email traffic.
- 11:10 AM Changeset in webkit [147645] by
-
- 3 edits2 adds in trunk
Source/WebCore: Change RenderFrameSet::computeEdgeInfo to use m-rows/m_cols directly
https://bugs.webkit.org/show_bug.cgi?id=113825
Reviewed by Eric Seidel.
Tests: fast/frames/invalid-frameset-compute-edge.html
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::computeEdgeInfo):
LayoutTests: Change RenderFrameSet::computeEdgeInfo to use m-rows/m_cols directly
https://bugs.webkit.org/show_bug.cgi?id=113825
Reviewed by Eric Seidel.
Add test for accessing an invalid frame.
- fast/frames/invalid-frameset-compute-edge-expected.html: Added.
- fast/frames/invalid-frameset-compute-edge.html: Added.
- 11:00 AM Changeset in webkit [147644] by
-
- 2 edits in trunk/Source/WebCore
[GTK][AC] Invalid clear ClutterContent of ClutterActor
https://bugs.webkit.org/show_bug.cgi?id=113758
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-04
Reviewed by Gustavo Noronha Silva.
Using clutter_actor_set_content(actor, 0) is better to clear ClutterContent of ClutterActor.
Actually the ClutterContent referece is cleared in the API if we set 0.
No new tests since no functionality changed.
- platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorUpdateTexture):
- 10:59 AM Changeset in webkit [147643] by
-
- 37 edits4 adds2 deletes in trunk
[Cairo] Fix canvas drawing of SVG-based patterns and remove NativeImageCairo
https://bugs.webkit.org/show_bug.cgi?id=113929
Reviewed by Martin Robinson.
Source/WebCore:
Make (Pass)NativeImagePtr typedefs to (Pass)RefPtr<cairo_surface_t> instead
of NativeImageCairo*. Now that we switch to using smart pointers,
NativeImageCairo is removed as it made no sense to make it ref counted when
it merely held a single ref counted member.
Now that Cairo is using smart pointers for (Pass)NativeImagePtr, this patch
also enables the implementation of SVGImage::nativeImageForCurrentFrame()
for USE(CAIRO) as well. This effectively fixes canvas drawing of SVG-based
patterns for Cairo-based ports.
No new tests, covered by svg/canvas/canvas-pattern-svg.html.
- GNUmakefile.list.am: Remove NativeImageCairo.* for GTK.
- PlatformEfl.cmake: Remove NativeImageCairo.* for EFL.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
Remove NativeImageCairo.* for Win.
- platform/graphics/BitmapImage.cpp:
(WebCore::FrameData::reportMemoryUsage):
Update MemoryClassInfo::addRawBuffer() call now that m_frame is a RefPtr
for USE(CAIRO).
- platform/graphics/BitmapImage.h:
(BitmapImage):
Remove factory method taking a cairo_surface_t* in argument. This is useless
now that PassNativeImagePtr is a typedef to PassRefPtr<cairo_surface_t> and
there is already a factory method taking a PassNativeImagePtr in argument.
- platform/graphics/NativeImagePtr.h:
(WebCore):
Make PassNativeImagePtr a typedef to PassRefPtr<cairo_surface_t> and
NativeImagePtr a typedef to RefPtr<cairo_surface_t>, instead of
NativeImageCairo*. Moving to smart pointers is needed to enable implementation
of SVGImage::nativeImageForCurrentFrame() for Cairo.
- platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::checkForSolidColor):
(WebCore::FrameData::clear):
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- platform/graphics/cairo/ImageCairo.cpp:
(WebCore::Image::drawPattern):
Update Cairo graphics code to reflect the (Pass)NativeImagePtr type changes.
- platform/graphics/cairo/NativeImageCairo.cpp: Removed.
- platform/graphics/cairo/NativeImageCairo.h: Removed.
- platform/graphics/cairo/PatternCairo.cpp:
(WebCore::Pattern::createPlatformPattern):
- platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
- platform/graphics/efl/ImageEfl.cpp:
(WebCore::BitmapImage::getEvasObject):
- platform/graphics/gtk/ImageGtk.cpp:
(WebCore::BitmapImage::getGdkPixbuf):
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
- platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::create):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
- platform/gtk/DragImageGtk.cpp:
(WebCore::createDragImageFromImage):
- platform/image-decoders/cairo/ImageDecoderCairo.cpp:
(WebCore::ImageFrame::asNewNativeImage):
- platform/win/DragImageCairoWin.cpp:
(WebCore::createDragImageFromImage):
Update code to reflect the (Pass)NativeImagePtr type changes.
- svg/graphics/SVGImage.cpp:
(WebCore):
- svg/graphics/SVGImage.h:
Enable SVGImage::nativeImageForCurrentFrame() for USE(CAIRO).
Source/WebKit:
Remove outdated symbols now that NativeImageCairo was removed.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/efl:
Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
instead of NativeImageCairo*.
- ewk/ewk_history.cpp:
(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):
- ewk/ewk_settings.cpp:
(ewk_settings_icon_database_icon_surface_get):
(ewk_settings_icon_database_icon_object_get):
Source/WebKit/gtk:
Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
instead of NativeImageCairo*.
- webkit/webkitfavicondatabase.cpp:
(getIconPixbufSynchronously):
Source/WebKit/win:
Remove outdated symbols now that NativeImageCairo was removed.
- WebKit.vcproj/WebKitExports.def.in:
Source/WebKit2:
Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
instead of NativeImageCairo*.
- Shared/gtk/ArgumentCodersGtk.cpp:
(CoreIPC::decodeImage):
- UIProcess/API/C/cairo/WKIconDatabaseCairo.cpp:
(WKIconDatabaseTryGetCairoSurfaceForURL):
- UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
(getIconSurfaceSynchronously):
LayoutTests:
Add EFL / GTK pixels results for svg/canvas/canvas-pattern-svg.html now that
the test passes for cairo-based ports.
- platform/efl/svg/canvas/canvas-pattern-svg-expected.png: Added.
- platform/gtk/svg/canvas/canvas-pattern-svg-expected.png: Added.
- 10:48 AM Changeset in webkit [147642] by
-
- 2 edits in trunk/Source/WebCore
[EFL] --minimal build fails with 'error: unused variable'
https://bugs.webkit.org/show_bug.cgi?id=113903
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-04
Reviewed by Gustavo Noronha Silva.
Moved variable definition under #if where it's used
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::restartedCallback):
- 10:30 AM Changeset in webkit [147641] by
-
- 2 edits in trunk/Source/WTF
ObjcRuntimeExtras.h should use variadic templates
https://bugs.webkit.org/show_bug.cgi?id=113941
Reviewed by Andreas Kling.
Reimplement wtfObjcMsgSend and wtfCallIMP as variadic function templates.
- wtf/ObjcRuntimeExtras.h:
(wtfObjcMsgSend):
(wtfCallIMP):
- 9:40 AM Changeset in webkit [147640] by
-
- 4 edits in trunk/Source
Fix the build with GCC 4.8
https://bugs.webkit.org/show_bug.cgi?id=113147
Reviewed by Allan Sandfeld Jensen.
Source/JavaScriptCore:
Initialize JSObject* exception to suppress warnings that make
the build fail because of -Werror=maybe-uninitialized.
- runtime/Executable.cpp:
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
Source/WTF:
Disable diagnostic warning -Wunused-local-typedefs for GCC 4.8
since dummy typedefs are commonly used in the codebase.
- wtf/Compiler.h:
- 9:37 AM Changeset in webkit [147639] by
-
- 12 edits in trunk/Source/WebCore
Global FontPlatformData cache should use OwnPtr.
<http://webkit.org/b/111939>
Reviewed by Anders Carlsson.
Let the global FontPlatformData use OwnPtr instead of raw pointers + deleteAllValues().
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::purgeInactiveFontData):
(WebCore::FontCache::invalidate):
Tweaked code for OwnPtr. Also made getCachedFontPlatformData() do one hash lookup
instead of two.
- platform/graphics/FontCache.h:
- platform/graphics/blackberry/FontCacheBlackBerry.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/chromium/FontCacheAndroid.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/skia/FontCacheSkia.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/wince/FontCacheWinCE.cpp:
(WebCore::FontCache::createFontPlatformData):
- platform/graphics/wx/FontCacheWx.cpp:
(WebCore::FontCache::createFontPlatformData):
FontCache::createFontPlatformData() now returns a PassOwnPtr.
- 9:28 AM Changeset in webkit [147638] by
-
- 2 edits in trunk/Source/WebCore
Render images with low-quality scaling while FrameView is being resized.
<http://webkit.org/b/113764>
<rdar://problem/13555154>
Reviewed by Antti Koivisto.
Have ImageQualityController ask the renderer's containing FrameView if it's currently in live
resize, and if so, paint all images with low-quality scaling. A high-quality repaint will happen
~0.5 sec after live resizing ends, piggybacking on the same mechanism we use to do JS-animated
resizing with low-quality scaling.
This reduces CPU time spent generating new tiles during live window resize, especially on Retina
systems where a lot of upscaling happens on legacy web content.
- rendering/RenderBoxModelObject.cpp:
(ImageQualityController):
Added an m_liveResizeOptimizationIsActive flag that tracks whether the ImageQualityController
is painting everything in low quality due to live window resize. It gets unset when the HQ
repaint timer fires and everything has been repainted properly.
(WebCore::ImageQualityController::highQualityRepaintTimerFired):
When the HQ repaint timer fires, check if the renderer's containing FrameView is still in
live resize, and if so, abort HQ repaint for now and reschedule the timer.
(WebCore::ImageQualityController::ImageQualityController):
(WebCore::ImageQualityController::objectDestroyed):
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
- 9:18 AM Changeset in webkit [147637] by
-
- 14 edits in trunk/Source
[Qt] docs: Fix module name format
https://bugs.webkit.org/show_bug.cgi?id=113209
Patch by Sze Howe Koh <szehowe.koh@gmail.com> on 2013-04-04
Reviewed by Jocelyn Turcotte.
Make QDoc-generated documentation follow the conventions at
http://qt-project.org/wiki/Spelling_Module_Names_in_Qt_Documentation
Source/WebKit/qt:
- Api/qwebdatabase.cpp:
- Api/qwebkitglobal.cpp:
- Api/qwebpluginfactory.cpp:
- Api/qwebsettings.cpp:
- WidgetApi/qgraphicswebview.cpp:
- WidgetApi/qwebframe.cpp:
- WidgetApi/qwebpage.cpp:
- WidgetApi/qwebview.cpp:
- docs/qtwebkit-bridge.qdoc:
- docs/qtwebkit-goes-mobile.qdoc:
- docs/qtwebkit.qdoc:
Source/WebKit2:
- UIProcess/API/qt/qquickwebview.cpp:
- 9:17 AM Changeset in webkit [147636] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix closure compiler warnings in IndexedDBModel.js
https://bugs.webkit.org/show_bug.cgi?id=113926
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-04
Reviewed by Alexander Pavlov.
No new tests: no change in behaviour.
- inspector/front-end/IndexedDBModel.js:
- 9:01 AM Changeset in webkit [147635] by
-
- 3 edits2 adds in trunk
REGRESSION (r145870): Can't get insertion point to appear in some input and textareas on wordpress
https://bugs.webkit.org/show_bug.cgi?id=113591
Patch by Xidorn Quan <quanxunzhen@gmail.com> on 2013-04-04
Reviewed by Simon Fraser.
Source/WebCore:
Since a child node could overflow its ancestor, it is not wise to check
one's radii boundary before checking whether the given point intersects
its children. This patch moves the related code down to fix the bug.
Test: fast/borders/border-radius-child.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
LayoutTests:
- fast/borders/border-radius-child-expected.txt: Added.
- fast/borders/border-radius-child.html: Added.
- 8:53 AM Changeset in webkit [147634] by
-
- 2 edits in trunk/Tools
Indentation fix to get webkit-patch working again after r147625
Unreviewed.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(MacEWS):
(MacWK2EWS):
- 8:32 AM Changeset in webkit [147633] by
-
- 2 edits in tags/Safari-537.35.8/Source/WebKit2
Merged r147592. <rdar://problem/13540351>
- 8:29 AM Changeset in webkit [147632] by
-
- 10 edits in tags/Safari-537.35.8/Source
Merged r147579. <rdar://problem/13478573>
- 8:26 AM Changeset in webkit [147631] by
-
- 2 edits in tags/Safari-537.35.8/Source/WebKit2
Merged r147500. <rdar://problem/13159030>
- 8:23 AM Changeset in webkit [147630] by
-
- 6 edits in tags/Safari-537.35.8/Source/WebKit2
Merged r147489. <rdar://problem/12679817>
- 8:20 AM Changeset in webkit [147629] by
-
- 13 edits2 copies in tags/Safari-537.35.8
Merged r147471. <rdar://problem/13522402>
- 8:15 AM Changeset in webkit [147628] by
-
- 4 edits in trunk
[GStreamer] Virtual modifier for MediaPlayer::simulateAudioInterruption must go
https://bugs.webkit.org/show_bug.cgi?id=113851
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-04-04
Reviewed by Eric Carlson.
.:
- Source/autotools/symbols.filter: Added
_ZN7WebCore11MediaPlayer25simulateAudioInterruptionEv symbol.
Source/WebCore:
- platform/graphics/MediaPlayer.h:
(MediaPlayer): Removed virtual modifier to
simulateAudioInterruption.
- 8:14 AM Changeset in webkit [147627] by
-
- 2 edits in tags/Safari-537.35.8/Source/JavaScriptCore
Merged r147079. <rdar://problem/13519289>
- 8:12 AM Changeset in webkit [147626] by
-
- 2 edits in tags/Safari-537.35.8/Source/JavaScriptCore
Merged r147017. <rdar://problem/13519289>
- 8:06 AM Changeset in webkit [147625] by
-
- 2 edits in trunk/Tools
Turn tests back on for Mac WK1/WK2 EWS.
Unreviewed.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(MacEWS):
(MacWK2EWS):
- 6:26 AM Changeset in webkit [147624] by
-
- 3 edits in trunk/Tools
[GTK][WK2] MiniBrowser custom URI scheme support
https://bugs.webkit.org/show_bug.cgi?id=112419
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-04
Reviewed by Carlos Garcia Campos.
Add support for about URIs in MiniBrowser. An example about page is show
with URI "about:minibrowser", the rest of the cases it will show a
proper message explaining that the about page didn't exist.
Internally it uses "minibrowser-about" prefix instead of "about", but
from the user point of view it works with "about" prefix.
- MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
(getInternalURI): Method to convert URIs from "about" prefix to
"minibrowser-about".
(getExternalURI): Opposite method.
(webViewURIChanged): Use "about" prefix to show the URI to users.
(webViewEnterFullScreen): Ditto.
(browser_window_load_uri): Use "minibrowser-about" prefix internally.
- MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
(aboutURISchemeRequestCallback): Callback to manage about calls.
(main): Register the URI scheme to manage about URIs.
- 6:20 AM Changeset in webkit [147623] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Support -webkit-font-smoothing
https://bugs.webkit.org/show_bug.cgi?id=106009
Reviewed by Jocelyn Turcotte.
Remove false dependency on Qt 5.1 for the -webkit-font-smoothing property.
For now we are still keeping the dependency on Font::shouldUseSmoothing().
- platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
- 5:05 AM Changeset in webkit [147622] by
-
- 51 edits5 adds in trunk
Regression(r142765) Broke Custom SVG cursors and SVG canvas drawing for Chromium
https://bugs.webkit.org/show_bug.cgi?id=113420
Reviewed by Stephen White.
Source/WebCore:
Introduce a PassNativeImagePtr typedef that is used in place of NativeImagePtr
for method arguments and return values. This is needed as Skia now maps
NativeImagePtr to RefPtr<NativeImageSkia> and PassNativeImagePtr to
PassRefPtr<NativeImageSkia>. We move towards ref counted smart pointers so that
SVGImage::nativeImageForCurrentFrame() can transfer ownership of the native
image to the caller if needed (e.g. for SVGImage).
Provide nativeImageForCurrentFrame() implementation for SVGImage. SVGImage no
longer holds the native image internally, to save memory. It is therefore created
when nativeImageForCurrentFrame() is called and ownership is passed to the
caller. For now, this implementation is only enabled for Skia as others are using
raw pointers for PassNativeImagePtr.
Test: svg/canvas/canvas-pattern-svg.html
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousNativeIconForPageURL):
Return a PassNativeImagePtr instead of NativeImagePtr.
- loader/icon/IconDatabase.h:
(IconDatabase):
- loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::synchronousNativeIconForPageURL):
Return a PassNativeImagePtr instead of NativeImagePtr.
- platform/chromium/DragImageChromiumSkia.cpp:
(WebCore::createDragImageFromImage):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead of a raw
one.
- platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeImage):
Store return value of nativeImageForCurrentFrame() in a RefPtr<NativeImageSkia>
instead of a NativeImagePtr. While these are equivalent, the former is more
readable in Skia-specific code.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::frameAtIndex):
Return a PassNativeImagePtr instead of a NativeImagePtr.
(WebCore::BitmapImage::nativeImageForCurrentFrame):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/graphics/BitmapImage.h:
(WebCore::BitmapImage::create):
Take a PassNativeImagePtr in argument instead of a NativeImagePtr.
(BitmapImage): Ditto.
- platform/graphics/GraphicsContext.h:
(GraphicsContext): Ditto.
- platform/graphics/GraphicsContext3D.h:
(ImageExtractor):
Keep NativeImageSkia in a RefPtr instead of OwnPtr, now that it is refcounted.
- platform/graphics/Image.h:
(WebCore::Image::nativeImageForCurrentFrame):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/graphics/ImageBuffer.h:
(ImageBuffer):
Have copyNativeImage() return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::createFrameAtIndex):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/graphics/ImageSource.h:
Have createFrameAtIndex() return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/graphics/NativeImagePtr.h:
Map NativeImagePtr to a RefPtr<NativeImageSkia> instead of NativeImageSkia* for Skia.
Introduce new PassNativeImagePtr that maps to PassRefPtr<NativeImageSkia> for Skia
and is equivalent to NativeImagePtr for other ports. We now use smart pointers for
the native image so that SVGImage::nativeImageForCurrentFrame() can pass ownership
of the native image to the caller, unlike BitmapImage::nativeImageForCurrentFrame().
- platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.
(WebCore::BitmapImage::BitmapImage):
Take a PassNativeImagePtr instead of a NativeImagePtr in argument.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawNativeImage): Ditto.
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::copyNativeImage):
Take a PassNativeImagePtr instead of a NativeImagePtr in argument.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToImage):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead of a raw one.
- platform/graphics/filters/skia/FEBlendSkia.cpp:
(WebCore::FEBlend::platformApplySkia): Ditto.
- platform/graphics/filters/skia/FEColorMatrixSkia.cpp:
(WebCore::FEColorMatrix::platformApplySkia): Ditto.
- platform/graphics/filters/skia/FEComponentTransferSkia.cpp:
(WebCore::FEComponentTransfer::platformApplySkia): Ditto.
- platform/graphics/filters/skia/FEDisplacementMapSkia.cpp:
(WebCore::FEDisplacementMap::platformApplySkia): Ditto.
- platform/graphics/filters/skia/FELightingSkia.cpp:
(WebCore::FELighting::platformApplySkia): Ditto.
- platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/graphics/qt/StillImageQt.cpp:
(WebCore::StillImage::nativeImageForCurrentFrame):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/graphics/qt/StillImageQt.h:
(StillImage): Ditto.
- platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
No longer need to adopt the return value of asNewNativeImage() now
that it returns a PassRefPtr instead of a raw one.
- platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
Call NativeImageSkia::create() factory method now that the constructor
is private.
- platform/graphics/skia/ImageSkia.cpp:
(WebCore::FrameData::clear):
Just call clear() on m_frame instead of explicitely deleting it now
that it is a RefPtr.
(WebCore::Image::drawPattern):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead
of a raw one.
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::checkForSolidColor):
Store return value of frameAtIndex() in a RefPtr instead of a raw one.
(WebCore::BitmapImage::draw):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead
of a raw one.
- platform/graphics/skia/NativeImageSkia.cpp:
Add new constructor taking all members in argument. This is used for
cloning a NativeImageSkia object.
(WebCore::NativeImageSkia::NativeImageSkia):
(WebCore::NativeImageSkia::deepSkBitmapCopy):
Add convenience function to make a deep copy of a SkBitmap.
- platform/graphics/skia/NativeImageSkia.h:
(WebCore):
(WebCore::NativeImageSkia::create):
(NativeImageSkia):
Make NativeImageSkia subclass RefCounted. Make the constructor private
and add a factory method instead that returns a PassRefPtr.
(WebCore::NativeImageSkia::clone):
Add a clone() method now that NativeImageSkia is refcounted and is no
longer copyable.
- platform/graphics/skia/PatternSkia.cpp:
(WebCore::Pattern::platformPattern):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead
of a raw one.
- platform/graphics/wince/ImageWinCE.cpp:
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/image-decoders/ImageDecoder.h:
(ImageFrame):
Have asNewNativeImage() return a PassNativeImagePtr instead of a
NativeImagePtr.
(WebCore::ImageFrame::getAddr):
(WebCore::ImageFrame::setSkBitmap):
(WebCore::ImageFrame::getSkBitmap):
(WebCore::ImageFrame::width):
(WebCore::ImageFrame::height):
Update use of m_bitmap now that it is a pointer type and call
NativeImageSkia::create() to construct a NativeImageSkia object now
that the constructor is private.
- platform/image-decoders/cairo/ImageDecoderCairo.cpp:
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- platform/image-decoders/openvg/ImageDecoderOpenVG.cpp:
(WebCore::ImageFrame::asNewNativeImage): Ditto.
- platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::ImageFrame::ImageFrame):
Initialize m_bitmap in the constructor now that it is a pointer
type and we need NativeImageSkia's default constructor to be
called.
(WebCore::ImageFrame::operator=):
Call NativeImageSkia's new clone() method to copy m_bitmap as
NativeImageSkia is now RefCounted and no longer copyable.
(WebCore::ImageFrame::clearPixelData):
(WebCore::ImageFrame::zeroFillPixelData):
(WebCore::ImageFrame::copyBitmapData):
(WebCore::ImageFrame::setSize):
Update use of m_bitmap now that it is a pointer type.
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.
Call NativeImageSkia's clone method now that it is no longer
copyable.
(WebCore::ImageFrame::setHasAlpha):
(WebCore::ImageFrame::setStatus):
Update use of m_bitmap now that it is a pointer type.
- platform/image-decoders/wx/ImageDecoderWx.cpp:
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.
- svg/graphics/SVGImage.cpp:
(WebCore):
(WebCore::SVGImage::nativeImageForCurrentFrame):
Add implementation of nativeImageForCurrentFrame() for SVGImage as
it is needed for SVG custom cursor support and Canvas drawing of
patterns containing SVG images. As SVGImage no longer keep the
native image internally to save memory, the implementation creates
the native image when nativeImageForCurrentFrame() and passes
its ownership to the caller.
- svg/graphics/SVGImage.h:
Override Image::nativeImageForCurrentFrame() and remove dummy
implementation of frameAtIndex() as it is not needed / used.
- svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::nativeImageForCurrentFrame):
Add implementation of nativeImageForCurrentFrame() which merely
forwards the call to the Image being contained.
- svg/graphics/SVGImageForContainer.h:
Override Image::nativeImageForCurrentFrame().
Source/WebKit/chromium:
Update code now that Image::nativeImageForCurrentFrame() and
ImageFrame::asNewNativeImage() return a smart pointer instead
of a raw one.
- src/WebImageDecoder.cpp:
(WebKit::WebImageDecoder::getFrameAtIndex):
- src/WebImageSkia.cpp:
(WebKit::WebImage::fromData):
(WebKit::WebImage::framesFromData):
(WebKit::WebImage::operator=):
- tests/DeferredImageDecoderTest.cpp:
(WebCore::TEST_F):
- tests/DragImageTest.cpp:
(WebCore::TestImage::TestImage):
(WebCore::TestImage::nativeImageForCurrentFrame):
(TestImage):
- tests/ImageLayerChromiumTest.cpp:
(WebCore::TestImage::TestImage):
(WebCore::TestImage::nativeImageForCurrentFrame):
(TestImage):
- tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
LayoutTests:
Add layout test to check that drawing canvas patterns containing SVG images works.
- platform/chromium-linux/svg/canvas/canvas-pattern-svg-expected.png: Added.
- svg/canvas/canvas-pattern-svg-expected.txt: Added.
- svg/canvas/canvas-pattern-svg.html: Added.
- 4:11 AM Changeset in webkit [147621] by
-
- 3 edits4 adds in trunk/LayoutTests
[SOUP] inspector/timeline/timeline-receive-response-event.html fails
https://bugs.webkit.org/show_bug.cgi?id=113860
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-04
Reviewed by Xan Lopez.
Copy the results of inspector/timeline/timeline-receive-response-event.html
to the efl and gtk platform dir.
Because test files are bigger than buffer size of ResourceHandleSoup.
- platform/efl/TestExpectations:
- platform/efl/inspector/timeline/timeline-receive-response-event-expected.txt: Added.
- platform/gtk/TestExpectations:
- platform/gtk/inspector/timeline/timeline-receive-response-event-expected.txt: Added.
- 4:10 AM Changeset in webkit [147620] by
-
- 3 edits in trunk/Source/WebCore
[CSSRegions] RenderFlowThread::renderRegionForLine should use a faster search method
https://bugs.webkit.org/show_bug.cgi?id=66921
Reviewed by David Hyatt.
The RenderFlowThread::regionAtBlockOffset() function is a hot path for the code using
flow threads because it translates from block coordinates to regions.
Currently the method is O(n), using a linear search through the regions chain to find the
region where a block offset lands.
The patch improves this search by using an interval tree (PODIntervalTree). Before a flow
thread is laid out, each region is updated to hold the size of the portion of the flow it
will receive. This information is gathered inside the interval tree and used to speedup the
search in RenderFlowThread::regionAtBlockOffset(). The algorithm uses a custom adapter
simplified for looking up offsets inside the interval tree.
For now, the interval tree is cleared every time the flow thread portions list is updated.
The implementation can be improved but induces some cmplexity as we'd have to manually manage
the life cycle of the tree's nodes. The performance gains are good enough as is to make this
only optional.
Another important change is now the flow thread portion rectangles will not overflow when
using auto-height regions (or very large regions). The maximum size of the flow is set to
LayoutUnit::max()/2. Any region forcing a greater size will be capped so the thread
won't overflow.
Performance test results:
/Layout/RegionsAuto:Time ms 699.95 181.20 74.11% Better
/Layout/RegionsAutoMaxHeight:Time ms 2083.00 308.55 85.19% Better
/Layout/RegionsFixed:Time ms 726.10 223.65 69.20% Better
/Layout/RegionsFixedShort:Time ms 869.60 288.25 66.85% Better
Tests: See PerformanceTests/Layout/Regions*
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::regionAtBlockOffset):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::RegionSearchAdapter::collectIfNeeded):
(WebCore):
- rendering/RenderFlowThread.h:
(WebCore):
- 4:07 AM Changeset in webkit [147619] by
-
- 2 edits in trunk/LayoutTests
[EFL][Qt] The layout test fast/loader/url-selected-user-gesture.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=113930
Reviewed by Antti Koivisto.
- fast/loader/url-selected-user-gesture.html:
- 3:52 AM Changeset in webkit [147618] by
-
- 5 edits1 add in trunk
[Qt] WebSocket errors should be logged to console
https://bugs.webkit.org/show_bug.cgi?id=113842
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-04
Reviewed by Jocelyn Turcotte.
Source/WebCore:
Pass the reason of a failure to SocketStreamError instance
and notify it via SocketStreamHandleClient::didFailSocketStream().
Test : http/tests/inspector/console-websocket-error.html
- platform/network/qt/SocketStreamError.h:
(WebCore::SocketStreamError::SocketStreamError):
- platform/network/qt/SocketStreamHandleQt.cpp:
(WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate):
(WebCore::SocketStreamHandlePrivate::socketErrorCallback):
LayoutTests:
- platform/qt/TestExpectations:
- platform/qt/http/tests/inspector/console-websocket-error-expected.txt: Added.
- 3:47 AM Changeset in webkit [147617] by
-
- 7 edits in trunk/Source/WebKit2
[WK2][EFL] WebView should own view size
https://bugs.webkit.org/show_bug.cgi?id=110753
Reviewed by Andreas Kling.
WebView owns view size. WKViewGetSize and WKViewSetSize API
is exposed accordingly. Usage of EFL-specific ewkView inside
toolkit-agnostic WebView class is reduced.
- UIProcess/API/C/efl/WKView.cpp:
(WKViewGetSize):
(WKViewSetSize):
- UIProcess/API/C/efl/WKView.h:
- UIProcess/API/efl/EwkView.cpp:
(EwkView::setDeviceScaleFactor):
(EwkView::size):
(EwkView::deviceSize):
(EwkView::scheduleUpdateDisplay):
(EwkView::handleEvasObjectCalculate):
- UIProcess/API/efl/EwkView.h:
(EwkView):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::setSize):
(WebKit):
(WebKit::WebView::paintToCurrentGLContext):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::viewSize):
(WebKit::WebView::dipSize):
- UIProcess/efl/WebView.h:
(WebView):
(WebKit::WebView::size):
- 2:40 AM Changeset in webkit [147616] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- 1:39 AM Changeset in webkit [147615] by
-
- 2 edits in trunk/Source/WebCore
[ATK] build fails when accessibility is turned off
https://bugs.webkit.org/show_bug.cgi?id=113699
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-04
Reviewed by Gyuyoung Kim.
- editing/atk/FrameSelectionAtk.cpp: Wrapped accessibility code in #if HAVE(ACCESSIBILITY)
- 12:59 AM Changeset in webkit [147614] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix closure compiler warnings in the profiler code HeapSnapshotDataGrids.js
https://bugs.webkit.org/show_bug.cgi?id=113922
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-04
Reviewed by Yury Semikhatsky.
No new tests: no change in behaviour.
- inspector/front-end/HeapSnapshotDataGrids.js:
- 12:30 AM Changeset in webkit [147613] by
-
- 9 edits7 adds in trunk/LayoutTests
[Mac] Unreviewed gardening. Rebaseline after r147588.
- platform/mac-lion/fast/text/international/text-combine-image-test-expected.png:
- platform/mac-lion/fast/text/international/text-combine-image-test-expected.txt:
- platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
- platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/mac-wk2/fast/text: Added.
- platform/mac-wk2/fast/text/international: Added.
- platform/mac-wk2/fast/text/international/003-expected.png: Added.
- platform/mac-wk2/fast/text/international/text-combine-image-test-expected.png: Added.
- platform/mac-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
- platform/mac/fast/text/international/003-expected.png:
- platform/mac/fast/text/international/003-expected.txt:
- platform/mac/fast/text/international/text-combine-image-test-expected.png: Added.
- platform/mac/fast/text/international/text-combine-image-test-expected.txt:
- platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
Apr 3, 2013:
- 11:02 PM Changeset in webkit [147612] by
-
- 4 edits in trunk/Source
Versioning.
- 11:00 PM Changeset in webkit [147611] by
-
- 4 edits in tags/Safari-537.35.8/Source
Versioning.
- 10:57 PM Changeset in webkit [147610] by
-
- 1 copy in tags/Safari-537.35.8
New Tag.
- 10:55 PM Changeset in webkit [147609] by
-
- 29 edits4 adds in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: put DFG data into a DFG::JITCode, and put common DFG and FTL data into something accessible from both DFG::JITCode and FTL::JITCode
https://bugs.webkit.org/show_bug.cgi?id=113905
Reviewed by Geoffrey Garen.
This removes one pointer from CodeBlock.
It also gives us a framework for having JITType-specific data in CodeBlock, by
putting it into the appropriate JITCode class (either DFG::JITCode or
FTL::JITCode). And it allows us to have DFG and FTL share some common data,
via DFG::CommonData, which is stored in both DFG::JITCode and FTL::JITCode and
always accessible via JITCode::dfgCommon().
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CodeBlock.cpp:
(JSC):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::performTracingFixpointIteration):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitWeakReferences):
(JSC::CodeBlock::shrinkToFit):
(JSC::CodeBlock::tallyFrequentExitSites):
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::shouldImmediatelyAssumeLivenessDuringScan):
(JSC::DFGCodeBlocks::mark):
- dfg/DFGAssemblyHelpers.h:
- dfg/DFGCommonData.cpp: Added.
(DFG):
(JSC::DFG::CommonData::notifyCompilingStructureTransition):
(JSC::DFG::CommonData::shrinkToFit):
- dfg/DFGCommonData.h: Added.
(JSC):
(DFG):
(JSC::DFG::WeakReferenceTransition::WeakReferenceTransition):
(WeakReferenceTransition):
(CommonData):
(JSC::DFG::CommonData::CommonData):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
- dfg/DFGDriver.h:
(DFG):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
- dfg/DFGGraph.h:
(Graph):
- dfg/DFGJITCode.cpp: Added.
(DFG):
(JSC::DFG::JITCode::JITCode):
(JSC::DFG::JITCode::~JITCode):
(JSC::DFG::JITCode::dfgCommon):
(JSC::DFG::JITCode::dfg):
(JSC::DFG::JITCode::shrinkToFit):
- dfg/DFGJITCode.h: Added.
(DFG):
(JITCode):
(JSC::DFG::JITCode::appendOSREntryData):
(JSC::DFG::JITCode::osrEntryDataForBytecodeIndex):
(JSC::DFG::JITCode::appendOSRExit):
(JSC::DFG::JITCode::lastOSRExit):
(JSC::DFG::JITCode::appendSpeculationRecovery):
(JSC::DFG::JITCode::appendWatchpoint):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGJITCompiler.h:
(JITCompiler):
(JSC::DFG::JITCompiler::addWeakReference):
(JSC::DFG::JITCompiler::noticeOSREntry):
(JSC::DFG::JITCompiler::jitCode):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSRExit.h:
(OSRExit):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::backwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::speculationWatchpoint):
(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGVariableEventStream.cpp:
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::JITCode):
(JSC::FTL::JITCode::~JITCode):
(FTL):
(JSC::FTL::JITCode::initializeCode):
(JSC::FTL::JITCode::addressForCall):
(JSC::FTL::JITCode::executableAddressAtOffset):
(JSC::FTL::JITCode::dataAddressAtOffset):
(JSC::FTL::JITCode::offsetOf):
(JSC::FTL::JITCode::size):
(JSC::FTL::JITCode::contains):
(JSC::FTL::JITCode::ftl):
(JSC::FTL::JITCode::dfgCommon):
- ftl/FTLJITCode.h:
(JITCode):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileStructureTransitionWatchpoint):
(JSC::FTL::LowerDFGToLLVM::compilePutStructure):
(JSC::FTL::LowerDFGToLLVM::compilePhantomPutStructure):
(JSC::FTL::LowerDFGToLLVM::addWeakReference):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::weakPointer):
- ftl/FTLState.cpp:
(FTL):
(JSC::FTL::State::State):
(JSC::FTL::State::dumpState):
- ftl/FTLState.h:
(State):
- heap/DFGCodeBlocks.cpp:
(JSC::DFGCodeBlocks::~DFGCodeBlocks):
(JSC::DFGCodeBlocks::jettison):
(JSC::DFGCodeBlocks::clearMarks):
(JSC::DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks):
(JSC::DFGCodeBlocks::traceMarkedCodeBlocks):
- jit/JITCode.cpp:
(JSC::JITCode::dfgCommon):
(JSC):
(JSC::JITCode::dfg):
(JSC::JITCode::ftl):
(JSC::DirectJITCode::DirectJITCode):
(JSC::DirectJITCode::initializeCodeRef):
(JSC::DirectJITCode::addressForCall):
(JSC::DirectJITCode::executableAddressAtOffset):
(JSC::DirectJITCode::dataAddressAtOffset):
(JSC::DirectJITCode::offsetOf):
(JSC::DirectJITCode::size):
(JSC::DirectJITCode::contains):
- jit/JITCode.h:
(DFG):
(FTL):
(JSC):
(JITCode):
(DirectJITCode):
- 10:09 PM Changeset in webkit [147608] by
-
- 4 edits in branches/dfgFourthTier
fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define
https://bugs.webkit.org/show_bug.cgi?id=113921
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
The LLVM community wants us to continue including all of LLVM's C++ headers. Change
to using #pragma's to disable warnings that they cannot handle.
- ftl/FTLLLVMHeaders.h:
Tools:
Reviewed by Oliver Hunt.
The LLVM community wants us to continue including all of LLVM's C++ headers. Change
the export script to do this.
- Scripts/export-llvm-build:
- 8:52 PM Changeset in webkit [147607] by
-
- 27 edits in trunk
[EFL] Add a decoration image to search input field
https://bugs.webkit.org/show_bug.cgi?id=113552
Reviewed by Laszlo Gombos.
Source/WebCore:
Though EFL port has a decoration image for search input field, we didn't use it.
Start to show it.
Tests: fast/forms/search-cancel-button-style-sharing.html
fast/forms/search-rtl.html
fast/css/input-search-padding.html
fast/css/text-input-with-webkit-border-radius.html
fast/css/text-overflow-input.html
fast/forms/box-shadow-override.html
fast/forms/control-restrict-line-height.html
fast/forms/input-appearance-height.html
fast/forms/placeholder-position.html
fast/forms/placeholder-pseudo-style.html
fast/forms/search-styled.html
fast/forms/search-vertical-alignment.html
fast/forms/searchfield-heights.html
fast/repaint/search-field-cancel.html
fast/replaced/width100percent-searchfield.html
- platform/efl/RenderThemeEfl.cpp:
(WebCore):
(WebCore::RenderThemeEfl::supportsDataListUI):
(WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
LayoutTests:
Rebaseline related to input search field.
- platform/efl/fast/css/input-search-padding-expected.png:
- platform/efl/fast/css/input-search-padding-expected.txt:
- platform/efl/fast/css/text-input-with-webkit-border-radius-expected.png:
- platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
- platform/efl/fast/css/text-overflow-input-expected.png:
- platform/efl/fast/css/text-overflow-input-expected.txt:
- platform/efl/fast/forms/box-shadow-override-expected.png:
- platform/efl/fast/forms/box-shadow-override-expected.txt:
- platform/efl/fast/forms/control-restrict-line-height-expected.png:
- platform/efl/fast/forms/control-restrict-line-height-expected.txt:
- platform/efl/fast/forms/input-appearance-height-expected.png:
- platform/efl/fast/forms/input-appearance-height-expected.txt:
- platform/efl/fast/forms/placeholder-position-expected.png:
- platform/efl/fast/forms/placeholder-position-expected.txt:
- platform/efl/fast/forms/placeholder-pseudo-style-expected.png:
- platform/efl/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/efl/fast/forms/search-cancel-button-style-sharing-expected.png:
- platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
- platform/efl/fast/forms/searchfield-heights-expected.png:
- platform/efl/fast/forms/searchfield-heights-expected.txt:
- platform/efl/fast/repaint/search-field-cancel-expected.png:
- platform/efl/fast/repaint/search-field-cancel-expected.txt:
- platform/efl/fast/replaced/width100percent-searchfield-expected.png:
- platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
- 7:49 PM Changeset in webkit [147606] by
-
- 1 copy in tags/Safari-537.36
New Tag.
- 7:16 PM Changeset in webkit [147605] by
-
- 8 edits in trunk/LayoutTests
Unreviewed gardening. Below tests aren't related to bug 87619. It just needs to do rebaseline.
- platform/efl/TestExpectations:
- platform/efl/fast/forms/number/number-appearance-rtl-expected.png:
- platform/efl/fast/forms/number/number-appearance-rtl-expected.txt:
- platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
- platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
- platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
- platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
- 6:52 PM Changeset in webkit [147604] by
-
- 2 edits in branches/dfgFourthTier/LayoutTests
fourthTier: Just linking LLVM into JSC causes all plugin tests to fail
https://bugs.webkit.org/show_bug.cgi?id=113915
Reviewed by nobody.
This is pretty funny. I don't know, yet, what is going on, but I don't want it to block other work.
- platform/mac/TestExpectations:
- 6:39 PM Changeset in webkit [147603] by
-
- 2 edits in trunk/Tools
Re-enable WinEWS tests.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 6:16 PM Changeset in webkit [147602] by
-
- 3 edits2 adds in trunk
Input value/placeholder is not redrawn when the input height grows
https://bugs.webkit.org/show_bug.cgi?id=113845
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/forms/text/text-height-grow.html
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::styleDidChange):
We need relayout of the inner text element.
LayoutTests:
- fast/forms/text/text-height-grow-expected.html: Added.
- fast/forms/text/text-height-grow.html: Added.
- 6:10 PM Changeset in webkit [147601] by
-
- 1 edit2 adds in trunk/LayoutTests
[GTK] Unreviewed gardening. Rebaseline after r147588.
- platform/gtk-wk1/fast/writing-mode: Added.
- platform/gtk-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
- 6:02 PM Changeset in webkit [147600] by
-
- 2 edits in trunk/Source/WebCore
Add comment to clarify isStackingContext() in RenderLayer.h
https://bugs.webkit.org/show_bug.cgi?id=113909
Reviewed by Simon Fraser.
It was not obvious how the implementation of isStackingContext()
was correct, a comment is appropriate here for anyone who reads
this code in the future.
Just a change in comment, no test needed.
- rendering/RenderLayer.h:
- 5:58 PM Changeset in webkit [147599] by
-
- 16 edits1 add3 deletes in trunk/LayoutTests
[Chromium] Unreviewed gardening. Rebaseline after r147588.
- platform/chromium-mac-lion/fast/text/international/003-expected.png:
- platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.png:
- platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.txt:
- platform/chromium-mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/chromium-mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.txt: Removed.
- platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/chromium-mac/fast/text/international/003-expected.png:
- platform/chromium-mac/fast/text/international/003-expected.txt: Added.
- platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png:
- platform/chromium-mac/fast/text/international/text-combine-image-test-expected.txt:
- platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/chromium-win/fast/text/international/003-expected.png:
- platform/chromium-win/fast/text/international/003-expected.txt:
- platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/chromium/TestExpectations:
- platform/chromium/fast/text/international/003-expected.txt: Removed.
- 5:45 PM Changeset in webkit [147598] by
-
- 2 edits in trunk/Source/WebKit2
Don't try to set the exception port for server connections
https://bugs.webkit.org/show_bug.cgi?id=113910
<rdar://problem/11248925>
Reviewed by Darin Adler.
Treat a SetExceptionPort message to the server connection as an invalid message.
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::receiveSourceEventHandler):
- 5:05 PM Changeset in webkit [147597] by
-
- 3 edits in trunk/Source/WebCore
[CSS Exclusions] Removed ExclusionShape dead code
https://bugs.webkit.org/show_bug.cgi?id=113904
Reviewed by Dirk Schulze.
No new tests, just removing dead code.
- rendering/ExclusionShape.cpp:
(WebCore::ExclusionShape::createExclusionShape):
- rendering/ExclusionShape.h:
(ExclusionShape):
- 4:44 PM Changeset in webkit [147596] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed. AppleWin port gardening.
- platform/win/TestExpectations:
- platform/win/fast/lists/inlineBoxWrapperNullCheck-expected.txt: Added.
- 4:16 PM Changeset in webkit [147595] by
-
- 2 edits in trunk/Source/WTF
Enable HAVE_MADV_FREE_REUSE on iOS
https://bugs.webkit.org/show_bug.cgi?id=113892
<rdar://problem/12787563>
Reviewed by Mark Rowe.
- wtf/Platform.h:
- 3:58 PM Changeset in webkit [147594] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Switch MediaPlayerPrivateBlackBerry.cpp's timer to use CLOCK_MONOTONIC
https://bugs.webkit.org/show_bug.cgi?id=113900
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-04-03
Reviewed by Rob Buis.
Internally Reviewed by Jeff Rogers.
Timers should use CLOCK_MONOTONIC to avoid undesirable effects when
the user switches the system time.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::drawBufferingAnimation):
- 3:54 PM Changeset in webkit [147593] by
-
- 2 edits in trunk/Source/WebKit2
<http://webkit.org/b/113898> Eliminate some code duplication by introducing an array of handlers to register / unregister.
Reviewed by Antti Koivisto.
- UIProcess/mac/WebContextMac.mm:
(OcclusionNotificationHandler): Structure containing the notification name, type and handler.
(WebKit::registerOcclusionNotificationHandlers): Register all of the handlers in the array.
(WebKit::unregisterOcclusionNotificationHandlers): Unregister all of the handlers in the array.
- 3:54 PM Changeset in webkit [147592] by
-
- 2 edits in trunk/Source/WebKit2
Enable process suppression when no windows in the application have drawn recently.
<http://webkit.org/b/113854> / <rdar://problem/13540351>
Reviewed by Darin Adler.
- UIProcess/mac/WebContextMac.mm:
(WebKit::applicationWindowModificationsStarted): Note that modifications are no longer stopped.
(WebKit::applicationWindowModificationsStopped): Note that modifications have stopped.
(WebKit::registerOcclusionNotificationHandlers): Register handlers for the start and stop notifications.
(WebKit::unregisterOcclusionNotificationHandlers): Unregister handlers for the start and stop notifications.
(WebKit::WebContext::canEnableProcessSuppressionForNetworkProcess): Allow suppression if the application is occluded
or the application has not drawn recently.
(WebKit::WebContext::canEnableProcessSuppressionForWebProcess): Ditto.
(WebKit::WebContext::canEnableProcessSuppressionForGlobalChildProcesses): Ditto.
- 3:35 PM Changeset in webkit [147591] by
-
- 9 edits4 adds in trunk
Unable to focus on embedded plugins such as Flash via javascript focus()
https://bugs.webkit.org/show_bug.cgi?id=32292
Patch by Dave Michael <dmichael@chromium.org> on 2013-04-03
Reviewed by Ryosuke Niwa.
Source/WebCore:
Make embed, object, and applet elements support focus() when
appropriate. Prior to this patch, javascript focus() had no effect on
embed, object, or applet elements unless tabindex or contenteditable is
set. With this patch, focus() will focus the element unless the plugin
content has failed to load (i.e., we are showing either fallback content
or an unavailable plugin indicator).
Test: plugins/focus.html
java/focus.html
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::supportsFocus):
Overridden to return true except when the plugin content has failed to load.
- html/HTMLPlugInElement.h:
(WebCore::HTMLPlugInElement::useFallbackContent):
Moved up from HTMLPlugInImageElement.
(WebCore::HTMLPlugInElement::supportsFocus):
- html/HTMLPlugInElement.h:
(WebCore::HTMLPlugInImageElement::useFallbackContent):
Removed. Now the implementation is inherited from HTMLPlugInElement.
LayoutTests:
Add/update testing to ensure embed, object, and applet tags now support
focus except when plugin content did not load.
- fast/events/resources/tabindex-focus-blur-all-frame1.html: Change embed and object
elements to reference an invalid plugin, to be consistent with applet. These
element types are not focusable when there is valid plugin content.
- fast/events/resources/tabindex-focus-blur-all-frame2.html: Same as above.
- fast/events/resources/tabindex-focus-blur-all-iframe1.html: Same as above.
- fast/events/resources/tabindex-focus-blur-all-iframe2.html: Same as above.
- java/focus-expected.txt: Added.
- java/focus.html: Added.
- plugins/focus-expected.txt: Added.
- plugins/focus.html: Added.
- 3:33 PM Changeset in webkit [147590] by
-
- 4 edits in tags/Safari-537.35.7/Source
Versioning.
- 3:18 PM Changeset in webkit [147589] by
-
- 1 copy in tags/Safari-537.35.7
New Tag.
- 2:53 PM Changeset in webkit [147588] by
-
- 12 edits5 adds in trunk
Element boundaries prevent Japanese line break opportunities
https://bugs.webkit.org/show_bug.cgi?id=105692
Reviewed by Darin Adler.
Source/WebCore:
Introduce use of prior context when using text break iterators
in non-ASCII path through nextBreakablePosition(). This enables
the use of line break context across an element boundary for
the non-ASCII path. Use of this context with the ASCII path was
enabled by https://bugs.webkit.org/show_bug.cgi?id=17427.
Performance tests of line layout and html5 parsing show that this
patch provides an approximately 4% improvement with Japanese and
no statistically significant regression with ASCII path. Parsing
(html5-full-render) performance is not significantly affected.
Tests: fast/text/line-break-between-text-nodes-cjk.html
fast/text/line-break-between-text-nodes-latin1.html
Expect rebaselines will be needed due to different line breaks:
fast/text/international/003.html
fast/text/international/text-combine-image-test-expected.html
fast/text/writing-mode/Kusa-Makura-background-canvas.html
- platform/text/TextBreakIterator.cpp:
(WebCore::acquireLineBreakIterator): Pass prior context to non-ICU path.
- platform/text/TextBreakIterator.h:
(WebCore::LazyLineBreakIterator::priorContextLength): Added.
(WebCore::LazyLineBreakIterator::get): Pass prior context to ICU path.
(WebCore::LazyLineBreakIterator::resetStringAndReleaseIterator): Editorial.
- platform/text/TextBreakIteratorICU.cpp:
Use prior context from line break iterators. Requires
adding new UTF16 (UChar*) text provider and reimplementing
Latin1 (LChar*) text provider. Implementation is optimized
by using generic functionality that applies to both string
sources.
(WebCore::textPinIndex): Added.
(WebCore::textNativeLength): Added.
(WebCore::textFixPointer): Added.
(WebCore::textClone): Added.
(WebCore::textExtract): Added.
(WebCore::textClose): Added.
(WebCore::textGetContext): Added.
(WebCore::textLatin1GetCurrentContext): Added.
(WebCore::textLatin1MoveInPrimaryContext): Added.
(WebCore::textLatin1SwitchToPrimaryContext): Added.
(WebCore::textLatin1MoveInPriorContext): Added.
(WebCore::textLatin1SwitchToPriorContext): Added.
(WebCore::textInChunkOrOutOfRange): Added.
(WebCore::textLatin1Access): Added.
(WebCore::textInit): Added.
(WebCore::textOpenLatin1): Added.
(WebCore::textUTF16GetCurrentContext): Added.
(WebCore::textUTF16MoveInPrimaryContext): Added.
(WebCore::textUTF16SwitchToPrimaryContext): Added.
(WebCore::textUTF16MoveInPriorContext): Added.
(WebCore::textUTF16SwitchToPriorContext): Added.
(WebCore::textUTF16Access): Added.
(WebCore::textOpenUTF16): Added.
(WebCore::acquireLineBreakIterator): Use new text providers with prior context.
- platform/text/wchar/TextBreakIteratorWchar.cpp:
(WebCore::acquireLineBreakIterator): Pass prior context to non-ICU path.
- rendering/break_lines.cpp:
(WebCore::nextBreakablePosition): Use prior context in ICU path.
LayoutTests:
- fast/text/line-break-between-text-nodes-cjk-expected.html: Added.
- fast/text/line-break-between-text-nodes-cjk.html: Added.
- fast/text/line-break-between-text-nodes-latin1-expected.html: Added.
- fast/text/line-break-between-text-nodes-latin1.html: Added.
- platform/chromium-linux/fast/text/international/003-expected.png: Rebaselined.
- platform/chromium-linux/fast/text/international/003-expected.txt: Rebaselined.
- platform/chromium-linux/fast/text/international/text-combine-image-test-expected.png: Rebaselined.
- platform/chromium-linux/fast/text/international/text-combine-image-test-expected.txt: Added (previously missing).
- platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Rebaselined.
- platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Rebaselined.
- 2:53 PM Changeset in webkit [147587] by
-
- 13 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Everyone should know about the FTL
https://bugs.webkit.org/show_bug.cgi?id=113897
Reviewed by Mark Hahnenberg.
In order to get OSR exit to work right, we need the distinction between DFG and
FTL to be clear even after compilation finishes, since they will have subtly
different OSR stories and likely use different data structures.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetStubInternal):
(JSC::ProgramCodeBlock::compileOptimized):
(JSC::EvalCodeBlock::compileOptimized):
(JSC::FunctionCodeBlock::compileOptimized):
(JSC::CodeBlock::adjustedExitCountThreshold):
(JSC::CodeBlock::tallyFrequentExitSites):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::hasOptimizedReplacement):
(JSC::ExecState::isInlineCallFrame):
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::JITCode):
- ftl/FTLState.cpp:
(JSC::FTL::State::dumpState):
- heap/DFGCodeBlocks.cpp:
(JSC::DFGCodeBlocks::jettison):
- interpreter/Interpreter.cpp:
(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):
- jit/JITCode.cpp:
(WTF::printInternal):
- jit/JITCode.h:
(JSC::JITCode::topTierJIT):
(JSC::JITCode::nextTierJIT):
(JITCode):
(JSC::JITCode::isJIT):
(JSC::JITCode::isLowerTier):
(JSC::JITCode::isHigherTier):
(JSC::JITCode::isLowerOrSameTier):
(JSC::JITCode::isHigherOrSameTier):
(JSC::JITCode::isOptimizingJIT):
- jit/JITDriver.h:
(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/Executable.cpp:
(JSC::EvalExecutable::compileOptimized):
(JSC::samplingDescription):
(JSC::ProgramExecutable::compileOptimized):
(JSC::FunctionExecutable::compileOptimizedForCall):
(JSC::FunctionExecutable::compileOptimizedForConstruct):
- 2:51 PM Changeset in webkit [147586] by
-
- 4 edits2 adds in branches/safari-534.59-branch/Source/WebKit2
Fix the build after merging 147042.
- Platform/mac/StringUtilities.h: Added.
(WebKit):
- Platform/mac/StringUtilities.mm: Added.
(WebKit):
(WebKit::nsStringFromWebCoreString):
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKContextCopyPlugInInfoForBundleIdentifier):
- UIProcess/Plugins/PluginInfoStore.h:
(PluginInfoStore):
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::findPluginWithBundleIdentifier):
- 2:35 PM Changeset in webkit [147585] by
-
- 3 edits in trunk/LayoutTests
get_by_pname can become confused when iterating over objects with static properties
https://bugs.webkit.org/show_bug.cgi?id=113831
Reviewed by Jer Noble.
Improving the test results to make it more obvious why something failed. Also removed
absolute paths from the test.
- fast/js/dom-static-property-for-in-iteration-expected.txt:
- fast/js/dom-static-property-for-in-iteration.html:
- 2:21 PM Changeset in webkit [147584] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed VS2010 build fix.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 2:08 PM Changeset in webkit [147583] by
-
- 10 edits2 deletes in trunk/Source
[Chromium] Bad cast from BitmapImageSingleFrameSkia to BitmapImage
https://bugs.webkit.org/show_bug.cgi?id=113492
Reviewed by Stephen White.
Source/WebCore:
Remove BitmapImageSingleFrameSkia and have ImageBufferSkia construct
BitmapImage objects instead via an intermediate NativeImageSkia.
No new tests, covered by existing tests.
- WebCore.gypi:
- platform/graphics/filters/skia/FEGaussianBlurSkia.cpp: Remove
include for BitmapImageSingleFrameSkia.h header.
- platform/graphics/skia/BitmapImageSingleFrameSkia.cpp: Removed.
- platform/graphics/skia/BitmapImageSingleFrameSkia.h: Removed.
- platform/graphics/skia/ImageBufferSkia.cpp: Construct BitmapImage
objects instead of BitmapImageSingleFrameSkia ones.
(WebCore::ImageBuffer::copyImage):
(WebCore::drawNeedsCopy):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
- platform/graphics/skia/ImageSkia.cpp:
(WebCore::BitmapImage::BitmapImage): Implement BitmapImage constructor
that takes an NativeImageSkia* in argument.
(WebCore):
(WebCore::BitmapImage::draw): Remove m_source.initialized() check as
this will return false for BitmapImage objects constructed from a
NativeImageSkia, due to the lack of decoder.
- platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::NativeImageSkia): Add parameter to the
NativeImageSkia constructor so that the caller can request a deep copy
instead of a shallow one. This is needed by the ImageBuffer.
- platform/graphics/skia/NativeImageSkia.h:
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageFrame::setSkBitmap):
Source/WebKit/chromium:
Update test now that BitmapImageSingleFrameSkia no longer exists.
BitmapImage is now used instead.
- tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):
- 1:57 PM Changeset in webkit [147582] by
-
- 4 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG should abstract out how it does forward exits, and that code should be simplified
https://bugs.webkit.org/show_bug.cgi?id=113894
Reviewed by Mark Hahnenberg.
1) We previously had two different ways of convertingToForward, one path for
where we had a ValueRecovery for the current node and one where we didn't.
But the paths were doing exactly the same thing except that if you have a
ValueRecovery, you also find the last applicable mov hint and do some
extra things. This patch combines the two paths and bases both of them on
the previous no-ValueRecovery path, which was simpler to begin with.
2) This moves the logic into DFG::OSRExit, which further simplifies the code
and makes the logic available to the FTL.
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::convertToForward):
(DFG):
- dfg/DFGOSRExit.h:
(DFG):
(OSRExit):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
- 1:44 PM Changeset in webkit [147581] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: resultAnimationElement->m_animatedType
https://bugs.webkit.org/show_bug.cgi?id=93528
Patch by David Vest <davve@opera.com> on 2013-04-03
Reviewed by Philip Rogers.
Source/WebCore:
When the order of animation elements change within an animation
group, we can't assume that the resultElement is the same as it
was when the animation was frozen. Make sure to reset the
animation type for the resultElement before updating the
animation.
Test: svg/animations/animation-dependency-crash.html
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::progress):
LayoutTests:
- svg/animations/animation-dependency-crash-expected.txt: Added.
- svg/animations/animation-dependency-crash.html: Added.
- 1:39 PM Changeset in webkit [147580] by
-
- 3 edits in trunk/Source/WebCore
Stop unconditionally enabling JavaScript execution when closing the Web Inspector.
https://webkit.org/b/113889
rdar://problem/12281794
Reviewed by Joseph Pecoraro.
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::InspectorPageAgent): Initialize m_originalScriptExecutionDisabled.
(WebCore::InspectorPageAgent::enable): Populate m_originalScriptExecutionDisabled based on current setting.
(WebCore::InspectorPageAgent::disable): Restore previous setting.
- inspector/InspectorPageAgent.h:
(InspectorPageAgent): Added m_originalScriptExecutionDisabled.
- 1:13 PM Changeset in webkit [147579] by
-
- 10 edits in trunk/Source
Cross fade into restarted plugin
https://bugs.webkit.org/show_bug.cgi?id=113868
Reviewed by Tim Horton.
Source/WebCore:
Allow a restarted plugin to fade in over its snapshot, avoiding the abrupt
flash of empty content. The WebCore part of this patch marks the plugin
element as restarted, and draws the snapshot for a short amount of time
as the plugin is restarting. After the plugin has reappeared, we stop drawing
the snapshot.
There is a little bit of drive-by whitespace removal in HTMLPlugInImageElement.
- html/HTMLPlugInElement.h:
(WebCore::HTMLPlugInElement::restartedPlugin): New method indicating if the plugin has been restarted.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Initialise new timer and member variable.
(WebCore::HTMLPlugInImageElement::setDisplayState): If we are moving into a restarting state, make sure
to remember this and also start a timer so that we show the snapshot for while.
(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired): No need to draw the snapshot from here on.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): Member variable to remember if we've restarted.
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintContents): Only exit early from the paint if we're not a restarting
plugin, otherwise we do want to draw the snapshot if there is one.
- rendering/RenderLayerBacking.cpp:
(WebCore::isRestartedPlugin): Detects a restarted plugin.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): Don't become a simple container
compositing layer if you're a restarted plugin.
Source/WebKit2:
Add a new plugin process type that indicates this is a plugin that
has been restarted from snapshotting. On Apple ports, this allows
us to animate the appearance of the plugin so that it crossfades
with the snapshot. Other ports will have to add their own fading.
- PluginProcess/PluginProcess.h: New Type: TypeRestartedProcess.
- WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
(WebKit::PluginProxy::pluginLayer): When the plugin's CALayer is created, if it
is a restarted plugin, add an opacity animation to fade it in.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin): Mark restarted plugins with the new process type.
- 1:05 PM Changeset in webkit [147578] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Adjustments to media controls appearance.
https://bugs.webkit.org/show_bug.cgi?id=113816
https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=316398
https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=316438
Updates to the BlackBerry media controls:
- extend the timeline slider.
- move the volume slider for audio elements up so it does not overlap the main panel.
- upstream some other cosmetic changes to media controls that were not previously upstreamed.
Patch by John Griggs <jgriggs@blackberry.com> on 2013-04-03
Reviewed by Rob Buis.
BlackBerry-specific, cosmetic change; No new tests required.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
(WebCore::RenderThemeBlackBerry::paintMediaPlayButton):
(WebCore::RenderThemeBlackBerry::paintMediaMuteButton):
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderThumb):
- 12:53 PM Changeset in webkit [147577] by
-
- 5 edits in trunk/LayoutTests
Compositing tests failing after http://trac.webkit.org/changeset/147502
https://bugs.webkit.org/show_bug.cgi?id=113838
Reviewed by Dean Jackson.
Add (contentsOpaque 1) to the DRT text output in some expectations files due to bug 70634
"Mark GraphicsLayers as opaque when possible" [1]. The expectations in the guilty changeset
weren't updated after bug 70634 landed.
[1]: https://bugs.webkit.org/show_bug.cgi?id=70634
- compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
- platform/mac/TestExpectations:
- 12:41 PM Changeset in webkit [147576] by
-
- 3 edits in branches/dfgFourthTier/WebKitLibraries
Updated LLVM drops to include LLVM_DO_NOT_INCLUDE_CPP_HEADERS changes.
Rubber stamped by Mark Hahnenberg.
- LLVMIncludesMountainLion.tar.bz2:
- LLVMLibrariesMountainLion.tar.bz2:
- 12:29 PM Changeset in webkit [147575] by
-
- 2 edits in branches/safari-534.59-branch/Source/WebKit2
Remove include after mis-merge of r147052.
- UIProcess/API/C/WKAPICast.h:
- 12:16 PM Changeset in webkit [147574] by
-
- 3 edits in trunk/Tools
[GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
https://bugs.webkit.org/show_bug.cgi?id=113883
Reviewed by Martin Robinson.
- gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
- gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
- 12:08 PM Changeset in webkit [147573] by
-
- 3 edits in branches/chromium/1453/Source/WebCore/platform/image-decoders/gif
Merge 147392 "Simply GIFImageReader error handling"
Simply GIFImageReader error handling
https://bugs.webkit.org/show_bug.cgi?id=113718
Reviewed by Adam Barth.
When GIFImageReader encounters a parsing error it should just return
without doing any more work. Current code saves a boolean before return,
this is not necessary.
Tested with existing unit tests.
Tested locally with ASAN build with 60k GIF images.
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::repetitionCount):
- platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::decode):
- platform/image-decoders/gif/GIFImageReader.h:
(GIFImageReader::GIFImageReader):
(GIFImageReader):
TBR=hclam@chromium.org
Review URL: https://codereview.chromium.org/13578002
- 11:58 AM Changeset in webkit [147572] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13564588> Add a temporary workaround for a build failure.
Fix suggested by Mark Rowe.
- Shared/mac/ChildProcessMac.mm:
- 11:47 AM Changeset in webkit [147571] by
-
- 8 edits in branches/safari-534.59-branch/Source/WebKit2
Merge 147052. <rdar://problem/13528851>
- 11:38 AM Changeset in webkit [147570] by
-
- 5 edits2 adds in trunk
get_by_pname can become confused when iterating over objects with static properties
https://bugs.webkit.org/show_bug.cgi?id=113831
Reviewed by Geoffrey Garen.
get_by_pname doesn't take static properties into account when using a JSPropertyNameIterator to directly
access an object's backing store. One way to fix this is to not cache any properties when iterating over
objects with static properties. This patch fixes the bug that was originally reported on swisscom.ch.
Source/JavaScriptCore:
- runtime/JSObject.cpp:
(JSC::JSObject::getOwnNonIndexPropertyNames):
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
- runtime/PropertyNameArray.h:
(JSC::PropertyNameArray::PropertyNameArray):
(JSC::PropertyNameArray::numCacheableSlots):
(JSC::PropertyNameArray::setNumCacheableSlots):
(PropertyNameArray):
LayoutTests:
- fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
- fast/js/dom-static-property-for-in-iteration.html: Added.
- 11:27 AM Changeset in webkit [147569] by
-
- 3 edits in trunk/WebKitLibraries
[Windows, WinCairo] Unreviewed VS2010 Build Correction
- win/tools/scripts/auto-version2010.sh: Added properties svn:eol-style and svn:executable.
- win/tools/scripts/feature-defines2010.sh: Added properties svn:eol-style and svn:executable.
- 11:23 AM Changeset in webkit [147568] by
-
- 5 edits in trunk/Source/WebKit2
[WK2] XMLHttpRequest upload events don't work with NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=113887
Reviewed by Brady Eidson.
Just forward didSendData client call to WebProcess.
- NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::didSendData): (WebKit::NetworkResourceLoader::didCancelAuthenticationChallenge): Tweaked a comment.
- WebProcess/Network/WebResourceLoader.cpp: (WebKit::WebResourceLoader::didSendData):
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Network/WebResourceLoader.messages.in:
- 11:12 AM Changeset in webkit [147567] by
-
- 2 edits in trunk/Source/WebCore
[Gstreamer] Use gst_buffer_extract() in copyGstreamerBuffersToAudioChannel()
https://bugs.webkit.org/show_bug.cgi?id=113880
Reviewed by Philippe Normand.
copyGstreamerBuffersToAudioChannel() was mapping the GstBuffer content to memcpy
it to the AudioChannel buffer. This patch leverages gst_buffer_extract() to
simplify the code as it does exactly what we need: gst_buffer_map, memcpy,
gst_buffer_unmap and error handling.
Also replace GstBuffer NULL check by an assertion as we already make sure they
are not NULL before adding them to the list. Additionally, we now call
audioChannel->mutableData() only once instead of once per iteration. It is
a bit better as the getter does some work internally.
No new tests, no behavior change.
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::copyGstreamerBuffersToAudioChannel):
- 10:30 AM Changeset in webkit [147566] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: DOM.highlightRect() and DOM.highlightQuad() should allow for page coordinates
https://bugs.webkit.org/show_bug.cgi?id=113869
Add a new "usePageCoordinates" parameter to DOM.highlightRect() and DOM.highlightQuad()
allowing to specify that the rect or quad to highlight should be converted to page
coordinates instead of using the default viewport coordinates.
Reviewed by Timothy Hatcher.
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightQuad):
(WebCore::InspectorDOMAgent::innerHighlightQuad):
Store the "usePageCoordinates" parameter obtained from the protocol calls onto the
highlight configuration object so that it may be used within the InspectorOverlay.
- inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::highlightQuad):
Check the highlight configuration for the "usePageCoordinates" parameter and
apply the inverse of the page's scroll offset to the quad if it's true.
- inspector/InspectorOverlay.h:
(HighlightConfig):
(WebCore::Highlight::setDataFromConfig):
(Highlight):
- 9:43 AM Changeset in webkit [147565] by
-
- 2 edits in trunk/Source/WebCore
Add omitted reference operator of VisiblePosition in AccessibilityObject
https://bugs.webkit.org/show_bug.cgi?id=113879
Reviewed by Darin Adler.
Seems reference operator has been omitted in startOfStyleRange function, so add it.
- accessibility/AccessibilityObject.cpp:
(WebCore::startOfStyleRange):
- 9:35 AM Changeset in webkit [147564] by
-
- 2 edits in trunk/Tools
[GTK] Include Pango in jhbuild-optional.modules
https://bugs.webkit.org/show_bug.cgi?id=113878
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-03
Reviewed by Martin Robinson.
Since r147547 Pango 1.32.0 is required. Including the module in the
JHBuild optional moduleset.
- gtk/jhbuild-optional.modules: Add Pango module.
- 9:27 AM Changeset in webkit [147563] by
-
- 5 edits in trunk/Tools
[Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
https://bugs.webkit.org/show_bug.cgi?id=113864
Moving setDefersLoading from TestRunnerQt to TestRunner
requires access to the non-Qt TestRunner.
As long as we instantiate both TestRunner and TestRunnerQt,
we need a separate getter for the non-Qt TestRunner instance.
Reviewed by Simon Hausmann.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebPage::resetSettings):
- DumpRenderTree/qt/DumpRenderTreeQt.h:
(DumpRenderTree::jscTestRunner):
- DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::setDefersLoading):
Moving setDefersLoading from TestRunnerQt
to TestRunner.
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):
- 9:12 AM Changeset in webkit [147562] by
-
- 2 edits in trunk/Source/WebCore
Update the localizable strings file.
Rubber-stamped by Michael Saboff.
- English.lproj/Localizable.strings:
- 8:58 AM Changeset in webkit [147561] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX (r147493): Fix number of arguments to AudioDestinationIOS constructor
Fixes the following build failures:
Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:84:25: error: no matching constructor for initialization of 'WebCore::AudioDestinationIOS'
return adoptPtr(new AudioDestinationIOS(callback, sampleRate));
In file included from Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:36:
Source/WebCore/platform/audio/ios/AudioDestinationIOS.h:44:5: note: candidate constructor not viable: requires 3 arguments, but 2 were provided
AudioDestinationIOS(AudioIOCallback&, unsigned numberOfOutputChannels, double sampleRate);
Source/WebCore/platform/audio/ios/AudioDestinationIOS.h:42:7: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 2 were provided
class AudioDestinationIOS : public AudioDestination, public AudioSessionListener {
Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:101:22: error: out-of-line definition of 'AudioDestinationIOS' does not match any declaration in 'WebCore::AudioDestinationIOS'
AudioDestinationIOS::AudioDestinationIOS(AudioIOCallback& callback, double sampleRate)
2 errors generated.
- platform/audio/ios/AudioDestinationIOS.h:
(AudioDestinationIOS): Remove numberOfOutputChannels argument.
- 8:51 AM Changeset in webkit [147560] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX (r147494): -[AVAudioSession setCategory:error:] takes NSError
Fixes the following build failure:
Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:151:71: error: cannot initialize a parameter of type 'NSError ' with an lvalue of type 'NSError *'
[[AVAudioSession sharedInstance] setCategory:categoryString error:error];
- platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSession::setCategory): Add '&' operator.
- 8:45 AM Changeset in webkit [147559] by
-
- 2 edits in trunk/Tools
[GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
https://bugs.webkit.org/show_bug.cgi?id=104779
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-03
Reviewed by Carlos Garcia Campos.
- Scripts/run-gtk-tests:
(TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
passing in current trunk.
- 8:45 AM Changeset in webkit [147558] by
-
- 8 edits2 adds in trunk
CSP blocks inline style when cloning a node
https://bugs.webkit.org/show_bug.cgi?id=112270
Patch by Felipe Zimmerle <felipe@zimmerle.org> on 2013-04-03
Reviewed by Adam Barth.
Source/WebCore:
Checks if the Element is being cloned, if so, the application of the
style is allowed otherwise it relies on default permission mechanism.
Test: http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects.html
- dom/Element.cpp:
(WebCore::Element::attributeChanged): Added parameter
AttributeModificationReason to the method signature.
(WebCore::Element::cloneAttributesFromElement): It is now calling
attributeChanged with AttributeModificationReason parameter. In this scope
it is always set to ModifiedByCloning.
(WebCode::Element::attributeChangedFromParserOrByCloning):
Added parameter AttributeModificationReason.
- dom/Element.h: Added AttributeModificationReason enum. Used to specify
whenever an attribute was set by a cloned oject or directly.
AttributeModificationReason added to attributeChanged with the default
value set to ModifiedDirectly.
- dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged): Added
AttributeModificationReason to the method signature.
(WebCore::StyledElement::styleAttributeChanged): Now it is checking the
reason of the update, if the reason is ModifiedDirectly check CSP
before set. If ModifiedByCloning set the attribute ignoring the CSP
policy.
- dom/StyledElement.h:
(StyledElement): Added AttributeModificationReason parameter to the methods:
attributeChanged and styleAttributeChanged, attributeChanged has
ModifiedDirectly as default value.
- svg/SVGElement.cpp:
(WebCore::SVGElement::attributeChanged): Added AttributeModificationReason
parameter to the method signature.
- svg/SVGElement.h:
(SVGElement): Added AttributeModificationReason parameter to the
attributeChanged signature with the default value set to:
ModifiedDirectly.
LayoutTests:
- http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects.html: Added.
- 8:18 AM Changeset in webkit [147557] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] WebKitWebNavigationAction: fix mix between dispose and finalize
https://bugs.webkit.org/show_bug.cgi?id=113794
Patch by Alban Crequy <alban.crequy@collabora.co.uk> on 2013-04-03
Reviewed by Gustavo Noronha Silva.
WebKitWebNavigationAction's dispose function was named finalize and was calling
the parent class's finalise function, causing a memory corruption. Change it to
be a proper finalize function instead.
- webkit/webkitwebnavigationaction.cpp:
(webkit_web_navigation_action_class_init):
- 8:11 AM Changeset in webkit [147556] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed 32bit buildfix after r147542.
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::didReceiveBinaryData):
- 8:09 AM Changeset in webkit [147555] by
-
- 2 edits in trunk/Source/WebCore
[Gstreamer] Avoid calls to g_slist_nth_data in webKitWebAudioSrcLoop()
https://bugs.webkit.org/show_bug.cgi?id=113875
Reviewed by Philippe Normand.
webKitWebAudioSrcLoop() was iterating over 2 GSLists by using a counter and then
calling g_slist_nth_data() to get the element of each GSList. This is inefficient
because calling g_slist_nth_data() will iterate the GSList up until index 'n'.
This patch improves this by keeping pointers to the current element of each list
while iterating, so that we can simply use g_slist_next() to iterate instead
of g_slist_nth_data().
No new tests, no behavior change.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcLoop):
- 8:04 AM Changeset in webkit [147554] by
-
- 4 edits in trunk/Source/WebCore
Actions that require user gesture don't work in window.showModalDialog in Chromium
https://bugs.webkit.org/show_bug.cgi?id=113777
Reviewed by Jochen Eisinger.
In Chromium the window for showModalDialog is not modal which causes the
UserGestureIndicator to block actions in the sub window. We introduce a
RAII that saves the UserGestureIndicator and state, then resets it before
runModalDialog, and restore it when it's done.
No new tests. Can't cause user gesture inside modal dialog.
- dom/UserGestureIndicator.cpp:
(WebCore::UserGestureIndicatorDisabler::UserGestureIndicatorDisabler): Saves and resets the topmost indicator and state.
(WebCore):
(WebCore::UserGestureIndicatorDisabler::~UserGestureIndicatorDisabler): Restores topmost indicator and state.
- dom/UserGestureIndicator.h:
(WebCore):
(UserGestureIndicatorDisabler): RAII to temporarily disable UserGestureIndicator.
(UserGestureIndicator): Allow access to UserGestureIndicatorDisabler.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::showModalDialog): Disable UserGestureIndicator while runModalDialog.
- 8:02 AM Changeset in webkit [147553] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fail gracefully if an OpenGL context could not be created.
https://bugs.webkit.org/show_bug.cgi?id=113784
In case we fail to create or adopt a valid platform OpenGL context
we do not want to provide a GraphicsContext3D instance.
Otherwise we would crash as soon as the instance is being used.
Reviewed by Jocelyn Turcotte.
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3D::GraphicsContext3D):
- 7:36 AM Changeset in webkit [147552] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove defaultViewportArguments check from call site of recomputeVirtualViewportFromViewportArguments
https://bugs.webkit.org/show_bug.cgi?id=113872
Reviewed by Carlos Garcia Campos.
Carlos pointed out that recomputeVirtualViewportFromViewportArguments
already contains the check, and returns an empty IntSize if it fails.
So pick up on that to make the code a bit more DRY.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
- 7:23 AM Changeset in webkit [147551] by
-
- 15 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening. Updated platform specific expected files after r147492.
- platform/qt/TestExpectations:
- platform/qt/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/qt/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
- platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
- platform/qt/fast/encoding/utf-16-big-endian-expected.png:
- platform/qt/fast/encoding/utf-16-big-endian-expected.txt:
- platform/qt/fast/encoding/utf-16-little-endian-expected.png:
- platform/qt/fast/encoding/utf-16-little-endian-expected.txt:
- platform/qt/fast/forms/input-value-expected.png: Added.
- platform/qt/fast/forms/input-value-expected.txt:
- platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.png:
- platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.txt:
- platform/qt/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/qt/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
- 7:15 AM Changeset in webkit [147550] by
-
- 2 edits in trunk/Tools
Fix HAVE(QTTESTSUPPORT) logic
build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
resulting in HAVE(QTTESTSUPPORT) never being true.
Move that logic down in sanitizeFeatures.
Patch by Pierre Rossi <pierre.rossi@digia.com> on 2013-04-03
Rubber-stamped by Tor Arne Vestbø.
- qmake/mkspecs/features/features.prf:
- 6:23 AM Changeset in webkit [147549] by
-
- 3 edits in trunk/Source/WebCore
[GTK][AC] Implement matrix keyframe animations with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=110314
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-03
Reviewed by Gustavo Noronha Silva.
Clutter 1.12 doesn't support additive transform animations yet, So clutter ac backend
uses matrix animations for the case. This patch follows changeset 143369, 143343
to support matrix keyframe animations. I believe this change is easy if you understand
above two changesets.
Covered by existing animation tests.
- platform/graphics/clutter/PlatformClutterAnimation.cpp:
(WebCore::PlatformClutterAnimation::setValues):
(WebCore::PlatformClutterAnimation::addClutterKeyframeTransitionForProperty):
(WebCore):
(WebCore::PlatformClutterAnimation::addTransformTransition):
- platform/graphics/clutter/PlatformClutterAnimation.h:
(PlatformClutterAnimation):
- 6:20 AM Changeset in webkit [147548] by
-
- 11 edits2 adds in trunk
Should close select popup when the element loses focus
https://bugs.webkit.org/show_bug.cgi?id=113220
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-04-03
Reviewed by Kent Tamura.
Source/WebCore:
Test: fast/forms/select-popup-closes-on-blur.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): handle the blur event, closing
the popup menu if any.
- testing/Internals.cpp:
(WebCore::Internals::isSelectPopupVisible): utility to query the select node renderer to
find out whether the popup is open or closed.
(WebCore):
- testing/Internals.h: add the new method definition.
- testing/Internals.idl: ditto.
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in: export WebCore::HTMLNames::selectTag for Internals
LayoutTests:
- fast/forms/select/popup-closes-on-blur-expected.txt: Added.
- fast/forms/select/popup-closes-on-blur.html: Added.
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- 6:20 AM Changeset in webkit [147547] by
-
- 4 edits in trunk
[GTK] Bump required versions of some dependencies
https://bugs.webkit.org/show_bug.cgi?id=113282
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-03
Reviewed by Martin Robinson.
.:
This patch updates the following dependencies:
- libsoup 2.42.0: is the current stable release.
- glib 2.36.0: libsoup 2.42 requires 2.35.0, but we don't want to depend on unstable versions and 2.36 is the next stable version after 2.35.
- gtk+ 3.6.0: this is the previous stable release. We don't currently have any code using newer API, so we will be able to remove all the #ifdefed code.
- at-spi2 2.5.3: is the version required by gtk+ 3.6.
- GObject introspection 1.32.0: is the version required by gtk+ 3.6.
- Pango 1.32.0: it's the current stable version and the first one depending on Harfbuzz.
- Fontconfig 2.5: required by pango 1.32.0 when using Harfbuzz.
- gtk+ 2.24.10: it allows us to remove a lot of deprecated code and #ifdefs.
- Source/autotools/Versions.m4:
Tools:
- gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
- 6:12 AM Changeset in webkit [147546] by
-
- 2 edits in trunk/Tools
[GTK] gst-plugins-good fails to build with newer Linux(v4l2)
https://bugs.webkit.org/show_bug.cgi?id=113809
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-04-03
Reviewed by Philippe Normand.
Newer Linux kernels have removed some deprecated macros from v4l2
headers, causing gst-plugins-good's build to break. We don't need it
right now, so just disable it.
- gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
- 5:44 AM Changeset in webkit [147545] by
-
- 12 edits in trunk
[Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
https://bugs.webkit.org/show_bug.cgi?id=113535
Reviewed by Simon Hausmann.
Source/WebCore:
Now Qt uses the CROSS_PLATFORM_CONTEXT_MENUS
USE flag. This flag provides a full cross-platform
representation of a ContextMenu and a ContextMenuItem.
The embedder can then decide how to show this, so neither
WebCore nor WebCore/platform need to know any platform
specifics about menus.
No new tests, no behavior changes.
- Target.pri:
- platform/ContextMenu.h:
(ContextMenu):
- platform/ContextMenuItem.h:
- platform/qt/ContextMenuItemQt.cpp:
(WebCore::ContextMenuItem::platformContextMenuItem):
- platform/qt/ContextMenuQt.cpp:
(WebCore::ContextMenu::ContextMenu):
(WebCore::ContextMenu::getContextMenuItems):
(WebCore::ContextMenu::createPlatformContextMenuFromItems):
(WebCore::ContextMenu::platformContextMenu):
Source/WebKit/qt:
Adjust ContextMenuClientQt and QWebPageAdapter to use CROSS_PLATFORM_CONTEXT_MENUS
USE flag by implementing customizeMenu() instead of getCustomMenuFromDefaultItems()
and by calling menu->items() instead of menu->platformDescription().
- WebCoreSupport/ContextMenuClientQt.cpp:
(WebCore::ContextMenuClientQt::customizeMenu):
- WebCoreSupport/ContextMenuClientQt.h:
(ContextMenuClientQt):
- WebCoreSupport/QWebPageAdapter.cpp:
(descriptionForPlatformMenu):
(QWebPageAdapter::updatePositionDependentMenuActions):
Tools:
Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
- qmake/mkspecs/features/features.prf:
- 5:35 AM Changeset in webkit [147544] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Monospace font does not render in proper sizes
https://bugs.webkit.org/show_bug.cgi?id=93263
Reviewed by Jocelyn Turcotte.
Remove this patch's artificial dependency on Qt 5.1.
- platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):
- 5:33 AM Changeset in webkit [147543] by
-
- 3 edits in trunk/Tools
[Qt] Move logic of simple forwarding functions to TestRunner.
https://bugs.webkit.org/show_bug.cgi?id=113863
Reviewed by Simon Hausmann.
- DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::setTextDirection):
(TestRunner::goBack):
(TestRunner::evaluateScriptInIsolatedWorld):
(TestRunner::addUserStyleSheet):
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):
- 5:15 AM Changeset in webkit [147542] by
-
- 6 edits in trunk/Source/WebCore
Refine LOG messages in WebSocket related components
https://bugs.webkit.org/show_bug.cgi?id=113852
Patch by Takeshi Yoshino <tyoshino@chromium.org> on 2013-04-03
Reviewed by Kent Tamura.
Refine LOG messages by
- Make them contain method names to ease identifying where the event occurred.
- For consistency, make all messages print the pointer of the origin instance.
- Quote UTF8 data in LOG messages.
- For overloaded methods, add the type to clarify which one is run
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
(WebCore::WebSocket::send):
(WebCore::WebSocket::close):
(WebCore::WebSocket::contextDestroyed):
(WebCore::WebSocket::didConnect):
(WebCore::WebSocket::didReceiveMessage):
(WebCore::WebSocket::didReceiveBinaryData):
(WebCore::WebSocket::didReceiveMessageError):
(WebCore::WebSocket::didUpdateBufferedAmount):
(WebCore::WebSocket::didStartClosingHandshake):
(WebCore::WebSocket::didClose):
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::subprotocol):
(WebCore::WebSocketChannel::extensions):
(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::bufferedAmount):
(WebCore::WebSocketChannel::close):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::disconnect):
(WebCore::WebSocketChannel::willOpenSocketStream):
(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
(WebCore::WebSocketChannel::didFailSocketStream):
(WebCore::WebSocketChannel::didStartLoading):
(WebCore::WebSocketChannel::didReceiveData):
(WebCore::WebSocketChannel::didFinishLoading):
(WebCore::WebSocketChannel::didFail):
(WebCore::WebSocketChannel::appendToBuffer):
(WebCore::WebSocketChannel::processBuffer):
(WebCore::WebSocketChannel::startClosingHandshake):
(WebCore::WebSocketChannel::closingTimerFired):
- Modules/websockets/WebSocketDeflater.cpp:
(WebCore::WebSocketDeflater::~WebSocketDeflater):
(WebCore::WebSocketInflater::~WebSocketInflater):
- Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::readServerHandshake):
- platform/network/chromium/SocketStreamHandle.cpp:
(WebCore::SocketStreamHandleInternal::connect):
(WebCore::SocketStreamHandleInternal::send):
(WebCore::SocketStreamHandleInternal::close):
(WebCore::SocketStreamHandleInternal::didOpenStream):
(WebCore::SocketStreamHandleInternal::didSendData):
(WebCore::SocketStreamHandleInternal::didReceiveData):
(WebCore::SocketStreamHandleInternal::didClose):
(WebCore::SocketStreamHandleInternal::didFail):
- 4:56 AM Changeset in webkit [147541] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Update QMAKE_MAC_SDK check for Qt 5.1
Relies on QMAKE_MAC_SDK_VERSION set in features.prf
Reviewed by Simon Hausmann.
- WebCore.pri:
- 4:56 AM Changeset in webkit [147540] by
-
- 2 edits in trunk/Tools
[Qt] Disable media support using QuickTime if deployment target != SDK
We link to a single libWebKitSystemInterface static lib, so unless the
deployment target matches the SDK let's not pretend like we'll be able
to run on anything lower than the SDK version.
Reviewed by Simon Hausmann.
- qmake/mkspecs/features/features.prf:
- 4:15 AM Changeset in webkit [147539] by
-
- 2 edits in trunk/Source/WebCore
[Qt] assignToHTMLImageElement no longer exists in Qt5
https://bugs.webkit.org/show_bug.cgi?id=113639
Patch by Kristof Provost <kristof@codepro.be> on 2013-04-03
Reviewed by Simon Hausmann.
No new tests: covered by ./Source/WebKit/qt/tests/hybridPixmap/test.html
- bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapRuntime::getClassRef):
- 4:06 AM Changeset in webkit [147538] by
-
- 5 edits1 copy1 add in trunk
Web Inspector: crash in WebCore::InspectorLayerTreeAgent::buildObjectForLayer if a layer is created for an anonymous RenderObject (:first-letter)
https://bugs.webkit.org/show_bug.cgi?id=113768
Source/WebCore:
The InspectorLayerTreeAgent now knows how to deal with anonymous RenderObjects
for the :first-letter and :first-line pseudo-elements.
Reviewed by Timothy Hatcher.
Test: inspector-protocol/layers/layers-anonymous.html
- inspector/Inspector.json:
Change the Layer type in the LayerTree domain to have more accurate terminology
(pseudo-element vs. pseudo-class) and a new optional isAnonymous flag for layers
associated to anonymous RenderObjects.
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
Check for anonymous RenderObjects and set the parent renderer's node as the node
for this layer since anonymous renderers have the Document as their node and this
would not be satisfactory to show in a front-end. We also check for anonymous
RenderObjects for the :first-letter and :first-line pseudo-elements and set them
in the pseudoElement property of the Layer object created such that a front-end
could correctly identify what type of pseudo-element for the associated node
yielded this layer.
(WebCore::InspectorLayerTreeAgent::idForNode):
Here we fix the actual crash by first checking if the node provided is null and
returning 0 if there's no such node. This ensures that any scenario where there
is no node associated with the RenderObject simply informs of the front-end that
no such node exists and we do not crash.
LayoutTests:
Reviewed by Timothy Hatcher.
- inspector-protocol/layers/layers-anonymous-expected.txt: Added.
- inspector-protocol/layers/layers-anonymous.html: Added.
New test for layers created for CSS anonymous boxes or blocks.
- inspector-protocol/layers/layers-generated-content.html:
Update test to use the "pseudoElement" property instead of "pseudoClass"
which was the previous, less accurate name.
- 4:06 AM Changeset in webkit [147537] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Decouple layout viewport from visual viewport
https://bugs.webkit.org/show_bug.cgi?id=113829
Reviewed by Carlos Garcia Campos.
Setting the visual viewport would force the layout viewport equal to
the visual viewport. Decouple the viewports by allowing the user to
specify a layout viewport when setting the viewport(s). The layout
viewport could be the exact same value passed for visual viewport, if
the old behavior is desired.
Also reevaluate any viewport arguments when (only) the layout viewport
changes in WebPage::setDefaultLayoutSize() since the layout viewport is
used as input to the calculation.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setScreenOrientation):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPage::setViewportSize):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
(BlackBerry::WebKit::WebPage::defaultLayoutSize):
- Api/WebPage.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- 3:59 AM Changeset in webkit [147536] by
-
- 13 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebaselining after r147530.
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- 3:24 AM Changeset in webkit [147535] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [REGRESSION(r147117)][Elements] Copy/paste keyboard shortcuts broken in "Edit as HTML"
https://bugs.webkit.org/show_bug.cgi?id=113798
Reviewed by Yury Semikhatsky.
Stop propagation of "copy" event from the multiline editor's
CodeMirror host element so that it is not handled by
WebInspector.documentCopy().
- inspector/front-end/UIUtils.js:
(.consumeCopy):
(.cleanUpAfterEditing):
- inspector/front-end/inspector.js:
(WebInspector.addMainEventListeners):
- 2:49 AM Changeset in webkit [147534] by
-
- 4 edits in trunk/LayoutTests
[EFL] accessibility/ignore-spacer-elements.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112001
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-04-03
Reviewed by Gyuyoung Kim.
Fixed failing test. The reason of failure is different expectation of childrenCount.
- accessibility/ignore-spacer-elements.html:
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- 2:48 AM Changeset in webkit [147533] by
-
- 3 edits3 adds in trunk
With borders of differing alpha, the corners become squared off
https://bugs.webkit.org/show_bug.cgi?id=113744
Reviewed by Simon Fraser.
Source/WebCore:
paintTranslucentBorderSides should pick up borders with common color
in order: top, bottom, left and right (not top, right, bottom and
left), because willBeOverdrawn depends on the assumption, borders are
drawn in order: top, bottom, left and right.
Test: fast/borders/border-left-right-same-bottom-different-color.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):
LayoutTests:
- fast/borders/border-left-right-same-bottom-different-color-expected.txt: Added.
- fast/borders/border-left-right-same-bottom-different-color.html: Added.
- platform/chromium-linux/fast/borders/border-left-right-same-bottom-different-color-expected.png: Added.
- 2:45 AM Changeset in webkit [147532] by
-
- 2 edits4 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Updated platform specific expected files.
- platform/qt/TestExpectations: Skipped failing reftest.
- platform/qt/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Added after r147502.
- platform/qt/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Added after r147502.
- platform/qt/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Added after r147502.
- platform/qt/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Added after r147502.
- 2:31 AM Changeset in webkit [147531] by
-
- 2 edits in trunk/Source/WebCore
[New Multicolumn]Remove assert in RenderMultiColumnFlowThread::createAnonymous
https://bugs.webkit.org/show_bug.cgi?id=113855
Reviewed by Antti Koivisto.
Remove CSSRegions specific assert from new multicolumn implementation.
No change in functionality, no new tests.
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::createAnonymous):
- 2:28 AM Changeset in webkit [147530] by
-
- 22 edits in trunk
X-Frame-Options: Blocked frames should not inherit their parent's SecurityOrigin.
https://bugs.webkit.org/show_bug.cgi?id=112903
Reviewed by Adam Barth.
Source/WebCore:
This change brings WebKit in line with IE and Gecko's behavior, both of
which treat the blocked frame as being cross-origin for the purposes of
access checks ('[frame].contentWindow.location.href' is inaccessible,
for example).
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
Rather than redirecting to 'about:blank', redirect to a URL which
does not inherit the SecurityOrigin of the parent.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
Before calling cancelMainResourceLoad, ensure that the frame's
document is sandboxed into a unique origin so that it doesn't inherit
the parent's SecurityOrigin.
LayoutTests:
- http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html:
- http/tests/security/XFrameOptions/x-frame-options-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- 2:19 AM Changeset in webkit [147529] by
-
- 9 edits1 add in trunk/Source
[Chromium] Implement target-densityDpi viewport property emulation
https://bugs.webkit.org/show_bug.cgi?id=110835
The value is only used in the Chromium port, when the corresponding
setting is enabled.
This is needed for supporting existing WebView-based applications
that rely on this property.
Reviewed by Adam Barth.
Source/WebCore:
- dom/ViewportArguments.cpp:
(WebCore::findTargetDensityDPIValue):
(WebCore):
(WebCore::setViewportFeature):
- dom/ViewportArguments.h:
(WebCore::ViewportArguments::ViewportArguments):
(ViewportArguments):
(WebCore::ViewportArguments::operator==):
Source/WebKit/chromium:
- public/WebSettings.h:
(WebSettings):
- src/ChromeClientImpl.cpp:
(WebKit):
(WebKit::calculateTargetDensityDPIFactor):
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setSupportDeprecatedTargetDensityDPI):
(WebKit):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::supportDeprecatedTargetDensityDPI):
- tests/WebFrameTest.cpp:
- tests/data/viewport-target-densitydpi-high.html: Added.
- 1:56 AM Changeset in webkit [147528] by
-
- 14 edits in trunk/LayoutTests
Unreviewed, rolling out r147409.
http://trac.webkit.org/changeset/147409
https://bugs.webkit.org/show_bug.cgi?id=113856
The baselines should be reverted after r147450. (Requested by
kadam on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-03
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- platform/qt/TestExpectations:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- 1:38 AM Changeset in webkit [147527] by
-
- 82 edits3 moves in trunk/LayoutTests
Unreviewed. Rebaseline several tests for Chromium that have better output after
r147492.
- platform/chromium-linux/editing/selection/select-missing-image-expected.png:
- platform/chromium-linux/fast/block/float/002-expected.png:
- platform/chromium-linux/fast/block/float/017-expected.png:
- platform/chromium-linux/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/chromium-linux/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/chromium-linux/fast/encoding/utf-16-big-endian-expected.png:
- platform/chromium-linux/fast/encoding/utf-16-little-endian-expected.png:
- platform/chromium-linux/fast/flexbox/023-expected.png:
- platform/chromium-linux/fast/flexbox/024-expected.png:
- platform/chromium-linux/fast/forms/input-value-expected.png:
- platform/chromium-linux/fast/forms/input-value-expected.txt:
- platform/chromium-linux/fast/invalid/012-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.png:
- platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/chromium-mac-lion/editing/selection/select-missing-image-expected.png:
- platform/chromium-mac-lion/fast/block/float/002-expected.png:
- platform/chromium-mac-lion/fast/block/float/017-expected.png:
- platform/chromium-mac-lion/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/chromium-mac-lion/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/chromium-mac-lion/fast/encoding/utf-16-big-endian-expected.png:
- platform/chromium-mac-lion/fast/encoding/utf-16-little-endian-expected.png:
- platform/chromium-mac-lion/fast/flexbox/023-expected.png:
- platform/chromium-mac-lion/fast/flexbox/024-expected.png:
- platform/chromium-mac-lion/fast/forms/005-expected.png:
- platform/chromium-mac-lion/fast/forms/input-value-expected.png:
- platform/chromium-mac-lion/fast/invalid/012-expected.png:
- platform/chromium-mac-lion/fast/parser/comment-in-script-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug2997-expected.png:
- platform/chromium-mac-lion/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/chromium-mac-snowleopard/fast/block/float/002-expected.png:
- platform/chromium-mac-snowleopard/fast/block/float/017-expected.png:
- platform/chromium-mac-snowleopard/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/chromium-mac-snowleopard/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/chromium-mac-snowleopard/fast/encoding/utf-16-big-endian-expected.png:
- platform/chromium-mac-snowleopard/fast/encoding/utf-16-little-endian-expected.png:
- platform/chromium-mac-snowleopard/fast/flexbox/023-expected.png:
- platform/chromium-mac-snowleopard/fast/flexbox/024-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
- platform/chromium-mac-snowleopard/fast/invalid/012-expected.png:
- platform/chromium-mac-snowleopard/fast/parser/comment-in-script-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2997-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/chromium-mac/editing/selection/select-missing-image-expected.png:
- platform/chromium-mac/fast/block/float/002-expected.png:
- platform/chromium-mac/fast/block/float/017-expected.png:
- platform/chromium-mac/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/chromium-mac/fast/dom/HTMLImageElement/image-alt-text-expected.txt: Renamed from LayoutTests/platform/chromium/fast/dom/HTMLImageElement/image-alt-text-expected.txt.
- platform/chromium-mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/chromium-mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt: Renamed from LayoutTests/platform/chromium/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt.
- platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.png:
- platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.txt:
- platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.png:
- platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.txt:
- platform/chromium-mac/fast/flexbox/023-expected.png:
- platform/chromium-mac/fast/flexbox/024-expected.png:
- platform/chromium-mac/fast/forms/005-expected.png:
- platform/chromium-mac/fast/forms/input-value-expected.png:
- platform/chromium-mac/fast/forms/input-value-expected.txt:
- platform/chromium-mac/fast/invalid/012-expected.png:
- platform/chromium-mac/fast/parser/comment-in-script-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug2997-expected.png:
- platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.txt: Renamed from LayoutTests/platform/chromium/tables/mozilla/collapsing_borders/bug41262-3-expected.txt.
- platform/chromium-win/editing/selection/select-missing-image-expected.png:
- platform/chromium-win/fast/block/float/002-expected.png:
- platform/chromium-win/fast/block/float/017-expected.png:
- platform/chromium-win/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/chromium-win/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
- platform/chromium-win/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/chromium-win/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
- platform/chromium-win/fast/encoding/utf-16-big-endian-expected.png:
- platform/chromium-win/fast/encoding/utf-16-big-endian-expected.txt:
- platform/chromium-win/fast/encoding/utf-16-little-endian-expected.png:
- platform/chromium-win/fast/encoding/utf-16-little-endian-expected.txt:
- platform/chromium-win/fast/flexbox/023-expected.png:
- platform/chromium-win/fast/flexbox/024-expected.png:
- platform/chromium-win/fast/forms/input-value-expected.png:
- platform/chromium-win/fast/forms/input-value-expected.txt:
- platform/chromium-win/fast/invalid/012-expected.png:
- platform/chromium-win/fast/parser/comment-in-script-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug2997-expected.png:
- platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
- platform/chromium/TestExpectations:
- 1:31 AM Changeset in webkit [147526] by
-
- 4 edits in trunk/Source/WebCore
Extract URL that doesn't inherit a parent's SecurityOrigin out into a constant.
https://bugs.webkit.org/show_bug.cgi?id=113780
Reviewed by Jochen Eisinger.
We're scheduling navigations to 'data:text/html,' in XSSAuditor in
order to end up on a page that doesn't inherit its parent's
SecurityOrigin. We'll be reusing this mechainsm to solve
http://wkbug.com/112903
This patch makes us more explicit about what we're doing and why.
It doesn't change any behavior: XSSAuditor tests should still pass.
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript):
Use SecurityOrigin::urlWithUniqueSecurityOrigin rather than a
literal string to make our intentions clear.
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::urlWithUniqueSecurityOrigin):
- page/SecurityOrigin.h:
Add the new static method.
- 1:21 AM Changeset in webkit [147525] by
-
- 7 edits in trunk/Source
Remove code for Mac 10.5 and earlier from WTF and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=113844
Reviewed by Benjamin Poulain.
Removed the code for 10.5 and removed if-def for 10.6.
Source/WebKit2:
- Shared/mac/PasteboardTypes.mm:
(WebKit::PasteboardTypes::forEditing):
Source/WTF:
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- wtf/Platform.h:
- wtf/ThreadingPthreads.cpp:
(WTF::initializeCurrentThreadInternal):
- wtf/unicode/icu/CollatorICU.cpp:
(WTF::Collator::userDefault):
- 12:54 AM Changeset in webkit [147524] by
-
- 14 edits in trunk/LayoutTests
Unreviewed, rebaseline several tests cases for GTK that have better results
after r147492.
- platform/gtk/TestExpectations:
- platform/gtk/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/gtk/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
- platform/gtk/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/gtk/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
- platform/gtk/fast/encoding/utf-16-big-endian-expected.png:
- platform/gtk/fast/encoding/utf-16-big-endian-expected.txt:
- platform/gtk/fast/encoding/utf-16-little-endian-expected.png:
- platform/gtk/fast/encoding/utf-16-little-endian-expected.txt:
- platform/gtk/fast/forms/input-value-expected.png:
- platform/gtk/fast/forms/input-value-expected.txt:
- platform/gtk/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/gtk/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
Apr 2, 2013:
- 11:56 PM Changeset in webkit [147523] by
-
- 3 edits in trunk/Source/WebCore
clean up static casts in WebAccessibilityObjectWrapperMac.mm to methods like toAccessibilityList()
https://bugs.webkit.org/show_bug.cgi?id=113828
Reviewed by Tim Horton.
static_cast changed to toAccessibilityList().
- accessibility/AccessibilityList.h:
(WebCore::toAccessibilityList):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
- 11:52 PM Changeset in webkit [147522] by
-
- 6 edits in trunk/LayoutTests
Update expectations for fast/css3-text/css3-text-indent/text-indent-each-line.html
https://bugs.webkit.org/show_bug.cgi?id=113848
Mark as [ Failure ImageOnlyFailure ] for fast/css3-text/css3-text-indent/.
Unreviewed gardening.
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-02
- platform/mac/TestExpectations:
- platform/qt-mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 11:40 PM Changeset in webkit [147521] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r147370.
http://trac.webkit.org/changeset/147370
https://bugs.webkit.org/show_bug.cgi?id=113850
This patch is causing crashes in video tests on all Mac bots.
(Requested by jernoble_ on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-02
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement):
- 11:17 PM Changeset in webkit [147520] by
-
- 21 edits in trunk
AXRoleDescripton for DL is "list"; should be "description list"
https://bugs.webkit.org/show_bug.cgi?id=111665
Patch by James Craig <james@cookiecrook.com> on 2013-04-02
Reviewed by Chris Fleizach.
Source/WebCore:
Defining the role and description strings, and accessors for DL.
This previously relied on getting the role and description from the platform API.
Updated existing test coverage.
- English.lproj/Localizable.strings:
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):
- platform/LocalizedStrings.cpp:
(WebCore::AXDescriptionListText):
(WebCore):
- platform/LocalizedStrings.h:
(WebCore):
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::AXDescriptionListText):
(WebCore):
- platform/chromium/LocalizedStringsChromium.cpp:
(WebCore::AXDescriptionListText):
(WebCore):
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore::AXDescriptionListText):
(WebCore):
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::AXDescriptionListText):
(WebCore):
- platform/qt/LocalizedStringsQt.cpp:
(WebCore::AXDescriptionListText):
(WebCore):
Source/WebKit/chromium:
Defining the role and description strings.
- public/WebAccessibilityRole.h:
- src/AssertMatchingEnums.cpp:
Tools:
Defining the role and description strings.
- DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
LayoutTests:
Updating expectation strings for DL role description.
- platform/mac/accessibility/lists-expected.txt:
- platform/mac/accessibility/role-subrole-roledescription-expected.txt:
- platform/mac/accessibility/role-subrole-roledescription.html:
- 11:00 PM Changeset in webkit [147519] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Network] Split business logic and presentation for initiator column.
https://bugs.webkit.org/show_bug.cgi?id=113486
Reviewed by Pavel Feldman.
Currently business logic and presentation are mixed.
This prevents making cell renderer static and applying
viewport rendering, because initiator sorting function
depends on data written when cell is rendered.
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
Removed business logic. Use "initiatorInfo".
(WebInspector.NetworkDataGridNode.InitiatorComparator):
Use "initiatorInfo".
- inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.initiatorInfo):
Extracted business logic from "refreshInitiatorCell".
- 10:39 PM Changeset in webkit [147518] by
-
- 1 edit4 adds in trunk/LayoutTests
Unreviewed gardening; rebaseline mac expected results after r147470.
- platform/mac/css3/filters/effect-reference-composite-expected.png: Added.
- platform/mac/css3/filters/effect-reference-composite-expected.txt: Added.
- platform/mac/css3/filters/effect-reference-composite-hw-expected.png: Added.
- platform/mac/css3/filters/effect-reference-composite-hw-expected.txt: Added.
- 9:56 PM Changeset in webkit [147517] by
-
- 2 edits in trunk/Source/WebCore
needsLeopardMailQuirks should be removed
https://bugs.webkit.org/show_bug.cgi?id=113749
Reviewed by Benjamin Poulain.
Removed needsLeopardMailQuirks from settings.in after r147447.
- page/Settings.in:
- 8:46 PM Changeset in webkit [147516] by
-
- 2 edits1 add in trunk/LayoutTests
[EFL] Unskip and update inspector tests
https://bugs.webkit.org/show_bug.cgi?id=113840
Unreviewed gardening.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-02
- platform/efl/TestExpectations:
- platform/efl/http/tests/inspector/console-websocket-error-expected.txt: Added.
- 7:50 PM Changeset in webkit [147515] by
-
- 2 edits in trunk/LayoutTests
Unskip filter-fallback-to-software.html on Mac WK2 Release
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-02
- platform/mac-wk2/TestExpectations:
The test seems to pass in Release. Let's see how the bots feel about that.
- 6:41 PM Changeset in webkit [147514] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG should compile a little sooner
https://bugs.webkit.org/show_bug.cgi?id=113835
Unreviewed.
Rolled out r147511 because it was based on incorrect performance
measurement.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::optimizationThresholdScalingFactor):
- 6:32 PM Changeset in webkit [147513] by
-
- 6 edits2 adds in trunk
Source/WebCore: [css3-text] Rendering -webkit-each-line value for text-indent from css3-text
https://bugs.webkit.org/show_bug.cgi?id=113259
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-02
Reviewed by Levi Weintraub.
CSS3 TEXT introduces new value, "each-line" for text-indent.
Indentation affects the first line of the block container as well as each line
after a forced line break, but does not affect lines after a soft wrap break.
This patch is the rendering part to support each-line value for text-indent.
It's prefixed and guarded by CSS3_TEXT flag.
Test: fast/css3-text/css3-text-indent/text-indent-each-line.html
- rendering/RenderBlock.h:
(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::startOffsetForLine):
(WebCore::RenderBlock::endOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine):
Rename a parameter from firstLine to shouldIndentText.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::shouldIndentText): Return boolean according to m_shouldIndentText.
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
(WebCore::LineWidth::fitBelowFloats):
Add enum IndentTextOrNot and m_shouldIndentText.
Use m_shouldIndentText instead of m_isFirstLine.
(WebCore::requiresIndent): Decide whether text indentation is required.
(WebCore::updateLogicalInlinePositions):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
LayoutTests: [css3-text] Rendering -webkit-each-line value for text-indent from css3-text
https://bugs.webkit.org/show_bug.cgi?id=113259
CSS3 TEXT introduces new value, "each-line" for text-indent.
Indentation affects the first line of the block container as well as each line
after a forced line break, but does not affect lines after a soft wrap break.
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-02
Reviewed by Levi Weintraub.
- fast/css3-text/css3-text-indent/text-indent-each-line-expected.html: Added.
- fast/css3-text/css3-text-indent/text-indent-each-line.html: Added.
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 5:35 PM Changeset in webkit [147512] by
-
- 8 edits in branches/safari-536.29-branch/Source/WebKit2
Merged 147052 <rdar://problem/13528851>
- 5:34 PM Changeset in webkit [147511] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG should compile a little sooner
https://bugs.webkit.org/show_bug.cgi?id=113835
Reviewed by Michael Saboff.
2% speedup on SunSpider.
2% speedup on JSRegress.
Neutral on Octane, v8, and Kraken.
The worst-hit single sub-test is kraken-stanford-crypto-ccm.js, which gets
18% slower. Since Kraken is neutral overall in its preferred mean, I
think that's OK for now.
(Our array indexing speculation fails pathologically on
kraken-stanford-crypto-ccm.js. Compiling sooner is a regression because
it triggers those failures sooner. I'm going to file some follow-up bugs
explaining how to fix our speculations on this sub-test, at which point
compiling earlier should become a slight speedup on Kraken overall.)
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::optimizationThresholdScalingFactor): I experimented
with a few different options, including reducing the coefficient 'a'.
A simple linear reduction on instruction count worked best.
- 5:28 PM Changeset in webkit [147510] by
-
- 2 edits in trunk/LayoutTests
Compositing tests failing after http://trac.webkit.org/changeset/147502
https://bugs.webkit.org/show_bug.cgi?id=113838
Temporarily marking as failing.
- platform/mac/TestExpectations:
- 5:08 PM Changeset in webkit [147509] by
-
- 2 edits in trunk/Tools
Unreviewed. Disable running tests on Win EWS queue.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 4:34 PM Changeset in webkit [147508] by
-
- 3 edits in trunk/Source/WebKit2
Be more robust against empty message receiver names in incoming messages
https://bugs.webkit.org/show_bug.cgi?id=113833
<rdar://problem/13284433>
Reviewed by Beth Dakin.
Turns out that we either send or receive messages whose receiver names are empty. This leads to bad things when we try to look
up the message receiver name in a hash map since the empty name is used to represent an empty hash map value.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::addWorkQueueMessageReceiverOnConnectionWorkQueue):
Sprinkle assertions.
(CoreIPC::Connection::processIncomingMessage):
If the message receiver name is not valid, make sure to call didReceiveInvalidMessage on the client thread.
(CoreIPC::Connection::dispatchDidReceiveInvalidMessage):
Add new helper function.
- 4:31 PM Changeset in webkit [147507] by
-
- 2 edits1 add in trunk/PerformanceTests
Need japanese line layout performance test
https://bugs.webkit.org/show_bug.cgi?id=113811
Reviewed by Ryosuke Niwa.
Will be used by https://bugs.webkit.org/show_bug.cgi?id=105692 to test potential performance regression
for Japanese (and other CJK) line break changes.
- Layout/LineLayoutJapanese.html: Added.
- Skipped: Skip this test by default.
- 4:28 PM Changeset in webkit [147506] by
-
- 3 edits in trunk/Source/WebCore
Generalize prior line break context state and names.
https://bugs.webkit.org/show_bug.cgi?id=113823
Reviewed by Darin Adler.
No new tests required due to no behavioral change.
- platform/text/TextBreakIterator.h:
(WebCore::LazyLineBreakIterator::LazyLineBreakIterator):
(WebCore::LazyLineBreakIterator::lastCharacter):
(WebCore::LazyLineBreakIterator::secondToLastCharacter):
(WebCore::LazyLineBreakIterator::setPriorContext):
(WebCore::LazyLineBreakIterator::updatePriorContext):
(WebCore::LazyLineBreakIterator::resetPriorContext):
(WebCore::LazyLineBreakIterator::resetStringAndReleaseIterator):
Store previous characters as prior context buffer used directly
by line break iterator implementation. Rename members to reflect
somewhat more general usage. Also fix bad indentations.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
Use renamed line break iterator methods.
- 4:17 PM Changeset in webkit [147505] by
-
- 3 edits2 adds in trunk
Padding applied twice for empty generated RenderInlines
https://bugs.webkit.org/show_bug.cgi?id=113800
Source/WebCore:
Reviewed by Levi Weintraub.
The padding for empty generated content render objects is
incorrectly applied twice. Regression from r140693.
Test: fast/css-generated-content/margin-empty-content.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineLogicalWidth):
LayoutTests:
Reviewed by Levi Weintraub.
Add test for empty generated content with padding.
- fast/css-generated-content/margin-empty-content-expected.html: Added.
- fast/css-generated-content/margin-empty-content.html: Added.
- 4:10 PM Changeset in webkit [147504] by
-
- 4 edits2 adds in trunk
Source/WebCore: InlineIterator needs to be updated when RenderCombineText shrinks at a line break
https://bugs.webkit.org/show_bug.cgi?id=113733
Reviewed by Emil A Eklund.
Update stale InlineIterators that point beyond the end of a RenderCombineText that's
shrunk when RenderCombineText::combineText() is called.
Test: fast/text/international/combine-at-line-break-crash.html
- rendering/BidiRun.h:
(WebCore::BidiRun::BidiRun): Adding an assertion that runs are created within
the bounds of their associated RenderText.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::iteratorIsBeyondEndOfRenderCombineText): Added.
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak): Update stale iterators.
LayoutTests: InlineIterator needs to be updated when RenderCombineText shrinks at a line break
https://bugs.webkit.org/show_bug.cgi?id=113732
Reviewed by Emil A Eklund.
- fast/text/international/combine-at-line-break-crash-expected.txt: Added.
- fast/text/international/combine-at-line-break-crash.html: Added.
- 3:51 PM Changeset in webkit [147503] by
-
- 3 edits in trunk/LayoutTests
Use cross-port testRunner methods in fast/loader/url-selected-user-gesture.html
https://bugs.webkit.org/show_bug.cgi?id=113827
Reviewed by Benjamin Poulain.
- fast/loader/url-selected-user-gesture-expected.txt:
- fast/loader/url-selected-user-gesture.html:
- 3:31 PM Changeset in webkit [147502] by
-
- 18 edits6 copies12 adds2 deletes in trunk
[CSS Filters] Filter outsets clipped on composited layers when filter is applied after first layout
https://bugs.webkit.org/show_bug.cgi?id=109098
Reviewed by Dean Jackson.
Source/WebCore:
This patch addresses the following issues:
(1) Compositors who can compute their own filter outsets don't need WebKit to inflate the
composited layer bounds. Eventually, all platforms' compositors should be able to
compute their own filter outsets.
(2) When filter outsets change, we need to update composited layer bounds if the filters are
painted in software.
(3) When filter outsets change, we need to recompute the overlap map to promote the correct
layers to composited layers on all platforms.
Tests: css3/filters/composited-layer-bounds-after-sw-blur-animation.html
css3/filters/composited-layer-bounds-with-composited-blur.html
css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change.html
css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow.html
css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow.html
- platform/graphics/IntRectExtent.h:
(WebCore::IntRectExtent::isZero):
(IntRectExtent):
Make isZero public on IntRectExtent.
- rendering/RenderLayer.cpp:
(WebCore::hasOrHadFilters):
Helper function used to exit early from filters related code.
(WebCore::RenderLayer::updateFilters):
Move filter updating code from RenderLayer::styleChanged into this new method.
This method calls RenderLayerBacking::updateFilters instead of
RenderLayerBacking::updateGraphicsLayerGeometry. RenderLayerBacking::updateFilters lets
us know whether there was a filter paint mode change (i.e. the filters were painted in
software and are now painted in the compositor, or vice-versa). We need to know this
earlier, in RenderLayer::styleChanged, because we may need to rebuild the compositing
layers due to a filter paint mode change.
(WebCore::RenderLayer::styleChanged):
Add a condition for filters for setCompositingLayersNeedRebuild. If the filter outsets
on a layer changed, we need to rebuild the compositing layers because there could be new
overlap. Likewise, if there are or were filter outsets and the filter paint mode changed
the layer bounds (and child positions) may have changed. In either case, we don't
rebuild the compositing layers if there is an accelerated filter animation running.
Remove old code to detect a filter paint mode change from the end of
RenderLayer::styleChanged because it could never be executed. The old code counted on
RenderLayerBacking::canCompositeFilters to change on its own, but it doesn't change
unless updateFilters gets called. Thus, we could never enter the if statement that
calls setBackingNeedsRepaint.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateFilters):
Now return true if there was a filter paint mode change, so RenderLayer::styleChanged
can decide if it should rebuild the compositing layers.
Call updateOrRemoveFilterEffectRenderer and setContentsNeedDisplay if there was a
render mode change. We need to either destroy or create the software renderer and we
need to repaint the layer contents if there was a render mode change.
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
Don't call updateFilters here. Call it earlier in RenderLayer::styleChanged, for reasons
explained above.
- rendering/RenderLayerBacking.h:
(RenderLayerBacking):
Make updateFilters public so RenderLayer::styleChanged can call it.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):
If the platform's compositor computes filter outsets for its layers internally, do not
inflate WebKit's composited bounds for filter outsets. This results in smaller layers
on Safari. Note that we still need to include filter outsets in layer bounds for other
situations like overlap testing in WebKit and when we're painting filters in software.
Source/WTF:
- wtf/Platform.h:
Add flag for HAVE(COMPOSITOR_FILTER_OUTSETS) macro. This is used to check if a
platform's compositor expands layers internally for filter outsets when it applies
filters like drop-shadow and blur. Currently, only CoreAnimation does has this
capability.
LayoutTests:
- compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
- compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
- compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
The above tests needed rebaselining because we're now using smaller layers on Safari.
We aren't inflating layers for filter outsets since CoreAnimation does it for us
already.
- css3/filters/composited-layer-bounds-after-sw-blur-animation-expected.txt: Added.
- css3/filters/composited-layer-bounds-after-sw-blur-animation.html: Added.
- css3/filters/composited-layer-bounds-with-composited-blur-expected.txt: Added.
- css3/filters/composited-layer-bounds-with-composited-blur.html: Added.
- css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change-expected.txt: Added.
- css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change.html: Added.
- css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow-expected.txt: Added.
- css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow.html: Added.
- css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow-expected.txt: Added.
- css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow.html: Added.
The above tests are all new. They mostly test edge cases with filter render mode
changes, filter outset changes, and composited layer promotion due to overlap.
Before this patch, composited-layer-bounds-after-sw-blur-animation.html breaks
visibly on Safari WebKit nightly. The blur filter in the test appears clipped before
this patch. The other tests render the same before and after this patch, but now their
layer sizes are smaller.
- css3/filters/filter-change-repaint-composited-expected.png:
- css3/filters/filter-change-repaint-composited.html:
This test has been expanded with two more cases, including the original reproduction of
this bug. The test needs rebaselining on Chromium Linux and Win.
- platform/chromium-win/css3/filters/filter-change-repaint-composited-expected.png: Removed.
- platform/chromium/TestExpectations:
- platform/chromium/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Added.
- platform/chromium/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Added.
- platform/chromium/css3/filters/composited-layer-bounds-after-sw-blur-animation-expected.txt: Added.
- platform/chromium/css3/filters/composited-layer-bounds-with-composited-blur-expected.txt: Added.
- platform/chromium/css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change-expected.txt: Added.
- platform/chromium/css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow-expected.txt: Added.
- platform/chromium/css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow-expected.txt: Added.
We need different expectations for Chromium for the new tests because layer bounds
include filter outsets on Chromium but not on Safari.
- platform/chromium/css3/filters/filter-change-repaint-composited-expected.png: Added.
- platform/qt/TestExpectations:
Note that we need baselines on Qt for the new and updated tests.
- 2:52 PM Changeset in webkit [147501] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Unreviewed, rolling out r147423.
The change r147402 was reverted by r147450.
The rebaseline introduced by r147423 needs to be reverted.
- platform/mac-wk2/http/tests/security/XFrameOptions: Removed.
- platform/mac-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
- platform/mac/http/tests/security/XFrameOptions: Removed.
- platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
- platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
- platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
- 2:49 PM Changeset in webkit [147500] by
-
- 2 edits in trunk/Source/WebKit2
[Mac][WK2] Donât let plug-ins use System V shared memory
https://bugs.webkit.org/show_bug.cgi?id=113466
<rdar://problem/13159030>
Reviewed, tweaked and landed by Alexey Proskuryakov.
Instead of allowing plug-ins to request System V shm, give them a
temporary but usable alternative if they try to request it.
- PluginProcess/mac/PluginProcessShim.mm:
- 2:31 PM WebKitGTK/2.0.x edited by
- (diff)
- 2:24 PM Changeset in webkit [147499] by
-
- 9 edits in trunk
[GTK] Make libsecret optional
https://bugs.webkit.org/show_bug.cgi?id=113821
Reviewed by Gustavo Noronha Silva.
.:
Add a configuration option to disable credential storage and thus remove
the libsecret dependency. This should make it possible to build WebKit 2.x
on Windows again.
- Source/autotools/FindDependencies.m4: Only look for libsecret if credential storage is active.
- Source/autotools/PrintBuildConfiguration.m4: Print whether or not credential storage is active.
- Source/autotools/ReadCommandLineArguments.m4: Added an option to control credential storage.
- Source/autotools/SetupAutoconfHeader.m4: Expose credential storage setting to code.
Source/WebCore:
Don't try to use libsecret if credential storage is disabled.
- platform/gtk/GRefPtrGtk.cpp: Protect libsecret sections.
- platform/gtk/GRefPtrGtk.h: Ditto.
- platform/network/gtk/CredentialBackingStore.cpp: Ditto.
- 2:23 PM Changeset in webkit [147498] by
-
- 2 edits8 adds4 deletes in trunk/LayoutTests
Unreviewed, chromium gardening.
- platform/chromium-linux/css3/filters/effect-reference-composite-expected.png: Removed.
- platform/chromium-linux/css3/filters/effect-reference-composite-expected.txt: Removed.
- platform/chromium-linux/css3/filters/effect-reference-composite-hw-expected.png: Removed.
- platform/chromium-linux/css3/filters/effect-reference-composite-hw-expected.txt: Removed.
- platform/chromium-mac/css3/filters/effect-reference-composite-expected.png: Added.
- platform/chromium-mac/css3/filters/effect-reference-composite-expected.txt: Added.
- platform/chromium-mac/css3/filters/effect-reference-composite-hw-expected.png: Added.
- platform/chromium-mac/css3/filters/effect-reference-composite-hw-expected.txt: Added.
- platform/chromium-win/css3/filters/effect-reference-composite-expected.png: Added.
- platform/chromium-win/css3/filters/effect-reference-composite-expected.txt: Added.
- platform/chromium-win/css3/filters/effect-reference-composite-hw-expected.png: Added.
- platform/chromium-win/css3/filters/effect-reference-composite-hw-expected.txt: Added.
- platform/chromium/TestExpectations:
- 2:21 PM Changeset in webkit [147497] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] API update for IntRect
https://bugs.webkit.org/show_bug.cgi?id=113824
Patch by Maxim Mogilnitsky <mmogilnitsky@rim.com> on 2013-04-02
Reviewed by Rob Buis.
Modifing IntRect and FloatRect API.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::regionForTextQuads):
- 2:19 PM Changeset in webkit [147496] by
-
- 1 edit2 deletes in trunk/LayoutTests
Unreviewed, rolling out r147423.
http://trac.webkit.org/changeset/147423
https://bugs.webkit.org/show_bug.cgi?id=113775
The change r147402 was reverted by r147450.
The rebaseline introduced by r147423 needs to be reverted.
- platform/mac-wk2/http/tests/security/XFrameOptions: Removed.
- platform/mac-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
- platform/mac/http/tests/security/XFrameOptions: Removed.
- platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
- platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
- platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
- 2:18 PM Changeset in webkit [147495] by
-
- 5 edits in trunk/Source/WebCore
[CSS Exclusions] refactor shape-outside code to use isFloatingWithShapeOutside() helper method
https://bugs.webkit.org/show_bug.cgi?id=113799
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-04-02
Reviewed by Dirk Schulze.
When reviewing my patch for bug 110349, Julien mentioned that the
common test for floating with shape outside should be factored out.
This patch does that.
No new functionality, so no new tests.
- rendering/ExclusionShapeOutsideInfo.cpp:
(WebCore::ExclusionShapeOutsideInfo::isEnabledFor): Use helper method.
- rendering/RenderBox.h:
(WebCore::RenderBox::exclusionShapeOutsideInfo): Ditto.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeNormalFlowOnly): Ditto.
- rendering/RenderObject.h:
(WebCore::RenderObject::hasPaintOffset): Ditto.
(WebCore::RenderObject::isFloatingWithShapeOutside): Add method to
encapsulate the common test.
- 1:49 PM Changeset in webkit [147494] by
-
- 3 edits4 adds in trunk/Source/WebCore
Add platform AudioSession and iOS platform-specific code.
https://bugs.webkit.org/show_bug.cgi?id=113813
<rdar://problem/11701792>
Reviewed by Eric Carlson.
Replace the deprecated AudioToolbox AudioSession APIs with the new AVAudioSession API.
To protect against exposing platform specific intrinsics to cross-platform code, add a
platform generic class AudioSession, with port-specific implementations. A default
implementation is provided.
Add a new listener interface to receive interruption notifications:
- platform/audio/AudioSessionListener.h: Added.
(WebCore::AudioSessionListener::AudioSessionListener):
(WebCore::AudioSessionListener::~AudioSessionListener):
Add a platform generic AudioSession class:
- platform/audio/AudioSession.cpp: Added.
(AudioSession::sharedSession): AudioSession is a singleton object, and this is its accessor.
(AudioSession::addListener): Add the parameter to the listeners set.
(AudioSession::removeListener): Remove the parameter from the listers set.
(AudioSession::beganAudioInterruption): Iterate over the parameters.
(AudioSession::endedAudioInterruption): Ditto.
(AudioSession::AudioSession): Empty stub.
(AudioSession::~AudioSession): Ditto.
(AudioSession::setCategory): Ditto.
(AudioSession::category): Ditto.
(AudioSession::sampleRate): Ditto.
(AudioSession::numberOfOutputChannels): Ditto.
(AudioSession::setActive): Ditto.
(AudioSession::preferredBufferDuration): Ditto.
(AudioSession::setPreferredBufferDuration): Ditto.
- platform/audio/AudioSession.h: Added.
Add IOS-specific AudioSession implementation:
- platform/audio/ios/AudioSessionIOS.mm: Added.
(-[WebAudioSessionHelper initWithCallback:WebCore::]): Register for interruption notifications.
(-[WebAudioSessionHelper dealloc]): Unregister for interruption notifications.
(-[WebAudioSessionHelper interruption:]): Pass to AudioSession.
(WebCore::AudioSessionPrivate::AudioSessionPrivate): Private storage for AudioSessionIOS.
(WebCore::AudioSession::AudioSession): Create AudioSessionPrivate and WebAudioSessionHelper.
(WebCore::AudioSession::~AudioSession): Simple destructor.
(WebCore::AudioSession::setCategory): Check the current categoryOverride, and refuse to overwrite
"MediaPlayback" with "AmbientSound".
(WebCore::AudioSession::setCategoryOverride): Simple setter.
(WebCore::AudioSession::categoryOverride): Simple getter.
(WebCore::AudioSession::category): Pass to AVAudioSession.
(WebCore::AudioSession::sampleRate): Ditto.
(WebCore::AudioSession::numberOfOutputChannels): Ditto.
(WebCore::AudioSession::setActive): Ditto.
(WebCore::AudioSession::preferredBufferDuration): Ditto.
(WebCore::AudioSession::setPreferredBufferDuration): Ditto.
Use the new AudioSession class in place of explicit AudioToolbox or AVAudioSession calls:
- platform/audio/ios/AudioDestinationIOS.cpp:
(WebCore::AudioDestination::hardwareSampleRate): Pass to AudioSession.
(WebCore::AudioDestination::maxChannelCount): Ditto.
(WebCore::AudioDestinationIOS::AudioDestinationIOS): Register for listeners and activate.
(WebCore::AudioDestinationIOS::~AudioDestinationIOS): Unregister and deactivate.
(WebCore::AudioDestinationIOS::configure): Use AudioSession to set the buffer length.
- platform/audio/ios/AudioDestinationIOS.h:
Add the new files to the project:
- WebCore.xcodeproj/project.pbxproj:
- 1:47 PM Changeset in webkit [147493] by
-
- 2 edits3 adds in trunk/Source/WebCore
Upstream AudioDestinationIOS.
https://bugs.webkit.org/show_bug.cgi?id=113806
Reviewed by Eric Carlson.
Upstream AudioDestinationIOS from the iOS repository.
- WebCore.xcodeproj/project.pbxproj:
- platform/audio/ios/AudioDestinationIOS.cpp: Added.
(WebCore::audioDestinations):
(WebCore::AudioDestination::create):
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestination::maxChannelCount):
(WebCore::AudioDestinationIOS::AudioDestinationIOS):
(WebCore::AudioDestinationIOS::~AudioDestinationIOS):
(WebCore::AudioDestinationIOS::configure):
(WebCore::AudioDestinationIOS::audioDestinationInterruptionListener):
(WebCore::AudioDestinationIOS::initializeAudioSession):
(WebCore::AudioDestinationIOS::start):
(WebCore::AudioDestinationIOS::stop):
(WebCore::AudioDestinationIOS::beganAudioInterruption):
(WebCore::AudioDestinationIOS::endedAudioInterruption):
(WebCore::AudioDestinationIOS::render):
(WebCore::AudioDestinationIOS::inputProc):
(WebCore::AudioDestinationIOS::frameSizeChangedProc):
- platform/audio/ios/AudioDestinationIOS.h: Added.
(AudioDestinationIOS):
(WebCore::AudioDestinationIOS::isPlaying):
(WebCore::AudioDestinationIOS::sampleRate):
- 1:35 PM Changeset in webkit [147492] by
-
- 30 edits in trunk
fast/dom/HTMLImageElement/image-alt-text.html and fast/dom/HTMLInputElement/input-image-alt-text.html are failing
https://bugs.webkit.org/show_bug.cgi?id=94198
Reviewed by Darin Adler.
Source/WebCore:
Fix alt text not being displayed for img elements or input of type
"image" due to insufficient size. imageSizeForError() was adding
padding for the alt text but setImageSizeForAltText() was not. The
issue was occurring in paintReplaced() because the contentWidth() /
contentHeight() would be exactly the same size as the alt text.
However, paintReplaced() first draws an outline rect where the
image should be and then reduces the usable width / height for the
alt text by 2 so that the text does not get printed over the rect
borders. However, after decreasing the usable width / height, there
is no longer enough space to draw the text.
No new tests, already covered by existing tests.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::setImageSizeForAltText): Add padding to the text size
so that the alt text can still be drawn, despite the outline rect
borders. Such padding was already used in imageSizeForError(). Also use
ceilf() for the value returned by Font::width() instead of truncating it.
This is needed because we need to fit the whole text in the image and this
may not be the case if we truncate.
(WebCore::RenderImage::paintReplaced):
LayoutTests:
Rebaseline several test cases that have better result now and add those
tests to TestExpectations for other ports since they will need a
rebaseline.
- platform/chromium/TestExpectations:
- platform/efl/fast/block/float/002-expected.png:
- platform/efl/fast/block/float/017-expected.png:
- platform/efl/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/efl/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
- platform/efl/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/efl/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
- platform/efl/fast/encoding/utf-16-big-endian-expected.png:
- platform/efl/fast/encoding/utf-16-big-endian-expected.txt:
- platform/efl/fast/encoding/utf-16-little-endian-expected.png:
- platform/efl/fast/encoding/utf-16-little-endian-expected.txt:
- platform/efl/fast/flexbox/023-expected.png:
- platform/efl/fast/flexbox/024-expected.png:
- platform/efl/fast/forms/input-value-expected.png:
- platform/efl/fast/forms/input-value-expected.txt:
- platform/efl/fast/invalid/012-expected.png:
- platform/efl/fast/lists/inlineBoxWrapperNullCheck-expected.png:
- platform/efl/fast/lists/inlineBoxWrapperNullCheck-expected.txt:
- platform/efl/fast/parser/comment-in-script-expected.png:
- platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
- platform/efl/tables/mozilla/bugs/bug2997-expected.png:
- platform/efl/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/efl/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- 1:24 PM Changeset in webkit [147491] by
-
- 8 edits1 add in trunk/Source
Add support for using ARM FFT in WebAudio
https://bugs.webkit.org/show_bug.cgi?id=109755
Reviewed by Chris Rogers.
Source/WebCore:
No new tests.
- WebCore.gyp/WebCore.gyp: Add dependency on openmax_dl when use_openmax_dl_fft is enabled.
- WebCore.gypi: Add source FFTFrameOpenMAXDLAndroid.cpp
- platform/audio/AudioArray.h:
(WebCore::AudioArray::allocate): Need 32-byte aligntment with the
OpenMAX DL FFT.
- platform/audio/FFTFrame.h:
(FFTFrame): Support OpenMAX DL FFT
- platform/audio/FFTFrameStub.cpp: Support OpenMAX DL FFT
- platform/audio/chromium/FFTFrameOpenMAXDLAndroid.cpp: Added. Implements the
necessary interface using the OpenMAX DL FFT routines.
(WebCore):
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::initialize):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::multiply):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):
(WebCore::FFTFrame::contextForSize):
Source/WebKit/chromium:
- features.gypi: Support building with the OpenMAX DL FFT.
- 1:04 PM Changeset in webkit [147490] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Memory leaks in MediaPlayerPrivateGStreamer
https://bugs.webkit.org/show_bug.cgi?id=113762
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-04-02
Reviewed by Philippe Normand.
Don't leak strings returned by gst_element_get_name() and
gst_missing_plugin_message_get_installer_detail().
No new tests. No change in behavior.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
- 1:00 PM Changeset in webkit [147489] by
-
- 6 edits in trunk/Source/WebKit2
Add WKContextSetInvalidMessageFunction
https://bugs.webkit.org/show_bug.cgi?id=113820
<rdar://problem/12679817>
Reviewed by Tim Horton.
- UIProcess/API/C/WKContext.cpp:
(WKContextSetInvalidMessageFunction):
Call WebContext::didReceiveInvalidMessage.
- UIProcess/API/C/WKContextPrivate.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::setInvalidMessageCallback):
Set the global variable.
(WebKit::WebContext::didReceiveInvalidMessage):
Construct a message name string and call the invalid message callback.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveInvalidMessage):
Call WebContext::didReceiveInvalidMessage.
- 12:57 PM Changeset in webkit [147488] by
-
- 1 edit3 deletes in trunk/LayoutTests
Rebaseline overflowHidden.html's test results after r147245.
Unreviewed.
The patch r147245 (https://bugs.webkit.org/show_bug.cgi?id=106143) updated results for
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-02
Reviewed by Tony Chang.
Chromium, but not for the other platforms.
The new results on Mac, EFL and Win match the common reference.
- platform/efl/fast/table/overflowHidden-expected.txt: Removed.
- platform/mac/fast/table/overflowHidden-expected.txt: Removed.
- platform/win-7sp0/fast/table: Removed.
- platform/win-7sp0/fast/table/overflowHidden-expected.txt: Removed.
- 12:54 PM Changeset in webkit [147487] by
-
- 3 edits1 add in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should have the equivalent of a ValueRecovery
https://bugs.webkit.org/show_bug.cgi?id=113819
Reviewed by Mark Hahnenberg.
This adds a way of saying that we have a value, we don't want to say what
node the value came from, but we know specifics of how the value is
formatted. This is the LLVM equivalent of DFG's ValueRecovery.
- JavaScriptCore.xcodeproj/project.pbxproj:
- ftl/FTLFormattedValue.h: Added.
(FTL):
(FormattedValue):
(JSC::FTL::FormattedValue::FormattedValue):
(JSC::FTL::FormattedValue::operator!):
(JSC::FTL::FormattedValue::format):
(JSC::FTL::FormattedValue::value):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileUInt32ToNumber):
(JSC::FTL::LowerDFGToLLVM::speculateForward):
(JSC::FTL::LowerDFGToLLVM::weakPointer):
- 12:53 PM Changeset in webkit [147486] by
-
- 2 edits in trunk/Source/WebCore
Fix css style for CC button on android
https://bugs.webkit.org/show_bug.cgi?id=113815
Patch by Min Qin <qinmin@chromium.org> on 2013-04-02
Reviewed by Adam Barth.
The default CC button size is 16px as defined in mediaControls.css. Android should use 35px.
This change fixed that problem.
Also fixed a problem that r142947 does not change the display of fullscreen button to -webkit-flex
Android does not run media layout tests currently. Will fix the test expectations when layout tests are run in content shell.
- css/mediaControlsChromiumAndroid.css:
(video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
- 12:52 PM Changeset in webkit [147485] by
-
- 8 edits in trunk/Source
[Mac] Remove WKCreateNSURLConnectionDelegateProxy
https://bugs.webkit.org/show_bug.cgi?id=113810
Reviewed by Anders Carlsson.
This WKSI function is not used any more.
- WebCore.exp.in:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- 12:50 PM Changeset in webkit [147484] by
-
- 3 edits in trunk/LayoutTests
[CSS Regions] Remove font-smoothing from fast/regions/region-style-inline-background-color.html
https://bugs.webkit.org/show_bug.cgi?id=113814
Reviewed by James Robinson.
The test uses font smoothing and makes the test fail on Chromium Mountain Lion. This happens
because of how regions handle overflow and clipping. For now, disable the font smoothing in
the test.
- fast/regions/region-style-inline-background-color-expected.html:
- fast/regions/region-style-inline-background-color.html:
- 12:13 PM Changeset in webkit [147483] by
-
- 2 edits in trunk/Tools
Disable running tests on the MAC WK2 EWS queue.
Unreviewed.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(MacWK2EWS):
- 12:06 PM Changeset in webkit [147482] by
-
- 7 edits in trunk/Source/WebKit
Provide a user default that can be used to disable docking of the Web Inspector.
The user default is "WebKit Web Inspector Setting - inspectorAttachDisabled".
https://webkit.org/b/113779
rdar://problem/13446021
Reviewed by Joseph Pecoraro.
Source/WebKit/cf:
- WebCoreSupport/WebInspectorClientCF.cpp:
(WebInspectorClient::inspectorAttachDisabled): Added.
(WebInspectorClient::setInspectorAttachDisabled): Added.
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient::inspectorAttachDisabled): Added.
(WebInspectorClient::setInspectorAttachDisabled): Added.
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::didResizeMainFrame):
(-[WebInspectorWindowController window]):
(-[WebInspectorWindowController showWindow:]):
Check inspectorAttachDisabled() in places where we attach or update the dock button.
Source/WebKit/win:
- WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient::inspectorAttachDisabled): Added.
(WebInspectorClient::setInspectorAttachDisabled): Added.
- 11:56 AM Changeset in webkit [147481] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should use the right abstract heap for Int32 array accesses
https://bugs.webkit.org/show_bug.cgi?id=113759
Reviewed by Mark Hahnenberg.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
- 11:54 AM Changeset in webkit [147480] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r147464.
http://trac.webkit.org/changeset/147464
https://bugs.webkit.org/show_bug.cgi?id=113812
JSSQLResultSet.cpp:131:24: error: implicit conversion loses
integer precision: 'int64_t' (aka 'long long') to 'int'
[-Werror,-Wshorten-64-to-32] (Requested by xenon on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-02
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjAttrWithGetterException):
(WebCore::jsTestObjStringAttrWithGetterException):
(WebCore::jsTestObjWithScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::jsTestObjNullableDoubleAttribute):
(WebCore::jsTestObjNullableLongAttribute):
(WebCore::jsTestObjNullableBooleanAttribute):
(WebCore::jsTestObjNullableStringAttribute):
(WebCore::jsTestObjNullableLongSettableAttribute):
(WebCore::jsTestObjNullableStringValue):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::jsTestTypedefsAttrWithGetterException):
(WebCore::jsTestTypedefsStringAttrWithGetterException):
- 11:42 AM Changeset in webkit [147479] by
-
- 7 edits in trunk/LayoutTests
Rebaseline svg/as-image/image-respects-pageScaleFactor expectations
Unreviewed rebaseline of test expectations.
- platform/chromium-linux/svg/as-image/image-respects-pageScaleFactor-expected.png:
- platform/chromium-mac-lion/svg/as-image/image-respects-pageScaleFactor-expected.png:
- platform/chromium-mac-snowleopard/svg/as-image/image-respects-pageScaleFactor-expected.png:
- platform/chromium-mac/svg/as-image/image-respects-pageScaleFactor-expected.png:
- platform/chromium-win/svg/as-image/image-respects-pageScaleFactor-expected.png:
- platform/chromium-win/svg/as-image/image-respects-pageScaleFactor-expected.txt:
- 11:37 AM Changeset in webkit [147478] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: Make Source Frame & status bar a layout boundary
https://bugs.webkit.org/show_bug.cgi?id=112353
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
No new tests: no change in behaviour.
- Add View.markAsLayoutBoundary method to mark a view as a layout
boundary. This will force this view to autoupdate its height to actual
pixel value.
- Mark both CodeMirrorTextEditor and DefaultTextEditor as a layout
boundary.
- Mark main-status-bar element with a layout-boundary class.
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
- inspector/front-end/DefaultTextEditor.js:
- inspector/front-end/View.js:
(WebInspector.View.prototype.markAsLayoutBoundary):
(WebInspector.View.prototype._processWillShow):
(WebInspector.View.prototype._processWasShown):
(WebInspector.View.prototype._processOnResize):
- inspector/front-end/inspector.css:
(.layout-boundary):
- inspector/front-end/inspector.html:
- 11:36 AM Changeset in webkit [147477] by
-
- 3 edits in trunk/Source/Platform
[chromium] Initialize all fields in WebFilterOperation
https://bugs.webkit.org/show_bug.cgi?id=113807
Reviewed by James Robinson.
- chromium/public/WebFilterOperation.h:
(WebKit::WebFilterOperation::WebFilterOperation):
- chromium/src/WebFilterOperation.cpp:
(WebKit::WebFilterOperation::WebFilterOperation):
- 11:36 AM Changeset in webkit [147476] by
-
- 9 edits in trunk/Source
<rdar://problem/13551119> [WK2] Crashes in NetworkProcess when canceling loads
https://bugs.webkit.org/show_bug.cgi?id=113803
Reviewed by Darin Adler.
Stop using a delegate proxy. It hasn't been needed in years, and the extra layer
just adds bugs.
This specific issue gets fixed because connection retains its delegate is retained,
but a proxy does not.
- WebCore.exp.in:
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::releaseDelegate): (WebCore::ResourceHandle::platformLoadResourceSynchronously): Removed code that was dealing with delegate proxy.
- 11:35 AM Changeset in webkit [147475] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Encapsulate SetEmbedderData/GetEmbedderData
https://bugs.webkit.org/show_bug.cgi?id=113331
Patch by John J. Barton <johnjbarton@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
Refactor to encapsulate uses of V8 Set/GetEmbedderData together
with uses of V8 Set/GetAlignedPointerInEmbedderData since these
functions operate on the same underyling array in V8.
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::setContextDebugId):
(WebCore::ScriptController::contextDebugId):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::setInjectedScriptContextDebugId):
- bindings/v8/V8PerContextData.cpp:
(WebCore::V8PerContextDebugData::setContextDebugData):
(WebCore):
(WebCore::V8PerContextDebugData::contextDebugId):
(WebCore::V8PerContextDebugData::createDebugData):
(WebCore::V8PerContextDebugData::getDebugData):
(WebCore::V8PerContextDebugData::setDebugData):
- bindings/v8/V8PerContextData.h:
(V8PerContextDebugData):
(WebCore):
- 11:32 AM Changeset in webkit [147474] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Adjust toolbar labels position
https://bugs.webkit.org/show_bug.cgi?id=113805
Patch by Alexei Filippov <alph@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
Move the labels 1px up to make them centered.
Also fix font centering in native memory distribution snapshot.
- inspector/front-end/inspector.css:
(.toolbar-label):
- inspector/front-end/nativeMemoryProfiler.css:
(.native-snapshot-view .data-grid td):
- 11:30 AM Changeset in webkit [147473] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, chromium expectations update.
- platform/chromium/TestExpectations:
- 11:27 AM Changeset in webkit [147472] by
-
- 1 edit in trunk/Source/WebCore/rendering/RenderLayer.cpp
Fix Windows build.
- 11:25 AM Changeset in webkit [147471] by
-
- 13 edits2 adds in trunk
Viewport constrained elements should work properly with headers and footers
https://bugs.webkit.org/show_bug.cgi?id=113743
Reviewed by Simon Fraser.
Source/WebCore:
ScrollableArea::constrainScrollPositionForOverhang() needs to take headerHeight
and footerHeight into account. It also needs to use totalContentsSize() instead of
contentsSize().
Send totalContentsSize() instead of contentsSize() and also send headerHeight()
and footerHeight().
- page/FrameView.cpp:
(WebCore::FrameView::scrollOffsetForFixedPosition):
- page/FrameView.h:
(FrameView):
The scrolling tree will also need to know about header and footer heights since it
will need these values to call
ScrollableArea::constrainScrollPositionForOverhang().
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setHeaderHeight):
(WebCore::ScrollingStateScrollingNode::setFooterHeight):
- page/scrolling/ScrollingStateScrollingNode.h:
(WebCore::ScrollingStateScrollingNode::headerHeight):
(ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::footerHeight):
- page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::ScrollingTreeScrollingNode):
(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):
- page/scrolling/ScrollingTreeScrollingNode.h:
(WebCore::ScrollingTreeScrollingNode::headerHeight):
(WebCore::ScrollingTreeScrollingNode::footerHeight):
(ScrollingTreeScrollingNode):
- page/scrolling/mac/ScrollingCoordinatorMac.h:
(ScrollParameters):
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinatorMac::setScrollParametersForNode):
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):
Use footerHeight when calculating the maxValue and use headerHeight in determining
what the minimum value is.
- platform/ScrollableArea.cpp:
(WebCore::constrainedScrollPosition):
(WebCore::ScrollableArea::constrainScrollPositionForOverhang):
- platform/ScrollableArea.h:
(ScrollableArea):
LayoutTests:
- platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer.html: Added.
- 11:23 AM Changeset in webkit [147470] by
-
- 4 edits7 adds in trunk
[Skia] Enable GPU-accelerated Skia path for FEComposite filter.
https://bugs.webkit.org/show_bug.cgi?id=113797
Reviewed by Adrienne Walker.
Source/WebCore:
Tests: css3/filters/effect-reference-composite-hw.html
css3/filters/effect-reference-composite.html
- WebCore.gypi:
- platform/graphics/filters/FEComposite.h:
Enable Skia DAG hook for FEComposite.
- platform/graphics/filters/skia/FECompositeSkia.cpp: Added.
(WebCore::FEComposite::createImageFilter):
Implement skia DAG builder for FEComposite, and implement generic
skia version of composite filter.
LayoutTests:
- css3/filters/effect-reference-composite-hw.html: Added.
- css3/filters/effect-reference-composite.html: Added.
- platform/chromium-linux/css3/filters/effect-reference-composite-expected.png: Added.
- platform/chromium-linux/css3/filters/effect-reference-composite-expected.txt: Added.
- platform/chromium-linux/css3/filters/effect-reference-composite-hw-expected.png: Added.
- platform/chromium-linux/css3/filters/effect-reference-composite-hw-expected.txt: Added.
- 11:20 AM Changeset in webkit [147469] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Avoid using style.display="inline-block"
https://bugs.webkit.org/show_bug.cgi?id=113802
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
No new tests.
- Create class "inline-block" which will set "display: inline-block"
style.
- Use this class with DIV elements to get "inline-block" element.
- inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper.prototype.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
- inspector/front-end/inspector.css:
(.inline-block):
- 11:18 AM Changeset in webkit [147468] by
-
- 3 edits2 adds in trunk
Web Inspector: [Timeline] warning markers are not propagated to coalesced records
https://bugs.webkit.org/show_bug.cgi?id=113789
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/timeline/timeline-coalescing.html
- inspector/front-end/TimelinePresentationModel.js: set childHasWarning on coalescing record if the record it replaces had warnings.
(WebInspector.TimelinePresentationModel.prototype._replaceWithCoalescedRecord):
LayoutTests:
- inspector/timeline/timeline-coalescing-expected.txt: Added.
- inspector/timeline/timeline-coalescing.html: Added.
- 11:17 AM Changeset in webkit [147467] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Create a selection from two points irregardless of the caret position.
https://bugs.webkit.org/show_bug.cgi?id=113795
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-04-02
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
PR276577
If we are to set both the base and extent of a selection, we should maintain the base upon setting the extent.
This prevents us from overwriting the previous calculation when setting extent.
Further, instead of setting and manipulating the selection, simply set up start and end VisiblePositions and
create a new directional selection so as to set the base and extent simultaneously.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::setSelection):
- 11:16 AM Changeset in webkit [147466] by
-
- 8 edits2 adds in trunk
Web Inspector: memory instrumentation for external strings is broken
https://bugs.webkit.org/show_bug.cgi?id=113788
Source/WebCore:
Reviewed by Pavel Feldman.
Native memory snapshot now provides information about JS external strings.
Test: inspector/profiler/memory-instrumentation-external-string.html
- inspector/InspectorMemoryAgent.cpp:
LayoutTests:
Test that native memory snapshot contains information about extenral strings.
Reviewed by Pavel Feldman.
- inspector/profiler/memory-instrumentation-external-string-expected.txt: Added.
- inspector/profiler/memory-instrumentation-external-string.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- 11:14 AM Changeset in webkit [147465] by
-
- 10 edits2 adds in trunk
Web Inspector: memory instrumentation for external arrays is broken
https://bugs.webkit.org/show_bug.cgi?id=113790
Source/WebCore:
Report pointers to external arrays as retaining ones to make sure their
size is counted correctly.
Reviewed by Pavel Feldman.
Test: inspector/profiler/memory-instrumentation-external-array.html
- inspector/InspectorMemoryAgent.cpp:
Source/WTF:
Reviewed by Pavel Feldman.
- wtf/MemoryInstrumentationArrayBufferView.h: report buffer pointer as retaining one as
we know that the pointer is not broken.
(WTF::reportMemoryUsage):
LayoutTests:
Test that JS external resources size includes size of JS external arrays
created in the inspected page.
Reviewed by Pavel Feldman.
- inspector/profiler/memory-instrumentation-external-array-expected.txt: Added.
- inspector/profiler/memory-instrumentation-external-array.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- 11:12 AM Changeset in webkit [147464] by
-
- 4 edits in trunk/Source/WebCore
[JSC] Don't create a JSValue if it's not going to be used for nullable attributes
https://bugs.webkit.org/show_bug.cgi?id=112711
Reviewed by Sam Weinig.
When nullable attributes are used, it's possible that we disregard the JSValue
when null should be returned instead. This is a waste, and we should cast the
native type to a JSValue as late as possible.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(NativeValueToLocal):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjAttrWithGetterException):
(WebCore::jsTestObjStringAttrWithGetterException):
(WebCore::jsTestObjWithScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::jsTestObjNullableDoubleAttribute):
(WebCore::jsTestObjNullableLongAttribute):
(WebCore::jsTestObjNullableBooleanAttribute):
(WebCore::jsTestObjNullableStringAttribute):
(WebCore::jsTestObjNullableLongSettableAttribute):
(WebCore::jsTestObjNullableStringValue):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::jsTestTypedefsAttrWithGetterException):
(WebCore::jsTestTypedefsStringAttrWithGetterException):
- 11:10 AM Changeset in webkit [147463] by
-
- 3 edits2 adds in trunk
[css exclusions] overflow:hidden undoes shape-outside offsets
https://bugs.webkit.org/show_bug.cgi?id=110349
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-04-02
Reviewed by Julien Chaffraix.
Source/WebCore:
When overflow: hidden was set on a float with shape-outside, the
offset from the shape-outside was being ignored. This was because the
float was being placed in the normal flow, causing the offsets to be
calculated differently. Since floats with shape outside behave like
positioned objects in many places, I have caused them to take the same
behavior as positioned objects in this case as well: the floats with
shape-outside do not get placed in the normal flow when overflow:
hidden is set.
Test: fast/exclusions/shape-outside-floats/shape-outside-floats-overflow-hidden.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeNormalFlowOnly): Floats that have
shape-outside should not be in the normal flow.
LayoutTests:
Add a test to make sure the float is properly positioned with
overflow: hidden.
- fast/exclusions/shape-outside-floats/shape-outside-floats-overflow-hidden-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-overflow-hidden.html: Added.
- 11:06 AM Changeset in webkit [147462] by
-
- 2 edits in tags/Safari-537.35.6/Source/WebCore
Merged r147373. <rdar://problem/13202277>
- 11:04 AM Changeset in webkit [147461] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: resource preview of html/js/css types should be on a grey background
https://bugs.webkit.org/show_bug.cgi?id=113791
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
No new tests.
- Add a css rule to set grey background for SourceFrame in resource view.
- Add "fill" style to SourceFrame element to setup its height.
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
- inspector/front-end/resourceView.css:
(.resource-view .script-view):
- 11:04 AM Changeset in webkit [147460] by
-
- 5 edits in tags/Safari-537.35.6/Source
Merged r147359. <rdar://problem/13549181>
- 11:02 AM Changeset in webkit [147459] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [CodeMirror] Editor doesn't have yellow background in DivergedFromVM state
https://bugs.webkit.org/show_bug.cgi?id=113783
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
No new tests.
Force CodeMirrorTextEditor to have transparent background to inherit
background color from source frame.
- inspector/front-end/cm/cmdevtools.css:
(.CodeMirror):
- 11:01 AM Changeset in webkit [147458] by
-
- 4 edits in tags/Safari-537.35.6/Source
Versioning.
- 10:59 AM Changeset in webkit [147457] by
-
- 10 edits in trunk/Tools
Dashboard refactor: Move dashboard specific history related features to History.
https://bugs.webkit.org/show_bug.cgi?id=113717
Reviewed by Ojan Vafai.
Each dashboard now creates its own History object, with a custom
configuration. This changes from just overriding global functions
to passing in callbacks for generatePage, handleValidHashParameter,
and handleQueryParameterChange. Same with passing in defaultStateValues
and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
variables.
All functions related to these features are now (mostly) private
function on History.
Loader no longer needs a loadingComplete callback, since it can just
initialize the history object itself.
- TestResultServer/static-dashboards/aggregate_results.js:
(handleValidHashParameter):
- TestResultServer/static-dashboards/dashboard_base.js:
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(generatePage):
(.switch.return):
(handleQueryParameterChange):
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(resetGlobals):
- TestResultServer/static-dashboards/history.js:
(.):
- TestResultServer/static-dashboards/loader.js:
(.):
- TestResultServer/static-dashboards/loader_unittests.js:
- TestResultServer/static-dashboards/timeline_explorer.js:
(generatePage):
(initCurrentBuilderTestResults):
- TestResultServer/static-dashboards/treemap.js:
(generatePage):
(.switch.return):
(handleQueryParameterChange):
- 10:58 AM Changeset in webkit [147456] by
-
- 15 edits in tags/Safari-537.35.6
Merged r147260. <rdar://problem/13536343>
- 10:53 AM Changeset in webkit [147455] by
-
- 3 edits in branches/chromium/1410/Source/WebCore
Merge 147389 "Hide non-coordinated scrollbars for Android M26"
Hide non-coordinated scrollbars for Android M26
https://bugs.webkit.org/show_bug.cgi?id=113738
Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-04-01
Reviewed by Simon Fraser.
This patch will hide any non-coordinated scrollbars on Android.
Coordinated scrollbars won't be affected.
Currently all scrollbars are coordinated on Android. The sole purpose
of this patch is to be cherry-picked to the M26 branch.
No new tests. Please revert immediately after landed.
- platform/ScrollView.cpp:
(WebCore::positionScrollbarLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::positionOverflowControlsLayers):
TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/13470017
- 10:53 AM Changeset in webkit [147454] by
-
- 3 edits2 adds in trunk
Check whether popups are allowed before creating a new window
https://bugs.webkit.org/show_bug.cgi?id=113782
Reviewed by Adam Barth.
Source/WebCore:
Otherwise, firing a generated mouse event at an anchor is enough to
work around the popup blocker.
Test: fast/loader/url-selected-user-gesture.html
- loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNewWindowPolicy):
LayoutTests:
- fast/loader/url-selected-user-gesture-expected.txt: Added.
- fast/loader/url-selected-user-gesture.html: Added.
- 10:50 AM Changeset in webkit [147453] by
-
- 5 edits in trunk
When computing the percentage of the logical height, use the logical top and bottom
https://bugs.webkit.org/show_bug.cgi?id=113761
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/writing-mode/percentage-height-orthogonal-writing-modes.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight):
LayoutTests:
- fast/writing-mode/percentage-height-orthogonal-writing-modes-expected.txt:
- fast/writing-mode/percentage-height-orthogonal-writing-modes.html:
- 10:50 AM Changeset in webkit [147452] by
-
- 3 edits in tags/Safari-537.35.6/Source/WebCore
Merged r147240. <rdar://problem/13256956>
- 10:49 AM Changeset in webkit [147451] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [CodeMirror] do not show cursor in read-only mode
https://bugs.webkit.org/show_bug.cgi?id=113793
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Alexander Pavlov.
No new tests.
Pass "nocursor" option to CodeMirror's "readonly" setting.
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.prototype.setReadOnly):
- 10:47 AM Changeset in webkit [147450] by
-
- 22 edits in trunk
Unreviewed, rolling out r147402.
http://trac.webkit.org/changeset/147402
https://bugs.webkit.org/show_bug.cgi?id=112903
Source/WebCore:
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
LayoutTests:
- http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html:
- http/tests/security/XFrameOptions/x-frame-options-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- 10:45 AM Changeset in webkit [147449] by
-
- 4 edits in tags/Safari-537.35.6/Source/WebCore
Merged r146995. <rdar://problem/13474743>
- 10:41 AM Changeset in webkit [147448] by
-
- 1 edit3 copies in branches/chromium/1453
Merge 147127 "RenderBox::backgroundIsKnownToBeOpaqueInRect may b..."
RenderBox::backgroundIsKnownToBeOpaqueInRect may be wrong for theme-painted elements
https://bugs.webkit.org/show_bug.cgi?id=113419
Reviewed by Simon Fraser.
Source/WebCore:
Do not consider control elements as opaque. They are typically theme painted, and we cannot assume opaqueness on the behalf of theme. It can be improved by asking the theme if it paints opaque.
Test: compositing/contents-opaque/control-layer.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):
LayoutTests:
- compositing/contents-opaque/control-layer-expected.txt: Added.
- compositing/contents-opaque/control-layer.html: Added.
- platform/chromium/compositing/contents-opaque/control-layer-expected.txt: Added.
TBR=alokp@chromium.org
BUG=223490
Review URL: https://codereview.chromium.org/13465009
- 10:35 AM Changeset in webkit [147447] by
-
- 16 edits in trunk/Source/WebKit/mac
WebKit/mac shouldn't have code for Mac 10.5 and earlier
https://bugs.webkit.org/show_bug.cgi?id=113746
Reviewed by Darin Adler.
Deleted the code for 10.5 and removed if-defs for 10.6.
- Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView createPlugin]):
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView createPlugin]):
(-[WebNetscapePluginView getVariable:forURL:value:length:]):
(-[WebNetscapePluginView _workaroundSilverlightFullscreenBug:]):
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::selectItemWritingDirectionIsNatural):
(WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection):
- WebCoreSupport/WebEditorClient.mm:
(core):
(WebEditorClient::checkTextOfParagraph):
(WebEditorClient::requestCheckingOfString):
- WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController _updateMenuAndDockForFullScreen]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
(-[WebHTMLView _frameOrBoundsChanged]):
(+[WebHTMLView _insertablePasteboardTypes]):
(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
(writingDirectionKeyBindingsEnabled):
(-[WebHTMLView _lookUpInDictionaryFromMenu:]):
(-[WebHTMLView attachRootLayer:]):
- WebView/WebHTMLViewInternal.h:
- WebView/WebPDFDocumentExtras.mm:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
- WebView/WebResourceInternal.h:
- WebView/WebScriptDebugDelegate.h:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _preferencesChanged:]):
(+[WebView initialize]):
(clientNeedsWebViewInitThreadWorkaround):
(-[WebView validateUserInterfaceItemWithoutDelegate:]):
(-[WebView setGrammarCheckingEnabled:]):
(-[WebView isAutomaticQuoteSubstitutionEnabled]):
(-[WebView isAutomaticLinkDetectionEnabled]):
(-[WebView isAutomaticDashSubstitutionEnabled]):
(-[WebView isAutomaticTextReplacementEnabled]):
(-[WebView isAutomaticSpellingCorrectionEnabled]):
(-[WebView _searchWithSpotlightFromMenu:]):
(WebInstallMemoryPressureHandler):
- WebView/WebViewPrivate.h:
- 10:28 AM Changeset in webkit [147446] by
-
- 8 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support fast property stores
https://bugs.webkit.org/show_bug.cgi?id=113757
Reviewed by Oliver Hunt.
Simplified the task of handling property transitions and reduced amount of code
duplication between the JITs.
Added PutByOffset, PutStructure, PhantomPutStructure, WeakJSConstant, and a
stub form of StructureTransitionWatchpoint to the FTL.
Also simplified the creation of pointer constants, and fixed a bug in
speculateObject().
- dfg/DFGGraph.h:
(JSC::DFG::Graph::notifyCompilingStructureTransition):
(Graph):
- dfg/DFGJITCompiler.h:
(JITCompiler):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileWeakJSConstant):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileStructureTransitionWatchpoint):
(JSC::FTL::LowerDFGToLLVM::compilePutStructure):
(JSC::FTL::LowerDFGToLLVM::compilePhantomPutStructure):
(JSC::FTL::LowerDFGToLLVM::compilePutByOffset):
(JSC::FTL::LowerDFGToLLVM::speculateObject):
(JSC::FTL::LowerDFGToLLVM::weakPointer):
- ftl/FTLOutput.h:
(Output):
(JSC::FTL::Output::constIntPtr):
(JSC::FTL::Output::absolute):
- 10:24 AM Changeset in webkit [147445] by
-
- 2 edits in trunk/LayoutTests
webkit fails IETC grid-column-002
https://bugs.webkit.org/show_bug.cgi?id=83907
Unreviewed Mac test expectation fix.
- platform/mac/TestExpectations:
Removed grid-column-002.htm here too.
- 10:21 AM Changeset in webkit [147444] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, chromium expectations update.
- platform/chromium/TestExpectations: Mark svg/as-image/image-respects-pageScaleFactor.html as flaky.
- 10:16 AM Changeset in webkit [147443] by
-
- 5 edits in trunk/Source/WebCore
[GTK][AC] Support preserves3D css property for clutter ac backend.
https://bugs.webkit.org/show_bug.cgi?id=113318
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-02
Reviewed by Gustavo Noronha Silva.
This patch brings preserve-3D css property support to WebKitGtk+ with clutter ac backed.
Most of the code is based on Mac port's implementation. The core concept is that
if a layer has preserve-3d property false, we mark itself and its immediate children
to make them flatten. And then we remove 3D factor in a modelView matrix
when applying it to each actor.
No new tests as this is covered with existing AC tests.
- platform/graphics/clutter/GraphicsLayerActor.cpp:
(_GraphicsLayerActorPrivate):
(graphics_layer_actor_init):
(graphicsLayerActorApplyTransform):
(graphicsLayerActorNew):
(graphicsLayerActorRemoveFromSuperLayer):
(graphicsLayerActorSetDrawsContent):
(graphicsLayerActorSetFlatten):
- platform/graphics/clutter/GraphicsLayerActor.h:
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::platformLayer):
(WebCore::GraphicsLayerClutter::moveOrCopyAnimations):
(WebCore):
(WebCore::GraphicsLayerClutter::setPreserves3D):
(WebCore::GraphicsLayerClutter::flushCompositingState):
(WebCore::GraphicsLayerClutter::recursiveCommitChanges):
(WebCore::GraphicsLayerClutter::commitLayerChangesAfterSublayers):
(WebCore::GraphicsLayerClutter::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerClutter::updateGeometry):
(WebCore::GraphicsLayerClutter::updateSublayerList):
(WebCore::GraphicsLayerClutter::updateStructuralLayer):
(WebCore::GraphicsLayerClutter::ensureStructuralLayer):
(WebCore::GraphicsLayerClutter::structuralLayerPurpose):
(WebCore::GraphicsLayerClutter::layerForSuperlayer):
- platform/graphics/clutter/GraphicsLayerClutter.h:
(CommitState):
(WebCore::GraphicsLayerClutter::CommitState::CommitState):
(GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::primaryLayer):
- 10:10 AM Changeset in webkit [147442] by
-
- 1 copy in tags/Safari-537.35.6
New Tag.
- 9:14 AM Changeset in webkit [147441] by
-
- 8 edits5 adds in trunk
HTML parser should consistently inspect the namespace of elements on the stack of open elements
https://bugs.webkit.org/show_bug.cgi?id=113723
Reviewed by Adam Barth.
Source/WebCore:
Added HTMLStackItem::matchesHTMLTag method and use that nearly
everywhere instead of HTMLStackItem::hasLocalName. The most important
of these changes is in HTMLElementStack's inScopeCommon() function,
where the use of matchesHTMLTag means that any of the inXXXScope()
calls now only match HTML tags.
Tests: html5lib/generated/run-namespace-sensitivity-data.html
html5lib/generated/run-namespace-sensitivity-write.html
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion):
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::popUntil):
(WebCore::HTMLElementStack::topmost):
(WebCore::inScopeCommon):
(WebCore::HTMLElementStack::inScope):
(WebCore::HTMLElementStack::inListItemScope):
(WebCore::HTMLElementStack::inTableScope):
(WebCore::HTMLElementStack::inButtonScope):
(WebCore::HTMLElementStack::inSelectScope):
- html/parser/HTMLElementStack.h:
(WebCore::HTMLElementStack::popUntilPopped):
- html/parser/HTMLFormattingElementList.cpp:
(WebCore::HTMLFormattingElementList::closestElementInScopeWithName):
- html/parser/HTMLStackItem.h:
(WebCore::HTMLStackItem::matchesHTMLTag):
(HTMLStackItem):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
LayoutTests:
- html5lib/generated/run-namespace-sensitivity-data-expected.txt: Added.
- html5lib/generated/run-namespace-sensitivity-data.html: Added.
- html5lib/generated/run-namespace-sensitivity-write-expected.txt: Added.
- html5lib/generated/run-namespace-sensitivity-write.html: Added.
- html5lib/resources/namespace-sensitivity.dat: Added.
- 9:00 AM Changeset in webkit [147440] by
-
- 3 edits in trunk/Source/WebCore
Report memory usage for ShadowDistributedRules.
https://bugs.webkit.org/show_bug.cgi?id=109882
Reviewed by Dimitri Glazkov.
This is a follow-up patch for r142855.
No new tests, no behavior change for layout tests.
- css/DocumentRuleSets.cpp:
(WebCore):
(WebCore::ShadowDistributedRules::reportMemoryUsage):
(WebCore::DocumentRuleSets::reportMemoryUsage):
- css/DocumentRuleSets.h:
(ShadowDistributedRules):
- 8:58 AM Changeset in webkit [147439] by
-
- 6 edits2 adds in trunk
AX: Need to get line thickness from fraction on web
https://bugs.webkit.org/show_bug.cgi?id=113720
Reviewed by David Kilzer.
Expose the line thickness property for fractions, which is needed to
help determine the type of equation.
Test: platform/mac/accessibility/mathml-line-fraction.html
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::mathLineThickness):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::mathLineThickness):
(WebCore):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityMathLineThickness]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- 8:48 AM Changeset in webkit [147438] by
-
- 2 edits in branches/chromium/1453/Source
Merge 147178 "[Chromium] Don't create SolidColorLayer for full t..."
[Chromium] Don't create SolidColorLayer for full transparent background
https://bugs.webkit.org/show_bug.cgi?id=113524
Reviewed by James Robinson.
Source/WebCore:
Test: GraphicsLayerChromiumTest.setContentsToSolidColor
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToSolidColor):
Source/WebKit/chromium:
- tests/GraphicsLayerChromiumTest.cpp:
(GraphicsLayerChromiumTest::setContentsToSolidColor):
TBR=wangxianzhu@chromium.org
Review URL: https://codereview.chromium.org/13430007
- 8:43 AM Changeset in webkit [147437] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed.
Enable fast/regions/region-style-inline-background-color.html on Mountain Lion as it started to pass.
- platform/chromium/TestExpectations:
- 8:24 AM Changeset in webkit [147436] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r147389.
http://trac.webkit.org/changeset/147389
https://bugs.webkit.org/show_bug.cgi?id=113738
r147389 was temporary patch for Chromium branch management, needs
revert.
- platform/ScrollView.cpp:
(WebCore::positionScrollbarLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::positionOverflowControlsLayers):
- 8:21 AM Changeset in webkit [147435] by
-
- 4 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
New results for effect-reference-hw, due to slight pixel differences from http://src.chromium.org/viewvc/chrome?view=rev&revision=191067
- platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
- platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
- platform/chromium/TestExpectations:
- 8:18 AM Changeset in webkit [147434] by
-
- 3 edits2 adds in trunk
Hang when calling setCurrentTime on SVG with cyclic animation dependency chain
https://bugs.webkit.org/show_bug.cgi?id=113485
Patch by David Vest <davve@opera.com> on 2013-04-02
Reviewed by Stephen Chenney.
Source/WebCore:
If no exact match can be found, approximateBinarySearch may return
either adjacent value to the key. Selecting the lesser value when
there is a greater one may cause interval creation to fail in a
way that causes infinite loops during seeking. Detect and amend
this condition by selecting the greater value when possible.
Test: svg/animations/animation-dependency-hang.html
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::findInstanceTime):
LayoutTests:
- svg/animations/animation-dependency-hang-expected.txt: Added.
- svg/animations/animation-dependency-hang.html: Added.
- 7:58 AM Changeset in webkit [147433] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: source location gets frozen after inspector reload
https://bugs.webkit.org/show_bug.cgi?id=113776
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
Put statusBarText item in its own container and update its contents in
ScriptsPanel._updateScriptViewStatusBarItems in similar way it's done
for statusBarItems.
No new tests.
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.statusBarText):
(WebInspector.ScriptsPanel.prototype._updateScriptViewStatusBarItems):
- 7:47 AM Changeset in webkit [147432] by
-
- 2 edits in trunk/Source/WebCore
Remove unneeded cpp file from CMake build. Rubber-stamp by Alexis Menard.
- CMakeLists.txt: Remove FFTFrameStub.cpp, since adding this file or not
to your build is a platform decision.
- 7:44 AM Changeset in webkit [147431] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: [Timeline] unify logic for 3 overview modes in Timeline
https://bugs.webkit.org/show_bug.cgi?id=113708
Reviewed by Yury Semikhatsky.
- make TimelineOverviewPane logic independent on overview mode;
- show only one of 3 controls at one time;
- attach overview controls to the same parent.
- inspector/front-end/OverviewGrid.js: remove gridElement() and itemsGraphsElement(), no longer needed.
(WebInspector.OverviewGrid):
- inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.setMode):
(WebInspector.TimelineOverviewPane.prototype._innerSetMode):
(WebInspector.TimelineOverviewPane.prototype._createOverviewControl):
(WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.addFrame):
(WebInspector.TimelineOverviewPane.prototype.zoomToFrame):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
(WebInspector.TimelineOverviewBase.prototype.update):
(WebInspector.TimelineOverviewBase.prototype.reset):
(WebInspector.TimelineOverviewBase.prototype.categoryVisibilityChanged):
(WebInspector.TimelineOverviewBase.prototype.addFrame):
(WebInspector.TimelineOverviewBase.prototype.getWindowTimes):
(WebInspector.TimelineEventOverview):
(WebInspector.TimelineEventOverview.prototype.categoryVisibilityChanged):
- inspector/front-end/timelinePanel.css:
- 7:41 AM Changeset in webkit [147430] by
-
- 11 edits1 add in trunk
webkit fails IETC grid-column-002
https://bugs.webkit.org/show_bug.cgi?id=83907
Reviewed by Ojan Vafai.
Source/WebCore:
Tests: fast/css-grid-layout/grid-item-column-row-get-set.html
ietestcenter/css3/grid/grid-column-002.htm
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
Don't accept 0 as a valid <integer> position.
LayoutTests:
- fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
- fast/css-grid-layout/grid-item-column-row-get-set.html:
Extended our testing to cover setting grid-{start|end|before|after} to 0.
- ietestcenter/css3/grid/grid-column-002.htm:
- ietestcenter/css3/grid/testRunnerEnableGrid.js: Added.
Needed to dynamically enable CSS Grid Layout for the test to pass. The file
hosts the boiler-plate code which will be common to all tests.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt-mac/TestExpectations:
- platform/qt/TestExpectations:
Removed grid-column-002.htm from the test expectations.
- 7:36 AM Changeset in webkit [147429] by
-
- 3 edits5 adds4 deletes in trunk/LayoutTests
[EFL] Unreviewed gardening.
- platform/efl-wk2/TestExpectations:
- platform/efl-wk2/fast/repaint/caret-with-transformation-expected.png: Added.
- platform/efl-wk2/fast/repaint/caret-with-transformation-expected.txt: Added.
- platform/efl-wk2/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
- platform/efl-wk2/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
- platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
- platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
- platform/efl-wk2/svg/css/composite-shadow-example-expected.txt: Removed.
- platform/efl-wk2/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
- platform/efl/TestExpectations:
- 7:28 AM Changeset in webkit [147428] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: allow referencing of nodes that have not been pushed to the front-end
https://bugs.webkit.org/show_bug.cgi?id=110921
Patch by Dmitry Gozman <dgozman@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
Nodes not yet pushed to front-end are referenced by BackendNodeId and retained.
One can group nodes when generating BackendNodeIds to release them all together later.
To resolve node references by BackendNodeId, frontend should use new pushNodeByBackendIdToFrontend method.
This will invalidate the generated BackendNodeId.
- inspector/Inspector.json:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::backendNodeIdForNode):
(WebCore::InspectorDOMAgent::releaseBackendNodeIds):
(WebCore::InspectorDOMAgent::pushNodeByBackendIdToFrontend):
- inspector/InspectorDOMAgent.h:
(WebCore):
(InspectorDOMAgent):
- 7:28 AM Changeset in webkit [147427] by
-
- 4 edits in trunk/LayoutTests
Web Inspector: Update test expectation for console-cross-origin-iframe-logging.html
https://bugs.webkit.org/show_bug.cgi?id=113756
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-02
Reviewed by Pavel Feldman.
Simplified errors by not including the whole URL after r145692.
- http/tests/inspector/console-cross-origin-iframe-logging-expected.txt:
- platform/efl/TestExpectations:
- platform/qt/TestExpectations:
- 6:48 AM Changeset in webkit [147426] by
-
- 10 edits8 adds in trunk
[CSS Regions] Nested auto-height regions don't layout correctly
https://bugs.webkit.org/show_bug.cgi?id=111969
Reviewed by David Hyatt.
Source/WebCore:
The patch fixes the auto-height regions processing model to work with nested named flows. Currently
this use case doesn't work correctly because the order in which the computed height value is propagated
to the regions is incorrect. For example, in the case of two flows (f1 and f2) and two auto-height
regions (r1 and r2) with r2 a member of f1:
- the normal layout phase starts
- r1 is laid out with height = 0
- f1 is laid out including r2 with height = 0; overrideLogicalHeight for r1 is computed
- f2 is laid out; overrideLogicalHeight for r2 is computed
- the constrained layout phase starts
- r1 is laid out using the overrideLogicalHeight computed in the normal phase
- f1 is laid out including r2 with its overrideLogicalHeight
- f2 is laid out
The problem appears at step 6 because the overrideLogicalheight computed during step 3 assumes r2
has a height of 0. The patch changes the algorithm to update the auto-height regions in the reverse
order of their flow threads dependecies. Here is a high level overview of the new algorithm,
considering the named flows are sorted in the order of their dependencies:
- The flows are laid out from the outer flow to the inner flow. This successfully computes the outer
non-auto-height regions size so the inner flows have the necessary information to correctly fragment
the content.
- The flows are laid out from the inner flow to the outer flow. After an inner flow is laid out it
goes into the constrained layout phase and marks the auto-height regions they need layout. This
means the outer flows will relayout if they depend on regions with auto-height regions belonging to
inner flows. This step will correctly compute the overrideLogicalHeights for the auto-height regions.
It's possible for non-auto-height regions to relayout if they depend on auto-height regions. This
will invalidate the inner flow threads and mark them as needing layout.
- The last step is to do one last layout if there are pahtological dependencies between non-auto-height
regions and auto-height regions as detected in the previous step.
The patch also removes the layout phase flag from RenderView and moves it to the flow threads. This
happens because a flow needs to update its auto-height regions overrideLogicalHeight while updating
the logical height of the regions belonging to the inner flows that are laid out by the flow (i.e. the
outer flow is in the normal phase while the inner flows are in the constrained layout phase).
There's also a new flag on the RenderFlowThread that is set when the flow needs the constrained layout
phase. This could have been placed on the flow thread controller but I think it will be useful when doing
content balancing for the new multi-column implementation.
Another change is the moment we clear the overrideLogicalHeight value on empty auto-height regions because
we don't have to relayout a flow thread once it's in the constrained phase. We need to have the correct
flow thread portions correctly computed after the artificial forced break is applied at the end of the content.
Tests: fast/regions/autoheight-mixed-nested-complex-regions.html
fast/regions/autoheight-mixed-nested-regions.html
fast/regions/autoheight-mixed-parallel-regions.html
fast/regions/autoheight-nested-regions.html
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::FlowThreadController):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads):
(WebCore):
(WebCore::FlowThreadController::registerNamedFlowContentNode):
(WebCore::FlowThreadController::unregisterNamedFlowContentNode):
(WebCore::FlowThreadController::updateFlowThreadsChainIfNecessary):
(WebCore::FlowThreadController::updateFlowThreadsNeedingLayout):
(WebCore::FlowThreadController::updateFlowThreadsNeedingTwoStepLayout):
(WebCore::FlowThreadController::resetFlowThreadsWithAutoHeightRegions):
(WebCore::FlowThreadController::updateFlowThreadsIntoConstrainedPhase):
- rendering/FlowThreadController.h:
(FlowThreadController):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::regionAtBlockOffset):
(WebCore::RenderFlowThread::applyBreakAfterContent): Apply an artificial break at the end of the content.
This way we can detect when the content ends and clear the overrideLogicalHeight on the empty auto-height regions.
(WebCore::RenderFlowThread::computeOverflowStateForRegions):
(WebCore):
(WebCore::RenderFlowThread::initializeRegionsOverrideLogicalContentHeight):
(WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):
- rendering/RenderFlowThread.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::pageLogicalWidth):
(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::maxPageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):
(WebCore::RenderRegion::layoutBlock):
(WebCore::RenderRegion::updateLogicalHeight):
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore):
(WebCore::RenderView::layoutContentInAutoLogicalHeightRegions):
(WebCore::RenderView::layout):
- rendering/RenderView.h:
(WebCore):
(RenderView):
LayoutTests:
These tests cover various combinations of dependencies between flows and regions with
or without auto-height.
- fast/regions/autoheight-mixed-nested-complex-regions-expected.txt: Added.
- fast/regions/autoheight-mixed-nested-complex-regions.html: Added.
- fast/regions/autoheight-mixed-nested-regions-expected.txt: Added.
- fast/regions/autoheight-mixed-nested-regions.html: Added.
- fast/regions/autoheight-mixed-parallel-regions-expected.txt: Added.
- fast/regions/autoheight-mixed-parallel-regions.html: Added.
- fast/regions/autoheight-nested-regions-expected.txt: Added.
- fast/regions/autoheight-nested-regions.html: Added.
- 6:46 AM Changeset in webkit [147425] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: ignore minimum record duration filter in Timeline overview
https://bugs.webkit.org/show_bug.cgi?id=113705
Reviewed by Pavel Feldman.
- inspector/front-end/TimelineOverviewPane.js:
- inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._durationFilterChanged):
- 6:45 AM Changeset in webkit [147424] by
-
- 6 edits in trunk/LayoutTests
Web Inspector: add tests for grouped messages filtration in console.
https://bugs.webkit.org/show_bug.cgi?id=113766
Added console groups to console filter test. Fixed minor bugs in other tests.
Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
- inspector/console/console-filter-test-expected.txt:
- inspector/console/console-filter-test.html:
- inspector/console/console-preserve-log.html:
- inspector/console/console-tests-expected.txt:
- inspector/console/console-tests.html:
- 6:44 AM Changeset in webkit [147423] by
-
- 1 edit6 adds in trunk/LayoutTests
[Mac] Unreviewed gardening.
https://bugs.webkit.org/show_bug.cgi?id=113775
Tests need platform-specific rebaselines after r147402. :(
- platform/mac-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
- platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
- platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
- platform/mac/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
- 6:19 AM Changeset in webkit [147422] by
-
- 9 edits in trunk
Web Inspector: display the number of dirty render objects in Layout timeline event
https://bugs.webkit.org/show_bug.cgi?id=95331
Reviewed by Pavel Feldman.
Source/WebCore:
Count the render objects that need layout in InspectorTimelineAgent::willLayout()
and display the number in popover over Layout record in Timeline panel.
- English.lproj/localizedStrings.js:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willLayout):
(WebCore::InspectorTimelineAgent::didLayout):
- inspector/TimelineRecordFactory.cpp:
(WebCore):
(WebCore::TimelineRecordFactory::createLayoutData):
(WebCore::TimelineRecordFactory::appendLayoutRoot):
- inspector/TimelineRecordFactory.h:
(TimelineRecordFactory):
- inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
LayoutTests:
- inspector/timeline/timeline-layout-expected.txt: rebaselined to include new properties;
- 6:15 AM Changeset in webkit [147421] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [CodeMirror] Popover for codemirror
https://bugs.webkit.org/show_bug.cgi?id=113771
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
Implement methods TextEditor.cursorPositionToCoordinates, TextEditor.coordinatesToCursorPosition and
TextEditor.tokenAtTextPosition in CodeMirrorTextEditor to support popover
functionality. Add css classes to highlight popover anchoring text.
No new tests.
- inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.prototype.cursorPositionToCoordinates):
(WebInspector.CodeMirrorTextEditor.prototype.coordinatesToCursorPosition):
(WebInspector.CodeMirrorTextEditor.prototype.tokenAtTextPosition):
- inspector/front-end/cm/cmdevtools.css:
(.CodeMirror .source-frame-eval-expression):
(.CodeMirror .source-frame-eval-expression-end):
(.CodeMirror .source-frame-eval-expression-start):
- 5:56 AM Changeset in webkit [147420] by
-
- 2 edits60 adds1 delete in trunk/LayoutTests
[EFL] Unreviewed gardening.
- platform/efl-wk2/TestExpectations:
- platform/efl-wk2/compositing/contents-opaque/control-layer-expected.txt: Added.
- platform/efl-wk2/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt: Added.
- platform/efl-wk2/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Added.
- platform/efl-wk2/compositing/rtl/rtl-overflow-scrolling-expected.png: Added.
- platform/efl-wk2/compositing/rtl/rtl-overflow-scrolling-expected.txt: Added.
- platform/efl-wk2/css3/flexbox/flexbox-baseline-expected.png: Added.
- platform/efl-wk2/css3/flexbox/flexbox-baseline-expected.txt: Added.
- platform/efl-wk2/editing/pasteboard/copy-paste-content-starting-and-ending-canvas-expected.txt: Added.
- platform/efl-wk2/editing/pasteboard/pasting-into-p-should-not-nest-p-expected.txt: Added.
- platform/efl-wk2/editing/selection/move-by-character-6-expected.txt: Removed.
- platform/efl-wk2/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt: Added.
- platform/efl-wk2/fast/dom/icon-url-property-expected.txt: Added.
- platform/efl-wk2/fast/dynamic/002-expected.txt: Added.
- platform/efl-wk2/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Added.
- platform/efl-wk2/fast/media/mq-resolution-expected.txt: Added.
- platform/efl-wk2/fast/media/w3c/test_media_queries-expected.txt: Added.
- platform/efl-wk2/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
- platform/efl-wk2/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
- platform/efl-wk2/fast/repaint/moving-shadow-on-container-expected.txt: Added.
- platform/efl-wk2/fast/repaint/moving-shadow-on-path-expected.txt: Added.
- platform/efl-wk2/fast/table/overflowHidden-expected.txt: Added.
- platform/efl-wk2/fast/text/complex-text-opacity-expected.png: Added.
- platform/efl-wk2/fast/text/complex-text-opacity-expected.txt: Added.
- platform/efl-wk2/fast/text/international/bidi-layout-across-linebreak-expected.png: Added.
- platform/efl-wk2/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
- platform/efl-wk2/fast/transforms/bounding-rect-zoom-expected.txt: Added.
- platform/efl-wk2/http/tests/inspector/console-resource-errors-expected.txt: Added.
- platform/efl-wk2/http/tests/security/xssAuditor/link-opens-new-window-expected.txt: Added.
- platform/efl-wk2/inspector/styles/paste-property-expected.txt: Added.
- platform/efl-wk2/svg/css/composite-shadow-example-expected.txt: Added.
- platform/efl-wk2/svg/css/composite-shadow-with-opacity-expected.txt: Added.
- platform/efl-wk2/tables/mozilla/bugs/bug73321-expected.txt: Added.
- platform/efl-wk2/tables/mozilla_expected_failures/bugs/bug89315-expected.png: Added.
- platform/efl-wk2/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Added.
- platform/efl-wk2/transforms/2d/hindi-rotated-expected.png: Added.
- platform/efl-wk2/transforms/2d/hindi-rotated-expected.txt: Added.
- 5:50 AM Changeset in webkit [147419] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding failure expectations for two Resource Timing layout tests
that regressed with r147387.
- 5:39 AM QtWebKitBuildBots edited by
- Qt Mountain Lion bot moved to Apple master (diff)
- 5:16 AM Changeset in webkit [147418] by
-
- 4 edits in trunk/Source/WebCore
[BlackBerry] Implement ScrollingCoordinator::frameViewLayoutUpdated()
https://bugs.webkit.org/show_bug.cgi?id=113763
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-02
Reviewed by Rob Buis.
PR 318945
Internally reviewed by Jakob Petsovits.
And remove the BlackBerry specific methods
frameViewFrameRectDidChange and frameViewContentsSizeDidChange.
- page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.cpp:
(WebCore::ScrollingCoordinatorBlackBerry::frameViewLayoutUpdated):
Called when the frame view has been laid out. Update the contents
rectangle and visible area of the scroll layer for the given frame
view.
- page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.h:
(ScrollingCoordinatorBlackBerry):
- platform/graphics/blackberry/LayerWebKitThread.h:
(WebCore::LayerWebKitThread::setFrameVisibleRect): Return early if
value hasn't changed.
(WebCore::LayerWebKitThread::setFrameContentsSize): Ditto.
- 5:06 AM Changeset in webkit [147417] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing tests after r147384 and r147388.
- platform/qt/TestExpectations:
- platform/qt/fast/table/overflowHidden-expected.txt: Rebaselining after 147374.
- 3:58 AM Changeset in webkit [147416] by
-
- 4 edits in trunk
Unreviewed, rolling out r147401.
http://trac.webkit.org/changeset/147401
https://bugs.webkit.org/show_bug.cgi?id=113767
The patch makes it extremely hard to set up the dependencies
properly on the GTK builders (Requested by zdobersek on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-02
.:
- Source/autotools/Versions.m4:
Tools:
- gtk/jhbuild.modules:
- 3:49 AM Changeset in webkit [147415] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Separate JavaScriptSourceFrame popover from knowledge of editor's DOM
https://bugs.webkit.org/show_bug.cgi?id=113412
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-02
Reviewed by Pavel Feldman.
- Use TextEditor.coordinatesToCursorPosition,
TextEditor.cursorPositionToCoordinates and TextEditor.tokenAtTextPosition to figure out
hovering area and create popover anchor.
- Use TextEditor.highlightRange/TextEditor.removeHighlight methods to
highlight hovering text in editor.
No new tests: no change in behaviour.
- inspector/front-end/DefaultTextEditor.js:
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.willHide):
(WebInspector.JavaScriptSourceFrame.prototype._getPopoverAnchor):
(WebInspector.JavaScriptSourceFrame.prototype.):
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):
- inspector/front-end/inspector.css:
(.popover-anchor):
(.source-frame-eval-expression):
- 3:33 AM Changeset in webkit [147414] by
-
- 10 edits in trunk/Source/WebCore
[CSSRegions] RenderFlowThread should not be created as a Document renderer
https://bugs.webkit.org/show_bug.cgi?id=113658
Reviewed by Julien Chaffraix.
After https://bugs.webkit.org/show_bug.cgi?id=107138, RenderFlowThread should not be constructed as a renderer for Document.
Since it does not have an element associated, it will be constructed using the pattern for anonymous blocks.
However, since I do not want the flow thread to be collapsed as anonymous blocks are, i changed RenderObject::isAnonymousBlock
to return false for a RenderFlowThread (the alternative would have been to patch more call sites to prevent RenderFlowThread
collapsing as anonymous block).
Covered by existing tests.
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
- rendering/RenderFlowThread.h:
- rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::addChild):
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::RenderMultiColumnFlowThread):
(WebCore::RenderMultiColumnFlowThread::createAnonymous):
- rendering/RenderMultiColumnFlowThread.h:
(RenderMultiColumnFlowThread):
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::createAnonymous):
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
- rendering/RenderNamedFlowThread.h:
(RenderNamedFlowThread):
- rendering/RenderObject.h:
(WebCore::RenderObject::isAnonymousBlock):
- 3:21 AM Changeset in webkit [147413] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r147383.
http://trac.webkit.org/changeset/147383
https://bugs.webkit.org/show_bug.cgi?id=112369
Speculative rollout because of lots of layout test failure
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::~HTMLDocumentParser):
(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore::HTMLDocumentParser::insert):
- html/parser/HTMLParserScheduler.cpp:
(WebCore::PumpSession::PumpSession):
- html/parser/HTMLParserScheduler.h:
- 2:52 AM Changeset in webkit [147412] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [HeapProfiler] Table rows do not appear when resizing.
https://bugs.webkit.org/show_bug.cgi?id=113760
Reviewed by Yury Semikhatsky.
Analysis: custom-made split-view doesn't notify content panes about
resizing.
- inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._updateRetainmentViewHeight):
Notify content pane about resize.
- 2:50 AM Changeset in webkit [147411] by
-
- 3 edits in trunk/Source/WebCore
[CSSRegions] Clean-up RenderFlowThread::updateRegionsFlowThreadPortionRect
https://bugs.webkit.org/show_bug.cgi?id=113659
Reviewed by Julien Chaffraix.
RenderRegion::logicalHeightOfAllFlowThreadContent already contains the
override logical content height for auto-height regions in normal layout phase.
Therefore, there is no need to explicitly override region's rect height with
the region's overrideLogicalContentHeight as the region rect already contains
the right value.
No change in functionality, covered by existing tests.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):
- 2:50 AM Changeset in webkit [147410] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Empty tooltip shown when hovering over popup menu items
https://bugs.webkit.org/show_bug.cgi?id=113382
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-04-02
Reviewed by Gyuyoung Kim.
Do not show the empty tooltip box if the text is null.
- MiniBrowser/efl/main.c:
(popup_menu_populate):
- 2:47 AM Changeset in webkit [147409] by
-
- 14 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebaselining after r147402.
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- platform/qt/TestExpectations:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- 2:33 AM Changeset in webkit [147408] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
rebaselined after r147390.
TestExpectation was deleted wrongly. Let me revert it.
- platform/chromium/TestExpectations:
- 2:08 AM Changeset in webkit [147407] by
-
- 1 edit7 adds15 deletes in trunk/LayoutTests
[Chromium] Unreviewed gardening.
rebaselined after r147390.
- platform/chromium-linux-x86/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Removed.
- platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Removed.
- platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Removed.
- platform/chromium-linux-x86/svg/as-border-image/svg-as-border-image-expected.png: Removed.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Removed.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Removed.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Removed.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Removed.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Removed.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Removed.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug625-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/marvin/tbody_valign_bottom-expected.png: Added.
- platform/chromium-linux-x86/tables/mozilla/marvin/td_valign_bottom-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/marvin/tfoot_valign_top-expected.png: Added.
- platform/chromium-linux-x86/tables/mozilla/marvin/th_valign_bottom-expected.png: Added.
- platform/chromium-linux/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
- platform/chromium-mac-lion/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Removed.
- platform/chromium-mac-snowleopard/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
- 2:01 AM Changeset in webkit [147406] by
-
- 2 edits in trunk/LayoutTests
[QT] Cleanup after r139447 and r145374.
https://bugs.webkit.org/show_bug.cgi?id=113671
Unreviewed gardening.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-02
- platform/qt/TestExpectations:
- 1:49 AM Changeset in webkit [147405] by
-
- 2 edits1 add in trunk/LayoutTests
[Qt]REGRESSION?(r63191): http/tests/inspector/resource-har-conversion.html fails
https://bugs.webkit.org/show_bug.cgi?id=42162
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-02
Reviewed by Csaba Osztrogonác.
Copy the results of http/tests/inspector/resource-har-conversion.html
to the qt platform dir.
- platform/qt/TestExpectations:
- platform/qt/http/tests/inspector/resource-har-conversion-expected.txt: Added.
- 1:33 AM Changeset in webkit [147404] by
-
- 159 edits7 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening.
rebaselined after r147390.
- platform/chromium-linux-x86/tables/mozilla/bugs/bug625-expected.png: Added.
- platform/chromium-linux-x86/tables/mozilla/marvin/tbody_valign_baseline-expected.png: Added.
- platform/chromium-linux-x86/tables/mozilla/marvin/td_valign_bottom-expected.png: Added.
- platform/chromium-linux-x86/tables/mozilla/marvin/thead_valign_baseline-expected.png: Added.
- platform/chromium-linux-x86/tables/mozilla/marvin/tr_valign_baseline-expected.png: Added.
- platform/chromium-linux-x86/tables/mozilla/marvin/tr_valign_middle-expected.png: Added.
- platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-mac-lion/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-mac-lion/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
- platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
- platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium/TestExpectations:
- 1:32 AM Changeset in webkit [147403] by
-
- 82 edits in trunk/Source/WebKit2
[WK2] Remove repeating code in declaration of WK2 API classes
https://bugs.webkit.org/show_bug.cgi?id=112782
Reviewed by Benjamin Poulain.
The following two lines of code had been repeated in every WK2 API
object class:
1) static const Type APIType = SomeAPIType;
2) virtual Type type() const { return APIType; }
This patch introduces template class 'TypedAPIObject' inherited
from WebKit::APIObject and it contains the common functionality.
So the new pattern is that API object classes are inherited from
TypedAPIObject (rather than from WebKit::APIObject directly) passing
the corresponding API object type as a template parameter.
The existing API object classes are modified accordingly to the
proposed pattern.
- Shared/APIObject.h:
(WebKit):
(TypedAPIObject):
(WebKit::TypedAPIObject::~TypedAPIObject):
(WebKit::TypedAPIObject::TypedAPIObject):
- Shared/ImmutableArray.h:
(ImmutableArray):
- Shared/ImmutableDictionary.h:
(ImmutableDictionary):
- Shared/WebArchive.h:
(WebArchive):
- Shared/WebArchiveResource.h:
(WebArchiveResource):
- Shared/WebBackForwardListItem.h:
(WebBackForwardListItem):
- Shared/WebBatteryStatus.h:
(WebBatteryStatus):
- Shared/WebCertificateInfo.h:
- Shared/WebConnection.h:
(WebConnection):
- Shared/WebContextMenuItem.h:
(WebContextMenuItem):
- Shared/WebData.h:
- Shared/WebError.h:
(WebKit::WebError::errorCode):
- Shared/WebGeolocationPosition.h:
(WebGeolocationPosition):
- Shared/WebGeometry.h:
- Shared/WebGraphicsContext.h:
(WebGraphicsContext):
- Shared/WebHitTestResult.h:
- Shared/WebImage.h:
(WebImage):
- Shared/WebNetworkInfo.h:
(WebNetworkInfo):
- Shared/WebNumber.h:
- Shared/WebOpenPanelParameters.h:
(WebOpenPanelParameters):
- Shared/WebRenderLayer.h:
- Shared/WebRenderObject.h:
- Shared/WebSecurityOrigin.h:
- Shared/WebSerializedScriptValue.h:
(WebSerializedScriptValue):
- Shared/WebString.h:
- Shared/WebURL.h:
- Shared/WebURLRequest.h:
(WebURLRequest):
- Shared/WebURLResponse.h:
(WebURLResponse):
- Shared/WebUserContentURLPattern.h:
- Shared/mac/ObjCObjectGraph.h:
- UIProcess/Authentication/AuthenticationChallengeProxy.h:
(AuthenticationChallengeProxy):
- UIProcess/Authentication/AuthenticationDecisionListener.h:
(AuthenticationDecisionListener):
- UIProcess/Authentication/WebCredential.h:
(WebCredential):
- UIProcess/Authentication/WebProtectionSpace.h:
(WebProtectionSpace):
- UIProcess/Downloads/DownloadProxy.h:
(DownloadProxy):
- UIProcess/GeolocationPermissionRequestProxy.h:
(GeolocationPermissionRequestProxy):
- UIProcess/Notifications/NotificationPermissionRequest.h:
(NotificationPermissionRequest):
- UIProcess/Notifications/WebNotification.h:
(WebNotification):
- UIProcess/Notifications/WebNotificationManagerProxy.h:
(WebNotificationManagerProxy):
- UIProcess/Plugins/WebPluginSiteDataManager.h:
(WebPluginSiteDataManager):
- UIProcess/WebApplicationCacheManagerProxy.h:
(WebApplicationCacheManagerProxy):
- UIProcess/WebBackForwardList.h:
(WebBackForwardList):
- UIProcess/WebBatteryManagerProxy.h:
(WebBatteryManagerProxy):
- UIProcess/WebContext.h:
(WebContext):
- UIProcess/WebCookieManagerProxy.h:
(WebCookieManagerProxy):
- UIProcess/WebDatabaseManagerProxy.h:
(WebDatabaseManagerProxy):
- UIProcess/WebEditCommandProxy.h:
(WebEditCommandProxy):
- UIProcess/WebFrameProxy.h:
(WebFrameProxy):
- UIProcess/WebGeolocationManagerProxy.h:
(WebGeolocationManagerProxy):
- UIProcess/WebGrammarDetail.h:
(WebGrammarDetail):
- UIProcess/WebIconDatabase.h:
(WebIconDatabase):
- UIProcess/WebInspectorProxy.h:
(WebInspectorProxy):
- UIProcess/WebKeyValueStorageManagerProxy.h:
(WebKeyValueStorageManagerProxy):
- UIProcess/WebMediaCacheManagerProxy.h:
(WebMediaCacheManagerProxy):
- UIProcess/WebNavigationData.h:
(WebNavigationData):
- UIProcess/WebNetworkInfoManagerProxy.h:
(WebNetworkInfoManagerProxy):
- UIProcess/WebOpenPanelResultListenerProxy.h:
(WebOpenPanelResultListenerProxy):
- UIProcess/WebPageGroup.h:
(WebPageGroup):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::WebPreferences):
- UIProcess/WebPreferences.h:
(WebPreferences):
- UIProcess/WebResourceCacheManagerProxy.h:
(WebResourceCacheManagerProxy):
- UIProcess/WebTextChecker.h:
(WebTextChecker):
- UIProcess/WebVibrationProxy.h:
(WebVibrationProxy):
- UIProcess/efl/WebPopupItemEfl.h:
(WebPopupItemEfl):
- UIProcess/efl/WebView.h:
- UIProcess/soup/WebSoupRequestManagerProxy.h:
(WebSoupRequestManagerProxy):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
(InjectedBundleNodeHandle):
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:
(InjectedBundleRangeHandle):
- WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
- WebProcess/InjectedBundle/InjectedBundleBackForwardList.h:
- WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:
- WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.h:
(InjectedBundleDOMWindowExtension):
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
- WebProcess/InjectedBundle/InjectedBundleNavigationAction.h:
(InjectedBundleNavigationAction):
- WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
(InjectedBundleScriptWorld):
- WebProcess/WebPage/PageOverlay.h:
(PageOverlay):
- WebProcess/WebPage/WebFrame.h:
(WebFrame):
- WebProcess/WebPage/WebInspector.h:
(WebInspector):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebProcess/WebPage/WebPageGroupProxy.h:
(WebPageGroupProxy):
- 1:28 AM Changeset in webkit [147402] by
-
- 22 edits in trunk
X-Frame-Options: Blocked frames should not inherit their parent's SecurityOrigin.
https://bugs.webkit.org/show_bug.cgi?id=112903
Reviewed by Adam Barth.
Source/WebCore:
This change brings WebKit in line with IE and Gecko's behavior, both of
which treat the blocked frame as being cross-origin for the purposes of
access checks ('[frame].contentWindow.location.href' is inaccessible,
for example).
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
Rather than redirecting to 'about:blank', redirect to
'data:text/html,<p></p>' which does not inherit the SecurityOrigin
of the parent.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
Before calling cancelMainResourceLoad, ensure that the frame's
document is sandboxed into a unique origin so that it doesn't
inherit the parent's SecurityOrigin.
LayoutTests:
- http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html:
- http/tests/security/XFrameOptions/x-frame-options-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- 1:25 AM Changeset in webkit [147401] by
-
- 4 edits in trunk
[GTK] Bump required versions of some dependencies
https://bugs.webkit.org/show_bug.cgi?id=113282
Reviewed by Martin Robinson.
.:
This patch updates the following dependencies:
- libsoup 2.42.0: is the current stable release.
- glib 2.36.0: libsoup 2.42 requires 2.35.0, but we don't want to depend on unstable versions and 2.36 is the next stable version after 2.35.
- gtk+ 3.6.0: this is the previous stable release. We don't currently have any code using newer API, so we will be able to remove all the #ifdefed code.
- at-spi2 2.5.3: is the version required by gtk+ 3.6.
- GObject introspection 1.32.0: is the version required by gtk+ 3.6.
- Pango 1.32.0: it's the current stable version and the first one depending on Harfbuzz.
- Fontconfig 2.5: required by pango 1.32.0 when using Harfbuzz.
- gtk+ 2.24.10: it allows us to remove a lot of deprecated code and #ifdefs.
- Source/autotools/Versions.m4:
Tools:
- gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
- 1:21 AM Changeset in webkit [147400] by
-
- 224 edits2 copies13 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening.
rebaselined after r147390.
- platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png.
- platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png.
- platform/chromium-linux-x86/svg/as-border-image/svg-as-border-image-expected.png: Added.
- platform/chromium-linux-x86/svg/custom/clip-mask-negative-scale-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-mac-lion/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-mac-lion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-mac/svg/as-image/image-preserveAspectRatio-all-expected.png:
- platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac/svg/filters/feImage-preserveAspectRatio-all-expected.png:
- platform/chromium-mac/svg/filters/feImage-preserveAspectratio-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-win/svg/as-image/image-preserveAspectRatio-all-expected.png:
- platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-win/svg/filters/feImage-preserveAspectRatio-all-expected.png:
- platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png:
- 1:12 AM Changeset in webkit [147399] by
-
- 121 edits2 copies1 add in trunk/LayoutTests
[Chromium] Unreviewed gardening.
rebaselined after r147390.
- platform/chromium-linux-x86/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-I18N/text-dirLTR-ubNone-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png.
- platform/chromium-linux-x86/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png.
- platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- 1:02 AM Changeset in webkit [147398] by
-
- 77 edits5 adds4 deletes in trunk/LayoutTests
[Chromium] Unreviewed gardening.
rebaselined after r147390.
- platform/chromium-linux-x86/css2.1/t090501-c5525-flt-l-00-b-g-expected.png: Added.
- platform/chromium-linux-x86/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Removed.
- platform/chromium-linux-x86/fast/borders/border-image-scale-transform-expected.png: Removed.
- platform/chromium-linux-x86/fast/borders/border-image-scaled-expected.png: Removed.
- platform/chromium-linux-x86/fast/borders/scaled-border-image-expected.png: Removed.
- platform/chromium-linux-x86/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
- platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
- platform/chromium-linux/fast/borders/scaled-border-image-expected.png:
- platform/chromium-linux/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
- platform/chromium-mac-lion/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-mac-lion/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-mac-lion/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-mac-lion/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-mac-lion/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac-lion/fast/borders/border-image-scaled-expected.png:
- platform/chromium-mac-lion/fast/borders/scaled-border-image-expected.png:
- platform/chromium-mac-lion/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-mac-lion/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-lion/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-snowleopard/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-mac-snowleopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png:
- platform/chromium-mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize02-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize04-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize13-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize14-expected.png:
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
- platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
- platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
- platform/chromium-mac/fast/borders/scaled-border-image-expected.png:
- platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
- platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
- platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-win/fast/borders/border-image-scaled-expected.png:
- platform/chromium-win/fast/borders/border-image-side-reduction-expected.png:
- platform/chromium-win/fast/borders/scaled-border-image-expected.png:
- platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
- 12:53 AM Changeset in webkit [147397] by
-
- 9 edits1 move1 add in trunk/LayoutTests
[Chromium] Unreviewed gardening.
rebaselined after r147390.
- platform/chromium-linux/css3/images/cross-fade-background-size-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-win/css3/images/cross-fade-background-size-expected.png: Renamed from LayoutTests/platform/chromium/css3/images/cross-fade-background-size-expected.png.
- 12:11 AM Changeset in webkit [147396] by
-
- 3 edits in trunk
[EFL][CMAKE] Move MOZ_X11 definition from OptionsCommon to OptionsEfl
https://bugs.webkit.org/show_bug.cgi?id=113685
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-02
Reviewed by Martin Robinson.
MOZ_X11 is added unconditionally in OptionsCommon for UNIX
platforms, but not all UNIX platforms use X11 for plugins,
BlackBerry doesn't. The only port using cmake that uses X11 is EFL
and it already has checks for X11, so we can just move the
definition to OptionsEfl.
- Source/cmake/OptionsCommon.cmake:
- Source/cmake/OptionsEfl.cmake:
Apr 1, 2013:
- 11:49 PM Changeset in webkit [147395] by
-
- 5 edits in trunk/Source/WebCore
RenderObject::offsetParent should return Element*
https://bugs.webkit.org/show_bug.cgi?id=113739
Reviewed by Abhishek Arya.
The offsetParent of a node should always be an Element, ensure this
by fixing RenderObject::offsetParent to return an Element* and clean up
the method to match the algorithm in the spec which lets us remove the
comments that were trying to explain what was going on.
This also hardens against badness where RenderObject::offsetParent
could have returned a renderer with a non-Element node which would result
in a bad cast in Element::offsetParent. We fixed all cases of this, but
this patch makes sure such things never happen again.
No new tests, no change in behavior.
- dom/Element.cpp:
(WebCore::Element::offsetParent):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::offsetParent): Now returns Element*.
- rendering/RenderObject.h:
(RenderObject):
- 11:34 PM Changeset in webkit [147394] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Removing duplicated expectations to get rid of linting errors.
- 11:29 PM Changeset in webkit [147393] by
-
- 4 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding failure expectation for the svg/repaint/buffered-rendering-static-image.html
layout test added in r147348, most likely due to disabled subpixel layout on the GTK port.
- platform/gtk/fast/table/overflowHidden-expected.png: Updating after r147245.
- platform/gtk/fast/table/overflowHidden-expected.txt: Ditto.
- 11:28 PM Changeset in webkit [147392] by
-
- 4 edits in trunk/Source/WebCore
Simply GIFImageReader error handling
https://bugs.webkit.org/show_bug.cgi?id=113718
Reviewed by Adam Barth.
When GIFImageReader encounters a parsing error it should just return
without doing any more work. Current code saves a boolean before return,
this is not necessary.
Tested with existing unit tests.
Tested locally with ASAN build with 60k GIF images.
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::repetitionCount):
- platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::decode):
- platform/image-decoders/gif/GIFImageReader.h:
(GIFImageReader::GIFImageReader):
(GIFImageReader):
- 11:23 PM Changeset in webkit [147391] by
-
- 15 edits in trunk/Source/WebCore
Make all v8 weak callbacks type safe
https://bugs.webkit.org/show_bug.cgi?id=111802
Reviewed by Adam Barth.
Make all v8 handle weak callbacks typesafe by adding a new class WeakHandleListner
that uses templates to generate the callback proxies that have the correct type
arguments. Now getting the arguments wrong will fail compilation.
No new tests, no change in behavior.
- bindings/v8/DOMDataStore.h:
(WebCore::::callback):
- bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperMap::DOMWrapperMap):
(WebCore::DOMWrapperMap::set):
(WebCore::DOMWrapperMap::reportMemoryUsage):
(DOMWrapperMap):
- bindings/v8/DOMWrapperWorld.cpp:
(WebCore::::callback):
(WebCore::DOMWrapperWorld::makeContextWeak):
- bindings/v8/ScriptState.cpp:
(WebCore::::callback):
(WebCore::ScriptState::ScriptState):
- bindings/v8/ScriptState.h:
(ScriptState):
- bindings/v8/ScriptWrappable.h:
(ScriptWrappable):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::::callback):
- bindings/v8/V8AbstractEventListener.cpp:
(WebCore::::callback):
(WebCore::V8AbstractEventListener::setListenerObject):
- bindings/v8/V8AbstractEventListener.h:
(V8AbstractEventListener):
- bindings/v8/V8MutationCallback.cpp:
(WebCore::::callback):
(WebCore::V8MutationCallback::V8MutationCallback):
- bindings/v8/V8MutationCallback.h:
(V8MutationCallback):
- bindings/v8/V8NPObject.cpp:
(V8NPTemplateMap):
(WebCore::V8NPTemplateMap::set):
(WebCore::::callback):
(WebCore::staticNPObjectMap):
- bindings/v8/V8Utilities.h:
(WeakHandleListener):
(WebCore::WeakHandleListener::makeWeak):
(WebCore::WeakHandleListener::WeakHandleListener):
(WebCore::WeakHandleListener::invokeWeakCallback):
- bindings/v8/V8ValueCache.cpp:
(WebCore::::callback):
(WebCore::StringCache::v8ExternalStringSlow):
- bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::::callback):
(WebCore::createInjectedScriptHostV8Wrapper):
- 11:16 PM Changeset in webkit [147390] by
-
- 2 edits in trunk/Source/WebKit/chromium
2013-04-01 <webkit.review.bot@gmail.com>
[chromium] Roll chromium deps to 191760.
https://bugs.webkit.org/show_bug.cgi?id=113745
Unreviewed, rolling deps.
- DEPS:
- 11:16 PM Changeset in webkit [147389] by
-
- 3 edits in trunk/Source/WebCore
Hide non-coordinated scrollbars for Android M26
https://bugs.webkit.org/show_bug.cgi?id=113738
Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-04-01
Reviewed by Simon Fraser.
This patch will hide any non-coordinated scrollbars on Android.
Coordinated scrollbars won't be affected.
Currently all scrollbars are coordinated on Android. The sole purpose
of this patch is to be cherry-picked to the M26 branch.
No new tests. Please revert immediately after landed.
- platform/ScrollView.cpp:
(WebCore::positionScrollbarLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::positionOverflowControlsLayers):
- 11:15 PM Changeset in webkit [147388] by
-
- 7 edits2 adds in trunk
Crash in Node::enclosingBlockFlowElement()
https://bugs.webkit.org/show_bug.cgi?id=113712
Reviewed by Abhishek Arya.
Source/WebCore:
Fix a bad Node assumption if we walk up to the document root.
Test: editing/execCommand/format-block-at-root.html
- dom/Node.cpp:
(WebCore::Node::isBlockFlowElement): Check we found an Element Node and rename from isBlockFlow().
(WebCore::Node::enclosingBlockFlowElement): Use the new toElement().
- editing/FormatBlockCommand.cpp:
(WebCore::FormatBlockCommand::formatRange): Check for NULL.
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApplyForSingleParagraph):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::enclosingInline): Impact from method rename.
LayoutTests:
- editing/execCommand/format-block-at-root-expected.txt: Added.
- editing/execCommand/format-block-at-root.html: Added.
- 10:51 PM Changeset in webkit [147387] by
-
- 7 edits2 adds in trunk
[Resource Timing] Expose timing information for iframes
https://bugs.webkit.org/show_bug.cgi?id=103927
Reviewed by Nate Chapin.
Source/WebCore:
The only catch with main documents is that we only want to record the load that was initiated by
adding the <iframe> to a document. We don't want any subsequent navigations within the iframe to
be reported.
Test: http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_iframe_self_navigation.html
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::loadDone): Make sure iframes are reported in the parent.
LayoutTests:
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_frame_initiator_type.html: Fix timeout.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_iframe_self_navigation-expected.txt: Added.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_iframe_self_navigation.html: Added.
- http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_initiator_types-expected.txt: Remove bad line.
- platform/chromium/TestExpectations: Unskip tests that relied on iframes.
- 10:48 PM Changeset in webkit [147386] by
-
- 4 edits in trunk/Source
[BlackBerry] Move Path into it's own header
https://bugs.webkit.org/show_bug.cgi?id=113724
Patch by Konrad Piascik <kpiascik@blackberry.com> on 2013-04-01
Reviewed by Rob Buis.
Source/WebCore:
No behavioural change.
- platform/graphics/blackberry/PathBlackBerry.cpp:
Source/WebKit/blackberry:
- WebKitSupport/DefaultTapHighlight.cpp:
- 10:43 PM Changeset in webkit [147385] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] canvas is not rendering correctly for www.html5-benchmark.com
https://bugs.webkit.org/show_bug.cgi?id=113716
Patch by Konrad Piascik <kpiascik@blackberry.com> on 2013-04-01
Reviewed by Rob Buis.
PR 317205
Internally reivewed by: Mike Lattanzio, Jacky Jiang
This is a site issue where they detect physical pixels by multiplying
availWidth * devicePixelRatio. This gives us an invalid result since
we don't round the CSS pixels that are reported to availWidth and availHeight.
- platform/blackberry/PlatformScreenBlackBerry.cpp:
(WebCore::toUserSpace):
- 10:39 PM Changeset in webkit [147384] by
-
- 12 edits2 adds in trunk
[CSS Exclusions] shape-outside on floats fails to respect shape-margin's vertical extent
https://bugs.webkit.org/show_bug.cgi?id=113600
Reviewed by Dirk Schulze.
Source/WebCore:
ExclusionShapeInsideInfo classes need to depend on the ExclusionShape's padded boundary and
ExclusionShapeOutsideInfo classes should depend on the ExclusionShape's margin boundary. Added
a virtual method to the ExclusionShapeInfo that returns the ExclusionShape's logical bounding box -
computedShapeLogicalBoundingBox() - and overrode that method in the subclasses to return the
value of the appropriate ExclusionShape method. Added shapeMarginLogicalBoundingBox() and
shapePaddingLogicalBoundingBox() methods to ExclusionShape and removed the shapeLogicalBoundingBox()
method, which did not take shape-margin or shape-padding into account.
Test: fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-bottom.html
- rendering/ExclusionPolygon.h: Defined the padding and margin bounding box virtual methods.
- rendering/ExclusionRectangle.h: Defined the padding and margin bounding box virtual methods.
- rendering/ExclusionShape.h: Added the padding and margin bounding box virtual abstract methods. Removed shapeLogicalBoundingBox().
(ExclusionShape):
- rendering/ExclusionShapeInfo.h:
(WebCore::ExclusionShapeInfo::shapeLogicalTop): Now calls computedShapeLogicalBoundingBox().
(WebCore::ExclusionShapeInfo::shapeLogicalBottom): Ditto.
(WebCore::ExclusionShapeInfo::shapeLogicalLeft): Ditto.
(WebCore::ExclusionShapeInfo::shapeLogicalRight): Ditto.
(WebCore::ExclusionShapeInfo::shapeLogicalWidth): Ditto.
(WebCore::ExclusionShapeInfo::shapeLogicalHeight): Ditto.
(ExclusionShapeInfo): Added computedShapeLogicalBoundingBox().
- rendering/ExclusionShapeInsideInfo.h:
(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::computedShapeLogicalBoundingBox): Gets the padded shape's bounding box.
- rendering/ExclusionShapeOutsideInfo.h:
(ExclusionShapeOutsideInfo):
(WebCore::ExclusionShapeOutsideInfo::computedShapeLogicalBoundingBox): Gets the margin shape's bounding box.
LayoutTests:
Corrected the expected values in the ellipse-margin-left and ellipse-margin-right tests because the
shape-outside float layout code now (correctly) takes into account the shape's margin boundary.
- fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-bottom-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-bottom.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left-expected.txt:
- fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html:
- fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right-expected.txt:
- fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html:
- 10:34 PM Changeset in webkit [147383] by
-
- 6 edits in trunk
Assertion failure !m_lastChunkBeforeScript in HTMLDocumentParser during inspector/debugger/pause-in-inline-script.html
https://bugs.webkit.org/show_bug.cgi?id=112369
Reviewed by Eric Seidel.
Source/WebCore:
The threaded HTML parser wasn't correctly handling the nested event
loops that can arise from the JavaScript debugger and from
showModalDialog. When the parser received a chunk from the background
parser, it was always processing it immediately, which lead to
re-entrancy. Now, we'll queue the chunk in the speculation buffer and
process it once the stack unwinds.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::~HTMLDocumentParser):
(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore::HTMLDocumentParser::insert):
- html/parser/HTMLParserScheduler.cpp:
(WebCore::PumpSession::PumpSession):
- html/parser/HTMLParserScheduler.h:
LayoutTests:
Unskip test that is now passing.
- platform/chromium/TestExpectations:
- 10:31 PM Changeset in webkit [147382] by
-
- 4 edits in trunk
[JSC] IndexedDB: Exceptions not thrown for non-cloneable values
https://bugs.webkit.org/show_bug.cgi?id=113689
Patch by Michael Pruett <michael@68k.org> on 2013-04-01
Reviewed by Kentaro Hara.
Source/WebCore:
ScriptValue::serialize() should not clear exceptions thrown during
serialization. This change is needed to match behavior in V8.
Tests: storage/indexeddb/clone-exception.html
storage/indexeddb/exceptions.html
storage/indexeddb/structured-clone.html
- bindings/js/ScriptValue.cpp:
(WebCore::ScriptValue::serialize):
LayoutTests:
- platform/gtk/TestExpectations:
- 10:29 PM Changeset in webkit [147381] by
-
- 2 edits in trunk/Source/WebCore
[Chromium] IndexedDB: Turn "should only be true in unit tests" comments into ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=113597
Reviewed by Adam Barth.
In the vein of wkbug.com/111233 and wkbug.com/110820 don't just comment that
some condition is true only in unit tests - ASSERT that Chromium's unitTestSupport()
is non-null to catch errors during development.
Exercised by Chromium's webkit_unit_tests.
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::close):
- 10:06 PM Changeset in webkit [147380] by
-
- 198 edits5 adds3 deletes in trunk/LayoutTests
Unreviewed, rolling out r147347.
http://trac.webkit.org/changeset/147347
broke Chromium Linux test
The same reason as the previous rollout.
- platform/chromium-linux-x86/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/border-image-scale-transform-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/border-image-scaled-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/scaled-border-image-expected.png: Added.
- platform/chromium-linux/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
- platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
- platform/chromium-linux/fast/borders/scaled-border-image-expected.png:
- platform/chromium-linux/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Removed.
- platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-lion/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-mac-lion/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-mac-lion/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-mac-lion/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-mac-lion/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac-lion/fast/borders/border-image-scaled-expected.png:
- platform/chromium-mac-lion/fast/borders/scaled-border-image-expected.png:
- platform/chromium-mac-lion/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-mac-lion/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-lion/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-mac-snowleopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png:
- platform/chromium-mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-mac/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize02-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize04-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize13-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize14-expected.png:
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
- platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
- platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
- platform/chromium-mac/fast/borders/scaled-border-image-expected.png:
- platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
- platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
- platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-win/fast/borders/border-image-scaled-expected.png:
- platform/chromium-win/fast/borders/border-image-side-reduction-expected.png:
- platform/chromium-win/fast/borders/scaled-border-image-expected.png:
- platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Removed.
- platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium/TestExpectations:
- 9:54 PM Changeset in webkit [147379] by
-
- 5 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support some more integer arithmetic ops (negate, xor, urshift)
https://bugs.webkit.org/show_bug.cgi?id=113740
Reviewed by Geoffrey Garen.
- ftl/FTLAbbreviations.h:
(JSC::FTL::buildNeg):
(JSC::FTL::buildLShr):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileBitXor):
(JSC::FTL::LowerDFGToLLVM::compileBitURShift):
(JSC::FTL::LowerDFGToLLVM::compileUInt32ToNumber):
- ftl/FTLOutput.h:
(JSC::FTL::Output::neg):
(JSC::FTL::Output::lShr):
- 9:46 PM Changeset in webkit [147378] by
-
- 381 edits in trunk/LayoutTests
Unreviewed, rolling out r147351.
http://trac.webkit.org/changeset/147351
broke Chromium Linux test
The same reason as the previous rollout.
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-mac-lion/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-mac-lion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-mac-lion/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-mac-lion/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-mac/svg/as-image/image-preserveAspectRatio-all-expected.png:
- platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac/svg/filters/feImage-preserveAspectRatio-all-expected.png:
- platform/chromium-mac/svg/filters/feImage-preserveAspectratio-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
- platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-win/svg/as-image/image-preserveAspectRatio-all-expected.png:
- platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-win/svg/filters/feImage-preserveAspectRatio-all-expected.png:
- platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
- platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- 9:28 PM Changeset in webkit [147377] by
-
- 9 edits1 move1 delete in trunk/LayoutTests
Unreviewed, rolling out r147358.
http://trac.webkit.org/changeset/147358
broke Chromium Linux test
In the flakiness dashboard, this rebaseline looks good, however actually it broke Chromium Linux Test bots.
Maybe something bad is happening, but let me revert them again.
- platform/chromium-linux/css3/images/cross-fade-background-size-expected.png: Removed.
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium/css3/images/cross-fade-background-size-expected.png: Renamed from LayoutTests/platform/chromium-win/css3/images/cross-fade-background-size-expected.png.
- 8:02 PM Changeset in webkit [147376] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
- platform/chromium/TestExpectations:
- 7:22 PM Changeset in webkit [147375] by
-
- 3 edits1 add in trunk
VS2010 WebCoreGenerated build scripts should use new feature-defines script.
Update FEATURE_DEFINES string generation for VS2010 solution.
https://bugs.webkit.org/show_bug.cgi?id=113737.
Reviewed by Timothy Horton.
- WebCore.vcxproj/build-generated-files.sh:
- win/tools/scripts/feature-defines2010.sh: Added.
- 6:23 PM Changeset in webkit [147374] by
-
- 7 edits1 copy1 move1 add1 delete in trunk/LayoutTests
Test rebaselines after r147245.
- fast/table/overflowHidden-expected.txt:
- platform/chromium-mac/fast/table/overflowHidden-expected.txt: Removed.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/gtk/fast/table/overflowHidden-expected.txt: Copied from LayoutTests/fast/table/overflowHidden-expected.txt.
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win-7sp0/fast/table/overflowHidden-expected.txt: Renamed from LayoutTests/platform/win/fast/table/overflowHidden-expected.txt.
- 5:26 PM Changeset in webkit [147373] by
-
- 2 edits in trunk/Source/WebCore
Autosize should use documentRect height instead of scrollHeight
https://bugs.webkit.org/show_bug.cgi?id=112770
Reviewed by David Levin.
Autosizing fails to compute the correct height if the root element is very
small but the document has significant overflow.
Also, unconditionally start laying out from the minimum height, so that the
documentRect can shrink below its previous height if needed.
No new tests; autosizing is not currently exposed in a testable way on Mac.
- page/FrameView.cpp:
(WebCore::FrameView::autoSizeIfEnabled):
- 5:10 PM Changeset in webkit [147372] by
-
- 2 edits in trunk/LayoutTests
Bot greening failed test from http://trac.webkit.org/changeset/147317.
The test should use testRunner, not layoutTestController.
Unreviewed.
- fast/text/emphasis-height-crash.html:
- 5:03 PM Changeset in webkit [147371] by
-
- 15 edits in trunk
[Shadow DOM] Change the order of event dispatching at AT_TARGET phase.
https://bugs.webkit.org/show_bug.cgi?id=113676
Reviewed by Dimitri Glazkov.
Source/WebCore:
Change the order of event dispatching at AT_TARGET phase so that it mimics bubbling events.
The spec side bug is:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=21404
Example:
Given the event path, from Node A (top-most) to Node G (target,
inner-most), where C and D are shadow hosts and G is the target,
the event dispatching order in the current WebKit implementation is:
(T: AT_TARGET, C: CAPTURING, B: BUBBLING)
For bubbling events:
A 1 (C) 11 (B)
B 2 (C) 10 (B)
C (SH) 3 (T)
D 4 (C) 9 (B)
E (SH) 5 (T)
F 6 (C) 8 (B)
G (Target) 7 (T)
For non-bubbling events:
A 1 (C)
B 2 (C)
C (SH) 3 (T)
D 4 (C)
E (SH) 5 (T)
F 6 (C)
G (Target) 7 (T)
This patch has changed the order of event dispatching as follows:
For bubbling events:
A 1 (C) 11 (B)
B 2 (C) 10 (B)
C (SH) 9 (T)
D 3 (C) 8 (B)
E (SH) 7 (T)
F 4 (C) 6 (B)
G (Target) 5 (T)
For non-bubbling events:
A 1 (C)
B 2 (C)
C (SH) 7 (T)
D 3 (C)
E (SH) 6 (T)
F 4 (C)
G (Target) 5 (T)
No new tests, updating existing layouts.
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtBubbling):
- dom/EventDispatcher.h:
(EventDispatcher):
LayoutTests:
- fast/dom/shadow/cppevent-in-shadow-expected.txt:
- fast/dom/shadow/cppevent-input-in-shadow-expected.txt:
- fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt:
- fast/dom/shadow/gesture-tap-expected.txt:
- fast/dom/shadow/shadow-boundary-events-expected.txt:
- fast/dom/shadow/shadow-boundary-events.html:
- fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt:
- fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes-expected.txt:
- fast/dom/shadow/shadow-dom-event-dispatching-non-distributed-nodes-expected.txt:
- fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt:
- fast/dom/shadow/shadow-root-blur-expected.txt:
- 5:00 PM Changeset in webkit [147370] by
-
- 2 edits in trunk/Source/WebCore
Crash in WebCore::HTMLMediaElement::~HTMLMediaElement.
https://bugs.webkit.org/show_bug.cgi?id=113531
Reviewed by Adam Barth.
No new tests, though this is intermittently reproducible with
http/tests/misc/delete-frame-during-readystatechange.html under ASAN.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement): Clear the media player manually
before the destructor exits. Clearing the media player may cancel a resource load,
which can trigger a readystatechange event. It's possible for the HTMLMediaElement
to attempt to fire an abort event within the readystatechange event, even though it is
now in an inconsistent state. Clearling the media player before finishing the destructor
ensures that the HTMLMediaElement will at least still be alive if this case is triggered.
Set m_completelyLoaded to true to ensure that if userCancelledLoad() is called, it doesn't
attempt to fire events while destructing.
- 4:35 PM Changeset in webkit [147369] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r146373.
http://trac.webkit.org/changeset/146373
https://bugs.webkit.org/show_bug.cgi?id=113731
broke autosizing shrinking past previous size (Requested by
thorton on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-01
- page/FrameView.cpp:
(WebCore::FrameView::autoSizeIfEnabled):
- 4:19 PM Changeset in webkit [147368] by
-
- 6 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support GetGlobalVar/PutGlobalVar
https://bugs.webkit.org/show_bug.cgi?id=113728
Reviewed by Gavin Barraclough.
Removed the macro magic for the globals absolute abstract heap, since for anything
with absolute addresses we can just share a common absolute abstract heap. It
would only be a problem if we for example were emitting an access to a global but
not using an absolute address, and then wanted to say that this access was
constrained to global variables. I don't believe we do that, and I don't believe we
ever will.
Then added Output::absolute(), a convenient way of building a typed pointer for an
absolute address.
Then added GetGlobalVar/PutGlobalVar.
- ftl/FTLAbstractHeapRepository.cpp:
(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):
- ftl/FTLAbstractHeapRepository.h:
(FTL):
(AbstractHeapRepository):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetGlobalVar):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compilePutGlobalVar):
- ftl/FTLOutput.h:
(JSC::FTL::Output::absolute):
(Output):
- 3:41 PM Changeset in webkit [147367] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, chromium expectations update after r147357.
- platform/chromium/TestExpectations:
- 3:02 PM Changeset in webkit [147366] by
-
- 2 edits in branches/chromium/1453/Source/WebKit/chromium
Merge 147181 "[chromium] Use widget.parent() for plugin WebMouse..."
[chromium] Use widget.parent() for plugin WebMouseEvents
https://bugs.webkit.org/show_bug.cgi?id=113543
Reviewed by James Robinson.
In r142571 I switches widget.parent() to widget.root() in the plugin
WebCore event -> WebMouseEvent creator, to make the converter the
inverse of the one going the other way and avoid null pointer crashes.
But the plugin code expects it to be parent() (see
http://crbug.com/223335).
- src/WebInputEventConversion.cpp:
(WebKit::updateWebMouseEventFromWebCoreMouseEvent):
TBR=aelias@chromium.org
Review URL: https://codereview.chromium.org/13190018
- 2:46 PM Changeset in webkit [147365] by
-
- 2 edits2 adds in trunk/LayoutTests
Unreviewed. AppleWin port gardening.
- platform/win/TestExpectations:
- platform/win/fast/table: Added.
- platform/win/fast/table/overflowHidden-expected.txt: Added.
- 2:36 PM Changeset in webkit [147364] by
-
- 1 edit in branches/chromium/1410/Source/WebCore/rendering/RenderTableCell.cpp
Merge 145822 "REGRESSION(r145305) Performance: 1.3% mac-release-..."
REGRESSION(r145305) Performance: 1.3% mac-release-10.6-webkit-latest/intl2/times/t change after rev 145300
https://bugs.webkit.org/show_bug.cgi?id=112125
Reviewed by Julien Chaffraix.
When detecting cases where a loaded image may need to move up into the padding created by the row's baseline
we don't need to do anything if the row doesn't have a baseline yet.
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::layout):
TBR=jchaffraix@webkit.org
Review URL: https://codereview.chromium.org/13393017
- 2:33 PM Changeset in webkit [147363] by
-
- 2 edits in trunk/Source/WebKit/mac
WebCache should do the normal initialization dance
https://bugs.webkit.org/show_bug.cgi?id=113722
<rdar://problem/13424530>
Reviewed by Anders Carlsson.
In case a WebKit1 client uses WebCache before creating a WebView (or any of the other
initialization-ready classes), we should do the initialization work in WebCache as well.
- Misc/WebCache.mm:
(+[WebCache initialize]):
- 2:32 PM Changeset in webkit [147362] by
-
- 5 edits in trunk/Source
Allow changing Web Inspector dock sides without undocking first.
https://webkit.org/b/113661
rdar://problem/13543127
Reviewed by Joseph Pecoraro.
Source/WebCore:
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): Initialize m_dockSide.
(WebCore::InspectorFrontendClientLocal::canAttachWindow): If we are already attached, allow
attaching again to allow switching sides.
(WebCore::InspectorFrontendClientLocal::setAttachedWindow): Set m_dockSide.
- inspector/InspectorFrontendClientLocal.h:
(InspectorFrontendClientLocal): Added m_dockSide.
Source/WebKit2:
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::createInspectorPage): Send AttachedBottom and
AttachedRight messages so InspectorFrontendClientLocal knows which side we
are attached.
(WebKit::WebInspectorProxy::canAttach): If we are already attached, allow
attaching again to allow switching sides.
- 2:27 PM Changeset in webkit [147361] by
-
- 2 edits in trunk/Source/WebKit2
Nor this! (Who reviewed this anyway!)
- WebProcess/Storage/StorageNamespaceProxy.cpp:
(WebKit::StorageNamespaceProxy::storageArea):
- 2:19 PM Changeset in webkit [147360] by
-
- 2 edits in trunk/Source/WebKit2
Didn't mean to commit this!
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
- 2:12 PM Changeset in webkit [147359] by
-
- 5 edits in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=113721
<rdar://problem/13549181> REGRESSION (r146929): HTTP auth credentials not reused during session
Reviewed by Brady Eidson.
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::shouldUseCredentialStorage): Added an override that we still need. It's not great, but causes no trouble for NetworkProcess. (WebKit::NetworkResourceLoader::shouldUseCredentialStorageAsync): Implement in terms of sync version to avoid duplicating logic.
- 1:56 PM Changeset in webkit [147358] by
-
- 9 edits2 adds1 delete in trunk/LayoutTests
Unreviewed, chromium gardening.
- platform/chromium-linux/css3/images/cross-fade-background-size-expected.png: Added.
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-win/css3/images/cross-fade-background-size-expected.png: Added.
- platform/chromium/css3/images/cross-fade-background-size-expected.png: Removed.
- 1:48 PM Changeset in webkit [147357] by
-
- 17 edits in trunk
[chromium] Delete code behind if (!applyXYZScaleInCompositor)
https://bugs.webkit.org/show_bug.cgi?id=111809
Reviewed by James Robinson.
Chromium is setting the flags applyPageScaleFactorInCompositor and
applyDeviceScaleFactorInCompositor permanently to true, so any code
in platform/chromium with the false setting is dead. Delete all of
it.
I also switched FrameTestHelpers and DumpRenderTree to always turn the
setting to true so that they test the code we're actually running.
This exposed a number of failing tests which I added in the
expectations file.
Note also that I made calls to setPageScaleFactor turn on
force-compositing-mode to make the layout tests work, as
pageScaleFactor is now ignored in non-composited mode.
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
- src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
- src/PageWidgetDelegate.cpp:
(WebKit::PageWidgetDelegate::paint):
- src/PageWidgetDelegate.h:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::selectRange):
(WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):
- src/WebPagePopupImpl.cpp:
(WebKit::WebPagePopupImpl::paint):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
(WebKit::WebViewImpl::scaledSize):
(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::selectionBounds):
(WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode):
(WebKit::WebViewImpl::clampOffsetAtScale):
(WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset):
(WebKit::WebViewImpl::setDeviceScaleFactor):
(WebKit::WebViewImpl::contentsSize):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::applyScrollAndScale):
- src/WebViewImpl.h:
- tests/FrameTestHelpers.cpp:
(WebKit::FrameTestHelpers::createWebView):
- tests/WebFrameTest.cpp:
- tests/WebInputEventConversionTest.cpp:
(WebCore::TEST):
- 1:33 PM Changeset in webkit [147356] by
-
- 4 edits in trunk
Make 'this' evaluate to the correct object when paused in the Debugger.
https://webkit.org/b/113607
rdar://problem/13538351
Reviewed by Joseph Pecoraro.
Source/WebCore:
- inspector/InjectedScriptSource.js:
(InjectedScript.prototype._evaluateOn): Bind 'this' to the expression function.
LayoutTests:
- platform/mac/http/tests/inspector/console-resource-errors-expected.txt:
- 1:10 PM Changeset in webkit [147355] by
-
- 6 edits2 adds in trunk
TextTrackCue Extension for WebVTT Regions
https://bugs.webkit.org/show_bug.cgi?id=109821
Reviewed by Eric Carlson.
Source/WebCore:
The TextTrackCue gets a new attribute and setting, regionId, which specifies
to which region the cue belongs to. The attribute is guarded by WEBVTT_REGIONS
and is by default disabled in ports.
Test: media/track/regions-webvtt/text-track-cue-region-attribute.html
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::TextTrackCue): Added member variable for the regionId attribute.
(WebCore):
(WebCore::TextTrackCue::setRegionId): Setter for the regionId attribute.
(WebCore::TextTrackCue::settingName): Added RegionId setting name.
(WebCore::TextTrackCue::setCueSettings): Parsed the "region:" cue setting.
- html/track/TextTrackCue.h:
(TextTrackCue):
(WebCore::TextTrackCue::regionId): Getter for the regionId attribute.
- html/track/TextTrackCue.idl: Updated to match the WebVTT Regions Extension.
LayoutTests:
- media/track/captions-webvtt/header-regions.vtt: Updated to include cues with
settings for which the "region:" setting should be ignored (for backwards compatibility
regarding WebVTT rendering rules).
- media/track/regions-webvtt/text-track-cue-region-attribute-expected.txt: Added.
- media/track/regions-webvtt/text-track-cue-region-attribute.html: Added.
- 1:05 PM Changeset in webkit [147354] by
-
- 10 edits in trunk/Source
Apply changes from storage events locally
https://bugs.webkit.org/show_bug.cgi?id=111502
Reviewed by Sam Weinig.
Source/WebCore:
Add and export a helper function for setting an item without taking
into account the quota for the map. Also, reindent StorageMap.h
- WebCore.exp.in:
- storage/StorageMap.cpp:
(WebCore::StorageMap::setItemIgnoringQuota):
(WebCore):
- storage/StorageMap.h:
(StorageMap):
(WebCore::StorageMap::quota):
Source/WebKit2:
- WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::StorageAreaProxy):
Store the security origin as a member variable.
(WebKit::StorageAreaProxy::dispatchStorageEvent):
Set the item and call the appropriate event dispatch function.
(WebKit::StorageAreaProxy::dispatchSessionStorageEvent):
(WebKit::StorageAreaProxy::dispatchLocalStorageEvent):
Add stubs.
- WebProcess/Storage/StorageAreaProxy.h:
- 1:01 PM Changeset in webkit [147353] by
-
- 2 edits in trunk/Source/WebCore
Remove a couple of malloc from ExceptionBase construction
https://bugs.webkit.org/show_bug.cgi?id=113681
Reviewed by Darin Adler.
- dom/ExceptionBase.cpp:
(WebCore::ExceptionBase::ExceptionBase):
When the condition is true, we were creating a new String for
description.name. The constructor had already allocated a string for
that: m_name. Use that string instead of creating a new one.
When the condition is false, we were creating a String for typeName
just to use the string operators. This is a waste of time, we can use
makeString() to invoke the string concatenation functions directly.
- 12:59 PM Changeset in webkit [147352] by
-
- 2 edits in tags/Safari-537.35.5/Source/WebCore
Merged r147287. <rdar://problem/13541868>
- 12:52 PM Changeset in webkit [147351] by
-
- 381 edits2 deletes in trunk/LayoutTests
Unreviewed, chromium gardening.
- platform/chromium-linux-x86/svg/dynamic-updates: Removed.
- platform/chromium-linux-x86/tables/mozilla/marvin: Removed.
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-mac-lion/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-mac-lion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-mac-lion/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-mac-lion/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-mac/svg/as-image/image-preserveAspectRatio-all-expected.png:
- platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac/svg/filters/feImage-preserveAspectRatio-all-expected.png:
- platform/chromium-mac/svg/filters/feImage-preserveAspectratio-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
- platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-win/svg/as-image/image-preserveAspectRatio-all-expected.png:
- platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-win/svg/filters/feImage-preserveAspectRatio-all-expected.png:
- platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
- platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- 12:49 PM Changeset in webkit [147350] by
-
- 4 edits in trunk/Source/WebCore
Move remaining marquee applying code to StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=113298
Reviewed by Allan Sandfeld Jensen.
Move applying logic for CSSPropertyWebkitMarqueeIncrement,
CSSPropertyWebkitMarqueeRepetition and CSSPropertyWebkitMarqueeSpeed
from StyleResolver::applyProperty.
No new tests, no change in functionality.
- css/StyleBuilder.cpp:
(ApplyPropertyMarqueeIncrement):
(WebCore::ApplyPropertyMarqueeIncrement::applyValue):
(WebCore::ApplyPropertyMarqueeIncrement::createHandler):
(WebCore):
(ApplyPropertyMarqueeRepetition):
(WebCore::ApplyPropertyMarqueeRepetition::applyValue):
(WebCore::ApplyPropertyMarqueeRepetition::createHandler):
(ApplyPropertyMarqueeSpeed):
(WebCore::ApplyPropertyMarqueeSpeed::applyValue):
(WebCore::ApplyPropertyMarqueeSpeed::createHandler):
(WebCore::StyleBuilder::StyleBuilder):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
Move marquee applying logic from StyleResolver to StyleBuilder.
- rendering/style/RenderStyle.h:
Change setMarqueeIncrement to pass Length by value instead of const
reference. This is consistent with other length setters and works with
the ApplyPropertyLength template.
- 12:39 PM Changeset in webkit [147349] by
-
- 5 edits in trunk/Source/JavaScriptCore
Use Vector::reserveInitialCapacity and Vector::uncheckedAppend for JSC's APIs
https://bugs.webkit.org/show_bug.cgi?id=113651
Reviewed by Andreas Kling.
This removes a bunch of branches on initialization and when
filling the vector.
- API/JSCallbackConstructor.cpp:
(JSC::constructJSCallback):
- API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::call):
- API/JSCallbackObjectFunctions.h:
(JSC::::construct):
(JSC::::call):
- API/JSObjectRef.cpp:
(JSObjectCopyPropertyNames):
- 11:55 AM Changeset in webkit [147348] by
-
- 19 edits6 adds in trunk
[SVG2] Add support for the buffered-rendering hint
https://bugs.webkit.org/show_bug.cgi?id=104207
Reviewed by Stephen Chenney.
Source/WebCore:
This patch adds the SVG2 buffered-rendering property and implements it for the image
element. For reference, the spec can be found at:
https://svgwg.org/svg2-draft/single-page.html#painting-BufferedRendering
The buffered-rendering hint causes our implementation to create a temporary image buffer
for caching an element's foreground rendering. This behavior has been designed to support
other graphical and container elements in followup patches (such as the use and g elements).
This patch should not affect rendering, and a test has been added showing the image
results are unchanged.
The performance aspects of this patch can be tested using the following test:
Without the patch, rendering is below 1fps. With the patch, rendering is fluid.
Tests: svg/css/buffered-rendering.html
svg/repaint/buffered-rendering-dynamic-image.html
svg/repaint/buffered-rendering-static-image.html
Other than the changes to RenderSVGImage and SVGRenderingContext, the changes below are to
support the new buffered-rendering property:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore):
(WebCore::CSSPrimitiveValue::operator EBufferedRendering):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
- css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
- css/SVGCSSPropertyNames.in:
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/SVGCSSValueKeywords.in:
- rendering/style/SVGRenderStyle.cpp:
(WebCore::SVGRenderStyle::diff):
- rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::initialBufferedRendering):
(WebCore::SVGRenderStyle::setBufferedRendering):
(WebCore::SVGRenderStyle::bufferedRendering):
(WebCore::SVGRenderStyle::setBitDefaults):
- rendering/style/SVGRenderStyleDefs.h:
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
The foreground painting has been extracted out into a separate function. This has also
been changed so that if the buffered-rendering hint is present, bufferForeground
is used.
(WebCore::RenderSVGImage::paintForeground):
(WebCore):
(WebCore::RenderSVGImage::invalidateBufferedForeground):
This function could be replaced with "m_bufferedForeground.clear()" but other renderers
(such as container elements) will require more complex invalidation logic. To
maintain consistency with this future code, invalidateBufferedForeground has been used.
(WebCore::RenderSVGImage::imageChanged):
- rendering/svg/RenderSVGImage.h:
(RenderSVGImage):
- rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::bufferForeground):
(WebCore):
- rendering/svg/SVGRenderingContext.h:
(SVGRenderingContext):
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
(WebCore::cssPropertyToTypeMap):
- svg/svgattrs.in:
LayoutTests:
- svg/css/buffered-rendering-expected.txt: Added.
- svg/css/buffered-rendering.html: Added.
- svg/repaint/buffered-rendering-dynamic-image-expected.html: Added.
- svg/repaint/buffered-rendering-dynamic-image.html: Added.
- svg/repaint/buffered-rendering-static-image-expected.html: Added.
- svg/repaint/buffered-rendering-static-image.html: Added.
- 11:39 AM Changeset in webkit [147347] by
-
- 198 edits3 adds4 deletes in trunk/LayoutTests
Unreviewed, chromium gardening.
- platform/chromium-linux-x86/fast/backgrounds/repeat: Removed.
- platform/chromium-linux-x86/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Removed.
- platform/chromium-linux-x86/fast/borders/border-image-scale-transform-expected.png: Removed.
- platform/chromium-linux-x86/fast/borders/border-image-scaled-expected.png: Removed.
- platform/chromium-linux-x86/fast/borders/scaled-border-image-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
- platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
- platform/chromium-linux/fast/borders/scaled-border-image-expected.png:
- platform/chromium-linux/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
- platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-lion/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-mac-lion/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-mac-lion/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-mac-lion/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-mac-lion/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac-lion/fast/borders/border-image-scaled-expected.png:
- platform/chromium-mac-lion/fast/borders/scaled-border-image-expected.png:
- platform/chromium-mac-lion/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-mac-lion/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-lion/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-mac-snowleopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png:
- platform/chromium-mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-mac/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize02-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize04-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize13-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize14-expected.png:
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
- platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
- platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
- platform/chromium-mac/fast/borders/scaled-border-image-expected.png:
- platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
- platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
- platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-win/fast/borders/border-image-scaled-expected.png:
- platform/chromium-win/fast/borders/border-image-side-reduction-expected.png:
- platform/chromium-win/fast/borders/scaled-border-image-expected.png:
- platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
- platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium/TestExpectations:
- 11:24 AM Changeset in webkit [147346] by
-
- 14 edits in trunk
CSP 1.1: Remove 'type' parameter from CSPDirectiveList::checkSourceAndReportViolation.
https://bugs.webkit.org/show_bug.cgi?id=113502
Reviewed by Adam Barth.
Source/WebCore:
Now that we're passing in 'effectiveDirective', we don't need the 'type'
parameter to generate the proper error message prefix when reporting
violations.
While I'm here, I'll slightly tweak the grammar for the error messages.
Changes are covered via rebaselines of existing tests.
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
Drop the 'type' parameter. We don't need to pass in a type since
we're now passing in the 'effectiveDirective'; we can use the latter
to generate the correct error message prefix.
(WebCore::CSPDirectiveList::allowScriptFromSource):
(WebCore::CSPDirectiveList::allowObjectFromSource):
(WebCore::CSPDirectiveList::allowChildFrameFromSource):
(WebCore::CSPDirectiveList::allowImageFromSource):
(WebCore::CSPDirectiveList::allowStyleFromSource):
(WebCore::CSPDirectiveList::allowFontFromSource):
(WebCore::CSPDirectiveList::allowMediaFromSource):
(WebCore::CSPDirectiveList::allowConnectToSource):
(WebCore::CSPDirectiveList::allowFormAction):
(WebCore::CSPDirectiveList::allowBaseURI):
Drop the 'type' parameter from the callsites, which has the lovely
property of allowing us to throw away a bunch of statically allocated
strings that we don't need anymore.
LayoutTests:
- http/tests/security/contentSecurityPolicy/frame-src-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/frame-src-redirect-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/media-src-track-block-expected.txt:
- http/tests/security/contentSecurityPolicy/object-src-no-url-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/object-src-none-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/object-src-url-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/style-blocked-expected.txt:
- media/csp-blocks-video-expected.txt:
- platform/chromium/http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
- platform/chromium/media/csp-blocks-video-expected.txt:
- 11:24 AM Changeset in webkit [147345] by
-
- 2 edits in trunk/Source/WTF
Move definition of nested classes that inherit enclosing class outside class definition.
https://bugs.webkit.org/show_bug.cgi?id=113454
Patch by Han Shen <shenhan@google.com> on 2013-04-01
Reviewed by Benjamin Poulain.
HashMap.h does not build on GCC 4.8. Inside this file,
HashMapKeysProxy and HashMapValuesProxy are defined as nested
class inside HashMap - which is legal - the illegal part is that
these 2 classes inherit HashMap, that is the enclosing class, that
causes "reference to in-complete definition" error.
The fix is to move outside the definition of these 2 classes, and
leave only declaration part inside HashMap as is illustrated below -
template class <typename T>
class HashMap {
... ...
... ...
private:
class HashMapKeysProxy;
ERROR - nested class inherits enclosing class.
class HashMapKeysProxy : private HashMap {
... ...
};
... ...
... ...
class HashMapKeysProxy : private HashMap {
... ...
};
... ...
... ...
};
Fixed as below:
template class <typename T>
class HashMap {
... ...
... ...
private:
class HashMapKeysProxy;
class HashMapValuesProxy;
... ...
... ...
};
template <typename T>
class HashMap<T>::HashMapKeysProxy : private HashMap<T> {
... ...
};
template <typename T>
class HashMap<T>::HashMapValuesProxy : private HashMap<T> {
... ...
};
- wtf/HashMap.h:
(HashMap):
(WTF): Factor out nested class definition from enclosing class.
- 11:06 AM Changeset in webkit [147344] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13490123> Sandbox extension tracking is incorrect when restoring a session
https://bugs.webkit.org/show_bug.cgi?id=113709
Reviewed by Anders Carlsson.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad): Added an assertion to catch extension tracking logic errors that could result in giving an extension to non-local pages. (WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad): Just like below, clearing m_pendingProvisionalSandboxExtension appears incorrect, even though I am not aware of any scenarios where this happens in practice. (WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad): The load may be failing exactly because a new one cancels it, so we shouldn't be preventing the new one from using its extension.
- 11:05 AM Changeset in webkit [147343] by
-
- 12 edits in trunk
AX: "video element controller" is an overly verbose default description for the playback controls; how about just "playback"
https://bugs.webkit.org/show_bug.cgi?id=113549
Patch by James Craig <james@cookiecrook.com> on 2013-04-01
Reviewed by Chris Fleizach.
Source/WebCore:
Existing test coverage.
Updating the video/audio element's default accessibility labels to be less verbose.
Also cleaned up some erroneous comments related to the sub-level controls on these elements.
- English.lproj/Localizable.strings:
- platform/LocalizedStrings.cpp:
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::localizedMediaControlElementString):
Source/WebCore/platform/gtk/po:
Existing test coverage.
Updating the video/audio element's default accessibility labels to be less verbose.
- en_CA.po:
- en_GB.po:
LayoutTests:
Updating the video/audio element's default accessibility labels to be less verbose.
- platform/gtk/accessibility/media-controls-panel-title-expected.txt:
- platform/gtk/accessibility/media-controls-panel-title.html:
- platform/gtk/accessibility/media-element-expected.txt:
- platform/mac/accessibility/media-element-expected.txt:
- 11:05 AM Changeset in webkit [147342] by
-
- 2 edits in trunk/Source/WebKit2
SharedMemory release build hardening.
<rdar://problem/13546860> and https://bugs.webkit.org/show_bug.cgi?id=113710
Reviewed by Anders Carlsson.
Successful creation of a memory entry with a size less than the size we requested should be treated
as a failure to create the SharedMemory object.
- Platform/mac/SharedMemoryMac.cpp:
(WebKit::SharedMemory::createFromVMBuffer): Early return if the port we get is bogus for our needs.
(WebKit::SharedMemory::createHandle): Ditto.
(WebKit::SharedMemory::create): Guarantee we pass valid input in to mach_vm_map.
- 11:00 AM Changeset in webkit [147341] by
-
- 1 edit2 deletes in branches/chromium/1410
Revert 140817 "Web Inspector: [Styles] Editing a property value ..."
BUG=225346
Web Inspector: [Styles] Editing a property value containing a trimmed data: URL breaks the style
https://bugs.webkit.org/show_bug.cgi?id=107936
Reviewed by Yury Semikhatsky.
Source/WebCore:
Restore the original CSS property value before editing.
Test: inspector/styles/edit-value-with-trimmed-url.html
- inspector/front-end/StylesSidebarPane.js:
LayoutTests:
- inspector/styles/edit-value-with-trimmed-url-expected.txt: Added.
- inspector/styles/edit-value-with-trimmed-url.html: Added.
TBR=apavlov@chromium.org
Review URL: https://codereview.chromium.org/13084008
- 10:57 AM Changeset in webkit [147340] by
-
- 4 edits in tags/Safari-537.35.5/Source
Versioning.
- 10:50 AM Changeset in webkit [147339] by
-
- 1 copy in tags/Safari-537.35.5
New Tag.
- 10:03 AM Changeset in webkit [147338] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r147319.
http://trac.webkit.org/changeset/147319
https://bugs.webkit.org/show_bug.cgi?id=113707
The unit test is still failing on the buildbot (Requested by
zdobersek on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-01
- Scripts/run-gtk-tests:
(TestRunner):
- 10:00 AM Changeset in webkit [147337] by
-
- 7 edits5 adds in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support ArithSub
https://bugs.webkit.org/show_bug.cgi?id=113675
Reviewed by Oliver Hunt.
This does the obvious bit of implementing ArithSub, but it also takes this
as an opportunity to clean up how intrinsics and common values (common types
and constants) are handled. Previously they were all lumped together in
FTL::Output. Now, in an effort to split up the files and make FTL::Output
less big, I created a thing called FTL::CommonValues which just tracks the
common values, and a thing called FTL::IntrinsicRepository which just tracks
intrinsics. These and FTL::Output are all related to each other in a linear
hierarchy. Moreover, IntrinsicRepository uses macro-fu to make it easy to
declare new intrinsics in the future.
I also out-of-lined some things and made .cpp files for each of these classes.
Initialize I wasn't going to do this but then I realized that FTL::Output is
already included in multiple places. Probably it's better if some of its guts
are not inline, and it's also good to now have .cpp "landing pads" if we ever
want to add more things to that class.
Note that a lot of how these things are designed has to do with the fact
that pretty soon here I'll have to switch us from using the LLVM global
context to using a context that we create. When that happens, anyone who
creates anything will have to know the context; that's why FTL::CommonValues
already knows the module but doesn't use it - in the future it will have to
do things with it.
- JavaScriptCore.xcodeproj/project.pbxproj:
- ftl/FTLAbbreviations.h:
(JSC::FTL::buildSub):
- ftl/FTLAbstractHeapRepository.cpp:
(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLCommonValues.cpp: Added.
(FTL):
(JSC::FTL::CommonValues::CommonValues):
- ftl/FTLCommonValues.h: Added.
(FTL):
(CommonValues):
(JSC::FTL::CommonValues::initialize):
- ftl/FTLIntrinsicRepository.cpp: Added.
(FTL):
(JSC::FTL::IntrinsicRepository::IntrinsicRepository):
- ftl/FTLIntrinsicRepository.h: Added.
(FTL):
(IntrinsicRepository):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithSub):
(LowerDFGToLLVM):
- ftl/FTLOutput.cpp: Added.
(FTL):
(JSC::FTL::Output::Output):
(JSC::FTL::Output::~Output):
- ftl/FTLOutput.h:
(Output):
(JSC::FTL::Output::initialize):
(JSC::FTL::Output::sub):
(JSC::FTL::Output::addWithOverflow32):
(JSC::FTL::Output::subWithOverflow32):
(JSC::FTL::Output::mulWithOverflow32):
- 9:54 AM Changeset in webkit [147336] by
-
- 3 edits in trunk/Source/WebCore
Make a bunch of DocumentLoader functions private
https://bugs.webkit.org/show_bug.cgi?id=113601
Reviewed by Alexey Proskuryakov.
No new tests, cleanup only.
- loader/DocumentLoader.cpp:
- loader/DocumentLoader.h:
- 9:44 AM Changeset in webkit [147335] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fixing borked VS 2010 project file
Unreviewed bot greening.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- 9:32 AM Changeset in webkit [147334] by
-
- 2 edits in trunk/Source/JavaScriptCore
One more Windows build fix
Unreviewed.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 9:26 AM Changeset in webkit [147333] by
-
- 3 edits in trunk/Source/WebCore
Minor code cleanup by removing duplicated null checks
https://bugs.webkit.org/show_bug.cgi?id=113701
Reviewed by Darin Adler.
Duplicated null check is code redundancy, so delete those.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::setFocusedNodeIfNeeded):
- platform/Arena.cpp:
(WebCore::FreeArenaList):
- 9:18 AM Changeset in webkit [147332] by
-
- 3 edits in trunk/Source/JavaScriptCore
More build fallout fixes.
Unreviewed build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def: Add new export symbols.
- heap/SuperRegion.cpp: Windows didn't like "LLU".
- 9:14 AM Changeset in webkit [147331] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: follow up to r147323, popover is empty on network panel.
Not reviewed.
- inspector/front-end/DOMExtension.js:
(Element.prototype.measurePreferredSize):
- inspector/front-end/Popover.js:
(WebInspector.Popover.prototype._innerShow):
- 9:01 AM Changeset in webkit [147330] by
-
- 6 edits in trunk/Source/JavaScriptCore
r147324 broke the world
https://bugs.webkit.org/show_bug.cgi?id=113704
Unreviewed build fix.
Remove a bunch of unused variables and use the correctly sized types for 32-bit platforms.
- heap/BlockAllocator.cpp:
(JSC::BlockAllocator::BlockAllocator):
- heap/BlockAllocator.h:
(BlockAllocator):
- heap/Heap.cpp:
(JSC::Heap::Heap):
- heap/SuperRegion.cpp:
(JSC::SuperRegion::SuperRegion):
- heap/SuperRegion.h:
(SuperRegion):
- 8:35 AM Changeset in webkit [147329] by
-
- 3 edits in trunk/Source/JavaScriptCore
32-bit Windows build fix
Unreviewed build fix.
- heap/SuperRegion.cpp:
- heap/SuperRegion.h: Use uint64_t instead of size_t.
(SuperRegion):
- 8:28 AM Changeset in webkit [147328] by
-
- 2 edits in trunk/Source/JavaScriptCore
EFL build fix
Unreviewed build fix.
- CMakeLists.txt:
- 8:26 AM Changeset in webkit [147327] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Exception in console on attempt to filter javascript messages.
https://bugs.webkit.org/show_bug.cgi?id=113327
Fixed non-css filtration if console message groups are present. Message groups elements are always shown and are
never filtered out.
Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-04-01
Reviewed by Pavel Feldman.
- inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.updateRepeatCount):
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.get this):
(WebInspector.ConsoleView.prototype._consoleMessageAdded):
(WebInspector.ConsoleView.prototype._appendConsoleMessage):
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._shouldBeVisible):
(WebInspector.ConsoleView.prototype._updateMessageList):
(WebInspector.ConsoleView.prototype._printResult):
- 8:25 AM Changeset in webkit [147326] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL doesn't need virtual register allocation
https://bugs.webkit.org/show_bug.cgi?id=113679
Reviewed by Mark Hahnenberg.
- dfg/DFGDriver.cpp:
(JSC::DFG::dumpAndVerifyGraph):
(DFG):
(JSC::DFG::compile):
- 8:24 AM Changeset in webkit [147325] by
-
- 12 edits3 adds in trunk
Parsing WebVTT Region Header Metadata
https://bugs.webkit.org/show_bug.cgi?id=109818
Reviewed by Eric Carlson.
Source/WebCore:
This patch enables reading regions from the metadata section of
a WebVTT file. The work for defining generic metadata within the
WebVTT file header is still work in progress in the TextTrack CG.
As previous patches, everything is guarded by WEBVTT_REGIONS and
is by default disabled in all ports.
Test: media/track/regions-webvtt/text-track-region-parser.html
- html/track/LoadableTextTrack.cpp:
(WebCore):
(WebCore::LoadableTextTrack::newRegionsAvailable): Added method
to be called as soon as regions have finished parsing.
- html/track/LoadableTextTrack.h:
(LoadableTextTrack):
- html/track/TextTrack.h: Changed the access modifiers.
(TextTrack):
- html/track/TextTrackRegion.cpp:
(WebCore::TextTrackRegion::setRegionSettings): Entry point for
parsing the region settings from a string.
(WebCore):
(WebCore::TextTrackRegion::getSettingFromString): Maps a string
to a RegionSetting value.
(WebCore::TextTrackRegion::parseSettingValue): Parses the value
of a specific setting.
(WebCore::TextTrackRegion::parseSetting): Parses a setting string.
- html/track/TextTrackRegion.h:
- html/track/WebVTTParser.cpp:
(WebCore):
(WebCore::WebVTTParser::parseFloatPercentageValue): Helper method
to parse a float percentage value (e.g. "50.1%")
(WebCore::WebVTTParser::parseFloatPercentageValuePair): Helper method
to parse a float percentage value pair (e.g. "50.1%, 30.5%")
(WebCore::WebVTTParser::getNewRegions): Retrieves the new regions
available for processing.
(WebCore::WebVTTParser::parseBytes):
(WebCore::WebVTTParser::collectHeader): Generic function to collect
header in the metadata region.
(WebCore::WebVTTParser::createNewRegion): Creates new region using
the existing metadata header name and value.
- html/track/WebVTTParser.h:
(WebVTTParserClient):
(WebVTTParser):
- loader/TextTrackLoader.cpp:
(WebCore):
(WebCore::TextTrackLoader::newRegionsParsed): Called when the
regions have been succesfully parsed.
(WebCore::TextTrackLoader::getNewRegions): Gets the new regions.
- loader/TextTrackLoader.h:
(TextTrackLoaderClient): Added methods that need to be implemented.
(TextTrackLoader):
LayoutTests:
- media/track/captions-webvtt/header-regions.vtt: Added.
- media/track/regions-webvtt/text-track-region-parser-expected.txt: Added.
- media/track/regions-webvtt/text-track-region-parser.html: Added.
- 8:23 AM Changeset in webkit [147324] by
-
- 18 edits2 adds in trunk/Source
Regions should be allocated from the same contiguous segment of virtual memory
https://bugs.webkit.org/show_bug.cgi?id=113662
Reviewed by Filip Pizlo.
Instead of letting the OS spread our Regions all over the place, we should allocate them all within
some range of each other. This change will open the door to some other optimizations, e.g. doing simple
range checks for our write barriers and compressing JSCell pointers to 32-bits.
Source/JavaScriptCore:
Added new SuperRegion class that encapsulates allocating Regions from a contiguous reserved chunk of
virtual address space. It functions very similarly to the FixedVMPoolExecutableAllocator class used by the JIT.
Also added two new subclasses of Region, NormalRegion and ExcessRegion.
NormalRegion is the type of Region that is normally allocated when there is available space remaining
in the SuperRegion. If we ever run out of space in the SuperRegion, we fall back to allocating
ExcessRegions, which are identical to how Regions have behaved up until now, i.e. they contain a
PageAllocationAligned.
We only use the SuperRegion (and NormalRegions) on 64-bit systems, since it doesn't make sense to reserve the
entire 4 GB address space on 32-bit systems just for the JS heap.
- GNUmakefile.list.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- heap/BlockAllocator.cpp:
(JSC::BlockAllocator::BlockAllocator):
- heap/BlockAllocator.h:
(JSC):
(BlockAllocator):
(JSC::BlockAllocator::allocate):
(JSC::BlockAllocator::allocateCustomSize):
(JSC::BlockAllocator::deallocateCustomSize):
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC):
(JSC::Heap::didExceedFixedHeapSizeLimit):
- heap/Heap.h:
(Heap):
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::create):
- heap/Region.h:
(Region):
(JSC):
(NormalRegion):
(JSC::NormalRegion::base):
(JSC::NormalRegion::size):
(ExcessRegion):
(JSC::ExcessRegion::base):
(JSC::ExcessRegion::size):
(JSC::NormalRegion::NormalRegion):
(JSC::NormalRegion::tryCreate):
(JSC::NormalRegion::tryCreateCustomSize):
(JSC::NormalRegion::reset):
(JSC::ExcessRegion::ExcessRegion):
(JSC::ExcessRegion::~ExcessRegion):
(JSC::ExcessRegion::create):
(JSC::ExcessRegion::createCustomSize):
(JSC::ExcessRegion::reset):
(JSC::Region::Region):
(JSC::Region::initializeBlockList):
(JSC::Region::create):
(JSC::Region::createCustomSize):
(JSC::Region::~Region):
(JSC::Region::destroy):
(JSC::Region::reset):
(JSC::Region::deallocate):
(JSC::Region::base):
(JSC::Region::size):
- heap/SuperRegion.cpp: Added.
(JSC):
(JSC::SuperRegion::SuperRegion):
(JSC::SuperRegion::getAlignedBase):
(JSC::SuperRegion::allocateNewSpace):
(JSC::SuperRegion::notifyNeedPage):
(JSC::SuperRegion::notifyPageIsFree):
- heap/SuperRegion.h: Added.
(JSC):
(SuperRegion):
Source/WTF:
- wtf/MetaAllocator.cpp: Changed the MetaAllocator to allow custom page sizes if the derived class wants to
use something other than the system page size.
(WTF::MetaAllocator::MetaAllocator):
- wtf/MetaAllocator.h:
(MetaAllocator):
- 7:03 AM Changeset in webkit [147323] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Go to line dialog has 0 height, viewport dialogs have empty gaps.
https://bugs.webkit.org/show_bug.cgi?id=113702
Reviewed by Yury Semikhatsky.
- inspector/front-end/DOMExtension.js:
(Element.prototype.measurePreferredSize):
- inspector/front-end/Popover.js:
(WebInspector.Popover.prototype._innerShow):
- inspector/front-end/ViewportControl.js:
(WebInspector.ViewportControl.prototype.refresh):
- inspector/front-end/dialog.css:
(.dialog-contents):
- 5:52 AM Changeset in webkit [147322] by
-
- 4 edits2 adds in trunk
Web Inspector: [DTE] Convertion between text and coordinates
https://bugs.webkit.org/show_bug.cgi?id=113389
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-01
Reviewed by Pavel Feldman.
Source/WebCore:
Test: inspector/editor/text-editor-char-to-coordinates.html
Implement cursorPositionToCoordinates and coordinatesToCursorPosition
methods pair in DefaultTextEditor.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.cursorPositionToCoordinates):
(WebInspector.DefaultTextEditor.prototype.coordinatesToCursorPosition):
(WebInspector.TextEditorMainPanel.prototype.cursorPositionToCoordinates):
(WebInspector.TextEditorMainPanel.prototype.coordinatesToCursorPosition):
- inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.cursorPositionToCoordinates):
(WebInspector.TextEditor.prototype.coordinatesToCursorPosition):
LayoutTests:
Test to verify added functionality.
- inspector/editor/text-editor-char-to-coordinates-expected.txt: Added.
- inspector/editor/text-editor-char-to-coordinates.html: Added.
- 5:47 AM Changeset in webkit [147321] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Rename "Copy to Curl" menu item command to "Copy to cURL"
https://bugs.webkit.org/show_bug.cgi?id=113575
Patch by Sergey Ryazanov <serya@chromium.org> on 2013-04-01
Reviewed by Pavel Feldman.
Fix the name to the offical way of capitalization.
- English.lproj/localizedStrings.js:
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._contextMenu):
- 5:13 AM Changeset in webkit [147320] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
- platform/chromium/TestExpectations:
- 3:46 AM Changeset in webkit [147319] by
-
- 2 edits in trunk/Tools
[GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
https://bugs.webkit.org/show_bug.cgi?id=104779
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-01
Reviewed by Carlos Garcia Campos.
- Scripts/run-gtk-tests:
(TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
passing in current trunk.
- 3:39 AM Changeset in webkit [147318] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding failure expectations for tests added in r147249 and r147250 that fail
due to disabled subpixel layout. Adding failure expectations for tests that regressed with r147241.
- platform/gtk/fast/events/event-attribute-expected.txt: Added the required baseline after r147205.
- 3:35 AM Changeset in webkit [147317] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: m_purgePreventCount when clicking text with emphasis marks
https://bugs.webkit.org/show_bug.cgi?id=85266
Patch by Koji Ishii <Koji Ishii> on 2013-04-01
Reviewed by Darin Adler.
Font::glyphDataAndPageForCharacter may call FontCache::getFontDataForCharacters
if system fallback occurs, which may return SimpleFontData with DoNotRetain,
so callers must prevent possible font cache purging.
Source/WebCore:
Test: fast/text/emphasis-height-crash.html
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::emphasisMarkAscent): Add FontCachePurgePreventer.
(WebCore::Font::emphasisMarkDescent): ditto.
(WebCore::Font::emphasisMarkHeight): ditto.
(WebCore::Font::drawEmphasisMarks): ditto.
LayoutTests:
- fast/text/emphasis-height-crash-expected.txt: Added.
- fast/text/emphasis-height-crash.html: Added.
- 3:32 AM Changeset in webkit [147316] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove an unused variable from the ARMv7 Assembler
https://bugs.webkit.org/show_bug.cgi?id=113653
Reviewed by Andreas Kling.
- assembler/ARMv7Assembler.h:
(ARMv7Assembler):
- 3:29 AM Changeset in webkit [147315] by
-
- 2 edits in trunk/LayoutTests
[GTK] Remove resource-har-conversion.html from TestExpectation
https://bugs.webkit.org/show_bug.cgi?id=113677
Unreviewed gardening.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-01
- platform/gtk/TestExpectations: Rebaseline after r147219.
- 3:25 AM Changeset in webkit [147314] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Fixed DOM Breakpoint pane styles.
https://bugs.webkit.org/show_bug.cgi?id=113688
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-04-01
Reviewed by Pavel Feldman.
The required stylesheet (breakpointsList.css) was not loaded because of
the peculiar way DOMBreakpointsSidebarPane is included in two panels
(Sources and Elements) via a proxy pane. Since DOMBreakpointsSidebarPane
was never shown directly the registerRequiredCSS call in its base class
NativeBreakpointsSidebarPane constructor had no effect.
Addin a registerRequiredCSS call to the proxy pane constructor fixes the
problem.
- inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.Proxy):
- 2:41 AM Changeset in webkit [147313] by
-
- 2 edits in trunk/Source/WTF
Web Inspector: add memory instrumentation for StringBuffer
https://bugs.webkit.org/show_bug.cgi?id=113507
Reviewed by Pavel Feldman.
Added memory instrumentation for StringBuffer.
- wtf/MemoryInstrumentationString.h:
(WTF):
(WTF::reportMemoryUsage):
- 2:39 AM Changeset in webkit [147312] by
-
- 198 edits1 move4 adds19 deletes in trunk/LayoutTests
Unreviewed, rolling out r147298.
http://trac.webkit.org/changeset/147298
broke lots of layout tests
- platform/chromium-linux-x86/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Removed.
- platform/chromium-linux-x86/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Added.
- platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
- platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize06-expected.png: Removed.
- platform/chromium-linux-x86/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
- platform/chromium-linux-x86/fast/borders/border-image-scale-transform-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/border-image-scaled-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/scaled-border-image-expected.png: Added.
- platform/chromium-linux-x86/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Removed.
- platform/chromium-linux-x86/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Removed.
- platform/chromium-linux-x86/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Removed.
- platform/chromium-linux/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-linux/css3/images/cross-fade-background-size-expected.png: Removed.
- platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-linux/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
- platform/chromium-linux/fast/backgrounds/size/backgroundSize06-expected.png: Removed.
- platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
- platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
- platform/chromium-linux/fast/borders/scaled-border-image-expected.png:
- platform/chromium-linux/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Removed.
- platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-lion/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-mac-lion/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-mac-lion/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-mac-lion/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-mac-lion/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
- platform/chromium-mac-lion/fast/backgrounds/size/backgroundSize06-expected.png: Removed.
- platform/chromium-mac-lion/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
- platform/chromium-mac-lion/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac-lion/fast/borders/border-image-scaled-expected.png:
- platform/chromium-mac-lion/fast/borders/scaled-border-image-expected.png:
- platform/chromium-mac-lion/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-mac-lion/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-lion/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-mac-snowleopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize06-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png:
- platform/chromium-mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-mac/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize02-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize04-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize13-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize14-expected.png:
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
- platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
- platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
- platform/chromium-mac/fast/borders/scaled-border-image-expected.png:
- platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
- platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
- platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-win/fast/borders/border-image-scaled-expected.png:
- platform/chromium-win/fast/borders/border-image-side-reduction-expected.png:
- platform/chromium-win/fast/borders/scaled-border-image-expected.png:
- platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Removed.
- platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium/TestExpectations:
- platform/chromium/css3/images/cross-fade-background-size-expected.png: Renamed from LayoutTests/platform/chromium-win/css3/images/cross-fade-background-size-expected.png.
- 2:27 AM Changeset in webkit [147311] by
-
- 237 edits6 deletes in trunk/LayoutTests
Unreviewed, rolling out r147301.
http://trac.webkit.org/changeset/147301
broke lots of layout tests
- platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Removed.
- platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Removed.
- platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Removed.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Removed.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Removed.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Removed.
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-mac-lion/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-mac-lion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-mac/svg/as-image/image-preserveAspectRatio-all-expected.png:
- platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac/svg/filters/feImage-preserveAspectRatio-all-expected.png:
- platform/chromium-mac/svg/filters/feImage-preserveAspectratio-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-win/svg/as-image/image-preserveAspectRatio-all-expected.png:
- platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-win/svg/filters/feImage-preserveAspectRatio-all-expected.png:
- platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
- 2:18 AM Changeset in webkit [147310] by
-
- 153 edits3 deletes in trunk/LayoutTests
Unreviewed, rolling out r147302.
http://trac.webkit.org/changeset/147302
broke lots of layout tests
- platform/chromium-linux-x86/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/marvin/th_valign_top-expected.png: Removed.
- platform/chromium-linux-x86/tables/mozilla/marvin/tr_valign_middle-expected.png: Removed.
- platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-mac-lion/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-mac-lion/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
- platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
- platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- 2:02 AM Changeset in webkit [147309] by
-
- 1 edit10 adds in trunk/LayoutTests
Unreviewed, rolling out r147307.
http://trac.webkit.org/changeset/147307
https://bugs.webkit.org/show_bug.cgi?id=113692
maybe broken lots of layout tests (Requested by
shinyak|gardener on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-01
- platform/chromium-linux-x86/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Added.
- platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize02-expected.png: Added.
- platform/chromium-linux-x86/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
- platform/chromium-linux-x86/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
- platform/chromium-linux-x86/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
- platform/chromium-linux/fast/backgrounds/size/backgroundSize02-expected.png: Added.
- platform/chromium-mac-lion/fast/backgrounds/size/backgroundSize02-expected.png: Added.
- platform/chromium-mac-lion/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize02-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
- 1:13 AM Changeset in webkit [147308] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Flame Chart. Extract item to coordinates conversion into a separate function.
https://bugs.webkit.org/show_bug.cgi?id=113682
Reviewed by Yury Semikhatsky.
The calculation was extracted into entryToAnchorBox.
Drive by fixes: unnecessary members were removed.
- inspector/front-end/FlameChart.js:
(WebInspector.FlameChart):
(WebInspector.FlameChart.Entry):
(WebInspector.FlameChart.prototype._calculateTimelineData):
(WebInspector.FlameChart.prototype._calculateTimelineDataForSamples):
(WebInspector.FlameChart.prototype._getPopoverAnchor):
(WebInspector.FlameChart.prototype._entryToAnchorBox):
(WebInspector.FlameChart.prototype.draw):
- 12:19 AM Changeset in webkit [147307] by
-
- 1 edit10 deletes in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Rebaselining.
- platform/chromium-linux-x86/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Removed.
- platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
- platform/chromium-linux-x86/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
- platform/chromium-linux-x86/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Removed.
- platform/chromium-linux-x86/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Removed.
- platform/chromium-linux/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
- platform/chromium-mac-lion/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
- platform/chromium-mac-lion/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
- platform/chromium-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
- 12:04 AM Changeset in webkit [147306] by
-
- 6 edits in trunk
[EFL] Enable user-select:all for EFL port
https://bugs.webkit.org/show_bug.cgi?id=113494
.:
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-04-01
Reviewed by Gyuyoung Kim.
Add a feature flag for user-select:all and enable it for EFL port.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
LayoutTests:
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-04-01
Reviewed by Gyuyoung Kim.
Enable user-select:all for EFL port and update the TestExpectations.
- platform/efl/TestExpectations:
Mar 31, 2013:
- 11:55 PM Changeset in webkit [147305] by
-
- 3 edits1 move in trunk/Tools
Unreviewed, rolling out r147289.
http://trac.webkit.org/changeset/147289
https://bugs.webkit.org/show_bug.cgi?id=113678
broke Win7 (dbg) build (Requested by shinyak|gardener on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-31
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
(WebTestRunner):
(WebUserMediaClientMock):
(WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
(WebTestRunner::WebUserMediaClientMock::taskList):
- Scripts/webkitpy/style/checkers/cpp.py:
(check_function_definition):
- 11:29 PM Changeset in webkit [147304] by
-
- 2 edits in trunk/Tools
configure-svn-config.sh fails
https://codereview.chromium.org/13392007/
Reviewed by Eric Seidel.
This script was trying to use "svn checkout" to dowload a file from
svn.webkit.org, but "svn checkout" only works with directories.
Instead, we should use "svn export".
- EWSTools/configure-svn-config.sh:
- 11:14 PM FeatureFlags edited by
- VIEWSOURCE_ATTRIBUTE (diff)
- 10:54 PM Changeset in webkit [147303] by
-
- 5 edits2 adds in trunk
Gradient background does not get repainted when child box is expanded.
https://bugs.webkit.org/show_bug.cgi?id=113644
Source/WebCore:
Patch by Zalan Bujtas <Alan Bujtas> on 2013-03-31
Reviewed by Antti Koivisto.
The initial value for background-size is SizeNone and remains, unless it is
set explicitly. However, when the background shorthand is used,
the size property defaults to SizeLength. The repaint
logic in mustRepaintFillLayers expects to have this value set correctly.
Test: fast/repaint/background-shorthand-with-gradient-and-height-changes.html
- rendering/RenderObject.cpp:
(WebCore::mustRepaintFillLayers): code cleanup. no functionality change.
- rendering/style/FillLayer.cpp:
(WebCore::FillLayer::FillLayer):
- rendering/style/FillLayer.h: use SizeNone as initial value.
(WebCore::FillLayer::initialFillSizeType):
(WebCore::FillLayer::initialFillSize):
LayoutTests:
Patch by Zalan Bujtas <Alan Bujtas> on 2013-03-31
Reviewed by Antti Koivisto.
- fast/repaint/background-shorthand-with-gradient-and-height-changes-expected.txt: Added.
- fast/repaint/background-shorthand-with-gradient-and-height-changes.html: Added.
- 10:23 PM Changeset in webkit [147302] by
-
- 153 edits4 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Rebaselining.
- platform/chromium-linux-x86/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Added.
- platform/chromium-linux-x86/tables/mozilla/marvin/th_valign_top-expected.png: Added.
- platform/chromium-linux-x86/tables/mozilla/marvin/tr_valign_middle-expected.png: Added.
- platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-mac-lion/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-mac-lion/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
- platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
- platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
- platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
- platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
- platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- 9:48 PM Changeset in webkit [147301] by
-
- 237 edits7 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Rebaselining.
- platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
- platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-mac-lion/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-mac-lion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac-lion/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-mac/svg/as-image/image-preserveAspectRatio-all-expected.png:
- platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-mac/svg/filters/feImage-preserveAspectRatio-all-expected.png:
- platform/chromium-mac/svg/filters/feImage-preserveAspectratio-expected.png:
- platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
- platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
- platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
- platform/chromium-win/svg/as-image/image-preserveAspectRatio-all-expected.png:
- platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
- platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
- platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
- platform/chromium-win/svg/filters/feImage-preserveAspectRatio-all-expected.png:
- platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png:
- platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
- 9:35 PM Changeset in webkit [147300] by
-
- 2 edits in branches/dfgFourthTier/Source/WTF
https://bugs.webkit.org/show_bug.cgi?id=113656
Fix Sam's nits.
Unreviewed.
Forgot to land these as part of http://trac.webkit.org/changeset/147299.
- wtf/MathExtras.h:
(isGreaterThanNonZeroPowerOfTwo):
- 9:33 PM Changeset in webkit [147299] by
-
- 4 edits in branches/dfgFourthTier/Source/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=113656
Fix Sam's nits.
Unreviewed.
- ftl/FTLAbstractHeap.cpp:
(JSC::FTL::IndexedAbstractHeap::initialize):
- ftl/FTLAbstractHeap.h:
(IndexedAbstractHeap):
(AbsoluteAbstractHeap):
- ftl/FTLAbstractHeapRepository.h:
(AbstractHeapRepository):
- 9:29 PM Changeset in webkit [147298] by
-
- 198 edits1 copy1 move18 adds4 deletes in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Rebaselining.
- platform/chromium-linux-x86/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Added.
- platform/chromium-linux-x86/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Removed.
- platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize02-expected.png: Added.
- platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize06-expected.png: Added.
- platform/chromium-linux-x86/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
- platform/chromium-linux-x86/fast/borders/border-image-scale-transform-expected.png: Removed.
- platform/chromium-linux-x86/fast/borders/border-image-scaled-expected.png: Removed.
- platform/chromium-linux-x86/fast/borders/scaled-border-image-expected.png: Removed.
- platform/chromium-linux-x86/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
- platform/chromium-linux-x86/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
- platform/chromium-linux-x86/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png.
- platform/chromium-linux/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-linux/css3/images/cross-fade-background-size-expected.png: Added.
- platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-linux/fast/backgrounds/size/backgroundSize02-expected.png: Added.
- platform/chromium-linux/fast/backgrounds/size/backgroundSize06-expected.png: Added.
- platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
- platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
- platform/chromium-linux/fast/borders/scaled-border-image-expected.png:
- platform/chromium-linux/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
- platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-lion/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-mac-lion/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-mac-lion/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-mac-lion/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-mac-lion/fast/backgrounds/size/backgroundSize02-expected.png: Added.
- platform/chromium-mac-lion/fast/backgrounds/size/backgroundSize06-expected.png: Added.
- platform/chromium-mac-lion/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
- platform/chromium-mac-lion/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac-lion/fast/borders/border-image-scaled-expected.png:
- platform/chromium-mac-lion/fast/borders/scaled-border-image-expected.png:
- platform/chromium-mac-lion/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-mac-lion/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-lion/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-mac-snowleopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize02-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize06-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-expected.png:
- platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png:
- platform/chromium-mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-mac/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize02-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize04-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize13-expected.png:
- platform/chromium-mac/fast/backgrounds/size/backgroundSize14-expected.png:
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
- platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
- platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
- platform/chromium-mac/fast/borders/scaled-border-image-expected.png:
- platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.png:
- platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
- platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
- platform/chromium-win/css3/images/cross-fade-background-size-expected.png: Renamed from LayoutTests/platform/chromium/css3/images/cross-fade-background-size-expected.png.
- platform/chromium-win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
- platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
- platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
- platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
- platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
- platform/chromium-win/fast/borders/border-image-scaled-expected.png:
- platform/chromium-win/fast/borders/border-image-side-reduction-expected.png:
- platform/chromium-win/fast/borders/scaled-border-image-expected.png:
- platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
- platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
- platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
- platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
- platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
- platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
- platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
- platform/chromium/TestExpectations:
- 9:20 PM Changeset in webkit [147297] by
-
- 5 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL JIT should support GetByVal on Int32 arrays
https://bugs.webkit.org/show_bug.cgi?id=113668
Reviewed by Sam Weinig.
It actually already supported this, but needed to be told that it did.
Also adds an option to enable LICM (loop-invariant code motion, i.e.
http://llvm.org/docs/Passes.html#licm-loop-invariant-code-motion). LICM
isn't doing me any good right now, but I guess I'll have to play with
it more. And this adds the ability to tweak the LLVM optimization level
from the command-line.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
- runtime/Options.h:
(JSC):
- 8:52 PM Changeset in webkit [147296] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
- platform/chromium/TestExpectations:
- 8:44 PM Changeset in webkit [147295] by
-
- 4 edits2 adds in trunk
Text representation of pseudo elements, '::-webkit-distributed', is wrong in CSSSelector::selectorText().
https://bugs.webkit.org/show_bug.cgi?id=113560
Reviewed by Dimitri Glazkov.
Source/WebCore:
Fix the text representation of distributed functional pseudo elements in CSSSelector::selectorText().
Test: fast/dom/shadow/distributed-pseudo-element-css-text.html
- css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText):
- css/CSSSelector.h:
(CSSSelector):
LayoutTests:
- fast/dom/shadow/distributed-pseudo-element-css-text-expected.txt: Added.
- fast/dom/shadow/distributed-pseudo-element-css-text.html: Added.
- 8:06 PM Changeset in webkit [147294] by
-
- 5 edits1 move in trunk/Source
[Chromium] Yarr should build using a separate GYP file from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=113652
Reviewed by Nico Weber.
Source/JavaScriptCore:
This patch moves JavaScriptCore.gyp to yarr.gyp because Chromium only
uses this GYP file to build yarr.
- JavaScriptCore.gyp/JavaScriptCoreGTK.gyp:
- JavaScriptCore.gypi:
- yarr/yarr.gyp: Renamed from Source/JavaScriptCore/JavaScriptCore.gyp/JavaScriptCore.gyp.
Source/WebCore:
- WebCore.gyp/WebCore.gyp:
- Update references to yarr.gyp.
- 7:52 PM WebKitGTK/2.0.x edited by
- (diff)
- 6:16 PM Changeset in webkit [147293] by
-
- 9 edits in trunk/Source
[EFL] Remove unused stdio.h includes
https://bugs.webkit.org/show_bug.cgi?id=113655
Reviewed by Andreas Kling.
We do not have to include unused header file.
Source/WebCore:
- platform/efl/CursorEfl.cpp:
- platform/efl/FileSystemEfl.cpp:
- platform/efl/PlatformKeyboardEventEfl.cpp:
- platform/efl/ScrollbarThemeEfl.cpp:
Source/WebKit/efl:
- ewk/ewk_tiled_backing_store.cpp:
- ewk/ewk_tiled_matrix.cpp:
- ewk/ewk_tiled_model.cpp:
(tile_account):
- 4:28 PM Changeset in webkit [147292] by
-
- 6 edits5 adds in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL JIT should supply TBAA meta-data to LLVM
https://bugs.webkit.org/show_bug.cgi?id=113656
Reviewed by Oliver Hunt.
This adds support for performing strong typing on the LLVM IR that the FTL
generates, by using TBAA meta-data. This will permit LLVM to do aggressive
GVN, load elimination, and LICM optimization even if it sees pointer store
side-effects. The goal is to precisely model all loads and stores we emit,
except for the super crazy ones (GetById that can go all-out polymorphic,
or for example a Call where we know nothing).
This is accomplished by introducing the notion of an AbstractHeap
typesystem. An AbstractHeap is a subset of all possible memory locations
that we might store to. For example, JSCell::m_structure and
JSObject::m_butterfly are two disjoint AbstractHeaps because we know that
a store to one cannot clobber the other. AbstractHeaps follow a
single-inheritance hierarchy. There is the root heap, which corresponds to
any possible memory location accessible to the JS engine, and then there
are heaps for all internal object fields, a heap for each global object,
and so on.
There are three other tidbits here that make this somewhat more interesting.
We have a notion of an AbstractHeap-with-offset, called AbstractField.
JSCell::m_structure is actually an AbstractField. This allows us to say
things like m_out.loadPtr(base, m_heaps.JSCell_structure); this both
gives you the offset of JSCell::m_structure and ascribes TBAA meta-data for
the JSCell::m_structure heap to the generated load instrction.
Another fun tidbit is the notion of Indexed, Numbered, and Absolute abstract
heaps. An indexed abstract heap corresponds to a set of locations that you
might access by index from some base. Virtual registers are a great example.
Though I call them just "variables" in the FTL. When we access a virtual
register, we know that we aren't interfering with accesses to
Structure-managed named properties, or with JSCell::m_structure, or with
other such disjoint heaps. But we also know that if we access a variable at
offset X and then another variable at offset Y and we know that X and Y are
unequal, then these two accesses are on disjoint subheaps of the variables
heap. This works out naturally for interference between, say, scoped variable
access and local variable access: if you access scoped variable r5 and then
access a local variable r5, these might interfere - and they will get the
same abstract subheap of the variables heap. IndexedAbstractHeaps
conveniently remember the size of the elements and will give you an
AbstractField (i.e. heap-with-offset) if you give it an index. This is great
for conveniently writing code that accesses contiguous arrays of well-typed
things. This allows you to literally do things like
m_out.load64(callFrameRegister, m_heaps.variables[operand]) and the right
thing will happen. You can also get the heap variables.atAnyIndex(), if
you're doing an access with an unknown index.
Numbered and Absolute abstract heaps are related except that they don't
assume that the value used to get the abstract subheap corresponds to any
meaningful offset from any base. Numbered heaps, like the properties heap
(for named properties tracked by Structure), are "numbered" (not indexed)
by the propertyNumber. So you can emit a GetByOffset by separately
computing the offset and the propertyNumber (both values are stored in the
StorageAccessData), and passing the offset directly to Output::address()
and passing m_heaps.properties[propertyNumber] as the field. Absolute heaps
are similar, but are keyed on absolute address. This is appropriate for
global variables, and possibly other things.
Finally, FTL::Output understands the notion of a pointer-with-TBAA-data,
and calls it a TypedPointer. TypedPointer is a tuple of a LLVMValueRef
referencing an intptr value and a pointer to an AbstractHeap. All load()
and store() operations now take a TypedPointer, and will perform the access
by casting the intptr to a pointer of the right type and then ascribing the
TBAA meta-data from the AbstractHeap.
- JavaScriptCore.xcodeproj/project.pbxproj:
- ftl/FTLAbbreviations.h:
(JSC::FTL::mdKindID):
(JSC::FTL::mdString):
(JSC::FTL::mdNode):
(FTL):
(JSC::FTL::setMetadata):
- ftl/FTLAbstractHeap.cpp: Added.
(FTL):
(JSC::FTL::AbstractHeap::tbaaMetadataSlow):
(JSC::FTL::AbstractHeap::decorateInstruction):
(JSC::FTL::IndexedAbstractHeap::IndexedAbstractHeap):
(JSC::FTL::IndexedAbstractHeap::~IndexedAbstractHeap):
(JSC::FTL::IndexedAbstractHeap::baseIndex):
(JSC::FTL::IndexedAbstractHeap::atSlow):
(JSC::FTL::IndexedAbstractHeap::initialize):
(JSC::FTL::NumberedAbstractHeap::NumberedAbstractHeap):
(JSC::FTL::NumberedAbstractHeap::~NumberedAbstractHeap):
(JSC::FTL::AbsoluteAbstractHeap::AbsoluteAbstractHeap):
(JSC::FTL::AbsoluteAbstractHeap::~AbsoluteAbstractHeap):
- ftl/FTLAbstractHeap.h: Added.
(FTL):
(AbstractHeap):
(JSC::FTL::AbstractHeap::AbstractHeap):
(JSC::FTL::AbstractHeap::isInitialized):
(JSC::FTL::AbstractHeap::initialize):
(JSC::FTL::AbstractHeap::parent):
(JSC::FTL::AbstractHeap::heapName):
(JSC::FTL::AbstractHeap::tbaaMetadata):
(AbstractField):
(JSC::FTL::AbstractField::AbstractField):
(JSC::FTL::AbstractField::initialize):
(JSC::FTL::AbstractField::offset):
(IndexedAbstractHeap):
(JSC::FTL::IndexedAbstractHeap::atAnyIndex):
(JSC::FTL::IndexedAbstractHeap::at):
(JSC::FTL::IndexedAbstractHeap::operator[]):
(JSC::FTL::IndexedAbstractHeap::returnInitialized):
(JSC::FTL::IndexedAbstractHeap::MyHashTraits::constructDeletedValue):
(JSC::FTL::IndexedAbstractHeap::MyHashTraits::isDeletedValue):
(NumberedAbstractHeap):
(JSC::FTL::NumberedAbstractHeap::atAnyNumber):
(JSC::FTL::NumberedAbstractHeap::at):
(JSC::FTL::NumberedAbstractHeap::operator[]):
(AbsoluteAbstractHeap):
(JSC::FTL::AbsoluteAbstractHeap::atAnyAddress):
(JSC::FTL::AbsoluteAbstractHeap::at):
(JSC::FTL::AbsoluteAbstractHeap::operator[]):
- ftl/FTLAbstractHeapRepository.cpp: Added.
(FTL):
(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):
(JSC::FTL::AbstractHeapRepository::~AbstractHeapRepository):
- ftl/FTLAbstractHeapRepository.h: Added.
(FTL):
(AbstractHeapRepository):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileCheckStructure):
(JSC::FTL::LowerDFGToLLVM::compileGetButterfly):
(JSC::FTL::LowerDFGToLLVM::compileGetArrayLength):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compileGetByOffset):
(JSC::FTL::LowerDFGToLLVM::speculateObject):
(JSC::FTL::LowerDFGToLLVM::addressFor):
(JSC::FTL::LowerDFGToLLVM::payloadFor):
(JSC::FTL::LowerDFGToLLVM::tagFor):
(LowerDFGToLLVM):
- ftl/FTLOutput.h:
(FTL):
(JSC::FTL::Output::Output):
(JSC::FTL::Output::initialize):
(JSC::FTL::Output::set):
(JSC::FTL::Output::load):
(JSC::FTL::Output::store):
(Output):
(JSC::FTL::Output::load32):
(JSC::FTL::Output::load64):
(JSC::FTL::Output::loadPtr):
(JSC::FTL::Output::store32):
(JSC::FTL::Output::store64):
(JSC::FTL::Output::storePtr):
(JSC::FTL::Output::addPtr):
(JSC::FTL::Output::address):
(JSC::FTL::Output::baseIndex):
- ftl/FTLTypedPointer.h: Added.
(FTL):
(TypedPointer):
(JSC::FTL::TypedPointer::TypedPointer):
(JSC::FTL::TypedPointer::operator!):
(JSC::FTL::TypedPointer::heap):
(JSC::FTL::TypedPointer::value):
- runtime/Options.h:
(JSC):
- 4:27 PM Changeset in webkit [147291] by
-
- 4 edits3 adds in trunk
HTMLLinkElement should resolve resource URLs when resources will be fetched
https://bugs.webkit.org/show_bug.cgi?id=113630
Source/WebCore:
HTMLLinkElement was resolving its URL when the href attribute was processed and caching it without ever
invalidating the cached URL. This patch removes the cached URL and adds getURL() which resolve the
URL dynamically.
Reviewed by Eric Seidel.
Test: fast/dom/HTMLLinkElement/resolve-url-on-insertion.html
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::getURL):
(WebCore):
(WebCore::HTMLLinkElement::parseAttribute):
(WebCore::HTMLLinkElement::shouldLoadLink):
(WebCore::HTMLLinkElement::process):
- html/HTMLLinkElement.h:
(HTMLLinkElement):
LayoutTests:
Reviewed by Eric Seidel.
- fast/dom/HTMLLinkElement/resolve-url-on-insertion-expected.txt: Added.
- fast/dom/HTMLLinkElement/resolve-url-on-insertion.html: Added.
- fast/dom/HTMLLinkElement/resources/stylesheet2.css: Added.
(#test2):
- 4:25 PM Changeset in webkit [147290] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix a comment. While thinking about TBAA for array accesses,
I realized that we have to be super careful about aliasing of typed arrays.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::getByValLoadElimination):
- 4:17 PM Changeset in webkit [147289] by
-
- 3 edits1 move in trunk/Tools
Allow WebUserMediaClientMock to be used by client
https://bugs.webkit.org/show_bug.cgi?id=113633
Patch by Wei Jia <wjia@chromium.org> on 2013-03-31
Reviewed by Adam Barth.
Export WebUserMediaClientMock.
Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
- DumpRenderTree/DumpRenderTree.gypi:
- DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
(WebUserMediaClientMock):
- DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_function_definition):
- 1:34 PM Changeset in webkit [147288] by
-
- 2 edits in branches/chromium/1410/Source/WebKit/chromium
Merge 147181 "[chromium] Use widget.parent() for plugin WebMouse..."
[chromium] Use widget.parent() for plugin WebMouseEvents
https://bugs.webkit.org/show_bug.cgi?id=113543
Reviewed by James Robinson.
In r142571 I switches widget.parent() to widget.root() in the plugin
WebCore event -> WebMouseEvent creator, to make the converter the
inverse of the one going the other way and avoid null pointer crashes.
But the plugin code expects it to be parent() (see
http://crbug.com/223335).
- src/WebInputEventConversion.cpp:
(WebKit::updateWebMouseEventFromWebCoreMouseEvent):
TBR=aelias@chromium.org
Review URL: https://codereview.chromium.org/13190003
- 1:13 PM Changeset in webkit [147287] by
-
- 2 edits in trunk/Source/WebCore
NetworkProcess crashes in WebCoreResourceHandleAsOperationQueueDelegate callbacks.
<rdar://problem/13541868> and https://bugs.webkit.org/show_bug.cgi?id=113664
Reviewed by Dan Bernstein.
In the "two-part" callbacks that involve waiting on a semaphore for the async block to finish,
the delegate might have been destroyed by the time the wait completes.
A RetainPtr<> protector will fix that up nicely.
- platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connectionShouldUseCredentialStorage:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willCacheResponse:]):
- 12:33 PM Changeset in webkit [147286] by
-
- 4 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL JIT should be able to compile the Array.prototype.findGraphNode function in Kraken/ai-astar
https://bugs.webkit.org/show_bug.cgi?id=113646
Reviewed by Oliver Hunt.
This adds enough FTL support to compile Array.prototype.findGraphNode. This isn't
a speed-up, yet, because findGraphNode tends to be aggressively inlined by the DFG,
and the FTL can't yet compile the things into which it was inlined. In future
patches we will get to a point where we can compile the callers, and then we'll be
able to see what the performance effects are.
But the interesting thing is that it isn't a slow-down, either. This implies that
even if we FTL compile a CodeBlock that we shouldn't have (the fact that we
compiling things that end up being inlined is dumb, and the fact that the current
FTL tiering strategy launches LLVM for those things is even dumber), we still run
at OK performance.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::transferAndCheckArguments):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCheckStructure):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileGetButterfly):
(JSC::FTL::LowerDFGToLLVM::compileGetArrayLength):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compileGetByOffset):
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowObject):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
(JSC::FTL::LowerDFGToLLVM::lowStorage):
(JSC::FTL::LowerDFGToLLVM::isNotInt32):
(JSC::FTL::LowerDFGToLLVM::isNotCell):
(JSC::FTL::LowerDFGToLLVM::isNotBoolean):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateCell):
(JSC::FTL::LowerDFGToLLVM::speculateObject):
(JSC::FTL::LowerDFGToLLVM::accountedPointer):
(JSC::FTL::LowerDFGToLLVM::weakPointer):
- ftl/FTLOutput.h:
(JSC::FTL::Output::Output):
(JSC::FTL::Output::insertNewBlocksBefore):
(JSC::FTL::Output::appendTo):
(Output):
(JSC::FTL::Output::baseIndex):
