Timeline



Apr 7, 2013:

11:53 PM Changeset in webkit [147896] by benjamin@webkit.org
  • 19 edits in trunk/LayoutTests

Regression(r147893) Caused several editing tests to fail
https://bugs.webkit.org/show_bug.cgi?id=114143

Patch by Christophe Dumez <Christophe Dumez> on 2013-04-07
Reviewed by Benjamin Poulain.

r147893 removed some Android code from WebCore but failed to update the
layout tests accordingly. This patch remove Android-specific tests from
several editing layout tests.

  • editing/deleting/paragraph-in-preserveNewline-expected.txt:
  • editing/deleting/paragraph-in-preserveNewline.html:
  • editing/deleting/whitespace-pre-1-expected.txt:
  • editing/deleting/whitespace-pre-1.html:
  • editing/execCommand/script-tests/toggle-compound-styles.js:
  • editing/execCommand/toggle-compound-styles-expected.txt:
  • editing/selection/5354455-1-expected.txt:
  • editing/selection/5354455-1.html:
  • editing/selection/click-in-margins-inside-editable-div-expected.txt:
  • editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt:
  • editing/selection/extend-after-mouse-selection-expected.txt:
  • editing/selection/extend-after-mouse-selection.html:
  • editing/selection/programmatic-selection-on-mac-is-directionless-expected.txt:
  • editing/selection/programmatic-selection-on-mac-is-directionless.html:
  • editing/selection/script-tests/click-in-margins-inside-editable-div.js:
  • editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js:
  • editing/selection/selection-extend-should-not-move-across-caret-on-mac-expected.txt:
  • editing/selection/selection-extend-should-not-move-across-caret-on-mac.html:
11:31 PM Changeset in webkit [147895] by vivek.vg@samsung.com
  • 2 edits in trunk

Modify .gitignore file to remove entries for chromium generated files
https://bugs.webkit.org/show_bug.cgi?id=114141

Reviewed by Gyuyoung Kim.

  • .gitignore:
11:20 PM Changeset in webkit [147894] by benjamin@webkit.org
  • 6 edits in trunk/Source/WTF

Remove the android code from WebKit Template Framework
https://bugs.webkit.org/show_bug.cgi?id=114138

Reviewed by Dirk Schulze.

  • wtf/Assertions.cpp:
  • wtf/Atomics.h:
  • wtf/MathExtras.h:
  • wtf/Platform.h:
  • wtf/ThreadIdentifierDataPthreads.cpp:
9:20 PM Changeset in webkit [147893] by benjamin@webkit.org
  • 11 edits in trunk/Source/WebCore

Remove the android code from WebCore
https://bugs.webkit.org/show_bug.cgi?id=114136

Reviewed by Anders Carlsson.

  • WebCore.exp.in:
  • dom/ViewportArguments.cpp:

(WebCore):
(WebCore::setViewportFeature):
(WebCore::viewportErrorMessageTemplate):
(WebCore::viewportErrorMessageLevel):

  • dom/ViewportArguments.h:

(WebCore::ViewportArguments::ViewportArguments):
(ViewportArguments):
(WebCore::ViewportArguments::operator==):

  • editing/EditingBehavior.h:

(WebCore::EditingBehavior::shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom):
(WebCore::EditingBehavior::shouldAllowSpellingSuggestionsWithoutSelection):
(WebCore::EditingBehavior::shouldNavigateBackOnBackspace):

  • editing/EditingBehaviorTypes.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureLongTap):
(WebCore::EventHandler::handleGestureForTextSelectionOrContextMenu):

  • page/Settings.cpp:

(WebCore):
(WebCore::editingBehaviorTypeForPlatform):

  • platform/graphics/FontCache.h:

(FontCache):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore::FontPlatformData::getRenderStyleForStrike):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setEditingBehavior):

9:14 PM Changeset in webkit [147892] by oliver@apple.com
  • 32 edits in trunk/Source

Add bounds checking for WTF::Vector::operator[]
https://bugs.webkit.org/show_bug.cgi?id=89600

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Make a few JSC classes opt-out of release mode bounds checking.

  • assembler/AssemblerBuffer.h:

(AssemblerBuffer):

  • assembler/AssemblerBufferWithConstantPool.h:

(AssemblerBufferWithConstantPool):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::bytecodeOffset):
(JSC):
(JSC::replaceExistingEntries):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::bytecodeOffsetForCallAtIndex):
(JSC::CodeBlock::callReturnIndexVector):
(JSC::CodeBlock::codeOrigins):
(RareData):

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedEvalCodeBlock::adoptVariables):
(UnlinkedEvalCodeBlock):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):

  • bytecompiler/BytecodeGenerator.h:

(CallArguments):
(JSC::BytecodeGenerator::instructions):
(BytecodeGenerator):

  • bytecompiler/StaticPropertyAnalysis.h:

(JSC::StaticPropertyAnalysis::create):
(JSC::StaticPropertyAnalysis::StaticPropertyAnalysis):
(StaticPropertyAnalysis):

  • bytecompiler/StaticPropertyAnalyzer.h:

(StaticPropertyAnalyzer):
(JSC::StaticPropertyAnalyzer::StaticPropertyAnalyzer):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • parser/ASTBuilder.h:

(ASTBuilder):

  • runtime/ArgList.h:

(MarkedArgumentBuffer):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncSort):

Source/WebCore:

Fix exports

  • WebCore.exp.in:

Source/WTF:

Add a template parameter to Vector<> that controls whether
bounds checking is performed in release builds or not.
Defaults to crashing on overflow.

  • wtf/Forward.h:

(WTF):

  • wtf/Vector.h:

(WTF):
(Vector):
(WTF::Vector::at):
(WTF::Vector::removeLast):
(WTF::::Vector):
(WTF::=):
(WTF::::contains):
(WTF::::find):
(WTF::::reverseFind):
(WTF::::fill):
(WTF::::appendRange):
(WTF::::expandCapacity):
(WTF::::tryExpandCapacity):
(WTF::::resize):
(WTF::::shrink):
(WTF::::grow):
(WTF::::reserveCapacity):
(WTF::::tryReserveCapacity):
(WTF::::reserveInitialCapacity):
(WTF::::shrinkCapacity):
(WTF::::append):
(WTF::::tryAppend):
(WTF::::appendSlowCase):
(WTF::::uncheckedAppend):
(WTF::::appendVector):
(WTF::::insert):
(WTF::::prepend):
(WTF::::remove):
(WTF::::reverse):
(WTF::::releaseBuffer):
(WTF::::checkConsistency):
(WTF::deleteAllValues):
(WTF::swap):
(WTF::operator==):
(WTF::operator!=):

9:10 PM Changeset in webkit [147891] by benjamin@webkit.org
  • 3 edits in trunk/LayoutTests

Remove the android part of editing/selection/rtl-move-selection-right-left.html
https://bugs.webkit.org/show_bug.cgi?id=114137

Reviewed by Anders Carlsson.

  • editing/selection/rtl-move-selection-right-left-expected.txt:
  • editing/selection/rtl-move-selection-right-left.html:
8:16 PM UnmaintainedFeatureList edited by benjamin@webkit.org
(diff)
7:55 PM UnmaintainedFeatureList edited by benjamin@webkit.org
(diff)
7:03 PM UnmaintainedFeatureList edited by timothy@apple.com
(diff)
6:38 PM UnmaintainedFeatureList created by benjamin@webkit.org
6:09 PM Changeset in webkit [147890] by benjamin@webkit.org
  • 3 edits in trunk/Websites/webkit.org

Simplify the page "Getting the Code" on WebKit.org
https://bugs.webkit.org/show_bug.cgi?id=113980

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-07
Reviewed by Sam Weinig.

  • building/checkout.html:

Instead of interleaving instructions for Mac and Windows, just
copy the things that make sense and have two clear sections.

Also mention Linux, it is the exact same instructions as Mac OS X.

Make svn checkout the alternative to a download of the tarball. It is
almost impossible to do a svn checkout on slow networks nowadays.

6:01 PM Changeset in webkit [147889] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Do not allocate static AtomicStrings when searching for alternate font names
https://bugs.webkit.org/show_bug.cgi?id=114110

Reviewed by Geoffrey Garen.

FontCache's alternateFamilyName does some font name substitutions
when a font is not found for a given name.

In the vast majority of cases, no substitutions are made and
alternateFamilyName returns the null atom.
Given the usage the function had a couple of problems:
-It created 6 static AtomicString.
-It did a case insensitive comparison with 6 differents strings

before failing.

This patch aims at solving both issues.

Instead of creating all AtomicString statically, the alternate name
are simply created on the fly as needed. Because the operation is so
unfrequent, and it uses the fast constructor, doing so should not slow
down the function.

To avoid comparing the input to every string, every time, the length of
the input is first evaluated, and we only do the necessary string comparisons.

On x86_64, this reduces the binary size by 2128 bytes.

  • platform/graphics/FontCache.cpp:

(WebCore::familyNameEqualIgnoringCase):
When comparing strings, we know:
-The family name is non null.
-The length of both strings is equal.
-The length is not null.
Make the comparison accordingly.

(WebCore::alternateFamilyName):
(WebCore::FontCache::getCachedFontPlatformData):

5:52 PM Changeset in webkit [147888] by benjamin@webkit.org
  • 77 edits
    1 delete in trunk/Source/WebCore

Remove remaining PLATFORM(CHROMIUM)-guarded code in WebCore
https://bugs.webkit.org/show_bug.cgi?id=114081

Remove the remaining PLATFORM(CHROMIUM) build guards. There are still a couple of guards
that most likely apply only to Chromium, like OS(ANDROID) or USE(SKIA_ON_MAC_CHROMIUM),
but removal of these should go into separate patches.

Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-04-07

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • config.h:
  • history/PageCache.cpp:

(WebCore):
(WebCore::logCanCacheFrameDecision):
(WebCore::logCanCachePageDecision):
(WebCore::PageCache::canCache):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::shouldAccelerate):

  • html/HTMLCanvasElement.h:
  • html/HTMLMediaElement.cpp:

(WebCore::createFileURLForApplicationCacheResource):
(WebCore::HTMLMediaElement::loadResource):

  • html/HTMLSelectElement.cpp:

(WebCore):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

  • html/MediaDocument.cpp:

(WebCore::MediaDocument::defaultEventHandler):

  • html/canvas/EXTDrawBuffers.cpp:

(WebCore::EXTDrawBuffers::satisfiesWebGLRequirements):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::create):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::platformLayer):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didBeginFrame):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::notifyFinished):

  • page/FeatureObserver.cpp:

(WebCore::FeatureObserver::~FeatureObserver):

  • platform/AsyncFileSystem.cpp:

(WebCore):

  • platform/ContextMenu.h:

(ContextMenu):

  • platform/ContextMenuItem.h:
  • platform/Cursor.h:
  • platform/DragData.cpp:

(WebCore):

  • platform/DragData.h:
  • platform/DragImage.h:
  • platform/LocalizedStrings.h:

(WebCore):

  • platform/Pasteboard.h:

(Pasteboard):

  • platform/PlatformExportMacros.h:
  • platform/PlatformInstrumentation.h:

(WebCore::PlatformInstrumentation::willDecodeImage):
(WebCore::PlatformInstrumentation::didDecodeImage):
(WebCore::PlatformInstrumentation::willResizeImage):
(WebCore::PlatformInstrumentation::didResizeImage):

  • platform/PlatformMenuDescription.h:

(WebCore):

  • platform/PlatformSpeechSynthesizer.h:

(PlatformSpeechSynthesizer):

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(PlatformWheelEvent):

  • platform/ScrollAnimator.cpp:

(WebCore):
(WebCore::ScrollAnimator::handleWheelEvent):

  • platform/ScrollAnimator.h:

(ScrollAnimator):

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::animationTimerFired):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateOverhangAreas):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scrollPositionChanged):

  • platform/Scrollbar.cpp:
  • platform/SecureTextInput.cpp: Removed.
  • platform/SecureTextInput.h:

(WebCore):

  • platform/SuddenTermination.h:

(WebCore):

  • platform/Widget.h:

(Widget):

  • platform/graphics/ANGLEWebKitBridge.h:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/FloatPoint.h:

(FloatPoint):

  • platform/graphics/FloatRect.h:

(FloatRect):

  • platform/graphics/FloatSize.h:

(FloatSize):

  • platform/graphics/Font.cpp:

(WebCore):
(WebCore::Font::width):

  • platform/graphics/Font.h:

(Font):

  • platform/graphics/FontCache.cpp:

(WebCore):

  • platform/graphics/FontCache.h:

(FontCache):

  • platform/graphics/FontDescription.h:
  • platform/graphics/FontPlatformData.cpp:
  • platform/graphics/GlyphBuffer.h:

(WebCore):
(WebCore::GlyphBuffer::add):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawImageBuffer):

  • platform/graphics/GraphicsContext3D.h:

(GraphicsContext3D):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::supportsBackgroundColorContent):

  • platform/graphics/Icon.h:

(Icon):

  • platform/graphics/ImageSource.cpp:
  • platform/graphics/ImageSource.h:

(WebCore):

  • platform/graphics/IntRect.h:

(IntRect):
(WebCore):

  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/PlatformLayer.h:
  • platform/graphics/SimpleFontData.h:

(SimpleFontData):
(DerivedFontData):

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::resizeContext):

  • platform/graphics/gpu/DrawingBuffer.h:

(WebCore):
(DrawingBuffer):

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:
  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

  • platform/image-decoders/ImageDecoder.h:
  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::open):

  • platform/network/BlobRegistry.cpp:

(WebCore::blobRegistry):

  • platform/network/BlobRegistryImpl.cpp:
  • platform/network/NetworkStateNotifier.cpp:
  • platform/network/NetworkStateNotifier.h:

(NetworkStateNotifier):

  • platform/network/NetworkingContext.h:

(NetworkingContext):

  • platform/network/ResourceHandleClient.h:
  • platform/network/ResourceRequestBase.cpp:

(WebCore):

  • platform/text/cf/HyphenationCF.cpp:
  • plugins/PluginViewNone.cpp:

(WebCore):

  • testing/Internals.cpp:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

5:43 PM Changeset in webkit [147887] by benjamin@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Use Vector::reserveInitialCapacity() when possible in JavaScriptCore runtime
https://bugs.webkit.org/show_bug.cgi?id=114111

Reviewed by Andreas Kling.

Almost all the code was already using Vector::reserveInitialCapacity()
and Vector::uncheckedAppend(). Fix the remaining parts.

  • runtime/ArgList.h:

(MarkedArgumentBuffer): The type VectorType is unused.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncSort):
Move the variable closer to where it is needed.

  • runtime/JSArray.cpp:

(JSC::JSArray::setLengthWithArrayStorage):

  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertyNames):

4:56 PM Changeset in webkit [147886] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

[EFL] --minimal build fails because of incorrect usage of GENERATE_THEME in CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=113902

Unreviewed.

Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-07

  • platform/efl/DefaultTheme/CMakeLists.txt:

Put possibly empty variable after non-empty to avoid space
at the beginning of string parameter

4:41 PM Changeset in webkit [147885] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/efl

[EFL] --minimal build fails with error: expected ;' before return'
https://bugs.webkit.org/show_bug.cgi?id=113953

Unreviewed.

Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-07

  • ewk/ewk_security_origin.cpp:

(ewk_security_origin_web_database_quota_get): Added missing semicolon.

4:00 PM Changeset in webkit [147884] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

[WIN] Fix problems with export macros of AutodrainedPool
https://bugs.webkit.org/show_bug.cgi?id=114132

Reviewed by Geoffrey Garen.

Exporting an inline function results in an error with the MS compiler.

  • wtf/AutodrainedPool.h:

(AutodrainedPool):
(WTF::AutodrainedPool::AutodrainedPool):
(WTF::AutodrainedPool::~AutodrainedPool):
(WTF::AutodrainedPool::cycle):

3:18 PM Changeset in webkit [147883] by Patrick Gansterer
  • 5 edits
    4 deletes in trunk/Source/WebCore

Add default implementation for KURL::fileSystemPath()
https://bugs.webkit.org/show_bug.cgi?id=108326

Reviewed by Benjamin Poulain.

The code for KURL::fileSystemPath() has been duplicated in different ports.
Add an implementation of this function to KURL.cpp for this ports and
get rid of the very similar port specific implementation files.

  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • PlatformWinCE.cmake:
  • platform/KURL.cpp:

(WebCore):
(WebCore::KURL::fileSystemPath):

  • platform/blackberry/KURLBlackBerry.cpp: Removed.
  • platform/efl/KURLEfl.cpp: Removed.
  • platform/wince/KURLWinCE.cpp: Removed.
  • platform/wx/KURLWx.cpp: Removed.
3:09 PM Changeset in webkit [147882] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

[WinCE] Add workaround for UNUSED_PARAM()
https://bugs.webkit.org/show_bug.cgi?id=113440

Reviewed by Benjamin Poulain.

The MSVC compiler for Windwos CE throws an error when
an function parameter is passed to UNUSED_PARAM() and
its type is only forward declared.

  • wtf/UnusedParam.h:
3:08 PM Changeset in webkit [147881] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

Do not check if WTF_ARM_ARCH_VERSION is defined in WTF_ARM_ARCH_AT_LEAST macro
https://bugs.webkit.org/show_bug.cgi?id=114127

Reviewed by Benjamin Poulain.

Platform.h defines WTF_ARM_ARCH_VERSION for CPU(ARM) always and removing
the check works around a bug in older Microsoft compiler versions.

  • wtf/Platform.h:
2:28 PM Changeset in webkit [147880] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Marked another webaudio test as flaky.

  • platform/efl/TestExpectations:
2:19 PM Changeset in webkit [147879] by Patrick Gansterer
  • 9 edits in trunk

Remove references to Skia and V8 from CMake files
https://bugs.webkit.org/show_bug.cgi?id=114130

Reviewed by Geoffrey Garen.

.:

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/WebKitPackaging.cmake:

Source/JavaScriptCore:

  • shell/PlatformBlackBerry.cmake:

Source/WebCore:

  • PlatformBlackBerry.cmake:

Source/WebKit:

  • PlatformBlackBerry.cmake:
1:56 PM Changeset in webkit [147878] by ddkilzer@apple.com
  • 21 edits in trunk

Remove the rest of SVG_DOM_OBJC_BINDINGS
<http://webkit.org/b/114112>

Reviewed by Geoffrey Garen.

.:

  • Source/autotools/SetupWebKitFeatures.m4:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
  • Remove references to ENABLE_SVG_DOM_OBJC_BINDINGS.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • Remove ENABLE_SVG_DOM_OBJC_BINDINGS macro.

Source/WebCore:

  • Configurations/WebCore.xcconfig:
  • Remove EXCLUDED_SOURCE_FILE_NAMES_SVG_DOM_OBJC_BINDINGS. Note that DOMHTMLIFrameElementPrivate.h should not have been in this list because the class contained methods other than just -getSVGDocument.
  • WebCore.xcodeproj/project.pbxproj:
  • Remove DOMHTMLFrameElementPrivate.h since the only method it contained was -[DOMHTMLFrameElement getSVGDocument], which was part of the SVG DOM Objective-C bindings.
  • bindings/objc/DOM.mm:

(kitClass):

  • bindings/objc/DOMEvents.mm:

(kitClass):

  • bindings/objc/ExceptionHandlers.mm:

(WebCore::raiseDOMException):

  • Remove code in ENABLE(SVG_DOM_OBJC_BINDINGS).

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:
  • Remove reference to SVG_DOM_OBJC_BINDINGS.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • Remove ENABLE_SVG_DOM_OBJC_BINDINGS macro.

Source/WTF:

  • wtf/FeatureDefines.h:
  • Remove ENABLE_SVG_DOM_OBJC_BINDINGS macro.

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • Remove --svg-dom-objc-bindings switch.
  • qmake/mkspecs/features/features.pri:
  • Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
1:27 PM Changeset in webkit [147877] by Christophe Dumez
  • 8 edits in trunk/LayoutTests

Unreviewed gardening.

Rebaseline several test cases that have line number information after r147872.

  • http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt:
  • http/tests/security/window-onerror-exception-in-iframe-expected.txt:
  • inspector/console/alert-toString-exception-expected.txt:
  • storage/indexeddb/exception-in-event-aborts-expected.txt:
  • storage/websql/sql-error-codes-expected.txt:
  • storage/websql/statement-error-callback-expected.txt:
  • storage/websql/transaction-callback-exception-crash-expected.txt:
1:02 PM Changeset in webkit [147876] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip a few test failing due to missing Quota API support.

  • platform/efl/TestExpectations:
12:55 PM Changeset in webkit [147875] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark a few tests as crashing on EFL port.

  • platform/efl/TestExpectations:
12:38 PM Changeset in webkit [147874] by Christophe Dumez
  • 1 edit
    5 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Generate missing baselines.

  • platform/efl/editing/pasteboard/paste-text-004-expected.png: Added.
  • platform/efl/svg/filters/feDropShadow-zero-deviation-expected.png: Added.
  • platform/efl/svg/filters/feDropShadow-zero-deviation-expected.txt: Added.
  • platform/efl/svg/filters/feGaussianBlur-zero-deviation-expected.png: Added.
  • platform/efl/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Added.
12:30 PM Changeset in webkit [147873] by Christophe Dumez
  • 8 edits
    1 add in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline several test cases.

  • platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/efl-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/efl/fast/forms/datalist/input-list-expected.txt:
  • platform/efl/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/efl/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/efl/fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
  • platform/efl/fast/js/global-constructors-expected.txt:
  • platform/efl/http/tests/inspector/console-websocket-error-expected.txt:
11:47 AM Changeset in webkit [147872] by oliver@apple.com
  • 17 edits in trunk

Inspector should display information about non-object exceptions
https://bugs.webkit.org/show_bug.cgi?id=114123

Reviewed by Adele Peterson.

Source/JavaScriptCore:

Make sure we store the right stack information, even when throwing
a primitive.

  • interpreter/CallFrame.h:

(JSC::ExecState::clearSupplementaryExceptionInfo):
(ExecState):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::throwException):

Source/WebCore:

Make use of the stack trace for line information when we're reporting
an exception

  • bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):

LayoutTests:

All these tests throw primitives as exceptions, and now they have source
and line number information

  • fast/dom/exception-getting-event-handler-expected.txt:
  • fast/dom/javascript-url-exception-isolation-expected.txt:
  • fast/dom/nested-script-exceptions-expected.txt:
  • fast/events/onerror-no-constructor-expected.txt:
  • fast/events/window-onerror13-expected.txt:
  • fast/events/window-onerror16-expected.txt:
  • fast/events/window-onerror2-expected.txt:
  • fast/events/window-onerror8-expected.txt:
  • fast/js/uncaught-exception-line-number-expected.txt:
  • fast/sub-pixel/inline-block-with-padding-expected.txt:
  • platform/mac/fast/AppleScript/001-expected.txt:
11:37 AM Changeset in webkit [147871] by robert@webkit.org
  • 3 edits
    2 adds in trunk

table element may get larger when its contents are recreated
https://bugs.webkit.org/show_bug.cgi?id=111342

Reviewed by Darin Adler.

Source/WebCore:

Remove anonymous table section wrappers when destroying their children.

Test: fast/table/anonymous-table-section-removed.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):

LayoutTests:

  • fast/table/anonymous-table-section-removed-expected.txt: Added.
  • fast/table/anonymous-table-section-removed.html: Added.
11:31 AM Changeset in webkit [147870] by Patrick Gansterer
  • 3 edits in trunk/Source/WebCore

[WIN] Fix build without precompiled header after r145827.

  • platform/ContextMenuItem.h:
  • platform/PlatformMenuDescription.h:
11:30 AM Changeset in webkit [147869] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Fix compilation of LocaleWin with !ENABLE(CALENDAR_PICKER) && !ENABLE(DATE_AND_TIME_INPUT_TYPES)

  • platform/text/win/LocaleWin.cpp:

(WebCore::LocaleWin::ensureShortMonthLabels):
(WebCore):
(WebCore::LocaleWin::ensureMonthLabels):

10:07 AM Changeset in webkit [147868] by Patrick Gansterer
  • 3 edits in trunk/Source/WebCore

[WIN] Fix build without precompiled header after r144216.

  • platform/network/cf/FormDataStreamCFNet.h:
  • platform/network/mac/FormDataStreamMac.h:
9:42 AM Changeset in webkit [147867] by commit-queue@webkit.org
  • 8 edits in trunk

Source/WebCore: [EFL] --minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
https://bugs.webkit.org/show_bug.cgi?id=114089

Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-07
Reviewed by Chris Fleizach.

Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelection):

  • editing/FrameSelection.h:

(WebCore):

Tools: [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
https://bugs.webkit.org/show_bug.cgi?id=114089

Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-07
Reviewed by Chris Fleizach.

Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)

  • DumpRenderTree/AccessibilityController.cpp:
  • DumpRenderTree/AccessibilityUIElement.cpp:
  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::DumpRenderTreeChrome):

  • DumpRenderTree/efl/DumpRenderTreeChrome.h:

(DumpRenderTreeChrome):

Apr 6, 2013:

8:52 PM Changeset in webkit [147866] by l.gombos@samsung.com
  • 4 edits in trunk/Tools

2013-04-06 Laszlo Gombos <l.gombos@samsung.com>

Build fix after r147857, remove remaining USE(JSC) guards.

Unreviewed.

  • DumpRenderTree/config.h:
  • TestWebKitAPI/config.h:
  • WebKitTestRunner/config.h:
6:59 PM Changeset in webkit [147865] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Rename sheriffbot to webkitbot
https://bugs.webkit.org/show_bug.cgi?id=114109

Reviewed by Benjamin Poulain.

Renamed since sheriffbot will be used in Blink.

  • Scripts/webkitpy/tool/commands/sheriffbot.py:

(SheriffBot):
(SheriffBot.begin_work_queue):

6:32 PM Changeset in webkit [147864] by benjamin@webkit.org
  • 1 edit
    4 deletes in trunk/Source/WebCore

Get rid of skia
https://bugs.webkit.org/show_bug.cgi?id=114108

Reviewed by Anders Carlsson.

  • platform/graphics/filters/skia/*: Removed.
  • platform/graphics/skia/*: Removed.
  • platform/image-decoders/skia/*: Removed.
  • platform/image-encoders/skia/*: Removed.
6:31 PM Changeset in webkit [147863] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove the chromium code from platform/graphics/mac
https://bugs.webkit.org/show_bug.cgi?id=114107

Reviewed by Anders Carlsson.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):

  • platform/graphics/mac/FontMac.mm:

(WebCore::hasBrokenCTFontGetVerticalTranslationsForGlyphs):

6:30 PM Changeset in webkit [147862] by benjamin@webkit.org
  • 8 edits in trunk/Source/WebCore

Clean platform/graphics/cg of the chromium bits
https://bugs.webkit.org/show_bug.cgi?id=114106

Reviewed by Anders Carlsson.

  • platform/graphics/cg/BitmapImageCG.cpp:
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::roundToDevicePixels):

  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:

(GraphicsContextPlatformPrivate):

  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/cg/ImageCG.cpp:
  • platform/graphics/cg/PathCG.cpp:
  • platform/graphics/cg/PatternCG.cpp:
4:48 PM Changeset in webkit [147861] by timothy@apple.com
  • 6 edits in trunk

Remove InjectedScriptHost.evaluateReturnsEvalFunction.

https://webkit.org/b/114099

Source/WebCore:

  • inspector/InjectedScriptHost.h:

(InjectedScriptHost):

  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js:

(InjectedScript.prototype._evaluateOn):

LayoutTests:

Reviewed by Joseph Pecoraro.

  • inspector/console/command-line-api-expected.txt:
4:40 PM Keeping the Tree Green edited by benjamin@webkit.org
(diff)
4:40 PM WebInspector edited by benjamin@webkit.org
(diff)
4:39 PM PortIntegrationArchitectureIssues edited by benjamin@webkit.org
(diff)
4:38 PM QtWebKitGardening edited by benjamin@webkit.org
(diff)
4:38 PM JavaScriptCore edited by benjamin@webkit.org
(diff)
4:38 PM NewRunWebKitTests edited by benjamin@webkit.org
(diff)
4:37 PM HackingOnNewRunWebKitTests edited by benjamin@webkit.org
(diff)
4:36 PM TestExpectations edited by benjamin@webkit.org
(diff)
4:36 PM AddingFeatures edited by benjamin@webkit.org
(diff)
4:36 PM WebKitIDL edited by benjamin@webkit.org
(diff)
4:35 PM LayoutUnit edited by benjamin@webkit.org
(diff)
4:29 PM WikiStart edited by benjamin@webkit.org
(diff)
4:23 PM Changeset in webkit [147860] by benjamin@webkit.org
  • 9 edits in trunk/Source/WebCore

Remove the chromium code from WebCore/platform/mac
https://bugs.webkit.org/show_bug.cgi?id=114104

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-06
Reviewed by Sam Weinig.

  • platform/mac/NSScrollerImpDetails.h:

(WebCore::isScrollbarOverlayAPIAvailable):

  • platform/mac/NSScrollerImpDetails.mm:
  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate layer]):
(WebCore::scrollAnimationEnabledForSystem):

  • platform/mac/ScrollElasticityController.mm:

(WebCore):

  • platform/mac/ScrollbarThemeMac.h:

(ScrollbarThemeMac):

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeMac::paint):
(WebCore):

  • platform/mac/ThemeMac.mm:

(WebCore::ThemeMac::ensuredView):

  • platform/mac/WebCoreNSCellExtras.h:
4:19 PM Changeset in webkit [147859] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove the Chromium code from Mac's FontPlatformData
https://bugs.webkit.org/show_bug.cgi?id=114103

Reviewed by Sam Weinig.

  • platform/graphics/FontPlatformData.h:

(WebCore):
(FontPlatformData):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):
(WebCore::FontPlatformData::setFont):
(WebCore::FontPlatformData::ctFont):

3:47 PM Changeset in webkit [147858] by oliver@apple.com
  • 15 edits in trunk

Unify the many and varied stack trace mechanisms, and make the result sane.
https://bugs.webkit.org/show_bug.cgi?id=114072

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Makes JSC::StackFrame record the bytecode offset and other necessary data
rather than requiring us to perform eager evaluation of the line number, etc.
Then remove most of the users of retrieveLastCaller, as most of them were
using it to create a stack trace in a fairly incomplete and inefficient way.

StackFrame now also has a couple of helpers to get the line and column info.

  • API/JSContextRef.cpp:

(JSContextCreateBacktrace):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitDebugHook):

  • interpreter/Interpreter.cpp:

(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::getBytecodeOffsetForCallFrame):
(JSC::getCallerInfo):
(JSC::StackFrame::line):
(JSC::StackFrame::column):
(JSC::StackFrame::expressionInfo):
(JSC::StackFrame::toString):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::retrieveCallerFromVMCode):

  • interpreter/Interpreter.h:

(StackFrame):
(Interpreter):

  • runtime/Error.cpp:

(JSC::throwError):

  • runtime/JSGlobalData.h:

(JSC):
(JSGlobalData):

  • runtime/JSGlobalObject.cpp:

(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):

Source/WebCore:

Now that we've fleshed out the StackFrames from Interpreter::getStackTrace
WebCore can just ask us for a stack trace rather than implementing its own
stack walking.

  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

  • inspector/ScriptCallFrame.cpp:

(WebCore::ScriptCallFrame::isEqual):

  • inspector/ScriptCallFrame.h:

(ScriptCallFrame):
(WebCore::ScriptCallFrame::columnNumber):

Tools:

The commandline jsc executable no longer requires arguments, so
I've made run-jsc work without them.

  • Scripts/run-jsc:
3:42 PM Changeset in webkit [147857] by weinig@apple.com
  • 108 edits in trunk/Source

Removed v8 bindings hooks from IDL files
https://bugs.webkit.org/show_bug.cgi?id=114091

Patch by Geoffrey Garen <ggaren@apple.com> on 2013-04-06
Reviewed by Anders Carlsson and Sam Weinig.

Source/JavaScriptCore:

  • heap/HeapStatistics.h:

Source/WebCore:

  • Modules/encryptedmedia/MediaKeySession.idl:
  • Modules/filesystem/DOMWindowFileSystem.idl:
  • Modules/filesystem/WorkerContextFileSystem.idl:
  • Modules/gamepad/NavigatorGamepad.idl:
  • Modules/geolocation/NavigatorGeolocation.idl:
  • Modules/indexeddb/DOMWindowIndexedDatabase.idl:
  • Modules/indexeddb/WorkerContextIndexedDatabase.idl:
  • Modules/mediastream/DOMWindowMediaStream.idl:
  • Modules/mediastream/NavigatorMediaStream.idl:
  • Modules/notifications/DOMWindowNotifications.idl:
  • Modules/notifications/NotificationCenter.idl:
  • Modules/notifications/WorkerContextNotifications.idl:
  • Modules/quota/DOMWindowQuota.idl:
  • Modules/speech/DOMWindowSpeech.idl:
  • Modules/webaudio/AudioBufferSourceNode.idl:
  • Modules/webaudio/AudioContext.idl:
  • Modules/webaudio/AudioParam.idl:
  • Modules/webaudio/DOMWindowWebAudio.idl:
  • Modules/webdatabase/DOMWindowWebDatabase.idl:
  • Modules/webdatabase/WorkerContextWebDatabase.idl:
  • Modules/websockets/DOMWindowWebSocket.idl:
  • Modules/websockets/WorkerContextWebSocket.idl:
  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/ScriptController.h:

(ScriptController):

  • bindings/scripts/test/TestNode.idl:
  • bindings/scripts/test/TestObj.idl:
  • css/CSSFontFaceLoadEvent.idl:
  • css/CSSHostRule.idl:
  • css/CSSRule.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSValue.idl:
  • css/FontLoader.idl:
  • css/StyleSheet.idl:
  • css/WebKitCSSRegionRule.idl:
  • dom/Clipboard.idl:
  • dom/CustomElementConstructor.idl:
  • dom/CustomEvent.idl:
  • dom/DOMNamedFlowCollection.idl:
  • dom/DOMStringMap.idl:
  • dom/DataTransferItemList.idl:
  • dom/Document.idl:
  • dom/DocumentFragment.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/EventTarget.idl:
  • dom/MessageChannel.idl:
  • dom/MouseEvent.idl:
  • dom/MutationRecord.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeList.idl:
  • dom/RequestAnimationFrameCallback.idl:
  • dom/ShadowRoot.idl:
  • dom/Text.idl:
  • history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTreeNode):
(WebCore::HistoryItem::decodeBackForwardTree):

  • html/DOMSettableTokenList.idl:
  • html/DOMTokenList.idl:
  • html/HTMLAllCollection.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLCollection.idl:
  • html/HTMLDialogElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFormControlsCollection.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLSpanElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTemplateElement.idl:
  • html/HTMLTrackElement.idl:
  • html/HTMLUnknownElement.idl:
  • html/MediaKeyError.idl:
  • html/MediaKeyEvent.idl:
  • html/MicroDataItemValue.idl:
  • html/canvas/CanvasRenderingContext2D.idl:
  • html/canvas/DOMPath.idl:
  • html/shadow/HTMLContentElement.idl:
  • html/shadow/HTMLShadowElement.idl:
  • html/track/TextTrack.idl:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorIndexedDBAgent.cpp:

(WebCore::InspectorIndexedDBAgent::requestDatabaseNames):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):
(WebCore::InspectorIndexedDBAgent::clearObjectStore):
(WebCore):

  • loader/EmptyClients.h:

(EmptyFrameLoaderClient):

  • loader/FrameLoaderClient.h:

(FrameLoaderClient):

  • page/Console.idl:
  • page/DOMWindow.idl:
  • page/DOMWindowPagePopup.idl:
  • page/History.idl:
  • page/Location.idl:
  • platform/graphics/skia/PatternSkia.cpp:

(WebCore::Pattern::platformDestroy):
(WebCore::Pattern::platformPattern):

  • testing/Internals.cpp:

(WebCore::Internals::serializeObject):
(WebCore::Internals::deserializeBuffer):

Source/WTF:

  • wtf/ArrayBuffer.h:

(WTF):
(WTF::ArrayBufferContents::ArrayBufferContents):
(WTF::ArrayBufferContents::transfer):
(ArrayBufferContents):
(ArrayBuffer):
(WTF::ArrayBufferContents::~ArrayBufferContents):

  • wtf/Platform.h:
3:05 PM Changeset in webkit [147856] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows VS2010 build fix.

  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
2:38 PM Changeset in webkit [147855] by zandobersek@gmail.com
  • 20 edits in trunk/Source

Remove the USE(SKIA_ON_MAC_CHROMIUM) guards
https://bugs.webkit.org/show_bug.cgi?id=114084

Reviewed by Ryosuke Niwa.

Source/WebCore:

Remove the USE(SKIA_ON_MAC_CHROMIUM) guards. The guards were enabled only
for the Chromium port via the features.gypi file that was removed in r147714.

  • platform/graphics/FloatPoint.h:

(FloatPoint):

  • platform/graphics/FloatRect.h:

(FloatRect):

  • platform/graphics/FloatSize.h:

(FloatSize):

  • platform/graphics/FontPlatformData.cpp:

(WebCore):

  • platform/graphics/FontPlatformData.h:

(FontPlatformData):
(WebCore::FontPlatformData::hash):

  • platform/graphics/IntPoint.h:

(IntPoint):

  • platform/graphics/IntRect.h:

(IntRect):
(WebCore):

  • platform/graphics/IntSize.h:

(IntSize):

  • platform/graphics/SimpleFontData.h:

(SimpleFontData):
(WebCore::SimpleFontData::widthForGlyph):

  • platform/graphics/cg/FloatPointCG.cpp:
  • platform/graphics/cg/FloatRectCG.cpp:
  • platform/graphics/cg/FloatSizeCG.cpp:
  • platform/graphics/cg/IntPointCG.cpp:
  • platform/graphics/cg/IntRectCG.cpp:
  • platform/graphics/cg/IntSizeCG.cpp:
  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):

  • platform/graphics/mac/FontCustomPlatformData.h:

(WebCore::FontCustomPlatformData::FontCustomPlatformData):
(FontCustomPlatformData):

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataUseFeatures.in: Remove the SKIA_ON_MAC_(CHROME|CHROMIUM) reference.
2:21 PM Changeset in webkit [147854] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] build fails with error: 'UINT_MAX' was not declared in this scope
https://bugs.webkit.org/show_bug.cgi?id=114086

Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-06
Reviewed by Tim Horton.

  • DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
2:19 PM Changeset in webkit [147853] by zandobersek@gmail.com
  • 4 edits in trunk/Tools

Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=114083

Reviewed by Ryosuke Niwa.

Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
in TestWebKitAPI and WebKitTestRunner.

  • TestWebKitAPI/config.h:
  • TestWebKitAPI/mac/InjectedBundleControllerMac.mm:

(TestWebKitAPI::InjectedBundleController::platformInitialize):

  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

(WTR::InjectedBundle::platformInitialize):

2:18 PM Changeset in webkit [147852] by zandobersek@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove the remaining PLATFORM(CHROMIUM) guard in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=114082

Reviewed by Ryosuke Niwa.

  • runtime/JSExportMacros.h: Remove the remaining PLATFORM(CHROMIUM) guard.
1:04 PM Changeset in webkit [147851] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

--minimal build fails with error: control reaches end of non-void function
https://bugs.webkit.org/show_bug.cgi?id=114085

Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-06
Reviewed by Oliver Hunt.

  • interpreter/Interpreter.cpp: return 0 if JIT is not enabled

(JSC::getBytecodeOffsetForCallFrame):

12:48 PM Changeset in webkit [147850] by robert@webkit.org
  • 5 edits in trunk

REGRESSION(r142152): Text wraps in menu
https://bugs.webkit.org/show_bug.cgi?id=113706

Reviewed by David Hyatt.

Source/WebCore:

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::inlineLogicalWidth): Empty inline elements add their inline border/padding/margin to the width of the
line when we iterate through them in nextLineBreak(), so no need to add them again here when climbing back up
from their first child looking for border/padding/margin to add. (An empty inline element can have floating children.)

LayoutTests:

  • fast/inline/inline-with-empty-inline-children-expected.txt:
  • fast/inline/inline-with-empty-inline-children.html:
12:17 PM Changeset in webkit [147849] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix the Windows build.

Added back a symbol that is exported.

11:58 AM Changeset in webkit [147848] by ggaren@apple.com
  • 3 edits in trunk/Source/WebKit2

Try to fix the WebKit2 build.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit):

  • NetworkProcess/NetworkResourceLoader.h:

(NetworkResourceLoader): Removed a defunct function.

11:54 AM Changeset in webkit [147847] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix the Windows build.

Removed symbols that aren't exported.

11:24 AM Changeset in webkit [147846] by ggaren@apple.com
  • 14 edits in trunk

Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
https://bugs.webkit.org/show_bug.cgi?id=114094

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

  • API/JSContextRef.cpp:

(JSContextCreateBacktrace):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitDebugHook):

  • interpreter/Interpreter.cpp:

(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::retrieveCallerFromVMCode):

  • interpreter/Interpreter.h:

(StackFrame):
(JSC::StackFrame::toString):
(JSC::StackFrame::friendlyLineNumber):
(Interpreter):

  • runtime/Error.cpp:

(JSC::throwError):

  • runtime/JSGlobalData.h:

(JSC):
(JSGlobalData):

  • runtime/JSGlobalObject.cpp:

(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):

Source/WebCore:

  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

  • inspector/ScriptCallFrame.cpp:

(WebCore::ScriptCallFrame::isEqual):

  • inspector/ScriptCallFrame.h:

(ScriptCallFrame):
(WebCore::ScriptCallFrame::lineNumber):

Tools:

  • Scripts/run-jsc:
11:24 AM Changeset in webkit [147845] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/wince

Unreviewed WinCE build fix after r145849.

  • WebCoreSupport/EditorClientWinCE.cpp:
11:23 AM Changeset in webkit [147844] by Patrick Gansterer
  • 4 edits in trunk/Source/WebKit

[CMake] Remove general include directories from platform specific files

Move the include directories, which are required by all CMake ports
to the general CMakeLists.txt to fix the build for Windows CE port.

  • CMakeLists.txt:
  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
11:15 AM Changeset in webkit [147843] by andersca@apple.com
  • 8 edits
    2 deletes in trunk/Source/WebCore

Remove VisitedLinks.{cpp|h}
https://bugs.webkit.org/show_bug.cgi?id=114095

Reviewed by Geoffrey Garen.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/VisitedLinks.cpp: Removed.
  • platform/VisitedLinks.h: Removed.
11:10 AM Changeset in webkit [147842] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix after r146932.

  • profiler/ProfilerDatabase.cpp:

(Profiler):

11:07 AM Changeset in webkit [147841] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Another build fix.

Actually remove the right files from WebCore.vcxproj.

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
11:03 AM Changeset in webkit [147840] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Fix build.

ThreadableLoaderClientWrapper was still calling didReceiveCachedMetadata; I didn't notice it
because the file was not in the Xcode project so I went ahead and added it.

  • WebCore.xcodeproj/project.pbxproj:
  • loader/ThreadableLoaderClientWrapper.h:
10:55 AM Changeset in webkit [147839] by andersca@apple.com
  • 19 edits
    2 deletes in trunk/Source/WebCore

Remove dead CachedMetadata code
https://bugs.webkit.org/show_bug.cgi?id=114093

Reviewed by Geoffrey Garen.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/CachedMetadata.cpp: Removed.
  • loader/CachedMetadata.h: Removed.
  • loader/ResourceLoader.h:

(ResourceLoader):

  • loader/SubresourceLoader.cpp:
  • loader/SubresourceLoader.h:

(SubresourceLoader):

  • loader/ThreadableLoaderClient.h:
  • loader/WorkerThreadableLoader.cpp:
  • loader/WorkerThreadableLoader.h:

(MainThreadBridge):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::reportMemoryUsage):

  • loader/cache/CachedResource.h:

(WebCore):
(CachedResource):

  • platform/network/ResourceHandle.cpp:
  • platform/network/ResourceHandle.h:

(ResourceHandle):

  • platform/network/ResourceHandleClient.h:

(ResourceHandleClient):

9:57 AM Changeset in webkit [147838] by andersca@apple.com
  • 7 edits
    2 deletes in trunk/Source/WebCore

Remove more dead Chromium code
https://bugs.webkit.org/show_bug.cgi?id=114090

Reviewed by Alp Toker.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/StatsCounter.cpp: Removed.
  • platform/StatsCounter.h: Removed.
3:06 AM Changeset in webkit [147837] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for WinCE after r143046.

  • platform/graphics/wince/ImageWinCE.cpp:

(WebCore::Image::drawPattern):

2:54 AM Changeset in webkit [147836] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Do not call getenv() on Windows CE where it does not exist.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

2:31 AM Changeset in webkit [147835] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

[WinCE] Do not call missing method createDragImageFromImage()
https://bugs.webkit.org/show_bug.cgi?id=110421

Patch by Mark Salisbury <mark.salisbury@hp.com> on 2013-04-06

  • platform/win/ClipboardWin.cpp:
2:22 AM Changeset in webkit [147834] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

[WinCE] Compile missing NetworkStorageSession methods
https://bugs.webkit.org/show_bug.cgi?id=110419

Patch by Mark Salisbury <mark.salisbury@hp.com> on 2013-04-05

  • PlatformWinCE.cmake:

Apr 5, 2013:

11:27 PM Changeset in webkit [147833] by ojan@chromium.org
  • 2 edits in trunk/Tools

Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=114080

Reviewed by Ryosuke Niwa.

This way, the WebKit and Blink dashboard code can change as appropriate without
needing to consider the other project's needs. This still doesn't update the
buildbots to upload to the new location, or the dashboard code to pull the
results.json files from the new location, but it at least allows for changing the
UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).

  • TestResultServer/app.yaml:
9:41 PM Changeset in webkit [147832] by kangil.han@samsung.com
  • 8 edits in trunk/Source/WebCore

Prefer prefix ++/-- operators for non-primitive types
https://bugs.webkit.org/show_bug.cgi?id=114033

Reviewed by Alexey Proskuryakov.

Post ++/-- creates a copy of current value and it is not necessary, so use prefix instead.

  • bindings/js/Dictionary.cpp:

(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
(WebCore::Dictionary::getOwnPropertyNames):

  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

  • dom/ContainerNode.cpp:

(WebCore::willRemoveChildren):

  • dom/Range.cpp:

(WebCore::Range::processAncestorsAndTheirSiblings):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::detachChildren):

  • platform/graphics/gpu/LoopBlinnPathProcessor.cpp:

(WebCore):
(WebCore::LoopBlinnPathProcessor::subdivideCurvesSlow):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDocumentMarkers):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::Function::setArguments):

9:21 PM Changeset in webkit [147831] by hmuller@adobe.com
  • 3 edits
    6 adds in trunk

[CSS Exclusions] Add support for the simple case of shape-margin polygonal shape-outside
https://bugs.webkit.org/show_bug.cgi?id=113726

Reviewed by Dirk Schulze.

Source/WebCore:

Add support for computing the shape-outside shape-margin boundary for a polygon.
This change is similar to the one added for padding polygons, see bug 112592.
The algorithm used for computing the margin boundary is is provisional. It works
correctly for convex polygons and will work correctly for non self-intersecting
polygons whose margin boundary is the same shape as the original polygon.

Tests: fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html

fast/exclusions/shape-outside-floats/shape-outside-floats-left-margin-polygon.html
fast/exclusions/shape-outside-floats/shape-outside-floats-right-margin-polygon.html

  • rendering/ExclusionPolygon.cpp:

(WebCore::appendArc): Generalized this method a little, to deal with margin and padding connecting arcs.
(WebCore::computeShapePaddingBounds): Pass the new appendArc() parameter.
(WebCore::computeShapeMarginBounds): Compute the margin boundary for a polygon, per the constraints summarized above.
(WebCore::ExclusionPolygon::getExcludedIntervals): Use the margin polygon for this computation.

LayoutTests:

Verify that shape-outside layout works correctly on floats, when shape-margin is specifed.

  • fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon-expected.txt: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-left-margin-polygon-expected.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-left-margin-polygon.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-right-margin-polygon-expected.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-right-margin-polygon.html: Added.
8:33 PM Changeset in webkit [147830] by benjamin@webkit.org
  • 2 edits
    2 adds
    7 deletes in trunk/LayoutTests

Modernize fast/events/autoscroll.html
https://bugs.webkit.org/show_bug.cgi?id=112508

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-05
Reviewed by Jer Noble.

The test fast/events/autoscroll.html was introduced in
https://bugs.webkit.org/show_bug.cgi?id=12331 (r19102) to verify the page
does not scroll when the text is selected.

It seems reasonable to test the use case with a text dump instead of a pixel test.
This should reduces the maintenance needed to keep the test useful.

  • fast/events/autoscroll.html: Removed.
  • fast/events/no-scroll-on-input-text-selection-expected.txt: Added.
  • fast/events/no-scroll-on-input-text-selection.html: Added.
  • platform/efl/fast/events/autoscroll-expected.png: Removed.
  • platform/efl/fast/events/autoscroll-expected.txt: Removed.
  • platform/gtk/fast/events/autoscroll-expected.png: Removed.
  • platform/gtk/fast/events/autoscroll-expected.txt: Removed.
  • platform/mac-wk2/TestExpectations:
  • platform/mac/fast/events/autoscroll-expected.png: Removed.
  • platform/mac/fast/events/autoscroll-expected.txt: Removed.
8:09 PM Changeset in webkit [147829] by aestes@apple.com
  • 9 edits
    4 adds in trunk

Returning NULL from willSendRequest should cancel a load from the memory cache
https://bugs.webkit.org/show_bug.cgi?id=114075

Reviewed by Darin Adler.

Source/WebCore:

When a resource is loaded from the memory cache and the client does not
implement the didLoadResourceFromMemoryCache delegate method, WebKit
synthesizes the typical sequence of resource load callbacks. One of
these is willSendRequest, which gives the client the opportunity to
modify the request. We should respect these modifications.

Handling any arbitrary modification is difficult given where in the
loading process we check the memory cache (see <http://webkit.org/b/113251>),
but we can handle the common case where the client cancels the load by
returning a NULL request.

Test: fast/loader/willsendrequest-returns-null-for-memory-cache-load.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::willLoadMediaElementURL): Passed request to sendRemainingDelegateMessages.
(WebCore::FrameLoader::commitProvisionalLoad): Ditto.
(WebCore::FrameLoader::loadResourceSynchronously): Ditto.
(WebCore::FrameLoader::loadedResourceFromMemoryCache): Added an out
parameter to pass back a request potentially modified by
requestFromDelegate, which is also passed to sendRemainingDelegateMessages.

  • loader/FrameLoader.h:
  • loader/ResourceLoadNotifier.cpp:

(WebCore::ResourceLoadNotifier::dispatchDidFailLoading): Added a
function to dispatch didFailLoading and to call the correct InspectorInstrumentation.
(WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages): If the
request is NULL, call dispatchDidFailLoading and return. This matches
the delegate callback sequence of a non memory cache load that is
cancelled by willSendRequest.

  • loader/ResourceLoadNotifier.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache):
Return false if the memory cache load is cancelled by the client.
(WebCore::CachedResourceLoader::requestResource): Return early if
shouldContinueAfterNotifyingLoadedFromMemoryCache is false.

LayoutTests:

  • fast/loader/resources/cached-image.html: Added.
  • fast/loader/willsendrequest-returns-null-for-memory-cache-load-expected.txt: Added.
  • fast/loader/willsendrequest-returns-null-for-memory-cache-load.html: Added.
  • platform/wk2/TestExpectations: Expect the test to fail in WKTR due to <http://webkit.org/b/114074>.
7:57 PM Changeset in webkit [147828] by benjamin@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Second attempt to fix the Windows bot

Unreviewed.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
7:40 PM Changeset in webkit [147827] by benjamin@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Attempt to fix the Windows bot

Unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-05

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

r147825 removed the symbol for nullptr_t. Add it back.

7:05 PM Changeset in webkit [147826] by rniwa@webkit.org
  • 4 edits in trunk/Tools

Re-enable testing on the commit queue
https://bugs.webkit.org/show_bug.cgi?id=114078

Reviewed by Darin Adler.

Re-enabled the feature and the associated tests.

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:

(CommitQueueTask.run):

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:

(CommitQueueTaskTest._run_through_task):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

(CommitQueueTest._mock_test_result):

6:22 PM Changeset in webkit [147825] by roger_fong@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Build fix.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
6:08 PM Changeset in webkit [147824] by Chris Fleizach
  • 4 edits
    1 copy
    1 add in trunk

AX: VoiceOver can't press on items
https://bugs.webkit.org/show_bug.cgi?id=114071

Reviewed by Tim Horton.

Source/WebCore:

The AXScrollToVisibleAction should not be used on earlier Mac versions because
it confuses VoiceOver.

Updated existing tests.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityActionNames]):

LayoutTests:

  • platform/mac-future/accessibility: Added.
  • platform/mac-future/accessibility/press-action-is-first-expected.txt: Added.
  • platform/mac/accessibility/press-action-is-first-expected.txt:
5:49 PM Changeset in webkit [147823] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] --no-tiled-backing-store build fails because FloatPoint is not declared
https://bugs.webkit.org/show_bug.cgi?id=113618

Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-05
Reviewed by Simon Fraser.

  • WebProcess/Plugins/Plugin.h: Forward declared FloatPoint
5:42 PM Changeset in webkit [147822] by andersca@apple.com
  • 16 edits
    3 deletes in trunk/Source

Stop building Objective-C bindings for the SVG DOM
https://bugs.webkit.org/show_bug.cgi?id=114076

Reviewed by Geoffrey Garen.

The DOM SVG Objective-C bindings have never been exposed as API, and not building them cuts WebCore build by 10%.

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • Configurations/WebCore.xcconfig:
  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:

(WebCore::createElementClassMap):
(kitClass):

  • bindings/objc/DOMCSS.mm:

(kitClass):

  • bindings/objc/DOMEvents.mm:
  • bindings/objc/DOMSVG.h: Removed.
  • bindings/objc/DOMSVGException.h: Removed.
  • bindings/objc/DOMSVGPathSegInternal.mm: Removed.
  • bindings/objc/ExceptionHandlers.mm:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLObjectElement.idl:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • MigrateHeaders.make:
5:10 PM Changeset in webkit [147821] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: DFG should better abstract arguments
https://bugs.webkit.org/show_bug.cgi?id=114073

Reviewed by Mark Hahnenberg.

  • dfg/DFGGPRInfo.h:

(GPRInfo):
(JSC::DFG::GPRInfo::toArgumentRegister):

5:07 PM Changeset in webkit [147820] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix.

5:06 PM Changeset in webkit [147819] by benjamin@webkit.org
  • 1 edit
    1 add
    7 deletes in trunk/LayoutTests

Change css1/basic/comments-expected.html to be a ref-test
https://bugs.webkit.org/show_bug.cgi?id=113996

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-05
Reviewed by Jer Noble.

The test css1/basic/comments.html verifies the handling
of comments inside a CSS declaration.

The test is changed to a ref-test by simply defining the style
directly on each element on the reference.

  • css1/basic/comments-expected.html: Added.
  • platform/efl/css1/basic/comments-expected.png: Removed.
  • platform/efl/css1/basic/comments-expected.txt: Removed.
  • platform/gtk/css1/basic/comments-expected.txt: Removed.
  • platform/mac/css1/basic/comments-expected.png: Removed.
  • platform/mac/css1/basic/comments-expected.txt: Removed.
  • platform/qt/css1/basic/comments-expected.png: Removed.
  • platform/qt/css1/basic/comments-expected.txt: Removed.
4:53 PM Changeset in webkit [147818] by oliver@apple.com
  • 14 edits in trunk

Unify the many and varied stack trace mechanisms, and make the result sane.
https://bugs.webkit.org/show_bug.cgi?id=114072

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Makes JSC::StackFrame record the bytecode offset and other necessary data
rather than requiring us to perform eager evaluation of the line number, etc.
Then remove most of the users of retrieveLastCaller, as most of them were
using it to create a stack trace in a fairly incomplete and inefficient way.

StackFrame now also has a couple of helpers to get the line and column info.

  • API/JSContextRef.cpp:

(JSContextCreateBacktrace):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitDebugHook):

  • interpreter/Interpreter.cpp:

(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::getBytecodeOffsetForCallFrame):
(JSC::getCallerInfo):
(JSC::StackFrame::line):
(JSC::StackFrame::column):
(JSC::StackFrame::expressionInfo):
(JSC::StackFrame::toString):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::retrieveCallerFromVMCode):

  • interpreter/Interpreter.h:

(StackFrame):
(Interpreter):

  • runtime/Error.cpp:

(JSC::throwError):

  • runtime/JSGlobalData.h:

(JSC):
(JSGlobalData):

  • runtime/JSGlobalObject.cpp:

(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):

Source/WebCore:

Now that we've fleshed out the StackFrames from Interpreter::getStackTrace
WebCore can just ask us for a stack trace rather than implementing its own
stack walking.

  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

  • inspector/ScriptCallFrame.cpp:

(WebCore::ScriptCallFrame::isEqual):

  • inspector/ScriptCallFrame.h:

(ScriptCallFrame):
(WebCore::ScriptCallFrame::columnNumber):

Tools:

The commandline jsc executable no longer requires arguments, so
I've made run-jsc work without them.

  • Scripts/run-jsc:
4:53 PM Changeset in webkit [147817] by Lucas Forschler
  • 5 edits in branches/safari-534.59-branch/Source

Versioning.

4:52 PM WebKitGTK/2.0.x edited by kov@webkit.org
(diff)
4:52 PM Changeset in webkit [147816] by mhahnenberg@apple.com
  • 3 edits
    3 adds in trunk

tryCacheGetByID sets StructureStubInfo accessType to an incorrect value
https://bugs.webkit.org/show_bug.cgi?id=114068

Reviewed by Geoffrey Garen.

In the case where we have a non-Value cacheable property, we set the StructureStubInfo accessType to
get_by_id_self, but then we don't patch self and instead patch in a get_by_id_self_fail. This leads to
incorrect profiling data so when the DFG compiles the function, it uses a GetByOffset rather than a GetById,
which leads to loading a GetterSetter directly out of an object.

Source/JavaScriptCore:

  • jit/JITStubs.cpp:

(JSC::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):

LayoutTests:

  • fast/js/jit-set-profiling-access-type-only-for-get-by-id-self-expected.txt: Added.
  • fast/js/jit-set-profiling-access-type-only-for-get-by-id-self.html: Added.
  • fast/js/script-tests/jit-set-profiling-access-type-only-for-get-by-id-self.js: Added.
4:51 PM Changeset in webkit [147815] by Lucas Forschler
  • 1 copy in tags/Safari-534.59.8

New Tag.

4:50 PM Changeset in webkit [147814] by kov@webkit.org
  • 1 edit
    1 add in trunk/Source/WebCore/platform/gtk/po

Translation of WebKitGTK+ for Malayalam (ml)
https://bugs.webkit.org/show_bug.cgi?id=113280

Patch by Ani Peter <peter.ani@gmail.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.

  • ml.po: Added.
4:47 PM WebKitGTK/2.0.x edited by kov@webkit.org
(diff)
4:46 PM Changeset in webkit [147813] by Lucas Forschler
  • 4 edits in branches/safari-536.29-branch/Source

Versioning.

4:44 PM Changeset in webkit [147812] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

webkit translations for gujarati
https://bugs.webkit.org/show_bug.cgi?id=113190

Patch by Sweta Kothari <swkothar@redhat.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.

  • gu.po:
4:38 PM WebKitGTK/2.0.x edited by kov@webkit.org
(diff)
4:35 PM Changeset in webkit [147811] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] [hi] Updated WebKit Translation in Hindi [hi] language
https://bugs.webkit.org/show_bug.cgi?id=113180

Patch by Rajesh Ranjan <rajeshkajha@yahoo.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.

  • hi.po:
4:30 PM Changeset in webkit [147810] by Lucas Forschler
  • 4 edits in branches/safari-536.29-branch/Source

Versioning.

4:28 PM Changeset in webkit [147809] by Lucas Forschler
  • 4 edits in tags/Safari-536.29.12/Source

Versioning.

4:26 PM Changeset in webkit [147808] by Lucas Forschler
  • 1 copy in tags/Safari-536.29.12

New Tag.

4:22 PM Changeset in webkit [147807] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] FatFingers Don't check the shadow tree for all elements.
https://bugs.webkit.org/show_bug.cgi?id=114066

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-04-05
Reviewed by Rob Buis.

BlackBerry PR 263078
Internally reviewed by Genevieve Mak.

No need to check shadow tree since sliders use touch events.

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::isElementClickable):

3:52 PM Changeset in webkit [147806] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Setting a header or footer should cause a relayout
https://bugs.webkit.org/show_bug.cgi?id=114070

Reviewed by Sam Weinig.

Mark the RenderView as needing layout in order to adjust everything for the new
header/footer.

  • page/FrameView.cpp:

(WebCore::FrameView::setHeaderHeight):
(WebCore::FrameView::setFooterHeight):

3:09 PM Changeset in webkit [147805] by Lucas Forschler
  • 10 edits in tags/Safari-537.36.1

Merged r147793. <rdar://problem/13588964>

3:07 PM Changeset in webkit [147804] by Lucas Forschler
  • 4 edits in tags/Safari-537.36.1/Source

Versioning.

3:03 PM Changeset in webkit [147803] by Lucas Forschler
  • 1 copy in tags/Safari-537.36.1

New Tag.

2:56 PM Changeset in webkit [147802] by Chris Fleizach
  • 10 edits
    4 adds in trunk

AX: Make SVG Group containers accessible elements
https://bugs.webkit.org/show_bug.cgi?id=113939

Reviewed by Simon Fraser.

Source/WebCore:

SVG group containers are currently not exposed in the AX tree.
When an SVG element has a <title> child, that is not being used for the AX label.
When hit-testing, from Accessibility, SVG groups are never returned.

All these issues are fixed for Mac and iOS.
There are two tests because right now iOS skips all the top-level accessibility tests
due to fundamental architectural differences.

Tests: accessibility/svg-group-element-with-title.html

platform/iphone-simulator/accessibility/svg-group-element-with-title.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::alternativeText):
(WebCore::AccessibilityNodeObject::accessibilityDescription):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper isSVGGroupElement]):
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
(-[WebAccessibilityObjectWrapper accessibilityClickPoint]):

  • rendering/HitTestRequest.h:

Add a new option, AccessibilityHitTest, that will allow us to override normal behavior.

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::nodeAtFloatPoint):

Allow a SVG group to be the node at a point, for accessibility hit tests.

Tools:

Implement axController.elementAtPoint for iOS.
Implement a correct version of clickPoint for iOS.

  • DumpRenderTree/ios/AccessibilityControllerIOS.mm:

(AccessibilityController::elementAtPoint):

  • DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::clickPointX):
(AccessibilityUIElement::clickPointY):

LayoutTests:

  • accessibility/svg-group-element-with-title-expected.txt: Added.
  • accessibility/svg-group-element-with-title.html: Added.
  • platform/iphone-simulator/accessibility/svg-group-element-with-title-expected.txt: Added.
  • platform/iphone-simulator/accessibility/svg-group-element-with-title.html: Added.
2:54 PM Changeset in webkit [147801] by Chris Fleizach
  • 3 edits
    2 adds in trunk

WebSpeech: event.elapsedTime is always 1364484608
https://bugs.webkit.org/show_bug.cgi?id=114045

Reviewed by Tim Horton.

Source/WebCore:

We were calculating elapsed time incorrectly.

Test: platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time.html

  • Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::fireEvent):

LayoutTests:

  • platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time-expected.txt: Added.
  • platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time.html: Added.
2:51 PM Changeset in webkit [147800] by Chris Fleizach
  • 4 edits
    2 adds in trunk

WebSpeech: crash at WebCore::SpeechSynthesis::speak
https://bugs.webkit.org/show_bug.cgi?id=113937

Reviewed by Tim Horton.

Source/WebCore:

Protect against the case when invalid data is passed in.

Test: platform/mac/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance.html

  • Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::speak):

  • Modules/speech/SpeechSynthesisUtterance.cpp:

(WebCore::SpeechSynthesisUtterance::setVoice):

LayoutTests:

  • platform/mac/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance-expected.txt: Added.
  • platform/mac/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance.html: Added.
2:47 PM Changeset in webkit [147799] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[GTK] Change from PLATFORM(GTK) to USE(GLIB) in WTF/CurrentTime.cpp
https://bugs.webkit.org/show_bug.cgi?id=114061

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2013-04-05
Reviewed by Gustavo Noronha Silva.

Now other ports using GLib can use the correct implementation
and not the fallback one without adding any other PLATFORM guards
here.

  • wtf/CurrentTime.cpp:

(WTF):

2:34 PM Changeset in webkit [147798] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

If CallFrame::trueCallFrame() knows that it's about to read garbage instead of a valid CodeOrigin/InlineCallFrame, then it should give up and return 0 and all callers should be robust against this
https://bugs.webkit.org/show_bug.cgi?id=114062

Reviewed by Oliver Hunt.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::canGetCodeOrigin):
(CodeBlock):

  • interpreter/CallFrame.cpp:

(JSC::CallFrame::trueCallFrame):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::getStackTrace):

2:19 PM Changeset in webkit [147797] by Antti Koivisto
  • 13 edits in trunk/Source/WebCore

Throttle compositing layer flushes during page loading
https://bugs.webkit.org/show_bug.cgi?id=113786

Reviewed by Simon Fraser.

Page content can change rapidly during page loading triggering excessive layer flushes and repainting. We should avoid this unnecessary work.

This patch reduces layer flushes (and painting) during loading by 50-70% on many popular pages.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadProgressingStatusChanged):

  • loader/FrameLoader.h:
  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::ProgressTracker):
(WebCore::ProgressTracker::reset):
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::finalProgressComplete):
(WebCore::ProgressTracker::isLoadProgressing):
(WebCore::ProgressTracker::progressHeartbeatTimerFired):

  • loader/ProgressTracker.h:


Track if the document load is progressing. This is done with a heartbeat timer that checks every 100ms if we have received more than 1k of data.
If four heartbeats pass without progress then we consider the load stalled.

  • page/FrameView.cpp:

(WebCore::FrameView::resetDeferredRepaintDelay):

Disable throttling temporary on user interaction so the page stays as responsive as possible even during loading.

(WebCore::FrameView::updateLayerFlushThrottling):

Enable throttling when the load is progressing, disable otherwise.

  • page/FrameView.h:
  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::canThrottleLayerFlush):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::platformCALayerDidCreateTiles):
(WebCore::GraphicsLayerCA::canThrottleLayerFlush):

Don't throttle if new tiles have been added by the tile controller. They may have stale content and need to be flushed immediately.

(WebCore::GraphicsLayerCA::noteLayerPropertyChanged):

Set the new TilesAdded change flag.

  • platform/graphics/ca/GraphicsLayerCA.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::notifyFlushRequired):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::notifyFlushRequired):
(WebCore::RenderLayerCompositor::scheduleLayerFlushNow):

Factor the actual flush scheduling to private function.

(WebCore::RenderLayerCompositor::scheduleLayerFlush):

Mark the compositor for flush and return without flushing if the flushes are currently being throttled.

(WebCore::RenderLayerCompositor::flushPendingLayerChanges):

After a flush, start the throtting timer (currently 0.5s) coalescing the subsequent flushes.

(WebCore::RenderLayerCompositor::didChangeVisibleRect):

Do immediately flush if needed.

(WebCore::RenderLayerCompositor::setLayerFlushThrottlingEnabled):

Flush immediately if disabled.

(WebCore::RenderLayerCompositor::disableLayerFlushThrottlingTemporarilyForInteraction):
(WebCore::RenderLayerCompositor::isThrottlingLayerFlushes):
(WebCore::RenderLayerCompositor::startLayerFlushTimerIfNeeded):
(WebCore::RenderLayerCompositor::layerFlushTimerFired):

Flush when the timer fires timer.

  • rendering/RenderLayerCompositor.h:
1:52 PM Changeset in webkit [147796] by benjamin@webkit.org
  • 23 edits in trunk/Source/WebCore

Clean the chromium bits of WebCore's WebDatabase
https://bugs.webkit.org/show_bug.cgi?id=114010

Reviewed by Ryosuke Niwa.

  • Modules/webdatabase/AbstractDatabaseServer.h:
  • Modules/webdatabase/ChangeVersionWrapper.cpp:

(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):

  • Modules/webdatabase/Database.cpp:
  • Modules/webdatabase/Database.h:

(Database):

  • Modules/webdatabase/DatabaseBackend.cpp:

(WebCore::DatabaseBackend::openAndVerifyVersion):

  • Modules/webdatabase/DatabaseBackendBase.cpp:

(WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
(WebCore::DatabaseBackendBase::performOpenAndVerify):
(WebCore::DatabaseBackendBase::getActualVersionForTransaction):
(WebCore::DatabaseBackendBase::incrementalVacuumIfNeeded):

  • Modules/webdatabase/DatabaseBackendBase.h:

(DatabaseBackendBase):

  • Modules/webdatabase/DatabaseBackendSync.cpp:

(WebCore::DatabaseBackendSync::openAndVerifyVersion):

  • Modules/webdatabase/DatabaseContext.cpp:

(WebCore::DatabaseContext::databaseExceededQuota):

  • Modules/webdatabase/DatabaseManager.cpp:
  • Modules/webdatabase/DatabaseManager.h:

(DatabaseManager):

  • Modules/webdatabase/DatabaseServer.cpp:

(WebCore::DatabaseServer::initialize):
(WebCore::DatabaseServer::setClient):
(WebCore::DatabaseServer::databaseDirectoryPath):
(WebCore::DatabaseServer::setDatabaseDirectoryPath):
(WebCore::DatabaseServer::openDatabase):

  • Modules/webdatabase/DatabaseServer.h:
  • Modules/webdatabase/DatabaseSync.cpp:

(WebCore::DatabaseSync::changeVersion):

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::retryCanEstablishDatabase):

  • Modules/webdatabase/DatabaseTracker.h:

(WebCore):
(DatabaseTracker):

  • Modules/webdatabase/SQLStatementBackend.cpp:

(WebCore::SQLStatementBackend::execute):
(WebCore::SQLStatementBackend::setDatabaseDeletedError):
(WebCore::SQLStatementBackend::setVersionMismatchedError):
(WebCore::SQLStatementBackend::setFailureDueToQuota):

  • Modules/webdatabase/SQLStatementBackend.h:

(SQLStatementBackend):

  • Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::deliverStatementCallback):

  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::executeSQL):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):
(WebCore::SQLTransactionBackend::runCurrentStatementAndGetNextState):
(WebCore::SQLTransactionBackend::nextStateForCurrentStatementError):
(WebCore::SQLTransactionBackend::postflightAndCommit):
(WebCore::SQLTransactionBackend::acquireOriginLock):
(WebCore::SQLTransactionBackend::releaseOriginLockIfNeeded):

  • Modules/webdatabase/SQLTransactionBackend.h:

(SQLTransactionBackend):

  • Modules/webdatabase/SQLTransactionBackendSync.cpp:

(WebCore::SQLTransactionBackendSync::begin):
(WebCore::SQLTransactionBackendSync::commit):

1:44 PM Changeset in webkit [147795] by ggaren@apple.com
  • 43 edits in trunk/Source

Made USE(JSC) unconditional
https://bugs.webkit.org/show_bug.cgi?id=114058

Reviewed by Anders Carlsson.

../JavaScriptCore:

  • config.h:

../ThirdParty:

  • gtest/include/gtest/internal/gtest-port.h:

../WebCore:

  • Modules/webdatabase/Database.cpp:
  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

  • bindings/js/JavaScriptCallFrame.cpp:
  • bindings/js/JavaScriptCallFrame.h:
  • bindings/scripts/InFilesCompiler.pm:

(generateHeadersHeader):

  • css/MediaQueryListListener.cpp:

(WebCore::MediaQueryListListener::queryChanged):

  • dom/ContainerNode.cpp:

(WebCore::dispatchChildRemovalEvents):

  • dom/EventListener.h:

(EventListener):
(WebCore::EventListener::visitJSFunction):

  • dom/EventTarget.h:

(EventTarget):
(WebCore):
(WebCore::EventTarget::visitJSEventListeners):

  • dom/Node.cpp:
  • dom/Node.h:
  • dom/ScriptExecutionContext.cpp:

(WebCore):
(WebCore::ScriptExecutionContext::globalData):

  • dom/ScriptExecutionContext.h:

(ScriptExecutionContext):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer):

  • html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::notifyFinished):

  • inspector/InjectedScriptHost.h:

(InjectedScriptHost):
(WebCore::InjectedScriptHost::evaluateReturnsEvalFunction):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):

  • page/Frame.cpp:
  • page/Settings.cpp:

(WebCore):
(WebCore::Settings::shouldRespectPriorityInCSSAttributeSetters):

  • page/Settings.h:

(Settings):

  • plugins/PluginView.cpp:

(WebCore::PluginView::start):
(WebCore::PluginView::stop):
(WebCore::PluginView::performRequest):
(WebCore::PluginView::npObject):
(WebCore):
(WebCore::PluginView::bindingInstance):
(WebCore::PluginView::privateBrowsingStateChanged):

  • plugins/PluginView.h:

(PluginView):

  • plugins/PluginViewBase.h:

(PluginViewBase):
(WebCore::PluginViewBase::scriptObject):

  • plugins/PluginViewNone.cpp:

(WebCore):
(WebCore::PluginView::bindingInstance):

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::setNPWindowIfNeeded):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::dropProtection):

../WebKit/efl:

  • ewk/ewk_frame.cpp:

(ewk_frame_script_execute):

../WebKit/qt:

  • Api/qwebscriptworld.cpp:

(QWebScriptWorld::QWebScriptWorld):

../WebKit2:

  • Shared/linux/WebMemorySamplerLinux.cpp:

(WebKit::WebMemorySampler::sampleWebKit):

  • config.h:

../WTF:

  • wtf/ThreadRestrictionVerifier.h:

(WTF):

  • wtf/WTFThreadData.cpp:

(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):

  • wtf/WTFThreadData.h:

(WTFThreadData):

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::~StringImpl):

1:41 PM Changeset in webkit [147794] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out http://trac.webkit.org/changeset/147729

It's causing a bunch of breakage on some more strict compilers:
<inline asm>:1267:2: error: ambiguous instructions require an explicit suffix (could be 'ficomps', or 'ficompl')

  • offlineasm/x86.rb:
1:38 PM Changeset in webkit [147793] by roger_fong@apple.com
  • 10 edits in trunk

Unreviewed. More VS2010 solution makefile fixes.
<rdar://problem/13588964>

  • WTF.vcxproj/WTF.make:
  • JavaScriptCore.vcxproj/JavaScriptCore.make:
  • WebCore.vcxproj/WebCore.make:
  • WebKit.vcxproj/WebKit.make:
  • win/tools/WinTools.make:
1:29 PM Changeset in webkit [147792] by commit-queue@webkit.org
  • 23 edits in trunk

[EFL] --no-tiled-backing-store build fails because of not used #if USE(ACCELERATED_COMPOSITING)
https://bugs.webkit.org/show_bug.cgi?id=113627

Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-05
Reviewed by Simon Fraser.

.:

  • Source/cmake/OptionsEfl.cmake: Disabled 3D_GRAPHICS and WEB_GL when accelerated compositing is on

Source/WebCore:

Wrapped code with #if USE(ACCELERATED_COMPOSITING) to make it compilable
with --no-tiled-backing-store build option:

  • page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::animate):

  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::animate):

  • platform/graphics/TextTrackRepresentation.cpp:

(NullTextTrackRepresentation):

  • platform/graphics/TextTrackRepresentation.h:

(TextTrackRepresentation):

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setHeaderHeight):
(WebCore::Internals::setFooterHeight):

Source/WebKit2:

Wrapped code with #if USE(ACCELERATED_COMPOSITING) to make it compilable
with --no-tiled-backing-store build option:

  • UIProcess/API/C/efl/WKView.cpp:
  • UIProcess/API/efl/EvasGLContext.cpp:
  • UIProcess/API/efl/EvasGLContext.h:
  • UIProcess/API/efl/EvasGLSurface.cpp:
  • UIProcess/API/efl/EvasGLSurface.h:
  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::displayTimerFired):
(EwkView::takeSnapshot):

  • UIProcess/API/efl/EwkView.h:

(WebKit):
(EwkView):

  • UIProcess/API/efl/SnapshotImageGL.cpp:
  • UIProcess/API/efl/SnapshotImageGL.h:
  • UIProcess/PageViewportController.cpp:
  • UIProcess/PageViewportController.h:
  • UIProcess/efl/PageViewportControllerClientEfl.cpp:
  • UIProcess/efl/ViewClientEfl.cpp:

(WebKit::ViewClientEfl::didChangeContentsSize):

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::didCommitLoad):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::didChangeViewportProperties):
(WebKit::WebView::pageDidRequestScroll):
(WebKit::WebView::didRenderFrame):
(WebKit::WebView::pageTransitionViewportReady):

1:04 PM Changeset in webkit [147791] by rniwa@webkit.org
  • 4 edits in trunk/Tools

Unreviewed, rolling out r147773 and r147774.
http://trac.webkit.org/changeset/147773
http://trac.webkit.org/changeset/147774
https://bugs.webkit.org/show_bug.cgi?id=114056

Causing some exceptions on AppEngine I don't understand
(Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-05

  • QueueStatusServer/config/queues.py:
  • QueueStatusServer/model/queues.py:

(Queue.short_name):
(Queue.display_name):

  • QueueStatusServer/model/queues_unittest.py:

(QueueTest.test_short_name):
(QueueTest.test_display_name):
(QueueTest.test_name_with_underscores):

12:55 PM Changeset in webkit [147790] by rniwa@webkit.org
  • 1 edit
    5 deletes in trunk/Source/WebCore

Remove the remaining Chromium files from WebCore
https://bugs.webkit.org/show_bug.cgi?id=114055

Reviewed by Benjamin Poulain.

Removed.

  • Resources/pagepopups/chromium: Removed.
  • Resources/pagepopups/chromium/calendarPickerChromium.css: Removed.
  • Resources/pagepopups/chromium/pickerCommonChromium.css: Removed.
  • html/shadow/MediaControlsChromium.cpp: Removed.
  • html/shadow/MediaControlsChromium.h: Removed.
  • html/shadow/MediaControlsChromiumAndroid.cpp: Removed.
  • html/shadow/MediaControlsChromiumAndroid.h: Removed.
12:49 PM Changeset in webkit [147789] by ggaren@apple.com
  • 2 edits in trunk/Tools

Fixed run-bindings-tests by removing V8
https://bugs.webkit.org/show_bug.cgi?id=114053

Reviewed by Benjamin Poulain.

  • Scripts/run-bindings-tests:

(main):

12:48 PM Changeset in webkit [147788] by rniwa@webkit.org
  • 1 edit
    6 deletes in trunk/Source/WebCore

Remove Chromium code from WebCore/css
https://bugs.webkit.org/show_bug.cgi?id=114052

Reviewed by Benjamin Poulain.

Removed.

  • css/mediaControlsChromium.css: Removed.
  • css/mediaControlsChromiumAndroid.css: Removed.
  • css/themeChromium.css: Removed.
  • css/themeChromiumAndroid.css: Removed.
  • css/themeChromiumLinux.css: Removed.
  • css/themeChromiumSkia.css: Removed.
12:45 PM Changeset in webkit [147787] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GStreamer] Segfault when attempting to install missing plugins
https://bugs.webkit.org/show_bug.cgi?id=114046

gst_install_plugins_async expects a null terminated list, but we weren't
adding a null terminator.

Patch by Brendan Long <self@brendanlong.com> on 2013-04-05
Reviewed by Philippe Normand.

No new tests since this just fixes a segfault.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

12:40 PM Changeset in webkit [147786] by benjamin@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove the chromium code for WebCore's indexeddb module
https://bugs.webkit.org/show_bug.cgi?id=114004

Reviewed by Ryosuke Niwa.

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBBackingStore::IDBBackingStore):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::close):

  • Modules/indexeddb/IDBFactoryBackendInterface.cpp:
  • Modules/indexeddb/IDBTracing.h:
12:36 PM Changeset in webkit [147785] by ggaren@apple.com
  • 1 delete in trunk/Source/WebKit/qt/v8

Removed a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I'm using a direct http commit to reduce email traffic.

12:36 PM Changeset in webkit [147784] by ggaren@apple.com
  • 1 delete in trunk/Source/WebCore/bridge/jni/v8

Removed a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I'm using a direct http commit to reduce email traffic.

12:34 PM Changeset in webkit [147783] by ggaren@apple.com
  • 1 delete in trunk/Source/WebCore/UseV8.cmake

Removed a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I'm using a direct http commit to reduce email traffic.

12:34 PM Changeset in webkit [147782] by ggaren@apple.com
  • 1 delete in trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

Removed a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I'm using a direct http commit to reduce email traffic.

12:34 PM Changeset in webkit [147781] by ggaren@apple.com
  • 1 delete in trunk/Source/WebCore/testing/v8

Removed a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I'm using a direct http commit to reduce email traffic.

12:34 PM Changeset in webkit [147780] by ggaren@apple.com
  • 1 delete in trunk/Source/WebCore/bindings/scripts/test/V8

Removed a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I'm using a direct http commit to reduce email traffic.

12:33 PM Changeset in webkit [147779] by ggaren@apple.com
  • 1 delete in trunk/Source/WebCore/bindings/v8

Removed a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I'm using a direct http commit to reduce email traffic.

12:30 PM Changeset in webkit [147778] by rniwa@webkit.org
  • 1 edit
    4 deletes in trunk/Source/WebCore

Cleanup after git svn left empty directories.

  • loader/chromium: Removed.
  • page/chromium: Removed.
  • page/scrolling/chromium: Removed.
  • plugins/chromium: Removed.
12:27 PM Changeset in webkit [147777] by rniwa@webkit.org
  • 1 edit
    1 delete in trunk/Source/WebCore

Actually delete platform/chromium.

  • platform/chromium: Removed.
12:27 PM Changeset in webkit [147776] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] --no-tiled-backing-store build fails because of not used #if USE(COORDINATED_GRAPHICS)
https://bugs.webkit.org/show_bug.cgi?id=113629

Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-05
Reviewed by Simon Fraser.

Wrapped code related to coordinated graphics with #if USE(COORDINATED_GRAPHICS)

  • UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp:
  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::initialize):
(WebKit):
(WebKit::WebView::paintToCairoSurface):
(WebKit::WebView::updateViewportSize):

12:24 PM Changeset in webkit [147775] by rniwa@webkit.org
  • 4 edits
    6 deletes in trunk/Source/WebCore

Remove Chromium code from WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=114014

Reviewed by Anders Carlsson.

Removed.

  • platform/audio/chromium: Removed.
  • platform/audio/chromium/AudioBusChromium.cpp: Removed.
  • platform/audio/chromium/AudioDestinationChromium.cpp: Removed.
  • platform/audio/chromium/AudioDestinationChromium.h: Removed.
  • platform/audio/chromium/FFTFrameOpenMAXDLAndroid.cpp: Removed.
  • platform/graphics/FontPlatformData.h:
  • platform/graphics/chromium: Removed.
  • platform/graphics/chromium/AnimationTranslationUtil.cpp: Removed.
  • platform/graphics/chromium/AnimationTranslationUtil.h: Removed.
  • platform/graphics/chromium/Canvas2DLayerBridge.cpp: Removed.
  • platform/graphics/chromium/Canvas2DLayerBridge.h: Removed.
  • platform/graphics/chromium/Canvas2DLayerManager.cpp: Removed.
  • platform/graphics/chromium/Canvas2DLayerManager.h: Removed.
  • platform/graphics/chromium/CrossProcessFontLoading.h: Removed.
  • platform/graphics/chromium/CrossProcessFontLoading.mm: Removed.
  • platform/graphics/chromium/DeferredImageDecoder.cpp: Removed.
  • platform/graphics/chromium/DeferredImageDecoder.h: Removed.
  • platform/graphics/chromium/DiscardablePixelRef.cpp: Removed.
  • platform/graphics/chromium/DiscardablePixelRef.h: Removed.
  • platform/graphics/chromium/DrawingBufferChromium.cpp: Removed.
  • platform/graphics/chromium/Extensions3DChromium.h: Removed.
  • platform/graphics/chromium/FontCacheAndroid.cpp: Removed.
  • platform/graphics/chromium/FontCacheChromiumLinux.cpp: Removed.
  • platform/graphics/chromium/FontCacheChromiumWin.cpp: Removed.
  • platform/graphics/chromium/FontChromiumWin.cpp: Removed.
  • platform/graphics/chromium/FontPlatformData.h: Removed.
  • platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: Removed.
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h: Removed.
  • platform/graphics/chromium/FontRenderStyle.h: Removed.
  • platform/graphics/chromium/FontUtilsChromiumWin.cpp: Removed.
  • platform/graphics/chromium/FontUtilsChromiumWin.h: Removed.
  • platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: Removed.
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: Removed.
  • platform/graphics/chromium/GraphicsLayerChromium.h: Removed.
  • platform/graphics/chromium/IconChromium.cpp: Removed.
  • platform/graphics/chromium/IconChromiumAndroid.cpp: Removed.
  • platform/graphics/chromium/ImageBufferDataSkia.h: Removed.
  • platform/graphics/chromium/ImageChromium.cpp: Removed.
  • platform/graphics/chromium/ImageDecodingStore.cpp: Removed.
  • platform/graphics/chromium/ImageDecodingStore.h: Removed.
  • platform/graphics/chromium/ImageFrameGenerator.cpp: Removed.
  • platform/graphics/chromium/ImageFrameGenerator.h: Removed.
  • platform/graphics/chromium/LayerPainterChromium.h: Removed.
  • platform/graphics/chromium/LazyDecodingPixelRef.cpp: Removed.
  • platform/graphics/chromium/LazyDecodingPixelRef.h: Removed.
  • platform/graphics/chromium/MediaPlayerPrivateChromium.cpp: Removed.
  • platform/graphics/chromium/MediaPlayerPrivateChromium.h: Removed.
  • platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp: Removed.
  • platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h: Removed.
  • platform/graphics/chromium/PlatformIcon.h: Removed.
  • platform/graphics/chromium/ScaledImageFragment.cpp: Removed.
  • platform/graphics/chromium/ScaledImageFragment.h: Removed.
  • platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Removed.
  • platform/graphics/chromium/SkSizeHash.h: Removed.
  • platform/graphics/chromium/TextureUploader.h: Removed.
  • platform/graphics/chromium/ThreadSafeDataTransport.cpp: Removed.
  • platform/graphics/chromium/ThreadSafeDataTransport.h: Removed.
  • platform/graphics/chromium/TransformSkMatrix44Conversions.cpp: Removed.
  • platform/graphics/chromium/TransformSkMatrix44Conversions.h: Removed.
  • platform/graphics/chromium/TransparencyWin.cpp: Removed.
  • platform/graphics/chromium/TransparencyWin.h: Removed.
  • platform/graphics/chromium/UniscribeHelper.cpp: Removed.
  • platform/graphics/chromium/UniscribeHelper.h: Removed.
  • platform/graphics/chromium/UniscribeHelperTextRun.cpp: Removed.
  • platform/graphics/chromium/UniscribeHelperTextRun.h: Removed.
  • platform/graphics/chromium/VDMXParser.cpp: Removed.
  • platform/graphics/chromium/VDMXParser.h: Removed.
  • platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore):

  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3DImpl::getOrCreateContext):

  • platform/mediastream/chromium: Removed.
  • platform/mediastream/chromium/MediaStreamCenterChromium.cpp: Removed.
  • platform/mediastream/chromium/MediaStreamCenterChromium.h: Removed.
  • platform/mediastream/chromium/RTCDTMFSenderHandlerChromium.cpp: Removed.
  • platform/mediastream/chromium/RTCDTMFSenderHandlerChromium.h: Removed.
  • platform/mediastream/chromium/RTCDataChannelHandlerChromium.cpp: Removed.
  • platform/mediastream/chromium/RTCDataChannelHandlerChromium.h: Removed.
  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp: Removed.
  • platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h: Removed.
  • platform/network/chromium: Removed.
  • platform/network/chromium/AuthenticationChallenge.h: Removed.
  • platform/network/chromium/AuthenticationChallengeChromium.cpp: Removed.
  • platform/network/chromium/BlobRegistryProxy.cpp: Removed.
  • platform/network/chromium/BlobRegistryProxy.h: Removed.
  • platform/network/chromium/CookieJarChromium.cpp: Removed.
  • platform/network/chromium/DNSChromium.cpp: Removed.
  • platform/network/chromium/ResourceError.h: Removed.
  • platform/network/chromium/ResourceHandle.cpp: Removed.
  • platform/network/chromium/ResourceHandleInternal.h: Removed.
  • platform/network/chromium/ResourceRequest.cpp: Removed.
  • platform/network/chromium/ResourceRequest.h: Removed.
  • platform/network/chromium/ResourceResponse.cpp: Removed.
  • platform/network/chromium/ResourceResponse.h: Removed.
  • platform/network/chromium/SocketStreamError.h: Removed.
  • platform/network/chromium/SocketStreamHandle.cpp: Removed.
  • platform/network/chromium/SocketStreamHandle.h: Removed.
  • platform/network/chromium/SocketStreamHandleInternal.h: Removed.
  • platform/sql/chromium: Removed.
  • platform/sql/chromium/SQLiteFileSystemChromium.cpp: Removed.
  • platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: Removed.
  • platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: Removed.
  • platform/text/chromium: Removed.
  • platform/text/chromium/Hyphenation.cpp: Removed.
  • platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp: Removed.
12:17 PM Changeset in webkit [147774] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix.

  • QueueStatusServer/model/queues.py:

(Queue.short_name):
(Queue.display_name):

12:08 PM Changeset in webkit [147773] by rniwa@webkit.org
  • 4 edits in trunk/Tools

Remove Chromium EWS bots from the queue status server
https://bugs.webkit.org/show_bug.cgi?id=113988

Reviewed by Benjamin Poulain.

Removed Chromium EWS bots.

  • QueueStatusServer/config/queues.py:
  • QueueStatusServer/model/queues.py:

(Queue.short_name):
(Queue.display_name):

  • QueueStatusServer/model/queues_unittest.py:

(QueueTest.test_short_name):
(QueueTest.test_display_name):
(QueueTest.test_name_with_underscores):

11:57 AM Changeset in webkit [147772] by rniwa@webkit.org
  • 2 edits
    1 delete in trunk/Source/WebCore

Remove Chromium code from WebCore/workers
https://bugs.webkit.org/show_bug.cgi?id=114050

Reviewed by Anders Carlsson.

Removed.

  • workers/WorkerLoaderProxy.h:

(WorkerLoaderProxy):

  • workers/chromium: Removed.
11:54 AM Changeset in webkit [147771] by rniwa@webkit.org
  • 2 edits
    1 delete in trunk/Source/WebCore

Remove Chromium code from WebCore/storage
https://bugs.webkit.org/show_bug.cgi?id=114049

Reviewed by Anders Carlsson.

Removed.

  • storage/StorageNamespace.cpp:
  • storage/chromium: Removed.
11:48 AM Changeset in webkit [147770] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.9/Source/WebCore

Merged r147664. <rdar://problem/13579024>

11:42 AM Changeset in webkit [147769] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[SOUP] Remove unnecessary explicit keyword in SocketStreamError.h
https://bugs.webkit.org/show_bug.cgi?id=113913

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-05
Reviewed by Martin Robinson.

No new tests, just removing an unnecessary code.

  • platform/network/soup/SocketStreamError.h:

(WebCore::SocketStreamError::SocketStreamError):

11:39 AM Changeset in webkit [147768] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL] Enable indexed database
https://bugs.webkit.org/show_bug.cgi?id=107248

Patch by Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> on 2013-04-05
Reviewed by Alexis Menard.

.:

  • Source/cmake/OptionsEfl.cmake:

Tools:

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
11:35 AM Changeset in webkit [147767] by Dimitri Glazkov
  • 2 edits in trunk/Tools

Remove vestiges of Chromium bits from watchlists.
https://bugs.webkit.org/show_bug.cgi?id=114047

Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/common/config/watchlist: Removed vestiges.
11:18 AM Changeset in webkit [147766] by commit-queue@webkit.org
  • 6 edits
    2 deletes in trunk/Source

Remove WTF_USE_GOOGLEURL-guarded code
https://bugs.webkit.org/show_bug.cgi?id=114028

Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-04-05
Reviewed by Ryosuke Niwa.

Source/WebCore:

The only remaining usage of the USE(GOOGLEURL) guards is in LinkHashChromium.cpp that will
get removed when purging the Source/WebCore/platform/chromium directory.

  • config.h: Remove the define that was Chromium-specific.
  • platform/KURL.cpp:

(WebCore):
(WebCore::KURL::reportMemoryUsage):
(WebCore::KURL::isSafeToSendToAnotherThread):

  • platform/KURL.h:

(KURL):

  • platform/KURLGoogle.cpp: Removed.
  • platform/KURLGooglePrivate.h: Removed.

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataUseFeatures.in: Remove GOOGLEURL from the list.
11:13 AM Changeset in webkit [147765] by zoltan@webkit.org
  • 3 edits
    2 adds in trunk

[regression] Security: Heap-use-after-free in WebCore::RenderBlock::logicalRightOffsetForLine
https://bugs.webkit.org/show_bug.cgi?id=111594

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-04-05
Reviewed by David Hyatt.

Source/WebCore:

Swapping the bases was causing any floats in the right base to be
lost, so change the code so that it no longer swaps the bases.

Test: fast/ruby/float-object-doesnt-crash.html

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::removeChild): Don't swap the bases anymore.

LayoutTests:

Add test to verify that the use-after-free is fixed. Note that it will
only crash when run under a memory checking tool like ASAN.

  • fast/ruby/float-object-doesnt-crash-expected.txt: Added.
  • fast/ruby/float-object-doesnt-crash.html: Added.
11:03 AM Changeset in webkit [147764] by Lucas Forschler
  • 4 edits in tags/Safari-537.35.9/Source

Versioning.

10:56 AM Changeset in webkit [147763] by Lucas Forschler
  • 1 copy in tags/Safari-537.35.9

New Tag.

10:54 AM Changeset in webkit [147762] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Remove dead code
https://bugs.webkit.org/show_bug.cgi?id=114043

Reviewed by Beth Dakin.

  • platform/PublicSuffix.h:
10:48 AM Changeset in webkit [147761] by andersca@apple.com
  • 7 edits
    2 deletes in trunk/Source/WebCore

Remove dead Chromium code from WebCore/workers
https://bugs.webkit.org/show_bug.cgi?id=114039

Reviewed by Antti Koivisto.

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::importScripts):

  • workers/WorkerLoaderProxy.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerContextProxy::create):

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::WorkerScriptLoader):
(WebCore::WorkerScriptLoader::createResourceRequest):

  • workers/WorkerScriptLoader.h:
  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):

  • workers/chromium/WorkerContextProxyChromium.cpp: Removed.
  • workers/chromium/WorkerContextProxyChromium.h: Removed.
10:44 AM Changeset in webkit [147760] by rniwa@webkit.org
  • 1 edit
    4 deletes in trunk/Source/WebCore

Remove Chromium code from WebCore/plugins
https://bugs.webkit.org/show_bug.cgi?id=114015

Reviewed by Andreas Kling.

Removed.

  • plugins/chromium: Removed.
  • plugins/chromium/PluginDataChromium.cpp: Removed.
  • plugins/chromium/PluginDataChromium.h: Removed.
  • plugins/chromium/PluginListBuilder.cpp: Removed.
  • plugins/chromium/PluginListBuilder.h: Removed.
10:36 AM Changeset in webkit [147759] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

ASSERTION FAILED: m_repaintRect == renderer()->clippedOverflowRectForRepaint(renderer()->containerForRepaint()) after r135816
https://bugs.webkit.org/show_bug.cgi?id=103432

Reviewed by Allan Sandfeld Jensen.

Remove optimization added in r99752 that attempted to avoid clip rect
updates for table cells. As the assertions show, this optimization
is not always correct, so remove it. Bug 108272 tracks adding it back in.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll): Remove m_canSkipRepaintRectsUpdateOnScroll
check when updating clip rects.

  • rendering/RenderLayer.h: Remove the m_canSkipRepaintRectsUpdateOnScroll bit.
10:30 AM Changeset in webkit [147758] by betravis@adobe.com
  • 12 edits in trunk

[css exclusions] Dynamically removing shape-inside should cause relayout of child blocks' inline content
https://bugs.webkit.org/show_bug.cgi?id=111029

Reviewed by David Hyatt.

Source/WebCore:

Preserve a removed ExclusionShapeInsideInfo for one additional layout pass
so that it can notify descendant inline content to relayout. This patch adds
a new 'needsRemoval' boolean to ExclusionShapeInsideInfo, which is set when
a style change removes but does not replace a shape-inside. When determining
whether a block needs to relayout inline children, ExclusionShapeInsideInfos with
the needsRemoval boolean set are included, but at other times (such as during
inline layout), they are ignored.

Added tests to the existing dynamic shape testfile
fast/exclusions/shape-inside/shape-inside-dynamic-nested.html

  • rendering/ExclusionShapeInsideInfo.h:

(WebCore::ExclusionShapeInsideInfo::setNeedsRemoval): Get/Set the
needsRemoval boolean.
(WebCore::ExclusionShapeInsideInfo::needsRemoval): Ditto.
(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::ExclusionShapeInsideInfo):
Initialize the needsRemoval boolean.

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState): Propagate removed shape insides
for layout correctly. You only need to track one at a time, and a
removed shape inside should not take precedence over a set shape-inside.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange):
Set the ExclusionShapeInsideInfo needsRemoval boolean, rather than immediately
removing the info.
(WebCore::exclusionInfoRequiresRelayout): Account for the needsRemoval
boolean as another way of requiring relayout.
(WebCore::RenderBlock::updateRegionsAndExclusionsBeforeChildLayout):
Look up whether an ExclusionShapeInsideInfo has been removed.
(WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout):
Remove any ExclusionShapeInsides marked for removal after a layout pass.
(WebCore):
(WebCore::RenderBlock::layoutBlock): Call the new updateRegionsAndExclusions
Before/After methods.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::exclusionShapeInsideInfo): Filter the result based
on whether it should include removed infos.
(RenderBlock):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutExclusionShapeInsideInfo): Ditto.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
Same as RenderBlock::layoutBlock.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock): Ditto.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock): Ditto.

LayoutTests:

Test that removed shape-insides correctly cause relayout in their blocks'
inline content.

  • fast/exclusions/shape-inside/shape-inside-dynamic-nested-expected.html:
  • fast/exclusions/shape-inside/shape-inside-dynamic-nested.html:
10:28 AM Changeset in webkit [147757] by Chris Fleizach
  • 2 edits in trunk/Tools

Add James Craig to the contributors list.

  • Scripts/webkitpy/common/config/committers.py:
10:15 AM Changeset in webkit [147756] by commit-queue@webkit.org
  • 15 edits
    6 adds in trunk

[CSS Regions] Elements in a region should be assignable to a named flow
https://bugs.webkit.org/show_bug.cgi?id=74144

Patch by Mihai Maerean <Mihai Maerean> on 2013-04-05
Reviewed by David Hyatt.

Source/WebCore:

DOM children of a region must not be rendered as children of the region, but can be collected in flow threads.

NodeRenderingContext::parentRenderer now creates the parent render flow thread if it doesn't exist.

Element::moveToFlowThreadIsNeeded is a virtual method that is overriden in PseudoElement to return false and
in SVGElement so only svg root elements can directly be collected by a render flow thread.

RenderObject::canDOMChildrenHaveRenderParent exists to optimize the code so nodes inside regions (and maybe
other types of renderers in the future) can still have renderers if they need to be in a flow thread while the
rest of renderers that can't have children skip the new instructions.

Tests: fast/regions/flow-body-in-html.html . To test the duplicate bug #103685.

fast/regions/region-content-flown-into-region.html
fast/regions/universal-selector-children-to-the-same-region.html . To test the duplicate bug #103685.

  • dom/Element.cpp:

(WebCore::Element::moveToFlowThreadIsNeeded):

  • dom/Element.h:
  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::parentRenderer): the renderer that will be the parent for this node's renderer.
In the case of RenderFlowThreads, it may need to create it.
(WebCore::NodeRenderingContext::shouldCreateRenderer): In a region, only the children that need to be in a flow
thread should have a renderer.
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRenderingContext::moveToFlowThread):

  • dom/NodeRenderingContext.h:

(NodeRenderingContext):

  • dom/PseudoElement.h: pseudo-elements cannot be directly collected into a named flow.
  • dom/Text.cpp:

(WebCore::Text::textRendererIsNeeded):
(WebCore::Text::updateTextRenderer): Because calling textRendererIsNeeded(NodeRenderingContext(...)) on a
non-const l-value NodeRenderingContext cannot be done on a temporary object on the stack.

  • dom/Text.h:
  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::isContentNodeRegisteredWithAnyNamedFlow):

  • rendering/FlowThreadController.h:
  • rendering/RenderObject.h:

(WebCore::RenderObject::canDOMChildrenHaveRenderParent): Even if this render object can't have render children,
the children in the DOM tree may have a render parent (that is different from this render object).

  • rendering/RenderRegion.h:
  • svg/SVGElement.cpp:

(WebCore::SVGElement::moveToFlowThreadIsNeeded): Allow only svg root elements to be directly collected by a
render flow thread.

  • svg/SVGElement.h:

(SVGElement):

LayoutTests:

  • fast/regions/flow-body-in-html-expected.txt: Added.
  • fast/regions/flow-body-in-html.html: Added. To test the duplicate bug #103685.
  • fast/regions/region-content-flown-into-region-expected.html: Added.
  • fast/regions/region-content-flown-into-region.html: Added.
  • fast/regions/universal-selector-children-to-the-same-region-expected.txt: Added.
  • fast/regions/universal-selector-children-to-the-same-region.html: Added. To test the duplicate bug #103685.
9:51 AM Changeset in webkit [147755] by andersca@apple.com
  • 6 edits in trunk/Source/WTF

Remove more dead Chromium code from WTF
https://bugs.webkit.org/show_bug.cgi?id=114037

Reviewed by Allan Sandfeld Jensen.

  • wtf/CurrentTime.cpp:

(WTF):

  • wtf/DisallowCType.h:
  • wtf/ExportMacros.h:
  • wtf/MainThread.cpp:
  • wtf/Platform.h:
9:40 AM Changeset in webkit [147754] by timothy@apple.com
  • 4 edits in trunk/Source

Allow the Web Inspector to use WebSQL.

This fixes an exception on load in the Safari Web Inspector.

https://webkit.org/b/114040
rdar://problem/13581422

Reviewed by Anders Carlsson.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Added.

Source/WebKit2:

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::exceededDatabaseQuota): Added.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Hook up exceededDatabaseQuota.

9:40 AM Changeset in webkit [147753] by Lucas Forschler
  • 1 copy in tags/Safari-536.29.11

New Tag.

9:26 AM Changeset in webkit [147752] by beidson@apple.com
  • 5 edits in trunk/Source/WebKit2

Add SPI to get a copy of the context menu at a given point.
<rdar://problem/13450908> and https://bugs.webkit.org/show_bug.cgi?id=113958

Reviewed by Andy Estes.

Add the new accessor:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::contextMenuAtPoint):

  • WebProcess/WebPage/WebPage.h:

Expose the new SPI:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCopyContextMenuAtPoint):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
9:13 AM Changeset in webkit [147751] by allan.jensen@digia.com
  • 5 edits in trunk/Source/WebCore

Fix GCC with C++11 build
https://bugs.webkit.org/show_bug.cgi?id=111579

Reviewed by Anders Carlsson.

If the destructor is private, MemoryInstrumentation can not create an inherited class.

  • css/PropertySetCSSStyleDeclaration.h:

(StyleRuleCSSStyleDeclaration):

  • dom/ShadowRoot.h:

(ShadowRoot):

  • loader/SubresourceLoader.h:

(SubresourceLoader):

  • platform/Timer.h:
8:52 AM Changeset in webkit [147750] by allan.jensen@digia.com
  • 11 edits in trunk/Source/WebCore

[Qt] Create ShadowBlur on demand.
https://bugs.webkit.org/show_bug.cgi?id=113506

Reviewed by Noam Rosenthal.

This patch creates ShadowBlur objects on demand instead of keeping a single one alive for
each GraphicsContext. This matches what other platforms does and fixes the problem with
an active shadowblur being affected by changing shadow settings on the GraphicsContext.

The method mustUseShadowBlur is moved from ShadowBlur to GraphcisContext, so that it can
be used to determine if a ShadowBlur object should even be generated.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::hasBlurredShadow):
(WebCore::GraphicsContext::mustUseShadowBlur):

  • platform/graphics/GraphicsContext.h:

(GraphicsContext):

  • platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::ShadowBlur):

  • platform/graphics/ShadowBlur.h:
  • platform/graphics/cairo/FontCairo.cpp:

(WebCore::drawGlyphsShadow):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):

  • platform/graphics/qt/FontQt.cpp:

(WebCore::drawQtGlyphRun):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::clearPlatformShadow):

  • platform/graphics/qt/ImageQt.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/qt/StillImageQt.cpp:

(WebCore::StillImage::draw):

8:49 AM Changeset in webkit [147749] by rniwa@webkit.org
  • 12 edits
    5 deletes in trunk/Source/WebCore

Remove Chromium code from WebCore/page
https://bugs.webkit.org/show_bug.cgi?id=114013

Reviewed by Anders Carlsson.

Removed.

  • page/Console.cpp:

(WebCore::Console::time):
(WebCore::Console::timeEnd):

  • page/EventHandler.cpp:

(WebCore::shouldGesturesTriggerActive):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore):
(WebCore::EventHandler::sendScrollEventToView):

  • page/FeatureObserver.cpp:

(WebCore::FeatureObserver::updateMeasurements):

  • page/FrameView.cpp:

(WebCore::FrameView::layout):
(WebCore::FrameView::useSlowRepaints):

  • page/PageConsole.cpp:
  • page/PageGroup.cpp:

(WebCore::PageGroup::isLinkVisited):
(WebCore::PageGroup::addVisitedLink):

  • page/Settings.cpp:

(WebCore):

  • page/android: Removed.
  • page/chromium: Removed.
  • page/chromium/ChromeClientChromium.h: Removed.
  • page/chromium/DragControllerChromium.cpp: Removed.
  • page/chromium/EventHandlerChromium.cpp: Removed.
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::create):
(WebCore):

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

  • page/scrolling/ScrollingTree.cpp:

(WebCore):

  • page/scrolling/ScrollingTree.h:

(ScrollingTree):

  • page/scrolling/chromium: Removed.
  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp: Removed.
  • page/scrolling/chromium/ScrollingCoordinatorChromium.h: Removed.
8:45 AM Changeset in webkit [147748] by rniwa@webkit.org
  • 7 edits
    18 deletes in trunk/Source/WebCore

Remove Chromium code from WebCore/rendering
https://bugs.webkit.org/show_bug.cgi?id=114017

Reviewed by Simon Fraser.

Removed.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::requiresHorizontalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresVerticalScrollbarLayer):
(WebCore::RenderLayerBacking::requiresScrollCornerLayer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::paintContents):
(WebCore::shouldCompositeOverflowControls):
(WebCore::RenderLayerCompositor::requiresOverhangAreasLayer):

  • rendering/RenderMediaControlsChromium.cpp: Removed.
  • rendering/RenderMediaControlsChromium.h: Removed.
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::shouldRespectImageOrientation):

  • rendering/RenderText.cpp:

(WebCore):
(WebCore::RenderText::previousOffsetForBackwardDeletion):

  • rendering/RenderThemeChromiumAndroid.cpp: Removed.
  • rendering/RenderThemeChromiumAndroid.h: Removed.
  • rendering/RenderThemeChromiumCommon.cpp: Removed.
  • rendering/RenderThemeChromiumCommon.h: Removed.
  • rendering/RenderThemeChromiumDefault.cpp: Removed.
  • rendering/RenderThemeChromiumDefault.h: Removed.
  • rendering/RenderThemeChromiumFontProvider.cpp: Removed.
  • rendering/RenderThemeChromiumFontProvider.h: Removed.
  • rendering/RenderThemeChromiumFontProviderLinux.cpp: Removed.
  • rendering/RenderThemeChromiumFontProviderWin.cpp: Removed.
  • rendering/RenderThemeChromiumMac.h: Removed.
  • rendering/RenderThemeChromiumMac.mm: Removed.
  • rendering/RenderThemeChromiumSkia.cpp: Removed.
  • rendering/RenderThemeChromiumSkia.h: Removed.
  • rendering/RenderThemeChromiumWin.cpp: Removed.
  • rendering/RenderThemeChromiumWin.h: Removed.
  • rendering/RenderThemeMacShared.mm:

(WebCore::RenderThemeMacShared::paintSliderThumb):

8:26 AM Changeset in webkit [147747] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Blitting wrong rect during history navigations
https://bugs.webkit.org/show_bug.cgi?id=113963

Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.

On www.bbc.com/news, we blit wrong rect during the second restoration
of the view states when we navigate back from stories to the main page.
Update the contents size and scroll position before we render and blit
if we failed to zoomAboutPoint so that UI thread can still get the
correct rect during blit.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):

7:50 AM Changeset in webkit [147746] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Texmap] css3/filters/filter-animation-from-none-hw.html does not animate
https://bugs.webkit.org/show_bug.cgi?id=114026

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-05
Reviewed by Allan Sandfeld Jensen.

Allow the filter's blending function to take place when animating from/to none.

  • platform/graphics/GraphicsLayerAnimation.cpp:

(WebCore::applyFilterAnimation):

7:47 AM Changeset in webkit [147745] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CoordGfx] Enable filter animations
https://bugs.webkit.org/show_bug.cgi?id=114027

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-05
Reviewed by Allan Sandfeld Jensen.

Allow CoordinatedGraphicsLayer to serialize filter animations to the UI process.

Covered by animation tests in css3/filters.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::addAnimation):

7:45 AM Changeset in webkit [147744] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Replace map{From,To}Transformed() with ViewportAccessor
https://bugs.webkit.org/show_bug.cgi?id=113449

Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-04-05
Reviewed by Rob Buis.

This removes the WebPage/BackingStoreClient family of coordinate
transformation functions, which were widely disliked for their
naming, with ViewportAccessor API that had previously been
introduced for limited use cases. This commit takes care of the
remaining call sites and leaves us with a single API to use.

No new tests, only a clean-up/refactor of existing code & functionality.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::slowScroll):
(BlackBerry::WebKit::BackingStorePrivate::visibleContentsRect):
(BlackBerry::WebKit::BackingStorePrivate::unclippedVisibleContentsRect):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::expandedContentsSize):

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::clipToRect):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::scrollPosition):
(BlackBerry::WebKit::WebPagePrivate::maximumScrollPosition):
(BlackBerry::WebKit::WebPagePrivate::setScrollPosition):
(BlackBerry::WebKit::WebPagePrivate::viewportSize):
(BlackBerry::WebKit::WebPagePrivate::actualVisibleSize):
(BlackBerry::WebKit::WebPagePrivate::layoutFinished):
(BlackBerry::WebKit::WebPagePrivate::notifyTransformedContentsSizeChanged):
(BlackBerry::WebKit::WebPagePrivate::updateCursor):
(BlackBerry::WebKit::WebPagePrivate::focusNodeRect):
(BlackBerry::WebKit::WebPagePrivate::contextNode):
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
(BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::blockZoom):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebKitSupport/BackingStoreClient.cpp:

(BlackBerry::WebKit::BackingStoreClient::transformedScrollPosition):
(BlackBerry::WebKit::BackingStoreClient::transformedMaximumScrollPosition):
(BlackBerry::WebKit::BackingStoreClient::actualVisibleSize):
(BlackBerry::WebKit::BackingStoreClient::transformedActualVisibleSize):

  • WebKitSupport/BackingStoreClient.h:

(BackingStoreClient):

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::fingerRectForPoint):
(BlackBerry::WebKit::FatFingers::FatFingers):
(BlackBerry::WebKit::FatFingers::findBestPoint):
(BlackBerry::WebKit::FatFingers::findIntersectingRegions):
(BlackBerry::WebKit::FatFingers::getNodesFromRect):

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::sendClickAtFatFingersPoint):
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
(BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):

  • WebKitSupport/WebKitThreadViewportAccessor.cpp:

(BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelContentsSize):
(BlackBerry::WebKit::WebKitThreadViewportAccessor::pixelScrollPosition):
(BlackBerry::WebKit::WebKitThreadViewportAccessor::documentViewportSize):

6:42 AM Changeset in webkit [147743] by rakuco@webkit.org
  • 2 edits in trunk/Source/WTF

[EFL] Disable GLOBAL_FAST_MALLOC_NEW by default.
https://bugs.webkit.org/show_bug.cgi?id=114031

Reviewed by Alexis Menard.

Follow what some other ports already do and avoid globally overriding
the new' and delete' operators with the ones in FastMalloc.

In many cases, third-party or client code allocates memory with
standard library calls but the memory gets deleted by FastMalloc,
causing a crash. The reverse (ie. memory being allocated by FastMalloc
and freed by the system libraries) is also possible.

Commits 135666 and 121018 provide more information about this, as well
as comment 6 in bug 89358.

  • wtf/Platform.h:
6:26 AM Changeset in webkit [147742] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

Avoid double hash table lookups in TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=114030

Reviewed by Noam Rosenthal.

Use Vector::add() and leverage its returned AddResult value instead of
calling Vector::find() then Vector::set() if the key does not already
exist in the map. This results in a single hash lookup instead of two
in this case.

No new tests, no behavior change.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGLData::SharedGLData::getShaderProgram):
(WebCore::TextureMapperGLData::getStaticVBO):
(WebCore::TextureMapperGL::drawUsingCustomFilter):

6:17 AM Changeset in webkit [147741] by mikhail.pozdnyakov@intel.com
  • 8 edits in trunk/Source/WebKit2

[WK2][EFL] WebView should own page position and scale factor
https://bugs.webkit.org/show_bug.cgi?id=111075

Reviewed by Andreas Kling.

View content position and content scale factor should belong to WebView
rather than to EwkView as it decreases EwkView usage inside EFL-agnostic
WebView and improves WebView encapsulation.

  • UIProcess/API/C/efl/WKView.cpp:

(WKViewGetContentScaleFactor):
(WKViewSetContentScaleFactor):

New WKView API was added to set and get content scale factor.
The view content scale factor is not the same as page scale factor:
it always applies to content but not necessarily applies to the page.
The view content scale factor is calculated by viewport controller
and applies immediately for painting in UI process. Page scale factor
is updated later after the frame is rendered to accomplish the pending
scale change.

(WKViewGetContentPosition):
(WKViewSetContentPosition):

New WKView API was added to set and get content position.
Content position is set in UI units.

  • UIProcess/API/C/efl/WKView.h:
  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):

  • UIProcess/API/efl/EwkView.h:

(EwkView):

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::setViewportPosition):
(WebKit::PageViewportControllerClientEfl::setPageScaleFactor):

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::WebView):
(WebKit::WebView::paintToCairoSurface):
(WebKit::WebView::transformToScene):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::pageDidRequestScroll):

  • UIProcess/efl/WebView.h:

(WebKit::WebView::setContentScaleFactor):
(WebKit::WebView::contentScaleFactor):
(WebView):
(WebKit::WebView::setContentPosition):
(WebKit::WebView::contentPosition):

5:50 AM Changeset in webkit [147740] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove unused parameters from notifyAnimationStarted() and paintContents()
https://bugs.webkit.org/show_bug.cgi?id=114022

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-05
Reviewed by Carlos Garcia Campos.

Naming the 'time' and 'inClip' unused parameters only produces
compiler warnings.

  • Api/WebOverlay_p.h:

(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::notifyAnimationStarted):
(WebOverlayPrivateWebKitThread):

  • Api/WebPage_p.h:

(BlackBerry::WebKit::WebPagePrivate::notifyAnimationStarted):
(BlackBerry::WebKit::WebPagePrivate::paintContents):

  • WebKitSupport/DefaultTapHighlight.h:

(BlackBerry::WebKit::DefaultTapHighlight::notifyAnimationStarted):

  • WebKitSupport/InspectorOverlayBlackBerry.cpp:

(BlackBerry::WebKit::InspectorOverlay::paintContents):

  • WebKitSupport/InspectorOverlayBlackBerry.h:

(BlackBerry::WebKit::InspectorOverlay::notifyAnimationStarted):
(InspectorOverlay):

  • WebKitSupport/SelectionOverlay.h:

(BlackBerry::WebKit::SelectionOverlay::notifyAnimationStarted):

5:38 AM Changeset in webkit [147739] by commit-queue@webkit.org
  • 11 edits
    4 adds in trunk

Source/WebCore: Updating mouse cursor on style changes without emitting fake mousemove event
https://bugs.webkit.org/show_bug.cgi?id=101857

Patch by Aivo Paas <aivopaas@gmail.com> on 2013-04-05
Reviewed by Allan Sandfeld Jensen.

Mouse cursor changes in styles used to be reflected in UI through dispatching a fake
mousemove event. The old approach has some flaws: it emits a mousemove event in
javascript when there is no mouse movement involved (bug 85343); the fake mousemove
event is cancelled while there is a mouse button held down - cursor won't change
until mouse is moved or the button released (bug 53341).

The new approach does not use the fake mousemove event. Instead, it uses only the logic
needed for the actual cursor change to happen.

EventHandler::selectCursor was refactored to not take a whole mouse event but instead work with
HitTestResult so that EventHandler::updateCursor must not create a useless PlatformEvent.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=85343 (mousemove event on cursor change)

https://bugs.webkit.org/show_bug.cgi?id=53341 (no cursor change when mouse button down)

Tests: fast/events/mouse-cursor-change.html

fast/events/mouse-cursor-no-mousemove.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::cursorUpdateTimerFired):
(WebCore::EventHandler::updateCursor):
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::scheduleCursorUpdate):

  • page/EventHandler.h:
  • page/FrameView.cpp:

(WebCore::FrameView::shouldSetCursor):

  • page/FrameView.h:
  • page/MouseEventWithHitTestResults.cpp:

(WebCore::MouseEventWithHitTestResults::isOverLink):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::isOverLink):

  • rendering/HitTestResult.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleDidChange):

LayoutTests: Updating mouse cursor on style changes without emitting fake mousemove event
https://bugs.webkit.org/show_bug.cgi?id=101857
Changing CSS cursor should work no matter is mouse button is pressed or not
https://bugs.webkit.org/show_bug.cgi?id=53341

Patch by Aivo Paas <aivopaas@gmail.com> on 2013-04-05
Reviewed by Allan Sandfeld Jensen.

Added tests for changing cursor on mousemove, mousedown, mouseup and mousemove
while mouse button being held down. Also added test to verify that a mousemove
event is not fired for changing cursor when mouse is not moving.

  • fast/events/mouse-cursor-change-expected.txt: Added.
  • fast/events/mouse-cursor-change.html: Added.
  • fast/events/mouse-cursor-no-mousemove-expected.txt: Added.
  • fast/events/mouse-cursor-no-mousemove.html: Added.
  • platform/mac/TestExpectations:
5:26 AM Changeset in webkit [147738] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] WebOverlay: fix access to m_client
https://bugs.webkit.org/show_bug.cgi?id=114003

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-05
Reviewed by Rob Buis.

m_client was replace by m_overlay in r146058.

  • Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):

4:27 AM Changeset in webkit [147737] by jocelyn.turcotte@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] PluginsX11: exposedRect offset is applied twice when painting windowless
https://bugs.webkit.org/show_bug.cgi?id=114020

Reviewed by Simon Hausmann.

Both XGetImage and QPainter::drawImage would apply the offset.
Since the XImage will only contain the exposed rect, no need to specify
the source rect to drawImage.

  • plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::paintUsingXPixmap):

4:01 AM Changeset in webkit [147736] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/blackberry

[BlackBerry] WebOverlayPrivate: remove showDebugBorders() and showRepaintCounter()
https://bugs.webkit.org/show_bug.cgi?id=114009

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-05
Reviewed by Carlos Garcia Campos.

These methods were removed in r133517 but were accidentally
introduced again in r145968.
The previous patch didn't remove them all.

  • WebKitSupport/DefaultTapHighlight.cpp:
  • WebKitSupport/DefaultTapHighlight.h:

(DefaultTapHighlight):

  • WebKitSupport/InspectorOverlayBlackBerry.cpp:
  • WebKitSupport/InspectorOverlayBlackBerry.h:

(InspectorOverlay):

  • WebKitSupport/SelectionOverlay.cpp:
  • WebKitSupport/SelectionOverlay.h:

(SelectionOverlay):

3:14 AM Changeset in webkit [147735] by apavlov@chromium.org
  • 1 edit in branches/chromium/1453/Source/WebCore/inspector/front-end/DOMBreakpointsSidebarPane.js

Merge 147314 "Web Inspector: Fixed DOM Breakpoint pane styles."

Web Inspector: Fixed DOM Breakpoint pane styles.
https://bugs.webkit.org/show_bug.cgi?id=113688

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-04-01
Reviewed by Pavel Feldman.

The required stylesheet (breakpointsList.css) was not loaded because of
the peculiar way DOMBreakpointsSidebarPane is included in two panels
(Sources and Elements) via a proxy pane. Since DOMBreakpointsSidebarPane
was never shown directly the registerRequiredCSS call in its base class
NativeBreakpointsSidebarPane constructor had no effect.
Addin a registerRequiredCSS call to the proxy pane constructor fixes the
problem.

  • inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.Proxy):

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/13598005

3:06 AM Changeset in webkit [147734] by apavlov@chromium.org
  • 1 edit in branches/chromium/1453/Source/WebCore/inspector/front-end/StylesSidebarPane.js

Merge 147088 "Web Inspector: Fixed property text indentation in ..."

Web Inspector: Fixed property text indentation in Styles sidebar.
https://bugs.webkit.org/show_bug.cgi?id=113409

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-28
Reviewed by Alexander Pavlov.

When the sidebar is too narrow and the property text wraps around it breaks the indentation.
This was introduced in r143207 which spuriously modified DOM elements order.

  • inspector/front-end/StylesSidebarPane.js:

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/13568005

3:00 AM Changeset in webkit [147733] by apavlov@chromium.org
  • 1 edit
    2 copies in branches/chromium/1453

Merge 147094 "Web Inspector: [REGRESSION] [Styles] Pasting a pro..."

Web Inspector: [REGRESSION] [Styles] Pasting a property in the "name" field is broken
https://bugs.webkit.org/show_bug.cgi?id=113491

Reviewed by Pavel Feldman.

Source/WebCore:

Update the CSSProperty name and value upon pasting properties into the Styles pane.
Drive-by: start editing the next/new property name after pasting.

Test: inspector/styles/paste-property.html

  • inspector/front-end/StylesSidebarPane.js:

(.selectElement):
(.moveDirection.alreadyNew):

LayoutTests:

  • inspector/styles/paste-property-expected.txt: Added.
  • inspector/styles/paste-property.html: Added.

TBR=apavlov@chromium.org
Review URL: https://codereview.chromium.org/13719002

2:28 AM Changeset in webkit [147732] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: crash in InspectorDOMAgent::innerHighlightQuad after r147566
https://bugs.webkit.org/show_bug.cgi?id=113991

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-05
Reviewed by Joseph Pecoraro.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::innerHighlightQuad):

2:25 AM Changeset in webkit [147731] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk/Source/WebCore

REGRESSION(r145279): Build fails while linking when MEDIA_STREAM is enabled
https://bugs.webkit.org/show_bug.cgi?id=113294

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-05
Reviewed by Xan Lopez.

In r145279 NamedGetter extended attribute is added to
RTCStatsResponse.idl which makes the code generator to add
prototypes for JSRTCStatsResponse::nameGetter and
JSRTCStatsResponse::canGetItemsForName to the generated
JSRTCStatsResponse header, but they are not implemented
anywhere. We need to provide a JSRTCStatsResponseCustom file with
the implementation of both functions.

  • GNUmakefile.list.am: Add JSRTCStatsResponseCustom.cpp to

compilation.

  • Target.pri: Ditto.
  • UseJSC.cmake: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • bindings/js/JSRTCStatsResponseCustom.cpp: Added.

(WebCore):
(WebCore::JSRTCStatsResponse::canGetItemsForName):
(WebCore::JSRTCStatsResponse::nameGetter):

2:12 AM Changeset in webkit [147730] by rniwa@webkit.org
  • 17 edits
    4 deletes in trunk/Source/WebCore

Remove Chromium code from WebCore/loader
https://bugs.webkit.org/show_bug.cgi?id=114011

Reviewed by Benjamin Poulain.

Removed.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

  • loader/DocumentThreadableLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::defaultObjectContentType):
(WebCore):

  • loader/FrameLoader.h:

(FrameLoader):

  • loader/FrameLoaderClient.h:

(FrameLoaderClient):

  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):

  • loader/ResourceLoadScheduler.cpp:

(WebCore):
(WebCore::ResourceLoadScheduler::ResourceLoadScheduler):
(WebCore::ResourceLoadScheduler::scheduleLoad):

  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.h:
  • loader/ThreadableLoaderClient.h:

(ThreadableLoaderClient):

  • loader/ThreadableLoaderClientWrapper.h:

(ThreadableLoaderClientWrapper):

  • loader/appcache/ApplicationCacheHost.h:

(WebCore):
(ApplicationCacheHost):

  • loader/cache/CachedRawResource.h:

(CachedRawResource):
(WebCore::CachedRawResourceClient::redirectReceived):

  • loader/cache/CachedResource.cpp:

(WebCore):
(WebCore::CachedResource::load):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::didSendData):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::preload):

  • loader/chromium: Removed.
  • loader/chromium/CachedRawResourceChromium.cpp: Removed.
  • loader/chromium/DocumentThreadableLoaderChromium.cpp: Removed.
  • loader/chromium/ResourceLoaderChromium.cpp: Removed.
  • loader/chromium/SubresourceLoaderChromium.cpp: Removed.
2:05 AM Changeset in webkit [147729] by allan.jensen@digia.com
  • 2 edits in trunk/Source/JavaScriptCore

LLint should be able to use x87 instead of SSE for floating pointer

https://bugs.webkit.org/show_bug.cgi?id=112239

Reviewed by Filip Pizlo.

Implements LLInt floating point operations in x87, to ensure we support
x86 without SSE2.

X86 (except 64bit) now defaults to using x87 instructions in order to
support all 32bit x86 back to i686. The implementation uses the fucomi
instruction from i686 which sets the new minimum.

  • offlineasm/x86.rb:
1:59 AM Changeset in webkit [147728] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] WebOverlayPrivate: remove showDebugBorders() and showRepaintCounter()
https://bugs.webkit.org/show_bug.cgi?id=114009

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-05
Reviewed by Carlos Garcia Campos.

These methods were removed in r133517 but were accidentally
introduced again in r145968.

  • Api/WebOverlay_p.h:

(WebOverlayPrivateWebKitThread):

1:25 AM Changeset in webkit [147727] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Removing a couple of expectations for tests that are now passing.
1:24 AM Changeset in webkit [147726] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] WebOverlay: check if platformContext is null
https://bugs.webkit.org/show_bug.cgi?id=114005

Patch by Anthony Scian <ascian@blackberry.com> on 2013-04-05
Reviewed by Carlos Garcia Campos.

RIM PR 256522
Internally reviewed by Mike Lattanzio.

The pointer returned by lockBufferDrawable can be null, so it
needs to be checked first before being used.

  • Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):

1:22 AM Changeset in webkit [147725] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK][WK2] WebKitLoaderClient: add missing initializers
https://bugs.webkit.org/show_bug.cgi?id=112961

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-05
Reviewed by Carlos Garcia Campos.

There are two new attributes: pluginLoadPolicy and pluginDidFail.

  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView):

1:20 AM Changeset in webkit [147724] by benjamin@webkit.org
  • 2 edits
    3 adds in trunk

Fix GTK+ for real after r147712

Reviewed by Ryosuke Niwa.

.:

  • GNUmakefile.am:
  • Source/Platform: Added.
  • Source/Platform/GNUmakefile.am: Added.

Source/Platform:

  • GNUmakefile.am: Added.
  • Platform: Added.
1:20 AM Changeset in webkit [147723] by mikhail.pozdnyakov@intel.com
  • 7 edits in trunk/Source/WebKit2

[WK2][EFL] Encapsulate view states set-up within WebView
https://bugs.webkit.org/show_bug.cgi?id=110877

Reviewed by Benjamin Poulain.

View states set-up is encapsulated within WebView. This change
reduces both usage of EwkView inside WebView class and usage of
WebPageProxy inside EwkView class.

New WKView API was added so that EwkView can define whether or not
the view is visible and focused.

  • UIProcess/API/C/efl/WKView.cpp:

(WKViewIsFocused):
(WKViewSetIsFocused):
(WKViewIsVisible):
(WKViewSetIsVisible):

  • UIProcess/API/C/efl/WKView.h:
  • UIProcess/API/efl/EwkView.cpp:

(::handleEvent):
(EwkView::handleEvasObjectShow):
(EwkView::handleEwkViewFocusIn):
(EwkView::handleEwkViewFocusOut):

  • UIProcess/API/efl/EwkView.h:
  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::WebView):
(WebKit::WebView::setFocused):
(WebKit):
(WebKit::WebView::setVisible):
(WebKit::WebView::isViewFocused):
(WebKit::WebView::isViewVisible):

  • UIProcess/efl/WebView.h:

(WebKit::WebView::isFocused):
(WebView):
(WebKit::WebView::isVisible):

1:10 AM Changeset in webkit [147722] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

[EFL] New baseline for accessibility/aria-option-role.html
https://bugs.webkit.org/show_bug.cgi?id=114006

Unreviewed, EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-04-05

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/accessibility/aria-option-role-expected.txt: Added.
1:02 AM Changeset in webkit [147721] by rniwa@webkit.org
  • 3 edits
    1 delete in trunk/Source/WebCore

Remove Chromium code from WebCore/editing
https://bugs.webkit.org/show_bug.cgi?id=114008

Reviewed by Benjamin Poulain.

Removed.

  • editing/EditingBehavior.h:

(WebCore::EditingBehavior::shouldAllowSpellingSuggestionsWithoutSelection):

  • editing/FrameSelection.h:

(WebCore):

  • editing/chromium: Removed.
  • editing/chromium/EditorChromium.cpp: Removed.
  • editing/chromium/FrameSelectionChromium.cpp: Removed.
12:55 AM Changeset in webkit [147720] by benjamin@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove the chromium code from the filesystem module
https://bugs.webkit.org/show_bug.cgi?id=114002

Reviewed by Ryosuke Niwa.

  • Modules/filesystem/DOMFileSystemBase.cpp:

(WebCore::DOMFileSystemBase::createFileSystemURL):

  • Modules/filesystem/FileSystemType.h:
  • Modules/filesystem/LocalFileSystem.cpp:
  • Modules/filesystem/LocalFileSystem.h:

(LocalFileSystem):

12:48 AM Changeset in webkit [147719] by rniwa@webkit.org
  • 4 edits
    1 delete in trunk/Source/WebCore

Remove Chromium code from Source/WebCore/dom
https://bugs.webkit.org/show_bug.cgi?id=114007

Reviewed by Benjamin Poulain.

Removed.

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):
(WebCore::Document::implicitClose):
(WebCore::Document::setFocusedNode):

  • dom/MessagePortChannel.h:

(MessagePortChannel):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot):

  • dom/default/chromium: Removed.
  • dom/default/chromium/PlatformMessagePortChannelChromium.cpp: Removed.
  • dom/default/chromium/PlatformMessagePortChannelChromium.h: Removed.
12:32 AM Changeset in webkit [147718] by benjamin@webkit.org
  • 1 edit
    4 deletes in trunk/Source/WebCore

Remove the chromium directories from WebCore/Modules
https://bugs.webkit.org/show_bug.cgi?id=114000

Reviewed by Ryosuke Niwa.

First step in cleaning the code: remove the chromium-specific files.

  • Modules/filesystem/chromium/DOMFileSystemChromium.cpp: Removed.
  • Modules/filesystem/chromium/DataTransferItemFileSystemChromium.cpp: Removed.
  • Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp: Removed.
  • Modules/filesystem/chromium/DraggedIsolatedFileSystem.h: Removed.
  • Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp: Removed.
  • Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.h: Removed.
  • Modules/speech/chromium/SpeechSynthesisChromium.cpp: Removed.
  • Modules/webdatabase/chromium/DatabaseObserver.h: Removed.
  • Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp: Removed.
  • Modules/webdatabase/chromium/QuotaTracker.cpp: Removed.
  • Modules/webdatabase/chromium/QuotaTracker.h: Removed.
  • Modules/webdatabase/chromium/SQLTransactionClientChromium.cpp: Removed.
12:25 AM Changeset in webkit [147717] by benjamin@webkit.org
  • 2 edits in trunk

Fix GTK+ build after r147712

Unreviewed.

  • GNUmakefile.am: remove the reference to

Source/Platform/GNUmakefile.am. The file has been removed.

12:12 AM Changeset in webkit [147716] by rniwa@webkit.org
  • 3 edits
    1 delete in trunk/Source/WebCore

Remove Chromium code from WebCore/accessibility
https://bugs.webkit.org/show_bug.cgi?id=114001

Reviewed by Benjamin Poulain.

Removed.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::AccessibilityObject):
(WebCore::AccessibilityObject::detach):
(WebCore::AccessibilityObject::isDetached):

  • accessibility/AccessibilityObject.h:

(AccessibilityObject):

  • accessibility/chromium: Removed.
  • accessibility/chromium/AXObjectCacheChromium.cpp: Removed.
  • accessibility/chromium/AccessibilityObjectChromium.cpp: Removed.
12:05 AM Changeset in webkit [147715] by benjamin@webkit.org
  • 20 edits
    4 deletes in trunk

Remove WTFURL from WebKit
https://bugs.webkit.org/show_bug.cgi?id=113994

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-05
Reviewed by Ryosuke Niwa.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore:

  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/KURL.cpp:

(WebCore):
(WebCore::KURL::reportMemoryUsage):
(WebCore::KURL::isSafeToSendToAnotherThread):

  • platform/KURL.h:

(KURL):
(WebCore):

  • platform/KURLWTFURL.cpp: Removed.
  • platform/KURLWTFURLImpl.h: Removed.
  • platform/cf/KURLCFNet.cpp:

(WebCore::KURL::KURL):
(WebCore::KURL::createCFURL):
(WebCore):

  • platform/mac/KURLMac.mm:

(WebCore::KURL::KURL):
(WebCore::KURL::createCFURL):

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataUseFeatures.in:

Source/WTF:

Painful, but that is for the best now :(

  • GNUmakefile.list.am:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/MemoryInstrumentationParsedURL.h: Removed.
  • wtf/url/api/ParsedURL.cpp: Removed.
  • wtf/url/api/ParsedURL.h: Removed.
  • wtf/url/api/URLBuffer.h: Removed.
  • wtf/url/api/URLQueryCharsetConverter.h: Removed.
  • wtf/url/api/URLString.cpp: Removed.
  • wtf/url/api/URLString.h: Removed.
  • wtf/url/src/RawURLBuffer.h: Removed.
  • wtf/url/src/URLCanon.h: Removed.
  • wtf/url/src/URLCanonEtc.cpp: Removed.
  • wtf/url/src/URLCanonFilesystemurl.cpp: Removed.
  • wtf/url/src/URLCanonFileurl.cpp: Removed.
  • wtf/url/src/URLCanonHost.cpp: Removed.
  • wtf/url/src/URLCanonICU.cpp: Removed.
  • wtf/url/src/URLCanonIP.cpp: Removed.
  • wtf/url/src/URLCanonInternal.cpp: Removed.
  • wtf/url/src/URLCanonInternal.h: Removed.
  • wtf/url/src/URLCanonMailto.cpp: Removed.
  • wtf/url/src/URLCanonPath.cpp: Removed.
  • wtf/url/src/URLCanonPathurl.cpp: Removed.
  • wtf/url/src/URLCanonQuery.cpp: Removed.
  • wtf/url/src/URLCanonRelative.cpp: Removed.
  • wtf/url/src/URLCanonStdURL.cpp: Removed.
  • wtf/url/src/URLCharacterTypes.cpp: Removed.
  • wtf/url/src/URLCharacterTypes.h: Removed.
  • wtf/url/src/URLComponent.h: Removed.
  • wtf/url/src/URLFile.h: Removed.
  • wtf/url/src/URLParse.cpp: Removed.
  • wtf/url/src/URLParse.h: Removed.
  • wtf/url/src/URLParseFile.cpp: Removed.
  • wtf/url/src/URLParseInternal.h: Removed.
  • wtf/url/src/URLSegments.cpp: Removed.
  • wtf/url/src/URLSegments.h: Removed.
  • wtf/url/src/URLUtil.cpp: Removed.
  • wtf/url/src/URLUtil.h: Removed.
  • wtf/url/src/URLUtilInternal.h: Removed.

Apr 4, 2013:

11:55 PM Changeset in webkit [147714] by benjamin@webkit.org
  • 1 edit
    1 delete in trunk/Source/WebKit

Remove Webkit/chromium
https://bugs.webkit.org/show_bug.cgi?id=113998

Reviewed by Ryosuke Niwa.

O Knights of Ni, you are just and fair, and we will return with a shrubbery.

  • chromium: Removed.
11:46 PM Changeset in webkit [147713] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

WinCairo build fails to link.
https://bugs.webkit.org/show_bug.cgi?id=113873

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-04-04
Reviewed by Brent Fulgham.

Removed double guards for USE(ACCELERATED_COMPOSITING),
and moved methods out of USE(ACCELERATED_COMPOSITING) guard to fix linker errors.

  • page/FrameView.cpp:

(WebCore::FrameView::setWantsLayerForTopOverHangArea):
(WebCore::FrameView::setWantsLayerForBottomOverHangArea):
(WebCore::FrameView::setWantsLayerForHeader):
(WebCore::FrameView::setWantsLayerForFooter):
(WebCore::FrameView::setHeaderHeight):
(WebCore::FrameView::setFooterHeight):

11:39 PM Changeset in webkit [147712] by rniwa@webkit.org
  • 1 edit
    2 deletes in trunk

Remove the top level gyp directory and Platform/chromium
https://bugs.webkit.org/show_bug.cgi?id=113999

Reviewed by Benjamin Poulain.

.:

  • Source/Platform: Removed.
  • Source/gyp: Removed.

Source/Platform:

  • Platform.gyp: Removed.
  • Platform.gyp/.gitignore: Removed.
  • Platform.gyp/Platform.gyp: Removed.
  • Platform.gypi: Removed.
  • chromium: Removed.
  • chromium/public: Removed.
  • chromium/public/Platform.h: Removed.
  • chromium/public/WebAnimation.h: Removed.
  • chromium/public/WebAnimationCurve.h: Removed.
  • chromium/public/WebAnimationDelegate.h: Removed.
  • chromium/public/WebAudioBus.h: Removed.
  • chromium/public/WebAudioDestinationConsumer.h: Removed.
  • chromium/public/WebAudioDevice.h: Removed.
  • chromium/public/WebBlobData.h: Removed.
  • chromium/public/WebBlobRegistry.h: Removed.
  • chromium/public/WebCString.h: Removed.
  • chromium/public/WebCanvas.h: Removed.
  • chromium/public/WebClipboard.h: Removed.
  • chromium/public/WebColor.h: Removed.
  • chromium/public/WebCommon.h: Removed.
  • chromium/public/WebCompositorOutputSurface.h: Removed.
  • chromium/public/WebCompositorSupport.h: Removed.
  • chromium/public/WebContentLayer.h: Removed.
  • chromium/public/WebContentLayerClient.h: Removed.
  • chromium/public/WebCookie.h: Removed.
  • chromium/public/WebCookieJar.h: Removed.
  • chromium/public/WebData.h: Removed.
  • chromium/public/WebDiscardableMemory.h: Removed.
  • chromium/public/WebDragData.h: Removed.
  • chromium/public/WebExternalTextureLayer.h: Removed.
  • chromium/public/WebExternalTextureLayerClient.h: Removed.
  • chromium/public/WebFileError.h: Removed.
  • chromium/public/WebFileInfo.h: Removed.
  • chromium/public/WebFileSystem.h: Removed.
  • chromium/public/WebFileSystemCallbacks.h: Removed.
  • chromium/public/WebFileSystemEntry.h: Removed.
  • chromium/public/WebFileSystemType.h: Removed.
  • chromium/public/WebFileUtilities.h: Removed.
  • chromium/public/WebFilterOperation.h: Removed.
  • chromium/public/WebFilterOperations.h: Removed.
  • chromium/public/WebFlingAnimator.h: Removed.
  • chromium/public/WebFloatAnimationCurve.h: Removed.
  • chromium/public/WebFloatKeyframe.h: Removed.
  • chromium/public/WebFloatPoint.h: Removed.
  • chromium/public/WebFloatQuad.h: Removed.
  • chromium/public/WebFloatRect.h: Removed.
  • chromium/public/WebFloatSize.h: Removed.
  • chromium/public/WebGamepad.h: Removed.
  • chromium/public/WebGamepads.h: Removed.
  • chromium/public/WebGestureCurve.h: Removed.
  • chromium/public/WebGestureCurveTarget.h: Removed.
  • chromium/public/WebGraphicsContext3D.h: Removed.
  • chromium/public/WebGraphicsMemoryAllocation.h: Removed.
  • chromium/public/WebGraphicsMemoryStats.h: Removed.
  • chromium/public/WebHTTPBody.h: Removed.
  • chromium/public/WebHTTPHeaderVisitor.h: Removed.
  • chromium/public/WebHTTPLoadInfo.h: Removed.
  • chromium/public/WebHyphenator.h: Removed.
  • chromium/public/WebImage.h: Removed.
  • chromium/public/WebImageLayer.h: Removed.
  • chromium/public/WebInputHandler.h: Removed.
  • chromium/public/WebInputHandlerClient.h: Removed.
  • chromium/public/WebLayer.h: Removed.
  • chromium/public/WebLayerPositionConstraint.h: Removed.
  • chromium/public/WebLayerScrollClient.h: Removed.
  • chromium/public/WebLayerTreeView.h: Removed.
  • chromium/public/WebLocalizedString.h: Removed.
  • chromium/public/WebMediaConstraints.h: Removed.
  • chromium/public/WebMediaStream.h: Removed.
  • chromium/public/WebMediaStreamCenter.h: Removed.
  • chromium/public/WebMediaStreamCenterClient.h: Removed.
  • chromium/public/WebMediaStreamSource.h: Removed.
  • chromium/public/WebMediaStreamSourcesRequest.h: Removed.
  • chromium/public/WebMediaStreamTrack.h: Removed.
  • chromium/public/WebMessagePortChannel.h: Removed.
  • chromium/public/WebMessagePortChannelClient.h: Removed.
  • chromium/public/WebMimeRegistry.h: Removed.
  • chromium/public/WebNonCopyable.h: Removed.
  • chromium/public/WebPluginListBuilder.h: Removed.
  • chromium/public/WebPoint.h: Removed.
  • chromium/public/WebPrerender.h: Removed.
  • chromium/public/WebPrerenderingSupport.h: Removed.
  • chromium/public/WebPrivateOwnPtr.h: Removed.
  • chromium/public/WebPrivatePtr.h: Removed.
  • chromium/public/WebRTCConfiguration.h: Removed.
  • chromium/public/WebRTCDTMFSenderHandler.h: Removed.
  • chromium/public/WebRTCDTMFSenderHandlerClient.h: Removed.
  • chromium/public/WebRTCDataChannelHandler.h: Removed.
  • chromium/public/WebRTCDataChannelHandlerClient.h: Removed.
  • chromium/public/WebRTCICECandidate.h: Removed.
  • chromium/public/WebRTCPeerConnectionHandler.h: Removed.
  • chromium/public/WebRTCPeerConnectionHandlerClient.h: Removed.
  • chromium/public/WebRTCSessionDescription.h: Removed.
  • chromium/public/WebRTCSessionDescriptionRequest.h: Removed.
  • chromium/public/WebRTCStatsRequest.h: Removed.
  • chromium/public/WebRTCStatsResponse.h: Removed.
  • chromium/public/WebRTCVoidRequest.h: Removed.
  • chromium/public/WebRect.h: Removed.
  • chromium/public/WebReferrerPolicy.h: Removed.
  • chromium/public/WebRenderingStats.h: Removed.
  • chromium/public/WebScreenInfo.h: Removed.
  • chromium/public/WebScrollbar.h: Removed.
  • chromium/public/WebScrollbarLayer.h: Removed.
  • chromium/public/WebScrollbarThemeGeometry.h: Removed.
  • chromium/public/WebScrollbarThemePainter.h: Removed.
  • chromium/public/WebSize.h: Removed.
  • chromium/public/WebSocketStreamError.h: Removed.
  • chromium/public/WebSocketStreamHandle.h: Removed.
  • chromium/public/WebSocketStreamHandleClient.h: Removed.
  • chromium/public/WebSolidColorLayer.h: Removed.
  • chromium/public/WebSpeechSynthesisUtterance.h: Removed.
  • chromium/public/WebSpeechSynthesisVoice.h: Removed.
  • chromium/public/WebSpeechSynthesizer.h: Removed.
  • chromium/public/WebSpeechSynthesizerClient.h: Removed.
  • chromium/public/WebStorageArea.h: Removed.
  • chromium/public/WebStorageNamespace.h: Removed.
  • chromium/public/WebString.h: Removed.
  • chromium/public/WebThread.h: Removed.
  • chromium/public/WebThreadSafeData.h: Removed.
  • chromium/public/WebTransformAnimationCurve.h: Removed.
  • chromium/public/WebTransformKeyframe.h: Removed.
  • chromium/public/WebTransformOperations.h: Removed.
  • chromium/public/WebURL.h: Removed.
  • chromium/public/WebURLError.h: Removed.
  • chromium/public/WebURLLoadTiming.h: Removed.
  • chromium/public/WebURLLoader.h: Removed.
  • chromium/public/WebURLLoaderClient.h: Removed.
  • chromium/public/WebURLRequest.h: Removed.
  • chromium/public/WebURLResponse.h: Removed.
  • chromium/public/WebUnitTestSupport.h: Removed.
  • chromium/public/WebVector.h: Removed.
  • chromium/public/WebWorkerRunLoop.h: Removed.
  • chromium/public/android: Removed.
  • chromium/public/android/WebSandboxSupport.h: Removed.
  • chromium/public/android/WebThemeEngine.h: Removed.
  • chromium/public/default: Removed.
  • chromium/public/default/WebThemeEngine.h: Removed.
  • chromium/public/linux: Removed.
  • chromium/public/linux/WebFontFamily.h: Removed.
  • chromium/public/linux/WebFontInfo.h: Removed.
  • chromium/public/linux/WebFontRenderStyle.h: Removed.
  • chromium/public/linux/WebSandboxSupport.h: Removed.
  • chromium/public/mac: Removed.
  • chromium/public/mac/WebSandboxSupport.h: Removed.
  • chromium/public/mac/WebThemeEngine.h: Removed.
  • chromium/public/win: Removed.
  • chromium/public/win/WebSandboxSupport.h: Removed.
  • chromium/public/win/WebThemeEngine.h: Removed.
  • chromium/src: Removed.
  • chromium/src/Platform.cpp: Removed.
  • chromium/src/WebActiveGestureAnimation.cpp: Removed.
  • chromium/src/WebActiveGestureAnimation.h: Removed.
  • chromium/src/WebCString.cpp: Removed.
  • chromium/src/WebFilterOperation.cpp: Removed.
  • chromium/src/WebFilterOperations.cpp: Removed.
  • chromium/src/WebFloatQuad.cpp: Removed.
  • chromium/src/WebPrerenderingSupport.cpp: Removed.
  • chromium/src/WebString.cpp: Removed.
11:20 PM Changeset in webkit [147711] by tkent@chromium.org
  • 2 edits in trunk/Tools

Remove ChromiumPublicApi pattern, and cc/message rules for it.

  • Scripts/webkitpy/common/config/watchlist:
11:05 PM Changeset in webkit [147710] by rniwa@webkit.org
  • 37 edits in trunk/Source/WebCore

Remove code for 10.5 and earlier from Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=113754

Reviewed by Benjamin Poulain.

Removed the code for 10.5 and removed if-def for 10.6.

  • WebCore.xcodeproj/project.pbxproj:
  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):

  • platform/LocalizedStrings.cpp:

(WebCore::imageTitle):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::setAllowsFontSmoothing):

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::Image::drawPattern):

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::clear):

  • platform/graphics/cg/PathCG.cpp:

(WebCore::Path::boundingRect):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore):
(WebCore::FontPlatformData::ctFont):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::supportsFullscreen):

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:
  • platform/graphics/mac/FontCacheMac.mm:

(WebCore):
(WebCore::fontCacheRegisteredFontsChangedNotificationCallback):
(WebCore::FontCache::platformInit):

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::supportsFullscreen):
(WebCore::MediaPlayerPrivateQTKit::setClosedCaptionsVisible):
(WebCore::MediaPlayerPrivateQTKit::cacheMovieScale):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformInit):

  • platform/graphics/mac/WebLayer.h:
  • platform/mac/CursorMac.mm:

(WebCore::Cursor::ensurePlatformCursor):

  • platform/mac/DisplaySleepDisabler.cpp:

(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
(WebCore):

  • platform/mac/DisplaySleepDisabler.h:

(DisplaySleepDisabler):

  • platform/mac/EmptyProtocolDefinitions.h:
  • platform/mac/HTMLConverter.h:
  • platform/mac/HTMLConverter.mm:
  • platform/mac/PopupMenuMac.mm:

(WebCore::PopupMenuMac::populate):

  • platform/mac/ScrollElasticityController.mm:

(systemUptime):

  • platform/mac/SharedTimerMac.mm:

(PowerObserver):
(WebCore::PowerObserver::PowerObserver):
(WebCore::PowerObserver::~PowerObserver):
(WebCore::PowerObserver::didReceiveSystemPowerNotification):

  • platform/mac/SuddenTermination.mm:
  • platform/mac/WebCoreFullScreenWindow.mm:

(-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):

  • platform/mac/WebFontCache.mm:

(+[WebFontCache getTraits:inFamily:]):
(+[WebFontCache internalFontWithFamily:traits:weight:size:]):

  • platform/mac/WebVideoFullscreenController.mm:

(SOFT_LINK_POINTER):
(-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):

  • platform/mac/WebVideoFullscreenHUDWindowController.mm:

(createControlWithMediaUIControlType):
(-[WebVideoFullscreenHUDWindowController windowDidLoad]):

  • platform/network/Credential.h:
  • platform/network/cf/DNSCFNet.cpp:

(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):

  • platform/network/cf/ProxyServerCFNet.cpp:

(WebCore):
(WebCore::proxyServersForURL):

  • platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::chooseProxy):

  • platform/network/mac/AuthenticationMac.mm:

(WebCore):

  • platform/network/mac/WebCoreURLResponse.mm:

(WebCore::adjustMIMETypeIfNecessary):

  • platform/text/TextChecking.h:

(WebCore):

10:36 PM Changeset in webkit [147709] by benjamin@webkit.org
  • 3 edits in trunk/Tools

Temporarily disable the Python unittests broken by the commit queue not running layout tests
https://bugs.webkit.org/show_bug.cgi?id=113997

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Ryosuke Niwa.

Disable the tests until Ryosuke gets the time and hardware to have
a testing commit-queue.

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:

(CommitQueueTaskTest):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

(CommitQueueTest):

10:24 PM Changeset in webkit [147708] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Qt build fix attempt after r147684.

  • html/canvas/CanvasRenderingContext.cpp:
10:17 PM Changeset in webkit [147707] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Remove Chromium builders from build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=113990

Reviewed by Benjamin Poulain.

Land the part to disable triggering of Chromium builders first so that we may start
deleting more Chromium code that breaks the update step.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
9:57 PM Changeset in webkit [147706] by ggaren@apple.com
  • 1 edit
    1 delete in trunk

Nixed the defunct chromium folder from ManualTests
https://bugs.webkit.org/show_bug.cgi?id=113995

Reviewed by Benjamin Poulain.

  • ManualTests/chromium: Removed.
  • ManualTests/chromium/autofill-popup-shiftupdown.hml: Removed.
  • ManualTests/chromium/drag-image-accounts-for-device-scale.html: Removed.
  • ManualTests/chromium/modifiers-during-drag-and-drop.html: Removed.
  • ManualTests/chromium/no-autofill-on-readonly.html: Removed.
  • ManualTests/chromium/onchange-reload-popup.html: Removed.
  • ManualTests/chromium/popup-menu-crash.html: Removed.
  • ManualTests/chromium/select-close-popup-value-change.html: Removed.
  • ManualTests/chromium/suggestions-popup-font-change.html: Removed.
9:53 PM Changeset in webkit [147705] by benjamin@webkit.org
  • 2 edits in trunk/Tools

Remove Chromium's DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=113989

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Kent Tamura.

On second thought, let's not go to Camelot. It is a silly place.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

9:46 PM Changeset in webkit [147704] by ggaren@apple.com
  • 1 edit
    1 delete in trunk/Tools

Nixed the defunct chromium folder from DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=113993

Reviewed by Ryosuke Niwa.

  • DumpRenderTree/chromium: Removed.
  • DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
  • DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
  • DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
  • DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
  • DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
  • DumpRenderTree/chromium/ImageDiff.cpp: Removed.
  • DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
  • DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
  • DumpRenderTree/chromium/MockPlatform.cpp: Removed.
  • DumpRenderTree/chromium/MockPlatform.h: Removed.
  • DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
  • DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
  • DumpRenderTree/chromium/Task.cpp: Removed.
  • DumpRenderTree/chromium/Task.h: Removed.
  • DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
  • DumpRenderTree/chromium/TestEventPrinter.h: Removed.
  • DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
  • DumpRenderTree/chromium/TestNavigationController.h: Removed.
  • DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
  • DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
  • DumpRenderTree/chromium/TestRunner: Removed.
  • DumpRenderTree/chromium/TestRunner/public: Removed.
  • DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
  • DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
  • DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
  • DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src: Removed.
  • DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
  • DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
  • DumpRenderTree/chromium/TestShell.cpp: Removed.
  • DumpRenderTree/chromium/TestShell.h: Removed.
  • DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
  • DumpRenderTree/chromium/TestShellMac.mm: Removed.
  • DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
  • DumpRenderTree/chromium/TestShellStub.cpp: Removed.
  • DumpRenderTree/chromium/TestShellWin.cpp: Removed.
  • DumpRenderTree/chromium/TestShellX11.cpp: Removed.
  • DumpRenderTree/chromium/WebViewHost.cpp: Removed.
  • DumpRenderTree/chromium/WebViewHost.h: Removed.
  • DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
  • DumpRenderTree/chromium/android_main_fonts.xml: Removed.
  • DumpRenderTree/chromium/config.h: Removed.
  • DumpRenderTree/chromium/fonts.conf: Removed.
9:40 PM Changeset in webkit [147703] by ggaren@apple.com
  • 1 edit
    1 delete in trunk/Source/WTF

Nixed the defunct chromium folder from WTF
https://bugs.webkit.org/show_bug.cgi?id=113992

Reviewed by Ryosuke Niwa.

  • wtf/chromium: Removed.
  • wtf/chromium/ChromiumThreading.h: Removed.
  • wtf/chromium/MainThreadChromium.cpp: Removed.
9:39 PM Changeset in webkit [147702] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

alternateFamilyName should return a null, not an empty value
https://bugs.webkit.org/show_bug.cgi?id=113987

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Anders Carlsson.

The string object corresponding semantically to "no-value" is
a null string, not an empty string.

Fix alternateFamilyName() accordingly.

  • platform/graphics/FontCache.cpp:

(WebCore::alternateFamilyName):
(WebCore::FontCache::getCachedFontPlatformData):

8:46 PM Changeset in webkit [147701] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] DOMSupport::isFixedPositionOrHasFixedPositionAncestor stops traversing render tree when it hits an iframe element
https://bugs.webkit.org/show_bug.cgi?id=113944

Patch by Andrew Lo <anlo@rim.com> on 2013-04-04
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.

Internal PR 320732.
When checking whether a RenderObject is fixed position or has a fixed position
ancestor, we traverse the render tree upwards.

When we reach the root of the tree, check whether the root is an
iframe and has an element owner. If so, we also need to continue iterating
up the tree from the owner to see if the iframe is a descendant of a fixed
position element.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::isFixedPositionOrHasFixedPositionAncestor):

7:52 PM Changeset in webkit [147700] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add support for getting page contents as string
https://bugs.webkit.org/show_bug.cgi?id=106752

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-04-04
Reviewed by Andreas Kling.

Modified ewk_view_page_contents_get() API to get page contents as string.
EWK_PAGE_CONTENTS_TYPE_STRING is added to Ewk_Page_Contents_Type.
Now, we can use both EWK_PAGE_CONTENTS_TYPE_MHTML and EWK_PAGE_CONTENTS_TYPE_STRING
for getting page contents.

  • UIProcess/API/efl/ewk_view.cpp:

(Ewk_Page_Contents_Context):
(ewkViewPageContentsAsMHTMLCallback):
(ewkViewPageContentsAsStringCallback):
(ewk_view_page_contents_get):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(PageContentsAsMHTMLCallback):
(PageContentsAsStringCallback):
(TEST_F):

7:51 PM Changeset in webkit [147699] by benjamin@webkit.org
  • 1 edit
    1 add
    7 deletes in trunk/LayoutTests

Change class_as_selector-expected.html to be a ref-test
https://bugs.webkit.org/show_bug.cgi?id=113970

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Geoffrey Garen.

The test checks style can be applied to text with a CSS class.
The reference is done by applying a style attribute directly
on each element.

  • css1/basic/class_as_selector-expected.html: Added.
  • platform/efl/css1/basic/class_as_selector-expected.png: Removed.
  • platform/efl/css1/basic/class_as_selector-expected.txt: Removed.
  • platform/gtk/css1/basic/class_as_selector-expected.txt: Removed.
  • platform/mac/css1/basic/class_as_selector-expected.png: Removed.
  • platform/mac/css1/basic/class_as_selector-expected.txt: Removed.
  • platform/qt/css1/basic/class_as_selector-expected.png: Removed.
  • platform/qt/css1/basic/class_as_selector-expected.txt: Removed.
7:48 PM Changeset in webkit [147698] by benjamin@webkit.org
  • 2 edits in trunk/LayoutTests

Unskip 3 backface-visibility tests on OS X

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04

  • platform/mac/TestExpectations:

The 3 pixel tests pass on WebKit1 and WebKit2.

7:43 PM Changeset in webkit [147697] by benjamin@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Update WebKit.org's contact page
https://bugs.webkit.org/show_bug.cgi?id=113968

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Geoffrey Garen.

  • contact.html:

-Add a direct link to our archives on Gmane.
-References the ports mailing-lists. This may reduces the emails

erroneously sent to webkit-dev.

-Add a link to our "reporting bug page".
-Get rid of the link to CIA. The website is dead.

7:39 PM Changeset in webkit [147696] by rniwa@webkit.org
  • 1 edit
    1 delete in trunk/Tools

Remove the rebaseline queue server since nobody except maybe one person from Google uses it.

Rubber stamped by Benjamin Poulain.

  • RebaselineQueueServer: Removed.
  • RebaselineQueueServer/app.yaml: Removed.
  • RebaselineQueueServer/handlers: Removed.
  • RebaselineQueueServer/handlers/init.py: Removed.
  • RebaselineQueueServer/handlers/builderqueue.py: Removed.
  • RebaselineQueueServer/handlers/pages.py: Removed.
  • RebaselineQueueServer/index.yaml: Removed.
  • RebaselineQueueServer/main.py: Removed.
  • RebaselineQueueServer/model: Removed.
  • RebaselineQueueServer/model/init.py: Removed.
  • RebaselineQueueServer/model/queueentry.py: Removed.
  • RebaselineQueueServer/static: Removed.
  • RebaselineQueueServer/static/builder-frame-empty.html: Removed.
  • RebaselineQueueServer/static/styles.css: Removed.
  • RebaselineQueueServer/templates: Removed.
  • RebaselineQueueServer/templates/builder-picker.html: Removed.
  • RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
  • RebaselineQueueServer/templates/builder-queue-list.html: Removed.
  • RebaselineQueueServer/templates/home.html: Removed.
7:35 PM Changeset in webkit [147695] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Fix setup-commit-queue and temporarily disable testing on commit-queue
https://bugs.webkit.org/show_bug.cgi?id=113979

Reviewed by Benjamin Poulain.

Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
and temporarily disable tests in commit-queue as we don't have enough resources at the moment.

  • EWSTools/setup-commit-queue.sh:
  • Scripts/webkitpy/tool/bot/commitqueuetask.py:

(CommitQueueTask.run):

6:32 PM WebKit Team edited by yosin@chromium.org
Updates yosin@'s knowledge area (diff)
6:29 PM Changeset in webkit [147694] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Work around a bug in the bindings generation script.

  • WebCore.xcodeproj/project.pbxproj:
6:25 PM Changeset in webkit [147693] by dino@apple.com
  • 4 edits in trunk/Source/WebCore

Don't dispatch delayed click if snapshotted plugin was triggered by a click on the label
https://bugs.webkit.org/show_bug.cgi?id=113982

Reviewed by Tim Horton.

We regressed the way clicks were sent on to restarted plugins when we moved to a
Shadow Root - we were always sending the click. We should only send the click
on if the user clicked on the main plugin content, and not send it when you
click directly on the label.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Keep a reference to the container and label.
(WebCore::HTMLPlugInImageElement::partOfSnapshotLabel): New method that detects if a Node was part

of the snapshot label.

(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Only record the event if you should forward it on.

  • html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement): New parameter to userDidClickSnapshot and member variables for shadow content.

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::handleEvent): Ask the plugin if the clicked target was the snapshot label.

5:59 PM Changeset in webkit [147692] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed EFL build fix.

Add missing include for FloatRect.h.

  • platform/efl/PlatformScreenEfl.cpp:
5:54 PM Changeset in webkit [147691] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

  • platform/graphics/GlyphPageTreeNode.cpp:
5:44 PM Changeset in webkit [147690] by Christophe Dumez
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed EFL build fix.

We had undefined reference to `JSC::CodeOrigin::maximumBytecodeIndex'.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::findClosureCallForReturnPC):
(JSC::CodeBlock::bytecodeOffset):

5:37 PM Changeset in webkit [147689] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Another build fix.

  • platform/graphics/FontCache.cpp:
  • platform/graphics/SimpleFontData.cpp:
5:28 PM Changeset in webkit [147688] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • WebCore.xcodeproj/project.pbxproj:
5:26 PM Changeset in webkit [147687] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Adjust fatfinger result priority
https://bugs.webkit.org/show_bug.cgi?id=113957

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-04-04
Reviewed by Rob Buis.

RIM PR 224781
Internally Reviewed by Genevieve Mak.

Change fatfigner algorithm, return the clickable element rather than
its parent anchor. Modify taphighlight and context menu node selection
accordingly.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::findBestPoint):

  • WebKitSupport/FatFingers.h:
  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::elementForTapHighlight):

5:15 PM Changeset in webkit [147686] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

Removed empty files from the build
https://bugs.webkit.org/show_bug.cgi?id=113978

Reviewed by Anders Carlsson.

Anders made a list of all the empty files that are slowing down the Mac
build, and I grepped them away.

  • WebCore.xcodeproj/project.pbxproj:
5:08 PM Changeset in webkit [147685] by dpranke@chromium.org
  • 2 edits in trunk/Tools

temporarily make flakiness dashboard work again webkit.org bots
https://bugs.webkit.org/show_bug.cgi?id=113972

Reviewed by Ojan Vafai.

This patch disables the chromium.org layout test bots TestExpectations
parsing temporarily until we can work out the right way to split into
two instances for webkit.org and chromium.org and figure out which
code to delete where :).

  • TestResultServer/static-dashboards/flakiness_dashboard.js:
5:08 PM Changeset in webkit [147684] by andersca@apple.com
  • 42 edits
    1 copy
    1 add in trunk/Source/WebCore

Prune unneeded header #includes
https://bugs.webkit.org/show_bug.cgi?id=113973

Reviewed by Geoffrey Garen.

Reduce the amount of headers included by other headers by:

  • Moving implicit and explicit constructors and destructors into .cpp files so member variable constructors/destructors don't have to be declared.
  • Move CachedResourceClient subclasses out into separate headers so that their respective CachedResource subclasses don't have to be included by the classes that derive from those subclasses.
  • Remove headers that were never needed in the first place.
  • Modules/webaudio/AudioContext.h:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp:
  • css/CSSFontFaceSource.h:
  • html/canvas/CanvasPattern.cpp:

(WebCore::CanvasPattern::create):
(WebCore::CanvasPattern::CanvasPattern):
(WebCore::CanvasPattern::~CanvasPattern):

  • html/canvas/CanvasPattern.h:

(WebCore::CanvasPattern::pattern):
(WebCore::CanvasPattern::originClean):

  • html/parser/HTMLScriptRunner.h:
  • loader/ImageLoader.h:
  • loader/LinkLoader.h:
  • loader/TextTrackLoader.h:
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedFont.h:
  • loader/cache/CachedFontClient.h: Added.

(WebCore::CachedFontClient::~CachedFontClient):
(WebCore::CachedFontClient::expectedType):
(WebCore::CachedFontClient::resourceClientType):
(WebCore::CachedFontClient::fontLoaded):

  • loader/cache/CachedResourceHandle.cpp:

(WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::setResource):

  • loader/cache/CachedResourceHandle.h:

(WebCore::CachedResourceHandleBase::get):
(WebCore::CachedResourceHandleBase::operator!):
(WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType):
(WebCore::CachedResourceHandleBase::operator=):
(WebCore::CachedResourceHandle::CachedResourceHandle):
(WebCore::CachedResourceHandle::get):
(WebCore::CachedResourceHandle::operator->):
(WebCore::CachedResourceHandle::operator=):
(WebCore::CachedResourceHandle::operator==):
(WebCore::CachedResourceHandle::operator!=):
(WebCore::operator==):
(WebCore::operator!=):

  • loader/cache/CachedSVGDocument.h:
  • loader/cache/CachedSVGDocumentReference.h:
  • loader/cache/CachedSVGDocumentClient.h: Added.

(WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::expectedType):
(WebCore::CachedSVGDocumentClient::resourceClientType):

  • loader/cache/CachedStyleSheetClient.h:
  • platform/PlatformScreen.h:
  • platform/audio/HRTFElevation.cpp:
  • platform/audio/HRTFKernel.cpp:

(WebCore::HRTFKernel::fftSize):

  • platform/audio/HRTFKernel.h:
  • platform/audio/ReverbConvolverStage.cpp:

(WebCore::ReverbConvolverStage::~ReverbConvolverStage):

  • platform/audio/ReverbConvolverStage.h:
  • platform/graphics/FontPlatformData.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/Path.cpp:
  • platform/graphics/Path.h:
  • platform/graphics/Pattern.cpp:
  • platform/graphics/Pattern.h:
  • platform/graphics/filters/FilterOperation.cpp:

(WebCore::ReferenceFilterOperation::ReferenceFilterOperation):
(WebCore::ReferenceFilterOperation::~ReferenceFilterOperation):
(WebCore::ReferenceFilterOperation::setCachedSVGDocumentReference):

  • platform/graphics/filters/FilterOperation.h:
  • platform/graphics/transforms/AffineTransform.h:
  • plugins/DOMMimeType.h:
  • rendering/RenderLayerFilterInfo.h:
  • rendering/style/StyleCachedShader.h:
  • svg/SVGFEImageElement.h:
  • svg/SVGFontFaceUriElement.h:
  • svg/SVGUseElement.h:
  • xml/parser/XMLDocumentParser.h:
4:59 PM Changeset in webkit [147683] by Christophe Dumez
  • 7 edits in trunk/Source

[Cairo] Stop passing raw pointers to BitmapImage::create()
https://bugs.webkit.org/show_bug.cgi?id=113945

Reviewed by Martin Robinson.

Source/WebCore:

BitmapImage::create() was updated in r147643 to take a PassRefPtr<cairo_surface_t>
in argument instead of a cairo_surface_t*. This patch updates several call sites
so that they now pass in a smart pointer instead of a raw one to avoid silent
converting from cairo_surface_t* to PassRefPtr<cairo_surface_t>.

No new tests, no behavior change.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBufferData::ImageBufferData): Use RefPtr to m_surface to avoid manual
memory handling.
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::~ImageBuffer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):

  • platform/graphics/cairo/ImageBufferDataCairo.h:

(ImageBufferData):

  • platform/graphics/gstreamer/ImageGStreamerCairo.cpp:

(ImageGStreamer::ImageGStreamer):

  • platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::ImageBuffer::toDataURL):

Source/WebKit2:

Pass a smart pointer in to BitmapImage::create() instead of a raw one
for the cairo surface. The factory method prototype was updated for
cairo in r147643.

  • Shared/cairo/ShareableBitmapCairo.cpp:

(WebKit::ShareableBitmap::createImage):

4:57 PM Changeset in webkit [147682] by Simon Fraser
  • 4 edits
    2 adds in trunk

Page content missing when flipping from an empty layer to a tiled layer
https://bugs.webkit.org/show_bug.cgi?id=113977
<rdar://problem/13444219>

Source/WebCore:

Reviewed by Tim Horton.

Some articles on USA Today were missing content on load, when a large GraphicsLayer
which did not draw content needed to draw content (and become tiled in the process).

The bug was an ordering dependency in GraphicsLayerCA::commitLayerChangesBeforeSublayers().
swapFromOrToTiledLayer() sets some dirty flags, but for some properties which have
already been committed in the current flush cycle.

Fix by moving the swapFromOrToTiledLayer() to the top of the commit, which is
safe since it only consults GraphicsLayer properties, not CALayer properties.

Test: compositing/tiling/empty-to-tiled.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::updateLayerDrawsContent):
(WebCore::GraphicsLayerCA::updateContentsScale):

  • platform/graphics/ca/GraphicsLayerCA.h:

(GraphicsLayerCA):

LayoutTests:

Reviewed by Tim Horton.

Ref test that adds visible content to a larger layer.

  • compositing/tiling/empty-to-tiled-expected.html: Added.
  • compositing/tiling/empty-to-tiled.html: Added.
4:56 PM Changeset in webkit [147681] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

Regression(r147639) Causes assertion hit in HashTable
https://bugs.webkit.org/show_bug.cgi?id=113954

Reviewed by Benjamin Poulain.

Lookup the key in the hash table again after the recursive call to
getCachedFontPlatformData() as it may have altered the hash map and
invalidated the previous iterator we had.

No new tests, covered by existing tests.

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::getCachedFontPlatformData):

4:52 PM Changeset in webkit [147680] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Fix webkitpy tests after r147678.

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

(CommitQueueTest.test_commit_queue):
(test_manual_reject_during_processing):

4:35 PM Changeset in webkit [147679] by eric.carlson@apple.com
  • 4 edits in trunk/LayoutTests

Unreviewed, fix a test and some results missed in r147675

  • media/media-captions-expected.txt:
  • media/video-controls-captions-trackmenu-localized.html:
  • platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
4:18 PM Changeset in webkit [147678] by rniwa@webkit.org
  • 2 edits
    1 add in trunk/Tools

The commit queue should use Mac MountainLion port
https://bugs.webkit.org/show_bug.cgi?id=113971

Reviewed by Lucas Forschler.

  • EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
  • Scripts/webkitpy/tool/commands/queues.py:

(CommitQueue):

4:16 PM Changeset in webkit [147677] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Stop pretending that statements return a value
https://bugs.webkit.org/show_bug.cgi?id=113969

Reviewed by Oliver Hunt.

Expressions have an intrinsic value, which they return to their parent
in the AST.

Statements just execute for effect in sequence.

This patch moves emitBytecode into the ExpressionNode and StatementNode
subclasses, and changes the SatementNode subclass to return void. This
eliminates some cruft where we used to return 0, or try to save a bogus
register and return it, as if a statement had a consuming parent in the
AST.

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitNode):
(BytecodeGenerator):
(JSC::BytecodeGenerator::emitNodeInConditionContext):

  • bytecompiler/NodesCodegen.cpp:

(JSC::ConstStatementNode::emitBytecode):
(JSC::BlockNode::emitBytecode):
(JSC::EmptyStatementNode::emitBytecode):
(JSC::DebuggerStatementNode::emitBytecode):
(JSC::ExprStatementNode::emitBytecode):
(JSC::VarStatementNode::emitBytecode):
(JSC::IfNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::CaseClauseNode::emitBytecode):
(JSC::CaseBlockNode::emitBytecodeForBlock):
(JSC::SwitchNode::emitBytecode):
(JSC::LabelNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):
(JSC::TryNode::emitBytecode):
(JSC::ScopeNode::emitStatementsBytecode):
(JSC::ProgramNode::emitBytecode):
(JSC::EvalNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):
(JSC::FuncDeclNode::emitBytecode):

  • parser/NodeConstructors.h:

(JSC::PropertyListNode::PropertyListNode):
(JSC::ArgumentListNode::ArgumentListNode):

  • parser/Nodes.h:

(Node):
(ExpressionNode):
(StatementNode):
(ConstStatementNode):
(BlockNode):
(EmptyStatementNode):
(DebuggerStatementNode):
(ExprStatementNode):
(VarStatementNode):
(IfNode):
(IfElseNode):
(DoWhileNode):
(WhileNode):
(ForNode):
(ForInNode):
(ContinueNode):
(BreakNode):
(ReturnNode):
(WithNode):
(LabelNode):
(ThrowNode):
(TryNode):
(ProgramNode):
(EvalNode):
(FunctionBodyNode):
(FuncDeclNode):
(CaseBlockNode):
(SwitchNode):

3:57 PM Changeset in webkit [147676] by benjamin@webkit.org
  • 2 edits in trunk/LayoutTests

Make fast/events/tabindex-focus-blur-all.html disallow Java so the test runs the same regardless of platform/port
https://bugs.webkit.org/show_bug.cgi?id=113950

Patch by Dave Michael <dmichael@chromium.org> on 2013-04-04
Reviewed by Jer Noble.

This hopefully fixes the test failure seen on Apple Mountain Lion WK2:
http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r147640%20(7636)/results.html
that was introduced in https://bugs.webkit.org/show_bug.cgi?id=32292

  • fast/events/resources/tabindex-focus-blur-all.js: Make the test disallow Java execution. Otherwise, <applet> is focusible on platforms that support Java by default and not focusible elsewhere.
3:23 PM Changeset in webkit [147675] by eric.carlson@apple.com
  • 35 edits in trunk

[Mac] add "automatic" text track menu item
https://bugs.webkit.org/show_bug.cgi?id=113822

Reviewed by Jer Noble.

Source/WebCore:

No new tests, existing tests updated.

  • English.lproj/Localizable.strings: Add new track menu item.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_captionDisplayMode.
(WebCore::HTMLMediaElement::finishParsingChildren): LoadTextTrackResource -> ConfigureTextTracks.
(WebCore::HTMLMediaElement::scheduleDelayedAction): Ditto.
(WebCore::HTMLMediaElement::loadTimerFired): Ditto.
(WebCore::HTMLMediaElement::loadInternal): Ditto. Flag the caption menu as invalid so it will

be rebuilt again.

(WebCore::HTMLMediaElement::mediaPlayerDidAddTrack): LoadTextTrackResource -> ConfigureTextTracks.
(WebCore::HTMLMediaElement::didAddTrack): Ditto.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Deal with new track display modes.
(WebCore::HTMLMediaElement::HTMLMediaElement::hasClosedCaptions): Minor cleanup.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Add some logging.
(WebCore::HTMLMediaElement::configureTextTracks): Call updateActiveTextTrackCues so cue display

is updated.

(WebCore::HTMLMediaElement::captionPreferencesChanged): Deal with new track display modes.
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Add some logging.

  • html/HTMLMediaElement.h: Ditto.
  • html/shadow/MediaControlElementTypes.cpp: Remove trackIndexAttributeName and trackListIndexForElement.
  • html/shadow/MediaControlElementTypes.h: Ditto.
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler): Don't use track index,

everything we need is in the track<->element map now.

(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay): Ditto. Always rebuild the

track list because clear the map each time the menu goes away because it refs every track.

(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu): Don't set the track

index attribute on the menu items, just use the map.

  • html/shadow/MediaControlElements.h:
  • html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsApple::changedClosedCaptionsVisibility): resetTrackListMenu is gone.
(WebCore::MediaControlsApple::reset): Ditto.
(WebCore::MediaControlsApple::closedCaptionTracksChanged): Ditto.

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::captionMenuOffItem): New, static TextTrack used for the menu "Off" item.
(WebCore::TextTrack::captionMenuAutomaticItem): New, static TextTrack used for the menu "Automatic" item.

  • html/track/TextTrack.h:
  • page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::shouldShowCaptions): Removed, we use captionDisplayMode instead.
(WebCore::CaptionUserPreferences::captionDisplayMode): New.
(WebCore::CaptionUserPreferences::setCaptionDisplayMode): New.
(WebCore::CaptionUserPreferences::setPreferredLanguage): Make the parameter a const reference.
(WebCore::CaptionUserPreferences::textTrackSelectionScore): Return 0 if the user doesn't want

captions or subtitles.

(WebCore::CaptionUserPreferences::textTrackLanguageSelectionScore): Take language as a parameter

instead of assuming that it is always the entire language list.

  • page/CaptionUserPreferences.h:
  • page/CaptionUserPreferencesMac.h:
  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::shouldShowCaptions): Removed, we use captionDisplayMode instead.
(WebCore::CaptionUserPreferencesMac::captionDisplayMode): New.
(WebCore::CaptionUserPreferencesMac::setCaptionDisplayMode): New.
(WebCore::CaptionUserPreferencesMac::setPreferredLanguage): Make the parameter a const reference.
(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Deal with "Automatic" mode.

captions or subtitles.

(WebCore::CaptionUserPreferences::textTrackLanguageSelectionScore): Take language as a parameter

instead of assuming that it is always the entire language list.

(WebCore::CaptionUserPreferencesMac::sortedTrackListForMenu): Insert "Off" and "Automatic" items.

  • platform/LocalizedStrings.cpp:

(WebCore::textTrackAutomaticMenuItemText): New.

  • platform/LocalizedStrings.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::languageOfPrimaryAudioTrack): New.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Return the language

of the main audio track.

LayoutTests:

  • media/media-captions.html: Opportunistic fix - don't look at state until we get the 'canplaythrough'

event because the media engine state may not have been processed until that time.

  • media/track/track-cue-container-rendering-position.html: Don't assume that a cue has been

rendered immediately when the 'canplaythrough' event comes through.

  • media/track/track-cue-rendering-mode-changed.html: Ditto.
  • media/track/track-in-band-expected.txt: Don't check if cues have loaded, it doesn't matter

for this test.

  • media/track/track-in-band.html: Ditto.
  • media/track/track-user-preferences-expected.txt: Changed name of utility function from

menuIndexForLanguage to indexOfMenuItemBeginningWith.

  • media/track/track-user-preferences.html: Move menuIndexForLanguage to trackmenu-test.js and

change name to indexOfMenuItemBeginningWith. Clarify the message logged when a track loads
but it should not.

  • media/trackmenu-test.js: Move some functions here from track-user-preferences.html

(trackMenuList):
(indexOfMenuItemBeginningWith):
(selectCaptionMenuItem):

  • media/video-controls-captions-trackmenu-sorted.html: Update for new menu item.
  • media/video-controls-captions-trackmenu.html: Ditto.
  • platform/mac/media/video-controls-captions-trackmenu-expected.txt: Ditto.
  • platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt: Ditto.
3:20 PM Changeset in webkit [147674] by glenn@skynav.com
  • 1 edit
    3 deletes in trunk/LayoutTests

[EFL] Unreviewed gardening. Rebaseline after r147588. Remove overridden pixel results.

  • platform/efl/fast/text/international/003-expected.png: Removed.
  • platform/efl/fast/text/international/text-combine-image-test-expected.png: Removed.
  • platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Removed.
3:01 PM Changeset in webkit [147673] by glenn@skynav.com
  • 1 edit
    6 adds in trunk/LayoutTests

[EFL] Unreviewed gardening. Rebaseline after r147588. Update pixel expectations.

  • platform/efl-wk1/fast/text/international/003-expected.png: Added.
  • platform/efl-wk1/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/efl-wk2/fast/text/international/003-expected.png: Added.
  • platform/efl-wk2/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
2:57 PM Changeset in webkit [147672] by dpranke@chromium.org
  • 2 edits in trunk/Tools

turn off running tests on chromium linux EWS bots
https://bugs.webkit.org/show_bug.cgi?id=113959

Reviewed by Geoffrey Garen.

Now that the Chromium port is no longer being maintained
there's little point in running the tests. Soon we should
just shut this bot off altogether.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(ChromiumLinuxEWS):

2:57 PM Changeset in webkit [147671] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r146580): Assertion using SecurityOrigin::create, URL string is not valid
https://bugs.webkit.org/show_bug.cgi?id=113961

Reviewed by Geoff Garen.

  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::createFromDatabaseIdentifier): (WebCore::SecurityOrigin::create): Don't use ParsedURLString, because http://host:80/ is normalized to http://host/, so it's not a parsed URL string.
2:25 PM Changeset in webkit [147670] by oliver@apple.com
  • 4 edits
    3 adds in trunk

Exception stack unwinding doesn't handle inline callframes correctly
https://bugs.webkit.org/show_bug.cgi?id=113952

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

The basic problem here is that the exception stack unwinding was
attempting to be "clever" and avoid doing a correct stack walk
as it "knew" inline callframes couldn't have exception handlers.

This used to be safe as the exception handling machinery was
designed to fail gently and just claim that no handler existed.
This was "safe" and even "correct" inasmuch as we currently
don't run any code with exception handlers through the dfg.

This patch fixes the logic by simply making everything uniformly
use the safe stack walking machinery, and making the correct
boundary checks occur everywhere that they should.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::findClosureCallForReturnPC):
(JSC::CodeBlock::bytecodeOffset):

  • interpreter/Interpreter.cpp:

(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::getCallerInfo):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::retrieveCallerFromVMCode):

LayoutTests:

Yay tests!

  • fast/js/js-correct-exception-handler-expected.txt: Added.
  • fast/js/js-correct-exception-handler.html: Added.
  • fast/js/script-tests/js-correct-exception-handler.js: Added.

(throwEventually):
(f.g):
(f):
(test):

2:16 PM Changeset in webkit [147669] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Removed a defunct comment
https://bugs.webkit.org/show_bug.cgi?id=113948

Reviewed by Oliver Hunt.

This is also a convenient way to test the EWS.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC):

2:08 PM Changeset in webkit [147668] by glenn@skynav.com
  • 1 edit
    7 adds
    3 deletes in trunk/LayoutTests

[EFL] Unreviewed gardening. Rebaseline after r147588.

  • platform/efl-wk1/fast/text/international: Added.
  • platform/efl-wk1/fast/text/international/003-expected.txt: Added.
  • platform/efl-wk1/fast/text/international/text-combine-image-test-expected.txt: Added.
  • platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
  • platform/efl-wk2/fast/text/international/003-expected.txt: Added.
  • platform/efl-wk2/fast/text/international/text-combine-image-test-expected.txt: Added.
  • platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
  • platform/efl/fast/text/international/003-expected.txt: Removed.
  • platform/efl/fast/text/international/text-combine-image-test-expected.txt: Removed.
  • platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
1:52 PM Changeset in webkit [147667] by commit-queue@webkit.org
  • 5 edits in trunk

Unreviewed, rolling out r147662.
http://trac.webkit.org/changeset/147662
https://bugs.webkit.org/show_bug.cgi?id=113955

The change r147662 breaks fast/regions/fixed-pos-elem-in-
region.html (Requested by benjaminp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-04

Source/WebCore:

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::inlineLogicalWidth):

LayoutTests:

  • fast/inline/inline-with-empty-inline-children-expected.txt:
  • fast/inline/inline-with-empty-inline-children.html:
1:46 PM Changeset in webkit [147666] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. AppleWin port gardening.

  • platform/win/TestExpectations:
1:19 PM Changeset in webkit [147665] by roger_fong@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed. AppleWin port gardening.

  • platform/win/TestExpectations:
  • platform/win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
12:58 PM Changeset in webkit [147664] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r147373): Auto-sizing doesn't always respect minimum width changes
https://bugs.webkit.org/show_bug.cgi?id=113947
<rdar://problem/13579024>

Reviewed by Anders Carlsson.

Reset the FrameView size to the minimum auto-sizing size
before performing auto-sizing. We were already resetting the height,
but not the width, instead using the FrameView's current width.

This means that changing the minimum width without also manually
resizing the FrameView will never see the width change.

Auto-sizing tests are not working on Mac yet.

  • page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled):

12:26 PM Changeset in webkit [147663] by mrobinson@webkit.org
  • 5 edits
    12 deletes in trunk/Source

[GTK] Remove the gyp build
https://bugs.webkit.org/show_bug.cgi?id=113942

Reviewed by Gustavo Noronha Silva.

Source/JavaScriptCore:

Source/ThirdParty/ANGLE:

  • ANGLE.gyp/ANGLE.gyp: Removed.
  • ANGLE.gypi: Removed.

Source/WebCore:

  • WebCore.gyp/WebCoreGTK.gyp: Removed.

Source/WebKit/gtk:

  • gyp/Configuration.gypi.in: Removed.
  • gyp/Dependencies.gyp: Removed.
  • gyp/GNUmakefile: Removed.
  • gyp/autogen.sh: Removed.
  • gyp/configure.ac: Removed.
  • gyp/run-gyp: Removed.

Source/WTF:

  • WTF.gyp/WTFGTK.gyp: Removed.
12:23 PM Changeset in webkit [147662] by robert@webkit.org
  • 5 edits in trunk

REGRESSION(r142152): Text wraps in menu
https://bugs.webkit.org/show_bug.cgi?id=113706

Reviewed by David Hyatt.

Source/WebCore:

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::inlineLogicalWidth): Empty inline elements add their inline border/padding/margin to the width of the
line when we iterate through them in nextLineBreak(), so no need to add them again here when climbing back up
from their first child looking for border/padding/margin to add. (An empty inline element can have floating children.)

LayoutTests:

  • fast/inline/inline-with-empty-inline-children-expected.txt:
  • fast/inline/inline-with-empty-inline-children.html:
12:15 PM Changeset in webkit [147661] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Changing typing style with font size delta overrides the previous font size delta
https://bugs.webkit.org/show_bug.cgi?id=113923

Reviewed by Andreas Kling.

The bug was caused by a new font size delta value overriding the old one as
opposed to being added to the old value. Fixed that in overrideWithStyle.

Also made overrideWithStyle share code with mergeStyle since there is already
code to merge text-decorations there.

Unfortunately, adding a test for this fix proved to be hard because we don't
expose any API to directly set typing style.

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::overrideWithStyle): Use mergeStyle.
(WebCore::EditingStyle::mergeStyle): Add font size deltas as opposed to simply
using the new value.

12:05 PM Changeset in webkit [147660] by Chris Fleizach
  • 4 edits
    2 adds in trunk

AX:File upload button has wrong label
https://bugs.webkit.org/show_bug.cgi?id=113924

Reviewed by David Kilzer.

Source/WebCore:

Allow the label and value to be returned for file upload controls on iOS.
Due to the different AX APIs, we can expose a bit more information on iOS.

Test: platform/iphone-simulator/accessibility/file-upload-button.html

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper stringValueShouldBeUsedInLabel]):
(-[WebAccessibilityObjectWrapper fileUploadButtonReturnsValueInTitle]):

  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(-[WebAccessibilityObjectWrapperBase fileUploadButtonReturnsValueInTitle]):
(-[WebAccessibilityObjectWrapperBase accessibilityTitle]):

LayoutTests:

  • platform/iphone-simulator/accessibility/file-upload-button-expected.txt: Added.
  • platform/iphone-simulator/accessibility/file-upload-button.html: Added.
11:52 AM Changeset in webkit [147659] by dino@apple.com
  • 8 edits in trunk/Source

Expose settings to disable plugin snapshotting autostart and primary detection
https://bugs.webkit.org/show_bug.cgi?id=113918

Reviewed by Tim Horton.

Source/WebCore:

Three new settings:

  • snapshotAllPlugIns: Do not apply any heuristics - immediately snapshot a plugin.
  • primaryPlugInSnapshotDetectionEnabled: Toggle snapshotting the "main" plugin in the page.
  • autostartOriginPlugInSnapshottingEnabled: Toggle snapshotting based on URL origins.
  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Don't tell the host that we've started

if the autostartOriginPlugInSnapshottingEnabled is false.

(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Don't restart a primary

plugin if primaryPlugInSnapshotDetectionEnabled is false.

(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Snapshot immediately if

snapshotAllPlugIns is true. Also, don't test for autostart if
autostartOriginPlugInSnapshottingEnabled is false.

  • page/Settings.in: Three new settings values.

Source/WebKit2:

Three new settings: snapshotAllPlugIns, primaryPlugInSnapshotDetectionEnabled and
autostartOriginPlugInSnapshottingEnabled.
These are exposed via WKPreferences (WebKit2 only, since that's the only port actively
using the feature).

  • Shared/WebPreferencesStore.h: Add macros for new settings.
  • UIProcess/API/C/WKPreferences.cpp: Getters and setters for new settings.

(WKPreferencesSetSnapshotAllPlugIns):
(WKPreferencesGetSnapshotAllPlugIns):
(WKPreferencesSetAutostartOriginPlugInSnapshottingEnabled):
(WKPreferencesGetAutostartOriginPlugInSnapshottingEnabled):
(WKPreferencesSetPrimaryPlugInSnapshotDetectionEnabled):
(WKPreferencesGetPrimaryPlugInSnapshotDetectionEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Forward settings updates.
(WebKit::WebPage::addPluginView): Don't run primary plugin detection if the setting is false.
(WebKit::WebPage::didFinishLoad): Ditto.

11:31 AM Changeset in webkit [147658] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Simplified bytecode generation by merging prefix and postfix nodes
https://bugs.webkit.org/show_bug.cgi?id=113925

Reviewed by Filip Pizlo.

PostfixNode now inherits from PrefixNode, so when we detect that we're
in a context where postifx and prefix are equivalent, PostFixNode can
just call through to PrefixNode codegen, instead of duplicating the
logic.

  • bytecompiler/NodesCodegen.cpp:

(JSC::PostfixNode::emitResolve):
(JSC::PostfixNode::emitBracket):
(JSC::PostfixNode::emitDot):

  • parser/NodeConstructors.h:

(JSC::PostfixNode::PostfixNode):

  • parser/Nodes.h:

(JSC):
(PrefixNode):
(PostfixNode):

11:25 AM Changeset in webkit [147657] by scherkus@chromium.org
  • 2 edits in trunk/Tools

Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.

  • Scripts/webkitpy/common/config/watchlist:
11:22 AM Changeset in webkit [147656] by ggaren@apple.com
  • 1 delete in trunk/LayoutTests/platform/chromium-win-xp

Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.

11:22 AM Changeset in webkit [147655] by ggaren@apple.com
  • 1 delete in trunk/LayoutTests/platform/chromium-win

Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.

11:22 AM Changeset in webkit [147654] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Remove skia code from PluginViewBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=113936

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-04
Reviewed by Rob Buis.

Skia is not used anymore by the BlackBerry port.

  • plugins/blackberry/PluginViewBlackBerry.cpp:

(WebCore::PluginView::paint):

11:22 AM Changeset in webkit [147653] by ggaren@apple.com
  • 1 delete in trunk/LayoutTests/platform/chromium-mac-snowleopard

Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.

11:19 AM Changeset in webkit [147652] by ggaren@apple.com
  • 1 delete in trunk/LayoutTests/platform/chromium-mac-mountainlion

Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.

11:19 AM Changeset in webkit [147651] by ggaren@apple.com
  • 1 delete in trunk/LayoutTests/platform/chromium-mac-lion

Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.

11:19 AM Changeset in webkit [147650] by ggaren@apple.com
  • 1 delete in trunk/LayoutTests/platform/chromium-mac

Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.

11:19 AM Changeset in webkit [147649] by ggaren@apple.com
  • 1 delete in trunk/LayoutTests/platform/chromium-linux-x86

Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.

11:19 AM Changeset in webkit [147648] by ggaren@apple.com
  • 1 delete in trunk/LayoutTests/platform/chromium-linux

Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.

11:19 AM Changeset in webkit [147647] by ggaren@apple.com
  • 1 delete in trunk/LayoutTests/platform/chromium-android

Removed Chromium layout test results. Reviewed by Anders Carlsson. I'm using a direct svn http command to try to reduce email traffic.

11:17 AM Changeset in webkit [147646] by ggaren@apple.com
  • 1 delete in trunk/LayoutTests/platform/chromium

Removed Chromium layout test results.\n\nReviewed by Anders Carlsson.\n\nI'm using a direct svn http command to try to reduce email traffic.

11:10 AM Changeset in webkit [147645] by eae@chromium.org
  • 3 edits
    2 adds in trunk

Source/WebCore: Change RenderFrameSet::computeEdgeInfo to use m-rows/m_cols directly
https://bugs.webkit.org/show_bug.cgi?id=113825

Reviewed by Eric Seidel.

Tests: fast/frames/invalid-frameset-compute-edge.html

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::computeEdgeInfo):

LayoutTests: Change RenderFrameSet::computeEdgeInfo to use m-rows/m_cols directly
https://bugs.webkit.org/show_bug.cgi?id=113825

Reviewed by Eric Seidel.

Add test for accessing an invalid frame.

  • fast/frames/invalid-frameset-compute-edge-expected.html: Added.
  • fast/frames/invalid-frameset-compute-edge.html: Added.
11:00 AM Changeset in webkit [147644] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK][AC] Invalid clear ClutterContent of ClutterActor
https://bugs.webkit.org/show_bug.cgi?id=113758

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-04
Reviewed by Gustavo Noronha Silva.

Using clutter_actor_set_content(actor, 0) is better to clear ClutterContent of ClutterActor.
Actually the ClutterContent referece is cleared in the API if we set 0.

No new tests since no functionality changed.

  • platform/graphics/clutter/GraphicsLayerActor.cpp:

(graphicsLayerActorUpdateTexture):

10:59 AM Changeset in webkit [147643] by Christophe Dumez
  • 37 edits
    4 adds
    2 deletes in trunk

[Cairo] Fix canvas drawing of SVG-based patterns and remove NativeImageCairo
https://bugs.webkit.org/show_bug.cgi?id=113929

Reviewed by Martin Robinson.

Source/WebCore:

Make (Pass)NativeImagePtr typedefs to (Pass)RefPtr<cairo_surface_t> instead
of NativeImageCairo*. Now that we switch to using smart pointers,
NativeImageCairo is removed as it made no sense to make it ref counted when
it merely held a single ref counted member.

Now that Cairo is using smart pointers for (Pass)NativeImagePtr, this patch
also enables the implementation of SVGImage::nativeImageForCurrentFrame()
for USE(CAIRO) as well. This effectively fixes canvas drawing of SVG-based
patterns for Cairo-based ports.

No new tests, covered by svg/canvas/canvas-pattern-svg.html.

  • GNUmakefile.list.am: Remove NativeImageCairo.* for GTK.
  • PlatformEfl.cmake: Remove NativeImageCairo.* for EFL.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:

Remove NativeImageCairo.* for Win.

  • platform/graphics/BitmapImage.cpp:

(WebCore::FrameData::reportMemoryUsage):
Update MemoryClassInfo::addRawBuffer() call now that m_frame is a RefPtr
for USE(CAIRO).

  • platform/graphics/BitmapImage.h:

(BitmapImage):
Remove factory method taking a cairo_surface_t* in argument. This is useless
now that PassNativeImagePtr is a typedef to PassRefPtr<cairo_surface_t> and
there is already a factory method taking a PassNativeImagePtr in argument.

  • platform/graphics/NativeImagePtr.h:

(WebCore):
Make PassNativeImagePtr a typedef to PassRefPtr<cairo_surface_t> and
NativeImagePtr a typedef to RefPtr<cairo_surface_t>, instead of
NativeImageCairo*. Moving to smart pointers is needed to enable implementation
of SVGImage::nativeImageForCurrentFrame() for Cairo.

  • platform/graphics/cairo/BitmapImageCairo.cpp:

(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::checkForSolidColor):
(WebCore::FrameData::clear):

  • platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

  • platform/graphics/cairo/ImageCairo.cpp:

(WebCore::Image::drawPattern):
Update Cairo graphics code to reflect the (Pass)NativeImagePtr type changes.

  • platform/graphics/cairo/NativeImageCairo.cpp: Removed.
  • platform/graphics/cairo/NativeImageCairo.h: Removed.
  • platform/graphics/cairo/PatternCairo.cpp:

(WebCore::Pattern::createPlatformPattern):

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

  • platform/graphics/efl/ImageEfl.cpp:

(WebCore::BitmapImage::getEvasObject):

  • platform/graphics/gtk/ImageGtk.cpp:

(WebCore::BitmapImage::getGdkPixbuf):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::updateContents):

  • platform/graphics/win/ImageCairoWin.cpp:

(WebCore::BitmapImage::create):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

  • platform/gtk/DragImageGtk.cpp:

(WebCore::createDragImageFromImage):

  • platform/image-decoders/cairo/ImageDecoderCairo.cpp:

(WebCore::ImageFrame::asNewNativeImage):

  • platform/win/DragImageCairoWin.cpp:

(WebCore::createDragImageFromImage):
Update code to reflect the (Pass)NativeImagePtr type changes.

  • svg/graphics/SVGImage.cpp:

(WebCore):

  • svg/graphics/SVGImage.h:

Enable SVGImage::nativeImageForCurrentFrame() for USE(CAIRO).

Source/WebKit:

Remove outdated symbols now that NativeImageCairo was removed.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/efl:

Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
instead of NativeImageCairo*.

  • ewk/ewk_history.cpp:

(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):

  • ewk/ewk_settings.cpp:

(ewk_settings_icon_database_icon_surface_get):
(ewk_settings_icon_database_icon_object_get):

Source/WebKit/gtk:

Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
instead of NativeImageCairo*.

  • webkit/webkitfavicondatabase.cpp:

(getIconPixbufSynchronously):

Source/WebKit/win:

Remove outdated symbols now that NativeImageCairo was removed.

  • WebKit.vcproj/WebKitExports.def.in:

Source/WebKit2:

Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
instead of NativeImageCairo*.

  • Shared/gtk/ArgumentCodersGtk.cpp:

(CoreIPC::decodeImage):

  • UIProcess/API/C/cairo/WKIconDatabaseCairo.cpp:

(WKIconDatabaseTryGetCairoSurfaceForURL):

  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp:

(getIconSurfaceSynchronously):

LayoutTests:

Add EFL / GTK pixels results for svg/canvas/canvas-pattern-svg.html now that
the test passes for cairo-based ports.

  • platform/efl/svg/canvas/canvas-pattern-svg-expected.png: Added.
  • platform/gtk/svg/canvas/canvas-pattern-svg-expected.png: Added.
10:48 AM Changeset in webkit [147642] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] --minimal build fails with 'error: unused variable'
https://bugs.webkit.org/show_bug.cgi?id=113903

Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-04
Reviewed by Gustavo Noronha Silva.

Moved variable definition under #if where it's used

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::restartedCallback):

10:30 AM Changeset in webkit [147641] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

ObjcRuntimeExtras.h should use variadic templates
https://bugs.webkit.org/show_bug.cgi?id=113941

Reviewed by Andreas Kling.

Reimplement wtfObjcMsgSend and wtfCallIMP as variadic function templates.

  • wtf/ObjcRuntimeExtras.h:

(wtfObjcMsgSend):
(wtfCallIMP):

9:40 AM Changeset in webkit [147640] by abecsi@webkit.org
  • 4 edits in trunk/Source

Fix the build with GCC 4.8
https://bugs.webkit.org/show_bug.cgi?id=113147

Reviewed by Allan Sandfeld Jensen.

Source/JavaScriptCore:

Initialize JSObject* exception to suppress warnings that make
the build fail because of -Werror=maybe-uninitialized.

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

Source/WTF:

Disable diagnostic warning -Wunused-local-typedefs for GCC 4.8
since dummy typedefs are commonly used in the codebase.

  • wtf/Compiler.h:
9:37 AM Changeset in webkit [147639] by akling@apple.com
  • 12 edits in trunk/Source/WebCore

Global FontPlatformData cache should use OwnPtr.
<http://webkit.org/b/111939>

Reviewed by Anders Carlsson.

Let the global FontPlatformData use OwnPtr instead of raw pointers + deleteAllValues().

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::purgeInactiveFontData):
(WebCore::FontCache::invalidate):

Tweaked code for OwnPtr. Also made getCachedFontPlatformData() do one hash lookup
instead of two.

  • platform/graphics/FontCache.h:
  • platform/graphics/blackberry/FontCacheBlackBerry.cpp:

(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/chromium/FontCacheAndroid.cpp:

(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/qt/FontCacheQt.cpp:

(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/skia/FontCacheSkia.cpp:

(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/wince/FontCacheWinCE.cpp:

(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/wx/FontCacheWx.cpp:

(WebCore::FontCache::createFontPlatformData):

FontCache::createFontPlatformData() now returns a PassOwnPtr.

9:28 AM Changeset in webkit [147638] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Render images with low-quality scaling while FrameView is being resized.
<http://webkit.org/b/113764>
<rdar://problem/13555154>

Reviewed by Antti Koivisto.

Have ImageQualityController ask the renderer's containing FrameView if it's currently in live
resize, and if so, paint all images with low-quality scaling. A high-quality repaint will happen
~0.5 sec after live resizing ends, piggybacking on the same mechanism we use to do JS-animated
resizing with low-quality scaling.

This reduces CPU time spent generating new tiles during live window resize, especially on Retina
systems where a lot of upscaling happens on legacy web content.

  • rendering/RenderBoxModelObject.cpp:

(ImageQualityController):

Added an m_liveResizeOptimizationIsActive flag that tracks whether the ImageQualityController
is painting everything in low quality due to live window resize. It gets unset when the HQ
repaint timer fires and everything has been repainted properly.

(WebCore::ImageQualityController::highQualityRepaintTimerFired):

When the HQ repaint timer fires, check if the renderer's containing FrameView is still in
live resize, and if so, abort HQ repaint for now and reschedule the timer.

(WebCore::ImageQualityController::ImageQualityController):
(WebCore::ImageQualityController::objectDestroyed):
(WebCore::ImageQualityController::shouldPaintAtLowQuality):

9:18 AM Changeset in webkit [147637] by commit-queue@webkit.org
  • 14 edits in trunk/Source

[Qt] docs: Fix module name format
https://bugs.webkit.org/show_bug.cgi?id=113209

Patch by Sze Howe Koh <szehowe.koh@gmail.com> on 2013-04-04
Reviewed by Jocelyn Turcotte.

Make QDoc-generated documentation follow the conventions at
http://qt-project.org/wiki/Spelling_Module_Names_in_Qt_Documentation

Source/WebKit/qt:

  • Api/qwebdatabase.cpp:
  • Api/qwebkitglobal.cpp:
  • Api/qwebpluginfactory.cpp:
  • Api/qwebsettings.cpp:
  • WidgetApi/qgraphicswebview.cpp:
  • WidgetApi/qwebframe.cpp:
  • WidgetApi/qwebpage.cpp:
  • WidgetApi/qwebview.cpp:
  • docs/qtwebkit-bridge.qdoc:
  • docs/qtwebkit-goes-mobile.qdoc:
  • docs/qtwebkit.qdoc:

Source/WebKit2:

  • UIProcess/API/qt/qquickwebview.cpp:
9:17 AM Changeset in webkit [147636] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: fix closure compiler warnings in IndexedDBModel.js
https://bugs.webkit.org/show_bug.cgi?id=113926

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-04
Reviewed by Alexander Pavlov.

No new tests: no change in behaviour.

  • inspector/front-end/IndexedDBModel.js:
9:01 AM Changeset in webkit [147635] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION (r145870): Can't get insertion point to appear in some input and textareas on wordpress
https://bugs.webkit.org/show_bug.cgi?id=113591

Patch by Xidorn Quan <quanxunzhen@gmail.com> on 2013-04-04
Reviewed by Simon Fraser.

Source/WebCore:

Since a child node could overflow its ancestor, it is not wise to check
one's radii boundary before checking whether the given point intersects
its children. This patch moves the related code down to fix the bug.

Test: fast/borders/border-radius-child.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):

LayoutTests:

  • fast/borders/border-radius-child-expected.txt: Added.
  • fast/borders/border-radius-child.html: Added.
8:53 AM Changeset in webkit [147634] by pierre.rossi@gmail.com
  • 2 edits in trunk/Tools

Indentation fix to get webkit-patch working again after r147625

Unreviewed.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(MacEWS):
(MacWK2EWS):

8:32 AM Changeset in webkit [147633] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.8/Source/WebKit2

Merged r147592. <rdar://problem/13540351>

8:29 AM Changeset in webkit [147632] by Lucas Forschler
  • 10 edits in tags/Safari-537.35.8/Source

Merged r147579. <rdar://problem/13478573>

8:26 AM Changeset in webkit [147631] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.8/Source/WebKit2

Merged r147500. <rdar://problem/13159030>

8:23 AM Changeset in webkit [147630] by Lucas Forschler
  • 6 edits in tags/Safari-537.35.8/Source/WebKit2

Merged r147489. <rdar://problem/12679817>

8:20 AM Changeset in webkit [147629] by Lucas Forschler
  • 13 edits
    2 copies in tags/Safari-537.35.8

Merged r147471. <rdar://problem/13522402>

8:15 AM Changeset in webkit [147628] by commit-queue@webkit.org
  • 4 edits in trunk

[GStreamer] Virtual modifier for MediaPlayer::simulateAudioInterruption must go
https://bugs.webkit.org/show_bug.cgi?id=113851

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-04-04
Reviewed by Eric Carlson.

.:

  • Source/autotools/symbols.filter: Added

_ZN7WebCore11MediaPlayer25simulateAudioInterruptionEv symbol.

Source/WebCore:

  • platform/graphics/MediaPlayer.h:

(MediaPlayer): Removed virtual modifier to
simulateAudioInterruption.

8:14 AM Changeset in webkit [147627] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.8/Source/JavaScriptCore

Merged r147079. <rdar://problem/13519289>

8:12 AM Changeset in webkit [147626] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.8/Source/JavaScriptCore

Merged r147017. <rdar://problem/13519289>

8:06 AM Changeset in webkit [147625] by Lucas Forschler
  • 2 edits in trunk/Tools

Turn tests back on for Mac WK1/WK2 EWS.

Unreviewed.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(MacEWS):
(MacWK2EWS):

6:26 AM Changeset in webkit [147624] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[GTK][WK2] MiniBrowser custom URI scheme support
https://bugs.webkit.org/show_bug.cgi?id=112419

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-04
Reviewed by Carlos Garcia Campos.

Add support for about URIs in MiniBrowser. An example about page is show
with URI "about:minibrowser", the rest of the cases it will show a
proper message explaining that the about page didn't exist.

Internally it uses "minibrowser-about" prefix instead of "about", but
from the user point of view it works with "about" prefix.

  • MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.

(getInternalURI): Method to convert URIs from "about" prefix to
"minibrowser-about".
(getExternalURI): Opposite method.
(webViewURIChanged): Use "about" prefix to show the URI to users.
(webViewEnterFullScreen): Ditto.
(browser_window_load_uri): Use "minibrowser-about" prefix internally.

  • MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.

(aboutURISchemeRequestCallback): Callback to manage about calls.
(main): Register the URI scheme to manage about URIs.

6:20 AM Changeset in webkit [147623] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Support -webkit-font-smoothing
https://bugs.webkit.org/show_bug.cgi?id=106009

Reviewed by Jocelyn Turcotte.

Remove false dependency on Qt 5.1 for the -webkit-font-smoothing property.
For now we are still keeping the dependency on Font::shouldUseSmoothing().

  • platform/graphics/qt/FontPlatformDataQt.cpp:

(WebCore::FontPlatformData::FontPlatformData):

5:05 AM Changeset in webkit [147622] by Christophe Dumez
  • 51 edits
    5 adds in trunk

Regression(r142765) Broke Custom SVG cursors and SVG canvas drawing for Chromium
https://bugs.webkit.org/show_bug.cgi?id=113420

Reviewed by Stephen White.

Source/WebCore:

Introduce a PassNativeImagePtr typedef that is used in place of NativeImagePtr
for method arguments and return values. This is needed as Skia now maps
NativeImagePtr to RefPtr<NativeImageSkia> and PassNativeImagePtr to
PassRefPtr<NativeImageSkia>. We move towards ref counted smart pointers so that
SVGImage::nativeImageForCurrentFrame() can transfer ownership of the native
image to the caller if needed (e.g. for SVGImage).

Provide nativeImageForCurrentFrame() implementation for SVGImage. SVGImage no
longer holds the native image internally, to save memory. It is therefore created
when nativeImageForCurrentFrame() is called and ownership is passed to the
caller. For now, this implementation is only enabled for Skia as others are using
raw pointers for PassNativeImagePtr.

Test: svg/canvas/canvas-pattern-svg.html

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::synchronousNativeIconForPageURL):
Return a PassNativeImagePtr instead of NativeImagePtr.

  • loader/icon/IconDatabase.h:

(IconDatabase):

  • loader/icon/IconDatabaseBase.h:

(WebCore::IconDatabaseBase::synchronousNativeIconForPageURL):
Return a PassNativeImagePtr instead of NativeImagePtr.

  • platform/chromium/DragImageChromiumSkia.cpp:

(WebCore::createDragImageFromImage):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead of a raw
one.

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeImage):
Store return value of nativeImageForCurrentFrame() in a RefPtr<NativeImageSkia>
instead of a NativeImagePtr. While these are equivalent, the former is more
readable in Skia-specific code.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::frameAtIndex):
Return a PassNativeImagePtr instead of a NativeImagePtr.

(WebCore::BitmapImage::nativeImageForCurrentFrame):
Return a PassNativeImagePtr instead of a NativeImagePtr.

  • platform/graphics/BitmapImage.h:

(WebCore::BitmapImage::create):
Take a PassNativeImagePtr in argument instead of a NativeImagePtr.

(BitmapImage): Ditto.

  • platform/graphics/GraphicsContext.h:

(GraphicsContext): Ditto.

  • platform/graphics/GraphicsContext3D.h:

(ImageExtractor):
Keep NativeImageSkia in a RefPtr instead of OwnPtr, now that it is refcounted.

  • platform/graphics/Image.h:

(WebCore::Image::nativeImageForCurrentFrame):
Return a PassNativeImagePtr instead of a NativeImagePtr.

  • platform/graphics/ImageBuffer.h:

(ImageBuffer):
Have copyNativeImage() return a PassNativeImagePtr instead of a NativeImagePtr.

  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::createFrameAtIndex):
Return a PassNativeImagePtr instead of a NativeImagePtr.

  • platform/graphics/ImageSource.h:

Have createFrameAtIndex() return a PassNativeImagePtr instead of a NativeImagePtr.

  • platform/graphics/NativeImagePtr.h:

Map NativeImagePtr to a RefPtr<NativeImageSkia> instead of NativeImageSkia* for Skia.
Introduce new PassNativeImagePtr that maps to PassRefPtr<NativeImageSkia> for Skia
and is equivalent to NativeImagePtr for other ports. We now use smart pointers for
the native image so that SVGImage::nativeImageForCurrentFrame() can pass ownership
of the native image to the caller, unlike BitmapImage::nativeImageForCurrentFrame().

  • platform/graphics/blackberry/ImageBlackBerry.cpp:

(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.

(WebCore::BitmapImage::BitmapImage):
Take a PassNativeImagePtr instead of a NativeImagePtr in argument.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawNativeImage): Ditto.

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::copyNativeImage):
Take a PassNativeImagePtr instead of a NativeImagePtr in argument.

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToImage):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead of a raw one.

  • platform/graphics/filters/skia/FEBlendSkia.cpp:

(WebCore::FEBlend::platformApplySkia): Ditto.

  • platform/graphics/filters/skia/FEColorMatrixSkia.cpp:

(WebCore::FEColorMatrix::platformApplySkia): Ditto.

  • platform/graphics/filters/skia/FEComponentTransferSkia.cpp:

(WebCore::FEComponentTransfer::platformApplySkia): Ditto.

  • platform/graphics/filters/skia/FEDisplacementMapSkia.cpp:

(WebCore::FEDisplacementMap::platformApplySkia): Ditto.

  • platform/graphics/filters/skia/FELightingSkia.cpp:

(WebCore::FELighting::platformApplySkia): Ditto.

  • platform/graphics/qt/ImageDecoderQt.cpp:

(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.

  • platform/graphics/qt/StillImageQt.cpp:

(WebCore::StillImage::nativeImageForCurrentFrame):
Return a PassNativeImagePtr instead of a NativeImagePtr.

  • platform/graphics/qt/StillImageQt.h:

(StillImage): Ditto.

  • platform/graphics/skia/GraphicsContext3DSkia.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
No longer need to adopt the return value of asNewNativeImage() now
that it returns a PassRefPtr instead of a raw one.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
Call NativeImageSkia::create() factory method now that the constructor
is private.

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::FrameData::clear):
Just call clear() on m_frame instead of explicitely deleting it now
that it is a RefPtr.

(WebCore::Image::drawPattern):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead
of a raw one.

(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::checkForSolidColor):
Store return value of frameAtIndex() in a RefPtr instead of a raw one.

(WebCore::BitmapImage::draw):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead
of a raw one.

  • platform/graphics/skia/NativeImageSkia.cpp:

Add new constructor taking all members in argument. This is used for
cloning a NativeImageSkia object.

(WebCore::NativeImageSkia::NativeImageSkia):
(WebCore::NativeImageSkia::deepSkBitmapCopy):
Add convenience function to make a deep copy of a SkBitmap.

  • platform/graphics/skia/NativeImageSkia.h:

(WebCore):
(WebCore::NativeImageSkia::create):
(NativeImageSkia):
Make NativeImageSkia subclass RefCounted. Make the constructor private
and add a factory method instead that returns a PassRefPtr.

(WebCore::NativeImageSkia::clone):
Add a clone() method now that NativeImageSkia is refcounted and is no
longer copyable.

  • platform/graphics/skia/PatternSkia.cpp:

(WebCore::Pattern::platformPattern):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead
of a raw one.

  • platform/graphics/wince/ImageWinCE.cpp:

(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.

  • platform/image-decoders/ImageDecoder.h:

(ImageFrame):
Have asNewNativeImage() return a PassNativeImagePtr instead of a
NativeImagePtr.

(WebCore::ImageFrame::getAddr):
(WebCore::ImageFrame::setSkBitmap):
(WebCore::ImageFrame::getSkBitmap):
(WebCore::ImageFrame::width):
(WebCore::ImageFrame::height):
Update use of m_bitmap now that it is a pointer type and call
NativeImageSkia::create() to construct a NativeImageSkia object now
that the constructor is private.

  • platform/image-decoders/cairo/ImageDecoderCairo.cpp:

(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.

  • platform/image-decoders/openvg/ImageDecoderOpenVG.cpp:

(WebCore::ImageFrame::asNewNativeImage): Ditto.

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::ImageFrame::ImageFrame):
Initialize m_bitmap in the constructor now that it is a pointer
type and we need NativeImageSkia's default constructor to be
called.

(WebCore::ImageFrame::operator=):
Call NativeImageSkia's new clone() method to copy m_bitmap as
NativeImageSkia is now RefCounted and no longer copyable.

(WebCore::ImageFrame::clearPixelData):
(WebCore::ImageFrame::zeroFillPixelData):
(WebCore::ImageFrame::copyBitmapData):
(WebCore::ImageFrame::setSize):
Update use of m_bitmap now that it is a pointer type.

(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.
Call NativeImageSkia's clone method now that it is no longer
copyable.

(WebCore::ImageFrame::setHasAlpha):
(WebCore::ImageFrame::setStatus):
Update use of m_bitmap now that it is a pointer type.

  • platform/image-decoders/wx/ImageDecoderWx.cpp:

(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.

  • svg/graphics/SVGImage.cpp:

(WebCore):
(WebCore::SVGImage::nativeImageForCurrentFrame):
Add implementation of nativeImageForCurrentFrame() for SVGImage as
it is needed for SVG custom cursor support and Canvas drawing of
patterns containing SVG images. As SVGImage no longer keep the
native image internally to save memory, the implementation creates
the native image when nativeImageForCurrentFrame() and passes
its ownership to the caller.

  • svg/graphics/SVGImage.h:

Override Image::nativeImageForCurrentFrame() and remove dummy
implementation of frameAtIndex() as it is not needed / used.

  • svg/graphics/SVGImageForContainer.cpp:

(WebCore::SVGImageForContainer::nativeImageForCurrentFrame):
Add implementation of nativeImageForCurrentFrame() which merely
forwards the call to the Image being contained.

  • svg/graphics/SVGImageForContainer.h:

Override Image::nativeImageForCurrentFrame().

Source/WebKit/chromium:

Update code now that Image::nativeImageForCurrentFrame() and
ImageFrame::asNewNativeImage() return a smart pointer instead
of a raw one.

  • src/WebImageDecoder.cpp:

(WebKit::WebImageDecoder::getFrameAtIndex):

  • src/WebImageSkia.cpp:

(WebKit::WebImage::fromData):
(WebKit::WebImage::framesFromData):
(WebKit::WebImage::operator=):

  • tests/DeferredImageDecoderTest.cpp:

(WebCore::TEST_F):

  • tests/DragImageTest.cpp:

(WebCore::TestImage::TestImage):
(WebCore::TestImage::nativeImageForCurrentFrame):
(TestImage):

  • tests/ImageLayerChromiumTest.cpp:

(WebCore::TestImage::TestImage):
(WebCore::TestImage::nativeImageForCurrentFrame):
(TestImage):

  • tests/PlatformContextSkiaTest.cpp:

(WebCore::TEST):

LayoutTests:

Add layout test to check that drawing canvas patterns containing SVG images works.

  • platform/chromium-linux/svg/canvas/canvas-pattern-svg-expected.png: Added.
  • svg/canvas/canvas-pattern-svg-expected.txt: Added.
  • svg/canvas/canvas-pattern-svg.html: Added.
4:11 AM Changeset in webkit [147621] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk/LayoutTests

[SOUP] inspector/timeline/timeline-receive-response-event.html fails
https://bugs.webkit.org/show_bug.cgi?id=113860

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-04
Reviewed by Xan Lopez.

Copy the results of inspector/timeline/timeline-receive-response-event.html
to the efl and gtk platform dir.
Because test files are bigger than buffer size of ResourceHandleSoup.

  • platform/efl/TestExpectations:
  • platform/efl/inspector/timeline/timeline-receive-response-event-expected.txt: Added.
  • platform/gtk/TestExpectations:
  • platform/gtk/inspector/timeline/timeline-receive-response-event-expected.txt: Added.
4:10 AM Changeset in webkit [147620] by abucur@adobe.com
  • 3 edits in trunk/Source/WebCore

[CSSRegions] RenderFlowThread::renderRegionForLine should use a faster search method
https://bugs.webkit.org/show_bug.cgi?id=66921

Reviewed by David Hyatt.

The RenderFlowThread::regionAtBlockOffset() function is a hot path for the code using
flow threads because it translates from block coordinates to regions.
Currently the method is O(n), using a linear search through the regions chain to find the
region where a block offset lands.
The patch improves this search by using an interval tree (PODIntervalTree). Before a flow
thread is laid out, each region is updated to hold the size of the portion of the flow it
will receive. This information is gathered inside the interval tree and used to speedup the
search in RenderFlowThread::regionAtBlockOffset(). The algorithm uses a custom adapter
simplified for looking up offsets inside the interval tree.
For now, the interval tree is cleared every time the flow thread portions list is updated.
The implementation can be improved but induces some cmplexity as we'd have to manually manage
the life cycle of the tree's nodes. The performance gains are good enough as is to make this
only optional.
Another important change is now the flow thread portion rectangles will not overflow when
using auto-height regions (or very large regions). The maximum size of the flow is set to
LayoutUnit::max()/2. Any region forcing a greater size will be capped so the thread
won't overflow.

Performance test results:
/Layout/RegionsAuto:Time ms 699.95 181.20 74.11% Better
/Layout/RegionsAutoMaxHeight:Time ms 2083.00 308.55 85.19% Better
/Layout/RegionsFixed:Time ms 726.10 223.65 69.20% Better
/Layout/RegionsFixedShort:Time ms 869.60 288.25 66.85% Better

Tests: See PerformanceTests/Layout/Regions*

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::regionAtBlockOffset):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::RegionSearchAdapter::collectIfNeeded):
(WebCore):

  • rendering/RenderFlowThread.h:

(WebCore):

4:07 AM Changeset in webkit [147619] by jochen@chromium.org
  • 2 edits in trunk/LayoutTests

[EFL][Qt] The layout test fast/loader/url-selected-user-gesture.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=113930

Reviewed by Antti Koivisto.

  • fast/loader/url-selected-user-gesture.html:
3:52 AM Changeset in webkit [147618] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk

[Qt] WebSocket errors should be logged to console
https://bugs.webkit.org/show_bug.cgi?id=113842

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-04
Reviewed by Jocelyn Turcotte.

Source/WebCore:

Pass the reason of a failure to SocketStreamError instance
and notify it via SocketStreamHandleClient::didFailSocketStream().

Test : http/tests/inspector/console-websocket-error.html

  • platform/network/qt/SocketStreamError.h:

(WebCore::SocketStreamError::SocketStreamError):

  • platform/network/qt/SocketStreamHandleQt.cpp:

(WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate):
(WebCore::SocketStreamHandlePrivate::socketErrorCallback):

LayoutTests:

  • platform/qt/TestExpectations:
  • platform/qt/http/tests/inspector/console-websocket-error-expected.txt: Added.
3:47 AM Changeset in webkit [147617] by mikhail.pozdnyakov@intel.com
  • 7 edits in trunk/Source/WebKit2

[WK2][EFL] WebView should own view size
https://bugs.webkit.org/show_bug.cgi?id=110753

Reviewed by Andreas Kling.

WebView owns view size. WKViewGetSize and WKViewSetSize API
is exposed accordingly. Usage of EFL-specific ewkView inside
toolkit-agnostic WebView class is reduced.

  • UIProcess/API/C/efl/WKView.cpp:

(WKViewGetSize):
(WKViewSetSize):

  • UIProcess/API/C/efl/WKView.h:
  • UIProcess/API/efl/EwkView.cpp:

(EwkView::setDeviceScaleFactor):
(EwkView::size):
(EwkView::deviceSize):
(EwkView::scheduleUpdateDisplay):
(EwkView::handleEvasObjectCalculate):

  • UIProcess/API/efl/EwkView.h:

(EwkView):

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::setSize):
(WebKit):
(WebKit::WebView::paintToCurrentGLContext):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::viewSize):
(WebKit::WebView::dipSize):

  • UIProcess/efl/WebView.h:

(WebView):
(WebKit::WebView::size):

2:40 AM Changeset in webkit [147616] by kadam@inf.u-szeged.hu
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/TestExpectations: Skipped some failing tests.
  • platform/qt/fast/borders/rtl-border-04-expected.png: Updated after r147588.
  • platform/qt/fast/borders/rtl-border-04-expected.txt: Updated after r147588.
1:39 AM Changeset in webkit [147615] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[ATK] build fails when accessibility is turned off
https://bugs.webkit.org/show_bug.cgi?id=113699

Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-04
Reviewed by Gyuyoung Kim.

  • editing/atk/FrameSelectionAtk.cpp: Wrapped accessibility code in #if HAVE(ACCESSIBILITY)
12:59 AM Changeset in webkit [147614] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: fix closure compiler warnings in the profiler code HeapSnapshotDataGrids.js
https://bugs.webkit.org/show_bug.cgi?id=113922

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-04
Reviewed by Yury Semikhatsky.

No new tests: no change in behaviour.

  • inspector/front-end/HeapSnapshotDataGrids.js:
12:30 AM Changeset in webkit [147613] by glenn@skynav.com
  • 9 edits
    7 adds in trunk/LayoutTests

[Mac] Unreviewed gardening. Rebaseline after r147588.

  • platform/mac-lion/fast/text/international/text-combine-image-test-expected.png:
  • platform/mac-lion/fast/text/international/text-combine-image-test-expected.txt:
  • platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/mac-wk2/fast/text: Added.
  • platform/mac-wk2/fast/text/international: Added.
  • platform/mac-wk2/fast/text/international/003-expected.png: Added.
  • platform/mac-wk2/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/mac-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/mac/fast/text/international/003-expected.png:
  • platform/mac/fast/text/international/003-expected.txt:
  • platform/mac/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/mac/fast/text/international/text-combine-image-test-expected.txt:
  • platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:

Apr 3, 2013:

11:02 PM Changeset in webkit [147612] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

11:00 PM Changeset in webkit [147611] by Lucas Forschler
  • 4 edits in tags/Safari-537.35.8/Source

Versioning.

10:57 PM Changeset in webkit [147610] by Lucas Forschler
  • 1 copy in tags/Safari-537.35.8

New Tag.

10:55 PM Changeset in webkit [147609] by fpizlo@apple.com
  • 29 edits
    4 adds in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: put DFG data into a DFG::JITCode, and put common DFG and FTL data into something accessible from both DFG::JITCode and FTL::JITCode
https://bugs.webkit.org/show_bug.cgi?id=113905

Reviewed by Geoffrey Garen.

This removes one pointer from CodeBlock.

It also gives us a framework for having JITType-specific data in CodeBlock, by
putting it into the appropriate JITCode class (either DFG::JITCode or
FTL::JITCode). And it allows us to have DFG and FTL share some common data,
via DFG::CommonData, which is stored in both DFG::JITCode and FTL::JITCode and
always accessible via JITCode::dfgCommon().

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.cpp:

(JSC):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::performTracingFixpointIteration):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitWeakReferences):
(JSC::CodeBlock::shrinkToFit):
(JSC::CodeBlock::tallyFrequentExitSites):

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::shouldImmediatelyAssumeLivenessDuringScan):
(JSC::DFGCodeBlocks::mark):

  • dfg/DFGAssemblyHelpers.h:
  • dfg/DFGCommonData.cpp: Added.

(DFG):
(JSC::DFG::CommonData::notifyCompilingStructureTransition):
(JSC::DFG::CommonData::shrinkToFit):

  • dfg/DFGCommonData.h: Added.

(JSC):
(DFG):
(JSC::DFG::WeakReferenceTransition::WeakReferenceTransition):
(WeakReferenceTransition):
(CommonData):
(JSC::DFG::CommonData::CommonData):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):

  • dfg/DFGDriver.h:

(DFG):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):

  • dfg/DFGGraph.h:

(Graph):

  • dfg/DFGJITCode.cpp: Added.

(DFG):
(JSC::DFG::JITCode::JITCode):
(JSC::DFG::JITCode::~JITCode):
(JSC::DFG::JITCode::dfgCommon):
(JSC::DFG::JITCode::dfg):
(JSC::DFG::JITCode::shrinkToFit):

  • dfg/DFGJITCode.h: Added.

(DFG):
(JITCode):
(JSC::DFG::JITCode::appendOSREntryData):
(JSC::DFG::JITCode::osrEntryDataForBytecodeIndex):
(JSC::DFG::JITCode::appendOSRExit):
(JSC::DFG::JITCode::lastOSRExit):
(JSC::DFG::JITCode::appendSpeculationRecovery):
(JSC::DFG::JITCode::appendWatchpoint):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGJITCompiler.h:

(JITCompiler):
(JSC::DFG::JITCompiler::addWeakReference):
(JSC::DFG::JITCompiler::noticeOSREntry):
(JSC::DFG::JITCompiler::jitCode):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOSRExit.h:

(OSRExit):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::backwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::speculationWatchpoint):
(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVariableEventStream.cpp:
  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

  • ftl/FTLJITCode.cpp:

(JSC::FTL::JITCode::JITCode):
(JSC::FTL::JITCode::~JITCode):
(FTL):
(JSC::FTL::JITCode::initializeCode):
(JSC::FTL::JITCode::addressForCall):
(JSC::FTL::JITCode::executableAddressAtOffset):
(JSC::FTL::JITCode::dataAddressAtOffset):
(JSC::FTL::JITCode::offsetOf):
(JSC::FTL::JITCode::size):
(JSC::FTL::JITCode::contains):
(JSC::FTL::JITCode::ftl):
(JSC::FTL::JITCode::dfgCommon):

  • ftl/FTLJITCode.h:

(JITCode):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileStructureTransitionWatchpoint):
(JSC::FTL::LowerDFGToLLVM::compilePutStructure):
(JSC::FTL::LowerDFGToLLVM::compilePhantomPutStructure):
(JSC::FTL::LowerDFGToLLVM::addWeakReference):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::weakPointer):

  • ftl/FTLState.cpp:

(FTL):
(JSC::FTL::State::State):
(JSC::FTL::State::dumpState):

  • ftl/FTLState.h:

(State):

  • heap/DFGCodeBlocks.cpp:

(JSC::DFGCodeBlocks::~DFGCodeBlocks):
(JSC::DFGCodeBlocks::jettison):
(JSC::DFGCodeBlocks::clearMarks):
(JSC::DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks):
(JSC::DFGCodeBlocks::traceMarkedCodeBlocks):

  • jit/JITCode.cpp:

(JSC::JITCode::dfgCommon):
(JSC):
(JSC::JITCode::dfg):
(JSC::JITCode::ftl):
(JSC::DirectJITCode::DirectJITCode):
(JSC::DirectJITCode::initializeCodeRef):
(JSC::DirectJITCode::addressForCall):
(JSC::DirectJITCode::executableAddressAtOffset):
(JSC::DirectJITCode::dataAddressAtOffset):
(JSC::DirectJITCode::offsetOf):
(JSC::DirectJITCode::size):
(JSC::DirectJITCode::contains):

  • jit/JITCode.h:

(DFG):
(FTL):
(JSC):
(JITCode):
(DirectJITCode):

10:09 PM Changeset in webkit [147608] by fpizlo@apple.com
  • 4 edits in branches/dfgFourthTier

fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define
https://bugs.webkit.org/show_bug.cgi?id=113921

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

The LLVM community wants us to continue including all of LLVM's C++ headers. Change
to using #pragma's to disable warnings that they cannot handle.

  • ftl/FTLLLVMHeaders.h:

Tools:

Reviewed by Oliver Hunt.

The LLVM community wants us to continue including all of LLVM's C++ headers. Change
the export script to do this.

  • Scripts/export-llvm-build:
8:52 PM Changeset in webkit [147607] by gyuyoung.kim@samsung.com
  • 27 edits in trunk

[EFL] Add a decoration image to search input field
https://bugs.webkit.org/show_bug.cgi?id=113552

Reviewed by Laszlo Gombos.

Source/WebCore:

Though EFL port has a decoration image for search input field, we didn't use it.
Start to show it.

Tests: fast/forms/search-cancel-button-style-sharing.html

fast/forms/search-rtl.html
fast/css/input-search-padding.html
fast/css/text-input-with-webkit-border-radius.html
fast/css/text-overflow-input.html
fast/forms/box-shadow-override.html
fast/forms/control-restrict-line-height.html
fast/forms/input-appearance-height.html
fast/forms/placeholder-position.html
fast/forms/placeholder-pseudo-style.html
fast/forms/search-styled.html
fast/forms/search-vertical-alignment.html
fast/forms/searchfield-heights.html
fast/repaint/search-field-cancel.html
fast/replaced/width100percent-searchfield.html

  • platform/efl/RenderThemeEfl.cpp:

(WebCore):
(WebCore::RenderThemeEfl::supportsDataListUI):
(WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):

LayoutTests:

Rebaseline related to input search field.

  • platform/efl/fast/css/input-search-padding-expected.png:
  • platform/efl/fast/css/input-search-padding-expected.txt:
  • platform/efl/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/efl/fast/css/text-overflow-input-expected.png:
  • platform/efl/fast/css/text-overflow-input-expected.txt:
  • platform/efl/fast/forms/box-shadow-override-expected.png:
  • platform/efl/fast/forms/box-shadow-override-expected.txt:
  • platform/efl/fast/forms/control-restrict-line-height-expected.png:
  • platform/efl/fast/forms/control-restrict-line-height-expected.txt:
  • platform/efl/fast/forms/input-appearance-height-expected.png:
  • platform/efl/fast/forms/input-appearance-height-expected.txt:
  • platform/efl/fast/forms/placeholder-position-expected.png:
  • platform/efl/fast/forms/placeholder-position-expected.txt:
  • platform/efl/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/efl/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/efl/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/efl/fast/forms/searchfield-heights-expected.png:
  • platform/efl/fast/forms/searchfield-heights-expected.txt:
  • platform/efl/fast/repaint/search-field-cancel-expected.png:
  • platform/efl/fast/repaint/search-field-cancel-expected.txt:
  • platform/efl/fast/replaced/width100percent-searchfield-expected.png:
  • platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
7:49 PM Changeset in webkit [147606] by Lucas Forschler
  • 1 copy in tags/Safari-537.36

New Tag.

7:16 PM Changeset in webkit [147605] by gyuyoung.kim@samsung.com
  • 8 edits in trunk/LayoutTests

Unreviewed gardening. Below tests aren't related to bug 87619. It just needs to do rebaseline.

  • platform/efl/TestExpectations:
  • platform/efl/fast/forms/number/number-appearance-rtl-expected.png:
  • platform/efl/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
  • platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
6:52 PM Changeset in webkit [147604] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/LayoutTests

fourthTier: Just linking LLVM into JSC causes all plugin tests to fail
https://bugs.webkit.org/show_bug.cgi?id=113915

Reviewed by nobody.

This is pretty funny. I don't know, yet, what is going on, but I don't want it to block other work.

  • platform/mac/TestExpectations:
6:39 PM Changeset in webkit [147603] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Re-enable WinEWS tests.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

6:16 PM Changeset in webkit [147602] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

Input value/placeholder is not redrawn when the input height grows
https://bugs.webkit.org/show_bug.cgi?id=113845

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/forms/text/text-height-grow.html

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::styleDidChange):
We need relayout of the inner text element.

LayoutTests:

  • fast/forms/text/text-height-grow-expected.html: Added.
  • fast/forms/text/text-height-grow.html: Added.
6:10 PM Changeset in webkit [147601] by glenn@skynav.com
  • 1 edit
    2 adds in trunk/LayoutTests

[GTK] Unreviewed gardening. Rebaseline after r147588.

  • platform/gtk-wk1/fast/writing-mode: Added.
  • platform/gtk-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
6:02 PM Changeset in webkit [147600] by shawnsingh@chromium.org
  • 2 edits in trunk/Source/WebCore

Add comment to clarify isStackingContext() in RenderLayer.h
https://bugs.webkit.org/show_bug.cgi?id=113909

Reviewed by Simon Fraser.

It was not obvious how the implementation of isStackingContext()
was correct, a comment is appropriate here for anyone who reads
this code in the future.

Just a change in comment, no test needed.

  • rendering/RenderLayer.h:
5:58 PM Changeset in webkit [147599] by glenn@skynav.com
  • 16 edits
    1 add
    3 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening. Rebaseline after r147588.

  • platform/chromium-mac-lion/fast/text/international/003-expected.png:
  • platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.png:
  • platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.txt:
  • platform/chromium-mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac/fast/text/international/003-expected.png:
  • platform/chromium-mac/fast/text/international/003-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png:
  • platform/chromium-mac/fast/text/international/text-combine-image-test-expected.txt:
  • platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
  • platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/chromium-win/fast/text/international/003-expected.png:
  • platform/chromium-win/fast/text/international/003-expected.txt:
  • platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/text/international/003-expected.txt: Removed.
5:45 PM Changeset in webkit [147598] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Don't try to set the exception port for server connections
https://bugs.webkit.org/show_bug.cgi?id=113910
<rdar://problem/11248925>

Reviewed by Darin Adler.

Treat a SetExceptionPort message to the server connection as an invalid message.

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::receiveSourceEventHandler):

5:05 PM Changeset in webkit [147597] by hmuller@adobe.com
  • 3 edits in trunk/Source/WebCore

[CSS Exclusions] Removed ExclusionShape dead code
https://bugs.webkit.org/show_bug.cgi?id=113904

Reviewed by Dirk Schulze.

No new tests, just removing dead code.

  • rendering/ExclusionShape.cpp:

(WebCore::ExclusionShape::createExclusionShape):

  • rendering/ExclusionShape.h:

(ExclusionShape):

4:44 PM Changeset in webkit [147596] by roger_fong@apple.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed. AppleWin port gardening.

  • platform/win/TestExpectations:
  • platform/win/fast/lists/inlineBoxWrapperNullCheck-expected.txt: Added.
4:16 PM Changeset in webkit [147595] by psolanki@apple.com
  • 2 edits in trunk/Source/WTF

Enable HAVE_MADV_FREE_REUSE on iOS
https://bugs.webkit.org/show_bug.cgi?id=113892
<rdar://problem/12787563>

Reviewed by Mark Rowe.

  • wtf/Platform.h:
3:58 PM Changeset in webkit [147594] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Switch MediaPlayerPrivateBlackBerry.cpp's timer to use CLOCK_MONOTONIC
https://bugs.webkit.org/show_bug.cgi?id=113900

Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-04-03
Reviewed by Rob Buis.
Internally Reviewed by Jeff Rogers.

Timers should use CLOCK_MONOTONIC to avoid undesirable effects when
the user switches the system time.

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::drawBufferingAnimation):

3:54 PM Changeset in webkit [147593] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

<http://webkit.org/b/113898> Eliminate some code duplication by introducing an array of handlers to register / unregister.

Reviewed by Antti Koivisto.

  • UIProcess/mac/WebContextMac.mm:

(OcclusionNotificationHandler): Structure containing the notification name, type and handler.
(WebKit::registerOcclusionNotificationHandlers): Register all of the handlers in the array.
(WebKit::unregisterOcclusionNotificationHandlers): Unregister all of the handlers in the array.

3:54 PM Changeset in webkit [147592] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Enable process suppression when no windows in the application have drawn recently.
<http://webkit.org/b/113854> / <rdar://problem/13540351>

Reviewed by Darin Adler.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::applicationWindowModificationsStarted): Note that modifications are no longer stopped.
(WebKit::applicationWindowModificationsStopped): Note that modifications have stopped.
(WebKit::registerOcclusionNotificationHandlers): Register handlers for the start and stop notifications.
(WebKit::unregisterOcclusionNotificationHandlers): Unregister handlers for the start and stop notifications.
(WebKit::WebContext::canEnableProcessSuppressionForNetworkProcess): Allow suppression if the application is occluded
or the application has not drawn recently.
(WebKit::WebContext::canEnableProcessSuppressionForWebProcess): Ditto.
(WebKit::WebContext::canEnableProcessSuppressionForGlobalChildProcesses): Ditto.

3:35 PM Changeset in webkit [147591] by commit-queue@webkit.org
  • 9 edits
    4 adds in trunk

Unable to focus on embedded plugins such as Flash via javascript focus()
https://bugs.webkit.org/show_bug.cgi?id=32292

Patch by Dave Michael <dmichael@chromium.org> on 2013-04-03
Reviewed by Ryosuke Niwa.

Source/WebCore:

Make embed, object, and applet elements support focus() when
appropriate. Prior to this patch, javascript focus() had no effect on
embed, object, or applet elements unless tabindex or contenteditable is
set. With this patch, focus() will focus the element unless the plugin
content has failed to load (i.e., we are showing either fallback content
or an unavailable plugin indicator).

Test: plugins/focus.html

java/focus.html

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::supportsFocus):
Overridden to return true except when the plugin content has failed to load.

  • html/HTMLPlugInElement.h:

(WebCore::HTMLPlugInElement::useFallbackContent):
Moved up from HTMLPlugInImageElement.
(WebCore::HTMLPlugInElement::supportsFocus):

  • html/HTMLPlugInElement.h:

(WebCore::HTMLPlugInImageElement::useFallbackContent):
Removed. Now the implementation is inherited from HTMLPlugInElement.

LayoutTests:

Add/update testing to ensure embed, object, and applet tags now support
focus except when plugin content did not load.

  • fast/events/resources/tabindex-focus-blur-all-frame1.html: Change embed and object

elements to reference an invalid plugin, to be consistent with applet. These
element types are not focusable when there is valid plugin content.

  • fast/events/resources/tabindex-focus-blur-all-frame2.html: Same as above.
  • fast/events/resources/tabindex-focus-blur-all-iframe1.html: Same as above.
  • fast/events/resources/tabindex-focus-blur-all-iframe2.html: Same as above.
  • java/focus-expected.txt: Added.
  • java/focus.html: Added.
  • plugins/focus-expected.txt: Added.
  • plugins/focus.html: Added.
3:33 PM Changeset in webkit [147590] by Lucas Forschler
  • 4 edits in tags/Safari-537.35.7/Source

Versioning.

3:18 PM Changeset in webkit [147589] by Lucas Forschler
  • 1 copy in tags/Safari-537.35.7

New Tag.

2:53 PM Changeset in webkit [147588] by glenn@skynav.com
  • 12 edits
    5 adds in trunk

Element boundaries prevent Japanese line break opportunities
https://bugs.webkit.org/show_bug.cgi?id=105692

Reviewed by Darin Adler.

Source/WebCore:

Introduce use of prior context when using text break iterators
in non-ASCII path through nextBreakablePosition(). This enables
the use of line break context across an element boundary for
the non-ASCII path. Use of this context with the ASCII path was
enabled by https://bugs.webkit.org/show_bug.cgi?id=17427.

Performance tests of line layout and html5 parsing show that this
patch provides an approximately 4% improvement with Japanese and
no statistically significant regression with ASCII path. Parsing
(html5-full-render) performance is not significantly affected.

Tests: fast/text/line-break-between-text-nodes-cjk.html

fast/text/line-break-between-text-nodes-latin1.html

Expect rebaselines will be needed due to different line breaks:

fast/text/international/003.html
fast/text/international/text-combine-image-test-expected.html
fast/text/writing-mode/Kusa-Makura-background-canvas.html

  • platform/text/TextBreakIterator.cpp:

(WebCore::acquireLineBreakIterator): Pass prior context to non-ICU path.

  • platform/text/TextBreakIterator.h:

(WebCore::LazyLineBreakIterator::priorContextLength): Added.
(WebCore::LazyLineBreakIterator::get): Pass prior context to ICU path.
(WebCore::LazyLineBreakIterator::resetStringAndReleaseIterator): Editorial.

  • platform/text/TextBreakIteratorICU.cpp:

Use prior context from line break iterators. Requires
adding new UTF16 (UChar*) text provider and reimplementing
Latin1 (LChar*) text provider. Implementation is optimized
by using generic functionality that applies to both string
sources.
(WebCore::textPinIndex): Added.
(WebCore::textNativeLength): Added.
(WebCore::textFixPointer): Added.
(WebCore::textClone): Added.
(WebCore::textExtract): Added.
(WebCore::textClose): Added.
(WebCore::textGetContext): Added.
(WebCore::textLatin1GetCurrentContext): Added.
(WebCore::textLatin1MoveInPrimaryContext): Added.
(WebCore::textLatin1SwitchToPrimaryContext): Added.
(WebCore::textLatin1MoveInPriorContext): Added.
(WebCore::textLatin1SwitchToPriorContext): Added.
(WebCore::textInChunkOrOutOfRange): Added.
(WebCore::textLatin1Access): Added.
(WebCore::textInit): Added.
(WebCore::textOpenLatin1): Added.
(WebCore::textUTF16GetCurrentContext): Added.
(WebCore::textUTF16MoveInPrimaryContext): Added.
(WebCore::textUTF16SwitchToPrimaryContext): Added.
(WebCore::textUTF16MoveInPriorContext): Added.
(WebCore::textUTF16SwitchToPriorContext): Added.
(WebCore::textUTF16Access): Added.
(WebCore::textOpenUTF16): Added.
(WebCore::acquireLineBreakIterator): Use new text providers with prior context.

  • platform/text/wchar/TextBreakIteratorWchar.cpp:

(WebCore::acquireLineBreakIterator): Pass prior context to non-ICU path.

  • rendering/break_lines.cpp:

(WebCore::nextBreakablePosition): Use prior context in ICU path.

LayoutTests:

  • fast/text/line-break-between-text-nodes-cjk-expected.html: Added.
  • fast/text/line-break-between-text-nodes-cjk.html: Added.
  • fast/text/line-break-between-text-nodes-latin1-expected.html: Added.
  • fast/text/line-break-between-text-nodes-latin1.html: Added.
  • platform/chromium-linux/fast/text/international/003-expected.png: Rebaselined.
  • platform/chromium-linux/fast/text/international/003-expected.txt: Rebaselined.
  • platform/chromium-linux/fast/text/international/text-combine-image-test-expected.png: Rebaselined.
  • platform/chromium-linux/fast/text/international/text-combine-image-test-expected.txt: Added (previously missing).
  • platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Rebaselined.
  • platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Rebaselined.
2:53 PM Changeset in webkit [147587] by fpizlo@apple.com
  • 13 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Everyone should know about the FTL
https://bugs.webkit.org/show_bug.cgi?id=113897

Reviewed by Mark Hahnenberg.

In order to get OSR exit to work right, we need the distinction between DFG and
FTL to be clear even after compilation finishes, since they will have subtly
different OSR stories and likely use different data structures.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::resetStubInternal):
(JSC::ProgramCodeBlock::compileOptimized):
(JSC::EvalCodeBlock::compileOptimized):
(JSC::FunctionCodeBlock::compileOptimized):
(JSC::CodeBlock::adjustedExitCountThreshold):
(JSC::CodeBlock::tallyFrequentExitSites):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::hasOptimizedReplacement):
(JSC::ExecState::isInlineCallFrame):

  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

  • ftl/FTLJITCode.cpp:

(JSC::FTL::JITCode::JITCode):

  • ftl/FTLState.cpp:

(JSC::FTL::State::dumpState):

  • heap/DFGCodeBlocks.cpp:

(JSC::DFGCodeBlocks::jettison):

  • interpreter/Interpreter.cpp:

(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):

  • jit/JITCode.cpp:

(WTF::printInternal):

  • jit/JITCode.h:

(JSC::JITCode::topTierJIT):
(JSC::JITCode::nextTierJIT):
(JITCode):
(JSC::JITCode::isJIT):
(JSC::JITCode::isLowerTier):
(JSC::JITCode::isHigherTier):
(JSC::JITCode::isLowerOrSameTier):
(JSC::JITCode::isHigherOrSameTier):
(JSC::JITCode::isOptimizingJIT):

  • jit/JITDriver.h:

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::compileOptimized):
(JSC::samplingDescription):
(JSC::ProgramExecutable::compileOptimized):
(JSC::FunctionExecutable::compileOptimizedForCall):
(JSC::FunctionExecutable::compileOptimizedForConstruct):

2:51 PM Changeset in webkit [147586] by Lucas Forschler
  • 4 edits
    2 adds in branches/safari-534.59-branch/Source/WebKit2

Fix the build after merging 147042.

  • Platform/mac/StringUtilities.h: Added.

(WebKit):

  • Platform/mac/StringUtilities.mm: Added.

(WebKit):
(WebKit::nsStringFromWebCoreString):

  • UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextCopyPlugInInfoForBundleIdentifier):

  • UIProcess/Plugins/PluginInfoStore.h:

(PluginInfoStore):

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::findPluginWithBundleIdentifier):

2:35 PM Changeset in webkit [147585] by mhahnenberg@apple.com
  • 3 edits in trunk/LayoutTests

get_by_pname can become confused when iterating over objects with static properties
https://bugs.webkit.org/show_bug.cgi?id=113831

Reviewed by Jer Noble.

Improving the test results to make it more obvious why something failed. Also removed
absolute paths from the test.

  • fast/js/dom-static-property-for-in-iteration-expected.txt:
  • fast/js/dom-static-property-for-in-iteration.html:
2:21 PM Changeset in webkit [147584] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit

Unreviewed VS2010 build fix.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
2:08 PM Changeset in webkit [147583] by Christophe Dumez
  • 10 edits
    2 deletes in trunk/Source

[Chromium] Bad cast from BitmapImageSingleFrameSkia to BitmapImage
https://bugs.webkit.org/show_bug.cgi?id=113492

Reviewed by Stephen White.

Source/WebCore:

Remove BitmapImageSingleFrameSkia and have ImageBufferSkia construct
BitmapImage objects instead via an intermediate NativeImageSkia.

No new tests, covered by existing tests.

  • WebCore.gypi:
  • platform/graphics/filters/skia/FEGaussianBlurSkia.cpp: Remove

include for BitmapImageSingleFrameSkia.h header.

  • platform/graphics/skia/BitmapImageSingleFrameSkia.cpp: Removed.
  • platform/graphics/skia/BitmapImageSingleFrameSkia.h: Removed.
  • platform/graphics/skia/ImageBufferSkia.cpp: Construct BitmapImage

objects instead of BitmapImageSingleFrameSkia ones.
(WebCore::ImageBuffer::copyImage):
(WebCore::drawNeedsCopy):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::BitmapImage::BitmapImage): Implement BitmapImage constructor
that takes an NativeImageSkia* in argument.
(WebCore):
(WebCore::BitmapImage::draw): Remove m_source.initialized() check as
this will return false for BitmapImage objects constructed from a
NativeImageSkia, due to the lack of decoder.

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::NativeImageSkia): Add parameter to the
NativeImageSkia constructor so that the caller can request a deep copy
instead of a shallow one. This is needed by the ImageBuffer.

  • platform/graphics/skia/NativeImageSkia.h:
  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageFrame::setSkBitmap):

Source/WebKit/chromium:

Update test now that BitmapImageSingleFrameSkia no longer exists.
BitmapImage is now used instead.

  • tests/PlatformContextSkiaTest.cpp:

(WebCore::TEST):

1:57 PM Changeset in webkit [147582] by fpizlo@apple.com
  • 4 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: DFG should abstract out how it does forward exits, and that code should be simplified
https://bugs.webkit.org/show_bug.cgi?id=113894

Reviewed by Mark Hahnenberg.

1) We previously had two different ways of convertingToForward, one path for

where we had a ValueRecovery for the current node and one where we didn't.
But the paths were doing exactly the same thing except that if you have a
ValueRecovery, you also find the last applicable mov hint and do some
extra things. This patch combines the two paths and bases both of them on
the previous no-ValueRecovery path, which was simpler to begin with.


2) This moves the logic into DFG::OSRExit, which further simplifies the code

and makes the logic available to the FTL.

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::convertToForward):
(DFG):

  • dfg/DFGOSRExit.h:

(DFG):
(OSRExit):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):

1:44 PM Changeset in webkit [147581] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: resultAnimationElement->m_animatedType
https://bugs.webkit.org/show_bug.cgi?id=93528

Patch by David Vest <davve@opera.com> on 2013-04-03
Reviewed by Philip Rogers.

Source/WebCore:

When the order of animation elements change within an animation
group, we can't assume that the resultElement is the same as it
was when the animation was frozen. Make sure to reset the
animation type for the resultElement before updating the
animation.

Test: svg/animations/animation-dependency-crash.html

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::progress):

LayoutTests:

  • svg/animations/animation-dependency-crash-expected.txt: Added.
  • svg/animations/animation-dependency-crash.html: Added.
1:39 PM Changeset in webkit [147580] by timothy@apple.com
  • 3 edits in trunk/Source/WebCore

Stop unconditionally enabling JavaScript execution when closing the Web Inspector.

https://webkit.org/b/113889
rdar://problem/12281794

Reviewed by Joseph Pecoraro.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent): Initialize m_originalScriptExecutionDisabled.
(WebCore::InspectorPageAgent::enable): Populate m_originalScriptExecutionDisabled based on current setting.
(WebCore::InspectorPageAgent::disable): Restore previous setting.

  • inspector/InspectorPageAgent.h:

(InspectorPageAgent): Added m_originalScriptExecutionDisabled.

1:13 PM Changeset in webkit [147579] by dino@apple.com
  • 10 edits in trunk/Source

Cross fade into restarted plugin
https://bugs.webkit.org/show_bug.cgi?id=113868

Reviewed by Tim Horton.

Source/WebCore:

Allow a restarted plugin to fade in over its snapshot, avoiding the abrupt
flash of empty content. The WebCore part of this patch marks the plugin
element as restarted, and draws the snapshot for a short amount of time
as the plugin is restarting. After the plugin has reappeared, we stop drawing
the snapshot.

There is a little bit of drive-by whitespace removal in HTMLPlugInImageElement.

  • html/HTMLPlugInElement.h:

(WebCore::HTMLPlugInElement::restartedPlugin): New method indicating if the plugin has been restarted.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Initialise new timer and member variable.
(WebCore::HTMLPlugInImageElement::setDisplayState): If we are moving into a restarting state, make sure

to remember this and also start a timer so that we show the snapshot for while.

(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired): No need to draw the snapshot from here on.

  • html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement): Member variable to remember if we've restarted.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintContents): Only exit early from the paint if we're not a restarting

plugin, otherwise we do want to draw the snapshot if there is one.

  • rendering/RenderLayerBacking.cpp:

(WebCore::isRestartedPlugin): Detects a restarted plugin.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): Don't become a simple container

compositing layer if you're a restarted plugin.

Source/WebKit2:

Add a new plugin process type that indicates this is a plugin that
has been restarted from snapshotting. On Apple ports, this allows
us to animate the appearance of the plugin so that it crossfades
with the snapshot. Other ports will have to add their own fading.

  • PluginProcess/PluginProcess.h: New Type: TypeRestartedProcess.
  • WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:

(WebKit::PluginProxy::pluginLayer): When the plugin's CALayer is created, if it

is a restarted plugin, add an opacity animation to fade it in.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin): Mark restarted plugins with the new process type.

1:05 PM Changeset in webkit [147578] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Adjustments to media controls appearance.
https://bugs.webkit.org/show_bug.cgi?id=113816
https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=316398
https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=316438

Updates to the BlackBerry media controls:

  • extend the timeline slider.
  • move the volume slider for audio elements up so it does not overlap the main panel.
  • upstream some other cosmetic changes to media controls that were not previously upstreamed.

Patch by John Griggs <jgriggs@blackberry.com> on 2013-04-03
Reviewed by Rob Buis.

BlackBerry-specific, cosmetic change; No new tests required.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
(WebCore::RenderThemeBlackBerry::paintMediaPlayButton):
(WebCore::RenderThemeBlackBerry::paintMediaMuteButton):
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderThumb):

12:53 PM Changeset in webkit [147577] by mvujovic@adobe.com
  • 5 edits in trunk/LayoutTests

Compositing tests failing after http://trac.webkit.org/changeset/147502
https://bugs.webkit.org/show_bug.cgi?id=113838

Reviewed by Dean Jackson.

Add (contentsOpaque 1) to the DRT text output in some expectations files due to bug 70634
"Mark GraphicsLayers as opaque when possible" [1]. The expectations in the guilty changeset
weren't updated after bug 70634 landed.

[1]: https://bugs.webkit.org/show_bug.cgi?id=70634

  • compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
  • compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
  • compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
  • platform/mac/TestExpectations:
12:41 PM Changeset in webkit [147576] by fpizlo@apple.com
  • 3 edits in branches/dfgFourthTier/WebKitLibraries

Updated LLVM drops to include LLVM_DO_NOT_INCLUDE_CPP_HEADERS changes.

Rubber stamped by Mark Hahnenberg.

  • LLVMIncludesMountainLion.tar.bz2:
  • LLVMLibrariesMountainLion.tar.bz2:
12:29 PM Changeset in webkit [147575] by Lucas Forschler
  • 2 edits in branches/safari-534.59-branch/Source/WebKit2

Remove include after mis-merge of r147052.

  • UIProcess/API/C/WKAPICast.h:
12:16 PM Changeset in webkit [147574] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

[GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
https://bugs.webkit.org/show_bug.cgi?id=113883

Reviewed by Martin Robinson.

  • gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
  • gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.

The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.

12:08 PM Changeset in webkit [147573] by hclam@chromium.org
  • 3 edits in branches/chromium/1453/Source/WebCore/platform/image-decoders/gif

Merge 147392 "Simply GIFImageReader error handling"

Simply GIFImageReader error handling
https://bugs.webkit.org/show_bug.cgi?id=113718

Reviewed by Adam Barth.

When GIFImageReader encounters a parsing error it should just return
without doing any more work. Current code saves a boolean before return,
this is not necessary.

Tested with existing unit tests.
Tested locally with ASAN build with 60k GIF images.

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::repetitionCount):

  • platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::decode):

  • platform/image-decoders/gif/GIFImageReader.h:

(GIFImageReader::GIFImageReader):
(GIFImageReader):

TBR=hclam@chromium.org
Review URL: https://codereview.chromium.org/13578002

11:58 AM Changeset in webkit [147572] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/13564588> Add a temporary workaround for a build failure.

Fix suggested by Mark Rowe.

  • Shared/mac/ChildProcessMac.mm:
11:47 AM Changeset in webkit [147571] by Lucas Forschler
  • 8 edits in branches/safari-534.59-branch/Source/WebKit2

Merge 147052. <rdar://problem/13528851>

11:38 AM Changeset in webkit [147570] by mhahnenberg@apple.com
  • 5 edits
    2 adds in trunk

get_by_pname can become confused when iterating over objects with static properties
https://bugs.webkit.org/show_bug.cgi?id=113831

Reviewed by Geoffrey Garen.

get_by_pname doesn't take static properties into account when using a JSPropertyNameIterator to directly
access an object's backing store. One way to fix this is to not cache any properties when iterating over
objects with static properties. This patch fixes the bug that was originally reported on swisscom.ch.

Source/JavaScriptCore:

  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnNonIndexPropertyNames):

  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::create):

  • runtime/PropertyNameArray.h:

(JSC::PropertyNameArray::PropertyNameArray):
(JSC::PropertyNameArray::numCacheableSlots):
(JSC::PropertyNameArray::setNumCacheableSlots):
(PropertyNameArray):

LayoutTests:

  • fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
  • fast/js/dom-static-property-for-in-iteration.html: Added.
11:27 AM Changeset in webkit [147569] by bfulgham@webkit.org
  • 3 edits in trunk/WebKitLibraries

[Windows, WinCairo] Unreviewed VS2010 Build Correction

  • win/tools/scripts/auto-version2010.sh: Added properties svn:eol-style and svn:executable.
  • win/tools/scripts/feature-defines2010.sh: Added properties svn:eol-style and svn:executable.
11:23 AM Changeset in webkit [147568] by ap@apple.com
  • 5 edits in trunk/Source/WebKit2

[WK2] XMLHttpRequest upload events don't work with NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=113887

Reviewed by Brady Eidson.

Just forward didSendData client call to WebProcess.

  • NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::didSendData): (WebKit::NetworkResourceLoader::didCancelAuthenticationChallenge): Tweaked a comment.
  • WebProcess/Network/WebResourceLoader.cpp: (WebKit::WebResourceLoader::didSendData):
  • WebProcess/Network/WebResourceLoader.h:
  • WebProcess/Network/WebResourceLoader.messages.in:
11:12 AM Changeset in webkit [147567] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

[Gstreamer] Use gst_buffer_extract() in copyGstreamerBuffersToAudioChannel()
https://bugs.webkit.org/show_bug.cgi?id=113880

Reviewed by Philippe Normand.

copyGstreamerBuffersToAudioChannel() was mapping the GstBuffer content to memcpy
it to the AudioChannel buffer. This patch leverages gst_buffer_extract() to
simplify the code as it does exactly what we need: gst_buffer_map, memcpy,
gst_buffer_unmap and error handling.

Also replace GstBuffer NULL check by an assertion as we already make sure they
are not NULL before adding them to the list. Additionally, we now call
audioChannel->mutableData() only once instead of once per iteration. It is
a bit better as the getter does some work internally.

No new tests, no behavior change.

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::copyGstreamerBuffersToAudioChannel):

10:30 AM Changeset in webkit [147566] by Antoine Quint
  • 6 edits in trunk/Source/WebCore

Web Inspector: DOM.highlightRect() and DOM.highlightQuad() should allow for page coordinates
https://bugs.webkit.org/show_bug.cgi?id=113869

Add a new "usePageCoordinates" parameter to DOM.highlightRect() and DOM.highlightQuad()
allowing to specify that the rect or quad to highlight should be converted to page
coordinates instead of using the default viewport coordinates.

Reviewed by Timothy Hatcher.

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightQuad):
(WebCore::InspectorDOMAgent::innerHighlightQuad):
Store the "usePageCoordinates" parameter obtained from the protocol calls onto the
highlight configuration object so that it may be used within the InspectorOverlay.

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::highlightQuad):
Check the highlight configuration for the "usePageCoordinates" parameter and
apply the inverse of the page's scroll offset to the quad if it's true.

  • inspector/InspectorOverlay.h:

(HighlightConfig):
(WebCore::Highlight::setDataFromConfig):
(Highlight):

9:43 AM Changeset in webkit [147565] by kangil.han@samsung.com
  • 2 edits in trunk/Source/WebCore

Add omitted reference operator of VisiblePosition in AccessibilityObject
https://bugs.webkit.org/show_bug.cgi?id=113879

Reviewed by Darin Adler.

Seems reference operator has been omitted in startOfStyleRange function, so add it.

  • accessibility/AccessibilityObject.cpp:

(WebCore::startOfStyleRange):

9:35 AM Changeset in webkit [147564] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Include Pango in jhbuild-optional.modules
https://bugs.webkit.org/show_bug.cgi?id=113878

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-03
Reviewed by Martin Robinson.

Since r147547 Pango 1.32.0 is required. Including the module in the
JHBuild optional moduleset.

  • gtk/jhbuild-optional.modules: Add Pango module.
9:27 AM Changeset in webkit [147563] by zeno.albisser@digia.com
  • 5 edits in trunk/Tools

[Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
https://bugs.webkit.org/show_bug.cgi?id=113864

Moving setDefersLoading from TestRunnerQt to TestRunner
requires access to the non-Qt TestRunner.
As long as we instantiate both TestRunner and TestRunnerQt,
we need a separate getter for the non-Qt TestRunner instance.

Reviewed by Simon Hausmann.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebPage::resetSettings):

  • DumpRenderTree/qt/DumpRenderTreeQt.h:

(DumpRenderTree::jscTestRunner):

  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunner::setDefersLoading):

Moving setDefersLoading from TestRunnerQt
to TestRunner.

  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

9:12 AM Changeset in webkit [147562] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Update the localizable strings file.

Rubber-stamped by Michael Saboff.

  • English.lproj/Localizable.strings:
8:58 AM Changeset in webkit [147561] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX (r147493): Fix number of arguments to AudioDestinationIOS constructor

Fixes the following build failures:

Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:84:25: error: no matching constructor for initialization of 'WebCore::AudioDestinationIOS'

return adoptPtr(new AudioDestinationIOS(callback, sampleRate));


In file included from Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:36:
Source/WebCore/platform/audio/ios/AudioDestinationIOS.h:44:5: note: candidate constructor not viable: requires 3 arguments, but 2 were provided

AudioDestinationIOS(AudioIOCallback&, unsigned numberOfOutputChannels, double sampleRate);

Source/WebCore/platform/audio/ios/AudioDestinationIOS.h:42:7: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 2 were provided
class AudioDestinationIOS : public AudioDestination, public AudioSessionListener {


Source/WebCore/platform/audio/ios/AudioDestinationIOS.cpp:101:22: error: out-of-line definition of 'AudioDestinationIOS' does not match any declaration in 'WebCore::AudioDestinationIOS'
AudioDestinationIOS::AudioDestinationIOS(AudioIOCallback& callback, double sampleRate)


2 errors generated.

  • platform/audio/ios/AudioDestinationIOS.h:

(AudioDestinationIOS): Remove numberOfOutputChannels argument.

8:51 AM Changeset in webkit [147560] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX (r147494): -[AVAudioSession setCategory:error:] takes NSError

Fixes the following build failure:

Source/WebCore/platform/audio/ios/AudioSessionIOS.mm:151:71: error: cannot initialize a parameter of type 'NSError ' with an lvalue of type 'NSError *'

[[AVAudioSession sharedInstance] setCategory:categoryString error:error];


  • platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSession::setCategory): Add '&' operator.

8:45 AM Changeset in webkit [147559] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
https://bugs.webkit.org/show_bug.cgi?id=104779

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-03
Reviewed by Carlos Garcia Campos.

  • Scripts/run-gtk-tests:

(TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
passing in current trunk.

8:45 AM Changeset in webkit [147558] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

CSP blocks inline style when cloning a node
https://bugs.webkit.org/show_bug.cgi?id=112270

Patch by Felipe Zimmerle <felipe@zimmerle.org> on 2013-04-03
Reviewed by Adam Barth.

Source/WebCore:

Checks if the Element is being cloned, if so, the application of the
style is allowed otherwise it relies on default permission mechanism.

Test: http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects.html

  • dom/Element.cpp:

(WebCore::Element::attributeChanged): Added parameter
AttributeModificationReason to the method signature.
(WebCore::Element::cloneAttributesFromElement): It is now calling
attributeChanged with AttributeModificationReason parameter. In this scope
it is always set to ModifiedByCloning.
(WebCode::Element::attributeChangedFromParserOrByCloning):
Added parameter AttributeModificationReason.

  • dom/Element.h: Added AttributeModificationReason enum. Used to specify

whenever an attribute was set by a cloned oject or directly.
AttributeModificationReason added to attributeChanged with the default
value set to ModifiedDirectly.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged): Added
AttributeModificationReason to the method signature.
(WebCore::StyledElement::styleAttributeChanged): Now it is checking the
reason of the update, if the reason is ModifiedDirectly check CSP
before set. If ModifiedByCloning set the attribute ignoring the CSP
policy.

  • dom/StyledElement.h:

(StyledElement): Added AttributeModificationReason parameter to the methods:
attributeChanged and styleAttributeChanged, attributeChanged has
ModifiedDirectly as default value.

  • svg/SVGElement.cpp:

(WebCore::SVGElement::attributeChanged): Added AttributeModificationReason
parameter to the method signature.

  • svg/SVGElement.h:

(SVGElement): Added AttributeModificationReason parameter to the
attributeChanged signature with the default value set to:
ModifiedDirectly.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects.html: Added.
8:18 AM Changeset in webkit [147557] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] WebKitWebNavigationAction: fix mix between dispose and finalize
https://bugs.webkit.org/show_bug.cgi?id=113794

Patch by Alban Crequy <alban.crequy@collabora.co.uk> on 2013-04-03
Reviewed by Gustavo Noronha Silva.

WebKitWebNavigationAction's dispose function was named finalize and was calling
the parent class's finalise function, causing a memory corruption. Change it to
be a proper finalize function instead.

  • webkit/webkitwebnavigationaction.cpp:

(webkit_web_navigation_action_class_init):

8:11 AM Changeset in webkit [147556] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed 32bit buildfix after r147542.

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveBinaryData):

8:09 AM Changeset in webkit [147555] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

[Gstreamer] Avoid calls to g_slist_nth_data in webKitWebAudioSrcLoop()
https://bugs.webkit.org/show_bug.cgi?id=113875

Reviewed by Philippe Normand.

webKitWebAudioSrcLoop() was iterating over 2 GSLists by using a counter and then
calling g_slist_nth_data() to get the element of each GSList. This is inefficient
because calling g_slist_nth_data() will iterate the GSList up until index 'n'.

This patch improves this by keeping pointers to the current element of each list
while iterating, so that we can simply use g_slist_next() to iterate instead
of g_slist_nth_data().

No new tests, no behavior change.

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcLoop):

8:04 AM Changeset in webkit [147554] by keishi@webkit.org
  • 4 edits in trunk/Source/WebCore

Actions that require user gesture don't work in window.showModalDialog in Chromium
https://bugs.webkit.org/show_bug.cgi?id=113777

Reviewed by Jochen Eisinger.

In Chromium the window for showModalDialog is not modal which causes the
UserGestureIndicator to block actions in the sub window. We introduce a
RAII that saves the UserGestureIndicator and state, then resets it before
runModalDialog, and restore it when it's done.

No new tests. Can't cause user gesture inside modal dialog.

  • dom/UserGestureIndicator.cpp:

(WebCore::UserGestureIndicatorDisabler::UserGestureIndicatorDisabler): Saves and resets the topmost indicator and state.
(WebCore):
(WebCore::UserGestureIndicatorDisabler::~UserGestureIndicatorDisabler): Restores topmost indicator and state.

  • dom/UserGestureIndicator.h:

(WebCore):
(UserGestureIndicatorDisabler): RAII to temporarily disable UserGestureIndicator.
(UserGestureIndicator): Allow access to UserGestureIndicatorDisabler.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::showModalDialog): Disable UserGestureIndicator while runModalDialog.

8:02 AM Changeset in webkit [147553] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Fail gracefully if an OpenGL context could not be created.
https://bugs.webkit.org/show_bug.cgi?id=113784

In case we fail to create or adopt a valid platform OpenGL context
we do not want to provide a GraphicsContext3D instance.
Otherwise we would crash as soon as the instance is being used.

Reviewed by Jocelyn Turcotte.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3D::GraphicsContext3D):

7:36 AM Changeset in webkit [147552] by anilsson@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove defaultViewportArguments check from call site of recomputeVirtualViewportFromViewportArguments
https://bugs.webkit.org/show_bug.cgi?id=113872

Reviewed by Carlos Garcia Campos.

Carlos pointed out that recomputeVirtualViewportFromViewportArguments
already contains the check, and returns an empty IntSize if it fails.
So pick up on that to make the code a bit more DRY.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

7:23 AM Changeset in webkit [147551] by kadam@inf.u-szeged.hu
  • 15 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated platform specific expected files after r147492.

  • platform/qt/TestExpectations:
  • platform/qt/fast/dom/HTMLImageElement/image-alt-text-expected.png:
  • platform/qt/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
  • platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
  • platform/qt/fast/encoding/utf-16-big-endian-expected.png:
  • platform/qt/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/qt/fast/encoding/utf-16-little-endian-expected.png:
  • platform/qt/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/qt/fast/forms/input-value-expected.png: Added.
  • platform/qt/fast/forms/input-value-expected.txt:
  • platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.png:
  • platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.txt:
  • platform/qt/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/qt/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
7:15 AM Changeset in webkit [147550] by pierre.rossi@gmail.com
  • 2 edits in trunk/Tools

Fix HAVE(QTTESTSUPPORT) logic

build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
resulting in HAVE(QTTESTSUPPORT) never being true.
Move that logic down in sanitizeFeatures.

Patch by Pierre Rossi <pierre.rossi@digia.com> on 2013-04-03
Rubber-stamped by Tor Arne Vestbø.

  • qmake/mkspecs/features/features.prf:
6:23 AM Changeset in webkit [147549] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GTK][AC] Implement matrix keyframe animations with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=110314

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-03
Reviewed by Gustavo Noronha Silva.

Clutter 1.12 doesn't support additive transform animations yet, So clutter ac backend
uses matrix animations for the case. This patch follows changeset 143369, 143343
to support matrix keyframe animations. I believe this change is easy if you understand
above two changesets.

Covered by existing animation tests.

  • platform/graphics/clutter/PlatformClutterAnimation.cpp:

(WebCore::PlatformClutterAnimation::setValues):
(WebCore::PlatformClutterAnimation::addClutterKeyframeTransitionForProperty):
(WebCore):
(WebCore::PlatformClutterAnimation::addTransformTransition):

  • platform/graphics/clutter/PlatformClutterAnimation.h:

(PlatformClutterAnimation):

6:20 AM Changeset in webkit [147548] by kov@webkit.org
  • 11 edits
    2 adds in trunk

Should close select popup when the element loses focus
https://bugs.webkit.org/show_bug.cgi?id=113220

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-04-03
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/select-popup-closes-on-blur.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::menuListDefaultEventHandler): handle the blur event, closing
the popup menu if any.

  • testing/Internals.cpp:

(WebCore::Internals::isSelectPopupVisible): utility to query the select node renderer to
find out whether the popup is open or closed.
(WebCore):

  • testing/Internals.h: add the new method definition.
  • testing/Internals.idl: ditto.

Source/WebKit/win:

  • WebKit.vcproj/WebKitExports.def.in: export WebCore::HTMLNames::selectTag for Internals

LayoutTests:

  • fast/forms/select/popup-closes-on-blur-expected.txt: Added.
  • fast/forms/select/popup-closes-on-blur.html: Added.
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
6:20 AM Changeset in webkit [147547] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] Bump required versions of some dependencies
https://bugs.webkit.org/show_bug.cgi?id=113282

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-03
Reviewed by Martin Robinson.

.:

This patch updates the following dependencies:

  • libsoup 2.42.0: is the current stable release.
  • glib 2.36.0: libsoup 2.42 requires 2.35.0, but we don't want to depend on unstable versions and 2.36 is the next stable version after 2.35.
  • gtk+ 3.6.0: this is the previous stable release. We don't currently have any code using newer API, so we will be able to remove all the #ifdefed code.
  • at-spi2 2.5.3: is the version required by gtk+ 3.6.
  • GObject introspection 1.32.0: is the version required by gtk+ 3.6.
  • Pango 1.32.0: it's the current stable version and the first one depending on Harfbuzz.
  • Fontconfig 2.5: required by pango 1.32.0 when using Harfbuzz.
  • gtk+ 2.24.10: it allows us to remove a lot of deprecated code and #ifdefs.
  • Source/autotools/Versions.m4:

Tools:

  • gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
6:12 AM Changeset in webkit [147546] by kov@webkit.org
  • 2 edits in trunk/Tools

[GTK] gst-plugins-good fails to build with newer Linux(v4l2)
https://bugs.webkit.org/show_bug.cgi?id=113809

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-04-03
Reviewed by Philippe Normand.

Newer Linux kernels have removed some deprecated macros from v4l2
headers, causing gst-plugins-good's build to break. We don't need it
right now, so just disable it.

  • gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
5:44 AM Changeset in webkit [147545] by jesus@webkit.org
  • 12 edits in trunk

[Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
https://bugs.webkit.org/show_bug.cgi?id=113535

Reviewed by Simon Hausmann.

Source/WebCore:

Now Qt uses the CROSS_PLATFORM_CONTEXT_MENUS
USE flag. This flag provides a full cross-platform
representation of a ContextMenu and a ContextMenuItem.
The embedder can then decide how to show this, so neither
WebCore nor WebCore/platform need to know any platform
specifics about menus.

No new tests, no behavior changes.

  • Target.pri:
  • platform/ContextMenu.h:

(ContextMenu):

  • platform/ContextMenuItem.h:
  • platform/qt/ContextMenuItemQt.cpp:

(WebCore::ContextMenuItem::platformContextMenuItem):

  • platform/qt/ContextMenuQt.cpp:

(WebCore::ContextMenu::ContextMenu):
(WebCore::ContextMenu::getContextMenuItems):
(WebCore::ContextMenu::createPlatformContextMenuFromItems):
(WebCore::ContextMenu::platformContextMenu):

Source/WebKit/qt:

Adjust ContextMenuClientQt and QWebPageAdapter to use CROSS_PLATFORM_CONTEXT_MENUS
USE flag by implementing customizeMenu() instead of getCustomMenuFromDefaultItems()
and by calling menu->items() instead of menu->platformDescription().

  • WebCoreSupport/ContextMenuClientQt.cpp:

(WebCore::ContextMenuClientQt::customizeMenu):

  • WebCoreSupport/ContextMenuClientQt.h:

(ContextMenuClientQt):

  • WebCoreSupport/QWebPageAdapter.cpp:

(descriptionForPlatformMenu):
(QWebPageAdapter::updatePositionDependentMenuActions):

Tools:

Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.

  • qmake/mkspecs/features/features.prf:
5:35 AM Changeset in webkit [147544] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Monospace font does not render in proper sizes
https://bugs.webkit.org/show_bug.cgi?id=93263

Reviewed by Jocelyn Turcotte.

Remove this patch's artificial dependency on Qt 5.1.

  • platform/graphics/qt/FontPlatformDataQt.cpp:

(WebCore::FontPlatformData::FontPlatformData):

5:33 AM Changeset in webkit [147543] by zeno.albisser@digia.com
  • 3 edits in trunk/Tools

[Qt] Move logic of simple forwarding functions to TestRunner.
https://bugs.webkit.org/show_bug.cgi?id=113863

Reviewed by Simon Hausmann.

  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunner::setTextDirection):
(TestRunner::goBack):
(TestRunner::evaluateScriptInIsolatedWorld):
(TestRunner::addUserStyleSheet):

  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

5:15 AM Changeset in webkit [147542] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Refine LOG messages in WebSocket related components
https://bugs.webkit.org/show_bug.cgi?id=113852

Patch by Takeshi Yoshino <tyoshino@chromium.org> on 2013-04-03
Reviewed by Kent Tamura.

Refine LOG messages by

  • Make them contain method names to ease identifying where the event occurred.
  • For consistency, make all messages print the pointer of the origin instance.
  • Quote UTF8 data in LOG messages.
  • For overloaded methods, add the type to clarify which one is run
  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):
(WebCore::WebSocket::send):
(WebCore::WebSocket::close):
(WebCore::WebSocket::contextDestroyed):
(WebCore::WebSocket::didConnect):
(WebCore::WebSocket::didReceiveMessage):
(WebCore::WebSocket::didReceiveBinaryData):
(WebCore::WebSocket::didReceiveMessageError):
(WebCore::WebSocket::didUpdateBufferedAmount):
(WebCore::WebSocket::didStartClosingHandshake):
(WebCore::WebSocket::didClose):

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::subprotocol):
(WebCore::WebSocketChannel::extensions):
(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::bufferedAmount):
(WebCore::WebSocketChannel::close):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::disconnect):
(WebCore::WebSocketChannel::willOpenSocketStream):
(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
(WebCore::WebSocketChannel::didFailSocketStream):
(WebCore::WebSocketChannel::didStartLoading):
(WebCore::WebSocketChannel::didReceiveData):
(WebCore::WebSocketChannel::didFinishLoading):
(WebCore::WebSocketChannel::didFail):
(WebCore::WebSocketChannel::appendToBuffer):
(WebCore::WebSocketChannel::processBuffer):
(WebCore::WebSocketChannel::startClosingHandshake):
(WebCore::WebSocketChannel::closingTimerFired):

  • Modules/websockets/WebSocketDeflater.cpp:

(WebCore::WebSocketDeflater::~WebSocketDeflater):
(WebCore::WebSocketInflater::~WebSocketInflater):

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::readServerHandshake):

  • platform/network/chromium/SocketStreamHandle.cpp:

(WebCore::SocketStreamHandleInternal::connect):
(WebCore::SocketStreamHandleInternal::send):
(WebCore::SocketStreamHandleInternal::close):
(WebCore::SocketStreamHandleInternal::didOpenStream):
(WebCore::SocketStreamHandleInternal::didSendData):
(WebCore::SocketStreamHandleInternal::didReceiveData):
(WebCore::SocketStreamHandleInternal::didClose):
(WebCore::SocketStreamHandleInternal::didFail):

4:56 AM Changeset in webkit [147541] by vestbo@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Update QMAKE_MAC_SDK check for Qt 5.1

Relies on QMAKE_MAC_SDK_VERSION set in features.prf

Reviewed by Simon Hausmann.

  • WebCore.pri:
4:56 AM Changeset in webkit [147540] by vestbo@webkit.org
  • 2 edits in trunk/Tools

[Qt] Disable media support using QuickTime if deployment target != SDK

We link to a single libWebKitSystemInterface static lib, so unless the
deployment target matches the SDK let's not pretend like we'll be able
to run on anything lower than the SDK version.

Reviewed by Simon Hausmann.

  • qmake/mkspecs/features/features.prf:
4:15 AM Changeset in webkit [147539] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] assignToHTMLImageElement no longer exists in Qt5
https://bugs.webkit.org/show_bug.cgi?id=113639

Patch by Kristof Provost <kristof@codepro.be> on 2013-04-03
Reviewed by Simon Hausmann.

No new tests: covered by ./Source/WebKit/qt/tests/hybridPixmap/test.html

  • bridge/qt/qt_pixmapruntime.cpp:

(JSC::Bindings::QtPixmapRuntime::getClassRef):

4:06 AM Changeset in webkit [147538] by Antoine Quint
  • 5 edits
    1 copy
    1 add in trunk

Web Inspector: crash in WebCore::InspectorLayerTreeAgent::buildObjectForLayer if a layer is created for an anonymous RenderObject (:first-letter)
https://bugs.webkit.org/show_bug.cgi?id=113768

Source/WebCore:

The InspectorLayerTreeAgent now knows how to deal with anonymous RenderObjects
for the :first-letter and :first-line pseudo-elements.

Reviewed by Timothy Hatcher.

Test: inspector-protocol/layers/layers-anonymous.html

  • inspector/Inspector.json:

Change the Layer type in the LayerTree domain to have more accurate terminology
(pseudo-element vs. pseudo-class) and a new optional isAnonymous flag for layers
associated to anonymous RenderObjects.

  • inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
Check for anonymous RenderObjects and set the parent renderer's node as the node
for this layer since anonymous renderers have the Document as their node and this
would not be satisfactory to show in a front-end. We also check for anonymous
RenderObjects for the :first-letter and :first-line pseudo-elements and set them
in the pseudoElement property of the Layer object created such that a front-end
could correctly identify what type of pseudo-element for the associated node
yielded this layer.

(WebCore::InspectorLayerTreeAgent::idForNode):
Here we fix the actual crash by first checking if the node provided is null and
returning 0 if there's no such node. This ensures that any scenario where there
is no node associated with the RenderObject simply informs of the front-end that
no such node exists and we do not crash.

LayoutTests:

Reviewed by Timothy Hatcher.

  • inspector-protocol/layers/layers-anonymous-expected.txt: Added.
  • inspector-protocol/layers/layers-anonymous.html: Added.

New test for layers created for CSS anonymous boxes or blocks.

  • inspector-protocol/layers/layers-generated-content.html:

Update test to use the "pseudoElement" property instead of "pseudoClass"
which was the previous, less accurate name.

4:06 AM Changeset in webkit [147537] by anilsson@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Decouple layout viewport from visual viewport
https://bugs.webkit.org/show_bug.cgi?id=113829

Reviewed by Carlos Garcia Campos.

Setting the visual viewport would force the layout viewport equal to
the visual viewport. Decouple the viewports by allowing the user to
specify a layout viewport when setting the viewport(s). The layout
viewport could be the exact same value passed for visual viewport, if
the old behavior is desired.

Also reevaluate any viewport arguments when (only) the layout viewport
changes in WebPage::setDefaultLayoutSize() since the layout viewport is
used as input to the calculation.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setScreenOrientation):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPage::setViewportSize):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
(BlackBerry::WebKit::WebPage::defaultLayoutSize):

  • Api/WebPage.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

3:59 AM Changeset in webkit [147536] by zarvai@inf.u-szeged.hu
  • 13 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining after r147530.

  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
3:24 AM Changeset in webkit [147535] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION(r147117)][Elements] Copy/paste keyboard shortcuts broken in "Edit as HTML"
https://bugs.webkit.org/show_bug.cgi?id=113798

Reviewed by Yury Semikhatsky.

Stop propagation of "copy" event from the multiline editor's
CodeMirror host element so that it is not handled by
WebInspector.documentCopy().

  • inspector/front-end/UIUtils.js:

(.consumeCopy):
(.cleanUpAfterEditing):

  • inspector/front-end/inspector.js:

(WebInspector.addMainEventListeners):

2:49 AM Changeset in webkit [147534] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] accessibility/ignore-spacer-elements.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112001

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-04-03
Reviewed by Gyuyoung Kim.

Fixed failing test. The reason of failure is different expectation of childrenCount.

  • accessibility/ignore-spacer-elements.html:
  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
2:48 AM Changeset in webkit [147533] by tasak@google.com
  • 3 edits
    3 adds in trunk

With borders of differing alpha, the corners become squared off
https://bugs.webkit.org/show_bug.cgi?id=113744

Reviewed by Simon Fraser.

Source/WebCore:

paintTranslucentBorderSides should pick up borders with common color
in order: top, bottom, left and right (not top, right, bottom and
left), because willBeOverdrawn depends on the assumption, borders are
drawn in order: top, bottom, left and right.

Test: fast/borders/border-left-right-same-bottom-different-color.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):

LayoutTests:

  • fast/borders/border-left-right-same-bottom-different-color-expected.txt: Added.
  • fast/borders/border-left-right-same-bottom-different-color.html: Added.
  • platform/chromium-linux/fast/borders/border-left-right-same-bottom-different-color-expected.png: Added.
2:45 AM Changeset in webkit [147532] by kadam@inf.u-szeged.hu
  • 2 edits
    4 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated platform specific expected files.

  • platform/qt/TestExpectations: Skipped failing reftest.
  • platform/qt/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt: Added after r147502.
  • platform/qt/compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt: Added after r147502.
  • platform/qt/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt: Added after r147502.
  • platform/qt/compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt: Added after r147502.
2:31 AM Changeset in webkit [147531] by mihnea@adobe.com
  • 2 edits in trunk/Source/WebCore

[New Multicolumn]Remove assert in RenderMultiColumnFlowThread::createAnonymous
https://bugs.webkit.org/show_bug.cgi?id=113855

Reviewed by Antti Koivisto.

Remove CSSRegions specific assert from new multicolumn implementation.
No change in functionality, no new tests.

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::createAnonymous):

2:28 AM Changeset in webkit [147530] by mkwst@chromium.org
  • 22 edits in trunk

X-Frame-Options: Blocked frames should not inherit their parent's SecurityOrigin.
https://bugs.webkit.org/show_bug.cgi?id=112903

Reviewed by Adam Barth.

Source/WebCore:

This change brings WebKit in line with IE and Gecko's behavior, both of
which treat the blocked frame as being cross-origin for the purposes of
access checks ('[frame].contentWindow.location.href' is inaccessible,
for example).

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

Rather than redirecting to 'about:blank', redirect to a URL which
does not inherit the SecurityOrigin of the parent.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

Before calling cancelMainResourceLoad, ensure that the frame's
document is sandboxed into a unique origin so that it doesn't inherit
the parent's SecurityOrigin.

LayoutTests:

  • http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
2:19 AM Changeset in webkit [147529] by mnaganov@chromium.org
  • 9 edits
    1 add in trunk/Source

[Chromium] Implement target-densityDpi viewport property emulation
https://bugs.webkit.org/show_bug.cgi?id=110835

The value is only used in the Chromium port, when the corresponding
setting is enabled.

This is needed for supporting existing WebView-based applications
that rely on this property.

Reviewed by Adam Barth.

Source/WebCore:

  • dom/ViewportArguments.cpp:

(WebCore::findTargetDensityDPIValue):
(WebCore):
(WebCore::setViewportFeature):

  • dom/ViewportArguments.h:

(WebCore::ViewportArguments::ViewportArguments):
(ViewportArguments):
(WebCore::ViewportArguments::operator==):

Source/WebKit/chromium:

  • public/WebSettings.h:

(WebSettings):

  • src/ChromeClientImpl.cpp:

(WebKit):
(WebKit::calculateTargetDensityDPIFactor):
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setSupportDeprecatedTargetDensityDPI):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):
(WebKit::WebSettingsImpl::supportDeprecatedTargetDensityDPI):

  • tests/WebFrameTest.cpp:
  • tests/data/viewport-target-densitydpi-high.html: Added.
1:56 AM Changeset in webkit [147528] by commit-queue@webkit.org
  • 14 edits in trunk/LayoutTests

Unreviewed, rolling out r147409.
http://trac.webkit.org/changeset/147409
https://bugs.webkit.org/show_bug.cgi?id=113856

The baselines should be reverted after r147450. (Requested by
kadam on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-03

  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • platform/qt/TestExpectations:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
1:38 AM Changeset in webkit [147527] by Christophe Dumez
  • 82 edits
    3 moves in trunk/LayoutTests

Unreviewed. Rebaseline several tests for Chromium that have better output after
r147492.

  • platform/chromium-linux/editing/selection/select-missing-image-expected.png:
  • platform/chromium-linux/fast/block/float/002-expected.png:
  • platform/chromium-linux/fast/block/float/017-expected.png:
  • platform/chromium-linux/fast/dom/HTMLImageElement/image-alt-text-expected.png:
  • platform/chromium-linux/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/chromium-linux/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-linux/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-linux/fast/flexbox/023-expected.png:
  • platform/chromium-linux/fast/flexbox/024-expected.png:
  • platform/chromium-linux/fast/forms/input-value-expected.png:
  • platform/chromium-linux/fast/forms/input-value-expected.txt:
  • platform/chromium-linux/fast/invalid/012-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.png:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium-mac-lion/editing/selection/select-missing-image-expected.png:
  • platform/chromium-mac-lion/fast/block/float/002-expected.png:
  • platform/chromium-mac-lion/fast/block/float/017-expected.png:
  • platform/chromium-mac-lion/fast/dom/HTMLImageElement/image-alt-text-expected.png:
  • platform/chromium-mac-lion/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/chromium-mac-lion/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-mac-lion/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-mac-lion/fast/flexbox/023-expected.png:
  • platform/chromium-mac-lion/fast/flexbox/024-expected.png:
  • platform/chromium-mac-lion/fast/forms/005-expected.png:
  • platform/chromium-mac-lion/fast/forms/input-value-expected.png:
  • platform/chromium-mac-lion/fast/invalid/012-expected.png:
  • platform/chromium-mac-lion/fast/parser/comment-in-script-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/bugs/bug2997-expected.png:
  • platform/chromium-mac-lion/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/002-expected.png:
  • platform/chromium-mac-snowleopard/fast/block/float/017-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLImageElement/image-alt-text-expected.png:
  • platform/chromium-mac-snowleopard/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/chromium-mac-snowleopard/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-mac-snowleopard/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-mac-snowleopard/fast/flexbox/023-expected.png:
  • platform/chromium-mac-snowleopard/fast/flexbox/024-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
  • platform/chromium-mac-snowleopard/fast/invalid/012-expected.png:
  • platform/chromium-mac-snowleopard/fast/parser/comment-in-script-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2997-expected.png:
  • platform/chromium-mac-snowleopard/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium-mac/editing/selection/select-missing-image-expected.png:
  • platform/chromium-mac/fast/block/float/002-expected.png:
  • platform/chromium-mac/fast/block/float/017-expected.png:
  • platform/chromium-mac/fast/dom/HTMLImageElement/image-alt-text-expected.png:
  • platform/chromium-mac/fast/dom/HTMLImageElement/image-alt-text-expected.txt: Renamed from LayoutTests/platform/chromium/fast/dom/HTMLImageElement/image-alt-text-expected.txt.
  • platform/chromium-mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/chromium-mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt: Renamed from LayoutTests/platform/chromium/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt.
  • platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/chromium-mac/fast/flexbox/023-expected.png:
  • platform/chromium-mac/fast/flexbox/024-expected.png:
  • platform/chromium-mac/fast/forms/005-expected.png:
  • platform/chromium-mac/fast/forms/input-value-expected.png:
  • platform/chromium-mac/fast/forms/input-value-expected.txt:
  • platform/chromium-mac/fast/invalid/012-expected.png:
  • platform/chromium-mac/fast/parser/comment-in-script-expected.png:
  • platform/chromium-mac/tables/mozilla/bugs/bug2997-expected.png:
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.txt: Renamed from LayoutTests/platform/chromium/tables/mozilla/collapsing_borders/bug41262-3-expected.txt.
  • platform/chromium-win/editing/selection/select-missing-image-expected.png:
  • platform/chromium-win/fast/block/float/002-expected.png:
  • platform/chromium-win/fast/block/float/017-expected.png:
  • platform/chromium-win/fast/dom/HTMLImageElement/image-alt-text-expected.png:
  • platform/chromium-win/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
  • platform/chromium-win/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/chromium-win/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
  • platform/chromium-win/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-win/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/chromium-win/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-win/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/chromium-win/fast/flexbox/023-expected.png:
  • platform/chromium-win/fast/flexbox/024-expected.png:
  • platform/chromium-win/fast/forms/input-value-expected.png:
  • platform/chromium-win/fast/forms/input-value-expected.txt:
  • platform/chromium-win/fast/invalid/012-expected.png:
  • platform/chromium-win/fast/parser/comment-in-script-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2997-expected.png:
  • platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium-win/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
  • platform/chromium/TestExpectations:
1:31 AM Changeset in webkit [147526] by mkwst@chromium.org
  • 4 edits in trunk/Source/WebCore

Extract URL that doesn't inherit a parent's SecurityOrigin out into a constant.
https://bugs.webkit.org/show_bug.cgi?id=113780

Reviewed by Jochen Eisinger.

We're scheduling navigations to 'data:text/html,' in XSSAuditor in
order to end up on a page that doesn't inherit its parent's
SecurityOrigin. We'll be reusing this mechainsm to solve
http://wkbug.com/112903

This patch makes us more explicit about what we're doing and why.
It doesn't change any behavior: XSSAuditor tests should still pass.

  • html/parser/XSSAuditorDelegate.cpp:

(WebCore::XSSAuditorDelegate::didBlockScript):

Use SecurityOrigin::urlWithUniqueSecurityOrigin rather than a
literal string to make our intentions clear.

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::urlWithUniqueSecurityOrigin):

  • page/SecurityOrigin.h:

Add the new static method.

1:21 AM Changeset in webkit [147525] by rniwa@webkit.org
  • 7 edits in trunk/Source

Remove code for Mac 10.5 and earlier from WTF and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=113844

Reviewed by Benjamin Poulain.

Removed the code for 10.5 and removed if-def for 10.6.

Source/WebKit2:

  • Shared/mac/PasteboardTypes.mm:

(WebKit::PasteboardTypes::forEditing):

Source/WTF:

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

  • wtf/Platform.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeCurrentThreadInternal):

  • wtf/unicode/icu/CollatorICU.cpp:

(WTF::Collator::userDefault):

12:54 AM Changeset in webkit [147524] by Christophe Dumez
  • 14 edits in trunk/LayoutTests

Unreviewed, rebaseline several tests cases for GTK that have better results
after r147492.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/dom/HTMLImageElement/image-alt-text-expected.png:
  • platform/gtk/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
  • platform/gtk/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
  • platform/gtk/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
  • platform/gtk/fast/encoding/utf-16-big-endian-expected.png:
  • platform/gtk/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/gtk/fast/encoding/utf-16-little-endian-expected.png:
  • platform/gtk/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/gtk/fast/forms/input-value-expected.png:
  • platform/gtk/fast/forms/input-value-expected.txt:
  • platform/gtk/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/gtk/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
Note: See TracTimeline for information about the timeline view.