Timeline
Apr 16, 2013:
- 9:58 PM Changeset in webkit [148591] by
-
- 2 edits in trunk/Websites/webkit.org
Update team.html to use contributors.json instead of committers.py
https://bugs.webkit.org/show_bug.cgi?id=114720
Reviewed by Ryosuke Niwa.
Updating the team.html to use contributors.json. Also removing the unused field 'area'
from the contributors information.
- team.html:
- 8:55 PM Changeset in webkit [148590] by
-
- 7 edits in trunk/Source
Re-name Page::layoutMilestones() to Page::requestedLayoutMilestones()
https://bugs.webkit.org/show_bug.cgi?id=114713
Reviewed by Simon Fraser.
Source/WebCore:
- page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::addLayoutMilestones):
(WebCore::Page::removeLayoutMilestones):
(WebCore::Page::isCountingRelevantRepaintedObjects):
- page/Page.h:
(WebCore::Page::requestedLayoutMilestones):
(Page):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _layoutMilestones]):
- 7:24 PM WebKit Team edited by
- (diff)
- 7:14 PM Changeset in webkit [148589] by
-
- 4 edits in trunk/Tools
Add Efl WebKit2 EWS bot
https://bugs.webkit.org/show_bug.cgi?id=114564
Reviewed by Ryosuke Niwa.
Added EflWK2EWS, and add myself a watcher for EflWK2EWS.
Also add a deprecated EflWK2Port class.
Besides clean up eflews watchers.
- QueueStatusServer/config/queues.py:
- Scripts/webkitpy/common/config/ews.json:
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port):
(EflPort.build_webkit_command):
(EflWK2Port):
(EflWK2Port.build_webkit_command):
- 6:41 PM Changeset in webkit [148588] by
-
- 4 edits1 add in trunk/Tools
Isolate Early Warning System definitions into a JSON
https://bugs.webkit.org/show_bug.cgi?id=114558
Reviewed by Benjamin Poulain.
Added ews.json to common/config, and made tool/commands/init.py call
AbstractEarlyWarningSystem.load_ews_classes to instantiate classes based on ews.json.
Reland the patch since the EWS failure was a false positive.
- Scripts/webkitpy/common/config/ews.json: Extracted from earlywarningsystem.py.
- Scripts/webkitpy/tool/commands/init.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem):
(AbstractEarlyWarningSystem.init):
(AbstractEarlyWarningSystem.load_ews_classes): Added. Loads ews.json.
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSystemTest._default_expected_logs):
(_test_ews):
(test_ewses):
- 6:13 PM Changeset in webkit [148587] by
-
- 2 edits in trunk/Source/WTF
Harden FastMalloc against partial pointer overflows
https://bugs.webkit.org/show_bug.cgi?id=114716
Reviewed by Gavin Barraclough.
Bite the bullet and perform object alignment checks on free.
malloc/free micro benchmark shows a regression, but real
benchmarks don't. There's a little code motion in this avoid
taking too much of a performance hit. In addition to the
alignment check we also validate the containing span as
we've already taken the hit of finding it.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- 6:01 PM Changeset in webkit [148586] by
-
- 3 edits in trunk/Source/WebCore
[CMake] Fix dependecy calculation for generated inspector files
https://bugs.webkit.org/show_bug.cgi?id=114092
Reviewed by Brent Fulgham.
At least in a generated Visual Studio solution the files generated via
CodeGeneratorInspector.py are considered outdated all the time because
the code generator only touches the file when the content changed.
Add an --write_always parameter to the script to touch the file always.
- CMakeLists.txt:
- inspector/CodeGeneratorInspector.py:
- 5:38 PM Changeset in webkit [148585] by
-
- 9 edits in trunk/Source
Clone storage namespaces for window.open
https://bugs.webkit.org/show_bug.cgi?id=114703
Reviewed by Sam Weinig.
Source/WebCore:
Pass the new page to StorageNamespace::copy.
- page/Chrome.cpp:
(WebCore::Chrome::createWindow):
- storage/StorageNamespace.h:
(StorageNamespace):
- storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::copy):
- storage/StorageNamespaceImpl.h:
(WebCore):
(StorageNamespaceImpl):
Source/WebKit2:
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::StorageArea::clone):
New helper function for cloning a storage area.
(WebKit::StorageManager::StorageArea::setItem):
Correctly handle the copy-on-write feature of StorageMap if it has multiple storage areas pointing to it.
(WebKit::StorageManager::StorageArea::removeItem):
Ditto.
(WebKit::StorageManager::SessionStorageNamespace::cloneTo):
Add cloned storage areas.
- WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::copy):
Create a new session storage namespace for the new page.
- 5:30 PM Changeset in webkit [148584] by
-
- 6 edits in trunk
Fix fallout after r148545.
Source/WebCore:
- platform/text/TextChecking.h:
Move Platform defines that were incorrectly in WebCore, into Platform.h
Source/WTF:
- wtf/Platform.h:
Move Platform defines that were incorrectly in WebCore, into Platform.h
Tools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
Remove calls to non-existent API functions.
- 5:21 PM Changeset in webkit [148583] by
-
- 6 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r148576.
http://trac.webkit.org/changeset/148576
https://bugs.webkit.org/show_bug.cgi?id=114714
WebCore is building some of these same files (Requested by
bfulgham on #webkit).
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcproj/jsc/jsc.vcproj:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- JavaScriptCore.vcxproj/jsc/jsc.vcxproj:
- JavaScriptCore.vcxproj/jsc/jsc.vcxproj.filters:
- 5:09 PM Changeset in webkit [148582] by
-
- 4 edits2 adds in trunk
[CSS Exclusions] polygon shape-inside layout fails
https://bugs.webkit.org/show_bug.cgi?id=114402
Source/WebCore:
Reviewed by Dirk Schulze.
The firstIncludedIntervalLogicalTop() method's implementation relied on optimistic
assumptions about floating point accuracy which, in rare cases, caused it to discard
first-fit locations based on the intersection of the minLogicalIntervalTop offset edge
and a polygon offset edge. Now: we do not verify that first-fit locations based on the
intersection of an offset edge and the minLogicalIntervalTop offset edge are below
the horizontal minLogicalIntervalTop line. They're essentially below the line "by definition".
Test: fast/exclusions/shape-inside/shape-inside-polygon-layout.html
- rendering/ExclusionPolygon.cpp:
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): Avoid floating point problems
when checking intersections with the offset edge based on minLogicalIntervalTop.
- rendering/ExclusionPolygon.h:
(WebCore::OffsetPolygonEdge::OffsetPolygonEdge): Initialize the basis field.
(WebCore::OffsetPolygonEdge::basis): Report what the offset edge is "based on": a polygon
edge, the top of the line, or a (reflex) vertex.
(OffsetPolygonEdge): Added the Basis enum to enable tracking what the geometry of
an offset edge is based on.
LayoutTests:
Verify that subsequent polygon shape-inside lines are vertically adjacent.
Reviewed by Dirk Schulze.
- fast/exclusions/shape-inside/shape-inside-polygon-layout-expected.txt: Added.
- fast/exclusions/shape-inside/shape-inside-polygon-layout.html: Added.
- 5:07 PM Changeset in webkit [148581] by
-
- 1 edit3 adds in trunk/LayoutTests
[CSS Shaders] Add a test with a vertex, fragment shader pair that compiles but don't link
https://bugs.webkit.org/show_bug.cgi?id=114636
Added a test to check that unavailable varyings in fragment shaders
don't lead to unexpected crashes due to linking errors.
The current implementation does not crash, and this makes sure it
won't in future.
Reviewed by Dean Jackson.
- css3/filters/custom/custom-filter-unavailable-varying-expected.html: Added.
- css3/filters/custom/custom-filter-unavailable-varying.html: Added.
- css3/filters/resources/unavailable-varying.fs: Added.
- 5:05 PM Changeset in webkit [148580] by
-
- 4 edits in branches/safari-536.30-branch/Source
Versioning.
- 5:05 PM Changeset in webkit [148579] by
-
- 2 edits in trunk/Source/WebCore
Further unreviewed build fix: protect JSAudioBufferCustom with a ENABLE(WEB_AUDIO) check.
- bindings/js/JSAudioBufferCustom.cpp:
- 5:03 PM Changeset in webkit [148578] by
-
- 1 copy in tags/Safari-536.30
New Tag.
- 5:03 PM Changeset in webkit [148577] by
-
- 4 edits in trunk/Source/WebKit/win
Unreviewed. Build fix for Windows.
- WebCoreSupport/WebContextMenuClient.cpp:
- WebCoreSupport/WebDragClient.cpp:
- WebFrame.cpp:
- 5:02 PM Changeset in webkit [148576] by
-
- 6 edits in trunk/Source/JavaScriptCore
[Windows, WinCairo] Stop individually building WTF files in JSC.
https://bugs.webkit.org/show_bug.cgi?id=114705
Reviewed by Anders Carlsson.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
Export additional String/fastMalloc symbols needed by JSC program.
- JavaScriptCore.vcproj/jsc/jsc.vcproj: Don't manually build
WTF implementation files (a second time!) in this project.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
Export additional String/fastMalloc symbols needed by JSC program.
- JavaScriptCore.vcxproj/jsc/jsc.vcxproj: Don't manually
build WTF implementation files (a second time!) in this project.
- JavaScriptCore.vcxproj/jsc/jsc.vcxproj.filters: Ditto.
- 4:52 PM Changeset in webkit [148575] by
-
- 5 edits in trunk/Source/WebKit/blackberry
Redo spellchecking of a field if the layout has changed
https://bugs.webkit.org/show_bug.cgi?id=114700
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-04-16
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
PR258637
If we insert a child node during spellchecking, the current request along
with the requests in queue become stale. The offsets were calculated when
they were created are no longer valid. We clear the queue by setting sequence
id to -1 and trigger spell checking again. We only trigger re-checking
if the layout change occurred during processing of a request. This is
maintained with the m_request pointer as it should be cleared after use.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::layoutFinished):
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::requestCheckingOfString):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(BlackBerry::WebKit::InputHandler::spellCheckTextBlock):
(WebKit):
(BlackBerry::WebKit::InputHandler::stopPendingSpellCheckRequests):
- WebKitSupport/InputHandler.h:
(InputHandler):
- 4:52 PM Changeset in webkit [148574] by
-
- 2 edits in branches/safari-536.30-branch/LayoutTests
CSS Variables aren't available on safari-536.30-branch.
<rdar://problem/13668920>
Patch by David Farler <dfarler@apple.com> on 2013-04-16
- platform/mac/Skipped:
Skip fast/css/variables/deferred-image-load-from-variable.html
- 4:47 PM Changeset in webkit [148573] by
-
- 2 edits in branches/safari-536.30-branch/LayoutTests
Skip fast/dom/Geolocation/watchPosition-unique.html on safari-536.30-branch
<rdar://problem/13668237>
Patch by David Farler <dfarler@apple.com> on 2013-04-16
- platform/mac/Skipped:
Skip fast/dom/Geolocation/watchPosition-unique.html.
- 4:45 PM Changeset in webkit [148572] by
-
- 1 edit in branches/safari-536.30-branch/Source/WebKit2/win/WebKit2.def
Windows build fix after r139111.
- 4:45 PM Changeset in webkit [148571] by
-
- 4 edits in trunk
.: [CMake] Do not use JAVASCRIPTCORE_DIR in add_custom_command() of JavaScriptcore project
https://bugs.webkit.org/show_bug.cgi?id=114265
Reviewed by Brent Fulgham.
- Source/cmake/WebKitMacros.cmake: Removed macro GENERATE_HASH_LUT.
Source/JavaScriptCore: [CMake] Do not use JAVASCRIPTCORE_DIR in add_custom_command() of JavaScriptCore project
https://bugs.webkit.org/show_bug.cgi?id=114265
Reviewed by Brent Fulgham.
Use CMAKE_CURRENT_SOURCE_DIR instead, since it provides the same value and is more
understandable. Also move the GENERATE_HASH_LUT macro into the CMakeLists.txt
of JavaScriptCore to avoid the usage of JAVASCRIPTCORE_DIR there too.
- CMakeLists.txt:
- 4:31 PM Changeset in webkit [148570] by
-
- 6 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG should be able to query Structure without modifying it
https://bugs.webkit.org/show_bug.cgi?id=114708
Reviewed by Oliver Hunt.
This is work towards allowing the DFG, and FTL, to run on a separate thread.
The idea is that the most evil thing that the DFG does that has thread-safety
issues is fiddling with Structures by calling Structure::get(). This can lead
to rematerialization of property tables, which is definitely not thread-safe
due to how StringImpl works. So, this patch completely side-steps the problem
by creating a new version of Structure::get, called
Structure::getWithoutMaterializing, which may choose to do an O(n) search if
necessary to avoid materialization. I believe this should be fine - the DFG
does't call into these code path often enough for this to matter, and most of
the time, the Structure that we call this on will already have a property
table because some inline cache would have already called ::get() on that
Structure.
Also cleaned up the materialization logic: we can stop the search as soon as
we find any Structure with a property table rather than searching all the way
for a pinned one.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
- runtime/Structure.cpp:
(JSC::Structure::findStructuresAndMapForMaterialization):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::getWithoutMaterializing):
(JSC):
- runtime/Structure.h:
(Structure):
- runtime/StructureInlines.h:
(JSC::Structure::getWithoutMaterializing):
(JSC):
- 4:31 PM Changeset in webkit [148569] by
-
- 4 edits in trunk/Source/WebCore
Changed the default debugger from GDB to LLDB for the 'All Source' scheme in WebKit.xcworkspace.
Patch by Andy Estes <aestes@apple.com> on 2013-04-16
Rubber-stamped by Dan Bernstein.
- WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
- 4:26 PM Changeset in webkit [148568] by
-
- 2 edits in trunk/Source/JavaScriptCore
Another Windows build fix attempt.
- runtime/JSGlobalData.h:
(JSGlobalData):
- 4:25 PM Changeset in webkit [148567] by
-
- 2 edits in branches/safari-536.30-branch/LayoutTests
<rdar://problem/13668125> Elgar: fast/block/float/float-not-removed-from-pre-block.html fails: expected file needs updating: two spaces
Patch by David Farler <dfarler@apple.com> on 2013-04-16
- fast/block/float/float-not-removed-from-pre-block-expected.txt:
Two spaces instead of one.
- 4:17 PM Changeset in webkit [148566] by
-
- 5 edits1 add in trunk/Source/WebCore
Repeated use of decodeAudioData() causes leak
https://bugs.webkit.org/show_bug.cgi?id=114709
Reviewed by Geoffrey Garen.
Report the correct size of the AudioBuffer to the garbage collector so that creating
these large buffers will trigger garbage collection.
- Modules/webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::memoryCost): Added; simple sum of the buffer sizes in m_channels;
- Modules/webaudio/AudioBuffer.h:
- Modules/webaudio/AudioBuffer.idl: Add the CustomToJSObject flag.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSAudioBufferCustom.cpp: Added.
(WebCore::toJS): Added; report the extra size of an AudioBuffer when the wrapper
is created.
- 4:01 PM Changeset in webkit [148565] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Viewport not rendered correctly
https://bugs.webkit.org/show_bug.cgi?id=114704
Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-04-16.
Reviewed by Rob Buis.
Internally reviewed by Konrad Piascik.
PR: 326260
The applyDeviceScaleFactorInCompositor setting is now generated from
Settings.in after rebase, the setter should be setApplyDeviceScaleFactorInCompositor()
instead of setApplyPageScaleFactorInCompositor().
The setting can be removed from WebSettings and use a simpler way
instead in the future if there are no issues when TextAutoSizer is
enabled. Just keep it for now.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
- Api/WebSettings.cpp:
(BlackBerry::WebKit::WebSettings::setApplyDeviceScaleFactorInCompositor):
- Api/WebSettings.h:
- 4:01 PM Changeset in webkit [148564] by
-
- 12 edits1 add in trunk/Source
Need a new layout milestone to notify bundle clients when the header has been
flushed
https://bugs.webkit.org/show_bug.cgi?id=114706
-and corresponding-
<rdar://problem/13657284>
Reviewed by Simon Fraser.
Source/WebCore:
New LayoutMilestone is DidFirstFlushForHeaderLayer.
- page/LayoutMilestones.h:
New API to allow removing a LayoutMilestone.
- WebCore.exp.in:
- page/Page.cpp:
(WebCore::Page::removeLayoutMilestones):
- page/Page.h:
(Page):
New boolean member variable m_headerLayerAwaitingFirstFlush keeps track of whether
we need to send the DidFirstFlushForHeaderLayer milestone.
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
Send the milestone if appropriate.
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
Set m_headerLayerAwaitingFirstFlush to true for a newly created layer.
(WebCore::RenderLayerCompositor::updateLayerForHeader):
Source/WebKit2:
Make this new LayoutMilestone private at the API layer.
- Shared/API/c/WKPageLoadTypes.h:
- Shared/API/c/WKPageLoadTypesPrivate.h: Added.
Handle the new milestone.
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toWKLayoutMilestones):
(WebKit::toLayoutMilestones):
New file to make the milestone private.
- WebKit2.xcodeproj/project.pbxproj:
Add or remove the DidFirstFlushForHeaderLayer millstone based on whether we just
added or removed a header.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::setHeaderLayerWithHeight):
- 4:01 PM Changeset in webkit [148563] by
-
- 3 edits in branches/dfgFourthTier/WebKitLibraries
Updated LLVM drops to include MCJIT fixes.
- LLVMIncludesMountainLion.tar.bz2:
- LLVMLibrariesMountainLion.tar.bz2:
- 3:59 PM Changeset in webkit [148562] by
-
- 2 edits in trunk/Source/JavaScriptCore
Try to fix the Windows build.
- runtime/JSGlobalData.h:
- 3:58 PM Changeset in webkit [148561] by
-
- 3 edits in branches/dfgFourthTier/Tools
fourthTier: Update LLVM-related build scripts to copy generated headers as well
https://bugs.webkit.org/show_bug.cgi?id=114551
Reviewed by Oliver Hunt.
Also added the ability to use something other than bzip2 compression, since although
it is great for checking things into the tree, it increases turn-around times when
experimenting.
- Scripts/copy-webkitlibraries-to-product-directory:
(unpackIfNecessary):
- Scripts/export-llvm-build:
- 3:58 PM Changeset in webkit [148560] by
-
- 3 edits in trunk/Source/WebCore
PlugIn Snapshotting: Crashes refreshing non-main-frame PDFPlugins
https://bugs.webkit.org/show_bug.cgi?id=114702
<rdar://problem/13542020>
Reviewed by Dean Jackson.
If:
a) a plugin fails all the tests in willCreatePlugIn, so it is WaitingForSnapshot there
b) primary plugin detection attempts to restart a plugin between the
time that willCreatePlugIn and didCreatePlugIn fire
c) when didCreatePlugIn fires, shouldAlwaysAutoStart() returns true,
because the plug-in is whitelisted,
we end up reattach()ing and going to Restarted state, and then going straight
to Playing state in didCreatePlugIn.
Instead, primary plugin promotion should be deferred until after the plugin is created,
so that we can take that one last bit of information (shouldAlwaysAutoStart) into account
before restarting and reattaching the plug-in.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn):
(WebCore::HTMLPlugInImageElement::restartSnapshottedPlugIn):
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):
(WebCore::HTMLPlugInImageElement::subframeLoaderDidCreatePlugIn):
- html/HTMLPlugInImageElement.h:
- 3:52 PM Changeset in webkit [148559] by
-
- 4 edits in branches/safari-536.30-branch/Source
Fixing incorrect versioning.
- 3:51 PM Changeset in webkit [148558] by
-
- 2 edits in trunk/Source/WebKit/gtk
Fix speling error.
- WebCoreSupport/WebViewInputMethodFilter.cpp:
- 3:38 PM Changeset in webkit [148557] by
-
- 3 edits in trunk/Source/WebKit/efl
More EFL build fixes.
- ewk/ewk_frame.cpp:
- ewk/ewk_view.cpp:
- 3:38 PM Changeset in webkit [148556] by
-
- 1 edit in branches/safari-536.30-branch/LayoutTests/fast/parser/document-open-in-unload.html
Change testRunner to layoutTestController.
- 3:35 PM Changeset in webkit [148555] by
-
- 2 edits in trunk/Source/WebCore
ASSERTION FAILED: i < size(), UNKNOWN in WebCore::ChannelMergerNode::process
https://bugs.webkit.org/show_bug.cgi?id=112657
Avoid to access input bus in checkNumberOfChannelsForInput() before the
bus is updated with AudioNode::checkNumberOfChannelsForInput().
Reviewed by Chris Rogers.
- Modules/webaudio/ChannelMergerNode.cpp:
(WebCore::ChannelMergerNode::checkNumberOfChannelsForInput):
- 3:35 PM Changeset in webkit [148554] by
-
- 2 edits in trunk/Source/WebKit/gtk
Another GTK+ build fix.
- WebCoreSupport/WebViewInputMethodFilter.cpp:
- 3:33 PM Changeset in webkit [148553] by
-
- 2 edits in trunk/Source/WebKit2
Another EFL build fix.
- WebProcess/WebPage/efl/WebPageEfl.cpp:
- 3:30 PM Changeset in webkit [148552] by
-
- 4 edits in trunk/Source/WebKit/gtk
GTK+ build fix attempt.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/WebViewInputMethodFilter.cpp:
- webkit/webkitwebframe.cpp:
- 3:28 PM Changeset in webkit [148551] by
-
- 3 edits in trunk/Source/WebCore
Even more Windows build fix and a Qt minimal build fix attempt.
- html/parser/XSSAuditorDelegate.cpp:
- page/win/FrameCGWin.cpp:
- 3:24 PM Changeset in webkit [148550] by
-
- 2 edits in trunk/Source/WebKit/efl
EFL build fix after r148545.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- 3:22 PM Changeset in webkit [148549] by
-
- 3 edits in trunk/Source/WebCore
More Windows build fixes.
- platform/win/DragDataWin.cpp:
- platform/win/PasteboardWin.cpp:
- 3:03 PM Changeset in webkit [148548] by
-
- 2 edits in trunk/Source/WebCore
Windows build fix.
- page/win/FrameWin.cpp:
- 3:01 PM Changeset in webkit [148547] by
-
- 2 edits in trunk/Source/WebCore
PlugIns that resize in user gestures should be immune to snapshotting
https://bugs.webkit.org/show_bug.cgi?id=114697
<rdar://problem/13666258>
Reviewed by Tim Horton.
Now that we snapshot plugins if they resize above the snapshotting threshold,
we need to make sure that we don't do it in response to a user gesture
such as a click.
Due to the complexities of real-world content and the way they often do
things using timeout, I copied the code from the generic user gesture
timeout, which gives a 5 second grace period after clicks.
- html/HTMLPlugInImageElement.cpp:
(WebCore::documentHadRecentUserGesture): New static function to share the code for
checking the time since the last click (or whatever).
(WebCore::HTMLPlugInImageElement::checkSizeChangeForSnapshotting): Make sure
to test for a user gesture.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Move the
code into the new function.
- 2:55 PM Changeset in webkit [148546] by
-
- 2 edits in trunk/LayoutTests
[Mac] compositing/background-color/background-color-change-to-text.html fails on some bots
https://bugs.webkit.org/show_bug.cgi?id=106186
- platform/mac/TestExpectations:
Mark 7 other tests that fall under this category as flakey.
- 2:54 PM Changeset in webkit [148545] by
-
- 67 edits in trunk/Source
Remove more #includes from Frame.h
https://bugs.webkit.org/show_bug.cgi?id=114642
Reviewed by Anders Carlsson.
Source/WebCore:
Convert Editor, FrameSelection, EventHandler and AnimationController into
OwnPtrs, to avoid inclusion.
- accessibility/AXObjectCache.cpp:
- accessibility/AccessibilityObject.cpp:
- accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
- bindings/objc/DOM.mm:
- dom/CharacterData.cpp:
- dom/ContainerNode.cpp:
- dom/Element.cpp:
- editing/AlternativeTextController.cpp:
- editing/CompositeEditCommand.cpp:
- editing/DeleteButtonController.h:
- editing/EditingStyle.cpp:
- editing/InsertLineBreakCommand.cpp:
- editing/SpellChecker.cpp:
- editing/SpellingCorrectionCommand.cpp:
- editing/TextInsertionBaseCommand.cpp:
- history/CachedFrame.cpp:
- html/HTMLAnchorElement.cpp:
- html/HTMLInputElement.cpp:
- html/HTMLPlugInElement.cpp:
- html/HTMLSelectElement.cpp:
- html/HTMLTextAreaElement.cpp:
- html/HTMLTextFormControlElement.cpp:
- html/TextFieldInputType.cpp:
- html/shadow/ClearButtonElement.cpp:
- html/shadow/MediaControlElements.cpp:
- html/shadow/SliderThumbElement.cpp:
- inspector/InspectorPageAgent.h:
- loader/FrameLoader.cpp:
- page/DOMWindow.cpp:
- page/Frame.cpp:
- page/Frame.h:
- page/FrameView.cpp:
- page/FrameView.h:
- page/Page.cpp:
- page/TouchAdjustment.cpp:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
- platform/gtk/PasteboardGtk.cpp:
- platform/qt/ClipboardQt.cpp:
- rendering/HitTestResult.cpp:
- rendering/RenderBlock.cpp:
- rendering/RenderEmbeddedObject.cpp:
- rendering/RenderLayer.cpp:
- rendering/RenderNamedFlowThread.cpp:
- rendering/RenderObject.cpp:
- rendering/RenderSnapshottedPlugIn.cpp:
- svg/graphics/SVGImage.cpp:
- testing/Internals.cpp:
Source/WebKit/mac:
- WebView/WebFrame.mm:
- WebView/WebHTMLRepresentation.mm:
- WebView/WebView.mm:
Source/WebKit/qt:
- WebCoreSupport/DragClientQt.cpp:
- WebCoreSupport/FrameLoaderClientQt.cpp:
- WebCoreSupport/QWebFrameAdapter.cpp:
- WebCoreSupport/QWebPageAdapter.cpp:
Source/WebKit2:
- WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:
- WebProcess/Plugins/PluginView.cpp:
- WebProcess/WebPage/WebFrame.cpp:
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
- WebProcess/WebPage/mac/WebPageMac.mm:
- WebProcess/WebPage/qt/WebPageQt.cpp:
- 2:35 PM Changeset in webkit [148544] by
-
- 4 edits2 copies in branches/safari-536.30-branch
Merge r125955. <rdar://problem/13485383>
- 2:22 PM Changeset in webkit [148543] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Update WebPage.{h, cpp} for supporting web filesystem
https://bugs.webkit.org/show_bug.cgi?id=114698
Reviewed by Rob Buis.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::clearBrowsingData):
(BlackBerry::WebKit::WebPage::clearWebFileSystem):
(WebKit):
- Api/WebPage.h:
- 2:20 PM Changeset in webkit [148542] by
-
- 2 edits in trunk/Source/WebCore
Speculative Windows build fix.
- platform/win/ContextMenuWin.cpp:
- 2:07 PM Changeset in webkit [148541] by
-
- 2 edits in trunk
Changed the default debugger from GDB to LLDB for the 'All Source' scheme in WebKit.xcworkspace.
Rubber-stamped by Dan Bernstein.
- WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
- 1:42 PM Changeset in webkit [148540] by
-
- 13 edits in trunk/Source/WebCore
[Mac] in-band cues sometimes displayed late
https://bugs.webkit.org/show_bug.cgi?id=114629
Reviewed by Jer Noble.
No new tests, this deals with a platform-specific issue that is extremely timing dependent.
- html/track/InbandTextTrack.cpp:
(WebCore::TextTrackCueMap::add): New, two way cue data <-> cue map.
(WebCore::TextTrackCueMap::find):
(WebCore::TextTrackCueMap::remove):
(WebCore::InbandTextTrack::updateCueFromCueData): New, update an existing cue. Set cue end time
to video duration if it is unknown.
(WebCore::InbandTextTrack::addGenericCue): Look for existing cues without considering duration
so we can match incomplete cues.
(WebCore::InbandTextTrack::updateGenericCue): New, update an existing cue. This allows us to
add in-band cues as soon as we get them from the media engine and update them as more
information becomes available.
(WebCore::InbandTextTrack::removeGenericCue): New, remove an existing cue. This is necessary
because we never want to keep an incomplete cue when a seek happens.
(WebCore::InbandTextTrack::removeCue): New, base class override so we can keep the two way
map up to date.
- html/track/InbandTextTrack.h:
- html/track/TextTrack.cpp:
(WebCore::TextTrack::addCue): TextTrack::removeCue takes a RefPtr.
(WebCore::TextTrack::removeCue): Take a RefPtr.
(WebCore::TextTrack::hasCue): Allow caller to request match without considering end time.
- html/track/TextTrack.h:
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::TextTrackCue): Initialize m_processingCueChanges.
(WebCore::TextTrackCue::willChange): Renamed from cueWillChange. Use m_processingCueChanges
to avoid thrashing the track when many cue properties will change.
(WebCore::TextTrackCue::didChange): Renamed from cueDidChange. Use m_processingCueChanges
to avoid thrashing the track when many cue properties will change.
(WebCore::TextTrackCue::setId): cueWillChange -> willChange. cueDidChange -> didChange.
(WebCore::TextTrackCue::setStartTime): Ditto.
(WebCore::TextTrackCue::setEndTime): Ditto.
(WebCore::TextTrackCue::setPauseOnExit): Ditto.
(WebCore::TextTrackCue::setVertical): Ditto.
(WebCore::TextTrackCue::setSnapToLines): Ditto.
(WebCore::TextTrackCue::setLine): Ditto.
(WebCore::TextTrackCue::setPosition): Ditto.
(WebCore::TextTrackCue::setSize): Ditto.
(WebCore::TextTrackCue::setAlign): Ditto.
(WebCore::TextTrackCue::setText): Ditto.
(WebCore::TextTrackCue::setRegionId): Ditto.
(WebCore::TextTrackCue::isEqual): Renamed from operator==, take match rules param.
- html/track/TextTrackCue.h:
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGeneric::isEqual): Renamed from operator==, take match rules param.
- html/track/TextTrackCueGeneric.h:
- platform/graphics/InbandTextTrackPrivateClient.h: Make GenericCueData refcounted.
(WebCore::GenericCueData::create): New.
(WebCore::GenericCueData::status): Ditto.
(WebCore::GenericCueData::setStatus): Ditto.
(WebCore::GenericCueData::GenericCueData):
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processCue): Add cues as soon as we get them from the media
engine, update duration once we know it.
(WebCore::InbandTextTrackPrivateAVF::resetCueValues): Tell the client to remove all incomplete
cues we have delivered.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Do not flush cues when seek completes,
we did that when the seek started and cues can be delivered before we get the the
seek completed notification.
- 1:22 PM Changeset in webkit [148539] by
-
- 5 edits in trunk
dfn element should be exposed as AXGroup:AXDefinition
https://bugs.webkit.org/show_bug.cgi?id=108980
Patch by James Craig <james@cookiecrook.com> on 2013-04-16
Reviewed by Chris Fleizach.
Source/WebCore:
dfn element now exposed as AXGroup:AXDefinition. Updated existing tests.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
LayoutTests:
dfn element now exposed as AXGroup:AXDefinition
- platform/mac/accessibility/role-subrole-roledescription-expected.txt:
- platform/mac/accessibility/role-subrole-roledescription.html:
- 1:15 PM Changeset in webkit [148538] by
-
- 2 edits in trunk/Source/WebKit2
Make resizing the docked Web Inspector stay in sync with the inspected view.
Reviewed by Joseph Pecoraro.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange):
Disable screen updates to make sure the layers for both views resize in sync.
- 1:05 PM Changeset in webkit [148537] by
-
- 6 edits in trunk/Source/WebCore
Begin chipping away at ScriptState
https://bugs.webkit.org/show_bug.cgi?id=114695
Reviewed by Geoffrey Garen.
Remove ScriptStateProtectedPtr as well as evalEnabled and setEvalEnabled.
- bindings/js/ScriptState.cpp:
- bindings/js/ScriptState.h:
- inspector/InjectedScriptBase.cpp:
(WebCore::InjectedScriptBase::callFunctionWithEvalEnabled):
- inspector/ScriptArguments.cpp:
(WebCore::ScriptArguments::ScriptArguments):
(WebCore::ScriptArguments::globalState):
- inspector/ScriptArguments.h:
- 12:57 PM Changeset in webkit [148536] by
-
- 50 edits in trunk/Source
Remove unneeded headers from ScriptExecutionContext.h
https://bugs.webkit.org/show_bug.cgi?id=114631
Reviewed by Alexey Proskuryakov.
Source/WebCore:
This shaves another minute off WebCore build time on my MacBook Pro.
- dom/ScriptExecutionContext.cpp:
- dom/ScriptExecutionContext.h:
- fileapi/Blob.cpp:
- rendering/RenderBlock.cpp:
- rendering/RenderBox.cpp:
- rendering/RenderFlowThread.cpp:
- rendering/RenderFrameSet.cpp:
- rendering/RenderIFrame.cpp:
- rendering/RenderImage.cpp:
- rendering/RenderListBox.cpp:
- rendering/RenderListItem.cpp:
- rendering/RenderListMarker.cpp:
- rendering/RenderMedia.cpp:
- rendering/RenderObject.cpp:
- rendering/RenderRegion.cpp:
- rendering/RenderReplaced.cpp:
- rendering/RenderReplica.cpp:
- rendering/RenderRubyRun.cpp:
- rendering/RenderScrollbarPart.cpp:
- rendering/RenderSlider.cpp:
- rendering/RenderTable.cpp:
- rendering/RenderTableCell.cpp:
- rendering/RenderTableRow.cpp:
- rendering/RenderTableSection.cpp:
- rendering/RenderTextControlSingleLine.cpp:
- rendering/RenderTextTrackCue.cpp:
- rendering/RenderVideo.cpp:
- rendering/RenderView.cpp:
- rendering/RenderWidget.cpp:
- rendering/svg/RenderSVGContainer.cpp:
- rendering/svg/RenderSVGForeignObject.cpp:
- rendering/svg/RenderSVGGradientStop.cpp:
- rendering/svg/RenderSVGHiddenContainer.cpp:
- rendering/svg/RenderSVGImage.cpp:
- rendering/svg/RenderSVGResourceContainer.cpp:
- rendering/svg/RenderSVGResourceMarker.cpp:
- rendering/svg/RenderSVGRoot.cpp:
- rendering/svg/RenderSVGShape.cpp:
- rendering/svg/RenderSVGText.cpp:
Source/WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
- WebProcess/WebPage/PageOverlay.cpp:
- 12:47 PM Changeset in webkit [148535] by
-
- 2 edits in trunk/Tools
Unreviewed. Disable WinEWS tests, simply not enough bots.
All bots are running consistently now but the queue still keeps growing.
Until we get more bots or make the tests faster, it doesn't seem wise to keep running tests.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 12:19 PM Changeset in webkit [148534] by
-
- 7 edits in trunk/Source
Remove even yet still more traces of v8
https://bugs.webkit.org/show_bug.cgi?id=114693
Reviewed by Anders Carlsson.
../WebCore:
No behavior change.
- bindings/generic/ActiveDOMCallback.h:
(WebCore::ActiveDOMCallback::isScriptControllerTerminating): Remove a V8-specific
method and the comment referencing it.
- bindings/generic/ActiveDOMCallback.cpp:
(WebCore::ActiveDOMCallback::isScriptControllerTerminating): ditto
- fileapi/File.cpp:
(WebCore::File::File): Remove a comment referencing v8
- inspector/InjectedScriptExterns.js: ditto
../WebKit2:
- Scripts/generate-forwarding-headers.pl: Remove v8 from list of platforms.
- 12:12 PM Changeset in webkit [148533] by
-
- 3 edits2 copies in branches/safari-536.30-branch
Merged r130313. <rdar://problem/13656005>
- 11:59 AM Changeset in webkit [148532] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: http/tests/security/cookies/third-party-cookie-blocking-user-action.html
https://bugs.webkit.org/show_bug.cgi?id=114511
Clear the test cookie at the beginning of the test to avoid failing if
the cookie is still around from a previous test.
Reviewed by Alexey Proskuryakov.
- http/tests/security/cookies/third-party-cookie-blocking-user-action.html:
- 11:56 AM Changeset in webkit [148531] by
-
- 18 edits in trunk/Source
Remove unused AlternativeTextClient::dismissDictationAlternativeUI
https://bugs.webkit.org/show_bug.cgi?id=114598
Reviewed by Ryosuke Niwa.
Source/WebCore:
Removing dead code.
- WebCore.exp.in:
- editing/mac/AlternativeTextUIController.h: Made dismissAlternatives() private.
- page/AlternativeTextClient.h:
Source/WebKit/mac:
- WebCoreSupport/WebAlternativeTextClient.h:
- WebCoreSupport/WebAlternativeTextClient.mm:
- WebView/WebView.mm:
- WebView/WebViewInternal.h:
Source/WebKit2:
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::dictationAlternatives):
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebAlternativeTextClient.h:
- WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp:
- 11:55 AM Changeset in webkit [148530] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Windows] Unreviewed VS2010 build correction.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorCommon.props:
Specify proper link library to avoid mixture of ICU 4.0 and 4.6
symbols during link.
- 11:54 AM Changeset in webkit [148529] by
-
- 4 edits in trunk/Source/WebKit
../WebKit: [Windows] Unreviewed VS2010 build correction.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorCommon.props:
Add correct link library to avoid mixture of ICU 4.0 and 4.6
syumbol use.
../WebKit/win: [Windows] Unreviewed build correction.
- WebKit.vcproj/WebKitExportGeneratorCommon.vsprops: Add correct
ICU link library to avoid mixture of ICU 4.0 and 4.6 symbols
during link.
- 11:50 AM Changeset in webkit [148528] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
Build fix after r148527.
- committers-autocomplete.js:
(WebKitCommitters):
- 11:41 AM Changeset in webkit [148527] by
-
- 10 edits1 add in trunk
The list of contributors in committers.py should be a separate JSON
https://bugs.webkit.org/show_bug.cgi?id=114673
Reviewed by Anders Carlsson.
Tools:
Added webkitpy/common/config/contributors.json, made CommitterList load it.
- EWSTools/start-queue-mac.sh:
- EWSTools/start-queue.sh:
- Scripts/webkitpy/common/checkout/commitinfo.py:
(CommitInfo.committer):
- Scripts/webkitpy/common/config/contributors.json: Added.
- Scripts/webkitpy/common/config/committers.py:
(Reviewer.init):
(CommitterList.init):
(CommitterList.load_json): Added.
(CommitterList.load_json.emails):
(CommitterList.load_json.nicks):
- Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
(MockCommitInfo.author):
Websites/bugs.webkit.org:
Updated the Bugzilla autocompletion code to use contributors.json.
Basically, this removes a large chunk of this JavaScript file.
- committers-autocomplete.js:
(WebKitCommitters):
Websites/webkit.org:
Updated the website to refer to contributors.json instead of committers.py.
- coding/commit-review-policy.html:
- 11:29 AM Changeset in webkit [148526] by
-
- 15 edits in trunk/Source/WebKit2
[GTK][WK2] Add API to retrieve a snapshot from a webview
https://bugs.webkit.org/show_bug.cgi?id=98270
Reviewed by Anders Carlsson.
This adds the GTK+ API necessary to retrieve a snapshot from a
webview asynchronously. The API uses the injected bundle
internally to get the snapshot from the WebProcess.
- UIProcess/API/gtk/WebKitError.cpp:
(webkit_snapshot_error_quark): Add snapshot API related error
quark.
- UIProcess/API/gtk/WebKitError.h: Add snapshot error handling.
- UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:
(didReceiveWebViewMessageFromInjectedBundle): Handle the new
"DidGetSnapshot" message.
- UIProcess/API/gtk/WebKitPrivate.h: Add SnapshotRegion enum.
- UIProcess/API/gtk/WebKitWebView.cpp:
(_WebKitWebViewPrivate): Add a map for the snapshot results.
(GetSnapshotAsyncData):
(webKitWebViewDidReceiveSnapshot):
(webKitSnapshotRegionToSnapshotRegion): Helper method for casting
the region option enumeration.
(generateSnapshotCallbackID): Method to generate unique callback
ids.
(webkit_web_view_get_snapshot):
(webkit_web_view_get_snapshot_finish): New snapshotting API.
- UIProcess/API/gtk/WebKitWebView.h: Ditto.
- UIProcess/API/gtk/WebKitWebViewPrivate.h: Add the private method
to handle a received snapshot.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add the new API
bits.
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(cairoSurfacesEqual): Add helper to compare cairo_surface_t
structs.
(testWebViewSnapshot): New test.
(beforeAll): Add the new test.
- UIProcess/API/gtk/tests/WebViewTest.cpp:
(WebViewTest::selectAll): Add method to help test snapshots
including selection.
- UIProcess/API/gtk/tests/WebViewTest.h: Ditto
- WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:
(didReceiveMessageToPage): Ditto.
(webkitWebExtensionCreate): Register method above.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkitWebPageDidReceiveMessage): Add this method. It
handles the new message "GetSnapshot".
- WebProcess/InjectedBundle/API/gtk/WebKitWebPagePrivate.h:
Add method above.
- 11:25 AM Changeset in webkit [148525] by
-
- 2 edits in trunk/Source/WebKit/mac
REGRESSION(r146025): WebKit applications can't apply underline or strike through
https://bugs.webkit.org/show_bug.cgi?id=114662
Reviewed by Enrica Casucci.
Use -webkit- prefixes to apply underline. There should be no further compatibility issues
since -khtml- was used only internally to pass the information down to WebCore.
Unfortunately, we can't test this code like any other font panel bug.
In the long run, we need to add some abstraction layer around font panel to make this testable
or else we'll keep regressing this feature.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _styleFromFontAttributes:]):
(-[WebHTMLView _styleForAttributeChange:]):
- 11:08 AM Changeset in webkit [148524] by
-
- 2 edits in trunk/Source/WebKit2
Create full rects for the inspector and inspected views when
adjusting to an inspected view frame change.
This ensures switching dock sides restores the inspected view
and inspector to fill the parent's bounds.
https://webkit.org/b/114666
rdar://problem/13660796
Reviewed by Joseph Pecoraro.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange):
- 10:56 AM Changeset in webkit [148523] by
-
- 4 edits4 adds in trunk
Float at exact multiple of line-height affects too many lines
https://bugs.webkit.org/show_bug.cgi?id=112744
Reviewed by David Hyatt.
Source/WebCore:
Tests: fast/block/float/float-with-fractional-height-vertical-lr.html
fast/block/float/float-with-fractional-height.html
When adding floats to the interval tree used for testing floats' overlap with lineboxes
truncate the dimensions of the float rather than rounding them. This matches the
treatment of linebox dimensions so ensures the test for overlap is comparing like
with like.
- rendering/RenderBlock.cpp:
(WebCore::::collectIfNeeded):
(WebCore::RenderBlock::FloatingObjects::intervalForFloatingObject):
(WebCore::::string):
LayoutTests:
- fast/block/float/float-with-fractional-height-expected.html: Added.
- fast/block/float/float-with-fractional-height-vertical-lr-expected.html: Added.
- fast/block/float/float-with-fractional-height-vertical-lr.html: Added.
- fast/block/float/float-with-fractional-height.html: Added.
- platform/mac/fast/backgrounds/background-position-parsing-expected.txt:
- 10:52 AM Changeset in webkit [148522] by
-
- 6 edits2 adds in trunk
AX: aria-valuetext is not exposed on OS X.
https://bugs.webkit.org/show_bug.cgi?id=114628
Reviewed by Tim Horton.
Source/WebCore:
aria-valuetext is only being exposed on ARIA controls. That's because there were
checks in place so that ONLY ARIA defined controls would return anything related to valuetext.
We should allow this to work on native controls as well.
Test: platform/mac/accessibility/aria-valuetext-on-native-slider.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::valueDescription):
(WebCore):
(WebCore::AccessibilityNodeObject::valueForRange):
(WebCore::AccessibilityNodeObject::maxValueForRange):
(WebCore::AccessibilityNodeObject::minValueForRange):
- accessibility/AccessibilityNodeObject.h:
(AccessibilityNodeObject):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isRangeControl):
Rename isARIAControl to isRangeControl and make it apply to all elements.
- accessibility/AccessibilityObject.h:
LayoutTests:
- platform/mac/accessibility/aria-valuetext-on-native-slider-expected.txt: Added.
- platform/mac/accessibility/aria-valuetext-on-native-slider.html: Added.
- 10:18 AM Changeset in webkit [148521] by
-
- 2 edits in trunk/Source/WebCore
RenderView should bail out of paintBoxDecorations() when painting with a different renderer
https://bugs.webkit.org/show_bug.cgi?id=114665
<rdar://problem/13434884>
Reviewed by Simon Fraser.
- rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations): Add a check to see if we should paint within the renderer.
This check exists in all other implementations of paintBoxDecorations(), and correctly avoids painting the
decorations if the root provided is not the RenderView.
- 10:18 AM Changeset in webkit [148520] by
-
- 1 copy in releases/WebKitGTK/webkit-2.0.1
Tagging the WebKitGTK+ 2.0.1 release
- 10:16 AM Changeset in webkit [148519] by
-
- 6 edits in trunk/Source/WebKit2
Initialize logging channels for web processes
https://bugs.webkit.org/show_bug.cgi?id=114621
Reviewed by Sam Weinig.
Use InitializeWebKit2 for initializing the web and plugin processes.
It handles initializing the logging channels and it's better to have
shared core for this. For the plugin process now we always create
a RunLoop object which is not necessary with the -scanPlugin argument
but it shouldn't be a problem.
- PluginProcess/qt/PluginProcessMainQt.cpp:
(WebKit::PluginProcessMain):
- PluginProcess/unix/PluginProcessMainUnix.cpp:
(WebKit::PluginProcessMainUnix):
- WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl):
- WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):
- WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):
- 10:12 AM Changeset in webkit [148518] by
-
- 11 edits in trunk/Source/WebCore
[CSS Shaders] Remove the cache of validated programs
https://bugs.webkit.org/show_bug.cgi?id=112844
Reviewed by Dean Jackson.
Since we're caching CustomFilterProgram(s) now, we don't need another cache for
CustomFilterValidatedProgram(s). With this patch, CustomFilterProgram stores a reference
to a lazily created CustomFilterValidatedProgram, and CustomFilterGlobalContext no longer
has a validated program cache.
Also, this patch removes the CustomFilterValidatedProgram's stored reference to
CustomFilterGlobalContext. The removal of the validated program cache would cause
this reference to become weak. Validated programs only needed to keep the global context
reference in order to create a CustomFilterCompiledProgram. In this patch, we create
CustomFilterCompiledProgram(s) in FECustomFilter instead of in CustomFilterValidatedProgram,
so validated programs don't need to store the global context reference anymore.
No new tests. Just Refactoring.
- platform/graphics/filters/CustomFilterCompiledProgram.cpp:
(WebCore::CustomFilterCompiledProgram::CustomFilterCompiledProgram):
- platform/graphics/filters/CustomFilterGlobalContext.cpp:
(WebCore::CustomFilterGlobalContext::~CustomFilterGlobalContext):
- platform/graphics/filters/CustomFilterGlobalContext.h:
(CustomFilterGlobalContext):
- platform/graphics/filters/CustomFilterProgram.cpp:
(WebCore::CustomFilterProgram::validatedProgram):
(WebCore::CustomFilterProgram::setValidatedProgram):
- platform/graphics/filters/CustomFilterProgram.h:
- platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::CustomFilterValidatedProgram):
(WebCore::CustomFilterValidatedProgram::compiledProgram):
(WebCore::CustomFilterValidatedProgram::setCompiledProgram):
(WebCore::CustomFilterValidatedProgram::~CustomFilterValidatedProgram):
- platform/graphics/filters/CustomFilterValidatedProgram.h:
(CustomFilterValidatedProgram):
- platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::prepareForDrawing):
- rendering/FilterEffectRenderer.cpp:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::computeFilterOperations):
- 9:45 AM Changeset in webkit [148517] by
-
- 6 edits in branches/safari-536.30-branch/LayoutTests
Update from testrunner to layoutTestController.
- 9:16 AM Changeset in webkit [148516] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] LayerTexture: check if the graphics context is NULL
https://bugs.webkit.org/show_bug.cgi?id=114674
Patch by Anthony Scian <ascian@blackberry.com> on 2013-04-16
Reviewed by Rob Buis.
Internal PR: 256522
- platform/graphics/blackberry/LayerTexture.cpp:
(WebCore::LayerTexture::setContentsToColor):
- 9:07 AM Changeset in webkit [148515] by
-
- 2 edits in branches/safari-536.30-branch/Source/WebCore
Merged r147938. <rdar://problem/13600559>
- 8:34 AM Changeset in webkit [148514] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][WK2] Add an API for getting context menu item's parent menu
https://bugs.webkit.org/show_bug.cgi?id=107510
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-04-16
Reviewed by Kenneth Rohde Christiansen.
Added parent menu support and API for Ewk_Context_Menu_Item, to
allow selecting context menus using Elementary widgets.
Context menu unit test updated with new function.
- UIProcess/API/efl/ewk_context_menu.cpp:
(EwkContextMenu::EwkContextMenu):
- UIProcess/API/efl/ewk_context_menu_item.cpp:
(EwkContextMenuItem::EwkContextMenuItem):
(ewk_context_menu_item_parent_menu_get):
- UIProcess/API/efl/ewk_context_menu_item.h:
- UIProcess/API/efl/ewk_context_menu_item_private.h:
(EwkContextMenuItem::create):
(EwkContextMenuItem::parentMenu):
(EwkContextMenuItem::setParentMenu):
(EwkContextMenuItem):
- UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:
(showContextMenu):
- 8:33 AM Changeset in webkit [148513] by
-
- 3 edits in branches/safari-536.30-branch
Merged r148483. <rdar://problem/13659541>
- 8:07 AM Changeset in webkit [148512] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Accelerated animation regression with GL renderer
https://bugs.webkit.org/show_bug.cgi?id=114685
Reviewed by Rob Buis.
Internally reviewed by Filip Spacek.
GL renderer changed the assumption made in accelerated animation
code that rendering the contents of AC layer tiles would be the
slow operation. By starting animations after the slow operation,
the appearance of the animation could be made smooth.
Rendering tiles may still be slow, but now something else can be
slow too: drawing display lists to backing. And it's running on
the compositing thread, can happen at any time and will interrupt
accelerated animations.
Improved the situation by calling an API for updating backing to
schedule the delay at a convenient time. We try to update backing
before starting animations. However, future backing updates can
still interrupt the running animation and cause dropped frames.
Further improvements to animation smoothness will probably require
optimizations in the GL renderer.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayer):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
- Api/WebPage_p.h:
(WebPagePrivate):
- WebKitSupport/FrameLayers.cpp:
(BlackBerry::WebKit::FrameLayers::notifyAnimationsStarted):
(WebKit):
- WebKitSupport/FrameLayers.h:
(FrameLayers):
- 5:59 AM Changeset in webkit [148511] by
-
- 2 edits in trunk/Source/WebKit/efl
REGRESSION (r148506): Use of deprecated libsoup API
https://bugs.webkit.org/show_bug.cgi?id=114679
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-16
Reviewed by Gyuyoung Kim.
Remove deprecated libsoup API usage.
- ewk/ewk_network.cpp:
(ewk_network_proxy_uri_set):
(ewk_network_proxy_uri_get):
- 5:14 AM Changeset in webkit [148510] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0
Unreviewed. Update NEWS and Versions.m4 for 2.0.1 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 2.0.1.
- 4:46 AM Changeset in webkit [148509] by
-
- 2 edits in trunk/Source/WebKit2
Fix release builds with !LOG_DISABLED.
- Platform/mac/Logging.mac.mm:
- 3:05 AM Changeset in webkit [148508] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r148128): window.resizeTo doesn't work from Safari address bar.
<rdar://problem/13635894>
<http://webkit.org/b/114561>
Reviewed by Sam Weinig.
Suppressing window geometry changes while any user gesture is active was a bit too restrictive,
and broke legitimate use-cases. Narrow it down to checking EventHandler::mousePressed().
No test yet, adding one is tracked by <http://webkit.org/b/114561>.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::allowedToChangeWindowGeometry):
Added to share code between all DOMWindow functions that alter window geometry.
(WebCore::DOMWindow::moveBy):
(WebCore::DOMWindow::moveTo):
(WebCore::DOMWindow::resizeBy):
(WebCore::DOMWindow::resizeTo):
- 2:40 AM Changeset in webkit [148507] by
-
- 17 edits in trunk/Source
[GTK][EFL] Remove deprecated libsoup API usage
https://bugs.webkit.org/show_bug.cgi?id=104894
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-16
Reviewed by Philippe Normand.
Source/WebCore:
Based on a patch by Claudio Saavedra <Claudio Saavedra>.
Remove LIBSOUP_USE_UNSTABLE_REQUEST_API and only include
libsoup/soup.h.
- platform/network/ResourceHandleInternal.h:
- platform/network/soup/GOwnPtrSoup.cpp:
- platform/network/soup/ProxyResolverSoup.h:
- platform/network/soup/ResourceErrorSoup.cpp:
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ensureSessionIsInitialized): No need to add the requester
feature.
(WebCore::createSoupRequestAndMessageForHandle): SoupSession has a
requester API, use it.
Source/WebKit/efl:
Remove LIBSOUP_USE_UNSTABLE_REQUEST_API and only include
libsoup/soup.h.
Source/WebKit2:
Remove LIBSOUP_USE_UNSTABLE_REQUEST_API and only include
libsoup/soup.h.
- WebProcess/Cookies/soup/WebKitSoupCookieJarSqlite.h:
- WebProcess/efl/WebProcessMainEfl.cpp:
- WebProcess/gtk/WebProcessMainGtk.cpp:
- WebProcess/soup/WebKitSoupRequestGeneric.h:
- WebProcess/soup/WebProcessSoup.cpp:
- WebProcess/soup/WebSoupRequestManager.cpp:
(WebKit::WebSoupRequestManager::registerURIScheme): Remove requester and
use method soup_session_add_feature_by_type().
- 2:35 AM Changeset in webkit [148506] by
-
- 4 edits1 delete in trunk
[EFL] Bump libsoup dependency to 2.42.0
https://bugs.webkit.org/show_bug.cgi?id=113927
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-16
Reviewed by Gyuyoung Kim.
Update libsoup required version to v2.42.0 and GLib to v2.36.0 as
required by libsoup for EFL port.
.:
- Source/cmake/OptionsEfl.cmake:
Tools:
- efl/jhbuild.modules:
- efl/patches/libsoup-2.40-auth-fix.patch: Removed as it's already
included in v2.42.0.
- 2:29 AM Changeset in webkit [148505] by
-
- 10 edits in trunk/Source/WebCore
Remove more traces of the now-obsolete support for V8
https://bugs.webkit.org/show_bug.cgi?id=114657
Reviewed by Ryosuke Niwa.
In addition to passing existing tests, I verified that the ElementFactory
and ElementWrapperFactory files were all textually identical before and after.
- dom/CustomEvent.cpp:
(WebCore): Remove Use(V8) bock.
- dom/CustomEvent.h:
(CustomEvent): ditto
- dom/MessageEvent.cpp:
(WebCore::MessageEvent::MessageEvent): ditto
(WebCore::MessageEvent::initMessageEvent): ditto
- dom/Node.h:
(Node): ditto
- dom/make_event_factory.pl:
(generateImplementation): Remove V8 support.
- dom/make_names.pl: Remove gobs of V8 support and simplify.
(printJSElementIncludes):
(printConditionalElementIncludes):
(printFactoryCppFile):
(printWrapperFunctions):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):
- inspector/InjectedScriptCanvasModuleSource.js: Remove V8 stack
trace code.
- platform/qt/PlatformSupport.h: Remove a macro only used for V8
bindings.
- svg/SVGZoomAndPan.h:
(SVGZoomAndPan): Remove mention of V8 from comment.
- 2:26 AM Changeset in webkit [148504] by
-
- 7 edits in trunk/Tools
Remove Account class from committers.py
https://bugs.webkit.org/show_bug.cgi?id=114671
Reviewed by Csaba Osztrogonác.
Account class was added to support watch list email addresses that are not associated with
a particular contributor but nobody uses these email address since Chromium port forked.
Remove it.
Also removed account_by_login from CommitterList since it was never called except its unittests.
- Scripts/webkitpy/common/checkout/changelog.py:
- Scripts/webkitpy/common/config/committers.py:
(Contributor):
(Contributor.matches_glob):
(Reviewer.init):
(CommitterList.init):
(CommitterList._email_to_account_map):
(CommitterList._login_to_account_map):
(CommitterList.contributors_by_fuzzy_match):
(CommitterList.contributor_by_email):
(CommitterList.contributor_by_name):
(CommitterList.committer_by_email):
(CommitterList.reviewer_by_email):
- Scripts/webkitpy/common/config/committers_unittest.py:
(CommittersTest.test_committer_lookup):
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla._commit_queue_flag):
- Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
(test_commit_queue_flag):
- Scripts/webkitpy/common/watchlist/watchlistparser.py:
(WatchListParser._validate):
- 1:51 AM Changeset in webkit [148503] by
-
- 3 edits in trunk/Tools
Unreviewed update to the watchlist.
Removing 'mkwst+watchlist@chromium.org' from committers.py and the
watchist file; moving to 'mkwst@chromium.org' instead.
- Scripts/webkitpy/common/config/committers.py:
- Scripts/webkitpy/common/config/watchlist:
- 1:36 AM Changeset in webkit [148502] by
-
- 55 edits1 move in trunk/Tools
Move webkitpy.layout_tests.port to webkitpy.port
https://bugs.webkit.org/show_bug.cgi?id=114668
Reviewed by Maciej Stachowiak.
Moved. Port objects knows a lot more than just layout_tests. They doesn't belong down in layout_tests.
- Scripts/webkitpy/common/host.py:
- Scripts/webkitpy/common/host_mock.py:
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
- Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
- Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
- Scripts/webkitpy/layout_tests/lint_test_expectations.py:
- Scripts/webkitpy/layout_tests/port: Removed.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
- Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
- Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
- Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
- Scripts/webkitpy/performance_tests/perftest.py:
- Scripts/webkitpy/performance_tests/perftest_unittest.py:
- Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
- Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
- Scripts/webkitpy/port: Copied from Tools/Scripts/webkitpy/layout_tests/port.
- Scripts/webkitpy/port/apple.py:
- Scripts/webkitpy/port/base.py:
- Scripts/webkitpy/port/base_unittest.py:
- Scripts/webkitpy/port/config_unittest.py:
(ConfigTest.test_default_configurationstandalone):
- Scripts/webkitpy/port/driver_unittest.py:
- Scripts/webkitpy/port/efl.py:
- Scripts/webkitpy/port/efl_unittest.py:
- Scripts/webkitpy/port/factory.py:
- Scripts/webkitpy/port/factory_unittest.py:
- Scripts/webkitpy/port/gtk.py:
- Scripts/webkitpy/port/gtk_unittest.py:
- Scripts/webkitpy/port/image_diff.py:
- Scripts/webkitpy/port/image_diff_unittest.py:
- Scripts/webkitpy/port/leakdetector_unittest.py:
- Scripts/webkitpy/port/mac.py:
- Scripts/webkitpy/port/mac_unittest.py:
- Scripts/webkitpy/port/mock_drt.py:
- Scripts/webkitpy/port/mock_drt_unittest.py:
- Scripts/webkitpy/port/port_testcase.py:
- Scripts/webkitpy/port/qt.py:
- Scripts/webkitpy/port/qt_unittest.py:
- Scripts/webkitpy/port/server_process_unittest.py:
- Scripts/webkitpy/port/test.py:
- Scripts/webkitpy/port/win.py:
- Scripts/webkitpy/port/win_unittest.py:
- Scripts/webkitpy/port/xvfbdriver.py:
- Scripts/webkitpy/port/xvfbdriver_unittest.py:
- Scripts/webkitpy/tool/bot/botinfo_unittest.py:
- Scripts/webkitpy/tool/commands/gardenomatic.py:
- Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
- Scripts/webkitpy/tool/commands/queries.py:
- Scripts/webkitpy/tool/commands/queries_unittest.py:
- Scripts/webkitpy/tool/commands/rebaseline.py:
- Scripts/webkitpy/tool/servers/gardeningserver.py:
- Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
- Scripts/webkitpy/tool/servers/rebaselineserver.py:
- Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
- 1:25 AM Changeset in webkit [148501] by
-
- 4 edits1 delete in trunk/Tools
Unreviewed, rolling out r148498.
http://trac.webkit.org/changeset/148498
https://bugs.webkit.org/show_bug.cgi?id=114669
Appears to have broken EWS (Requested by rniwa on #webkit).
- Scripts/webkitpy/common/config/ews.json: Removed.
- Scripts/webkitpy/tool/commands/init.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem):
(AbstractEarlyWarningSystem.init):
(AbstractEarlyWarningSystem.handle_script_error.does):
(GtkEWS):
(GtkWK2EWS):
(EflEWS):
(QtEWS):
(QtWK2EWS):
(WinEWS):
(MacEWS):
(MacWK2EWS):
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSystemTest._default_expected_logs):
(_test_ews):
(test_ewses):
- 1:15 AM Changeset in webkit [148500] by
-
- 3 edits in trunk/LayoutTests
Web Inspector: [Network] Cover the type of preflight xhr.
https://bugs.webkit.org/show_bug.cgi?id=113471.
Patch by Pan Deng <pan.deng@intel.com> on 2013-04-16
Reviewed by Vsevolod Vlasov.
Add the Network resource type test to make sure the xhr-preflight is "xhr".
- http/tests/inspector/network-preflight-options-expected.txt:
- http/tests/inspector/network-preflight-options.html:
- 12:55 AM Changeset in webkit [148499] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- 12:43 AM Changeset in webkit [148498] by
-
- 4 edits1 add in trunk/Tools
Isolate Early Warning System definitions into a JSON
https://bugs.webkit.org/show_bug.cgi?id=114558
Reviewed by Benjamin Poulain.
Added ews.json to common/config, and made tool/commands/init.py call
AbstractEarlyWarningSystem.load_ews_classes to instantiate classes based on ews.json.
- Scripts/webkitpy/common/config/ews.json: Extracted from earlywarningsystem.py.
- Scripts/webkitpy/tool/commands/init.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem):
(AbstractEarlyWarningSystem.init):
(AbstractEarlyWarningSystem.load_ews_classes): Added. Loads ews.json.
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSystemTest._default_expected_logs):
(_test_ews):
(test_ewses):
- 12:36 AM Changeset in webkit [148497] by
-
- 2 edits in trunk/Source/WebCore
Potential use after free in ApplyStyleCommand::splitAncestorsWithUnicodeBidi
https://bugs.webkit.org/show_bug.cgi?id=114664
Reviewed by Oliver Hunt.
Use RefPtr as needed.
No new tests since this bug was discovered by code inspection.
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
- 12:04 AM Changeset in webkit [148496] by
-
- 3 edits2 adds in branches/safari-536.30-branch
Merged r142631.
Source/WebCore:
2013-02-12 Dominic Mazzoni <dmazzoni@google.com>
ASSERTION FAILED: i < size(), UNKNOWN in WebCore::AccessibilityMenuListPopup::didUpdateActiveOption
https://bugs.webkit.org/show_bug.cgi?id=109452
Reviewed by Chris Fleizach.
Send the accessibility childrenChanged notification in
HTMLSelectElement::setRecalcListItems instead of in childrenChanged
so that all possible codepaths are caught.
Test: accessibility/insert-selected-option-into-select-causes-crash.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childrenChanged):
(WebCore::HTMLSelectElement::setRecalcListItems):
LayoutTests:
Updated the test to account for the lack of accessibleElementById.
2013-02-12 Dominic Mazzoni <dmazzoni@google.com>
ASSERTION FAILED: i < size(), UNKNOWN in WebCore::AccessibilityMenuListPopup::didUpdateActiveOption
https://bugs.webkit.org/show_bug.cgi?id=109452
Reviewed by Chris Fleizach.
Add test to ensure a crash doesn't happen if a selected option
is added to a select element, which was triggering a code path where
the DOM has added a new child of the select but the accessibility
object never got updated.
- accessibility/insert-selected-option-into-select-causes-crash-expected.txt: Added.
- accessibility/insert-selected-option-into-select-causes-crash.html: Added.
Apr 15, 2013:
- 11:12 PM Changeset in webkit [148495] by
-
- 7 edits in trunk
Web Inspector: Make var and function declarations work again in the Console.
https://webkit.org/b/114534
rdar://problem/13614477
Reviewed by Oliver Hunt.
Source/WebCore:
- inspector/InjectedScriptSource.js:
(InjectedScript.prototype._evaluateOn): Use 'with' when not evaluating
on a call frame.
LayoutTests:
- inspector/console/command-line-api-expected.txt:
- inspector/console/console-eval-syntax-error-expected.txt:
- inspector/extensions/extensions-eval-expected.txt:
- platform/mac/http/tests/inspector/console-resource-errors-expected.txt:
Updated test results.
- 10:56 PM Changeset in webkit [148494] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Add missing Localized strings
https://bugs.webkit.org/show_bug.cgi?id=114656
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-15
Reviewed by Timothy Hatcher.
No tests because no behavior change is expected.
- English.lproj/localizedStrings.js:
- 10:31 PM Changeset in webkit [148493] by
-
- 3 edits2 adds in branches/safari-536.30-branch
Merged r139444.
Source/WebCore:
2013-01-11 Stephen Chenney <schenney@chromium.org>
Objects can be re-added to the AXObjectCache during removal
https://bugs.webkit.org/show_bug.cgi?id=104171
The problem occurs when a label's corresponding element is a sibling
that precedes it in the render tree, and the corresponding element is
removed. The corresponding element's AX render object is removed, but
then recreated when accessibilityIsIgnored() invokes correspondingControl()
on the label. The corresponding renderer then has an AX render object
that survives beyond the deleted renderer, leading to invalid memory
accesses.
The solution is to rearrange the calls to delete the renderer's AX
render object only when we are sure it will no longer be required.
Reviewed by Simon Fraser.
Test: accessibility/corresponding-control-deleted-crash.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed): Move the call to remove the
renderer from the AXCache to after the renderer is removed from the
render tree. This means that the AXObject still exists during renderer
removal, as we require.
LayoutTests:
Checked in a failing expected result for corresponding-control-deleted-crash.html,
since the test requires author shadow DOM to be enabled.
2013-01-11 Stephen Chenney <schenney@chromium.org>
Objects can be re-added to the AXObjectCache during removal
https://bugs.webkit.org/show_bug.cgi?id=104171
Reviewed by Simon Fraser.
New test which asserts with !m_hasAXObject in RenderObject::~RenderObject without the patch. Requires Shadow DOM enabled.
- accessibility/corresponding-control-deleted-crash-expected.txt: Added.
- accessibility/corresponding-control-deleted-crash.html: Added.
- 10:09 PM Changeset in webkit [148492] by
-
- 4 edits2 adds in branches/safari-536.30-branch
Merged r131670.
2012-10-17 Tom Sepez <tsepez@chromium.org>
Crash in ContainerNode::removeAllChildren()
https://bugs.webkit.org/show_bug.cgi?id=98443
Reviewed by Eric Carlson.
Source/WebCore:
This patch makes the errorEventSender added in WebKit Revision 112190 interact
with the updatedHasPendingLoadEvent() mechanism in the same manner as the other
existing event senders.
Test: http/tests/security/video-poster-cross-origin-crash2.html
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::setImage):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::updatedHasPendingEvent):
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
(WebCore::ImageLoader::dispatchPendingLoadEvent):
- loader/ImageLoader.h:
(ImageLoader):
LayoutTests:
- http/tests/security/video-poster-cross-origin-crash2-expected.txt: Added.
- http/tests/security/video-poster-cross-origin-crash2.html: Added.
- 9:37 PM Changeset in webkit [148491] by
-
- 5 edits in branches/safari-536.30-branch
Merged r142063.
2013-02-06 Tom Sepez <tsepez@chromium.org>
document.referrer leakage with XSS Auditor page block
https://bugs.webkit.org/show_bug.cgi?id=109089
Reviewed by Adam Barth.
Source/WebCore:
Pass "about:blank" as referrer instead of "" so that the actual page
is not leaked when empty referrers are replaced later on in the
request.
- html/parser/XSSAuditorDelegate.cpp:
(WebCore::XSSAuditorDelegate::didBlockScript):
LayoutTests:
Test prints the referrer to show it isn't leaked.
- http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
- http/tests/security/xssAuditor/full-block-script-tag.html:
- 8:41 PM Changeset in webkit [148490] by
-
- 3 edits in trunk/Source/WTF
Unreviewed, rolling out r148488.
http://trac.webkit.org/changeset/148488
https://bugs.webkit.org/show_bug.cgi?id=114660
Roll back in r148462 since it was a false positive. (Requested
by rniwa on #webkit).
- wtf/FastMalloc.cpp:
(WTF):
(WTF::setThreadHeap):
(WTF::TCMalloc_ThreadCache::GetThreadHeap):
(WTF::TCMalloc_ThreadCache::InitTSD):
- wtf/ThreadSpecificWin.cpp:
(WTF::destructorsList):
(WTF::destructorsMutex):
(WTF::threadSpecificKeyCreate):
(WTF::threadSpecificKeyDelete):
- 8:37 PM Changeset in webkit [148489] by
-
- 3 edits in trunk/Source/JavaScriptCore
Windows clean build fix after r148479.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 7:55 PM Changeset in webkit [148488] by
-
- 3 edits in trunk/Source/WTF
Unreviewed, rolling out r148462.
http://trac.webkit.org/changeset/148462
https://bugs.webkit.org/show_bug.cgi?id=114658
Broke Windows builds (Requested by rniwa on #webkit).
- wtf/FastMalloc.cpp:
(WTF):
(WTF::setThreadHeap):
(WTF::TCMalloc_ThreadCache::GetThreadHeap):
(WTF::TCMalloc_ThreadCache::InitTSD):
- wtf/ThreadSpecificWin.cpp:
(WTF::destructorsList):
(WTF::destructorsMutex):
(WTF::threadSpecificKeyCreate):
(WTF::threadSpecificKeyDelete):
- 7:52 PM Changeset in webkit [148487] by
-
- 6 edits in trunk/Source/WebCore
Rename restartedPlugin to isRestartedPlugin. This was
review feedback from r148038 that I thought I fixed
everywhere but failed.
https://bugs.webkit.org/show_bug.cgi?id=114233
- html/HTMLPlugInElement.h:
(WebCore::HTMLPlugInElement::isRestartedPlugin): Prefix with "is".
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::setDisplayState):
(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired):
- html/HTMLPlugInImageElement.h:
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintContents):
- rendering/RenderLayerBacking.cpp:
(WebCore::isRestartedPlugin):
- 7:15 PM Changeset in webkit [148486] by
-
- 3 edits in trunk/Source/WebCore
Remove V8 attribtues from IDLAttributes.txt
https://bugs.webkit.org/show_bug.cgi?id=114651
Reviewed by Sam Weinig.
No tests because no behavior change is expected.
- bindings/scripts/IDLAttributes.txt: Remove V8 attribtues.
- html/track/TextTrackList.idl: Remove a stray V8-specific attribute
(so I guess this change is not useless)
- 6:38 PM Changeset in webkit [148485] by
-
- 27 edits2 adds in branches/safari-536.30-branch
Merged r139111.
2013-01-08 Tom Sepez <tsepez@chromium.org>
Copy-paste preserves <embed> tags containing active content.
https://bugs.webkit.org/show_bug.cgi?id=77625
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: editing/pasteboard/paste-noplugin.html
- dom/FragmentScriptingPermission.h:
(WebCore::scriptingContentIsAllowed):
(WebCore::pluginContentIsAllowed):
Add new permission to restrict plugin pasting. Add inline functions to check
the implications of each permission rather than having a list of raw comparisions
sprinkled throughout the code.
- editing/markup.cpp:
(WebCore::createFragmentFromMarkup):
Revert back to unsafe plugin pasting regardless of caller's intentions when
the settings allow it.
- dom/Element.cpp:
(WebCore::Element::parserSetAttributes):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertScriptElement):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::endElementNs):
- xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parseEndElement):
Use new inline functions to check implications of permissions rather than raw
comparisions.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
Check if plugin pasting is allowed before inserting applet/embed/oject elements.
- page/Settings.in:
Declaration of new unsafePluginPastingEnabled setting.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::documentFragment):
- platform/blackberry/PasteboardBlackBerry.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asFragment):
- platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/qt/DragDataQt.cpp:
(WebCore::DragData::asFragment):
- platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::documentFragment):
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::fragmentFromCFHTML):
(WebCore::fragmentFromHTML):
- platform/wx/PasteboardWx.cpp:
(WebCore::Pasteboard::documentFragment):
Pass DisallowScriptingAndPluginContent enum value.
Source/WebKit/chromium:
Adds chromium API to new unsafePluginPastingEnabled setting.
- public/WebSettings.h:
- src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setUnsafePluginPastingEnabled):
(WebKit):
- src/WebSettingsImpl.h:
(WebSettingsImpl):
LayoutTests:
- editing/pasteboard/paste-noplugin-expected.txt: Added.
- editing/pasteboard/paste-noplugin.html: Added.
- 6:34 PM Changeset in webkit [148484] by
-
- 6 edits in trunk
WebKit should not expose AXSubrole:AXDescriptionList on Mountain Lion as it causes a regression in VoiceOver behavior
https://bugs.webkit.org/show_bug.cgi?id=113975
Patch by James Craig <james@cookiecrook.com> on 2013-04-15
Reviewed by Chris Fleizach.
Serve NSAccessibilityDescriptionListSubrole or NSAccessibilityDefinitionListSubrole
depending on platform. Updated existing test coverage.
Source/WebCore:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper subrole]):
LayoutTests:
- platform/mac/accessibility/lists-expected.txt:
- platform/mac/accessibility/role-subrole-roledescription-expected.txt:
- platform/mac/accessibility/role-subrole-roledescription.html:
- 6:20 PM Changeset in webkit [148483] by
-
- 3 edits3 moves in trunk
Source/WebKit/mac: plugins/get-url-beforeunload-destroys-plugin.html crashes in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=114653
<rdar://problem/13659541>
Reviewed by Sam Weinig.
Protect the NetscapePluginInstanceProxy since it can otherwise go away.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::performRequest):
LayoutTests: plugins/get-url-beforeunload-destroys-plugin.html crashes in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=114653
Reviewed by Sam Weinig.
Move this test back now that it passes in WK1.
- http/tests/plugins/get-url-beforeunload-destroys-plugin-expected.txt: Renamed from LayoutTests/platform/mac-wk2/http/tests/plugins/get-url-beforeunload-destroys-plugin-expected.txt.
- http/tests/plugins/get-url-beforeunload-destroys-plugin.html: Renamed from LayoutTests/platform/mac-wk2/http/tests/plugins/get-url-beforeunload-destroys-plugin.html.
- http/tests/plugins/resources/notify-done.html: Renamed from LayoutTests/platform/mac-wk2/http/tests/plugins/resources/notify-done.html.
- 6:05 PM Changeset in webkit [148482] by
-
- 9 edits in trunk/Source
Plugins that resize might need to be snapshotted.
https://bugs.webkit.org/show_bug.cgi?id=102157
<rdar://problem/12696259>
Reviewed by Tim Horton.
Source/WebCore:
A plugin could avoid snapshotting if it started very
small (below the threshold where we autostart), and then
resized to be large (above the threshold). Detect this
case and tell the plugin to snapshot.
There unfortunately is a bit of state to track when doing
this. We have to start the snapshotting in a post-layout
task, so we carry a flag to say we're checking size but
not wanting the plugin to update (which would restart it).
We also might be a plugin that would have already restarted
due to a similar plugin being clicked or detected as dominant.
So this patch introduces a member variable that tracks what
decision has been made on snapshotting.
I also added some more logging to be more clear about what is
happening to plugins going through the snapshot process, and
changed the order of the tests in the algorithm so that domain
detection comes before examining the size.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Initialise
the two new member variables.
(WebCore::HTMLPlugInImageElement::setDisplayState): Mark a restarted
plugin as NeverSnapshot. This means that if it later resizes above the
threshold, it won't trigger the snapshot detection.
(WebCore::HTMLPlugInImageElement::checkSnapshotStatus): Renamed from
updateSnapshotInfo. This now updates the snapshot, but also runs
the check for size changes.
(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin): Gather all plugins
that look like a restarting plugin, not just those snapshotted. That
way they can all be marked as NeverSnapshot.
(WebCore::HTMLPlugInImageElement::restartSimilarPlugIns): Bless every
plugin that looks similar, whether or not it is snapshotted.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): More logging.
(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Ditto.
(WebCore::HTMLPlugInImageElement::checkSizeChangeForSnapshotting): New
method. If the plugin was below the threshold and is now above it,
begin the snapshotting process.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Plugins
that were marked as NeverSnapshot should start immediately. Move the origin
test earlier in the method. If a plugin avoided snapshotting due to size,
remember the size.
(WebCore::HTMLPlugInImageElement::subframeLoaderDidCreatePlugIn): Mark the
plugin as NeverSnapshot.
- html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): Four new member variables:
- the decision we made regarding snapshotting (or not), uses the SnapshotDecision enum
- the size when it avoided snapshotting
- a flag to indicate the post layout update was triggered due to a size change
(WebCore::HTMLPlugInImageElement::needsCheckForSizeChange): New method.
(WebCore::HTMLPlugInImageElement::setNeedsCheckForSizeChange): New method.
(WebCore::HTMLPlugInImageElement::snapshotDecision): Return the decision
regarding snapshotting or not snapshotting.
- page/FrameView.cpp:
(WebCore::FrameView::addWidgetToUpdate): Guard updating the widget. We don't
want to do it when we're checking for a size change in the plugin.
(WebCore::FrameView::updateWidget): Call new name.
- plugins/PluginViewBase.h:
(WebCore::PluginViewBase::beginSnapshottingRunningPlugin): Empty virtual
method to snapshot a running plugin.
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::layout): If the plugin has increased in
size add it to the post layout list so that it will be checked.
Source/WebKit2:
Allow a running plugin to be snapshotted. All this
means is that we start the snapshot timer again.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::beginSnapshottingRunningPlugin): Restart
the timer.
- WebProcess/Plugins/PluginView.h: Virtual method declaration.
- 6:01 PM Changeset in webkit [148481] by
-
- 3 edits2 adds in trunk
activating a focused link to an in-page fragment ID should transfer focus to the target of the link when possible
https://bugs.webkit.org/show_bug.cgi?id=17450
Reviewed by Maciej Stachowiak.
Source/WebCore:
When a fragment is scrolled to due to an activation event or on load, focus should attempt to
move to the fragment if possible.
Test: fast/dom/fragment-activation-focuses-target.html
- page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
LayoutTests:
- fast/dom/fragment-activation-focuses-target.html: Added.
- 5:30 PM Changeset in webkit [148480] by
-
- 21 edits in trunk/Source/WebCore
Remove V8-specific extended attributes from IDL files
https://bugs.webkit.org/show_bug.cgi?id=114523
Reviewed by Geoffrey Garen.
No tests because no behavior change is expected.
- Modules/encryptedmedia/MediaKeyMessageEvent.idl:
- Modules/encryptedmedia/MediaKeyNeededEvent.idl:
- Modules/encryptedmedia/MediaKeySession.idl:
- Modules/encryptedmedia/MediaKeys.idl:
- Modules/filesystem/HTMLInputElementFileSystem.idl:
- Modules/indexeddb/IDBAny.idl:
- Modules/mediasource/MediaSource.idl:
- Modules/mediasource/SourceBuffer.idl:
- Modules/mediasource/SourceBufferList.idl:
- Modules/mediastream/MediaStream.idl:
- Modules/webaudio/AudioDestinationNode.idl:
- html/track/TextTrackCue.idl:
- html/track/TextTrackCueList.idl:
- html/track/TextTrackList.idl:
- html/track/TextTrackRegion.idl:
- html/track/TextTrackRegionList.idl:
- html/track/TrackEvent.idl:
- storage/Storage.idl:
- svg/SVGDocument.idl:
- svg/SVGElement.idl:
- workers/WorkerContext.idl:
- xml/XMLHttpRequest.idl:
- xml/XPathNSResolver.idl:
- 5:22 PM Changeset in webkit [148479] by
-
- 25 edits1 copy in trunk/Source
ScriptWrappable subclasses shouldn't have to include WeakInlines.h
https://bugs.webkit.org/show_bug.cgi?id=114641
Reviewed by Alexey Proskuryakov.
Source/JavaScriptCore:
Move back the Weak constructor, destructor and clear() to Weak.h. Add a new weakClearSlowCase function
and put it in Weak.cpp.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- heap/Weak.cpp: Added.
- heap/Weak.h:
- heap/WeakInlines.h:
- heap/WeakSetInlines.h:
Source/WebCore:
Remove ScriptWrappableInlines.h includes, they're not needed anymore.
- css/WebKitCSSMatrix.cpp:
- dom/ClientRect.cpp:
- dom/ClientRectList.cpp:
- dom/Clipboard.cpp:
- dom/DOMStringMap.cpp:
- dom/Event.cpp:
- dom/MutationRecord.cpp:
- fileapi/FileList.cpp:
- page/BarInfo.cpp:
- plugins/DOMMimeTypeArray.cpp:
- plugins/DOMPlugin.cpp:
- plugins/DOMPluginArray.cpp:
- storage/Storage.cpp:
- 5:10 PM Changeset in webkit [148478] by
-
- 2 edits in branches/safari-536.30-branch/Source/JavaScriptCore
Build fix for Windows.
<rdar://problem/13438603>
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- 4:46 PM Changeset in webkit [148477] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] build fix after r148434
https://bugs.webkit.org/show_bug.cgi?id=114647
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-15
Reviewed by Benjamin Poulain.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::showContextMenu):
- 4:26 PM Changeset in webkit [148476] by
-
- 3 edits in branches/safari-536.30-branch/Source/WebCore
Build fix for r148472.
- 4:17 PM Changeset in webkit [148475] by
-
- 15 edits in trunk/Source/JavaScriptCore
HeapTimer lifetime should be less complicated
https://bugs.webkit.org/show_bug.cgi?id=114529
Reviewed by Oliver Hunt.
Right now our HeapTimer lifetime is rather complicated. HeapTimers are "owned" by the JSGlobalData,
but there's an issue in that there can be races between a thread that is trying to tear down a JSGlobalData
and the HeapTimer's fire function. Our current code for tearing down HeapTimers is an intricate and delicate
dance which probably contains subtle bugs.
We can make our lives easier by changing things around a bit.
1) We should free the API lock from being solely owned by the JSGlobalData so we don't have to worry about
grabbing the lock out of invalid memory when our HeapTimer callback fires.
2) We should also make it so that we deref the JSGlobalData first, then unlock the API lock so that when we
have the lock, the JSGlobalData is in one of two states: fully valid or completely destroyed, and we know exactly which one.
3) The JSLock can tell us this information by keeping a back pointer to the JSGlobalData. When the JSGlobalData's
destructor is called, it clears this pointer in the JSLock. Other clients of the API lock can then check
this pointer to determine whether or not the JSGlobalData is still around.
4) The CFRunLoopTimer will use the API lock as its context rather than the HeapTimer itself. The only way
the HeapTimer's callback can get to the HeapTimer is through the API lock's JSGlobalData pointer.
5) The CFRunLoopTimerContext struct has two fields for retain and release callbacks for the context's info field.
We'll provide these callbacks to ref() and deref() the JSLock as necessary. Thus, the timer becomes the other
owner of the JSLock apart from the JSGlobalData.
- API/APIShims.h: Remove the cruft that was required by the previous design, such as RefGlobalDataTag.
(JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
(JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
(APIEntryShimWithoutLock):
(JSC::APIEntryShim::APIEntryShim):
(JSC::APIEntryShim::~APIEntryShim): Protect the API lock with a RefPtr, deref the JSGlobalData, which could destroy it,
then unlock the API lock. This ordering prevents others from obtaining the API lock while the JSGlobalData is in the
middle of being torn down.
(JSC::APIEntryShim::init): We now take the lock, then ref the JSGlobalData, which is the opposite order of when we
tear down the shim.
- heap/Heap.cpp:
(JSC::Heap::setActivityCallback): Use PassOwnPtr now.
(JSC::Heap::activityCallback): Ditto.
(JSC::Heap::sweeper): Ditto.
(JSC):
- heap/Heap.h:
(Heap):
- heap/HeapTimer.cpp:
(JSC::retainAPILock): Retain callback for CFRunLoopTimerContext struct.
(JSC::releaseAPILock): Release callback for the CFRunLoopTimerContext struct.
(JSC::HeapTimer::HeapTimer): Use the API lock as the context's info field rather than the HeapTimer.
(JSC::HeapTimer::timerDidFire): Grab the API lock. Return early if the JSGlobalData has already been destroyed.
Otherwise, figure out which kind of HeapTimer we are based on the CFRunLoopTimerRef passed to the callback and
call the HeapTimer's callback.
- heap/HeapTimer.h:
(HeapTimer):
- heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::create): PassOwnPtr all the things.
- heap/IncrementalSweeper.h:
(IncrementalSweeper):
- jsc.cpp:
(jscmain): We use an APIEntryShim instead of a RefPtr for the JSGlobalData because we need to
tear down the JSGlobalData while we still hold the lock, which the APIEntryShim handles correctly.
- runtime/GCActivityCallback.h:
(DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::create):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData): Notify the API lock that the JSGlobalData is being torn down.
- runtime/JSGlobalData.h:
(JSGlobalData):
(JSC::JSGlobalData::apiLock):
- runtime/JSLock.cpp:
(JSC::JSLockHolder::JSLockHolder): Ref, then lock (just like the API shim).
(JSC):
(JSC::JSLock::willDestroyGlobalData):
(JSC::JSLockHolder::init):
(JSC::JSLockHolder::~JSLockHolder): Protect, deref, then unlock (just like the API shim).
(JSC::JSLock::JSLock):
- runtime/JSLock.h: Add back pointer to the JSGlobalData and a callback for when the JSGlobalData is being
torn down that clears this pointer to notify other clients (i.e. timer callbacks) that the JSGlobalData is no
longer valid.
(JSLockHolder):
(JSLock):
(JSC::JSLock::globalData):
- testRegExp.cpp:
(realMain): We use an APIEntryShim instead of a RefPtr for the JSGlobalData because we need to
tear down the JSGlobalData while we still hold the lock, which the APIEntryShim handles correctly.
- 4:04 PM Changeset in webkit [148474] by
-
- 14 edits1 add in trunk/Source
LLInt SH4 backend implementation
https://bugs.webkit.org/show_bug.cgi?id=112886
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-04-15
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
- dfg/DFGOperations.cpp:
(JSC):
- jit/JITStubs.cpp:
- llint/LLIntOfflineAsmConfig.h:
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- offlineasm/arm.rb:
- offlineasm/ast.rb:
- offlineasm/backends.rb:
- offlineasm/instructions.rb:
- offlineasm/mips.rb:
- offlineasm/risc.rb:
- offlineasm/sh4.rb: Added.
Source/WTF:
- wtf/Platform.h:
- 3:56 PM Changeset in webkit [148473] by
-
- 2 edits in branches/safari-536.30-branch/Source/JavaScriptCore
Merged r141029. <rdar://problem/13334878>
- 3:26 PM Changeset in webkit [148472] by
-
- 5 edits in branches/safari-536.30-branch/Source/WebCore
r138821, <rdar://problem/13334928>
- 3:19 PM Changeset in webkit [148471] by
-
- 2 edits in branches/safari-536.30-branch/Source/WebCore
Merged r138990.
2013-01-07 Tom Sepez <tsepez@chromium.org>
Document::initSecurityContext() gives parent security context to iframes with invalid URLs.
https://bugs.webkit.org/show_bug.cgi?id=104960
Reviewed by Adam Barth.
Change covers the case of an invalid non-empty URL. We know nothing
about that kind of URL and choose not to inherit origins.
- dom/Document.cpp:
(WebCore::shouldInheritSecurityOriginFromOwner):
- 3:07 PM Changeset in webkit [148470] by
-
- 5 edits2 copies in branches/safari-536.30-branch
Merge r143454. <rdar://problem/13334919>
- 2:42 PM Changeset in webkit [148469] by
-
- 4 edits2 copies in branches/safari-536.30-branch
Merge r143454. <rdar://problem/13334874>
- 2:25 PM Changeset in webkit [148468] by
-
- 2 edits in trunk/Source/WebCore
Call directly RenderBlock::deleteLineBoxTree
https://bugs.webkit.org/show_bug.cgi?id=102761
Reviewed by Darin Adler.
Instead of implementing RenderLineBoxList::deleteLineBoxTree logic inside
RenderBlock::determineStartPosition, we can reuse the code. The commentaries added
in the changeset #86628 are not valid anymore, nextRootBox is casting m_nextLineBox
and nextLineBox is returning m_nextLineBox.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::determineStartPosition):
- 2:19 PM Changeset in webkit [148467] by
-
- 4 edits in trunk/Source/WebCore
Remove files related to quota and proximity events from the Xcode project
https://bugs.webkit.org/show_bug.cgi?id=114635
Reviewed by Benjamin Poulain.
- WebCore.xcodeproj/project.pbxproj:
- history/PageCache.cpp:
- page/DOMWindow.cpp:
- 2:07 PM Changeset in webkit [148466] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Crash from null m_webSettings in WebPagePrivate
https://bugs.webkit.org/show_bug.cgi?id=114633
RIM PR 303745
Patch by Liam Quinn <lquinn@blackberry.com> on 2013-04-15
Reviewed by Rob Buis.
Internally reviewed by Leo Yang.
Speculative fix suggested by George Staikos--initialize m_webSettings first thing in the init() method.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
- 2:05 PM Changeset in webkit [148465] by
-
- 17 edits in branches/safari-536.30-branch
Merge r142759. <rdar://problem/13334873>
- 2:04 PM Changeset in webkit [148464] by
-
- 2 edits in trunk/Source/WebKit2
After switching to another space and back, video races to catch up with audio
https://bugs.webkit.org/show_bug.cgi?id=114634
Reviewed by Tim Horton.
In Mountain Lion and previous, report that a view is "not visible" when its window
is not in the active space. This causes us to notify AVFoundation that its CAImageQueues
will not be serviced and results in not having the "catch up" behavior when returning
to the browser's space.
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::isViewVisible):
- 1:32 PM Changeset in webkit [148463] by
-
- 17 edits in trunk
[CMake] Add WTF_USE_*_UNICODE variables
https://bugs.webkit.org/show_bug.cgi?id=114556
Reviewed by Brent Fulgham.
WTF_USE_ICU_UNICODE and WTF_USE_WCHAR_UNICODE are used to
reduce duplication in the platform specific CMake files.
.:
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsWinCE.cmake:
Source/JavaScriptCore:
- CMakeLists.txt:
- PlatformEfl.cmake:
Source/WebCore:
- CMakeLists.txt:
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
- PlatformWinCE.cmake:
Source/WTF:
- wtf/CMakeLists.txt:
- wtf/PlatformBlackBerry.cmake:
- wtf/PlatformEfl.cmake:
- wtf/PlatformWinCE.cmake:
- 1:23 PM Changeset in webkit [148462] by
-
- 3 edits in trunk/Source/WTF
[WIN] Remove remaining calls to pthread from WTF
https://bugs.webkit.org/show_bug.cgi?id=114563
Reviewed by Brent Fulgham.
Replace pthread_key_create with threadSpecificKeyCreate and
pthread_setspecific with threadSpecificSet from ThreadSpecific.h.
These functions provide a windows-specific implementation for the pthread functions,
but require that the thread has been created with WTF::createThread(),
which is the case for all threads created within WebKit.
To call this function from fastMalloc we must not call fastMalloc in them.
To fulfill this constraint ThreadSpecificWin will allocated its memory through the
original malloc implementation and use the stack for local and static variables.
Keep the Darwin implementation as it is, since it contains some performance tweaks.
- wtf/FastMalloc.cpp:
- wtf/ThreadSpecificWin.cpp:
(WTF::destructorsList):
(WTF::destructorsMutex):
(WTF::threadSpecificKeyCreate):
(WTF::threadSpecificKeyDelete):
- 1:13 PM Changeset in webkit [148461] by
-
- 2 edits in trunk/Tools
WKR gets stuck when there are many merges
https://bugs.webkit.org/show_bug.cgi?id=114632
Reviewed by Andreas Kling.
Move the last revision forward when it exists in a branch.
Otherwise, we'll be stuck looping over revisions made to merge patches.
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot.next_work_item):
- 1:09 PM Changeset in webkit [148460] by
-
- 4 edits in branches/safari-536.30-branch/Source/WebCore
Merge 133840, 134191, 134197, <rdar://problem/13334895>
- 1:05 PM Changeset in webkit [148459] by
-
- 9 edits in branches/safari-536.30-branch/Source/WebCore
Merged r140127. <rdar://problem/13334953>
- 12:46 PM Changeset in webkit [148458] by
-
- 2 edits in trunk/Source/WebCore
HTMLMediaElement::removeTextTrack should clear track client
https://bugs.webkit.org/show_bug.cgi?id=114630
Reviewed by Jer Noble.
No new tests, this is clean-up that prevents a potential crash.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::removeTextTrack): Clear the track client.
- 12:39 PM Changeset in webkit [148457] by
-
- 2 edits in branches/safari-536.30-branch/Source/WebCore
Merge r138213, <rdar://problem/13335063>
- 12:32 PM Changeset in webkit [148456] by
-
- 2 edits in trunk/Source/WebKit/win
Crash when favicon is requested
https://bugs.webkit.org/show_bug.cgi?id=114624
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-04-15
Reviewed by Brent Fulgham.
- WebIconDatabase.cpp:
(WebIconDatabase::getOrCreateDefaultIconBitmap): Added NULL pointer check.
- 12:04 PM Changeset in webkit [148455] by
-
- 7 edits1 delete in branches/safari-536.30-branch
Rollout r145643.
- 11:27 AM Changeset in webkit [148454] by
-
- 4 edits2 adds in branches/safari-536.30-branch
Merge r142816, <rdar://problem/13334866>
- 11:23 AM Changeset in webkit [148453] by
-
- 3 edits2 adds in trunk
An inline element with an absolutely positioned child does not correctly calculate/render padding and margin
https://bugs.webkit.org/show_bug.cgi?id=47554
Reviewed by David Hyatt.
Source/WebCore:
When looking for padding/margin to add from the start of a child's parent skip past any leading positioned siblings as
we don't add the padding/margin of the common parent when skipping past them in |skipLeadingWhitespace|. We
don't need to worry about the case of trailing positioned objects as we will account for their parent's
border/margin/padding when we encounter them in |nextSegmentBreak|.
Test: fast/inline/padding-before-leading-positioned-element-contributes-width.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::previousInFlowSibling):
(WebCore):
(WebCore::inlineLogicalWidth):
LayoutTests:
- fast/inline/padding-before-leading-positioned-element-contributes-width-expected.txt: Added.
- fast/inline/padding-before-leading-positioned-element-contributes-width.html: Added.
- 11:19 AM WebKitGTK/2.0.x edited by
- (diff)
- 11:16 AM Changeset in webkit [148452] by
-
- 1 edit1 add in trunk/LayoutTests
Flaky Test: http/tests/ssl/ping-with-unsafe-redirect.html
https://bugs.webkit.org/show_bug.cgi?id=114616
Land expected results for the test.
- http/tests/ssl/ping-with-unsafe-redirect-expected.txt: Added.
- 11:02 AM Changeset in webkit [148451] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Forward userGesture when creating a new window
https://bugs.webkit.org/show_bug.cgi?id=114622
Patch by Andy Chen <andchen@blackberry.com> on 2013-04-15
Reviewed by Rob Buis.
Client could use this info to decide whether the popup should
be blocked.
PR 291898
Reviewed internally by Mike Fenton
- Api/WebPageClient.h:
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
- 10:59 AM Changeset in webkit [148450] by
-
- 3 edits2 adds in branches/safari-536.30-branch
Merge r142922, <rdar://problem/13334860>
- 10:52 AM Changeset in webkit [148449] by
-
- 2 edits in trunk/Tools
[GTK] Missing a few packages for building on stock Fedora
https://bugs.webkit.org/show_bug.cgi?id=113916
Reviewed by Philippe Normand.
- gtk/install-dependencies: add packages that are missing.
- 10:46 AM Changeset in webkit [148448] by
-
- 3 edits2 adds in branches/safari-536.30-branch
Merged r138988, <rdar://problem/13334838>
- 10:13 AM Changeset in webkit [148447] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=114623
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-04-15
Reviewed by Brent Fulgham.
- platform/network/curl/CookieJarCurl.cpp: Added required header files.
- 10:09 AM Changeset in webkit [148446] by
-
- 2 edits in trunk/Tools
REGRESSION (r148360): Failure in webkitpy.tool.multicommandtool_unittest.MultiCommandToolTest.test_command_help
https://bugs.webkit.org/show_bug.cgi?id=114602
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/tool/multicommandtool_unittest.py:
(CommandTest.test_required_arguments): Reset the static argument_names variable on the TrivialCommand
interface so its value doesn't leak into the following tests.
- 10:06 AM Changeset in webkit [148445] by
-
- 2 edits in trunk
[GTK] REGRESSION(r147499): HTTP auth dialog doesn't remember passwords anymore
https://bugs.webkit.org/show_bug.cgi?id=114613
Reviewed by Carlos Garcia Campos.
- Source/autotools/SetupAutoconfHeader.m4: Correct definition of ENABLE_CREDENTIAL_STORAGE
so that the ENABLE(CREDENTIAL_STORAGE) macro work properly.
- 9:22 AM Changeset in webkit [148444] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- 9:07 AM Changeset in webkit [148443] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r148236.
- 8:52 AM Changeset in webkit [148442] by
-
- 2 edits in trunk/Source/WebCore
Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790
Patch by Rob Buis <rbuis@rim.com> on 2013-04-15
Reviewed by Darin Adler.
It does not seem needed to initialize jpeg_create_compress struct to zero,
all that is needed is set the err field. See for instance SkImageDecoder_libjpeg.cpp.
- platform/image-encoders/JPEGImageEncoder.cpp:
(WebCore::compressRGBABigEndianToJPEG):
- 8:39 AM Changeset in webkit [148441] by
-
- 3 edits in trunk/Tools
Deprecate land-cowboy in favor of land-cowhand
https://bugs.webkit.org/show_bug.cgi?id=104470
Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-04-15
Reviewed by Darin Adler.
Move the LandCowboy command implementation under the LandCowhand command and deprecate the former.
- Scripts/webkitpy/tool/commands/download.py:
(LandCowhand):
(LandCowboy):
(LandCowboy._prepare_state):
- Scripts/webkitpy/tool/commands/download_unittest.py:
(test_land_cowhand): Adjust the unit tests by testing both LandCowhand and LandCowboy,
also checking the deprecation message in the output of the latter.
- 8:28 AM Changeset in webkit [148440] by
-
- 3 edits1 delete in trunk/Source/WebCore
[GTK] Remove platform specific implementation of KURL::fileSystemPath()
https://bugs.webkit.org/show_bug.cgi?id=114133
Reviewed by Martin Robinson.
r147883 added a generic implementation of this function,
which can be used by all ports to share the code.
- GNUmakefile.list.am:
- platform/KURL.cpp:
(WebCore):
- platform/gtk/KURLGtk.cpp: Removed.
- 8:28 AM Changeset in webkit [148439] by
-
- 3 edits in trunk/Source/WebKit2
Schedule rendering at regular interval (60fps)
https://bugs.webkit.org/show_bug.cgi?id=114617
Patch by Seulgi Kim <seulgikim@company100.net> on 2013-04-15
Reviewed by Martin Robinson.
Schedule rendering reguarly regardless of the time taken to render a
frame. Otherwise, next flush delayed by the amount of the rendering
time.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::LayerTreeHostGtk):
(WebKit::LayerTreeHostGtk::layerFlushTimerFired):
(WebKit::LayerTreeHostGtk::flushAndRenderLayers):
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
- 8:25 AM Changeset in webkit [148438] by
-
- 2 edits in trunk/Source/WebKit/wince
Unreviewed WinCE build fix after r148373.
- WebCoreSupport/EditorClientWinCE.cpp:
- 8:22 AM Changeset in webkit [148437] by
-
- 2 edits in trunk/Source/WebCore
Debug buildfix after r148433.
https://bugs.webkit.org/show_bug.cgi?id=108295
Reviewed by Allan Sandfeld Jensen.
- platform/graphics/texmap/TextureMapperLayer.h:
(WebCore::TextureMapperLayer::children): Added.
- 7:16 AM Changeset in webkit [148436] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk1/TestExpectations:
- platform/qt/TestExpectations:
- 7:02 AM Changeset in webkit [148435] by
-
- 2 edits in trunk/Tools
Improve Windows cmd.exe detection
https://bugs.webkit.org/show_bug.cgi?id=114620
Patch by Jonathan Liu <net147@gmail.com> on 2013-04-15
Reviewed by Jocelyn Turcotte.
The current detection code handles Windows cmd.exe and Cygwin shell
but not does not handle MSYS shell correctly. Simplify and improve the
detection by checking MINGW_IN_SHELL instead as used in other places
(e.g. qt_functions.prf).
- qmake/mkspecs/features/default_pre.prf:
- 6:43 AM Changeset in webkit [148434] by
-
- 12 edits in trunk/Source/WebKit2
[EFL][WK2] Use C API in ewk_context_menu
https://bugs.webkit.org/show_bug.cgi?id=109698
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-04-15
Reviewed by Andreas Kling.
EFL port unlike others does not handle context menus inside WebKit but exposes an API:
ewk_context_menu and ewk_context_menu_item, and leaves context menu to application.
Currently EFL port's context menu API uses internal C++ classes, while it should use WK2 C API,
to avoid violating layering.
This patch changes EFL context menu API to use only WK2 C API.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::showContextMenu):
- UIProcess/API/efl/EwkView.h:
(WebKit):
(EwkView):
- UIProcess/API/efl/ewk_context_menu.cpp:
(EwkContextMenu::EwkContextMenu):
(EwkContextMenu::contextMenuItemSelected):
(ewk_context_menu_item_select):
(getWKTagFromEwkAction):
- UIProcess/API/efl/ewk_context_menu_item.cpp:
(EwkContextMenuItem::EwkContextMenuItem):
(getEwkActionFromWKTag):
- UIProcess/API/efl/ewk_context_menu_item.h:
- UIProcess/API/efl/ewk_context_menu_item_private.h:
(EwkContextMenuItem::create):
(EwkContextMenuItem):
- UIProcess/API/efl/ewk_context_menu_private.h:
(EwkContextMenu::create):
(EwkContextMenu):
- UIProcess/efl/ContextMenuClientEfl.cpp:
(showContextMenu):
(hideContextMenu):
(ContextMenuClientEfl::ContextMenuClientEfl):
- UIProcess/efl/ContextMenuClientEfl.h:
(WebKit::ContextMenuClientEfl::view):
- UIProcess/efl/WebContextMenuProxyEfl.cpp:
(WebKit::WebContextMenuProxyEfl::showContextMenu):
(WebKit::WebContextMenuProxyEfl::hideContextMenu):
- UIProcess/efl/WebContextMenuProxyEfl.h:
(WebContextMenuProxyEfl):
- 6:24 AM Changeset in webkit [148433] by
-
- 6 edits in trunk/Source/WebCore
Coordinated Graphics: Remove GraphicsLayerTextureMapper dependency from CoordinatedGraphicsScene.
https://bugs.webkit.org/show_bug.cgi?id=108295
Since all the changes to the TextureMapperLayer tree now come in a single IPC message via
CoordinatedGraphicsState, we don't need the additional buffering done in GraphicsLayerTextureMapper.
This reduces unnecessary function calls, and also streamlines GraphicsLayerTextureMapper to be used
only in WebKit1 (without CoordinatedGraphics).
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-15
Reviewed by Allan Sandfeld Jensen.
No new tests, refactor only.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
(WebCore::GraphicsLayerTextureMapper::setDrawsContent):
(WebCore::GraphicsLayerTextureMapper::prepareBackingStoreIfNeeded):
(WebCore::GraphicsLayerTextureMapper::updateDebugBorderAndRepaintCount):
(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded):
(WebCore):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
Removed references to m_hasOwnBackingStore, which was done to separate the CoordinatedGraphics
path from the WK1 path.
- platform/graphics/texmap/TextureMapperLayer.h:
(WebCore::TextureMapperLayer::drawsContent):
(WebCore::TextureMapperLayer::contentsAreVisible):
(WebCore::TextureMapperLayer::size):
(WebCore::TextureMapperLayer::opacity):
(WebCore::TextureMapperLayer::transform):
(WebCore::TextureMapperLayer::isShowingRepaintCounter):
(WebCore::TextureMapperLayer::fixedToViewport):
(TextureMapperLayer):
Added a few public functions needed by CoordinatedGraphicsScene.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::layerShouldHaveBackingStore):
(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebCore::CoordinatedGraphicsScene::paintToGraphicsContext):
(WebCore::CoordinatedGraphicsScene::adjustPositionForFixedLayers):
(WebCore::CoordinatedGraphicsScene::createCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::syncCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::destroyCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerRepaintCountIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerChildrenIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerFiltersIfNeeded):
(WebCore::CoordinatedGraphicsScene::setLayerState):
(WebCore::CoordinatedGraphicsScene::getLayerByIDIfExists):
(WebCore::CoordinatedGraphicsScene::createLayer):
(WebCore::CoordinatedGraphicsScene::deleteLayer):
(WebCore::CoordinatedGraphicsScene::setRootLayerID):
(WebCore::CoordinatedGraphicsScene::prepareContentBackingStore):
(WebCore::CoordinatedGraphicsScene::createBackingStoreIfNeeded):
(WebCore::CoordinatedGraphicsScene::removeBackingStoreIfNeeded):
(WebCore::CoordinatedGraphicsScene::resetBackingStoreSizeToLayerSize):
(WebCore::CoordinatedGraphicsScene::createTilesIfNeeded):
(WebCore::CoordinatedGraphicsScene::removeTilesIfNeeded):
(WebCore::CoordinatedGraphicsScene::updateTilesIfNeeded):
(WebCore::CoordinatedGraphicsScene::assignImageBackingToLayer):
(WebCore::CoordinatedGraphicsScene::commitSceneState):
(WebCore::CoordinatedGraphicsScene::ensureRootLayer):
(WebCore::CoordinatedGraphicsScene::setLayerAnimationsIfNeeded):
(WebCore::CoordinatedGraphicsScene::findScrollableContentsLayerAt):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
(CoordinatedGraphicsScene):
(WebCore::CoordinatedGraphicsScene::layerByID):
(WebCore::CoordinatedGraphicsScene::rootLayer):
Use TextureMapperLayer instead of GraphicsLayer and GraphicsLayerTextureMapper.
- 6:00 AM Changeset in webkit [148432] by
-
- 5 edits in trunk/Source/WebCore
Dynamically triggered subframe loads are causing tile churn
https://bugs.webkit.org/show_bug.cgi?id=114440
Reviewed by Andreas Kling.
In some cases we switch in and out of minimal tiles multiple times during page loading. This
creates tile churn where we create speculative tiles and then throw them out. This can be
caused by various reasons including dynamically created subframes.
- page/FrameView.cpp:
(WebCore::FrameView::setIsVisuallyNonEmpty):
Stay in minimal tiles modes until there is some visual contents. This avoids switching out from minimal
tiles while awaiting response for the initial requests.
- page/FrameView.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::computeTileCoverage):
- rendering/RenderLayerBacking.h:
(WebCore::RenderLayerBacking::didSwitchToFullTileCoverageDuringLoading):
(WebCore::RenderLayerBacking::setDidSwitchToFullTileCoverageDuringLoading):
Only switch into minimal coverage mode once per page load.
(RenderLayerBacking):
- 5:02 AM Changeset in webkit [148431] by
-
- 5 edits4 adds in trunk
color-index media feature not supported
https://bugs.webkit.org/show_bug.cgi?id=114468
Patch by Rune Lillesveen <rune@opera.com> on 2013-04-15
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Support the color-index media feature. Currently assumes that no WebKit
browser will have an output device that uses a color lookup table.
Tests: fast/media/mq-color-index-01.html
fast/media/mq-color-index-02.html
- css/MediaFeatureNames.h:
(MediaFeatureNames):
- css/MediaQueryEvaluator.cpp:
(WebCore::color_indexMediaFeatureEval):
(WebCore):
(WebCore::min_color_indexMediaFeatureEval):
(WebCore::max_color_indexMediaFeatureEval):
- css/MediaQueryExp.cpp:
(WebCore::featureWithPositiveInteger):
(WebCore::featureWithoutValue):
LayoutTests:
Added testcases for checking support and handling invalid values for
the color-index media feature.
- fast/media/mq-color-index-01-expected.html: Added.
- fast/media/mq-color-index-01.html: Added.
- fast/media/mq-color-index-02-expected.txt: Added.
- fast/media/mq-color-index-02.html: Added.
- 4:49 AM Changeset in webkit [148430] by
-
- 6 edits in trunk/Source
[CoordGfx] Background color should not be part of GraphicsLayerState
https://bugs.webkit.org/show_bug.cgi?id=113785
Source/WebCore:
Page background is independent from layer state, send it to the UI
as soon as possible.
Should not cause observable change in behavior so no new tests.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::commitSceneState):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
Source/WebKit2:
Reviewed by Andreas Kling.
Page background is independent from layer state, send it to the UI
as soon as possible.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::setBackgroundColor):
- 4:11 AM QtWebKitBuildBots edited by
- Updating some bot information. (diff)
- 4:08 AM Changeset in webkit [148429] by
-
- 2 edits in trunk/Tools
[webkitpy] Use $NUMBER_OF_PROCESSORS in Executive.cpu_count()
https://bugs.webkit.org/show_bug.cgi?id=114506
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-15
Reviewed by Philippe Normand.
- Scripts/webkitpy/common/system/executive.py:
(Executive.cpu_count): Modify function in order to use the environment
variable $NUMBER_OF_PROCESSORS if it is defined and it is an integer
greater than 0.
- 3:58 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:57 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:54 AM Changeset in webkit [148428] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0
Merge r147967 - Bug 110293 uses read -d which is a non-portable bashism
https://bugs.webkit.org/show_bug.cgi?id=113349
Reviewed by Gustavo Noronha Silva.
- Source/autotools/SetupWebKitFeatures.m4: Pass the default feature set to the
feature script in a more portable way.
- 3:50 AM Changeset in webkit [148427] by
-
- 5 edits in trunk
[BlackBerry] ASSERT in StyleResolver::ensureScopeResolver()
https://bugs.webkit.org/show_bug.cgi?id=114615
Patch by Xan Lopez <xlopez@igalia.com> on 2013-04-15
Reviewed by Carlos Garcia Campos.
Source/WebKit/blackberry:
Add a method to enable the style scoped feature to our
DumpRenderTreeSupport class.
- WebKitSupport/DumpRenderTreeSupport.cpp:
(DumpRenderTreeSupport::setStyleScopedEnabled):
- WebKitSupport/DumpRenderTreeSupport.h:
(DumpRenderTreeSupport):
Tools:
Enable the style scoped feature if we have support for it.
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
- 3:36 AM Changeset in webkit [148426] by
-
- 3 edits in trunk/LayoutTests
[EFL] Unskip some inspector tests related to styles
https://bugs.webkit.org/show_bug.cgi?id=114609
Unreviewed gardening.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-15
- platform/efl-wk2/TestExpectations: Old issues. Fixed on the latest codebase.
- platform/efl/TestExpectations: Fixed by r128637.
- 3:35 AM QtWebKitGardening edited by
- Rename sheriffbot to webkitbot (diff)
- 3:33 AM CommitterTips edited by
- Rename sheriffbot to webkitbot (diff)
- 3:11 AM Changeset in webkit [148425] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Filesystem callback notifyCreateSnapshotFileAndReadMetadata can be called on the wring thread
https://bugs.webkit.org/show_bug.cgi?id=114610
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-15
Reviewed by Xan Lopez.
Override notifyCreateSnapshotFileAndReadMetadata to make sure the
callback is called on the right thread.
Fixes a crash in several fast/filesystem test in debug builds.
- platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.cpp:
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyCreateSnapshotFileAndReadMetadata):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyCreateSnapshotFileAndReadMetadataOnWorkerThread):
- platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.h:
- 2:31 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:28 AM Changeset in webkit [148424] by
-
- 9 edits in releases/WebKitGTK/webkit-2.0
Merge r147499 - [GTK] Make libsecret optional
https://bugs.webkit.org/show_bug.cgi?id=113821
Reviewed by Gustavo Noronha Silva.
.:
Add a configuration option to disable credential storage and thus remove
the libsecret dependency. This should make it possible to build WebKit 2.x
on Windows again.
- Source/autotools/FindDependencies.m4: Only look for libsecret if credential storage is active.
- Source/autotools/PrintBuildConfiguration.m4: Print whether or not credential storage is active.
- Source/autotools/ReadCommandLineArguments.m4: Added an option to control credential storage.
- Source/autotools/SetupAutoconfHeader.m4: Expose credential storage setting to code.
Source/WebCore:
Don't try to use libsecret if credential storage is disabled.
- platform/gtk/GRefPtrGtk.cpp: Protect libsecret sections.
- platform/gtk/GRefPtrGtk.h: Ditto.
- platform/network/gtk/CredentialBackingStore.cpp: Ditto.
- 2:18 AM Changeset in webkit [148423] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry][CSS Filters] Non-image content disappears when filter applied
https://bugs.webkit.org/show_bug.cgi?id=114498
Reviewed by Carlos Garcia Campos.
Applying a filter to a div with simple text content caused the div to
disappear.
In https://bugs.webkit.org/show_bug.cgi?id=114276, we added some GL
state save/restore code for vertex attributes to make sure the state
changes done by BlackBerry::Platform::Graphics don't interfere with
GL code executing in WebKit. However, saving and restoring vertex
attribute state won't do much good if those attributes were never
enabled to begin with. Fixed by enabling vertex attributes
appropriately when setting them, so that state can be saved and
restored.
All the CSS Filters layout tests apply the filters to simple rectangles
or images, there's nothing sufficiently complex that we manage to
trigger this GL state conflict in the BlackBerry port. This suggests
adding a new platform-specific layout test would be appropriate, but
since we don't use pixel tests yet, such a test would not help detect
regressions. Ultimately we decided against adding a layout test for
this bug at this time.
- platform/graphics/blackberry/LayerFilterRenderer.cpp:
(WebCore::LayerFilterRenderer::applyActions):
- 2:16 AM Changeset in webkit [148422] by
-
- 2 edits in trunk/Tools
[Qt] QtMultimedia not used when GStreamer is not found
https://bugs.webkit.org/show_bug.cgi?id=111842
Reviewed by Philippe Normand.
Fallback to using QtMultimedia when native libraries are not found.
- qmake/mkspecs/features/features.prf:
- 2:11 AM Changeset in webkit [148421] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
spelling-with-whitespace-selection.html passes after r148282.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 2:02 AM Changeset in webkit [148420] by
-
- 10 edits in trunk/Source/WebKit2
[WK2] Add new callbacks and a function for WebKit2 context menu API
https://bugs.webkit.org/show_bug.cgi?id=111552
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-04-15
Reviewed by Anders Carlsson.
Add contextMenuHide and contextMenuShow callbacks to WKPageContextMenuClient
and WKPageContextMenuSelected API so context menus can be handled outside
WebKit. API version of this client was bumped so older client version still
can be used
- Shared/APIClientTraits.cpp:
(WebKit):
- Shared/APIClientTraits.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageSelectContextMenuItem):
- UIProcess/API/C/WKPage.h:
- UIProcess/API/gtk/WebKitContextMenuClient.cpp:
(attachContextMenuClientToView):
- UIProcess/WebPageContextMenuClient.cpp:
(WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):
(WebKit::WebPageContextMenuClient::showContextMenu):
(WebKit):
(WebKit::WebPageContextMenuClient::hideContextMenu):
- UIProcess/WebPageContextMenuClient.h:
(WebPageContextMenuClient):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::internalShowContextMenu):
- UIProcess/efl/ContextMenuClientEfl.cpp:
(ContextMenuClientEfl::ContextMenuClientEfl):
- 1:20 AM Changeset in webkit [148419] by
-
- 2 edits in trunk/LayoutTests
[EFL] inspector/styles/styles-history.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=98777
Unreviewed gardening.
Unskip inspector/styles/styles-history.html as it was fixed by r131895.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-15
- platform/efl/TestExpectations:
- 12:27 AM Changeset in webkit [148418] by
-
- 1 edit1 delete in trunk/LayoutTests
[EFL] Remove inspector/styles/paste-property-expected.txt from efl-wk2
https://bugs.webkit.org/show_bug.cgi?id=114604
Unreviewed gardening.
Remove an improper file after r147420.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-15
- platform/efl-wk2/inspector/styles/paste-property-expected.txt: Removed.
- 12:06 AM Changeset in webkit [148417] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline fast/js/global-constructors.html for EFL port due to
addition of MutationRecordConstructor.
- platform/efl/fast/js/global-constructors-expected.txt:
Apr 14, 2013:
- 11:58 PM Changeset in webkit [148416] by
-
- 14 edits6 deletes in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline several SVG tests for EFL port.
- platform/efl-wk2/svg/css/group-with-shadow-expected.png:
- platform/efl-wk2/svg/filters/shadow-on-rect-with-filter-expected.png:
- platform/efl/svg/css/arrow-with-shadow-expected.png:
- platform/efl/svg/css/arrow-with-shadow-expected.txt: Removed.
- platform/efl/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
- platform/efl/svg/css/clippath-with-shadow-expected.txt: Removed.
- platform/efl/svg/css/composite-shadow-example-expected.png:
- platform/efl/svg/css/composite-shadow-example-expected.txt:
- platform/efl/svg/css/composite-shadow-with-opacity-expected.png:
- platform/efl/svg/css/composite-shadow-with-opacity-expected.txt:
- platform/efl/svg/css/group-with-shadow-expected.txt:
- platform/efl/svg/css/path-with-shadow-expected.txt:
- platform/efl/svg/css/shadow-and-opacity-expected.txt:
- platform/efl/svg/css/shadow-with-large-radius-expected.txt: Removed.
- platform/efl/svg/css/shadow-with-negative-offset-expected.txt: Removed.
- platform/efl/svg/css/text-gradient-shadow-expected.txt:
- platform/efl/svg/css/text-shadow-multiple-expected.txt:
- platform/efl/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
- platform/efl/transitions/svg-text-shadow-transition-expected.txt:
- 8:13 PM CommitterTips edited by
- Clarify that "Unreviewed" should be present if no "Reviewed by" is present. (diff)
- 7:22 PM Changeset in webkit [148415] by
-
- 2 edits in branches/safari-536.30-branch/Source/JavaScriptCore
Revert "Attempt to fix Windows build after r148370"
This reverts commit r148375.
- runtime/JSStringJoiner.h: Remove include of
<wtf/CheckedArithmetic.h>.
- 6:29 PM Changeset in webkit [148414] by
-
- 12 edits in trunk
[css3-text] Parsing -webkit-hanging value for text-indent from css3-text
https://bugs.webkit.org/show_bug.cgi?id=113680
Source/WebCore:
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-14
Reviewed by Andreas Kling.
This patch is the parsing part to support hanging value for text-indent.
"hanging" means "Inverts which lines are affected."
It's prefixed and guarded by CSS3_TEXT flag.
No new tests, this patch updates existing tests.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseTextIndent): Parsed "-webkit-hanging" with "-webkit-each-line".
- css/CSSValueKeywords.in: Added "-webkit-hanging" keyword.
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyTextIndent::applyInheritValue):
(WebCore::ApplyPropertyTextIndent::applyInitialValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h: Added enum TextIndentType.
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h: Added m_textIndentType.
(StyleRareInheritedData):
Added the usual getter / setter / initial methods for m_textIndentType.
LayoutTests:
"hanging" is added for text-indent in CSS3.
http://dev.w3.org/csswg/css3-text/#hanging
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-14
Reviewed by Andreas Kling.
- fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-expected.txt:
- fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent.js:
(valueSettingTest):
- 4:32 PM Changeset in webkit [148413] by
-
- 9 edits2 adds in trunk/Source
Move Mac specific snapshotting code into its own file
https://bugs.webkit.org/show_bug.cgi?id=114597
Reviewed by Andreas Kling.
Source/WebCore:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- bindings/objc/DOM.mm:
(-[DOMRange renderedImageForcingBlackText:]):
- page/Frame.h:
- page/mac/FrameMac.mm:
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):
- page/mac/FrameSnapshottingMac.h: Added.
- page/mac/FrameSnapshottingMac.mm: Added.
(WebCore::imageFromRect):
(WebCore::selectionImage):
(WebCore::rangeImage):
(WebCore::snapshotDragImage):
- platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::dragNSImage):
Move the four Mac specific snapshotting functions in Frame.h into FrameSnapshottingMac.h/mm and turn
them into free standing functions.
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(-[WebHTMLView _selectionDraggingImage]):
(-[WebHTMLView selectionImageForcingBlackText:]):
- 2:50 PM Changeset in webkit [148412] by
-
- 2 edits in trunk/LayoutTests
Re-skip editing/spelling/spelling-changed-text.html on Mac/WK1.
- platform/mac/TestExpectations:
- 2:13 PM Changeset in webkit [148411] by
-
- 2 edits in trunk/Source/WebCore
Hawtfix Mac build.
- WebCore.exp.in:
- 1:32 PM Changeset in webkit [148410] by
-
- 5 edits in trunk/Source/WebCore
Only MutableStylePropertySets should be able to have CSSOM wrappers.
<http://webkit.org/b/114595>
Reviewed by Antti Koivisto.
Tighten typing so that only MutableStylePropertySets can have CSSOM wrappers associated.
This allows us to get rid of the out-of-line base class destructor.
- WebCore.exp.in:
- css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::~MutableStylePropertySet):
(WebCore::MutableStylePropertySet::cssStyleDeclaration):
(WebCore::MutableStylePropertySet::ensureInlineCSSStyleDeclaration):
- css/StylePropertySet.h:
(StylePropertySet):
(MutableStylePropertySet):
- dom/StyledElement.cpp:
(WebCore::StyledElement::inlineStyleCSSOMWrapper):
- 1:05 PM Changeset in webkit [148409] by
-
- 4 edits in branches/safari-536.30-branch/Source/WTF
Try to fix Windows Elgar build again after r148370
Merge r148401.
Add EnumClass.h to the MSVC project.
2013-04-14 David Kilzer <ddkilzer@apple.com>
Add EnumClass.h to project files
<http://webkit.org/b/114582>
Rubber-stamped by Dan Bernstein.
- WTF.pro: Add EnumClass.h to project.
- WTF.vcproj/WTF.vcproj: Ditto.
- WTF.vcxproj/WTF.vcxproj: Ditto.
- WTF.vcxproj/WTF.vcxproj.filters: Ditto.
- WTF.xcodeproj/project.pbxproj: Ditto.
- 12:19 PM Changeset in webkit [148408] by
-
- 2 edits in trunk/Source/WebCore
Remove unused function declaration StylePropertySet::setNeedsStyleRecalc().
Rubber-stamped by Antti Koivisto.
- css/StylePropertySet.h:
(StylePropertySet):
- 12:17 PM Changeset in webkit [148407] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Regression(r148274): Broke rendering in the browser
https://bugs.webkit.org/show_bug.cgi?id=114593
Reviewed by Anders Carlsson.
r148274 added a new "didChangeViewportAttributes" callback to
WKView but did not hook it up in ViewClientEfl. This patch
fixes this and makes rendering work again in the browser.
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::ViewClientEfl):
- 12:09 PM Changeset in webkit [148406] by
-
- 3 edits in trunk/Source/WebCore
Move StylePropertySet internal storage access helpers to subclass.
<http://webkit.org/b/114592>
Reviewed by Antti Koivisto.
Removed mutablePropertyVector() since most call sites are inside MutableStylePropertySet
and can access m_propertyVector directly. The few ones that aren't can just cast.
For ImmutableStylePropertySet, moved value/metadata array accessors to the subclass
and remove "immutable" from their names.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::immutableCopyIfNeeded):
(WebCore::ImmutableStylePropertySet::ImmutableStylePropertySet):
(WebCore::ImmutableStylePropertySet::~ImmutableStylePropertySet):
(WebCore::MutableStylePropertySet::MutableStylePropertySet):
(WebCore::MutableStylePropertySet::removeProperty):
(WebCore::MutableStylePropertySet::removePrefixedOrUnprefixedProperty):
(WebCore::MutableStylePropertySet::setProperty):
(WebCore::MutableStylePropertySet::appendPrefixingVariantProperty):
(WebCore::MutableStylePropertySet::parseDeclaration):
(WebCore::MutableStylePropertySet::addParsedProperties):
(WebCore::MutableStylePropertySet::clear):
(WebCore::MutableStylePropertySet::removePropertiesInSet):
(WebCore::MutableStylePropertySet::findCSSPropertyWithID):
(WebCore::MutableStylePropertySet::removeEquivalentProperties):
(WebCore::StylePropertySet::reportMemoryUsage):
- css/StylePropertySet.h:
(PropertyReference):
(StylePropertySet):
(ImmutableStylePropertySet):
(WebCore::ImmutableStylePropertySet::valueArray):
(WebCore::ImmutableStylePropertySet::metadataArray):
(WebCore::StylePropertySet::PropertyReference::propertyMetadata):
(WebCore::StylePropertySet::PropertyReference::propertyValue):
(WebCore::StylePropertySet::propertyCount):
- 11:25 AM Changeset in webkit [148405] by
-
- 2 edits in trunk/Source/WTF
Try to fix non-apple windows builds
- 10:56 AM Changeset in webkit [148404] by
-
- 2 edits in trunk/Source/WebCore
Specialize propertyCount() in StylePropertySet subclasses.
<http://webkit.org/b/114590>
Reviewed by Antti Koivisto.
Avoid branching on m_isMutable in code that already knows which type of set it is.
- css/StylePropertySet.h:
(WebCore::ImmutableStylePropertySet::propertyCount):
(ImmutableStylePropertySet):
(WebCore::MutableStylePropertySet::propertyCount):
(MutableStylePropertySet):
- 10:49 AM Changeset in webkit [148403] by
-
- 9 edits in trunk/Source/WebCore
Move property setting/removing functions to MutableStylePropertySet.
<http://webkit.org/b/114589>
Reviewed by Antti Koivisto.
Move all functions for setting/removing properties from StylePropertySet to MutableStylePropertySet.
Had to change SVGElement::animatedSMILStyleProperties() & friends to hand out MutableStylePropertySet*
which was always the internal type anyway.
- css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::removeShorthandProperty):
(WebCore::MutableStylePropertySet::removeProperty):
(WebCore::MutableStylePropertySet::removePrefixedOrUnprefixedProperty):
(WebCore::MutableStylePropertySet::setProperty):
(WebCore::MutableStylePropertySet::appendPrefixingVariantProperty):
(WebCore::MutableStylePropertySet::setPrefixingVariantProperty):
(WebCore::MutableStylePropertySet::mergeAndOverrideOnConflict):
(WebCore::MutableStylePropertySet::removeBlockProperties):
(WebCore::MutableStylePropertySet::removePropertiesInSet):
(WebCore::MutableStylePropertySet::findCSSPropertyWithID):
(WebCore::MutableStylePropertySet::removeEquivalentProperties):
- css/StylePropertySet.h:
(StylePropertySet):
(MutableStylePropertySet):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::removePropertiesInStyle):
(WebCore::reconcileTextDecorationProperties):
- svg/SVGAnimateElement.cpp:
(WebCore::applyCSSPropertyToTarget):
- svg/SVGElement.cpp:
(WebCore::SVGElement::animatedSMILStyleProperties):
(WebCore::SVGElement::ensureAnimatedSMILStyleProperties):
- svg/SVGElement.h:
(SVGElement):
- svg/SVGElementRareData.h:
(WebCore::SVGElementRareData::animatedSMILStyleProperties):
(WebCore::SVGElementRareData::ensureAnimatedSMILStyleProperties):
(SVGElementRareData):
- 10:33 AM Changeset in webkit [148402] by
-
- 5 edits in trunk/Source/WebCore
EditingStyle should have a MutableStylePropertySet internally.
<http://webkit.org/b/114588>
Reviewed by Anders Carlsson.
Switch EditingStyle::m_mutableStyle to a RefPtr<MutableStylePropertySet>.
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::copyBlockProperties):
- css/StylePropertySet.h:
(StylePropertySet):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::setStyle):
(WebCore::EditingStyle::mergeStyleFromRules):
(WebCore::StyleChange::StyleChange):
(WebCore::setTextDecorationProperty):
(WebCore::StyleChange::extractTextStyles):
(WebCore::diffTextDecorations):
(WebCore::getPropertiesNotIn):
- editing/EditingStyle.h:
(WebCore::EditingStyle::style):
(EditingStyle):
(StyleChange):
- 9:49 AM Changeset in webkit [148401] by
-
- 6 edits in trunk/Source/WTF
Add EnumClass.h to project files
<http://webkit.org/b/114582>
Rubber-stamped by Dan Bernstein.
- WTF.pro: Add EnumClass.h to project.
- WTF.vcproj/WTF.vcproj: Ditto.
- WTF.vcxproj/WTF.vcxproj: Ditto.
- WTF.vcxproj/WTF.vcxproj.filters: Ditto.
- WTF.xcodeproj/project.pbxproj: Ditto.
- 9:43 AM Changeset in webkit [148400] by
-
- 6 edits in trunk/Source/WebCore
Move addParsedProperty/addParsedProperties to MutableStylePropertySet.
<http://webkit.org/b/114587>
Reviewed by Antti Koivisto.
All CSSParser methods that mutate an existing StylePropertySet now take a MutableStylePropertySet*
instead of a StylePropertySet*.
- css/CSSParser.cpp:
(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::parseKeywordValue):
(WebCore::parseTranslateTransformValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseDeclaration):
- css/CSSParser.h:
(CSSParser):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::setProperty):
(WebCore::MutableStylePropertySet::addParsedProperties):
(WebCore::MutableStylePropertySet::addParsedProperty):
- css/StylePropertySet.h:
(StylePropertySet):
(MutableStylePropertySet):
- css/ViewportStyleResolver.h:
(ViewportStyleResolver):
- 9:21 AM Changeset in webkit [148399] by
-
- 3 edits in trunk/Source/WebCore
CSSParser should return ImmutableStylePropertySets.
<http://webkit.org/b/114585>
Reviewed by Anders Carlsson.
The StylePropertySets created by CSSParser were already immutable.
Let this be reflected in the pointer types returned.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseInlineStyleDeclaration):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::createStylePropertySet):
- css/CSSParser.h:
(CSSParser):
- 9:14 AM Changeset in webkit [148398] by
-
- 4 edits in trunk/Source/WebCore
Move StylePropertySet::createImmutable() to ImmutableStylePropertySet.
<http://webkit.org/b/114584>
Reviewed by Anders Carlsson.
StylePropertySet::createImmutable() -> ImmutableStylePropertySet::create()
Also, immutableCopyIfNeeded() now returns a PassRefPtr<ImmutableStylePropertySet>.
- css/CSSParser.cpp:
(WebCore::CSSParser::createStylePropertySet):
- css/StylePropertySet.cpp:
(WebCore::ImmutableStylePropertySet::create):
(WebCore::StylePropertySet::immutableCopyIfNeeded):
- css/StylePropertySet.h:
(StylePropertySet):
(ImmutableStylePropertySet):
- 8:46 AM Changeset in webkit [148397] by
-
- 5 edits in trunk/Source/WebCore
Move parseDeclaration() and clear() to MutableStylePropertySet.
<http://webkit.org/b/114583>
Reviewed by Anders Carlsson.
...and remove ASSERT(isMutable()) from the function bodies.
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::removedFrom):
Use clear() directly instead of taking an empty string through the CSS parser.
- css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::parseDeclaration):
(WebCore::MutableStylePropertySet::clear):
- css/StylePropertySet.h:
(StylePropertySet):
(MutableStylePropertySet):
- dom/StyledElement.cpp:
(WebCore::StyledElement::setInlineStyleFromString):
- 8:19 AM Changeset in webkit [148396] by
-
- 23 edits in trunk/Source
Move CSSOM classes to using MutableStylePropertySet over StylePropertySet.
<http://webkit.org/b/114581>
Reviewed by Anders Carlsson.
Source/WebCore:
Moved ensureCSSStyleDeclaration() and ensureInlineCSSStyleDeclaration() from StylePropertySet
to MutableStylePropertySet.
StyleRule & co now return a MutableStylePropertySet* from mutableProperties() to aid with...
CSSStyleDeclaration now only deals with MutableStylePropertySets. This was already the case
in practice, we just didn't have any compile-time foot-shooting protection.
In other words, if there's a CSSOM wrapper for a given StylePropertySet, it's guaranteed to
be mutable, and the pointer types now reflect this.
- WebCore.exp.in:
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::StyleRuleCSSStyleDeclaration::StyleRuleCSSStyleDeclaration):
(WebCore::StyleRuleCSSStyleDeclaration::reattach):
- css/PropertySetCSSStyleDeclaration.h:
(WebCore::PropertySetCSSStyleDeclaration::PropertySetCSSStyleDeclaration):
(PropertySetCSSStyleDeclaration):
(WebCore::StyleRuleCSSStyleDeclaration::create):
(StyleRuleCSSStyleDeclaration):
(WebCore::InlineCSSStyleDeclaration::InlineCSSStyleDeclaration):
- css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::ensureCSSStyleDeclaration):
(WebCore::MutableStylePropertySet::ensureInlineCSSStyleDeclaration):
- css/StylePropertySet.h:
(StylePropertySet):
(MutableStylePropertySet):
- css/StyleRule.cpp:
(WebCore::StyleRule::mutableProperties):
(WebCore::StyleRulePage::mutableProperties):
(WebCore::StyleRuleFontFace::mutableProperties):
(WebCore::StyleRuleViewport::mutableProperties):
(WebCore::StyleRuleFilter::mutableProperties):
- css/StyleRule.h:
(StyleRule):
(StyleRuleFontFace):
(StyleRulePage):
(StyleRuleViewport):
(StyleRuleFilter):
- css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::mutableProperties):
- css/WebKitCSSKeyframeRule.h:
(StyleKeyframe):
- dom/Attr.cpp:
(WebCore::Attr::style):
- dom/Attr.h:
(Attr):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::styleFromMatchedRulesForElement):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::copyTypingStyle):
- editing/FrameSelection.h:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
Source/WebKit/gtk:
- WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::shouldApplyStyle):
Source/WebKit/mac:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::shouldApplyStyle):
- WebView/WebFrame.mm:
(-[WebFrame _typingStyle]):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::shouldApplyStyle):
- 7:24 AM Changeset in webkit [148395] by
-
- 24 edits in trunk/Source/WebCore
Move create() methods from StylePropertySet to MutableStylePropertySet.
<http://webkit.org/b/114574>
Reviewed by Antti Koivisto.
Move the two create() methods that create MutableStylePropertySets from StylePropertySet
to MutableStylePropertySet, and make them actually return MutableStylePropertySets.
Switch to using {Pass,}RefPtr<MutableStylePropertySet> where appropriate to keep things building.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFontFaceValue):
- css/DOMWindowCSS.cpp:
(WebCore::DOMWindowCSS::supports):
- css/ElementRuleCollector.cpp:
(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):
- css/FontLoader.cpp:
(WebCore::FontLoader::resolveFontStyle):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::copyPropertiesInSet):
(WebCore::MutableStylePropertySet::create):
- css/StylePropertySet.h:
(StylePropertySet):
(MutableStylePropertySet):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::resolveVariables):
- css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
- dom/Attr.cpp:
(WebCore::Attr::style):
- dom/Document.cpp:
(WebCore::Document::createCSSStyleDeclaration):
- dom/StyledElement.cpp:
(WebCore::StyledElement::ensureMutableInlineStyle):
(WebCore::StyledElement::rebuildPresentationAttributeStyle):
- editing/ApplyStyleCommand.cpp:
(WebCore::copyStyleOrCreateEmpty):
- editing/EditingStyle.cpp:
(WebCore::editingStyleFromComputedStyle):
(WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue):
(WebCore::EditingStyle::setProperty):
(WebCore::EditingStyle::extractAndRemoveTextDirection):
(WebCore::styleFromMatchedRulesForElement):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::EditingStyle::forceInline):
- editing/Editor.cpp:
(WebCore::Editor::setBaseWritingDirection):
- editing/EditorCommand.cpp:
(WebCore::executeApplyStyle):
(WebCore::executeToggleStyleInList):
(WebCore::executeApplyParagraphStyle):
(WebCore::executeMakeTextWritingDirectionLeftToRight):
(WebCore::executeMakeTextWritingDirectionNatural):
(WebCore::executeMakeTextWritingDirectionRightToLeft):
- html/HTMLTableElement.cpp:
(WebCore::leakBorderStyle):
(WebCore::HTMLTableElement::createSharedCellStyle):
(WebCore::leakGroupBorderStyle):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
- page/DragController.cpp:
(WebCore::DragController::concludeEditDrag):
- svg/SVGElementRareData.h:
(WebCore::SVGElementRareData::ensureAnimatedSMILStyleProperties):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::getPresentationAttribute):
- 5:37 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:35 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:34 AM Changeset in webkit [148394] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0
Merge r148293 - [GTK] Lower the pango dependency
https://bugs.webkit.org/show_bug.cgi?id=114520
Reviewed by Carlos Garcia Campos.
- Source/autotools/Versions.m4: Only depend on Pango 1.30.0 instead of
Pango 1.32.0. 1.32.0 isn't strictly necessary and the version of GTK+ that
we depend on (3.6.0) depends on 1.30.0.
- 5:33 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:32 AM Changeset in webkit [148393] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Tools
Merge r147946 - [GTK] Bump gnome-themes-standard to 3.6.0
https://bugs.webkit.org/show_bug.cgi?id=114155
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-08
Reviewed by Martin Robinson.
- gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
dependency of gnome-themes-standard accordingly.
- 5:32 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:31 AM Changeset in webkit [148392] by
-
- 2 edits1 add in releases/WebKitGTK/webkit-2.0/Tools
Merge r148110 - [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
https://bugs.webkit.org/show_bug.cgi?id=114365
Reviewed by Martin Robinson.
Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
The patch addresses crashes in the tally_event_reply method. It is already committed into the
at-spi2-atk source tree and will be available with the next stable release, after which the
patch should be removed and the dependency version bumped.
- gtk/jhbuild.modules:
- gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
- 5:29 AM Changeset in webkit [148391] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Tools
Merge r147574 - [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
https://bugs.webkit.org/show_bug.cgi?id=113883
Reviewed by Martin Robinson.
- gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
- 5:27 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:24 AM Changeset in webkit [148390] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Tools
Merge r147547 - [GTK] Bump required versions of some dependencies
https://bugs.webkit.org/show_bug.cgi?id=113282
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-03
Reviewed by Martin Robinson.
.:
This patch updates the following dependencies:
- libsoup 2.42.0: is the current stable release.
- glib 2.36.0: libsoup 2.42 requires 2.35.0, but we don't want to depend on unstable versions and 2.36 is the next stable version after 2.35.
- gtk+ 3.6.0: this is the previous stable release. We don't currently have any code using newer API, so we will be able to remove all the #ifdefed code.
- at-spi2 2.5.3: is the version required by gtk+ 3.6.
- GObject introspection 1.32.0: is the version required by gtk+ 3.6.
- Pango 1.32.0: it's the current stable version and the first one depending on Harfbuzz.
- Fontconfig 2.5: required by pango 1.32.0 when using Harfbuzz.
- gtk+ 2.24.10: it allows us to remove a lot of deprecated code and #ifdefs.
- Source/autotools/Versions.m4:
Tools:
- gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
- 5:23 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:19 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:18 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:17 AM Changeset in webkit [148389] by
-
- 4 edits15 deletes in releases/WebKitGTK/webkit-2.0
Merge r147963 - [WIN] Remove WebKit2 source code
https://bugs.webkit.org/show_bug.cgi?id=114096
Reviewed by Anders Carlsson.
Source/WebKit2:
Remove conditional includes for the windows platform.
- Shared/API/c/WKBase.h:
- UIProcess/API/C/WKAPICast.h:
Tools:
Remove the windows specific parts of the MiniBrowser.
- MiniBrowser/MiniBrowser.vcproj: Removed.
- MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
- MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
- MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
- MiniBrowser/win/BrowserView.cpp: Removed.
- MiniBrowser/win/BrowserView.h: Removed.
- MiniBrowser/win/BrowserWindow.cpp: Removed.
- MiniBrowser/win/BrowserWindow.h: Removed.
- MiniBrowser/win/MiniBrowser.cpp: Removed.
- MiniBrowser/win/MiniBrowser.h: Removed.
- MiniBrowser/win/MiniBrowser.rc: Removed.
- MiniBrowser/win/main.cpp: Removed.
- MiniBrowser/win/resource.h: Removed.
- MiniBrowser/win/stdafx.cpp: Removed.
- MiniBrowser/win/stdafx.h: Removed.
- 5:15 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:15 AM Changeset in webkit [148388] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Tools
Merge r148230 - [GTK] Windows build failure after r136056
https://bugs.webkit.org/show_bug.cgi?id=114121
Patch by Kalev Lember <kalevlember@gmail.com> on 2013-04-11
Reviewed by Martin Robinson.
- TestWebKitAPI/config.h: Make sure defines are correct for other
Windows ports than apple-win.
- 5:14 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:13 AM Changeset in webkit [148387] by
-
- 1 edit1 add in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge r147814 - Translation of WebKitGTK+ for Malayalam (ml)
https://bugs.webkit.org/show_bug.cgi?id=113280
Patch by Ani Peter <peter.ani@gmail.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.
- ml.po: Added.
- 5:11 AM Changeset in webkit [148386] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge r147812 - webkit translations for gujarati
https://bugs.webkit.org/show_bug.cgi?id=113190
Patch by Sweta Kothari <swkothar@redhat.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.
- gu.po:
- 4:36 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:33 AM Changeset in webkit [148385] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge r147811 - [l10n] [hi] Updated WebKit Translation in Hindi [hi] language
https://bugs.webkit.org/show_bug.cgi?id=113180
Patch by Rajesh Ranjan <rajeshkajha@yahoo.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.
- hi.po:
- 4:28 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:26 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:25 AM Changeset in webkit [148384] by
-
- 1 edit1 add in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge r147015 - Tamil translation for Gnome 3.6
https://bugs.webkit.org/show_bug.cgi?id=96995
Patch by Shantha kumar <shkumar@redhat.com> on 2013-03-27
Reviewed by Gustavo Noronha Silva (kov).
- ta.po: Added.
- 4:24 AM Changeset in webkit [148383] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po
Merge r147003 - Updated Slovenian translation
https://bugs.webkit.org/show_bug.cgi?id=113151
Patch by Matej Urbančič <mateju@svn.gnome.org> on 2013-03-27
Reviewed by Gustavo Noronha Silva (kov).
- sl.po: translation update.
- 4:05 AM WebKitGTK/2.0.x edited by
- (diff)
- 4:01 AM Changeset in webkit [148382] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r148286 - [GTK] Web Process crash when the UI process finishes too early
https://bugs.webkit.org/show_bug.cgi?id=112729
Reviewed by Anders Carlsson.
The problem is when creating the GSocket in the WorkQeue for the
socket descriptor. GLib considers a programmer error to create a
GSocket providing an invalid socket and finishes the process with
g_error(). We are actually providing a valid socket when creating
the GSocket, but it can be invalidated by the worker thread while
the GSocket is being created. This is because
registerEventSourceHandler is called from the main thread and
unregisterEventSourceHandler can be called from the worker
thread. We are currently registering two event handlers, one to
read data from the socket and another one to close the CoreIPC
connection when the socket connection is broken. Every event
source registered uses its own GSocket (even if the file
descriptor is actually the same), so that when the UI process
finishes too early, the first event handler can be executed in the
worker thread, closing the socket descriptor, while the main
thread is creating the GSocket for the second one.
We don't really need to use a separate event handler to monitor
the connection, because GSocket always notifies when condition is
G_IO_HUP and G_IO_ERR even if they haven't been explicitly set in
g_socket_create_source(). We can register socket event sources
differently, providing also a function to be called when the
connection is closed, using a single socket and the same even source.
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::open): Register a single socket event
handler providing also a function to be called when the connection
is closed.
- Platform/WorkQueue.h:
(WorkQueue):
- Platform/gtk/WorkQueueGtk.cpp: The EventSource class has been
split, moving everyting specific to socket event source to a
derived class SocketEventSource.
(WorkQueue::EventSource::EventSource):
(WorkQueue::EventSource::performWork):
(WorkQueue::EventSource::performWorkOnce):
(WorkQueue::EventSource::performWorkOnTermination):
(WorkQueue::EventSource::deleteEventSource):
(WorkQueue::EventSource):
(WorkQueue::SocketEventSource):
(WorkQueue::SocketEventSource::SocketEventSource):
(WorkQueue::SocketEventSource::cancel):
(WorkQueue::SocketEventSource::didClose):
(WorkQueue::SocketEventSource::checkCondition):
(WorkQueue::SocketEventSource::eventCallback):
(WorkQueue::registerSocketEventHandler):
(WorkQueue::unregisterSocketEventHandler):
(WorkQueue::dispatchOnSource):
- 1:10 AM Changeset in webkit [148381] by
-
- 11 edits in trunk/Source
Source/WebKit/efl: Unreviewed build fix for WebKit1 EFL after r148373 due to missing
header includes.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/EditorClientEfl.cpp:
- WebCoreSupport/FrameLoaderClientEfl.cpp:
- WebCoreSupport/InspectorClientEfl.cpp:
- ewk/ewk_frame.cpp:
- ewk/ewk_view.cpp:
- ewk/ewk_view_private.h:
(WebCore):
Source/WebKit2: Unreviewed build fix for WebKit2 EFL after r148373 due to missing
header includes.
- UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:
- UIProcess/efl/InputMethodContextEfl.cpp:
Apr 13, 2013:
- 9:13 PM Changeset in webkit [148380] by
-
- 2 edits in trunk/Source/WebCore
Fix three crashes seen on the bots after "Make Frame's ScriptController an OwnPtr and remove the #include"
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open):
Check that the frame is not null (as it can be in cases like http/tests/xmlhttprequest/detaching-frame-2.html).
We used to be getting lucky, in that shouldBypassMainWorldContentSecurityPolicy(), the function that is ultimately
called, only operates on global state. Now that we need to actually dereference the Frame to get the ScriptController,
we see this crash.
- 9:06 PM Changeset in webkit [148379] by
-
- 2 edits in trunk/Tools
Build fix attempt for webkitbot. Unicodify everything.
- Scripts/webkitpy/tool/bot/irc_command.py:
(Whois.execute):
- 8:55 PM Changeset in webkit [148378] by
-
- 3 edits2 adds in trunk
Selection direction is not preserved when applying styles
https://bugs.webkit.org/show_bug.cgi?id=110979
Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2013-04-13
Reviewed by Ryosuke Niwa.
Source/WebCore:
The patch is based on the one submitted by Shezan Baig.
If the starting selection was directional and its base was not first,
switch newStart and newEnd when setting the ending direction. Otherwise,
leave the order unchanged.
Test: editing/style/preserve-selection-direction.html
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::updateStartEnd):
LayoutTests:
Add a test, based on the work by Shezan Baig
- editing/style/preserve-selection-direction-expected.txt: Added.
- editing/style/preserve-selection-direction.html: Added.
- 8:02 PM Changeset in webkit [148377] by
-
- 2 edits in trunk/Source/WebCore
Added svn:ignore for inspector/CodeGeneratorInspectorStrings.pyc
- inspector: Added property svn:ignore.
- 7:12 PM Changeset in webkit [148376] by
-
- 5 edits in trunk/Source/WebKit2
Add ObjC API for setting initialization data for the WKWebProcessPlugIn
https://bugs.webkit.org/show_bug.cgi?id=103846
Reviewed by Darin Adler.
- UIProcess/API/mac/WKProcessGroup.h:
Adds a new optional processGroupWillCreateConnectionToWebProcessPlugIn: method for the WKProcessGroupDelegate protocol,
which allows the user to pass (via an autoreleased return value) initialization data to the web process plugin.
- UIProcess/API/mac/WKProcessGroup.mm:
(getInjectedBundleInitializationUserData):
(setUpInectedBundleClient):
(-[WKProcessGroup initWithInjectedBundleURL:]):
(-[WKProcessGroup dealloc]):
Use the existing WKContextInjectedBundleClient infrastructure to pass the initialization data to the bundle
via the new ObjCObjectGraph APIObject.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:
Adds webProcessPlugIn:initializeWithObject: to the WKWebProcessPlugIn protocol, replacing webProcessPlugInInitialize:.
- WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::load):
Pass the initialization data to the web process plugin.
- 7:00 PM Changeset in webkit [148375] by
-
- 2 edits in branches/safari-536.30-branch/Source/JavaScriptCore
Attempt to fix Windows build after r148370
Try to fix the following build failure:
4>JSStringJoiner.cpp
4>..\..\runtime\JSStringJoiner.cpp(112) : error C2653: 'CheckedState' : is not a class or namespace name
4>..\..\runtime\JSStringJoiner.cpp(112) : error C2065: 'DidOverflow' : undeclared identifier
4>..\..\runtime\JSStringJoiner.cpp(112) : warning C4805: '==' : unsafe mix of type 'bool' and type unknown-type in operation
- runtime/JSStringJoiner.h: Include <wtf/CheckedArithmetic.h>.
- 6:27 PM Changeset in webkit [148374] by
-
- 2 edits in trunk/Source/WebKit2
Attempt Build Fix.
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
- 5:54 PM Changeset in webkit [148373] by
-
- 88 edits in trunk/Source
Make Frame's ScriptController an OwnPtr and remove the #include
https://bugs.webkit.org/show_bug.cgi?id=114105
Reviewed by Dean Jackson.
Source/WebCore:
- Modules/websockets/WebSocket.cpp:
- bindings/generic/BindingSecurity.cpp:
- bindings/js/JSEventListener.cpp:
- bindings/js/JSLazyEventListener.cpp:
- bindings/js/PageScriptDebugServer.cpp:
- bindings/js/ScriptEventListener.cpp:
- bindings/js/ScriptState.cpp:
- bindings/objc/DOM.mm:
- bindings/objc/DOMAbstractView.mm:
- bindings/objc/DOMInternal.mm:
- dom/DocumentStyleSheetCollection.cpp:
- dom/EventTarget.cpp:
- dom/ScriptElement.cpp:
- history/CachedFrame.cpp:
- html/HTMLCanvasElement.cpp:
- html/HTMLDocument.cpp:
- html/HTMLElement.cpp:
- html/HTMLFormElement.cpp:
- html/HTMLPlugInElement.cpp:
- html/HTMLPlugInImageElement.cpp:
- html/parser/HTMLParserOptions.cpp:
- inspector/InspectorAgent.cpp:
- inspector/InspectorController.cpp:
- inspector/InspectorFrontendClientLocal.cpp:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorInstrumentation.cpp:
- inspector/InspectorOverlay.cpp:
- inspector/InspectorPageAgent.cpp:
- inspector/PageRuntimeAgent.cpp:
- loader/DocumentWriter.cpp:
- loader/NavigationScheduler.cpp:
- loader/SubframeLoader.cpp:
- loader/cache/CachedResourceLoader.cpp:
- page/DOMWindow.cpp:
- page/EventSource.cpp:
- page/Frame.cpp:
- page/Frame.h:
- page/Navigator.cpp:
- page/Page.cpp:
- page/PageGroup.cpp:
- xml/XMLHttpRequest.cpp:
- xml/XMLTreeViewer.cpp:
Source/WebKit/mac:
- Plugins/Hosted/HostedNetscapePluginStream.mm:
- Plugins/WebNetscapePluginStream.mm:
- Plugins/WebPluginContainerCheck.mm:
- WebCoreSupport/WebGeolocationClient.mm:
- WebCoreSupport/WebInspectorClient.mm:
- WebView/WebFrame.mm:
Source/WebKit2:
- Shared/WebHitTestResult.cpp:
- Shared/WebHitTestResult.h:
- UIProcess/Plugins/PlugInAutoStartProvider.cpp:
- UIProcess/WebContext.h:
- UIProcess/WebPageProxy.h:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
- WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
- WebProcess/Plugins/PDF/PDFPlugin.h:
- WebProcess/Plugins/PluginView.cpp:
- WebProcess/Storage/StorageAreaImpl.cpp:
- WebProcess/Storage/StorageAreaMap.cpp:
- WebProcess/WebPage/WebFrame.cpp:
- WebProcess/WebPage/WebPage.cpp:
- 5:46 PM Changeset in webkit [148372] by
-
- 5 edits in trunk/Tools
webkitbot should provide full name, email address, and IRC nicknames on whois
https://bugs.webkit.org/show_bug.cgi?id=114494
Reviewed by Benjamin Poulain.
A response like the one below is useless. Improve it:
webkitbot: rniwa: zdobersek is zdobersek (zandobersek@gmail.com). Why do you ask?
We now report full name, email address, committer/reviewer status, and IRC nickname.
Also teach webkitbot how to respond to ping.
- Scripts/webkitpy/tool/bot/irc_command.py:
(PingPong): Moved
(PingPong.execute):
(Whois._full_record_and_nick): Renamed and rewritten.
(Whois.execute):
- Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_whois): Updated test cases as needed.
- Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_help): Added ping.
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot): Teached WKR how to respond to hi.
- 5:28 PM Changeset in webkit [148371] by
-
- 5 edits in trunk/Websites/bugs.webkit.org
Delete bubbles from webkit-commit-queue.appspot.com now that we've completed the transition
https://bugs.webkit.org/show_bug.cgi?id=114476
Reviewed by Gyuyoung Kim.
- code-review.js:
- template/en/custom/attachment/edit.html.tmpl:
- template/en/custom/attachment/list.html.tmpl:
- template/en/custom/attachment/reviewform.html.tmpl:
- 4:15 PM Changeset in webkit [148370] by
-
- 7 edits in branches/safari-536.30-branch
Merge 145580, 145587, 145594, r145595, r145647, 145759. Part 2/2 for <rdar://problem/13438603>.
- 4:15 PM Changeset in webkit [148369] by
-
- 2 edits1 add in branches/safari-536.30-branch/Source/WTF
Merge r141499, r141950, r141965. Part 1/2 for <rdar://problem/13438603>.
Add Source/WTF/wtf/EnumClass.h
- 3:28 PM Changeset in webkit [148368] by
-
- 14 edits1 add in trunk
Add form delegate method that's invoked right before sending a submit event to a form element
https://bugs.webkit.org/show_bug.cgi?id=114575
Reviewed by Dan Bernstein.
Source/WebCore:
- WebCore.exp.in:
Export a symbol.
- WebCore.xcodeproj/project.pbxproj:
Make DOMHTMLFormElementInternal.h a private header.
Source/WebKit/mac:
- MigrateHeaders.make:
Copy DOMHTMLFormElementInternal.h over to WebKit.
- WebCoreSupport/WebFrameLoaderClient.mm:
(makeFormFieldValuesDictionary):
New helper function that returns the values of a form in dictionary form.
(WebFrameLoaderClient::dispatchWillSendSubmitEvent):
Call the right delegate method.
(WebFrameLoaderClient::dispatchWillSubmitForm):
Use the helper function.
- WebView/WebDelegateImplementationCaching.h:
- WebView/WebDelegateImplementationCaching.mm:
(CallFormDelegate):
Add another overload.
- WebView/WebFormDelegate.h:
- WebView/WebFormDelegate.m:
(-[WebFormDelegate willSendSubmitEventToForm:inFrame:withValues:]):
Add a default implementation.
Tools:
Add a test.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm: Added.
(-[FormDelegate willSendSubmitEventToForm:inFrame:withValues:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):
- TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::toSTD):
Don't crash when a null NSString is passed to toSTD.
- 3:01 PM Changeset in webkit [148367] by
-
- 3 edits4 adds in trunk
Whitespace between nowrap elements ignored after collapsed trailing space in a text run
https://bugs.webkit.org/show_bug.cgi?id=17705
Reviewed by Ryosuke Niwa.
Source/WebCore:
Bug 93448 and r138654 fixed the treatment of line-breaks between nowrap elements. This augments
that fix by recognizing that we have a potential break not only in situations where the next character is a
space and the current character is not, but also where the next character is a space and the current character
*is* a space *and* we are ignoring spaces. This is so because any spaces we have ignored up to this point
after the actual word end will get collapsed away even if we don't end up taking the line break.
In a nutshell, if we allow whitespace collapsing 'word ' and 'word' are equivalent when before a whitespace
character, so treat the first as well as the second as a potential linebreak.
Test: fast/text/whitespace/inline-whitespace-wrapping-5.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
LayoutTests:
- fast/text/whitespace/inline-whitespace-wrapping-5-expected.html: Added.
- fast/text/whitespace/inline-whitespace-wrapping-5.html: Added.
- fast/text/whitespace/inline-whitespace-wrapping-6-expected.html: Added.
- fast/text/whitespace/inline-whitespace-wrapping-6.html: Added.
- 2:49 PM Changeset in webkit [148366] by
-
- 4 edits3 copies in branches/safari-536.30-branch
Merged r136845. <rdar://problem/13334927>
- 2:11 PM QtWebKit edited by
- Add QupZilla Web Browser which also uses QtWebKit (diff)
- 1:03 PM Changeset in webkit [148365] by
-
- 19 edits in trunk/Source
Rename/tweak some StylePropertySet/CSSStyleDeclaration copying functions.
<http://webkit.org/b/114569>
Reviewed by Anders Carlsson.
- StylePropertySet::copy() -> mutableCopy()
This function now returns a MutableStylePropertySet, and this is also reflected in the name.
- CSSStyleDeclaration::copy() -> copyProperties()
Renamed to reflect that it's the properties being copied, not the CSSStyleDeclaration.
They also now return MutableStylePropertySets.
- StylePropertySet::copyPropertiesInSet()
- CSSStyleDeclaration::copyPropertiesInSet()
These functions now return MutableStylePropertySets.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::copyProperties):
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):
- css/CSSComputedStyleDeclaration.h:
(CSSComputedStyleDeclaration):
- css/CSSStyleDeclaration.h:
(CSSStyleDeclaration):
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::copyProperties):
- css/PropertySetCSSStyleDeclaration.h:
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::mutableCopy):
(WebCore::StylePropertySet::copyPropertiesInSet):
- css/StylePropertySet.h:
(StylePropertySet):
- css/StyleRule.cpp:
(WebCore::StyleRule::StyleRule):
(WebCore::StyleRule::mutableProperties):
(WebCore::StyleRulePage::StyleRulePage):
(WebCore::StyleRulePage::mutableProperties):
(WebCore::StyleRuleFontFace::StyleRuleFontFace):
(WebCore::StyleRuleFontFace::mutableProperties):
(WebCore::StyleRuleViewport::StyleRuleViewport):
(WebCore::StyleRuleViewport::mutableProperties):
(WebCore::StyleRuleFilter::StyleRuleFilter):
(WebCore::StyleRuleFilter::mutableProperties):
- css/ViewportStyleResolver.cpp:
(WebCore::ViewportStyleResolver::addViewportRule):
- css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::mutableProperties):
- dom/Element.cpp:
(WebCore::UniqueElementData::UniqueElementData):
- dom/StyledElement.cpp:
(WebCore::StyledElement::ensureMutableInlineStyle):
- editing/ApplyStyleCommand.cpp:
(WebCore::copyStyleOrCreateEmpty):
- editing/EditingStyle.cpp:
(WebCore::copyEditingProperties):
(WebCore::editingStyleFromComputedStyle):
(WebCore::EditingStyle::EditingStyle):
(WebCore::EditingStyle::init):
(WebCore::EditingStyle::copy):
(WebCore::EditingStyle::mergeStyle):
(WebCore::getPropertiesNotIn):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::copyTypingStyle):
- 11:19 AM Changeset in webkit [148364] by
-
- 8 edits in branches/safari-536.30-branch/Source/WebKit2
Merged r147512. <rdar://problem/13380323>
- 11:00 AM Changeset in webkit [148363] by
-
- 11 edits2 moves in trunk/Source/WebCore
Rename StyleBuilder to DeprecatedStyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=114532
Reviewed by Benjamin Poulain.
The StyleBuilder code is hard to read and maintain. People should
not add new properties to this class. To make this clear, this
patch renames the class to DeprecatedStyleBuilder.
Pure refactoring, no change in functionality.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
- css/DeprecatedStyleBuilder.cpp: Renamed from Source/WebCore/css/StyleBuilder.cpp.
- css/DeprecatedStyleBuilder.h: Renamed from Source/WebCore/css/StyleBuilder.h.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::reportMemoryUsage):
- css/StyleResolver.h:
(StyleResolver):
- rendering/style/RenderStyle.h:
- 10:56 AM Changeset in webkit [148362] by
-
- 2 edits in trunk/Tools
Python test fix attempt after r148360.
- Scripts/webkitpy/tool/multicommandtool_unittest.py:
(test_command_help):
- 10:53 AM Changeset in webkit [148361] by
-
- 2 edits in trunk/LayoutTests
Update Mac WebKit2 test expectations for flaky and failing tests.
- platform/mac-wk2/TestExpectations:
- 10:39 AM Changeset in webkit [148360] by
-
- 19 edits in trunk/Tools
Merge AbstractDeclarativeCommand into Command as a comment suggests
https://bugs.webkit.org/show_bug.cgi?id=114559
Reviewed by Antti Koivisto.
Merged two classes as the comment right above AbstractDeclarativeCommand suggested.
We need to merge a lot more classes to make webkitpy hackable.
- Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
(AbstractLocalServerCommand):
(AbstractLocalServerCommand.init):
- Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
(AbstractSequencedCommand):
(AbstractSequencedCommand.init):
- Scripts/webkitpy/tool/commands/adduserstogroups.py:
(AddUsersToGroups):
- Scripts/webkitpy/tool/commands/analyzechangelog.py:
(AnalyzeChangeLog):
(AnalyzeChangeLog.init):
- Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
- Scripts/webkitpy/tool/commands/bugfortest.py:
(BugForTest):
- Scripts/webkitpy/tool/commands/bugsearch.py:
(BugSearch):
- Scripts/webkitpy/tool/commands/chromechannels.py:
(ChromeChannels):
(init):
- Scripts/webkitpy/tool/commands/download.py:
(AbstractPatchProcessingCommand):
- Scripts/webkitpy/tool/commands/findusers.py:
(FindUsers):
- Scripts/webkitpy/tool/commands/openbugs.py:
(OpenBugs):
- Scripts/webkitpy/tool/commands/queries.py:
(BugsToCommit):
(PatchesInCommitQueue):
(PatchesToCommitQueue):
(PatchesToCommitQueue.init):
(PatchesToReview):
(PatchesToReview.init):
(PatchesToReview.execute):
(WhatBroke):
(ResultsFor):
(FailureReason):
(FindFlakyTests):
(TreeStatus):
(CrashLog):
(PrintExpectations):
(PrintExpectations.init):
(PrintBaselines):
(PrintBaselines.init):
- Scripts/webkitpy/tool/commands/queues.py:
(AbstractQueue.init):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractRebaseliningCommand):
- Scripts/webkitpy/tool/commands/suggestnominations.py:
(SuggestNominations):
(SuggestNominations.init):
- Scripts/webkitpy/tool/commands/upload.py:
(CommitMessageForCurrentDiff):
(CommitMessageForCurrentDiff.init):
(CleanPendingCommit):
(CleanReviewQueue):
(AssignToCommitter):
(PostCommits):
(PostCommits.init):
(MarkBugFixed):
(MarkBugFixed.init):
(CreateBug):
(CreateBug.init):
- Scripts/webkitpy/tool/multicommandtool.py:
(Command):
(Command.init):
(Command.main):
(HelpCommand):
(HelpCommand.init):
- Scripts/webkitpy/tool/multicommandtool_unittest.py:
(TrivialCommand):
(TrivialCommand.init):
(LikesToRetry):
(LikesToRetry.init):
(CommandTest.test_name_with_arguments):
(CommandTest.test_required_arguments):
(test_command_help):
- 9:43 AM Changeset in webkit [148359] by
-
- 6 edits in trunk/Source/WebCore
Remove unused method CSSStyleDeclaration::makeMutable().
<http://webkit.org/b/114567>
Reviewed by Anders Carlsson.
- css/CSSComputedStyleDeclaration.cpp:
- css/CSSComputedStyleDeclaration.h:
(CSSComputedStyleDeclaration):
- css/CSSStyleDeclaration.h:
(CSSStyleDeclaration):
- css/PropertySetCSSStyleDeclaration.cpp:
- css/PropertySetCSSStyleDeclaration.h:
- 9:38 AM Changeset in webkit [148358] by
-
- 3 edits2 adds in trunk
Width of last of consecutive tabs may be incorrect with "white-space: pre-wrap"
https://bugs.webkit.org/show_bug.cgi?id=114562
Reviewed by Dan Bernstein.
Source/WebCore:
When we measure the last word of a RenderText, make sure we use the correct x
position taking into account the current accumulated word measurements up to
this character. This is of particular importance in the case of tabs where the
measured width would differ based on the x position.
Test: fast/text/tab-last-word-in-renderer-pre-wrap.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::setLogicalWidthForTextRun):
LayoutTests:
- fast/text/tab-last-word-in-renderer-pre-wrap-expected.html: Added.
- fast/text/tab-last-word-in-renderer-pre-wrap.html: Added.
- 9:07 AM Changeset in webkit [148357] by
-
- 2 edits in trunk/Source/WebCore
[Windows, WinCairo] ImageBufferCairo.cpp fails to compile after 148247, 148264.
https://bugs.webkit.org/show_bug.cgi?id=114540
Patch by Mark Salisbury <mark.salisbury@hp.com> on 2013-04-13
Reviewed by Brent Fulgham.
- platform/graphics/cairo/ImageBufferCairo.cpp:
- 7:09 AM Changeset in webkit [148356] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add missing export macro to SymbolTableEntry::freeFatEntrySlow()
- runtime/SymbolTable.h:
(SymbolTableEntry):
- 5:04 AM Changeset in webkit [148355] by
-
- 5 edits in trunk
[EFL] --minimal build fails with error: 'ViewModeInvalid' is not a member of 'WebCore::Page'
https://bugs.webkit.org/show_bug.cgi?id=114048
Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-13
Reviewed by Gyuyoung Kim.
Source/WebKit/efl:
Wrapped view-mode media related code into #if ENABLE(VIEW_MODE_CSS_MEDIA)
- WebCoreSupport/AssertMatchingEnums.cpp:
- ewk/ewk_view.cpp:
(ewk_view_mode_set):
Tools:
Wrapped view media related code in #if ENABLE(VIEW_MODE_CSS_MEDIA)
- DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::setViewModeMediaFeature):
- 2:47 AM Changeset in webkit [148354] by
-
- 2 edits2 deletes in trunk/Tools
Merge watchlistloader into host since it's an unnecessary indirection
https://bugs.webkit.org/show_bug.cgi?id=114555
Reviewed by Antti Koivisto.
We don't need a class to load a file.
- Scripts/webkitpy/common/host.py:
(Host.watch_list):
- Scripts/webkitpy/common/watchlist/watchlistloader.py: Removed.
- Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Removed.
- 1:16 AM Changeset in webkit [148353] by
-
- 4 edits in trunk/Tools
Rename JSONResultsGeneratorBase to JSONResultsGenerator
https://bugs.webkit.org/show_bug.cgi?id=114553
Reviewed by Philippe Normand.
Renamed now that we've got rid of the old JSONResultsGenerator in r148352.
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
(JSONLayoutResultsGenerator):
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGenerator):
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
(JSONGeneratorTest._test_json_generation):
(JSONGeneratorTest._verify_json_results):
- 1:02 AM Changeset in webkit [148352] by
-
- 8 edits in trunk/Tools
Remove more Chromium specific code from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=114552
Reviewed by Philippe Normand.
- Scripts/webkitpy/common/host.py:
(Host.checkout):
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGeneratorBase):
(JSONResultsGeneratorBase.init):
(JSONResultsGeneratorBase._is_results_all_of_type):
- Scripts/webkitpy/layout_tests/port/base.py:
(Port):
(Port.expected_filename):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
- Scripts/webkitpy/tool/commands/queues.py:
(PatchProcessingQueue._new_port_name_from_old):
(CommitQueue.did_pass_testing_ews):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._results_url):
(Rebaseline._builder_with_name):
- Scripts/webkitpy/tool/mocktool.py:
(MockTool.irc):
- 12:56 AM Changeset in webkit [148351] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed GTK build fix after r148311.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(resizeWebKitWebViewBaseFromAllocation): Passing IntSize() as the scroll offset
argument to the DrawingAreaProxy::setSize method.
- 12:53 AM Changeset in webkit [148350] by
-
- 4 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Fix release build.
- dfg/DFGOSRExitCompilerCommon.cpp:
- ftl/FTLExitValue.cpp:
- ftl/FTLOSRExitCompiler.cpp:
- 12:40 AM Changeset in webkit [148349] by
-
- 3 edits in trunk/Tools
Fix flakiness dashboard unit test failures
https://bugs.webkit.org/show_bug.cgi?id=114518
Reviewed by Ryosuke Niwa.
Fix the current failures in unit tests for the flakiness dashboard by adjusting failing
test cases to simulate loading the builders list from the webkit.org build master, replacing
the Chromium builders and platforms that are used in tests with builders and platforms for the
Apple Mac Lion WebKit2 port, and removing two test cases that were testing Chromium-specific
functionality of the dashboard.
This is sort of an interlude to the flakiness dashboard cleanup, with the removal of Chromium-specific
code and hopefully general simplification of the dashboard codebase coming in near future.
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(resetGlobals):
(test):
- TestResultServer/static-dashboards/loader_unittests.js:
- 12:38 AM Changeset in webkit [148348] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed GTK build fix after r148305.
- GNUmakefile.list.am: Adding the TrackListBase build targets to the build.
- 12:38 AM Changeset in webkit [148347] by
-
- 35 edits26 adds in branches/dfgFourthTier/Source
fourthTier: FTL should have OSR exit
https://bugs.webkit.org/show_bug.cgi?id=113623
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
This implements OSR exit, and hilariously, it actually works. The idea is to have
LLVM call a no-return function on the off-ramp, passing it everything we know about
bytecode state that isn't already flushed to the call frame. Our own JIT takes care
of the rest.
We can now run all of SunSpider, V8, and Kraken with the FTL enabled.
The details are described in FTLOSRExit.h.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- assembler/AbstractMacroAssembler.h:
(Address):
(JSC::AbstractMacroAssembler::Address::withOffset):
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::offsetOf):
(LinkBuffer):
- assembler/MacroAssemblerX86Common.h:
- assembler/RepatchBuffer.h:
(JSC::RepatchBuffer::RepatchBuffer):
(JSC::RepatchBuffer::~RepatchBuffer):
(RepatchBuffer):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::tallyFrequentExitSites):
- bytecode/Operands.h:
(Operands):
(JSC):
(JSC::::dump):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
- dfg/DFGGPRInfo.h:
(DFG):
(GPRInfo):
- dfg/DFGMinifiedNode.h:
(JSC::DFG::belongsInMinifiedGraph):
- dfg/DFGNodeType.h:
(JSC::DFG::needsOSRBackwardRewiring):
(DFG):
(JSC::DFG::needsOSRForwardRewiring):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
(DFG):
(JSC::DFG::OSRExit::convertToForward):
- dfg/DFGOSRExit.h:
(OSRExit):
- dfg/DFGOSRExitBase.cpp: Added.
(DFG):
(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSiteSlow):
(JSC::DFG::OSRExitBase::doSearchForForwardConversion):
- dfg/DFGOSRExitBase.h: Added.
(DFG):
(JSC::DFG::OSRExitBase::OSRExitBase):
(OSRExitBase):
(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSite):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::handleExitCounts):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):
- dfg/DFGOSRExitCompilerCommon.h:
(DFG):
- dfg/DFGOSRExitPreparation.cpp: Added.
(DFG):
(JSC::DFG::prepareCodeOriginForOSRExit):
- dfg/DFGOSRExitPreparation.h: Added.
(DFG):
- dfg/DFGOperations.cpp:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
- dfg/DFGValueSource.h:
(JSC::DFG::ValueSource::forSpeculation):
- dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):
- ftl/FTLAbbreviations.h:
(JSC::FTL::functionType):
(FTL):
(JSC::FTL::typeOf):
(JSC::FTL::appendBasicBlock):
(JSC::FTL::insertBasicBlock):
(JSC::FTL::buildCall):
(JSC::FTL::setTailCall):
- ftl/FTLCArgumentGetter.cpp: Added.
(FTL):
(JSC::FTL::CArgumentGetter::loadNextAndBox):
- ftl/FTLCArgumentGetter.h: Added.
(FTL):
(JSC::FTL::isArgumentRegister):
(CArgumentGetter):
(JSC::FTL::CArgumentGetter::CArgumentGetter):
(JSC::FTL::CArgumentGetter::loadNext8):
(JSC::FTL::CArgumentGetter::loadNext32):
(JSC::FTL::CArgumentGetter::loadNext64):
(JSC::FTL::CArgumentGetter::loadNextPtr):
(JSC::FTL::CArgumentGetter::loadNextDouble):
(JSC::FTL::CArgumentGetter::nextAddress):
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLExitArgument.cpp: Added.
(FTL):
(JSC::FTL::ExitArgument::dump):
- ftl/FTLExitArgument.h: Added.
(FTL):
(ExitArgumentRepresentation):
(ExitArgument):
(JSC::FTL::ExitArgument::ExitArgument):
(JSC::FTL::ExitArgument::operator!):
(JSC::FTL::ExitArgument::format):
(JSC::FTL::ExitArgument::argument):
(JSC::FTL::ExitArgument::withFormat):
(JSC::FTL::ExitArgument::representation):
- ftl/FTLExitArgumentForOperand.cpp: Added.
(FTL):
(JSC::FTL::ExitArgumentForOperand::dump):
- ftl/FTLExitArgumentForOperand.h: Added.
(FTL):
(ExitArgumentForOperand):
(JSC::FTL::ExitArgumentForOperand::ExitArgumentForOperand):
(JSC::FTL::ExitArgumentForOperand::operator!):
(JSC::FTL::ExitArgumentForOperand::exitArgument):
(JSC::FTL::ExitArgumentForOperand::operand):
(JSC::FTL::lesserArgumentIndex):
- ftl/FTLExitArgumentList.h: Added.
(FTL):
- ftl/FTLExitThunkGenerator.cpp: Added.
(FTL):
(JSC::FTL::ExitThunkGenerator::ExitThunkGenerator):
(JSC::FTL::ExitThunkGenerator::~ExitThunkGenerator):
(JSC::FTL::ExitThunkGenerator::emitThunk):
- ftl/FTLExitThunkGenerator.h: Added.
(FTL):
(ExitThunkGenerator):
(JSC::FTL::ExitThunkGenerator::didThings):
- ftl/FTLExitValue.cpp: Added.
(FTL):
(JSC::FTL::ExitValue::dump):
- ftl/FTLExitValue.h: Added.
(FTL):
(ExitValue):
(JSC::FTL::ExitValue::ExitValue):
(JSC::FTL::ExitValue::operator!):
(JSC::FTL::ExitValue::dead):
(JSC::FTL::ExitValue::inJSStack):
(JSC::FTL::ExitValue::inJSStackAsInt32):
(JSC::FTL::ExitValue::inJSStackAsDouble):
(JSC::FTL::ExitValue::constant):
(JSC::FTL::ExitValue::exitArgument):
(JSC::FTL::ExitValue::kind):
(JSC::FTL::ExitValue::isDead):
(JSC::FTL::ExitValue::isInJSStackSomehow):
(JSC::FTL::ExitValue::isConstant):
(JSC::FTL::ExitValue::isArgument):
- ftl/FTLFormattedValue.h:
(FTL):
(JSC::FTL::noValue):
(JSC::FTL::int32Value):
(JSC::FTL::uInt32Value):
(JSC::FTL::booleanValue):
(JSC::FTL::jsValueValue):
(JSC::FTL::doubleValue):
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::initializeExitThunks):
(FTL):
(JSC::FTL::JITCode::exitThunks):
- ftl/FTLJITCode.h:
(JITCode):
- ftl/FTLLowerDFGToLLVM.cpp:
(FTL):
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::transferAndCheckArguments):
(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetLocal):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileMovHint):
(JSC::FTL::LowerDFGToLLVM::compileZombieHint):
(JSC::FTL::LowerDFGToLLVM::compileMovHintAndCheck):
(JSC::FTL::LowerDFGToLLVM::compileAdd):
(JSC::FTL::LowerDFGToLLVM::compileArithSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::LowerDFGToLLVM::compileUInt32ToNumber):
(JSC::FTL::LowerDFGToLLVM::compileCheckStructure):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::speculateBackward):
(JSC::FTL::LowerDFGToLLVM::speculateForward):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::terminate):
(JSC::FTL::LowerDFGToLLVM::backwardTypeCheck):
(JSC::FTL::LowerDFGToLLVM::forwardTypeCheck):
(JSC::FTL::LowerDFGToLLVM::typeCheck):
(JSC::FTL::LowerDFGToLLVM::appendTypeCheck):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::speculateObject):
(JSC::FTL::LowerDFGToLLVM::isLive):
(JSC::FTL::LowerDFGToLLVM::use):
(JSC::FTL::LowerDFGToLLVM::initializeOSRExitStateForBlock):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
(JSC::FTL::LowerDFGToLLVM::tryToSetConstantExitArgument):
(JSC::FTL::LowerDFGToLLVM::addExitArgument):
(JSC::FTL::LowerDFGToLLVM::linkOSRExitsAndCompleteInitializationBlocks):
(JSC::FTL::LowerDFGToLLVM::observeMovHint):
- ftl/FTLOSRExit.cpp: Added.
(FTL):
(JSC::FTL::OSRExit::OSRExit):
(JSC::FTL::OSRExit::codeLocationForRepatch):
(JSC::FTL::OSRExit::convertToForward):
- ftl/FTLOSRExit.h: Added.
(FTL):
(OSRExit):
- ftl/FTLOSRExitCompilationInfo.h: Added.
(FTL):
(JSC::FTL::OSRExitCompilationInfo::OSRExitCompilationInfo):
(OSRExitCompilationInfo):
- ftl/FTLOSRExitCompiler.cpp: Added.
(FTL):
(JSC::FTL::compileStub):
(JSC::FTL::compileFTLOSRExit):
- ftl/FTLOSRExitCompiler.h: Added.
(FTL):
- ftl/FTLOutput.h:
(JSC::FTL::Output::newBlock):
(JSC::FTL::Output::intToPtr):
(JSC::FTL::Output::load):
(JSC::FTL::Output::store):
(Output):
(JSC::FTL::Output::call):
(JSC::FTL::Output::convertToTailCall):
(FTL):
- ftl/FTLState.h:
(State):
- ftl/FTLThunks.cpp: Added.
(FTL):
(JSC::FTL::osrExitGenerationThunkGenerator):
- ftl/FTLThunks.h: Added.
(JSC):
(FTL):
- ftl/FTLValueFormat.cpp: Added.
(WTF):
(WTF::printInternal):
- ftl/FTLValueFormat.h: Added.
(FTL):
(WTF):
- ftl/FTLValueSource.cpp: Added.
(FTL):
(JSC::FTL::ValueSource::dump):
- ftl/FTLValueSource.h: Added.
(FTL):
(ValueSource):
(JSC::FTL::ValueSource::ValueSource):
(JSC::FTL::ValueSource::kind):
(JSC::FTL::ValueSource::operator!):
(JSC::FTL::ValueSource::node):
Source/WTF:
Reviewed by Oliver Hunt.
Finally make toCString() somewhat variadic.
- wtf/StringPrintStream.h:
(WTF):
(WTF::toCString):
Apr 12, 2013:
- 9:39 PM Changeset in webkit [148346] by
-
- 2 edits in branches/safari-536.30-branch/Source/WebKit2
Merged r148284. <rdar://problem/13335003>
- 9:23 PM Changeset in webkit [148345] by
-
- 3 edits in branches/safari-536.30-branch/Source/WebCore
Merged 140893. <rdar://problem/13334946>
- 9:18 PM Changeset in webkit [148344] by
-
- 5 edits in branches/safari-536.30-branch/Source/WebCore
Merged r141315. <rdar://problem/13334946>
- 9:15 PM Changeset in webkit [148343] by
-
- 4 edits in branches/safari-536.30-branch/Source/WebCore
Merged r140886. <rdar://problem/13334946>
- 8:52 PM Changeset in webkit [148342] by
-
- 8 edits in branches/safari-536.30-branch/Source/WebCore
Merged r140892. <rdar://problem/13334946>
- 8:15 PM Changeset in webkit [148341] by
-
- 4 edits in branches/safari-536.30-branch/Source/WebCore
Merged r140891. <rdar://problem/13334946>
- 8:09 PM Changeset in webkit [148340] by
-
- 9 edits2 copies in branches/safari-536.30-branch
Merged r140748. <rdar://problem/13334946>
- 7:38 PM Changeset in webkit [148339] by
-
- 2 edits in branches/safari-536.30-branch/Source/WebKit2
Merged r141445. <rdar://problem/13266396>
- 7:32 PM Changeset in webkit [148338] by
-
- 2 edits in branches/safari-536.30-branch/Source/WebKit2
Merged r141445. <rdar://problem/13335003>
- 7:08 PM Changeset in webkit [148337] by
-
- 1 edit2 copies in branches/safari-536.30-branch/LayoutTests
Merged r136596. <rdar://problem/13334868>
- 7:02 PM Changeset in webkit [148336] by
-
- 2 edits6 copies in branches/safari-536.30-branch/LayoutTests
Merged r133701. <rdar://problem/13334976>
- 7:00 PM Changeset in webkit [148335] by
-
- 2 edits in branches/safari-536.30-branch/Source/WebCore
Merged r129814. <rdar://problem/13334978>
- 6:52 PM Changeset in webkit [148334] by
-
- 5 edits in branches/safari-536.30-branch/LayoutTests
Merged r128747. <rdar://problem/13266379>
- 6:47 PM Changeset in webkit [148333] by
-
- 3 edits in branches/safari-536.30-branch/LayoutTests
Merged r123167. <rdar://problem/13266379>
- 6:44 PM Changeset in webkit [148332] by
-
- 3 edits in branches/safari-536.30-branch/Source/WebCore
Merged r143565, <rdar://problem/13334867>
- 6:37 PM Changeset in webkit [148331] by
-
- 7 edits in trunk/Source/WebKit2
Add private interface to WKView to asynchronously update the drawing area size
https://bugs.webkit.org/show_bug.cgi?id=114549
Reviewed by Simon Fraser.
This will allow a client using the WKView to resize the contents without blocking waiting for the web process to repaint.
- UIProcess/API/mac/WKView.mm:
(-[WKView _setDrawingAreaSize:]):
- if the new size of teh drawing area does not match the frame size, position it according to the contentAnchor.
(-[WKView updateLayer]):
- Don't let a subsequent frame size change block on a prior async resize.
(-[WKView forceAsyncDrawingAreaSizeUpdate:]):
- resize the drawing area asynchronously, even if frame size udpates are disabled.
(-[WKView waitForAsyncDrawingAreaSizeUpdate]):
- wait for asynchronous updates to complete.
- UIProcess/API/mac/WKViewPrivate.h:
- declare new methods.
- UIProcess/DrawingAreaProxy.cpp:
(WebKit):
- UIProcess/DrawingAreaProxy.h:
(DrawingAreaProxy):
(WebKit::DrawingAreaProxy::waitForPossibleGeometryUpdate):
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
(TiledCoreAnimationDrawingAreaProxy):
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::waitForPossibleGeometryUpdate):
- pass timeout for waitForPossibleGeometryUpdate as a parameter.
- 6:25 PM Changeset in webkit [148330] by
-
- 2 edits in trunk/Source/WebKit2
32-bit build fix.
- UIProcess/API/mac/WKView.mm:
(-[WKView setFrameSize:]):
- 6:09 PM Changeset in webkit [148329] by
-
- 8 edits in trunk
Query directly for cache partition names
https://bugs.webkit.org/show_bug.cgi?id=114538
Reviewed by David Kilzer.
Source/WebKit2:
Call back into WebKitSystemInterface to ask it for the cache
partition names instead of trying to figure them out.
- WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::getCacheOrigins):
(WebKit):
(WebKit::WebResourceCacheManager::returnCacheOrigins):
- WebProcess/ResourceCache/WebResourceCacheManager.h:
(WebResourceCacheManager):
- WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:
(WebKit::WebResourceCacheManager::cfURLCacheHostNames):
(WebKit):
(WebKit::WebResourceCacheManager::cfURLCacheHostNamesWithCallback):
WebKitLibraries:
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- 6:02 PM Changeset in webkit [148328] by
-
- 2 edits in trunk/Tools
BUILD FIX: Make AccessibilityUIElementIOS.mm build on iOS
Reviewed by Chris Fleizach.
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Declare
-_accessibilityPath from the WebAccessibilityObjectWrapper
class.
(_CGPathEnumerationIteration): Remove unused CGPoint* variable.
- 5:55 PM Changeset in webkit [148327] by
-
- 5 edits2 adds in branches/safari-536.30-branch
Merge r132856. <rdar://problem/13334380>
- 5:49 PM Changeset in webkit [148326] by
-
- 4 edits2 adds in branches/safari-536.30-branch
Merge r131488. <rdar://problem/13334380>
- 5:46 PM Changeset in webkit [148325] by
-
- 3 edits2 copies in branches/safari-536.30-branch
Merged r130717. <rdar://problem/13334846>
- 5:37 PM Changeset in webkit [148324] by
-
- 2 edits in trunk/Source/WebKit2
Build fix - too soon!
- UIProcess/API/mac/WKViewPrivate.h:
- 5:33 PM Changeset in webkit [148323] by
-
- 5 edits in trunk/Source/WebCore
Update AVFoundationCF code following http://trac.webkit.org/changeset/148291.
https://bugs.webkit.org/show_bug.cgi?id=114548.
Reviewed by Eric Carlson.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::seekToTime):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMinTimeSeekable):
(WebCore):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeSeekable):
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
(MediaPlayerPrivateAVFoundationCF):
- 5:15 PM Changeset in webkit [148322] by
-
- 2 edits in trunk/Source/WebKit2
Build fix - too soon!
- UIProcess/API/mac/WKView.mm:
(-[WKView setFrameSize:]):
- 5:15 PM Changeset in webkit [148321] by
-
- 2 edits in branches/safari-536.30-branch/Source/WebCore
Merged r136619. <rdar://problem/13335066>
- 5:09 PM Changeset in webkit [148320] by
-
- 5 edits in branches/safari-536.30-branch
Merged r117463. <rdar://problem/13335066>
- 5:03 PM Changeset in webkit [148319] by
-
- 2 edits2 deletes in branches/safari-536.30-branch/LayoutTests
Merged r138692. <rdar://problem/13334855>
- 4:58 PM Changeset in webkit [148318] by
-
- 1 edit4 copies3 adds1 delete in branches/safari-536.30-branch/LayoutTests
Merged r138686. <rdar://problem/13334855>
- 4:55 PM Changeset in webkit [148317] by
-
- 2 edits in trunk/Tools
Unreviewed, remove an old email address for myself.
- Scripts/webkitpy/common/config/committers.py:
- 4:47 PM Changeset in webkit [148316] by
-
- 2 edits in trunk/Source/WebCore
Demystify some code in RenderLayer::updateScrollableAreaSet()
https://bugs.webkit.org/show_bug.cgi?id=114543
Reviewed by Tim Horton.
Clean up some code that called functions with important side effects
inside a ternary operator, and clean up the #ifdefs.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollableAreaSet):
- 4:46 PM Changeset in webkit [148315] by
-
- 7 edits15 copies2 deletes in branches/safari-536.30-branch
Merged r138654. <rdar://problem/13334855>
- 4:43 PM Changeset in webkit [148314] by
-
- 2 edits in trunk/Source/JavaScriptCore
Block freeing thread should call Region::destroy instead of delete
https://bugs.webkit.org/show_bug.cgi?id=114544
Reviewed by Oliver Hunt.
Since Region doesn't have a virtual destructor, calling delete will not properly clean up all of
the state of the Region. We should call destroy() instead.
- heap/BlockAllocator.cpp:
(JSC::BlockAllocator::releaseFreeRegions):
(JSC::BlockAllocator::blockFreeingThreadMain):
- 4:42 PM Changeset in webkit [148313] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: switch to using MCJIT and disable frame pointer elimination
https://bugs.webkit.org/show_bug.cgi?id=114542
Reviewed by Oliver Hunt and Michael Saboff.
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- 4:29 PM Changeset in webkit [148312] by
-
- 11 edits1 add in trunk
[WK2] WebPageProxy loadURL() won't work when called just after terminateProcess()
https://bugs.webkit.org/show_bug.cgi?id=110743
Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-04-12
Reviewed by Benjamin Poulain.
Source/WebKit2:
A call to loadURL() just after terminating WebProcess will fail thanks to
WebPageProxy being in an undefined state since it is in the middle of its own
cleanup after process termination.
To properly fix this, not only WebPageProxy cleanup should be made
at WebProcess termination request, but also WebProcessProxy needs
to only return to its caller after terminating the process and
closing connections. Otherwise, WebPageProxy can even be able to
detect that WebProcess is no longer running, but a call to respawn
the process will fail.
To fix these issues, this patch moves the cleanup code to a shared private function
that is used for both the cases i.e. user termination and real crash. WebProcess
shutdown is done using a new method that ensures that all cleanup was done before
returning.
A last change introduced in this patch is that for user requested termination,
clients are no longer notified of a crash (since it is not a crash).
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::terminateProcess):
(WebKit::WebPageProxy::processDidCrash):
(WebKit):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::userRequestedTerminate):
(WebKit):
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
Tools:
Adding a new test file to check if loading a page just after WebProcess
has crashed (or was terminated) works. The test executes the
following steps (Load, Crash, Load), thus stressing WebProcess
reattach and process termination code path.
- TestWebKitAPI/GNUmakefile.am:
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp: Added.
(TestWebKitAPI):
(WebKit2CrashLoader):
(TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
(TestWebKitAPI::WebKit2CrashLoader::loadUrl):
(TestWebKitAPI::WebKit2CrashLoader::crashWebProcess):
(TestWebKitAPI::didFinishLoad):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
- 4:18 PM Changeset in webkit [148311] by
-
- 15 edits in trunk/Source/WebKit2
Add contentAnchor to WKView
http://bugs.webkit.org/show_bug.cgi?id=114469
Currently if you call setFrameSize: while frame size updates are disabled, or if the geometry
update times out, then the previously rendered page content will be rendered anchored to the
top left corner of the frame.
This is appropriate if the frame is being resized from the bottom right corner. In order to
achieve a more desirable appearance if the frame is being resized from another corner we
should allow the corner at which the content anchors to be specified.
Reviewed by Simon Fraser.
- UIProcess/API/mac/WKView.mm:
(-[WKView setFrameSize:]):
- If the content anchor has been set, then updating the frame size moves the origin within the layer.
(-[WKView _setDrawingAreaSize:]):
- Instruct the drawing area to paint at the correct position within the layer.
(-[WKView _setAcceleratedCompositingModeRootLayer:]):
- If the root layer is cleared this implicitly resets any origin position we had set within it.
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
- initialize new data members.
(-[WKView setContentAnchor:]):
(-[WKView contentAnchor]):
- Accessor implementation for @property contentAnchor.
- UIProcess/API/mac/WKViewPrivate.h:
(NS_ENUM):
- Added WKContentAnchor enum type, and @property contentAnchor.
- UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::setSize):
- Don't suppress geometry updates where the layer poistion has changed.
- UIProcess/DrawingAreaProxy.h:
(DrawingAreaProxy):
- Added m_layerPosition, layerPosition argument to setSize
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
(TiledCoreAnimationDrawingAreaProxy):
- Added m_lastSentLayerPosition
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry):
- Don't suppress geometry updates where the layer poistion has changed.
(WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry):
- Pass layer position in UpdateGeometry message.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::updateGeometry):
- Added layerPosition argument to updateGeometry
- WebProcess/WebPage/DrawingArea.messages.in:
- Added layerPosition argument to updateGeometry
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
- Added layerPosition argument to updateGeometry
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
- Added layerPosition argument to updateGeometry
- 4:11 PM Changeset in webkit [148310] by
-
- 3 edits3 adds in trunk
<rdar://problem/13277362> REGRESSION (r141981): Crash when closing a Google Docs document
https://bugs.webkit.org/show_bug.cgi?id=114541
Reviewed by Brady Eidson.
Test: http/tests/ssl/ping-with-unsafe-redirect.html
- loader/FrameNetworkingContext.h: (WebCore::FrameNetworkingContext::shouldClearReferrerOnHTTPSToHTTPRedirect): Added a null check. All NetworkingContext functions except for this one had it already.
- 4:07 PM Changeset in webkit [148309] by
-
- 1 edit in branches/safari-536.30-branch/LayoutTests/http/tests/security/xssAuditor/resources/echo-intertag.pl
Update from testRunner to layoutTestController
- 4:07 PM Changeset in webkit [148308] by
-
- 2 edits in branches/safari-536.30-branch/LayoutTests
Update from testRunner to layoutTestController
- 3:50 PM Changeset in webkit [148307] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Don't forget to skip the test in WebKit2 for now.
- platform/mac-wk2/TestExpectations:
- 3:46 PM Changeset in webkit [148306] by
-
- 10 edits2 adds in trunk
[Mac] REGRESSION: Auto substitution strips new lines
https://bugs.webkit.org/show_bug.cgi?id=114537
Reviewed by Enrica Casucci.
Source/WebCore:
The bug was caused by SpellingCorrectionCommand's use of InsertTextCommand. This command can't insert
new lines and there's even an assertion for it. Use TypingCommand::insertText instead.
Since TypingCommand::insertText calls appliedEditing on its own, we need to avoid calling that again in
CompositeEditCommand::apply after SpellingCorrectionCommand::doApply. Replaced the check in apply to use
callsAppliedEditingInDoApply instead of isTypingCommand, and added callsAppliedEditingInDoApply to both
TypingCommand and SpellingCorrectionCommand to return true (it returns false by default).
Test: platform/mac/editing/spelling/autocorrection-with-multi-line-text.html
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::apply): Use TypingCommand::insertText instead of InsertTextCommand
(WebCore::CompositeEditCommand::callsAppliedEditingInDoApply): Added. Returns false.
- editing/CompositeEditCommand.h:
(CompositeEditCommand):
- editing/SpellingCorrectionCommand.cpp:
(WebCore::SpellingCorrectionCommand::doApply):
(WebCore::SpellingCorrectionCommand::callsAppliedEditingInDoApply): Added. Returns true.
- editing/SpellingCorrectionCommand.h:
(SpellingCorrectionCommand):
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::callsAppliedEditingInDoApply): Added. Returns true.
- editing/TypingCommand.h:
(TypingCommand):
Tools:
Add a rule to replace "helloleworld" by "hello\nworld" for testing purpose.
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
LayoutTests:
Added a regression test. Unfortunately, we can't setup text substituion in DumpRenderTree
so use NSSpellChecker to exercise the relevant code path.
- platform/mac/editing/spelling/autocorrection-with-multi-line-text-expected.txt: Added.
- platform/mac/editing/spelling/autocorrection-with-multi-line-text.html: Added.
- 3:04 PM Changeset in webkit [148305] by
-
- 16 edits1 copy1 add in trunk/Source/WebCore
Refactor TextTrack and TextTrackList to make it easier to add audio and video tracks
https://bugs.webkit.org/show_bug.cgi?id=114330
Patch by Brendan Long <b.long@cablelabs.com> on 2013-04-12
Reviewed by Jer Noble.
No new tests because this doesn't add new functionality.
- CMakeLists.txt: Only compile text track files if ENABLE(VIDEO_TRACK), and add TrackListBase
- Target.pri: Add TrackListBase
- WebCore.vcproj/WebCore.vcproj: Correct InbandTextTrackPrivate.h's location and add TrackListBase
- WebCore.xcodeproj/project.pbxproj: Add TrackListBase
- html/HTMLMediaElement.cpp: Renamed "track" functions to "textTrack"
(WebCore::HTMLMediaElement::mediaPlayerDidAddTextTrack): Renamed.
(WebCore::HTMLMediaElement::mediaPlayerDidRemoveTextTrack): Renamed.
(WebCore::HTMLMediaElement::addTextTrack): Renamed.
(WebCore::HTMLMediaElement::removeTextTrack): Renamed.
(WebCore::HTMLMediaElement::removeAllInbandTracks): Use renamed functions.
(WebCore::HTMLMediaElement::didAddTextTrack): Renamed.
(WebCore::HTMLMediaElement::didRemoveTextTrack): Renamed.
- html/HTMLMediaElement.h:
Renamed "track" functions to "textTrack" and only forward-declare TextTrackList if ENABLE(VIDEO_TRACK)
- html/HTMLTrackElement.cpp: Renamed "track" functions to "textTrack"
(WebCore::HTMLTrackElement::insertedInto):
(WebCore::HTMLTrackElement::removedFrom):
- html/track/TextTrack.cpp:
Move media element, label, language and kind into TrackBase and move EventTarget functions into TextTrack.
(WebCore::TextTrack::TextTrack): Added.
(WebCore::TextTrack::interfaceName): Added.
(WebCore::TextTrack::scriptExecutionContext): Added.
(WebCore::TextTrack::eventTargetData): Added.
(WebCore::TextTrack::ensureEventTargetData): Added.
(WebCore::TextTrack::isValidKind): Added to support TrackBase::setKind()
(WebCore::TextTrack::setKind): Override to support textTrackKindChanged()
(WebCore::TextTrack::isRendered): Use kind(), label() and language() instead of m_kind, etc.
(WebCore::TextTrack::platformTextTrack): Ditto.
(WebCore::TextTrack::isMainProgramContent): Ditto.
- html/track/TextTrack.h:
Same as TextTrack.cpp, plus added defaultKindKeyword() so TrackBase::setKind() will work and added
toTextTrack().
- html/track/TextTrackList.cpp:
Move functionality into TrackListBase, add toTextTrack() casts, use
TrackBase where necesssary and use owner() instead of m_owner.
Moved EventTarget functions into TrackListBase.
(TextTrackList::TextTrackList):
(TextTrackList::getTrackIndexRelativeToRenderedTracks):
(TextTrackList::item):
(TextTrackList::invalidateTrackIndexesAfterTrack):
(TextTrackList::append):
(TextTrackList::remove):
(TextTrackList::contains):
- html/track/TextTrackList.h:
Move EventTarget, RefCounted and m_inbandTracks into TrackListBase.
Override length(), contains() and remove().
- html/track/TrackBase.cpp: Remove EventTarget functions.
(WebCore::TrackBase::TrackBase):
Remove EventTarget, add label and language
(WebCore::TrackBase::setKind): Added
- html/track/TrackBase.h:
Don't extend EventTarget (AudioTrack and VideoTrack aren't). Handle
kind, label, language and media element.
(WebCore::TrackBase::setMediaElement): Added.
(WebCore::TrackBase::mediaElement): Added.
(WebCore::TrackBase::kind): Added.
(WebCore::TrackBase::label): Added.
(WebCore::TrackBase::setLabel): Added.
(WebCore::TrackBase::language): Added.
(WebCore::TrackBase::setLanguage): Added.
- html/track/TrackListBase.cpp:
Added. Handles functionality common to TextTrackList, AudioTrackList and
VideoTrackList.
(TrackListBase::TrackListBase): Added.
(TrackListBase::~TrackListBase): Added.
(TrackListBase::length): Added.
(TrackListBase::remove): Added.
(TrackListBase::contains): Added.
(TrackListBase::scheduleAddTrackEvent): Added.
(TrackListBase::scheduleRemoveTrackEvent): Added.
(TrackListBase::scheduleChangeEvent): Added.
(TrackListBase::asyncEventTimerFired): Added.
- html/track/TrackListBase.h:
Copied from Source/WebCore/html/track/TextTrackList.h. Handles
functionality common to TextTrackList, AudioTrackList and VideoTrackList.
(WebCore::TrackListBase::scriptExecutionContext): Added.
(WebCore::TrackListBase::clearOwner): Added.
(WebCore::TrackListBase::owner): Added.
(WebCore::TrackListBase::isFiringEventListeners): Added.
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::addTextTrack): Renamed (was addTrack)
(WebCore::MediaPlayer::removeTextTrack): Renamed (was removeTrack)
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerDidAddTextTrack): Renamed (was mediaPlayerDidAddTrack)
(WebCore::MediaPlayerClient::mediaPlayerDidRemoveTextTrack): Renamed (was mediaPlayerDidRemoveTrack)
- 2:54 PM Changeset in webkit [148304] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r148296 and r148297.
http://trac.webkit.org/changeset/148296
http://trac.webkit.org/changeset/148297
https://bugs.webkit.org/show_bug.cgi?id=114536
Needs more thought (Requested by ap on #webkit).
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- 2:39 PM Changeset in webkit [148303] by
-
- 18 edits in trunk/Source/WebCore
make the codegenerator actually emit polymorphism check in the "no vtable" path
https://bugs.webkit.org/show_bug.cgi?id=114533
Reviewed by David Kilzer.
Make the "no vtable" check correct so that we actually plant a polymorphism
check. Update a few interfaces to have the correct validation attributes.
- Modules/webdatabase/SQLTransaction.idl:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::toJS):
- bindings/scripts/test/TestInterface.idl:
- html/track/TextTrackCue.idl:
- svg/SVGAnimatedAngle.idl:
- svg/SVGAnimatedBoolean.idl:
- svg/SVGAnimatedEnumeration.idl:
- svg/SVGAnimatedInteger.idl:
- svg/SVGAnimatedLength.idl:
- svg/SVGAnimatedLengthList.idl:
- svg/SVGAnimatedNumber.idl:
- svg/SVGAnimatedNumberList.idl:
- svg/SVGAnimatedPreserveAspectRatio.idl:
- svg/SVGAnimatedRect.idl:
- svg/SVGAnimatedString.idl:
- svg/SVGAnimatedTransformList.idl:
- 1:44 PM Changeset in webkit [148302] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Enable selecting text in single line input field without selection point being actually on the targeted text vertically
https://bugs.webkit.org/show_bug.cgi?id=114515
Patch by Yongxin Dai <yodai@rim.com> on 2013-04-12
Reviewed by Rob Buis.
PR #317924.
Internally reviewed by Mike Fenton.
It was still hard to select text in URL bar with an inverted selection handle.
We improve the issue by replacing the Y coordinate of selection point with Y
coordinate of start caret for single line input filed. Thus, the Y coordinate
is always valid regardless of the actual location of the selection handle.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::startCaretViewportRect):
(WebKit):
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
- WebKitSupport/SelectionHandler.h:
(SelectionHandler):
- 1:28 PM Changeset in webkit [148301] by
-
- 14 edits in trunk/Source/WebCore
Make CodeGeneratorJS plant comments to explain failures in the binding validation
https://bugs.webkit.org/show_bug.cgi?id=114528
Reviewed by Sam Weinig.
No change in behaviour, just make the generated bindings include comments
to aid diagnosing issues that may be non-obvious.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::toJS):
- 1:17 PM Changeset in webkit [148300] by
-
- 8 edits in trunk/Source
REGRESSION (r138858): GIFs don't start playing when they come out of background tabs
https://bugs.webkit.org/show_bug.cgi?id=108864
<rdar://problem/13140489>
Reviewed by Antti Koivisto.
Don't repaint the world when animations resume; instead, FrameView
will cause all animated images to repaint. This line also had no effect for
TiledCoreAnimationDrawingArea, which does not implement setNeedsDisplay.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::resumeActiveDOMObjectsAndAnimations):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::resumeAnimatingImagesForLoader): Added.
Iterate through all of the loader's cached resources. If they are bitmap images
which claim to be animatable, notify the image's observers that the animation advanced
by one frame. In reality, the image is still on the same frame, but will now be repainted,
restarting the animation loop.
- loader/cache/CachedImage.h:
- page/FrameView.cpp:
(WebCore::FrameView::setIsInWindow):
When the FrameView is brought into a window, repaint all animated images.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::canAnimate): Added.
Return whether or not the image should animate (claims to animate, has not already
finished its animation, and has an ImageObserver) *and* has more than one frame.
- platform/graphics/BitmapImage.h:
(BitmapImage): Add canAnimate.
- 1:10 PM Changeset in webkit [148299] by
-
- 2 edits in trunk/Tools
Re-enable WinEWS tests.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
- 12:35 PM Changeset in webkit [148298] by
-
- 13 edits in trunk/Source/WebCore
r148197 broke the GTK+ build
https://bugs.webkit.org/show_bug.cgi?id=114525
Reviewed by Anders Carlsson.
Re-add the ENABLE(SCROLLING_THREAD) guards to scrolling thread files
and extend them with USE(COORDINATED_GRAPHICS). This code is unused
by other configurations currently.
- page/scrolling/ScrollingStateFixedNode.cpp: Re-add guards.
- page/scrolling/ScrollingStateFixedNode.h: Ditto.
- page/scrolling/ScrollingStateNode.cpp: Ditto.
- page/scrolling/ScrollingStateNode.h: Ditto.
- page/scrolling/ScrollingStateScrollingNode.cpp: Ditto.
- page/scrolling/ScrollingStateScrollingNode.h: Ditto.
- page/scrolling/ScrollingStateStickyNode.cpp: Ditto.
- page/scrolling/ScrollingStateStickyNode.h: Ditto.
- page/scrolling/ScrollingStateTree.cpp: Ditto.
- page/scrolling/ScrollingStateTree.h: Ditto.
- page/scrolling/mac/ScrollingStateNodeMac.mm: Ditto.
- page/scrolling/mac/ScrollingStateScrollingNodeMac.mm: Ditto.
- 12:28 PM Changeset in webkit [148297] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13334446> [Mac] Tweak sandbox profile.
Apply a post-landing review comment.
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- 12:14 PM Changeset in webkit [148296] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13334446> [Mac] Tweak sandbox profile.
Reviewed by Jessie Berlin.
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- 12:09 PM Changeset in webkit [148295] by
-
- 2 edits in trunk/Source/WebCore
(AVFoundation) WebKit fails to detect live stream.
https://bugs.webkit.org/show_bug.cgi?id=114474
Reviewed by Eric Carlson.
Remove a workaround (added by r88944) for an error in an Apple.com javascript
media controller. The error has been fixed, and the workaround is causing problems
with other media streams.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
- 11:57 AM Changeset in webkit [148294] by
-
- 15 edits6 adds4 deletes in trunk
[GTK] Split GtkAuthenticationDialog in two widgets
https://bugs.webkit.org/show_bug.cgi?id=103644
Reviewed by Xan Lopez.
Source/WebCore:
The current GtkAuthenticationDialog implements both the common
logic and widgets to implement a real GtkDialog and a widget to be
embedded in any container. WebKit1 uses a GtkDialog while WebKit2
embeds the dialog in the WebView. This patch splits the code to
leave in Platform only the code that is actually common, leaving
the widget implementation to the WebKit layer, using a dialog in
WebKit1 and embedding auth widget in the WebView in WebKit2.
- GNUmakefile.list.am: Add new files to compilation.
- platform/gtk/GtkAuthenticationDialog.cpp: Removed.
- platform/gtk/GtkAuthenticationDialog.h: Removed.
- platform/gtk/WebKitAuthenticationWidget.cpp: Added.
(_WebKitAuthenticationWidgetPrivate):
(packTwoColumnLayoutInBox):
(createLabel):
(createEntry):
(webkitAuthenticationWidgetInitialize):
(webkitAuthenticationWidgetFinalize):
(webkit_authentication_widget_init):
(webkit_authentication_widget_class_init):
(webkitAuthenticationWidgetNew):
(webkitAuthenticationWidgetCreateCredential):
(webkitAuthenticationWidgetGetChallenge):
- platform/gtk/WebKitAuthenticationWidget.h: Added.
(_WebKitAuthenticationWidget):
(_WebKitAuthenticationWidgetClass):
Source/WebKit/gtk:
- GNUmakefile.am: Add new files to compilation.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
Use helper createAuthenticationDialog() to create and show the
auth dialog.
- webkit/webkitauthenticationdialog.cpp: Added.
(authenticationDialogResponseCallback):
(createAuthenticationDialog):
- webkit/webkitauthenticationdialog.h: Added.
- webkit/webkitsoupauthdialog.cpp:
(sessionAuthenticate): Ditto.
Source/WebKit2:
- GNUmakefile.list.am: Add new files to compilation.
- UIProcess/API/gtk/WebKit2GtkAuthenticationDialog.cpp: Removed.
- UIProcess/API/gtk/WebKit2GtkAuthenticationDialog.h: Removed.
- UIProcess/API/gtk/WebKitAuthenticationDialog.cpp: Added.
(webkitAuthenticationDialogAuthenticate): Use the
AuthenticationChallengeProxy to authenticate and destroy the dialog.
(okButtonClicked): Call webkitAuthenticationDialogAuthenticate()
with the credential.
(cancelButtonClicked): Call
webkitAuthenticationDialogAuthenticate() with a NULL credential to
continue without credential.
(webkitAuthenticationDialogInitialize): Build the UI.
(webkitAuthenticationDialogDraw): Draw a background.
(webkitAuthenticationDialogMap): Grab default button.
(webkitAuthenticationDialogConstructed): Create a GtkStyleContext
with the GtkWindow path to draw the widget background like a real
dialog.
(webkit_authentication_dialog_class_init):
(webkitAuthenticationDialogNew): Create a new
WebKitAuthenticationDialog widget.
- UIProcess/API/gtk/WebKitAuthenticationDialog.h: Added.
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewHandleAuthenticationChallenge): Create a
WebKitAuthenticationDialog widget and pass add it to the
container.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(_WebKitWebViewBasePrivate): Updated to use the widget directly.
(webkitWebViewChildIsInternalWidget): Ditto.
(webkitWebViewBaseAddAuthenticationDialog): Ditto.
(webkitWebViewBaseCancelAuthenticationDialog): Ditto.
(webkitWebViewBaseContainerRemove): Ditto.
(webkitWebViewBaseContainerForall): Ditto.
(resizeWebKitWebViewBaseFromAllocation): Ditto.
(webkitWebViewBaseFocus): Ditto.
(webkitWebViewBaseDestroy): Destroy the auth widget is present.
(webkit_web_view_base_class_init): Add implementation for
GtkWidgetClass::destroy.
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
Tools:
- gtk/generate-gtkdoc:
(get_webkit2_options): Do not generate api docs for
WebKitAuthenticationDialog which is private in WebKit2.
(get_webkit1_options): Do not generate api docs for
webkitauthenticationdialog which is private in WebKit1.
- 11:45 AM Changeset in webkit [148293] by
-
- 2 edits in trunk
[GTK] Lower the pango dependency
https://bugs.webkit.org/show_bug.cgi?id=114520
Reviewed by Carlos Garcia Campos.
- Source/autotools/Versions.m4: Only depend on Pango 1.30.0 instead of
Pango 1.32.0. 1.32.0 isn't strictly necessary and the version of GTK+ that
we depend on (3.6.0) depends on 1.30.0.
- 11:43 AM Changeset in webkit [148292] by
-
- 2 edits in trunk/Tools
WebKit Queues should capitalize K in Wk2
https://bugs.webkit.org/show_bug.cgi?id=114524
Reviewed by Philippe Normand.
- QueueStatusServer/model/queues.py:
(Queue.display_name):
- 11:39 AM Changeset in webkit [148291] by
-
- 9 edits in trunk/Source/WebCore
Add support for MediaPlayer::minTimeSeekable()
https://bugs.webkit.org/show_bug.cgi?id=114484
Reviewed by Eric Carlson.
Plumb a new minTimeSeekable() method through MediaPlayer and
MediaPlayerPrivate and use this new method in the existing
HTMLMediaElement::minTimeSeekable() method.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::minTimeSeekable): Pass to MediaPlayer.
- platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::minTimeSeekable): Return 0.
(WebCore::MediaPlayer::minTimeSeekable): Pass to MediaPlayerPrivate.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::seekable): Define in terms of
minTimeSeekable()
(WebCore::MediaPlayerPrivateInterface::minTimeSeekable): Default to 0.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
Initialize new m_cachedMinTimeSeekable ivar.
(WebCore::MediaPlayerPrivateAVFoundation::maxTimeSeekableDouble):
Renamed from maxTimeSeekable().
(WebCore::MediaPlayerPrivateAVFoundation::minTimeSeekable): Added.
Cache value of platformMinTimeSeekable().
(WebCore::MediaPlayerPrivateAVFoundation::seekableTimeRangesChanged):
Reset m_cachedMinTimeSeekable.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime): float -> double.
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMinTimeSeekable):
Added. Retrieve the lowest value from -[m_playerItem seekableTimeRanges].
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMaxTimeSeekable):
float -> double.
- 11:36 AM Changeset in webkit [148290] by
-
- 2 edits in trunk/Source/WebKit/win
All tests crash on Windows
https://bugs.webkit.org/show_bug.cgi?id=114522
Reviewed by Ryosuke Niwa.
In the MSVC++ ABI, a member function pointer will have a different size depending on whether the
class it belongs to is defined or not. Because of this, when passing member function pointers as parameters
it's important to ensure that the class is known by both the caller and the callee.
- WebFrame.cpp:
Include PolicyChecker.h
- 11:06 AM Changeset in webkit [148289] by
-
- 20 edits2 adds60 deletes in trunk
Unreviewed, rolling out r147942, r148026, and r148092.
http://trac.webkit.org/changeset/147942
http://trac.webkit.org/changeset/148026
http://trac.webkit.org/changeset/148092
https://bugs.webkit.org/show_bug.cgi?id=114521
"r147942 is buggy. Rollback all the patches depending on it."
(Requested by abucur on #webkit).
Source/WebCore:
- dom/ContainerNode.cpp:
(WebCore::willRemoveChildren):
(WebCore):
(WebCore::ContainerNode::removeChildren):
- dom/Document.cpp:
(WebCore::Document::nodeChildrenWillBeRemoved):
(WebCore):
- dom/Document.h:
(Document):
- dom/Node.cpp:
- dom/Node.h:
(Node):
- dom/NodeTraversal.cpp:
- dom/NodeTraversal.h:
(ElementTraversal):
(NodeTraversal):
- dom/Range.cpp:
(WebCore::boundaryNodeChildrenWillBeRemoved):
(WebCore):
(WebCore::Range::nodeChildrenWillBeRemoved):
- dom/Range.h:
- html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::attach):
- html/HTMLOListElement.cpp:
(WebCore::HTMLOListElement::updateItemValues):
(WebCore::HTMLOListElement::recalculateItemCount):
- rendering/RenderCounter.cpp:
(WebCore::previousInPreOrder):
(WebCore::previousSiblingOrParent):
(WebCore::parentElement):
(WebCore::nextInPreOrder):
- rendering/RenderListItem.cpp:
(WebCore::enclosingList):
(WebCore::RenderListItem::nextListItem):
(WebCore::previousListItem):
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::explicitValueChanged):
(WebCore::previousOrNextItem):
(WebCore::RenderListItem::updateListMarkerNumbers):
- rendering/RenderListItem.h:
(RenderListItem):
LayoutTests:
- fast/dom/MutationObserver/added-out-of-order-expected.txt:
- fast/dom/MutationObserver/added-out-of-order.html:
- fast/dom/Range/range-remove-children-event-expected.txt: Removed.
- fast/dom/Range/range-remove-children-event.html: Removed.
- fast/dom/containerNode-expected.txt: Added.
- fast/dom/containerNode.html: Added.
- fast/dom/shadow/shadow-and-list-elements-expected.html:
- fast/events/mutation-during-innerHTML-expected.txt: Removed.
- fast/events/mutation-during-innerHTML.html: Removed.
- fast/lists/positioned-count-crash-expected.txt:
- fast/regions/counters/extract-list-items-001-expected.html: Removed.
- fast/regions/counters/extract-list-items-001.html: Removed.
- fast/regions/counters/extract-list-items-002-expected.html: Removed.
- fast/regions/counters/extract-list-items-002.html: Removed.
- fast/regions/counters/extract-list-items-003-expected.html: Removed.
- fast/regions/counters/extract-list-items-003.html: Removed.
- fast/regions/counters/extract-list-items-004-expected.html: Removed.
- fast/regions/counters/extract-list-items-004.html: Removed.
- fast/regions/counters/extract-list-items-005-expected.html: Removed.
- fast/regions/counters/extract-list-items-005.html: Removed.
- fast/regions/counters/extract-list-items-006-expected.html: Removed.
- fast/regions/counters/extract-list-items-006.html: Removed.
- fast/regions/counters/extract-list-items-007-expected.html: Removed.
- fast/regions/counters/extract-list-items-007.html: Removed.
- fast/regions/counters/extract-list-items-008-expected.html: Removed.
- fast/regions/counters/extract-list-items-008.html: Removed.
- fast/regions/counters/extract-list-items-009-expected.html: Removed.
- fast/regions/counters/extract-list-items-009.html: Removed.
- fast/regions/counters/extract-list-items-010-expected.html: Removed.
- fast/regions/counters/extract-list-items-010.html: Removed.
- fast/regions/counters/extract-list-items-011-expected.html: Removed.
- fast/regions/counters/extract-list-items-011.html: Removed.
- fast/regions/counters/extract-list-items-012-expected.html: Removed.
- fast/regions/counters/extract-list-items-012.html: Removed.
- fast/regions/counters/extract-list-items-013-expected.html: Removed.
- fast/regions/counters/extract-list-items-013.html: Removed.
- fast/regions/counters/extract-list-items-014-expected.html: Removed.
- fast/regions/counters/extract-list-items-014.html: Removed.
- fast/regions/counters/extract-list-items-015-expected.html: Removed.
- fast/regions/counters/extract-list-items-015.html: Removed.
- fast/regions/counters/extract-numbered-paragraphs-divs-001-expected.html: Removed.
- fast/regions/counters/extract-numbered-paragraphs-divs-001.html: Removed.
- fast/regions/counters/extract-numbered-paragraphs-divs-002-expected.html: Removed.
- fast/regions/counters/extract-numbered-paragraphs-divs-002.html: Removed.
- fast/regions/counters/extract-numbered-paragraphs-expected.html: Removed.
- fast/regions/counters/extract-numbered-paragraphs.html: Removed.
- fast/regions/counters/extract-numbered-spans-display-only-some-expected.html: Removed.
- fast/regions/counters/extract-numbered-spans-display-only-some.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-001-expected.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-001.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-002-expected.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-002.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-003-expected.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-003.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001-expected.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002-expected.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003-expected.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004-expected.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html: Removed.
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html: Removed.
- fast/regions/counters/extract-unordered-lists-in-regions-expected.html: Removed.
- fast/regions/counters/extract-unordered-lists-in-regions.html: Removed.
- 10:58 AM Changeset in webkit [148288] by
-
- 13 edits2 adds in trunk
TimeRanges::nearest() returns incorrect results.
https://bugs.webkit.org/show_bug.cgi?id=114483
Reviewed by Eric Carlson.
.:
Add symbols needed by WebCoreTestSupport to exports list.
- Source/autotools/symbols.filter:
Source/WebCore:
Test: media/timeranges-nearest.html
TimeRanges::nearest() has had an incorrect algorithm since its
addition, which has gone unnoticed because no media engine supports
seekable ranges with greater than one entry, and no media engine
seekable ranges with startTime values > 0.
Fix the algorithm used to walk a TimeRanges object; return the closest
time, not the smallest delta between range and target time.
- html/TimeRanges.cpp:
(TimeRanges::nearest):
Add some internal functions to allow us to write LayoutTests for
TimeRanges objects:
- WebCore.exp.in:
- testing/Internals.cpp:
(WebCore::Internals::createTimeRanges):
(WebCore::Internals::closestTimeToTimeRanges):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
Add symbols needed by WebCoreTestSupport to the exports list.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/win:
Add symbols needed by WebCoreTestSupport to the exports list.
- WebKit.vcproj/WebKitExports.def.in:
LayoutTests:
- media/timeranges-nearest-expected.txt: Added.
- media/timeranges-nearest.html: Added.
- 10:40 AM Changeset in webkit [148287] by
-
- 2 edits in trunk/Source/WTF
Remove bogus change
- 10:24 AM Changeset in webkit [148286] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Web Process crash when the UI process finishes too early
https://bugs.webkit.org/show_bug.cgi?id=112729
Reviewed by Anders Carlsson.
The problem is when creating the GSocket in the WorkQeue for the
socket descriptor. GLib considers a programmer error to create a
GSocket providing an invalid socket and finishes the process with
g_error(). We are actually providing a valid socket when creating
the GSocket, but it can be invalidated by the worker thread while
the GSocket is being created. This is because
registerEventSourceHandler is called from the main thread and
unregisterEventSourceHandler can be called from the worker
thread. We are currently registering two event handlers, one to
read data from the socket and another one to close the CoreIPC
connection when the socket connection is broken. Every event
source registered uses its own GSocket (even if the file
descriptor is actually the same), so that when the UI process
finishes too early, the first event handler can be executed in the
worker thread, closing the socket descriptor, while the main
thread is creating the GSocket for the second one.
We don't really need to use a separate event handler to monitor
the connection, because GSocket always notifies when condition is
G_IO_HUP and G_IO_ERR even if they haven't been explicitly set in
g_socket_create_source(). We can register socket event sources
differently, providing also a function to be called when the
connection is closed, using a single socket and the same even source.
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::open): Register a single socket event
handler providing also a function to be called when the connection
is closed.
- Platform/WorkQueue.h:
(WorkQueue):
- Platform/gtk/WorkQueueGtk.cpp: The EventSource class has been
split, moving everyting specific to socket event source to a
derived class SocketEventSource.
(WorkQueue::EventSource::EventSource):
(WorkQueue::EventSource::performWork):
(WorkQueue::EventSource::performWorkOnce):
(WorkQueue::EventSource::performWorkOnTermination):
(WorkQueue::EventSource::deleteEventSource):
(WorkQueue::EventSource):
(WorkQueue::SocketEventSource):
(WorkQueue::SocketEventSource::SocketEventSource):
(WorkQueue::SocketEventSource::cancel):
(WorkQueue::SocketEventSource::didClose):
(WorkQueue::SocketEventSource::checkCondition):
(WorkQueue::SocketEventSource::eventCallback):
(WorkQueue::registerSocketEventHandler):
(WorkQueue::unregisterSocketEventHandler):
(WorkQueue::dispatchOnSource):
- 10:23 AM Changeset in webkit [148285] by
-
- 23 edits2 adds in trunk
Support "forced" subtitles
https://bugs.webkit.org/show_bug.cgi?id=114460
Reviewed by Jer Noble.
Source/WebCore:
Test: media/track/track-forced-subtitles.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::configureTextTrackGroup): Enable a forced track if nothing else is enabled.
(WebCore::HTMLMediaElement::configureTextTracks): Include forced tracks with captions+subtitles.
- html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::InbandTextTrack): Deal with kind=forced.
- html/track/TextTrack.cpp:
(WebCore::TextTrack::forcedKeyword): New keyword.
(WebCore::TextTrack::isValidKindKeyword): Include forced.
(WebCore::TextTrack::platformTextTrack): Ditto.
- html/track/TextTrack.h:
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::primaryAudioTrackLanguageOverride): New override to support testing.
- page/CaptionUserPreferences.h:
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Support forced tracks.
- platform/graphics/InbandTextTrackPrivate.h:
- platform/graphics/PlatformTextTrack.h: Add Forced, minor cleanup.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processCue): Drive-by enhancement: log cue position.
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
(WebCore::InbandTextTrackPrivateAVFObjC::kind): Support forced.
(WebCore::InbandTextTrackPrivateAVFObjC::label): Drive-by cleanup.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::processTextTracks): Don't filter out forced tracks.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Log the language returned.
- testing/Internals.cpp:
(WebCore::Internals::setPrimaryAudioTrackLanguageOverride): New.
(WebCore::Internals::setCaptionDisplayMode): New.
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- media/content/CC+Subtitles.m4v: Added.
- media/track/track-forced-subtitles-in-band-expected.txt: Added.
- media/track/track-forced-subtitles-in-band.html: Added.
- media/trackmenu-test.js:
- platform/efl/TestExpectations: Skip new test.
- platform/gtk/TestExpectations: Ditto.
- platform/mac/TestExpectations: Ditto.
- platform/qt/TestExpectations: Ditto.
- platform/win/TestExpectations: Ditto.
- 10:06 AM Changeset in webkit [148284] by
-
- 3 edits in trunk/Source/WebKit2
<rdar://problem/13126204> [Mac] Tweak sandbox profile.
Reviewed by Anders Carlsson.
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- WebProcess/com.apple.WebProcess.sb.in:
- 9:54 AM Changeset in webkit [148283] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Some ligatures are applied across different fronts
https://bugs.webkit.org/show_bug.cgi?id=113604
Reviewed by Darin Adler.
The bug was caused by applyFontTransforms applying ligatures without updating the font data in the glyph buffer.
Suppose we have characters AB and A uses font X and B uses font Y. Further suppose that we have ligatures for AB
in Y. The problem was that WithIterator::advanceInternal calls applyFontTransforms on AB to apply this ligature
even though A and B use different fonts. Since X doesn't contain the same ligature for A to be paired with that
of B in X, we get a blank A.
Fixed the bug by resetting lastGlyphCount after calling applyFontTransforms. This ensures that we don't call
applyFontTransforms across different fonts.
No new tests since this requires a variant of Osaka font that doesn't come with OS X.
The bug 114482 tracks the effort to add a test for this bug fix. I've already asked someone to create a custom
font for us so that we can test this bug fix but that's going to a while.
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advanceInternal):
- 9:52 AM Changeset in webkit [148282] by
-
- 26 edits6 deletes in trunk
[Mac] Enable spellchecking tests added in r141471
https://bugs.webkit.org/show_bug.cgi?id=108525
Reviewed by Darin Adler.
Source/WebCore:
Made automatic quote substitution, dash substitution, text replacement, and spelling correction
togglable via internals object. These functions are no-op when text replacement is not used.
This allows us to disable automatic spelling correction in spellcheck tests.
Enabled several tests added in r141471.
- WebCore.exp.in:
- testing/Internals.cpp:
(WebCore::Internals::setContinuousSpellCheckingEnabled): Don't null check editor() since it's not
null whenever frame() is not null.
(WebCore::Internals::setAutomaticQuoteSubstitutionEnabled): Added.
(WebCore::Internals::setAutomaticLinkDetectionEnabled): Added.
(WebCore::Internals::setAutomaticDashSubstitutionEnabled): Added.
(WebCore::Internals::setAutomaticTextReplacementEnabled): Added.
(WebCore::Internals::setAutomaticSpellingCorrectionEnabled): Added.
- testing/Internals.h:
- testing/Internals.idl:
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
(resetDefaultsToConsistentValues):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
LayoutTests:
Updated the tests not to assume spelling correction suggestions were listed in a context menu since
only Chromium port did this.
- editing/spelling/resources/util.js:
(initSpellTest): Disable automatic text replacements.
- editing/spelling/spelling-with-underscore-selection-expected.txt: Removed.
- editing/spelling/spelling-with-underscore-selection.html: Removed.
This test erroneously assumed a specific word breaking behavior that doesn't include the underscore
when selecting a word especially since Chromium was the only port that was running these tests.
- editing/spelling/spelling-double-clicked-word-with-underscores-expected.txt: Removed.
- editing/spelling/spelling-double-clicked-word-with-underscores.html: Removed.
Ditto.
- editing/spelling/spelling-should-select-single-word-expected.txt: Removed.
- editing/spelling/spelling-should-select-single-word.html: Removed.
Removed since this test doesn't do anything useful without the assertion for the context menu.
- editing/spelling/spelling-double-clicked-word-expected.txt:
- editing/spelling/spelling-double-clicked-word.html:
- editing/spelling/spelling-exactly-selected-word-expected.txt:
- editing/spelling/spelling-exactly-selected-word.html:
- editing/spelling/spelling-with-punctuation-selection-expected.txt:
- editing/spelling/spelling-with-punctuation-selection.html:
- editing/spelling/spelling-with-whitespace-selection-expected.txt:
- editing/spelling/spelling-with-whitespace-selection.html:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wk2/TestExpectations:
- 9:33 AM Changeset in webkit [148281] by
-
- 4 edits in trunk/Source/WebKit2
[GTK][WK2] Add document-loaded signal to WebKitWebPage
https://bugs.webkit.org/show_bug.cgi?id=110614
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-12
Reviewed by Carlos Garcia Campos.
Add a new signal document-loaded to WebKitWebPage that will be emitted
when the DOM document has been loaded for the main frame.
- UIProcess/API/gtk/tests/TestWebExtensions.cpp:
(documentLoadedCallback):
(testDocumentLoadedSignal):
(beforeAll): Add test for document-loaded signal.
- UIProcess/API/gtk/tests/WebExtensionTest.cpp:
(documentLoadedCallback):
(pageCreatedCallback):
(methodCallCallback): Add new D-Bus signal DocumentLoaded in order to
test document-loaded signal.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkit_web_page_class_init):
(webkitWebPageCreate): Add document-loaded signal and emit it when
didFinishDocumentLoadForFrame is called.
- 9:19 AM Changeset in webkit [148280] by
-
- 2 edits in trunk/Source/WTF
[Qt][Win] r148257 broke the build
https://bugs.webkit.org/show_bug.cgi?id=114512
Build fix.
- wtf/Platform.h:
- 9:07 AM Changeset in webkit [148279] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Webkit fails to build webkit2gtk-tests-resources.gresource.
https://bugs.webkit.org/show_bug.cgi?id=114485
Patch by Hanyee Kim <choco@company100.net> on 2013-04-12
Reviewed by Martin Robinson.
Generating webkit2gtk-tests-resources.gresource can be failed due to
the non-existing target directory.
We need to make target directory before generating it.
- UIProcess/API/gtk/tests/GNUmakefile.am:
- 8:13 AM Changeset in webkit [148278] by
-
- 8 edits in trunk/Source/WebKit2
REGRESSION(r145869): Right-click on SWF contents displays the context menu at the wrong place.
<http://webkit.org/b/113836>
<rdar://problem/13587624>
Reviewed by Anders "Wesley Crusher" Carlsson.
Mac plugins expect flipped-Y screen coordinates, while DOM APIs speak in unflipped coordinates,
and we were mixing them up in the window frame caching optimization.
Solve this by having the UIProcess send both flipped and unflipped window frames to the WebProcess.
The flipped frame is passed on to plugins, and the unflipped frame is used for window.screenX/Y etc.
- UIProcess/API/mac/WKView.mm:
(-[WKView _updateWindowAndViewFrames]):
No need to retrieve the window frame here as WebPageProxy::windowAndViewFramesChanged() will
always override it anyway.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::windowAndViewFramesChanged):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::windowRect):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowAndViewFramesChanged):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::windowFrameInUnflippedScreenCoordinates):
- WebProcess/WebPage/WebPage.messages.in:
- 7:05 AM Changeset in webkit [148277] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Crash running layout tests
https://bugs.webkit.org/show_bug.cgi?id=114503
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-12
Reviewed by Xan Lopez.
Hit an assertion in ~GuardedPointerBase when DRT is
deleted. DumpRenderTree class derives from
BlackBerry::Platform::LayoutTestClient that derives from
BlackBerry::Platform::GuardedPointerBase, so the DRT pointer
should no be released with delete but with
BlackBerry::Platform::deleteGuardedObject().
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
- 6:50 AM Changeset in webkit [148276] by
-
- 5 edits in trunk/Tools
[GTK] Enable WebKit2 building on GTK EWSs
https://bugs.webkit.org/show_bug.cgi?id=114500
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-12
Reviewed by Philippe Normand.
Add configuration in order to be able to setup GTK EWSs building
WebKit2. A new queue gtk-wk2-ews is added.
- QueueStatusServer/config/queues.py:
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port):
(GtkWK2Port):
(GtkWK2Port.build_webkit_command):
(GtkWK2Port.run_webkit_tests_command):
- Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest.test_gtk_port):
(DeprecatedPortTest):
(DeprecatedPortTest.test_gtk_wk2_port):
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(GtkWK2EWS):
- 6:22 AM Changeset in webkit [148275] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Upstream the filesystem code
https://bugs.webkit.org/show_bug.cgi?id=114437
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-12
Reviewed by Rob Buis.
These are the changes for AsyncFileSystemBlackBerry.
This patch contains contributions from many members of the
BlackBerry WebKit team.
- platform/blackberry/AsyncFileSystemBlackBerry.cpp:
(WebCore::AsyncFileSystem::isAvailable):
(WebCore):
(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
(WebCore::AsyncFileSystemBlackBerry::openFileSystem):
(WebCore::AsyncFileSystem::deleteFileSystem):
(WebCore::AsyncFileSystemBlackBerry::AsyncFileSystemBlackBerry):
(WebCore::AsyncFileSystemBlackBerry::~AsyncFileSystemBlackBerry):
(WebCore::AsyncFileSystemBlackBerry::move):
(WebCore::AsyncFileSystemBlackBerry::copy):
(WebCore::AsyncFileSystemBlackBerry::remove):
(WebCore::AsyncFileSystemBlackBerry::removeRecursively):
(WebCore::AsyncFileSystemBlackBerry::readMetadata):
(WebCore::AsyncFileSystemBlackBerry::createFile):
(WebCore::AsyncFileSystemBlackBerry::createDirectory):
(WebCore::AsyncFileSystemBlackBerry::fileExists):
(WebCore::AsyncFileSystemBlackBerry::directoryExists):
(WebCore::AsyncFileSystemBlackBerry::readDirectory):
(WebCore::AsyncFileSystemBlackBerry::createWriter):
(WebCore::AsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadata):
(WebCore::AsyncFileSystemBlackBerry::fileSystemURLToPath):
- platform/blackberry/AsyncFileSystemBlackBerry.h:
(WTF):
(WTF::BlackBerry::Platform::WebFileSystem):
(WebCore::AsyncFileSystemBlackBerry::create):
(AsyncFileSystemBlackBerry):
- 6:10 AM Changeset in webkit [148274] by
-
- 11 edits4 copies in trunk/Source/WebKit2
[WK2][EFL] WebView: Add callbacks to the WKViewClient to handle page viewport update
https://bugs.webkit.org/show_bug.cgi?id=110463
Reviewed by Anders Carlsson.
- UIProcess/efl/ViewClientEfl.h:
(ViewClientEfl):
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::didChangeViewportProperties):
- UIProcess/efl/WebViewClient.cpp:
(WebKit::WebViewClient::didChangeViewportAttributes):
(WebKit):
- UIProcess/efl/WebViewClient.h:
Added didChangeViewportAttributes callback to the WKViewClient to
handle page viewport updates.
- CMakeLists.txt:
- Shared/API/c/WKBase.h:
- Shared/APIObject.h:
- UIProcess/API/C/WKAPICast.h:
(WebKit):
- UIProcess/API/C/WKViewportAttributes.cpp: Added.
(WKViewportAttributesGetTypeID):
- UIProcess/API/C/WKViewportAttributes.h: Added.
- UIProcess/API/C/efl/WKView.h:
- UIProcess/WebViewportAttributes.cpp: Added.
(WebKit):
(WebKit::WebViewportAttributes::WebViewportAttributes):
(WebKit::WebViewportAttributes::~WebViewportAttributes):
- UIProcess/WebViewportAttributes.h: Added.
(WebKit):
(WebViewportAttributes):
(WebKit::WebViewportAttributes::create):
(WebKit::WebViewportAttributes::originalAttributes):
(WebKit::WebViewportAttributes::type):
Added WKViewportAttributesRef - WK2 C API object that is wrapping
WebCore::ViewportAttributes structure and is passed in didChangeViewportAttributes
WKViewClient callback.
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didChangeViewportAttributes):
(WebKit):
Added implementaion of didChangeViewportAttributes WKViewClient
callback so that existing EFL WK2 funtionality is kept.
- 3:54 AM Changeset in webkit [148273] by
-
- 2 edits in trunk/Source/WebCore
Apply our MSVC 2012 optimizer bug workaround to all minor releases
https://bugs.webkit.org/show_bug.cgi?id=114436
Reviewed by Alexey Proskuryakov.
The bug has only been partially fixed in Update 2 but our Update 1 workaround
still avoids the crash.
- platform/text/TextEncodingRegistry.cpp:
(WebCore::TextEncodingNameHash::equal):
- 3:28 AM Changeset in webkit [148272] by
-
- 2 edits in trunk/Source/WebCore
And again, with the correct case this time.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
- 3:22 AM Changeset in webkit [148271] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
Add missing #include and forward declaration.
- 2:03 AM Changeset in webkit [148270] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Crash running layout tests when WebPage is destroyed
https://bugs.webkit.org/show_bug.cgi?id=114497
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-12
Reviewed by Xan Lopez.
PR 324649
Internally reviewed by Konrad Piascik and Rob Buis.
Use a bool member to keep track of whether the inspector is
enabled or not instead of relaying on the enable developer extras
setting, that can be set in other places than enableWebInspector().
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Initialize
m_inspectorEnabled.
(BlackBerry::WebKit::WebPage::enableWebInspector): Return early if
inspector is already enabled and set m_inspectorEnabled to true.
(BlackBerry::WebKit::WebPage::disableWebInspector): Return early
if inspector is not enabled and set m_inspectorEnabled to false.
(BlackBerry::WebKit::WebPage::isWebInspectorEnabled): Check the
current value of m_inspectorEnabled instead of the developer
extras setting.
- Api/WebPage_p.h:
(WebPagePrivate): Add m_inspectorEnabled.
- 1:55 AM Changeset in webkit [148269] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed functionality fix for ports enabling the MicroData feature.
- html/DOMSettableTokenList.idl: Add the SkipVTableValidation IDL attribute to the DOMSettableTokenList interface.
This removes crashes in the MicroData layout tests that are occurring on EFL and GTK builders, the two ports being
the only ports that enable this feature.
- 1:17 AM Changeset in webkit [148268] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/TestExpectations:
- platform/qt/fast/js/global-constructors-expected.txt: Rebaselining after r148236.
- 1:12 AM Changeset in webkit [148267] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] The style of visited links doesn't change in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112175
Reviewed by Benjamin Poulain.
The problem is that visited links were not tracked by the web
process. There's a web process initial parameter to set whether
web process should track visited links or not and it's disabled by
default.
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformInitializeWebProcess): Always set
shouldTrackVisitedLinks to true.
- 12:55 AM WebKitGTK/2.0.x edited by
- (diff)
- 12:38 AM Changeset in webkit [148266] by
-
- 1 edit2 deletes in trunk/Tools
Remove Chromium scripts
https://bugs.webkit.org/show_bug.cgi?id=114492
Reviewed by Benjamin Poulain.
- Scripts/run-chromium-webkit-unit-tests: Removed.
- Scripts/update-webkit-chromium: Removed.
- 12:15 AM Changeset in webkit [148265] by
-
- 15 edits1 add in trunk/Source/WebCore
Move CachedRawResourceClient into a separate file
https://bugs.webkit.org/show_bug.cgi?id=114491
Reviewed by Mark Rowe.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- loader/DocumentLoader.cpp:
- loader/DocumentLoader.h:
- loader/DocumentThreadableLoader.h:
- loader/archive/cf/LegacyWebArchive.cpp:
- loader/cache/CachedRawResource.cpp:
- loader/cache/CachedRawResource.h:
- loader/cache/CachedRawResourceClient.h: Added.
- loader/icon/IconLoader.h:
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
- 12:14 AM Changeset in webkit [148264] by
-
- 18 edits in trunk
Unreviewed, rolling out r148262.
http://trac.webkit.org/changeset/148262
https://bugs.webkit.org/show_bug.cgi?id=114493
Cairo dep should now build, rolling r148247 back in (Requested
by zdobersek on #webkit).
Patch by Commit Queue <rniwa@webkit.org> on 2013-04-12
.:
- Source/autotools/FindDependencies.m4:
- Source/autotools/PrintBuildConfiguration.m4:
- Source/autotools/SetupWebKitFeatures.m4:
Source/WebCore:
- platform/graphics/GraphicsContext.cpp:
(WebCore):
- platform/graphics/ImageBuffer.cpp:
(WebCore):
- platform/graphics/cairo/GLContext.h:
(GLContext):
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::isAcceleratedContext):
(WebCore):
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBufferData::ImageBufferData):
(WebCore):
(WebCore::createCairoGLSurface):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::mapSurfaceToImage):
(WebCore::unmapSurfaceFromImage):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBufferData::paintToTextureMapper):
(WebCore::ImageBuffer::platformLayer):
- platform/graphics/cairo/ImageBufferDataCairo.h:
(ImageBufferData):
- platform/graphics/egl/GLContextEGL.cpp:
(WebCore::GLContextEGL::GLContextEGL):
(WebCore::GLContextEGL::~GLContextEGL):
(WebCore::GLContextEGL::cairoDevice):
(WebCore):
- platform/graphics/egl/GLContextEGL.h:
- platform/graphics/glx/GLContextGLX.cpp:
(WebCore::GLContextGLX::GLContextGLX):
(WebCore::GLContextGLX::~GLContextGLX):
(WebCore::GLContextGLX::cairoDevice):
(WebCore):
- platform/graphics/glx/GLContextGLX.h:
(GLContextGLX):
Tools:
- Scripts/webkitdirs.pm:
(buildAutotoolsProject):
- gtk/jhbuild.modules:
