Timeline



May 13, 2013:

11:52 PM Changeset in webkit [150056] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Make -[WebNavigationData url] the destination of the navigation
https://bugs.webkit.org/show_bug.cgi?id=114904

Reviewed by Dave Kilzer.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::updateGlobalHistory): Initialize the WebNavigationData with the
current URL, not the original request URL.

10:42 PM Changeset in webkit [150055] by eric.carlson@apple.com
  • 6 edits in trunk/Source/WebCore

[Mac] update in-band caption attributes
https://bugs.webkit.org/show_bug.cgi?id=116057

Reviewed by Dean Jackson.

  • html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::updateCueFromCueData): Copy highlight color.

  • html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties): "highlight" color sets the cue

background, "background" color sets the cue container background.

  • html/track/TextTrackCueGeneric.h:
  • platform/graphics/InbandTextTrackPrivateClient.h:
  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::processCueAttributes): Process "highlight" color.

9:09 PM Changeset in webkit [150054] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX (r150049): Fix RetainPtr<> type in PasteboardIOS.mm

  • platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::writeImage): Use RetainPtr<CFStringRef>
instead of RetainPtr<NSString>.

9:04 PM Changeset in webkit [150053] by benjamin@webkit.org
  • 13 edits
    1 delete in trunk/Source/WebCore

Remove platform/graphic's Generator
https://bugs.webkit.org/show_bug.cgi?id=116084

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-13
Reviewed by Darin Adler.

The Generator no longer abstract anything useful, its only
implementation is Gradient.

  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GeneratedImage.h:
  • platform/graphics/Generator.h: Removed.
  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::draw):
(WebCore::GeneratorGeneratedImage::drawPattern):

  • platform/graphics/GeneratorGeneratedImage.h:

(WebCore::GeneratorGeneratedImage::create):
(WebCore::GeneratorGeneratedImage::GeneratorGeneratedImage):
(GeneratorGeneratedImage):

  • platform/graphics/Gradient.h:

(WebCore):
(Gradient):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::fillRect):

  • platform/graphics/GraphicsContext.h:

(WebCore):
(GraphicsContext):

8:36 PM Changeset in webkit [150052] by ryuan.choi@samsung.com
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip several tests which already passed and add png expected results.

  • platform/efl/TestExpectations:
  • platform/efl/editing/selection/doubleclick-crash-expected.png: Added.
  • platform/efl/editing/selection/select-missing-image-expected.png: Added.
8:20 PM Changeset in webkit [150051] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Nightly build's jsc doesn't work without DYLD_FRAMEWORK...
https://bugs.webkit.org/show_bug.cgi?id=79065

Patch by Alvaro Lopez Ortega <alvaro@alobbs.com> on 2013-05-13
Reviewed by Darin Adler.

Fixes the build process so the depencencies of the jsc binary are
modified before its copied to its target directory. In this way
jsc should always use relative reference to the JavaScriptCore
libraries.

the "Copy Into Framework" target.

7:49 PM Changeset in webkit [150050] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Objective-C API: scanExternalObjectGraph should not create new JSVirtualMachine wrappers
https://bugs.webkit.org/show_bug.cgi?id=116074

If scanExternalObjectGraph creates a new JSVirtualMachine wrapper during collection, when the
scanExternalObjectGraph call finishes and the autorelease pool is drained we will dealloc the
JSVirtualMachine which will cause us to try to take the API lock for the corresponding VM.
If this happens on a GC thread other than the "main" thread, we will deadlock. The solution
is to just check the VM cache, and if there is no JSVirtualMachine wrapper, return early.

Reviewed by Darin Adler.

  • API/JSVirtualMachine.mm:

(scanExternalObjectGraph):

7:21 PM Changeset in webkit [150049] by ddkilzer@apple.com
  • 4 edits
    3 adds in trunk/Source/WebCore

Upstream iOS Clipboard and Pasteboard changes
<http://webkit.org/b/116062>

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Clipboard.h:
  • platform/Pasteboard.h:
  • platform/ios/ClipboardIOS.h: Added.
  • platform/ios/ClipboardIOS.mm: Added.
  • platform/ios/PasteboardIOS.mm: Added.
7:14 PM Changeset in webkit [150048] by allan.jensen@digia.com
  • 2 edits in trunk/LayoutTests

compositing/transitions/transform-on-large-layer.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=110099

Reviewed by Darin Adler.

Only set the timeout for test end after the resize event has been
received. This helps slow test bots, and also makes it easier to
tell rendering failures from failures to send resize event.

  • compositing/transitions/transform-on-large-layer.html:
7:11 PM Changeset in webkit [150047] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Mac] Use pageScaleFactor * deviceScaleFactor in requiresTiledLayer() and computePixelAlignment() of GraphicsLayerCA.
https://bugs.webkit.org/show_bug.cgi?id=107359

Patch by Huang Dongsung <luxtella@company100.net> on 2013-05-13
Reviewed by Darin Adler.

Currently GraphicsLayerCA uses pageScaleFactor in requiresTiledLayer() and
computePixelAlignment(), but we must use pageScaleFactor * deviceScaleFactor in
them.
It is because:

  1. requiresTiledLayer() uses the scale to compute an actual layer size in the device

pixel unit.

  1. computePixelAlignment() uses the scale to compute an aligned layer position

in the device pixel unit.

No new tests. We can not test about requiresTiledLayer() because it depends on
gpu. computePixelAlignment() is correct now because fortunately Mac uses
only 2 (for retina display) as a deviceScaleFactor.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::requiresTiledLayer):
(WebCore::GraphicsLayerCA::computePixelAlignment):

7:00 PM Changeset in webkit [150046] by commit-queue@webkit.org
  • 12 edits in trunk

Added testRunner.setPrinting.
https://bugs.webkit.org/show_bug.cgi?id=42693
rdar://problem/8213845

Patch by Alex Christensen <achristensen@apple.com> on 2013-05-13
Reviewed by Darin Adler.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCopyRenderTreeExternalRepresentationForPrinting): Added.

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

Added WKBundlePageCopyRenderTreeExternalRepresentationForPrinting declaration.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::renderTreeExternalRepresentationForPrinting): Added.

  • WebProcess/WebPage/WebPage.h:

Added renderTreeExternalRepresentationForPrinting declaration.

Tools:

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:

Added setPrinting JavaScript function.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump):
Dump the external representation for printing if setPrinting has been called.

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(WTR::TestRunner::isPrinting): Added.
(WTR::TestRunner::setPrinting): Added.
Added and initialized m_isPrinting member boolean.

LayoutTests:

  • platform/wk2/TestExpectations:

Unskipped printing tests.

5:59 PM Changeset in webkit [150045] by Christophe Dumez
  • 27 edits
    3 moves in trunk

Rename BarInfo to BarProp and remove [NoInterfaceObject]
https://bugs.webkit.org/show_bug.cgi?id=116027

Reviewed by Andreas Kling.

Source/WebCore:

Rename BarInfo to BarProp and remove [NoInterfaceObject] extended attribute from
the IDL interface to match the specification:
http://www.w3.org/html/wg/drafts/html/master/browsers.html#barprop

The new behavior also matches Firefox and Blink.

No new tests, covered by LayoutTests/fast/js/global-constructors-attributes.html.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:
  • page/BarProp.cpp: Renamed from Source/WebCore/page/BarInfo.cpp.
  • page/BarProp.h: Renamed from Source/WebCore/page/BarInfo.h.
  • page/BarProp.idl: Renamed from Source/WebCore/page/BarInfo.idl.
  • page/DOMWindow.cpp:
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

Rebaseline fast/js/global-constructors-attributes.html now that there is a new
'BarProp' global constructor.

Rebaseline a few other tests now that BarInfo was renamed to BarProp.

  • fast/dom/Window/window-lookup-precedence-expected.txt:
  • fast/js/global-constructors-attributes-expected.txt:
  • fast/loader/window-properties-restored-from-page-cache-expected.txt:
  • http/tests/security/cross-frame-access-put-expected.txt:
  • platform/efl/fast/js/global-constructors-attributes-expected.txt:
  • platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt:
  • platform/gtk/fast/js/global-constructors-attributes-expected.txt:
  • platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
  • platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:
  • platform/qt/fast/js/global-constructors-attributes-expected.txt:
4:17 PM Changeset in webkit [150044] by andersca@apple.com
  • 6 edits in trunk/Source

Remove ChromeClient::willPopupMenu
https://bugs.webkit.org/show_bug.cgi?id=116063

Reviewed by Andreas Kling.

Source/WebCore:

Remove ChromeClient::willPopupMenu.

  • page/ChromeClient.h:

Source/WebKit/mac:

ChromeClient::willPopupMenu is only called in one place from WebKit, so just move the function to the call site.

  • WebCoreSupport/PopupMenuMac.mm:

(PopupMenuMac::show):

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:
4:16 PM Changeset in webkit [150043] by Beth Dakin
  • 13 edits in trunk/Source/WebCore

Headers and footers should be pinned to the left edge of the window when scrolling
horizontally
https://bugs.webkit.org/show_bug.cgi?id=116061
-and corresponding-
<rdar://problem/13599215>

Reviewed by Simon Fraser.

The scrolling thread will need to know about the header and footer layers in order
the implement this custom scrolling behavior.

These getters will fetch the header or footer layer from the FrameView as
appropriate.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::headerLayerForFrameView):
(WebCore::ScrollingCoordinator::footerLayerForFrameView):

  • page/scrolling/ScrollingCoordinator.h:

When we’re scrolling on the main thread, adjust the position of the header and
footer layers here.
(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):

ScrollingStateScrollingNode now stores GraphicsLayers and PlatformLayers for the
header and footer, just like it already does for the counterScrollingLayer.

  • page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):

  • page/scrolling/ScrollingStateScrollingNode.h:

(ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::headerLayer):
(WebCore::ScrollingStateScrollingNode::footerLayer):

Setters for the new layers.

  • page/scrolling/mac/ScrollingCoordinatorMac.h:

(ScrollingCoordinatorMac):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::frameViewRootLayerDidChange):
(WebCore::ScrollingCoordinatorMac::setHeaderLayerForNode):
(WebCore::ScrollingCoordinatorMac::setFooterLayerForNode):

These setters and getters mirror the existing one for counterScrollingLayer.

  • page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:

(WebCore::ScrollingStateScrollingNode::headerPlatformLayer):
(WebCore::ScrollingStateScrollingNode::setHeaderLayer):
(WebCore::ScrollingStateScrollingNode::footerPlatformLayer):
(WebCore::ScrollingStateScrollingNode::setFooterLayer):

And the ScrollingTree will store CALayers for the header and footer.

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:

(ScrollingTreeScrollingNodeMac):

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::updateBeforeChildren):

This is where the magic happens when we are scrolling on the scrolling thread.
Adjust the horizontal position the behave like a fixed object, but keep the
vertical position what it was when layer was created.
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):

RenderLayerCompositor must now provide getters for the header and footer.

  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::headerLayer):
(WebCore::RenderLayerCompositor::footerLayer):

Set the anchor point for when we adjust the position later on. Also call
frameViewRootLayerDidChange() to get the new layers picked up and sent to the
scrolling tree.
(WebCore::RenderLayerCompositor::updateLayerForHeader):
(WebCore::RenderLayerCompositor::updateLayerForFooter):

4:11 PM Changeset in webkit [150042] by benjamin@webkit.org
  • 8 edits in trunk/Source

Improve stringProtoFuncLastIndexOf for the prefix case
https://bugs.webkit.org/show_bug.cgi?id=115952

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncLastIndexOf):
Use the optimized string search when possible.

On Joseph Pecoraro's tests, this gives a ~30% speed improvement.

Source/WTF:

Add an optimized version of StringImpl::startsWith() for JavaScriptCore.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::startsWith):

  • wtf/text/StringImpl.h:

(StringImpl):
(WTF::StringImpl::startsWith):

  • wtf/text/WTFString.h:

(WTF::String::startsWith):

2:53 PM Changeset in webkit [150041] by timothy@apple.com
  • 32 edits in trunk/Source

Add support for updating the Web Inspector toolbar height.

https://bugs.webkit.org/show_bug.cgi?id=115996

Reviewed by Joseph Pecoraro and Benjamin Poulain.

Source/WebCore:

  • inspector/InspectorFrontendClient.h:

(InspectorFrontendClient):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::setToolbarHeight):

  • inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

  • inspector/InspectorFrontendHost.idl:
  • testing/Internals.cpp:

Source/WebKit/efl:

  • WebCoreSupport/InspectorClientEfl.cpp:

(WebCore::InspectorFrontendClientEfl::setToolbarHeight):

  • WebCoreSupport/InspectorClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorFrontendClient::setToolbarHeight):

  • WebCoreSupport/InspectorClientGtk.h:

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::setToolbarHeight):

Source/WebKit/qt:

  • WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorFrontendClientQt::setToolbarHeight):

  • WebCoreSupport/InspectorClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorFrontendClient::setToolbarHeight):

  • WebCoreSupport/WebInspectorClient.h:

Source/WebKit2:

  • UIProcess/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::setToolbarHeight):
(WebInspectorProxy):

  • UIProcess/WebInspectorProxy.messages.in:
  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformSetToolbarHeight):

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformSetToolbarHeight):
(WebKit):

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformSetToolbarHeight):

  • UIProcess/qt/WebInspectorProxyQt.cpp:

(WebKit::WebInspectorProxy::platformSetToolbarHeight):

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:

(WebKit::WebInspectorFrontendClient::setToolbarHeight):

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:

(WebInspectorFrontendClient):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::setToolbarHeight):

  • WebProcess/WebPage/WebInspector.h:
2:29 PM Changeset in webkit [150040] by dino@apple.com
  • 4 edits
    2 adds in trunk

toDataURL can return an empty image in some cases
https://bugs.webkit.org/show_bug.cgi?id=115981
<rdar://problem/13760256>

Reviewed by Darin Adler.

Source/WebCore:

In some accelerated rendering cases, calling toDataURL on
an off-screen canvas produced an empty image. The solution
was to force a CGContextFlush before extracting the data
for image generation.

While here, I collected the flushing code from other methods
into a single place. Also we were getting into a situation where
we called flush two times in a row.

Test: fast/canvas/toDataURL-not-empty.html

  • platform/graphics/ImageBuffer.h:

(ImageBuffer): Define two new methods flushContext and flushContextIfNecessary.

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::context): Call flushContextIfNecessary.
(WebCore::ImageBuffer::flushContextIfNecessary): Moved the 10.7 code in here.
(WebCore::ImageBuffer::flushContext): Calls CGContextFlush.
(WebCore::ImageBuffer::getUnmultipliedImageData): Call new helper.
(WebCore::ImageBuffer::getPremultipliedImageData): Call new helper.
(WebCore::ImageBuffer::toDataURL): Flush the CG context.

LayoutTests:

Make sure that a canvas with content is not the same as one
without content.

  • fast/canvas/toDataURL-not-empty-expected.txt: Added.
  • fast/canvas/toDataURL-not-empty.html: Added.
2:27 PM Changeset in webkit [150039] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark fast/table/crash-split-table-section-no-cell-recalc.html as crashing
on EFL port.

  • platform/efl/TestExpectations:
2:02 PM Changeset in webkit [150038] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

Regressions in flexbox layout caused by the flexing optimizations.
https://bugs.webkit.org/show_bug.cgi?id=116058
<rdar://problem/13863647>

Reviewed by Beth Dakin.

Roll out the flex-related changes from r149597 so that the layout
algorithm goes back to the way it was. Leave the repainting optimizations
in place though.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::gatherFlexChildrenInfo):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):

1:43 PM Changeset in webkit [150037] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip several tests that stopped crashing after r150030.

  • platform/efl-wk2/TestExpectations:
1:39 PM Changeset in webkit [150036] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark fast/css/variables/var-inside-shape.html as failing on EFL after
r150025.

  • platform/efl/TestExpectations:
1:29 PM Changeset in webkit [150035] by Philippe Normand
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r150014.
http://trac.webkit.org/changeset/150014
https://bugs.webkit.org/show_bug.cgi?id=86410

Broke video playback on WK2 and some webgl tests

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::paint):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

(MediaPlayerPrivateGStreamerBase):

1:07 PM Changeset in webkit [150034] by rniwa@webkit.org
  • 4 edits in trunk/Source

Sometimes NSUndoManager can get into an inconsistent state
https://bugs.webkit.org/show_bug.cgi?id=116050

Reviewed by Enrica Casucci.

Always group undo items to work around a bug in NSUndoManager that manifests
when we call removeAllActionsWithTarget.

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::registerUndoOrRedoStep):

Source/WebKit2:

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::registerEditCommand):

1:06 PM Changeset in webkit [150033] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark fast/animation/request-animation-frame-too-rapid.html as failing on EFL WK2
due to r150015.

  • platform/efl-wk2/TestExpectations:
12:37 PM Changeset in webkit [150032] by hmuller@adobe.com
  • 9 edits
    6 adds
    2 deletes in trunk/LayoutTests

[CSS Exclusions] Simple shape-outside tests fail when subpixel layout is disabled
https://bugs.webkit.org/show_bug.cgi?id=115767

Reviewed by Dirk Schulze.

The overall goal of this change was to restore the (last) four excluded exclusions ref-tests
by making them work correctly when subpixel layout is disabled. All of the tests were
substantially simplified, as was the supporting javascript code. The original
shape-outside-floats-simple-rounded-rectangle test was replaced by three separate tests
because the original was bigger then then the 800x600 limit and because it unncessarily
combined three indepedent test cases.

  • fast/exclusions/resources/rounded-rectangle.js:

(ellipseXIntercept): Return the 1st quadrant X intercept for an ellipse given a first quadrant Y intercept.
(scanConvertRoundedRectangleOutside): Return the line segment intervals that overlap a rounded rectangle.
(genLeftRightRoundedRectFloatShapeOutsideRefTest): Insert a stack of float divs that match the left or right edge of a rounded rectangle.

  • fast/exclusions/shape-outside-floats/shape-outside-floats-non-zero-y-expected.html:
  • fast/exclusions/shape-outside-floats/shape-outside-floats-non-zero-y.html:
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle-expected.html:
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle.html:
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse-expected.html:
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse.html:
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-001-expected.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-001.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-002-expected.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-002.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-003-expected.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-003.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-expected.html: Removed.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle.html: Removed.
  • platform/mac/TestExpectations:
12:35 PM Changeset in webkit [150031] by Christophe Dumez
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r150022.
http://trac.webkit.org/changeset/150022
https://bugs.webkit.org/show_bug.cgi?id=114044

Causes assertions in media tests

Source/WebCore:

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition):
(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay):
(WebCore::MediaPlayerPrivateGStreamer::currentTime):
(WebCore::MediaPlayerPrivateGStreamer::seek):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

LayoutTests:

  • media/video-seek-after-end-expected.txt: Removed.
  • media/video-seek-after-end.html: Removed.
12:31 PM Changeset in webkit [150030] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

[WK2] Crash in WebKit::StorageAreaMap::didSetItem()
https://bugs.webkit.org/show_bug.cgi?id=116026

Reviewed by Andreas Kling.

Make sure that we ignore any leftover messages from the UI process after we've reset
the storage map. Achieve this by keeping a seed count in the StorageAreaMap object that's incremented
everytime the map is reset. Associate every storage area change with the seed and ignore any incoming
notification messages from the UI process if the seeds are different.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC):
(CoreIPC::callMemberFunction):

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::getValues):
(WebKit::StorageManager::setItem):
(WebKit::StorageManager::removeItem):
(WebKit::StorageManager::clear):

  • UIProcess/Storage/StorageManager.h:

(StorageManager):

  • UIProcess/Storage/StorageManager.messages.in:
  • WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::StorageAreaMap):
(WebKit::StorageAreaMap::setItem):
(WebKit::StorageAreaMap::removeItem):
(WebKit::StorageAreaMap::clear):
(WebKit::StorageAreaMap::resetValues):
(WebKit::StorageAreaMap::loadValuesIfNeeded):
(WebKit::StorageAreaMap::didGetValues):
(WebKit::StorageAreaMap::didSetItem):
(WebKit::StorageAreaMap::didRemoveItem):
(WebKit::StorageAreaMap::didClear):
(WebKit::StorageAreaMap::applyChange):

  • WebProcess/Storage/StorageAreaMap.h:

(StorageAreaMap):

  • WebProcess/Storage/StorageAreaMap.messages.in:
12:30 PM Changeset in webkit [150029] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Source/WebCore: Floats should not overhang from flex items
https://bugs.webkit.org/show_bug.cgi?id=115925

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-13
Reviewed by David Hyatt.

Allowing floats to overhand from flex items is not only against the
spec, it causes bad bugs. Fix this by having flex items properly avoid
floats.

Test: fast/block/float/float-not-removed-crash2.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::avoidsFloats): Add flex items to avoid floats.

  • rendering/RenderBox.h:

(WebCore::RenderBox::isFlexItemIncludingDeprecated): Determine if the current box is a

flex item or deprecated flex item.

LayoutTests: Fix the float logic to not return an anonymous block ancestor
https://bugs.webkit.org/show_bug.cgi?id=115925

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-13
Reviewed by David Hyatt.

Cleaned up fuzzer test. Note that this will only crash when run under
a memory checker like ASAN.

  • fast/block/float/float-not-removed-crash2-expected.txt: Added.
  • fast/block/float/float-not-removed-crash2.html: Added.
12:23 PM Changeset in webkit [150028] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[webkitpy] Make FileInfo.repository_name support SVN version > 1.6
https://bugs.webkit.org/show_bug.cgi?id=116016

Reviewed by Dirk Pranke.

Same fix as in the upstream style checker, but without hg support.
( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )

  • Scripts/webkitpy/style/checkers/cpp.py:

(FileInfo.repository_name):

12:11 PM Changeset in webkit [150027] by zoltan@webkit.org
  • 10 edits
    1 copy
    13 adds in trunk

[CSS Regions][CSS Exclusions] Shape-inside on regions should respect region borders and paddings
https://bugs.webkit.org/show_bug.cgi?id=115456

Reviewed by David Hyatt.

I refactored the computation logic of shape-inside on regions by removing access to RenderFlowThread from ExclusionShapeInfo's logicalTopOffset
function, this means all the logic is now existing in RenderBlockLineLayout.cpp. By modifying the logicalTopOffset it turned out that the borders
and padding hadn't worked correctly, since borders and paddings were counted twice in the shape-inside's computation. This patch adds the necessary
modifications to let it respect the borders and padding in the correct way. I created 2 new helper functions to prevent increasing the code size of
the layoutRunsAndFloatsInRange function.

Source/WebCore:

I introduced 7 new tests to test for testing the correct behavior.

Tests: fast/regions/shape-inside/shape-inside-on-first-region-block-content.html

fast/regions/shape-inside/shape-inside-on-first-region-inline-content.html
fast/regions/shape-inside/shape-inside-on-second-region-block-content.html
fast/regions/shape-inside/shape-inside-on-second-region-inline-content.html
fast/regions/shape-inside/shape-inside-on-regions-inline-content.html
fast/regions/shape-inside/shape-inside-with-region-borders.html
fast/regions/shape-inside/shape-inside-with-region-padding.html

  • rendering/ExclusionShapeInfo.cpp:

(WebCore): Remove FlowThread logic from logicalTopOffset move definition to header.

  • rendering/ExclusionShapeInfo.h:

(WebCore::ExclusionShapeInfo::logicalTopOffset): Moved from cpp.
(WebCore::ExclusionShapeInfo::logicalLeftOffset): Add condition for RenderRegions.

  • rendering/RenderBlock.h:

(RenderBlock): Add definition to the new helper members.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutExclusionShapeInsideInfo): Modified the flow thread case to return the appropriate region.
(WebCore::RenderBlock::updateLineBoundariesForExclusions): Added new helper function. Modify the shape-inside on regions
line boundaries and position computation logic.
(WebCore::RenderBlock::adjustLogicalLineTopAndLogicalHeightIfNeeded): Added new helper function which handles the flow thread case also.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Modified the code to use the helper functions.

LayoutTests:

  • fast/regions/shape-inside/shape-inside-on-additional-regions-expected.html: Modify to not use shape-inside for testing.
  • fast/regions/shape-inside/shape-inside-on-additional-regions.html: Fix the shape-inside's dimension.
  • fast/regions/shape-inside/shape-inside-on-first-region-block-content-expected.html: Added.
  • fast/regions/shape-inside/shape-inside-on-first-region-block-content.html: Added.
  • fast/regions/shape-inside/shape-inside-on-first-region-inline-content-expected.html: Added.
  • fast/regions/shape-inside/shape-inside-on-first-region-inline-content.html: Added.
  • fast/regions/shape-inside/shape-inside-on-regions-expected.html: Match the shape-inside height to the container's height.
  • fast/regions/shape-inside/shape-inside-on-regions-inline-content-expected.html: Added.
  • fast/regions/shape-inside/shape-inside-on-regions.html: Match the shape-inside height to the container's height.
  • fast/regions/shape-inside/shape-inside-on-second-region-block-content-expected.html: Added.
  • fast/regions/shape-inside/shape-inside-on-second-region-block-content.html: Added.
  • fast/regions/shape-inside/shape-inside-on-second-region-inline-content-expected.html: Added.
  • fast/regions/shape-inside/shape-inside-on-second-region-inline-content.html: Added.
  • fast/regions/shape-inside/shape-inside-with-region-borders-expected.html: Added.
  • fast/regions/shape-inside/shape-inside-with-region-borders.html: Added.
  • fast/regions/shape-inside/shape-inside-with-region-padding-expected.html: Added.
  • fast/regions/shape-inside/shape-inside-with-region-padding.html: Added.
12:06 PM Changeset in webkit [150026] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit/win

Unreviewed. AppleWin VS2005 build fix.

  • WebKit.vcproj/WebKitExports.def.in:
11:37 AM Changeset in webkit [150025] by betravis@adobe.com
  • 3 edits
    2 adds in trunk

[css exclusions] Enable CSS Exclusions by default when CSS_EXCLUSIONS is set
https://bugs.webkit.org/show_bug.cgi?id=115919

Reviewed by Dean Jackson.

Source/WebCore:

Change the RuntimeEnabledFeatures::isCSSExclusionsEnabled boolean to default
to true. CSS Exclusions can still be enabled / disabled in platforms by
setting the CSS_EXCLUSIONS compile flag in one of the FeatureDefine files.

Test: fast/exclusions/css-exclusions-enabled.html

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

LayoutTests:

Adding a test to make sure CSS Exclusions can be enabled, and are enabled by
default.

  • fast/exclusions/css-exclusions-enabled-expected.txt: Added.
  • fast/exclusions/css-exclusions-enabled.html: Added.
11:24 AM Changeset in webkit [150024] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][CoordinatedGraphics] Avoid dispensable calls to WebView::updateViewportSize()
https://bugs.webkit.org/show_bug.cgi?id=116045

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2013-05-13
Reviewed by Darin Adler.

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::setSize):

11:16 AM Changeset in webkit [150023] by commit-queue@webkit.org
  • 30 edits
    3 adds in trunk

Cell heights are disproportional when a row-spanning cell contains a block element that determines the height of the rows
https://bugs.webkit.org/show_bug.cgi?id=52185

Patch by Suchit Agrawal <a.suchit@samsung.com> on 2013-05-13
Reviewed by David Hyatt.

Source/WebCore:

Cells heights are not proper when rowspan cell have its own height and rowspan height
is more than the height of the rows present in rowspan.

After calculating logical height of the rows in the table, we are recalculating the height
of the rows present in rowspan. Based on the ratio of row's logical height, we are
distributing rowspan cell height in rows.

Test: fast/table/table-rowspan-height-distribution-in-rows.html

  • rendering/RenderTableSection.cpp:

(WebCore):

Update the logical height of the rows based on rowspan cell height.
(WebCore::RenderTableSection::distributeRowSpanHeightToRows):

It calculates logical height of the rows in the table.
(WebCore::RenderTableSection::calcRowLogicalHeight):

Added new private API to distribute rowSpan cell height in rows.

  • rendering/RenderTableSection.h:

(RenderTableSection):

LayoutTests:

Test case updated.

  • fast/css/vertical-align-baseline-rowspan-007.htm:

Reference Test cases updated.

  • fast/css/vertical-align-baseline-rowspan-007-expected.html:
  • fast/css/vertical-align-baseline-rowspan-008-expected.html:

Added test cases based on changes in the code and different scenarios for rowspan height
distribution in rows.

  • fast/table/table-rowspan-height-distribution-in-rows.html: Added.
  • platform/qt/fast/table/table-rowspan-height-distribution-in-rows-expected.png: Added.
  • platform/qt/fast/table/table-rowspan-height-distribution-in-rows-expected.txt: Added.

Test cases need to rebaseline in qt, efl, gtk and mac platforms.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:

Test case results are updated in qt platform.

  • platform/qt/tables/mozilla/bugs/bug17548-expected.png:
  • platform/qt/tables/mozilla/bugs/bug17548-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug220536-expected.png:
  • platform/qt/tables/mozilla/bugs/bug220536-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug7714-expected.png:
  • platform/qt/tables/mozilla/bugs/bug7714-expected.txt:
  • platform/qt/tables/mozilla/core/bloomberg-expected.png:
  • platform/qt/tables/mozilla/core/bloomberg-expected.txt:
  • platform/qt/tables/mozilla/other/test6-expected.png:
  • platform/qt/tables/mozilla/other/test6-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug1010-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug6933-expected.txt:
  • tables/mozilla/core/bloomberg-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
10:07 AM Changeset in webkit [150022] by kbalazs@webkit.org
  • 4 edits
    2 adds in trunk

[GStreamer] cannot seek after video finished
https://bugs.webkit.org/show_bug.cgi?id=114044

Patch by Balazs Kelemen <b.kelemen@sisa.samsung.com> on 2013-04-30
Reviewed by Philippe Normand.

Source/WebCore:

Test: media/video-seek-after-end.html

Rework the seeking logic to be able to seek after reseting the pipeline.
In addition to solve the actual problem this patch supposed to make seeking
more robust and correct.
The previous implementation tried to hide the complexity of asynchronous operations
on the pipeline. It did not handle the GST_MESSAGE_ASYNC_DONE message from the bus
but instead reported the seek as finished when it saw an asynchronous pending state
(GST_STATE_CHANGE_ASYNC) which could happen way before the seek is really done.
Now we pay attention to the GST_MESSAGE_ASYNC_DONE message to track the status of seeks.
Seeks are not the only operations executed asynchronously, changing the pipeling state is
similar. It means a seek can overlap with onother ongoing asynchronous operation.
This change address this by introducing an invariant for seeks, which is that we only request
a seek if there are no other ongoing asynchronous operations and the pipeline state is either
paused or playing (which is recommended anyway according to GStreamer's documentation).
This way we can be sure that the time when we get the next GST_MESSAGE_ASYNC_DONE message the
seek has been completed.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::toGstClockTime): Factored time conversation into a helper.
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):

(WebCore::MediaPlayerPrivateGStreamer::playbackPosition): The position might not be available
if the pipeline still has a pending state. As a workaround, if we are right after a seek we can
use the seek time. Avoiding this situation would be possible by not allowing any asynchronous
operation to overlap. I believe it would add a lot more complexity so I decided to rather introduce
this workaround. Otherwise those overlapping operations are handled fine by GStreamer.

(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): Do not reset internal state variables.
This function called when there is an intent to restart playback but it does not actually restart it.
(WebCore::MediaPlayerPrivateGStreamer::currentTime): Just removed a staling newline.
(WebCore::MediaPlayerPrivateGStreamer::seek): Take a look to the pipeline state and act upon that.
If there is an ongoing asynchronous operation make the seek pending, otherwise do it now.
Now we handle overlapping seeks as well because I saw that it can happen in some tests.
Added an early return for live streams as it doesn't makes sense to try seeking in them.

(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Handle GST_MESSAGE_ASYNC_DONE and some refactoring.
(WebCore::MediaPlayerPrivateGStreamer::asyncStateChangeDone):
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Only handle seeks in the pending case, the rest is
now handled in asyncStateChangeDone.
(WebCore::MediaPlayerPrivateGStreamer::cacheDuration): Do not reset the m_mediaDurationKnown if the pipeline
has an asynchronous pending state because it would fail. It does actually happen when we get a duration message
after restarting the pipeline and it would result in restarting playback from the start. It seems to be a bug
in GStreamer that it sends the duration message too early. Also sanitized this function by merging redundant branches.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

LayoutTests:

  • media/video-seek-after-end-expected.txt: Added.
  • media/video-seek-after-end.html: Added.
9:44 AM Changeset in webkit [150021] by jocelyn.turcotte@digia.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix a crash on startup in FrameLoaderClientQt::callPolicyFunction with MSVC

Reviewed by Allan Sandfeld Jensen.

It's not clear why it crashes, but here's my guess by looking at the generated
assembly code:
Since we're using a member function pointer to PolicyChecker, the representation
is not necessarily just a simple pointer and might be a bigger structure used
to handle virtual functions resolution.
For a function taking such a function "pointer" as parameter, the compiler doesn't
seem to have the caller and callee agree on which convention to use if the function
pointer's class is non-virtual and only one of the ends doesn't know about it.

Including the definition of the member function pointer's class fixes the crash.

  • WebCoreSupport/FrameLoaderClientQt.cpp:
9:19 AM Changeset in webkit [150020] by jonlee@apple.com
  • 3 edits in trunk/Source/WebKit2

[WK2] Notification manager removal should not be tied to termination of web processes
https://bugs.webkit.org/show_bug.cgi?id=116038
<rdar://problem/10968680>

Reviewed by Ryosuke Niwa.

WebNotificationManagerProxy incorrectly removes the manager when web processes close.
Since it is a supplemental on the web context, the manager should only be removed
when the context is destroyed.

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:
  • UIProcess/Notifications/WebNotificationManagerProxy.h: Remove implementation of

processDidClose().

9:19 AM Changeset in webkit [150019] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WTF

Unreviewed. Fix Qt Linux MIPS32R2 build after r149879.

Bring back GLIB_CHECK_VERSION for GBytes since Qt Linux MIPS32R2
depends on glib 2.24.2.

  • wtf/gobject/GRefPtr.cpp:

(_GBytes):
(WTF::refGPtr):
(WTF::derefGPtr):

8:45 AM Changeset in webkit [150018] by Martin Robinson
  • 3 edits
    2 adds in trunk/Source/WebKit2

[GTK] [WebKit2] Use a template file for generated GObject enum files
https://bugs.webkit.org/show_bug.cgi?id=115867

Reviewed by Carlos Garcia Campos.

  • GNUmakefile.am: Use a template file instead of specifying portions of the file on the command-line.
  • UIProcess/API/gtk/WebKitEnumTypes.cpp.template: Added.
  • UIProcess/API/gtk/WebKitEnumTypes.h.template: Added.
  • UIProcess/API/gtk/WebKitFindController.cpp: We can no longer rely on WebKitEnumTypes.h to pull in WebKitWebView.h.
8:45 AM Changeset in webkit [150017] by akling@apple.com
  • 1 edit in trunk/Source/WebKit/mac/ChangeLog

Remove accidental unrelated ChangeLog entry from r150016.

8:29 AM Changeset in webkit [150016] by Darin Adler
  • 6 edits in trunk/Source

Source/WebCore: [Mac] Move writeRange/PlainText/URL from ClipboardMac to PasteboardMac
https://bugs.webkit.org/show_bug.cgi?id=116009

Reviewed by Andreas Kling.

  • dom/Clipboard.cpp:

(WebCore::Clipboard::writeRange): Added. Moved from ClipboardMac,
but added some FIXMEs.
(WebCore::Clipboard::writePlainText): Ditto.
(WebCore::Clipboard::writeURL): Ditto.

  • dom/Clipboard.h: Made writeURL, writeRange, and writePlainText

non-virtual in non-legacy clipboard implementations.

  • platform/mac/ClipboardMac.h: Removed writeRange, writeURL, and

writePlainText.

  • platform/mac/ClipboardMac.mm: Ditto.

Source/WebKit/mac: [Mac] Layer-backed WebViews draw their background color even when setDrawsBackground:NO was called
https://bugs.webkit.org/show_bug.cgi?id=116014
<rdar://problem/12781227>

Reviewed by Andreas Kling.

  • WebView/WebFrame.mm:

(-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]): Remove calls to setBackgroundColor: and
setDrawsBackground: on the document view. These were added to support a hypothetical document view
that wanted to draw its background like WebHTMLView does, but this was never communicated as a
document view protocol, formal or informal, and it's unlikely that it was ever used. The bug was
caused because there is an -[NSView setDrawsBackground:] method, probably an internal one, and we
were calling it unintentionally on a WebHTMLView.

8:29 AM Changeset in webkit [150015] by commit-queue@webkit.org
  • 10 edits in trunk/Source

[CoordGfx] requestAnimationFrame performance issues
https://bugs.webkit.org/show_bug.cgi?id=112345

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-05-13
Reviewed by Jocelyn Turcotte.

Source/WebCore:

Removed current requestAnimationFrame logic from CoordinatedGraphics. The new logic
is entirely in WebKit2 CoordinatedLayerTreeHost.

Covered by existing tests in fast/animations.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::CoordinatedGraphicsScene):
(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

(CoordinatedGraphicsScene):

Source/WebKit2:

Changed the logic of requestAnimationFrame in Coordinated Graphics.
We don't send any IPC messages for requestAnimationFrame. Instead, we do one of two things:

  • If there is already a frame pending in the UI process, do nothing, as the animations would be serviced when the frame is returned to the web process.
  • If there is no frame pending, we schedule a flush, making sure that that flush occurs at least 1/60 seconds after the last animation service, so that we don't get an infinite loop of flushes.
  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:

(WebKit::CoordinatedLayerTreeHostProxy::requestAnimationFrame):

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::flushPendingLayerChanges):
(WebKit::CoordinatedLayerTreeHost::scheduleAnimation):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.messages.in:
8:14 AM Changeset in webkit [150014] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[texmap][GStreamer] Composited Video support
https://bugs.webkit.org/show_bug.cgi?id=86410

Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-05-13
Reviewed by Philippe Normand.

Enable the video accelerated compositing using the WebKit's
TextureMapper.

This patch does not use hardware accelerated video decoding. It
provides a generic path for system memory buffers.

No new tests, already covered by existing tests.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore):
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture): update the
texture content with the new received video buffer.
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint): choose to
use the accelerated compositing or the normal code path
(WebCore::MediaPlayerPrivateGStreamerBase::paint): if accelerated
compositing is used this method is halted.
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper): get
a texture from the pool and draws it if it is already available.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

(MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::platformLayer): returns itself
(WebCore::MediaPlayerPrivateGStreamerBase::supportsAcceleratedRendering):
returns true

8:05 AM Changeset in webkit [150013] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Document: Use a DeferrableOneShotTimer to throw out StyleResolver when unused.
<http://webkit.org/b/115929>

Reviewed by Anders Carlsson.

Nothing exciting here, just replacing a rickety-looking punting mechanism with a proper
DeferrableOneShotTimer. Note that the timeout changes from 60 to 30 seconds because DOST
works by punting a full interval on next timeout.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::didAccessStyleResolver):
(WebCore::Document::styleResolverThrowawayTimerFired):

  • dom/Document.h:

(Document):

7:59 AM Changeset in webkit [150012] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

[WK2][CoordinatedGraphics] WKView needs API for handling opacity
https://bugs.webkit.org/show_bug.cgi?id=116032

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2013-05-13
Reviewed by Kenneth Rohde Christiansen.

Add WKViewSetOpacity and WKViewOpacity APIs and use them in
WebView.cpp.

  • UIProcess/API/C/CoordinatedGraphics/WKView.cpp:

(WKViewSetOpacity):
(WKViewOpacity):

  • UIProcess/API/C/CoordinatedGraphics/WKView.h:
  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::WebView):
(WebKit::WebView::paintToCurrentGLContext):

  • UIProcess/CoordinatedGraphics/WebView.h:

(WebKit::WebView::setOpacity):
(WebKit::WebView::opacity):
(WebView):

7:55 AM Changeset in webkit [150011] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION(r149287): FoldingText only shows me half of my text.
<http://webkit.org/b/115956>
<rdar://problem/13831099>

Reviewed by Antti Koivisto.

Check if the FrameView geometry changed post-layout, and send a resize event if needed.
This brings us closer to the original resize event behavior, with the exception that
setFrameRect() still fires an event right away if possible. This means we are still
guarded from FOUC's but frames that layout via [WebHTMLView layoutToMinimumPageWidth]
also get resize events like they used to.

No new tests, because I don't know how to test this.

  • page/FrameView.h:
  • page/FrameView.cpp:

(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::sendResizeEventIfNeeded):

Factor out the resize event logic from setFrameRect() so we can call it from both
there and performPostLayoutTasks(). sendResizeEventIfNeeded() only sends an event
if view geometry or zoom factor has changed since last time it was called.

7:26 AM Changeset in webkit [150010] by Antti Koivisto
  • 10 edits in trunk/Source

Remove unneeded counters from ScopeContentDistribution.
https://bugs.webkit.org/show_bug.cgi?id=116028

Reviewed by Andreas Kling.

They don't do much.

  • WebCore.exp.in:
  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot):

  • dom/ShadowRoot.h:


No need for registration code anymore.

  • html/shadow/ContentDistributor.cpp:

(WebCore::ScopeContentDistribution::ScopeContentDistribution):

Default m_insertionPointListIsValid to true to avoid crawling when there are no InsertionPoints.

(WebCore::ScopeContentDistribution::ensureInsertionPointList):
(WebCore::ScopeContentDistribution::registerInsertionPoint):
(WebCore::ScopeContentDistribution::unregisterInsertionPoint):

  • html/shadow/ContentDistributor.h:


Remove distributeNodeChildrenTo, it was only used by the older/younger shadow root code.

  • testing/Internals.cpp:
  • testing/Internals.h:
  • testing/Internals.idl:
7:10 AM EFLHistoryApiTutorial edited by saulo@gmx.com
(diff)
7:03 AM Changeset in webkit [150009] by commit-queue@webkit.org
  • 2 edits
    1 delete in trunk/PerformanceTests

Web Inspector: Get rid of native-memory-snapshot in performance test
https://bugs.webkit.org/show_bug.cgi?id=116013

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-13
Reviewed by Andreas Kling.

Remove native-memory-snapshot.html from PerformanceTests.

  • inspector/native-memory-snapshot.html: Removed.
  • inspector/performance-test.js:

(initialize_TimeTracker.Timer):
(initialize_TimeTracker.Timer.prototype._dump):
(initialize_TimeTracker.InspectorTest.runPerformanceTest):

6:55 AM Changeset in webkit [150008] by zandobersek@gmail.com
  • 4 edits in trunk

[GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
https://bugs.webkit.org/show_bug.cgi?id=115918

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Due to layer violations and circular dependencies the WebKitPluginProcess requires for the
libraries containing the built code of the intertwining Platform and WebCore layers to be
specified multiple times when linking. This can be avoided by packing the two layers' archives
into one big archive, named after the WebCore layer due to no clear boundary between it and the
Platform layer. The big archive can then be specified only once when linking, simplifying the code
and suppressing all the layering violations so they do not cause build problems.

First the libtool libraries that the WebCore layer (as required by the WebKitPluginProcess) depends on
are specified. These are then used as dependencies for the archive creation rule as well as the list
from which the archive file paths are constructed and then used to dump the member files from these archives.
The member files are then added to the big archive. The latter is added to the list of libraries the
WebKitPluginProcess requires to successfully link.

  • GNUmakefile.am:

Tools:

Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
when linking, simplifying the code and suppressing all the layering violations so they do not cause build
problems.

First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
These are then used as dependencies for the archive creation rule as well as the list from which the archive
file paths are constructed and then used to dump the member files from these archives. The member files are
then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
successfully link.

  • TestWebKitAPI/GNUmakefile.am:
6:52 AM Changeset in webkit [150007] by andersca@apple.com
  • 11 edits
    1 delete in trunk

Remove UnusedParam.h
https://bugs.webkit.org/show_bug.cgi?id=116029

Reviewed by Andreas Kling.

Source/WTF:

Remove UnusedParam.h, it's empty now.

  • GNUmakefile.list.am:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/UnusedParam.h: Removed.

Tools:

Stop including UnusedParam.h.

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
  • WebKitTestRunner/qt/TestInvocationQt.cpp:
6:14 AM Changeset in webkit [150006] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.0.2

Tagging the WebKitGTK+ 2.0.2 release

5:30 AM Changeset in webkit [150005] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.0

Unreviewed. Update NEWS and Versions.m4 for 2.0.2 release.

.:

  • Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Added release notes for 2.0.2.
4:32 AM Changeset in webkit [150004] by Christophe Dumez
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark several test cases as crashing on EFL port.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
4:08 AM Changeset in webkit [150003] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark 2 ref tests as failing on EFL port.

  • platform/efl/TestExpectations:
4:00 AM Changeset in webkit [150002] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip 2 HTTP tests that time out of EFL port.

  • platform/efl/TestExpectations:
3:53 AM Changeset in webkit [150001] by Christophe Dumez
  • 1 edit
    6 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Provide EFL baselines for several compositing test cases.

  • platform/efl/compositing/backing/no-backing-for-clip-overhang-expected.txt: Added.
  • platform/efl/compositing/contents-opaque/hidden-with-visible-child-expected.txt: Added.
  • platform/efl/compositing/contents-opaque/hidden-with-visible-text-expected.txt: Added.
  • platform/efl/compositing/contents-opaque/overflow-hidden-child-layers-expected.txt: Added.
3:50 AM Changeset in webkit [150000] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Remove unused references from projects in Visual Studio
https://bugs.webkit.org/show_bug.cgi?id=116002

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-13
Reviewed by Csaba Osztrogonác.

nativeMemoryProfiler.css and NativeMemorySnapshotView.js were removed in r149807.

No new tests, no behavior change.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
1:53 AM Changeset in webkit [149999] by commit-queue@webkit.org
  • 20 edits in trunk

WebProcess consuming very high CPU on linkedin.com
https://bugs.webkit.org/show_bug.cgi?id=115601

Patch by Zalan Bujtas <Alan Bujtas> on 2013-05-13
Reviewed by Andreas Kling.

Disable WEB_TIMING_MINIMAL.
Turn off window.performance and performance.now(). Some JS frameworks expect
additional Web Timing APIs, when performance.now() is available.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • dom/EventTargetFactory.in:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::resetDOMWindowProperties):
(WebCore):

  • page/DOMWindow.h:

(DOMWindow):

  • page/DOMWindow.idl:
  • page/Performance.cpp:

(WebCore::Performance::timing):

  • page/Performance.h:

(Performance):

  • page/Performance.idl:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

LayoutTests:

  • platform/mac/TestExpectations:
  • fast/js/global-constructors-attributes-expected.txt:
1:37 AM Changeset in webkit [149998] by Darin Adler
  • 2 edits in trunk/Source/WebKit/mac

[Mac] Layer-backed WebViews draw their background color even when setDrawsBackground:NO was called
https://bugs.webkit.org/show_bug.cgi?id=116014
<rdar://problem/12781227>

Reviewed by Dan Bernstein.

  • WebView/WebFrame.mm:

(-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]): Remove calls to setBackgroundColor: and
setDrawsBackground: on the document view. These were added to support a hypothetical document view
that wanted to draw its background like WebHTMLView does, but this was never communicated as a
document view protocol, formal or informal, and it's unlikely that it was ever used. The bug was
caused because there is an -[NSView setDrawsBackground:] method, probably an internal one, and we
were calling it unintentionally on a WebHTMLView.

12:55 AM Changeset in webkit [149997] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk

Merge r149666 - [GTK] Initialize WebKitWebPlugin path to prevent double-free
https://bugs.webkit.org/show_bug.cgi?id=115624

Patch by Tomas Popela <tpopela@redhat.com> on 2013-05-07
Reviewed by Carlos Garcia Campos.

Use GOwnPtr for WebKitWebPlugin path to prevent double-free
situations. Also use GOwnPtr for GError in webkit_web_plugin_get_path.

  • webkit/webkitwebplugin.cpp:

(webkit_web_plugin_finalize):
(webkit_web_plugin_get_path):

  • webkit/webkitwebpluginprivate.h:
12:46 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
12:43 AM Changeset in webkit [149996] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r149735 - [GStreamer] Does memory buffering even with preload set to none
https://bugs.webkit.org/show_bug.cgi?id=115754

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-05-08
Reviewed by Philippe Normand.

Covered by existing tests.

Revision 148840 fixed on-disk buffering being done when preload is set to none,
but memory buffering is still being done. That is because setting the state to
paused causes GStreamer to start loading the media, to gather information. Only
doing that when committing the load avoids that while maintaining the tested
behaviour unchanged.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::load): move setting pause state to commitLoad.
(WebCore::MediaPlayerPrivateGStreamer::commitLoad): see above.

12:33 AM Changeset in webkit [149995] by kadam@inf.u-szeged.hu
  • 1 edit
    6 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Added platform specific expected files.

  • platform/qt-5.0-wk1/compositing/backing/no-backing-for-clip-overhang-expected.txt: Added after r149969.
  • platform/qt-5.0-wk2/compositing/contents-opaque/hidden-with-visible-child-expected.txt: Added after r149915.
  • platform/qt-5.0-wk2/compositing/contents-opaque/hidden-with-visible-text-expected.txt: Added after r149915.
  • platform/qt-5.0-wk2/compositing/contents-opaque/overflow-hidden-child-layers-expected.txt: Added after r149914.
  • platform/qt/compositing/backing/no-backing-for-clip-overhang-expected.txt: Added after r149969.
12:20 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
12:18 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
12:17 AM Changeset in webkit [149994] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge r149494 - Updated WebKitGTK+ Translation for Odia [or] language.
https://bugs.webkit.org/show_bug.cgi?id=115030

Patch by Manoj Kumar Giri <mgiri@redhat.com> on 2013-05-02
Reviewed by Gustavo Noronha Silva.

  • or.po: updated translation.
12:15 AM Changeset in webkit [149993] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk

Merge r149486 - Segmentation Fault with Romanian locale. Evolution not starting.
https://bugs.webkit.org/show_bug.cgi?id=115484

Reviewed by Darin Adler.

Do not translate the property names that are being passed to the g_param_spec_boolean
method - it is not required and is causing segfaults with various locales.

  • webkit/webkitviewportattributes.cpp:

(webkit_viewport_attributes_class_init):

12:14 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
12:11 AM Changeset in webkit [149992] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r149192 - [GTK] Compilation of ProcessLauncherGtk.cpp fails due to unresolved symbols
https://bugs.webkit.org/show_bug.cgi?id=115240

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2013-04-26
Reviewed by Martin Robinson.

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: Includes sys/socket.h if OS is Linux
12:07 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)

May 12, 2013:

11:55 PM Changeset in webkit [149991] by Carlos Garcia Campos
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-2.0

Merge r148840 - [GStreamer] Media attribute preload="none" is not honored
https://bugs.webkit.org/show_bug.cgi?id=114357

Reviewed by Philippe Normand.

Source/WebCore:

Fix the logic that prevents live streams from being buffered to not make preload="none" ignored.

Test: http/tests/media/video-preload.html
We need a http test because the bug does not triggered with local files.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):
Remove m_originalPreloadWasAutoAndWasOverridden because it is not necessary and it is causing this bug.
Currently if the tag has preload="none" attribute we set m_preload to Auto in the constructor. After that
MedaPlayer calls setPreload(None), so we set m_originalPreloadWasAutoAndWasOverridden to true and later
reset m_preload to Auto. The error prone factor here is that the m_preload member is repeated in the
private class and setPreload is also used there. This seems to be necessary because we need to be able
to ignore preloading if this is a live stream. Fortunately the original parsed value is available in the
constructor, so we can use that. This will give the correct value that we should override only in the case
of a live stream and that's it, we don't need to reset it later to Auto.
Furthermore, we should ignore setting preload to auto from js if it is a live stream. This patch also handles
this with an early return in setPreload.

LayoutTests:

  • http/tests/media/video-preload-expected.txt: Added.
  • http/tests/media/video-preload.html: Added.
11:52 PM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
11:48 PM Changeset in webkit [149990] by Carlos Garcia Campos
  • 8 edits in releases/WebKitGTK/webkit-2.0

Merge r148788 - [GTK] Fix unit test webkit2/WebKitFindController/hide
https://bugs.webkit.org/show_bug.cgi?id=89810

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-20
Reviewed by Carlos Garcia Campos.

Source/WebKit2:

The test had some hacks in order to compare a page with highlighted
results after using the find command with the original page. Now it uses
the snapshots API that allows to make the test simpler and more
reliable.

  • UIProcess/API/gtk/tests/TestMain.h:

(Test::cairoSurfacesEqual): Moved helper function to compare two cairo
surfaces from TestWebKitWebView.
(Test):

  • UIProcess/API/gtk/tests/TestWebKitFindController.cpp:

(testFindControllerHide): Modify test to use snapshots.

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewSnapshot): Move basic snapshop methods to WebViewTest to
share them with TestWebKitFindController test.

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::WebViewTest): Initialize cairo surface.
(WebViewTest::~WebViewTest): Destroy cairo surface.
(onSnapshotReady): Callback to set the cairo surface when the snapshot
is ready.
(WebViewTest::getSnapshotAndWaitUntilReady): Method that takes a
snapshot and returns the cairo surface when it is ready.

  • UIProcess/API/gtk/tests/WebViewTest.h: Add new method headers and

attribute for the cairo surface.

Tools:

  • Scripts/run-gtk-tests:

(TestRunner): Unskip test webkit2/WebKitFindController/hide.

11:40 PM Changeset in webkit [149989] by eric.carlson@apple.com
  • 3 edits
    3 adds in trunk

REGRESSION (r149749): Video becomes invisible when it starts playing at newyorkbygehry.com
https://bugs.webkit.org/show_bug.cgi?id=115963

Reviewed by Dean Jackson.

Source/WebCore:

Test: media/video-remove-insert-repaints.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::insertedInto): Set m_inActiveDocument when inserted into a document.
(WebCore::HTMLMediaElement::removedFrom): Fix logging.

LayoutTests:

  • media/video-remove-insert-repaints.html: Added.
  • media/video-remove-insert-repaints-expected.txt: Added.
  • platform/mac/media/video-remove-insert-repaints-expected.png: Added.
11:39 PM Changeset in webkit [149988] by commit-queue@webkit.org
  • 2 edits
    6 adds in trunk/LayoutTests

[EFL] Unreviewed EFL gardening
https://bugs.webkit.org/show_bug.cgi?id=116004

Unreviewed EFL gardening

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-05-12

  • platform/efl-wk2/TestExpectations:
  • platform/efl/fast/block/lineboxcontain/block-with-ideographs-expected.txt: Added.
  • platform/efl/fast/selectors/unqualified-hover-strict-expected.txt: Added.
  • platform/efl/fast/text/text-combine-different-fonts-expected.txt: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
  • platform/efl/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
  • platform/efl/tables/mozilla_expected_failures/bugs/bug45621-expected.txt: Added.
11:25 PM Changeset in webkit [149987] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Move sudden termination symbols to the Mac-only section

  • WebCore.exp.in: Move the sudden termination symbols to the

!PLATFORM(IOS) section for reals this time.

11:24 PM Changeset in webkit [149986] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Fix Mac build.

  • platform/mac/PasteboardMac.mm: Add back include of ClipboardMac.h that was removed by accident a couple of patches back.
10:35 PM Changeset in webkit [149985] by Darin Adler
  • 7 edits in trunk/Source/WebCore

[Mac] Moved files function from ClipboardMac to PasteboardMac
https://bugs.webkit.org/show_bug.cgi?id=116008

Reviewed by Anders Carlsson.

  • dom/Clipboard.cpp:

(WebCore::Clipboard::files): Added. Moved the DOM-depdendent and
platform-independent part of the files function in ClipboardMac here.

  • dom/Clipboard.h: Made files function non-virtual in non-legacy case.
  • platform/Pasteboard.h: Removed static member function

absoluteURLsFromPasteboardFilenames since it can now be private to
PasteboardMac. Added member function readFilenames.

  • platform/mac/ClipboardMac.h: Removed function member files and also

now-unused data member m_clipboardContents.

  • platform/mac/ClipboardMac.mm: Removed files function.

(WebCore::ClipboardMac::ClipboardMac): Removed code to initialize
m_clipboardContents.

  • platform/mac/PasteboardMac.mm:

(WebCore::absoluteURLsFromPasteboardFilenames): Changed from a static
member function to a file-local function.
(WebCore::absoluteURLsFromPasteboard): Changed to call the function
above in its new location.
(WebCore::Pasteboard::readFilenames): Added. Code from ClipboardMac,
minus the DOM-specific parts. Added a FIXME about the peculiar round
trip through NSURL this code takes.

10:32 PM Changeset in webkit [149984] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix WebKit2 build.

  • WebCore.exp.in:

Put WebCore::disableSuddenTermination and WebCore::enableSuddenTermination symbols in the right section.

10:26 PM Changeset in webkit [149983] by Darin Adler
  • 7 edits in trunk/Source/WebCore

[Mac] Move types function from ClipboardMac to PasteboardMac
https://bugs.webkit.org/show_bug.cgi?id=116007

Reviewed by Anders Carlsson.

  • dom/Clipboard.cpp:

(WebCore::Clipboard::types): Added. Calls through to Pasteboard
after doing checks needed at this level.

  • dom/Clipboard.h: Made types function non-virtual in non-legacy case,

and removed non-helpful comment.

  • platform/Pasteboard.h: Updated includes and comments at the top of

the file a bit. Removed static member function addHTMLClipboardTypesForCocoaType,
since it can now be private to PasteboardMac. Added member function types.

  • platform/mac/ClipboardMac.h: Removed types function.
  • platform/mac/ClipboardMac.mm: Ditto.
  • platform/mac/PasteboardMac.mm:

(WebCore::addHTMLClipboardTypesForCocoaType): Made this a file-local
function instead of a static member function.
(WebCore::Pasteboard::types): Added. Moved from ClipboardMac.

10:19 PM Changeset in webkit [149982] by Darin Adler
  • 7 edits in trunk/Source/WebCore

[Mac] Move setData from ClipboardMac to PasteboardMac
https://bugs.webkit.org/show_bug.cgi?id=116006

Reviewed by Anders Carlsson.

  • dom/Clipboard.cpp:

(WebCore::Clipboard::setData): Added. Calls through to Pasteboard
after doing checks needed at this level.

  • dom/Clipboard.h: Made setData non-virtual in non-legacy case.
  • platform/Pasteboard.h: Updated includes and forward declarations.

Removed static member function cocoaTypeFromHTMLClipboardType, since
it can now be private to PasteboardMac. Added static member function
addHTMLClipboardTypesForCocoaType, which is shared between the
ClipboardMac and PasteboardMac files for now. Added writeString.

  • platform/mac/ClipboardMac.h: Removed setData.
  • platform/mac/ClipboardMac.mm: Removed utiTypeFromCocoaType,

addHTMLClipboardTypesForCocoaType, and setData.
(WebCore::ClipboardMac::types): Call addHTMLClipboardTypesForCocoaType
as a Pasteboard static member function, for now.

  • platform/mac/PasteboardMac.mm:

(WebCore::cocoaTypeFromHTMLClipboardType): Added. Moved from ClipboardMac.
(WebCore::Pasteboard::readString): Changed to call
cocoaTypeFromHTMLClipboardType as a file-local function, not a member
function (in fact, we didn't need to repeat the class name before, either,
so this is just removing something we didn't need).
(WebCore::utiTypeFromCocoaType): Added. Moved from ClipboardMac.
(WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType): Ditto.
(WebCore::Pasteboard::writeString): Ditto.

9:44 PM Changeset in webkit [149981] by Darin Adler
  • 7 edits in trunk/Source/WebCore

[Mac] Move getData from ClipboardMac to PasteboardMac
https://bugs.webkit.org/show_bug.cgi?id=116005

Reviewed by Anders Carlsson.

  • dom/Clipboard.cpp:

(WebCore::Clipboard::Clipboard): Added a new boolean argument, forFileDrag,
to the constructor. Maybe we can find a better way to do this once we move
all the platforms over, but this boolean seems a good way to do it for now.
(WebCore::Clipboard::getData): Added. Calls through to Pasteboard after
doing the canReadData check, which is part of DOM rules, not the platform.
Also checks for the file drag case like the old ClipboardMac code did.

  • dom/Clipboard.h: Made getData non-virtual in non-legacy case.
  • platform/Pasteboard.h: Added a static member function named

absoluteURLsFromPasteboardFilenames, temporary so it can be shared between
ClipboardMac and PasteboardMac. Added a readString public function member,
and a m_changeCount data member. The type of m_changeCount is long since
that can always hold an NSInteger but yet is a type we can compile without
including the header file that defines NSInteger.

  • platform/mac/ClipboardMac.h: Removed getData.
  • platform/mac/ClipboardMac.mm: Removed getData.

(WebCore::ClipboardMac::ClipboardMac): Added code to pass in the new
forFileDrag boolean.
(WebCore::ClipboardMac::files): Call absoluteURLsFromPasteboardFilenames
as a static member function in Pasteboard since we moved it there.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::Pasteboard): Initialize the change count, so later
pasteboard operations can check it.
(WebCore::Pasteboard::absoluteURLsFromPasteboardFilenames): Added. Moved
here from ClipboardMac.
(WebCore::absoluteURLsFromPasteboard): Ditto.
(WebCore::Pasteboard::readString): Added. Moved here from ClipboardMac.

9:24 PM Changeset in webkit [149980] by andersca@apple.com
  • 169 edits in trunk/Source

Stop including UnusedParam.h
https://bugs.webkit.org/show_bug.cgi?id=116003

Reviewed by Sam Weinig.

UnusedParam.h is empty now so there's no need to include it anymore.

Source/JavaScriptCore:

  • API/APICast.h:
  • API/tests/JSNode.c:
  • API/tests/JSNodeList.c:
  • API/tests/minidom.c:
  • API/tests/testapi.c:
  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssemblerCodeRef.h:
  • bytecode/CodeBlock.cpp:
  • heap/HandleStack.h:
  • interpreter/JSStackInlines.h:
  • jit/CompactJITCodeMap.h:
  • jit/ExecutableAllocator.h:
  • parser/SourceProvider.h:
  • runtime/DatePrototype.cpp:
  • runtime/JSNotAnObject.cpp:
  • runtime/JSSegmentedVariableObject.h:
  • runtime/JSVariableObject.h:
  • runtime/Options.cpp:
  • runtime/PropertyOffset.h:

Source/WebCore:

  • Modules/encryptedmedia/CDMPrivateAVFoundation.mm:
  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:
  • Modules/indexeddb/IDBObjectStore.cpp:
  • Modules/webdatabase/DatabaseServer.cpp:
  • Modules/webdatabase/DatabaseThread.cpp:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/objc/DOMObject.mm:
  • css/CSSCursorImageValue.cpp:
  • css/DeprecatedStyleBuilder.cpp:
  • dom/EventDispatcher.cpp:
  • dom/Node.cpp:
  • editing/AlternativeTextController.h:
  • editing/Editor.cpp:
  • html/HTMLPlugInElement.cpp:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • html/canvas/OESVertexArrayObject.h:
  • html/parser/HTMLConstructionSite.cpp:
  • html/parser/HTMLTokenizer.cpp:
  • html/track/InbandTextTrack.cpp:
  • inspector/InspectorCanvasInstrumentation.h:
  • inspector/InspectorConsoleInstrumentation.h:
  • inspector/InspectorController.cpp:
  • inspector/InspectorCounters.h:
  • inspector/InspectorDatabaseInstrumentation.h:
  • inspector/InspectorInstrumentation.h:
  • loader/DocumentThreadableLoader.cpp:
  • loader/PingLoader.cpp:
  • loader/appcache/ApplicationCacheGroup.cpp:
  • loader/cache/CachedResourceLoader.cpp:
  • loader/mac/DocumentLoaderMac.cpp:
  • page/ChromeClient.h:
  • page/Console.cpp:
  • page/FrameView.cpp:
  • page/PageConsole.cpp:
  • page/animation/AnimationController.cpp:
  • page/animation/ImplicitAnimation.cpp:
  • page/animation/KeyframeAnimation.cpp:
  • platform/LocalizedStrings.cpp:
  • platform/ScrollAnimator.h:
  • platform/ThreadGlobalData.cpp:
  • platform/blackberry/AsyncFileSystemBlackBerry.cpp:
  • platform/graphics/Font.cpp:
  • platform/graphics/GlyphBuffer.h:
  • platform/graphics/Gradient.cpp:
  • platform/graphics/ShadowBlur.cpp:
  • platform/graphics/SimpleFontData.cpp:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
  • platform/graphics/blackberry/GradientBlackBerry.cpp:
  • platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:
  • platform/graphics/ca/mac/WebTileLayer.mm:
  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/cg/ImageSourceCG.cpp:
  • platform/graphics/clutter/PlatformClutterAnimation.cpp:
  • platform/graphics/filters/ValidatedCustomFilterOperation.cpp:
  • platform/graphics/gstreamer/GStreamerVersioning.cpp:
  • platform/graphics/mac/GraphicsContext3DMac.mm:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  • platform/graphics/mac/SimpleFontDataMac.mm:
  • platform/graphics/mac/WebGLLayer.mm:
  • platform/graphics/mac/WebLayer.mm:
  • platform/graphics/mac/WebTiledLayer.mm:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
  • platform/graphics/qt/GraphicsContext3DQt.cpp:
  • platform/graphics/texmap/TextureMapper.h:
  • platform/graphics/wince/ImageBufferWinCE.cpp:
  • platform/mac/PasteboardMac.mm:
  • platform/mac/ScrollAnimatorMac.mm:
  • platform/mac/ScrollViewMac.mm:
  • platform/mac/ScrollbarThemeMac.mm:
  • platform/mac/SharedTimerMac.mm:
  • platform/mac/WebCoreFullScreenPlaceholderView.mm:
  • platform/mac/WebCoreObjCExtras.mm:
  • platform/mac/WebFontCache.mm:
  • platform/mac/WebVideoFullscreenController.mm:
  • platform/mac/WebVideoFullscreenHUDWindowController.mm:
  • platform/mac/WebWindowAnimation.mm:
  • platform/network/blackberry/CredentialStorageBlackBerry.cpp:
  • platform/network/cf/ResourceErrorCF.cpp:
  • platform/network/mac/CookieStorageMac.mm:
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/network/win/ResourceHandleWin.cpp:
  • platform/text/TextEncodingDetectorICU.cpp:
  • rendering/RenderFlowThread.h:
  • rendering/RenderImage.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderTreeAsText.cpp:
  • rendering/svg/RenderSVGResourceClipper.cpp:
  • rendering/svg/RenderSVGResourceFilter.cpp:
  • rendering/svg/RenderSVGResourceGradient.cpp:
  • rendering/svg/RenderSVGResourceMasker.cpp:
  • rendering/svg/SVGRenderSupport.cpp:
  • rendering/svg/SVGTextLayoutEngineSpacing.cpp:
  • workers/WorkerContext.cpp:
  • workers/WorkerScriptLoader.cpp:
  • xml/XMLHttpRequest.cpp:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • ewk/ewk_js.cpp:
  • ewk/ewk_security_origin.cpp:
  • ewk/ewk_view.cpp:
  • ewk/ewk_web_database.cpp:

Source/WebKit/gtk:

  • webkit/webkitapplicationcache.cpp:

Source/WebKit/mac:

  • Plugins/WebNetscapePluginEventHandlerCocoa.mm:
  • WebView/WebDashboardRegion.mm:
  • WebView/WebFullScreenController.mm:

Source/WebKit/win:

  • WebSecurityOrigin.cpp:

Source/WebKit2:

  • UIProcess/API/C/WKContext.cpp:
  • UIProcess/API/C/WKInspector.cpp:
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/efl/ewk_text_checker.cpp:
  • UIProcess/API/efl/ewk_view.cpp:
  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
  • UIProcess/API/efl/tests/test_ewk2_view.cpp:
  • UIProcess/mac/WKFullScreenWindowController.mm:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
  • WebProcess/ResourceCache/WebResourceCacheManager.cpp:

Source/WTF:

  • wtf/Atomics.h:
  • wtf/BoundsCheckedPointer.h:
  • wtf/DateMath.h:
  • wtf/FastMalloc.cpp:
  • wtf/NumberOfCores.cpp:
  • wtf/OSAllocator.h:
  • wtf/OSAllocatorPosix.cpp:
  • wtf/PageAllocation.h:
  • wtf/RefCounted.h:
  • wtf/TCSystemAlloc.cpp:
  • wtf/ThreadingPthreads.cpp:
  • wtf/Vector.h:
  • wtf/dtoa/cached-powers.cc:
  • wtf/dtoa/fixed-dtoa.cc:
8:51 PM Changeset in webkit [149979] by Darin Adler
  • 5 edits in trunk/Source/WebCore

[Mac] Move clearAllData from ClipboardMac to PasteboardMac
https://bugs.webkit.org/show_bug.cgi?id=116001

Reviewed by Andreas Kling.

  • dom/Clipboard.cpp:

(WebCore::Clipboard::clearAllData): Added. Calls through to Pasteboard after
doing the canWriteData check, which is part of DOM rules, not the platform.

  • dom/Clipboard.h: Made clearAllData non-virtual in non-legacy case.
  • platform/mac/ClipboardMac.h: Removed clearAllData.
  • platform/mac/ClipboardMac.mm: Ditto.
7:56 PM Changeset in webkit [149978] by andersca@apple.com
  • 3 edits in trunk/Source/WTF

Move UNUSED_PARAM and UNUSED_LABEL macros to Compiler.h
https://bugs.webkit.org/show_bug.cgi?id=115997

Reviewed by Benjamin Poulain.

UnusedParam.h predates Compiler.h and the macros defined there should just go into Compiler.h

  • wtf/Compiler.h:

(unusedParam):

  • wtf/UnusedParam.h:
7:41 PM Changeset in webkit [149977] by Darin Adler
  • 7 edits in trunk/Source/WebCore

[Mac] Move clearData from ClipboardMac to PasteboardMac
https://bugs.webkit.org/show_bug.cgi?id=116000

Reviewed by Andreas Kling.

  • dom/Clipboard.cpp:

(WebCore::Clipboard::clearData): Added. Calls through to Pasteboard after
doing the canWriteData check, which is part of DOM rules, not the platform.

  • dom/Clipboard.h: Made clearData non-virtual in non-legacy case.
  • platform/Pasteboard.h: Added an overload of the clear function that takes

a single type and clears only that type. Also temporarily exported the
cocoaTypeFromHTMLClipboardType function as a static member so it can be used
in both ClipboardMac and PasteboardMac during the transition.

  • platform/mac/ClipboardMac.h: Removed clearData.
  • platform/mac/ClipboardMac.mm: Removed clearData.

(WebCore::ClipboardMac::getData): Changed to call cocoaTypeFromHTMLClipboardType
as a Pasteboard class static member function.
(WebCore::ClipboardMac::setData): Ditto.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::cocoaTypeFromHTMLClipboardType): Moved here from
ClipboardMac.
(WebCore::Pasteboard::clear): Added. Moved here from ClipboardMac.

7:28 PM Changeset in webkit [149976] by Darin Adler
  • 7 edits in trunk/Source/WebCore

[Mac] Move hasData from ClipboardMac to PasteboardMac
https://bugs.webkit.org/show_bug.cgi?id=115999

Reviewed by Andreas Kling.

  • dom/Clipboard.cpp:

(WebCore::Clipboard::hasData): Added. Calls through to Pasteboard.

  • dom/Clipboard.h: Added LEGACY_VIRTUAL and LEGACY_PURE macros,

only for within this header file. These help us keep many functions
as pure virtual in the legacy style Clipboard class, but have them
be non-virtual in the normal/future style. Use LEGACY_VIRTUAL and
LEGACY_PURE to make the hasData member non-virtual.

  • platform/Pasteboard.h: Added hasData, and added some blank lines and a FIXME.
  • platform/mac/ClipboardMac.h: Removed hasData override.
  • platform/mac/ClipboardMac.mm: Ditto.
  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::hasData): Added. Moved code here from ClipboardMac.

7:14 PM Changeset in webkit [149975] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX (r149971): sudden termination is a Mac-only concept

  • WebCore.exp.in: Move sudden termination symbols to Mac-only

section.

7:00 PM Changeset in webkit [149974] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Node: Use FINAL instead of the non-virtual shadowing hack.
<http://webkit.org/b/115995>

Reviewed by Anders Carlsson.

Decorate Element/Attr implementations of prefix/localName/namespaceURI getters with FINAL
so that call sites with a more specific pointer type than Node* can avoid the virtual dispatch.

  • dom/Attr.h:
  • dom/Element.h:
  • dom/Node.cpp:
  • dom/Node.h:
6:31 PM Changeset in webkit [149973] by ryuan.choi@samsung.com
  • 3 edits in trunk/LayoutTests

REGRESSION (r149668): 4 reftest failures under fast/regions on GTK
https://bugs.webkit.org/show_bug.cgi?id=115783

Unreviewed rebaseline. They were fixed after r149802.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
6:25 PM Changeset in webkit [149972] by Darin Adler
  • 6 edits in trunk/Source/WebCore

[Mac] Give every Clipboard an underlying Pasteboard
https://bugs.webkit.org/show_bug.cgi?id=115979

Reviewed by Andreas Kling.

This is the first step in Clipboard and Pasteboard refactoring
to fix the overlap and many layering violations.

  • dom/Clipboard.cpp:

(WebCore::Clipboard::Clipboard): Add an m_pasteboard data member,
Mac-only for now, but eventually for all platforms.
(WebCore::Clipboard::~Clipboard): No longer inline the destructor.

  • dom/Clipboard.h: Add WTF_USE_LEGACY_STYLE_ABSTRACT_CLIPBOARD_CLASS

flag, currently true for all non-Mac platforms. Make the constructor
no longer inline. Added a PassOwnPtr<Pasteboard> argument to the
constructor and an OwnPtr<Pasteboard> data member.

  • platform/Pasteboard.h: Added a create function to make it easy

to create a pasteboard given a pasteboard name.

  • platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::ClipboardMac): Create a pasteboard and pass
it to the Clipboard constructor.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::create): Added.

4:16 PM Changeset in webkit [149971] by akling@apple.com
  • 17 edits in trunk/Source

Unload event listeners should prevent Safari from insta-killing the web process on last tab close.
<http://webkit.org/b/115988>
<rdar://problem/13870943>

Reviewed by Anders Carlsson.

Source/WebCore:

Add two methods to Chrome (and ChromeClient):

  • enableSuddenTermination()
  • disableSuddenTermination()

..and call these from DOMWindow instead of the free global functions.

For WebKit1, it just calls the NSProcessInfo methods to keep behavior the same.
For WebKit2, the new methods plumb through the information to the UI process.

Also updated the DOMWindow logic to think in terms of per-DOMWindow sudden termination counters
instead of a process-global one, since that gets confusing in a WK2 world.
When a DOMWindow transitions between having/not having unload/beforeunload event listeners,
we send a notification to the Chrome.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Chrome.h:

(WebCore::Chrome::enableSuddenTermination):
(WebCore::Chrome::disableSuddenTermination):

  • page/ChromeClient.h:

(WebCore::ChromeClient::enableSuddenTermination):
(WebCore::ChromeClient::disableSuddenTermination):

  • page/DOMWindow.cpp:

(WebCore::addUnloadEventListener):
(WebCore::removeUnloadEventListener):
(WebCore::removeAllUnloadEventListeners):
(WebCore::addBeforeUnloadEventListener):
(WebCore::removeBeforeUnloadEventListener):
(WebCore::removeAllBeforeUnloadEventListeners):
(WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents):
(WebCore::DOMWindow::dispatchAllPendingUnloadEvents):
(WebCore::DOMWindow::enableSuddenTermination):
(WebCore::DOMWindow::disableSuddenTermination):

  • page/DOMWindow.h:

(DOMWindow):

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::enableSuddenTermination):
(WebChromeClient::disableSuddenTermination):

Source/WebKit2:

Let WebCore control the UI process's suppression of the sudden termination mechanism.
This is implemented by having WebChromeClient push Enable/DisableSuddenTermination messages
over to the UI process where the appropriate NSProcessInfo calls are made.

We also use this information when deciding whether to insta-kill a web process when its last
page is closed. This mechanism is re-usable in WebCore to protect against sudden termination
by the UI process.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::removeWebPage):
(WebKit::WebProcessProxy::enableSuddenTermination):
(WebKit::WebProcessProxy::disableSuddenTermination):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

  • UIProcess/WebProcessProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::enableSuddenTermination):
(WebKit::WebChromeClient::disableSuddenTermination):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

2:27 PM Changeset in webkit [149970] by andersca@apple.com
  • 12 edits
    1 delete in trunk/Source

Remove Complex.h from WTF
https://bugs.webkit.org/show_bug.cgi?id=115989

Reviewed by Beth Dakin.

Source/WebCore:

Replace Complex declarations with std::complex<double>. Pass by value since the struct
is small enough to go into two registers on X86-64.

  • Modules/webaudio/RealtimeAnalyser.cpp:

(WebCore::RealtimeAnalyser::doFFTAnalysis):
(WebCore::RealtimeAnalyser::getFloatFrequencyData):
(WebCore::RealtimeAnalyser::getByteFrequencyData):
(WebCore::RealtimeAnalyser::getByteTimeDomainData):

  • platform/audio/Biquad.cpp:

(WebCore::Biquad::setZeroPolePairs):
(WebCore::Biquad::setAllpassPole):
(WebCore::Biquad::getFrequencyResponse):

  • platform/audio/Biquad.h:
  • platform/audio/FFTFrame.cpp:

(WebCore::FFTFrame::interpolateFrequencyComponents):
(WebCore::FFTFrame::extractAverageGroupDelay):
(WebCore::FFTFrame::addConstantGroupDelay):

Source/WTF:

Complex.h contains a typedef and a single function (that already has an equivalent in the STL).
The header is used by three files in WebCore, so just use std::complex<double> and std::polar directly.

  • GNUmakefile.list.am:
  • WTF.vcproj/WTF.vcproj:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/Complex.h: Removed.
11:46 AM Changeset in webkit [149969] by Simon Fraser
  • 5 edits
    2 adds in trunk

Dropdowns on http://www.exploratorium.edu don't show anything
https://bugs.webkit.org/show_bug.cgi?id=115991

Source/WebCore:

Reviewed by Dan Bernstein.

We can't optimize away the backing store of a layer by saying that
it paints into a composited ancestor if its composited bounds are not contained
by that ancestor.

Test: compositing/backing/no-backing-for-clip-overhang.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Pass in our
previously computed composited bounds relative to our composited ancestor,
and its composited bounds.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresOwnBackingStore): If the ancestor's
composited bounds don't contain the layer's composited bounds, the layer
needs its own backing store.

  • rendering/RenderLayerCompositor.h:

LayoutTests:

Reviewed by Dan Bernstein.

Layer tree dump test with an overflow:hidden that projects outside its
ancestor, and is forced to composite by a composited child.

  • compositing/backing/no-backing-for-clip-overhang-expected.txt: Added.
  • compositing/backing/no-backing-for-clip-overhang.html: Added.
11:22 AM Changeset in webkit [149968] by Martin Robinson
  • 7 edits
    8 adds in trunk

[GTK] Add a basic cmake build for WTF and JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=115967

Reviewed by Laszlo Gombos.

.:

  • CMakeLists.txt: Add GTK+ to the list of ports.
  • Source/CMakeLists.txt: We do not try to build WebCoreTestSupport when WebCore is disabled.
  • Source/cmake/FindGAIL3.cmake: Added.
  • Source/cmake/FindGDK3.cmake: Added.
  • Source/cmake/FindGStreamer.cmake: Use the passed in minimum version.
  • Source/cmake/FindGTK3.cmake: Added.
  • Source/cmake/FindXt.cmake: Added.
  • Source/cmake/OptionsEfl.cmake: Pass in the minimum version.
  • Source/cmake/OptionsGTK.cmake: Added.

Source/JavaScriptCore:

  • PlatformGTK.cmake: Added.
  • shell/PlatformGTK.cmake: Added.

Source/WTF:

  • wtf/PlatformGTK.cmake: Added.
11:12 AM Changeset in webkit [149967] by commit-queue@webkit.org
  • 103 edits in trunk

Unreviewed, rolling out r149955.
http://trac.webkit.org/changeset/149955
https://bugs.webkit.org/show_bug.cgi?id=115990

Broke lots of tests (Requested by smfr on #webkit).

Source/WebCore:

  • WebCore.exp.in:
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.h:

(InlineTextBox):

  • rendering/RenderApplet.h:
  • rendering/RenderBR.h:
  • rendering/RenderBlock.h:

(RenderBlock):
(WebCore::RenderBlock::virtualContinuation):
(WebCore::RenderBlock::virtualChildren):
(WebCore::RenderBlock::isRenderBlock):
(WebCore::RenderBlock::isBlockFlow):
(WebCore::RenderBlock::isInlineBlockOrInlineTable):
(WebCore::RenderBlock::dirtyLinesFromChangedChild):
(WebCore::RenderBlock::collapsedMarginBefore):
(WebCore::RenderBlock::collapsedMarginAfter):

  • rendering/RenderBox.h:

(WebCore::RenderBox::borderBoundingBox):
(RenderBox):
(WebCore::RenderBox::marginLogicalLeft):
(WebCore::RenderBox::marginLogicalRight):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::isBoxModelObject):

  • rendering/RenderButton.h:
  • rendering/RenderCombineText.h:
  • rendering/RenderCounter.h:
  • rendering/RenderDeprecatedFlexibleBox.h:
  • rendering/RenderDetailsMarker.h:
  • rendering/RenderEmbeddedObject.h:

(RenderEmbeddedObject):
(WebCore::RenderEmbeddedObject::isEmbeddedObject):
(WebCore::RenderEmbeddedObject::virtualChildren):

  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFlowThread.h:
  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.h:
  • rendering/RenderFullScreen.cpp:
  • rendering/RenderFullScreen.h:
  • rendering/RenderGrid.h:
  • rendering/RenderHTMLCanvas.h:
  • rendering/RenderIFrame.h:
  • rendering/RenderImage.h:

(RenderImage):
(WebCore::RenderImage::isRenderImage):

  • rendering/RenderInline.h:

(RenderInline):
(WebCore::RenderInline::virtualContinuation):
(WebCore::RenderInline::virtualChildren):
(WebCore::RenderInline::isRenderInline):
(WebCore::RenderInline::layout):
(WebCore::RenderInline::requiresLayer):
(WebCore::RenderInline::offsetWidth):
(WebCore::RenderInline::offsetHeight):
(WebCore::RenderInline::borderBoundingBox):
(WebCore::RenderInline::dirtyLinesFromChangedChild):

  • rendering/RenderLayerModelObject.h:
  • rendering/RenderListBox.h:
  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.h:
  • rendering/RenderMedia.h:

(WebCore::RenderMedia::virtualChildren):
(WebCore::RenderMedia::canHaveChildren):
(WebCore::RenderMedia::isMedia):
(WebCore::RenderMedia::isImage):
(WebCore::RenderMedia::requiresForcedStyleRecalcPropagation):

  • rendering/RenderMediaControlElements.h:
  • rendering/RenderMenuList.h:
  • rendering/RenderMeter.h:
  • rendering/RenderMultiColumnBlock.h:
  • rendering/RenderMultiColumnFlowThread.h:
  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderNamedFlowThread.h:
  • rendering/RenderPart.h:

(RenderPart):
(WebCore::RenderPart::isRenderPart):
(WebCore::RenderPart::renderName):

  • rendering/RenderProgress.h:
  • rendering/RenderRegion.h:

(WebCore::RenderRegion::isRenderRegion):

  • rendering/RenderRegionSet.h:
  • rendering/RenderReplaced.h:

(RenderReplaced):
(WebCore::RenderReplaced::renderName):

  • rendering/RenderReplica.h:
  • rendering/RenderRuby.h:
  • rendering/RenderRubyBase.h:
  • rendering/RenderRubyRun.h:
  • rendering/RenderRubyText.h:
  • rendering/RenderScrollbarPart.h:
  • rendering/RenderSearchField.h:
  • rendering/RenderSlider.h:
  • rendering/RenderSnapshottedPlugIn.h:

(RenderSnapshottedPlugIn):

  • rendering/RenderTable.h:

(RenderTable):
(WebCore::RenderTable::renderName):
(WebCore::RenderTable::isTable):
(WebCore::RenderTable::avoidsFloats):

  • rendering/RenderTableCaption.h:
  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.h:
  • rendering/RenderText.h:

(RenderText):
(WebCore::RenderText::marginLeft):
(WebCore::RenderText::marginRight):
(WebCore::RenderText::styleWillChange):
(WebCore::RenderText::length):
(WebCore::RenderText::paint):
(WebCore::RenderText::layout):

  • rendering/RenderTextControl.h:

(RenderTextControl):
(WebCore::RenderTextControl::renderName):
(WebCore::RenderTextControl::isTextControl):
(WebCore::RenderTextControl::avoidsFloats):

  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.h:

(RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::isTextField):

  • rendering/RenderTextFragment.h:
  • rendering/RenderTextTrackCue.h:
  • rendering/RenderVideo.h:
  • rendering/RenderView.h:
  • rendering/RenderWidget.h:

(RenderWidget):
(WebCore::RenderWidget::isWidget):

  • rendering/RenderWordBreak.h:
  • rendering/RootInlineBox.h:

(RootInlineBox):

  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/svg/RenderSVGBlock.h:

(RenderSVGBlock):

  • rendering/svg/RenderSVGContainer.h:

(WebCore::RenderSVGContainer::setNeedsBoundariesUpdate):
(WebCore::RenderSVGContainer::virtualChildren):
(WebCore::RenderSVGContainer::isSVGContainer):
(WebCore::RenderSVGContainer::renderName):
(RenderSVGContainer):
(WebCore::RenderSVGContainer::objectBoundingBox):
(WebCore::RenderSVGContainer::strokeBoundingBox):
(WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):

  • rendering/svg/RenderSVGEllipse.h:
  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGGradientStop.h:
  • rendering/svg/RenderSVGHiddenContainer.h:

(WebCore::RenderSVGHiddenContainer::renderName):
(RenderSVGHiddenContainer):
(WebCore::RenderSVGHiddenContainer::isSVGHiddenContainer):

  • rendering/svg/RenderSVGImage.h:
  • rendering/svg/RenderSVGInline.h:

(WebCore::RenderSVGInline::renderName):
(WebCore::RenderSVGInline::requiresLayer):
(WebCore::RenderSVGInline::isSVGInline):
(RenderSVGInline):

  • rendering/svg/RenderSVGInlineText.h:
  • rendering/svg/RenderSVGModelObject.h:

(WebCore::RenderSVGModelObject::requiresLayer):
(RenderSVGModelObject):

  • rendering/svg/RenderSVGPath.h:
  • rendering/svg/RenderSVGRect.h:
  • rendering/svg/RenderSVGResourceClipper.h:
  • rendering/svg/RenderSVGResourceContainer.h:

(RenderSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::isSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::toRenderSVGResourceContainer):

  • rendering/svg/RenderSVGResourceFilter.h:
  • rendering/svg/RenderSVGResourceFilterPrimitive.h:
  • rendering/svg/RenderSVGResourceGradient.h:

(RenderSVGResourceGradient):
(WebCore::RenderSVGResourceGradient::resourceBoundingBox):

  • rendering/svg/RenderSVGResourceLinearGradient.h:
  • rendering/svg/RenderSVGResourceMarker.h:
  • rendering/svg/RenderSVGResourceMasker.h:
  • rendering/svg/RenderSVGResourcePattern.h:
  • rendering/svg/RenderSVGResourceRadialGradient.h:
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGShape.h:

(WebCore::RenderSVGShape::setNeedsBoundariesUpdate):
(WebCore::RenderSVGShape::setNeedsTransformUpdate):
(WebCore::RenderSVGShape::repaintRectInLocalCoordinates):
(WebCore::RenderSVGShape::localToParentTransform):
(WebCore::RenderSVGShape::localTransform):
(WebCore::RenderSVGShape::isSVGShape):
(RenderSVGShape):
(WebCore::RenderSVGShape::objectBoundingBox):
(WebCore::RenderSVGShape::strokeBoundingBox):

  • rendering/svg/RenderSVGTSpan.h:
  • rendering/svg/RenderSVGText.h:
  • rendering/svg/RenderSVGTextPath.h:
  • rendering/svg/RenderSVGTransformableContainer.h:
  • rendering/svg/RenderSVGViewportContainer.h:

Tools:

  • Scripts/webkitpy/port/mac.py:
10:58 AM Changeset in webkit [149966] by Martin Robinson
  • 4 edits in trunk

Move defines to platform

[GTK] Move defines that will never be configured to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=115965

Reviewed by Andreas Kling.

.:

  • Source/autotools/SetupAutoconfHeader.m4: Move some unchanging defines to Platform.h.

Source/WTF:

  • wtf/Platform.h: Add new defines that were previously in the autoconf header.
10:50 AM Changeset in webkit [149965] by andersca@apple.com
  • 7 edits in trunk/Source

Simplify AutodrainedPool
https://bugs.webkit.org/show_bug.cgi?id=115986

Reviewed by Andreas Kling.

Source/WebCore:

Remove calls to AutodrainedPool::cycle as well as the iteration counter passed to the constructor.
Instead, just declare RAII pools where it seems necessary.

  • Modules/webdatabase/DatabaseThread.cpp:

(WebCore::DatabaseThread::databaseThread):

  • fileapi/FileThread.cpp:

(WebCore::FileThread::runLoop):

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::performURLImport):
(WebCore::IconDatabase::readFromDatabase):

Source/WTF:

Remove the ability to cycle an AutodrainedPool, as well as the iteration count.
Creating and draining pools is fast enough now that we don't need to try to be clever about it.

  • wtf/AutodrainedPool.h:

(AutodrainedPool):
(WTF::AutodrainedPool::AutodrainedPool):

  • wtf/AutodrainedPoolMac.mm:

(WTF::AutodrainedPool::AutodrainedPool):

10:47 AM Changeset in webkit [149964] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/13402976> Sandbox violations in com.nvidia.OpenGL on Lion.

Reviewed by Dan Bernstein.

  • WebProcess/com.apple.WebProcess.sb.in: Silence the violations (on Lion only).
9:45 AM Changeset in webkit [149963] by andersca@apple.com
  • 9 edits
    1 delete in trunk/Source/WTF

Move RemoteMemoryReader into FastMalloc.cpp
https://bugs.webkit.org/show_bug.cgi?id=115985

Reviewed by Andreas Kling.

RemoteMemoryReader is only used in FastMalloc.cpp, and even had one of its member functions
implemented there, so move the entire class template there and remove MallocZoneSupport.h.

  • GNUmakefile.list.am:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/FastMalloc.cpp:

(WTF):
(PageHeapAllocator):
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

  • wtf/MallocZoneSupport.h: Removed.
9:37 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
9:33 AM Changeset in webkit [149962] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.0/Source

Merge r147640 - Fix the build with GCC 4.8
https://bugs.webkit.org/show_bug.cgi?id=113147

Reviewed by Allan Sandfeld Jensen.

Source/JavaScriptCore:

Initialize JSObject* exception to suppress warnings that make
the build fail because of -Werror=maybe-uninitialized.

  • runtime/Executable.cpp:

(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

Source/WTF:

Disable diagnostic warning -Wunused-local-typedefs for GCC 4.8
since dummy typedefs are commonly used in the codebase.

  • wtf/Compiler.h:
8:26 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
8:22 AM Changeset in webkit [149961] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.0/Source/WTF

Merge r146993 - Support C++11 static_assert
https://bugs.webkit.org/show_bug.cgi?id=113308

Reviewed by Alexey Proskuryakov.

Use the C++11 static_assert for COMPILE_ASSERT when it is available. Note that
even when compiling with C++11 support, static_assert will not always be available
since Assertions.h may also be used outside of C++.

C11 _Static_assert is enabled for GCC when it has C11 support (gcc>=4.7 -std=c11).

  • wtf/Assertions.h:
  • wtf/Compiler.h:
8:12 AM Changeset in webkit [149960] by akling@apple.com
  • 184 edits in trunk/Source/WebCore

Apply FINAL to the Node hierarchy.
<http://webkit.org/b/115984>

Mostly from Blink r149454 by <cevans@chromium.org>
<http://src.chromium.org/viewvc/blink?view=revision&revision=149454>

A couple of the stable DOM/ microbenchmarks are perf positive on Linux clang:

  • CloneNodes time reduced from 162.4 to 156.5 ms.
  • CreateNodes time reduced from 113.9 to 104.9 ms.
  • dom/: Beat things with the FINAL stick.
  • html/: Ditto.
  • svg/: Ditto.
7:23 AM Changeset in webkit [149959] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Devirtualize some things on Document.

From Blink r149967 by <esprehn@chromium.org>
<http://src.chromium.org/viewvc/blink?view=revision&revision=149967>

Several methods on Document are virtual but don't override a super class method
and don't need to be virtual. This patch devirtualizes:

  • createElementNS()
  • finishedParsing()
  • suspendScriptedAnimationControllerCallbacks()
  • resumeScriptedAnimationControllerCallbacks()

It also removes the suspend and resume callbacks from ScriptExecutionContext
since they didn't need to be there.

  • dom/Document.h:
  • dom/ScriptExecutionContext.h:
7:11 AM Changeset in webkit [149958] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WTF

Merge r145701 - Support C++11 features in GCC <4.6
https://bugs.webkit.org/show_bug.cgi?id=111553

Reviewed by Simon Hausmann.

Enable support for rvalue references from gcc 4.3, deleted functions
from gcc 4.4, explicit conversion from gcc 4.5, and strongly typed
enums from gcc 4.6.

  • wtf/Compiler.h:
7:05 AM Changeset in webkit [149957] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Remove redundant call to removeAllEventListeners() in Document::open().

From Blink r150175 by <dcheng@chromium.org>
<http://src.chromium.org/viewvc/blink?view=revision&revision=150175>

Document::open() already calls Document::removeAllEventListeners(), which
removes the event listeners from the DOMWindow it's attached to, so
there's no need to do it manually here as well.

  • dom/Document.cpp:

(WebCore::Document::open):

6:57 AM Changeset in webkit [149956] by akling@apple.com
  • 2 edits in trunk/LayoutTests

Rebaseline fast/js/global-constructors-attributes.html for mac-lion after r149920.

  • platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
6:38 AM Changeset in webkit [149955] by akling@apple.com
  • 102 edits in trunk

Apply FINAL to the RenderObject hierarchy.
<http://webkit.org/b/115977>

Mostly from Blink r148795 by <cevans@chromium.org>
<http://src.chromium.org/viewvc/blink?view=revision&revision=148795>

  • rendering/: Beat things with the FINAL stick.
  • WebCore.exp.in: Export a now-needed symbol.
4:23 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
4:19 AM Changeset in webkit [149954] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Tools

Merge r145881 - Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
https://bugs.webkit.org/show_bug.cgi?id=112394

Patch by Tobias Mueller <tobiasmue@gnome.org> on 2013-03-15
Reviewed by Philippe Normand.

  • GtkLauncher/main.c:

(main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER

4:19 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
4:15 AM Changeset in webkit [149953] by Carlos Garcia Campos
  • 10 edits in releases/WebKitGTK/webkit-2.0

Merge r148860 - [WebKit2] Plugins without a MIME Type fail to load
https://bugs.webkit.org/show_bug.cgi?id=112834

Reviewed by Benjamin Poulain.

Source/WebKit2:

The problem is that when the plugin is created and the MIME Type
is empty, since the MIME Type guessed in the UI process using the
plugin extension is not passed to the WebProcess, when the plugin
is instantiated, the value of NPMIMEType parameter passed to
NPP_New is NULL, and NPERR_INVALID_INSTANCE_ERROR is returned.
GetPluginPath message has been renamed to FindPlugin, since it
doesn't only return the path but also the new MIME Type and load
policy.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findPlugin): Receive an output newMIMEType
parameter that is passed to PluginModuleInfo::findPlugin() so that
in case of guessing the MIME Type, the new one is passed back to
the WebProcess.

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin): Pass the MIME Type
from the parameters to WebPage::createPlugin.
(WebKit::WebFrameLoaderClient::recreatePlugin): Pass a newMIMEType
parameter to WebPage::createPlugin.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin): Add newMIMEType out parameter and
pass it to the FindPlugin message.
(WebKit::WebPage::canPluginHandleResponse): Pass newMIMEType to
FindPlugin message.

  • WebProcess/WebPage/WebPage.h:

(WebPage):

LayoutTests:

  • platform/wk2/TestExpectations: Unskip

plugins/no-mime-with-valid-extension.html.

2:25 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
Only bug fixes in the stable branch (diff)
2:05 AM Changeset in webkit [149952] by Carlos Garcia Campos
  • 44 edits in trunk

[GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=115914

Reviewed by Martin Robinson.

Source/WebCore:

  • platform/graphics/gtk/FullscreenVideoControllerGtk.cpp:

(WebCore::FullscreenVideoControllerGtk::hideHud):
(WebCore::FullscreenVideoControllerGtk::initializeWindow):

  • platform/gtk/GtkVersioning.c:
  • platform/gtk/GtkVersioning.h:
  • platform/gtk/WidgetRenderingContext.cpp:

(WebCore::WidgetRenderingContext::WidgetRenderingContext):

  • plugins/gtk/gtk2xtbin.c:

(gtk_xtbin_realize):

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::contentsSizeChanged):

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::transitionToCommittedForNewPage):

  • tests/testapplicationcache.c:
  • tests/testatk.c:
  • tests/testatkroles.c:

(main):

  • tests/testcontextmenu.c:
  • tests/testcopyandpaste.c:

(main):

  • tests/testdomdocument.c:
  • tests/testdomdomwindow.c:
  • tests/testdomnode.c:
  • tests/testdownload.c:

(main):

  • tests/testfavicondatabase.c:

(main):

  • tests/testglobals.c:
  • tests/testhittestresult.c:
  • tests/testhttpbackend.c:

(main):

  • tests/testkeyevents.c:

(main):

  • tests/testloading.c:
  • tests/testmimehandling.c:

(main):

  • tests/testnetworkrequest.c:

(main):

  • tests/testnetworkresponse.c:

(main):

  • tests/testwebbackforwardlist.c:

(main):

  • tests/testwebdatasource.c:

(main):

  • tests/testwebframe.c:

(main):

  • tests/testwebhistoryitem.c:

(main):

  • tests/testwebinspector.c:

(main):

  • tests/testwebplugindatabase.c:

(main):

  • tests/testwebresource.c:

(main):

  • tests/testwebsettings.c:

(main):

  • tests/testwebview.c:
  • tests/testwindow.c:

(main):

  • webkit/webkitwebview.cpp:

(webkit_web_view_realize):
(webkit_web_view_show_help):
(webkit_web_view_class_init):
(webkit_web_view_set_tooltip_text):

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseRealize):

Tools:

  • GtkLauncher/main.c:

(createToolbar):

  • MiniBrowser/gtk/BrowserWindow.c:

(_BrowserWindow):
(browserWindowSetStatusText):
(fullScreenMessageTimeoutCallback):
(webViewEnterFullScreen):
(webViewLeaveFullScreen):
(browserWindowFinalize):
(browserWindowConstructed):

  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::continuousMouseScrollBy):

May 11, 2013:

11:15 PM Changeset in webkit [149951] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Unreviewed build fix after r149932

Patch by Brent Fulgham <Brent Fulgham> on 2013-05-11

  • make-export-file-generator: Don't attempt to import

(or use) non-existent cxxabi functions on Windows.

10:39 PM Changeset in webkit [149950] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Add more info to compositing log channel output
https://bugs.webkit.org/show_bug.cgi?id=115978

Reviewed by Dean Jackson.

Add to compositing log channel output whether a layer paints
into its compositing ancestor.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::logLayerInfo):

9:54 PM Changeset in webkit [149949] by Simon Fraser
  • 4 edits
    4 adds in trunk

REGRESSION: Fixed background on ColterReed.com scrolls
https://bugs.webkit.org/show_bug.cgi?id=115951

Source/WebCore:

Reviewed by Beth Dakin.

The logic for painting the fixed root background into its own layer was
broken when the document element's layer was composited. This could be caused
by a negative z-index child of the body, or by an explicit compositing-causing
style on the <html>.

There were two issues. First, when painting the layer for the fixed root
background, we would simply short-circuit the fixed background paint in
RenderLayer::paintLayer(), when checking for a composited layer. We have
to continue to paint through the composited <html> layer to get the root
background in this case.

Secondly, RenderLayerBacking::paintIntoLayer() would only set the PaintLayerPaintingSkipRootBackground
flag if this RenderLayerBacking had a m_backgroundLayer. However, when the <html> is
composited, we need to skip painting the root layer for both the RenderView's backing,
and for the <html>'s backing. Checking whether there is *any* layer that paints
the fixed root background (i.e. checking compositor()->fixedRootBackgroundLayer())
is a simple way to fix this test.

Tests: platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-composited-html.html

platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-negative-z-index-fixed.html

  • rendering/RenderLayer.cpp:

(WebCore::paintForFixedRootBackground):
(WebCore::RenderLayer::paintLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintIntoLayer):

LayoutTests:

Reviewed by Beth Dakin.

Tests with a fixed background and two different ways of making the <html> composited.

  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-composited-html-expected.html: Added.
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-composited-html.html: Added.
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-negative-z-index-fixed-expected.html: Added.
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-negative-z-index-fixed.html: Added.
9:28 PM Changeset in webkit [149948] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Possible crash when going Back while loading PDF
https://bugs.webkit.org/show_bug.cgi?id=115972

Reviewed by Dan Bernstein.

It's possible for m_frame to be null when Document::findUnsafeParentScrollPropagationBoundary()
is called, so null-check currentFrame.

  • dom/Document.cpp:

(WebCore::Document::findUnsafeParentScrollPropagationBoundary):

5:53 PM Changeset in webkit [149947] by ap@apple.com
  • 3 edits in trunk/Source/WebCore

<rdar://problem/13823864> TextCodecICU complains about ambiguous codec names with current ICU release
https://bugs.webkit.org/show_bug.cgi?id=115953

Reviewed by Darin Adler.

Store and use canonical converter name to create converters.

As a side effect, we now actually reuse cached converters - previously we would compare
a standard encoding name to internal canonical one, which rarely match.

  • platform/text/TextCodecICU.h:
  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::create): Pass canonical ICU converter name to constructor. (WebCore::TextCodecICU::registerEncodingNames):
    • Updated terminology.
    • Added a comment that special cases should be kept in sync between registerEncodingNames and registerCodecs.
    • Moved maccyrillic alias to a correct section. It's not present in ICU even today.
    • Changed a few aliases to actually map to standard name, not to an overridden one (this doesn't change behavior since addToTextEncodingNameMap looks up canonical name, but is clearer).

(WebCore::TextCodecICU::registerCodecs): Store a converter name to use with each
canonical encoding name.
(WebCore::TextCodecICU::TextCodecICU): Ditto.
(WebCore::TextCodecICU::releaseICUConverter): Reset the converter to remove any
leftover data.
(WebCore::TextCodecICU::createICUConverter):

  • Compare converter name to converter name, not to another alias name.
  • Use proper string comparison instead of pointer comparison.
  • When creating a converter, assert that the name is not ambigous - canonical converter names should never be, otherwise there would be no way to create the converter without ambiguity.
5:26 PM Changeset in webkit [149946] by mhahnenberg@apple.com
  • 6 edits
    2 adds
    2 deletes in branches/dfgFourthTier/Source/JavaScriptCore

Rename StructureCheckHoistingPhase to TypeCheckHoistingPhase
https://bugs.webkit.org/show_bug.cgi?id=115938

We're going to add some more types of check hoisting soon, so let's have
the right name here.

Rubber stamped by Filip Pizlo.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGStructureCheckHoistingPhase.cpp: Removed.
  • dfg/DFGStructureCheckHoistingPhase.h: Removed.
  • dfg/DFGTypeCheckHoistingPhase.cpp: Added.

(DFG):
(TypeCheckHoistingPhase):
(JSC::DFG::TypeCheckHoistingPhase::TypeCheckHoistingPhase):
(JSC::DFG::TypeCheckHoistingPhase::run):
(JSC::DFG::TypeCheckHoistingPhase::shouldConsiderForHoisting):
(JSC::DFG::TypeCheckHoistingPhase::noticeStructureCheck):
(CheckData):
(JSC::DFG::TypeCheckHoistingPhase::CheckData::CheckData):
(JSC::DFG::performTypeCheckHoisting):

  • dfg/DFGTypeCheckHoistingPhase.h: Added.
4:42 PM Changeset in webkit [149945] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r149944.

  • Platform/CoreIPC/ArgumentEncoder.cpp: Include <sys/mman.h> for mmap(2).
4:28 PM Changeset in webkit [149944] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Don't pass malloced pointers as out-of-line data when sending Mach messages
https://bugs.webkit.org/show_bug.cgi?id=115970
<rdar://problem/13144680>

Reviewed by Sam Weinig.

Give ArgumentEncoder an inline buffer of 512 bytes. If we need more than that, use mmap to allocate data
since that gives us fresh zero-filled memory that we can safely share.

  • Platform/CoreIPC/ArgumentEncoder.cpp:

(CoreIPC::ArgumentEncoder::ArgumentEncoder):
Set up the buffer pointers to point to the inline buffer.

(CoreIPC::ArgumentEncoder::~ArgumentEncoder):
Unmap the buffer if necessary.

(CoreIPC::ArgumentEncoder::grow):
Grow the allocation exponentially, rounded up to the nearest page. This is a simplification from the
current strategy, but most messages are either tiny in which case they will fit inside the inline buffer,
or big in which case we'll end up doing less allocations + memory copying.

  • Platform/CoreIPC/ArgumentEncoder.h:

(ArgumentEncoder):

4:26 PM Changeset in webkit [149943] by mhahnenberg@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

SpeculativeJIT::checkArray should use the correct ExitKind
https://bugs.webkit.org/show_bug.cgi?id=115943

Currently it uses Uncountable, which gives us no information if we end up exiting due to a
mismatched ClassInfo pointer. It should instead use BadType and should pass the correct
JSValueSource and Node instead of passing empty values.

Reviewed by Filip Pizlo.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArray):

2:42 PM Changeset in webkit [149942] by Antoine Quint
  • 3 edits in trunk/Source/WebCore

[Mac] The captions menu should not use a canned max-width and max-height
https://bugs.webkit.org/show_bug.cgi?id=115968

Reviewed by Eric Carlson.

Use more real estate to display the captions menu should the caption names
be long.

  • css/mediaControlsQuickTime.css:

(video::-webkit-media-controls-closed-captions-container):
(video::-webkit-media-controls-closed-captions-track-list):
Make the captions menu scale to a max-width and max-height to allow 4px
above and below the menu, except on the right where it always aligns with
the captions icon in the media controller.

  • html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsApple::createControls):
Move the captions menu element to be a child of the controls instead of
the panel such that it may scale relative to the controls when using %
CSS values.

2:07 PM Changeset in webkit [149941] by fpizlo@apple.com
  • 5 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support Jump and ForceOSRExit
https://bugs.webkit.org/show_bug.cgi?id=115942

Reviewed by Oliver Hunt.

Added two obvious nodes: Jump and ForceOSRExit. We already had everything we needed
to support them.

Adding these increases our coverage a fair bit, and revealed a bug: LLVM's full
instruction selector currently appears to mishandle doubles in constant pools (or
just constant pools in general) with the small code model in the MCJIT. But switching
to FastISel "fixes" it. That's what this patch does, for now. This will probably
actually be permanent; the FastISel does pretty much everything we would ever want,
at least in the foreseeable future.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):
(FTL):

  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileJSConstant):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileJump):
(JSC::FTL::LowerDFGToLLVM::compileReturn):
(JSC::FTL::LowerDFGToLLVM::compileForceOSRExit):

  • runtime/Options.h:

(JSC):

1:57 PM Changeset in webkit [149940] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r149904.

  • GNUmakefile.list.am: Adding missing build targets.
1:08 PM Changeset in webkit [149939] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Bogus -webkit-columns value in fast/text/international/spaces-combined-in-vertical-text.html
https://bugs.webkit.org/show_bug.cgi?id=115164

Patch by Xan Lopez <xlopez@igalia.com> on 2013-05-11
Reviewed by Rob Buis.

Remove bogus -webkit-columns property.

  • fast/text/international/spaces-combined-in-vertical-text.html:
1:07 PM Changeset in webkit [149938] by Christophe Dumez
  • 2 edits in trunk/Source/WebKit2

Unreviewed, Fix WK2 EFL build after r149904.

Add new PluginInformation.cpp file to CMake.

  • CMakeLists.txt:
12:47 PM Changeset in webkit [149937] by Christophe Dumez
  • 2 edits in trunk/Source/WebKit2

Unreviewed, fix WK2 EFL build after r149904.

Add new WKPluginInformation.cpp file to CMake.

  • CMakeLists.txt:
12:09 PM Changeset in webkit [149936] by jochen@chromium.org
  • 5 edits
    2 adds in trunk

Disallow a window to focus itself via javascript URLs or using target _self
https://bugs.webkit.org/show_bug.cgi?id=115906

Reviewed by Geoffrey Garen.

Source/WebCore:

Test: fast/dom/Window/window-focus-self.html

  • loader/FrameLoader.cpp:

(WebCore::createWindow):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::focus):

LayoutTests:

  • fast/dom/Window/window-focus-self-expected.txt: Added.
  • fast/dom/Window/window-focus-self.html: Added.
  • platform/wk2/TestExpectations: test uses unimplemented setWindowIsKey.
12:07 PM Changeset in webkit [149935] by Christophe Dumez
  • 58 edits in trunk/Source/WebCore

Fix several style warnings in generated bindings
https://bugs.webkit.org/show_bug.cgi?id=115961

Reviewed by Kentaro Hara.

Fix several style errors in the bindings generated under
Source/WebCore/bindings/scripts/test/

No new tests, no behavior change.

  • bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation):
(WriteData):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(WriteData):

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateHeader):

  • bindings/scripts/test/CPP/WebDOMFloat64Array.cpp:
  • bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.cpp:
  • bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
  • bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp:
  • bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp:
  • bindings/scripts/test/CPP/WebDOMTestEventTarget.cpp:
  • bindings/scripts/test/CPP/WebDOMTestException.cpp:
  • bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
  • bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp:
  • bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp:
  • bindings/scripts/test/CPP/WebDOMTestNode.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestOverloadedConstructors.cpp:
  • bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp:
  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.h:

(WebCore::JSTestActiveDOMObject::releaseImplIfNotNull):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.h:

(WebCore::JSTestCustomNamedGetter::releaseImplIfNotNull):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestEventConstructor.h:

(WebCore::JSTestEventConstructor::releaseImplIfNotNull):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestEventTarget.h:

(WebCore::JSTestEventTarget::releaseImplIfNotNull):

  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestException.h:

(WebCore::JSTestException::releaseImplIfNotNull):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestInterface.h:

(WebCore::JSTestInterface::releaseImplIfNotNull):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::releaseImplIfNotNull):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:

(WebCore::JSTestNamedConstructor::releaseImplIfNotNull):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::releaseImplIfNotNull):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.h:

(WebCore::JSTestOverloadedConstructors::releaseImplIfNotNull):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::releaseImplIfNotNull):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestTypedefs.h:

(WebCore::JSTestTypedefs::releaseImplIfNotNull):

  • bindings/scripts/test/ObjC/DOMFloat64ArrayInternal.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestActiveDOMObjectInternal.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestCallbackInternal.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestCustomNamedGetterInternal.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestEventConstructorInternal.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestEventTargetInternal.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestExceptionInternal.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestInterfaceInternal.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestMediaQueryListListenerInternal.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestNamedConstructorInternal.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestNodeInternal.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestObjInternal.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestOverloadedConstructorsInternal.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterfaceInternal.h:

(WebCore):

  • bindings/scripts/test/ObjC/DOMTestTypedefsInternal.h:

(WebCore):

11:53 AM Changeset in webkit [149934] by akling@apple.com
  • 3 edits in trunk/Source/WebKit2

When possible, terminate web processes immediately when closing their last page.
<http://webkit.org/b/115964>
<rdar://problem/13869266>

Reviewed by Geoffrey Garen.

When we're using a network process, there's no need for the UI process to wait for web processes
to clear resource caches and terminate nicely.

We can just kill them off right away in WebProcessProxy::removeWebPage() when the last page is closed.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::removeWebPage):

Terminate the child process immediately if possible.

  • UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::canTerminateChildProcess):
(WebKit::WebProcessProxy::shouldTerminate):

Broke out the logic from the shouldTerminate() IPC message handler into a separate function
so we can call it from removeWebPage().

11:00 AM Changeset in webkit [149933] by andersca@apple.com
  • 8 edits
    1 add in trunk

Crash when terminating a process that has not been fully launched
https://bugs.webkit.org/show_bug.cgi?id=115962
<rdar://problem/13660916>

Reviewed by Andreas Kling.

Source/WebKit2:

Handle terminating a process that has not been fully launched.

  • UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::ProcessLauncher::didFinishLaunchingProcess):
If we have been invalidated, dispose the connection identifier.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::terminateProcess):
If we're still launching the process, invalidate so the client won't get an unexpected
didFinishLaunching callback.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::requestTermination):
Check if webConnection() is null before calling it. (It will be null if the process isn't fully launched).

Tools:

Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
before the process has had a chance to be fully launched.

  • TestWebKitAPI/GNUmakefile.am:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
9:09 AM Changeset in webkit [149932] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Make it a build error to put invalid C++ symbol names in WebCore.exp.in
https://bugs.webkit.org/show_bug.cgi?id=115958

Reviewed by Andreas Kling.

While invalid C++ symbols will eventually show up as a link error since the symbol won't be found,
this makes it easier to catch invalid symbols inside of #ifdefs.

  • make-export-file-generator:

Try to demangle C++ symbols before printing them.

7:09 AM Changeset in webkit [149931] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX (r149718): Move exported symbol into ENABLE(FULLSCREEN_API) section

Fixes the following build failure when ENABLE(FULLSCREEN_API) is
off:

Undefined symbols for architecture i386:

"ZNK7WebCore7Element25containsFullScreenElementEv", referenced from:

-exported_symbol[s_list] command line option

  • WebCore.exp.in: Move the symbol.
5:14 AM Changeset in webkit [149930] by robert@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, remove some lint accidentally left in r149929.

  • rendering/InlineFlowBox.cpp:

(WebCore::verticalAlignApplies):

5:08 AM Changeset in webkit [149929] by robert@webkit.org
  • 5 edits
    2 adds in trunk

Text flow broken in elements with vertical align top/bottom and inline elements taller than line-height
https://bugs.webkit.org/show_bug.cgi?id=111974

Source/WebCore:

Reviewed by Ryosuke Niwa.

Per http://www.w3.org/TR/CSS2/visudet.html#propdef-vertical-align 'vertical-align' only applies to inline and table-cell
elements.

Test: fast/css/vertical-align-block-elements.html

  • rendering/InlineFlowBox.cpp:

(WebCore::isTextInBlockElement):
(WebCore):
(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):

LayoutTests:

Reviewed by Ryosuke Niwa.

  • editing/execCommand/query-command-state-expected.txt:
  • editing/execCommand/script-tests/query-command-state.js: Remove invalid tests, vertical-align does not apply to div elements.

(runTests):

  • fast/css/vertical-align-block-elements-expected.html: Added.
  • fast/css/vertical-align-block-elements.html: Added.
1:36 AM Changeset in webkit [149928] by benjamin@webkit.org
  • 7 edits in trunk/Source/WebCore

Make CanvasStyle a plain object instead of an RefCounted object
https://bugs.webkit.org/show_bug.cgi?id=115775

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-11
Reviewed by Andreas Kling.

CanvasStyle is just 2 words wide. We do not gain anything from allocating
it on the heap. Change the object to be just a type and some data.

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::toJS):
(WebCore::toHTMLCanvasStyle):

  • html/HTMLCanvasElement.cpp:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::setStrokeStyle):
(WebCore::CanvasRenderingContext2D::setFillStyle):
(WebCore::CanvasRenderingContext2D::setStrokeColor):
(WebCore::CanvasRenderingContext2D::setFillColor):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

  • html/canvas/CanvasRenderingContext2D.h:

(WebCore::CanvasRenderingContext2D::strokeStyle):
(CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::fillStyle):
(State):

  • html/canvas/CanvasStyle.cpp:

(WebCore::CanvasStyle::CanvasStyle):
(WebCore::CanvasStyle::createFromString):
(WebCore::CanvasStyle::createFromStringWithOverrideAlpha):
(WebCore::CanvasStyle::isEquivalentColor):
(WebCore):
(WebCore::CanvasStyle::operator=):
(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):

  • html/canvas/CanvasStyle.h:

(CanvasStyle):
(WebCore::CanvasStyle::isValid):
(WebCore::CanvasStyle::CanvasStyle):
(WebCore):
(WebCore::CanvasStyle::operator=):

12:56 AM Changeset in webkit [149927] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Gradient::platformGradient: Vector reserveCapacity -> reserveInitialCapacity
https://bugs.webkit.org/show_bug.cgi?id=115779

Reviewed by Andreas Kling.

  • platform/graphics/cg/GradientCG.cpp:

(WebCore::Gradient::platformGradient): Clang is surprisingly smart at removing
all the branches of this function. Remove two more with reserveInitialCapacity.

12:47 AM Changeset in webkit [149926] by benjamin@webkit.org
  • 2 edits in trunk/Websites/planet.webkit.org

Remove irrelevant blogs from Planet WebKit
https://bugs.webkit.org/show_bug.cgi?id=115620

Reviewed by Ryosuke Niwa.

  • config.ini:

May 10, 2013:

10:51 PM Changeset in webkit [149925] by ap@apple.com
  • 8 edits
    2 adds
    3 deletes in trunk

<rdar://problem/13666412> Clean up some edge cases of URL parsing.
https://bugs.webkit.org/show_bug.cgi?id=104919

Reviewed by Darin Adler.

WebCore:

  • page/SecurityOrigin.cpp: (WebCore::schemeRequiresHost): (WebCore::shouldTreatAsUniqueOrigin): Updated function name and comments (host is not the same as authority). We still need this check - KURL can still produce http URLs with an empty host (even as this patch reduces the number of such cases). So can Gecko and current draft of URL Standard. It would be good to have a guarantee that such useless URLs can not come out of URL parser, as relying on downstream code re-parsing the URL correctly would be fragile.
  • platform/KURL.cpp: (WebCore::hostPortIsEmptyButCredentialsArePresent): Updated an argument name for correctness. (WebCore::KURL::parse):
  1. Reverted behavior changes from <http://trac.webkit.org/changeset/82181> - I could find no reason to allow "@" in hostnames, and having a URL like this re-parsed by a different parser would likely produce different results. It's better to just treat these edge case URLs as invalid.
  2. When hostname component is a lone colon, preserve it in parsed URL string, as otherwise path would get pushed in its place when re-parsing.
  3. When authority component is a lone colon, don't forget to "" after scheme, too.
  4. Added some assertions about contents of authority component, to catch potential mis-parsing earlier.

LayoutTests:

  • fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-pathname.js:
  • fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt: Updated expectations of one sub-test. We previously tried to keep the test passing as is (see bug 57291), but I couldn't find any reason to prefer the old behavior.
  • fast/url/host-expected.txt:
  • fast/url/host.html: Updated one subtest to new results, which match at least Gecko (original of the test actually claims that all browsers including Safari already do what we'll do now).
  • fast/url/segments-userinfo-vs-host-expected.txt: Added.
  • fast/url/segments-userinfo-vs-host.html: Added. Added a number of tests, with detailed explanations of the differences with Firefox, and with rationales.
  • http/tests/uri/username-with-no-hostname-expected.txt: Removed.
  • http/tests/uri/username-with-no-hostname.html-disabled: Removed.
  • platform/win/http/tests/uri/username-with-no-hostname-expected.txt: Removed. This test has been disabled for a long time, and being an end-to-end test for invalid URL handling, it would be difficult to make work again. We have multiple parsing tests for URLs like this.
10:45 PM Changeset in webkit [149924] by ap@apple.com
  • 3 edits in trunk/Source/WebCore

Make TextCodecICU not depend on TextEncoding
https://bugs.webkit.org/show_bug.cgi?id=115848

Reviewed by Darin Adler.

  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::create): (WebCore::TextCodecICU::TextCodecICU): (WebCore::TextCodecICU::createICUConverter): (WebCore::TextCodecICU::decode): (WebCore::TextCodecICU::encode):
  • platform/text/TextCodecICU.h: Use a plain encoding string in platform encoder wrapper, not a higher level concept.
10:03 PM Changeset in webkit [149923] by commit-queue@webkit.org
  • 20 edits in trunk/Source

Web Inspector: Implement WK2 version of WebInspectorFrontendClient::save
https://bugs.webkit.org/show_bug.cgi?id=115564

Patch by Brian J. Burg <Brian Burg> on 2013-05-10
Reviewed by Benjamin Poulain.

Source/WebKit/mac:

Clean up save() and append() implementations.

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::save):
(WebInspectorFrontendClient::append):

Source/WebKit2:

Implement InspectorFrontendHost's save() and append() methods for
Mac WebKit2. Add canSave() for all ports.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::save):
(WebKit):
(WebKit::WebInspectorProxy::append):

  • UIProcess/WebInspectorProxy.h:

(WebInspectorProxy):

  • UIProcess/WebInspectorProxy.messages.in:
  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformSave):
(WebKit):
(WebKit::WebInspectorProxy::platformAppend):

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformSave):
(WebKit):
(WebKit::WebInspectorProxy::platformAppend):

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformSave):
(WebKit):
(WebKit::WebInspectorProxy::platformAppend):

  • UIProcess/qt/WebInspectorProxyQt.cpp:

(WebKit::WebInspectorProxy::platformSave):
(WebKit):
(WebKit::WebInspectorProxy::platformAppend):

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:

(WebKit::WebInspectorFrontendClient::canSave):
(WebKit):
(WebKit::WebInspectorFrontendClient::save):
(WebKit::WebInspectorFrontendClient::append):

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:

(WebInspectorFrontendClient):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::save):
(WebKit):
(WebKit::WebInspector::append):
(WebKit::WebInspector::didSave):
(WebKit::WebInspector::didAppend):

  • WebProcess/WebPage/WebInspector.h:

(WebInspector):

  • WebProcess/WebPage/WebInspector.messages.in:
  • WebProcess/WebPage/efl/WebInspectorEfl.cpp:

(WebKit::WebInspector::canSave):
(WebKit):

  • WebProcess/WebPage/gtk/WebInspectorGtk.cpp:

(WebKit::WebInspector::canSave):
(WebKit):

  • WebProcess/WebPage/mac/WebInspectorMac.mm:

(WebKit::WebInspector::canSave):
(WebKit):

  • WebProcess/WebPage/qt/WebInspectorQt.cpp:

(WebKit::WebInspector::canSave):
(WebKit):

6:59 PM Changeset in webkit [149922] by l.gombos@samsung.com
  • 18 edits in trunk

Remove Mac OS X Leopard (10.5) support
https://bugs.webkit.org/show_bug.cgi?id=107964

Reviewed by Ryosuke Niwa.

Removed the code for 10.5 and removed if-def for 10.6.

Source/WebCore:

No new tests, covered by existing tests.

  • platform/LocalizedStrings.cpp:

(WebCore::contextMenuItemTagLookUpInDictionary):

  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/mac/EmptyProtocolDefinitions.h:
  • platform/mac/NSScrollerImpDetails.h:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/text/mac/HyphenationMac.mm:

Source/WebKit/mac:

  • DefaultDelegates/WebDefaultContextMenuDelegate.mm:
  • Misc/WebKitErrors.m:

(-[NSError _initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]):

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

  • WebView/WebClipView.mm:

(-[WebClipView _immediateScrollToPoint:]):

  • WebView/WebFrameView.mm:

(-[WebFrameView initWithFrame:]):

  • WebView/WebView.mm:

Tools:

  • DumpRenderTree/cf/WebArchiveDumpSupport.cpp:

(convertMIMEType):
(createXMLStringFromWebArchiveData):

  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::authenticateSession):
(TestRunner::setTextDirection):

  • WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:

(convertMIMEType):
(createXMLStringFromWebArchiveData):

6:27 PM Changeset in webkit [149921] by l.gombos@samsung.com
  • 16 edits in trunk/Source

Remove USE(OS_RANDOMNESS)
https://bugs.webkit.org/show_bug.cgi?id=108095

Reviewed by Darin Adler.

Remove the USE(OS_RANDOMNESS) guard as it is turned on for all
ports.

Source/JavaScriptCore:

  • jit/JIT.cpp:

(JSC::JIT::JIT):

Source/WebCore:

No new tests as this is covered by existing tests.

  • page/Crypto.cpp:

(WebCore::Crypto::getRandomValues):

  • platform/UUID.cpp:

(WebCore::createCanonicalUUIDString):

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataUseFeatures.in:

Source/WTF:

  • wtf/CryptographicallyRandomNumber.cpp:

(WTF::cryptographicallyRandomValues):

  • wtf/CryptographicallyRandomNumber.h:
  • wtf/OSRandomSource.cpp:

(WTF::cryptographicallyRandomValuesFromOS):

  • wtf/OSRandomSource.h:
  • wtf/Platform.h:
  • wtf/RandomNumber.cpp:

(WTF::randomNumber):

  • wtf/RandomNumber.h:
  • wtf/RandomNumberSeed.h:

(WTF::initializeRandomNumberGenerator):

6:24 PM Changeset in webkit [149920] by Christophe Dumez
  • 25 edits in trunk

Remove [NoInterfaceObject] from several WebAudio IDL interfaces
https://bugs.webkit.org/show_bug.cgi?id=115894

Reviewed by Darin Adler.

Source/WebCore:

Several WebAudio IDL interfaces had [NoInterfaceObject] extended attribute set,
meaning that there was no corresponding attribute on the global window object.
This behavior is not according to the specification:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html

This patch removes the [NoInterfaceObject] extended attribute where needed to
match the specification.

No new tests, already covered by existing tests.

  • Modules/webaudio/AnalyserNode.idl:
  • Modules/webaudio/AudioBuffer.idl:
  • Modules/webaudio/AudioBufferSourceNode.idl:
  • Modules/webaudio/AudioDestinationNode.idl:
  • Modules/webaudio/AudioListener.idl:
  • Modules/webaudio/AudioNode.idl:
  • Modules/webaudio/AudioParam.idl:
  • Modules/webaudio/BiquadFilterNode.idl:
  • Modules/webaudio/ChannelMergerNode.idl:
  • Modules/webaudio/ChannelSplitterNode.idl:
  • Modules/webaudio/ConvolverNode.idl:
  • Modules/webaudio/DelayNode.idl:
  • Modules/webaudio/DynamicsCompressorNode.idl:
  • Modules/webaudio/GainNode.idl:
  • Modules/webaudio/MediaElementAudioSourceNode.idl:
  • Modules/webaudio/MediaStreamAudioDestinationNode.idl:
  • Modules/webaudio/MediaStreamAudioSourceNode.idl:
  • Modules/webaudio/OscillatorNode.idl:
  • Modules/webaudio/ScriptProcessorNode.idl:
  • Modules/webaudio/WaveShaperNode.idl:
  • Modules/webaudio/WaveTable.idl:

LayoutTests:

Rebaseline fast/js/global-constructors-attributes.html now that more
global constructors are exposed.

  • fast/js/global-constructors-attributes-expected.txt:
  • platform/efl/fast/js/global-constructors-attributes-expected.txt:
6:23 PM Changeset in webkit [149919] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Copy WKPluginInformation.h header to the WebKit2 Framework private headers.
https://bugs.webkit.org/show_bug.cgi?id=115940

Patch by Remy Demarest <rdemarest@apple.com> on 2013-05-10
Reviewed by Darin Adler.

  • WebKit2.xcodeproj/project.pbxproj:

Move WKPluginInformation.h file from the framework's Project Headers to
Private Headers.

5:59 PM Changeset in webkit [149918] by Simon Fraser
  • 3 edits
    2 adds in trunk

REGRESSION (r145680): No box shadow rendered on element with positioned child that obscures it
https://bugs.webkit.org/show_bug.cgi?id=115840

Source/WebCore:

Reviewed by Antti Koivisto.

In r107836, we moved some box-shadow painting into the paintFillLayer code for performance.
However, in r145680 we started to skip background painting when we know the background is
obscured. This broke shadow painting in some cases.

Fix by always painting the background fill layers if we know that they will also
paint the shadow.

Test: fast/box-shadow/box-shadow-obscured-backgrounds.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBackground):

LayoutTests:

Reviewed by Antti Koivisto.

  • fast/box-shadow/box-shadow-obscured-backgrounds-expected.html: Added.
  • fast/box-shadow/box-shadow-obscured-backgrounds.html: Added.
5:52 PM Changeset in webkit [149917] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/Source/WebKit2

[Qt][Mac] Unreviewed. Roll out the fix attempt in r149912.

  • Target.pri:
5:46 PM Changeset in webkit [149916] by Brent Fulgham
  • 3 edits
    1 add in trunk/Tools

[Windows] Allow VS2010 Build to use VS2005 Support Libraries
https://bugs.webkit.org/show_bug.cgi?id=115935

Reviewed by Jer Noble.

  • WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
  • WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference

to the new manifest file.

  • WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
5:32 PM Changeset in webkit [149915] by Simon Fraser
  • 3 edits
    4 adds in trunk

REGRESSION (r143626): Element shows as garbage in image gallery
https://bugs.webkit.org/show_bug.cgi?id=115946

Source/WebCore:

Reviewed by Antti Koivisto.

RenderLayer::backgroundIsKnownToBeOpaqueInRect() used hasVisibleContent()
to check whether the layer's content was hidden via the visibility property.
However, this assumed that a passing hasVisibleContent() check meant that the
entire area was covered by the renderers and layers checked layer.

This is not always true. It's possible to have a visibility:hidden layer
with a non-covering visbility:visible child, or even a single RenderText
child that happens to have visibility:visible style. In these situations,
hasVisibleContent() returns true but the entire area is not painted.

So we have to fall back to on a more conservative check using the
visibility style, which will give is a reliable answer for the current layer.

Tests: compositing/contents-opaque/hidden-with-visible-child.html

compositing/contents-opaque/hidden-with-visible-text.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

Reviewed by Antti Koivisto.

Test that dumps layers for a visibility:hidden element with a child text node,
and with a visibility:visible child. The resulting compositing layer should
not be marked as opaque.

  • compositing/contents-opaque/hidden-with-visible-child-expected.txt: Added.
  • compositing/contents-opaque/hidden-with-visible-child.html: Added.
  • compositing/contents-opaque/hidden-with-visible-text-expected.txt: Added.
  • compositing/contents-opaque/hidden-with-visible-text.html: Added.
5:31 PM Changeset in webkit [149914] by Simon Fraser
  • 3 edits
    2 adds in trunk

Garbage down left side of nytimes.com page (if subscriber)
https://bugs.webkit.org/show_bug.cgi?id=115839

Source/WebCore:

Reviewed by Antti Koivisto.

RenderLayer::backgroundIsKnownToBeOpaqueInRect() would incorrectly return true
for layers where the given rect wasn't contained in the background rect, but
where some child layer obscured the rect, even though clipping hid part
of that child layer.

So bail from RenderLayer::backgroundIsKnownToBeOpaqueInRect() if we have
any overflow clipping. This could be enhanced in future to test whether child
layers obscure the clipping rect, but that would be more expensive.

Test: compositing/contents-opaque/overflow-hidden-child-layers.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

Reviewed by Antti Koivisto.

  • compositing/contents-opaque/overflow-hidden-child-layers-expected.txt: Added.
  • compositing/contents-opaque/overflow-hidden-child-layers.html: Added.
4:42 PM Changeset in webkit [149913] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix AppleConnect issues for WiFi interfaces
<rdar://problem/13776227&13776240&13776281>
https://bugs.webkit.org/show_bug.cgi?id=115932

Patch by Simon Cooper <scooper@apple.com> on 2013-05-10
Reviewed by Alexey Proskuryakov.

Add support for WiFi interfaces for the AppleConnect plugin.
Remove the FIXME.

  • Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb:
4:36 PM Changeset in webkit [149912] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/Source/WebKit2

[Qt][Mac] Unreviewed speculative build fix after r149904.

  • Target.pri:
4:15 PM Changeset in webkit [149911] by mhahnenberg@apple.com
  • 8 edits
    2 adds in trunk/Source/JavaScriptCore

Rename StructureCheckHoistingPhase to TypeCheckHoistingPhase
https://bugs.webkit.org/show_bug.cgi?id=115938

We're going to add some more types of check hoisting soon, so let's have the right name here.

Rubber stamped by Filip Pizlo.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGStructureCheckHoistingPhase.cpp: Removed.
  • dfg/DFGStructureCheckHoistingPhase.h: Removed.
  • dfg/DFGTypeCheckHoistingPhase.cpp: Copied from Source/JavaScriptCore/dfg/DFGStructureCheckHoistingPhase.cpp.

(JSC::DFG::TypeCheckHoistingPhase::TypeCheckHoistingPhase):
(JSC::DFG::performTypeCheckHoisting):

  • dfg/DFGTypeCheckHoistingPhase.h: Copied from Source/JavaScriptCore/dfg/DFGStructureCheckHoistingPhase.h.
3:56 PM Changeset in webkit [149910] by fpizlo@apple.com
  • 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support CompareStrictEqConstant
https://bugs.webkit.org/show_bug.cgi?id=115941

Reviewed by Mark Hahnenberg.

Pretty simple, but factors out the craziness of comparing against null or undefined
in a way that is reusable for both == and ===.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCompareEqConstant):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEqConstant):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::equalNullOrUndefined):

3:50 PM Changeset in webkit [149909] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/Source/WebKit2

[Qt] Unreviewed buildfix after r149904.

  • Target.pri:
3:22 PM Changeset in webkit [149908] by fpizlo@apple.com
  • 7 edits
    2 adds in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support CompareEqConstant
https://bugs.webkit.org/show_bug.cgi?id=115939

Reviewed by Oliver Hunt and Mark Hahnenberg.

The most interesting part of this patch is the way I make it easier to deal with
the inputs to Phi functions. This adds the notion of ValueFromBlock, which you
can get by doing m_out.anchor(value). You can build up a vector of these, and then
pass them to m_out.phi(type, vector) in one go.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • ftl/FTLAbbreviatedTypes.h: Added.

(FTL):

  • ftl/FTLAbbreviations.h:

(FTL):
(JSC::FTL::addIncoming):
(JSC::FTL::buildPhi):

  • ftl/FTLAbstractHeapRepository.h:

(FTL):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCompareEqConstant):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lowDouble):
(JSC::FTL::LowerDFGToLLVM::masqueradesAsUndefinedWatchpointIfIsStillValid):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::phi):
(Output):
(JSC::FTL::Output::anchor):

  • ftl/FTLValueFromBlock.h: Added.

(FTL):
(ValueFromBlock):
(JSC::FTL::ValueFromBlock::ValueFromBlock):
(JSC::FTL::ValueFromBlock::value):
(JSC::FTL::ValueFromBlock::block):

2:28 PM Changeset in webkit [149907] by zhajiang@rim.com
  • 5 edits in trunk

Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790

Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-05-10.
Reviewed by Rob Buis.

Source/WebKit/blackberry:

Fix the following warnings for BlackBerry:
BackingStore.cpp:852:60: warning: suggest parentheses around '&&' within

'
' [-Wparentheses].

WebPage.cpp:2858:40: warning: suggest parentheses around assignment used
as truth value [-Wparentheses].
WebPage.cpp:2880:42: warning: suggest parentheses around assignment used
as truth value [-Wparentheses]

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::updateTilesAfterBackingStoreRectChange):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::adjustRectOffsetForFrameOffset):
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):

Tools:

Fix the following warnings for BlackBerry:
DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
used as truth value [-Wparentheses].

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):

2:11 PM Changeset in webkit [149906] by eric.carlson@apple.com
  • 8 edits
    2 adds in trunk

In-band captions not visible immediately after track mode change
https://bugs.webkit.org/show_bug.cgi?id=115922

Reviewed by Dean Jackson.

Source/WebCore:

Test: media/track/track-in-band-mode.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTrackModeChanged): Add cues for all loaded tracks, regardless

of track type.

LayoutTests:

  • media/track/track-in-band-mode-expected.txt: Added.
  • media/track/track-in-band-mode.html: Added.
  • platform/efl/TestExpectations: Skip new test.
  • platform/gtk/TestExpectations: Ditto.
  • platform/mac/TestExpectations: Ditto.
  • platform/qt/TestExpectations: Ditto.
  • platform/win/TestExpectations: Ditto.
1:54 PM Changeset in webkit [149905] by timothy@apple.com
  • 3 edits in trunk/Source/WebCore

Web Inspector: determine the resource type in InspectorResourceAgent::willSendRequest.

This allows the Network timeline and Resources sidebar to filter Resources earlier,
before the server sends a response. Useful for long polling (comet) XHRs.

https://webkit.org/b/74935
rdar://problem/13726105

Reviewed by Joseph Pecoraro.

  • inspector/Inspector.json:

(Network.requestWillBeSent): Added.

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willSendRequest): Send the type if it isn't Other along in requestWillBeSent.
(WebCore::InspectorResourceAgent::didReceiveResponse): Don't determine the type here anymore. Clear the CachedResource
if isNotModified like the old code path did by not setting cachedResource if !isNotModified.

1:46 PM Changeset in webkit [149904] by weinig@apple.com
  • 12 edits
    5 adds in trunk/Source/WebKit2

Unify plug-in information dictionaries
<rdar://problem/13852080>
https://bugs.webkit.org/show_bug.cgi?id=115891

Reviewed by Anders Carlsson.

This unifies the plug-in information dictionaries vended by WKContextCopyPlugInInfoForBundleIdentifier
and WKContextGetInfoForInstalledPlugIns with those from the WKPageLoaderClient and WKPageUIClient.

All the old keys will continue to work, but have been deprecated in favor of new keys defined in
WKPluginInformation.h

  • Shared/API/c/WKPluginInformation.cpp: Added.
  • Shared/API/c/WKPluginInformation.h: Added.

Export new keys as SPI.

  • Shared/Plugins/Netscape/PluginInformation.h: Added.
  • Shared/Plugins/Netscape/PluginInformation.cpp: Added.

(WebKit::pluginInformationBundleIdentifierKey):
(WebKit::pluginInformationBundleVersionKey):
(WebKit::pluginInformationPathKey):
(WebKit::pluginInformationDisplayNameKey):
(WebKit::pluginInformationDefaultLoadPolicyKey):
(WebKit::pluginInformationUpdatePastLastBlockedVersionIsKnownAvailableKey):
(WebKit::pluginInformationHasSandboxProfileKey):
(WebKit::pluginInformationFrameURLKey):
(WebKit::pluginInformationMIMETypeKey):
(WebKit::pluginInformationPageURLKey):
(WebKit::pluginInformationPluginspageAttributeURLKey):
(WebKit::pluginInformationPluginURLKey):
Add new keys.

(WebKit::pluginModuleInformation):
(WebKit::createPluginInformationDictionary):
Add creation functions to simplify multiple sites.

  • Shared/Plugins/Netscape/mac/PluginInformationMac.mm: Added.

(WebKit::platformPluginModuleInformation):
Add platform specific data to the dictionary.

  • UIProcess/API/C/WKPage.cpp:

(WKPageGetPluginInformationBundleIdentifierKey):
(WKPageGetPluginInformationBundleVersionKey):
(WKPageGetPluginInformationDisplayNameKey):
(WKPageGetPluginInformationFrameURLKey):
(WKPageGetPluginInformationMIMETypeKey):
(WKPageGetPluginInformationPageURLKey):
(WKPageGetPluginInformationPluginspageAttributeURLKey):
(WKPageGetPluginInformationPluginURLKey):

  • UIProcess/API/C/WKPage.h:

Deprecate the old keys.

  • UIProcess/API/C/mac/WKContextPrivateMac.h:
  • UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextCopyPlugInInfoForBundleIdentifier):
(WKContextGetInfoForInstalledPlugIns):
Simplify by using the new createPluginInformationDictionary functions.

(WKPlugInInfoPathKey):
(WKPlugInInfoBundleIdentifierKey):
(WKPlugInInfoVersionKey):
(WKPlugInInfoLoadPolicyKey):
(WKPlugInInfoUpdatePastLastBlockedVersionIsKnownAvailableKey):
(WKPlugInInfoIsSandboxedKey):
Deprecate the old keys.

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didFailToInitializePlugin):
(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
(WebKit::WebLoaderClient::pluginLoadPolicy):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::unavailablePluginButtonClicked):

  • UIProcess/WebUIClient.h:

Optimize for the most recent callback type which takes a dictionary,
and pull out the necessary bits from it for deprecated callbacks as necessary.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findPlugin):
(WebKit::WebPageProxy::unavailablePluginButtonClicked):
(WebKit::WebPageProxy::didFailToInitializePlugin):
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
Use createPluginInformationDictionary() consistently, to get consistent results for callbacks.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

1:35 PM Changeset in webkit [149903] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Web Inspector: implement runOpenPanel callback for WebKit2 inspector
https://bugs.webkit.org/show_bug.cgi?id=115865

Patch by Brian J. Burg <Brian Burg> on 2013-05-10
Reviewed by Sam Weinig.

  • UIProcess/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::inspectorWindow):
Add an accessor for m_inspectorWindow.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::runOpenPanel):
Show the open panel dialog when requested.

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Register the callback when the inspector page is created.

1:34 PM Changeset in webkit [149902] by commit-queue@webkit.org
  • 13 edits in trunk

[WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
https://bugs.webkit.org/show_bug.cgi?id=115928

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2013-05-10
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

WKViewSetThemePath was moved to WKViewEfl.h since it is EFL specific.

  • UIProcess/API/C/CoordinatedGraphics/WKView.cpp:
  • UIProcess/API/C/CoordinatedGraphics/WKView.h:
  • UIProcess/API/C/efl/WKViewEfl.cpp:

(WKViewSetThemePath):

  • UIProcess/API/C/efl/WKViewEfl.h:
  • UIProcess/CoordinatedGraphics/WebView.cpp:
  • UIProcess/CoordinatedGraphics/WebView.h:

(WebView):

  • UIProcess/efl/ViewClientEfl.cpp:
  • UIProcess/efl/WebInspectorProxyEfl.cpp:
  • UIProcess/efl/WebViewEfl.cpp:

(WebKit::WebViewEfl::setThemePath):

  • UIProcess/efl/WebViewEfl.h:

(WebViewEfl):

Tools:

WKViewSetThemePath was moved to WKViewEfl.h.

  • TestWebKitAPI/efl/PlatformWebView.cpp:
12:24 PM Changeset in webkit [149901] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed mac-lion rebaselines.

  • platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
12:12 PM Changeset in webkit [149900] by fpizlo@apple.com
  • 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support CompareStrictEq
https://bugs.webkit.org/show_bug.cgi?id=115927

Reviewed by Mark Hahnenberg.

Do the sensible thing, and make it so that for common cases, CompareEq is
implemented in terms of CompareStrictEq in the FTL backend. All of the cases
we currently support can be done this way.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):

12:10 PM Changeset in webkit [149899] by l.gombos@samsung.com
  • 5 edits in trunk/Source/WebCore

[CMake] Consolidate list of files to build for WebCore plugin support
https://bugs.webkit.org/show_bug.cgi?id=104429

Reviewed by Rob Buis.

Move the common files to support plugins and the logic for disabling
plugins) to CMakeLists.txt from PlatformXXX.cmake.

No new tests as there is no new functionality.

  • CMakeLists.txt:
  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • PlatformWinCE.cmake:
12:04 PM Changeset in webkit [149898] by fpizlo@apple.com
  • 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support Int32ToDouble
https://bugs.webkit.org/show_bug.cgi?id=115926

Reviewed by Mark Hahnenberg.

This node exists mainly to help the DFG see that a node may have both an int
and a double representation. But in the FTL, nodes already have multiple
representations. So this is just a no-op for the FTL.

I considered making it so that the node isn't even inserted if we're doing
FTL compilation, but that would have required a bunch of conditionalizing in
the DFG's optimization phases, which sort of expect this node to be present
and necessary.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileInt32ToDouble):
(LowerDFGToLLVM):

12:02 PM Changeset in webkit [149897] by robert@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r148121): Empty Span does not get a linebox when it's in an anonymous block
https://bugs.webkit.org/show_bug.cgi?id=115818

Reviewed by David Hyatt.

Source/WebCore:

r148121 only worried about split inlines inside anonymous blocks - it ought to have
catered for empty inlines, with no continuations, inside a single solitary anonymous block too.

Test: fast/inline/anonymous-block-with-empty-inline.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::hasInlineDirectionBordersPaddingOrMargin):

LayoutTests:

  • fast/inline/anonymous-block-with-empty-inline-expected.txt: Added.
  • fast/inline/anonymous-block-with-empty-inline.html: Added.
11:47 AM Changeset in webkit [149896] by fpizlo@apple.com
  • 5 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support LogicalNot
https://bugs.webkit.org/show_bug.cgi?id=115924

Reviewed by Mark Hahnenberg.

  • ftl/FTLAbbreviations.h:

(JSC::FTL::buildNot):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileLogicalNot):
(LowerDFGToLLVM):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::bitNot):

11:39 AM Changeset in webkit [149895] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[GTK] Remove unnecessary includes in WidgetGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=115912

Reviewed by Andreas Kling.

No new tests - no new functionality.

  • platform/gtk/WidgetGtk.cpp: Remove the unnecessary includes of the Chrome.h, Frame.h, FrameView.h,

Page.h and RenderObject.h headers as the included declarations are not used anywhere. ScrollView.h is
included instead as it is required and was previously included by one of the removed header inclusions.

11:38 AM Changeset in webkit [149894] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[Cairo] Remove the unnecessary ImageData.h include in ImageBufferCairo.cpp
https://bugs.webkit.org/show_bug.cgi?id=115911

Reviewed by Carlos Garcia Campos.

No new tests - no new functionality.

  • platform/graphics/cairo/ImageBufferCairo.cpp: Remove the ImageData.h include

as the included declarations are not used anywhere.

11:37 AM Changeset in webkit [149893] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[Cairo] Remove the unnecessary CSSParser.h include in GradientCairo.cpp
https://bugs.webkit.org/show_bug.cgi?id=115910

Reviewed by Laszlo Gombos.

No new tests - no new functionality.

  • platform/graphics/cairo/GradientCairo.cpp: Remove the CSSParser.h include

as the included declarations are not used anywhere.

11:31 AM Changeset in webkit [149892] by fpizlo@apple.com
  • 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support CompareGreater, CompareLessEq, and CompareGreaterEq
https://bugs.webkit.org/show_bug.cgi?id=115923

Reviewed by Mark Hahnenberg.

Also fixed a bug where double CompareLess would assert.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCompareLess):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileCompareLessEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreater):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreaterEq):

11:20 AM Changeset in webkit [149891] by dino@apple.com
  • 3 edits
    2 adds in trunk

Include tab character as a word end for kerning
https://bugs.webkit.org/show_bug.cgi?id=115915
<rdar://problem/13861491>

Reviewed by Enrica Casucci.

This is a follow-up to https://bugs.webkit.org/show_bug.cgi?id=112507
which only looked for a space character as a word end. It should
look for tab characters too.

Source/WebCore:

Test: fast/text/word-space-with-kerning-4.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun): Look for '\t'.

LayoutTests:

  • fast/text/word-space-with-kerning-4-expected.html: Added.
  • fast/text/word-space-with-kerning-4.html: Added.
11:12 AM Changeset in webkit [149890] by fpizlo@apple.com
  • 7 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL CompareEq ObjectUse should handle masquerading
https://bugs.webkit.org/show_bug.cgi?id=115920

Reviewed by Mark Hahnenberg.

We don't yet support watchpoints, but this does all the wiring right up to the
part where we would have emitted watchpoints. I've also written this in a way that
makes it easy to use the case where you would have anyway speculated non-masquerading
even if the watchpoint was invalidated.

This is inherently racy, of course: but the only race here is that you might first
set the watchpoint, and then the watchpoint is invalidated, and then you compile rest
of the code in a way that doesn't need the watchpoint. That's fine, since the FTL
will remember that it had set the watchpoint and then cancel the compilation.

  • ftl/FTLAbbreviations.h:

(JSC::FTL::int8Type):

  • ftl/FTLAbstractHeapRepository.h:

(FTL):

  • ftl/FTLCommonValues.cpp:

(JSC::FTL::CommonValues::CommonValues):

  • ftl/FTLCommonValues.h:

(CommonValues):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::lowNonNullObject):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::speculateNonNullObject):
(JSC::FTL::LowerDFGToLLVM::masqueradesAsUndefinedWatchpointIsStillValid):
(JSC::FTL::LowerDFGToLLVM::masqueradesAsUndefinedWatchpointIfIsStillValid):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::constInt8):
(JSC::FTL::Output::load8):
(JSC::FTL::Output::isZero8):
(JSC::FTL::Output::notZero8):
(JSC::FTL::Output::testIsZero8):
(JSC::FTL::Output::testNonZero8):

10:48 AM Changeset in webkit [149889] by akling@apple.com
  • 2 edits in trunk/Tools

I accidentally the Java testing.

  • Scripts/webkitpy/port/mac.py:
10:39 AM Changeset in webkit [149888] by andersca@apple.com
  • 8 edits
    2 deletes in trunk/Source/WebCore

Remove EventTracer
https://bugs.webkit.org/show_bug.cgi?id=115916

Reviewed by Sam Weinig.

EventTracer is dead code, remove it.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/EventTracer.cpp: Removed.
  • platform/EventTracer.h: Removed.
10:36 AM Changeset in webkit [149887] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[GTK] Generated files are regenerated always
https://bugs.webkit.org/show_bug.cgi?id=115908

Reviewed by Carlos Garcia Campos.

No new tests - no change in functionality.

  • GNUmakefile.am: Don't treat the window constructors IDL file as a dependency of the JavaScriptCore bindings.

The file is generated during the IDL preprocessing, and the JSC bindings already depend on that step through
the idl_supplemental_dependencies file. Because of that the window constructors IDL file has a phony target
which seems to confuse the bindings generation rule into thinking that a complete regeration of the bindings is required.

10:34 AM Changeset in webkit [149886] by akling@apple.com
  • 10 edits in trunk

Caching of generated images in CSS should be smarter.
<http://webkit.org/b/115902>
<rdar://problem/13542727>

Reviewed by Antti Koivisto.

Add an IntSize => GeneratorGeneratedImage cache at the CSSImageGeneratorValue level.

CSSGradientValue is currently the only CSSImageGeneratorValue subclass that makes use of the cache.
Generated images are kept for 3 seconds after last use.

The main problem with the previous approach was that background renderers (e.g <body>, <tr>, etc)
would be passed to multiple CSSImageGeneratorValue::getImage() calls with different sizes requested
for each of the descendent renderers that inherit their background from the same parent.
The cache wasn't smart enough for this, it just thought the background renderer was changing size
a lot, and would regenerate the image over and over.

We already had caching of intermediate image buffers for GeneratorGeneratedImage::drawPattern().
This removes the eviction timer from that cache so that the intermediate images can live a bit longer.

(WebCore::CSSImageGeneratorValue::cachedImageForSize):
(WebCore::CSSImageGeneratorValue::saveCachedImageForSize):

Renamed from getImage() and putImage().

(WebCore::CSSImageGeneratorValue::evictCachedGeneratedImage):
(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::CachedGeneratedImage):
(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::evictionTimerFired):

Let the CachedGeneratedImage throw itself out from cache when the timer fires.

  • css/CSSImageGeneratorValue.h:

(CachedGeneratedImage):

Exactly what it sounds like. These go into CSSImageGeneratorValue::m_images with the size
as the hash key.

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::drawPattern):

  • platform/graphics/GeneratorGeneratedImage.h:

(WebCore::GeneratorGeneratedImage::~GeneratorGeneratedImage):
(WebCore::GeneratorGeneratedImage::GeneratorGeneratedImage):

Keep the intermediate image for drawPattern() until destruction instead of dropping it on
a timer. These objects are now evicted by the CSSImageGeneratorValue's image cache
after 3 seconds of disuse rather than kept for the lifetime of the renderer.

  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::canvasChanged):
(WebCore::CSSCanvasValue::canvasResized):

  • css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::crossfadeChanged):

  • rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::addClient):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::addClient):
(WebCore::CSSImageGeneratorValue::removeClient):

CSSImageGeneratorValue::m_clients is now a HashCountedSet<RenderObject*>, tweak accordingly.

10:20 AM Changeset in webkit [149885] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r149439): Video turns blank upon entering full screen for the first time
https://bugs.webkit.org/show_bug.cgi?id=115617

Reviewed by Eric Carlson.

Partially revert the change introduced in r149439 for OS X 10.8 and previous. On these
platforms, create a window with a NSZeroSize initial frame, which fixes the "blank"
first-full screen behavior.

  • UIProcess/API/mac/WKView.mm:

(-[WKView createFullScreenWindow]):

10:16 AM Changeset in webkit [149884] by zandobersek@gmail.com
  • 7 edits in trunk/Source/WebKit2

[WK2] Make the WebSoupRequestManager a supplement to the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=115717

Reviewed by Andreas Kling.

WebSoupRequestManager should inherit from WebProcessSupplement and should be used as such
by the WebProcess. This removes the need for the m_soupRequestManager member variable in
the WebProcess class and brings the WebSoupRequestManager in line with other manager classes
of which instances are controlled by the WebProcess class.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess): Add the WebSoupRequestManager as a supplement.

  • WebProcess/WebProcess.h:

(WebProcess): Remove the m_soupRequestManager member variable and its getter method.

  • WebProcess/soup/WebKitSoupRequestGeneric.cpp:

(webkitSoupRequestGenericSendAsync): Access the WebSoupRequestManager as a supplement.
(webkitSoupRequestGenericSendFinish): Ditto.

  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformInitializeWebProcess): Access the WebSoupRequestManager as a supplement.

  • WebProcess/soup/WebSoupRequestManager.cpp:

(WebKit::WebSoupRequestManager::supplementName): Specify the supplement's name.

  • WebProcess/soup/WebSoupRequestManager.h:

(WebSoupRequestManager): Inherit from the WebProcessSupplement interface.

10:04 AM Changeset in webkit [149883] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Module Cairo fails to build under jhbuild
https://bugs.webkit.org/show_bug.cgi?id=115854

Patch by Brian Holt <brian.holt@samsung.com> on 2013-05-10
Reviewed by Martin Robinson.

Make cairo depend on glib in jhbuild.modules.

  • gtk/jhbuild.modules:
10:03 AM Changeset in webkit [149882] by andersca@apple.com
  • 10 edits
    3 deletes in trunk/Source/WebCore

Remove MemoryUsageSupport class
https://bugs.webkit.org/show_bug.cgi?id=115913

Reviewed by Andreas Kling.

MemoryUsageSupport was just used by a single call site in InspectorTimelineAgent,
and the function called always returns zero on all platforms! Remove it.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorMemoryAgent.cpp:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore):
(WebCore::InspectorTimelineAgent::setNativeHeapStatistics):

  • platform/MemoryUsageSupport.cpp: Removed.
  • platform/MemoryUsageSupport.h: Removed.
  • platform/qt/MemoryUsageSupportQt.cpp: Removed.
9:38 AM Changeset in webkit [149881] by rniwa@webkit.org
  • 7 edits
    2 adds in trunk

REGRESSION (r149652): Videos do not play on cnn.com, just black box
https://bugs.webkit.org/show_bug.cgi?id=115887

Reviewed by Antti Koivisto.

Source/WebCore:

The bug was caused by window and document named item maps counting the same element twice
when it has the same id and name attribute values. Fixed the bug by avoiding to add or remove
an element per id and name attribute updates when it had already been added or removed by
name and id attribute updates respectively.

We do this by checking whether the other attribute affects the element's precense in window
and document named item maps and avoiding to add or remove the attribute when they do and
the other attribute is present in updateId and updateName.

Consider a scenario when an object element has id "foo", and name attribute is about to be also
set to "foo". If the id attribute doesn't affect element's presense in window or document
named item maps, we're done. If it does, then the maps already have this element so we don't
want to add it again. Conversely, if the element already has id and name attributes set to
"foo", and we're moving the id attribute, then we want to remove the element from the maps only
if the id doesn't affect the presence of the element in the maps.

Unfortuntely, this logic doesn't work when we're inserting or removing an element on its entirely
because updateId and updateName are called when both id and name attributes are present so skip
this step (AlwaysUpdateHTMLDocumentNamedItemMaps) for the id attribute to break the symmetry.

Test: fast/dom/HTMLDocument/image-with-same-id-and-name.html

fast/dom/HTMLDocument/object-with-same-id-and-name.html

  • dom/Element.cpp:

(WebCore::Element::insertedInto): Call updateId and updateName with
AlwaysUpdateHTMLDocumentNamedItemMaps.
(WebCore::Element::removedFrom): Ditto.
(WebCore::Element::updateName): Don't add or remove this element if the id attribute has already
done so except when we're inserting, removing, or cloning an element.
(WebCore::Element::updateId): Ditto for the name attribute.
(WebCore::Element::cloneAttributesFromElement): Added a comment and assert that we never call this
function when this element is in the document. We can't update window and documemt named item
maps here because image element's id attribute value, for example, is present in the document's
named item map if it has a name attribute. Since this function calls updateId and updateName
before updating attributes, this check is going to fail in DocumentNameCollection's
nodeMatchesIfIdAttributeMatch and bad things will happen.

  • dom/Element.h:
  • editing/ReplaceNodeWithSpanCommand.cpp:

(WebCore::swapInNodePreservingAttributesAndChildren): Clone children and attributes before
inserting the swapped span to avoid hitting the assertion in cloneAttributesFromElement we added.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem):

LayoutTests:

Add regression tests.

  • fast/dom/HTMLDocument/image-with-same-id-and-name-expected.txt: Added.
  • fast/dom/HTMLDocument/image-with-same-id-and-name.html: Added.
  • fast/dom/HTMLDocument/object-with-same-id-and-name-expected.txt: Added.
  • fast/dom/HTMLDocument/object-with-same-id-and-name.html: Added.
9:18 AM Changeset in webkit [149880] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Don't trust character widths for internal OS X fonts in form controls
https://bugs.webkit.org/show_bug.cgi?id=115883
<rdar://problem/13817757>

Reviewed by Darin Adler.

We ignore the character width for a bunch of fonts when predicting
the width of a form control. Some of the internal fonts in OS X are
not in the ignored list. Rather than add them, simply test for
fonts whose family begins with a period character ".".

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::hasValidAvgCharWidth): Return false for

any family that starts with "."

9:11 AM Changeset in webkit [149879] by Carlos Garcia Campos
  • 11 edits in trunk

[GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=115904

Reviewed by Martin Robinson.

Source/WebCore:

  • bindings/gobject/WebKitDOMEventTarget.cpp:
  • platform/gtk/GtkVersioning.c:
  • platform/gtk/GtkVersioning.h:

Source/WebKit2:

  • UIProcess/API/gtk/tests/TestInspectorServer.cpp:

(startTestServerMonitor):

  • UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp:

(startTestServerMonitor):

Source/WTF:

  • wtf/gobject/GRefPtr.cpp:

Tools:

  • ImageDiff/gtk/ImageDiff.cpp:

(main):

9:01 AM Changeset in webkit [149878] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix the ENABLE(SHARED_WORKERS) build after r149864.

  • workers/SharedWorkerThread.cpp: include "SecurityOrigin.h"
8:27 AM Changeset in webkit [149877] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

Add my new address to contributors.json. (Unreviewed)

  • Scripts/webkitpy/common/config/contributors.json:
7:05 AM Changeset in webkit [149876] by Claudio Saavedra
  • 2 edits in trunk/Source/WebCore

Fix build after r149864.

Unreviewed build fix.

  • loader/ThreadableLoader.h: include <wtf/text/AtomicString.h>

when building with RESOURCE_TIMING enabled.

6:26 AM WebKit Team edited by Christophe Dumez
Move myself to the Reviewers list (diff)
6:19 AM Changeset in webkit [149875] by Christophe Dumez
  • 2 edits in trunk/Tools

Unreviewed. Move myself to the reviewers list.

  • Scripts/webkitpy/common/config/contributors.json:
6:16 AM Changeset in webkit [149874] by Christophe Dumez
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline fast/dom/Range/getClientRects.html for EFL port.
Skip accessibility/poorly-formed-aria-table.html introduced in
r149858 but failing on EFL port.

  • platform/efl/TestExpectations:
  • platform/efl/fast/dom/Range/getClientRects-expected.txt:
6:00 AM Changeset in webkit [149873] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • bindings/js/ScriptController.cpp:
5:53 AM Changeset in webkit [149872] by zarvai@inf.u-szeged.hu
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/fast/js/global-constructors-attributes-expected.txt: Rebaselining after r149845.
  • platform/qt/inspector/console/command-line-api-expected.txt: Added after r149829.
5:51 AM Changeset in webkit [149871] by andersca@apple.com
  • 13 edits
    1 delete in trunk/Source/WebCore

Remove ScriptInstance.h
https://bugs.webkit.org/show_bug.cgi?id=115900

Reviewed by Andreas Kling.

Remove yet another abstraction now that we don't support V8.

  • GNUmakefile.list.am:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptController.h:

(Bindings):
(ScriptController):

  • bindings/js/ScriptControllerMac.mm:

(WebCore::ScriptController::createScriptInstanceForWidget):

  • bindings/js/ScriptInstance.h: Removed.
  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::getInstance):

  • html/HTMLPlugInElement.h:

(Bindings):
(HTMLPlugInElement):

  • platform/graphics/wince/MediaPlayerProxy.h:

(WebMediaPlayerProxy):

  • rendering/RenderEmbeddedObject.cpp:
  • rendering/RenderSnapshottedPlugIn.cpp:
5:49 AM Changeset in webkit [149870] by Christophe Dumez
  • 3 edits
    3 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Skip several remaining shadow dom tests and rebaseline a few others.

  • platform/efl/TestExpectations:
  • platform/efl/fast/images/crossfade-client-not-removed-crash-expected.txt: Added.
  • platform/efl/fast/js/dom-static-property-for-in-iteration-expected.txt:
  • platform/efl/inspector/console/command-line-api-expected.txt: Added.
5:22 AM Changeset in webkit [149869] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r149866.
http://trac.webkit.org/changeset/149866
https://bugs.webkit.org/show_bug.cgi?id=115898

Broke tests

  • dom/Document.cpp:

(WebCore::Document::setDomain):
(WebCore::Document::initSecurityContext):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::isolatedCopy):
(WebCore::SecurityOrigin::setDomainFromDOM):
(WebCore::SecurityOrigin::grantUniversalAccess):

  • page/SecurityOrigin.h:

(SecurityOrigin):

5:21 AM Changeset in webkit [149868] by Christophe Dumez
  • 2 edits in trunk/Tools

Unreviewed. Add my email to a few watchlists.

  • Scripts/webkitpy/common/config/watchlist:
5:17 AM Changeset in webkit [149867] by abucur@adobe.com
  • 3 edits in trunk/Source/WebCore

Remove overflow dead code
https://bugs.webkit.org/show_bug.cgi?id=115893

Reviewed by Antti Koivisto.

The patch removes unused public overflow accesor functions from RenderOverflow and InlineFlowBox.

Tests: no tests, code cleanup.

  • rendering/InlineFlowBox.h: Removed logicalLeftLayoutOverflow and logicalRightLayoutOverflow.
  • rendering/RenderOverflow.h: Removed setMinYLayoutOverflow, setMaxYLayoutOverflow,

setMinXLayoutOverflow, setMaxXLayoutOverflow, setMinYVisualOverflow, setMaxYVisualOverflow,
setMinXVisualOverflow and setMaxXVisualOverflow.

4:59 AM Changeset in webkit [149866] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Begin making SecurityOrigin immutable
https://bugs.webkit.org/show_bug.cgi?id=115898

Reviewed by Andreas Kling.

Replace SecurityOrigin::setDomainFromDOM and SecurityOrigin::grantUniversalAccess with
member functions that return new SecurityOrigin objects.

  • dom/Document.cpp:

(WebCore::Document::setDomain):
Update the security origin to one returned by copyWithDomainSetFromDOM.

(WebCore::Document::initSecurityContext):
Set the security origin to one returned by copyWithUniversalAccessGranted().

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):
Add a new constructor that takes all the member variables as parameters. This is a little unwieldy at the moment,
but all the boolean parameters could be replaced by a bitmask of flags.

(WebCore::SecurityOrigin::isolatedCopy):
Call the new constructor.

(WebCore::SecurityOrigin::copyWithDomainSetFromDOM):
Return a new security origin with m_domainWasSetInDOM set to true and the domain updated.

(WebCore::SecurityOrigin::copyWithUniversalAccessGranted):
Return a new security origin with m_universalAccess set to true.

4:18 AM Changeset in webkit [149865] by andersca@apple.com
  • 7 edits in trunk/Source/WebCore

Remove ScriptController::updateSecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=115895

Reviewed by Antti Koivisto.

ScriptController::updateSecurityOrigin is just dead code now that the V8 bindings are gone.

  • bindings/js/ScriptController.cpp:
  • bindings/js/ScriptController.h:
  • dom/Document.cpp:

(WebCore::Document::setIsViewSource):
(WebCore::Document::setDomain):

  • dom/Document.h:

(Document):

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::enforceSandboxFlags):

  • dom/SecurityContext.h:

(SecurityContext):

4:12 AM Changeset in webkit [149864] by andersca@apple.com
  • 15 edits in trunk/Source/WebCore

Stop including SecurityOrigin.h where unnecessary
https://bugs.webkit.org/show_bug.cgi?id=115897

Reviewed by Antti Koivisto.

Move rarely called functions out of line so headers don't have to include SecurityOrigin.h

  • Modules/indexeddb/IDBFactoryBackendImpl.h:
  • Modules/webdatabase/DatabaseBackendBase.cpp:

(WebCore::DatabaseBackendBase::databaseDebugName):

  • Modules/webdatabase/DatabaseBackendBase.h:

(DatabaseBackendBase):

  • Modules/webdatabase/DatabaseSync.h:
  • bindings/js/JSDOMWindowCustom.h:
  • html/parser/XSSAuditor.cpp:
  • loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):
(WebCore::ThreadableLoaderOptions::~ThreadableLoaderOptions):
(WebCore::ThreadableLoader::create):

  • loader/ThreadableLoader.h:

(ThreadableLoaderOptions):

  • loader/WorkerThreadableLoader.cpp:
  • workers/DedicatedWorkerContext.cpp:
  • workers/DedicatedWorkerThread.cpp:
  • workers/SharedWorkerContext.cpp:
  • workers/WorkerThread.cpp:
  • workers/WorkerThread.h:
2:37 AM WK2-EFLTextCheckerApiTutorial edited by a.badowski@samsung.com
(diff)
2:32 AM WK2-EFLTextCheckerApiTutorial edited by a.badowski@samsung.com
(diff)
2:29 AM WK2-EFLTextCheckerApiTutorial edited by a.badowski@samsung.com
(diff)
1:45 AM Changeset in webkit [149863] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Unicode support missing from string representation of Contributors in committers.py
https://bugs.webkit.org/show_bug.cgi?id=115859

Patch by Simon Pena <simon.pena@samsung.com> on 2013-05-10
Reviewed by Darin Adler.

Contributors, in committers.py, provided a string representation in str which
didn't support unicode characters, so printing a contributor would fail in that case.
This patch implements unicode and makes str use it to represent a contributor.
The unit tests are updated accordingly, so they ensure that a unicode name can be shown.

  • Scripts/webkitpy/common/config/committers.py: Move the existing string representation

to the newly implemented method unicode, and make str display its utf-8 encoded
representation.
(Contributor.str):
(Contributor):
(Contributor.unicode):

  • Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that

a contributor with unicode characters can be represented as a string.
(CommittersTest):
(CommittersTest.test_contributor_encoding):

12:41 AM Changeset in webkit [149862] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix GTK+ build after r149839.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::gtkStyleChangedCallback):

May 9, 2013:

8:29 PM Changeset in webkit [149861] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: DFG shouldn't allocate in the GC heap
https://bugs.webkit.org/show_bug.cgi?id=115598

Reviewed by Geoffrey Garen.

I believe that we've now fixed this, and this patch just adds the relevant assertion.

  • runtime/JSCellInlines.h:

(JSC::JSCell::JSCell):

7:45 PM Changeset in webkit [149860] by fpizlo@apple.com
  • 12 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: CodeBlock should be RefCounted
https://bugs.webkit.org/show_bug.cgi?id=115594

Reviewed by Geoffrey Garen.

This makes it possible to have the currently-being-compiled CodeBlock not be
installed in Executable, while also allowing it to point to its intended
alternative(). So long as we were using ownership and not reference counting, it
would have been difficult to have both CodeBlock::m_alternative and
Executable::m_codeBlockForBlah point to the previous CodeBlock.

I also took the opportunity to clean up a bunch of code that appears to have
rotted.

  • assembler/MacroAssemblerCodeRef.h:

(MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::operator==):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::releaseAlternative):
(JSC::CodeBlock::setAlternative):
(CodeBlock):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):

  • heap/DFGCodeBlocks.cpp:

(JSC::DFGCodeBlocks::~DFGCodeBlocks):
(JSC::DFGCodeBlocks::jettison):
(JSC::DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks):

  • heap/DFGCodeBlocks.h:

(DFGCodeBlocks):

  • heap/Heap.cpp:

(JSC::Heap::jettisonDFGCodeBlock):

  • heap/Heap.h:
  • jit/JITDriver.h:

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

  • runtime/Executable.cpp:

(JSC::jettisonCodeBlock):
(JSC::EvalExecutable::jitCompile):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::jitCompile):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::jitCompileForCall):
(JSC::FunctionExecutable::jitCompileForConstruct):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

  • runtime/Executable.h:

(EvalExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::codeBlockFor):

  • runtime/ExecutionHarness.h:

(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):

6:46 PM Changeset in webkit [149859] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

Unskipped the webarchive tests for Mac that are not skipped for a reason other than
dumpDOMAsWebArchive not being implemented, which was fixed in r149692.
https://bugs.webkit.org/show_bug.cgi?id=115819

Patch by Alex Christensen <achristensen@apple.com> on 2013-05-09
Reviewed by Benjamin Poulain.

  • platform/efl-wk2/TestExpectations:

Skip webarchive tests.

  • platform/gtk-wk2/TestExpectations:

Skip webarchive tests.

  • platform/qt-5.0-mac-wk2/TestExpectations:

Skip webarchive tests.

  • platform/qt-5.0-wk2/TestExpectations:

Skip webarchive tests.

  • platform/wk2/TestExpectations:

Removed universal skipping of webarchive tests, noted which tests are still skipped with bug numbers.

5:57 PM Changeset in webkit [149858] by Chris Fleizach
  • 10 edits
    2 adds in trunk

AX: VoiceOver is no longer seeing items in poorly formed tables
https://bugs.webkit.org/show_bug.cgi?id=115837

Reviewed by Darin Adler.

Source/WebCore:

In case the author didn't include the rows of a table as the
direct children, a table needs to dive down its descendant chain
until the rows are found.

I also took the opportunity to clean up a bit around what the different
meanings of table are in the accessibility classes.

Test: accessibility/poorly-formed-aria-table.html

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addRowDescendant):
(WebCore::AccessibilityARIAGrid::addChildren):

  • accessibility/AccessibilityARIAGrid.h:

(AccessibilityARIAGrid):

  • accessibility/AccessibilityARIAGridRow.cpp:

(WebCore::AccessibilityARIAGridRow::parentTable):
(WebCore):

  • accessibility/AccessibilityARIAGridRow.h:

(AccessibilityARIAGridRow):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isTable):

  • accessibility/AccessibilityTable.h:

(AccessibilityTable):
(WebCore::AccessibilityTable::isTable):
(WebCore::toAccessibilityTable):

  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::parentTable):

LayoutTests:

  • accessibility/poorly-formed-aria-table-expected.txt: Added.
  • accessibility/poorly-formed-aria-table.html: Added.
5:12 PM Changeset in webkit [149857] by zoltan@webkit.org
  • 6 edits in trunk/LayoutTests

[Qt] REGRESSION (r148975) shape-inside-percentage.html and shape-inside-overflow-fixed-dimensions.html are failing after r148975
https://bugs.webkit.org/show_bug.cgi?id=115053

Reviewed by Alexandru Chiculita.

I changed the tests to use Ahem font (overflow will be the same on every port) and modify the markup in order to be the similar
for the two tests. The change fixes both tests and make them passing on Qt as well. I removed the tests from the TestExpectations.

  • fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html:
  • fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html:
  • fast/exclusions/shape-inside/shape-inside-percentage-expected.html:
  • fast/exclusions/shape-inside/shape-inside-percentage.html:
  • platform/qt/TestExpectations:
4:55 PM Changeset in webkit [149856] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

REGRESSION: Disabled multiline select element now responds to (certain) clicks
https://bugs.webkit.org/show_bug.cgi?id=115710

Patch by Yael Aharon <yael.aharon@intel.com> on 2013-05-09
Reviewed by Kent Tamura.

Source/WebCore:

After http://trac.webkit.org/changeset/140286, select elements can scroll whether they
are disabled or not. While they scroll, they also change the selected item.
This patch allows the select element to scroll, but does not change the selection
if the select element is disabled.

Test: fast/forms/select/listbox-disabled-scroll-no-onchange.html
Test: fast/forms/select/listbox-disabled-no-autoscroll.html

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::autoscroll):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::stopAutoscroll):

LayoutTests:

Test that a disabled element does not change selection while scrolling.

  • fast/forms/select/listbox-disabled-scroll-no-onchange-expected.txt: Added.
  • fast/forms/select/listbox-disabled-scroll-no-onchange.html: Added.
  • fast/forms/select/listbox-disabled-no-autoscroll.html: Added.
  • fast/forms/select/listbox-disabled-no-autoscroll-expected.html: Added.
4:47 PM Changeset in webkit [149855] by Patrick Gansterer
  • 4 edits in trunk/Tools

[WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
https://bugs.webkit.org/show_bug.cgi?id=92371

Reviewed by Brent Fulgham.

Use JavaScriptThreading.cpp where the same functionality is
implemented too. This reduces the dependency on the pthread
library. Also replace assert() with WebKit ASSERT().

  • DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
  • DumpRenderTree/win/DumpRenderTree.cpp:

(dumpHistoryItem):
(dumpBackForwardList):

  • DumpRenderTree/win/DumpRenderTree.vcproj:
4:41 PM Changeset in webkit [149854] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Clean up SecurityOrigin::databaseIdentifier
https://bugs.webkit.org/show_bug.cgi?id=115882

Reviewed by Beth Dakin.

Remove m_encodedHost and just call encodeHost from databaseIdentifier().
Also, use a StringBuilder when constructing the database identifier to avoid allocating
temporary String objects over and over.

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore):
(WebCore::SecurityOrigin::createFromDatabaseIdentifier):
(WebCore::SecurityOrigin::databaseIdentifier):

  • page/SecurityOrigin.h:

(SecurityOrigin):

4:21 PM Changeset in webkit [149853] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Remove m_securityOrigin from XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=115881

Reviewed by Alexey Proskuryakov.

The security origin passed to XMLHttpRequest::create was always null, so just get rid of the member variable completely.

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::create):
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::securityOrigin):

  • xml/XMLHttpRequest.h:

(XMLHttpRequest):

4:03 PM Changeset in webkit [149852] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
3:50 PM Changeset in webkit [149851] by fpizlo@apple.com
  • 16 edits
    4 adds in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: DFG should have its own notion of StructureChain, and it should be possible to validate it after compilation finishes
https://bugs.webkit.org/show_bug.cgi?id=115841

Reviewed by Oliver Hunt.

This adds IntendedStructureChain, which is like StructureChain, except that it holds a bit
more information and can be validated independantly of its owning Structure and lexical
GlobalObject, since it remembers both of those things. It's also malloc'd and RefCounted
rather than GC'd, so it can be allocated in a concurrent compilation thread.

Gave this class a bunch of methods to allow the following idiom:

  • Snapshot a structure chain concurrently. This structure chain may end up being wrong in case of races, but in that case we will find out when we try to validate it.


  • Perform validation on the structure chain itself, without recomputing the chain. Previously, many chain validation methods (prototypeChainMayInterceptStoreTo() for example) recomputed the chain, and hence, were inherently racy: you could build one chain and then validate against a different chain, and hence not realize that the chain you did build was actually broken for your purposes, because the chain you checked was a different one.


  • Validate that the chain is still the right one at any time, allowing the cancellation of compilation if there was a race.


Also added DFG::DesiredStructureChains, which tracks those intended structure chains that
the compiler had already chosen to use. If any of those are invalid at link time, throw
out the compilation.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):

  • bytecode/GetByIdStatus.h:

(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::chain):
(GetByIdStatus):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):

  • bytecode/PutByIdStatus.h:

(JSC::PutByIdStatus::PutByIdStatus):
(JSC::PutByIdStatus::structureChain):
(PutByIdStatus):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGDesiredStructureChains.cpp: Added.

(DFG):
(JSC::DFG::DesiredStructureChains::DesiredStructureChains):
(JSC::DFG::DesiredStructureChains::~DesiredStructureChains):
(JSC::DFG::DesiredStructureChains::areStillValid):

  • dfg/DFGDesiredStructureChains.h: Added.

(DFG):
(DesiredStructureChains):
(JSC::DFG::DesiredStructureChains::addLazily):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::isStillValid):
(DFG):

  • dfg/DFGGraph.h:

(Graph):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::linkFunction):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • runtime/IntendedStructureChain.cpp: Added.

(JSC):
(JSC::IntendedStructureChain::IntendedStructureChain):
(JSC::IntendedStructureChain::~IntendedStructureChain):
(JSC::IntendedStructureChain::isStillValid):
(JSC::IntendedStructureChain::matches):
(JSC::IntendedStructureChain::chain):
(JSC::IntendedStructureChain::mayInterceptStoreTo):
(JSC::IntendedStructureChain::isNormalized):
(JSC::IntendedStructureChain::terminalPrototype):

  • runtime/IntendedStructureChain.h: Added.

(JSC):
(IntendedStructureChain):
(JSC::IntendedStructureChain::head):
(JSC::IntendedStructureChain::size):
(JSC::IntendedStructureChain::at):
(JSC::IntendedStructureChain::operator[]):
(JSC::IntendedStructureChain::last):

  • runtime/Structure.cpp:

(JSC::Structure::prototypeChainMayInterceptStoreTo):

  • runtime/Structure.h:

(Structure):

  • runtime/StructureInlines.h:

(JSC::Structure::storedPrototypeObject):
(JSC):
(JSC::Structure::storedPrototypeStructure):

3:40 PM Changeset in webkit [149850] by Christophe Dumez
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed build fix after r149836.

It broke at least EFL and GTK builds. Move new static members initialization
outside the class. Those need to have a definition outside the class because
their address is used (e.g. CodeCacheMap::nonGlobalWorkingSetMaxEntries).

  • runtime/CodeCache.cpp:

(JSC):

  • runtime/CodeCache.h:

(CodeCacheMap):

3:39 PM Changeset in webkit [149849] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Enable UI process storage
https://bugs.webkit.org/show_bug.cgi?id=115879
<rdar://problem/12239765>

Reviewed by Beth Dakin.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

Flip the switch.

3:37 PM Changeset in webkit [149848] by andersca@apple.com
  • 121 edits in trunk/Source/WebKit2

Remove extra spaces between right angle brackets in template declarations
https://bugs.webkit.org/show_bug.cgi?id=115877

Reviewed by Beth Dakin.

C++11 doesn't require spaces between right angle brackets so remove all of them.

  • NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:

(WebKit::NetworkBlobRegistry::registerBlobURL):
(WebKit::NetworkBlobRegistry::sandboxExtensions):

  • NetworkProcess/FileAPI/NetworkBlobRegistry.h:

(NetworkBlobRegistry):

  • NetworkProcess/HostRecord.h:

(HostRecord):

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::registerBlobURL):

  • NetworkProcess/NetworkConnectionToWebProcess.h:

(NetworkConnectionToWebProcess):

  • NetworkProcess/NetworkProcess.h:

(NetworkProcess):

  • NetworkProcess/NetworkResourceLoadScheduler.cpp:

(WebKit::NetworkResourceLoadScheduler::servePendingRequests):
(WebKit::NetworkResourceLoadScheduler::removeScheduledLoaders):

  • NetworkProcess/NetworkResourceLoadScheduler.h:
  • NetworkProcess/SchedulableLoader.cpp:

(WebKit::SchedulableLoader::SchedulableLoader):

  • NetworkProcess/SchedulableLoader.h:

(SchedulableLoader):

  • Platform/CoreIPC/ArgumentCoders.h:
  • Platform/CoreIPC/Connection.cpp:

(Connection::SyncMessageState):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::processIncomingMessage):

  • Platform/CoreIPC/Connection.h:

(Connection):

  • Platform/WorkQueue.h:

(WorkQueue):

  • PluginProcess/PluginProcess.h:

(PluginProcess):

  • Scripts/webkit2/messages_unittest.py:

(CoreIPC):

  • Shared/BlockingResponseMap.h:

(BlockingResponseMap):

  • Shared/ChildProcessProxy.h:

(ChildProcessProxy):

  • Shared/ImmutableArray.cpp:

(WebKit::ImmutableArray::ImmutableArray):

  • Shared/ImmutableArray.h:

(WebKit::ImmutableArray::adopt):
(ImmutableArray):

  • Shared/ImmutableDictionary.cpp:

(WebKit::ImmutableDictionary::keys):

  • Shared/ImmutableDictionary.h:

(ImmutableDictionary):

  • Shared/Network/CustomProtocols/CustomProtocolManager.h:

(CustomProtocolManager):

  • Shared/SecurityOriginData.cpp:

(WebKit::performAPICallbackWithSecurityOriginDataVector):

  • Shared/SessionState.cpp:
  • Shared/StatisticsData.h:

(StatisticsData):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageDecoder::baseDecode):

  • Shared/WebArchive.cpp:

(WebKit::WebArchive::WebArchive):
(WebKit::WebArchive::subresources):
(WebKit::WebArchive::subframeArchives):

  • Shared/WebContextMenuItem.cpp:

(WebKit::WebContextMenuItem::submenuItemsAsImmutableArray):

  • Shared/WebOpenPanelParameters.cpp:

(WebKit::WebOpenPanelParameters::acceptMIMETypes):
(WebKit::WebOpenPanelParameters::selectedFileNames):

  • Shared/mac/ArgumentCodersMac.mm:

(CoreIPC::encode):

  • SharedWorkerProcess/SharedWorkerProcess.h:

(SharedWorkerProcess):

  • UIProcess/API/mac/WKPrintingView.h:

(WebFrameProxy):

  • UIProcess/API/mac/WKPrintingView.mm:

(-[WKPrintingView _drawPreview:]):

  • UIProcess/API/mac/WKView.mm:

(WebKit):

  • UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::processDidClose):

  • UIProcess/Downloads/DownloadProxyMap.h:

(DownloadProxyMap):

  • UIProcess/GeolocationPermissionRequestManagerProxy.h:

(GeolocationPermissionRequestManagerProxy):

  • UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h:

(DynamicLinkerEnvironmentExtractor):

  • UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:

(CustomProtocolManagerProxy):

  • UIProcess/Network/NetworkProcessProxy.h:

(NetworkProcessProxy):

  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.h:

(NotificationPermissionRequestManagerProxy):

  • UIProcess/Notifications/WebNotificationManagerProxy.h:

(WebNotificationManagerProxy):

  • UIProcess/Plugins/PluginProcessManager.h:

(PluginProcessManager):

  • UIProcess/Plugins/PluginProcessProxy.h:

(PluginProcessProxy):

  • UIProcess/Plugins/WebPluginSiteDataManager.cpp:

(WebKit::WebPluginSiteDataManager::didGetSitesWithData):

  • UIProcess/Plugins/WebPluginSiteDataManager.h:

(WebPluginSiteDataManager):

  • UIProcess/SharedWorkers/SharedWorkerProcessManager.h:

(SharedWorkerProcessManager):

  • UIProcess/SharedWorkers/SharedWorkerProcessProxy.h:

(SharedWorkerProcessProxy):

  • UIProcess/StatisticsRequest.cpp:

(WebKit::StatisticsRequest::completedRequest):

  • UIProcess/Storage/StorageManager.cpp:

(StorageManager::StorageArea):
(WebKit::StorageManager::StorageArea::dispatchEvents):
(StorageManager::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::getOrCreateStorageArea):
(WebKit::StorageManager::SessionStorageNamespace::cloneTo):
(WebKit::StorageManager::createLocalStorageMap):
(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::destroyStorageMap):
(WebKit::StorageManager::invalidateConnectionInternal):
(WebKit::StorageManager::findStorageArea):
(WebKit::StorageManager::getOrCreateLocalStorageNamespace):

  • UIProcess/Storage/StorageManager.h:

(StorageManager):

  • UIProcess/WebApplicationCacheManagerProxy.h:

(WebApplicationCacheManagerProxy):

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::clear):

  • UIProcess/WebBackForwardList.h:

(WebKit):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::enableProcessTermination):
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):

  • UIProcess/WebContext.h:

(WebContext):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::didGetHostnamesWithCookies):

  • UIProcess/WebCookieManagerProxy.h:

(WebCookieManagerProxy):

  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):

  • UIProcess/WebDatabaseManagerProxy.h:

(WebDatabaseManagerProxy):

  • UIProcess/WebFormClient.cpp:

(WebKit::WebFormClient::willSubmitForm):

  • UIProcess/WebFormClient.h:

(WebFormClient):

  • UIProcess/WebKeyValueStorageManagerProxy.h:

(WebKeyValueStorageManagerProxy):

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didChangeBackForwardList):

  • UIProcess/WebLoaderClient.h:

(WebLoaderClient):

  • UIProcess/WebMediaCacheManagerProxy.cpp:

(WebKit::WebMediaCacheManagerProxy::didGetHostnamesWithMediaCache):

  • UIProcess/WebMediaCacheManagerProxy.h:

(WebMediaCacheManagerProxy):

  • UIProcess/WebPageContextMenuClient.cpp:

(WebKit::WebPageContextMenuClient::showContextMenu):

  • UIProcess/WebPageProxy.cpp:

(ExceededDatabaseQuotaRecords):
(WebKit::WebPageProxy::relatedPages):
(WebKit::WebPageProxy::didChangeBackForwardList):
(WebKit::WebPageProxy::handleWheelEvent):
(WebKit::WebPageProxy::processNextQueuedWheelEvent):
(WebKit::WebPageProxy::findStringMatches):
(WebKit::WebPageProxy::willSubmitForm):
(WebKit::WebPageProxy::pluginInformationDictionary):
(WebKit::WebPageProxy::didFindStringMatches):
(WebKit::WebPageProxy::didReceiveEvent):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::didClose):
(WebKit::WebProcessProxy::didBecomeUnresponsive):
(WebKit::WebProcessProxy::interactionOccurredWhileUnresponsive):
(WebKit::WebProcessProxy::didBecomeResponsive):
(WebKit::WebProcessProxy::disconnectFramesFromPage):
(WebKit::WebProcessProxy::frameCountInPage):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

  • UIProcess/WebResourceCacheManagerProxy.h:

(WebResourceCacheManagerProxy):

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::populateNSMenu):
(WebKit::nsMenuItemVector):

  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:

(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):

  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):

  • WebProcess/IconDatabase/WebIconDatabaseProxy.h:

(WebIconDatabaseProxy):

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::originsWithApplicationCache):

  • WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp:

(WebKit::InjectedBundleBackForwardListItem::children):

  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange):

  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:

(InjectedBundlePageEditorClient):

  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:

(WebKit::InjectedBundlePageFormClient::willSendSubmitEvent):
(WebKit::InjectedBundlePageFormClient::willSubmitForm):

  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:

(InjectedBundlePageFormClient):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::featuresUsedInPage):

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::internallyFailedLoadTimerFired):
(WebKit::WebResourceLoadScheduler::networkProcessCrashed):

  • WebProcess/Network/WebResourceLoadScheduler.h:

(WebResourceLoadScheduler):

  • WebProcess/Notifications/NotificationPermissionRequestManager.h:

(NotificationPermissionRequestManager):

  • WebProcess/Notifications/WebNotificationManager.h:

(WebNotificationManager):

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::invalidate):

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:

(NPRuntimeObjectMap):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::stopAllStreams):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

(NetscapePlugin):

  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:

(NetscapePluginStream):

  • WebProcess/Plugins/PDF/SimplePDFPlugin.mm:

(getAllScriptsInPDFDocument):
(WebKit::SimplePDFPlugin::runScriptsInPDFDocument):

  • WebProcess/Plugins/PluginProcessConnectionManager.h:

(PluginProcessConnectionManager):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::cancelAllStreams):

  • WebProcess/Plugins/PluginView.h:

(PluginView):

  • WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::dispatchSessionStorageEvent):
(WebKit::StorageAreaMap::dispatchLocalStorageEvent):

  • WebProcess/Storage/StorageNamespaceImpl.cpp:

(WebKit::StorageNamespaceImpl::storageArea):

  • WebProcess/Storage/StorageNamespaceImpl.h:

(StorageNamespaceImpl):

  • WebProcess/Storage/WebKeyValueStorageManager.cpp:

(WebKit::keyValueStorageOriginIdentifiers):

  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp:

(WebKit::WebDatabaseManager::getDatabasesByOrigin):
(WebKit::WebDatabaseManager::getDatabaseOrigins):

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::getClientPasteboardDataForRange):

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):

  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:

(WebKit::WebEditorClient::documentFragmentFromAttributedString):

  • WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::findStringMatches):

  • WebProcess/WebPage/FindController.h:

(FindController):

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::childFrames):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::trackedRepaintRects):

  • WebProcess/WebPage/WebPage.h:

(WebKit):
(WebPage):

  • WebProcess/WebPage/mac/LayerTreeHostMac.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::visitedLinkStateChanged):
(WebKit::WebProcess::allVisitedLinkStateChanged):
(WebKit::WebProcess::focusedWebPage):
(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::didClose):
(WebKit::WebProcess::webPageGroup):
(WebKit::addCaseFoldedCharacters):
(WebKit::getWebCoreMemoryCacheStatistics):
(WebKit::WebProcess::setTextCheckerState):

  • WebProcess/WebProcess.h:

(WebProcess):

3:26 PM Changeset in webkit [149847] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Implement WebPlatformStrategies::transientLocalStorageNamespace
https://bugs.webkit.org/show_bug.cgi?id=115876
<rdar://problem/13852871>

Reviewed by Beth Dakin.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::transientLocalStorageNamespace):
Return a session storage namespace for a random page when UI process storage is enabled,
otherwise call the base class implementation.

3:09 PM Changeset in webkit [149846] by roger_fong@apple.com
  • 1 edit
    2 adds
    1 delete in trunk/LayoutTests

Unreviewed mac gardening.

  • platform/mac/inspector/command-line-api-expected.txt: Removed.
  • platform/mac/inspector/console: Added.
  • platform/mac/inspector/console/command-line-api-expected.txt: Added.
2:47 PM Changeset in webkit [149845] by Christophe Dumez
  • 17 edits in trunk

[NoInterfaceObject] extended attribute should be removed for several interfaces
https://bugs.webkit.org/show_bug.cgi?id=115852

Reviewed by Benjamin Poulain.

Source/WebCore:

Remove [NoInterfaceObject] extended attribute from the following Web IDL
interfaces: SecurityPolicy, History, Location, Navigator, Performance,
PerformanceEntry, PerformanceMark, PerformanceMeasure, PerformanceNavigation,
PerformanceResourceTiming, PerformanceTiming and Screen.

These interfaces should not have the [NoInterfaceObject] extended attribute
according to their respective specifications:

The new behavior is consistent with the specifications, Firefox and soon Blink.

No new tests, already covered by existing tests.

  • page/DOMSecurityPolicy.idl:
  • page/History.idl:
  • page/Location.idl:
  • page/Navigator.idl:
  • page/Performance.idl:
  • page/PerformanceEntry.idl:
  • page/PerformanceMark.idl:
  • page/PerformanceMeasure.idl:
  • page/PerformanceNavigation.idl:
  • page/PerformanceResourceTiming.idl:
  • page/PerformanceTiming.idl:
  • page/Screen.idl:

LayoutTests:

Rebaseline several layout tests whose output has changed now that a few more
global constructors are exposed.

  • fast/dom/dom-constructors-expected.txt:
  • fast/js/global-constructors-attributes-expected.txt:
  • platform/efl/fast/js/global-constructors-attributes-expected.txt:
2:45 PM Changeset in webkit [149844] by robert@webkit.org
  • 4 edits
    1 move
    3 deletes in trunk

REGRESSION (Safari 3-Safari 4): Replaced element with percent height in table has incorrect height
https://bugs.webkit.org/show_bug.cgi?id=26394

Reviewed by David Hyatt.

Source/WebCore:

Text controls or any object that has scrollable content should not flex inside a table cell.
This makes our behaviour the same as IE, FF and Opera (Presto).

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):

LayoutTests:

  • fast/replaced/table-percent-height-text-controls-expected.txt: Renamed from LayoutTests/platform/mac/fast/replaced/table-percent-height-text-controls-expected.txt.
  • fast/replaced/table-percent-height-text-controls.html:
  • platform/gtk/fast/replaced/table-percent-height-text-controls-expected.txt: Removed.
  • platform/qt/fast/replaced/table-percent-height-text-controls-expected.txt: Removed.
  • platform/win/fast/replaced/table-percent-height-text-controls-expected.txt: Removed.
2:35 PM Changeset in webkit [149843] by Patrick Gansterer
  • 2 edits
    1 move in trunk/Tools

[DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
https://bugs.webkit.org/show_bug.cgi?id=92505

Reviewed by Brent Fulgham.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.

(javaScriptThreadsMutex):
(javaScriptThreads):
(runJavaScriptThread):
(startJavaScriptThreads):
(stopJavaScriptThreads):

  • DumpRenderTree/pthreads: Removed.
  • DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
2:34 PM Changeset in webkit [149842] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • WebCore.exp.in:
2:18 PM Changeset in webkit [149841] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Update srcipt paths in editing/shadow/rightclick-on-meter-in-shadow-crash.html
https://bugs.webkit.org/show_bug.cgi?id=96223

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-05-09
Reviewed by Rob Buis.

The original paths don't exist at all.

  • editing/shadow/rightclick-on-meter-in-shadow-crash.html:
2:03 PM Changeset in webkit [149840] by andersca@apple.com
  • 14 edits in trunk/Source/WebCore

Add a StorageStrategy hook for creating transient local storage namespaces
https://bugs.webkit.org/show_bug.cgi?id=115870

Reviewed by Geoffrey Garen.

  • WebCore.exp.in:

Export symbol needed by WebKit2.

  • dom/Document.cpp:

(WebCore::Document::topOrigin):

  • dom/Document.h:
  • dom/ScriptExecutionContext.h:
  • workers/WorkerContext.h:

Remove const qualifier from topOrigin() to avoid ugly const_casts when assigning into a RefPtr<SecurityOrigin> variable.

  • page/PageGroup.cpp:

(WebCore::PageGroup::transientLocalStorage):
Do a single hash lookup instead of three and use the SecurityOrigin itself as the hash key instead of a string representation of it.

  • page/PageGroup.h:

Update HashMap declaration.

  • storage/StorageNamespace.cpp:

(WebCore::StorageNamespace::transientLocalStorageNamespace):
Add new implementation that will optionally call out to the storage strategy.

  • storage/StorageNamespaceImpl.cpp:

(WebCore::StorageNamespaceImpl::transientLocalStorageNamespace):
Move the default implementation here from PageGroup.

  • storage/StorageStrategy.cpp:

(WebCore::StorageStrategy::transientLocalStorageNamespace):
Call the default implementation.

1:54 PM Changeset in webkit [149839] by enrica@apple.com
  • 4 edits in trunk/Source/WebCore

A change in system environment should force all CSS properties to be recomputed.
https://bugs.webkit.org/show_bug.cgi?id=115872
<rdar://problem/13781171>

Reviewed by Antti Koivisto.

When a change in the global environment occurs, for example system colors,
we need to make sure all the CSS properties are recomputed and not fetched
from the cache. For this reason we invalidate the properties cache.
I've also renamed the function to give it a more meaningful name.

  • page/Page.cpp:

(WebCore::Page::updateStyleForAllPagesAfterGlobalChangeInEnvironment):

  • page/Page.h:
  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::platformColorsDidChange):

1:35 PM Changeset in webkit [149838] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Reoptimize free-standing :focus/link/visited/-webkit-any-link selectors.
<http://webkit.org/b/115590>

Reviewed by Darin Adler.

Common pseudo selectors should go into their respective rule buckets instead of ending up in the universal one.

  • css/RuleSet.cpp:

(WebCore::RuleSet::findBestRuleSetAndAdd):

Check tag selectors with * local name (usually created for namespace) for a suitable narrower bucket too.

1:31 PM Changeset in webkit [149837] by roger_fong@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed mac port gardening.

  • platform/mac-lion/fast/js: Added.
  • platform/mac-lion/fast/js/global-constructors-attributes-expected.txt: Added.
  • platform/mac/inspector/command-line-api-expected.txt: Added.
1:03 PM Changeset in webkit [149836] by oliver@apple.com
  • 17 edits
    3 adds in trunk

Code cache stores bogus var references for functions in eval code
https://bugs.webkit.org/show_bug.cgi?id=115747

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

Non-global eval now uses a per-CodeBlock cache, and only use it
when we're at the top of a function's scope. This means that we
will no longer cache the parsing of a single string across
multiple functions, and we won't cache when we're nested inside
constructs like |with| and |catch| where previously we would, which
is good because caching in those cases is unsound.

  • bytecode/EvalCodeCache.h:

(JSC):
(JSC::EvalCodeCache::getSlow):
(JSC::EvalCodeCache::get):

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::codeCacheForEval):
(UnlinkedCodeBlock):
(RareData):

  • debugger/Debugger.cpp:

(JSC::evaluateInGlobalCallFrame):

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluate):

  • interpreter/Interpreter.cpp:

(JSC::eval):

  • runtime/CodeCache.cpp:

(JSC::CodeCache::CodeCache):
(JSC::CodeCache::generateBytecode):
(JSC):
(JSC::CodeCache::getCodeBlock):

  • runtime/CodeCache.h:

(JSC::CodeCacheMap::CodeCacheMap):
(CodeCacheMap):
(JSC::CodeCacheMap::canPruneQuickly):
(JSC::CodeCacheMap::prune):
(JSC::CodeCache::create):
(CodeCache):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::EvalExecutable):
(JSC::EvalExecutable::compileInternal):

  • runtime/Executable.h:

(JSC::EvalExecutable::create):
(EvalExecutable):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::createEvalCodeBlock):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

(VM):

LayoutTests:

Many tests

  • fast/js/eval-cache-scoped-lookup-expected.txt: Added.
  • fast/js/eval-cache-scoped-lookup.html: Added.
  • fast/js/script-tests/eval-cache-scoped-lookup.js: Added.

(first):
(a.string_appeared_here.second):
(third):
(fifth):
(sixth):
(seventh):
(eighth):
(nineth):
(tenth):
(eleventh):

12:41 PM Changeset in webkit [149835] by mhahnenberg@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Fixing botched rebase of ChangeLog

12:38 PM Changeset in webkit [149834] by mhahnenberg@apple.com
  • 4 edits
    3 adds in trunk

DFGArrayMode::fromObserved is too liberal when it sees different Array and NonArray shapes
https://bugs.webkit.org/show_bug.cgi?id=115805

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

It checks the observed ArrayModes to see if we have seen any ArrayWith* first. If so, it assumes it's
an Array::Array, even if we've also observed any NonArrayWith* in the ArrayProfile. This leads to the
code generated by jumpSlowForUnwantedArrayMode to check the indexing type against (shape | IsArray)
instead of just shape, which can cause us to exit a lot in the case that we saw a NonArray.

To fix this we need to add a case that checks for both ArrayWith* and NonArrayWith* cases first, which
should then use Array::PossiblyArray, then do the checks we were already doing.

  • bytecode/ArrayProfile.h:

(JSC::hasSeenArray):
(JSC::hasSeenNonArray):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::fromObserved):

LayoutTests:

Added regression test for array access over polymorphic array vs. non-array indexing types.
With the fix, we get 3.666x faster on this microbenchmark.

Reviewed by Geoffrey Garen.

  • fast/js/regress/array-nonarray-polymorphic-access-expected.txt: Added.
  • fast/js/regress/array-nonarray-polymorphic-access.html: Added.
  • fast/js/regress/script-tests/array-nonarray-polymorphic-access.js: Added.

(f):
(run):

12:24 PM Changeset in webkit [149833] by Darin Adler
  • 7 edits in trunk/Source

RenderQuote has giant function for language to quotes map
https://bugs.webkit.org/show_bug.cgi?id=115807

Reviewed by Anders Carlsson.

Source/WebCore:

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::RenderQuote): Updated for m_isAttached name change.
(WebCore::RenderQuote::~RenderQuote): Updated for name change, and also split
assertion with && in it into two separate assertions.
(WebCore::checkNumberOfDistinctQuoteCharacters): Added. Helper function that is used
to check that the number of distinct quote characters is small enough to fit into
our fixed size array below.
(WebCore::quotesForLanguage): Replaces the old quotesDataLanguageMap function.
Returns a pointer to a struct that contains the four quote characters. This new
function doesn't have the massive amount of code that the old one did. We use the
standard library bsearch function to do a binary search.
(WebCore::stringForQuoteCharacter): Added. This returns a string for a given quote
character; one string for any given character.
(WebCore::quotationMarkString): Added. Returns the string for the quotation mark.
(WebCore::apostropheStringImpl): Added. Returns the string for the apostrophe.
(WebCore::RenderQuote::originalText): Rewrote this to include all the logic that
used to be in the quotesData function.
(WebCore::RenderQuote::attachQuote): Tweak assertions as above. Removed unneeded
special case for the first quote in a RenderView; sharing the code is better and
there is no significant performance difference. Also use m_isAttached directly
when looking at predecessores so there is no need for an isAttached function.
(WebCore::RenderQuote::detachQuote): Updated assertions and for name change.
(WebCore::RenderQuote::updateDepth): Ditto.

  • rendering/RenderQuote.h: Removed unneeded includes. Marked the class FINAL since

we call the originalText function in the class and we don't want to do a virtual
function dispatch for that. Removed uneeded const from an argument. Removed a
stray semicolon. Removed the quotesData and isAttached functions, since they are no
longer needed. Renamed m_attached to m_isAttached.

  • rendering/style/QuotesData.cpp: Removed the overload of QuotesData::create that

takes four quote strings. This was only used to build up the quotes table.

  • rendering/style/QuotesData.h: Ditto.

Source/WTF:

  • wtf/unicode/CharacterNames.h: Added a couple of character names.
12:03 PM Changeset in webkit [149832] by andersca@apple.com
  • 15 edits in trunk/Source/WebKit2

Use explicit qualifiers for names in the std:: namespace
https://bugs.webkit.org/show_bug.cgi?id=115868

Reviewed by Andreas Kling.

  • Shared/mac/ArgumentCodersMac.mm:

(CoreIPC::encode):

  • UIProcess/API/C/WKPluginSiteDataManager.cpp:

(WKPluginSiteDataManagerClearAllSiteData):

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::findPluginForExtension):

  • UIProcess/WebFrameProxy.cpp:
  • UIProcess/WebProcessProxy.cpp:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::parsePostBuffer):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::loadURL):

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::deliverDataToPlugin):

  • WebProcess/Plugins/PDF/SimplePDFPlugin.mm:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:
  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::countStringMatches):
(WebKit::FindController::updateFindUIAfterPageScroll):

  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::drawPDFPage):

  • WebProcess/mac/WebProcessMac.mm:
12:00 PM Changeset in webkit [149831] by mifenton@rim.com
  • 8 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update iInRegionScroller, WebKitTextCodec and WebPageCompositor
to match check-webkit-style updates.

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):

  • Api/InRegionScroller_p.h:
  • Api/WebKitTextCodec.cpp:

(BlackBerry::WebKit::transcode):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositor::render):

  • Api/WebPageCompositor.h:
  • Api/WebPageCompositor_p.h:

(WebPageCompositorPrivate):

  • Api/WebSettings_p.h:
11:49 AM Changeset in webkit [149830] by commit-queue@webkit.org
  • 14 edits
    3 adds in trunk

shouldUsePluginDocument() needs to be respected when a document is created
https://bugs.webkit.org/show_bug.cgi?id=110308

Patch by Max Feil <mfeil@rim.com> on 2013-05-09
Reviewed by Rob Buis.

Source/WebCore:

In DOMImplementation::createDocument() we should create
a PluginDocument for mime types that return "true" for
shouldAlwaysUsePluginDocument(), even if there is no pluginData
for them. This lets a client choose plugins for which the "missing
plugin" text or icon should appear more consistently. Otherwise
plugins referenced by iFrames will be treated as an HTMLDocument,
possibly resulting in binary files rendered as gibberish text.

Layout test platform/blackberry/plugins/swf-as-src-of-iframe.html

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

Source/WebKit/blackberry:

This patch implements shouldAlwaysUsePluginDocument() in the
BlackBerry frame loader client. It is called in several places
within WebCore to determine whether a PluginDocument should
be created.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::shouldAlwaysUsePluginDocument):
(WebCore):
(WebCore::FrameLoaderClientBlackBerry::createPlugin):

  • WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

Source/WebKit/win:

Renaming shouldUsePluginDocument() to shouldAlwaysUsePluginDocument()
for clarity.

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::shouldAlwaysUsePluginDocument):

  • WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

Source/WebKit2:

Renaming shouldUsePluginDocument() to shouldAlwaysUsePluginDocument()
for clarity.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::shouldAlwaysUsePluginDocument):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

11:47 AM Changeset in webkit [149829] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Fix an exception when hovering native functions while paused in the debugger.

https://webkit.org/b/115866
rdar://problem/13681982

Reviewed by Darin Adler and Joseph Pecoraro.

  • inspector/InjectedScriptSource.js:

(InjectedScript.prototype.getFunctionDetails): Return an error if the details
is null or undefined.

11:42 AM Changeset in webkit [149828] by Darin Adler
  • 2 edits in trunk/Source/WebCore

[Mac] CFError leak under Objective-C garbage collection
https://bugs.webkit.org/show_bug.cgi?id=115862

Reviewed by Benjamin Poulain.

  • platform/network/mac/ResourceErrorMac.mm:

(WebCore::ResourceError::nsError): Use adoptCF instead of adoptNS since
the CFError needs a CFRelease, not an -[NSObject release].

11:38 AM Changeset in webkit [149827] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

BlackBerry: fix call to PluginLayerWebKitThread::setHolePunchRect()
https://bugs.webkit.org/show_bug.cgi?id=114953

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-09
Reviewed by Rob Buis.

data->layer needs a cast in order to call setHolePunchRect().

  • plugins/blackberry/NPCallbacksBlackBerry.cpp:

(WebCore::npSetHolePunchHandler):

11:32 AM Changeset in webkit [149826] by mifenton@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update SelectionHandler to match check-webkit-style updates.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::shouldExtendSelectionInDirection):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::adjustCaretRects):
(BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
(BlackBerry::WebKit::regionRectListContainsPoint):

  • WebKitSupport/SelectionHandler.h:

(SelectionHandler):

11:24 AM Changeset in webkit [149825] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[BlackBerry] Set up logging buffer on start of jsc executable
https://bugs.webkit.org/show_bug.cgi?id=114688

Patch by Joe Mason <jmason@blackberry.com> on 2013-05-09
Reviewed by Rob Buis.

Internal PR: 322715
Internally Reviewed By: Jeff Rogers

  • jsc.cpp:

(main): call BB::Platform::setupApplicationLogging

11:13 AM Changeset in webkit [149824] by mifenton@rim.com
  • 11 edits in trunk/Source/WebCore

[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update WebCore/platform/graphics BlackBerry sources
to match check-webkit-style updates.

Internally reviewed by Jakob Petsovits.

  • platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
  • platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::readPixelsIMG):
(WebCore::GraphicsContext3D::paintToCanvas):

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore::GraphicsLayerBlackBerry::updateLayerPosition):

  • platform/graphics/blackberry/IntRectBlackBerry.cpp:

(WebCore::IntRect::IntRect):

  • platform/graphics/blackberry/LayerCompositingThread.h:

(WTF::::deref):

  • platform/graphics/blackberry/LayerFilterRenderer.cpp:

(WebCore::LayerFilterRenderer::initializeSharedGLObjects):
(WebCore::LayerFilterRenderer::actionsForOperations):
(WebCore::LayerFilterRenderer::applyActions):

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::setViewport):
(WebCore::LayerRenderer::compositeBuffer):
(WebCore::LayerRenderer::drawColor):
(WebCore::LayerRenderer::compositeLayersRecursive):

  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::setFrame):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):

  • platform/image-decoders/blackberry/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::JPEGImageDecoder):

11:02 AM Changeset in webkit [149823] by mifenton@rim.com
  • 5 edits in trunk/Source/WebCore

[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update WebCore/platform/network/blackberry
to match check-webkit-style updates.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::initialize):
(WebCore::NetworkJob::handleSetCookieHeader):
(WebCore::NetworkJob::sendResponseIfNeeded):
(WebCore::NetworkJob::shouldSendClientData):

  • platform/network/blackberry/NetworkJob.h:

(NetworkJob):

  • platform/network/blackberry/NetworkManager.cpp:

(WebCore::NetworkManager::startJob):

  • platform/network/blackberry/rss/RSSFilterStream.cpp:

(WebCore::isRSSContent):
(WebCore::transcode):

10:59 AM Changeset in webkit [149822] by mifenton@rim.com
  • 11 edits in trunk/Source/WebCore

[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update WebCore/platform/blackberry to match check-webkit-style updates.

No functional changes.

  • platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:
  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::getRawCookies):

  • platform/blackberry/CookieMap.h:

(WebCore::CookieMap::count):

  • platform/blackberry/CookieParser.cpp:

(WebCore::CookieParser::parseOneCookie):

  • platform/blackberry/LoggingBlackBerry.cpp:
  • platform/blackberry/PageClientBlackBerry.h:

(Platform):
(Graphics):
(WebCore):

  • platform/blackberry/ParsedCookie.cpp:

(WebCore::ParsedCookie::appendWebCoreCookie):

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintSearchFieldCancelButton):
(WebCore::RenderThemeBlackBerry::paintButton):
(WebCore::RenderThemeBlackBerry::paintSliderThumb):

  • platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:

(WebCore::signedPublicKeyAndChallengeString):

  • platform/blackberry/ScrollAnimatorBlackBerry.h:
10:40 AM Changeset in webkit [149821] by msaboff@apple.com
  • 4 edits
    4 adds in trunk/Source

JSC: There should be a disassembler for ARM Thumb 2
https://bugs.webkit.org/show_bug.cgi?id=115827

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Added a new disassembler for ARMv7 Thumb2 instructions for use by the JSC debugging
and profiling code. The opcode coverage is currently not complete. It covers all
of the integer instructions JSC currently emits, but only a limited number of
floating point opcodes. Currently that is just the 64 bit vmov and vmsr instructions.

The disassembler is structured as a base opcode class ARMv7DOpcode with sub-classes
for each instruction group. There is a public format method that does the bulk of
the disassembly work. There are two broad sub-classes, ARMv7D16BitOpcode and
ARMv7D32BitOpcode, for the 16 bit and 32 bit opcodes. There are sub-classes under
those two classes for individual and related groups of opcodes. Instructions are
"dispatched" to the right subclass via two arrays of linked lists in the inner classes
OpcodeGroup. There is one such inner class for each ARMv7D16BitOpcode and ARMv7D32BitOpcode.
Each OpcodeGroup has a mask and a pattern that it applies to the instruction to determine
that it matches a particular group. OpcodeGroup uses a static method to reinterpret_cast
the Opcode object to the right base class for the instruction group for formatting.
The cast eliminates the need of allocating an object for each decoded instruction.
Unknown instructions are formatted as ".word 1234" or ".long 12345678" depending whether
the instruction is 16 or 32 bit.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • disassembler/ARMv7: Added.
  • disassembler/ARMv7/ARMv7DOpcode.cpp: Added.

(ARMv7Disassembler):
(OpcodeGroupInitializer):
(JSC::ARMv7Disassembler::ARMv7DOpcode::init):
(JSC::ARMv7Disassembler::ARMv7DOpcode::startITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::saveITConditionAt):
(JSC::ARMv7Disassembler::ARMv7DOpcode::fetchOpcode):
(JSC::ARMv7Disassembler::ARMv7DOpcode::disassemble):
(JSC::ARMv7Disassembler::ARMv7DOpcode::bufferPrintf):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendInstructionName):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendRegisterName):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendRegisterList):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendFPRegisterName):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::init):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::doDisassemble):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::defaultFormat):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddRegisterT2::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSPPlusImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchConditionalT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchExchangeT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchT2::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareImmediateT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT2::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeGeneratePCRelativeAddress::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadFromLiteralPool::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLogicalImmediateT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscAddSubSP::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscBreakpointT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscByteHalfwordOps::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscHint16::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscIfThenT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscPushPop::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveImmediateT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveRegisterT1::format):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::init):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::doDisassemble):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::defaultFormat):
(JSC::ARMv7Disassembler::ARMv7DOpcodeConditionalBranchT3::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchOrBranchLink::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::appendModifiedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::appendImmShift):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::appendFPRegister):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegShift::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegExtend::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegParallel::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegMisc::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadRegister::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadUnsignedImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataPushPopSingle::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate12::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleRegister::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMSR::format):

  • disassembler/ARMv7/ARMv7DOpcode.h: Added.

(ARMv7Disassembler):
(ARMv7DOpcode):
(JSC::ARMv7Disassembler::ARMv7DOpcode::ARMv7DOpcode):
(JSC::ARMv7Disassembler::ARMv7DOpcode::is32BitInstruction):
(JSC::ARMv7Disassembler::ARMv7DOpcode::isFPInstruction):
(JSC::ARMv7Disassembler::ARMv7DOpcode::conditionName):
(JSC::ARMv7Disassembler::ARMv7DOpcode::shiftName):
(JSC::ARMv7Disassembler::ARMv7DOpcode::inITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::startingITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::endITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendInstructionNameNoITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendSeparator):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendCharacter):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendString):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendShiftType):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendSignedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendUnsignedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendPCRelativeOffset):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendShiftAmount):
(ARMv7D16BitOpcode):
(OpcodeGroup):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::OpcodeGroup):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::setNext):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::next):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::matches):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::format):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::rm):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::rd):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::opcodeGroupNumber):
(ARMv7DOpcodeAddRegisterT2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddRegisterT2::rdn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddRegisterT2::rm):
(ARMv7DOpcodeAddSPPlusImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSPPlusImmediate::rd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSPPlusImmediate::immediate8):
(ARMv7DOpcodeAddSubtract):
(ARMv7DOpcodeAddSubtractT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::rm):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::rn):
(ARMv7DOpcodeAddSubtractImmediate3):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::immediate3):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::rn):
(ARMv7DOpcodeAddSubtractImmediate8):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::rdn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::immediate8):
(ARMv7DOpcodeBranchConditionalT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchConditionalT1::condition):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchConditionalT1::offset):
(ARMv7DOpcodeBranchExchangeT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchExchangeT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchExchangeT1::rm):
(ARMv7DOpcodeBranchT2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchT2::immediate11):
(ARMv7DOpcodeCompareImmediateT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareImmediateT1::rn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareImmediateT1::immediate8):
(ARMv7DOpcodeCompareRegisterT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT1::rn):
(ARMv7DOpcodeCompareRegisterT2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT2::rn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT2::rm):
(ARMv7DOpcodeDataProcessingRegisterT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::rm):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::rdn):
(ARMv7DOpcodeGeneratePCRelativeAddress):
(JSC::ARMv7Disassembler::ARMv7DOpcodeGeneratePCRelativeAddress::rd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeGeneratePCRelativeAddress::immediate8):
(ARMv7DOpcodeLoadFromLiteralPool):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadFromLiteralPool::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadFromLiteralPool::immediate8):
(ARMv7DOpcodeLoadStoreRegisterImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::immediate5):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::rn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::scale):
(ARMv7DOpcodeLoadStoreRegisterImmediateWordAndByte):
(ARMv7DOpcodeLoadStoreRegisterImmediateHalfWord):
(ARMv7DOpcodeLoadStoreRegisterOffsetT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::opB):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::rm):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::rn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::rt):
(ARMv7DOpcodeLoadStoreRegisterSPRelative):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::immediate8):
(ARMv7DOpcodeLogicalImmediateT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLogicalImmediateT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLogicalImmediateT1::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLogicalImmediateT1::immediate5):
(ARMv7DOpcodeMiscAddSubSP):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscAddSubSP::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscAddSubSP::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscAddSubSP::immediate7):
(ARMv7DOpcodeMiscByteHalfwordOps):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscByteHalfwordOps::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscByteHalfwordOps::op):
(ARMv7DOpcodeMiscBreakpointT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscBreakpointT1::immediate8):
(ARMv7DOpcodeMiscCompareAndBranch):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::immediate6):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::rn):
(ARMv7DOpcodeMiscHint16):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscHint16::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscHint16::opA):
(ARMv7DOpcodeMiscIfThenT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscIfThenT1::firstCondition):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscIfThenT1::mask):
(ARMv7DOpcodeMiscPushPop):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscPushPop::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscPushPop::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscPushPop::registerMask):
(ARMv7DOpcodeMoveImmediateT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveImmediateT1::rd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveImmediateT1::immediate8):
(ARMv7DOpcodeMoveRegisterT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveRegisterT1::rd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveRegisterT1::rm):
(ARMv7D32BitOpcode):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::OpcodeGroup):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::setNext):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::next):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::matches):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::format):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::rd):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::rm):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::rn):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::rt):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::opcodeGroupNumber):
(ARMv7DOpcodeBranchRelative):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchRelative::sBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchRelative::j1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchRelative::j2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchRelative::immediate11):
(ARMv7DOpcodeConditionalBranchT3):
(JSC::ARMv7Disassembler::ARMv7DOpcodeConditionalBranchT3::offset):
(JSC::ARMv7Disassembler::ARMv7DOpcodeConditionalBranchT3::condition):
(JSC::ARMv7Disassembler::ARMv7DOpcodeConditionalBranchT3::immediate6):
(ARMv7DOpcodeBranchOrBranchLink):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchOrBranchLink::offset):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchOrBranchLink::immediate10):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchOrBranchLink::isBL):
(ARMv7DOpcodeDataProcessingLogicalAndRithmetic):
(ARMv7DOpcodeDataProcessingModifiedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::sBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::immediate12):
(ARMv7DOpcodeDataProcessingShiftedReg):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::sBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::immediate5):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::type):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::tbBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::tBit):
(ARMv7DOpcodeDataProcessingReg):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingReg::op1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingReg::op2):
(ARMv7DOpcodeDataProcessingRegShift):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegShift::opName):
(ARMv7DOpcodeDataProcessingRegExtend):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegExtend::opExtendName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegExtend::opExtendAndAddName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegExtend::rotate):
(ARMv7DOpcodeDataProcessingRegParallel):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegParallel::opName):
(ARMv7DOpcodeDataProcessingRegMisc):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegMisc::opName):
(ARMv7DOpcodeHint32):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::isDebugHint):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::debugOption):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::op):
(ARMv7DOpcodeFPTransfer):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::opH):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::opL):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::opC):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::opB):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::vd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::vn):
(ARMv7DOpcodeDataLoad):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataLoad::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataLoad::op):
(ARMv7DOpcodeLoadRegister):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadRegister::immediate2):
(ARMv7DOpcodeLoadSignedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::pBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::uBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::wBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::immediate8):
(ARMv7DOpcodeLoadUnsignedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadUnsignedImmediate::immediate12):
(ARMv7DOpcodeLongMultipleDivide):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::smlalOpName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::smlaldOpName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::smlsldOpName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::rdLo):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::rdHi):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::op1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::op2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::nBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::mBit):
(ARMv7DOpcodeDataPushPopSingle):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataPushPopSingle::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataPushPopSingle::op):
(ARMv7DOpcodeDataStoreSingle):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataStoreSingle::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataStoreSingle::op):
(ARMv7DOpcodeStoreSingleImmediate12):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate12::immediate12):
(ARMv7DOpcodeStoreSingleImmediate8):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::pBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::uBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::wBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::immediate8):
(ARMv7DOpcodeStoreSingleRegister):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleRegister::immediate2):
(ARMv7DOpcodeUnmodifiedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::shBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::bitNumOrSatImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::immediate5):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::immediate12):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::immediate16):
(ARMv7DOpcodeVMOVDoublePrecision):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::rt2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::vm):
(ARMv7DOpcodeVMOVSinglePrecision):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::rt2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::vm):
(ARMv7DOpcodeVMSR):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMSR::opL):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMSR::rt):

  • disassembler/ARMv7Disassembler.cpp: Added.

(JSC::tryToDisassemble):

Source/WTF:

Added a new disassembler for ARMv7 Thumb2 instructions for use by the JSC debugging
and profiling code. Enabled the disassembler for IOS bulds.

  • wtf/Platform.h:
9:54 AM Changeset in webkit [149820] by mifenton@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update WebPage and WebPageClient to match check-webkit-style updates.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::executeJavaScriptInIsolatedWorld):
(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::calculateReflowedScrollPosition):
(BlackBerry::WebKit::WebPagePrivate::centerOfVisibleContentsRect):
(BlackBerry::WebKit::WebPage::assignFocus):
(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPage::deleteTextRelativeToCursor):
(BlackBerry::WebKit::WebPage::addVisitedLink):
(BlackBerry::WebKit::WebPagePrivate::findPatternStringForUrl):
(BlackBerry::WebKit::WebPage::notifySwipeEvent):
(BlackBerry::WebKit::WebPage::notifyScreenPowerStateChanged):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::setRootLayerWebKitThread):
(BlackBerry::WebKit::WebPagePrivate::releaseLayerResourcesCompositingThread):

  • Api/WebPageClient.h:
  • Api/WebPage_p.h:
9:51 AM Changeset in webkit [149819] by mifenton@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update BackingStore to match check-webkit-style updates.

Internally reviewed by Jakob Petsovits.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::bestDivisor):
(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveLeft):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveRight):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveUp):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveDown):
(BlackBerry::WebKit::BackingStorePrivate::canMoveLeft):
(BlackBerry::WebKit::BackingStorePrivate::canMoveRight):
(BlackBerry::WebKit::BackingStorePrivate::canMoveUp):
(BlackBerry::WebKit::BackingStorePrivate::canMoveDown):
(BlackBerry::WebKit::BackingStorePrivate::indexOfTile):
(BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
(BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
(BlackBerry::WebKit::BackingStoreGeometry::originOfTile):
(BlackBerry::WebKit::BackingStore::repaint):

  • Api/BackingStore_p.h:

(BackingStoreGeometry):

9:36 AM WebKit Team edited by simon.pena@samsung.com
Adding myself (diff)
9:16 AM Changeset in webkit [149818] by mifenton@rim.com
  • 8 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update ChromeClientBlackBerry, CredentialManager, FrameLoaderClientBlackBerry,
GeolocationClientBlackBerry and IconDatabaseClientBlackberry to
match check-webkit-style updates.

  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

  • WebCoreSupport/CredentialManager.h:

(CredentialManager):

  • WebCoreSupport/CredentialTransformData.cpp:
  • WebCoreSupport/FrameLoaderClientBlackBerry.h:

(WebCore::FrameLoaderClientBlackBerry::assignIdentifierToInitialRequest):
(FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveAuthenticationChallenge):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidCancelAuthenticationChallenge):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveContentLength):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoading):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailLoading):

  • WebCoreSupport/GeolocationClientBlackBerry.cpp:

(GeolocationClientBlackBerry::onLocationUpdate):

  • WebCoreSupport/GeolocationClientBlackBerry.h:

(GeolocationClientBlackBerry):

  • WebCoreSupport/IconDatabaseClientBlackBerry.cpp:

(WebCore::IconDatabaseClientBlackBerry::initIconDatabase):

9:13 AM Changeset in webkit [149817] by crogers@google.com
  • 29 edits in trunk/Source/WebCore

Require use of AudioBus::create() to avoid ref-counting issues
https://bugs.webkit.org/show_bug.cgi?id=115836

Reviewed by Andreas Kling.

There were a couple of places still embedding raw AudioBus objects as
member variables or local variables causing ref-counting problems
now that AudioBus is ref-counted. Make AudioBus constructor private
to enforce use of AudioBus::create().

Adapted from Blink patch:
https://chromiumcodereview.appspot.com/14628008/

  • Modules/webaudio/AudioDestinationNode.h:

(WebCore::AudioDestinationNode::LocalAudioInputProvider::LocalAudioInputProvider):
(WebCore::AudioDestinationNode::LocalAudioInputProvider::set):
(WebCore::AudioDestinationNode::LocalAudioInputProvider::provideInput):
(LocalAudioInputProvider):

  • Modules/webaudio/AudioNodeInput.cpp:

(WebCore::AudioNodeInput::AudioNodeInput):
(WebCore::AudioNodeInput::updateInternalBus):

  • Modules/webaudio/AudioNodeOutput.cpp:

(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::updateInternalBus):

  • Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::calculateFinalValues):

  • Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::setBuffer):

  • Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
(WebCore::MediaStreamAudioDestinationNode::process):

  • Modules/webaudio/MediaStreamAudioDestinationNode.h:
  • Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):

  • Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::ScriptProcessorNode):
(WebCore::ScriptProcessorNode::process):

  • Modules/webaudio/ScriptProcessorNode.h:

(ScriptProcessorNode):

  • platform/audio/AudioBus.cpp:

(WebCore::AudioBus::create):
(WebCore):
(WebCore::AudioBus::AudioBus):
(WebCore::AudioBus::createBufferFromRange):
(WebCore::AudioBus::createBySampleRateConverting):
(WebCore::AudioBus::createByMixingToMono):

  • platform/audio/AudioBus.h:

(AudioBus):

  • platform/audio/AudioFIFO.cpp:

(WebCore::AudioFIFO::AudioFIFO):
(WebCore::AudioFIFO::consume):
(WebCore::AudioFIFO::push):

  • platform/audio/AudioFIFO.h:

(AudioFIFO):

  • platform/audio/AudioPullFIFO.cpp:

(WebCore::AudioPullFIFO::AudioPullFIFO):
(WebCore::AudioPullFIFO::fillBuffer):

  • platform/audio/AudioPullFIFO.h:

(AudioPullFIFO):

  • platform/audio/AudioResampler.cpp:

(WebCore::AudioResampler::AudioResampler):
(WebCore::AudioResampler::configureChannels):

  • platform/audio/MultiChannelResampler.cpp:
  • platform/audio/Reverb.cpp:

(WebCore::Reverb::initialize):

  • platform/audio/SincResampler.cpp:

(WebCore::SincResampler::consumeSource):
(WebCore):

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):

  • platform/audio/gstreamer/AudioDestinationGStreamer.h:

(AudioDestinationGStreamer):

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::createBus):

  • platform/audio/ios/AudioDestinationIOS.cpp:

(WebCore::AudioDestinationIOS::AudioDestinationIOS):
(WebCore::AudioDestinationIOS::render):

  • platform/audio/ios/AudioDestinationIOS.h:

(AudioDestinationIOS):

  • platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestinationMac::AudioDestinationMac):
(WebCore::AudioDestinationMac::render):

  • platform/audio/mac/AudioDestinationMac.h:

(AudioDestinationMac):

  • platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::createBus):

9:09 AM Changeset in webkit [149816] by zhajiang@rim.com
  • 5 edits in trunk/Source/WebKit/blackberry

Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790

Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-05-09.
Reviewed by Rob Buis.

Fix the following warnings for BlackBerry:
InRegionScroller.cpp:286:39: warning: suggest parentheses around
assignment used as truth value [-Wparentheses].
InRegionScroller.cpp:349:39: warning: suggest parentheses around
assignment used as truth value [-Wparentheses].
InRegionScroller.cpp:456:82: warning: suggest parentheses around '&&'

within '
' [-Wparentheses].

InRegionScrollableArea.cpp:134:16: warning: suggest explicit braces to
avoid ambiguous 'else' [-Wparentheses].
SelectionHandler.cpp:390:109: warning: suggest parentheses around '&&'

within '
' [-Wparentheses].

SelectionOverlay.cpp:56:47: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare].

  • Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
(BlackBerry::WebKit::InRegionScrollerPrivate::firstScrollableInRegionForNode):
(BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):

  • WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):

  • WebKitSupport/SelectionOverlay.cpp:

(BlackBerry::WebKit::SelectionOverlay::draw):

9:02 AM Changeset in webkit [149815] by mifenton@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update ColorPickerClient and PagePopupBlackBerry
to match check-webkit-style updates.

  • WebCoreSupport/ColorPickerClient.cpp:

(WebCore::ColorPickerClient::generateHTML):

  • WebCoreSupport/PagePopupBlackBerry.cpp:

(WebCore::setValueAndClosePopupCallback):
(WebCore::PagePopupBlackBerry::installDOMFunction):

8:51 AM Changeset in webkit [149814] by commit-queue@webkit.org
  • 9 edits
    4 adds in trunk/Source

[BlackBerry] Upstream the input popups
https://bugs.webkit.org/show_bug.cgi?id=114608

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-09
Reviewed by Rob Buis.

This patch contains contributions from many members of the
BlackBerry WebKit team, including:

Chris Hutten-Czapski
David Hoon
Jessica Cao
Rob Buis
Tiancheng Jiang

Source/WebCore:

  • Resources/blackberry/colorControlBlackBerry.css: Added.

(.color-picker-popup-area):
(.color-picker-content):
(.color-picker-block):
(#color-picker-swatch-block):
(.color-picker-switcher):
(.color-picker-check-mark):
(.color-picker-option):
(.color-picker-button):
(.color-picker-highlight):
(input):
(.color-picker-sharp):
(.color-picker-off):
(.color-picker-inactive-font):
(.color-picker-row):
(.color-picker-hex-style):
(.color-picker-input):
(.color-picker-well):
(.color-picker-input .color-picker-well):
(.color-picker-slider):
(.color-picker-slider-output):
(.color-picker-range):
(.color-picker-range::-webkit-slider-thumb):
(.color-picker-range::-webkit-slider-thumb:active):
(.red-ranger-bg):
(.green-ranger-bg):
(.blue-ranger-bg):
(@media only screen and (height: 768px)):
(@media only screen and (height: 720px)):

  • Resources/blackberry/colorControlBlackBerry.js: Added.

(.):

  • Resources/blackberry/popupControlBlackBerry.css:

(body):
(.popup-area):
(.popup-header):
(.popup-content):
(.popup-buttons):
(.popup-button):
(@media only screen and (width: 720px) and (height: 720px)):

  • Resources/blackberry/selectControlBlackBerry.css:

(.popup-content):
(@media (min-height: 918px)):
(.option):
(@media only screen and (width: 720px) and (height: 720px)):
(.contents):
(.option:active):
(.selected):
(.selected .contents::after):
(.text):
(.disabled):
(.optgroup):
(.optgroup-option):

  • Resources/blackberry/selectControlBlackBerry.js:

(.):

  • Resources/blackberry/timeControlBlackBerry.css: Added.

(#popup-content-time):
(.column):
(.column:not(:last-child)):
(.cell):
(.yearmonthdate .cell div:last-child):
(.row-highlight-container):
(.row-highlight-filler):
(.row-highlight):
(.tall-bit):
(@media only screen and (width: 720px) and (height: 720px)):

  • Resources/blackberry/timeControlBlackBerry.js: Added.

(.):

Source/WebKit/blackberry:

  • WebCoreSupport/ColorPickerClient.cpp:

(WebCore):
(WebCore::ColorPickerClient::generateHTML):

  • WebCoreSupport/DatePickerClient.cpp:

(WebCore):
(WebCore::DatePickerClient::generateHTML):
(WebCore::DatePickerClient::generateDateLabels):

  • WebCoreSupport/DatePickerClient.h:

(DatePickerClient):

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore):
(WebCore::SelectPopupClient::generateHTML):

8:46 AM Changeset in webkit [149813] by rwlbuis@webkit.org
  • 16 edits in trunk/Source/WebCore

[BlackBerry] texmap code generates warnings
https://bugs.webkit.org/show_bug.cgi?id=115815

Patch by Rob Buis <rbuis@rim.com> on 2013-05-09
Reviewed by Benjamin Poulain.

Add USE(TEXTURE_MAPPER) guards since Source/WebCore/CMakeLists.txt includes
these files unconditionally.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  • platform/graphics/texmap/TextureMapper.h:
  • platform/graphics/texmap/TextureMapperBackingStore.cpp:
  • platform/graphics/texmap/TextureMapperBackingStore.h:
  • platform/graphics/texmap/TextureMapperFPSCounter.cpp:
  • platform/graphics/texmap/TextureMapperFPSCounter.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:
  • platform/graphics/texmap/TextureMapperGL.h:
  • platform/graphics/texmap/TextureMapperLayer.cpp:
  • platform/graphics/texmap/TextureMapperLayer.h:
  • platform/graphics/texmap/TextureMapperTile.cpp:
  • platform/graphics/texmap/TextureMapperTile.h:
  • platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:
  • platform/graphics/texmap/TextureMapperTiledBackingStore.h:
8:44 AM Changeset in webkit [149812] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

PluginDatabase: add plugin directory for the BlackBerry port.
https://bugs.webkit.org/show_bug.cgi?id=114943

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-09
Reviewed by Rob Buis.

XP_UNIX is defined for the BlackBerry port, but we don't want to
share the same code here.

  • plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::defaultPluginDirectories):
(WebCore::PluginDatabase::isPreferredPluginDirectory):

8:43 AM Changeset in webkit [149811] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update DOMSupport to match check-webkit-style updates.

  • WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::isTextInputElement):
(BlackBerry::WebKit::DOMSupport::isPasswordElement):
(BlackBerry::WebKit::DOMSupport::convertPointToFrame):

8:42 AM Changeset in webkit [149810] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BLACKBERRY]fix regression in Webpage
and FrameLoaderClientBlackberry
https://bugs.webkit.org/show_bug.cgi?id=115843

Patch by Xuefei Ren <xren@blackberry.com> on 2013-05-09
Reviewed by Rob Buis.

Internally reviewed by Mary Wu.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::loadFile):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::startDownload):

8:35 AM Changeset in webkit [149809] by mifenton@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update FatFingers to match check-webkit-style updates.

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::checkFingerIntersection):
(BlackBerry::WebKit::FatFingers::checkForClickableElement):

  • WebKitSupport/FatFingers.h:

(FatFingersResult):

8:26 AM Changeset in webkit [149808] by mifenton@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Update InRegionScrollableArea, TileIndexHash
and TouchEventHandler to match check-webkit-style updates.

  • WebKitSupport/InRegionScrollableArea.cpp:
  • WebKitSupport/TileIndexHash.h:
  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):

8:16 AM Changeset in webkit [149807] by commit-queue@webkit.org
  • 8 edits
    2 deletes in trunk/Source/WebCore

Web Inspector: Remove Memory Distribution and Memory Snapshots Panels
https://bugs.webkit.org/show_bug.cgi?id=115850

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-09
Reviewed by Andreas Kling.

Removed the Memory Instrumentation Code after r148921.

No new tests, no behavior change.

  • inspector/compile-front-end.py:
  • inspector/front-end/NativeMemorySnapshotView.js: Removed.
  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel):

  • inspector/front-end/Settings.js:

(WebInspector.Settings):
(WebInspector.ExperimentsSettings):

  • inspector/front-end/SettingsScreen.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.js:

(WebInspector._panelDescriptors):

  • inspector/front-end/nativeMemoryProfiler.css: Removed.
8:11 AM Changeset in webkit [149806] by mifenton@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857

Reviewed by Rob Buis.

Styles fixes required for InputHandler based on updated
check-webkit-style.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
(BlackBerry::WebKit::InputHandler::ensureFocusPluginElementVisible):
(BlackBerry::WebKit::InputHandler::setPopupListIndexes):
(BlackBerry::WebKit::InputHandler::firstSpanInString):
(BlackBerry::WebKit::InputHandler::setTextAttributes):

  • WebKitSupport/InputHandler.h:
7:26 AM Changeset in webkit [149805] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed GTK build fix after r149796.

  • GNUmakefile.am: Add a phony target for the window constructors file and include it among

the dependencies for the non-generated code.

7:03 AM Changeset in webkit [149804] by timothy@apple.com
  • 2 edits in trunk/Source/WebKit2

Make dragging off a tab in Safari with a docked Inspector reattach the Inspector.

https://webkit.org/b/115832
rdar://problem/13605661

Reviewed by Benjamin Poulain.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformBringToFront):
If the Web Inspector is no longer in the same window as the inspected view,
then we need to reopen the Inspector to get it attached to the right window.

6:50 AM Changeset in webkit [149803] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

[CSSRegions] Change fast/regions/webkit-flow-inlines-inside-regions-bounds[-vertical] tests to make them platform independent
https://bugs.webkit.org/show_bug.cgi?id=115851

Patch by Radu Stavila <stavila@adobe.com> on 2013-05-09
Reviewed by Antti Koivisto.

Modified tests to make them platform independent by using Ahem and no font smoothing.

  • fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.html:
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.html:
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html:
  • fast/regions/webkit-flow-inlines-inside-regions-bounds.html:
6:48 AM Changeset in webkit [149802] by commit-queue@webkit.org
  • 10 edits in trunk/LayoutTests

[Qt][EFL][GTK] Failing CSS region tests
https://bugs.webkit.org/show_bug.cgi?id=115785

Patch by Radu Stavila <stavila@adobe.com> on 2013-05-09
Reviewed by Antti Koivisto.

Updated tests to overcome platform differences
Unskip fixed CSS regions tests

  • fast/regions/webkit-flow-double-pagination-float-push-expected.html:
  • fast/regions/webkit-flow-double-pagination-float-push.html:
  • fast/regions/webkit-flow-float-pushed-to-last-region-expected.html:
  • fast/regions/webkit-flow-float-pushed-to-last-region.html:
  • fast/regions/webkit-flow-float-unable-to-push-expected.html:
  • fast/regions/webkit-flow-float-unable-to-push.html:
  • fast/regions/webkit-flow-floats-inside-regions-bounds-expected.html:
  • fast/regions/webkit-flow-floats-inside-regions-bounds.html:
  • platform/qt/TestExpectations:
6:12 AM Changeset in webkit [149801] by zarvai@inf.u-szeged.hu
  • 9 edits
    10 copies
    36 adds in trunk/LayoutTests

[Qt] Unreviewed gardeing. Updating some png expected results.

  • platform/qt-5.0-wk2/compositing/checkerboard-expected.png: Added.
  • platform/qt-5.0-wk2/css3/unicode-bidi-isolate-basic-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/delete-image-001-expected.png: Added.
  • platform/qt-5.0-wk2/editing/inserting/typing-around-image-001-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/caret-rtl-2-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/caret-rtl-2-left-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/caret-rtl-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/extend-by-character-002-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/extend-selection-bidi-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/unrendered-001-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/rtl-border-04-expecrted.png: Added.
  • platform/qt-5.0-wk2/fast/borders/rtl-border-05-expected.png: Added.
  • platform/qt-5.0-wk2/fast/box-shadow/shadow-repaint-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/dom/34176-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label06-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label07-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.png:
  • platform/qt-5.0-wk2/fast/forms/listbox-bidi-align-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/search-rtl-expected.png: Added.
  • platform/qt-5.0-wk2/fast/frames/transparent-scrollbar-expected.png: Added.
  • platform/qt-5.0-wk2/fast/inline/inline-box-background-expected.png: Added.
  • platform/qt-5.0-wk2/fast/inline/inline-box-background-long-image-expected.png: Added.
  • platform/qt-5.0-wk2/fast/inline/inline-box-background-repeat-x-expected.png: Added.
  • platform/qt-5.0-wk2/fast/inline/inline-box-background-repeat-y-expected.png: Added.
  • platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/absolute-position-moved-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
  • platform/qt-5.0-wk2/fast/repaint/add-table-overpaint-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
  • platform/qt-5.0-wk2/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/change-transform-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/inline-outline-repaint-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/overflow-into-content-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png.
  • platform/qt-5.0-wk2/fast/repaint/stacked-diacritics-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/table-cell-overflow-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
  • platform/qt-5.0-wk2/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/table-row-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png.
  • platform/qt-5.0-wk2/fast/repaint/transform-rotate-and-remove-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
  • platform/qt-5.0-wk2/fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/repaint-on-image-bounds-change-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png.
  • platform/qt-5.0-wk2/svg/custom/use-disappears-after-style-update-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png.
  • platform/qt-5.0-wk2/svg/dom/rect-modify-rx-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/repaint/svgsvgelement-repaint-children-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
  • platform/qt-5.0-wk2/svg/text/tspan-dynamic-positioning-expected.png: Added.
6:11 AM Changeset in webkit [149800] by akling@apple.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt][WK1]REGRESSION(r149532) tst_qwebelement and tst_qwebframe API tests crash.
<http://webkit.org/b/115855>

Fix obvious off-by-one mistake.

  • Api/qwebelement.cpp:

(QWebElement::styleProperty):

3:05 AM WebKitIDL edited by Christophe Dumez
Add documentation for [NoInterfaceObject] introduced in r149796 (diff)
2:40 AM WebKitIDL edited by Christophe Dumez
Move extended attribute to their correct place (diff)
2:18 AM Changeset in webkit [149799] by kadam@inf.u-szeged.hu
  • 1 edit
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening. Added platform specific expected file after r149758.

  • platform/qt/fast/js/global-constructors-attributes-expected.txt: Added after r149758.
2:07 AM Changeset in webkit [149798] by mario@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Update Simon Pena email on his behalf.

  • Scripts/webkitpy/common/config/contributors.json:
1:14 AM Changeset in webkit [149797] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for Qt minimal build.

r149796 broke builds that have WEB_SOCKETS flag disabled.

  • page/DOMWindow.idl:
12:38 AM Changeset in webkit [149796] by Christophe Dumez
  • 215 edits
    4 deletes in trunk

Add support for [NoInterfaceObject] Web IDL extended attribute
https://bugs.webkit.org/show_bug.cgi?id=115714

Reviewed by Kentaro Hara.

.:

Update GENERATE_BINDINGS macro to take an additional _window_constructors_file
optional argument.

  • Source/cmake/WebKitMacros.cmake:

Source/WebCore:

*Constructor attributes on the global DOMWindow object are now automatically
generated for each non-callback interface that is not declared with the
[NoInterfaceObject] extended attribute. It is thus no longer needed for
developers to manually add *Constructor attributes for their new interfaces
unless they wish to register an "extra" constructor for their interface.

This patch does not modify at all the behavior on JS side. To achieve this,
[NoInterfaceObject] extended attribute is added to interfaces that should
not have it according to specification (e.g. History, Location, ...).
This can be improved later as the behavior should not change with this
patch.

No new tests, no behavior change.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/battery/BatteryManager.idl:
  • Modules/encryptedmedia/MediaKeyMessageEvent.idl:
  • Modules/encryptedmedia/MediaKeyNeededEvent.idl:
  • Modules/encryptedmedia/MediaKeySession.idl:
  • Modules/encryptedmedia/MediaKeys.idl:
  • Modules/filesystem/DOMFileSystem.idl:
  • Modules/filesystem/DOMFileSystemSync.idl:
  • Modules/filesystem/DirectoryEntry.idl:
  • Modules/filesystem/DirectoryEntrySync.idl:
  • Modules/filesystem/DirectoryReader.idl:
  • Modules/filesystem/DirectoryReaderSync.idl:
  • Modules/filesystem/Entry.idl:
  • Modules/filesystem/EntryArray.idl:
  • Modules/filesystem/EntryArraySync.idl:
  • Modules/filesystem/EntrySync.idl:
  • Modules/filesystem/FileEntry.idl:
  • Modules/filesystem/FileEntrySync.idl:
  • Modules/filesystem/FileWriter.idl:
  • Modules/filesystem/FileWriterSync.idl:
  • Modules/filesystem/Metadata.idl:
  • Modules/gamepad/Gamepad.idl:
  • Modules/gamepad/GamepadList.idl:
  • Modules/geolocation/Coordinates.idl:
  • Modules/geolocation/Geolocation.idl:
  • Modules/geolocation/Geoposition.idl:
  • Modules/geolocation/PositionError.idl:
  • Modules/indexeddb/DOMWindowIndexedDatabase.idl:
  • Modules/indexeddb/IDBAny.idl:
  • Modules/mediasource/MediaSource.idl:
  • Modules/mediasource/SourceBuffer.idl:
  • Modules/mediasource/SourceBufferList.idl:
  • Modules/mediastream/DOMWindowMediaStream.idl: Removed.
  • Modules/mediastream/MediaStream.idl:
  • Modules/mediastream/MediaStreamTrack.idl:
  • Modules/mediastream/MediaStreamTrackEvent.idl:
  • Modules/mediastream/NavigatorUserMediaError.idl:
  • Modules/mediastream/RTCDTMFSender.idl:
  • Modules/mediastream/RTCDTMFToneChangeEvent.idl:
  • Modules/mediastream/RTCDataChannel.idl:
  • Modules/mediastream/RTCDataChannelEvent.idl:
  • Modules/mediastream/RTCIceCandidateEvent.idl:
  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCStatsReport.idl:
  • Modules/mediastream/RTCStatsResponse.idl:
  • Modules/networkinfo/NetworkInfoConnection.idl:
  • Modules/notifications/DOMWindowNotifications.idl:
  • Modules/notifications/NotificationCenter.idl:
  • Modules/quota/StorageInfo.idl:
  • Modules/quota/StorageQuota.idl:
  • Modules/speech/DOMWindowSpeech.idl: Removed.
  • Modules/speech/DOMWindowSpeechSynthesis.idl:
  • Modules/speech/SpeechGrammar.idl:
  • Modules/speech/SpeechGrammarList.idl:
  • Modules/speech/SpeechRecognition.idl:
  • Modules/speech/SpeechRecognitionAlternative.idl:
  • Modules/speech/SpeechRecognitionError.idl:
  • Modules/speech/SpeechRecognitionEvent.idl:
  • Modules/speech/SpeechRecognitionResult.idl:
  • Modules/speech/SpeechRecognitionResultList.idl:
  • Modules/speech/SpeechSynthesis.idl:
  • Modules/speech/SpeechSynthesisVoice.idl:
  • Modules/webaudio/AnalyserNode.idl:
  • Modules/webaudio/AudioBuffer.idl:
  • Modules/webaudio/AudioBufferSourceNode.idl:
  • Modules/webaudio/AudioContext.idl:
  • Modules/webaudio/AudioDestinationNode.idl:
  • Modules/webaudio/AudioListener.idl:
  • Modules/webaudio/AudioNode.idl:
  • Modules/webaudio/AudioParam.idl:
  • Modules/webaudio/AudioSourceNode.idl:
  • Modules/webaudio/BiquadFilterNode.idl:
  • Modules/webaudio/ChannelMergerNode.idl:
  • Modules/webaudio/ChannelSplitterNode.idl:
  • Modules/webaudio/ConvolverNode.idl:
  • Modules/webaudio/DOMWindowWebAudio.idl: Removed.
  • Modules/webaudio/DelayNode.idl:
  • Modules/webaudio/DynamicsCompressorNode.idl:
  • Modules/webaudio/GainNode.idl:
  • Modules/webaudio/MediaElementAudioSourceNode.idl:
  • Modules/webaudio/MediaStreamAudioDestinationNode.idl:
  • Modules/webaudio/MediaStreamAudioSourceNode.idl:
  • Modules/webaudio/OfflineAudioContext.idl:
  • Modules/webaudio/OscillatorNode.idl:
  • Modules/webaudio/PannerNode.idl:
  • Modules/webaudio/ScriptProcessorNode.idl:
  • Modules/webaudio/WaveShaperNode.idl:
  • Modules/webaudio/WaveTable.idl:
  • Modules/webdatabase/DOMWindowWebDatabase.idl:
  • Modules/webdatabase/Database.idl:
  • Modules/webdatabase/DatabaseSync.idl:
  • Modules/webdatabase/SQLError.idl:
  • Modules/webdatabase/SQLResultSet.idl:
  • Modules/webdatabase/SQLResultSetRowList.idl:
  • Modules/webdatabase/SQLTransaction.idl:
  • Modules/webdatabase/SQLTransactionSync.idl:
  • Modules/websockets/DOMWindowWebSocket.idl: Removed.
  • Modules/websockets/WebSocket.idl:
  • PlatformBlackBerry.cmake:
  • UseJSC.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/IDLParser.pm:

(parseTypedef):

  • bindings/scripts/preprocess-idls.pl:

(GenerateConstructorAttribute):
(getFileContents):
(getPartialInterfaceNameFromIDL):
(isCallbackInterfaceFromIDL):
(trim):
(getInterfaceExtendedAttributesFromIDL):

  • css/CSSFontFaceLoadEvent.idl:
  • css/CSSFontFaceRule.idl:
  • css/CSSSupportsRule.idl:
  • css/CSSUnknownRule.idl:
  • css/DOMWindowCSS.idl:
  • css/FontLoader.idl:
  • css/MediaQueryList.idl:
  • css/MediaQueryListListener.idl:
  • css/StyleMedia.idl:
  • dom/CustomElementConstructor.idl:
  • dom/DOMError.idl:
  • dom/DOMNamedFlowCollection.idl:
  • dom/DataTransferItem.idl:
  • dom/DataTransferItemList.idl:
  • dom/EventListener.idl:
  • dom/EventTarget.idl:
  • dom/NodeIterator.idl:
  • dom/ShadowRoot.idl:
  • dom/TreeWalker.idl:
  • dom/WebKitNamedFlow.idl:
  • fileapi/FileException.idl:
  • fileapi/FileReaderSync.idl:
  • html/HTMLAudioElement.idl:
  • html/HTMLDetailsElement.idl:
  • html/HTMLOptionElement.idl:
  • html/MediaError.idl:
  • html/MediaKeyError.idl:
  • html/MicroDataItemValue.idl:
  • html/RadioNodeList.idl:
  • html/ValidityState.idl:
  • html/canvas/CanvasRenderingContext.idl:
  • html/canvas/DOMPath.idl:
  • html/canvas/EXTDrawBuffers.idl:
  • html/canvas/EXTTextureFilterAnisotropic.idl:
  • html/canvas/OESElementIndexUint.idl:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESTextureFloat.idl:
  • html/canvas/OESTextureHalfFloat.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/WebGLCompressedTextureATC.idl:
  • html/canvas/WebGLCompressedTexturePVRTC.idl:
  • html/canvas/WebGLCompressedTextureS3TC.idl:
  • html/canvas/WebGLContextAttributes.idl:
  • html/canvas/WebGLDebugRendererInfo.idl:
  • html/canvas/WebGLDebugShaders.idl:
  • html/canvas/WebGLDepthTexture.idl:
  • html/canvas/WebGLLoseContext.idl:
  • html/canvas/WebGLVertexArrayObjectOES.idl:
  • html/track/AudioTrack.idl:
  • html/track/AudioTrackList.idl:
  • html/track/TextTrackRegionList.idl:
  • html/track/VideoTrack.idl:
  • html/track/VideoTrackList.idl:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorFrontendHost.idl:
  • inspector/JavaScriptCallFrame.idl:
  • inspector/ScriptProfile.idl:
  • inspector/ScriptProfileNode.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • page/AbstractView.idl:
  • page/BarInfo.idl:
  • page/Console.idl:
  • page/Crypto.idl:
  • page/DOMSecurityPolicy.idl:
  • page/DOMWindow.idl:
  • page/History.idl:
  • page/Location.idl:
  • page/MemoryInfo.idl:
  • page/Navigator.idl:
  • page/PagePopupController.idl:
  • page/Performance.idl:
  • page/PerformanceEntry.idl:
  • page/PerformanceEntryList.idl:
  • page/PerformanceMark.idl:
  • page/PerformanceMeasure.idl:
  • page/PerformanceNavigation.idl:
  • page/PerformanceResourceTiming.idl:
  • page/PerformanceTiming.idl:
  • page/Screen.idl:
  • page/SpeechInputResult.idl:
  • page/SpeechInputResultList.idl:
  • page/WorkerNavigator.idl:
  • page/make_settings.pl:

(generateInternalSettingsIdlFile):

  • svg/ElementTimeControl.idl:
  • svg/SVGAnimationElement.idl:
  • svg/SVGExternalResourcesRequired.idl:
  • svg/SVGFilterPrimitiveStandardAttributes.idl:
  • svg/SVGFitToViewBox.idl:
  • svg/SVGLangSpace.idl:
  • svg/SVGLocatable.idl:
  • svg/SVGStyledElement.idl:
  • svg/SVGTests.idl:
  • svg/SVGTransformable.idl:
  • svg/SVGURIReference.idl:
  • testing/InternalSettings.idl:
  • testing/Internals.idl:
  • testing/MallocStatistics.idl:
  • testing/TypeConversions.idl:
  • workers/AbstractWorker.idl:
  • workers/DedicatedWorkerContext.idl:
  • workers/SharedWorker.idl:
  • workers/SharedWorkerContext.idl:
  • workers/WorkerContext.idl:
  • workers/WorkerLocation.idl:
  • xml/XPathExpression.idl:
  • xml/XPathNSResolver.idl:

Tools:

Update BindingsTests.generate_supplemental_dependency() to pass an
additional windowConstructorsFile argument to preprocess-idls.pl.

  • Scripts/webkitpy/bindings/main.py:

(BindingsTests.generate_supplemental_dependency):
(BindingsTests.main):

12:05 AM Changeset in webkit [149795] by commit-queue@webkit.org
  • 5 edits in trunk

[GTK][AC] Buildfix after r149694
https://bugs.webkit.org/show_bug.cgi?id=115797

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-05-09
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Some interfaces, such as a return value and parameters of functions are changed.

No new tests since no functionality changed.

  • platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::animationHasStepsTimingFunction):
(WebCore::GraphicsLayerClutter::timingFunctionForAnimationValue):
(WebCore::GraphicsLayerClutter::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerClutter::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):
(WebCore::GraphicsLayerClutter::setAnimationEndpoints):
(WebCore::GraphicsLayerClutter::setAnimationKeyframes):

  • platform/graphics/clutter/GraphicsLayerClutter.h:

(GraphicsLayerClutter):

Tools:

Add CLUTTER_LIBS for linking TestWebCore.

  • TestWebKitAPI/GNUmakefile.am:
Note: See TracTimeline for information about the timeline view.