Timeline
Jun 25, 2013:
- 11:37 PM WebKitGTK/StartHacking edited by
- (diff)
- 11:35 PM WebKitGTK/StartHacking edited by
- Estimated size of a debug build added (diff)
- 9:16 PM Changeset in webkit [151979] by
-
- 21 edits26 adds in branches/dfgFourthTier
fourthTier: DFG should support switch_string
https://bugs.webkit.org/show_bug.cgi?id=117967
Source/JavaScriptCore:
Reviewed by Sam Weinig.
Add a reusable binary switch creator.
Implement switch on string using three modes:
- Binary switch on StringImpl* in the case of identifiers.
- Trie of binary switches on characters in the case of a not-too-big switch over not-too-big 8-bit strings.
- Hash lookup if all else fails.
Anywhere from a 2x to 3x speed-up on microbenchmarks that stress
string switches. 25-35% speed-up on HashMap tests. 4% speed-up on
pdfjs.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/JumpTable.h:
(StringJumpTable):
(JSC::StringJumpTable::clear):
- dfg/DFGBackwardsPropagationPhase.cpp:
(JSC::DFG::BackwardsPropagationPhase::propagate):
- dfg/DFGBinarySwitch.cpp: Added.
(DFG):
(JSC::DFG::BinarySwitch::BinarySwitch):
(JSC::DFG::BinarySwitch::advance):
(JSC::DFG::BinarySwitch::build):
- dfg/DFGBinarySwitch.h: Added.
(DFG):
(BinarySwitch):
(JSC::DFG::BinarySwitch::caseIndex):
(JSC::DFG::BinarySwitch::caseValue):
(JSC::DFG::BinarySwitch::fallThrough):
(JSC::DFG::BinarySwitch::Case::Case):
(Case):
(JSC::DFG::BinarySwitch::Case::operator<):
(JSC::DFG::BinarySwitch::BranchCode::BranchCode):
(BranchCode):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGLazyJSValue.cpp:
(JSC::DFG::LazyJSValue::getValue):
(JSC::DFG::equalToStringImpl):
(DFG):
(JSC::DFG::LazyJSValue::strictEqual):
(JSC::DFG::LazyJSValue::dump):
- dfg/DFGLazyJSValue.h:
(JSC::DFG::LazyJSValue::knownStringImpl):
(LazyJSValue):
(JSC::DFG::LazyJSValue::stringImpl):
(JSC::DFG::LazyJSValue::switchLookupValue):
- dfg/DFGNode.cpp:
(WTF::printInternal):
- dfg/DFGNode.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitSwitchChar):
(JSC::DFG::SpeculativeJIT::StringSwitchCase::operator<):
(DFG):
(JSC::DFG::SpeculativeJIT::emitBinarySwitchStringRecurse):
(JSC::DFG::SpeculativeJIT::emitSwitchStringOnString):
(JSC::DFG::SpeculativeJIT::emitSwitchString):
(JSC::DFG::SpeculativeJIT::emitSwitch):
(JSC::DFG::SpeculativeJIT::addBranch):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::branch8):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::StringSwitchCase::StringSwitchCase):
(StringSwitchCase):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileSwitch):
- runtime/Options.h:
(JSC):
Source/WTF:
Reviewed by Sam Weinig.
Make it possible to compare a RefPtr<StringImpl> and a StringImpl* without
having to ref the StringImpl.
- wtf/text/StringHash.h:
(WTF::StringHash::equal):
LayoutTests:
Reviewed by Sam Weinig.
- fast/js/regress/script-tests/switch-string-basic-big-var.js: Added.
(foo):
(make):
- fast/js/regress/script-tests/switch-string-basic-big.js: Added.
(foo):
(make):
- fast/js/regress/script-tests/switch-string-basic-var.js: Added.
(foo):
(make):
- fast/js/regress/script-tests/switch-string-basic.js: Added.
(foo):
- fast/js/regress/script-tests/switch-string-big-length-tower-var.js: Added.
(foo):
- fast/js/regress/script-tests/switch-string-length-tower-var.js: Added.
(foo):
- fast/js/regress/script-tests/switch-string-length-tower.js: Added.
(foo):
- fast/js/regress/script-tests/switch-string-short.js: Added.
(foo):
- fast/js/regress/switch-string-basic-big-expected.txt: Added.
- fast/js/regress/switch-string-basic-big-var-expected.txt: Added.
- fast/js/regress/switch-string-basic-big-var.html: Added.
- fast/js/regress/switch-string-basic-big.html: Added.
- fast/js/regress/switch-string-basic-expected.txt: Added.
- fast/js/regress/switch-string-basic-var-expected.txt: Added.
- fast/js/regress/switch-string-basic-var.html: Added.
- fast/js/regress/switch-string-basic.html: Added.
- fast/js/regress/switch-string-big-length-tower-var-expected.txt: Added.
- fast/js/regress/switch-string-big-length-tower-var.html: Added.
- fast/js/regress/switch-string-length-tower-expected.txt: Added.
- fast/js/regress/switch-string-length-tower-var-expected.txt: Added.
- fast/js/regress/switch-string-length-tower-var.html: Added.
- fast/js/regress/switch-string-length-tower.html: Added.
- fast/js/regress/switch-string-short-expected.txt: Added.
- fast/js/regress/switch-string-short.html: Added.
- 8:48 PM Changeset in webkit [151978] by
-
- 12 edits in trunk/Source
JSString should remember AtomicString
https://bugs.webkit.org/show_bug.cgi?id=117386
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Added JSValue::toAtomicString and JSString::atomicString. These two functions allow WebCore to update
JSString's m_value to set isAtomic flag and avoid the AtomicStringTable lookups in subsequent attempts
to obtain the AtomicString of the same value.
- runtime/JSCJSValue.h:
- runtime/JSString.h:
(JSC::JSString::atomicString):
(JSC::JSValue::toAtomicString):
Source/WebCore:
Added "Atomic" attribute as a WebKit extension to WebIDL, and deployed it in Element.idl and Node.idl so that
the binding code can use newly added JSValue::toAtomic to update JSString's m_value.
- bindings/js/JSDOMBinding.cpp:
(WebCore::valueToAtomicStringWithNullCheck): Added.
(WebCore::valueToAtomicStringWithUndefinedOrNullCheck): Added.
- bindings/js/JSDOMBinding.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GetNativeTypeFromSignature): Return const AtomicString& when either Atomic attribute is specified or the type is
Reflect. Note that setAttribute and getAttribute both use AtomicString for all arguments.
(JSValueToNative): Use AtomicString equivalents when possible when converting DOMString to a WebCore object.
- bindings/scripts/IDLAttributes.txt: Added "Atomic" attribute.
- bindings/scripts/test/JS/JSTestObj.cpp: Baselined test cases.
(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):
- dom/Document.idl:
- dom/Element.idl:
- dom/Node.idl:
- 6:22 PM Changeset in webkit [151977] by
-
- 2 edits in branches/safari-537-branch/Source/WTF
Merged r151755. <rdar://problem/14209227>
- 6:09 PM Changeset in webkit [151976] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r151747. <rdar://problem/14187667>
- 6:06 PM Changeset in webkit [151975] by
-
- 14 edits in trunk/Source
Adopt is/toHTMLAnchorElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=117973
Reviewed by Andreas Kling.
To enhance readibility, this patch adopts is/toHTMLAnchorElement.
This also helps out to reduce duplicated use of static_cast.
Source/WebCore:
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::anchorElement):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::anchorElement):
(WebCore::AccessibilityRenderObject::internalLinkElement):
(WebCore::AccessibilityRenderObject::url):
(WebCore::AccessibilityRenderObject::stringValueForMSAA):
(WebCore::AccessibilityRenderObject::isLinked):
- css/CSSDefaultStyleSheets.cpp:
(WebCore::elementCanUseSimpleDefaultStyle):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- dom/Document.cpp:
(WebCore::Document::updateBaseURL):
- dom/TreeScope.cpp:
(WebCore::TreeScope::findAnchor):
- dom/VisitedLinkState.cpp:
(WebCore::linkHashForElement):
(WebCore::VisitedLinkState::determineLinkStateSlowCase):
- html/HTMLAnchorElement.h:
(WebCore::isHTMLAnchorElement):
(WebCore::toHTMLAnchorElement):
- page/DragController.cpp:
(WebCore::DragController::draggableElement):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::absoluteLinkURL):
(WebCore::HitTestResult::isLiveLink):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::getTextDecorationColors):
Source/WebKit/blackberry:
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):
- 5:58 PM Changeset in webkit [151974] by
-
- 3 edits in branches/safari-537-branch/Source/JavaScriptCore
Merged r151786. <rdar://problem/14149317>
- 5:36 PM Changeset in webkit [151973] by
-
- 7 edits in branches/safari-537-branch/Source
Merged r151929. <rdar://problem/14250527>
- 5:30 PM Changeset in webkit [151972] by
-
- 4 edits in branches/safari-537-branch/Source/WebKit2
Merged r151760. <rdar://problem/14197983>
- 2:48 PM Changeset in webkit [151971] by
-
- 2 edits in trunk/Source/WebCore
Don't snapshot plug-ins that come from the same host as the page
https://bugs.webkit.org/show_bug.cgi?id=117969
<rdar://problem/12885400>
Reviewed by Tim Horton.
If a page is serving plug-in content directly, then that content
is typically very important to the page. For example, embedding
a video or audio player. In this case, don't snapshot the plug-ins.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Add a test
that compares the plug-in's URL against the main page's URL and don't snapshot
if they are the same.
- 11:18 AM Changeset in webkit [151970] by
-
- 2 edits in branches/safari-537-branch/Source/JavaScriptCore
Merged r151923. <rdar://problem/14250711>
- 11:17 AM Changeset in webkit [151969] by
-
- 2 edits in tags/Safari-537.46.6/Source/JavaScriptCore
Merged r151923. <rdar://problem/14250711>
- 11:15 AM Changeset in webkit [151968] by
-
- 5 edits in tags/Safari-537.46.6/Source
Versioning.
- 11:12 AM Changeset in webkit [151967] by
-
- 1 copy in tags/Safari-537.46.6
New Tag.
- 10:45 AM Changeset in webkit [151966] by
-
- 9 edits in trunk/Source/WebCore
Added PLATFORM(WIN) to many places where it was missing for compiling WebGL for Windows.
https://bugs.webkit.org/show_bug.cgi?id=117955
Reviewed by Brent Fulgham.
- platform/graphics/GraphicsContext3D.cpp:
- platform/graphics/OpenGLShims.cpp:
- platform/graphics/cairo/GraphicsContext3DCairo.cpp: Include new location of ShaderLang.h on Windows as of r151854.
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):
- platform/graphics/opengl/Extensions3DOpenGL.h:
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: Added PLATFORM(WIN) when necessary to each file.
- 9:16 AM Changeset in webkit [151965] by
-
- 3 edits1 move2 deletes in trunk/LayoutTests
[AX][ATK] Update accessibility baselines after r151953
https://bugs.webkit.org/show_bug.cgi?id=117983
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-06-25
Reviewed by Chris Fleizach.
Updating aria-option-role-expected.txt for EFL and GTK after the changes in aria-option-role.html test (r151953).
Moving platform aria-checkbox-text.html to LayoutTests/accessibility. Baseline is the same for mac, gtk, efl. Windows port has it's own specific version.
- accessibility/aria-checkbox-text-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-checkbox-text-expected.txt.
- platform/efl/accessibility/aria-checkbox-text-expected.txt: Removed.
- platform/efl/accessibility/aria-option-role-expected.txt:
- platform/gtk/accessibility/aria-checkbox-text-expected.txt: Removed.
- platform/gtk/accessibility/aria-option-role-expected.txt:
- 8:24 AM Changeset in webkit [151964] by
-
- 2 edits in trunk/Source/WebCore
Fixes a typo in renderTextDecorationFlagsToCSSValue
https://bugs.webkit.org/show_bug.cgi?id=117989
Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2013-06-25
Reviewed by Gyuyoung Kim.
Return value should be PassRefPtr instead of RefPtr.
Backported from Blink:
https://src.chromium.org/viewvc/blink?view=rev&revision=152994
No new tests, no behavior change.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderTextDecorationFlagsToCSSValue):
- 6:09 AM Changeset in webkit [151963] by
-
- 2 edits in trunk/Tools
Unreviewed, change my email address for watch list.
- Scripts/webkitpy/common/config/watchlist:
- 5:57 AM Changeset in webkit [151962] by
-
- 2 edits in trunk/Source/WebCore
"application/x-mimearchive" should be included in finding remoteWebArchive while document loading
https://bugs.webkit.org/show_bug.cgi?id=117734
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-06-25
Reviewed by Alexey Proskuryakov.
"application/x-mimearchive" is also used while checking for
RemoteArchive.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::continueAfterContentPolicy):
- 5:23 AM WebKitGTK/StartHacking edited by
- (diff)
- 5:22 AM WebKitGTK/StartHacking edited by
- (diff)
- 5:09 AM WebKitEFLLayoutTest edited by
- Change the guide of layout test dependencies to use the install script. (diff)
- 5:04 AM EFLWebKit edited by
- Change the guide of base dependencies to use the install script. (diff)
- 4:35 AM Changeset in webkit [151961] by
-
- 1 edit1 add in trunk/Tools
[EFL] Add a script to install dependencies.
https://bugs.webkit.org/show_bug.cgi?id=117968
Reviewed by Christophe Dumez.
Add a script which installs basic dependencies for building WebKit EFL.
The dependencies are from the current EFLWebKit wiki page.
After this patch is landed, the wiki page will be updated to use
this script.
- efl/install-dependencies: Added.
- 3:57 AM Changeset in webkit [151960] by
-
- 2 edits in trunk/LayoutTests
[GTK] Add bug report into TestExpectations for fast/text/international/synthesized-italic-vertical-latin.html
https://bugs.webkit.org/show_bug.cgi?id=117976
Unreviewed gardening.
TestExpectations was missing a bug number for a skip test (http://webkit.org/b/117975).
Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-06-25
- platform/gtk/TestExpectations:
- 2:17 AM Changeset in webkit [151959] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing inspector test.
- platform/qt/TestExpectations:
- 2:00 AM Changeset in webkit [151958] by
-
- 3 edits in trunk/Source/WebCore
HTMLMediaElement should inherit from MediaPlayerClient privately
https://bugs.webkit.org/show_bug.cgi?id=117874
Reviewed by Andreas Kling.
Fixing FIXME: HTMLMediaElement was stuck with public inheritance from
MediaPlayerClient due to the Chromium and Qt port.
The Qt port is changed to not cast from MediaPlayerClient to HTMLMediaElement.
- html/HTMLMediaElement.h:
- platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::commitLoad):
- 1:44 AM Changeset in webkit [151957] by
-
- 10 edits in trunk/Source/WebCore
Checking if frame is complete and access duration doesn't need a decode
https://bugs.webkit.org/show_bug.cgi?id=116041
Reviewed by Allan Sandfeld Jensen.
This change is to avoid image decoding for these two operations:
- frameIsCompleteAtIndex
- frameDurationAtIndex
These two operations are moved to ImageDecoder interface and are now const
to prevent future regression.
We are now able to check if a frame is complete by parsing the entire GIF file
without decoding. This also provides information like frame duration such that
controller the animation doesn't require any decoding.
Based on the Blink patch by Hin-Chung Lam <hclam@google.com>
https://src.chromium.org/viewvc/blink?revision=149883&view=revision
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::frameIsCompleteAtIndex):
(WebCore::BitmapImage::frameDurationAtIndex):
- platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::frameDurationAtIndex):
(WebCore::ImageSource::frameHasAlphaAtIndex):
(WebCore::ImageSource::frameIsCompleteAtIndex):
- platform/graphics/ImageSource.h:
- platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::frameHasAlphaAtIndex):
(WebCore::ImageDecoder::frameIsCompleteAtIndex):
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::frameDurationAtIndex):
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::frameIsCompleteAtIndex):
(WebCore::GIFImageDecoder::frameDurationAtIndex):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::gifComplete):
(WebCore::GIFImageDecoder::decode):
(WebCore::GIFImageDecoder::initFrameBuffer):
- platform/image-decoders/gif/GIFImageDecoder.h:
- platform/image-decoders/gif/GIFImageReader.h:
(GIFImageReader::frameContext):
(GIFImageReader::parseCompleted):
Jun 24, 2013:
- 11:28 PM Changeset in webkit [151956] by
-
- 4 edits in trunk/Source/WebCore
Update AbstractWorker, Worker and SharedWorker to match the specification
https://bugs.webkit.org/show_bug.cgi?id=117930
Reviewed by Kentaro Hara.
Update AbstractWorker, Worker and SharedWorker to match the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#abstractworker
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#worker
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#sharedworker
Worker and SharedWorker no longer inherit from AbstractWorker. Web IDL 'implements'
statements are used instead. Worker and SharedWorker can now inherit from EventTarget
as per the specification.
No new tests, no behavior change.
- workers/AbstractWorker.idl:
- workers/SharedWorker.idl:
- workers/Worker.idl:
- 10:58 PM Changeset in webkit [151955] by
-
- 2 edits in trunk/Source/WebCore
DerivedSources.make should optionally include SupplementalDependencies.dep
https://bugs.webkit.org/show_bug.cgi?id=117972
Reviewed by Dan Bernstein.
make(1) logs a non-fatal error to stderr when an included Makefile can't
be found. This error is non-fatal because after make(1) reads in all the
Makefiles it runs the recipe for any rule that specifies one of the
Makefiles as a target. Only if the Makefile is still missing after
applying these rules does the error become fatal.
Since SupplementalDependencies.dep is generated by running a script on
SupplementalDependencies.txt, the file won't exist during clean builds.
Each time make(1) logs this non-fatal error, Xcode sees it and itself
logs a non-fatal error. This is annoying.
We don't care about this error. We only care if the recipe to generate
SupplementalDependencies.dep fails, which is already a fatal error.
Suppress the error by including SupplementalDependencies.dep optionally.
- DerivedSources.make:
- 9:23 PM Changeset in webkit [151954] by
-
- 3 edits in trunk/Tools
[Mac] Update font used for Chinese in test systems
https://bugs.webkit.org/show_bug.cgi?id=117970
Reviewed by Alexey Proskuryakov.
Add "Songti TC" and "Songti SC" to the list of allowed fonts
in DRT and WKTR.
- DumpRenderTree/mac/DumpRenderTree.mm:
(allowedFontFamilySet):
- WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
(WTR::allowedFontFamilySet):
- 9:07 PM Changeset in webkit [151953] by
-
- 2 edits in trunk/LayoutTests
[Mac] Build correction.
- platform/mac/accessibility/aria-tab-roles-expected.txt:
- 8:47 PM Changeset in webkit [151952] by
-
- 5 edits in trunk/Source/WebKit2
Silverlight triggers sandbox violations: deny network-bind 0.0.0.0:0
https://bugs.webkit.org/show_bug.cgi?id=117966
<rdar://problem/13927918>
Patch by Simon Cooper <scooper@apple.com> on 2013-06-24
Reviewed by Sam Weinig.
Allow assigning (via bind) an ephemeral port before connecting
- Resources/PlugInSandboxProfiles/com.apple.QuickTime Plugin.plugin.sb:
- Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:
- Resources/PlugInSandboxProfiles/com.microsoft.SilverlightPlugin.sb:
- Resources/PlugInSandboxProfiles/com.oracle.java.JavaAppletPlugin.sb:
- 7:38 PM Changeset in webkit [151951] by
-
- 9 edits9 adds in trunk
Add support for document.currentScript
https://bugs.webkit.org/show_bug.cgi?id=104221
Reviewed by Ryosuke Niwa.
Merge http://src.chromium.org/viewvc/blink?view=revision&revision=152230
document.currentScript reflects the script that is currently being executed.
Merge http://src.chromium.org/viewvc/blink?view=revision&revision=152237
Following up patch for code clean-up.
Source/WebCore:
Tests: fast/dom/Document/document-current-script-async.html
fast/dom/Document/document-current-script.html
- dom/Document.cpp:
(WebCore::Document::pushCurrentScript):
(WebCore::Document::popCurrentScript):
- dom/Document.h:
(WebCore::Document::currentScript):
- dom/Document.idl:
- dom/ScriptElement.cpp:
(WebCore::isHTMLScriptElement):
(WebCore::isSVGScriptElement):
(WebCore::ScriptElement::executeScript):
(WebCore::toScriptElementIfPossible):
- html/HTMLScriptElement.h:
(WebCore::toHTMLScriptElement):
- svg/SVGScriptElement.cpp:
- svg/SVGScriptElement.h:
(WebCore::toSVGScriptElement):
LayoutTests:
- fast/dom/Document/document-current-script-async-expected.txt: Added.
- fast/dom/Document/document-current-script-async.html: Added.
- fast/dom/Document/document-current-script-expected.txt: Added.
- fast/dom/Document/document-current-script.html: Added.
- fast/dom/Document/resources/log-current-script-b.js: Added.
- fast/dom/Document/resources/log-current-script-d.js: Added.
- fast/dom/Document/resources/log-current-script-f.js: Added.
- fast/dom/Document/resources/log-current-script.js: Added.
- 7:27 PM Changeset in webkit [151950] by
-
- 2 edits in trunk/Source/WebKit2
PluginProcess deny file-read-data /Network/Library under addVolumeTracker
https://bugs.webkit.org/show_bug.cgi?id=117965
<rdar://problem/14121247>
Patch by Simon Cooper <scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.
Silently deny reading /Network/Applications and
/Network/Library.
- Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
- 7:19 PM Changeset in webkit [151949] by
-
- 25 edits in trunk/Source
Adopt is/toHTMLFormElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=117937
Reviewed by Andreas Kling.
This refers to http://src.chromium.org/viewvc/blink?view=revision&revision=152859
To enhance readibility, this patch adopts is/toHTMLFormElement.
This also helps out to reduce duplicated use of static_cast.
Source/WebCore:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- bindings/js/JSDOMFormDataCustom.cpp:
(WebCore::toHTMLFormElement):
- bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::nameGetter):
- editing/FrameSelection.cpp:
(WebCore::scanForForm):
(WebCore::FrameSelection::currentForm):
- editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
- html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::findAssociatedForm):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::findFormAncestor):
- html/HTMLFormControlsCollection.cpp:
(WebCore::HTMLFormControlsCollection::HTMLFormControlsCollection):
(WebCore::HTMLFormControlsCollection::formControlElements):
(WebCore::HTMLFormControlsCollection::formImageElements):
(WebCore::HTMLFormControlsCollection::updateNameCache):
- html/HTMLFormElement.h:
(WebCore::isHTMLFormElement):
(WebCore::toHTMLFormElement):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::insertedInto):
- html/HTMLNameCollection.cpp:
(WebCore::WindowNameCollection::nodeMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatches):
- html/RadioInputType.cpp:
(WebCore::RadioInputType::handleKeydownEvent):
- html/RadioNodeList.cpp:
(WebCore::RadioNodeList::RadioNodeList):
(WebCore::RadioNodeList::checkElementMatchesRadioNodeListFilter):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::closestFormAncestor):
- page/Frame.cpp:
(WebCore::Frame::searchForLabelsBeforeElement):
Source/WebKit/blackberry:
- WebCoreSupport/CredentialManager.cpp:
(WebCore::CredentialManager::autofillPasswordForms):
Source/WebKit/win:
- DOMCoreClasses.cpp:
(DOMElement::createInstance):
- DOMHTMLClasses.cpp:
(DOMHTMLFormElement::action):
(DOMHTMLFormElement::method):
- WebFrame.cpp:
(formElementFromDOMElement):
Source/WebKit2:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::containsAnyFormElements):
- 6:44 PM Changeset in webkit [151948] by
-
- 2 edits in trunk/Source/WebKit2
deny file-read-data /Library/CoreMediaIO/Plug-Ins/DAL
https://bugs.webkit.org/show_bug.cgi?id=117964
<rdar://problem/14036864>
Patch by Simon Cooper <scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.
Permit reading of the /Library/CoreMediaIO/Plug-Ins/DAL
subdirectory.
- Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
- 6:36 PM Changeset in webkit [151947] by
-
- 105 edits in trunk/Source/WebCore
Remove unneeded include header files from WebCore
https://bugs.webkit.org/show_bug.cgi?id=117926
Reviewed by Andreas Kling.
Merge from https://chromiumcodereview.appspot.com/17388003.
Cleanup unused includes from WebCore.
- editing/CompositeEditCommand.cpp:
- editing/DeleteSelectionCommand.cpp:
- editing/EditingStyle.cpp:
- editing/Editor.cpp:
- editing/FrameSelection.cpp:
- editing/HTMLInterchange.cpp:
- editing/IndentOutdentCommand.cpp:
- editing/InsertListCommand.cpp:
- editing/InsertTextCommand.cpp:
- editing/SpellChecker.h:
- editing/VisibleUnits.cpp:
- editing/VisibleUnits.h:
- editing/markup.cpp:
- fileapi/Blob.h:
- fileapi/File.h:
- fileapi/WebKitBlobBuilder.h:
- history/HistoryItem.cpp:
- history/HistoryItem.h:
- html/BaseDateAndTimeInputType.cpp:
- html/BaseDateAndTimeInputType.h:
- html/ClassList.cpp:
- html/ClassList.h:
- html/DOMSettableTokenList.h:
- html/DOMURL.cpp:
- html/DateInputType.h:
- html/FormController.h:
- html/HTMLCanvasElement.cpp:
- html/HTMLCollection.cpp:
- html/HTMLCollection.h:
- html/HTMLDocument.h:
- html/HTMLEmbedElement.cpp:
- html/HTMLFieldSetElement.h:
- html/HTMLFormElement.cpp:
- html/HTMLFrameOwnerElement.h:
- html/HTMLIFrameElement.cpp:
- html/HTMLInputElement.cpp:
- html/HTMLLegendElement.cpp:
- html/HTMLLinkElement.h:
- html/HTMLMediaElement.cpp:
- html/HTMLMeterElement.cpp:
- html/HTMLOptionElement.cpp:
- html/HTMLOutputElement.h:
- html/HTMLPlugInImageElement.cpp:
- html/HTMLPlugInImageElement.h:
- html/HTMLProgressElement.cpp:
- html/HTMLSelectElement.cpp:
- html/HTMLTableElement.cpp:
- html/HTMLTitleElement.cpp:
- html/HTMLTrackElement.cpp:
- html/ImageInputType.h:
- html/InputType.h:
- html/MediaController.h:
- html/MediaFragmentURIParser.h:
- html/NumberInputType.cpp:
- html/RadioNodeList.h:
- html/TextFieldInputType.h:
- html/TypeAhead.cpp:
- html/ValidityState.cpp:
- html/canvas/CanvasPathMethods.h:
- html/canvas/CanvasRenderingContext2D.cpp:
- html/canvas/CanvasRenderingContext2D.h:
- html/canvas/OESVertexArrayObject.h:
- html/canvas/WebGLBuffer.cpp:
- html/canvas/WebGLBuffer.h:
- html/canvas/WebGLCompressedTextureATC.h:
- html/canvas/WebGLCompressedTextureS3TC.cpp:
- html/canvas/WebGLCompressedTextureS3TC.h:
- html/canvas/WebGLContextObject.h:
- html/canvas/WebGLDebugShaders.cpp:
- html/canvas/WebGLObject.h:
- html/canvas/WebGLProgram.h:
- html/canvas/WebGLRenderingContext.cpp:
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLShader.h:
- html/canvas/WebGLTexture.h:
- html/canvas/WebGLUniformLocation.h:
- html/canvas/WebGLVertexArrayObjectOES.h:
- html/parser/BackgroundHTMLParser.cpp:
- html/parser/BackgroundHTMLParser.h:
- html/parser/CSSPreloadScanner.cpp:
- html/parser/HTMLConstructionSite.cpp:
- html/parser/HTMLConstructionSite.h:
- html/parser/HTMLDocumentParser.h:
- html/parser/HTMLElementStack.h:
- html/parser/HTMLParserIdioms.cpp:
- html/parser/HTMLParserIdioms.h:
- html/parser/HTMLParserScheduler.h:
- html/parser/HTMLPreloadScanner.cpp:
- html/parser/HTMLSourceTracker.h:
- html/parser/HTMLTreeBuilder.h:
- html/parser/HTMLTreeBuilderSimulator.h:
- html/parser/XSSAuditor.cpp:
- html/parser/XSSAuditorDelegate.h:
- html/shadow/HTMLContentElement.cpp:
- html/shadow/HTMLContentElement.h:
- html/shadow/MediaControlElements.cpp:
- html/shadow/MediaControls.h:
- html/shadow/SliderThumbElement.cpp:
- html/shadow/SliderThumbElement.h:
- html/shadow/TextControlInnerElements.cpp:
- html/track/InbandTextTrack.h:
- html/track/LoadableTextTrack.cpp:
- html/track/LoadableTextTrack.h:
- html/track/TextTrackCueGeneric.h:
- 6:28 PM Changeset in webkit [151946] by
-
- 3 edits in trunk/Source/WebCore
Don't crash if renderName() is called on a renderer with no style
https://bugs.webkit.org/show_bug.cgi?id=117960
Reviewed by Dave Hyatt.
Calling renderName() at the top of RenderObject::willChangeStyle() when
adding debug logging would often crash because various functions called
from renderName() assume style is non-null. Fix this.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::renderName):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::renderName):
- 6:14 PM Changeset in webkit [151945] by
-
- 10 edits in branches/dfgFourthTier/Source
fourthTier: Count external memory usage towards heap footprint
https://bugs.webkit.org/show_bug.cgi?id=117948
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Currently just count strings. Strings get counted in such a way that we won't re-count strings
that are aliased, by dividing by the reference count. This then ups the GC footprint and allows
the collector to appropriately amortize itself.
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::size):
(JSC::Heap::collect):
- heap/Heap.h:
(Heap):
- heap/SlotVisitor.h:
- heap/SlotVisitorInlines.h:
(JSC::SlotVisitor::reportExtraMemoryUsage):
(JSC):
- runtime/JSString.cpp:
(JSC::JSString::visitChildren):
Source/WTF:
Expose some functionality needed for properly measuring StringImpl footprint.
- wtf/Atomics.h:
(WTF::weakCompareAndSwapSize):
(WTF):
- wtf/MathExtras.h:
(divideRoundedUp):
- wtf/text/StringImpl.h:
(WTF::StringImpl::cost):
(StringImpl):
(WTF::StringImpl::costDuringGC):
(WTF::StringImpl::refCount):
- 6:05 PM Changeset in webkit [151944] by
-
- 2 edits in trunk/Source/WebKit2
Repeating sandbox violations when playing Amazon Prime videos with Flash
https://bugs.webkit.org/show_bug.cgi?id=117953
<rdar://problem/14193693>
Patch by Simon Cooper <scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.
Add some missing "standard" files for network service lookups
- Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
- 6:03 PM Changeset in webkit [151943] by
-
- 2 edits in trunk/Source/WebKit2
Plug-in sandbox violations attempting to access com.apple.CoreGraphics.plist
https://bugs.webkit.org/show_bug.cgi?id=117963
<rdar://problem/14084234>
Patch by Simon Cooper <scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.
Permit the reading of the com.apple.CoreGraphics preference file
- Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
- 5:51 PM Changeset in webkit [151942] by
-
- 5 edits in trunk/LayoutTests
[Mac] media/video-played-collapse.html is flakey on certain platforms.
https://bugs.webkit.org/show_bug.cgi?id=117034
Reviewed by Beth Dakin.
This test does not wait until a seek completes before issuing a play()
command during its subtests. This can cause flakiness on some platforms
where playback will begin from the pre-seek currentTime. Wait for the seek
to complete before continuing the sub-tests.
Additionally, a 2s watchdog timeout is present to catch stalled tests. This
timeout is fine for short-duration sub-tests, but longer tests' durations
approach this 2s timeout period. Make the timeout the test duration + 2s.
- media/video-played-collapse-expected.txt:
- media/video-played-collapse.html:
- media/video-played.js:
(playForMillisecs.callPauseIfTimeIsReached):
(playForMillisecs):
- platform/mac-wk2/TestExpectations:
- 5:41 PM Changeset in webkit [151941] by
-
- 2 edits in trunk/Source/WebKit2
com.oracle.javadeployment.plist is not correctly specified in the JavaApplet plugin profile
https://bugs.webkit.org/show_bug.cgi?id=117961
<rdar://problem/14223823>
Patch by Simon Cooper <scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.
Remove the trailing extraneous .plist from the preference file rule
- Resources/PlugInSandboxProfiles/com.oracle.java.JavaAppletPlugin.sb:
- 5:40 PM Changeset in webkit [151940] by
-
- 2 edits in trunk/Source/WebKit2
PluginProcess sandbox violations on com.apple.networkConnect.plist when resetting Safari
https://bugs.webkit.org/show_bug.cgi?id=117958
<rdar://problem/13938149>
Patch by Simon Cooper <scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.
Allow reading the com.apple.networkConnect plist.
- Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb:
- 5:38 PM Changeset in webkit [151939] by
-
- 2 edits in trunk/Source/WebKit2
Java sandbox violation ipc-posix-shm-read-data /tmp/com.apple.csseed.67
https://bugs.webkit.org/show_bug.cgi?id=117954
<rdar://problem/14166577>
Patch by Simon Cooper <scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.
Permit read access to this shared memory segment
- Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
- 5:37 PM Changeset in webkit [151938] by
-
- 2 edits in trunk/Source/WebKit2
Plugin Sandbox violation in /Library/Audio/Sounds/Banks
https://bugs.webkit.org/show_bug.cgi?id=117957
<rdar://problem/14163582>
Patch by Simon Cooper <scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.
Permit read access to subdirectories under /Library/Audio/Sounds
- Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
- 5:15 PM Changeset in webkit [151937] by
-
- 2 edits in trunk/Source/WebKit
Windows build links to opengl32.lib to allow WebGL compiling.
https://bugs.webkit.org/show_bug.cgi?id=117949
Reviewed by Brent Fulgham.
- WebKit.vcxproj/WebKit/WebKitCommon.props: Added link to opengl32.lib.
- 5:05 PM Changeset in webkit [151936] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Only resume root layer commits for visible WebPages
https://bugs.webkit.org/show_bug.cgi?id=117956
https://jira.bbqnx.net/browse/BRWSR-12047
JIRA428381
Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-06-24
Reviewed by George Staikos.
In r150629, the code from that change introduced to
suspend and resume root layer commits would not take into
account whether the page is actually visible.
Because application activation state is usually conveyed
to all or any WebPages, this would mean on transitioning
into an active application state, we were resuming
root layer commits that might have previously been
disabled for visibility reasons.
Fix this by going through a single function that knows
by itself whether to suspend or resume root layer commits,
so the calling code doesn't have a chance to get it wrong.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setVisible):
(BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
(BlackBerry::WebKit::WebPagePrivate::updateRootLayerCommitEnabled):
- Api/WebPage_p.h:
(WebPagePrivate):
- 4:34 PM Changeset in webkit [151935] by
-
- 2 edits in trunk/Source/WebCore
Added /d option to xcopy to prevent unnecessary copying and compiling.
https://bugs.webkit.org/show_bug.cgi?id=117951
Reviewed by Brent Fulgham.
- WebCore.vcxproj/WebCorePreBuild.cmd:
- 4:27 PM Changeset in webkit [151934] by
-
- 3 edits2 adds in trunk
Fix various crashes on sites with fixed backgrounds
https://bugs.webkit.org/show_bug.cgi?id=117959
Source/WebCore:
Reviewed by Andy Estes.
FrameView::removeSlowRepaintObject() would assume that addSlowRepaintObject()
had been called before it, but this isn't always the case. For example, if
a page has a fixed background on the body, this falls into the accelerated
path in WK2 tiled mode, so addSlowRepaintObject() is never called. However,
we still call removeSlowRepaintObject() if the body is removed.
So null-check m_slowRepaintObjects to avoid crashing.
Test: platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-removal.html
- page/FrameView.cpp:
(WebCore::FrameView::removeSlowRepaintObject):
LayoutTests:
Reviewed by Andy Estes.
Test that does a document.write on a page with a fixed background on the body.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-removal-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-removal.html: Added.
- 3:56 PM Changeset in webkit [151933] by
-
- 2 edits in trunk/Tools
Make MiniBrowser paginated mode work with WebKit1
https://bugs.webkit.org/show_bug.cgi?id=117950
Reviewed by Beth Dakin.
- MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController isPaginated]):
(-[WK1BrowserWindowController togglePaginationMode:]):
Hook up isPaginated and togglePaginationMode just as for WebKit2.
- 3:49 PM Changeset in webkit [151932] by
-
- 2 edits in trunk/Source/WebKit2
Make sure m_iconDatabaseImpl is not null before closing it
https://bugs.webkit.org/show_bug.cgi?id=117943
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-06-24
Reviewed by Simon Fraser.
Since r150474 WebIconDatabase is closed unconditionally in
TestController destructor, in that case WebKitTestRunner crashes
when no icon database path is set. This misbehavior was observed in
ports such as efl and nix.
In this patch, WebIconDatabase::close() calls m_iconDatabaseImpl->close()
only if m_iconDatabaseImpl is not null, as it's already being done in other
WebIconDatabase's methods, such as isOpen().
- UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::close):
- 2:36 PM Changeset in webkit [151931] by
-
- 1 edit2 copies2 moves in trunk/LayoutTests
[CSS Shapes] split test shape-inside-first-fit-001.html into 800x600 parts
https://bugs.webkit.org/show_bug.cgi?id=117939
Reviewed by Dirk Schulze.
Split the test into two parts, to ensure that it first within the 800x600 limit.
- fast/exclusions/shape-inside/shape-inside-first-fit-001-horizontal-expected.html: Copied from LayoutTests/fast/exclusions/shape-inside/shape-inside-first-fit-001-expected.html.
- fast/exclusions/shape-inside/shape-inside-first-fit-001-horizontal.html: Copied from LayoutTests/fast/exclusions/shape-inside/shape-inside-first-fit-001.html.
- fast/exclusions/shape-inside/shape-inside-first-fit-001-vertical-expected.html: Renamed from LayoutTests/fast/exclusions/shape-inside/shape-inside-first-fit-001-expected.html.
- fast/exclusions/shape-inside/shape-inside-first-fit-001-vertical.html: Renamed from LayoutTests/fast/exclusions/shape-inside/shape-inside-first-fit-001.html.
- 2:33 PM Changeset in webkit [151930] by
-
- 2 edits in trunk/Tools
bisect-builds: improve heuristic for choosing the next build after a broken build
<http://webkit.org/b/117918>
Reviewed by Simon Fraser.
- Scripts/bisect-builds: When a build is broken, use a heuristic
that "bisects" the left side or the right side of the remaining
revisions to pick a revision that's sufficiently different from
the revision of the broken build. This heuristic assumes there
is a sequential range of broken builds whenever one broken build
is found.
- 2:32 PM Changeset in webkit [151929] by
-
- 7 edits in trunk/Source
Expose the mediaHasAudio() function in WK2
https://bugs.webkit.org/show_bug.cgi?id=117946
<rdar://problem/14250527>
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-24
Reviewed by Beth Dakin.
Source/WebCore:
- WebCore.exp.in: Updated to include symbol for
HTMLMediaElement::mediaHasAudio() function.
Source/WebKit2:
Exposes the WebCore::HTMLMediaElement::mediaHasAudio() function
in WK2.
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
(WKBundleHitTestResultMediaHasAudio): Added.
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::mediaHasAudio): Added.
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
- 2:28 PM Changeset in webkit [151928] by
-
- 2 edits in trunk/LayoutTests
[CSS Shapes] Remove setCSSShapesEnabled(true) from shape-inside-empty-expected.html since it isn't using shapes
https://bugs.webkit.org/show_bug.cgi?id=117945
Reviewed by Dirk Schulze.
- fast/exclusions/shape-inside/shape-inside-empty-expected.html:
- 2:09 PM Changeset in webkit [151927] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r147591): can't type in Adobe Connect
https://bugs.webkit.org/show_bug.cgi?id=117947
<rdar://problem/14223539>
Reviewed by Andreas Kling.
With the change in r147591, it is now possible for a plug-in element to be focused before the plug-in
starts. Handle this by focusing the plug-in right after it's started if necessary.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::didInitializePlugin):
- 2:02 PM Changeset in webkit [151926] by
-
- 20 edits1 delete in trunk/Source
Move displayID stuff from Widget to Chrome
https://bugs.webkit.org/show_bug.cgi?id=117944
Reviewed by Anders Carlsson.
In r151877 I polluted Widget with displayID-related stuff. This would
be better on HostWindow, so move it there. This is a net code reduction,
and eliminates PlatformScreenMac.h, and the NSScreen category.
Source/WebCore:
- WebCore.exp.in: Remove some functions from the exports list.
- WebCore.xcodeproj/project.pbxproj: PlatformScreenMac.h is gone!
- dom/Document.cpp:
(WebCore::Document::requestAnimationFrame): Get the displayID from page->chrome()
- page/Chrome.cpp:
(WebCore::Chrome::Chrome): Initialize m_displayID.
(WebCore::Chrome::displayID):
(WebCore::Chrome::windowScreenDidChange): Code moved from Page; save the
displayID, and tell all subframes that the displayID changed.
- page/Chrome.h: Add displayID-related functions.
- page/FrameView.cpp: Removed windowDisplayID().
- page/FrameView.h: Ditto.
- page/Page.cpp: Removed code.
(WebCore::Page::Page):
- page/Page.h:
- platform/HostWindow.h: Added virtual displayID-related functions.
- platform/Widget.cpp: Removed code.
- platform/Widget.h: Ditto.
- platform/mac/PlatformScreenMac.h: Removed.
- platform/mac/PlatformScreenMac.mm: Removed the NSScreen category.
(WebCore::displayIDFromScreen):
(WebCore::screenForDisplayID):
(WebCore::displayFromWidget):
(WebCore::screenForWidget):
- platform/mac/WidgetMac.mm: Removed windowDisplayID().
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::notifyFlushBeforeDisplayRefresh): Get
the displayID via chrome().
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView doWindowDidChangeScreen]): Go via chrome().
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowScreenDidChange): Go via chrome().
- 1:52 PM Changeset in webkit [151925] by
-
- 2 edits in trunk/Source/WebCore
Don't create Document's selector query cache just to invalidate it.
<http://webkit.org/b/117942>
Reviewed by Anders Carlsson.
If Document::m_selectorQueryCache is null, there's nothing to invalidate,
so don't go through the trouble of creating a query cache.
- dom/Document.cpp:
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::updateBaseURL):
- 1:46 PM Changeset in webkit [151924] by
-
- 25 edits11 adds3 deletes in trunk/LayoutTests
AX: Make tests usable on Mac and Windows
https://bugs.webkit.org/show_bug.cgi?id=117901
Reviewed by Chris Fleizach.
- accessibility/aria-checkbox-text.html:
- accessibility/aria-hidden-expected.txt:
- accessibility/aria-hidden-with-elements-expected.txt:
- accessibility/aria-hidden-with-elements.html:
- accessibility/aria-hidden.html:
- accessibility/aria-labelledby-overrides-label-expected.txt:
- accessibility/aria-labelledby-overrides-label.html:
- accessibility/aria-option-role.html:
- accessibility/aria-presentational-role-expected.txt:
- accessibility/aria-presentational-role.html:
- accessibility/aria-tab-roles-expected.txt:
- accessibility/aria-tab-roles.html:
- accessibility/empty-image-with-title-expected.txt:
- accessibility/empty-image-with-title.html:
- accessibility/html-html-element-is-ignored-expected.txt:
- accessibility/html-html-element-is-ignored.html:
- accessibility/img-aria-button-alt-tag-expected.txt:
- accessibility/img-aria-button-alt-tag.html:
- accessibility/input-image-alt-expected.txt:
- accessibility/input-image-alt.html:
- platform/mac/accessibility/aria-checkbox-text-expected.txt:
- platform/mac/accessibility/aria-option-role-expected.txt:
- platform/win/accessibility/aria-checkbox-text-expected.txt: Added.
- platform/win/accessibility/aria-hidden-expected.txt: Added.
- platform/win/accessibility/aria-hidden-with-elements-expected.txt: Added.
- platform/win/accessibility/aria-labelledby-overrides-label-expected.txt: Added.
- platform/win/accessibility/aria-option-role-expected.txt: Added.
- platform/win/accessibility/aria-presentational-role-expected.txt: Added.
- platform/win/accessibility/aria-tab-roles-expected.txt: Added.
- platform/win/accessibility/empty-image-with-title-expected.txt: Added.
- platform/win/accessibility/html-html-element-is-ignored-expected.txt: Added.
- platform/win/accessibility/img-aria-button-alt-tag-expected.txt: Added.
- platform/win/accessibility/input-image-alt-expected.txt: Added.
- platform/win/aria-labelledby-on-input-expected.txt: Removed.
- platform/win/aria-menubar-menuitems-expected.txt: Removed.
- platform/win/aria-roles-expected.txt: Removed.
- 1:26 PM Changeset in webkit [151923] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Makefile build fix for AppleWindows.
- JavaScriptCore.vcxproj/JavaScriptCore.make:
- 1:09 PM Changeset in webkit [151922] by
-
- 2 edits in trunk/Source/WebCore
Refactor adding a line break
https://bugs.webkit.org/show_bug.cgi?id=117907
Reviewed by Ryosuke Niwa.
Reduce code duplication when adding a line break.
No new tests, refactoring.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::addLineBreak):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
- 12:53 PM Changeset in webkit [151921] by
-
- 2 edits in trunk/Source/WTF
Unreviewed. AppleWin build fix, followup to r151915.
- WTF.vcxproj/WTFProduction.props:
- 12:08 PM Changeset in webkit [151920] by
-
- 4 edits in trunk/Source
HashMap: reverse the order of the template arguments at alternate 'find', 'contains' and 'add' methods
https://bugs.webkit.org/show_bug.cgi?id=117911
Reviewed by Anders Carlsson.
The order of the template arguments at HashMap alternate 'find', 'contains' and
'add' methods is reversed so that callers can just pass the translator
and let the compiler deduce input argument type.
Another rational is consistency with HashSet class.
Source/WebCore:
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::get):
(WebCore::HTTPHeaderMap::contains):
(WebCore::HTTPHeaderMap::add):
Source/WTF:
- wtf/HashMap.h:
- 11:47 AM Changeset in webkit [151919] by
-
- 2 edits in trunk/Source/WebCore
Remove unnecessary check in RenderBlockLineLayout::nextSegmentBreak()
https://bugs.webkit.org/show_bug.cgi?id=117713
Reviewed by David Hyatt.
Changeset r151613 should have done this instead. Since r151518 changed
nextSegmentBreak() to detect line-break opportunities between no-wrap
inlines there is no need to force the break later.
No new tests, covered by existing tests.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
- 11:06 AM Changeset in webkit [151918] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: WebInspector.displayNameForURL() failure prevents DOM inspection
https://bugs.webkit.org/show_bug.cgi?id=117927
Handle possible mis-encoded URI fragments passed to decodeURIComponent() which
could prevent inspection of the DOM.
Reviewed by Timothy Hatcher.
- UserInterface/Main.js:
(WebInspector.displayNameForURL):
- 10:42 AM Changeset in webkit [151917] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Added a Radar number to my last ChangeLog
- 10:12 AM Changeset in webkit [151916] by
-
- 2 edits in trunk/Source/WebCore
Potential crash when in-band track is removed
https://bugs.webkit.org/show_bug.cgi?id=117938
<rdar://problem/14246763>
Reviewed by Jer Noble.
This is timing dependent and I was unable to come up with a reliable test.
- html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::willRemoveTextTrackPrivate): Early return if the media element
has been cleared.
- 9:25 AM Changeset in webkit [151915] by
-
- 6 edits2 adds in trunk/Source/WTF
[WinCairo] WTF.dll is linking with CoreFoundation.lib in VS2010.
https://bugs.webkit.org/show_bug.cgi?id=117294
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-06-24
Reviewed by Brent Fulgham.
WinCairo build should not use CoreFoundation.
- WTF.vcxproj/WTFCFLite.props: Added.
- WTF.vcxproj/WTFCommon.props: Remove CoreFoundation.lib from depencency list.
- WTF.vcxproj/WTFCoreFoundation.props: Added.
- WTF.vcxproj/WTFDebug.props: Import WTFCoreFoundation.props for WinApple.
- WTF.vcxproj/WTFDebugWinCairo.props: Import WTFCFLite.props for WinCairo.
- WTF.vcxproj/WTFRelease.props: Import WTFCoreFoundation.props for WinApple.
- WTF.vcxproj/WTFReleaseWinCairo.props: Import WTFCFLite.props for WinCairo.
- 9:21 AM Changeset in webkit [151914] by
-
- 21 edits3 moves in trunk
WaveTable name has changed to PeriodicWave
https://bugs.webkit.org/show_bug.cgi?id=117748
Reviewed by Jer Noble.
Source/WebCore:
See related Web Audio bug and spec change:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=19561
https://dvcs.w3.org/hg/audio/rev/7c4a40a9bb57
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createPeriodicWave):
- Modules/webaudio/AudioContext.h:
- Modules/webaudio/AudioContext.idl:
- Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::OscillatorNode):
(WebCore::OscillatorNode::setType):
(WebCore::OscillatorNode::calculateSampleAccuratePhaseIncrements):
(WebCore::OscillatorNode::process):
(WebCore::OscillatorNode::setPeriodicWave):
(WebCore::OscillatorNode::propagatesSilence):
- Modules/webaudio/OscillatorNode.h:
- Modules/webaudio/OscillatorNode.idl:
- Modules/webaudio/PeriodicWave.cpp: Renamed from Source/WebCore/Modules/webaudio/WaveTable.cpp.
(WebCore::PeriodicWave::create):
(WebCore::PeriodicWave::createSine):
(WebCore::PeriodicWave::createSquare):
(WebCore::PeriodicWave::createSawtooth):
(WebCore::PeriodicWave::createTriangle):
(WebCore::PeriodicWave::PeriodicWave):
(WebCore::PeriodicWave::waveDataForFundamentalFrequency):
(WebCore::PeriodicWave::maxNumberOfPartials):
(WebCore::PeriodicWave::numberOfPartialsForRange):
(WebCore::PeriodicWave::createBandLimitedTables):
(WebCore::PeriodicWave::generateBasicWaveform):
- Modules/webaudio/PeriodicWave.h: Renamed from Source/WebCore/Modules/webaudio/WaveTable.h.
(WebCore::PeriodicWave::rateScale):
(WebCore::PeriodicWave::periodicWaveSize):
(WebCore::PeriodicWave::sampleRate):
(WebCore::PeriodicWave::numberOfRanges):
- Modules/webaudio/PeriodicWave.idl: Renamed from Source/WebCore/Modules/webaudio/WaveTable.idl.
- Target.pri:
- WebCore.xcodeproj/project.pbxproj:
Tools:
- Scripts/do-webcore-rename:
LayoutTests:
- fast/js/global-constructors-attributes-expected.txt:
- webaudio/oscillator-basic-expected.txt:
- webaudio/oscillator-basic.html:
- webaudio/oscillator-custom.html:
- webaudio/resources/oscillator-testing.js:
(generateExponentialOscillatorSweep):
- 8:35 AM Changeset in webkit [151913] by
-
- 1 edit1 move in trunk/LayoutTests
[Mac] Unreviewed build correction after r151868
New test expecation had been placed in the wrong directory.
- platform/mac/accessibility/listitem-title-expected.txt: Copied from platform/mac/listitem-title-actual.txt.
- platform/mac/listitem-title-actual.txt: Removed.
- 8:14 AM Changeset in webkit [151912] by
-
- 3 edits in trunk/Source/WebCore
Commented IDL implements statements should not impact code generation
https://bugs.webkit.org/show_bug.cgi?id=117932
Reviewed by Kentaro Hara.
Fix regular expression in preprocess-idls.pl script so that commented
IDL implements statements no longer cause any code to be generated.
No new tests, covered by TestObj.idl.
- bindings/scripts/preprocess-idls.pl:
(getImplementedInterfacesFromIDL):
- bindings/scripts/test/TestObj.idl:
- 8:12 AM Changeset in webkit [151911] by
-
- 10 edits in trunk/Source/WebCore
Adopt is/toHTMLStyleElement for minor code cleanup
https://bugs.webkit.org/show_bug.cgi?id=117917
Reviewed by Antti Koivisto.
This patch refers to http://src.chromium.org/viewvc/blink?view=revision&revision=152853
There are some usages of static_cast to HTMLStyleElement so this patch creates toHTMLStyleElement
function for code cleanup. Plus, isHTMLStyleElement is also made for same purpose.
- css/CSSStyleSheet.cpp:
(WebCore::isAcceptableCSSStyleSheetParent):
- css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::scopeFor):
- css/StyleSheetList.cpp:
(WebCore::StyleSheetList::getNamedItem):
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
- dom/Node.cpp:
(WebCore::Node::numberOfScopedHTMLStyleChildren):
- html/HTMLStyleElement.h:
(WebCore::isHTMLStyleElement):
(WebCore::toHTMLStyleElement):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::inlineStyleSheetText):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
- 8:09 AM Changeset in webkit [151910] by
-
- 2 edits in trunk/Source/WebCore
Cleanup RenderThemeWin after r151783 and r151794.
https://bugs.webkit.org/show_bug.cgi?id=117936
Reviewed by Alexis Menard.
GetSysColor() takes an integer as argument. Let cssValueIdToSysColorIndex()
return an int instead of casting the values to the CSSValueID type.
- rendering/RenderThemeWin.cpp:
(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWin::systemColor):
- 7:16 AM Changeset in webkit [151909] by
-
- 2 edits in trunk/Source/WebCore
Use SetFilePointer instead of SetFilePointerEx in FileSystemWin
https://bugs.webkit.org/show_bug.cgi?id=116205
Reviewed by Ryosuke Niwa.
SetFilePointerEx is not available on Windows CE, so use SetFilePointer.
Also add a extra return for the case of an failure.
- platform/win/FileSystemWin.cpp:
(WebCore::seekFile):
- 7:07 AM Changeset in webkit [151908] by
-
- 7 edits1 copy in trunk/Source/WebCore
Introduce WindowTimers IDL interface
https://bugs.webkit.org/show_bug.cgi?id=117929
Reviewed by Kentaro Hara.
Introduce WindowTimers IDL interface and have both DOMWindow and WorkerContext
implement it to match the latest specification and avoid IDL duplication:
- http://www.whatwg.org/specs/web-apps/current-work/multipage/timers.html#windowtimers
- http://dev.w3.org/html5/workers/#apis-available-to-workers
No new tests, no behavior change.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- page/DOMWindow.idl:
- page/WindowTimers.idl:
- workers/WorkerContext.idl:
- 6:58 AM Changeset in webkit [151907] by
-
- 2 edits in trunk/Source/WebCore
Build fix for WinCE after r151563.
- bindings/js/JSDOMBinding.cpp:
(WebCore::toInt8): Use fabs() instead of abs().
(WebCore::toUInt8): Ditto.
- 6:09 AM Changeset in webkit [151906] by
-
- 2 edits in trunk/Source/WebCore
Build fix for WinCE after r151783.
- rendering/RenderThemeWinCE.cpp:
(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWinCE::systemColor):
- 5:31 AM Changeset in webkit [151905] by
-
- 2 edits in trunk
[CMAKE] Clear unused cmakedefines
https://bugs.webkit.org/show_bug.cgi?id=117931
Reviewed by Christophe Dumez.
- Source/cmakeconfig.h.cmake:
Removed ENABLE_AS_IMAGE, ENABLE_LEGACY_WEBKIT_BLOB_BUILDER and
ENABLE_CLIENT_BASED_GEOLOCATION cmakedefines which already removed.
- 2:38 AM Changeset in webkit [151904] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Implement unit test callback: onWordGuesses.
https://bugs.webkit.org/show_bug.cgi?id=117794
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-06-24
Reviewed by Christophe Dumez.
- UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
(onWordGuesses):
Add client suggestions for the word.
(checkClientSuggestionsForWord):
Verify the suggestions that were given by the client.
- 2:32 AM Changeset in webkit [151903] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r151021.
http://trac.webkit.org/changeset/151021
https://bugs.webkit.org/show_bug.cgi?id=117924
caused regressions on Qt and GTK (#117141 and #117688)
(Requested by philn on #webkit).
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_init):
(webKitWebSrcFinalize):
(webKitWebSrcSetProperty):
(webKitWebSrcGetProperty):
(webKitWebSrcStop):
(webKitWebSrcStart):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri):
(webKitWebSrcNeedDataMainCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcSeekMainCb):
(webKitWebSrcSeekDataCb):
(StreamingClient::StreamingClient):
(StreamingClient::~StreamingClient):
(StreamingClient::didReceiveResponse):
(StreamingClient::didReceiveData):
(StreamingClient::didFinishLoading):
(StreamingClient::wasBlocked):
(StreamingClient::cannotShowURL):
- 2:09 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:04 AM Changeset in webkit [151902] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0
Merge r151791 - [GTK] remove bashism from configure
https://bugs.webkit.org/show_bug.cgi?id=117796
Reviewed by Gustavo Noronha Silva.
- Source/autotools/FindDependencies.m4: Perform string appending by redeclaring the base string to the value
of the base string followed by the string that's being appended. This replaces the use of the '+=' operator
that works under bash but is not supported by other shells.
- 1:49 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:46 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:44 AM Changeset in webkit [151901] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r148279 - [GTK] Webkit fails to build webkit2gtk-tests-resources.gresource.
https://bugs.webkit.org/show_bug.cgi?id=114485
Patch by Hanyee Kim <choco@company100.net> on 2013-04-12
Reviewed by Martin Robinson.
Generating webkit2gtk-tests-resources.gresource can be failed due to
the non-existing target directory.
We need to make target directory before generating it.
- UIProcess/API/gtk/tests/GNUmakefile.am:
- 1:41 AM Changeset in webkit [151900] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r148125 - Fixed build failure in Plugin.h: FloatPoint was not in namespace WebCore
make[1]: * Waiting for unfinished jobs....
In file included from Source/WebKit2/PluginProcess/PluginCreationParameters.h:31:0,
from Source/WebKit2/PluginProcess/PluginCreationParameters.cpp:27:
./Source/WebKit2/WebProcess/Plugins/Plugin.h:268:58: error: 'FloatPoint' in namespace 'WebCore' does not name a type
./Source/WebKit2/WebProcess/Plugins/Plugin.h:268:77: error: ISO C++ forbids declaration of 'parameter' with no type [-fpermissive]
cc1plus: warning: unrecognized command line option "-Wno-c++11-extensions" [enabled by default]
make[1]: * [Source/WebKit2/PluginProcess/libwebkit2gtk_3_0_la-PluginCreationParameters.lo] Error 1
It now passes that make target.
https://bugs.webkit.org/show_bug.cgi?id=111862
Patch by Tobias Mueller <tobiasmue@gnome.org> on 2013-04-10
Reviewed by Darin Adler.
- WebProcess/Plugins/Plugin.h:
(WebCore): Added FloatPoint to the WebCore namespace
- 1:37 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:32 AM Changeset in webkit [151899] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r151492 - [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
https://bugs.webkit.org/show_bug.cgi?id=116723
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
- GNUmakefile.am: When generating the WebCoreLayerGtk2.a archive from all the dependency archives, remove the
current archive (if any). Updating an existent archive in an incremental build is not bulletproof and can lead
to corrupt archives and subsequent build failures. On the other hand, the archive generation is not expensive
and produces a working archive without problems even on incremental builds.
- 1:31 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:26 AM Changeset in webkit [151898] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r150884 - Unreviewed. Fix make distcheck.
Source/WebKit2:
- GNUmakefile.am: Add WebCoreLayerGtk2.a to DISTCLEANFILES.
- 1:03 AM Changeset in webkit [151897] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipping the crashing tests on debug bots.
https://bugs.webkit.org/show_bug.cgi?id=94458
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-24
- platform/qt/TestExpectations:
- 12:58 AM Changeset in webkit [151896] by
-
- 8 edits in trunk/Source/WebCore
Move IDL implements statements to IDL files that implement the interface
https://bugs.webkit.org/show_bug.cgi?id=117921
Reviewed by Kentaro Hara.
Move IDL implements statements to IDL files that implement the interface
so that we can more easily know that a given IDL interface implements
another.
The generator now enforces this as well for consistency.
No new tests, covered by TestImplements.idl.
- bindings/scripts/preprocess-idls.pl:
(getImplementedInterfacesFromIDL):
- bindings/scripts/test/TestImplements.idl:
- bindings/scripts/test/TestInterface.idl:
- dom/CharacterData.idl:
- dom/ChildNode.idl:
- dom/DocumentType.idl:
- dom/Element.idl:
- 12:58 AM WebKitGTK/2.0.x edited by
- (diff)
- 12:52 AM Changeset in webkit [151895] by
-
- 3 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
[GTK] Merge r150008 into the webkit-2.0 branch
https://bugs.webkit.org/show_bug.cgi?id=117889
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-06-21
Reviewed by Carlos Garcia Campos.
- GNUmakefile.am: Merge r150008 with some changes, for instance not listing libPlatform.la, libPlatformGtk2.la
and libANGLE.la among the webcore layer dependencies as these libtool archives were created after the 2.0 branching.
- GNUmakefile.list.am: Merge r150008.
- 12:32 AM Changeset in webkit [151894] by
-
- 4 edits2 adds in trunk
Hittest finds the truncated text instead of the floating input, when the input is clicked.
https://bugs.webkit.org/show_bug.cgi?id=115675
Patch by Zalan Bujtas <Alan Bujtas> on 2013-06-24
Reviewed by David Hyatt.
Ignore truncated text on inline textbox and everything beyond the ellipsis box on
the root inlinebox while hittesting. (provided that nodeAtPoint finds no hit for any of
the root inline's children.)
Source/WebCore:
Test: fast/css/text-overflow-ellipsis-and-floating-input-hittest.html
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::nodeAtPoint):
(WebCore::InlineTextBox::paint):
LayoutTests:
- fast/css/text-overflow-ellipsis-and-floating-input-hittest-expected.txt: Added.
- fast/css/text-overflow-ellipsis-and-floating-input-hittest.html: Added.
Jun 23, 2013:
- 11:20 PM Changeset in webkit [151893] by
-
- 2 edits in trunk/LayoutTests
AX: Rebaseline test after r151868
https://bugs.webkit.org/show_bug.cgi?id=117892
Rubber stamped by Chris Fleizach.
- platform/mac/accessibility/lists-expected.txt:
- 10:49 PM Changeset in webkit [151892] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening. Unskip two media tests because there is no crash after system update.
- platform/efl/TestExpectations:
- 9:07 PM Changeset in webkit [151891] by
-
- 1 edit in branches/dfgFourthTier/Source/WTF/ChangeLog
fourthTier: DFG should optimize identifier string equality
https://bugs.webkit.org/show_bug.cgi?id=117920
Reviewed by Sam Weinig.
Note that this ChangeLog was supposed to be committed in r151890.
Expose the IsIdentifier bit to the JIT.
- wtf/text/StringImpl.h:
(WTF::StringImpl::flagIsIdentifier):
- 9:05 PM Changeset in webkit [151890] by
-
- 12 edits6 adds in branches/dfgFourthTier
fourthTier: DFG should optimize identifier string equality
https://bugs.webkit.org/show_bug.cgi?id=117920
Source/JavaScriptCore:
Reviewed by Sam Weinig.
This is a 20% speed-up for string equality comparisons when both strings are
identifiers.
This is important for two reasons:
1) Using strings as enumerations is an idiom. A great example is typeof. It
would be great if this performed better.
2) When I implement switch_string in the DFG, it would be great to optimize
the case where the switched-on value is an identifier. That would involve
a simple binary switch rather than a more complicated trie-switch over
characters.
- bytecode/SpeculatedType.cpp:
(JSC::dumpSpeculation):
(JSC::speculationToAbbreviatedString):
(JSC::speculationFromCell):
- bytecode/SpeculatedType.h:
(JSC):
(JSC::isStringIdentSpeculation):
(JSC::isStringSpeculation):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateStringIdent):
(Node):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::compileStringEquality):
(JSC::DFG::SpeculativeJIT::compileStringIdentEquality):
(DFG):
(JSC::DFG::SpeculativeJIT::speculateString):
(JSC::DFG::SpeculativeJIT::speculateStringIdentAndLoadStorage):
(JSC::DFG::SpeculativeJIT::speculateStringIdent):
(JSC::DFG::SpeculativeJIT::speculate):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- dfg/DFGUseKind.cpp:
(WTF::printInternal):
- dfg/DFGUseKind.h:
(JSC::DFG::typeFilterFor):
(JSC::DFG::isCell):
LayoutTests:
Reviewed by Sam Weinig.
Add a benchmark for string equality where there is a long identifier, and
also add a benchmark for non-identifier string equality (since the previous
test for string equality was really identifier equality).
- fast/js/regress/script-tests/string-long-ident-equality.js: Added.
(foo):
- fast/js/regress/script-tests/string-var-equality.js: Added.
(addFoo):
(foo):
- fast/js/regress/string-long-ident-equality-expected.txt: Added.
- fast/js/regress/string-long-ident-equality.html: Added.
- fast/js/regress/string-var-equality-expected.txt: Added.
- fast/js/regress/string-var-equality.html: Added.
- 6:41 PM Changeset in webkit [151889] by
-
- 7 edits3 adds in branches/dfgFourthTier
Merge trunk r147965.
Source/JavaScriptCore:
2013-04-08 Filip Pizlo <fpizlo@apple.com>
DFG should be able to inline string equality comparisons
https://bugs.webkit.org/show_bug.cgi?id=114224
Reviewed by Oliver Hunt.
Inline 8-bit string equality, go to slow path for 16-bit strings. 2x speed-up for string equality
comparisons on 8-bit strings. 20-50% speed-up on JSRegress/HashMap tests. 30% speed-up on
string-fasta. 2% speed-up on SunSpider overall. Some small speed-ups elsewhere.
This is a gnarly change but we have loads of test coverage already between the HashMap tests and
preexisting DFG string equality tests (which appear to have been designed to test OSR exits, but
also give us good overall coverage on string equality behavior).
- dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compilePeepHoleBranch): (JSC::DFG::SpeculativeJIT::compare): (JSC::DFG::SpeculativeJIT::compileStrictEq): (JSC::DFG::SpeculativeJIT::compileStringEquality): (DFG):
- dfg/DFGSpeculativeJIT.h: (SpeculativeJIT):
LayoutTests:
2013-04-08 Filip Pizlo <fpizlo@apple.com>
DFG should be able to inline string equality comparisons
https://bugs.webkit.org/show_bug.cgi?id=114224
Reviewed by Oliver Hunt.
- fast/js/regress/script-tests/string-equality.js: Added. (foo):
- fast/js/regress/string-equality-expected.txt: Added.
- fast/js/regress/string-equality.html: Added.
- 5:40 PM Changeset in webkit [151888] by
-
- 17 edits in trunk/Source
Sort all the Xcode project files
https://bugs.webkit.org/show_bug.cgi?id=117696
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- JavaScriptCore.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.
Source/ThirdParty:
- gtest/xcode/Samples/FrameworkSample/WidgetFramework.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.
- gtest/xcode/gtest.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.
Source/ThirdParty/ANGLE:
- ANGLE.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.
Source/WebInspectorUI:
- WebInspectorUI.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.
Source/WebKit2:
- WebKit2.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.
Source/WTF:
- WTF.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.
Jun 22, 2013:
- 11:24 PM Changeset in webkit [151887] by
-
- 3 edits in trunk/Source/WebCore
Remove redundant helper from RenderRegion.
https://bugs.webkit.org/show_bug.cgi?id=117915
Patch by Zalan Bujtas <Alan Bujtas> on 2013-06-22
Reviewed by Andreas Kling.
Minor code cleanup.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::regionOversetState):
(WebCore::RenderRegion::setRegionOversetState):
- rendering/RenderRegion.h:
- 11:14 PM Changeset in webkit [151886] by
-
- 3 edits in trunk/Tools
[EFL] Add support for MHTML save/load feature to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=106620
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-06-22
Reviewed by Christophe Dumez.
Enable CTRL + S as save page in mhtml and CTRL + L to load any page
from filesystem.
- MiniBrowser/efl/CMakeLists.txt:
- MiniBrowser/efl/main.c:
(page_contents_callback):
(on_key_down):
(show_file_entry_dialog): generic function to show file enrty
selector dialogue
- 9:57 PM Changeset in webkit [151885] by
-
- 10 edits6 adds in branches/dfgFourthTier
fourthTier: DFG shouldn't exit just because a String GetByVal went out-of-bounds
https://bugs.webkit.org/show_bug.cgi?id=117906
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
This does the obvious thing, but also makes sure that out-of-bounds accesses
don't fall off into a C call, but try to do the fast thing if the prototype
chain is sane. We ought to probably do this for other array accesses in the
future, as well, since it's so darn easy.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::objectPrototypeIsSane):
(JSC):
(JSC::JSGlobalObject::arrayPrototypeChainIsSane):
(JSC::JSGlobalObject::stringPrototypeChainIsSane):
- runtime/JSGlobalObject.h:
(JSGlobalObject):
LayoutTests:
Reviewed by Mark Hahnenberg.
The out-of-bounds benchmark that isn't insane speeds up by 22x in this
patch.
- fast/js/regress/script-tests/string-get-by-val-out-of-bounds-insane.js: Added.
(foo):
- fast/js/regress/script-tests/string-get-by-val-out-of-bounds.js: Added.
(foo):
- fast/js/regress/string-get-by-val-out-of-bounds-expected.txt: Added.
- fast/js/regress/string-get-by-val-out-of-bounds-insane-expected.txt: Added.
- fast/js/regress/string-get-by-val-out-of-bounds-insane.html: Added.
- fast/js/regress/string-get-by-val-out-of-bounds.html: Added.
- 8:31 PM Changeset in webkit [151884] by
-
- 5 edits in tags/Safari-537.46.5/Source
“Versioning.”
- 8:28 PM Changeset in webkit [151883] by
-
- 1 copy in tags/Safari-537.46.5
New tag.
- 6:42 PM Changeset in webkit [151882] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: GC's put_by_id transition fixpoint should converge more quickly
https://bugs.webkit.org/show_bug.cgi?id=117912
Reviewed by Mark Hahnenberg.
This was a rookie mistake. The GC does a classic forward data flow fixpoint. These work well so long as you
iterate the program in program order, or at least something close to program order. Because I enjoy reverse
loops ("while (n--) blah"), I ended up iterating in *reverse* of program order which ensured worst-case
pathologies every single time. And unsurprisingly, this slowed down a program, namely pdfjs.
Flipping the loops to iterate forward fixes a 90% regression in Octane/pdfjs and is otherwise neutral.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::propagateTransitions):
- 4:33 PM Changeset in webkit [151881] by
-
- 2 edits in trunk/Source/WebKit2
Slightly reduce width threshold on detection of primary snapshotted Plug-In
https://bugs.webkit.org/show_bug.cgi?id=117914
<rdar://problem/14136687>
Reviewed by Simon Fraser.
We've noticed some content that should be detected as the primary snapshotted plug-in,
but is just a bit smaller than our 450x300 minimum threshold. Reduce the width to 400.
- WebProcess/WebPage/WebPage.cpp: Change primarySnapshottedPlugInMinimumWidth from 450 to 400.
- 4:16 PM Changeset in webkit [151880] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r151878.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::startLoading): Pass the new UseDefaultOriginRestrictionsForType
argument to the ResourceLoaderOptions constructor.
- 1:29 PM Changeset in webkit [151879] by
-
- 2 edits in trunk/Source/WebCore
Followup from r151877 .
Fix crash in fast/frames/iframe-access-screen-of-deleted.html by null-checking the widget.
- platform/mac/PlatformScreenMac.mm:
(WebCore::screenForWidget):
- 12:56 PM Changeset in webkit [151878] by
-
- 14 edits3 adds in trunk
[CSS Shapes] limit shape image values to same origin
https://bugs.webkit.org/show_bug.cgi?id=117610
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Restrict the image URL values for shape-inside and shape-outside to
the same origin as the document. The alpha channel of image shape values
will be thresholded to produce the shape's boundaries (see bug 116643)
so normal image access rules aren't secure enough.
Added a RequestOriginPolicy ResourceLoaderOption which is used by
StyleResolver::loadPendingShapeImage() to request the additional restriction.
The change should have no other effect although it does enable one to apply
the same restriction to other resources which can currently be loaded from
any origin - see CachedResourceLoader::canRequest().
Test: http/tests/security/shape-inside-image-origin.html
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage): Add an effectively optional ResourceLoaderOptions parameter.
- css/CSSImageValue.h:
(WebCore::CSSImageValue::cachedImage): Ditto.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingShapeImage): Load the image with the default CachedResourceLoader options plus RestrictToSameOrigin.
(WebCore::StyleResolver::loadPendingImages): Call loadPendingShapeImage().
- css/StyleResolver.h:
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource): Update the ResourceLoaderOptions static variable.
- loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader): Ditto.
- loader/ResourceLoader.h:
(WebCore::ResourceLoader::options):
- loader/ResourceLoaderOptions.h: Add RequestOriginPolicy enum.
(WebCore::ResourceLoaderOptions::ResourceLoaderOptions):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest): Pass ResourceLoaderOptions along to revised CachedResourceLoader::canRequest().
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet): Update load() ResourceLoaderOptions.
(WebCore::CachedResourceLoader::canRequest): Replaced ContentSecurityPolicyCheck parameter with ResourceLoaderOptions.
(WebCore::CachedResourceLoader::requestResource): Pass ResourceLoaderOptions along to revised CachedResourceLoader::canRequest().
(WebCore::CachedResourceLoader::defaultCachedResourceOptions): Added UseDefaultOriginRestrictionsForType initializer.
- loader/cache/CachedResourceLoader.h:
- loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading): Added UseDefaultOriginRestrictionsForType intializer.
LayoutTests:
Verify that a non same-origin image URL specified for shape-inside or
shape-outside will not load and the shape property will be reset to "none".
- http/tests/resources/square100.png: Added.
- http/tests/security/shape-inside-image-origin-expected.txt: Added.
- http/tests/security/shape-inside-image-origin.html: Added.
- 12:41 PM Changeset in webkit [151877] by
-
- 11 edits1 add in trunk/Source
screen.availWidth always returns width of primary display
https://bugs.webkit.org/show_bug.cgi?id=117863
Source/WebCore:
Reviewed by Geoffrey Garen.
In WebKit2, Widgets have no platformWidget, so trying to get to the
NSScreen via the platform widget's window never succeeded, and we always
fell back on getting info for the main display.
However, we were already pushing the WKView's displayID down to the
WebProcess for the requestAnimationFrame infrastructure, so use that.
Add a virtual function on Widget windowDisplayID(), that is overridden
in FrameView to return the PlatformDisplayID which Page has.
Fix PlatformScreenMac to fall back to Widget::windowDisplayID() when it fails
to get an NSWindow from the Widget.
Add a utility category on NSScreen to get an NSScreen's displayID, and to
find an NSScreen given a displayID.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- page/FrameView.cpp:
(WebCore::FrameView::windowDisplayID):
- page/FrameView.h:
- platform/Widget.cpp:
(WebCore::Widget::windowDisplayID):
- platform/Widget.h:
- platform/mac/PlatformScreenMac.h: Added.
- platform/mac/PlatformScreenMac.mm:
(+[NSScreen screenForDislayID:]):
(-[NSScreen displayID]):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
- platform/mac/WidgetMac.mm:
(WebCore::Widget::windowDisplayID):
Source/WebKit2:
Reviewed by Geoffrey Garen.
In WebKit2, Widgets have no platformWidget, so trying to get to the
NSScreen via the platform widget's window never succeeded, and we always
fell back on getting info for the main display.
However, we were already pushing the WKView's displayID down to the
WebProcess for the requestAnimationFrame infrastructure, so use that.
The WebProcess would not receive a displayID for a WKView until the window
was activated; fix by calling -doWindowDidChangeScreen when the view
moves to a window, rather than doing it from -_windowDidBecomeKey:.
- UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidBecomeKey:]):
Jun 21, 2013:
- 10:56 PM Changeset in webkit [151876] by
-
- 4 edits3 adds in branches/dfgFourthTier
fourthTier: DFG should CSE MakeRope
https://bugs.webkit.org/show_bug.cgi?id=117905
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
Adds MakeRope to the CSE phase and removes the comment that says that
we could do it but aren't doing it.
Also fixed SpeculatedType dumping so that if you have a Cell type then
it just prints "Cell" and if you just have Object then it just prints
"Object", instead of printing the long list of types.
- bytecode/SpeculatedType.cpp:
(JSC::dumpSpeculation):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
LayoutTests:
Reviewed by Geoffrey Garen.
This benchmark speeds up by 50%.
- fast/js/regress/make-rope-cse-expected.txt: Added.
- fast/js/regress/make-rope-cse.html: Added.
- fast/js/regress/script-tests/make-rope-cse.js: Added.
(foo):
- 7:36 PM Changeset in webkit [151875] by
-
- 2 edits in trunk/Source/WebCore
Crashes due to NULL dereference beneath WebCore::StyleResolver::loadPendingSVGDocuments and related functions
https://bugs.webkit.org/show_bug.cgi?id=117903
Reviewed by Darin Adler.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingSVGDocuments): Add a NULL check for
RenderStyle here...
(WebCore::StyleResolver::loadPendingResources): ...and here.
- 7:27 PM Changeset in webkit [151874] by
-
- 7 edits3 adds in branches/dfgFourthTier
fourthTier: DFG should't exit just because it GetByVal'd a big character
https://bugs.webkit.org/show_bug.cgi?id=117899
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
Add a slow path. Also clarify handling of GetByVal in PutStructure elimination.
Previously it would fail due to canExit() but now we can also fail because
GetByVal(String) can allocate. Just make it so GetByVal is totally poisoned, in
a very explicit way.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::putStructureStoreElimination):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
LayoutTests:
Reviewed by Mark Hahnenberg.
This benchmark speeds up by 3x.
- fast/js/regress/script-tests/string-get-by-val-big-char.js: Added.
(foo):
- fast/js/regress/string-get-by-val-big-char-expected.txt: Added.
- fast/js/regress/string-get-by-val-big-char.html: Added.
- 6:10 PM Changeset in webkit [151873] by
-
- 2 edits in trunk/Source/WebCore
Occasional crash swiping between pages
https://bugs.webkit.org/show_bug.cgi?id=117902
Reviewed by Beth Dakin.
m_scrollingStateTree->rootStateNode() can be null when quickly swiping between pages,
so check this in ScrollingCoordinatorMac::commitTreeState().
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::commitTreeState):
- 5:25 PM Changeset in webkit [151872] by
-
- 2 edits in trunk/Tools
[Windows] Unreviewed crash protection for DRT
- DumpRenderTree/win/AccessibilityUIElementWin.cpp: Check for null elements in routines
to avoid crashing during test runs.
- 5:13 PM Changeset in webkit [151871] by
-
- 2 edits in branches/dfgFourthTier/Source/WebCore
Fixed broken build: updated to match SmallStrings changes in r151864.
Not reviewed.
No new tests.
- bindings/js/JSDOMBinding.h:
(WebCore::jsStringWithCache):
- 5:08 PM Changeset in webkit [151870] by
-
- 1 edit1 add in trunk/LayoutTests
[Windows] Unreviewed gardening.
- platform/win/accessibility/aria-menubar-menuitems-expected.txt: Added.
- 4:58 PM Changeset in webkit [151869] by
-
- 11 edits1 add in trunk
Source/JavaScriptCore: Introducing the VMStackBounds class.
https://bugs.webkit.org/show_bug.cgi?id=117862.
Reviewed by Geoffrey Garen.
- Removed Interpreter::StackPolicy.
- The new VMStackBounds will take over choosing the appropriate stack size requirements, and invoking the underlying WTF::StackBounds to to the real bounds check.
- VMStackBounds will now be used universally throughout JSC instead of WTF::StackBounds.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- bytecompiler/BytecodeGenerator.h:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
- interpreter/Interpreter.h:
(JSC::Interpreter::isInErrorHandlingMode):
- parser/Parser.cpp:
(JSC::::Parser):
- parser/Parser.h:
- runtime/StringRecursionChecker.h:
(JSC::StringRecursionChecker::performCheck):
- runtime/VMStackBounds.h: Added.
(JSC::VMStackBounds::VMStackBounds):
(JSC::VMStackBounds::isSafeToRecurse):
(JSC::VMStackBounds::requiredCapacity):
LayoutTests: Reverting failure expectation for fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html.
https://bugs.webkit.org/show_bug.cgi?id=117862.
Reviewed by Geoffrey Garen.
- platform/mac/TestExpectations:
- 4:39 PM Changeset in webkit [151868] by
-
- 3 edits3 adds in trunk
AX: Title for ListItemRole should consist of concatenated child text elements.
https://bugs.webkit.org/show_bug.cgi?id=117892
Reviewed by Chris Fleizach.
Source/WebCore:
accessibility/listitem-title.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::visibleText): Add ListItemRole to set of
elements that concatenate their children for display purposes.
(WebCore::AccessibilityNodeObject::title): Ditto.
LayoutTests:
- accessibility/listitem-title.html: Added.
- platform/mac/accessibility/listitem-title-expected.txt: Added.
- platform/win/accessibility/listitem-title-expected.txt: Added.
- 4:28 PM Changeset in webkit [151867] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit
Merged r151847. <rdar://problem/14231905>
- 4:27 PM Changeset in webkit [151866] by
-
- 8 edits in branches/safari-537-branch/Source
Merged r151787. <rdar://problem/14219184>
- 4:23 PM Changeset in webkit [151865] by
-
- 6 edits3 deletes in branches/safari-537-branch/LayoutTests
Merged r151801.
- 4:05 PM Changeset in webkit [151864] by
-
- 8 edits3 adds in branches/dfgFourthTier
fourthTier: Small strings shouldn't get GC'd
https://bugs.webkit.org/show_bug.cgi?id=117897
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
Kill off the code needed to allocate them lazily and finalize them.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
- heap/Heap.cpp:
(JSC::Heap::collect):
- runtime/JSString.h:
(JSC::jsSingleCharacterString):
(JSC::jsSingleCharacterSubstring):
(JSC::jsString):
(JSC::jsSubstring8):
(JSC::jsSubstring):
(JSC::jsOwnedString):
- runtime/NumberPrototype.cpp:
(JSC::integerValueToString):
- runtime/SmallStrings.cpp:
(JSC):
(JSC::SmallStrings::initializeCommonStrings):
(JSC::SmallStrings::visitStrongReferences):
- runtime/SmallStrings.h:
(JSC::SmallStrings::singleCharacterString):
(SmallStrings):
LayoutTests:
Reviewed by Mark Hahnenberg.
This test speeds up by 5%.
- fast/js/regress/script-tests/string-get-by-val.js: Added.
(foo):
- fast/js/regress/string-get-by-val-expected.txt: Added.
- fast/js/regress/string-get-by-val.html: Added.
- 3:50 PM Changeset in webkit [151863] by
-
- 2 edits in trunk/Source/WebCore
[MediaStream]: Remove
>= 0 assertion from a size_t variable
https://bugs.webkit.org/show_bug.cgi?id=117890
Patch by Sergio Correia <Sergio Correia> on 2013-06-21
Reviewed by Adam Barth.
This patch fixes a strict build by removing the
>= 0 assertion from
a size_t (unsigned type) variable in RTCStatsResponse.cpp.
No new tests; build fix.
- Modules/mediastream/RTCStatsResponse.cpp:
(WebCore::RTCStatsResponse::addStatistic): Remove
>=0assertion,
since the variable is unsigned and is always >= 0.
- 3:20 PM Changeset in webkit [151862] by
-
- 5 edits in tags/Safari-537.46.4/Source
Versioning.
- 3:13 PM Changeset in webkit [151861] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught exception when pretty printing WebInspector.Script
https://bugs.webkit.org/show_bug.cgi?id=117893
This was an issue with an earlier refactoring. The sourceCode is a Script,
so replace the non-existent local variable "script" with "this._sourceCode".
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-06-21
Reviewed by Timothy Hatcher.
- UserInterface/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype.textEditorUpdatedFormatting):
- 3:13 PM Changeset in webkit [151860] by
-
- 2 edits in tags/Safari-537.46.4/Source/WebKit
Merged r151847. <rdar://problem/14231905>
- 3:07 PM Changeset in webkit [151859] by
-
- 8 edits in tags/Safari-537.46.4/Source
Merged r151787. <rdar://problem/14219184>
- 2:55 PM Changeset in webkit [151858] by
-
- 2 edits in trunk/Source/WebCore
GraphicsContext3DNEON.h cannot be found on Windows and does not need to be found.
https://bugs.webkit.org/show_bug.cgi?id=117894
Reviewed by Brent Fulgham.
- platform/graphics/GraphicsContext3D.cpp:
Added #if HAVE(ARM_NEON_INTRINSICS) around #include "GraphicsContext3DNEON.h"
- 2:33 PM Changeset in webkit [151857] by
-
- 1 copy in tags/Safari-537.46.4
New Tag.
- 2:27 PM Changeset in webkit [151856] by
-
- 15 edits1 add in branches/dfgFourthTier/Source
fourthTier: Merge r146932 and 146933 so that we can profile from DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=117891
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
Merging the JSC part of these changes required creating a fresh VM to JSONify
the profiler database, because that's the only truly safe way to do it. This
is because we don't really know when the profiler would be asked to dump JSON,
and we might be in the middle of VM shutdown. That's a bug in the ToT version
of this, but we didn't catch it because we didn't have enough assertions to
that effect.
- jsc.cpp:
(jscmain):
- profiler/ProfilerDatabase.cpp:
(Profiler):
(JSC::Profiler::Database::Database):
(JSC::Profiler::Database::~Database):
(JSC::Profiler::Database::toJSON):
(JSC::Profiler::Database::registerToSaveAtExit):
(JSC::Profiler::Database::addDatabaseToAtExit):
(JSC::Profiler::Database::removeDatabaseFromAtExit):
(JSC::Profiler::Database::performAtExitSave):
(JSC::Profiler::Database::removeFirstAtExitDatabase):
(JSC::Profiler::Database::atExitCallback):
- profiler/ProfilerDatabase.h:
(Database):
(JSC::Profiler::Database::databaseID):
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::createContextGroup):
(JSC::VM::create):
(JSC::VM::createLeaked):
(JSC::VM::sharedInstance):
- runtime/VM.h:
(VM):
Source/WTF:
Reviewed by Mark Hahnenberg.
The WTF part of this change is a straight-up merge with nothing interesting.
- GNUmakefile.list.am:
- WTF.gypi:
- WTF.pro:
- WTF.vcproj/WTF.vcproj:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/MetaAllocator.cpp:
(WTF::MetaAllocator::dumpProfile):
- wtf/ProcessID.h: Added.
(WTF):
(WTF::getCurrentProcessID):
- wtf/text/StringImpl.cpp:
(WTF::StringStats::printStats):
- 2:04 PM Changeset in webkit [151855] by
-
- 3 edits2 adds in trunk
Ignoring padding-right of inline elements in containers with undefined width
https://bugs.webkit.org/show_bug.cgi?id=76451
Reviewed by David Hyatt.
Source/WebCore:
Collapsed trailing space on a normal wrap line should not cause a line-break
if it is the difference between fitting on the line and breaking. Likewise, on a line that
has a mix of auto-wrap and no-wrap inlines we don't want a trailing space at the end of a no-wrap inline
to be the difference between that no-wrap inline fitting or breaking the line. This latter
scenario is covered already by inline-whitespace-wrapping-8.html.
Test: fast/text/whitespace/inline-whitespace-wrapping-9.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::fitsOnLine):
(WebCore::LineWidth::fitsOnLineIncludingExtraWidth):
(WebCore::LineWidth::fitsOnLineExcludingTrailingWhitespace):
(WebCore::LineWidth::currentWidth):
(WebCore::LineWidth::fitsOnLineExcludingTrailingCollapsedWhitespace):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
LayoutTests:
- fast/text/whitespace/inline-whitespace-wrapping-9-expected.html: Added.
- fast/text/whitespace/inline-whitespace-wrapping-9.html: Added.
- 1:57 PM Changeset in webkit [151854] by
-
- 8 edits in trunk/Source/WebCore
Added WebGL source files to Windows build and made Windows build successfully with them.
https://bugs.webkit.org/show_bug.cgi?id=117853
Reviewed by Brent Fulgham.
- WebCore.vcxproj/WebCore.vcxproj: Added WebGL source files.
- WebCore.vcxproj/WebCore.vcxproj.filters: Added platform\graphics\opengl and platform\graphics\gpu filters.
- WebCore.vcxproj/WebCorePreBuild.cmd: Copy ANGLE headers and glext.h before building WebCore (which now uses them).
- platform/graphics/ANGLEWebKitBridge.h: Look in newly copied directory for ShaderLang.h.
- platform/graphics/OpenGLShims.h: Include GL/glext.h.
- platform/graphics/gpu/LoopBlinnShader.cpp:
(WebCore::LoopBlinnShader::use): Fixed parameter ordering in call to uniformMatrix4fv.
- platform/graphics/opengl/GLPlatformSurface.cpp:
(WebCore::GLPlatformSurface::createOffScreenSurface): Added notImplemented for non-EGL builds for now.
- 1:37 PM Changeset in webkit [151853] by
-
- 4 edits in trunk/Source/WebCore
Update platform text track menu
https://bugs.webkit.org/show_bug.cgi?id=117884
Reviewed by Jer Noble.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setSelectedTextTrack):
- html/track/TextTrack.cpp:
(WebCore::TextTrack::platformTextTrack):
- platform/graphics/PlatformTextTrack.h:
(WebCore::PlatformTextTrack::create):
(WebCore::PlatformTextTrack::uniqueId):
(WebCore::PlatformTextTrack::captionMenuOffItem):
(WebCore::PlatformTextTrack::captionMenuAutomaticItem):
(WebCore::PlatformTextTrack::PlatformTextTrack):
- 1:21 PM Changeset in webkit [151852] by
-
- 5 edits in trunk
AX: audio/video playback control timers (elapsed and remaining) should be exposed as ApplicationTimerRole
https://bugs.webkit.org/show_bug.cgi?id=117883
Patch by James Craig <james@cookiecrook.com> on 2013-06-21
Reviewed by Chris Fleizach.
Some of the media controls were returning the wrong role. Updated existing test coverage.
Source/WebCore:
- accessibility/AccessibilityMediaControls.h:
(WebCore::AccessibilityMediaTimeDisplay::roleValue):
LayoutTests:
- accessibility/media-element.html:
- platform/mac/accessibility/media-element-expected.txt:
- 12:59 PM Changeset in webkit [151851] by
-
- 1 edit2 adds in trunk/Source/WebCore
Added glext.h from http://www.opengl.org/registry/oldspecs/glext.h for Windows
This file does not meet WebKit style guidelines.
Part of https://bugs.webkit.org/show_bug.cgi?id=117853
Reviewed by Brent Fulgham.
- platform/graphics/win/GL: Added.
- platform/graphics/win/GL/glext.h: Added.
- 12:53 PM WebKitGTK/2.0.x edited by
- Add three more merge proposals for the 2.0.4 release. (diff)
- 12:46 PM Changeset in webkit [151850] by
-
- 5 edits in tags/Safari-537.46.3/Source
Versioning.
- 12:38 PM Changeset in webkit [151849] by
-
- 1 copy in tags/Safari-537.46.3
New Tag.
- 12:25 PM Changeset in webkit [151848] by
-
- 7 edits in branches/dfgFourthTier
Merge trunk r146548.
Source/JavaScriptCore:
2013-03-21 Filip Pizlo <fpizlo@apple.com>
JSC profiler should have an at-a-glance report of the success of DFG optimization
https://bugs.webkit.org/show_bug.cgi?id=112988
Reviewed by Geoffrey Garen.
- dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::handleCall): (JSC::DFG::ByteCodeParser::handleGetById): (JSC::DFG::ByteCodeParser::parseBlock):
- profiler/ProfilerCompilation.cpp: (JSC::Profiler::Compilation::Compilation): (JSC::Profiler::Compilation::toJS):
- profiler/ProfilerCompilation.h: (JSC::Profiler::Compilation::noticeInlinedGetById): (JSC::Profiler::Compilation::noticeInlinedPutById): (JSC::Profiler::Compilation::noticeInlinedCall): (Compilation):
- runtime/CommonIdentifiers.h:
Tools:
2013-03-21 Filip Pizlo <fpizlo@apple.com>
JSC profiler should have an at-a-glance report of the success of DFG optimization
https://bugs.webkit.org/show_bug.cgi?id=112988
Reviewed by Geoffrey Garen.
- Scripts/display-profiler-output:
- 11:47 AM Changeset in webkit [151847] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed. Fix a missing parenthesis in include directory path.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorCommon.props:
- 11:16 AM Changeset in webkit [151846] by
-
- 2 edits in trunk/Source/WebInspectorUI
Stop removing and re-adding breakpoints from the backend on reload.
On reload the sourceCode for breakpoints are nulled out, which fires DisplayLocationDidChange.
Then the sourceCode is reassociated, firing DisplayLocationDidChange again. In these cases we
don't need to update the backend, since nothing really changed.
https://bugs.webkit.org/show_bug.cgi?id=117877
Reviewed by Joseph Pecoraro.
- UserInterface/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype._breakpointDisplayLocationDidChange): Return early when
_ignoreBreakpointDisplayLocationDidChangeEvent is true.
(WebInspector.DebuggerManager.prototype.reset): Set _ignoreBreakpointDisplayLocationDidChangeEvent.
(WebInspector.DebuggerManager.prototype._associateBreakpointsWithSourceCode): Ditto.
- 11:08 AM Changeset in webkit [151845] by
-
- 2 edits in trunk/Source/WebCore
Fix TextTrackCue::cueIndex() to handle the null case of TextTrack::cues(() properly
https://bugs.webkit.org/show_bug.cgi?id=117815
<rdar://problem/14211041>
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-21
Reviewed by Ryosuke Niwa.
This patch adds assert statements to try to catch when
track()->cues() returns a null pointer.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::cueIndex):
- 10:52 AM Changeset in webkit [151844] by
-
- 5 edits in trunk/Source/WebCore
[iOS] Hang drawing captions after pressing the home button while playing a video
https://bugs.webkit.org/show_bug.cgi?id=117882
Reviewed by Eric Carlson.
Instead of rendering in a callback on the main thread, pre-render the captions and pass to the main
thread as a CGImage. As such, rename paintTextTrackRepresentation() to createTextTrackRepresentationImage().
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage): Renamed from
paintTextTrackRepresentation. Now returns an Image object.
- html/shadow/MediaControlElements.h:
- platform/graphics/MediaPlayer.h:
- platform/graphics/TextTrackRepresentation.h:
- 10:42 AM Changeset in webkit [151843] by
-
- 8 edits in trunk/Source/WebCore
[CSS Regions] Move overset compute code from flow thread to named flow thread
https://bugs.webkit.org/show_bug.cgi?id=117835
Patch by Radu Stavila <stavila@adobe.com> on 2013-06-21
Reviewed by Andreas Kling.
Moved computeOversetStateForRegions() and overset() methods from RenderFlowThread to RenderNamedFlowThread.
Added ASSERTS in RenderRegion::regionOversetState and RenderRegion::setRegionOversetState to ensure
the region was created from an element.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeOverflow):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
- rendering/RenderFlowThread.h:
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::computeOversetStateForRegions):
- rendering/RenderNamedFlowThread.h:
(WebCore::RenderNamedFlowThread::overset):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::regionOversetState):
(WebCore::RenderRegion::setRegionOversetState):
- 9:48 AM Changeset in webkit [151842] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r151838.
http://trac.webkit.org/changeset/151838
https://bugs.webkit.org/show_bug.cgi?id=117880
Breaks MediaPlayerPrivateQt on Mac (Requested by carewolf on
#webkit).
- html/HTMLMediaElement.h:
- 9:35 AM Changeset in webkit [151841] by
-
- 6 edits3 adds in trunk
Source/WebCore: [Windows] AX: Radio buttons with "tab" role should describe themselves as tabs
https://bugs.webkit.org/show_bug.cgi?id=117837
Reviewed by Chris Fleizach.
accessibility/aria-tab-role-on-buttons.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canSetSelectedAttribute): Indicate that certain accessibility
types (such as Tabs) can be selected.
- accessibility/AccessibilityNodeObject.h: Signature for canSelectAttribute override.
Source/WebKit/win: [Windows] AX: Radio buttons with "tab" role should describe themselves as tabs.
https://bugs.webkit.org/show_bug.cgi?id=117837
Reviewed by Chris Fleizach.
- AccessibleBase.cpp:
(MSAARole): Don't expose TabRole as a radio button to satisfy buggy screen readers.
LayoutTests: [Windows] AX: Radio buttons with "tab" role should describe themselves as tabs.
https://bugs.webkit.org/show_bug.cgi?id=117837
Reviewed by Chris Fleizach.
- accessibility/aria-tab-role-on-buttons.html: Added.
- accessibility/aria-tab-role-on-buttons-expected.txt: Added.
- platform/win/aria-tab-role-on-buttons-expected.txt: Added.
- 9:12 AM Changeset in webkit [151840] by
-
- 4 edits in trunk/Source/WebCore
Remove unused GesturePinch events
https://bugs.webkit.org/show_bug.cgi?id=117875
Reviewed by Andreas Kling.
The gesturePinch events have not been used for some time, even Chromium
had stop using them before moving out of webkit.
- dom/GestureEvent.cpp:
(WebCore::GestureEvent::create):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
- platform/PlatformEvent.h:
- 9:03 AM Changeset in webkit [151839] by
-
- 13 edits3 moves1 add1 delete in trunk
Improve the reattaching process while applying the :hover style
https://bugs.webkit.org/show_bug.cgi?id=117590
Patch by Radu Stavila <stavila@adobe.com> on 2013-06-21
Reviewed by Andreas Kling.
Source/WebCore:
Changes made:
- context is properly propagated to the element's children and to Shadow DOM elements.
- context is properly set on the lazyReattach method.
- another hit-testing is triggered when needed.
- when a hovered element is detached, it's ancestors are also removed from the hovered state.
Tests: fast/css/hover-display-block-inline.html
fast/css/hover-display-block-none.html
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::attach):
(WebCore::ContainerNode::detach):
- dom/ContainerNode.h:
(WebCore::ContainerNode::attachChildren):
(WebCore::ContainerNode::detachChildrenIfNeeded):
(WebCore::ContainerNode::detachChildren):
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
(WebCore::Document::updateHoverActiveState):
- dom/Element.cpp:
(WebCore::Element::attach):
(WebCore::Element::detach):
- dom/ElementShadow.cpp:
(WebCore::ElementShadow::attach):
(WebCore::ElementShadow::detach):
- dom/ElementShadow.h:
- dom/Node.h:
(WebCore::Node::lazyReattach):
LayoutTests:
Moved hover-display-block-inline.html and hover-display-block-none.html from fast/regions to fast/css.
Updated hover-display-block-none.html and hover-single-flow-into-other.html to ensure the outcome won't be affected by the machine's speed.
Updated input-file-re-render.html to stop it from failing on windows and linux machines (a more detailed description can be found inside the test itself).
- fast/css/hover-display-block-inline-expected.txt: Renamed from LayoutTests/fast/regions/hover-display-block-inline-expected.txt.
- fast/css/hover-display-block-inline.html: Renamed from LayoutTests/fast/regions/hover-display-block-inline.html.
- fast/css/hover-display-block-none-expected.txt: Renamed from LayoutTests/fast/regions/hover-display-block-none-expected.txt.
- fast/css/hover-display-block-none.html: Added.
- fast/css/hover-update-expected.txt:
- fast/css/hover-update.html:
- fast/forms/file/input-file-re-render.html:
- fast/regions/hover-display-block-none.html: Removed.
- fast/regions/hover-single-flow-into-other.html:
- 9:01 AM Changeset in webkit [151838] by
-
- 2 edits in trunk/Source/WebCore
HTMLMediaElement should inherit from MediaPlayerClient privately
https://bugs.webkit.org/show_bug.cgi?id=117874
Reviewed by Andreas Kling.
Fixing FIXME: HTMLMediaElement was stuck with public inheritance from
MediaPlayerClient due to the Chromium port.
This can now be fixed to a private inheritance.
- html/HTMLMediaElement.h:
- 8:58 AM Changeset in webkit [151837] by
-
- 1 edit2 deletes in trunk/Source/WebCore
Remove Chromium-only TouchDisambiguation
https://bugs.webkit.org/show_bug.cgi?id=117873
Reviewed by Andreas Kling.
- page/TouchDisambiguation.cpp: Removed.
- page/TouchDisambiguation.h: Removed.
- 8:45 AM Changeset in webkit [151836] by
-
- 7 edits in trunk
Rollout r150602: Restoring text-overflow vs. floating rendering behaviour.
https://bugs.webkit.org/show_bug.cgi?id=117871
Unreviewed. Rolling out r150602.
Undesirable rendering behaviour.
Patch by Zalan Bujtas <Alan Bujtas> on 2013-06-21
Source/WebCore:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::checkLinesForTextOverflow):
LayoutTests:
- fast/css/text-overflow-ellipsis-behind-floats-expected.html:
- fast/css/text-overflow-ellipsis-behind-floats.html:
- fast/css/text-overflow-ellipsis-full-truncate-rtl-expected.html:
- fast/css/text-overflow-ellipsis-full-truncate-rtl.html:
- 7:31 AM Changeset in webkit [151835] by
-
- 12 edits in trunk
Web Inspector: Integrate new regionOversetChange event into inspector
https://bugs.webkit.org/show_bug.cgi?id=117833
Source/WebCore:
Added the new regionOversetChange event to the WebInspector.
Patch by Radu Stavila <stavila@adobe.com> on 2013-06-21
Reviewed by Joseph Pecoraro.
Tests: inspector/styles/protocol-css-regions-commands.html:
- inspector/Inspector.json:
- inspector/InspectorCSSAgent.cpp:
(WebCore::ChangeRegionOversetTask::ChangeRegionOversetTask):
(WebCore::ChangeRegionOversetTask::scheduleFor):
(WebCore::ChangeRegionOversetTask::unschedule):
(WebCore::ChangeRegionOversetTask::reset):
(WebCore::ChangeRegionOversetTask::onTimer):
(WebCore::InspectorCSSAgent::resetNonPersistentData):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore::InspectorCSSAgent::didChangeRegionOverset):
(WebCore::InspectorCSSAgent::regionOversetChanged):
- inspector/InspectorCSSAgent.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didChangeRegionOversetImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didChangeRegionOverset):
- inspector/front-end/CSSNamedFlowCollectionsView.js:
(WebInspector.CSSNamedFlowCollectionsView.prototype._regionOversetChanged):
(WebInspector.CSSNamedFlowCollectionsView.prototype.wasShown):
(WebInspector.CSSNamedFlowCollectionsView.prototype.willHide):
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype._regionOversetChanged):
(WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
(WebInspector.CSSDispatcher.prototype.regionOversetChanged):
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::dispatchRegionOversetChangeEvent):
LayoutTests:
Tests for the new regionOversetChange event.
Patch by Radu Stavila <stavila@adobe.com> on 2013-06-21
Reviewed by Joseph Pecoraro.
- inspector/styles/protocol-css-regions-commands-expected.txt:
- inspector/styles/protocol-css-regions-commands.html:
- 6:59 AM Changeset in webkit [151834] by
-
- 2 edits in trunk/Source/WebCore
[EFL] NetworkStateNotifierEfl: Use closeWithRetry instead of looping for EINTR on close
https://bugs.webkit.org/show_bug.cgi?id=117872
Patch by Sergio Correia <Sergio Correia> on 2013-06-21
Reviewed by Christophe Dumez.
closeWithRetry works around the Linux behavior of closing the file descriptor
unconditionally even if the close() call is interrupted.
No new tests, no behavior change.
- platform/network/efl/NetworkStateNotifierEfl.cpp:
(WebCore::NetworkStateNotifier::~NetworkStateNotifier): Use closeWithRetry instead of
looping for EINTR on close.
- 4:41 AM Changeset in webkit [151833] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Do not try to load videos in unit tests
https://bugs.webkit.org/show_bug.cgi?id=117866
Reviewed by Philippe Normand.
It makes the tests slower, and generates and error because we use
a fake src.
- UIProcess/API/gtk/tests/TestContextMenu.cpp:
(testContextMenuDefaultMenu): Use preload='none' in video tag.
- UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewMouseTarget): Ditto.
- 3:34 AM Changeset in webkit [151832] by
-
- 33 edits in trunk
REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
https://bugs.webkit.org/show_bug.cgi?id=117825
Reviewed by Kentaro Hara.
Source/WebCore:
Partially revert r150663 so that we use Settings to enable WebAudio instead of
RuntimeEnabledFeatures.
Introduce a new [EnabledBySetting] IDL extended attribute which behaves similarly to
the existing [EnabledAtRuntime] but relies on Settings instead of RuntimeEnabledFeatures
to determine if the feature should be enabled. Make use of this new IDL attribute for
webkitAudioContext interface.
No new tests, no behavior change.
- Modules/webaudio/AudioContext.idl:
- WebCore.exp.in:
- WebCore.order:
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/preprocess-idls.pl:
(GenerateConstructorAttribute):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjTestSubObjEnabledBySettingConstructor):
(WebCore::setJSTestObjTestSubObjEnabledBySettingConstructor):
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj TestSubObjEnabledBySetting]):
(-[DOMTestObj setTestSubObjEnabledBySetting:]):
- bindings/scripts/test/TestObj.idl:
- page/Settings.in:
Source/WebKit/efl:
Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setWebAudioEnabled):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
- ewk/ewk_view.cpp:
(_ewk_view_priv_new):
Source/WebKit/gtk:
Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
Source/WebKit/mac:
Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit/qt:
Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.
- Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
Source/WebKit/win:
Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Source/WebKit2:
Use Settings to enable Web Audio instead of RuntimeEnabledFeatures.
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
DumpRenderTreeSupportEfl::setWebAudioEnabled() now requires an additional view argument.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::overridePreference):
- 3:33 AM Changeset in webkit [151831] by
-
- 6 edits4 moves in trunk
[ATK] Added support for aria-required attribute.
https://bugs.webkit.org/show_bug.cgi?id=117730
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-06-21
Reviewed by Chris Fleizach.
Source/WebCore:
Tests: accessibility/aria-required.html
accessibility/html5-required-attribute.html
The aria-required attribute is used to indicate that user input is required on an
element before a form can be submitted.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(setAtkStateSetFromCoreObject):
Tools:
Added support for testing aria-required attribute.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::isRequired):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isRequired):
LayoutTests:
Moving specific platform accessibility tests.
- accessibility/aria-required-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-required-expected.txt.
- accessibility/aria-required.html: Renamed from LayoutTests/platform/mac/accessibility/aria-required.html.
- accessibility/html5-required-attribute-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/html5-required-attribute-expected.txt.
- accessibility/html5-required-attribute.html: Renamed from LayoutTests/platform/mac/accessibility/html5-required-attribute.html.
- 2:36 AM Changeset in webkit [151830] by
-
- 2 edits in trunk/LayoutTests
IndieUI: Add basic IndieUI infrastructure
https://bugs.webkit.org/show_bug.cgi?id=117367
Unreviewed. Update Lion expected results.
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
- 1:55 AM Changeset in webkit [151829] by
-
- 2 edits in trunk/Source/WebCore
IndieUI: Add basic IndieUI infrastructure
https://bugs.webkit.org/show_bug.cgi?id=117367
Unreviewed. Revert erroneous file that was included accidentally.
- accessibility/AccessibilityNodeObject.h:
- 1:52 AM Changeset in webkit [151828] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][EFL]: Invalidate the ProcessLauncher when the process is terminated before it has finished launching
https://bugs.webkit.org/show_bug.cgi?id=117865
Patch by Sergio Correia <Sergio Correia> on 2013-06-21
Reviewed by Christophe Dumez.
Original patch from Carlos Garcia Campos for the Gtk port.
- UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::ProcessLauncher::terminateProcess): If process is still
launching, just invalidate the launcher. Reset the process
identifier after killing the process.
- 1:51 AM Changeset in webkit [151827] by
-
- 25 edits2 copies9 adds in trunk
IndieUI: Add basic IndieUI infrastructure
https://bugs.webkit.org/show_bug.cgi?id=117367
Reviewed by Ryosuke Niwa.
Source/WebCore:
IndieUI is a new W3C spec that aims to abstract the connection between input and action, so that
a user (possibly using assistive technologies like a screen reader) does not need a specific kind
of device (like a mouse) to interact with an object.
http://www.w3.org/WAI/IndieUI/
This initial patch adds in the basic support for UIRequestEvent and the uiactions attribute.
It modifies the config files to enable and build this feature.
Tests: indieui/create-uirequestevent.html
indieui/uiactions.html
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- GNUmakefile.am:
- Modules/indieui: Added.
- Modules/indieui/UIRequestEvent.cpp: Added.
(WebCore::UIRequestEventInit::UIRequestEventInit):
(WebCore::UIRequestEvent::create):
(WebCore::UIRequestEvent::UIRequestEvent):
(WebCore::UIRequestEvent::~UIRequestEvent):
(WebCore::UIRequestEvent::interfaceName):
(WebCore::UIRequestEventDispatchMediator::UIRequestEventDispatchMediator):
(WebCore::UIRequestEventDispatchMediator::event):
(WebCore::UIRequestEventDispatchMediator::dispatchEvent):
- Modules/indieui/UIRequestEvent.h: Added.
(WebCore::UIRequestEvent::receiver):
(WebCore::UIRequestEventDispatchMediator::create):
- Modules/indieui/UIRequestEvent.idl: Added.
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AccessibilityNodeObject.h:
- dom/Element.cpp:
(WebCore::Element::setUIActions):
(WebCore::Element::UIActions):
- dom/Element.h:
- dom/Element.idl:
- dom/Event.cpp:
(WebCore::EventInit::EventInit):
- dom/Event.h:
- dom/EventNames.in:
- dom/Node.cpp:
(WebCore::Node::dispatchUIRequestEvent):
- dom/Node.h:
- dom/UIEvent.cpp:
(WebCore::UIEventInit::UIEventInit):
- dom/UIEvent.h:
- html/HTMLAttributeNames.in:
LayoutTests:
- fast/js/dom-static-property-for-in-iteration-expected.txt:
- fast/js/global-constructors-attributes-expected.txt:
- indieui: Added.
- indieui/create-uirequestevent-expected.txt: Added.
- indieui/create-uirequestevent.html: Added.
- indieui/uiactions-expected.txt: Added.
- indieui/uiactions.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- platform/qt/fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
- platform/win/TestExpectations:
- platform/win/fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
- 1:07 AM Changeset in webkit [151826] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Migrate WebKitWebResource to GTask
https://bugs.webkit.org/show_bug.cgi?id=117152
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/WebKitWebResource.cpp:
(resourceDataCallback):
(webkit_web_resource_get_data):
(webkit_web_resource_get_data_finish):
- 12:08 AM WebKitGTK/2.0.x edited by
- Add two proposed patches for 2.0.4. (diff)
