Timeline



Jun 26, 2013:

11:21 PM Changeset in webkit [152080] by Christophe Dumez
  • 99 edits
    26 moves in trunk/Source

Rename WorkerContext to WorkerGlobalScope
​https://bugs.webkit.org/show_bug.cgi?id=118059

Reviewed by Kentaro Hara.

Source/WebCore:

Rename WorkerContext / SharedWorkerContext / DedicatedWorkerContext to
WorkerGlobalScope / SharedWorkerGlobalScope / DedicatedWorkerGlobalScope
to match the latest specification:
​http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#workerglobalscope

Those interfaces have [NoInterfaceObject] IDL extended attribute so the
name did not matter much so far. However, the specification was updated
and [NoInterfaceObject] was removed. We should therefore rename those
interfaces as a preparation for this change.

No new tests, no behavior change as these interfaces are not exposed to
JavaScript yet.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Modules/filesystem/WorkerGlobalScopeFileSystem.cpp: Renamed from Source/WebCore/Modules/filesystem/WorkerContextFileSystem.cpp.

(WebCore::WorkerGlobalScopeFileSystem::webkitRequestFileSystem):
(WebCore::WorkerGlobalScopeFileSystem::webkitRequestFileSystemSync):
(WebCore::WorkerGlobalScopeFileSystem::webkitResolveLocalFileSystemURL):
(WebCore::WorkerGlobalScopeFileSystem::webkitResolveLocalFileSystemSyncURL):

  • Modules/filesystem/WorkerGlobalScopeFileSystem.h: Renamed from Source/WebCore/Modules/filesystem/WorkerContextFileSystem.h.
  • Modules/filesystem/WorkerGlobalScopeFileSystem.idl: Renamed from Source/WebCore/Modules/filesystem/WorkerContextFileSystem.idl.
  • Modules/indexeddb/IDBFactory.cpp:
  • Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp: Renamed from Source/WebCore/Modules/indexeddb/WorkerContextIndexedDatabase.cpp.

(WebCore::WorkerGlobalScopeIndexedDatabase::WorkerGlobalScopeIndexedDatabase):
(WebCore::WorkerGlobalScopeIndexedDatabase::~WorkerGlobalScopeIndexedDatabase):
(WebCore::WorkerGlobalScopeIndexedDatabase::supplementName):
(WebCore::WorkerGlobalScopeIndexedDatabase::from):
(WebCore::WorkerGlobalScopeIndexedDatabase::indexedDB):

  • Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.h: Renamed from Source/WebCore/Modules/indexeddb/WorkerContextIndexedDatabase.h.
  • Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.idl: Renamed from Source/WebCore/Modules/indexeddb/WorkerContextIndexedDatabase.idl.
  • Modules/notifications/Notification.cpp:
  • Modules/notifications/NotificationCenter.cpp:
  • Modules/notifications/WorkerGlobalScopeNotifications.cpp: Renamed from Source/WebCore/Modules/notifications/WorkerContextNotifications.cpp.

(WebCore::WorkerGlobalScopeNotifications::WorkerGlobalScopeNotifications):
(WebCore::WorkerGlobalScopeNotifications::~WorkerGlobalScopeNotifications):
(WebCore::WorkerGlobalScopeNotifications::supplementName):
(WebCore::WorkerGlobalScopeNotifications::from):
(WebCore::WorkerGlobalScopeNotifications::webkitNotifications):

  • Modules/notifications/WorkerGlobalScopeNotifications.h: Renamed from Source/WebCore/Modules/notifications/WorkerContextNotifications.h.
  • Modules/notifications/WorkerGlobalScopeNotifications.idl: Renamed from Source/WebCore/Modules/notifications/WorkerContextNotifications.idl.
  • Modules/webdatabase/DatabaseContext.cpp:

(WebCore::DatabaseContext::allowDatabaseAccess):
(WebCore::DatabaseContext::databaseExceededQuota):

  • Modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp: Renamed from Source/WebCore/Modules/webdatabase/WorkerContextWebDatabase.cpp.

(WebCore::WorkerGlobalScopeWebDatabase::openDatabase):
(WebCore::WorkerGlobalScopeWebDatabase::openDatabaseSync):

  • Modules/webdatabase/WorkerGlobalScopeWebDatabase.h: Renamed from Source/WebCore/Modules/webdatabase/WorkerContextWebDatabase.h.

(WebCore::WorkerGlobalScopeWebDatabase::WorkerGlobalScopeWebDatabase):
(WebCore::WorkerGlobalScopeWebDatabase::~WorkerGlobalScopeWebDatabase):

  • Modules/webdatabase/WorkerGlobalScopeWebDatabase.idl: Renamed from Source/WebCore/Modules/webdatabase/WorkerContextWebDatabase.idl.
  • Modules/websockets/ThreadableWebSocketChannel.cpp:

(WebCore::ThreadableWebSocketChannel::create):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasksCallback):

  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):
(WebCore::workerGlobalScopeDidSend):
(WebCore::WorkerThreadableWebSocketChannel::Peer::send):
(WebCore::workerGlobalScopeDidGetBufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::bufferedAmount):
(WebCore::workerGlobalScopeDidConnect):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didConnect):
(WebCore::workerGlobalScopeDidReceiveMessage):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessage):
(WebCore::workerGlobalScopeDidReceiveBinaryData):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveBinaryData):
(WebCore::workerGlobalScopeDidUpdateBufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didUpdateBufferedAmount):
(WebCore::workerGlobalScopeDidStartClosingHandshake):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake):
(WebCore::workerGlobalScopeDidClose):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
(WebCore::workerGlobalScopeDidReceiveMessageError):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessageError):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::create):
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::~WorkerGlobalScopeDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::WorkerGlobalScopeDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::waitForMethodCompletion):

  • Modules/websockets/WorkerThreadableWebSocketChannel.h:

(WebCore::WorkerThreadableWebSocketChannel::create):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::create):

  • Target.pri:
  • UseJSC.cmake:
  • WebCore.order:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/cpp/WebDOMEventTarget.cpp:

(toWebKit):

  • bindings/cpp/WebDOMEventTarget.h:
  • bindings/generic/ActiveDOMCallback.cpp:
  • bindings/js/DOMRequestState.h:

(WebCore::DOMRequestState::DOMRequestState):

  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::scriptExecutionContext):
(WebCore::toJSDOMGlobalObject):

  • bindings/js/JSDedicatedWorkerGlobalScopeCustom.cpp: Renamed from Source/WebCore/bindings/js/JSDedicatedWorkerContextCustom.cpp.

(WebCore::JSDedicatedWorkerGlobalScope::postMessage):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSEventTargetCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSWorkerGlobalScopeBase.cpp: Renamed from Source/WebCore/bindings/js/JSWorkerContextBase.cpp.

(WebCore::JSWorkerGlobalScopeBase::JSWorkerGlobalScopeBase):
(WebCore::JSWorkerGlobalScopeBase::finishCreation):
(WebCore::JSWorkerGlobalScopeBase::destroy):
(WebCore::JSWorkerGlobalScopeBase::scriptExecutionContext):
(WebCore::toJS):
(WebCore::toJSDedicatedWorkerGlobalScope):
(WebCore::toJSSharedWorkerGlobalScope):
(WebCore::toJSWorkerGlobalScope):

  • bindings/js/JSWorkerGlobalScopeBase.h: Renamed from Source/WebCore/bindings/js/JSWorkerContextBase.h.

(WebCore::JSWorkerGlobalScopeBase::impl):
(WebCore::JSWorkerGlobalScopeBase::createStructure):

  • bindings/js/JSWorkerGlobalScopeCustom.cpp: Renamed from Source/WebCore/bindings/js/JSWorkerContextCustom.cpp.

(WebCore::JSWorkerGlobalScope::visitChildren):
(WebCore::JSWorkerGlobalScope::getOwnPropertySlotDelegate):
(WebCore::JSWorkerGlobalScope::getOwnPropertyDescriptorDelegate):
(WebCore::JSWorkerGlobalScope::importScripts):
(WebCore::JSWorkerGlobalScope::setTimeout):
(WebCore::JSWorkerGlobalScope::setInterval):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::startForWorkerGlobalScope):
(WebCore::ScriptProfiler::stopForWorkerGlobalScope):

  • bindings/js/ScriptProfiler.h:
  • bindings/js/ScriptState.cpp:

(WebCore::scriptStateFromWorkerGlobalScope):

  • bindings/js/ScriptState.h:
  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::~WorkerScriptController):
(WebCore::WorkerScriptController::initScript):
(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::setException):
(WebCore::WorkerScriptController::forbidExecution):
(WebCore::WorkerScriptController::isExecutionForbidden):
(WebCore::WorkerScriptController::disableEval):
(WebCore::WorkerScriptController::attachDebugger):
(WebCore::WorkerScriptController::detachDebugger):

  • bindings/js/WorkerScriptController.h:

(WebCore::WorkerScriptController::workerGlobalScopeWrapper):
(WebCore::WorkerScriptController::initScriptIfNeeded):

  • bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
(WebCore::WorkerScriptDebugServer::removeListener):
(WebCore::WorkerScriptDebugServer::runEventLoopWhilePaused):

  • bindings/js/WorkerScriptDebugServer.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/preprocess-idls.pl:
  • dom/ActiveDOMObject.cpp:
  • dom/EventTarget.h:
  • dom/EventTargetFactory.in:
  • dom/MessagePort.cpp:

(WebCore::MessagePort::dispatchMessages):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::createdMessagePort):
(WebCore::ScriptExecutionContext::destroyedMessagePort):
(WebCore::ScriptExecutionContext::vm):

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::isWorkerGlobalScope):

  • inspector/InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createForWorker):
(WebCore::InjectedScriptManager::canAccessInspectedWorkerGlobalScope):

  • inspector/InjectedScriptManager.h:
  • inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::addMessageToConsole):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didStartWorkerGlobalScopeImpl):
(WebCore::InspectorInstrumentation::willEvaluateWorkerScript):
(WebCore::InspectorInstrumentation::workerGlobalScopeTerminatedImpl):
(WebCore::InspectorInstrumentation::instrumentingAgentsForWorkerGlobalScope):
(WebCore::InspectorInstrumentation::instrumentingAgentsForNonDocumentContext):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didStartWorkerGlobalScope):
(WebCore::InspectorInstrumentation::workerGlobalScopeTerminated):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::WorkerProfilerAgent::WorkerProfilerAgent):
(WebCore::WorkerProfilerAgent::startProfiling):
(WebCore::WorkerProfilerAgent::stopProfiling):
(WebCore::InspectorProfilerAgent::create):

  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorRuntimeAgent.h:
  • inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::proxy):
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::connectToWorkerGlobalScope):
(WebCore::InspectorWorkerAgent::WorkerFrontendChannel::disconnectFromWorkerGlobalScope):
(WebCore::InspectorWorkerAgent::connectToWorker):
(WebCore::InspectorWorkerAgent::disconnectFromWorker):
(WebCore::InspectorWorkerAgent::didStartWorkerGlobalScope):
(WebCore::InspectorWorkerAgent::workerGlobalScopeTerminated):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):

  • inspector/InspectorWorkerAgent.h:
  • inspector/InstrumentingAgents.cpp:

(WebCore::instrumentationForWorkerGlobalScope):

  • inspector/InstrumentingAgents.h:
  • inspector/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::create):
(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::interruptAndDispatchInspectorCommands):
(WebCore::WorkerDebuggerAgent::injectedScriptForEval):

  • inspector/WorkerDebuggerAgent.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):

  • inspector/WorkerInspectorController.h:
  • inspector/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
(WebCore::WorkerRuntimeAgent::injectedScriptForEval):
(WebCore::WorkerRuntimeAgent::pauseWorkerGlobalScope):

  • inspector/WorkerRuntimeAgent.h:

(WebCore::WorkerRuntimeAgent::create):

  • loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoader::create):
(WebCore::ThreadableLoader::loadResourceSynchronously):

  • loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
(WebCore::WorkerThreadableLoader::loadResourceSynchronously):
(WebCore::workerGlobalScopeDidSendData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
(WebCore::workerGlobalScopeDidReceiveResponse):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
(WebCore::workerGlobalScopeDidReceiveData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
(WebCore::workerGlobalScopeDidFinishLoading):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
(WebCore::workerGlobalScopeDidFail):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
(WebCore::workerGlobalScopeDidFailAccessControlCheck):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFailAccessControlCheck):
(WebCore::workerGlobalScopeDidFailRedirectCheck):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):

  • loader/WorkerThreadableLoader.h:

(WebCore::WorkerThreadableLoader::create):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::removeRequestFromCache):

  • platform/blackberry/LocalFileSystemBlackBerry.cpp:

(WebCore::openFileSystem):
(WebCore::LocalFileSystem::deleteFileSystem):

  • platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp:

(WebCore::WorkerAsyncFileSystemBlackBerry::WorkerAsyncFileSystemBlackBerry):
(WebCore::WorkerAsyncFileSystemBlackBerry::openFileSystem):
(WebCore::WorkerAsyncFileSystemBlackBerry::deleteFileSystem):

  • platform/blackberry/WorkerAsyncFileSystemBlackBerry.h:

(WebCore::WorkerAsyncFileSystemBlackBerry::create):

  • platform/blackberry/WorkerAsyncFileWriterBlackBerry.h:
  • platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.cpp:

(WebCore::WorkerPlatformAsyncFileSystemCallbacks::postTaskToWorkerThread):

  • platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.h:
  • platform/blackberry/WorkerPlatformFileWriterClient.cpp:

(WebCore::WorkerPlatformFileWriterClient::postTaskToWorkerThreadIfNeeded):

  • platform/blackberry/WorkerPlatformFileWriterClient.h:
  • workers/DedicatedWorkerGlobalScope.cpp: Renamed from Source/WebCore/workers/DedicatedWorkerContext.cpp.

(WebCore::DedicatedWorkerGlobalScope::create):
(WebCore::DedicatedWorkerGlobalScope::DedicatedWorkerGlobalScope):
(WebCore::DedicatedWorkerGlobalScope::~DedicatedWorkerGlobalScope):
(WebCore::DedicatedWorkerGlobalScope::interfaceName):
(WebCore::DedicatedWorkerGlobalScope::postMessage):
(WebCore::DedicatedWorkerGlobalScope::importScripts):
(WebCore::DedicatedWorkerGlobalScope::thread):

  • workers/DedicatedWorkerGlobalScope.h: Renamed from Source/WebCore/workers/DedicatedWorkerContext.h.
  • workers/DedicatedWorkerGlobalScope.idl: Renamed from Source/WebCore/workers/DedicatedWorkerContext.idl.
  • workers/DedicatedWorkerThread.cpp:

(WebCore::DedicatedWorkerThread::createWorkerGlobalScope):
(WebCore::DedicatedWorkerThread::runEventLoop):

  • workers/DedicatedWorkerThread.h:
  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::SharedWorkerProxy::workerGlobalScopeClosed):
(WebCore::SharedWorkerProxy::workerGlobalScopeDestroyed):
(WebCore::SharedWorkerConnectTask::performTask):
(WebCore::SharedWorkerScriptLoader::notifyFinished):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):

  • workers/SharedWorkerGlobalScope.cpp: Renamed from Source/WebCore/workers/SharedWorkerContext.cpp.

(WebCore::createConnectEvent):
(WebCore::SharedWorkerGlobalScope::create):
(WebCore::SharedWorkerGlobalScope::SharedWorkerGlobalScope):
(WebCore::SharedWorkerGlobalScope::~SharedWorkerGlobalScope):
(WebCore::SharedWorkerGlobalScope::interfaceName):
(WebCore::SharedWorkerGlobalScope::thread):
(WebCore::SharedWorkerGlobalScope::logExceptionToConsole):

  • workers/SharedWorkerGlobalScope.h: Renamed from Source/WebCore/workers/SharedWorkerContext.h.

(WebCore::SharedWorkerGlobalScope::name):

  • workers/SharedWorkerGlobalScope.idl: Renamed from Source/WebCore/workers/SharedWorkerContext.idl.
  • workers/SharedWorkerThread.cpp:

(WebCore::SharedWorkerThread::createWorkerGlobalScope):

  • workers/SharedWorkerThread.h:
  • workers/Worker.cpp:

(WebCore::Worker::Worker):
(WebCore::Worker::postMessage):
(WebCore::Worker::terminate):
(WebCore::Worker::notifyFinished):

  • workers/Worker.h:
  • workers/WorkerGlobalScope.cpp: Renamed from Source/WebCore/workers/WorkerContext.cpp.

(WebCore::CloseWorkerGlobalScopeTask::create):
(WebCore::CloseWorkerGlobalScopeTask::performTask):
(WebCore::CloseWorkerGlobalScopeTask::isCleanupTask):
(WebCore::WorkerGlobalScope::WorkerGlobalScope):
(WebCore::WorkerGlobalScope::~WorkerGlobalScope):
(WebCore::WorkerGlobalScope::applyContentSecurityPolicyFromString):
(WebCore::WorkerGlobalScope::scriptExecutionContext):
(WebCore::WorkerGlobalScope::virtualURL):
(WebCore::WorkerGlobalScope::virtualCompleteURL):
(WebCore::WorkerGlobalScope::completeURL):
(WebCore::WorkerGlobalScope::userAgent):
(WebCore::WorkerGlobalScope::disableEval):
(WebCore::WorkerGlobalScope::location):
(WebCore::WorkerGlobalScope::close):
(WebCore::WorkerGlobalScope::navigator):
(WebCore::WorkerGlobalScope::hasPendingActivity):
(WebCore::WorkerGlobalScope::postTask):
(WebCore::WorkerGlobalScope::setTimeout):
(WebCore::WorkerGlobalScope::clearTimeout):
(WebCore::WorkerGlobalScope::clearInspector):
(WebCore::WorkerGlobalScope::setInterval):
(WebCore::WorkerGlobalScope::clearInterval):
(WebCore::WorkerGlobalScope::importScripts):
(WebCore::WorkerGlobalScope::errorEventTarget):
(WebCore::WorkerGlobalScope::logExceptionToConsole):
(WebCore::WorkerGlobalScope::addConsoleMessage):
(WebCore::WorkerGlobalScope::addMessage):
(WebCore::WorkerGlobalScope::addMessageToWorkerConsole):
(WebCore::WorkerGlobalScope::isContextThread):
(WebCore::WorkerGlobalScope::isJSExecutionForbidden):
(WebCore::WorkerGlobalScope::eventTargetData):
(WebCore::WorkerGlobalScope::ensureEventTargetData):
(WebCore::WorkerGlobalScope::Observer::Observer):
(WebCore::WorkerGlobalScope::Observer::~Observer):
(WebCore::WorkerGlobalScope::Observer::stopObserving):
(WebCore::WorkerGlobalScope::registerObserver):
(WebCore::WorkerGlobalScope::unregisterObserver):
(WebCore::WorkerGlobalScope::notifyObserversOfStop):
(WebCore::WorkerGlobalScope::eventQueue):

  • workers/WorkerGlobalScope.h: Renamed from Source/WebCore/workers/WorkerContext.h.

(WebCore::WorkerGlobalScope::isSharedWorkerGlobalScope):
(WebCore::WorkerGlobalScope::isDedicatedWorkerGlobalScope):
(WebCore::WorkerGlobalScope::url):
(WebCore::WorkerGlobalScope::groupSettings):
(WebCore::WorkerGlobalScope::script):
(WebCore::WorkerGlobalScope::clearScript):
(WebCore::WorkerGlobalScope::thread):
(WebCore::WorkerGlobalScope::self):
(WebCore::WorkerGlobalScope::workerInspectorController):
(WebCore::WorkerGlobalScope::optionalNavigator):
(WebCore::WorkerGlobalScope::optionalLocation):
(WebCore::WorkerGlobalScope::isClosing):

  • workers/WorkerGlobalScope.idl: Renamed from Source/WebCore/workers/WorkerContext.idl.
  • workers/WorkerGlobalScopeProxy.h: Renamed from Source/WebCore/workers/WorkerContextProxy.h.

(WebCore::WorkerGlobalScopeProxy::~WorkerGlobalScopeProxy):
(WebCore::WorkerGlobalScopeProxy::PageInspector::~PageInspector):
(WebCore::WorkerGlobalScopeProxy::connectToInspector):
(WebCore::WorkerGlobalScopeProxy::disconnectFromInspector):
(WebCore::WorkerGlobalScopeProxy::sendMessageToInspector):

  • workers/WorkerLoaderProxy.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::MessageWorkerGlobalScopeTask::create):
(WebCore::MessageWorkerGlobalScopeTask::MessageWorkerGlobalScopeTask):
(WebCore::MessageWorkerGlobalScopeTask::performTask):
(WebCore::WorkerGlobalScopeDestroyedTask::create):
(WebCore::WorkerGlobalScopeDestroyedTask::WorkerGlobalScopeDestroyedTask):
(WebCore::WorkerGlobalScopeDestroyedTask::performTask):
(WebCore::WorkerTerminateTask::performTask):
(WebCore::PostMessageToPageInspectorTask::performTask):
(WebCore::WorkerGlobalScopeProxy::create):
(WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
(WebCore::WorkerMessagingProxy::~WorkerMessagingProxy):
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::workerObjectDestroyedInternal):
(WebCore::connectToWorkerGlobalScopeInspectorTask):
(WebCore::WorkerMessagingProxy::connectToInspector):
(WebCore::disconnectFromWorkerGlobalScopeInspectorTask):
(WebCore::WorkerMessagingProxy::disconnectFromInspector):
(WebCore::dispatchOnInspectorBackendTask):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeClosed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyedInternal):
(WebCore::WorkerMessagingProxy::terminateWorkerGlobalScope):

  • workers/WorkerMessagingProxy.h:
  • workers/WorkerObjectProxy.h:
  • workers/WorkerReportingProxy.h:
  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::run):
(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::runCleanupTasks):
(WebCore::WorkerRunLoop::Task::performTask):

  • workers/WorkerRunLoop.h:
  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::loadSynchronously):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::runEventLoop):
(WebCore::WorkerThreadShutdownFinishTask::performTask):
(WebCore::WorkerThreadShutdownStartTask::performTask):
(WebCore::WorkerThread::stop):

  • workers/WorkerThread.h:

(WebCore::WorkerThread::workerGlobalScope):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::usesDashboardBackwardCompatibilityMode):
(WebCore::XMLHttpRequest::responseXML):

Source/WebKit/qt:

Update calls to ScriptExecutionContext::isWorkerContext() as it was
renamed to ScriptExecutionContext::isWorkerGlobalScope().

  • WebCoreSupport/NotificationPresenterClientQt.cpp:

(WebCore::NotificationPresenterClientQt::show):
(WebCore::NotificationPresenterClientQt::toPage):
(WebCore::NotificationPresenterClientQt::toFrame):

11:15 PM Changeset in webkit [152079] by Patrick Gansterer
  • 3 edits in trunk/Source/WebKit/wince

Unreviewed WinCE build fix after r152065.

  • WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::AXStartFrameLoad):
(WebKit::ChromeClientWinCE::AXFinishFrameLoad):

  • WebCoreSupport/ChromeClientWinCE.h:
11:02 PM Changeset in webkit [152078] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Avoid redundant checks for Compositing reasons in RenderLayerCompositor
​https://bugs.webkit.org/show_bug.cgi?id=118114

Patch by Sanjoy Pal <​sanjoy.pal@samsung.com> on 2013-06-26
Reviewed by Anders Carlsson.

A RenderObject can be any one of the Video, Canvas, Plugin or Iframe.
Hence removing the redundant checks.

No new tests as no functionality change.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::reasonsForCompositing):

9:37 PM Changeset in webkit [152077] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Sometimes the Flash Player plugin cannot make outgoing connections
​https://bugs.webkit.org/show_bug.cgi?id=118110
<rdar://problem/14270933>

Patch by Simon Cooper <​scooper@apple.com> on 2013-06-26
Reviewed by Alexey Proskuryakov.

Allow outgoing and incoming UDP data. Tidy up the QuickTime
profile as it gets the UDP ability from the common profile.

  • Resources/PlugInSandboxProfiles/com.apple.QuickTime Plugin.plugin.sb:
  • Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
8:30 PM Changeset in webkit [152076] by fpizlo@apple.com
  • 7 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support hole/OOB PutByVal's
​https://bugs.webkit.org/show_bug.cgi?id=118112

Reviewed by Geoffrey Garen.

Added a common code generator for the out-of-bounds case that is reused by
all contiguous-like arrays (Int32, Double, Contiguous).

This is relatively straight-forward, except that it's the first time that
the FTL has to call DFG operations that take more than two arguments.

  • ftl/FTLAbbreviations.h:

(JSC::FTL::functionType):
(JSC::FTL::buildCall):

  • ftl/FTLAbstractHeapRepository.h:

(FTL):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:

(FTL):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::contiguousPutByValOutOfBounds):
(JSC::FTL::LowerDFGToLLVM::vmCall):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::call):

8:07 PM Changeset in webkit [152075] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Flash Player: deny ipc-posix-sem 59918130
​https://bugs.webkit.org/show_bug.cgi?id=118107
<rdar://problem/14271105>

Patch by Simon Cooper <​scooper@apple.com> on 2013-06-26
Reviewed by Alexey Proskuryakov.

Allow same-sandbox scoped semaphores on Mavericks. Permit the
named semaphore for older releases.

  • Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:
7:50 PM Changeset in webkit [152074] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk/Source

Coordinated Graphics: Separate CoordinatedLayerTreeHost into CoordinatedLayerTreeHost and CompositingCoordinator
​https://bugs.webkit.org/show_bug.cgi?id=104360

Patch by Gwang Yoon Hwang <​ryumiel@company100.net> on 2013-06-26
Reviewed by Noam Rosenthal.

The CoordinatedLayerTreeHost has too many responsibilities. It
implements LayerTreeHost, GraphicsLayerClient,
CoordinatedGraphicsLayerClient, CoordinatedImageBacking::Client,
UpdateAtlas::Client, GraphicsLayerFactory and
WebCustomFilterProgramProxyClient.

This refactoring reduces the responsibilities of CoordinatedLayerTreeHost.

This patch introduces a new class called CompositingCoordinator, which
takes the responsibility of managing compositing resources in
WebProcess.

CoordinatedLayerTreeHost is responsible only for the scheduling and
IPC-specific stuff, which are relevant only for WebKit2.

No new tests, covered by existing tests.

Source/WebCore:

  • CMakeLists.txt:
  • Target.pri:
  • platform/graphics/texmap/coordinated/CompositingCoordinator.cpp: Added.

(WebCore::CompositingCoordinator::create):
(WebCore::CompositingCoordinator::~CompositingCoordinator):
(WebCore::CompositingCoordinator::CompositingCoordinator):
(WebCore::CompositingCoordinator::setRootCompositingLayer):
(WebCore::CompositingCoordinator::sizeDidChange):
(WebCore::CompositingCoordinator::flushPendingLayerChanges):
(WebCore::CompositingCoordinator::syncDisplayState):
(WebCore::CompositingCoordinator::nextAnimationServiceTime):
(WebCore::CompositingCoordinator::clearPendingStateChanges):
(WebCore::CompositingCoordinator::initializeRootCompositingLayerIfNeeded):
(WebCore::CompositingCoordinator::createRootLayer):
(WebCore::CompositingCoordinator::syncLayerState):
(WebCore::CompositingCoordinator::createImageBackingIfNeeded):
(WebCore::CompositingCoordinator::createImageBacking):
(WebCore::CompositingCoordinator::updateImageBacking):
(WebCore::CompositingCoordinator::clearImageBackingContents):
(WebCore::CompositingCoordinator::removeImageBacking):
(WebCore::CompositingCoordinator::flushPendingImageBackingChanges):
(WebCore::CompositingCoordinator::notifyAnimationStarted):
(WebCore::CompositingCoordinator::notifyFlushRequired):
(WebCore::CompositingCoordinator::paintContents):
(WebCore::CompositingCoordinator::createGraphicsLayer):
(WebCore::CompositingCoordinator::deviceScaleFactor):
(WebCore::CompositingCoordinator::pageScaleFactor):
(WebCore::CompositingCoordinator::createUpdateAtlas):
(WebCore::CompositingCoordinator::removeUpdateAtlas):
(WebCore::CompositingCoordinator::visibleContentsRect):
(WebCore::CompositingCoordinator::mainContentsLayer):
(WebCore::CompositingCoordinator::setVisibleContentsRect):
(WebCore::CompositingCoordinator::deviceOrPageScaleFactorChanged):
(WebCore::CompositingCoordinator::detachLayer):
(WebCore::CompositingCoordinator::commitScrollOffset):
(WebCore::CompositingCoordinator::renderNextFrame):
(WebCore::CompositingCoordinator::purgeBackingStores):
(WebCore::CompositingCoordinator::paintToSurface):
(WebCore::CompositingCoordinator::scheduleReleaseInactiveAtlases):
(WebCore::CompositingCoordinator::releaseInactiveAtlasesTimerFired):

  • platform/graphics/texmap/coordinated/CompositingCoordinator.h: Added.

(WebCore::CompositingCoordinator::clearRootLayer):
(WebCore::CompositingCoordinator::rootLayer):
(WebCore::CompositingCoordinator::state):

Source/WebKit2:

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::~CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::setRootCompositingLayer):
(WebKit::CoordinatedLayerTreeHost::invalidate):
(WebKit::CoordinatedLayerTreeHost::forceRepaint):
(WebKit::CoordinatedLayerTreeHost::sizeDidChange):
(WebKit::CoordinatedLayerTreeHost::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHost::renderNextFrame):
(WebKit::CoordinatedLayerTreeHost::purgeBackingStores):
(WebKit::CoordinatedLayerTreeHost::willSyncLayerState):
(WebKit::CoordinatedLayerTreeHost::prepareCustomFilterProxiesForAnimations):
(WebKit::CoordinatedLayerTreeHost::checkCustomFilterProgramProxies):
(WebKit::CoordinatedLayerTreeHost::removeCustomFilterProgramProxy):
(WebKit::CoordinatedLayerTreeHost::didFlushRootLayer):
(WebKit::CoordinatedLayerTreeHost::performScheduledLayerFlush):
(WebKit::CoordinatedLayerTreeHost::createPageOverlayLayer):
(WebKit::CoordinatedLayerTreeHost::paintLayerContents):
(WebKit::CoordinatedLayerTreeHost::commitSceneState):
(WebKit::CoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
(WebKit::CoordinatedLayerTreeHost::graphicsLayerFactory):
(WebKit::CoordinatedLayerTreeHost::scheduleAnimation):
(WebKit::CoordinatedLayerTreeHost::commitScrollOffset):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
  • WebProcess/WebPage/LayerTreeHost.h:
7:48 PM Changeset in webkit [152073] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Silverlight deny ipc-posix-sem LC_Mutex playing Amazon Prime videos
​https://bugs.webkit.org/show_bug.cgi?id=118102
<rdar://problem/14194077>

Patch by Simon Cooper <​scooper@apple.com> on 2013-06-26
Reviewed by Alexey Proskuryakov.

Allow same-sandbox scoped semaphores on Mavericks. Permit the
named semaphore for older releases.

  • Resources/PlugInSandboxProfiles/com.microsoft.SilverlightPlugin.sb:
7:46 PM Changeset in webkit [152072] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Update ColorSync shared memory names in plug-in sandbox profile
​https://bugs.webkit.org/show_bug.cgi?id=118099

Patch by Simon Cooper <​scooper@apple.com> on 2013-06-26
Reviewed by Alexey Proskuryakov.

Update the common profile to use the names used in Mavericks

  • Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
7:11 PM Changeset in webkit [152071] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

[EFL][REGRESSION] Crash after r151540 with debug build
​https://bugs.webkit.org/show_bug.cgi?id=118111

Reviewed by Gyuyoung Kim.

  • ewk/ewk_view.cpp:

(ewk_view_scroll): Fixed ASSERT conditions wrongly refactored.

7:00 PM Changeset in webkit [152070] by kihong.kwon@samsung.com
  • 5 edits
    2 adds in trunk

Vibration cannot be canceled during pattern vibration.
​https://bugs.webkit.org/show_bug.cgi?id=117822

Reviewed by Gyuyoung Kim.

Source/WebCore:

Vibration can not cancel during pattern vibration is working. If resting time which are
even numbers of pattern m_isVibraing will be false and cancel will thus return early.
In addition, m_timerStart needs to be stopped in the cancelVibration().
If cancelVibration() is called right after m_timerStart is fired, timerStartFired
function can be called even if vibration is already canceled because of timing issue of timer.

Test: vibration/cancelVibration-during-pattern-vibrating.html

  • Modules/vibration/Vibration.cpp:

(WebCore::Vibration::vibrate):
(WebCore::Vibration::cancelVibration):
(WebCore::Vibration::suspendVibration):
(WebCore::Vibration::resumeVibration):
(WebCore::Vibration::stopVibration):
(WebCore::Vibration::timerStartFired):
(WebCore::Vibration::timerStopFired):

  • Modules/vibration/Vibration.h:

LayoutTests:

Add a test case for vibration cancelation during pattern vibration.
In addition, restore visibilityState before executing cancelVibration-after-pagevisibility-changed-to-hidden.html.

  • vibration/cancelVibration-after-pagevisibility-changed-to-hidden.html:
  • vibration/cancelVibration-during-pattern-vibrating-expected.txt: Added.
  • vibration/cancelVibration-during-pattern-vibrating.html: Added.
6:08 PM Changeset in webkit [152069] by andersca@apple.com
  • 44 edits in trunk

Deprecate StringImpl::charactersWithNullTermination
​https://bugs.webkit.org/show_bug.cgi?id=118108

Reviewed by Beth Dakin.

Source/WebCore:

Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.

  • html/canvas/WebGLProgram.cpp:

(WebCore::WebGLProgram::cacheActiveAttribLocations):

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::getLinkedFonts):

  • platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • platform/graphics/win/FontCustomPlatformDataCairo.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • platform/graphics/win/IconWin.cpp:

(WebCore::Icon::createIconForFiles):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpCookiesForQuickTime):

  • platform/graphics/wince/FontPlatformData.cpp:

(WebCore::FontPlatformData::FontPlatformData):

  • platform/network/curl/CurlDownload.cpp:

(CurlDownload::moveFileToDestination):

  • platform/network/win/CookieJarWin.cpp:

(WebCore::setCookiesFromDOM):
(WebCore::cookiesForDOM):

  • platform/network/win/DownloadBundleWin.cpp:

(WebCore::DownloadBundle::appendResumeData):
(WebCore::DownloadBundle::extractResumeData):

  • platform/network/win/ResourceHandleWin.cpp:

(WebCore::createInternetHandle):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::fileLoadTimer):

  • platform/sql/SQLiteFileSystem.cpp:

(WebCore::SQLiteFileSystem::openDatabase):

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare):

  • platform/text/win/LocaleWin.cpp:

(WebCore::LCIDFromLocaleInternal):

  • platform/text/win/TextCodecWin.cpp:

(WebCore::TextCodecWin::enumerateSupportedEncodings):

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::getWebLocData):
(WebCore::createGlobalData):
(WebCore::setFileDescriptorData):
(WebCore::getURL):
(WebCore::setCFData):

  • platform/win/ContextMenuWin.cpp:

(WebCore::ContextMenu::createPlatformContextMenuFromItems):

  • platform/win/DragImageWin.cpp:

(WebCore::createDragImageIconForCachedImageFilename):

  • platform/win/FileSystemWin.cpp:

(WebCore::getFindData):
(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::pathByAppendingComponent):
(WebCore::makeAllDirectories):
(WebCore::pathGetFileName):
(WebCore::openTemporaryFile):
(WebCore::openFile):

  • platform/win/MIMETypeRegistryWin.cpp:

(WebCore::mimeTypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):

  • platform/win/PasteboardWin.cpp:

(WebCore::createGlobalImageFileDescriptor):
(WebCore::createGlobalHDropContent):

  • platform/win/PathWalker.cpp:

(WebCore::PathWalker::PathWalker):

  • platform/win/SSLKeyGeneratorWin.cpp:

(WebCore::WebCore::signedPublicKeyAndChallengeString):

  • platform/win/SharedBufferWin.cpp:

(WebCore::SharedBuffer::createWithContentsOfFile):

  • platform/wince/FileSystemWinCE.cpp:

(WebCore::getFileInfo):
(WebCore::fileExists):
(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::makeAllDirectories):
(WebCore::openTemporaryFile):
(WebCore::openFile):

  • plugins/win/PluginDatabaseWin.cpp:

(WebCore::PluginDatabase::getPluginPathsInDirectories):
(WebCore::addMozillaPluginDirectories):
(WebCore::addAdobeAcrobatPluginDirectory):
(WebCore::addJavaPluginDirectory):

  • plugins/win/PluginPackageWin.cpp:

(WebCore::getVersionInfo):
(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::handlePostReadFile):

Source/WebKit/win:

Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.

  • COMPropertyBag.h:

(::GetPropertyInfo):

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::runOpenPanel):

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorFrontendClient::updateWindowTitle):

  • WebDownloadCFNet.cpp:

(WebDownload::didFinish):

  • WebKitSystemBits.cpp:

(WebVolumeFreeSize):

  • WebLocalizableStrings.cpp:

(LocalizedString::operator LPCTSTR):

  • WebView.cpp:

(WebView::setToolTip):

Source/WebKit2:

Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::createServerAndClientIdentifiers):

Source/WTF:

The optimization in String and StringImpl to keep track of whether a string
has a null terminator isn't worth it; in most cases we call charactersWithNullTermination() on
temporary strings which ends up copying strings anyway.

A better solution is to have a charactersWithNullTermination() function that returns a Vector<UChar>,
which is similar to what we have for String::utf8() and String::ascii(). This will be done in a follow-up patch.

  • wtf/text/WTFString.cpp:

(WTF::String::deprecatedCharactersWithNullTermination):

  • wtf/text/WTFString.h:

Tools:

Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(findFontFallback):
(addFontFallbackIfPresent):
(removeFontFallbackIfPresent):

5:59 PM Changeset in webkit [152068] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source

Versioning.

5:52 PM Changeset in webkit [152067] by Lucas Forschler
  • 5 edits in tags/Safari-537.47/Source

Versioning.

5:40 PM Changeset in webkit [152066] by Lucas Forschler
  • 1 copy in tags/Safari-537.47

New Tag.

5:39 PM Changeset in webkit [152065] by roger_fong@apple.com
  • 14 edits
    1 add in trunk/Source

Add an accessibility delegate interface to AppleWin port.
​https://bugs.webkit.org/show_bug.cgi?id=118094.

Reviewed by Brent Fulgham.

  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj:
  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters:
  • Interfaces/AccessibilityDelegate.idl: Added.
  • Interfaces/IWebView.idl:
  • Interfaces/WebKit.idl:
  • WebCoreSupport/WebChromeClient.cpp: Add methods that call into the AccessibilityDelegate.

(WebChromeClient::AXStartFrameLoad):
(WebChromeClient::AXFinishFrameLoad):

  • WebCoreSupport/WebChromeClient.h:
  • WebView.cpp: Add support for setting and getting the AccessibilityDelegate from the WebView.

(WebView::close):
(WebView::setAccessibilityDelegate):
(WebView::accessibilityDelegate):

  • WebView.h:
  • accessibility/win/AXObjectCacheWin.cpp: We call the page client's AXStartFrameLoad and AXFinishFrameLoad methods here, which will in turn call the AccessibilityDelegate's callbacks.

(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):

  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::AXStartFrameLoad):
(WebCore::EmptyChromeClient::AXFinishFrameLoad):

  • page/ChromeClient.h:
5:07 PM Changeset in webkit [152064] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r152020. <rdar://problem/14278229>

5:03 PM Changeset in webkit [152063] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

QuickTime plug-in cannot update com.apple.quicktime.plugin.preferences.plist file
​https://bugs.webkit.org/show_bug.cgi?id=118098
<rdar://problem/13888138>

Patch by Simon Cooper <​scooper@apple.com> on 2013-06-26
Reviewed by Alexey Proskuryakov.

Allow the preference file to be written

  • Resources/PlugInSandboxProfiles/com.apple.QuickTime Plugin.plugin.sb:
4:44 PM Changeset in webkit [152062] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-537-branch

Merged r151998. <rdar://problem/14272548>

4:39 PM Changeset in webkit [152061] by Lucas Forschler
  • 9 edits
    6 copies in branches/safari-537-branch

Merged r151997. <rdar://problem/14223569>

4:34 PM Changeset in webkit [152060] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source/WebCore

Merged r151994. <rdar://problem/14241270>

4:32 PM Changeset in webkit [152059] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r151986. <rdar://problem/14272659>

4:31 PM Changeset in webkit [152058] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r151971. <rdar://problem/12885400>

4:28 PM Changeset in webkit [152057] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/LayoutTests

Merged r151953. <rdar://problem/14248148>

4:28 PM Changeset in webkit [152056] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source/WebKit2

Merged r151952. <rdar://problem/13927918>

4:26 PM Changeset in webkit [152055] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r151950. <rdar://problem/14121247>

4:25 PM Changeset in webkit [152054] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r151948. <rdar://problem/14036864>

4:23 PM Changeset in webkit [152053] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r151944. <rdar://problem/14193693>

4:23 PM Changeset in webkit [152052] by andersca@apple.com
  • 8 edits
    1 add in trunk/Source

Add JSStringCreateWithCharactersNoCopy SPI
​https://bugs.webkit.org/show_bug.cgi?id=118074
<rdar://problem/14279905>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • API/JSStringRef.cpp:

(JSStringCreateWithCharactersNoCopy):
Create a new OpaqueJSString, using the newly added StringImpl::createWithoutCopying function.

  • API/JSStringRefPrivate.h: Added.

Add a home for the JSStringCreateWithCharactersNoCopy function.

  • API/OpaqueJSString.h:

(OpaqueJSString::OpaqueJSString):
Just call isolatedCopy on the passed in string.

  • API/tests/testapi.c:

Add an API test for JSStringCreateWithCharactersNoCopy.

Add new files.

Source/WTF:

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::createFromLiteral):
Use the new ConstructWithoutCopying constructor, passing DoesHaveTerminatingNullCharacter to it.
Change the other createFromLiteral overload to just call the first.

(WTF::StringImpl::createWithoutCopying):
Add helper functions for creating strings that shouldn't copy their underlying data.

  • wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl):
Rename the ConstructFromLiteralTag constructor enum to ConstructWithoutCopyingTag. Change the constructor
to take an enum that states whether the string has a terminating null character or not.

(WTF::StringImpl::createFromLiteral):
Call createWithoutCopying.

(WTF::StringImpl::requiresCopy):
Rename this from isASCIILiteral() and make it more generic so it can handle 16-bit strings as well.

(WTF::StringImpl::isolatedCopy):
If this string doesn't have to be copied, just create a new StringImpl object that references the current data.

4:22 PM Changeset in webkit [152051] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r151943. <rdar://problem/14084234>

4:21 PM Changeset in webkit [152050] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r151941. <rdar://problem/14223823>

4:19 PM Changeset in webkit [152049] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r151940. <rdar://problem/13938149>

4:17 PM Changeset in webkit [152048] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r151939. <rdar://problem/14166577>

4:14 PM Changeset in webkit [152047] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r151938. <rdar://problem/14163582>

4:09 PM Changeset in webkit [152046] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-537-branch

Merged r151934. <rdar://problem/14230128>

4:07 PM Changeset in webkit [152045] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL::canCompile(Graph&) should not consider nodes that won't be compiled
​https://bugs.webkit.org/show_bug.cgi?id=118097

Reviewed by Mark Hahnenberg.

This increases coverage to include programs that have unprofiled paths. Those paths will
often have nodes that appear to do untyped speculations, and the FTL sometimes doesn't
support those; except that it doesn't matter since the reason why they were untyped is
that they were unprofiled and anyway we won't run them because we'll exit before them.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

4:07 PM Changeset in webkit [152044] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r151927. <rdar://problem/14223539>

4:04 PM Changeset in webkit [152043] by Lucas Forschler
  • 25 edits
    11 copies
    3 deletes in branches/safari-537-branch/LayoutTests

Merged r151924. <rdar://problem/14248148>

4:03 PM Changeset in webkit [152042] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebInspectorUI

Merged r151918. <rdar://problem/14244539>

4:02 PM Changeset in webkit [152041] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r151916. <rdar://problem/14246763>

4:00 PM Changeset in webkit [152040] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-537-branch

Merged r151894. <rdar://problem/13008605>

3:56 PM Changeset in webkit [152039] by fpizlo@apple.com
  • 4 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support ArrayifyToStructure
​https://bugs.webkit.org/show_bug.cgi?id=118095

Reviewed by Mark Hahnenberg.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:

(FTL):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArrayifyToStructure):
(LowerDFGToLLVM):

3:51 PM Changeset in webkit [152038] by jer.noble@apple.com
  • 9 edits
    2 adds in trunk

Potential use-after-free after neutering AudioBuffer's underlying ArrayBuffer.
​https://bugs.webkit.org/show_bug.cgi?id=118040

Reviewed by Filip Pizlo.

Source/WebCore:

Test: webaudio/audiobuffer-neuter.html

When creating an AudioBuffer's backing ArrayBufferView objects, mark them as 'unneuterable',
meaning the underlying data will be copied in a neuter scenario rather than transferred. This
means the underlying assumtions of the webaudio code can continue to assume that the memory
areas owned by the ArrayBufferView will be present until the AudioBuffer is itself destroyed.

In order to not expose the 'unneuterable' behavior to JavaScript, return a fresh Float32Array
wrapper around the ArrayBuffer object, rather than our own.

  • Modules/webaudio/AudioBuffer.cpp:

(WebCore::AudioBuffer::AudioBuffer): Mark the newly created channels as not neuterable.
(WebCore::AudioBuffer::getChannelData): Return a new Float32Array object rather than a pointer to our own.

  • Modules/webaudio/AudioBuffer.h:

Source/WTF:

Add support for 'unneuterable' ArrayBufferViews. Views marked as such will have their underlying
ArrayBuffer objects copied rather than transferred to a new view.

  • wtf/ArrayBuffer.cpp:

(WTF::ArrayBuffer::transfer): Check whether the associated views are neuterable, and if not

clone the ArrayBuffer rather than transferring it.

  • wtf/ArrayBuffer.h:

(WTF::ArrayBufferContents::copyTo): Added. Utility function.

  • wtf/ArrayBufferView.cpp:

(WTF::ArrayBufferView::ArrayBufferView):
(WTF::ArrayBufferView::neuter):

  • wtf/ArrayBufferView.h:

(WTF::ArrayBufferView::setNeuterable):
(WTF::ArrayBufferView::isNeuterable):

LayoutTests:

  • webaudio/audiobuffer-neuter.html: Added.
  • webaudio/audiobuffer-neuter-expected.txt: Added.
3:36 PM Changeset in webkit [152037] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Unreviewed build correction after r152035.

  • page/CaptionUserPreferencesMediaAF.cpp: Don't attempt to include CoreText.h if we do not have MediaAccessibility Framework.
3:16 PM Changeset in webkit [152036] by fpizlo@apple.com
  • 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support ForwardCheckStructure/ForwardStructureTransitionWatchpoint and doing so shouldn't break V8/crypto
​https://bugs.webkit.org/show_bug.cgi?id=118091

Reviewed by Mark Hahnenberg.

I was going to just add ForwardCheckStructure/ForwardStructureTransitionWatchpoint support,
which is trivial. But doing so increases coverage a lot, and revealed long-standing bugs in
the FTL. I then fixed those bugs, also:

  • The FTL should not attempt to compile a block that is not reachable according to the CFA. This is analogous to terminating basic block compilation if the CFA becomes !isValid(). Attempting to compile such a block means that you're running on broken CFA state, and the CFA will become inconsistent with the code you're generating, leading to some strangeness. For example, the FTL relies on the CFA to tell it that we gave up compiling a node and hence don't have LValue's for that node (by virtue of us giving up due to !isValid()). But the CFA's isValid() bit will not be set correctly for blocks that weren't visited by the CFA at all, and the CFA expects you to know this because it expects that you already checked BasicBlock::cfaHasVisited.


  • SetLocal needs to change the ValueSource of the operand to indicate that its value has been stashed in the local (i.e. the "reference" corresponding to the operand in FTL speak). This is because although OSR exit already knows that the value of the operand is stored in the Node, and it already knows what LValue corresponds to the node, OSR exit will also assume that if the Node dies then the value-at-exit for that operand should be Dead (i.e. jsUndefined). But the Node dying, and the local dying, are two distinct things; in particular the local always outlives the Node in the case of a SetLocal. So, we just need to have SetLocal have the ValueSource be BlahInLocal rather than HaveNode, to ensure that OSR exit knows that the darn thing is really live until the end of the basic block, as opposed to until whenever the Node dies (which could be at any time).


  • PutByOffset was erroneously storing to an offset from the base object, rather than an offset from the storage. Note that the storage will be the base object (exactly - i.e. same node, same value) for inline stores, but will be a distinct thing for out-of-line stores.


  • At-head set-up of OSR exit state was using ValueInLocals for variables forced double, when it should have been using DoubleInLocals.
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::compilePutByOffset):
(JSC::FTL::LowerDFGToLLVM::initializeOSRExitStateForBlock):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):

3:02 PM Changeset in webkit [152035] by Brent Fulgham
  • 7 edits in trunk/Source

../WebCore: [Windows] Enable CaptionUserPreferencesMediaAF on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=118076

Reviewed by Eric Carlson.

  • WebCore.vcxproj/WebCore.vcxproj: Enable building the CaptionUserPreferencesMediaAF source file.
  • page/CaptionUserPreferencesMediaAF.cpp: Add soft-link commands for CoreText symbols needed in the implementation for Windows.
  • platform/LocalizedStrings.cpp: Enable Text Track-related strings on Windows.
  • platform/LocalizedStrings.h: Ditto.

../WTF: [Windows] Enable CaptionUserPreferenceMediaAF on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=118076

Reviewed by Eric Carlson.

  • wtf/Platform.h: Enable Media Accessibility Framework in Windows build environments that support it.
2:47 PM Changeset in webkit [152034] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r151879. <rdar://problem/13560876>

2:45 PM Changeset in webkit [152033] by Lucas Forschler
  • 11 edits
    1 copy in branches/safari-537-branch/Source

Merged r151877. <rdar://problem/13560876>

2:42 PM Changeset in webkit [152032] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r151881. <rdar://problem/14136687>

2:41 PM Changeset in webkit [152031] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r151875. <rdar://problem/14202130>

2:38 PM Changeset in webkit [152030] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r151873. <rdar://problem/14229987>

2:38 PM Changeset in webkit [152029] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebInspectorUI

Merged r151861. <rdar://problem/14233755>

2:35 PM Changeset in webkit [152028] by Lucas Forschler
  • 5 edits in branches/safari-537-branch

Merged r151852. <rdar://problem/14231548>

2:33 PM Changeset in webkit [152027] by Lucas Forschler
  • 6 edits in branches/safari-537-branch

Merged r151836. <rdar://problem/14043357>

2:26 PM Changeset in webkit [152026] by Lucas Forschler
  • 33 edits in branches/safari-537-branch

Merged r151832. <rdar://problem/14160571>

2:20 PM Changeset in webkit [152025] by Lucas Forschler
  • 4 edits
    2 copies in branches/safari-537-branch

Merged r151822. <rdar://problem/14225079>

2:14 PM Changeset in webkit [152024] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-537-branch

Merged r151821. <rdar://problem/14118228>

2:11 PM Changeset in webkit [152023] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-537-branch

Merged r151812. <rdar://problem/13977070>

2:09 PM Changeset in webkit [152022] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-537-branch

Merged r151807. <rdar://problem/13860717>

2:07 PM Changeset in webkit [152021] by Lucas Forschler
  • 6 edits in branches/safari-537-branch/Source

Merged r151804. <rdar://problem/14063409>

2:04 PM Changeset in webkit [152020] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Speed up SVG sprites by only painting the source rect in SVGImage::draw
​https://bugs.webkit.org/show_bug.cgi?id=118070

Reviewed by Tim Horton.

Merge ​https://chromium.googlesource.com/chromium/blink/+/d359ab67fdd76a877d666dca91c311505dd27bbf.

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw):

2:04 PM Changeset in webkit [152019] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r151803. <rdar://problem/14067600>

2:02 PM Changeset in webkit [152018] by thakis@chromium.org
  • 1 edit
    1 delete in trunk/Tools

Remove detect-mismached-virtual-const.
​https://bugs.webkit.org/show_bug.cgi?id=117999

Reviewed by Anders Carlsson.

Clang warns on mismatched virtual const, so there's no need for this
script any more.

  • Scripts/detect-mismatched-virtual-const: Removed.
2:02 PM Changeset in webkit [152017] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-537-branch

Merged r151796. <rdar://problem/14191593>

1:59 PM Changeset in webkit [152016] by Lucas Forschler
  • 6 edits in branches/safari-537-branch/Source/WebKit2

Merged r151795. <rdar://problem/14112329>

1:59 PM Changeset in webkit [152015] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r151793. <rdar://problem/14212635>

1:58 PM Changeset in webkit [152014] by fpizlo@apple.com
  • 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support PutByVal
​https://bugs.webkit.org/show_bug.cgi?id=118075

Reviewed by Mark Hahnenberg.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):

1:55 PM Changeset in webkit [152013] by Lucas Forschler
  • 9 edits in branches/safari-537-branch

Merged r151776. <rdar://problem/13730458>

1:51 PM Changeset in webkit [152012] by achristensen@apple.com
  • 2 edits
    2 adds in trunk/Tools

Added a code coverage report.
​https://bugs.webkit.org/show_bug.cgi?id=117941

Reviewed by Joseph Pecoraro.

  • CodeCoverage: Added.
  • CodeCoverage/results-template.html: Added.
  • Scripts/generate-coverage-data: Generate and open the new report.
1:51 PM Changeset in webkit [152011] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r151785. <rdar://problem/14218781>

1:47 PM Changeset in webkit [152010] by Lucas Forschler
  • 9 edits
    2 deletes in branches/safari-537-branch

Merged r151774. <rdar://problem/14209720>

1:46 PM Changeset in webkit [152009] by Lucas Forschler
  • 8 edits in branches/safari-537-branch/Source/WebKit2

Merged r151767. <rdar://problem/14159371>

1:43 PM Changeset in webkit [152008] by Lucas Forschler
  • 8 edits in branches/safari-537-branch/Source/WebKit2

Merged r151748. <rdar://problem/14166644>

1:41 PM Changeset in webkit [152007] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-537-branch

Merged r151719. <rdar://problem/14198987>

12:49 PM Changeset in webkit [152006] by ddkilzer@apple.com
  • 3 edits in trunk/Source/WebCore

BUILD FIX (r151981): Include HTMLAudioElement.h for ENABLE(PLUGIN_PROXY_FOR_VIDEO)

  • css/StyleResolver.cpp:
  • Include HTMLAudioElement.h.
  • Sort headers.
  • rendering/RenderLayerCompositor.cpp:
  • Include HTMLAudioElement.h.
12:39 PM Changeset in webkit [152005] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

getComputedStyle().width wrong after text changed
​https://bugs.webkit.org/show_bug.cgi?id=106611

Patch by Yuki Sekiguchi <​yuki.sekiguchi@access-company.com> on 2013-06-26
Reviewed by Dean Jackson.

Source/WebCore:

When a new RenderText is created, NodeRenderingContext::createRendererForTextIfNeeded() sets a style to the RenderText.
If a font in the new style needs transcode (e.g. Meiryo), styleDidChange() calls transformText().
It sets a preferredLogicalWidthsDirty flag.
After that, createRendererForTextIfNeeded() inserts the RenderText to its parent renderer.
However, RenderObjectChildList::insertChildNode() doesn't set a preferredLogicalWidthsDirty flag of owner
because a preferredLogicalWidthsDirty flag of the RenderText is already true.

Inserting new child should always sets a preferredLogicalWidthsDirty flag.
Therefore, this patch called setPreferredLogicalWidthsDirty() of owner.

Test: fast/dynamic/empty-absolute-innerhtml-transcoding-text.html

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::insertChildNode):

LayoutTests:

  • fast/dynamic/empty-absolute-innerhtml-transcoding-text-expected.html: Added.
  • fast/dynamic/empty-absolute-innerhtml-transcoding-text.html: Added.
11:49 AM Changeset in webkit [152004] by Brent Fulgham
  • 5 edits
    2 moves in trunk/Source/WebCore

Prepare CaptionUserPreferencesMac for use on Windows port.
​https://bugs.webkit.org/show_bug.cgi?id=118069

Reviewed by Eric Carlson.

  • WebCore.vcxproj/WebCore.vcxproj: Add new files.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Update for new file name.
  • page/CaptionUserPreferencesMac.h: Removed.
  • page/CaptionUserPreferencesMac.mm: Removed.
  • page/CaptionUserPreferencesMediaAF.cpp: Copied from page/CaptionUserPreferencesMac.mm.
  • page/CaptionUserPreferencesMediaAF.h: Copied from page/CaptionUserPreferencesMac.h.
  • page/PageGroup.cpp:

(WebCore::PageGroup::captionPreferences): Updated to new class name.

11:17 AM Changeset in webkit [152003] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unneccesary cast to Node* in MediaControlTextTrackContainerElement::updateDisplay
​https://bugs.webkit.org/show_bug.cgi?id=118020

Reviewed by Christophe Dumez.

Merge ​https://chromium.googlesource.com/chromium/blink/+/2de89f61bb316f5e166b45ce71bb2b293dbf575d

TextTrackCue is a Node, there's no reason to static_cast from it to Node*.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay):

11:13 AM Changeset in webkit [152002] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

RenderBox::hasRenderOverflow should return bool instead of RenderOverflow*
​https://bugs.webkit.org/show_bug.cgi?id=118041

Reviewed by Christophe Dumez.

Merge ​https://chromium.googlesource.com/chromium/blink/+/1683b58c855b745463acbf18086e32279db5000f.

  • rendering/RenderBox.h:

(WebCore::RenderBox::hasRenderOverflow):
(WebCore::RenderBox::hasHorizontalLayoutOverflow):
(WebCore::RenderBox::hasVerticalLayoutOverflow):

11:06 AM Changeset in webkit [152001] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unneeded static_casts from SelectorChecker
​https://bugs.webkit.org/show_bug.cgi?id=118018

Reviewed by Christophe Dumez.

Merge ​https://chromium.googlesource.com/chromium/blink/+/adc5b8bec2d8c6a857b3c930ca7484f76cad1367

SelectorChecker::checkOne casts to StyledElement just to call classNames, but
this method is on Element so there's no reason for this. The cast here also
looks pretty suspect. The method also casts to HTMLFrameElementBase to call
containsFullScreenElement which is also on Element so the cast can be removed.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

10:55 AM Changeset in webkit [152000] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebInspectorUI

Merged r151846. <rdar://problem/13955160>

10:52 AM Changeset in webkit [151999] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source/WebInspectorUI

Merged r151738. <rdar://problem/13439854>

10:47 AM Changeset in webkit [151998] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Set Attr.ownerDocument in Element#setAttributeNode()
​https://bugs.webkit.org/show_bug.cgi?id=118031

Reviewed by Andreas Kling.

Source/WebCore:

Merge ​https://chromium.googlesource.com/chromium/blink/+/fa739fe5369f55bbdcb3fa123cb64df36b8ae414.

Adopt Attr node as needed.

Test: fast/dom/Attr/set-attribute-node-from-iframe.html

  • dom/Element.cpp:

(WebCore::Element::setAttributeNode):

LayoutTests:

Add a regression test.

  • fast/dom/Attr/set-attribute-node-from-iframe-expected.txt: Added.
  • fast/dom/Attr/set-attribute-node-from-iframe.html: Added.
10:31 AM Changeset in webkit [151997] by hyatt@apple.com
  • 9 edits
    6 adds in trunk

Flex boxes (both old and new) don't handle max-height images correctly.
​https://bugs.webkit.org/show_bug.cgi?id=118000

Reviewed by Beth Dakin.

Source/WebCore:

Tests: css3/flexbox/image-percent-max-height.html

fast/flexbox/image-percent-max-height.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::dirtyForLayoutFromPercentageHeightDescendants):
(WebCore::RenderBlock::layoutBlockChildren):
Pull the percentage height descendant code that dirties those descendants
out of layoutBlockChildren and into a protected helper function,
dirtyForLayoutFromPercentageHeightDescendants, that can be called from the
flex box code.

Also patch dirtyForLayoutFromPercentageHeightDescendants so that it will dirty
preferred logical widths when a child has an aspect ratio, since we know that
percentage height changes will potentially affect the preferred widths of the image and
its ancestor blocks.

  • rendering/RenderBlock.h:

Declaration of the new dirtyForLayoutFromPercentageHeightDescendants function.

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
Make the old flex box code call dirtyForLayoutFromPercentageHeightDescendants so
that everything is dirtied properly.

(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
Remove the isReplaced()/percentage height/width dirtying now that the old flexible
box is using the same dirtying mechanism as RenderBlock.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
Patch the new flexible box code to use the dirtying mechanism that RenderBlock
uses for percentage heights/widths on replaced descendants.

  • rendering/RenderObject.h:

(WebCore::RenderObject::hasAspectRatio):
Pulled the static helper function from RenderReplaced into a full-blown method
on RenderObject, so that dirtyForLayoutFromPercentageHeightDescendants can call
it to check if an object has an aspect ratio.

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeAspectRatioInformationForRenderBox):
(WebCore::RenderReplaced::computeIntrinsicRatioInformation):
Patch the call sites of the static helper function to use hasAspectRatio instead
and get rid of the static in the cpp file.

LayoutTests:

  • css3/flexbox/image-percent-max-height-expected.html: Added.
  • css3/flexbox/image-percent-max-height.html: Added.
  • css3/flexbox/resources/hero.png: Added.
  • fast/flexbox/image-percent-max-height-expected.html: Added.
  • fast/flexbox/image-percent-max-height.html: Added.
  • fast/flexbox/resources/hero.png: Added.
10:23 AM Changeset in webkit [151996] by kangil.han@samsung.com
  • 12 edits in trunk/Source

Adopt is/toHTMLAreaElement for code cleanup
​https://bugs.webkit.org/show_bug.cgi?id=117980

Reviewed by Antonio Gomes.

To enhance readibility, this patch adopts is/toHTMLAreaElement.
This also helps out to reduce duplicated use of static_cast.

Source/WebCore:

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::focusedUIElementForPage):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::getDocumentLinks):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::addImageMapChildren):

  • html/HTMLAreaElement.h:

(WebCore::isHTMLAreaElement):
(WebCore::toHTMLAreaElement):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::mapMouseEvent):

  • page/FocusController.cpp:

(WebCore::FocusController::advanceFocusDirectionally):

  • page/SpatialNavigation.cpp:

(WebCore::FocusCandidate::FocusCandidate):
(WebCore::areElementsOnSameLine):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::absoluteLinkURL):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintAreaElementFocusRing):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::elementForTapHighlight):

10:18 AM Changeset in webkit [151995] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] ASSERT(!m_tileMatrixNeedsUpdate) in BackingStorePrivate::render()
​https://bugs.webkit.org/show_bug.cgi?id=118062

Patch by Jacky Jiang <​zhajiang@blackberry.com> on 2013-06-26.
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.

JIRA426949
requestLayoutIfNeeded() can cause zoomAboutPoint() when the layout
is finished and make the tile matrix stale. We need requestLayoutIfNeeded()
before we updateTileMatrixIfNeeded() so that we can fix the ASSERT and
also pass the valid TileIndexList to render().

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::render):

10:03 AM Changeset in webkit [151994] by beidson@apple.com
  • 5 edits in trunk/Source/WebCore

[Mac] Document URL is not updated by HSTS
<rdar://problem/14241270> and ​https://bugs.webkit.org/show_bug.cgi?id=118003

Patch started by Alexey Proskuryakov, finished by Brady Eidson.

Reviewed by Brady Eidson and then Alexey Proskuryakov.

Synthesize a response and properly handle willSendRequest when the URL changes in a way that's typical for HSTS.

  • platform/network/mac/WebCoreURLResponse:
  • platform/network/mac/WebCoreURLResponse:

(WebCore::synthesizeRedirectResponseIfNecessary): Synthesize a redirect response and when the URL changes in a way that's

typical for HSTS connections.

  • platform/network/mac/WebCoreResourceHandleAsDelegate.mm:

(-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Call synthesizeRedirectResponseIfNecessary.

  • platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]): Ditto.

9:28 AM Changeset in webkit [151993] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

editing/selection/doubleclick-crash.html can be flaky
​https://bugs.webkit.org/show_bug.cgi?id=118017

Reviewed by Jessie Berlin.

Merge ​https://chromium.googlesource.com/chromium/blink/+/45ac882064589ac41a63762905f0618fc035cd44.

  • editing/selection/doubleclick-crash.html:
9:05 AM Changeset in webkit [151992] by abucur@adobe.com
  • 2 edits in trunk/Source/WebCore

[CSS Regions] fast/regions/seamless-iframe-flowed-into-regions.html asserts
​https://bugs.webkit.org/show_bug.cgi?id=117797

Reviewed by Antti Koivisto.

The seamless iframes inherit the current RenderFlowThread during layout. This means getting
the LayoutState object from the flow thread RenderView object is not always correct.
For RenderObjects inside the seamless iframes the view()/LayoutState object is different than the one
of the RenderFlowThread. The patch changes the code to use the correct LayoutState object during
layout when pushing a new state.

Tests: covered by fast/regions/seamless-iframe-flowed-into-regions.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::currentActiveRenderBox):
(WebCore::RenderFlowThread::pushFlowThreadLayoutState):
(WebCore::RenderFlowThread::popFlowThreadLayoutState):

9:00 AM Changeset in webkit [151991] by Antoine Quint
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: stepping through while paused in debugger makes a popover appear
​https://bugs.webkit.org/show_bug.cgi?id=117994

There is no obvious need to call tokenTrackingControllerNewHighlightCandidate when the
active call frame changes and it leads to an extraneous display of the popover.

Reviewed by Timothy Hatcher.

  • UserInterface/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._activeCallFrameDidChange):

8:38 AM Changeset in webkit [151990] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove many static_casts to Element types from AccessibilityNodeObject
​https://bugs.webkit.org/show_bug.cgi?id=118021

Reviewed by Chris Fleizach.

Merge ​https://chromium.googlesource.com/chromium/blink/+/ecd837f94996a20fdb8798e24f26cf6edea2a423.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::alternativeTextForWebArea):
(WebCore::AccessibilityNodeObject::text):

8:18 AM Changeset in webkit [151989] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Convert versus AsIs should have no bearing on whether we can do the SaneChain optimization for double array GetByVals
​https://bugs.webkit.org/show_bug.cgi?id=118028

Reviewed by Sam Weinig.

The SaneChain optimization allows us to get rid of the NaN check on loading from
a double array, if the result is used in an arithmetic op that wouldn't
distinguish between NaN and undefined. Normally the NaN check would be needed
because NaN is the hole marker.

The SaneChain optimization definitely requires that you're an Original array,
since we need to watchpoint the array prototype chain. And so it also needs to
be a JSArray, and not an object that has indexed double properties. We also
require an in-bounds access, since the backend is only capable of the
optimization in the in-bounds case (though we could extend it to OOB in the
future). But whether the array is being converted or is as-is isn't relevant.
Either way, if it's a double original array in-bounds access by the time that
the array check (or conversion!) completes, we can do the optimization.

Ever-so-slight speed-up on Kraken/imaging-gaussian-blur.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

7:28 AM Changeset in webkit [151988] by Christophe Dumez
  • 30 edits in trunk/Source/WebCore

Stop inheriting SVGExternalResourcesRequired, SVGFitToViewBox and SVGZoomAndPan
​https://bugs.webkit.org/show_bug.cgi?id=118029

Reviewed by Kentaro Hara.

Stop inheriting SVGExternalResourcesRequired, SVGFitToViewBox and SVGZoomAndPan
in the IDL and use implements statements instead.

This is one step towards getting rid of multiple inheritance in the SVG code
and matching the latest specification:
​http://www.w3.org/TR/SVG2/types.html#BasicDOMInterfaces

There is no webexposed behavior change.

No new tests, no behavior change.

  • svg/SVGAnimationElement.idl:
  • svg/SVGCircleElement.idl:
  • svg/SVGClipPathElement.idl:
  • svg/SVGCursorElement.idl:
  • svg/SVGDefsElement.idl:
  • svg/SVGEllipseElement.idl:
  • svg/SVGFEImageElement.idl:
  • svg/SVGFilterElement.idl:
  • svg/SVGForeignObjectElement.idl:
  • svg/SVGGElement.idl:
  • svg/SVGGradientElement.idl:
  • svg/SVGImageElement.idl:
  • svg/SVGLineElement.idl:
  • svg/SVGMPathElement.idl:
  • svg/SVGMarkerElement.idl:
  • svg/SVGMaskElement.idl:
  • svg/SVGPathElement.idl:
  • svg/SVGPatternElement.idl:
  • svg/SVGPolygonElement.idl:
  • svg/SVGPolylineElement.idl:
  • svg/SVGRectElement.idl:
  • svg/SVGSVGElement.idl:
  • svg/SVGScriptElement.idl:
  • svg/SVGSwitchElement.idl:
  • svg/SVGSymbolElement.idl:
  • svg/SVGTextContentElement.idl:
  • svg/SVGUseElement.idl:
  • svg/SVGViewSpec.idl:
4:45 AM Changeset in webkit [151987] by rakuco@webkit.org
  • 1 edit
    1 delete in trunk/Tools

gdb: Remove the webcore.py pretty printer.
​https://bugs.webkit.org/show_bug.cgi?id=117992

Reviewed by Jochen Eisinger.

webcore.py has been only a placeholder for backwards compatibility
for almost 3 years. It should be safe enough to remove it now.

  • gdb/webcore.py: Removed.
3:49 AM Changeset in webkit [151986] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Use-after-free in RadioInputType::handleKeydownEvent
​https://bugs.webkit.org/show_bug.cgi?id=118035

Reviewed by Kent Tamura.

Use RefPtr for inputElement since setFocusedNode could blow it away.

  • html/RadioInputType.cpp:

(WebCore::RadioInputType::handleKeydownEvent):

3:39 AM Changeset in webkit [151985] by Christophe Dumez
  • 23 edits in trunk

Get rid of multiple inheritence for SVGViewElement interface
​https://bugs.webkit.org/show_bug.cgi?id=118014

Reviewed by Kentaro Hara.

Source/WebCore:

Web IDL no longer supports multiple inheritence. As per the latest
specification SVGViewElement should only inherit from SVGElement.
'implements' statements are used for the rest. This patch refactors
the IDL files to match the latest specification:
​http://www.w3.org/TR/SVG2/linking.html#InterfaceSVGViewElement

Note that there is a WebExposed change as SVGZoomAndPan used to be
exposed on the Window and it is not anymore. SVGZoomAndPan merely
supplements SVGViewElement and should not be exposed to JavaScript
according to the latest specification.

No new tests, covered by existing tests.

  • CMakeLists.txt:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • svg/SVGExternalResourcesRequired.idl:
  • svg/SVGFitToViewBox.idl:
  • svg/SVGViewElement.idl:
  • svg/SVGZoomAndPan.idl:

LayoutTests:

Update / Rebaseline several SVG test cases now that SVGZoomAndPan interface
is no longer exposed.

  • fast/js/global-constructors-attributes-expected.txt:
  • platform/efl/fast/js/global-constructors-attributes-expected.txt:
  • platform/gtk/fast/js/global-constructors-attributes-expected.txt:
  • platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
  • platform/qt/fast/js/global-constructors-attributes-expected.txt:
  • svg/custom/global-constructors-expected.txt:
  • svg/custom/js-svg-constructors-expected.txt:
  • svg/custom/js-svg-constructors.svg:
  • svg/custom/script-tests/global-constructors.js:
  • svg/dom/SVGViewSpec-defaults-expected.txt:
  • svg/dom/SVGViewSpec-expected.txt:
  • svg/dom/resources/viewspec-parser.js:

(zoomAndPanToString):
(viewSpecToString):

  • svg/dom/script-tests/SVGViewSpec-defaults.js:
  • svg/dom/script-tests/SVGViewSpec.js:

(continueTesting):

1:22 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
1:18 AM Changeset in webkit [151984] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Creating cURL watchlist and adding myself to it.

Patch by Peter Gal <​galpeter@inf.u-szeged.hu> on 2013-05-26
Reviewed by Csaba Osztrogonác.

  • Scripts/webkitpy/common/config/watchlist:
1:16 AM Changeset in webkit [151983] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

[GTK] [WK2] Cannot make debug builds of the stable branch
​https://bugs.webkit.org/show_bug.cgi?id=117979

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-06-25
Reviewed by Carlos Garcia Campos.

Add missing source files to WebKitPluginProcess.

  • GNUmakefile.list.am:
1:14 AM Changeset in webkit [151982] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

Mark SVG(Circle|Path|Rect)Element::createRenderer() with OVERRIDE
​https://bugs.webkit.org/show_bug.cgi?id=118037

Reviewed by Philip Rogers.

Merge ​https://chromium.googlesource.com/chromium/blink/+/e8196920e769ab0786b2b4b21d3fdc2d87afef0d.

  • svg/SVGCircleElement.h:
  • svg/SVGPathElement.h:
  • svg/SVGRectElement.h:
12:46 AM WebKitGTK/2.0.x edited by agarcia@igalia.com
(diff)
12:44 AM Changeset in webkit [151981] by kangil.han@samsung.com
  • 11 edits in trunk/Source

Adopt is/toHTMLAudioElement for code cleanup
​https://bugs.webkit.org/show_bug.cgi?id=117985

Reviewed by Jer Noble.

To enhance readibility, this patch adopts is/toHTMLAudioElement.
This also helps out to reduce duplicated use of static_cast.

Source/WebCore:

  • bindings/js/JSNodeCustom.cpp:

(WebCore::isReachableFromDOM):

  • css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement):

  • html/HTMLAudioElement.h:

(WebCore::isHTMLAudioElement):
(WebCore::toHTMLAudioElement):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::mediaElement):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForVideo):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMediaMuteButton):
(WebCore::RenderThemeMac::paintMediaPlayButton):

Source/WebKit/mac:

  • Plugins/WebPluginController.mm:
12:24 AM Changeset in webkit [151980] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Refactoring: Fold Document::focusedNodeRemoved into Document::removeFocusedNodeOfSubtree
​https://bugs.webkit.org/show_bug.cgi?id=118036

Reviewed by Kent Tamura.

Merge ​https://chromium.googlesource.com/chromium/blink/+/3391beabe75548cc638a6c88982f913621a4410f.

  • dom/Document.cpp:

(WebCore::Document::removeFocusedNodeOfSubtree):

  • dom/Document.h:

Jun 25, 2013:

11:37 PM WebKitGTK/StartHacking edited by Andres Gomez
(diff)
11:35 PM WebKitGTK/StartHacking edited by Andres Gomez
Estimated size of a debug build added (diff)
9:16 PM Changeset in webkit [151979] by fpizlo@apple.com
  • 21 edits
    26 adds in branches/dfgFourthTier

fourthTier: DFG should support switch_string
​https://bugs.webkit.org/show_bug.cgi?id=117967

Source/JavaScriptCore:

Reviewed by Sam Weinig.

Add a reusable binary switch creator.

Implement switch on string using three modes:

  • Binary switch on StringImpl* in the case of identifiers.


  • Trie of binary switches on characters in the case of a not-too-big switch over not-too-big 8-bit strings.


  • Hash lookup if all else fails.


Anywhere from a 2x to 3x speed-up on microbenchmarks that stress
string switches. 25-35% speed-up on HashMap tests. 4% speed-up on
pdfjs.

(StringJumpTable):
(JSC::StringJumpTable::clear):

  • dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

  • dfg/DFGBinarySwitch.cpp: Added.

(DFG):
(JSC::DFG::BinarySwitch::BinarySwitch):
(JSC::DFG::BinarySwitch::advance):
(JSC::DFG::BinarySwitch::build):

  • dfg/DFGBinarySwitch.h: Added.

(DFG):
(BinarySwitch):
(JSC::DFG::BinarySwitch::caseIndex):
(JSC::DFG::BinarySwitch::caseValue):
(JSC::DFG::BinarySwitch::fallThrough):
(JSC::DFG::BinarySwitch::Case::Case):
(Case):
(JSC::DFG::BinarySwitch::Case::operator<):
(JSC::DFG::BinarySwitch::BranchCode::BranchCode):
(BranchCode):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGLazyJSValue.cpp:

(JSC::DFG::LazyJSValue::getValue):
(JSC::DFG::equalToStringImpl):
(DFG):
(JSC::DFG::LazyJSValue::strictEqual):
(JSC::DFG::LazyJSValue::dump):

  • dfg/DFGLazyJSValue.h:

(JSC::DFG::LazyJSValue::knownStringImpl):
(LazyJSValue):
(JSC::DFG::LazyJSValue::stringImpl):
(JSC::DFG::LazyJSValue::switchLookupValue):

  • dfg/DFGNode.cpp:

(WTF::printInternal):

  • dfg/DFGNode.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitSwitchChar):
(JSC::DFG::SpeculativeJIT::StringSwitchCase::operator<):
(DFG):
(JSC::DFG::SpeculativeJIT::emitBinarySwitchStringRecurse):
(JSC::DFG::SpeculativeJIT::emitSwitchStringOnString):
(JSC::DFG::SpeculativeJIT::emitSwitchString):
(JSC::DFG::SpeculativeJIT::emitSwitch):
(JSC::DFG::SpeculativeJIT::addBranch):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::branch8):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::StringSwitchCase::StringSwitchCase):
(StringSwitchCase):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileSwitch):

  • runtime/Options.h:

(JSC):

Source/WTF:

Reviewed by Sam Weinig.

Make it possible to compare a RefPtr<StringImpl> and a StringImpl* without
having to ref the StringImpl.

  • wtf/text/StringHash.h:

(WTF::StringHash::equal):

LayoutTests:

Reviewed by Sam Weinig.

  • fast/js/regress/script-tests/switch-string-basic-big-var.js: Added.

(foo):
(make):

  • fast/js/regress/script-tests/switch-string-basic-big.js: Added.

(foo):
(make):

  • fast/js/regress/script-tests/switch-string-basic-var.js: Added.

(foo):
(make):

  • fast/js/regress/script-tests/switch-string-basic.js: Added.

(foo):

  • fast/js/regress/script-tests/switch-string-big-length-tower-var.js: Added.

(foo):

  • fast/js/regress/script-tests/switch-string-length-tower-var.js: Added.

(foo):

  • fast/js/regress/script-tests/switch-string-length-tower.js: Added.

(foo):

  • fast/js/regress/script-tests/switch-string-short.js: Added.

(foo):

  • fast/js/regress/switch-string-basic-big-expected.txt: Added.
  • fast/js/regress/switch-string-basic-big-var-expected.txt: Added.
  • fast/js/regress/switch-string-basic-big-var.html: Added.
  • fast/js/regress/switch-string-basic-big.html: Added.
  • fast/js/regress/switch-string-basic-expected.txt: Added.
  • fast/js/regress/switch-string-basic-var-expected.txt: Added.
  • fast/js/regress/switch-string-basic-var.html: Added.
  • fast/js/regress/switch-string-basic.html: Added.
  • fast/js/regress/switch-string-big-length-tower-var-expected.txt: Added.
  • fast/js/regress/switch-string-big-length-tower-var.html: Added.
  • fast/js/regress/switch-string-length-tower-expected.txt: Added.
  • fast/js/regress/switch-string-length-tower-var-expected.txt: Added.
  • fast/js/regress/switch-string-length-tower-var.html: Added.
  • fast/js/regress/switch-string-length-tower.html: Added.
  • fast/js/regress/switch-string-short-expected.txt: Added.
  • fast/js/regress/switch-string-short.html: Added.
8:48 PM Changeset in webkit [151978] by rniwa@webkit.org
  • 12 edits in trunk/Source

JSString should remember AtomicString
​https://bugs.webkit.org/show_bug.cgi?id=117386

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added JSValue::toAtomicString and JSString::atomicString. These two functions allow WebCore to update
JSString's m_value to set isAtomic flag and avoid the AtomicStringTable lookups in subsequent attempts
to obtain the AtomicString of the same value.

  • runtime/JSCJSValue.h:
  • runtime/JSString.h:

(JSC::JSString::atomicString):
(JSC::JSValue::toAtomicString):

Source/WebCore:

Added "Atomic" attribute as a WebKit extension to WebIDL, and deployed it in Element.idl and Node.idl so that
the binding code can use newly added JSValue::toAtomic to update JSString's m_value.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::valueToAtomicStringWithNullCheck): Added.
(WebCore::valueToAtomicStringWithUndefinedOrNullCheck): Added.

  • bindings/js/JSDOMBinding.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GetNativeTypeFromSignature): Return const AtomicString& when either Atomic attribute is specified or the type is
Reflect. Note that setAttribute and getAttribute both use AtomicString for all arguments.
(JSValueToNative): Use AtomicString equivalents when possible when converting DOMString to a WebCore object.

  • bindings/scripts/IDLAttributes.txt: Added "Atomic" attribute.
  • bindings/scripts/test/JS/JSTestObj.cpp: Baselined test cases.

(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):

  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Node.idl:
6:22 PM Changeset in webkit [151977] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WTF

Merged r151755. <rdar://problem/14209227>

6:09 PM Changeset in webkit [151976] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebCore

Merged r151747. <rdar://problem/14187667>

6:06 PM Changeset in webkit [151975] by kangil.han@samsung.com
  • 14 edits in trunk/Source

Adopt is/toHTMLAnchorElement for code cleanup
​https://bugs.webkit.org/show_bug.cgi?id=117973

Reviewed by Andreas Kling.

To enhance readibility, this patch adopts is/toHTMLAnchorElement.
This also helps out to reduce duplicated use of static_cast.

Source/WebCore:

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::anchorElement):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::anchorElement):
(WebCore::AccessibilityRenderObject::internalLinkElement):
(WebCore::AccessibilityRenderObject::url):
(WebCore::AccessibilityRenderObject::stringValueForMSAA):
(WebCore::AccessibilityRenderObject::isLinked):

  • css/CSSDefaultStyleSheets.cpp:

(WebCore::elementCanUseSimpleDefaultStyle):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • dom/Document.cpp:

(WebCore::Document::updateBaseURL):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::findAnchor):

  • dom/VisitedLinkState.cpp:

(WebCore::linkHashForElement):
(WebCore::VisitedLinkState::determineLinkStateSlowCase):

  • html/HTMLAnchorElement.h:

(WebCore::isHTMLAnchorElement):
(WebCore::toHTMLAnchorElement):

  • page/DragController.cpp:

(WebCore::DragController::draggableElement):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::absoluteLinkURL):
(WebCore::HitTestResult::isLiveLink):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

Source/WebKit/blackberry:

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::isElementClickable):

5:58 PM Changeset in webkit [151974] by Lucas Forschler
  • 3 edits in branches/safari-537-branch/Source/JavaScriptCore

Merged r151786. <rdar://problem/14149317>

5:36 PM Changeset in webkit [151973] by Lucas Forschler
  • 7 edits in branches/safari-537-branch/Source

Merged r151929. <rdar://problem/14250527>

5:30 PM Changeset in webkit [151972] by Lucas Forschler
  • 4 edits in branches/safari-537-branch/Source/WebKit2

Merged r151760. <rdar://problem/14197983>

2:48 PM Changeset in webkit [151971] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Don't snapshot plug-ins that come from the same host as the page
​https://bugs.webkit.org/show_bug.cgi?id=117969
<rdar://problem/12885400>

Reviewed by Tim Horton.

If a page is serving plug-in content directly, then that content
is typically very important to the page. For example, embedding
a video or audio player. In this case, don't snapshot the plug-ins.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Add a test
that compares the plug-in's URL against the main page's URL and don't snapshot
if they are the same.

11:18 AM Changeset in webkit [151970] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/JavaScriptCore

Merged r151923. <rdar://problem/14250711>

11:17 AM Changeset in webkit [151969] by Lucas Forschler
  • 2 edits in tags/Safari-537.46.6/Source/JavaScriptCore

Merged r151923. <rdar://problem/14250711>

11:15 AM Changeset in webkit [151968] by Lucas Forschler
  • 5 edits in tags/Safari-537.46.6/Source

Versioning.

11:12 AM Changeset in webkit [151967] by Lucas Forschler
  • 1 copy in tags/Safari-537.46.6

New Tag.

10:45 AM Changeset in webkit [151966] by achristensen@apple.com
  • 9 edits in trunk/Source/WebCore

Added PLATFORM(WIN) to many places where it was missing for compiling WebGL for Windows.
​https://bugs.webkit.org/show_bug.cgi?id=117955

Reviewed by Brent Fulgham.

  • platform/graphics/GraphicsContext3D.cpp:
  • platform/graphics/OpenGLShims.cpp:
  • platform/graphics/cairo/GraphicsContext3DCairo.cpp: Include new location of ShaderLang.h on Windows as of r151854.
  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):

  • platform/graphics/opengl/Extensions3DOpenGL.h:
  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: Added PLATFORM(WIN) when necessary to each file.
9:16 AM Changeset in webkit [151965] by commit-queue@webkit.org
  • 3 edits
    1 move
    2 deletes in trunk/LayoutTests

[AX][ATK] Update accessibility baselines after r151953
​https://bugs.webkit.org/show_bug.cgi?id=117983

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-06-25
Reviewed by Chris Fleizach.

Updating aria-option-role-expected.txt for EFL and GTK after the changes in aria-option-role.html test (r151953).
Moving platform aria-checkbox-text.html to LayoutTests/accessibility. Baseline is the same for mac, gtk, efl. Windows port has it's own specific version.

  • accessibility/aria-checkbox-text-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-checkbox-text-expected.txt.
  • platform/efl/accessibility/aria-checkbox-text-expected.txt: Removed.
  • platform/efl/accessibility/aria-option-role-expected.txt:
  • platform/gtk/accessibility/aria-checkbox-text-expected.txt: Removed.
  • platform/gtk/accessibility/aria-option-role-expected.txt:
8:24 AM Changeset in webkit [151964] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fixes a typo in renderTextDecorationFlagsToCSSValue
​https://bugs.webkit.org/show_bug.cgi?id=117989

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2013-06-25
Reviewed by Gyuyoung Kim.

Return value should be PassRefPtr instead of RefPtr.

Backported from Blink:
​https://src.chromium.org/viewvc/blink?view=rev&revision=152994

No new tests, no behavior change.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::renderTextDecorationFlagsToCSSValue):

6:09 AM Changeset in webkit [151963] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

Unreviewed, change my email address for watch list.

  • Scripts/webkitpy/common/config/watchlist:
5:57 AM Changeset in webkit [151962] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

"application/x-mimearchive" should be included in finding remoteWebArchive while document loading
​https://bugs.webkit.org/show_bug.cgi?id=117734

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-06-25
Reviewed by Alexey Proskuryakov.

"application/x-mimearchive" is also used while checking for

RemoteArchive.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::continueAfterContentPolicy):

5:23 AM WebKitGTK/StartHacking edited by Adrian Perez de Castro
(diff)
5:22 AM WebKitGTK/StartHacking edited by Adrian Perez de Castro
(diff)
5:09 AM WebKitEFLLayoutTest edited by bw80.lee@gmail.com
Change the guide of layout test dependencies to use the install script. (diff)
5:04 AM EFLWebKit edited by bw80.lee@gmail.com
Change the guide of base dependencies to use the install script. (diff)
4:35 AM Changeset in webkit [151961] by bw80.lee@samsung.com
  • 1 edit
    1 add in trunk/Tools

[EFL] Add a script to install dependencies.
​https://bugs.webkit.org/show_bug.cgi?id=117968

Reviewed by Christophe Dumez.

Add a script which installs basic dependencies for building WebKit EFL.

The dependencies are from the current EFLWebKit wiki page.
After this patch is landed, the wiki page will be updated to use
this script.

  • efl/install-dependencies: Added.
3:57 AM Changeset in webkit [151960] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Add bug report into TestExpectations for fast/text/international/synthesized-italic-vertical-latin.html
​https://bugs.webkit.org/show_bug.cgi?id=117976

Unreviewed gardening.

TestExpectations was missing a bug number for a skip test (​http://webkit.org/b/117975).

Patch by Denis Nomiyama <​d.nomiyama@samsung.com> on 2013-06-25

  • platform/gtk/TestExpectations:
2:17 AM Changeset in webkit [151959] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing inspector test.

  • platform/qt/TestExpectations:
2:00 AM Changeset in webkit [151958] by allan.jensen@digia.com
  • 3 edits in trunk/Source/WebCore

HTMLMediaElement should inherit from MediaPlayerClient privately
​https://bugs.webkit.org/show_bug.cgi?id=117874

Reviewed by Andreas Kling.

Fixing FIXME: HTMLMediaElement was stuck with public inheritance from
MediaPlayerClient due to the Chromium and Qt port.

The Qt port is changed to not cast from MediaPlayerClient to HTMLMediaElement.

  • html/HTMLMediaElement.h:
  • platform/graphics/qt/MediaPlayerPrivateQt.cpp:

(WebCore::MediaPlayerPrivateQt::commitLoad):

1:44 AM Changeset in webkit [151957] by Csaba Osztrogonác
  • 10 edits in trunk/Source/WebCore

Checking if frame is complete and access duration doesn't need a decode
​https://bugs.webkit.org/show_bug.cgi?id=116041

Reviewed by Allan Sandfeld Jensen.

This change is to avoid image decoding for these two operations:

  1. frameIsCompleteAtIndex
  2. frameDurationAtIndex

These two operations are moved to ImageDecoder interface and are now const
to prevent future regression.

We are now able to check if a frame is complete by parsing the entire GIF file
without decoding. This also provides information like frame duration such that
controller the animation doesn't require any decoding.

Based on the Blink patch by Hin-Chung Lam <​hclam@google.com>
​https://src.chromium.org/viewvc/blink?revision=149883&view=revision

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::frameIsCompleteAtIndex):
(WebCore::BitmapImage::frameDurationAtIndex):

  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::frameDurationAtIndex):
(WebCore::ImageSource::frameHasAlphaAtIndex):
(WebCore::ImageSource::frameIsCompleteAtIndex):

  • platform/graphics/ImageSource.h:
  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::frameHasAlphaAtIndex):
(WebCore::ImageDecoder::frameIsCompleteAtIndex):

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::frameDurationAtIndex):

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::frameIsCompleteAtIndex):
(WebCore::GIFImageDecoder::frameDurationAtIndex):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::gifComplete):
(WebCore::GIFImageDecoder::decode):
(WebCore::GIFImageDecoder::initFrameBuffer):

  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/gif/GIFImageReader.h:

(GIFImageReader::frameContext):
(GIFImageReader::parseCompleted):

Jun 24, 2013:

11:28 PM Changeset in webkit [151956] by Christophe Dumez
  • 4 edits in trunk/Source/WebCore

Update AbstractWorker, Worker and SharedWorker to match the specification
​https://bugs.webkit.org/show_bug.cgi?id=117930

Reviewed by Kentaro Hara.

Update AbstractWorker, Worker and SharedWorker to match the spec:
​http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#abstractworker
​http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#worker
​http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#sharedworker

Worker and SharedWorker no longer inherit from AbstractWorker. Web IDL 'implements'
statements are used instead. Worker and SharedWorker can now inherit from EventTarget
as per the specification.

No new tests, no behavior change.

  • workers/AbstractWorker.idl:
  • workers/SharedWorker.idl:
  • workers/Worker.idl:
10:58 PM Changeset in webkit [151955] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

DerivedSources.make should optionally include SupplementalDependencies.dep
​https://bugs.webkit.org/show_bug.cgi?id=117972

Reviewed by Dan Bernstein.

make(1) logs a non-fatal error to stderr when an included Makefile can't
be found. This error is non-fatal because after make(1) reads in all the
Makefiles it runs the recipe for any rule that specifies one of the
Makefiles as a target. Only if the Makefile is still missing after
applying these rules does the error become fatal.

Since SupplementalDependencies.dep is generated by running a script on
SupplementalDependencies.txt, the file won't exist during clean builds.
Each time make(1) logs this non-fatal error, Xcode sees it and itself
logs a non-fatal error. This is annoying.

We don't care about this error. We only care if the recipe to generate
SupplementalDependencies.dep fails, which is already a fatal error.
Suppress the error by including SupplementalDependencies.dep optionally.

  • DerivedSources.make:
9:23 PM Changeset in webkit [151954] by dino@apple.com
  • 3 edits in trunk/Tools

[Mac] Update font used for Chinese in test systems
​https://bugs.webkit.org/show_bug.cgi?id=117970

Reviewed by Alexey Proskuryakov.

Add "Songti TC" and "Songti SC" to the list of allowed fonts
in DRT and WKTR.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(allowedFontFamilySet):

  • WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:

(WTR::allowedFontFamilySet):

9:07 PM Changeset in webkit [151953] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Mac] Build correction.

  • platform/mac/accessibility/aria-tab-roles-expected.txt:
8:47 PM Changeset in webkit [151952] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

Silverlight triggers sandbox violations: deny network-bind 0.0.0.0:0
​https://bugs.webkit.org/show_bug.cgi?id=117966
<rdar://problem/13927918>

Patch by Simon Cooper <​scooper@apple.com> on 2013-06-24
Reviewed by Sam Weinig.

Allow assigning (via bind) an ephemeral port before connecting

  • Resources/PlugInSandboxProfiles/com.apple.QuickTime Plugin.plugin.sb:
  • Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:
  • Resources/PlugInSandboxProfiles/com.microsoft.SilverlightPlugin.sb:
  • Resources/PlugInSandboxProfiles/com.oracle.java.JavaAppletPlugin.sb:
7:38 PM Changeset in webkit [151951] by kangil.han@samsung.com
  • 9 edits
    9 adds in trunk

Add support for document.currentScript
​https://bugs.webkit.org/show_bug.cgi?id=104221

Reviewed by Ryosuke Niwa.

Merge ​http://src.chromium.org/viewvc/blink?view=revision&revision=152230
document.currentScript reflects the script that is currently being executed.

Merge ​http://src.chromium.org/viewvc/blink?view=revision&revision=152237
Following up patch for code clean-up.

Source/WebCore:

Tests: fast/dom/Document/document-current-script-async.html

fast/dom/Document/document-current-script.html

  • dom/Document.cpp:

(WebCore::Document::pushCurrentScript):
(WebCore::Document::popCurrentScript):

  • dom/Document.h:

(WebCore::Document::currentScript):

  • dom/Document.idl:
  • dom/ScriptElement.cpp:

(WebCore::isHTMLScriptElement):
(WebCore::isSVGScriptElement):
(WebCore::ScriptElement::executeScript):
(WebCore::toScriptElementIfPossible):

  • html/HTMLScriptElement.h:

(WebCore::toHTMLScriptElement):

  • svg/SVGScriptElement.cpp:
  • svg/SVGScriptElement.h:

(WebCore::toSVGScriptElement):

LayoutTests:

  • fast/dom/Document/document-current-script-async-expected.txt: Added.
  • fast/dom/Document/document-current-script-async.html: Added.
  • fast/dom/Document/document-current-script-expected.txt: Added.
  • fast/dom/Document/document-current-script.html: Added.
  • fast/dom/Document/resources/log-current-script-b.js: Added.
  • fast/dom/Document/resources/log-current-script-d.js: Added.
  • fast/dom/Document/resources/log-current-script-f.js: Added.
  • fast/dom/Document/resources/log-current-script.js: Added.
7:27 PM Changeset in webkit [151950] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

PluginProcess deny file-read-data /Network/Library under addVolumeTracker
​https://bugs.webkit.org/show_bug.cgi?id=117965
<rdar://problem/14121247>

Patch by Simon Cooper <​scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.

Silently deny reading /Network/Applications and
/Network/Library.

  • Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
7:19 PM Changeset in webkit [151949] by kangil.han@samsung.com
  • 25 edits in trunk/Source

Adopt is/toHTMLFormElement for code cleanup
​https://bugs.webkit.org/show_bug.cgi?id=117937

Reviewed by Andreas Kling.

This refers to ​http://src.chromium.org/viewvc/blink?view=revision&revision=152859

To enhance readibility, this patch adopts is/toHTMLFormElement.
This also helps out to reduce duplicated use of static_cast.

Source/WebCore:

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

  • bindings/js/JSDOMFormDataCustom.cpp:

(WebCore::toHTMLFormElement):

  • bindings/js/JSHTMLFormElementCustom.cpp:

(WebCore::JSHTMLFormElement::nameGetter):

  • editing/FrameSelection.cpp:

(WebCore::scanForForm):
(WebCore::FrameSelection::currentForm):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::findAssociatedForm):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::findFormAncestor):

  • html/HTMLFormControlsCollection.cpp:

(WebCore::HTMLFormControlsCollection::HTMLFormControlsCollection):
(WebCore::HTMLFormControlsCollection::formControlElements):
(WebCore::HTMLFormControlsCollection::formImageElements):
(WebCore::HTMLFormControlsCollection::updateNameCache):

  • html/HTMLFormElement.h:

(WebCore::isHTMLFormElement):
(WebCore::toHTMLFormElement):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::insertedInto):

  • html/HTMLNameCollection.cpp:

(WebCore::WindowNameCollection::nodeMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatches):

  • html/RadioInputType.cpp:

(WebCore::RadioInputType::handleKeydownEvent):

  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::RadioNodeList):
(WebCore::RadioNodeList::checkElementMatchesRadioNodeListFilter):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLFormElement):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::closestFormAncestor):

  • page/Frame.cpp:

(WebCore::Frame::searchForLabelsBeforeElement):

Source/WebKit/blackberry:

  • WebCoreSupport/CredentialManager.cpp:

(WebCore::CredentialManager::autofillPasswordForms):

Source/WebKit/win:

  • DOMCoreClasses.cpp:

(DOMElement::createInstance):

  • DOMHTMLClasses.cpp:

(DOMHTMLFormElement::action):
(DOMHTMLFormElement::method):

  • WebFrame.cpp:

(formElementFromDOMElement):

Source/WebKit2:

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::containsAnyFormElements):

6:44 PM Changeset in webkit [151948] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

deny file-read-data /Library/CoreMediaIO/Plug-Ins/DAL
​https://bugs.webkit.org/show_bug.cgi?id=117964
<rdar://problem/14036864>

Patch by Simon Cooper <​scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.

Permit reading of the /Library/CoreMediaIO/Plug-Ins/DAL
subdirectory.

  • Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
6:36 PM Changeset in webkit [151947] by gyuyoung.kim@samsung.com
  • 105 edits in trunk/Source/WebCore

Remove unneeded include header files from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=117926

Reviewed by Andreas Kling.

Merge from ​https://chromiumcodereview.appspot.com/17388003.

Cleanup unused includes from WebCore.

  • editing/CompositeEditCommand.cpp:
  • editing/DeleteSelectionCommand.cpp:
  • editing/EditingStyle.cpp:
  • editing/Editor.cpp:
  • editing/FrameSelection.cpp:
  • editing/HTMLInterchange.cpp:
  • editing/IndentOutdentCommand.cpp:
  • editing/InsertListCommand.cpp:
  • editing/InsertTextCommand.cpp:
  • editing/SpellChecker.h:
  • editing/VisibleUnits.cpp:
  • editing/VisibleUnits.h:
  • editing/markup.cpp:
  • fileapi/Blob.h:
  • fileapi/File.h:
  • fileapi/WebKitBlobBuilder.h:
  • history/HistoryItem.cpp:
  • history/HistoryItem.h:
  • html/BaseDateAndTimeInputType.cpp:
  • html/BaseDateAndTimeInputType.h:
  • html/ClassList.cpp:
  • html/ClassList.h:
  • html/DOMSettableTokenList.h:
  • html/DOMURL.cpp:
  • html/DateInputType.h:
  • html/FormController.h:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLCollection.cpp:
  • html/HTMLCollection.h:
  • html/HTMLDocument.h:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLFieldSetElement.h:
  • html/HTMLFormElement.cpp:
  • html/HTMLFrameOwnerElement.h:
  • html/HTMLIFrameElement.cpp:
  • html/HTMLInputElement.cpp:
  • html/HTMLLegendElement.cpp:
  • html/HTMLLinkElement.h:
  • html/HTMLMediaElement.cpp:
  • html/HTMLMeterElement.cpp:
  • html/HTMLOptionElement.cpp:
  • html/HTMLOutputElement.h:
  • html/HTMLPlugInImageElement.cpp:
  • html/HTMLPlugInImageElement.h:
  • html/HTMLProgressElement.cpp:
  • html/HTMLSelectElement.cpp:
  • html/HTMLTableElement.cpp:
  • html/HTMLTitleElement.cpp:
  • html/HTMLTrackElement.cpp:
  • html/ImageInputType.h:
  • html/InputType.h:
  • html/MediaController.h:
  • html/MediaFragmentURIParser.h:
  • html/NumberInputType.cpp:
  • html/RadioNodeList.h:
  • html/TextFieldInputType.h:
  • html/TypeAhead.cpp:
  • html/ValidityState.cpp:
  • html/canvas/CanvasPathMethods.h:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/OESVertexArrayObject.h:
  • html/canvas/WebGLBuffer.cpp:
  • html/canvas/WebGLBuffer.h:
  • html/canvas/WebGLCompressedTextureATC.h:
  • html/canvas/WebGLCompressedTextureS3TC.cpp:
  • html/canvas/WebGLCompressedTextureS3TC.h:
  • html/canvas/WebGLContextObject.h:
  • html/canvas/WebGLDebugShaders.cpp:
  • html/canvas/WebGLObject.h:
  • html/canvas/WebGLProgram.h:
  • html/canvas/WebGLRenderingContext.cpp:
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLShader.h:
  • html/canvas/WebGLTexture.h:
  • html/canvas/WebGLUniformLocation.h:
  • html/canvas/WebGLVertexArrayObjectOES.h:
  • html/parser/BackgroundHTMLParser.cpp:
  • html/parser/BackgroundHTMLParser.h:
  • html/parser/CSSPreloadScanner.cpp:
  • html/parser/HTMLConstructionSite.cpp:
  • html/parser/HTMLConstructionSite.h:
  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLElementStack.h:
  • html/parser/HTMLParserIdioms.cpp:
  • html/parser/HTMLParserIdioms.h:
  • html/parser/HTMLParserScheduler.h:
  • html/parser/HTMLPreloadScanner.cpp:
  • html/parser/HTMLSourceTracker.h:
  • html/parser/HTMLTreeBuilder.h:
  • html/parser/HTMLTreeBuilderSimulator.h:
  • html/parser/XSSAuditor.cpp:
  • html/parser/XSSAuditorDelegate.h:
  • html/shadow/HTMLContentElement.cpp:
  • html/shadow/HTMLContentElement.h:
  • html/shadow/MediaControlElements.cpp:
  • html/shadow/MediaControls.h:
  • html/shadow/SliderThumbElement.cpp:
  • html/shadow/SliderThumbElement.h:
  • html/shadow/TextControlInnerElements.cpp:
  • html/track/InbandTextTrack.h:
  • html/track/LoadableTextTrack.cpp:
  • html/track/LoadableTextTrack.h:
  • html/track/TextTrackCueGeneric.h:
6:28 PM Changeset in webkit [151946] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Don't crash if renderName() is called on a renderer with no style
​https://bugs.webkit.org/show_bug.cgi?id=117960

Reviewed by Dave Hyatt.

Calling renderName() at the top of RenderObject::willChangeStyle() when
adding debug logging would often crash because various functions called
from renderName() assume style is non-null. Fix this.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::renderName):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::renderName):

6:14 PM Changeset in webkit [151945] by fpizlo@apple.com
  • 10 edits in branches/dfgFourthTier/Source

fourthTier: Count external memory usage towards heap footprint
​https://bugs.webkit.org/show_bug.cgi?id=117948

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Currently just count strings. Strings get counted in such a way that we won't re-count strings
that are aliased, by dividing by the reference count. This then ups the GC footprint and allows
the collector to appropriately amortize itself.

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::size):
(JSC::Heap::collect):

  • heap/Heap.h:

(Heap):

  • heap/SlotVisitor.h:
  • heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::reportExtraMemoryUsage):
(JSC):

  • runtime/JSString.cpp:

(JSC::JSString::visitChildren):

Source/WTF:

Expose some functionality needed for properly measuring StringImpl footprint.

  • wtf/Atomics.h:

(WTF::weakCompareAndSwapSize):
(WTF):

  • wtf/MathExtras.h:

(divideRoundedUp):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::cost):
(StringImpl):
(WTF::StringImpl::costDuringGC):
(WTF::StringImpl::refCount):

6:05 PM Changeset in webkit [151944] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Repeating sandbox violations when playing Amazon Prime videos with Flash
​https://bugs.webkit.org/show_bug.cgi?id=117953
<rdar://problem/14193693>

Patch by Simon Cooper <​scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.

Add some missing "standard" files for network service lookups

  • Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
6:03 PM Changeset in webkit [151943] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Plug-in sandbox violations attempting to access com.apple.CoreGraphics.plist
​https://bugs.webkit.org/show_bug.cgi?id=117963
<rdar://problem/14084234>

Patch by Simon Cooper <​scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.

Permit the reading of the com.apple.CoreGraphics preference file

  • Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
5:51 PM Changeset in webkit [151942] by jer.noble@apple.com
  • 5 edits in trunk/LayoutTests

[Mac] media/video-played-collapse.html is flakey on certain platforms.
​https://bugs.webkit.org/show_bug.cgi?id=117034

Reviewed by Beth Dakin.

This test does not wait until a seek completes before issuing a play()
command during its subtests. This can cause flakiness on some platforms
where playback will begin from the pre-seek currentTime. Wait for the seek
to complete before continuing the sub-tests.

Additionally, a 2s watchdog timeout is present to catch stalled tests. This
timeout is fine for short-duration sub-tests, but longer tests' durations
approach this 2s timeout period. Make the timeout the test duration + 2s.

  • media/video-played-collapse-expected.txt:
  • media/video-played-collapse.html:
  • media/video-played.js:

(playForMillisecs.callPauseIfTimeIsReached):
(playForMillisecs):

  • platform/mac-wk2/TestExpectations:
5:41 PM Changeset in webkit [151941] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

com.oracle.javadeployment.plist is not correctly specified in the JavaApplet plugin profile
​https://bugs.webkit.org/show_bug.cgi?id=117961
<rdar://problem/14223823>

Patch by Simon Cooper <​scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.

Remove the trailing extraneous .plist from the preference file rule

  • Resources/PlugInSandboxProfiles/com.oracle.java.JavaAppletPlugin.sb:
5:40 PM Changeset in webkit [151940] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

PluginProcess sandbox violations on com.apple.networkConnect.plist when resetting Safari
​https://bugs.webkit.org/show_bug.cgi?id=117958
<rdar://problem/13938149>

Patch by Simon Cooper <​scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.

Allow reading the com.apple.networkConnect plist.

  • Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb:
5:38 PM Changeset in webkit [151939] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Java sandbox violation ipc-posix-shm-read-data /tmp/com.apple.csseed.67
​https://bugs.webkit.org/show_bug.cgi?id=117954
<rdar://problem/14166577>

Patch by Simon Cooper <​scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.

Permit read access to this shared memory segment

  • Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
5:37 PM Changeset in webkit [151938] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Plugin Sandbox violation in /Library/Audio/Sounds/Banks
​https://bugs.webkit.org/show_bug.cgi?id=117957
<rdar://problem/14163582>

Patch by Simon Cooper <​scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.

Permit read access to subdirectories under /Library/Audio/Sounds

  • Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
5:15 PM Changeset in webkit [151937] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

Windows build links to opengl32.lib to allow WebGL compiling.
​https://bugs.webkit.org/show_bug.cgi?id=117949

Reviewed by Brent Fulgham.

  • WebKit.vcxproj/WebKit/WebKitCommon.props: Added link to opengl32.lib.
5:05 PM Changeset in webkit [151936] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Only resume root layer commits for visible WebPages
​https://bugs.webkit.org/show_bug.cgi?id=117956
​https://jira.bbqnx.net/browse/BRWSR-12047
JIRA428381

Patch by Jakob Petsovits <​jpetsovits@blackberry.com> on 2013-06-24
Reviewed by George Staikos.

In r150629, the code from that change introduced to
suspend and resume root layer commits would not take into
account whether the page is actually visible.

Because application activation state is usually conveyed
to all or any WebPages, this would mean on transitioning
into an active application state, we were resuming
root layer commits that might have previously been
disabled for visibility reasons.

Fix this by going through a single function that knows
by itself whether to suspend or resume root layer commits,
so the calling code doesn't have a chance to get it wrong.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::setVisible):
(BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
(BlackBerry::WebKit::WebPagePrivate::updateRootLayerCommitEnabled):

  • Api/WebPage_p.h:

(WebPagePrivate):

4:34 PM Changeset in webkit [151935] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Added /d option to xcopy to prevent unnecessary copying and compiling.
​https://bugs.webkit.org/show_bug.cgi?id=117951

Reviewed by Brent Fulgham.

  • WebCore.vcxproj/WebCorePreBuild.cmd:
4:27 PM Changeset in webkit [151934] by Simon Fraser
  • 3 edits
    2 adds in trunk

Fix various crashes on sites with fixed backgrounds
​https://bugs.webkit.org/show_bug.cgi?id=117959

Source/WebCore:

Reviewed by Andy Estes.

FrameView::removeSlowRepaintObject() would assume that addSlowRepaintObject()
had been called before it, but this isn't always the case. For example, if
a page has a fixed background on the body, this falls into the accelerated
path in WK2 tiled mode, so addSlowRepaintObject() is never called. However,
we still call removeSlowRepaintObject() if the body is removed.

So null-check m_slowRepaintObjects to avoid crashing.

Test: platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-removal.html

  • page/FrameView.cpp:

(WebCore::FrameView::removeSlowRepaintObject):

LayoutTests:

Reviewed by Andy Estes.

Test that does a document.write on a page with a fixed background on the body.

  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-removal-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-removal.html: Added.
3:56 PM Changeset in webkit [151933] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Make MiniBrowser paginated mode work with WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=117950

Reviewed by Beth Dakin.

  • MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController isPaginated]):
(-[WK1BrowserWindowController togglePaginationMode:]):
Hook up isPaginated and togglePaginationMode just as for WebKit2.

3:49 PM Changeset in webkit [151932] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Make sure m_iconDatabaseImpl is not null before closing it
​https://bugs.webkit.org/show_bug.cgi?id=117943

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-06-24
Reviewed by Simon Fraser.

Since r150474 WebIconDatabase is closed unconditionally in
TestController destructor, in that case WebKitTestRunner crashes
when no icon database path is set. This misbehavior was observed in
ports such as efl and nix.
In this patch, WebIconDatabase::close() calls m_iconDatabaseImpl->close()
only if m_iconDatabaseImpl is not null, as it's already being done in other
WebIconDatabase's methods, such as isOpen().

  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::close):

2:36 PM Changeset in webkit [151931] by hmuller@adobe.com
  • 1 edit
    2 copies
    2 moves in trunk/LayoutTests

[CSS Shapes] split test shape-inside-first-fit-001.html into 800x600 parts
​https://bugs.webkit.org/show_bug.cgi?id=117939

Reviewed by Dirk Schulze.

Split the test into two parts, to ensure that it first within the 800x600 limit.

  • fast/exclusions/shape-inside/shape-inside-first-fit-001-horizontal-expected.html: Copied from LayoutTests/fast/exclusions/shape-inside/shape-inside-first-fit-001-expected.html.
  • fast/exclusions/shape-inside/shape-inside-first-fit-001-horizontal.html: Copied from LayoutTests/fast/exclusions/shape-inside/shape-inside-first-fit-001.html.
  • fast/exclusions/shape-inside/shape-inside-first-fit-001-vertical-expected.html: Renamed from LayoutTests/fast/exclusions/shape-inside/shape-inside-first-fit-001-expected.html.
  • fast/exclusions/shape-inside/shape-inside-first-fit-001-vertical.html: Renamed from LayoutTests/fast/exclusions/shape-inside/shape-inside-first-fit-001.html.
2:33 PM Changeset in webkit [151930] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

bisect-builds: improve heuristic for choosing the next build after a broken build
<​http://webkit.org/b/117918>

Reviewed by Simon Fraser.

  • Scripts/bisect-builds: When a build is broken, use a heuristic

that "bisects" the left side or the right side of the remaining
revisions to pick a revision that's sufficiently different from
the revision of the broken build. This heuristic assumes there
is a sequential range of broken builds whenever one broken build
is found.

2:32 PM Changeset in webkit [151929] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Expose the mediaHasAudio() function in WK2
​https://bugs.webkit.org/show_bug.cgi?id=117946
<rdar://problem/14250527>

Patch by Ruth Fong <​ruth_fong@apple.com> on 2013-06-24
Reviewed by Beth Dakin.

Source/WebCore:

  • WebCore.exp.in: Updated to include symbol for

HTMLMediaElement::mediaHasAudio() function.

Source/WebKit2:

Exposes the WebCore::HTMLMediaElement::mediaHasAudio() function
in WK2.

  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:

(WKBundleHitTestResultMediaHasAudio): Added.

  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:

(WebKit::InjectedBundleHitTestResult::mediaHasAudio): Added.

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
2:28 PM Changeset in webkit [151928] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[CSS Shapes] Remove setCSSShapesEnabled(true) from shape-inside-empty-expected.html since it isn't using shapes
​https://bugs.webkit.org/show_bug.cgi?id=117945

Reviewed by Dirk Schulze.

  • fast/exclusions/shape-inside/shape-inside-empty-expected.html:
2:09 PM Changeset in webkit [151927] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r147591): can't type in Adobe Connect
​https://bugs.webkit.org/show_bug.cgi?id=117947
<rdar://problem/14223539>

Reviewed by Andreas Kling.

With the change in r147591, it is now possible for a plug-in element to be focused before the plug-in
starts. Handle this by focusing the plug-in right after it's started if necessary.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::didInitializePlugin):

2:02 PM Changeset in webkit [151926] by Simon Fraser
  • 20 edits
    1 delete in trunk/Source

Move displayID stuff from Widget to Chrome
​https://bugs.webkit.org/show_bug.cgi?id=117944

Reviewed by Anders Carlsson.

In r151877 I polluted Widget with displayID-related stuff. This would
be better on HostWindow, so move it there. This is a net code reduction,
and eliminates PlatformScreenMac.h, and the NSScreen category.

Source/WebCore:

  • WebCore.exp.in: Remove some functions from the exports list.
  • WebCore.xcodeproj/project.pbxproj: PlatformScreenMac.h is gone!
  • dom/Document.cpp:

(WebCore::Document::requestAnimationFrame): Get the displayID from page->chrome()

  • page/Chrome.cpp:

(WebCore::Chrome::Chrome): Initialize m_displayID.
(WebCore::Chrome::displayID):
(WebCore::Chrome::windowScreenDidChange): Code moved from Page; save the
displayID, and tell all subframes that the displayID changed.

  • page/Chrome.h: Add displayID-related functions.
  • page/FrameView.cpp: Removed windowDisplayID().
  • page/FrameView.h: Ditto.
  • page/Page.cpp: Removed code.

(WebCore::Page::Page):

  • page/Page.h:
  • platform/HostWindow.h: Added virtual displayID-related functions.
  • platform/Widget.cpp: Removed code.
  • platform/Widget.h: Ditto.
  • platform/mac/PlatformScreenMac.h: Removed.
  • platform/mac/PlatformScreenMac.mm: Removed the NSScreen category.

(WebCore::displayIDFromScreen):
(WebCore::screenForDisplayID):
(WebCore::displayFromWidget):
(WebCore::screenForWidget):

  • platform/mac/WidgetMac.mm: Removed windowDisplayID().
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::notifyFlushBeforeDisplayRefresh): Get
the displayID via chrome().

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView doWindowDidChangeScreen]): Go via chrome().

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowScreenDidChange): Go via chrome().

1:52 PM Changeset in webkit [151925] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Don't create Document's selector query cache just to invalidate it.
<​http://webkit.org/b/117942>

Reviewed by Anders Carlsson.

If Document::m_selectorQueryCache is null, there's nothing to invalidate,
so don't go through the trouble of creating a query cache.

  • dom/Document.cpp:

(WebCore::Document::setCompatibilityMode):
(WebCore::Document::updateBaseURL):

1:46 PM Changeset in webkit [151924] by Brent Fulgham
  • 25 edits
    11 adds
    3 deletes in trunk/LayoutTests

AX: Make tests usable on Mac and Windows
​https://bugs.webkit.org/show_bug.cgi?id=117901

Reviewed by Chris Fleizach.

  • accessibility/aria-checkbox-text.html:
  • accessibility/aria-hidden-expected.txt:
  • accessibility/aria-hidden-with-elements-expected.txt:
  • accessibility/aria-hidden-with-elements.html:
  • accessibility/aria-hidden.html:
  • accessibility/aria-labelledby-overrides-label-expected.txt:
  • accessibility/aria-labelledby-overrides-label.html:
  • accessibility/aria-option-role.html:
  • accessibility/aria-presentational-role-expected.txt:
  • accessibility/aria-presentational-role.html:
  • accessibility/aria-tab-roles-expected.txt:
  • accessibility/aria-tab-roles.html:
  • accessibility/empty-image-with-title-expected.txt:
  • accessibility/empty-image-with-title.html:
  • accessibility/html-html-element-is-ignored-expected.txt:
  • accessibility/html-html-element-is-ignored.html:
  • accessibility/img-aria-button-alt-tag-expected.txt:
  • accessibility/img-aria-button-alt-tag.html:
  • accessibility/input-image-alt-expected.txt:
  • accessibility/input-image-alt.html:
  • platform/mac/accessibility/aria-checkbox-text-expected.txt:
  • platform/mac/accessibility/aria-option-role-expected.txt:
  • platform/win/accessibility/aria-checkbox-text-expected.txt: Added.
  • platform/win/accessibility/aria-hidden-expected.txt: Added.
  • platform/win/accessibility/aria-hidden-with-elements-expected.txt: Added.
  • platform/win/accessibility/aria-labelledby-overrides-label-expected.txt: Added.
  • platform/win/accessibility/aria-option-role-expected.txt: Added.
  • platform/win/accessibility/aria-presentational-role-expected.txt: Added.
  • platform/win/accessibility/aria-tab-roles-expected.txt: Added.
  • platform/win/accessibility/empty-image-with-title-expected.txt: Added.
  • platform/win/accessibility/html-html-element-is-ignored-expected.txt: Added.
  • platform/win/accessibility/img-aria-button-alt-tag-expected.txt: Added.
  • platform/win/accessibility/input-image-alt-expected.txt: Added.
  • platform/win/aria-labelledby-on-input-expected.txt: Removed.
  • platform/win/aria-menubar-menuitems-expected.txt: Removed.
  • platform/win/aria-roles-expected.txt: Removed.
1:26 PM Changeset in webkit [151923] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Makefile build fix for AppleWindows.

1:09 PM Changeset in webkit [151922] by robert@webkit.org
  • 2 edits in trunk/Source/WebCore

Refactor adding a line break
​https://bugs.webkit.org/show_bug.cgi?id=117907

Reviewed by Ryosuke Niwa.

Reduce code duplication when adding a line break.

No new tests, refactoring.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::addLineBreak):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

12:53 PM Changeset in webkit [151921] by roger_fong@apple.com
  • 2 edits in trunk/Source/WTF

Unreviewed. AppleWin build fix, followup to r151915.

  • WTF.vcxproj/WTFProduction.props:
12:08 PM Changeset in webkit [151920] by mikhail.pozdnyakov@intel.com
  • 4 edits in trunk/Source

HashMap: reverse the order of the template arguments at alternate 'find', 'contains' and 'add' methods
​https://bugs.webkit.org/show_bug.cgi?id=117911

Reviewed by Anders Carlsson.

The order of the template arguments at HashMap alternate 'find', 'contains' and
'add' methods is reversed so that callers can just pass the translator
and let the compiler deduce input argument type.

Another rational is consistency with HashSet class.

Source/WebCore:

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::get):
(WebCore::HTTPHeaderMap::contains):
(WebCore::HTTPHeaderMap::add):

Source/WTF:

  • wtf/HashMap.h:
11:47 AM Changeset in webkit [151919] by robert@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary check in RenderBlockLineLayout::nextSegmentBreak()
​https://bugs.webkit.org/show_bug.cgi?id=117713

Reviewed by David Hyatt.

Changeset r151613 should have done this instead. Since r151518 changed
nextSegmentBreak() to detect line-break opportunities between no-wrap
inlines there is no need to force the break later.

No new tests, covered by existing tests.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

11:06 AM Changeset in webkit [151918] by Antoine Quint
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: WebInspector.displayNameForURL() failure prevents DOM inspection
​https://bugs.webkit.org/show_bug.cgi?id=117927

Handle possible mis-encoded URI fragments passed to decodeURIComponent() which
could prevent inspection of the DOM.

Reviewed by Timothy Hatcher.

  • UserInterface/Main.js:

(WebInspector.displayNameForURL):

10:42 AM Changeset in webkit [151917] by ggaren@apple.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Added a Radar number to my last ChangeLog

10:12 AM Changeset in webkit [151916] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Potential crash when in-band track is removed
​https://bugs.webkit.org/show_bug.cgi?id=117938
<rdar://problem/14246763>

Reviewed by Jer Noble.

This is timing dependent and I was unable to come up with a reliable test.

  • html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::willRemoveTextTrackPrivate): Early return if the media element

has been cleared.

9:25 AM Changeset in webkit [151915] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk/Source/WTF

[WinCairo] WTF.dll is linking with CoreFoundation.lib in VS2010.
​https://bugs.webkit.org/show_bug.cgi?id=117294

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-06-24
Reviewed by Brent Fulgham.

WinCairo build should not use CoreFoundation.

  • WTF.vcxproj/WTFCFLite.props: Added.
  • WTF.vcxproj/WTFCommon.props: Remove CoreFoundation.lib from depencency list.
  • WTF.vcxproj/WTFCoreFoundation.props: Added.
  • WTF.vcxproj/WTFDebug.props: Import WTFCoreFoundation.props for WinApple.
  • WTF.vcxproj/WTFDebugWinCairo.props: Import WTFCFLite.props for WinCairo.
  • WTF.vcxproj/WTFRelease.props: Import WTFCoreFoundation.props for WinApple.
  • WTF.vcxproj/WTFReleaseWinCairo.props: Import WTFCFLite.props for WinCairo.
9:21 AM Changeset in webkit [151914] by crogers@google.com
  • 21 edits
    3 moves in trunk

WaveTable name has changed to PeriodicWave
​https://bugs.webkit.org/show_bug.cgi?id=117748

Reviewed by Jer Noble.

Source/WebCore:

See related Web Audio bug and spec change:
​https://www.w3.org/Bugs/Public/show_bug.cgi?id=19561
​https://dvcs.w3.org/hg/audio/rev/7c4a40a9bb57

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createPeriodicWave):

  • Modules/webaudio/AudioContext.h:
  • Modules/webaudio/AudioContext.idl:
  • Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::OscillatorNode):
(WebCore::OscillatorNode::setType):
(WebCore::OscillatorNode::calculateSampleAccuratePhaseIncrements):
(WebCore::OscillatorNode::process):
(WebCore::OscillatorNode::setPeriodicWave):
(WebCore::OscillatorNode::propagatesSilence):

  • Modules/webaudio/OscillatorNode.h:
  • Modules/webaudio/OscillatorNode.idl:
  • Modules/webaudio/PeriodicWave.cpp: Renamed from Source/WebCore/Modules/webaudio/WaveTable.cpp.

(WebCore::PeriodicWave::create):
(WebCore::PeriodicWave::createSine):
(WebCore::PeriodicWave::createSquare):
(WebCore::PeriodicWave::createSawtooth):
(WebCore::PeriodicWave::createTriangle):
(WebCore::PeriodicWave::PeriodicWave):
(WebCore::PeriodicWave::waveDataForFundamentalFrequency):
(WebCore::PeriodicWave::maxNumberOfPartials):
(WebCore::PeriodicWave::numberOfPartialsForRange):
(WebCore::PeriodicWave::createBandLimitedTables):
(WebCore::PeriodicWave::generateBasicWaveform):

  • Modules/webaudio/PeriodicWave.h: Renamed from Source/WebCore/Modules/webaudio/WaveTable.h.

(WebCore::PeriodicWave::rateScale):
(WebCore::PeriodicWave::periodicWaveSize):
(WebCore::PeriodicWave::sampleRate):
(WebCore::PeriodicWave::numberOfRanges):

  • Modules/webaudio/PeriodicWave.idl: Renamed from Source/WebCore/Modules/webaudio/WaveTable.idl.
  • Target.pri:
  • WebCore.xcodeproj/project.pbxproj:

Tools:

  • Scripts/do-webcore-rename:

LayoutTests:

  • fast/js/global-constructors-attributes-expected.txt:
  • webaudio/oscillator-basic-expected.txt:
  • webaudio/oscillator-basic.html:
  • webaudio/oscillator-custom.html:
  • webaudio/resources/oscillator-testing.js:

(generateExponentialOscillatorSweep):

8:35 AM Changeset in webkit [151913] by Brent Fulgham
  • 1 edit
    1 move in trunk/LayoutTests

[Mac] Unreviewed build correction after r151868
New test expecation had been placed in the wrong directory.

  • platform/mac/accessibility/listitem-title-expected.txt: Copied from platform/mac/listitem-title-actual.txt.
  • platform/mac/listitem-title-actual.txt: Removed.
8:14 AM Changeset in webkit [151912] by Christophe Dumez
  • 3 edits in trunk/Source/WebCore

Commented IDL implements statements should not impact code generation
​https://bugs.webkit.org/show_bug.cgi?id=117932

Reviewed by Kentaro Hara.

Fix regular expression in preprocess-idls.pl script so that commented
IDL implements statements no longer cause any code to be generated.

No new tests, covered by TestObj.idl.

  • bindings/scripts/preprocess-idls.pl:

(getImplementedInterfacesFromIDL):

  • bindings/scripts/test/TestObj.idl:
8:12 AM Changeset in webkit [151911] by kangil.han@samsung.com
  • 10 edits in trunk/Source/WebCore

Adopt is/toHTMLStyleElement for minor code cleanup
​https://bugs.webkit.org/show_bug.cgi?id=117917

Reviewed by Antti Koivisto.

This patch refers to ​http://src.chromium.org/viewvc/blink?view=revision&revision=152853

There are some usages of static_cast to HTMLStyleElement so this patch creates toHTMLStyleElement
function for code cleanup. Plus, isHTMLStyleElement is also made for same purpose.

  • css/CSSStyleSheet.cpp:

(WebCore::isAcceptableCSSStyleSheetParent):

  • css/StyleScopeResolver.cpp:

(WebCore::StyleScopeResolver::scopeFor):

  • css/StyleSheetList.cpp:

(WebCore::StyleSheetList::getNamedItem):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):

  • dom/Node.cpp:

(WebCore::Node::numberOfScopedHTMLStyleChildren):

  • html/HTMLStyleElement.h:

(WebCore::isHTMLStyleElement):
(WebCore::toHTMLStyleElement):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::inlineStyleSheetText):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

8:09 AM Changeset in webkit [151910] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Cleanup RenderThemeWin after r151783 and r151794.
​https://bugs.webkit.org/show_bug.cgi?id=117936

Reviewed by Alexis Menard.

GetSysColor() takes an integer as argument. Let cssValueIdToSysColorIndex()
return an int instead of casting the values to the CSSValueID type.

  • rendering/RenderThemeWin.cpp:

(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWin::systemColor):

7:16 AM Changeset in webkit [151909] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Use SetFilePointer instead of SetFilePointerEx in FileSystemWin
​https://bugs.webkit.org/show_bug.cgi?id=116205

Reviewed by Ryosuke Niwa.

SetFilePointerEx is not available on Windows CE, so use SetFilePointer.
Also add a extra return for the case of an failure.

  • platform/win/FileSystemWin.cpp:

(WebCore::seekFile):

7:07 AM Changeset in webkit [151908] by Christophe Dumez
  • 7 edits
    1 copy in trunk/Source/WebCore

Introduce WindowTimers IDL interface
​https://bugs.webkit.org/show_bug.cgi?id=117929

Reviewed by Kentaro Hara.

Introduce WindowTimers IDL interface and have both DOMWindow and WorkerContext
implement it to match the latest specification and avoid IDL duplication:

No new tests, no behavior change.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • page/DOMWindow.idl:
  • page/WindowTimers.idl:
  • workers/WorkerContext.idl:
6:58 AM Changeset in webkit [151907] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for WinCE after r151563.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::toInt8): Use fabs() instead of abs().
(WebCore::toUInt8): Ditto.

6:09 AM Changeset in webkit [151906] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for WinCE after r151783.

  • rendering/RenderThemeWinCE.cpp:

(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWinCE::systemColor):

5:31 AM Changeset in webkit [151905] by ryuan.choi@samsung.com
  • 2 edits in trunk

[CMAKE] Clear unused cmakedefines
​https://bugs.webkit.org/show_bug.cgi?id=117931

Reviewed by Christophe Dumez.

  • Source/cmakeconfig.h.cmake:

Removed ENABLE_AS_IMAGE, ENABLE_LEGACY_WEBKIT_BLOB_BUILDER and
ENABLE_CLIENT_BASED_GEOLOCATION cmakedefines which already removed.

2:38 AM Changeset in webkit [151904] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Implement unit test callback: onWordGuesses.
​https://bugs.webkit.org/show_bug.cgi?id=117794

Patch by Krzysztof Wolanski <​k.wolanski@samsung.com> on 2013-06-24
Reviewed by Christophe Dumez.

  • UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:

(onWordGuesses):
Add client suggestions for the word.

(checkClientSuggestionsForWord):
Verify the suggestions that were given by the client.

2:32 AM Changeset in webkit [151903] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r151021.
​http://trac.webkit.org/changeset/151021
​https://bugs.webkit.org/show_bug.cgi?id=117924

caused regressions on Qt and GTK (#117141 and #117688)
(Requested by philn on #webkit).

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webkit_web_src_init):
(webKitWebSrcFinalize):
(webKitWebSrcSetProperty):
(webKitWebSrcGetProperty):
(webKitWebSrcStop):
(webKitWebSrcStart):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri):
(webKitWebSrcNeedDataMainCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcSeekMainCb):
(webKitWebSrcSeekDataCb):
(StreamingClient::StreamingClient):
(StreamingClient::~StreamingClient):
(StreamingClient::didReceiveResponse):
(StreamingClient::didReceiveData):
(StreamingClient::didFinishLoading):
(StreamingClient::wasBlocked):
(StreamingClient::cannotShowURL):

2:09 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
2:04 AM Changeset in webkit [151902] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0

Merge r151791 - [GTK] remove bashism from configure
​https://bugs.webkit.org/show_bug.cgi?id=117796

Reviewed by Gustavo Noronha Silva.

  • Source/autotools/FindDependencies.m4: Perform string appending by redeclaring the base string to the value

of the base string followed by the string that's being appended. This replaces the use of the '+=' operator
that works under bash but is not supported by other shells.

1:49 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
1:46 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
1:44 AM Changeset in webkit [151901] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r148279 - [GTK] Webkit fails to build webkit2gtk-tests-resources.gresource.
​https://bugs.webkit.org/show_bug.cgi?id=114485

Patch by Hanyee Kim <​choco@company100.net> on 2013-04-12
Reviewed by Martin Robinson.

Generating webkit2gtk-tests-resources.gresource can be failed due to
the non-existing target directory.
We need to make target directory before generating it.

  • UIProcess/API/gtk/tests/GNUmakefile.am:
1:41 AM Changeset in webkit [151900] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r148125 - Fixed build failure in Plugin.h: FloatPoint was not in namespace WebCore

make[1]: * Waiting for unfinished jobs....
In file included from Source/WebKit2/PluginProcess/PluginCreationParameters.h:31:0,

from Source/WebKit2/PluginProcess/PluginCreationParameters.cpp:27:

./Source/WebKit2/WebProcess/Plugins/Plugin.h:268:58: error: 'FloatPoint' in namespace 'WebCore' does not name a type
./Source/WebKit2/WebProcess/Plugins/Plugin.h:268:77: error: ISO C++ forbids declaration of 'parameter' with no type [-fpermissive]
cc1plus: warning: unrecognized command line option "-Wno-c++11-extensions" [enabled by default]
make[1]: * [Source/WebKit2/PluginProcess/libwebkit2gtk_3_0_la-PluginCreationParameters.lo] Error 1

It now passes that make target.

​https://bugs.webkit.org/show_bug.cgi?id=111862

Patch by Tobias Mueller <​tobiasmue@gnome.org> on 2013-04-10
Reviewed by Darin Adler.

  • WebProcess/Plugins/Plugin.h:

(WebCore): Added FloatPoint to the WebCore namespace

1:37 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
1:32 AM Changeset in webkit [151899] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r151492 - [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
​https://bugs.webkit.org/show_bug.cgi?id=116723

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

  • GNUmakefile.am: When generating the WebCoreLayerGtk2.a archive from all the dependency archives, remove the

current archive (if any). Updating an existent archive in an incremental build is not bulletproof and can lead
to corrupt archives and subsequent build failures. On the other hand, the archive generation is not expensive
and produces a working archive without problems even on incremental builds.

1:31 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
1:26 AM Changeset in webkit [151898] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r150884 - Unreviewed. Fix make distcheck.

Source/WebKit2:

  • GNUmakefile.am: Add WebCoreLayerGtk2.a to DISTCLEANFILES.
1:03 AM Changeset in webkit [151897] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipping the crashing tests on debug bots.
​https://bugs.webkit.org/show_bug.cgi?id=94458

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-06-24

  • platform/qt/TestExpectations:
12:58 AM Changeset in webkit [151896] by Christophe Dumez
  • 8 edits in trunk/Source/WebCore

Move IDL implements statements to IDL files that implement the interface
​https://bugs.webkit.org/show_bug.cgi?id=117921

Reviewed by Kentaro Hara.

Move IDL implements statements to IDL files that implement the interface
so that we can more easily know that a given IDL interface implements
another.

The generator now enforces this as well for consistency.

No new tests, covered by TestImplements.idl.

  • bindings/scripts/preprocess-idls.pl:

(getImplementedInterfacesFromIDL):

  • bindings/scripts/test/TestImplements.idl:
  • bindings/scripts/test/TestInterface.idl:
  • dom/CharacterData.idl:
  • dom/ChildNode.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
12:58 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
12:52 AM Changeset in webkit [151895] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

[GTK] Merge r150008 into the webkit-2.0 branch
​https://bugs.webkit.org/show_bug.cgi?id=117889

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2013-06-21
Reviewed by Carlos Garcia Campos.

  • GNUmakefile.am: Merge r150008 with some changes, for instance not listing libPlatform.la, libPlatformGtk2.la

and libANGLE.la among the webcore layer dependencies as these libtool archives were created after the 2.0 branching.

  • GNUmakefile.list.am: Merge r150008.
12:32 AM Changeset in webkit [151894] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Hittest finds the truncated text instead of the floating input, when the input is clicked.
​https://bugs.webkit.org/show_bug.cgi?id=115675

Patch by Zalan Bujtas <Alan Bujtas> on 2013-06-24
Reviewed by David Hyatt.

Ignore truncated text on inline textbox and everything beyond the ellipsis box on
the root inlinebox while hittesting. (provided that nodeAtPoint finds no hit for any of
the root inline's children.)

Source/WebCore:

Test: fast/css/text-overflow-ellipsis-and-floating-input-hittest.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::nodeAtPoint):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::nodeAtPoint):
(WebCore::InlineTextBox::paint):

LayoutTests:

  • fast/css/text-overflow-ellipsis-and-floating-input-hittest-expected.txt: Added.
  • fast/css/text-overflow-ellipsis-and-floating-input-hittest.html: Added.

Jun 23, 2013:

11:20 PM Changeset in webkit [151893] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

AX: Rebaseline test after r151868
​https://bugs.webkit.org/show_bug.cgi?id=117892

Rubber stamped by Chris Fleizach.

  • platform/mac/accessibility/lists-expected.txt:
10:49 PM Changeset in webkit [151892] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening. Unskip two media tests because there is no crash after system update.

  • platform/efl/TestExpectations:
9:07 PM Changeset in webkit [151891] by fpizlo@apple.com
  • 1 edit in branches/dfgFourthTier/Source/WTF/ChangeLog

fourthTier: DFG should optimize identifier string equality
​https://bugs.webkit.org/show_bug.cgi?id=117920

Reviewed by Sam Weinig.

Note that this ChangeLog was supposed to be committed in r151890.

Expose the IsIdentifier bit to the JIT.

  • wtf/text/StringImpl.h:

(WTF::StringImpl::flagIsIdentifier):

9:05 PM Changeset in webkit [151890] by fpizlo@apple.com
  • 12 edits
    6 adds in branches/dfgFourthTier

fourthTier: DFG should optimize identifier string equality
​https://bugs.webkit.org/show_bug.cgi?id=117920

Source/JavaScriptCore:

Reviewed by Sam Weinig.

This is a 20% speed-up for string equality comparisons when both strings are
identifiers.

This is important for two reasons:

1) Using strings as enumerations is an idiom. A great example is typeof. It

would be great if this performed better.


2) When I implement switch_string in the DFG, it would be great to optimize

the case where the switched-on value is an identifier. That would involve
a simple binary switch rather than a more complicated trie-switch over
characters.

  • bytecode/SpeculatedType.cpp:

(JSC::dumpSpeculation):
(JSC::speculationToAbbreviatedString):
(JSC::speculationFromCell):

  • bytecode/SpeculatedType.h:

(JSC):
(JSC::isStringIdentSpeculation):
(JSC::isStringSpeculation):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateStringIdent):
(Node):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::compileStringEquality):
(JSC::DFG::SpeculativeJIT::compileStringIdentEquality):
(DFG):
(JSC::DFG::SpeculativeJIT::speculateString):
(JSC::DFG::SpeculativeJIT::speculateStringIdentAndLoadStorage):
(JSC::DFG::SpeculativeJIT::speculateStringIdent):
(JSC::DFG::SpeculativeJIT::speculate):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGUseKind.cpp:

(WTF::printInternal):

  • dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):
(JSC::DFG::isCell):

LayoutTests:

Reviewed by Sam Weinig.

Add a benchmark for string equality where there is a long identifier, and
also add a benchmark for non-identifier string equality (since the previous
test for string equality was really identifier equality).

  • fast/js/regress/script-tests/string-long-ident-equality.js: Added.

(foo):

  • fast/js/regress/script-tests/string-var-equality.js: Added.

(addFoo):
(foo):

  • fast/js/regress/string-long-ident-equality-expected.txt: Added.
  • fast/js/regress/string-long-ident-equality.html: Added.
  • fast/js/regress/string-var-equality-expected.txt: Added.
  • fast/js/regress/string-var-equality.html: Added.
6:41 PM Changeset in webkit [151889] by fpizlo@apple.com
  • 7 edits
    3 adds in branches/dfgFourthTier

Merge trunk r147965.

Source/JavaScriptCore:

2013-04-08 Filip Pizlo <​fpizlo@apple.com>


DFG should be able to inline string equality comparisons
​https://bugs.webkit.org/show_bug.cgi?id=114224


Reviewed by Oliver Hunt.


Inline 8-bit string equality, go to slow path for 16-bit strings. 2x speed-up for string equality
comparisons on 8-bit strings. 20-50% speed-up on JSRegress/HashMap tests. 30% speed-up on
string-fasta. 2% speed-up on SunSpider overall. Some small speed-ups elsewhere.


This is a gnarly change but we have loads of test coverage already between the HashMap tests and
preexisting DFG string equality tests (which appear to have been designed to test OSR exits, but
also give us good overall coverage on string equality behavior).


  • dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode):
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compilePeepHoleBranch): (JSC::DFG::SpeculativeJIT::compare): (JSC::DFG::SpeculativeJIT::compileStrictEq): (JSC::DFG::SpeculativeJIT::compileStringEquality): (DFG):
  • dfg/DFGSpeculativeJIT.h: (SpeculativeJIT):

LayoutTests:

2013-04-08 Filip Pizlo <​fpizlo@apple.com>


DFG should be able to inline string equality comparisons
​https://bugs.webkit.org/show_bug.cgi?id=114224


Reviewed by Oliver Hunt.


  • fast/js/regress/script-tests/string-equality.js: Added. (foo):
  • fast/js/regress/string-equality-expected.txt: Added.
  • fast/js/regress/string-equality.html: Added.
5:40 PM Changeset in webkit [151888] by Darin Adler
  • 17 edits in trunk/Source

Sort all the Xcode project files
​https://bugs.webkit.org/show_bug.cgi?id=117696

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

  • JavaScriptCore.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Source/ThirdParty:

  • gtest/xcode/Samples/FrameworkSample/WidgetFramework.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.
  • gtest/xcode/gtest.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Source/ThirdParty/ANGLE:

  • ANGLE.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Source/WebInspectorUI:

  • WebInspectorUI.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Source/WebKit2:

  • WebKit2.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Source/WTF:

  • WTF.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Jun 22, 2013:

11:24 PM Changeset in webkit [151887] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove redundant helper from RenderRegion.
​https://bugs.webkit.org/show_bug.cgi?id=117915

Patch by Zalan Bujtas <Alan Bujtas> on 2013-06-22
Reviewed by Andreas Kling.

Minor code cleanup.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::regionOversetState):
(WebCore::RenderRegion::setRegionOversetState):

  • rendering/RenderRegion.h:
11:14 PM Changeset in webkit [151886] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[EFL] Add support for MHTML save/load feature to MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=106620

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-06-22
Reviewed by Christophe Dumez.

Enable CTRL + S as save page in mhtml and CTRL + L to load any page
from filesystem.

  • MiniBrowser/efl/CMakeLists.txt:
  • MiniBrowser/efl/main.c:

(page_contents_callback):
(on_key_down):
(show_file_entry_dialog): generic function to show file enrty
selector dialogue

9:57 PM Changeset in webkit [151885] by fpizlo@apple.com
  • 10 edits
    6 adds in branches/dfgFourthTier

fourthTier: DFG shouldn't exit just because a String GetByVal went out-of-bounds
​https://bugs.webkit.org/show_bug.cgi?id=117906

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

This does the obvious thing, but also makes sure that out-of-bounds accesses
don't fall off into a C call, but try to do the fast thing if the prototype
chain is sane. We ought to probably do this for other array accesses in the
future, as well, since it's so darn easy.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::objectPrototypeIsSane):
(JSC):
(JSC::JSGlobalObject::arrayPrototypeChainIsSane):
(JSC::JSGlobalObject::stringPrototypeChainIsSane):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):

LayoutTests:

Reviewed by Mark Hahnenberg.

The out-of-bounds benchmark that isn't insane speeds up by 22x in this
patch.

  • fast/js/regress/script-tests/string-get-by-val-out-of-bounds-insane.js: Added.

(foo):

  • fast/js/regress/script-tests/string-get-by-val-out-of-bounds.js: Added.

(foo):

  • fast/js/regress/string-get-by-val-out-of-bounds-expected.txt: Added.
  • fast/js/regress/string-get-by-val-out-of-bounds-insane-expected.txt: Added.
  • fast/js/regress/string-get-by-val-out-of-bounds-insane.html: Added.
  • fast/js/regress/string-get-by-val-out-of-bounds.html: Added.
8:31 PM Changeset in webkit [151884] by jberlin@webkit.org
  • 5 edits in tags/Safari-537.46.5/Source

“Versioning.”

8:28 PM Changeset in webkit [151883] by jberlin@webkit.org
  • 1 copy in tags/Safari-537.46.5

New tag.

6:42 PM Changeset in webkit [151882] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: GC's put_by_id transition fixpoint should converge more quickly
​https://bugs.webkit.org/show_bug.cgi?id=117912

Reviewed by Mark Hahnenberg.

This was a rookie mistake. The GC does a classic forward data flow fixpoint. These work well so long as you
iterate the program in program order, or at least something close to program order. Because I enjoy reverse
loops ("while (n--) blah"), I ended up iterating in *reverse* of program order which ensured worst-case
pathologies every single time. And unsurprisingly, this slowed down a program, namely pdfjs.

Flipping the loops to iterate forward fixes a 90% regression in Octane/pdfjs and is otherwise neutral.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::propagateTransitions):

4:33 PM Changeset in webkit [151881] by dino@apple.com
  • 2 edits in trunk/Source/WebKit2

Slightly reduce width threshold on detection of primary snapshotted Plug-In
​https://bugs.webkit.org/show_bug.cgi?id=117914
<rdar://problem/14136687>

Reviewed by Simon Fraser.

We've noticed some content that should be detected as the primary snapshotted plug-in,
but is just a bit smaller than our 450x300 minimum threshold. Reduce the width to 400.

  • WebProcess/WebPage/WebPage.cpp: Change primarySnapshottedPlugInMinimumWidth from 450 to 400.
4:16 PM Changeset in webkit [151880] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix after r151878.

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::WebCoreAVFResourceLoader::startLoading): Pass the new UseDefaultOriginRestrictionsForType
argument to the ResourceLoaderOptions constructor.

1:29 PM Changeset in webkit [151879] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Followup from r151877 .
Fix crash in fast/frames/iframe-access-screen-of-deleted.html by null-checking the widget.

  • platform/mac/PlatformScreenMac.mm:

(WebCore::screenForWidget):

12:56 PM Changeset in webkit [151878] by hmuller@adobe.com
  • 14 edits
    3 adds in trunk

[CSS Shapes] limit shape image values to same origin
​https://bugs.webkit.org/show_bug.cgi?id=117610

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Restrict the image URL values for shape-inside and shape-outside to
the same origin as the document. The alpha channel of image shape values
will be thresholded to produce the shape's boundaries (see bug 116643)
so normal image access rules aren't secure enough.

Added a RequestOriginPolicy ResourceLoaderOption which is used by
StyleResolver::loadPendingShapeImage() to request the additional restriction.
The change should have no other effect although it does enable one to apply
the same restriction to other resources which can currently be loaded from
any origin - see CachedResourceLoader::canRequest().

Test: http/tests/security/shape-inside-image-origin.html

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::cachedImage): Add an effectively optional ResourceLoaderOptions parameter.

  • css/CSSImageValue.h:

(WebCore::CSSImageValue::cachedImage): Ditto.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingShapeImage): Load the image with the default CachedResourceLoader options plus RestrictToSameOrigin.
(WebCore::StyleResolver::loadPendingImages): Call loadPendingShapeImage().

  • css/StyleResolver.h:
  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::startLoadingMainResource): Update the ResourceLoaderOptions static variable.

  • loader/NetscapePlugInStreamLoader.cpp:

(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader): Ditto.

  • loader/ResourceLoader.h:

(WebCore::ResourceLoader::options):

  • loader/ResourceLoaderOptions.h: Add RequestOriginPolicy enum.

(WebCore::ResourceLoaderOptions::ResourceLoaderOptions):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest): Pass ResourceLoaderOptions along to revised CachedResourceLoader::canRequest().

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet): Update load() ResourceLoaderOptions.
(WebCore::CachedResourceLoader::canRequest): Replaced ContentSecurityPolicyCheck parameter with ResourceLoaderOptions.
(WebCore::CachedResourceLoader::requestResource): Pass ResourceLoaderOptions along to revised CachedResourceLoader::canRequest().
(WebCore::CachedResourceLoader::defaultCachedResourceOptions): Added UseDefaultOriginRestrictionsForType initializer.

  • loader/cache/CachedResourceLoader.h:
  • loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading): Added UseDefaultOriginRestrictionsForType intializer.

LayoutTests:

Verify that a non same-origin image URL specified for shape-inside or
shape-outside will not load and the shape property will be reset to "none".

  • http/tests/resources/square100.png: Added.
  • http/tests/security/shape-inside-image-origin-expected.txt: Added.
  • http/tests/security/shape-inside-image-origin.html: Added.
12:41 PM Changeset in webkit [151877] by Simon Fraser
  • 11 edits
    1 add in trunk/Source

screen.availWidth always returns width of primary display
​https://bugs.webkit.org/show_bug.cgi?id=117863

Source/WebCore:

Reviewed by Geoffrey Garen.

In WebKit2, Widgets have no platformWidget, so trying to get to the
NSScreen via the platform widget's window never succeeded, and we always
fell back on getting info for the main display.

However, we were already pushing the WKView's displayID down to the
WebProcess for the requestAnimationFrame infrastructure, so use that.

Add a virtual function on Widget windowDisplayID(), that is overridden
in FrameView to return the PlatformDisplayID which Page has.

Fix PlatformScreenMac to fall back to Widget::windowDisplayID() when it fails
to get an NSWindow from the Widget.

Add a utility category on NSScreen to get an NSScreen's displayID, and to
find an NSScreen given a displayID.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • page/FrameView.cpp:

(WebCore::FrameView::windowDisplayID):

  • page/FrameView.h:
  • platform/Widget.cpp:

(WebCore::Widget::windowDisplayID):

  • platform/Widget.h:
  • platform/mac/PlatformScreenMac.h: Added.
  • platform/mac/PlatformScreenMac.mm:

(+[NSScreen screenForDislayID:]):
(-[NSScreen displayID]):
(WebCore::screenRect):
(WebCore::screenAvailableRect):

  • platform/mac/WidgetMac.mm:

(WebCore::Widget::windowDisplayID):

Source/WebKit2:

Reviewed by Geoffrey Garen.

In WebKit2, Widgets have no platformWidget, so trying to get to the
NSScreen via the platform widget's window never succeeded, and we always
fell back on getting info for the main display.

However, we were already pushing the WKView's displayID down to the
WebProcess for the requestAnimationFrame infrastructure, so use that.

The WebProcess would not receive a displayID for a WKView until the window
was activated; fix by calling -doWindowDidChangeScreen when the view
moves to a window, rather than doing it from -_windowDidBecomeKey:.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidBecomeKey:]):

Note: See TracTimeline for information about the timeline view.