Timeline
Jul 1, 2013:
- 11:03 PM Changeset in webkit [152280] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC]: Fix maybe-uninitialized gcc 4.8 warning in DFGSpeculativeJIT.cpp
https://bugs.webkit.org/show_bug.cgi?id=118278
Patch by Sergio Correia <Sergio Correia> on 2013-07-01
Reviewed by Filip Pizlo.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
Initialize valueGPR with InvalidGPRReg.
- 9:33 PM Changeset in webkit [152279] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should run LICM after AA setup
https://bugs.webkit.org/show_bug.cgi?id=118277
Reviewed by Maciej Stachowiak.
LICM queries alias analysis. Hence, just like GVN, it should run after
we have set up the alias analysis.
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- 9:07 PM Changeset in webkit [152278] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should run AA passes before GVN
https://bugs.webkit.org/show_bug.cgi?id=118276
Rubber stamped by Geoffrey Garen.
These enable load elimination in GVN.
Immediately gives us a speed-up on a bunch of benchmarks I hacked to run
properly in the FTL. One example is 20% on imaging-gaussian-blur. (Fair
warning: the stock version of that benchmark won't see speed-ups -
probably slow-downs instead - because the FTL can't do OSR entry yet.)
Another example is the findGraphNode function, which now sees a 7%
speed-up, and that's without even doing LICM or other good things.
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- 7:00 PM Changeset in webkit [152277] by
-
- 3 edits in trunk/Tools
[Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
https://bugs.webkit.org/show_bug.cgi?id=118267
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-07-01
Reviewed by Gyuyoung Kim.
After r152226 (from https://bugs.webkit.org/show_bug.cgi?id=117249)
WEBKIT_OUTPUTDIR should be used instead of WEBKITOUPUTDIR. However
Efl's jhbuildrc is still using the WEBKITOUTPUTDIR environment variable.
- efl/jhbuildrc:
- gtk/jhbuildrc:
- 6:01 PM Changeset in webkit [152276] by
-
- 2 edits in trunk/Source/WebCore
Windows should be included in the list of platforms that can use OpenGL ES 2.
https://bugs.webkit.org/show_bug.cgi?id=118264
Reviewed by Dean Jackson.
- platform/graphics/GraphicsContext3D.h: Added PLATFORM(WIN) to platforms using OpenGL ES 2.
- 6:00 PM Changeset in webkit [152275] by
-
- 18 edits14 deletes in trunk
[GTK] Remove unsupported AC backends
https://bugs.webkit.org/show_bug.cgi?id=117362
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-07-01
Reviewed by Martin Robinson.
.:
- Source/autotools/FindDependencies.m4: remove checks related to acceleration backend,
turn them into a check for OpenGL being available, simply.
- Source/autotools/ReadCommandLineArguments.m4: remove command line option to select
accelerated backend, it's now auto-detected.
- Source/autotools/SetupAutoconfHeader.m4: no longer defines USE_CLUTTER and
USE_TEXTURE_MAPPER_CAIRO.
- Source/autotools/SetupAutomake.m4: remove checks related to acceleration backend,
turn them into a check for OpenGL being available, simply.
- Source/autotools/Versions.m4: no longer check for clutter/clutter-gtk.
Source/WebCore:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Source/WebCore/platform/graphics/PlatformLayer.h: Removed mentions of clutter
and the texmap cairo backend.
- platform/graphics/clutter/DrawingBufferClutter.cpp: Removed.
- platform/graphics/clutter/GraphicsContext3DClutter.cpp: Removed.
- platform/graphics/clutter/GraphicsContext3DPrivate.cpp: Removed.
- platform/graphics/clutter/GraphicsContext3DPrivate.h: Removed.
- platform/graphics/clutter/GraphicsLayerActor.cpp: Removed.
- platform/graphics/clutter/GraphicsLayerActor.h: Removed.
- platform/graphics/clutter/GraphicsLayerClutter.cpp: Removed.
- platform/graphics/clutter/GraphicsLayerClutter.h: Removed.
- platform/graphics/clutter/PlatformClutterAnimation.cpp: Removed.
- platform/graphics/clutter/PlatformClutterAnimation.h: Removed.
- platform/graphics/clutter/PlatformClutterLayerClient.h: Removed.
- platform/graphics/clutter/TransformationMatrixClutter.cpp: Removed.
- Source/WebCore/platform/graphics/transforms/TransformationMatrix.h: Removed cogl
matrix type conversion.
Source/WebKit/gtk:
- GNUmakefile.am:
- WebCoreSupport/AcceleratedCompositingContext.h: removed clutter and cairo
additions.
- WebCoreSupport/AcceleratedCompositingContextCairo.cpp: Removed.
- WebCoreSupport/AcceleratedCompositingContextClutter.cpp: Removed.
- webkit/webkitglobals.cpp:
(webkitInit): removed clutter-gtk initialization.
Tools:
- gtk/jhbuild-optional.modules: no longer needs clutter-gtk, clutter
and cogl, so removed.
- 5:45 PM Changeset in webkit [152274] by
-
- 7 edits in branches/safari-537-branch/Source/WebKit2
Merged r152273. <rdar://problem/13078036>
- 5:08 PM Changeset in webkit [152273] by
-
- 7 edits in trunk/Source/WebKit2
Clean up private browsing session tracking
https://bugs.webkit.org/show_bug.cgi?id=118266
<rdar://problem/13078036>
Reviewed by Brady Eidson.
Instead of counting API calls, we now watch actual WebPreferences objects.
- UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetPrivateBrowsingEnabled): Removed code that used to notify WebContext. It's now done by WebPreferences.
- UIProcess/WebContext.h:
- UIProcess/WebContext.cpp: (WebKit::WebContext::ensureNetworkProcess): Instead of counting the number of times API was called, rely on WebPreferences tracking. (WebKit::WebContext::willStartUsingPrivateBrowsing): Ditto. This function is now only called when we detect a change in private browsing state. (WebKit::WebContext::willStopUsingPrivateBrowsing): Ditto. (WebKit::WebContext::createNewWebProcess): Tell the new process to create a private browsing session if needed.
- UIProcess/WebPreferences.h:
- UIProcess/WebPreferences.cpp: (WebKit::WebPreferences::addPageGroup): Count how many page groups use private browsing, and notify WebContext when a session is needed. Note that we don't notify WebContext about WebPreferences without any page groups, because it's likely that preferences will be updated by the client before groups are associated. (WebKit::WebPreferences::removePageGroup): Ditto. (WebKit::WebPreferences::updateBoolValueForKey): Perform special handling for private browsing mode changes. (WebKit::WebPreferences::updatePrivateBrowsingValue): Notify WebContext when it's time to create or destroy a private browsing session. (WebKit::WebPreferences::anyPageGroupsAreUsingPrivateBrowsing): A getter for WebContext to know when any page groups are in private browsing mode.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): Don't create a private browsing session implicitly, UI process takes care of it.
- 4:36 PM Changeset in webkit [152272] by
-
- 6 edits2 copies in branches/safari-537-branch
Merged r152265. <rdar://problem/14301217>
- 4:33 PM Changeset in webkit [152271] by
-
- 3 edits in branches/safari-537-branch/Source/WebKit2
Merged r152266. <rdar://problem/14301166>
- 4:31 PM Changeset in webkit [152270] by
-
- 3 edits in branches/safari-537-branch/Source/WebKit2
Merged r152077. <rdar://problem/14270933>
- 4:21 PM Changeset in webkit [152269] by
-
- 4 edits in trunk/Source/WebCore
DrawingBuffer constructor and destructor were not defined for Windows.
I moved duplicate code from Cairo and Qt to DrawingBuffer.cpp to be used by Qt, Cairo, and Windows.
https://bugs.webkit.org/show_bug.cgi?id=118262
Reviewed by Dean Jackson.
- platform/graphics/cairo/DrawingBufferCairo.cpp: Removed duplicate DrawingBuffer constructor and destructor.
- platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer): Moved from Cairo and Qt implementation.
- platform/graphics/gpu/qt/DrawingBufferQt.cpp: Removed duplicate DrawingBuffer constructor and destructor.
- 3:44 PM Changeset in webkit [152268] by
-
- 2 edits in trunk/Source/WebCore
Fixed unreachable return when GLX or EGL are used with WebGL.
https://bugs.webkit.org/show_bug.cgi?id=118263
Reviewed by Noam Rosenthal.
- platform/graphics/opengl/GLPlatformContext.cpp:
(WebCore::createOffScreenContext): Fixed unreachable return.
- 3:23 PM Changeset in webkit [152267] by
-
- 14 edits in trunk
Link to WebInspectorUI.framework at build time instead of soft linking.
https://bugs.webkit.org/show_bug.cgi?id=118261
Reviewed by Joseph Pecoraro.
.:
- Source/Makefile: Build WebInspectorUI before WebKit and WebKit2.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Configurations/WebKit.xcconfig:
- WebCoreSupport/WebInspectorClient.mm:
(useWebKitWebInspector):
Source/WebKit2:
- Configurations/WebKit2.xcconfig:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/mac/WebInspectorMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
Tools:
- Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.
- 2:47 PM Changeset in webkit [152266] by
-
- 3 edits in trunk/Source/WebKit2
[wk2] TiledCoreAnimationDrawingArea should support scrolling its exposed rect
https://bugs.webkit.org/show_bug.cgi?id=118173
<rdar://problem/14301166>
Reviewed by Anders Carlsson.
Offset the exposed rect passed from the WKView by the main frame's current scroll position
before sending it to our TiledBackings, so that it is in the same coordinate space as their
ordinary visibleRects.
This has the side effect of making clips-to-exposed-rect testable (though useless) in Safari.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
Add updateScrolledExposedRect() and m_scrolledExposedRect.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scroll):
Call updateScrolledExposedRect when the main frame scrolls.
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):
Remove a FIXME about this change.
Call updateScrolledExposedRect instead of passing down the unscrolled rect.
(WebKit::TiledCoreAnimationDrawingArea::setClipsToExposedRect):
Call updateScrolledExposedRect, because that method will short-circuit if
setClipsToExposedRect is false, so we need to update here for correctness
if we get a setExposedRect(), setClipsToExposedRect(true) pair.
(WebKit::TiledCoreAnimationDrawingArea::updateScrolledExposedRect):
Update m_scrolledExposedRect and propagate it to our TiledBackings.
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer):
Use the scrolled exposed rect.
- 2:35 PM Changeset in webkit [152265] by
-
- 6 edits2 adds in trunk
Maximum scroll position can be negative in some cases
https://bugs.webkit.org/show_bug.cgi?id=118175
<rdar://problem/14301217>
Reviewed by Anders Carlsson.
Test (API): WebKit2.ResizeReversePaginatedWebView
- page/FrameView.cpp:
(WebCore::FrameView::maximumScrollPosition):
- page/FrameView.h:
Override maximumScrollPosition() in FrameView and don't clamp to zero if
a reverse pagination mode is enabled, as it is possible (and common) to
have a negative maximum scroll position with reverse pagination.
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
Drive-by adoption of toIntSize().
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
(TestWebKitAPI::didRunJavaScript):
(TestWebKitAPI::didLayout):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
Add a test that loads a vertical-lr document, paginates it horizontally
from right to left, resizes the view to fit the entire document, and
verifies that the scroll position is negative, as it must be for the
document to be enclosed by the view.
- 2:19 PM Changeset in webkit [152264] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152230. <rdar://problem/14306784>
- 2:17 PM Changeset in webkit [152263] by
-
- 3 edits in branches/safari-537-branch/Source/WebCore
Merged r152204. <rdar://problem/14205335>
- 2:16 PM Changeset in webkit [152262] by
-
- 2 edits in branches/safari-537-branch/Source/WebInspectorUI
Merged r152200. <rdar://problem/14308488>
- 2:13 PM Changeset in webkit [152261] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152187. <rdar://problem/14250167>
- 2:12 PM Changeset in webkit [152260] by
-
- 3 edits2 copies in branches/safari-537-branch
Merged r152185. <rdar://problem/13926528>
- 2:10 PM Changeset in webkit [152259] by
-
- 6 edits in branches/safari-537-branch/Source/WebKit2
Merged r152182. <rdar://problem/14255677>
- 2:09 PM Changeset in webkit [152258] by
-
- 4 edits2 copies in branches/safari-537-branch/Source/WebInspectorUI
Merged r152092. <rdar://problem/5847649>
- 2:07 PM Changeset in webkit [152257] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152075. <rdar://problem/14271105>
- 2:05 PM Changeset in webkit [152256] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152073. <rdar://problem/14194077>
- 2:04 PM Changeset in webkit [152255] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152072. <rdar://problem/13643935>
- 2:02 PM Changeset in webkit [152254] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152063. <rdar://problem/13888138>
- 2:00 PM Changeset in webkit [152253] by
-
- 13 edits in branches/safari-537-branch/Source
Merged r152234. <rdar://problem/14083280>
- 1:57 PM Changeset in webkit [152252] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152231. <rdar://problem/14321403>
- 1:54 PM Changeset in webkit [152251] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152207. <rdar://problem/14242032>
- 1:53 PM Changeset in webkit [152250] by
-
- 2 edits in branches/safari-537-branch/Source/WebCore
Merged r152202. <rdar://problem/14247819>
- 1:45 PM Changeset in webkit [152249] by
-
- 2 edits in trunk/Source/WebKit2
Properly hide the header and footer banners if they are set to null.
https://bugs.webkit.org/show_bug.cgi?id=118219
Reviewed by Beth Dakin.
Call Page::addFooterWithHeight(0) to remove the parent layer that hosts the banner when
the footer banner is detached. Similarly for the header banner.
- WebProcess/WebPage/mac/PageBannerMac.mm:
(WebKit::PageBanner::detachFromPage):
- 1:43 PM Changeset in webkit [152248] by
-
- 4 edits4 copies in branches/safari-537-branch
Merged r152198. <rdar://problem/13488092>
- 1:39 PM Changeset in webkit [152247] by
-
- 4 edits2 copies in branches/safari-537-branch
Merged r152196. <rdar://problem/14259249>
- 1:38 PM Changeset in webkit [152246] by
-
- 6 edits in branches/safari-537-branch/Source/WebCore
Merged r152194. <rdar://problem/14261627>
- 1:36 PM Changeset in webkit [152245] by
-
- 11 edits in branches/safari-537-branch/Source/WebKit2
Merged r152190. <rdar://problem/14301175>
- 1:34 PM Changeset in webkit [152244] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152177. <rdar://problem/14303613>
- 1:33 PM Changeset in webkit [152243] by
-
- 8 edits in branches/safari-537-branch/Source/WebCore
Merged r152117. <rdar://problem/14278960>
- 1:30 PM Changeset in webkit [152242] by
-
- 4 edits in branches/safari-537-branch
Merged r152091. <rdar://problem/12679475>
- 1:07 PM Changeset in webkit [152241] by
-
- 14 edits1 copy in branches/safari-537-branch/Source
Merged r152065. <rdar://problem/10055712>
- 12:48 PM Changeset in webkit [152240] by
-
- 8 edits in trunk/Source/WebCore
Removed all references to DrawingBuffer methods unused since the removal of Chromium:
DrawingBuffer::prepareBackBuffer,
DrawingBuffer::requiresCopyFromBackToFrontBuffer, and
DrawingBuffer::clearPlatformLayer.
https://bugs.webkit.org/show_bug.cgi?id=118257
Reviewed by Darin Adler.
- platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:
(WebCore::DrawingBuffer::platformLayer):
- platform/graphics/cairo/DrawingBufferCairo.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
- platform/graphics/clutter/DrawingBufferClutter.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
- platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::clear):
- platform/graphics/gpu/DrawingBuffer.h:
- platform/graphics/gpu/mac/DrawingBufferMac.mm:
(WebCore::DrawingBuffer::frontColorBuffer):
- platform/graphics/gpu/qt/DrawingBufferQt.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
- 12:33 PM Changeset in webkit [152239] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed build correction.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Need to export tag for textarea element.
- 12:24 PM Changeset in webkit [152238] by
-
- 30 edits in trunk/Source
Remove support for consumable user gestures
https://bugs.webkit.org/show_bug.cgi?id=118247
Reviewed by Geoffrey Garen.
Source/WebCore:
The features was not enabled on any port, and is meanwhile broken, so we
should delete it.
No new tests, just deleting dead code.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::increment):
(WebCore::AccessibilityNodeObject::decrement):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::press):
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeScript):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeScriptInWorld):
- dom/UserGestureIndicator.cpp:
(WebCore::isDefinite):
(WebCore::UserGestureIndicator::UserGestureIndicator):
(WebCore::UserGestureIndicator::~UserGestureIndicator):
- dom/UserGestureIndicator.h:
(WebCore::UserGestureIndicator::processingUserGesture):
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::openInNewTab):
- inspector/InspectorFrontendHost.cpp:
(WebCore::FrontendMenuProvider::contextMenuItemSelected):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::navigate):
- loader/NavigationScheduler.cpp:
(WebCore::ScheduledURLNavigation::fire):
(WebCore::ScheduledURLNavigation::didStartTimer):
(WebCore::ScheduledRedirect::fire):
(WebCore::ScheduledRefresh::fire):
(WebCore::ScheduledHistoryNavigation::fire):
(WebCore::ScheduledFormSubmission::fire):
(WebCore::ScheduledFormSubmission::didStartTimer):
- page/DOMTimer.cpp:
(WebCore::DOMTimer::DOMTimer):
(WebCore::DOMTimer::fired):
- page/DOMTimer.h:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::showModalDialog):
- page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
- page/EventHandler.h:
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::toggleMediaFullscreenState):
(WebCore::HitTestResult::enterFullscreenForVideo):
Source/WebKit/blackberry:
- WebKitSupport/NotificationManager.cpp:
(BlackBerry::WebKit::NotificationManager::notificationClicked):
Source/WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::evaluate):
- Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView sendEvent:isDrawRect:]):
Source/WebKit/qt:
- WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::notificationClicked):
Source/WebKit/win:
- WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle):
Source/WebKit2:
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::didClickNotification):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::performFrameLoadURLRequest):
(WebKit::PluginView::evaluate):
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::searchWithGoogle):
- 12:14 PM Changeset in webkit [152237] by
-
- 12 edits in branches/safari-537-branch/Source
Merged r151978. <rdar://problem/14102739>
- 11:54 AM Changeset in webkit [152236] by
-
- 1 edit2 adds in trunk/Websites/webkit.org
Add screenshot of the inspector color picker for the blog
- blog-files/last-week-in-webkit: Added.
- blog-files/last-week-in-webkit/Inspector_color_picker.png: Added.
- 11:41 AM Changeset in webkit [152235] by
-
- 14 edits8 adds in trunk
Add Support for mspace element
https://bugs.webkit.org/show_bug.cgi?id=115610
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-07-01
Reviewed by Chris Fleizach.
Source/WebCore:
This patch adds basic support for the MathML mspace element. This is
important to let people control spacing of mathematical formulas.
Attributes width, height and depth are implemented. For the moment,
only nonnegative width are accepted.
- CMakeLists.txt: add references to the RenderMathMLSpace files.
- GNUmakefile.list.am: ditto.
- Target.pri: ditto.
- WebCore.vcxproj/WebCore.vcxproj: ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: ditto.
- WebCore.xcodeproj/project.pbxproj: ditto.
- css/mathml.css:
(mtable[columnlines="dashed"] > mtr > mtd + mtd): remove the obsolete linebreaking rule.
- mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::createRenderer): map mspaceTag to RenderMathMLSpace.
- mathml/mathattrs.in: add width, height and depth attributes
- mathml/mathtags.in: add mspace element
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::parseMathMLLength): fix int to float conversion.
- rendering/mathml/RenderMathMLBlock.h: declare isRenderMathMLSpace.
(WebCore::RenderMathMLBlock::isRenderMathMLSpace):
- rendering/mathml/RenderMathMLSpace.cpp: Added.
(WebCore::RenderMathMLSpace::RenderMathMLSpace):
(WebCore::RenderMathMLSpace::isChildAllowed):
(WebCore::RenderMathMLSpace::computePreferredLogicalWidths):
(WebCore::RenderMathMLSpace::updateFromElement):
(WebCore::RenderMathMLSpace::updateLogicalWidth):
(WebCore::RenderMathMLSpace::updateLogicalHeight):
(WebCore::RenderMathMLSpace::layout):
(WebCore::RenderMathMLSpace::styleDidChange):
(WebCore::RenderMathMLSpace::firstLineBoxBaseline):
- rendering/mathml/RenderMathMLSpace.h: Added.
(WebCore::RenderMathMLSpace::isRenderMathMLSpace):
(WebCore::RenderMathMLSpace::renderName):
(WebCore::toRenderMathMLSpace):
LayoutTests:
Add a reftest for the mspace element (width, height and depth) and
the parsing of MathML lengths. Import a reftest from Gecko to check
positive namedspace values.
- mathml/presentation/mspace-expected.html: Added.
- mathml/presentation/mspace-units-expected.html: Added.
- mathml/presentation/mspace-units.html: Added.
- mathml/presentation/mspace.html: Added.
- mathml/presentation/positive-namedspace-expected.html: Added.
- mathml/presentation/positive-namedspace.html: Added.
- 11:40 AM Changeset in webkit [152234] by
-
- 13 edits in trunk/Source
Audio in apps which embed WebViews is corrupted.
https://bugs.webkit.org/show_bug.cgi?id=118163
Reviewed by Maciej Stachowiak.
Source/WebCore:
Add a preference, which defaults to off, which controls whether the
AudioSessionManager will switch to a large audio buffer setting for
power-savings during <video> playback.
- WebCore.exp.in:
- page/Settings.cpp:
(WebCore::Settings::setLowPowerVideoAudioBufferSizeEnabled): Added. Simple setter.
- page/Settings.h:
(WebCore::Settings::lowPowerVideoAudioBufferSizeEnabled): Added. Simple getter.
- platform/audio/mac/AudioSessionManagerMac.cpp:
(AudioSessionManager::updateSessionState): Only set the large audio buffer
size if lowPowerVideoAudioBufferSize is enabled.
Source/WebKit/mac:
Expose the WebCore lowPowerVideoAudioBufferSizeEnabled setting to WebKit clients.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences lowPowerVideoAudioBufferSizeEnabled]):
(-[WebPreferences setLowPowerVideoAudioBufferSizeEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
Expose the WebCore lowPowerVideoAudioBufferSizeEnabled setting to WebKit2 clients.
- Shared/WebPreferencesStore.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 11:12 AM Changeset in webkit [152233] by
-
- 2 edits in trunk/WebKitLibraries
[Windows] Unreviewed correction to DEBUG_ALL target. Target was undefining DEBUG_ALL and DEBUG_INTERNAL,
which prevented proper build operation.
- win/tools/vsprops/debugsuffix.props: We should DEFINE (not UNDEFINE) the DEBUG_ALL and DEBUG_INTERNAL
macros when building with 'debugsuffix' target.
- 11:04 AM Changeset in webkit [152232] by
-
- 2 edits in trunk/Source/WebCore
[ATK] Leak: leaks in WebKitAccessibleInterfaceText
https://bugs.webkit.org/show_bug.cgi?id=118248
Fixed memory leaks.
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-01
Reviewed by Christophe Dumez.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getPangoLayoutForAtk):
(webkitAccessibleTextGetText):
- 10:53 AM Changeset in webkit [152231] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Make WebCore.make copy over QTMovieWin DLL's and PDB's.
<rdar://problem/14321403>
- WebCore.vcxproj/WebCore.make:
- 10:45 AM Changeset in webkit [152230] by
-
- 2 edits in trunk/Source/WebKit2
WKPageLoadDataWithUserData neglects to set the base URL that is passed in
<rdar://problem/14306784>
https://bugs.webkit.org/show_bug.cgi?id=118256
Reviewed by Anders Carlsson.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadData):
Pass the baseURL, not blankURL(), and remove an unnecessary multiplication by sizeof(uint8_t) which is always 1.
- 9:47 AM Changeset in webkit [152229] by
-
- 2 edits in trunk/Source/WebKit/win
[Curl] WebDownload init method is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=118241
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-01
Reviewed by Brent Fulgham.
The WebDownload::init() method called when a normal load is changed to a download
because of a decision by the policy delegate, is not implemented for Curl.
- WebDownloadCurl.cpp:
(WebDownload::init): Implement init() method.
- 9:38 AM Changeset in webkit [152228] by
-
- 3 edits in trunk/Source/WebCore
[Win] Crash when scrolling page with images.
https://bugs.webkit.org/show_bug.cgi?id=117832
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-01
Reviewed by Brent Fulgham.
Avoid access violation by returning early from method if image frame doesn't have pixel data.
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageFrame::hasPixelData): Added method to check if frame has pixel data.
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::haveDecodedRow): Early return if frame doesn't have pixel data.
- 9:32 AM Changeset in webkit [152227] by
-
- 4 edits in trunk/Source/WebCore
Avoid calling RenderLayerBacking::resetContentsRect() if possible
https://bugs.webkit.org/show_bug.cgi?id=118217
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-07-01
Reviewed by Simon Fraser.
Call resetContentsRect() only if the layer has a contentsLayer.
Otherwise the contentsRect is redundant for the GraphicsLayer.
No new tests - optimization only. This is covered by plenty of existing
tests in webgl/ and compositing/.
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(WebCore::GraphicsLayerTextureMapper::hasContentsLayer):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
Added hasContentsLayer calls for TextureMapper/CoordinatedGraphics
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- 9:25 AM Changeset in webkit [152226] by
-
- 9 edits in trunk/Tools
[EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
https://bugs.webkit.org/show_bug.cgi?id=117249
Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2013-07-01
Reviewed by Brent Fulgham.
Finish converting all use cases of WEBKITOUTPUTDIR to
WEBKIT_OUTPUTDIR, which seems to be preferred these days.
- DumpRenderTree/efl/FontManagement.cpp:
(getCustomBuildDir):
(getPlatformFontsPath):
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(getOutputDir):
- Scripts/webkitdirs.pm:
(determineBaseProductDir):
(usesPerConfigurationBuildDirectory):
- Scripts/webkitpy/port/base.py:
(Port.to.setup_environ_for_server):
- Scripts/webkitpy/port/driver.py:
(Driver._setup_environ_for_driver):
- Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server):
- WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::getOutputDir):
- jhbuild/jhbuildutils.py:
(get_dependencies_path):
- 8:39 AM Changeset in webkit [152225] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix cast-align warnings in JavaScriptCore/heap/HandleBlockInlines.h
https://bugs.webkit.org/show_bug.cgi?id=118242
Reviewed by Mark Hahnenberg.
- heap/HandleBlockInlines.h:
(JSC::HandleBlock::nodes):
- 8:29 AM Changeset in webkit [152224] by
-
- 2 edits in trunk/Tools
Unreviewed change of my email address.
- Scripts/webkitpy/common/config/contributors.json:
- 7:36 AM Changeset in webkit [152223] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Un-break the WebCore ChangeLog after http://trac.webkit.org/changeset/152219.
- 7:29 AM Changeset in webkit [152222] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Avoid creating a QWindow for offscreen GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=118244
Reviewed by Noam Rosenthal.
In Qt 5.0 we had to create invisible windows, but in Qt 5.1
we can now create specific offscreen surfaces.
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
- 6:31 AM Changeset in webkit [152221] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipping unsupported tests.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-01
- platform/qt/TestExpectations:
- 6:29 AM Changeset in webkit [152220] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Remove long unused Qt4 forward definitions
Unreviewed cleanu-up.
- platform/graphics/GraphicsContext3D.h:
- 6:27 AM Changeset in webkit [152219] by
-
- 5 edits in trunk/Source/WebCore
Use DeferrableOneShotTimer for deleting decoded data
https://bugs.webkit.org/show_bug.cgi?id=118150
Reviewed by Andreas Kling.
Adam Barth pointed out that the virtual function for overriding the default delay doesn't work
as expected from base class constructor.
- loader/cache/CachedResource.cpp:
(WebCore::deadDecodedDataDeletionIntervalForResourceType):
(WebCore::CachedResource::CachedResource):
Use static function instead of calling a virtual.
- loader/cache/CachedResource.h:
- loader/cache/CachedScript.cpp:
- loader/cache/CachedScript.h:
- 3:43 AM Changeset in webkit [152218] by
-
- 26 edits in trunk/Source
Adopt toHTMLTextAreaElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118226
Reviewed by Andreas Kling.
To enhance readability, this patch adopts toHTMLTextAreaElement.
This also helps out to reduce duplicated use of static_cast.
Source/WebCore:
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::isNativeTextControl):
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::text):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendText):
- html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):
- html/HTMLTextAreaElement.h:
(WebCore::toHTMLTextAreaElement):
- page/FocusController.cpp:
(WebCore::clearSelectionIfNeeded):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::isContentEditable):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesLogicalWidthToFitContent):
- rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::~RenderTextControlMultiLine):
(WebCore::RenderTextControlMultiLine::preferredContentLogicalWidth):
(WebCore::RenderTextControlMultiLine::computeControlLogicalHeight):
- testing/Internals.cpp:
(WebCore::Internals::wasLastChangeUserEdit):
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isTextInputElement):
(BlackBerry::WebKit::DOMSupport::inputElementText):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::elementType):
(BlackBerry::WebKit::InputHandler::boundingBoxForInputField):
Source/WebKit/mac:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::textDidChangeInTextArea):
Source/WebKit/win:
- DOMCoreClasses.cpp:
(DOMElement::createInstance):
- DOMHTMLClasses.cpp:
(DOMHTMLTextAreaElement::form):
(DOMHTMLTextAreaElement::value):
(DOMHTMLTextAreaElement::setValue):
(DOMHTMLTextAreaElement::select):
(DOMHTMLTextAreaElement::isUserEdited):
Source/WebKit2:
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):
- WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::createAnnotationElement):
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::textDidChangeInTextArea):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::containsAnyFormControls):
- 1:44 AM Changeset in webkit [152217] by
-
- 3 edits in trunk/Source/WebCore
Add missing string headers that are used when LOG_DISABLED is 0.
https://bugs.webkit.org/show_bug.cgi?id=118227
Patch by Kwang Yul Seo <skyul@company100.net> on 2013-07-01
Reviewed by Andreas Kling.
Build fix for LOG_DISABLED=0.
No new tests, no behavior change.
- html/track/InbandTextTrack.cpp:
- rendering/RenderLayerCompositor.cpp:
- 1:44 AM Changeset in webkit [152216] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Use PassOwnPtr for the returned value of createBackingStore
https://bugs.webkit.org/show_bug.cgi?id=118230
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-07-01
Reviewed by Andreas Kling.
It would be better that createBackingStore returns PassOwnPtr instread of OwnPtr
to keep compatibility with c++0x.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::createBackingStore):
- 1:10 AM Applications using WebKit edited by
- Wakanda server updates (diff)
- 12:11 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
Jun 30, 2013:
- 10:30 AM Changeset in webkit [152215] by
-
- 5 edits3 adds in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining whatever can be rebaselined and adding failure expectations for other current failures.
- platform/gtk-wk1/TestExpectations:
- platform/gtk/TestExpectations:
- platform/gtk/editing/selection/user-select-all-image-with-single-click-expected.txt: Added.
- platform/gtk/editing/selection/user-select-all-with-single-click-expected.txt: Added.
- platform/gtk/fast/events/ondragenter-expected.txt: Added.
- platform/gtk/fast/js/global-constructors-attributes-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
Jun 29, 2013:
- 1:27 PM Changeset in webkit [152214] by
-
- 5 edits in trunk/Source/WebCore
Avoid calling into Objective-C every time we get the scrollbar width
https://bugs.webkit.org/show_bug.cgi?id=118216
Reviewed by Geoffrey Garen.
Profiling shows that calling Scrollbar::isOverlayScrollbar() is somewhat
expensive, because it calls down into Objective-C. Fix by caching in
ScrollbarThemeMac whether we're using overlay scrollbars. We update this
cache on creation, and when preferences change; ScrollAnimatorMac::updateScrollerStyle()
is the function that gets called when the user changes the setting in System Preferences.
- platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::usesOverlayScrollbarsChanged):
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
- platform/mac/ScrollbarThemeMac.h:
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::preferencesChanged):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbarsChanged):
- 1:22 PM Changeset in webkit [152213] by
-
- 3 edits in trunk/Source/WebCore
Avoid calling isSimpleContainerCompositingLayer() an extra time
https://bugs.webkit.org/show_bug.cgi?id=118218
Reviewed by Tim Horton.
containsPaintedContent() called isSimpleContainerCompositingLayer(), which
is not particularly cheap. But the caller already has this information,
so pass it in.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDrawsContent):
(WebCore::RenderLayerBacking::containsPaintedContent):
- rendering/RenderLayerBacking.h:
- 1:19 PM Changeset in webkit [152212] by
-
- 2 edits in trunk/Source/WebCore
Avoid doing work in RenderBox::outlineBoundsForRepaint() when the repaintContainer is this
https://bugs.webkit.org/show_bug.cgi?id=118215
Reviewed by Tim Horton.
When the RenderGeometryMap code path was added, RenderBox::outlineBoundsForRepaint()
actually got slower if no coordinate mapping was needed. So avoid doing work when
we can, including avoiding the FloatQuad construction.
Speeds up scrolling overflow:scroll areas with large numbers of layer children.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::outlineBoundsForRepaint):
- 8:49 AM Changeset in webkit [152211] by
-
- 14 edits in trunk/Source
Adopt is/toHTMLOptGroupElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118213
Reviewed by Andreas Kling.
To enhance readability, this patch adopts is/toHTMLOptGroupElement.
This also helps out to reduce duplicated use of static_cast.
Source/WebCore:
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::isEnabled):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):
- html/HTMLOptGroupElement.h:
(WebCore::isHTMLOptGroupElement):
(WebCore::toHTMLOptGroupElement):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
(WebCore::HTMLOptionElement::isDisabledFormControl):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore::HTMLSelectElement::recalcListItems):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::hasImpliedEndTag):
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isSelectScopeMarker):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemText):
(WebCore::RenderMenuList::itemIsEnabled):
(WebCore::RenderMenuList::itemIsLabel):
Source/WebKit/blackberry:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openSelectPopup):
- 8:15 AM Changeset in webkit [152210] by
-
- 2 edits in trunk/Source/WebCore
Build fix for unguarded SVGGraphicsElement
https://bugs.webkit.org/show_bug.cgi?id=118214
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-06-29
Reviewed by Christophe Dumez.
Add the SVG condition to SVGGraphicsElement.idl
No new tests required since no functionality changed.
- svg/SVGGraphicsElement.idl:
- 7:59 AM Changeset in webkit [152209] by
-
- 2 edits in trunk/Source/JavaScriptCore
Follow-up to r152206: also update HashFlags8BitBuffer in the LLInt.
- llint/LowLevelInterpreter.asm:
- 1:18 AM Changeset in webkit [152208] by
-
- 24 edits in trunk/Source
Adopt is/toHTMLOptionElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118212
Reviewed by Andreas Kling.
To enhance readability, this patch adopts is/toHTMLOptionElement.
This also helps out to reduce duplicated use of static_cast.
Source/WebCore:
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::isSelected):
(WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):
- accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::setElement):
(WebCore::AccessibilityMenuListOption::isEnabled):
(WebCore::AccessibilityMenuListOption::isSelected):
(WebCore::AccessibilityMenuListOption::setSelected):
(WebCore::AccessibilityMenuListOption::stringValue):
- accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):
- html/HTMLCollection.cpp:
(WebCore::isMatchingElement):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::index):
- html/HTMLOptionElement.h:
(WebCore::isHTMLOptionElement):
(WebCore::toHTMLOptionElement):
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::hasPlaceholderLabelOption):
(WebCore::HTMLSelectElement::value):
(WebCore::HTMLSelectElement::setValue):
(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore::HTMLSelectElement::nextValidIndex):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::selectOption):
(WebCore::HTMLSelectElement::optionToListIndex):
(WebCore::HTMLSelectElement::listToOptionIndex):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState):
(WebCore::HTMLSelectElement::searchOptionsForValue):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::lastSelectedListIndex):
(WebCore::HTMLSelectElement::optionAtIndex):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
(WebCore::HTMLSelectElement::length):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::hasImpliedEndTag):
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isSelectScopeMarker):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth):
(WebCore::RenderMenuList::setTextFromOption):
(WebCore::RenderMenuList::itemText):
(WebCore::RenderMenuList::itemIsEnabled):
(WebCore::RenderMenuList::itemIsSelected):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paintSliderTicks):
Source/WebKit/blackberry:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
(BlackBerry::WebKit::InputHandler::didNodeOpenPopup):
(BlackBerry::WebKit::InputHandler::openSelectPopup):
(BlackBerry::WebKit::InputHandler::setPopupListIndexes):
- WebKitSupport/SelectPopupClient.cpp:
(BlackBerry::WebKit::SelectPopupClient::setValueAndClosePopup):
Source/WebKit/win:
- DOMCoreClasses.cpp:
(DOMElement::createInstance):
- DOMHTMLClasses.cpp:
(DOMHTMLOptionElement::text):
(DOMHTMLOptionElement::label):
- 12:25 AM Changeset in webkit [152207] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(151586): multipart/x-mixed-replace images are broken
https://bugs.webkit.org/show_bug.cgi?id=118169
Reviewed by Alexey Proskuryakov.
When loading multipart content the resource data will change as
the next part is loaded, so we need to make a copy of the data
before sending it to the resource.
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse):
Jun 28, 2013:
- 11:02 PM Changeset in webkit [152206] by
-
- 2 edits in trunk/Source/JavaScriptCore
Un-crashify JSC tests on debug bots after Anders had his way with StringImpl.
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- 10:53 PM Changeset in webkit [152205] by
-
- 4 edits in trunk
Fix Windows builds after deprecatedCharactersWithNullTermination() removal.
Source/WebKit2:
- Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::createServerAndClientIdentifiers):
Tools:
- DumpRenderTree/win/DumpRenderTree.cpp:
(addFontFallbackIfPresent):
(removeFontFallbackIfPresent):
- 7:55 PM Changeset in webkit [152204] by
-
- 3 edits in trunk/Source/WebCore
[Mac] adopt new AVFoundation caption API
https://bugs.webkit.org/show_bug.cgi?id=118207
Reviewed by Dean Jackson.
No new tests, I was not able to come up with a reliable layout test.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::flushCues): New, call currentTrack->resetCueValues().
(-[WebCoreAVFMovieObserver outputSequenceWasFlushed:]): New delegate method.
- 7:41 PM Changeset in webkit [152203] by
-
- 22 edits in trunk/Source
Adopt is/toHTMLImageElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118182
Reviewed by Andreas Kling.
To enhance readability, this patch adopts is/toHTMLImageElement.
This also helps out to reduce duplicated use of static_cast.
Source/WebCore:
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isNativeImage):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::url):
- bindings/js/JSNodeCustom.cpp:
(WebCore::isReachableFromDOM):
- bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::assignToHTMLImageElement):
(JSC::Bindings::QtPixmapRuntime::toQt):
- dom/Clipboard.cpp:
(WebCore::Clipboard::setDragImage):
- dom/Node.cpp:
(WebCore::Node::enclosingLinkEventParentOrSelf):
- editing/Editor.cpp:
(WebCore::imageElementFromImageDocument):
- html/HTMLAnchorElement.cpp:
(WebCore::appendServerMapMousePosition):
- html/HTMLImageElement.h:
(WebCore::isHTMLImageElement):
(WebCore::toHTMLImageElement):
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
- html/HTMLNameCollection.cpp:
(WebCore::WindowNameCollection::nodeMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatchesIfIdAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatches):
- page/DragController.cpp:
(WebCore::DragController::draggableElement):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
- platform/gtk/PasteboardGtk.cpp:
(WebCore::getURLForImageNode):
- platform/mac/HTMLConverter.mm:
(+[WebHTMLConverter editingAttributedStringFromRange:]):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::imageMap):
(WebCore::RenderImage::updateAltText):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::shouldRespectImageOrientation):
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
(BlackBerry::WebKit::WebPage::blockZoom):
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):
- 6:45 PM Changeset in webkit [152202] by
-
- 2 edits in trunk/Source/WebCore
PageThrottler::shouldThrottleTimers is wrong.
https://bugs.webkit.org/show_bug.cgi?id=118210
Reviewed by Anders Carlson.
m_throttleState == PageNotThrottledState
-> page NOT throttled, so should NOT throttle timers
m_throttleState != PageNotThrottledState
-> page NOT NOT throttled, so should throttle timers
This needs cleaning up, but for now, 1 character fix.
- page/PageThrottler.h:
(WebCore::PageThrottler::shouldThrottleTimers):
-> !=
- 6:39 PM Changeset in webkit [152201] by
-
- 11 edits in trunk
Remove String::deprecatedCharactersWithNullTermination() and related code
https://bugs.webkit.org/show_bug.cgi?id=118211
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
- API/JSStringRef.cpp:
(JSStringCreateWithCharactersNoCopy):
Update call to StringImpl::createWithoutCopying.
Source/WTF:
Remove String::deprecatedCharactersWithNullTermination, StringImpl::createWithTerminatingNullCharacter
and the s_hashFlagHasTerminatingNullCharacter flag. We no longer care about whether strings have a
terminating null character.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::createFromLiteral):
(WTF::StringImpl::createWithoutCopying):
(WTF::StringImpl::getData16SlowCase):
(WTF::StringImpl::sizeInBytes):
- wtf/text/StringImpl.h:
(WTF::StringImpl::StringImpl):
(WTF::StringImpl::createFromLiteral):
(WTF::StringImpl::isolatedCopy):
- wtf/text/WTFString.cpp:
- wtf/text/WTFString.h:
Tools:
Remove all hasTerminatingNullCharacter() checks.
- TestWebKitAPI/Tests/WTF/AtomicString.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/WTFString.cpp:
(TestWebKitAPI::TEST):
- 6:39 PM Changeset in webkit [152200] by
-
- 2 edits in trunk/Source/WebInspectorUI
Update Apple System fonts in auto-complete
https://bugs.webkit.org/show_bug.cgi?id=118205
<rdar://problem/14308488>
Reviewed by Joseph Pecoraro.
Update for the new Apple System font names, and remove some invalid entries.
- UserInterface/CSSKeywordCompletions.js: General cleanup. Note that
"apple-system-short-caption2" looks like it was accidentally omitted. It wasn't :)
- 6:25 PM Changeset in webkit [152199] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: AX: VoiceOver speaks all inspector search fields as 'required'
https://bugs.webkit.org/show_bug.cgi?id=118122
Patch by James Craig <james@cookiecrook.com> on 2013-06-28
Reviewed by Timothy Hatcher.
Removed bogus "required" state, and switched :valid selector to use :not(:placeholder-shown)
so that screen readers will not indicate a bogus :required/:invalid state to the user.
Minor cosmetic difference blocked by http://webkit.org/b/118162
- UserInterface/FilterBar.css:
(.filter-bar > input[type="search"]:focus):
(.filter-bar > input[type="search"]:not(:placeholder-shown)):
- UserInterface/FilterBar.js:
(WebInspector.FilterBar):
- UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel):
- UserInterface/SearchBar.css:
(.search-bar > input[type="search"]:focus):
(.search-bar > input[type="search"]:not(:placeholder-shown)):
- UserInterface/SearchBar.js:
(WebInspector.SearchBar):
- 5:09 PM Changeset in webkit [152198] by
-
- 4 edits4 adds in trunk
An element with -webkit-user-select: all should be selected on single click
https://bugs.webkit.org/show_bug.cgi?id=117864
Reviewed by Darin Adler.
Source/WebCore:
Set m_mouseDownMayStartSelect true even when the node cannot start selection
if the node was inside an element with -webkit-user-select: all.
Test: editing/selection/user-select-all-with-single-click.html
- page/EventHandler.cpp:
(WebCore::canMouseDownStartSelect):
LayoutTests:
Add tests for single clicking on an element with user-select: all.
We select the entire element regardless of whether the user had clicked on text or an image
to be consistent even though Firefox requires a double click on the latter case.
- editing/selection/user-select-all-with-image-single-click-expected.txt: Added.
- editing/selection/user-select-all-with-image-single-click.html: Added.
- editing/selection/user-select-all-with-single-click-expected.txt: Added.
- editing/selection/user-select-all-with-single-click.html: Added.
- 5:01 PM Changeset in webkit [152197] by
-
- 3 edits in trunk/Source/WebCore
Remove unused attachChildrenLazily method and make attach/detachChildren private
https://bugs.webkit.org/show_bug.cgi?id=118016
Reviewed by Darin Adler.
Merge https://chromium.googlesource.com/chromium/blink/+/009520dc31c9458e0cf71cf212fa5688c4ca68b0
No one should be manually trying to attach or detach all their children so there's
no reason for these methods to be public.
In doing this I realized that attachChildrenLazily is not used and can be removed.
I also realized that we were detaching all our children before the ShadowRoots which
is sad since the InsertionPoints will call detach() on them as well, and then when we
call ContainerNode::detach at the end of Element::detach we'll go detach them again!
This patch makes it so we only go through and detach them twice instead of three times.
In the future we should figure out a way to only do this once.
- dom/ContainerNode.h:
- dom/Element.cpp:
(WebCore::Element::detach):
- 4:57 PM Changeset in webkit [152196] by
-
- 4 edits2 adds in trunk
[Mac] Crash when loading is stopped from -didReceiveResponse
https://bugs.webkit.org/show_bug.cgi?id=118209
<rdar://problem/14259249>
Reviewed by Brady Eidson.
Test: TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm.
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse): Added yet another check for reachedTerminalState().
- 4:40 PM Changeset in webkit [152195] by
-
- 2 edits in trunk/Tools
[Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=118208
Reviewed by Mark Rowe.
Newer versions of clang use a default template depth of 128, but this
is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
previous default.
Clang lowered the default to keep recursive template instantiation
from overflowing the stack (see <rdar://problem/13935016>), but
TestWebKitAPI's C++ files don't trigger a stack overflow even with the
higher limit. If for some reason this starts happening then we can
lower the limit back down.
- TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
- 4:11 PM Changeset in webkit [152194] by
-
- 6 edits in trunk/Source/WebCore
Cached pages don't update their backing scale factor when it changes
https://bugs.webkit.org/show_bug.cgi?id=118206
-and-
<rdar://problem/14261627>
Reviewed by Tim Horton.
It is not sufficient to mark pages in the PageCache as needing a full style
recalc. We also need to ensure that the RenderLayerCompositors for the CachesPages
get updated.
Keep track of whether device scale has been updated with
m_needsDeviceScaleChanged. If that has been marked true, then restore() will call
Frame::deviceOrPageScaleFactorChanged().
- history/CachedPage.cpp:
(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):
- history/CachedPage.h:
(WebCore::CachedPage::markForDeviceScaleChanged):
Propagate markForDeviceScaleChanged() to all of the CachedPages.
- history/PageCache.cpp:
(WebCore::PageCache::markPagesForDeviceScaleChanged):
- history/PageCache.h:
Call PageCache::markPagesForDeviceScaleChanged()
- page/Page.cpp:
(WebCore::Page::setDeviceScaleFactor):
- 3:48 PM Changeset in webkit [152193] by
-
- 2 edits in trunk/Source/WebCore
Added template parameters to std::min to fix compile errors in Visual Studio x64.
https://bugs.webkit.org/show_bug.cgi?id=118204
Reviewed by Geoffrey Garen.
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeURLToDataObject): Added <unsigned> to std::min.
(WebCore::createGlobalImageFileDescriptor): Added <int> to std::min.
- 3:43 PM Changeset in webkit [152192] by
-
- 5 edits in trunk/Source/WebCore
Added WebGL files to Windows build.
https://bugs.webkit.org/show_bug.cgi?id=118200
Reviewed by Brent Fulgham.
- WebCore.vcxproj/WebCore.vcxproj: Added WebGL files, removed unused GraphicsContext3DOpenGLES.cpp.
- WebCore.vcxproj/WebCore.vcxproj.filters: Added WebGL files, removed unused GraphicsContext3DOpenGLES.cpp.
- platform/graphics/cairo/GLContext.cpp: Only include GLContextEGL.h or GLContextGLX.h if they're needed.
- platform/graphics/cg/GraphicsContext3DCG.cpp: Only include GraphicsContext3DNEON.h if it's needed.
- 3:21 PM Changeset in webkit [152191] by
-
- 2 edits in trunk/Tools
[Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
https://bugs.webkit.org/show_bug.cgi?id=118195
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-06-28
Reviewed by Daniel Bates.
Currently, ports that use jhbuild fail to determine jhbuild directory
when "webKitBranchBuild" git configuration property is enabled. To reproduce
that issue in Efl port, enable that flag in .git/config, switch to a git branch
other than "master" and try to build webkit. The build will fail to
locate dependencies due to lack of pkg-config paths which should be set
by jhbuild.
For more details about "webKitBranchBuild" option, see:
https://trac.webkit.org/wiki/UsingGitWithWebKit
- Scripts/webkitdirs.pm:
(getJhbuildPath):
- 3:15 PM Changeset in webkit [152190] by
-
- 11 edits in trunk/Source/WebKit2
[wk2] WKView shouldn't force scrolling off if shouldClipToVisibleRect is set
https://bugs.webkit.org/show_bug.cgi?id=118174
<rdar://problem/14301175>
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView _updateViewExposedRect]):
Pass whether or not clips-to-visibleRect is enabled down to the WebPageProxy.
(-[WKView setMinimumSizeForAutoLayout:]):
Disable scrolling when using autolayout instead of when using clips-to-visibleRect.
(-[WKView setShouldClipToVisibleRect:]):
Clipping to the WKView's visibleRect does not strictly require scrolling to be disabled,
and in fact there are cases (RTL/TB pagination) where we *must* scroll, even when the view
is big enough to fit the content (the case clip-to-visibleRect was added for).
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
- UIProcess/WebPageProxy.h:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::viewExposedRectChanged):
(WebKit::WebPageProxy::exposedRectChangedTimerFired):
Keep track of and forward to the drawing area whether or not clips-to-visibleRect is enabled.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setClipsToExposedRect): Added.
(WebKit::DrawingArea::didChangeScrollOffsetForAnyFrame): Added a missing space.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::viewExposedRectChanged):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Forward clips-to-visibleRect enabled state to the drawing area.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
Add storage for m_clipsToExposedRect.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setClipsToExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::updateMainFrameClipsToExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer):
Check m_clipsToExposedRect instead of the main-frame's isScrollable() to determine
whether we should tell our TiledBackings to clip to the exposed rect we provide.
We don't need to listen to mainFrameScrollabilityChanged anymore.
- 2:48 PM Changeset in webkit [152189] by
-
- 2 edits in branches/safari-537-branch/Tools
Merged r152188. <rdar://problem/14306452>
- 2:45 PM Changeset in webkit [152188] by
-
- 2 edits in trunk/Tools
WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
https://bugs.webkit.org/show_bug.cgi?id=118201
Reviewed by Dean Jackson.
- WebKitTestRunner/mac/main.mm:
(main):
Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
setAutomaticDashSubstitutionEnabled are not exposed on WKView.
- 1:40 PM Changeset in webkit [152187] by
-
- 2 edits in trunk/Source/WebKit2
Stale occlusion state after moving page back into window
https://bugs.webkit.org/show_bug.cgi?id=118202
Reviewed by Anders Carlsson.
We need to update the occlusion state when the page goes back into the window.
- UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
- update occlusion state.
- 1:38 PM Changeset in webkit [152186] by
-
- 9 edits in trunk/Tools
Upstream WebKit Nightly’s WebKitLauncher
https://bugs.webkit.org/show_bug.cgi?id=117418
Reviewed by Mark Rowe.
Literal patch from Nightly's OpenSource repo.
- WebKitLauncher/Configurations/Base.xcconfig:
- WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
- WebKitLauncher/Info.plist:
- WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
- WebKitLauncher/WebKitLauncherURLProtocol.m:
(+[WebKitLauncherURLProtocol load]):
(+[WebKitLauncherURLProtocol canInitWithRequest:]):
(-[WebKitLauncherURLProtocol startLoading]):
(-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
(-[WebKitLauncherURLProtocol resourceNotFound]):
- WebKitLauncher/WebKitNightlyEnablerSparkle.m:
(initializeSparkle):
- WebKitLauncher/main.m:
(determineExecutablePath):
(currentMacOSXVersion):
(main):
- WebKitLauncher/start.html:
- 12:59 PM Changeset in webkit [152185] by
-
- 3 edits2 adds in trunk
-webkit-line-break: after-white-space sometimes truncates DOM on copy & paste
https://bugs.webkit.org/show_bug.cgi?id=118164
Reviewed by Sam Weinig.
Source/WebCore:
We can't assume that all subsequent ancestors contain exactly one child since they could have been
added in the first if statement matching: currentNode->parentNode() != rootNode && isRemovableBlock(currentNode)
Exit early when we encounter such an ancestor since removing its ancestor (that contains multiple children
some of which aren't in nodesToRemove) can clobber more nodes than we're allowed to remove.
Test: editing/pasteboard/simplfiying-markup-should-not-strip-content.html
- editing/SimplifyMarkupCommand.cpp:
(WebCore::SimplifyMarkupCommand::doApply):
(WebCore::SimplifyMarkupCommand::pruneSubsequentAncestorsToRemove):
LayoutTests:
Add a regression test.
- editing/pasteboard/simplfiying-markup-should-not-strip-content-expected.txt: Added.
- editing/pasteboard/simplfiying-markup-should-not-strip-content.html: Added.
- 12:55 PM Changeset in webkit [152184] by
-
- 3 edits in trunk/LayoutTests
media/video-currentTime.html flakey
https://bugs.webkit.org/show_bug.cgi?id=118198
Reviewed by Jessie Berlin.
Update video-currentTime.html so that it listens for timeupdate events, and ends the test
after the first one with a >0 currentTime. Add a 3s watchdog for the failure case.
- media/video-currentTime-expected.txt:
- media/video-currentTime.html:
- 12:09 PM Changeset in webkit [152183] by
-
- 7 edits2 adds in trunk/Source
Coordinated Graphics: Separate CoordinatedLayerTreeHost into CoordinatedLayerTreeHost and CompositingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=104360
Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2013-06-28
Reviewed by Noam Rosenthal.
The CoordinatedLayerTreeHost has too many responsibilities. It
implements LayerTreeHost, GraphicsLayerClient,
CoordinatedGraphicsLayerClient, CoordinatedImageBacking::Client,
UpdateAtlas::Client, GraphicsLayerFactory and
WebCustomFilterProgramProxyClient.
This refactoring reduces the responsibilities of CoordinatedLayerTreeHost.
This patch introduces a new class called CompositingCoordinator, which
takes the responsibility of managing compositing resources in
WebProcess.
CoordinatedLayerTreeHost is responsible only for the scheduling and
IPC-specific stuff, which are relevant only for WebKit2.
No new tests, covered by existing tests.
Source/WebCore:
- CMakeLists.txt:
- Target.pri:
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp: Added.
(WebCore::CompositingCoordinator::create):
(WebCore::CompositingCoordinator::~CompositingCoordinator):
(WebCore::CompositingCoordinator::CompositingCoordinator):
(WebCore::CompositingCoordinator::setRootCompositingLayer):
(WebCore::CompositingCoordinator::sizeDidChange):
(WebCore::CompositingCoordinator::flushPendingLayerChanges):
(WebCore::CompositingCoordinator::syncDisplayState):
(WebCore::CompositingCoordinator::nextAnimationServiceTime):
(WebCore::CompositingCoordinator::clearPendingStateChanges):
(WebCore::CompositingCoordinator::initializeRootCompositingLayerIfNeeded):
(WebCore::CompositingCoordinator::createRootLayer):
(WebCore::CompositingCoordinator::syncLayerState):
(WebCore::CompositingCoordinator::createImageBackingIfNeeded):
(WebCore::CompositingCoordinator::createImageBacking):
(WebCore::CompositingCoordinator::updateImageBacking):
(WebCore::CompositingCoordinator::clearImageBackingContents):
(WebCore::CompositingCoordinator::removeImageBacking):
(WebCore::CompositingCoordinator::flushPendingImageBackingChanges):
(WebCore::CompositingCoordinator::notifyAnimationStarted):
(WebCore::CompositingCoordinator::notifyFlushRequired):
(WebCore::CompositingCoordinator::paintContents):
(WebCore::CompositingCoordinator::createGraphicsLayer):
(WebCore::CompositingCoordinator::deviceScaleFactor):
(WebCore::CompositingCoordinator::pageScaleFactor):
(WebCore::CompositingCoordinator::createUpdateAtlas):
(WebCore::CompositingCoordinator::removeUpdateAtlas):
(WebCore::CompositingCoordinator::visibleContentsRect):
(WebCore::CompositingCoordinator::mainContentsLayer):
(WebCore::CompositingCoordinator::setVisibleContentsRect):
(WebCore::CompositingCoordinator::deviceOrPageScaleFactorChanged):
(WebCore::CompositingCoordinator::detachLayer):
(WebCore::CompositingCoordinator::commitScrollOffset):
(WebCore::CompositingCoordinator::renderNextFrame):
(WebCore::CompositingCoordinator::purgeBackingStores):
(WebCore::CompositingCoordinator::paintToSurface):
(WebCore::CompositingCoordinator::scheduleReleaseInactiveAtlases):
(WebCore::CompositingCoordinator::releaseInactiveAtlasesTimerFired):
- platform/graphics/texmap/coordinated/CompositingCoordinator.h: Added.
(WebCore::CompositingCoordinator::clearRootLayer):
(WebCore::CompositingCoordinator::rootLayer):
(WebCore::CompositingCoordinator::state):
Source/WebKit2:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::~CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::setRootCompositingLayer):
(WebKit::CoordinatedLayerTreeHost::invalidate):
(WebKit::CoordinatedLayerTreeHost::forceRepaint):
(WebKit::CoordinatedLayerTreeHost::sizeDidChange):
(WebKit::CoordinatedLayerTreeHost::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHost::renderNextFrame):
(WebKit::CoordinatedLayerTreeHost::purgeBackingStores):
(WebKit::CoordinatedLayerTreeHost::willSyncLayerState):
(WebKit::CoordinatedLayerTreeHost::prepareCustomFilterProxiesForAnimations):
(WebKit::CoordinatedLayerTreeHost::checkCustomFilterProgramProxies):
(WebKit::CoordinatedLayerTreeHost::removeCustomFilterProgramProxy):
(WebKit::CoordinatedLayerTreeHost::didFlushRootLayer):
(WebKit::CoordinatedLayerTreeHost::performScheduledLayerFlush):
(WebKit::CoordinatedLayerTreeHost::createPageOverlayLayer):
(WebKit::CoordinatedLayerTreeHost::paintLayerContents):
(WebKit::CoordinatedLayerTreeHost::commitSceneState):
(WebKit::CoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
(WebKit::CoordinatedLayerTreeHost::graphicsLayerFactory):
(WebKit::CoordinatedLayerTreeHost::scheduleAnimation):
(WebKit::CoordinatedLayerTreeHost::commitScrollOffset):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- WebProcess/WebPage/LayerTreeHost.h:
- 11:57 AM Changeset in webkit [152182] by
-
- 6 edits in trunk/Source/WebKit2
Make the UI process run the Java Updater
https://bugs.webkit.org/show_bug.cgi?id=118197
<rdar://problem/14255677>
Reviewed by Sam Weinig.
Patch the relevant NSWorkspace method and pipe through the request to launch the Java updater to the UI process.
- PluginProcess/PluginProcess.h:
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::replacedNSWorkspace_launchApplicationAtURL_options_configuration_error):
(WebKit::initializeCocoaOverrides):
(WebKit::PluginProcess::launchApplicationAtURL):
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/Plugins/PluginProcessProxy.messages.in:
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::isJavaUpdaterURL):
(WebKit::shouldLaunchApplicationAtURL):
(WebKit::PluginProcessProxy::launchApplicationAtURL):
- 11:47 AM Changeset in webkit [152181] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r152135.
http://trac.webkit.org/changeset/152135
https://bugs.webkit.org/show_bug.cgi?id=118199
Rolling out temporary patch used for debugging the test bots
(Requested by rfong on #webkit).
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::load):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::load):
- 11:08 AM Changeset in webkit [152180] by
-
- 4 edits in trunk/LayoutTests
Update TestExpectations so new Shapes tests are skipped where the old ones were
https://bugs.webkit.org/show_bug.cgi?id=118192
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-28
Reviewed by Brent Fulgham.
Shapes still aren't enabled on some ports, so skip the tests there.
As part of this patch, it was discovered that they work on EFL, so the
skipping has been removed from there.
- platform/efl/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 11:07 AM Changeset in webkit [152179] by
-
- 3 edits in trunk/Tools
[EFL] back/forward keyboard shortcuts are non-intuitive
https://bugs.webkit.org/show_bug.cgi?id=118193
Patch by Balazs Kelemen <b.kelemen@samsung.com> on 2013-06-28
Reviewed by Christophe Dumez.
Changed shortcuts for go-back/go-forward to alt+left and alt+right.
- EWebLauncher/main.c:
(on_key_down):
- MiniBrowser/efl/main.c:
(on_key_down):
- 11:00 AM Changeset in webkit [152178] by
-
- 3 edits2 adds in trunk
SVG relayout problem when displayed with different image box heights
https://bugs.webkit.org/show_bug.cgi?id=118140
Patch by Morten Stenshorne <mstensho@opera.com> on 2013-06-28
Reviewed by Philip Rogers.
Source/WebCore:
If the root element is an SVG, its position and height are affected
by the view height.
Test: svg/as-image/same-source-different-height.html
- rendering/RenderView.cpp:
(WebCore::RenderView::layout):
LayoutTests:
- svg/as-image/same-source-different-height-expected.html: Added.
- svg/as-image/same-source-different-height.html: Added.
- 10:54 AM Changeset in webkit [152177] by
-
- 2 edits in trunk/Source/WebKit2
WARN_UNUSED_RESULT can't be used in API headers, but WKBundlePageExtendIncrementalRenderingSuppression tries to
https://bugs.webkit.org/show_bug.cgi?id=118196
<rdar://problem/14303613>
Reviewed by Anders Carlsson.
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
- 10:54 AM Changeset in webkit [152176] by
-
- 3 edits in trunk/Tools
Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
https://bugs.webkit.org/show_bug.cgi?id=118194.
Reviewed by Brent Fulgham.
- DumpRenderTree/win/DumpRenderTree.cpp:
(dllLauncherEntryPoint):
- WinLauncher/WinLauncher.cpp:
(dllLauncherEntryPoint):
- 10:31 AM Changeset in webkit [152175] by
-
- 12 edits3 deletes in trunk/Source/WebCore
Allow some LayoutPoint and LayoutSize conversions to be inlined
https://bugs.webkit.org/show_bug.cgi?id=118167
Reviewed by Ryosuke Niwa.
Construction of FloatSize from LayoutSize, and FloatPoint's move(const LayoutSize&)
and moveBy(const LayoutPoint&) were not inlined, and showed up on some profiles.
Make them inlined by removing the overloaded functions, and instead providing
conversion operators from LayoutSize to FloatSize, and LayoutPoint to FloatPoint.
Do the same to allow a LayoutRect to be converted to a FloatRect.
This is nice because it removes pollution of FloatRect, FloatPoint and FloatSize with
Layout* entirely.
Remove Qt-specific conversions on LayoutRect, LayoutPoint and LayoutSize. Qt can
convert via IntRect/FloatRect as necessary.
- platform/graphics/FloatPoint.cpp:
- platform/graphics/FloatPoint.h:
(WebCore::FloatPoint::move):
(WebCore::FloatPoint::moveBy):
- platform/graphics/FloatRect.cpp:
- platform/graphics/FloatRect.h:
- platform/graphics/FloatSize.cpp:
- platform/graphics/FloatSize.h:
- platform/graphics/LayoutPoint.h:
(WebCore::LayoutPoint::operator FloatPoint):
- platform/graphics/LayoutRect.cpp:
- platform/graphics/LayoutRect.h:
(WebCore::LayoutRect::operator FloatRect):
- platform/graphics/LayoutSize.h:
(WebCore::LayoutSize::operator FloatSize):
- 10:13 AM Changeset in webkit [152174] by
-
- 3 edits in trunk/Tools
Unreviewed build fix for AppleWin port. Fix some file paths.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
- 9:50 AM Changeset in webkit [152173] by
-
- 5 edits in branches/safari-537-branch/LayoutTests
Merged r151942. <rdar://problem/14299780>
- 9:39 AM Changeset in webkit [152172] by
-
- 2 edits in trunk/LayoutTests
accessibility/media-element.html does not support platforms without subroles
https://bugs.webkit.org/show_bug.cgi?id=118187
Reviewed by Chris Fleizach.
Update the test to be more friendly with platforms not supporting subroles.
- accessibility/media-element.html: Updated test.
- 9:23 AM Changeset in webkit [152171] by
-
- 4 edits2 adds in trunk/Tools
Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
https://bugs.webkit.org/show_bug.cgi?id=118160.
Reviewed by Brent Fulgham.
- WinLauncher/AccessibilityDelegate.cpp: Added.
(AccessibilityDelegate::QueryInterface):
(AccessibilityDelegate::AddRef):
(AccessibilityDelegate::Release):
(AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
(AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.
- WinLauncher/AccessibilityDelegate.h: Added.
(AccessibilityDelegate::AccessibilityDelegate):
- WinLauncher/WinLauncher.cpp:
(dllLauncherEntryPoint):
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
- 9:11 AM WebKitIDL edited by
- Remove ExtendsDOMGlobalObject and IsWorkerContext after r152168 (diff)
- 9:08 AM Changeset in webkit [152170] by
-
- 2 edits in trunk/Tools
Clean up temporary files created by the bindings test script
https://bugs.webkit.org/show_bug.cgi?id=118189
Reviewed by Kentaro Hara.
Remove temporary files created by preprocess-idls.pl script after
the bindings tests are executed.
Based on Blink 153236 by Kentaro Hara <haraken@chromium.org>.
- Scripts/webkitpy/bindings/main.py:
(BindingsTests.main):
- 9:07 AM Changeset in webkit [152169] by
-
- 3 edits in trunk/Source/WebKit/win
[WinCairo] Compilation error.
https://bugs.webkit.org/show_bug.cgi?id=118131
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-06-28
Reviewed by Brent Fulgham.
- Interfaces/IWebView.idl: Include needed accessibility interface.
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::AXFinishFrameLoad): Accessibility methods should not be inside FULLSCREEN_API ifdef.
- 9:01 AM Changeset in webkit [152168] by
-
- 7 edits in trunk/Source/WebCore
Get rid of IsWorkerGlobalScope and ExtendsDOMGlobalObject extended attributes
https://bugs.webkit.org/show_bug.cgi?id=118191
Reviewed by Kentaro Hara.
Remove WebKit-specific [IsWorkerGlobalScope] and [ExtendsDOMGlobalObject] IDL
extended attributes and update the JSC bindings generator to figure this out
on its own.
No new tests, no behavior change.
- bindings/scripts/CodeGeneratorJS.pm:
(IsDOMGlobalObject):
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorHelperMethods):
- bindings/scripts/IDLAttributes.txt:
- page/DOMWindow.idl:
- workers/DedicatedWorkerGlobalScope.idl:
- workers/SharedWorkerGlobalScope.idl:
- workers/WorkerGlobalScope.idl:
- 8:58 AM Changeset in webkit [152167] by
-
- 80 edits1 copy2 moves in trunk
Introduce SVGGraphicsElement IDL interface
https://bugs.webkit.org/show_bug.cgi?id=118178
Reviewed by Kentaro Hara.
Source/WebCore:
Introduce SVGGraphicsElement IDL interface as per the latest SVG
specification:
SVGGraphicsElement is a merge of SVGLocatable and SVGTransformable.
This is one step towards simplifying inheritance in SVG and matching
the latest SVG2 specification.
No new tests, already covered by existing tests.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.order:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGeneratorJS.pm:
(GetGnuVTableOffsetForType):
- rendering/svg/RenderSVGEllipse.cpp:
(WebCore::RenderSVGEllipse::RenderSVGEllipse):
- rendering/svg/RenderSVGEllipse.h:
- rendering/svg/RenderSVGPath.cpp:
(WebCore::RenderSVGPath::RenderSVGPath):
- rendering/svg/RenderSVGPath.h:
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::pathOnlyClipping):
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
- rendering/svg/RenderSVGResourceMarker.cpp:
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::RenderSVGShape):
(WebCore::RenderSVGShape::updateShapeFromElement):
(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::nonScalingStrokeTransform):
(WebCore::RenderSVGShape::shouldGenerateMarkerPositions):
- rendering/svg/RenderSVGShape.h:
- rendering/svg/RenderSVGTransformableContainer.cpp:
(WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer):
(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
- rendering/svg/RenderSVGTransformableContainer.h:
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::SVGAElement):
(WebCore::SVGAElement::parseAttribute):
(WebCore::SVGAElement::svgAttributeChanged):
(WebCore::SVGAElement::defaultEventHandler):
(WebCore::SVGAElement::supportsFocus):
(WebCore::SVGAElement::isURLAttribute):
- svg/SVGAElement.h:
- svg/SVGAElement.idl:
- svg/SVGAllInOne.cpp:
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::hasValidAttributeType):
- svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::SVGCircleElement):
(WebCore::SVGCircleElement::parseAttribute):
(WebCore::SVGCircleElement::svgAttributeChanged):
- svg/SVGCircleElement.h:
- svg/SVGCircleElement.idl:
- svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::SVGClipPathElement):
(WebCore::SVGClipPathElement::parseAttribute):
(WebCore::SVGClipPathElement::svgAttributeChanged):
(WebCore::SVGClipPathElement::childrenChanged):
- svg/SVGClipPathElement.h:
- svg/SVGClipPathElement.idl:
- svg/SVGDefsElement.cpp:
(WebCore::SVGDefsElement::SVGDefsElement):
- svg/SVGDefsElement.h:
- svg/SVGDefsElement.idl:
- svg/SVGElement.h:
(WebCore::SVGElement::isSVGGraphicsElement):
- svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::SVGEllipseElement):
(WebCore::SVGEllipseElement::parseAttribute):
(WebCore::SVGEllipseElement::svgAttributeChanged):
- svg/SVGEllipseElement.h:
- svg/SVGEllipseElement.idl:
- svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
(WebCore::SVGForeignObjectElement::parseAttribute):
(WebCore::SVGForeignObjectElement::svgAttributeChanged):
(WebCore::SVGForeignObjectElement::rendererIsNeeded):
- svg/SVGForeignObjectElement.h:
- svg/SVGForeignObjectElement.idl:
- svg/SVGGElement.cpp:
(WebCore::SVGGElement::SVGGElement):
(WebCore::SVGGElement::parseAttribute):
(WebCore::SVGGElement::svgAttributeChanged):
- svg/SVGGElement.h:
- svg/SVGGElement.idl:
- svg/SVGGraphicsElement.cpp: Renamed from Source/WebCore/svg/SVGStyledTransformableElement.cpp.
(WebCore::SVGGraphicsElement::SVGGraphicsElement):
(WebCore::SVGGraphicsElement::~SVGGraphicsElement):
(WebCore::SVGGraphicsElement::getCTM):
(WebCore::SVGGraphicsElement::getScreenCTM):
(WebCore::SVGGraphicsElement::animatedLocalTransform):
(WebCore::SVGGraphicsElement::supplementalTransform):
(WebCore::SVGGraphicsElement::isSupportedAttribute):
(WebCore::SVGGraphicsElement::parseAttribute):
(WebCore::SVGGraphicsElement::svgAttributeChanged):
(WebCore::SVGGraphicsElement::nearestViewportElement):
(WebCore::SVGGraphicsElement::farthestViewportElement):
(WebCore::SVGGraphicsElement::getBBox):
(WebCore::SVGGraphicsElement::createRenderer):
(WebCore::SVGGraphicsElement::toClipPath):
- svg/SVGGraphicsElement.h: Renamed from Source/WebCore/svg/SVGStyledTransformableElement.h.
(WebCore::SVGGraphicsElement::localCoordinateSpaceTransform):
(WebCore::SVGGraphicsElement::synchronizeRequiredFeatures):
(WebCore::SVGGraphicsElement::synchronizeRequiredExtensions):
(WebCore::SVGGraphicsElement::synchronizeSystemLanguage):
(WebCore::toSVGGraphicsElement):
- svg/SVGGraphicsElement.idl: Copied from Source/WebCore/svg/SVGForeignObjectElement.idl.
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::SVGImageElement):
(WebCore::SVGImageElement::isPresentationAttribute):
(WebCore::SVGImageElement::collectStyleForPresentationAttribute):
(WebCore::SVGImageElement::parseAttribute):
(WebCore::SVGImageElement::svgAttributeChanged):
(WebCore::SVGImageElement::attach):
(WebCore::SVGImageElement::insertedInto):
(WebCore::SVGImageElement::addSubresourceAttributeURLs):
(WebCore::SVGImageElement::didMoveToNewDocument):
- svg/SVGImageElement.h:
- svg/SVGImageElement.idl:
- svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::SVGLineElement):
(WebCore::SVGLineElement::parseAttribute):
(WebCore::SVGLineElement::svgAttributeChanged):
- svg/SVGLineElement.h:
- svg/SVGLineElement.idl:
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::SVGPathElement):
(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::insertedInto):
(WebCore::SVGPathElement::removedFrom):
- svg/SVGPathElement.h:
- svg/SVGPathElement.idl:
- svg/SVGPatternElement.cpp:
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::SVGPolyElement):
(WebCore::SVGPolyElement::parseAttribute):
(WebCore::SVGPolyElement::svgAttributeChanged):
- svg/SVGPolyElement.h:
- svg/SVGPolygonElement.idl:
- svg/SVGPolylineElement.idl:
- svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::SVGRectElement):
(WebCore::SVGRectElement::parseAttribute):
(WebCore::SVGRectElement::svgAttributeChanged):
- svg/SVGRectElement.h:
- svg/SVGRectElement.idl:
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::didMoveToNewDocument):
(WebCore::SVGSVGElement::parseAttribute):
(WebCore::SVGSVGElement::insertedInto):
(WebCore::SVGSVGElement::removedFrom):
- svg/SVGSVGElement.h:
- svg/SVGSVGElement.idl:
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::localCoordinateSpaceTransform):
- svg/SVGSwitchElement.cpp:
(WebCore::SVGSwitchElement::SVGSwitchElement):
- svg/SVGSwitchElement.h:
- svg/SVGSwitchElement.idl:
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::parseAttribute):
(WebCore::SVGUseElement::insertedInto):
(WebCore::SVGUseElement::removedFrom):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::toClipPath):
(WebCore::SVGUseElement::finishParsingChildren):
- svg/SVGUseElement.h:
- svg/SVGUseElement.idl:
LayoutTests:
Rebaseline js/global-constructors-attributes.html test case now that
SVGGraphicsElement is exposed on the global Window object.
- fast/js/global-constructors-attributes-expected.txt:
- platform/efl/fast/js/global-constructors-attributes-expected.txt:
- platform/gtk/fast/js/global-constructors-attributes-expected.txt:
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
- platform/qt/fast/js/global-constructors-attributes-expected.txt:
- 8:00 AM Changeset in webkit [152166] by
-
- 2 edits in trunk/Source/WebKit2
Don't fire process-became-responsive callback when disconnecting it.
<http://webkit.org/b/118166>
Reviewed by Anders Carlsson.
When disconnecting from a web process, call ResponsivenessTimer::invalidate() instead of
stop() to avoid firing the didBecomeResponsive() callback.
This lets the UI process react faster to actually unresponsive processes.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::disconnect):
- 7:52 AM WebKitIDL edited by
- Update documentation for [GlobalContext] after r152100 (diff)
- 7:49 AM Changeset in webkit [152165] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][GTK] 100% CPU usage rendering a page with animations
https://bugs.webkit.org/show_bug.cgi?id=117703
Reviewed by Martin Robinson.
Unconditionally update the value of m_lastFlushTime in
::flushAndRenderLayers. By doing that we avoid a neverending
sequence of layer flushes that happened when m_lastFlushTime==0
and flushPendingLayerChanges() was false. In that situation the
value m_lastFlushTime was never updated so a new flush was always
rescheduled.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::flushAndRenderLayers):
- 7:29 AM Changeset in webkit [152164] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipping failing tests, and mathml tests because not yet supported.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-28
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt/TestExpectations:
- 6:31 AM Changeset in webkit [152163] by
-
- 2 edits in trunk
[Autotools] Properly quote harfbuzz-icu pkg-config check
https://bugs.webkit.org/show_bug.cgi?id=118186
Patch by Sean Bright <sean@malleable.com> on 2013-06-28
Reviewed by Carlos Garcia Campos.
A secondary test was added in r150963 to check for harfbuzz-icu
when it was split into two packages, but the test is not properly
quoted. If the test fails you get an error about missing
version "./configure.9.8" instead of the expected "0.9.8."
- Source/autotools/FindDependencies.m4:
- 5:28 AM Changeset in webkit [152162] by
-
- 9 edits in trunk
Add new schemes to content utils.
https://bugs.webkit.org/show_bug.cgi?id=118181
Reviewed by Christophe Dumez.
Source/WebCore:
According to latest content handler spec, new schemes are added to it.
Those are "geo, magnet, sip, ssh and xmpp".
http://www.w3.org/html/wg/drafts/html/master/webappapis.html#custom-handlers
Tests: fast/dom/register-protocol-handler.html
fast/dom/unregister-protocol-handler.html
- Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::initProtocolHandlerWhitelist):
LayoutTests:
Add new schemes as well as change SYNTAX_ERR, SECURITY_ERR.
- fast/dom/register-protocol-handler-expected.txt:
- fast/dom/register-protocol-handler.html:
- fast/dom/unregister-protocol-handler-expected.txt:
- fast/dom/unregister-protocol-handler.html:
- platform/efl/fast/dom/register-protocol-handler-expected.txt:
- platform/efl/fast/dom/unregister-protocol-handler-expected.txt:
- 4:14 AM Changeset in webkit [152161] by
-
- 2 edits in trunk/Source/WebCore
Avoid duplicating hostWindow() call in ScrollView.cpp
https://bugs.webkit.org/show_bug.cgi?id=118168
Patch by Sanghyup Lee <sh53.lee@samsung.com> on 2013-06-28
Reviewed by Christophe Dumez.
Remove redundant hostWindow() calls in ScrollView.cpp.
- platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::contentsToScreen):
(WebCore::ScrollView::screenToContents):
(WebCore::ScrollView::repaintContentRectangle):
(WebCore::ScrollView::updateOverhangAreas):
(WebCore::ScrollView::addPanScrollIcon):
(WebCore::ScrollView::removePanScrollIcon):
- 4:00 AM Changeset in webkit [152160] by
-
- 3 edits in trunk/LayoutTests
[GTK] Unreviewed gardening. Unskip and reorganize tests no longer failing in GTK-WK and GTK-WK2
https://bugs.webkit.org/show_bug.cgi?id=118180
Unreviewed GTK gardening.
Patch by Simon Pena <simon.pena@samsung.com> on 2013-06-28
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- 3:59 AM Changeset in webkit [152159] by
-
- 2 edits in trunk/Source/WebKit/gtk
Use gtk_widget_get_preferred_size instead of deprecated gtk_widget_get_requisition
https://bugs.webkit.org/show_bug.cgi?id=118177
Patch by Iago Toral Quiroga <itoral@igalia.com> on 2013-06-28
Reviewed by Carlos Garcia Campos.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::contentsSizeChanged):
- 3:18 AM Changeset in webkit [152158] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, EFL rebaseline.
SECURITY_ERR and SYNTAX_ERR have been changed with SecurityError and SyntaxError since r135162.
- platform/efl/fast/dom/register-protocol-handler-expected.txt:
- platform/efl/fast/dom/unregister-protocol-handler-expected.txt:
- 2:33 AM Changeset in webkit [152157] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix GTK build after r152156.
- GNUmakefile.list.am:
- 1:34 AM Changeset in webkit [152156] by
-
- 57 edits1 delete in trunk/Source/WebCore
Merge SVGLangSpace into SVGElement
https://bugs.webkit.org/show_bug.cgi?id=118170
Reviewed by Kentaro Hara.
Remove SVGLangSpace IDL interface and move its attributes to SVGElement
to match the latest specification and simplify inheritance in SVG:
No new tests, no behavior change.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- svg/SVGAElement.h:
- svg/SVGAElement.idl:
- svg/SVGCircleElement.h:
- svg/SVGCircleElement.idl:
- svg/SVGClipPathElement.h:
- svg/SVGClipPathElement.idl:
- svg/SVGDefsElement.h:
- svg/SVGDefsElement.idl:
- svg/SVGDescElement.h:
- svg/SVGDescElement.idl:
- svg/SVGElement.cpp:
(WebCore::SVGElement::parseAttribute):
- svg/SVGElement.h:
- svg/SVGElement.idl:
- svg/SVGEllipseElement.h:
- svg/SVGEllipseElement.idl:
- svg/SVGFEImageElement.h:
- svg/SVGFEImageElement.idl:
- svg/SVGFilterElement.h:
- svg/SVGFilterElement.idl:
- svg/SVGForeignObjectElement.h:
- svg/SVGForeignObjectElement.idl:
- svg/SVGGElement.h:
- svg/SVGGElement.idl:
- svg/SVGImageElement.h:
- svg/SVGImageElement.idl:
- svg/SVGLangSpace.idl: Removed.
- svg/SVGLineElement.h:
- svg/SVGLineElement.idl:
- svg/SVGMarkerElement.h:
- svg/SVGMarkerElement.idl:
- svg/SVGMaskElement.h:
- svg/SVGMaskElement.idl:
- svg/SVGPathElement.h:
- svg/SVGPathElement.idl:
- svg/SVGPatternElement.h:
- svg/SVGPatternElement.idl:
- svg/SVGPolyElement.h:
- svg/SVGPolygonElement.idl:
- svg/SVGPolylineElement.idl:
- svg/SVGRectElement.h:
- svg/SVGRectElement.idl:
- svg/SVGSVGElement.h:
- svg/SVGSVGElement.idl:
- svg/SVGStyleElement.h:
- svg/SVGStyleElement.idl:
- svg/SVGSwitchElement.h:
- svg/SVGSwitchElement.idl:
- svg/SVGSymbolElement.h:
- svg/SVGSymbolElement.idl:
- svg/SVGTextContentElement.h:
- svg/SVGTextContentElement.idl:
- svg/SVGTitleElement.h:
- svg/SVGTitleElement.idl:
- svg/SVGUseElement.h:
- svg/SVGUseElement.idl:
- 1:28 AM Changeset in webkit [152155] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] MiniBrowser doesn't solve the saving location when there are no XDG settings
https://bugs.webkit.org/show_bug.cgi?id=117538
Patch by Andres Gomez <Andres Gomez> on 2013-06-28
Reviewed by Carlos Garcia Campos.
If the XDG specification is not working for the "Downloads"
directory, let's use HOME as fallback.
- UIProcess/API/gtk/WebKitDownload.cpp:
(webkitDownloadDecideDestination):
- 1:20 AM Changeset in webkit [152154] by
-
- 4 edits in trunk/Source/WebCore
Use & instead of | in the value of [CallWith]
https://bugs.webkit.org/show_bug.cgi?id=118054
Reviewed by Kentaro Hara.
[CallWith=ScriptExecutionContext|ScriptState] meant that both the
ScriptExecutionContext AND the ScriptState would be passed as
arguments to the implementation (not one OR the other).
This patch changes the semantics for those IDL extended attributes
to make it less confusing. Proper usage is now:
[CallWith=ScriptExecutionContext&ScriptState]
No new tests, covered by existing bindings tests.
- bindings/scripts/CodeGenerator.pm:
(ExtendedAttributeContains):
- bindings/scripts/test/TestObj.idl:
- page/Console.idl:
- 12:34 AM Changeset in webkit [152153] by
-
- 2 edits1 add in trunk/Source/WebKit2
[EFL][WK2] Add spellcheck API tests in unit tests.
https://bugs.webkit.org/show_bug.cgi?id=118123
Patch by Dariusz Frankiewicz <Dariusz Frankiewicz> on 2013-06-28
Reviewed by Christophe Dumez.
According to discussion in bug https://bugs.webkit.org/show_bug.cgi?id=113742
we're moving spelling tests from layout tests to unit tests.
- UIProcess/API/efl/tests/resources/spelling_selection_tests.html: Added.
New file is needed to make tests, with and without spellcheck attribute.
File contains basic site with content editable fields and buttons which select
different parts of misspelled words.
- UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
(countContextMenuItems):
Added method used to count number of items in context menu.
Jun 27, 2013:
- 10:47 PM Changeset in webkit [152152] by
-
- 2 edits in branches/safari-537-branch/LayoutTests
Merge a file from r151836 that was lost in the r152027 merge.
- fast/css/text-overflow-ellipsis-behind-floats-expected.html:
- 8:31 PM Changeset in webkit [152151] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
Make Graph::substituteGetLocal() out-of-line
Rubber stamped by Geoffrey Garen.
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::substituteGetLocal):
(DFG):
- dfg/DFGGraph.h:
(Graph):
- 7:28 PM Changeset in webkit [152150] by
-
- 3 edits in trunk/Source/WebCore
HTMLAudioElement doesn't have to know about isVideo function
https://bugs.webkit.org/show_bug.cgi?id=118116
Reviewed by Eric Carlson.
Minor code cleanup to remove isVideo function from HTMLAudioElement.
We can use default function in HTMLMediaElement as hasVideo does.
- html/HTMLAudioElement.h:
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::isVideo):
- 7:26 PM Changeset in webkit [152149] by
-
- 58 edits in trunk/Source
Adopt is/toHTMLInputElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118130
Reviewed by Antti Koivisto.
To enhance readability, this patch adopts is/toHTMLInputElement.
This also helps out to reduce duplicated use of static_cast.
Source/WebCore:
- accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaTimeline::valueDescription):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::isNativeTextControl):
(WebCore::AccessibilityNodeObject::isNativeImage):
(WebCore::AccessibilityNodeObject::isInputImage):
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::valueForRange):
(WebCore::AccessibilityNodeObject::maxValueForRange):
(WebCore::AccessibilityNodeObject::minValueForRange):
(WebCore::AccessibilityNodeObject::actionElement):
(WebCore::AccessibilityNodeObject::titleElementText):
(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::title):
(WebCore::AccessibilityNodeObject::text):
(WebCore::AccessibilityNodeObject::colorValue):
(WebCore::accessibleNameForNode):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isFileUploadButton):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::url):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::element):
- accessibility/ios/AccessibilityObjectIOS.mm:
(WebCore::AccessibilityObject::accessibilityPasswordFieldLength):
- bindings/js/JSHTMLInputElementCustom.cpp:
(WebCore::JSHTMLInputElement::selectionStart):
(WebCore::JSHTMLInputElement::setSelectionStart):
(WebCore::JSHTMLInputElement::selectionEnd):
(WebCore::JSHTMLInputElement::setSelectionEnd):
(WebCore::JSHTMLInputElement::selectionDirection):
(WebCore::JSHTMLInputElement::setSelectionDirection):
(WebCore::JSHTMLInputElement::setSelectionRange):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::isInPasswordField):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace):
- html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::getTextFieldValues):
- html/HTMLInputElement.h:
(WebCore::isHTMLInputElement):
(WebCore::toHTMLInputElement):
- html/RadioInputType.cpp:
(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::isKeyboardFocusable):
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::mediaControlElementType):
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
(WebCore::InputFieldSpeechButtonElement::startSpeechInput):
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
- page/Chrome.cpp:
(WebCore::Chrome::setToolTip):
- page/EventHandler.cpp:
(WebCore::isSubmitImage):
(WebCore::EventHandler::handleMousePressEvent):
- page/FocusController.cpp:
(WebCore::clearSelectionIfNeeded):
- platform/gtk/PasteboardGtk.cpp:
(WebCore::getURLForImageNode):
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
- platform/qt/RenderThemeQtMobile.cpp:
(WebCore::RenderThemeQtMobile::paintSliderTrack):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::isContentEditable):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::hasLineIfEmpty):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesLogicalWidthToFitContent):
- rendering/RenderButton.cpp:
(WebCore::RenderButton::updateFromElement):
(WebCore::RenderButton::canHaveGeneratedChildren):
- rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::isOpen):
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::updateFromElement):
(WebCore::RenderFileUploadControl::maxFilenameWidth):
(WebCore::RenderFileUploadControl::paintObject):
(WebCore::RenderFileUploadControl::uploadButton):
(WebCore::RenderFileUploadControl::fileTextValue):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::updateAltText):
- testing/Internals.cpp:
(WebCore::Internals::selectColorInColorChooser):
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
- WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::findPasswordFormFields):
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isPasswordElement):
(BlackBerry::WebKit::DOMSupport::inputElementText):
(BlackBerry::WebKit::DOMSupport::isDateTimeInputField):
(BlackBerry::WebKit::DOMSupport::isColorInputField):
(BlackBerry::WebKit::DOMSupport::elementIdOrNameIndicatesNoAutocomplete):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::elementType):
(BlackBerry::WebKit::InputHandler::setInputValue):
(BlackBerry::WebKit::InputHandler::extractedTextRequest):
(BlackBerry::WebKit::InputHandler::showTextInputTypeSuggestionBox):
Source/WebKit/efl:
- ewk/ewk_view.cpp:
(ewk_view_input_method_state_set):
Source/WebKit/mac:
- DOM/WebDOMOperations.mm:
(-[DOMHTMLInputElement _setAutofilled:]):
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::focusedNodeChanged):
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::textFieldDidBeginEditing):
(WebEditorClient::textFieldDidEndEditing):
(WebEditorClient::textDidChangeInTextField):
(WebEditorClient::doTextFieldCommandFromEvent):
(WebEditorClient::textWillBeDeletedInTextField):
- WebView/WebHTMLRepresentation.mm:
(inputElementFromDOMElement):
Source/WebKit/qt:
- WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::setInputMethodState):
- WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::inputMethodQuery):
Source/WebKit/win:
- DOMCoreClasses.cpp:
(DOMElement::createInstance):
- DOMHTMLClasses.cpp:
(DOMHTMLInputElement::form):
(DOMHTMLInputElement::disabled):
(DOMHTMLInputElement::readOnly):
(DOMHTMLInputElement::setType):
(DOMHTMLInputElement::value):
(DOMHTMLInputElement::setValue):
(DOMHTMLInputElement::setValueForUser):
(DOMHTMLInputElement::select):
(DOMHTMLInputElement::setSelectionStart):
(DOMHTMLInputElement::selectionStart):
(DOMHTMLInputElement::setSelectionEnd):
(DOMHTMLInputElement::selectionEnd):
(DOMHTMLInputElement::isTextField):
(DOMHTMLInputElement::rectOnScreen):
(DOMHTMLInputElement::replaceCharactersInRange):
(DOMHTMLInputElement::selectedRange):
(DOMHTMLInputElement::setAutofilled):
(DOMHTMLInputElement::isAutofilled):
(DOMHTMLInputElement::isUserEdited):
- WebFrame.cpp:
(inputElementFromDOMElement):
Source/WebKit2:
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementValueForUser):
(WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::htmlInputElementLastChangeWasUserEdit):
- WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::createAnnotationElement):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::focusedNodeChanged):
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::textFieldDidBeginEditing):
(WebKit::WebEditorClient::textFieldDidEndEditing):
(WebKit::WebEditorClient::textDidChangeInTextField):
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
(WebKit::WebEditorClient::textWillBeDeletedInTextField):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::containsAnyFormControls):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):
- 7:00 PM Changeset in webkit [152148] by
-
- 6 edits in trunk/Source/WebCore
Use DeferrableOneShotTimer for deleting decoded data
https://bugs.webkit.org/show_bug.cgi?id=118150
Reviewed by Andreas Kling.
Up to 1% of page load time can be used under CachedScript::script() for restarting
the decoded data deletion timer.
Using DeferrableOneShotTimer instead of a plain Timer avoids unnecessary low level timer access.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::destroyDecodedDataIfNeeded):
(WebCore::CachedResource::decodedDataDeletionTimerFired):
(WebCore::CachedResource::decodedDataDeletionTimerDelay):
Adopt DeferrableOneShotTimer.
- loader/cache/CachedResource.h:
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::script):
(WebCore::CachedScript::decodedDataDeletionTimerDelay):
Keep using zero delay for scripts.
- platform/Timer.h:
(WebCore::DeferrableOneShotTimer::stop):
Avoid unnecessary restart after stopping and starting again.
- 6:53 PM Changeset in webkit [152147] by
-
- 14 edits5 copies1 add in trunk/Source/WebKit2
[EFL][WK2] Add WK2 C API to handle touch events.
https://bugs.webkit.org/show_bug.cgi?id=108915
Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-06-27
Reviewed by Gyuyoung Kim.
Touch events for our target platforms differ (XInput2, Wayland, Tizen) so
for the EFL port we want to be able to feed events manually.
To keep our current API for desktop EFL/Enlightenment working, we convert
our currently limited EFL events to the new EFL specific C EwkTouchPoint
and EwkTouchEvent type.
EwkTouchPoint and EwkTouchEvent are exposed as WKTouchPointRef and
WKTouchEventRef, so they are opaque in the applications.
The WKViewSendTouchEvent can be used for any use-case (platform/product)
not involving the EFL events.
At the same time we make sure to avoid using WK2 internals in our EFL API
implementation.
- PlatformEfl.cmake:
- Shared/API/c/efl/WKBaseEfl.h:
- Shared/APIObject.h:
- Shared/NativeWebTouchEvent.h:
(WebKit::NativeWebTouchEvent::nativeEvent):
- Shared/efl/NativeWebTouchEventEfl.cpp:
(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):
- Shared/efl/WebEventFactory.cpp:
(WebKit::toWebPlatformTouchPointState):
(WebKit::toWebEventType):
(WebKit::toWebEventModifiers):
(WebKit::WebEventFactory::createWebTouchEvent):
- Shared/efl/WebEventFactory.h:
- UIProcess/API/C/efl/WKAPICastEfl.h:
- UIProcess/API/C/efl/WKEventEfl.cpp: Added.
(WKTouchPointCreate):
(WKTouchEventCreate):
- UIProcess/API/C/efl/WKEventEfl.h: Added.
- UIProcess/API/C/efl/WKViewEfl.cpp:
(WKViewSendTouchEvent):
- UIProcess/API/C/efl/WKViewEfl.h:
- UIProcess/API/efl/EwkView.cpp:
(toWKTouchPointState):
(toWKEventModifiers):
(EwkView::feedTouchEvent):
(EwkView::feedTouchEvents):
- UIProcess/efl/EwkTouchEvent.cpp: Added.
(WebKit::EwkTouchEvent::EwkTouchEvent):
- UIProcess/efl/EwkTouchEvent.h: Added.
(WebKit::EwkTouchEvent::create):
(WebKit::EwkTouchEvent::eventType):
(WebKit::EwkTouchEvent::touchPoints):
(WebKit::EwkTouchEvent::modifiers):
(WebKit::EwkTouchEvent::timestamp):
(WebKit::EwkTouchEvent::type):
- UIProcess/efl/EwkTouchPoint.cpp: Added.
(WebKit::EwkTouchPoint::EwkTouchPoint):
- UIProcess/efl/EwkTouchPoint.h: Added.
(WebKit::EwkTouchPoint::create):
(WebKit::EwkTouchPoint::id):
(WebKit::EwkTouchPoint::state):
(WebKit::EwkTouchPoint::screenPosition):
(WebKit::EwkTouchPoint::position):
(WebKit::EwkTouchPoint::radius):
(WebKit::EwkTouchPoint::rotationAngle):
(WebKit::EwkTouchPoint::forceFactor):
(WebKit::EwkTouchPoint::type):
- UIProcess/efl/WebViewEfl.cpp:
(WebKit::WebViewEfl::sendTouchEvent):
- UIProcess/efl/WebViewEfl.h:
- 6:17 PM Changeset in webkit [152146] by
-
- 3 edits in branches/safari-537-branch/Tools
Merged r152144. <rdar://problem/13529880>
- 6:16 PM Changeset in webkit [152145] by
-
- 3 edits in branches/safari-537-branch/Tools
Merged r151954. <rdar://problem/14250356>
- 6:02 PM Changeset in webkit [152144] by
-
- 3 edits in trunk/Tools
[Mac] Add Mavericks system font to Test systems
https://bugs.webkit.org/show_bug.cgi?id=118109
Reviewed by Simon Fraser.
OS X Mavericks uses a different font for system controls. Tell DRT and
WKTR about them otherwise they use a fallback font. Unfortunately the
fonts are hidden (not found in the list of available fonts) so I
had to add them manually.
Even though there is only one at the moment, I implemented this
as a set so it will be easier to add new fonts if necessary.
- DumpRenderTree/mac/DumpRenderTree.mm:
(allowedFontFamilySet): Fixed typo.
(systemHiddenFontFamilySet): New method that returns the system control font.
(drt_NSFontManager_availableFonts): Merge the hidden fonts.
- WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
(WTR::allowedFontFamilySet): Fixed typo.
(WTR::systemHiddenFontFamilySet): As above.
(WTR::wtr_NSFontManager_availableFonts):
- 5:33 PM Changeset in webkit [152143] by
-
- 10 edits in trunk
Get rid of the last uses of deprecatedCharactersWithNullTermination()
https://bugs.webkit.org/show_bug.cgi?id=118159
Reviewed by Andreas Kling.
Replace calls to deprecatedCharactersWithNullTermination() with charactersWithNullTermination().data().
Source/WebKit/win:
- COMPropertyBag.h:
(::GetPropertyInfo):
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::runOpenPanel):
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::updateWindowTitle):
- WebDownloadCFNet.cpp:
(WebDownload::didFinish):
- WebKitSystemBits.cpp:
(WebVolumeFreeSize):
- WebLocalizableStrings.cpp:
(LocalizedString::operator LPCTSTR):
- WebView.cpp:
(WebView::setToolTip):
Tools:
- DumpRenderTree/win/DumpRenderTree.cpp:
(findFontFallback):
- 5:19 PM Changeset in webkit [152142] by
-
- 29 edits in trunk/Source
Add a new String::charactersWithNullTermination() function that returns a vector
https://bugs.webkit.org/show_bug.cgi?id=118155
Reviewed by Andreas Kling.
Source/WebCore:
Change calls to deprecatedCharactersWithNullTermination() to charactersWithNullTermination().data()
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::getLinkedFonts):
- platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/win/IconWin.cpp:
(WebCore::Icon::createIconForFiles):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpCookiesForQuickTime):
- platform/graphics/wince/FontPlatformData.cpp:
(WebCore::FontPlatformData::FontPlatformData):
- platform/network/curl/CurlDownload.cpp:
(CurlDownload::moveFileToDestination):
- platform/network/win/CookieJarWin.cpp:
(WebCore::setCookiesFromDOM):
(WebCore::cookiesForDOM):
- platform/network/win/DownloadBundleWin.cpp:
(WebCore::DownloadBundle::appendResumeData):
(WebCore::DownloadBundle::extractResumeData):
- platform/network/win/ResourceHandleWin.cpp:
(WebCore::createInternetHandle):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::fileLoadTimer):
- platform/text/win/LocaleWin.cpp:
(WebCore::LCIDFromLocaleInternal):
- platform/text/win/TextCodecWin.cpp:
(WebCore::TextCodecWin::enumerateSupportedEncodings):
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::getWebLocData):
(WebCore::createGlobalData):
(WebCore::setFileDescriptorData):
(WebCore::getURL):
(WebCore::setCFData):
- platform/win/ContextMenuWin.cpp:
(WebCore::ContextMenu::createPlatformContextMenuFromItems):
- platform/win/DragImageWin.cpp:
(WebCore::createDragImageIconForCachedImageFilename):
- platform/win/FileSystemWin.cpp:
(WebCore::getFindData):
(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::pathByAppendingComponent):
(WebCore::makeAllDirectories):
(WebCore::pathGetFileName):
(WebCore::openTemporaryFile):
(WebCore::openFile):
- platform/win/MIMETypeRegistryWin.cpp:
(WebCore::mimeTypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
- platform/win/PasteboardWin.cpp:
(WebCore::createGlobalImageFileDescriptor):
(WebCore::createGlobalHDropContent):
- platform/win/PathWalker.cpp:
(WebCore::PathWalker::PathWalker):
- platform/win/SSLKeyGeneratorWin.cpp:
(WebCore::WebCore::signedPublicKeyAndChallengeString):
- platform/win/SharedBufferWin.cpp:
(WebCore::SharedBuffer::createWithContentsOfFile):
- platform/wince/FileSystemWinCE.cpp:
(WebCore::getFileInfo):
(WebCore::fileExists):
(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::makeAllDirectories):
(WebCore::openTemporaryFile):
(WebCore::openFile):
- plugins/win/PluginDatabaseWin.cpp:
(WebCore::PluginDatabase::getPluginPathsInDirectories):
(WebCore::addMozillaPluginDirectories):
(WebCore::addAdobeAcrobatPluginDirectory):
(WebCore::addJavaPluginDirectory):
- plugins/win/PluginPackageWin.cpp:
(WebCore::getVersionInfo):
(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):
- plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::handlePostReadFile):
Source/WTF:
This new String::charactersWithNullTermination() function returns a new Vector<UChar>
and does not modify the underlying string data.
- wtf/text/WTFString.cpp:
(WTF::String::charactersWithNullTermination):
- wtf/text/WTFString.h:
- 5:17 PM Changeset in webkit [152141] by
-
- 13 edits in trunk/Source/WebInspectorUI
Web Inspector: AX: Add container ARIA roles (toolbar, main, labeled regions, etc.)
so the layout is more discoverable to screen reader users
https://bugs.webkit.org/show_bug.cgi?id=118104
Patch by James Craig <james@cookiecrook.com> on 2013-06-27
Reviewed by Timothy Hatcher.
Made the basic layout (toolbar, sidebars, main) of the Web Inspector understandable
and navigable with VoiceOver.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/ButtonNavigationItem.js:
- UserInterface/CSSStyleDetailsSidebarPanel.js:
- UserInterface/DashboardManager.js:
- UserInterface/Main.js:
- UserInterface/NavigationBar.js:
- UserInterface/NavigationItem.js:
- UserInterface/NavigationSidebarPanel.js:
- UserInterface/RadioButtonNavigationItem.js:
- UserInterface/Sidebar.js:
- UserInterface/SidebarPanel.js:
- UserInterface/Toolbar.js:
- 5:14 PM Changeset in webkit [152140] by
-
- 5 edits6 adds in trunk
Implement parsing of MathML lengths.
https://bugs.webkit.org/show_bug.cgi?id=118053
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-06-27
Reviewed by Chris Fleizach.
Source/WebCore:
A parsing function for MathML lengths, similar to Gecko's one, is
implemented. It is currently only used to parse mfrac@linethickness but
will be convenient to parse other MathML attributes in the future.
Tests: mathml/presentation/mfrac-linethickness1.html
mathml/presentation/mfrac-linethickness2.html
mathml/presentation/mfrac-linethickness3.html
- rendering/mathml/RenderMathMLBlock.cpp: add parsing functions
(WebCore::parseMathMLLength): parsing MathML Length (number unit)
(WebCore::parseNamedSpace): parsing MathML namedspaces
- rendering/mathml/RenderMathMLBlock.h: declare parsing functions
- rendering/mathml/RenderMathMLFraction.cpp: use the parsing function for linethickness
(WebCore::RenderMathMLFraction::updateFromElement):
LayoutTests:
Add some reftests for mfrac@linethickness. Better tests for the parsing
of MathML lengths will be provided when mspace is implemented
(bug 115610)
- mathml/presentation/mfrac-linethickness1-expected-mismatch.html: Added.
- mathml/presentation/mfrac-linethickness1.html: Added.
- mathml/presentation/mfrac-linethickness2-expected.html: Added.
- mathml/presentation/mfrac-linethickness2.html: Added.
- mathml/presentation/mfrac-linethickness3-expected-mismatch.html: Added.
- mathml/presentation/mfrac-linethickness3.html: Added.
- 5:02 PM Changeset in webkit [152139] by
-
- 8 edits3 adds in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG should know how to find natural loops
https://bugs.webkit.org/show_bug.cgi?id=118152
Reviewed by Mark Hahnenberg.
There are a bunch of things we can do when we know where the loops are.
Previously we didn't. With this patch, we do.
This patch adds the classic dominator based natural loop finder.
The only client of this right now is the DFG::Disassembler. It prints out
a summary of the analysis for each block.
This will become more important when I do
https://bugs.webkit.org/show_bug.cgi?id=118151, which definitely requires
this kind of analysis, at least if we want to do the optimization over
DFG IR (and I'm pretty sure we do).
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAnalysis.h: Added.
(DFG):
(Analysis):
(JSC::DFG::Analysis::Analysis):
(JSC::DFG::Analysis::invalidate):
(JSC::DFG::Analysis::computeIfNecessary):
(JSC::DFG::Analysis::isValid):
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
- dfg/DFGDisassembler.cpp:
(JSC::DFG::Disassembler::createDumpList):
- dfg/DFGDominators.cpp:
(JSC::DFG::Dominators::Dominators):
(JSC::DFG::Dominators::compute):
- dfg/DFGDominators.h:
(Dominators):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dumpBlockHeader):
(JSC::DFG::Graph::invalidateCFG):
(DFG):
- dfg/DFGGraph.h:
(Graph):
- dfg/DFGNaturalLoops.cpp: Added.
(DFG):
(JSC::DFG::NaturalLoop::dump):
(JSC::DFG::NaturalLoops::NaturalLoops):
(JSC::DFG::NaturalLoops::~NaturalLoops):
(JSC::DFG::NaturalLoops::compute):
(JSC::DFG::NaturalLoops::loopsOf):
(JSC::DFG::NaturalLoops::dump):
- dfg/DFGNaturalLoops.h: Added.
(DFG):
(NaturalLoop):
(JSC::DFG::NaturalLoop::NaturalLoop):
(JSC::DFG::NaturalLoop::addBlock):
(JSC::DFG::NaturalLoop::header):
(JSC::DFG::NaturalLoop::size):
(JSC::DFG::NaturalLoop::at):
(JSC::DFG::NaturalLoop::operator[]):
(JSC::DFG::NaturalLoop::contains):
(NaturalLoops):
(JSC::DFG::NaturalLoops::numLoops):
(JSC::DFG::NaturalLoops::loop):
(JSC::DFG::NaturalLoops::headerOf):
- 4:41 PM Changeset in webkit [152138] by
-
- 2 edits in trunk/LayoutTests
[Mac WK2] compositing/repaint/positioned-movement.html flaky, missing repaint
https://bugs.webkit.org/show_bug.cgi?id=118153
Update the expectation to reflect that the test is also flakey on release and other
platforms
- platform/mac-wk2/TestExpectations:
- 4:31 PM Changeset in webkit [152137] by
-
- 2 edits in trunk/Source/WebCore
Remove call to deprecatedCharactersWithNullTermination() in WebGL code
https://bugs.webkit.org/show_bug.cgi?id=118154
Reviewed by Dean Jackson.
Remove an unneeded call to deprecatedCharactersWithNullTermination(). Ultimately,
the string we used to call it on gets converted to an UTF-8 CString that has a null character anyway.
- html/canvas/WebGLProgram.cpp:
(WebCore::WebGLProgram::cacheActiveAttribLocations):
- 4:04 PM Changeset in webkit [152136] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: AX: Console log of the Inspector does not announce output for screen readers
https://bugs.webkit.org/show_bug.cgi?id=115976
Patch by James Craig <james@cookiecrook.com> on 2013-06-27
Reviewed by Timothy Hatcher.
Main console log area (div.console-messages) is now an ARIA live region (role="log")
so screen readers speak plain text updates.
Also added contextual labels (e.g. input/output) but speech output verification of
those is currently blocked by http://webkit.org/b/118096
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/ConsoleCommand.js:
(WebInspector.ConsoleCommand.prototype.toMessageElement):
- UserInterface/ConsoleCommandResult.js:
(WebInspector.ConsoleCommandResult.prototype.toMessageElement):
- UserInterface/LogContentView.css:
(@media reader):
- UserInterface/LogContentView.js:
(WebInspector.LogContentView):
- 4:00 PM Changeset in webkit [152135] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Temporarily add some stderr output to Media Engine load methods to determine which engine buildbots are using for layout tests.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::load):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::load):
- 3:56 PM Changeset in webkit [152134] by
-
- 4 edits in trunk/Source/WebCore
Stop using deprecatedCharactersWithNullTermination in SQLite code
https://bugs.webkit.org/show_bug.cgi?id=118146
Reviewed by Filip Pizlo.
Turns out SQLite uses UTF-8 internally so we might just as well use the SQLite functions
that take UTF-8 strings and do the conversion ourselves. This has the added advantage that we can
use String::utf8() which returns a null-terminated string.
Require a version of SQLite newer than 3.6.16 so we can remove two workarounds. 3.6.16 was released
4 years ago so supported port is likely to have it.
- platform/sql/SQLiteFileSystem.cpp:
(WebCore::SQLiteFileSystem::openDatabase):
Use sqlite3_open instead of sqlite3_open16.
- platform/sql/SQLiteFileSystem.h:
Fix parameter name capitalization.
- platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
Use sqlite3_prepare_v2. Also, pass the length of the string (including the null character), since
that lets SQLite avoid a buffer copy. Remove a workaround for versions of SQLite older than 3.6.16.
- 3:43 PM Changeset in webkit [152133] by
-
- 10 edits in trunk/Tools
Sync up w3c import script with changes in Blink
https://bugs.webkit.org/show_bug.cgi?id=118149
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-27
Reviewed by Dirk Pranke.
This is a port of the following blink changes:
https://codereview.chromium.org/15366004
https://chromiumcodereview.appspot.com/15592005
https://codereview.chromium.org/16021006
https://codereview.chromium.org/15590004
https://codereview.chromium.org/15901008
https://codereview.chromium.org/16171009
https://codereview.chromium.org/16465007
https://codereview.chromium.org/15981013
- Scripts/webkitpy/common/checkout/checkout_unittest.py:
(setUp):
(test_commit_message_for_this_commit):
- Scripts/webkitpy/port/base.py:
(Port):
- Scripts/webkitpy/port/test.py:
- Scripts/webkitpy/w3c/test_converter.py:
(W3CTestConverter.init):
(W3CTestConverter.read_webkit_prefixed_css_property_list):
(W3CTestConverter.convert_for_webkit):
(W3CTestConverter.convert_css):
(W3CTestConverter.convert_html):
(W3CTestConverter.convert_testharness_paths):
(W3CTestConverter.convert_prefixed_properties):
(W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
- Scripts/webkitpy/w3c/test_converter_unittest.py:
- Scripts/webkitpy/w3c/test_importer.py:
(main):
(configure_logging):
(configure_logging.LogHandler):
(configure_logging.LogHandler.format):
(parse_args):
(TestImporter.init):
(TestImporter.find_importable_tests):
(TestImporter.import_tests):
(TestImporter.setup_destination_directory):
(TestImporter.remove_deleted_files):
- Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
(TestImporterTest.test_import_dir_with_no_tests):
(TestImporterTest):
- Scripts/webkitpy/w3c/test_parser.py:
(TestParser.load_file):
(TestParser.analyze_test):
(TestParser.support_files):
- Scripts/webkitpy/w3c/test_parser_unittest.py:
- 3:40 PM Changeset in webkit [152132] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Unnecessary root layer commits occur during html5 video playback
https://bugs.webkit.org/show_bug.cgi?id=118147
Patch by Andrew Lo <anlo@blackberry.com> on 2013-06-27
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson, John Griggs.
Only request layer commits when layer properties change in
GraphicsLayerBlackBerry::updateContentsRect and
GraphicsLayerBlackBerry::setContentsToMedia.
JIRA112749.
- platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore::GraphicsLayerBlackBerry::setContentsToMedia):
(WebCore::GraphicsLayerBlackBerry::updateContentsRect):
- 3:33 PM Changeset in webkit [152131] by
-
- 15 edits1 move4 adds in branches/dfgFourthTier/Source
fourthTier: JSC's disassembly infrastructure should be able to disassemble the code that LLVM generates
https://bugs.webkit.org/show_bug.cgi?id=118148
Source/JavaScriptCore:
Reviewed by Anders Carlsson.
Oh boy. UDis86 cannot disassemble the AVX (or whatever it's called) stuff
that LLVM generates for floating point. So the right decision is to
switch to the LLVM disassembler, right? Wrong!! LLVM's disassembler
cannot disassemble the load-from-absolute-address-into-%rax instructions
that our JIT generates quite a lot of.
So, this keeps the UDis86 disassembler, but adds the LLVM disassembler,
and requires the caller of disassemble() to hint which one is likely to
be less wrong for the given code.
Maybe in the future LLVM will catch up to UDis86, but it's definitely not
there right now.
This now allows us to disassemble all of the code that LLVM generates.
- JavaScriptCore.xcodeproj/project.pbxproj:
- disassembler/Disassembler.cpp:
(JSC::disassemble):
- disassembler/Disassembler.h:
(JSC::tryToDisassemble):
(JSC):
- disassembler/LLVMDisassembler.cpp: Added.
(JSC):
(JSC::symbolLookupCallback):
(JSC::tryToDisassembleWithLLVM):
- disassembler/LLVMDisassembler.h: Added.
(JSC):
(JSC::tryToDisassembleWithLLVM):
- disassembler/UDis86Disassembler.cpp:
(JSC::tryToDisassembleWithUDis86):
- disassembler/UDis86Disassembler.h: Added.
(JSC):
(JSC::tryToDisassembleWithUDis86):
- disassembler/X86Disassembler.cpp: Added.
(JSC):
(JSC::tryToDisassemble):
- ftl/FTLAbbreviatedTypes.h:
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLJITCode.h:
- ftl/FTLJITFinalizer.h:
- ftl/FTLLLVMHeaders.h: Removed.
- ftl/FTLLink.cpp:
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- runtime/Options.h:
(JSC):
Source/WTF:
Reviewed by Anders Carlsson.
We now use LLVM for two things: disassembler and FTL. Separate out the question
of whether we have LLVM (HAVE(LLVM)) from whether we want to use the LLVM
disassembler (USE(LLVM_DISASSEMBLER)) and whether we enable the FTL
(ENABLE(FTL_JIT)).
Also move the cruft for including LLVM headers into WTF since now we use it in
a bunch of places, not all related to FTL. There's no obvious place to put that
file in JSC so I put it in WTF.
- WTF.xcodeproj/project.pbxproj:
- wtf/LLVMHeaders.h: Copied from Source/JavaScriptCore/ftl/FTLLLVMHeaders.h.
- wtf/Platform.h:
- 3:20 PM Changeset in webkit [152130] by
-
- 9 edits2 copies in branches/safari-537-branch
Merged r152038. <rdar://problem/14282525>
- 3:19 PM Changeset in webkit [152129] by
-
- 7 edits in branches/safari-537-branch/Source
Merged r152035. <rdar://problem/14280545>
- 3:18 PM Changeset in webkit [152128] by
-
- 5 edits2 copies2 deletes in branches/safari-537-branch/Source/WebCore
Merged r152004. <rdar://problem/14278574>
- 3:17 PM Changeset in webkit [152127] by
-
- 2 edits in branches/safari-537-branch/Source/WebInspectorUI
Merged r151991. <rdar://problem/14260788>
- 3:17 PM Changeset in webkit [152126] by
-
- 3 edits3 copies in branches/safari-537-branch
Merged r152868. <rdar://problem/14230704>
- 3:16 PM Changeset in webkit [152125] by
-
- 6 edits3 copies in branches/safari-537-branch
Merged r151841. <rdar://problem/12476099>
- 3:15 PM Changeset in webkit [152124] by
-
- 7 edits in branches/safari-537-branch/Source/WebCore
Merged r151778. <rdar://problem/9524530>
- 3:14 PM Changeset in webkit [152123] by
-
- 8 edits in branches/safari-537-branch/Source
Merged r151745. <rdar://problem/9524530>
- 1:33 PM Changeset in webkit [152122] by
-
- 18 edits19 adds12 deletes in trunk
[CSS Shapes] New positioning model: basic support for rectangle shape-outside
https://bugs.webkit.org/show_bug.cgi?id=118080
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-27
Reviewed by David Hyatt.
Source/WebCore:
With the latest Editor's Draft of the CSS Shapes specification,
shape-outside no longer affects the positioning of floats. This is the
first step in changing the implementation to reflect this
specification change. The bulk of this change is reverting the code
that was needed to position floats based on the bounding box of the
shape.
Tests: csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html
- rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState): Revert changes to support float
positioning from shape-outside.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::blockSelectionGaps): Ditto.
(WebCore::RenderBlock::insertFloatingObject): Ditto.
(WebCore::RenderBlock::positionNewFloats): Ditto.
(WebCore::RenderBlock::logicalLeftOffsetForLine): Instead of
converting to shape bounding box coordinates, convert to the
float's margin box coordinates.
(WebCore::RenderBlock::logicalRightOffsetForLine): Ditto.
(WebCore::positionForPointRespectingEditingBoundaries): Revert changes
to support float positioning from shape-outside.
- rendering/RenderBlock.h:
(WebCore::RenderBlock::xPositionForFloatIncludingMargin): Ditto.
(WebCore::RenderBlock::yPositionForFloatIncludingMargin): Ditto.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Instead
of converting to shape bounding box coordinates, convert to the
float's margin box coordinates.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::mapLocalToContainer): Revert changes to support
float positioning from shape-outside.
(WebCore::RenderBox::offsetFromContainer): Ditto.
(WebCore::RenderBox::computeRectForRepaint): Ditto.
(WebCore::RenderBox::layoutOverflowRectForPropagation): Ditto.
- rendering/RenderBoxModelObject.cpp: Ditto.
- rendering/RenderBoxModelObject.h: Ditto.
- rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint): Ditto.
(WebCore::RenderInline::computeRectForRepaint): Ditto.
(WebCore::RenderInline::mapLocalToContainer): Ditto.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPosition): Ditto.
(WebCore::RenderLayer::calculateClipRects): Ditto.
(WebCore::RenderLayer::shouldBeNormalFlowOnly): Ditto.
- rendering/RenderLayer.h:
(WebCore::RenderLayer::offsetForInFlowPosition): Ditto.
- rendering/RenderObject.h: Ditto.
- rendering/shapes/ShapeInfo.h: Make m_renderer protected, since we
now need it in the subclass to compute the segments.
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::computeSegmentsForLine): Update segment
computation to use the float's margin box instead of the shape's
bounding box for computing the deltas.
(WebCore::ShapeOutsideInfo::leftSegmentMarginBoxDelta): This used to
be leftSegmentShapeBoundingBoxDelta, which has been renamed in the
obvious way.
(WebCore::ShapeOutsideInfo::rightSegmentMarginBoxDelta): This used to
be rightSegmentShapeBoundingBoxDelta, which has been renamed in the
obvious way.
- rendering/shapes/ShapeOutsideInfo.h: Revert changes to support float
positioning from shape-outside.
- rendering/style/RenderStyle.h: Ditto.
LayoutTests:
Added new tests for the new model. These tests are also spec tests, so
their canonical location is now in the CSS WG's repository. They have
been imported to WebKit using the import-w3c-tests script, and that's
why they live under the csswg directory.
The new tests replace the shape-outside-floats-simple-rectangle.html
test, which was anything but simple.
Tests that have not been rewritten yet have been marked as skipped.
Tests for the old positioning behavior that are not applicable to the
new behavior have been deleted.
- TestExpectations: Skip all the tests that need to be rewritten.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000-expected.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001-expected.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002-expected.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000-expected.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000-expected.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001-expected.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002-expected.html: Added.
- csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html: Added.
- csswg/submitted/shapes/shape-outside/w3c-import.log: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-margin-is-ignored-expected.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-margin-is-ignored.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-non-zero-y-expected.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-non-zero-y.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-overflow-hidden-expected.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-overflow-hidden.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-overhang-expected.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-overhang.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-positioning-expected.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-positioning.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rectangle-expected.html: Removed.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rectangle.html: Removed.
- 1:02 PM Changeset in webkit [152121] by
-
- 4 edits in trunk/Source/WebCore
RenderLayerCompositor destructor is fragile
https://bugs.webkit.org/show_bug.cgi?id=118143
Reviewed by Simon Fraser.
With iOS tile cache implementation deleting RenderLayerCompositor may end up starting a deleted timer.
This corrupts the timer heap and leads to a crash later. This happens because GraphicsLayers destructor
calls back to the RenderLayerCompositor that is being deleted. This is pretty fragile in general.
No test as there is no known way to repro this with plain webkit.
- platform/Timer.cpp:
(WebCore::TimerBase::TimerBase):
(WebCore::TimerBase::~TimerBase):
(WebCore::TimerBase::setNextFireTime):
- platform/Timer.h:
Assert that the timer is alive before starting it. This turns bugs like this into clear crash stacks
instead of hard-to-debug timer heap corruptions.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::~RenderLayerCompositor):
Take care to delete owned GraphicsLayers before proceeding with the rest of the destructor.
- 12:36 PM Changeset in webkit [152120] by
-
- 34 edits in trunk/Source/WebCore
Update SVG interfaces to stop inheriting from SVGURIReference and SVGTests
https://bugs.webkit.org/show_bug.cgi?id=118142
Reviewed by Ryosuke Niwa.
Stop inheriting from SVGURIReference and SVGTests and use IDL implements statements
instead. This is one step towards getting rid of multiple inheritance in SVG (which
is no longer supported by Web IDL) and matching the latest specification:
No new tests, no behavior change.
- CMakeLists.txt:
- DerivedSources.pri:
- GNUmakefile.list.am:
- svg/SVGAElement.idl:
- svg/SVGAltGlyphElement.idl:
- svg/SVGAnimationElement.idl:
- svg/SVGCircleElement.idl:
- svg/SVGClipPathElement.idl:
- svg/SVGCursorElement.idl:
- svg/SVGDefsElement.idl:
- svg/SVGEllipseElement.idl:
- svg/SVGFEImageElement.idl:
- svg/SVGFilterElement.idl:
- svg/SVGForeignObjectElement.idl:
- svg/SVGGElement.idl:
- svg/SVGGlyphRefElement.idl:
- svg/SVGGradientElement.idl:
- svg/SVGImageElement.idl:
- svg/SVGLineElement.idl:
- svg/SVGMPathElement.idl:
- svg/SVGMaskElement.idl:
- svg/SVGPathElement.idl:
- svg/SVGPatternElement.idl:
- svg/SVGPolygonElement.idl:
- svg/SVGPolylineElement.idl:
- svg/SVGRectElement.idl:
- svg/SVGSVGElement.idl:
- svg/SVGScriptElement.idl:
- svg/SVGSwitchElement.idl:
- svg/SVGTRefElement.idl:
- svg/SVGTextContentElement.idl:
- svg/SVGTextPathElement.idl:
- svg/SVGUseElement.idl:
- 11:37 AM Changeset in webkit [152119] by
-
- 2 edits in trunk/Websites/webkit.org
Update required tools for Windows instructions.
- building/tools.html:
- 11:16 AM Changeset in webkit [152118] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should be able to dump disassembly
https://bugs.webkit.org/show_bug.cgi?id=118141
Reviewed by Geoffrey Garen.
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- 11:13 AM Changeset in webkit [152117] by
-
- 8 edits in trunk/Source/WebCore
Polish context menus for media elements
https://bugs.webkit.org/show_bug.cgi?id=118078
<rdar://problem/14278960>
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-27
Reviewed by Eric Carlson.
No new tests: media/context-menu-action.html,
which has been disabled by bug 116651, is used to test context menus.
- English.lproj/Localizable.strings: Changed "Fullscreen" to "Full Screen"
and added strings "Show Controls" and "Hide Controls".
- page/ContextMenuController.cpp: Updated to include a new context menu item
that toggles betweeen "Show Controls" and "Hide Controls".
- platform/ContextMenuItem.h:
- platform/LocalizedStrings.cpp:
- platform/LocalizedStrings.h:
- platform/efl/LocalizedStringsEfl.cpp:
- platform/gtk/LocalizedStringsGtk.cpp:
- platform/qt/LocalizedStringsQt.cpp:
Added equivalents of localized strings "Show Controls" and "Hide Controls".
- 11:08 AM Changeset in webkit [152116] by
-
- 9 edits2 copies in tags/Safari-537.47
Merged r152038. <rdar://problem/14282525>
- 11:01 AM Changeset in webkit [152115] by
-
- 7 edits in tags/Safari-537.47/Source
Merged r152035. <rdar://problem/14280545>
- 10:57 AM Changeset in webkit [152114] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
Unreviewed, fix build for LLVM ToT.
This doesn't affect those using the binary drops, but if you're building from
LLVM ToT you'll get link errors. These arise because we expect there to be a
libLLVMArchive, but that is no longer built by LLVM ToT. This casues the linker
to fall back on the system's libLLVMArchive, which is incompatible with the
other LLVM libs we pull in.
Also, we didn't need that library anyway and shouldn't have been linking
against it.
- Configurations/JavaScriptCore.xcconfig:
- 10:49 AM Changeset in webkit [152113] by
-
- 2 edits in trunk/Tools
[webkitpy] AbstractPatchSequencingCommand should have _prepare_state
https://bugs.webkit.org/show_bug.cgi?id=118128
Reviewed by Ryosuke Niwa.
It is a preparation for a new webkit-patch command: run-tests-touched-by-attachment
https://bugs.webkit.org/show_bug.cgi?id=117831
- Scripts/webkitpy/tool/commands/download.py:
(AbstractPatchSequencingCommand):
(AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps.
(AbstractPatchSequencingCommand._process_patch): Use the same initial state for each patch.
(AbstractPatchSequencingCommand._prepare_state): Added.
- 10:47 AM Changeset in webkit [152112] by
-
- 5 edits2 copies2 deletes in tags/Safari-537.47/Source/WebCore
Merged r152004. <rdar://problem/14278574>
- 10:45 AM Changeset in webkit [152111] by
-
- 2 edits in tags/Safari-537.47/Source/WebInspectorUI
Merged r151991. <rdar://problem/14260788>
- 10:44 AM Changeset in webkit [152110] by
-
- 3 edits in trunk/Source/WebKit2
Fix cast-align warnings in WebKit2/Platform/CoreIPC
https://bugs.webkit.org/show_bug.cgi?id=117987
Reviewed by Rob Buis, WK2 signed-off by Anders Carlsson.
- Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::decode):
- Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::ArgumentEncoder::encode):
- 10:42 AM Changeset in webkit [152109] by
-
- 3 edits3 copies in tags/Safari-537.47
Merged r151868. <rdar://problem/14230704>
- 10:40 AM Changeset in webkit [152108] by
-
- 6 edits3 copies in tags/Safari-537.47
Merged r151841. <rdar://problem/12476099>
- 10:37 AM Changeset in webkit [152107] by
-
- 7 edits in tags/Safari-537.47/Source/WebCore
Merged r151778. <rdar://problem/9524530>
- 10:34 AM Changeset in webkit [152106] by
-
- 8 edits in tags/Safari-537.47/Source
Merged r151745. <rdar://problem/9524530>
- 9:51 AM Changeset in webkit [152105] by
-
- 4 edits2 adds in trunk
AX: IOS: crash while navigating with SVG
https://bugs.webkit.org/show_bug.cgi?id=118101
Source/WebCore:
Need to check if the SVG path exists before copying it.
Reviewed by Stephen Chenney.
Test: platform/iphone-simulator/accessibility/svg-path-crash.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::elementPath):
- rendering/svg/RenderSVGShape.h:
(WebCore::RenderSVGShape::hasPath):
LayoutTests:
Reviewed by Stephen Chenney.
- platform/iphone-simulator/accessibility/svg-path-crash-expected.txt: Added.
- platform/iphone-simulator/accessibility/svg-path-crash.html: Added.
- 9:44 AM Changeset in webkit [152104] by
-
- 2 edits in trunk/Tools
[Qt] Build overrides -j when given --makeargs="-sj40"
https://bugs.webkit.org/show_bug.cgi?id=116897
Patch by Brendan Long <b.long@cablelabs.com> on 2013-06-27
Reviewed by Csaba Osztrogonác.
- Scripts/webkitdirs.pm:
(buildQMakeProjects):
Change regex checking for -j* to also check for -*j*
- 9:33 AM Changeset in webkit [152103] by
-
- 3 edits in trunk/Source/WebCore
Removing the redundant checks after r152078
https://bugs.webkit.org/show_bug.cgi?id=118117
Patch by Seokju Kwon <Seokju Kwon> on 2013-06-27
Reviewed by Simon Fraser.
Avoided redundant checks in RenderLayerCompositor::reasonsForCompositing() after r152078.
No new tests as no functionality change.
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logReasonsForCompositing):
- 9:32 AM Changeset in webkit [152102] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] We should clear all markers when input changes a word
https://bugs.webkit.org/show_bug.cgi?id=118136
JIRA115313.
For the case where a letter is added to the middle of a misspelled word, we were
sending incorrect offsets to clear spelling markers. However, since this
expanded the current word, it overlaps entirely the previous spelling marker so
no issue is found. However, if the keypress is backspace, the incorrect range
is smaller, causing an overlap which recreates the marker over the last character.
Setting shouldEraseMarkersAfterChangeSelection to follow continuous spell checking,
which will clear all markers regardless of overlap.
This patch also sustains spelling markers after the user taps to move the caret onto
the word, which is a nice gain as it was asked for previously.
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-06-27
Reviewed by Rob Buis.
Internally Reviewed by Mike Fenton
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldEraseMarkersAfterChangeSelection):
- 9:19 AM Changeset in webkit [152101] by
-
- 3 edits in trunk/LayoutTests
[GTK] Unreviewed gardening. Unskip tests no longer timing out.
https://bugs.webkit.org/show_bug.cgi?id=118135
Unreviewed GTK gardening.
Patch by Simon Pena <simon.pena@samsung.com> on 2013-06-27
- platform/gtk-wk1/TestExpectations:
- platform/gtk/TestExpectations:
- 8:46 AM Changeset in webkit [152100] by
-
- 40 edits4 copies4 moves in trunk
Remove [NoInterfaceObject] from WorkerGlobalScope
https://bugs.webkit.org/show_bug.cgi?id=118071
Reviewed by Kentaro Hara.
.:
Update GENERATE_BINDINGS CMake macro to take 2 additional parameters
now needed by the preprocess-idls.pl script.
- Source/cmake/WebKitMacros.cmake:
Source/WebCore:
Expose WorkerGlobalScope interface in worker environment as per the latest
specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#the-workerglobalscope-common-interface
Also expose the SharedWorkerGlobalScope interface when the JavaScript global environment is a
shared worker environment, and the DedicatedWorkerGlobalScope interface when the JavaScript
global environment is a dedicated worker environment:
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#sharedworkerglobalscope
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#dedicatedworkerglobalscope
The semantics of the [GlobalContext] IDL extended attribute has changed to support this
use case. The value for the extended attribute is now the name of the interface to which the
Constructor attribute should be added (Window, WorkerGlobalScope, SharedWorkerGlobalScope...).
It is possible to specify several interface names by using '&' as separator. For e.g.
[GlobalContext=DOMWindow&WorkerGlobalScope].
Tests: fast/js/global-constructors-attributes-dedicated-worker.html
fast/js/global-constructors-attributes-shared-worker.html
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- Modules/websockets/WebSocket.idl:
- UseJSC.cmake:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorHelperMethods):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/generate-bindings.pl:
(checkIfIDLAttributesExists):
- bindings/scripts/preprocess-idls.pl:
- dom/MessageChannel.idl:
- dom/MessageEvent.idl:
- fileapi/Blob.idl:
- fileapi/FileReader.idl:
- fileapi/FileReaderSync.idl:
- html/DOMURL.idl:
- html/canvas/ArrayBuffer.idl:
- html/canvas/DataView.idl:
- html/canvas/Float32Array.idl:
- html/canvas/Float64Array.idl:
- html/canvas/Int16Array.idl:
- html/canvas/Int32Array.idl:
- html/canvas/Int8Array.idl:
- html/canvas/Uint16Array.idl:
- html/canvas/Uint32Array.idl:
- html/canvas/Uint8Array.idl:
- html/canvas/Uint8ClampedArray.idl:
- page/EventSource.idl:
- workers/DedicatedWorkerGlobalScope.idl:
- workers/SharedWorkerGlobalScope.idl:
- workers/WorkerGlobalScope.idl:
- workers/WorkerLocation.idl:
- xml/XMLHttpRequest.idl:
Tools:
Update bindings test script to pass 2 additional parameters
now needed by the preprocess-idls.pl script.
- Scripts/webkitpy/bindings/main.py:
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.main):
LayoutTests:
Split fast/js/global-constructors-attributes-worker.html test into 2 for both
shared and dedicated workers, as the output is now different.
- fast/js/global-constructors-attributes-dedicated-worker-expected.txt: Copied from LayoutTests/fast/js/global-constructors-attributes-worker-expected.txt.
- fast/js/global-constructors-attributes-dedicated-worker.html: Copied from LayoutTests/fast/js/global-constructors-attributes-worker.html.
- fast/js/global-constructors-attributes-shared-worker-expected.txt: Renamed from LayoutTests/fast/js/global-constructors-attributes-worker-expected.txt.
- fast/js/global-constructors-attributes-shared-worker.html: Renamed from LayoutTests/fast/js/global-constructors-attributes-worker.html.
- fast/js/script-tests/global-constructors-attributes.js:
(.self.postMessage):
(.self.onconnect.self.postMessage):
(.self.onconnect):
- platform/efl/fast/js/global-constructors-attributes-dedicated-worker-expected.txt: Copied from LayoutTests/platform/gtk/fast/js/global-constructors-attributes-worker-expected.txt.
- platform/efl/fast/js/global-constructors-attributes-shared-worker-expected.txt: Copied from LayoutTests/platform/gtk/fast/js/global-constructors-attributes-worker-expected.txt.
- platform/gtk/fast/js/global-constructors-attributes-dedicated-worker-expected.txt: Renamed from LayoutTests/platform/gtk/fast/js/global-constructors-attributes-worker-expected.txt.
- platform/gtk/fast/js/global-constructors-attributes-shared-worker-expected.txt: Renamed from LayoutTests/platform/efl/fast/js/global-constructors-attributes-worker-expected.txt.
- 8:42 AM Changeset in webkit [152099] by
-
- 7 edits2 deletes in trunk/Source
Unreviewed, rolling out r152074.
http://trac.webkit.org/changeset/152074
https://bugs.webkit.org/show_bug.cgi?id=118137
It caused lots of layout and API test crash on Qt Wk2.
(Requested by kadam on #webkit).
Source/WebCore:
- CMakeLists.txt:
- Target.pri:
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp: Removed.
- platform/graphics/texmap/coordinated/CompositingCoordinator.h: Removed.
Source/WebKit2:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::~CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::setRootCompositingLayer):
(WebKit::CoordinatedLayerTreeHost::invalidate):
(WebKit::CoordinatedLayerTreeHost::forceRepaint):
(WebKit::CoordinatedLayerTreeHost::sizeDidChange):
(WebKit::CoordinatedLayerTreeHost::flushPendingLayerChanges):
(WebKit::CoordinatedLayerTreeHost::clearPendingStateChanges):
(WebKit::CoordinatedLayerTreeHost::initializeRootCompositingLayerIfNeeded):
(WebKit::CoordinatedLayerTreeHost::syncLayerState):
(WebKit::CoordinatedLayerTreeHost::prepareCustomFilterProxiesIfNeeded):
(WebKit::CoordinatedLayerTreeHost::checkCustomFilterProgramProxies):
(WebKit::CoordinatedLayerTreeHost::removeCustomFilterProgramProxy):
(WebKit::CoordinatedLayerTreeHost::detachLayer):
(WebKit::CoordinatedLayerTreeHost::performScheduledLayerFlush):
(WebKit::CoordinatedLayerTreeHost::syncDisplayState):
(WebKit::CoordinatedLayerTreeHost::didPerformScheduledLayerFlush):
(WebKit::CoordinatedLayerTreeHost::createPageOverlayLayer):
(WebKit::CoordinatedLayerTreeHost::createImageBackingIfNeeded):
(WebKit::CoordinatedLayerTreeHost::createImageBacking):
(WebKit::CoordinatedLayerTreeHost::updateImageBacking):
(WebKit::CoordinatedLayerTreeHost::clearImageBackingContents):
(WebKit::CoordinatedLayerTreeHost::removeImageBacking):
(WebKit::CoordinatedLayerTreeHost::flushPendingImageBackingChanges):
(WebKit::CoordinatedLayerTreeHost::notifyAnimationStarted):
(WebKit::CoordinatedLayerTreeHost::notifyFlushRequired):
(WebKit::CoordinatedLayerTreeHost::paintContents):
(WebKit::CoordinatedLayerTreeHost::createGraphicsLayer):
(WebKit::CoordinatedLayerTreeHost::deviceScaleFactor):
(WebKit::CoordinatedLayerTreeHost::pageScaleFactor):
(WebKit::CoordinatedLayerTreeHost::createUpdateAtlas):
(WebKit::CoordinatedLayerTreeHost::removeUpdateAtlas):
(WebKit::CoordinatedLayerTreeHost::visibleContentsRect):
(WebKit::CoordinatedLayerTreeHost::mainContentsLayer):
(WebKit::CoordinatedLayerTreeHost::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
(WebKit::CoordinatedLayerTreeHost::graphicsLayerFactory):
(WebKit::CoordinatedLayerTreeHost::scheduleAnimation):
(WebKit::CoordinatedLayerTreeHost::renderNextFrame):
(WebKit::CoordinatedLayerTreeHost::purgeBackingStores):
(WebKit::CoordinatedLayerTreeHost::paintToSurface):
(WebKit::CoordinatedLayerTreeHost::scheduleReleaseInactiveAtlases):
(WebKit::CoordinatedLayerTreeHost::releaseInactiveAtlasesTimerFired):
(WebKit::CoordinatedLayerTreeHost::commitScrollOffset):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::setVisibleContentsRect):
(WebKit::LayerTreeHost::renderNextFrame):
(WebKit::LayerTreeHost::purgeBackingStores):
- 8:11 AM Changeset in webkit [152098] by
-
- 2 edits in trunk/Source/WebCore
Avoid duplicating hostWindow() call in FrameView::setFrameRect()
https://bugs.webkit.org/show_bug.cgi?id=118115
Patch by Seokju Kwon <Seokju Kwon> on 2013-06-27
Reviewed by Christophe Dumez.
Remove a redundant call in FrameView::setFrameRect().
No function change, no tests.
- page/FrameView.cpp:
(WebCore::FrameView::scheduleAnimation):
- 7:35 AM Changeset in webkit [152097] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=118100
Unreviewed Qt gardening.
Moved hover-display-block-none.html from fast/regions to fast/css.
Patch by Seokju Kwon <Seokju Kwon> on 2013-06-27
- platform/qt/TestExpectations:
- 7:19 AM Changeset in webkit [152096] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebase the previous test.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-27
- platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
- 6:48 AM Changeset in webkit [152095] by
-
- 8 edits in trunk
Fixing some compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=117791
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-06-27
Reviewed by Martin Robinson.
Source/WebCore:
No new tests needed.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetTextForOffset): Fixed warning about
uninitialized variable.
Source/WebKit2:
- UIProcess/API/gtk/tests/WebExtensionTest.cpp: Properly
initialized GDBusInterfaceVTable.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkitWebPageCreate): Added missing fields to the
WKBundlePageLoaderClient.
Tools:
- GNUmakefile.am: Silenced format warning.
- TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
(TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
Solved warning about uninitialized variable.
- 6:31 AM Changeset in webkit [152094] by
-
- 7 edits2 moves in trunk/Source
Use consistent file names for WidgetBackingStoreGtkX11 class
https://bugs.webkit.org/show_bug.cgi?id=118124
Patch by Iago Toral Quiroga <itoral@igalia.com> on 2013-06-27
Reviewed by Carlos Garcia Campos.
Source/WebCore:
- GNUmakefile.list.am:
- PlatformGTK.cmake:
- platform/gtk/GtkWidgetBackingStoreX11.cpp: Removed.
- platform/gtk/GtkWidgetBackingStoreX11.h: Removed.
- platform/gtk/WidgetBackingStoreGtkX11.cpp: Added.
(WebCore::WidgetBackingStoreGtkX11::create):
(WebCore::WidgetBackingStoreGtkX11::WidgetBackingStoreGtkX11):
(WebCore::WidgetBackingStoreGtkX11::~WidgetBackingStoreGtkX11):
(WebCore::WidgetBackingStoreGtkX11::cairoSurface):
(WebCore::WidgetBackingStoreGtkX11::scroll):
- platform/gtk/WidgetBackingStoreGtkX11.h: Added.
Source/WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.cpp:
Source/WebKit2:
- UIProcess/cairo/BackingStoreCairo.cpp:
- 5:46 AM Changeset in webkit [152093] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebase and skipping failing tests.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-27
- platform/qt-5.0-wk1/TestExpectations:
- platform/qt/TestExpectations:
- platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
- 4:07 AM Changeset in webkit [152092] by
-
- 4 edits2 adds in trunk/Source/WebInspectorUI
Web Inspector: Display color picker in popover on color swatch click
https://bugs.webkit.org/show_bug.cgi?id=117919
Patch by Matthew Holden <jftholden@yahoo.com> on 2013-06-27
Reviewed by Timothy Hatcher.
Includes fixes from second code review.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/CSSColorPicker.css: Added.
(.colorpicker-container):
(.colorpicker-fill-parent):
(.colorpicker-top):
(.colorpicker-color):
(.colorpicker-bottom span):
(.colorpicker-text):
(.colorpicker-color-text-value):
(.colorpicker-hue):
(.colorpicker-fill):
(.colorpicker-range-container):
(.colorpicker-range-container *):
(.colorpicker-range-container label):
(.colorpicker-range-container input):
(.colorpicker-saturation):
(.colorpicker-value):
(.colorpicker-dragger):
(.colorpicker-slider):
(.colorpicker-container .swatch):
(.colorpicker-container .swatch-inner):
- UserInterface/CSSColorPicker.js: Added.
(WebInspector.CSSColorPicker.consume):
(WebInspector.CSSColorPicker.move):
(WebInspector.CSSColorPicker.start):
(WebInspector.CSSColorPicker.stop):
(WebInspector.CSSColorPicker.makeDraggable):
(WebInspector.CSSColorPicker.hueDrag):
(WebInspector.CSSColorPicker.colorDragStart):
(WebInspector.CSSColorPicker.colorDrag):
(WebInspector.CSSColorPicker.alphaDrag):
(WebInspector.CSSColorPicker.colorSwatchClicked):
(WebInspector.CSSColorPicker):
(WebInspector.CSSColorPicker.prototype.get element):
(WebInspector.CSSColorPicker.prototype.set color):
(WebInspector.CSSColorPicker.prototype.get color):
(WebInspector.CSSColorPicker.prototype.get outputColorFormat):
(WebInspector.CSSColorPicker.prototype.get colorHueOnly):
(WebInspector.CSSColorPicker.prototype.set displayText):
(WebInspector.CSSColorPicker.prototype.shown):
(WebInspector.CSSColorPicker.prototype._updateHelperLocations):
(WebInspector.CSSColorPicker.prototype._updateDisplay):
(WebInspector.CSSColorPicker.hsvaToRGBA):
(WebInspector.CSSColorPicker.rgbaToHSVA):
- UserInterface/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype.didDismissPopover):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.event.newColorText.colorTextMarker):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.event.newColorText):
- UserInterface/Main.html:
- 4:03 AM Changeset in webkit [152091] by
-
- 4 edits in trunk
Notify the debugger about functions created from source code via new Function() or WebCore::JSLazyEventListener.
https://bugs.webkit.org/show_bug.cgi?id=118063
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::fromGlobalCode): Call Debugger::sourceParsed.
LayoutTests:
- inspector/debugger/debugger-script-preprocessor-expected.txt: Updated.
- 3:36 AM Changeset in webkit [152090] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline fast/js/global-constructors-attributes.html for EFL port
after r151914. WaveTable was renamed to PeriodicWave.
- platform/efl/fast/js/global-constructors-attributes-expected.txt:
- 3:35 AM Changeset in webkit [152089] by
-
- 2 edits in trunk/Source/WebCore
Buildfix for !ENABLE(SVG) builds.
Reviewed by Csaba Osztrogonác.
Moving RenderObject::hasAspectRatio() outside from ENABLE(SVG) guard.
- rendering/RenderObject.h:
(WebCore::RenderObject::hasAspectRatio):
- 3:30 AM Changeset in webkit [152088] by
-
- 9 edits in trunk/Source/WebCore
Adopt is/toHTMLLabelElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118113
Reviewed by Andreas Kling.
To enhance readability, this patch adopts is/toHTMLLabelElement.
This also helps out to reduce duplicated use of static_cast.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::labelChanged):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::labelForElement):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::labelElementContainer):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- dom/DocumentOrderedMap.cpp:
(WebCore::keyMatchesLabelForAttribute):
- dom/Element.cpp:
(WebCore::Element::updateLabel):
- dom/TreeScope.cpp:
(WebCore::TreeScope::labelElementForId):
- html/HTMLLabelElement.h:
(WebCore::isHTMLLabelElement):
(WebCore::toHTMLLabelElement):
- html/LabelsNodeList.cpp:
(WebCore::LabelsNodeList::nodeMatches):
- 3:28 AM Changeset in webkit [152087] by
-
- 4 edits in trunk/Source/WebCore
[curl] Fix unused variable/parameter warnings
https://bugs.webkit.org/show_bug.cgi?id=118050
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-06-27
Reviewed by Christophe Dumez.
Commented out unused parameters and removed an unused variable in the curl backend.
No tests required.
- platform/network/curl/CredentialStorageCurl.cpp:
(WebCore::CredentialStorage::getFromPersistentStorage):
- platform/network/curl/DNSCurl.cpp:
(WebCore::prefetchDNS):
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::curl_lock_callback):
(WebCore::curl_unlock_callback):
(WebCore::headerCallback):
(WebCore::ResourceHandleManager::downloadTimerCallback):
- 3:10 AM Changeset in webkit [152086] by
-
- 3 edits in trunk/Source/WebCore
Fix cast-align warnings in WebCore/platform/graphics/cairo
https://bugs.webkit.org/show_bug.cgi?id=117990
Reviewed by Rob Buis.
- platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::checkForSolidColor):
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):
- 3:05 AM Changeset in webkit [152085] by
-
- 2 edits in trunk/Source/WebCore
[curl] Add "set-cookie" to appendable headers
https://bugs.webkit.org/show_bug.cgi?id=118061
Patch by Szabolcs Dávid <davidsz@inf.u-szeged.hu> on 2013-06-27
Reviewed by Christophe Dumez.
Mark set-cookie as an appendable header.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::isAppendableHeader):
- 1:49 AM Changeset in webkit [152084] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] [WK2] Check value of WEBKIT_INJECTED_BUNDLE_PATH
https://bugs.webkit.org/show_bug.cgi?id=118055
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-06-27
Reviewed by Carlos Garcia Campos.
If the directory pointed at by WEBKIT_INJECTED_BUNDLE_PATH does
not exist, fall back to the system directory.
This makes MiniBrowser work outside the build tree.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(injectedBundleDirectory):
- 12:49 AM Changeset in webkit [152083] by
-
- 9 edits3 adds in trunk
Source/WebCore: Remove ENABLE_CSS_COMPOSITING guards around -webkit-background-blend mode related code. The same flag guards -webkit-blend-mode code, but those guards are not touched by this change.
https://bugs.webkit.org/show_bug.cgi?id=117619
Patch by Horia Iosif Olaru <olaru@adobe.com> on 2013-06-27
Reviewed by Dean Jackson.
Test: css3/compositing/effect-background-blend-mode-tiled.html
- WebCore.exp.in:
- bindings/generic/RuntimeEnabledFeatures.h:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillProperty):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- css/CSSPropertyNames.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
LayoutTests: Add an extra test to check if tiled background images get blended as expected. This test passed before this change. The tests for this change are the existing background-blend-mode tests.
https://bugs.webkit.org/show_bug.cgi?id=117619
Patch by Horia Iosif Olaru <olaru@adobe.com> on 2013-06-27
Reviewed by Dean Jackson.
- css3/compositing/effect-background-blend-mode-tiled-expected.txt: Added.
- css3/compositing/effect-background-blend-mode-tiled.html: Added.
- platform/mac/css3/compositing/effect-background-blend-mode-tiled-expected.png: Added.
- 12:28 AM Changeset in webkit [152082] by
-
- 2 edits in trunk/Tools
Fix bindings tests after r152080
https://bugs.webkit.org/show_bug.cgi?id=118118
Reviewed by Gyuyoung Kim.
r152080 renamed argument to preprocess-idls.pl from --workerContextConstructorsFile
to --workerGlobalScopeConstructorsFile. This patch updates to bindings test script
accordingly.
- Scripts/webkitpy/bindings/main.py:
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.main):
- 12:00 AM Changeset in webkit [152081] by
-
- 6 edits in trunk
[BlackBerry] Handle testRunner.setCustomPolicyDelegate()
https://bugs.webkit.org/show_bug.cgi?id=117982
Patch by Carlos Garcia Campos <cargarcia@blackberry.com> on 2013-06-26
Reviewed by Rob Buis.
Source/WebKit/blackberry:
Take custom policy into account when deciding the policy for
navigation actions.
Fixes test fast/loader/onload-policy-ignore-for-frame.html.
- Api/DumpRenderTreeClient.h:
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
If custom policy is enabled ignore the navigation action when it's
not permissive.
Tools:
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::DumpRenderTree): Initialize
m_policyDelegateIsPermissive.
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
Reset m_policyDelegateIsPermissive.
(BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate): Set
m_policyDelegateIsPermissive.
- DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
(BlackBerry::WebKit::DumpRenderTree::policyDelegateEnabled):
Return whether custom policy is enabled.
(BlackBerry::WebKit::DumpRenderTree::policyDelegateIsPermissive):
Return whether custom policy is permissive.
