Timeline
Sep 16, 2013:
- 9:23 PM Changeset in webkit [155929] by
-
- 3 edits in trunk/Tools
[Windows] Clean up WinLauncher by using smart pointers
https://bugs.webkit.org/show_bug.cgi?id=121467
Reviewed by Anders Carlsson.
- WinLauncher/PrintWebUIDelegate.cpp:
(PrintWebUIDelegate::webViewPrintingMarginRect): Switch to smart pointers.
- WinLauncher/WinLauncher.cpp:
(WinLauncherWebHost::updateAddressBar): Use _bstr_t and smart pointers.
(WinLauncherWebHost::didFailProvisionalLoadWithError): Ditto.
(showLastVisitedSites): Smart pointer updates.
(WinLauncherWebHost::didFinishLoadForFrame): Ditto.
(setToDefaultPreferences): Ditto.
(dllLauncherEntryPoint): Ditto.
(PrintView): Ditto.
(LaunchInspector): Ditto.
(NavigateToHistory): Ditto.
(MyEditProc): Ditto.
(loadURL): Ditto.
- 9:22 PM Changeset in webkit [155928] by
-
- 69 edits in trunk/Source/WebCore
CTTE: InputType should store its HTMLInputElement back pointer as a reference
https://bugs.webkit.org/show_bug.cgi?id=121466
Reviewed by Anders Carlsson.
- Converts InputType::create() and InputType::createText() to take a HTMLInputElement& (as well as all the subclasses).
- Change InputType::element() to return an HTMLInputElement& and update all the callers.
- 9:15 PM Changeset in webkit [155927] by
-
- 3 edits in trunk/Source/WebKit2
Fix EFL build after r155888
https://bugs.webkit.org/show_bug.cgi?id=121465
Patch by Sergio Correia <Sergio Correia> on 2013-09-16
Reviewed by Gyuyoung Kim.
Update WebView to follow the changes in PageClient in r155888.
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::createDrawingAreaProxy): Use createOwned (addded in
r155407) to return the DrawingAreaProxy from DrawingAreaProxyImpl.
- UIProcess/CoordinatedGraphics/WebView.h: Update createDrawingAreaProxy()
signature to match PageClient.h.
- 6:49 PM Changeset in webkit [155926] by
-
- 4 edits in trunk/Source/WTF
USE(WEB_THREAD): More explicit WebThread initialization
https://bugs.webkit.org/show_bug.cgi?id=121454
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-16
Reviewed by Benjamin Poulain.
Be more explicit when initializing WebThread only data.
- wtf/MainThread.h:
- wtf/MainThread.cpp:
(WTF::initializeWebThreadOnce):
(WTF::initializeWebThread):
Ensure one time initialization.
- wtf/mac/MainThreadMac.mm:
(WTF::initializeMainThreadPlatform):
(WTF::initializeWebThreadPlatform):
Move WebThread value initialization to its own function.
(WTF::isMainThread):
Remove no longer invalid assert if WebThread was not initialized.
- 6:39 PM Changeset in webkit [155925] by
-
- 5 edits2 copies in branches/safari-537.60-branch/Source/WebCore
Merged r155226. <rdar://problem/14949946>
- 6:31 PM Changeset in webkit [155924] by
-
- 9 edits in trunk/Source
Make InspectorTimelineAgent use an enum for the record type instead of a string.
https://bugs.webkit.org/show_bug.cgi?id=121461
Reviewed by Joseph Pecoraro.
Source/WebCore:
- inspector/Inspector.json:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore::toProtocol):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):
- inspector/InspectorTimelineAgent.h:
(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
Source/WebInspectorUI:
- UserInterface/InspectorBackendCommands.js:
- UserInterface/Legacy/6.0/InspectorBackendCommands.js:
- UserInterface/TimelineManager.js:
(WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
(WebInspector.TimelineManager.prototype.eventRecorded):
- Versions/Inspector-iOS-6.0.json:
- 6:26 PM Changeset in webkit [155923] by
-
- 4 edits1 copy1 delete in branches/safari-537.60-branch/Source/WebCore
Merged r155215. <rdar://problem/14949946>
- 6:26 PM Changeset in webkit [155922] by
-
- 6 edits in trunk/Tools
[Windows] Add rudimentary history to WinLauncher.
https://bugs.webkit.org/show_bug.cgi?id=121463
Reviewed by Anders Carlsson.
- WinLauncher/WinLauncher.cpp:
(updateMenuItemForHistoryItem): Added
(showLastVisitedSites): Added
(WinLauncherWebHost::didFinishLoadForFrame): Add history item once
a new page has been visited.
(dllLauncherEntryPoint): Deallocate history on exit.
(NavigateToHistory): Added
(WndProc): Add handler for history entries
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu items to hold
up to 10 history slots.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link against
Windows utility library to allow use of _bstr_t type.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Add menu items
to hold up to 10 history slots.
- WinLauncher/stdafx.h: Add <comutil.h> to precompiled headers.
- 6:21 PM Changeset in webkit [155921] by
-
- 3 edits in branches/safari-537.60-branch/Source/WebKit/win
Merged r155212. <rdar://problem/14949951>
- 6:18 PM Changeset in webkit [155920] by
-
- 5 edits in branches/safari-537.60-branch/Source/WebCore
Merged r155130. <rdar://problem/14932481>
- 6:16 PM Changeset in webkit [155919] by
-
- 2 edits in branches/safari-537.60-branch/Source/WebCore
Merged r155127. <rdar://problem/14932481>
- 6:08 PM Changeset in webkit [155918] by
-
- 13 edits3 adds in trunk
[GTK] Make symbol export filter more strict, and disable for dev/test builds
https://bugs.webkit.org/show_bug.cgi?id=120586
Reviewed by Martin Robinson.
.:
- GNUmakefile.am: only include test-related automake files when developer
mode is on.
- Source/autotools/ReadCommandLineArguments.m4: add --enable-developer-mode,
defaults to no, and to yes for debug builds.
- Source/autotools/SetupAutomake.m4: add ENABLE_DEVELOPER_MODE conditional.
- Source/autotools/symbols.filter: make the exported symbols list much shorter,
covering only the public ABI and a few symbols required by WebKit2 processes.
Source/WebKit/gtk:
- GNUmakefile.am: only use the version script when in developer mode..
Source/WebKit2:
- GNUmakefile.am: only use the version script if developer mode is disabled.
Tools:
- GNUmakefile.am: moved GtkLauncher and documentation builds to their own
makefiles, so they can be included unconditionally.
- GtkLauncher/GNUmakefile.am: added.
- Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary): always pass --enable-developer-mode
to configure, since we consider builds done through build-webkit to be development
and test builds.
- gtk/GNUmakefile.am: added.
- gtk/common.py: do not use the Scripts directory as a reference to the top path;
it's not necessary and it will not work now that the Scripts directory is not
shipped in the tarball.
- 6:07 PM Changeset in webkit [155917] by
-
- 4 edits in branches/safari-537.60-branch/Source/WebCore
Merged r154915. <rdar://problem/14932478>
- 6:04 PM Changeset in webkit [155916] by
-
- 9 edits in branches/safari-537.60-branch/Source/WebCore
Merged r154914. <rdar://problem/14932478>
- 6:01 PM Changeset in webkit [155915] by
-
- 2 edits in trunk/Source/WTF
Fix WebKit1 build after r155910
Reviewed by Anders Carlsson.
- wtf/Platform.h: Some files in WebKit include system headers before
WTF headers, causing the macro to be defined twice. #undef the macro
to support that case.
- 6:00 PM Changeset in webkit [155914] by
-
- 2 edits in branches/safari-537.60-branch/Source/WebCore
Merged r154890. <rdar://problem/14932478>
- 5:31 PM Changeset in webkit [155913] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix after 155905.
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::sendOutgoingMessage): use OwnPtr instead of PassOwnPtr.
- 4:39 PM Changeset in webkit [155912] by
-
- 2 edits in trunk/Source/WTF
Disable OS X's unprefixed debug macro
https://bugs.webkit.org/show_bug.cgi?id=121460
Reviewed by Anders Carlsson.
- wtf/Platform.h: OS X defines a series of platform macros for debugging.
Some of them are really annoying because they use common names (e.g. check()).
Disable those macros so that we are not limited in how we name methods and functions.
- 4:32 PM Changeset in webkit [155911] by
-
- 8 edits in trunk/Source
Add RunLoop::isMain and use it in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121459
Reviewed by Anders Carlsson.
Source/WebCore:
- WebCore.exp.in:
- platform/RunLoop.cpp:
(WebCore::RunLoop::isMain):
- platform/RunLoop.h:
Source/WebKit2:
- UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
(getIconSurfaceSynchronously):
(iconDataReadyForPageURLCallback):
(webkit_favicon_database_get_favicon_uri):
- UIProcess/API/mac/WKPrintingView.mm:
(-[WKPrintingView _delayedResumeAutodisplayTimerFired]):
(-[WKPrintingView _adjustPrintingMarginsForHeaderAndFooter]):
(pageDidDrawToImage):
(pageDidDrawToPDF):
(-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]):
(pageDidComputePageRects):
(-[WKPrintingView _askPageToComputePageRects]):
(prepareDataForPrintingOnSecondaryThread):
(-[WKPrintingView knowsPageRange:]):
(-[WKPrintingView _drawPreview:]):
(-[WKPrintingView drawRect:]):
(-[WKPrintingView _drawPageBorderWithSizeOnMainThread:]):
(-[WKPrintingView drawPageBorderWithSize:]):
- UIProcess/WebProcessProxy.cpp:
(WebKit::globalPageMap):
- 4:30 PM Changeset in webkit [155910] by
-
- 2 edits in trunk/Source/WTF
Disable OS X's unprefixed debug macro
https://bugs.webkit.org/show_bug.cgi?id=121460
Reviewed by Anders Carlsson.
- wtf/Platform.h: OS X defines a serie of platform macros for debugging.
Some of them are really annoying because they use common names (e.g. check()).
Disable those macros so that we are not limited how we name methods and functions.
- 3:57 PM Changeset in webkit [155909] by
-
- 3 edits2 adds in trunk
AX: ARIA tablist is disabled, but VoiceOver does not speak the tabs as dimmed
https://bugs.webkit.org/show_bug.cgi?id=121408
Reviewed by Darin Adler.
Source/WebCore:
ARIA says that aria-disabled should propagate to children nodes.
Test: accessibility/aria-disabled-propagated-to-children.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isEnabled):
LayoutTests:
- accessibility/aria-disabled-propagated-to-children-expected.txt: Added.
- accessibility/aria-disabled-propagated-to-children.html: Added.
- 3:20 PM Changeset in webkit [155908] by
-
- 167 edits in trunk/Source/WebCore
CTTE: Element::createRenderer() should take references
https://bugs.webkit.org/show_bug.cgi?id=121449
Reviewed by Anders Carlsson.
*Many file elided*
- 3:16 PM Changeset in webkit [155907] by
-
- 2 edits in trunk/Source/WebCore
iOS build fix after r155638.
Unreviewed.
- editing/Editor.cpp:
- 3:01 PM Changeset in webkit [155906] by
-
- 5 edits in trunk/Source/WebCore
Make FloatingObjects own it's FloatingObject instances
https://bugs.webkit.org/show_bug.cgi?id=121323
Reviewed by Alexandru Chiculita.
As part of decoupling FloatingObjects from RenderBlock, change
FloatingObjects to properly manage the FloatingObject instances it
contains.
No new tests, no behavior change.
- rendering/FloatingObjects.cpp:
(WebCore::FloatingObject::FloatingObject): Make the constructors
private so that FloatingObjects can only be created with an OwnPtr.
Also make a RenderBox required to create a FloatingObject.
(WebCore::FloatingObject::create): Factory method to create a vanilla
FloatingObject.
(WebCore::FloatingObject::copyToNewContainer): Factory method to copy
an existing FloatingObject in the case it is overhanging or intruding
and needs to be copied to the block that it overhangs or intrudes
into.
(WebCore::FloatingObject::unsafeClone): Rename this method so it is
more obvious that it really shouldn't be used, and to make it more
obvious that one should use the copyToNewContainer method for all
normal FloatingObject copies.
(WebCore::FloatingObjects::clear): Delete all the FloatingObjects in
the set before clearing it.
(WebCore::FloatingObjects::moveAllToFloatInfoMap): Move all of the
FloatingObjects in the set to a RendererToFloatInfoMap. This is used
in RenderBlockFlow::clearFloats to when it is readding floats after
clearing the set.
(WebCore::FloatingObjects::add): Take an OwnPtr.
(WebCore::FloatingObjects::remove): Delete the removed FloatingObject.
- rendering/FloatingObjects.h: Remove FloatingObject::setRenderer(),
since the RenderBox must be set in the constructor.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::moveAllChildrenIncludingFloatsTo): Rename clone
to unsafeClone.
(WebCore::RenderBlock::removeFloatingObjects): Don't delete anymore,
since clear does it.
(WebCore::RenderBlock::insertFloatingObject): Handle OwnPtr properly.
(WebCore::RenderBlock::removeFloatingObject): Don't delete anymore,
since remove does it.
(WebCore::RenderBlock::removeFloatingObjectsBelow): Ditto.
(WebCore::RenderBlock::addOverhangingFloats): Use copyToNewContainer
and OwnPtr.
(WebCore::RenderBlock::addIntrudingFloats): Ditto.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::clearFloats): Use exportToFloatInfoMap.
- 3:00 PM Changeset in webkit [155905] by
-
- 4 edits in trunk/Source/WebKit2
Replace more uses of PassOwnPtr with OwnPtr in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121453
Reviewed by Sam Weinig.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::SecondaryThreadPendingSyncReply::SecondaryThreadPendingSyncReply):
(CoreIPC::Connection::createSyncMessageEncoder):
(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::sendSyncReply):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::sendSyncMessageFromSecondaryThread):
(CoreIPC::Connection::waitForSyncReply):
(CoreIPC::Connection::processIncomingSyncReply):
(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::enqueueIncomingMessage):
(CoreIPC::Connection::dispatchMessage):
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::PendingSyncReply::PendingSyncReply):
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::sendOutgoingMessage):
- 2:59 PM Changeset in webkit [155904] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: svg/batik/masking/maskRegions.svg
https://bugs.webkit.org/show_bug.cgi?id=114120
Fails in the same way as many other batik tests.
- platform/mac/TestExpectations: Marking as flaky.
- 2:46 PM Changeset in webkit [155903] by
-
- 2 edits in trunk/Source/WebCore
Fix creation of embedded JS and CSS files on cmake based ports.
https://bugs.webkit.org/show_bug.cgi?id=121448
Reviewed by Joseph Pecoraro.
Just a build fix, layout tests already test this issue.
- CMakeLists.txt:
- 2:35 PM Changeset in webkit [155902] by
-
- 2 edits in trunk/LayoutTests
Marked a few tests that are too slow in debug builds, and frequently fail.
- platform/mac/TestExpectations:
- 2:30 PM Changeset in webkit [155901] by
-
- 3 edits in trunk/Source/WebKit/win
[Windows] Rendering stops when mouse is moving for some types of animations.
https://bugs.webkit.org/show_bug.cgi?id=121329
Reviewed by Anders Carlsson.
- WebView.cpp:
(WebView::WebView): Add new display flag.
(WebView::repaint): Mark view as needing a display operation.
(WebView::addToDirtyRegion): Ditto
(WebView::scrollBackingStore): Ditto
(WebView::sizeChanged): Ditto
(WebView::updateBackingStore): Ditto
(WebView::performLayeredWindowUpdate): Mark the WebView as having been
moved to screen.
(WebView::paintIntoWindow): Ditto
(WebView::WebViewWndProc): If the view needs display, and it was not done during
this message loop iteration, draw the screen.
- WebView.h:
(WebView::needsDisplay): Added
- 2:09 PM Changeset in webkit [155900] by
-
- 7 edits in trunk/Source
MessageQueue should use a Deque of OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=121450
Reviewed by Andreas Kling.
Source/WebCore:
- Modules/webdatabase/DatabaseThread.cpp:
(WebCore::SameDatabasePredicate::operator()):
- dom/default/PlatformMessagePortChannel.h:
(WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
- fileapi/FileThread.cpp:
(WebCore::SameInstancePredicate::operator()):
- workers/WorkerRunLoop.cpp:
(WebCore::ModePredicate::operator()):
Source/WTF:
- wtf/MessageQueue.h:
- 2:01 PM Changeset in webkit [155899] by
-
- 5 edits in releases/WebKitGTK/webkit-2.2
[GTK][2.2] Enable the Wayland target by default if the GTK+ Wayland dependency is available
https://bugs.webkit.org/show_bug.cgi?id=121414
Reviewed by Martin Robinson.
- Source/autotools/FindDependencies.m4: If the Wayland target is not strictly disabled, also check that the GTK+ Wayland
package (gtk+-wayland-3.0) has a recent-enough version. If the dependency could not be satisfied, either a warning or an
error is printed out, depending if the Wayland target was required or just optional.
- Source/autotools/PrintBuildConfiguration.m4: Add a new macro, AM_APPEND_TO_DESRIPTION, that's helpful when producing
a description string that can contain multiple items that should be nicely formatted when listed in that string. This is
then used when creating the description for all the enabled targets, so for instance 'x11, wayland' string would be displayed
if both the X11 and Wayland targets are enabled.
- Source/autotools/ReadCommandLineArguments.m4: The --with-target configuration options should default to 'x11,wayland' if
not given, with the Wayland target in that case not being a hard requirement (i.e. it should be disabled if the dependencies
for the Wayland target could not be found).
- Source/autotools/Versions.m4: The GTK+ Wayland dependency should be of version 3.9.14 or greater (the 3.10 release series).
- 1:39 PM Changeset in webkit [155898] by
-
- 4 edits in trunk
WTF::Deque should work with move only types
https://bugs.webkit.org/show_bug.cgi?id=121446
Reviewed by Andreas Kling.
Source/WTF:
- wtf/Deque.h:
Use std::move and std::forward where appropriate and get rid of the PassTraits include.
Tools:
- TestWebKitAPI/Tests/WTF/Deque.cpp:
(TestWebKitAPI::TEST):
Add a test.
- 1:34 PM Changeset in webkit [155897] by
-
- 2 edits in trunk/LayoutTests
svg/animations/smil-leak-*.svg tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=114280
The tests are still flaky. Ran out of ideas, so marking them as such and leaving them there.
- platform/mac/TestExpectations:
- 1:24 PM Changeset in webkit [155896] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: TypeError when updating ResourceTreeElement created in strange order
https://bugs.webkit.org/show_bug.cgi?id=121382
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-16
Reviewed by Timothy Hatcher.
Patch by Brian Burg. Fix an uncaught exception that can happen on navigations.
- UserInterface/ResourceTreeElement.js:
(WebInspector.ResourceTreeElement.prototype._updateStatus):
- 1:14 PM Changeset in webkit [155895] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed, fixing the GTK WK2 build after r155888.
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::createDrawingAreaProxy):
- UIProcess/API/gtk/PageClientImpl.h:
- 1:09 PM Changeset in webkit [155894] by
-
- 10 edits in trunk/Source/WebCore
CTTE: FrameTree::top() should return a reference.
<https://webkit.org/b/121445>
Reviewed by Anders Carlsson.
There's always a top frame in the tree.
- 1:01 PM Changeset in webkit [155893] by
-
- 1 edit14 adds in trunk/Source/WebCore
Unreviewed, fixing GObject bindings tests after r155850 by adding the *.symbols files that are now also generated.
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.symbols: Added.
- bindings/scripts/test/GObject/WebKitDOMTestCallback.symbols: Added.
- bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.symbols: Added.
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.symbols: Added.
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.symbols: Added.
- bindings/scripts/test/GObject/WebKitDOMTestException.symbols: Added.
- bindings/scripts/test/GObject/WebKitDOMTestInterface.symbols: Added.
- bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.symbols: Added.
- bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.symbols: Added.
- bindings/scripts/test/GObject/WebKitDOMTestNode.symbols: Added.
- bindings/scripts/test/GObject/WebKitDOMTestObj.symbols: Added.
- bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.symbols: Added.
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.symbols: Added.
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.symbols: Added.
- 12:56 PM Changeset in webkit [155892] by
-
- 3 edits in trunk/Source/WebCore
Fix the build following <http://trac.webkit.org/changeset/155591>
(https://bugs.webkit.org/show_bug.cgi?id=121200)
Fix the build for ports that enable PLUGIN_PROXY_FOR_VIDEO, such as iOS WebKit.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateSizes): Substitute isWidget() for isRenderWidget()
as the latter is undefined.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForVideo): Ditto.
- 12:48 PM Changeset in webkit [155891] by
-
- 14 edits1 add in trunk/Source/JavaScriptCore
MarkedBlocks shouldn't be put in Allocated state if they didn't produce a FreeList
https://bugs.webkit.org/show_bug.cgi?id=121236
Reviewed by Geoffrey Garen.
Right now, after a collection all MarkedBlocks are in the Marked block state. When lazy sweeping
happens, if a block returns an empty free list after being swept, we call didConsumeFreeList(),
which moves the block into the Allocated block state. This happens to both the block that was
just being allocated out of (i.e. m_currentBlock) as well as any blocks who are completely full.
We should distinguish between these two cases: m_currentBlock should transition to
Allocated (because we were just allocating out of it) and any subsequent block that returns an
empty free list should transition back to the Marked state. This will make the block state more
consistent with the actual state the block is in, and it will also allow us to speed up moving
all blocks the the Marked state during generational collection.
Added new RAII-style HeapIterationScope class that notifies the Heap when it is about to be
iterated and when iteration has finished. Any clients that need accurate liveness data when
iterating over the Heap now need to use a HeapIterationScope so that the state of Heap can
be properly restored after they are done iterating. No new GC-allocated objects can be created
until this object goes out of scope.
- JavaScriptCore.xcodeproj/project.pbxproj:
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions): Added HeapIterationScope for the Recompiler iteration.
- heap/Heap.cpp:
(JSC::Heap::willStartIterating): Callback used by HeapIterationScope to indicate that iteration of
the Heap is about to begin. This will cause cell liveness data to be canonicalized by calling stopAllocating.
(JSC::Heap::didFinishIterating): Same, but indicates that iteration has finished.
(JSC::Heap::globalObjectCount): Used HeapIterationScope.
(JSC::Heap::objectTypeCounts): Ditto.
(JSC::Heap::markDeadObjects): Ditto.
(JSC::Heap::zombifyDeadObjects): Ditto.
- heap/Heap.h:
- heap/HeapIterationScope.h: Added. New RAII-style object for indicating to the Heap that it's about
to be iterated or that iteration has finished.
(JSC::HeapIterationScope::HeapIterationScope):
(JSC::HeapIterationScope::~HeapIterationScope):
- heap/HeapStatistics.cpp:
(JSC::HeapStatistics::showObjectStatistics): Used new HeapIterationScope.
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper): We now treat the case where we have just finished
allocating out of the current block differently from the case where we sweep a block and it
returns an empty free list. This was the primary point of this patch.
(JSC::MarkedAllocator::allocateSlowCase): ASSERT that nobody is currently iterating the Heap
when allocating.
- heap/MarkedAllocator.h:
(JSC::MarkedAllocator::reset): All allocators are reset after every collection. We need to make
sure that the m_lastActiveBlock gets cleared, which it might not always because we don't call
takeCanonicalizedBlock on blocks in the large allocators.
(JSC::MarkedAllocator::stopAllocating): We shouldn't already have a last active block,
so ASSERT as much.
(JSC::MarkedAllocator::resumeAllocating): Do the opposite of what stopAllocating
does. So, if we don't have a m_lastActiveBlock then we don't have to worry about undoing anything
done by stopAllocating. If we do, then we call resumeAllocating on the block, which returns the FreeList
as it was prior to stopping allocation. We then set the current block to the last active block and
clear the last active block.
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::resumeAllocating): Any block resuming allocation should be in
the Marked state, so ASSERT as much. We always allocate a m_newlyAllocated Bitmap if we're
FreeListed, so if we didn't allocate one then we know we were Marked when allocation was stopped,
so just return early with an empty FreeList. If we do have a non-null m_newlyAllocated Bitmap
then we need to be swept in order to rebuild our FreeList.
- heap/MarkedBlock.h:
(JSC::MarkedBlock::didConsumeEmptyFreeList): This is called if we ever sweep a block and get back
an empty free list. Instead of transitioning to the Allocated state, we now go straight back to the
Marked state. This makes sense because we weren't actually allocated out of, so we shouldn't be in
the allocated state. Also added some ASSERTs to make sure that we're in the state that we expect: all of
our mark bits should be set and we should not have a m_newlyAllocated Bitmap.
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::forEachAllocator): Added a new functor-style iteration method so that we can
easily iterate over each allocator for, e.g., stopping and resuming allocators without
duplicating code.
(JSC::StopAllocatingFunctor::operator()): New functors for use with forEachAllocator.
(JSC::MarkedSpace::stopAllocating): Ditto.
(JSC::ResumeAllocatingFunctor::operator()): Ditto.
(JSC::MarkedSpace::resumeAllocating): Ditto.
(JSC::MarkedSpace::willStartIterating): Callback that notifies MarkedSpace that it is being iterated.
Does some ASSERTs, sets a flag, canonicalizes cell liveness data by calling stopAllocating.
(JSC::MarkedSpace::didFinishIterating): Ditto, but to signal that iteration has completed.
- heap/MarkedSpace.h:
(JSC::MarkedSpace::iterationInProgress): Returns true if a HeapIterationScope is currently active.
(JSC::MarkedSpace::forEachLiveCell): Accepts a HeapIterationScope to enforce the rule that you have to
create one prior to iterating over the Heap.
(JSC::MarkedSpace::forEachDeadCell): Ditto.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::haveABadTime): Changed to use new HeapIterationScope.
- runtime/VM.cpp:
(JSC::VM::releaseExecutableMemory): Ditto.
- 12:47 PM WebKitGTK/2.2.x edited by
- (diff)
- 12:36 PM Changeset in webkit [155890] by
-
- 5 edits in trunk/LayoutTests
svg/animations/smil-leak-*.svg tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=114280
The tests were still flaky. Changed retry timeout from 0 to 100 ms as previously
suggested by Geoff.
- svg/animations/smil-leak-dynamically-added-element-instances.svg:
- svg/animations/smil-leak-element-instances-noBaseValRef.svg:
- svg/animations/smil-leak-element-instances.svg:
- svg/animations/smil-leak-elements.svg:
- 12:06 PM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 11:58 AM Changeset in webkit [155889] by
-
- 3 edits in trunk/Source/JavaScriptCore
Inlining should work in debug mode (i.e. Executable::newCodeBlock() should call recordParse())
https://bugs.webkit.org/show_bug.cgi?id=121444
Reviewed by Mark Hahnenberg.
- dfg/DFGArgumentPosition.h: Fix a bug discovered by reenabling inlining. ArgumentPosition may point to the non-canonical VariableAccessData but users of someVariable() want the canonical one.
(JSC::DFG::ArgumentPosition::someVariable):
- runtime/Executable.cpp: Call recordParse() so that the Executable knows things about itself (like if it has captured variables). Otherwise those fields are uninitialized.
(JSC::ScriptExecutable::newCodeBlockFor):
- 11:57 AM Changeset in webkit [155888] by
-
- 17 edits in trunk/Source/WebKit2
Remove some uses of PassOwnPtr in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121443
Reviewed by Andreas Kling.
- Scripts/webkit2/messages.py:
(message_to_struct_declaration):
(generate_message_handler):
- Scripts/webkit2/messages_unittest.py:
- UIProcess/API/mac/FindIndicatorWindow.h:
- UIProcess/API/mac/FindIndicatorWindow.mm:
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::createDrawingAreaProxy):
- UIProcess/API/mac/WKView.mm:
(-[WKView WebKit::]):
(-[WKView _setFindIndicator:fadeOut:animate:]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/DrawingAreaProxyImpl.cpp:
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/PageClient.h:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
(PageOverlayClientImpl::PageOverlayClientImpl):
(WKBundlePageOverlayCreate):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::createWebEvent):
- WebProcess/Plugins/PluginView.h:
- 11:26 AM Changeset in webkit [155887] by
-
- 2 edits in trunk/Source/WebCore
Build fix following <https://trac.webkit.org/r154358>
(https://bugs.webkit.org/show_bug.cgi?id=120078)
Fix the build for ports that enable PLUGIN_PROXY_FOR_VIDEO, such as iOS WebKit.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::rendererIsNeeded): Substitute "style" for "context".
- 11:21 AM Changeset in webkit [155886] by
-
- 9 edits in trunk/Source
Make InspectorTypeBuilder generate better enums in C++.
https://bugs.webkit.org/show_bug.cgi?id=121440
Reviewed by Joseph Pecoraro.
Source/WebCore:
- inspector/CodeGeneratorInspector.py:
(fix_camel_case): Add more abbrivations.
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder): Use fix_camel_case
- inspector/ConsoleMessage.cpp:
(WebCore::messageSourceValue):
(WebCore::messageTypeValue):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::detectOrigin):
- inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::parse):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::resourceStyleSheetText):
- inspector/InspectorStyleSheet.h:
(WebCore::InspectorStyleSheet::canBind):
Source/WebInspectorUI:
- UserInterface/InspectorBackendCommands.js: Updated to make Css be CSS.
- 11:09 AM Changeset in webkit [155885] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: svg/batik/filters/feTile.svg
https://bugs.webkit.org/show_bug.cgi?id=114375
- platform/mac/TestExpectations: Marking as flaky. We already have a lot of these
batik tests marked as flaky, with similar symptoms.
- 10:56 AM Changeset in webkit [155884] by
-
- 2 edits in trunk/Source/JavaScriptCore
Aligned argument signatures of setupArgumentsWithExecState are missing on MIPS.
https://bugs.webkit.org/show_bug.cgi?id=121439
Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-09-16
Reviewed by Geoffrey Garen.
Missing implementations of setupArgumentsWithExecState added.
- dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
- 10:50 AM Changeset in webkit [155883] by
-
- 8 edits in trunk/Source/WTF
Change a couple of COMPILE_ASSERTs to static_assert
https://bugs.webkit.org/show_bug.cgi?id=121441
Reviewed by Andreas Kling.
- wtf/BloomFilter.h:
- wtf/PackedIntVector.h:
(WTF::PackedIntVector::PackedIntVector):
- wtf/StdLibExtras.h:
(WTF::bitwise_cast):
(WTF::safeCast):
(WTF::roundUpToMultipleOf):
- wtf/StringHasher.h:
(WTF::StringHasher::hashMemory):
- wtf/Vector.h:
- wtf/text/AtomicString.cpp:
- wtf/unicode/Unicode.h:
- 10:40 AM Changeset in webkit [155882] by
-
- 5 edits in trunk/LayoutTests
svg/animations/smil-leak-*.svg tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=114280
Reviewed by Geoffrey Garen.
Try garbage collection multiple times, who knows which queues the deleted nodes
could still be in. Also, removed last week's experimental change to make 10x more
nodes to see how that affects the number of leaks (it didn't).
- svg/animations/smil-leak-dynamically-added-element-instances.svg:
- svg/animations/smil-leak-element-instances-noBaseValRef.svg:
- svg/animations/smil-leak-element-instances.svg:
- svg/animations/smil-leak-elements.svg:
- 10:21 AM Changeset in webkit [155881] by
-
- 3 edits in trunk/Source/WebCore
MediaStream API: Storing the constraints in MediaStreamSource
https://bugs.webkit.org/show_bug.cgi?id=120882
based on: https://chromium.googlesource.com/chromium/blink/+/04ac7655b54ae98f55774afde3f8e92b6c6302e6
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-09-16
Reviewed by Eric Carlson.
No new tests needed.
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::succeed):
- platform/mediastream/MediaStreamSource.h:
(WebCore::MediaStreamSource::setConstraints):
(WebCore::MediaStreamSource::constraints):
- 10:21 AM Changeset in webkit [155880] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/po
Merge 155867 - Add new Galician translations
https://bugs.webkit.org/show_bug.cgi?id=105079
Patch by Fran Dieguez <frandieguez@gnome.org> on 2013-09-16
Reviewed by Gustavo Noronha Silva.
- gl.po: updated
- 10:21 AM Changeset in webkit [155879] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/po
Merge 155866 - L10n - en_GB PO file for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=100255
Patch by Chris Leonard <cjlhomeaddress@gmail.com> on 2013-09-16
Reviewed by Gustavo Noronha Silva.
- en_GB.po: updated.
- 10:20 AM Changeset in webkit [155878] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/po
Merge 155869 - Updated spanish Translation
https://bugs.webkit.org/show_bug.cgi?id=100677
Patch by Daniel Mustieles <daniel.mustieles@gmail.com> on 2013-09-16
Reviewed by Gustavo Noronha Silva.
- es.po: updated.
- 10:16 AM Changeset in webkit [155877] by
-
- 2 edits in trunk/LayoutTests
http/tests/misc/submit-post-keygen.html is extremely slow on bots, often timing out
https://bugs.webkit.org/show_bug.cgi?id=121331
Marking as possibly failing too, because when DRT detects a timeout, run-webkit-tests
thinks that it's a failure.
- platform/mac/TestExpectations:
- 10:13 AM Changeset in webkit [155876] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] Fix typo in subp implementation in LLINT.
https://bugs.webkit.org/show_bug.cgi?id=121438
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-09-16
Reviewed by Andreas Kling.
- offlineasm/sh4.rb:
- 10:12 AM Changeset in webkit [155875] by
-
- 2 edits in trunk/Source/WebCore
Rebaseline bindings tests after Sam's Document& changes.
- 10:07 AM Changeset in webkit [155874] by
-
- 5 edits in trunk/Source/WebCore
Destroying a Document's render tree shouldn't make it impossible to recreate.
<https://webkit.org/b/121437>
Reviewed by Antti Koivisto.
Rename Document::detach() to destroyRenderTree() and stop automatically
disconnecting Document from its Frame after the deforestation.
Added Document::disconnectFromFrame() and do that after every call to
destroyRenderTree() that we currently have.
This change doesn't alter any behavior on its own, but is a step towards
being able to destroy and rebuild the render tree.
- 9:35 AM Changeset in webkit [155873] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r155861 - Web Inspector: Do not try to parse incomplete HTTP requests
https://bugs.webkit.org/show_bug.cgi?id=121123
Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-09-16
Reviewed by Carlos Garcia Campos.
Update to incorporate additional review suggestions.
- UIProcess/API/gtk/tests/TestInspectorServer.cpp:
(sendIncompleteRequest):
Fix memory leaks, change test timeout from 2 seconds to 1 second,
use "0" instead of "NULL" and use g_assert_no_error when checking
for GError.
- 9:32 AM Changeset in webkit [155872] by
-
- 3 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r155642 - Web Inspector: Do not try to parse incomplete HTTP requests
https://bugs.webkit.org/show_bug.cgi?id=121123
Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-09-12
Reviewed by Darin Adler.
When working on a patch for bug #121121 I found an issue with the InspectorServer where it would try
to parse an HTTP message before receiving the full message and thus fail connecting with the
chromedevtools plugin.
What happens is that the WebSocketServerConnection receives buffers on
WebSocketServerConnection::didReceiveSocketStreamData and calls
WebSocketServerConnection::readHTTPMessage which then checks if we have a valid request by calling
HTTPRequest::parseHTTPRequestFromBuffer. If the request is valid it tries to parse the message and
clears the buffer, otherwise it continues adding data to the internal buffer until we have a valid
request.
The problem is that currently HTTPRequest::parseHTTPRequestFromBuffer considers the request as valid
before receiving the full message. To solve this we should make the method check if the request
headers end with a blank line otherwise we consider the request as invalid (see also
http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html).
- UIProcess/API/gtk/tests/TestInspectorServer.cpp:
(sendIncompleteRequest):
(beforeAll):
Add GTK specific test to check if the inspector server replies to incomplete requests.
- UIProcess/InspectorServer/HTTPRequest.cpp:
(WebKit::HTTPRequest::parseHeaders):
Do not consider request valid if headers didn't end with a blank line.
- 9:29 AM Changeset in webkit [155871] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed warning correction. Avoid uninitialized renderer.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue): Renderer can be uninitialized.
- 9:24 AM Changeset in webkit [155870] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed warning correction.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFilter): Don't use 'value' as the input argument
to the method, and the internal loop variable for the parser.
- 9:21 AM Changeset in webkit [155869] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
Updated spanish Translation
https://bugs.webkit.org/show_bug.cgi?id=100677
Patch by Daniel Mustieles <daniel.mustieles@gmail.com> on 2013-09-16
Reviewed by Gustavo Noronha Silva.
- es.po: updated.
- 9:19 AM Changeset in webkit [155868] by
-
- 2 edits in trunk/Source/WebCore
[Win] Compile errors in WebCore derived sources.
https://bugs.webkit.org/show_bug.cgi?id=121420
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-09-16
Reviewed by Brent Fulgham.
- dom/make_names.pl:
(printNamesCppFile): Added const modifier.
(printDefinitions): Use C style cast.
- 9:18 AM Changeset in webkit [155867] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
Add new Galician translations
https://bugs.webkit.org/show_bug.cgi?id=105079
Patch by Fran Dieguez <frandieguez@gnome.org> on 2013-09-16
Reviewed by Gustavo Noronha Silva.
- gl.po: updated
- 9:16 AM Changeset in webkit [155866] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
L10n - en_GB PO file for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=100255
Patch by Chris Leonard <cjlhomeaddress@gmail.com> on 2013-09-16
Reviewed by Gustavo Noronha Silva.
- en_GB.po: updated.
- 9:16 AM Changeset in webkit [155865] by
-
- 5 edits8 adds in trunk
[CSS Shapes] Winding rule polygon issues
https://bugs.webkit.org/show_bug.cgi?id=120236
Reviewed by Dirk Schulze.
Source/WebCore:
This patch corrects some of the problems with shape-inside and
self-intersecting polygons and eliminates the layout flashing behavior
that prompted the original bug report. The FloatPolygon::contains()
method now respoects the polygon's fillRule and the PolygonShape code
used to find shape-inside intervals for the top and bottom of a line
now also handles fillRule correctly.
Tests: fast/shapes/shape-inside/shape-inside-complex-polygon-001.html
fast/shapes/shape-inside/shape-inside-complex-polygon-002.html
fast/shapes/shape-inside/shape-inside-complex-polygon-003.html
fast/shapes/shape-inside/shape-inside-complex-polygon-004.html
- platform/graphics/FloatPolygon.cpp:
(WebCore::FloatPolygon::containsEvenOdd):
(WebCore::FloatPolygon::containsNonZero):
(WebCore::FloatPolygon::contains):
- platform/graphics/FloatPolygon.h:
- rendering/shapes/PolygonShape.cpp:
(WebCore::computeXIntersections):
LayoutTests:
Verify that self-intersecting rectilinear shape-inside polygons work
correctly for the evenodd and nonzero fill rules.
The shape for tests 001 and 002 contains a loop (the vertices are
numbered in the figure):
0----4----1----5
| | | |
| 3----2 |
7--------------6
When the fillRule is nonzero the entire rectangle is filled because
edges 7-0 and 3-4 wind in same direction. When fillRule is evenodd the
1-2-3-4 rectangle is not filled, leaving a U shape.
The shape for tests 003 and 004 is similar, but the adjacent vertical edges
wind in opposite directions. As a result both nonzero and evenodd fills
produce the same U shaped result.
0----2---1,5---6
| | | |
| 3----4 |
8--------------7
- fast/shapes/shape-inside/shape-inside-complex-polygon-001-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-complex-polygon-001.html: Added.
- fast/shapes/shape-inside/shape-inside-complex-polygon-002-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-complex-polygon-002.html: Added.
- fast/shapes/shape-inside/shape-inside-complex-polygon-003-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-complex-polygon-003.html: Added.
- fast/shapes/shape-inside/shape-inside-complex-polygon-004-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-complex-polygon-004.html: Added.
- 9:01 AM Changeset in webkit [155864] by
-
- 16 edits1 delete in releases/WebKitGTK/webkit-2.2
Merge r155534 - [GTK] Remove Gail dependency from build system for GTK3
https://bugs.webkit.org/show_bug.cgi?id=119673
Reviewed by Gustavo Noronha Silva.
.:
- Source/autotools/FindDependencies.m4: Don't look for GAIL at all.
- Source/autotools/Versions.m4: Removed any reference to GAIL.
- Source/cmake/FindGAIL3.cmake: Removed.
- Source/cmake/OptionsGTK.cmake: Don't look for the GAIL package.
Source/WebCore:
- GNUmakefile.am: Removed GAIL_CFLAGS.
- PlatformGTK.cmake: Removed GAIL3_INCLUDE_DIRS and GAIL3_LIBRARIES.
Source/WebKit/gtk:
- GNUmakefile.am: Removed GAIL_CFLAGS and GAIL_LIBS.
Source/WebKit2:
- GNUmakefile.am: Removed GAIL_LIBS.
Tools:
- EWSTools/ubuntu-ews-packages: Removed libgail-dev package.
- Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server): Do not load the 'gail' module anymore.
- TestWebKitAPI/GNUmakefile.am: Removed GAIL_LIBS.
- 9:00 AM WebKitGTK/2.2.x edited by
- (diff)
- 8:56 AM Changeset in webkit [155863] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore
Merge r155520 - [GTK] Get rid of Pango/Gail dependencies in accessibility for ATK
https://bugs.webkit.org/show_bug.cgi?id=114867
Reviewed by Martin Robinson.
Removed all trace of Gail and Pango specific code from the AtkText
implementation, now everything has been reimplemented.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetTextForOffset): Removed fallback code
relying in Gail/Pango, now all the related code has been
removed. Also, replaced the collection of if statements with a
switch, for better readability of the code.
- 8:55 AM WebKitGTK/2.2.x edited by
- (diff)
- 8:53 AM Changeset in webkit [155862] by
-
- 4 edits in releases/WebKitGTK/webkit-2.2/Source
Merge r155516 - [GTK] Reimplement atk_text_get_text_*_offset for LINE boundaries
https://bugs.webkit.org/show_bug.cgi?id=114872
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Re-implement these functions without using GailTextUtil nor Pango.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(lineAtPositionForAtkBoundary): New helper function to find the
line at a given position considering values of AtkTextBoundary.
(webkitAccessibleTextLineForBoundary): New function,
implementing atk_text_get_text_*_offset for LINE.
(webkitAccessibleTextGetTextForOffset): Replace usage of Gail for
LINE boundaries with webkitAccessibleTextLineForBoundary().
Source/WebKit/gtk:
Fixed wrong unit test.
- tests/testatk.c:
(testWebkitAtkGetTextAtOffsetWithPreformattedText): This test was
reporting a trailing '\n' for some reason for a <pre> block, which
is plainly wrong since, in order to return that, there should be
at least a trailing empty space after that and before the </pre>
closing tag. This is fixed now.
(testWebkitAtkGetTextAtOffsetWithWrappedLines): Uncommented tests
that were previously not passing due to a bug in GailTextUtil.
- 8:52 AM WebKitGTK/2.2.x edited by
- (diff)
- 8:49 AM Changeset in webkit [155861] by
-
- 2 edits in trunk/Source/WebKit2
Web Inspector: Do not try to parse incomplete HTTP requests
https://bugs.webkit.org/show_bug.cgi?id=121123
Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-09-16
Reviewed by Carlos Garcia Campos.
Update to incorporate additional review suggestions.
- UIProcess/API/gtk/tests/TestInspectorServer.cpp:
(sendIncompleteRequest):
Fix memory leaks, change test timeout from 2 seconds to 1 second,
use "0" instead of "NULL" and use g_assert_no_error when checking
for GError.
- 8:49 AM Changeset in webkit [155860] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore
Merge r155031 - [GTK] Reimplement atk_text_get_text_*_offset for SENTENCE boundaries
https://bugs.webkit.org/show_bug.cgi?id=114873
Reviewed by Chris Fleizach.
Re-implement these functions without using GailTextUtil nor Pango.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextWordForBoundary): Renamed from webkitAccessibleTextGetWordForBoundary,
to keep it consistent with names for new functions.
(isSentenceBoundary): Helper function to know when we are either
at the beginning or the end of a sentence.
(isWhiteSpaceBetweenSentences): It returns true if we are in the
middle of a white space between sentences. Useful for implementing
the SENTENCE_END boundary type.
(sentenceAtPositionForAtkBoundary): New helper function to find the
sentence at a given position considering values of AtkTextBoundary.
(webkitAccessibleTextSentenceForBoundary): New function,
implementing atk_text_get_text_*_offset for SENTENCE.
(webkitAccessibleTextGetTextForOffset): Replace usage of Gail for
SENTENCE boundaries with webkitAccessibleTextSentenceForBoundary().
- 8:48 AM WebKitGTK/2.2.x edited by
- (diff)
- 8:17 AM Changeset in webkit [155859] by
-
- 5 edits in trunk/Source/WebCore
AXObjectCache::m_document should be a reference.
<https://webkit.org/b/121425>
Reviewed by Antti Koivisto.
AXObjectCache is always owned by a Document so remove the uncertainty
by turning its m_document into a Document&.
- 8:17 AM Changeset in webkit [155858] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/po
Merge 155855 - [l10n] [pt_BR] Updated Brazilian Portuguese translation of WebKitGTK+ - 12/09/2013
https://bugs.webkit.org/show_bug.cgi?id=121255
Patch by Enrico Nicoletto <liverig@gmail.com> on 2013-09-16
Reviewed by Gustavo Noronha.
- pt_BR.po: updated.
- 8:16 AM Changeset in webkit [155857] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/po
Merge 155831 - [l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=121392
Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-09-15
Reviewed by Gustavo Noronha Silva.
- pl.po: updated.
- 8:16 AM Changeset in webkit [155856] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/po
Merge 154677 - [l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=119986
Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-08-27
Reviewed by Gustavo Noronha Silva.
- pl.po: updated.
- 8:16 AM WebKitGTK/2.2.x edited by
- (diff)
- 8:03 AM Changeset in webkit [155855] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[l10n] [pt_BR] Updated Brazilian Portuguese translation of WebKitGTK+ - 12/09/2013
https://bugs.webkit.org/show_bug.cgi?id=121255
Patch by Enrico Nicoletto <liverig@gmail.com> on 2013-09-16
Reviewed by Gustavo Noronha.
- pt_BR.po: updated.
- 7:00 AM Changeset in webkit [155854] by
-
- 4 edits4 moves in trunk
Unreviewed, rolling out r155851.
http://trac.webkit.org/changeset/155851
https://bugs.webkit.org/show_bug.cgi?id=121429
checkbox states should be exposed through AtkState, not
AtkValue (Requested by msanchez on #webkit).
Source/WebCore:
- accessibility/atk/WebKitAccessibleInterfaceValue.cpp:
(webkitAccessibleValueGetCurrentValue):
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(getInterfaceMaskFromObject):
LayoutTests:
- platform/mac/accessibility/mixed-checkbox-expected.txt: Renamed from LayoutTests/accessibility/mixed-checkbox-expected.txt.
- platform/mac/accessibility/mixed-checkbox.html: Renamed from LayoutTests/accessibility/mixed-checkbox.html.
- platform/mac/accessibility/native-vs-nonnative-checkboxes-expected.txt: Renamed from LayoutTests/accessibility/native-vs-nonnative-checkboxes-expected.txt.
- platform/mac/accessibility/native-vs-nonnative-checkboxes.html: Renamed from LayoutTests/accessibility/native-vs-nonnative-checkboxes.html.
- 6:54 AM Changeset in webkit [155853] by
-
- 4 edits4 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipping and rebase failing tests on Qt bots.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-16
- platform/qt-wk1/TestExpectations:
- platform/qt-wk1/fast/events/before-unload-returnValue-expected.txt: Added r155367.
- platform/qt-wk1/inspector/console/command-line-api-expected.txt:
- platform/qt/TestExpectations:
- platform/qt/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt: Added r155607.
- platform/qt/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt: Added r155607.
- 6:38 AM WebKitGTK/2.2.x edited by
- (diff)
- 6:25 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 5:51 AM Changeset in webkit [155852] by
-
- 5 edits2 adds in trunk/Source/WebKit2
[EFL][WK2] Implement pan and flick gesture.
https://bugs.webkit.org/show_bug.cgi?id=107101
Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-09-16
Reviewed by Gyuyoung Kim.
Implement pan gesture to scroll page by movement of point and stop
scrolling smoothly using ease-in-out-quad algorithm after touched
point is removed from the screen.
Use Ecore_Animator in order to process movement once per each framing
time slot instead of processing all movement.
- PlatformEfl.cmake:
- UIProcess/API/efl/EwkView.cpp:
(EwkView::scrollBy):
- UIProcess/API/efl/EwkView.h:
- UIProcess/API/efl/GestureRecognizer.cpp:
(WebKit::GestureHandler::view):
(WebKit::GestureHandler::GestureHandler):
(WebKit::GestureHandler::~GestureHandler):
(WebKit::GestureHandler::reset):
(WebKit::GestureHandler::panAnimatorCallback):
(WebKit::GestureHandler::handlePanStarted):
(WebKit::GestureHandler::handlePan):
(WebKit::GestureHandler::handlePanFinished):
(WebKit::GestureHandler::flickAnimatorCallback):
(WebKit::GestureHandler::handleFlick):
(WebKit::GestureRecognizer::noGesture):
(WebKit::GestureRecognizer::reset):
- UIProcess/efl/EasingCurves.cpp: Added.
(WebKit::easeInOutQuad):
- UIProcess/efl/EasingCurves.h: Added.
- 5:38 AM Changeset in webkit [155851] by
-
- 4 edits4 moves in trunk
[ATK] Extends atk value interface to return proper checkbox states
https://bugs.webkit.org/show_bug.cgi?id=121413
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-16
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Tests: accessibility/mixed-checkbox.html
accessibility/native-vs-nonnative-checkboxes.html
- accessibility/atk/WebKitAccessibleInterfaceValue.cpp:
(webkitAccessibleValueValueForAccessibilityObject):
(webkitAccessibleValueGetCurrentValue):
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(getInterfaceMaskFromObject):
LayoutTests:
Sharing mac tests with other ports (GTK/EFL).
- accessibility/mixed-checkbox-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/mixed-checkbox-expected.txt.
- accessibility/mixed-checkbox.html: Renamed from LayoutTests/platform/mac/accessibility/mixed-checkbox.html.
- accessibility/native-vs-nonnative-checkboxes-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/native-vs-nonnative-checkboxes-expected.txt.
- accessibility/native-vs-nonnative-checkboxes.html: Renamed from LayoutTests/platform/mac/accessibility/native-vs-nonnative-checkboxes.html.
- 5:28 AM Changeset in webkit [155850] by
-
- 4 edits5 adds in trunk/Source/WebCore
[GTK] Check DOM bindings API compatibility while building
https://bugs.webkit.org/show_bug.cgi?id=101224
Reviewed by Gustavo Noronha Silva.
A .symbols file is now generated for every DOM binding public API
object. It contains the signature of all public methods. We keep a
single file with the signature of all public methods in the source
tree. When DOM bindings are generated, a new symbols file is
created concatenating all .symbols files generated and it's
compared with the symbols file in the source tree using a script
that checks if the changes are API compatible or not. In case of
API break the build finishes showing the differences found in the
symbol files. If API compatible changes are found, the diff is
shown in stdout, suggesting to run the gobject-run-api-break-test
with the --reset-results option to update the symbols file, and
the build continues. If there aren't API changes the build
continues silently.
- GNUmakefile.am:
- bindings/gobject/GNUmakefile.am:
- bindings/gobject/WebKitDOMCustom.symbols: Added.
- bindings/gobject/WebKitDOMEventTarget.symbols: Added.
- bindings/gobject/WebKitDOMObject.symbols: Added.
- bindings/gobject/webkitdom.symbols: Added.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction):
(WriteData):
- bindings/scripts/gobject-run-api-break-test: Added.
(check_api):
- 4:44 AM Changeset in webkit [155849] by
-
- 5 edits in trunk/Source/WebCore
Devirtualize Document::detach().
<https://webkit.org/b/121418>
Reviewed by Antti Koivisto.
The only override was in PluginDocument which needs to decouple itself
from the plugin element at the start of detach.
Added PluginDocument::detachFromPluginElement() and call it from detach().
- 3:49 AM Changeset in webkit [155848] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening. Removed fail expectations for test in
the GTK & EFL ports, consistently passing after r155374.
- platform/efl/TestExpectations: Removed test.
- platform/gtk/TestExpectations: Ditto.
- 2:27 AM Changeset in webkit [155847] by
-
- 8 edits in trunk
Source/WebKit2: [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
https://bugs.webkit.org/show_bug.cgi?id=98410
Patch by Wojciech Bielawski <w.bielawski@samsung.com> on 2013-09-16
Reviewed by Darin Adler.
Add API required to implement click() method for context menu entry, used by WebkitTestRunner::EventSender.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageClickMenuItem):
(WKBundlePageCopyContextMenuItemTitle):
(WKBundlePageGetContextMenuItems):
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
Tools: [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
https://bugs.webkit.org/show_bug.cgi?id=98410
Patch by Wojciech Bielawski <w.bielawski@samsung.com> on 2013-09-16
Reviewed by Darin Adler.
Add implementation of click() method of objects returned by eventSender.contextClick().
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(MenuItemPrivateData):
(WTR::menuItemClickCallback):
(WTR::getMenuItemTitleCallback):
(WTR::staticMenuItemFinalize):
(WTR::getMenuItemClass):
(WTR::EventSendingController::contextClick):
LayoutTests: [WKTR] Add implementation of click() method of objects returned by eventSender.contextClick().
https://bugs.webkit.org/show_bug.cgi?id=98410
Patch by Wojciech Bielawski <w.bielawski@samsung.com> on 2013-09-16
Reviewed by Darin Adler.
Unskipping tests related with click() method.
- platform/efl-wk2/TestExpectations: Corrected bug number for tests: editing/pasteboard/can-read-in-copy-and-cut-events.html editing/pasteboard/can-read-in-dragstart-event.html
- platform/gtk-wk2/TestExpectations:
- 2:05 AM Changeset in webkit [155846] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] Handle subp opcode with 3 operands and bpbeq opcode in LLINT.
https://bugs.webkit.org/show_bug.cgi?id=121412
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-09-16
Reviewed by Andreas Kling.
- offlineasm/sh4.rb:
- 1:42 AM Changeset in webkit [155845] by
-
- 4 edits in trunk/Source/WebCore
CTTE: RenderCombineText always has a Text node.
<https://webkit.org/b/121411>
Reviewed by Antti Koivisto.
This renderer is never anonymous and always has a corresponding Text node.
Replaced node() with a textNode() reference getter.
- 1:00 AM Changeset in webkit [155844] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore
Merge r155778 - Missing allow-none introspection annotation for DomDocument.evaluate method
https://bugs.webkit.org/show_bug.cgi?id=118310
Reviewed by Martin Robinson.
Add (allow-none) introspection annotation to parameters that can
be NULL.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction):
- 12:59 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:48 AM Changeset in webkit [155843] by
-
- 10 edits in releases/WebKitGTK/webkit-2.2
Merge r155768 - [GTK] WebKitGTK+ is linking against libxslt in too many places
https://bugs.webkit.org/show_bug.cgi?id=121356
Reviewed by Martin Robinson.
Source/WebCore:
Don't use LIBXSLT_CFLAGS when compiling libWebCorePlatform and
libWebCoreGtk, no source files use libxslt there.
- GNUmakefile.am:
Source/WebKit/gtk:
Don't use LIBXSLT_CFLAGS when compiling libwebkitgtk, no source
files use libxslt there.
The webkit tests don't use libxslt, so we shouldn't link against
it.
- GNUmakefile.am:
Source/WebKit2:
Don't use LIBXSLT_CFLAGS when compiling libWebCoreGtk2, no source
files use libxslt there.
- GNUmakefile.am:
Tools:
TestWebCore, WebKitTestRunner and MiniBrowser don't use libxslt,
so we don't need to link against it.
- MiniBrowser/gtk/GNUmakefile.am:
- TestWebKitAPI/GNUmakefile.am:
- WebKitTestRunner/GNUmakefile.am:
- 12:14 AM Changeset in webkit [155842] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Tools
Merge r155758 - Uses gtk-doc tools even when --disable-gtk-doc passed
https://bugs.webkit.org/show_bug.cgi?id=91239
Patch by Ross Burton <ross.burton@intel.com> on 2013-09-14
Reviewed by Martin Robinson.
Don't run generate-gtkdoc on install if gtk-doc is disabled.
- GNUmakefile.am:
- 12:13 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:09 AM Changeset in webkit [155841] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Tools
Merge r155772 - [GTK] Fails to compile if the build directory is in a different partition
https://bugs.webkit.org/show_bug.cgi?id=121296
Reviewed by Martin Robinson.
Instead of using os.symlink() to install the gtk-doc templates,
use os.link() first and fall back to os.symlink() if it fails.
- gtk/gtkdoc.py:
(GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
- 12:08 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:07 AM Changeset in webkit [155840] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Tools
Merge r155757 - [GTK] Fails to compile if the build directory is in a different partition
https://bugs.webkit.org/show_bug.cgi?id=121296
Reviewed by Carlos Garcia Campos.
Use symlinks instead of hard links to support building on a
different file system.
- gtk/gtkdoc.py:
(GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
- 12:05 AM Changeset in webkit [155839] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk
Merge r155677 - download-requested arg should be WEBKIT_TYPE_DOWNLOAD not G_TYPE_OBJECT
https://bugs.webkit.org/show_bug.cgi?id=57634
Reviewed by Darin Adler.
- webkit/webkitwebview.cpp:
(webkit_web_view_class_init):
- 12:04 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:04 AM Changeset in webkit [155838] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r155533 - [WK2] [GTK] LayerTreeHostGtk: don't set m_isValid to false if glContext() returns null
https://bugs.webkit.org/show_bug.cgi?id=120892
Reviewed by Martin Robinson.
If the GL context cannot be created then m_isValid is set to false
during the initialization of LayerTreeHostGtk.
This is not really necessary since the rest of the code already
deals with that situation, so it doesn't have any effect other
than breaking the assertion in invalidate().
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::initialize):
- 12:03 AM WebKitGTK/2.2.x edited by
- (diff)
Sep 15, 2013:
- 11:59 PM Changeset in webkit [155837] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderSVGInlineText always has a Text node.
<https://webkit.org/b/121409>
Reviewed by Antti Koivisto.
This renderer is never anonymous and always has a corresponding Text node.
Replaced node() with a textNode() reference getter.
Only one null check was harmed in the making of this patch.
- 11:59 PM Changeset in webkit [155836] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2
Merge r155517 - autogen.sh: fix removal of autom4te.cache
https://bugs.webkit.org/show_bug.cgi?id=121150
Reviewed by Carlos Garcia Campos.
The removal of autom4te.cache is wrong, it uses 'rm -f' instead of
'rm -rf' and it relies on an undefined variable.
In addition to that, it should be done after running autoreconf,
which is when it's no longer needed.
- autogen.sh:
- 11:58 PM WebKitGTK/2.2.x edited by
- (diff)
- 11:58 PM Changeset in webkit [155835] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2
Merge r155515 - Unquoted $ORIGDIR in autogen.sh
https://bugs.webkit.org/show_bug.cgi?id=19512
Reviewed by Carlos Garcia Campos.
Quote all directory names. This doesn't mean that all possible
directory names are safe for building webkit, but the configure
script already runs a sanity check.
- autogen.sh:
- 11:57 PM WebKitGTK/2.2.x edited by
- (diff)
- 10:53 PM Changeset in webkit [155834] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the Windows build.
- dom/make_names.pl: The static_cast here was running into const-correctness issues, so for now change it back to a C-style cast.
- 10:40 PM Changeset in webkit [155833] by
-
- 29 edits in trunk/Source/WebCore
Adding "explicit" keyword in rendering related constructors
https://bugs.webkit.org/show_bug.cgi?id=121398
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-09-15
Reviewed by Andreas Kling.
Adding explicit in below constructor.
All files belong to Source/WebCore/rendering/ path.
- rendering/AutoTableLayout.h:
- rendering/ClipPathOperation.h:
(WebCore::ClipPathOperation::ClipPathOperation):
(WebCore::ShapeClipPathOperation::ShapeClipPathOperation):
- rendering/FixedTableLayout.h:
- rendering/FloatingObjects.h:
(WebCore::FloatingObject::FloatingObject):
- rendering/FlowThreadController.h:
- rendering/HitTestResult.h:
- rendering/ImageQualityController.h:
- rendering/InlineBox.h:
(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::InlineBoxBitfields::InlineBoxBitfields):
- rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
- rendering/InlineTextBox.h:
(WebCore::InlineTextBox::InlineTextBox):
- rendering/LayoutState.h:
- rendering/LogicalSelectionOffsetCaches.h:
(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):
- rendering/RenderBoxModelObject.h:
- rendering/RenderFlexibleBox.h:
- rendering/RenderFrameSet.h:
(WebCore::FrameEdgeInfo::FrameEdgeInfo):
- rendering/RenderGeometryMap.h:
- rendering/RenderImage.h:
- rendering/RenderImageResourceStyleImage.h:
- rendering/RenderLayerFilterInfo.h:
- rendering/RenderMultiColumnSet.h:
- rendering/RenderNamedFlowThread.h:
- rendering/RenderReplaced.h:
- rendering/RenderSearchField.h:
- rendering/RenderSelectionInfo.h:
(WebCore::RenderSelectionInfoBase::RenderSelectionInfoBase):
(WebCore::RenderBlockSelectionInfo::RenderBlockSelectionInfo):
- rendering/RenderTableSection.h:
- rendering/RenderTextControl.h:
- rendering/RenderTextControlSingleLine.h:
- rendering/TrailingFloatsRootInlineBox.h:
- 6:29 PM Changeset in webkit [155832] by
-
- 10 edits in trunk
Unreviewed make distcheck fix.
Source/JavaScriptCore:
- GNUmakefile.list.am:
Source/WebCore:
- GNUmakefile.am:
- GNUmakefile.list.am:
Source/WebKit2:
- GNUmakefile.list.am:
Source/WTF:
- GNUmakefile.list.am:
- 6:19 PM Changeset in webkit [155831] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=121392
Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-09-15
Reviewed by Gustavo Noronha Silva.
- pl.po: updated.
- 6:01 PM Changeset in webkit [155830] by
-
- 5 edits in trunk/Source/WebKit/win
Remove dependency on CoreFoundation from WebIconDatabase
https://bugs.webkit.org/show_bug.cgi?id=119387
Reviewed by Brent Fulgham.
- COMVariantSetter.h:
(COMVariant::operator&):
(COMVariant::operator->):
- WebIconDatabase.cpp:
(WebIconDatabase::iconDatabaseNotificationUserInfoURLKey):
(postDidAddIconNotification):
- WebIconDatabase.h:
- WebView.cpp:
(WebView::notifyDidAddIcon):
- 5:45 PM Changeset in webkit [155829] by
-
- 2 edits in trunk/Source/WTF
Fix build with Visual Studio 2012 after r153764.
https://bugs.webkit.org/show_bug.cgi?id=121406
Reviewed by Brent Fulgham.
- wtf/MathExtras.h:
- 5:02 PM Changeset in webkit [155828] by
-
- 2 edits in trunk/Source/WebCore
[WIN] Fix build without precompiled header after r154146.
- platform/win/WebCoreBundleWin.h:
- 2:07 PM Changeset in webkit [155827] by
-
- 4 edits in trunk/Source/WebCore
CTTE: EllipsisBox owner renderer is always a RenderBlock.
<https://webkit.org/b/121402>
Reviewed by Antti Koivisto.
Let the constructor reflect this. Also out-of-line it because reasons.
- 1:51 PM Changeset in webkit [155826] by
-
- 2 edits in trunk/Source/WTF
Unreviewed GTK gardening.
- GNUmakefile.list.am: remove FastAllocBase.h, this file disappeared
in r155251.
- 12:56 PM Changeset in webkit [155825] by
-
- 44 edits in trunk/Source/WebCore
CTTE: RenderObject's createAnonymous() and setDocumentForAnonymous() should take Document references
https://bugs.webkit.org/show_bug.cgi?id=121400
Reviewed by Andreas Kling.
The Document used for anonymous renderers is never null.
- dom/Document.cpp:
- page/FrameView.cpp:
- rendering/FlowThreadController.cpp:
- rendering/RenderBlock.cpp:
- rendering/RenderBlock.h:
- rendering/RenderFlexibleBox.cpp:
- rendering/RenderFlexibleBox.h:
- rendering/RenderFullScreen.cpp:
- rendering/RenderFullScreen.h:
- rendering/RenderImage.cpp:
- rendering/RenderInline.cpp:
- rendering/RenderInline.h:
- rendering/RenderLayer.cpp:
- rendering/RenderListMarker.cpp:
- rendering/RenderMultiColumnBlock.cpp:
- rendering/RenderMultiColumnFlowThread.cpp:
- rendering/RenderMultiColumnFlowThread.h:
- rendering/RenderMultiColumnSet.cpp:
- rendering/RenderMultiColumnSet.h:
- rendering/RenderNamedFlowThread.cpp:
- rendering/RenderNamedFlowThread.h:
- rendering/RenderObject.h:
- rendering/RenderReplica.cpp:
- rendering/RenderReplica.h:
- rendering/RenderRuby.cpp:
- rendering/RenderRubyBase.cpp:
- rendering/RenderRubyBase.h:
- rendering/RenderRubyRun.cpp:
- rendering/RenderScrollbar.cpp:
- rendering/RenderScrollbarPart.cpp:
- rendering/RenderScrollbarPart.h:
- rendering/RenderTable.cpp:
- rendering/RenderTableCell.cpp:
- rendering/RenderTableCell.h:
- rendering/RenderTableRow.cpp:
- rendering/RenderTableRow.h:
- rendering/RenderTableSection.cpp:
- rendering/RenderText.cpp:
- rendering/RenderView.cpp:
- rendering/RenderView.h:
- rendering/mathml/RenderMathMLBlock.cpp:
- rendering/mathml/RenderMathMLRow.cpp:
- rendering/mathml/RenderMathMLScripts.cpp:
- 12:48 PM Changeset in webkit [155824] by
-
- 2 edits in trunk/Tools
Make the GDB webkit.py script compatible with Python v3
https://bugs.webkit.org/show_bug.cgi?id=121395
Reviewed by Ryosuke Niwa.
GDB fails to load the printing helpers from the webkit.py script if Python v3 is used. To avoid that,
uses of xrange() in the script are replaced with range(), and the print statements are changed into
the print() function invocations.
- gdb/webkit.py:
(guess_string_length):
(ustring_to_string):
(lstring_to_string):
(WTFCStringPrinter.to_string):
(PrintPathToRootCommand.invoke):
- 12:19 PM Changeset in webkit [155823] by
-
- 6 edits in trunk/Source/WebCore
CTTE: ContentData::createRenderer() should take references
https://bugs.webkit.org/show_bug.cgi?id=121399
Reviewed by Andreas Kling.
- Convert createRenderer(Document*, RenderStyle*) to createRenderer(Document&, RenderStyle&)
- Do a drive by final-ing of ContentData derived classes.
- dom/PseudoElement.cpp:
(WebCore::PseudoElement::didAttachRenderers):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::createAnonymous):
- rendering/RenderImage.h:
- rendering/style/ContentData.cpp:
(WebCore::ImageContentData::createRenderer):
(WebCore::TextContentData::createRenderer):
(WebCore::CounterContentData::createRenderer):
(WebCore::QuoteContentData::createRenderer):
- rendering/style/ContentData.h:
- 12:10 PM Changeset in webkit [155822] by
-
- 2 edits in trunk/LayoutTests
Attempt to fix a local flakiness on Lion.
Rubber stamped by Andreas Kling.
- fast/history/history-back-while-pdf-in-pagecache.html:
- 12:00 PM Changeset in webkit [155821] by
-
- 4 edits in trunk/Source/WebCore
CTTE: RenderFrameSet is never anonymous.
<https://webkit.org/b/121396>
Reviewed by Antti Koivisto.
This renderer is never anonymous, and always has a corresponding HTMLFrameSetElement.
Replaced element() with a frameSetElement().
- 11:53 AM Changeset in webkit [155820] by
-
- 4 edits in trunk/Source/JavaScriptCore
Deoptimize deoptimization: make DFGOSRExitCompiler64.cpp more hackable
https://bugs.webkit.org/show_bug.cgi?id=121374
Reviewed by Geoffrey Garen.
This reduces the size of DFGOSRExitCompiler64.cpp by almost 50%, and makes it
super easy to add new recovery kinds. For recoveries that involve reboxing, it
allows you to keep most of the code common between the on-stack and in-reg
cases: they all get funneled through the "load from scratch buffer, convert,
and then store to stack" logic.
This opens up a bunch of possibilities. It'll make adding Int48 much easier,
and it probably will come in handy as we do various DFG stack layout changes in
support of the FTL.
- bytecode/ValueRecovery.h:
(JSC::ValueRecovery::dumpInContext):
(JSC::ValueRecovery::dump):
- dfg/DFGOSRExitCompiler.cpp:
(JSC::DFG::shortOperandsDump):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- 11:47 AM Changeset in webkit [155819] by
-
- 9 edits in trunk/Source/WebCore
CTTE: Node subclasses should take a Document by reference in their constructor (Part 10)
https://bugs.webkit.org/show_bug.cgi?id=121397
Reviewed by Andreas Kling.
Convert the bindings code to pass a Document reference for named constructors.
- bindings/js/JSImageConstructor.cpp:
(WebCore::constructImage):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
- html/HTMLAudioElement.cpp:
(WebCore::HTMLAudioElement::createForJSConstructor):
- html/HTMLAudioElement.h:
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::createForJSConstructor):
- html/HTMLImageElement.h:
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::createForJSConstructor):
- html/HTMLOptionElement.h:
- 11:25 AM Changeset in webkit [155818] by
-
- 5 edits in trunk/Source/WebCore
CTTE: Node subclasses should take a Document by reference in their constructor (Part 9)
https://bugs.webkit.org/show_bug.cgi?id=121394
Reviewed by Andreas Kling.
Remove the 'constructorTakesDocumentReference' property. It is the default now.
- dom/make_names.pl:
Always use a Document reference.
- html/HTMLTagNames.in:
- mathml/mathtags.in:
- svg/svgtags.in:
Remove the 'constructorTakesDocumentReference' property.
- 11:12 AM Changeset in webkit [155817] by
-
- 4 edits in trunk/Source/WebCore
RenderWidget doesn't need to cache a FrameView pointer.
<https://webkit.org/b/121158>
Reviewed by Antti Koivisto.
The FrameView can be found through RenderObject::view().frameView().
This way also gets you a reference, so no need for null-checking.
- 11:08 AM Changeset in webkit [155816] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r155814 - [GTK] The web inspector is not rendered when docked in WebKit2 when AC is used
https://bugs.webkit.org/show_bug.cgi?id=121381
Reviewed by Martin Robinson.
When accelerated compositing results are rendered we return early
from webkitWebViewBaseDraw and other WebView children are not
drawn. We need to chain up the draw signal handler, so that the
GtkContainer propagates the draw to all its children.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseDraw):
- 11:06 AM Changeset in webkit [155815] by
-
- 185 edits in trunk/Source/WebCore
CTTE: Node subclasses should take a Document by reference in their constructor (Part 8)
https://bugs.webkit.org/show_bug.cgi?id=121393
Reviewed by Andreas Kling.
Converts the following to take a Document reference:
- All of SVG
- 10:41 AM Changeset in webkit [155814] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] The web inspector is not rendered when docked in WebKit2 when AC is used
https://bugs.webkit.org/show_bug.cgi?id=121381
Reviewed by Martin Robinson.
When accelerated compositing results are rendered we return early
from webkitWebViewBaseDraw and other WebView children are not
drawn. We need to chain up the draw signal handler, so that the
GtkContainer propagates the draw to all its children.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseDraw):
- 10:10 AM Changeset in webkit [155813] by
-
- 16 edits in trunk/Source/WebCore
[CTTE] Node subclasses should take a Document by reference in their constructor (Part 7)
https://bugs.webkit.org/show_bug.cgi?id=121389
Reviewed by Andreas Kling.
Converts the following to take a Document reference:
- Element
- MathMLElement
- MathMLInlineContainerElement
- MathMLMathElement
- MathMLTextElement
- 7:58 AM Changeset in webkit [155812] by
-
- 2 edits in trunk/Source/WTF
[WIN] Fix build without precompiled header after r155454.
- wtf/win/GDIObject.h: Added missing windows.h include.
- 7:13 AM Changeset in webkit [155811] by
-
- 9 edits in trunk/Source/WebCore
CTTE: RenderMedia and RenderVideo are never anonymous.
<https://webkit.org/b/121388>
Reviewed by Sam Weinig.
Codify the following:
- RenderMedia always has an HTMLMediaElement.
- RenderVideo always has an HTMLVideoElement.
None of these renderers are ever anonymous, so delete element() and provide
strongly typed reference getters instead.
- 7:12 AM Changeset in webkit [155810] by
-
- 9 edits5 adds in trunk/Source/WebCore
Unreviewed, rolling out r155809.
http://trac.webkit.org/changeset/155809
https://bugs.webkit.org/show_bug.cgi?id=121388
Accidentally removed files, let's redo this.
- 7:06 AM Changeset in webkit [155809] by
-
- 9 edits5 deletes in trunk/Source/WebCore
CTTE: RenderMedia and RenderVideo are never anonymous.
<https://webkit.org/b/121388>
Reviewed by Sam Weinig.
Codify the following:
- RenderMedia always has an HTMLMediaElement.
- RenderVideo always has an HTMLVideoElement.
None of these renderers are ever anonymous, so delete element() and provide
strongly typed reference getters instead.
- 6:31 AM Changeset in webkit [155808] by
-
- 47 edits in trunk/Source/WebCore
[CTTE] Node subclasses should take a Document by reference in their constructor (Part 6)
https://bugs.webkit.org/show_bug.cgi?id=121387
Reviewed by Andreas Kling.
Converts the following to take a Document reference:
- Attr
- CDATASection
- CharacterData
- Comment
- DOMImplementation
- DocumentFragment
- DocumentType
- EntityReference
- Notation
- ProcessingInstruction
- ShadowRoot
- TemplateContentDocumentFragment
- Text
- 5:59 AM Changeset in webkit [155807] by
-
- 2 edits in trunk/Source/WebCore
Remove RenderObject::clearNode().
<https://webkit.org/b/121386>
Reviewed by Anders Carlsson.
This was used by ref-counted RenderWidgets after getting removed from their
parent renderer but kept alive by an external ref. We have no need for this
awkward state anymore, so remove clearNode().
- 5:52 AM Changeset in webkit [155806] by
-
- 21 edits in trunk/Source/WebCore
CTTE: RenderWidgets are never anonymous.
<https://webkit.org/b/121385>
Reviewed by Anders Carlsson.
Codify the following:
- RenderWidget always has an HTMLFrameOwnerElement.
- RenderEmbeddedObject always has an HTMLFrameOwnerElement.
- RenderSnapshottedPlugIn always has an HTMLPlugInImageElement.
- RenderFrame always has an HTMLFrameElement.
- RenderIFrame always has an HTMLIFrameElement.
None of these renderers are ever anonymous, so delete element() and provide
strongly typed reference getters instead.
- 5:51 AM Changeset in webkit [155805] by
-
- 2 edits in trunk/Source/WTF
Remove Ref(const T&) constructor.
<https://webkit.org/b/121384>
Reviewed by Anders Carlsson.
This constructor was added as a stopgap measure until we got better support
for move semantics in Vector.
- wtf/Ref.h:
- 5:07 AM WebKitGTK/2.2.x edited by
- (diff)
- 4:42 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:35 AM Changeset in webkit [155804] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, fix ridiculous bug in WeakPtr.
I made operator!() null check the pointer to the WeakReference. :|
Caught by plugins/destroy-on-setwindow.html on bots.
- wtf/WeakPtr.h:
(WTF::WeakPtr::operator!):
- 2:29 AM Changeset in webkit [155803] by
-
- 4 edits in trunk/Tools
[webkitpy] perf profiler attaches to WKTR after the WebProcess was launched
https://bugs.webkit.org/show_bug.cgi?id=119631
Reviewed by Ryosuke Niwa.
The perf profiler is attached to the test runner after the test runner has been launched,
but in the case of WebKitTestRunner, this is done after the WebProcess was spawned by the
UIProcess, meaning that WebProcess operations will not be profiled.
To avoid that, the perf profiler is changed to provide a wrapper command for the test runner.
This is done in the scope of already present support for wrapper scripts (such as valgrind)
that are settable through the --wrapper option. This causes the perf profiler to correctly
continue profiling the WebProcess after it was spawned.
When the profiler is launched, a wait process is launched with the profiler's pid as the
argument. This ensures we can check that the profiler exited normally. If it did not, its
output can be corrupted and can cause problems when that output is examined. The after-exit
report is avoided in that case.
- Scripts/webkitpy/common/system/profiler.py:
(Profiler.wrapper_arguments): The method returns an empty list by default.
(Perf.init): Remove unnecessary member variables.
(Perf.attach_to_pid): Launch the wait process with the profiler's pid as the argument.
(Perf.wrapper_arguments): Used instead of attaching the profiler to the profiled process' pid,
the method returns a list of arguments that should be used as a wrapper for the test runner.
The arguments specify the 'perf record' command, with the output file and the instruction to
construct the call graph given as well.
(Perf._first_ten_lines_of_profile): Prettify the output by avoiding the unnecessary trailing
whitespace in the profile lines.
(Perf.profile_after_exit): Kill the profiler process through its pid if the wait process is still
running. If it is running even after that, or if the profiler process produced a non-zero exit
code, the method reports the profiling failure and returns. Otherwise it continues on reporting
the top 10 lines of the profile and how to examine the profile further.
- Scripts/webkitpy/port/driver.py:
(Driver._command_wrapper): The method is now a member of the Driver class, returning the wrapper
as specified by the --wrapper option if given, or the profiler wrapper if the profiler is present,
or an empty list otherwise.
(Driver.cmd_line):
- Scripts/webkitpy/port/driver_unittest.py:
(DriverTest.make_port): Adjusted so mock host or options objects can be specified
for the testing-specific Port object.
(DriverTest._assert_wrapper): Pass a MockOptions object with the wrapper value to the make_port method,
as the Driver._command_wrapper now operates on the option's value directly rather than accepting it through
a parameter.
(DriverTest.test_profiler_as_wrapper): Provide a test case to check the correct profiler wrapper is used
when profiling on the Linux platform with the perf profiler.
- 1:51 AM Changeset in webkit [155802] by
-
- 16 edits in trunk/Source/WebCore
Use FINAL instead of virtualChildren trick in render tree classes
https://bugs.webkit.org/show_bug.cgi?id=121373
Reviewed by Andreas Kling.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetterStyle): Use children instead of
virtualChildren.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::splitAnonymousBoxesAroundChild): Ditto.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::moveChildTo): Ditto.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild): Ditto.
(WebCore::RenderObject::removeChild): Ditto.
(WebCore::RenderObject::handleDynamicFloatPositionChange): Ditto.
(WebCore::RenderObject::willBeDestroyed): Ditto.
(WebCore::RenderObject::removeFromRenderFlowThreadRecursive): Ditto.
- rendering/RenderBlock.h: Changed firstChild and lastChild to use
m_children directly instead of a function. Made the children function
a final virtual override. Deleted the virtualChildren override. Added
override keywords to other virtual functions.
- rendering/RenderEmbeddedObject.h: Ditto.
- rendering/RenderFrameSet.h: Ditto.
- rendering/RenderInline.h: Ditto.
- rendering/RenderMedia.h: Ditto.
- rendering/RenderTableCol.h: Ditto.
- rendering/RenderTableRow.h: Ditto.
- rendering/RenderTableSection.h: Ditto.
- rendering/svg/RenderSVGContainer.h: Ditto.
- rendering/svg/RenderSVGRoot.h: Ditto.
- rendering/RenderObject.h:
(WebCore::RenderObject::firstChild): Use children instead of virtualChildren.
(WebCore::RenderObject::lastChild): Ditto.
(WebCore::RenderObject::children): Renamed from virtualChildren.
(WebCore::RenderObject::canHaveChildren): Use children instead of virtualChildren.
- 1:50 AM Changeset in webkit [155801] by
-
- 15 edits in trunk/Source/WebCore
Shrink factory functions
https://bugs.webkit.org/show_bug.cgi?id=121378
Reviewed by Andreas Kling.
This makes the functions that builds four different types of per-element tables
all have smaller code size.
- DerivedSources.make: Tweaked how HTML and SVG wrapper factories are made a bit.
It was OK, but a little sloppy.
- dom/Document.cpp:
(WebCore::Document::createElement): Changed to call the createElement functions
in the factories. Also did some style improvement.
- dom/make_names.pl:
(printConstructorSignature): Make constructors take a Document& instead of
a Document*.
(printConstructorInterior): Updated for Document& instead of Document*.
(printFunctionTable): Renamed from printFunctionInits, because this now
creates table entries. The actual code to add each function is now done
in a loop instead.
(printNamesHeaderFile): Made the table const.
(printNamesCppFile): Made the table const.
(printDefinitions): Generate a table, table entries, and a loop that calls
createQualifiedName, rather than an "unrolled loop".
(printFactoryCppFile): Tweaked indentation. Updated to take Document& instead
of Document*. Generate a table, table entries, and a loop that builds a map,
rather than an "unrolled" loop.
(printFactoryHeaderFile): Eliminated the unused createElement member function
that was part of a dream of factory objects in a namespace registry, giving
the name createElement to the static member function so it would be less
redundant. Also made the function takes a Document& instead of Document*.
Also made the default "not created by parser", since the parser is the simpler
use case, outnumbered by the non-parser uses, at least at the moment. Also,
use nullptr instead of 0.
(printWrapperFactoryCppFile): Generate a table, table entries, and a loop
that builds a map rather than an "unrolled" loop.
- editing/htmlediting.cpp:
(WebCore::createHTMLElement): Put the null check here that used to be in
HTMLElementFactory::createElement, and call with a reference instead of a
pointer. Also don't need to pass "0, false" since "not created by the parser"
is now the default.
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::createElement): Ditto.
- html/HTMLElement.cpp:
(WebCore::populateEventNameForAttributeLocalNameMap): Changed to use an
AtomicStringImpl* as the key instead of AtomicString, since all the strings
come from the local names of tags, and so don't need to be ref'd. This saves
a bit of reference count churn when building the map and is the same pattern
used in some maps in the make_names.pl script above.
(WebCore::HTMLElement::parseAttribute): Updated for change above.
- html/HTMLObjectElement.cpp:
(WebCore::isRecognizedTagName): More const.
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::createHTMLElement): Changed to call the
HTMLElementFactory::createElement function under its new name with a reference
rather than a pointer.
- html/parser/HTMLIdentifier.cpp:
(WebCore::nameForIndex): More const.
(WebCore::HTMLIdentifier::addNames): More const.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::mapLoweredLocalNameToName): More const.
(WebCore::adjustSVGTagNameCase): Eliminated local variable so we would not have
to utter type with more const.
(WebCore::adjustAttributes): Ditto.
(WebCore::addNamesWithPrefix): More const. Also tweaked to use a bit more reference,
and a bit less pointer. Also used array instead of pointer for argument since they
are synonyms and this use is more array-like and const array is slightly easier to
understand than the double const pointer.
(WebCore::adjustForeignAttributes): Eliminated local variable so we would not have
to utter type with more const.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::copyWebVTTNodeToDOMTree): Pass a reference to
WebVTTElement::createEquivalentHTMLElement.
- html/track/WebVTTElement.cpp:
(WebCore::WebVTTElement::WebVTTElement): Take a reference instead of a pointer.
(WebCore::WebVTTElement::create): Ditto.
(WebCore::WebVTTElement::cloneElementWithoutAttributesAndChildren): Pass a
reference instead of a pointer to create.
(WebCore::WebVTTElement::createEquivalentHTMLElement): Take a reference instead
of a pointer, and update uses of HTMLElementFactory::createElement. Also made
this return null when a bad node type is passed in, which should never happen.
- html/track/WebVTTElement.h: Use Document& instead of Document*. Removed unused
and undefined create/constructor overloads.
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::constructTreeFromToken): Pass document reference rather than
pointer to WebVTTElement::create.
- 1:21 AM Changeset in webkit [155800] by
-
- 4 edits in trunk/Source/WebCore
Get rid of ref-counting on RenderArena.
<https://webkit.org/b/121379>
Reviewed by Darin Adler.
This was used to guard the arena during ref-counted RenderWidget teardown.
- 1:18 AM Changeset in webkit [155799] by
-
- 2 edits in trunk/Source/WebCore
Fix Qt build.
- css/CSSSelector.cpp: (WebCore::populatePseudoTypeByNameMap): Removed stray line that was breaking the build for any platform with !ENABLE(VIDEO_TRACK).
- 1:15 AM Changeset in webkit [155798] by
-
- 3 edits in trunk/Source/WebCore
Restore two-pass mechanism for FrameView::updateEmbeddedObjects().
<https://webkit.org/b/121380>
Reviewed by Darin Adler.
Restore the code to make a second pass over the embedded objects needing
an update in case more objects were added to the set during the first pass.
- 1:08 AM Changeset in webkit [155797] by
-
- 15 edits20 adds2 deletes in trunk
Implement the mmultiscripts tag
https://bugs.webkit.org/show_bug.cgi?id=99618
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-09-15
Reviewed by Chris Fleizach.
Source/WebCore:
Tests: mathml/invalid-scripts-crash.html
mathml/presentation/multiscripts-equivalence.html
mathml/presentation/multiscripts-noscripts.html
mathml/presentation/multiscripts-positions.html
mathml/presentation/scripts-base-alignment.html
mathml/presentation/scripts-horizontal-alignment.html
mathml/presentation/scripts-vertical-alignment.html
mathml/scripts-addChild.html
mathml/scripts-removeChild.html
This relies on the existing msub/msup/msubsup code to implement the mmultiscripts tag. This also improves dynamic addition/removal of children for these MathML elements and adds a specific style for invalid children, so that they render like an merror tag. Finally, this fixes a bad memory access in the Accessibility render object of msubsup.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isMathSubscriptSuperscript):
(WebCore::AccessibilityRenderObject::mathSuperscriptObject):
- css/mathml.css:
(mo, mrow, mfenced, mfrac, msub, msup, msubsup, mmultiscripts, mprescripts, none, munder, mover, munderover, msqrt, mroot):
(mover > :last-child, munderover > :last-child):
(msub > * + *, msup > * + *, msubsup > * + *, mmultiscripts > * + *, munder > * + *, mover > * + *, munderover > * + *):
(merror, msub > * + * + *, msup > * + * + *, msubsup > * + * + * + *, msub > mprescripts, msup > mprescripts, msubsup > mprescripts, msub > none, msup > none, msubsup > none, mmultiscripts > mprescripts ~ mprescripts, mmultiscripts > mprescripts ~ mprescripts ~ *):
- mathml/MathMLInlineContainerElement.cpp:
(WebCore::MathMLInlineContainerElement::createRenderer):
- mathml/mathtags.in:
- rendering/mathml/RenderMathMLBlock.h:
(WebCore::RenderMathMLBlock::isRenderMathMLScripts):
(WebCore::RenderMathMLBlock::isRenderMathMLScriptsWrapper):
- rendering/mathml/RenderMathMLScripts.cpp: Added.
(WebCore::isMPrescripts):
(WebCore::RenderMathMLScripts::RenderMathMLScripts):
(WebCore::RenderMathMLScripts::base):
(WebCore::RenderMathMLScripts::fixAnonymousStyleForSubSupPair):
(WebCore::RenderMathMLScripts::fixAnonymousStyles):
(WebCore::RenderMathMLScripts::addChildInternal):
(WebCore::RenderMathMLScripts::removeChildInternal):
(WebCore::RenderMathMLScripts::addChild):
(WebCore::RenderMathMLScripts::removeChild):
(WebCore::RenderMathMLScripts::styleDidChange):
(WebCore::RenderMathMLScripts::unembellishedOperator):
(WebCore::RenderMathMLScripts::layout):
(WebCore::RenderMathMLScripts::firstLineBoxBaseline):
(WebCore::RenderMathMLScriptsWrapper::createAnonymousWrapper):
(WebCore::RenderMathMLScriptsWrapper::addChildInternal):
(WebCore::RenderMathMLScriptsWrapper::addChild):
(WebCore::RenderMathMLScriptsWrapper::removeChildInternal):
(WebCore::RenderMathMLScriptsWrapper::removeChild):
- rendering/mathml/RenderMathMLScripts.h: Added.
(WebCore::RenderMathMLScriptsWrapper::RenderMathMLScriptsWrapper):
(WebCore::RenderMathMLScriptsWrapper::renderName):
(WebCore::RenderMathMLScriptsWrapper::isRenderMathMLScriptsWrapper):
(WebCore::toRenderMathMLScriptsWrapper):
(WebCore::RenderMathMLScripts::isRenderMathMLScripts):
(WebCore::RenderMathMLScripts::renderName):
(WebCore::toRenderMathMLScripts):
- rendering/mathml/RenderMathMLSubSup.cpp: Removed.
- rendering/mathml/RenderMathMLSubSup.h: Removed.
LayoutTests:
Add many tests for script msub/msup/msubsup/mmultiscripts:
- invalid markup
- equivalence between mmultiscripts without scripts and mrow
- equivalence between mmultiscripts and msub/msup/msubsup
- position of scripts in mmultiscripts
- baseline alignment of msub/msup/msubsup elements
- horizontal/vertical alignment of scripts
- adding/removing children with the DOM
- TestExpectations: Some remaining MathML pixel tests are broken by this patch.
- mathml/invalid-scripts-crash-expected.txt: Added.
- mathml/invalid-scripts-crash.html: Added.
- mathml/presentation/multiscripts-equivalence-expected.html: Added.
- mathml/presentation/multiscripts-equivalence.html: Added.
- mathml/presentation/multiscripts-noscripts-expected.html: Added.
- mathml/presentation/multiscripts-noscripts.html: Added.
- mathml/presentation/multiscripts-positions-expected.html: Added.
- mathml/presentation/multiscripts-positions.html: Added.
- mathml/presentation/scripts-base-alignment-expected.html: Added.
- mathml/presentation/scripts-base-alignment.html: Added.
- mathml/presentation/scripts-horizontal-alignment-expected.html: Added.
- mathml/presentation/scripts-horizontal-alignment.html: Added.
- mathml/presentation/scripts-vertical-alignment-expected.html: Added.
- mathml/presentation/scripts-vertical-alignment.html: Added.
- mathml/scripts-addChild-expected.html: Added.
- mathml/scripts-addChild.html: Added.
- mathml/scripts-removeChild-expected.html: Added.
- mathml/scripts-removeChild.html: Added.
- platform/mac/accessibility/mathml-multiscript-expected.txt: Reference updated.
- 12:27 AM Changeset in webkit [155796] by
-
- 13 edits1 delete in trunk/Source
Get rid of ref-counting on RenderWidget.
<https://webkit.org/b/121357>
Reviewed by Darin Adler.
Source/WebCore:
Instead of RenderView tracking RenderWidgets, have FrameView track Widgets
that are currently in the render tree.
To protect ourselves during NPAPI tomfoolery, we now let RenderWidget hand
out weak pointers through a createWeakPtr() method so call sites can monitor
the renderer for deletion without having to take shared ownership.
This works out quite nicely since instead of keeping a limping object alive
for a little longer just so we can call methods on it (to accomplish nothing),
we're forced to check right away if it's gone, and take immediate action.
De-virtualized RenderObject::destroy() since it's no longer needed for
RenderWidget to defer destruction.
- page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
Call updateWidgetPositions() on FrameView instead of RenderView.
(WebCore::FrameView::updateEmbeddedObject):
Turn null checking of embedded object's element backpointer into an
assertion. This will eventually go away completely once that renderer
can return a HTMLFrameOwnerElement&.
Use WeakPtr to check for renderer destruction following the call out
to updateWidget().
(WebCore::FrameView::updateEmbeddedObjects):
Slap a WidgetHierarchyUpdatesSuspensionScope guard on this function
to defer Widget updates until all the updateEmbeddedObject calls are
done. This avoids RenderWidget::setWidget() having to handle 'this'
disappearing from underneath.
Also use a ListHashSet with a null sentinel to avoid looping forever.
(WebCore::FrameView::performPostLayoutTasks):
Only call updateEmbeddedObjects() once since that function no longer
operates in chunks.
(WebCore::FrameView::notifyWidgetsInAllFrames):
Call notifyWidgets() on FrameView instead of RenderView.
(WebCore::FrameView::didAddWidgetToRenderTree):
(WebCore::FrameView::willRemoveWidgetFromRenderTree):
Added. These are called by RenderWidget when a Widget is being
added or removed from a RenderWidget.
(WebCore::collectWidgets):
Helper to collect raw Widget pointers into a Vector and ref them.
(WebCore::FrameView::updateWidgetPositions):
Moved here from RenderView. This function holds a ref on all the
attached Widgets and calls RenderWidget::updateWidgetPosition() on
their corresponding renderers.
(WebCore::FrameView::notifyWidgets):
Moved here from RenderView. Holds a ref on all the widgets while
calling Widget::notifyWidget() on each one.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
Call updateWidgetPositions() on FrameView instead of RenderView.
- rendering/RenderObject.h:
De-virtualized destroy().
- rendering/RenderView.cpp:
- rendering/RenderView.h:
Moved a bunch of things to FrameView. Made protected section private
since nothing inherits from RenderView.
- rendering/RenderWidget.h:
(WebCore::RenderWidget::createWeakPtr):
Added a WeakPtr factory for clients that want to monitor this object
for destruction.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::RenderWidget):
(WebCore::RenderWidget::willBeDestroyed):
(WebCore::RenderWidget::~RenderWidget):
Removed ref counting.
Removed registration with RenderView in ctor/willBeDestroyed.
(WebCore::RenderWidget::setWidgetGeometry):
Monitor the RenderWidget itself through a WeakPtr and check on it
after each step that we're still alive. In that case just bail out.
(WebCore::RenderWidget::setWidget):
Register the incoming/outgoing Widget with the FrameView.
Use a WeakPtr to check on 'this' after updateWidgetGeometry().
(WebCore::RenderWidget::updateWidgetPosition):
Use a WeakPtr to check on 'this' after updateWidgetGeometry().
- GNUmakefile.list.am:
- rendering/RenderWidgetProtector.h:
Removed.
Source/WTF:
- wtf/WeakPtr.h:
(WTF::WeakPtr::operator!):
Add operator! to WeakPtr.
Sep 14, 2013:
- 10:23 PM Changeset in webkit [155795] by
-
- 81 edits in trunk/Source/WebCore
[CTTE] Node subclasses should take a Document by reference in their constructor (Part 5)
https://bugs.webkit.org/show_bug.cgi?id=121375
Reviewed by Andreas Kling.
- dom/make_names.pl:
Add support for a top level 'constructorTakesDocumentReference' property to
force using a Document reference for the whole factory.
- html/HTMLTagNames.in:
Replace per-tag 'constructorTakesDocumentReference' with a top level declaration
now that all of the HTML tag names are supported.
Converts the following to take a Document reference:
- HTMLContentElement
- HTMLElement
- HTMLFrameElementBase
- HTMLFrameOwnerElement
- HTMLPlugInElement
- HTMLPlugInImageElement
- HTMLUnknownElement
- InsertionPoint
- StyledElement
- TextTrackCueBox
- TextTrackCueGenericBoxElement
- 7:25 PM Changeset in webkit [155794] by
-
- 8 edits in trunk
MediaStream API: Update RTCDataChannel
https://bugs.webkit.org/show_bug.cgi?id=121102
Reviewed by Sam Weinig.
Source/WebCore:
Based on https://chromium.googlesource.com/chromium/blink/+/c6975c41956acded7cf0363012d7d6b69d0c6d96,
and https://chromium.googlesource.com/chromium/blink/+/214dab0bd6385f573c918ba5ce58a5aa206ce186.
No new tests, existing tests updated.
- Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::create): Take an options Dictionary.
(WebCore::RTCDataChannel::didChangeReadyState): String -> AtomicString. Early return if the
state hasn't changed.
(WebCore::RTCDataChannel::binaryType): String -> AtomicString.
(WebCore::RTCDataChannel::setBinaryType): String -> AtomicString.
- Modules/mediastream/RTCDataChannel.h:
- Modules/mediastream/RTCDataChannel.idl:
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::createDataChannel): Take an options struct.
- platform/mediastream/RTCDataChannelHandler.h:
- platform/mediastream/RTCPeerConnectionHandler.h:
(WebCore::RTCDataChannelInit::RTCDataChannelInit): Take an options struct.
LayoutTests:
- fast/mediastream/RTCPeerConnection-datachannel-expected.txt:
- fast/mediastream/RTCPeerConnection-datachannel.html:
- 5:57 PM Changeset in webkit [155793] by
-
- 5 edits in trunk/Source/JavaScriptCore
It should be easy to add new nodes that do OSR forward rewiring in both DFG and FTL
https://bugs.webkit.org/show_bug.cgi?id=121371
Reviewed by Sam Weinig.
Forward rewiring is a tricky part of OSR that handles the following:
a: Something(...)
SetLocal(@a, locX)
b: Int32ToDouble(@a)
c: SomethingThatExits(@b)
<no further uses of @a or @b>
Note that at @c, OSR will think that locX->@a, but @a will be dead. So it must be
smart enough to find @b, which contains an equivalent value. It must do this for
any identity functions we support. Currently we support four such functions.
Currently the code for doing this is basically duplicated between the DFG and the
FTL. Also both versions of the code have some really weirdly written logic for
picking the "best" identity function to use.
We should fix this by simply having a way to ask "is this node an identity
function, and if so, then how good is it?" Then both the DFG and FTL could use
this and have no hard-wired knowledge of those identity functions.
While we're at it, this also changes some terminology because I found the use of
the word "needs" confusing. Note that this retains the somewhat confusing behavior
that we don't search all possible forward/backward uses. We only search one step
in each direction. This is because we only need to handle cases that FixupPhase
and the parser insert. All other code that tries to insert intermediate conversion
nodes should ensure to Phantom the original node. For example, the following
transformation is illegal:
Before:
x: SomethingThatExits(@a)
After:
w: Conversion(@a)
x: SomethingThatExits(@w)
The correct form of that transformation is one of these:
Correct #1:
v: DoAllChecks(@a) exit here
w: Conversion(@a)
x: Something(@w) no exit
Correct #2:
w: Conversion(@a)
x: SomethingThatExits(@w)
y: Phantom(@a)
Correct #3:
w: Conversion(@a)
x: SomethingThatExits(@w, @a)
Note that we use #3 for some heap accesses, but of course it requires that the
node you're using has an extra slot for a "dummy" use child.
Broadly speaking though, such transformations should be relegated to something
below DFG IR, like LLVM IR.
- dfg/DFGNodeType.h:
(JSC::DFG::forwardRewiringSelectionScore):
(JSC::DFG::needsOSRForwardRewiring):
- dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
- 5:50 PM Changeset in webkit [155792] by
-
- 5 edits in trunk/Source/WebCore
MediaStream API: Update RTCDataChannel to match the specification
https://bugs.webkit.org/show_bug.cgi?id=120889
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-09-14
Reviewed by Eric Carlson
Merged from https://chromium.googlesource.com/chromium/blink/+/c3862b0a83e20fc8b1f770c7e4a886a7cceb80d2
by Tommy Widenflycht.
According to WebRTC specification, RTCDataChannel must have the following new attributes:
boolean ordered
unsigned short maxRetransmitTime
unsigned short maxRetransmits
DOMString protocol
boolean negotiated
unsigned short id
and the following one was deprecated:
boolean reliable
Test updates will be landed with https://webkit.org/b/121102.
- Modules/mediastream/RTCDataChannel.cpp:
(WebCore::RTCDataChannel::ordered):
(WebCore::RTCDataChannel::maxRetransmitTime):
(WebCore::RTCDataChannel::maxRetransmits):
(WebCore::RTCDataChannel::protocol):
(WebCore::RTCDataChannel::negotiated):
(WebCore::RTCDataChannel::id):
- Modules/mediastream/RTCDataChannel.h:
- Modules/mediastream/RTCDataChannel.idl:
- platform/mediastream/RTCDataChannelHandler.h:
- 5:39 PM Changeset in webkit [155791] by
-
- 96 edits in trunk/Source/WebCore
[CTTE] Node subclasses should take a Document by reference in their constructor (Part 4)
https://bugs.webkit.org/show_bug.cgi?id=121372
Reviewed by Eric Carlson.
Converts the following to take a Document reference:
- HTMLFormControlElement
- HTMLFormControlElementWithState
- HTMLMapElement
- HTMLMarqueeElement
- HTMLMediaElement
- HTMLMenuElement
- HTMLMetaElement
- HTMLMeterElement
- HTMLOListElement
- HTMLObjectElement
- HTMLOptGroupElement
- HTMLOptionElement
- HTMLOutputElement
- HTMLParagraphElement
- HTMLParamElement
- HTMLProgressElement
- HTMLScriptElement
- HTMLSelectElement
- HTMLSourceElement
- HTMLSpanElement
- HTMLStyleElement
- HTMLSummaryElement
- HTMLTableCellElement
- HTMLTableElement
- HTMLTableRowElement
- HTMLTableSectionElement
- HTMLTemplateElement
- HTMLTextAreaElement
- HTMLTextFormControlElement
- HTMLTitleElement
- HTMLTrackElement
- HTMLUListElement
- InlineStyleSheetOwner
- LabelableElement
- All the MediaControl elements
- 5:27 PM Changeset in webkit [155790] by
-
- 7 edits in trunk/Source/WebCore
XMLViewer_js and XMLViewer_css should be minified
https://bugs.webkit.org/show_bug.cgi?id=121334
Reviewed by Timothy Hatcher.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- xml/XMLViewer.css:
- xml/XMLViewer.js:
- 5:16 PM Changeset in webkit [155789] by
-
- 3 edits in trunk/Source/WebCore
[MediaStream] remove MediaStream.label
https://bugs.webkit.org/show_bug.cgi?id=121337
Reviewed by Sam Weinig.
No new tests or modified tests, this attribute was apparently never tested.
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStream.idl:
- 2:35 PM Changeset in webkit [155788] by
-
- 2 edits in trunk/Tools
[mac] Check For Framework Include Consistency build phase checks the wrong framework
https://bugs.webkit.org/show_bug.cgi?id=121215
Reviewed by Mark Rowe.
- Scripts/check-for-webkit-framework-include-consistency: Replaced hard-coded paths to
WebKit.framework’s Headers and PrivateHeaders directories with the current target’s
public and private headers folder paths. Also tweaked the error messages’ format to make
Xcode recognize them as errors.
- 2:33 PM Changeset in webkit [155787] by
-
- 3 edits in trunk/Source/WebKit2
Remove non-Apple cruft from the installed WKBase.h
https://bugs.webkit.org/show_bug.cgi?id=121370
Reviewed by Darin Adler.
- Configurations/WebKit2.xcconfig: Set INSTALLHDRS_SCRIPT_PHASE to YES.
- WebKit2.xcodeproj/project.pbxproj: Added a script build phase that runs unifdef on
the installed WKBase.h with APPLE defined and various BUILDING_* and WTF_USE_* symbols
undefined.
- 2:33 PM Changeset in webkit [155786] by
-
- 99 edits in trunk/Source/WebCore
[CTTE] Node subclasses should take a Document by reference in their constructor (Part 3)
https://bugs.webkit.org/show_bug.cgi?id=121368
Reviewed by Darin Adler.
Converts the following to take a Document reference:
- DeleteButton
- DetailsContentElement
- DetailsMarkerControl
- DetailsSummaryElement
- HTMLBDIElement
- HTMLBRElement
- HTMLBaseElement
- HTMLBaseFontElement
- HTMLButtonElement
- HTMLCanvasElement
- HTMLDListElement
- HTMLDataListElement
- HTMLDetailsElement
- HTMLDirectoryElement
- HTMLDivElement
- HTMLEmbedElement
- HTMLFieldSetElement
- HTMLFontElement
- HTMLFormElement
- HTMLFrameElement
- HTMLFrameSetElement
- HTMLHRElement
- HTMLHeadElement
- HTMLHeadingElement
- HTMLHtmlElement
- HTMLIFrameElement
- HTMLImageElement
- HTMLInputElement
- HTMLKeygenElement
- HTMLLIElement
- HTMLLabelElement
- HTMLLegendElement
- HTMLLinkElement
- HTMLModElement
- HTMLPreElement
- HTMLQuoteElement
- HTMLTableCaptionElement
- HTMLTableColElement
- ImageDocumentElement
- KeygenSelectElement
- SummaryContentElement
- UploadButtonElement
- 2:11 PM Changeset in webkit [155785] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r155228): Call to DragData::asFragment() nullifies PassRefPtr<Range> in documentFragmentFromDragData
https://bugs.webkit.org/show_bug.cgi?id=121359
Reviewed by Darin Adler.
- page/DragController.cpp:
(WebCore::documentFragmentFromDragData): Pass the naked pointer as the PassRefPtr<Range> argument to the DragData::asFragment()
call. The naked pointer will get wrapped and protected by a new PassRefPtr. Passing the original PassRefPtr will also create
a new PassRefPtr, but will leak the reference of the original one, leaving its pointer nullified.
- 1:59 PM Changeset in webkit [155784] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed GTK build fix after r155774.
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction): Temporarily skip generation of bindings for the Console::profile() and Console::profileEnd() methods
as they're not correctly generated for the moment.
- 1:21 PM Changeset in webkit [155783] by
-
- 5 edits in trunk/Source/JavaScriptCore
Rename IntegerBranch/IntegerCompare to Int32Branch/Int32Compare.
Rubber stamped by Mark Hahnenberg.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleInt32Branch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileInt32Compare):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileInt32Compare):
- 1:15 PM Changeset in webkit [155782] by
-
- 2 edits in trunk/Source/WebCore
Shrink the nameToPseudoTypeMap function
https://bugs.webkit.org/show_bug.cgi?id=121367
Reviewed by Andreas Kling.
- css/CSSSelector.cpp:
(WebCore::populatePseudoTypeByNameMap): Replaces the old nameToPseudoTypeMap
function. Use a table instead of lots of globals and unrolled code to set up
the map.
(WebCore::CSSSelector::parsePseudoType): Updated to use the code above, and
also use a different style that's tighter.
- 1:11 PM Changeset in webkit [155781] by
-
- 2 edits in trunk/Source/WebCore
Shrink the listMarkerText function
https://bugs.webkit.org/show_bug.cgi?id=121364
Reviewed by Andreas Kling.
Changed code to use StringBuilder, which is a better fit for what we are
doing here. But mainly, inlining was out of hand, so hit that with the
NEVER_INLINE stick. Might be worth revisiting this to optimize further for
speed by making StringBuilder better at this.
- rendering/RenderListMarker.cpp:
(WebCore::toRoman): NEVER_INLINE and use StringBuilder.
(WebCore::toAlphabeticOrNumeric): Use StringBuilder.
(WebCore::toSymbolic): NEVER_INLINE and use StringBuilder.
(WebCore::toAlphabetic): Ditto.
(WebCore::toNumeric): Ditto.
(WebCore::toHebrewUnder1000): NEVER_INLINE.
(WebCore::toHebrew): NEVER_INLINE and use StringBuilder.
(WebCore::toArmenianUnder10000): NEVER_INLINE.
(WebCore::toArmenian): NEVER_INLINE and use StringBuilder.
(WebCore::toGeorgian): NEVER_INLINE and use StringBuilder.
(WebCore::toCJKIdeographic): NEVER_INLINE and use StringBuilder.
(WebCore::listMarkerText): Use StringBuilder.
- 12:51 PM Changeset in webkit [155780] by
-
- 14 edits in trunk/Source/WebCore
[CTTE] Node subclasses should take a Document by reference in their
constructor (HTMLAnchorElement, HTMLAppletElement, HTMLAreaElement, HTMLAudioElement)
https://bugs.webkit.org/show_bug.cgi?id=121365
Reviewed by Andreas Kling.
- editing/CreateLinkCommand.cpp:
(WebCore::CreateLinkCommand::doApply):
- editing/UnlinkCommand.cpp:
(WebCore::UnlinkCommand::doApply):
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::HTMLAnchorElement):
(WebCore::HTMLAnchorElement::create):
- html/HTMLAnchorElement.h:
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::HTMLAppletElement):
(WebCore::HTMLAppletElement::create):
- html/HTMLAppletElement.h:
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::HTMLAreaElement):
(WebCore::HTMLAreaElement::create):
- html/HTMLAreaElement.h:
- html/HTMLAudioElement.cpp:
(WebCore::HTMLAudioElement::HTMLAudioElement):
(WebCore::HTMLAudioElement::create):
(WebCore::HTMLAudioElement::createForJSConstructor):
- html/HTMLAudioElement.h:
- html/HTMLTagNames.in:
- html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::addLink):
- page/DragController.cpp:
(WebCore::documentFragmentFromDragData):
- 12:48 PM Changeset in webkit [155779] by
-
- 5 edits in trunk/Source/WebCore
Get INPUT_SPEECH compiling for Nix, EFL and GTK
https://bugs.webkit.org/show_bug.cgi?id=121362
r154257 was not applied completely in HTMLInputElement.cpp and there was a wrong method signature
in TextControlInnerElements.
Also adding the files needed to build INPUT_SPEECH to each build system files.
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-09-14
Reviewed by Andreas Kling.
No new tests needed.
- CMakeLists.txt:
- GNUmakefile.list.am:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
- html/shadow/TextControlInnerElements.h:
- 12:21 PM Changeset in webkit [155778] by
-
- 2 edits in trunk/Source/WebCore
Missing allow-none introspection annotation for DomDocument.evaluate method
https://bugs.webkit.org/show_bug.cgi?id=118310
Reviewed by Martin Robinson.
Add (allow-none) introspection annotation to parameters that can
be NULL.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction):
- 12:16 PM Changeset in webkit [155777] by
-
- 7 edits in trunk/Source/WebCore
[CTTE] Node subclasses should take a Document by reference in their constructor (HTMLBodyElement)
https://bugs.webkit.org/show_bug.cgi?id=121363
Reviewed by Andreas Kling.
- dom/make_names.pl:
(defaultTagPropertyHash):
(printConstructorInterior):
Add a new property, 'constructorTakesDocumentReference', to indicate that the class
has been converted to take a Document by reference. Once all classes are converted, this
will go away.
- html/HTMLTagNames.in:
Add the 'constructorTakesDocumentReference' property to the <body> tag as an initial
step.
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::HTMLBodyElement):
(WebCore::HTMLBodyElement::create):
- html/HTMLBodyElement.h:
Modify the constructor and create functions of HTMLBodyElement to take a Document reference.
- editing/markup.cpp:
(WebCore::createFragmentFromMarkup):
(WebCore::createFragmentForTransformToFragment):
- html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::createContainingTable):
Update callers of HTMLBodyElement::create() to pass a Document reference.
- 12:14 PM Changeset in webkit [155776] by
-
- 2 edits in trunk/Source/WebCore
stage
- 12:03 PM Changeset in webkit [155775] by
-
- 5 edits in trunk/Source
Add NeverDestroyed::get
https://bugs.webkit.org/show_bug.cgi?id=121358
Reviewed by Anders Carlsson.
Source/WebCore:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::parseAttribute): Use auto and the new get
function to make this code less repetitive.
Source/WTF:
- wtf/NeverDestroyed.h: Removed code to make this non-copyable, since we also
use a macro to accomplish that.
(WTF::NeverDestroyed::get): Added. Useful in conjuction with auto to avoid
having to repeat the type when we want to put one of these into a reference.
- 11:54 AM WebKitGTK/2.2.x edited by
- (diff)
- 11:52 AM WebKitGTK/2.2.x edited by
- (diff)
- 11:29 AM Changeset in webkit [155774] by
-
- 11 edits1 delete in trunk/Source/WebCore
There is no need for any custom bindings for Console
https://bugs.webkit.org/show_bug.cgi?id=121338
Reviewed by Timothy Hatcher.
- GNUmakefile.list.am:
- Target.pri:
- UseJSC.cmake:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
Remove JSConsoleCustom.cpp from project files.
- bindings/js/JSConsoleCustom.cpp:
Removed.
- page/Console.cpp:
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
- page/Console.h:
Swap the order of the arguments to appease the bindings generator.
- page/Console.idl:
Add the [CallWith=ScriptState] attribute to pass the ExecState
and [TreatNullAs=NullString, TreatUndefinedAs=NullString] to get
the right stringification.
- 11:09 AM WebKitGTK/2.0.x edited by
- (diff)
- 11:07 AM Changeset in webkit [155773] by
-
- 2 edits in trunk/Source/WebKit2
Build fix after r155770.
- UIProcess/API/mac/WKViewPrivate.h: Added WKBase.h import.
- 11:03 AM Changeset in webkit [155772] by
-
- 2 edits in trunk/Tools
[GTK] Fails to compile if the build directory is in a different partition
https://bugs.webkit.org/show_bug.cgi?id=121296
Reviewed by Martin Robinson.
Instead of using os.symlink() to install the gtk-doc templates,
use os.link() first and fall back to os.symlink() if it fails.
- gtk/gtkdoc.py:
(GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
- 10:26 AM Changeset in webkit [155771] by
-
- 8 edits in trunk/Source/WebCore
AnimationBase::m_animation is never null
https://bugs.webkit.org/show_bug.cgi?id=121360
Reviewed by Darin Adler.
Enforce this by using references instead of pointers.
- page/animation/AnimationBase.cpp:
- page/animation/AnimationBase.h:
- page/animation/CompositeAnimation.cpp:
- page/animation/ImplicitAnimation.cpp:
- page/animation/ImplicitAnimation.h:
- page/animation/KeyframeAnimation.cpp:
- page/animation/KeyframeAnimation.h:
- 10:06 AM Changeset in webkit [155770] by
-
- 23 edits3 copies in trunk/Source/WebKit2
[mac] Public header WKBase.h imports a private header, WKBaseMac.h
https://bugs.webkit.org/show_bug.cgi?id=121216
Reviewed by Darin Adler.
- Shared/API/c/WKBase.h: Moved definitions of enums and WK_EXPORT and WK_INLINE macros
out of this files.
- Shared/API/c/WKDeclarationSpecifiers.h: Copied from Source/WebKit2/Shared/API/c/WKBase.h.
Contains definitions of WK_EXPORT and WK_INLINE.
- Shared/API/c/WKSharedAPICast.h: Added #includes.
- Shared/API/c/WKUserContentInjectedFrames.h: Copied from Source/WebKit2/Shared/API/c/WKBase.h.
Contains enum definition.
- Shared/API/c/WKUserScriptInjectionTime.h: Copied from Source/WebKit2/Shared/API/c/WKBase.h.
Contains enum definition.
- UIProcess/API/C/WKPageGroup.h: Added #includes.
- UIProcess/API/mac/WKBrowsingContextController.h: Removed WKBase.h import from this public
header, replacing it with WKDeclarationSpecifiers.h import.
- UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Added WKBase.h import.
- UIProcess/API/mac/WKBrowsingContextGroup.h: Removed WKBase.h import from this public
header, added necessary public imports.
- UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Added WKBase.h import.
- UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Removed WKBase.h import from public
header.
- UIProcess/API/mac/WKConnection.h: Ditto. Added WKDeclarationSpecifiers.h import.
- UIProcess/API/mac/WKConnectionInternal.h: Added WKBase.h import.
- UIProcess/API/mac/WKProcessGroup.h: Removed WKBase.h import from public header, added
WKDeclarationSpecifiers.h import.
- UIProcess/API/mac/WKProcessGroupPrivate.h: Added WKBase.h import.
- UIProcess/API/mac/WKView.h: Removed WKBase.h import from public header, added
WKDeclarationSpecifiers.h import.
- WebKit2.xcodeproj/project.pbxproj: Added new public header files, made WKBase.h private.
- WebProcess/InjectedBundle/API/mac/WKDOMNode.h: Removed WKBase.h import from public header,
added WKDeclarationSpecifiers.h import.
- WebProcess/InjectedBundle/API/mac/WKDOMNodePrivate.h: Added WKBase.h import.
- WebProcess/InjectedBundle/API/mac/WKDOMRange.h: Removed WKBase.h import from public
header, added WKDeclarationSpecifiers.h import.
- WebProcess/InjectedBundle/API/mac/WKDOMRangePrivate.h: Added WKBase.h import.
- WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h: Removed WKBase.h import from public
header, added WKDeclarationSpecifiers.h import.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h: Ditto.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerInternal.h:
Added WKBase.h import.
- 9:19 AM Changeset in webkit [155769] by
-
- 3 edits in trunk/Source/WebCore
Shrink the function that builds the event listener attribute name map
https://bugs.webkit.org/show_bug.cgi?id=121354
Reviewed by Andreas Kling.
- html/HTMLElement.cpp:
(WebCore::populateEventNameForAttributeLocalNameMap): Added. Uses a
table to populate the map.
(WebCore::eventNameForAttributeLocalNameMap): Added. Uses NeverDestroyed
to allocate a map, but does not initialize it.
(WebCore::HTMLElement::parseAttribute): Put code to use map in here.
- html/HTMLElement.h: Removed eventNameForAttributeName, no longer
a member function.
- 9:12 AM Changeset in webkit [155768] by
-
- 10 edits in trunk
[GTK] WebKitGTK+ is linking against libxslt in too many places
https://bugs.webkit.org/show_bug.cgi?id=121356
Reviewed by Martin Robinson.
Source/WebCore:
Don't use LIBXSLT_CFLAGS when compiling libWebCorePlatform and
libWebCoreGtk, no source files use libxslt there.
- GNUmakefile.am:
Source/WebKit/gtk:
Don't use LIBXSLT_CFLAGS when compiling libwebkitgtk, no source
files use libxslt there.
The webkit tests don't use libxslt, so we shouldn't link against
it.
- GNUmakefile.am:
Source/WebKit2:
Don't use LIBXSLT_CFLAGS when compiling libWebCoreGtk2, no source
files use libxslt there.
- GNUmakefile.am:
Tools:
TestWebCore, WebKitTestRunner and MiniBrowser don't use libxslt,
so we don't need to link against it.
- MiniBrowser/gtk/GNUmakefile.am:
- TestWebKitAPI/GNUmakefile.am:
- WebKitTestRunner/GNUmakefile.am:
- 3:22 AM Changeset in webkit [155767] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining after r155324.
- platform/gtk/fast/forms/placeholder-position-expected.png:
- platform/gtk/fast/forms/placeholder-position-expected.txt:
- 3:20 AM Changeset in webkit [155766] by
-
- 6 edits in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining after r155408.
- platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/gtk/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- 3:11 AM Changeset in webkit [155765] by
-
- 19 edits in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining after r155253.
- platform/gtk/editing/pasteboard/4989774-expected.txt:
- platform/gtk/editing/pasteboard/paste-match-style-001-expected.txt:
- platform/gtk/editing/selection/caret-ltr-2-expected.txt:
- platform/gtk/editing/selection/caret-ltr-2-left-expected.txt:
- platform/gtk/editing/selection/caret-ltr-expected.txt:
- platform/gtk/editing/selection/caret-ltr-right-expected.txt:
- platform/gtk/editing/selection/caret-rtl-2-expected.txt:
- platform/gtk/editing/selection/caret-rtl-2-left-expected.txt:
- platform/gtk/editing/selection/caret-rtl-expected.txt:
- platform/gtk/editing/selection/caret-rtl-right-expected.txt:
- platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
- platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
- platform/gtk/editing/style/style-boundary-005-expected.txt:
- platform/gtk/fast/forms/formmove3-expected.txt:
- platform/gtk/fast/forms/input-align-image-expected.txt:
- platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/gtk/fast/invalid/003-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug647-expected.txt:
- 2:47 AM Changeset in webkit [155764] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Skip additional inspector tests that are failing after switching to the new Web Inspector.
- platform/gtk-wk1/TestExpectations:
- platform/gtk/TestExpectations:
- 2:28 AM Changeset in webkit [155763] by
-
- 11 edits1 copy5 adds in trunk
Web Inspector: InjectedScriptSource_js and InjectedScriptCanvasModuleSource_js should be minified
https://bugs.webkit.org/show_bug.cgi?id=121183
Reviewed by Timothy Hatcher.
Source/WebCore:
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
Minify files at build time before running xxd.pl.
- WebCore.xcodeproj/project.pbxproj:
- inspector/InjectedScriptCanvasModuleSource.js:
- inspector/InjectedScriptSource.js:
Strip trailing whitespace (touching the files so the derived sources are regenerated).
- inspector/InspectorOverlayPage.css: Added.
- inspector/InspectorOverlayPage.html:
- inspector/InspectorOverlayPage.js: Copied from Source/WebCore/inspector/InspectorOverlayPage.html.
Move JS and CSS to external files. They are inlined and minified at build time.
- inspector/Scripts/cssmin.py: Added.
- inspector/Scripts/jsmin.py: Added.
Copied from WebInspectorUI/Scripts.
- inspector/Scripts/inline-and-minify-stylesheets-and-scripts.py: Added.
Add a script that can inline stylesheets and scripts. For minifying InspectorOverlayPage.html.
LayoutTests:
Now that the file is minified, a line number changed.
- platform/mac/inspector/console/command-line-api-expected.txt:
- 2:26 AM Changeset in webkit [155762] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fixing debug GTK builds after r155709.
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::write): Assert that the PasteboardURL's URL is not empty.
- 2:15 AM Changeset in webkit [155761] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderDetailsMarker is never anonymous.
<https://webkit.org/b/121355>
Reviewed by Darin Adler.
This renderer is never anonymous, and always has a corresponding DetailsMarkerControl.
Couldn't resist cleaning up the class a little bit, adding OVERRIDE and making
toRenderDetailsMarker() into a reference version.
- 2:13 AM Changeset in webkit [155760] by
-
- 4 edits in trunk/Source/WebCore
CTTE: RenderRubyAs{Block,Inline} are never anonymous.
<https://webkit.org/b/121353>
Reviewed by Darin Adler.
Replace element() with existingElement() and spam class with OVERRIDE.
Removed bogus removeLeftoverAnonymousBlock() override in RenderRubyAsInline
since it didn't override anything from a parent class.
- 2:11 AM Changeset in webkit [155759] by
-
- 4 edits in trunk/Source/WebCore
CTTE: RenderRubyText is never anonymous.
<https://webkit.org/b/121352>
Reviewed by Darin Adler.
Replace element() with existingElement() and spam class with OVERRIDE.
- 1:38 AM Changeset in webkit [155758] by
-
- 2 edits in trunk/Tools
Uses gtk-doc tools even when --disable-gtk-doc passed
https://bugs.webkit.org/show_bug.cgi?id=91239
Patch by Ross Burton <ross.burton@intel.com> on 2013-09-14
Reviewed by Martin Robinson.
Don't run generate-gtkdoc on install if gtk-doc is disabled.
- GNUmakefile.am:
- 1:36 AM Changeset in webkit [155757] by
-
- 2 edits in trunk/Tools
[GTK] Fails to compile if the build directory is in a different partition
https://bugs.webkit.org/show_bug.cgi?id=121296
Reviewed by Carlos Garcia Campos.
Use symlinks instead of hard links to support building on a
different file system.
- gtk/gtkdoc.py:
(GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
- 12:46 AM Changeset in webkit [155756] by
-
- 8 edits in trunk/Source/WebCore
CTTE: RenderSVGBlock renderers are never anonymous.
<https://webkit.org/b/121351>
Reviewed by Antti Koivisto.
RenderSVGBlock inherits from RenderBlockFlow, so needs separate treatment
from RenderSVGModelObject.
But like RSMO, these renderers are never anonymous, so add strongly typed
reference getters and do away with some magical type casts.
- 12:28 AM Changeset in webkit [155755] by
-
- 34 edits in trunk/Source/WebCore
CTTE: RenderSVGModelObject renderers are never anonymous.
<https://webkit.org/b/121350>
Reviewed by Darin Adler.
Flip the switch, turning RenderSVGModelObject::element() into a reference.
Sep 13, 2013:
- 11:45 PM Changeset in webkit [155754] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderSVGResourceClipper always has an SVGClipPathElement.
<https://webkit.org/b/121349>
Reviewed by Darin Adler.
This renderer is never anonymous. Tighten things up with a clipPathElement()
reference getter. Removed some unnecessary null checks and type casts.
- 11:37 PM Changeset in webkit [155753] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderSVGResourceFilter always has an SVGFilterElement.
<https://webkit.org/b/121348>
Reviewed by Darin Adler.
This renderer is never anonymous. Tighten things up with a filterElement()
reference getter. Removed some unnecessary null checks and type casts.
- 11:36 PM Changeset in webkit [155752] by
-
- 17 edits in trunk
Use a better name than m_invertibleCTM
https://bugs.webkit.org/show_bug.cgi?id=121341
Reviewed by Andreas Kling.
Source/WebCore:
Rename isTransformInvertible to hasInvertibleTransform, and
m_invertibleCTM to m_hasInvertibleTransform.
- html/canvas/CanvasPathMethods.cpp:
(WebCore::CanvasPathMethods::moveTo):
(WebCore::CanvasPathMethods::lineTo):
(WebCore::CanvasPathMethods::quadraticCurveTo):
(WebCore::CanvasPathMethods::bezierCurveTo):
(WebCore::CanvasPathMethods::arcTo):
(WebCore::CanvasPathMethods::arc):
(WebCore::CanvasPathMethods::rect):
Updated for name change. Not really sure the name is good here,
because DOMPath doesn't have a transform at all; should switch
to a better name some day.
- html/canvas/CanvasPathMethods.h: Renamed, added a new constructor,
and made the virtual function private.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::State::operator=):
(WebCore::CanvasRenderingContext2D::scale):
(WebCore::CanvasRenderingContext2D::rotate):
(WebCore::CanvasRenderingContext2D::translate):
(WebCore::CanvasRenderingContext2D::transform):
(WebCore::CanvasRenderingContext2D::setTransform):
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::stroke):
(WebCore::CanvasRenderingContext2D::clip):
(WebCore::CanvasRenderingContext2D::isPointInPath):
(WebCore::CanvasRenderingContext2D::isPointInStroke):
(WebCore::CanvasRenderingContext2D::clearRect):
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::strokeRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::didDraw):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
Updated for name change.
- html/canvas/CanvasRenderingContext2D.h: Updated for name change.
Also got rid of unneeded conditional around forward class declaration.
- html/canvas/DOMPath.h: Moved SVG-specific include into a
separate paragraph. Removed unneeded invocation of WTF_MAKE_NONCOPYABLE,
which is already true since we inherit from RefCounted. Changed create
function argument to be a const*. Eliminated extra constructors that were
unneeded. Made the path-parsing create function SVG-only, rather than
compiling a useless empty one when compiling without SVG.
Tools:
- Scripts/do-webcore-rename: Updated to do this replace as we do.
- 11:35 PM Changeset in webkit [155751] by
-
- 10 edits in trunk/Source/WebCore
CTTE: Tighter element types for RenderSVGResourceGradient and subclasses.
<https://webkit.org/b/121346>
Reviewed by Darin Adler
Codify the following:
- RenderSVGResourceGradient always has an SVGGradientElement.
- RenderSVGResourceLinearGradient always has an SVGLinearGradientElement.
- RenderSVGResourceRadialGradient always has an SVGRadialGradientElement.
None of these renderers are ever anonymous, so delete element() and provide
strongly typed reference getters instead.
Also made RenderSVGResourceGradient constructor protected since it should
never be instantiated directly.
- 11:31 PM Changeset in webkit [155750] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderSVGResourceMarker always has an SVGMarkerElement.
<https://webkit.org/b/121345>
Reviewed by Brent Fulgham.
This renderer is never anonymous. Tighten things up with a maskElement()
reference getter. Removed some unnecessary type casts and assertions.
- 11:29 PM Changeset in webkit [155749] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderSVGResourceMasker always has an SVGMaskElement.
<https://webkit.org/b/121344>
Reviewed by Brent Fulgham.
This renderer is never anonymous. Tighten things up with a maskElement()
reference getter. Removed some unnecessary null checks and assertions.
- 11:22 PM Changeset in webkit [155748] by
-
- 4 edits in trunk
Pick the correct overload when a const reference is passed to appendSlowCase.
https://bugs.webkit.org/show_bug.cgi?id=121326
Reviewed by Darin Adler.
Source/WTF:
- wtf/Vector.h:
(WTF::Vector::appendSlowCase):
Make sure that the pointer to the element isn't const so we'll pick the right expandCapacity overload.
Tools:
- TestWebKitAPI/Tests/WTF/Vector.cpp:
(TestWebKitAPI::TEST):
- 10:45 PM Changeset in webkit [155747] by
-
- 5 edits in trunk
[Windows] Enable Page Visibility API
https://bugs.webkit.org/show_bug.cgi?id=121340
Reviewed by Anders Carlsson.
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.props: Activate feature.
- win/tools/vsprops/FeatureDefinesCairo.props: Ditto.
LayoutTests:
- platform/win/TestExpectations: Enable some Page Visibility tests on Windows.
- 10:02 PM Changeset in webkit [155746] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r155719?): http/tests/inspector/network/network-size-chunked.html and
http/tests/inspector/network/network-size-sync.html fail on bots
https://bugs.webkit.org/show_bug.cgi?id=121343
- platform/mac/TestExpectations: Marking these as failing.
- 9:54 PM Changeset in webkit [155745] by
-
- 5 edits in trunk/Source/JavaScriptCore
Rename SpeculativeJIT::integerResult() to int32Result().
Rubber stamped by Mark Hahnenberg.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compileDoubleAsInt32):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileArithNegate):
(JSC::DFG::SpeculativeJIT::compileArithIMul):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compileArithDiv):
(JSC::DFG::SpeculativeJIT::compileArithMod):
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::int32Result):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 9:46 PM Changeset in webkit [155744] by
-
- 12 edits1 add in trunk/Source/WebCore
Unreviewed, rolling out r155738.
http://trac.webkit.org/changeset/155738
https://bugs.webkit.org/show_bug.cgi?id=121342
Broke many tests (Requested by ap on #webkit).
- GNUmakefile.list.am:
- Target.pri:
- UseJSC.cmake:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSConsoleCustom.cpp: Added.
(WebCore::JSConsole::profile):
(WebCore::JSConsole::profileEnd):
- bindings/js/ScriptState.h:
- page/Console.cpp:
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
- page/Console.h:
- page/Console.idl:
- 8:58 PM Changeset in webkit [155743] by
-
- 2 edits in trunk/Source/WebCore
CSSPropertyAnimation::ensurePropertyMap() is large
https://bugs.webkit.org/show_bug.cgi?id=121199
Reviewed by Darin Adler.
The bug was caused by repeated calls to Vector::append. Avoid it by storing pointers in a local array
and then adding them as we traverse them through to fill m_propertyToIdMap. Also reserve the full
initial capacity at once to avoid repeated calls to FastMalloc and FastFree.
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::instance):
(WebCore::CSSPropertyAnimationWrapperMap::wrapperForProperty):
(WebCore::CSSPropertyAnimationWrapperMap::wrapperForIndex):
(WebCore::CSSPropertyAnimationWrapperMap::indexFromPropertyID):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Renamed from ensurePropertyMap.
Also merged addShorthandProperties into it since they have to access local variables of the other.
- 8:51 PM Changeset in webkit [155742] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix for EFL port.
- editing/efl/EditorEfl.cpp:
- platform/efl/PasteboardEfl.cpp:
(WebCore::Pasteboard::read):
(WebCore::Pasteboard::write):
- 8:24 PM Changeset in webkit [155741] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix attempt for WK2 build.
- WebProcess/Plugins/PluginView.cpp: Changed ScriptState to ExecState.
(WebKit::PluginView::performJavaScriptURLRequest):
- 7:01 PM Changeset in webkit [155740] by
-
- 10 edits in trunk/Source/WebCore
Fix a few lingering ScriptStates.
Reviewed by Andy Estes.
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::update):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
- bindings/cpp/WebNativeNodeFilterCondition.cpp:
(WebNativeNodeFilterCondition::acceptNode):
- bindings/cpp/WebNativeNodeFilterCondition.h:
- dom/CustomElementConstructor.cpp:
(WebCore::CustomElementConstructor::create):
- dom/CustomElementConstructor.h:
- dom/CustomElementRegistry.cpp:
(WebCore::CustomElementRegistry::registerElement):
- dom/CustomElementRegistry.h:
- plugins/PluginView.cpp:
(WebCore::PluginView::performRequest):
- 6:57 PM Changeset in webkit [155739] by
-
- 10 edits in trunk
Rename confusingly named "runtimeObject" functions
https://bugs.webkit.org/show_bug.cgi?id=121339
Source/WebCore:
Also CTTE: HTMLElement.
Reviewed by Sam Weinig.
- bindings/js/JSHTMLAppletElementCustom.cpp:
(WebCore::JSHTMLAppletElement::putDelegate): Renamed.
(WebCore::JSHTMLAppletElement::getCallData): Renamed.
- bindings/js/JSHTMLEmbedElementCustom.cpp:
(WebCore::JSHTMLEmbedElement::putDelegate): Renamed.
(WebCore::JSHTMLEmbedElement::getCallData): Renamed.
- bindings/js/JSHTMLObjectElementCustom.cpp:
(WebCore::JSHTMLObjectElement::putDelegate): Renamed.
(WebCore::JSHTMLObjectElement::getCallData): Renamed.
- bindings/js/JSPluginElementFunctions.cpp:
(WebCore::isPluginElement): Changed to take HTMLElement&.
(WebCore::pluginInstance): Ditto.
(WebCore::pluginScriptObjectFromPluginViewBase): Updated for name and type change.
(WebCore::pluginScriptObject): Ditto.
(WebCore::pluginElementPropertyGetter): Ditto.
(WebCore::pluginElementCustomGetOwnPropertySlot): Ditto.
(WebCore::pluginElementCustomPut): Ditto.
(WebCore::pluginElementGetCallData): Ditto.
- bindings/js/JSPluginElementFunctions.h: Updated names and types.
- bindings/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:JSC::originRootObject:rootObject:]):
Updated for type change.
- bridge/runtime_method.cpp:
(JSC::callRuntimeMethod): Ditto.
Tools:
Reviewed by Sam Weinig.
- Scripts/do-webcore-rename: Updated to do this replace as usual.
- 6:50 PM Changeset in webkit [155738] by
-
- 12 edits1 delete in trunk/Source/WebCore
There is no need for any custom bindings for Console
https://bugs.webkit.org/show_bug.cgi?id=121338
Reviewed by Joseph Pecoraro.
- GNUmakefile.list.am:
- Target.pri:
- UseJSC.cmake:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
Remove JSConsoleCustom.cpp from project files.
- bindings/js/JSConsoleCustom.cpp:
Removed.
- page/Console.cpp:
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
- page/Console.h:
Swap the order of the arguments to appease the bindings generator.
- page/Console.idl:
Add the [CallWith=ScriptState] attribute to pass the ExecState
and [TreatNullAs=NullString, TreatUndefinedAs=NullString] to get
the right stringification.
- 6:37 PM Changeset in webkit [155737] by
-
- 2 edits in trunk/Source/WebCore
Part 2 of Replace ScriptState with JSC::ExecState
https://bugs.webkit.org/show_bug.cgi?id=121336
- dom/Document.h:
There is no WebCore::JSC namespace!
- 6:30 PM Changeset in webkit [155736] by
-
- 83 edits in trunk/Source/WebCore
Replace ScriptState with JSC::ExecState
https://bugs.webkit.org/show_bug.cgi?id=121336
Reviewed by Darin Adler.
- Modules/indexeddb/IDBCursor.h:
- Modules/indexeddb/IDBObjectStore.h:
- bindings/js/JSInjectedScriptHostCustom.cpp:
- bindings/js/JSInjectedScriptManager.cpp:
- bindings/js/JSNodeCustom.cpp:
- bindings/js/JSNodeFilterCondition.h:
- bindings/js/ScriptController.cpp:
- bindings/js/ScriptDebugServer.cpp:
- bindings/js/ScriptDebugServer.h:
- bindings/js/ScriptEventListener.cpp:
- bindings/js/ScriptEventListener.h:
- bindings/js/ScriptFunctionCall.cpp:
- bindings/js/ScriptFunctionCall.h:
- bindings/js/ScriptObject.cpp:
- bindings/js/ScriptObject.h:
- bindings/js/ScriptProfiler.cpp:
- bindings/js/ScriptProfiler.h:
- bindings/js/ScriptState.cpp:
- bindings/js/ScriptState.h:
- bindings/js/ScriptValue.cpp:
- bindings/js/ScriptValue.h:
- bindings/js/SerializedScriptValue.cpp:
- bindings/js/SerializedScriptValue.h:
- dom/Document.cpp:
- dom/Document.h:
- dom/NodeFilter.cpp:
- dom/NodeFilter.h:
- dom/NodeFilterCondition.cpp:
- dom/NodeFilterCondition.h:
- dom/NodeIterator.cpp:
- dom/NodeIterator.h:
- dom/ScriptExecutionContext.cpp:
- dom/ScriptExecutionContext.h:
- dom/Traversal.cpp:
- dom/Traversal.h:
- dom/TreeWalker.cpp:
- dom/TreeWalker.h:
- inspector/ConsoleMessage.cpp:
- inspector/ConsoleMessage.h:
- inspector/InjectedScript.h:
- inspector/InjectedScriptBase.cpp:
- inspector/InjectedScriptBase.h:
- inspector/InjectedScriptCanvasModule.cpp:
- inspector/InjectedScriptCanvasModule.h:
- inspector/InjectedScriptHost.cpp:
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptManager.cpp:
- inspector/InjectedScriptManager.h:
- inspector/InjectedScriptModule.cpp:
- inspector/InjectedScriptModule.h:
- inspector/InspectorAgent.cpp:
- inspector/InspectorCanvasAgent.cpp:
- inspector/InspectorCanvasAgent.h:
- inspector/InspectorConsoleAgent.cpp:
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorConsoleInstrumentation.h:
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorDebuggerAgent.cpp:
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorFrontendClientLocal.cpp:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorIndexedDBAgent.cpp:
- inspector/InspectorInstrumentation.cpp:
- inspector/InspectorInstrumentation.h:
- inspector/PageConsoleAgent.cpp:
- inspector/PageDebuggerAgent.cpp:
- inspector/PageRuntimeAgent.cpp:
- inspector/PageRuntimeAgent.h:
- inspector/ScriptArguments.cpp:
- inspector/ScriptArguments.h:
- inspector/ScriptDebugListener.h:
- inspector/WorkerDebuggerAgent.cpp:
- inspector/WorkerRuntimeAgent.cpp:
- page/Console.cpp:
- page/Console.h:
- page/ContentSecurityPolicy.cpp:
- page/ContentSecurityPolicy.h:
- page/PageConsole.cpp:
- page/PageConsole.h:
- workers/WorkerGlobalScope.cpp:
- workers/WorkerGlobalScope.h:
- 5:28 PM Changeset in webkit [155735] by
-
- 5 edits in trunk/Source/JavaScriptCore
FTL JIT broke after r155711
https://bugs.webkit.org/show_bug.cgi?id=121332
Reviewed by Geoffrey Garen.
Fixed OSR entry to use the local variable's index instead of its VirtualRegister.
Initialized ExitArgumentForOperand::m_operand to InvalidVirtualRegister instead of -1.
Fixed compileCallOrConstruct() to update locals on callframe going down.
Fixed prepareOSREntry() to grow stack down if needed.
- ftl/FTLExitArgumentForOperand.h:
(JSC::FTL::ExitArgumentForOperand::ExitArgumentForOperand):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileExtractOSREntryLocal):
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
- ftl/FTLOSREntry.cpp:
(JSC::FTL::prepareOSREntry):
- 5:26 PM Changeset in webkit [155734] by
-
- 5 edits in trunk/Source
Avoid a couple of zero-sized fastMalloc calls
https://bugs.webkit.org/show_bug.cgi?id=121333
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- API/JSStringRefCF.cpp:
(JSStringCopyCFString):
Return an empty constant CFStringRef if the JSStringRef is empty.
- runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::JSPropertyNameIterator):
Don't allocate an empty m_jsStrings array if m_jsStringsSize is 0.
Source/WTF:
- wtf/text/StringBuffer.h:
(WTF::StringBuffer::StringBuffer):
Initialize m_data to null if m_length is null, and use Checked<size_t> to check for
overflow when multiplying m_length with the character size.
- 4:56 PM Changeset in webkit [155733] by
-
- 2 edits in trunk/LayoutTests
svg/dom/SVGScriptElement/script-load-and-error-events.svg is flakey
https://bugs.webkit.org/show_bug.cgi?id=25817
Reviewed by Tim Horton.
- svg/dom/SVGScriptElement/script-load-and-error-events.svg: Let test 5 finish
before starting test 6.
- 4:35 PM Changeset in webkit [155732] by
-
- 2 edits in trunk/LayoutTests
http/tests/misc/submit-post-keygen.html is extremely slow on bots, often timing out
https://bugs.webkit.org/show_bug.cgi?id=121331
- platform/mac/TestExpectations: Marked the test as sometimes timing out.
- 4:35 PM Changeset in webkit [155731] by
-
- 13 edits in trunk/Source/WebCore
Chrome, DragController and FocusController should hold onto a Page&
https://bugs.webkit.org/show_bug.cgi?id=121325
Reviewed by Anders Carlsson.
- editing/FrameSelection.cpp:
- editing/FrameSelection.h:
- page/Chrome.cpp:
(WebCore::Chrome::Chrome):
(WebCore::Chrome::scroll):
(WebCore::Chrome::createWindow):
(WebCore::canRunModalIfDuringPageDismissal):
(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):
(WebCore::Chrome::mouseDidMoveOverElement):
(WebCore::Chrome::setToolTip):
(WebCore::Chrome::windowScreenDidChange):
- page/Chrome.h:
- page/DragController.cpp:
- page/DragController.h:
- page/mac/DragControllerMac.mm:
- page/FocusController.cpp:
- page/FocusController.h:
- page/Page.cpp:
(WebCore::Page::Page):
- page/PageGroupLoadDeferrer.cpp:
- page/PageGroupLoadDeferrer.h:
Take references where possible.
- 4:18 PM Changeset in webkit [155730] by
-
- 12 edits3 adds in trunk
DFG AI assumes that ToThis can never return non-object if it is passed an object, and operationToThis will get the wrong value of isStrictMode() if there's inlining
https://bugs.webkit.org/show_bug.cgi?id=121330
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg and Oliver Hunt.
Also print whether a function is strict mode in debug dumps.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpAssumingJITType):
- bytecode/CodeOrigin.cpp:
(JSC::InlineCallFrame::dumpInContext):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
Tools:
Reviewed by Mark Hahnenberg and Oliver Hunt.
We should run tests even if they don't have expected files yet.
- Scripts/run-layout-jsc:
LayoutTests:
Reviewed by Mark Hahnenberg and Oliver Hunt.
- js/dfg-strict-mode-to-this-expected.txt: Added.
- js/dfg-strict-mode-to-this.html: Added.
- js/jsc-test-list:
- js/script-tests/dfg-strict-mode-to-this.js: Added.
(thingy.bar):
(thingy.foo):
(thingy):
- 4:05 PM Changeset in webkit [155729] by
-
- 30 edits in trunk
Use nullptr instead of 0 in calls to HashMap::add
https://bugs.webkit.org/show_bug.cgi?id=121322
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitLoad):
(JSC::BytecodeGenerator::addStringConstant):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::cellConstant):
Source/WebCore:
- bridge/IdentifierRep.cpp:
(WebCore::IdentifierRep::get):
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData):
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::getFontFace):
- css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::getFontData):
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFamilyValue):
(WebCore::CSSValuePool::createFontFaceValue):
- dom/ChildListMutationScope.cpp:
(WebCore::ChildListMutationAccumulator::getOrCreate):
- dom/Document.cpp:
(WebCore::Document::getCSSCanvasElement):
- dom/NodeRareData.h:
(WebCore::NodeListsNodeData::addCacheWithAtomicName):
(WebCore::NodeListsNodeData::addCacheWithName):
(WebCore::NodeListsNodeData::addCacheWithQualifiedName):
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
- page/PageGroup.cpp:
(WebCore::PageGroup::pageGroup):
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::ensureCompositeAnimation):
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
- storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::localStorageNamespace):
Source/WebKit/mac:
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::hostForPlugin):
Source/WebKit2:
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::SyncMessageState::getOrCreate):
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createLocalStorageMap):
(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::getOrCreateLocalStorageNamespace):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addBackForwardItem):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::getOrCreate):
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
(WebKit::InjectedBundleRangeHandle::getOrCreate):
- WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::createLocalStorageNamespace):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::webPageGroup):
Tools:
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::evaluateScriptInIsolatedWorld):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::evaluateScriptInIsolatedWorld):
- 4:00 PM Changeset in webkit [155728] by
-
- 5 edits in trunk/LayoutTests
svg/animations/smil-leak-*.svg tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=114280
Approved in person by Geoff Garen.
Increased the number of nodes in the test 10x to see what happens with the number
of leaked nodes.
- svg/animations/smil-leak-dynamically-added-element-instances.svg:
- svg/animations/smil-leak-element-instances-noBaseValRef.svg:
- svg/animations/smil-leak-element-instances.svg:
- svg/animations/smil-leak-elements.svg:
- 3:27 PM Changeset in webkit [155727] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: svg/dom/SVGScriptElement/script-load-and-error-events.svg
https://bugs.webkit.org/show_bug.cgi?id=25817
Reviewed by Tim Horton.
- svg/dom/SVGScriptElement/script-load-and-error-events.svg: Made test output
a bit more verbose to see what's happening on bots.
- 2:38 PM Changeset in webkit [155726] by
-
- 4 edits in trunk/Source/WebKit/mac
[mac WK1] Introduce WebViewWillCloseNotification
https://bugs.webkit.org/show_bug.cgi?id=121321
Reviewed by Sam Weinig.
- WebKit.exp: Exported WebViewWillCloseNotification.
- WebView/WebView.mm:
(-[WebView _close]): Send WebViewWillCloseNotification before closing the WebView.
- WebView/WebViewPrivate.h: Declared WebViewWillCloseNotification.
- 2:32 PM Changeset in webkit [155725] by
-
- 2 edits2 adds in trunk/LayoutTests
Layout Test fast/dom/Window/window-postmessage-clone.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=111898
Reviewed by Oliver Hunt.
- fast/dom/Window/script-tests/postmessage-clone.js: The test was checking
modification times of non-existent files. When you do this, you get current time,
and current time changes over time, making comparisons non-reliable.
- fast/dom/Window/resources/file1.txt: Added.
- fast/dom/Window/resources/file2.txt: Added.
- 2:19 PM Changeset in webkit [155724] by
-
- 15 edits in trunk
Try to kill initialiser expression in for-in statements
https://bugs.webkit.org/show_bug.cgi?id=121311
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
We'd like to get rid of this pointless initialiser expression
in for-in statements. Unfortunately we have to keep the no_in
variant of expression parsing to avoid ambiguity in the grammar.
There's a possibility that this will need to be rolled out, but
we'll need to live on it to see.
- bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createForInLoop):
- parser/NodeConstructors.h:
(JSC::ForInNode::ForInNode):
- parser/Nodes.h:
- parser/Parser.cpp:
(JSC::::parseForStatement):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createForInLoop):
LayoutTests:
Update test cases to represent the new reality
- js/line-column-numbers-expected.txt:
- js/line-column-numbers.html:
- js/parser-syntax-check-expected.txt:
- js/script-tests/function-declaration-statement.js:
- js/script-tests/line-column-numbers.js:
(try.toFuzz22b):
- js/script-tests/parser-syntax-check.js:
- js/script-tests/toString-for-var-decl.js:
(f1):
- 2:12 PM Changeset in webkit [155723] by
-
- 4 edits in trunk/Source/WebCore
ContextMenuController should hold onto a Page&
https://bugs.webkit.org/show_bug.cgi?id=121320
Reviewed by Anders Carlsson.
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::ContextMenuController):
(WebCore::ContextMenuController::~ContextMenuController):
(WebCore::ContextMenuController::showContextMenu):
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):
(WebCore::ContextMenuController::showContextMenuAt):
- page/ContextMenuController.h:
Store the Page and ContextMenuClient as references.
- page/Page.cpp:
(WebCore::Page::Page):
Pass the Page and ContextMenuClient as references and switch to using createOwned<>().
- 2:11 PM Changeset in webkit [155722] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed; part one of build fix for Windows.
Sorry for the noise, I thought I'd fixed it.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 1:52 PM Changeset in webkit [155721] by
-
- 11 edits in trunk/Source/WebCore
Apply OVERRIDE and FINAL to Image subclasses and clean them up
https://bugs.webkit.org/show_bug.cgi?id=121086
Reviewed by Alexey Proskuryakov.
Everything other than the copious application of OVERRIDE and FINAL
is explicitly called out below.
- WebCore.exp.in:
Export the correct version of getCGImageRef for use by WebKit2.
- platform/graphics/BitmapImage.cpp:
- platform/graphics/BitmapImage.h:
Drive-by inline isBitmapImage.
Move create(HBITMAP) to be near the other create() functions.
Move all of the members private.
Devirtualize frameCount().
Move notSolidColor() near the other solid color functions.
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage):
(WebCore::CrossfadeGeneratedImage::drawPattern):
- platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::draw):
(WebCore::GeneratorGeneratedImage::drawPattern):
Use size() and setContainerSize() instead of directly accessing a
superclass' (now private, previously protected) members.
- platform/graphics/CrossfadeGeneratedImage.h:
- platform/graphics/GeneratedImage.h:
Make m_size private, I don't think we do protected members.
- platform/graphics/GeneratorGeneratedImage.h:
Make all the members private.
- svg/graphics/SVGImage.h:
- svg/graphics/SVGImageForContainer.h:
- 1:41 PM Changeset in webkit [155720] by
-
- 4 edits in trunk/LayoutTests
Flaky Test: http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html
https://bugs.webkit.org/show_bug.cgi?id=114209
Reviewed by Joseph Pecoraro.
- TestExpectations: Marked the test as WontFix. It is hopelessly broken, and
doesn't test anything specific anyway.
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
Removed from the lists, as the test is now skipped globally.
- 1:40 PM Changeset in webkit [155719] by
-
- 2 edits in trunk/Source/WebCore
[Mac] WebCore Web Inspector files are only copied as part of clean build
https://bugs.webkit.org/show_bug.cgi?id=121316
Reviewed by Timothy Hatcher.
Removed insufficient dependencies to make the phase run unconditionally.
- WebCore.xcodeproj/project.pbxproj:
- 1:37 PM Changeset in webkit [155718] by
-
- 5 edits in trunk/Source/WebCore
CodeGeneratorJS doesn't generate header includes for sequence<type>
https://bugs.webkit.org/show_bug.cgi?id=121314
Reviewed by Dean Jackson.
- bindings/scripts/CodeGeneratorJS.pm:
(SkipIncludeHeader): Don't return false for sequence and array types.
(AddIncludesForType): Do add includes for sequence and array types.
(GenerateCallbackImplementation):
- bindings/scripts/test/JS/JSTestTypedefs.cpp: Regenerated
- bindings/scripts/test/JS/JSTestTypedefs.h: Ditto.
- bindings/scripts/test/TestTypedefs.idl: Add a method that takes a sequence<TestEventTarget>.
- 12:41 PM Changeset in webkit [155717] by
-
- 2 edits in trunk/Source/WTF
[Windows] Activate FastMalloc hardening
https://bugs.webkit.org/show_bug.cgi?id=121307
Reviewed by Oliver Hunt.
- wtf/FastMalloc.cpp:
(WTF::SLL_Next): Add workaround for MSVC compiler bug.
- 12:31 PM Changeset in webkit [155716] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderSVGResourcePattern always has an SVGPatternElement.
<https://webkit.org/b/121313>
Reviewed by Anders Carlsson.
This renderer is never anonymous. Tighten things up with a patternElement()
reference getter. Removed some unnecessary null checks and assertions.
- 12:09 PM Changeset in webkit [155715] by
-
- 11 edits in trunk/Source/WebCore
Remove layering-violating Pasteboard::plainText function (for all platforms now)
https://bugs.webkit.org/show_bug.cgi?id=121312
Reviewed by Antti Koivisto.
- editing/Editor.cpp:
(WebCore::Editor::pasteAsPlainTextWithPasteboard): Call readPlainTextFromPasteboard
on all platforms, not just Mac and EFL. Also call canSmartReplaceWithPasteboard with
a reference instead of a pointer.
(WebCore::Editor::readPlainTextFromPasteboard): Added. This is a cross-platform
version of what was previously a Mac-only function.
(WebCore::Editor::plainTextFromPasteboard): Added. This is the simple non-Mac version
of this function.
(WebCore::Editor::pasteWithPasteboard): Updated to call canSmartReplaceWithPasteboard
with a reference.
(WebCore::Editor::canSmartReplaceWithPasteboard): Updated to take a reference.
- editing/Editor.h: Make readPlainTextFromPasteboard cross-platform instead of
Mac-only. Also changed argument to canSmartReplaceWithPasteboard to be a reference.
Also added private plainTextFromPasteboard function.
- editing/mac/EditorMac.mm:
(WebCore::Editor::pasteWithPasteboard): Updated to call canSmartReplaceWithPasteboard
with a reference.
(WebCore::Editor::plainTextFromPasteboard): Added. Contains the Mac-specific parts
of the readPlainTextFromPasteboard function.
- platform/Pasteboard.h: Fixed a conditional in the PasteboardPlainText struct to
omit iOS. Removed the layering-voiolating plainText function.
- platform/blackberry/PasteboardBlackBerry.cpp:
(WebCore::Pasteboard::read): Renamed from plainText and updated to new calling
convention.
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::read): Ditto.
- platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::read): Ditto.
- platform/nix/PasteboardNix.cpp:
(WebCore::Pasteboard::read): Ditto.
- platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::read): Ditto.
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::read): Ditto.
- 12:06 PM Changeset in webkit [155714] by
-
- 30 edits1 add in trunk
[GTK] Move to the new web inspector
https://bugs.webkit.org/show_bug.cgi?id=120647
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-09-13
Reviewed by Carlos Garcia Campos.
.:
- GNUmakefile.am: include the new WebInspectorUI GNUmakefile.am.
Source/WebCore:
No tests for the new inspector UI as of yet.
- GNUmakefile.am: no longer install the deprecated inspector UI files.
- WebCore.exp.in: add SchemeRegistry symbol that is now used.
Source/WebInspectorUI:
- GNUmakefile.am: Added. Generate the GResource source and link it into libWebCore.
Source/WebKit/gtk:
- WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::openInspectorFrontend): update paths to the internal resource ones.
(WebKit::InspectorClient::inspectorFilesPath): ditto.
- tests/testwebinspector.c:
(consoleMessageCallback): the new inspector currently emits an error when loading, so add it to
the list of messages which are not considered failures.
- webkit/webkitglobals.cpp:
(webkitInit): register resource as a local scheme; currently used by the inspector.
Source/WebKit2:
- GNUmakefile.am: bundle the remote inspector page list HTML into libwebkit2gtk as a GResource.
- UIProcess/API/gtk/tests/GNUmakefile.am: no need to set WEBKIT_INSPECTOR_PATH anymore.
- UIProcess/API/gtk/tests/InspectorTestServer.cpp:
(main): ditto.
- UIProcess/API/gtk/tests/TestInspector.cpp:
(beforeAll): ditto.
- UIProcess/API/gtk/tests/TestInspectorServer.cpp:
(testInspectorServerPageList): update paths to the internal resource ones.
- UIProcess/InspectorServer/WebInspectorServer.h:
- UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::platformResourceForPath): ditto.
(WebKit::WebInspectorServer::buildPageList): ditto.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::isMainInspectorPage): factor out checking for the inspector main resource, to make
the code more readable.
(WebKit::decidePolicyForNavigationAction): use SchemeRegistry to figure out whether the
request is for a local resource instead of KURL::isLocalFile() to allow using schemes
other than file:// for the inspector resources.
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::inspectorPageURL): use the new internal resource URL; since it's now
static we no longer need to generate and store the string.
(WebKit::WebInspectorProxy::inspectorBaseURL): ditto.
- WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspector::localizedStringsURL): use the new internal resource URL.
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformInitializeWebProcess): register resource as a local scheme.
Tools:
- GtkLauncher/main.c:
(main): no longer set WEBKIT_INSPECTOR_PATH.
- MiniBrowser/gtk/main.c:
(main): ditto.
- Scripts/old-run-webkit-tests:
(openDumpTool): ditto.
- Scripts/run-gtk-tests: ditto.
- Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server): ditto.
LayoutTests:
- platform/gtk/TestExpectations: the new inspector UI does not support the current
inspector testing harness so keep it skipped, a new one will eventually be landed.
- 11:22 AM Changeset in webkit [155713] by
-
- 2 edits in trunk/Source/WebCore
Try to fix Qt build.
- platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::write): Update variable name at one place I missed.
- 11:10 AM Changeset in webkit [155712] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Scrolling and zooming is slow when Flash plugin visible
https://bugs.webkit.org/show_bug.cgi?id=120618
Reviewed by Anders Carlsson.
Internally reviewed by Jacky Jiang.
JIRA 490823
Compositing Flash plugin content triggered a workaround for a graphics
driver quirk. The workaround was actually related to WebGL, not Flash,
back when we used glCopyTexImage to implement WebGL double buffering
(see PR 148933 and 150228 for more details of the old implementation).
Originally, both WebGL and plugin layers added themselves to the
LayerRenderer::m_layersLockingTextureResources list. Now only plugin
layers use this list.
The glCopyTexImage code was removed long ago, and WebGL now uses the
EGLImage-based double buffering approach implemented in
EGLImageLayerWebKitThread and EGLImageLayerCompositingThreadClient.
Fixed by removing the now obsolete workaround, a call to "glFinish".
This considerably improves the frame rate of zooming and scrolling when
Flash content is visible.
Improvement in frame rate not appropriate to test using layout tests,
could easily result in flaky test.
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::compositeLayers):
- 11:03 AM Changeset in webkit [155711] by
-
- 57 edits in trunk/Source/JavaScriptCore
fourthTier: Change JSStack to grow from high to low addresses
https://bugs.webkit.org/show_bug.cgi?id=118758
Reviewed by Oliver Hunt.
Changed the JSC stack to grow down. Effectively the JSC stack frame is flipped from
what it was. See JSStack.h for the new offsets. Changed JSStack begin() and end()
to be getBaseOfStack() and getLimitOfStack(). Most of the changes are address or offset
calculation changes. Decoupled a local register ordinal (loop variable or array index)
from the offset into the callFrame using localToOperand() and the inverse operandToLocal().
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::trustedImm32ForShift):
(JSC::MacroAssembler::lshiftPtr): Added to create scaled addresses with a negative index
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::lshift64): Added to create scaled addresses with a negative index
- assembler/X86Assembler.h:
(JSC::X86Assembler::shlq_i8r): Added to create scaled addresses with a negative index
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
- bytecode/CodeBlock.h:
(JSC::unmodifiedArgumentsRegister):
(JSC::CodeBlock::isCaptured):
- bytecode/CodeOrigin.h:
(JSC::CodeOrigin::stackOffset):
- bytecode/Operands.h:
(JSC::localToOperand):
(JSC::operandIsLocal):
(JSC::operandToLocal):
(JSC::operandIsArgument):
(JSC::operandToArgument):
(JSC::argumentToOperand):
- bytecode/VirtualRegister.h: Made InvalidVirtualRegister a positive value that fits in
31 bits since it can be placed into the 31 bit field "stackOffset" in struct InlineCallFrame.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addVar):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::createLazyRegisterIfNecessary):
(JSC::BytecodeGenerator::newRegister):
(JSC::BytecodeGenerator::emitNewArray):
- bytecompiler/BytecodeGenerator.h:
(JSC::CallArguments::registerOffset):
- bytecompiler/NodesCodegen.cpp:
(JSC::CallArguments::CallArguments):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOperations.cpp:
- dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::allocate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callFrameSlot):
(JSC::DFG::SpeculativeJIT::argumentSlot):
(JSC::DFG::SpeculativeJIT::callFrameTagSlot):
(JSC::DFG::SpeculativeJIT::callFramePayloadSlot):
(JSC::DFG::SpeculativeJIT::argumentTagSlot):
(JSC::DFG::SpeculativeJIT::argumentPayloadSlot):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::reportValidationContext):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::genericAddSpan):
- interpreter/CallFrame.cpp:
(JSC::CallFrame::frameExtentInternal):
- interpreter/CallFrame.h:
(JSC::ExecState::init):
(JSC::ExecState::argumentOffset):
(JSC::ExecState::argumentOffsetIncludingThis):
(JSC::ExecState::argIndexForRegister):
- interpreter/Interpreter.cpp:
(JSC::loadVarargs):
(JSC::Interpreter::dumpRegisters):
- interpreter/JSStack.cpp:
(JSC::JSStack::JSStack):
(JSC::JSStack::~JSStack):
(JSC::JSStack::growSlowCase):
(JSC::JSStack::gatherConservativeRoots):
(JSC::JSStack::releaseExcessCapacity):
(JSC::JSStack::disableErrorStackReserve):
- interpreter/JSStack.h:
(JSC::JSStack::getBaseOfStack):
(JSC::JSStack::getLimitOfStack):
(JSC::JSStack::size):
(JSC::JSStack::end):
(JSC::JSStack::containsAddress):
(JSC::JSStack::lowAddress):
(JSC::JSStack::highAddress):
(JSC::JSStack::reservationEnd):
(JSC::JSStack::shrink):
(JSC::JSStack::grow):
- interpreter/JSStackInlines.h:
(JSC::JSStack::getTopOfFrame):
(JSC::JSStack::pushFrame):
(JSC::JSStack::popFrame):
(JSC::JSStack::installTrapsAfterFrame):
- interpreter/StackVisitor.cpp:
(JSC::inlinedFrameOffset):
(JSC::StackVisitor::readInlinedFrame):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileOpCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileOpCall):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_get_argument_by_val):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_get_argument_by_val):
- jit/JITStubs.cpp:
(JSC::throwExceptionFromOpCall):
(JSC::DEFINE_STUB_FUNCTION):
- jit/ThunkGenerators.cpp:
(JSC::arityFixup):
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::genericCall):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/ArgList.cpp:
(JSC::ArgList::getSlice):
(JSC::MarkedArgumentBuffer::slowAppend):
- runtime/ArgList.h:
(JSC::MarkedArgumentBuffer::MarkedArgumentBuffer):
(JSC::MarkedArgumentBuffer::slotFor):
(JSC::MarkedArgumentBuffer::mallocBase):
(JSC::ArgList::at):
- runtime/Arguments.cpp:
(JSC::Arguments::tearOff):
- runtime/ArrayConstructor.cpp:
(JSC::constructArrayWithSizeQuirk):
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/JSActivation.h:
(JSC::JSActivation::registersOffset):
(JSC::JSActivation::tearOff):
(JSC::JSActivation::isValidIndex):
- runtime/JSArray.h:
(JSC::constructArrayNegativeIndexed): New method to create an array from registers that grow down.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::globalExec):
- runtime/JSGlobalObject.h:
(JSC::constructArrayNegativeIndexed):
- runtime/JSString.h:
- runtime/Operations.h:
(JSC::jsStringFromRegisterArray):
- runtime/SymbolTable.h:
(JSC::SharedSymbolTable::captureCount):
- 10:59 AM Changeset in webkit [155710] by
-
- 6 edits1 add in trunk/Source/WebCore
Move LineLayoutState class to LineLayoutState.h
https://bugs.webkit.org/show_bug.cgi?id=121263
Reviewed by Ryosuke Niwa.
I added bitfields, reordered the members and a functions too.
No new tests, no behavior change.
- rendering/LineLayoutState.h: Added.
(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::markForFullLayout):
(WebCore::LineLayoutState::isFullLayout):
(WebCore::LineLayoutState::usesRepaintBounds):
(WebCore::LineLayoutState::setRepaintRange):
(WebCore::LineLayoutState::updateRepaintRangeFromBox):
(WebCore::LineLayoutState::endLineMatched):
(WebCore::LineLayoutState::setEndLineMatched):
(WebCore::LineLayoutState::checkForFloatsFromLastLine):
(WebCore::LineLayoutState::setCheckForFloatsFromLastLine):
(WebCore::LineLayoutState::lineInfo):
(WebCore::LineLayoutState::endLineLogicalTop):
(WebCore::LineLayoutState::setEndLineLogicalTop):
(WebCore::LineLayoutState::endLine):
(WebCore::LineLayoutState::setEndLine):
(WebCore::LineLayoutState::lastFloat):
(WebCore::LineLayoutState::setLastFloat):
(WebCore::LineLayoutState::floats):
(WebCore::LineLayoutState::floatIndex):
(WebCore::LineLayoutState::setFloatIndex):
(WebCore::LineLayoutState::adjustedLogicalLineTop):
(WebCore::LineLayoutState::setAdjustedLogicalLineTop):
(WebCore::LineLayoutState::flowThread):
(WebCore::LineLayoutState::setFlowThread):
- rendering/RenderBlockLineLayout.cpp: Remove LineLayoutState.
- 10:46 AM Changeset in webkit [155709] by
-
- 12 edits in trunk/Source/WebCore
Remove layering-violating Pasteboard::writeURL (for all platforms now)
https://bugs.webkit.org/show_bug.cgi?id=121306
Reviewed by Antti Koivisto.
- editing/Editor.cpp:
(WebCore::Editor::copyURL): Move the contents of the writeURLToPasteboard function
in here.
- editing/Editor.h: Removed Mac-specific writeURLToPasteboard, added private
Mac-specific fillInUserVisibleForm function for the one Mac-specific part of writing URLs.
- editing/efl/EditorEfl.cpp: Deleted Editor::writeURLToPasteboard.
- editing/mac/EditorMac.mm: Deleted Editor::writeURLToPasteboard, moving the code
into copyURL.
(WebCore::Editor::fillInUserVisibleForm): Added.
- page/DragController.cpp:
(WebCore::DragController::startDrag): Call copyURL instead of writeURL or
writeURLToPasteboard.
- platform/Pasteboard.h: Fixed up the PasteboardURL struct so it's suitable for
cross-platform use. Removed the writeURL function. Removed the Frame* argument from
the Windows-specific writeURLToDataObject function.
- platform/blackberry/PasteboardBlackBerry.cpp:
(WebCore::Pasteboard::write): Renamed/refactored from writeURL.
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::write): Ditto.
- platform/nix/PasteboardNix.cpp:
(WebCore::Pasteboard::write): Ditto.
- platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::write): Ditto.
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeURLToDataObject): Removed unused Frame* argument.
(WebCore::Pasteboard::write): Renamed/refactored from writeURL.
- 10:32 AM Changeset in webkit [155708] by
-
- 4 edits2 adds in trunk
AX: AXPress does not work in SVG
https://bugs.webkit.org/show_bug.cgi?id=121248
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Implement accessKeyAction() on SVGElements, which is what accessibility code
uses in order to activate Elements.
Test: accessibility/svg-element-press.html
- svg/SVGElement.cpp:
(WebCore::SVGElement::accessKeyAction):
- svg/SVGElement.h:
LayoutTests:
- accessibility/svg-element-press-expected.txt: Added.
- accessibility/svg-element-press.html: Added.
- 9:54 AM Changeset in webkit [155707] by
-
- 8 edits in trunk/Source/WebCore
[CTTE] RenderSVGTransformableContainer is never anonymous.
<https://webkit.org/b/121304>
Reviewed by Anders Carlsson.
This renderer is never anonymous. Tighten things up with a graphicsElement()
reference getter.
- 8:56 AM Changeset in webkit [155706] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderSVGImage always has a SVGImageElement.
<https://webkit.org/b/121301>
Reviewed by Anders Carlsson.
This renderer is never anonymous, and always has a corresponding SVGImageElement.
- 8:55 AM Changeset in webkit [155705] by
-
- 2 edits in trunk/Source/JavaScriptCore
ARM EABI hardfp buildfix after r155675
https://bugs.webkit.org/show_bug.cgi?id=121287
Reviewed by Geoffrey Garen.
- dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
- 8:54 AM Changeset in webkit [155704] by
-
- 16 edits in trunk/Source/WebCore
[CTTE] Tighter element types for RenderSVGShape and subclasses.
<https://webkit.org/b/121302>
Reviewed by Antti Koivisto.
Codify the following:
- RenderSVGPath always has an SVGGraphicsElement.
- RenderSVGEllipse always has an SVGGraphicsElement.
- RenderSVGRect always has an SVGRectElement.
- RenderSVGShape always has an SVGGraphicsElement.
None of these renderers are ever anonymous, so delete element() and provide
strongly typed reference getters instead.
- 8:53 AM Changeset in webkit [155703] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderSVGResourceFilterPrimitive always has an SVGFilterPrimitiveStandardAttributes.
<https://webkit.org/b/121300>
Reviewed by Anders Carlsson.
This renderer is never anonymous, and always has a corresponding SVGFilterPrimitiveStandardAttributes element.
- 8:40 AM Changeset in webkit [155702] by
-
- 2 edits in trunk/Source/WebKit2
Fix build with namespaced Qt.
Unreviewed build fix.
One forward declaration of QUrl was missing proper namespace macros.
- UIProcess/API/qt/qquickurlschemedelegate_p.h:
- 8:25 AM Changeset in webkit [155701] by
-
- 2 edits in trunk/Source/WTF
OwnArrayPtr: Never allow implicit pointer conversion
https://bugs.webkit.org/show_bug.cgi?id=121291
Reviewed by Anders Carlsson.
We should never allow implicit pointer conversion in OwnArrayPtr
and remove its template copy constructor & template assignment operator, as:
- these methods are never used
- these methods are inappropriate to have in OwnArrayPtr as arrays do not interact well with polymorphism.
- wtf/OwnArrayPtr.h:
- 8:25 AM Changeset in webkit [155700] by
-
- 6 edits in trunk/Source/WebCore
Finish removing layer-violating code from Pasteboard (just for Mac during this first step)
https://bugs.webkit.org/show_bug.cgi?id=121279
Reviewed by Anders Carlsson.
- editing/Editor.h: Added webContentFromPasteboard member function, private nested class
WebContentReader, private createFragmentForImageResourceAndAddResource and
createFragmentAndAddResources member functions.
- editing/mac/EditorMac.mm: Re-sorted includes and added some.
(WebCore::Editor::pasteWithPasteboard): Call the new webContentFromPasteboard function.
(WebCore::Editor::insertParagraphSeparatorInQuotedContent): Comment tweak.
(WebCore::styleForSelectionStart): Removed an unneeded call to String::impl.
(WebCore::Editor::readPlainTextFromPasteboard): Updated to use an isURL boolean instead
of a separate string named "url".
(WebCore::Editor::WebContentReader::readWebArchive): Added. Contains reworked code that
was originally in Pasteboard::documentFragment.
(WebCore::Editor::WebContentReader::readFilenames): Ditto.
(WebCore::Editor::WebContentReader::readHTML): Ditto.
(WebCore::Editor::WebContentReader::readRTFD): Ditto.
(WebCore::Editor::WebContentReader::readRTF): Ditto.
(WebCore::Editor::WebContentReader::readImage): Ditto.
(WebCore::Editor::WebContentReader::readURL): Ditto.
(WebCore::Editor::WebContentReader::readPlainText): Ditto.
(WebCore::Editor::webContentFromPasteboard): Added. Uses WebContentReader to read the
content from the pasteboard.
(WebCore::Editor::createFragmentForImageResourceAndAddResource): Added. Helper used
by code above.
(WebCore::Editor::createFragmentAndAddResources): Ditto.
- platform/Pasteboard.h: Added new PasteboardWebContentReader abstract class so
client can get the various types of pasteboard content and stop on the kind it
can handle. Improved comments and formatting a bit. Removed documentFragment
when compiling for PLATFORM(MAC).
- platform/mac/DragDataMac.mm:
(WebCore::DragData::asFragment): Changed to use Editor::webContentFromPasteboard.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::read): Updated the plain text overload of this for changes
to the struct that holds the result. Added a new web content overload of this,
which retains the pasteboard-reading part of Pasteboard::documentFragment, but
omits the document fragment construction part.
- 8:15 AM Changeset in webkit [155699] by
-
- 4 edits in trunk
[Qt] REGRESSION(r154444): xss-DENIED test results changed
https://bugs.webkit.org/show_bug.cgi?id=120595
Reviewed by Jocelyn Turcotte.
Tools:
Avoid overwriting Qt meta properties, which we identify by them being undeletable.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(DumpRenderTree::initJSObjects):
LayoutTests:
- platform/qt/TestExpectations:
- 8:01 AM WebKitGTK/2.0.x edited by
- (diff)
- 7:50 AM Changeset in webkit [155698] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderSVGText always has a SVGTextElement.
<https://webkit.org/b/121299>
Reviewed by Antti Koivisto.
This renderer is never anonymous, and always has a corresponding <svg> element.
Tighten this up and remove some pointless assertions.
- 7:34 AM Changeset in webkit [155697] by
-
- 13 edits1 delete in trunk/Source
Remove support for QXmlStream as the XML parser.
https://bugs.webkit.org/show_bug.cgi?id=121229
Reviewed by Andreas Kling.
Source/WebCore:
Remove the implementation and all the #ifdef related to it.
- Target.pri:
- WebCore.pri:
- dom/TransformSource.h:
- xml/XMLErrors.h:
- xml/XSLStyleSheet.h:
- xml/XSLTProcessor.h:
- xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::enterText):
(WebCore::toString):
(WebCore::XMLDocumentParser::exitText):
(WebCore::XMLDocumentParser::insertErrorMessageBlock):
- xml/parser/XMLDocumentParser.h:
- xml/parser/XMLDocumentParserQt.cpp: Removed.
Source/WebKit/blackberry:
Removed USE flags.
- WebCoreSupport/AboutDataUseFeatures.in:
Source/WTF:
Removed USE flags.
- wtf/Platform.h:
- 7:07 AM Changeset in webkit [155696] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderSVGViewportContainer always has a SVGSVGElement.
<https://webkit.org/b/121297>
Reviewed by Antti Koivisto.
This renderer is never anonymous, and always has a corresponding <svg> element.
Tighten this up and remove some pointless null checks and type checks.
- 6:42 AM Changeset in webkit [155695] by
-
- 5 edits in trunk/LayoutTests
One more Unreviewed fix after r155675.
- js/array-with-double-assign-expected.txt:
- js/array-with-double-assign.html: Path fixed.
- js/array-with-double-push-expected.txt:
- js/array-with-double-push.html: Path fixed.
- 6:09 AM Changeset in webkit [155694] by
-
- 2 edits in trunk
[Qt] Update sync.profile
https://bugs.webkit.org/show_bug.cgi?id=121295
Reviewed by Simon Hausmann.
Ensure we let the dependencies pick the right branch instead of always master
and list all the dependencies we need on all platforms.
- Source/sync.profile:
- 6:06 AM Changeset in webkit [155693] by
-
- 1 edit6 moves in trunk/LayoutTests
Unreviewed fix after r155675. Move new tests from fast/js to js.
- js/array-with-double-assign-expected.txt: Renamed from LayoutTests/fast/js/array-with-double-assign-expected.txt.
- js/array-with-double-assign.html: Renamed from LayoutTests/fast/js/array-with-double-assign.html.
- js/array-with-double-push-expected.txt: Renamed from LayoutTests/fast/js/array-with-double-push-expected.txt.
- js/array-with-double-push.html: Renamed from LayoutTests/fast/js/array-with-double-push.html.
- js/script-tests/array-with-double-assign.js: Renamed from LayoutTests/fast/js/script-tests/array-with-double-assign.js.
(foo):
- js/script-tests/array-with-double-push.js: Renamed from LayoutTests/fast/js/script-tests/array-with-double-push.js.
(foo):
- 5:57 AM Changeset in webkit [155692] by
-
- 5 edits5 deletes in trunk/LayoutTests
[Qt] unreviewed gardening. Rebaseline after r155253.
- platform/qt-wk2/editing/selection/caret-rtl-2-expected.png: Removed.
- platform/qt-wk2/editing/selection/caret-rtl-2-left-expected.png: Removed.
- platform/qt-wk2/editing/selection/caret-rtl-expected.png: Removed.
- platform/qt-wk2/editing/selection/caret-rtl-right-expected.png: Removed.
- platform/qt-wk2/editing/selection/caret-rtl-right-expected.txt: Removed.
- platform/qt/editing/selection/caret-rtl-2-expected.txt:
- platform/qt/editing/selection/caret-rtl-2-left-expected.txt:
- platform/qt/editing/selection/caret-rtl-expected.txt:
- platform/qt/editing/selection/caret-rtl-right-expected.txt:
- 5:32 AM Changeset in webkit [155691] by
-
- 15 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebaseline tests after r155408.
- platform/qt/fast/forms/control-restrict-line-height-expected.png:
- platform/qt/fast/forms/control-restrict-line-height-expected.txt:
- platform/qt/fast/forms/input-placeholder-visibility-1-expected.png:
- platform/qt/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/qt/fast/forms/input-placeholder-visibility-3-expected.png:
- platform/qt/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/qt/fast/forms/placeholder-position-expected.png:
- platform/qt/fast/forms/placeholder-position-expected.txt:
- platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.png:
- platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
- platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.png:
- platform/qt/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.png:
- platform/qt/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- 5:24 AM Changeset in webkit [155690] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderSVGRoot always has a SVGSVGElement.
<https://webkit.org/b/121293>
Reviewed by Antti Koivisto.
This renderer is never anonymous, and always has a corresponding <svg> element.
Tighten this up and remove some pointless null checks and assertions.
- 5:22 AM Changeset in webkit [155689] by
-
- 5 edits in trunk/Source/WebCore
Remove support for anonymous deprecated flexboxes.
<https://webkit.org/b/121288>
Reviewed by Antti Koivisto.
There are no remaining internal clients of RenderDeprecatedFlexibleBox,
Nuke a FIXME from r143643 where the move to basing renderers on new flexbox started.
This was the only user of anonymous deprecated flexbox, so removed the ability to
construct those.
Also removed some Chrome-related feature observation gunk from constructor.
- 5:21 AM Changeset in webkit [155688] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderMultiColumnBlock is never anonymous.
<https://webkit.org/b/121292>
Reviewed by Antti Koivisto.
Hide element() and provide existingElement() instead, returning an Element&.
- 5:20 AM Changeset in webkit [155687] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderGrid is never anonymous.
<https://webkit.org/b/121290>
Reviewed by Antti Koivisto.
Hide element() and provide existingElement() instead, returning an Element&.
- 5:18 AM Changeset in webkit [155686] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderTableCaption is never anonymous.
<https://webkit.org/b/121289>
Reviewed by Antti Koivisto.
Hide element() and provide existingElement() instead, returning an Element&.
- 4:16 AM Changeset in webkit [155685] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderTableCol is never anonymous.
<https://webkit.org/b/121286>
Reviewed by Antti Koivisto.
Hide element() and provide existingElement() instead, returning an Element&.
Removed one bogus null check that was exposed.
- 4:15 AM Changeset in webkit [155684] by
-
- 5 edits in trunk/Source/WebCore
[CTTE] RenderListItem is never anonymous.
<https://webkit.org/b/121285>
Reviewed by Antti Koivisto.
Hide element() and provide existingElement() instead, returning an Element&.
Removed some bogus assertions that were exposed by this.
- 3:08 AM Changeset in webkit [155683] by
-
- 2 edits in trunk/Source/WebKit/mac
REGRESSION (r155615): Lots of reftests fail with single line or single pixel differences
https://bugs.webkit.org/show_bug.cgi?id=121245
Reviewed by Darin Adler.
Similar to https://bugs.webkit.org/show_bug.cgi?id=120963,
we need to manually ensure that some pieces of persistent
CoreGraphics state are restored after PDFKit changes them.
In this case, we bookend our restoration around the various
_recursiveDisplay... functions that we also use in WebHTMLView.
- WebView/WebPDFView.mm:
(-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
(-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
(-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
(-[WebPDFView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
- 2:48 AM Changeset in webkit [155682] by
-
- 18 edits1 delete in trunk/Source/WebCore
[CTTE] Tighter element types for RenderSVGInline and subclasses.
<https://webkit.org/b/121283>
Reviewed by Antti Koivisto.
Codify the following:
- RenderSVGInline always has an SVGGraphicsElement.
- RenderSVGTextPath always has an SVGTextPathElement.
- RenderSVGTSpan always has an SVGTextPositioningElement.
None of these renderers are ever anonymous, so delete element() and provide
strongly typed reference getters instead.
- 2:43 AM Changeset in webkit [155681] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderFileUploadControl always has a HTMLInputElement.
<https://webkit.org/b/121278>
Reviewed by Darin Adler.
RenderFileUploadControl is never anonymous and always has a corresponding HTMLInputElement.
- 2:40 AM Changeset in webkit [155680] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderFieldset always has a HTMLFieldSetElement.
<https://webkit.org/b/121277>
Reviewed by Darin Adler.
RenderFieldset is never anonymous and always has a corresponding HTMLFieldSetElement.
- 2:38 AM Changeset in webkit [155679] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip some failing tests.
https://bugs.webkit.org/show_bug.cgi?id=120848.
- platform/qt/TestExpectations:
- 2:00 AM Changeset in webkit [155678] by
-
- 5 edits in trunk/Source/WebCore
[CTTE] RenderButton always has a HTMLFormControlElement.
<https://webkit.org/b/121281>
Reviewed by Antti Koivisto.
RenderButton is never anonymous and has either a <button> or an <input> element,
and their nearest shared ancestor is HTMLFormControlElement.
- 1:16 AM Changeset in webkit [155677] by
-
- 2 edits in trunk/Source/WebKit/gtk
download-requested arg should be WEBKIT_TYPE_DOWNLOAD not G_TYPE_OBJECT
https://bugs.webkit.org/show_bug.cgi?id=57634
Reviewed by Darin Adler.
- webkit/webkitwebview.cpp:
(webkit_web_view_class_init):
- 1:16 AM Changeset in webkit [155676] by
-
- 5 edits in trunk
Give actions in Range class NON_SHOUTING_NAMES
https://bugs.webkit.org/show_bug.cgi?id=121280
Reviewed by Andreas Kling.
Source/WebCore:
- dom/Range.cpp:
(WebCore::Range::deleteContents):
(WebCore::Range::processContents):
(WebCore::Range::processContentsBetweenOffsets):
(WebCore::Range::processNodes):
(WebCore::Range::processAncestorsAndTheirSiblings):
(WebCore::Range::extractContents):
(WebCore::Range::cloneContents):
- dom/Range.h:
Just let do-webcore-rename do its thing.
- DELETE_CONTENTS -> Delete
- EXTRACT_CONTENTS -> Extract
- CLONE_CONTENTS -> Clone
Tools:
- Scripts/do-webcore-rename: Updated to do this replace, keeping with
the tradition of checking in the last one we did, along with other
rename ideas for the future.
- 12:34 AM Changeset in webkit [155675] by
-
- 4 edits8 adds in trunk
Fixed crash in V8 benchmark suite in ARM,softp,EABI environment.
https://bugs.webkit.org/show_bug.cgi?id=117281
Patch by Youngho Yoo <youngho33.yoo@lge.com> on 2013-09-13
Reviewed by Michael Saboff.
Fix the missing EABI_32BIT_DUMMY_ARG in FPRReg using callOperation function.
Source/JavaScriptCore:
Test 1 : fast/js/array-with-double-assign.html
Test 2 : fast/js/array-with-double-push.html
- dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
LayoutTests:
- fast/js/array-with-double-assign-expected.txt: Added.
- fast/js/array-with-double-assign.html: Added.
- fast/js/array-with-double-push-expected.txt: Added.
- fast/js/array-with-double-push.html: Added.
- fast/js/script-tests/array-with-double-assign.js: Added.
(foo):
- fast/js/script-tests/array-with-double-push.js: Added.
(foo):
Sep 12, 2013:
- 11:42 PM Changeset in webkit [155674] by
-
- 11 edits8 adds in trunk
Source/WebCore: [EFL]Background Style of element not visible because of default theme style
https://bugs.webkit.org/show_bug.cgi?id=117405
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-09-12
Reviewed by Gyuyoung Kim.
When select element is styled with css background property(color/image) the styling
gets hidden by Combo box non transparent image. This patch handle the
case and transparent images are used when select image is styled. So
now background-color and background-image are visible across the Combo box
The code is added to support css styling of other theme control,
Basically an extra signal is emitted to edje which change the state
of edje object whenever the control is styled.
Covered by existing test case, updated the test expected image.
- platform/efl/DefaultTheme/CMakeLists.txt:
- platform/efl/DefaultTheme/widget/combo/combo.edc:
- platform/efl/DefaultTheme/widget/combo/combo_focus_button_transparent.png: Added.
- platform/efl/DefaultTheme/widget/combo/combo_focus_transparent.png: Added.
- platform/efl/DefaultTheme/widget/combo/combo_hover_button_transparent.png: Added.
- platform/efl/DefaultTheme/widget/combo/combo_hover_transparent.png: Added.
- platform/efl/DefaultTheme/widget/combo/combo_normal_button_transparent.png: Added.
- platform/efl/DefaultTheme/widget/combo/combo_normal_transparent.png: Added.
- platform/efl/DefaultTheme/widget/combo/combo_press_button_transparent.png: Added.
- platform/efl/DefaultTheme/widget/combo/combo_press_transparent.png: Added.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::applyEdjeStateFromForm):
(WebCore::RenderThemeEfl::isControlStyled):
(WebCore::RenderThemeEfl::paintThemePart):
- platform/efl/RenderThemeEfl.h:
LayoutTests: [EFL] Background Style of element not visible because of default theme style
https://bugs.webkit.org/show_bug.cgi?id=117405
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-09-12
Reviewed by Gyuyoung Kim.
Updating expected image oputput of pixel test reflecting the
background image visible over combo box.
- platform/efl/fast/forms/menulist-narrow-width-expected.png:
- platform/efl/fast/forms/menulist-restrict-line-height-expected.png:
- platform/efl/fast/forms/menulist-style-color-expected.png:
- platform/efl/fast/forms/select-background-none-expected.png:
- platform/efl/fast/forms/select-style-expected.png:
- 11:16 PM Changeset in webkit [155673] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderMenuList always has a HTMLSelectElement.
<https://webkit.org/b/121276>
Reviewed by Anders Carlsson.
This renderer is never anonymous and always has a corresponding HTMLSelectElement.
Deleted element() in favor of HTMLSelectElement& selectElement().
- 10:50 PM Changeset in webkit [155672] by
-
- 2 edits in trunk/Source/WebKit/qt
Fix Qt build.
- WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::inputMethodQuery):
- 10:32 PM Changeset in webkit [155671] by
-
- 13 edits in trunk/Source
[CTTE] Tighten RenderTextControl element typing.
<https://webkit.org/b/121275>
Reviewed by Anders Carlsson.
Codify these invariants:
- RenderTextControl always has a HTMLTextFormControl.
- RenderSearchField always has a HTMLInputElement.
- RenderTextControlSingleLine always has a HTMLInputElement.
None of these renderers are ever anonymous. Deleted element() and added
strongly typed reference getters instead.
- 10:13 PM Changeset in webkit [155670] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderListMarker is always anonymous and owned by RenderListItem.
<https://webkit.org/b/121274>
Reviewed by Anders Carlsson.
Store a RenderListItem& instead of a pointer in RenderListMarker.
Deleted the element() function since list markers are always anonymous.
- 10:12 PM Changeset in webkit [155669] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderListBox's element is always a HTMLSelectElement.
<https://webkit.org/b/121273>
Reviewed by Anders Carlsson.
Hide element() on RenderListBox and make selectElement() return a reference
since this renderer cannot be anonymous.
- 10:11 PM Changeset in webkit [155668] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderHTMLCanvas's element is always a HTMLCanvasElement.
<https://webkit.org/b/121272>
Reviewed by Anders Carlsson.
Add RenderHTMLCanvas::canvasElement(), hiding element().
This function also returns a reference since this renderer cannot be anonymous.
- 10:09 PM Changeset in webkit [155667] by
-
- 4 edits in trunk/Source/WebCore
[CTTE] RenderTextControlMultiLine's element is always a HTMLTextAreaElement.
<https://webkit.org/b/121271>
Reviewed by Anders Carlsson.
Add RenderTextControlMultiLine::textAreaElement(), hiding element().
This function also returns a reference since this renderer cannot be anonymous.
- 9:49 PM BuildingGtk edited by
- Add how to use wayland-dependecies.modules (diff)
- 7:19 PM Changeset in webkit [155666] by
-
- 2 edits in trunk/WebKitLibraries
[Windows] Update WKSI library for Open Source builders.
- win/lib32/WebKitSystemInterface.lib: Recompile with latest WebKit to use newer
WTF.dll symbol exports.
- 5:37 PM Changeset in webkit [155665] by
-
- 7 edits2 adds in trunk
[mac] Cache rendered image in PDFDocumentImage
https://bugs.webkit.org/show_bug.cgi?id=121207
Reviewed by Simon Fraser.
Tests: fast/images/pdf-as-image-too-big.html
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::createImage):
PDFDocumentImage takes a ImageObserver now so that it can report
decoded data size changes to the memory cache.
- platform/graphics/Image.h:
(WebCore::Image::isPDFDocumentImage): Added.
- platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::PDFDocumentImage):
PDFDocumentImage takes a ImageObserver now so that it can report
decoded data size changes to the memory cache.
(WebCore::PDFDocumentImage::applyRotationForPainting):
Fix up some comments, and use GraphicsContext instead of CG API.
(WebCore::PDFDocumentImage::cacheParametersMatch):
Determine whether our cached image is still valid, given the new
destination's size, CTM scale, and source rect.
(WebCore::transformContextForPainting): Added.
(WebCore::PDFDocumentImage::updateCachedImageIfNeeded):
Cache a rendered bitmap of the PDF. Invalidate the cache if cacheParametersMatch
decides that the parameters don't match, unless we're painting in low quality mode,
in which case we'll scale the existing image (and then fully repaint when the
high-quality repaint timer fires).
Inform the memory cache of our new size.
(WebCore::PDFDocumentImage::draw):
Update the cached image if needed.
Paint the cached image into the context if it's available (which it might not be,
if the image is way too big and the allocation fails). Otherwise, paint straight
into the context as we previously did.
(WebCore::PDFDocumentImage::destroyDecodedData):
Throw away the cached image if requested.
(WebCore::PDFDocumentImage::decodedSize):
(WebCore::PDFDocumentImage::drawPDFPage):
Drive-by use GraphicsContext instead of CG directly.
- platform/graphics/cg/PDFDocumentImage.h:
(WebCore::PDFDocumentImage::create):
Override isPDFDocumentImage().
Add storage for the cached image buffer and various cache parameters.
- rendering/ImageQualityController.cpp:
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
PDFDocumentImage is also interested in/capable of low-quality painting now.
Add a test ensuring that very large PDF-in-<img> elements don't crash.
- fast/images/pdf-as-image-too-big-expected.txt: Added.
- fast/images/pdf-as-image-too-big.html: Added.
- 5:33 PM Changeset in webkit [155664] by
-
- 2 edits in trunk/Source/WebCore
Image doesn't always repaint at high quality in all tiles after a live resize
https://bugs.webkit.org/show_bug.cgi?id=121244
Reviewed by Darin Adler.
Currently, ImageQualityController removes an image from its low-quality-images
list from inside shouldPaintAtLowQuality, if this is the first paint outside
of a live resize, but does not force the renderer to repaint in its entirety.
However, there's no guarantee we've invalidated the whole renderer, so this can
leave some parts of the image painted in low-quality.
This just removes a short-circuit, instead using the ordinary high-quality-repaint
timer to ensure that the entire renderer is repainted.
No new test; all attempts have failed, as this depends on tiled drawing
and a live resize occurring.
- rendering/ImageQualityController.cpp:
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
- 5:23 PM Changeset in webkit [155663] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Speculative build fix after r155638.
- platform/efl/PasteboardEfl.cpp: Add include for PassRefPtr, which
is no longer implicitly included.
- 4:57 PM Changeset in webkit [155662] by
-
- 5 edits in trunk/Source/JavaScriptCore
DFG::Int32Operand and fillInt32() should go away and all uses should be replaced with SpeculateInt32Operand
https://bugs.webkit.org/show_bug.cgi?id=121268
Reviewed by Oliver Hunt.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
- 4:30 PM Changeset in webkit [155661] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Duplicated color swatches changing autocompletes color names
https://bugs.webkit.org/show_bug.cgi?id=121265
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-12
Reviewed by Timothy Hatcher.
CodeMirror bookmarks at position used to be unique but no longer are.
Define an extension to give us unique bookmarks as we expected, and
update all the old locations using setBookmark.
- UserInterface/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype.didDismissPopover):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._updateTextMarkers):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):
(WebInspector.CSSStyleDeclarationTextEditor.prototype):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.event.newColorText):
- UserInterface/CodeMirrorAdditions.js:
- 4:28 PM Changeset in webkit [155660] by
-
- 6 edits in trunk/Source
Avoid extra scrollbar-related layouts for overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=121267
Source/WebCore:
Reviewed by Beth Dakin.
If ScrollView::updateScrollbars() detected that scrollbars were added
and removed, it would call contentsResized(), which calls setNeedsLayout(),
followed by visibleContentsResized() which would trigger layout. There is no
point doing this with overlay scrollbars, so avoid it by having
setHas*Scrollbar() return true if the addition/removal of a scrollbar changed
the available width.
No tests: we can't test overlay scrollbars in tests.
- page/FrameView.cpp:
(WebCore::FrameView::setContentsSize): Drive-by assertion that
checks that the unsigned m_deferSetNeedsLayouts doesn't wrap when
decremented.
- platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar): Return true if the addition/removal
changed available space.
(WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
(WebCore::ScrollView::updateScrollbars): Only set sendContentResizedNotification
if available space was changed by addition/removal of scrollbars.
- platform/ScrollView.h:
Source/WebKit2:
Reviewed by Beth Dakin.
view->resize() will call setNeedsLayout() if necessary, and may already have
done layout, so the extra setNeedsLayout() here was bad.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setSize):
- 4:27 PM Changeset in webkit [155659] by
-
- 16 edits in trunk/Source/WebInspectorUI
Web Inspector: Update CodeMirror for gutter fix
https://bugs.webkit.org/show_bug.cgi?id=121262
Update CodeMirror to 757944449 to fix gutter click issue:
<https://github.com/marijnh/CodeMirror/issues/1807>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-12
Reviewed by Timothy Hatcher.
- Tools/PrettyPrinting/CodeMirrorFormatters.js:
- Tools/PrettyPrinting/FormatterContentBuilder.js:
(FormatterContentBuilder.prototype._appendIndent):
- Tools/PrettyPrinting/codemirror.css:
- Tools/PrettyPrinting/codemirror.js:
- Tools/PrettyPrinting/css.js:
- UserInterface/CodeMirrorAdditions.js:
- UserInterface/CodeMirrorFormatters.js:
- UserInterface/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype.didRemoveBreakpoint):
(WebInspector.DebuggerManager.prototype._removeBreakpoint):
- UserInterface/External/CodeMirror/codemirror.css:
- UserInterface/External/CodeMirror/codemirror.js:
- UserInterface/External/CodeMirror/coffeescript.js:
- UserInterface/External/CodeMirror/css.js:
- UserInterface/External/CodeMirror/less.js:
- UserInterface/External/CodeMirror/sql.js:
- UserInterface/TextEditor.js:
(WebInspector.TextEditor.prototype.hasFormatter):
- 4:25 PM Changeset in webkit [155658] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Update License copyrights in minified JavaScript
https://bugs.webkit.org/show_bug.cgi?id=121264
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-12
Reviewed by Timothy Hatcher.
- Scripts/copy-user-interface-resources.sh:
- 4:07 PM Changeset in webkit [155657] by
-
- 7 edits in trunk
Source/JavaScriptCore: Web Inspector shouldn't artificially allocate the arguments object in functions that don't use it
https://bugs.webkit.org/show_bug.cgi?id=121206
<rdar://problem/6911886>
Reviewed by Joseph Pecoraro.
This is a step toward better tools, and a 23% speedup in a simple
JavaScript benchmark run with the Web Inspector open.
We want the Web Inspector to be fast, and we want it to produce reliable
CPU and memory profiles. We can't do that if just opening the Web Inspector
incurs huge CPU/memory penalties like the arguments object.
Also, since use of the 'arguments' identifier is an API for allocating
an object, I think it's good for the UI to let developers know when
they've invoked that API and when they haven't.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator): No need to allocate the
arguments object artificially for the debugger's sake. The activation
object no longer assumes that the stack frame is laid out for one.
(Long-term, this code will move out of the activation object, into a
special object for interfacing with the debugger.)
- runtime/JSActivation.cpp:
(JSC::JSActivation::getOwnNonIndexPropertyNames):
(JSC::JSActivation::getOwnPropertySlot): Don't advertise or provide an
arguments object if the user function didn't include one. The bytecode
generator will not have laid out the stack frame to support one.
(Eventually, we do want the Web Inspector to see an arguments
object in scope in the console. That's a one-line change in JSActivation,
but it's blocked by https://bugs.webkit.org/show_bug.cgi?id=121208.)
(JSC::JSActivation::argumentsGetter):
- runtime/JSActivation.h: Removed this obsolete performance
work-around. C++ property access to an activation object is no longer
hot.
LayoutTests: Web Inspector shouldn't artificially allocate the arguments object in functions that don't use it
https://bugs.webkit.org/show_bug.cgi?id=121206
Reviewed by Joseph Pecoraro.
<rdar://problem/6911886>
- inspector/debugger/debugger-expand-scope-expected.txt: Updated these
results to reflect the fact that it's correct to exclude the 'arguments'
identifier from function scopes that don't use it.
- inspector/debugger/debugger-expand-scope.html: Edited this test to
include one frame that uses the 'arguments' identifier and one frame
that doesn't, so we test both cases.
- 4:03 PM Changeset in webkit [155656] by
-
- 2 edits in trunk/Tools
Create short build logs for errors and warnings.
https://bugs.webkit.org/show_bug.cgi?id=120614
Reviewed by Ryosuke Niwa.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
-include StringIO
(CompileWebKit.createSummary):
-add a createSummary function which will parse out errors and warnings into a concise log file for quick viewing
- 3:55 PM Changeset in webkit [155655] by
-
- 3 edits in trunk/Source/WebCore
[CSS Shapes] Rename shapeContainingBlockHeight to shapeContainingBlockLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=121252
Reviewed by Oliver Hunt.
No new tests, no behavior change.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::pushShapeContentOverflowBelowTheContentBox):
- rendering/shapes/ShapeInfo.h:
(WebCore::ShapeInfo::shapeContainingBlockLogicalHeight):
- 3:46 PM Changeset in webkit [155654] by
-
- 3 edits in trunk/Tools
Update cygwin downloader to search for packages in the right location.
- CygwinDownloader/cygwin-downloader.py:
- CygwinDownloader/cygwin-downloader.zip:
- 3:41 PM Changeset in webkit [155653] by
-
- 5 edits in trunk
<meter> element AXValue is listed as a writable value
https://bugs.webkit.org/show_bug.cgi?id=117650
Patch by Samuel White <Samuel White> on 2013-09-12
Reviewed by Chris Fleizach.
Source/WebCore:
No new tests, updated existing accessibility/meter-element.html test
to check writability. Changed meter element value to be unwritable.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::canSetValueAttribute):
LayoutTests:
Added writability check to meter element test.
- accessibility/meter-element.html:
- platform/mac/accessibility/meter-element-expected.txt:
- 3:39 PM Changeset in webkit [155652] by
-
- 3 edits in trunk/Source/JavaScriptCore
Rolling out r155632
Broke some tests.
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper):
- heap/MarkedBlock.h:
- 3:09 PM Changeset in webkit [155651] by
-
- 3 edits3 adds in trunk
[Qt] SHOULD NEVER BE REACHED is touched WebCore::InputType::createStepRange
https://bugs.webkit.org/show_bug.cgi?id=121148
Reviewed by Kent Tamura.
Source/WebCore:
Non-steppable input types must not rendered as slider even if its webkit-apperance style
property is set to slider-vertical/horizontal.
Test: platform/qt/fast/forms/range/slider-crash-on-input.html
- platform/qt/RenderThemeQStyle.cpp:
(WebCore::RenderThemeQStyle::paintSliderTrack):
LayoutTests:
Trying to render text input as slider-vertical. Expecting to run without crash.
- platform/qt/fast/forms/range/slider-crash-on-input.html: Added.
- platform/qt/platform/qt/fast/forms/range/slider-crash-on-input-expected.txt: Added.
- 2:40 PM Changeset in webkit [155650] by
-
- 2 edits in trunk/LayoutTests
Canvas fillText and measureText handle ideographic spaces differently
https://bugs.webkit.org/show_bug.cgi?id=108881
Fixing the test:
- Updated paths to js-test scripts.
- Removed "meta charcode" - we don't need to specify a charset here, and it's
"charset", not "charcode" anyway.
- fast/canvas/canvas-measureText-ideographicSpace.html:
- 2:04 PM Changeset in webkit [155649] by
-
- 4 edits in trunk/Source
Source/JavaScriptCore: Qt build fix. Add a return to make the compiler happy.
- dfg/DFGGPRInfo.h:
(JSC::DFG::JSValueRegs::gpr):
Source/WebCore: Qt and Windows build fix.
- page/animation/CSSPropertyAnimation.cpp:
- 2:02 PM Changeset in webkit [155648] by
-
- 5 edits in trunk/LayoutTests
svg/animations/smil-leak-*.svg tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=114280
Reviewed by Tim Horton.
Moved garbage collection out of the function that touches nodes to be collected,
making sure that they are definitely not on the stack.
I could not reproduce locally, so this is a speculative fix.
- svg/animations/smil-leak-dynamically-added-element-instances.svg:
- svg/animations/smil-leak-element-instances-noBaseValRef.svg:
- svg/animations/smil-leak-element-instances.svg:
- svg/animations/smil-leak-elements.svg:
- 1:52 PM Changeset in webkit [155647] by
-
- 4 edits in trunk/Source/WebCore
Encapsulate globals in CSSPropertyAnimation.cpp
https://bugs.webkit.org/show_bug.cgi?id=121205
Reviewed by Antti Koivisto.
Encapsulated the globals inside a newly added CSSPropertyAnimationWrapperMap. Also removed the circular
dependency from ShorthandPropertyWrapper's constructor to CSSPropertyAnimationWrapperMap::instance().
The circular dependency still exists in ensurePropertyMap but I'm going to remove it in the bug 121199.
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::ShorthandPropertyWrapper::ShorthandPropertyWrapper): Takes a Vector of longhand wrappers instead of
calling wrapperForProperty in the middle of constructing the very table. This circular dependency is now
encapsulated in CSSPropertyAnimationWrapperMap::ensurePropertyMap.
(WebCore::CSSPropertyAnimationWrapperMap::instance): Added.
(WebCore::CSSPropertyAnimationWrapperMap::wrapperForProperty): Renamed from WebCore::wrapperForProperty.
(WebCore::CSSPropertyAnimationWrapperMap::wrapperForIndex): Added.
(WebCore::CSSPropertyAnimationWrapperMap::size): Added.
(WebCore::CSSPropertyAnimationWrapperMap::addPropertyWrapper): Renamed from WebCore::addPropertyWrapper. Also
cleaned up boolean logics to use early exits instead of nested ifs.
(WebCore::CSSPropertyAnimationWrapperMap::addShorthandProperties): Renamed from WebCore::addShorthandProperties.
(WebCore::CSSPropertyAnimationWrapperMap::ensurePropertyMap): Renamed from WebCore::ensurePropertyMap.
Added an alias gPropertyWrappers for m_propertyWrappers; this aliasing will be removed in the bug 121199.
(WebCore::CSSPropertyAnimation::blendProperties):
(WebCore::CSSPropertyAnimation::animationOfPropertyIsAccelerated):
(WebCore::CSSPropertyAnimation::animatableShorthandsAffectingProperty):
(WebCore::CSSPropertyAnimation::propertiesEqual):
(WebCore::CSSPropertyAnimation::getPropertyAtIndex):
(WebCore::CSSPropertyAnimation::getNumProperties):
- page/animation/CSSPropertyAnimation.h:
- rendering/style/RenderStyle.h:
- 1:42 PM Changeset in webkit [155646] by
-
- 4 edits3 deletes in trunk/LayoutTests
Flaky Test: plugins/mouse-events.html
https://bugs.webkit.org/show_bug.cgi?id=116665
Reviewed by Anders Carlsson.
- plugins/mouse-events-expected.txt:
- plugins/mouse-events.html:
This test used async calls for events, and then usually logged responses while waiting
for a plg.eventLoggingEnabled setter synchronously. Depending on sync/async event
order is not reliable, especially with old WebKit1 plug-in IPC code.
- platform/mac-wk2/plugins/mouse-events-expected.txt: For some unclear reason,
focus works differently in WebKit2.
- platform/gtk/plugins/mouse-events-expected.txt: Removed.
- platform/qt/plugins/mouse-events-expected.txt: Removed.
- platform/win/plugins/mouse-events-expected.txt: Removed.
These results looked similar to new cross-platform ones, hopefully custom results
won't be needed any more.
- 1:40 PM Changeset in webkit [155645] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG::GenerationInfo init/fill methods shouldn't duplicate a bunch of logic
https://bugs.webkit.org/show_bug.cgi?id=121253
Reviewed by Oliver Hunt.
- dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::initGPR):
(JSC::DFG::GenerationInfo::initInt32):
(JSC::DFG::GenerationInfo::initJSValue):
(JSC::DFG::GenerationInfo::initCell):
(JSC::DFG::GenerationInfo::initBoolean):
(JSC::DFG::GenerationInfo::initStorage):
(JSC::DFG::GenerationInfo::fillGPR):
(JSC::DFG::GenerationInfo::fillJSValue):
(JSC::DFG::GenerationInfo::fillCell):
(JSC::DFG::GenerationInfo::fillInt32):
(JSC::DFG::GenerationInfo::fillBoolean):
(JSC::DFG::GenerationInfo::fillStorage):
- 1:13 PM Changeset in webkit [155644] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, fix mispelling (Specualte -> Speculate) that I introduced in an
earlier patch.
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculateInt32Operand::gpr):
(JSC::DFG::SpeculateStrictInt32Operand::gpr):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Strict):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Strict):
- 1:07 PM Changeset in webkit [155643] by
-
- 7 edits in trunk/Source/JavaScriptCore
GPRTemporary's reuse constructor should be templatized to reduce code duplication, and the bool to denote tag or payload should be replaced with an enum
https://bugs.webkit.org/show_bug.cgi?id=121250
Reviewed by Oliver Hunt.
- dfg/DFGGPRInfo.h:
(JSC::DFG::JSValueRegs::gpr):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::GPRTemporary::GPRTemporary):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileStringEquality):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::JSValueOperand::gpr):
(JSC::DFG::GPRTemporary::GPRTemporary):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileIntegerCompare):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::compile):
- runtime/JSCJSValue.h:
- 1:00 PM Changeset in webkit [155642] by
-
- 3 edits in trunk/Source/WebKit2
Web Inspector: Do not try to parse incomplete HTTP requests
https://bugs.webkit.org/show_bug.cgi?id=121123
Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-09-12
Reviewed by Darin Adler.
When working on a patch for bug #121121 I found an issue with the InspectorServer where it would try
to parse an HTTP message before receiving the full message and thus fail connecting with the
chromedevtools plugin.
What happens is that the WebSocketServerConnection receives buffers on
WebSocketServerConnection::didReceiveSocketStreamData and calls
WebSocketServerConnection::readHTTPMessage which then checks if we have a valid request by calling
HTTPRequest::parseHTTPRequestFromBuffer. If the request is valid it tries to parse the message and
clears the buffer, otherwise it continues adding data to the internal buffer until we have a valid
request.
The problem is that currently HTTPRequest::parseHTTPRequestFromBuffer considers the request as valid
before receiving the full message. To solve this we should make the method check if the request
headers end with a blank line otherwise we consider the request as invalid (see also
http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html).
- UIProcess/API/gtk/tests/TestInspectorServer.cpp:
(sendIncompleteRequest):
(beforeAll):
Add GTK specific test to check if the inspector server replies to incomplete requests.
- UIProcess/InspectorServer/HTTPRequest.cpp:
(WebKit::HTTPRequest::parseHeaders):
Do not consider request valid if headers didn't end with a blank line.
- 12:52 PM Changeset in webkit [155641] by
-
- 16 edits in trunk/Source
SharedBuffer::createNSData should return a RetainPtr<NSData>
https://bugs.webkit.org/show_bug.cgi?id=121237
Reviewed by Darin Adler.
Source/WebCore:
This makes memory management cleared and fixes a leak in PDFDocumentImage::createPDFDocument.
We use a RetainPtr subclass as a stopgap measure to prevent code that does [buffer->createNSData() autorelease]
from compiling and crashing due to the NSData object being overreleased.
- loader/ResourceBuffer.h:
- loader/mac/ResourceBuffer.mm:
(WebCore::ResourceBuffer::createNSData):
- platform/SharedBuffer.h:
(WebCore::SharedBuffer::NSDataRetainPtr::NSDataRetainPtr):
- platform/graphics/mac/PDFDocumentImageMac.mm:
(WebCore::PDFDocumentImage::createPDFDocument):
- platform/mac/HTMLConverter.mm:
(-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
(fileWrapperForURL):
- platform/mac/PasteboardMac.mm:
(WebCore::fileWrapper):
(WebCore::Pasteboard::read):
(WebCore::documentFragmentWithRTF):
(WebCore::fragmentFromWebArchive):
- platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::setBufferForType):
- platform/mac/SharedBufferMac.mm:
(WebCore::SharedBuffer::createNSData):
Source/WebKit/mac:
Update for WebCore changes. This also fixes a leak where we'd create an NSFileWrapper from NSData but never release the data.
- WebView/WebDataSource.mm:
(-[WebDataSource data]):
- WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation documentSource]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
- WebView/WebResource.mm:
(-[WebResource encodeWithCoder:]):
(-[WebResource data]):
Source/WebKit2:
Update for WebCore changes.
- UIProcess/API/mac/WKView.mm:
(-[WKView writeSelectionToPasteboard:types:]):
(-[WKView _setPromisedData:WebCore::withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:WebCore::forPasteboard:]):
(-[WKView namesOfPromisedFilesDroppedAtDestination:]):
- 12:48 PM Changeset in webkit [155640] by
-
- 2 edits in trunk/Source/WTF
Bitmap's WordType should be a template parameter
https://bugs.webkit.org/show_bug.cgi?id=121238
Reviewed by Darin Adler.
The code is written as if it already is. We just need to lift it out of the class.
This simplifies code that wants to load, for example, a single byte rather than an
entire 32-bit word.
- wtf/Bitmap.h:
(WTF::Bitmap::Bitmap):
(WTF::Bitmap::get):
(WTF::Bitmap::set):
(WTF::Bitmap::testAndSet):
(WTF::Bitmap::testAndClear):
(WTF::Bitmap::concurrentTestAndSet):
(WTF::Bitmap::concurrentTestAndClear):
(WTF::Bitmap::clear):
(WTF::Bitmap::clearAll):
(WTF::Bitmap::nextPossiblyUnset):
(WTF::Bitmap::findRunOfZeros):
(WTF::Bitmap::count):
(WTF::Bitmap::isEmpty):
(WTF::Bitmap::isFull):
- 12:48 PM Changeset in webkit [155639] by
-
- 9 edits in trunk/Source/WebCore
Remove more Timeline stuff we don't use
https://bugs.webkit.org/show_bug.cgi?id=121246
Reviewed by Joseph Pecoraro.
- inspector/InspectorController.cpp:
- inspector/InspectorController.h:
- inspector/InspectorDOMDebuggerAgent.cpp:
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
- inspector/InspectorTimelineAgent.h:
- 12:23 PM Changeset in webkit [155638] by
-
- 7 edits2 adds in trunk/Source/WebCore
[EFL] Get rid of layering violations in PasteboardEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=121241
Patch by Christophe Dumez <Christophe Dumez> on 2013-09-12
Reviewed by Darin Adler.
Get rid of layering violations in PasteboardEfl.cpp. For now, just mimic
the Mac port to avoid divergences and leave port-specific functions
unimplemented as the EFL port does not support the pasteboard functionality
yet.
No new tests, no behavior change.
- PlatformEfl.cmake:
- editing/Editor.cpp:
(WebCore::Editor::pasteAsPlainTextWithPasteboard):
(WebCore::Editor::cut):
(WebCore::Editor::copy):
(WebCore::Editor::copyURL):
(WebCore::Editor::copyImage):
- editing/Editor.h:
- editing/efl/EditorEfl.cpp: Added.
(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::Editor::writeURLToPasteboard):
(WebCore::Editor::writeImageToPasteboard):
(WebCore::Editor::readPlainTextFromPasteboard):
(WebCore::Editor::pasteWithPasteboard):
- page/DragController.cpp:
(WebCore::DragController::startDrag):
- platform/Pasteboard.h:
- platform/efl/PasteboardEfl.cpp:
- 12:21 PM Changeset in webkit [155637] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Unreviewed build fix after r155635.
Include DragData.h
- platform/gtk/PasteboardGtk.cpp:
- 12:13 PM Changeset in webkit [155636] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Build fix after r155635.
Rubber Stamped by Darin Adler.
- platform/Pasteboard.h: Add missing compile guards for Windows port.
- 11:57 AM FTLJIT edited by
- (diff)
- 11:56 AM FTLJIT edited by
- (diff)
- 11:52 AM FTLJIT edited by
- (diff)
- 11:44 AM FTLJIT edited by
- (diff)
- 11:43 AM FTLJIT edited by
- (diff)
- 11:43 AM FTLJIT created by
- 11:39 AM Changeset in webkit [155635] by
-
- 4 edits in trunk/Source/WebCore
Reorganize Pasteboard.h to make it easier to read, and express plan for future work
https://bugs.webkit.org/show_bug.cgi?id=121234
Reviewed by Anders Carlsson.
- platform/Pasteboard.h: Move Mac/iOS-specific pasteboard names to the bottom of the
file rather than putting them up with forward declarations before the class. Removed
unneeded forward class declarations. Changed #if statements about migration to the
more modern non-layering-violation API to list platforms not yet migrated, rather than
listing platforms that have migrated (Mac). Move conditional code down below the
uncondiditional code so it's easier to see what the class is doing. Move layering-
violation code down to the bottom too, so it's easier to see the future class without
having the design mistakes mixed in. Sort platform-specific sections in alphabetical
order instead of random order. Did the destructor in a cleaner way so the #if is out
of the way after the class rather than in the class. Removed WebSmartPastePboardType,
WebURLPboardType, and WebURLsWithTitlesPboard declarations, since they are only used
inside the PasteboardMac.mm source file.
- platform/ios/PasteboardIOS.mm: Aded a FIXME comment.
- platform/mac/PasteboardMac.mm: Made the constants for pasteboard types be actual
constants, rather than global variables.
- 11:33 AM JavaScriptCore edited by
- (diff)
- 11:29 AM Changeset in webkit [155634] by
-
- 2 edits in trunk/Source/WebCore
[curl] Use utf8 for headers in CurlDownload.
https://bugs.webkit.org/show_bug.cgi?id=120413
Patch by Tamas Czene <tczene@inf.u-szeged.hu> on 2013-09-12
Reviewed by Brent Fulgham.
- platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::headerCallback):
- 11:26 AM Changeset in webkit [155633] by
-
- 7 edits2 adds in trunk/Source/WebCore
[curl] Improve multipart response handling
https://bugs.webkit.org/show_bug.cgi?id=117735
Reviewed by Brent Fulgham.
The multipart/x-mixed-replace mime type in responses are ignored
with the curl network backend. To handle such responses the
MultipartHandle is introduced which will split the content using
the boundary specified by the mime type.
There are already existing tests (http/tests/multipart).
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- platform/network/HTTPParsers.cpp:
(WebCore::parseHTTPHeader):
- platform/network/HTTPParsers.h:
- platform/network/ResourceHandleInternal.h:
- platform/network/curl/MultipartHandle.cpp: Added.
(WebCore::MultipartHandle::extractBoundary):
(WebCore::MultipartHandle::matchForBoundary):
(WebCore::MultipartHandle::checkForBoundary):
(WebCore::MultipartHandle::parseHeadersIfPossible):
(WebCore::MultipartHandle::contentReceived):
(WebCore::MultipartHandle::processContent):
(WebCore::MultipartHandle::contentEnded):
(WebCore::MultipartHandle::didReceiveData):
(WebCore::MultipartHandle::didReceiveResponse):
- platform/network/curl/MultipartHandle.h: Added.
(WebCore::MultipartHandle::MultipartHandle):
(WebCore::MultipartHandle::~MultipartHandle):
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::writeCallback):
(WebCore::headerCallback):
(WebCore::ResourceHandleManager::downloadTimerCallback):
- 11:13 AM Changeset in webkit [155632] by
-
- 3 edits in trunk/Source/JavaScriptCore
MarkedBlocks shouldn't be put in Allocated state if they didn't produce a FreeList
https://bugs.webkit.org/show_bug.cgi?id=121236
Reviewed by Geoffrey Garen.
Right now, after a collection all MarkedBlocks are in the Marked block state. When lazy sweeping
happens, if a block returns an empty free list after being swept, we call didConsumeFreeList(),
which moves the block into the Allocated block state. This happens to both the block that was
just being allocated out of (i.e. m_currentBlock) as well as any blocks who are completely full.
We should distinguish between these two cases: m_currentBlock should transition to
Allocated (because we were just allocating out of it) and any subsequent block that returns an
empty free list should transition back to the Marked state. This will make the block state more
consistent with the actual state the block is in, and it will also allow us to speed up moving
all blocks to the Marked state during generational collection.
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper):
- heap/MarkedBlock.h:
(JSC::MarkedBlock::didConsumeEmptyFreeList):
- 10:54 AM Changeset in webkit [155631] by
-
- 15 edits2 deletes in trunk/Source
Remove RenderApplet.
<https://webkit.org/b/121231>
Reviewed by Darin Adler.
Add a RenderEmbeddedObject::createForApplet(HTMLAppletElement&) and nuke
the RenderApplet class from orbit.
- 10:46 AM Changeset in webkit [155630] by
-
- 5 edits in trunk/Source/WebCore
[Windows] Build fix after r155621
Rubber-stamped by Anders Carlsson.
See also https://bugs.webkit.org/show_bug.cgi?id=121235 for
why this was necessary.
- css/MediaQueryEvaluator.cpp: Work around VS compiler bug.
- dom/make_names.pl: Ditto.
- loader/archive/ArchiveFactory.cpp: Ditto.
- rendering/svg/SVGPathData.cpp: Ditto.
- 10:38 AM Changeset in webkit [155629] by
-
- 13 edits in trunk/Source
SharedBuffer::createCFData should return RetainPtr<CFDataRef>
https://bugs.webkit.org/show_bug.cgi?id=121230
Reviewed by Darin Adler.
Source/WebCore:
- loader/ResourceBuffer.cpp:
(WebCore::ResourceBuffer::createCFData):
- loader/ResourceBuffer.h:
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::createPropertyListRepresentation):
(WebCore::LegacyWebArchive::create):
- platform/SharedBuffer.h:
- platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer::createCFData):
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::setData):
- platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::createPDFDocument):
- platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
- platform/mac/SharedBufferMac.mm:
(WebCore::SharedBuffer::createCFData):
Source/WebKit2:
- NetworkProcess/mac/NetworkResourceLoaderMac.mm:
(WebKit::NetworkResourceLoader::tryGetShareableHandleFromSharedBuffer):
- Shared/WebArchiveResource.cpp:
(WebKit::WebArchiveResource::data):
- 9:57 AM Changeset in webkit [155628] by
-
- 6 edits1 add in trunk/Source/WebCore
Move LineInfo class into LineInfo.h
https://bugs.webkit.org/show_bug.cgi?id=121191
Reviewed by David Hyatt.
No new tests, no behavior change.
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/LineInfo.h: Added.
(WebCore::LineInfo::LineInfo):
(WebCore::LineInfo::isFirstLine):
(WebCore::LineInfo::isLastLine):
(WebCore::LineInfo::isEmpty):
(WebCore::LineInfo::previousLineBrokeCleanly):
(WebCore::LineInfo::floatPaginationStrut):
(WebCore::LineInfo::runsFromLeadingWhitespace):
(WebCore::LineInfo::resetRunsFromLeadingWhitespace):
(WebCore::LineInfo::incrementRunsFromLeadingWhitespace):
(WebCore::LineInfo::setFirstLine):
(WebCore::LineInfo::setLastLine):
(WebCore::LineInfo::setEmpty):
(WebCore::LineInfo::setPreviousLineBrokeCleanly):
(WebCore::LineInfo::setFloatPaginationStrut):
- rendering/RenderBlockLineLayout.cpp:
- 9:50 AM Changeset in webkit [155627] by
-
- 7 edits in trunk/Source/WebCore
[CSS Shapes] Remove unnecessarily complex template from ShapeInfo classes
https://bugs.webkit.org/show_bug.cgi?id=121213
Reviewed by Darin Adler.
These classes were trying to be way too clever, and as a result were
hard to read and hard to debug. Replace the complex templated method
calls with virtual methods to make these classes much easier to
understand and maintain.
No new tests, no behavior change.
- rendering/shapes/ShapeInfo.cpp:
(WebCore::::computedShape):
(WebCore::::computeSegmentsForLine):
- rendering/shapes/ShapeInfo.h:
- rendering/shapes/ShapeInsideInfo.cpp:
(WebCore::ShapeInsideInfo::getShapeValue):
- rendering/shapes/ShapeInsideInfo.h:
(WebCore::ShapeInsideInfo::computeSegmentsForLine):
(WebCore::ShapeInsideInfo::ShapeInsideInfo):
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::computeSegmentsForLine):
(WebCore::ShapeOutsideInfo::getShapeValue):
- rendering/shapes/ShapeOutsideInfo.h:
(WebCore::ShapeOutsideInfo::ShapeOutsideInfo):
- 9:49 AM Changeset in webkit [155626] by
-
- 3 edits in trunk/Source/WebCore
[CSS Shapes] Turn shape's logicalwidth/height into a LayoutSize
https://bugs.webkit.org/show_bug.cgi?id=121187
Reviewed by David Hyatt.
No new tests, no behavior change.
- rendering/shapes/ShapeInfo.cpp:
(WebCore::::computedShape):
- rendering/shapes/ShapeInfo.h:
(WebCore::ShapeInfo::setShapeSize):
(WebCore::ShapeInfo::shapeContainingBlockHeight):
- 9:47 AM Changeset in webkit [155625] by
-
- 7 edits in trunk/Source/WebCore
Move layering-violating code from Pasteboard::plainText into Editor (Mac only at first)
https://bugs.webkit.org/show_bug.cgi?id=121075
Reviewed by Anders Carlsson.
- editing/Editor.cpp:
(WebCore::Editor::pasteAsPlainTextBypassingDHTML): Pass pasteboard as a reference.
(WebCore::Editor::pasteAsPlainTextWithPasteboard): Use readPlainTextFromPasteboard
for Mac. Also update to take a reference.
(WebCore::Editor::paste): Pass pasteboard as a reference.
(WebCore::Editor::pasteAsPlainText): Ditto.
- editing/Editor.h: Ditto.
- editing/mac/EditorMac.mm:
(WebCore::Editor::readSelectionFromPasteboard): Pass pasteboard as a reference.
(WebCore::Editor::readPlainTextFromPasteboard): Added. The declaration of this
was added (by mistake) in an earlier patch. This has code that used to be inside
Pasteboard::plainText.
- platform/Pasteboard.h: Added PasteboardPlainText. Reorganized functions in the
Pasteboard class and added some FIXMEs. Sorted platforms alphabetically and grouped
functions together and data members separate from them.
- platform/mac/DragDataMac.mm:
(WebCore::DragData::asPlainText): Updated to call readPlainTextFromPasteboard.
(WebCore::DragData::asURL): Tweaked style of unused parameter.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::read): Renamed this from plainText, and refactored so that
the data goes out in the PasteboardPlainText structure.
- 9:44 AM Changeset in webkit [155624] by
-
- 6 edits8 adds in trunk
CSS Unit vw in border-width maps to 0px.
https://bugs.webkit.org/show_bug.cgi?id=109229
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-12
Reviewed by Darin Adler.
Source/WebCore:
Border and outline properties were not applied incase
its values were given in vh/vw units.
Tests: fast/css/viewport-height-border.html
fast/css/viewport-height-outline.html
fast/css/viewport-width-border.html
fast/css/viewport-width-outline.html
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLengthDouble):
Added case CSS_VH and CSS_VW.
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isViewportPercentageWidth):
(WebCore::CSSPrimitiveValue::isViewportPercentageHeight):
Added APIs to check the unit type(CSS_VW and CSS_VH).
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyComputeLength::applyValue):
Calculating the border values which has been specified
in vh/vw units.The vh/vw units are calcultated as percent
of viewport height and viewport width respectively.
LayoutTests:
- fast/css/viewport-height-border-expected.txt: Added.
- fast/css/viewport-height-border.html: Added.
- fast/css/viewport-height-outline-expected.txt: Added.
- fast/css/viewport-height-outline.html: Added.
- fast/css/viewport-width-border-expected.txt: Added.
- fast/css/viewport-width-border.html: Added.
- fast/css/viewport-width-outline-expected.txt: Added.
- fast/css/viewport-width-outline.html: Added.
Added new tests for verifying that border and outline properties are
applied when its values are given in vh/vw units.
- resources/js-test-pre.js:
(shouldNotBeEqualToString):
Added this API so that can compare two strings.Similiar to
shouldBeEqualToString.
- 9:42 AM Changeset in webkit [155623] by
-
- 2 edits in trunk/Source/WebCore
[Coordinated Graphics] Fix the build on MacOS 10.9
https://bugs.webkit.org/show_bug.cgi?id=121225
Reviewed by Darin Adler.
- platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
- 9:27 AM Changeset in webkit [155622] by
-
- 15 edits in trunk/Source
Change debug hooks to pass sourceID and position info via the DebuggerCallFrame.
https://bugs.webkit.org/show_bug.cgi?id=121214.
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- debugger/Debugger.h:
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::sourceId):
(JSC::DebuggerCallFrame::clear):
- debugger/DebuggerCallFrame.h:
(JSC::DebuggerCallFrame::DebuggerCallFrame):
(JSC::DebuggerCallFrame::line):
(JSC::DebuggerCallFrame::column):
- interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
(JSC::Interpreter::unwind):
(JSC::Interpreter::debug):
Source/WebCore:
No new tests.
Also changed the Inspector's JavaScriptCallFrame to get the sourceID and
position info from its DebuggerCallFrame instead of caching those values.
- bindings/js/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
- bindings/js/JavaScriptCallFrame.h:
(WebCore::JavaScriptCallFrame::create):
(WebCore::JavaScriptCallFrame::invalidate):
(WebCore::JavaScriptCallFrame::sourceID):
(WebCore::JavaScriptCallFrame::position):
(WebCore::JavaScriptCallFrame::line):
(WebCore::JavaScriptCallFrame::column):
(WebCore::JavaScriptCallFrame::update):
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::createCallFrame):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::callEvent):
(WebCore::ScriptDebugServer::atStatement):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::exception):
(WebCore::ScriptDebugServer::willExecuteProgram):
(WebCore::ScriptDebugServer::didExecuteProgram):
(WebCore::ScriptDebugServer::didReachBreakpoint):
- bindings/js/ScriptDebugServer.h:
- bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::willExecuteProgram):
- bindings/js/WorkerScriptDebugServer.h:
Source/WebKit/mac:
- webview/WebScriptDebugger.h:
- WebView/WebScriptDebugger.mm:
(WebScriptDebugger::WebScriptDebugger):
(WebScriptDebugger::callEvent):
(WebScriptDebugger::atStatement):
(WebScriptDebugger::returnEvent):
(WebScriptDebugger::exception):
(WebScriptDebugger::willExecuteProgram):
(WebScriptDebugger::didExecuteProgram):
(WebScriptDebugger::didReachBreakpoint):
- 9:13 AM Changeset in webkit [155621] by
-
- 5 edits in trunk
Add rudimentary support for move-only types as values in HashMap
https://bugs.webkit.org/show_bug.cgi?id=121226
Reviewed by Andreas Kling.
Source/WTF:
- wtf/HashMap.h:
Change a bunch of functions to so they can take both rvalue and lvalue references and use std::forward.
- wtf/HashTraits.h:
(WTF::KeyValuePair::KeyValuePair):
Change constructors to accept both lvalues and rvalues.
Tools:
- TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::TEST):
Add a HashMap<unsigned, MoveOnly> test.
- 9:07 AM Changeset in webkit [155620] by
-
- 3 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk
Merge r155619 - [GTK][WK1] Block accelerated compositing under non-X11 displays
https://bugs.webkit.org/show_bug.cgi?id=121165
Reviewed by Martin Robinson.
This is analogous to the changes in r154728 and r154729 that enforce disabling accelerated compositing
under Wayland displays and made the RedirectedXCompositeWindow use in WebKit2 limited only to the X11 displays.
- WebCoreSupport/AcceleratedCompositingContextGL.cpp: Remove two unnecessary header includes that also
introduce symbols that conflict with the symbols defined in the X headers. Include the <gdk/gdkx.h> header
if the GTK+ dependency can provide it.
(WebKit::AcceleratedCompositingContext::initialize): Only set up the RedirectedXCompositeWindow instance
if running under an X11 display.
(WebKit::AcceleratedCompositingContext::renderLayersToWindow): The removal of the unnecessary header
inclusions also removed the std::max() injection into the global scope. Using std::max directly instead.
(WebKit::AcceleratedCompositingContext::scheduleLayerFlush): Ditto.
- webkit/webkitwebview.cpp:
(updateAcceleratedCompositingSetting): A helper function that ensures the accelerated compositing feature
stays disabled under Wayland displays. It also prints out a warning message the first time the user tries
to enable accelerated compositing under Wayland displays, telling that the feature is not supported and
will remain disabled.
(webkit_web_view_update_settings): Call updateAcceleratedCompositingSetting() to enable the feature if possible.
(webkit_web_view_settings_notify): Ditto.
- 9:02 AM Changeset in webkit [155619] by
-
- 3 edits in trunk/Source/WebKit/gtk
[GTK][WK1] Block accelerated compositing under non-X11 displays
https://bugs.webkit.org/show_bug.cgi?id=121165
Reviewed by Martin Robinson.
This is analogous to the changes in r154728 and r154729 that enforce disabling accelerated compositing
under Wayland displays and made the RedirectedXCompositeWindow use in WebKit2 limited only to the X11 displays.
- WebCoreSupport/AcceleratedCompositingContextGL.cpp: Remove two unnecessary header includes that also
introduce symbols that conflict with the symbols defined in the X headers. Include the <gdk/gdkx.h> header
if the GTK+ dependency can provide it.
(WebKit::AcceleratedCompositingContext::initialize): Only set up the RedirectedXCompositeWindow instance
if running under an X11 display.
(WebKit::AcceleratedCompositingContext::renderLayersToWindow): The removal of the unnecessary header
inclusions also removed the std::max() injection into the global scope. Using std::max directly instead.
(WebKit::AcceleratedCompositingContext::scheduleLayerFlush): Ditto.
- webkit/webkitwebview.cpp:
(updateAcceleratedCompositingSetting): A helper function that ensures the accelerated compositing feature
stays disabled under Wayland displays. It also prints out a warning message the first time the user tries
to enable accelerated compositing under Wayland displays, telling that the feature is not supported and
will remain disabled.
(webkit_web_view_update_settings): Call updateAcceleratedCompositingSetting() to enable the feature if possible.
(webkit_web_view_settings_notify): Ditto.
- 8:55 AM Changeset in webkit [155618] by
-
- 12 edits in trunk/LayoutTests
[EFL] Changed expected results after turning on WTF_USE_TILED_BACKING_STORE (r133898)
https://bugs.webkit.org/show_bug.cgi?id=121227
Unreviewed EFL gardening.
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-09-12
- platform/efl/TestExpectations:
- platform/efl/editing/selection/caret-ltr-2-expected.png:
- platform/efl/editing/selection/caret-ltr-2-expected.txt:
- platform/efl/editing/selection/caret-ltr-2-left-expected.png:
- platform/efl/editing/selection/caret-ltr-2-left-expected.txt:
- platform/efl/editing/selection/caret-ltr-expected.png:
- platform/efl/editing/selection/caret-ltr-expected.txt:
- platform/efl/editing/selection/caret-rtl-2-expected.png:
- platform/efl/editing/selection/caret-rtl-2-expected.txt:
- platform/efl/editing/selection/caret-rtl-expected.png:
- platform/efl/editing/selection/caret-rtl-expected.txt:
- 8:55 AM Changeset in webkit [155617] by
-
- 2 edits in trunk/Source/WebKit
[Win] TestWebKitAPI fails to link.
https://bugs.webkit.org/show_bug.cgi?id=121223
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-09-12
Reviewed by Brent Fulgham.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add required symbol.
- 8:52 AM Changeset in webkit [155616] by
-
- 3 edits in trunk/Source/WebCore
[WinCairo] Compile errors, missing include.
https://bugs.webkit.org/show_bug.cgi?id=121222
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-09-12
Reviewed by Brent Fulgham.
- platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp: Include required header.
- platform/win/DragImageCairoWin.cpp: Include required header.
- 8:46 AM Changeset in webkit [155615] by
-
- 3 edits3 adds in trunk
REGRESSION: Inline PDF that are cached fail to appear in iframe.
https://bugs.webkit.org/show_bug.cgi?id=75449
Reviewed by Darin Adler.
Make sure 'frame is from page cache' flag is set for subframes too.
WebFrameLoaderClient::m_frameCameFromPageCache == true forces plugins
to be loaded manually. It ensures that the plugin raw data is fetched again
while the containing frame is being restored from the page cache.
(Plugins get destroyed when the frame goes to page cache.)
Source/WebKit2:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
This gets called only on the frame where the actual history navigation happens.
(WebKit::WebFrameLoaderClient::didRestoreFromPageCache):
This gets called for all the restored frames.
LayoutTests:
- fast/history/history-back-while-pdf-in-pagecache-expected.html: Added.
- fast/history/history-back-while-pdf-in-pagecache.html: Added.
- fast/history/resources/history-back-for-pfd-test.html: Added.
- 8:30 AM Changeset in webkit [155614] by
-
- 7 edits2 adds in trunk/Tools
Auto GDB backtrace generation for EFL/GTK/Qt bots.
https://bugs.webkit.org/show_bug.cgi?id=119338
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-12
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/port/efl.py:
(EflPort.check_sys_deps):
(EflPort):
(EflPort._get_crash_log):
- Scripts/webkitpy/port/efl_unittest.py:
(EflPortTest.test_show_results_html_file):
(EflPortTest):
(EflPortTest.test_get_crash_log):
- Scripts/webkitpy/port/gtk.py:
(GtkPort._get_crash_log):
- Scripts/webkitpy/port/gtk_unittest.py:
(GtkPortTest.test_get_crash_log):
- Scripts/webkitpy/port/linux_get_crash_log.py: Added.
(GDBCrashLogGenerator):
(GDBCrashLogGenerator.init):
(GDBCrashLogGenerator._get_gdb_output):
(GDBCrashLogGenerator.generate_crash_log):
(GDBCrashLogGenerator.generate_crash_log.match_filename):
- Scripts/webkitpy/port/linux_get_crash_log_unittest.py: Added.
(GDBCrashLogGeneratorTest):
(GDBCrashLogGeneratorTest.test_generate_crash_log):
(_mock_gdb_output):
- Scripts/webkitpy/port/qt.py:
(QtPort.default_child_processes):
(QtPort):
(QtPort._get_crash_log):
- Scripts/webkitpy/port/qt_unittest.py:
(QtPortTest.test_check_sys_deps):
(QtPortTest):
(QtPortTest.test_get_crash_log):
- 8:28 AM Changeset in webkit [155613] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add back c++11 features removed by buildfixes after all ports did the switch
https://bugs.webkit.org/show_bug.cgi?id=119266
Reviewed by Anders Carlsson.
- bytecode/GetByIdStatus.h:
(JSC::GetByIdStatus::GetByIdStatus):
- dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::~Worklist):
- interpreter/StackVisitor.cpp:
(JSC::StackVisitor::Frame::codeType):
(JSC::StackVisitor::Frame::functionName):
(JSC::StackVisitor::Frame::sourceURL):
(JSC::StackVisitor::Frame::print):
- 8:09 AM Changeset in webkit [155612] by
-
- 2 edits in trunk/Tools
Unreviewed. Moving myself to the commiters list.
- Scripts/webkitpy/common/config/contributors.json:
- 7:56 AM Changeset in webkit [155611] by
-
- 36 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebase after r155253.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-12
- platform/qt-wk2/editing/style/style-boundary-005-expected.png: Added.
- platform/qt/editing/pasteboard/4989774-expected.png:
- platform/qt/editing/pasteboard/4989774-expected.txt:
- platform/qt/editing/pasteboard/paste-match-style-001-expected.png:
- platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
- platform/qt/editing/selection/caret-ltr-2-expected.png:
- platform/qt/editing/selection/caret-ltr-2-expected.txt:
- platform/qt/editing/selection/caret-ltr-2-left-expected.png:
- platform/qt/editing/selection/caret-ltr-2-left-expected.txt:
- platform/qt/editing/selection/caret-ltr-expected.png:
- platform/qt/editing/selection/caret-ltr-expected.txt:
- platform/qt/editing/selection/caret-ltr-right-expected.png:
- platform/qt/editing/selection/caret-ltr-right-expected.txt:
- platform/qt/editing/selection/caret-rtl-2-expected.png:
- platform/qt/editing/selection/caret-rtl-2-expected.txt:
- platform/qt/editing/selection/caret-rtl-2-left-expected.png:
- platform/qt/editing/selection/caret-rtl-2-left-expected.txt:
- platform/qt/editing/selection/caret-rtl-expected.png:
- platform/qt/editing/selection/caret-rtl-expected.txt:
- platform/qt/editing/selection/caret-rtl-right-expected.png:
- platform/qt/editing/selection/caret-rtl-right-expected.txt:
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
- platform/qt/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
- platform/qt/editing/style/style-boundary-005-expected.png:
- platform/qt/editing/style/style-boundary-005-expected.txt:
- platform/qt/fast/forms/formmove3-expected.txt:
- platform/qt/fast/forms/input-align-image-expected.png:
- platform/qt/fast/forms/input-align-image-expected.txt:
- platform/qt/fast/forms/preserveFormDuringResidualStyle-expected.png:
- platform/qt/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/qt/fast/invalid/003-expected.png:
- platform/qt/fast/invalid/003-expected.txt:
- platform/qt/tables/mozilla/bugs/bug647-expected.png:
- platform/qt/tables/mozilla/bugs/bug647-expected.txt:
- 7:51 AM Changeset in webkit [155610] by
-
- 1 edit1 add in trunk/Tools
[GTK] Add jhbuild-wayland.modules
https://bugs.webkit.org/show_bug.cgi?id=120455
Reviewed by Gustavo Noronha Silva.
Current versions of gtk+, gdk-pixbuf and glib don't fit the requirement for wayland support.
With this patch, you can build extra gtk+, gdk-pixbuf and glib through jhbuild with exporting
WEBKIT_EXTRA_MODULESETS.
- gtk/jhbuild-wayland.modules: Added.
- 7:41 AM Changeset in webkit [155609] by
-
- 3 edits2 adds in trunk
XMLSerializer.serializeToString() should throw exception for invalid node value.
https://bugs.webkit.org/show_bug.cgi?id=121209
Reviewed by Darin Adler.
Source/WebCore:
FF and Opera 12 (pre blink/webkit) throw exception in case the node value is invalid.
Blink sends an empty string as the result of serializeToString operation with invalid node.
We should match with other browsers for throwing it as an exception.
Blink review URL: https://chromiumcodereview.appspot.com/23532055/
Test: fast/dom/xmlserializer-serialize-to-string-exception.html
- xml/XMLSerializer.cpp:
(WebCore::XMLSerializer::serializeToString):
LayoutTests:
- fast/dom/xmlserializer-serialize-to-string-exception-expected.txt: Added.
- fast/dom/xmlserializer-serialize-to-string-exception.html: Added.
- 7:27 AM Changeset in webkit [155608] by
-
- 4 edits2 adds in trunk
Crash in ScrollingStateStickyNode::updateConstraints
https://bugs.webkit.org/show_bug.cgi?id=119638
Reviewed by Simon Fraser.
Ensure when a scrolling state node is removed from the state tree,
we remove both the current node and all its children from the
associated m_stateNodeMap lookup table.
Source/WebCore:
Test: fast/css/sticky/multiple-layers-sticky-crash.html
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::removeChild):
(WebCore::ScrollingStateNode::willBeRemovedFromStateTree):
- page/scrolling/ScrollingStateNode.h:
LayoutTests:
- fast/css/sticky/multiple-layers-sticky-crash-expected.txt: Added.
- fast/css/sticky/multiple-layers-sticky-crash.html: Added.
- 7:03 AM Changeset in webkit [155607] by
-
- 6 edits4 adds in trunk
REGRESSION (r132516): Javascript menu text incorrectly disappearing and reappearing
https://bugs.webkit.org/show_bug.cgi?id=101047
Reviewed by Simon Fraser.
Compositing layers keep track of ancestors' clipping by constructing the RenderLayerBacking::m_ancestorClippingLayer.
It helps setting up the proper clipping context for the corresponding graphics layer.
When a RenderObject's clipping style changes, it needs to propagate this change not only
to the associated RenderLayer, but also to the descendants', if applicable.
Before r132516, it was mainly covered by initiating full style recalcs, which ensured that
style recalc on the descendant rendering tree took care of creating/destroying
RenderLayerBacking::m_ancestorClippingLayer at every compositing layer node. Without the full
recalc, the clipping of the compositing render layers and the corresponding render subtrees can get out of sync.
This patch updates the clipping context on the descendant subtree, when the clipping behaviour
changes on a render node.
Source/WebCore:
Tests: compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants.html
compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateDescendantClippingContext):
(WebCore::RenderLayer::styleChanged):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::~RenderLayerBacking):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::updateAncestorClippingLayer):
(WebCore::RenderLayerBacking::updateDescendantClippingLayer):
- rendering/RenderLayerBacking.h:
LayoutTests:
- compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt: Added.
- compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants.html: Added.
- compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt: Added.
- compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2.html: Added.
- 4:15 AM Changeset in webkit [155606] by
-
- 2 edits in trunk/Tools
[GTK][WK2] a11y tests unconditionally launching a11y daemons
https://bugs.webkit.org/show_bug.cgi?id=120299
Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-09-12
Reviewed by Carlos Garcia Campos.
Use the right variable name to store a reference to the at-spi2
bus launcher process, so we can be sure we are terminating it when
calling _tear_down_testing_environment().
- Scripts/run-gtk-tests:
(TestRunner._start_accessibility_daemons): Use _spi_bus_launcher
instead of _ally_bus_launcher.
- 3:54 AM Changeset in webkit [155605] by
-
- 2 edits in trunk/Tools
[GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suite is skipped
https://bugs.webkit.org/show_bug.cgi?id=121218
Reviewed by Philippe Normand.
Skipping the entire suite was added to skip tests when they can't
be run because of the environment, for example to skip the a11y
tests when the at-spi daemons fail to start. This is no longer
true for all the cases, so we can disable the tests that are
impossible to run instead of skipping them.
- Scripts/run-gtk-tests:
(TestRunner.init): Initialize the skipped tests list.
(TestRunner._setup_testing_environment): Add
TestWebKitAccessibility path to the list of disabled tests when
at-spi daemon fail to start.
(TestRunner._should_run_test_program): Check first if the test
program is disabled and then whether it's skipped honoring the
skipped command line option.
- 3:42 AM Changeset in webkit [155604] by
-
- 20 edits2 deletes in trunk/Source
Remove home-brewed nullptr
https://bugs.webkit.org/show_bug.cgi?id=119624
Reviewed by Anders Carlsson.
The standard C++11 nullptr and std::nullptr_t type should be used now.
Source/JavaScriptCore:
- heap/PassWeak.h:
- heap/Weak.h:
Source/WebCore:
- bindings/js/JSDOMBinding.h:
Source/WebKit/efl:
- tests/UnitTestUtils/EWKTestView.cpp:
Source/WTF:
- GNUmakefile.list.am:
- WTF.pro:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/NullPtr.cpp: Removed.
- wtf/NullPtr.h: Removed.
- wtf/OwnArrayPtr.h:
- wtf/OwnPtr.h:
- wtf/PassOwnPtr.h:
- wtf/PassRefPtr.h:
- wtf/RetainPtr.h:
- wtf/win/GDIObject.h:
- 3:24 AM Changeset in webkit [155603] by
-
- 14 edits1 move in trunk
<meter> element text value exposed as AXTitle; should be exposing AXValueDescription
https://bugs.webkit.org/show_bug.cgi?id=117651
Patch by Samuel White <Samuel White> on 2013-09-12
Reviewed by Mario Sanchez Prada.
Source/WebCore:
No new tests, updated accessibility/meter-element to handle platform specific output.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isMeter):
- accessibility/AccessibilityObject.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
Tools:
Prepended 'AXValueDescription: ' to valueDescription output and updated impacted tests.
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::valueDescription):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::valueDescription):
LayoutTests:
Updated existing meter element test to cover platform specific output.
- accessibility/meter-element.html:
- platform/mac/accessibility/aria-valuetext-on-native-slider-expected.txt:
- platform/mac/accessibility/aria-valuetext-on-native-slider.html:
- platform/mac/accessibility/aria-valuetext.html:
- platform/mac/accessibility/meter-element-expected.txt: Renamed from LayoutTests/accessibility/meter-element-expected.txt.
- platform/mac/accessibility/spinbutton-valuedescription-expected.txt:
- platform/mac/accessibility/spinbutton-valuedescription.html:
- 2:54 AM Changeset in webkit [155602] by
-
- 2 edits in trunk/Source/WebCore
class WeekInputType invokes wrong constructor
https://bugs.webkit.org/show_bug.cgi?id=120768
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-09-12
Reviewed by Andreas Kling.
Correcting wrong constuctor invocation.
- html/WeekInputType.h:
(WebCore::WeekInputType::WeekInputType):
- 2:51 AM Changeset in webkit [155601] by
-
- 3 edits2 adds in trunk
AX: Self-referencing aria-labelledby only uses contents.
https://bugs.webkit.org/show_bug.cgi?id=120814
Patch by Samuel White <Samuel White> on 2013-09-12
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Implemented additional 'Text Alternative Computation' steps documented at:
http://www.w3.org/WAI/PF/aria/complete#textalternativecomputation. This allows us to remove
our raw text node iteration that was previously forcing us to do our computation incorrectly.
Element content is now sourced using textUnderElement (step 2C of the computation).
Test: accessibility/self-referencing-aria-labelledby.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::accessibleNameForNode):
(WebCore::AccessibilityNodeObject::accessibilityDescriptionForElements):
LayoutTests:
Test to verify that self-referencing aria-labelledby behavior works as expected.
- accessibility/self-referencing-aria-labelledby-expected.txt: Added.
- accessibility/self-referencing-aria-labelledby.html: Added.
- 2:38 AM Changeset in webkit [155600] by
-
- 11 edits in trunk/Source/WebCore
Unreviewed, rolling out r155597.
http://trac.webkit.org/changeset/155597
https://bugs.webkit.org/show_bug.cgi?id=121220
broke windows build because there's no ews :( (Requested by
thorton on #webkit).
- WebCore.exp.in:
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::isBitmapImage):
- platform/graphics/BitmapImage.h:
(WebCore::BitmapImage::create):
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage):
(WebCore::CrossfadeGeneratedImage::drawPattern):
- platform/graphics/CrossfadeGeneratedImage.h:
(WebCore::CrossfadeGeneratedImage::setContainerSize):
(WebCore::CrossfadeGeneratedImage::usesContainerSize):
(WebCore::CrossfadeGeneratedImage::hasRelativeWidth):
(WebCore::CrossfadeGeneratedImage::hasRelativeHeight):
(WebCore::CrossfadeGeneratedImage::size):
- platform/graphics/GeneratedImage.h:
(WebCore::GeneratedImage::hasSingleSecurityOrigin):
(WebCore::GeneratedImage::setContainerSize):
(WebCore::GeneratedImage::usesContainerSize):
(WebCore::GeneratedImage::hasRelativeWidth):
(WebCore::GeneratedImage::hasRelativeHeight):
(WebCore::GeneratedImage::size):
(WebCore::GeneratedImage::destroyDecodedData):
(WebCore::GeneratedImage::decodedSize):
- platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::draw):
(WebCore::GeneratorGeneratedImage::drawPattern):
- platform/graphics/GeneratorGeneratedImage.h:
(WebCore::GeneratorGeneratedImage::GeneratorGeneratedImage):
- svg/graphics/SVGImage.h:
(WebCore::SVGImage::isSVGImage):
(WebCore::SVGImage::usesContainerSize):
(WebCore::SVGImage::destroyDecodedData):
(WebCore::SVGImage::decodedSize):
- svg/graphics/SVGImageForContainer.h:
(WebCore::SVGImageForContainer::destroyDecodedData):
(WebCore::SVGImageForContainer::decodedSize):
- 2:31 AM Changeset in webkit [155599] by
-
- 7 edits in trunk
REGRESSION(r154781): accessibility/notification-listeners.html is failing
https://bugs.webkit.org/show_bug.cgi?id=120669
Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-09-12
Reviewed by Chris Fleizach.
Tools:
Fixed 4 problems that were causing notification-listeners.html to fail.
Notifications for AXFocusedUIElementChanged and AXValueChanged had to be
implemented in axObjectEventListener().
A notification for AXFocusedUIElementChanged was incorrectly sent when
the element lost focus.
Global notification was not dispatched if an element notification was
present in the HashMap.
connectAccessibilityCallbacks() was connecting signals to callbacks
multiple times because it was not checking if
disconnectAccessibilityCallbacks() had an early return if there were
active handlers.
- DumpRenderTree/atk/AccessibilityCallbacks.h: Modified
disconnectAccessibilityCallbacks() to inform if the callbacks were
successfully disconnected.
- DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
(axObjectEventListener): Implemented notifications for
AXFocusedUIElementChanged and AXValueChanged. Fixed the global
notification, which was not dispatched if an element notification
existed. Fixed the notification for AXFocusedUIElementChanged that was
incorrectly sent when the element lost focus. In addition, fixed a typo
where TRUE should be true.
(connectAccessibilityCallbacks): Added early return if
disconnectAccessibilityCallbacks() did not disconnect the callbacks.
(disconnectAccessibilityCallbacks): Added a return value to inform if
callbacks were successfully disconnected.
LayoutTests:
Updated the expectation for notification-listeners.html, which was
failing before this fix.
- platform/gtk/TestExpectations: Removed notification-listeners.html.
- platform/gtk/accessibility/notification-listeners-expected.txt:
Updated the expectation for notification-listeners.html. There is one
difference from the results on the Mac port, which was used as
reference. The element role for <select> is AXComboBox while on Mac
is AXPopUpButton.
- 2:12 AM Changeset in webkit [155598] by
-
- 14 edits in trunk/Source/WebCore
RenderWidget elements are always HTMLFrameOwnerElement subclasses.
<https://webkit.org/b/121217>
Reviewed by Antti Koivisto.
Make RenderWidget constructor take HTMLFrameOwnerElement* and update subclasses
with even tighter types where possible.
Also added RenderWidget::frameOwnerElement() and deleted element().
Removed a handful of unnecessary type checks that were exposed by this.
- 2:03 AM Changeset in webkit [155597] by
-
- 11 edits in trunk/Source/WebCore
Apply OVERRIDE and FINAL to Image subclasses and clean them up
https://bugs.webkit.org/show_bug.cgi?id=121086
Reviewed by Alexey Proskuryakov.
Everything other than the copious application of OVERRIDE and FINAL
is explicitly called out below.
- WebCore.exp.in:
Export the correct version of getCGImageRef for use by WebKit2.
- platform/graphics/BitmapImage.cpp:
- platform/graphics/BitmapImage.h:
Drive-by inline isBitmapImage.
Move create(HBITMAP) to be near the other create() functions.
Move all of the members and quite a few functions from protected to private.
Devirtualize frameCount().
Move notSolidColor() near the other solid color functions.
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage):
(WebCore::CrossfadeGeneratedImage::drawPattern):
- platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::draw):
(WebCore::GeneratorGeneratedImage::drawPattern):
Use size() and setContainerSize() instead of directly accessing a
superclass' (now private, previously protected) members.
- platform/graphics/CrossfadeGeneratedImage.h:
- platform/graphics/GeneratedImage.h:
Make m_size private, I don't think we do protected members.
- platform/graphics/GeneratorGeneratedImage.h:
Make all the members private.
- svg/graphics/SVGImage.h:
- svg/graphics/SVGImageForContainer.h:
- 1:32 AM WebKitGTK/2.2.x edited by
- (diff)
