Timeline



Sep 20, 2013:

10:35 PM Changeset in webkit [156224] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Another CSS parser leak fix
https://bugs.webkit.org/show_bug.cgi?id=121730

Reviewed by Alexey Proskuryakov.

  • css/CSSGrammar.y.in: Added a missing adoptPtr.
10:35 PM Changeset in webkit [156223] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Handle panning gestures messages properly on Windows
https://bugs.webkit.org/show_bug.cgi?id=121711

Follow-up fix: five regression tests started to crash on Mac.

Reviewed by Anders Carlsson.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollByRecursively):

Added null checks, not all callers are interested in scrolled view pointer.

9:13 PM Changeset in webkit [156222] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Bad cast from CSSInitialValue to CSSValueList
https://bugs.webkit.org/show_bug.cgi?id=121729

Source/WebCore:

Reviewed by Beth Dakin.

Merge https://chromium.googlesource.com/chromium/blink/+/fcfaa51f9207b32cffe751c1a1380a921e464cbb

The issue was that we would cast to CSSValueList without checking
the type of the CSSValue. After this change, we use the ASSERT'ing
cast and explicitly check the type of the CSSValue before the cast.

Test: fast/css/crash-inherit-value-font-family.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFontFaceValue):

LayoutTests:

Reviewed by Beth Dakin.

Add a regression test. This is not a merge since the test in the Blink change involves
superfluous execCommand calls.

  • fast/css/crash-inherit-value-font-family-expected.txt: Added.
  • fast/css/crash-inherit-value-font-family.html: Added.
9:11 PM Changeset in webkit [156221] by Lucas Forschler
  • 5 edits in branches/safari-537.60-branch/Source

Merged r156219. <rdar://problem/12712495>

8:36 PM Changeset in webkit [156220] by zoltan@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove includes from LineWidth.h
https://bugs.webkit.org/show_bug.cgi?id=121716

Reviewed by Darin Adler.

In r156197 I removed logicalLineHeight from LineWidth.h, so we don't need to include RenderBlock.h
and RenderRubyRun.h anymore in LineWidth.h.

No new tests, no behavior change.

  • rendering/LineWidth.cpp:
  • rendering/LineWidth.h:
8:23 PM Changeset in webkit [156219] by roger_fong@apple.com
  • 5 edits in trunk/Source

Handle panning gestures messages properly on Windows.
https://bugs.webkit.org/show_bug.cgi?id=121711.

Reviewed by Brent Fulgham.

This fixes a number of issues with panning gestures on Windows.

  1. Two finger panning in one direction can sometimes cause some unexpected scrolling

in the other direction when the gesture first begins (directions meaning horizontal and vertical)

  1. Single finger horizontal panning should only be disabled when attempting to select text.
  2. Scrolling via panning should be clamped, other wise we can scroll contents completely out of the scrollview.
  3. Horizontal overpan should work.
  4. Overpan should occur whenever we scroll to the extents of whichever scroll view we're currently scrolling.
  • WebView.cpp:

(WebView::gestureNotify):
(WebView::gesture):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollByRecursively):

  • rendering/RenderLayer.h:

Added an argument to keep track of which scrollview was actually scrolled
This is needed by the Windows port to keep track to determine whether or not
we need to overpan.

6:25 PM Changeset in webkit [156218] by mrowe@apple.com
  • 3 edits in trunk/WebKitLibraries

Fix link errors for external users when building WebKit with Xcode 5.

Reviewed by Oliver Hunt.

  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
5:57 PM Changeset in webkit [156217] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Windows] Unreviewed build fix after r156216.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: I accidentally exposed the symbol of the calling function, not the missing symbol!
5:51 PM Changeset in webkit [156216] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[WINDOWS] Unreviewed build fix after r156215.

  • WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add missing symbols needed by DumpRenderTree.dll.
5:35 PM Changeset in webkit [156215] by Alexandru Chiculita
  • 12 edits
    2 adds in trunk

Web Inspector: [CSS Regions] Display CSS Regions chain when highlighting a CSS Region node
https://bugs.webkit.org/show_bug.cgi?id=121719

Reviewed by Joseph Pecoraro.

Source/WebCore:

Test: inspector/elements/highlight-node-regions.html

When a CSS Region node is highlighted through the WebInspector, it will also lookup all the regions
that are part of the same flow and inject enough information into InspectorOverlayPage.js to get the other
CSS Regions highlighted as well. A chain will also link the regions and a number will display the ordering
of the content.

  • WebCore.exp.in:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::buildObjectForHighlightedNode):

  • inspector/InspectorController.h:
  • inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForRegionHighlight):
(WebCore::buildObjectForCSSRegionsHighlight):
(WebCore::InspectorOverlay::buildObjectForHighlightedNode):
(WebCore::InspectorOverlay::drawNodeHighlight): Separated the InspectorObject building part out of this function,
so that we can call buildObjectForHighlightedNode from the Internals APIs for testing.

  • inspector/InspectorOverlay.h:
  • inspector/InspectorOverlayPage.js:

(_drawRegionNumber):
(_quadMidPoint):
(_drawRegionLink):
(_fixQuadScrollPosition):
(_drawRegionsHighlight):
(drawNodeHighlight):

  • testing/Internals.cpp: Exposed the generated InspectorObject to the layout test.

(WebCore::Internals::inspectorHighlightObject):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Added test to check the position of the CSS Regions part of the same flow thread with
the highlighted CSS Region node.

  • http/tests/inspector/elements-test.js:
  • inspector/elements/highlight-node-regions-expected.txt: Added.
  • inspector/elements/highlight-node-regions.html: Added.
5:24 PM Changeset in webkit [156214] by mhahnenberg@apple.com
  • 3 edits
    3 adds in trunk

(un)shiftCountWithAnyIndexingType will start over in the middle of copying if it sees a hole
https://bugs.webkit.org/show_bug.cgi?id=121717

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This bug caused the array to become corrupted. We now check for holes before we start moving things,
and start moving things only once we've determined that there are none.

  • runtime/JSArray.cpp:

(JSC::JSArray::shiftCountWithAnyIndexingType):
(JSC::JSArray::unshiftCountWithAnyIndexingType):

LayoutTests:

Added test to make sure that splicing an array with holes works correctly.

  • js/array-splice-with-holes-expected.txt: Added.
  • js/array-splice-with-holes.html: Added.
  • js/script-tests/array-splice-with-holes.js: Added.
5:07 PM Changeset in webkit [156213] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Fix test after <http://trac.webkit.org/changeset/156203>

  • platform/mac/accessibility/aria-help.html: Correct paths to JS tests.
5:07 PM Changeset in webkit [156212] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

REGRESSION(r156047): WebCore hangs inside JSC::toInt32(double)
https://bugs.webkit.org/show_bug.cgi?id=121648

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

The Int52<->StrictInt52 conversion did the opposite fill() than what it was
supposed to. For example when converting a Int52 to a StrictInt52 it would fill
as Int52, and vice-versa.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateInt52):

LayoutTests:

Reviewed by Mark Hahnenberg.

  • js/dfg-int52-change-format-expected.txt: Added.
  • js/dfg-int52-change-format.html: Added.
  • js/script-tests/dfg-int52-change-format.js: Added.

(foo):

5:00 PM Changeset in webkit [156211] by oliver@apple.com
  • 3 edits
    3 adds in trunk

REGRESSION(r153215): New iCloud site crashes
https://bugs.webkit.org/show_bug.cgi?id=121710

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Don't claim to be able to rely on the arguments structure, use the Arguments
speculation type

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

LayoutTests:

New test case

  • js/dfg-arguments-mutated-structure-expected.txt: Added.
  • js/dfg-arguments-mutated-structure.html: Added.
  • js/script-tests/dfg-arguments-mutated-structure.js: Added.

(foo):

4:59 PM Changeset in webkit [156210] by commit-queue@webkit.org
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r156185.
http://trac.webkit.org/changeset/156185
https://bugs.webkit.org/show_bug.cgi?id=121727

Caused a lot of crashes in tests (Requested by ap on #webkit).

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::updateLayout):

  • dom/Document.h:

LayoutTests:

  • fast/dom/HTMLDocument/active-element-gets-unfocusable-expected.txt: Removed.
  • fast/dom/HTMLDocument/active-element-gets-unfocusable.html: Removed.
4:45 PM Changeset in webkit [156209] by timothy@apple.com
  • 9 edits in trunk/Source/WebInspectorUI

Parse MIME-types and strip them down to the base type when needed.

The use of charset in a MIME-type interferes with our type maps,
preventing the right syntax highlighting mode and pretty printing.

https://bugs.webkit.org/show_bug.cgi?id=121723

Reviewed by Joseph Pecoraro.

  • UserInterface/ConsolePrompt.js:

(WebInspector.ConsolePrompt):

  • UserInterface/FontResourceContentView.js:
  • UserInterface/Resource.js:

(WebInspector.Resource.Type.fromMIMEType):
(WebInspector.Resource.prototype.get mimeTypeComponents):
(WebInspector.Resource.prototype.get syntheticMIMEType):
(WebInspector.Resource.prototype.get contentURL):
(WebInspector.Resource.prototype.updateForResponse):

  • UserInterface/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestDataSection):

  • UserInterface/SourceMapResource.js:

(WebInspector.SourceMapResource.prototype.requestContentFromBackend):

  • UserInterface/SyntaxHighlightingSupport.js:

(WebInspector.syntaxHighlightStringAsDocumentFragment):

  • UserInterface/TextEditor.js:

(WebInspector.TextEditor.prototype.set mimeType):

  • UserInterface/Utilities.js:

(parseMIMEType): Added.

4:01 PM Changeset in webkit [156208] by mrowe@apple.com
  • 5 edits in trunk

<https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date

Tools:

Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.

Reviewed by David Kilzer.

  • Scripts/webkitdirs.pm:

(checkRequiredSystemConfig):

Websites/webkit.org:

Update references on webkit.org to mention Xcode 4.6 as the minimum version.

Reviewed by David Kilzer.

  • building/debug-mac-uiprocess.html:
  • building/tools.html:
3:52 PM Changeset in webkit [156207] by Lucas Forschler
  • 5 edits in branches/safari-537.60-branch/Source

Versioning.

3:48 PM Changeset in webkit [156206] by Lucas Forschler
  • 1 copy in tags/Safari-537.60.2

New Tag.

3:17 PM Changeset in webkit [156205] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

Shaders that fail to compile should be marked as such
https://bugs.webkit.org/show_bug.cgi?id=121721

Reviewed by Simon Fraser.

  1. Add a new logging channel for WebGL.
  1. If a translated shader fails to compile (technically

this should never happen), mark it as invalid.

Test: https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/misc/shader-with-non-reserved-words.html

  • platform/Logging.h: New WebGL channel.
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::compileShader): Log the raw and translated
input to glCompileShader, but mark the entry as invalid.

2:58 PM Changeset in webkit [156204] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Add an implementation of std::index_sequence from C++14
https://bugs.webkit.org/show_bug.cgi?id=121718

Reviewed by Ryosuke Niwa.

This will make it easier to do things like pack expansion of tuple elements.

  • wtf/StdLibExtras.h:
2:56 PM Changeset in webkit [156203] by mario@webkit.org
  • 18 edits
    2 moves
    2 deletes in trunk

[ATK] Do not expose aria-help in ATK based platforms
https://bugs.webkit.org/show_bug.cgi?id=121675

Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-09-20
Reviewed by Chris Fleizach.

Source/WebCore:

Stop exposing the value for the 'aria-help' attribute as an
AtkObject attribute, based in AccessibilityObject::helpText().

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes): Remove the mapping.

Source/WebKit/efl:

Removed accessibilityHelpText() helper method from
DumpRenderSupportEfl's API, since it's not longer needed.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp: Removed method.
  • WebCoreSupport/DumpRenderTreeSupportEfl.h: Ditto.

Source/WebKit/gtk:

Removed accessibilityHelpText() helper method from
DumpRenderSupportGtk's API, since it's not longer needed.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Removed method.
  • WebCoreSupport/DumpRenderTreeSupportGtk.h: Ditto.

Tools:

Remove the implementations for AccessibilityUIElement::helpText()
from DRT and WKTR for GTK and EFL, since they are based on the
AccessibilityObject::helpText() method and the 'aria-help'
attributes, which is wrong since they should not depend on that
but in ATK specific API (see also http://webkit.org/b/121684).

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::helpText): Added a new and empty
implementation, now that we are no longer using this in ATK.

  • DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file

as the only function provided here was helpText().

  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
  • DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp

removed from the list of sources to compile.

  • GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::helpText): Replaced old implementation
based in DumpRenderTreeSupportGtk with an empty one.

LayoutTests:

Moved test based in helpText() into the Mac directory, and update
expectations for platforms as needed.

  • platform/mac/accessibility/aria-help-expected.txt: Renamed from LayoutTests/accessibility/aria-help-expected.txt.
  • platform/mac/accessibility/aria-help.html: Renamed from LayoutTests/accessibility/aria-help.html.
  • platform/gtk-wk2/TestExpectations: Removed failure expectation

for aria-help, now moved to Mac, and for aria-describedby-on-input,
which is now moved to the generic TestExpectations file for GTK.

  • platform/gtk/TestExpectations: Added aria-describedby-on-input,

linking it to the newly filed bug 121684.

  • platform/gtk-wk2/TestExpectations: Removed failure expectation.
  • platform/win/TestExpectations: Removed failure expectation.
  • platform/wincairo/TestExpectations: Ditto.
2:54 PM Changeset in webkit [156202] by Lucas Forschler
  • 3 edits in branches/safari-537.60-branch/Source/WebCore

Correct build by activating Microsoft Assembler support in
project file. I have no idea why this would be missing in
the branch.

Patch by Brent Fulgham <Brent Fulgham> on 2013-09-20

  • WebCore.vcxproj/WebCore.vcxproj: Activate MASM support.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
2:47 PM Changeset in webkit [156201] by Simon Fraser
  • 7 edits in trunk/Source/WebCore

Scrollbars don't appear on long pages after r155660
https://bugs.webkit.org/show_bug.cgi?id=121714
<rdar://problem/15042478>

Reviewed by Beth Dakin.

After r155660, we don't do any additional layouts when scrollbars are
added or removed. That caused us to not enter the code that creates or
destroys composting layers for scrollbars in RenderLayerCompositor, resulting
in missing scrollbars.

Fix by having ScrollView::updateScrollbars() call addedOrRemovedScrollbar()
when a scrollbar was added or removed, which is overridden in FrameView
to call through to RenderLayerCompositor::frameViewDidAddOrRemoveScrollbars().

Not testable since scrollbar layers aren't contained in layer tree dumps
(to reduce diffs between platforms).

  • page/FrameView.cpp:

(WebCore::FrameView::addedOrRemovedScrollbar): New function to tell the compositor
that scrollbars changed.

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar): Change the meaning of the return
value to say if the scrollbar was added or removed. Add an out param that indicates
whether the scrollbar change affects content size (not true for overlay scrollbars).
(WebCore::ScrollView::setHasVerticalScrollbar): Ditto.
(WebCore::ScrollView::updateScrollbars): Keep track of whether scrollbars were
added or removed, and call addedOrRemovedScrollbar() if true.

  • platform/ScrollView.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidAddOrRemoveScrollbars): Call updateOverflowControlsLayers().
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):

  • rendering/RenderLayerCompositor.h:
2:47 PM Changeset in webkit [156200] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Ensure that TileController tile coverage is updated on scrolling even when we don't have scrollbars
https://bugs.webkit.org/show_bug.cgi?id=121700
<rdar://problem/15030589>

Reviewed by Dean Jackson.

r155660 introduced a bug where we wouldn't make scrollbars on long pages. However,
that revealed a fundamental flaw in the TiledBacking update logic; it relied on the
GraphicsLayer flushes triggered by scrollbars updates in order to update the main
TileController's tile coverage. No scrollbars meant no tile coverage updates.

Fix by explicitly triggering a flush when the FrameView is scrolled (we get
notified about this on the main thread after the scrolling thread has moved
layers around).

No test since this will only be exposed for a short time while scrollbars are
broken.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidScroll):

2:17 PM Changeset in webkit [156199] by zoltan@webkit.org
  • 3 edits in trunk/Source/WebCore

Refactoring LineBreaker and RenderTextInfo out of RenderBlock.h
https://bugs.webkit.org/show_bug.cgi?id=121707

Reviewed by David Hyatt.

LineBreaker and RenderTextInfo are defined in RenderBlock.h, but only used in RenderBlockLineLayout.cpp.
Moving them there (LineBreaker needs to be a friend class of RenderBlock) in the first step in the process
of refactoring LineBreaker::NextSegmentBreak into more manageable chunks.

This change was reviewed and landed in Blink:
https://src.chromium.org/viewvc/blink?revision=157402&view=revision

No new tests.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineBreaker::LineBreaker):
(WebCore::LineBreaker::lineWasHyphenated):
(WebCore::LineBreaker::positionedObjects):
(WebCore::LineBreaker::clear):
(WebCore::RenderTextInfo::RenderTextInfo):
(WebCore::RenderTextInfo::~RenderTextInfo):
(WebCore::LineBreaker::skipTrailingWhitespace):
(WebCore::LineBreaker::skipLeadingWhitespace):
(WebCore::LineBreaker::reset):
(WebCore::LineBreaker::nextLineBreak):
(WebCore::LineBreaker::nextSegmentBreak):

2:17 PM Changeset in webkit [156198] by timothy@apple.com
  • 10 edits in trunk/Source/WebInspectorUI

Web Inspector: Fix keyboard shortcuts for other platforms
https://bugs.webkit.org/show_bug.cgi?id=120657

Patch by Marcelo Morais <m.morais@samsung.com> on 2013-09-20
Reviewed by Timothy Hatcher.

Handling keyboard shortcuts according to the current platform.

  • UserInterface/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.loadResourceSynchronously):
(.WebInspector.InspectorFrontendHostStub.prototype.platform): Added. Return the
current platform.

  • UserInterface/KeyboardShortcut.js:

(WebInspector.KeyboardShortcut.Modifier.get CommandOrControl): Added. Created keyboard
modifier to return Control or Command key according to current platform.

  • UserInterface/ContentBrowser.js:

(WebInspector.ContentBrowser): Returning Control or Command key for keyboard
shortcuts according to current platform.

  • UserInterface/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel): Ditto.

  • UserInterface/FindBanner.js:

(WebInspector.FindBanner): Ditto.

  • UserInterface/JavaScriptLogViewController.js:

(WebInspector.JavaScriptLogViewController): Ditto.

  • UserInterface/LogContentView.js:

(WebInspector.LogContentView): Ditto.

  • UserInterface/Main.js:

(WebInspector.contentLoaded): Ditto.

  • UserInterface/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel): Ditto.

1:53 PM Changeset in webkit [156197] by zoltan@webkit.org
  • 6 edits in trunk/Source/WebCore

Move logicalHeightForLine out of LineWidth.h
https://bugs.webkit.org/show_bug.cgi?id=121575

Reviewed by David Hyatt.

In bug #121107 (r155565), I moved logicalHeightForLine into LineWidth.h as part of LineWidth
refactoring. LogicalHeightForLine without passing the second parameter uses RenderBlock::lineHeight
anyway, except it doesn't take -line-box-contain CSS property into account. For Shapes we don't
have implementation for variable-height lines (https://bugs.webkit.org/show_bug.cgi?id=95361) yet, so
so I modified the affected functions to call lineHeight directly. I renamed logicalHeightForLine
to minLineHeightForReplacedRenderer, and I made the second parameter a mandatory for that function.

No new tests, no behavior change.

  • rendering/LineWidth.cpp:

(WebCore::LineWidth::updateAvailableWidth):
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

  • rendering/LineWidth.h:
  • rendering/RenderBlock.cpp: Move the definition here.

(WebCore::RenderBlock::minLineHeightForReplacedRenderer):

  • rendering/RenderBlock.h: Move the function here and rename it.
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutShapeInsideInfo):
(WebCore::updateLogicalInlinePositions):
(WebCore::updateSegmentsForShapes):

1:40 PM Changeset in webkit [156196] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

-[WebHTMLConveter _getFloat:forNode:property:] leaks
https://bugs.webkit.org/show_bug.cgi?id=121709

Reviewed by Enrica Casucci.

  • platform/mac/HTMLConverter.mm:

(-[WebHTMLConverter _getFloat:forNode:property:]): Don't leak.

1:35 PM Changeset in webkit [156195] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Add an argument to ImageSource::createFrameAtIndex to hint a decoder that we expect a scaled image.
https://bugs.webkit.org/show_bug.cgi?id=121696

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-09-20
Reviewed by Antti Koivisto.

Add an argument to ImageSource::createFrameAtIndex. A platform image decoder can decide the optimal
scale based on the hint and pass the real scale it used for decoding.

No new tests, no behavior change.

  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::createFrameAtIndex):

  • platform/graphics/ImageSource.h:
  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::createFrameAtIndex):

1:27 PM Changeset in webkit [156194] by Bem Jones-Bey
  • 1 edit
    57 copies
    8 adds
    1 delete in trunk/LayoutTests

Move tests to new import location
https://bugs.webkit.org/show_bug.cgi?id=121701

Reviewed by Dirk Schulze.

The import script was previously importing the tests into an incorrect
path. This change uses the latest import script to import all of the
shapes tests to the right location.

There are also some small changes in the tests since they had some
more metadata added upstream, but there are no functional changes in
the tests with this change.

  • csswg/contributors/adobe/submitted/shapes/shape-outside/resources/rounded-rectangle.js: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/resources/rounded-rectangle.js.

(ellipseXIntercept):
(scanConvertRoundedRectangleOutside):
(genLeftRightRoundedRectFloatShapeOutsideRefTest):
(genLeftRoundedRectFloatShapeOutsideRefTest):
(genRightRoundedRectFloatShapeOutsideRefTest):

  • csswg/contributors/adobe/submitted/shapes/shape-outside/resources/subpixel-utils.js: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/resources/subpixel-utils.js.

(SubPixelLayout):
(SubPixelLayout.):

  • csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-circle-000-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html: Copied from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-000-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-001-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-002-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-square-border-000-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-stacked-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-stacked-000-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-stacked-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-stacked-000.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002-expected.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html: Renamed from LayoutTests/csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log: Added.
  • csswg/submitted/shapes/shape-outside/w3c-import.log: Removed.
1:26 PM Changeset in webkit [156193] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Make JSMainThreadNullState noncopyable.

Blindly rubber-stamped by Antti Koivisto.

  • bindings/js/JSMainThreadExecState.h:
1:23 PM Changeset in webkit [156192] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Clobberize phase forgets to indicate that it writes GCState for several node types
https://bugs.webkit.org/show_bug.cgi?id=121702

Reviewed by Oliver Hunt.

Added read and write for GCState to the nodes that could end up allocating (and thereby
cause a garbage collection).

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

1:13 PM Changeset in webkit [156191] by mitz@apple.com
  • 5 edits
    1 copy in trunk

Make extract-localizable-strings available to WebCore clients
https://bugs.webkit.org/show_bug.cgi?id=121699

Reviewed by Darin Adler.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj: Added a Scripts group with a reference to

extract-localizable-strings.pl. Added a Copy Scripts build phase to the WebCore target that
copies the script into PrivateHeaders/Scripts in the framework.

  • extract-localizable-strings.pl: Copied from Tools/Scripts/extract-localizable-strings.

Tools:

  • Scripts/extract-localizable-strings: Copied to

Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
executes the script from its new location. This is a temporary measure until certain code
that is external to WebKit is adapted to the new location.

  • Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl

from its new location.

12:56 PM Changeset in webkit [156190] by Antti Koivisto
  • 6 edits in trunk/Source/WebCore

Move layer hierarchy functions from RenderObject to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121692

Reviewed by Andreas Kling.

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::addLayers):
(WebCore::RenderElement::removeLayers):
(WebCore::RenderElement::moveLayers):
(WebCore::RenderElement::findNextLayer):
(WebCore::RenderElement::layerCreationAllowedForSubtree):

Move these from RenderObject.

(WebCore::RenderElement::insertedIntoTree):
(WebCore::RenderElement::willBeRemovedFromTree):

Factor the layer related portion of these virtuals here.

12:29 PM Changeset in webkit [156189] by benjamin@webkit.org
  • 6 edits in trunk/Source/WebCore

Start cleaning the API of SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=121654

Reviewed by Antti Koivisto.

Make the matching mode internal.
Remove unused accessors.
Make isFrameFocused() internal.

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::ruleMatches):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matchRecursively):
(WebCore::SelectorChecker::checkOne):
(WebCore::isFrameFocused):

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::match):

  • css/StyleResolver.h:

(WebCore::checkRegionSelector):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::selectorMatches):

12:28 PM Changeset in webkit [156188] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove SelectorChecker's CrossesBoundary boundary mode
https://bugs.webkit.org/show_bug.cgi?id=121653

Reviewed by Antti Koivisto.

This mode is an ancient vestige of shadow dom.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::match):
(WebCore::SelectorChecker::checkOne):

  • css/SelectorChecker.h:
12:27 PM Changeset in webkit [156187] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Move the SharingRules mode outside of SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=121652

Reviewed by Antti Koivisto.

The SharingRules handling inside SelectorChecker is a weird hack
to hit a specific branch of ElementRuleCollector.

This patch moves the exception to ElementRuleCollector, where it is easier
to understand what it is for.

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::doCollectMatchingRulesForList):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::match):

12:09 PM Changeset in webkit [156186] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Fixed img src URLS with multiple spaces
https://bugs.webkit.org/show_bug.cgi?id=121592

Patch by Yoav Weiss <yoav@yoav.ws> on 2013-09-20
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/loader/image-src-multiple-space.html

I've removed the simplifyWhiteSpace step from HTMLImageElement's src attribute during the srcset selection algorithm.
That step prevented URLs with multiple spaces from being loaded as images, minimizing the multiple spaces into a single one.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::bestFitSourceForImageAttributes):

LayoutTests:

This test verifies that URLs with multiple spaces can be loaded as an image resource.

  • fast/loader/image-src-multiple-space-expected.txt: Added.
  • fast/loader/image-src-multiple-space.html: Added.
12:06 PM Changeset in webkit [156185] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Hiding a focused element should unfocus it and fire a blur event
https://bugs.webkit.org/show_bug.cgi?id=29241

Patch by Arunprasad Rajkumar <ararunprasad@gmail.com> on 2013-09-20
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/dom/HTMLDocument/active-element-gets-unfocusable.html

We check whether the current focus element is really focusable after
the style recalculation and layout change. If it is not focusable then schedule a
timer to reset it asynchronously.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::recalcStyle): Check isFocusable() on the focus element after
style recalculation.
(WebCore::Document::updateLayout): Check isFocusable() on the focus element after
layout.
(WebCore::Document::resetHiddenFocusElementSoon):
(WebCore::Document::resetHiddenFocusElementTimer):

  • dom/Document.h:

LayoutTests:

  • fast/dom/HTMLDocument/active-element-gets-unfocusable-expected.txt: Added.
  • fast/dom/HTMLDocument/active-element-gets-unfocusable.html: Added.

LayoutTest reused from https://chromium.googlesource.com/chromium/blink/+/c58f636fd18fc27944c42e27d6a92a36867c57e1
with little modification.

11:42 AM Changeset in webkit [156184] by fpizlo@apple.com
  • 39 edits
    5 adds
    5 deletes in trunk/Source/JavaScriptCore

Move CCallHelpers and AssemblyHelpers into jit/ and have JSInterfaceJIT use them
https://bugs.webkit.org/show_bug.cgi?id=121637

Rubber stamped by Michael Saboff.

Also moved GPRInfo/FPRInfo into jit/. Rolling back in after fixing JIT-only build
and tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/ValueRecovery.h:

(JSC::ValueRecovery::dumpInContext):

  • dfg/DFGAssemblyHelpers.cpp: Removed.
  • dfg/DFGAssemblyHelpers.h: Removed.
  • dfg/DFGBinarySwitch.h:
  • dfg/DFGByteCodeParser.cpp:
  • dfg/DFGCCallHelpers.h: Removed.
  • dfg/DFGDisassembler.cpp:
  • dfg/DFGFPRInfo.h: Removed.
  • dfg/DFGGPRInfo.h: Removed.
  • dfg/DFGGraph.cpp:
  • dfg/DFGGraph.h:
  • dfg/DFGJITCompiler.h:
  • dfg/DFGOSRExit.cpp:
  • dfg/DFGOSRExit.h:
  • dfg/DFGOSRExitCompiler.h:
  • dfg/DFGOSRExitCompilerCommon.h:
  • dfg/DFGRegisterBank.h:
  • dfg/DFGRegisterSet.h:
  • dfg/DFGRepatch.cpp:
  • dfg/DFGSilentRegisterSavePlan.h:
  • dfg/DFGThunks.cpp:
  • dfg/DFGVariableEvent.cpp:
  • ftl/FTLCArgumentGetter.h:

(JSC::FTL::CArgumentGetter::CArgumentGetter):
(JSC::FTL::CArgumentGetter::loadNext8):
(JSC::FTL::CArgumentGetter::loadNext32):
(JSC::FTL::CArgumentGetter::loadNext64):
(JSC::FTL::CArgumentGetter::loadNextPtr):
(JSC::FTL::CArgumentGetter::loadNextDouble):

  • ftl/FTLCompile.cpp:
  • ftl/FTLExitThunkGenerator.h:
  • ftl/FTLLink.cpp:
  • ftl/FTLThunks.cpp:
  • jit/AssemblyHelpers.cpp: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.cpp.
  • jit/AssemblyHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h.

(JSC::AssemblyHelpers::AssemblyHelpers):
(JSC::AssemblyHelpers::debugCall):

  • jit/CCallHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGCCallHelpers.h.
  • jit/FPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGFPRInfo.h.

(WTF::printInternal):

  • jit/GPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGGPRInfo.h.

(WTF::printInternal):

  • jit/JIT.cpp:

(JSC::JIT::JIT):

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):

  • jit/JSInterfaceJIT.h:

(JSC::JSInterfaceJIT::JSInterfaceJIT):

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::finalize):

  • jit/ThunkGenerators.cpp:

(JSC::linkForGenerator):
(JSC::virtualForGenerator):
(JSC::stringLengthTrampolineGenerator):
(JSC::nativeForGenerator):
(JSC::arityFixup):
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
(JSC::imulThunkGenerator):

  • llint/LLIntThunks.cpp:

(JSC::LLInt::generateThunkWithJumpTo):

  • runtime/JSCJSValue.h:
11:31 AM Changeset in webkit [156183] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r156140): Srcset tests are frequently crashing
https://bugs.webkit.org/show_bug.cgi?id=121695

Reviewed by Dean Jackson.

Returning a string created without copying bytes is not safe. It used to be OK
because a new string was immediately created by decodeURLEscapeSequences().
But even that was not great, because decodeURLEscapeSequences() could potentially
return the same string, not a deep copy, if we decided to optimize it like that.

Also made a number of drive-by style fixes.

  • It's URL, not Url.
  • It's srcset, not srcSet.
  • We don't add ".0" in floating point value initializers. It's particularly misleading

to initialize a float with 1.0, which is a double value.

  • Renamed srcSetLength to srcsetAttributeLength to match srcsetAttribute variable

whose length it caches.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::parseImagesWithScaleFromSrcsetAttribute):
(WebCore::bestFitSourceForImageAttributes):

11:12 AM Changeset in webkit [156182] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

[GTK] Clean up the Skip* functions in the GObject DOM bindings code generator
https://bugs.webkit.org/show_bug.cgi?id=121633

Reviewed by Gustavo Noronha Silva.

  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipAttribute): Fold in some skipping checks that are used by all callers.
(SkipFunction): Ditto.
(GenerateProperties): Rely on SkipAttribute more thoroughly.
(GenerateFunction): Rely on SkipFunction more thoroughly.
(GenerateFunctions): Rely on SkipAttribute more thoroughly.

10:44 AM Changeset in webkit [156181] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Fix the build after r156144

  • html/canvas/CanvasRenderingContext2D.cpp: Added missing include.
10:32 AM Changeset in webkit [156180] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

renderStyleOfEnclosingTextNode should update style before using a renderer
https://bugs.webkit.org/show_bug.cgi?id=121690

Reviewed by Enrica Casucci.

Merge https://chromium.googlesource.com/chromium/blink/+/65f089545e8c18cb268dfcbe56cba1cd8045527a

When accessing a renderer editing should always make sure that the style has been updated for the node.
Editing calls splitTextNode in a number of places and then accesses the renderer later. This patch is
the first of many to make sure editing always updates the style before attempting to access the renderer
(or style) of a node after calling a mutation method.

  • editing/ApplyBlockElementCommand.cpp:

(WebCore::ApplyBlockElementCommand::renderStyleOfEnclosingTextNode):

  • editing/ApplyBlockElementCommand.h:
10:28 AM Changeset in webkit [156179] by ap@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

Remove URL decoding in srcset handling
https://bugs.webkit.org/show_bug.cgi?id=121609

Followup to <http://trac.webkit.org/changeset/156161> - that change renamed expected
results, but the new test wasn't landed.

  • fast/loader/image-src-encoded.html: Copied from LayoutTests/fast/loader/image-src-question-mark.html.
  • fast/loader/image-src-question-mark.html: Removed.
10:18 AM Changeset in webkit [156178] by Darin Adler
  • 3 edits in trunk/Source/WebCore

Fix a couple more CSS leaks
https://bugs.webkit.org/show_bug.cgi?id=121683

Reviewed by Alexey Proskuryakov.

  • css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::viewSourceStyle): Put the result of the
parseUASheet into a global variable so it doesn't show up as a storage leak.

  • css/CSSGrammar.y.in: Added a missing adoptRef. This was leaking any rule

we parsed individually.

10:16 AM Changeset in webkit [156177] by Patrick Gansterer
  • 1 edit
    4 deletes in trunk/Tools

Nuke remaining VS2005 tools from the tree.
https://bugs.webkit.org/show_bug.cgi?id=121691

Reviewed by Brent Fulgham.

  • CLWrapper/CLWrapper.cpp: Removed.
  • CLWrapper/CLWrapper.sln: Removed.
  • CLWrapper/CLWrapper.vcproj: Removed.
  • MIDLWrapper/MIDLWrapper.cpp: Removed.
  • MIDLWrapper/MIDLWrapper.sln: Removed.
  • MIDLWrapper/MIDLWrapper.vcproj: Removed.
  • Scripts/parallelcl: Removed.
  • vcbin/cl.exe: Removed.
  • vcbin/midl.exe: Removed.
10:16 AM Changeset in webkit [156176] by Bem Jones-Bey
  • 8 edits in trunk/Source/WebCore

Simplify the ShapeOutsideInfo and ShapeInfo interfaces
https://bugs.webkit.org/show_bug.cgi?id=121685

Reviewed by Darin Adler.

With the creation ShapeInfo::computeSegmentsForLine, it became possible to
simplify the ShapeInfo classes. ShapeOutsideInfo has no need to save the
segments, and now that segment creation is in its own method, it doesn't have
to save the segments anymore. This also simplifies the public interface of
ShapeOutsideInfo, as it only has one method to do the computation.

Also, the methods in ShapeOutsideInfo have been renamed to reflect the fact
that ShapeOutsideInfo isn't really interested in segments.

No new tests, no new behavior.

  • rendering/FloatingObjects.cpp:

(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset):

  • rendering/LineWidth.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

  • rendering/shapes/ShapeInfo.cpp:
  • rendering/shapes/ShapeInfo.h:
  • rendering/shapes/ShapeInsideInfo.h:
  • rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):

  • rendering/shapes/ShapeOutsideInfo.h:
10:10 AM Changeset in webkit [156175] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Making tests added in r156157 JS-only, given that other
code generators are still broken.

Original bug 121305 (StrictTypeChecking extended attribute fails for methods with sequence<T>).
https://bugs.webkit.org/show_bug.cgi?id=121305

Patch by Antonio Gomes <a1.gomes@sisa.samsung.com> on 2013-09-20
Rubber stamped by Alexey Proskuryakov.

  • bindings/scripts/test/TestObj.idl:
10:07 AM Changeset in webkit [156174] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Poor rendering opening a Google map short link
https://bugs.webkit.org/show_bug.cgi?id=121687

Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-09-20
Reviewed by Yong Li.
Internally reviewed by Arvid Nilsson.

JIRA 495023
Route lines on google map were shown even they were on a hidden canvas.
Include visibility on LayerWebKitThread if it's a canvas layer and respect
the visibility when compositing layers in LayerRenderer.

  • platform/graphics/blackberry/LayerData.h:

(WebCore::LayerData::isCanvasLayer):
(WebCore::LayerData::isVisible):
(WebCore::LayerData::includeVisibility):

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::compositeLayersRecursive):

9:57 AM Changeset in webkit [156173] by Brent Fulgham
  • 2 edits in trunk/Source/WebInspectorUI

[Windows] Unreviewed gardening. Teach WebInspectorUI.vcxproj folder to
ignore Visual Studio's local user settings file.

  • WebInspectorUI.vcxproj: Added property svn:ignore.
9:48 AM Changeset in webkit [156172] by commit-queue@webkit.org
  • 2 edits in trunk

[CMAKE] FindHarfBuzz: Handle harfbuzz / harfbuzz-icu split
https://bugs.webkit.org/show_bug.cgi?id=121688

Patch by Sergio Correia <Sergio Correia> on 2013-09-20
Reviewed by Martin Robinson.

HarfBuzz 0.9.18 split ICU support into a separate harfbuzz-icu library.
To be able to build with earlier and newer versions of HarfBuzz, we should
check for harfbuzz-icu as well, if version >= 0.9.18.

  • Source/cmake/FindHarfBuzz.cmake: Check for harfbuzz-icu, if version

    0.9.18.

9:45 AM Changeset in webkit [156171] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/win

Fix MIDL files for Visual Studio 2012
https://bugs.webkit.org/show_bug.cgi?id=121552

Reviewed by Brent Fulgham.

The MIDL compiler shipped with Visual Studio 2012 does not accept forward declarations
with typedefs. Use the struct keyword in the function signature to fix this problem.

  • Interfaces/DOMPrivate.idl:
9:45 AM Changeset in webkit [156170] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WTF

Atomics.h does not build on MinGW
https://bugs.webkit.org/show_bug.cgi?id=121663

Reviewed by Darin Adler.

MinGW does not have _ReadWriteBarrier() intrinsic, but does have GCC
inline assembler, so use the GCC definitions instead of MSVC ones.

  • wtf/Atomics.h:

(WTF::compilerFence):

9:40 AM WebInspector edited by timothy@apple.com
(diff)
9:39 AM WebInspector edited by timothy@apple.com
(diff)
9:35 AM Changeset in webkit [156169] by allan.jensen@digia.com
  • 2 edits in trunk/Source/JavaScriptCore

Inline method exported
https://bugs.webkit.org/show_bug.cgi?id=121664

Reviewed by Darin Adler.

WatchDog::didFire() is marked as an exported symbol eventhough it is
defined inline. This breaks the build on MinGW since it results in dllimport
being declared on a definition.

  • runtime/Watchdog.h:

(JSC::Watchdog::didFire):

9:18 AM Changeset in webkit [156168] by commit-queue@webkit.org
  • 4 edits in trunk

AX: WebArea claims to have a subrole, but always returns nil.
https://bugs.webkit.org/show_bug.cgi?id=121658

Patch by Sam White <Samuel White> on 2013-09-20
Reviewed by Chris Fleizach.

Source/WebCore:

No new tests, updated existing AXWebArea related test to reflect unused attribute removal.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

Updated test output to reflect removal of unused NSAccessibilitySubroleAttribute in AXWebArea.

  • platform/mac/accessibility/document-attributes-expected.txt:
8:47 AM Changeset in webkit [156167] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Tools

[GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
https://bugs.webkit.org/show_bug.cgi?id=121294

Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-09-20
Reviewed by Martin Robinson.

Provide a new patch to deal with the issue in the GTK+ module from
the internal jhbuild environment. This issue has been reported
upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).

  • gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
  • gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.
8:34 AM Changeset in webkit [156166] by akling@apple.com
  • 14 edits in trunk/Source/WebCore

Add valueForLength/minimumValueForLength wrappers to RenderElement.
<https://webkit.org/b/121676>

Reviewed by Antti Koivisto.

Add two inline wrappers for these functions so we don't have to pass
the RenderView everywhere.

8:20 AM Changeset in webkit [156165] by commit-queue@webkit.org
  • 4 edits in trunk

[ATK][WTR] accessibility/aria-invalid.html times out
https://bugs.webkit.org/show_bug.cgi?id=121668

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-09-20
Reviewed by Mario Sanchez Prada.

Tools:

Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
false in case of aria-invalid event with empty value.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
case of aria-invalid event with empty value.

LayoutTests:

Updated the expectation of aria-invalid.html test, which was timing out
before bug 120421 and this fix.

  • platform/gtk-wk2/TestExpectations: Removed aria-invalid.html because

it now passes with this fix and the patch from bug 120421.

8:15 AM Changeset in webkit [156164] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk/Tools

[ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
https://bugs.webkit.org/show_bug.cgi?id=120421

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-09-20
Reviewed by Mario Sanchez Prada.

Implemented the notification listener for AccessibilityUIElement for
WebKitTestRunner. The signal is generated by
AXObjectCache::postPlatformNotification() and received by
axObjectEventListener(). axObjectEventListener() will then invoke
JSObjectCallAsFunction() with the respective callback function. The
notification handlers are stored in HashMap in
AccessibilityNotificationHandlerAtk.cpp.

Moved ATK signal handling (printAccessibilityEvent and
axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.

  • WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the

include path.

  • WebKitTestRunner/GNUmakefile.am:

Added AccessibilityNotificationHandlerAtk.cpp/h.

  • WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved

listener IDs to AccessibilityNotificationHandlerAtk.cpp.

  • WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved

listener IDs to AccessibilityNotificationHandlerAtk.cpp.

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a

notification handler for GTK+ and EFL.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:

Moved printAccessibilityEvent and axObjectEventListener to
AccessibilityNotificationHandlerAtk.cpp.
(WTR::AccessibilityController::logAccessibilityEvents): Moved listener
IDs to AccessibilityNotificationHandlerAtk.cpp.
(WTR::AccessibilityController::resetToConsistentState): Moved listener
IDs to AccessibilityNotificationHandlerAtk.cpp.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.

(WTR::printAccessibilityEvent): Prints accessibility events. This
function was moved from AccessibilityControllerAtk.cpp.
(WTR::axObjectEventListener): Callback for signals. This function was
moved from AccessibilityControllerAtk.cpp.
(WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
Initialize element and function callback.
(WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
Removes handler from HashMap and disconnects callbacks if necessary.
(WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
logging mode and connects callbacks.
(WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
Sets the notification callback and connects callback to signals.
(WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
Removes the notification callback from HashMap.
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
Connects axObjectEventListener to ATK signals.
(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
Disconnects callback.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.

(WTR::AccessibilityNotificationHandler::create): Creates a new instance
of AccessibilityNotificationHandler.
(WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
element.
(WTR::AccessibilityNotificationHandler::platformElement): Gets the
element.
(WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
Gets the notification callback.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::addNotificationListener): Creates
notification handler, set the platform element and the notification
callback.
(WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
notification handler.

  • WebKitTestRunner/PlatformEfl.cmake:

Added AccessibilityNotificationHandlerAtk.cpp.

8:04 AM Changeset in webkit [156163] by Martin Robinson
  • 44 edits in trunk/Source/WebCore

[GTK] Fix some small style issues in the bindings
https://bugs.webkit.org/show_bug.cgi?id=121613

Reviewed by Carlos Garcia Campos.

  • bindings/scripts/CodeGeneratorGObject.pm: When printing the license

header use the more common comment style within the WebKit project.
(GenerateProperty): Indent property definitions according to WebKit style, improve
the nick and blurb properties, and improve the various parameter spec argument layout.
(GenerateFunction): Remove the newline from function signatures to match WebKit style.

  • bindings/scripts/test/GObject: Update bindings test results.
7:58 AM Changeset in webkit [156162] by zarvai@inf.u-szeged.hu
  • 4 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebase after Qt 5.1.1 and skip failing tests.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-20

  • platform/qt-wk1/TestExpectations:
  • platform/qt-wk2/TestExpectations:
  • platform/qt-wk2/fast/forms/submit-to-blank-multiple-times-expected.txt: Added.
  • platform/qt/TestExpectations:
7:43 AM Changeset in webkit [156161] by commit-queue@webkit.org
  • 1 edit
    5 moves in trunk/LayoutTests

Modified img src and srcset encoded URL tests
https://bugs.webkit.org/show_bug.cgi?id=121677

Previous tests have broken the Windows builds, since '?' is not a valid char.
Moved to using '@'

Patch by Yoav Weiss <yoav@yoav.ws> on 2013-09-20
Reviewed by Anders Carlsson.

  • fast/hidpi/image-srcset-encoded-expected.txt: Renamed from LayoutTests/fast/hidpi/image-srcset-question-mark-expected.txt.
  • fast/hidpi/image-srcset-encoded.html: Renamed from LayoutTests/fast/hidpi/image-srcset-question-mark.html.
  • fast/hidpi/resources/image@test.png: Renamed from LayoutTests/fast/hidpi/resources/image?test.png.
  • fast/loader/image-src-encoded-expected.txt: Renamed from LayoutTests/fast/loader/image-src-question-mark-expected.txt.
  • fast/loader/resources/image@test.png: Renamed from LayoutTests/fast/loader/resources/image?test.png.
7:12 AM Changeset in webkit [156160] by zarvai@inf.u-szeged.hu
  • 1 edit
    16 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Update tests after r156066 and r156083.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-20

  • platform/qt-wk1/fast/forms/HTMLOptionElement_label06-expected.png: Added r156083.
  • platform/qt-wk1/fast/forms/HTMLOptionElement_label06-expected.txt: Added r156083.
  • platform/qt-wk1/fast/forms/HTMLOptionElement_label07-expected.png: Added r156083.
  • platform/qt-wk1/fast/forms/HTMLOptionElement_label07-expected.txt: Added r156083.
  • platform/qt-wk1/fast/forms/form-element-geometry-expected.png: Added r156083.
  • platform/qt-wk1/fast/forms/form-element-geometry-expected.txt: Added r156083.
  • platform/qt-wk1/fast/forms/menulist-separator-painting-expected.txt: Added r156083.
  • platform/qt-wk1/fast/forms/select-baseline-expected.png: Added r156083.
  • platform/qt-wk1/fast/forms/select-baseline-expected.txt: Added r156083.
  • platform/qt-wk1/fast/forms/selectlist-minsize-expected.txt: Added r156083.
  • platform/qt-wk1/fast/replaced/three-selects-break-expected.txt: Added r156083.
  • platform/qt-wk1/js/dom/switch-behaviour-expected.txt: Added r156066.
6:23 AM Changeset in webkit [156159] by Patrick Gansterer
  • 8 edits in trunk/Source

[CMake] Use COMPILE_DEFINITIONS target property for setting BUILDING_* defines
https://bugs.webkit.org/show_bug.cgi?id=121672

Reviewed by Gyuyoung Kim.

Since the scope of add_definitions() is always a whole file, we need to use
target properties instead to set definitions only for specific targets.

Source/JavaScriptCore:

  • CMakeLists.txt:

Source/WebCore:

  • CMakeLists.txt:

Source/WebKit:

  • CMakeLists.txt:

Source/WTF:

  • wtf/CMakeLists.txt:
6:17 AM Changeset in webkit [156158] by tonikitoo@webkit.org
  • 9 edits in trunk

Source/WebCore: Make "autoscroll for drag'n drop" a setting
https://bugs.webkit.org/show_bug.cgi?id=121559

Reviewed by Ryosuke Niwa.
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>

Currently, there is a ChromeClient hook to make the
feature opt'ed-in or out. That makes it harder to test the
feature on ports that do not enable it, e.g. Mac/WebKit2 port.
However, Mac/WebKit2 is the port that has the best drag'n drop
WTR implementation.

Patch changes the toggle on/off mechanism to be a setting,
and exposes it through InternalSetting interface for testing.

  • page/AutoscrollController.cpp:

(WebCore::AutoscrollController::updateDragAndDrop):

  • page/ChromeClient.h:
  • page/Settings.in:
  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setAutoscrollForDragAndDropEnabled):

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:

LayoutTests: Make "autoscroll" for drag'n drop a setting
https://bugs.webkit.org/show_bug.cgi?id=121559

  • fast/events/drag-and-drop-autoscroll.html:

Adapts the test so that is toggles the feature on
via InternalSettings interface.

6:16 AM Changeset in webkit [156157] by tonikitoo@webkit.org
  • 6 edits in trunk/Source/WebCore

StrictTypeChecking extended attribute fails for methods with sequence<T> https://bugs.webkit.org/show_bug.cgi?id=121305

Reviewed by Darin Adler.
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>

The extended attribute StrictTypeChecking can not be set to methods if
one of the parameters is a "sequence".
Basically, since "sequence" is not considered a native type
(see function IsNativeType) the Perl code generator tries to
include its supposedly associated header, in this case "JSsequence.h"
Compilation then fails.

It is a problem for bindings including WebGL, where all methods
are supposed to be set as StrictTypeChecking (see bug 44202 [1]). Due to this restriction,
it relaxed, but I would like to bring it back.

Patch fixes the issue by hardening the way includes are auto-added
for methods where StrictTypeChecking extended attribute is present.
Now, only wrapper types (see IsWrapperType) trigger header inclusion,
excluding arrays, sequences, basic types, etc.

[1] https://bugs.webkit.org/show_bug.cgi?id=44202

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionStrictFunctionWithSequence):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/TestObj.idl:
5:28 AM Changeset in webkit [156156] by zarvai@inf.u-szeged.hu
  • 17 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Update tests after change to Qt 5.1.1

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-20

  • platform/qt/css1/text_properties/letter_spacing-expected.png:
  • platform/qt/css1/text_properties/letter_spacing-expected.txt:
  • platform/qt/fast/css/first-line-text-decoration-expected.png:
  • platform/qt/fast/css/first-line-text-decoration-expected.txt:
  • platform/qt/fast/css/first-line-text-decoration-inherited-from-parent-expected.png:
  • platform/qt/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
  • platform/qt/fast/css/word-space-extra-expected.png:
  • platform/qt/fast/css/word-space-extra-expected.txt:
  • platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.png:
  • platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt:
  • platform/qt/fast/text/basic/003-expected.png:
  • platform/qt/fast/text/basic/003-expected.txt:
  • platform/qt/fast/text/basic/013-expected.png:
  • platform/qt/fast/text/basic/013-expected.txt:
  • platform/qt/fast/text/text-letter-spacing-expected.png:
  • platform/qt/fast/text/text-letter-spacing-expected.txt:
5:16 AM Changeset in webkit [156155] by akling@apple.com
  • 38 edits in trunk/Source/WebCore

Optimize fetching the Node for never-anonymous renderers.
<https://webkit.org/b/121627>

Reviewed by Antti Koivisto.

Add a RenderObject::nodeForNonAnonymous() that can be used instead
of node() when a renderer is guaranteed non-anonymous.

Use this to implement reference element getters for the various
renderers that are known at compile-time to correspond to a DOM node.

Also renamed existingElement() => element() since using an alternate
name for a reference overload isn't actually necessary.

4:56 AM Changeset in webkit [156154] by Patrick Gansterer
  • 7 edits in trunk/Source

Remove duplicated secondsPerDay variables
https://bugs.webkit.org/show_bug.cgi?id=121601

Reviewed by Andreas Kling.

Source/WebCore:

Use secondsPerDay from DateMath.h instead of defining it again.

  • history/HistoryItem.cpp:

(WebCore::timeToDay):

Source/WebKit/win:

Use secondsPerDay from DateMath.h instead of defining it again.

  • MarshallingHelpers.cpp:

Source/WTF:

Move secondsPerDay from the source into the header file
to make it accessible by other code too.

  • wtf/DateMath.cpp:
  • wtf/DateMath.h:
4:54 AM Changeset in webkit [156153] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Fix duplicated loop variable names after r155743
https://bugs.webkit.org/show_bug.cgi?id=121667

Reviewed by Andreas Kling.

Do not use the same name for variables in nested loops to fix a compiler warning.

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

4:51 AM Changeset in webkit [156152] by allan.jensen@digia.com
  • 2 edits in trunk/Tools

Update features.pri
https://bugs.webkit.org/show_bug.cgi?id=121670

Reviewed by Jocelyn Turcotte.

Remove feature flags that no longer exists and new ones added to FeatureList.pm

  • qmake/mkspecs/features/features.pri:
4:44 AM Changeset in webkit [156151] by Antti Koivisto
  • 27 edits in trunk/Source/WebCore

Make RenderObject::parent() return RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121671

Reviewed by Andreas Kling.

Make RenderObject::parent() return RenderElement and adopt everywhere.
Moved addChild/removeChild from RenderObject to RenderElement.
Uninlined a few big RenderObject functions.
Renamed RenderObject::remove() -> RenderObject::removeFromParent()

4:32 AM Changeset in webkit [156150] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebCore

Buildfix after r156133 for !ENABLE(WORKERS) platforms
https://bugs.webkit.org/show_bug.cgi?id=121669

Reviewed by Antti Koivisto.

  • platform/ThreadGlobalData.cpp:
  • platform/ThreadGlobalData.h:
4:18 AM Changeset in webkit [156149] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK][WK2] accessibility/selection-states.html is failing
https://bugs.webkit.org/show_bug.cgi?id=116972

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-20
Reviewed by Mario Sanchez Prada.

Tools:

isSelectable() was not exposed in Accessibility.

  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:

LayoutTests:

Unskipping accessibility/selection-states.html test.

  • platform/gtk-wk2/TestExpectations:
3:58 AM Changeset in webkit [156148] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/win

Add covariant RenderElement* Element::renderer()
https://bugs.webkit.org/show_bug.cgi?id=121638

Unreviewed buildfix after r156144.

  • DOMCoreClasses.cpp:

(DOMElement::boundingBox):
(DOMElement::font):

2:59 AM Changeset in webkit [156147] by Antti Koivisto
  • 135 edits in trunk/Source/WebCore

Make createRenderer() return RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121666

Rubber-stamped by Andreas Kling.

Tighter typing.

2:52 AM Changeset in webkit [156146] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Buildfix for ENABLE(CSS_FILTERS) && !ENABLE(ACCELERATED_COMPOSITING) after r155131.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::enclosingFilterRepaintLayer):

2:51 AM Changeset in webkit [156145] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

[WIN] Fix build without precompiled header after r154146.

  • platform/win/WebCoreBundleWin.cpp:
2:48 AM BadContent edited by zandobersek@gmail.com
Block a spamming account. (diff)
1:59 AM Changeset in webkit [156144] by Antti Koivisto
  • 22 edits in trunk/Source/WebCore

Add covariant RenderElement* Element::renderer()
https://bugs.webkit.org/show_bug.cgi?id=121638

Reviewed by Andreas Kling.

Also add isRenderElement() test and casting functions.

12:34 AM Changeset in webkit [156143] by zarvai@inf.u-szeged.hu
  • 5 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebase tests.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-20

  • platform/qt-wk2/fast/css/word-space-extra-expected.png: Added r155957.
  • platform/qt/fast/css/pseudo-first-line-border-width-expected.png: Rebase after r155957.
  • platform/qt/fast/css/pseudo-first-line-border-width-expected.txt: Rebase after r155957.
  • platform/qt/fast/css/word-space-extra-expected.txt: Rebase after r155957.
  • platform/qt/fast/forms/select-empty-option-height-expected.txt: Rebase after rr156040.

Sep 19, 2013:

11:08 PM Changeset in webkit [156142] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Handle null font families.

Reviewed by Darin Adler.

  • platform/graphics/Font.cpp:

(WebCore::computeFontGlyphsCacheHash):
Don't crash when trying to hash null strings.

10:57 PM Changeset in webkit [156141] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Fix a couple mistakes in my recent CSS grammar leak patch
https://bugs.webkit.org/show_bug.cgi?id=121659

Reviewed by Alexey Proskuryakov.

  • css/CSSGrammar.y.in: Added initialization to nullptr for some error cases

that were otherwise leaving a bad value for the result of the production.
Also fixed a reversed logical expression.

10:02 PM Changeset in webkit [156140] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

Remove URL decoding in srcset handling
https://bugs.webkit.org/show_bug.cgi?id=121609

Patch by Yoav Weiss <yoav@yoav.ws> on 2013-09-19
Reviewed by Benjamin Poulain.

Source/WebCore:

Tests: fast/hidpi/image-srcset-question-mark.html

fast/loader/image-src-question-mark.html

Removed URL decoding from src and srcset's handling algorithm, since they break encoded URLS.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::parseImagesWithScaleFromSrcSetAttribute):
(WebCore::bestFitSourceForImageAttributes):

LayoutTests:

These tests make sure that encoded URLs are properly handled, and especially URLs
with a question mark in them.

  • fast/hidpi/image-srcset-question-mark-expected.txt: Added.
  • fast/hidpi/image-srcset-question-mark.html: Added.
  • fast/hidpi/resources/image?test.png: Added.
  • fast/loader/image-src-question-mark-expected.txt: Added.
  • fast/loader/image-src-question-mark.html: Added.
  • fast/loader/resources/image?test.png: Added.
9:46 PM Changeset in webkit [156139] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Avoid calling AtomicString::lower() in makeFontGlyphsCacheKey
https://bugs.webkit.org/show_bug.cgi?id=121656

Reviewed by Darin Adler.

Instead of lower casing AtomicStrings, store the strings as is and use the case folding
hash and case insensitive compare to determine equality.

  • platform/graphics/Font.cpp:

(WebCore::operator==):
(WebCore::makeFontGlyphsCacheKey):
(WebCore::computeFontGlyphsCacheHash):

9:29 PM Changeset in webkit [156138] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Fix leaks in CSS parser caused by overwriting owned raw pointers with 0
https://bugs.webkit.org/show_bug.cgi?id=121655

Reviewed by Anders Carlsson.

  • css/CSSGrammar.y.in: Use nullptr instead of 0. Use unique_ptr instead

of a raw pointer in cases where we might or might not actually keep
the allocated memory. This can still be cleaned up further, but this
should fix the memory leaks we have been seeing.

9:07 PM Changeset in webkit [156137] by g.czajkowski@samsung.com
  • 18 edits in trunk/LayoutTests

Use shouldBecomeEqual in asynchronous spellchecking tests.
https://bugs.webkit.org/show_bug.cgi?id=121483

Reviewed by Darin Adler.

Every asynchronous spellchecking layout test waits for spelling or grammar
markers using setTimeout. It duplicates the code, moreover the implementation
differs in every test.

Use shouldBecomeEqual helper (introduced in r143860) to test spellchecking
asynchronously.

  • editing/spelling/grammar-markers-expected.txt:
  • editing/spelling/grammar-markers-hidpi-expected.txt:
  • editing/spelling/grammar-markers-hidpi.html:
  • editing/spelling/grammar-markers.html:
  • editing/spelling/grammar-paste-expected.txt:
  • editing/spelling/grammar-paste.html:

Dump text of destination element instead of source one to show what is
really tested. It stops outputting that the input and textarea elements
can store html tags, for example,
PASS INPUT has a marker on 'I have a<b>n ki</b>wi'.

  • editing/spelling/script-tests/spellcheck-paste.js:

(verifyMarker):
(pasteAndVerify):

  • editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
  • editing/spelling/spellcheck-paste-continuous-disabled.html:
  • editing/spelling/spellcheck-paste-disabled-expected.txt:
  • editing/spelling/spellcheck-paste-disabled.html:

At the beginning, those tests check whether spelling marker appears
synchronously. Then, spell checking is disabled to check whether
the markers have disappeared properly.
There is no need to check spelling asynchronously in the second part
of the tests. Use synchronous spellchecking path instead.

  • editing/spelling/spellcheck-paste-expected.txt:
  • editing/spelling/spelling-marker-description-expected.txt:
  • editing/spelling/spelling-marker-description.html:
  • platform/efl-wk2/editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
  • platform/mac/editing/spelling/grammar-markers-expected.png:
  • platform/mac/editing/spelling/grammar-markers-hidpi-expected.png:
7:05 PM Changeset in webkit [156136] by Brent Fulgham
  • 37 edits
    5 adds
    5 deletes in trunk/Source/JavaScriptCore

Unreviewed, rolling out r156120.
http://trac.webkit.org/changeset/156120
https://bugs.webkit.org/show_bug.cgi?id=121651

Broke windows runtime and all tests (Requested by bfulgham on
#webkit).

Patch by Commit Queue <commit-queue@webkit.org> on 2013-09-19

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/ValueRecovery.h:

(JSC::ValueRecovery::dumpInContext):

  • dfg/DFGAssemblyHelpers.cpp: Renamed from Source/JavaScriptCore/jit/AssemblyHelpers.cpp.

(JSC::DFG::AssemblyHelpers::executableFor):
(JSC::DFG::AssemblyHelpers::decodedCodeMapFor):
(JSC::DFG::AssemblyHelpers::setSamplingFlag):
(JSC::DFG::AssemblyHelpers::clearSamplingFlag):
(JSC::DFG::AssemblyHelpers::jitAssertIsInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSNumber):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSDouble):
(JSC::DFG::AssemblyHelpers::jitAssertIsCell):
(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):

  • dfg/DFGAssemblyHelpers.h: Renamed from Source/JavaScriptCore/jit/AssemblyHelpers.h.

(JSC::DFG::AssemblyHelpers::AssemblyHelpers):
(JSC::DFG::AssemblyHelpers::codeBlock):
(JSC::DFG::AssemblyHelpers::vm):
(JSC::DFG::AssemblyHelpers::assembler):
(JSC::DFG::AssemblyHelpers::preserveReturnAddressAfterCall):
(JSC::DFG::AssemblyHelpers::restoreReturnAddressBeforeReturn):
(JSC::DFG::AssemblyHelpers::emitGetFromCallFrameHeaderPtr):
(JSC::DFG::AssemblyHelpers::emitPutToCallFrameHeader):
(JSC::DFG::AssemblyHelpers::emitPutImmediateToCallFrameHeader):
(JSC::DFG::AssemblyHelpers::branchIfNotCell):
(JSC::DFG::AssemblyHelpers::addressFor):
(JSC::DFG::AssemblyHelpers::tagFor):
(JSC::DFG::AssemblyHelpers::payloadFor):
(JSC::DFG::AssemblyHelpers::branchIfNotObject):
(JSC::DFG::AssemblyHelpers::selectScratchGPR):
(JSC::DFG::AssemblyHelpers::debugCall):
(JSC::DFG::AssemblyHelpers::jitAssertIsInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSInt32):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSNumber):
(JSC::DFG::AssemblyHelpers::jitAssertIsJSDouble):
(JSC::DFG::AssemblyHelpers::jitAssertIsCell):
(JSC::DFG::AssemblyHelpers::jitAssertHasValidCallFrame):
(JSC::DFG::AssemblyHelpers::boxDouble):
(JSC::DFG::AssemblyHelpers::unboxDouble):
(JSC::DFG::AssemblyHelpers::boxInt52):
(JSC::DFG::AssemblyHelpers::emitExceptionCheck):
(JSC::DFG::AssemblyHelpers::emitCount):
(JSC::DFG::AssemblyHelpers::globalObjectFor):
(JSC::DFG::AssemblyHelpers::strictModeFor):
(JSC::DFG::AssemblyHelpers::baselineCodeBlockFor):
(JSC::DFG::AssemblyHelpers::baselineCodeBlock):
(JSC::DFG::AssemblyHelpers::argumentsRegisterFor):
(JSC::DFG::AssemblyHelpers::symbolTableFor):
(JSC::DFG::AssemblyHelpers::offsetOfLocals):
(JSC::DFG::AssemblyHelpers::offsetOfArgumentsIncludingThis):

  • dfg/DFGBinarySwitch.h:
  • dfg/DFGByteCodeParser.cpp:
  • dfg/DFGCCallHelpers.h: Renamed from Source/JavaScriptCore/jit/CCallHelpers.h.

(JSC::DFG::CCallHelpers::CCallHelpers):
(JSC::DFG::CCallHelpers::resetCallArguments):
(JSC::DFG::CCallHelpers::addCallArgument):
(JSC::DFG::CCallHelpers::setupArguments):
(JSC::DFG::CCallHelpers::setupArgumentsExecState):
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(JSC::DFG::CCallHelpers::setupTwoStubArgs):
(JSC::DFG::CCallHelpers::setupStubArguments):
(JSC::DFG::CCallHelpers::setupResults):

  • dfg/DFGDisassembler.cpp:
  • dfg/DFGFPRInfo.h: Renamed from Source/JavaScriptCore/jit/FPRInfo.h.

(JSC::DFG::FPRInfo::toRegister):
(JSC::DFG::FPRInfo::toIndex):
(JSC::DFG::FPRInfo::toArgumentRegister):
(JSC::DFG::FPRInfo::debugName):

  • dfg/DFGGPRInfo.h: Renamed from Source/JavaScriptCore/jit/GPRInfo.h.

(JSC::DFG::JSValueRegs::JSValueRegs):
(JSC::DFG::JSValueRegs::payloadOnly):
(JSC::DFG::JSValueRegs::operator!):
(JSC::DFG::JSValueRegs::gpr):
(JSC::DFG::JSValueRegs::payloadGPR):
(JSC::DFG::JSValueSource::JSValueSource):
(JSC::DFG::JSValueSource::unboxedCell):
(JSC::DFG::JSValueSource::operator!):
(JSC::DFG::JSValueSource::isAddress):
(JSC::DFG::JSValueSource::offset):
(JSC::DFG::JSValueSource::base):
(JSC::DFG::JSValueSource::gpr):
(JSC::DFG::JSValueSource::asAddress):
(JSC::DFG::JSValueSource::notAddress):
(JSC::DFG::JSValueRegs::tagGPR):
(JSC::DFG::JSValueSource::tagGPR):
(JSC::DFG::JSValueSource::payloadGPR):
(JSC::DFG::JSValueSource::hasKnownTag):
(JSC::DFG::JSValueSource::tag):
(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):
(JSC::DFG::GPRInfo::toArgumentRegister):

  • dfg/DFGGraph.cpp:
  • dfg/DFGGraph.h:
  • dfg/DFGJITCompiler.h:
  • dfg/DFGOSRExit.cpp:
  • dfg/DFGOSRExit.h:
  • dfg/DFGOSRExitCompiler.h:
  • dfg/DFGOSRExitCompilerCommon.h:
  • dfg/DFGRegisterBank.h:
  • dfg/DFGRegisterSet.h:
  • dfg/DFGRepatch.cpp:
  • dfg/DFGSilentRegisterSavePlan.h:
  • dfg/DFGThunks.cpp:
  • dfg/DFGVariableEvent.cpp:
  • ftl/FTLCArgumentGetter.h:

(JSC::FTL::CArgumentGetter::CArgumentGetter):
(JSC::FTL::CArgumentGetter::loadNext8):
(JSC::FTL::CArgumentGetter::loadNext32):
(JSC::FTL::CArgumentGetter::loadNext64):
(JSC::FTL::CArgumentGetter::loadNextPtr):
(JSC::FTL::CArgumentGetter::loadNextDouble):

  • ftl/FTLCompile.cpp:
  • ftl/FTLExitThunkGenerator.h:
  • ftl/FTLLink.cpp:
  • ftl/FTLThunks.cpp:
  • jit/JIT.cpp:

(JSC::JIT::JIT):

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):

  • jit/JSInterfaceJIT.h:

(JSC::JSInterfaceJIT::preserveReturnAddressAfterCall):
(JSC::JSInterfaceJIT::restoreReturnAddressBeforeReturn):

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::finalize):

  • jit/ThunkGenerators.cpp:

(JSC::linkForGenerator):
(JSC::virtualForGenerator):
(JSC::stringLengthTrampolineGenerator):
(JSC::nativeForGenerator):
(JSC::arityFixup):
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
(JSC::imulThunkGenerator):

  • llint/LLIntThunks.cpp:

(JSC::LLInt::generateThunkWithJumpTo):

  • runtime/JSCJSValue.h:
6:51 PM Changeset in webkit [156135] by eric.carlson@apple.com
  • 8 edits
    2 adds in trunk

MediaStream API: update MediaStreamTrackEvent object to match spec
https://bugs.webkit.org/show_bug.cgi?id=121624

Reviewed by Dean Jackson.

Source/WebCore:

Test: fast/mediastream/MediaStreamTrackEvent-constructor.html

  • Modules/mediastream/MediaStreamTrack.idl: Remove NoInterfaceObject.
  • Modules/mediastream/MediaStreamTrackEvent.cpp:

(WebCore::MediaStreamTrackEventInit::MediaStreamTrackEventInit): New.
(WebCore::MediaStreamTrackEvent::create): New form that takes an initialize.
(WebCore::MediaStreamTrackEvent::MediaStreamTrackEvent): Ditto.

  • Modules/mediastream/MediaStreamTrackEvent.h:
  • Modules/mediastream/MediaStreamTrackEvent.idl:
  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue): New.

  • bindings/js/JSDictionary.h:

LayoutTests:

  • fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt: Added.
  • fast/mediastream/MediaStreamTrackEvent-constructor.html: Added.
6:41 PM Changeset in webkit [156134] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

ASSERTs in isMainThread after USE(WEB_THREAD) MainThread changes
https://bugs.webkit.org/show_bug.cgi?id=121650

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-19
Reviewed by Benjamin Poulain.

  • wtf/mac/MainThreadMac.mm:

(WTF::initializeMainThreadPlatform):

6:10 PM Changeset in webkit [156133] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Remove #if !ENABLE(WORKERS) code in ThreadGlobalData
https://bugs.webkit.org/show_bug.cgi?id=121649

Reviewed by Sam Weinig.

This lets us remove a FIXME. Also, move threadGlobalData out of line; there's no need for it to be inline.

  • WebCore.exp.in:
  • platform/ThreadGlobalData.cpp:

(WebCore::threadGlobalData):

  • platform/ThreadGlobalData.h:
6:00 PM Changeset in webkit [156132] by andersca@apple.com
  • 19 edits in trunk/Source/WebCore

Modernize Length setters/getters
https://bugs.webkit.org/show_bug.cgi?id=121647

Reviewed by Andreas Kling.

Add a move constructor and move assignment operator to Length and fixup some of the getters and setters.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyLength::setValue):
(WebCore::ApplyPropertyLength::createHandler):
(WebCore::ApplyPropertyBorderRadius::setValue):
(WebCore::ApplyPropertyBorderRadius::createHandler):
(WebCore::ApplyPropertyLineHeight::createHandler):

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::LengthPropertyWrapper::LengthPropertyWrapper):
(WebCore::LengthPropertyWrapper::blend):
(WebCore::FillLayerPropertyWrapper::FillLayerPropertyWrapper):
(WebCore::FillLayerPropertyWrapper::blend):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

  • platform/CalculationValue.h:

(WebCore::CalcExpressionLength::CalcExpressionLength):
(WebCore::CalcExpressionBlendLength::CalcExpressionBlendLength):

  • platform/Length.cpp:

(WebCore::CalculationValueHandleMap::remove):
(WebCore::CalculationValueHandleMap::find):
(WebCore::Length::decrementCalculatedRef):

  • platform/Length.h:

(WebCore::Length::Length):
(WebCore::Length::operator=):
(WebCore::Length::moveFromLength):

  • platform/LengthBox.cpp:

(WebCore::LengthBox::logicalLeft):
(WebCore::LengthBox::logicalRight):
(WebCore::LengthBox::before):
(WebCore::LengthBox::after):
(WebCore::LengthBox::start):
(WebCore::LengthBox::end):

  • platform/LengthBox.h:

(WebCore::LengthBox::LengthBox):
(WebCore::LengthBox::left):
(WebCore::LengthBox::right):
(WebCore::LengthBox::top):
(WebCore::LengthBox::bottom):

  • platform/LengthSize.h:

(WebCore::LengthSize::LengthSize):
(WebCore::LengthSize::setWidth):
(WebCore::LengthSize::width):
(WebCore::LengthSize::setHeight):
(WebCore::LengthSize::height):

  • platform/graphics/filters/FilterOperation.h:

(WebCore::FilterOperation::BlurFilterOperation::create):
(WebCore::FilterOperation::BlurFilterOperation::stdDeviation):
(WebCore::FilterOperation::BlurFilterOperation::BlurFilterOperation):

  • rendering/style/BasicShapes.h:

(WebCore::BasicShapeRectangle::x):
(WebCore::BasicShapeRectangle::y):
(WebCore::BasicShapeRectangle::width):
(WebCore::BasicShapeRectangle::height):
(WebCore::BasicShapeRectangle::cornerRadiusX):
(WebCore::BasicShapeRectangle::cornerRadiusY):
(WebCore::BasicShapeRectangle::setX):
(WebCore::BasicShapeRectangle::setY):
(WebCore::BasicShapeRectangle::setWidth):
(WebCore::BasicShapeRectangle::setHeight):
(WebCore::BasicShapeRectangle::setCornerRadiusX):
(WebCore::BasicShapeRectangle::setCornerRadiusY):
(WebCore::BasicShapeCircle::centerX):
(WebCore::BasicShapeCircle::centerY):
(WebCore::BasicShapeCircle::radius):
(WebCore::BasicShapeCircle::setCenterX):
(WebCore::BasicShapeCircle::setCenterY):
(WebCore::BasicShapeCircle::setRadius):
(WebCore::BasicShapeEllipse::centerX):
(WebCore::BasicShapeEllipse::centerY):
(WebCore::BasicShapeEllipse::radiusX):
(WebCore::BasicShapeEllipse::radiusY):
(WebCore::BasicShapeEllipse::setCenterX):
(WebCore::BasicShapeEllipse::setCenterY):
(WebCore::BasicShapeEllipse::setRadiusX):
(WebCore::BasicShapeEllipse::setRadiusY):
(WebCore::BasicShapePolygon::getXAt):
(WebCore::BasicShapePolygon::getYAt):
(WebCore::BasicShapePolygon::appendPoint):
(WebCore::BasicShapeInsetRectangle::top):
(WebCore::BasicShapeInsetRectangle::right):
(WebCore::BasicShapeInsetRectangle::bottom):
(WebCore::BasicShapeInsetRectangle::left):
(WebCore::BasicShapeInsetRectangle::cornerRadiusX):
(WebCore::BasicShapeInsetRectangle::cornerRadiusY):
(WebCore::BasicShapeInsetRectangle::setTop):
(WebCore::BasicShapeInsetRectangle::setRight):
(WebCore::BasicShapeInsetRectangle::setBottom):
(WebCore::BasicShapeInsetRectangle::setLeft):
(WebCore::BasicShapeInsetRectangle::setCornerRadiusX):
(WebCore::BasicShapeInsetRectangle::setCornerRadiusY):

  • rendering/style/FillLayer.h:

(WebCore::FillSize::FillSize):
(WebCore::FillLayer::xPosition):
(WebCore::FillLayer::yPosition):
(WebCore::FillLayer::sizeLength):
(WebCore::FillLayer::setXPosition):
(WebCore::FillLayer::setYPosition):

  • rendering/style/NinePieceImage.cpp:

(WebCore::NinePieceImage::NinePieceImage):

  • rendering/style/NinePieceImage.h:

(WebCore::NinePieceImage::setImageSlices):
(WebCore::NinePieceImage::setBorderSlices):
(WebCore::NinePieceImage::setOutset):
(WebCore::NinePieceImage::computeOutset):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::specifiedLineHeight):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleBoxData.h:

(WebCore::StyleBoxData::width):
(WebCore::StyleBoxData::height):
(WebCore::StyleBoxData::minWidth):
(WebCore::StyleBoxData::minHeight):
(WebCore::StyleBoxData::maxWidth):
(WebCore::StyleBoxData::maxHeight):
(WebCore::StyleBoxData::verticalAlign):

  • rendering/style/StyleReflection.h:

(WebCore::StyleReflection::offset):
(WebCore::StyleReflection::setOffset):

5:22 PM Changeset in webkit [156131] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Out-of-line InspectorValues create() methods.
<https://webkit.org/b/121639>

Reviewed by Joseph Pecoraro.

These functions are hardly performance-critical and are taking up
quite a lot of space.

Shrinks the WebCore binary by 70500 bytes.

4:19 PM Changeset in webkit [156130] by ap@apple.com
  • 23 edits in trunk

Layout Test http/tests/security/canvas-remote-read-remote-image-redirect.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=121458

Reviewed by Sam Weinig.

Source/WebCore:

The code to automagically produce line numbers is quite fragile. Added some FIXMEs,
and added an issue that was making reporting flaky for code is JS event handlers
executed while parsing was paused.

  • page/PageConsole.cpp: (WebCore::PageConsole::addMessage): Use actual "script is

running" check instead of "parsing a script element" one.

LayoutTests:

  • fast/frames/sandboxed-iframe-attribute-parsing-06-expected.txt:
  • fast/frames/sandboxed-iframe-attribute-parsing-07-expected.txt:
  • fast/frames/sandboxed-iframe-attribute-parsing-08-expected.txt:
  • fast/frames/sandboxed-iframe-attribute-parsing-09-expected.txt:
  • fast/frames/sandboxed-iframe-attribute-parsing-10-expected.txt:
  • fast/frames/sandboxed-iframe-attribute-parsing-11-expected.txt:
  • fast/frames/sandboxed-iframe-attribute-parsing-12-expected.txt:
  • fast/frames/sandboxed-iframe-attribute-parsing-13-expected.txt:
  • fast/frames/sandboxed-iframe-attribute-parsing-14-expected.txt:
  • fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
  • fast/frames/sandboxed-iframe-scripting-04-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-invalid-header-expected.txt:
  • http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
  • media/video-controls-no-scripting-expected.txt:

We now get a line number for blocked inline scripts, which is a progression.
It is the line number for the closing </script>, which is not ideal, but better
than nothing.

  • http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
  • http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt:

Also a progression - we now get a line number for offending <script>.

4:15 PM Changeset in webkit [156129] by dbates@webkit.org
  • 2 edits in trunk/Source/WTF

[iOS] Define mainThreadEstablishedAsPthreadMain to be true in WTF::initializeMainThreadPlatform()

Reviewed by Joseph Pecoraro.

This change was inadvertently left out of <http://trac.webkit.org/changeset/155926>.

  • wtf/mac/MainThreadMac.mm:

(WTF::initializeMainThreadPlatform):

4:03 PM Changeset in webkit [156128] by weinig@apple.com
  • 12 edits
    1 delete in trunk/Source/WTF

Remove OwnArrayPtr
https://bugs.webkit.org/show_bug.cgi?id=121612

Reviewed by Anders Carlsson.

  • GNUmakefile.list.am:
  • WTF.pro:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/Assertions.cpp:
  • wtf/CMakeLists.txt:
  • wtf/DateMath.h:
  • wtf/FastBitVector.h:
  • wtf/Forward.h:
  • wtf/OwnArrayPtr.h: Removed.
  • wtf/VectorTraits.h:
4:02 PM Changeset in webkit [156127] by dbates@webkit.org
  • 2 edits in trunk/Source/WTF

Substitute return type void for bool in function declaration for WTF::initializeWebThread()

Reviewed by Joseph Pecoraro.

Make the declaration of WTF::initializeWebThread() match the function prototype
of its definition.

  • wtf/MainThread.h:
3:42 PM Changeset in webkit [156126] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix Windows build part 2. m_jitCodeMap should always be there.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::jitCodeMap):

3:38 PM Changeset in webkit [156125] by rniwa@webkit.org
  • 8 edits in trunk/Source/WebCore

Remove superfluous CSSLinearTimingFunctionValue and use switch on TimingFunction::type() in more places
https://bugs.webkit.org/show_bug.cgi?id=121589

Reviewed by Dean Jackson.

Replaced CSSLinearTimingFunctionValue by the identifier "linear" and used switch statements on
TimingFunction::type() in more places where we were branching on every type.

Merge https://chromium.googlesource.com/chromium/blink/+/5454f20c71090c35bdd1053e5cc572d5c0bdede7
Merge https://chromium.googlesource.com/chromium/blink/+/104ad42c523d32b67d108c6e59f4f27488fe38a5

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::createTimingFunctionValue):

  • css/CSSTimingFunctionValue.cpp:
  • css/CSSTimingFunctionValue.h:
  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapAnimationTimingFunction):

  • css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

(WebCore::CSSValue::isCubicBezierTimingFunctionValue):

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::progress):

3:27 PM Changeset in webkit [156124] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Remove some of the tautologies in DFGRepatch function naming.

Rubber stamped by Mark Hahnenberg.

For example change DFG::dfgLinkFor() to be DFG::linkFor().

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::resetStubInternal):

  • dfg/DFGOperations.cpp:
  • dfg/DFGRepatch.cpp:

(JSC::DFG::repatchCall):
(JSC::DFG::repatchByIdSelfAccess):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::repatchGetByID):
(JSC::DFG::buildGetByIDList):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::repatchPutByID):
(JSC::DFG::buildPutByIdList):
(JSC::DFG::repatchIn):
(JSC::DFG::linkFor):
(JSC::DFG::linkSlowFor):
(JSC::DFG::linkClosureCall):
(JSC::DFG::resetGetByID):
(JSC::DFG::resetPutByID):
(JSC::DFG::resetIn):

  • dfg/DFGRepatch.h:

(JSC::DFG::resetGetByID):
(JSC::DFG::resetPutByID):
(JSC::DFG::resetIn):

3:23 PM Changeset in webkit [156123] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix Windows build. ScratchBuffer should always be available regardless of
ENABLE_DFG_JIT.

  • runtime/VM.h:
3:16 PM Changeset in webkit [156122] by dbates@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

[iOS] Add more iOS logic to the JavaScriptCore build configuration files
https://bugs.webkit.org/show_bug.cgi?id=121635

Reviewed by Geoffrey Garen.

Towards building JavaScriptCore for both OS X and iOS using the same
set of configuration files, add more iOS logic.

  • Configurations/Base.xcconfig:
  • Configurations/JSC.xcconfig:
  • Configurations/JavaScriptCore.xcconfig:
  • Configurations/ToolExecutable.xcconfig:
3:12 PM Changeset in webkit [156121] by commit-queue@webkit.org
  • 17 edits in trunk/Source/WebCore

Unreviewed, rolling out r156119.
http://trac.webkit.org/changeset/156119
https://bugs.webkit.org/show_bug.cgi?id=121640

broke builds in various ways (Requested by anttik on #webkit).

  • accessibility/AccessibilitySpinButton.cpp:
  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

  • css/SelectorChecker.cpp:
  • dom/ContainerNode.h:
  • dom/Element.h:
  • dom/PseudoElement.cpp:

(WebCore::PseudoElement::didAttachRenderers):

  • editing/SplitTextNodeContainingElementCommand.cpp:

(WebCore::SplitTextNodeContainingElementCommand::doApply):

  • editing/TypingCommand.cpp:
  • html/ImageDocument.cpp:
  • page/PageSerializer.cpp:
  • rendering/RenderElement.h:
  • rendering/RenderObject.h:
  • svg/SVGAnimatedColor.cpp:

(WebCore::adjustForCurrentColor):

  • svg/SVGLocatable.cpp:
  • svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::determineAbsolutePaintRect):
(WebCore::FEImage::referencedRenderer):

  • svg/graphics/filters/SVGFEImage.h:
3:10 PM Changeset in webkit [156120] by fpizlo@apple.com
  • 37 edits
    5 moves in trunk/Source/JavaScriptCore

Move CCallHelpers and AssemblyHelpers into jit/ and have JSInterfaceJIT use them
https://bugs.webkit.org/show_bug.cgi?id=121637

Rubber stamped by Michael Saboff.

Also moved GPRInfo/FPRInfo into jit/.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/ValueRecovery.h:

(JSC::ValueRecovery::dumpInContext):

  • dfg/DFGAssemblyHelpers.cpp: Removed.
  • dfg/DFGAssemblyHelpers.h: Removed.
  • dfg/DFGBinarySwitch.h:
  • dfg/DFGByteCodeParser.cpp:
  • dfg/DFGCCallHelpers.h: Removed.
  • dfg/DFGDisassembler.cpp:
  • dfg/DFGFPRInfo.h: Removed.
  • dfg/DFGGPRInfo.h: Removed.
  • dfg/DFGGraph.cpp:
  • dfg/DFGGraph.h:
  • dfg/DFGJITCompiler.h:
  • dfg/DFGOSRExit.cpp:
  • dfg/DFGOSRExit.h:
  • dfg/DFGOSRExitCompiler.h:
  • dfg/DFGOSRExitCompilerCommon.h:
  • dfg/DFGRegisterBank.h:
  • dfg/DFGRegisterSet.h:
  • dfg/DFGRepatch.cpp:
  • dfg/DFGSilentRegisterSavePlan.h:
  • dfg/DFGThunks.cpp:
  • dfg/DFGVariableEvent.cpp:
  • ftl/FTLCArgumentGetter.h:

(JSC::FTL::CArgumentGetter::CArgumentGetter):
(JSC::FTL::CArgumentGetter::loadNext8):
(JSC::FTL::CArgumentGetter::loadNext32):
(JSC::FTL::CArgumentGetter::loadNext64):
(JSC::FTL::CArgumentGetter::loadNextPtr):
(JSC::FTL::CArgumentGetter::loadNextDouble):

  • ftl/FTLCompile.cpp:
  • ftl/FTLExitThunkGenerator.h:
  • ftl/FTLLink.cpp:
  • ftl/FTLThunks.cpp:
  • jit/AssemblyHelpers.cpp: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.cpp.
  • jit/AssemblyHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h.

(JSC::AssemblyHelpers::AssemblyHelpers):
(JSC::AssemblyHelpers::debugCall):

  • jit/CCallHelpers.h: Copied from Source/JavaScriptCore/dfg/DFGCCallHelpers.h.
  • jit/FPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGFPRInfo.h.

(WTF::printInternal):

  • jit/GPRInfo.h: Copied from Source/JavaScriptCore/dfg/DFGGPRInfo.h.

(WTF::printInternal):

  • jit/JIT.cpp:

(JSC::JIT::JIT):

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):

  • jit/JSInterfaceJIT.h:

(JSC::JSInterfaceJIT::JSInterfaceJIT):

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::finalize):

  • jit/ThunkGenerators.cpp:

(JSC::linkForGenerator):
(JSC::virtualForGenerator):
(JSC::stringLengthTrampolineGenerator):
(JSC::nativeForGenerator):
(JSC::arityFixup):
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
(JSC::absThunkGenerator):
(JSC::powThunkGenerator):
(JSC::imulThunkGenerator):

  • llint/LLIntThunks.cpp:

(JSC::LLInt::generateThunkWithJumpTo):

  • runtime/JSCJSValue.h:
3:03 PM Changeset in webkit [156119] by Antti Koivisto
  • 17 edits in trunk/Source/WebCore

Add covariant RenderElement* Element::renderer()
https://bugs.webkit.org/show_bug.cgi?id=121638

Reviewed by Andreas Kling.

Also add isRenderElement() test and casting functions.

2:42 PM Changeset in webkit [156118] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Streamline JSMainThreadNullState.
<https://webkit.org/b/121636>

Reviewed by Anders Carlsson.

JSMainThreadNullState is only used by non-JavaScript bindings and
thus won't ever call didLeaveScriptContext() on destruction.
Specialize the class for its use-case instead of sharing code
with JSMainThreadExecState.

Shrinks the WebCore binary by 82848 bytes.

2:40 PM Changeset in webkit [156117] by akling@apple.com
  • 2 edits in trunk/Source/WTF

Assume allocator success in Vector unless using try* functions.
<https://webkit.org/b/121629>

Reviewed by Anders Carlsson.

Turn some Vector::begin() null checking into assertions instead.

We have try* style functions for when an allocation request is so
large that it might actually fail. fastMalloc() will never return
null (it will just CRASH() instead.)

2:27 PM Changeset in webkit [156116] by betravis@adobe.com
  • 12 edits in trunk

CSS_SHAPES not supported on AppleWin port
https://bugs.webkit.org/show_bug.cgi?id=118810

Enabling CSS Shapes on Windows port

Reviewed by Brent Fulgham.

  • LayoutTests/Changelog
  • LayoutTEsts/platform/win/TestExpectations
  • Source/WebCore/ChangeLog
  • Source/WebCore/WebCore.vcxproj/WebCore.vcxproj
  • Source/WebCore/WebCore.vcxproj/WebCoreCommon.props
  • Source/WebCore/WebCore.vcxproj/copyForwardingHeaders.cmd
  • Source/WebCore/css/CSSPropertyNames.in
  • Source/WebKit/ChangeLog
  • Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in
  • WebKitLibraries/ChangeLog
  • WebKitLibraries/win/tools/vsprops/FeatureDefines.props
  • WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.props
2:06 PM Changeset in webkit [156115] by mitz@apple.com
  • 2 edits in trunk/Tools

Attempted build fix after r156114.

  • Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.
1:46 PM Changeset in webkit [156114] by mitz@apple.com
  • 1 edit
    2 deletes in trunk/WebKitLibraries

Removed WebCoreSQLite3. It has been unused for years.

Rubber-stamped by Mark Rowe.

  • WebCoreSQLite3: Removed.
  • WebCoreSQLite3/sqlite3.h: Removed.
  • WebCoreSQLite3/sqlite3ext.h: Removed.
  • libWebCoreSQLite3.a: Removed.
1:29 PM Changeset in webkit [156113] by dbates@webkit.org
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

[iOS] Substitute UNREACHABLE_FOR_PLATFORM() for RELEASE_ASSERT_NOT_REACHED()

Rubber-stamped by Joseph Pecoraro.

Use UNREACHABLE_FOR_PLATFORM() instead of RELEASE_ASSERT_NOT_REACHED() in
the non-x86/x86-64 variant of JIT::emitSlow_op_mod() so as to avoid a missing
noreturn warning in Clang while simultaneously asserting unreachable code.

  • jit/JITArithmetic.cpp:

(JSC::JIT::emitSlow_op_mod):

1:27 PM Changeset in webkit [156112] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[iOS] Substitute UNREACHABLE_FOR_PLATFORM() for RELEASE_ASSERT_NOT_REACHED()

Rubber-stamped by Joseph Pecoraro.

Use UNREACHABLE_FOR_PLATFORM() instead of RELEASE_ASSERT_NOT_REACHED() in
the non-x86/x86-64 variant of JIT::emitSlow_op_mod() so as to avoid a missing
noreturn warning in Clang while simultaneously asserting unreachable code.

  • jit/JITArithmetic.cpp:

(JSC::JIT::emitSlow_op_mod):

1:07 PM Changeset in webkit [156111] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSC: X86 disassembler shows 16, 32 and 64 bit displacements as unsigned
https://bugs.webkit.org/show_bug.cgi?id=121625

Rubber-stamped by Filip Pizlo.

Chenged 16, 32 and 64 bit offsets to be signed. Kept the original tab indented
spacing to match the rest of the file.

  • disassembler/udis86/udis86_syn-att.c:

(gen_operand):

12:54 PM Changeset in webkit [156110] by akling@apple.com
  • 8 edits
    1 add in trunk/Source/WebCore

Add SVGPropertyInfo.cpp
<https://webkit.org/b/121622>

Reviewed by Anders Carlsson.

Add a cpp file for this class to make it more hackable.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/properties/SVGPropertyInfo.cpp: Added.

(WebCore::SVGPropertyInfo::SVGPropertyInfo):

  • svg/properties/SVGPropertyInfo.h:
12:22 PM Changeset in webkit [156109] by ap@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r129451): run-safari --no-saved-state is broken
https://bugs.webkit.org/show_bug.cgi?id=121566

Undo a last minute change that doesn't actually work.

  • Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed

via command line, <rdar://problem/15032886>.

12:06 PM Changeset in webkit [156108] by eric.carlson@apple.com
  • 13 edits
    1 add in trunk

MediaStream API: update NavigatorUserMediaError object to match spec
https://bugs.webkit.org/show_bug.cgi?id=121584

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, updated getusermedia.html.

  • CMakeLists.txt: Add NavigatorUserMediaError.cpp.
  • GNUmakefile.list.am: Ditto.
  • Modules/mediastream/NavigatorUserMediaError.cpp: Added.
  • Modules/mediastream/NavigatorUserMediaError.h: Derive from DOMError, get rid of "message" attribute.
  • Modules/mediastream/NavigatorUserMediaError.idl: Ditto.
  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::create): ASCIILiteral -> AtomicString. Rename constraint parameters.
(WebCore::UserMediaRequest::UserMediaRequest): Rename constraint parameters.
(WebCore::UserMediaRequest::audioConstraints): Return PassRefPtr<> instead of raw ptr.
(WebCore::UserMediaRequest::videoConstraints): Ditto.
(WebCore::UserMediaRequest::ownerDocument): Clean up style.
(WebCore::UserMediaRequest::succeed):
(WebCore::UserMediaRequest::permissionFailure): Renamed from fail.
(WebCore::UserMediaRequest::constraintFailure): Renamed from failConstraint.
(WebCore::UserMediaRequest::callSuccessHandler): New.
(WebCore::UserMediaRequest::callErrorHandler): New.

  • Modules/mediastream/UserMediaRequest.h:
  • WebCore.xcodeproj/project.pbxproj: Add NavigatorUserMediaError.cpp
  • dom/DOMError.h: Make constructor protected.
  • platform/mediastream/MediaStreamSourcesQueryClient.h: Make constraints available.

LayoutTests:

  • fast/mediastream/getusermedia-expected.txt:
  • fast/mediastream/getusermedia.html:
11:49 AM Changeset in webkit [156107] by zoltan@webkit.org
  • 8 edits in trunk/LayoutTests

[CSS Shapes] Fix starting html tag and doctype for shape-inside floats tests
https://bugs.webkit.org/show_bug.cgi?id=121621

Reviewed by Andreas Kling.

  • fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content-expected.html:
  • fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content-expected.html:
  • fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content.html:
  • fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content-expected.html:
  • fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content.html:
  • fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content-expected.html:
  • fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content.html:
11:18 AM Changeset in webkit [156106] by Bem Jones-Bey
  • 8 edits
    4 adds in trunk

Fix handling of top margin on float with shape-outside
https://bugs.webkit.org/show_bug.cgi?id=121614

Reviewed by Alexandru Chiculita.

Source/WebCore:

When a float has shape outside, the top margin should be treated as if
there is no shape there, so inline content should be allowed to flow
into that space. This patch fixes two issues:

1) If the top margin is the same as the line height, a line should be
able to fit into the margin. Before this patch, that line was being
treated as if it intersected with the shape.

2) The shape should be positioned (x, y) relative to the box sizing
box of the float. While the x coordinate was being treated properly,
the y coordinate was relative to the top of the margin box. This patch
fixes this behavior.

This patch also includes a simple test for right and left margins, as
I wrote that test and then discovered the problems listed above.

This patch also removes an unused override of the
lineOverlapsShapeBounds method.

Tests: csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html

csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html

  • rendering/FloatingObjects.cpp:

(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset):

  • rendering/LineWidth.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

  • rendering/shapes/ShapeInfo.h:
  • rendering/shapes/ShapeInsideInfo.h:
  • rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::computeSegmentsForContainingBlockLine):

  • rendering/shapes/ShapeOutsideInfo.h:

LayoutTests:

  • csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000-expected.html: Added.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html: Added.

Test for a positive left/right margin.

  • csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html: Added.
  • csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html: Added.

Test for a positive top margin.

11:13 AM Changeset in webkit [156105] by mitz@apple.com
  • 5 edits in trunk

Add a style guideline regarding spacing in range-based for loops
https://bugs.webkit.org/show_bug.cgi?id=121620

Reviewed by Anders Carlsson.

Tools:

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_spacing): Added checking that there are spaces around the colon in a range-based for
loop.
(CppChecker): Added whitespace/colon to the categories set.

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_spacing): Added two tests for the new check.

Websites/webkit.org:

  • coding/coding-style.html: Added the guideline that spaces should be placed

around the colon in a range-based for loop.

10:57 AM Changeset in webkit [156104] by rniwa@webkit.org
  • 3 edits in trunk/PerformanceTests

DoYouEvenBench: Indentations in benchmark.js and benchmark.html are all messed up
https://bugs.webkit.org/show_bug.cgi?id=121597

Reviewed by Anders Carlsson.

Fixed indentations.

  • DoYouEvenBench/benchmark.html:
  • DoYouEvenBench/benchmark.js:

(SimplePromise.prototype.resolve.else):
(SimplePromise.prototype.resolve):
(BenchmarkRunner.waitForElement.resolveIfReady):
(BenchmarkRunner.waitForElement):
(BenchmarkRunner._waitAndWarmUp.Fibonacci):
(BenchmarkRunner._finalize):

10:57 AM Changeset in webkit [156103] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add XHR tests checking readyState transition when abort() is invoked in various states
https://bugs.webkit.org/show_bug.cgi?id=121585

Reviewed by Alexey Proskuryakov.

Merge https://chromium.googlesource.com/chromium/blink/+/2d854757576db590745cfb78e11ca428a1aac342

  • http/tests/xmlhttprequest/readystatechange-and-abort-expected.txt: Added.
  • http/tests/xmlhttprequest/readystatechange-and-abort.html: Added.
10:52 AM Changeset in webkit [156102] by Antti Koivisto
  • 26 edits
    2 adds in trunk/Source/WebCore

Add RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121608

Reviewed by Dave Hyatt.

Add a common base class for all Element renderers. The class hierarchy will now look like this

RenderObject

RenderText
RenderElement

RenderLayerModelObject

...

RenderSVGModelObject

...

RenderSVGGradientStop


This will allow tighter typing in both render and DOM trees.

The patch also moves renderer factory function to RenderElement::createFor().

10:36 AM Changeset in webkit [156101] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebKit/qt

Keep chasing the definition of QAccessibleWidget
https://bugs.webkit.org/show_bug.cgi?id=121611

Reviewed by Jocelyn Turcotte.

  • WidgetApi/qwebviewaccessible_p.h:
9:06 AM Changeset in webkit [156100] by weinig@apple.com
  • 12 edits in trunk/Tools

Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
https://bugs.webkit.org/show_bug.cgi?id=121588

Reviewed by Anders Carlsson.

  • DumpRenderTree/TestRunner.cpp:
  • ImageDiff/efl/ImageDiff.cpp:
  • TestWebKitAPI/JavaScriptTest.cpp:
  • TestWebKitAPI/PlatformUtilities.cpp:
  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  • WebKitTestRunner/StringFunctions.h:
  • WebKitTestRunner/TestInvocation.cpp:
  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
9:00 AM Changeset in webkit [156099] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r149928): CanvasStyle::operator= leaks everything
https://bugs.webkit.org/show_bug.cgi?id=121591

Reviewed by Andreas Kling.

  • html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::operator=): Don't leak.
8:11 AM Changeset in webkit [156098] by Manuel Rego Casasnovas
  • 3 edits in trunk/LayoutTests

Unreviewed. Fix typo in layout test description introduced in r155974.

  • fast/regions/selection-direction-expected.html:
  • fast/regions/selection-direction.html:
7:41 AM Changeset in webkit [156097] by commit-queue@webkit.org
  • 4 edits
    2 copies in trunk

[CSS Masking/Background] Position property should be ignored when using repeat: space
https://bugs.webkit.org/show_bug.cgi?id=120623

Source/WebCore:

The background/mask-position should be ignored when using repeat: space,
unless there is not enough space for two copies of the image. In that case,
only one image is placed and background/mask-position determines its position.

Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-19
Reviewed by Dirk Schulze.

Test: css3/masking/mask-repeat-one-copy.html

  • rendering/RenderBoxModelObject.cpp: Ignored position property if space value is positive, set no-repeat otherwise.

(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

LayoutTests:

Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-19
Reviewed by Dirk Schulze.

  • css3/masking/mask-repeat-one-copy-expected.html:
  • css3/masking/mask-repeat-one-copy.html: Only one copy of the mask should be drawn, and background position should determine its position.
  • css3/masking/mask-repeat-space-padding.html: Added a mask-position which should be ignored.
7:39 AM Changeset in webkit [156096] by Michał Pakuła vel Rutka
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip tests added to platform/efl/Skipped, which now are passing.

  • platform/efl/TestExpectations:
6:51 AM Changeset in webkit [156095] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

CTTE: EllipsisBox::renderer() should return RenderBlock&.
<https://webkit.org/b/121604>

Reviewed by Antti Koivisto.

I missed adding a renderer() overload when fixing up EllipsisBox.
Flushed out one unnecessary type check.

6:48 AM Changeset in webkit [156094] by akling@apple.com
  • 13 edits in trunk/Source/WebCore

CTTE: Tighten renderer types for InlineTextBox and SVGInlineTextBox.
<https://webkit.org/b/121605>

Reviewed by Antti Koivisto.

Codify the following:

  • InlineTextBox always has a RenderText.
  • SVGInlineTextBox always has a RenderSVGInlineText.

Removed InlineTextBox::textRenderer() and make renderer() simply
return a RenderText&/RenderSVGInlineText& instead.

This turns some node() accessors into textNode() and removes a host
of casts and assertions.

6:36 AM Changeset in webkit [156093] by Antti Koivisto
  • 5 edits in trunk/Source/WebCore

[CTTE] Hide nonPseudoNode and generatingNode, replace with Element versions
https://bugs.webkit.org/show_bug.cgi?id=121606

Reviewed by Andreas Kling.

5:33 AM Changeset in webkit [156092] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

CTTE: Tighten renderer types for InlineFlowBox and SVGInlineFlowBox.
<https://webkit.org/b/121603>

Reviewed by Antti Koivisto.

Codify the following:

  • InlineFlowBox always has a RenderBoxModelObject.
  • SVGInlineFlowBox always has a RenderSVGInline.

This turns some node() accessors into element(). Neato!

4:03 AM Changeset in webkit [156091] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

CSS Unit vmax and vmin in border-width not handled.
https://bugs.webkit.org/show_bug.cgi?id=121421

Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-19
Reviewed by Darin Adler.

Source/WebCore:

Border properties were not applied incase its values
were given in vmax/vmin units.

Tests: fast/css/viewport-vmax-border.html

fast/css/viewport-vmin-border.html

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::computeLengthDouble):

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isViewportPercentageMax):
(WebCore::CSSPrimitiveValue::isViewportPercentageMin):

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyComputeLength::applyValue):
Calculating the border values which has been specified in
vmax/vmin units. 1vmax: 1vw or 1vh, whatever is largest.
1vmin: 1vw or 1vh, whatever is smallest. The vh/vw units are
calcultated as percent of viewport height and viewport width respectively.

LayoutTests:

  • fast/css/viewport-vmax-border-expected.txt: Added.
  • fast/css/viewport-vmax-border.html: Added.
  • fast/css/viewport-vmin-border-expected.txt: Added.
  • fast/css/viewport-vmin-border.html: Added.

Added new tests for verifying that border properties are
applied when its values are given in vmax/vmin units.

3:37 AM Changeset in webkit [156090] by Antti Koivisto
  • 22 edits in trunk

[CTTE] RenderText is always anonymous or associated with Text node
https://bugs.webkit.org/show_bug.cgi?id=121596

Source/WebCore:

Reviewed by Andreas Kling.

Tighten the node type of RenderText and its subclasses to Text.
Switch to createAnonymous pattern.
Switch a bunch of unnecessary StringImpl* use to Strings.

LayoutTests:

Reviewed by Andreas Kling.

Update some MathML render tree dumps. RenderTexts for these are now anonymous.

  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/row-expected.txt:
1:42 AM Changeset in webkit [156089] by zarvai@inf.u-szeged.hu
  • 4 edits
    10 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebase after r155957 and 155998.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-19

  • platform/qt-wk1/compositing/contents-scale/animating-expected.txt: Added r155998.
  • platform/qt-wk1/compositing/contents-scale/scaled-ancestor-expected.txt: Added r155998.
  • platform/qt-wk1/compositing/contents-scale/simple-scale-expected.txt: Added r155998.
  • platform/qt-wk1/compositing/contents-scale/z-translate-expected.txt: Added r155998.
  • platform/qt-wk2/compositing/contents-scale/animating-expected.txt: Added r155998.
  • platform/qt-wk2/compositing/contents-scale/scaled-ancestor-expected.txt: Added r155998.
  • platform/qt-wk2/compositing/contents-scale/simple-scale-expected.txt: Added r155998.
  • platform/qt-wk2/compositing/contents-scale/z-translate-expected.txt: Added r155998.
  • platform/qt/css3/selectors3/html/css3-modsel-179a-expected.txt: Rebase after r155957.
  • platform/qt/css3/selectors3/xhtml/css3-modsel-179a-expected.txt: Rebase after r155957.
  • platform/qt/css3/selectors3/xml/css3-modsel-179a-expected.txt: Rebase after r155957.
1:07 AM Changeset in webkit [156088] by rniwa@webkit.org
  • 2 edits
    31 adds in trunk/PerformanceTests

Add an AngularJS test to DoYouEvenBench
https://bugs.webkit.org/show_bug.cgi?id=121595

Reviewed by Antti Koivisto.

  • DoYouEvenBench/benchmark.html:
  • DoYouEvenBench/todomvc/architecture-examples/angularjs: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower.json: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular-mocks: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular-mocks/angular-mocks.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular/angular.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.css: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/bg.png: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/index.html: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/app.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/controllers: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/controllers/todoCtrl.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoBlur.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoEscape.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoFocus.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/services: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/services/todoStorage.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/readme.md: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test/config: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test/config/testacular.conf.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test/package.json: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test/readme.md: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit/directivesSpec.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit/todoCtrlSpec.js: Added.
12:54 AM Changeset in webkit [156087] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding failure expectations for failing HiDPI and a11y tests.
12:07 AM Changeset in webkit [156086] by mihnea@adobe.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after 156082. Guard SVG code with defines.

12:07 AM Changeset in webkit [156085] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Remove names of unused arguments from the x86/x86-64 function prototype
for JIT::emitSlow_op_mod()

Rubber-stamped by Ryosuke Niwa.

  • jit/JITArithmetic.cpp:

(JSC::JIT::emitSlow_op_mod):

Sep 18, 2013:

11:42 PM Changeset in webkit [156084] by zandobersek@gmail.com
  • 7 edits in trunk/LayoutTests

Unreviewed GTK gardening. Rebaselining after r155957.

  • platform/gtk/css3/selectors3/html/css3-modsel-179a-expected.txt:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-179a-expected.txt:
  • platform/gtk/css3/selectors3/xml/css3-modsel-179a-expected.txt:
  • platform/gtk/fast/css/pseudo-first-line-border-width-expected.txt:
  • platform/gtk/fast/css/word-space-extra-expected.txt:
  • platform/gtk/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
11:32 PM Changeset in webkit [156083] by zandobersek@gmail.com
  • 10 edits in trunk/LayoutTests

Unreviewed GTK gardening. Rebaselining after r156040.

  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
  • platform/gtk/fast/forms/select-baseline-expected.txt:
  • platform/gtk/fast/forms/select-empty-option-height-expected.txt:
  • platform/gtk/fast/forms/selectlist-minsize-expected.txt:
  • platform/gtk/fast/html/keygen-expected.txt:
  • platform/gtk/fast/replaced/three-selects-break-expected.txt:
11:22 PM Changeset in webkit [156082] by mihnea@adobe.com
  • 3 edits
    2 adds in trunk

[CSSRegions] Failed to retrieve named flow ranges for content with inline svg
https://bugs.webkit.org/show_bug.cgi?id=121489

Reviewed by David Hyatt.

Source/WebCore:

The inline SVG element behaves like a replaced element in HTML context. When computing the ranges
that are displayed inside a region for a named flow that contains an inline SVG element, we have
to treat the SVG as a replaced and run the checks only for the SVG root element, skipping the
other SVG elements inside.

Test: fast/regions/get-region-flow-ranges-inline-svg.html

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::nextNodeInsideContentNode): Add function to retrieve the next node in traversal
under the contentNode subtree that should be used for getRanges inspection.
(WebCore::RenderNamedFlowThread::getRanges): Replace NodeTravesal::next with nextNodeInsideContentNode.

LayoutTests:

  • fast/regions/get-region-flow-ranges-inline-svg-expected.txt: Added.
  • fast/regions/get-region-flow-ranges-inline-svg.html: Added.
11:18 PM Changeset in webkit [156081] by zandobersek@gmail.com
  • 1 edit
    5 moves
    1 add in trunk/LayoutTests

Unreviewed GTK gardening. Moving GTK-specific baselines for some js/dom/* tests into the proper directory.

  • platform/gtk/js/dom: Added.
  • platform/gtk/js/dom-static-property-for-in-iteration-expected.txt: Removed.
  • platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt: Copied from LayoutTests/platform/gtk/js/dom-static-property-for-in-iteration-expected.txt.
  • platform/gtk/js/dom/function-length-expected.txt: Copied from LayoutTests/platform/gtk/js/function-length-expected.txt.
  • platform/gtk/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Copied from LayoutTests/platform/gtk/js/global-constructors-attributes-dedicated-worker-expected.txt.
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/gtk/js/global-constructors-attributes-expected.txt.
  • platform/gtk/js/dom/global-constructors-attributes-shared-worker-expected.txt: Copied from LayoutTests/platform/gtk/js/global-constructors-attributes-shared-worker-expected.txt.
  • platform/gtk/js/function-length-expected.txt: Removed.
  • platform/gtk/js/global-constructors-attributes-dedicated-worker-expected.txt: Removed.
  • platform/gtk/js/global-constructors-attributes-expected.txt: Removed.
  • platform/gtk/js/global-constructors-attributes-shared-worker-expected.txt: Removed.
9:03 PM Changeset in webkit [156080] by rniwa@webkit.org
  • 1 edit
    2 adds
    2 deletes in trunk/LayoutTests

Redo r156078.

  • platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Added.
  • platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Added.
  • platform/mac-wk2/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Removed.
  • platform/mac-wk2/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Removed.
8:12 PM Changeset in webkit [156079] by weinig@apple.com
  • 16 edits in trunk/Source/JavaScriptCore

Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=121583

Reviewed by Anders Carlsson.

  • API/JSStringRefCF.cpp:

(JSStringCreateWithCFString):

  • API/JSStringRefQt.cpp:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::dumpDisassembly):

  • runtime/Arguments.cpp:

(JSC::Arguments::tearOff):

  • runtime/Arguments.h:

(JSC::Arguments::isTornOff):
(JSC::Arguments::allocateSlowArguments):

  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::JSPropertyNameIterator):

  • runtime/JSPropertyNameIterator.h:
  • runtime/JSSegmentedVariableObject.h:
  • runtime/JSVariableObject.h:
  • runtime/PropertyNameArray.h:
  • runtime/RegExp.cpp:
  • runtime/StructureChain.h:

(JSC::StructureChain::finishCreation):

  • runtime/SymbolTable.h:

(JSC::SharedSymbolTable::setSlowArguments):

8:03 PM Changeset in webkit [156078] by rniwa@webkit.org
  • 1 edit
    2 adds
    2 deletes in trunk/LayoutTests

Lion rebaseline after r155253.

  • platform/mac-wk2/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Added.
  • platform/mac-wk2/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Added.
  • platform/qt-wk2/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Removed.
  • platform/qt-wk2/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Removed.
7:17 PM Changeset in webkit [156077] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Add test expectations for bugs 121581 and 121582.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
7:04 PM Changeset in webkit [156076] by rniwa@webkit.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

Fix the expected result again after r156070.

  • platform/mac-lion/js/dom: Added.
  • platform/mac-lion/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt.
  • platform/mac/js/dom/global-constructors-attributes-expected.txt: Removed.
6:31 PM Changeset in webkit [156075] by Bem Jones-Bey
  • 3 edits
    2 adds in trunk

REGRESSION (r155854 - r155967) block with margin-left adjacent to floated block causes text of subsequent blocks to overlap the floated block.
https://bugs.webkit.org/show_bug.cgi?id=121532

Reviewed by Andreas Kling.

Source/WebCore:

When refactoring the code, I ended up adding the margin in instead of
subtracting it in the case of an intruding float. This patch fixes
that so that the margin is properly handled.

Test: fast/block/float/intruding-float-sibling-with-margin.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::addIntrudingFloats):

LayoutTests:

  • fast/block/float/intruding-float-sibling-with-margin-expected.html: Added.
  • fast/block/float/intruding-float-sibling-with-margin.html: Added.
5:55 PM Changeset in webkit [156074] by Bem Jones-Bey
  • 4 edits in trunk/Tools

W3C Test Import script reformats test HTML
https://bugs.webkit.org/show_bug.cgi?id=119159

Reviewed by Dirk Pranke.

Completely rewrite the test conversion process to minimize
reformatting when adding prefixes, etc. This isn't 100% perfect, there
are still places where it will end up changing the formatting, but it
is much better than before. Most notably, the public interface to the
test converter has changed: now one calls a method instead of creating
an instance of the test converter class. This is because the test
converter class now has state, so one really needs a new instance for
each test.

Note that this also lays some simple groundwork for being able to use
a MockHost in the tests.

  • Scripts/webkitpy/w3c/test_converter.py:

(convert_for_webkit):
(_W3CTestConverter):
(_W3CTestConverter.init):
(_W3CTestConverter.output):
(_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
(_W3CTestConverter.convert_style_data):
(_W3CTestConverter.convert_attributes_if_needed):
(_W3CTestConverter.handle_starttag):
(_W3CTestConverter.handle_endtag):
(_W3CTestConverter.handle_startendtag):
(_W3CTestConverter.handle_data):
(_W3CTestConverter.handle_entityref):
(_W3CTestConverter.handle_charref):
(_W3CTestConverter.handle_comment):
(_W3CTestConverter.handle_decl):
(_W3CTestConverter.handle_pi):

  • Scripts/webkitpy/w3c/test_converter_unittest.py:

(W3CTestConverterTest):
(W3CTestConverterTest.fake_dir_path):
(W3CTestConverterTest.test_read_prefixed_property_list):
(verify_no_conversion_happened):

  • Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.import_tests):

5:15 PM Changeset in webkit [156073] by rniwa@webkit.org
  • 2 edits
    100 adds in trunk/PerformanceTests

Add a not completely unrealistic DOM Benchmark
https://bugs.webkit.org/show_bug.cgi?id=121361

Reviewed by Filip Pizlo.

Add a DOM benchmark based on TodoMVC for vanilla JS, Ember.js, Backbone.js, and jQuery.
We'll add more frameworks and demo apps as we go.

  • DoYouEvenBench: Added.
  • DoYouEvenBench/benchmark.html: Added.
  • DoYouEvenBench/benchmark.js: Added.

(SimplePromise):
(SimplePromise.prototype.then):
(SimplePromise.prototype.resolve.else):
(SimplePromise.prototype.resolve):
(BenchmarkRunner.suite):
(BenchmarkRunner.waitForElement.resolveIfReady):
(BenchmarkRunner.waitForElement):
(BenchmarkRunner._removeFrame):
(BenchmarkRunner._appendFrame):
(BenchmarkRunner._waitAndWarmUp.Fibonacci):
(BenchmarkRunner._testName):
(BenchmarkRunner._testItemId):
(BenchmarkRunner.listSuites.button.onclick):
(BenchmarkRunner.listSuites.callNextStep):
(BenchmarkRunner.listSuites):
(BenchmarkState):
(BenchmarkState.prototype.currentSuite):
(BenchmarkState.prototype.currentTest):
(BenchmarkState.prototype.next):
(BenchmarkState.prototype.isFirstTest):
(BenchmarkState.prototype.prepareCurrentSuite.frame.onload):
(BenchmarkRunner.step):
(BenchmarkRunner._runTestAndRecordResults):
(BenchmarkRunner._finalize):

  • DoYouEvenBench/todomvc: Added.
  • DoYouEvenBench/todomvc/architecture-examples: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower.json: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone.localStorage: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone.localStorage/backbone.localStorage.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone/backbone.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/jquery: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/jquery/jquery.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.css: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common/bg.png: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/underscore: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/underscore/underscore.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/index.html: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/app.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/collections: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/collections/todos.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/models: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/models/todo.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/routers: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/routers/router.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/views: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/views/app-view.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/views/todo-view.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/readme.md: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower.json: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember-localstorage-adapter: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember-localstorage-adapter/localstorage_adapter.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/handlebars: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/handlebars/handlebars.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/jquery: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/jquery/jquery.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.css: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/bg.png: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/index.html: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/app.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/controllers: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/controllers/todo_controller.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/controllers/todos_controller.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/libs: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/libs/ember-data.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/models: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/models/store.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/models/todo.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/views: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/views/edit_todo_view.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/readme.md: Added.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/test.html: Added.
  • DoYouEvenBench/todomvc/architecture-examples/jquery: Added.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower.json: Added.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components: Added.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/handlebars: Added.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/handlebars/handlebars.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/jquery: Added.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/jquery/jquery.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common: Added.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.css: Added.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common/bg.png: Added.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/css: Added.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/css/app.css: Added.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/index.html: Added.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/js/app.js: Added.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/readme.md: Added.
  • DoYouEvenBench/todomvc/license.md: Added.
  • DoYouEvenBench/todomvc/readme.md: Added.
  • DoYouEvenBench/todomvc/vanilla-examples: Added.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs: Added.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower.json: Added.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components: Added.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common: Added.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.css: Added.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.js: Added.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/bg.png: Added.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/index.html: Added.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js: Added.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/app.js: Added.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/controller.js: Added.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/helpers.js: Added.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/model.js: Added.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/store.js: Added.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/view.js: Added.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/readme.md: Added.
  • Skipped:
4:58 PM Changeset in webkit [156072] by rniwa@webkit.org
  • 6 edits in trunk

Merge HTMLBodyElement::didNotifySubtreeInsertions into HTMLBodyElement::insertedInto
https://bugs.webkit.org/show_bug.cgi?id=121576

Reviewed by Andreas Kling.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/2a9cac908f4eceadfcf9d21bdf5b3e598075aa1f

The logic in didNotifySubtreeInsertions to set the marginwidth and marginheight attributes
on the <body> of elements inside <iframe> and <frame> doesn't need to run after inserting
all the children of the frame. In fact this means that when you have those attributes
and then the script in the iframe touches offsetLeft or any layout dependent property
we'll layout with the wrong values and then have to do another layout after these margin
attributes are set.

I also remove the scheduleRelayout() call that was inside didNotifySubtreeInsertions. This
call doesn't make any sense, inserting a <body> will always trigger a style recalc and
a subsequent layout. The code is 9 years old: https://trac.webkit.org/changeset/8122
and all tests run fine without it.

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::insertedInto):

  • html/HTMLBodyElement.h:
  • html/HTMLFrameElementBase.h:

(WebCore::isHTMLFrameElementBase):
(WebCore::toHTMLFrameElementBase):

LayoutTests:

Rebaseline a test now that we don't do an extra layout.

  • inspector/timeline/timeline-script-tag-1-expected.txt:
4:51 PM Changeset in webkit [156071] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed check in a proper baseline.

  • js/dom/global-constructors-attributes-expected.txt:
4:40 PM Changeset in webkit [156070] by rniwa@webkit.org
  • 1 edit
    3 moves
    2 adds in trunk/LayoutTests

Move expected results after r156066.

  • platform/efl/js/dom: Added.
  • platform/efl/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/efl/js/global-constructors-attributes-expected.txt.
  • platform/efl/js/global-constructors-attributes-expected.txt: Removed.
  • platform/mac-lion/js/global-constructors-attributes-expected.txt: Removed.
  • platform/mac/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/mac-lion/js/global-constructors-attributes-expected.txt.
  • platform/qt/js/dom: Added.
  • platform/qt/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/qt/js/global-constructors-attributes-expected.txt.
  • platform/qt/js/global-constructors-attributes-expected.txt: Removed.
3:45 PM Changeset in webkit [156069] by andersca@apple.com
  • 62 edits in trunk/Source/WebKit2

Remove the ENABLE_PLUGIN_PROCESS #define
https://bugs.webkit.org/show_bug.cgi?id=121569

Reviewed by Andreas Kling.

Fold the ENABLE_PLUGIN_PROCESS #define into the NETSCAPE_PLUGIN_API #define since
building plug-ins without the plug-in process is not supported.

  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
  • PluginProcess/PluginControllerProxy.cpp:
  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginControllerProxy.messages.in:
  • PluginProcess/PluginCreationParameters.cpp:
  • PluginProcess/PluginCreationParameters.h:
  • PluginProcess/PluginProcess.cpp:
  • PluginProcess/PluginProcess.h:
  • PluginProcess/PluginProcess.messages.in:
  • PluginProcess/WebProcessConnection.cpp:
  • PluginProcess/WebProcessConnection.h:
  • PluginProcess/WebProcessConnection.messages.in:
  • PluginProcess/mac/PluginControllerProxyMac.mm:
  • PluginProcess/mac/PluginProcessMac.mm:
  • Shared/Plugins/NPIdentifierData.cpp:
  • Shared/Plugins/NPIdentifierData.h:
  • Shared/Plugins/NPObjectMessageReceiver.cpp:
  • Shared/Plugins/NPObjectMessageReceiver.h:
  • Shared/Plugins/NPObjectMessageReceiver.messages.in:
  • Shared/Plugins/NPObjectProxy.cpp:
  • Shared/Plugins/NPObjectProxy.h:
  • Shared/Plugins/NPRemoteObjectMap.cpp:
  • Shared/Plugins/NPRemoteObjectMap.h:
  • Shared/Plugins/NPVariantData.cpp:
  • Shared/Plugins/NPVariantData.h:
  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::getMIMETypesFromPluginBundle):

  • Shared/Plugins/PluginProcessCreationParameters.cpp:
  • Shared/Plugins/PluginProcessCreationParameters.h:
  • UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::ProcessLauncher::processTypeAsString):
(WebKit::ProcessLauncher::getProcessTypeFromString):

  • UIProcess/Launcher/ProcessLauncher.h:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::addDYLDEnvironmentAdditions):
(WebKit::serviceName):
(WebKit::createProcess):

  • UIProcess/Plugins/PluginProcessManager.cpp:
  • UIProcess/Plugins/PluginProcessManager.h:
  • UIProcess/Plugins/PluginProcessProxy.cpp:
  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/Plugins/PluginProcessProxy.messages.in:
  • UIProcess/Plugins/WebPluginSiteDataManager.cpp:

(WebKit::WebPluginSiteDataManager::~WebPluginSiteDataManager):
(WebKit::WebPluginSiteDataManager::invalidate):
(WebKit::WebPluginSiteDataManager::getSitesWithData):
(WebKit::WebPluginSiteDataManager::clearSiteData):

  • UIProcess/Plugins/WebPluginSiteDataManager.h:
  • UIProcess/Plugins/mac/PluginProcessManagerMac.mm:
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::setProcessModel):
(WebKit::WebContext::shouldTerminate):
(WebKit::WebContext::disconnectProcess):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPluginProcessConnection):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in:
  • UIProcess/mac/WebContextMac.mm:

(WebKit::updateProcessSuppressionStateOfGlobalChildProcesses):

  • WebKit2Prefix.h:
  • WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
  • WebProcess/Plugins/PluginProcessConnection.cpp:
  • WebProcess/Plugins/PluginProcessConnection.h:
  • WebProcess/Plugins/PluginProcessConnection.messages.in:
  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:
  • WebProcess/Plugins/PluginProcessConnectionManager.h:
  • WebProcess/Plugins/PluginProcessConnectionManager.messages.in:
  • WebProcess/Plugins/PluginProxy.cpp:
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginProxy.messages.in:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeConnection):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
3:37 PM Changeset in webkit [156068] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit/win

[Windows] Build fix after r156063.

  • WebHistory.h: std::unique is an algorithm; std::unique_ptr is what we want here!
3:36 PM Changeset in webkit [156067] by Brent Fulgham
  • 2 edits in trunk/Source/JavaScriptCore

[Windows] Unreviewed build fix after r156064.

  • jsc.cpp:

(jscmain): Need a temporary to perform '&' in VS2010.

3:26 PM Changeset in webkit [156066] by fpizlo@apple.com
  • 7 edits
    3 moves
    785 adds
    781 deletes in trunk

Get rid of the jsc-test-list by moving all not-jsc-capable tests into js/dom
https://bugs.webkit.org/show_bug.cgi?id=121578

Rubber stamped by Geoffrey Garen.

Tools:

  • Scripts/run-layout-jsc:

LayoutTests:

  • fast/regex/cross-frame-callable-expected.txt: Removed.
  • fast/regex/cross-frame-callable.html: Removed.
  • fast/regex/dom: Added.
  • fast/regex/dom/cross-frame-callable-expected.txt: Added.
  • fast/regex/dom/cross-frame-callable.html: Added.
  • fast/regex/dom/lastIndex-expected.txt: Added.
  • fast/regex/dom/lastIndex.html: Added.
  • fast/regex/dom/non-pattern-characters-expected.txt: Added.
  • fast/regex/dom/non-pattern-characters.html: Added.
  • fast/regex/dom/script-tests: Added.
  • fast/regex/dom/script-tests/cross-frame-callable.js: Added.

(doTest):

  • fast/regex/dom/script-tests/lastIndex.js: Added.
  • fast/regex/dom/script-tests/non-pattern-characters.js: Added.
  • fast/regex/dom/script-tests/unicodeCaseInsensitive.js: Added.

(shouldBeTrue.ucs2CodePoint):

  • fast/regex/dom/syntax-errors-expected.txt: Added.
  • fast/regex/dom/syntax-errors.html: Added.
  • fast/regex/dom/unicodeCaseInsensitive-expected.txt: Added.
  • fast/regex/dom/unicodeCaseInsensitive.html: Added.
  • fast/regex/lastIndex-expected.txt: Removed.
  • fast/regex/lastIndex.html: Removed.
  • fast/regex/non-pattern-characters-expected.txt: Removed.
  • fast/regex/non-pattern-characters.html: Removed.
  • fast/regex/script-tests/cross-frame-callable.js: Removed.
  • fast/regex/script-tests/lastIndex.js: Removed.
  • fast/regex/script-tests/non-pattern-characters.js: Removed.
  • fast/regex/script-tests/unicodeCaseInsensitive.js: Removed.
  • fast/regex/syntax-errors-expected.txt: Removed.
  • fast/regex/syntax-errors.html: Removed.
  • fast/regex/unicodeCaseInsensitive-expected.txt: Removed.
  • fast/regex/unicodeCaseInsensitive.html: Removed.
  • js/JSON-parse-expected.txt: Removed.
  • js/JSON-parse.html: Removed.
  • js/JSON-stringify-expected.txt: Removed.
  • js/JSON-stringify.html: Removed.
  • js/Object-defineProperty-expected.txt: Removed.
  • js/Object-defineProperty.html: Removed.
  • js/Promise-already-fulfilled-expected.txt: Removed.
  • js/Promise-already-fulfilled.html: Removed.
  • js/Promise-already-rejected-expected.txt: Removed.
  • js/Promise-already-rejected.html: Removed.
  • js/Promise-already-resolved-expected.txt: Removed.
  • js/Promise-already-resolved.html: Removed.
  • js/Promise-catch-expected.txt: Removed.
  • js/Promise-catch-in-workers-expected.txt: Removed.
  • js/Promise-catch-in-workers.html: Removed.
  • js/Promise-catch.html: Removed.
  • js/Promise-chain-expected.txt: Removed.
  • js/Promise-chain.html: Removed.
  • js/Promise-exception-expected.txt: Removed.
  • js/Promise-exception.html: Removed.
  • js/Promise-expected.txt: Removed.
  • js/Promise-fulfill-expected.txt: Removed.
  • js/Promise-fulfill-in-workers-expected.txt: Removed.
  • js/Promise-fulfill-in-workers.html: Removed.
  • js/Promise-fulfill.html: Removed.
  • js/Promise-init-expected.txt: Removed.
  • js/Promise-init-in-workers-expected.txt: Removed.
  • js/Promise-init-in-workers.html: Removed.
  • js/Promise-init.html: Removed.
  • js/Promise-reject-expected.txt: Removed.
  • js/Promise-reject-in-workers-expected.txt: Removed.
  • js/Promise-reject-in-workers.html: Removed.
  • js/Promise-reject.html: Removed.
  • js/Promise-resolve-chain-expected.txt: Removed.
  • js/Promise-resolve-chain.html: Removed.
  • js/Promise-resolve-expected.txt: Removed.
  • js/Promise-resolve-in-workers-expected.txt: Removed.
  • js/Promise-resolve-in-workers.html: Removed.
  • js/Promise-resolve-with-then-exception-expected.txt: Removed.
  • js/Promise-resolve-with-then-exception.html: Removed.
  • js/Promise-resolve-with-then-fulfill-expected.txt: Removed.
  • js/Promise-resolve-with-then-fulfill.html: Removed.
  • js/Promise-resolve-with-then-reject-expected.txt: Removed.
  • js/Promise-resolve-with-then-reject.html: Removed.
  • js/Promise-resolve.html: Removed.
  • js/Promise-simple-expected.txt: Removed.
  • js/Promise-simple-fulfill-expected.txt: Removed.
  • js/Promise-simple-fulfill-inside-callback-expected.txt: Removed.
  • js/Promise-simple-fulfill-inside-callback.html: Removed.
  • js/Promise-simple-fulfill.html: Removed.
  • js/Promise-simple-in-workers-expected.txt: Removed.
  • js/Promise-simple-in-workers.html: Removed.
  • js/Promise-simple.html: Removed.
  • js/Promise-static-fulfill-expected.txt: Removed.
  • js/Promise-static-fulfill.html: Removed.
  • js/Promise-static-reject-expected.txt: Removed.
  • js/Promise-static-reject.html: Removed.
  • js/Promise-static-resolve-expected.txt: Removed.
  • js/Promise-static-resolve.html: Removed.
  • js/Promise-then-expected.txt: Removed.
  • js/Promise-then-in-workers-expected.txt: Removed.
  • js/Promise-then-in-workers.html: Removed.
  • js/Promise-then-without-callbacks-expected.txt: Removed.
  • js/Promise-then-without-callbacks-in-workers-expected.txt: Removed.
  • js/Promise-then-without-callbacks-in-workers.html: Removed.
  • js/Promise-then-without-callbacks.html: Removed.
  • js/Promise-then.html: Removed.
  • js/Promise-types-expected.txt: Removed.
  • js/Promise-types.html: Removed.
  • js/Promise.html: Removed.
  • js/activation-object-function-lifetime-expected.txt: Removed.
  • js/activation-object-function-lifetime.html: Removed.
  • js/activation-proto-expected.txt: Removed.
  • js/activation-proto.html: Removed.
  • js/add-to-primitive-expected.txt: Removed.
  • js/add-to-primitive.html: Removed.
  • js/array-float-delete-expected.txt: Removed.
  • js/array-float-delete.html: Removed.
  • js/array-foreach-expected.txt: Removed.
  • js/array-foreach.html: Removed.
  • js/array-indexof-expected.txt: Removed.
  • js/array-indexof.html: Removed.
  • js/array-join-bug-11524-expected.txt: Removed.
  • js/array-join-bug-11524.html: Removed.
  • js/array-map-expected.txt: Removed.
  • js/array-map.html: Removed.
  • js/array-prototype-properties-expected.txt: Removed.
  • js/array-prototype-properties.html: Removed.
  • js/array-some-expected.txt: Removed.
  • js/array-some.html: Removed.
  • js/array-sort-exception-expected.txt: Removed.
  • js/array-sort-exception.html: Removed.
  • js/array-tostring-ignore-separator-expected.txt: Removed.
  • js/array-tostring-ignore-separator.html: Removed.
  • js/array-with-double-assign-expected.txt: Removed.
  • js/array-with-double-assign.html: Removed.
  • js/array-with-double-push-expected.txt: Removed.
  • js/array-with-double-push.html: Removed.
  • js/assign-expected.txt: Removed.
  • js/assign.html: Removed.
  • js/basic-map-expected.txt: Removed.
  • js/basic-map.html: Removed.
  • js/basic-set-expected.txt: Removed.
  • js/basic-set.html: Removed.
  • js/basic-weakmap-expected.txt: Removed.
  • js/basic-weakmap.html: Removed.
  • js/bitwise-and-on-undefined-expected.txt: Removed.
  • js/bitwise-and-on-undefined.html: Removed.
  • js/bom-in-file-retains-correct-offset-expected.txt: Removed.
  • js/bom-in-file-retains-correct-offset.html: Removed.
  • js/branch-fold-correctness-expected.txt: Removed.
  • js/branch-fold-correctness.html: Removed.
  • js/cached-eval-gc-expected.txt: Removed.
  • js/cached-eval-gc.html: Removed.
  • js/call-base-resolution-expected.txt: Removed.
  • js/call-base-resolution.html: Removed.
  • js/callback-function-with-handle-event-expected.txt: Removed.
  • js/callback-function-with-handle-event.html: Removed.
  • js/codegen-temporaries-multiple-global-blocks-expected.txt: Removed.
  • js/codegen-temporaries-multiple-global-blocks.html: Removed.
  • js/concat-large-strings-crash-expected.txt: Removed.
  • js/concat-large-strings-crash.html: Removed.
  • js/concat-large-strings-crash2-expected.txt: Removed.
  • js/concat-large-strings-crash2.html: Removed.
  • js/console-non-string-values-expected.txt: Removed.
  • js/console-non-string-values.html: Removed.
  • js/const-expected.txt: Removed.
  • js/const.html: Removed.
  • js/construct-global-object-expected.txt: Removed.
  • js/construct-global-object.html: Removed.
  • js/constructor-attributes-expected.txt: Removed.
  • js/constructor-attributes.html: Removed.
  • js/constructor-expected.txt: Removed.
  • js/constructor-length.html: Removed.
  • js/constructor.html: Removed.
  • js/create-lots-of-workers-expected.txt: Removed.
  • js/create-lots-of-workers.html: Removed.
  • js/cross-frame-bad-time-expected.txt: Removed.
  • js/cross-frame-bad-time.html: Removed.
  • js/cross-frame-prototype-expected.txt: Removed.
  • js/cross-frame-prototype.html: Removed.
  • js/cross-frame-really-bad-time-expected.txt: Removed.
  • js/cross-frame-really-bad-time-with-proto-expected.txt: Removed.
  • js/cross-frame-really-bad-time-with-proto.html: Removed.
  • js/cross-frame-really-bad-time.html: Removed.
  • js/cross-global-object-inline-global-var-expected.txt: Removed.
  • js/cross-global-object-inline-global-var.html: Removed.
  • js/custom-constructors-expected.txt: Removed.
  • js/custom-constructors.html: Removed.
  • js/cyclic-proto-expected.txt: Removed.
  • js/cyclic-proto.html: Removed.
  • js/cyclic-ref-toString-expected.txt: Removed.
  • js/cyclic-ref-toString.html: Removed.
  • js/date-DST-time-cusps-expected.txt: Removed.
  • js/date-DST-time-cusps.html: Removed.
  • js/date-big-constructor-expected.txt: Removed.
  • js/date-big-constructor.html: Removed.
  • js/date-big-setdate-expected.txt: Removed.
  • js/date-big-setdate.html: Removed.
  • js/date-big-setmonth-expected.txt: Removed.
  • js/date-big-setmonth.html: Removed.
  • js/date-negative-setmonth-expected.txt: Removed.
  • js/date-negative-setmonth.html: Removed.
  • js/date-preserve-milliseconds-expected.txt: Removed.
  • js/date-preserve-milliseconds.html: Removed.
  • js/deep-recursion-test-expected.txt: Removed.
  • js/deep-recursion-test.html: Removed.
  • js/delete-function-parameter-expected.txt: Removed.
  • js/delete-function-parameter.html: Removed.
  • js/delete-multiple-global-blocks-expected.txt: Removed.
  • js/delete-multiple-global-blocks.html: Removed.
  • js/delete-syntax-expected.txt: Removed.
  • js/delete-syntax.html: Removed.
  • js/dfg-arguments-alias-activation-expected.txt: Removed.
  • js/dfg-arguments-alias-activation.html: Removed.
  • js/dfg-byte-array-put-expected.txt: Removed.
  • js/dfg-byte-array-put.html: Removed.
  • js/dfg-byteOffset-neuter-expected.txt: Removed.
  • js/dfg-byteOffset-neuter.html: Removed.
  • js/dfg-compare-final-object-to-final-object-or-other-expected.txt: Removed.
  • js/dfg-compare-final-object-to-final-object-or-other.html: Removed.
  • js/dfg-cross-global-object-inline-new-array-expected.txt: Removed.
  • js/dfg-cross-global-object-inline-new-array-literal-expected.txt: Removed.
  • js/dfg-cross-global-object-inline-new-array-literal-with-variables-expected.txt: Removed.
  • js/dfg-cross-global-object-inline-new-array-literal-with-variables.html: Removed.
  • js/dfg-cross-global-object-inline-new-array-literal.html: Removed.
  • js/dfg-cross-global-object-inline-new-array-with-elements-expected.txt: Removed.
  • js/dfg-cross-global-object-inline-new-array-with-elements.html: Removed.
  • js/dfg-cross-global-object-inline-new-array-with-size-expected.txt: Removed.
  • js/dfg-cross-global-object-inline-new-array-with-size.html: Removed.
  • js/dfg-cross-global-object-inline-new-array.html: Removed.
  • js/dfg-cross-global-object-new-array-expected.txt: Removed.
  • js/dfg-cross-global-object-new-array.html: Removed.
  • js/dfg-custom-getter-expected.txt: Removed.
  • js/dfg-custom-getter-throw-expected.txt: Removed.
  • js/dfg-custom-getter-throw-inlined-expected.txt: Removed.
  • js/dfg-custom-getter-throw-inlined.html: Removed.
  • js/dfg-custom-getter-throw.html: Removed.
  • js/dfg-custom-getter.html: Removed.
  • js/dfg-ensure-array-storage-on-window-expected.txt: Removed.
  • js/dfg-ensure-array-storage-on-window.html: Removed.
  • js/dfg-ensure-non-array-array-storage-on-window-expected.txt: Removed.
  • js/dfg-ensure-non-array-array-storage-on-window.html: Removed.
  • js/dfg-inline-resolve-expected.txt: Removed.
  • js/dfg-inline-resolve.html: Removed.
  • js/dfg-inline-switch-imm-expected.txt: Removed.
  • js/dfg-inline-switch-imm.html: Removed.
  • js/dfg-int32-to-double-on-set-local-and-exit-expected.txt: Removed.
  • js/dfg-int32-to-double-on-set-local-and-exit.html: Removed.
  • js/dfg-int32-to-double-on-set-local-and-sometimes-exit-expected.txt: Removed.
  • js/dfg-int32-to-double-on-set-local-and-sometimes-exit.html: Removed.
  • js/dfg-logical-not-final-object-or-other-expected.txt: Removed.
  • js/dfg-logical-not-final-object-or-other.html: Removed.
  • js/dfg-make-rope-side-effects-expected.txt: Removed.
  • js/dfg-make-rope-side-effects.html: Removed.
  • js/dfg-negative-array-size-expected.txt: Removed.
  • js/dfg-negative-array-size.html: Removed.
  • js/dfg-patchable-get-by-id-after-watchpoint-expected.txt: Removed.
  • js/dfg-patchable-get-by-id-after-watchpoint.html: Removed.
  • js/dfg-peephole-compare-final-object-to-final-object-or-other-expected.txt: Removed.
  • js/dfg-peephole-compare-final-object-to-final-object-or-other-when-both-proven-final-object-expected.txt: Removed.
  • js/dfg-peephole-compare-final-object-to-final-object-or-other-when-both-proven-final-object.html: Removed.
  • js/dfg-peephole-compare-final-object-to-final-object-or-other-when-proven-final-object-expected.txt: Removed.
  • js/dfg-peephole-compare-final-object-to-final-object-or-other-when-proven-final-object.html: Removed.
  • js/dfg-peephole-compare-final-object-to-final-object-or-other.html: Removed.
  • js/dfg-proto-stub-watchpoint-fire-expected.txt: Removed.
  • js/dfg-proto-stub-watchpoint-fire.html: Removed.
  • js/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-expected.txt: Removed.
  • js/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.html: Removed.
  • js/dfg-put-by-id-allocate-storage-expected.txt: Removed.
  • js/dfg-put-by-id-allocate-storage-polymorphic-expected.txt: Removed.
  • js/dfg-put-by-id-allocate-storage-polymorphic.html: Removed.
  • js/dfg-put-by-id-allocate-storage.html: Removed.
  • js/dfg-put-by-id-reallocate-storage-expected.txt: Removed.
  • js/dfg-put-by-id-reallocate-storage-polymorphic-expected.txt: Removed.
  • js/dfg-put-by-id-reallocate-storage-polymorphic.html: Removed.
  • js/dfg-put-by-id-reallocate-storage.html: Removed.
  • js/dfg-put-by-val-setter-then-get-by-val-expected.txt: Removed.
  • js/dfg-put-by-val-setter-then-get-by-val.html: Removed.
  • js/dfg-put-to-readonly-property-expected.txt: Removed.
  • js/dfg-put-to-readonly-property.html: Removed.
  • js/dfg-rshift-by-zero-eliminate-valuetoint32-expected.txt: Removed.
  • js/dfg-rshift-by-zero-eliminate-valuetoint32.html: Removed.
  • js/dfg-store-unexpected-value-into-argument-and-osr-exit-expected.txt: Removed.
  • js/dfg-store-unexpected-value-into-argument-and-osr-exit.html: Removed.
  • js/dfg-strcat-over-objects-then-exit-on-it-expected.txt: Removed.
  • js/dfg-strcat-over-objects-then-exit-on-it.html: Removed.
  • js/dfg-strict-mode-arguments-get-beyond-length-expected.txt: Removed.
  • js/dfg-strict-mode-arguments-get-beyond-length.html: Removed.
  • js/dfg-typed-array-neuter-expected.txt: Removed.
  • js/dfg-typed-array-neuter.html: Removed.
  • js/direct-entry-to-function-code-expected.txt: Removed.
  • js/direct-entry-to-function-code.html: Removed.
  • js/do-while-expression-value-expected.txt: Removed.
  • js/do-while-expression-value.html: Removed.
  • js/do-while-without-semicolon-expected.txt: Removed.
  • js/do-while-without-semicolon.html: Removed.
  • js/document-all-between-frames-expected.txt: Removed.
  • js/document-all-between-frames.html: Removed.
  • js/document-all-triggers-masquerades-watchpoint-expected.txt: Removed.
  • js/document-all-triggers-masquerades-watchpoint.html: Removed.
  • js/dom: Added.
  • js/dom-static-property-for-in-iteration-expected.txt: Removed.
  • js/dom-static-property-for-in-iteration.html: Removed.
  • js/dom/JSON-parse-expected.txt: Added.
  • js/dom/JSON-parse.html: Added.
  • js/dom/JSON-stringify-expected.txt: Added.
  • js/dom/JSON-stringify.html: Added.
  • js/dom/Object-defineProperty-expected.txt: Added.
  • js/dom/Object-defineProperty.html: Added.
  • js/dom/Promise-already-fulfilled-expected.txt: Added.
  • js/dom/Promise-already-fulfilled.html: Added.
  • js/dom/Promise-already-rejected-expected.txt: Added.
  • js/dom/Promise-already-rejected.html: Added.
  • js/dom/Promise-already-resolved-expected.txt: Added.
  • js/dom/Promise-already-resolved.html: Added.
  • js/dom/Promise-catch-expected.txt: Added.
  • js/dom/Promise-catch-in-workers-expected.txt: Added.
  • js/dom/Promise-catch-in-workers.html: Added.
  • js/dom/Promise-catch.html: Added.
  • js/dom/Promise-chain-expected.txt: Added.
  • js/dom/Promise-chain.html: Added.
  • js/dom/Promise-exception-expected.txt: Added.
  • js/dom/Promise-exception.html: Added.
  • js/dom/Promise-expected.txt: Added.
  • js/dom/Promise-fulfill-expected.txt: Added.
  • js/dom/Promise-fulfill-in-workers-expected.txt: Added.
  • js/dom/Promise-fulfill-in-workers.html: Added.
  • js/dom/Promise-fulfill.html: Added.
  • js/dom/Promise-init-expected.txt: Added.
  • js/dom/Promise-init-in-workers-expected.txt: Added.
  • js/dom/Promise-init-in-workers.html: Added.
  • js/dom/Promise-init.html: Added.
  • js/dom/Promise-reject-expected.txt: Added.
  • js/dom/Promise-reject-in-workers-expected.txt: Added.
  • js/dom/Promise-reject-in-workers.html: Added.
  • js/dom/Promise-reject.html: Added.
  • js/dom/Promise-resolve-chain-expected.txt: Added.
  • js/dom/Promise-resolve-chain.html: Added.
  • js/dom/Promise-resolve-expected.txt: Added.
  • js/dom/Promise-resolve-in-workers-expected.txt: Added.
  • js/dom/Promise-resolve-in-workers.html: Added.
  • js/dom/Promise-resolve-with-then-exception-expected.txt: Added.
  • js/dom/Promise-resolve-with-then-exception.html: Added.
  • js/dom/Promise-resolve-with-then-fulfill-expected.txt: Added.
  • js/dom/Promise-resolve-with-then-fulfill.html: Added.
  • js/dom/Promise-resolve-with-then-reject-expected.txt: Added.
  • js/dom/Promise-resolve-with-then-reject.html: Added.
  • js/dom/Promise-resolve.html: Added.
  • js/dom/Promise-simple-expected.txt: Added.
  • js/dom/Promise-simple-fulfill-expected.txt: Added.
  • js/dom/Promise-simple-fulfill-inside-callback-expected.txt: Added.
  • js/dom/Promise-simple-fulfill-inside-callback.html: Added.
  • js/dom/Promise-simple-fulfill.html: Added.
  • js/dom/Promise-simple-in-workers-expected.txt: Added.
  • js/dom/Promise-simple-in-workers.html: Added.
  • js/dom/Promise-simple.html: Added.
  • js/dom/Promise-static-fulfill-expected.txt: Added.
  • js/dom/Promise-static-fulfill.html: Added.
  • js/dom/Promise-static-reject-expected.txt: Added.
  • js/dom/Promise-static-reject.html: Added.
  • js/dom/Promise-static-resolve-expected.txt: Added.
  • js/dom/Promise-static-resolve.html: Added.
  • js/dom/Promise-then-expected.txt: Added.
  • js/dom/Promise-then-in-workers-expected.txt: Added.
  • js/dom/Promise-then-in-workers.html: Added.
  • js/dom/Promise-then-without-callbacks-expected.txt: Added.
  • js/dom/Promise-then-without-callbacks-in-workers-expected.txt: Added.
  • js/dom/Promise-then-without-callbacks-in-workers.html: Added.
  • js/dom/Promise-then-without-callbacks.html: Added.
  • js/dom/Promise-then.html: Added.
  • js/dom/Promise-types-expected.txt: Added.
  • js/dom/Promise-types.html: Added.
  • js/dom/Promise.html: Added.
  • js/dom/activation-object-function-lifetime-expected.txt: Added.
  • js/dom/activation-object-function-lifetime.html: Added.
  • js/dom/activation-proto-expected.txt: Added.
  • js/dom/activation-proto.html: Added.
  • js/dom/add-to-primitive-expected.txt: Added.
  • js/dom/add-to-primitive.html: Added.
  • js/dom/array-float-delete-expected.txt: Added.
  • js/dom/array-float-delete.html: Added.
  • js/dom/array-foreach-expected.txt: Added.
  • js/dom/array-foreach.html: Added.
  • js/dom/array-indexof-expected.txt: Added.
  • js/dom/array-indexof.html: Added.
  • js/dom/array-join-bug-11524-expected.txt: Added.
  • js/dom/array-join-bug-11524.html: Added.
  • js/dom/array-map-expected.txt: Added.
  • js/dom/array-map.html: Added.
  • js/dom/array-prototype-properties-expected.txt: Added.
  • js/dom/array-prototype-properties.html: Added.
  • js/dom/array-some-expected.txt: Added.
  • js/dom/array-some.html: Added.
  • js/dom/array-sort-exception-expected.txt: Added.
  • js/dom/array-sort-exception.html: Added.
  • js/dom/array-tostring-ignore-separator-expected.txt: Added.
  • js/dom/array-tostring-ignore-separator.html: Added.
  • js/dom/array-with-double-assign-expected.txt: Added.
  • js/dom/array-with-double-assign.html: Added.
  • js/dom/array-with-double-push-expected.txt: Added.
  • js/dom/array-with-double-push.html: Added.
  • js/dom/assign-expected.txt: Added.
  • js/dom/assign.html: Added.
  • js/dom/basic-map-expected.txt: Added.
  • js/dom/basic-map.html: Added.
  • js/dom/basic-set-expected.txt: Added.
  • js/dom/basic-set.html: Added.
  • js/dom/basic-weakmap-expected.txt: Added.
  • js/dom/basic-weakmap.html: Added.
  • js/dom/bitwise-and-on-undefined-expected.txt: Added.
  • js/dom/bitwise-and-on-undefined.html: Added.
  • js/dom/bom-in-file-retains-correct-offset-expected.txt: Added.
  • js/dom/bom-in-file-retains-correct-offset.html: Added.
  • js/dom/branch-fold-correctness-expected.txt: Added.
  • js/dom/branch-fold-correctness.html: Added.
  • js/dom/cached-eval-gc-expected.txt: Added.
  • js/dom/cached-eval-gc.html: Added.
  • js/dom/call-base-resolution-expected.txt: Added.
  • js/dom/call-base-resolution.html: Added.
  • js/dom/callback-function-with-handle-event-expected.txt: Added.
  • js/dom/callback-function-with-handle-event.html: Added.
  • js/dom/codegen-temporaries-multiple-global-blocks-expected.txt: Added.
  • js/dom/codegen-temporaries-multiple-global-blocks.html: Added.
  • js/dom/concat-large-strings-crash-expected.txt: Added.
  • js/dom/concat-large-strings-crash.html: Added.
  • js/dom/concat-large-strings-crash2-expected.txt: Added.
  • js/dom/concat-large-strings-crash2.html: Added.
  • js/dom/console-non-string-values-expected.txt: Added.
  • js/dom/console-non-string-values.html: Added.
  • js/dom/const-expected.txt: Added.
  • js/dom/const.html: Added.
  • js/dom/construct-global-object-expected.txt: Added.
  • js/dom/construct-global-object.html: Added.
  • js/dom/constructor-attributes-expected.txt: Added.
  • js/dom/constructor-attributes.html: Added.
  • js/dom/constructor-expected.txt: Added.
  • js/dom/constructor-length.html: Added.
  • js/dom/constructor.html: Added.
  • js/dom/create-lots-of-workers-expected.txt: Added.
  • js/dom/create-lots-of-workers.html: Added.
  • js/dom/cross-frame-bad-time-expected.txt: Added.
  • js/dom/cross-frame-bad-time.html: Added.
  • js/dom/cross-frame-prototype-expected.txt: Added.
  • js/dom/cross-frame-prototype.html: Added.
  • js/dom/cross-frame-really-bad-time-expected.txt: Added.
  • js/dom/cross-frame-really-bad-time-with-proto-expected.txt: Added.
  • js/dom/cross-frame-really-bad-time-with-proto.html: Added.
  • js/dom/cross-frame-really-bad-time.html: Added.
  • js/dom/cross-global-object-inline-global-var-expected.txt: Added.
  • js/dom/cross-global-object-inline-global-var.html: Added.
  • js/dom/custom-constructors-expected.txt: Added.
  • js/dom/custom-constructors.html: Added.
  • js/dom/cyclic-proto-expected.txt: Added.
  • js/dom/cyclic-proto.html: Added.
  • js/dom/cyclic-ref-toString-expected.txt: Added.
  • js/dom/cyclic-ref-toString.html: Added.
  • js/dom/date-DST-time-cusps-expected.txt: Added.
  • js/dom/date-DST-time-cusps.html: Added.
  • js/dom/date-big-constructor-expected.txt: Added.
  • js/dom/date-big-constructor.html: Added.
  • js/dom/date-big-setdate-expected.txt: Added.
  • js/dom/date-big-setdate.html: Added.
  • js/dom/date-big-setmonth-expected.txt: Added.
  • js/dom/date-big-setmonth.html: Added.
  • js/dom/date-negative-setmonth-expected.txt: Added.
  • js/dom/date-negative-setmonth.html: Added.
  • js/dom/date-preserve-milliseconds-expected.txt: Added.
  • js/dom/date-preserve-milliseconds.html: Added.
  • js/dom/deep-recursion-test-expected.txt: Added.
  • js/dom/deep-recursion-test.html: Added.
  • js/dom/delete-function-parameter-expected.txt: Added.
  • js/dom/delete-function-parameter.html: Added.
  • js/dom/delete-multiple-global-blocks-expected.txt: Added.
  • js/dom/delete-multiple-global-blocks.html: Added.
  • js/dom/delete-syntax-expected.txt: Added.
  • js/dom/delete-syntax.html: Added.
  • js/dom/dfg-arguments-alias-activation-expected.txt: Added.
  • js/dom/dfg-arguments-alias-activation.html: Added.
  • js/dom/dfg-byte-array-put-expected.txt: Added.
  • js/dom/dfg-byte-array-put.html: Added.
  • js/dom/dfg-byteOffset-neuter-expected.txt: Added.
  • js/dom/dfg-byteOffset-neuter.html: Added.
  • js/dom/dfg-compare-final-object-to-final-object-or-other-expected.txt: Added.
  • js/dom/dfg-compare-final-object-to-final-object-or-other.html: Added.
  • js/dom/dfg-cross-global-object-inline-new-array-expected.txt: Added.
  • js/dom/dfg-cross-global-object-inline-new-array-literal-expected.txt: Added.
  • js/dom/dfg-cross-global-object-inline-new-array-literal-with-variables-expected.txt: Added.
  • js/dom/dfg-cross-global-object-inline-new-array-literal-with-variables.html: Added.
  • js/dom/dfg-cross-global-object-inline-new-array-literal.html: Added.
  • js/dom/dfg-cross-global-object-inline-new-array-with-elements-expected.txt: Added.
  • js/dom/dfg-cross-global-object-inline-new-array-with-elements.html: Added.
  • js/dom/dfg-cross-global-object-inline-new-array-with-size-expected.txt: Added.
  • js/dom/dfg-cross-global-object-inline-new-array-with-size.html: Added.
  • js/dom/dfg-cross-global-object-inline-new-array.html: Added.
  • js/dom/dfg-cross-global-object-new-array-expected.txt: Added.
  • js/dom/dfg-cross-global-object-new-array.html: Added.
  • js/dom/dfg-custom-getter-expected.txt: Added.
  • js/dom/dfg-custom-getter-throw-expected.txt: Added.
  • js/dom/dfg-custom-getter-throw-inlined-expected.txt: Added.
  • js/dom/dfg-custom-getter-throw-inlined.html: Added.
  • js/dom/dfg-custom-getter-throw.html: Added.
  • js/dom/dfg-custom-getter.html: Added.
  • js/dom/dfg-ensure-array-storage-on-window-expected.txt: Added.
  • js/dom/dfg-ensure-array-storage-on-window.html: Added.
  • js/dom/dfg-ensure-non-array-array-storage-on-window-expected.txt: Added.
  • js/dom/dfg-ensure-non-array-array-storage-on-window.html: Added.
  • js/dom/dfg-inline-resolve-expected.txt: Added.
  • js/dom/dfg-inline-resolve.html: Added.
  • js/dom/dfg-inline-switch-imm-expected.txt: Added.
  • js/dom/dfg-inline-switch-imm.html: Added.
  • js/dom/dfg-int32-to-double-on-set-local-and-exit-expected.txt: Added.
  • js/dom/dfg-int32-to-double-on-set-local-and-exit.html: Added.
  • js/dom/dfg-int32-to-double-on-set-local-and-sometimes-exit-expected.txt: Added.
  • js/dom/dfg-int32-to-double-on-set-local-and-sometimes-exit.html: Added.
  • js/dom/dfg-logical-not-final-object-or-other-expected.txt: Added.
  • js/dom/dfg-logical-not-final-object-or-other.html: Added.
  • js/dom/dfg-make-rope-side-effects-expected.txt: Added.
  • js/dom/dfg-make-rope-side-effects.html: Added.
  • js/dom/dfg-negative-array-size-expected.txt: Added.
  • js/dom/dfg-negative-array-size.html: Added.
  • js/dom/dfg-patchable-get-by-id-after-watchpoint-expected.txt: Added.
  • js/dom/dfg-patchable-get-by-id-after-watchpoint.html: Added.
  • js/dom/dfg-peephole-compare-final-object-to-final-object-or-other-expected.txt: Added.
  • js/dom/dfg-peephole-compare-final-object-to-final-object-or-other-when-both-proven-final-object-expected.txt: Added.
  • js/dom/dfg-peephole-compare-final-object-to-final-object-or-other-when-both-proven-final-object.html: Added.
  • js/dom/dfg-peephole-compare-final-object-to-final-object-or-other-when-proven-final-object-expected.txt: Added.
  • js/dom/dfg-peephole-compare-final-object-to-final-object-or-other-when-proven-final-object.html: Added.
  • js/dom/dfg-peephole-compare-final-object-to-final-object-or-other.html: Added.
  • js/dom/dfg-proto-stub-watchpoint-fire-expected.txt: Added.
  • js/dom/dfg-proto-stub-watchpoint-fire.html: Added.
  • js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-expected.txt: Added.
  • js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.html: Added.
  • js/dom/dfg-put-by-id-allocate-storage-expected.txt: Added.
  • js/dom/dfg-put-by-id-allocate-storage-polymorphic-expected.txt: Added.
  • js/dom/dfg-put-by-id-allocate-storage-polymorphic.html: Added.
  • js/dom/dfg-put-by-id-allocate-storage.html: Added.
  • js/dom/dfg-put-by-id-reallocate-storage-expected.txt: Added.
  • js/dom/dfg-put-by-id-reallocate-storage-polymorphic-expected.txt: Added.
  • js/dom/dfg-put-by-id-reallocate-storage-polymorphic.html: Added.
  • js/dom/dfg-put-by-id-reallocate-storage.html: Added.
  • js/dom/dfg-put-by-val-setter-then-get-by-val-expected.txt: Added.
  • js/dom/dfg-put-by-val-setter-then-get-by-val.html: Added.
  • js/dom/dfg-put-to-readonly-property-expected.txt: Added.
  • js/dom/dfg-put-to-readonly-property.html: Added.
  • js/dom/dfg-rshift-by-zero-eliminate-valuetoint32-expected.txt: Added.
  • js/dom/dfg-rshift-by-zero-eliminate-valuetoint32.html: Added.
  • js/dom/dfg-store-unexpected-value-into-argument-and-osr-exit-expected.txt: Added.
  • js/dom/dfg-store-unexpected-value-into-argument-and-osr-exit.html: Added.
  • js/dom/dfg-strcat-over-objects-then-exit-on-it-expected.txt: Added.
  • js/dom/dfg-strcat-over-objects-then-exit-on-it.html: Added.
  • js/dom/dfg-strict-mode-arguments-get-beyond-length-expected.txt: Added.
  • js/dom/dfg-strict-mode-arguments-get-beyond-length.html: Added.
  • js/dom/dfg-typed-array-neuter-expected.txt: Added.
  • js/dom/dfg-typed-array-neuter.html: Added.
  • js/dom/direct-entry-to-function-code-expected.txt: Added.
  • js/dom/direct-entry-to-function-code.html: Added.
  • js/dom/do-while-expression-value-expected.txt: Added.
  • js/dom/do-while-expression-value.html: Added.
  • js/dom/do-while-without-semicolon-expected.txt: Added.
  • js/dom/do-while-without-semicolon.html: Added.
  • js/dom/document-all-between-frames-expected.txt: Added.
  • js/dom/document-all-between-frames.html: Added.
  • js/dom/document-all-triggers-masquerades-watchpoint-expected.txt: Added.
  • js/dom/document-all-triggers-masquerades-watchpoint.html: Added.
  • js/dom/dom-static-property-for-in-iteration-expected.txt: Added.
  • js/dom/dom-static-property-for-in-iteration.html: Added.
  • js/dom/dot-node-base-exception-expected.txt: Added.
  • js/dom/dot-node-base-exception.html: Added.
  • js/dom/encode-URI-test-expected.txt: Added.
  • js/dom/encode-URI-test.html: Added.
  • js/dom/end-in-string-escape-expected.txt: Added.
  • js/dom/end-in-string-escape.html: Added.
  • js/dom/enter-dictionary-indexing-mode-with-blank-indexing-type-expected.txt: Added.
  • js/dom/enter-dictionary-indexing-mode-with-blank-indexing-type.html: Added.
  • js/dom/error-object-write-and-detele-for-stack-property-expected.txt: Added.
  • js/dom/error-object-write-and-detele-for-stack-property.html: Added.
  • js/dom/eval-cache-scoped-lookup-expected.txt: Added.
  • js/dom/eval-cache-scoped-lookup.html: Added.
  • js/dom/eval-contained-syntax-error-expected.txt: Added.
  • js/dom/eval-contained-syntax-error.html: Added.
  • js/dom/eval-cross-window-expected.txt: Added.
  • js/dom/eval-cross-window.html: Added.
  • js/dom/eval-keyword-vs-function-expected.txt: Added.
  • js/dom/eval-keyword-vs-function.html: Added.
  • js/dom/eval-overriding-expected.txt: Added.
  • js/dom/eval-overriding.html: Added.
  • js/dom/exception-codegen-crash-expected.txt: Added.
  • js/dom/exception-codegen-crash.html: Added.
  • js/dom/exception-line-number-expected.txt: Added.
  • js/dom/exception-line-number.html: Added.
  • js/dom/exception-linenums-in-html-1-expected.txt: Added.
  • js/dom/exception-linenums-in-html-1.html: Added.
  • js/dom/exception-linenums-in-html-2-expected.txt: Added.
  • js/dom/exception-linenums-in-html-2.html: Added.
  • js/dom/exception-linenums-in-html-3-expected.txt: Added.
  • js/dom/exception-linenums-in-html-3.html: Added.
  • js/dom/exception-registerfile-shrink-expected.txt: Added.
  • js/dom/exception-registerfile-shrink.html: Added.
  • js/dom/exception-sequencing-binops-expected.txt: Added.
  • js/dom/exception-sequencing-binops.html: Added.
  • js/dom/exception-sequencing-binops2-expected.txt: Added.
  • js/dom/exception-sequencing-binops2.html: Added.
  • js/dom/exception-sequencing-expected.txt: Added.
  • js/dom/exception-sequencing.html: Added.
  • js/dom/exception-thrown-from-equal-expected.txt: Added.
  • js/dom/exception-thrown-from-equal.html: Added.
  • js/dom/exception-thrown-from-eval-inside-closure-expected.txt: Added.
  • js/dom/exception-thrown-from-eval-inside-closure.html: Added.
  • js/dom/exception-thrown-from-function-with-lazy-activation-expected.txt: Added.
  • js/dom/exception-thrown-from-function-with-lazy-activation.html: Added.
  • js/dom/exception-thrown-from-new-expected.txt: Added.
  • js/dom/exception-thrown-from-new.html: Added.
  • js/dom/exceptions-thrown-in-callbacks-expected.txt: Added.
  • js/dom/exceptions-thrown-in-callbacks.html: Added.
  • js/dom/exec-state-marking-expected.txt: Added.
  • js/dom/exec-state-marking.html: Added.
  • js/dom/find-ignoring-case-regress-99753-expected.txt: Added.
  • js/dom/find-ignoring-case-regress-99753.html: Added.
  • js/dom/floating-point-truncate-rshift-expected.txt: Added.
  • js/dom/floating-point-truncate-rshift.html: Added.
  • js/dom/function-argument-evaluation-before-exception-expected.txt: Added.
  • js/dom/function-argument-evaluation-before-exception.html: Added.
  • js/dom/function-argument-evaluation-expected.txt: Added.
  • js/dom/function-argument-evaluation.html: Added.
  • js/dom/function-bind-expected.txt: Added.
  • js/dom/function-bind.html: Added.
  • js/dom/function-constructor-this-value-expected.txt: Added.
  • js/dom/function-constructor-this-value.html: Added.
  • js/dom/function-declarations-expected.txt: Added.
  • js/dom/function-declarations.html: Added.
  • js/dom/function-decompilation-operators-expected.txt: Added.
  • js/dom/function-decompilation-operators.html: Added.
  • js/dom/function-dot-arguments-and-caller-expected.txt: Added.
  • js/dom/function-dot-arguments-and-caller.html: Added.
  • js/dom/function-dot-arguments-identity-expected.txt: Added.
  • js/dom/function-dot-arguments-identity.html: Added.
  • js/dom/function-dot-arguments2-expected.txt: Added.
  • js/dom/function-dot-arguments2.html: Added.
  • js/dom/function-length-expected.txt: Added.
  • js/dom/function-length.html: Added.
  • js/dom/function-name-expected.txt: Added.
  • js/dom/function-name-is-in-scope-expected.txt: Added.
  • js/dom/function-name-is-in-scope.html: Added.
  • js/dom/function-name.html: Added.
  • js/dom/function-names-expected.txt: Added.
  • js/dom/function-names.html: Added.
  • js/dom/function-prototype-expected.txt: Added.
  • js/dom/function-prototype.html: Added.
  • js/dom/function-redefinition-expected.txt: Added.
  • js/dom/function-redefinition.html: Added.
  • js/dom/garbage-collect-after-string-appends-expected.txt: Added.
  • js/dom/get-by-pname-only-prototype-properties-expected.txt: Added.
  • js/dom/get-by-pname-only-prototype-properties.html: Added.
  • js/dom/getOwnPropertyDescriptor-expected.txt: Added.
  • js/dom/getOwnPropertyDescriptor.html: Added.
  • js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Added.
  • js/dom/global-constructors-attributes-dedicated-worker.html: Added.
  • js/dom/global-constructors-attributes-expected.txt: Added.
  • js/dom/global-constructors-attributes-shared-worker-expected.txt: Added.
  • js/dom/global-constructors-attributes-shared-worker.html: Added.
  • js/dom/global-constructors-attributes.html: Added.
  • js/dom/global-constructors-deletable-expected.txt: Added.
  • js/dom/global-constructors-deletable.html: Added.
  • js/dom/global-function-resolve-expected.txt: Added.
  • js/dom/global-function-resolve.html: Added.
  • js/dom/global-recursion-on-full-stack-expected.txt: Added.
  • js/dom/global-recursion-on-full-stack.html: Added.
  • js/dom/global-var-limit-expected.txt: Added.
  • js/dom/global-var-limit.html: Added.
  • js/dom/immediate-constant-instead-of-cell-expected.txt: Added.
  • js/dom/immediate-constant-instead-of-cell.html: Added.
  • js/dom/implicit-call-with-global-reentry-expected.txt: Added.
  • js/dom/implicit-call-with-global-reentry.html: Added.
  • js/dom/implicit-global-to-global-reentry-expected.txt: Added.
  • js/dom/implicit-global-to-global-reentry.html: Added.
  • js/dom/imul-expected.txt: Added.
  • js/dom/imul.html: Added.
  • js/dom/inc-bracket-assign-subscript-expected.txt: Added.
  • js/dom/inc-bracket-assign-subscript.html: Added.
  • js/dom/inc-const-valueOf-expected.txt: Added.
  • js/dom/inc-const-valueOf.html: Added.
  • js/dom/indexed-setter-on-global-object-expected.txt: Added.
  • js/dom/indexed-setter-on-global-object.html: Added.
  • js/dom/inline-arguments-tear-off-expected.txt: Added.
  • js/dom/inline-arguments-tear-off.html: Added.
  • js/dom/instanceof-XMLHttpRequest-expected.txt: Added.
  • js/dom/instanceof-XMLHttpRequest.html: Added.
  • js/dom/invalid-syntax-for-function-expected.txt: Added.
  • js/dom/invalid-syntax-for-function.html: Added.
  • js/dom/jit-set-profiling-access-type-only-for-get-by-id-self-expected.txt: Added.
  • js/dom/jit-set-profiling-access-type-only-for-get-by-id-self.html: Added.
  • js/dom/js-constructors-use-correct-global-expected.txt: Added.
  • js/dom/js-constructors-use-correct-global.html: Added.
  • js/dom/js-correct-exception-handler-expected.txt: Added.
  • js/dom/js-correct-exception-handler.html: Added.
  • js/dom/lastModified-expected.txt: Added.
  • js/dom/lastModified.html: Added.
  • js/dom/lazy-create-arguments-from-get-by-val-expected.txt: Added.
  • js/dom/lazy-create-arguments-from-get-by-val.html: Added.
  • js/dom/lexical-lookup-in-function-constructor-expected.txt: Added.
  • js/dom/lexical-lookup-in-function-constructor.html: Added.
  • js/dom/line-column-numbers-expected.txt: Added.
  • js/dom/line-column-numbers.html: Added.
  • js/dom/method-check-expected.txt: Added.
  • js/dom/method-check.html: Added.
  • js/dom/missing-style-end-tag-js-expected.txt: Added.
  • js/dom/missing-style-end-tag-js.html: Added.
  • js/dom/missing-title-end-tag-js-expected.txt: Added.
  • js/dom/missing-title-end-tag-js.html: Added.
  • js/dom/native-error-prototype-expected.txt: Added.
  • js/dom/native-error-prototype.html: Added.
  • js/dom/navigator-language-expected.txt: Added.
  • js/dom/navigator-language.html: Added.
  • js/dom/navigator-plugins-crash-expected.txt: Added.
  • js/dom/navigator-plugins-crash.html: Added.
  • js/dom/negate-overflow-expected.txt: Added.
  • js/dom/negate-overflow.html: Added.
  • js/dom/neq-null-crash-expected.txt: Added.
  • js/dom/neq-null-crash.html: Added.
  • js/dom/nested-function-scope-expected.txt: Added.
  • js/dom/nested-function-scope.html: Added.
  • js/dom/nested-object-gc-expected.txt: Added.
  • js/dom/nested-object-gc.html: Added.
  • js/dom/non-object-proto-expected.txt: Added.
  • js/dom/non-object-proto.html: Added.
  • js/dom/normal-character-escapes-in-string-literals-expected.txt: Added.
  • js/dom/normal-character-escapes-in-string-literals.html: Added.
  • js/dom/not-a-constructor-to-string-expected.txt: Added.
  • js/dom/not-a-constructor-to-string.html: Added.
  • js/dom/not-a-function-to-string-expected.txt: Added.
  • js/dom/not-a-function-to-string.html: Added.
  • js/dom/null-char-in-string-expected.txt: Added.
  • js/dom/null-char-in-string.html: Added.
  • js/dom/number-tofixed-expected.txt: Added.
  • js/dom/number-tofixed.html: Added.
  • js/dom/number-toprecision-expected.txt: Added.
  • js/dom/number-toprecision.html: Added.
  • js/dom/object-extra-comma-expected.txt: Added.
  • js/dom/object-extra-comma.html: Added.
  • js/dom/object-prototype-constructor-expected.txt: Added.
  • js/dom/object-prototype-constructor.html: Added.
  • js/dom/object-prototype-properties-expected.txt: Added.
  • js/dom/object-prototype-properties.html: Added.
  • js/dom/object-prototype-toLocaleString-expected.txt: Added.
  • js/dom/object-prototype-toLocaleString.html: Added.
  • js/dom/parse-error-external-script-in-eval-expected.txt: Added.
  • js/dom/parse-error-external-script-in-eval.html: Added.
  • js/dom/parse-error-external-script-in-new-Function-expected.txt: Added.
  • js/dom/parse-error-external-script-in-new-Function.html: Added.
  • js/dom/post-inc-assign-overwrites-expected.txt: Added.
  • js/dom/post-inc-assign-overwrites.html: Added.
  • js/dom/post-message-numeric-property-expected.txt: Added.
  • js/dom/post-message-numeric-property.html: Added.
  • js/dom/postfix-syntax-expected.txt: Added.
  • js/dom/postfix-syntax.html: Added.
  • js/dom/prefix-syntax-expected.txt: Added.
  • js/dom/prefix-syntax.html: Added.
  • js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-expected.txt: Added.
  • js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps.html: Added.
  • js/dom/put-direct-index-beyond-vector-length-resize-expected.txt: Added.
  • js/dom/put-direct-index-beyond-vector-length-resize.html: Added.
  • js/dom/put-to-base-global-checked-expected.txt: Added.
  • js/dom/put-to-base-global-checked.html: Added.
  • js/dom/random-array-gc-stress-expected.txt: Added.
  • js/dom/random-array-gc-stress.html: Added.
  • js/dom/recursion-limit-equal-expected.txt: Added.
  • js/dom/recursion-limit-equal.html: Added.
  • js/dom/regexp-bol-expected.txt: Added.
  • js/dom/regexp-bol-with-multiline-expected.txt: Added.
  • js/dom/regexp-bol-with-multiline.html: Added.
  • js/dom/regexp-bol.html: Added.
  • js/dom/regexp-caching-expected.txt: Added.
  • js/dom/regexp-caching.html: Added.
  • js/dom/regexp-charclass-crash-expected.txt: Added.
  • js/dom/regexp-charclass-crash.html: Added.
  • js/dom/regexp-extended-characters-crash-expected.txt: Added.
  • js/dom/regexp-extended-characters-crash.html: Added.
  • js/dom/regexp-lastindex-expected.txt: Added.
  • js/dom/regexp-lastindex.html: Added.
  • js/dom/regexp-look-ahead-empty-expected.txt: Added.
  • js/dom/regexp-look-ahead-empty.html: Added.
  • js/dom/regexp-look-ahead-expected.txt: Added.
  • js/dom/regexp-look-ahead.html: Added.
  • js/dom/regexp-match-reify-before-putbyval-expected.txt: Added.
  • js/dom/regexp-match-reify-before-putbyval.html: Added.
  • js/dom/regexp-non-capturing-groups-expected.txt: Added.
  • js/dom/regexp-non-capturing-groups.html: Added.
  • js/dom/regexp-non-greedy-parentheses-expected.txt: Added.
  • js/dom/regexp-non-greedy-parentheses.html: Added.
  • js/dom/regexp-overflow-expected.txt: Added.
  • js/dom/regexp-overflow.html: Added.
  • js/dom/regexp-range-out-of-order-expected.txt: Added.
  • js/dom/regexp-range-out-of-order.html: Added.
  • js/dom/regexp-ranges-and-escaped-hyphens-expected.txt: Added.
  • js/dom/regexp-ranges-and-escaped-hyphens.html: Added.
  • js/dom/regexp-stack-overflow-expected.txt: Added.
  • js/dom/regexp-stack-overflow.html: Added.
  • js/dom/regexp-test-null-string-expected.txt: Added.
  • js/dom/regexp-test-null-string.html: Added.
  • js/dom/regexp-unicode-handling-expected.txt: Added.
  • js/dom/regexp-unicode-handling.html: Added.
  • js/dom/regexp-unicode-overflow-expected.txt: Added.
  • js/dom/regexp-unicode-overflow.html: Added.
  • js/dom/removing-Cf-characters-expected.txt: Added.
  • js/dom/removing-Cf-characters.html: Added.
  • js/dom/reserved-words-as-property-expected.txt: Added.
  • js/dom/reserved-words-as-property.html: Added.
  • js/dom/same-origin-subframe-about-blank-expected.txt: Added.
  • js/dom/same-origin-subframe-about-blank.html: Added.
  • js/dom/script-line-number-expected.txt: Added.
  • js/dom/script-line-number.html: Added.
  • js/dom/script-tests: Added.
  • js/dom/script-tests/Object-defineProperty.js: Added.

(createUnconfigurableProperty):
(getter):
(getter1):
(setter):
(setter1):
(get shouldBeTrue):
(testObject.):
(testObject.set get anObj):
(testObject):

  • js/dom/script-tests/activation-proto.js: Added.
  • js/dom/script-tests/array-float-delete.js: Added.
  • js/dom/script-tests/array-join-bug-11524.js: Added.

(customObject.valueOf):

  • js/dom/script-tests/array-prototype-properties.js: Added.
  • js/dom/script-tests/array-sort-exception.js: Copied from LayoutTests/js/script-tests/array-sort-exception.js.
  • js/dom/script-tests/array-tostring-ignore-separator.js: Added.
  • js/dom/script-tests/array-with-double-assign.js: Added.

(foo):

  • js/dom/script-tests/array-with-double-push.js: Added.

(foo):

  • js/dom/script-tests/assign.js: Added.
  • js/dom/script-tests/basic-map.js: Added.

(set shouldBe):
(set var):

  • js/dom/script-tests/basic-set.js: Added.

(set new):
(otherString.string_appeared_here.set add):
(try.set forEach):
(set forEach):
(set gc):

  • js/dom/script-tests/basic-weakmap.js: Added.
  • js/dom/script-tests/cached-eval-gc.js: Added.

(gc):
(doTest):

  • js/dom/script-tests/constructor-attributes.js: Added.

(canEnum):
(checkConstructor):
(declaredFunction):

  • js/dom/script-tests/constructor.js: Added.
  • js/dom/script-tests/cross-frame-bad-time.js: Added.

(foo):

  • js/dom/script-tests/cross-frame-really-bad-time-with-proto.js: Added.

(foo):
(evil):
(bar):
(done):

  • js/dom/script-tests/cross-frame-really-bad-time.js: Added.

(Cons):
(foo):
(evil):
(bar):
(done):

  • js/dom/script-tests/cross-global-object-inline-global-var.js: Added.

(foo):
(done):
(doit):

  • js/dom/script-tests/custom-constructors.js: Added.
  • js/dom/script-tests/cyclic-proto.js: Added.
  • js/dom/script-tests/cyclic-ref-toString.js: Added.
  • js/dom/script-tests/date-DST-time-cusps.js: Added.
  • js/dom/script-tests/date-big-constructor.js: Added.
  • js/dom/script-tests/date-big-setdate.js: Added.
  • js/dom/script-tests/date-big-setmonth.js: Added.
  • js/dom/script-tests/date-negative-setmonth.js: Added.
  • js/dom/script-tests/date-preserve-milliseconds.js: Added.
  • js/dom/script-tests/delete-syntax.js: Added.
  • js/dom/script-tests/dfg-byte-array-put.js: Added.

(doPut):
(doGet):

  • js/dom/script-tests/dfg-byteOffset-neuter.js: Added.

(foo):

  • js/dom/script-tests/dfg-compare-final-object-to-final-object-or-other.js: Added.

(foo):

  • js/dom/script-tests/dfg-cross-global-object-inline-new-array-literal-with-variables.js: Added.

(foo):
(done):
(doit):

  • js/dom/script-tests/dfg-cross-global-object-inline-new-array-literal.js: Added.

(foo):
(done):
(doit):

  • js/dom/script-tests/dfg-cross-global-object-inline-new-array-with-elements.js: Added.

(foo):
(done):
(doit):

  • js/dom/script-tests/dfg-cross-global-object-inline-new-array-with-size.js: Added.

(foo):
(done):
(doit):

  • js/dom/script-tests/dfg-cross-global-object-inline-new-array.js: Added.

(foo):
(done):
(doit):

  • js/dom/script-tests/dfg-cross-global-object-new-array.js: Added.

(foo):
(runTest):
(doit):

  • js/dom/script-tests/dfg-custom-getter-throw-inlined.js: Added.

(foo):
(baz):
(bar):

  • js/dom/script-tests/dfg-custom-getter-throw.js: Added.

(foo):
(bar):

  • js/dom/script-tests/dfg-custom-getter.js: Added.

(foo):

  • js/dom/script-tests/dfg-ensure-array-storage-on-window.js: Added.

(foo):
(while):

  • js/dom/script-tests/dfg-ensure-non-array-array-storage-on-window.js: Added.

(foo):
(bar):
(.shouldBe):

  • js/dom/script-tests/dfg-inline-switch-imm.js: Added.

(foo):
(bar):

  • js/dom/script-tests/dfg-int32-to-double-on-set-local-and-exit.js: Added.

(checkpoint):
(func1):
(func2):
(func3):
(test):

  • js/dom/script-tests/dfg-int32-to-double-on-set-local-and-sometimes-exit.js: Added.

(checkpoint):
(func1):
(func2):
(func3):
(test):

  • js/dom/script-tests/dfg-logical-not-final-object-or-other.js: Added.

(foo):

  • js/dom/script-tests/dfg-make-rope-side-effects.js: Added.

(f):
(k.valueOf):
(k.toString):

  • js/dom/script-tests/dfg-negative-array-size.js: Added.

(foo):

  • js/dom/script-tests/dfg-patchable-get-by-id-after-watchpoint.js: Added.

(foo):
(O):
(O.prototype.f):
(P1):
(P2):

  • js/dom/script-tests/dfg-peephole-compare-final-object-to-final-object-or-other-when-both-proven-final-object.js: Added.

(foo):

  • js/dom/script-tests/dfg-peephole-compare-final-object-to-final-object-or-other-when-proven-final-object.js: Added.

(foo):

  • js/dom/script-tests/dfg-peephole-compare-final-object-to-final-object-or-other.js: Added.

(foo):

  • js/dom/script-tests/dfg-proto-stub-watchpoint-fire.js: Added.

(A):
(B):
(foo):

  • js/dom/script-tests/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.js: Added.

(f):

  • js/dom/script-tests/dfg-put-by-id-allocate-storage-polymorphic.js: Added.

(foo):

  • js/dom/script-tests/dfg-put-by-id-allocate-storage.js: Added.

(foo):

  • js/dom/script-tests/dfg-put-by-id-reallocate-storage-polymorphic.js: Added.

(foo):

  • js/dom/script-tests/dfg-put-by-id-reallocate-storage.js: Added.

(foo):

  • js/dom/script-tests/dfg-put-by-val-setter-then-get-by-val.js: Added.

(foo):
(for):

  • js/dom/script-tests/dfg-put-to-readonly-property.js: Added.

(foo):
(bar):

  • js/dom/script-tests/dfg-rshift-by-zero-eliminate-valuetoint32.js: Added.

(f):

  • js/dom/script-tests/dfg-store-unexpected-value-into-argument-and-osr-exit.js: Added.

(foo):

  • js/dom/script-tests/dfg-strcat-over-objects-then-exit-on-it.js: Added.

(foo):
(bar):
(x):

  • js/dom/script-tests/dfg-strict-mode-arguments-get-beyond-length.js: Added.

(foo):
(bar):

  • js/dom/script-tests/dfg-typed-array-neuter.js: Added.

(foo):
(bar):

  • js/dom/script-tests/document-all-triggers-masquerades-watchpoint.js: Added.

(f):

  • js/dom/script-tests/dot-node-base-exception.js: Added.
  • js/dom/script-tests/end-in-string-escape.js: Added.
  • js/dom/script-tests/enter-dictionary-indexing-mode-with-blank-indexing-type.js: Added.
  • js/dom/script-tests/eval-cache-scoped-lookup.js: Added.

(first):
(a.string_appeared_here.second):
(third):
(fifth):
(sixth):
(seventh):
(eighth):
(nineth):
(tenth):
(eleventh):

  • js/dom/script-tests/eval-contained-syntax-error.js: Added.
  • js/dom/script-tests/exception-line-number.js: Added.

(foo):
(window.onerror):

  • js/dom/script-tests/exception-registerfile-shrink.js: Added.
  • js/dom/script-tests/exception-sequencing-binops.js: Copied from LayoutTests/js/exception-sequencing-binops.js.
  • js/dom/script-tests/function-bind.js: Added.

(F):

  • js/dom/script-tests/function-name.js: Added.
  • js/dom/script-tests/function-names.js: Added.

(checkConstructorName):

  • js/dom/script-tests/get-by-pname-only-prototype-properties.js: Added.

(foo):

  • js/dom/script-tests/global-constructors-attributes.js: Added.

(.self.postMessage):
(.self.onconnect.self.postMessage):
(.self.onconnect):
(classNameForObject):
(constructorPropertiesOnGlobalObject):

  • js/dom/script-tests/global-constructors-deletable.js: Added.
  • js/dom/script-tests/global-function-resolve.js: Added.
  • js/dom/script-tests/immediate-constant-instead-of-cell.js: Added.
  • js/dom/script-tests/implicit-call-with-global-reentry.js: Added.

(testGlobalCode):
(testObject.get getterTest):
(testObject.set setterTest):
(testObject.toString):
(testObject.valueOf):
(testObject.toStringTest):
(testObject.valueOfTest):

  • js/dom/script-tests/imul.js: Added.

(testIMul):

  • js/dom/script-tests/inc-bracket-assign-subscript.js: Added.

(testPreIncBracketAccessWithAssignSubscript):
(testPostIncBracketAccessWithAssignSubscript):

  • js/dom/script-tests/inc-const-valueOf.js: Added.

(testPostIncConstVarWithIgnoredResult.const.a.valueOf):
(testPostIncConstVarWithIgnoredResult):
(testPreIncConstVarWithIgnoredResult.const.a.valueOf):
(testPreIncConstVarWithIgnoredResult):
(testPreIncConstVarWithAssign.const.a.valueOf):
(testPreIncConstVarWithAssign):

  • js/dom/script-tests/indexed-setter-on-global-object.js: Added.
  • js/dom/script-tests/inline-arguments-tear-off.js: Added.

(g):
(f):
(doStuff):

  • js/dom/script-tests/instanceof-XMLHttpRequest.js: Added.
  • js/dom/script-tests/jit-set-profiling-access-type-only-for-get-by-id-self.js: Added.

(L_):
(Q2):
(f):

  • js/dom/script-tests/js-correct-exception-handler.js: Added.

(throwEventually):
(f.g):
(f):
(test):

  • js/dom/script-tests/lastModified.js: Added.
  • js/dom/script-tests/lazy-create-arguments-from-get-by-val.js: Added.

(foo):

  • js/dom/script-tests/line-column-numbers.js: Added.

(try.doThrow4b):
(doThrow5b.try.innerFunc):
(doThrow5b):
(doThrow6b.try.innerFunc):
(doThrow6b):
(catch):
(try.doThrow11b):
(try.doThrow14b):
(try.testObj19b.toString):
(try.testObj19b.run):
(try.test20b.f):
(try.test20b):
(try.toFuzz21b):
(try.toFuzz22b):

  • js/dom/script-tests/method-check.js: Added.

(func2):
(func.String.prototype.a):
(func.String.prototype.b):
(func):
(addOne):
(addOneHundred):
(totalizer.makeCall):

  • js/dom/script-tests/native-error-prototype.js: Added.
  • js/dom/script-tests/neq-null-crash.js: Added.

(crush):

  • js/dom/script-tests/nested-object-gc.js: Added.
  • js/dom/script-tests/non-object-proto.js: Added.
  • js/dom/script-tests/normal-character-escapes-in-string-literals.js: Added.

(test):
(testOther):

  • js/dom/script-tests/null-char-in-string.js: Added.
  • js/dom/script-tests/number-tofixed.js: Added.
  • js/dom/script-tests/number-toprecision.js: Added.
  • js/dom/script-tests/object-extra-comma.js: Added.
  • js/dom/script-tests/object-prototype-constructor.js: Added.

(Foo.Bar):
(F):

  • js/dom/script-tests/object-prototype-properties.js: Added.
  • js/dom/script-tests/object-prototype-toLocaleString.js: Added.

(o.toLocaleString):
(String.prototype.toString):

  • js/dom/script-tests/post-inc-assign-overwrites.js: Added.

(postIncDotAssignToBase):
(postIncBracketAssignToBase):
(postIncBracketAssignToSubscript):

  • js/dom/script-tests/post-message-numeric-property.js: Added.

(window.onmessage):

  • js/dom/script-tests/postfix-syntax.js: Added.
  • js/dom/script-tests/prefix-syntax.js: Added.
  • js/dom/script-tests/prototype-chain-caching-with-impure-get-own-property-slot-traps.js: Added.

(f):

  • js/dom/script-tests/put-direct-index-beyond-vector-length-resize.js: Added.
  • js/dom/script-tests/put-to-base-global-checked.js: Added.

(globalF):
(warmup):
(foo):

  • js/dom/script-tests/random-array-gc-stress.js: Added.

(getRandomIndex):
(test):

  • js/dom/script-tests/recursion-limit-equal.js: Added.

(test):

  • js/dom/script-tests/regexp-bol-with-multiline.js: Added.
  • js/dom/script-tests/regexp-bol.js: Added.
  • js/dom/script-tests/regexp-extended-characters-crash.js: Added.
  • js/dom/script-tests/regexp-lastindex.js: Added.
  • js/dom/script-tests/regexp-look-ahead-empty.js: Added.
  • js/dom/script-tests/regexp-look-ahead.js: Added.
  • js/dom/script-tests/regexp-match-reify-before-putbyval.js: Added.
  • js/dom/script-tests/regexp-non-capturing-groups.js: Added.
  • js/dom/script-tests/regexp-non-greedy-parentheses.js: Added.
  • js/dom/script-tests/regexp-overflow.js: Added.
  • js/dom/script-tests/regexp-range-out-of-order.js: Added.
  • js/dom/script-tests/regexp-ranges-and-escaped-hyphens.js: Added.
  • js/dom/script-tests/regexp-stack-overflow.js: Added.
  • js/dom/script-tests/regexp-unicode-handling.js: Added.

(Gn):

  • js/dom/script-tests/regexp-unicode-overflow.js: Added.

(createRegExs):

  • js/dom/script-tests/removing-Cf-characters.js: Added.
  • js/dom/script-tests/reserved-words-as-property.js: Added.

(testWordEvalAndFunction):
(testWord):
(testWordStrictAndNonStrict):

  • js/dom/script-tests/select-options-add.js: Added.
  • js/dom/script-tests/stack-at-creation-for-error-objects.js: Added.

(checkStack):

  • js/dom/script-tests/stack-trace.js: Added.

(printStack):
(hostThrower):
(callbacker):
(outer):
(inner):
(evaler):
(normalOuter):
(normalInner):
(scripterInner):
(scripterOuter):
(selfRecursive1):
(selfRecursive2):
(selfRecursive3):
(throwError):
(object.get getter1.o.valueOf):
(object.get getter1):
(object.get getter2):
(object.get getter3.o2.valueOf):
(object.get getter3):
(object.nonInlineable.callCount):
(object.nonInlineable):
(object.inlineable):
(yetAnotherInlinedCall):
(makeInlinableCall):
(.try.g):
(h):
(mapTest):
(mapTestDriver):
(dfgFunction):
(try.f):
(callNonCallable):
(dfgTest):
(inlineableThrow):
(dfgThing.get willThrow):
(dfgThing.get willThrowEventually):
(dfgThing.willThrowFunc):
(dfgThing.willThrowEventuallyFunc):
(dfg1):
(dfg2):
(dfg3):
(dfg4):
(dfg5):
(dfg6):
(dfg7):
(dfg8):
(dfg9):
(dfga):
(dfgb):
(dfgc):

  • js/dom/script-tests/strict-readonly-statics.js: Added.

(testWindowUndefined):
(testNumberMAX_VALUE):

  • js/dom/script-tests/string-match.js: Added.

(testMatch):

  • js/dom/script-tests/string-prototype-properties.js: Added.

(Number.prototype.toString):

  • js/dom/script-tests/string-replace-2.js: Added.

(testReplace):
(replacer):

  • js/dom/script-tests/string-replace-3.js: Added.
  • js/dom/script-tests/string-replacement-outofmemory.js: Added.

(createStringWithRepeatedChar):

  • js/dom/script-tests/string-split-conformance.js: Added.
  • js/dom/script-tests/string-split-double-empty.js: Added.
  • js/dom/script-tests/string-split-ignore-case.js: Added.
  • js/dom/script-tests/switch-behaviour.js: Added.

(characterSwitch):
(sparseCharacterSwitch):

  • js/dom/script-tests/throw-exception-in-global-setter.js: Added.

(callSetter):

  • js/dom/script-tests/toInt32UInt32.js: Added.
  • js/dom/script-tests/toString-exception.js: Added.
  • js/dom/script-tests/toString-overrides.js: Added.

(Number.prototype.toString):
(Number.prototype.toLocaleString):
(RegExp.prototype.toString):
(RegExp.prototype.toLocaleString):

  • js/dom/script-tests/toString-stack-overflow.js: Added.
  • js/dom/script-tests/transition-cache-dictionary-crash.js: Added.

(f):

  • js/dom/script-tests/typed-array-access.js: Added.

(bitsToString):
(bitsToValue):
(valueToBits):
(roundTrip):

  • js/dom/script-tests/typed-array-set-different-types.js: Added.

(MyRandom):
(.reference):
(.usingConstruct):

  • js/dom/script-tests/typeof-syntax.js: Added.
  • js/dom/script-tests/unshift-multi.js: Added.

(unshift1):
(unshift2):
(unshift5):

  • js/dom/script-tests/vardecl-preserve-arguments.js: Added.

(argumentsLength):
(argumentsLengthInnerBlock):
(argumentsLengthInnerBlock2):
(argumentsLengthTryCatch):
(argumentsLengthWith):
(argumentsLengthOverride):
(argumentsLengthOverrideInnerBlock):
(argumentsLengthOverrideInnerBlock2):
(argumentsLengthOverrideInnerBlock3):
(argumentsTearOff1):
(argumentsTearOff2):
(argumentsTearOff3):

  • js/dom/script-tests/webcore-string-comparison.js: Added.
  • js/dom/script-tests/with-scope-gc.js: Added.

(gc):

  • js/dom/select-options-add-expected.txt: Added.
  • js/dom/select-options-add.html: Added.
  • js/dom/select-options-remove-expected.txt: Added.
  • js/dom/select-options-remove-gc-expected.txt: Added.
  • js/dom/select-options-remove-gc.html: Added.
  • js/dom/select-options-remove.html: Added.
  • js/dom/stack-at-creation-for-error-objects-expected.txt: Added.
  • js/dom/stack-at-creation-for-error-objects.html: Added.
  • js/dom/stack-trace-expected.txt: Added.
  • js/dom/stack-trace.html: Added.
  • js/dom/strict-readonly-statics-expected.txt: Added.
  • js/dom/strict-readonly-statics.html: Added.
  • js/dom/string-anchor-expected.txt: Added.
  • js/dom/string-anchor.html: Added.
  • js/dom/string-concatenate-outofmemory-expected.txt: Added.
  • js/dom/string-fontcolor-expected.txt: Added.
  • js/dom/string-fontcolor.html: Added.
  • js/dom/string-fontsize-expected.txt: Added.
  • js/dom/string-fontsize.html: Added.
  • js/dom/string-link-expected.txt: Added.
  • js/dom/string-link.html: Added.
  • js/dom/string-match-expected.txt: Added.
  • js/dom/string-match.html: Added.
  • js/dom/string-prototype-properties-expected.txt: Added.
  • js/dom/string-prototype-properties.html: Added.
  • js/dom/string-replace-2-expected.txt: Added.
  • js/dom/string-replace-2.html: Added.
  • js/dom/string-replace-3-expected.txt: Added.
  • js/dom/string-replace-3.html: Added.
  • js/dom/string-replace-exception-crash-expected.txt: Added.
  • js/dom/string-replace-exception-crash.html: Added.
  • js/dom/string-replacement-outofmemory-expected.txt: Added.
  • js/dom/string-replacement-outofmemory.html: Added.
  • js/dom/string-split-conformance-expected.txt: Added.
  • js/dom/string-split-conformance.html: Added.
  • js/dom/string-split-double-empty-expected.txt: Added.
  • js/dom/string-split-double-empty.html: Added.
  • js/dom/string-split-ignore-case-expected.txt: Added.
  • js/dom/string-split-ignore-case.html: Added.
  • js/dom/switch-behaviour-expected.txt: Added.
  • js/dom/switch-behaviour.html: Added.
  • js/dom/text-field-resize-expected.txt: Added.
  • js/dom/text-field-resize.html: Added.
  • js/dom/throw-exception-in-global-setter-expected.txt: Added.
  • js/dom/throw-exception-in-global-setter.html: Added.
  • js/dom/throw-from-array-sort-expected.txt: Added.
  • js/dom/throw-from-array-sort.html: Added.
  • js/dom/toInt32UInt32-expected.txt: Added.
  • js/dom/toInt32UInt32.html: Added.
  • js/dom/toString-and-valueOf-override-expected.txt: Added.
  • js/dom/toString-and-valueOf-override.html: Added.
  • js/dom/toString-dontEnum-expected.txt: Added.
  • js/dom/toString-dontEnum.html: Added.
  • js/dom/toString-exception-expected.txt: Added.
  • js/dom/toString-exception.html: Added.
  • js/dom/toString-number-expected.txt: Added.
  • js/dom/toString-number.html: Added.
  • js/dom/toString-overrides-expected.txt: Added.
  • js/dom/toString-overrides.html: Added.
  • js/dom/toString-stack-overflow-expected.txt: Added.
  • js/dom/toString-stack-overflow.html: Added.
  • js/dom/toString-try-else-expected.txt: Added.
  • js/dom/toString-try-else.html: Added.
  • js/dom/transition-cache-dictionary-crash-expected.txt: Added.
  • js/dom/transition-cache-dictionary-crash.html: Added.
  • js/dom/trivial-functions-expected.txt: Added.
  • js/dom/trivial-functions.html: Added.
  • js/dom/try-catch-crash-expected.txt: Added.
  • js/dom/try-catch-crash.html: Added.
  • js/dom/typed-array-access-expected.txt: Added.
  • js/dom/typed-array-access.html: Added.
  • js/dom/typed-array-set-different-types-expected.txt: Added.
  • js/dom/typed-array-set-different-types.html: Added.
  • js/dom/typeof-syntax-expected.txt: Added.
  • js/dom/typeof-syntax.html: Added.
  • js/dom/uncaught-exception-line-number-expected.txt: Added.
  • js/dom/uncaught-exception-line-number.html: Added.
  • js/dom/unshift-multi-expected.txt: Added.
  • js/dom/unshift-multi.html: Added.
  • js/dom/var-declarations-expected.txt: Added.
  • js/dom/var-declarations-shadowing-expected.txt: Added.
  • js/dom/var-declarations-shadowing.html: Added.
  • js/dom/var-declarations.html: Added.
  • js/dom/vardecl-preserve-arguments-expected.txt: Added.
  • js/dom/vardecl-preserve-arguments.html: Added.
  • js/dom/vardecl-preserve-parameters-expected.txt: Added.
  • js/dom/vardecl-preserve-parameters.html: Added.
  • js/dom/vardecl-preserve-vardecl-expected.txt: Added.
  • js/dom/vardecl-preserve-vardecl.html: Added.
  • js/dom/webcore-string-comparison-expected.txt: Added.
  • js/dom/webcore-string-comparison.html: Added.
  • js/dom/webidl-type-mapping-expected.txt: Added.
  • js/dom/webidl-type-mapping.html: Added.
  • js/dom/while-expression-value-expected.txt: Added.
  • js/dom/while-expression-value.html: Added.
  • js/dom/window-location-href-file-urls-expected.txt: Added.
  • js/dom/window-location-href-file-urls.html: Added.
  • js/dom/with-scope-gc-expected.txt: Added.
  • js/dom/with-scope-gc.html: Added.
  • js/dot-node-base-exception-expected.txt: Removed.
  • js/dot-node-base-exception.html: Removed.
  • js/encode-URI-test-expected.txt: Removed.
  • js/encode-URI-test.html: Removed.
  • js/end-in-string-escape-expected.txt: Removed.
  • js/end-in-string-escape.html: Removed.
  • js/enter-dictionary-indexing-mode-with-blank-indexing-type-expected.txt: Removed.
  • js/enter-dictionary-indexing-mode-with-blank-indexing-type.html: Removed.
  • js/error-object-write-and-detele-for-stack-property-expected.txt: Removed.
  • js/error-object-write-and-detele-for-stack-property.html: Removed.
  • js/eval-cache-scoped-lookup-expected.txt: Removed.
  • js/eval-cache-scoped-lookup.html: Removed.
  • js/eval-contained-syntax-error-expected.txt: Removed.
  • js/eval-contained-syntax-error.html: Removed.
  • js/eval-cross-window-expected.txt: Removed.
  • js/eval-cross-window.html: Removed.
  • js/eval-keyword-vs-function-expected.txt: Removed.
  • js/eval-keyword-vs-function.html: Removed.
  • js/eval-overriding-expected.txt: Removed.
  • js/eval-overriding.html: Removed.
  • js/exception-codegen-crash-expected.txt: Removed.
  • js/exception-codegen-crash.html: Removed.
  • js/exception-line-number-expected.txt: Removed.
  • js/exception-line-number.html: Removed.
  • js/exception-linenums-in-html-1-expected.txt: Removed.
  • js/exception-linenums-in-html-1.html: Removed.
  • js/exception-linenums-in-html-2-expected.txt: Removed.
  • js/exception-linenums-in-html-2.html: Removed.
  • js/exception-linenums-in-html-3-expected.txt: Removed.
  • js/exception-linenums-in-html-3.html: Removed.
  • js/exception-registerfile-shrink-expected.txt: Removed.
  • js/exception-registerfile-shrink.html: Removed.
  • js/exception-sequencing-binops-expected.txt: Removed.
  • js/exception-sequencing-binops.html: Removed.
  • js/exception-sequencing-binops.js: Removed.
  • js/exception-sequencing-binops2-expected.txt: Removed.
  • js/exception-sequencing-binops2.html: Removed.
  • js/exception-sequencing-expected.txt: Removed.
  • js/exception-sequencing.html: Removed.
  • js/exception-thrown-from-equal-expected.txt: Removed.
  • js/exception-thrown-from-equal.html: Removed.
  • js/exception-thrown-from-eval-inside-closure-expected.txt: Removed.
  • js/exception-thrown-from-eval-inside-closure.html: Removed.
  • js/exception-thrown-from-function-with-lazy-activation-expected.txt: Removed.
  • js/exception-thrown-from-function-with-lazy-activation.html: Removed.
  • js/exception-thrown-from-new-expected.txt: Removed.
  • js/exception-thrown-from-new.html: Removed.
  • js/exceptions-thrown-in-callbacks-expected.txt: Removed.
  • js/exceptions-thrown-in-callbacks.html: Removed.
  • js/exec-state-marking-expected.txt: Removed.
  • js/exec-state-marking.html: Removed.
  • js/find-ignoring-case-regress-99753-expected.txt: Removed.
  • js/find-ignoring-case-regress-99753.html: Removed.
  • js/floating-point-truncate-rshift-expected.txt: Removed.
  • js/floating-point-truncate-rshift.html: Removed.
  • js/function-argument-evaluation-before-exception-expected.txt: Removed.
  • js/function-argument-evaluation-before-exception.html: Removed.
  • js/function-argument-evaluation-expected.txt: Removed.
  • js/function-argument-evaluation.html: Removed.
  • js/function-bind-expected.txt: Removed.
  • js/function-bind.html: Removed.
  • js/function-constructor-this-value-expected.txt: Removed.
  • js/function-constructor-this-value.html: Removed.
  • js/function-declarations-expected.txt: Removed.
  • js/function-declarations.html: Removed.
  • js/function-decompilation-operators-expected.txt: Removed.
  • js/function-decompilation-operators.html: Removed.
  • js/function-dot-arguments-and-caller-expected.txt: Removed.
  • js/function-dot-arguments-and-caller.html: Removed.
  • js/function-dot-arguments-identity-expected.txt: Removed.
  • js/function-dot-arguments-identity.html: Removed.
  • js/function-dot-arguments2-expected.txt: Removed.
  • js/function-dot-arguments2.html: Removed.
  • js/function-length-expected.txt: Removed.
  • js/function-length.html: Removed.
  • js/function-name-expected.txt: Removed.
  • js/function-name-is-in-scope-expected.txt: Removed.
  • js/function-name-is-in-scope.html: Removed.
  • js/function-name.html: Removed.
  • js/function-names-expected.txt: Removed.
  • js/function-names.html: Removed.
  • js/function-prototype-expected.txt: Removed.
  • js/function-prototype.html: Removed.
  • js/function-redefinition-expected.txt: Removed.
  • js/function-redefinition.html: Removed.
  • js/garbage-collect-after-string-appends-expected.txt: Removed.
  • js/get-by-pname-only-prototype-properties-expected.txt: Removed.
  • js/get-by-pname-only-prototype-properties.html: Removed.
  • js/getOwnPropertyDescriptor-expected.txt: Removed.
  • js/getOwnPropertyDescriptor.html: Removed.
  • js/global-constructors-attributes-dedicated-worker-expected.txt: Removed.
  • js/global-constructors-attributes-dedicated-worker.html: Removed.
  • js/global-constructors-attributes-expected.txt: Removed.
  • js/global-constructors-attributes-shared-worker-expected.txt: Removed.
  • js/global-constructors-attributes-shared-worker.html: Removed.
  • js/global-constructors-attributes.html: Removed.
  • js/global-constructors-deletable-expected.txt: Removed.
  • js/global-constructors-deletable.html: Removed.
  • js/global-function-resolve-expected.txt: Removed.
  • js/global-function-resolve.html: Removed.
  • js/global-recursion-on-full-stack-expected.txt: Removed.
  • js/global-recursion-on-full-stack.html: Removed.
  • js/global-var-limit-expected.txt: Removed.
  • js/global-var-limit.html: Removed.
  • js/immediate-constant-instead-of-cell-expected.txt: Removed.
  • js/immediate-constant-instead-of-cell.html: Removed.
  • js/implicit-call-with-global-reentry-expected.txt: Removed.
  • js/implicit-call-with-global-reentry.html: Removed.
  • js/implicit-global-to-global-reentry-expected.txt: Removed.
  • js/implicit-global-to-global-reentry.html: Removed.
  • js/imul-expected.txt: Removed.
  • js/imul.html: Removed.
  • js/inc-bracket-assign-subscript-expected.txt: Removed.
  • js/inc-bracket-assign-subscript.html: Removed.
  • js/inc-const-valueOf-expected.txt: Removed.
  • js/inc-const-valueOf.html: Removed.
  • js/indexed-setter-on-global-object-expected.txt: Removed.
  • js/indexed-setter-on-global-object.html: Removed.
  • js/inline-arguments-tear-off-expected.txt: Removed.
  • js/inline-arguments-tear-off.html: Removed.
  • js/instanceof-XMLHttpRequest-expected.txt: Removed.
  • js/instanceof-XMLHttpRequest.html: Removed.
  • js/invalid-syntax-for-function-expected.txt: Removed.
  • js/invalid-syntax-for-function.html: Removed.
  • js/jit-set-profiling-access-type-only-for-get-by-id-self-expected.txt: Removed.
  • js/jit-set-profiling-access-type-only-for-get-by-id-self.html: Removed.
  • js/js-constructors-use-correct-global-expected.txt: Removed.
  • js/js-constructors-use-correct-global.html: Removed.
  • js/js-correct-exception-handler-expected.txt: Removed.
  • js/js-correct-exception-handler.html: Removed.
  • js/jsc-test-list: Removed.
  • js/lastModified-expected.txt: Removed.
  • js/lastModified.html: Removed.
  • js/lazy-create-arguments-from-get-by-val-expected.txt: Removed.
  • js/lazy-create-arguments-from-get-by-val.html: Removed.
  • js/lexical-lookup-in-function-constructor-expected.txt: Removed.
  • js/lexical-lookup-in-function-constructor.html: Removed.
  • js/line-column-numbers-expected.txt: Removed.
  • js/line-column-numbers.html: Removed.
  • js/method-check-expected.txt: Removed.
  • js/method-check.html: Removed.
  • js/missing-style-end-tag-js-expected.txt: Removed.
  • js/missing-style-end-tag-js.html: Removed.
  • js/missing-title-end-tag-js-expected.txt: Removed.
  • js/missing-title-end-tag-js.html: Removed.
  • js/native-error-prototype-expected.txt: Removed.
  • js/native-error-prototype.html: Removed.
  • js/navigator-language-expected.txt: Removed.
  • js/navigator-language.html: Removed.
  • js/navigator-plugins-crash-expected.txt: Removed.
  • js/navigator-plugins-crash.html: Removed.
  • js/negate-overflow-expected.txt: Removed.
  • js/negate-overflow.html: Removed.
  • js/neq-null-crash-expected.txt: Removed.
  • js/neq-null-crash.html: Removed.
  • js/nested-function-scope-expected.txt: Removed.
  • js/nested-function-scope.html: Removed.
  • js/nested-object-gc-expected.txt: Removed.
  • js/nested-object-gc.html: Removed.
  • js/non-object-proto-expected.txt: Removed.
  • js/non-object-proto.html: Removed.
  • js/normal-character-escapes-in-string-literals-expected.txt: Removed.
  • js/normal-character-escapes-in-string-literals.html: Removed.
  • js/not-a-constructor-to-string-expected.txt: Removed.
  • js/not-a-constructor-to-string.html: Removed.
  • js/not-a-function-to-string-expected.txt: Removed.
  • js/not-a-function-to-string.html: Removed.
  • js/null-char-in-string-expected.txt: Removed.
  • js/null-char-in-string.html: Removed.
  • js/number-tofixed-expected.txt: Removed.
  • js/number-tofixed.html: Removed.
  • js/number-toprecision-expected.txt: Removed.
  • js/number-toprecision.html: Removed.
  • js/object-extra-comma-expected.txt: Removed.
  • js/object-extra-comma.html: Removed.
  • js/object-prototype-constructor-expected.txt: Removed.
  • js/object-prototype-constructor.html: Removed.
  • js/object-prototype-properties-expected.txt: Removed.
  • js/object-prototype-properties.html: Removed.
  • js/object-prototype-toLocaleString-expected.txt: Removed.
  • js/object-prototype-toLocaleString.html: Removed.
  • js/parse-error-external-script-in-eval-expected.txt: Removed.
  • js/parse-error-external-script-in-eval.html: Removed.
  • js/parse-error-external-script-in-new-Function-expected.txt: Removed.
  • js/parse-error-external-script-in-new-Function.html: Removed.
  • js/post-inc-assign-overwrites-expected.txt: Removed.
  • js/post-inc-assign-overwrites.html: Removed.
  • js/post-message-numeric-property-expected.txt: Removed.
  • js/post-message-numeric-property.html: Removed.
  • js/postfix-syntax-expected.txt: Removed.
  • js/postfix-syntax.html: Removed.
  • js/prefix-syntax-expected.txt: Removed.
  • js/prefix-syntax.html: Removed.
  • js/prototype-chain-caching-with-impure-get-own-property-slot-traps-expected.txt: Removed.
  • js/prototype-chain-caching-with-impure-get-own-property-slot-traps.html: Removed.
  • js/put-direct-index-beyond-vector-length-resize-expected.txt: Removed.
  • js/put-direct-index-beyond-vector-length-resize.html: Removed.
  • js/put-to-base-global-checked-expected.txt: Removed.
  • js/put-to-base-global-checked.html: Removed.
  • js/random-array-gc-stress-expected.txt: Removed.
  • js/random-array-gc-stress.html: Removed.
  • js/recursion-limit-equal-expected.txt: Removed.
  • js/recursion-limit-equal.html: Removed.
  • js/regexp-bol-expected.txt: Removed.
  • js/regexp-bol-with-multiline-expected.txt: Removed.
  • js/regexp-bol-with-multiline.html: Removed.
  • js/regexp-bol.html: Removed.
  • js/regexp-caching-expected.txt: Removed.
  • js/regexp-caching.html: Removed.
  • js/regexp-charclass-crash-expected.txt: Removed.
  • js/regexp-charclass-crash.html: Removed.
  • js/regexp-extended-characters-crash-expected.txt: Removed.
  • js/regexp-extended-characters-crash.html: Removed.
  • js/regexp-lastindex-expected.txt: Removed.
  • js/regexp-lastindex.html: Removed.
  • js/regexp-look-ahead-empty-expected.txt: Removed.
  • js/regexp-look-ahead-empty.html: Removed.
  • js/regexp-look-ahead-expected.txt: Removed.
  • js/regexp-look-ahead.html: Removed.
  • js/regexp-match-reify-before-putbyval-expected.txt: Removed.
  • js/regexp-match-reify-before-putbyval.html: Removed.
  • js/regexp-non-capturing-groups-expected.txt: Removed.
  • js/regexp-non-capturing-groups.html: Removed.
  • js/regexp-non-greedy-parentheses-expected.txt: Removed.
  • js/regexp-non-greedy-parentheses.html: Removed.
  • js/regexp-overflow-expected.txt: Removed.
  • js/regexp-overflow.html: Removed.
  • js/regexp-range-out-of-order-expected.txt: Removed.
  • js/regexp-range-out-of-order.html: Removed.
  • js/regexp-ranges-and-escaped-hyphens-expected.txt: Removed.
  • js/regexp-ranges-and-escaped-hyphens.html: Removed.
  • js/regexp-stack-overflow-expected.txt: Removed.
  • js/regexp-stack-overflow.html: Removed.
  • js/regexp-test-null-string-expected.txt: Removed.
  • js/regexp-test-null-string.html: Removed.
  • js/regexp-unicode-handling-expected.txt: Removed.
  • js/regexp-unicode-handling.html: Removed.
  • js/regexp-unicode-overflow-expected.txt: Removed.
  • js/regexp-unicode-overflow.html: Removed.
  • js/removing-Cf-characters-expected.txt: Removed.
  • js/removing-Cf-characters.html: Removed.
  • js/reserved-words-as-property-expected.txt: Removed.
  • js/reserved-words-as-property.html: Removed.
  • js/same-origin-subframe-about-blank-expected.txt: Removed.
  • js/same-origin-subframe-about-blank.html: Removed.
  • js/script-line-number-expected.txt: Removed.
  • js/script-line-number.html: Removed.
  • js/script-tests/Object-defineProperty.js: Removed.
  • js/script-tests/activation-proto.js: Removed.
  • js/script-tests/array-float-delete.js: Removed.
  • js/script-tests/array-join-bug-11524.js: Removed.
  • js/script-tests/array-prototype-properties.js: Removed.
  • js/script-tests/array-sort-exception.js: Removed.
  • js/script-tests/array-tostring-ignore-separator.js: Removed.
  • js/script-tests/array-with-double-assign.js: Removed.
  • js/script-tests/array-with-double-push.js: Removed.
  • js/script-tests/assign.js: Removed.
  • js/script-tests/basic-map.js: Removed.
  • js/script-tests/basic-set.js: Removed.
  • js/script-tests/basic-weakmap.js: Removed.
  • js/script-tests/cached-eval-gc.js: Removed.
  • js/script-tests/constructor-attributes.js: Removed.
  • js/script-tests/constructor.js: Removed.
  • js/script-tests/cross-frame-bad-time.js: Removed.
  • js/script-tests/cross-frame-really-bad-time-with-proto.js: Removed.
  • js/script-tests/cross-frame-really-bad-time.js: Removed.
  • js/script-tests/cross-global-object-inline-global-var.js: Removed.
  • js/script-tests/custom-constructors.js: Removed.
  • js/script-tests/cyclic-proto.js: Removed.
  • js/script-tests/cyclic-ref-toString.js: Removed.
  • js/script-tests/date-DST-time-cusps.js: Removed.
  • js/script-tests/date-big-constructor.js: Removed.
  • js/script-tests/date-big-setdate.js: Removed.
  • js/script-tests/date-big-setmonth.js: Removed.
  • js/script-tests/date-negative-setmonth.js: Removed.
  • js/script-tests/date-preserve-milliseconds.js: Removed.
  • js/script-tests/delete-syntax.js: Removed.
  • js/script-tests/dfg-byte-array-put.js: Removed.
  • js/script-tests/dfg-byteOffset-neuter.js: Removed.
  • js/script-tests/dfg-compare-final-object-to-final-object-or-other.js: Removed.
  • js/script-tests/dfg-cross-global-object-inline-new-array-literal-with-variables.js: Removed.
  • js/script-tests/dfg-cross-global-object-inline-new-array-literal.js: Removed.
  • js/script-tests/dfg-cross-global-object-inline-new-array-with-elements.js: Removed.
  • js/script-tests/dfg-cross-global-object-inline-new-array-with-size.js: Removed.
  • js/script-tests/dfg-cross-global-object-inline-new-array.js: Removed.
  • js/script-tests/dfg-cross-global-object-new-array.js: Removed.
  • js/script-tests/dfg-custom-getter-throw-inlined.js: Removed.
  • js/script-tests/dfg-custom-getter-throw.js: Removed.
  • js/script-tests/dfg-custom-getter.js: Removed.
  • js/script-tests/dfg-ensure-array-storage-on-window.js: Removed.
  • js/script-tests/dfg-ensure-non-array-array-storage-on-window.js: Removed.
  • js/script-tests/dfg-inline-switch-imm.js: Removed.
  • js/script-tests/dfg-int32-to-double-on-set-local-and-exit.js: Removed.
  • js/script-tests/dfg-int32-to-double-on-set-local-and-sometimes-exit.js: Removed.
  • js/script-tests/dfg-logical-not-final-object-or-other.js: Removed.
  • js/script-tests/dfg-make-rope-side-effects.js: Removed.
  • js/script-tests/dfg-negative-array-size.js: Removed.
  • js/script-tests/dfg-patchable-get-by-id-after-watchpoint.js: Removed.
  • js/script-tests/dfg-peephole-compare-final-object-to-final-object-or-other-when-both-proven-final-object.js: Removed.
  • js/script-tests/dfg-peephole-compare-final-object-to-final-object-or-other-when-proven-final-object.js: Removed.
  • js/script-tests/dfg-peephole-compare-final-object-to-final-object-or-other.js: Removed.
  • js/script-tests/dfg-proto-stub-watchpoint-fire.js: Removed.
  • js/script-tests/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.js: Removed.
  • js/script-tests/dfg-put-by-id-allocate-storage-polymorphic.js: Removed.
  • js/script-tests/dfg-put-by-id-allocate-storage.js: Removed.
  • js/script-tests/dfg-put-by-id-reallocate-storage-polymorphic.js: Removed.
  • js/script-tests/dfg-put-by-id-reallocate-storage.js: Removed.
  • js/script-tests/dfg-put-by-val-setter-then-get-by-val.js: Removed.
  • js/script-tests/dfg-put-to-readonly-property.js: Removed.
  • js/script-tests/dfg-rshift-by-zero-eliminate-valuetoint32.js: Removed.
  • js/script-tests/dfg-store-unexpected-value-into-argument-and-osr-exit.js: Removed.
  • js/script-tests/dfg-strcat-over-objects-then-exit-on-it.js: Removed.
  • js/script-tests/dfg-strict-mode-arguments-get-beyond-length.js: Removed.
  • js/script-tests/dfg-typed-array-neuter.js: Removed.
  • js/script-tests/document-all-triggers-masquerades-watchpoint.js: Removed.
  • js/script-tests/dot-node-base-exception.js: Removed.
  • js/script-tests/end-in-string-escape.js: Removed.
  • js/script-tests/enter-dictionary-indexing-mode-with-blank-indexing-type.js: Removed.
  • js/script-tests/eval-cache-scoped-lookup.js: Removed.
  • js/script-tests/eval-contained-syntax-error.js: Removed.
  • js/script-tests/exception-line-number.js: Removed.
  • js/script-tests/exception-registerfile-shrink.js: Removed.
  • js/script-tests/function-bind.js: Removed.
  • js/script-tests/function-name.js: Removed.
  • js/script-tests/function-names.js: Removed.
  • js/script-tests/get-by-pname-only-prototype-properties.js: Removed.
  • js/script-tests/global-constructors-attributes.js: Removed.
  • js/script-tests/global-constructors-deletable.js: Removed.
  • js/script-tests/global-function-resolve.js: Removed.
  • js/script-tests/immediate-constant-instead-of-cell.js: Removed.
  • js/script-tests/implicit-call-with-global-reentry.js: Removed.
  • js/script-tests/imul.js: Removed.
  • js/script-tests/inc-bracket-assign-subscript.js: Removed.
  • js/script-tests/inc-const-valueOf.js: Removed.
  • js/script-tests/indexed-setter-on-global-object.js: Removed.
  • js/script-tests/inline-arguments-tear-off.js: Removed.
  • js/script-tests/instanceof-XMLHttpRequest.js: Removed.
  • js/script-tests/jit-set-profiling-access-type-only-for-get-by-id-self.js: Removed.
  • js/script-tests/js-correct-exception-handler.js: Removed.
  • js/script-tests/lastModified.js: Removed.
  • js/script-tests/lazy-create-arguments-from-get-by-val.js: Removed.
  • js/script-tests/line-column-numbers.js: Removed.
  • js/script-tests/method-check.js: Removed.
  • js/script-tests/native-error-prototype.js: Removed.
  • js/script-tests/neq-null-crash.js: Removed.
  • js/script-tests/nested-object-gc.js: Removed.
  • js/script-tests/non-object-proto.js: Removed.
  • js/script-tests/normal-character-escapes-in-string-literals.js: Removed.
  • js/script-tests/null-char-in-string.js: Removed.
  • js/script-tests/number-tofixed.js: Removed.
  • js/script-tests/number-toprecision.js: Removed.
  • js/script-tests/object-extra-comma.js: Removed.
  • js/script-tests/object-prototype-constructor.js: Removed.
  • js/script-tests/object-prototype-properties.js: Removed.
  • js/script-tests/object-prototype-toLocaleString.js: Removed.
  • js/script-tests/post-inc-assign-overwrites.js: Removed.
  • js/script-tests/post-message-numeric-property.js: Removed.
  • js/script-tests/postfix-syntax.js: Removed.
  • js/script-tests/prefix-syntax.js: Removed.
  • js/script-tests/prototype-chain-caching-with-impure-get-own-property-slot-traps.js: Removed.
  • js/script-tests/put-direct-index-beyond-vector-length-resize.js: Removed.
  • js/script-tests/put-to-base-global-checked.js: Removed.
  • js/script-tests/random-array-gc-stress.js: Removed.
  • js/script-tests/recursion-limit-equal.js: Removed.
  • js/script-tests/regexp-bol-with-multiline.js: Removed.
  • js/script-tests/regexp-bol.js: Removed.
  • js/script-tests/regexp-extended-characters-crash.js: Removed.
  • js/script-tests/regexp-lastindex.js: Removed.
  • js/script-tests/regexp-look-ahead-empty.js: Removed.
  • js/script-tests/regexp-look-ahead.js: Removed.
  • js/script-tests/regexp-match-reify-before-putbyval.js: Removed.
  • js/script-tests/regexp-non-capturing-groups.js: Removed.
  • js/script-tests/regexp-non-greedy-parentheses.js: Removed.
  • js/script-tests/regexp-overflow.js: Removed.
  • js/script-tests/regexp-range-out-of-order.js: Removed.
  • js/script-tests/regexp-ranges-and-escaped-hyphens.js: Removed.
  • js/script-tests/regexp-stack-overflow.js: Removed.
  • js/script-tests/regexp-unicode-handling.js: Removed.
  • js/script-tests/regexp-unicode-overflow.js: Removed.
  • js/script-tests/removing-Cf-characters.js: Removed.
  • js/script-tests/reserved-words-as-property.js: Removed.
  • js/script-tests/select-options-add.js: Removed.
  • js/script-tests/stack-at-creation-for-error-objects.js: Removed.
  • js/script-tests/stack-trace.js: Removed.
  • js/script-tests/strict-readonly-statics.js: Removed.
  • js/script-tests/string-match.js: Removed.
  • js/script-tests/string-prototype-properties.js: Removed.
  • js/script-tests/string-replace-2.js: Removed.
  • js/script-tests/string-replace-3.js: Removed.
  • js/script-tests/string-replacement-outofmemory.js: Removed.
  • js/script-tests/string-split-conformance.js: Removed.
  • js/script-tests/string-split-double-empty.js: Removed.
  • js/script-tests/string-split-ignore-case.js: Removed.
  • js/script-tests/switch-behaviour.js: Removed.
  • js/script-tests/throw-exception-in-global-setter.js: Removed.
  • js/script-tests/toInt32UInt32.js: Removed.
  • js/script-tests/toString-exception.js: Removed.
  • js/script-tests/toString-overrides.js: Removed.
  • js/script-tests/toString-stack-overflow.js: Removed.
  • js/script-tests/transition-cache-dictionary-crash.js: Removed.
  • js/script-tests/typed-array-access.js: Removed.
  • js/script-tests/typed-array-set-different-types.js: Removed.
  • js/script-tests/typeof-syntax.js: Removed.
  • js/script-tests/unshift-multi.js: Removed.
  • js/script-tests/vardecl-preserve-arguments.js: Removed.
  • js/script-tests/webcore-string-comparison.js: Removed.
  • js/script-tests/with-scope-gc.js: Removed.
  • js/select-options-add-expected.txt: Removed.
  • js/select-options-add.html: Removed.
  • js/select-options-remove-expected.txt: Removed.
  • js/select-options-remove-gc-expected.txt: Removed.
  • js/select-options-remove-gc.html: Removed.
  • js/select-options-remove.html: Removed.
  • js/stack-at-creation-for-error-objects-expected.txt: Removed.
  • js/stack-at-creation-for-error-objects.html: Removed.
  • js/stack-trace-expected.txt: Removed.
  • js/stack-trace.html: Removed.
  • js/strict-readonly-statics-expected.txt: Removed.
  • js/strict-readonly-statics.html: Removed.
  • js/string-anchor-expected.txt: Removed.
  • js/string-anchor.html: Removed.
  • js/string-concatenate-outofmemory-expected.txt: Removed.
  • js/string-fontcolor-expected.txt: Removed.
  • js/string-fontcolor.html: Removed.
  • js/string-fontsize-expected.txt: Removed.
  • js/string-fontsize.html: Removed.
  • js/string-link-expected.txt: Removed.
  • js/string-link.html: Removed.
  • js/string-match-expected.txt: Removed.
  • js/string-match.html: Removed.
  • js/string-prototype-properties-expected.txt: Removed.
  • js/string-prototype-properties.html: Removed.
  • js/string-replace-2-expected.txt: Removed.
  • js/string-replace-2.html: Removed.
  • js/string-replace-3-expected.txt: Removed.
  • js/string-replace-3.html: Removed.
  • js/string-replace-exception-crash-expected.txt: Removed.
  • js/string-replace-exception-crash.html: Removed.
  • js/string-replacement-outofmemory-expected.txt: Removed.
  • js/string-replacement-outofmemory.html: Removed.
  • js/string-split-conformance-expected.txt: Removed.
  • js/string-split-conformance.html: Removed.
  • js/string-split-double-empty-expected.txt: Removed.
  • js/string-split-double-empty.html: Removed.
  • js/string-split-ignore-case-expected.txt: Removed.
  • js/string-split-ignore-case.html: Removed.
  • js/switch-behaviour-expected.txt: Removed.
  • js/switch-behaviour.html: Removed.
  • js/text-field-resize-expected.txt: Removed.
  • js/text-field-resize.html: Removed.
  • js/throw-exception-in-global-setter-expected.txt: Removed.
  • js/throw-exception-in-global-setter.html: Removed.
  • js/throw-from-array-sort-expected.txt: Removed.
  • js/throw-from-array-sort.html: Removed.
  • js/toInt32UInt32-expected.txt: Removed.
  • js/toInt32UInt32.html: Removed.
  • js/toString-and-valueOf-override-expected.txt: Removed.
  • js/toString-and-valueOf-override.html: Removed.
  • js/toString-dontEnum-expected.txt: Removed.
  • js/toString-dontEnum.html: Removed.
  • js/toString-exception-expected.txt: Removed.
  • js/toString-exception.html: Removed.
  • js/toString-number-expected.txt: Removed.
  • js/toString-number.html: Removed.
  • js/toString-overrides-expected.txt: Removed.
  • js/toString-overrides.html: Removed.
  • js/toString-stack-overflow-expected.txt: Removed.
  • js/toString-stack-overflow.html: Removed.
  • js/toString-try-else-expected.txt: Removed.
  • js/toString-try-else.html: Removed.
  • js/transition-cache-dictionary-crash-expected.txt: Removed.
  • js/transition-cache-dictionary-crash.html: Removed.
  • js/trivial-functions-expected.txt: Removed.
  • js/trivial-functions.html: Removed.
  • js/try-catch-crash-expected.txt: Removed.
  • js/try-catch-crash.html: Removed.
  • js/typed-array-access-expected.txt: Removed.
  • js/typed-array-access.html: Removed.
  • js/typed-array-set-different-types-expected.txt: Removed.
  • js/typed-array-set-different-types.html: Removed.
  • js/typeof-syntax-expected.txt: Removed.
  • js/typeof-syntax.html: Removed.
  • js/uncaught-exception-line-number-expected.txt: Removed.
  • js/uncaught-exception-line-number.html: Removed.
  • js/unshift-multi-expected.txt: Removed.
  • js/unshift-multi.html: Removed.
  • js/var-declarations-expected.txt: Removed.
  • js/var-declarations-shadowing-expected.txt: Removed.
  • js/var-declarations-shadowing.html: Removed.
  • js/var-declarations.html: Removed.
  • js/vardecl-preserve-arguments-expected.txt: Removed.
  • js/vardecl-preserve-arguments.html: Removed.
  • js/vardecl-preserve-parameters-expected.txt: Removed.
  • js/vardecl-preserve-parameters.html: Removed.
  • js/vardecl-preserve-vardecl-expected.txt: Removed.
  • js/vardecl-preserve-vardecl.html: Removed.
  • js/webcore-string-comparison-expected.txt: Removed.
  • js/webcore-string-comparison.html: Removed.
  • js/webidl-type-mapping-expected.txt: Removed.
  • js/webidl-type-mapping.html: Removed.
  • js/while-expression-value-expected.txt: Removed.
  • js/while-expression-value.html: Removed.
  • js/window-location-href-file-urls-expected.txt: Removed.
  • js/window-location-href-file-urls.html: Removed.
  • js/with-scope-gc-expected.txt: Removed.
  • js/with-scope-gc.html: Removed.
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/mac/js/constructor-length-expected.txt: Removed.
  • platform/mac/js/dom: Added.
  • platform/mac/js/dom/constructor-length-expected.txt: Copied from LayoutTests/platform/mac/js/constructor-length-expected.txt.
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
3:17 PM Changeset in webkit [156065] by fpizlo@apple.com
  • 2 edits in trunk/Tools

Unreviewed, fix for Ruby 1.8.

  • Scripts/run-jsc-stress-tests:
3:09 PM Changeset in webkit [156064] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Give 'jsc' commandline an option to disable deleting the VM.

Reviewed by Mark Hahnenberg.

  • jsc.cpp:

(jscmain):

  • runtime/Options.h:
2:45 PM Changeset in webkit [156063] by weinig@apple.com
  • 12 edits in trunk/Source

Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in WebKit and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121568

Reviewed by Andreas Kling.

../WebKit/win:

  • WebHistory.cpp:

(WebHistory::removeAllItems):
(WebHistory::orderedLastVisitedDays):
(WebHistory::addItemToDateCaches):
(WebHistory::removeItemFromDateCaches):

  • WebHistory.h:
  • WebPreferences.cpp:

(WebPreferences::copyWebKitPreferencesToCFPreferences):

../WebKit2:

  • Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::Connection::processMessage):
(CoreIPC::readBytesFromSocket):
(CoreIPC::Connection::sendOutgoingMessage):

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::feedTouchEvent):
(EwkView::feedTouchEvents):

  • UIProcess/API/efl/SnapshotImageGL.h:
  • UIProcess/API/efl/ewk_file_chooser_request.cpp:

(ewk_file_chooser_request_files_choose):

  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::createArgsArray):
(WebKit::ProcessLauncher::launchProcess):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCopyContextMenuItems):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:
2:38 PM Changeset in webkit [156062] by fpizlo@apple.com
  • 2 edits in trunk/Tools

run-jsc-stress-tests should make it easier to look at error spew from tests
https://bugs.webkit.org/show_bug.cgi?id=121531

Reviewed by Mark Hahnenberg.

This makes two changes:

  • The out/err spew from each test is now saved to a .out file in jsc-stress-results.


  • The same spew also goes to the console but is prefixed by the test's name.


This required some tee and awk hacks, and then some sh hacks to work around the fact

that if you do "(foo | bar)
baz", and foo fails, then baz won't run - the

operator will only see a failure of bar failed. So to pass output to tee and awk, I
needed to do weird things.

  • Scripts/run-jsc-stress-tests:
2:12 PM Changeset in webkit [156061] by rniwa@webkit.org
  • 7 edits in trunk/LayoutTests

Fix svg/masking/* tests
https://bugs.webkit.org/show_bug.cgi?id=121570

Reviewed by Rob Buis.

Merge https://chromium.googlesource.com/chromium/blink/+/975b3219677968706cbddb9295ceada05c092dd6

"rx" is not a valid <circle> attribute - these tests were not drawing anything.
Also switching to rects to avoid reftest antialiasing issues.
For non-alpha variants, using a 50% luminance to capture the effect on the output color.

  • svg/masking/mask-type-alpha-expected.svg:
  • svg/masking/mask-type-alpha.svg:
  • svg/masking/mask-type-luminance-expected.svg:
  • svg/masking/mask-type-luminance.svg:
  • svg/masking/mask-type-not-set-expected.svg:
  • svg/masking/mask-type-not-set.svg:
2:08 PM Changeset in webkit [156060] by Brent Fulgham
  • 2 edits in trunk/WebKitLibraries

[Windows] Unreviewed build fix: Expose PlatformArchitecture macro to build system.

  • win/tools/vsprops/common.props:
1:45 PM Changeset in webkit [156059] by Brent Fulgham
  • 3 edits in trunk/Source/WTF

[Windows] Unreviewed build correction.

  • WTF.vcxproj/WTFGeneratedCommon.props: Export PLATFORMARCHITECTURE macro for use in

Makefiles and shell scripts.

  • WTF.vcxproj/build-generated-files.sh: Output header search path to identify when the build

is confused about build architecture.

1:33 PM Changeset in webkit [156058] by jer.noble@apple.com
  • 5 edits in trunk

[MSE] Throw exception when setting timestampOffset while 'updating' state is set.
https://bugs.webkit.org/show_bug.cgi?id=121561

Reviewed by Eric Carlson.

Source/WebCore:

Tests: Updated http/tests/media/media-source/mediasource-append-buffer.html.

Merge https://chromium.googlesource.com/chromium/blink/+/25285998be3d0edcd951d12d445a7375e50e512c
by Changbin Shao.

The Media Source Extensions spec requires that an exception be thrown if the 'updating' attribute
equals true while setting the timestampOffset of a SourceBuffer.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::setTimestampOffset):

LayoutTests:

  • http/tests/media/media-source/mediasource-append-buffer-expected.txt:
  • http/tests/media/media-source/mediasource-append-buffer.html:
1:31 PM Changeset in webkit [156057] by ap@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r129451): run-safari --no-saved-state is broken
https://bugs.webkit.org/show_bug.cgi?id=121566

Reviewed by Mark Rowe.

  • Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp):

Check arguments, not the newly created empty array. Pass a value that silences warnings.
While at it, removed a check for Snow Leopard.

12:51 PM Changeset in webkit [156056] by andersca@apple.com
  • 12 edits in trunk/Source

RefPtrHashMap should work with move only types
https://bugs.webkit.org/show_bug.cgi?id=121564

Reviewed by Andreas Kling.

Source/JavaScriptCore:

  • runtime/VM.cpp:

(JSC::VM::addSourceProviderCache):

Source/WebCore:

  • bridge/IdentifierRep.cpp:

(WebCore::IdentifierRep::get):

  • page/PageGroup.cpp:

(WebCore::PageGroup::transientLocalStorage):

Source/WebKit/mac:

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::methodNamed):
(WebKit::ProxyInstance::fieldNamed):

Source/WebKit2:

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::LocalStorageNamespace::getOrCreateStorageArea):
(WebKit::StorageManager::SessionStorageNamespace::getOrCreateStorageArea):

  • WebProcess/Storage/StorageNamespaceImpl.cpp:

(WebKit::StorageNamespaceImpl::storageArea):

Source/WTF:

Add the same rvalue references and std::forward calls that already exist in HashMap.

  • wtf/RefPtrHashMap.h:
12:13 PM Changeset in webkit [156055] by enrica@apple.com
  • 3 edits in trunk/Source/WebCore

Upstream changes to WebHTMLConverter to support HTML
to NSAttributedString conversion on both iOS and OS X.

Reviewed by Benjamin Poulain.

This is a new submission of r156001 with the fix for the
failing TestWebKitAPI test. The additional change has been
reviewed by Tim Horton.

  • platform/mac/HTMLConverter.h:
  • platform/mac/HTMLConverter.mm:

(WebDefaultFont):
(_fontForNameAndSize):
(+[WebHTMLConverter defaultParagraphStyle]):
(-[WebHTMLConverter _computedStyleForElement:]):
(-[WebHTMLConverter _specifiedStyleForElement:]):
(-[WebHTMLConverter _computedStringForNode:property:]):
(-[WebHTMLConverter _stringForNode:property:]):
(-[WebHTMLConverter _getComputedFloat:forNode:property:]):
(-[WebHTMLConverter _getFloat:forNode:property:]):
(_NSFirstPathForDirectoriesInDomains):
(_NSSystemLibraryPath):
(-[WebHTMLConverter _webKitBundle]):
(_colorForRGBColor):
(_shadowForShadowStyle):
(-[WebHTMLConverter _elementIsBlockLevel:]):
(-[WebHTMLConverter _elementHasOwnBackgroundColor:]):
(-[WebHTMLConverter _computedColorForNode:property:]):
(-[WebHTMLConverter _colorForNode:property:]):
(-[WebHTMLConverter _computedAttributesForElement:]):
(-[WebHTMLConverter _attributesForElement:]):
(-[WebHTMLConverter _newParagraphForElement:tag:allowEmpty:suppressTrailingSpace:]):
(-[WebHTMLConverter _newLineForElement:]):
(-[WebHTMLConverter _newTabForElement:]):
(-[WebHTMLConverter _WebMessageDocumentClass]):
(-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
(-[WebHTMLConverter _addQuoteForElement:opening:level:]):
(-[WebHTMLConverter _addValue:forElement:]):
(-[WebHTMLConverter _fillInBlock:forElement:backgroundColor:extraMargin:extraPadding:isTable:]):
(_dateForString):
(_colCompare):
(-[WebHTMLConverter _processMetaElementWithName:content:]):
(-[WebHTMLConverter _processHeadElement:]):
(-[WebHTMLConverter _enterElement:tag:display:embedded:]):
(-[WebHTMLConverter _addTableForElement:]):
(-[WebHTMLConverter _addTableCellForElement:]):
(-[WebHTMLConverter _processElement:tag:display:depth:]):
(-[WebHTMLConverter _addMarkersToList:range:]):
(-[WebHTMLConverter _exitElement:tag:display:depth:startIndex:]):
(-[WebHTMLConverter _processText:]):
(-[WebHTMLConverter _traverseNode:depth:embedded:]):
(-[WebHTMLConverter _traverseFooterNode:depth:]):
(-[WebHTMLConverter _loadFromDOMRange]):
(-[WebHTMLConverter dealloc]):
(-[WebHTMLConverter init]):
(-[WebHTMLConverter initWithDOMRange:]):
(-[WebHTMLConverter attributedString]):
(+[WebHTMLConverter editingAttributedStringFromRange:]):

11:04 AM Changeset in webkit [156054] by Antti Koivisto
  • 18 edits
    2 moves in trunk/Source/WebCore

Rename RenderBR to RenderLineBreak
https://bugs.webkit.org/show_bug.cgi?id=121560

Reviewed by Sam Weinig.

It now represents both hard (br) and soft (wbr) line breaks.

10:58 AM Changeset in webkit [156053] by robert@webkit.org
  • 3 edits
    2 adds in trunk

Quirksmode: Break Tag Extra Space Bug
https://bugs.webkit.org/show_bug.cgi?id=11943

Reviewed by David Hyatt.

Source/WebCore:

Collapse away all space between text and a hard line-break when in a right-aligned
container so that the trailing space doesn't push the text away from the container edge.

Test: fast/text/whitespace/trailing-space-before-br-in-right-aligned-text.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

  • fast/text/whitespace/trailing-space-before-br-in-right-aligned-text-expected.html: Added.
  • fast/text/whitespace/trailing-space-before-br-in-right-aligned-text.html: Added.
10:45 AM Changeset in webkit [156052] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for Qt (and other) ports after 156049.

Wrap implementation of PublicURLManager in ENABLE(BLOB) check.

  • html/PublicURLManager.cpp:
10:32 AM Changeset in webkit [156051] by Patrick Gansterer
  • 3 edits in trunk/Source/WebKit/win

Make WebHistory more type safe
https://bugs.webkit.org/show_bug.cgi?id=119389

Reviewed by Brent Fulgham.

Use a WTF::HashMap instead of a CFMutableDictionary to avoid
casting from void* all the time when accessing the entries.
This reduces the dependencies on CoreFoundation too.

  • WebHistory.cpp:

(WebHistory::WebHistory):
(WebHistory::removeAllItems):
(WebHistory::allItems):
(WebHistory::removeItem):
(WebHistory::addItem):
(WebHistory::visitedURL):
(WebHistory::itemForURL):
(WebHistory::removeItemForURLString):
(WebHistory::itemForURLString):
(WebHistory::addVisitedLinksToPageGroup):

  • WebHistory.h:
10:27 AM Changeset in webkit [156050] by mhahnenberg@apple.com
  • 11 edits
    1 add in trunk/Source/JavaScriptCore

Rename OperationInProgress to HeapOperation and move it out of Heap.h into its own header
https://bugs.webkit.org/show_bug.cgi?id=121534

Reviewed by Geoffrey Garen.

OperationInProgress is a silly name.

Many parts of the Heap would like to know what HeapOperation is currently underway, but
since they are included in Heap.h they can't directly reference HeapOperation if it also
lives in Heap.h. The simplest thing to do is to give HeapOperation its own header. While
a bit overkill, it simplifies including it wherever its needed.

(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC::CodeBlock::updateAllValueProfilePredictions):
(JSC::CodeBlock::updateAllPredictions):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::updateAllValueProfilePredictions):
(JSC::CodeBlock::updateAllPredictions):

  • bytecode/LazyOperandValueProfile.cpp:

(JSC::CompressedLazyOperandValueProfileHolder::computeUpdatedPredictions):

  • bytecode/LazyOperandValueProfile.h:
  • bytecode/ValueProfile.h:

(JSC::ValueProfileBase::computeUpdatedPrediction):

  • heap/Heap.h:
  • heap/HeapOperation.h: Added.
10:25 AM Changeset in webkit [156049] by jer.noble@apple.com
  • 43 edits
    20 copies
    69 adds in trunk

Merge blink MediaSource changes since fork.
https://bugs.webkit.org/show_bug.cgi?id=118752

Rubber-stamped by Eric Carlson.

Source/WebCore:

Tests: http/tests/media/media-source/mediasource-addsourcebuffer.html

http/tests/media/media-source/mediasource-append-buffer.html
http/tests/media/media-source/mediasource-buffered.html
http/tests/media/media-source/mediasource-closed.html
http/tests/media/media-source/mediasource-config-change-mp4-a-bitrate.html
http/tests/media/media-source/mediasource-config-change-mp4-av-audio-bitrate.html
http/tests/media/media-source/mediasource-config-change-mp4-av-framesize.html
http/tests/media/media-source/mediasource-config-change-mp4-av-video-bitrate.html
http/tests/media/media-source/mediasource-config-change-mp4-v-bitrate.html
http/tests/media/media-source/mediasource-config-change-mp4-v-framerate.html
http/tests/media/media-source/mediasource-config-change-mp4-v-framesize.html
http/tests/media/media-source/mediasource-config-change-webm-a-bitrate.html
http/tests/media/media-source/mediasource-config-change-webm-av-audio-bitrate.html
http/tests/media/media-source/mediasource-config-change-webm-av-framesize.html
http/tests/media/media-source/mediasource-config-change-webm-av-video-bitrate.html
http/tests/media/media-source/mediasource-config-change-webm-v-bitrate.html
http/tests/media/media-source/mediasource-config-change-webm-v-framerate.html
http/tests/media/media-source/mediasource-config-change-webm-v-framesize.html
http/tests/media/media-source/mediasource-is-type-supported.html
http/tests/media/media-source/mediasource-multiple-attach.html
http/tests/media/media-source/mediasource-play.html
http/tests/media/media-source/mediasource-sourcebufferlist.html

Add files to project. Fix compile errors exposed by enabling.

  • WebCore.xcodeproj/project.pbxproj:
  • Modules/mediasource/MediaSourceRegistry.cpp:

(WebCore::MediaSourceRegistry::lookupMediaSource):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(WebCore::MediaPlayerPrivateAVFoundation::load):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:

(WebCore::MediaPlayerPrivateQTKit::load):

  • platform/mac/MIMETypeRegistryMac.mm:

(WebCore::MIMETypeRegistry::isSupportedMediaSourceMIMEType):

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:

Merge
https://chromium.googlesource.com/chromium/blink/+/c38e2955db98a300a535b692869fea0e41501497
https://chromium.googlesource.com/chromium/blink/+/8568015e9bee1de7fccee28163f9e4a4b51f9baf
https://chromium.googlesource.com/chromium/blink/+/14417e8fa6294f4e7dbc1e0fac549398522b2f97
https://chromium.googlesource.com/chromium/blink/+/f43a5496f233102f8861a067a9cf8053c010d401
https://chromium.googlesource.com/chromium/blink/+/57771439806f7c6e6a272efb1ea72900f5f6a015
https://chromium.googlesource.com/chromium/blink/+/8c77a790a9d225194db0a8832399d0f9e1fa54ec
https://chromium.googlesource.com/chromium/blink/+/d33ae3fa7a8592e946503ed17f862a27c6d9dde1
https://chromium.googlesource.com/chromium/blink/+/1caaa9c51f06e1b9341d58c994f77fd59fcd236d
https://chromium.googlesource.com/chromium/blink/+/e95720393b0ebe67f19de39bb77cdf2926165512
https://chromium.googlesource.com/chromium/blink/+/bad2c1b4b70faec731b2ad3cc8a4ccf28de6cc38
https://chromium.googlesource.com/chromium/blink/+/a7873430c3d5c9373336c6f3993db3cb4228e9cd
https://chromium.googlesource.com/chromium/blink/+/508966d5e32360b3cec058f9fbae0014542fbc52
https://chromium.googlesource.com/chromium/blink/+/371dfe72f61ce6f73e6c242324da73c415d38be3

LayoutTests:

  • http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt: Added.
  • http/tests/media/media-source/mediasource-addsourcebuffer.html: Added.
  • http/tests/media/media-source/mediasource-append-buffer-expected.txt: Added.
  • http/tests/media/media-source/mediasource-append-buffer.html: Added.
  • http/tests/media/media-source/mediasource-buffered-expected.txt: Added.
  • http/tests/media/media-source/mediasource-buffered.html: Added.
  • http/tests/media/media-source/mediasource-closed-expected.txt: Added.
  • http/tests/media/media-source/mediasource-closed.html: Added.
  • http/tests/media/media-source/mediasource-config-change-mp4-a-bitrate-expected.txt: Added.
  • http/tests/media/media-source/mediasource-config-change-mp4-a-bitrate.html: Added.
  • http/tests/media/media-source/mediasource-config-change-mp4-av-audio-bitrate-expected.txt: Added.
  • http/tests/media/media-source/mediasource-config-change-mp4-av-audio-bitrate.html: Added.
  • http/tests/media/media-source/mediasource-config-change-mp4-av-framesize-expected.txt: Added.
  • http/tests/media/media-source/mediasource-config-change-mp4-av-framesize.html: Added.
  • http/tests/media/media-source/mediasource-config-change-mp4-av-video-bitrate-expected.txt: Added.
  • http/tests/media/media-source/mediasource-config-change-mp4-av-video-bitrate.html: Added.
  • http/tests/media/media-source/mediasource-config-change-mp4-v-bitrate-expected.txt: Added.
  • http/tests/media/media-source/mediasource-config-change-mp4-v-bitrate.html: Added.
  • http/tests/media/media-source/mediasource-config-change-mp4-v-framerate-expected.txt: Added.
  • http/tests/media/media-source/mediasource-config-change-mp4-v-framerate.html: Added.
  • http/tests/media/media-source/mediasource-config-change-mp4-v-framesize-expected.txt: Added.
  • http/tests/media/media-source/mediasource-config-change-mp4-v-framesize.html: Added.
  • http/tests/media/media-source/mediasource-config-change-webm-a-bitrate-expected.txt: Added.
  • http/tests/media/media-source/mediasource-config-change-webm-a-bitrate.html: Added.
  • http/tests/media/media-source/mediasource-config-change-webm-av-audio-bitrate-expected.txt: Added.
  • http/tests/media/media-source/mediasource-config-change-webm-av-audio-bitrate.html: Added.
  • http/tests/media/media-source/mediasource-config-change-webm-av-framesize-expected.txt: Added.
  • http/tests/media/media-source/mediasource-config-change-webm-av-framesize.html: Added.
  • http/tests/media/media-source/mediasource-config-change-webm-av-video-bitrate-expected.txt: Added.
  • http/tests/media/media-source/mediasource-config-change-webm-av-video-bitrate.html: Added.
  • http/tests/media/media-source/mediasource-config-change-webm-v-bitrate-expected.txt: Added.
  • http/tests/media/media-source/mediasource-config-change-webm-v-bitrate.html: Added.
  • http/tests/media/media-source/mediasource-config-change-webm-v-framerate-expected.txt: Added.
  • http/tests/media/media-source/mediasource-config-change-webm-v-framerate.html: Added.
  • http/tests/media/media-source/mediasource-config-change-webm-v-framesize-expected.txt: Added.
  • http/tests/media/media-source/mediasource-config-change-webm-v-framesize.html: Added.
  • http/tests/media/media-source/mediasource-config-changes.js: Added.
  • http/tests/media/media-source/mediasource-is-type-supported-expected.txt: Added.
  • http/tests/media/media-source/mediasource-is-type-supported.html: Added.
  • http/tests/media/media-source/mediasource-multiple-attach-expected.txt: Added.
  • http/tests/media/media-source/mediasource-multiple-attach.html: Added.
  • http/tests/media/media-source/mediasource-play-expected.txt: Added.
  • http/tests/media/media-source/mediasource-play.html: Added.
  • http/tests/media/media-source/mediasource-sourcebufferlist-expected.txt: Added.
  • http/tests/media/media-source/mediasource-sourcebufferlist.html: Added.
  • http/tests/media/media-source/mediasource-util.js: Added.
  • http/tests/media/media-source/video-media-source-objects-expected.txt:
  • http/tests/media/resources/media-source/generate-config-change-tests.py: Added.
  • http/tests/media/resources/media-source/mp4/test-a-128k-44100Hz-1ch-manifest.json: Added.
  • http/tests/media/resources/media-source/mp4/test-a-192k-44100Hz-1ch-manifest.json: Added.
  • http/tests/media/resources/media-source/mp4/test-av-384k-44100Hz-1ch-320x240-30fps-10kfr-manifest.json: Added.
  • http/tests/media/resources/media-source/mp4/test-av-384k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
  • http/tests/media/resources/media-source/mp4/test-av-448k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
  • http/tests/media/resources/media-source/mp4/test-av-640k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
  • http/tests/media/resources/media-source/mp4/test-v-128k-320x240-24fps-8kfr-manifest.json: Added.
  • http/tests/media/resources/media-source/mp4/test-v-128k-320x240-30fps-10kfr-manifest.json: Added.
  • http/tests/media/resources/media-source/mp4/test-v-128k-640x480-30fps-10kfr-manifest.json: Added.
  • http/tests/media/resources/media-source/mp4/test-v-256k-320x240-30fps-10kfr-manifest.json: Added.
  • http/tests/media/resources/media-source/webm/test-a-128k-44100Hz-1ch-manifest.json: Added.
  • http/tests/media/resources/media-source/webm/test-a-192k-44100Hz-1ch-manifest.json: Added.
  • http/tests/media/resources/media-source/webm/test-av-384k-44100Hz-1ch-320x240-30fps-10kfr-manifest.json: Added.
  • http/tests/media/resources/media-source/webm/test-av-384k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
  • http/tests/media/resources/media-source/webm/test-av-448k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
  • http/tests/media/resources/media-source/webm/test-av-640k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
  • http/tests/media/resources/media-source/webm/test-v-128k-320x240-24fps-8kfr-manifest.json: Added.
  • http/tests/media/resources/media-source/webm/test-v-128k-320x240-30fps-10kfr-manifest.json: Added.
  • http/tests/media/resources/media-source/webm/test-v-128k-640x480-30fps-10kfr-manifest.json: Added.
  • http/tests/media/resources/media-source/webm/test-v-256k-320x240-30fps-10kfr-manifest.json: Added.
10:21 AM Changeset in webkit [156048] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Improved WinLauncher's URL handling.
https://bugs.webkit.org/show_bug.cgi?id=121535

Patch by Alex Christensen <achristensen@webkit.org> on 2013-09-18
Reviewed by Brent Fulgham.

  • WinLauncher/WinLauncher.cpp:

(EditProc):
Use INTERNET_MAX_URL_LENGTH instead of our MAX_URL_LENGTH.
(loadURL):
Prepend "http://" to URLs with no scheme.

10:14 AM Changeset in webkit [156047] by fpizlo@apple.com
  • 75 edits
    12 adds in trunk

DFG should support Int52 for local variables
https://bugs.webkit.org/show_bug.cgi?id=121064

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This adds Int52 support for local variables to the DFG and FTL. It's a speed-up on
programs that have local int32 overflows but where a larger int representation can
prevent us from having to convert all the way up to double.

It's a small speed-up for now. But we're just supporting Int52 for a handful of
operations (add, sub, mul, neg, compare, bitops, typed array access) and this lays
the groundwork for adding Int52 to JSValue, which will probably be a bigger
speed-up.

The basic approach is:

  • We have a notion of Int52 in our typesystem. Int52 doesn't belong to BytecodeTop or HeapTop - i.e. it doesn't arise from JSValues.


  • DFG treats Int52 as being part of its FullTop and will treat it as being a subtype of double unless instructed otherwise.


  • Prediction propagator creates Int52s whenever we have a node going doubly but due to large values rather than fractional values, and that node is known to be able to produce Int52 natively in the DFG backend.


  • Fixup phase converts edges to MachineIntUses in nodes that are known to be able to deal with Int52, and where we have a subtype of Int32|Int52 as the predicted input.


  • The DFG backend and FTL LLVM IR lowering have two notions of Int52s - ones that are left-shifted by 16 (great for overflow checks) and ones that are sign-extended. Both backends know how to convert between Int52s and the other representations.
  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::rshift64):
(JSC::MacroAssemblerX86_64::mul64):
(JSC::MacroAssemblerX86_64::branchMul64):
(JSC::MacroAssemblerX86_64::branchNeg64):
(JSC::MacroAssemblerX86_64::convertInt64ToDouble):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::imulq_rr):
(JSC::X86Assembler::cvtsi2sdq_rr):

  • bytecode/DataFormat.h:

(JSC::dataFormatToString):

  • bytecode/ExitKind.cpp:

(JSC::exitKindToString):

  • bytecode/ExitKind.h:
  • bytecode/OperandsInlines.h:

(JSC::::dumpInContext):

  • bytecode/SpeculatedType.cpp:

(JSC::dumpSpeculation):
(JSC::speculationToAbbreviatedString):
(JSC::speculationFromValue):

  • bytecode/SpeculatedType.h:

(JSC::isInt32SpeculationForArithmetic):
(JSC::isInt52Speculation):
(JSC::isMachineIntSpeculationForArithmetic):
(JSC::isInt52AsDoubleSpeculation):
(JSC::isBytecodeRealNumberSpeculation):
(JSC::isFullRealNumberSpeculation):
(JSC::isBytecodeNumberSpeculation):
(JSC::isFullNumberSpeculation):
(JSC::isBytecodeNumberSpeculationExpectingDefined):
(JSC::isFullNumberSpeculationExpectingDefined):

  • bytecode/ValueRecovery.h:

(JSC::ValueRecovery::alreadyInJSStackAsUnboxedInt52):
(JSC::ValueRecovery::inGPR):
(JSC::ValueRecovery::displacedInJSStack):
(JSC::ValueRecovery::isAlreadyInJSStack):
(JSC::ValueRecovery::gpr):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dumpInContext):

  • dfg/DFGAbstractInterpreter.h:

(JSC::DFG::AbstractInterpreter::needsTypeCheck):
(JSC::DFG::AbstractInterpreter::filterByType):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

  • dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::checkConsistency):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::couldBeType):
(JSC::DFG::AbstractValue::isType):
(JSC::DFG::AbstractValue::checkConsistency):
(JSC::DFG::AbstractValue::validateType):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::refine):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::boxInt52):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGCommon.h:

(JSC::DFG::enableInt52):

  • dfg/DFGDCEPhase.cpp:

(JSC::DFG::DCEPhase::fixupBlock):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
(JSC::DFG::FixupPhase::fixupUntypedSetLocalsInBlock):
(JSC::DFG::FixupPhase::observeUseKindOnNode):
(JSC::DFG::FixupPhase::fixEdge):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):
(JSC::DFG::FixupPhase::attemptToMakeIntegerAdd):

  • dfg/DFGFlushFormat.cpp:

(WTF::printInternal):

  • dfg/DFGFlushFormat.h:

(JSC::DFG::resultFor):
(JSC::DFG::useKindFor):

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::initInt52):
(JSC::DFG::GenerationInfo::initStrictInt52):
(JSC::DFG::GenerationInfo::isFormat):
(JSC::DFG::GenerationInfo::isInt52):
(JSC::DFG::GenerationInfo::isStrictInt52):
(JSC::DFG::GenerationInfo::fillInt52):
(JSC::DFG::GenerationInfo::fillStrictInt52):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::addShouldSpeculateMachineInt):
(JSC::DFG::Graph::mulShouldSpeculateMachineInt):
(JSC::DFG::Graph::negateShouldSpeculateMachineInt):

  • dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::mergeStateAtTail):

  • dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::reconstruct):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::noticeOSREntry):

  • dfg/DFGMinifiedNode.h:

(JSC::DFG::belongsInMinifiedGraph):
(JSC::DFG::MinifiedNode::hasChild):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateNumber):
(JSC::DFG::Node::shouldSpeculateNumberExpectingDefined):
(JSC::DFG::Node::canSpeculateInt52):

  • dfg/DFGNodeFlags.h:

(JSC::DFG::nodeCanSpeculateInt52):

  • dfg/DFGNodeType.h:

(JSC::DFG::permitsOSRBackwardRewiring):
(JSC::DFG::forwardRewiringSelectionScore):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOSREntry.h:
  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::speculatedDoubleTypeForPrediction):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doDoubleVoting):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()):
(JSC::DFG::safeToExecute):

  • dfg/DFGSilentRegisterSavePlan.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileDoublePutByVal):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileArithNegate):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::speculateMachineInt):
(JSC::DFG::SpeculativeJIT::speculateNumber):
(JSC::DFG::SpeculativeJIT::speculateRealNumber):
(JSC::DFG::SpeculativeJIT::speculate):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::isFilled):
(JSC::DFG::SpeculativeJIT::isFilledDouble):
(JSC::DFG::SpeculativeJIT::use):
(JSC::DFG::SpeculativeJIT::isKnownInteger):
(JSC::DFG::SpeculativeJIT::isKnownCell):
(JSC::DFG::SpeculativeJIT::isKnownNotNumber):
(JSC::DFG::SpeculativeJIT::int52Result):
(JSC::DFG::SpeculativeJIT::strictInt52Result):
(JSC::DFG::SpeculativeJIT::initConstantInfo):
(JSC::DFG::SpeculativeJIT::isInteger):
(JSC::DFG::SpeculativeJIT::betterUseStrictInt52):
(JSC::DFG::SpeculativeJIT::generationInfo):
(JSC::DFG::SpeculateInt52Operand::SpeculateInt52Operand):
(JSC::DFG::SpeculateInt52Operand::~SpeculateInt52Operand):
(JSC::DFG::SpeculateInt52Operand::edge):
(JSC::DFG::SpeculateInt52Operand::node):
(JSC::DFG::SpeculateInt52Operand::gpr):
(JSC::DFG::SpeculateInt52Operand::use):
(JSC::DFG::SpeculateStrictInt52Operand::SpeculateStrictInt52Operand):
(JSC::DFG::SpeculateStrictInt52Operand::~SpeculateStrictInt52Operand):
(JSC::DFG::SpeculateStrictInt52Operand::edge):
(JSC::DFG::SpeculateStrictInt52Operand::node):
(JSC::DFG::SpeculateStrictInt52Operand::gpr):
(JSC::DFG::SpeculateStrictInt52Operand::use):
(JSC::DFG::SpeculateWhicheverInt52Operand::SpeculateWhicheverInt52Operand):
(JSC::DFG::SpeculateWhicheverInt52Operand::~SpeculateWhicheverInt52Operand):
(JSC::DFG::SpeculateWhicheverInt52Operand::edge):
(JSC::DFG::SpeculateWhicheverInt52Operand::node):
(JSC::DFG::SpeculateWhicheverInt52Operand::gpr):
(JSC::DFG::SpeculateWhicheverInt52Operand::use):
(JSC::DFG::SpeculateWhicheverInt52Operand::format):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::boxInt52):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt52):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileInt52Compare):
(JSC::DFG::SpeculativeJIT::compilePeepHoleInt52Branch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGUseKind.cpp:

(WTF::printInternal):

  • dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):
(JSC::DFG::isNumerical):

  • dfg/DFGValueSource.cpp:

(JSC::DFG::ValueSource::dump):

  • dfg/DFGValueSource.h:

(JSC::DFG::dataFormatToValueSourceKind):
(JSC::DFG::valueSourceKindToDataFormat):
(JSC::DFG::ValueSource::forFlushFormat):
(JSC::DFG::ValueSource::valueRecovery):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
(JSC::DFG::VariableAccessData::flushFormat):

  • ftl/FTLCArgumentGetter.cpp:

(JSC::FTL::CArgumentGetter::loadNextAndBox):

  • ftl/FTLCArgumentGetter.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLExitValue.cpp:

(JSC::FTL::ExitValue::dumpInContext):

  • ftl/FTLExitValue.h:

(JSC::FTL::ExitValue::inJSStackAsInt52):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::createPhiVariables):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileUpsilon):
(JSC::FTL::LowerDFGToLLVM::compilePhi):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::compileAdd):
(JSC::FTL::LowerDFGToLLVM::compileArithSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareLess):
(JSC::FTL::LowerDFGToLLVM::compileCompareLessEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreater):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreaterEq):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowInt52):
(JSC::FTL::LowerDFGToLLVM::lowStrictInt52):
(JSC::FTL::LowerDFGToLLVM::betterUseStrictInt52):
(JSC::FTL::LowerDFGToLLVM::bestInt52Kind):
(JSC::FTL::LowerDFGToLLVM::opposite):
(JSC::FTL::LowerDFGToLLVM::lowWhicheverInt52):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::lowDouble):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
(JSC::FTL::LowerDFGToLLVM::strictInt52ToInt32):
(JSC::FTL::LowerDFGToLLVM::strictInt52ToDouble):
(JSC::FTL::LowerDFGToLLVM::strictInt52ToJSValue):
(JSC::FTL::LowerDFGToLLVM::setInt52WithStrictValue):
(JSC::FTL::LowerDFGToLLVM::strictInt52ToInt52):
(JSC::FTL::LowerDFGToLLVM::int52ToStrictInt52):
(JSC::FTL::LowerDFGToLLVM::speculateRealNumber):
(JSC::FTL::LowerDFGToLLVM::initializeOSRExitStateForBlock):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
(JSC::FTL::LowerDFGToLLVM::setInt52):
(JSC::FTL::LowerDFGToLLVM::setStrictInt52):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::addWithOverflow64):
(JSC::FTL::Output::subWithOverflow64):
(JSC::FTL::Output::mulWithOverflow64):

  • ftl/FTLValueFormat.cpp:

(WTF::printInternal):

  • ftl/FTLValueFormat.h:
  • ftl/FTLValueSource.cpp:

(JSC::FTL::ValueSource::dump):

  • ftl/FTLValueSource.h:
  • interpreter/Register.h:

(JSC::Register::unboxedInt52):

  • runtime/Arguments.cpp:

(JSC::Arguments::tearOffForInlineCallFrame):

  • runtime/IndexingType.cpp:

(JSC::leastUpperBoundOfIndexingTypeAndType):

  • runtime/JSCJSValue.h:
  • runtime/JSCJSValueInlines.h:

(JSC::JSValue::isMachineInt):
(JSC::JSValue::asMachineInt):

Source/WTF:

Reviewed by Oliver Hunt.

  • wtf/PrintStream.h:

(WTF::ValueIgnoringContext::ValueIgnoringContext):
(WTF::ValueIgnoringContext::dump):
(WTF::ignoringContext):

Tools:

Reviewed by Oliver Hunt.

  • Scripts/run-jsc-stress-tests:

LayoutTests:

Reviewed by Oliver Hunt.

  • js/dfg-int-overflow-large-constants-in-a-line-expected.txt:
  • js/regress/large-int-captured-expected.txt: Added.
  • js/regress/large-int-captured.html: Added.
  • js/regress/large-int-expected.txt: Added.
  • js/regress/large-int-neg-expected.txt: Added.
  • js/regress/large-int-neg.html: Added.
  • js/regress/large-int.html: Added.
  • js/regress/marsaglia-larger-ints-expected.txt: Added.
  • js/regress/marsaglia-larger-ints.html: Added.
  • js/regress/script-tests/large-int-captured.js: Added.

(.bar):
(foo):

  • js/regress/script-tests/large-int-neg.js: Added.

(foo):

  • js/regress/script-tests/large-int.js: Added.

(foo):

  • js/regress/script-tests/marsaglia-larger-ints.js: Added.

(uint):
(marsaglia):

  • js/script-tests/dfg-int-overflow-large-constants-in-a-line.js:
9:51 AM Changeset in webkit [156046] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r155771): js/stack-overflow-arrity-catch.html is crashing on non-Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=121376

Reviewed by Oliver Hunt.

Fix stack grow() call for stack growing down. This should catch running out of stack space before
we try to move the frame down due to arity mismatch.

  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):

9:33 AM Changeset in webkit [156045] by commit-queue@webkit.org
  • 4 edits in trunk

[Win] TestWebKitAPI does not compile.
https://bugs.webkit.org/show_bug.cgi?id=121485

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-09-18
Reviewed by Brent Fulgham.

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Export needed symbols.

Tools:

It is no longer possible to inherit from WebCore::BitmapImage, which the test relies on.
Instead, load a bitmap, then destroy the decoded data, which will cause WebCore::frameAtIndex()
to return null, which is the case we want to test.

  • TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:

(TestWebKitAPI::TEST):

9:27 AM Changeset in webkit [156044] by akling@apple.com
  • 2 edits in trunk/LayoutTests

Missed one rebaseline for the RenderMenuList change.

  • platform/mac/fast/forms/select-empty-option-height-expected.txt:
8:55 AM Changeset in webkit [156043] by akling@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

YARR: Put UCS2 canonicalization tables in read-only memory.
<https://webkit.org/b/121547>

Reviewed by Sam Weinig.

These tables never mutate so mark them const.

8:54 AM Changeset in webkit [156042] by akling@apple.com
  • 2 edits in trunk/Source/WTF

Put constant CachedPower table in read-only memory.
<https://webkit.org/b/121546>

Reviewed by Anders Carlsson.

  • wtf/dtoa/cached-powers.cc:
8:48 AM Changeset in webkit [156041] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

CTTE: RenderBR always has an HTMLElement.
<https://webkit.org/b/121557>

Reviewed by Antti Koivisto.

This renderer is never anonymous and always has a corresponding HTMLElement.
Tighten this up by making the constructor take a HTMLElement& and remove
RenderBR::createAnonymous().

8:35 AM Changeset in webkit [156040] by akling@apple.com
  • 12 edits in trunk

Avoid using RenderBR internally in RenderMenuList.
<https://webkit.org/b/121550>

Reviewed by Antti Koivisto.

Source/WebCore:

RenderMenuLists with an empty caption text were previously using a
RenderBR as placeholder.

Switch to using a \n RenderText instead so we can tighten RenderBR.

This will change DRT dumps but actual metrics should not change.

LayoutTests:

Update expected results for RenderMenuLists with empty text.
They now have a RenderText inside them instead of a RenderBR.

7:41 AM Changeset in webkit [156039] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore
Change one accidental "object->isText()
object->isLineBreak()" from previous patch back to "object->isTextOrLineBreak()"


Not reviewed.

  • rendering/InlineIterator.h:

(WebCore::isIteratorTarget):

7:33 AM Changeset in webkit [156038] by Antti Koivisto
  • 28 edits
    2 deletes in trunk/Source/WebCore

Remove RenderWordBreak
https://bugs.webkit.org/show_bug.cgi?id=121549

Reviewed by Andreas Kling.

Remove RenderWordBreak and make it a bit in RenderBR instead.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::updateHoverActiveState):

  • dom/Position.cpp:

(WebCore::hasInlineBoxWrapper):
(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):

  • editing/Editor.cpp:

(WebCore::findFirstMarkable):

  • editing/TextIterator.cpp:

(WebCore::ignoresContainerClip):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::createRenderer):

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::logicalHeight):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):
(WebCore::InlineBox::deleteLine):
(WebCore::InlineBox::extractLine):
(WebCore::InlineBox::attachLine):
(WebCore::InlineBox::nodeAtPoint):

  • rendering/InlineBox.h:

(WebCore::InlineBox::isLineBreak):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::computeOverflow):

  • rendering/InlineIterator.h:

(WebCore::InlineIterator::atTextParagraphSeparator):
(WebCore::isIteratorTarget):

  • rendering/RenderBR.cpp:

(WebCore::RenderBR::RenderBR):

  • rendering/RenderBR.h:

(WebCore::toRenderBR):

RenderBR now represents both hard and soft line breaks. It will be renamed to RenderLineBreak later.

  • rendering/RenderBlock.cpp:

(WebCore::InlineMinMaxIterator::next):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::createInlineBoxForRenderer):
(WebCore::dirtyLineBoxesForRenderer):
(WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlockFlow::layoutInlineChildren):
(WebCore::textBeginsWithBreakablePosition):
(WebCore::canBreakAtThisPosition):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::generateCulledLineBoxRects):
(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):
(WebCore::RenderInline::dirtyLineBoxes):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isLineBreak):

This bit covers both BR and WBR.

(WebCore::RenderObject::isBR):
(WebCore::RenderObject::isLineBreakOpportunity):

Rename isWordBreak to isLineBreakOpportunity. This matches HTML5 spec terminology.

(WebCore::RenderObject::isTextOrLineBreak):

Since WBR used to be Text we want this check to still cover it too. Renamed from isTextOrBR.

(WebCore::RenderObject::setIsLineBreak):
(WebCore::RenderObject::isWBR):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):

  • rendering/RenderText.cpp:
  • rendering/RenderText.h:
  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

  • rendering/RenderWordBreak.cpp: Removed.
  • rendering/RenderWordBreak.h: Removed.
  • rendering/RenderingAllInOne.cpp:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::ascentAndDescentForBox):
(WebCore::RootInlineBox::verticalPositionForBox):
(WebCore::RootInlineBox::includeLeadingForBox):
(WebCore::RootInlineBox::includeFontForBox):
(WebCore::RootInlineBox::includeGlyphsForBox):
(WebCore::RootInlineBox::includeMarginForBox):

6:48 AM Changeset in webkit [156037] by Csaba Osztrogonác
  • 3 edits
    5 adds in trunk

ASSERT_NOT_REACHED is touched in WebCore::CSSPrimitiveValue::computeLengthDouble
https://bugs.webkit.org/show_bug.cgi?id=120469

Source/WebCore:

Tests: fast/css/outline-offset-parsing-assert.html

fast/css/outline-offset-parsing.html

Reviewed by Dirk Schulze.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Fixed a typo after r66615, outline-offset can't be percentage.

LayoutTests:

Reviewed by Dirk Schulze.

  • fast/css/outline-offset-parsing-assert-expected.txt: Added.
  • fast/css/outline-offset-parsing-assert.html: Added.
  • fast/css/outline-offset-parsing-expected.txt: Added.
  • fast/css/outline-offset-parsing.html: Added.
  • fast/css/script-tests/outline-offset-parsing.js: Added.

(test):

5:39 AM Changeset in webkit [156036] by commit-queue@webkit.org
  • 4 edits
    12 adds in trunk

[MathML] Implement the subscriptshift and superscriptshift attributes
https://bugs.webkit.org/show_bug.cgi?id=120069

Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-18
Reviewed by Darin Adler.

Source/WebCore:

Added support for subscriptshift and superscriptshift attributes. The
subscriptshift attribute is for msup element and superscriptshift for
msup. msubsup can have both subscriptshift and superscriptshift. The
subscriptshift attribute specifies the minimum amount to shift the
baseline of subscript down. The superscriptshift attribute specifies
the minimum amount to shift the baseline of superscript up.

Tests: mathml/presentation/msub-subscriptshift.html

mathml/presentation/msubsup-subscriptshift.html
mathml/presentation/msubsup-superscriptshift.html
mathml/presentation/msup-superscriptshift.html
mathml/presentation/multiscript-subscriptshift.html
mathml/presentation/multiscript-superscriptshift.html

  • mathml/mathattrs.in:
  • rendering/mathml/RenderMathMLScripts.cpp:

(WebCore::RenderMathMLScripts::layout):
For aligning the subscript and superscript padding is added to the base.
So subscriptshift and superscriptshift attributes is set as padding bottom
and padding top of base respectively.

LayoutTests:

  • mathml/presentation/msub-subscriptshift-expected.txt: Added.
  • mathml/presentation/msub-subscriptshift.html: Added.
  • mathml/presentation/msubsup-subscriptshift-expected.txt: Added.
  • mathml/presentation/msubsup-subscriptshift.html: Added.
  • mathml/presentation/msubsup-superscriptshift-expected.txt: Added.
  • mathml/presentation/msubsup-superscriptshift.html: Added.
  • mathml/presentation/msup-superscriptshift-expected.txt: Added.
  • mathml/presentation/msup-superscriptshift.html: Added.
  • mathml/presentation/multiscript-subscriptshift-expected.txt: Added.
  • mathml/presentation/multiscript-subscriptshift.html: Added.
  • mathml/presentation/multiscript-superscriptshift-expected.txt: Added.
  • mathml/presentation/multiscript-superscriptshift.html: Added.

Added new tests for verifying that subscriptshift and superscriptshift are
being applied properly to the script base.

5:07 AM QtWebKitBuildBots edited by zarvai@inf.u-szeged.hu
(diff)
3:12 AM Changeset in webkit [156035] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.1.92

Tagging the WebKitGTK+ 2.1.91 release

2:34 AM Changeset in webkit [156034] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.2

Unreviewed. Update NEWS and Versions.m4 for 2.1.92 release.

.:

  • Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Add release notes.
1:28 AM Changeset in webkit [156033] by mario@webkit.org
  • 29 edits in trunk

[ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
https://bugs.webkit.org/show_bug.cgi?id=121495

Reviewed by Chris Fleizach.

Source/WebCore:

Removed the 'aria-' prefix from the exposed ATK object attributes
for WAI-ARIA attributes 'aria-haspopup' and 'aria-sort'.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes): Removed the prefix.

Tools:

Adapted DRT and WKTR to deal with the new names for the ATK object
attributes being exposed for 'aria-haspopup' and 'aria-sort'.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(coreAttributeToAtkAttribute): Updated translation between ATK and DRT.
(AccessibilityUIElement::stringAttributeValue): Ditto.
(AccessibilityUIElement::hasPopup): Ditto.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::coreAttributeToAtkAttribute): Updated translation between ATK and WKTR.
(WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
(WTR::AccessibilityUIElement::hasPopup): Ditto.

LayoutTests:

Rebaseline test expectations that were displaying the 'aria-sort'
attributes incorrectly, when they shouldn't due to that ARIA
attribute not being explicitly used in the HTML.

  • platform/efl-wk1/accessibility/lists-expected.txt: Removed output for 'aria-sort'.
  • platform/efl-wk1/accessibility/plugin-expected.txt: Ditto.
  • platform/efl-wk1/accessibility/table-with-aria-role-expected.txt: Ditto.
  • platform/efl-wk1/accessibility/transformed-element-expected.txt: Ditto.
  • platform/efl-wk2/accessibility/image-link-expected.txt: Ditto.
  • platform/efl-wk2/accessibility/image-map2-expected.txt: Ditto.
  • platform/efl-wk2/accessibility/lists-expected.txt: Ditto.
  • platform/efl-wk2/accessibility/plugin-expected.txt: Ditto.
  • platform/efl-wk2/accessibility/table-cell-spans-expected.txt: Ditto.
  • platform/efl-wk2/accessibility/table-cells-expected.txt: Ditto.
  • platform/efl-wk2/accessibility/table-with-aria-role-expected.txt: Ditto.
  • platform/efl-wk2/accessibility/transformed-element-expected.txt: Ditto.
  • platform/gtk/accessibility/image-link-expected.txt: Ditto.
  • platform/gtk/accessibility/image-map2-expected.txt: Ditto.
  • platform/gtk/accessibility/lists-expected.txt: Ditto.
  • platform/gtk/accessibility/plugin-expected.txt: Ditto.
  • platform/gtk/accessibility/table-cell-spans-expected.txt: Ditto.
  • platform/gtk/accessibility/table-cells-expected.txt: Ditto.
  • platform/gtk/accessibility/table-detection-expected.txt: Ditto.
  • platform/gtk/accessibility/table-one-cell-expected.txt: Ditto.
  • platform/gtk/accessibility/table-with-aria-role-expected.txt: Ditto.
  • platform/gtk/accessibility/table-with-rules-expected.txt: Ditto.
  • platform/gtk/accessibility/transformed-element-expected.txt: Ditto.
12:55 AM Changeset in webkit [156032] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r156028 - [GTK] WebKitScriptWorld not in API documentation
https://bugs.webkit.org/show_bug.cgi?id=121539

Reviewed by Philippe Normand.

  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add WebKitScriptWorld.
12:52 AM Changeset in webkit [156031] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebInspectorUI

Merge r156027 - [GTK] Cannot find WebInspectorUI/UserInterface/Main.html referenced in GResourceBundle.xml
https://bugs.webkit.org/show_bug.cgi?id=121405

Patch by Gustavo Noronha Silva <gns@gnome.org> on 2013-09-17
Reviewed by Carlos Garcia Campos.

  • GNUmakefile.am: if srcdir == builddir the WebInspectorUI variable that is used both to list

the dependencies of the GResourceBundle and to normalize the paths added to the XML through sed
replacement will end up starting with ./, which would be fine if automake did not remove that
from the paths in the target's dependency. We deal with that by normalizing the path we use to
take that quirk into account.

12:38 AM Changeset in webkit [156030] by Carlos Garcia Campos
  • 30 edits
    1 add in releases/WebKitGTK/webkit-2.2

Merge r155714 - [GTK] Move to the new web inspector
https://bugs.webkit.org/show_bug.cgi?id=120647

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-09-13
Reviewed by Carlos Garcia Campos.

.:

  • GNUmakefile.am: include the new WebInspectorUI GNUmakefile.am.

Source/WebCore:

No tests for the new inspector UI as of yet.

  • GNUmakefile.am: no longer install the deprecated inspector UI files.
  • WebCore.exp.in: add SchemeRegistry symbol that is now used.

Source/WebInspectorUI:

  • GNUmakefile.am: Added. Generate the GResource source and link it into libWebCore.

Source/WebKit/gtk:

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::openInspectorFrontend): update paths to the internal resource ones.
(WebKit::InspectorClient::inspectorFilesPath): ditto.

  • tests/testwebinspector.c:

(consoleMessageCallback): the new inspector currently emits an error when loading, so add it to
the list of messages which are not considered failures.

  • webkit/webkitglobals.cpp:

(webkitInit): register resource as a local scheme; currently used by the inspector.

Source/WebKit2:

  • GNUmakefile.am: bundle the remote inspector page list HTML into libwebkit2gtk as a GResource.
  • UIProcess/API/gtk/tests/GNUmakefile.am: no need to set WEBKIT_INSPECTOR_PATH anymore.
  • UIProcess/API/gtk/tests/InspectorTestServer.cpp:

(main): ditto.

  • UIProcess/API/gtk/tests/TestInspector.cpp:

(beforeAll): ditto.

  • UIProcess/API/gtk/tests/TestInspectorServer.cpp:

(testInspectorServerPageList): update paths to the internal resource ones.

  • UIProcess/InspectorServer/WebInspectorServer.h:
  • UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:

(WebKit::WebInspectorServer::platformResourceForPath): ditto.
(WebKit::WebInspectorServer::buildPageList): ditto.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::isMainInspectorPage): factor out checking for the inspector main resource, to make
the code more readable.
(WebKit::decidePolicyForNavigationAction): use SchemeRegistry to figure out whether the
request is for a local resource instead of KURL::isLocalFile() to allow using schemes
other than file:// for the inspector resources.

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::inspectorPageURL): use the new internal resource URL; since it's now
static we no longer need to generate and store the string.
(WebKit::WebInspectorProxy::inspectorBaseURL): ditto.

  • WebProcess/WebPage/gtk/WebInspectorGtk.cpp:

(WebKit::WebInspector::localizedStringsURL): use the new internal resource URL.

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformInitializeWebProcess): register resource as a local scheme.

Tools:

  • GtkLauncher/main.c:

(main): no longer set WEBKIT_INSPECTOR_PATH.

  • MiniBrowser/gtk/main.c:

(main): ditto.

  • Scripts/old-run-webkit-tests:

(openDumpTool): ditto.

  • Scripts/run-gtk-tests: ditto.
  • Scripts/webkitpy/port/gtk.py:

(GtkPort.setup_environ_for_server): ditto.

LayoutTests:

  • platform/gtk/TestExpectations: the new inspector UI does not support the current

inspector testing harness so keep it skipped, a new one will eventually be landed.

12:37 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
12:25 AM Changeset in webkit [156029] by commit-queue@webkit.org
  • 69 edits
    12 deletes in trunk

Unreviewed, rolling out r156019 and r156020.
http://trac.webkit.org/changeset/156019
http://trac.webkit.org/changeset/156020
https://bugs.webkit.org/show_bug.cgi?id=121540

Broke tests (Requested by ap on #webkit).

Source/JavaScriptCore:

  • assembler/MacroAssemblerX86_64.h:
  • assembler/X86Assembler.h:
  • bytecode/DataFormat.h:

(JSC::dataFormatToString):

  • bytecode/ExitKind.cpp:

(JSC::exitKindToString):

  • bytecode/ExitKind.h:
  • bytecode/OperandsInlines.h:

(JSC::::dumpInContext):

  • bytecode/SpeculatedType.cpp:

(JSC::dumpSpeculation):
(JSC::speculationToAbbreviatedString):
(JSC::speculationFromValue):

  • bytecode/SpeculatedType.h:

(JSC::isInt32SpeculationForArithmetic):
(JSC::isInt48Speculation):
(JSC::isMachineIntSpeculationForArithmetic):
(JSC::isInt48AsDoubleSpeculation):
(JSC::isRealNumberSpeculation):
(JSC::isNumberSpeculation):
(JSC::isNumberSpeculationExpectingDefined):

  • bytecode/ValueRecovery.h:

(JSC::ValueRecovery::inGPR):
(JSC::ValueRecovery::displacedInJSStack):
(JSC::ValueRecovery::isAlreadyInJSStack):
(JSC::ValueRecovery::gpr):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dumpInContext):

  • dfg/DFGAbstractInterpreter.h:

(JSC::DFG::AbstractInterpreter::needsTypeCheck):
(JSC::DFG::AbstractInterpreter::filterByType):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

  • dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::checkConsistency):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::validateType):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::refine):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::unboxDouble):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::canonicalize):
(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGCommon.h:
  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
(JSC::DFG::FixupPhase::observeUseKindOnNode):
(JSC::DFG::FixupPhase::fixEdge):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):
(JSC::DFG::FixupPhase::attemptToMakeIntegerAdd):

  • dfg/DFGFlushFormat.cpp:

(WTF::printInternal):

  • dfg/DFGFlushFormat.h:

(JSC::DFG::resultFor):
(JSC::DFG::useKindFor):

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::initInt32):
(JSC::DFG::GenerationInfo::fillInt32):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::addShouldSpeculateMachineInt):
(JSC::DFG::Graph::mulShouldSpeculateMachineInt):
(JSC::DFG::Graph::negateShouldSpeculateMachineInt):

  • dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::mergeStateAtTail):

  • dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::reconstruct):

  • dfg/DFGMinifiedNode.h:

(JSC::DFG::belongsInMinifiedGraph):
(JSC::DFG::MinifiedNode::hasChild):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateNumber):
(JSC::DFG::Node::shouldSpeculateNumberExpectingDefined):
(JSC::DFG::Node::canSpeculateInt48):

  • dfg/DFGNodeFlags.h:

(JSC::DFG::nodeCanSpeculateInt48):

  • dfg/DFGNodeType.h:

(JSC::DFG::forwardRewiringSelectionScore):

  • dfg/DFGOSRExitCompiler.cpp:

(JSC::DFG::shortOperandsDump):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::speculatedDoubleTypeForPrediction):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doDoubleVoting):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()):
(JSC::DFG::safeToExecute):

  • dfg/DFGSilentRegisterSavePlan.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileDoublePutByVal):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileArithNegate):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::speculateNumber):
(JSC::DFG::SpeculativeJIT::speculateRealNumber):
(JSC::DFG::SpeculativeJIT::speculate):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::isFilled):
(JSC::DFG::SpeculativeJIT::isFilledDouble):
(JSC::DFG::SpeculativeJIT::use):
(JSC::DFG::SpeculativeJIT::boxDouble):
(JSC::DFG::SpeculativeJIT::isKnownInteger):
(JSC::DFG::SpeculativeJIT::isKnownCell):
(JSC::DFG::SpeculativeJIT::isKnownNotNumber):
(JSC::DFG::SpeculativeJIT::int32Result):
(JSC::DFG::SpeculativeJIT::initConstantInfo):
(JSC::DFG::SpeculativeJIT::isInteger):
(JSC::DFG::SpeculativeJIT::generationInfoFromVirtualRegister):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGUseKind.cpp:

(WTF::printInternal):

  • dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):
(JSC::DFG::isNumerical):

  • dfg/DFGValueSource.cpp:

(JSC::DFG::ValueSource::dump):

  • dfg/DFGValueSource.h:

(JSC::DFG::dataFormatToValueSourceKind):
(JSC::DFG::valueSourceKindToDataFormat):
(JSC::DFG::ValueSource::forFlushFormat):
(JSC::DFG::ValueSource::valueRecovery):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
(JSC::DFG::VariableAccessData::flushFormat):

  • ftl/FTLCArgumentGetter.cpp:

(JSC::FTL::CArgumentGetter::loadNextAndBox):

  • ftl/FTLCArgumentGetter.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLExitValue.cpp:

(JSC::FTL::ExitValue::dumpInContext):

  • ftl/FTLExitValue.h:
  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::createPhiVariables):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileUpsilon):
(JSC::FTL::LowerDFGToLLVM::compilePhi):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::compileAdd):
(JSC::FTL::LowerDFGToLLVM::compileArithSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareLess):
(JSC::FTL::LowerDFGToLLVM::compileCompareLessEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreater):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreaterEq):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::lowDouble):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
(JSC::FTL::LowerDFGToLLVM::speculateRealNumber):
(JSC::FTL::LowerDFGToLLVM::initializeOSRExitStateForBlock):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
(JSC::FTL::LowerDFGToLLVM::setInt32):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::mulWithOverflow32):

  • ftl/FTLValueFormat.cpp:

(WTF::printInternal):

  • ftl/FTLValueFormat.h:
  • ftl/FTLValueSource.cpp:

(JSC::FTL::ValueSource::dump):

  • ftl/FTLValueSource.h:
  • interpreter/Register.h:
  • runtime/Arguments.cpp:

(JSC::Arguments::tearOffForInlineCallFrame):

  • runtime/IndexingType.cpp:

(JSC::leastUpperBoundOfIndexingTypeAndType):

  • runtime/JSCJSValue.h:
  • runtime/JSCJSValueInlines.h:

Source/WTF:

  • wtf/PrintStream.h:

Tools:

  • Scripts/run-jsc-stress-tests:

LayoutTests:

  • js/regress/large-int-captured-expected.txt: Removed.
  • js/regress/large-int-captured.html: Removed.
  • js/regress/large-int-expected.txt: Removed.
  • js/regress/large-int-neg-expected.txt: Removed.
  • js/regress/large-int-neg.html: Removed.
  • js/regress/large-int.html: Removed.
  • js/regress/marsaglia-larger-ints-expected.txt: Removed.
  • js/regress/marsaglia-larger-ints.html: Removed.
  • js/regress/script-tests/large-int-captured.js: Removed.
  • js/regress/script-tests/large-int-neg.js: Removed.
  • js/regress/script-tests/large-int.js: Removed.
  • js/regress/script-tests/marsaglia-larger-ints.js: Removed.
12:07 AM Changeset in webkit [156028] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] WebKitScriptWorld not in API documentation
https://bugs.webkit.org/show_bug.cgi?id=121539

Reviewed by Philippe Normand.

  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add WebKitScriptWorld.

Sep 17, 2013:

11:51 PM Changeset in webkit [156027] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

[GTK] Cannot find WebInspectorUI/UserInterface/Main.html referenced in GResourceBundle.xml
https://bugs.webkit.org/show_bug.cgi?id=121405

Patch by Gustavo Noronha Silva <gns@gnome.org> on 2013-09-17
Reviewed by Carlos Garcia Campos.

  • GNUmakefile.am: if srcdir == builddir the WebInspectorUI variable that is used both to list

the dependencies of the GResourceBundle and to normalize the paths added to the XML through sed
replacement will end up starting with ./, which would be fine if automake did not remove that
from the paths in the target's dependency. We deal with that by normalizing the path we use to
take that quirk into account.

11:39 PM Changeset in webkit [156026] by ryumiel@company100.net
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

11:30 PM Changeset in webkit [156025] by Antti Koivisto
  • 9 edits in trunk/Source/WebCore

Rename InlineBox::isText()
<https://webkit.org/b/121525>

Reviewed by Andreas Kling.

The flag sounds like RenderObject::isText() yet it can be set for some inline boxes generated
for non-text renderers too (br, list markers). This is pretty confusing.

Rename to InlineBox::behavesLikeText().

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::logicalHeight):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):

  • rendering/InlineBox.h:

(WebCore::InlineBox::behavesLikeText):
(WebCore::InlineBox::setBehavesLikeText):
(WebCore::InlineBox::InlineBoxBitfields::InlineBoxBitfields):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::baselinePosition):
(WebCore::InlineTextBox::lineHeight):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::createInlineBoxForRenderer):
(WebCore::setLogicalWidthForTextRun):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::createInlineBox):

  • rendering/RenderText.cpp:

(WebCore::RenderText::createInlineTextBox):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::includeLeadingForBox):
(WebCore::RootInlineBox::includeFontForBox):
(WebCore::RootInlineBox::includeGlyphsForBox):
(WebCore::RootInlineBox::includeMarginForBox):

Switch tests from isText() to isTextOrBR(). This matches the behavior before r155957.
I don't know if there is a case where this actually makes any difference in behavior.

11:05 PM Changeset in webkit [156024] by weinig@apple.com
  • 3 edits in trunk/Source/WebCore

Shrink SVGPathStringBuilder
https://bugs.webkit.org/show_bug.cgi?id=121536

Reviewed by Anders Carlsson.

  • Use StringBuilder everywhere to avoid unnecessary temporary String objects and code size bloat.
  • Also did a drive by FINAL / OVERRIDE pass.

As an example of the win, the function SVGPathStringBuilder::arcTo
went from being 6120 bytes down to just 378 bytes.

  • svg/SVGPathStringBuilder.cpp:

(WebCore::SVGPathStringBuilder::SVGPathStringBuilder):
(WebCore::SVGPathStringBuilder::~SVGPathStringBuilder):
(WebCore::SVGPathStringBuilder::cleanup):
(WebCore::SVGPathStringBuilder::incrementPathSegmentCount):
(WebCore::SVGPathStringBuilder::continueConsuming):
It wasn't helpful for these to be inlined, so move them to
the implementation file.

(WebCore::appendFlag):
(WebCore::appendNumber):
(WebCore::appendPoint):
Added helpers.

(WebCore::SVGPathStringBuilder::moveTo):
(WebCore::SVGPathStringBuilder::lineTo):
(WebCore::SVGPathStringBuilder::lineToHorizontal):
(WebCore::SVGPathStringBuilder::lineToVertical):
(WebCore::SVGPathStringBuilder::curveToCubic):
(WebCore::SVGPathStringBuilder::curveToCubicSmooth):
(WebCore::SVGPathStringBuilder::curveToQuadratic):
(WebCore::SVGPathStringBuilder::curveToQuadraticSmooth):
(WebCore::SVGPathStringBuilder::arcTo):
(WebCore::SVGPathStringBuilder::closePath):

  • svg/SVGPathStringBuilder.h:

Stopped using operator+ and removed duplicate string building logic in each build
type (e.g. both sides of the PathCoordinateMode condition were doing almost identical
work).

10:00 PM Changeset in webkit [156023] by weinig@apple.com
  • 14 edits in trunk/Source/WebCore

CTTE: Convert some straggling Element subclasses constructors to take a Document&
https://bugs.webkit.org/show_bug.cgi?id=121533

Reviewed by Anders Carlsson.

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::didAddUserAgentShadowRoot):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::didAddUserAgentShadowRoot):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::didAddUserAgentShadowRoot):

  • html/SearchInputType.cpp:

(WebCore::SearchInputType::createShadowSubtree):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):

  • html/shadow/MeterShadowElement.cpp:

(WebCore::MeterShadowElement::MeterShadowElement):
(WebCore::MeterInnerElement::MeterInnerElement):

  • html/shadow/MeterShadowElement.h:

(WebCore::MeterInnerElement::create):
(WebCore::MeterBarElement::create):
(WebCore::MeterValueElement::create):

  • html/shadow/ProgressShadowElement.cpp:

(WebCore::ProgressShadowElement::ProgressShadowElement):
(WebCore::ProgressInnerElement::ProgressInnerElement):
(WebCore::ProgressBarElement::ProgressBarElement):
(WebCore::ProgressValueElement::ProgressValueElement):

  • html/shadow/ProgressShadowElement.h:

(WebCore::ProgressInnerElement::create):
(WebCore::ProgressBarElement::create):
(WebCore::ProgressValueElement::create):

  • html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::SpinButtonElement):
(WebCore::SpinButtonElement::create):

  • html/shadow/SpinButtonElement.h:
  • html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerContainer::TextControlInnerContainer):
(WebCore::TextControlInnerContainer::create):
(WebCore::TextControlInnerElement::TextControlInnerElement):
(WebCore::TextControlInnerElement::create):
(WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
(WebCore::TextControlInnerTextElement::create):
(WebCore::SearchFieldResultsButtonElement::SearchFieldResultsButtonElement):
(WebCore::SearchFieldResultsButtonElement::create):
(WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
(WebCore::SearchFieldCancelButtonElement::create):
(WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):
(WebCore::InputFieldSpeechButtonElement::create):

  • html/shadow/TextControlInnerElements.h:
8:27 PM Changeset in webkit [156022] by zoltan@webkit.org
  • 12 edits
    8 adds in trunk

[CSS Shapes] Use the float height to determine position in shape-inside
https://bugs.webkit.org/show_bug.cgi?id=102846

Reviewed by Darin Adler.

Float positioning inside shape-inside has been working only for simple cases when the float boundaries didn't overlap with the shape.
This patch fixes the behavior for left floats and shapes with inline content. I want to add this work step by step, therefore the next
step would be to add support for block content with inline content (e.g. paragraphs) then cover cases with right floats.

Source/WebCore:

Tests: fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content.html

fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content.html
fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content.html
fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content.html

  • rendering/LineWidth.cpp:

(WebCore::LineWidth::LineWidth): Use the new updateCurrentShapeSegment member function.
(WebCore::LineWidth::updateCurrentShapeSegment): We need a function to update the current line segment's reference, since we use it multiple places.

  • rendering/LineWidth.h: Add new member function.
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeLogicalLocationForFloat): Fix positioning of a floating element.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLine): Use updateSegmentsForLine instead of computeSegmentsForLine.
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLineInFlowThread): Use updateSegmentsForLine instead of computeSegmentsForLine.
(WebCore::RenderBlock::adjustLogicalLineTopAndLogicalHeightIfNeeded):
(WebCore::updateSegmentsForShapes): After our float is positioned, we need to adjust the current lineTop and update the logical height to be able to wrap around the float.
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak): If we have a float in our line we might need to adjust our lineTop and logicalHeight.

  • rendering/shapes/ShapeInfo.cpp:

(WebCore::::computeSegmentsForLine): Add new const function to compute the segments. I'd like make this function static later if possible.
(WebCore::::updateSegmentsForLine): Old computeSegmentsForLine, change name to indicate that it is actually changing things.

  • rendering/shapes/ShapeInfo.h: Update function names, add declaration.

(WebCore::ShapeInfo::clearSegments):
(WebCore::ShapeInfo::logicalLineBottom):
(WebCore::ShapeInfo::lineOverlapsShapeBounds):

  • rendering/shapes/ShapeInsideInfo.cpp:

(WebCore::ShapeInsideInfo::computeFirstFitPositionForFloat): Compute the first fit position below the current line position inside shapes. I called this function
this way, because currently we use it only for shapes.

  • rendering/shapes/ShapeInsideInfo.h: Update function names.
  • rendering/shapes/ShapeOutsideInfo.cpp: Update function names.

(WebCore::ShapeOutsideInfo::computeSegmentsForContainingBlockLine):
(WebCore::ShapeOutsideInfo::updateSegmentsForLine):

  • rendering/shapes/ShapeOutsideInfo.h: Update function names.

LayoutTests:

  • fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content-expected.html: Added.
  • fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content.html: Added.
  • fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content-expected.html: Added.
  • fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content.html: Added.
  • fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content-expected.html: Added.
  • fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content.html: Added.
  • fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content-expected.html: Added.
  • fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content.html: Added.
6:59 PM Changeset in webkit [156021] by jae.park@company100.net
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

  • Scripts/webkitpy/common/config/contributors.json:
6:48 PM Changeset in webkit [156020] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix 32-bit build.

  • runtime/JSCJSValue.h:
6:31 PM Changeset in webkit [156019] by fpizlo@apple.com
  • 69 edits
    12 adds in trunk

DFG should support Int52 for local variables
https://bugs.webkit.org/show_bug.cgi?id=121064

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This adds Int52 support for local variables to the DFG and FTL. It's a speed-up on
programs that have local int32 overflows but where a larger int representation can
prevent us from having to convert all the way up to double.

It's a small speed-up for now. But we're just supporting Int52 for a handful of
operations (add, sub, mul, neg, compare, bitops, typed array access) and this lays
the groundwork for adding Int52 to JSValue, which will probably be a bigger
speed-up.

The basic approach is:

  • We have a notion of Int52 in our typesystem. Int52 doesn't belong to BytecodeTop or HeapTop - i.e. it doesn't arise from JSValues.


  • DFG treats Int52 as being part of its FullTop and will treat it as being a subtype of double unless instructed otherwise.


  • Prediction propagator creates Int52s whenever we have a node going doubly but due to large values rather than fractional values, and that node is known to be able to produce Int52 natively in the DFG backend.


  • Fixup phase converts edges to MachineIntUses in nodes that are known to be able to deal with Int52, and where we have a subtype of Int32|Int52 as the predicted input.


  • The DFG backend and FTL LLVM IR lowering have two notions of Int52s - ones that are left-shifted by 16 (great for overflow checks) and ones that are sign-extended. Both backends know how to convert between Int52s and the other representations.
  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::rshift64):
(JSC::MacroAssemblerX86_64::mul64):
(JSC::MacroAssemblerX86_64::branchMul64):
(JSC::MacroAssemblerX86_64::branchNeg64):
(JSC::MacroAssemblerX86_64::convertInt64ToDouble):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::imulq_rr):
(JSC::X86Assembler::cvtsi2sdq_rr):

  • bytecode/DataFormat.h:

(JSC::dataFormatToString):

  • bytecode/OperandsInlines.h:

(JSC::::dumpInContext):

  • bytecode/SpeculatedType.cpp:

(JSC::dumpSpeculation):
(JSC::speculationToAbbreviatedString):
(JSC::speculationFromValue):

  • bytecode/SpeculatedType.h:

(JSC::isInt32SpeculationForArithmetic):
(JSC::isMachineIntSpeculationForArithmetic):
(JSC::isBytecodeRealNumberSpeculation):
(JSC::isFullRealNumberSpeculation):
(JSC::isBytecodeNumberSpeculation):
(JSC::isFullNumberSpeculation):
(JSC::isBytecodeNumberSpeculationExpectingDefined):
(JSC::isFullNumberSpeculationExpectingDefined):

  • bytecode/ValueRecovery.h:

(JSC::ValueRecovery::alreadyInJSStackAsUnboxedInt52):
(JSC::ValueRecovery::inGPR):
(JSC::ValueRecovery::displacedInJSStack):
(JSC::ValueRecovery::isAlreadyInJSStack):
(JSC::ValueRecovery::gpr):
(JSC::ValueRecovery::virtualRegister):
(JSC::ValueRecovery::dumpInContext):

  • dfg/DFGAbstractInterpreter.h:

(JSC::DFG::AbstractInterpreter::needsTypeCheck):
(JSC::DFG::AbstractInterpreter::filterByType):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

  • dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::checkConsistency):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::couldBeType):
(JSC::DFG::AbstractValue::isType):
(JSC::DFG::AbstractValue::checkConsistency):
(JSC::DFG::AbstractValue::validateType):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::refine):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::boxInt52):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::pureCSE):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGCommon.h:

(JSC::DFG::enableInt52):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
(JSC::DFG::FixupPhase::fixupUntypedSetLocalsInBlock):
(JSC::DFG::FixupPhase::observeUseKindOnNode):
(JSC::DFG::FixupPhase::fixEdge):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):
(JSC::DFG::FixupPhase::attemptToMakeIntegerAdd):

  • dfg/DFGFlushFormat.cpp:

(WTF::printInternal):

  • dfg/DFGFlushFormat.h:

(JSC::DFG::resultFor):
(JSC::DFG::useKindFor):

  • dfg/DFGGenerationInfo.h:

(JSC::DFG::GenerationInfo::initInt52):
(JSC::DFG::GenerationInfo::initStrictInt52):
(JSC::DFG::GenerationInfo::isFormat):
(JSC::DFG::GenerationInfo::isInt52):
(JSC::DFG::GenerationInfo::isStrictInt52):
(JSC::DFG::GenerationInfo::fillInt52):
(JSC::DFG::GenerationInfo::fillStrictInt52):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::addShouldSpeculateMachineInt):
(JSC::DFG::Graph::mulShouldSpeculateMachineInt):
(JSC::DFG::Graph::negateShouldSpeculateMachineInt):

  • dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::mergeStateAtTail):

  • dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::reconstruct):

  • dfg/DFGMinifiedNode.h:

(JSC::DFG::belongsInMinifiedGraph):
(JSC::DFG::MinifiedNode::hasChild):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateNumber):
(JSC::DFG::Node::shouldSpeculateNumberExpectingDefined):

  • dfg/DFGNodeFlags.h:
  • dfg/DFGNodeType.h:

(JSC::DFG::forwardRewiringSelectionScore):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::speculatedDoubleTypeForPrediction):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doDoubleVoting):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()):
(JSC::DFG::safeToExecute):

  • dfg/DFGSilentRegisterSavePlan.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(JSC::DFG::SpeculativeJIT::silentFill):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileDoublePutByVal):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileArithNegate):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::speculateMachineInt):
(JSC::DFG::SpeculativeJIT::speculateNumber):
(JSC::DFG::SpeculativeJIT::speculateRealNumber):
(JSC::DFG::SpeculativeJIT::speculate):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::canReuse):
(JSC::DFG::SpeculativeJIT::isFilled):
(JSC::DFG::SpeculativeJIT::isFilledDouble):
(JSC::DFG::SpeculativeJIT::use):
(JSC::DFG::SpeculativeJIT::isKnownInteger):
(JSC::DFG::SpeculativeJIT::isKnownCell):
(JSC::DFG::SpeculativeJIT::isKnownNotNumber):
(JSC::DFG::SpeculativeJIT::int52Result):
(JSC::DFG::SpeculativeJIT::strictInt52Result):
(JSC::DFG::SpeculativeJIT::initConstantInfo):
(JSC::DFG::SpeculativeJIT::isInteger):
(JSC::DFG::SpeculativeJIT::betterUseStrictInt52):
(JSC::DFG::SpeculativeJIT::generationInfo):
(JSC::DFG::SpeculateInt52Operand::SpeculateInt52Operand):
(JSC::DFG::SpeculateInt52Operand::~SpeculateInt52Operand):
(JSC::DFG::SpeculateInt52Operand::edge):
(JSC::DFG::SpeculateInt52Operand::node):
(JSC::DFG::SpeculateInt52Operand::gpr):
(JSC::DFG::SpeculateInt52Operand::use):
(JSC::DFG::SpeculateStrictInt52Operand::SpeculateStrictInt52Operand):
(JSC::DFG::SpeculateStrictInt52Operand::~SpeculateStrictInt52Operand):
(JSC::DFG::SpeculateStrictInt52Operand::edge):
(JSC::DFG::SpeculateStrictInt52Operand::node):
(JSC::DFG::SpeculateStrictInt52Operand::gpr):
(JSC::DFG::SpeculateStrictInt52Operand::use):
(JSC::DFG::SpeculateWhicheverInt52Operand::SpeculateWhicheverInt52Operand):
(JSC::DFG::SpeculateWhicheverInt52Operand::~SpeculateWhicheverInt52Operand):
(JSC::DFG::SpeculateWhicheverInt52Operand::edge):
(JSC::DFG::SpeculateWhicheverInt52Operand::node):
(JSC::DFG::SpeculateWhicheverInt52Operand::gpr):
(JSC::DFG::SpeculateWhicheverInt52Operand::use):
(JSC::DFG::SpeculateWhicheverInt52Operand::format):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::boxInt52):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateInt52):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileInt52Compare):
(JSC::DFG::SpeculativeJIT::compilePeepHoleInt52Branch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGUseKind.cpp:

(WTF::printInternal):

  • dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):
(JSC::DFG::isNumerical):

  • dfg/DFGValueSource.cpp:

(JSC::DFG::ValueSource::dump):

  • dfg/DFGValueSource.h:

(JSC::DFG::dataFormatToValueSourceKind):
(JSC::DFG::valueSourceKindToDataFormat):
(JSC::DFG::ValueSource::forFlushFormat):
(JSC::DFG::ValueSource::valueRecovery):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
(JSC::DFG::VariableAccessData::flushFormat):

  • ftl/FTLCArgumentGetter.cpp:

(JSC::FTL::CArgumentGetter::loadNextAndBox):

  • ftl/FTLCArgumentGetter.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLExitValue.cpp:

(JSC::FTL::ExitValue::dumpInContext):

  • ftl/FTLExitValue.h:

(JSC::FTL::ExitValue::inJSStackAsInt52):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::createPhiVariables):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileUpsilon):
(JSC::FTL::LowerDFGToLLVM::compilePhi):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::compileAdd):
(JSC::FTL::LowerDFGToLLVM::compileArithSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareLess):
(JSC::FTL::LowerDFGToLLVM::compileCompareLessEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreater):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreaterEq):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowInt52):
(JSC::FTL::LowerDFGToLLVM::lowStrictInt52):
(JSC::FTL::LowerDFGToLLVM::betterUseStrictInt52):
(JSC::FTL::LowerDFGToLLVM::bestInt52Kind):
(JSC::FTL::LowerDFGToLLVM::opposite):
(JSC::FTL::LowerDFGToLLVM::Int52s::operator[]):
(JSC::FTL::LowerDFGToLLVM::lowWhicheverInt52):
(JSC::FTL::LowerDFGToLLVM::lowWhicheverInt52s):
(JSC::FTL::LowerDFGToLLVM::lowOpposingInt52s):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::lowDouble):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
(JSC::FTL::LowerDFGToLLVM::strictInt52ToInt32):
(JSC::FTL::LowerDFGToLLVM::strictInt52ToDouble):
(JSC::FTL::LowerDFGToLLVM::strictInt52ToJSValue):
(JSC::FTL::LowerDFGToLLVM::setInt52WithStrictValue):
(JSC::FTL::LowerDFGToLLVM::strictInt52ToInt52):
(JSC::FTL::LowerDFGToLLVM::int52ToStrictInt52):
(JSC::FTL::LowerDFGToLLVM::speculateRealNumber):
(JSC::FTL::LowerDFGToLLVM::initializeOSRExitStateForBlock):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
(JSC::FTL::LowerDFGToLLVM::setInt52):
(JSC::FTL::LowerDFGToLLVM::setStrictInt52):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::addWithOverflow64):
(JSC::FTL::Output::subWithOverflow64):
(JSC::FTL::Output::mulWithOverflow64):

  • ftl/FTLValueFormat.cpp:

(WTF::printInternal):

  • ftl/FTLValueFormat.h:
  • ftl/FTLValueSource.cpp:

(JSC::FTL::ValueSource::dump):

  • ftl/FTLValueSource.h:
  • interpreter/Register.h:

(JSC::Register::unboxedInt52):

  • runtime/Arguments.cpp:

(JSC::Arguments::tearOffForInlineCallFrame):

  • runtime/IndexingType.cpp:

(JSC::leastUpperBoundOfIndexingTypeAndType):

  • runtime/JSCJSValue.h:
  • runtime/JSCJSValueInlines.h:

(JSC::JSValue::isMachineInt):
(JSC::JSValue::asMachineInt):

Source/WTF:

Reviewed by Oliver Hunt.

  • wtf/PrintStream.h:

(WTF::ValueIgnoringContext::ValueIgnoringContext):
(WTF::ValueIgnoringContext::dump):
(WTF::ignoringContext):

Tools:

Reviewed by Oliver Hunt.

  • Scripts/run-jsc-stress-tests:

LayoutTests:

Reviewed by Oliver Hunt.

  • js/regress/large-int-captured-expected.txt: Added.
  • js/regress/large-int-captured.html: Added.
  • js/regress/large-int-expected.txt: Added.
  • js/regress/large-int-neg-expected.txt: Added.
  • js/regress/large-int-neg.html: Added.
  • js/regress/large-int.html: Added.
  • js/regress/marsaglia-larger-ints-expected.txt: Added.
  • js/regress/marsaglia-larger-ints.html: Added.
  • js/regress/script-tests/large-int-captured.js: Added.

(.bar):
(foo):

  • js/regress/script-tests/large-int-neg.js: Added.

(foo):

  • js/regress/script-tests/large-int.js: Added.

(foo):

  • js/regress/script-tests/marsaglia-larger-ints.js: Added.

(uint):
(marsaglia):

6:10 PM Changeset in webkit [156018] by alex.christensen@flexsim.com
  • 2 edits in trunk/Tools

Added back and forward buttons to WinLauncher.
https://bugs.webkit.org/show_bug.cgi?id=121212

Reviewed by Brent Fulgham.

  • WinLauncher/WinLauncher.cpp:

(resizeSubViews):
Move new back and forward buttons to correct positions before URL bar.
(dllLauncherEntryPoint):
Store the default button window procedure and replace with my button procedures.
(EditProc): Updated style and renamed from MyEditProc.
(BackButtonProc): Added.
(ForwardButtonProc): Added.

6:06 PM Changeset in webkit [156017] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Use CheckStructure for checking the types of typed arrays whenever possible
https://bugs.webkit.org/show_bug.cgi?id=121514

Reviewed by Oliver Hunt.

  • bytecode/ArrayProfile.cpp:

(JSC::ArrayProfile::computeUpdatedPrediction):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::fromObserved):
(JSC::DFG::ArrayMode::refine):
(JSC::DFG::ArrayMode::originalArrayStructure):
(JSC::DFG::arrayClassToString):

  • dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::ArrayMode):
(JSC::DFG::ArrayMode::arrayModesWithIndexingShape):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::isOriginalTypedArrayStructure):

6:04 PM Changeset in webkit [156016] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG should use the (x & 0x7fffffff) trick for doing overflow and neg-zero checks on negation in one go
https://bugs.webkit.org/show_bug.cgi?id=121520

Reviewed by Oliver Hunt.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithNegate):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileArithNegate):

5:15 PM Changeset in webkit [156015] by weinig@apple.com
  • 40 edits in trunk/Source/WebCore

Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in WebCore
https://bugs.webkit.org/show_bug.cgi?id=121527

Reviewed by Anders Carlsson.

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::setBuffer):

  • Modules/webaudio/AudioBufferSourceNode.h:
  • Modules/webaudio/OscillatorNode.h:
  • css/CSSParser.cpp:

(WebCore::CSSParser::setupParser):
(WebCore::CSSParser::currentCharacter16):

  • css/CSSParser.h:
  • html/HTMLAreaElement.h:
  • html/HTMLFrameSetElement.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::simulateVertexAttrib0):
(WebCore::WebGLRenderingContext::LRUImageBufferCache::LRUImageBufferCache):

  • html/canvas/WebGLRenderingContext.h:
  • platform/ScrollAnimatorNone.cpp:
  • platform/audio/DynamicsCompressor.cpp:

(WebCore::DynamicsCompressor::setNumberOfChannels):

  • platform/audio/DynamicsCompressor.h:
  • platform/audio/FFTFrame.h:
  • platform/audio/gstreamer/FFTFrameGStreamer.cpp:

(WebCore::FFTFrame::FFTFrame):

  • platform/efl/ScrollbarEfl.cpp:

(ScrollbarEfl::updateThumbPositionAndProportion):

  • platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::ANGLEWebKitBridge::compileShaderSource):

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::texImage2DResourceSafe):

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

  • platform/graphics/blackberry/LayerTexture.cpp:
  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::getDirtyRects):

  • platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/gpu/Texture.cpp:

(WebCore::Texture::updateSubRect):

  • platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::HarfBuzzShaper::setNormalizedBuffer):

  • platform/graphics/harfbuzz/HarfBuzzShaper.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getShaderInfoLog):

  • platform/graphics/opentype/OpenTypeSanitizer.cpp:
  • platform/graphics/texmap/TextureMapperGL.cpp:
  • platform/graphics/wince/SharedBitmap.cpp:

(WebCore::SharedBitmap::SharedBitmap):
(WebCore::SharedBitmap::to16bit):

  • platform/graphics/wince/SharedBitmap.h:
  • platform/image-decoders/blackberry/JPEGImageDecoder.cpp:

(WebCore::ImageReader::decode):

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageReader::createRowBuffer):

  • platform/win/ContextMenuWin.cpp:

(WebCore::ContextMenu::getContextMenuItems):

  • platform/win/LoggingWin.cpp:

(WebCore::logLevelString):

  • plugins/PluginPackage.cpp:
  • plugins/blackberry/PluginViewBlackBerry.cpp:

(WebCore::PluginView::handleTouchEvent):

  • plugins/win/PluginPackageWin.cpp:

(WebCore::PluginPackage::fetchInfo):

5:10 PM Changeset in webkit [156014] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r156001.
http://trac.webkit.org/changeset/156001
https://bugs.webkit.org/show_bug.cgi?id=121529

Broke API tests (Requested by ap on #webkit).

  • platform/mac/HTMLConverter.h:
  • platform/mac/HTMLConverter.mm:

(WebDefaultFont):
(_fontForNameAndSize):
(+[WebHTMLConverter defaultParagraphStyle]):
(-[WebHTMLConverter _computedStyleForElement:]):
(-[WebHTMLConverter _specifiedStyleForElement:]):
(-[WebHTMLConverter _computedStringForNode:property:]):
(-[WebHTMLConverter _stringForNode:property:]):
(-[WebHTMLConverter _getComputedFloat:forNode:property:]):
(-[WebHTMLConverter _getFloat:forNode:property:]):
(_colorForRGBColor):
(_shadowForShadowStyle):
(-[WebHTMLConverter _elementIsBlockLevel:]):
(-[WebHTMLConverter _elementHasOwnBackgroundColor:]):
(-[WebHTMLConverter _computedColorForNode:property:]):
(-[WebHTMLConverter _colorForNode:property:]):
(-[WebHTMLConverter _computedAttributesForElement:]):
(-[WebHTMLConverter _attributesForElement:]):
(-[WebHTMLConverter _newParagraphForElement:tag:allowEmpty:suppressTrailingSpace:]):
(-[WebHTMLConverter _newLineForElement:]):
(-[WebHTMLConverter _newTabForElement:]):
(-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
(-[WebHTMLConverter _addQuoteForElement:opening:level:]):
(-[WebHTMLConverter _addValue:forElement:]):
(-[WebHTMLConverter _fillInBlock:forElement:backgroundColor:extraMargin:extraPadding:isTable:]):
(_dateForString):
(_colCompare):
(-[WebHTMLConverter _enterElement:tag:display:]):
(-[WebHTMLConverter _addTableForElement:]):
(-[WebHTMLConverter _addTableCellForElement:]):
(-[WebHTMLConverter _processElement:tag:display:depth:]):
(-[WebHTMLConverter _addMarkersToList:range:]):
(-[WebHTMLConverter _exitElement:tag:display:depth:startIndex:]):
(-[WebHTMLConverter _processText:]):
(-[WebHTMLConverter _traverseNode:depth:embedded:]):
(-[WebHTMLConverter _traverseFooterNode:depth:]):
(-[WebHTMLConverter _loadFromDOMRange]):
(-[WebHTMLConverter dealloc]):
(-[WebHTMLConverter init]):
(-[WebHTMLConverter initWithDOMRange:]):
(-[WebHTMLConverter attributedString]):
(+[WebHTMLConverter editingAttributedStringFromRange:]):
(fileWrapperForElement):

4:24 PM Changeset in webkit [156013] by ap@apple.com
  • 1 edit
    4 deletes in trunk/LayoutTests

Removed some Lion specific results - these tests are failing on Lion bots despite these,
and it looks like Lion now matches cross-platform results.

  • platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Removed.
  • platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Removed.
  • platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Removed.
  • platform/mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Removed.
4:12 PM Changeset in webkit [156012] by ap@apple.com
  • 2 edits in trunk/LayoutTests

compositing/images/positioned-image-content-rect.html is failing on some bots
https://bugs.webkit.org/show_bug.cgi?id=121526

  • platform/mac/TestExpectations: Marked as failing or passing for now, should

be fixed with upcoming color management improvements.

4:08 PM Changeset in webkit [156011] by commit-queue@webkit.org
  • 24 edits in trunk

AX: Mac AXARIABusy should be AXElementBusy (not ARIA specific)
https://bugs.webkit.org/show_bug.cgi?id=121442

Patch by Samuel White <Samuel White> on 2013-09-17
Reviewed by Chris Fleizach.

Source/WebCore:

No new tests, changed AXARIABusy attribute to AXElementBusy to uncouple the concept of busy with
the aria-busy attribute. This will allow us to expand on the definition of busy moving forward.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

Mac platform attribute name change only (AXARIABusy => AXElementBusy). Updated existing tests using this attribute.

  • accessibility/transformed-element-expected.txt:
  • platform/mac/accessibility/aria-columnrowheaders-expected.txt:
  • platform/mac/accessibility/aria-liveregions-attributes-expected.txt:
  • platform/mac/accessibility/aria-liveregions-attributes.html:
  • platform/mac/accessibility/bounds-for-range-expected.txt:
  • platform/mac/accessibility/document-attributes-expected.txt:
  • platform/mac/accessibility/document-links-expected.txt:
  • platform/mac/accessibility/image-link-expected.txt:
  • platform/mac/accessibility/image-map2-expected.txt:
  • platform/mac/accessibility/internal-link-anchors-expected.txt:
  • platform/mac/accessibility/internal-link-anchors2-expected.txt:
  • platform/mac/accessibility/lists-expected.txt:
  • platform/mac/accessibility/plugin-expected.txt:
  • platform/mac/accessibility/table-attributes-expected.txt:
  • platform/mac/accessibility/table-cell-spans-expected.txt:
  • platform/mac/accessibility/table-cells-expected.txt:
  • platform/mac/accessibility/table-detection-expected.txt:
  • platform/mac/accessibility/table-one-cell-expected.txt:
  • platform/mac/accessibility/table-sections-expected.txt:
  • platform/mac/accessibility/table-with-aria-role-expected.txt:
  • platform/mac/accessibility/table-with-rules-expected.txt:
3:48 PM Changeset in webkit [156010] by msaboff@apple.com
  • 2 edits in trunk/Tools

Unreviewed typo fix after r155999

Changed en_US.UTB-8 to en_US.UTF-8

  • Scripts/run-javascriptcore-tests:
3:32 PM Changeset in webkit [156009] by akling@apple.com
  • 18 edits in trunk/Source

Pack create_hash_table tables better.
<https://webkit.org/b/121517>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Reduces JavaScriptCore binary size by 4648 bytes.

  • create_hash_table:
  • runtime/Lookup.h:

Reorder HashTableValue members to avoid unnecessary padding.

Source/WebCore:

Reduces WebCore binary size by 72744 bytes.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHashTable):

Updated for new HashTableValue member order.

  • bindings/scripts/test/JS/*:

Rebaselined bindings tests.

3:27 PM Changeset in webkit [156008] by Simon Fraser
  • 2 edits
    1 copy in trunk/LayoutTests

Rebaseline a test.

  • platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt: Copied from LayoutTests/platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt.
  • platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
3:27 PM Changeset in webkit [156007] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Windows] Adjust test list further to make the bots green.

  • platform/win/TestExpectations:
3:07 PM Changeset in webkit [156006] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt] Add FlowThreadController.h to Target.pri
https://bugs.webkit.org/show_bug.cgi?id=121516

Reviewed by Dirk Schulze.

No new tests, no behavior change.

  • Target.pri:
3:03 PM Changeset in webkit [156005] by ap@apple.com
  • 2 edits in trunk/LayoutTests

ScriptProcessorNode is garbage collected while still active if unreachable (breaks
webaudio/javascriptaudionode.html test)
https://bugs.webkit.org/show_bug.cgi?id=112521

2:58 PM Changeset in webkit [156004] by andersca@apple.com
  • 115 edits in trunk/Source

Stop explicitly using PassOwnPtr in WebCore/html
https://bugs.webkit.org/show_bug.cgi?id=121511

Reviewed by Andreas Kling.

Source/WebCore:

  • dom/ElementRareData.h:

(WebCore::ElementRareData::setClassList):

  • html/ButtonInputType.cpp:

(WebCore::ButtonInputType::create):

  • html/ButtonInputType.h:
  • html/CheckboxInputType.cpp:

(WebCore::CheckboxInputType::create):
(WebCore::CheckboxInputType::willDispatchClick):

  • html/CheckboxInputType.h:
  • html/ClassList.cpp:

(WebCore::ClassList::create):

  • html/ClassList.h:
  • html/ColorInputType.cpp:

(WebCore::ColorInputType::create):

  • html/ColorInputType.h:
  • html/DateInputType.cpp:

(WebCore::DateInputType::create):

  • html/DateInputType.h:
  • html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::create):

  • html/DateTimeInputType.h:
  • html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::create):

  • html/DateTimeLocalInputType.h:
  • html/EmailInputType.cpp:

(WebCore::EmailInputType::create):

  • html/EmailInputType.h:
  • html/FileInputType.cpp:

(WebCore::FileInputType::create):

  • html/FileInputType.h:
  • html/FormAssociatedElement.cpp:

(WebCore::FormAttributeTargetObserver::create):

  • html/FormController.cpp:

(WebCore::SavedFormState::create):
(WebCore::SavedFormState::deserialize):
(WebCore::FormKeyGenerator::create):
(WebCore::FormController::createSavedFormStateMap):

  • html/FormController.h:

(WebCore::FormController::create):

  • html/HTMLInputElement.cpp:

(WebCore::ListAttributeTargetObserver::create):

  • html/HiddenInputType.cpp:

(WebCore::HiddenInputType::create):

  • html/HiddenInputType.h:
  • html/ImageInputType.cpp:

(WebCore::ImageInputType::create):

  • html/ImageInputType.h:
  • html/InputType.cpp:

(WebCore::InputType::create):
(WebCore::InputType::createText):
(WebCore::InputType::willDispatchClick):

  • html/InputType.h:
  • html/MonthInputType.cpp:

(WebCore::MonthInputType::create):

  • html/MonthInputType.h:
  • html/NumberInputType.cpp:

(WebCore::NumberInputType::create):

  • html/NumberInputType.h:
  • html/PasswordInputType.cpp:

(WebCore::PasswordInputType::create):

  • html/PasswordInputType.h:
  • html/PublicURLManager.h:

(WebCore::PublicURLManager::create):

  • html/RadioInputType.cpp:

(WebCore::RadioInputType::create):
(WebCore::RadioInputType::willDispatchClick):

  • html/RadioInputType.h:
  • html/RangeInputType.cpp:

(WebCore::RangeInputType::create):

  • html/RangeInputType.h:
  • html/ResetInputType.cpp:

(WebCore::ResetInputType::create):

  • html/ResetInputType.h:
  • html/SearchInputType.cpp:

(WebCore::SearchInputType::create):

  • html/SearchInputType.h:
  • html/SubmitInputType.cpp:

(WebCore::SubmitInputType::create):

  • html/SubmitInputType.h:
  • html/TelephoneInputType.cpp:

(WebCore::TelephoneInputType::create):

  • html/TelephoneInputType.h:
  • html/TextInputType.cpp:

(WebCore::TextInputType::create):

  • html/TextInputType.h:
  • html/TimeInputType.cpp:

(WebCore::TimeInputType::create):

  • html/TimeInputType.h:
  • html/URLInputType.cpp:

(WebCore::URLInputType::create):

  • html/URLInputType.h:
  • html/ValidationMessage.cpp:

(WebCore::ValidationMessage::create):

  • html/ValidationMessage.h:
  • html/ValidityState.h:

(WebCore::ValidityState::create):

  • html/WeekInputType.cpp:

(WebCore::WeekInputType::create):

  • html/WeekInputType.h:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::createCompositingBuffer):

  • html/canvas/CanvasRenderingContext2D.h:

(WebCore::CanvasRenderingContext2D::create):

  • html/canvas/EXTDrawBuffers.cpp:

(WebCore::EXTDrawBuffers::create):

  • html/canvas/EXTDrawBuffers.h:
  • html/canvas/EXTTextureFilterAnisotropic.cpp:

(WebCore::EXTTextureFilterAnisotropic::create):

  • html/canvas/EXTTextureFilterAnisotropic.h:
  • html/canvas/OESElementIndexUint.cpp:

(WebCore::OESElementIndexUint::create):

  • html/canvas/OESElementIndexUint.h:
  • html/canvas/OESStandardDerivatives.cpp:

(WebCore::OESStandardDerivatives::create):

  • html/canvas/OESStandardDerivatives.h:
  • html/canvas/OESTextureFloat.cpp:

(WebCore::OESTextureFloat::create):

  • html/canvas/OESTextureFloat.h:
  • html/canvas/OESTextureHalfFloat.cpp:

(WebCore::OESTextureHalfFloat::create):

  • html/canvas/OESTextureHalfFloat.h:
  • html/canvas/OESVertexArrayObject.cpp:

(WebCore::OESVertexArrayObject::create):

  • html/canvas/OESVertexArrayObject.h:
  • html/canvas/WebGLCompressedTextureATC.cpp:

(WebCore::WebGLCompressedTextureATC::create):

  • html/canvas/WebGLCompressedTextureATC.h:
  • html/canvas/WebGLCompressedTexturePVRTC.cpp:

(WebCore::WebGLCompressedTexturePVRTC::create):

  • html/canvas/WebGLCompressedTexturePVRTC.h:
  • html/canvas/WebGLCompressedTextureS3TC.cpp:

(WebCore::WebGLCompressedTextureS3TC::create):

  • html/canvas/WebGLCompressedTextureS3TC.h:
  • html/canvas/WebGLDebugRendererInfo.cpp:

(WebCore::WebGLDebugRendererInfo::create):

  • html/canvas/WebGLDebugRendererInfo.h:
  • html/canvas/WebGLDebugShaders.cpp:

(WebCore::WebGLDebugShaders::create):

  • html/canvas/WebGLDebugShaders.h:
  • html/canvas/WebGLDepthTexture.cpp:

(WebCore::WebGLDepthTexture::create):

  • html/canvas/WebGLDepthTexture.h:
  • html/canvas/WebGLLoseContext.cpp:

(WebCore::WebGLLoseContext::create):

  • html/canvas/WebGLLoseContext.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::create):

  • html/canvas/WebGLRenderingContext.h:
  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::resumeFrom):

  • html/parser/BackgroundHTMLParser.h:

(WebCore::BackgroundHTMLParser::create):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::validateSpeculations):
(WebCore::HTMLDocumentParser::discardSpeculationsAndResumeFrom):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::ElementRecord::ElementRecord):

  • html/parser/HTMLElementStack.h:

(WebCore::HTMLElementStack::ElementRecord::releaseNext):
(WebCore::HTMLElementStack::ElementRecord::setNext):

  • html/parser/HTMLMetaCharsetParser.h:

(WebCore::HTMLMetaCharsetParser::create):

  • html/parser/HTMLParserScheduler.h:

(WebCore::HTMLParserScheduler::create):

  • html/parser/HTMLParserThread.h:

(WebCore::HTMLParserThread::create):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):

  • html/parser/HTMLResourcePreloader.cpp:

(WebCore::HTMLResourcePreloader::preload):

  • html/parser/HTMLResourcePreloader.h:

(WebCore::PreloadRequest::create):

  • html/parser/HTMLScriptRunner.h:

(WebCore::HTMLScriptRunner::create):

  • html/parser/HTMLToken.h:

(WebCore::HTMLToken::releaseDoctypeData):

  • html/parser/HTMLTokenizer.h:

(WebCore::HTMLTokenizer::create):

  • html/parser/HTMLTreeBuilder.h:

(WebCore::HTMLTreeBuilder::create):

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterToken):

  • html/parser/XSSAuditor.h:
  • html/parser/XSSAuditorDelegate.h:

(WebCore::XSSInfo::create):

  • html/track/WebVTTParser.h:

(WebCore::WebVTTParser::create):

  • html/track/WebVTTTokenizer.h:

(WebCore::WebVTTTokenizer::create):

Source/WTF:

Make operator= work work for different types of OwnPtrs.

  • wtf/OwnPtr.h:
2:57 PM Changeset in webkit [156003] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG doesn't properly keep scope alive for op_put_to_scope
https://bugs.webkit.org/show_bug.cgi?id=121519

Reviewed by Michael Saboff.

This was a latent bug that can't actually occur in ToT. It was uncovered by causing slow
path calls in the baseline JIT for op_put_to_scope in places where we couldn't before (but
which were necessary for gen GC).

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

2:48 PM Changeset in webkit [156002] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Web Inspector: inspector/storage-panel-dom-storage-update.html is flakey on the bots
https://bugs.webkit.org/show_bug.cgi?id=120544

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:

Marking as such again.

2:48 PM Changeset in webkit [156001] by enrica@apple.com
  • 3 edits in trunk/Source/WebCore

Upstream changes to WebHTMLConverter to support HTML
to NSAttributedString conversion on both iOS and OS X.

Reviewed by Benjamin Poulain.

  • platform/mac/HTMLConverter.h:
  • platform/mac/HTMLConverter.mm:

(WebDefaultFont):
(_fontForNameAndSize):
(+[WebHTMLConverter defaultParagraphStyle]):
(-[WebHTMLConverter _computedStyleForElement:]):
(-[WebHTMLConverter _specifiedStyleForElement:]):
(-[WebHTMLConverter _computedStringForNode:property:]):
(-[WebHTMLConverter _stringForNode:property:]):
(-[WebHTMLConverter _getComputedFloat:forNode:property:]):
(-[WebHTMLConverter _getFloat:forNode:property:]):
(_NSFirstPathForDirectoriesInDomains):
(_NSSystemLibraryPath):
(-[WebHTMLConverter _webKitBundle]):
(_colorForRGBColor):
(_shadowForShadowStyle):
(-[WebHTMLConverter _elementIsBlockLevel:]):
(-[WebHTMLConverter _elementHasOwnBackgroundColor:]):
(-[WebHTMLConverter _computedColorForNode:property:]):
(-[WebHTMLConverter _colorForNode:property:]):
(-[WebHTMLConverter _computedAttributesForElement:]):
(-[WebHTMLConverter _attributesForElement:]):
(-[WebHTMLConverter _newParagraphForElement:tag:allowEmpty:suppressTrailingSpace:]):
(-[WebHTMLConverter _newLineForElement:]):
(-[WebHTMLConverter _newTabForElement:]):
(-[WebHTMLConverter _WebMessageDocumentClass]):
(-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
(-[WebHTMLConverter _addQuoteForElement:opening:level:]):
(-[WebHTMLConverter _addValue:forElement:]):
(-[WebHTMLConverter _fillInBlock:forElement:backgroundColor:extraMargin:extraPadding:isTable:]):
(_dateForString):
(_colCompare):
(-[WebHTMLConverter _processMetaElementWithName:content:]):
(-[WebHTMLConverter _processHeadElement:]):
(-[WebHTMLConverter _enterElement:tag:display:embedded:]):
(-[WebHTMLConverter _addTableForElement:]):
(-[WebHTMLConverter _addTableCellForElement:]):
(-[WebHTMLConverter _processElement:tag:display:depth:]):
(-[WebHTMLConverter _addMarkersToList:range:]):
(-[WebHTMLConverter _exitElement:tag:display:depth:startIndex:]):
(-[WebHTMLConverter _processText:]):
(-[WebHTMLConverter _traverseNode:depth:embedded:]):
(-[WebHTMLConverter _traverseFooterNode:depth:]):
(-[WebHTMLConverter _loadFromDOMRange]):
(-[WebHTMLConverter dealloc]):
(-[WebHTMLConverter init]):
(-[WebHTMLConverter initWithDOMRange:]):
(-[WebHTMLConverter attributedString]):
(+[WebHTMLConverter editingAttributedStringFromRange:]):

2:46 PM Changeset in webkit [156000] by weinig@apple.com
  • 7 edits in trunk/Source

Add make_unique and start using it
https://bugs.webkit.org/show_bug.cgi?id=121523

Reviewed by Anders Carlsson.

../WebCore:

  • html/HTMLAreaElement.h:
  • html/HTMLFrameSetElement.h:
  • platform/Length.cpp:

(WebCore::newCoordsArray):
(WebCore::newLengthArray):

  • platform/Length.h:

Switch off OwnArrayPtr to std::unique_ptr<T[]> and make use of make_unique.

../WTF:

  • wtf/StdLibExtras.h:

(std::make_unique):
Add temporary implementation of std::make_unique that we can use until our standard
libraries have support for it.

2:44 PM Changeset in webkit [155999] by msaboff@apple.com
  • 2 edits in trunk/Tools

run-jsc-stress-tests fails with ruby version 2
https://bugs.webkit.org/show_bug.cgi?id=121521

Reviewed by Jessie Berlin.

Explicitly set LANG to en_US.UTB-8 before starting run-jsc-stress-tests.

  • Scripts/run-javascriptcore-tests:
2:33 PM Changeset in webkit [155998] by Simon Fraser
  • 33 edits
    13 copies
    9 adds
    1 delete in trunk

Hardware accelerated CSS transitions appear pixelated when scaled up using transform
https://bugs.webkit.org/show_bug.cgi?id=27684
<rdar://problem/6134606>

Source/WebCore:

Reviewed by Dean Jackson.

Take transforms and animations into account when computing the contentsScale
for a layer, so that scaled-up layers remain sharp most of the time.

In its recursiveCommitChanges() tree walk, GraphicsLayerCA now tracks
a root-relative transform, and extracts from that transform the X and Y
scales which it uses to scale the backing store.

If the layer has transform animations on it, we keep around
a transformation matrix for the animation endpoints (or keyframes),
pick up the state that has the larger impact on the root-relative scale,
and use that as the layer's transform, and the transform when recursing
over descendants.

Tests: compositing/contents-scale/animating.html

compositing/contents-scale/scaled-ancestor.html
compositing/contents-scale/simple-scale.html
compositing/contents-scale/z-translate.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::maxScaleFromTransform): Decompose the transform if necesssary
to extract the X and Y scale components.
(WebCore::GraphicsLayerCA::GraphicsLayerCA): Initialize m_rootRelativeScaleFactor.
(WebCore::GraphicsLayerCA::flushCompositingState): Supply a TransformationMatrix
for the root of the recursion.
(WebCore::GraphicsLayerCA::layerTransform): This code was factored out of
computeVisibleRect(), and optionally takes a custom transform.
(WebCore::GraphicsLayerCA::computeVisibleRect): Use the layerTransform() function.
(WebCore::GraphicsLayerCA::updateRootRelativeScale): Given a transform from the root,
find the max scale factor by multiplying the various animation endpoint matrices and picking
the one with the biggest impact on scale. Use this to set m_rootRelativeScaleFactor, and
set the flag to say that we need to update contentsScale.
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): After updating
animations, call updateRootRelativeScale() to update m_rootRelativeScaleFactor.
(WebCore::GraphicsLayerCA::updateAnimations): We have a side table of animation name to
TransformationMatrix, so figure out which entries can be removed from that side table,
and remove them.
(WebCore::GraphicsLayerCA::setAnimationOnLayer):
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations): Store the matrices for
animation endpoints/keyframes in the m_animationTransforms side table. We don't store
them directly in LayerPropertyAnimation because we just want the final matrix for
a transform list, and using a side table makes ownership easier to manage.
(WebCore::GraphicsLayerCA::getTransformFromAnimationsWithMaxScaleImpact):
goes through the matrices for the running animation endpoints/keyframes, and
multiplies each with the transform up to this layer to find the matrix with the
larger impact on scale.
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints): Returns a vector
of TransformationMatrix for the from and to states.
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes): Returns a vector
of TransformationMatrix for the keyframes.
(WebCore::GraphicsLayerCA::updateContentsScale): Include m_rootRelativeScaleFactor in the
scale factor computation.
(WebCore::GraphicsLayerCA::dumpAdditionalProperties): If we're dumping visible rects,
also dump the contentsScale. Convenient at these are useful to look at together, and I didn't
want to pollute Internals with yet more flags.

  • platform/graphics/ca/GraphicsLayerCA.h:

(WebCore::GraphicsLayerCA::LayerPropertyAnimation::LayerPropertyAnimation): Formatting.

LayoutTests:

Reviewed by Dean Jackson.

New tests that dump contentsScale under various scaling scenarios:

  • compositing/contents-scale/animating-expected.txt: Added.
  • compositing/contents-scale/animating.html: Added.
  • compositing/contents-scale/scaled-ancestor-expected.txt: Added.
  • compositing/contents-scale/scaled-ancestor.html: Added.
  • compositing/contents-scale/simple-scale-expected.txt: Added.
  • compositing/contents-scale/simple-scale.html: Added.
  • compositing/contents-scale/z-translate-expected.txt: Added.
  • compositing/contents-scale/z-translate.html: Added.

These tests had Mac-specific results (which include visible rects and now
contents scale) in the cross-platform directory, so cleaned up the cross-platform
results and moved the Mac results to platform-mac.

  • compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt:
  • compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt:
  • compositing/visible-rect/2d-transformed-expected.txt:
  • compositing/visible-rect/3d-transform-style-expected.txt:
  • compositing/visible-rect/3d-transformed-expected.txt:
  • compositing/visible-rect/animated-expected.txt:
  • compositing/visible-rect/animated-from-none-expected.txt:
  • compositing/visible-rect/clipped-by-viewport-expected.txt:
  • compositing/visible-rect/clipped-visible-rect-expected.txt:
  • compositing/visible-rect/flipped-preserve-3d-expected.txt:
  • compositing/visible-rect/iframe-and-layers-expected.txt:
  • compositing/visible-rect/nested-transform-expected.txt:
  • compositing/visible-rect/scrolled-expected.txt:
  • platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
  • platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
  • platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
  • platform/mac/compositing/visible-rect/2d-transformed-expected.txt: Copied from LayoutTests/compositing/visible-rect/2d-transformed-expected.txt.
  • platform/mac/compositing/visible-rect/3d-transform-style-expected.txt: Copied from LayoutTests/compositing/visible-rect/3d-transform-style-expected.txt.
  • platform/mac/compositing/visible-rect/3d-transformed-expected.txt: Copied from LayoutTests/compositing/visible-rect/3d-transformed-expected.txt.
  • platform/mac/compositing/visible-rect/animated-expected.txt: Copied from LayoutTests/compositing/visible-rect/animated-expected.txt.
  • platform/mac/compositing/visible-rect/animated-from-none-expected.txt: Copied from LayoutTests/compositing/visible-rect/animated-from-none-expected.txt.
  • platform/mac/compositing/visible-rect/clipped-by-viewport-expected.txt: Copied from LayoutTests/compositing/visible-rect/clipped-by-viewport-expected.txt.
  • platform/mac/compositing/visible-rect/clipped-visible-rect-expected.txt: Copied from LayoutTests/compositing/visible-rect/clipped-visible-rect-expected.txt.
  • platform/mac/compositing/visible-rect/flipped-preserve-3d-expected.txt: Copied from LayoutTests/compositing/visible-rect/flipped-preserve-3d-expected.txt.
  • platform/mac/compositing/visible-rect/iframe-and-layers-expected.txt: Copied from LayoutTests/compositing/visible-rect/iframe-and-layers-expected.txt.
  • platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
  • platform/mac/compositing/visible-rect/nested-transform-expected.txt: Copied from LayoutTests/compositing/visible-rect/nested-transform-expected.txt.
  • platform/mac/compositing/visible-rect/scrolled-expected.txt: Copied from LayoutTests/compositing/visible-rect/scrolled-expected.txt.
2:07 PM Changeset in webkit [155997] by Lucas Forschler
  • 5 edits in branches/safari-537.60-branch/Source/WebCore

Merge 154391.

2:02 PM Changeset in webkit [155996] by Lucas Forschler
  • 3 edits in branches/safari-537.60-branch/WebKitLibraries

Merge 154390.

1:56 PM Changeset in webkit [155995] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Don't GC while OSR compiling
https://bugs.webkit.org/show_bug.cgi?id=121513

Reviewed by Mark Hahnenberg.

Fixes some rare crashes that I see in ConservativeRoots, while in a GC from OSR exit
compilation.

  • dfg/DFGOSRExitCompiler.cpp:
  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileFTLOSRExit):

1:54 PM Changeset in webkit [155994] by commit-queue@webkit.org
  • 21 edits
    14 deletes in trunk

Unreviewed, rolling out r155977.
http://trac.webkit.org/changeset/155977
https://bugs.webkit.org/show_bug.cgi?id=121515

Broke over a dozen tests on Mac WK2 (Requested by ap on
#webkit).

Source/WebCore:

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::flushCompositingState):
(WebCore::GraphicsLayerCA::computeVisibleRect):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateAnimations):
(WebCore::GraphicsLayerCA::setAnimationOnLayer):
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerCA::updateContentsScale):
(WebCore::GraphicsLayerCA::dumpAdditionalProperties):

  • platform/graphics/ca/GraphicsLayerCA.h:

(WebCore::GraphicsLayerCA::LayerPropertyAnimation::LayerPropertyAnimation):

LayoutTests:

  • compositing/contents-scale/animating-expected.txt: Removed.
  • compositing/contents-scale/animating.html: Removed.
  • compositing/contents-scale/scaled-ancestor-expected.txt: Removed.
  • compositing/contents-scale/scaled-ancestor.html: Removed.
  • compositing/contents-scale/simple-scale-expected.txt: Removed.
  • compositing/contents-scale/simple-scale.html: Removed.
  • compositing/contents-scale/z-translate-expected.txt: Removed.
  • compositing/contents-scale/z-translate.html: Removed.
  • compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt:
  • compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt:
  • compositing/visible-rect/2d-transformed-expected.txt:
  • compositing/visible-rect/3d-transform-style-expected.txt:
  • compositing/visible-rect/3d-transformed-expected.txt:
  • compositing/visible-rect/animated-expected.txt:
  • compositing/visible-rect/animated-from-none-expected.txt:
  • compositing/visible-rect/clipped-by-viewport-expected.txt:
  • compositing/visible-rect/clipped-visible-rect-expected.txt:
  • compositing/visible-rect/flipped-preserve-3d-expected.txt:
  • compositing/visible-rect/iframe-and-layers-expected.txt:
  • compositing/visible-rect/nested-transform-expected.txt:
  • compositing/visible-rect/scrolled-expected.txt:
  • platform/mac/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt: Removed.
  • platform/mac/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt: Removed.
  • platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
  • platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
  • platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
  • platform/mac/compositing/visible-rect/2d-transformed-expected.txt: Removed.
  • platform/mac/compositing/visible-rect/3d-transform-style-expected.txt: Removed.
  • platform/mac/compositing/visible-rect/3d-transformed-expected.txt: Removed.
  • platform/mac/compositing/visible-rect/animated-expected.txt: Removed.
  • platform/mac/compositing/visible-rect/animated-from-none-expected.txt: Removed.
  • platform/mac/compositing/visible-rect/clipped-by-viewport-expected.txt: Removed.
  • platform/mac/compositing/visible-rect/clipped-visible-rect-expected.txt: Removed.
  • platform/mac/compositing/visible-rect/flipped-preserve-3d-expected.txt: Removed.
  • platform/mac/compositing/visible-rect/iframe-and-layers-expected.txt: Removed.
  • platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
  • platform/mac/compositing/visible-rect/nested-transform-expected.txt: Removed.
  • platform/mac/compositing/visible-rect/scrolled-expected.txt: Removed.
1:53 PM Changeset in webkit [155993] by Lucas Forschler
  • 3 edits in branches/safari-537-branch/WebKitLibraries

Rollout r155990

1:36 PM Changeset in webkit [155992] by eric.carlson@apple.com
  • 17 edits
    10 adds in trunk

MediaStream API: Changing the device enumeration to be async
https://bugs.webkit.org/show_bug.cgi?id=120883

Reviewed by Darin Adler.

Source/WebCore:

Parts merged from https://chromium.googlesource.com/chromium/blink/+/40a96080a1531e50de4eb84571c7dc9fb321ece5
and https://chromium.googlesource.com/chromium/blink/+/ff783a23bb1add588971a8187048a305cf485121
by Tommy Widenflycht.

Test: fast/mediastream/MediaStreamTrack-getSources.html

  • CMakeLists.txt: Added new files.
  • DerivedSources.make: Ditto.
  • GNUmakefile.list.am: Ditto.
  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::kind): ASCIILiteral -> NeverDestroyed<AtomicString>.
(WebCore::MediaStreamTrack::readyState): Ditto.
(WebCore::MediaStreamTrack::getSources): New.

  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/MediaStreamTrack.idl:
  • Modules/mediastream/MediaStreamTrackSourcesCallback.h: Added.
  • Modules/mediastream/MediaStreamTrackSourcesCallback.idl: Added.
  • Modules/mediastream/MediaStreamTrackSourcesRequest.cpp: Added.
  • Modules/mediastream/MediaStreamTrackSourcesRequest.h: Added.
  • Modules/mediastream/SourceInfo.cpp: Added.
  • Modules/mediastream/SourceInfo.h: Added.
  • Modules/mediastream/SourceInfo.idl: Added.
  • WebCore.xcodeproj/project.pbxproj: Add new files.
  • bindings/js/JSDOMBinding.h: Add toJS templates for Vector<T> and Vector<RefPtr<T>>.
  • platform/mediastream/MediaStreamCenter.h: Add prototype for getMediaStreamTrackSources.
  • platform/mediastream/MediaStreamTrackSourcesRequestClient.h: Added.
  • platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:

(WebCore::MediaStreamCenterMac::getMediaStreamTrackSources): Added.

  • platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:
  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:

(WebCore::MediaStreamCenterMac::getMediaStreamTrackSources): Added

  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
  • platform/mediastream/mac/MediaStreamCenterMac.cpp:

(WebCore::MediaStreamCenterMac::getMediaStreamTrackSources): Added.

  • platform/mediastream/mac/MediaStreamCenterMac.h:

LayoutTests:

  • fast/mediastream/MediaStreamTrack-getSources-expected.txt: Added.
  • fast/mediastream/MediaStreamTrack-getSources.html: Added.
1:30 PM Changeset in webkit [155991] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

lUnreviewed, rolling out r155976.
http://trac.webkit.org/changeset/155976
https://bugs.webkit.org/show_bug.cgi?id=121512

Broke a test, needs cleanup (Requested by ap_ on #webkit).

Patch by Commit Queue <commit-queue@webkit.org> on 2013-09-17

  • platform/mac/accessibility/element-busy-changed-expected.txt: Removed.
  • platform/mac/accessibility/element-busy-changed.html: Removed.
1:23 PM Changeset in webkit [155990] by Lucas Forschler
  • 3 edits in branches/safari-537-branch/WebKitLibraries

Windows build fix after r154914.

1:10 PM Changeset in webkit [155989] by commit-queue@webkit.org
  • 5 edits
    2 deletes in trunk

Unreviewed, rolling out r155976.
http://trac.webkit.org/changeset/155976
https://bugs.webkit.org/show_bug.cgi?id=121512

Broke a test, needs cleanup (Requested by ap_ on #webkit).

Source/WebCore:

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAttributeChanged):

  • accessibility/AXObjectCache.h:
  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

LayoutTests:

  • platform/mac/accessibility/element-busy-changed-expected.txt: Removed.
  • platform/mac/accessibility/element-busy-changed.html: Removed.
1:06 PM Changeset in webkit [155988] by commit-queue@webkit.org
  • 8 edits
    15 adds
    1 delete in trunk

Improve srcset parser
https://bugs.webkit.org/show_bug.cgi?id=119423

Patch by Romain Perier <Romain Perier> on 2013-09-17
Reviewed by Benjamin Poulain.

Source/WebCore:

Added new tests and covered by existing ones.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::isHTMLSpaceOrComma): Add a new predicate function used by String::find()
to get the first space or comma character from the input string.
(WebCore::parseImagesWithScaleFromSrcSetAttribute): Add a new static function to parse
and extract images with scale from the srcset attribute. All valid candidates are
returned to the caller through a list. This parsing function also adds support
for data URI schemes as described by the specification.
(WebCore::bestFitSourceForImageAttributes): Remove intermediate arrays of string
when parsing. That is more efficient and avoids trashing the data cache
(varying between 20 and 65% faster depending of the amount of data)
The parser now walks along the attribute value and extracts the candidates directly.

LayoutTests:

  • fast/hidpi/image-srcset-data-srcset-invalid-inputs.html: Ensures that a various invalid form of data uri schemes are supported by the srcset attribute.
  • fast/hidpi/image-srcset-data-srcset-valid-inputs.html: Ensures that a various valid form of data uri schemes are supported by the srcset attribute.
  • fast/hidpi/image-srcset-data-srcset.html: Use comma instead of %.
  • fast/hidpi/image-srcset-fraction-1.5x.html: Added.
  • fast/hidpi/image-srcset-invalid-inputs-except-one.html: Missing srcset-helper.js. Adding more invalid cases.
  • fast/hidpi/image-srcset-invalid-inputs.html: Adding more invalid cases.
  • fast/hidpi/image-srcset-nomodifier.html: Updated output as behaviour changed for this case.
  • fast/hidpi/image-srcset-space-suffix-nomodifier.html: Ensures that a single candidate with no scale modifier is supported by the srcset attribute, even if a space is left at the end.
  • fast/hidpi/image-srcset-space-prefix-nomodifier.html: Ensures that a single candidate with no scale modifier is supported by the srcset attribute, even if a space is left at the beginning.
  • fast/hidpi/image-srcset-space-surrounded-nomodifier.html: Ensures that a single candidate with no scale modifier is supported by the srcset attribute, even if it is surrounded by spaces.
  • fast/hidpi/image-srcset-data-escaped-srcset.html: Ensures that data uri schemes with escaped characters are supported by the srcset attribute.
1:00 PM Changeset in webkit [155987] by Csaba Osztrogonác
  • 7 edits in trunk/Source/WebKit2

Buildfix for !ENABLE(CUSTOM_PROTOCOLS) platforms
https://bugs.webkit.org/show_bug.cgi?id=121417

Reviewed by Alexey Proskuryakov.

Original patch by Balazs Kelemen <kbalazs@webkit.org>.

  • CMakeLists.txt: Add CustomProtocolManagerProxy.messages.in.
  • DerivedSources.pri: Add CustomProtocolManagerProxy.messages.in.
  • GNUmakefile.am: Add CustomProtocolManagerProxy.messages.in.
  • GNUmakefile.list.am: Add CustomProtocolManagerProxyMessages.h and CustomProtocolManagerProxyMessageReceiver.cpp.
  • NetworkProcess/NetworkProcess.cpp: Add the missing ENABLE(CUSTOM_PROTOCOLS) guard.

(WebKit::NetworkProcess::NetworkProcess):

  • UIProcess/WebProcessProxy.cpp: Remove the unnecessary conditional include.
12:41 PM Changeset in webkit [155986] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge 155985 - [GTK] Test /webkit2/WebKitWebInspectorServer/test-open-debugging-session times out after r155714
https://bugs.webkit.org/show_bug.cgi?id=121383

Reviewed by Carlos Garcia Campos.

  • UIProcess/API/gtk/tests/TestInspectorServer.cpp:

(openRemoteDebuggingSession): use the page contents' to check the remote debugging of the page
has been successfuly opened, as the title is no longer the same after the switch to the new
frontend.

12:27 PM Changeset in webkit [155985] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Test /webkit2/WebKitWebInspectorServer/test-open-debugging-session times out after r155714
https://bugs.webkit.org/show_bug.cgi?id=121383

Reviewed by Carlos Garcia Campos.

  • UIProcess/API/gtk/tests/TestInspectorServer.cpp:

(openRemoteDebuggingSession): use the page contents' to check the remote debugging of the page
has been successfuly opened, as the title is no longer the same after the switch to the new
frontend.

12:16 PM Changeset in webkit [155984] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after 155963.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::getStyleContext): use nullptr instead of 0.

12:06 PM Changeset in webkit [155983] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Windows] Disable a number of crashing tests to help the EWS system run more rapidly.
https://bugs.webkit.org/show_bug.cgi?id=121509

  • platform/win/TestExpectations:
12:05 PM Changeset in webkit [155982] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Make SVGTransform::valueAsString use StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=121498

Unreviewed typo fix, should address a regression on svg/dom/SVGViewSpec.html.

  • svg/SVGTransform.cpp: (WebCore::SVGTransform::valueAsString): "e" is totally

not the same as "f".

11:57 AM Changeset in webkit [155981] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Windows] Disable a number of failing tests to help the EWS system run more rapidly.

  • platform/win/TestExpectations:
11:39 AM Changeset in webkit [155980] by kov@webkit.org
  • 3 edits in releases/WebKitGTK/webkit-2.2/Source/WebInspectorUI

Merge 155966 - Clean up the Inspector's WebSocket code and prevent it from dropping messages.

https://bugs.webkit.org/show_bug.cgi?id=121391

Reviewed by Joseph Pecoraro.

  • UserInterface/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.initializeWebSocket): Added. Create the socket
and call _sendPendingMessagesToBackendIfNeeded.
(.WebInspector.InspectorFrontendHostStub.prototype.sendMessageToBackend): Store messages as pending
if the socket isn't ready yet. Call _sendPendingMessagesToBackendIfNeeded.
(.WebInspector.InspectorFrontendHostStub.prototype._sendPendingMessagesToBackendIfNeeded): Added.

  • UserInterface/Main.js:

(WebInspector._initializeWebSocketIfNeeded): Move socket creation to initializeWebSocket.

11:22 AM Changeset in webkit [155979] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] Unreviewed build fix after r155963.

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::evaluateScriptInIsolatedWorld): Pass nullptr rather than 0.

11:15 AM Changeset in webkit [155978] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit/win

[Windows] Speculative build fix after r155963

  • WebKitCOMAPI.cpp:

(classFactory): Use nullptr rather than 0 for HashMap.

11:12 AM Changeset in webkit [155977] by Simon Fraser
  • 21 edits
    13 copies
    9 adds in trunk

Hardware accelerated CSS transitions appear pixelated when scaled up using transform
https://bugs.webkit.org/show_bug.cgi?id=27684
<rdar://problem/6134606>

Source/WebCore:

Reviewed by Dean Jackson.

Take transforms and animations into account when computing the contentsScale
for a layer, so that scaled-up layers remain sharp most of the time.

In its recursiveCommitChanges() tree walk, GraphicsLayerCA now tracks
a root-relative transform, and extracts from that transform the X and Y
scales which it uses to scale the backing store.

If the layer has transform animations on it, we keep around
a transformation matrix for the animation endpoints (or keyframes),
pick up the state that has the larger impact on the root-relative scale,
and use that as the layer's transform, and the transform when recursing
over descendants.

Tests: compositing/contents-scale/animating.html

compositing/contents-scale/scaled-ancestor.html
compositing/contents-scale/simple-scale.html
compositing/contents-scale/z-translate.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::maxScaleFromTransform): Decompose the transform if necesssary
to extract the X and Y scale components.
(WebCore::GraphicsLayerCA::GraphicsLayerCA): Initialize m_rootRelativeScaleFactor.
(WebCore::GraphicsLayerCA::flushCompositingState): Supply a TransformationMatrix
for the root of the recursion.
(WebCore::GraphicsLayerCA::layerTransform): This code was factored out of
computeVisibleRect(), and optionally takes a custom transform.
(WebCore::GraphicsLayerCA::computeVisibleRect): Use the layerTransform() function.
(WebCore::GraphicsLayerCA::updateRootRelativeScale): Given a transform from the root,
find the max scale factor by multiplying the various animation endpoint matrices and picking
the one with the biggest impact on scale. Use this to set m_rootRelativeScaleFactor, and
set the flag to say that we need to update contentsScale.
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): After updating
animations, call updateRootRelativeScale() to update m_rootRelativeScaleFactor.
(WebCore::GraphicsLayerCA::updateAnimations): We have a side table of animation name to
TransformationMatrix, so figure out which entries can be removed from that side table,
and remove them.
(WebCore::GraphicsLayerCA::setAnimationOnLayer):
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations): Store the matrices for
animation endpoints/keyframes in the m_animationTransforms side table. We don't store
them directly in LayerPropertyAnimation because we just want the final matrix for
a transform list, and using a side table makes ownership easier to manage.
(WebCore::GraphicsLayerCA::getTransformFromAnimationsWithMaxScaleImpact):
goes through the matrices for the running animation endpoints/keyframes, and
multiplies each with the transform up to this layer to find the matrix with the
larger impact on scale.
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints): Returns a vector
of TransformationMatrix for the from and to states.
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes): Returns a vector
of TransformationMatrix for the keyframes.
(WebCore::GraphicsLayerCA::updateContentsScale): Include m_rootRelativeScaleFactor in the
scale factor computation.
(WebCore::GraphicsLayerCA::dumpAdditionalProperties): If we're dumping visible rects,
also dump the contentsScale. Convenient at these are useful to look at together, and I didn't
want to pollute Internals with yet more flags.

  • platform/graphics/ca/GraphicsLayerCA.h:

(WebCore::GraphicsLayerCA::LayerPropertyAnimation::LayerPropertyAnimation): Formatting.

LayoutTests:

Reviewed by Dean Jackson.

New tests that dump contentsScale under various scaling scenarios:

  • compositing/contents-scale/animating-expected.txt: Added.
  • compositing/contents-scale/animating.html: Added.
  • compositing/contents-scale/scaled-ancestor-expected.txt: Added.
  • compositing/contents-scale/scaled-ancestor.html: Added.
  • compositing/contents-scale/simple-scale-expected.txt: Added.
  • compositing/contents-scale/simple-scale.html: Added.
  • compositing/contents-scale/z-translate-expected.txt: Added.
  • compositing/contents-scale/z-translate.html: Added.

These tests had Mac-specific results (which include visible rects and now
contents scale) in the cross-platform directory, so cleaned up the cross-platform
results and moved the Mac results to platform-mac.

  • compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt:
  • compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt:
  • compositing/visible-rect/2d-transformed-expected.txt:
  • compositing/visible-rect/3d-transform-style-expected.txt:
  • compositing/visible-rect/3d-transformed-expected.txt:
  • compositing/visible-rect/animated-expected.txt:
  • compositing/visible-rect/animated-from-none-expected.txt:
  • compositing/visible-rect/clipped-by-viewport-expected.txt:
  • compositing/visible-rect/clipped-visible-rect-expected.txt:
  • compositing/visible-rect/flipped-preserve-3d-expected.txt:
  • compositing/visible-rect/iframe-and-layers-expected.txt:
  • compositing/visible-rect/nested-transform-expected.txt:
  • compositing/visible-rect/scrolled-expected.txt:
  • platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
  • platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
  • platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
  • platform/mac/compositing/visible-rect/2d-transformed-expected.txt: Copied from LayoutTests/compositing/visible-rect/2d-transformed-expected.txt.
  • platform/mac/compositing/visible-rect/3d-transform-style-expected.txt: Copied from LayoutTests/compositing/visible-rect/3d-transform-style-expected.txt.
  • platform/mac/compositing/visible-rect/3d-transformed-expected.txt: Copied from LayoutTests/compositing/visible-rect/3d-transformed-expected.txt.
  • platform/mac/compositing/visible-rect/animated-expected.txt: Copied from LayoutTests/compositing/visible-rect/animated-expected.txt.
  • platform/mac/compositing/visible-rect/animated-from-none-expected.txt: Copied from LayoutTests/compositing/visible-rect/animated-from-none-expected.txt.
  • platform/mac/compositing/visible-rect/clipped-by-viewport-expected.txt: Copied from LayoutTests/compositing/visible-rect/clipped-by-viewport-expected.txt.
  • platform/mac/compositing/visible-rect/clipped-visible-rect-expected.txt: Copied from LayoutTests/compositing/visible-rect/clipped-visible-rect-expected.txt.
  • platform/mac/compositing/visible-rect/flipped-preserve-3d-expected.txt: Copied from LayoutTests/compositing/visible-rect/flipped-preserve-3d-expected.txt.
  • platform/mac/compositing/visible-rect/iframe-and-layers-expected.txt: Copied from LayoutTests/compositing/visible-rect/iframe-and-layers-expected.txt.
  • platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
  • platform/mac/compositing/visible-rect/nested-transform-expected.txt: Copied from LayoutTests/compositing/visible-rect/nested-transform-expected.txt.
  • platform/mac/compositing/visible-rect/scrolled-expected.txt: Copied from LayoutTests/compositing/visible-rect/scrolled-expected.txt.
11:10 AM Changeset in webkit [155976] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

AX: Expose ARIA Busy Notifications
https://bugs.webkit.org/show_bug.cgi?id=121451

Patch by Samuel White <Samuel White> on 2013-09-17
Reviewed by Darin Adler.

Source/WebCore:

Added AXElementBusyChanged notification that posts when aria-busy is toggled. This
enables screen readers to detect busy states without polling the focused element.

Test: platform/mac/accessibility/element-busy-changed.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAttributeChanged):

  • accessibility/AXObjectCache.h:
  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

LayoutTests:

Added test to verify that elements post AXElementBusyChanged notifications when aria-busy is toggled.

  • platform/mac/accessibility/element-busy-changed-expected.txt: Added.
  • platform/mac/accessibility/element-busy-changed.html: Added.
11:10 AM Changeset in webkit [155975] by Antti Koivisto
  • 12 edits in trunk/Source/WebCore

Add isTextOrBR() and use it
https://bugs.webkit.org/show_bug.cgi?id=121506

Reviewed by Darin Adler.

It is a popular test.

  • dom/Document.cpp:

(WebCore::Document::updateHoverActiveState):

  • editing/Editor.cpp:

(WebCore::findFirstMarkable):

  • editing/TextIterator.cpp:

(WebCore::ignoresContainerClip):

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::logicalHeight):

  • rendering/InlineIterator.h:

(WebCore::isIteratorTarget):

  • rendering/RenderBlock.cpp:

(WebCore::InlineMinMaxIterator::next):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::layoutInlineChildren):

  • rendering/RenderCounter.cpp:

(WebCore::planCounter):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isTextOrBR):

  • rendering/RenderTreeAsText.cpp:

(WebCore::write):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::ascentAndDescentForBox):
(WebCore::RootInlineBox::verticalPositionForBox):

11:04 AM Changeset in webkit [155974] by Manuel Rego Casasnovas
  • 1 edit
    2 adds in trunk/LayoutTests

[CSS Regions] Layout Test for selection direction
https://bugs.webkit.org/show_bug.cgi?id=121501

Reviewed by Darin Adler.

Selection follows DOM tree, so the highlighted text in this test case is
the opposite to what the user is actually selecting. This was not
working properly from r139197 to r155058, so adding a Layout Test to
prevent future breaks. It is a reftest comparing regions and absolute
positions behavior.

  • fast/regions/selection-direction-expected.html: Added.
  • fast/regions/selection-direction.html: Added.
10:56 AM Changeset in webkit [155973] by andersca@apple.com
  • 2 edits in trunk/Tools

Fix a typo.

  • TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::TEST):

10:40 AM Changeset in webkit [155972] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

RenderBR should not be RenderText
https://bugs.webkit.org/show_bug.cgi?id=121221

Rubber-stamped by Andreas Kling.

Fix assertion in these tests:

fast/repaint/selection-rl.html
fast/writing-mode/horizontal-bt-replaced-selection.html
fast/writing-mode/vertical-rl-replaced-selection.html

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::nodeAtPoint):

10:20 AM Changeset in webkit [155971] by enrica@apple.com
  • 31 edits in trunk/Source

Remove unused function didSetSelectionTypesForPasteboard from EditorClient.
https://bugs.webkit.org/show_bug.cgi?id=121464

Reviewed by Darin Adler.

Source/WebCore:

This method was only implemented in WebEditorClient.mm for Mac where it was
calling a private delegate that is no longer in use.
This patch removes it for all the platforms.
I've also removed setTypes and writeAfterSettingTypes from the implementation
of the Pasteboard class for Mac.

  • editing/mac/EditorMac.mm:

(WebCore::Editor::writeSelectionToPasteboard): Now calls write instead of
setTypes and writeAfterSettingTypes.

  • loader/EmptyClients.h: Removed didSetSelectionTypesForPasteboard.
  • page/EditorClient.h: Ditto.
  • platform/Pasteboard.h: Removed setTypes and writeAfterSettingTypes.
  • platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::writeSelection): Removed call to didSetSelectionTypesForPasteboard.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::write): Added to replace setTypes and writeAfterSettingTypes.

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.cpp:
  • WebCoreSupport/EditorClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.cpp:
  • WebCoreSupport/EditorClientGtk.h:

Source/WebKit/mac:

This method was only implemented in WebEditorClient.mm for Mac where it was
calling a private delegate that is no longer in use.

  • DefaultDelegates/WebDefaultEditingDelegate.m:
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:
  • WebView/WebEditingDelegatePrivate.h:

Source/WebKit/qt:

  • WebCoreSupport/EditorClientQt.cpp:
  • WebCoreSupport/EditorClientQt.h:

Source/WebKit/win:

  • WebCoreSupport/WebEditorClient.cpp:
  • WebCoreSupport/WebEditorClient.h:

Source/WebKit/wince:

  • WebCoreSupport/EditorClientWinCE.cpp:
  • WebCoreSupport/EditorClientWinCE.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.h:
10:17 AM Changeset in webkit [155970] by Darin Adler
  • 6 edits in trunk/Source/WebCore

Further shrink table-populating code by making the tables read-only data and preventing inlining
https://bugs.webkit.org/show_bug.cgi?id=121468

Reviewed by Sam Weinig.

  • bindings/scripts/StaticString.pm:

(GenerateStrings): Eliminated the xxxImpl globals. We definitely did not need
globals for these, much less read-write data. Instead, write the expression at
each site where we need them.
(GenerateStringAsserts): This is one such site (see above).

  • css/CSSSelector.cpp:

(WebCore::populatePseudoTypeByNameMap): Mark this function NEVER_INLINE and
add static to make sure the table ends up in read-only data.

  • dom/make_names.pl:

(printDefinitions): Write the xxxImpl expression (see above).
(printFactoryCppFile): Ditto. Also mark the populate function NEVER_INLINE and
add static to make sure the table ends up in read-only data.
(printWrapperFactoryCppFile): Ditto.

  • html/HTMLElement.cpp:

(WebCore::populateEventNameForAttributeLocalNameMap): Mark this function
NEVER_INLINE and add static to makes sure the table ends up in read-only data.

  • platform/text/UnicodeRange.cpp: Added a const to make this read-only data.
10:13 AM Changeset in webkit [155969] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Shrink SVGElement::cssPropertyIdForSVGAttributeName and cssPropertyToTypeMap
https://bugs.webkit.org/show_bug.cgi?id=121499

Reviewed by Andreas Kling.

  • svg/SVGElement.cpp:

(WebCore::populateAttributeNameToCSSPropertyIDMap): Added. Code that used to
be in SVGElement::cssPropertyIdForSVGAttributeName to build a map that maps
attribute names to CSS property IDs, but without the multiple unrolled calls
to HashMap functions.
(WebCore::populateAttributeNameToAnimatedPropertyTypeMap): Added. Code that
used to be in cssPropertyToTypeMap, but without the multiple unrolled calls
to HashMap functions.
(WebCore::attributeNameToAnimatedPropertyTypeMap): Renamed from
cssPropertyToTypeMap, a confusingly inaccurate and imprecise name, and
reimplemented using the populate function.
(WebCore::SVGElement::animatedPropertyTypeForAttribute): Updated to call
attributeNameToAnimatedPropertyTypeMap, and also removed the double hashing
that was done by calling contains followed by get.
(WebCore::SVGElement::cssPropertyIdForSVGAttributeName): Rewrote to use
populateAttributeNameToCSSPropertyIDMap.
(WebCore::SVGElement::isAnimatableCSSProperty): Updated to call the new
attributeNameToAnimatedPropertyTypeMap.

10:09 AM Changeset in webkit [155968] by Darin Adler
  • 5 edits in trunk/Source

Make SVGTransform::valueAsString use StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=121498

Reviewed by Andreas Kling.

Source/WebCore:

  • svg/SVGTransform.cpp:

(WebCore::SVGTransform::valueAsString): Use StringBuilder constently to
avoid creating temporary String objects that cause additional, slow
memory allocation.

Source/WTF:

  • wtf/text/StringBuilder.cpp: Added appendNumber functions corresponding to all remaining

String::number functions. If we find we don't need all of these we can delete them later,
but I don't want to give clients a reason to prefer less-efficient API to StringBuilder.

  • wtf/text/StringBuilder.h: Ditto.
10:07 AM Changeset in webkit [155967] by Darin Adler
  • 3 edits in trunk/Source/WebCore

Get rid of a couple unneeded NeverDestroyed::get() calls
https://bugs.webkit.org/show_bug.cgi?id=121500

Reviewed by Andreas Kling.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::parsePseudoType): No need to call get() here.

  • dom/make_names.pl:

(printFactoryCppFile): Ditto.
(printWrapperFactoryCppFile): Ditto.

10:04 AM Changeset in webkit [155966] by timothy@apple.com
  • 3 edits in trunk/Source/WebInspectorUI

Clean up the Inspector's WebSocket code and prevent it from dropping messages.

https://bugs.webkit.org/show_bug.cgi?id=121391

Reviewed by Joseph Pecoraro.

  • UserInterface/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.initializeWebSocket): Added. Create the socket
and call _sendPendingMessagesToBackendIfNeeded.
(.WebInspector.InspectorFrontendHostStub.prototype.sendMessageToBackend): Store messages as pending
if the socket isn't ready yet. Call _sendPendingMessagesToBackendIfNeeded.
(.WebInspector.InspectorFrontendHostStub.prototype._sendPendingMessagesToBackendIfNeeded): Added.

  • UserInterface/Main.js:

(WebInspector._initializeWebSocketIfNeeded): Move socket creation to initializeWebSocket.

9:46 AM Changeset in webkit [155965] by hmuller@adobe.com
  • 3 edits
    2 adds in trunk

Bad ASSERT() in RasterShapeIntervals::firstIncludedIntervalY()
https://bugs.webkit.org/show_bug.cgi?id=121455

Reviewed by Darin Adler.

Source/WebCore:

Corrected a bad ASSERT() introduced in https://bugs.webkit.org/show_bug.cgi?id=120211.

Test: fast/shapes/shape-inside/shape-inside-first-fit-crash.html

  • rendering/shapes/RasterShape.cpp:

(WebCore::RasterShapeIntervals::firstIncludedIntervalY):

LayoutTests:

Simple regression test, it crashes in the bad ASSERT().

  • fast/shapes/shape-inside/shape-inside-first-fit-crash-expected.txt: Added.
  • fast/shapes/shape-inside/shape-inside-first-fit-crash.html: Added.
9:41 AM Changeset in webkit [155964] by hyatt@apple.com
  • 7 edits in trunk/Source/WebCore

Move the line widow functions out of RenderBlock and into RenderBlockFlow.
https://bugs.webkit.org/show_bug.cgi?id=121456

Reviewed by Dean Jackson.

  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:

(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::calculateMinimumPageHeight):
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
(WebCore::RenderBlockFlow::setBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::clearShouldBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::relayoutToAvoidWidows):

  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData):
(WebCore::RenderBlockFlow::shouldBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::lineBreakToAvoidWidow):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):

  • rendering/RenderObject.h:
9:26 AM Changeset in webkit [155963] by andersca@apple.com
  • 14 edits in trunk

HashMap should work with move-only keys
https://bugs.webkit.org/show_bug.cgi?id=121310

Reviewed by Darin Adler.

Source/WebCore:

Update the call sites now that HashMap::take doesn't return a PassOwnPtr.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::takeRenderBoxRegionInfo):

  • rendering/RenderRegion.h:
  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::registerResource):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::removePendingResource):
(WebCore::SVGDocumentExtensions::removePendingResourceForRemoval):

  • svg/SVGDocumentExtensions.h:

Source/WTF:

Add extra overloads for add and set where the key is an rvalue reference, but not a
template parameter rvalue reference. This way we'll coerce the key parameter to have the expected
type instead of the passed in type, causing map.add(StringImpl::create("Hello"), 123) work when the
type of map is HashMap<String, unsigned>.

Also, sprinkle && and std::forward where appropriate.

  • wtf/HashMap.h:
  • wtf/HashTable.h:

Tools:

  • TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::TEST):
Add test.

9:00 AM Changeset in webkit [155962] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Add RenderObject bit for isBR().
https://bugs.webkit.org/show_bug.cgi?id=121494

Reviewed by Andreas Kling.

It is no longer piggybacking on isText() flag and is now hot in inline layout.

  • rendering/RenderBR.cpp:

(WebCore::RenderBR::RenderBR):

  • rendering/RenderBR.h:
  • rendering/RenderObject.h:

(WebCore::RenderObject::isBR):
(WebCore::RenderObject::setIsBR):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):

8:54 AM Changeset in webkit [155961] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Export some missing symbols for Internals after RenderArena& change.

  • WebCore.exp.in:
8:38 AM Changeset in webkit [155960] by kadam@inf.u-szeged.hu
  • 3 edits
    4 adds
    1 delete in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip and rebase tests.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-17

  • platform/qt-wk2/TestExpectations:
  • platform/qt-wk2/compositing/geometry/negative-text-indent-with-overflow-hidden-layer-expected.txt: Added r155546.
  • platform/qt-wk2/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt: Added r155607.
  • platform/qt-wk2/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt: Added r155607.
  • platform/qt-wk2/fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt: Added r155546.
  • platform/qt-wk2/fast/replaced/border-radius-clip-expected.txt: Removed.
  • platform/qt/TestExpectations:
8:25 AM Changeset in webkit [155959] by Christophe Dumez
  • 12 edits
    3 adds in trunk

Set MessageEvent.source to the newly created port for shared workers' connect events
https://bugs.webkit.org/show_bug.cgi?id=121390

Reviewed by Darin Adler.

Source/WebCore:

Set MessageEvent.source to the newly created port for shared workers' connect events
instead of previously null, as per the latest specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/comms.html#dom-messageevent-source
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#dom-sharedworker

This behavior is consisent with Blink.

Test: fast/workers/shared-worker-messageevent-source.html

  • dom/EventTarget.cpp:

(WebCore::EventTarget::isMessagePort):

  • dom/EventTarget.h:
  • dom/MessageEvent.cpp:

(WebCore::isValidSource):
(WebCore::MessageEvent::MessageEvent):

  • dom/MessageEvent.h:

Use null String instead of an empty String as default value for origin and lastEventId.
This is more efficient and has no impact on the behavior on the JavaScript since a
null String is exposed as an empty one on JS side.
This change is covered by fast/events/constructors/message-event-constructor.html

  • dom/MessageEvent.idl:
  • dom/MessagePort.h:
  • page/DOMWindow.cpp:

(WebCore::PostMessageTimer::event):

  • workers/SharedWorkerGlobalScope.cpp:

(WebCore::createConnectEvent):

LayoutTests:

Add layout test to check that MessageEvent.source is set to the newly created port
for shared workers' connect events.

  • fast/events/constructors/message-event-constructor-expected.txt:
  • fast/events/constructors/message-event-constructor.html:
  • fast/workers/resources/messageevent-source.js: Added.

(onconnect):

  • fast/workers/shared-worker-messageevent-source-expected.txt: Added.
  • fast/workers/shared-worker-messageevent-source.html: Added.
8:18 AM Changeset in webkit [155958] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Fix Windows CE build on ARM.
https://bugs.webkit.org/show_bug.cgi?id=121490

Patch by Sergio Martins <sergio.martins@kdab.com> on 2013-09-17
Reviewed by Darin Adler.

  • wtf/dtoa/utils.h:
8:13 AM Changeset in webkit [155957] by Antti Koivisto
  • 36 edits in trunk

RenderBR should not be RenderText
https://bugs.webkit.org/show_bug.cgi?id=121221

Reviewed by Darin Adler.

Source/WebCore:

Stop inheriting RenderBR from RenderText and make it be a RenderBoxModelObject instead. RenderBR was one
of the few cases where Element renderer was a RenderText. This will enable future cleanups.

RenderBR used little of RenderText mechanisms and was already heavily specialized everywhere. Layout code
didn't care about its text content at all. The new RenderText is also significatly more lightweight
than the old. As a line box it uses plain InlineBox instead of InlineTextBox.

The patch tries to avoid changing test results though there are a few changed render tree dumps without
visual effect. There are also two rendering progressions.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::getUpperLeftCorner):

  • dom/Document.cpp:

(WebCore::Document::updateHoverActiveState):

  • dom/Position.cpp:

(WebCore::hasInlineBoxWrapper):
(WebCore::nextRenderedEditable):
(WebCore::previousRenderedEditable):
(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
(WebCore::Position::getInlineBoxAndOffset):

  • dom/Range.cpp:

(WebCore::Range::textRects):
(WebCore::Range::textQuads):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):

  • editing/Editor.cpp:

(WebCore::findFirstMarkable):

  • editing/TextIterator.cpp:

(WebCore::ignoresContainerClip):

  • editing/VisibleUnits.cpp:

(WebCore::CachedLogicallyOrderedLeafBoxes::previousTextOrLineBreakBox):
(WebCore::CachedLogicallyOrderedLeafBoxes::nextTextOrLineBreakBox):
(WebCore::logicallyPreviousBox):
(WebCore::logicallyNextBox):
(WebCore::wordBreakIteratorForMinOffsetBoundary):
(WebCore::wordBreakIteratorForMaxOffsetBoundary):

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::logicalHeight):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):
(WebCore::InlineBox::deleteLine):
(WebCore::InlineBox::extractLine):
(WebCore::InlineBox::attachLine):
(WebCore::InlineBox::paint):

  • rendering/InlineBox.h:

(WebCore::InlineBox::isLineBreak):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeOverflow):

  • rendering/InlineIterator.h:

(WebCore::isIteratorTarget):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::lineHeight):
(WebCore::InlineTextBox::isLineBreak):

  • rendering/RenderBR.cpp:

(WebCore::RenderBR::RenderBR):
(WebCore::RenderBR::~RenderBR):
(WebCore::RenderBR::createAnonymous):
(WebCore::RenderBR::lineHeight):
(WebCore::RenderBR::baselinePosition):
(WebCore::RenderBR::createInlineBox):
(WebCore::RenderBR::setInlineBoxWrapper):
(WebCore::RenderBR::replaceInlineBoxWrapper):
(WebCore::RenderBR::deleteInlineBoxWrapper):
(WebCore::RenderBR::dirtyLineBoxes):
(WebCore::RenderBR::caretMinOffset):
(WebCore::RenderBR::caretMaxOffset):
(WebCore::RenderBR::canBeSelectionLeaf):
(WebCore::RenderBR::setSelectionState):
(WebCore::RenderBR::localCaretRect):
(WebCore::RenderBR::linesBoundingBox):
(WebCore::RenderBR::absoluteRects):
(WebCore::RenderBR::absoluteQuads):
(WebCore::RenderBR::updateFromStyle):
(WebCore::RenderBR::borderBoundingBox):

  • rendering/RenderBR.h:

(WebCore::toRenderBR):

  • rendering/RenderBlock.cpp:

(WebCore::InlineMinMaxIterator::next):
(WebCore::RenderBlock::updateFirstLetter):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::createInlineBoxForRenderer):
(WebCore::dirtyLineBoxesForRenderer):
(WebCore::reachedEndOfTextRenderer):
(WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlockFlow::layoutInlineChildren):
(WebCore::requiresLineBox):
(WebCore::shouldSkipWhitespaceAfterStartObject):
(WebCore::canBreakAtThisPosition):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::generateCulledLineBoxRects):
(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):
(WebCore::RenderInline::dirtyLineBoxes):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::RenderMenuList):
(WebCore::RenderMenuList::styleDidChange):
(WebCore::RenderMenuList::setText):
(WebCore::RenderMenuList::text):

  • rendering/RenderMenuList.h:
  • rendering/RenderObject.h:

(WebCore::RenderObject::isBeforeContent):
(WebCore::RenderObject::isAfterContent):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):

  • rendering/RenderText.cpp:

(WebCore::RenderText::removeAndDestroyTextBoxes):
(WebCore::RenderText::computePreferredLogicalWidths):
(WebCore::RenderText::setTextInternal):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::ascentAndDescentForBox):
(WebCore::RootInlineBox::verticalPositionForBox):

LayoutTests:

  • editing/selection/move-by-word-visually-mac-expected.txt:


This is a progression. A previously failing subtest passes.

  • platform/mac/css3/selectors3/html/css3-modsel-179a-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-179a-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-179a-expected.txt:


Changes in render tree dump that don't affect rendering.

  • platform/mac/fast/css/pseudo-first-line-border-width-expected.txt:


This is a progression. The new rendering matches Firefox.

  • platform/mac/fast/css/word-space-extra-expected.txt:
  • platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:


Changes in render tree dump that don't affect rendering.

8:10 AM Changeset in webkit [155956] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2
Buildfix for !(ENABLE(WEB_ARCHIVE)
ENABLE(MHTML)) platforms

https://bugs.webkit.org/show_bug.cgi?id=121491

Reviewed by Darin Adler.

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::scheduleLoad):

7:57 AM Changeset in webkit [155955] by akling@apple.com
  • 12 edits in trunk/Source/WebCore

Dodge more work during render tree teardown.
<https://webkit.org/b/121487>

Reviewed by Antti Koivisto.

Add a Document::hasLivingRenderTree() method that returns true if
there's a render tree attached to the document and it's not in the
process of being torn down.

Deploy this check in a number of places that were only checking
for the presence of a RenderView.

7:52 AM Changeset in webkit [155954] by eric.carlson@apple.com
  • 9 edits in trunk

MediaStream API: Adding an async RTCPeerConnection::addIceCandidate
https://bugs.webkit.org/show_bug.cgi?id=121403

Source/WebCore:

Merged from https://chromium.googlesource.com/chromium/blink/+/5bd81fda88d48dd2780832246e7d1ab973ee7a1d

Reviewed by Darin Adler.

No new tests, updated RTCPeerConnection-ice.html.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::addIceCandidate): Add success and error callbacks.

  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/RTCPeerConnection.idl:
  • platform/mediastream/RTCPeerConnectionHandler.h: Changed addIceCandidate signature.
  • platform/mediastream/RTCVoidRequest.h: Removed ExtraData, it is unnecessary.

LayoutTests:

Reviewed by Darin Adler.

  • fast/mediastream/RTCPeerConnection-ice-expected.txt:
  • fast/mediastream/RTCPeerConnection-ice.html:
6:44 AM Changeset in webkit [155953] by berto@igalia.com
  • 2 edits in trunk/Source/WebKit2

[GTK] Unreviewed make distcheck fix.

  • GNUmakefile.am: include WebProcess/Network/*.in in the tarball,

it's needed for generating WebResourceLoaderMessage*.{cpp,h}.

6:38 AM Changeset in webkit [155952] by Carlos Garcia Campos
  • 8 edits in trunk/Source/WebCore

[GTK] Do not include Returns tag in api doc for methods returning void
https://bugs.webkit.org/show_bug.cgi?id=121488

Reviewed by Philippe Normand.

  • bindings/gobject/WebKitDOMCustom.h:
  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction): Only add Returns tag for methods not returning
void.

  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.h:
  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.h:
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
6:24 AM Changeset in webkit [155951] by michael.bruning@digia.com
  • 2 edits in trunk/Source/WebCore

Correct range used for Emoji checks.
https://bugs.webkit.org/show_bug.cgi?id=121486

Reviewed by Allan Sandfeld Jensen.

Found and reported by David Binderman via Qt bug tracker.

The check if a character was in the Emoji range always evaluated to
false due to the upper range limit being lower than the lower limit.

Changed the upper limit to the highest assigned character from the
"Transport and Map Symbols" (0x1F6C5) as that seems to have been the
intended upper range limit of this check.

  • platform/graphics/Font.cpp:

(WebCore::Font::isCJKIdeographOrSymbol):

5:40 AM Changeset in webkit [155950] by mihnea@adobe.com
  • 2 edits in trunk/Source/WTF

REGRESSION(r155910): WebKit nightly builds don't load any page
https://bugs.webkit.org/show_bug.cgi?id=121482

Reviewed by Andreas Kling.

Replaced C++ style comments with C style comments.

  • wtf/Platform.h:
5:33 AM Changeset in webkit [155949] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Move text caret rect computation to root inline box
https://bugs.webkit.org/show_bug.cgi?id=121479

Reviewed by Andreas Kling.

For future code sharing.

  • rendering/RenderText.cpp:

(WebCore::RenderText::localCaretRect):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::computeCaretRect):

  • rendering/RootInlineBox.h:
5:17 AM Changeset in webkit [155948] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore

[GTK] Don't make the GObject DOM bindings API break test fatal
https://bugs.webkit.org/show_bug.cgi?id=121484

Reviewed by Carlos Garcia Campos.

The API varies depending on the compilation options, so this can
easily produce false positives.

Until we figure out a way to handle this situation we shouldn't
make this test fatal.

  • bindings/scripts/gobject-run-api-break-test:

(check_api):

5:05 AM Changeset in webkit [155947] by mihnea@adobe.com
  • 1 edit
    2 adds in trunk/LayoutTests

[CSSRegions] Flowed fixed element without its transformed parent positioned relative to viewport
https://bugs.webkit.org/show_bug.cgi?id=121478

Reviewed by Antti Koivisto.

A fixed positioned element collected into a named flow without its transformed parent should be positioned relative to the viewport instead of the transformed parent. Add a test for this behavior.

  • fast/regions/flow-fixed-element-transformed-parent-expected.txt: Added.
  • fast/regions/flow-fixed-element-transformed-parent.html: Added.
5:02 AM Changeset in webkit [155946] by mihnea@adobe.com
  • 2 edits in trunk/Source/WebCore

[CSSRegions] Replace generatingNode() with generatingElement() for RenderRegion
https://bugs.webkit.org/show_bug.cgi?id=121469

Reviewed by Antti Koivisto.

The fix for https://bugs.webkit.org/show_bug.cgi?id=120397 replaced node() with generatingElement() for regions, but i forgot about replacing generatingNode() with generatingElement() in RenderNamedFlowThread::compareRenderRegions. This is needed in preparation for regions as anonymous blocks refactoring in https://bugs.webkit.org/show_bug.cgi?id=119135.

No new functionality introduced, therefore no new tests.

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::compareRenderRegions):

4:58 AM Changeset in webkit [155945] by berto@igalia.com
  • 2 edits in trunk/Tools

BrowserMarshal.h build fail
https://bugs.webkit.org/show_bug.cgi?id=102938

Patch by YuTeh Shen <shenyute@hotmail.com> on 2013-09-17
Reviewed by Carlos Garcia Campos.

Fix variable name.

  • MiniBrowser/gtk/GNUmakefile.am:
4:05 AM Changeset in webkit [155944] by akling@apple.com
  • 35 edits in trunk/Source/WebCore

CTTE: Pass RenderArena around by reference.
<https://webkit.org/b/121470>

Reviewed by Antti Koivisto.

Pass the RenderArena around by reference in all render tree code.
This code will never be running without an arena.

3:24 AM Changeset in webkit [155943] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

[GTK] GObject DOM symbols file is not generated for video related classes
https://bugs.webkit.org/show_bug.cgi?id=121476

Reviewed by Philippe Normand.

The problem is that we are using a different path for video
related header files in the Makefile, it's the same path in
practice, because we are just prepending ./ to the path, but the
rules that parse those paths don't expect the ./ at the beginning.

  • bindings/gobject/GNUmakefile.am: Use the same path for video

related header files as the other paths in
webkitgtk_gdom_built_h_api.

  • bindings/gobject/webkitdom.symbols: Updated to include the

symbols of the video related clases.

2:47 AM Changeset in webkit [155942] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit2

[GTK][EFL] Add ResourceError::internalError() after r138387
https://bugs.webkit.org/show_bug.cgi?id=121433

Reviewed by Christophe Dumez.

Original patch by Balazs Kelemen <kbalazs@webkit.org>
and Kwang Yul Seo <skyul@company100.net>

  • WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:

(WebKit::internalError):

  • WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:

(WebKit::internalError):

2:44 AM Changeset in webkit [155941] by berto@igalia.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed make distcheck fix.

  • GNUmakefile.list.am:
2:38 AM Changeset in webkit [155940] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing tests.

  • platform/qt-wk1/TestExpectations:
2:32 AM Changeset in webkit [155939] by akling@apple.com
  • 2 edits in trunk/Source/WebKit

Some build juice for Windows.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
2:27 AM Changeset in webkit [155938] by akling@apple.com
  • 16 edits
    2 deletes in trunk/Source/WebCore

Remove ContextFeatures.
<https://webkit.org/b/121473>

Reviewed by Antti Koivisto.

This was only used by the chromium port, nobody implements ContextFeaturesClient.

1:53 AM Changeset in webkit [155937] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Un-dork the build. :|

1:44 AM Changeset in webkit [155936] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix clang warning when building without ENABLE(STYLE_SCOPED).

1:39 AM Changeset in webkit [155935] by Csaba Osztrogonác
  • 7 edits in trunk/Source/WebKit2

Fix Qt WK2 build after r155888
https://bugs.webkit.org/show_bug.cgi?id=121471

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-17
Reviewed by Csaba Osztrogonác.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::createDrawingAreaProxy):

  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/API/qt/raw/qrawwebview.cpp:

(QRawWebViewPrivate::createDrawingAreaProxy):

  • UIProcess/API/qt/raw/qrawwebview_p_p.h:
  • UIProcess/qt/QtPageClient.cpp:

(WebKit::QtPageClient::createDrawingAreaProxy):

  • UIProcess/qt/QtPageClient.h:
1:22 AM Changeset in webkit [155934] by Csaba Osztrogonác
  • 6 edits in trunk/Source/WebKit2

[GTK][EFL] Add NetworkProcess support for ProcessLauncher
https://bugs.webkit.org/show_bug.cgi?id=121434

Reviewed by Sam Weinig.

Original patch by Balazs Kelemen <kbalazs@webkit.org>
and Kwang Yul Seo <skyul@company100.net>

  • Shared/ProcessExecutablePath.h:
  • Shared/efl/ProcessExecutablePathEfl.cpp:

(WebKit::executablePathOfNetworkProcess):

  • Shared/gtk/ProcessExecutablePathGtk.cpp:

(WebKit::executablePathOfNetworkProcess):

  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::ProcessLauncher::launchProcess):

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess):

1:20 AM Changeset in webkit [155933] by Csaba Osztrogonác
  • 5 edits in trunk/Source/WebKit2

Buildfix for !USE(PROTECTION_SPACE_AUTH_CALLBACK) platforms
https://bugs.webkit.org/show_bug.cgi?id=121431

Reviewed by Alexey Proskuryakov.

Mising guards added.

Original patch by Balazs Kelemen <kbalazs@webkit.org>
and Kwang Yul Seo <skyul@company100.net>

  • NetworkProcess/NetworkResourceLoader.messages.in:
  • WebProcess/Network/WebResourceLoader.cpp:
  • WebProcess/Network/WebResourceLoader.h:
  • WebProcess/Network/WebResourceLoader.messages.in:
1:18 AM Changeset in webkit [155932] by Csaba Osztrogonác
  • 6 edits in trunk/Source/WebKit2

WebResourceLoader.messages.in should be ENABLE(NETWORK_PROCESS) guarded
https://bugs.webkit.org/show_bug.cgi?id=121424

Reviewed by Alexey Proskuryakov.

Original patch by Balazs Kelemen <kbalazs@webkit.org>.

  • CMakeLists.txt:
  • DerivedSources.pri:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebProcess/Network/WebResourceLoader.messages.in: ENABLE(NETWORK_PROCESS) guard added.
1:13 AM Changeset in webkit [155931] by akling@apple.com
  • 9 edits in trunk/Source/WebCore

Move <style scoped> code behind ENABLE(STYLE_SCOPED)
<https://webkit.org/b/121018>

Reviewed by Darin Adler.

Move all the code for <style scoped> behind ENABLE(STYLE_SCOPED) guards.
It's not nice to clutter common codepaths with code that always executes
even though the feature is disabled at compile-time.

12:01 AM Changeset in webkit [155930] by Manuel Rego Casasnovas
  • 2 edits in trunk/Source/WebKit2

Unreviewed, fixing the GTK WK2 debug build after r155911.

  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp: Add missing using

namespace WebCore.

Sep 16, 2013:

9:23 PM Changeset in webkit [155929] by Brent Fulgham
  • 3 edits in trunk/Tools

[Windows] Clean up WinLauncher by using smart pointers
https://bugs.webkit.org/show_bug.cgi?id=121467

Reviewed by Anders Carlsson.

  • WinLauncher/PrintWebUIDelegate.cpp:

(PrintWebUIDelegate::webViewPrintingMarginRect): Switch to smart pointers.

  • WinLauncher/WinLauncher.cpp:

(WinLauncherWebHost::updateAddressBar): Use _bstr_t and smart pointers.
(WinLauncherWebHost::didFailProvisionalLoadWithError): Ditto.
(showLastVisitedSites): Smart pointer updates.
(WinLauncherWebHost::didFinishLoadForFrame): Ditto.
(setToDefaultPreferences): Ditto.
(dllLauncherEntryPoint): Ditto.
(PrintView): Ditto.
(LaunchInspector): Ditto.
(NavigateToHistory): Ditto.
(MyEditProc): Ditto.
(loadURL): Ditto.

9:22 PM Changeset in webkit [155928] by weinig@apple.com
  • 69 edits in trunk/Source/WebCore

CTTE: InputType should store its HTMLInputElement back pointer as a reference
https://bugs.webkit.org/show_bug.cgi?id=121466

Reviewed by Anders Carlsson.

  • Converts InputType::create() and InputType::createText() to take a HTMLInputElement& (as well as all the subclasses).
  • Change InputType::element() to return an HTMLInputElement& and update all the callers.
9:15 PM Changeset in webkit [155927] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Fix EFL build after r155888
https://bugs.webkit.org/show_bug.cgi?id=121465

Patch by Sergio Correia <Sergio Correia> on 2013-09-16
Reviewed by Gyuyoung Kim.

Update WebView to follow the changes in PageClient in r155888.

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::createDrawingAreaProxy): Use createOwned (addded in
r155407) to return the DrawingAreaProxy from DrawingAreaProxyImpl.

  • UIProcess/CoordinatedGraphics/WebView.h: Update createDrawingAreaProxy()

signature to match PageClient.h.

6:49 PM Changeset in webkit [155926] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WTF

USE(WEB_THREAD): More explicit WebThread initialization
https://bugs.webkit.org/show_bug.cgi?id=121454

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-16
Reviewed by Benjamin Poulain.

Be more explicit when initializing WebThread only data.

  • wtf/MainThread.h:
  • wtf/MainThread.cpp:

(WTF::initializeWebThreadOnce):
(WTF::initializeWebThread):
Ensure one time initialization.

  • wtf/mac/MainThreadMac.mm:

(WTF::initializeMainThreadPlatform):
(WTF::initializeWebThreadPlatform):
Move WebThread value initialization to its own function.

(WTF::isMainThread):
Remove no longer invalid assert if WebThread was not initialized.

6:39 PM Changeset in webkit [155925] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-537.60-branch/Source/WebCore

Merged r155226. <rdar://problem/14949946>

6:31 PM Changeset in webkit [155924] by timothy@apple.com
  • 9 edits in trunk/Source

Make InspectorTimelineAgent use an enum for the record type instead of a string.

https://bugs.webkit.org/show_bug.cgi?id=121461

Reviewed by Joseph Pecoraro.

Source/WebCore:

  • inspector/Inspector.json:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore::toProtocol):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):

  • inspector/InspectorTimelineAgent.h:

(WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):

Source/WebInspectorUI:

  • UserInterface/InspectorBackendCommands.js:
  • UserInterface/Legacy/6.0/InspectorBackendCommands.js:
  • UserInterface/TimelineManager.js:

(WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
(WebInspector.TimelineManager.prototype.eventRecorded):

  • Versions/Inspector-iOS-6.0.json:
6:26 PM Changeset in webkit [155923] by Lucas Forschler
  • 4 edits
    1 copy
    1 delete in branches/safari-537.60-branch/Source/WebCore

Merged r155215. <rdar://problem/14949946>

6:26 PM Changeset in webkit [155922] by Brent Fulgham
  • 6 edits in trunk/Tools

[Windows] Add rudimentary history to WinLauncher.
https://bugs.webkit.org/show_bug.cgi?id=121463

Reviewed by Anders Carlsson.

  • WinLauncher/WinLauncher.cpp:

(updateMenuItemForHistoryItem): Added
(showLastVisitedSites): Added
(WinLauncherWebHost::didFinishLoadForFrame): Add history item once
a new page has been visited.
(dllLauncherEntryPoint): Deallocate history on exit.
(NavigateToHistory): Added
(WndProc): Add handler for history entries

  • WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu items to hold

up to 10 history slots.

  • WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link against

Windows utility library to allow use of _bstr_t type.

  • WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Add menu items

to hold up to 10 history slots.

  • WinLauncher/stdafx.h: Add <comutil.h> to precompiled headers.
6:21 PM Changeset in webkit [155921] by Lucas Forschler
  • 3 edits in branches/safari-537.60-branch/Source/WebKit/win

Merged r155212. <rdar://problem/14949951>

6:18 PM Changeset in webkit [155920] by Lucas Forschler
  • 5 edits in branches/safari-537.60-branch/Source/WebCore

Merged r155130. <rdar://problem/14932481>

6:16 PM Changeset in webkit [155919] by Lucas Forschler
  • 2 edits in branches/safari-537.60-branch/Source/WebCore

Merged r155127. <rdar://problem/14932481>

6:08 PM Changeset in webkit [155918] by kov@webkit.org
  • 13 edits
    3 adds in trunk

[GTK] Make symbol export filter more strict, and disable for dev/test builds
https://bugs.webkit.org/show_bug.cgi?id=120586

Reviewed by Martin Robinson.

.:

  • GNUmakefile.am: only include test-related automake files when developer

mode is on.

  • Source/autotools/ReadCommandLineArguments.m4: add --enable-developer-mode,

defaults to no, and to yes for debug builds.

  • Source/autotools/SetupAutomake.m4: add ENABLE_DEVELOPER_MODE conditional.
  • Source/autotools/symbols.filter: make the exported symbols list much shorter,

covering only the public ABI and a few symbols required by WebKit2 processes.

Source/WebKit/gtk:

  • GNUmakefile.am: only use the version script when in developer mode..

Source/WebKit2:

  • GNUmakefile.am: only use the version script if developer mode is disabled.

Tools:

  • GNUmakefile.am: moved GtkLauncher and documentation builds to their own

makefiles, so they can be included unconditionally.

  • GtkLauncher/GNUmakefile.am: added.
  • Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary): always pass --enable-developer-mode
to configure, since we consider builds done through build-webkit to be development
and test builds.

  • gtk/GNUmakefile.am: added.
  • gtk/common.py: do not use the Scripts directory as a reference to the top path;

it's not necessary and it will not work now that the Scripts directory is not
shipped in the tarball.

6:07 PM Changeset in webkit [155917] by Lucas Forschler
  • 4 edits in branches/safari-537.60-branch/Source/WebCore

Merged r154915. <rdar://problem/14932478>

6:04 PM Changeset in webkit [155916] by Lucas Forschler
  • 9 edits in branches/safari-537.60-branch/Source/WebCore

Merged r154914. <rdar://problem/14932478>

6:01 PM Changeset in webkit [155915] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Fix WebKit1 build after r155910

Reviewed by Anders Carlsson.

  • wtf/Platform.h: Some files in WebKit include system headers before

WTF headers, causing the macro to be defined twice. #undef the macro
to support that case.

6:00 PM Changeset in webkit [155914] by Lucas Forschler
  • 2 edits in branches/safari-537.60-branch/Source/WebCore

Merged r154890. <rdar://problem/14932478>

5:31 PM Changeset in webkit [155913] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after 155905.

  • Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::Connection::sendOutgoingMessage): use OwnPtr instead of PassOwnPtr.

4:39 PM Changeset in webkit [155912] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Disable OS X's unprefixed debug macro
https://bugs.webkit.org/show_bug.cgi?id=121460

Reviewed by Anders Carlsson.

  • wtf/Platform.h: OS X defines a series of platform macros for debugging.

Some of them are really annoying because they use common names (e.g. check()).

Disable those macros so that we are not limited in how we name methods and functions.

4:32 PM Changeset in webkit [155911] by Joseph Pecoraro
  • 8 edits in trunk/Source

Add RunLoop::isMain and use it in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121459

Reviewed by Anders Carlsson.

Source/WebCore:

  • WebCore.exp.in:
  • platform/RunLoop.cpp:

(WebCore::RunLoop::isMain):

  • platform/RunLoop.h:

Source/WebKit2:

  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp:

(getIconSurfaceSynchronously):
(iconDataReadyForPageURLCallback):
(webkit_favicon_database_get_favicon_uri):

  • UIProcess/API/mac/WKPrintingView.mm:

(-[WKPrintingView _delayedResumeAutodisplayTimerFired]):
(-[WKPrintingView _adjustPrintingMarginsForHeaderAndFooter]):
(pageDidDrawToImage):
(pageDidDrawToPDF):
(-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]):
(pageDidComputePageRects):
(-[WKPrintingView _askPageToComputePageRects]):
(prepareDataForPrintingOnSecondaryThread):
(-[WKPrintingView knowsPageRange:]):
(-[WKPrintingView _drawPreview:]):
(-[WKPrintingView drawRect:]):
(-[WKPrintingView _drawPageBorderWithSizeOnMainThread:]):
(-[WKPrintingView drawPageBorderWithSize:]):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::globalPageMap):

4:30 PM Changeset in webkit [155910] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Disable OS X's unprefixed debug macro
https://bugs.webkit.org/show_bug.cgi?id=121460

Reviewed by Anders Carlsson.

  • wtf/Platform.h: OS X defines a serie of platform macros for debugging.

Some of them are really annoying because they use common names (e.g. check()).

Disable those macros so that we are not limited how we name methods and functions.

3:57 PM Changeset in webkit [155909] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: ARIA tablist is disabled, but VoiceOver does not speak the tabs as dimmed
https://bugs.webkit.org/show_bug.cgi?id=121408

Reviewed by Darin Adler.

Source/WebCore:

ARIA says that aria-disabled should propagate to children nodes.

Test: accessibility/aria-disabled-propagated-to-children.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isEnabled):

LayoutTests:

  • accessibility/aria-disabled-propagated-to-children-expected.txt: Added.
  • accessibility/aria-disabled-propagated-to-children.html: Added.
3:20 PM Changeset in webkit [155908] by weinig@apple.com
  • 167 edits in trunk/Source/WebCore

CTTE: Element::createRenderer() should take references
https://bugs.webkit.org/show_bug.cgi?id=121449

Reviewed by Anders Carlsson.

*Many file elided*

3:16 PM Changeset in webkit [155907] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

iOS build fix after r155638.

Unreviewed.

  • editing/Editor.cpp:
3:01 PM Changeset in webkit [155906] by Bem Jones-Bey
  • 5 edits in trunk/Source/WebCore

Make FloatingObjects own it's FloatingObject instances
https://bugs.webkit.org/show_bug.cgi?id=121323

Reviewed by Alexandru Chiculita.

As part of decoupling FloatingObjects from RenderBlock, change
FloatingObjects to properly manage the FloatingObject instances it
contains.

No new tests, no behavior change.

  • rendering/FloatingObjects.cpp:

(WebCore::FloatingObject::FloatingObject): Make the constructors
private so that FloatingObjects can only be created with an OwnPtr.
Also make a RenderBox required to create a FloatingObject.
(WebCore::FloatingObject::create): Factory method to create a vanilla
FloatingObject.
(WebCore::FloatingObject::copyToNewContainer): Factory method to copy
an existing FloatingObject in the case it is overhanging or intruding
and needs to be copied to the block that it overhangs or intrudes
into.
(WebCore::FloatingObject::unsafeClone): Rename this method so it is
more obvious that it really shouldn't be used, and to make it more
obvious that one should use the copyToNewContainer method for all
normal FloatingObject copies.
(WebCore::FloatingObjects::clear): Delete all the FloatingObjects in
the set before clearing it.
(WebCore::FloatingObjects::moveAllToFloatInfoMap): Move all of the
FloatingObjects in the set to a RendererToFloatInfoMap. This is used
in RenderBlockFlow::clearFloats to when it is readding floats after
clearing the set.
(WebCore::FloatingObjects::add): Take an OwnPtr.
(WebCore::FloatingObjects::remove): Delete the removed FloatingObject.

  • rendering/FloatingObjects.h: Remove FloatingObject::setRenderer(),

since the RenderBox must be set in the constructor.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::moveAllChildrenIncludingFloatsTo): Rename clone
to unsafeClone.
(WebCore::RenderBlock::removeFloatingObjects): Don't delete anymore,
since clear does it.
(WebCore::RenderBlock::insertFloatingObject): Handle OwnPtr properly.
(WebCore::RenderBlock::removeFloatingObject): Don't delete anymore,
since remove does it.
(WebCore::RenderBlock::removeFloatingObjectsBelow): Ditto.
(WebCore::RenderBlock::addOverhangingFloats): Use copyToNewContainer
and OwnPtr.
(WebCore::RenderBlock::addIntrudingFloats): Ditto.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::clearFloats): Use exportToFloatInfoMap.

3:00 PM Changeset in webkit [155905] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Replace more uses of PassOwnPtr with OwnPtr in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121453

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::SecondaryThreadPendingSyncReply::SecondaryThreadPendingSyncReply):
(CoreIPC::Connection::createSyncMessageEncoder):
(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::sendSyncReply):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::sendSyncMessageFromSecondaryThread):
(CoreIPC::Connection::waitForSyncReply):
(CoreIPC::Connection::processIncomingSyncReply):
(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::enqueueIncomingMessage):
(CoreIPC::Connection::dispatchMessage):

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::PendingSyncReply::PendingSyncReply):

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::sendOutgoingMessage):

2:59 PM Changeset in webkit [155904] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Flaky Test: svg/batik/masking/maskRegions.svg
https://bugs.webkit.org/show_bug.cgi?id=114120

Fails in the same way as many other batik tests.

  • platform/mac/TestExpectations: Marking as flaky.
2:46 PM Changeset in webkit [155903] by Hugo Parente Lima
  • 2 edits in trunk/Source/WebCore

Fix creation of embedded JS and CSS files on cmake based ports.
https://bugs.webkit.org/show_bug.cgi?id=121448

Reviewed by Joseph Pecoraro.

Just a build fix, layout tests already test this issue.

  • CMakeLists.txt:
2:35 PM Changeset in webkit [155902] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Marked a few tests that are too slow in debug builds, and frequently fail.

  • platform/mac/TestExpectations:
2:30 PM Changeset in webkit [155901] by Brent Fulgham
  • 3 edits in trunk/Source/WebKit/win

[Windows] Rendering stops when mouse is moving for some types of animations.
https://bugs.webkit.org/show_bug.cgi?id=121329

Reviewed by Anders Carlsson.

  • WebView.cpp:

(WebView::WebView): Add new display flag.
(WebView::repaint): Mark view as needing a display operation.
(WebView::addToDirtyRegion): Ditto
(WebView::scrollBackingStore): Ditto
(WebView::sizeChanged): Ditto
(WebView::updateBackingStore): Ditto
(WebView::performLayeredWindowUpdate): Mark the WebView as having been
moved to screen.
(WebView::paintIntoWindow): Ditto
(WebView::WebViewWndProc): If the view needs display, and it was not done during
this message loop iteration, draw the screen.

  • WebView.h:

(WebView::needsDisplay): Added

2:09 PM Changeset in webkit [155900] by andersca@apple.com
  • 7 edits in trunk/Source

MessageQueue should use a Deque of OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=121450

Reviewed by Andreas Kling.

Source/WebCore:

  • Modules/webdatabase/DatabaseThread.cpp:

(WebCore::SameDatabasePredicate::operator()):

  • dom/default/PlatformMessagePortChannel.h:

(WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):

  • fileapi/FileThread.cpp:

(WebCore::SameInstancePredicate::operator()):

  • workers/WorkerRunLoop.cpp:

(WebCore::ModePredicate::operator()):

Source/WTF:

  • wtf/MessageQueue.h:
2:01 PM Changeset in webkit [155899] by zandobersek@gmail.com
  • 5 edits in releases/WebKitGTK/webkit-2.2

[GTK][2.2] Enable the Wayland target by default if the GTK+ Wayland dependency is available
https://bugs.webkit.org/show_bug.cgi?id=121414

Reviewed by Martin Robinson.

  • Source/autotools/FindDependencies.m4: If the Wayland target is not strictly disabled, also check that the GTK+ Wayland

package (gtk+-wayland-3.0) has a recent-enough version. If the dependency could not be satisfied, either a warning or an
error is printed out, depending if the Wayland target was required or just optional.

  • Source/autotools/PrintBuildConfiguration.m4: Add a new macro, AM_APPEND_TO_DESRIPTION, that's helpful when producing

a description string that can contain multiple items that should be nicely formatted when listed in that string. This is
then used when creating the description for all the enabled targets, so for instance 'x11, wayland' string would be displayed
if both the X11 and Wayland targets are enabled.

  • Source/autotools/ReadCommandLineArguments.m4: The --with-target configuration options should default to 'x11,wayland' if

not given, with the Wayland target in that case not being a hard requirement (i.e. it should be disabled if the dependencies
for the Wayland target could not be found).

  • Source/autotools/Versions.m4: The GTK+ Wayland dependency should be of version 3.9.14 or greater (the 3.10 release series).
1:39 PM Changeset in webkit [155898] by andersca@apple.com
  • 4 edits in trunk

WTF::Deque should work with move only types
https://bugs.webkit.org/show_bug.cgi?id=121446

Reviewed by Andreas Kling.

Source/WTF:

  • wtf/Deque.h:

Use std::move and std::forward where appropriate and get rid of the PassTraits include.

Tools:

  • TestWebKitAPI/Tests/WTF/Deque.cpp:

(TestWebKitAPI::TEST):
Add a test.

1:34 PM Changeset in webkit [155897] by ap@apple.com
  • 2 edits in trunk/LayoutTests

svg/animations/smil-leak-*.svg tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=114280

The tests are still flaky. Ran out of ideas, so marking them as such and leaving them there.

  • platform/mac/TestExpectations:
1:24 PM Changeset in webkit [155896] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: TypeError when updating ResourceTreeElement created in strange order
https://bugs.webkit.org/show_bug.cgi?id=121382

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-16
Reviewed by Timothy Hatcher.

Patch by Brian Burg. Fix an uncaught exception that can happen on navigations.

  • UserInterface/ResourceTreeElement.js:

(WebInspector.ResourceTreeElement.prototype._updateStatus):

1:14 PM Changeset in webkit [155895] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebKit2

Unreviewed, fixing the GTK WK2 build after r155888.

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::createDrawingAreaProxy):

  • UIProcess/API/gtk/PageClientImpl.h:
1:09 PM Changeset in webkit [155894] by akling@apple.com
  • 10 edits in trunk/Source/WebCore

CTTE: FrameTree::top() should return a reference.
<https://webkit.org/b/121445>

Reviewed by Anders Carlsson.

There's always a top frame in the tree.

1:01 PM Changeset in webkit [155893] by zandobersek@gmail.com
  • 1 edit
    14 adds in trunk/Source/WebCore

Unreviewed, fixing GObject bindings tests after r155850 by adding the *.symbols files that are now also generated.

  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.symbols: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestCallback.symbols: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.symbols: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.symbols: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.symbols: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestException.symbols: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestInterface.symbols: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.symbols: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.symbols: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestNode.symbols: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.symbols: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.symbols: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.symbols: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestTypedefs.symbols: Added.
12:56 PM Changeset in webkit [155892] by dbates@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix the build following <http://trac.webkit.org/changeset/155591>
(https://bugs.webkit.org/show_bug.cgi?id=121200)

Fix the build for ports that enable PLUGIN_PROXY_FOR_VIDEO, such as iOS WebKit.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateSizes): Substitute isWidget() for isRenderWidget()
as the latter is undefined.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForVideo): Ditto.

12:48 PM Changeset in webkit [155891] by mhahnenberg@apple.com
  • 14 edits
    1 add in trunk/Source/JavaScriptCore

MarkedBlocks shouldn't be put in Allocated state if they didn't produce a FreeList
https://bugs.webkit.org/show_bug.cgi?id=121236

Reviewed by Geoffrey Garen.

Right now, after a collection all MarkedBlocks are in the Marked block state. When lazy sweeping
happens, if a block returns an empty free list after being swept, we call didConsumeFreeList(),
which moves the block into the Allocated block state. This happens to both the block that was
just being allocated out of (i.e. m_currentBlock) as well as any blocks who are completely full.
We should distinguish between these two cases: m_currentBlock should transition to
Allocated (because we were just allocating out of it) and any subsequent block that returns an
empty free list should transition back to the Marked state. This will make the block state more
consistent with the actual state the block is in, and it will also allow us to speed up moving
all blocks the the Marked state during generational collection.

Added new RAII-style HeapIterationScope class that notifies the Heap when it is about to be
iterated and when iteration has finished. Any clients that need accurate liveness data when
iterating over the Heap now need to use a HeapIterationScope so that the state of Heap can
be properly restored after they are done iterating. No new GC-allocated objects can be created
until this object goes out of scope.

(JSC::Debugger::recompileAllJSFunctions): Added HeapIterationScope for the Recompiler iteration.

  • heap/Heap.cpp:

(JSC::Heap::willStartIterating): Callback used by HeapIterationScope to indicate that iteration of
the Heap is about to begin. This will cause cell liveness data to be canonicalized by calling stopAllocating.
(JSC::Heap::didFinishIterating): Same, but indicates that iteration has finished.
(JSC::Heap::globalObjectCount): Used HeapIterationScope.
(JSC::Heap::objectTypeCounts): Ditto.
(JSC::Heap::markDeadObjects): Ditto.
(JSC::Heap::zombifyDeadObjects): Ditto.

  • heap/Heap.h:
  • heap/HeapIterationScope.h: Added. New RAII-style object for indicating to the Heap that it's about

to be iterated or that iteration has finished.
(JSC::HeapIterationScope::HeapIterationScope):
(JSC::HeapIterationScope::~HeapIterationScope):

  • heap/HeapStatistics.cpp:

(JSC::HeapStatistics::showObjectStatistics): Used new HeapIterationScope.

  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::tryAllocateHelper): We now treat the case where we have just finished
allocating out of the current block differently from the case where we sweep a block and it
returns an empty free list. This was the primary point of this patch.
(JSC::MarkedAllocator::allocateSlowCase): ASSERT that nobody is currently iterating the Heap
when allocating.

  • heap/MarkedAllocator.h:

(JSC::MarkedAllocator::reset): All allocators are reset after every collection. We need to make
sure that the m_lastActiveBlock gets cleared, which it might not always because we don't call
takeCanonicalizedBlock on blocks in the large allocators.
(JSC::MarkedAllocator::stopAllocating): We shouldn't already have a last active block,
so ASSERT as much.
(JSC::MarkedAllocator::resumeAllocating): Do the opposite of what stopAllocating
does. So, if we don't have a m_lastActiveBlock then we don't have to worry about undoing anything
done by stopAllocating. If we do, then we call resumeAllocating on the block, which returns the FreeList
as it was prior to stopping allocation. We then set the current block to the last active block and
clear the last active block.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::resumeAllocating): Any block resuming allocation should be in
the Marked state, so ASSERT as much. We always allocate a m_newlyAllocated Bitmap if we're
FreeListed, so if we didn't allocate one then we know we were Marked when allocation was stopped,
so just return early with an empty FreeList. If we do have a non-null m_newlyAllocated Bitmap
then we need to be swept in order to rebuild our FreeList.

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::didConsumeEmptyFreeList): This is called if we ever sweep a block and get back
an empty free list. Instead of transitioning to the Allocated state, we now go straight back to the
Marked state. This makes sense because we weren't actually allocated out of, so we shouldn't be in
the allocated state. Also added some ASSERTs to make sure that we're in the state that we expect: all of
our mark bits should be set and we should not have a m_newlyAllocated Bitmap.

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::forEachAllocator): Added a new functor-style iteration method so that we can
easily iterate over each allocator for, e.g., stopping and resuming allocators without
duplicating code.
(JSC::StopAllocatingFunctor::operator()): New functors for use with forEachAllocator.
(JSC::MarkedSpace::stopAllocating): Ditto.
(JSC::ResumeAllocatingFunctor::operator()): Ditto.
(JSC::MarkedSpace::resumeAllocating): Ditto.
(JSC::MarkedSpace::willStartIterating): Callback that notifies MarkedSpace that it is being iterated.
Does some ASSERTs, sets a flag, canonicalizes cell liveness data by calling stopAllocating.
(JSC::MarkedSpace::didFinishIterating): Ditto, but to signal that iteration has completed.

  • heap/MarkedSpace.h:

(JSC::MarkedSpace::iterationInProgress): Returns true if a HeapIterationScope is currently active.
(JSC::MarkedSpace::forEachLiveCell): Accepts a HeapIterationScope to enforce the rule that you have to
create one prior to iterating over the Heap.
(JSC::MarkedSpace::forEachDeadCell): Ditto.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::haveABadTime): Changed to use new HeapIterationScope.

  • runtime/VM.cpp:

(JSC::VM::releaseExecutableMemory): Ditto.

12:47 PM WebKitGTK/2.2.x edited by kov@webkit.org
(diff)
12:36 PM Changeset in webkit [155890] by ap@apple.com
  • 5 edits in trunk/LayoutTests

svg/animations/smil-leak-*.svg tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=114280

The tests were still flaky. Changed retry timeout from 0 to 100 ms as previously
suggested by Geoff.

  • svg/animations/smil-leak-dynamically-added-element-instances.svg:
  • svg/animations/smil-leak-element-instances-noBaseValRef.svg:
  • svg/animations/smil-leak-element-instances.svg:
  • svg/animations/smil-leak-elements.svg:
12:06 PM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org
(diff)
11:58 AM Changeset in webkit [155889] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Inlining should work in debug mode (i.e. Executable::newCodeBlock() should call recordParse())
https://bugs.webkit.org/show_bug.cgi?id=121444

Reviewed by Mark Hahnenberg.

  • dfg/DFGArgumentPosition.h: Fix a bug discovered by reenabling inlining. ArgumentPosition may point to the non-canonical VariableAccessData but users of someVariable() want the canonical one.

(JSC::DFG::ArgumentPosition::someVariable):

  • runtime/Executable.cpp: Call recordParse() so that the Executable knows things about itself (like if it has captured variables). Otherwise those fields are uninitialized.

(JSC::ScriptExecutable::newCodeBlockFor):

11:57 AM Changeset in webkit [155888] by andersca@apple.com
  • 17 edits in trunk/Source/WebKit2

Remove some uses of PassOwnPtr in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121443

Reviewed by Andreas Kling.

  • Scripts/webkit2/messages.py:

(message_to_struct_declaration):
(generate_message_handler):

  • Scripts/webkit2/messages_unittest.py:
  • UIProcess/API/mac/FindIndicatorWindow.h:
  • UIProcess/API/mac/FindIndicatorWindow.mm:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::createDrawingAreaProxy):

  • UIProcess/API/mac/WKView.mm:

(-[WKView WebKit::]):
(-[WKView _setFindIndicator:fadeOut:animate:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/DrawingAreaProxyImpl.cpp:
  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/PageClient.h:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(PageOverlayClientImpl::PageOverlayClientImpl):
(WKBundlePageOverlayCreate):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::createWebEvent):

  • WebProcess/Plugins/PluginView.h:
11:26 AM Changeset in webkit [155887] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix following <https://trac.webkit.org/r154358>
(https://bugs.webkit.org/show_bug.cgi?id=120078)

Fix the build for ports that enable PLUGIN_PROXY_FOR_VIDEO, such as iOS WebKit.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::rendererIsNeeded): Substitute "style" for "context".

11:21 AM Changeset in webkit [155886] by timothy@apple.com
  • 9 edits in trunk/Source

Make InspectorTypeBuilder generate better enums in C++.

https://bugs.webkit.org/show_bug.cgi?id=121440

Reviewed by Joseph Pecoraro.

Source/WebCore:

  • inspector/CodeGeneratorInspector.py:

(fix_camel_case): Add more abbrivations.
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder): Use fix_camel_case

  • inspector/ConsoleMessage.cpp:

(WebCore::messageSourceValue):
(WebCore::messageTypeValue):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::detectOrigin):

  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::parse):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::resourceStyleSheetText):

  • inspector/InspectorStyleSheet.h:

(WebCore::InspectorStyleSheet::canBind):

Source/WebInspectorUI:

  • UserInterface/InspectorBackendCommands.js: Updated to make Css be CSS.
11:09 AM Changeset in webkit [155885] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Flaky Test: svg/batik/filters/feTile.svg
https://bugs.webkit.org/show_bug.cgi?id=114375

  • platform/mac/TestExpectations: Marking as flaky. We already have a lot of these

batik tests marked as flaky, with similar symptoms.

10:56 AM Changeset in webkit [155884] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Aligned argument signatures of setupArgumentsWithExecState are missing on MIPS.
https://bugs.webkit.org/show_bug.cgi?id=121439

Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-09-16
Reviewed by Geoffrey Garen.

Missing implementations of setupArgumentsWithExecState added.

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):

10:50 AM Changeset in webkit [155883] by andersca@apple.com
  • 8 edits in trunk/Source/WTF

Change a couple of COMPILE_ASSERTs to static_assert
https://bugs.webkit.org/show_bug.cgi?id=121441

Reviewed by Andreas Kling.

  • wtf/BloomFilter.h:
  • wtf/PackedIntVector.h:

(WTF::PackedIntVector::PackedIntVector):

  • wtf/StdLibExtras.h:

(WTF::bitwise_cast):
(WTF::safeCast):
(WTF::roundUpToMultipleOf):

  • wtf/StringHasher.h:

(WTF::StringHasher::hashMemory):

  • wtf/Vector.h:
  • wtf/text/AtomicString.cpp:
  • wtf/unicode/Unicode.h:
10:40 AM Changeset in webkit [155882] by ap@apple.com
  • 5 edits in trunk/LayoutTests

svg/animations/smil-leak-*.svg tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=114280

Reviewed by Geoffrey Garen.

Try garbage collection multiple times, who knows which queues the deleted nodes
could still be in. Also, removed last week's experimental change to make 10x more
nodes to see how that affects the number of leaks (it didn't).

  • svg/animations/smil-leak-dynamically-added-element-instances.svg:
  • svg/animations/smil-leak-element-instances-noBaseValRef.svg:
  • svg/animations/smil-leak-element-instances.svg:
  • svg/animations/smil-leak-elements.svg:
10:21 AM Changeset in webkit [155881] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

MediaStream API: Storing the constraints in MediaStreamSource
https://bugs.webkit.org/show_bug.cgi?id=120882

based on: https://chromium.googlesource.com/chromium/blink/+/04ac7655b54ae98f55774afde3f8e92b6c6302e6

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-09-16
Reviewed by Eric Carlson.

No new tests needed.

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::succeed):

  • platform/mediastream/MediaStreamSource.h:

(WebCore::MediaStreamSource::setConstraints):
(WebCore::MediaStreamSource::constraints):

10:21 AM Changeset in webkit [155880] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/po

Merge 155867 - Add new Galician translations
https://bugs.webkit.org/show_bug.cgi?id=105079

Patch by Fran Dieguez <frandieguez@gnome.org> on 2013-09-16
Reviewed by Gustavo Noronha Silva.

  • gl.po: updated
10:21 AM Changeset in webkit [155879] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/po

Merge 155866 - L10n - en_GB PO file for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=100255

Patch by Chris Leonard <cjlhomeaddress@gmail.com> on 2013-09-16
Reviewed by Gustavo Noronha Silva.

  • en_GB.po: updated.
10:20 AM Changeset in webkit [155878] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/po

Merge 155869 - Updated spanish Translation
https://bugs.webkit.org/show_bug.cgi?id=100677

Patch by Daniel Mustieles <daniel.mustieles@gmail.com> on 2013-09-16
Reviewed by Gustavo Noronha Silva.

  • es.po: updated.
10:16 AM Changeset in webkit [155877] by ap@apple.com
  • 2 edits in trunk/LayoutTests

http/tests/misc/submit-post-keygen.html is extremely slow on bots, often timing out
https://bugs.webkit.org/show_bug.cgi?id=121331

Marking as possibly failing too, because when DRT detects a timeout, run-webkit-tests
thinks that it's a failure.

  • platform/mac/TestExpectations:
10:13 AM Changeset in webkit [155876] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[sh4] Fix typo in subp implementation in LLINT.
https://bugs.webkit.org/show_bug.cgi?id=121438

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-09-16
Reviewed by Andreas Kling.

  • offlineasm/sh4.rb:
10:12 AM Changeset in webkit [155875] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Rebaseline bindings tests after Sam's Document& changes.

10:07 AM Changeset in webkit [155874] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Destroying a Document's render tree shouldn't make it impossible to recreate.
<https://webkit.org/b/121437>

Reviewed by Antti Koivisto.

Rename Document::detach() to destroyRenderTree() and stop automatically
disconnecting Document from its Frame after the deforestation.

Added Document::disconnectFromFrame() and do that after every call to
destroyRenderTree() that we currently have.

This change doesn't alter any behavior on its own, but is a step towards
being able to destroy and rebuild the render tree.

9:35 AM Changeset in webkit [155873] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r155861 - Web Inspector: Do not try to parse incomplete HTTP requests
https://bugs.webkit.org/show_bug.cgi?id=121123

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-09-16
Reviewed by Carlos Garcia Campos.

Update to incorporate additional review suggestions.

  • UIProcess/API/gtk/tests/TestInspectorServer.cpp:

(sendIncompleteRequest):
Fix memory leaks, change test timeout from 2 seconds to 1 second,
use "0" instead of "NULL" and use g_assert_no_error when checking
for GError.

9:32 AM Changeset in webkit [155872] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r155642 - Web Inspector: Do not try to parse incomplete HTTP requests
https://bugs.webkit.org/show_bug.cgi?id=121123

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-09-12
Reviewed by Darin Adler.

When working on a patch for bug #121121 I found an issue with the InspectorServer where it would try
to parse an HTTP message before receiving the full message and thus fail connecting with the
chromedevtools plugin.

What happens is that the WebSocketServerConnection receives buffers on
WebSocketServerConnection::didReceiveSocketStreamData and calls
WebSocketServerConnection::readHTTPMessage which then checks if we have a valid request by calling
HTTPRequest::parseHTTPRequestFromBuffer. If the request is valid it tries to parse the message and
clears the buffer, otherwise it continues adding data to the internal buffer until we have a valid
request.

The problem is that currently HTTPRequest::parseHTTPRequestFromBuffer considers the request as valid
before receiving the full message. To solve this we should make the method check if the request
headers end with a blank line otherwise we consider the request as invalid (see also
http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html).

  • UIProcess/API/gtk/tests/TestInspectorServer.cpp:

(sendIncompleteRequest):
(beforeAll):
Add GTK specific test to check if the inspector server replies to incomplete requests.

  • UIProcess/InspectorServer/HTTPRequest.cpp:

(WebKit::HTTPRequest::parseHeaders):
Do not consider request valid if headers didn't end with a blank line.

9:29 AM Changeset in webkit [155871] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Unreviewed warning correction. Avoid uninitialized renderer.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue): Renderer can be uninitialized.

9:24 AM Changeset in webkit [155870] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Unreviewed warning correction.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFilter): Don't use 'value' as the input argument
to the method, and the internal loop variable for the parser.

9:21 AM Changeset in webkit [155869] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Updated spanish Translation
https://bugs.webkit.org/show_bug.cgi?id=100677

Patch by Daniel Mustieles <daniel.mustieles@gmail.com> on 2013-09-16
Reviewed by Gustavo Noronha Silva.

  • es.po: updated.
9:19 AM Changeset in webkit [155868] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Compile errors in WebCore derived sources.
https://bugs.webkit.org/show_bug.cgi?id=121420

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-09-16
Reviewed by Brent Fulgham.

  • dom/make_names.pl:

(printNamesCppFile): Added const modifier.
(printDefinitions): Use C style cast.

9:18 AM Changeset in webkit [155867] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Add new Galician translations
https://bugs.webkit.org/show_bug.cgi?id=105079

Patch by Fran Dieguez <frandieguez@gnome.org> on 2013-09-16
Reviewed by Gustavo Noronha Silva.

  • gl.po: updated
9:16 AM Changeset in webkit [155866] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

L10n - en_GB PO file for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=100255

Patch by Chris Leonard <cjlhomeaddress@gmail.com> on 2013-09-16
Reviewed by Gustavo Noronha Silva.

  • en_GB.po: updated.
9:16 AM Changeset in webkit [155865] by hmuller@adobe.com
  • 5 edits
    8 adds in trunk

[CSS Shapes] Winding rule polygon issues
https://bugs.webkit.org/show_bug.cgi?id=120236

Reviewed by Dirk Schulze.

Source/WebCore:

This patch corrects some of the problems with shape-inside and
self-intersecting polygons and eliminates the layout flashing behavior
that prompted the original bug report. The FloatPolygon::contains()
method now respoects the polygon's fillRule and the PolygonShape code
used to find shape-inside intervals for the top and bottom of a line
now also handles fillRule correctly.

Tests: fast/shapes/shape-inside/shape-inside-complex-polygon-001.html

fast/shapes/shape-inside/shape-inside-complex-polygon-002.html
fast/shapes/shape-inside/shape-inside-complex-polygon-003.html
fast/shapes/shape-inside/shape-inside-complex-polygon-004.html

  • platform/graphics/FloatPolygon.cpp:

(WebCore::FloatPolygon::containsEvenOdd):
(WebCore::FloatPolygon::containsNonZero):
(WebCore::FloatPolygon::contains):

  • platform/graphics/FloatPolygon.h:
  • rendering/shapes/PolygonShape.cpp:

(WebCore::computeXIntersections):

LayoutTests:

Verify that self-intersecting rectilinear shape-inside polygons work
correctly for the evenodd and nonzero fill rules.

The shape for tests 001 and 002 contains a loop (the vertices are
numbered in the figure):

0----4----1----5
| | | |
| 3----2 |
7--------------6

When the fillRule is nonzero the entire rectangle is filled because
edges 7-0 and 3-4 wind in same direction. When fillRule is evenodd the
1-2-3-4 rectangle is not filled, leaving a U shape.

The shape for tests 003 and 004 is similar, but the adjacent vertical edges
wind in opposite directions. As a result both nonzero and evenodd fills
produce the same U shaped result.

0----2---1,5---6
| | | |
| 3----4 |
8--------------7

  • fast/shapes/shape-inside/shape-inside-complex-polygon-001-expected.html: Added.
  • fast/shapes/shape-inside/shape-inside-complex-polygon-001.html: Added.
  • fast/shapes/shape-inside/shape-inside-complex-polygon-002-expected.html: Added.
  • fast/shapes/shape-inside/shape-inside-complex-polygon-002.html: Added.
  • fast/shapes/shape-inside/shape-inside-complex-polygon-003-expected.html: Added.
  • fast/shapes/shape-inside/shape-inside-complex-polygon-003.html: Added.
  • fast/shapes/shape-inside/shape-inside-complex-polygon-004-expected.html: Added.
  • fast/shapes/shape-inside/shape-inside-complex-polygon-004.html: Added.
9:01 AM Changeset in webkit [155864] by Carlos Garcia Campos
  • 16 edits
    1 delete in releases/WebKitGTK/webkit-2.2

Merge r155534 - [GTK] Remove Gail dependency from build system for GTK3
https://bugs.webkit.org/show_bug.cgi?id=119673

Reviewed by Gustavo Noronha Silva.

.:

  • Source/autotools/FindDependencies.m4: Don't look for GAIL at all.
  • Source/autotools/Versions.m4: Removed any reference to GAIL.
  • Source/cmake/FindGAIL3.cmake: Removed.
  • Source/cmake/OptionsGTK.cmake: Don't look for the GAIL package.

Source/WebCore:

  • GNUmakefile.am: Removed GAIL_CFLAGS.
  • PlatformGTK.cmake: Removed GAIL3_INCLUDE_DIRS and GAIL3_LIBRARIES.

Source/WebKit/gtk:

  • GNUmakefile.am: Removed GAIL_CFLAGS and GAIL_LIBS.

Source/WebKit2:

  • GNUmakefile.am: Removed GAIL_LIBS.

Tools:

  • EWSTools/ubuntu-ews-packages: Removed libgail-dev package.
  • Scripts/webkitpy/port/gtk.py:

(GtkPort.setup_environ_for_server): Do not load the 'gail' module anymore.

  • TestWebKitAPI/GNUmakefile.am: Removed GAIL_LIBS.
9:00 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
8:56 AM Changeset in webkit [155863] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore

Merge r155520 - [GTK] Get rid of Pango/Gail dependencies in accessibility for ATK
https://bugs.webkit.org/show_bug.cgi?id=114867

Reviewed by Martin Robinson.

Removed all trace of Gail and Pango specific code from the AtkText
implementation, now everything has been reimplemented.

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(webkitAccessibleTextGetTextForOffset): Removed fallback code
relying in Gail/Pango, now all the related code has been
removed. Also, replaced the collection of if statements with a
switch, for better readability of the code.

8:55 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
8:53 AM Changeset in webkit [155862] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.2/Source

Merge r155516 - [GTK] Reimplement atk_text_get_text_*_offset for LINE boundaries
https://bugs.webkit.org/show_bug.cgi?id=114872

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Re-implement these functions without using GailTextUtil nor Pango.

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(lineAtPositionForAtkBoundary): New helper function to find the
line at a given position considering values of AtkTextBoundary.
(webkitAccessibleTextLineForBoundary): New function,
implementing atk_text_get_text_*_offset for LINE.
(webkitAccessibleTextGetTextForOffset): Replace usage of Gail for
LINE boundaries with webkitAccessibleTextLineForBoundary().

Source/WebKit/gtk:

Fixed wrong unit test.

  • tests/testatk.c:

(testWebkitAtkGetTextAtOffsetWithPreformattedText): This test was
reporting a trailing '\n' for some reason for a <pre> block, which
is plainly wrong since, in order to return that, there should be
at least a trailing empty space after that and before the </pre>
closing tag. This is fixed now.
(testWebkitAtkGetTextAtOffsetWithWrappedLines): Uncommented tests
that were previously not passing due to a bug in GailTextUtil.

8:52 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
8:49 AM Changeset in webkit [155861] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Web Inspector: Do not try to parse incomplete HTTP requests
https://bugs.webkit.org/show_bug.cgi?id=121123

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-09-16
Reviewed by Carlos Garcia Campos.

Update to incorporate additional review suggestions.

  • UIProcess/API/gtk/tests/TestInspectorServer.cpp:

(sendIncompleteRequest):
Fix memory leaks, change test timeout from 2 seconds to 1 second,
use "0" instead of "NULL" and use g_assert_no_error when checking
for GError.

8:49 AM Changeset in webkit [155860] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore

Merge r155031 - [GTK] Reimplement atk_text_get_text_*_offset for SENTENCE boundaries
https://bugs.webkit.org/show_bug.cgi?id=114873

Reviewed by Chris Fleizach.

Re-implement these functions without using GailTextUtil nor Pango.

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(webkitAccessibleTextWordForBoundary): Renamed from webkitAccessibleTextGetWordForBoundary,
to keep it consistent with names for new functions.
(isSentenceBoundary): Helper function to know when we are either
at the beginning or the end of a sentence.
(isWhiteSpaceBetweenSentences): It returns true if we are in the
middle of a white space between sentences. Useful for implementing
the SENTENCE_END boundary type.
(sentenceAtPositionForAtkBoundary): New helper function to find the
sentence at a given position considering values of AtkTextBoundary.
(webkitAccessibleTextSentenceForBoundary): New function,
implementing atk_text_get_text_*_offset for SENTENCE.
(webkitAccessibleTextGetTextForOffset): Replace usage of Gail for
SENTENCE boundaries with webkitAccessibleTextSentenceForBoundary().

8:48 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
8:17 AM Changeset in webkit [155859] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

AXObjectCache::m_document should be a reference.
<https://webkit.org/b/121425>

Reviewed by Antti Koivisto.

AXObjectCache is always owned by a Document so remove the uncertainty
by turning its m_document into a Document&.

8:17 AM Changeset in webkit [155858] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/po

Merge 155855 - [l10n] [pt_BR] Updated Brazilian Portuguese translation of WebKitGTK+ - 12/09/2013
https://bugs.webkit.org/show_bug.cgi?id=121255

Patch by Enrico Nicoletto <liverig@gmail.com> on 2013-09-16
Reviewed by Gustavo Noronha.

  • pt_BR.po: updated.
8:16 AM Changeset in webkit [155857] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/po

Merge 155831 - [l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=121392

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-09-15
Reviewed by Gustavo Noronha Silva.

  • pl.po: updated.
8:16 AM Changeset in webkit [155856] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore/platform/gtk/po

Merge 154677 - [l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=119986

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-08-27
Reviewed by Gustavo Noronha Silva.

  • pl.po: updated.
8:16 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
8:03 AM Changeset in webkit [155855] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] [pt_BR] Updated Brazilian Portuguese translation of WebKitGTK+ - 12/09/2013
https://bugs.webkit.org/show_bug.cgi?id=121255

Patch by Enrico Nicoletto <liverig@gmail.com> on 2013-09-16
Reviewed by Gustavo Noronha.

  • pt_BR.po: updated.
7:00 AM Changeset in webkit [155854] by commit-queue@webkit.org
  • 4 edits
    4 moves in trunk

Unreviewed, rolling out r155851.
http://trac.webkit.org/changeset/155851
https://bugs.webkit.org/show_bug.cgi?id=121429

checkbox states should be exposed through AtkState, not
AtkValue (Requested by msanchez on #webkit).

Source/WebCore:

  • accessibility/atk/WebKitAccessibleInterfaceValue.cpp:

(webkitAccessibleValueGetCurrentValue):

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(getInterfaceMaskFromObject):

LayoutTests:

  • platform/mac/accessibility/mixed-checkbox-expected.txt: Renamed from LayoutTests/accessibility/mixed-checkbox-expected.txt.
  • platform/mac/accessibility/mixed-checkbox.html: Renamed from LayoutTests/accessibility/mixed-checkbox.html.
  • platform/mac/accessibility/native-vs-nonnative-checkboxes-expected.txt: Renamed from LayoutTests/accessibility/native-vs-nonnative-checkboxes-expected.txt.
  • platform/mac/accessibility/native-vs-nonnative-checkboxes.html: Renamed from LayoutTests/accessibility/native-vs-nonnative-checkboxes.html.
6:54 AM Changeset in webkit [155853] by kadam@inf.u-szeged.hu
  • 4 edits
    4 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipping and rebase failing tests on Qt bots.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-16

  • platform/qt-wk1/TestExpectations:
  • platform/qt-wk1/fast/events/before-unload-returnValue-expected.txt: Added r155367.
  • platform/qt-wk1/inspector/console/command-line-api-expected.txt:
  • platform/qt/TestExpectations:
  • platform/qt/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt: Added r155607.
  • platform/qt/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt: Added r155607.
6:38 AM WebKitGTK/2.2.x edited by mario@webkit.org
(diff)
6:25 AM WebKitGTK/WebKit2Roadmap edited by mario@webkit.org
(diff)
5:51 AM Changeset in webkit [155852] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk/Source/WebKit2

[EFL][WK2] Implement pan and flick gesture.
https://bugs.webkit.org/show_bug.cgi?id=107101

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-09-16
Reviewed by Gyuyoung Kim.

Implement pan gesture to scroll page by movement of point and stop
scrolling smoothly using ease-in-out-quad algorithm after touched
point is removed from the screen.

Use Ecore_Animator in order to process movement once per each framing
time slot instead of processing all movement.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/EwkView.cpp:

(EwkView::scrollBy):

  • UIProcess/API/efl/EwkView.h:
  • UIProcess/API/efl/GestureRecognizer.cpp:

(WebKit::GestureHandler::view):
(WebKit::GestureHandler::GestureHandler):
(WebKit::GestureHandler::~GestureHandler):
(WebKit::GestureHandler::reset):
(WebKit::GestureHandler::panAnimatorCallback):
(WebKit::GestureHandler::handlePanStarted):
(WebKit::GestureHandler::handlePan):
(WebKit::GestureHandler::handlePanFinished):
(WebKit::GestureHandler::flickAnimatorCallback):
(WebKit::GestureHandler::handleFlick):
(WebKit::GestureRecognizer::noGesture):
(WebKit::GestureRecognizer::reset):

  • UIProcess/efl/EasingCurves.cpp: Added.

(WebKit::easeInOutQuad):

  • UIProcess/efl/EasingCurves.h: Added.
5:38 AM Changeset in webkit [155851] by commit-queue@webkit.org
  • 4 edits
    4 moves in trunk

[ATK] Extends atk value interface to return proper checkbox states
https://bugs.webkit.org/show_bug.cgi?id=121413

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-16
Reviewed by Mario Sanchez Prada.

Source/WebCore:

Tests: accessibility/mixed-checkbox.html

accessibility/native-vs-nonnative-checkboxes.html

  • accessibility/atk/WebKitAccessibleInterfaceValue.cpp:

(webkitAccessibleValueValueForAccessibilityObject):
(webkitAccessibleValueGetCurrentValue):

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(getInterfaceMaskFromObject):

LayoutTests:

Sharing mac tests with other ports (GTK/EFL).

  • accessibility/mixed-checkbox-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/mixed-checkbox-expected.txt.
  • accessibility/mixed-checkbox.html: Renamed from LayoutTests/platform/mac/accessibility/mixed-checkbox.html.
  • accessibility/native-vs-nonnative-checkboxes-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/native-vs-nonnative-checkboxes-expected.txt.
  • accessibility/native-vs-nonnative-checkboxes.html: Renamed from LayoutTests/platform/mac/accessibility/native-vs-nonnative-checkboxes.html.
5:28 AM Changeset in webkit [155850] by Carlos Garcia Campos
  • 4 edits
    5 adds in trunk/Source/WebCore

[GTK] Check DOM bindings API compatibility while building
https://bugs.webkit.org/show_bug.cgi?id=101224

Reviewed by Gustavo Noronha Silva.

A .symbols file is now generated for every DOM binding public API
object. It contains the signature of all public methods. We keep a
single file with the signature of all public methods in the source
tree. When DOM bindings are generated, a new symbols file is
created concatenating all .symbols files generated and it's
compared with the symbols file in the source tree using a script
that checks if the changes are API compatible or not. In case of
API break the build finishes showing the differences found in the
symbol files. If API compatible changes are found, the diff is
shown in stdout, suggesting to run the gobject-run-api-break-test
with the --reset-results option to update the symbols file, and
the build continues. If there aren't API changes the build
continues silently.

  • GNUmakefile.am:
  • bindings/gobject/GNUmakefile.am:
  • bindings/gobject/WebKitDOMCustom.symbols: Added.
  • bindings/gobject/WebKitDOMEventTarget.symbols: Added.
  • bindings/gobject/WebKitDOMObject.symbols: Added.
  • bindings/gobject/webkitdom.symbols: Added.
  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction):
(WriteData):

  • bindings/scripts/gobject-run-api-break-test: Added.

(check_api):

4:44 AM Changeset in webkit [155849] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Devirtualize Document::detach().
<https://webkit.org/b/121418>

Reviewed by Antti Koivisto.

The only override was in PluginDocument which needs to decouple itself
from the plugin element at the start of detach.

Added PluginDocument::detachFromPluginElement() and call it from detach().

3:49 AM Changeset in webkit [155848] by mario@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed gardening. Removed fail expectations for test in
the GTK & EFL ports, consistently passing after r155374.

  • platform/efl/TestExpectations: Removed test.
  • platform/gtk/TestExpectations: Ditto.
2:27 AM Changeset in webkit [155847] by commit-queue@webkit.org
  • 8 edits in trunk

Source/WebKit2: [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
https://bugs.webkit.org/show_bug.cgi?id=98410

Patch by Wojciech Bielawski <w.bielawski@samsung.com> on 2013-09-16
Reviewed by Darin Adler.

Add API required to implement click() method for context menu entry, used by WebkitTestRunner::EventSender.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageClickMenuItem):
(WKBundlePageCopyContextMenuItemTitle):
(WKBundlePageGetContextMenuItems):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

Tools: [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
https://bugs.webkit.org/show_bug.cgi?id=98410

Patch by Wojciech Bielawski <w.bielawski@samsung.com> on 2013-09-16
Reviewed by Darin Adler.

Add implementation of click() method of objects returned by eventSender.contextClick().

  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(MenuItemPrivateData):
(WTR::menuItemClickCallback):
(WTR::getMenuItemTitleCallback):
(WTR::staticMenuItemFinalize):
(WTR::getMenuItemClass):
(WTR::EventSendingController::contextClick):

LayoutTests: [WKTR] Add implementation of click() method of objects returned by eventSender.contextClick().
https://bugs.webkit.org/show_bug.cgi?id=98410

Patch by Wojciech Bielawski <w.bielawski@samsung.com> on 2013-09-16
Reviewed by Darin Adler.

Unskipping tests related with click() method.

  • platform/efl-wk2/TestExpectations: Corrected bug number for tests: editing/pasteboard/can-read-in-copy-and-cut-events.html editing/pasteboard/can-read-in-dragstart-event.html
  • platform/gtk-wk2/TestExpectations:
2:05 AM Changeset in webkit [155846] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[sh4] Handle subp opcode with 3 operands and bpbeq opcode in LLINT.
https://bugs.webkit.org/show_bug.cgi?id=121412

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-09-16
Reviewed by Andreas Kling.

  • offlineasm/sh4.rb:
1:42 AM Changeset in webkit [155845] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

CTTE: RenderCombineText always has a Text node.
<https://webkit.org/b/121411>

Reviewed by Antti Koivisto.

This renderer is never anonymous and always has a corresponding Text node.
Replaced node() with a textNode() reference getter.

1:00 AM Changeset in webkit [155844] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebCore

Merge r155778 - Missing allow-none introspection annotation for DomDocument.evaluate method
https://bugs.webkit.org/show_bug.cgi?id=118310

Reviewed by Martin Robinson.

Add (allow-none) introspection annotation to parameters that can
be NULL.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction):

12:59 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
12:48 AM Changeset in webkit [155843] by Carlos Garcia Campos
  • 10 edits in releases/WebKitGTK/webkit-2.2

Merge r155768 - [GTK] WebKitGTK+ is linking against libxslt in too many places
https://bugs.webkit.org/show_bug.cgi?id=121356

Reviewed by Martin Robinson.

Source/WebCore:

Don't use LIBXSLT_CFLAGS when compiling libWebCorePlatform and
libWebCoreGtk, no source files use libxslt there.

  • GNUmakefile.am:

Source/WebKit/gtk:

Don't use LIBXSLT_CFLAGS when compiling libwebkitgtk, no source
files use libxslt there.

The webkit tests don't use libxslt, so we shouldn't link against
it.

  • GNUmakefile.am:

Source/WebKit2:

Don't use LIBXSLT_CFLAGS when compiling libWebCoreGtk2, no source
files use libxslt there.

  • GNUmakefile.am:

Tools:

TestWebCore, WebKitTestRunner and MiniBrowser don't use libxslt,
so we don't need to link against it.

  • MiniBrowser/gtk/GNUmakefile.am:
  • TestWebKitAPI/GNUmakefile.am:
  • WebKitTestRunner/GNUmakefile.am:
12:14 AM Changeset in webkit [155842] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Tools

Merge r155758 - Uses gtk-doc tools even when --disable-gtk-doc passed
https://bugs.webkit.org/show_bug.cgi?id=91239

Patch by Ross Burton <ross.burton@intel.com> on 2013-09-14
Reviewed by Martin Robinson.

Don't run generate-gtkdoc on install if gtk-doc is disabled.

  • GNUmakefile.am:
12:13 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
12:09 AM Changeset in webkit [155841] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Tools

Merge r155772 - [GTK] Fails to compile if the build directory is in a different partition
https://bugs.webkit.org/show_bug.cgi?id=121296

Reviewed by Martin Robinson.

Instead of using os.symlink() to install the gtk-doc templates,
use os.link() first and fall back to os.symlink() if it fails.

  • gtk/gtkdoc.py:

(GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):

12:08 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
12:07 AM Changeset in webkit [155840] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Tools

Merge r155757 - [GTK] Fails to compile if the build directory is in a different partition
https://bugs.webkit.org/show_bug.cgi?id=121296

Reviewed by Carlos Garcia Campos.

Use symlinks instead of hard links to support building on a
different file system.

  • gtk/gtkdoc.py:

(GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):

12:05 AM Changeset in webkit [155839] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk

Merge r155677 - download-requested arg should be WEBKIT_TYPE_DOWNLOAD not G_TYPE_OBJECT
https://bugs.webkit.org/show_bug.cgi?id=57634

Reviewed by Darin Adler.

  • webkit/webkitwebview.cpp:

(webkit_web_view_class_init):

12:04 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
12:04 AM Changeset in webkit [155838] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r155533 - [WK2] [GTK] LayerTreeHostGtk: don't set m_isValid to false if glContext() returns null
https://bugs.webkit.org/show_bug.cgi?id=120892

Reviewed by Martin Robinson.

If the GL context cannot be created then m_isValid is set to false
during the initialization of LayerTreeHostGtk.

This is not really necessary since the rest of the code already
deals with that situation, so it doesn't have any effect other
than breaking the assertion in invalidate().

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::initialize):

12:03 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
Note: See TracTimeline for information about the timeline view.