Timeline



Oct 1, 2013:

10:11 PM Changeset in webkit [156764] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

contenteditable justify commands applied to next paragraph as well
https://bugs.webkit.org/show_bug.cgi?id=90611

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-01
Reviewed by Ryosuke Niwa.

Source/WebCore:

When the selection extends from first paragraph to start of next
paragraph then Justify command is applied to both the paragraph,
Instead it should be applied only to first paragraph.

Co-author: Sudarshan C P <sudarshan.cp@samsung.com>

Test: editing/execCommand/contenteditable-justify-next-paragraph.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyBlockStyle):
Adjusted visibleEnd to previous position.

LayoutTests:

Added a test for selecting one paragraph and the beginning of another
paragraph to ensure that only the first fully-selected paragraph should
be justified when justifying the selection.

  • editing/execCommand/align-in-span-expected.txt: Updated.
  • editing/execCommand/contenteditable-justify-next-paragraph-expected.txt: Added.
  • editing/execCommand/contenteditable-justify-next-paragraph.html: Added.
10:01 PM Changeset in webkit [156763] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Flaky Test: media/media-element-play-after-eos.html
https://bugs.webkit.org/show_bug.cgi?id=115048

  • platform/mac/TestExpectations: Marking as such.
9:25 PM Changeset in webkit [156762] by Lucas Forschler
  • 1 edit in branches/safari-537-branch/LayoutTests/platform/mac-lion/TestExpectations

Rollout r156759.

9:20 PM Changeset in webkit [156761] by akling@apple.com
  • 15 edits in trunk/Source

Move mouse event dispatch from Node to Element.
<https://webkit.org/b/122203>

Reviewed by Anders Carlsson.

We never dispatch mouse events on text or other non-element nodes,
so move the related logic to using Element.

Node::dispatchMouseEvent() moves to Element. I also changed the
relatedTarget argument to be an Element* since the related target
is never a Node either.

Most of this patch is *Node -> *Element renames in EventHandler.

9:17 PM Changeset in webkit [156760] by gyuyoung.kim@samsung.com
  • 22 edits in trunk/Source/WebCore

Generate toCSSFooValue for CSS child values
https://bugs.webkit.org/show_bug.cgi?id=122157

Reviewed by Darin Adler.

As a step to cleanup static_cast<> for CSSFooValue, this patch adds toCSSFooValue()
for "CSSAspectRatioValue, CSSBorderImageSliceValue, CSSFunctionValue, CSSInheritedValue,
CSSValueList, CSSVariableValue, and CSSFontFaceSrcValue".

To use CSS_VALUE_TYPE_CASTS, isFunctionValue(), isFontFaceSrcValue() are added to
generate toCSSFunctionValue, toCSSFontFaceSrcValue().

No new tests, no behavior changes.

  • css/CSSAspectRatioValue.h:
  • css/CSSBorderImageSliceValue.h:
  • css/CSSFontFaceSrcValue.h:
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSFunctionValue.h:
  • css/CSSInheritedValue.h:
  • css/CSSParser.cpp:

(WebCore::filterProperties):
(WebCore::CSSParser::addFillValue):
(WebCore::CSSParser::addAnimationValue):
(WebCore::CSSParser::createFontFaceRule):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::wrapValueInCommaSeparatedList):

  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapNinePieceImage):
(WebCore::CSSToStyleMap::mapNinePieceImageSlice):

  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

(WebCore::CSSValue::isFunctionValue):
(WebCore::CSSValue::isFontFaceSrcValue):

  • css/CSSValueList.h:

(WebCore::CSSValueListInspector::CSSValueListInspector):

  • css/CSSVariableValue.h:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyTextIndent::applyValue):

  • css/MediaQueryEvaluator.cpp:

(WebCore::compareAspectRatioValue):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getLayeredShorthandValue):

  • css/StyleResolver.cpp:

(WebCore::createGridPosition):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::parseCustomFilterParameter):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):

  • editing/EditingStyle.cpp:

(WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle):
(WebCore::EditingStyle::mergeStyle):
(WebCore::StyleChange::extractTextStyles):
(WebCore::diffTextDecorations):

  • editing/EditorCommand.cpp:

(WebCore::executeToggleStyleInList):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::rebuildFontFace):

8:28 PM Changeset in webkit [156759] by Lucas Forschler
  • 1 edit in branches/safari-537-branch/LayoutTests/platform/mac-lion/TestExpectations

Update TestExpectations.

7:22 PM Changeset in webkit [156758] by fpizlo@apple.com
  • 5 edits in trunk

FTL should use the new version of LLVM MCJIT memory manager APIs that take a SectionName
https://bugs.webkit.org/show_bug.cgi?id=122193

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Update our usage of the LLVM C API since the API is about to change.

  • ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateCodeSection):
(JSC::FTL::mmAllocateDataSection):

WebKitLibraries:

Reviewed by Geoffrey Garen.

  • LLVMIncludesMountainLion.tar.bz2:
  • LLVMLibrariesMountainLion.tar.bz2:
7:19 PM Changeset in webkit [156757] by fpizlo@apple.com
  • 19 edits
    12 deletes in trunk

REGRESSION(156464): 50% regression on SunSpider/string-fasta
https://bugs.webkit.org/show_bug.cgi?id=122202

Source/JavaScriptCore:

Unreviewed, roll out r156464.

This is a progression on string-fasta, since it fixes the regression.

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::paramString):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitExpressionInfo):

  • bytecompiler/NodesCodegen.cpp:

(JSC::ForInNode::emitBytecode):
(JSC::FuncExprNode::emitBytecode):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::addVar):

  • parser/NodeConstructors.h:

(JSC::CommaNode::CommaNode):
(JSC::ParameterNode::ParameterNode):
(JSC::ForInNode::ForInNode):

  • parser/Nodes.cpp:

(JSC::FunctionParameters::create):
(JSC::FunctionParameters::FunctionParameters):
(JSC::FunctionParameters::~FunctionParameters):

  • parser/Nodes.h:

(JSC::ExpressionNode::isDotAccessorNode):
(JSC::CommaNode::append):
(JSC::ParameterNode::ident):
(JSC::FunctionParameters::at):
(JSC::FunctionParameters::identifiers):

  • parser/Parser.cpp:

(JSC::::Parser):
(JSC::::parseVarDeclaration):
(JSC::::parseVarDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseFormalParameters):
(JSC::::parseAssignmentExpression):

  • parser/Parser.h:

(JSC::Scope::declareParameter):
(JSC::Parser::declareParameter):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createFormalParameterList):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::operatorStackPop):

  • runtime/JSONObject.cpp:
  • runtime/JSONObject.h:

LayoutTests:

Unreviewed, roll out r156464.

  • js/destructuring-assignment-expected.txt: Removed.
  • js/destructuring-assignment.html: Removed.
  • js/mozilla/strict/13.1-expected.txt:
  • js/mozilla/strict/regress-532254-expected.txt:
  • js/mozilla/strict/script-tests/13.1.js:
  • js/regress/destructuring-arguments-expected.txt: Removed.
  • js/regress/destructuring-arguments-length-expected.txt: Removed.
  • js/regress/destructuring-arguments-length.html: Removed.
  • js/regress/destructuring-arguments.html: Removed.
  • js/regress/destructuring-swap-expected.txt: Removed.
  • js/regress/destructuring-swap.html: Removed.
  • js/regress/script-tests/destructuring-arguments-length.js: Removed.
  • js/regress/script-tests/destructuring-arguments.js: Removed.
  • js/regress/script-tests/destructuring-swap.js: Removed.
  • js/script-tests/destructuring-assignment.js: Removed.
  • sputnik/Conformance/13_Function_Definition/S13_A5.html:
7:01 PM Changeset in webkit [156756] by timothy@apple.com
  • 2 edits in trunk/Tools

Fix singular labels for test failures.

https://bugs.webkit.org/show_bug.cgi?id=122200

Reviewed by Joseph Pecoraro.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):

6:09 PM FTLJIT edited by fpizlo@apple.com
(diff)
6:05 PM Changeset in webkit [156755] by Lucas Forschler
  • 1 edit in branches/safari-537.73-branch/LayoutTests/platform/mac-lion/TestExpectations

Merge TextExpectations.

6:04 PM Changeset in webkit [156754] by Lucas Forschler
  • 1 edit in branches/safari-537.73-branch/LayoutTests/platform/mac-wk2/TestExpectations

Merge TextExpectations.

6:00 PM Changeset in webkit [156753] by timothy@apple.com
  • 2 edits in trunk/Tools

Don't keep appending iterations each time the queue updates.

https://bugs.webkit.org/show_bug.cgi?id=122198

Reviewed by Joseph Pecoraro.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:

(BuildbotQueue.prototype.update):

5:36 PM Changeset in webkit [156752] by timothy@apple.com
  • 3 edits in trunk/Tools

Properly sort iterations in the Dashboard by revision for out-of-order queues.

https://bugs.webkit.org/show_bug.cgi?id=122196

Reviewed by Brent Fulgham.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration):
(BuildbotIteration.prototype.update):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:

(BuildbotQueue.prototype.update):
(BuildbotQueue.prototype.sortIterations):

5:03 PM Changeset in webkit [156751] by weinig@apple.com
  • 24 edits in trunk/Source/WebCore

Convert PageGroup to using std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=122184

Reviewed by Anders Carlsson.

  • page/CaptionUserPreferences.cpp:
  • page/CaptionUserPreferences.h:
  • page/CaptionUserPreferencesMediaAF.cpp:
  • page/CaptionUserPreferencesMediaAF.h:
  • page/Frame.cpp:
  • page/GroupSettings.h:
  • page/Page.cpp:
  • page/PageGroup.cpp:
  • page/PageGroup.h:
  • page/UserScriptTypes.h:
  • page/UserStyleSheetTypes.h:
  • workers/DedicatedWorkerGlobalScope.h:
  • workers/DedicatedWorkerThread.cpp:
  • workers/DedicatedWorkerThread.h:
  • workers/SharedWorkerGlobalScope.cpp:
  • workers/SharedWorkerGlobalScope.h:
  • workers/SharedWorkerThread.cpp:
  • workers/SharedWorkerThread.h:
  • workers/WorkerGlobalScope.cpp:
  • workers/WorkerGlobalScope.h:
  • workers/WorkerThread.cpp:
  • workers/WorkerThread.h:
4:45 PM Changeset in webkit [156750] by timothy@apple.com
  • 4 edits in trunk/Tools

Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations.

Also fix some URLs to not have extras slashes and add a page title.

https://bugs.webkit.org/show_bug.cgi?id=122192

Reviewed by Joseph Pecoraro.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot.prototype.buildLogURLForIteration):
(WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
(WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
4:42 PM Changeset in webkit [156749] by timothy_horton@apple.com
  • 27 edits in trunk

Tiled drawing GraphicsLayer tree dumps should match non-tiled more closely
https://bugs.webkit.org/show_bug.cgi?id=122172

Reviewed by Anders Carlsson.

No new tests, but will be tested by all of the compositing tests after bug 121859 lands.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::dumpProperties):
Only dump drawsContent and backgroundColor if the client says we should.
Provide the ability to skip over a layer in the dump, making it appear as if that layer's
children are direct decendents of that layer's parent.

  • platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::shouldSkipLayerInDump): Added.
(WebCore::GraphicsLayerClient::shouldDumpPropertyForLayer): Added.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::shouldSkipLayerInDump):
Added. Always skip the root tile cache's flattening layer, as it is
uninteresting and does not exist in the non-tiled-drawing compositing case.

(WebCore::RenderLayerBacking::shouldDumpPropertyForLayer):
Don't dump drawsContent on the root tile cache.
Don't dump backgroundcolor on the root tile cache, unless it is non-white.
This may require some WebKit2-specific rebaselines, but they will occur later.

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::layerTreeAsText):
If the root tile cache has no composited children, don't dump anything,
to match the traditional case where we drop out of compositing when
we have no reason to be compositing. Except, do dump the root tile cache's
layers if we're specifically being asked to dump tile caches.

  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.txt:
  • platform/mac-wk2/tiled-drawing/sticky/sticky-layers-expected.txt:
  • platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-expected.txt:
  • platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative-expected.txt:
  • platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
  • platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
  • platform/mac-wk2/tiled-drawing/tile-coverage-speculative-expected.txt:
  • platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt:
  • platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration-expected.txt:
  • platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
  • platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
  • platform/mac-wk2/tiled-drawing/use-tiled-drawing-expected.txt:

Rebaseline some tests given these changes.

4:35 PM Changeset in webkit [156748] by Lucas Forschler
  • 1 edit in branches/safari-537-branch/LayoutTests/platform/mac-lion/TestExpectations

Skip Failing tests.

4:28 PM Changeset in webkit [156747] by fpizlo@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

Variable event stream (for DFG OSR exit) should be explicit about where on the stack a SetLocal put a value
https://bugs.webkit.org/show_bug.cgi?id=122178

Reviewed by Geoffrey Garen.

Now if the DFG stores the value of a variable into the stack explicitly via a SetLocal,
it will record where on the stack it stored the value in addition to recording where on
the stack the bytecode would have done the SetLocal. Previously it just recorded the
format and the bytecode variable. Recording just the bytecode variable is currently fine
since the DFG always executes SetLocal's to the same stack location that the bytecode
would have used. But that prevents stack compression (webkit.org/b/122024) so this patch
allows the SetLocal to say both the bytecode variable that we're speaking of and the
actual stack location to which the SetLocal stored the value.

This had to touch a lot of code, so I took the opportunity to also resolve
webkit.org/b/108019.

  • bytecode/Operands.h:

(JSC::Operands::hasOperand):

  • dfg/DFGFlushFormat.h:

(JSC::DFG::dataFormatFor):

  • dfg/DFGMinifiedID.h:

(JSC::DFG::MinifiedID::bits):
(JSC::DFG::MinifiedID::invalidID):
(JSC::DFG::MinifiedID::otherInvalidID):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::recordSetLocal):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGValueSource.cpp:

(JSC::DFG::ValueSource::dump):

  • dfg/DFGValueSource.h:

(JSC::DFG::ValueSource::ValueSource):
(JSC::DFG::ValueSource::forFlushFormat):
(JSC::DFG::ValueSource::forDataFormat):
(JSC::DFG::ValueSource::isSet):
(JSC::DFG::ValueSource::kind):
(JSC::DFG::ValueSource::valueRecovery):
(JSC::DFG::ValueSource::id):
(JSC::DFG::ValueSource::virtualRegister):

  • dfg/DFGVariableEvent.cpp:

(JSC::DFG::VariableEvent::dump):
(JSC::DFG::VariableEvent::dumpSpillInfo):

  • dfg/DFGVariableEvent.h:

(JSC::DFG::VariableEvent::fillGPR):
(JSC::DFG::VariableEvent::fillPair):
(JSC::DFG::VariableEvent::fillFPR):
(JSC::DFG::VariableEvent::spill):
(JSC::DFG::VariableEvent::death):
(JSC::DFG::VariableEvent::setLocal):
(JSC::DFG::VariableEvent::movHint):
(JSC::DFG::VariableEvent::id):
(JSC::DFG::VariableEvent::gpr):
(JSC::DFG::VariableEvent::tagGPR):
(JSC::DFG::VariableEvent::payloadGPR):
(JSC::DFG::VariableEvent::fpr):
(JSC::DFG::VariableEvent::spillRegister):
(JSC::DFG::VariableEvent::bytecodeRegister):
(JSC::DFG::VariableEvent::machineRegister):
(JSC::DFG::VariableEvent::variableRepresentation):

  • dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::reconstruct):

4:18 PM Changeset in webkit [156746] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

FTL: split overflow checks into non-overflow arithmetic and an additional call to the overflow intrinsic check.
https://bugs.webkit.org/show_bug.cgi?id=122170

Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-01
Reviewed by Filip Pizlo.

Overflow intrinsics are preventing SCEV and other LLVM analysis passes from analyzing loops. This patch changes the FTL-IR gen by splitting arithmetic calculations into two parts:

  1. Generate the arithmetic calculation (that may overflow)
  2. Generate the overflow check (that is only used by the OSR-exit logic).

We trust LLVM (SelectionDAG) to merge these calculations into a single opcode.

This JS function:

function foo() {

for (i=0; i < 10000000; i++) { }

}

Is now compiled into this LLVM-IR:

"OSR exit continuation for @24<Int32>": ; preds = %"Block #0", %"OSR exit continuation for @24<Int32>2"

%4 = phi i64 [ %10, %"OSR exit continuation for @24<Int32>2" ], [ -281474976710656, %"Block #0" ]
%5 = trunc i64 %4 to i32
%6 = add i32 %5, 1
%7 = tail call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 %5, i32 1)
%8 = extractvalue { i32, i1 } %7, 1
br i1 %8, label %"OSR exit failCase for @24<Int32>1", label %"OSR exit continuation for @24<Int32>2"

And into this assembly:

LBB0_1: ## %OSR exit continuation for @24<Int32>

## =>This Inner Loop Header: Depth=1

movl %ecx, %esi
incl %esi
jo LBB0_4

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileAddSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):

4:17 PM Changeset in webkit [156745] by Lucas Forschler
  • 1 edit in branches/safari-537-branch/LayoutTests/platform/mac-lion/TestExpectations

<rdar://problem/15126654>

3:59 PM Changeset in webkit [156744] by Lucas Forschler
  • 1 edit in branches/safari-537-branch/LayoutTests/platform/mac-wk2/TestExpectations

Skip failing test.

3:52 PM Changeset in webkit [156743] by mrowe@apple.com
  • 8 edits in trunk/Source/WebKit2

<http://webkit.org/b/122190> WebKit2 APIs returning CF and NS types should explicitly declare whether they return retained objects.

This make the APIs easier to use under ARC and can help out the static analyzer.

Reviewed by Anders Carlsson.

  • Shared/API/c/cf/WKErrorCF.h:
  • Shared/API/c/cf/WKStringCF.h:
  • Shared/API/c/cf/WKURLCF.h:
  • Shared/API/c/cg/WKImageCG.h:
  • Shared/API/c/mac/WKURLRequestNS.h:
  • Shared/API/c/mac/WKURLResponseNS.h:
  • UIProcess/API/C/cg/WKIconDatabaseCG.h:
3:47 PM Changeset in webkit [156742] by joone.hur@intel.com
  • 5 edits
    5 adds in trunk

Quirksmode: CSS1: WebKit fails dynamic :first-letter test
https://bugs.webkit.org/show_bug.cgi?id=15602

Reviewed by David Hyatt.

Source/WebCore:

CSS first-letter property does not work properly when the first letter is changed
by DOM scripting.
This patch allows to check if the existing first-letter is no longer the
first-letter. In this case, it deletes the old first-letter object and creates
a new one. For the remaining text, the oldRemainingText object is used
again for containing the full text(first letter + remaining text).

Test: fast/css/first-letter-block-change.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter):

LayoutTests:

Add a test case that ensures that CSS first-letter property should work
properly when the first letter is changed by DOM scripting.

  • fast/css/first-letter-block-change.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk-wk1/fast/css/first-letter-block-change-expected.png: Added.
  • platform/gtk-wk2/fast/css/first-letter-block-change-expected.png: Added.
  • platform/gtk/fast/css/first-letter-block-change-expected.txt: Added.
  • platform/mac/TestExpectations:
3:45 PM Changeset in webkit [156741] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardening.

  • platform/win/TestExpectations: Update TestExpectations for two crashes that were not

previously logged, one image-only failure, another broken test due to the media changes.

3:45 PM Changeset in webkit [156740] by ap@apple.com
  • 3 edits in trunk/Tools

[Mac] Set NSApplication current event while sending events directly to views
https://bugs.webkit.org/show_bug.cgi?id=122179

Reviewed by Darin Adler.

DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView,
which doesn't update [NSApp currentEvent]. But there are many places in WebKit that
use the current event.

  • DumpRenderTree/mac/EventSendingController.mm:

(-[EventSendingController mouseDown:withModifiers:]):
(-[EventSendingController mouseUp:withModifiers:]):
(-[EventSendingController mouseMoveToX:Y:]):
(-[EventSendingController mouseScrollByX:andY:continuously:]):
(-[EventSendingController contextClick]):
(-[EventSendingController keyDown:withModifiers:withLocation:]):

  • WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::mouseScrollBy):
Update the current event. We were already using the SPI in WebKit.

3:34 PM Changeset in webkit [156739] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
https://bugs.webkit.org/show_bug.cgi?id=122183

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-01
Reviewed by Timothy Hatcher.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration.prototype.update):

3:29 PM Changeset in webkit [156738] by Antti Koivisto
  • 32 edits in trunk/Source/WebCore

Make tests for renderer base types non-virtual
https://bugs.webkit.org/show_bug.cgi?id=122185

Reviewed by Dave Hyatt.

Make isRenderFoo() functions for commonly tested base types use bit flags instead of virtual calls.
This is faster and we have space in RenderElement.

These bits are not mutully exclusive. For testing leaf types we can add an enum.

3:22 PM Changeset in webkit [156737] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[Windows] Unreviewed gardening. Skip fast/events/drag-and-drop-autoscroll-inner-frame.html.

Drag and drop does not work on Windows DRT.

  • platform/win/TestExpectations:
3:04 PM Changeset in webkit [156736] by timothy@apple.com
  • 7 edits
    1 add in trunk/Tools

Tweaks to the Buildbot Dashboard

https://bugs.webkit.org/show_bug.cgi?id=122169

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:

(BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:

(BuildbotQueueView.prototype.revisionLinksForIteration):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot.prototype.buildLogURLForIteration):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2:49 PM Changeset in webkit [156735] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed build fix after r156730.
https://bugs.webkit.org/show_bug.cgi?id=122021

  • platform/win/TestExpectations: Disable a number of tests broken by the switch to the new

CSS/JS-based media controls.

2:26 PM Changeset in webkit [156734] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Consolidate multiple OSRExit calls into one.
https://bugs.webkit.org/show_bug.cgi?id=122168

Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-01
Reviewed by Filip Pizlo.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithDiv):
(JSC::FTL::LowerDFGToLLVM::compileArithMod):

2:12 PM Changeset in webkit [156733] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Cleanup Document::dispatchFullScreenChangeOrErrorEvent
https://bugs.webkit.org/show_bug.cgi?id=122143

Reviewed by Antti Koivisto.

Reduce the code duplication by extracting dispatchFullScreenChangeOrErrorEvent.

  • dom/Document.cpp:

(WebCore::Document::fullScreenChangeDelayTimerFired):
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent): Extracted.

  • dom/Document.h:
1:45 PM Changeset in webkit [156732] by ap@apple.com
  • 2 edits in trunk/LayoutTests

fast/forms/search-event-delay.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=53990

1:38 PM Changeset in webkit [156731] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r156725.
http://trac.webkit.org/changeset/156725
https://bugs.webkit.org/show_bug.cgi?id=122176

broke all the mismatch tests again (Requested by thorton on
#webkit).

Tools:

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):

LayoutTests:

  • platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Removed.
  • platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Removed.
1:33 PM Changeset in webkit [156730] by Brent Fulgham
  • 9 edits in trunk

Source/WebCore: [Win] Implement the media controls in JavaScript
https://bugs.webkit.org/show_bug.cgi?id=122166

Reviewed by Jer Noble.

  • DerivedSources.make: Uncomment feature flag test.
  • WebCore.vcxproj/WebCore.vcxproj: Add new media control implementation files.

Also cleaned up some misplaced files in the project tree.

  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.vcxproj/WebCoreCommon.props: Add missing include path for the

mediacontrols path.

  • WebCore.vcxproj/copyForwardingHeaders.cmd: Add Modules/mediacontrols to copied headers.
  • rendering/RenderThemeWin.cpp: Add missing include for UserAgentScripts.

WebKitLibraries: [Win] Implement the media controls in JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=122166

Reviewed by Jer Noble.

  • win/tools/vsprops/FeatureDefines.props: Activate the

ENABLE_MEDIA_CONTROLS_SCRIPT flag.

1:20 PM Changeset in webkit [156729] by commit-queue@webkit.org
  • 8 edits in trunk

Source/WebCore: Added adoptCOM to COMPtr on Windows.
https://bugs.webkit.org/show_bug.cgi?id=122069

Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-01
Reviewed by Brent Fulgham.

  • platform/win/COMPtr.h:

(adoptCOM): Added.

Source/WebKit/win: Implemented createWebViewWithRequest in WinLauncher.
https://bugs.webkit.org/show_bug.cgi?id=122069

Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-01
Reviewed by Brent Fulgham.

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::createWindow):

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchCreatePage):
Pass request url from the NavigationAction to createWebViewWithRequest.

Tools: Implemented createWebViewWithRequest in WinLauncher.
https://bugs.webkit.org/show_bug.cgi?id=122069

Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-01
Reviewed by Brent Fulgham.

  • WinLauncher/PrintWebUIDelegate.cpp:

(PrintWebUIDelegate::createWebViewWithRequest): Added.

  • WinLauncher/PrintWebUIDelegate.h:

Removed createWebViewWithRequest stub.

12:55 PM Changeset in webkit [156728] by Antoine Quint
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: evaluate and show a popover for selected text in JS source when paused
https://bugs.webkit.org/show_bug.cgi?id=122151

Reviewed by Joseph Pecoraro.

Identify if the hovered token is contained within the text selection (if any) and use
the selection as the hovered expression to allow the user to select text and hover it
to see what it evaluates to.

  • UserInterface/CodeMirrorTokenTrackingController.js:

(WebInspector.CodeMirrorTokenTrackingController.prototype.highlightRange):
Check we're trying to highlight a different range before removing the highlight
and applying the new one, this prevents the marked text from flashing if it's
being re-hovered which would easily happen when hovering multiple tokens within
the same selection.

(WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
In the case where there is selected text, check whether the hovered token is at least
partially contained within the selection, and if so use the selection text as the
hovered expression to evaluate.

12:32 PM Changeset in webkit [156727] by Antoine Quint
  • 2 edits in trunk/Source/WebInspectorUI

Console buttons don’t show after page reload
https://bugs.webkit.org/show_bug.cgi?id=116515

Reviewed by Darin Adler.

The correct display of navigation items in the ContentBrowser is contingent on
the ContentViewContainer's _backForwardList being up-to-date when the navigation
items are retrieved from it. However, when the main resource changes (in this case
the user refreshes the browser), calls are made to ContentViewContainer's
closeAllContentViewsOfPrototype() which may modify the _backForwardList but doesn't
necessarily notify of a change to the currentContentView since we may be still showing
the same view in case it wasn't directly related to the main resource, for instance
the console log.

We now check if the _backForwardList is changed as a result of calling
closeAllContentViewsOfPrototype() and in that case also dispatch the
CurrentContentViewDidChange event which will restore the correct state
for the back/forward buttons and navigation items of the navigation bar.

  • UserInterface/ContentViewContainer.js:

(WebInspector.ContentViewContainer.prototype.closeAllContentViewsOfPrototype):
Track changes to the _backForwardList and dispatch the CurrentContentViewDidChange
event in case such changes happened.

12:31 PM Changeset in webkit [156726] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

Unreviewed build fix; The addedFunction and removedFunction arguments to determineChangedTracksFromNewTracksAndOldItems
were reversed, exposing an underlying, existing bug in AudioTrackPrivate and VideoTrack private. Give a default (null)
value to AudioTrackPrivate::m_client and VideoTrackPrivate::m_client and fix the ordering of arguments in
determineChangedTracksFromNewTracksAndOldItems.

  • platform/graphics/AudioTrackPrivate.h:

(WebCore::AudioTrackPrivate::AudioTrackPrivate):

  • platform/graphics/VideoTrackPrivate.h:

(WebCore::VideoTrackPrivate::VideoTrackPrivate):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::determineChangedTracksFromNewTracksAndOldItems):

11:50 AM Changeset in webkit [156725] by timothy_horton@apple.com
  • 3 edits
    2 adds in trunk

[wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
https://bugs.webkit.org/show_bug.cgi?id=122006
<rdar://problem/15095197>

Reviewed by Dean Jackson.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):
Layer-back the root view in WebKitTestRunner's window, to work around a bug
where the window server snapshot API returns blank snapshots.

Re-landing after r156724, this should not break everything now.

Add a test that ensures that WebKitTestRunner's snapshots are not
completely blank with tiled drawing enabled.

  • platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Added.
  • platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Added.
11:46 AM Changeset in webkit [156724] by timothy_horton@apple.com
  • 6 edits in trunk/Tools

[mac] 1x emulation on Retina hardware shouldn't use SPI
https://bugs.webkit.org/show_bug.cgi?id=122152
<rdar://problem/15119384>

Reviewed by Anders Carlsson.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):
(main):

  • DumpRenderTree/mac/DumpRenderTreeWindow.h:
  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:
  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/mac/main.mm:

(main):
Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.

11:45 AM Changeset in webkit [156723] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

SpeculativeJIT::m_arguments/m_variables are vestiges of a time long gone
https://bugs.webkit.org/show_bug.cgi?id=122140

Reviewed by Darin Adler.

Just killing code.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::recordSetLocal):

11:41 AM WebKitGTK/2.2.x edited by jmunhoz@igalia.com
(diff)
11:40 AM WebKitGTK/2.0.x edited by jmunhoz@igalia.com
(diff)
11:36 AM WebKitGTK/2.2.x edited by jmunhoz@igalia.com
(diff)
11:24 AM Changeset in webkit [156722] by jer.noble@apple.com
  • 7 edits
    3 copies
    4 adds in trunk

[Mac] Add support for VideoTrack to MediaPlayerPrivateAVFObjC
https://bugs.webkit.org/show_bug.cgi?id=122122

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/video-track.html

Refactor the methods which query AVAssetTrack and AVPlayerItemTrack into an Impl class, and
use that class to reset the properties of both AudioTrackAVFObjC and the new VideoTrackAVFObjC.

Add new files to project:

  • WebCore.xcodeproj/project.pbxproj:

Add the new implementation class, shared by AudioTrackAVFObjC and VideoTrackAVFObjC:

  • platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.h: Added.

(WebCore::AVTrackPrivateAVFObjCImpl::create): Simple factory.
(WebCore::AVTrackPrivateAVFObjCImpl::playerItemTrack): Simple getter.

  • platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm: Added.

(WebCore::AVTrackPrivateAVFObjCImpl::AVTrackPrivateAVFObjCImpl): Simple constructor.
(WebCore::AVTrackPrivateAVFObjCImpl::enabled): Pass to AVPlayerItemTrack.
(WebCore::AVTrackPrivateAVFObjCImpl::setEnabled): Ditto.
(WebCore::AVTrackPrivateAVFObjCImpl::audioKind): Distinguish between Alternative and Main content.
(WebCore::AVTrackPrivateAVFObjCImpl::videoKind): Distinguish between Alternative, Main, Caption,

and Description content.

(WebCore::AVTrackPrivateAVFObjCImpl::id): Pass to AVAssetTrack.
(WebCore::AVTrackPrivateAVFObjCImpl::label): Retrieve the Title metadata in the user's preferred

language.

(WebCore::AVTrackPrivateAVFObjCImpl::language): Pass to languageForAVAssetTrack.
(WebCore::AVTrackPrivateAVFObjCImpl::languageForAVAssetTrack): Moved from AudioTrackPrivateAVFObjC.

  • platform/graphics/avfoundation/VideoTrackPrivateAVF.h: Copied from Source/WebCore/platform/graphics/avfoundation/AudioTrackPrivateAVF.h.

(WebCore::VideoTrackPrivateAVF::kind): Simple getter.
(WebCore::VideoTrackPrivateAVF::id): Ditto.
(WebCore::VideoTrackPrivateAVF::label): Ditto.
(WebCore::VideoTrackPrivateAVF::language): Ditto.
(WebCore::VideoTrackPrivateAVF::setKind): Simple setter.
(WebCore::VideoTrackPrivateAVF::setId): Ditto.
(WebCore::VideoTrackPrivateAVF::setLabel): Ditto.
(WebCore::VideoTrackPrivateAVF::setLanguage): Ditto.
(WebCore::VideoTrackPrivateAVF::VideoTrackPrivateAVF): Simple constructor.

  • platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:

(WebCore::AudioTrackPrivateAVFObjC::AudioTrackPrivateAVFObjC): Create a AVTrackPrivateAVFObjCImpl.
(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack): Retrieve properties from m_impl.
(WebCore::AudioTrackPrivateAVFObjC::setPlayerItemTrack): Create a new AVTrackPrivateAVFObjCImpl.
(WebCore::AudioTrackPrivateAVFObjC::playerItemTrack): Pass to m_impl.
(WebCore::AudioTrackPrivateAVFObjC::setEnabled): Ditto.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Refactor implementation into

template method determineChangedTracksFromNewTracksAndOldItems().

(WebCore::determineChangedTracksFromNewTracksAndOldItems): Refactored.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks): Pass to determineChangedTracksFromNewTracksAndOldItems.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Changed class hosting

languageForAVAssetTrack.

  • platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp: Added.

(WebCore::VideoTrackPrivateAVFObjC::VideoTrackPrivateAVFObjC): Create a AVTrackPrivateAVFObjCImpl.
(WebCore::VideoTrackPrivateAVFObjC::resetPropertiesFromTrack): Retrieve properties from m_impl.
(WebCore::VideoTrackPrivateAVFObjC::setPlayerItemTrack): Create a new AVTrackPrivateAVFObjCImpl.
(WebCore::VideoTrackPrivateAVFObjC::playerItemTrack): Pass to m_impl.
(WebCore::VideoTrackPrivateAVFObjC::setSelected): Ditto.

  • platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h: Added.

(WebCore::VideoTrackPrivateAVFObjC::create): Simple factory.

LayoutTests:

  • media/track/video-track-expected.txt: Added.
  • media/track/video-track.html: Added.
10:22 AM Changeset in webkit [156721] by Lucas Forschler
  • 5 edits in branches/safari-537.73-branch/Source

Versioning.

10:20 AM Changeset in webkit [156720] by Lucas Forschler
  • 7 edits in branches/safari-537.73-branch/Source

rollout 156718.

10:20 AM Changeset in webkit [156719] by akling@apple.com
  • 23 edits in trunk/Source/WebCore

Leaf EventTarget subclasses should be FINAL.
<https://webkit.org/b/122141>

Reviewed by Darin Adler.

Clear out a slew of FIXMEs now that HasMemoryCostMemberFunction
works on classes marked FINAL (fixed in bug 121747.)

10:19 AM Changeset in webkit [156718] by Lucas Forschler
  • 7 edits in branches/safari-537.73-branch/Source

Versioning.

10:03 AM Changeset in webkit [156717] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Rename URL type variables in Curl network backend.
https://bugs.webkit.org/show_bug.cgi?id=122158

Patch by Szabolcs Dávid <davidsz@inf.u-szeged.hu> on 2013-10-01
Reviewed by Darin Adler.

I changed the name of the URL objects to match with the new class name.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::getProtectionSpace):
(WebCore::ResourceHandleManager::initializeHandle):

9:59 AM Changeset in webkit [156716] by commit-queue@webkit.org
  • 4 edits in trunk

Center misspelling dots across width of word
https://bugs.webkit.org/show_bug.cgi?id=122046

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-01
Reviewed by Darin Adler.

Source/WebCore:

Test: editing/spelling/spelling.html

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::GraphicsContext::drawLineForDocumentMarker):

LayoutTests:

This patch only rebaselines a single test. I would have rebaselined
the rest of the tests, but they seem to be affected by
webkit.org/b/122146. I don't want to commit incorrect expected results.

  • platform/mac/editing/spelling/spelling-expected.png:
9:40 AM Changeset in webkit [156715] by dbates@webkit.org
  • 5 edits in trunk/Source/WebCore

[iOS] WebCore fails to build with newer versions of clang
https://bugs.webkit.org/show_bug.cgi?id=122161

Reviewed by Darin Adler.

  • editing/FrameSelection.cpp: Add ENABLE(TEXT_CARET)-guard around shouldStopBlinkingDueToTypingCommand().
  • page/EventHandler.cpp: Add !PLATFORM(IOS)-guard around constants cursorUpdateInterval and maximumCursorSize;

also add touch event/gesture event guard around shouldGesturesTriggerActive().

  • platform/network/cf/ResourceResponseCFNet.cpp: Remove unused function filenameHasSaneExtension.
  • platform/network/mac/ResourceResponseMac.mm: Only define static variables commonHeaderFields when building

without CFNetwork; also remove variable numCommonHeaderFields, instead use WTF_ARRAY_LENGTH(commonHeaderFields)
to compute the size of the fixed-sized array commonHeaderFields.

9:39 AM Changeset in webkit [156714] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[iOS] JavaScriptCore fails to build with newer versions of clang
https://bugs.webkit.org/show_bug.cgi?id=122162

Reviewed by Darin Adler.

  • runtime/GCActivityCallback.cpp: Add !PLATFORM(IOS)-guard around constant pagingTimeOut

as we don't compile the code that uses it on iOS.

9:26 AM Changeset in webkit [156713] by commit-queue@webkit.org
  • 24 edits
    2 copies
    1 add in trunk

[GStreamer] Support "chapter" text tracks
https://bugs.webkit.org/show_bug.cgi?id=122000

Patch by Brendan Long <b.long@cablelabs.com> on 2013-10-01
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/in-band/track-in-band-mkv-chapters.html

  • platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h: New class, needed for cues that aren't associated with GstPads.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Check for table of contents messages.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents): Parse table of contents messages into text tracks.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContentsEntry): Recursive method for parsing all of the TOC entries.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Add the processTableOfContents functions.

LayoutTests:

  • media/content/counting-subtitled-srt.mkv: Added chapters metadata.
  • media/track/in-band/track-in-band-mkv-chapters-expected.txt: New test, similar to cues-added-one, but uses "chapters" track.
  • media/track/in-band/track-in-band-mkv-chapters.html: Same.
  • media/in-band-cues.js: Updated tests to handle the new "chapters" track.
  • media/track/in-band/track-in-band-kate-ogg-cues-added-once-expected.txt: Same.
  • media/track/in-band/track-in-band-kate-ogg-cues-added-once.html: Same.
  • media/track/in-band/track-in-band-kate-ogg-mode-expected.txt: Same.
  • media/track/in-band/track-in-band-kate-ogg-mode.html: Same.
  • media/track/in-band/track-in-band-kate-ogg-style-expected.txt: Same.
  • media/track/in-band/track-in-band-kate-ogg-track-order-expected.txt: Same.
  • media/track/in-band/track-in-band-kate-ogg-track-order.html: Same.
  • media/track/in-band/track-in-band-srt-mkv-cues-added-once-expected.txt: Same.
  • media/track/in-band/track-in-band-srt-mkv-cues-added-once.html: Same.
  • media/track/in-band/track-in-band-srt-mkv-kind-expected.txt: Same.
  • media/track/in-band/track-in-band-srt-mkv-kind.html: Same.
  • media/track/in-band/track-in-band-srt-mkv-language-expected.txt: Same.
  • media/track/in-band/track-in-band-srt-mkv-language.html: Same.
  • media/track/in-band/track-in-band-srt-mkv-mode-expected.txt: Same.
  • media/track/in-band/track-in-band-srt-mkv-mode.html: Same.
  • media/track/in-band/track-in-band-srt-mkv-style-expected.txt: Same.
  • media/track/in-band/track-in-band-srt-mkv-track-order-expected.txt: Same.
  • media/track/in-band/track-in-band-srt-mkv-track-order.html: Same.
9:14 AM Changeset in webkit [156712] by Darin Adler
  • 2 edits in trunk/LayoutTests

Try to get another Windows test to pass.

  • platform/win/js/dom/global-constructors-attributes-expected.txt: Removed one

more class (Notification) for a feature turned off for the Windows platform.

8:02 AM Changeset in webkit [156711] by Darin Adler
  • 1 edit
    1 add in trunk/LayoutTests

Try to get another Windows test to pass.

  • platform/win/js/dom/global-constructors-attributes-expected.txt: Added.

Copy of the platform-independent results file, with items deleted for features
that are currently turned off for the Windows platform.

7:58 AM Changeset in webkit [156710] by allan.jensen@digia.com
  • 3 edits in trunk/Source/WebCore

[Texmap] CSS filter not working on software composited layers
https://bugs.webkit.org/show_bug.cgi?id=122159

Reviewed by Noam Rosenthal.

Tell the rendering layer we do not support CSS filters when we do not. This
will make RenderLayer fall back to using its own software implementation.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setFilters):

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::applyFilters):

5:34 AM Changeset in webkit [156709] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Try to fix assertion failures seem on bots.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::createFilterOperations): Rearrange code so this
won't try ot call toCSSPrimitiveValue on a non-primitive-value in the
DROP_SHADOW case.

5:09 AM Changeset in webkit [156708] by zandobersek@gmail.com
  • 1 edit in trunk/Source/WebCore/ChangeLog

Fix the 'InexedDB' typo in the ChangeLog that I failed to address prior to landing r156701.

4:57 AM Changeset in webkit [156707] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Adding failure expectations for currently failing tests.

  • platform/gtk/TestExpectations:
4:38 AM Changeset in webkit [156706] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebKit2

[Qt][WK2] Fix build after r156688.
https://bugs.webkit.org/show_bug.cgi?id=122153

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-10-01
Reviewed by Allan Sandfeld Jensen.

  • Shared/qt/ShareableBitmapQt.cpp:

(WebKit::ShareableBitmap::createGraphicsContext):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::createDrawingAreaProxy):

  • UIProcess/API/qt/qquickwebview_p_p.h:
  • UIProcess/API/qt/raw/qrawwebview.cpp:

(QRawWebViewPrivate::createDrawingAreaProxy):

  • UIProcess/API/qt/raw/qrawwebview_p_p.h:
  • UIProcess/qt/QtPageClient.cpp:

(WebKit::QtPageClient::createDrawingAreaProxy):

  • UIProcess/qt/QtPageClient.h:
  • WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:

(WebKit::convertQPixmapToShareableBitmap):

3:50 AM Changeset in webkit [156705] by gyuyoung.kim@samsung.com
  • 21 edits in trunk/Source/WebCore

Generate toCSSFooValue for CSSPrimitiveValue
https://bugs.webkit.org/show_bug.cgi?id=122101

Reviewed by Antti Koivisto.

As a step of clean-up static_cast<> in CSSValues, this patch generates
toCSSFooPrimitiveValue() in order to detect bad casts as well as improves
code readability.

No new tests, no behavior changes.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::subimageIsPending):
(WebCore::CSSImageGeneratorValue::cachedImageForCSSValue):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::fillImageSet):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::parseRadialGradient):

  • css/CSSPrimitiveValue.h:
  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapFillAttachment):
(WebCore::CSSToStyleMap::mapFillClip):
(WebCore::CSSToStyleMap::mapFillComposite):
(WebCore::CSSToStyleMap::mapFillBlendMode):
(WebCore::CSSToStyleMap::mapFillOrigin):
(WebCore::CSSToStyleMap::mapFillRepeatX):
(WebCore::CSSToStyleMap::mapFillRepeatY):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapFillMaskSourceType):
(WebCore::CSSToStyleMap::mapAnimationDelay):
(WebCore::CSSToStyleMap::mapAnimationDirection):
(WebCore::CSSToStyleMap::mapAnimationDuration):
(WebCore::CSSToStyleMap::mapAnimationFillMode):
(WebCore::CSSToStyleMap::mapAnimationIterationCount):
(WebCore::CSSToStyleMap::mapAnimationName):
(WebCore::CSSToStyleMap::mapAnimationPlayState):
(WebCore::CSSToStyleMap::mapAnimationProperty):
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
(WebCore::CSSToStyleMap::mapNinePieceImageRepeat):

  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyMarqueeIncrement::applyValue):
(WebCore::ApplyPropertyMarqueeRepetition::applyValue):
(WebCore::ApplyPropertyMarqueeSpeed::applyValue):
(WebCore::ApplyPropertyTextUnderlinePosition::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyTextIndent::applyValue):

  • css/MediaList.cpp:

(WebCore::reportMediaQueryWarningIfNeeded):

  • css/MediaQueryEvaluator.cpp:

(WebCore::numberValue):
(WebCore::orientationMediaFeatureEval):
(WebCore::evalResolution):
(WebCore::device_pixel_ratioMediaFeatureEval):
(WebCore::resolutionMediaFeatureEval):
(WebCore::computeLength):
(WebCore::view_modeMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getLayeredShorthandValue):

  • css/StyleResolver.cpp:

(WebCore::createGridTrackSize):
(WebCore::createGridTrackList):
(WebCore::createGridPosition):
(WebCore::hasVariableReference):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::parseCustomFilterArrayParameter):
(WebCore::StyleResolver::parseCustomFilterColorParameter):
(WebCore::StyleResolver::parseCustomFilterNumberParameter):
(WebCore::StyleResolver::parseCustomFilterParameter):
(WebCore::StyleResolver::parseCustomFilterParameterList):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):

  • css/TransformFunctions.cpp:

(WebCore::transformsForValue):

  • css/ViewportStyleResolver.cpp:

(WebCore::ViewportStyleResolver::getViewportArgumentValue):

  • css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::setMatrixValue):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::computedFontSize):

  • editing/EditingStyle.cpp:

(WebCore::identifierForStyleProperty):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(WebCore::cssValueToRGBA):
(WebCore::EditingStyle::extractFontSizeDelta):
(WebCore::EditingStyle::textDirection):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::EditingStyle::legacyFontSize):
(WebCore::EditingStyle::textDirectionForSelection):
(WebCore::StyleChange::extractTextStyles):
(WebCore::fontWeightIsBold):
(WebCore::isTransparentColorValue):

  • editing/markup.cpp:

(WebCore::propertyMissingOrEqualToNone):

3:36 AM Changeset in webkit [156704] by Darin Adler
  • 1 edit
    25 moves
    2 adds in trunk/LayoutTests

Move platform-specific test results from js to js/dom to match moves in r156066.

I see multiple check-ins with people doing this for some files, but these seem to have been missed.
Maybe some of these are unneeded and can be removed.

My hope is that this might help with some failures seen on the Windows bot.

  • platform/blackberry/js/dom/constructor-length-expected.txt: Renamed from LayoutTests/platform/blackberry/js/constructor-length-expected.txt.
  • platform/efl/js/dom/constructor-length-expected.txt: Renamed from LayoutTests/platform/efl/js/constructor-length-expected.txt.
  • platform/efl/js/dom/dom-static-property-for-in-iteration-expected.txt: Renamed from LayoutTests/platform/efl/js/dom-static-property-for-in-iteration-expected.txt.
  • platform/efl/js/dom/exception-linenums-in-html-3-expected.png: Renamed from LayoutTests/platform/efl/js/exception-linenums-in-html-3-expected.png.
  • platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Renamed from LayoutTests/platform/efl/js/global-constructors-attributes-dedicated-worker-expected.txt.
  • platform/efl/js/dom/global-constructors-attributes-shared-worker-expected.txt: Renamed from LayoutTests/platform/efl/js/global-constructors-attributes-shared-worker-expected.txt.
  • platform/efl/js/dom/missing-style-end-tag-js-expected.png: Renamed from LayoutTests/platform/efl/js/missing-style-end-tag-js-expected.png.
  • platform/efl/js/dom/missing-title-end-tag-js-expected.png: Renamed from LayoutTests/platform/efl/js/missing-title-end-tag-js-expected.png.
  • platform/gtk/js/dom/constructor-length-expected.txt: Renamed from LayoutTests/platform/gtk/js/constructor-length-expected.txt.
  • platform/gtk/js/dom/exception-linenums-in-html-3-expected.png: Renamed from LayoutTests/platform/gtk/js/exception-linenums-in-html-3-expected.png.
  • platform/gtk/js/dom/missing-style-end-tag-js-expected.png: Renamed from LayoutTests/platform/gtk/js/missing-style-end-tag-js-expected.png.
  • platform/gtk/js/dom/missing-title-end-tag-js-expected.png: Renamed from LayoutTests/platform/gtk/js/missing-title-end-tag-js-expected.png.
  • platform/mac/js/dom/exception-linenums-in-html-3-expected.png: Renamed from LayoutTests/platform/mac/js/exception-linenums-in-html-3-expected.png.
  • platform/mac/js/dom/missing-style-end-tag-js-expected.png: Renamed from LayoutTests/platform/mac/js/missing-style-end-tag-js-expected.png.
  • platform/mac/js/dom/missing-title-end-tag-js-expected.png: Renamed from LayoutTests/platform/mac/js/missing-title-end-tag-js-expected.png.
  • platform/qt/js/dom/constructor-length-expected.txt: Renamed from LayoutTests/platform/qt/js/constructor-length-expected.txt.
  • platform/qt/js/dom/date-DST-time-cusps-expected.txt: Renamed from LayoutTests/platform/qt/js/date-DST-time-cusps-expected.txt.
  • platform/qt/js/dom/dom-static-property-for-in-iteration-expected.txt: Renamed from LayoutTests/platform/qt/js/dom-static-property-for-in-iteration-expected.txt.
  • platform/qt/js/dom/exception-linenums-in-html-3-expected.png: Renamed from LayoutTests/platform/qt/js/exception-linenums-in-html-3-expected.png.
  • platform/qt/js/dom/missing-style-end-tag-js-expected.png: Renamed from LayoutTests/platform/qt/js/missing-style-end-tag-js-expected.png.
  • platform/qt/js/dom/missing-title-end-tag-js-expected.png: Renamed from LayoutTests/platform/qt/js/missing-title-end-tag-js-expected.png.
  • platform/qt/js/dom/switch-behaviour-expected.txt: Renamed from LayoutTests/platform/qt/js/switch-behaviour-expected.txt.
  • platform/win/js/dom/dom-static-property-for-in-iteration-expected.txt: Renamed from LayoutTests/platform/win/js/dom-static-property-for-in-iteration-expected.txt.
  • platform/win/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Renamed from LayoutTests/platform/win/js/global-constructors-attributes-dedicated-worker-expected.txt.
  • platform/win/js/dom/global-constructors-attributes-shared-worker-expected.txt: Renamed from LayoutTests/platform/win/js/global-constructors-attributes-shared-worker-expected.txt.
2:59 AM Changeset in webkit [156703] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Try to fix AVFoundation crashes seen on Lion bot.

  • platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:

Four AVFoundation string constants used in this file were new to 10.8.
For older versions of OS X, use hard-coded string constants instead.

2:37 AM Changeset in webkit [156702] by zandobersek@gmail.com
  • 6 edits
    6 adds
    2 deletes in trunk/LayoutTests

Unreviewed GTK gardening. Rebaselining after r156527, moving baselines specific to GTK WK1
under the platform/gtk-wk1 directory.

  • platform/gtk-wk1/js: Added.
  • platform/gtk-wk1/js/dom: Added.
  • platform/gtk-wk1/js/dom/function-length-expected.txt: Added.
  • platform/gtk-wk1/scrollingcoordinator: Added.
  • platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
  • platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.
  • platform/gtk/js/dom/function-length-expected.txt: Removed.
  • platform/gtk/scrollingcoordinator: Removed.
  • platform/gtk/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Removed.
  • platform/gtk/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Removed.
  • platform/gtk/svg/custom/SVGPoint-matrixTransform-expected.txt:
  • platform/gtk/svg/custom/getTransformToElement-expected.txt:
  • platform/gtk/svg/custom/text-ctm-expected.txt:
  • platform/gtk/svg/custom/text-hit-test-expected.txt:
  • platform/gtk/svg/text/append-text-node-to-tspan-expected.txt:
1:12 AM Changeset in webkit [156701] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

[InexedDB] Interfaces inheriting from EventTarget should generate JSC (un)wrapping functions
https://bugs.webkit.org/show_bug.cgi?id=122114

Reviewed by Darin Adler.

After r156590, four IndexedDB interfaces are inheriting from the EventTarget interface. Because of that,
they're now required to have interface-specific JSC wrapping and unwrapping functions generated since the
JSC wrapping and unwrapping functions for the EventTarget interface delegate these operations to these
interface-specific functions. If the functions are not generated and accessible, the EventTarget functions
end up recursively calling themselves.

  • Modules/indexeddb/IDBDatabase.idl:
  • Modules/indexeddb/IDBOpenDBRequest.idl:
  • Modules/indexeddb/IDBRequest.idl:
  • Modules/indexeddb/IDBTransaction.idl:

Sep 30, 2013:

11:37 PM Changeset in webkit [156700] by ryuan.choi@samsung.com
  • 18 edits in trunk/Source

Build fix for EFL, Qt, Gtk port after r156688
https://bugs.webkit.org/show_bug.cgi?id=122139

Reviewed by Anders Carlsson.

Get rid of more uses of OwnPtr and PassOwnPtr.

Source/WebCore:

  • platform/graphics/surfaces/GraphicsSurface.cpp:

(WebCore::GraphicsSurface::beginPaint):

  • platform/graphics/surfaces/GraphicsSurface.h:
  • platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp:

(WebCore::GraphicsSurface::platformBeginPaint):

  • platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:

(WebCore::GraphicsSurface::platformBeginPaint):

  • platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:

(WebCore::GraphicsSurface::platformBeginPaint):

Source/WebKit2:

  • Shared/API/c/cairo/WKImageCairo.cpp:

(WKImageCreateFromCairoSurface):

  • Shared/API/c/qt/WKImageQt.cpp:

(WKImageCreateFromQImage):

  • Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:

(WebKit::WebCoordinatedSurface::createGraphicsContext):
(WebKit::WebCoordinatedSurface::paintToSurface):

  • Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
  • Shared/cairo/ShareableBitmapCairo.cpp:

(WebKit::ShareableBitmap::createGraphicsContext):

  • Shared/gtk/ArgumentCodersGtk.cpp:

(CoreIPC::encodeImage):

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::createDrawingAreaProxy):

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::createDrawingAreaProxy):

  • UIProcess/CoordinatedGraphics/WebView.h:
  • WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:

(WebKit::convertCairoSurfaceToShareableBitmap):

11:12 PM Changeset in webkit [156699] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Layout Test media/click-volume-bar-not-pausing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122126

Reviewed by Darin Adler.

Speculative partial fix.

I'm not sure if it's possible to make this test completely controlled without
DOMFrameContentLoaded support - we need to do work when the <video> element is
already present, but playback hasn't started yet. As media documents use autoplay,
there is a race between load and playing events.

  • media/click-volume-bar-not-pausing-expected.txt:
  • media/click-volume-bar-not-pausing.html:
    • Add video URL after initial content fully loads to avoid races with that.
    • Added some state logging for clarity.
    • Only listen for "playing" event once. If playback already started, we have a playing event already queued, and would add another one with pause()/play().
10:58 PM Changeset in webkit [156698] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

AX: Expose ARIA Busy Notifications
https://bugs.webkit.org/show_bug.cgi?id=121451

Patch by Sam White <Samuel White> on 2013-09-30
Reviewed by Chris Fleizach.

Source/WebCore:

Added AXElementBusyChanged notification that posts when aria-busy is toggled. This
enables screen readers to detect busy states without polling the focused element.

Test: platform/mac/accessibility/element-busy-changed.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAttributeChanged):

  • accessibility/AXObjectCache.h:
  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

LayoutTests:

Added test to verify that elements post AXElementBusyChanged notifications when aria-busy is toggled.

  • platform/mac/accessibility/element-busy-changed-expected.txt: Added.
  • platform/mac/accessibility/element-busy-changed.html: Added.
10:16 PM Changeset in webkit [156697] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit/efl

Fix the build.

  • ewk/ewk_settings.cpp:
10:10 PM Changeset in webkit [156696] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fixing the build.

  • GNUmakefile.list.am:
9:59 PM Changeset in webkit [156695] by weinig@apple.com
  • 5 edits in trunk/Source/WebCore

More build fixing.

  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InstrumentingAgents.h:
9:57 PM Changeset in webkit [156694] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

check-webkit-style should not warn about use of C++11 “>>” instead of “> >"
https://bugs.webkit.org/show_bug.cgi?id=116474

Patch by Sam Weinig <sam@webkit.org> on 2013-09-30
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
9:47 PM Changeset in webkit [156693] by weinig@apple.com
  • 4 edits in trunk/Source/WebCore

Fix the Efl and Gtk builds.

  • GNUmakefile.list.am:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
9:33 PM Changeset in webkit [156692] by weinig@apple.com
  • 75 edits
    51 deletes in trunk

Remove support for DOMFileSystem
https://bugs.webkit.org/show_bug.cgi?id=122137

Reviewed by Anders Carlsson.

.:

  • Source/autotools/SetupWebKitFeatures.m4:
  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Files elided *

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::clearWebFileSystem):

  • WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/efl:

  • ewk/ewk_settings.cpp:

(ewk_settings_file_system_path_set):

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • Scripts/webkitpy/style/checkers/cpp.py:

(check_spacing):

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest.test_spacing_for_binary_ops):

  • qmake/mkspecs/features/features.pri:

LayoutTests:

  • fast/dom/MutationObserver/filesystem-callback-delivery-expected.txt: Removed.
  • fast/dom/MutationObserver/filesystem-callback-delivery.html: Removed.
  • fast/filesystem: Removed.
  • fast/filesystem/async-operations-expected.txt: Removed.
  • fast/filesystem/async-operations.html: Removed.
  • fast/filesystem/cross-filesystem-op-expected.txt: Removed.
  • fast/filesystem/cross-filesystem-op.html: Removed.
  • fast/filesystem/directory-entry-to-uri-expected.txt: Removed.
  • fast/filesystem/directory-entry-to-uri.html: Removed.
  • fast/filesystem/entry-points-missing-arguments-expected.txt: Removed.
  • fast/filesystem/entry-points-missing-arguments.html: Removed.
  • fast/filesystem/file-after-reload-crash-expected.txt: Removed.
  • fast/filesystem/file-after-reload-crash.html: Removed.
  • fast/filesystem/file-entry-to-uri-expected.txt: Removed.
  • fast/filesystem/file-entry-to-uri.html: Removed.
  • fast/filesystem/file-from-file-entry-expected.txt: Removed.
  • fast/filesystem/file-from-file-entry.html: Removed.
  • fast/filesystem/file-metadata-after-write-expected.txt: Removed.
  • fast/filesystem/file-metadata-after-write.html: Removed.
  • fast/filesystem/file-writer-abort-continue-expected.txt: Removed.
  • fast/filesystem/file-writer-abort-continue.html: Removed.
  • fast/filesystem/file-writer-abort-depth-expected.txt: Removed.
  • fast/filesystem/file-writer-abort-depth.html: Removed.
  • fast/filesystem/file-writer-abort-expected.txt: Removed.
  • fast/filesystem/file-writer-abort.html: Removed.
  • fast/filesystem/file-writer-empty-blob-expected.txt: Removed.
  • fast/filesystem/file-writer-empty-blob.html: Removed.
  • fast/filesystem/file-writer-events-expected.txt: Removed.
  • fast/filesystem/file-writer-events.html: Removed.
  • fast/filesystem/file-writer-gc-blob-expected.txt: Removed.
  • fast/filesystem/file-writer-gc-blob.html: Removed.
  • fast/filesystem/file-writer-truncate-extend-expected.txt: Removed.
  • fast/filesystem/file-writer-truncate-extend.html: Removed.
  • fast/filesystem/file-writer-write-overlapped-expected.txt: Removed.
  • fast/filesystem/file-writer-write-overlapped.html: Removed.
  • fast/filesystem/filesystem-missing-arguments-expected.txt: Removed.
  • fast/filesystem/filesystem-missing-arguments.html: Removed.
  • fast/filesystem/filesystem-no-callback-null-ptr-crash-expected.txt: Removed.
  • fast/filesystem/filesystem-no-callback-null-ptr-crash.html: Removed.
  • fast/filesystem/filesystem-reference-expected.txt: Removed.
  • fast/filesystem/filesystem-reference.html: Removed.
  • fast/filesystem/filesystem-unserializable-expected.txt: Removed.
  • fast/filesystem/filesystem-unserializable.html: Removed.
  • fast/filesystem/filesystem-uri-origin-expected.txt: Removed.
  • fast/filesystem/filesystem-uri-origin.html: Removed.
  • fast/filesystem/flags-passing-expected.txt: Removed.
  • fast/filesystem/flags-passing.html: Removed.
  • fast/filesystem/input-access-entries-expected.txt: Removed.
  • fast/filesystem/input-access-entries.html: Removed.
  • fast/filesystem/not-enough-arguments-expected.txt: Removed.
  • fast/filesystem/not-enough-arguments.html: Removed.
  • fast/filesystem/op-copy-expected.txt: Removed.
  • fast/filesystem/op-copy.html: Removed.
  • fast/filesystem/op-get-entry-expected.txt: Removed.
  • fast/filesystem/op-get-entry.html: Removed.
  • fast/filesystem/op-get-metadata-expected.txt: Removed.
  • fast/filesystem/op-get-metadata.html: Removed.
  • fast/filesystem/op-get-parent-expected.txt: Removed.
  • fast/filesystem/op-get-parent.html: Removed.
  • fast/filesystem/op-move-expected.txt: Removed.
  • fast/filesystem/op-move.html: Removed.
  • fast/filesystem/op-read-directory-expected.txt: Removed.
  • fast/filesystem/op-read-directory.html: Removed.
  • fast/filesystem/op-remove-expected.txt: Removed.
  • fast/filesystem/op-remove.html: Removed.
  • fast/filesystem/op-restricted-chars-expected.txt: Removed.
  • fast/filesystem/op-restricted-chars.html: Removed.
  • fast/filesystem/op-restricted-names-expected.txt: Removed.
  • fast/filesystem/op-restricted-names.html: Removed.
  • fast/filesystem/op-restricted-unicode-expected.txt: Removed.
  • fast/filesystem/op-restricted-unicode.html: Removed.
  • fast/filesystem/read-directory-expected.txt: Removed.
  • fast/filesystem/read-directory.html: Removed.
  • fast/filesystem/resources: Removed.
  • fast/filesystem/resources/async-operations.js: Removed.
  • fast/filesystem/resources/directory-entry-to-uri.js: Removed.
  • fast/filesystem/resources/file-entry-to-uri-sync.js: Removed.
  • fast/filesystem/resources/file-entry-to-uri.js: Removed.
  • fast/filesystem/resources/file-from-file-entry-sync.js: Removed.
  • fast/filesystem/resources/file-from-file-entry.js: Removed.
  • fast/filesystem/resources/file-writer-abort-continue.js: Removed.
  • fast/filesystem/resources/file-writer-abort-depth.js: Removed.
  • fast/filesystem/resources/file-writer-abort.js: Removed.
  • fast/filesystem/resources/file-writer-empty-blob.js: Removed.
  • fast/filesystem/resources/file-writer-events.js: Removed.
  • fast/filesystem/resources/file-writer-gc-blob.js: Removed.
  • fast/filesystem/resources/file-writer-sync-truncate-extend.js: Removed.
  • fast/filesystem/resources/file-writer-sync-write-overlapped.js: Removed.
  • fast/filesystem/resources/file-writer-truncate-extend.js: Removed.
  • fast/filesystem/resources/file-writer-utils.js: Removed.
  • fast/filesystem/resources/file-writer-write-overlapped.js: Removed.
  • fast/filesystem/resources/fs-test-util.js: Removed.
  • fast/filesystem/resources/fs-worker-common.js: Removed.
  • fast/filesystem/resources/op-copy.js: Removed.
  • fast/filesystem/resources/op-get-entry.js: Removed.
  • fast/filesystem/resources/op-get-metadata.js: Removed.
  • fast/filesystem/resources/op-get-parent.js: Removed.
  • fast/filesystem/resources/op-move.js: Removed.
  • fast/filesystem/resources/op-read-directory.js: Removed.
  • fast/filesystem/resources/op-remove.js: Removed.
  • fast/filesystem/resources/op-restricted-chars.js: Removed.
  • fast/filesystem/resources/op-restricted-names.js: Removed.
  • fast/filesystem/resources/op-restricted-unicode.js: Removed.
  • fast/filesystem/resources/op-tests-helper.js: Removed.
  • fast/filesystem/resources/shared-worker-stub.js: Removed.
  • fast/filesystem/resources/simple-persistent-sync.js: Removed.
  • fast/filesystem/resources/simple-persistent.js: Removed.
  • fast/filesystem/resources/simple-readonly.js: Removed.
  • fast/filesystem/resources/simple-required-arguments-getdirectory.js: Removed.
  • fast/filesystem/resources/simple-required-arguments-getfile.js: Removed.
  • fast/filesystem/resources/simple-required-arguments-getmetadata.js: Removed.
  • fast/filesystem/resources/simple-required-arguments-remove.js: Removed.
  • fast/filesystem/resources/simple-temporary-sync.js: Removed.
  • fast/filesystem/resources/simple-temporary.js: Removed.
  • fast/filesystem/resources/sync-operations.js: Removed.
  • fast/filesystem/script-tests: Removed.
  • fast/filesystem/script-tests/TEMPLATE.html: Removed.
  • fast/filesystem/script-tests/filesystem-reference.js: Removed.
  • fast/filesystem/script-tests/filesystem-unserializable.js: Removed.
  • fast/filesystem/script-tests/flags-passing.js: Removed.
  • fast/filesystem/script-tests/read-directory.js: Removed.
  • fast/filesystem/simple-persistent-expected.txt: Removed.
  • fast/filesystem/simple-persistent.html: Removed.
  • fast/filesystem/simple-readonly-expected.txt: Removed.
  • fast/filesystem/simple-readonly-file-object-expected.txt: Removed.
  • fast/filesystem/simple-readonly-file-object.html: Removed.
  • fast/filesystem/simple-readonly.html: Removed.
  • fast/filesystem/simple-required-arguments-getdirectory-expected.txt: Removed.
  • fast/filesystem/simple-required-arguments-getdirectory.html: Removed.
  • fast/filesystem/simple-required-arguments-getfile-expected.txt: Removed.
  • fast/filesystem/simple-required-arguments-getfile.html: Removed.
  • fast/filesystem/simple-required-arguments-getmetadata-expected.txt: Removed.
  • fast/filesystem/simple-required-arguments-getmetadata.html: Removed.
  • fast/filesystem/simple-required-arguments-remove-expected.txt: Removed.
  • fast/filesystem/simple-required-arguments-remove.html: Removed.
  • fast/filesystem/simple-temporary-expected.txt: Removed.
  • fast/filesystem/simple-temporary.html: Removed.
  • fast/filesystem/workers: Removed.
  • fast/filesystem/workers/async-operations-expected.txt: Removed.
  • fast/filesystem/workers/async-operations.html: Removed.
  • fast/filesystem/workers/detached-frame-crash-expected.txt: Removed.
  • fast/filesystem/workers/detached-frame-crash.html: Removed.
  • fast/filesystem/workers/file-entry-to-uri-sync-expected.txt: Removed.
  • fast/filesystem/workers/file-entry-to-uri-sync.html: Removed.
  • fast/filesystem/workers/file-from-file-entry-expected.txt: Removed.
  • fast/filesystem/workers/file-from-file-entry-sync-expected.txt: Removed.
  • fast/filesystem/workers/file-from-file-entry-sync.html: Removed.
  • fast/filesystem/workers/file-from-file-entry.html: Removed.
  • fast/filesystem/workers/file-writer-empty-blob-expected.txt: Removed.
  • fast/filesystem/workers/file-writer-empty-blob.html: Removed.
  • fast/filesystem/workers/file-writer-events-expected.txt: Removed.
  • fast/filesystem/workers/file-writer-events-shared-worker-expected.txt: Removed.
  • fast/filesystem/workers/file-writer-events-shared-worker.html: Removed.
  • fast/filesystem/workers/file-writer-events.html: Removed.
  • fast/filesystem/workers/file-writer-gc-blob-expected.txt: Removed.
  • fast/filesystem/workers/file-writer-gc-blob.html: Removed.
  • fast/filesystem/workers/file-writer-sync-truncate-extend-expected.txt: Removed.
  • fast/filesystem/workers/file-writer-sync-truncate-extend.html: Removed.
  • fast/filesystem/workers/file-writer-sync-write-overlapped-expected.txt: Removed.
  • fast/filesystem/workers/file-writer-sync-write-overlapped.html: Removed.
  • fast/filesystem/workers/file-writer-truncate-extend-expected.txt: Removed.
  • fast/filesystem/workers/file-writer-truncate-extend.html: Removed.
  • fast/filesystem/workers/file-writer-write-overlapped-expected.txt: Removed.
  • fast/filesystem/workers/file-writer-write-overlapped.html: Removed.
  • fast/filesystem/workers/resources: Removed.
  • fast/filesystem/workers/resources/detached-frame-crash-frame.html: Removed.
  • fast/filesystem/workers/resources/detached-frame-crash-worker.js: Removed.
  • fast/filesystem/workers/simple-persistent-expected.txt: Removed.
  • fast/filesystem/workers/simple-persistent-sync-expected.txt: Removed.
  • fast/filesystem/workers/simple-persistent-sync.html: Removed.
  • fast/filesystem/workers/simple-persistent.html: Removed.
  • fast/filesystem/workers/simple-temporary-expected.txt: Removed.
  • fast/filesystem/workers/simple-temporary-sync-expected.txt: Removed.
  • fast/filesystem/workers/simple-temporary-sync.html: Removed.
  • fast/filesystem/workers/simple-temporary.html: Removed.
  • fast/filesystem/workers/sync-operations-expected.txt: Removed.
  • fast/filesystem/workers/sync-operations.html: Removed.
  • fast/forms/file/input-file-entries-expected.txt: Removed.
  • fast/forms/file/input-file-entries.html: Removed.
  • http/tests/filesystem: Removed.
  • http/tests/filesystem/no-cache-filesystem-url-expected.txt: Removed.
  • http/tests/filesystem/no-cache-filesystem-url.html: Removed.
  • http/tests/filesystem/resolve-uri-expected.txt: Removed.
  • http/tests/filesystem/resolve-uri.html: Removed.
  • http/tests/filesystem/resources: Removed.
  • http/tests/filesystem/resources/fs-test-util.js: Removed.
  • http/tests/filesystem/resources/fs-worker-common.js: Removed.
  • http/tests/filesystem/resources/fs-worker-test-util.js: Removed.
  • http/tests/filesystem/script-tests: Removed.
  • http/tests/filesystem/script-tests/TEMPLATE.html: Removed.
  • http/tests/filesystem/script-tests/resolve-uri.js: Removed.
  • http/tests/filesystem/workers: Removed.
  • http/tests/filesystem/workers/resolve-url-expected.txt: Removed.
  • http/tests/filesystem/workers/resolve-url-sync-expected.txt: Removed.
  • http/tests/filesystem/workers/resolve-url-sync.html: Removed.
  • http/tests/filesystem/workers/resolve-url.html: Removed.
  • http/tests/filesystem/workers/script-tests: Removed.
  • http/tests/filesystem/workers/script-tests/TEMPLATE.html: Removed.
  • http/tests/filesystem/workers/script-tests/resolve-url-sync.js: Removed.
  • http/tests/inspector/filesystem: Removed.
  • http/tests/inspector/filesystem/delete-entry-expected.txt: Removed.
  • http/tests/inspector/filesystem/delete-entry.html: Removed.
  • http/tests/inspector/filesystem/directory-tree-expected.txt: Removed.
  • http/tests/inspector/filesystem/directory-tree.html: Removed.
  • http/tests/inspector/filesystem/filesystem-test.js: Removed.
  • http/tests/inspector/filesystem/request-directory-content-expected.txt: Removed.
  • http/tests/inspector/filesystem/request-directory-content.html: Removed.
  • http/tests/inspector/filesystem/request-file-content-expected.txt: Removed.
  • http/tests/inspector/filesystem/request-file-content.html: Removed.
  • http/tests/inspector/filesystem/request-filesystem-root-expected.txt: Removed.
  • http/tests/inspector/filesystem/request-filesystem-root.html: Removed.
  • http/tests/inspector/filesystem/request-metadata-expected.txt: Removed.
  • http/tests/inspector/filesystem/request-metadata.html: Removed.
  • http/tests/security/contentSecurityPolicy/filesystem-urls-match-self-expected.txt: Removed.
  • http/tests/security/contentSecurityPolicy/filesystem-urls-match-self.html: Removed.
  • http/tests/security/filesystem-iframe-from-remote-expected.txt: Removed.
  • http/tests/security/filesystem-iframe-from-remote.html: Removed.
  • http/tests/security/mixedContent/filesystem-url-in-iframe-expected.txt: Removed.
  • http/tests/security/mixedContent/filesystem-url-in-iframe.html: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob-fail.html: Removed.
  • http/tests/websocket/tests/hybi/send-file-blob.html: Removed.
  • http/tests/workers/resources/sync-operations.js:

(onmessage):

  • http/tests/workers/terminate-during-sync-operation-expected.txt: Removed.
  • http/tests/workers/terminate-during-sync-operation.html: Removed.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
6:47 PM Changeset in webkit [156691] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Build fix afer r156688.

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore::ThreadableBlobRegistry::registerBlobURL): Switch to std::unique_ptr in
method implementation.

6:37 PM Changeset in webkit [156690] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • NetworkProcess/mac/RemoteNetworkingContext.mm:
6:24 PM Changeset in webkit [156689] by mrowe@apple.com
  • 3 edits in trunk/Tools

More build fixage for builds with SDKs.

  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/BaseTarget.xcconfig:
5:59 PM Changeset in webkit [156688] by andersca@apple.com
  • 93 edits in trunk/Source

Get rid of more uses of OwnPtr and PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=122136

Reviewed by Antti Koivisto.

Source/WebCore:

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveBinaryData):

  • WebCore.exp.in:
  • fileapi/Blob.cpp:

(WebCore::Blob::Blob):
(WebCore::Blob::slice):

  • fileapi/Blob.h:

(WebCore::Blob::create):

  • fileapi/File.cpp:

(WebCore::createBlobDataForFileWithType):
(WebCore::createBlobDataForFile):
(WebCore::createBlobDataForFileWithName):

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore::BlobRegistryContext::BlobRegistryContext):
(WebCore::registerBlobURLTask):
(WebCore::ThreadableBlobRegistry::registerBlobURL):

  • fileapi/ThreadableBlobRegistry.h:
  • fileapi/WebKitBlobBuilder.cpp:

(WebCore::BlobBuilder::getBlob):

  • platform/network/BlobData.cpp:

(WebCore::BlobDataHandle::BlobDataHandle):

  • platform/network/BlobData.h:

(WebCore::BlobData::BlobData):
(WebCore::BlobDataHandle::create):

  • platform/network/BlobRegistry.h:
  • platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::registerBlobURL):

  • platform/network/BlobRegistryImpl.h:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::responseBlob):

Source/WebKit2:

  • NetworkProcess/AsynchronousNetworkLoaderClient.h:
  • NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:

(WebKit::NetworkBlobRegistry::registerBlobURL):

  • NetworkProcess/FileAPI/NetworkBlobRegistry.h:
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):

  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/SynchronousNetworkLoaderClient.h:
  • NetworkProcess/mac/RemoteNetworkingContext.mm:
  • Platform/CoreIPC/ArgumentDecoder.h:
  • Platform/CoreIPC/ArgumentEncoder.h:
  • Platform/CoreIPC/MessageDecoder.cpp:

(CoreIPC::MessageDecoder::setImportanceAssertion):

  • Platform/CoreIPC/MessageDecoder.h:
  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::receiveSourceEventHandler):

  • Platform/CoreIPC/mac/ImportanceAssertion.h:

(CoreIPC::ImportanceAssertion::ImportanceAssertion):

  • Platform/mac/LayerHostingContext.h:
  • Platform/mac/LayerHostingContext.mm:

(WebKit::LayerHostingContext::createForPort):
(WebKit::LayerHostingContext::createForWindowServer):

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::paint):

  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::addPluginControllerProxy):
(WebKit::WebProcessConnection::removePluginControllerProxy):
(WebKit::WebProcessConnection::createPluginInternal):

  • PluginProcess/WebProcessConnection.h:
  • Shared/API/c/cg/WKImageCG.cpp:

(WKImageCreateFromCGImage):

  • Shared/BlockingResponseMap.h:

(BlockingResponseMap::waitForResponse):
(BlockingResponseMap::didReceiveResponse):

  • Shared/Downloads/Download.cpp:
  • Shared/Downloads/Download.h:
  • Shared/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::startDownload):
(WebKit::DownloadManager::convertHandleToDownload):

  • Shared/FileAPI/BlobRegistrationData.cpp:

(WebKit::BlobRegistrationData::BlobRegistrationData):
(WebKit::BlobRegistrationData::releaseData):
(WebKit::BlobRegistrationData::decode):

  • Shared/FileAPI/BlobRegistrationData.h:
  • Shared/Plugins/NPObjectMessageReceiver.cpp:
  • Shared/Plugins/NPObjectMessageReceiver.h:
  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::registerNPObject):

  • Shared/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::NetscapePluginModule::tryLoad):

  • Shared/Plugins/Netscape/NetscapePluginModule.h:
  • Shared/ShareableBitmap.h:
  • Shared/WebURL.h:

(WebKit::WebURL::create):
(WebKit::WebURL::WebURL):
(WebKit::WebURL::parseURLIfNecessary):

  • Shared/cg/ShareableBitmapCG.cpp:

(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::makeCGImageCopy):

  • Shared/mac/SecItemShim.cpp:

(WebKit::sendSecItemRequest):
(WebKit::webSecItemCopyMatching):
(WebKit::webSecItemAdd):
(WebKit::webSecItemUpdate):
(WebKit::webSecItemDelete):
(WebKit::SecItemShim::secItemResponse):

  • UIProcess/API/mac/FindIndicatorWindow.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::createDrawingAreaProxy):

  • UIProcess/API/mac/WKView.mm:

(-[WKView std::WebKit::]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/BackingStore.cpp:
  • UIProcess/BackingStore.h:
  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::incorporateUpdate):

  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
  • WebProcess/FileAPI/BlobRegistryProxy.cpp:

(WebKit::BlobRegistryProxy::registerBlobURL):

  • WebProcess/FileAPI/BlobRegistryProxy.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
  • WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm:

(WKBundlePageBannerCreateBannerWithCALayer):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::imageForRect):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::scheduleTimer):
(WebKit::NetscapePlugin::unscheduleTimer):
(WebKit::NetscapePlugin::snapshot):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::snapshot):

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::update):

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::convertImageToBitmap):

  • WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create):

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::display):

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::getFindIndicatorBitmapAndRect):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createWithCoreMainFrame):
(WebKit::WebFrame::createSubframe):
(WebKit::WebFrame::create):
(WebKit::WebFrame::WebFrame):

  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scaledSnapshotWithOptions):
(WebKit::WebPage::drawRectToImage):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
5:48 PM Changeset in webkit [156687] by andersca@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Message sending functions should only accept rvalues
https://bugs.webkit.org/show_bug.cgi?id=122041

Reviewed by Andreas Kling.

In order to safely encode move-only types, make all send variants accept rvalues only, except
for the "send to all processes" ones. For them, copy the message before sending. This ensures that trying
to send a move-only type in a message will fail to compile.

  • NetworkProcess/NetworkResourceLoader.h:

(WebKit::NetworkResourceLoader::sendAbortingOnFailure):

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):

  • Platform/CoreIPC/MessageSender.h:

(CoreIPC::MessageSender::sendSync):

  • Shared/ChildProcessProxy.h:

(WebKit::ChildProcessProxy::send):
(WebKit::ChildProcessProxy::sendSync):

  • UIProcess/WebContext.h:

(WebKit::WebContext::sendToNetworkingProcess):
(WebKit::WebContext::sendToNetworkingProcessRelaunchingIfNecessary):
(WebKit::WebContext::sendToAllProcesses):
(WebKit::WebContext::sendToAllProcessesRelaunchingThemIfNecessary):
(WebKit::WebContext::sendToOneProcess):

  • UIProcess/WebPageGroup.h:

(WebKit::WebPageGroup::sendToAllProcessesInGroup):

4:42 PM Changeset in webkit [156686] by Lucas Forschler
  • 1 copy in branches/safari-537.73-branch

New Branch.

4:13 PM Changeset in webkit [156685] by timothy@apple.com
  • 1 edit
    36 adds in trunk/Tools

Add initial version of a new Buildbot dashboard view.

https://bugs.webkit.org/show_bug.cgi?id=122131

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
3:52 PM Changeset in webkit [156684] by mitz@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

<rdar://problem/15114974> Assertion failure under -[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:] if no classes conform to JSExport
https://bugs.webkit.org/show_bug.cgi?id=122124

Reviewed by Darin Adler.

  • API/JSWrapperMap.mm: Defined an empty class that conforms to the JSExport protocol, to

ensure that the protocol is always registered with the runtime by the time
getJSExportProtocol() is called.

3:43 PM Changeset in webkit [156683] by benjamin@webkit.org
  • 46 edits in trunk

Remove the code guarded by STYLE_SCOPED
https://bugs.webkit.org/show_bug.cgi?id=122123

Reviewed by Anders Carlsson.

.:

  • Source/autotools/SetupWebKitFeatures.m4:
  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Start cleaning the code related to <style scoped>. This patch
only removes the code with #ifdef guards.

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.exp.in:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):

  • bindings/generic/RuntimeEnabledFeatures.h:
  • css/DocumentRuleSets.cpp:

(WebCore::DocumentRuleSets::appendAuthorStyleSheets):

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::matchScopedAuthorRules):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):

  • css/StyleResolver.h:

(WebCore::StyleResolver::ensureScopeResolver):

  • css/StyleScopeResolver.cpp:
  • css/StyleScopeResolver.h:
  • dom/Node.cpp:
  • dom/Node.h:
  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot):

  • dom/ShadowRoot.h:
  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::HTMLStyleElement):
(WebCore::HTMLStyleElement::parseAttribute):
(WebCore::HTMLStyleElement::insertedInto):
(WebCore::HTMLStyleElement::removedFrom):

  • html/HTMLStyleElement.h:
  • html/HTMLStyleElement.idl:
  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:
  • testing/Internals.cpp:
  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:
2:56 PM Changeset in webkit [156682] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

ASSERT(!m_hasBadParent) in InlineBox::parent() should be ASSERT_WITH_SECURITY_IMPLICATION
https://bugs.webkit.org/show_bug.cgi?id=122032

Patch by Drew Yao <ayao@apple.com> on 2013-09-30
Reviewed by Andreas Kling.

Convert assertion to ASSERT_WITH_SECURITY_IMPLICATION to help catch use after free bugs.

No new tests needed.

  • rendering/InlineBox.h:

(WebCore::InlineBox::parent):

2:54 PM Changeset in webkit [156681] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Don't attempt to destroy decoded frame if a BitmapImage doesn't have encoded raw data.
https://bugs.webkit.org/show_bug.cgi?id=122115

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-09-30
Reviewed by Daniel Bates.

With BitmapImage::create(PassNativeImagePtr, ImageObserver*), a BitmapImage could be created by
passing a native image. If this image is added to memory cache, we shouldn't attempt to destroy
its decoded frames since there is no encoded raw data and we won't be able to reconstruct the image again.

No new tests for now. Currently there isn't a code path to add to the memory cache a BitmapImage
that was created by adopting a native image. We'll add such a code path in a subsequent patch.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::destroyDecodedDataIfNecessary):

2:42 PM Changeset in webkit [156680] by akling@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Pass VM instead of ExecState to ObjectPrototype constructor.
<https://webkit.org/b/122116>

Reviewed by Geoffrey Garen.

The ObjectPrototype constructor was only using the ExecState to get
to the VM.

2:41 PM Changeset in webkit [156679] by akling@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Pass VM instead of JSGlobalObject to MathObject constructor.
<https://webkit.org/b/122119>

Reviewed by Geoffrey Garen.

The MathObject constructor was only using the global object to get
to the VM. finishCreation() still uses it to set up functions.

1:47 PM Changeset in webkit [156678] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Remove timeout from shouldBecome* functions in js-test-pre
https://bugs.webkit.org/show_bug.cgi?id=122121

Reviewed by Ryosuke Niwa.

Removed timeout. A 0.5 sec timeout never makes sense, and if something is stuck,
a test should just time out normally.

  • resources/js-test-pre.js:

(_waitForCondition):
(shouldBecomeEqual):
(shouldBecomeEqualToString):
(shouldBecomeDifferent):

1:38 PM Changeset in webkit [156677] by fpizlo@apple.com
  • 21 edits
    1 add in trunk/Source/JavaScriptCore

Get rid of the AlreadyInJSStack recoveries since they are totally redundant with the DisplacedInJSStack recoveries
https://bugs.webkit.org/show_bug.cgi?id=122065

Reviewed by Mark Hahnenberg.

This mostly just kills a bunch of code.

But incidentaly while killing that code, I uncovered a bug in our FTL OSR entrypoint
creation phase. The phase inserts a sequence of SetLocal(ExtractOSREntryLocal) nodes.
If we hoist some type check into the local, then we might inject a conversion node
between the ExtractOSREntryLocal and the SetLocal - for example we might put in a
Int32ToDouble node. But currently the FixupPhase will make all conversion nodes placed
on an edge of a SetLocal use forward exit. This then confuses the OSR exit machinery.
When OSR exit sees a forward exit, it tries to "roll forward" execution from the exiting
node to the first node that has a different CodeOrigin. This only works if the nodes
after the forward exit are MovHints or other tnings that the OSR exit compiler can
forward-execute. But here, it will see a bunch of SetLocal and ExtractOSREntryLocal
nodes for the same bytecode index. Two possible solutions exist. We could teach the
forward-execution logic how to deal with multiple SetLocals and ExtractOSREntryLocals.
This would be a lot of complexity; right now it just needs to deal with exactly one
SetLocal-like operation. The alternative is to make sure that the conversion node that
we inject ends up exiting *backward* rather than forward.

But making the conversion nodes exit backward is somewhat tricky. Before this patch,
conversion nodes always exit forward for SetLocals and backwards otherwise. It turns out
that the solution is to rationalize how we choose the speculation direciton for a
conversion node. The conversion node's speculation direction should be the same as the
speculation direction of the node for which it is doing a conversion. Since SetLocal's
already exit forward by default, this policy preserves our previous behavior. But it
also allows the OSR entrypoint creation phase to make its SetLocals exit backward
instead.

Of course, if the SetLocal(ExtractOSREntryLocal) sequences exit backward, then we need
to make sure that the OSR exit machine knows that the local variables are indeed live.
Consider that if we have:

a: ExtractOSREntryLocal(loc1)
b: SetLocal(@a, loc1)
c: ExtractOSRentryLocal(loc2)
d: SetLocal(@c, loc2)


Without additional magic, the exit at @b will think that loc2 is dead and the OSR exit
compiler will clobber loc2 with Undefined. So we need to make sure that we actually
emit code like:

a: ExtractOSREntryLocal(loc1)
b: ExtractOSREntryLocal(loc2)
c: SetLocal(@a, loc1)
d: SetLocal(@b, loc2)
e: SetLocal(@a, loc1)
f: SetLocal(@b, loc2)

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeOrigin.h:
  • bytecode/ValueRecovery.cpp: Added.

(JSC::ValueRecovery::recover):
(JSC::ValueRecovery::dumpInContext):
(JSC::ValueRecovery::dump):

  • bytecode/ValueRecovery.h:
  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
(JSC::DFG::FixupPhase::fixEdge):

  • dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::reconstruct):

  • dfg/DFGNode.h:

(JSC::DFG::Node::speculationDirection):
(JSC::DFG::Node::setSpeculationDirection):

  • dfg/DFGOSREntrypointCreationPhase.cpp:

(JSC::DFG::OSREntrypointCreationPhase::run):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):

  • dfg/DFGValueSource.h:

(JSC::DFG::ValueSource::valueRecovery):

  • dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::reconstruct):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateMachineInt):

  • interpreter/Register.h:

(JSC::Register::unboxedStrictInt52):

  • runtime/Arguments.cpp:

(JSC::Arguments::tearOff):

  • runtime/Arguments.h:
1:32 PM Changeset in webkit [156676] by beidson@apple.com
  • 19 edits
    1 delete in trunk/Source/WebCore

Remove IDBTracing.h.
https://bugs.webkit.org/show_bug.cgi?id=122118

Reviewed by Alexey Proskuryakov.

Global replace of "IDB_TRACE" with "LOG(StorageAPI)", and remove all notions of this header.

  • GNUmakefile.list.am:
  • Modules/indexeddb/IDBCursor.cpp:
  • Modules/indexeddb/IDBDatabase.cpp:
  • Modules/indexeddb/IDBDatabaseBackendInterface.h:
  • Modules/indexeddb/IDBFactory.cpp:
  • Modules/indexeddb/IDBIndex.cpp:
  • Modules/indexeddb/IDBObjectStore.cpp:
  • Modules/indexeddb/IDBOpenDBRequest.cpp:
  • Modules/indexeddb/IDBRequest.cpp:
  • Modules/indexeddb/IDBTracing.h: Removed.
  • Modules/indexeddb/IDBTransaction.cpp:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/IDBBindingUtilities.cpp:
1:10 PM Changeset in webkit [156675] by Antoine Quint
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: rows in the Layer sidebar panel may have the incorrect background color
https://bugs.webkit.org/show_bug.cgi?id=122108

Reviewed by Darin Adler.

The LayerTreeDataGrid is a custom DataGrid subclass which exposes a .setChildren() method
used to sort chidren without DOM order manipulation, for performance reason. However, since
the way the alternating background color is usually implemented is based on the built-in
CSS pseudo-classes working with DOM order, the background colors of nodes in the LayerTreeDataGrid
can be incorrect depending on the sort order and the number of nodes. To fix this, we now manually
set "even" and "odd" CSS classes on those nodes when they're sorted such that we have a chance
to style them as intended.

  • UserInterface/LayerTreeDataGrid.js:

(WebInspector.LayerTreeDataGrid.prototype._updateChildren):
Check if the data grid node index is even or odd and reflect this via an exclusive "even"
or "odd" CSS class name.

  • UserInterface/LayerTreeSidebarPanel.css:

(.layer-tree.panel .data-container tbody > tr.even):
(.layer-tree.panel .data-container tbody > tr.odd):
Apply alternating colors based on the exclusive "even" and "odd" CSS class names as applied in
WebInspector.LayerTreeDataGrid.prototype._updateChildren().

1:07 PM Changeset in webkit [156674] by alex.christensen@flexsim.com
  • 2 edits in trunk/Source/WebKit

[Windows] Unreviewed build fix for Win64.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Added correct 64-bit BitmapImage::create symbol.

1:07 PM Changeset in webkit [156673] by Antoine Quint
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Popover displaying "reasons for compositing" may remain on screen after selected layer is removed
https://bugs.webkit.org/show_bug.cgi?id=117575

Ensure the popover attached to the selected data grid node is updated when the
content or sort order of the Layer sidebar panel is updated.

Reviewed by Darin Adler.

  • UserInterface/LayerTreeSidebarPanel.js:

(WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid):

1:06 PM Changeset in webkit [156672] by Antoine Quint
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: nodes can be dragged from the console log
https://bugs.webkit.org/show_bug.cgi?id=122105

Reviewed by Darin Adler.

Catch "dragstart" events targeting nodes hosted in a DOMTreeOutline within the console
log view and prevent the default logic to trigger so that these nodes can't be dragged
off the console as it wouldn't make sense to.

  • UserInterface/DOMTreeOutline.js:

(WebInspector.DOMTreeOutline):
Create a class property to allow the CSS class name to be used in WebInspector.LogContentView.

  • UserInterface/LogContentView.js:

(WebInspector.LogContentView):
(WebInspector.LogContentView.prototype._ondragstart):
Track the "dragstart" events in their capture phase such that, if the event target is
a DOM node hosted in a DOMTreeOutline, we can prevent the event from propagating and
cancel its default behavior such that no dragging at all is performed.

12:51 PM Changeset in webkit [156671] by alex.christensen@flexsim.com
  • 2 edits in trunk/Source/JavaScriptCore

Win64 compile fix after r1256490.
https://bugs.webkit.org/show_bug.cgi?id=122117

Patch by Alex Christensen <alex.christensen@flexsim.com> on 2013-09-30
Reviewed by Michael Saboff.

  • jit/JITStubsMSVC64.asm:

Implemented getHostCallReturnValue for Windows x86_64 processors.

12:44 PM Changeset in webkit [156670] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

NetworkResourceLoader.messages.in should be ENABLE(NETWORK_PROCESS) guarded
https://bugs.webkit.org/show_bug.cgi?id=122110

Reviewed by Darin Adler.

  • NetworkProcess/NetworkResourceLoader.messages.in:
12:35 PM Changeset in webkit [156669] by Brent Fulgham
  • 4 edits in trunk/Source/WebCore

[Windows] Build fix after r156622. Build RenderLayerModelObject.cpp in a separate compilation unit
from the RenderLayerAllnOne file so that the scalar and vector destructors are visible to other
elements of WebCore during the build.

  • WebCore.vcxproj/WebCore.vcxproj: Compile RenderLayerModelObject outside of the all-in-one file.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • rendering/RenderingAllInOne.cpp: Remove RenderLayerModelObject.cpp.
11:58 AM Changeset in webkit [156668] by akling@apple.com
  • 11 edits in trunk/Source

Pass VM instead of JSGlobalObject to RegExp constructor.
<https://webkit.org/b/122113>

Reviewed by Darin Adler.

RegExps don't need anything from the global object during their
construction and only use it to get to the VM. Reduce loads by
simply passing the VM around instead.

JSC release binary size -= 120 bytes(!)

11:13 AM Changeset in webkit [156667] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Win] Compile errors in WebKit (via peavo@outlook.com).
https://bugs.webkit.org/show_bug.cgi?id=122106

Reviewed by Darin Adler.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add link

declarations missed in r156655.

11:09 AM Changeset in webkit [156666] by mrowe@apple.com
  • 9 edits in trunk

Fix the build when building against an SDK.

Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
the compiler command lines. It can't know to do this for the system framework search paths
we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.

Source/WebCore:

  • Configurations/WebCore.xcconfig:

Source/WebKit/mac:

  • Configurations/WebKit.xcconfig:

Source/WebKit2:

  • Configurations/BaseTarget.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
  • WebKitTestRunner/Configurations/BaseTarget.xcconfig:
10:58 AM Changeset in webkit [156665] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Unreviewed build fix.

  • WebCore.vcxproj/WebCore.vcxproj.filters: Correct malformed XML in project files.
10:56 AM Changeset in webkit [156664] by jer.noble@apple.com
  • 11 edits in trunk

Unreviewed, roll back in r156546 with rebaselined tests.
https://bugs.webkit.org/show_bug.cgi?id=122111

Source/WebCore:

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller):
(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):
(Controller.prototype.updateHasAudio):

LayoutTests:

  • platform/mac/TestExpectations:
  • platform/mac/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
  • platform/mac/fast/layers/video-layer-expected.png:
  • platform/mac/fast/layers/video-layer-expected.txt:
  • platform/mac/media/media-controls-clone-expected.png:
  • platform/mac/media/media-controls-clone-expected.txt:
  • platform/mac/media/video-no-audio-expected.txt:
10:38 AM Changeset in webkit [156663] by commit-queue@webkit.org
  • 3 edits
    3 deletes in trunk/LayoutTests

editing/execCommand/findString-diacriticals.html expects to fail
https://bugs.webkit.org/show_bug.cgi?id=122100

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-09-30
Reviewed by Alexey Proskuryakov.

Since all major platforms pass editing/execCommand/findString-diacriticals.html,
the test now globally expects "PASS" instead of "FAIL" rendering the individual
platform expectation files obsolete.

  • editing/execCommand/findString-diacriticals-expected.txt: "PASS" -> "FAIL"
  • platform/efl/TestExpectations: EFL passes editing/execCommand/findString-diacriticals.
  • platform/gtk/editing/execCommand/findString-diacriticals-expected.txt: Removed.
  • platform/mac/editing/execCommand/findString-diacriticals-expected.txt: Removed.
  • platform/qt/editing/execCommand/findString-diacriticals-expected.txt: Removed.
10:36 AM Changeset in webkit [156662] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.

A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
it to be double-freed.

  • WinLauncher/WinLauncher.cpp:

(EditProc): Be explicit about type passed to loadURL.
(loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
that reallocating the BSTR is done with the knowledge of the smart pointer.

9:59 AM Changeset in webkit [156661] by commit-queue@webkit.org
  • 5 edits in trunk

Unreviewed, rolling out r156656.
http://trac.webkit.org/changeset/156656
https://bugs.webkit.org/show_bug.cgi?id=122111

Broke several media tests (Requested by ap on #webkit).

Source/WebCore:

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller):
(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):

LayoutTests:

  • platform/mac/TestExpectations:
  • platform/mac/media/video-no-audio-expected.txt:
9:50 AM Changeset in webkit [156660] by weinig@apple.com
  • 7 edits in trunk/Source/WebCore

Convert a bunch of OwnPtrs on Page to std::unique_ptrs
https://bugs.webkit.org/show_bug.cgi?id=122086

Reviewed by Darin Adler.

  • loader/ProgressTracker.cpp:
  • loader/ProgressTracker.h:
  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::setGroupName):
(WebCore::Page::initGroup):

  • page/Page.h:
  • page/PageGroup.cpp:

(WebCore::PageGroup::PageGroup):

  • page/PageGroup.h:
9:32 AM Changeset in webkit [156659] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Changed expectation for accessibility/file-upload-button-stringvalue.html after r156532
https://bugs.webkit.org/show_bug.cgi?id=122103

Unreviewed EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-30

  • platform/efl-wk1/TestExpectations: file-upload-button-stringvalue.html fails on efl-wk1.

Unskipped accessibility/heading-level.html. It passes after r156551.

  • platform/efl-wk2/accessibility/file-upload-button-stringvalue-expected.txt:
9:30 AM Changeset in webkit [156658] by allan.jensen@digia.com
  • 7 edits
    2 deletes in trunk

[Qt] Fix force_static_libs_as_shared in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121961

Reviewed by Csaba Osztrogonác.

Get rid of the unused WebKit2QML library

.:

  • Source/api.pri:

Source/WebKit2:

  • Target.pri:
  • WebKit2.pro:
  • WebKit2QML.pri: Removed.

Tools:

  • qmake/mkspecs/features/webkit_modules.prf:
  • qmake/mkspecs/modules/webkit2qml.prf: Removed.
9:21 AM Changeset in webkit [156657] by Antti Koivisto
  • 14 edits
    1 delete in trunk/Source/WebCore

Remove FontTranscoder
https://bugs.webkit.org/show_bug.cgi?id=122088

Reviewed by Andreas Kling.

This overly generic class just implements mapping of backslash to yen symbol for some legacy Japanese fonts.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.pri:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/Font.cpp:

(WebCore::useBackslashAsYenSignForFamily):

Move the family set to Font.cpp.

(WebCore::Font::Font):
(WebCore::Font::operator=):
(WebCore::Font::update):

Keep the cached boolean up to date.

  • platform/graphics/Font.h:

(WebCore::Font::useBackslashAsYenSymbol):

Use descriptive name instead of talking about "transcoding".

  • platform/text/transcoder: Removed.
  • platform/text/transcoder/FontTranscoder.cpp: Removed.
  • platform/text/transcoder/FontTranscoder.h: Removed.
  • rendering/RenderText.cpp:

(WebCore::RenderText::RenderText):
(WebCore::RenderText::computeUseBackslashAsYenSymbol):

Rename for clarity.
Avoid unnecessary hash lookup, just check the cached bit in Font.

(WebCore::RenderText::styleDidChange):
(WebCore::RenderText::setTextInternal):

"Transcoding" here was just a simple character replacement.

(WebCore::RenderText::textWithoutConvertingBackslashToYenSymbol):

Renamed.

  • rendering/RenderText.h:
9:09 AM Changeset in webkit [156656] by jer.noble@apple.com
  • 5 edits in trunk

REGRESSION(r156546): media/video-no-audio.html broken
https://bugs.webkit.org/show_bug.cgi?id=122049

Reviewed by Eric Carlson.

Source/WebCore:

Now that our video elements have audio tracks, use their presence or
absense to show or hide the volume controls.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller):
(Controller.prototype.addVideoListeners): Listen for audioTrack changes.
(Controller.prototype.removeVideoListeners): Stop listening to same.
(Controller.prototype.handleAudioTrackChange): Call this.updateHasAudio()
(Controller.prototype.handleAudioTrackAdd): Ditto.
(Controller.prototype.handleAudioTrackRemove): Ditto.
(Controller.prototype.updateHasAudio): Hide the volume controls if no

audioTracks are present, and vice versa.

LayoutTests:

  • platform/mac/TestExpectations:
  • platform/mac/media/video-no-audio-expected.txt:
8:43 AM Changeset in webkit [156655] by akling@apple.com
  • 2 edits in trunk/Source/WebKit/win

Try to fix the Windows build.

  • WebFrame.cpp:

(WebFrame::pauseAnimation):
(WebFrame::pauseTransition):

8:42 AM Changeset in webkit [156654] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Fix compilation for COMPILER(MSVC) && !CPU(X86) after r156490.
https://bugs.webkit.org/show_bug.cgi?id=122102

Reviewed by Geoffrey Garen.

_AddressOfReturnAddress() is supported for all platforms of
ths Microsoft compiler, so we can use it for !CPU(X86) too.

  • jit/JITOperationWrappers.h:
8:39 AM Changeset in webkit [156653] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Mac-Lion build fix.

Use metadataItemsFromArray:withLocale: instead of
metadataItemsFromArray:filteredAndSortedAccordingToPreferredLanguages:
on Lion and earlier.

  • platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:

(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack):

8:17 AM Changeset in webkit [156652] by jer.noble@apple.com
  • 6 edits
    5 adds in trunk

[Mac] Add AudioTrack support to MediaPlayerPrivateAVFObC.
https://bugs.webkit.org/show_bug.cgi?id=122043

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/audio-track.html

Add a new class AudioTrackPrivateAVF and subclass AudioTrackPrivateAVFObjC
which are backed by a AVPlayerItemTrack. Create one of these tracks when
we are notified that the list of available tracks has changed.

  • WebCore.xcodeproj/project.pbxproj:
  • html/track/AudioTrack.cpp:

(WebCore::AudioTrack::setEnabled): Pass through to the AudioTrackPrivate

so that the underlying media track can be (dis|en)abled.

  • platform/graphics/avfoundation/AudioTrackPrivateAVF.h: Added.

(WebCore::AudioTrackPrivateAVF::kind): Simple getter.
(WebCore::AudioTrackPrivateAVF::id): Ditto.
(WebCore::AudioTrackPrivateAVF::label): Ditto.
(WebCore::AudioTrackPrivateAVF::language): Ditto.
(WebCore::AudioTrackPrivateAVF::setKind): Simple Setter.
(WebCore::AudioTrackPrivateAVF::setId): Ditto.
(WebCore::AudioTrackPrivateAVF::setLabel): Ditto.
(WebCore::AudioTrackPrivateAVF::setLanguage): Ditto.
(WebCore::AudioTrackPrivateAVF::AudioTrackPrivateAVF): Simple constructor.

  • platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h: Added.

(WebCore::AudioTrackPrivateAVFObjC::create): Simple factory.
(WebCore::AudioTrackPrivateAVFObjC::playerItemTrack): Simple getter.

  • platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm: Added.

(WebCore::AudioTrackPrivateAVFObjC::AudioTrackPrivateAVFObjC): Call resetPropertiesFromTrack.
(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack): Fill out the values from

the associated AVPlayerItemTrack and its AVAssetTrack.

(WebCore::AudioTrackPrivateAVFObjC::setPlayerItemTrack): Call resetPropertiesFromTrack.
(WebCore::AudioTrackPrivateAVFObjC::setEnabled): (En|Dis)able the AVPlayerItemTrack.
(WebCore::AudioTrackPrivateAVFObjC::languageForAVAssetTrack): Refactored from

MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Determine which tracks

have been added or removed and notify the clients accordingly.

(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Refactor into

AudioTrackPrivateAVFObjC::languageForAVAssetTrack.

LayoutTests:

  • media/track/audio-track-expected.txt: Added.
  • media/track/audio-track.html: Added.
7:57 AM Changeset in webkit [156651] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[EFL] Added passing expectation for fast/forms/textarea-metrics.html
https://bugs.webkit.org/show_bug.cgi?id=122107

Unreviewed EFL gardening.

fast/forms/textarea-metrics.html fails in WebKitTestRunner but returns expected
results in MiniBrowser. Since GTK uses platform dependent expectation file to
migitate this identical discrepancy, the same solution has been applied to EFL.

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-09-30

  • platform/efl/TestExpectations:
  • platform/efl/fast/forms/textarea-metrics-expected.txt: Added.
7:05 AM Changeset in webkit [156650] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/wince

Unreviewed WinCE build fix after r153927.

  • WebView.cpp:

(WebView::WebView):

6:58 AM Changeset in webkit [156649] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/wince

Unreviewed WinCE build fix after r155289.

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForResponse):
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNewWindowAction):
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNavigationAction):
(WebKit::FrameLoaderClientWinCE::dispatchWillSubmitForm):

6:57 AM Changeset in webkit [156648] by Patrick Gansterer
  • 2 edits in trunk/Source/WebKit/wince

Unreviewed WinCE build fix after r154178.

  • WebView.cpp:

(WebView::wndProc):

6:15 AM Changeset in webkit [156647] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Fix incorrect click counting in EventSenderProxy
https://bugs.webkit.org/show_bug.cgi?id=122098

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-09-30
Reviewed by Gyuyoung Kim.

Tools:

Previously used two types of recording time, which conflicted with each other.

  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp:

(WTR::EventSenderProxy::mouseUp):

LayoutTests:

After fixing EventSenderProxy extend-selection-after-double-click.html runs correctly.

  • platform/efl/TestExpectations:
4:49 AM Changeset in webkit [156646] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening after the resolution of bug 84835
https://bugs.webkit.org/show_bug.cgi?id=122096

Unreviewed EFL gardening.

Removed expected failures for bug 84835.
editing/pasteboard/copy-inside-h1-preserves-h1 and
editing/pasteboard/copy-without-selection are still failing due to bug 86623
and have been marked accordingly.

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-09-30

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
3:56 AM Changeset in webkit [156645] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Two tests are passing in WK2 after r156541.

  • platform/gtk-wk2/TestExpectations: Removed passing tests.
3:46 AM Changeset in webkit [156644] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Accessibility tests pass after r156532 and r156551
https://bugs.webkit.org/show_bug.cgi?id=122090

Unreviewed EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-30

  • platform/efl-wk2/TestExpectations:
3:44 AM Changeset in webkit [156643] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] New test accessibility/table-with-hidden-head-section.html failing on EFL port
https://bugs.webkit.org/show_bug.cgi?id=111850

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-30
Reviewed by Mario Sanchez Prada.

Test passes after r156532.

  • platform/efl/TestExpectations:
3:39 AM Changeset in webkit [156642] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebCore

Generate toCSSCalcValue instead of using manual cast function
https://bugs.webkit.org/show_bug.cgi?id=122055

Reviewed by Antti Koivisto.

Generated type cast function supports more plenty functions rather than manual functions.
To use CSS_VALUE_TYPE_CAST, isCalculationValue() needs to be changed with isCalcValue().

No new tests, no behavior changes.

  • css/CSSCalculationValue.h:
  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

(WebCore::CSSValue::isCalcValue):

  • css/StyleResolver.cpp:

(WebCore::hasVariableReference):

2:33 AM Changeset in webkit [156641] by rgabor@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for DEBUG_VERBOSE mode after r156511.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCurrentBlock):

1:26 AM Changeset in webkit [156640] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

[webkitpy] Make the Xvfb screen depth overridable
https://bugs.webkit.org/show_bug.cgi?id=122089

Reviewed by Gyuyoung Kim.

Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
was set. The default value that's used if the variable wasn't set is 24.

  • Scripts/webkitpy/port/xvfbdriver.py:

(XvfbDriver._xvfb_screen_depth):
(XvfbDriver._start):

  • Scripts/webkitpy/port/xvfbdriver_unittest.py:

(XvfbDriverTest.make_driver):
(XvfbDriverTest.test_start_no_pixel_tests):
(XvfbDriverTest.test_start_pixel_tests):
(XvfbDriverTest.test_start_arbitrary_worker_number):
(XvfbDriverTest.test_next_free_display):
(XvfbDriverTest.test_start_next_worker):

1:21 AM Changeset in webkit [156639] by Antti Koivisto
  • 9 edits in trunk/Source/WebCore

Get rid of static map for marking ancestor line boxes dirty
https://bugs.webkit.org/show_bug.cgi?id=122080

Reviewed by Andreas Kling.

This is ugly and shows up in profiles too. Use a bit in RenderElement instead.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.h:


Move dirtyLinesFromChangedChild down to RenderBlockFlow. It wouldn't do anything on other RenderBlocks.

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::RenderElement):

  • rendering/RenderElement.h:


Add m_ancestorLineBoxDirty bit. We have 32 unused bits here on 64bit systems.

(WebCore::RenderElement::dirtyLinesFromChangedChild):
(WebCore::RenderElement::ancestorLineBoxDirty):
(WebCore::RenderElement::setAncestorLineBoxDirty):
(WebCore::RenderObject::setNeedsLayout):

  • rendering/RenderInline.h:
  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):

Tighten the interface.

  • rendering/RenderLineBoxList.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):

  • rendering/RenderObject.h:


Remove the static map.

1:14 AM Changeset in webkit [156638] by svillar@igalia.com
  • 9 edits
    2 adds in trunk

[CSS Grid Layout] Implement the grid-area shorthand
https://bugs.webkit.org/show_bug.cgi?id=103334

Reviewed by Andreas Kling.

Source/WebCore:

Based on Blink r151684 by <jchaffraix@chromium.org>

Test: fast/css-grid-layout/grid-item-area-get-set.html

Added support to specify grid positions using the
'-webkit-grid-area' shorthand. Named grid areas are still not
allowed, to be done in a follow up patch as it likely requires
'-webkit-grid-template' support.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridItemPositionShorthand):

  • css/CSSPropertyNames.in:
  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):

  • css/StylePropertyShorthand.cpp:

(WebCore::webkitGridAreaShorthand):
(WebCore::shorthandForProperty):

  • css/StylePropertyShorthand.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

LayoutTests:

From Blink r151684 by <jchaffraix@chromium.org>

  • fast/css-grid-layout/grid-item-area-get-set-expected.txt: Added.
  • fast/css-grid-layout/grid-item-area-get-set.html: Added.
1:10 AM Changeset in webkit [156637] by rgabor@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Speculative build fix on ARMv7 Thumb2 after r156490.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::fmodAsDFGOperation):

12:35 AM Changeset in webkit [156636] by gyuyoung.kim@samsung.com
  • 8 edits in trunk/Source/WebCore

Generate toCSSFooValue for CSSGradientValue, CSSLinearGradientValue and CSSRadialGradient
https://bugs.webkit.org/show_bug.cgi?id=122060

Reviewed by Antti Koivisto.

As a step to generate toCSSFooValue, toCSSGradientValuem toCSSLinearGradientValue and
toCSSRadialGradient are generated. isLinearGradient() and isRadialGradient() are moved
from each class to CSSValue in order to generate toCSSFooValue.

No new tests, no behavior change.

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::image):
(WebCore::CSSGradientValue::gradientWithStylesResolved):

  • css/CSSGradientValue.h:
  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseDeprecatedGradient):

  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

(WebCore::CSSValue::isLinearGradient):
(WebCore::CSSValue::isRadialGradient):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):

12:12 AM Changeset in webkit [156635] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

user-select: none cursor turns to I-beam on mouse dragging
https://bugs.webkit.org/show_bug.cgi?id=90159

Patch by Vani Hegde <vani.hegde@samsung.com> on 2013-09-30
Reviewed by Ryosuke Niwa.

Source/WebCore:

When tried to select some text in an area that has style
cursor:default set, cursor type changes to text cursor ignoring
the cursor style that is explicitly set.

When the cursor style is explicitly set as default (or something else),
we should not change it to text cursor no matter what we are over
or what operation we are performing (be it hovering over the text
or selecting the text).

During text selection, changing the cursor type to text only when
there is no explicit cursor type set fixes the issue.

Test: editing/caret/selection-with-caret-type-progress.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::selectCursor):
During selection, set the cursor style to text only if there is no
explicit cursor style set.

LayoutTests:

Test case added to verify that explicitly set cursor style
is retained on performing text selection.

  • editing/caret/selection-with-caret-type-progress-expected.txt: Added.
  • editing/caret/selection-with-caret-type-progress.html: Added.

Sep 29, 2013:

11:32 PM Changeset in webkit [156634] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

FTL: refactor compileAdd and compileArithSub into one function.
https://bugs.webkit.org/show_bug.cgi?id=122081

Patch by Nadav Rotem <nrotem@apple.com> on 2013-09-29
Reviewed by Geoffrey Garen.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileAddSub):

10:40 PM Changeset in webkit [156633] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebCore

Generate toCSSFooValue() for CSSCanvasValue
https://bugs.webkit.org/show_bug.cgi?id=122058

Reviewed by Antti Koivisto.

Generate toCSSFooValue() for CSSCanvasValue, and use it.
This type cast function will help to detect bad-casts.
isCanvasValue() is added in order to generate toCSSCanvasValue.

No new tests, no behavior change.

  • css/CSSCanvasValue.h:
  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):

  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

(WebCore::CSSValue::isCanvasValue):

10:38 PM Changeset in webkit [156632] by Darin Adler
  • 5 edits in trunk/Source/ThirdParty

Take some Xcode advice about turning on additional warnings in ANGLE and gtest
https://bugs.webkit.org/show_bug.cgi?id=122087

Reviewed by Mark Rowe.

Source/ThirdParty:

  • gtest/xcode/Config/General.xcconfig: Added some warnings that Xcode 5 suggested.

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig: Add some of the warnings that Xcode 5 suggested.
  • src/compiler/preprocessor/Tokenizer.l: Defined YY_NO_INPUT so we don't compile

an unused function and get a warning.

10:30 PM Changeset in webkit [156631] by mrowe@apple.com
  • 9 edits in trunk

Fix the Lion build.

Ensure that C++ and Objective-C++ files build with the right compiler flags.

Source/WebCore:

  • Configurations/WebCore.xcconfig:

Source/WebKit/mac:

  • Configurations/WebKit.xcconfig:

Source/WebKit2:

  • Configurations/BaseTarget.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
  • WebKitTestRunner/Configurations/BaseTarget.xcconfig:
10:28 PM Changeset in webkit [156630] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebCore

Generate toCSSFooValue() for CSSLineBoxContainValue
https://bugs.webkit.org/show_bug.cgi?id=122054

Reviewed by Darin Adler.

As a step to use toCSSFooValue, toCSSLineBoxContainValue is generated by using
CSS_VALUE_TYPE_CASTS. To use it, isCSSLineBoxContainValue() is changed to
isLineBoxContatinValue(). Unnecessary local variable is removed by this patch.

No new tests, no behavior changes.

  • css/CSSLineBoxContainValue.h:
  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

(WebCore::CSSValue::isLineBoxContainValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

10:26 PM Changeset in webkit [156629] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/Source/WebCore

Generate toCSSCrossfadeValue() instead of using manual function
https://bugs.webkit.org/show_bug.cgi?id=122057

Reviewed by Antti Koivisto.

Generated toCSSFooValue() supports more plenty functions rather than
to use manual cast function.

No new tests, no behavior changes.

  • css/CSSCrossfadeValue.h:
  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):

  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

10:22 PM Changeset in webkit [156628] by gyuyoung.kim@samsung.com
  • 6 edits in trunk/Source/WebCore

Generate toCSSFooValue() for CSSFilterImageValue and CSSInitialValue
https://bugs.webkit.org/show_bug.cgi?id=122056

Reviewed by Antti Koivisto.

Generate toCSSFooValue() for CSSFilterImageValue and CSSInitialValue, and use it.
This type cast function will help to detect bad-casts.

No new tests, no behavior changes.

  • css/CSSFilterImageValue.h:
  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):

  • css/CSSInitialValue.h:
  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::generatedOrPendingFromValue):

9:57 PM Changeset in webkit [156627] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Fix crashes caused by my recent attempt at a Windows build fix.

  • bindings/js/WebCoreTypedArrayController.cpp: (WebCore::WebCoreTypedArrayController::toJS): Added back the prefix for the call to WebCore::toJS, otherwise this function just calls itself infinitely recursively.
9:56 PM Changeset in webkit [156626] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the build.

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::evaluate):

9:36 PM Changeset in webkit [156625] by weinig@apple.com
  • 14 edits in trunk/Source/WebCore

Cleanup PageThrottler and PageConsole a bit
https://bugs.webkit.org/show_bug.cgi?id=122085

Reviewed by Anders Carlsson.

  • html/HTMLMediaElement.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::completed):

  • loader/FrameLoader.h:
  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::checkForHTTPStatusCodeError):
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::willCancel):

  • loader/SubresourceLoader.h:

Store the PageActivityAssertionToken as a std::unique_ptr.

  • page/Page.cpp:

(WebCore::Page::Page):
Use createOwned and pass this by reference for the PageThrottler and PageConsole.
(WebCore::Page::~Page):
Remove unnecessary clearing of an OwnPtr that is about to be destroyed.

  • page/Page.h:

Make m_pageThrottler const and return it as a reference.

  • page/PageActivityAssertionToken.cpp:

(WebCore::PageActivityAssertionToken::PageActivityAssertionToken):
(WebCore::PageActivityAssertionToken::~PageActivityAssertionToken):

  • page/PageActivityAssertionToken.h:

Take the PageThrottler by reference in the constructor. It is never null.

  • page/PageConsole.cpp:

(WebCore::PageConsole::PageConsole):
(WebCore::PageConsole::~PageConsole):
(WebCore::PageConsole::addMessage):

  • page/PageConsole.h:

Pass and store the Page as a reference and remove an extraneous null check. Remove
the create function.

  • page/PageThrottler.cpp:

(WebCore::PageThrottler::PageThrottler):
(WebCore::PageThrottler::~PageThrottler):
(WebCore::PageThrottler::createActivityToken):
(WebCore::PageThrottler::throttlePage):
(WebCore::PageThrottler::unthrottlePage):
(WebCore::PageThrottler::addActivityToken):
(WebCore::PageThrottler::removeActivityToken):

  • page/PageThrottler.h:

Pass and store the Page as a reference. Move the creation of PageActivityAssertionToken here
to aid encapsulation.

8:45 PM Changeset in webkit [156624] by akling@apple.com
  • 52 edits in trunk/Source

Pass VM instead of JSGlobalObject to function constructors.
<https://webkit.org/b/122082>

Reviewed by Darin Adler.

Functions don't need anything from the global object during their
construction and only use it to get to the VM. Reduce loads by
simply passing the VM around instead.

This patch is mostly mechanical, I just changed the signature of
InternalFunction and worked my way from there until it built.

JSC release binary size -= 4840 bytes.

7:54 PM Changeset in webkit [156623] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Try to fix Windows build.

  • bindings/js/WebCoreTypedArrayController.cpp: Windows has a symbol named Handle, so we need to call JSC::Handle out by name. To fix that, I removed "using namespace JSC" entirely. And just for fun, sort of "rewrote" this file. (WebCore::WebCoreTypedArrayController::WebCoreTypedArrayController): Removed unneeded explicit initialization of m_owner. (WebCore::WebCoreTypedArrayController::~WebCoreTypedArrayController): Fixed formatting. (WebCore::WebCoreTypedArrayController::toJS): Added lots of explicit JSC and got rid of local. (WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::isReachableFromOpaqueRoots): Cut down on locals, used auto& for type, and called it "wrapper" since that's what JSArrayBuffer is. (WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::finalize): More of the same.
7:40 PM Changeset in webkit [156622] by Darin Adler
  • 138 edits in trunk/Source

Use RenderElement instead of RenderObject in many places
https://bugs.webkit.org/show_bug.cgi?id=122078

Reviewed by Andreas Kling.

Source/ThirdParty/ANGLE:

  • ANGLE.xcodeproj/project.pbxproj: Let Xcode do its thing to this file.

Source/WebCore:

  • WebCore.exp.in: Updated for name changes.
  • dom/ContainerNode.h: Moved renderer() here from Element.
  • dom/Element.h: Moved renderer() from here to ContainerNode.
  • render/RenderElement.h: Moved renderer() from Element to ContainerNode.
  • accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::imageMapLinkRenderer):
(WebCore::AccessibilityImageMapLink::detachFromParent):
(WebCore::AccessibilityImageMapLink::elementPath):
(WebCore::AccessibilityImageMapLink::elementRect):

  • accessibility/AccessibilityImageMapLink.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

  • bindings/objc/DOM.mm:

(-[DOMElement image]):
(-[DOMElement _font]):
(-[DOMElement _imageTIFFRepresentation]):

  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::canvasChanged):
(WebCore::CSSCanvasValue::canvasResized):
(WebCore::CSSCanvasValue::canvasDestroyed):
(WebCore::CSSCanvasValue::fixedSize):
(WebCore::CSSCanvasValue::image):

  • css/CSSCanvasValue.h:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::computeRenderStyleForProperty):

  • css/CSSCrossfadeValue.cpp:

(WebCore::subimageKnownToBeOpaque):
(WebCore::CSSCrossfadeValue::fixedSize):
(WebCore::CSSCrossfadeValue::knownToBeOpaque):
(WebCore::CSSCrossfadeValue::image):
(WebCore::CSSCrossfadeValue::crossfadeChanged):

  • css/CSSCrossfadeValue.h:
  • css/CSSFilterImageValue.cpp:

(WebCore::CSSFilterImageValue::fixedSize):
(WebCore::CSSFilterImageValue::knownToBeOpaque):
(WebCore::CSSFilterImageValue::image):
(WebCore::CSSFilterImageValue::filterImageChanged):

  • css/CSSFilterImageValue.h:
  • css/CSSFontSelector.cpp:
  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::image):
(WebCore::CSSGradientValue::addStops):
(WebCore::CSSGradientValue::knownToBeOpaque):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::createGradient):

  • css/CSSGradientValue.h:

(WebCore::CSSGradientValue::fixedSize):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::addClient):
(WebCore::CSSImageGeneratorValue::removeClient):
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::knownToBeOpaque):

  • css/CSSImageGeneratorValue.h:

(WebCore::CSSImageGeneratorValue::clients):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::knownToBeOpaque):

  • css/CSSImageValue.h:
  • css/DeprecatedStyleBuilder.cpp:
  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::removeMarkersFromList):
(WebCore::DocumentMarkerController::repaintMarkers):

  • dom/Element.cpp:

(WebCore::localZoomForRenderer):
(WebCore::adjustForLocalZoom):
(WebCore::Element::offsetParent):
(WebCore::Element::updateExistingPseudoElement):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::create):
(WebCore::ElementRareData::ElementRareData):

  • dom/Node.cpp:

(WebCore::Node::ensureRareData):

  • editing/DeleteButtonController.cpp:

(WebCore::isDeletableElement):

  • editing/Editor.cpp:

(WebCore::Editor::hasBidiSelection):
(WebCore::Editor::baseWritingDirectionForSelectionStart):

  • editing/EditorCommand.cpp:

(WebCore::verticalScrollDistance):

  • editing/htmlediting.cpp:

(WebCore::directionOfEnclosingBlock):

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::fontForSelection):
(WebCore::getImage):

  • editing/mac/EditorMac.mm:

(WebCore::Editor::fontForSelection):
(WebCore::getImage):

  • editing/markup.cpp:
  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::computePath):
(WebCore::HTMLAreaElement::computeRect):
(WebCore::HTMLAreaElement::setFocus):

  • html/HTMLAreaElement.h:
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::setInnerText):

  • html/HTMLFormControlElement.cpp:

(WebCore::updateFromElementCallback):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::rendererIsNeeded):

  • html/HTMLFrameOwnerElement.h:
  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::x):
(WebCore::HTMLImageElement::y):
(WebCore::HTMLImageElement::willRespondToMouseClickEvents):

  • html/HTMLMapElement.cpp:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::defaultEventHandler):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::renderMeter):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::didRecalcStyle):

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::willRespondToMouseClickEvents):
(WebCore::HTMLPlugInElement::defaultEventHandler):
(WebCore::HTMLPlugInElement::isKeyboardFocusable):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::defaultEventHandler):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::renderProgress):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::scrollToSelection):
(WebCore::HTMLSelectElement::setOptionsChangedOnRenderer):
(WebCore::HTMLSelectElement::selectOption):

  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::cellAbove):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::hasVisibleTextArea):
(WebCore::HTMLTextFormControlElement::setSelectionRange):

  • html/InputType.h:
  • html/parser/HTMLResourcePreloader.cpp:
  • html/shadow/MediaControlElementTypes.cpp:

(WebCore::MediaControlElement::setDisplayType):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::startDrag):
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):

  • html/shadow/MeterShadowElement.cpp:

(WebCore::MeterShadowElement::rendererIsNeeded):
(WebCore::MeterInnerElement::rendererIsNeeded):

  • inspector/InspectorOverlay.cpp:
  • inspector/InspectorTimelineAgent.cpp:
  • inspector/InspectorTimelineAgent.h:
  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::renderImageResource):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::currentFrameKnownToBeOpaque):

  • loader/cache/CachedImage.h:
  • mathml/MathMLElement.cpp:
  • page/ContextMenuController.cpp:
  • page/DragController.cpp:

(WebCore::DragController::draggableElement):

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::startPanScrolling):
(WebCore::EventHandler::autoscrollRenderer):
(WebCore::EventHandler::scrollOverflow):
(WebCore::EventHandler::logicalScrollOverflow):
(WebCore::EventHandler::subframeForTargetNode):
(WebCore::EventHandler::selectCursor):
(WebCore::layerForNode):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::clearGestureScrollNodes):

  • page/EventHandler.h:
  • page/FocusController.cpp:
  • page/Frame.cpp:

(WebCore::Frame::ownerRenderer):
(WebCore::Frame::visiblePositionForPoint):
(WebCore::Frame::nodeImage):

  • page/FrameView.cpp:

(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::applyPaginationToViewport):
(WebCore::FrameView::calculateScrollbarModesForLayout):
(WebCore::FrameView::isEnclosedInCompositingLayer):
(WebCore::FrameView::embeddedContentBox):
(WebCore::FrameView::addSlowRepaintObject):
(WebCore::FrameView::removeSlowRepaintObject):
(WebCore::FrameView::addViewportConstrainedObject):
(WebCore::FrameView::removeViewportConstrainedObject):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::repaintSlowRepaintObjects):
(WebCore::FrameView::setViewportConstrainedObjectsNeedLayout):
(WebCore::FrameView::updateOverflowStatus):
(WebCore::FrameView::updateScrollCorner):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):

  • page/FrameView.h:
  • page/PageSerializer.cpp:

(WebCore::PageSerializer::addImageToResources):

  • page/PageSerializer.h:
  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::AnimationBase):
(WebCore::AnimationBase::updateStateMachine):

  • page/animation/AnimationBase.h:

(WebCore::AnimationBase::renderer):

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::ensureCompositeAnimation):
(WebCore::AnimationControllerPrivate::clear):
(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer):
(WebCore::AnimationControllerPrivate::isRunningAnimationOnRenderer):
(WebCore::AnimationControllerPrivate::isRunningAcceleratedAnimationOnRenderer):
(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):
(WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
(WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
(WebCore::AnimationControllerPrivate::numberOfActiveAnimations):
(WebCore::AnimationController::cancelAnimations):
(WebCore::AnimationController::updateAnimations):
(WebCore::AnimationController::getAnimatedStyleForRenderer):
(WebCore::AnimationController::notifyAnimationStarted):
(WebCore::AnimationController::pauseAnimationAtTime):
(WebCore::AnimationController::pauseTransitionAtTime):
(WebCore::AnimationController::isRunningAnimationOnRenderer):
(WebCore::AnimationController::isRunningAcceleratedAnimationOnRenderer):

  • page/animation/AnimationController.h:
  • page/animation/AnimationControllerPrivate.h:
  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::crossfadeBlend):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::updateKeyframeAnimations):
(WebCore::CompositeAnimation::animate):

  • page/animation/CompositeAnimation.h:
  • page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::ImplicitAnimation):
(WebCore::ImplicitAnimation::animate):
(WebCore::ImplicitAnimation::pauseAnimation):
(WebCore::ImplicitAnimation::sendTransitionEvent):

  • page/animation/ImplicitAnimation.h:

(WebCore::ImplicitAnimation::create):

  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::animate):
(WebCore::KeyframeAnimation::pauseAnimation):
(WebCore::KeyframeAnimation::endAnimation):
(WebCore::KeyframeAnimation::sendAnimationEvent):

  • page/animation/KeyframeAnimation.h:
  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::passSubframeEventToSubframe):

  • page/mac/FrameSnapshottingMac.mm:

(WebCore::snapshotDragImage):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::paint):

  • rendering/CounterNode.cpp:

(WebCore::CounterNode::CounterNode):
(WebCore::CounterNode::create):

  • rendering/CounterNode.h:

(WebCore::CounterNode::owner):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter):
(WebCore::FilterEffectRenderer::build):

  • rendering/FilterEffectRenderer.h:
  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::spellingToolTip):
(WebCore::HitTestResult::title):
(WebCore::HitTestResult::innerTextIfTruncated):
(WebCore::HitTestResult::image):

  • rendering/LayoutRepainter.cpp:

(WebCore::LayoutRepainter::LayoutRepainter):

  • rendering/LayoutRepainter.h:
  • rendering/LayoutState.h:

(WebCore::LayoutState::LayoutState):

  • rendering/LineWidth.h:
  • rendering/LogicalSelectionOffsetCaches.h:

(WebCore::isContainingBlockCandidateForAbsolutelyPositionedObject):
(WebCore::isNonRenderBlockInline):
(WebCore::containingBlockForFixedPosition):
(WebCore::containingBlockForAbsolutePosition):
(WebCore::containingBlockForObjectInFlow):
(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):

  • rendering/PaintInfo.h:

(WebCore::PaintInfo::PaintInfo):
(WebCore::PaintInfo::updateSubtreePaintRootForChildren):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintFillLayers):
(WebCore::RenderBox::paintFillLayer):

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderCounter.cpp:

(WebCore::nextInPreOrder):
(WebCore::planCounter):
(WebCore::makeCounterNode):
(WebCore::RenderCounter::originalText):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::~RenderElement):
(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::removeChildInternal):
(WebCore::RenderElement::willBeDestroyed):
(WebCore::RenderElement::rendererForRootBackground):

  • rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::initialize):

  • rendering/RenderImageResource.h:
  • rendering/RenderImageResourceStyleImage.cpp:

(WebCore::RenderImageResourceStyleImage::initialize):

  • rendering/RenderImageResourceStyleImage.h:

(WebCore::RenderImageResourceStyleImage::create):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::canBeComposited):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore):
(WebCore::RenderLayerCompositor::reasonsForCompositing):
(WebCore::RenderLayerCompositor::requiresCompositingForTransform):
(WebCore::RenderLayerCompositor::requiresCompositingForVideo):
(WebCore::RenderLayerCompositor::requiresCompositingForCanvas):
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
(WebCore::RenderLayerCompositor::requiresCompositingForFrame):
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason):
(WebCore::RenderLayerCompositor::requiresCompositingForFilters):
(WebCore::RenderLayerCompositor::requiresCompositingForBlending):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
(WebCore::RenderLayerCompositor::isRunningAcceleratedTransformAnimation):

  • rendering/RenderLayerCompositor.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock):
(WebCore::mustRepaintFillLayers):
(WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered):
(WebCore::RenderObject::willBeDestroyed):

  • rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::rendererOwningScrollbar):

  • rendering/RenderScrollbarPart.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBackgroundsBehindCell):

  • rendering/RenderTableCell.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/style/FillLayer.cpp:

(WebCore::FillLayer::hasOpaqueImage):

  • rendering/style/FillLayer.h:
  • rendering/style/KeyframeList.h:

(WebCore::KeyframeList::KeyframeList):

  • rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::imageSize):
(WebCore::StyleCachedImage::computeIntrinsicDimensions):
(WebCore::StyleCachedImage::setContainerSizeForRenderer):
(WebCore::StyleCachedImage::addClient):
(WebCore::StyleCachedImage::removeClient):
(WebCore::StyleCachedImage::image):
(WebCore::StyleCachedImage::knownToBeOpaque):

  • rendering/style/StyleCachedImage.h:
  • rendering/style/StyleCachedImageSet.cpp:

(WebCore::StyleCachedImageSet::imageSize):
(WebCore::StyleCachedImageSet::computeIntrinsicDimensions):
(WebCore::StyleCachedImageSet::setContainerSizeForRenderer):
(WebCore::StyleCachedImageSet::addClient):
(WebCore::StyleCachedImageSet::removeClient):
(WebCore::StyleCachedImageSet::image):
(WebCore::StyleCachedImageSet::knownToBeOpaque):

  • rendering/style/StyleCachedImageSet.h:
  • rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::imageSize):
(WebCore::StyleGeneratedImage::computeIntrinsicDimensions):
(WebCore::StyleGeneratedImage::addClient):
(WebCore::StyleGeneratedImage::removeClient):
(WebCore::StyleGeneratedImage::image):
(WebCore::StyleGeneratedImage::knownToBeOpaque):

  • rendering/style/StyleGeneratedImage.h:
  • rendering/style/StyleImage.h:

(WebCore::StyleImage::imagesEquivalent):

  • rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::cssImageValue):
(WebCore::StylePendingImage::cssImageGeneratorValue):
(WebCore::StylePendingImage::cssCursorImageValue):
(WebCore::StylePendingImage::cssImageSetValue):
(WebCore::StylePendingImage::computeIntrinsicDimensions):

  • testing/Internals.cpp:

(WebCore::Internals::boundingBox):
(WebCore::Internals::isSelectPopupVisible):
(WebCore::Internals::isPluginUnavailabilityIndicatorObscured):
Use RenderElement instead of RenderObject where it was easy to do so.
For local variables holding the return value of renderer() functions,
use auto instead, so the most-specific possible type will be used,
without having to figure out what that is in each case. Also use some
more OVERRIDE and FINAL and use nullptr instead of 0. And replace some
cryptic short local variable names with words.

5:57 PM Changeset in webkit [156621] by akling@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Pass VM instead of JSGlobalObject to ArrayPrototype constructor.
<https://webkit.org/b/122079>

Reviewed by Geoffrey Garen.

ArrayPrototype doesn't need the global object for anything during
construction, so reduce the amount of loads by just passing the VM.

3:20 PM Changeset in webkit [156620] by akling@apple.com
  • 31 edits in trunk/Source

Pass VM instead of ExecState to simple builtin constructors.
<https://webkit.org/b/122077>

Reviewed by Sam Weinig.

None of the simple builtins need the ExecState for anything during
their construction, so reduce the amount of loads by just passing
the VM around instead.

3:16 PM Changeset in webkit [156619] by pdr@google.com
  • 8 edits
    3 adds in trunk

Repaint borders and outlines on pseudo content changes
https://bugs.webkit.org/show_bug.cgi?id=122070

Reviewed by Andreas Kling.

Source/WebCore:

This patch fixes a regression from wkrev.com/150259 where pseudo content with
borders or outlines would fail to repaint if the color property changed.
The root bug is that border-color and outline-color properties use 'color' if
no explicit border-color or outline-color are given, and changing color should
repaint borders and outlines even if the text content is empty.

Relevant spec sections:
border: http://www.w3.org/TR/CSS1/#border-color
outline: http://www.w3.org/TR/CSS2/ui.html#propdef-outline-color

This patch also renames StyleDifferenceRepaintIfText to
StyleDifferenceRepaintIfTextOrBorderOrOutline and updates the relevant functions.

Test: fast/repaint/hover-pseudo-borders.html

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::hasImmediateNonWhitespaceTextChildOrBorderOrOutline):

This function has been renamed to reflect that it returns true for borders
or outlines as well.

(WebCore::RenderElement::shouldRepaintForStyleDifference):

  • rendering/RenderElement.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresRepaintIfTextOrBorderOrOutline):
(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::clientStyleChanged):

These have also been renamed to reflect the new borders and outlines check.

LayoutTests:

  • fast/repaint/hover-pseudo-borders.html: Added.
  • platform/mac/fast/repaint/hover-pseudo-borders-expected.png: Added.
  • platform/mac/fast/repaint/hover-pseudo-borders-expected.txt: Added.
1:50 PM Changeset in webkit [156618] by Antti Koivisto
  • 6 edits in trunk/Source/WebCore

Tighten typing in inline rendering
https://bugs.webkit.org/show_bug.cgi?id=122076

Reviewed by Andreas Kling.

More RenderElement, const, &, etc.

  • dom/Position.cpp:

(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):

  • rendering/InlineFlowBox.cpp:

(WebCore::isLastChildForRenderer):
(WebCore::isAncestorAndWithinBlock):
(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
(WebCore::InlineFlowBox::nodeAtPoint):

  • rendering/InlineIterator.h:

(WebCore::InlineIterator::InlineIterator):
(WebCore::InlineIterator::root):
(WebCore::isEmptyInline):
(WebCore::bidiNextShared):
(WebCore::bidiNextSkippingEmptyInlines):
(WebCore::bidiNextIncludingEmptyInlines):
(WebCore::bidiFirstSkippingEmptyInlines):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::inlineLogicalWidth):
(WebCore::alwaysRequiresLineBox):
(WebCore::requiresLineBox):
(WebCore::canBreakAtThisPosition):
(WebCore::LineBreaker::nextSegmentBreak):

  • rendering/shapes/ShapeInsideInfo.h:

(WebCore::LineSegmentIterator::LineSegmentIterator):

12:31 PM Changeset in webkit [156617] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Refactor code for finding x86 scratch register.
https://bugs.webkit.org/show_bug.cgi?id=122072

Patch by Nadav Rotem <nrotem@apple.com> on 2013-09-29
Reviewed by Geoffrey Garen.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::getUnusedRegister):
(JSC::MacroAssemblerX86Common::store8):
(JSC::MacroAssemblerX86Common::store16):

11:04 AM Changeset in webkit [156616] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening. Skip the IndexedDB tests for now as the feature is going
through substantial changes that don't ensure constant proper functionality.

  • platform/gtk-wk2/TestExpectations:
  • platform/gtk/TestExpectations:

Sep 28, 2013:

11:02 PM Changeset in webkit [156615] by weinig@apple.com
  • 9 edits
    2 deletes in trunk/Source/WebCore

Merge ScriptControllerBase into ScriptController
https://bugs.webkit.org/show_bug.cgi?id=122071

Reviewed by Antti Koivisto.

There is no need for ScriptControllerBase. Remove it.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.cpp: Removed.
  • bindings/ScriptControllerBase.h: Removed.
  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::canExecuteScripts):
(WebCore::ScriptController::executeScript):
(WebCore::ScriptController::executeIfJavaScriptURL):

  • bindings/js/ScriptController.h:
10:42 PM Changeset in webkit [156614] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r156613 for ports enabling CSS3_TEXT.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::requiresIndent): Use the RenderStyle reference.

9:34 PM Changeset in webkit [156613] by Antti Koivisto
  • 21 edits in trunk/Source/WebCore

Switch inline boxes to use const RenderStyle&
https://bugs.webkit.org/show_bug.cgi?id=122068

Reviewed by Sam Weinig.

1:20 PM Changeset in webkit [156612] by Antti Koivisto
  • 12 edits in trunk/Source/WebCore

Add first()/last() to ElementIteratorAdapters
https://bugs.webkit.org/show_bug.cgi?id=122067

Reviewed by Darin Adler.

Add a convenient way for getting the first and last element if it exists.

Use it in some places.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::canvasHasFallbackContent):

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

  • dom/Document.cpp:

(WebCore::Document::childrenChanged):
(WebCore::Document::removeTitle):

  • dom/ElementChildIterator.h:

(WebCore::::first):
(WebCore::::last):

  • dom/ElementDescendantIterator.h:

(WebCore::::first):
(WebCore::::last):

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::legend):

  • html/HTMLLegendElement.cpp:

(WebCore::HTMLLegendElement::associatedControl):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::finishParsingChildren):
(WebCore::HTMLMediaElement::selectMediaResource):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::title):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::rebuildFontFace):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::hasSingleSecurityOrigin):

1:01 PM Changeset in webkit [156611] by mrowe@apple.com
  • 18 edits
    2 copies in trunk

Fix some failures with newer versions of clang.

Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.

Reviewed by Dan Bernstein.

Source/WebCore:

  • Configurations/WebCore.xcconfig:

Source/WebKit/mac:

  • Configurations/DebugRelease.xcconfig:
  • Configurations/WebKit.xcconfig:

Source/WebKit2:

  • Configurations/BaseTarget.xcconfig:
  • Configurations/DebugRelease.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
  • DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
  • DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
  • WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
12:15 PM Changeset in webkit [156610] by mrowe@apple.com
  • 17 edits in trunk/Source

Take Xcode's advice and enable some extra warnings.

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:
  • JavaScriptCore.xcodeproj/project.pbxproj:

Source/WebCore:

  • Configurations/Base.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::removeNamedItemNS): Use the correct constant.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:
  • WebKit2.xcodeproj/project.pbxproj:

Source/WTF:

  • Configurations/Base.xcconfig:
  • WTF.xcodeproj/project.pbxproj:
12:10 PM Changeset in webkit [156609] by weinig@apple.com
  • 4 edits in trunk/Source/WebCore

CTTE: VisitedLinkState should hold a Document&
https://bugs.webkit.org/show_bug.cgi?id=122066

Reviewed by Antti Koivisto.

The Document can never be null, so use a reference.

11:30 AM Changeset in webkit [156608] by Antti Koivisto
  • 23 edits in trunk/Source/WebCore

Clean up code for getting first line style
https://bugs.webkit.org/show_bug.cgi?id=122037

Reviewed by Andreas Kling.

We have confusing RenderObject::style(bool firstLine). Get rid of it in favour of
just using RenderObject::firstLineStyle() where appropriate.

Also switch to RenderStyle references in many places and move first line style caching
code down to RenderElement.

10:19 AM Changeset in webkit [156607] by Darin Adler
  • 44 edits in trunk/Source

Add Frame::mainFrame and Frame::isMainFrame
https://bugs.webkit.org/show_bug.cgi?id=122064

Reviewed by Andreas Kling.

Source/WebCore:

  • WebCore.exp.in: Removed exports of FrameView::isMainFrameView and

Page::frameIsMainFrame. Since the new isMainFrame function is inline, it
does not need to be exported.

  • history/PageCache.cpp:

(WebCore::PageCache::markPagesForFullStyleRecalc):
(WebCore::PageCache::markPagesForDeviceScaleChanged):
These two were the only functions I found that really wanted the equivalent
of Page::frameIsMainFrame, so wrote it out here instead of using a function
call.

  • inspector/InspectorAgent.cpp: Removed the unused isMainResourceLoader function.
  • inspector/InspectorAgent.h: Removed declarations of a few nonexistent or

unused private member functions. Also removed the InjectedScriptForOriginMap
typedef: It's mor readable to use the type directly

  • loader/FrameLoader.h: Removed isLoadingMainFrame. It's not better than

calling frame().isMainFrame() directly.

  • page/Frame.cpp:

(WebCore::Frame::Frame): Initialize m_mainFrame and call selfOnlyRef, keeping
the MainFrame alive as long as any of its subframes is alive.
(WebCore::Frame::~Frame): Call selfOnlyDeref.
(WebCore::Frame::createView): Use isMainFrame.
(WebCore::Frame::setPageAndTextZoomFactors): Ditto.

  • page/Frame.h: Added Frame::mainFrame, Frame::isMainFrame, and Frame::m_mainFrame.
  • page/FrameView.h: Removed the isMainFrameView function. It's not better than

calling frame().isMainFrame() directly.

  • page/MainFrame.cpp:

(WebCore::MainFrame::MainFrame): Initialize m_selfOnlyRefCount to 0.
(WebCore::MainFrame::selfOnlyRef): Added.
(WebCore::MainFrame::selfOnlyDeref): Added.
(WebCore::MainFrame::dropChildren): Added. Called when the self-only reference
count reaches 0 to avoid a reference cycle with subframes.

  • page/MainFrame.h: Added new data members as mentioned above. Also, the

definition of the Frame::isMainFrame inline function goes here, since it can't
compile without the MainFrame class definition. This means that callers of
isMainFrame need to include MainFrame.h, which seems reasonable and is easy
to do.

  • page/Page.cpp:
  • page/Page.h: Added assertion to Page::mainFrame since it returns a reference.

Removed Page::frameIsMainFrame since it's not better than calling isMainFrame
on the frame.

  • dom/Document.cpp:

(WebCore::Document::setVisualUpdatesAllowed):
(WebCore::Document::didBecomeCurrentDocumentInFrame):
(WebCore::Document::updateViewportArguments):
(WebCore::Document::setInPageCache):
(WebCore::Document::ensurePlugInsInjectedScript):

  • history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

  • history/CachedPage.cpp:

(WebCore::CachedPage::restore):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):

  • html/ImageDocument.cpp:

(WebCore::ImageDocument::shouldShrinkToFit):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::didClearWindowObjectInWorld):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCommitLoadImpl):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
(WebCore::InspectorPageAgent::frameNavigated):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::willSendRequest):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::prepareForCachedPageRestore):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::didLayout):
(WebCore::FrameLoader::checkLoadComplete):
(WebCore::FrameLoader::addExtraFieldsToRequest):
(WebCore::FrameLoader::loadResourceSynchronously):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::dispatchDidCommitLoad):
(WebCore::FrameLoader::loadProgressingStatusChanged):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
(WebCore::HistoryController::restoreScrollPositionAndViewState):
(WebCore::HistoryController::updateForCommit):
(WebCore::HistoryController::updateForSameDocumentNavigation):
(WebCore::HistoryController::updateBackForwardListClippedAtTarget):
(WebCore::HistoryController::pushState):

  • loader/icon/IconController.cpp:

(WebCore::IconController::startLoader):

  • page/AutoscrollController.cpp:

(WebCore::AutoscrollController::stopAutoscrollTimer):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):

  • page/DOMWindow.cpp:

(WebCore::allowsBeforeUnloadListeners):
(WebCore::DOMWindow::focus):
(WebCore::DOMWindow::blur):
(WebCore::DOMWindow::close):
(WebCore::DOMWindow::allowedToChangeWindowGeometry):

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::keyEvent):

  • page/FrameTree.cpp:

(WebCore::FrameTree::find):
(WebCore::FrameTree::traverseNextWithWrap):

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::createScrollbar):
(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::setHeaderHeight):
(WebCore::FrameView::setFooterHeight):
(WebCore::FrameView::minimumScrollPosition):
(WebCore::FrameView::maximumScrollPosition):
(WebCore::FrameView::shouldUpdateFixedElementsAfterScrolling):
(WebCore::FrameView::beginDeferredRepaints):
(WebCore::FrameView::endDeferredRepaints):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::sendResizeEventIfNeeded):
(WebCore::FrameView::pagination):
(WebCore::FrameView::visibleContentScaleFactor):
(WebCore::FrameView::setVisibleScrollerThumbRect):
(WebCore::FrameView::scrollbarStyleChanged):
(WebCore::FrameView::paintScrollCorner):
(WebCore::FrameView::paintScrollbar):
(WebCore::FrameView::paintOverhangAreas):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):
Use the new functions where possible instead of Page::frameIsMainFrame,
Page::mainFrame, FrameLoader::isLoadingMainFrame, and FrameView::isMainFrameView.

Source/WebKit/blackberry:

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
Call isMainFrame.

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
(WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest):
(WebCore::FrameLoaderClientEfl::updateGlobalHistory):
Call isMainFrame.

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::assignIdentifierToInitialRequest):
Call isMainFrame.

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::canHandleRequest):
(WebFrameLoaderClient::transitionToCommittedForNewPage):

  • WebView/WebFrameView.mm:

(-[WebFrameView _install]):
Call isMainFrame.

Source/WebKit2:

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::shouldUseTiledBackingForFrameView):
Call isMainFrame.

9:14 AM Changeset in webkit [156606] by commit-queue@webkit.org
  • 3 edits
    8 adds in trunk

filter: drop-shadow doesnot support viewport units
https://bugs.webkit.org/show_bug.cgi?id=122053

Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-28
Reviewed by Darin Adler.

Source/WebCore:

drop-shadow properties were not applied incase its values
were given in vh, vw, vmax, vmin units.

Tests: fast/css/drop-shadow-viewport-height.html

fast/css/drop-shadow-viewport-vmax.html
fast/css/drop-shadow-viewport-vmin.html
fast/css/drop-shadow-viewport-width.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::createFilterOperations):
Calculating the drop-shadow values which has been specified in viewport
units.The vh/vw units are calcultated as percent of viewport height and
viewport width respectively. 1vmax: 1vw or 1vh, whatever is largest.
1vmin: 1vw or 1vh, whatever is smallest.

LayoutTests:

  • fast/css/drop-shadow-viewport-height-expected-mismatch.html: Added.
  • fast/css/drop-shadow-viewport-height.html: Added.
  • fast/css/drop-shadow-viewport-vmax-expected-mismatch.html: Added.
  • fast/css/drop-shadow-viewport-vmax.html: Added.
  • fast/css/drop-shadow-viewport-vmin-expected-mismatch.html: Added.
  • fast/css/drop-shadow-viewport-vmin.html: Added.
  • fast/css/drop-shadow-viewport-width-expected-mismatch.html: Added.
  • fast/css/drop-shadow-viewport-width.html: Added.

Added new tests for verifying that drop-shadow properties are applied
when its values are viewport units.

9:10 AM Changeset in webkit [156605] by commit-queue@webkit.org
  • 5 edits
    16 adds in trunk

REGRESSION (r154614): Setting the document scroll position isn't symmetric; can successfully set document.body.scrollTop, but can only read from document.documentElement.scrollTop
https://bugs.webkit.org/show_bug.cgi?id=121876

Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-28
Reviewed by Darin Adler.

Source/WebCore:

Non-Quirks mode should set/get scrolltop/scrollleft through
document.documentElement.scrollTop/document.documentElement.scrollLeft
Quirks mode should set/get scrolltop/scrollleft through
document.body.scrollTop/document.body.scrollLeft.

Tests: fast/dom/Element/body-scrollLeft-Quirks.html

fast/dom/Element/body-scrollLeft.html
fast/dom/Element/body-scrollTop-Quirks.html
fast/dom/Element/body-scrollTop.html
fast/dom/Element/documentElement-scrollLeft-Quirks.html
fast/dom/Element/documentElement-scrollLeft.html
fast/dom/Element/documentElement-scrollTop-Quirks.html
fast/dom/Element/documentElement-scrollTop.html

  • dom/Element.cpp:

(WebCore::Element::setScrollLeft):
(WebCore::Element::setScrollTop):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::setScrollLeft):
(WebCore::HTMLBodyElement::setScrollTop):
Need to set the scrollTop and scrollLeft after checking if document
is in quirks or non-quirks mode. Incase it is body.scrollLeft/
body.scrollTop set only if document is in quirks mode. If document is
non-quirks mode set documentElement.scrollLeft/documentElement.scrollTop.

LayoutTests:

  • fast/dom/Element/body-scrollLeft-Quirks-expected.txt: Added.
  • fast/dom/Element/body-scrollLeft-Quirks.html: Added.
  • fast/dom/Element/body-scrollLeft-expected.txt: Added.
  • fast/dom/Element/body-scrollLeft.html: Added.
  • fast/dom/Element/body-scrollTop-Quirks-expected.txt: Added.
  • fast/dom/Element/body-scrollTop-Quirks.html: Added.
  • fast/dom/Element/body-scrollTop-expected.txt: Added.
  • fast/dom/Element/body-scrollTop.html: Added.
  • fast/dom/Element/documentElement-scrollLeft-Quirks-expected.txt: Added.
  • fast/dom/Element/documentElement-scrollLeft-Quirks.html: Added.
  • fast/dom/Element/documentElement-scrollLeft-expected.txt: Added.
  • fast/dom/Element/documentElement-scrollLeft.html: Added.
  • fast/dom/Element/documentElement-scrollTop-Quirks-expected.txt: Added.
  • fast/dom/Element/documentElement-scrollTop-Quirks.html: Added.
  • fast/dom/Element/documentElement-scrollTop-expected.txt: Added.
  • fast/dom/Element/documentElement-scrollTop.html: Added.

Added test cases for verifying that Non-Quirks mode should set
scrolltop/scrollleft through document.documentElement.scrollTop/
document.documentElement.scrollLeft and Quirks mode should set/get
scrolltop/scrollleft through document.body.scrollTop/document.body.scrollLeft.

  • fast/multicol/scrolling-overflow.html:

Rebaselining existing tests as per the new behavior. To set
document.body.scrollLeft document to be in Quirks mode.

8:05 AM Changeset in webkit [156604] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Message sending functions should only accept rvalues
https://bugs.webkit.org/show_bug.cgi?id=122041

Reviewed by Andreas Kling.

In order to safely encode move-only types, make all send variants accept rvalues only, except
for the "send to all processes" ones. For them, copy the message before sending. This ensures that trying
to send a move-only type in a message will fail to compile.

  • NetworkProcess/NetworkResourceLoader.h:

(WebKit::NetworkResourceLoader::sendAbortingOnFailure):

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):

  • Platform/CoreIPC/MessageSender.h:

(CoreIPC::MessageSender::sendSync):

  • Shared/ChildProcessProxy.h:

(WebKit::ChildProcessProxy::send):
(WebKit::ChildProcessProxy::sendSync):

  • UIProcess/WebContext.h:

(WebKit::WebContext::sendToNetworkingProcess):
(WebKit::WebContext::sendToNetworkingProcessRelaunchingIfNecessary):
(WebKit::WebContext::sendToAllProcesses):
(WebKit::WebContext::sendToAllProcessesRelaunchingThemIfNecessary):
(WebKit::WebContext::sendToOneProcess):

  • UIProcess/WebPageGroup.h:

(WebKit::WebPageGroup::sendToAllProcessesInGroup):

8:02 AM Changeset in webkit [156603] by Philippe Normand
  • 5 edits in trunk/Source

Unreviewed GTK build fix after r156560.

Source/WebKit/gtk:

  • WebCoreSupport/AcceleratedCompositingContext.h:

Source/WebKit2:

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::paintContents):
(WebKit::LayerTreeHostGtk::createPageOverlayLayer):
(WebKit::LayerTreeHostGtk::destroyPageOverlayLayer):

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
7:15 AM Changeset in webkit [156602] by akling@apple.com
  • 25 edits in trunk/Source

Pass VM instead of ExecState to JSFunction constructors.
<https://webkit.org/b/122014>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

JSFunction doesn't need the ExecState for anything during its
construction, so reduce the amount of loads by just passing the
VM around instead.

Factored out putDirectNonIndexAccessor() from the existing
putDirectAccessor() to avoid snowballing the patch (and because
it's kinda neat to avoid the extra branch.)

JSC release binary size -= 9680 bytes.

Source/WebCore:

Updated for new JSFunction::create() signature.

6:27 AM Changeset in webkit [156601] by gyuyoung.kim@samsung.com
  • 10 edits in trunk/Source/WebCore

Generate toCSSFooValue() for CSSImageValue
https://bugs.webkit.org/show_bug.cgi?id=122051

Reviewed by Andreas Kling.

Clean up static_cast<CSSImageValue*> type casts. It will help to
detect bad cast as well as improve code readability.

Removed unnecessary local variables as well.

No new tests, no behavior changes.

  • css/CSSCrossfadeValue.cpp:

(WebCore::subimageKnownToBeOpaque):

  • css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::~CSSCursorImageValue):
(WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
(WebCore::CSSCursorImageValue::cachedImage):
(WebCore::CSSCursorImageValue::isSVGCursor):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::subimageIsPending):
(WebCore::CSSImageGeneratorValue::cachedImageForCSSValue):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::fillImageSet):

  • css/CSSImageValue.h:
  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::retrieveResourcesForProperties):

  • rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::data):
(WebCore::StylePendingImage::cssImageValue):

3:26 AM Changeset in webkit [156600] by mrowe@apple.com
  • 21 edits in trunk/Source/WebCore

WebCore fails to build with newer versions of clang.

Reviewed by Sam Weinig.

  • Modules/indexeddb/IDBIndex.cpp: Remove an unused constant.
  • Modules/indexeddb/IDBObjectStore.cpp: Ditto.
  • Modules/webaudio/AudioContext.cpp: Ditto.
  • Modules/webaudio/ScriptProcessorNode.cpp: Ditto.
  • Modules/webdatabase/SQLResultSet.cpp: Ditto.
  • Modules/webdatabase/SQLTransactionBackend.cpp: Ditto.
  • Modules/websockets/WebSocketHandshake.cpp: Ditto.
  • bindings/objc/DOM.mm: Disable a warning about overriding a protocol method in a cateogry around the one

place we do it. I don't understand why this generates a warning, nor can I see a different approach that
would not result in the warning being emitted.

  • css/CSSGrammar.y.in: #if a function that's only used inside an #if.
  • html/track/TextTrackCue.cpp: Remove an unused constant.
  • loader/TextResourceDecoder.cpp: Remove two unused functions.
  • page/ContentSecurityPolicy.cpp: Add #if's around constants and functions that are only used when CSP_NEXT is enabled.

(WebCore::CSPDirectiveList::checkSourceAndReportViolation): Reorder the ifs slightly to make the #if'ing easier.

  • page/ContentSecurityPolicy.h: Add #if's around functions that are only used when CSP_NEXT is enabled.
  • page/DOMSecurityPolicy.cpp: Ditto.
  • page/DOMSecurityPolicy.h: Ditto.
  • page/animation/CSSPropertyAnimation.cpp: Remove an unused function.
  • platform/mac/DisplaySleepDisabler.cpp: Add an #if around a constant that's only used on iOS.
  • platform/mac/WebCoreFullScreenWarningView.mm: Remove three unused constants.
  • rendering/RenderLayer.cpp: Remove two unused constants.
  • rendering/RenderLayerCompositor.cpp:

(WebCore::compositingLogEnabled): Move the #if around the function definition.

  • svg/SVGAnimatedAngle.cpp: Remove an unused function.
  • svg/SVGUseElement.cpp: #if a function that's only used inside an ASSERT.
  • xml/XPathStep.cpp: Ditto.
3:25 AM Changeset in webkit [156599] by mrowe@apple.com
  • 6 edits in trunk/Source/WebKit/mac

WebKit fails to build with newer versions of clang.

Reviewed by Sam Weinig.

  • Carbon/HIWebView.mm: Remove an unused function.
  • History/BinaryPropertyList.cpp: #if a constant that's only used in 64-bit.
  • Misc/WebIconDatabase.mm: Remove two unused constants.
  • Plugins/WebBaseNetscapePluginView.mm: Remove an unused constant.
  • WebCoreSupport/WebEditorClient.mm: Ditto.
3:23 AM Changeset in webkit [156598] by mrowe@apple.com
  • 7 edits in trunk/Source/WebKit2

WebKit2 fails to build with newer versions of clang.

Reviewed by Anders Carlsson.

  • Shared/VisitedLinkTable.cpp: #if a function that's only used inside an ASSERT.
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm: Remove an unused constant.
  • UIProcess/mac/WKFullScreenWindowController.mm: Ditto.
  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm: Ditto.
  • WebProcess/WebPage/FindController.cpp: Ditto.
  • WebProcess/WebPage/WebBackForwardListProxy.cpp: Remove two unused constants.
3:22 AM Changeset in webkit [156597] by mrowe@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

JavaScriptCore fails to build with newer versions of clang.

Reviewed by Sam Weinig.

  • interpreter/Interpreter.cpp: Remove an unused function.
  • parser/SourceProvider.cpp: Ditto.
  • runtime/GCActivityCallback.cpp: #if a constant that's only used on non-CF platforms.
  • runtime/JSCJSValue.cpp: Remove an unused constant.
  • runtime/JSString.cpp: Ditto.
3:19 AM Changeset in webkit [156596] by mrowe@apple.com
  • 5 edits in trunk/Source/WTF

<rdar://problem/15079224> WTF fails to build with newer versions of clang.

Reviewed by Sam Weinig.

  • wtf/DateMath.cpp: Remove some unused constants.
  • wtf/FastMalloc.cpp: #if some constants and functions that are unused in some configurations.

Remove a function that's unused on all platforms.

  • wtf/TCSystemAlloc.cpp: Remove some unused constants.

(TCMalloc_SystemRelease): Remove an if whose body is never executed.

  • wtf/dtoa.cpp: #if things such that storeInc is only defined when USE_LONG_LONG is undefined.

Remove an unused constant.

Sep 27, 2013:

10:35 PM Changeset in webkit [156595] by ap@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Restore accidentally removed ChangeLog lines.

9:08 PM Changeset in webkit [156594] by fpizlo@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Get rid of SetMyScope/SetCallee; use normal variables for the scope and callee of inlined call frames of closures
https://bugs.webkit.org/show_bug.cgi?id=122047

Reviewed by Oliver Hunt.

Currently we have the DFG reserve space for inline call frames at exactly the same stack
offsets that you would have gotten if the baseline interpreter/JIT had made the calls.
We need to get rid of that. One of the weirder parts of this is that we have special DFG
operations for accessing these inlined call frame headers. It's really hard for any
analysis of DFG IR to see what the liveness of any of those frame header "variables" is;
the liveness behaves like flushed arguments (it's all live until end of the inlinee) but
we don't have anything like a Flush node for those special variables.

This patch gets rid of the special operations for accessing inline call frame headers.
GetMyScope and GetCallee still remain, and are only for accessing the machine call
frame's scope/callee entries. The inline call frame's scope/callee now behave like
normal variables, and have Flush behavior just like inline arguments.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::setDirect):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::getScope):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getCalleeLoadElimination):
(JSC::DFG::CSEPhase::getMyScopeLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

5:32 PM Changeset in webkit [156593] by Bem Jones-Bey
  • 3 edits
    10 adds in trunk/LayoutTests

[CSS Shapes] New positioning model: Positive margins
https://bugs.webkit.org/show_bug.cgi?id=118089

Reviewed by Alexandru Chiculita.

The remaining tests for shape-outside with positive margins. These
have all been imported from the CSSWG's repo.

  • csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-005-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-005.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-006-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-006.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-007-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-007.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-008-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-008.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-009-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-009.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
5:11 PM Changeset in webkit [156592] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test media/media-controller-playback.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122042

  • platform/mac/TestExpectations: Marked as such.
5:03 PM Changeset in webkit [156591] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

4:45 PM Changeset in webkit [156590] by beidson@apple.com
  • 32 edits in trunk/Source/WebCore

IndexedDB IDL Refactoring.
https://bugs.webkit.org/show_bug.cgi?id=121996

Reviewed by Alexey Proskuryakov.

This includes:
1 - Leveraging EventTarget.idl inheritance
2 - Removing comments
3 - Reordering to match the spec's IDLs
4 - Removing nonstandard, WebKit-specific methods
5 - Updating interfaces to match the spec (versions are only uint64_t's now...)
6 - Updating implementation code as needed (versions are only uint64_t's now...)

IDL changes:

  • Modules/indexeddb/IDBCursor.idl:
  • Modules/indexeddb/IDBDatabase.idl:
  • Modules/indexeddb/IDBFactory.idl:
  • Modules/indexeddb/IDBIndex.idl:
  • Modules/indexeddb/IDBKeyRange.idl:
  • Modules/indexeddb/IDBObjectStore.idl:
  • Modules/indexeddb/IDBRequest.idl:
  • Modules/indexeddb/IDBTransaction.idl:
  • Modules/indexeddb/IDBVersionChangeEvent.idl:
  • Modules/indexeddb/IndexedDB.h: Add new enum to represent version nullness.

Adapt to new IDLs, and also refactor representation of initial, null versioning:

  • Modules/indexeddb/IDBCallbacks.h:

(WebCore::IDBCallbacks::onBlocked):
(WebCore::IDBCallbacks::onUpgradeNeeded):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::version):
(WebCore::IDBDatabase::onVersionChange):

  • Modules/indexeddb/IDBDatabase.h:
  • Modules/indexeddb/IDBDatabaseCallbacks.h:
  • Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp:

(WebCore::IDBDatabaseCallbacksImpl::onVersionChange):

  • Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::open):
(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):

  • Modules/indexeddb/IDBFactory.h:
  • Modules/indexeddb/IDBMetadata.h:

(WebCore::IDBDatabaseMetadata::IDBDatabaseMetadata):

  • Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::create):
(WebCore::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::onBlocked):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):

  • Modules/indexeddb/IDBOpenDBRequest.h:
  • Modules/indexeddb/IDBRequest.cpp:
  • Modules/indexeddb/IDBRequest.h:
  • Modules/indexeddb/IDBTransaction.cpp:
  • Modules/indexeddb/IDBTransaction.h:
  • Modules/indexeddb/IDBVersionChangeEvent.cpp:

(WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent):

  • Modules/indexeddb/IDBVersionChangeEvent.h:

(WebCore::IDBVersionChangeEvent::create):
(WebCore::IDBVersionChangeEvent::oldVersion):
(WebCore::IDBVersionChangeEvent::newVersion):

Keep leveldb building with minimal adaptations to the new IDLs,
but note that the LevelDB implementation is now incompatible with the spec:

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:

(WebCore::IDBBackingStore::getIDBDatabaseMetaData):
(WebCore::objectStoreCursorOptions):
(WebCore::indexCursorOptions):

  • Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:

(WebCore::IDBDatabaseBackendLevelDB::IDBDatabaseBackendLevelDB):
(WebCore::IDBDatabaseBackendLevelDB::openInternal):
(WebCore::IDBDatabaseBackendLevelDB::VersionChangeOperation::perform):
(WebCore::IDBDatabaseBackendLevelDB::processPendingCalls):
(WebCore::IDBDatabaseBackendLevelDB::openConnection):
(WebCore::IDBDatabaseBackendLevelDB::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendLevelDB::deleteDatabase):
(WebCore::IDBDatabaseBackendLevelDB::deleteDatabaseFinal):
(WebCore::IDBDatabaseBackendLevelDB::VersionChangeAbortOperation::perform):

  • Modules/indexeddb/leveldb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):

  • inspector/InspectorIndexedDBAgent.cpp: Update for metadata change.
4:40 PM Changeset in webkit [156589] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

CookieStorageShim should be PLATFORM(MAC) guarded
https://bugs.webkit.org/show_bug.cgi?id=121423

Reviewed by Darin Adler.

Original patch by Kwang Yul Seo <skyul@company100.com>.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

4:29 PM Changeset in webkit [156588] by enrica@apple.com
  • 22 edits in trunk/Source

Upstream changes to Pasteboard implementation for iOS.
https://bugs.webkit.org/show_bug.cgi?id=121818

Reviewed by Benjamin Poulain.

Source/WebCore:

  • WebCore.exp.in:
  • editing/Editor.cpp:

(WebCore::Editor::dispatchCPPEvent):

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::WebContentReader::addFragment):
(WebCore::Editor::WebContentReader::readWebArchive):
(WebCore::Editor::WebContentReader::readFilenames):
(WebCore::Editor::WebContentReader::readHTML):
(WebCore::Editor::WebContentReader::readRTFD):
(WebCore::Editor::WebContentReader::readRTF):
(WebCore::uniqueURLWithRelativePart):
(WebCore::Editor::WebContentReader::readImage):
(WebCore::Editor::WebContentReader::readURL):
(WebCore::Editor::WebContentReader::readPlainText):
(WebCore::Editor::webContentFromPasteboard):
(WebCore::Editor::pasteWithPasteboard):
(WebCore::Editor::createFragmentAndAddResources):
(WebCore::Editor::createFragmentForImageResourceAndAddResource):

  • platform/Pasteboard.h:
  • platform/PasteboardStrategy.h:
  • platform/PlatformPasteboard.h:
  • platform/ios/PasteboardIOS.mm:

(WebCore::PasteboardWebContent::PasteboardWebContent):
(WebCore::PasteboardWebContent::~PasteboardWebContent):
(WebCore::PasteboardImage::PasteboardImage):
(WebCore::PasteboardImage::~PasteboardImage):
(WebCore::Pasteboard::Pasteboard):
(WebCore::Pasteboard::clear):
(WebCore::Pasteboard::readString):
(WebCore::Pasteboard::writeString):
(WebCore::Pasteboard::types):

  • platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::changeCount):
(WebCore::PlatformPasteboard::write):
(WebCore::PlatformPasteboard::count):
(WebCore::PlatformPasteboard::readBuffer):
(WebCore::PlatformPasteboard::readString):
(WebCore::PlatformPasteboard::readURL):

  • platform/mac/PasteboardMac.mm:

(WebCore::PasteboardWebContent::PasteboardWebContent):
(WebCore::PasteboardWebContent::~PasteboardWebContent):
(WebCore::PasteboardImage::PasteboardImage):
(WebCore::PasteboardImage::~PasteboardImage):

  • platform/mac/PlatformPasteboardMac.mm:

Source/WebKit/mac:

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::writeToPasteboard):
(WebPlatformStrategies::getPasteboardItemsCount):
(WebPlatformStrategies::readBufferFromPasteboard):
(WebPlatformStrategies::readURLFromPasteboard):
(WebPlatformStrategies::readStringFromPasteboard):
(WebPlatformStrategies::changeCount):

Source/WebKit2:

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::decodeSharedBuffer):

  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/WebContext.h:
  • UIProcess/WebContext.messages.in:
  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::writeWebContentToPasteboard):
(WebKit::WebContext::writeImageToPasteboard):
(WebKit::WebContext::writeStringToPasteboard):
(WebKit::WebContext::readStringFromPasteboard):
(WebKit::WebContext::readURLFromPasteboard):
(WebKit::WebContext::readBufferFromPasteboard):
(WebKit::WebContext::getPasteboardItemsCount):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::writeToPasteboard):
(WebKit::WebPlatformStrategies::getPasteboardItemsCount):
(WebKit::WebPlatformStrategies::readBufferFromPasteboard):
(WebKit::WebPlatformStrategies::readURLFromPasteboard):
(WebKit::WebPlatformStrategies::readStringFromPasteboard):
(WebKit::WebPlatformStrategies::changeCount):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
4:19 PM Changeset in webkit [156587] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit/win

[Windows] Unreviewed build fix following r156560.

  • WebView.h:
4:17 PM Changeset in webkit [156586] by hmuller@adobe.com
  • 12 edits
    4 adds in trunk

Crash on shape-outside when using calc()
https://bugs.webkit.org/show_bug.cgi?id=121020

Reviewed by Dirk Schulze.

Source/WebCore:

This change prevents a crash caused by specifying a CSS Shape geometry
Length attribute with a calc() expression. It adds support for converting
Lengths to CSSPrimitive Values, in large part by migrating Blink changes
made to the calc classes since the split. Doing so required a few supporting
changes in some related classes, notably CSSPrimitiveValue.

Tests: fast/shapes/shape-inside/shape-inside-calc-crash.html

css3/calc/simplification.html

  • css/BasicShapeFunctions.cpp:

(WebCore::convertToCSSPrimitiveValue): Effectively use the new CSSPrimtiveValue(length,style) constructor to convert Lengths to CSSValues.
(WebCore::valueForBasicShape): Use the convertToCSSPrimitiveValue() function.
(WebCore::convertToLength): Added the CalculatedConversion convertToLength() flag to enable support for calc() valued Length Shape attributes.

  • css/BasicShapeFunctions.h:
  • css/CSSCalculationValue.cpp:

(WebCore::hasDoubleValue):
(WebCore::buildCssText):
(WebCore::CSSCalcValue::clampToPermittedRange):
(WebCore::CSSCalcValue::doubleValue):
(WebCore::CSSCalcExpressionNode::~CSSCalcExpressionNode):
(WebCore::CSSCalcPrimitiveValue::create):
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(WebCore::CSSCalcPrimitiveValue::doubleValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(WebCore::CSSCalcPrimitiveValue::primitiveType):
(WebCore::CSSCalcPrimitiveValue::CSSCalcPrimitiveValue):
(WebCore::determineCategory):
(WebCore::isIntegerResult):
(WebCore::CSSCalcBinaryOperation::create):
(WebCore::CSSCalcBinaryOperation::createSimplified):
(WebCore::CSSCalcBinaryOperation::doubleValue):
(WebCore::CSSCalcBinaryOperation::buildCssText):
(WebCore::CSSCalcBinaryOperation::primitiveType):
(WebCore::CSSCalcBinaryOperation::CSSCalcBinaryOperation):
(WebCore::CSSCalcBinaryOperation::getNumberSide):
(WebCore::CSSCalcBinaryOperation::evaluate):
(WebCore::CSSCalcBinaryOperation::evaluateOperator):
(WebCore::CSSCalcExpressionNodeParser::parseValue):
(WebCore::CSSCalcExpressionNodeParser::parseValueTerm):
(WebCore::CSSCalcExpressionNodeParser::parseValueMultiplicativeExpression):
(WebCore::CSSCalcExpressionNodeParser::parseAdditiveValueExpression):
(WebCore::CSSCalcValue::createExpressionNode):
(WebCore::CSSCalcValue::create):

  • css/CSSCalculationValue.h:

(WebCore::CSSCalcExpressionNode::category):
(WebCore::CSSCalcValue::create):
(WebCore::CSSCalcValue::isInt):
(WebCore::CSSCalcValue::permittedValueRange):
(WebCore::CSSCalcValue::expressionNode):
(WebCore::CSSCalcValue::CSSCalcValue):
(WebCore::toCSSCalcValue):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue): Pass the style along to the new valueForBasicShape() function.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::unitCategory): Made this function public so that CSSCalculationValue could use it.
(WebCore::CSSPrimitiveValue::conversionToCanonicalUnitsScaleFactor): Ditto.
(WebCore::CSSPrimitiveValue::primitiveType): Cleared trailing whitespace.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Construct a CSSPrimitiveValue from a Length and a RenderStyle*.
(WebCore::CSSPrimitiveValue::init): The common part of the two Length CSSPrimitiveValue constructors.
(WebCore::CSSPrimitiveValue::computeLengthDouble): Moved the case labels to the left per check-webkit-style.
(WebCore::CSSPrimitiveValue::getStringValue): Ditto.
(WebCore::CSSPrimitiveValue::getDoubleValue): Removed trailing whitespace.

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::create): Construct a CSSPrimitiveValue from a Length and a RenderStyle*.
(WebCore::toCSSPrimitiveValue): Check the CSSValue*'s validity with ASSERT_WITH_SECURITY_IMPLICATION before casting to CSSPrimitiveValue*.

  • css/CSSValuePool.h:

(WebCore::CSSValuePool::createValue): A new overload that delegates to the new CSSPrimitiveValue(length,style) constructor.

  • platform/CalculationValue.h:

(WebCore::CalculationValue::operator==):
(WebCore::CalculationValue::isNonNegative):
(WebCore::CalculationValue::expression):
(WebCore::CalcExpressionNumber::value):
(WebCore::toCalcExpressionNumber):
(WebCore::CalcExpressionLength::CalcExpressionLength):
(WebCore::CalcExpressionLength::length):
(WebCore::toCalcExpressionLength):
(WebCore::CalcExpressionBinaryOperation::leftSide):
(WebCore::CalcExpressionBinaryOperation::rightSide):
(WebCore::CalcExpressionBinaryOperation::getOperator):
(WebCore::toCalcExpressionBinaryOperation):
(WebCore::CalcExpressionBlendLength::CalcExpressionBlendLength):
(WebCore::CalcExpressionBlendLength::from):
(WebCore::CalcExpressionBlendLength::to):
(WebCore::CalcExpressionBlendLength::progress):
(WebCore::toCalcExpressionBlendLength):

LayoutTests:

Specifying a CSS Shape geometry Length attribute with a calc() expression
or looking up the value with getComputedStyle(), caused crashes.

  • fast/shapes/shape-inside/shape-inside-calc-crash-expected.txt: Added.
  • fast/shapes/shape-inside/shape-inside-calc-crash.html: Added.
  • css3/calc/simplification-expected.txt: Added
  • css3/calc/simplification.html: Added
  • LayoutTests/css3/calc/cssom-expected.txt:
4:09 PM Changeset in webkit [156585] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test animations/combo-transform-translate+scale.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122040

  • platform/mac/TestExpectations: Marking as such.
4:05 PM Changeset in webkit [156584] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test media/track/track-cue-overlap-snap-to-lines-not-set.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122039

  • platform/mac/TestExpectations: Marking as such.
4:01 PM Changeset in webkit [156583] by ap@apple.com
  • 2 edits in trunk/LayoutTests

animations/transform-non-accelerated.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122038

  • platform/mac/TestExpectations: Marking as such.
3:34 PM Changeset in webkit [156582] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r154219): 30% more malloc memory used on html5-full-render.
<https://webkit.org/b/122034>

Reviewed by Antti Koivisto.

canExecuteScripts() used to rely on Frame::settings() returning null
when the Frame was disconnected from its Page, and giving Frame its
own handle on the Settings broke this mechanism.

This caused us to hold on for some objects for a bit longer than we
needed to in the run-perf-tests harness, showing up as a massive 30%
regression in malloc memory use.

Fixed it by added an explicit null check of Frame::page().

3:24 PM Changeset in webkit [156581] by alex.christensen@flexsim.com
  • 2 edits in trunk/Source/WebKit

[Windows] Unreviewed build fix.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Fixed linker symbols I broke last time.

3:14 PM Changeset in webkit [156580] by ap@apple.com
  • 22 edits in trunk/Source/WebCore

Updating bindings test results after KURL->URL rename.

Includes were now in the wrong order.

  • bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.cpp:
  • bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp:
  • bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp:
  • bindings/scripts/test/CPP/WebDOMTestEventTarget.cpp:
  • bindings/scripts/test/CPP/WebDOMTestException.cpp:
  • bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp:
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:
  • bindings/scripts/test/JS/JSTestException.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestTypedefs.cpp:
  • bindings/scripts/test/ObjC/DOMTestActiveDOMObject.mm:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm:
  • bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.mm:
  • bindings/scripts/test/ObjC/DOMTestEventConstructor.mm:
  • bindings/scripts/test/ObjC/DOMTestEventTarget.mm:
  • bindings/scripts/test/ObjC/DOMTestException.mm:
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/ObjC/DOMTestTypedefs.mm:
3:05 PM Changeset in webkit [156579] by Lucas Forschler
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg

Add supporting logic for r156570.

3:01 PM Changeset in webkit [156578] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r156569.
http://trac.webkit.org/changeset/156569
https://bugs.webkit.org/show_bug.cgi?id=122035

broke a lot of mismatch tests (Requested by thorton on
#webkit).

Tools:

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):

LayoutTests:

  • platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Removed.
  • platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Removed.
2:54 PM Changeset in webkit [156577] by alex.christensen@flexsim.com
  • 2 edits in trunk/Source/WebKit

[Windows] Unreviewed build fix for Win64.

Patch by Alex Christensen <alex.christensen@flexsim.com> on 2013-09-27

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Added and fixed 64-bit linker symbols.

2:52 PM Changeset in webkit [156576] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test media/video-duration-known-after-eos.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122033

  • platform/mac/TestExpectations: Marked as such.
2:29 PM Changeset in webkit [156575] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Get MediaStreamCenterGStreamer compiling again
https://bugs.webkit.org/show_bug.cgi?id=122029

After MediaStream cleanup commit, it was not building anymore.

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-09-27
Reviewed by Eric Carlson.

No new tests needed.

  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
2:18 PM Changeset in webkit [156574] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Storing a reference to MediaStreamTrack in RTCStatsRequest
https://bugs.webkit.org/show_bug.cgi?id=122030

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-09-27
Reviewed by Eric Carlson.

The spec[1] says that the stats is related to a MediaStreamTrack object.
It also says: "Evaluate the need for other selectors than MediaStreamTrack".
So a MediaStreamTrack object is more suitable in this case.

[1]http://dev.w3.org/2011/webrtc/editor/webrtc.html#stats-selector

No new tests needed.

  • Modules/mediastream/RTCStatsRequestImpl.cpp:

(WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl):
(WebCore::RTCStatsRequestImpl::hasSelector):
(WebCore::RTCStatsRequestImpl::track):

  • Modules/mediastream/RTCStatsRequestImpl.h:
  • platform/mediastream/RTCStatsRequest.h:
2:15 PM Changeset in webkit [156573] by ap@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION(r156546): 18 media tests broken
https://bugs.webkit.org/show_bug.cgi?id=122021

  • platform/mac/TestExpectations: Adding one more test, media/track/track-cue-rendering-vertical.html
2:11 PM Changeset in webkit [156572] by ap@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] Intermittent crash on media/video-controls-captions-trackmenu.html
https://bugs.webkit.org/show_bug.cgi?id=110173

This code got rewritten, and the test now just fails. Fixing and re-enabling it
is tracked in a different bug.

  • platform/mac/TestExpectations: Removing superfluous entry which was confusing the parser.
1:48 PM Changeset in webkit [156571] by ap@apple.com
  • 2 edits in trunk/Tools

Don't retry failures on Apple MountainLion Release WK1 tester
https://bugs.webkit.org/show_bug.cgi?id=122026

Reviewed by Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures

on this bot.

1:47 PM Changeset in webkit [156570] by ap@apple.com
  • 3 edits in trunk/Tools

Don't hardcode builder specific configuration in buildbot master.cfg
https://bugs.webkit.org/show_bug.cgi?id=122023

Reviewed by Mark Rowe.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments

property to Qt Mountain Lion Release, making it run pixel tests.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitTests.start): Use additionalArguments.
(RunWebKit2Tests.start): Don't hardcode individual bot behavior here.

1:47 PM Changeset in webkit [156569] by timothy_horton@apple.com
  • 3 edits
    2 adds in trunk

[wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
https://bugs.webkit.org/show_bug.cgi?id=122006
<rdar://problem/15095197>

Reviewed by Dean Jackson.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):
Layer-back the root view in WebKitTestRunner's window, to work around a bug
where the window server snapshot API returns blank snapshots.

Add a test that ensures that WebKitTestRunner's snapshots are not
completely blank with tiled drawing enabled.

  • platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Added.
  • platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Added.
1:44 PM Changeset in webkit [156568] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test fast/animation/request-animation-frame-time-unit.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122031

  • platform/mac/TestExpectations: Marking as such. Dean is going to look into

related issues soon.

1:25 PM Changeset in webkit [156567] by commit-queue@webkit.org
  • 12 edits in trunk/Source

[Nix] Updating Nix trunk files
https://bugs.webkit.org/show_bug.cgi?id=121752

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-09-27
Reviewed by Benjamin Poulain.

Source/WebCore:

No new tests needed.

  • page/nix/EventHandlerNix.cpp:

(WebCore::EventHandler::focusDocumentView):
(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):

  • platform/DragImage.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/nix/DragImageNix.cpp:

(WebCore::createDragImageFromImage):

  • platform/nix/GamepadsNix.cpp:

(WebCore::sampleGamepads):

  • platform/nix/LanguageNix.cpp:

(WebCore::platformLanguage):

  • platform/nix/LocalizedStringsNix.cpp:

(WebCore::unacceptableTLSCertificate):

  • platform/nix/PasteboardNix.cpp:

(WebCore::Pasteboard::types):

  • platform/nix/RenderThemeNix.cpp:

(WebCore::toColor):
(WebCore::themeEngine):
(WebCore::webCanvas):
(WebCore::getWebThemeState):
(WebCore::RenderThemeNix::paintButton):
(WebCore::RenderThemeNix::paintTextField):
(WebCore::RenderThemeNix::paintCheckbox):
(WebCore::RenderThemeNix::paintRadio):
(WebCore::RenderThemeNix::paintMenuList):
(WebCore::RenderThemeNix::paintProgressBar):
(WebCore::RenderThemeNix::paintInnerSpinButton):
(WebCore::RenderThemeNix::paintMeter):

Source/WTF:

  • wtf/nix/FeatureDefinesNix.h:
1:06 PM Changeset in webkit [156566] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WK2][CoordinatedGraphics] fix build after r156560
https://bugs.webkit.org/show_bug.cgi?id=122028

Fixing build.

Patch by Ralph Thomas <ralpht@gmail.com> on 2013-09-27
Reviewed by Anders Carlsson.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::paintLayerContents):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
12:22 PM Changeset in webkit [156565] by timothy@apple.com
  • 2 edits in trunk/Source/WebKit/win

Attempt to fix Windows build.

11:49 AM Changeset in webkit [156564] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Deoptimize 32-bit deoptimization
https://bugs.webkit.org/show_bug.cgi?id=122025

Reviewed by Oliver Hunt.

Just simplifying a bunch of code. I don't want the old, super-complicated,
deoptimization code to get in the way of changes I'll be making to DFG stack layout.

  • bytecode/ValueRecovery.h:

(JSC::ValueRecovery::inGPR):
(JSC::ValueRecovery::isInRegisters):
(JSC::ValueRecovery::gpr):
(JSC::ValueRecovery::dumpInContext):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

11:48 AM Changeset in webkit [156563] by Lucas Forschler
  • 5 edits in branches/safari-537.60-branch/Source

Versioning.

11:46 AM Changeset in webkit [156562] by Lucas Forschler
  • 1 copy in tags/Safari-537.60.3

New Tag.

11:41 AM Changeset in webkit [156561] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION(r156546): 17 media tests broken
https://bugs.webkit.org/show_bug.cgi?id=122021

Unreviewed gardening; add failing tests to TestExpectations while triaging new failures.

  • platform/mac/TestExpectations:
11:38 AM Changeset in webkit [156560] by andersca@apple.com
  • 27 edits in trunk/Source

Use std::unique_ptr for GraphicsLayer creation
https://bugs.webkit.org/show_bug.cgi?id=122020

Reviewed by Antti Koivisto.

Source/WebCore:

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/GraphicsLayerFactory.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayer::create):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:

(WebCore::CompositingCoordinator::createGraphicsLayer):

  • platform/graphics/texmap/coordinated/CompositingCoordinator.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::createGraphicsLayer):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::paintIntoLayer):

  • rendering/RenderLayerBacking.h:

(WebCore::RenderLayerBacking::hasScrollingLayer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateRootLayerPosition):

  • rendering/RenderLayerCompositor.h:

Source/WebKit2:

  • UIProcess/mac/RemoteLayerTreeHost.h:
  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::getOrCreateLayer):

  • WebProcess/WebPage/mac/LayerTreeHostMac.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm:

(WebKit::LayerTreeHostMac::paintContents):
(WebKit::LayerTreeHostMac::createPageOverlayLayer):
(WebKit::LayerTreeHostMac::destroyPageOverlayLayer):

  • WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
  • WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
  • WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::createGraphicsLayer):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::paintContents):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::destroyPageOverlayLayer):

11:36 AM Changeset in webkit [156559] by alex.christensen@flexsim.com
  • 2 edits in trunk/Source/JavaScriptCore

Fixed Win64 build after r156184.
https://bugs.webkit.org/show_bug.cgi?id=121994

Reviewed by Oliver Hunt.

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupTwoStubArgsGPR):
(JSC::CCallHelpers::setupTwoStubArgsFPR):
Renamed from setupTwoStubArgs.
Visual Studio x64 compiler fails to see that this is an overloaded template function.
(JSC::CCallHelpers::setupStubArguments):
(JSC::CCallHelpers::setupArguments):
(JSC::CCallHelpers::setupArgumentsWithExecState):
Use setupTwoStubArgsGPR or setupTwoStubArgsFPR instead of setupTwoStubArgs.

11:34 AM Changeset in webkit [156558] by Beth Dakin
  • 23 edits in trunk/Source

ScrollbarPainterController should adopt the api to lock overlay scrollbar state
https://bugs.webkit.org/show_bug.cgi?id=121928

Reviewed by Sam Weinig.

Source/WebCore:

ScrollbarPainterController should adopt the api to lock overlay scrollbar state.
This will allow the ScrollbarPainterController and ScrollAnimatorMac to have
control over knowing whether or not the scrollbars are currently active, which
will allow us to remove a bunch of functions previously implemented in
ScrollableArea subclasses to answer that question.

ScrollableArea::scrollbarsCanBeActive() is not longer virtual. It used to
implemented on ScrollableArea subclasses, but now ScrollableArea can just get the
information from the ScrollAnimator.

  • WebCore.exp.in:

When ScrollableArea subclasses implemented scrollbarsCanBeActive(), they would
check to see if the document was in the page cache. Instead of that model, this
patch adopts a model where ScrollbarPainterController is told directly whether or
not it is active via shouldLockOverlayScrollbarsToHidden(bool).

  • dom/Document.cpp:

(WebCore::Document::setInPageCache):

setAnimatorsAreActive() is no longer necessary. The functionality can be bundled
into shouldLockOverlayScrollbarsToHidden(bool).
(WebCore::Document::documentDidResumeFromPageCache):

Remove implementations of scrollbarsCanBeActive(), setAnimatorsAreActive(), and
scrollbarAnimationsAreSuppressed().

  • page/FrameView.cpp:

(WebCore::FrameView::notifyPageThatContentAreaWillPaint):

  • page/FrameView.h:

setShouldSuppressScrollbarAnimations(bool) now calls
setShouldLockOverlayScrollbars(bool).

  • page/Page.cpp:

(WebCore::Page::setShouldSuppressScrollbarAnimations):
(WebCore::Page::setShouldLockOverlayScrollbars):

  • page/Page.h:

setIsActive() is now implemented in the ScrollAnimator instead of ScrollableArea
subclasses. finishCurrentScrollAnimations() is replaced by
lockOverlayScrollbarStateToHidden(bool).

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::lockOverlayScrollbarStateToHidden):
(WebCore::ScrollAnimator::scrollbarsCanBeActive):

New enum ScrollbarOverlayState.

  • platform/ScrollTypes.h:

Go to the animator for both of these functions.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::lockOverlayScrollbarStateToHidden):
(WebCore::ScrollableArea::scrollbarsCanBeActive):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::setVisibleScrollerThumbRect):

Three new pieces of ScrollbarPainterController api.

  • platform/mac/NSScrollerImpDetails.h:

Instead of asking the ScrollableArea if scrollbars can be active, just find out if
the ScrollbarPaintController has been locked.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterControllerDelegate scrollerImpPair:setContentAreaNeedsDisplayInRect:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::mayBeginScrollGesture):
(WebCore::ScrollAnimatorMac::lockOverlayScrollbarStateToHidden):
(WebCore::ScrollAnimatorMac::scrollbarsCanBeActive):
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):

Remove implementations of scrollbarsCanBeActive() and
scrollbarAnimationsAreSuppressed().

  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp:
  • rendering/RenderListBox.h:

Source/WebKit2:

This function no longer needs to be implemented by ScrollablArea subclasses.

  • WebProcess/Plugins/PDF/PDFPlugin.h:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:
11:22 AM Changeset in webkit [156557] by hyatt@apple.com
  • 9 edits in trunk/Source/WebCore

Move line grid functionality from RenderBlock into RenderBlockFlow.
https://bugs.webkit.org/show_bug.cgi?id=121502

Reviewed by Dean Jackson.

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::establishLineGrid):

  • rendering/LayoutState.h:

(WebCore::LayoutState::lineGrid):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::willBeDestroyed):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::willBeDestroyed):
(WebCore::RenderBlockFlow::layoutLineGridBox):

  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData):
(WebCore::RenderBlockFlow::lineGridBox):
(WebCore::RenderBlockFlow::setLineGridBox):

  • rendering/RenderBlockLineLayout.cpp:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::lineSnapAdjustment):

10:52 AM Changeset in webkit [156556] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Re-indent Settings.h

Rubber-stamped by Anders Carlsson.

10:42 AM Changeset in webkit [156555] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Web Inspector: Make WebKitGTK+ port work with Eclipse chromedevtools plugin
https://bugs.webkit.org/show_bug.cgi?id=121121

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-09-27
Reviewed by Gustavo Noronha Silva.

The chromedevtools plugin (http://code.google.com/p/chromedevtools/) requires a specific
json format to connect to the webkit inspector.

The current format is missing some required fields that make the connection with the plugin
fail.

The format expected by the plugin is as follows:

{

"title": "Foo",
"url": "http://foo",
"devtoolsFrontendUrl": "/Main.html?ws=localhost:9222/devtools/page/1",
"webSocketDebuggerUrl": "ws://localhost:9222/devtools/page/1"

}

The current format is missing the entries for "devtoolsFrontendUrl" and
"webSocketDebuggerUrl".

The plugin also sends an HTTP GET request to http://host:port/json instead of
http://host:port/pagelist.json when retrieving the pages list.

This patch fixes the issues by adding support for the missing fields and accepting requests
for "/json" alongside "/pagelist.json".

  • UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:

(WebKit::WebInspectorServer::platformResourceForPath):
Also accept requests for "/json" alongside "pagelist.json".
(WebKit::WebInspectorServer::buildPageList):
Add fields required by chromedevtools plugin.

10:40 AM Changeset in webkit [156554] by eric.carlson@apple.com
  • 9 edits in trunk

[MediaStream API] update SourceInfo object to match spec
https://bugs.webkit.org/show_bug.cgi?id=121941

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, existing test updated.

  • Modules/mediastream/SourceInfo.cpp:

(WebCore::SourceInfo::kind): Get rid of "none".

  • Modules/mediastream/SourceInfo.h:

(WebCore::SourceInfo::sourceId): Renamed from "id".

  • Modules/mediastream/SourceInfo.idl:
  • platform/mediastream/MediaStreamTrackSourcesRequestClient.h:

(WebCore::TrackSourceInfo::create):
(WebCore::TrackSourceInfo::kind):
(WebCore::TrackSourceInfo::TrackSourceInfo):

  • platform/mock/MockMediaStreamCenter.cpp:

(WebCore::MockMediaStreamCenter::getMediaStreamTrackSources): "facing" isn't a part of sourceInfo.

Return a non-NULL ID because a source must always have one.

LayoutTests:

  • fast/mediastream/MediaStreamTrack-getSources-expected.txt:
  • fast/mediastream/MediaStreamTrack-getSources.html:
10:26 AM Changeset in webkit [156553] by dino@apple.com
  • 9 edits in trunk

Provide 2D Matrix decomposition for animation
https://bugs.webkit.org/show_bug.cgi?id=112824
<rdar://problem/15091882>

Reviewed by Eric Carlson (and Ian Henderson offline).

Source/WebCore:

Implement a new 2d matrix blend, which is triggered
when animating between two affine 3d matrices. This
is intended to be the official algorithm that gets
put into the W3C Transforms specification.

The old code is renamed with a 4 prefix (indicating
it is a blend between 3d matrices using quaternions),
and new methods and structures for 2d blending were added.

I also took the opportunity to clean up a lot of
bad WebKit style.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::maxScaleFromTransform): Use 3d decomposition.

  • platform/graphics/transforms/PerspectiveTransformOperation.cpp:

(WebCore::PerspectiveTransformOperation::blend): Ditto.

  • platform/graphics/transforms/RotateTransformOperation.cpp:

(WebCore::RotateTransformOperation::blend): Ditto.

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::decompose2): New method to decompose an affine 3d matrix
into X/Y scale + translate, a rotation angle, plus some extracted
a,b,c,d fields from the affine section.
(WebCore::decompose4): New name for the old function.
(WebCore::TransformationMatrix::blend2): Perform linear interpolation
between two 2d decompositions.
(WebCore::TransformationMatrix::blend4): New name for the old function.
(WebCore::TransformationMatrix::blend): Call blend2 or blend4 depending
on the type of matrix.
(WebCore::TransformationMatrix::decompose2): Calls into the decompose2
method above.
(WebCore::TransformationMatrix::decompose4): New name.
(WebCore::TransformationMatrix::recompose2): Recomposes a 3d matrix from
a 2d decomposition.
(WebCore::TransformationMatrix::recompose4): New name.

  • platform/graphics/transforms/TransformationMatrix.h: All the changes

for the new methods above.

LayoutTests:

This test was only exercising the fact that our
software decomposition did not match our hardware
decomposition (although that required visual inspection).
Now that our 2d decomposition is correct, update the
test and its expected result.

  • animations/transform-non-accelerated-expected.txt:
  • animations/transform-non-accelerated.html:
10:24 AM Changeset in webkit [156552] by timothy@apple.com
  • 1 edit in trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in

Attempt to fix windows build.

9:59 AM Changeset in webkit [156551] by mario@webkit.org
  • 5 edits in trunk

[GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
https://bugs.webkit.org/show_bug.cgi?id=106924

Reviewed by Chris Fleizach.

Tools:

Consider headings levels as values to be returned in intValue()
both in DRT and WKTR, so we can share more tests with other ports.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::intValue): Consider headings too.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::intValue): Ditto.

LayoutTests:

Removed accesibility/heading-level.html from failure expectations.

  • platform/gtk/TestExpectations: Removed test now passing.
9:39 AM Changeset in webkit [156550] by Darin Adler
  • 840 edits
    7 moves in trunk

rename KURL to URL
https://bugs.webkit.org/show_bug.cgi?id=16214

Reviewed by Andreas Kling.

Source/WebCore:

  • many files: Renamed, using script.

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Let the script to try to rename here.

Source/WebKit/blackberry:

  • many files: Renamed, using script.

Source/WebKit/efl:

  • many files: Renamed, using script.

Source/WebKit/gtk:

  • many files: Renamed, using script.

Source/WebKit/mac:

  • many files: Renamed, using script.

Source/WebKit/qt:

  • many files: Renamed, using script.

Source/WebKit/win:

  • many files: Renamed, using script.

Source/WebKit/wince:

  • many files: Renamed, using script.

Source/WebKit2:

  • many files: Renamed, using script.

Tools:

  • many files: Renamed, using script.
9:37 AM Changeset in webkit [156549] by rgabor@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

LLInt alignment problem on ARM in debug mode
https://bugs.webkit.org/show_bug.cgi?id=122012

Reviewed by Michael Saboff.

Force GCC to put the LLInt code to .text section.

  • llint/LowLevelInterpreter.cpp:
9:34 AM Changeset in webkit [156548] by Darin Adler
  • 2 edits in trunk/Tools

Fix Python scripts test failures.

  • Scripts/webkitpy/style/checkers/cpp.py: (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests now, not by the checker itself.
9:12 AM Changeset in webkit [156547] by galpeter@inf.u-szeged.hu
  • 2 edits in trunk/Source/WebKit2

Remove unused method parameters from TupleCoder.
https://bugs.webkit.org/show_bug.cgi?id=122009

Reviewed by Anders Carlsson.

In case of TupleCoder<0, Elements...> the parameter
names for encoder, decoder and tuple are not used.
By removing the paramter names the unusued paramter
warning will disappear.

  • Platform/CoreIPC/Arguments.h:
9:05 AM Changeset in webkit [156546] by jer.noble@apple.com
  • 45 edits
    8 adds
    2 deletes in trunk

[Mac] Implement the media controls in JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=120895

Reviewed by Dean Jackson.

Source/JavaScriptCore:

Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Re-implement the existing MediaControls constellation of classes in JavaScript
and CSS. This will allow different ports to configure their controls without
dependencies on the layout requirements of any other port's controls.

Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT:

  • Configurations/FeatureDefines.xcconfig:

Add new source files to the project:

  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:

Add a new class MediaControlsHost which the script controls can use to
communicate with the HTMLMediaElement without exposing private interfaces
to web facing scripts:

  • Modules/mediacontrols/MediaControlsHost.cpp: Added.

(WebCore::MediaControlsHost::automaticKeyword): Static method.
(WebCore::MediaControlsHost::forcedOnlyKeyword): Ditto.
(WebCore::MediaControlsHost::alwaysOnKeyword): Ditto.
(WebCore::MediaControlsHost::create): Simple factory.
(WebCore::MediaControlsHost::MediaControlsHost): Simple constructor.
(WebCore::MediaControlsHost::~MediaControlsHost): Simple destructor.
(WebCore::MediaControlsHost::sortedTrackListForMenu): Pass through to CaptionUserPreferences.
(WebCore::MediaControlsHost::displayNameForTrack): Ditto.
(WebCore::MediaControlsHost::captionMenuOffItem): Pass through to TextTrack.
(WebCore::MediaControlsHost::captionMenuAutomaticItem): Ditto.
(WebCore::MediaControlsHost::captionDisplayMode): Pass through to CaptionUserPreferences.
(WebCore::MediaControlsHost::setSelectedTextTrack): Pass through to HTMLMediaElement.
(WebCore::MediaControlsHost::textTrackContainer): Lazily create a MediaControlTextTrackContainerElement.
(WebCore::MediaControlsHost::updateTextTrackContainer): Pass through to MediaControlTextTrackContainerElement.

  • Modules/mediacontrols/MediaControlsHost.h: Added.
  • Modules/mediacontrols/MediaControlsHost.idl: Added.
  • Modules/mediacontrols/mediaControlsApple.css: Added.

Add convenience methods for adding a MediaControlsHost to a VM.

  • bindings/js/ScriptObject.cpp:

(WebCore::ScriptGlobalObject::set):

  • bindings/js/ScriptObject.h:

Add the new controller .js implementation:

  • Modules/mediacontrols/mediaControlsApple.js: Added.

(createControls): Global method to create a new Controller object.
(Controller): Constructor. Create and configure the default set of controls.
(Controller.prototype.addListeners): Adds event listeners to the this.video object.
(Controller.prototype.removeListeners): Removes listeners from same.
(Controller.prototype.handleEvent): Makes Controller an EventHandler, making registration and

deregistration simpler.

(Controller.prototype.createBase): Creates the base controls object and the text track container.
(Controller.prototype.createControls): Creates the controls panel object and controller UI.
(Controller.prototype.setControlsType): Switches between Full Screen and Inline style of controller.
(Controller.prototype.disconnectControls): Disconnects all UI elements from the DOM.
(Controller.prototype.configureInlineControls): Configures existing controls for Inline mode.
(Controller.prototype.configureFullScreenControls): Ditto, for Full Screen Mode.

Add listeners for HTMLMediaElement events:
(Controller.prototype.onloadstart): Update the status display.
(Controller.prototype.onerror): Ditto.
(Controller.prototype.onabort): Ditto.
(Controller.prototype.onsuspend): Ditto.
(Controller.prototype.onprogress): Ditto.
(Controller.prototype.onstalled): Ditto.
(Controller.prototype.onwaiting): Ditto.
(Controller.prototype.onreadystatechange): Ditto.
(Controller.prototype.ontimeupdate): Update the timeline and time displays.
(Controller.prototype.ondurationchange): Ditto.
(Controller.prototype.onplaying): Update the play button.
(Controller.prototype.onplay): Ditto.
(Controller.prototype.onpause): Ditto.
(Controller.prototype.onratechange): Ditto.
(Controller.prototype.onvolumechange): Update the volume and mute UI.
(Controller.prototype.ontexttrackchange): Update the text track container and captions button.
(Controller.prototype.ontexttrackadd): Ditto.
(Controller.prototype.ontexttrackremove): Ditto.
(Controller.prototype.ontexttrackcuechange): Ditto.
(Controller.prototype.onfullscreenchange): Reconfigure the controls.

Add listeners for UI element events:
(Controller.prototype.onwrappermousemove): Show the controls and start the hide timer.
(Controller.prototype.onwrappermouseout): Hide the controls and stop the hide timer.
(Controller.prototype.onrewindbuttonclicked): Rewind.
(Controller.prototype.onplaybuttonclicked): Toggle pause.
(Controller.prototype.ontimelinechange): Update the currentTime.
(Controller.prototype.ontimelinedown):
(Controller.prototype.ontimelineup):
(Controller.prototype.ontimelinemouseover): Show the thumbnail view if available.
(Controller.prototype.ontimelinemouseout): Hide same.
(Controller.prototype.ontimelinemousemove): Move the thumbnail view.
(Controller.prototype.onmutebuttonclicked): Mute audio.
(Controller.prototype.onminbuttonclicked): Increase volume to max.
(Controller.prototype.onmaxbuttonclicked): Decrease volume to min.
(Controller.prototype.onvolumesliderchange): Update the current volume.
(Controller.prototype.oncaptionbuttonclicked): Show or hide the track menu.
(Controller.prototype.onfullscreenbuttonclicked): Enter or exit fullscreen.
(Controller.prototype.oncontrolschange): Show or hide the controls panel.
(Controller.prototype.onseekbackmousedown): Start seeking and enable the seek timer.
(Controller.prototype.onseekbackmouseup): Stop seeking and disable the seek timer.
(Controller.prototype.onseekforwardmousedown): Start seekind and enable the seek timer.
(Controller.prototype.onseekforwardmouseup): Stop seekind and disable the seek timer.

Add action methods (which are mostly self explanatory):
(Controller.prototype.updateDuration):
(Controller.prototype.updatePlaying):
(Controller.prototype.showControls):
(Controller.prototype.hideControls):
(Controller.prototype.removeControls):
(Controller.prototype.addControls):
(Controller.prototype.updateTime):
(Controller.prototype.updateReadyState):
(Controller.prototype.setStatusHidden):
(Controller.prototype.updateThumbnailTrack):
(Controller.prototype.updateCaptionButton):
(Controller.prototype.updateCaptionContainer):
(Controller.prototype.buildCaptionMenu):
(Controller.prototype.captionItemSelected):
(Controller.prototype.destroyCaptionMenu):
(Controller.prototype.updateVolume):

Add utility methods:
(Controller.prototype.isFullScreen):
(Controller.prototype.canPlay):
(Controller.prototype.nextRate):
(Controller.prototype.seekBackFaster):
(Controller.prototype.seekForwardFaster):
(Controller.prototype.formatTime):
(Controller.prototype.trackHasThumbnails):

Add the stylesheet for the javascript controls (which are mostly) copied from
the (deleted) mediaControlsQuickTime.css and fullscreenQuickTime.css files:

  • Modules/mediacontrols/mediaControlsApple.css: Added.
  • css/fullscreenQuickTime.css: Removed.
  • css/mediaControlsQuickTime.css: Removed.

Inject new stylesheets into UA sheets:

  • css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

Use the new javascript controls rather than MediaControls:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::childShouldCreateRenderer): Use the javascript controls if available.
(WebCore::HTMLMediaElement::updateTextTrackDisplay): Ditto.
(WebCore::HTMLMediaElement::mediaControls): Ditto.
(WebCore::HTMLMediaElement::hasMediaControls): Ditto.
(WebCore::HTMLMediaElement::createMediaControls): Ditto.
(WebCore::HTMLMediaElement::configureMediaControls): Ditto.
(WebCore::HTMLMediaElement::configureTextTrackDisplay): Ditto.
(WebCore::HTMLMediaElement::ensureIsolatedWorld): Create a new VM for the controls script.
(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript): Inject the media controls script into the VM.
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot): Inject the MediaControlsHost into the VM and call

the scripts global factory function.

  • html/HTMLMediaElement.h:

Remove most of the drawing code from RenderThemeMac and RenderThemeWin and
add accessors for the new .js and .css file data:

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::mediaControlsStyleSheet): Empty virtual method.
(WebCore::RenderTheme::mediaControlsScript): Ditto.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::mediaControlsStyleSheet): Add accessor for mediaControlsApple.css.
(WebCore::RenderThemeMac::mediaControlsScript): Add accessor for mediaControlsApple.js.
(WebCore::RenderThemeMac::adjustSliderThumbSize): Remove the call to adjustMediaSliderThumbSize.

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::mediaControlsStyleSheet):
(WebCore::RenderThemeWin::mediaControlsScript):

  • rendering/RenderThemeWin.h:

Source/WebKit/mac:

Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT.

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

Define and turn on ENABLE_MEDIA_CONTROLS_SCRIPT.

  • wtf/FeatureDefines.h:

LayoutTests:

Rebaseline changed tests and add new (failing) tests to
TestExpectations.

  • media/audio-delete-while-slider-thumb-clicked.html:
  • platform/mac/TestExpectations:
  • platform/mac/fast/hidpi/video-controls-in-hidpi-expected.png:
  • platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
  • platform/mac/fast/layers/video-layer-expected.png:
  • platform/mac/fast/layers/video-layer-expected.txt:
  • platform/mac/fullscreen/video-controls-override-expected.txt: Added.
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.png:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-strict-expected.png:
  • platform/mac/media/controls-strict-expected.txt:
  • platform/mac/media/controls-styling-strict-expected.png:
  • platform/mac/media/controls-styling-strict-expected.txt:
  • platform/mac/media/controls-without-preload-expected.png:
  • platform/mac/media/controls-without-preload-expected.txt:
  • platform/mac/media/media-controls-clone-expected.png:
  • platform/mac/media/media-controls-clone-expected.txt:
  • webarchive/loading/video-in-webarchive-expected.txt:
8:55 AM Changeset in webkit [156545] by Bem Jones-Bey
  • 7 edits
    2 adds in trunk

[css-shapes] Shapes are not resolved the same way in shape-inside and clip-path
https://bugs.webkit.org/show_bug.cgi?id=121922

Reviewed by Andreas Kling.

Source/WebCore:

Fix computation of a percentage radius for circle shape-outside to
match the CSS Shapes spec.

Test: csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-001.html

  • rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape):

LayoutTests:

Add new test for circular shape-outside with percentage radius.

Update the nested container with unresolved height test because with a
circle it isn't really testing just for unresolved height behavior.

  • csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-001-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-001.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
  • fast/shapes/shape-inside/shape-inside-on-nested-container-with-unresolved-height-expected.html:
  • fast/shapes/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html:
8:34 AM Changeset in webkit [156544] by akling@apple.com
  • 2 edits in trunk/LayoutTests

Unrehued mac-lion rebaseline.

  • platform/mac-lion/js/dom/global-constructors-attributes-expected.txt:
8:09 AM Changeset in webkit [156543] by Darin Adler
  • 119 edits
    2 adds in trunk

Add empty MainFrame class
https://bugs.webkit.org/show_bug.cgi?id=121770

Reviewed by Andreas Kling.

Source/WebCore:

For now, MainFrame simply derives from Frame and adds nothing.
Next, we will make each Frame point back to its MainFrame.

  • CMakeLists.txt: Added MainFrame.cpp/h.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.exp.in: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • page/Frame.cpp:

(WebCore::Frame::Frame): Use references instead of pointers for constructor.
(WebCore::Frame::create): Pass references instead of pointers to constructor.

  • page/Frame.h: Made constructor protected instead of private, and marked

destructor virtual explicitly. Also marked virtual functions OVERRIDE and FINAL.

  • page/MainFrame.cpp: Added.
  • page/MainFrame.h: Added.
  • page/Page.cpp:

(WebCore::Page::Page): Use MainFrame::create instead of Frame::create.
(WebCore::Page::frameIsMainFrame): Moved here, no longer inline.
(WebCore::Page::renderTreeSize): Use const Frame* instead of Frame*.
(WebCore::Page::checkSubframeCountConsistency): Ditto.

  • page/Page.h: Changed mainFrame() to return MainFrame& and m_mainFrame to

be a RefPtr<MainFrame>.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
  • bindings/js/PageScriptDebugServer.cpp:
  • bindings/js/ScriptProfiler.cpp:
  • bindings/js/ScriptState.cpp:
  • css/MediaQueryEvaluator.cpp:
  • dom/Document.cpp:
  • history/CachedFrame.cpp:
  • history/CachedPage.cpp:
  • history/PageCache.cpp:
  • html/HTMLPlugInImageElement.cpp:
  • inspector/InspectorAgent.cpp:
  • inspector/InspectorCanvasAgent.cpp:
  • inspector/InspectorClient.cpp:
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorFrontendClientLocal.cpp:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorInputAgent.cpp:
  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorOverlay.cpp:
  • inspector/InspectorPageAgent.cpp:
  • inspector/PageRuntimeAgent.cpp:
  • loader/FrameLoader.cpp:
  • loader/HistoryController.cpp:
  • loader/archive/mhtml/MHTMLArchive.cpp:
  • page/AutoscrollController.cpp:
  • page/Chrome.cpp:
  • page/ContextMenuController.cpp:
  • page/DOMWindow.cpp:
  • page/DragController.cpp:
  • page/EventHandler.cpp:
  • page/FocusController.cpp:
  • page/FrameTree.cpp:
  • page/FrameView.cpp:
  • page/GestureTapHighlighter.cpp:
  • page/PageGroup.cpp:
  • page/PageGroupLoadDeferrer.cpp:
  • page/PageSerializer.cpp:
  • page/PageThrottler.cpp:
  • page/Settings.cpp:
  • page/SpatialNavigation.cpp:
  • page/mac/DragControllerMac.mm:
  • page/mac/PageMac.cpp:
  • page/scrolling/ScrollingCoordinator.cpp:
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:
  • platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
  • plugins/DOMMimeType.cpp:
  • storage/StorageEventDispatcher.cpp:
  • svg/graphics/SVGImage.cpp:
  • testing/InternalSettings.cpp:
  • testing/Internals.cpp:

Include MainFrame.h instead of Frame.h as needed.

Source/WebKit/efl:

  • WebCoreSupport/AcceleratedCompositingContextEfl.cpp:
  • WebCoreSupport/InspectorClientEfl.cpp:
  • ewk/ewk_view.cpp:

Include MainFrame.h instead of Frame.h as needed.

Source/WebKit/gtk:

  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:
  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • WebCoreSupport/GtkAdjustmentWatcher.cpp:
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebview.cpp:
  • webkit/webkitviewportattributes.cpp:

Include MainFrame.h instead of Frame.h as needed.

Source/WebKit/mac:

  • WebCoreSupport/WebDragClient.mm:
  • WebCoreSupport/WebInspectorClient.mm:
  • WebCoreSupport/WebPlatformStrategies.mm:
  • WebView/WebFrame.mm:
  • WebView/WebHTMLView.mm:
  • WebView/WebView.mm:

Include MainFrame.h instead of Frame.h as needed.

Source/WebKit/qt:

  • Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:
  • Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:
  • Source/WebKit/qt/WebCoreSupport/QWebFrameAdapter.cpp:
  • Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:
  • Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp:

Include MainFrame.h instead of Frame.h as needed.

Source/WebKit/win:

  • win/WebCoreSupport/WebDragClient.cpp:
  • win/WebCoreSupport/WebContextMenuClient.cpp:
  • win/WebDropSource.cpp:
  • win/WebFrame.cpp:
  • win/WebView.cpp:

Include MainFrame.h instead of Frame.h as needed.

Source/WebKit2:

  • WebProcess/FullScreen/WebFullScreenManager.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/Plugins/PluginView.cpp:
  • WebProcess/Storage/StorageAreaMap.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
  • WebProcess/WebPage/FindController.cpp:
  • WebProcess/WebPage/PageOverlay.cpp:
  • WebProcess/WebPage/WebInspector.cpp:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:
  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm:
  • WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
  • WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
  • WebProcess/WebPage/mac/WebPageMac.mm:

Include MainFrame.h instead of Frame.h as needed.

7:31 AM Changeset in webkit [156542] by gyuyoung.kim@samsung.com
  • 10 edits in trunk/Source/WebCore

Add toWebKitCSS*Value functions to cast from CSSValue
https://bugs.webkit.org/show_bug.cgi?id=121776

Reviewed by Andreas Kling.

CSS_VALUE_TYPE_CASTS can't cover WebKitCSS*Value classes. So, this patch adds toWebKitCSS*Value manually.

No new tests, no behavior change.

  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):

  • css/TransformFunctions.cpp:

(WebCore::transformsForValue):

  • css/WebKitCSSArrayFunctionValue.h:

(WebCore::toWebKitCSSArrayFunctionValue):

  • css/WebKitCSSFilterValue.h:

(WebCore::toWebKitCSSFilterValue):

  • css/WebKitCSSMatFunctionValue.h:

(WebCore::toWebKitCSSMatFunctionValue):

  • css/WebKitCSSMixFunctionValue.h:

(WebCore::toWebKitCSSMixFunctionValue):

  • css/WebKitCSSSVGDocumentValue.h:

(WebCore::toWebKitCSSSVGDocumentValue):

  • css/WebKitCSSShaderValue.h:

(WebCore::toWebKitCSSShaderValue):

  • css/WebKitCSSTransformValue.h:

(WebCore::toWebKitCSSTransformValue):

6:48 AM Changeset in webkit [156541] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK][WK2] Logging of accessibility events is not disabled between tests
https://bugs.webkit.org/show_bug.cgi?id=121957

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-09-27
Reviewed by Mario Sanchez Prada.

Tools:

Fixed an issue in AccessibilityNotificationHandler where the destructor
was not disconnecting accessibility event callbacks if logging was on.
The decision of disconnecting events can solely rely on the existence of
notification handlers because logging uses the global notification
handler.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:

(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
disconnection when logging is on.

LayoutTests:

Removed some accessibility tests from the expectations file that were
failing before this fix.

  • platform/gtk-wk2/TestExpectations:
6:40 AM Changeset in webkit [156540] by akling@apple.com
  • 7 edits in trunk/Source

Pass VM instead of ExecState to JSDateMath functions.
<https://webkit.org/b/121997>

Reviewed by Geoffrey Garen.

The JSC date math functions only need the VM, so pass that from
callers instead of the whole ExecState.

6:31 AM Changeset in webkit [156539] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] editing/selection/fake-doubleclick.html rebaseline after r140111
https://bugs.webkit.org/show_bug.cgi?id=121831

Unreviewed EFL gardening.

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-09-27

  • platform/efl-wk2/TestExpectations:
  • platform/efl/editing/selection/fake-doubleclick-expected.txt:
6:01 AM Changeset in webkit [156538] by Patrick Gansterer
  • 2 edits
    2 adds
    1 delete in trunk/Tools

Add general CMakeLists.txt for DRT
https://bugs.webkit.org/show_bug.cgi?id=119268

Reviewed by Gyuyoung Kim.

The new file allows better sharing between ports.

  • CMakeLists.txt:
  • DumpRenderTree/CMakeLists.txt: Added.
  • DumpRenderTree/PlatformEfl.cmake: Added.
  • DumpRenderTree/efl/CMakeLists.txt: Removed.
5:58 AM Changeset in webkit [156537] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.2.0

Tagging the WebKitGTK+ 2.2.0 release

5:47 AM Changeset in webkit [156536] by Alan Bujtas
  • 5 edits
    2 adds in trunk

Unexpected word wrapping for wrapped content then raw content.
https://bugs.webkit.org/show_bug.cgi?id=121130

Reviewed by Darin Adler.

When deciding whether a line is considered empty, we need to check if the current
object is fully responsible for the currently uncommitted width. It helps differentiating
<span></span><span>abcd</span> from <span>a</span><span>bcd</span>, where in the first
case when we hit the second <span> the line is still considered empty, as opposed to the
second example.
This patch introduces a map to keep track of the uncommitted widths.

Source/WebCore:

Test: fast/css/unexpected-word-wrapping-with-non-empty-spans.html

  • rendering/LineWidth.cpp:

(WebCore::LineWidth::uncommittedWidthForObject):
(WebCore::LineWidth::addUncommittedWidth):

  • rendering/LineWidth.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineBreaker::nextSegmentBreak):

LayoutTests:

  • fast/css/unexpected-word-wrapping-with-non-empty-spans-expected.html: Added.
  • fast/css/unexpected-word-wrapping-with-non-empty-spans.html: Added.
5:16 AM Changeset in webkit [156535] by allan.jensen@digia.com
  • 6 edits in trunk

[Qt] Fix force_static_libs_as_shared in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121961

Reviewed by Csaba Osztrogonác.

Source/WebKit/qt:

  • WebCoreSupport/QWebFrameAdapter.h:

Source/WebKit2:

Do not add strict ordering for webkit2qml. It is not needed and causes
Target.pri to be built out of order.

  • WebKit2.pro:

Tools:

Reenable force_static_libs_as_shared when building WebKit2.

  • qmake/mkspecs/features/default_post.prf:
4:57 AM Changeset in webkit [156534] by allan.jensen@digia.com
  • 3 edits in trunk/Tools

[Qt] Mock implementations of positioning and orientation not used
https://bugs.webkit.org/show_bug.cgi?id=121956

Reviewed by Csaba Osztrogonác.

Move production_build checks to sanitizeFeatures where its value is actually known.

  • qmake/mkspecs/features/features.prf:
  • qmake/mkspecs/features/features.pri:
3:40 AM Changeset in webkit [156533] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.2

Unreviewed. Update NEWS and Versions.m4 for 2.2.0 release.

.:

  • Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Add release notes.
2:44 AM Changeset in webkit [156532] by mario@webkit.org
  • 23 edits
    2 adds in trunk

[ATK] Protect entry points in the ATK wrapper against outdated render trees
https://bugs.webkit.org/show_bug.cgi?id=121558

Reviewed by Chris Fleizach.

Source/WebCore:

Make sure that we protect every entry point in the ATK wrapper
against outdated render trees, before using the WebCore's
accessibility API, since that might lead to problems (and crashes)
if the render and accessibility trees are not stable.

Thus, call AccessibilityObject::updateBackingStore() in those
entry points and check whether the ATK wrapper is detached or not
after that, to decide whether to continue or not.

Besides providing a new test to check that it WebKit does not
crash in a given scenario (which actually triggered the
investigation here), solving this situation also fixes other tests
that were previously failing (aria-used-on-image-maps.html) or
that were printing wrong results, not detected until now due to
wrong platform specific expectations (file-upload-button-stringvalue
and deleting-iframe-destroys-axcache).

Test: accessibility/heading-crash-after-hidden.html

  • accessibility/atk/WebKitAccessibleUtil.h: Added two new macros

to inject the needed code at the beginning of each entry point to
allow gracefully exit those functions when the render tree is
unstable. Inspired by g_return_if_fail and g_return_val_if_fail, we
called them returnIfWebKitAccessibleIsInvalid and returnValIfWebKitAccessibleIsInvalid.

  • accessibility/atk/WebKitAccessibleHyperlink.cpp:

(webkitAccessibleHyperlinkActionDoAction): Protect entry point.
(webkitAccessibleHyperlinkActionGetNActions): Ditto.
(webkitAccessibleHyperlinkActionGetDescription): Ditto.
(webkitAccessibleHyperlinkActionGetKeybinding): Ditto.
(webkitAccessibleHyperlinkActionGetName): Ditto.
(webkitAccessibleHyperlinkGetURI): Ditto.
(webkitAccessibleHyperlinkGetObject): Ditto.
(webkitAccessibleHyperlinkGetStartIndex): Ditto.
(webkitAccessibleHyperlinkGetEndIndex): Ditto.
(webkitAccessibleHyperlinkIsValid): Ditto.
(webkitAccessibleHyperlinkGetNAnchors): Ditto.
(webkitAccessibleHyperlinkIsSelectedLink): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceAction.cpp:

(webkitAccessibleActionDoAction): Ditto.
(webkitAccessibleActionGetNActions): Ditto.
(webkitAccessibleActionGetDescription): Ditto.
(webkitAccessibleActionGetKeybinding): Ditto.
(webkitAccessibleActionGetName): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceComponent.cpp:

(webkitAccessibleComponentRefAccessibleAtPoint): Ditto.
(webkitAccessibleComponentGetExtents): Ditto.
(webkitAccessibleComponentGrabFocus): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceDocument.cpp:

(webkitAccessibleDocumentGetAttributeValue): Ditto.
(webkitAccessibleDocumentGetAttributes): Ditto.
(webkitAccessibleDocumentGetLocale): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp:

(webkitAccessibleEditableTextSetRunAttributes): Ditto.
(webkitAccessibleEditableTextSetTextContents): Ditto.
(webkitAccessibleEditableTextInsertText): Ditto.
(webkitAccessibleEditableTextCopyText): Ditto.
(webkitAccessibleEditableTextCutText): Ditto.
(webkitAccessibleEditableTextDeleteText): Ditto.
(webkitAccessibleEditableTextPasteText): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp:

(webkitAccessibleHypertextGetLink): Ditto.
(webkitAccessibleHypertextGetNLinks): Ditto.
(webkitAccessibleHypertextGetLinkIndex): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceImage.cpp:

(webkitAccessibleImageGetImagePosition): Ditto.
(webkitAccessibleImageGetImageDescription): Ditto.
(webkitAccessibleImageGetImageSize): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:

(webkitAccessibleSelectionAddSelection): Ditto.
(webkitAccessibleSelectionClearSelection): Ditto.
(webkitAccessibleSelectionRefSelection): Ditto.
(webkitAccessibleSelectionGetSelectionCount): Ditto.
(webkitAccessibleSelectionIsChildSelected): Ditto.
(webkitAccessibleSelectionRemoveSelection): Ditto.
(webkitAccessibleSelectionSelectAllSelection): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(webkitAccessibleTableRefAt): Ditto.
(webkitAccessibleTableGetIndexAt): Ditto.
(webkitAccessibleTableGetColumnAtIndex): Ditto.
(webkitAccessibleTableGetRowAtIndex): Ditto.
(webkitAccessibleTableGetNColumns): Ditto.
(webkitAccessibleTableGetNRows): Ditto.
(webkitAccessibleTableGetColumnExtentAt): Ditto.
(webkitAccessibleTableGetRowExtentAt): Ditto.
(webkitAccessibleTableGetColumnHeader): Ditto.
(webkitAccessibleTableGetRowHeader): Ditto.
(webkitAccessibleTableGetCaption): Ditto.
(webkitAccessibleTableGetColumnDescription): Ditto.
(webkitAccessibleTableGetRowDescription): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(webkitAccessibleTextGetText): Ditto.
(webkitAccessibleTextGetTextAfterOffset): Ditto.
(webkitAccessibleTextGetTextAtOffset): Ditto.
(webkitAccessibleTextGetTextBeforeOffset): Ditto.
(webkitAccessibleTextGetCharacterAtOffset): Ditto.
(webkitAccessibleTextGetCaretOffset): Ditto.
(webkitAccessibleTextGetRunAttributes): Ditto.
(webkitAccessibleTextGetDefaultAttributes): Ditto.
(webkitAccessibleTextGetCharacterExtents): Ditto.
(webkitAccessibleTextGetRangeExtents): Ditto.
(webkitAccessibleTextGetCharacterCount): Ditto.
(webkitAccessibleTextGetOffsetAtPoint): Ditto.
(webkitAccessibleTextGetNSelections): Ditto.
(webkitAccessibleTextGetSelection): Ditto.
(webkitAccessibleTextAddSelection): Ditto.
(webkitAccessibleTextSetSelection): Ditto.
(webkitAccessibleTextRemoveSelection): Ditto.
(webkitAccessibleTextSetCaretOffset): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceValue.cpp:

(webkitAccessibleValueGetCurrentValue): Ditto.
(webkitAccessibleValueGetMaximumValue): Ditto.
(webkitAccessibleValueGetMinimumValue): Ditto.
(webkitAccessibleValueSetCurrentValue): Ditto.
(webkitAccessibleValueGetMinimumIncrement): Ditto.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(core): Removed, as it's not actually needed.
(webkitAccessibleGetName): Protect entry point.
(webkitAccessibleGetDescription): Ditto.
(webkitAccessibleGetParent): Ditto.
(webkitAccessibleGetNChildren): Ditto.
(webkitAccessibleRefChild): Ditto.
(webkitAccessibleGetIndexInParent): Ditto.
(webkitAccessibleGetAttributes): Ditto.
(webkitAccessibleGetRole): Ditto.
(webkitAccessibleRefStateSet): Ditto.
(webkitAccessibleRefRelationSet): Ditto.
(webkitAccessibleGetObjectLocale): Ditto.
(webkitAccessibleDetach): Ditto.
(webkitAccessibleIsDetached): New helper function, to be used from
the newly added macros. We need to check whether the wrapper is
detached and not just the wrapper AccessibilityObject since once
the detachment happens we can't trust anything but the AtkObject
from the wrapper (the AccessibilityObject might be invalid).

  • accessibility/atk/WebKitAccessibleWrapperAtk.h:

Assert that the render tree is neither being updated nor in need
of being updated before trying to compute the text under a given
element, since that might lead to crashes due to the constructor
of TextIterator calling updateLayoutIgnorePendingStylesheets().

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::textUnderElement): Assert that
the render tree is neither being updated nor needing updating.

LayoutTests:

Added a new test to check that we do not crash in certain
scenarios when hiding objects and retriving accessibility
information about it.

  • accessibility/heading-crash-after-hidden-expected.txt: Added.
  • accessibility/heading-crash-after-hidden.html: Added.

Rebaselined expectations that were wrong before, since they were
not returning the actual value that they should be returning when
called AccessibilityUIElement::stringValue().

  • platform/efl-wk1/accessibility/file-upload-button-stringvalue-expected.txt:

Updated, since the actual text being returned should be the actual
value of the file chooser (e.g. "(None)") and not the text in the
upload botton (e.g. "Choose files").

  • platform/efl-wk2/accessibility/file-upload-button-stringvalue-expected.txt: Ditto.
  • platform/gtk-wk2/accessibility/file-upload-button-stringvalue-expected.txt: Ditto..
  • platform/gtk/accessibility/file-upload-button-stringvalue-expected.txt: Ditto.
  • platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt:

Updated, since the iframe should be exposed at all after deleting it.

Removed accesibility test now passing after fixing this issue.

  • platform/gtk/TestExpectations: Removed accessibility/aria-used-on-image-maps.html.
2:07 AM Changeset in webkit [156531] by mario@webkit.org
  • 3 edits in trunk/Tools

[ATK] Normalize checks in entry points for DRT and WKTR
https://bugs.webkit.org/show_bug.cgi?id=121959

Reviewed by Chris Fleizach.

Always check if we have a proper instance of AtkObject,
implementing the interfaces that we might need for each case, at
the entry point of every method of AccessibilityUIElement for ATK,
and do those checks in an uniform way across DRT and WKTR, to
avoid confusion and issues when modifying these files in the future.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::getChildren): Use normalized checks.
(AccessibilityUIElement::getChildrenWithRange): Ditto.
(AccessibilityUIElement::rowCount): Ditto.
(AccessibilityUIElement::columnCount): Ditto.
(AccessibilityUIElement::childrenCount): Ditto.
(AccessibilityUIElement::elementAtPoint): Ditto.
(AccessibilityUIElement::getChildAtIndex): Ditto.
(AccessibilityUIElement::allAttributes): Ditto.
(AccessibilityUIElement::titleUIElement): Ditto.
(AccessibilityUIElement::parentElement): Ditto.
(AccessibilityUIElement::attributesOfChildren): Ditto.
(AccessibilityUIElement::role): Ditto.
(AccessibilityUIElement::title): Ditto.
(AccessibilityUIElement::description): Ditto.
(AccessibilityUIElement::stringValue): Ditto.
(AccessibilityUIElement::language): Ditto.
(AccessibilityUIElement::x): Ditto.
(AccessibilityUIElement::y): Ditto.
(AccessibilityUIElement::width): Ditto.
(AccessibilityUIElement::height): Ditto.
(AccessibilityUIElement::orientation): Ditto.
(AccessibilityUIElement::intValue): Ditto.
(AccessibilityUIElement::minValue): Ditto.
(AccessibilityUIElement::maxValue): Ditto.
(indexRangeInTable): Ditto.
(AccessibilityUIElement::cellForColumnAndRow): Ditto.
(AccessibilityUIElement::stringAttributeValue): Ditto.
(alterCurrentValue): Ditto.
(AccessibilityUIElement::press): Ditto.
(AccessibilityUIElement::documentEncoding): Ditto.
(AccessibilityUIElement::documentURI): Ditto.
(AccessibilityUIElement::hasPopup): Ditto.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::indexRangeInTable): Use normalized checks.
(WTR::alterCurrentValue): Ditto.
(WTR::AccessibilityUIElement::getChildren): Ditto.
(WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
(WTR::AccessibilityUIElement::childrenCount): Ditto.
(WTR::AccessibilityUIElement::elementAtPoint): Ditto.
(WTR::AccessibilityUIElement::indexOfChild): Ditto.
(WTR::AccessibilityUIElement::childAtIndex): Ditto.
(WTR::AccessibilityUIElement::titleUIElement): Ditto.
(WTR::AccessibilityUIElement::parentElement): Ditto.
(WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
(WTR::AccessibilityUIElement::allAttributes): Ditto.
(WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
(WTR::AccessibilityUIElement::role): Ditto.
(WTR::AccessibilityUIElement::title): Ditto.
(WTR::AccessibilityUIElement::description): Ditto.
(WTR::AccessibilityUIElement::orientation): Ditto.
(WTR::AccessibilityUIElement::stringValue): Ditto.
(WTR::AccessibilityUIElement::language): Ditto.
(WTR::AccessibilityUIElement::x): Ditto.
(WTR::AccessibilityUIElement::y): Ditto.
(WTR::AccessibilityUIElement::width): Ditto.
(WTR::AccessibilityUIElement::height): Ditto.
(WTR::AccessibilityUIElement::intValue): Ditto.
(WTR::AccessibilityUIElement::minValue): Ditto.
(WTR::AccessibilityUIElement::maxValue): Ditto.
(WTR::AccessibilityUIElement::rowCount): Ditto.
(WTR::AccessibilityUIElement::columnCount): Ditto.
(WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
(WTR::AccessibilityUIElement::press): Ditto.
(WTR::AccessibilityUIElement::documentEncoding): Ditto.
(WTR::AccessibilityUIElement::documentURI): Ditto.
(WTR::AccessibilityUIElement::hasPopup): Ditto.

1:58 AM Changeset in webkit [156530] by mario@webkit.org
  • 5 edits in trunk

[ATK] accessibility/aria-sort.html is failing after r156409
https://bugs.webkit.org/show_bug.cgi?id=121947

Reviewed by Chris Fleizach.

Source/WebCore:

The WAI-ARIA spec says to translate the value as is from the
attribute, so do just that instead of mapping values from the
AccessibilitySortDirection enumeration into strings.
http://www.w3.org/TR/wai-aria-implementation/#mapping_state-property

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes): Do the right mapping for aria-sort.

Tools:

Implement AccessibilityUIElement::isSupported for the ATK
platforms, just by checking whether we have an associated object
attribute exposed for the wrapper object matching the required
attribute in the layout test (e.g "AXSortDirection" -> "sort").

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::isAttributeSupported): Implemented.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::isAttributeSupported): Implemented.

1:47 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
12:48 AM Changeset in webkit [156529] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WTF

[GCC] Fix build with gcc < 4.8.1, which does not have is_trivially_destructible
https://bugs.webkit.org/show_bug.cgi?id=121999

Patch by Gustavo Noronha Silva <gns@gnome.org> on 2013-09-27
Reviewed by Benjamin Poulain.

  • wtf/StdLibExtras.h:
Note: See TracTimeline for information about the timeline view.