Timeline
Oct 3, 2013:
- 11:05 PM Changeset in webkit [156880] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself to some watchlists.
- Scripts/webkitpy/common/config/watchlist:
- 9:42 PM Changeset in webkit [156879] by
-
- 2 edits in trunk/Source/WebCore
Assert that we don't try to index past the end of the m_coreTextIndices array
https://bugs.webkit.org/show_bug.cgi?id=122308
Reviewed by Dan Bernstein.
Because an assertion failure is better than a random crash.
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextRun::indexAt):
- 9:38 PM Changeset in webkit [156878] by
-
- 4 edits2 deletes in trunk/Source/WebKit
Remove WebNSNotificationCenterExtras
https://bugs.webkit.org/show_bug.cgi?id=122316
Reviewed by Dan Bernstein.
Source/WebKit:
Update Xcode project.
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
Use dispatch_async to ensure that notifications are posted on the main thread.
- Misc/WebIconDatabase.mm:
(-[WebIconDatabase _sendNotificationForURL:]):
(-[WebIconDatabase _sendDidRemoveAllIconsNotification]):
- Misc/WebNSNotificationCenterExtras.h: Removed.
- Misc/WebNSNotificationCenterExtras.m: Removed.
- 9:11 PM Changeset in webkit [156877] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r155787): WebKitTestRunner rebuilds from scratch when doing an incremental build
Reviewed by Dan Bernstein.
- WebKit2.xcodeproj/project.pbxproj: Have unifdef generate its output to a temporary file. If its exit status
indicates that the content did not change, remove the temporary file. If the content changed, moved the temporary file
over the destination. This avoids updating the modification date of the file when it has not changed.
- 9:04 PM Changeset in webkit [156876] by
-
- 69 edits in trunk/Source/WebCore
Move setting of some layout bits to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=122256
Reviewed by Andreas Kling.
These bits never apply to RenderText nodes:
normalChildNeedsLayout
posChildNeedsLayout
needsSimplifiedNormalFlowLayout
normalChildNeedsLayout
positionedMovementLayout
The code for setting them can be moved to RenderElement.
Also separated the code paths for setting and clearing the bits and uninlined
everything that is not massively popular.
- 8:42 PM Changeset in webkit [156875] by
-
- 2 edits in tags/Safari-538.1.2/Source/ThirdParty/ANGLE
Merged r156870. <rdar://problem/15116673>
- 8:21 PM Changeset in webkit [156874] by
-
- 5 edits in tags/Safari-538.1.2/Source
Versioning.
- 8:19 PM Changeset in webkit [156873] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION (r156811): WebCore rebuilds from scratch when doing an incremental build
The change in r156811 resulted in several public headers in the JavaScriptCore framework having their modification
date touched on every build, even if their contents had not changed. This resulted in a large portion of WebCore
needing to rebuilt after an incremental build of JavaScriptCore.
Reviewed by Dan Bernstein.
- JavaScriptCore.xcodeproj/project.pbxproj: Have unifdef generate its output to a temporary file. If its exit status
indicates that the content did not change, remove the temporary file. If the content changed, moved the temporary file
over the destination.
- 8:19 PM Changeset in webkit [156872] by
-
- 1 copy in tags/Safari-538.1.2
New Tag.
- 8:08 PM Changeset in webkit [156871] by
-
- 23 edits in trunk/Source
Remove shouldRubberBandInDirection from the WKBundlePageUIClient
https://bugs.webkit.org/show_bug.cgi?id=122309
Reviewed by Andreas Kling.
../WebCore:
- loader/EmptyClients.h:
- page/ChromeClient.h:
- page/FrameView.cpp:
- page/FrameView.h:
- platform/ScrollableArea.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::shouldRubberBandInDirection):
../WebKit/efl:
- WebCoreSupport/ChromeClientEfl.h:
../WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.h:
../WebKit/mac:
- WebCoreSupport/WebChromeClient.h:
../WebKit/win:
- WebCoreSupport/WebChromeClient.h:
../WebKit/wince:
- WebCoreSupport/ChromeClientWinCE.h:
../WebKit2:
WKBundlePageUIClient's shouldRubberBandInDirection has never worked with
threaded scrolling, so remove it.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.h:
- 5:43 PM Changeset in webkit [156870] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
<rdar://problem/15116673> [mac] Build failure when the source directory is not named ANGLE
https://bugs.webkit.org/show_bug.cgi?id=122307
Reviewed by Mark Rowe.
- ANGLE.xcodeproj/project.pbxproj: Ensure that the symlink to SRCROOT in
DerivedSources/ANGLE is named ANGLE.
- 4:38 PM Changeset in webkit [156869] by
-
- 11 edits in trunk
Fix the HTMLSelectElement.prototype.remove() method
https://bugs.webkit.org/show_bug.cgi?id=121586
Reviewed by Darin Adler.
Source/WebCore:
Fix the HTMLSelectElement.prototype.remove() method so that it behaves like
Element.remove() if no argument is passed (from ChildNode). This behavior
is consistent with Firefox and Blink.
See https://www.w3.org/Bugs/Public/show_bug.cgi?id=20720 for more
information.
Tests: js/dom/select-options-remove.html
- bindings/js/JSHTMLOptionsCollectionCustom.cpp:
(WebCore::JSHTMLOptionsCollection::remove):
Stop calling JSHTMLSelectElement::remove() blindly as it is dangerous, especially
now that calling it without argument now detaches the element. Instead, have the
bindings call the corresponding methods on the HTMLOptionsCollection implementation
object, as it should.
- bindings/js/JSHTMLSelectElementCustom.cpp:
(WebCore::JSHTMLSelectElement::remove):
Call Element::remove() if no argument is given.
- html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::remove):
- html/HTMLOptionsCollection.h:
- html/HTMLSelectElement.cpp:
- html/HTMLSelectElement.h:
Rename remove(int) to removeByIndex(int) to avoid conflict with
Node::remove(ExceptionCode&).
LayoutTests:
Add test to make sure calling HTMLSelectElement.prototype.remove() detaches the
select element from its parent, as Element::remove() would.
- js/dom/select-options-remove-expected.txt:
- js/resources/select-options-remove.js:
- 4:31 PM Changeset in webkit [156868] by
-
- 1 edit1 delete in trunk/LayoutTests
Re-remove Qt TestExpectations re-added in r156841 after r156866.
- platform/qt: Removed.
- platform/qt/TestExpectations: Removed.
- 4:29 PM Changeset in webkit [156867] by
-
- 8 edits2 adds in trunk
Regression: AX: <table><caption> no longer exposed as AXTitle.
https://bugs.webkit.org/show_bug.cgi?id=121977
Patch by Samuel White <Samuel White> on 2013-10-03
Reviewed by Darin Adler.
Source/WebCore:
Some cleanup of accessibilityText. Notably, subclasses were unnecessarily redeclaring this method as both private and
protected. Added OVERRIDE keyword to these subclasses as needed. Moved titleElementText to virtual so we can do subclass
overrides in cases like this bug. That is, AccessibilityTable can leverage the existing machinery for alternativeText,
visibleText, and helpText, but we do some custom work ONLY in titleElementText.
Test: accessibility/table-title.html
- accessibility/AccessibilityImageMapLink.h:
- accessibility/AccessibilityMediaControls.h:
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::titleElementText):
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::titleElementText):
- accessibility/AccessibilityTable.h:
LayoutTests:
Added test to verify that table elements correctly derive their AXTitle from their associated caption element.
- accessibility/table-title-expected.txt: Added.
- accessibility/table-title.html: Added.
- 4:24 PM Changeset in webkit [156866] by
-
- 5 edits in trunk/Tools
Remove Qt builders from the flakiness dashboard.
- TestResultServer/static-dashboards/builders.jsonp:
- TestResultServer/static-dashboards/flakiness_dashboard.js:
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- TestResultServer/static-dashboards/loader_unittests.js:
- 4:18 PM Changeset in webkit [156865] by
-
- 1 edit3 adds in trunk/LayoutTests
Add a testcase for a bug that I had during the development. This code uses the asm.js style.
https://bugs.webkit.org/show_bug.cgi?id=122286
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-03
Reviewed by Filip Pizlo.
- js/regress/asmjs_bool_bug-expected.txt: Added.
- js/regress/asmjs_bool_bug.html: Added.
- js/regress/script-tests/asmjs_bool_bug.js: Added.
(strlen):
- 4:10 PM Changeset in webkit [156864] by
-
- 4 edits in trunk/Tools
[mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
https://bugs.webkit.org/show_bug.cgi?id=122299
Reviewed by Beth Dakin.
- TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
Disable threaded scrolling.
- TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
- TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
Synchronously wait for the scrolling thread to inform the main thread of the new scroll position.
- 4:03 PM Changeset in webkit [156863] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Win] Unreviewed gardening.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Clean up the
paths for various files added outside of Visual Studio. They are all
displayed in the root of the project, rather than the proper sub-folder.
- 3:54 PM Changeset in webkit [156862] by
-
- 6 edits in trunk/Source
../JavaScriptCore: [Win] Update solutions and projects to support 64-bit builds.
https://bugs.webkit.org/show_bug.cgi?id=122225
Reviewed by Anders Carlsson.
Revise ordering of CPU(X86) and CPU(X86_64) tests, because MSVC always defines
both when targeting a 64-bit build.
- JavaScriptCore.vcxproj/JavaScriptCore.submit.sln: Add an x64 target
for 64-bit builds.
../WTF: [Win] Update solutions and projects to support 64-bit build.
https://bugs.webkit.org/show_bug.cgi?id=122225
Reviewed by Anders Carlsson.
- WTF.vcxproj/WTF.submit.sln: Add x64 architecture targets.
- WTF.vcxproj/WTF.vcxproj: Correct path to config.h file.
- WTF.vcxproj/WTF.vcxproj.filters: Correct path to config.h file.
- 3:52 PM Changeset in webkit [156861] by
-
- 10 edits4 copies in trunk/Source/WebKit2
Create CoordinatedDrawingArea / CoordinatedDrawingAreaProxy
https://bugs.webkit.org/show_bug.cgi?id=122207
Patch by Sergio Correia <Sergio Correia> on 2013-10-03
Reviewed by Anders Carlsson.
Since Apple are moving away from DrawingAreaImpl, Coordinated Graphics
should have its own drawing area.
- CMakeLists.txt: Use CoordinatedDrawingArea and
CoordinatedDrawingAreaProxy instead of the DrawingAreaImpl /
DrawingAreaProxyImpl.
- Shared/DrawingAreaInfo.h: Add DrawingAreaTypeCoordinated.
- UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:
Added, copied from DrawingAreaProxyImpl.cpp.
- UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h: Added,
copied from DrawingAreaProxyImpl.h.
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::createDrawingAreaProxy): Use CoordinatedDrawingAreaProxy.
- UIProcess/DrawingAreaProxyImpl.cpp: Remove Coordinated Graphics
bits.
- UIProcess/DrawingAreaProxyImpl.h: Ditto.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:
Added, copied from DrawingAreaImpl.cpp.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
Added, copied from DrawingAreaImpl.h.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::performScheduledLayerFlush): Use
CoordinatedDrawingArea.
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create): Handle the DrawingAreaTypeCoordinated
in the DrawingArea creation code.
- WebProcess/WebPage/DrawingAreaImpl.cpp: Remove Coordinated Graphics
bits.
- WebProcess/WebPage/DrawingAreaImpl.h: Ditto.
- 3:15 PM Changeset in webkit [156860] by
-
- 30 edits in trunk/Source
Ignore deprecation warnings
https://bugs.webkit.org/show_bug.cgi?id=122302
Reviewed by Mark Rowe.
Source/WebCore:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
- bindings/objc/DOMHTML.mm:
(-[DOMHTMLInputElement _rectOnScreen]):
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
- page/mac/FrameSnapshottingMac.mm:
(WebCore::imageFromRect):
- platform/graphics/mac/IconMac.mm:
(WebCore::Icon::Icon):
- platform/mac/DragImageMac.mm:
(WebCore::scaleDragImage):
- platform/mac/PlatformEventFactoryMac.mm:
(WebCore::globalPoint):
- platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformContentsToScreen):
(WebCore::ScrollView::platformScreenToContents):
Source/WebKit/mac:
- Misc/WebIconDatabase.mm:
(-[WebIconDatabase _scaleIcon:toSize:]):
(webGetNSImage):
- Misc/WebNSImageExtras.m:
(-[NSImage _web_scaleToMaxSize:]):
(-[NSImage _web_dissolveToFraction:]):
- Misc/WebNSViewExtras.m:
(-[NSView _web_DragImageForElement:rect:event:pasteboard:source:offset:]):
(-[NSView _web_convertRect:toView:]):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::mouseEvent):
- Plugins/Hosted/WebTextInputWindowController.m:
(-[WebTextInputPanel _interpretKeyEvent:string:]):
- Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
- WebCoreSupport/WebDragClient.mm:
(WebDragClient::startDrag):
- WebInspector/WebNodeHighlight.mm:
(-[WebNodeHighlight _computeHighlightWindowFrame]):
- WebView/WebFullScreenController.mm:
(-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
(-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
- WebView/WebHTMLView.mm:
(+[WebHTMLView _postFlagsChangedEvent:]):
(-[WebHTMLView _updateMouseoverWithFakeEvent]):
(-[WebHTMLView _autoscroll]):
(-[WebHTMLView mouseDown:]):
(-[WebHTMLView mouseDragged:]):
(-[WebHTMLView mouseUp:]):
(-[WebHTMLView accessibilityHitTest:]):
(-[WebHTMLView _executeSavedKeypressCommands]):
(-[WebHTMLView attachRootLayer:]):
(-[WebHTMLView textStorage]):
(-[WebHTMLView _updateSelectionForInputManager]):
- WebView/WebTextCompletionController.mm:
(-[WebTextCompletionController _buildUI]):
(-[WebTextCompletionController _placePopupWindow:]):
Source/WebKit2:
- Shared/mac/WebEventFactory.mm:
(WebKit::globalPoint):
- UIProcess/API/mac/FindIndicatorWindow.mm:
(WebKit::FindIndicatorWindow::setFindIndicator):
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::screenToWindow):
(WebKit::PageClientImpl::windowToScreen):
- UIProcess/API/mac/WKTextInputWindowController.mm:
(-[WKTextInputPanel _interpretKeyEvent:usingLegacyCocoaTextInput:string:]):
(-[WKTextInputPanel _hasMarkedText]):
- UIProcess/API/mac/WKView.mm:
(-[WKView characterIndexForPoint:]):
(-[WKView firstRectForCharacterRange:actualRange:]):
(-[WKView _postFakeMouseMovedEventForFlagsChangedEvent:]):
(-[WKView _setDragImage:at:linkDrag:]):
(-[WKView performDictionaryLookupAtCurrentMouseLocation]):
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::showContextMenu):
- UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::showPopupMenu):
- 2:46 PM Changeset in webkit [156859] by
-
- 2 edits in trunk/Tools
Use numeric strings in the OS version dictionary
https://bugs.webkit.org/show_bug.cgi?id=122300
Reviewed by Mark Rowe.
- Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo._determine_mac_version):
- 2:14 PM Changeset in webkit [156858] by
-
- 2 edits in trunk/Source/JavaScriptCore
Eliminate unused JITStub function declarations
https://bugs.webkit.org/show_bug.cgi?id=122288
Reviewed by Geoffrey Garen.
Removed unused JITStub declarations.
- jit/JITStubs.h:
- 2:07 PM Changeset in webkit [156857] by
-
- 3 edits2 adds in trunk/LayoutTests
[CSS Regions] Layout Test for selecting text in 2 regions
https://bugs.webkit.org/show_bug.cgi?id=121841
Reviewed by Alexandru Chiculita.
Add new reftest for selecting text in 2 regions. It compares the
behavior (highlighted text and selected content) in regions and absolute
positions.
- fast/regions/resources/helper.js: Add new function to set selected
content in an element onmouseup.
(onMouseUpLogSelection.document.onmouseup):
(onMouseUpLogSelection):
- fast/regions/resources/region-style.css: Define some styles that could
be reused in other tests.
- fast/regions/selection/selecting-text-in-2-regions-expected.html:
Added.
- fast/regions/selection/selecting-text-in-2-regions.html: Added.
- 1:49 PM Changeset in webkit [156856] by
-
- 5 edits in tags/Safari-538.1.1/Source
Versioning.
- 1:44 PM Changeset in webkit [156855] by
-
- 1 copy in tags/Safari-538.1.1
New Tag.
- 1:44 PM Changeset in webkit [156854] by
-
- 2 edits in trunk/Tools
Fix LeaksViewer to load leaks results from MountainLion, not Lion.
Rubber-stamped by Tim Horton.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
(LeaksViewer._displayURLPrompt):
- 1:36 PM Changeset in webkit [156853] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: fast/history/history-back-while-pdf-in-pagecache.html
https://bugs.webkit.org/show_bug.cgi?id=121628
- platform/mac/TestExpectations: Marking as such.
- 1:04 PM Changeset in webkit [156852] by
-
- 3 edits4 adds in trunk
[CSS Shapes] Support the shape-image-threshold property
https://bugs.webkit.org/show_bug.cgi?id=122254
Reviewed by Andreas Kling.
Source/WebCore:
Replace the hardwired 0 Shape::createShape() threshold parameter with the style's
shapeImageThreshold() value (which has been clamped to [0,1]).
Tests: fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-001.html
fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-002.html
- rendering/shapes/ShapeInfo.cpp:
(WebCore::::computedShape):
LayoutTests:
Verify that a shape-outside image whose pixels' alpha channels are all above shape-image-threshold causes
layout to skirt the shape, and similarly that an image whose pixels' alpha channels are all below the threshold
has no effect on the layout.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-001-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-001.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-002-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-002.html: Added.
- 1:00 PM Changeset in webkit [156851] by
-
- 7 edits1 copy1 delete in trunk/LayoutTests
[CSS Shapes] Revise the CSS property parsing tests
https://bugs.webkit.org/show_bug.cgi?id=122251
Reviewed by Andreas Kling.
Flattened the shapes CSS property parsing tests by inserting the code from
the fast/shapes/parsing/script-tests subdirectory into the test HTML source
files. The subdirectory is now empty and the tests are easier to read.
- fast/shapes/parsing/parsing-shape-image-threshold.html: Inserted parsing-shape-image-threshold.js instead of referring to it with script src.
- fast/shapes/parsing/parsing-shape-inside.html: Likewise
- fast/shapes/parsing/parsing-shape-lengths.html: Likewise
- fast/shapes/parsing/parsing-shape-margin.html: Likewise
- fast/shapes/parsing/parsing-shape-outside.html: Likewise
- fast/shapes/parsing/parsing-shape-padding.html: Likewise
- fast/shapes/parsing/parsing-test-utils.js: Renamed from LayoutTests/fast/shapes/parsing/script-tests/parsing-test-utils.js.
(getCSSText):
(getComputedStyleValue):
(getParentAndChildComputedStyles):
(getParentAndChildComputedStylesString):
(getChildComputedStyle):
(testShapeSpecifiedProperty):
(testShapeComputedProperty):
(testNotInheritedShapeChildProperty):
(property):
- fast/shapes/parsing/script-tests/parsing-shape-image-threshold.js: Removed.
- fast/shapes/parsing/script-tests/parsing-shape-inside.js: Removed.
- fast/shapes/parsing/script-tests/parsing-shape-lengths.js: Removed.
- fast/shapes/parsing/script-tests/parsing-shape-margin.js: Removed.
- fast/shapes/parsing/script-tests/parsing-shape-outside.js: Removed.
- fast/shapes/parsing/script-tests/parsing-shape-padding.js: Removed.
- 12:53 PM Changeset in webkit [156850] by
-
- 5 edits in trunk/Source/WebCore
[CSS Regions] Follow-up code style change after bug #121828 All regions have layers
https://bugs.webkit.org/show_bug.cgi?id=122265
Patch by Mihai Maerean <Mihai Maerean> on 2013-10-03
Reviewed by Darin Adler.
Comments moved to the cpp file, as requested in the review of bug #121828 All regions have layers.
No new tests, no behavior change.
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::requiresLayer):
- rendering/RenderMultiColumnSet.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::requiresLayer):
- rendering/RenderRegion.h:
- 12:52 PM Changeset in webkit [156849] by
-
- 2 edits in trunk/LayoutTests
video-object-fit tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=121803
I'm not quite sure what's going on, but [ Pass Failure ] expectations didn't cut it.
Trying [ Pass ImageOnlyFailure ], as the failures are always image only anyway.
- platform/mac/TestExpectations:
- 12:48 PM Changeset in webkit [156848] by
-
- 3 edits in trunk/Source/WebCore
[cairo] Initialize the m_compositorTexture in GraphicsContext3DCairo.cpp
https://bugs.webkit.org/show_bug.cgi?id=122285
Patch by Alejandro G. Castro <alex@igalia.com> on 2013-10-03
Reviewed by Noam Rosenthal.
Initialize to the default texture to avoid the random texture name
and generate the texture name.
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D): Initialize
m_compositorTexture.
(WebCore::GraphicsContext3D::~GraphicsContext3D): Delete the
generated textures names.
- platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs): Generate the texture
names for m_compositorTexture and m_texture.
- 11:38 AM Changeset in webkit [156847] by
-
- 41 edits in trunk/Source/WebKit2
Remove the last remnants of Qt from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=122290
Reviewed by Andreas Kling.
- Platform/PlatformProcessIdentifier.h:
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):
- Shared/Downloads/Download.cpp:
(WebKit::Download::Download):
- Shared/Downloads/Download.h:
- Shared/Downloads/DownloadManager.cpp:
- Shared/Downloads/DownloadManager.h:
- Shared/EditorState.cpp:
(WebKit::EditorState::encode):
(WebKit::EditorState::decode):
- Shared/EditorState.h:
(WebKit::EditorState::EditorState):
- Shared/LayerTreeContext.h:
- Shared/NativeWebKeyboardEvent.h:
- Shared/NativeWebMouseEvent.h:
- Shared/NativeWebWheelEvent.h:
- Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::encode):
(WebKit::PlatformPopupMenuData::decode):
- Shared/PlatformPopupMenuData.h:
- Shared/ShareableBitmap.h:
- Shared/WebPreferencesStore.h:
- UIProcess/Downloads/DownloadProxy.cpp:
- UIProcess/Downloads/DownloadProxy.h:
- UIProcess/PageClient.h:
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didFinishLaunching):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::download):
- UIProcess/WebFullScreenManagerProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::performDragControllerAction):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::showPopupMenu):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebPopupMenuProxy.h:
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/WebCoreSupport/WebDragClient.cpp:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
(WebKit::WebEditorClient::willSetInputMethodState):
(WebKit::WebEditorClient::supportsGlobalSelection):
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::shouldFallBack):
- WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::didChangeSelectedIndex):
- WebProcess/WebCoreSupport/WebPopupMenu.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::editorState):
(WebKit::WebPage::performDragControllerAction):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- config.h:
- 11:24 AM Changeset in webkit [156846] by
-
- 7 edits10 adds in trunk
[CSS Shapes] Support block content with inline content around floats in shape-inside
https://bugs.webkit.org/show_bug.cgi?id=121616
Reviewed by David Hyatt.
In r156022 and r156364, I added support for floats inside shape-inside with inline content. This change extends
the existing implementation to support block content with inline content (paragraphs). I added an extra text for
positioning a float inside shape-inside without text content around it.
Source/WebCore:
Tests: fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content.html
fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content.html
fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle.html
fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content.html
fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content.html
- rendering/FloatingObjects.h:
(WebCore::FloatingObject::logicalSize): Add new function to return the FloatingObject logical size.
- rendering/LineWidth.cpp:
(WebCore::LineWidth::fitBelowFloats): When the lineBreaker code pushes down the content below the floating object,
we need to update the segments if we are in a shape-inside.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat): Do the positioning based on the float actual size, and use the
recent shapeInsideInfo. (Calling layoutShapeInsideInfo which deals with the layoutStates also instead of shapeInsideInfo.)
- rendering/RenderBlock.h:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::adjustLogicalLineTopAndLogicalHeightIfNeeded): If we don't have inline content we still need to positionize
our float content in a shape-inside.
(WebCore::updateSegmentsForShapes): Use the right coordinates for block content with inline content.
LayoutTests:
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content.html: Added.
- 11:06 AM Changeset in webkit [156845] by
-
- 1 edit247 deletes in trunk/Source/WebKit2
Remove Qt files from WebKit2.
Rubber-stomped by Andreas Kling.
- DerivedSources.pri: Removed.
- PluginProcess.pro: Removed.
- PluginProcess/qt/PluginControllerProxyQt.cpp: Removed.
- PluginProcess/qt/PluginProcessMainQt.cpp: Removed.
- PluginProcess/qt/PluginProcessQt.cpp: Removed.
- SandboxProcess.pro: Removed.
- Shared/API/c/qt/WKImageQt.cpp: Removed.
- Shared/API/c/qt/WKImageQt.h: Removed.
- Shared/Downloads/qt/DownloadQt.cpp: Removed.
- Shared/Downloads/qt/QtFileDownloader.cpp: Removed.
- Shared/Downloads/qt/QtFileDownloader.h: Removed.
- Shared/qt/ArgumentCodersQt.cpp: Removed.
- Shared/qt/ArgumentCodersQt.h: Removed.
- Shared/qt/LayerTreeContextQt.cpp: Removed.
- Shared/qt/NativeWebKeyboardEventQt.cpp: Removed.
- Shared/qt/NativeWebMouseEventQt.cpp: Removed.
- Shared/qt/NativeWebTouchEventQt.cpp: Removed.
- Shared/qt/NativeWebWheelEventQt.cpp: Removed.
- Shared/qt/PlatformCertificateInfo.h: Removed.
- Shared/qt/ProcessExecutablePathQt.cpp: Removed.
- Shared/qt/QtNetworkReplyData.cpp: Removed.
- Shared/qt/QtNetworkReplyData.h: Removed.
- Shared/qt/QtNetworkRequestData.cpp: Removed.
- Shared/qt/QtNetworkRequestData.h: Removed.
- Shared/qt/ShareableBitmapQt.cpp: Removed.
- Shared/qt/WebCoreArgumentCodersQt.cpp: Removed.
- Shared/qt/WebEventFactoryQt.cpp: Removed.
- Shared/qt/WebEventFactoryQt.h: Removed.
- Shared/qt/WebURLRequestQt.cpp: Removed.
- Shared/qt/WebURLResponseQt.cpp: Removed.
- Target.pri: Removed.
- UIProcess/API/C/qt/WKIconDatabaseQt.cpp: Removed.
- UIProcess/API/C/qt/WKIconDatabaseQt.h: Removed.
- UIProcess/API/C/qt/WKNativeEvent.h: Removed.
- UIProcess/API/cpp/qt/WKStringQt.cpp: Removed.
- UIProcess/API/cpp/qt/WKStringQt.h: Removed.
- UIProcess/API/cpp/qt/WKURLQt.cpp: Removed.
- UIProcess/API/cpp/qt/WKURLQt.h: Removed.
- UIProcess/API/qt/qquicknetworkreply.cpp: Removed.
- UIProcess/API/qt/qquicknetworkreply_p.h: Removed.
- UIProcess/API/qt/qquicknetworkrequest.cpp: Removed.
- UIProcess/API/qt/qquicknetworkrequest_p.h: Removed.
- UIProcess/API/qt/qquickurlschemedelegate.cpp: Removed.
- UIProcess/API/qt/qquickurlschemedelegate_p.h: Removed.
- UIProcess/API/qt/qquickwebpage.cpp: Removed.
- UIProcess/API/qt/qquickwebpage_p.h: Removed.
- UIProcess/API/qt/qquickwebpage_p_p.h: Removed.
- UIProcess/API/qt/qquickwebview.cpp: Removed.
- UIProcess/API/qt/qquickwebview_p.h: Removed.
- UIProcess/API/qt/qquickwebview_p_p.h: Removed.
- UIProcess/API/qt/qtwebsecurityorigin.cpp: Removed.
- UIProcess/API/qt/qtwebsecurityorigin_p.h: Removed.
- UIProcess/API/qt/qwebdownloaditem.cpp: Removed.
- UIProcess/API/qt/qwebdownloaditem_p.h: Removed.
- UIProcess/API/qt/qwebdownloaditem_p_p.h: Removed.
- UIProcess/API/qt/qwebiconimageprovider.cpp: Removed.
- UIProcess/API/qt/qwebiconimageprovider_p.h: Removed.
- UIProcess/API/qt/qwebkittest.cpp: Removed.
- UIProcess/API/qt/qwebkittest_p.h: Removed.
- UIProcess/API/qt/qwebloadrequest.cpp: Removed.
- UIProcess/API/qt/qwebloadrequest_p.h: Removed.
- UIProcess/API/qt/qwebnavigationhistory.cpp: Removed.
- UIProcess/API/qt/qwebnavigationhistory_p.h: Removed.
- UIProcess/API/qt/qwebnavigationhistory_p_p.h: Removed.
- UIProcess/API/qt/qwebnavigationrequest.cpp: Removed.
- UIProcess/API/qt/qwebnavigationrequest_p.h: Removed.
- UIProcess/API/qt/qwebpermissionrequest.cpp: Removed.
- UIProcess/API/qt/qwebpermissionrequest_p.h: Removed.
- UIProcess/API/qt/qwebpreferences.cpp: Removed.
- UIProcess/API/qt/qwebpreferences_p.h: Removed.
- UIProcess/API/qt/qwebpreferences_p_p.h: Removed.
- UIProcess/API/qt/raw/qrawwebview.cpp: Removed.
- UIProcess/API/qt/raw/qrawwebview_p.h: Removed.
- UIProcess/API/qt/raw/qrawwebview_p_p.h: Removed.
- UIProcess/API/qt/tests/bytearraytestdata.cpp: Removed.
- UIProcess/API/qt/tests/bytearraytestdata.h: Removed.
- UIProcess/API/qt/tests/html/basic_page.html: Removed.
- UIProcess/API/qt/tests/html/basic_page2.html: Removed.
- UIProcess/API/qt/tests/html/bluesquare.html: Removed.
- UIProcess/API/qt/tests/html/direct-image-compositing.html: Removed.
- UIProcess/API/qt/tests/html/inputmethod.html: Removed.
- UIProcess/API/qt/tests/html/redsquare.html: Removed.
- UIProcess/API/qt/tests/html/resources/qwkview_noBackground1.png: Removed.
- UIProcess/API/qt/tests/html/resources/qwkview_noBackground3.png: Removed.
- UIProcess/API/qt/tests/html/resources/qwkview_paint.png: Removed.
- UIProcess/API/qt/tests/html/resources/simple_image.png: Removed.
- UIProcess/API/qt/tests/html/scroll.html: Removed.
- UIProcess/API/qt/tests/inspectorserver/inspectorserver.pro: Removed.
- UIProcess/API/qt/tests/inspectorserver/tst_inspectorserver.cpp: Removed.
- UIProcess/API/qt/tests/publicapi/publicapi.pro: Removed.
- UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp: Removed.
- UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro: Removed.
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_linkHovered.qml: Removed.
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_loadHtml.qml: Removed.
- UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_navigationRequested.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView.pro: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_colorChooser.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_download.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_evaluateJavaScript.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_findText.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_fitToView.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_geopermission.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_itemSelector.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_javaScriptDialogs.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadFail.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadHtml.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgress.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadProgressSignal.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_messaging.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_multiFileUpload.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_navigationHistory.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_notification.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_origin.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_preferences.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_properties.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_resize.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_titleChanged.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_userScripts.qml: Removed.
- UIProcess/API/qt/tests/qmltests/WebView/tst_wheelEventHandling.qml: Removed.
- UIProcess/API/qt/tests/qmltests/common/TestWebView.qml: Removed.
- UIProcess/API/qt/tests/qmltests/common/alert.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/append-document-title.js: Removed.
- UIProcess/API/qt/tests/qmltests/common/big-user-script.js: Removed.
- UIProcess/API/qt/tests/qmltests/common/change-document-title.js: Removed.
- UIProcess/API/qt/tests/qmltests/common/colorChooser.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/confirm.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/download.zip: Removed.
- UIProcess/API/qt/tests/qmltests/common/evaluatejavascript.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/favicon.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/favicon.png: Removed.
- UIProcess/API/qt/tests/qmltests/common/favicon2.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/font-preferences.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/geolocation.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/javascript.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/link.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/localStorage.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/messaging.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/multifileupload.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/notification.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/prompt.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/qrctest.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/redirect.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/select.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/selectwithsize.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/singlefileupload.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/small-favicon.png: Removed.
- UIProcess/API/qt/tests/qmltests/common/test1.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/test2.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/test3.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/test4.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/test5.html: Removed.
- UIProcess/API/qt/tests/qmltests/common/titleupdate.js: Removed.
- UIProcess/API/qt/tests/qmltests/qmltests.pro: Removed.
- UIProcess/API/qt/tests/qmltests/resources.qrc: Removed.
- UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp: Removed.
- UIProcess/API/qt/tests/qquickwebview/qquickwebview.pro: Removed.
- UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp: Removed.
- UIProcess/API/qt/tests/qrawwebview/qrawwebview.pro: Removed.
- UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp: Removed.
- UIProcess/API/qt/tests/tests.pri: Removed.
- UIProcess/API/qt/tests/testwindow.h: Removed.
- UIProcess/API/qt/tests/util.cpp: Removed.
- UIProcess/API/qt/tests/util.h: Removed.
- UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp: Removed.
- UIProcess/InspectorServer/qt/WebSocketServerQt.cpp: Removed.
- UIProcess/InspectorServer/qt/WebSocketServerQt.h: Removed.
- UIProcess/Launcher/qt/ProcessLauncherQt.cpp: Removed.
- UIProcess/Plugins/qt/PluginProcessProxyQt.cpp: Removed.
- UIProcess/qt/BackingStoreQt.cpp: Removed.
- UIProcess/qt/PageViewportControllerClientQt.cpp: Removed.
- UIProcess/qt/PageViewportControllerClientQt.h: Removed.
- UIProcess/qt/QtDialogRunner.cpp: Removed.
- UIProcess/qt/QtDialogRunner.h: Removed.
- UIProcess/qt/QtDownloadManager.cpp: Removed.
- UIProcess/qt/QtDownloadManager.h: Removed.
- UIProcess/qt/QtGestureRecognizer.cpp: Removed.
- UIProcess/qt/QtGestureRecognizer.h: Removed.
- UIProcess/qt/QtPageClient.cpp: Removed.
- UIProcess/qt/QtPageClient.h: Removed.
- UIProcess/qt/QtPanGestureRecognizer.cpp: Removed.
- UIProcess/qt/QtPanGestureRecognizer.h: Removed.
- UIProcess/qt/QtPinchGestureRecognizer.cpp: Removed.
- UIProcess/qt/QtPinchGestureRecognizer.h: Removed.
- UIProcess/qt/QtTapGestureRecognizer.cpp: Removed.
- UIProcess/qt/QtTapGestureRecognizer.h: Removed.
- UIProcess/qt/QtWebContext.cpp: Removed.
- UIProcess/qt/QtWebContext.h: Removed.
- UIProcess/qt/QtWebError.cpp: Removed.
- UIProcess/qt/QtWebError.h: Removed.
- UIProcess/qt/QtWebIconDatabaseClient.cpp: Removed.
- UIProcess/qt/QtWebIconDatabaseClient.h: Removed.
- UIProcess/qt/QtWebPageEventHandler.cpp: Removed.
- UIProcess/qt/QtWebPageEventHandler.h: Removed.
- UIProcess/qt/QtWebPagePolicyClient.cpp: Removed.
- UIProcess/qt/QtWebPagePolicyClient.h: Removed.
- UIProcess/qt/QtWebPageSGNode.cpp: Removed.
- UIProcess/qt/QtWebPageSGNode.h: Removed.
- UIProcess/qt/QtWebPageUIClient.cpp: Removed.
- UIProcess/qt/QtWebPageUIClient.h: Removed.
- UIProcess/qt/TextCheckerQt.cpp: Removed.
- UIProcess/qt/WebColorPickerQt.cpp: Removed.
- UIProcess/qt/WebColorPickerQt.h: Removed.
- UIProcess/qt/WebContextMenuProxyQt.cpp: Removed.
- UIProcess/qt/WebContextMenuProxyQt.h: Removed.
- UIProcess/qt/WebContextQt.cpp: Removed.
- UIProcess/qt/WebFullScreenManagerProxyQt.cpp: Removed.
- UIProcess/qt/WebGeolocationProviderQt.cpp: Removed.
- UIProcess/qt/WebGeolocationProviderQt.h: Removed.
- UIProcess/qt/WebInspectorProxyQt.cpp: Removed.
- UIProcess/qt/WebPageProxyQt.cpp: Removed.
- UIProcess/qt/WebPopupMenuProxyQt.cpp: Removed.
- UIProcess/qt/WebPopupMenuProxyQt.h: Removed.
- UIProcess/qt/WebPreferencesQt.cpp: Removed.
- UIProcess/qt/WebProcessProxyQt.cpp: Removed.
- WebKit2.pri: Removed.
- WebKit2.pro: Removed.
- WebProcess.pro: Removed.
- WebProcess/Cookies/qt/WebCookieManagerQt.cpp: Removed.
- WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
- WebProcess/Plugins/Netscape/qt/PluginProxyQt.cpp: Removed.
- WebProcess/WebCoreSupport/qt/WebContextMenuClientQt.cpp: Removed.
- WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp: Removed.
- WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp: Removed.
- WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp: Removed.
- WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h: Removed.
- WebProcess/WebCoreSupport/qt/WebPopupMenuQt.cpp: Removed.
- WebProcess/WebPage/qt/WebInspectorQt.cpp: Removed.
- WebProcess/WebPage/qt/WebPageQt.cpp: Removed.
- WebProcess/qt/QtBuiltinBundle.cpp: Removed.
- WebProcess/qt/QtBuiltinBundle.h: Removed.
- WebProcess/qt/QtBuiltinBundlePage.cpp: Removed.
- WebProcess/qt/QtBuiltinBundlePage.h: Removed.
- WebProcess/qt/QtNetworkAccessManager.cpp: Removed.
- WebProcess/qt/QtNetworkAccessManager.h: Removed.
- WebProcess/qt/QtNetworkReply.cpp: Removed.
- WebProcess/qt/QtNetworkReply.h: Removed.
- WebProcess/qt/SeccompFiltersWebProcessQt.cpp: Removed.
- WebProcess/qt/SeccompFiltersWebProcessQt.h: Removed.
- WebProcess/qt/WebProcessMainQt.cpp: Removed.
- WebProcess/qt/WebProcessQt.cpp: Removed.
- qt/MainQt.cpp: Removed.
- qt/PluginMainQt.cpp: Removed.
- 11:05 AM Changeset in webkit [156844] by
-
- 2 edits in trunk/LayoutTests
Add test expectation for one more test having color space issues after r156793.
(css3/filters/custom/custom-filter-composite-fractional-source-alpha.html)
- platform/mac-wk2/TestExpectations:
- 10:58 AM Changeset in webkit [156843] by
-
- 2 edits in trunk/LayoutTests
Layout Test media/click-volume-bar-not-pausing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122126
- platform/mac/TestExpectations: Marked it as such.
- 10:55 AM Changeset in webkit [156842] by
-
- 10 edits in trunk/Source
Move IDBFactoryBackend creation to DatabaseStrategy.
https://bugs.webkit.org/show_bug.cgi?id=122284
Reviewed by Alexey Proskuryakov.
Source/WebCore:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBFactory.h:
- Modules/indexeddb/IDBFactoryBackendInterface.cpp:
(WebCore::IDBFactoryBackendInterface::create):
- platform/DatabaseStrategy.cpp:
(WebCore::DatabaseStrategy::createIDBFactoryBackend): Implement a default.
- platform/DatabaseStrategy.h:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createIDBFactoryBackend): Fallback to the default for now.
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 10:45 AM Changeset in webkit [156841] by
-
- 1 edit2 adds in trunk/LayoutTests
Re-add Qt TestExpectations. Without it, the flakiness dashboard page loads as blank.
- platform/qt: Added.
- platform/qt/TestExpectations: Added.
- 10:29 AM Changeset in webkit [156840] by
-
- 2 edits in trunk/Tools
REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
https://bugs.webkit.org/show_bug.cgi?id=122260
Reviewed by Alexey Proskuryakov.
For the API to work, the tests need to be compiled with a newer version of the LLVM
compiler. Until the bots are updated to that version, disable the tests on 10.8.
- TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
- 10:24 AM Changeset in webkit [156839] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile error with VIDEO disabled.
https://bugs.webkit.org/show_bug.cgi?id=122266
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-03
Reviewed by Brent Fulgham.
- dom/Document.cpp:
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent): Protect with ENABLE(VIDEO) guard.
- 10:20 AM Changeset in webkit [156838] by
-
- 6 edits6 adds in trunk
[CSS Shapes] add shape-margin support for image valued shapes
https://bugs.webkit.org/show_bug.cgi?id=121619
Reviewed by Alexandru Chiculita.
Source/WebCore:
Add support for computing the shape-margin boundary for a shape-outside whose
value is an image.
Tests: fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-001.html
fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-002.html
fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-003.html
- rendering/shapes/RasterShape.cpp:
(WebCore::MarginIntervalGenerator::MarginIntervalGenerator): Internal utility that generates the margin intervals for the image interval specified with set().
(WebCore::MarginIntervalGenerator::set):
(WebCore::MarginIntervalGenerator::intervalAt):
(WebCore::findInsertionPoint): Find the insertion point index for the the specified X value, within a vector of intervals sorted by X1.
(WebCore::RasterShapeIntervals::uniteMarginInterval): Destructively unite one interval with an existing one, or append it.
(WebCore::RasterShapeIntervals::computeShapeMarginIntervals):
(WebCore::RasterShape::marginIntervals): Return the lazily computed value, or create it with computeShapeMarginIntervals().
- rendering/shapes/RasterShape.h:
(WebCore::RasterShapeIntervals::getIntervals):
(WebCore::RasterShape::RasterShape):
(WebCore::RasterShapeIntervals::uniteMarginInterval):
- WTF/wtf/MathExtras.h: Added clampToUnsigned() inline.
LayoutTests:
Verify that the shape-outside margin-boundary is computed correctly for image valued shapes.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-001-expected.txt: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-001.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-002-expected.txt: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-002.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-003-expected.txt: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-003.html: Added.
- 10:12 AM Changeset in webkit [156837] by
-
- 2 edits in trunk/Source/JavaScriptCore
[EFL] [DEBUG] JavaScriptCore fails to build
https://bugs.webkit.org/show_bug.cgi?id=122267
Patch by Sergio Correia <Sergio Correia> on 2013-10-03
Reviewed by Michael Saboff.
Build fails due to an expression containing comparison between signed
and unsigned integer.
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions): Add cast to avoid signed vs.
unsigned comparison warning.
- 9:02 AM Changeset in webkit [156836] by
-
- 3 edits in trunk/Source/WebCore
[CSSRegions] Remove unused RenderLayerModelObject::updateLayerIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=122262
Reviewed by Alexandru Chiculita.
All regions have layers by default therefore there is no need for this function.
No tests needed, just a minor cleanup.
- rendering/RenderLayerModelObject.cpp:
- rendering/RenderLayerModelObject.h:
- 8:21 AM Changeset in webkit [156835] by
-
- 10 edits in trunk
[ATK] Expose aria-invalid as a text attribute (not object attribute)
https://bugs.webkit.org/show_bug.cgi?id=122015
Reviewed by Chris Fleizach.
Source/WebCore:
Expose the aria-invalid attribute correctly through a text
attribute (through the AtkText interface) instead of using an
object, according to what the WAI-ARIA specs says.
http://www.w3.org/TR/wai-aria-implementation/#mapping_state-property
This will be tested by accesibility/aria-invalid.html, which should
keep passing after thanks to the changes done in the DRT and WKTR.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::invalidStatus): Update this method
to only return values recognized by the WAI-ARIA specification.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getAttributeSetForAccessibilityObject): Expose aria-invalid as a
custom text attribute 'invalid', following the lead of Firefox.
Also register that custom attribute as a AtkTextAttribute.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes): Remove exposure of aria-invalid
as an object attribute from here.
Tools:
Adapted DRT and WKTR to check the exposure of the aria-invalid
attribute as a text attribute, instead of an object attribute.
Also, done some refactoring of the code to try to keep things
simpler and more coherent, by defining new helper functions,
simplifying code, moving static variables and functions into
unnammed namespaces and so on, without altering the logic other
than for checking the text attribute for aria-invalid.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(coreAttributeToAtkAttribute): Consider 'invalid' as the name of
the attribute exposed by the ATK wrapper, not 'aria-invalid'.
Also, never return an empty string if not falling through any of
the cases checked here, and return the original attribute instead.
(atkAttributeValueToCoreAttributeValue): New helper function to
match the attributes values returned by the ATK wrapper with the
values expected by the layout tests. Moved the mappings for the
values of AXSortDirection here as well.
(getAttributeSet): New helper function to retrieve a list of
attributes (an AtkAttributeSet) from an AtkObject using the right
API depending on whether we want the object attributes or the text
attributes (in case the object implements AtkText).
(getAttributeSetValueForId): Simplified by using getAttributeSet
and atkAttributeValueToCoreAttributeValue. Also, added a new
parameter to indicater whether we are interested in object
attributes or text attributes.
(getAtkAttributeSetAsString): Ditto.
(attributesOfElement): Updated to pass the new required parameter
to getAtkAttributeSetAsString, indicating that we want the object
attributes in this case, for backwards compatibility.
(indexRangeInTable): Moved up in the file into the unnammed namespace.
(alterCurrentValue): Ditto.
(AccessibilityUIElement::stringAttributeValue): After moving most
of the code here to the new helper functions, simplified it by
just checking whether the required attribute is provided as an
object attribute or, if that's not the case, as a text attribute.
(AccessibilityUIElement::isAttributeSupported): Ditto.
(AccessibilityUIElement::intValue): Updated to pass the new
required parameter to getAttributeSetValueForId, indicating that
we want the object attributes in this case.
(AccessibilityUIElement::hasPopup): Ditto.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::coreAttributeToAtkAttribute): Same changes than for DRT.
(WTR::atkAttributeValueToCoreAttributeValue): Ditto.
(WTR::getAttributeSet): Ditto.
(WTR::getAttributeSetValueForId): Ditto.
(WTR::getAtkAttributeSetAsString): Ditto.
(WTR::attributesOfElement): Ditto.
(WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
(WTR::AccessibilityUIElement::isAttributeSupported): Ditto.
(WTR::AccessibilityUIElement::intValue): Ditto.
(WTR::AccessibilityUIElement::hasPopup): Ditto.
LayoutTests:
Updated the aria-invalid.html layout test to make sure that it
behaves as defined by the WAI-ARIA specification for values other
than 'false', 'true', 'grammar' and 'spelling'.
- accessibility/aria-invalid.html: Updated test.
- accessibility/aria-invalid-expected.txt: Updated expectations.
- 8:05 AM Changeset in webkit [156834] by
-
- 5 edits in branches/safari-537.73-branch/Source
Versioning.
- 8:03 AM Changeset in webkit [156833] by
-
- 1 copy in tags/Safari-537.73.1
New Tag.
- 3:19 AM Changeset in webkit [156832] by
-
- 1 edit2 copies in trunk/LayoutTests
Add back .htaccess files erroneously removed in r156827.
- http/tests/appcache/resources/intercept: Copied from LayoutTests/http/tests/appcache/resources/intercept.
- http/tests/uri/intercept: Copied from LayoutTests/http/tests/uri/intercept.
- 2:30 AM Changeset in webkit [156831] by
-
- 2 edits in trunk/Source/WebCore
Add the NotDeletable, OperationsNotDeletable IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=122217
Reviewed by Darin Adler.
Before adjusting the JSC bindings generator to enforce configurable operations and thus conform to the
WebIDL specification in this regard, two no-op attributes are introduced that will preserve the current
behavior of operations being non-configurable.
All the relevant interfaces will be annotated with the OperationsNotDeletable attribute first. After the
generator is properly modified, this attribute will be removed from the interfaces after checking that
the operations' configurability also matches the configurability of operations in other browser engines
and that the change introduces no regressions in tests.
The NotDeletable attribute will be used as required to annotate operations that should stay
non-configurable for backwards compatibility or cross-browser compatibility.
- bindings/scripts/IDLAttributes.txt:
- 1:43 AM Changeset in webkit [156830] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG: ConstProp the pattern ValueToInt32(Bool(x)) -> Int32(x)
https://bugs.webkit.org/show_bug.cgi?id=122263
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-03
Reviewed by Geoffrey Garen.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- 1:35 AM Changeset in webkit [156829] by
-
- 8 deletes in trunk/LayoutTests/platform
Remove Qt specific expected files and directories.
Reviewed by Csaba Osztrogonác.
- 12:58 AM Changeset in webkit [156828] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed fix of DrawingArea creation on non-Mac platforms after r156793.
std::make_unique<DrawingAreaImpl>() should be used, as before that revision.
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
- 12:35 AM Changeset in webkit [156827] by
-
- 138 deletes in trunk
Unreviewed. Remove empty directories.
- 12:33 AM Changeset in webkit [156826] by
-
- 2 edits in trunk/Source/WebCore
Remove preDispatchEventHandler and postDispatchEventHandler,
functions that are supposed to be removed in the previous commit (r156825).
- dom/Node.h:
Oct 2, 2013:
- 11:50 PM Changeset in webkit [156825] by
-
- 16 edits in trunk/Source/WebCore
Get rid of Node::preDispatchEventHandler and Node::postDispatchEventHandler
https://bugs.webkit.org/show_bug.cgi?id=122144
Reviewed by Darin Adler.
Get rid of pre/post event dispatch callbacks preDispatchEventHandler and postDispatchEventHandler since
the former was only called by HTMLMediaElement and HTMLInputElement and the latter was only called by
HTMLInputElement.
Explicitly call HTMLMediaElement's willDispatchFullScreenChangeEvent in fullScreenChangeDelayTimerFired
of Document since this is the only place that fires the fullscreenchange event.
Also add an explicit call to willDispatchEvent and didDispatchClickEvent in EventDispatcher::dispatch.
This also allows us to stack-allocate InputElementClickHandlingState instead of having willDispatchEvent
heap-allocate it and pass it around as void*.
- WebCore.order:
- dom/Document.cpp:
(WebCore::Document::fullScreenChangeDelayTimerFired):
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent):
- dom/Document.h:
- dom/EventContext.cpp:
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatch):
(WebCore::EventDispatcher::callWillDispatchEventOnInputElement):
(WebCore::EventDispatcher::dispatchEventPostProcess):
- dom/EventDispatcher.h:
- html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::willDispatchClick):
- html/CheckboxInputType.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::willDispatchEvent):
(WebCore::HTMLInputElement::didDispatchClickEvent):
- html/HTMLInputElement.h:
- html/HTMLMediaElement.cpp:
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::willDispatchFullScreenChangeEvent): Renamed from preDispatchEventHandler.
- html/HTMLTextFormControlElement.h:
- html/InputType.cpp:
(WebCore::InputType::willDispatchClick):
- html/InputType.h:
- html/RadioInputType.cpp:
(WebCore::RadioInputType::willDispatchClick):
- html/RadioInputType.h:
- 11:41 PM Changeset in webkit [156824] by
-
- 5 edits in trunk/Source/WebCore
Update binding test results after r156808 for r156769.
- bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::JSattributeOwner::finalize):
- bindings/scripts/test/JS/JSattribute.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::JSreadonlyOwner::finalize):
- bindings/scripts/test/JS/JSreadonly.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- 11:30 PM Changeset in webkit [156823] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
https://bugs.webkit.org/show_bug.cgi?id=122260
Reviewed by Mark Rowe.
For the API to work, the tests need to be compiled with a newer version of the LLVM
compiler. Until the bots are updated to that version, disable the tests on 10.8.
- API/tests/testapi.mm:
- 10:59 PM Changeset in webkit [156822] by
-
- 69 edits in trunk/Source/WebCore
Unreviewed, rolling out r156816.
http://trac.webkit.org/changeset/156816
https://bugs.webkit.org/show_bug.cgi?id=122259
broke 8 tests (Requested by kling on #webkit).
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::willRecalcStyle):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::listAttributeTargetChanged):
- html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderContainer::layout):
(WebCore::SliderThumbElement::setPositionFromValue):
(WebCore::SliderThumbElement::setPositionFromPoint):
(WebCore::SliderThumbElement::stopDragging):
- page/FrameView.cpp:
(WebCore::FrameView::setHeaderHeight):
(WebCore::FrameView::setFooterHeight):
(WebCore::FrameView::layout):
(WebCore::FrameView::setViewportConstrainedObjectsNeedLayout):
(WebCore::FrameView::scheduleRelayout):
(WebCore::FrameView::setNeedsLayout):
- page/Page.cpp:
(WebCore::Page::setPageScaleFactor):
- rendering/FlowThreadController.h:
(WebCore::FlowThreadController::setIsRenderNamedFlowThreadOrderDirty):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::relayoutShapeDescendantIfMoved):
(WebCore::RenderBlock::markShapeInsideDescendantsForLayout):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::updateBlockChildDirtyBitsBeforeLayout):
(WebCore::RenderBlock::dirtyForLayoutFromPercentageHeightDescendants):
(WebCore::RenderBlock::simplifiedNormalFlowLayout):
(WebCore::RenderBlock::simplifiedLayout):
(WebCore::RenderBlock::markFixedPositionObjectForLayoutIfNeeded):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::markPositionedObjectsForLayout):
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded):
(WebCore::RenderBlock::removePositionedObjects):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlock::getClearDelta):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::adjustPositionedBlock):
(WebCore::RenderBlockFlow::adjustBlockChildForPagination):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlockFlow::layoutInlineChildren):
(WebCore::RenderBlock::positionNewFloatOnLine):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleWillChange):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::layout):
(WebCore::RenderBox::positionLineBox):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::gatherFlexChildrenInfo):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
(WebCore::RenderDeprecatedFlexibleBox::clearLineClamp):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::insertChildInternal):
- rendering/RenderElement.h:
(WebCore::RenderElement::setAncestorLineBoxDirty):
(WebCore::RenderObject::setNeedsLayout):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::layout):
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::layoutSpecialExcludedChild):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::styleDidChange):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::prepareChildForPositionedLayout):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::invalidateRegions):
(WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout):
- rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::layoutWithFlattening):
- rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):
(WebCore::RenderFrameSet::positionFrames):
(WebCore::RenderFrameSet::positionFramesWithFlattening):
(WebCore::RenderFrameSet::continueResizing):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::logicalContentHeightForChild):
(WebCore::RenderGrid::layoutGridItems):
- rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::canvasSizeChanged):
- rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::layout):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageDimensionsChanged):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::styleDidChange):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleDidChange):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::layout):
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::updateMarqueeStyle):
- rendering/RenderMedia.cpp:
(WebCore::RenderMedia::layout):
- rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::relayoutForPagination):
(WebCore::RenderMultiColumnBlock::layoutSpecialExcludedChild):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::markContainingBlocksForLayout):
(WebCore::RenderObject::layout):
- rendering/RenderObject.h:
(WebCore::RenderObject::setNeedsLayoutAndPrefWidthsRecalc):
(WebCore::RenderObject::setNeedsPositionedMovementLayout):
(WebCore::RenderObject::setNormalChildNeedsLayout):
(WebCore::RenderObject::setPosChildNeedsLayout):
(WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
(WebCore::RenderObject::setChildNeedsLayout):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::layout):
- rendering/RenderReplica.cpp:
(WebCore::RenderReplica::layout):
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::layoutSpecialExcludedChild):
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::updateScrollbarParts):
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::layout):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
- rendering/RenderTable.h:
(WebCore::RenderTable::setNeedsSectionRecalc):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeIntrinsicPadding):
(WebCore::RenderTableCell::setCellLogicalWidth):
(WebCore::RenderTableCell::layout):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange):
(WebCore::RenderTableRow::layout):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layout):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::recalcCells):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::layoutSpecialExcludedChild):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::setNeedsLayoutOnAncestors):
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::styleDidChange):
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updateIntrinsicSize):
- rendering/RenderView.cpp:
(WebCore::RenderView::layout):
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::layout):
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::computeChildrenPreferredLogicalHeights):
- rendering/mathml/RenderMathMLScripts.cpp:
(WebCore::RenderMathMLScripts::layout):
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layout):
- rendering/svg/RenderSVGGradientStop.cpp:
(WebCore::RenderSVGGradientStop::layout):
- rendering/svg/RenderSVGHiddenContainer.cpp:
(WebCore::RenderSVGHiddenContainer::layout):
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::layout):
- rendering/svg/RenderSVGResource.cpp:
(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::registerResource):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::layout):
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::layout):
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::layout):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::layoutChildren):
- svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::svgAttributeChanged):
(WebCore::SVGClipPathElement::childrenChanged):
- svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::setFilterRes):
(WebCore::SVGFilterElement::svgAttributeChanged):
(WebCore::SVGFilterElement::childrenChanged):
- svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::svgAttributeChanged):
(WebCore::SVGGradientElement::childrenChanged):
- svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::svgAttributeChanged):
- svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::svgAttributeChanged):
(WebCore::SVGMarkerElement::childrenChanged):
- svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::svgAttributeChanged):
(WebCore::SVGMaskElement::childrenChanged):
- svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::svgAttributeChanged):
(WebCore::SVGPatternElement::childrenChanged):
- svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::svgAttributeChanged):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::updateCurrentTranslate):
- 9:31 PM Changeset in webkit [156821] by
-
- 3 edits in trunk/Websites/webkit.org
2013-10-02 Geoffrey Garen <ggaren@apple.com>
Sync'd sunspider-1.0.2 to PerformanceTests/SunSpider/hosted/sunspider-1.0.2.
- perf/sunspider-1.0.2/sunspider-1.0.2/driver.html:
- perf/sunspider-1.0.2/sunspider-1.0.2/sunspider-test-contents.js:
- 9:25 PM Changeset in webkit [156820] by
-
- 3 edits in trunk/PerformanceTests/SunSpider
Improved painting behavior in SunSpider 1.0.2
https://bugs.webkit.org/show_bug.cgi?id=122257
Reviewed by Oliver Hunt.
Individual test names with times was a good painting strategy years
back, when each benchmark took hundreds of milliseconds to run. Now,
the whole suite can finish in a a few hundres milliseconds, and things
look pretty flashy.
Instead, display a countdown that indicates which iteration of the
test we're on.
- resources/TEMPLATE.html: Work around a bug in Firefox by specifying
our style inside the .html file instead of in an external stylesheet.
Under heavy JavaScript load, Firefox neglects to apply external
stylesheets -- probably due to a starved timer.
- resources/driver-TEMPLATE.html: Delay a little between runs to ensure
that our countdown has enough time to paint.
- 8:21 PM Changeset in webkit [156819] by
-
- 5 edits in trunk/Source/WebCore
Keep SVGElementRareData in an SVGElement member instead of a hashmap.
<https://webkit.org/b/122253>
Reviewed by Antti Koivisto.
Free up another Node flag by moving SVGElement's SVG-specific rare data
to a member variable instead of tracking them in a hashmap on the side.
This grows SVGElement by one pointer, but I will make up for this in
subsequent patches.
- 7:44 PM Changeset in webkit [156818] by
-
- 7 edits in trunk/Source/JavaScriptCore
Make LLINT exception stack unwinding consistent with the JIT.
https://bugs.webkit.org/show_bug.cgi?id=122255.
Reviewed by Filip Pizlo.
Previously, the CommonSlowPaths code is expected to behave in an
inconsistent way in terms of whether to unwind the stack when handling
exceptions or not. For the LLINT, the slow path should unwind the stack
before returning. For the JIT, the slow path should not unwind the stack.
This can result in the stack being unwound twice when the exception
being handled is a TerminationException.
This patch fixes the LLINT's expectation so that it expects the same
slow path behavior as the JIT does.
- llint/LLIntExceptions.cpp:
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/CommonSlowPathsExceptions.cpp:
(JSC::CommonSlowPaths::interpreterThrowInCaller):
- 7:27 PM Changeset in webkit [156817] by
-
- 9 edits in trunk/Source/JavaScriptCore
The DFG should use always DFG::Graph methods for determining where special registers are
https://bugs.webkit.org/show_bug.cgi?id=122248
Reviewed by Michael Saboff.
This makes it possible to have the DFG use different registers than the other engines
for things like activation and arguments.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::setLocalStoreElimination):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::activationRegister):
(JSC::DFG::Graph::uncheckedActivationRegister):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::baselineArgumentsRegisterFor):
- 7:26 PM Changeset in webkit [156816] by
-
- 69 edits in trunk/Source/WebCore
Move setting of some layout bits to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=122256
Reviewed by Andreas Kling.
These bits never apply to RenderText nodes:
normalChildNeedsLayout
posChildNeedsLayout
needsSimplifiedNormalFlowLayout
normalChildNeedsLayout
positionedMovementLayout
The code for setting them can be moved to RenderElement.
Also separated the code paths for setting and clearing the bits and uninlined
everything that is not massively popular.
- 6:32 PM Changeset in webkit [156815] by
-
- 3 edits in trunk/Source/WebCore
CTTE: Drag events are only dispatched on Elements.
<https://webkit.org/b/122250>
Reviewed by Antti Koivisto.
We never dispatch drag events on non-Element nodes so tighten up the
code to operate on Elements instead.
- 5:54 PM Changeset in webkit [156814] by
-
- 10 edits3 adds in trunk
[CSS Shapes] Implement the shape-image-threshold property
https://bugs.webkit.org/show_bug.cgi?id=122216
Reviewed by Andreas Kling.
Source/WebCore:
Added support for the CSS shape-image-threshold property. This change
just enables parsing the property, it's not connected to the
Shapes code yet.
The number valued shape-image-threshold property is defined here:
http://dev.w3.org/csswg/css-shapes-1/#shape-image-threshold-property
Its computed value is clamped to the range [0, 1].
Test: fast/shapes/parsing/parsing-shape-image-threshold.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPropertyNames.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
LayoutTests:
Check parsing of the non-inherited CSS shape-image-threshold number property.
The property is defined here:
http://dev.w3.org/csswg/css-shapes-1/#shape-image-threshold-property
- fast/shapes/parsing/parsing-shape-image-threshold-expected.txt: Added.
- fast/shapes/parsing/parsing-shape-image-threshold.html: Added.
- fast/shapes/parsing/script-tests/parsing-shape-image-threshold.js: Added.
- 5:10 PM Changeset in webkit [156813] by
-
- 10 edits1 delete in trunk/Source/WebCore
Remove Qt-specific code in WebCore/plugins.
<https://webkit.org/b/122247>
Reviewed by Anders Carlsson.
Purge PLATFORM(QT) blocks and Qt-specific files.
- 5:04 PM Changeset in webkit [156812] by
-
- 1 edit7 deletes in trunk
Remove Qt related files from the root directories
https://bugs.webkit.org/show_bug.cgi?id=122249
Reviewed by Andreas Kling.
- Source/QtWebKit.pro: Removed.
- Source/api.pri: Removed.
- Source/qtwebkit.qdocconf: Removed.
- Source/sync.profile: Removed.
- Source/tests.pri: Removed.
- Source/widgetsapi.pri: Removed.
- WebKit.pro: Removed.
- 4:47 PM Changeset in webkit [156811] by
-
- 8 edits in trunk/Source/JavaScriptCore
The Objective-C API should be available in 10.8 builds
https://bugs.webkit.org/show_bug.cgi?id=122245
Reviewed by Mark Rowe.
Enabled the Objective-C API when building on OS X 10.8 with the modern Objective-C runtime,
but kept the availability attributes in API headers for 10.9 and later as they were.
- API/JSBase.h: When JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080 is defined, made
JSC_OBJC_API_ENABLED true on 10.8 and above.
- API/JSContext.h: When JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080 is defined, marked the class
as available on all OS X versions.
- API/JSManagedValue.h: Ditto.
- API/JSValue.h: Ditto.
- API/JSVirtualMachine.h: Ditto.
- Configurations/Base.xcconfig: Added JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080 to
GCC_PREPROCESSOR_DEFINITIONS.
- JavaScriptCore.xcodeproj/project.pbxproj: Added a script build phase to unifdef the
above header files with JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080 either defined or not based on
the OS X version we are targeting.
- 4:33 PM Changeset in webkit [156810] by
-
- 3 edits in trunk/Source/JavaScriptCore
Make Baseline JIT exception handling work like the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=122244
Reviewed by Filip Pizlo.
Added a jump list (m_exceptionChecks) to JIT as a common place for exception processing within
generated code. Added exceptionCheck() helpers that check for an exception which add a branch
to the list.
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
(JSC::JIT::privateCompileExceptionHandlers):
- jit/JIT.h:
(JSC::JIT::exceptionCheck):
- 4:33 PM Changeset in webkit [156809] by
-
- 6 edits1 add in trunk/Source/WebInspectorUI
Web Inspector: save and restore source positions in back/forward history
https://bugs.webkit.org/show_bug.cgi?id=122062
Patch by Brian J. Burg <Brian Burg> on 2013-10-02
Reviewed by Timothy Hatcher.
Previously, the back/forward entries comprised of only the content
views, but not their positions if navigated via hyperlink (i.e.,
handling script.js:42). When multiple instances of the same
content view appeared in the back/forward list, the most recent
navigation was displayed rather than the linked position.
We now store context necessary to re-navigate such hyperlinks by
storing view- specific data inside a cookie object, and invoke a
supplied callback to take any position initialization actions,
such as calling TextEditor.revealPosition. This state is
encapsulated into BackForwardEntry instances.
Functions that save and restore scroll positions inside content
views have been changed to store state in BackForwardEntry
instances, so multiple scroll positions can be saved for a content
view appearing in the navigation history more than once.
- UserInterface/BackForwardEntry.js: Added.
(WebInspector.BackForwardEntry):
(WebInspector.BackForwardEntry.prototype.get contentView):
(WebInspector.BackForwardEntry.prototype.get cookie):
(WebInspector.BackForwardEntry.prototype.prepareToShow):
(WebInspector.BackForwardEntry.prototype.prepareToHide):
(WebInspector.BackForwardEntry.prototype._restoreFromCookie):
(WebInspector.BackForwardEntry.prototype._restoreScrollPositions):
(WebInspector.BackForwardEntry.prototype._saveScrollPositions):
- UserInterface/ContentBrowser.js:
(WebInspector.ContentBrowser.prototype.showContentView):
(WebInspector.ContentBrowser.prototype._updateContentViewNavigationItems):
(WebInspector.ContentBrowser.prototype._updateFindBanner):
- UserInterface/ContentViewContainer.js:
(WebInspector.ContentViewContainer.prototype.get currentContentView):
(WebInspector.ContentViewContainer.prototype.get currentBackForwardEntry):
(WebInspector.ContentViewContainer.prototype.showContentView):
(WebInspector.ContentViewContainer.prototype.showBackForwardEntryForIndex):
(WebInspector.ContentViewContainer.prototype.replaceContentView):
(WebInspector.ContentViewContainer.prototype.closeAllContentViewsOfPrototype):
(WebInspector.ContentViewContainer.prototype.closeAllContentViews):
(WebInspector.ContentViewContainer.prototype.goBack):
(WebInspector.ContentViewContainer.prototype.goForward):
(WebInspector.ContentViewContainer.prototype.shown):
(WebInspector.ContentViewContainer.prototype.hidden):
(WebInspector.ContentViewContainer.prototype._showEntry):
(WebInspector.ContentViewContainer.prototype._hideEntry):
- UserInterface/Main.html:
- UserInterface/Main.js:
(WebInspector.openURL):
- UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype.restoreCallback):
(WebInspector.ResourceSidebarPanel.prototype.showSourceCode):
- 4:32 PM Changeset in webkit [156808] by
-
- 14 edits22 adds in trunk/Source/WebCore
IDL parser should remove a leading "_" from identifier names
https://bugs.webkit.org/show_bug.cgi?id=122239
Reviewed by Jer Noble.
No new tests, updated bindings tests and results.
- bindings/scripts/IDLParser.pm:
(identifierRemoveNullablePrefix): Remove leading "_".
(parseInterface): Call identifierRemoveNullablePrefix.
(parseException): Ditto.
(parseEnum): Ditto.
(parseConst): Ditto.
(parseAttributeRest): Ditto.
(parseOperationRest): Ditto.
(parseOptionalOrRequiredArgument): Ditto.
(parseExceptionField): Ditto.
(parseNonAnyType): Ditto.
Update tests and results.
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
- bindings/scripts/test/CPP/WebDOMTestObj.h:
- bindings/scripts/test/CPP/WebDOMattribute.cpp: Added.
- bindings/scripts/test/CPP/WebDOMattribute.h: Added.
- bindings/scripts/test/CPP/WebDOMreadonly.cpp: Added.
- bindings/scripts/test/CPP/WebDOMreadonly.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.symbols:
- bindings/scripts/test/GObject/WebKitDOMattribute.cpp: Added.
- bindings/scripts/test/GObject/WebKitDOMattribute.h: Added.
- bindings/scripts/test/GObject/WebKitDOMattribute.symbols: Added.
- bindings/scripts/test/GObject/WebKitDOMattributePrivate.h: Added.
- bindings/scripts/test/GObject/WebKitDOMreadonly.cpp: Added.
- bindings/scripts/test/GObject/WebKitDOMreadonly.h: Added.
- bindings/scripts/test/GObject/WebKitDOMreadonly.symbols: Added.
- bindings/scripts/test/GObject/WebKitDOMreadonlyPrivate.h: Added.
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/JS/JSattribute.cpp: Added.
- bindings/scripts/test/JS/JSattribute.h: Added.
- bindings/scripts/test/JS/JSreadonly.cpp: Added.
- bindings/scripts/test/JS/JSreadonly.h: Added.
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
- bindings/scripts/test/ObjC/DOMattribute.h: Added.
- bindings/scripts/test/ObjC/DOMattribute.mm: Added.
- bindings/scripts/test/ObjC/DOMattributeInternal.h: Added.
- bindings/scripts/test/ObjC/DOMreadonly.h: Added.
- bindings/scripts/test/ObjC/DOMreadonly.mm: Added.
- bindings/scripts/test/ObjC/DOMreadonlyInternal.h: Added.
- bindings/scripts/test/TestException.idl:
- bindings/scripts/test/TestInterface.idl:
- bindings/scripts/test/TestObj.idl:
- 4:29 PM Changeset in webkit [156807] by
-
- 8 edits in trunk/LayoutTests
[CSS Regions] Helper functions for selection layout tests
https://bugs.webkit.org/show_bug.cgi?id=122128
Reviewed by Alexandru Chiculita.
Create new common JavaScript methods for CSS Regions layout tests
related to selection. Refactored tests in order to use them.
- fast/regions/resources/helper.js: Added new functions.
(selectContentByRange): Select from start to end position.
(selectContentByIds): Select from the beginning of the first element to the end
of the second one.
(selectBaseAndExtent): Select from start to end with given offsets using
Selection.setBaseAndExtent() method.
(mouseClick): Clicks in a given position.
- fast/regions/selection/selecting-text-in-empty-region.html: Refactored
test in order to use the new functions.
- fast/regions/selection/selecting-text-through-different-region-flows-2-expected.html:
Ditto.
- fast/regions/selection/selecting-text-through-different-region-flows-2.html:
Ditto.
- fast/regions/selection/selecting-text-through-different-region-flows.html:
Ditto.
- fast/regions/selection/selection-direction-expected.html: Ditto.
- fast/regions/selection/selection-direction.html: Ditto.
- 4:27 PM Changeset in webkit [156806] by
-
- 3 edits2 adds in trunk
[css-shapes] shape-outside does not properly handle the container and the float having different writing modes
https://bugs.webkit.org/show_bug.cgi?id=122243
Reviewed by Alexandru Chiculita.
Source/WebCore:
The margin box offset needs to be computed based on the writing mode
of the container, not the writihg mode of the float itself. This
patch makes that happen.
Test: fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes.html
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):
LayoutTests:
Test that the margins and width are properly computed in the case of
different writing modes.
- fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes.html: Added.
- 4:11 PM Changeset in webkit [156805] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix MSVC build
- 3:37 PM Changeset in webkit [156804] by
-
- 10 edits1 delete in trunk/Source/WebCore
Remove Qt-specific code in WebCore/{bindings,bridge,loader,icon,testing}.
<https://webkit.org/b/122242>
Reviewed by Anders Carlsson.
Purge PLATFORM(QT) blocks and Qt-specific files.
- 3:21 PM Changeset in webkit [156803] by
-
- 2 edits in trunk/Tools
EWS build fix after the Qt EWS removal.
- QueueStatusServer/model/attachment.py:
(Attachment._calculate_queue_positions):
- 3:14 PM Changeset in webkit [156802] by
-
- 2 edits in trunk/Source/JavaScriptCore
Optimized VM access from C++ code
https://bugs.webkit.org/show_bug.cgi?id=122241
Reviewed by Filip Pizlo.
- runtime/JSScope.h:
(JSC::JSScope::vm): Use MarkedBlock instead of Heap, since both have a
pointer to the VM, and Heap is one extra load.
- 2:58 PM Changeset in webkit [156801] by
-
- 11 edits in trunk/LayoutTests
Unreviewed rebaseline, try to add newlines back that keep disappearing on me.
- platform/mac-wk2/compositing/contents-opaque/body-background-painted-expected.txt:
- platform/mac-wk2/compositing/contents-opaque/body-background-skipped-expected.txt:
- platform/mac-wk2/compositing/repaint/fixed-background-scroll-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-absolute-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
- platform/mac-wk2/compositing/tiling/rotated-tiled-clamped-expected.txt:
- platform/mac-wk2/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
- platform/mac-wk2/compositing/tiling/tile-cache-zoomed-expected.txt:
- platform/mac-wk2/compositing/tiling/tiled-layer-resize-expected.txt:
- 2:57 PM Changeset in webkit [156800] by
-
- 3 edits2 deletes in trunk/Source/WebCore
Remove Qt-specific code in WebCore/{page,accessibility}.
<https://webkit.org/b/122222>
Reviewed by Anders Carlsson.
Purge PLATFORM(QT) blocks and FooBarQt.* files.
- 2:45 PM Changeset in webkit [156799] by
-
- 8 edits1 delete in trunk/Source/WebKit2
Remove Qt code from Platform/
https://bugs.webkit.org/show_bug.cgi?id=122240
Reviewed by Andreas Kling.
- Platform/CoreIPC/Connection.h:
- Platform/Logging.cpp:
- Platform/Logging.h:
- Platform/Module.h:
- Platform/PlatformProcessIdentifier.h:
- Platform/SharedMemory.h:
- Platform/WorkQueue.h:
- Platform/qt/LoggingQt.cpp: Removed.
- Platform/qt/ModuleQt.cpp: Removed.
- Platform/qt/WorkQueueQt.cpp: Removed.
- 2:44 PM Changeset in webkit [156798] by
-
- 3 edits in trunk/Source/WebCore
[CSS Shapes] Move ShapeInsideInfo::updateSegmentsForLine implementations into the cpp
https://bugs.webkit.org/show_bug.cgi?id=122236
Reviewed by Oliver Hunt.
There is no reason for updateSegmentsForLine methods to be inline. I moved them to the cpp.
No new tests, no behavior change.
- rendering/shapes/ShapeInsideInfo.cpp:
(WebCore::ShapeInsideInfo::updateSegmentsForLine):
- rendering/shapes/ShapeInsideInfo.h:
- 2:27 PM Changeset in webkit [156797] by
-
- 10 edits25 deletes in trunk/Tools
Remove Qt code from Tools/
https://bugs.webkit.org/show_bug.cgi?id=122227
Reviewed by Andreas Kling.
- DumpRenderTree/WorkQueue.cpp:
- DumpRenderTree/blackberry/src.pro: Removed.
- DumpRenderTree/qt/DumpRenderTree.pro: Removed.
- DumpRenderTree/qt/DumpRenderTree.qrc: Removed.
- DumpRenderTree/qt/DumpRenderTreeMain.cpp: Removed.
- DumpRenderTree/qt/DumpRenderTreeQt.cpp: Removed.
- DumpRenderTree/qt/DumpRenderTreeQt.h: Removed.
- DumpRenderTree/qt/EventSenderQt.cpp: Removed.
- DumpRenderTree/qt/EventSenderQt.h: Removed.
- DumpRenderTree/qt/GCControllerQt.cpp: Removed.
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Removed.
- DumpRenderTree/qt/TestRunnerQt.cpp: Removed.
- DumpRenderTree/qt/TestRunnerQt.h: Removed.
- DumpRenderTree/qt/TextInputControllerQt.cpp: Removed.
- DumpRenderTree/qt/TextInputControllerQt.h: Removed.
- DumpRenderTree/qt/WorkQueueItemQt.cpp: Removed.
- DumpRenderTree/qt/WorkQueueItemQt.h: Removed.
- DumpRenderTree/qt/fonts/AHEM.TTF: Removed.
- DumpRenderTree/qt/resources/user.css: Removed.
- DumpRenderTree/qt/testplugin.cpp: Removed.
- DumpRenderTree/qt/testplugin.h: Removed.
- ImageDiff/ImageDiff.pro: Removed.
- ImageDiff/qt/ImageDiff.cpp: Removed.
- MiniBrowser/qt/BrowserWindow.cpp: Removed.
- MiniBrowser/qt/BrowserWindow.h: Removed.
- MiniBrowser/qt/MiniBrowser.pro: Removed.
- MiniBrowser/qt/MiniBrowser.qrc: Removed.
- MiniBrowser/qt/MiniBrowserApplication.cpp: Removed.
- MiniBrowser/qt/MiniBrowserApplication.h: Removed.
- MiniBrowser/qt/UrlLoader.cpp: Removed.
- MiniBrowser/qt/UrlLoader.h: Removed.
- MiniBrowser/qt/icons/checkbox_checked.png: Removed.
- MiniBrowser/qt/icons/checkbox_unchecked.png: Removed.
- MiniBrowser/qt/icons/contents_width.png: Removed.
- MiniBrowser/qt/icons/favicon.png: Removed.
- MiniBrowser/qt/icons/find.png: Removed.
- MiniBrowser/qt/icons/folder.png: Removed.
- MiniBrowser/qt/icons/info.png: Removed.
- MiniBrowser/qt/icons/next.png: Removed.
- MiniBrowser/qt/icons/plus.png: Removed.
- MiniBrowser/qt/icons/previous.png: Removed.
- MiniBrowser/qt/icons/refresh.png: Removed.
- MiniBrowser/qt/icons/stop.png: Removed.
- MiniBrowser/qt/icons/titlebar.png: Removed.
- MiniBrowser/qt/icons/touch.png: Removed.
- MiniBrowser/qt/icons/touchpoint.png: Removed.
- MiniBrowser/qt/icons/up.png: Removed.
- MiniBrowser/qt/js/MultiSelect.js: Removed.
- MiniBrowser/qt/main.cpp: Removed.
- MiniBrowser/qt/qml/AlertDialog.qml: Removed.
- MiniBrowser/qt/qml/AuthenticationDialog.qml: Removed.
- MiniBrowser/qt/qml/BrowserWindow.qml: Removed.
- MiniBrowser/qt/qml/CheckBox.qml: Removed.
- MiniBrowser/qt/qml/ColorChooser.qml: Removed.
- MiniBrowser/qt/qml/ConfirmDialog.qml: Removed.
- MiniBrowser/qt/qml/Dialog.qml: Removed.
- MiniBrowser/qt/qml/DialogButton.qml: Removed.
- MiniBrowser/qt/qml/DialogLineInput.qml: Removed.
- MiniBrowser/qt/qml/FilePicker.qml: Removed.
- MiniBrowser/qt/qml/ItemSelector.qml: Removed.
- MiniBrowser/qt/qml/MockTouchPoint.qml: Removed.
- MiniBrowser/qt/qml/PromptDialog.qml: Removed.
- MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Removed.
- MiniBrowser/qt/qml/ScrollIndicator.qml: Removed.
- MiniBrowser/qt/qml/ViewportInfoItem.qml: Removed.
- MiniBrowser/qt/raw/DerivedSources.pri: Removed.
- MiniBrowser/qt/raw/MiniBrowserRaw.pro: Removed.
- MiniBrowser/qt/raw/Target.pri: Removed.
- MiniBrowser/qt/raw/View.cpp: Removed.
- MiniBrowser/qt/raw/View.h: Removed.
- MiniBrowser/qt/utils.cpp: Removed.
- MiniBrowser/qt/utils.h: Removed.
- QtTestBrowser/QtTestBrowser.pro: Removed.
- QtTestBrowser/QtTestBrowser.qrc: Removed.
- QtTestBrowser/cookiejar.cpp: Removed.
- QtTestBrowser/cookiejar.h: Removed.
- QtTestBrowser/favicon.png: Removed.
- QtTestBrowser/fpstimer.cpp: Removed.
- QtTestBrowser/fpstimer.h: Removed.
- QtTestBrowser/launcherwindow.cpp: Removed.
- QtTestBrowser/launcherwindow.h: Removed.
- QtTestBrowser/locationedit.cpp: Removed.
- QtTestBrowser/locationedit.h: Removed.
- QtTestBrowser/mainwindow.cpp: Removed.
- QtTestBrowser/mainwindow.h: Removed.
- QtTestBrowser/qttestbrowser.cpp: Removed.
- QtTestBrowser/urlloader.cpp: Removed.
- QtTestBrowser/urlloader.h: Removed.
- QtTestBrowser/useragentlist.txt: Removed.
- QtTestBrowser/utils.cpp: Removed.
- QtTestBrowser/utils.h: Removed.
- QtTestBrowser/webinspector.h: Removed.
- QtTestBrowser/webpage.cpp: Removed.
- QtTestBrowser/webpage.h: Removed.
- QtTestBrowser/webview.cpp: Removed.
- QtTestBrowser/webview.h: Removed.
- TestWebKitAPI/DerivedSources.pri: Removed.
- TestWebKitAPI/InjectedBundle.pri: Removed.
- TestWebKitAPI/PlatformWebView.h:
- TestWebKitAPI/TestWebKitAPI.pri: Removed.
- TestWebKitAPI/TestWebKitAPI.pro: Removed.
- TestWebKitAPI/Tests.pri: Removed.
- TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Removed.
- TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
- TestWebKitAPI/Tests/WTF/WTF.pro: Removed.
- TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Removed.
- TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Removed.
- TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Removed.
- TestWebKitAPI/qt/PlatformWebViewQt.cpp: Removed.
- TestWebKitAPI/qt/main.cpp: Removed.
- Tools.pro: Removed.
- WebKitTestRunner/DerivedSources.pri: Removed.
- WebKitTestRunner/EventSenderProxy.h:
- WebKitTestRunner/InjectedBundle/DerivedSources.pri: Removed.
- WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Removed.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::resetAfterTest):
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
(WTR::InjectedBundlePage::didClearWindowForFrame):
- WebKitTestRunner/InjectedBundle/Target.pri: Removed.
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Removed.
- WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
- WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Removed.
- WebKitTestRunner/PlatformWebView.h:
- WebKitTestRunner/Target.pri: Removed.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/WebKitTestRunner.pro: Removed.
- WebKitTestRunner/qt/EventSenderProxyQt.cpp: Removed.
- WebKitTestRunner/qt/PlatformWebViewQt.cpp: Removed.
- WebKitTestRunner/qt/TestControllerQt.cpp: Removed.
- WebKitTestRunner/qt/TestInvocationQt.cpp: Removed.
- WebKitTestRunner/qt/WebKitTestRunner.qrc: Removed.
- WebKitTestRunner/qt/main.cpp: Removed.
- WebKitTestRunner/qt/resources/user.css: Removed.
- qmake/.qmake.cache: Removed.
- qmake/.qmake.conf: Removed.
- qmake/README: Removed.
- qmake/config.tests/README: Removed.
- qmake/config.tests/fontconfig/fontconfig.cpp: Removed.
- qmake/config.tests/fontconfig/fontconfig.pro: Removed.
- qmake/config.tests/gccdepends/empty.cpp: Removed.
- qmake/config.tests/gccdepends/gccdepends.pro: Removed.
- qmake/config.tests/glx/glx.cpp: Removed.
- qmake/config.tests/glx/glx.pro: Removed.
- qmake/config.tests/gnuld/gnuld.pro: Removed.
- qmake/config.tests/gnuld/main.cpp: Removed.
- qmake/config.tests/libXcomposite/libXcomposite.cpp: Removed.
- qmake/config.tests/libXcomposite/libXcomposite.pro: Removed.
- qmake/config.tests/libXrender/libXrender.cpp: Removed.
- qmake/config.tests/libXrender/libXrender.pro: Removed.
- qmake/config.tests/libwebp/libwebp.cpp: Removed.
- qmake/config.tests/libwebp/libwebp.pro: Removed.
- qmake/config.tests/libxml2/libxml2.cpp: Removed.
- qmake/config.tests/libxml2/libxml2.pro: Removed.
- qmake/config.tests/libxslt/libxslt.cpp: Removed.
- qmake/config.tests/libxslt/libxslt.pro: Removed.
- qmake/config.tests/libzlib/libzlib.cpp: Removed.
- qmake/config.tests/libzlib/libzlib.pro: Removed.
- qmake/dump-features.pl: Removed.
- qmake/mkspecs/features/configure.prf: Removed.
- qmake/mkspecs/features/default_post.prf: Removed.
- qmake/mkspecs/features/default_pre.prf: Removed.
- qmake/mkspecs/features/features.prf: Removed.
- qmake/mkspecs/features/features.pri: Removed.
- qmake/mkspecs/features/force_static_libs_as_shared.prf: Removed.
- qmake/mkspecs/features/functions.prf: Removed.
- qmake/mkspecs/features/gprof.prf: Removed.
- qmake/mkspecs/features/mac/default_post.prf: Removed.
- qmake/mkspecs/features/mac/default_pre.prf: Removed.
- qmake/mkspecs/features/minimal_qt.prf: Removed.
- qmake/mkspecs/features/production_build.prf: Removed.
- qmake/mkspecs/features/rpath.prf: Removed.
- qmake/mkspecs/features/unix/default_post.prf: Removed.
- qmake/mkspecs/features/unix/default_pre.prf: Removed.
- qmake/mkspecs/features/unix/icc.prf: Removed.
- qmake/mkspecs/features/use_all_in_one_files.prf: Removed.
- qmake/mkspecs/features/valgrind.prf: Removed.
- qmake/mkspecs/features/webkit_modules.prf: Removed.
- qmake/mkspecs/features/win32/default_post.prf: Removed.
- qmake/mkspecs/features/win32/default_pre.prf: Removed.
- qmake/mkspecs/modules/angle.prf: Removed.
- qmake/mkspecs/modules/javascriptcore.prf: Removed.
- qmake/mkspecs/modules/webcore.prf: Removed.
- qmake/mkspecs/modules/webkit1.prf: Removed.
- qmake/mkspecs/modules/webkit2.prf: Removed.
- qmake/mkspecs/modules/wtf.prf: Removed.
- 2:24 PM Changeset in webkit [156796] by
-
- 3 edits8 moves1 add in trunk/LayoutTests
[CSS Regions] Selection layout tests moved to specific folder
https://bugs.webkit.org/show_bug.cgi?id=122099
Reviewed by Alexandru Chiculita.
Moved CSS Regions layout tests related to selection to
"fast/regions/selection/".
- fast/regions/selection/selecting-text-in-empty-region-expected.txt: Renamed from LayoutTests/fast/regions/selecting-text-in-empty-region-expected.txt.
- fast/regions/selection/selecting-text-in-empty-region.html: Renamed from LayoutTests/fast/regions/selecting-text-in-empty-region.html.
- fast/regions/selection/selecting-text-through-different-region-flows-2-expected.html: Renamed from LayoutTests/fast/regions/selecting-text-through-different-region-flows-2-expected.html.
- fast/regions/selection/selecting-text-through-different-region-flows-2.html: Renamed from LayoutTests/fast/regions/selecting-text-through-different-region-flows-2.html.
- fast/regions/selection/selecting-text-through-different-region-flows-expected.html: Renamed from LayoutTests/fast/regions/selecting-text-through-different-region-flows-expected.html.
- fast/regions/selection/selecting-text-through-different-region-flows.html: Renamed from LayoutTests/fast/regions/selecting-text-through-different-region-flows.html.
- fast/regions/selection/selection-direction-expected.html: Renamed from LayoutTests/fast/regions/selection-direction-expected.html.
- fast/regions/selection/selection-direction.html: Renamed from LayoutTests/fast/regions/selection-direction.html.
- platform/gtk-wk2/TestExpectations: Update path in skipped tests.
- platform/qt-wk2/TestExpectations: Ditto.
- 2:24 PM WebKitGTK/2.2.x edited by
- (diff)
- 2:23 PM Changeset in webkit [156795] by
-
- 79 edits11 deletes in trunk/Source/WebCore
Remove Qt from WebCore/platform.
<https://webkit.org/b/122228>
Reviewed by Anders Carlsson.
Purge PLATFORM(QT) blocks and FooBarQt.* files.
- 2:22 PM Changeset in webkit [156794] by
-
- 8 edits in trunk
The LLInt should not use JITStackFrame
https://bugs.webkit.org/show_bug.cgi?id=122231
Reviewed by Filip Pizlo.
Replaced uses of JITStackFrame::vm with code to either access the vm via the CodeBlock from
known JavaScript call frames or via the JSScope* for host call frames. This eliminates
all uses of JITStackFrame from the LLInt.
- heap/MarkedBlock.h: Made LLIntOffsetsExtractor a friend to access member offsets.
- heap/WeakSet.h: Made LLIntOffsetsExtractor a friend to access member offsets.
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions): Added an ASSERT for the newly added MarkedBlockMask
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 2:14 PM Changeset in webkit [156793] by
-
- 22 edits31 adds3 deletes in trunk
[mac] Stop using DrawingAreaImpl on PLATFORM(MAC)
https://bugs.webkit.org/show_bug.cgi?id=121859
<rdar://problem/15069359>
Reviewed by Anders Carlsson.
The Mac port will now use tiled drawing for all WebKit2 views.
- Shared/DrawingAreaInfo.h:
Don't include DrawingAreaTypeImpl as a valid DrawingAreaType on Mac.
- UIProcess/API/mac/WKView.mm:
(-[WKView drawRect:]):
Remove our implementation of drawRect that paints from DrawingAreaImpl's backing store.
(-[WKView _shouldUseTiledDrawingArea]):
Removed. Always treated as if it were true, now.
(-[WKView _createDrawingAreaProxy]):
Always create a TiledCoreAnimationDrawingAreaProxy now.
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
(-[WKView wantsUpdateLayer]):
WKView always wants a layer, etc.
- UIProcess/BackingStore.h:
Remove Mac-specific BackingStore code, only used for DrawingAreaImpl on Mac.
- UIProcess/DrawingAreaProxy.h:
Remove an unneeded include.
- UIProcess/mac/BackingStoreMac.mm: Removed.
- WebKit2.xcodeproj/project.pbxproj:
Remove a bunch of files we don't need to build anymore.
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
Never create a DrawingAreaImpl on Mac.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updatePreferences):
(WebKit::DrawingAreaImpl::resumePainting):
- WebProcess/WebPage/DrawingAreaImpl.h:
Remove Mac-specific DrawingAreaImpl code.
- WebProcess/WebPage/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::create):
- WebProcess/WebPage/mac/LayerTreeHostMac.h: Removed.
- WebProcess/WebPage/mac/LayerTreeHostMac.mm: Removed.
- page/FrameView.cpp:
(WebCore::FrameView::addTrackedRepaintRect):
(WebCore::FrameView::repaintContentRectangle):
- page/FrameView.h:
Factor out the coordinate conversion and appending of new repaint rects on FrameView.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::dumpProperties):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::shouldDumpPropertyForLayer):
Don't dump repaint rects on the root tile cache, they'll be included at the top,
where FrameView's repaints are normally included.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setContentsNeedDisplay):
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
Push the root tile cache's tracked repaint rects to FrameView instead.
- WebKitTestRunner/TestInvocation.cpp:
(WTR::shouldUseThreadedScrolling):
(WTR::updateThreadedScrollingForCurrentTest):
(WTR::TestInvocation::invoke):
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]):
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):
Rename the tiled drawing switch to threaded scrolling, since that's really
all it switches now that we use tiled drawing everywhere.
Use an unbuffered window, as well, to avoid snapshotting issues on some platforms
and to more closely match the case we're interested in testing.
- platform/mac-wk2/TestExpectations:
- platform/mac-wk2/compositing/contents-opaque/body-background-painted-expected.txt: Added.
- platform/mac-wk2/compositing/contents-opaque/body-background-skipped-expected.txt: Added.
- platform/mac-wk2/compositing/rtl/rtl-absolute-expected.txt: Added.
- platform/mac-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
- platform/mac-wk2/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Added.
Add WebKit2 results, because we dump non-white background color on the root layer now.
- platform/mac-wk2/compositing/repaint/fixed-background-scroll-expected.txt: Added.
New WebKit2 result; repaint rects are showing up now.
- platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
- platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
Slightly adjusted results.
- platform/mac-wk2/compositing/tiling/rotated-tiled-clamped-expected.txt: Added.
- platform/mac-wk2/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Added.
- platform/mac-wk2/compositing/tiling/tile-cache-zoomed-expected.txt: Added.
- platform/mac-wk2/compositing/tiling/tiled-layer-resize-expected.txt: Added.
New WebKit2 results; we show the root tile cache if layerTreeAsText is asked to dump tile caches.
- platform/mac-wk2/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
- platform/mac-wk2/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
- platform/mac-wk2/fast/block/basic/020-expected.txt: Added.
- platform/mac-wk2/fast/dynamic/012-expected.txt: Added.
- platform/mac-wk2/fast/dynamic/layer-hit-test-crash-expected.txt: Added.
- platform/mac-wk2/fast/repaint/layer-hide-when-needs-layout-expected.txt: Added.
- platform/mac-wk2/fast/text/whitespace/028-expected.txt: Added.
- platform/mac-wk2/fast/layers/layer-visibility-expected.txt: Added.
- platform/mac-wk2/fast/layers/layer-visibility-sublayer-expected.txt: Added.
- platform/mac-wk2/fast/repaint/invisible-objects-expected.txt: Added.
New WebKit2 results; additional compositing layers.
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Added.
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Added.
New test to ensure that window-server snapshots work with tiled drawing.
- 1:34 PM Changeset in webkit [156792] by
-
- 2 edits in trunk/Source/WTF
Eliminate a branch in FastBitVector setAndCheck, make it vectorizable.
https://bugs.webkit.org/show_bug.cgi?id=122229
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-02
Reviewed by Geoffrey Garen.
The CPU is unlikely to predict the branch in setAndCheck. I changed the code to use conditional instructions.
- wtf/FastBitVector.h:
(WTF::FastBitVector::setAndCheck):
- 1:34 PM Changeset in webkit [156791] by
-
- 13 edits9 adds in trunk
Implement Array key, value and entries iterators
https://bugs.webkit.org/show_bug.cgi?id=122195
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Add implementation of ES6 Array iterators for keys(), values() and entries()
Fairly self explanatory as we just need a simple implementation so that we can
implement and test other features.
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/ArrayIteratorConstructor.cpp: Added.
(JSC::ArrayIteratorConstructor::finishCreation):
- runtime/ArrayIteratorConstructor.h: Added.
(JSC::ArrayIteratorConstructor::create):
(JSC::ArrayIteratorConstructor::createStructure):
(JSC::ArrayIteratorConstructor::ArrayIteratorConstructor):
- runtime/ArrayIteratorPrototype.cpp: Added.
(JSC::ArrayIteratorPrototype::finishCreation):
(JSC::createIteratorResult):
(JSC::arrayIteratorPrototypeNext):
- runtime/ArrayIteratorPrototype.h: Added.
(JSC::ArrayIteratorPrototype::create):
(JSC::ArrayIteratorPrototype::createStructure):
(JSC::ArrayIteratorPrototype::ArrayIteratorPrototype):
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncValues):
(JSC::arrayProtoFuncEntries):
(JSC::arrayProtoFuncKeys):
- runtime/CommonIdentifiers.h:
- runtime/Identifier.h:
(JSC::Identifier::createEmptyUnique):
- runtime/JSArrayIterator.cpp: Added.
(JSC::JSArrayIterator::finishCreation):
- runtime/JSArrayIterator.h: Added.
(JSC::JSArrayIterator::createStructure):
(JSC::JSArrayIterator::create):
(JSC::JSArrayIterator::iterationKind):
(JSC::JSArrayIterator::iteratedObject):
(JSC::JSArrayIterator::nextIndex):
(JSC::JSArrayIterator::setNextIndex):
(JSC::JSArrayIterator::finish):
(JSC::JSArrayIterator::JSArrayIterator):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::iteratorResultStructure):
LayoutTests:
Add tests
- js/Object-getOwnPropertyNames-expected.txt:
- js/array-iterators-expected.txt: Added.
- js/array-iterators.html: Added.
- js/script-tests/Object-getOwnPropertyNames.js:
- js/script-tests/array-iterators.js: Added.
- 1:31 PM Changeset in webkit [156790] by
-
- 1 edit in branches/safari-537.73-branch/LayoutTests/platform/mac-wk2/TestExpectations
Merge 156783.
- 1:16 PM Changeset in webkit [156789] by
-
- 2 edits in trunk/Source/WebKit/win
[Windows] Unreviewed build fix.
- WebScriptWorld.cpp:
(WebScriptWorld::findOrCreateWorld):
- 12:55 PM Changeset in webkit [156788] by
-
- 6 edits in trunk/Source/WebCore
Clean up more <style scoped> from style resolution
https://bugs.webkit.org/show_bug.cgi?id=122188
Reviewed by Darin Adler.
- css/ElementRuleCollector.cpp:
(WebCore::MatchRequest::MatchRequest):
(WebCore::ElementRuleCollector::collectMatchingRules):
(WebCore::ElementRuleCollector::collectMatchingRulesForRegion):
(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::ruleMatches):
(WebCore::ElementRuleCollector::doCollectMatchingRulesForList):
- css/ElementRuleCollector.h:
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively):
- css/SelectorChecker.h:
(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::selectorMatches):
- 12:38 PM Changeset in webkit [156787] by
-
- 2 edits in trunk/Source/JavaScriptCore
get_callee and to_this aren't properly cleared during finalizeUnconditionally
https://bugs.webkit.org/show_bug.cgi?id=122224
Reviewed by Geoffrey Garen.
Even though there is code to clear unmarked inline cache objects in finalizeUnconditionally,
it will never run because get_callee and to_this weren't added to the proper Vector in the
UnlinkedCodeBlock that is iterated during finalizeUnconditionally.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCreateThis):
- 12:16 PM Changeset in webkit [156786] by
-
- 2 edits1 move in trunk/Tools
Move AHEM.TTF from qt/fonts/ to fonts/.
Rubber-stamped by Andreas Kling.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/fonts/AHEM.TTF: Renamed from Tools/DumpRenderTree/qt/fonts/AHEM.TTF.
- 12:11 PM Changeset in webkit [156785] by
-
- 19 edits12 adds in trunk
Implement prefixed-destructuring assignment
https://bugs.webkit.org/show_bug.cgi?id=121930
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
Relanding with fix after rollout - it helps to not completely destroy
optimisations for no reason.
LayoutTests:
Relanding with fix after rollout - it helps to not completely destroy
optimisations for no reason.
- 11:52 AM Changeset in webkit [156784] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL: Refactor compileArithDiv and compileArithMod into one function.
https://bugs.webkit.org/show_bug.cgi?id=122205
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-02
Reviewed by Filip Pizlo.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileAddSub):
(JSC::FTL::LowerDFGToLLVM::compileArithDivMod):
- 11:34 AM WebKitGTK/2.2.x edited by
- (diff)
- 11:29 AM Changeset in webkit [156783] by
-
- 1 edit in branches/safari-537-branch/LayoutTests/platform/mac-wk2/TestExpectations
Update Test Expectations.
- 11:23 AM Changeset in webkit [156782] by
-
- 25 edits in trunk/Source/WebCore
Update bindings test results.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectOwner::finalize):
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterOwner::finalize):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorOwner::finalize):
- bindings/scripts/test/JS/JSTestEventConstructor.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetOwner::finalize):
- bindings/scripts/test/JS/JSTestEventTarget.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionOwner::finalize):
- bindings/scripts/test/JS/JSTestException.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceOwner::finalize):
- bindings/scripts/test/JS/JSTestInterface.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerOwner::finalize):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorOwner::finalize):
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjOwner::finalize):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsOwner::finalize):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsOwner::finalize):
- bindings/scripts/test/JS/JSTestTypedefs.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
- 11:20 AM Changeset in webkit [156781] by
-
- 1 edit263 deletes in trunk/Source/WebKit
Remove WebKit/qt.
Rubber-stamped by Andreas Kling.
- qt/Api/qhttpheader.cpp: Removed.
- qt/Api/qhttpheader_p.h: Removed.
- qt/Api/qwebdatabase.cpp: Removed.
- qt/Api/qwebdatabase.h: Removed.
- qt/Api/qwebdatabase_p.h: Removed.
- qt/Api/qwebelement.cpp: Removed.
- qt/Api/qwebelement.h: Removed.
- qt/Api/qwebelement_p.h: Removed.
- qt/Api/qwebhistory.cpp: Removed.
- qt/Api/qwebhistory.h: Removed.
- qt/Api/qwebhistory_p.h: Removed.
- qt/Api/qwebhistoryinterface.cpp: Removed.
- qt/Api/qwebhistoryinterface.h: Removed.
- qt/Api/qwebkitglobal.cpp: Removed.
- qt/Api/qwebkitglobal.h: Removed.
- qt/Api/qwebkitplatformplugin.h: Removed.
- qt/Api/qwebplugindatabase.cpp: Removed.
- qt/Api/qwebplugindatabase_p.h: Removed.
- qt/Api/qwebpluginfactory.cpp: Removed.
- qt/Api/qwebpluginfactory.h: Removed.
- qt/Api/qwebscriptworld.cpp: Removed.
- qt/Api/qwebscriptworld.h: Removed.
- qt/Api/qwebscriptworld_p.h: Removed.
- qt/Api/qwebsecurityorigin.cpp: Removed.
- qt/Api/qwebsecurityorigin.h: Removed.
- qt/Api/qwebsecurityorigin_p.h: Removed.
- qt/Api/qwebsettings.cpp: Removed.
- qt/Api/qwebsettings.h: Removed.
- qt/ChangeLog-2011-02-16: Removed.
- qt/WebCoreSupport/ChromeClientQt.cpp: Removed.
- qt/WebCoreSupport/ChromeClientQt.h: Removed.
- qt/WebCoreSupport/ContextMenuClientQt.cpp: Removed.
- qt/WebCoreSupport/ContextMenuClientQt.h: Removed.
- qt/WebCoreSupport/DragClientQt.cpp: Removed.
- qt/WebCoreSupport/DragClientQt.h: Removed.
- qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp: Removed.
- qt/WebCoreSupport/DumpRenderTreeSupportQt.h: Removed.
- qt/WebCoreSupport/EditorClientQt.cpp: Removed.
- qt/WebCoreSupport/EditorClientQt.h: Removed.
- qt/WebCoreSupport/FrameLoaderClientQt.cpp: Removed.
- qt/WebCoreSupport/FrameLoaderClientQt.h: Removed.
- qt/WebCoreSupport/FrameNetworkingContextQt.cpp: Removed.
- qt/WebCoreSupport/FrameNetworkingContextQt.h: Removed.
- qt/WebCoreSupport/FullScreenVideoQt.cpp: Removed.
- qt/WebCoreSupport/FullScreenVideoQt.h: Removed.
- qt/WebCoreSupport/GeolocationClientQt.cpp: Removed.
- qt/WebCoreSupport/GeolocationClientQt.h: Removed.
- qt/WebCoreSupport/GeolocationPermissionClientQt.cpp: Removed.
- qt/WebCoreSupport/GeolocationPermissionClientQt.h: Removed.
- qt/WebCoreSupport/IconDatabaseClientQt.cpp: Removed.
- qt/WebCoreSupport/IconDatabaseClientQt.h: Removed.
- qt/WebCoreSupport/InitWebCoreQt.cpp: Removed.
- qt/WebCoreSupport/InitWebCoreQt.h: Removed.
- qt/WebCoreSupport/InspectorClientQt.cpp: Removed.
- qt/WebCoreSupport/InspectorClientQt.h: Removed.
- qt/WebCoreSupport/InspectorServerQt.cpp: Removed.
- qt/WebCoreSupport/InspectorServerQt.h: Removed.
- qt/WebCoreSupport/NotificationPresenterClientQt.cpp: Removed.
- qt/WebCoreSupport/NotificationPresenterClientQt.h: Removed.
- qt/WebCoreSupport/PlatformStrategiesQt.cpp: Removed.
- qt/WebCoreSupport/PlatformStrategiesQt.h: Removed.
- qt/WebCoreSupport/PopupMenuQt.cpp: Removed.
- qt/WebCoreSupport/PopupMenuQt.h: Removed.
- qt/WebCoreSupport/QWebFrameAdapter.cpp: Removed.
- qt/WebCoreSupport/QWebFrameAdapter.h: Removed.
- qt/WebCoreSupport/QWebPageAdapter.cpp: Removed.
- qt/WebCoreSupport/QWebPageAdapter.h: Removed.
- qt/WebCoreSupport/QtPlatformPlugin.cpp: Removed.
- qt/WebCoreSupport/QtPlatformPlugin.h: Removed.
- qt/WebCoreSupport/QtPluginWidgetAdapter.cpp: Removed.
- qt/WebCoreSupport/QtPluginWidgetAdapter.h: Removed.
- qt/WebCoreSupport/QtPrintContext.cpp: Removed.
- qt/WebCoreSupport/QtPrintContext.h: Removed.
- qt/WebCoreSupport/SearchPopupMenuQt.cpp: Removed.
- qt/WebCoreSupport/SearchPopupMenuQt.h: Removed.
- qt/WebCoreSupport/TextCheckerClientQt.cpp: Removed.
- qt/WebCoreSupport/TextCheckerClientQt.h: Removed.
- qt/WebCoreSupport/TextureMapperLayerClientQt.cpp: Removed.
- qt/WebCoreSupport/TextureMapperLayerClientQt.h: Removed.
- qt/WebCoreSupport/UndoStepQt.cpp: Removed.
- qt/WebCoreSupport/UndoStepQt.h: Removed.
- qt/WebCoreSupport/WebEventConversion.cpp: Removed.
- qt/WebCoreSupport/WebEventConversion.h: Removed.
- qt/WidgetApi/qgraphicswebview.cpp: Removed.
- qt/WidgetApi/qgraphicswebview.h: Removed.
- qt/WidgetApi/qwebframe.cpp: Removed.
- qt/WidgetApi/qwebframe.h: Removed.
- qt/WidgetApi/qwebframe_p.h: Removed.
- qt/WidgetApi/qwebinspector.cpp: Removed.
- qt/WidgetApi/qwebinspector.h: Removed.
- qt/WidgetApi/qwebinspector_p.h: Removed.
- qt/WidgetApi/qwebpage.cpp: Removed.
- qt/WidgetApi/qwebpage.h: Removed.
- qt/WidgetApi/qwebpage_p.h: Removed.
- qt/WidgetApi/qwebview.cpp: Removed.
- qt/WidgetApi/qwebview.h: Removed.
- qt/WidgetApi/qwebviewaccessible.cpp: Removed.
- qt/WidgetApi/qwebviewaccessible_p.h: Removed.
- qt/WidgetSupport/DefaultFullScreenVideoHandler.cpp: Removed.
- qt/WidgetSupport/DefaultFullScreenVideoHandler.h: Removed.
- qt/WidgetSupport/FullScreenVideoWidget.cpp: Removed.
- qt/WidgetSupport/FullScreenVideoWidget.h: Removed.
- qt/WidgetSupport/InitWebKitQt.cpp: Removed.
- qt/WidgetSupport/InitWebKitQt.h: Removed.
- qt/WidgetSupport/InspectorClientWebPage.cpp: Removed.
- qt/WidgetSupport/InspectorClientWebPage.h: Removed.
- qt/WidgetSupport/PageClientQt.cpp: Removed.
- qt/WidgetSupport/PageClientQt.h: Removed.
- qt/WidgetSupport/QGraphicsWidgetPluginImpl.cpp: Removed.
- qt/WidgetSupport/QGraphicsWidgetPluginImpl.h: Removed.
- qt/WidgetSupport/QStyleFacadeImp.cpp: Removed.
- qt/WidgetSupport/QStyleFacadeImp.h: Removed.
- qt/WidgetSupport/QWebUndoCommand.cpp: Removed.
- qt/WidgetSupport/QWebUndoCommand.h: Removed.
- qt/WidgetSupport/QWidgetPluginImpl.cpp: Removed.
- qt/WidgetSupport/QWidgetPluginImpl.h: Removed.
- qt/WidgetSupport/QtFallbackWebPopup.cpp: Removed.
- qt/WidgetSupport/QtFallbackWebPopup.h: Removed.
- qt/WidgetSupport/QtWebComboBox.cpp: Removed.
- qt/WidgetSupport/QtWebComboBox.h: Removed.
- qt/declarative/declarative.pro: Removed.
- qt/declarative/experimental/experimental.pri: Removed.
- qt/declarative/experimental/plugin.cpp: Removed.
- qt/declarative/experimental/plugin.json: Removed.
- qt/declarative/experimental/qmldir: Removed.
- qt/declarative/plugin.cpp: Removed.
- qt/declarative/plugin.json: Removed.
- qt/declarative/plugins.qmltypes: Removed.
- qt/declarative/public.pri: Removed.
- qt/declarative/qmldir: Removed.
- qt/docs/qtwebkit-bridge.qdoc: Removed.
- qt/docs/qtwebkit-goes-mobile.qdoc: Removed.
- qt/docs/qtwebkit.qdoc: Removed.
- qt/docs/qwebview-diagram.png: Removed.
- qt/docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: Removed.
- qt/docs/webkitsnippets/qtwebkit_build_snippet.qdoc: Removed.
- qt/docs/webkitsnippets/qtwebkit_goes_mobile_snippets.cpp: Removed.
- qt/docs/webkitsnippets/qtwebkit_qwebinspector_snippet.cpp: Removed.
- qt/docs/webkitsnippets/qtwebkit_qwebview_snippet.cpp: Removed.
- qt/docs/webkitsnippets/simple/main.cpp: Removed.
- qt/docs/webkitsnippets/simple/simple.pro: Removed.
- qt/docs/webkitsnippets/webelement/main.cpp: Removed.
- qt/docs/webkitsnippets/webelement/webelement.pro: Removed.
- qt/docs/webkitsnippets/webpage/main.cpp: Removed.
- qt/docs/webkitsnippets/webpage/webpage.pro: Removed.
- qt/examples/examples.pro: Removed.
- qt/examples/platformplugin/README: Removed.
- qt/examples/platformplugin/WebNotificationPresenter.cpp: Removed.
- qt/examples/platformplugin/WebNotificationPresenter.h: Removed.
- qt/examples/platformplugin/WebPlugin.cpp: Removed.
- qt/examples/platformplugin/WebPlugin.h: Removed.
- qt/examples/platformplugin/platformplugin.pro: Removed.
- qt/examples/platformplugin/qwebkitplatformplugin.h: Removed.
- qt/tests/MIMESniffing/MIMESniffing.pro: Removed.
- qt/tests/MIMESniffing/TestData.h: Removed.
- qt/tests/MIMESniffing/resources.qrc: Removed.
- qt/tests/MIMESniffing/resources/application_atom+xml: Removed.
- qt/tests/MIMESniffing/resources/application_ogg: Removed.
- qt/tests/MIMESniffing/resources/application_pdf: Removed.
- qt/tests/MIMESniffing/resources/application_postscript: Removed.
- qt/tests/MIMESniffing/resources/application_rdf+xml: Removed.
- qt/tests/MIMESniffing/resources/application_rss+xml: Removed.
- qt/tests/MIMESniffing/resources/application_x-gzip: Removed.
- qt/tests/MIMESniffing/resources/application_x-rar-compressed: Removed.
- qt/tests/MIMESniffing/resources/application_zip: Removed.
- qt/tests/MIMESniffing/resources/audio_x-wave: Removed.
- qt/tests/MIMESniffing/resources/image_bmp: Removed.
- qt/tests/MIMESniffing/resources/image_gif: Removed.
- qt/tests/MIMESniffing/resources/image_jpeg: Removed.
- qt/tests/MIMESniffing/resources/image_png: Removed.
- qt/tests/MIMESniffing/resources/image_vnd.microsoft.icon: Removed.
- qt/tests/MIMESniffing/resources/image_webp: Removed.
- qt/tests/MIMESniffing/resources/text_html: Removed.
- qt/tests/MIMESniffing/resources/text_xml: Removed.
- qt/tests/MIMESniffing/resources/video_webm: Removed.
- qt/tests/MIMESniffing/tst_MIMESniffing.cpp: Removed.
- qt/tests/benchmarks/loading/loading.pro: Removed.
- qt/tests/benchmarks/loading/tst_loading.cpp: Removed.
- qt/tests/benchmarks/painting/painting.pro: Removed.
- qt/tests/benchmarks/painting/tst_painting.cpp: Removed.
- qt/tests/benchmarks/webgl/10000_triangles.html: Removed.
- qt/tests/benchmarks/webgl/tst_webgl.cpp: Removed.
- qt/tests/benchmarks/webgl/tst_webgl.qrc: Removed.
- qt/tests/benchmarks/webgl/webgl.pro: Removed.
- qt/tests/cmake/CMakeLists.txt: Removed.
- qt/tests/cmake/cmake.pro: Removed.
- qt/tests/hybridPixmap/hybridPixmap.pro: Removed.
- qt/tests/hybridPixmap/resources.qrc: Removed.
- qt/tests/hybridPixmap/test.html: Removed.
- qt/tests/hybridPixmap/tst_hybridPixmap.cpp: Removed.
- qt/tests/hybridPixmap/widget.cpp: Removed.
- qt/tests/hybridPixmap/widget.h: Removed.
- qt/tests/hybridPixmap/widget.ui: Removed.
- qt/tests/qgraphicswebview/qgraphicswebview.pro: Removed.
- qt/tests/qgraphicswebview/resources/greendiv.html: Removed.
- qt/tests/qgraphicswebview/resources/input_types.html: Removed.
- qt/tests/qgraphicswebview/resources/pointing_right.html: Removed.
- qt/tests/qgraphicswebview/resources/pointing_up.html: Removed.
- qt/tests/qgraphicswebview/resources/scrolltest_page.html: Removed.
- qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp: Removed.
- qt/tests/qgraphicswebview/tst_qgraphicswebview.qrc: Removed.
- qt/tests/qobjectbridge/qobjectbridge.pro: Removed.
- qt/tests/qobjectbridge/tst_qobjectbridge.cpp: Removed.
- qt/tests/qwebelement/qwebelement.pro: Removed.
- qt/tests/qwebelement/resources/image.png: Removed.
- qt/tests/qwebelement/resources/style.css: Removed.
- qt/tests/qwebelement/resources/style2.css: Removed.
- qt/tests/qwebelement/tst_qwebelement.cpp: Removed.
- qt/tests/qwebelement/tst_qwebelement.qrc: Removed.
- qt/tests/qwebframe/qwebframe.pro: Removed.
- qt/tests/qwebframe/resources/image.png: Removed.
- qt/tests/qwebframe/resources/style.css: Removed.
- qt/tests/qwebframe/resources/test1.html: Removed.
- qt/tests/qwebframe/resources/test2.html: Removed.
- qt/tests/qwebframe/resources/testiframe.html: Removed.
- qt/tests/qwebframe/resources/testiframe2.html: Removed.
- qt/tests/qwebframe/tst_qwebframe.cpp: Removed.
- qt/tests/qwebframe/tst_qwebframe.qrc: Removed.
- qt/tests/qwebhistory/qwebhistory.pro: Removed.
- qt/tests/qwebhistory/resources/page1.html: Removed.
- qt/tests/qwebhistory/resources/page2.html: Removed.
- qt/tests/qwebhistory/resources/page3.html: Removed.
- qt/tests/qwebhistory/resources/page4.html: Removed.
- qt/tests/qwebhistory/resources/page5.html: Removed.
- qt/tests/qwebhistory/resources/page6.html: Removed.
- qt/tests/qwebhistory/tst_qwebhistory.cpp: Removed.
- qt/tests/qwebhistory/tst_qwebhistory.qrc: Removed.
- qt/tests/qwebhistoryinterface/qwebhistoryinterface.pro: Removed.
- qt/tests/qwebhistoryinterface/tst_qwebhistoryinterface.cpp: Removed.
- qt/tests/qwebinspector/qwebinspector.pro: Removed.
- qt/tests/qwebinspector/tst_qwebinspector.cpp: Removed.
- qt/tests/qwebpage/qwebpage.pro: Removed.
- qt/tests/qwebpage/resources/content.html: Removed.
- qt/tests/qwebpage/resources/frame_a.html: Removed.
- qt/tests/qwebpage/resources/frame_c.html: Removed.
- qt/tests/qwebpage/resources/framedindex.html: Removed.
- qt/tests/qwebpage/resources/iframe.html: Removed.
- qt/tests/qwebpage/resources/iframe2.html: Removed.
- qt/tests/qwebpage/resources/iframe3.html: Removed.
- qt/tests/qwebpage/resources/index.html: Removed.
- qt/tests/qwebpage/resources/script.html: Removed.
- qt/tests/qwebpage/resources/user.css: Removed.
- qt/tests/qwebpage/tst_qwebpage.cpp: Removed.
- qt/tests/qwebpage/tst_qwebpage.qrc: Removed.
- qt/tests/qwebplugindatabase/qwebplugindatabase.pro: Removed.
- qt/tests/qwebplugindatabase/tst_qwebplugindatabase.cpp: Removed.
- qt/tests/qwebsecurityorigin/qwebsecurityorigin.pro: Removed.
- qt/tests/qwebsecurityorigin/resources/test.html: Removed.
- qt/tests/qwebsecurityorigin/tst_qwebsecurityorigin.cpp: Removed.
- qt/tests/qwebsecurityorigin/tst_qwebsecurityorigin.qrc: Removed.
- qt/tests/qwebview/.gitignore: Removed.
- qt/tests/qwebview/qwebview.pro: Removed.
- qt/tests/qwebview/resources/frame_a.html: Removed.
- qt/tests/qwebview/resources/index.html: Removed.
- qt/tests/qwebview/resources/input_types.html: Removed.
- qt/tests/qwebview/resources/scrolltest_page.html: Removed.
- qt/tests/qwebview/tst_qwebview.cpp: Removed.
- qt/tests/qwebview/tst_qwebview.qrc: Removed.
- qt/tests/resources/image2.png: Removed.
- qt/tests/resources/test.swf: Removed.
- qt/tests/tests.pri: Removed.
- qt/tests/util.h: Removed.
- 11:17 AM Changeset in webkit [156780] by
-
- 17 edits9 deletes in trunk/Source/JavaScriptCore
Get rid of Qt code from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=122223
Reviewed by Oliver Hunt.
- API/JSStringRefQt.cpp: Removed.
- API/JSStringRefQt.h: Removed.
- API/OpaqueJSString.h:
- DerivedSources.pri: Removed.
- JavaScriptCore.pri: Removed.
- JavaScriptCore.pro: Removed.
- LLIntOffsetsExtractor.pro: Removed.
- Target.pri: Removed.
- assembler/AbstractMacroAssembler.h:
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::urshift32):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::shouldBlindForSpecificArch):
- assembler/MacroAssemblerX86Common.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithSub):
- heap/HeapTimer.cpp:
(JSC::HeapTimer::timerEvent):
- heap/HeapTimer.h:
- heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::scheduleTimer):
- heap/IncrementalSweeper.h:
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitSub32Constant):
- jsc.cpp:
(main):
- jsc.pro: Removed.
- runtime/DateConstructor.cpp:
- runtime/GCActivityCallback.cpp:
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::cancelTimer):
- runtime/GCActivityCallback.h:
- testRegExp.cpp:
(main):
- yarr/yarr.pri: Removed.
- 11:08 AM Changeset in webkit [156779] by
-
- 5 edits1 delete in trunk/Source/WebCore
Remove Qt-specific code in WebCore/{rendering,editing,history}.
<https://webkit.org/b/122220>
Reviewed by Anders Carlsson.
Purge PLATFORM(QT) blocks and FooBarQt.* files.
- 11:07 AM Changeset in webkit [156778] by
-
- 12 edits in trunk/Source/WebCore
Remove Qt-specific code in common WebCore/{html,dom} files.
<https://webkit.org/b/122219>
Reviewed by Anders Carlsson.
Purge PLATFORM(QT) blocks.
- 11:06 AM Changeset in webkit [156777] by
-
- 2 edits in trunk/LayoutTests
video-object-fit tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=121803
- platform/mac/TestExpectations: Marking as such.
- 11:06 AM Changeset in webkit [156776] by
-
- 2 edits in trunk/Source/WebKit2
Fix the Mac WebKit2 build following <http://trac.webkit.org/changeset/139241>
(https://bugs.webkit.org/show_bug.cgi?id=104197)
WebContextMac.mm fails to compile when building with network process disabled.
The constants WebKit2HTTPProxyDefaultsKey and WebKit2HTTPSProxyDefaultsKey,
defined in WebContextMac.mm, should only be defined when building with the
network process enabled as these constants are only referenced from
ENABLE(NETWORK_PROCESS)-guard code.
- UIProcess/mac/WebContextMac.mm:
- 11:03 AM Changeset in webkit [156775] by
-
- 11 edits3 deletes in trunk/Source/WTF
Remove Qt code from WTF
https://bugs.webkit.org/show_bug.cgi?id=122221
Reviewed by Antti Koivisto.
I'm keeping the PLATFORM(QT) defines in Platform.h for now so we can assess if there are any
Qt only features that we can remove later.
- WTF.pri: Removed.
- WTF.pro: Removed.
- wtf/Assertions.cpp:
- wtf/CurrentTime.cpp:
- wtf/DisallowCType.h:
- wtf/FastMalloc.cpp:
- wtf/FeatureDefines.h:
- wtf/qt/MainThreadQt.cpp: Removed.
- wtf/qt/StringQt.cpp: Removed.
- wtf/text/AtomicString.h:
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::~StringImpl):
- wtf/text/StringImpl.h:
- wtf/text/WTFString.cpp:
(WTF::String::format):
- wtf/text/WTFString.h:
- 11:02 AM Changeset in webkit [156774] by
-
- 2 edits in trunk/LayoutTests
Quirksmode: CSS1: WebKit fails dynamic :first-letter test
https://bugs.webkit.org/show_bug.cgi?id=15602
- platform/mac/TestExpectations: Correcting Mac expectations too, now that we have results.
- 11:00 AM Changeset in webkit [156773] by
-
- 3 edits2 adds in trunk/LayoutTests
Quirksmode: CSS1: WebKit fails dynamic :first-letter test
https://bugs.webkit.org/show_bug.cgi?id=15602
- platform/mac/fast/css/first-letter-block-change-expected.png: Added.
- platform/mac/fast/css/first-letter-block-change-expected.txt: Added.
Added expected results for Mac.
- platform/efl/TestExpectations: Corrected the expectation. This test is not
failing, it has no results.
- 10:26 AM Changeset in webkit [156772] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/templates/root.html
remove Qt from the main buildbot page.
- 10:16 AM Changeset in webkit [156771] by
-
- 4 edits in trunk/Tools
Remove Qt bots and EWS from trunk.
https://bugs.webkit.org/show_bug.cgi?id=122210.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2013-10-02
Reviewed by Allan Sandfeld Jensen.
Remove Qt buil dbots.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(appendCustomBuildFlags):
(RunGtkAPITests.getText2):
(Factory.init):
(TestFactory.init):
(BuildAndTestFactory.init):
(loadBuilderConfig):
- BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
- 10:13 AM Changeset in webkit [156770] by
-
- 3 edits in trunk/Tools
Remove Qt bots and EWS from trunk.
https://bugs.webkit.org/show_bug.cgi?id=122210.
Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2013-10-02
Reviewed by Allan Sandfeld Jensen.
Remove Qt EWS bots.
- QueueStatusServer/config/queues.py:
- Scripts/webkitpy/common/config/ews.json:
- 10:03 AM Changeset in webkit [156769] by
-
- 94 edits in trunk/Source
CTTE: DOMWrapperWorlds should be passed around by reference
https://bugs.webkit.org/show_bug.cgi?id=122206
Reviewed by Andreas Kling.
../WebCore:
- bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::clearWrappers):
(WebCore::normalWorld):
(WebCore::mainThreadNormalWorld):
- bindings/js/DOMWrapperWorld.h:
(WebCore::debuggerWorld):
(WebCore::pluginWorld):
(WebCore::currentWorld):
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):
- bindings/js/JSCSSValueCustom.cpp:
(WebCore::JSCSSValueOwner::finalize):
- bindings/js/JSDOMBinding.h:
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(WebCore::getInlineCachedWrapper):
(WebCore::setInlineCachedWrapper):
(WebCore::clearInlineCachedWrapper):
(WebCore::getCachedWrapper):
(WebCore::cacheWrapper):
(WebCore::uncacheWrapper):
(WebCore::jsStringWithCache):
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
(WebCore::toJSDOMGlobalObject):
- bindings/js/JSDOMGlobalObject.h:
(WebCore::JSDOMGlobalObject::world):
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::toJSDOMWindow):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::JSDOMWindowShell):
(WebCore::JSDOMWindowShell::setWindow):
(WebCore::toJSDOMWindowShell):
- bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::create):
(WebCore::JSDOMWindowShell::world):
- bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::JSErrorHandler):
- bindings/js/JSErrorHandler.h:
(WebCore::JSErrorHandler::create):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::handleEvent):
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::create):
(WebCore::JSEventListener::isolatedWorld):
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::getJSListenerFunctions):
- bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::JSLazyEventListener):
- bindings/js/JSLazyEventListener.h:
- bindings/js/JSMutationCallback.cpp:
(WebCore::JSMutationCallback::JSMutationCallback):
(WebCore::JSMutationCallback::call):
- bindings/js/JSNodeCustom.cpp:
(WebCore::JSNodeOwner::finalize):
- bindings/js/JSPluginElementFunctions.h:
(WebCore::pluginElementCustomGetOwnPropertySlot):
- bindings/js/JSWorkerGlobalScopeBase.cpp:
(WebCore::JSWorkerGlobalScopeBase::JSWorkerGlobalScopeBase):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::execute):
- bindings/js/ScheduledAction.h:
(WebCore::ScheduledAction::ScheduledAction):
- bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::restore):
- bindings/js/ScriptCachedFrameData.h:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::destroyWindowShell):
(WebCore::ScriptController::createWindowShell):
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::getAllWorlds):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::executeScriptInWorld):
(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
- bindings/js/ScriptController.h:
(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::existingWindowShell):
(WebCore::ScriptController::globalObject):
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::isContentScript):
- bindings/js/ScriptState.cpp:
(WebCore::execStateFromNode):
(WebCore::execStateFromPage):
- bindings/js/ScriptState.h:
- bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::transferArrayBuffers):
- bindings/js/WebCoreJSClientData.h:
(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::WebCoreJSClientData::normalWorld):
(WebCore::WebCoreJSClientData::getAllWorlds):
(WebCore::WebCoreJSClientData::rememberWorld):
(WebCore::WebCoreJSClientData::forgetWorld):
- bindings/js/WebCoreTypedArrayController.cpp:
(WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::finalize):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- dom/Document.cpp:
(WebCore::Document::ensurePlugInsInjectedScript):
- dom/Document.h:
- dom/DocumentStyleSheetCollection.cpp:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::ensureIsolatedWorld):
(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot):
- html/HTMLMediaElement.h:
- html/HTMLPlugInImageElement.cpp:
(WebCore::plugInImageElementIsolatedWorld):
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::didClearWindowObjectInWorld):
- inspector/InspectorAgent.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::didClearWindowObjectInWorld):
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didClearWindowObjectInWorld):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
- inspector/InspectorPageAgent.h:
- loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
(WebCore::FrameLoader::dispatchGlobalObjectAvailableInAllWorlds):
- loader/FrameLoader.h:
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::dispatchGlobalObjectAvailable):
- page/CaptionUserPreferencesMediaAF.cpp:
- page/DOMWindowExtension.cpp:
(WebCore::DOMWindowExtension::DOMWindowExtension):
- page/DOMWindowExtension.h:
(WebCore::DOMWindowExtension::create):
(WebCore::DOMWindowExtension::world):
- page/Frame.cpp:
(WebCore::Frame::injectUserScripts):
(WebCore::Frame::injectUserScriptsForWorld):
- page/Frame.h:
- page/PageGroup.cpp:
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):
(WebCore::PageGroup::removeUserScriptsFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):
- page/PageGroup.h:
../WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):
- WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
- WebCoreSupport/FrameLoaderClientEfl.h:
../WebKit/gtk:
- WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):
- WebCoreSupport/FrameLoaderClientGtk.h:
../WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
(WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
(WebKit::NetscapePluginInstanceProxy::evaluate):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebView/WebFrame.mm:
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
(-[WebFrame _globalContextForScriptWorld:]):
(-[WebFrame jsWrapperForNode:inScriptWorld:]):
- WebView/WebScriptWorld.mm:
(+[WebScriptWorld standardWorld]):
(+[WebScriptWorld findOrCreateWorld:]):
- WebView/WebScriptWorldInternal.h:
- WebView/WebView.mm:
(-[WebView _injectOutlookQuirksScript]):
(+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
(+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
(+[WebView _removeUserScriptFromGroup:world:url:]):
(+[WebView _removeUserStyleSheetFromGroup:world:url:]):
(+[WebView _removeUserScriptsFromGroup:world:]):
(+[WebView _removeUserStyleSheetsFromGroup:world:]):
../WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebScriptWorld.cpp:
(WebScriptWorld::standardWorld):
(WebScriptWorld::findOrCreateWorld):
- WebScriptWorld.h:
(WebScriptWorld::world):
../WebKit/wince:
- WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::dispatchDidClearWindowObjectInWorld):
- WebCoreSupport/FrameLoaderClientWinCE.h:
../WebKit2:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):
(WebKit::InjectedBundlePageLoaderClient::globalObjectIsAvailableForFrame):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:
(WebKit::InjectedBundleScriptWorld::getOrCreate):
(WebKit::InjectedBundleScriptWorld::normalWorld):
(WebKit::InjectedBundleScriptWorld::coreWorld):
- WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::windowScriptNPObject):
(WebKit::PluginView::pluginElementNPObject):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
(WebKit::WebFrameLoaderClient::dispatchGlobalObjectAvailable):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- 9:43 AM Changeset in webkit [156768] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, removing references to the recently removed Modules/filesystem directory.
- GNUmakefile.am:
- 8:10 AM WebKitGTK/2.2.x edited by
- propose r156003 for 2.2.1 (diff)
- 6:07 AM Changeset in webkit [156767] by
-
- 47 edits5 copies103 deletes in trunk
[CSS Regions] Activate all regions to have layers, as CSS Regions create a new stacking context
https://bugs.webkit.org/show_bug.cgi?id=121828
Patch by Mihai Maerean <Mihai Maerean> on 2013-10-02
Reviewed by Darin Adler.
Source/WebCore:
The CSS Regions specification says "CSS Regions create a new stacking context." (http://dev.w3.org/csswg/css-regions/).
Divs that create stacking contexts are painted after the divs that don't create stacking contexts.
Test: fast/regions/layers/stacking-context-paint-order.html: While the existing region-sibling-paint-order.html
test verifies that regions paint correctly when the next sibling also creates a stacking context, this new test
verifies that regions paint correctly when the next sibling doesn't create a stacking context.
- rendering/RenderBlock.cpp: Remove code that is not needed now that all regions have layers.
- rendering/RenderBlock.h: Remove code that is not needed now that all regions have layers.
- rendering/RenderBox.cpp: Remove code that is not needed now that all regions have layers.
- rendering/RenderBox.h: Remove code that is not needed now that all regions have layers.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::updateLayerToRegionMappings): Remove code that is not needed now that all regions have layers.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
- rendering/RenderRegion.h:
(WebCore::RenderRegion::requiresLayer): Always. CSS Regions create Stacking Contexts. RenderMultiColumnSet
implements its own behaviour so the behaviour of each class is contained within its own files.
- rendering/RenderMultiColumnSet.h:
(WebCore::RenderMultiColumnSet::requiresLayer): RenderMultiColumnSet derives from RenderRegion, but unlike the
CSS Regions specification, the Multi-Columns CSS specification states that the column boxes do not establish new
Stacking Contexts.
- rendering/RenderTreeAsText.cpp:
(WebCore::writeRenderRegionList): There's no need to output " hasLayer" since all regions now have layers.
LayoutTests:
For the ref tests, the divs in the expected results coresponding to the regions now have a CSS style causing
them to also create Stacking Contexts.
Most of the tests in fast/regions/layers/ have been deleted because they aren't relevant anymore.
The change in most of the *-expected.txt files is that the " hasLayer" part has been removed (since all regions
now have layers).
Platform (efl, efl-wk2, gtk, mac-lion, mac-wk2, qt, qt-wk2) specific expectated results need to be generated again.
- fast/regions/autoheight-regions-mark-expected.txt:
- fast/regions/flow-content-basic-expected.html: Added. The test is now a ref test.
- fast/regions/flow-content-basic-vertical-expected.html: Added. The test is now a ref test.
- fast/regions/flow-content-basic-vertical-rl-expected.html: Added.The test is now a ref test.
- fast/regions/flow-content-basic-vertical-rl.html:
- fast/regions/flow-content-basic-vertical.html:
- fast/regions/flow-content-basic.html:
- fast/regions/flows-dependency-dynamic-remove-expected.txt:
- fast/regions/flows-dependency-same-flow-expected.txt:
- fast/regions/layers/dynamic-layer-added-with-no-layout-expected.png: Removed.
- fast/regions/layers/dynamic-layer-added-with-no-layout-expected.txt: Removed.
- fast/regions/layers/dynamic-layer-added-with-no-layout.html: Removed.
- fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.png: Removed.
- fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.txt: Removed.
- fast/regions/layers/dynamic-layer-removed-with-no-layout.html: Removed.
- fast/regions/layers/regions-promoted-to-layers-expected.png: Removed.
- fast/regions/layers/regions-promoted-to-layers-expected.txt: Removed.
- fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.png: Removed.
- fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.txt: Removed.
- fast/regions/layers/regions-promoted-to-layers-horizontal-bt.html: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.png: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.txt: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-lr.html: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.png: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.txt: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-rl.html: Removed.
- fast/regions/layers/regions-promoted-to-layers.html: Removed.
- fast/regions/layers/stacking-context-paint-order-expected.html: Added.
- fast/regions/layers/stacking-context-paint-order.html: Added. While the existing region-sibling-paint-order.html
test verifies that regions paint correctly when the next sibling also creates a stacking context, this new test
verifies that regions paint correctly when the next sibling doesn't create a stacking context.
- fast/regions/region-sibling-paint-order-expected.html:
- fast/regions/region-sibling-paint-order.html:
- fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
- fast/repaint/region-painting-composited-element-expected.html:
- fast/repaint/region-painting-in-composited-view-expected.html:
- fast/repaint/region-painting-in-composited-view.html:
- fast/repaint/region-painting-via-layout-expected.txt:
- platform/efl-wk2/TestExpectations:
- platform/efl-wk2/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
- platform/efl-wk2/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
- platform/efl/TestExpectations:
- platform/efl/fast/regions/autoheight-regions-mark-expected.png: Removed.
- platform/efl/fast/regions/autoheight-regions-mark-expected.txt: Removed.
- platform/efl/fast/regions/flow-content-basic-expected.png: Removed. The test is now a ref test.
- platform/efl/fast/regions/flow-content-basic-expected.txt: Removed.
- platform/efl/fast/regions/flow-content-basic-vertical-expected.png: Removed.
- platform/efl/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
- platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
- platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
- platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.png: Removed.
- platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
- platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
- platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
- platform/efl/fast/regions/region-dynamic-after-before-expected.txt:
- platform/efl/fast/regions/region-generated-content-before-after-expected.txt:
- platform/efl/fast/regions/text-region-split-small-pagination-expected.png: Removed.
- platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
- platform/efl/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
- platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
- platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
- platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
- platform/efl/fast/repaint/region-painting-invalidation-expected.png: Removed.
- platform/efl/fast/repaint/region-painting-invalidation-expected.txt: Removed.
- platform/efl/fast/repaint/region-painting-via-layout-expected.png: Removed.
- platform/efl/fast/repaint/region-painting-via-layout-expected.txt: Removed.
- platform/gtk/TestExpectations:
- platform/gtk/fast/regions/autoheight-regions-mark-expected.png: Removed.
- platform/gtk/fast/regions/autoheight-regions-mark-expected.txt: Removed.
- platform/gtk/fast/regions/flow-content-basic-expected.png: Removed.
- platform/gtk/fast/regions/flow-content-basic-expected.txt: Removed.
- platform/gtk/fast/regions/flow-content-basic-vertical-expected.png: Removed.
- platform/gtk/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
- platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
- platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
- platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.png: Removed.
- platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
- platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
- platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
- platform/gtk/fast/regions/region-dynamic-after-before-expected.txt:
- platform/gtk/fast/regions/region-generated-content-before-after-expected.txt:
- platform/gtk/fast/regions/text-region-split-small-pagination-expected.png: Removed.
- platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
- platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
- platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
- platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
- platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
- platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
- platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
- platform/gtk/fast/repaint/region-painting-invalidation-expected.png: Removed.
- platform/gtk/fast/repaint/region-painting-invalidation-expected.txt: Removed.
- platform/gtk/fast/repaint/region-painting-via-layout-expected.png: Removed.
- platform/gtk/fast/repaint/region-painting-via-layout-expected.txt: Removed.
- platform/mac-lion/TestExpectations:
- platform/mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
- platform/mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
- platform/mac-wk2/TestExpectations:
- platform/mac/fast/regions/flow-content-basic-expected.png: Removed.
- platform/mac/fast/regions/flow-content-basic-expected.txt: Removed.
- platform/mac/fast/regions/flow-content-basic-vertical-expected.png: Removed.
- platform/mac/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
- platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
- platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
- platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
- platform/mac/fast/regions/region-dynamic-after-before-expected.txt:
- platform/mac/fast/regions/region-generated-content-before-after-expected.txt:
- platform/mac/fast/regions/text-region-split-small-pagination-expected.txt:
- platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt:
- platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
- platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
- platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
- platform/mac/fast/repaint/region-painting-invalidation-expected.txt:
- platform/qt-wk2/TestExpectations:
- platform/qt-wk2/fast/regions/flow-content-basic-expected.png: Removed.
- platform/qt-wk2/fast/regions/flow-content-basic-vertical-expected.png: Removed.
- platform/qt-wk2/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
- platform/qt-wk2/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
- platform/qt-wk2/fast/regions/text-region-split-small-pagination-expected.png: Removed.
- platform/qt-wk2/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
- platform/qt-wk2/fast/repaint/region-painting-invalidation-expected.png: Removed.
- platform/qt-wk2/fast/repaint/region-painting-invalidation-expected.txt: Removed.
- platform/qt-wk2/fast/repaint/region-painting-via-layout-expected.png: Removed.
- platform/qt/TestExpectations:
- platform/qt/fast/regions/autoheight-regions-mark-expected.png: Removed.
- platform/qt/fast/regions/autoheight-regions-mark-expected.txt: Removed.
- platform/qt/fast/regions/flow-content-basic-expected.png: Removed.
- platform/qt/fast/regions/flow-content-basic-expected.txt: Removed.
- platform/qt/fast/regions/flow-content-basic-vertical-expected.png: Removed.
- platform/qt/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
- platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
- platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
- platform/qt/fast/regions/flows-dependency-dynamic-remove-expected.png: Removed.
- platform/qt/fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
- platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
- platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
- platform/qt/fast/regions/text-region-split-small-pagination-expected.png: Removed.
- platform/qt/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
- platform/qt/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
- platform/qt/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
- platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
- platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
- platform/qt/fast/repaint/region-painting-invalidation-expected.png: Removed.
- platform/qt/fast/repaint/region-painting-invalidation-expected.txt: Removed.
- platform/qt/fast/repaint/region-painting-via-layout-expected.png: Removed.
- platform/qt/fast/repaint/region-painting-via-layout-expected.txt: Removed.
- platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
- platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
- 3:14 AM Changeset in webkit [156766] by
-
- 4 edits2 adds in trunk
HTML listbox is not resized horizontally when zooming
https://bugs.webkit.org/show_bug.cgi?id=20445
Reviewed by Darin Adler.
Source/WebCore:
If any style changes happens on a HTMLSelectElement, we need to set the m_optionsChanged property
of its renderer (RenderListBox) otherwise its size won't follow the changed content.
Test: fast/transforms/listbox-zoom.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::didRecalcStyle):
- html/HTMLSelectElement.h:
LayoutTests:
A test with a zoomed listbox is added to check whether the styleChange is catched.
- fast/transforms/listbox-zoom.html: Added.
- fast/transforms/listbox-zoom-expected.txt: Added.
- 2:32 AM Changeset in webkit [156765] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: highlight newly added console messages in the Activity Viewer
https://bugs.webkit.org/show_bug.cgi?id=122093
Reviewed by Joseph Pecoraro.
Fade the appropriate console log button in the Activity Viewer for a short duration
to call attention to it when its count is incremented. The animation may be restarted
in-flight if the count is incremented as we were pulsing the opacity.
- UserInterface/DashboardView.css:
(.toolbar .dashboard > .item.pulsing):
(@-webkit-keyframes console-item-pulse):
New pulse animation for a console item in the Activity Viewer, the new "pulsing" CSS
class is applied in WebInspector.DashboardView.prototype._setConsoleItemValue().
- UserInterface/DashboardView.js:
(WebInspector.DashboardView.prototype.set logs):
(WebInspector.DashboardView.prototype.set issues):
(WebInspector.DashboardView.prototype.set errors):
Refactor setters to use the new WebInspector.DashboardView.prototype._setConsoleItemValue()
method.
(WebInspector.DashboardView.prototype._setConsoleItemValue):
We now set the ivar backing console item values in this new refactored method and additionally
apply an animation to the DOM element for the given item if its value is incremented such that
it pulses, subtly calling out the developer's attention to it.
- UserInterface/Utilities.js:
New Element.prototype.recalculateStyles() method to abstract the hack required to force
a style recalc on a given element.
Oct 1, 2013:
- 10:11 PM Changeset in webkit [156764] by
-
- 4 edits2 adds in trunk
contenteditable justify commands applied to next paragraph as well
https://bugs.webkit.org/show_bug.cgi?id=90611
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-01
Reviewed by Ryosuke Niwa.
Source/WebCore:
When the selection extends from first paragraph to start of next
paragraph then Justify command is applied to both the paragraph,
Instead it should be applied only to first paragraph.
Co-author: Sudarshan C P <sudarshan.cp@samsung.com>
Test: editing/execCommand/contenteditable-justify-next-paragraph.html
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyBlockStyle):
Adjusted visibleEnd to previous position.
LayoutTests:
Added a test for selecting one paragraph and the beginning of another
paragraph to ensure that only the first fully-selected paragraph should
be justified when justifying the selection.
- editing/execCommand/align-in-span-expected.txt: Updated.
- editing/execCommand/contenteditable-justify-next-paragraph-expected.txt: Added.
- editing/execCommand/contenteditable-justify-next-paragraph.html: Added.
- 10:01 PM Changeset in webkit [156763] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: media/media-element-play-after-eos.html
https://bugs.webkit.org/show_bug.cgi?id=115048
- platform/mac/TestExpectations: Marking as such.
- 9:25 PM Changeset in webkit [156762] by
-
- 1 edit in branches/safari-537-branch/LayoutTests/platform/mac-lion/TestExpectations
Rollout r156759.
- 9:20 PM Changeset in webkit [156761] by
-
- 15 edits in trunk/Source
Move mouse event dispatch from Node to Element.
<https://webkit.org/b/122203>
Reviewed by Anders Carlsson.
We never dispatch mouse events on text or other non-element nodes,
so move the related logic to using Element.
Node::dispatchMouseEvent() moves to Element. I also changed the
relatedTarget argument to be an Element* since the related target
is never a Node either.
Most of this patch is *Node -> *Element renames in EventHandler.
- 9:17 PM Changeset in webkit [156760] by
-
- 22 edits in trunk/Source/WebCore
Generate toCSSFooValue for CSS child values
https://bugs.webkit.org/show_bug.cgi?id=122157
Reviewed by Darin Adler.
As a step to cleanup static_cast<> for CSSFooValue, this patch adds toCSSFooValue()
for "CSSAspectRatioValue, CSSBorderImageSliceValue, CSSFunctionValue, CSSInheritedValue,
CSSValueList, CSSVariableValue, and CSSFontFaceSrcValue".
To use CSS_VALUE_TYPE_CASTS, isFunctionValue(), isFontFaceSrcValue() are added to
generate toCSSFunctionValue, toCSSFontFaceSrcValue().
No new tests, no behavior changes.
- css/CSSAspectRatioValue.h:
- css/CSSBorderImageSliceValue.h:
- css/CSSFontFaceSrcValue.h:
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
- css/CSSFunctionValue.h:
- css/CSSInheritedValue.h:
- css/CSSParser.cpp:
(WebCore::filterProperties):
(WebCore::CSSParser::addFillValue):
(WebCore::CSSParser::addAnimationValue):
(WebCore::CSSParser::createFontFaceRule):
- css/CSSProperty.cpp:
(WebCore::CSSProperty::wrapValueInCommaSeparatedList):
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapNinePieceImage):
(WebCore::CSSToStyleMap::mapNinePieceImageSlice):
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isFunctionValue):
(WebCore::CSSValue::isFontFaceSrcValue):
- css/CSSValueList.h:
(WebCore::CSSValueListInspector::CSSValueListInspector):
- css/CSSVariableValue.h:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
- css/MediaQueryEvaluator.cpp:
(WebCore::compareAspectRatioValue):
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getLayeredShorthandValue):
- css/StyleResolver.cpp:
(WebCore::createGridPosition):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::parseCustomFilterParameter):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
- editing/EditingStyle.cpp:
(WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle):
(WebCore::EditingStyle::mergeStyle):
(WebCore::StyleChange::extractTextStyles):
(WebCore::diffTextDecorations):
- editing/EditorCommand.cpp:
(WebCore::executeToggleStyleInList):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::rebuildFontFace):
- 8:28 PM Changeset in webkit [156759] by
-
- 1 edit in branches/safari-537-branch/LayoutTests/platform/mac-lion/TestExpectations
Update TestExpectations.
- 7:22 PM Changeset in webkit [156758] by
-
- 5 edits in trunk
FTL should use the new version of LLVM MCJIT memory manager APIs that take a SectionName
https://bugs.webkit.org/show_bug.cgi?id=122193
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
Update our usage of the LLVM C API since the API is about to change.
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateCodeSection):
(JSC::FTL::mmAllocateDataSection):
WebKitLibraries:
Reviewed by Geoffrey Garen.
- LLVMIncludesMountainLion.tar.bz2:
- LLVMLibrariesMountainLion.tar.bz2:
- 7:19 PM Changeset in webkit [156757] by
-
- 19 edits12 deletes in trunk
REGRESSION(156464): 50% regression on SunSpider/string-fasta
https://bugs.webkit.org/show_bug.cgi?id=122202
Source/JavaScriptCore:
Unreviewed, roll out r156464.
This is a progression on string-fasta, since it fixes the regression.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::paramString):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitExpressionInfo):
- bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitBytecode):
(JSC::FuncExprNode::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::addVar):
- parser/NodeConstructors.h:
(JSC::CommaNode::CommaNode):
(JSC::ParameterNode::ParameterNode):
(JSC::ForInNode::ForInNode):
- parser/Nodes.cpp:
(JSC::FunctionParameters::create):
(JSC::FunctionParameters::FunctionParameters):
(JSC::FunctionParameters::~FunctionParameters):
- parser/Nodes.h:
(JSC::ExpressionNode::isDotAccessorNode):
(JSC::CommaNode::append):
(JSC::ParameterNode::ident):
(JSC::FunctionParameters::at):
(JSC::FunctionParameters::identifiers):
- parser/Parser.cpp:
(JSC::::Parser):
(JSC::::parseVarDeclaration):
(JSC::::parseVarDeclarationList):
(JSC::::parseForStatement):
(JSC::::parseFormalParameters):
(JSC::::parseAssignmentExpression):
- parser/Parser.h:
(JSC::Scope::declareParameter):
(JSC::Parser::declareParameter):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createFormalParameterList):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::operatorStackPop):
- runtime/JSONObject.cpp:
- runtime/JSONObject.h:
LayoutTests:
Unreviewed, roll out r156464.
- js/destructuring-assignment-expected.txt: Removed.
- js/destructuring-assignment.html: Removed.
- js/mozilla/strict/13.1-expected.txt:
- js/mozilla/strict/regress-532254-expected.txt:
- js/mozilla/strict/script-tests/13.1.js:
- js/regress/destructuring-arguments-expected.txt: Removed.
- js/regress/destructuring-arguments-length-expected.txt: Removed.
- js/regress/destructuring-arguments-length.html: Removed.
- js/regress/destructuring-arguments.html: Removed.
- js/regress/destructuring-swap-expected.txt: Removed.
- js/regress/destructuring-swap.html: Removed.
- js/regress/script-tests/destructuring-arguments-length.js: Removed.
- js/regress/script-tests/destructuring-arguments.js: Removed.
- js/regress/script-tests/destructuring-swap.js: Removed.
- js/script-tests/destructuring-assignment.js: Removed.
- sputnik/Conformance/13_Function_Definition/S13_A5.html:
- 7:01 PM Changeset in webkit [156756] by
-
- 2 edits in trunk/Tools
Fix singular labels for test failures.
https://bugs.webkit.org/show_bug.cgi?id=122200
Reviewed by Joseph Pecoraro.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
- 6:09 PM FTLJIT edited by
- (diff)
- 6:05 PM Changeset in webkit [156755] by
-
- 1 edit in branches/safari-537.73-branch/LayoutTests/platform/mac-lion/TestExpectations
Merge TextExpectations.
- 6:04 PM Changeset in webkit [156754] by
-
- 1 edit in branches/safari-537.73-branch/LayoutTests/platform/mac-wk2/TestExpectations
Merge TextExpectations.
- 6:00 PM Changeset in webkit [156753] by
-
- 2 edits in trunk/Tools
Don't keep appending iterations each time the queue updates.
https://bugs.webkit.org/show_bug.cgi?id=122198
Reviewed by Joseph Pecoraro.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype.update):
- 5:36 PM Changeset in webkit [156752] by
-
- 3 edits in trunk/Tools
Properly sort iterations in the Dashboard by revision for out-of-order queues.
https://bugs.webkit.org/show_bug.cgi?id=122196
Reviewed by Brent Fulgham.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration):
(BuildbotIteration.prototype.update):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype.update):
(BuildbotQueue.prototype.sortIterations):
- 5:03 PM Changeset in webkit [156751] by
-
- 24 edits in trunk/Source/WebCore
Convert PageGroup to using std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=122184
Reviewed by Anders Carlsson.
- page/CaptionUserPreferences.cpp:
- page/CaptionUserPreferences.h:
- page/CaptionUserPreferencesMediaAF.cpp:
- page/CaptionUserPreferencesMediaAF.h:
- page/Frame.cpp:
- page/GroupSettings.h:
- page/Page.cpp:
- page/PageGroup.cpp:
- page/PageGroup.h:
- page/UserScriptTypes.h:
- page/UserStyleSheetTypes.h:
- workers/DedicatedWorkerGlobalScope.h:
- workers/DedicatedWorkerThread.cpp:
- workers/DedicatedWorkerThread.h:
- workers/SharedWorkerGlobalScope.cpp:
- workers/SharedWorkerGlobalScope.h:
- workers/SharedWorkerThread.cpp:
- workers/SharedWorkerThread.h:
- workers/WorkerGlobalScope.cpp:
- workers/WorkerGlobalScope.h:
- workers/WorkerThread.cpp:
- workers/WorkerThread.h:
- 4:45 PM Changeset in webkit [156750] by
-
- 4 edits in trunk/Tools
Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations.
Also fix some URLs to not have extras slashes and add a page title.
https://bugs.webkit.org/show_bug.cgi?id=122192
Reviewed by Joseph Pecoraro.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot.prototype.buildLogURLForIteration):
(WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
(WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
- 4:42 PM Changeset in webkit [156749] by
-
- 27 edits in trunk
Tiled drawing GraphicsLayer tree dumps should match non-tiled more closely
https://bugs.webkit.org/show_bug.cgi?id=122172
Reviewed by Anders Carlsson.
No new tests, but will be tested by all of the compositing tests after bug 121859 lands.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::dumpProperties):
Only dump drawsContent and backgroundColor if the client says we should.
Provide the ability to skip over a layer in the dump, making it appear as if that layer's
children are direct decendents of that layer's parent.
- platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::shouldSkipLayerInDump): Added.
(WebCore::GraphicsLayerClient::shouldDumpPropertyForLayer): Added.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::shouldSkipLayerInDump):
Added. Always skip the root tile cache's flattening layer, as it is
uninteresting and does not exist in the non-tiled-drawing compositing case.
(WebCore::RenderLayerBacking::shouldDumpPropertyForLayer):
Don't dump drawsContent on the root tile cache.
Don't dump backgroundcolor on the root tile cache, unless it is non-white.
This may require some WebKit2-specific rebaselines, but they will occur later.
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::layerTreeAsText):
If the root tile cache has no composited children, don't dump anything,
to match the traditional case where we drop out of compositing when
we have no reason to be compositing. Except, do dump the root tile cache's
layers if we're specifically being asked to dump tile caches.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.txt:
- platform/mac-wk2/tiled-drawing/sticky/sticky-layers-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-coverage-speculative-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt:
- platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration-expected.txt:
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
- platform/mac-wk2/tiled-drawing/use-tiled-drawing-expected.txt:
Rebaseline some tests given these changes.
- 4:35 PM Changeset in webkit [156748] by
-
- 1 edit in branches/safari-537-branch/LayoutTests/platform/mac-lion/TestExpectations
Skip Failing tests.
- 4:28 PM Changeset in webkit [156747] by
-
- 13 edits in trunk/Source/JavaScriptCore
Variable event stream (for DFG OSR exit) should be explicit about where on the stack a SetLocal put a value
https://bugs.webkit.org/show_bug.cgi?id=122178
Reviewed by Geoffrey Garen.
Now if the DFG stores the value of a variable into the stack explicitly via a SetLocal,
it will record where on the stack it stored the value in addition to recording where on
the stack the bytecode would have done the SetLocal. Previously it just recorded the
format and the bytecode variable. Recording just the bytecode variable is currently fine
since the DFG always executes SetLocal's to the same stack location that the bytecode
would have used. But that prevents stack compression (webkit.org/b/122024) so this patch
allows the SetLocal to say both the bytecode variable that we're speaking of and the
actual stack location to which the SetLocal stored the value.
This had to touch a lot of code, so I took the opportunity to also resolve
webkit.org/b/108019.
- bytecode/Operands.h:
(JSC::Operands::hasOperand):
- dfg/DFGFlushFormat.h:
(JSC::DFG::dataFormatFor):
- dfg/DFGMinifiedID.h:
(JSC::DFG::MinifiedID::bits):
(JSC::DFG::MinifiedID::invalidID):
(JSC::DFG::MinifiedID::otherInvalidID):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::recordSetLocal):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGValueSource.cpp:
(JSC::DFG::ValueSource::dump):
- dfg/DFGValueSource.h:
(JSC::DFG::ValueSource::ValueSource):
(JSC::DFG::ValueSource::forFlushFormat):
(JSC::DFG::ValueSource::forDataFormat):
(JSC::DFG::ValueSource::isSet):
(JSC::DFG::ValueSource::kind):
(JSC::DFG::ValueSource::valueRecovery):
(JSC::DFG::ValueSource::id):
(JSC::DFG::ValueSource::virtualRegister):
- dfg/DFGVariableEvent.cpp:
(JSC::DFG::VariableEvent::dump):
(JSC::DFG::VariableEvent::dumpSpillInfo):
- dfg/DFGVariableEvent.h:
(JSC::DFG::VariableEvent::fillGPR):
(JSC::DFG::VariableEvent::fillPair):
(JSC::DFG::VariableEvent::fillFPR):
(JSC::DFG::VariableEvent::spill):
(JSC::DFG::VariableEvent::death):
(JSC::DFG::VariableEvent::setLocal):
(JSC::DFG::VariableEvent::movHint):
(JSC::DFG::VariableEvent::id):
(JSC::DFG::VariableEvent::gpr):
(JSC::DFG::VariableEvent::tagGPR):
(JSC::DFG::VariableEvent::payloadGPR):
(JSC::DFG::VariableEvent::fpr):
(JSC::DFG::VariableEvent::spillRegister):
(JSC::DFG::VariableEvent::bytecodeRegister):
(JSC::DFG::VariableEvent::machineRegister):
(JSC::DFG::VariableEvent::variableRepresentation):
- dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):
- 4:18 PM Changeset in webkit [156746] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL: split overflow checks into non-overflow arithmetic and an additional call to the overflow intrinsic check.
https://bugs.webkit.org/show_bug.cgi?id=122170
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-01
Reviewed by Filip Pizlo.
Overflow intrinsics are preventing SCEV and other LLVM analysis passes from analyzing loops. This patch changes the FTL-IR gen by splitting arithmetic calculations into two parts:
- Generate the arithmetic calculation (that may overflow)
- Generate the overflow check (that is only used by the OSR-exit logic).
We trust LLVM (SelectionDAG) to merge these calculations into a single opcode.
This JS function:
function foo() {
for (i=0; i < 10000000; i++) { }
}
Is now compiled into this LLVM-IR:
"OSR exit continuation for @24<Int32>": ; preds = %"Block #0", %"OSR exit continuation for @24<Int32>2"
%4 = phi i64 [ %10, %"OSR exit continuation for @24<Int32>2" ], [ -281474976710656, %"Block #0" ]
%5 = trunc i64 %4 to i32
%6 = add i32 %5, 1
%7 = tail call { i32, i1 } @llvm.sadd.with.overflow.i32(i32 %5, i32 1)
%8 = extractvalue { i32, i1 } %7, 1
br i1 %8, label %"OSR exit failCase for @24<Int32>1", label %"OSR exit continuation for @24<Int32>2"
And into this assembly:
LBB0_1: ## %OSR exit continuation for @24<Int32>
## =>This Inner Loop Header: Depth=1
movl %ecx, %esi
incl %esi
jo LBB0_4
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileAddSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
- 4:17 PM Changeset in webkit [156745] by
-
- 1 edit in branches/safari-537-branch/LayoutTests/platform/mac-lion/TestExpectations
<rdar://problem/15126654>
- 3:59 PM Changeset in webkit [156744] by
-
- 1 edit in branches/safari-537-branch/LayoutTests/platform/mac-wk2/TestExpectations
Skip failing test.
- 3:52 PM Changeset in webkit [156743] by
-
- 8 edits in trunk/Source/WebKit2
<http://webkit.org/b/122190> WebKit2 APIs returning CF and NS types should explicitly declare whether they return retained objects.
This make the APIs easier to use under ARC and can help out the static analyzer.
Reviewed by Anders Carlsson.
- Shared/API/c/cf/WKErrorCF.h:
- Shared/API/c/cf/WKStringCF.h:
- Shared/API/c/cf/WKURLCF.h:
- Shared/API/c/cg/WKImageCG.h:
- Shared/API/c/mac/WKURLRequestNS.h:
- Shared/API/c/mac/WKURLResponseNS.h:
- UIProcess/API/C/cg/WKIconDatabaseCG.h:
- 3:47 PM Changeset in webkit [156742] by
-
- 5 edits5 adds in trunk
Quirksmode: CSS1: WebKit fails dynamic :first-letter test
https://bugs.webkit.org/show_bug.cgi?id=15602
Reviewed by David Hyatt.
Source/WebCore:
CSS first-letter property does not work properly when the first letter is changed
by DOM scripting.
This patch allows to check if the existing first-letter is no longer the
first-letter. In this case, it deletes the old first-letter object and creates
a new one. For the remaining text, the oldRemainingText object is used
again for containing the full text(first letter + remaining text).
Test: fast/css/first-letter-block-change.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):
LayoutTests:
Add a test case that ensures that CSS first-letter property should work
properly when the first letter is changed by DOM scripting.
- fast/css/first-letter-block-change.html: Added.
- platform/efl/TestExpectations:
- platform/gtk-wk1/fast/css/first-letter-block-change-expected.png: Added.
- platform/gtk-wk2/fast/css/first-letter-block-change-expected.png: Added.
- platform/gtk/fast/css/first-letter-block-change-expected.txt: Added.
- platform/mac/TestExpectations:
- 3:45 PM Changeset in webkit [156741] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed gardening.
- platform/win/TestExpectations: Update TestExpectations for two crashes that were not
previously logged, one image-only failure, another broken test due to the media changes.
- 3:45 PM Changeset in webkit [156740] by
-
- 3 edits in trunk/Tools
[Mac] Set NSApplication current event while sending events directly to views
https://bugs.webkit.org/show_bug.cgi?id=122179
Reviewed by Darin Adler.
DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView,
which doesn't update [NSApp currentEvent]. But there are many places in WebKit that
use the current event.
- DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController mouseDown:withModifiers:]):
(-[EventSendingController mouseUp:withModifiers:]):
(-[EventSendingController mouseMoveToX:Y:]):
(-[EventSendingController mouseScrollByX:andY:continuously:]):
(-[EventSendingController contextClick]):
(-[EventSendingController keyDown:withModifiers:withLocation:]):
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::mouseScrollBy):
Update the current event. We were already using the SPI in WebKit.
- 3:34 PM Changeset in webkit [156739] by
-
- 2 edits in trunk/Tools
Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
https://bugs.webkit.org/show_bug.cgi?id=122183
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-01
Reviewed by Timothy Hatcher.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.update):
- 3:29 PM Changeset in webkit [156738] by
-
- 32 edits in trunk/Source/WebCore
Make tests for renderer base types non-virtual
https://bugs.webkit.org/show_bug.cgi?id=122185
Reviewed by Dave Hyatt.
Make isRenderFoo() functions for commonly tested base types use bit flags instead of virtual calls.
This is faster and we have space in RenderElement.
These bits are not mutully exclusive. For testing leaf types we can add an enum.
- 3:22 PM Changeset in webkit [156737] by
-
- 2 edits in trunk/LayoutTests
[Windows] Unreviewed gardening. Skip fast/events/drag-and-drop-autoscroll-inner-frame.html.
Drag and drop does not work on Windows DRT.
- platform/win/TestExpectations:
- 3:04 PM Changeset in webkit [156736] by
-
- 7 edits1 add in trunk/Tools
Tweaks to the Buildbot Dashboard
https://bugs.webkit.org/show_bug.cgi?id=122169
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
(BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype.revisionLinksForIteration):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot.prototype.buildLogURLForIteration):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
- 2:49 PM Changeset in webkit [156735] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed build fix after r156730.
https://bugs.webkit.org/show_bug.cgi?id=122021
- platform/win/TestExpectations: Disable a number of tests broken by the switch to the new
CSS/JS-based media controls.
- 2:26 PM Changeset in webkit [156734] by
-
- 2 edits in trunk/Source/JavaScriptCore
Consolidate multiple OSRExit calls into one.
https://bugs.webkit.org/show_bug.cgi?id=122168
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-01
Reviewed by Filip Pizlo.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithDiv):
(JSC::FTL::LowerDFGToLLVM::compileArithMod):
- 2:12 PM Changeset in webkit [156733] by
-
- 3 edits in trunk/Source/WebCore
Cleanup Document::dispatchFullScreenChangeOrErrorEvent
https://bugs.webkit.org/show_bug.cgi?id=122143
Reviewed by Antti Koivisto.
Reduce the code duplication by extracting dispatchFullScreenChangeOrErrorEvent.
- dom/Document.cpp:
(WebCore::Document::fullScreenChangeDelayTimerFired):
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent): Extracted.
- dom/Document.h:
- 1:45 PM Changeset in webkit [156732] by
-
- 2 edits in trunk/LayoutTests
fast/forms/search-event-delay.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=53990
- TestExpectations: Marking as such.
- 1:38 PM Changeset in webkit [156731] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r156725.
http://trac.webkit.org/changeset/156725
https://bugs.webkit.org/show_bug.cgi?id=122176
broke all the mismatch tests again (Requested by thorton on
#webkit).
Tools:
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
LayoutTests:
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Removed.
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Removed.
- 1:33 PM Changeset in webkit [156730] by
-
- 9 edits in trunk
Source/WebCore: [Win] Implement the media controls in JavaScript
https://bugs.webkit.org/show_bug.cgi?id=122166
Reviewed by Jer Noble.
- DerivedSources.make: Uncomment feature flag test.
- WebCore.vcxproj/WebCore.vcxproj: Add new media control implementation files.
Also cleaned up some misplaced files in the project tree.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.vcxproj/WebCoreCommon.props: Add missing include path for the
mediacontrols path.
- WebCore.vcxproj/copyForwardingHeaders.cmd: Add Modules/mediacontrols to copied headers.
- rendering/RenderThemeWin.cpp: Add missing include for UserAgentScripts.
WebKitLibraries: [Win] Implement the media controls in JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=122166
Reviewed by Jer Noble.
- win/tools/vsprops/FeatureDefines.props: Activate the
ENABLE_MEDIA_CONTROLS_SCRIPT flag.
- 1:20 PM Changeset in webkit [156729] by
-
- 8 edits in trunk
Source/WebCore: Added adoptCOM to COMPtr on Windows.
https://bugs.webkit.org/show_bug.cgi?id=122069
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-01
Reviewed by Brent Fulgham.
- platform/win/COMPtr.h:
(adoptCOM): Added.
Source/WebKit/win: Implemented createWebViewWithRequest in WinLauncher.
https://bugs.webkit.org/show_bug.cgi?id=122069
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-01
Reviewed by Brent Fulgham.
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::createWindow):
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchCreatePage):
Pass request url from the NavigationAction to createWebViewWithRequest.
Tools: Implemented createWebViewWithRequest in WinLauncher.
https://bugs.webkit.org/show_bug.cgi?id=122069
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-01
Reviewed by Brent Fulgham.
- WinLauncher/PrintWebUIDelegate.cpp:
(PrintWebUIDelegate::createWebViewWithRequest): Added.
- WinLauncher/PrintWebUIDelegate.h:
Removed createWebViewWithRequest stub.
- 12:55 PM Changeset in webkit [156728] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: evaluate and show a popover for selected text in JS source when paused
https://bugs.webkit.org/show_bug.cgi?id=122151
Reviewed by Joseph Pecoraro.
Identify if the hovered token is contained within the text selection (if any) and use
the selection as the hovered expression to allow the user to select text and hover it
to see what it evaluates to.
- UserInterface/CodeMirrorTokenTrackingController.js:
(WebInspector.CodeMirrorTokenTrackingController.prototype.highlightRange):
Check we're trying to highlight a different range before removing the highlight
and applying the new one, this prevents the marked text from flashing if it's
being re-hovered which would easily happen when hovering multiple tokens within
the same selection.
(WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
In the case where there is selected text, check whether the hovered token is at least
partially contained within the selection, and if so use the selection text as the
hovered expression to evaluate.
- 12:32 PM Changeset in webkit [156727] by
-
- 2 edits in trunk/Source/WebInspectorUI
Console buttons don’t show after page reload
https://bugs.webkit.org/show_bug.cgi?id=116515
Reviewed by Darin Adler.
The correct display of navigation items in the ContentBrowser is contingent on
the ContentViewContainer's _backForwardList being up-to-date when the navigation
items are retrieved from it. However, when the main resource changes (in this case
the user refreshes the browser), calls are made to ContentViewContainer's
closeAllContentViewsOfPrototype() which may modify the _backForwardList but doesn't
necessarily notify of a change to the currentContentView since we may be still showing
the same view in case it wasn't directly related to the main resource, for instance
the console log.
We now check if the _backForwardList is changed as a result of calling
closeAllContentViewsOfPrototype() and in that case also dispatch the
CurrentContentViewDidChange event which will restore the correct state
for the back/forward buttons and navigation items of the navigation bar.
- UserInterface/ContentViewContainer.js:
(WebInspector.ContentViewContainer.prototype.closeAllContentViewsOfPrototype):
Track changes to the _backForwardList and dispatch the CurrentContentViewDidChange
event in case such changes happened.
- 12:31 PM Changeset in webkit [156726] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed build fix; The addedFunction and removedFunction arguments to determineChangedTracksFromNewTracksAndOldItems
were reversed, exposing an underlying, existing bug in AudioTrackPrivate and VideoTrack private. Give a default (null)
value to AudioTrackPrivate::m_client and VideoTrackPrivate::m_client and fix the ordering of arguments in
determineChangedTracksFromNewTracksAndOldItems.
- platform/graphics/AudioTrackPrivate.h:
(WebCore::AudioTrackPrivate::AudioTrackPrivate):
- platform/graphics/VideoTrackPrivate.h:
(WebCore::VideoTrackPrivate::VideoTrackPrivate):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::determineChangedTracksFromNewTracksAndOldItems):
- 11:50 AM Changeset in webkit [156725] by
-
- 3 edits2 adds in trunk
[wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
https://bugs.webkit.org/show_bug.cgi?id=122006
<rdar://problem/15095197>
Reviewed by Dean Jackson.
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
Layer-back the root view in WebKitTestRunner's window, to work around a bug
where the window server snapshot API returns blank snapshots.
Re-landing after r156724, this should not break everything now.
Add a test that ensures that WebKitTestRunner's snapshots are not
completely blank with tiled drawing enabled.
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Added.
- platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Added.
- 11:46 AM Changeset in webkit [156724] by
-
- 6 edits in trunk/Tools
[mac] 1x emulation on Retina hardware shouldn't use SPI
https://bugs.webkit.org/show_bug.cgi?id=122152
<rdar://problem/15119384>
Reviewed by Anders Carlsson.
- DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
(main):
- DumpRenderTree/mac/DumpRenderTreeWindow.h:
- DumpRenderTree/mac/DumpRenderTreeWindow.mm:
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
- WebKitTestRunner/mac/main.mm:
(main):
Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.
- 11:45 AM Changeset in webkit [156723] by
-
- 3 edits in trunk/Source/JavaScriptCore
SpeculativeJIT::m_arguments/m_variables are vestiges of a time long gone
https://bugs.webkit.org/show_bug.cgi?id=122140
Reviewed by Darin Adler.
Just killing code.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::recordSetLocal):
- 11:41 AM WebKitGTK/2.2.x edited by
- (diff)
- 11:40 AM WebKitGTK/2.0.x edited by
- (diff)
- 11:36 AM WebKitGTK/2.2.x edited by
- (diff)
- 11:24 AM Changeset in webkit [156722] by
-
- 7 edits3 copies4 adds in trunk
[Mac] Add support for VideoTrack to MediaPlayerPrivateAVFObjC
https://bugs.webkit.org/show_bug.cgi?id=122122
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/video-track.html
Refactor the methods which query AVAssetTrack and AVPlayerItemTrack into an Impl class, and
use that class to reset the properties of both AudioTrackAVFObjC and the new VideoTrackAVFObjC.
Add new files to project:
- WebCore.xcodeproj/project.pbxproj:
Add the new implementation class, shared by AudioTrackAVFObjC and VideoTrackAVFObjC:
- platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.h: Added.
(WebCore::AVTrackPrivateAVFObjCImpl::create): Simple factory.
(WebCore::AVTrackPrivateAVFObjCImpl::playerItemTrack): Simple getter.
- platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm: Added.
(WebCore::AVTrackPrivateAVFObjCImpl::AVTrackPrivateAVFObjCImpl): Simple constructor.
(WebCore::AVTrackPrivateAVFObjCImpl::enabled): Pass to AVPlayerItemTrack.
(WebCore::AVTrackPrivateAVFObjCImpl::setEnabled): Ditto.
(WebCore::AVTrackPrivateAVFObjCImpl::audioKind): Distinguish between Alternative and Main content.
(WebCore::AVTrackPrivateAVFObjCImpl::videoKind): Distinguish between Alternative, Main, Caption,
and Description content.
(WebCore::AVTrackPrivateAVFObjCImpl::id): Pass to AVAssetTrack.
(WebCore::AVTrackPrivateAVFObjCImpl::label): Retrieve the Title metadata in the user's preferred
language.
(WebCore::AVTrackPrivateAVFObjCImpl::language): Pass to languageForAVAssetTrack.
(WebCore::AVTrackPrivateAVFObjCImpl::languageForAVAssetTrack): Moved from AudioTrackPrivateAVFObjC.
- platform/graphics/avfoundation/VideoTrackPrivateAVF.h: Copied from Source/WebCore/platform/graphics/avfoundation/AudioTrackPrivateAVF.h.
(WebCore::VideoTrackPrivateAVF::kind): Simple getter.
(WebCore::VideoTrackPrivateAVF::id): Ditto.
(WebCore::VideoTrackPrivateAVF::label): Ditto.
(WebCore::VideoTrackPrivateAVF::language): Ditto.
(WebCore::VideoTrackPrivateAVF::setKind): Simple setter.
(WebCore::VideoTrackPrivateAVF::setId): Ditto.
(WebCore::VideoTrackPrivateAVF::setLabel): Ditto.
(WebCore::VideoTrackPrivateAVF::setLanguage): Ditto.
(WebCore::VideoTrackPrivateAVF::VideoTrackPrivateAVF): Simple constructor.
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
(WebCore::AudioTrackPrivateAVFObjC::AudioTrackPrivateAVFObjC): Create a AVTrackPrivateAVFObjCImpl.
(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack): Retrieve properties from m_impl.
(WebCore::AudioTrackPrivateAVFObjC::setPlayerItemTrack): Create a new AVTrackPrivateAVFObjCImpl.
(WebCore::AudioTrackPrivateAVFObjC::playerItemTrack): Pass to m_impl.
(WebCore::AudioTrackPrivateAVFObjC::setEnabled): Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Refactor implementation into
template method determineChangedTracksFromNewTracksAndOldItems().
(WebCore::determineChangedTracksFromNewTracksAndOldItems): Refactored.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks): Pass to determineChangedTracksFromNewTracksAndOldItems.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Changed class hosting
languageForAVAssetTrack.
- platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.cpp: Added.
(WebCore::VideoTrackPrivateAVFObjC::VideoTrackPrivateAVFObjC): Create a AVTrackPrivateAVFObjCImpl.
(WebCore::VideoTrackPrivateAVFObjC::resetPropertiesFromTrack): Retrieve properties from m_impl.
(WebCore::VideoTrackPrivateAVFObjC::setPlayerItemTrack): Create a new AVTrackPrivateAVFObjCImpl.
(WebCore::VideoTrackPrivateAVFObjC::playerItemTrack): Pass to m_impl.
(WebCore::VideoTrackPrivateAVFObjC::setSelected): Ditto.
- platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h: Added.
(WebCore::VideoTrackPrivateAVFObjC::create): Simple factory.
LayoutTests:
- media/track/video-track-expected.txt: Added.
- media/track/video-track.html: Added.
- 10:22 AM Changeset in webkit [156721] by
-
- 5 edits in branches/safari-537.73-branch/Source
Versioning.
- 10:20 AM Changeset in webkit [156720] by
-
- 7 edits in branches/safari-537.73-branch/Source
rollout 156718.
- 10:20 AM Changeset in webkit [156719] by
-
- 23 edits in trunk/Source/WebCore
Leaf EventTarget subclasses should be FINAL.
<https://webkit.org/b/122141>
Reviewed by Darin Adler.
Clear out a slew of FIXMEs now that HasMemoryCostMemberFunction
works on classes marked FINAL (fixed in bug 121747.)
- 10:19 AM Changeset in webkit [156718] by
-
- 7 edits in branches/safari-537.73-branch/Source
Versioning.
- 10:03 AM Changeset in webkit [156717] by
-
- 2 edits in trunk/Source/WebCore
Rename URL type variables in Curl network backend.
https://bugs.webkit.org/show_bug.cgi?id=122158
Patch by Szabolcs Dávid <davidsz@inf.u-szeged.hu> on 2013-10-01
Reviewed by Darin Adler.
I changed the name of the URL objects to match with the new class name.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::getProtectionSpace):
(WebCore::ResourceHandleManager::initializeHandle):
- 9:59 AM Changeset in webkit [156716] by
-
- 4 edits in trunk
Center misspelling dots across width of word
https://bugs.webkit.org/show_bug.cgi?id=122046
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-01
Reviewed by Darin Adler.
Source/WebCore:
Test: editing/spelling/spelling.html
- platform/graphics/GraphicsContext.h:
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawLineForDocumentMarker):
LayoutTests:
This patch only rebaselines a single test. I would have rebaselined
the rest of the tests, but they seem to be affected by
webkit.org/b/122146. I don't want to commit incorrect expected results.
- platform/mac/editing/spelling/spelling-expected.png:
- 9:40 AM Changeset in webkit [156715] by
-
- 5 edits in trunk/Source/WebCore
[iOS] WebCore fails to build with newer versions of clang
https://bugs.webkit.org/show_bug.cgi?id=122161
Reviewed by Darin Adler.
- editing/FrameSelection.cpp: Add ENABLE(TEXT_CARET)-guard around shouldStopBlinkingDueToTypingCommand().
- page/EventHandler.cpp: Add !PLATFORM(IOS)-guard around constants cursorUpdateInterval and maximumCursorSize;
also add touch event/gesture event guard around shouldGesturesTriggerActive().
- platform/network/cf/ResourceResponseCFNet.cpp: Remove unused function filenameHasSaneExtension.
- platform/network/mac/ResourceResponseMac.mm: Only define static variables commonHeaderFields when building
without CFNetwork; also remove variable numCommonHeaderFields, instead use WTF_ARRAY_LENGTH(commonHeaderFields)
to compute the size of the fixed-sized array commonHeaderFields.
- 9:39 AM Changeset in webkit [156714] by
-
- 2 edits in trunk/Source/JavaScriptCore
[iOS] JavaScriptCore fails to build with newer versions of clang
https://bugs.webkit.org/show_bug.cgi?id=122162
Reviewed by Darin Adler.
- runtime/GCActivityCallback.cpp: Add !PLATFORM(IOS)-guard around constant pagingTimeOut
as we don't compile the code that uses it on iOS.
- 9:26 AM Changeset in webkit [156713] by
-
- 24 edits2 copies1 add in trunk
[GStreamer] Support "chapter" text tracks
https://bugs.webkit.org/show_bug.cgi?id=122000
Patch by Brendan Long <b.long@cablelabs.com> on 2013-10-01
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/in-band/track-in-band-mkv-chapters.html
- platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h: New class, needed for cues that aren't associated with GstPads.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Check for table of contents messages.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents): Parse table of contents messages into text tracks.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContentsEntry): Recursive method for parsing all of the TOC entries.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Add the processTableOfContents functions.
LayoutTests:
- media/content/counting-subtitled-srt.mkv: Added chapters metadata.
- media/track/in-band/track-in-band-mkv-chapters-expected.txt: New test, similar to cues-added-one, but uses "chapters" track.
- media/track/in-band/track-in-band-mkv-chapters.html: Same.
- media/in-band-cues.js: Updated tests to handle the new "chapters" track.
- media/track/in-band/track-in-band-kate-ogg-cues-added-once-expected.txt: Same.
- media/track/in-band/track-in-band-kate-ogg-cues-added-once.html: Same.
- media/track/in-band/track-in-band-kate-ogg-mode-expected.txt: Same.
- media/track/in-band/track-in-band-kate-ogg-mode.html: Same.
- media/track/in-band/track-in-band-kate-ogg-style-expected.txt: Same.
- media/track/in-band/track-in-band-kate-ogg-track-order-expected.txt: Same.
- media/track/in-band/track-in-band-kate-ogg-track-order.html: Same.
- media/track/in-band/track-in-band-srt-mkv-cues-added-once-expected.txt: Same.
- media/track/in-band/track-in-band-srt-mkv-cues-added-once.html: Same.
- media/track/in-band/track-in-band-srt-mkv-kind-expected.txt: Same.
- media/track/in-band/track-in-band-srt-mkv-kind.html: Same.
- media/track/in-band/track-in-band-srt-mkv-language-expected.txt: Same.
- media/track/in-band/track-in-band-srt-mkv-language.html: Same.
- media/track/in-band/track-in-band-srt-mkv-mode-expected.txt: Same.
- media/track/in-band/track-in-band-srt-mkv-mode.html: Same.
- media/track/in-band/track-in-band-srt-mkv-style-expected.txt: Same.
- media/track/in-band/track-in-band-srt-mkv-track-order-expected.txt: Same.
- media/track/in-band/track-in-band-srt-mkv-track-order.html: Same.
- 9:14 AM Changeset in webkit [156712] by
-
- 2 edits in trunk/LayoutTests
Try to get another Windows test to pass.
- platform/win/js/dom/global-constructors-attributes-expected.txt: Removed one
more class (Notification) for a feature turned off for the Windows platform.
- 8:02 AM Changeset in webkit [156711] by
-
- 1 edit1 add in trunk/LayoutTests
Try to get another Windows test to pass.
- platform/win/js/dom/global-constructors-attributes-expected.txt: Added.
Copy of the platform-independent results file, with items deleted for features
that are currently turned off for the Windows platform.
- 7:58 AM Changeset in webkit [156710] by
-
- 3 edits in trunk/Source/WebCore
[Texmap] CSS filter not working on software composited layers
https://bugs.webkit.org/show_bug.cgi?id=122159
Reviewed by Noam Rosenthal.
Tell the rendering layer we do not support CSS filters when we do not. This
will make RenderLayer fall back to using its own software implementation.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setFilters):
- platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::applyFilters):
- 5:34 AM Changeset in webkit [156709] by
-
- 2 edits in trunk/Source/WebCore
Try to fix assertion failures seem on bots.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::createFilterOperations): Rearrange code so this
won't try ot call toCSSPrimitiveValue on a non-primitive-value in the
DROP_SHADOW case.
- 5:09 AM Changeset in webkit [156708] by
-
- 1 edit in trunk/Source/WebCore/ChangeLog
Fix the 'InexedDB' typo in the ChangeLog that I failed to address prior to landing r156701.
- 4:57 AM Changeset in webkit [156707] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening. Adding failure expectations for currently failing tests.
- platform/gtk/TestExpectations:
- 4:38 AM Changeset in webkit [156706] by
-
- 9 edits in trunk/Source/WebKit2
[Qt][WK2] Fix build after r156688.
https://bugs.webkit.org/show_bug.cgi?id=122153
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-10-01
Reviewed by Allan Sandfeld Jensen.
- Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::createGraphicsContext):
- UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::createDrawingAreaProxy):
- UIProcess/API/qt/qquickwebview_p_p.h:
- UIProcess/API/qt/raw/qrawwebview.cpp:
(QRawWebViewPrivate::createDrawingAreaProxy):
- UIProcess/API/qt/raw/qrawwebview_p_p.h:
- UIProcess/qt/QtPageClient.cpp:
(WebKit::QtPageClient::createDrawingAreaProxy):
- UIProcess/qt/QtPageClient.h:
- WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:
(WebKit::convertQPixmapToShareableBitmap):
- 3:50 AM Changeset in webkit [156705] by
-
- 21 edits in trunk/Source/WebCore
Generate toCSSFooValue for CSSPrimitiveValue
https://bugs.webkit.org/show_bug.cgi?id=122101
Reviewed by Antti Koivisto.
As a step of clean-up static_cast<> in CSSValues, this patch generates
toCSSFooPrimitiveValue() in order to detect bad casts as well as improves
code readability.
No new tests, no behavior changes.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::subimageIsPending):
(WebCore::CSSImageGeneratorValue::cachedImageForCSSValue):
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::fillImageSet):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::parseRadialGradient):
- css/CSSPrimitiveValue.h:
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillAttachment):
(WebCore::CSSToStyleMap::mapFillClip):
(WebCore::CSSToStyleMap::mapFillComposite):
(WebCore::CSSToStyleMap::mapFillBlendMode):
(WebCore::CSSToStyleMap::mapFillOrigin):
(WebCore::CSSToStyleMap::mapFillRepeatX):
(WebCore::CSSToStyleMap::mapFillRepeatY):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapFillMaskSourceType):
(WebCore::CSSToStyleMap::mapAnimationDelay):
(WebCore::CSSToStyleMap::mapAnimationDirection):
(WebCore::CSSToStyleMap::mapAnimationDuration):
(WebCore::CSSToStyleMap::mapAnimationFillMode):
(WebCore::CSSToStyleMap::mapAnimationIterationCount):
(WebCore::CSSToStyleMap::mapAnimationName):
(WebCore::CSSToStyleMap::mapAnimationPlayState):
(WebCore::CSSToStyleMap::mapAnimationProperty):
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
(WebCore::CSSToStyleMap::mapNinePieceImageRepeat):
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyMarqueeIncrement::applyValue):
(WebCore::ApplyPropertyMarqueeRepetition::applyValue):
(WebCore::ApplyPropertyMarqueeSpeed::applyValue):
(WebCore::ApplyPropertyTextUnderlinePosition::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
- css/MediaList.cpp:
(WebCore::reportMediaQueryWarningIfNeeded):
- css/MediaQueryEvaluator.cpp:
(WebCore::numberValue):
(WebCore::orientationMediaFeatureEval):
(WebCore::evalResolution):
(WebCore::device_pixel_ratioMediaFeatureEval):
(WebCore::resolutionMediaFeatureEval):
(WebCore::computeLength):
(WebCore::view_modeMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getLayeredShorthandValue):
- css/StyleResolver.cpp:
(WebCore::createGridTrackSize):
(WebCore::createGridTrackList):
(WebCore::createGridPosition):
(WebCore::hasVariableReference):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::parseCustomFilterArrayParameter):
(WebCore::StyleResolver::parseCustomFilterColorParameter):
(WebCore::StyleResolver::parseCustomFilterNumberParameter):
(WebCore::StyleResolver::parseCustomFilterParameter):
(WebCore::StyleResolver::parseCustomFilterParameterList):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):
- css/TransformFunctions.cpp:
(WebCore::transformsForValue):
- css/ViewportStyleResolver.cpp:
(WebCore::ViewportStyleResolver::getViewportArgumentValue):
- css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::computedFontSize):
- editing/EditingStyle.cpp:
(WebCore::identifierForStyleProperty):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(WebCore::cssValueToRGBA):
(WebCore::EditingStyle::extractFontSizeDelta):
(WebCore::EditingStyle::textDirection):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::EditingStyle::legacyFontSize):
(WebCore::EditingStyle::textDirectionForSelection):
(WebCore::StyleChange::extractTextStyles):
(WebCore::fontWeightIsBold):
(WebCore::isTransparentColorValue):
- editing/markup.cpp:
(WebCore::propertyMissingOrEqualToNone):
- 3:36 AM Changeset in webkit [156704] by
-
- 1 edit25 moves2 adds in trunk/LayoutTests
Move platform-specific test results from js to js/dom to match moves in r156066.
I see multiple check-ins with people doing this for some files, but these seem to have been missed.
Maybe some of these are unneeded and can be removed.
My hope is that this might help with some failures seen on the Windows bot.
- platform/blackberry/js/dom/constructor-length-expected.txt: Renamed from LayoutTests/platform/blackberry/js/constructor-length-expected.txt.
- platform/efl/js/dom/constructor-length-expected.txt: Renamed from LayoutTests/platform/efl/js/constructor-length-expected.txt.
- platform/efl/js/dom/dom-static-property-for-in-iteration-expected.txt: Renamed from LayoutTests/platform/efl/js/dom-static-property-for-in-iteration-expected.txt.
- platform/efl/js/dom/exception-linenums-in-html-3-expected.png: Renamed from LayoutTests/platform/efl/js/exception-linenums-in-html-3-expected.png.
- platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Renamed from LayoutTests/platform/efl/js/global-constructors-attributes-dedicated-worker-expected.txt.
- platform/efl/js/dom/global-constructors-attributes-shared-worker-expected.txt: Renamed from LayoutTests/platform/efl/js/global-constructors-attributes-shared-worker-expected.txt.
- platform/efl/js/dom/missing-style-end-tag-js-expected.png: Renamed from LayoutTests/platform/efl/js/missing-style-end-tag-js-expected.png.
- platform/efl/js/dom/missing-title-end-tag-js-expected.png: Renamed from LayoutTests/platform/efl/js/missing-title-end-tag-js-expected.png.
- platform/gtk/js/dom/constructor-length-expected.txt: Renamed from LayoutTests/platform/gtk/js/constructor-length-expected.txt.
- platform/gtk/js/dom/exception-linenums-in-html-3-expected.png: Renamed from LayoutTests/platform/gtk/js/exception-linenums-in-html-3-expected.png.
- platform/gtk/js/dom/missing-style-end-tag-js-expected.png: Renamed from LayoutTests/platform/gtk/js/missing-style-end-tag-js-expected.png.
- platform/gtk/js/dom/missing-title-end-tag-js-expected.png: Renamed from LayoutTests/platform/gtk/js/missing-title-end-tag-js-expected.png.
- platform/mac/js/dom/exception-linenums-in-html-3-expected.png: Renamed from LayoutTests/platform/mac/js/exception-linenums-in-html-3-expected.png.
- platform/mac/js/dom/missing-style-end-tag-js-expected.png: Renamed from LayoutTests/platform/mac/js/missing-style-end-tag-js-expected.png.
- platform/mac/js/dom/missing-title-end-tag-js-expected.png: Renamed from LayoutTests/platform/mac/js/missing-title-end-tag-js-expected.png.
- platform/qt/js/dom/constructor-length-expected.txt: Renamed from LayoutTests/platform/qt/js/constructor-length-expected.txt.
- platform/qt/js/dom/date-DST-time-cusps-expected.txt: Renamed from LayoutTests/platform/qt/js/date-DST-time-cusps-expected.txt.
- platform/qt/js/dom/dom-static-property-for-in-iteration-expected.txt: Renamed from LayoutTests/platform/qt/js/dom-static-property-for-in-iteration-expected.txt.
- platform/qt/js/dom/exception-linenums-in-html-3-expected.png: Renamed from LayoutTests/platform/qt/js/exception-linenums-in-html-3-expected.png.
- platform/qt/js/dom/missing-style-end-tag-js-expected.png: Renamed from LayoutTests/platform/qt/js/missing-style-end-tag-js-expected.png.
- platform/qt/js/dom/missing-title-end-tag-js-expected.png: Renamed from LayoutTests/platform/qt/js/missing-title-end-tag-js-expected.png.
- platform/qt/js/dom/switch-behaviour-expected.txt: Renamed from LayoutTests/platform/qt/js/switch-behaviour-expected.txt.
- platform/win/js/dom/dom-static-property-for-in-iteration-expected.txt: Renamed from LayoutTests/platform/win/js/dom-static-property-for-in-iteration-expected.txt.
- platform/win/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Renamed from LayoutTests/platform/win/js/global-constructors-attributes-dedicated-worker-expected.txt.
- platform/win/js/dom/global-constructors-attributes-shared-worker-expected.txt: Renamed from LayoutTests/platform/win/js/global-constructors-attributes-shared-worker-expected.txt.
- 2:59 AM Changeset in webkit [156703] by
-
- 2 edits in trunk/Source/WebCore
Try to fix AVFoundation crashes seen on Lion bot.
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
Four AVFoundation string constants used in this file were new to 10.8.
For older versions of OS X, use hard-coded string constants instead.
- 2:37 AM Changeset in webkit [156702] by
-
- 6 edits6 adds2 deletes in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining after r156527, moving baselines specific to GTK WK1
under the platform/gtk-wk1 directory.
- platform/gtk-wk1/js: Added.
- platform/gtk-wk1/js/dom: Added.
- platform/gtk-wk1/js/dom/function-length-expected.txt: Added.
- platform/gtk-wk1/scrollingcoordinator: Added.
- platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
- platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.
- platform/gtk/js/dom/function-length-expected.txt: Removed.
- platform/gtk/scrollingcoordinator: Removed.
- platform/gtk/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Removed.
- platform/gtk/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Removed.
- platform/gtk/svg/custom/SVGPoint-matrixTransform-expected.txt:
- platform/gtk/svg/custom/getTransformToElement-expected.txt:
- platform/gtk/svg/custom/text-ctm-expected.txt:
- platform/gtk/svg/custom/text-hit-test-expected.txt:
- platform/gtk/svg/text/append-text-node-to-tspan-expected.txt:
- 1:12 AM Changeset in webkit [156701] by
-
- 5 edits in trunk/Source/WebCore
[InexedDB] Interfaces inheriting from EventTarget should generate JSC (un)wrapping functions
https://bugs.webkit.org/show_bug.cgi?id=122114
Reviewed by Darin Adler.
After r156590, four IndexedDB interfaces are inheriting from the EventTarget interface. Because of that,
they're now required to have interface-specific JSC wrapping and unwrapping functions generated since the
JSC wrapping and unwrapping functions for the EventTarget interface delegate these operations to these
interface-specific functions. If the functions are not generated and accessible, the EventTarget functions
end up recursively calling themselves.
- Modules/indexeddb/IDBDatabase.idl:
- Modules/indexeddb/IDBOpenDBRequest.idl:
- Modules/indexeddb/IDBRequest.idl:
- Modules/indexeddb/IDBTransaction.idl:
Sep 30, 2013:
- 11:37 PM Changeset in webkit [156700] by
-
- 18 edits in trunk/Source
Build fix for EFL, Qt, Gtk port after r156688
https://bugs.webkit.org/show_bug.cgi?id=122139
Reviewed by Anders Carlsson.
Get rid of more uses of OwnPtr and PassOwnPtr.
Source/WebCore:
- platform/graphics/surfaces/GraphicsSurface.cpp:
(WebCore::GraphicsSurface::beginPaint):
- platform/graphics/surfaces/GraphicsSurface.h:
- platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp:
(WebCore::GraphicsSurface::platformBeginPaint):
- platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurface::platformBeginPaint):
- platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:
(WebCore::GraphicsSurface::platformBeginPaint):
Source/WebKit2:
- Shared/API/c/cairo/WKImageCairo.cpp:
(WKImageCreateFromCairoSurface):
- Shared/API/c/qt/WKImageQt.cpp:
(WKImageCreateFromQImage):
- Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
(WebKit::WebCoordinatedSurface::createGraphicsContext):
(WebKit::WebCoordinatedSurface::paintToSurface):
- Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
- Shared/cairo/ShareableBitmapCairo.cpp:
(WebKit::ShareableBitmap::createGraphicsContext):
- Shared/gtk/ArgumentCodersGtk.cpp:
(CoreIPC::encodeImage):
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::createDrawingAreaProxy):
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::createDrawingAreaProxy):
- UIProcess/CoordinatedGraphics/WebView.h:
- WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
(WebKit::convertCairoSurfaceToShareableBitmap):
- 11:12 PM Changeset in webkit [156699] by
-
- 3 edits in trunk/LayoutTests
Layout Test media/click-volume-bar-not-pausing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122126
Reviewed by Darin Adler.
Speculative partial fix.
I'm not sure if it's possible to make this test completely controlled without
DOMFrameContentLoaded support - we need to do work when the <video> element is
already present, but playback hasn't started yet. As media documents use autoplay,
there is a race between load and playing events.
- media/click-volume-bar-not-pausing-expected.txt:
- media/click-volume-bar-not-pausing.html:
- Add video URL after initial content fully loads to avoid races with that.
- Added some state logging for clarity.
- Only listen for "playing" event once. If playback already started, we have a playing event already queued, and would add another one with pause()/play().
- 10:58 PM Changeset in webkit [156698] by
-
- 5 edits2 adds in trunk
AX: Expose ARIA Busy Notifications
https://bugs.webkit.org/show_bug.cgi?id=121451
Patch by Sam White <Samuel White> on 2013-09-30
Reviewed by Chris Fleizach.
Source/WebCore:
Added AXElementBusyChanged notification that posts when aria-busy is toggled. This
enables screen readers to detect busy states without polling the focused element.
Test: platform/mac/accessibility/element-busy-changed.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChanged):
- accessibility/AXObjectCache.h:
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
LayoutTests:
Added test to verify that elements post AXElementBusyChanged notifications when aria-busy is toggled.
- platform/mac/accessibility/element-busy-changed-expected.txt: Added.
- platform/mac/accessibility/element-busy-changed.html: Added.
- 10:16 PM Changeset in webkit [156697] by
-
- 2 edits in trunk/Source/WebKit/efl
Fix the build.
- ewk/ewk_settings.cpp:
- 10:10 PM Changeset in webkit [156696] by
-
- 2 edits in trunk/Source/WebCore
Fixing the build.
- GNUmakefile.list.am:
- 9:59 PM Changeset in webkit [156695] by
-
- 5 edits in trunk/Source/WebCore
More build fixing.
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- inspector/InspectorAllInOne.cpp:
- inspector/InstrumentingAgents.h:
- 9:57 PM Changeset in webkit [156694] by
-
- 3 edits in trunk/Tools
check-webkit-style should not warn about use of C++11 “>>” instead of “> >"
https://bugs.webkit.org/show_bug.cgi?id=116474
Patch by Sam Weinig <sam@webkit.org> on 2013-09-30
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/style/checkers/cpp.py:
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
- 9:47 PM Changeset in webkit [156693] by
-
- 4 edits in trunk/Source/WebCore
Fix the Efl and Gtk builds.
- GNUmakefile.list.am:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- 9:33 PM Changeset in webkit [156692] by
-
- 75 edits51 deletes in trunk
Remove support for DOMFileSystem
https://bugs.webkit.org/show_bug.cgi?id=122137
Reviewed by Anders Carlsson.
.:
- Source/autotools/SetupWebKitFeatures.m4:
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Files elided *
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::clearWebFileSystem):
- WebCoreSupport/AboutDataEnableFeatures.in:
Source/WebKit/efl:
- ewk/ewk_settings.cpp:
(ewk_settings_file_system_path_set):
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_spacing_for_binary_ops):
- qmake/mkspecs/features/features.pri:
LayoutTests:
- fast/dom/MutationObserver/filesystem-callback-delivery-expected.txt: Removed.
- fast/dom/MutationObserver/filesystem-callback-delivery.html: Removed.
- fast/filesystem: Removed.
- fast/filesystem/async-operations-expected.txt: Removed.
- fast/filesystem/async-operations.html: Removed.
- fast/filesystem/cross-filesystem-op-expected.txt: Removed.
- fast/filesystem/cross-filesystem-op.html: Removed.
- fast/filesystem/directory-entry-to-uri-expected.txt: Removed.
- fast/filesystem/directory-entry-to-uri.html: Removed.
- fast/filesystem/entry-points-missing-arguments-expected.txt: Removed.
- fast/filesystem/entry-points-missing-arguments.html: Removed.
- fast/filesystem/file-after-reload-crash-expected.txt: Removed.
- fast/filesystem/file-after-reload-crash.html: Removed.
- fast/filesystem/file-entry-to-uri-expected.txt: Removed.
- fast/filesystem/file-entry-to-uri.html: Removed.
- fast/filesystem/file-from-file-entry-expected.txt: Removed.
- fast/filesystem/file-from-file-entry.html: Removed.
- fast/filesystem/file-metadata-after-write-expected.txt: Removed.
- fast/filesystem/file-metadata-after-write.html: Removed.
- fast/filesystem/file-writer-abort-continue-expected.txt: Removed.
- fast/filesystem/file-writer-abort-continue.html: Removed.
- fast/filesystem/file-writer-abort-depth-expected.txt: Removed.
- fast/filesystem/file-writer-abort-depth.html: Removed.
- fast/filesystem/file-writer-abort-expected.txt: Removed.
- fast/filesystem/file-writer-abort.html: Removed.
- fast/filesystem/file-writer-empty-blob-expected.txt: Removed.
- fast/filesystem/file-writer-empty-blob.html: Removed.
- fast/filesystem/file-writer-events-expected.txt: Removed.
- fast/filesystem/file-writer-events.html: Removed.
- fast/filesystem/file-writer-gc-blob-expected.txt: Removed.
- fast/filesystem/file-writer-gc-blob.html: Removed.
- fast/filesystem/file-writer-truncate-extend-expected.txt: Removed.
- fast/filesystem/file-writer-truncate-extend.html: Removed.
- fast/filesystem/file-writer-write-overlapped-expected.txt: Removed.
- fast/filesystem/file-writer-write-overlapped.html: Removed.
- fast/filesystem/filesystem-missing-arguments-expected.txt: Removed.
- fast/filesystem/filesystem-missing-arguments.html: Removed.
- fast/filesystem/filesystem-no-callback-null-ptr-crash-expected.txt: Removed.
- fast/filesystem/filesystem-no-callback-null-ptr-crash.html: Removed.
- fast/filesystem/filesystem-reference-expected.txt: Removed.
- fast/filesystem/filesystem-reference.html: Removed.
- fast/filesystem/filesystem-unserializable-expected.txt: Removed.
- fast/filesystem/filesystem-unserializable.html: Removed.
- fast/filesystem/filesystem-uri-origin-expected.txt: Removed.
- fast/filesystem/filesystem-uri-origin.html: Removed.
- fast/filesystem/flags-passing-expected.txt: Removed.
- fast/filesystem/flags-passing.html: Removed.
- fast/filesystem/input-access-entries-expected.txt: Removed.
- fast/filesystem/input-access-entries.html: Removed.
- fast/filesystem/not-enough-arguments-expected.txt: Removed.
- fast/filesystem/not-enough-arguments.html: Removed.
- fast/filesystem/op-copy-expected.txt: Removed.
- fast/filesystem/op-copy.html: Removed.
- fast/filesystem/op-get-entry-expected.txt: Removed.
- fast/filesystem/op-get-entry.html: Removed.
- fast/filesystem/op-get-metadata-expected.txt: Removed.
- fast/filesystem/op-get-metadata.html: Removed.
- fast/filesystem/op-get-parent-expected.txt: Removed.
- fast/filesystem/op-get-parent.html: Removed.
- fast/filesystem/op-move-expected.txt: Removed.
- fast/filesystem/op-move.html: Removed.
- fast/filesystem/op-read-directory-expected.txt: Removed.
- fast/filesystem/op-read-directory.html: Removed.
- fast/filesystem/op-remove-expected.txt: Removed.
- fast/filesystem/op-remove.html: Removed.
- fast/filesystem/op-restricted-chars-expected.txt: Removed.
- fast/filesystem/op-restricted-chars.html: Removed.
- fast/filesystem/op-restricted-names-expected.txt: Removed.
- fast/filesystem/op-restricted-names.html: Removed.
- fast/filesystem/op-restricted-unicode-expected.txt: Removed.
- fast/filesystem/op-restricted-unicode.html: Removed.
- fast/filesystem/read-directory-expected.txt: Removed.
- fast/filesystem/read-directory.html: Removed.
- fast/filesystem/resources: Removed.
- fast/filesystem/resources/async-operations.js: Removed.
- fast/filesystem/resources/directory-entry-to-uri.js: Removed.
- fast/filesystem/resources/file-entry-to-uri-sync.js: Removed.
- fast/filesystem/resources/file-entry-to-uri.js: Removed.
- fast/filesystem/resources/file-from-file-entry-sync.js: Removed.
- fast/filesystem/resources/file-from-file-entry.js: Removed.
- fast/filesystem/resources/file-writer-abort-continue.js: Removed.
- fast/filesystem/resources/file-writer-abort-depth.js: Removed.
- fast/filesystem/resources/file-writer-abort.js: Removed.
- fast/filesystem/resources/file-writer-empty-blob.js: Removed.
- fast/filesystem/resources/file-writer-events.js: Removed.
- fast/filesystem/resources/file-writer-gc-blob.js: Removed.
- fast/filesystem/resources/file-writer-sync-truncate-extend.js: Removed.
- fast/filesystem/resources/file-writer-sync-write-overlapped.js: Removed.
- fast/filesystem/resources/file-writer-truncate-extend.js: Removed.
- fast/filesystem/resources/file-writer-utils.js: Removed.
- fast/filesystem/resources/file-writer-write-overlapped.js: Removed.
- fast/filesystem/resources/fs-test-util.js: Removed.
- fast/filesystem/resources/fs-worker-common.js: Removed.
- fast/filesystem/resources/op-copy.js: Removed.
- fast/filesystem/resources/op-get-entry.js: Removed.
- fast/filesystem/resources/op-get-metadata.js: Removed.
- fast/filesystem/resources/op-get-parent.js: Removed.
- fast/filesystem/resources/op-move.js: Removed.
- fast/filesystem/resources/op-read-directory.js: Removed.
- fast/filesystem/resources/op-remove.js: Removed.
- fast/filesystem/resources/op-restricted-chars.js: Removed.
- fast/filesystem/resources/op-restricted-names.js: Removed.
- fast/filesystem/resources/op-restricted-unicode.js: Removed.
- fast/filesystem/resources/op-tests-helper.js: Removed.
- fast/filesystem/resources/shared-worker-stub.js: Removed.
- fast/filesystem/resources/simple-persistent-sync.js: Removed.
- fast/filesystem/resources/simple-persistent.js: Removed.
- fast/filesystem/resources/simple-readonly.js: Removed.
- fast/filesystem/resources/simple-required-arguments-getdirectory.js: Removed.
- fast/filesystem/resources/simple-required-arguments-getfile.js: Removed.
- fast/filesystem/resources/simple-required-arguments-getmetadata.js: Removed.
- fast/filesystem/resources/simple-required-arguments-remove.js: Removed.
- fast/filesystem/resources/simple-temporary-sync.js: Removed.
- fast/filesystem/resources/simple-temporary.js: Removed.
- fast/filesystem/resources/sync-operations.js: Removed.
- fast/filesystem/script-tests: Removed.
- fast/filesystem/script-tests/TEMPLATE.html: Removed.
- fast/filesystem/script-tests/filesystem-reference.js: Removed.
- fast/filesystem/script-tests/filesystem-unserializable.js: Removed.
- fast/filesystem/script-tests/flags-passing.js: Removed.
- fast/filesystem/script-tests/read-directory.js: Removed.
- fast/filesystem/simple-persistent-expected.txt: Removed.
- fast/filesystem/simple-persistent.html: Removed.
- fast/filesystem/simple-readonly-expected.txt: Removed.
- fast/filesystem/simple-readonly-file-object-expected.txt: Removed.
- fast/filesystem/simple-readonly-file-object.html: Removed.
- fast/filesystem/simple-readonly.html: Removed.
- fast/filesystem/simple-required-arguments-getdirectory-expected.txt: Removed.
- fast/filesystem/simple-required-arguments-getdirectory.html: Removed.
- fast/filesystem/simple-required-arguments-getfile-expected.txt: Removed.
- fast/filesystem/simple-required-arguments-getfile.html: Removed.
- fast/filesystem/simple-required-arguments-getmetadata-expected.txt: Removed.
- fast/filesystem/simple-required-arguments-getmetadata.html: Removed.
- fast/filesystem/simple-required-arguments-remove-expected.txt: Removed.
- fast/filesystem/simple-required-arguments-remove.html: Removed.
- fast/filesystem/simple-temporary-expected.txt: Removed.
- fast/filesystem/simple-temporary.html: Removed.
- fast/filesystem/workers: Removed.
- fast/filesystem/workers/async-operations-expected.txt: Removed.
- fast/filesystem/workers/async-operations.html: Removed.
- fast/filesystem/workers/detached-frame-crash-expected.txt: Removed.
- fast/filesystem/workers/detached-frame-crash.html: Removed.
- fast/filesystem/workers/file-entry-to-uri-sync-expected.txt: Removed.
- fast/filesystem/workers/file-entry-to-uri-sync.html: Removed.
- fast/filesystem/workers/file-from-file-entry-expected.txt: Removed.
- fast/filesystem/workers/file-from-file-entry-sync-expected.txt: Removed.
- fast/filesystem/workers/file-from-file-entry-sync.html: Removed.
- fast/filesystem/workers/file-from-file-entry.html: Removed.
- fast/filesystem/workers/file-writer-empty-blob-expected.txt: Removed.
- fast/filesystem/workers/file-writer-empty-blob.html: Removed.
- fast/filesystem/workers/file-writer-events-expected.txt: Removed.
- fast/filesystem/workers/file-writer-events-shared-worker-expected.txt: Removed.
- fast/filesystem/workers/file-writer-events-shared-worker.html: Removed.
- fast/filesystem/workers/file-writer-events.html: Removed.
- fast/filesystem/workers/file-writer-gc-blob-expected.txt: Removed.
- fast/filesystem/workers/file-writer-gc-blob.html: Removed.
- fast/filesystem/workers/file-writer-sync-truncate-extend-expected.txt: Removed.
- fast/filesystem/workers/file-writer-sync-truncate-extend.html: Removed.
- fast/filesystem/workers/file-writer-sync-write-overlapped-expected.txt: Removed.
- fast/filesystem/workers/file-writer-sync-write-overlapped.html: Removed.
- fast/filesystem/workers/file-writer-truncate-extend-expected.txt: Removed.
- fast/filesystem/workers/file-writer-truncate-extend.html: Removed.
- fast/filesystem/workers/file-writer-write-overlapped-expected.txt: Removed.
- fast/filesystem/workers/file-writer-write-overlapped.html: Removed.
- fast/filesystem/workers/resources: Removed.
- fast/filesystem/workers/resources/detached-frame-crash-frame.html: Removed.
- fast/filesystem/workers/resources/detached-frame-crash-worker.js: Removed.
- fast/filesystem/workers/simple-persistent-expected.txt: Removed.
- fast/filesystem/workers/simple-persistent-sync-expected.txt: Removed.
- fast/filesystem/workers/simple-persistent-sync.html: Removed.
- fast/filesystem/workers/simple-persistent.html: Removed.
- fast/filesystem/workers/simple-temporary-expected.txt: Removed.
- fast/filesystem/workers/simple-temporary-sync-expected.txt: Removed.
- fast/filesystem/workers/simple-temporary-sync.html: Removed.
- fast/filesystem/workers/simple-temporary.html: Removed.
- fast/filesystem/workers/sync-operations-expected.txt: Removed.
- fast/filesystem/workers/sync-operations.html: Removed.
- fast/forms/file/input-file-entries-expected.txt: Removed.
- fast/forms/file/input-file-entries.html: Removed.
- http/tests/filesystem: Removed.
- http/tests/filesystem/no-cache-filesystem-url-expected.txt: Removed.
- http/tests/filesystem/no-cache-filesystem-url.html: Removed.
- http/tests/filesystem/resolve-uri-expected.txt: Removed.
- http/tests/filesystem/resolve-uri.html: Removed.
- http/tests/filesystem/resources: Removed.
- http/tests/filesystem/resources/fs-test-util.js: Removed.
- http/tests/filesystem/resources/fs-worker-common.js: Removed.
- http/tests/filesystem/resources/fs-worker-test-util.js: Removed.
- http/tests/filesystem/script-tests: Removed.
- http/tests/filesystem/script-tests/TEMPLATE.html: Removed.
- http/tests/filesystem/script-tests/resolve-uri.js: Removed.
- http/tests/filesystem/workers: Removed.
- http/tests/filesystem/workers/resolve-url-expected.txt: Removed.
- http/tests/filesystem/workers/resolve-url-sync-expected.txt: Removed.
- http/tests/filesystem/workers/resolve-url-sync.html: Removed.
- http/tests/filesystem/workers/resolve-url.html: Removed.
- http/tests/filesystem/workers/script-tests: Removed.
- http/tests/filesystem/workers/script-tests/TEMPLATE.html: Removed.
- http/tests/filesystem/workers/script-tests/resolve-url-sync.js: Removed.
- http/tests/inspector/filesystem: Removed.
- http/tests/inspector/filesystem/delete-entry-expected.txt: Removed.
- http/tests/inspector/filesystem/delete-entry.html: Removed.
- http/tests/inspector/filesystem/directory-tree-expected.txt: Removed.
- http/tests/inspector/filesystem/directory-tree.html: Removed.
- http/tests/inspector/filesystem/filesystem-test.js: Removed.
- http/tests/inspector/filesystem/request-directory-content-expected.txt: Removed.
- http/tests/inspector/filesystem/request-directory-content.html: Removed.
- http/tests/inspector/filesystem/request-file-content-expected.txt: Removed.
- http/tests/inspector/filesystem/request-file-content.html: Removed.
- http/tests/inspector/filesystem/request-filesystem-root-expected.txt: Removed.
- http/tests/inspector/filesystem/request-filesystem-root.html: Removed.
- http/tests/inspector/filesystem/request-metadata-expected.txt: Removed.
- http/tests/inspector/filesystem/request-metadata.html: Removed.
- http/tests/security/contentSecurityPolicy/filesystem-urls-match-self-expected.txt: Removed.
- http/tests/security/contentSecurityPolicy/filesystem-urls-match-self.html: Removed.
- http/tests/security/filesystem-iframe-from-remote-expected.txt: Removed.
- http/tests/security/filesystem-iframe-from-remote.html: Removed.
- http/tests/security/mixedContent/filesystem-url-in-iframe-expected.txt: Removed.
- http/tests/security/mixedContent/filesystem-url-in-iframe.html: Removed.
- http/tests/websocket/tests/hybi/send-file-blob-expected.txt: Removed.
- http/tests/websocket/tests/hybi/send-file-blob-fail-expected.txt: Removed.
- http/tests/websocket/tests/hybi/send-file-blob-fail.html: Removed.
- http/tests/websocket/tests/hybi/send-file-blob.html: Removed.
- http/tests/workers/resources/sync-operations.js:
(onmessage):
- http/tests/workers/terminate-during-sync-operation-expected.txt: Removed.
- http/tests/workers/terminate-during-sync-operation.html: Removed.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 6:47 PM Changeset in webkit [156691] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Build fix afer r156688.
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore::ThreadableBlobRegistry::registerBlobURL): Switch to std::unique_ptr in
method implementation.
- 6:37 PM Changeset in webkit [156690] by
-
- 2 edits in trunk/Source/WebKit2
Fix build.
- NetworkProcess/mac/RemoteNetworkingContext.mm:
- 6:24 PM Changeset in webkit [156689] by
-
- 3 edits in trunk/Tools
More build fixage for builds with SDKs.
- WebKitTestRunner/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/BaseTarget.xcconfig:
- 5:59 PM Changeset in webkit [156688] by
-
- 93 edits in trunk/Source
Get rid of more uses of OwnPtr and PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=122136
Reviewed by Antti Koivisto.
Source/WebCore:
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::didReceiveBinaryData):
- WebCore.exp.in:
- fileapi/Blob.cpp:
(WebCore::Blob::Blob):
(WebCore::Blob::slice):
- fileapi/Blob.h:
(WebCore::Blob::create):
- fileapi/File.cpp:
(WebCore::createBlobDataForFileWithType):
(WebCore::createBlobDataForFile):
(WebCore::createBlobDataForFileWithName):
- fileapi/ThreadableBlobRegistry.cpp:
(WebCore::BlobRegistryContext::BlobRegistryContext):
(WebCore::registerBlobURLTask):
(WebCore::ThreadableBlobRegistry::registerBlobURL):
- fileapi/ThreadableBlobRegistry.h:
- fileapi/WebKitBlobBuilder.cpp:
(WebCore::BlobBuilder::getBlob):
- platform/network/BlobData.cpp:
(WebCore::BlobDataHandle::BlobDataHandle):
- platform/network/BlobData.h:
(WebCore::BlobData::BlobData):
(WebCore::BlobDataHandle::create):
- platform/network/BlobRegistry.h:
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::registerBlobURL):
- platform/network/BlobRegistryImpl.h:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseBlob):
Source/WebKit2:
- NetworkProcess/AsynchronousNetworkLoaderClient.h:
- NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::registerBlobURL):
- NetworkProcess/FileAPI/NetworkBlobRegistry.h:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::NetworkResourceLoader):
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/SynchronousNetworkLoaderClient.h:
- NetworkProcess/mac/RemoteNetworkingContext.mm:
- Platform/CoreIPC/ArgumentDecoder.h:
- Platform/CoreIPC/ArgumentEncoder.h:
- Platform/CoreIPC/MessageDecoder.cpp:
(CoreIPC::MessageDecoder::setImportanceAssertion):
- Platform/CoreIPC/MessageDecoder.h:
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::receiveSourceEventHandler):
- Platform/CoreIPC/mac/ImportanceAssertion.h:
(CoreIPC::ImportanceAssertion::ImportanceAssertion):
- Platform/mac/LayerHostingContext.h:
- Platform/mac/LayerHostingContext.mm:
(WebKit::LayerHostingContext::createForPort):
(WebKit::LayerHostingContext::createForWindowServer):
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::addPluginControllerProxy):
(WebKit::WebProcessConnection::removePluginControllerProxy):
(WebKit::WebProcessConnection::createPluginInternal):
- PluginProcess/WebProcessConnection.h:
- Shared/API/c/cg/WKImageCG.cpp:
(WKImageCreateFromCGImage):
- Shared/BlockingResponseMap.h:
(BlockingResponseMap::waitForResponse):
(BlockingResponseMap::didReceiveResponse):
- Shared/Downloads/Download.cpp:
- Shared/Downloads/Download.h:
- Shared/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload):
(WebKit::DownloadManager::convertHandleToDownload):
- Shared/FileAPI/BlobRegistrationData.cpp:
(WebKit::BlobRegistrationData::BlobRegistrationData):
(WebKit::BlobRegistrationData::releaseData):
(WebKit::BlobRegistrationData::decode):
- Shared/FileAPI/BlobRegistrationData.h:
- Shared/Plugins/NPObjectMessageReceiver.cpp:
- Shared/Plugins/NPObjectMessageReceiver.h:
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::registerNPObject):
- Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryLoad):
- Shared/Plugins/Netscape/NetscapePluginModule.h:
- Shared/ShareableBitmap.h:
- Shared/WebURL.h:
(WebKit::WebURL::create):
(WebKit::WebURL::WebURL):
(WebKit::WebURL::parseURLIfNecessary):
- Shared/cg/ShareableBitmapCG.cpp:
(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::makeCGImageCopy):
- Shared/mac/SecItemShim.cpp:
(WebKit::sendSecItemRequest):
(WebKit::webSecItemCopyMatching):
(WebKit::webSecItemAdd):
(WebKit::webSecItemUpdate):
(WebKit::webSecItemDelete):
(WebKit::SecItemShim::secItemResponse):
- UIProcess/API/mac/FindIndicatorWindow.h:
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::createDrawingAreaProxy):
- UIProcess/API/mac/WKView.mm:
(-[WKView std::WebKit::]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/BackingStore.cpp:
- UIProcess/BackingStore.h:
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::incorporateUpdate):
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
- WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::registerBlobURL):
- WebProcess/FileAPI/BlobRegistryProxy.h:
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
- WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm:
(WKBundlePageBannerCreateBannerWithCALayer):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::imageForRect):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::scheduleTimer):
(WebKit::NetscapePlugin::unscheduleTimer):
(WebKit::NetscapePlugin::snapshot):
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::snapshot):
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::update):
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::convertImageToBitmap):
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::display):
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::getFindIndicatorBitmapAndRect):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createWithCoreMainFrame):
(WebKit::WebFrame::createSubframe):
(WebKit::WebFrame::create):
(WebKit::WebFrame::WebFrame):
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scaledSnapshotWithOptions):
(WebKit::WebPage::drawRectToImage):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/LayerTreeHostMac.h:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
- 5:48 PM Changeset in webkit [156687] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Message sending functions should only accept rvalues
https://bugs.webkit.org/show_bug.cgi?id=122041
Reviewed by Andreas Kling.
In order to safely encode move-only types, make all send variants accept rvalues only, except
for the "send to all processes" ones. For them, copy the message before sending. This ensures that trying
to send a move-only type in a message will fail to compile.
- NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::sendAbortingOnFailure):
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):
- Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::sendSync):
- Shared/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::send):
(WebKit::ChildProcessProxy::sendSync):
- UIProcess/WebContext.h:
(WebKit::WebContext::sendToNetworkingProcess):
(WebKit::WebContext::sendToNetworkingProcessRelaunchingIfNecessary):
(WebKit::WebContext::sendToAllProcesses):
(WebKit::WebContext::sendToAllProcessesRelaunchingThemIfNecessary):
(WebKit::WebContext::sendToOneProcess):
- UIProcess/WebPageGroup.h:
(WebKit::WebPageGroup::sendToAllProcessesInGroup):
- 4:42 PM Changeset in webkit [156686] by
-
- 1 copy in branches/safari-537.73-branch
New Branch.
- 4:13 PM Changeset in webkit [156685] by
-
- 1 edit36 adds in trunk/Tools
Add initial version of a new Buildbot dashboard view.
https://bugs.webkit.org/show_bug.cgi?id=122131
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
- 3:52 PM Changeset in webkit [156684] by
-
- 2 edits in trunk/Source/JavaScriptCore
<rdar://problem/15114974> Assertion failure under -[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:] if no classes conform to JSExport
https://bugs.webkit.org/show_bug.cgi?id=122124
Reviewed by Darin Adler.
- API/JSWrapperMap.mm: Defined an empty class that conforms to the JSExport protocol, to
ensure that the protocol is always registered with the runtime by the time
getJSExportProtocol() is called.
- 3:43 PM Changeset in webkit [156683] by
-
- 46 edits in trunk
Remove the code guarded by STYLE_SCOPED
https://bugs.webkit.org/show_bug.cgi?id=122123
Reviewed by Anders Carlsson.
.:
- Source/autotools/SetupWebKitFeatures.m4:
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Start cleaning the code related to <style scoped>. This patch
only removes the code with #ifdef guards.
- Configurations/FeatureDefines.xcconfig:
- WebCore.exp.in:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
- bindings/generic/RuntimeEnabledFeatures.h:
- css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::appendAuthorStyleSheets):
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::matchScopedAuthorRules):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):
- css/StyleResolver.h:
(WebCore::StyleResolver::ensureScopeResolver):
- css/StyleScopeResolver.cpp:
- css/StyleScopeResolver.h:
- dom/Node.cpp:
- dom/Node.h:
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
- dom/ShadowRoot.h:
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::HTMLStyleElement):
(WebCore::HTMLStyleElement::parseAttribute):
(WebCore::HTMLStyleElement::insertedInto):
(WebCore::HTMLStyleElement::removedFrom):
- html/HTMLStyleElement.h:
- html/HTMLStyleElement.idl:
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
- testing/InternalSettings.h:
- testing/InternalSettings.idl:
- testing/Internals.cpp:
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
- 2:56 PM Changeset in webkit [156682] by
-
- 2 edits in trunk/Source/WebCore
ASSERT(!m_hasBadParent) in InlineBox::parent() should be ASSERT_WITH_SECURITY_IMPLICATION
https://bugs.webkit.org/show_bug.cgi?id=122032
Patch by Drew Yao <ayao@apple.com> on 2013-09-30
Reviewed by Andreas Kling.
Convert assertion to ASSERT_WITH_SECURITY_IMPLICATION to help catch use after free bugs.
No new tests needed.
- rendering/InlineBox.h:
(WebCore::InlineBox::parent):
- 2:54 PM Changeset in webkit [156681] by
-
- 2 edits in trunk/Source/WebCore
Don't attempt to destroy decoded frame if a BitmapImage doesn't have encoded raw data.
https://bugs.webkit.org/show_bug.cgi?id=122115
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-09-30
Reviewed by Daniel Bates.
With BitmapImage::create(PassNativeImagePtr, ImageObserver*), a BitmapImage could be created by
passing a native image. If this image is added to memory cache, we shouldn't attempt to destroy
its decoded frames since there is no encoded raw data and we won't be able to reconstruct the image again.
No new tests for now. Currently there isn't a code path to add to the memory cache a BitmapImage
that was created by adopting a native image. We'll add such a code path in a subsequent patch.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyDecodedDataIfNecessary):
- 2:42 PM Changeset in webkit [156680] by
-
- 4 edits in trunk/Source/JavaScriptCore
Pass VM instead of ExecState to ObjectPrototype constructor.
<https://webkit.org/b/122116>
Reviewed by Geoffrey Garen.
The ObjectPrototype constructor was only using the ExecState to get
to the VM.
- 2:41 PM Changeset in webkit [156679] by
-
- 6 edits in trunk/Source/JavaScriptCore
Pass VM instead of JSGlobalObject to MathObject constructor.
<https://webkit.org/b/122119>
Reviewed by Geoffrey Garen.
The MathObject constructor was only using the global object to get
to the VM. finishCreation() still uses it to set up functions.
- 1:47 PM Changeset in webkit [156678] by
-
- 2 edits in trunk/LayoutTests
Remove timeout from shouldBecome* functions in js-test-pre
https://bugs.webkit.org/show_bug.cgi?id=122121
Reviewed by Ryosuke Niwa.
Removed timeout. A 0.5 sec timeout never makes sense, and if something is stuck,
a test should just time out normally.
- resources/js-test-pre.js:
(_waitForCondition):
(shouldBecomeEqual):
(shouldBecomeEqualToString):
(shouldBecomeDifferent):
- 1:38 PM Changeset in webkit [156677] by
-
- 21 edits1 add in trunk/Source/JavaScriptCore
Get rid of the AlreadyInJSStack recoveries since they are totally redundant with the DisplacedInJSStack recoveries
https://bugs.webkit.org/show_bug.cgi?id=122065
Reviewed by Mark Hahnenberg.
This mostly just kills a bunch of code.
But incidentaly while killing that code, I uncovered a bug in our FTL OSR entrypoint
creation phase. The phase inserts a sequence of SetLocal(ExtractOSREntryLocal) nodes.
If we hoist some type check into the local, then we might inject a conversion node
between the ExtractOSREntryLocal and the SetLocal - for example we might put in a
Int32ToDouble node. But currently the FixupPhase will make all conversion nodes placed
on an edge of a SetLocal use forward exit. This then confuses the OSR exit machinery.
When OSR exit sees a forward exit, it tries to "roll forward" execution from the exiting
node to the first node that has a different CodeOrigin. This only works if the nodes
after the forward exit are MovHints or other tnings that the OSR exit compiler can
forward-execute. But here, it will see a bunch of SetLocal and ExtractOSREntryLocal
nodes for the same bytecode index. Two possible solutions exist. We could teach the
forward-execution logic how to deal with multiple SetLocals and ExtractOSREntryLocals.
This would be a lot of complexity; right now it just needs to deal with exactly one
SetLocal-like operation. The alternative is to make sure that the conversion node that
we inject ends up exiting *backward* rather than forward.
But making the conversion nodes exit backward is somewhat tricky. Before this patch,
conversion nodes always exit forward for SetLocals and backwards otherwise. It turns out
that the solution is to rationalize how we choose the speculation direciton for a
conversion node. The conversion node's speculation direction should be the same as the
speculation direction of the node for which it is doing a conversion. Since SetLocal's
already exit forward by default, this policy preserves our previous behavior. But it
also allows the OSR entrypoint creation phase to make its SetLocals exit backward
instead.
Of course, if the SetLocal(ExtractOSREntryLocal) sequences exit backward, then we need
to make sure that the OSR exit machine knows that the local variables are indeed live.
Consider that if we have:
a: ExtractOSREntryLocal(loc1)
b: SetLocal(@a, loc1)
c: ExtractOSRentryLocal(loc2)
d: SetLocal(@c, loc2)
Without additional magic, the exit at @b will think that loc2 is dead and the OSR exit
compiler will clobber loc2 with Undefined. So we need to make sure that we actually
emit code like:
a: ExtractOSREntryLocal(loc1)
b: ExtractOSREntryLocal(loc2)
c: SetLocal(@a, loc1)
d: SetLocal(@b, loc2)
e: SetLocal(@a, loc1)
f: SetLocal(@b, loc2)
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CodeOrigin.h:
- bytecode/ValueRecovery.cpp: Added.
(JSC::ValueRecovery::recover):
(JSC::ValueRecovery::dumpInContext):
(JSC::ValueRecovery::dump):
- bytecode/ValueRecovery.h:
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
(JSC::DFG::FixupPhase::fixEdge):
- dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::reconstruct):
- dfg/DFGNode.h:
(JSC::DFG::Node::speculationDirection):
(JSC::DFG::Node::setSpeculationDirection):
- dfg/DFGOSREntrypointCreationPhase.cpp:
(JSC::DFG::OSREntrypointCreationPhase::run):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileInlineStart):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
- dfg/DFGValueSource.h:
(JSC::DFG::ValueSource::valueRecovery):
- dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateMachineInt):
- interpreter/Register.h:
(JSC::Register::unboxedStrictInt52):
- runtime/Arguments.cpp:
(JSC::Arguments::tearOff):
- runtime/Arguments.h:
- 1:32 PM Changeset in webkit [156676] by
-
- 19 edits1 delete in trunk/Source/WebCore
Remove IDBTracing.h.
https://bugs.webkit.org/show_bug.cgi?id=122118
Reviewed by Alexey Proskuryakov.
Global replace of "IDB_TRACE" with "LOG(StorageAPI)", and remove all notions of this header.
- GNUmakefile.list.am:
- Modules/indexeddb/IDBCursor.cpp:
- Modules/indexeddb/IDBDatabase.cpp:
- Modules/indexeddb/IDBDatabaseBackendInterface.h:
- Modules/indexeddb/IDBFactory.cpp:
- Modules/indexeddb/IDBIndex.cpp:
- Modules/indexeddb/IDBObjectStore.cpp:
- Modules/indexeddb/IDBOpenDBRequest.cpp:
- Modules/indexeddb/IDBRequest.cpp:
- Modules/indexeddb/IDBTracing.h: Removed.
- Modules/indexeddb/IDBTransaction.cpp:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/IDBBindingUtilities.cpp:
- 1:10 PM Changeset in webkit [156675] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: rows in the Layer sidebar panel may have the incorrect background color
https://bugs.webkit.org/show_bug.cgi?id=122108
Reviewed by Darin Adler.
The LayerTreeDataGrid is a custom DataGrid subclass which exposes a .setChildren() method
used to sort chidren without DOM order manipulation, for performance reason. However, since
the way the alternating background color is usually implemented is based on the built-in
CSS pseudo-classes working with DOM order, the background colors of nodes in the LayerTreeDataGrid
can be incorrect depending on the sort order and the number of nodes. To fix this, we now manually
set "even" and "odd" CSS classes on those nodes when they're sorted such that we have a chance
to style them as intended.
- UserInterface/LayerTreeDataGrid.js:
(WebInspector.LayerTreeDataGrid.prototype._updateChildren):
Check if the data grid node index is even or odd and reflect this via an exclusive "even"
or "odd" CSS class name.
- UserInterface/LayerTreeSidebarPanel.css:
(.layer-tree.panel .data-container tbody > tr.even):
(.layer-tree.panel .data-container tbody > tr.odd):
Apply alternating colors based on the exclusive "even" and "odd" CSS class names as applied in
WebInspector.LayerTreeDataGrid.prototype._updateChildren().
- 1:07 PM Changeset in webkit [156674] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed build fix for Win64.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Added correct 64-bit BitmapImage::create symbol.
- 1:07 PM Changeset in webkit [156673] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Popover displaying "reasons for compositing" may remain on screen after selected layer is removed
https://bugs.webkit.org/show_bug.cgi?id=117575
Ensure the popover attached to the selected data grid node is updated when the
content or sort order of the Layer sidebar panel is updated.
Reviewed by Darin Adler.
- UserInterface/LayerTreeSidebarPanel.js:
(WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid):
- 1:06 PM Changeset in webkit [156672] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: nodes can be dragged from the console log
https://bugs.webkit.org/show_bug.cgi?id=122105
Reviewed by Darin Adler.
Catch "dragstart" events targeting nodes hosted in a DOMTreeOutline within the console
log view and prevent the default logic to trigger so that these nodes can't be dragged
off the console as it wouldn't make sense to.
- UserInterface/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline):
Create a class property to allow the CSS class name to be used in WebInspector.LogContentView.
- UserInterface/LogContentView.js:
(WebInspector.LogContentView):
(WebInspector.LogContentView.prototype._ondragstart):
Track the "dragstart" events in their capture phase such that, if the event target is
a DOM node hosted in a DOMTreeOutline, we can prevent the event from propagating and
cancel its default behavior such that no dragging at all is performed.
- 12:51 PM Changeset in webkit [156671] by
-
- 2 edits in trunk/Source/JavaScriptCore
Win64 compile fix after r1256490.
https://bugs.webkit.org/show_bug.cgi?id=122117
Patch by Alex Christensen <alex.christensen@flexsim.com> on 2013-09-30
Reviewed by Michael Saboff.
- jit/JITStubsMSVC64.asm:
Implemented getHostCallReturnValue for Windows x86_64 processors.
- 12:44 PM Changeset in webkit [156670] by
-
- 2 edits in trunk/Source/WebKit2
NetworkResourceLoader.messages.in should be ENABLE(NETWORK_PROCESS) guarded
https://bugs.webkit.org/show_bug.cgi?id=122110
Reviewed by Darin Adler.
- NetworkProcess/NetworkResourceLoader.messages.in:
- 12:35 PM Changeset in webkit [156669] by
-
- 4 edits in trunk/Source/WebCore
[Windows] Build fix after r156622. Build RenderLayerModelObject.cpp in a separate compilation unit
from the RenderLayerAllnOne file so that the scalar and vector destructors are visible to other
elements of WebCore during the build.
- WebCore.vcxproj/WebCore.vcxproj: Compile RenderLayerModelObject outside of the all-in-one file.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- rendering/RenderingAllInOne.cpp: Remove RenderLayerModelObject.cpp.
- 11:58 AM Changeset in webkit [156668] by
-
- 11 edits in trunk/Source
Pass VM instead of JSGlobalObject to RegExp constructor.
<https://webkit.org/b/122113>
Reviewed by Darin Adler.
RegExps don't need anything from the global object during their
construction and only use it to get to the VM. Reduce loads by
simply passing the VM around instead.
JSC release binary size -= 120 bytes(!)
- 11:13 AM Changeset in webkit [156667] by
-
- 2 edits in trunk/Source/WebKit
[Win] Compile errors in WebKit (via peavo@outlook.com).
https://bugs.webkit.org/show_bug.cgi?id=122106
Reviewed by Darin Adler.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add link
declarations missed in r156655.
- 11:09 AM Changeset in webkit [156666] by
-
- 9 edits in trunk
Fix the build when building against an SDK.
Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
the compiler command lines. It can't know to do this for the system framework search paths
we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.
Source/WebCore:
- Configurations/WebCore.xcconfig:
Source/WebKit/mac:
- Configurations/WebKit.xcconfig:
Source/WebKit2:
- Configurations/BaseTarget.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
- WebKitTestRunner/Configurations/BaseTarget.xcconfig:
- 10:58 AM Changeset in webkit [156665] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Unreviewed build fix.
- WebCore.vcxproj/WebCore.vcxproj.filters: Correct malformed XML in project files.
- 10:56 AM Changeset in webkit [156664] by
-
- 11 edits in trunk
Unreviewed, roll back in r156546 with rebaselined tests.
https://bugs.webkit.org/show_bug.cgi?id=122111
Source/WebCore:
- Modules/mediacontrols/mediaControlsApple.js:
(Controller):
(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):
(Controller.prototype.updateHasAudio):
LayoutTests:
- platform/mac/TestExpectations:
- platform/mac/fast/hidpi/video-controls-in-hidpi-expected.png:
- platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
- platform/mac/fast/layers/video-layer-expected.png:
- platform/mac/fast/layers/video-layer-expected.txt:
- platform/mac/media/media-controls-clone-expected.png:
- platform/mac/media/media-controls-clone-expected.txt:
- platform/mac/media/video-no-audio-expected.txt:
- 10:38 AM Changeset in webkit [156663] by
-
- 3 edits3 deletes in trunk/LayoutTests
editing/execCommand/findString-diacriticals.html expects to fail
https://bugs.webkit.org/show_bug.cgi?id=122100
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-09-30
Reviewed by Alexey Proskuryakov.
Since all major platforms pass editing/execCommand/findString-diacriticals.html,
the test now globally expects "PASS" instead of "FAIL" rendering the individual
platform expectation files obsolete.
- editing/execCommand/findString-diacriticals-expected.txt: "PASS" -> "FAIL"
- platform/efl/TestExpectations: EFL passes editing/execCommand/findString-diacriticals.
- platform/gtk/editing/execCommand/findString-diacriticals-expected.txt: Removed.
- platform/mac/editing/execCommand/findString-diacriticals-expected.txt: Removed.
- platform/qt/editing/execCommand/findString-diacriticals-expected.txt: Removed.
- 10:36 AM Changeset in webkit [156662] by
-
- 2 edits in trunk/Tools
[Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.
A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
it to be double-freed.
- WinLauncher/WinLauncher.cpp:
(EditProc): Be explicit about type passed to loadURL.
(loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
that reallocating the BSTR is done with the knowledge of the smart pointer.
- 9:59 AM Changeset in webkit [156661] by
-
- 5 edits in trunk
Unreviewed, rolling out r156656.
http://trac.webkit.org/changeset/156656
https://bugs.webkit.org/show_bug.cgi?id=122111
Broke several media tests (Requested by ap on #webkit).
Source/WebCore:
- Modules/mediacontrols/mediaControlsApple.js:
(Controller):
(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):
LayoutTests:
- platform/mac/TestExpectations:
- platform/mac/media/video-no-audio-expected.txt:
- 9:50 AM Changeset in webkit [156660] by
-
- 7 edits in trunk/Source/WebCore
Convert a bunch of OwnPtrs on Page to std::unique_ptrs
https://bugs.webkit.org/show_bug.cgi?id=122086
Reviewed by Darin Adler.
- loader/ProgressTracker.cpp:
- loader/ProgressTracker.h:
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::setGroupName):
(WebCore::Page::initGroup):
- page/Page.h:
- page/PageGroup.cpp:
(WebCore::PageGroup::PageGroup):
- page/PageGroup.h:
- 9:32 AM Changeset in webkit [156659] by
-
- 3 edits in trunk/LayoutTests
[EFL] Changed expectation for accessibility/file-upload-button-stringvalue.html after r156532
https://bugs.webkit.org/show_bug.cgi?id=122103
Unreviewed EFL gardening.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-30
- platform/efl-wk1/TestExpectations: file-upload-button-stringvalue.html fails on efl-wk1.
Unskipped accessibility/heading-level.html. It passes after r156551.
- platform/efl-wk2/accessibility/file-upload-button-stringvalue-expected.txt:
- 9:30 AM Changeset in webkit [156658] by
-
- 7 edits2 deletes in trunk
[Qt] Fix force_static_libs_as_shared in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121961
Reviewed by Csaba Osztrogonác.
Get rid of the unused WebKit2QML library
.:
- Source/api.pri:
Source/WebKit2:
- Target.pri:
- WebKit2.pro:
- WebKit2QML.pri: Removed.
Tools:
- qmake/mkspecs/features/webkit_modules.prf:
- qmake/mkspecs/modules/webkit2qml.prf: Removed.
- 9:21 AM Changeset in webkit [156657] by
-
- 14 edits1 delete in trunk/Source/WebCore
Remove FontTranscoder
https://bugs.webkit.org/show_bug.cgi?id=122088
Reviewed by Andreas Kling.
This overly generic class just implements mapping of backslash to yen symbol for some legacy Japanese fonts.
- CMakeLists.txt:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/Font.cpp:
(WebCore::useBackslashAsYenSignForFamily):
Move the family set to Font.cpp.
(WebCore::Font::Font):
(WebCore::Font::operator=):
(WebCore::Font::update):
Keep the cached boolean up to date.
- platform/graphics/Font.h:
(WebCore::Font::useBackslashAsYenSymbol):
Use descriptive name instead of talking about "transcoding".
- platform/text/transcoder: Removed.
- platform/text/transcoder/FontTranscoder.cpp: Removed.
- platform/text/transcoder/FontTranscoder.h: Removed.
- rendering/RenderText.cpp:
(WebCore::RenderText::RenderText):
(WebCore::RenderText::computeUseBackslashAsYenSymbol):
Rename for clarity.
Avoid unnecessary hash lookup, just check the cached bit in Font.
(WebCore::RenderText::styleDidChange):
(WebCore::RenderText::setTextInternal):
"Transcoding" here was just a simple character replacement.
(WebCore::RenderText::textWithoutConvertingBackslashToYenSymbol):
Renamed.
- rendering/RenderText.h:
- 9:09 AM Changeset in webkit [156656] by
-
- 5 edits in trunk
REGRESSION(r156546): media/video-no-audio.html broken
https://bugs.webkit.org/show_bug.cgi?id=122049
Reviewed by Eric Carlson.
Source/WebCore:
Now that our video elements have audio tracks, use their presence or
absense to show or hide the volume controls.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller):
(Controller.prototype.addVideoListeners): Listen for audioTrack changes.
(Controller.prototype.removeVideoListeners): Stop listening to same.
(Controller.prototype.handleAudioTrackChange): Call this.updateHasAudio()
(Controller.prototype.handleAudioTrackAdd): Ditto.
(Controller.prototype.handleAudioTrackRemove): Ditto.
(Controller.prototype.updateHasAudio): Hide the volume controls if no
audioTracks are present, and vice versa.
LayoutTests:
- platform/mac/TestExpectations:
- platform/mac/media/video-no-audio-expected.txt:
- 8:43 AM Changeset in webkit [156655] by
-
- 2 edits in trunk/Source/WebKit/win
Try to fix the Windows build.
- WebFrame.cpp:
(WebFrame::pauseAnimation):
(WebFrame::pauseTransition):
- 8:42 AM Changeset in webkit [156654] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix compilation for COMPILER(MSVC) && !CPU(X86) after r156490.
https://bugs.webkit.org/show_bug.cgi?id=122102
Reviewed by Geoffrey Garen.
_AddressOfReturnAddress() is supported for all platforms of
ths Microsoft compiler, so we can use it for !CPU(X86) too.
- jit/JITOperationWrappers.h:
- 8:39 AM Changeset in webkit [156653] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed Mac-Lion build fix.
Use metadataItemsFromArray:withLocale: instead of
metadataItemsFromArray:filteredAndSortedAccordingToPreferredLanguages:
on Lion and earlier.
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm:
(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack):
- 8:17 AM Changeset in webkit [156652] by
-
- 6 edits5 adds in trunk
[Mac] Add AudioTrack support to MediaPlayerPrivateAVFObC.
https://bugs.webkit.org/show_bug.cgi?id=122043
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/audio-track.html
Add a new class AudioTrackPrivateAVF and subclass AudioTrackPrivateAVFObjC
which are backed by a AVPlayerItemTrack. Create one of these tracks when
we are notified that the list of available tracks has changed.
- WebCore.xcodeproj/project.pbxproj:
- html/track/AudioTrack.cpp:
(WebCore::AudioTrack::setEnabled): Pass through to the AudioTrackPrivate
so that the underlying media track can be (dis|en)abled.
- platform/graphics/avfoundation/AudioTrackPrivateAVF.h: Added.
(WebCore::AudioTrackPrivateAVF::kind): Simple getter.
(WebCore::AudioTrackPrivateAVF::id): Ditto.
(WebCore::AudioTrackPrivateAVF::label): Ditto.
(WebCore::AudioTrackPrivateAVF::language): Ditto.
(WebCore::AudioTrackPrivateAVF::setKind): Simple Setter.
(WebCore::AudioTrackPrivateAVF::setId): Ditto.
(WebCore::AudioTrackPrivateAVF::setLabel): Ditto.
(WebCore::AudioTrackPrivateAVF::setLanguage): Ditto.
(WebCore::AudioTrackPrivateAVF::AudioTrackPrivateAVF): Simple constructor.
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.h: Added.
(WebCore::AudioTrackPrivateAVFObjC::create): Simple factory.
(WebCore::AudioTrackPrivateAVFObjC::playerItemTrack): Simple getter.
- platform/graphics/avfoundation/objc/AudioTrackPrivateAVFObjC.mm: Added.
(WebCore::AudioTrackPrivateAVFObjC::AudioTrackPrivateAVFObjC): Call resetPropertiesFromTrack.
(WebCore::AudioTrackPrivateAVFObjC::resetPropertiesFromTrack): Fill out the values from
the associated AVPlayerItemTrack and its AVAssetTrack.
(WebCore::AudioTrackPrivateAVFObjC::setPlayerItemTrack): Call resetPropertiesFromTrack.
(WebCore::AudioTrackPrivateAVFObjC::setEnabled): (En|Dis)able the AVPlayerItemTrack.
(WebCore::AudioTrackPrivateAVFObjC::languageForAVAssetTrack): Refactored from
MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Determine which tracks
have been added or removed and notify the clients accordingly.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Refactor into
AudioTrackPrivateAVFObjC::languageForAVAssetTrack.
LayoutTests:
- media/track/audio-track-expected.txt: Added.
- media/track/audio-track.html: Added.
- 7:57 AM Changeset in webkit [156651] by
-
- 2 edits1 add in trunk/LayoutTests
[EFL] Added passing expectation for fast/forms/textarea-metrics.html
https://bugs.webkit.org/show_bug.cgi?id=122107
Unreviewed EFL gardening.
fast/forms/textarea-metrics.html fails in WebKitTestRunner but returns expected
results in MiniBrowser. Since GTK uses platform dependent expectation file to
migitate this identical discrepancy, the same solution has been applied to EFL.
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-09-30
- platform/efl/TestExpectations:
- platform/efl/fast/forms/textarea-metrics-expected.txt: Added.
- 7:05 AM Changeset in webkit [156650] by
-
- 2 edits in trunk/Source/WebKit/wince
Unreviewed WinCE build fix after r153927.
- WebView.cpp:
(WebView::WebView):
- 6:58 AM Changeset in webkit [156649] by
-
- 2 edits in trunk/Source/WebKit/wince
Unreviewed WinCE build fix after r155289.
- WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForResponse):
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNewWindowAction):
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNavigationAction):
(WebKit::FrameLoaderClientWinCE::dispatchWillSubmitForm):
- 6:57 AM Changeset in webkit [156648] by
-
- 2 edits in trunk/Source/WebKit/wince
Unreviewed WinCE build fix after r154178.
- WebView.cpp:
(WebView::wndProc):
- 6:15 AM Changeset in webkit [156647] by
-
- 4 edits in trunk
[EFL] Fix incorrect click counting in EventSenderProxy
https://bugs.webkit.org/show_bug.cgi?id=122098
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-09-30
Reviewed by Gyuyoung Kim.
Tools:
Previously used two types of recording time, which conflicted with each other.
- WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR::EventSenderProxy::mouseUp):
LayoutTests:
After fixing EventSenderProxy extend-selection-after-double-click.html runs correctly.
- platform/efl/TestExpectations:
- 4:49 AM Changeset in webkit [156646] by
-
- 3 edits in trunk/LayoutTests
[EFL] Gardening after the resolution of bug 84835
https://bugs.webkit.org/show_bug.cgi?id=122096
Unreviewed EFL gardening.
Removed expected failures for bug 84835.
editing/pasteboard/copy-inside-h1-preserves-h1 and
editing/pasteboard/copy-without-selection are still failing due to bug 86623
and have been marked accordingly.
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-09-30
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- 3:56 AM Changeset in webkit [156645] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening. Two tests are passing in WK2 after r156541.
- platform/gtk-wk2/TestExpectations: Removed passing tests.
- 3:46 AM Changeset in webkit [156644] by
-
- 2 edits in trunk/LayoutTests
[EFL] Accessibility tests pass after r156532 and r156551
https://bugs.webkit.org/show_bug.cgi?id=122090
Unreviewed EFL gardening.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-30
- platform/efl-wk2/TestExpectations:
- 3:44 AM Changeset in webkit [156643] by
-
- 2 edits in trunk/LayoutTests
[EFL] New test accessibility/table-with-hidden-head-section.html failing on EFL port
https://bugs.webkit.org/show_bug.cgi?id=111850
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-30
Reviewed by Mario Sanchez Prada.
Test passes after r156532.
- platform/efl/TestExpectations:
- 3:39 AM Changeset in webkit [156642] by
-
- 5 edits in trunk/Source/WebCore
Generate toCSSCalcValue instead of using manual cast function
https://bugs.webkit.org/show_bug.cgi?id=122055
Reviewed by Antti Koivisto.
Generated type cast function supports more plenty functions rather than manual functions.
To use CSS_VALUE_TYPE_CAST, isCalculationValue() needs to be changed with isCalcValue().
No new tests, no behavior changes.
- css/CSSCalculationValue.h:
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isCalcValue):
- css/StyleResolver.cpp:
(WebCore::hasVariableReference):
- 2:33 AM Changeset in webkit [156641] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Build fix for DEBUG_VERBOSE mode after r156511.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
- 1:26 AM Changeset in webkit [156640] by
-
- 3 edits in trunk/Tools
[webkitpy] Make the Xvfb screen depth overridable
https://bugs.webkit.org/show_bug.cgi?id=122089
Reviewed by Gyuyoung Kim.
Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
was set. The default value that's used if the variable wasn't set is 24.
- Scripts/webkitpy/port/xvfbdriver.py:
(XvfbDriver._xvfb_screen_depth):
(XvfbDriver._start):
- Scripts/webkitpy/port/xvfbdriver_unittest.py:
(XvfbDriverTest.make_driver):
(XvfbDriverTest.test_start_no_pixel_tests):
(XvfbDriverTest.test_start_pixel_tests):
(XvfbDriverTest.test_start_arbitrary_worker_number):
(XvfbDriverTest.test_next_free_display):
(XvfbDriverTest.test_start_next_worker):
- 1:21 AM Changeset in webkit [156639] by
-
- 9 edits in trunk/Source/WebCore
Get rid of static map for marking ancestor line boxes dirty
https://bugs.webkit.org/show_bug.cgi?id=122080
Reviewed by Andreas Kling.
This is ugly and shows up in profiles too. Use a bit in RenderElement instead.
- rendering/RenderBlock.h:
- rendering/RenderBlockFlow.h:
Move dirtyLinesFromChangedChild down to RenderBlockFlow. It wouldn't do anything on other RenderBlocks.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::RenderElement):
- rendering/RenderElement.h:
Add m_ancestorLineBoxDirty bit. We have 32 unused bits here on 64bit systems.
(WebCore::RenderElement::dirtyLinesFromChangedChild):
(WebCore::RenderElement::ancestorLineBoxDirty):
(WebCore::RenderElement::setAncestorLineBoxDirty):
(WebCore::RenderObject::setNeedsLayout):
- rendering/RenderInline.h:
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
Tighten the interface.
- rendering/RenderLineBoxList.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeDestroyed):
- rendering/RenderObject.h:
Remove the static map.
- 1:14 AM Changeset in webkit [156638] by
-
- 9 edits2 adds in trunk
[CSS Grid Layout] Implement the grid-area shorthand
https://bugs.webkit.org/show_bug.cgi?id=103334
Reviewed by Andreas Kling.
Source/WebCore:
Based on Blink r151684 by <jchaffraix@chromium.org>
Test: fast/css-grid-layout/grid-item-area-get-set.html
Added support to specify grid positions using the
'-webkit-grid-area' shorthand. Named grid areas are still not
allowed, to be done in a follow up patch as it likely requires
'-webkit-grid-template' support.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridItemPositionShorthand):
- css/CSSPropertyNames.in:
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
- css/StylePropertyShorthand.cpp:
(WebCore::webkitGridAreaShorthand):
(WebCore::shorthandForProperty):
- css/StylePropertyShorthand.h:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
LayoutTests:
From Blink r151684 by <jchaffraix@chromium.org>
- fast/css-grid-layout/grid-item-area-get-set-expected.txt: Added.
- fast/css-grid-layout/grid-item-area-get-set.html: Added.
- 1:10 AM Changeset in webkit [156637] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Speculative build fix on ARMv7 Thumb2 after r156490.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::fmodAsDFGOperation):
- 12:35 AM Changeset in webkit [156636] by
-
- 8 edits in trunk/Source/WebCore
Generate toCSSFooValue for CSSGradientValue, CSSLinearGradientValue and CSSRadialGradient
https://bugs.webkit.org/show_bug.cgi?id=122060
Reviewed by Antti Koivisto.
As a step to generate toCSSFooValue, toCSSGradientValuem toCSSLinearGradientValue and
toCSSRadialGradient are generated. isLinearGradient() and isRadialGradient() are moved
from each class to CSSValue in order to generate toCSSFooValue.
No new tests, no behavior change.
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image):
(WebCore::CSSGradientValue::gradientWithStylesResolved):
- css/CSSGradientValue.h:
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseDeprecatedGradient):
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isLinearGradient):
(WebCore::CSSValue::isRadialGradient):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
- 12:12 AM Changeset in webkit [156635] by
-
- 3 edits2 adds in trunk
user-select: none cursor turns to I-beam on mouse dragging
https://bugs.webkit.org/show_bug.cgi?id=90159
Patch by Vani Hegde <vani.hegde@samsung.com> on 2013-09-30
Reviewed by Ryosuke Niwa.
Source/WebCore:
When tried to select some text in an area that has style
cursor:default set, cursor type changes to text cursor ignoring
the cursor style that is explicitly set.
When the cursor style is explicitly set as default (or something else),
we should not change it to text cursor no matter what we are over
or what operation we are performing (be it hovering over the text
or selecting the text).
During text selection, changing the cursor type to text only when
there is no explicit cursor type set fixes the issue.
Test: editing/caret/selection-with-caret-type-progress.html
- page/EventHandler.cpp:
(WebCore::EventHandler::selectCursor):
During selection, set the cursor style to text only if there is no
explicit cursor style set.
LayoutTests:
Test case added to verify that explicitly set cursor style
is retained on performing text selection.
- editing/caret/selection-with-caret-type-progress-expected.txt: Added.
- editing/caret/selection-with-caret-type-progress.html: Added.
Sep 29, 2013:
- 11:32 PM Changeset in webkit [156634] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL: refactor compileAdd and compileArithSub into one function.
https://bugs.webkit.org/show_bug.cgi?id=122081
Patch by Nadav Rotem <nrotem@apple.com> on 2013-09-29
Reviewed by Geoffrey Garen.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileAddSub):
- 10:40 PM Changeset in webkit [156633] by
-
- 5 edits in trunk/Source/WebCore
Generate toCSSFooValue() for CSSCanvasValue
https://bugs.webkit.org/show_bug.cgi?id=122058
Reviewed by Antti Koivisto.
Generate toCSSFooValue() for CSSCanvasValue, and use it.
This type cast function will help to detect bad-casts.
isCanvasValue() is added in order to generate toCSSCanvasValue.
No new tests, no behavior change.
- css/CSSCanvasValue.h:
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isCanvasValue):
- 10:38 PM Changeset in webkit [156632] by
-
- 5 edits in trunk/Source/ThirdParty
Take some Xcode advice about turning on additional warnings in ANGLE and gtest
https://bugs.webkit.org/show_bug.cgi?id=122087
Reviewed by Mark Rowe.
Source/ThirdParty:
- gtest/xcode/Config/General.xcconfig: Added some warnings that Xcode 5 suggested.
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig: Add some of the warnings that Xcode 5 suggested.
- src/compiler/preprocessor/Tokenizer.l: Defined YY_NO_INPUT so we don't compile
an unused function and get a warning.
- 10:30 PM Changeset in webkit [156631] by
-
- 9 edits in trunk
Fix the Lion build.
Ensure that C++ and Objective-C++ files build with the right compiler flags.
Source/WebCore:
- Configurations/WebCore.xcconfig:
Source/WebKit/mac:
- Configurations/WebKit.xcconfig:
Source/WebKit2:
- Configurations/BaseTarget.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
- WebKitTestRunner/Configurations/BaseTarget.xcconfig:
- 10:28 PM Changeset in webkit [156630] by
-
- 5 edits in trunk/Source/WebCore
Generate toCSSFooValue() for CSSLineBoxContainValue
https://bugs.webkit.org/show_bug.cgi?id=122054
Reviewed by Darin Adler.
As a step to use toCSSFooValue, toCSSLineBoxContainValue is generated by using
CSS_VALUE_TYPE_CASTS. To use it, isCSSLineBoxContainValue() is changed to
isLineBoxContatinValue(). Unnecessary local variable is removed by this patch.
No new tests, no behavior changes.
- css/CSSLineBoxContainValue.h:
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isLineBoxContainValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- 10:26 PM Changeset in webkit [156629] by
-
- 4 edits in trunk/Source/WebCore
Generate toCSSCrossfadeValue() instead of using manual function
https://bugs.webkit.org/show_bug.cgi?id=122057
Reviewed by Antti Koivisto.
Generated toCSSFooValue() supports more plenty functions rather than
to use manual cast function.
No new tests, no behavior changes.
- css/CSSCrossfadeValue.h:
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- 10:22 PM Changeset in webkit [156628] by
-
- 6 edits in trunk/Source/WebCore
Generate toCSSFooValue() for CSSFilterImageValue and CSSInitialValue
https://bugs.webkit.org/show_bug.cgi?id=122056
Reviewed by Antti Koivisto.
Generate toCSSFooValue() for CSSFilterImageValue and CSSInitialValue, and use it.
This type cast function will help to detect bad-casts.
No new tests, no behavior changes.
- css/CSSFilterImageValue.h:
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):
- css/CSSInitialValue.h:
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::generatedOrPendingFromValue):
- 9:57 PM Changeset in webkit [156627] by
-
- 2 edits in trunk/Source/WebCore
Fix crashes caused by my recent attempt at a Windows build fix.
- bindings/js/WebCoreTypedArrayController.cpp: (WebCore::WebCoreTypedArrayController::toJS): Added back the prefix for the call to WebCore::toJS, otherwise this function just calls itself infinitely recursively.
- 9:56 PM Changeset in webkit [156626] by
-
- 2 edits in trunk/Source/WebKit2
Fix the build.
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::evaluate):
- 9:36 PM Changeset in webkit [156625] by
-
- 14 edits in trunk/Source/WebCore
Cleanup PageThrottler and PageConsole a bit
https://bugs.webkit.org/show_bug.cgi?id=122085
Reviewed by Anders Carlsson.
- html/HTMLMediaElement.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::completed):
- loader/FrameLoader.h:
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::checkForHTTPStatusCodeError):
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::willCancel):
- loader/SubresourceLoader.h:
Store the PageActivityAssertionToken as a std::unique_ptr.
- page/Page.cpp:
(WebCore::Page::Page):
Use createOwned and pass this by reference for the PageThrottler and PageConsole.
(WebCore::Page::~Page):
Remove unnecessary clearing of an OwnPtr that is about to be destroyed.
- page/Page.h:
Make m_pageThrottler const and return it as a reference.
- page/PageActivityAssertionToken.cpp:
(WebCore::PageActivityAssertionToken::PageActivityAssertionToken):
(WebCore::PageActivityAssertionToken::~PageActivityAssertionToken):
- page/PageActivityAssertionToken.h:
Take the PageThrottler by reference in the constructor. It is never null.
- page/PageConsole.cpp:
(WebCore::PageConsole::PageConsole):
(WebCore::PageConsole::~PageConsole):
(WebCore::PageConsole::addMessage):
- page/PageConsole.h:
Pass and store the Page as a reference and remove an extraneous null check. Remove
the create function.
- page/PageThrottler.cpp:
(WebCore::PageThrottler::PageThrottler):
(WebCore::PageThrottler::~PageThrottler):
(WebCore::PageThrottler::createActivityToken):
(WebCore::PageThrottler::throttlePage):
(WebCore::PageThrottler::unthrottlePage):
(WebCore::PageThrottler::addActivityToken):
(WebCore::PageThrottler::removeActivityToken):
- page/PageThrottler.h:
Pass and store the Page as a reference. Move the creation of PageActivityAssertionToken here
to aid encapsulation.
- 8:45 PM Changeset in webkit [156624] by
-
- 52 edits in trunk/Source
Pass VM instead of JSGlobalObject to function constructors.
<https://webkit.org/b/122082>
Reviewed by Darin Adler.
Functions don't need anything from the global object during their
construction and only use it to get to the VM. Reduce loads by
simply passing the VM around instead.
This patch is mostly mechanical, I just changed the signature of
InternalFunction and worked my way from there until it built.
JSC release binary size -= 4840 bytes.
- 7:54 PM Changeset in webkit [156623] by
-
- 2 edits in trunk/Source/WebCore
Try to fix Windows build.
- bindings/js/WebCoreTypedArrayController.cpp: Windows has a symbol named Handle, so we need to call JSC::Handle out by name. To fix that, I removed "using namespace JSC" entirely. And just for fun, sort of "rewrote" this file. (WebCore::WebCoreTypedArrayController::WebCoreTypedArrayController): Removed unneeded explicit initialization of m_owner. (WebCore::WebCoreTypedArrayController::~WebCoreTypedArrayController): Fixed formatting. (WebCore::WebCoreTypedArrayController::toJS): Added lots of explicit JSC and got rid of local. (WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::isReachableFromOpaqueRoots): Cut down on locals, used auto& for type, and called it "wrapper" since that's what JSArrayBuffer is. (WebCore::WebCoreTypedArrayController::JSArrayBufferOwner::finalize): More of the same.
- 7:40 PM Changeset in webkit [156622] by
-
- 138 edits in trunk/Source
Use RenderElement instead of RenderObject in many places
https://bugs.webkit.org/show_bug.cgi?id=122078
Reviewed by Andreas Kling.
Source/ThirdParty/ANGLE:
- ANGLE.xcodeproj/project.pbxproj: Let Xcode do its thing to this file.
Source/WebCore:
- WebCore.exp.in: Updated for name changes.
- dom/ContainerNode.h: Moved renderer() here from Element.
- dom/Element.h: Moved renderer() from here to ContainerNode.
- render/RenderElement.h: Moved renderer() from Element to ContainerNode.
- accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::imageMapLinkRenderer):
(WebCore::AccessibilityImageMapLink::detachFromParent):
(WebCore::AccessibilityImageMapLink::elementPath):
(WebCore::AccessibilityImageMapLink::elementRect):
- accessibility/AccessibilityImageMapLink.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
- bindings/objc/DOM.mm:
(-[DOMElement image]):
(-[DOMElement _font]):
(-[DOMElement _imageTIFFRepresentation]):
- css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::canvasChanged):
(WebCore::CSSCanvasValue::canvasResized):
(WebCore::CSSCanvasValue::canvasDestroyed):
(WebCore::CSSCanvasValue::fixedSize):
(WebCore::CSSCanvasValue::image):
- css/CSSCanvasValue.h:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::computeRenderStyleForProperty):
- css/CSSCrossfadeValue.cpp:
(WebCore::subimageKnownToBeOpaque):
(WebCore::CSSCrossfadeValue::fixedSize):
(WebCore::CSSCrossfadeValue::knownToBeOpaque):
(WebCore::CSSCrossfadeValue::image):
(WebCore::CSSCrossfadeValue::crossfadeChanged):
- css/CSSCrossfadeValue.h:
- css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::fixedSize):
(WebCore::CSSFilterImageValue::knownToBeOpaque):
(WebCore::CSSFilterImageValue::image):
(WebCore::CSSFilterImageValue::filterImageChanged):
- css/CSSFilterImageValue.h:
- css/CSSFontSelector.cpp:
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image):
(WebCore::CSSGradientValue::addStops):
(WebCore::CSSGradientValue::knownToBeOpaque):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::createGradient):
- css/CSSGradientValue.h:
(WebCore::CSSGradientValue::fixedSize):
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::addClient):
(WebCore::CSSImageGeneratorValue::removeClient):
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::knownToBeOpaque):
- css/CSSImageGeneratorValue.h:
(WebCore::CSSImageGeneratorValue::clients):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::knownToBeOpaque):
- css/CSSImageValue.h:
- css/DeprecatedStyleBuilder.cpp:
- dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::removeMarkersFromList):
(WebCore::DocumentMarkerController::repaintMarkers):
- dom/Element.cpp:
(WebCore::localZoomForRenderer):
(WebCore::adjustForLocalZoom):
(WebCore::Element::offsetParent):
(WebCore::Element::updateExistingPseudoElement):
- dom/ElementRareData.h:
(WebCore::ElementRareData::create):
(WebCore::ElementRareData::ElementRareData):
- dom/Node.cpp:
(WebCore::Node::ensureRareData):
- editing/DeleteButtonController.cpp:
(WebCore::isDeletableElement):
- editing/Editor.cpp:
(WebCore::Editor::hasBidiSelection):
(WebCore::Editor::baseWritingDirectionForSelectionStart):
- editing/EditorCommand.cpp:
(WebCore::verticalScrollDistance):
- editing/htmlediting.cpp:
(WebCore::directionOfEnclosingBlock):
- editing/ios/EditorIOS.mm:
(WebCore::Editor::fontForSelection):
(WebCore::getImage):
- editing/mac/EditorMac.mm:
(WebCore::Editor::fontForSelection):
(WebCore::getImage):
- editing/markup.cpp:
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::computePath):
(WebCore::HTMLAreaElement::computeRect):
(WebCore::HTMLAreaElement::setFocus):
- html/HTMLAreaElement.h:
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::reset):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::setInnerText):
- html/HTMLFormControlElement.cpp:
(WebCore::updateFromElementCallback):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::rendererIsNeeded):
- html/HTMLFrameOwnerElement.h:
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::x):
(WebCore::HTMLImageElement::y):
(WebCore::HTMLImageElement::willRespondToMouseClickEvents):
- html/HTMLMapElement.cpp:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::defaultEventHandler):
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::renderMeter):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::didRecalcStyle):
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::willRespondToMouseClickEvents):
(WebCore::HTMLPlugInElement::defaultEventHandler):
(WebCore::HTMLPlugInElement::isKeyboardFocusable):
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::defaultEventHandler):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::renderProgress):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::scrollToSelection):
(WebCore::HTMLSelectElement::setOptionsChangedOnRenderer):
(WebCore::HTMLSelectElement::selectOption):
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::cellAbove):
- html/HTMLTextFormControlElement.cpp:
(WebCore::hasVisibleTextArea):
(WebCore::HTMLTextFormControlElement::setSelectionRange):
- html/InputType.h:
- html/parser/HTMLResourcePreloader.cpp:
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlElement::setDisplayType):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::startDrag):
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
- html/shadow/MeterShadowElement.cpp:
(WebCore::MeterShadowElement::rendererIsNeeded):
(WebCore::MeterInnerElement::rendererIsNeeded):
- inspector/InspectorOverlay.cpp:
- inspector/InspectorTimelineAgent.cpp:
- inspector/InspectorTimelineAgent.h:
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::renderImageResource):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::currentFrameKnownToBeOpaque):
- loader/cache/CachedImage.h:
- mathml/MathMLElement.cpp:
- page/ContextMenuController.cpp:
- page/DragController.cpp:
(WebCore::DragController::draggableElement):
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear):
(WebCore::EventHandler::startPanScrolling):
(WebCore::EventHandler::autoscrollRenderer):
(WebCore::EventHandler::scrollOverflow):
(WebCore::EventHandler::logicalScrollOverflow):
(WebCore::EventHandler::subframeForTargetNode):
(WebCore::EventHandler::selectCursor):
(WebCore::layerForNode):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::clearGestureScrollNodes):
- page/EventHandler.h:
- page/FocusController.cpp:
- page/Frame.cpp:
(WebCore::Frame::ownerRenderer):
(WebCore::Frame::visiblePositionForPoint):
(WebCore::Frame::nodeImage):
- page/FrameView.cpp:
(WebCore::FrameView::applyOverflowToViewport):
(WebCore::FrameView::applyPaginationToViewport):
(WebCore::FrameView::calculateScrollbarModesForLayout):
(WebCore::FrameView::isEnclosedInCompositingLayer):
(WebCore::FrameView::embeddedContentBox):
(WebCore::FrameView::addSlowRepaintObject):
(WebCore::FrameView::removeSlowRepaintObject):
(WebCore::FrameView::addViewportConstrainedObject):
(WebCore::FrameView::removeViewportConstrainedObject):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::repaintSlowRepaintObjects):
(WebCore::FrameView::setViewportConstrainedObjectsNeedLayout):
(WebCore::FrameView::updateOverflowStatus):
(WebCore::FrameView::updateScrollCorner):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::convertFromRenderer):
(WebCore::FrameView::convertToRenderer):
- page/FrameView.h:
- page/PageSerializer.cpp:
(WebCore::PageSerializer::addImageToResources):
- page/PageSerializer.h:
- page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::AnimationBase):
(WebCore::AnimationBase::updateStateMachine):
- page/animation/AnimationBase.h:
(WebCore::AnimationBase::renderer):
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::ensureCompositeAnimation):
(WebCore::AnimationControllerPrivate::clear):
(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer):
(WebCore::AnimationControllerPrivate::isRunningAnimationOnRenderer):
(WebCore::AnimationControllerPrivate::isRunningAcceleratedAnimationOnRenderer):
(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):
(WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
(WebCore::AnimationControllerPrivate::getAnimatedStyleForRenderer):
(WebCore::AnimationControllerPrivate::numberOfActiveAnimations):
(WebCore::AnimationController::cancelAnimations):
(WebCore::AnimationController::updateAnimations):
(WebCore::AnimationController::getAnimatedStyleForRenderer):
(WebCore::AnimationController::notifyAnimationStarted):
(WebCore::AnimationController::pauseAnimationAtTime):
(WebCore::AnimationController::pauseTransitionAtTime):
(WebCore::AnimationController::isRunningAnimationOnRenderer):
(WebCore::AnimationController::isRunningAcceleratedAnimationOnRenderer):
- page/animation/AnimationController.h:
- page/animation/AnimationControllerPrivate.h:
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::crossfadeBlend):
- page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::updateKeyframeAnimations):
(WebCore::CompositeAnimation::animate):
- page/animation/CompositeAnimation.h:
- page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::ImplicitAnimation):
(WebCore::ImplicitAnimation::animate):
(WebCore::ImplicitAnimation::pauseAnimation):
(WebCore::ImplicitAnimation::sendTransitionEvent):
- page/animation/ImplicitAnimation.h:
(WebCore::ImplicitAnimation::create):
- page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::animate):
(WebCore::KeyframeAnimation::pauseAnimation):
(WebCore::KeyframeAnimation::endAnimation):
(WebCore::KeyframeAnimation::sendAnimationEvent):
- page/animation/KeyframeAnimation.h:
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::passSubframeEventToSubframe):
- page/mac/FrameSnapshottingMac.mm:
(WebCore::snapshotDragImage):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::paint):
- rendering/CounterNode.cpp:
(WebCore::CounterNode::CounterNode):
(WebCore::CounterNode::create):
- rendering/CounterNode.h:
(WebCore::CounterNode::owner):
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::buildReferenceFilter):
(WebCore::FilterEffectRenderer::build):
- rendering/FilterEffectRenderer.h:
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::spellingToolTip):
(WebCore::HitTestResult::title):
(WebCore::HitTestResult::innerTextIfTruncated):
(WebCore::HitTestResult::image):
- rendering/LayoutRepainter.cpp:
(WebCore::LayoutRepainter::LayoutRepainter):
- rendering/LayoutRepainter.h:
- rendering/LayoutState.h:
(WebCore::LayoutState::LayoutState):
- rendering/LineWidth.h:
- rendering/LogicalSelectionOffsetCaches.h:
(WebCore::isContainingBlockCandidateForAbsolutelyPositionedObject):
(WebCore::isNonRenderBlockInline):
(WebCore::containingBlockForFixedPosition):
(WebCore::containingBlockForAbsolutePosition):
(WebCore::containingBlockForObjectInFlow):
(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):
- rendering/PaintInfo.h:
(WebCore::PaintInfo::PaintInfo):
(WebCore::PaintInfo::updateSubtreePaintRootForChildren):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintFillLayers):
(WebCore::RenderBox::paintFillLayer):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
- rendering/RenderBoxModelObject.h:
- rendering/RenderCounter.cpp:
(WebCore::nextInPreOrder):
(WebCore::planCounter):
(WebCore::makeCounterNode):
(WebCore::RenderCounter::originalText):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::~RenderElement):
(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::removeChildInternal):
(WebCore::RenderElement::willBeDestroyed):
(WebCore::RenderElement::rendererForRootBackground):
- rendering/RenderImageResource.cpp:
(WebCore::RenderImageResource::initialize):
- rendering/RenderImageResource.h:
- rendering/RenderImageResourceStyleImage.cpp:
(WebCore::RenderImageResourceStyleImage::initialize):
- rendering/RenderImageResourceStyleImage.h:
(WebCore::RenderImageResourceStyleImage::create):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::canBeComposited):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore):
(WebCore::RenderLayerCompositor::reasonsForCompositing):
(WebCore::RenderLayerCompositor::requiresCompositingForTransform):
(WebCore::RenderLayerCompositor::requiresCompositingForVideo):
(WebCore::RenderLayerCompositor::requiresCompositingForCanvas):
(WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
(WebCore::RenderLayerCompositor::requiresCompositingForFrame):
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason):
(WebCore::RenderLayerCompositor::requiresCompositingForFilters):
(WebCore::RenderLayerCompositor::requiresCompositingForBlending):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
(WebCore::RenderLayerCompositor::isRunningAcceleratedTransformAnimation):
- rendering/RenderLayerCompositor.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
(WebCore::mustRepaintFillLayers):
(WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered):
(WebCore::RenderObject::willBeDestroyed):
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::rendererOwningScrollbar):
- rendering/RenderScrollbarPart.h:
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
- rendering/RenderTableCell.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
- rendering/style/FillLayer.cpp:
(WebCore::FillLayer::hasOpaqueImage):
- rendering/style/FillLayer.h:
- rendering/style/KeyframeList.h:
(WebCore::KeyframeList::KeyframeList):
- rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::imageSize):
(WebCore::StyleCachedImage::computeIntrinsicDimensions):
(WebCore::StyleCachedImage::setContainerSizeForRenderer):
(WebCore::StyleCachedImage::addClient):
(WebCore::StyleCachedImage::removeClient):
(WebCore::StyleCachedImage::image):
(WebCore::StyleCachedImage::knownToBeOpaque):
- rendering/style/StyleCachedImage.h:
- rendering/style/StyleCachedImageSet.cpp:
(WebCore::StyleCachedImageSet::imageSize):
(WebCore::StyleCachedImageSet::computeIntrinsicDimensions):
(WebCore::StyleCachedImageSet::setContainerSizeForRenderer):
(WebCore::StyleCachedImageSet::addClient):
(WebCore::StyleCachedImageSet::removeClient):
(WebCore::StyleCachedImageSet::image):
(WebCore::StyleCachedImageSet::knownToBeOpaque):
- rendering/style/StyleCachedImageSet.h:
- rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::imageSize):
(WebCore::StyleGeneratedImage::computeIntrinsicDimensions):
(WebCore::StyleGeneratedImage::addClient):
(WebCore::StyleGeneratedImage::removeClient):
(WebCore::StyleGeneratedImage::image):
(WebCore::StyleGeneratedImage::knownToBeOpaque):
- rendering/style/StyleGeneratedImage.h:
- rendering/style/StyleImage.h:
(WebCore::StyleImage::imagesEquivalent):
- rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::cssImageValue):
(WebCore::StylePendingImage::cssImageGeneratorValue):
(WebCore::StylePendingImage::cssCursorImageValue):
(WebCore::StylePendingImage::cssImageSetValue):
(WebCore::StylePendingImage::computeIntrinsicDimensions):
- testing/Internals.cpp:
(WebCore::Internals::boundingBox):
(WebCore::Internals::isSelectPopupVisible):
(WebCore::Internals::isPluginUnavailabilityIndicatorObscured):
Use RenderElement instead of RenderObject where it was easy to do so.
For local variables holding the return value of renderer() functions,
use auto instead, so the most-specific possible type will be used,
without having to figure out what that is in each case. Also use some
more OVERRIDE and FINAL and use nullptr instead of 0. And replace some
cryptic short local variable names with words.
- 5:57 PM Changeset in webkit [156621] by
-
- 4 edits in trunk/Source/JavaScriptCore
Pass VM instead of JSGlobalObject to ArrayPrototype constructor.
<https://webkit.org/b/122079>
Reviewed by Geoffrey Garen.
ArrayPrototype doesn't need the global object for anything during
construction, so reduce the amount of loads by just passing the VM.
- 3:20 PM Changeset in webkit [156620] by
-
- 31 edits in trunk/Source
Pass VM instead of ExecState to simple builtin constructors.
<https://webkit.org/b/122077>
Reviewed by Sam Weinig.
None of the simple builtins need the ExecState for anything during
their construction, so reduce the amount of loads by just passing
the VM around instead.
- 3:16 PM Changeset in webkit [156619] by
-
- 8 edits3 adds in trunk
Repaint borders and outlines on pseudo content changes
https://bugs.webkit.org/show_bug.cgi?id=122070
Reviewed by Andreas Kling.
Source/WebCore:
This patch fixes a regression from wkrev.com/150259 where pseudo content with
borders or outlines would fail to repaint if the color property changed.
The root bug is that border-color and outline-color properties use 'color' if
no explicit border-color or outline-color are given, and changing color should
repaint borders and outlines even if the text content is empty.
Relevant spec sections:
border: http://www.w3.org/TR/CSS1/#border-color
outline: http://www.w3.org/TR/CSS2/ui.html#propdef-outline-color
This patch also renames StyleDifferenceRepaintIfText to
StyleDifferenceRepaintIfTextOrBorderOrOutline and updates the relevant functions.
Test: fast/repaint/hover-pseudo-borders.html
- rendering/RenderElement.cpp:
(WebCore::RenderElement::hasImmediateNonWhitespaceTextChildOrBorderOrOutline):
This function has been renamed to reflect that it returns true for borders
or outlines as well.
(WebCore::RenderElement::shouldRepaintForStyleDifference):
- rendering/RenderElement.h:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresRepaintIfTextOrBorderOrOutline):
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientStyleChanged):
These have also been renamed to reflect the new borders and outlines check.
LayoutTests:
- fast/repaint/hover-pseudo-borders.html: Added.
- platform/mac/fast/repaint/hover-pseudo-borders-expected.png: Added.
- platform/mac/fast/repaint/hover-pseudo-borders-expected.txt: Added.
- 1:50 PM Changeset in webkit [156618] by
-
- 6 edits in trunk/Source/WebCore
Tighten typing in inline rendering
https://bugs.webkit.org/show_bug.cgi?id=122076
Reviewed by Andreas Kling.
More RenderElement, const, &, etc.
- dom/Position.cpp:
(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
- rendering/InlineFlowBox.cpp:
(WebCore::isLastChildForRenderer):
(WebCore::isAncestorAndWithinBlock):
(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
(WebCore::InlineFlowBox::nodeAtPoint):
- rendering/InlineIterator.h:
(WebCore::InlineIterator::InlineIterator):
(WebCore::InlineIterator::root):
(WebCore::isEmptyInline):
(WebCore::bidiNextShared):
(WebCore::bidiNextSkippingEmptyInlines):
(WebCore::bidiNextIncludingEmptyInlines):
(WebCore::bidiFirstSkippingEmptyInlines):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineLogicalWidth):
(WebCore::alwaysRequiresLineBox):
(WebCore::requiresLineBox):
(WebCore::canBreakAtThisPosition):
(WebCore::LineBreaker::nextSegmentBreak):
- rendering/shapes/ShapeInsideInfo.h:
(WebCore::LineSegmentIterator::LineSegmentIterator):
- 12:31 PM Changeset in webkit [156617] by
-
- 2 edits in trunk/Source/JavaScriptCore
Refactor code for finding x86 scratch register.
https://bugs.webkit.org/show_bug.cgi?id=122072
Patch by Nadav Rotem <nrotem@apple.com> on 2013-09-29
Reviewed by Geoffrey Garen.
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::getUnusedRegister):
(JSC::MacroAssemblerX86Common::store8):
(JSC::MacroAssemblerX86Common::store16):
- 11:04 AM Changeset in webkit [156616] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening. Skip the IndexedDB tests for now as the feature is going
through substantial changes that don't ensure constant proper functionality.
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
