Timeline



Oct 10, 2013:

11:41 PM Changeset in webkit [157294] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

Make EventPath private to EventDispatcher.cpp
https://bugs.webkit.org/show_bug.cgi?id=122638

Reviewed by Darin Adler.

Move the declaration of EventPath into EventDispatcher.cpp since EventPath is only used in this file.
Also make EventDispatcher a namespace since it is never instantiated since r157250.

  • dom/EventDispatcher.cpp:

(WebCore::EventPath::isEmpty):
(WebCore::EventPath::size):
(WebCore::EventPath::contextAt):
(WebCore::EventPath::lastContextIfExists):

  • dom/EventDispatcher.h:
  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willDispatchEvent):

11:37 PM Changeset in webkit [157293] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

FTL shouldn't pass i1's into llvm.webkit.stackmap's
https://bugs.webkit.org/show_bug.cgi?id=122629
<rdar://problem/15203037>

Reviewed by Sam Weinig and Nadav Rotem.

LLVM's stackmap support requires that we only pass operands with legal types (i.e. types
that are hardware-representable). i1, which the FTL previously used for Booleans, is not
legal.

We have two options: either add support in LLVM to legalize stackmap operands, or add
support to the FTL to legalize stackmap operands. It's easier to fix this in FTL, and
that's what this patch does.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):

11:18 PM Changeset in webkit [157292] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

contentEditable with "position:relative" paragraphs is buggy
https://bugs.webkit.org/show_bug.cgi?id=33950

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-10
Reviewed by Darin Adler.

Source/WebCore:

When paragraph is positioned(relative/absolute/fixed) then deleting
that paragraph cause wrong merging of other(below) paragraphs. This is
happening because positioned element is treated as special element and
on deletion complete paragraph element is removed. The ranges become
paragraph. This issue happens when all the content of special element
are deleted. So the merging of paragraph is avoided in this scenario.

Test: editing/deleting/deleting-relative-positioned-special-element.html

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::initializeStartEnd):Avoid merging
block when special candidate are included in deletion range

LayoutTests:

LayoutTests:

Added a testcase to verify that when paragraph is relative positioned
then deleting the all content of paragraph should not incorrectly collapse the
others(below) paragraphs.
And Rebaseline the test expectation.

  • editing/deleting/5546763-expected.txt: Updated.
  • editing/deleting/deleting-relative-positioned-special-element-expected.txt: Added.
  • editing/deleting/deleting-relative-positioned-special-element.html: Added.
  • editing/unsupported-content/table-delete-001.html: Adjusted to dump

as markup.

  • editing/unsupported-content/table-delete-003.html: Adjusted to dump

as markup.

Below tests had wrong cursor position previously now corrected and
both expected file has been changed to markup dump.

  • platform/mac/editing/unsupported-content/table-delete-001-expected.txt:
  • platform/mac/editing/unsupported-content/table-delete-003-expected.txt:
11:17 PM Changeset in webkit [157291] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Layout Test fast/css/font-face-download-error.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122636

Reviewed by Darin Adler.

  • fast/css/font-face-download-error-expected.txt: TEST COMPLETE is now printed

after the test is complete.

  • fast/css/font-face-download-error.html: Changed to properly wait for fonts to load.

Also, updated to use a proper async test implementation.

11:16 PM Changeset in webkit [157290] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Track controls show metadata and chapter tracks
https://bugs.webkit.org/show_bug.cgi?id=122468

Patch by Brendan Long <b.long@cablelabs.com> on 2013-10-10
Reviewed by Darin Adler.

Source/WebCore:

Test: media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html

  • page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::sortedTrackListForMenu): Only show captions, descriptions and subtitles in the track controls.

LayoutTests:

Add a test to make sure we don't show metadata and chapter tracks in the track controls.

  • media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles-expected.txt: Added.
  • media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html: Added.
  • platform/efl/TestExpectations: Skip, uses caption button, not track menu.
  • platform/mac/TestExpectations: Skip, track menu tests all fail on Mac.
  • platform/win/TestExpectations: Same.
9:55 PM Changeset in webkit [157289] by bw80.lee@samsung.com
  • 4 edits
    3 adds in trunk/Source/WebKit2

[EFL][WK2] Separate dispatch context from WorkQueue.
https://bugs.webkit.org/show_bug.cgi?id=115332

Reviewed by Anders Carlsson.

Refactor WorkQueue to prevent dangling workqueue access.

Previously, the WorkQueue class had all context about dispatch.
WorkQueue had dispatch item queue and socket event handler,
and those were accessed on the work queue thread through WorkQueue
instance.

With reference countable WorkQueue concept, this implementation
complicates handling workqueue ref-counting and causes dangling
workqueue access problem.

To make it easy to handle WorkQueue reference count and to prevent
dangling access problem, DispatchQueue class is added to handle
dispatch tasks, and the WorkQueue instance and DispatchQueue thread
will have the reference count of the DispatchQueue instance to prevent
dangling access.

  • Platform/WorkQueue.h:
  • Platform/efl/DispatchQueueEfl.cpp: Added.

(DispatchQueue::ThreadContext::start):
(DispatchQueue::ThreadContext::ThreadContext):
(DispatchQueue::ThreadContext::function):
(DispatchQueue::create):
(DispatchQueue::DispatchQueue):
(DispatchQueue::~DispatchQueue):
(DispatchQueue::dispatch):
(DispatchQueue::stopThread):
(DispatchQueue::setSocketEventHandler):
(DispatchQueue::clearSocketEventHandler):
(DispatchQueue::performWork):
(DispatchQueue::performTimerWork):
(DispatchQueue::performFileDescriptorWork):
(DispatchQueue::insertTimerWorkItem):
(DispatchQueue::dispatchQueueThread):
(DispatchQueue::wakeUpThread):
(DispatchQueue::getNextTimeOut):

  • Platform/efl/DispatchQueueEfl.h: Added.
  • Platform/efl/DispatchQueueWorkItemEfl.h: Added.

(WorkItem::create):
(WorkItem::dispatch):
(WorkItem::WorkItem):
(TimerWorkItem::create):
(TimerWorkItem::expirationTimeSeconds):
(TimerWorkItem::hasExpired):
(TimerWorkItem::TimerWorkItem):

  • Platform/efl/WorkQueueEfl.cpp:

(WorkQueue::platformInitialize):
(WorkQueue::platformInvalidate):
(WorkQueue::registerSocketEventHandler):
(WorkQueue::unregisterSocketEventHandler):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):

  • PlatformEfl.cmake:
8:56 PM Changeset in webkit [157288] by rniwa@webkit.org
  • 14 edits
    2 deletes in trunk/Source/WebCore

EventContext should be used only in EventDispatcher.cpp
https://bugs.webkit.org/show_bug.cgi?id=122631

Reviewed by Anders Carlsson.

Merged WindowEventContext into EventDispatcher. Moved the code to avoid dispatching load event on
window into dispatchEventInDOM so that WindowEventContext's constructor doesn't need Event.

Also replaced DOMWindow, Node, and EventPath arguments to InspectorInstrumentation::willDispatchEvent
by a single boolean indicating whether window, the origin, or the event path has an event listener.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/EventDispatcher.cpp:

(WebCore::WindowEventContext::window): Moved from WindowEventContext.
(WebCore::WindowEventContext::target): Ditto.
(WebCore::WindowEventContext::WindowEventContext): Ditto; removed the code to avoid dispatching load
event on window since that's checked in dispatchEventInDOM now.
(WebCore::WindowEventContext::handleLocalEvents): Ditto.
(WebCore::dispatchEventInDOM): Avoid calling handleLocalEvent on a load event with WindowEventContext.
(WebCore::EventDispatcher::dispatchEvent): Pass a boolean to indicate whether window, the origin, or
the event path contains any event listener to InspectorInstrumentation::willDispatchEvent to hide
EventPath from the inspector code.

  • dom/EventDispatcher.h:
  • dom/Node.cpp:
  • dom/Node.h:
  • dom/WindowEventContext.cpp: Removed.
  • dom/WindowEventContext.h: Removed.
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willDispatchEventImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willDispatchEvent):

8:51 PM Changeset in webkit [157287] by Darin Adler
  • 2 edits in trunk/Source/WebCore

REGRESSION (r157205?): Leaks in XPath
https://bugs.webkit.org/show_bug.cgi?id=122609

Reviewed by Andreas Kling.

  • xml/XPathGrammar.y: Fixed warnings by adding missing "$$ = $1" to various rules.

Added local unique_ptr for NodeTest and ArgumentList in three rules, so they
won't be leaked.

8:37 PM Changeset in webkit [157286] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source/WebCore

Add toSVGColor|Paint() to cleanup static_cast<>, and use it
https://bugs.webkit.org/show_bug.cgi?id=122630

Reviewed by Andreas Kling.

SVGColor and SVGPaint can't use CSS_VALUE_TYPE_CASTS(), this cl adds
toSVGColor() and toSVGPaint() manually. Those functions will help to
detect bad type cast.

  • css/CSSValue.cpp:

(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • svg/SVGColor.h:

(WebCore::toSVGColor):

  • svg/SVGPaint.h:

(WebCore::toSVGPaint):

6:47 PM Changeset in webkit [157285] by akling@apple.com
  • 11 edits
    2 deletes in trunk/Source/WebCore

Kill WebCore::BindingState.
<https://webkit.org/b/122606>

Reviewed by Darin Adler.

Just use JSC::ExecState directly instead.

6:47 PM Changeset in webkit [157284] by kov@webkit.org
  • 2 edits in trunk/Tools

webkit-patch failure-reason has a quite low limit for 'too many failures'
https://bugs.webkit.org/show_bug.cgi?id=122556

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-10-10
Reviewed by Darin Adler.

  • Scripts/webkitpy/tool/commands/queries.py:

(FailureReason._explain_failures_for_builder): adjust the number of too many failures
to match what the layout test runners use these days.

6:41 PM Changeset in webkit [157283] by kov@webkit.org
  • 2 edits in trunk/Tools

webkit-patch failure-reason should allow specifying failures one is interested in
https://bugs.webkit.org/show_bug.cgi?id=122554

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-10-10
Reviewed by Darin Adler.

  • Scripts/webkitpy/tool/commands/queries.py:

(FailureReason):
(FailureReason._explain_failures_for_builder): keep track of explained failures and drop out of the
loop if the ones we're interested in been explained.
(FailureReason._done_explaining): check the failures we're interested in have been explained, if any.
(FailureReason.execute): initialize failures to explain and the explained set.

6:14 PM Changeset in webkit [157282] by rniwa@webkit.org
  • 17 edits
    2 deletes in trunk/Source/WebCore

Remove EventRetargeter.h/cpp
https://bugs.webkit.org/show_bug.cgi?id=122625

Reviewed by Anders Carlsson.

Merged the remaining contents of EventRetargeter.h and EventRetargter.cpp into EventDispatcher.cpp.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/indieui/UIRequestEvent.cpp:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/Event.cpp:
  • dom/Event.h:
  • dom/EventDispatcher.cpp:

(WebCore::eventTargetRespectingTargetRules):
(WebCore::shouldEventCrossShadowBoundary):
(WebCore::nodeOrHostIfPseudoElement):
(WebCore::EventPath::EventPath):
(WebCore::buildRelatedNodeMap):
(WebCore::addRelatedNodeForUnmapedTreeScopes):
(WebCore::calculateAdjustedNodes):
(WebCore::updateTouchListsInEventPath):
(WebCore::EventPath::updateTouchLists):
(WebCore::EventPath::setRelatedTarget):

  • dom/EventRetargeter.cpp: Removed.
  • dom/EventRetargeter.h: Removed.
  • dom/FocusEvent.cpp:
  • dom/GestureEvent.h:
  • dom/KeyboardEvent.h:
  • dom/MouseEvent.cpp:
  • dom/MouseEvent.h:
  • dom/TouchEvent.cpp:
  • dom/UIEvent.cpp:
  • dom/WheelEvent.cpp:
5:51 PM Changeset in webkit [157281] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit

Windows build fix attempt.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
5:40 PM Changeset in webkit [157280] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Making the base implementation of isAudioStreamSource, in MediaStreamSource, return the correct value
https://bugs.webkit.org/show_bug.cgi?id=122612

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-10
Reviewed by Jer Noble.

There is no reason for this implementation, in the base class, to always return false
if we already have the information about the type of the source.

No new tests needed.

  • Modules/webaudio/MediaStreamAudioSource.h:
  • platform/mediastream/MediaStreamSource.h:

(WebCore::MediaStreamSource::isAudioStreamSource):

5:30 PM Changeset in webkit [157279] by Simon Fraser
  • 2 edits in trunk/Source/WebKit/mac

Always force layout before flushing compositing layers
https://bugs.webkit.org/show_bug.cgi?id=122626

Reviewed by Tim Horton.

[m_webView _flushCompositingChanges] only actually flushes compositing
layers if the FrameView does not need layout (FrameView::flushCompositingStateForThisFrame()
returns in this case). In this situation, flushLayers() does actually try
to force a layout, but on some platforms it's possible for something else
to dirty layout before the runloop observer fires again. This can result
in flushLayers() never actually managing to flush, which stalls visual
updates.

Fix by always calling -viewWillDraw (which updates layout) before flushing
layers. This now matches WebKit2 behavior.

  • WebView/WebView.mm:

(LayerFlushController::flushLayers):

5:17 PM Changeset in webkit [157278] by timothy@apple.com
  • 1 edit
    431 deletes in trunk/Source/WebCore

Web Inspector: Remove the old front-end from WebKit.

https://bugs.webkit.org/show_bug.cgi?id=122295

  • inspector/front-end/AceTextEditor.js: Removed.
  • inspector/front-end/AdvancedSearchController.js: Removed.
  • inspector/front-end/ApplicationCacheItemsView.js: Removed.
  • inspector/front-end/ApplicationCacheModel.js: Removed.
  • inspector/front-end/AuditCategories.js: Removed.
  • inspector/front-end/AuditController.js: Removed.
  • inspector/front-end/AuditFormatters.js: Removed.
  • inspector/front-end/AuditLauncherView.js: Removed.
  • inspector/front-end/AuditResultView.js: Removed.
  • inspector/front-end/AuditRules.js: Removed.
  • inspector/front-end/AuditsPanel.js: Removed.
  • inspector/front-end/BottomUpProfileDataGridTree.js: Removed.
  • inspector/front-end/BreakpointManager.js: Removed.
  • inspector/front-end/BreakpointsSidebarPane.js: Removed.
  • inspector/front-end/CPUProfileView.js: Removed.
  • inspector/front-end/CSSMetadata.js: Removed.
  • inspector/front-end/CSSNamedFlowCollectionsView.js: Removed.
  • inspector/front-end/CSSNamedFlowView.js: Removed.
  • inspector/front-end/CSSSelectorProfileView.js: Removed.
  • inspector/front-end/CSSStyleModel.js: Removed.
  • inspector/front-end/CallStackSidebarPane.js: Removed.
  • inspector/front-end/CanvasProfileView.js: Removed.
  • inspector/front-end/Checkbox.js: Removed.
  • inspector/front-end/CodeMirrorTextEditor.js: Removed.
  • inspector/front-end/Color.js: Removed.
  • inspector/front-end/CompilerScriptMapping.js: Removed.
  • inspector/front-end/ConsoleMessage.js: Removed.
  • inspector/front-end/ConsoleModel.js: Removed.
  • inspector/front-end/ConsolePanel.js: Removed.
  • inspector/front-end/ConsoleView.js: Removed.
  • inspector/front-end/ContentProvider.js: Removed.
  • inspector/front-end/ContentProviderBasedProjectDelegate.js: Removed.
  • inspector/front-end/ContentProviders.js: Removed.
  • inspector/front-end/ContextMenu.js: Removed.
  • inspector/front-end/CookieItemsView.js: Removed.
  • inspector/front-end/CookieParser.js: Removed.
  • inspector/front-end/CookiesTable.js: Removed.
  • inspector/front-end/DOMAgent.js: Removed.
  • inspector/front-end/DOMBreakpointsSidebarPane.js: Removed.
  • inspector/front-end/DOMCountersGraph.js: Removed.
  • inspector/front-end/DOMExtension.js: Removed.
  • inspector/front-end/DOMPresentationUtils.js: Removed.
  • inspector/front-end/DOMStorage.js: Removed.
  • inspector/front-end/DOMStorageItemsView.js: Removed.
  • inspector/front-end/DOMSyntaxHighlighter.js: Removed.
  • inspector/front-end/DataGrid.js: Removed.
  • inspector/front-end/Database.js: Removed.
  • inspector/front-end/DatabaseQueryView.js: Removed.
  • inspector/front-end/DatabaseTableView.js: Removed.
  • inspector/front-end/DebuggerModel.js: Removed.
  • inspector/front-end/DebuggerScriptMapping.js: Removed.
  • inspector/front-end/DefaultScriptMapping.js: Removed.
  • inspector/front-end/DefaultTextEditor.js: Removed.
  • inspector/front-end/Dialog.js: Removed.
  • inspector/front-end/DirectoryContentView.js: Removed.
  • inspector/front-end/DockController.js: Removed.
  • inspector/front-end/Drawer.js: Removed.
  • inspector/front-end/ElementsPanel.js: Removed.
  • inspector/front-end/ElementsPanelDescriptor.js: Removed.
  • inspector/front-end/ElementsTreeOutline.js: Removed.
  • inspector/front-end/EmptyView.js: Removed.
  • inspector/front-end/EventListenersSidebarPane.js: Removed.
  • inspector/front-end/ExtensionAPI.js: Removed.
  • inspector/front-end/ExtensionAuditCategory.js: Removed.
  • inspector/front-end/ExtensionPanel.js: Removed.
  • inspector/front-end/ExtensionRegistryStub.js: Removed.
  • inspector/front-end/ExtensionServer.js: Removed.
  • inspector/front-end/ExtensionView.js: Removed.
  • inspector/front-end/FileContentView.js: Removed.
  • inspector/front-end/FileManager.js: Removed.
  • inspector/front-end/FileMapping.js: Removed.
  • inspector/front-end/FileSystemMapping.js: Removed.
  • inspector/front-end/FileSystemModel.js: Removed.
  • inspector/front-end/FileSystemProjectDelegate.js: Removed.
  • inspector/front-end/FileSystemView.js: Removed.
  • inspector/front-end/FileUtils.js: Removed.
  • inspector/front-end/FilteredItemSelectionDialog.js: Removed.
  • inspector/front-end/FlameChart.js: Removed.
  • inspector/front-end/FontView.js: Removed.
  • inspector/front-end/GoToLineDialog.js: Removed.
  • inspector/front-end/HAREntry.js: Removed.
  • inspector/front-end/HandlerRegistry.js: Removed.
  • inspector/front-end/HeapSnapshot.js: Removed.
  • inspector/front-end/HeapSnapshotDataGrids.js: Removed.
  • inspector/front-end/HeapSnapshotGridNodes.js: Removed.
  • inspector/front-end/HeapSnapshotLoader.js: Removed.
  • inspector/front-end/HeapSnapshotProxy.js: Removed.
  • inspector/front-end/HeapSnapshotView.js: Removed.
  • inspector/front-end/HeapSnapshotWorker.js: Removed.
  • inspector/front-end/HeapSnapshotWorkerDispatcher.js: Removed.
  • inspector/front-end/HelpScreen.js: Removed.
  • inspector/front-end/ImageView.js: Removed.
  • inspector/front-end/Images/addIcon.png: Removed.
  • inspector/front-end/Images/applicationCache.png: Removed.
  • inspector/front-end/Images/back.png: Removed.
  • inspector/front-end/Images/breakpointBorder.png: Removed.
  • inspector/front-end/Images/breakpointConditionalBorder.png: Removed.
  • inspector/front-end/Images/breakpointConditionalCounterBorder.png: Removed.
  • inspector/front-end/Images/breakpointCounterBorder.png: Removed.
  • inspector/front-end/Images/checker.png: Removed.
  • inspector/front-end/Images/closeButtons.png: Removed.
  • inspector/front-end/Images/cookie.png: Removed.
  • inspector/front-end/Images/database.png: Removed.
  • inspector/front-end/Images/databaseTable.png: Removed.
  • inspector/front-end/Images/debuggerContinue.png: Removed.
  • inspector/front-end/Images/debuggerPause.png: Removed.
  • inspector/front-end/Images/debuggerStepInto.png: Removed.
  • inspector/front-end/Images/debuggerStepOut.png: Removed.
  • inspector/front-end/Images/debuggerStepOver.png: Removed.
  • inspector/front-end/Images/deleteIcon.png: Removed.
  • inspector/front-end/Images/disclosureTriangleSmallDown.png: Removed.
  • inspector/front-end/Images/disclosureTriangleSmallDownBlack.png: Removed.
  • inspector/front-end/Images/disclosureTriangleSmallDownWhite.png: Removed.
  • inspector/front-end/Images/disclosureTriangleSmallRight.png: Removed.
  • inspector/front-end/Images/disclosureTriangleSmallRightBlack.png: Removed.
  • inspector/front-end/Images/disclosureTriangleSmallRightDown.png: Removed.
  • inspector/front-end/Images/disclosureTriangleSmallRightDownBlack.png: Removed.
  • inspector/front-end/Images/disclosureTriangleSmallRightDownWhite.png: Removed.
  • inspector/front-end/Images/disclosureTriangleSmallRightWhite.png: Removed.
  • inspector/front-end/Images/domain.png: Removed.
  • inspector/front-end/Images/errorIcon.png: Removed.
  • inspector/front-end/Images/errorMediumIcon.png: Removed.
  • inspector/front-end/Images/errorRedDot.png: Removed.
  • inspector/front-end/Images/fileSystem.png: Removed.
  • inspector/front-end/Images/forward.png: Removed.
  • inspector/front-end/Images/frame.png: Removed.
  • inspector/front-end/Images/glossyHeader.png: Removed.
  • inspector/front-end/Images/glossyHeaderPressed.png: Removed.
  • inspector/front-end/Images/glossyHeaderSelected.png: Removed.
  • inspector/front-end/Images/glossyHeaderSelectedPressed.png: Removed.
  • inspector/front-end/Images/goArrow.png: Removed.
  • inspector/front-end/Images/graphLabelCalloutLeft.png: Removed.
  • inspector/front-end/Images/graphLabelCalloutRight.png: Removed.
  • inspector/front-end/Images/indexedDB.png: Removed.
  • inspector/front-end/Images/indexedDBIndex.png: Removed.
  • inspector/front-end/Images/indexedDBObjectStore.png: Removed.
  • inspector/front-end/Images/localStorage.png: Removed.
  • inspector/front-end/Images/namedFlowOverflow.png: Removed.
  • inspector/front-end/Images/navigatorShowHideButton.png: Removed.
  • inspector/front-end/Images/paneAddButtons.png: Removed.
  • inspector/front-end/Images/paneBottomGrow.png: Removed.
  • inspector/front-end/Images/paneBottomGrowActive.png: Removed.
  • inspector/front-end/Images/paneElementStateButtons.png: Removed.
  • inspector/front-end/Images/paneFilterButtons.png: Removed.
  • inspector/front-end/Images/paneGrowHandleLine.png: Removed.
  • inspector/front-end/Images/paneRefreshButtons.png: Removed.
  • inspector/front-end/Images/paneSettingsButtons.png: Removed.
  • inspector/front-end/Images/popoverArrows.png: Removed.
  • inspector/front-end/Images/popoverBackground.png: Removed.
  • inspector/front-end/Images/profileGroupIcon.png: Removed.
  • inspector/front-end/Images/profileIcon.png: Removed.
  • inspector/front-end/Images/profileSmallIcon.png: Removed.
  • inspector/front-end/Images/profilesSilhouette.png: Removed.
  • inspector/front-end/Images/programCounterBorder.png: Removed.
  • inspector/front-end/Images/radioDot.png: Removed.
  • inspector/front-end/Images/regionEmpty.png: Removed.
  • inspector/front-end/Images/regionFit.png: Removed.
  • inspector/front-end/Images/regionOverset.png: Removed.
  • inspector/front-end/Images/resourceCSSIcon.png: Removed.
  • inspector/front-end/Images/resourceDocumentIcon.png: Removed.
  • inspector/front-end/Images/resourceDocumentIconSmall.png: Removed.
  • inspector/front-end/Images/resourceJSIcon.png: Removed.
  • inspector/front-end/Images/resourcePlainIcon.png: Removed.
  • inspector/front-end/Images/resourcePlainIconSmall.png: Removed.
  • inspector/front-end/Images/resourcesSizeGraphIcon.png: Removed.
  • inspector/front-end/Images/resourcesTimeGraphIcon.png: Removed.
  • inspector/front-end/Images/scriptsSilhouette.png: Removed.
  • inspector/front-end/Images/searchNext.png: Removed.
  • inspector/front-end/Images/searchPrev.png: Removed.
  • inspector/front-end/Images/searchSmallBlue.png: Removed.
  • inspector/front-end/Images/searchSmallBrightBlue.png: Removed.
  • inspector/front-end/Images/searchSmallGray.png: Removed.
  • inspector/front-end/Images/searchSmallWhite.png: Removed.
  • inspector/front-end/Images/segment.png: Removed.
  • inspector/front-end/Images/segmentEnd.png: Removed.
  • inspector/front-end/Images/segmentHover.png: Removed.
  • inspector/front-end/Images/segmentHoverEnd.png: Removed.
  • inspector/front-end/Images/segmentSelected.png: Removed.
  • inspector/front-end/Images/segmentSelectedEnd.png: Removed.
  • inspector/front-end/Images/sessionStorage.png: Removed.
  • inspector/front-end/Images/spinner.gif: Removed.
  • inspector/front-end/Images/spinnerActive.gif: Removed.
  • inspector/front-end/Images/spinnerActiveSelected.gif: Removed.
  • inspector/front-end/Images/spinnerInactive.gif: Removed.
  • inspector/front-end/Images/spinnerInactiveSelected.gif: Removed.
  • inspector/front-end/Images/splitviewDimple.png: Removed.
  • inspector/front-end/Images/splitviewDividerBackground.png: Removed.
  • inspector/front-end/Images/statusbarButtonGlyphs.png: Removed.
  • inspector/front-end/Images/statusbarButtonGlyphs2x.png: Removed.
  • inspector/front-end/Images/statusbarResizerHorizontal.png: Removed.
  • inspector/front-end/Images/statusbarResizerVertical.png: Removed.
  • inspector/front-end/Images/successGreenDot.png: Removed.
  • inspector/front-end/Images/thumbActiveHoriz.png: Removed.
  • inspector/front-end/Images/thumbActiveVert.png: Removed.
  • inspector/front-end/Images/thumbHoriz.png: Removed.
  • inspector/front-end/Images/thumbHoverHoriz.png: Removed.
  • inspector/front-end/Images/thumbHoverVert.png: Removed.
  • inspector/front-end/Images/thumbVert.png: Removed.
  • inspector/front-end/Images/tickMark.png: Removed.
  • inspector/front-end/Images/timelineHollowPillBlue.png: Removed.
  • inspector/front-end/Images/timelineHollowPillGray.png: Removed.
  • inspector/front-end/Images/timelineHollowPillGreen.png: Removed.
  • inspector/front-end/Images/timelineHollowPillOrange.png: Removed.
  • inspector/front-end/Images/timelineHollowPillPurple.png: Removed.
  • inspector/front-end/Images/timelineHollowPillRed.png: Removed.
  • inspector/front-end/Images/timelineHollowPillYellow.png: Removed.
  • inspector/front-end/Images/timelinePillBlue.png: Removed.
  • inspector/front-end/Images/timelinePillGray.png: Removed.
  • inspector/front-end/Images/timelinePillGreen.png: Removed.
  • inspector/front-end/Images/timelinePillOrange.png: Removed.
  • inspector/front-end/Images/timelinePillPurple.png: Removed.
  • inspector/front-end/Images/timelinePillRed.png: Removed.
  • inspector/front-end/Images/timelinePillYellow.png: Removed.
  • inspector/front-end/Images/toolbarIcons.png: Removed.
  • inspector/front-end/Images/toolbarIconsSmall.png: Removed.
  • inspector/front-end/Images/toolbarItemSelected.png: Removed.
  • inspector/front-end/Images/trackHoriz.png: Removed.
  • inspector/front-end/Images/trackVert.png: Removed.
  • inspector/front-end/Images/treeDownTriangleBlack.png: Removed.
  • inspector/front-end/Images/treeDownTriangleWhite.png: Removed.
  • inspector/front-end/Images/treeRightTriangleBlack.png: Removed.
  • inspector/front-end/Images/treeRightTriangleWhite.png: Removed.
  • inspector/front-end/Images/treeUpTriangleBlack.png: Removed.
  • inspector/front-end/Images/treeUpTriangleWhite.png: Removed.
  • inspector/front-end/Images/userInputIcon.png: Removed.
  • inspector/front-end/Images/userInputPreviousIcon.png: Removed.
  • inspector/front-end/Images/userInputResultIcon.png: Removed.
  • inspector/front-end/Images/warningIcon.png: Removed.
  • inspector/front-end/Images/warningMediumIcon.png: Removed.
  • inspector/front-end/Images/warningOrangeDot.png: Removed.
  • inspector/front-end/Images/warningsErrors.png: Removed.
  • inspector/front-end/IndexedDBModel.js: Removed.
  • inspector/front-end/IndexedDBViews.js: Removed.
  • inspector/front-end/InspectElementModeController.js: Removed.
  • inspector/front-end/InspectorBackend.js: Removed.
  • inspector/front-end/InspectorBackendCommands.qrc: Removed.
  • inspector/front-end/InspectorFrontendAPI.js: Removed.
  • inspector/front-end/InspectorFrontendHostStub.js: Removed.
  • inspector/front-end/InspectorView.js: Removed.
  • inspector/front-end/IsolatedFileSystem.js: Removed.
  • inspector/front-end/IsolatedFileSystemManager.js: Removed.
  • inspector/front-end/JSHeapSnapshot.js: Removed.
  • inspector/front-end/JavaScriptFormatter.js: Removed.
  • inspector/front-end/JavaScriptSourceFrame.js: Removed.
  • inspector/front-end/KeyboardShortcut.js: Removed.
  • inspector/front-end/Linkifier.js: Removed.
  • inspector/front-end/LiveEditSupport.js: Removed.
  • inspector/front-end/MemoryStatistics.js: Removed.
  • inspector/front-end/MetricsSidebarPane.js: Removed.
  • inspector/front-end/NativeBreakpointsSidebarPane.js: Removed.
  • inspector/front-end/NativeHeapSnapshot.js: Removed.
  • inspector/front-end/NativeMemoryGraph.js: Removed.
  • inspector/front-end/NavigatorOverlayController.js: Removed.
  • inspector/front-end/NavigatorView.js: Removed.
  • inspector/front-end/NetworkItemView.js: Removed.
  • inspector/front-end/NetworkLog.js: Removed.
  • inspector/front-end/NetworkManager.js: Removed.
  • inspector/front-end/NetworkPanel.js: Removed.
  • inspector/front-end/NetworkPanelDescriptor.js: Removed.
  • inspector/front-end/NetworkRequest.js: Removed.
  • inspector/front-end/NetworkUISourceCodeProvider.js: Removed.
  • inspector/front-end/Object.js: Removed.
  • inspector/front-end/ObjectPopoverHelper.js: Removed.
  • inspector/front-end/ObjectPropertiesSection.js: Removed.
  • inspector/front-end/OverridesView.js: Removed.
  • inspector/front-end/OverviewGrid.js: Removed.
  • inspector/front-end/Panel.js: Removed.
  • inspector/front-end/PanelEnablerView.js: Removed.
  • inspector/front-end/ParsedURL.js: Removed.
  • inspector/front-end/Placard.js: Removed.
  • inspector/front-end/Popover.js: Removed.
  • inspector/front-end/PresentationConsoleMessageHelper.js: Removed.
  • inspector/front-end/ProfileDataGridTree.js: Removed.
  • inspector/front-end/ProfileLauncherView.js: Removed.
  • inspector/front-end/ProfilesPanel.js: Removed.
  • inspector/front-end/ProfilesPanelDescriptor.js: Removed.
  • inspector/front-end/Progress.js: Removed.
  • inspector/front-end/ProgressIndicator.js: Removed.
  • inspector/front-end/PropertiesSection.js: Removed.
  • inspector/front-end/PropertiesSidebarPane.js: Removed.
  • inspector/front-end/RawSourceCode.js: Removed.
  • inspector/front-end/RemoteObject.js: Removed.
  • inspector/front-end/RequestCookiesView.js: Removed.
  • inspector/front-end/RequestHTMLView.js: Removed.
  • inspector/front-end/RequestHeadersView.js: Removed.
  • inspector/front-end/RequestJSONView.js: Removed.
  • inspector/front-end/RequestPreviewView.js: Removed.
  • inspector/front-end/RequestResponseView.js: Removed.
  • inspector/front-end/RequestTimingView.js: Removed.
  • inspector/front-end/RequestView.js: Removed.
  • inspector/front-end/Resource.js: Removed.
  • inspector/front-end/ResourceScriptMapping.js: Removed.
  • inspector/front-end/ResourceTreeModel.js: Removed.
  • inspector/front-end/ResourceType.js: Removed.
  • inspector/front-end/ResourceUtils.js: Removed.
  • inspector/front-end/ResourceView.js: Removed.
  • inspector/front-end/ResourceWebSocketFrameView.js: Removed.
  • inspector/front-end/ResourcesPanel.js: Removed.
  • inspector/front-end/RevisionHistoryView.js: Removed.
  • inspector/front-end/RuntimeModel.js: Removed.
  • inspector/front-end/SASSSourceMapping.js: Removed.
  • inspector/front-end/ScopeChainSidebarPane.js: Removed.
  • inspector/front-end/Script.js: Removed.
  • inspector/front-end/ScriptFormatter.js: Removed.
  • inspector/front-end/ScriptFormatterWorker.js: Removed.
  • inspector/front-end/ScriptSnippetModel.js: Removed.
  • inspector/front-end/ScriptsNavigator.js: Removed.
  • inspector/front-end/ScriptsPanel.js: Removed.
  • inspector/front-end/ScriptsPanelDescriptor.js: Removed.
  • inspector/front-end/ScriptsSearchScope.js: Removed.
  • inspector/front-end/SearchController.js: Removed.
  • inspector/front-end/Section.js: Removed.
  • inspector/front-end/Settings.js: Removed.
  • inspector/front-end/SettingsScreen.js: Removed.
  • inspector/front-end/ShortcutsScreen.js: Removed.
  • inspector/front-end/ShowMoreDataGridNode.js: Removed.
  • inspector/front-end/SidebarOverlay.js: Removed.
  • inspector/front-end/SidebarPane.js: Removed.
  • inspector/front-end/SidebarTreeElement.js: Removed.
  • inspector/front-end/SidebarView.js: Removed.
  • inspector/front-end/SimpleWorkspaceProvider.js: Removed.
  • inspector/front-end/SnippetJavaScriptSourceFrame.js: Removed.
  • inspector/front-end/SnippetStorage.js: Removed.
  • inspector/front-end/SoftContextMenu.js: Removed.
  • inspector/front-end/SourceCSSTokenizer.js: Removed.
  • inspector/front-end/SourceCSSTokenizer.re2js: Removed.
  • inspector/front-end/SourceFrame.js: Removed.
  • inspector/front-end/SourceHTMLTokenizer.js: Removed.
  • inspector/front-end/SourceHTMLTokenizer.re2js: Removed.
  • inspector/front-end/SourceJavaScriptTokenizer.js: Removed.
  • inspector/front-end/SourceJavaScriptTokenizer.re2js: Removed.
  • inspector/front-end/SourceMap.js: Removed.
  • inspector/front-end/SourceMapping.js: Removed.
  • inspector/front-end/SourceTokenizer.js: Removed.
  • inspector/front-end/Spectrum.js: Removed.
  • inspector/front-end/SplitView.js: Removed.
  • inspector/front-end/StatusBarButton.js: Removed.
  • inspector/front-end/StyleSheetOutlineDialog.js: Removed.
  • inspector/front-end/StylesSidebarPane.js: Removed.
  • inspector/front-end/StylesSourceMapping.js: Removed.
  • inspector/front-end/SuggestBox.js: Removed.
  • inspector/front-end/TabbedEditorContainer.js: Removed.
  • inspector/front-end/TabbedPane.js: Removed.
  • inspector/front-end/TestController.js: Removed.
  • inspector/front-end/TextEditor.js: Removed.
  • inspector/front-end/TextEditorHighlighter.js: Removed.
  • inspector/front-end/TextEditorModel.js: Removed.
  • inspector/front-end/TextPrompt.js: Removed.
  • inspector/front-end/TextUtils.js: Removed.
  • inspector/front-end/TimelineFrameController.js: Removed.
  • inspector/front-end/TimelineGrid.js: Removed.
  • inspector/front-end/TimelineManager.js: Removed.
  • inspector/front-end/TimelineModel.js: Removed.
  • inspector/front-end/TimelineOverviewPane.js: Removed.
  • inspector/front-end/TimelinePanel.js: Removed.
  • inspector/front-end/TimelinePanelDescriptor.js: Removed.
  • inspector/front-end/TimelinePresentationModel.js: Removed.
  • inspector/front-end/Toolbar.js: Removed.
  • inspector/front-end/TopDownProfileDataGridTree.js: Removed.
  • inspector/front-end/UISourceCode.js: Removed.
  • inspector/front-end/UISourceCodeFrame.js: Removed.
  • inspector/front-end/UIString.js: Removed.
  • inspector/front-end/UIUtils.js: Removed.
  • inspector/front-end/UglifyJS/parse-js.js: Removed.
  • inspector/front-end/UserAgentSupport.js: Removed.
  • inspector/front-end/UserMetrics.js: Removed.
  • inspector/front-end/View.js: Removed.
  • inspector/front-end/ViewportControl.js: Removed.
  • inspector/front-end/WatchExpressionsSidebarPane.js: Removed.
  • inspector/front-end/WebKit.qrc: Removed.
  • inspector/front-end/WorkerManager.js: Removed.
  • inspector/front-end/WorkersSidebarPane.js: Removed.
  • inspector/front-end/Workspace.js: Removed.
  • inspector/front-end/ace/LICENSE.txt: Removed.
  • inspector/front-end/ace/ace.js: Removed.
  • inspector/front-end/ace/acedevtools.css: Removed.
  • inspector/front-end/ace/mode_css.js: Removed.
  • inspector/front-end/ace/mode_html.js: Removed.
  • inspector/front-end/ace/mode_javascript.js: Removed.
  • inspector/front-end/ace/theme_textmate.js: Removed.
  • inspector/front-end/auditsPanel.css: Removed.
  • inspector/front-end/breadcrumbList.css: Removed.
  • inspector/front-end/breakpointsList.css: Removed.
  • inspector/front-end/buildSystemOnly.js: Removed.
  • inspector/front-end/canvasProfiler.css: Removed.
  • inspector/front-end/cm/LICENSE: Removed.
  • inspector/front-end/cm/closebrackets.js: Removed.
  • inspector/front-end/cm/cmdevtools.css: Removed.
  • inspector/front-end/cm/codemirror.css: Removed.
  • inspector/front-end/cm/codemirror.js: Removed.
  • inspector/front-end/cm/css.js: Removed.
  • inspector/front-end/cm/htmlmixed.js: Removed.
  • inspector/front-end/cm/javascript.js: Removed.
  • inspector/front-end/cm/matchbrackets.js: Removed.
  • inspector/front-end/cm/xml.js: Removed.
  • inspector/front-end/cssNamedFlows.css: Removed.
  • inspector/front-end/dataGrid.css: Removed.
  • inspector/front-end/dialog.css: Removed.
  • inspector/front-end/elementsPanel.css: Removed.
  • inspector/front-end/externs.js: Removed.
  • inspector/front-end/filteredItemSelectionDialog.css: Removed.
  • inspector/front-end/flameChart.css: Removed.
  • inspector/front-end/heapProfiler.css: Removed.
  • inspector/front-end/helpScreen.css: Removed.
  • inspector/front-end/indexedDBViews.css: Removed.
  • inspector/front-end/inspector.css: Removed.
  • inspector/front-end/inspector.html: Removed.
  • inspector/front-end/inspector.js: Removed.
  • inspector/front-end/inspectorCommon.css: Removed.
  • inspector/front-end/inspectorSyntaxHighlight.css: Removed.
  • inspector/front-end/jsdifflib.js: Removed.
  • inspector/front-end/navigatorView.css: Removed.
  • inspector/front-end/networkLogView.css: Removed.
  • inspector/front-end/networkPanel.css: Removed.
  • inspector/front-end/panelEnablerView.css: Removed.
  • inspector/front-end/popover.css: Removed.
  • inspector/front-end/profilesPanel.css: Removed.
  • inspector/front-end/resourceView.css: Removed.
  • inspector/front-end/resourcesPanel.css: Removed.
  • inspector/front-end/revisionHistory.css: Removed.
  • inspector/front-end/scriptsPanel.css: Removed.
  • inspector/front-end/sidebarPane.css: Removed.
  • inspector/front-end/spectrum.css: Removed.
  • inspector/front-end/splitView.css: Removed.
  • inspector/front-end/tabbedPane.css: Removed.
  • inspector/front-end/test-runner.html: Removed.
  • inspector/front-end/textEditor.css: Removed.
  • inspector/front-end/textPrompt.css: Removed.
  • inspector/front-end/timelinePanel.css: Removed.
  • inspector/front-end/treeoutline.js: Removed.
  • inspector/front-end/utilities.js: Removed.
5:07 PM Changeset in webkit [157277] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add failing expectations to some tests on Mac Lion.

  • platform/mac-lion/TestExpectations:
5:05 PM Changeset in webkit [157276] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/win

Fix build.

  • Interfaces/WebKit.idl:

Oops, didn't mean to remove the uuid for WebURLResponse.

5:05 PM Changeset in webkit [157275] by commit-queue@webkit.org
  • 7 edits
    2 deletes in trunk

Web Inspector: Remove the old front-end from WebKit
https://bugs.webkit.org/show_bug.cgi?id=122295

Patch by Marcelo Morais <m.morais@samsung.com> on 2013-10-10
Reviewed by Timothy Hatcher.

.:

  • Source/PlatformGTK.cmake: Removed. This file was using files from the

old inspector, not needed anymore.

Source/WebCore:

Updating the project files to remove all references from the old
inspector front-end.

  • WebCore.vcxproj/WebCore.vcxproj: Removed the references for the old

inspector front-end.

  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • inspector/compile-front-end.py: Removed.

Source/WebKit:

  • PlatformBlackBerry.cmake: Removed the references for the old

inspector front-end.

5:01 PM Changeset in webkit [157274] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix with ENABLE_DEVICE_ORIENTATION after r157215

Now, impl() return reference instead of a pointer.

  • bindings/js/JSDeviceMotionEventCustom.cpp:

(WebCore::JSDeviceMotionEvent::acceleration):
(WebCore::JSDeviceMotionEvent::accelerationIncludingGravity):
(WebCore::JSDeviceMotionEvent::rotationRate):
(WebCore::JSDeviceMotionEvent::interval):
(WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):

  • bindings/js/JSDeviceOrientationEventCustom.cpp:

(WebCore::JSDeviceOrientationEvent::alpha):
(WebCore::JSDeviceOrientationEvent::beta):
(WebCore::JSDeviceOrientationEvent::gamma):
(WebCore::JSDeviceOrientationEvent::absolute):
(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):

4:56 PM Changeset in webkit [157273] by commit-queue@webkit.org
  • 10 edits
    1 add in trunk

[MediaStream API] update MediaStream object to match spec
https://bugs.webkit.org/show_bug.cgi?id=121939

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-10
Reviewed by Jer Noble.

Source/WebCore:

Test: fast/mediastream/MediaStream-clone.html

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::ended):
(WebCore::MediaStream::clone):
(WebCore::MediaStream::cloneMediaStreamTrackVector):
(WebCore::MediaStream::contextDestroyed):
(WebCore::MediaStream::scheduledEventTimerFired):

  • Modules/mediastream/MediaStream.h:
  • Modules/mediastream/MediaStream.idl:

LayoutTests:

  • TestExpectations:
  • fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
  • fast/mediastream/MediaStream-add-remove-tracks.html:
  • fast/mediastream/MediaStream-clone.html: Added.
  • fast/mediastream/MediaStreamConstructor-expected.txt:
  • fast/mediastream/MediaStreamConstructor.html:
4:51 PM Changeset in webkit [157272] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Calling setUsePresentationValue on MountainLion results in unrecognized selector
warnings
https://bugs.webkit.org/show_bug.cgi?id=122624

Reviewed by Tim Horton.

Only call setUsePresentationValue if the scrollbar supports updates on a secondary
thread.

  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):

4:34 PM Changeset in webkit [157271] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Validate uniform input when setting texture sampler uniforms.
https://bugs.webkit.org/show_bug.cgi?id=122610.

Reviewed by Dean Jackson.

Covered by Khronos Conformance Suite 1.0.2.
Specifically, conformance/uniforms/uniform-samplers-test.html.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::uniform1i):
(WebCore::WebGLRenderingContext::uniform1iv):

4:31 PM Changeset in webkit [157270] by Seokju Kwon
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r157250

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

4:20 PM Changeset in webkit [157269] by commit-queue@webkit.org
  • 22 edits in trunk/Source/WebInspectorUI

Web Inspector: content views and managers should save/restore view state.
https://bugs.webkit.org/show_bug.cgi?id=122546

To restore the same content view and sidebars when re-opening the
inspector, a cookie is saved whenever a new content view is shown
in the main content browser. Previously, this cookie was created
and restored using navigation sidebar-specific logic. This has two
major flaws: non-default sidebars for a represented object are not
restored correctly; and it centralizes storage of view-specific
state such as subview selections.

This patch adds ContentView methods for saving a key for the
view's represented object, and saving/restoring any view-specific
state as the view is shown. The 'type' field of the cookie
specifies the manager which deserializes the cookie into a
represented object.

Patch by Brian J. Burg <Brian Burg> on 2013-10-10
Reviewed by Timothy Hatcher.

  • UserInterface/ApplicationCacheFrameContentView.js:

(WebInspector.ApplicationCacheFrameContentView):
(WebInspector.ApplicationCacheFrameContentView.prototype.saveToCookie):
(WebInspector.ApplicationCacheFrameContentView.prototype._maybeUpdate):
(WebInspector.ApplicationCacheFrameContentView.prototype._updateStatus):
(WebInspector.ApplicationCacheFrameContentView.prototype.updateStatus):
(WebInspector.ApplicationCacheFrameContentView.prototype._updateCallback):

  • UserInterface/ApplicationCacheManager.js:

(WebInspector.ApplicationCacheManager.prototype.networkStateUpdated):
(WebInspector.ApplicationCacheManager.prototype.applicationCacheStatusUpdated):
(WebInspector.ApplicationCacheManager.prototype.):
(WebInspector.ApplicationCacheManager.prototype.requestApplicationCache):
(WebInspector.ApplicationCacheManager.prototype.objectForCookie):
(WebInspector.ApplicationCacheManager.prototype._manifestForFrameLoaded):
(WebInspector.ApplicationCacheManager.prototype._framesWithManifestsLoaded):
(WebInspector.ApplicationCacheManager.prototype._frameManifestUpdated):

  • UserInterface/BackForwardEntry.js:

(WebInspector.BackForwardEntry):
(WebInspector.BackForwardEntry.prototype._restoreFromCookie):

  • UserInterface/ContentBrowser.js:

(WebInspector.ContentBrowser.prototype.showContentViewForRepresentedObject):
(WebInspector.ContentBrowser.prototype.showContentView):

  • UserInterface/ContentView.js:

(WebInspector.ContentView.prototype.saveToCookie):
(WebInspector.ContentView.prototype.restoreFromCookie):

  • UserInterface/ContentViewContainer.js:

(WebInspector.ContentViewContainer.prototype.showContentView):

  • UserInterface/CookieStorageContentView.js:

(WebInspector.CookieStorageContentView.prototype.update):
(WebInspector.CookieStorageContentView.prototype.saveToCookie):
(WebInspector.CookieStorageContentView.prototype._rebuildTable):
(WebInspector.CookieStorageContentView.prototype._filterCookies):

  • UserInterface/DOMStorageContentView.js:

(WebInspector.DOMStorageContentView.prototype.saveToCookie):

  • UserInterface/DatabaseContentView.js:

(WebInspector.DatabaseContentView.prototype.saveToCookie):
(WebInspector.DatabaseContentView.prototype._messagesClicked):

  • UserInterface/DatabaseTableContentView.js:

(WebInspector.DatabaseTableContentView):
(WebInspector.DatabaseTableContentView.prototype.saveToCookie):

  • UserInterface/FrameContentView.js:

(WebInspector.FrameContentView.prototype.saveToCookie):
(WebInspector.FrameContentView.prototype.restoreFromCookie):

  • UserInterface/FrameResourceManager.js:

(WebInspector.FrameResourceManager.prototype.objectForCookie):

  • UserInterface/InstrumentSidebarPanel.js:

(WebInspector.InstrumentSidebarPanel):
(WebInspector.InstrumentSidebarPanel.prototype.showTimeline):
(WebInspector.InstrumentSidebarPanel.prototype.shown):
(WebInspector.InstrumentSidebarPanel.prototype._timelinesTreeElementSelected):

  • UserInterface/Main.js:

(WebInspector.loaded):
(WebInspector.contentLoaded):
(WebInspector.openURL):
(WebInspector._updateCurrentContentViewCookie):
(WebInspector._showContentViewForCookie.lastAttemptToRestoreFromCookie):
(WebInspector._showContentViewForCookie):
(WebInspector._resolveAndShowPendingContentViewCookie.delayedWork):
(WebInspector._resolveAndShowPendingContentViewCookie):
(WebInspector.elementDragStart):
(WebInspector.elementDragEnd):
(WebInspector.createMessageTextView):
(WebInspector.linkifyStringAsFragment):

  • UserInterface/NavigationSidebarPanel.js:
  • UserInterface/ResourceClusterContentView.js:

(WebInspector.ResourceClusterContentView.prototype.saveToCookie):
(WebInspector.ResourceClusterContentView.prototype.restoreFromCookie):

  • UserInterface/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype.showSourceCode):
(WebInspector.ResourceSidebarPanel.prototype._mainFrameDidChange):
(WebInspector.ResourceSidebarPanel.prototype._domStorageObjectWasAdded):
(WebInspector.ResourceSidebarPanel.prototype._databaseWasAdded):
(WebInspector.ResourceSidebarPanel.prototype._cookieStorageObjectWasAdded):
(WebInspector.ResourceSidebarPanel.prototype._frameManifestAdded):

  • UserInterface/ScriptContentView.js:

(WebInspector.ScriptContentView.prototype.saveToCookie):
(WebInspector.ScriptContentView.prototype.restoreFromCookie):

  • UserInterface/StorageManager.js:

(WebInspector.StorageManager.prototype.findMatchingObjectInArray):
(WebInspector.StorageManager.prototype.objectForCookie):

  • UserInterface/TimelineManager.js:

(WebInspector.TimelineManager):
(WebInspector.TimelineManager.prototype.get timelines):
(WebInspector.TimelineManager.prototype.objectForCookie):

  • UserInterface/TimelinesContentView.js:

(WebInspector.TimelinesContentView.prototype.saveToCookie):
(WebInspector.TimelinesContentView.prototype.restoreFromCookie):
(WebInspector.TimelinesContentView.prototype._makeColumnScopeBar):

4:17 PM Changeset in webkit [157268] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk

Create MediaStream object with ended attribute set if all tracks that are being used on its creation are ended
https://bugs.webkit.org/show_bug.cgi?id=122358

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-10
Reviewed by Jer Noble.

Source/WebCore:

Spec tells that if all tracks that belongs to a new MediaStream object being created are ended,
then the ended attribute of this MediaStream must be set to true.
http://www.w3.org/TR/mediacapture-streams/#widl-MediaStream-ended

Since there is no port supporting MediaStream yet, we are skipping this test for now.

Test: fast/mediastream/MediaStream-construct-with-ended-tracks.html

  • Modules/mediastream/MediaStream.cpp:

(WebCore::createFromSourceVectors):
(WebCore::MediaStream::create):

  • Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):

  • platform/mediastream/MediaStreamDescriptor.cpp:

(WebCore::MediaStreamDescriptor::create):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):

  • platform/mediastream/MediaStreamDescriptor.h:
  • platform/mock/MockMediaStreamCenter.cpp:

(WebCore::MockMediaStreamCenter::createMediaStream):

LayoutTests:

Since there is no port supporting MediaStream yet, we are skipping this test for now.

  • TestExpectations:
  • fast/mediastream/MediaStream-construct-with-ended-tracks.html: Added.
4:16 PM Changeset in webkit [157267] by oliver@apple.com
  • 13 edits in trunk

Further improve ArrayIterator performance
https://bugs.webkit.org/show_bug.cgi?id=122575

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

Add an assembly thunk for ArrayIterator.@@next so that we
can avoid marshalling costs when iterating arrays.

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::loadSpecificClassArgument):

  • jit/ThunkGenerators.cpp:

(JSC::arrayIteratorNextThunkGenerator):

  • jit/ThunkGenerators.h:
  • runtime/ArrayIteratorPrototype.cpp:

(JSC::ArrayIteratorPrototype::finishCreation):

  • runtime/Intrinsic.h:
  • runtime/JSArrayIterator.h:

(JSC::JSArrayIterator::offsetOfIterationKind):
(JSC::JSArrayIterator::offsetOfIteratedObject):
(JSC::JSArrayIterator::offsetOfNextIndex):

  • runtime/JSCJSValue.h:

(JSC::JSValue::offsetOfPayload):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::iteratorResultStructureOffset):

  • runtime/VM.cpp:

(JSC::thunkGeneratorForIntrinsic):

LayoutTests:

Add a few new tests to make sure the new asm thunk correctly
handles non-arrays.

  • js/array-iterators-expected.txt:
  • js/script-tests/array-iterators.js:
4:10 PM Changeset in webkit [157266] by msaboff@apple.com
  • 17 edits in trunk

transition cti_op_* methods returning int to JIT operations.
https://bugs.webkit.org/show_bug.cgi?id=122563

Reviewed by Oliver Hunt.

Moved serveral operationCompare* functions from DFGOperations to JITOperations as well as changing
dfgConvertJSValueToBoolean to operationConvertJSValueToBoolean so that they can be shared with the baseline JIT.
Added JITOperation operationHasProperty(). Added needed callOperation helpers and transitioned baseline JIT code
to use the new operations.

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):

  • jit/JIT.h:
  • jit/JITArithmetic.cpp:

(JSC::JIT::emitSlow_op_jless):
(JSC::JIT::emitSlow_op_jlesseq):
(JSC::JIT::emitSlow_op_jgreater):
(JSC::JIT::emitSlow_op_jgreatereq):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emitSlow_op_jngreater):
(JSC::JIT::emitSlow_op_jngreatereq):
(JSC::JIT::emit_compareAndJumpSlow):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_compareAndJumpSlow):

  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_next_pname):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emit_op_next_pname):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
4:05 PM Changeset in webkit [157265] by aestes@apple.com
  • 16 edits
    2 adds in trunk

Add SPI for telling WebKit to prefer pictograph glyphs over monochrome ones
https://bugs.webkit.org/show_bug.cgi?id=122608

Reviewed by Dan Bernstein.

Based on patches by Dan Bernstein.

Source/WebCore:

Test: fonts/font-fallback-prefers-pictographs.html

Created a mechanism to append a font to the end of a font's fallback
list, before the system fallback list. This mechanism is used when
Settings::fontFallbackPrefersPictographs() is true to insert a
pictograph font ahead of a monochrome one from the system fallback list.

  • WebCore.exp.in: Moved

ZN7WebCore8Settings33setFontFallbackPrefersPictographsEb outside of
an iOS platform guard.

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::fallbackFontDataCount): Retuned 1 if
pictograph fonts are preferred.
(WebCore::CSSFontSelector::getFallbackFontData): Returned the
pictograph font's FontData if it is preferred.

  • css/CSSFontSelector.h:
  • page/Settings.cpp:

(WebCore::Settings::Settings): Initialized
m_fontFallbackPrefersPictographs to false.
(WebCore::Settings::setFontFallbackPrefersPictographs): Set
m_fontFallbackPrefersPictographs and called
Page::setNeedsRecalcStyleInAllFrames().

  • page/Settings.h:

(WebCore::Settings::fontFallbackPrefersPictographs):

  • platform/graphics/FontGlyphs.cpp:

(WebCore::FontGlyphs::realizeFontDataAt): Realized the selector's
fallback font if necessary.

  • platform/graphics/FontSelector.h:
  • style/StyleResolveTree.cpp:

(WebCore::Style::resolveTree): Removed iOS platform guards.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setFontFallbackPrefersPictographs): Set the
corresponding WebCore::Setting.

  • testing/InternalSettings.h: Defined an internal setting for the test.
  • testing/InternalSettings.idl: Ditto.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _setFontFallbackPrefersPictographs:]): Called
WebCore::Settings::setFontFallbackPrefersPictographs().

  • WebView/WebViewPrivate.h:

LayoutTests:

  • fonts/font-fallback-prefers-pictographs-expected.html: Added.
  • fonts/font-fallback-prefers-pictographs.html: Added.
3:57 PM Changeset in webkit [157264] by fpizlo@apple.com
  • 24 edits
    2 adds in trunk/Source/JavaScriptCore

OSR exit using llvm.webkit.stackmap should pass more tests
https://bugs.webkit.org/show_bug.cgi?id=122518

Reviewed by Mark Hahnenberg.

  • Make the X86Assembler capable of dealing with all XMM registers.


  • Make the StackMaps code on WebKit's side capable of dealing with XMM registers.


  • Factor out most of the smarts of StackMaps::Location into a self-contained object. Previously you needed both StackMaps::Location and a StackMaps reference to do most things since the Location might have referred to a constant. Now you can just get a self-contained Location object.


  • Fix a bug where OSR exit generation thunk generator was assuming that the call frame register is already in argumentGPR0. In the future, the call frame will just be the machine FP and we won't have to do anything special. But for now the "call frame" is just a normal value in LLVM IR and may end up in any register. Make the OSR exit generation thunk generator polymorphic over the call frame argument's Location.


  • Move the stuff that depends on the polymorphic OSR exit generation thunk generator into the finalizer, since generating and linking one of those thunks requires a cache flush and we need to do that on the main thread.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::firstRegister):
(JSC::ARMv7Assembler::lastRegister):
(JSC::ARMv7Assembler::firstFPRegister):
(JSC::ARMv7Assembler::lastFPRegister):

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::firstFPRegister):
(JSC::AbstractMacroAssembler::lastFPRegister):

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::nextFPRegister):

  • assembler/MacroAssemblerARMv7.h:
  • assembler/MacroAssemblerX86Common.h:
  • assembler/X86Assembler.h:

(JSC::X86Assembler::firstFPRegister):
(JSC::X86Assembler::lastFPRegister):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

  • ftl/FTLCompile.cpp:

(JSC::FTL::fixFunctionBasedOnStackMaps):

  • ftl/FTLExitThunkGenerator.cpp:

(JSC::FTL::ExitThunkGenerator::emitThunk):
(JSC::FTL::ExitThunkGenerator::emitThunks):

  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeFunction):

  • ftl/FTLJITFinalizer.h:
  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • ftl/FTLLocation.cpp: Added.

(JSC::FTL::Location::forStackmaps):
(JSC::FTL::Location::dump):
(JSC::FTL::Location::involvesGPR):
(JSC::FTL::Location::isGPR):
(JSC::FTL::Location::gpr):
(JSC::FTL::Location::isFPR):
(JSC::FTL::Location::fpr):
(JSC::FTL::Location::restoreInto):
(WTF::printInternal):

  • ftl/FTLLocation.h: Added.

(JSC::FTL::Location::Location):
(JSC::FTL::Location::forRegister):
(JSC::FTL::Location::forIndirect):
(JSC::FTL::Location::forConstant):
(JSC::FTL::Location::kind):
(JSC::FTL::Location::hasDwarfRegNum):
(JSC::FTL::Location::dwarfRegNum):
(JSC::FTL::Location::hasOffset):
(JSC::FTL::Location::offset):
(JSC::FTL::Location::hasConstant):
(JSC::FTL::Location::constant):
(JSC::FTL::Location::operator!):
(JSC::FTL::Location::isHashTableDeletedValue):
(JSC::FTL::Location::operator==):
(JSC::FTL::Location::hash):
(JSC::FTL::LocationHash::hash):
(JSC::FTL::LocationHash::equal):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::linkOSRExitsAndCompleteInitializationBlocks):

  • ftl/FTLSaveRestore.cpp:

(JSC::FTL::bytesForFPRs):
(JSC::FTL::requiredScratchMemorySizeInBytes):
(JSC::FTL::offsetOfFPR):
(JSC::FTL::saveAllRegisters):
(JSC::FTL::restoreAllRegisters):

  • ftl/FTLSaveRestore.h:
  • ftl/FTLStackMaps.cpp:

(JSC::FTL::StackMaps::Location::restoreInto):

  • ftl/FTLStackMaps.h:
  • ftl/FTLState.h:
  • ftl/FTLThunks.cpp:

(JSC::FTL::osrExitGenerationWithoutStackMapThunkGenerator):
(JSC::FTL::osrExitGenerationWithStackMapThunkGenerator):

  • ftl/FTLThunks.h:

(JSC::FTL::generateIfNecessary):
(JSC::FTL::Thunks::getOSRExitGenerationThunk):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
3:56 PM Changeset in webkit [157263] by andersca@apple.com
  • 9 edits
    4 deletes in trunk/Source/WebKit

Remove WebScrollBar
https://bugs.webkit.org/show_bug.cgi?id=122623

Reviewed by Brent Fulgham.

Source/WebKit:

Remove files from VS projects.

  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj:
  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters:
  • WebKit.vcxproj/WebKit/WebKit.vcxproj:
  • WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:

Source/WebKit/win:

WebScrollBar isn't used by anyone, remove it.

  • ForEachCoClass.h:
  • Interfaces/IWebScrollBarDelegatePrivate.idl: Removed.
  • Interfaces/IWebScrollBarPrivate.idl: Removed.
  • Interfaces/WebKit.idl:
  • WebKitClassFactory.cpp:

(WebKitClassFactory::CreateInstance):

  • WebScrollBar.cpp: Removed.
  • WebScrollBar.h: Removed.
3:39 PM Changeset in webkit [157262] by fpizlo@apple.com
  • 5 edits in trunk

Tools: Make sure that DataTypes.h is in the binary drop.

Rubber stamped by Michael Saboff.

  • Scripts/export-llvm-build:

WebKitLibraries: Update the binary drops to the latest version of LLVM, built without -fvisibility=hidden
now that we have soft linking. Also include DataTypes.h in the drop.

Rubber stamped by Michael Saboff.

  • LLVMIncludesMountainLion.tar.bz2:
  • LLVMLibrariesMountainLion.tar.bz2:
3:27 PM Changeset in webkit [157261] by Beth Dakin
  • 2 edits in trunk/Source/WebKit/win

Build fix after http://trac.webkit.org/changeset/157253

  • WebScrollBar.h:
3:19 PM Changeset in webkit [157260] by fpizlo@apple.com
  • 24 edits
    16 adds
    2 deletes in trunk

FTL: Soft-link LLVM as a workaround for LLVM's static initializers and exit-time destructors
https://bugs.webkit.org/show_bug.cgi?id=122566

Source/JavaScriptCore:

Reviewed by Mark Rowe.

The JSC project now builds a libllvmForJSC.dylib. If FTL is enabled, this
gets copied into JavaScriptCore.framework/Versions/A/Libraries. JSC will
load the dylib by finding it using NSBundle APIs and then doing dlopen().
That will only happen lazily, when something happens that requires LLVM.

This mostly takes care of LLVM static initialization overhead by deferring
it until it's really needed.

This takes care of LLVM's exit-time destructors because inside
libllvmForJSC.dylib, we override cxa_atexit.

  • Configurations/JavaScriptCore.xcconfig:
  • Configurations/LLVMForJSC.xcconfig: Added.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • disassembler/LLVMDisassembler.cpp:

(JSC::tryToDisassembleWithLLVM):

  • ftl/FTLAbbreviatedTypes.h:
  • ftl/FTLAbbreviations.h:

(JSC::FTL::voidType):
(JSC::FTL::int1Type):
(JSC::FTL::int8Type):
(JSC::FTL::int16Type):
(JSC::FTL::int32Type):
(JSC::FTL::int64Type):
(JSC::FTL::intPtrType):
(JSC::FTL::floatType):
(JSC::FTL::doubleType):
(JSC::FTL::pointerType):
(JSC::FTL::structType):
(JSC::FTL::functionType):
(JSC::FTL::typeOf):
(JSC::FTL::mdKindID):
(JSC::FTL::mdString):
(JSC::FTL::mdNode):
(JSC::FTL::setMetadata):
(JSC::FTL::addFunction):
(JSC::FTL::setLinkage):
(JSC::FTL::setFunctionCallingConv):
(JSC::FTL::getParam):
(JSC::FTL::constInt):
(JSC::FTL::constReal):
(JSC::FTL::constIntToPtr):
(JSC::FTL::constBitCast):
(JSC::FTL::appendBasicBlock):
(JSC::FTL::insertBasicBlock):
(JSC::FTL::buildPhi):
(JSC::FTL::addIncoming):
(JSC::FTL::buildAlloca):
(JSC::FTL::buildAdd):
(JSC::FTL::buildSub):
(JSC::FTL::buildMul):
(JSC::FTL::buildDiv):
(JSC::FTL::buildRem):
(JSC::FTL::buildNeg):
(JSC::FTL::buildFAdd):
(JSC::FTL::buildFSub):
(JSC::FTL::buildFMul):
(JSC::FTL::buildFDiv):
(JSC::FTL::buildFRem):
(JSC::FTL::buildFNeg):
(JSC::FTL::buildAnd):
(JSC::FTL::buildOr):
(JSC::FTL::buildXor):
(JSC::FTL::buildShl):
(JSC::FTL::buildAShr):
(JSC::FTL::buildLShr):
(JSC::FTL::buildNot):
(JSC::FTL::buildLoad):
(JSC::FTL::buildStore):
(JSC::FTL::buildSExt):
(JSC::FTL::buildZExt):
(JSC::FTL::buildFPToSI):
(JSC::FTL::buildFPToUI):
(JSC::FTL::buildSIToFP):
(JSC::FTL::buildUIToFP):
(JSC::FTL::buildIntCast):
(JSC::FTL::buildFPCast):
(JSC::FTL::buildIntToPtr):
(JSC::FTL::buildPtrToInt):
(JSC::FTL::buildBitCast):
(JSC::FTL::buildICmp):
(JSC::FTL::buildFCmp):
(JSC::FTL::buildCall):
(JSC::FTL::setTailCall):
(JSC::FTL::buildExtractValue):
(JSC::FTL::buildSelect):
(JSC::FTL::buildBr):
(JSC::FTL::buildCondBr):
(JSC::FTL::buildSwitch):
(JSC::FTL::addCase):
(JSC::FTL::buildRet):
(JSC::FTL::buildUnreachable):
(JSC::FTL::dumpModule):
(JSC::FTL::verifyModule):

  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

  • ftl/FTLFail.cpp:

(JSC::FTL::fail):

  • ftl/FTLJITCode.h:
  • ftl/FTLJITFinalizer.h:
  • ftl/FTLLink.cpp:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lower):

  • ftl/FTLOutput.cpp:

(JSC::FTL::Output::Output):
(JSC::FTL::Output::~Output):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::appendTo):

  • ftl/FTLState.cpp:

(JSC::FTL::State::State):
(JSC::FTL::State::~State):

  • ftl/WebKitLLVMLibraryAnchor.cpp: Removed.
  • jsc.cpp:

(jscmain):

  • llvm: Added.
  • llvm/InitializeLLVM.cpp: Added.

(JSC::initializeLLVM):

  • llvm/InitializeLLVM.h: Added.
  • llvm/InitializeLLVMMac.mm: Added.

(JSC::initializeLLVMImpl):

  • llvm/InitializeLLVMPOSIX.cpp: Added.

(JSC::initializeLLVMPOSIX):

  • llvm/InitializeLLVMPOSIX.h: Added.
  • llvm/LLVMAPI.cpp: Added.
  • llvm/LLVMAPI.h: Added.
  • llvm/LLVMAPIFunctions.h: Added.
  • llvm/LLVMHeaders.h: Added.
  • llvm/library: Added.
  • llvm/library/LLVMAnchor.cpp: Added.
  • llvm/library/LLVMExports.cpp: Added.

(initializeAndGetJSCLLVMAPI):

  • llvm/library/LLVMOverrides.cpp: Added.

(cxa_atexit):

  • llvm/library/config_llvm.h: Added.
  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/Options.h:

Source/WTF:

Reviewed by Mark Rowe.

Remove all LLVM stuff from WTF since to get LLVM you need to soft-link and it's
entirely the responsibility of JSC to do that.

Also fixed an export goof that I found after fixing the weak thingy script in JSC.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/LLVMHeaders.h: Removed.
  • wtf/text/CString.h:

(WTF::CStringHash::hash):

Tools:

Reviewed by Mark Rowe.

  • Scripts/configure-llvm:
3:16 PM Changeset in webkit [157259] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Add timeout annotation to gtk-wk2-specific expectation for
editing/spelling/spellcheck-paste.html.

  • platform/gtk-wk2/TestExpectations:
3:03 PM Changeset in webkit [157258] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

currentThis and currentArguments crash if called from outside a callback
https://bugs.webkit.org/show_bug.cgi?id=122620

Reviewed by Filip Pizlo.

The documentation for these methods claims that they will return nil if called
from somewhere other than an API callback, but currently they both crash.

  • API/JSContext.mm:

(+[JSContext currentThis]):
(+[JSContext currentArguments]):

  • API/tests/testapi.mm:
3:00 PM Changeset in webkit [157257] by fpizlo@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fix changelog entry order.

2:59 PM Changeset in webkit [157256] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

CallbackData unnecessarily caches the JSValue for currentThis
https://bugs.webkit.org/show_bug.cgi?id=122616

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2013-10-10
Reviewed by Oliver Hunt.

CallbackData implements its own version of caching the JSValue* for the JSValueRef it stores.
+[JSValue valueWithJSValueRef:inContext:] already does caching, thus obviating the need for
CallbackData to do its own caching.

  • API/JSContext.mm:

(+[JSContext currentThis]):
(-[JSContext beginCallbackWithData:thisValue:argumentCount:arguments:]):
(-[JSContext endCallbackWithData:]):

  • API/JSContextInternal.h:
2:50 PM Changeset in webkit [157255] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unused attribute in CoordinatedTile class
https://bugs.webkit.org/show_bug.cgi?id=122619

Patch by Sergio Correia <Sergio Correia> on 2013-10-10
Reviewed by Noam Rosenthal.

No new tests, covered by existing ones.

  • platform/graphics/texmap/coordinated/CoordinatedTile.h: Remove

m_localBuffer.

2:47 PM Changeset in webkit [157254] by Csaba Osztrogonác
  • 5 edits
    5 adds in trunk/Source/WebKit2

[WK2][Soup] Add platform specific stubs for NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=110115

Reviewed by Carlos Garcia Campos.

Original patch by Balazs Kelemen <kbalazs@webkit.org> and Kwang Yul Seo <skyul@company100.net>.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • NetworkProcess/gtk/NetworkProcessSoup.cpp: Added.

(WebKit::NetworkProcess::platformInitializeNetworkProcess):
(WebKit::NetworkProcess::platformSetCacheModel):
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
Stubs.
(WebKit::NetworkProcess::clearCacheForAllOrigins):
(WebKit::NetworkProcess::platformTerminate):

  • NetworkProcess/soup/NetworkResourceLoadSchedulerSoup.cpp: Added.

(WebKit::NetworkResourceLoadScheduler::platformInitializeMaximumHTTPConnectionCountPerHost):
Added platform default based on the comment in ResourceRequestSoup.cpp.

  • UIProcess/Network/soup/NetworkProcessProxySoup.cpp: Added.

(WebKit::NetworkProcessProxy::platformGetLaunchOptions):
Stub.

  • UIProcess/soup/WebContextSoup.cpp: Added.

(WebKit::WebContext::platformInitializeNetworkProcess):
Stub.

2:44 PM Changeset in webkit [157253] by Beth Dakin
  • 28 edits in trunk/Source

Scrollbars are updated on the main thread rather than the scrolling thread
(causing scroll bars not to appear/update quickly in some cases)
https://bugs.webkit.org/show_bug.cgi?id=122585
-and corresponding-
<rdar://problem/10710775>

Reviewed by Simon Fraser.

Source/WebCore:

This patch does a few things in order to allow scrollbars to be updated on the
scrolling thread:

  1. This patch adds the ability to know if the lower-level APIs necessary to get

this to work right are available, AND if the content is actually capable of taking
advantage of this feature. This is currently implemented as
Scrollbar::supportsUpdateOnSecondaryThread() which makes use of a new
ScrollableArea function called updatesScrollLayerPositionOnMainThread()

  1. To update on the scrolling thread, the scrolling tree needs to know about the

ScrollbarPainters.

  1. Once it knows about them, it should update the presentation value whenever the

layer position changes.

  1. Presentation value is basically the same thing as double value. There is a bit

of code we maintain currently to compute that. This patch moves that code to a
static function on ScrollableArea that can be called from both the main thread and
the scrolling thread.

  1. ScrollbarPainter API needs to know about the layers we have created for the

vertical and horizontal scrollbars, then they will use those layers and the
presentation value that we set on the scrolling thread to move the layers around.

This is part of #1 above.

  • page/FrameView.cpp:

(WebCore::FrameView::updatesScrollLayerPositionOnMainThread):

  • page/FrameView.h:

This is part of #2. ScrollingStateScrollingNodes now have vertical and horizontal
ScrollbarPainters for Mac only.

  • page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):

  • page/scrolling/ScrollingStateScrollingNode.h:

(WebCore::ScrollingStateScrollingNode::verticalScrollbarPainter):
(WebCore::ScrollingStateScrollingNode::horizontalScrollbarPainter):

Also part of #2. Make sure to set the ScrollbarPainters for scrolling nodes when
appropriate.

  • page/scrolling/mac/ScrollingCoordinatorMac.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated):

Implement this function that was just stubbed out before. This is part of #5 in
that is will allow the ScrollbarPainter API to know about any layer changes.
(WebCore::ScrollingCoordinatorMac::scrollableAreaScrollbarLayerDidChange):

Back to #2, making sure we properly set the ScrollbarPainters to send over to the
scrolling thread.
(WebCore::ScrollingCoordinatorMac::setScrollbarPaintersForNode):

  • page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:

(WebCore::ScrollingStateScrollingNode::setScrollbarPainters):

This code achieves #3. It uses new ScrollbarPainter API to adjust the position of
the scrollbars from the scrolling thread.

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::ScrollingTreeScrollingNodeMac):
(WebCore::ScrollingTreeScrollingNodeMac::updateBeforeChildren):
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):

This is for #5. ScrollbarPainter needs to know about our scrollbar layers.

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::verticalScrollbarLayerDidChange):
(WebCore::ScrollAnimator::horizontalScrollbarLayerDidChange):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::verticalScrollbarLayerDidChange):
(WebCore::ScrollableArea::horizontalScrollbarLayerDidChange):

This is for #4. This code computes the scrollbar’s value and current overhang
amount.
(WebCore::ScrollableArea::computeScrollbarValueAndOverhang):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::layerForHorizontalScrollbar):
(WebCore::ScrollableArea::layerForVerticalScrollbar):
(WebCore::ScrollableArea::layerForScrolling):

This is for #1. We need to know if we have the ability to update scrollbars on a
different thread. We can do that only on certain versions of the OS, only when
threaded scrolling is enabled, and only when the current page is actually using
the scrolling thread to scroll.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::supportsUpdateOnSecondaryThread):

  • platform/Scrollbar.h:
  • platform/ScrollbarThemeClient.h:

New ScrollbarPainter APIs.

  • platform/mac/NSScrollerImpDetails.h:

This is for #5, letting the ScrollbarPainter API know about the layers.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate layer]):
(-[WebScrollbarPainterDelegate convertRectToLayer:]):
(-[WebScrollbarPainterDelegate shouldUseLayerPerPartForScrollerImp:]):

Before we kick off a scroll animation, set the current painting characteristics so
they are up-to-date in case we are scrolling on the scrolling thread.
(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::verticalScrollbarLayerDidChange):
(WebCore::ScrollAnimatorMac::horizontalScrollbarLayerDidChange):

Only paint the scrollbars through ScrollbarThemeMac if they are NOT being updated
by the scrolling thread.

  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::setCurrentPaintCharacteristics):
(WebCore::scrollbarPainterPaint):
(WebCore::ScrollbarThemeMac::paint):

Back to #1.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updatesScrollLayerPositionOnMainThread):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):

  • rendering/RenderListBox.h:

Source/WebKit2:

New pure virtual function.

  • WebProcess/Plugins/PDF/PDFPlugin.h:
2:34 PM Changeset in webkit [157252] by Brent Fulgham
  • 6 edits in trunk/Source/WebCore

[Win] Unreviewed build fix after r157228

The changes in r157228 trigger a bug in VS2010. This patch works around the compiler bug
to allow this platform to build.

  • dom/Range.cpp: Move implementation to header file.
  • dom/Range.h: Inline the method.
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::open): Add stub method (with pointer arguments) to call the real
method with references.

  • page/DOMWindow.h: Declare stub method taking pointer arguments to avoid compiler bug.
  • testing/Internals.cpp:

(WebCore::Internals::openDummyInspectorFrontend): Use work-around method when building under
the buggy version of Visual Studio.

2:34 PM Changeset in webkit [157251] by Csaba Osztrogonác
  • 4 edits
    1 move
    2 adds in trunk/Source/WebKit2

[WK2] Port RemoteNetworkingContext for Soup
https://bugs.webkit.org/show_bug.cgi?id=110097

Reviewed by Darin Adler.

Original patch by Balazs Kelemen <kbalazs@webkit.org> and Kwang Yul Seo <skyul@company100.net>.

This should be a cross-platform interface so I lifted the header from
the mac directory. Removed mac specific arguments from constructor,
added setters instead. Moved platform things behind ifdefs and added
Soup specific bits.

The following things were fixed by Csaba Osztrogonác:

  • solved conflicts in project.pbxproj
  • removed the change in the non-existent SyncNetworkResourceLoader.cpp
  • marked RemoteNetworkingContext class as FINAL
  • reordered the members for platform specific initialization
  • added initializers to m_needsSiteSpecificQuirks and m_localFileContentSniffingEnabled members on PLATFORM(MAC)
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::start):

  • NetworkProcess/RemoteNetworkingContext.h: Renamed from Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.h.

(WebKit::RemoteNetworkingContext::create):
(WebKit::RemoteNetworkingContext::RemoteNetworkingContext):
(WebKit::RemoteNetworkingContext::setNeedsSiteSpecificQuirks):
(WebKit::RemoteNetworkingContext::setLocalFileContentSniffingEnabled):

  • NetworkProcess/mac/RemoteNetworkingContext.mm:
  • NetworkProcess/soup/RemoteNetworkingContextSoup.cpp: Added.

(WebKit::RemoteNetworkingContext::~RemoteNetworkingContext):
(WebKit::RemoteNetworkingContext::isValid):
(WebKit::RemoteNetworkingContext::initiatingPageID):
(WebKit::RemoteNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::RemoteNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::RemoteNetworkingContext::storageSession):
(WebKit::RemoteNetworkingContext::privateBrowsingSession):

  • WebKit2.xcodeproj/project.pbxproj:
2:11 PM Changeset in webkit [157250] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Make all functions of EventDispatcher static
https://bugs.webkit.org/show_bug.cgi?id=122591

Reviewed by Antti Koivisto.

Now that EventDispatchMediator is gone, we don't have to have an EventDispatcher object.
Turn EventDispatcher into an empty class with a bunch of static functions.

We can convert it to a namespace or whatever later.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchSimulatedClick):
(WebCore::EventDispatcher::dispatchEvent):

  • dom/EventDispatcher.h:
1:50 PM Changeset in webkit [157249] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

CallbackData unnecessarily caches the JSValue for currentThis
https://bugs.webkit.org/show_bug.cgi?id=122616

Reviewed by Oliver Hunt.

CallbackData implements its own version of caching the JSValue* for the JSValueRef it stores.
+[JSValue valueWithJSValueRef:inContext:] already does caching, thus obviating the need for
CallbackData to do its own caching.

  • API/JSContext.mm:

(+[JSContext currentThis]):
(-[JSContext beginCallbackWithData:thisValue:argumentCount:arguments:]):
(-[JSContext endCallbackWithData:]):

  • API/JSContextInternal.h:
1:42 PM Changeset in webkit [157248] by commit-queue@webkit.org
  • 14 edits in trunk/Source

Convert some OwnPtr/PassOwnPtr in CoordinatedGraphics code to std::unique_ptr's
https://bugs.webkit.org/show_bug.cgi?id=122614

Patch by Sergio Correia <Sergio Correia> on 2013-10-10
Reviewed by Anders Carlsson.

Source/WebCore:

No new tests, covered by existing ones.

  • platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:

(WebCore::CompositingCoordinator::paintToSurface):
(WebCore::CompositingCoordinator::releaseInactiveAtlasesTimerFired):

  • platform/graphics/texmap/coordinated/CompositingCoordinator.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::adjustContentsScale):
(WebCore::CoordinatedGraphicsLayer::createBackingStore):
(WebCore::CoordinatedGraphicsLayer::updateContentBuffers):
(WebCore::CoordinatedGraphicsLayer::purgeBackingStores):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::createLayer):
(WebCore::CoordinatedGraphicsScene::deleteLayer):
(WebCore::CoordinatedGraphicsScene::ensureRootLayer):
(WebCore::CoordinatedGraphicsScene::purgeGLResources):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
  • platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp:

(WebCore::ThreadSafeCoordinatedSurface::ThreadSafeCoordinatedSurface):

  • platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.h:
  • platform/graphics/texmap/coordinated/UpdateAtlas.cpp:

(WebCore::UpdateAtlas::buildLayoutIfNeeded):
(WebCore::UpdateAtlas::didSwapBuffers):

  • platform/graphics/texmap/coordinated/UpdateAtlas.h:

(WebCore::UpdateAtlas::isInUse):

Source/WebKit2:

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
1:15 PM Changeset in webkit [157247] by roger_fong@apple.com
  • 4 edits in trunk/Source/WebCore

Store uniform type information in WebGLUniformationLocation.
https://bugs.webkit.org/show_bug.cgi?id=122607.

Reviewed by Dean Jackson.

Covered by Khronos Conformance Suite 1.0.2.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getUniform):
(WebCore::WebGLRenderingContext::getUniformLocation):

  • html/canvas/WebGLUniformLocation.cpp:

(WebCore::WebGLUniformLocation::create):
(WebCore::WebGLUniformLocation::WebGLUniformLocation):
(WebCore::WebGLUniformLocation::type):

  • html/canvas/WebGLUniformLocation.h:
1:05 PM Changeset in webkit [157246] by commit-queue@webkit.org
  • 14 edits in trunk/LayoutTests

Web Inspector: Remove the old front-end from WebKit
https://bugs.webkit.org/show_bug.cgi?id=122295

Patch by Marcelo Morais <m.morais@samsung.com> on 2013-10-10
Reviewed by Timothy Hatcher.

Skipping the tests of the old Inspector UI for all ports.

  • TestExpectations:
  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk-wk1/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac-lion/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win-xp/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:
1:05 PM Changeset in webkit [157245] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r157203): WebKit crashes after dispatching gesture event
https://bugs.webkit.org/show_bug.cgi?id=122615

Reviewed by Anders Carlsson.

Don't release the event until the end of the function where we call member functions on it.

  • dom/Node.cpp:

(WebCore::Node::dispatchGestureEvent):

1:04 PM Changeset in webkit [157244] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, roll out r157193. It broke some builds.

1:02 PM Changeset in webkit [157243] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

generate-message-receiver.py can't handle nested #ifs
https://bugs.webkit.org/show_bug.cgi?id=121877

Reviewed by Alexey Proskuryakov.

  • Scripts/webkit2/parser.py:

(parse): Exit early until proper fix instead of generating buggy output.

12:49 PM Changeset in webkit [157242] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

Move the rest of EventRetargeter functions to EventPath
https://bugs.webkit.org/show_bug.cgi?id=122586

Reviewed by Andreas Kling.

Moved the rest of EventRetargeter functiosn either static local or EventPath member functions.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchScopedEvent):
(WebCore::EventDispatcher::dispatch):
(WebCore::EventDispatcher::dispatchEventPostProcess):

  • dom/EventDispatcher.h:
  • dom/EventRetargeter.cpp:

(WebCore::EventPath::EventPath):
(WebCore::calculateAdjustedNodes): Made static local. Also takes const EventPath and returns the size
to which EventPath should be shrunk; this allows us to remove EventPath::shrink.
(WebCore::updateTouchListsInEventPath): Moved and renamed from EventRetargeter::adjustTouchList.
(WebCore::EventPath::updateTouchLists): Moved and renamed from EventRetargeter::adjustForTouchEvent.
(WebCore::EventPath::setRelatedTarget): Moved.

  • dom/EventRetargeter.h:

(WebCore::eventTargetRespectingTargetRules): Renamed from EventRetargeter::eventTargetRespectingTargetRules.

12:48 PM Changeset in webkit [157241] by mrowe@apple.com
  • 33 edits in trunk

<rdar://problem/13341666> WebKit should always build against an SDK.

Have all projects default to building against the OS X Internal SDK for the Production
configuration. For the Debug and Release configurations, look for UseInternalSDK.xcconfig
to determine whether the OS X Internal SDK should be used. If not, use the normal OS X SDK.

Reviewed by Dan Bernstein.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:

Source/ThirdParty:

  • gtest/xcode/Config/General.xcconfig:
  • gtest/xcode/Config/ProductionProject.xcconfig:

Source/ThirdParty/ANGLE:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:

Source/WebCore:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:

Source/WebInspectorUI:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:

Source/WTF:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
  • MiniBrowser/Configurations/Base.xcconfig:
  • MiniBrowser/Configurations/DebugRelease.xcconfig:
  • TestWebKitAPI/Configurations/Base.xcconfig:
  • TestWebKitAPI/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:
12:43 PM Changeset in webkit [157240] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[CoordinatedGraphics][CSS Shaders] marshal color and matrix custom filter parameters
https://bugs.webkit.org/show_bug.cgi?id=117904

Correctly encode and decode the "matrix" and "color" custom filter parameter types.
No port currently enables this code, however with this change the relevant layout tests now pass when enabled in EFL.
Patch by Ralph Thomas <ralpht@gmail.com> on 2013-10-10
Reviewed by Noam Rosenthal.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

12:25 PM Changeset in webkit [157239] by mrowe@apple.com
  • 4 edits in trunk/Source

Source/JavaScriptCore: <rdar://problem/13871507> JavaScriptCore fails to build with C++ 98 conformance changes

Reviewed by Andreas Kling.

  • heap/VTableSpectrum.cpp:

(JSC::VTableSpectrum::dump): strrchr returns a const char* when passed one.
Update the type of the local variable to accommodate that.

Source/WebKit2: <rdar://problem/13871522> WebKit2 fails to build with C++ 98 conformance changes

Reviewed by Andreas Kling.

  • Shared/mac/SandboxExtensionMac.mm:

(WebKit::resolveSymlinksInPath): strrchr returns a const char* when passed one.
Update the type of the local variable to accommodate that.

12:22 PM Changeset in webkit [157238] by hmuller@adobe.com
  • 4 edits in trunk/Source

[CSS Shapes] clampToUnsigned() should return unsigned, not int
https://bugs.webkit.org/show_bug.cgi?id=122601

Source/WebCore:

Reviewed by Andreas Kling.

Corrected the return type for clampToUnsigned() in MathExtras.h. It's now unsigned.
No new tests since this is just an internal refactoring of existing code.

  • rendering/shapes/RasterShape.cpp:

(WebCore::RasterShape::marginIntervals): Use the redefined clampToUnsigned method.

Source/WTF:

Corrected the return type for clampToUnsigned() in MathExtras.h. It's now unsigned.

Reviewed by Andreas Kling.

  • wtf/MathExtras.h:

(clampToUnsigned):

11:24 AM Changeset in webkit [157237] by berto@igalia.com
  • 4 edits in trunk/LayoutTests

Unreviewed gardening.

Move the tests that only fail in wk1 to their file, and unskip the
ones that are passing in all cases.

  • platform/gtk-wk1/TestExpectations:
  • platform/gtk-wk2/TestExpectations:
  • platform/gtk/TestExpectations:
11:22 AM Changeset in webkit [157236] by Bem Jones-Bey
  • 13 edits
    7 copies
    1 add in trunk

[CSS Shapes] New positioning model: Shape cropped to margin box
https://bugs.webkit.org/show_bug.cgi?id=118092

Reviewed by Alexandru Chiculita.

Source/WebCore:

Clip the shape to the margin box when it extends out the left or right
edges. Also added a few local variables to make the code easier to
read.

Tests: csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-ref.html

csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-004.html
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-005.html
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-006.html

  • rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):

LayoutTests:

Add tests for shapes that extend out left/right of the margin box.

Fix polygon and image threshold tests so that they have a large enough
margin box so the shape isn't clipped.

Also update some of the top/bottom tests to have a better reference,
they should be more likely to break if the implementation fails now.

  • csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-ref-expected.html: Copied from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-ref.html: Copied from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-004-expected.html: Copied from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-004.html: Copied from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-005-expected.html: Copied from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-005.html: Copied from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-006-expected.html: Copied from LayoutTests/csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-expected.html.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-006.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
  • fast/shapes/shape-outside-floats/shape-outside-floats-image-threshold-001.html:
11:20 AM Changeset in webkit [157235] by dbates@webkit.org
  • 6 edits in trunk/Source/WebCore

Avoid resizing the internal buffer of SharedBuffer when creating a PurgeableBuffer
https://bugs.webkit.org/show_bug.cgi?id=122516

Reviewed by Darin Adler.

Currently when we create a PurgeableBuffer from a SharedBuffer we may
resize the internal buffer of the SharedBuffer so that it can fit the
concatenated contents of all of its segments before copying this
internal buffer to the internal buffer of the PurgeableBuffer. Instead,
we can avoid resizing the internal buffer of SharedBuffer by allocating
a PurgeableBuffer and then copying the internal buffer of SharedBuffer
and its segments directly into it.

  • platform/PurgeableBuffer.h:

(WebCore::PurgeableBuffer::createUninitialized): Add inline implementation
when building with ENABLE_PURGEABLE_MEMORY disabled.

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::createPurgeableBuffer): Implemented in terms of
SharedBuffer::{copyBufferAndClear, createUninitialized}().
(WebCore::SharedBuffer::copyBufferAndClear): Added.
(WebCore::SharedBuffer::buffer): Moved logic to copy segments/data array to
SharedBuffer::copyBufferAndClear() and modified this function to use it.

  • platform/SharedBuffer.h:
  • platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::copyBufferAndClear): Renamed; formerly called SharedBuffer::copyDataArrayAndClear.

  • platform/mac/PurgeableBufferMac.cpp:

(WebCore::allocatePurgeableBuffer): Added.
(WebCore::PurgeableBuffer::createUninitialized): Added.
(WebCore::PurgeableBuffer::create): Moved logic to allocate a purgeable buffer into
PurgeableBuffer::createUninitialized() and modified this function to use it.

11:20 AM Changeset in webkit [157234] by mhahnenberg@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Objective-C API: blocks aren't callable via 'new'
https://bugs.webkit.org/show_bug.cgi?id=122561

Reviewed by Oliver Hunt.

Currently the only way for clients to vend new native objects to JavaScript code
is via factory methods in the form of exported class methods or blocks. Blocks can
be called like normal functions from JavaScript code, but they cannot be invoked
with 'new'. This would give a simple way for clients to expose constructor-like
behavior to their JavaScript code.

This patch adds the ability for blocks to be invoked as if they were a constructor.
Blocks invoked as constructors are required to return an object. If the block doesn't
return an object then an error is thrown. The 'this' object is not provided to the
block and must be created within the block itself.

This patch also unifies the native 'construct' callback used in both the C and Obj-C
APIs under the APICallbackFunction struct, similar to how we unified the 'call' callback
between ObjCCallbackFunction and JSCallbackFunction before.

This patch also adds tests to make sure that different blocks generate objects that
correctly behave when queried with instanceof. It also makes sure that the correct
JS exception is thrown when a block fails to return an object.

  • API/APICallbackFunction.h:

(JSC::APICallbackFunction::call):
(JSC::APICallbackFunction::construct):

  • API/JSCallbackConstructor.cpp:

(JSC::JSCallbackConstructor::getConstructData):

  • API/JSCallbackConstructor.h:

(JSC::JSCallbackConstructor::constructCallback):

  • API/JSCallbackFunction.h:

(JSC::JSCallbackFunction::functionCallback):

  • API/ObjCCallbackFunction.h:

(JSC::ObjCCallbackFunction::functionCallback):
(JSC::ObjCCallbackFunction::constructCallback):

  • API/ObjCCallbackFunction.mm:

(JSC::objCCallbackFunctionCallAsConstructor):
(JSC::ObjCCallbackFunction::ObjCCallbackFunction):
(JSC::ObjCCallbackFunction::create):
(JSC::ObjCCallbackFunction::getConstructData):

  • API/tests/testapi.mm:
11:14 AM Changeset in webkit [157233] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. plugins/document-open.html will some times timeout.

  • platform/gtk-wk2/TestExpectations:
10:54 AM Changeset in webkit [157232] by kov@webkit.org
  • 2 edits in trunk/Tools

Unreviewed gardening, the inspector protocol timeouts are also affecting TestInspectorServer.

  • Scripts/run-gtk-tests:

(TestRunner): skip TestInspectorServer.

10:41 AM Changeset in webkit [157231] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: VoiceOver speaking too much when group elements with tabindex=-1 are used
https://bugs.webkit.org/show_bug.cgi?id=122574

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Tests: accessibility/negative-tabindex-does-not-expose-label.html

Elements that expose tabindex=-1 are being identified as generic focusable elements for accessibility.
Which among other things, determines whether to create an accessible name for the object.
This has the negative effect of causing VoiceOver to speak way too much information when navigating inside
a <div> with this attribute.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::title):

LayoutTests:

  • accessibility/negative-tabindex-does-not-expose-label-expected.txt: Added.
  • accessibility/negative-tabindex-does-not-expose-label.html: Added.
10:39 AM Changeset in webkit [157230] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Remove custom finalizer for Node JS wrappers.
<https://webkit.org/b/122603>

Reviewed by Geoff Garen.

Node can just use the auto-generated finalizer, the custom one was
identical to what the generator would output.

9:38 AM Changeset in webkit [157229] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Remove duplicate entry for editing/spelling/spellcheck-paste.html.

  • platform/gtk/TestExpectations:
9:31 AM Changeset in webkit [157228] by akling@apple.com
  • 11 edits in trunk/Source/WebCore

CTTE: activeDOMWindow() and firstDOMWindow() should return references.
<https://webkit.org/b/122598>

Reviewed by Anders Carlsson.

Now that wrappers vend references to their WebCore objects, follow
up and make these two return references as well.

9:19 AM Changeset in webkit [157227] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[ATK] Missing checks in returnIfWebKitAccessibleIsInvalid
https://bugs.webkit.org/show_bug.cgi?id=122600

Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-10-10
Reviewed by Chris Fleizach.

Check that the AccessibilityObject associated to the ATK wrapper
is not NULL and contains a valid reference to the document before
calling AccessibilityObject::updateBackingStore().

  • accessibility/atk/WebKitAccessibleUtil.h: Add extra checks.
8:43 AM Changeset in webkit [157226] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

Clean up JSDOMWindowShell a little.
<https://webkit.org/b/122599>

Reviewed by Anders Carlsson.

  • Have impl() return a DOMWindow& instead of a pointer.
  • Store the DOMWrapperWorld in a Ref instead of a RefPtr.
  • Reuse TRY_TO_UNWRAP_WITH_INTERFACE in EventTarget bindings.
8:35 AM Changeset in webkit [157225] by Csaba Osztrogonác
  • 12 edits in trunk/Source/WebKit2

Buildfix for non Mac platforms with enabled NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=121793

Reviewed by Anders Carlsson.

  • Shared/ShareableResource.cpp:
  • Shared/ShareableResource.h:
  • Shared/WebResourceBuffer.cpp:
  • Shared/WebResourceBuffer.h:
  • WebKit2Prefix.h:
  • WebProcess/Network/NetworkProcessConnection.cpp:
  • WebProcess/Network/NetworkProcessConnection.h:
  • WebProcess/Network/NetworkProcessConnection.messages.in:
  • WebProcess/Network/WebResourceLoader.cpp:
  • WebProcess/Network/WebResourceLoader.h:
  • WebProcess/Network/WebResourceLoader.messages.in:
8:01 AM Changeset in webkit [157224] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Make XPathGrammar.y bison3-friendly again after r157205
https://bugs.webkit.org/show_bug.cgi?id=122595

Patch by Sergio Correia <Sergio Correia> on 2013-10-10
Reviewed by Anders Carlsson.

No new tests, build fix.

  • xml/XPathGrammar.y: Replace YYLEX_PARAM with %lex-param, as the

former was removed in bison3.

7:51 AM Changeset in webkit [157223] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

SVGUseElement: Use iterative traversal to find disallowed elements.
<https://webkit.org/b/122596>

Reviewed by Antti Koivisto.

Rewrote subtreeContainsDisallowedElement() in SVGUseElement.cpp to
use iterative traversal with descendantsOfType<Element> instead of
recursing through the tree.

6:55 AM Changeset in webkit [157222] by akling@apple.com
  • 14 edits in trunk/Source/WebCore

Move RenderObject::layout() to RenderElement.
<https://webkit.org/b/122537>

Reviewed by Antti Koivisto.

RenderText will ASSERT_NOT_REACHED() in its layout(), so move this
to RenderElement. This allows us to use the fast firstChild()
instead of virtual dispatch.

The needsLayout() bit remains on RenderObject for now. Moving that
to RenderElement is a far more involved change.

6:42 AM Changeset in webkit [157221] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: Crash at WebCore::accessibleNameForNode when visiting Facebook
https://bugs.webkit.org/show_bug.cgi?id=122572

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Test: accessibility/aria-labeled-with-hidden-node.html

Handle the case where aria-labelledby references a non-rendered node.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::accessibleNameForNode):

LayoutTests:

  • accessibility/aria-labeled-with-hidden-node-expected.txt: Added.
  • accessibility/aria-labeled-with-hidden-node.html: Added.
6:39 AM Changeset in webkit [157220] by berto@igalia.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

dom/xhtml/level2/html/HTMLInputElement20.xhtml no longer crashes.

  • platform/gtk/TestExpectations:
6:29 AM Changeset in webkit [157219] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r157210): Crashes in WebCore::ScopedEventQueue::dispatchEvent for platforms using GCC
https://bugs.webkit.org/show_bug.cgi?id=122592

Reviewed by Gustavo Noronha Silva.

  • dom/ScopedEventQueue.cpp:

(WebCore::ScopedEventQueue::dispatchEvent): When calling EventDispatcher::dispatchEvent(), the GCC-compiled code
first creates a copy of the PassRefPtr<Event> object that's being passed into the method call. The copy will be used
in that method while the original is left with a null pointer. Only after that is the original queried for its pointer
while trying to get the Event's target, resulting in a crash due to calling the Event::target() on a null pointer.
To avoid it, pass a naked Event pointer to the method call. This will create a new PassRefPtr object without nullifying
the original one.

6:19 AM Changeset in webkit [157218] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Tools

[GTK] Provide search functionality to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=117631

Patch by Andres Gomez <Andres Gomez> on 2013-10-10
Reviewed by Carlos Garcia Campos.

Adds a search bar to MiniBrowser with the minimum functionality
and a new button to the toolbar for showing the new search
bar. Typical keyboard shortcuts are also added.

  • MiniBrowser/gtk/BrowserSearchBar.c: Added.

(doSearch):
(searchNext):
(searchPrevious):
(searchCloseButtonClickedCallback):
(searchEntryMenuIconPressedCallback):
(searchEntryClearIconReleasedCallback):
(searchEntryChangedCallback):
(searchEntryActivatedCallback):
(searchPrevButtonClickedCallback):
(searchNextButtonClickedCallback):
(searchMenuCheckButtonToggledCallback):
(browser_search_bar_init):
(browserSearchBarFinalize):
(browser_search_bar_class_init):
(browser_search_bar_new):
(browser_search_bar_add_accelerators):
(browser_search_bar_open):
(browser_search_bar_close):

  • MiniBrowser/gtk/BrowserSearchBar.h: Added.
  • MiniBrowser/gtk/BrowserWindow.c:

(webViewEnterFullScreen): Closes new search bar.
(webViewLeaveFullScreen): Opens new search bar if previously
visible.
(searchCallback): Added. Shows and hides the new search bar.
(browser_window_init): Added search button to the toolbar.
(browserWindowConstructed): Creates the new search bar.

  • MiniBrowser/gtk/GNUmakefile.am: Added new files to compilation.
5:27 AM Changeset in webkit [157217] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Webkit - Updated Tamil translation
https://bugs.webkit.org/show_bug.cgi?id=120520

Patch by Shantha kumar <shkumar@redhat.com> on 2013-10-10
Reviewed by Gustavo Noronha Silva.

  • ta.po: updated.
5:19 AM Changeset in webkit [157216] by akling@apple.com
  • 13 edits in trunk/Source/WebCore

Use more Element iterators in SVG code.
<http://webkit.org/b/121127>

Reviewed by Antti Koivisto.

Use childrenOfType to iterate over only SVGElement (or even more
specific) children in a bunch of places.

Also auto-generate type helpers for SVGElement and SVGStopElement.

5:01 AM Changeset in webkit [157215] by akling@apple.com
  • 141 edits in trunk/Source

JS DOM wrappers' impl() functions should return references.
<https://webkit.org/b/122497>

Reviewed by Antti Koivisto.

JS DOM wrappers always have a corresponding WebCore object during
their lifetime, so make impl() return a reference.

4:17 AM Changeset in webkit [157214] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix debug build after r157210
https://bugs.webkit.org/show_bug.cgi?id=122593

Patch by Sergio Correia <Sergio Correia> on 2013-10-10
Reviewed by Andreas Kling.

No new tests, build fix.

  • dom/EventContext.cpp:

(WebCore::TouchEventContext::handleLocalEvents): Fix ASSERT, now that
event is a reference instead of a pointer.

4:16 AM Changeset in webkit [157213] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Tighten some renderer access in Document.
<https://webkit.org/b/121865>

Reviewed by Antti Koivisto.

A bit of Node/Element and RenderObject/RenderElement tightening.

3:49 AM Changeset in webkit [157212] by akling@apple.com
  • 10 edits in trunk/Source

rangeOfContents() should take a Node&.
<https://webkit.org/b/122438>

Reviewed by Darin Adler.

All callers of rangeOfContents() either have a Node& already,
or do some kind of null-checking before calling it.

1:38 AM Changeset in webkit [157211] by svillar@igalia.com
  • 19 edits
    5 adds in trunk

[CSS Grid Layout] Implement support for grid-template
https://bugs.webkit.org/show_bug.cgi?id=103313

Reviewed by Dean Jackson.

Source/WebCore:

Based on Blink r153427, r155199 and r155712 by <jchaffraix@chromium.org>

Test: fast/css-grid-layout/grid-template-get-set.html

Recognize, parse, store and return properly the value of
grid-template. It required some extra parsing code because the
specs mandates to check that the defined grid areas are indeed
rectangular. Named grid areas are still not fully supported, will
be done in a follow up patch.

As validating involves building the grid areas a new CSSValue was
added to hold the computed value. Note that we have to track the
explicit size of the named grid areas as the named grid areas
(".") are not tracked in our HashMap of grid areas.

This change also involves moving GridCoordinate and GridSpan to a
separate file in order to share the code that describes the grid
area coordinates.

  • CMakeLists.txt: Added new files to the build.
  • GNUmakefile.list.am: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSGridTemplateValue.cpp: Added.

(WebCore::CSSGridTemplateValue::CSSGridTemplateValue):
(WebCore::stringForPosition):
(WebCore::CSSGridTemplateValue::customCSSText):

  • css/CSSGridTemplateValue.h: Added.

(WebCore::CSSGridTemplateValue::create):
(WebCore::CSSGridTemplateValue::~CSSGridTemplateValue):
(WebCore::CSSGridTemplateValue::gridAreaMap):
(WebCore::CSSGridTemplateValue::rowCount):
(WebCore::CSSGridTemplateValue::columnCount):
(WebCore::toCSSGridTemplateValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridTemplate): create the grid areas and
validate that they define rectangular sections.

  • css/CSSParser.h:
  • css/CSSPropertyNames.in: Added -webkit-grid-template.
  • css/CSSValue.cpp:

(WebCore::CSSValue::equals): add support for the new CSSGridTemplateValue.
(WebCore::CSSValue::cssText): Ditto.
(WebCore::CSSValue::destroy): Ditto.

  • css/CSSValue.h:

(WebCore::CSSValue::isGridTemplateValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::cachedGridCoordinate): Replaced RenderGrid::GridSpan by WebCore::GridSpan.
(WebCore::RenderGrid::resolveGridPositionsFromAutoPlacementPosition): Ditto.
(WebCore::RenderGrid::resolveGridPositionsFromStyle): Ditto.
(WebCore::RenderGrid::resolveGridPositionAgainstOppositePosition): Ditto.
(WebCore::RenderGrid::resolveNamedGridLinePositionAgainstOppositePosition): Ditto.
(WebCore::RenderGrid::resolveRowStartColumnStartNamedGridLinePositionAgainstOppositePosition): Ditto.
(WebCore::RenderGrid::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition): Ditto.

  • rendering/RenderGrid.h: Took GridSpan and GridCoordinate out.
  • rendering/style/GridCoordinate.h: Added.

(WebCore::GridSpan::create):
(WebCore::GridSpan::GridSpan):
(WebCore::GridSpan::operator==):
(WebCore::GridCoordinate::GridCoordinate):
(WebCore::GridCoordinate::operator==):
(WebCore::GridCoordinate::operator!=):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleGridData.cpp:

(WebCore::StyleGridData::StyleGridData):

  • rendering/style/StyleGridData.h:

(WebCore::StyleGridData::operator==):

LayoutTests:

From Blink r153427, r155199 and r155712 by <jchaffraix@chromium.org>

Added a test to verify that we properly recognize, parse, store
and return the value of grid-template.

  • fast/css-grid-layout/grid-template-get-set-expected.txt: Added.
  • fast/css-grid-layout/grid-template-get-set.html: Added.
1:19 AM Changeset in webkit [157210] by rniwa@webkit.org
  • 14 edits in trunk/Source/WebCore

Make EventDispatcher::dispatch comprehensible
https://bugs.webkit.org/show_bug.cgi?id=122588

Reviewed by Andreas Kling.

Merged EventDispatcher::dispatchEventAtCapturing, EventDispatcher::dispatchEventAtTarget,
EventDispatcher::dispatchEventAtBubbling, and EventDispatcher::dispatchEventPostProcess into EventDispatcher::dispatch,
and extracted static local callDefaultEventHandlersInTheBubblingOrder and dispatchEventInDOM out of it.

Also made handleLocalEvents of subclasses of EventContext and Node take Event& instead of Event*.

  • dom/EventContext.cpp: The following functions now take Event& instead of Event*.

(WebCore::EventContext::handleLocalEvents):
(WebCore::MouseOrFocusEventContext::handleLocalEvents):
(WebCore::TouchEventContext::handleLocalEvents):

  • dom/EventContext.h:
  • dom/EventDispatcher.cpp:

(WebCore::callDefaultEventHandlersInTheBubblingOrder): Extracted from EventDispatcher::dispatchEventPostProcess,
which is now merged into EventDispatcher::dispatch.
(WebCore::dispatchEventInDOM): Extracted out of EventDispatcher::dispatch, EventDispatcher::dispatchEventAtCapturing,
EventDispatcher::dispatchEventAtTarget and EventDispatcher::dispatchEventAtBubbling. This function is responsible for
dispatching the event for capturing, at the target, and then bubbling through the event path chain.
(WebCore::EventDispatcher::dispatch): EventDispatcher::dispatchEventPostProcess got merged into this. The calls to
dispatchEventAtCapturing, dispatchEventAtTarget, and dispatchEventAtBubbling are replaced by a single call to
dispatchEventInDOM.

  • dom/EventDispatcher.h:
  • dom/FocusEvent.h:

(WebCore::toFocusEvent): Added the version that takes a reference.

  • dom/MouseEvent.h:

(WebCore::toMouseEvent): Ditto.

  • dom/TouchEvent.h:

(WebCore::toTouchEvent): Ditto.

  • dom/Node.cpp:

(WebCore::Node::handleLocalEvents): Now takes Event& instead of Event*.

  • dom/Node.h:
  • dom/WindowEventContext.cpp:

(WebCore::WindowEventContext::handleLocalEvents): Ditto.

  • dom/WindowEventContext.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::handleLocalEvents): Ditto.

  • html/HTMLFormElement.h:
1:16 AM HaikuWebkit created by pulkomandy@gmail.com
1:03 AM WikiStart edited by pulkomandy@gmail.com
(diff)

Oct 9, 2013:

9:24 PM Changeset in webkit [157209] by fpizlo@apple.com
  • 27 edits
    4 adds in trunk/Source/JavaScriptCore

FTL should be able to do simple OSR exits using llvm.webkit.stackmap
https://bugs.webkit.org/show_bug.cgi?id=122538

Reviewed by Oliver Hunt.

This gives the FTL the ability to OSR exit using the llvm.webkit.stackmap intrinsic.

  • The FTL compiles all OSR exit calls as calls to llvm.webkit.stackmap with a unique ID, passing a requested size that is big enough for own jump replacement.


  • After LLVM compilation, we parse the new LLVM stackmap section.


  • For all llvm.webkit.stackmaps that we used for OSR exits, we do a jumpReplacement, which targets exit thunks that we generate.


  • If an exit thunk fires, it causes JSC to compile an exit off-ramp that uses a combination of the JSC-internal OSR exit accounting (FTL::ExitValue and friends) and LLVM stackmap's accounting of where data actually ended up (register, indirect, constant) to reconstruct bytecode state.


This still has shortcomings; for example it cannot handle XMM or YMM registers. Handling
YMM registers will require adding some basic YMM support to our assemblers - really we
just need the ability to move a YMM's value into a GPR.

This patch preserves all of the old, intrinsic-less, FTL OSR exit support. Hence it
manages to pass all existing FTL tests even despite its incompleteness. I think that's
the right way to go since this is already a big patch, and anyway it would be great to
keep the intrinsic-less FTL OSR exit support so long as the LLVM side of this hasn't
landed.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::firstRegister):
(JSC::AbstractMacroAssembler::lastRegister):

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::isStackRelated):
(JSC::MacroAssembler::firstRealRegister):
(JSC::MacroAssembler::nextRegister):
(JSC::MacroAssembler::secondRealRegister):

  • assembler/MacroAssemblerX86Common.h:
  • assembler/X86Assembler.h:

(JSC::X86Assembler::firstRegister):
(JSC::X86Assembler::lastRegister):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • ftl/FTLCArgumentGetter.cpp:

(JSC::FTL::CArgumentGetter::loadNextAndBox):

  • ftl/FTLCArgumentGetter.h:

(JSC::FTL::CArgumentGetter::loadNextDoubleIntoGPR):

  • ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateCodeSection):
(JSC::FTL::mmAllocateDataSection):
(JSC::FTL::dumpDataSection):
(JSC::FTL::fixFunctionBasedOnStackMaps):
(JSC::FTL::compile):

  • ftl/FTLExitThunkGenerator.cpp:

(JSC::FTL::ExitThunkGenerator::emitThunk):
(JSC::FTL::ExitThunkGenerator::emitThunks):

  • ftl/FTLExitThunkGenerator.h:
  • ftl/FTLExitValue.h:

(JSC::FTL::ExitValue::isInJSStackSomehow):
(JSC::FTL::ExitValue::valueFormat):

  • ftl/FTLFail.cpp:

(JSC::FTL::fail):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLJITCode.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::generateExitThunks):
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::LowerDFGToLLVM::linkOSRExitsAndCompleteInitializationBlocks):

  • ftl/FTLOSRExit.h:
  • ftl/FTLOSRExitCompilationInfo.h:

(JSC::FTL::OSRExitCompilationInfo::OSRExitCompilationInfo):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStubWithOSRExitStackmap):
(JSC::FTL::compileStubWithoutOSRExitStackmap):
(JSC::FTL::compileFTLOSRExit):

  • ftl/FTLSaveRestore.cpp: Added.

(JSC::FTL::bytesForGPRs):
(JSC::FTL::requiredScratchMemorySizeInBytes):
(JSC::FTL::offsetOfGPR):
(JSC::FTL::saveAllRegisters):
(JSC::FTL::restoreAllRegisters):

  • ftl/FTLSaveRestore.h: Added.
  • ftl/FTLStackMaps.cpp: Added.

(JSC::FTL::readObject):
(JSC::FTL::StackMaps::Constant::parse):
(JSC::FTL::StackMaps::Constant::dump):
(JSC::FTL::StackMaps::Location::parse):
(JSC::FTL::StackMaps::Location::dump):
(JSC::FTL::StackMaps::Location::involvesGPR):
(JSC::FTL::StackMaps::Location::isGPR):
(JSC::FTL::StackMaps::Location::gpr):
(JSC::FTL::StackMaps::Location::restoreInto):
(JSC::FTL::StackMaps::Record::parse):
(JSC::FTL::StackMaps::Record::dump):
(JSC::FTL::StackMaps::parse):
(JSC::FTL::StackMaps::dump):
(JSC::FTL::StackMaps::dumpMultiline):
(JSC::FTL::StackMaps::getRecordMap):
(WTF::printInternal):

  • ftl/FTLStackMaps.h: Added.
  • ftl/FTLState.h:
  • ftl/FTLThunks.cpp:

(JSC::FTL::osrExitGenerationThunkGenerator):

  • ftl/FTLValueFormat.cpp:

(JSC::FTL::reboxAccordingToFormat):

  • ftl/FTLValueFormat.h:
  • runtime/DataView.cpp:

(JSC::DataView::create):

  • runtime/DataView.h:

(JSC::DataView::read):

  • runtime/Options.h:
9:24 PM Changeset in webkit [157208] by fpizlo@apple.com
  • 4 edits in trunk/Source/WTF

FTL should be able to do simple OSR exits using llvm.webkit.stackmap
https://bugs.webkit.org/show_bug.cgi?id=122538

Reviewed by Oliver Hunt.

  • wtf/PrintStream.cpp:

(WTF::printInternal):

  • wtf/PrintStream.h:
  • wtf/RefCountedArray.h:

(WTF::RefCountedArray::byteSize):

8:26 PM Changeset in webkit [157207] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Another build fix after r157204.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatch):

8:19 PM Changeset in webkit [157206] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix after r157204.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatch):

7:46 PM Changeset in webkit [157205] by Darin Adler
  • 22 edits in trunk/Source/WebCore

Use unique_ptr instead of deleteAllValues in XPath
https://bugs.webkit.org/show_bug.cgi?id=121082

Reviewed by Anders Carlsson.

  • dom/Attr.h: Made the namespaceURI function public so it can be called by

code in XPath. Since the class is FINAL, calls won't do virtual dispatch.

  • xml/XPathExpression.cpp:

(WebCore::XPathExpression::XPathExpression): Added. Use std::move.
(WebCore::XPathExpression::createExpression): Use the new Parser::parseStatement
and more std::move.
(WebCore::XPathExpression::~XPathExpression): Removed now-unneeded delete.

  • xml/XPathExpression.h: Removed unused create function. Use std::unique_ptr.
  • xml/XPathExpressionNode.cpp:

(WebCore::XPath::Expression::evaluationContext): Use NeverDestroyed instead of
DEFINE_STATIC_LOCAL.
(WebCore::XPath::Expression::setSubexpressions): Added. Used to set all the
subexpressions at once rather than adding one at a time.

  • xml/XPathExpressionNode.h: Use plain unsigned instead of unsigned long.

Eliminated the ParseNode class, used only by the parser to delete objects,
which we now do with %destructor. Made more functions protected. Fixed the
capitalization of the word "subexpression". Made m_subexpressions be a Vector
of std::unique_ptr.

  • xml/XPathFunctions.cpp: Marked all the classes FINAL and all their virtual

functions OVERRIDE. Reduced some of the boilerplate.
(WebCore::XPath::Function::setArguments): Passed in the name so we don't have
to store the function names in all the function objects.
(WebCore::XPath::FunId::evaluate): Use std::move instead of Value::adopt.
(WebCore::XPath::FunLocalName::evaluate): Use emptyString instead of "".
(WebCore::XPath::FunNamespaceURI::evaluate): Ditto.
(WebCore::XPath::FunName::evaluate): Ditto.
(WebCore::XPath::FunSubstringBefore::evaluate): Ditto.
(WebCore::XPath::FunSubstringAfter::evaluate): Ditto.
(WebCore::XPath::FunSubstring::evaluate): Ditto.
(WebCore::XPath::FunLang::evaluate): Use Value(false) so we can make the
constructor that takes a boolean explicit.
(WebCore::XPath::FunFalse::evaluate): Ditto.
(WebCore::XPath::populateFunctionMap): Changed idiom slightly to match other
maps we set up.
(WebCore::XPath::Function::create): Refactored createFunction into three
member functions of this name.

  • xml/XPathFunctions.h: Made all the Function members private or protected

except for Function::create.

  • xml/XPathGrammar.y: Changed the parser to use a reference instead of

a pointer, and to pass the reference through to yylex as well. Break up
the union into pieces and add %destructor as needed to make sure everything
gets deallocated if parsing fails. Added a new top level rule "Top" so that
we would not try to set the parse result multiple times during parsing.
Call setParseResult instead of setting m_topExpr directly. Use std::unique_ptr
to adopt pointers from the union. Removed all the register/unregister calls
that used to be used to manage storage. Also changed the four different node
types to be separate tokens instead of using string matching at this level
for them.

  • xml/XPathNodeSet.cpp:

(WebCore::XPath::NodeSet::sort): Removed const_cast since m_isSorted and
m_nodes are now both marked mutable. Also set m_isSorted after sorting; this
was an oversight that hurt performance before.
(WebCore::XPath::NodeSet::traversalSort): Ditto.
(WebCore::XPath::NodeSet::firstNode): Use nullptr.
(WebCore::XPath::NodeSet::anyNode): Ditto.

  • xml/XPathNodeSet.h: Removed unneeded extra includes. Removed the

WTF_MAKE_FAST_ALLOCATED for NodeSet since we never allocate these on the heap.
Added a constructor that takes a single node. Deleted the swap function, since
we now move instead of swap. Deleted the append function that takes a raw Node*,
since calling the PassRefPtr<Node> overload does the same thing. Removed the
unused reverse function. Marked both m_isSorted and m_nodes mutable so the
sort function can be const.

  • xml/XPathParser.cpp: Moved the Token struct in here instead of the header.

(WebCore::XPath::populateAxisNamesMap):Renamed to match our normal naming scheme,
and changed to use add instead of set, use WTF_ARRAY_LENGTH, and not use a typedef.
(WebCore::XPath::parseAxisName): Related style changes, including renaming to
better reflect the way this works with a boolean.
(WebCore::XPath::Parser::nextTokenInternal): Updated to call parseAxisName,
and to produce four separate tokens for the four node type functions.
(WebCore::XPath::Parser::nextToken): Renamed local variable.
(WebCore::XPath::Parser::Parser): Made this a real constructor that takes arguments
and initializes all the fields. Deleted the unneeded reset function.
(WebCore::XPath::Parser::lex): Changed to take an argument of an appropriate type
instead of casting from void*. Also changed the string code to leak a StringImpl,
which is now what the grammar code expects.
(WebCore::XPath::Parser::expandQualifiedName): Renamed from expandQName. Changed
to set m_sawNamespaceError instead of relying on code in the grammar to do it.
(WebCore::XPath::Parser::parseStatement): Removed most of the code in this function.
Changed to a much simpler model. Also made this a static member function so it
takes care of creating the parser itself and does not need to call reset. Also
changed return value to be a std::unique_ptr to make ownership more clear.

  • xml/XPathParser.h: Added a declaration of YYSTYPE. Removed unneeded forward

declarations and moved Token into the cpp file. Deleted most public functions,
leaving only parseStatement, the entry point, and the three functions needed by
the grammar, lex, expandQualifiedName, and setParseResult.

  • xml/XPathPath.cpp:

(WebCore::XPath::Filter::Filter): Move in the arguments instead of copying them.
(WebCore::XPath::Filter::evaluate): Updated for name and type changes.
(WebCore::XPath::LocationPath::LocationPath): Ditto.
(WebCore::XPath::LocationPath::evaluate): Ditto. Also use std::move instead of
Value::adopt and instead of swap.
(WebCore::XPath::LocationPath::appendStep): Changed to take ownership of a
unique_ptr.
(WebCore::XPath::LocationPath::prependStep): Ditto. Renamed from insertFirstStep.
(WebCore::XPath::Path::Path): Move in the arguments.

  • xml/XPathPath.h: Removed unneeded includes. Changed arugument types to use

std::unique_ptr to pass ownership in. Added override to all virtual functions.
Changed data members to use std::unique_ptr.

  • xml/XPathPredicate.cpp:

(WebCore::XPath::StringExpression::StringExpression): Use move.
(WebCore::XPath::Negative::Negative): Added.
(WebCore::XPath::Negative::evaluate): Updated for name changes.
(WebCore::XPath::NumericOp::NumericOp): Use move.
(WebCore::XPath::NumericOp::evaluate): Tweak formatting.
(WebCore::XPath::EqTestOp::EqTestOp): Use move.
(WebCore::XPath::EqTestOp::evaluate): Updated for name changes.
(WebCore::XPath::LogicalOp::LogicalOp): Use move.
(WebCore::XPath::LogicalOp::shortCircuitOn): Made shorter.
(WebCore::XPath::LogicalOp::evaluate): Updated for name changes.
(WebCore::XPath::Union::Union): Added.
(WebCore::XPath::Union::evaluate): Updated for name changes.
(WebCore::XPath::evaluatePredicate): Updated for name changes, to use
ASCIILiteral, and to be a free function that takes an expression.
(WebCore::XPath::predicateIsContextPositionSensitive): Added.
Replaces the Predicate::isContextPositionSensitive function.

  • xml/XPathPredicate.h: Made all the classes FINAL and added a lot of OVERRIDE.

Added a constructor for Negative and Union. Got rid of the Predicate class and
instead provided two functions that operate on an Expression.

  • xml/XPathStep.cpp:

(WebCore::XPath::Step::Step): Use move instea dof copying.
(WebCore::XPath::Step::~Step): Removed calls to deleteAllValues.
(WebCore::XPath::Step::optimize): Use move instead of swap and copy. Also
operate directly on the data members of the node test instead of using functions
that just return references to those data members.
(WebCore::XPath::optimizeStepPair): Use references instead of pointers, move
instead of swap, and early return instead of nested if statements.
(WebCore::XPath::Step::predicatesAreContextListInsensitive): Use references.
(WebCore::XPath::Step::evaluate): Use references instead of pointers and move
instead of swap.
(WebCore::XPath::nodeMatchesBasicTest): Use references instead of pointers and
more specific types when possible.
(WebCore::XPath::nodeMatches): Ditto.
(WebCore::XPath::Step::nodesInAxis): Use references instead of pointers. Added
braces to match style. Use words instead of letters for local variable names.

  • xml/XPathStep.h: Make almost everything in NodeTest private since callers

just set these up and Step is what actually uses them. Changed the predicate
vectors to be vectors of Predicate instead of Predicate*, since a Predicate
is just a wrapper around a single std::unique_ptr<Expression>. Changed to use
move instead of copy when making a Step and to use references instead of pointers.

  • xml/XPathValue.cpp: Use std::numeric_limits explicitly instead of using using.

Got rid of Value::adopt.
(WebCore::XPath::Value::toNodeSet): Use NeverDestroyed instead of DEFINE_STATE_LOCAL.
Updated for name changes.
(WebCore::XPath::Value::modifiableNodeSet): Ditto.
(WebCore::XPath::Value::toBoolean): Ditto.
(WebCore::XPath::Value::toNumber): Ditto.
(WebCore::XPath::Value::toString): Ditto. Use ASCIILiteral.

  • xml/XPathValue.h: Moved ValueData class inside the Value class and renamed

it Value::Data. Removed fancy trick that avoids turning pointers into bool, and
just take the risk. Made many, but not all, of the Value constructors explicit
since we normally are explicit at call sites. Removed unneeded unsigned long
overload of the constructor. Changed the NodeSet version of the constructor to
use std::move and use that instead of AdoptTag.

6:59 PM Changeset in webkit [157204] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix. Add back the missing call to EventRetargeter::adjustForTouchEvent.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatch):

6:44 PM Changeset in webkit [157203] by rniwa@webkit.org
  • 20 edits
    2 deletes in trunk/Source/WebCore

EventDispatchMediator is goner
https://bugs.webkit.org/show_bug.cgi?id=122581

Reviewed by Antti Koivisto.

Killed the death.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/Element.cpp:

(WebCore::Element::dispatchWheelEvent):
(WebCore::Element::dispatchKeyEvent):
(WebCore::Element::dispatchFocusEvent):
(WebCore::Element::dispatchBlurEvent):

  • dom/EventDispatchMediator.cpp: Removed.
  • dom/EventDispatchMediator.h: Removed.
  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::dispatchScopedEvent):

  • dom/EventDispatcher.h:
  • dom/KeyboardEvent.h:
  • dom/MouseEvent.h:
  • dom/Node.cpp:

(WebCore::Node::dispatchScopedEvent):
(WebCore::Node::dispatchEvent):
(WebCore::Node::dispatchGestureEvent):
(WebCore::Node::dispatchTouchEvent):
(WebCore::Node::dispatchUIRequestEvent):

  • dom/Node.h:
  • dom/ScopedEventQueue.cpp:

(WebCore::ScopedEventQueue::~ScopedEventQueue):
(WebCore::ScopedEventQueue::enqueueEvent):
(WebCore::ScopedEventQueue::dispatchAllEvents):
(WebCore::ScopedEventQueue::dispatchEvent):

  • dom/ScopedEventQueue.h:
  • dom/TouchEvent.cpp:
  • dom/TouchEvent.h:
  • dom/UIEvent.h:
  • dom/WheelEvent.h:
6:37 PM Changeset in webkit [157202] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Kill some RenderObject::firstChildSlow/lastChildSlow usage.
<https://webkit.org/b/122582>

Reviewed by Antti Koivisto.

Use tighter typing in some random places to flush out unnecessary use
of virtual first/last child getters on RenderObject.

There are more of these opportunities, but I left them untouched to
avoid snowballing this patch.

6:23 PM Changeset in webkit [157201] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

webkit-patch failure-reason fails with UnicodeDecodeError when name has non-ascii characters
https://bugs.webkit.org/show_bug.cgi?id=122552

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-10-09
Reviewed by Darin Adler.

  • Scripts/webkitpy/common/checkout/commitinfo.py:

(CommitInfo.blame_string): ensure objects are made into unicode strings, not regular ones that
will cause UnicodeDecodeError for non-ascii characters.

6:23 PM Changeset in webkit [157200] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix some bad paths in the Xcode project
https://bugs.webkit.org/show_bug.cgi?id=122583

Reviewed by Mark Rowe.

Fix paths for some storage quota-related files, and remove
reference to mediaControlsQuickTime.css which was removed in r156546.

  • WebCore.xcodeproj/project.pbxproj:
6:17 PM Changeset in webkit [157199] by Alexandru Chiculita
  • 7 edits
    16 adds in trunk

Web Inspector: [CSS Regions] Display the correct fragment boxes for content inside flow threads
https://bugs.webkit.org/show_bug.cgi?id=122291

Reviewed by Timothy Hatcher.

Source/WebCore:

Tests: inspector/elements/highlight-regions-flow-horiz-bt.html

inspector/elements/highlight-regions-flow-transform-horiz-bt.html
inspector/elements/highlight-regions-flow-transform-vert-lr.html
inspector/elements/highlight-regions-flow-transform-vert-rl.html
inspector/elements/highlight-regions-flow-transform.html
inspector/elements/highlight-regions-flow-vert-lr.html
inspector/elements/highlight-regions-flow-vert-rl.html
inspector/elements/highlight-regions-flow.html

Nodes inside a RenderFlowThread can be split across multiple regions. This patch adds the required
code to compute "fragments" for each region. Each fragment will display its own label.

There are a couple of changes:

  1. The node highlight object now has a "scroll" property to hold the main view's scroll offset.
  2. There's a "fragment" array to get a list of quads for each renderer fragment. Renderers outside

RenderFlowThreads will just have one fragment.

  1. ElementInfo now has two more properties: "regionFlowInfo" (renamed from former flowInfo) and "contentFlowInfo".

If the renderer is a RenderRegion it will have a regionFlowInfo. If the renderer is inside a RenderFlowThread
then it will have a "contentFlowInfo".

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::getHighlight): It should now take a "region" parameter to customize the output for a specific
containing region.
(WebCore::buildObjectForHighlight):
(WebCore::buildObjectForCSSRegionContentClip): We need to know how to clip the fragments inside regions.
(WebCore::buildObjectForRendererFragments): Extracted code from buildObjectForHighlight and added
the new regions lookup code.
(WebCore::buildObjectForElementInfo): Extracted from buildObjectForHighlight.
(WebCore::InspectorOverlay::buildObjectForHighlightedNode):
(WebCore::InspectorOverlay::drawQuadHighlight):

  • inspector/InspectorOverlayPage.css: There can be multiple labels on screen at once, so I've

created the #element-title-template element that we clone for each label. .element-title-container is now
holding all the .element-title elements, so that we can remove them all at once.
(.element-title-container):
(.element-title):
(#element-title-template):
(.tag-name):
(.node-id):
(.class-name):

  • inspector/InspectorOverlayPage.html:
  • inspector/InspectorOverlayPage.js:

(reset):
(_toggleOptionalValue):
(_createElementTitle): Creates an element populated with data read from elementInfo.
(_drawElementTitle): Added code to create more labels for multiple fragments.
(_drawRegionsHighlight):
(_drawFragmentHighlight):
(drawNodeHighlight): Consolidated the scroll property into a canvas.transform.

LayoutTests:

Added tests to check the result of the InspectorOverlay when it inspects nodes inside RenderFlowThreads.

  • http/tests/inspector/elements-test.js:
  • inspector/elements/highlight-regions-flow-expected.txt: Added.
  • inspector/elements/highlight-regions-flow-horiz-bt-expected.txt: Added.
  • inspector/elements/highlight-regions-flow-horiz-bt.html: Added.
  • inspector/elements/highlight-regions-flow-transform-expected.txt: Added.
  • inspector/elements/highlight-regions-flow-transform-horiz-bt-expected.txt: Added.
  • inspector/elements/highlight-regions-flow-transform-horiz-bt.html: Added.
  • inspector/elements/highlight-regions-flow-transform-vert-lr-expected.txt: Added.
  • inspector/elements/highlight-regions-flow-transform-vert-lr.html: Added.
  • inspector/elements/highlight-regions-flow-transform-vert-rl-expected.txt: Added.
  • inspector/elements/highlight-regions-flow-transform-vert-rl.html: Added.
  • inspector/elements/highlight-regions-flow-transform.html: Added.
  • inspector/elements/highlight-regions-flow-vert-lr-expected.txt: Added.
  • inspector/elements/highlight-regions-flow-vert-lr.html: Added.
  • inspector/elements/highlight-regions-flow-vert-rl-expected.txt: Added.
  • inspector/elements/highlight-regions-flow-vert-rl.html: Added.
  • inspector/elements/highlight-regions-flow.html: Added.
5:53 PM Changeset in webkit [157198] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Layout assertion failure in WebCore::RenderView::paint
https://bugs.webkit.org/show_bug.cgi?id=121925

Reviewed by Tim Horton.

This fixes the assertion seen when running WK2 API tests.

If RenderLayerCompositor::flushPendingLayerChanges() was called before
the root layer was attached, it would set m_shouldFlushOnReattach
to do the flush later, after attaching (bypassing the runloop observer
that updated layout if necessary).

This could cause us to get to a CA commit without having updated
layout, hence the assertion.

Fix by having attachRootLayer() schedule a layer flush, rather than doing
one right away.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::attachRootLayer):

5:35 PM Changeset in webkit [157197] by Bem Jones-Bey
  • 9 edits in trunk/Source/WebCore

Move float logical location/dimension methods to RenderBlockFlow
https://bugs.webkit.org/show_bug.cgi?id=122282

Reviewed by David Hyatt.

I recently moved the logical location and dimension methods from
RenderBlock to FloatingObject. This made it so that the methods needed
to take in the horizontal writing mode of the FloatingObject's
container in order to do their thing. When looking into how to fix
this, I came to understand why RenderBlock has methods to determine
the logical location and dimensions of its children, when the children
themselves have those methods: the methods on RenderBlock are for
determining the logical value in the writing mode of that RenderBlock,
and the method on the child is for determining the logical value in
the writing mode of the child.

Since the floating object list has moved from RenderBlock to
RenderBlockFlow, this change moves the logical dimension methods from
FloatingObject to RenderBlockFlow.

No new tests, no new behavior.

  • rendering/FloatingObjects.cpp:

(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter):
(WebCore::FloatingObjects::FloatingObjects):
(WebCore::::updateOffsetIfNeeded):
(WebCore::::collectIfNeeded):
(WebCore::::getHeightRemaining):

  • rendering/FloatingObjects.h:
  • rendering/LineWidth.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::clearFloats):
(WebCore::RenderBlockFlow::repaintOverhangingFloats):
(WebCore::RenderBlockFlow::insertFloatingObject):
(WebCore::RenderBlockFlow::removeFloatingObject):
(WebCore::RenderBlockFlow::removeFloatingObjectsBelow):
(WebCore::RenderBlockFlow::computeLogicalLocationForFloat):
(WebCore::RenderBlockFlow::positionNewFloats):
(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelow):
(WebCore::RenderBlockFlow::lowestFloatLogicalBottom):
(WebCore::RenderBlockFlow::addOverhangingFloats):
(WebCore::RenderBlockFlow::hasOverhangingFloat):
(WebCore::RenderBlockFlow::addIntrudingFloats):

  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::logicalTopForFloat):
(WebCore::RenderBlockFlow::logicalBottomForFloat):
(WebCore::RenderBlockFlow::logicalLeftForFloat):
(WebCore::RenderBlockFlow::logicalRightForFloat):
(WebCore::RenderBlockFlow::logicalWidthForFloat):
(WebCore::RenderBlockFlow::logicalHeightForFloat):
(WebCore::RenderBlockFlow::logicalSizeForFloat):
(WebCore::RenderBlockFlow::pixelSnappedLogicalTopForFloat):
(WebCore::RenderBlockFlow::pixelSnappedLogicalBottomForFloat):
(WebCore::RenderBlockFlow::pixelSnappedLogicalLeftForFloat):
(WebCore::RenderBlockFlow::pixelSnappedLogicalRightForFloat):
(WebCore::RenderBlockFlow::setLogicalTopForFloat):
(WebCore::RenderBlockFlow::setLogicalLeftForFloat):
(WebCore::RenderBlockFlow::setLogicalHeightForFloat):
(WebCore::RenderBlockFlow::setLogicalWidthForFloat):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::adjustLogicalLineTopAndLogicalHeightIfNeeded):
(WebCore::RenderBlockFlow::checkPaginationAndFloatsAtEndLine):
(WebCore::updateSegmentsForShapes):
(WebCore::LineBreaker::nextSegmentBreak):
(WebCore::RenderBlockFlow::positionNewFloatOnLine):

  • rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):

  • rendering/shapes/ShapeOutsideInfo.h:
5:29 PM Changeset in webkit [157196] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove MouseEventDispatchMediator
https://bugs.webkit.org/show_bug.cgi?id=122580

Reviewed by Antti Koivisto.

Removed. Will remove EventDispatchMediator next.

  • dom/Element.cpp:

(WebCore::Element::dispatchMouseEvent):

  • dom/MouseEvent.cpp:
  • dom/MouseEvent.h:
  • dom/Node.cpp:

(WebCore::Node::dispatchEvent):
(WebCore::Node::dispatchTouchEvent):

4:49 PM Changeset in webkit [157195] by rniwa@webkit.org
  • 11 edits in trunk/Source/WebCore

Remove all subclasses of EventDispatchMediator except MouseEventDispatchMediator
https://bugs.webkit.org/show_bug.cgi?id=122579

Reviewed by Antti Koivisto.

Removed UIRequestEventDispatchMediator, GestureEventDispatchMediator, KeyboardEventDispatchMediator,
and WheelEventDispatchMediator. Moved the code in the respective mediateAndDispatchEvent functions
to their respective dispatch*Event functions in Node.cpp and Element.cpp.

  • Modules/indieui/UIRequestEvent.cpp:

(WebCore::UIRequestEvent::eventInterface):

  • Modules/indieui/UIRequestEvent.h:
  • dom/Element.cpp:

(WebCore::deltaMode):
(WebCore::Element::dispatchWheelEvent):
(WebCore::Element::dispatchKeyEvent):

  • dom/GestureEvent.cpp:
  • dom/GestureEvent.h:
  • dom/KeyboardEvent.cpp:
  • dom/KeyboardEvent.h:
  • dom/Node.cpp:

(WebCore::Node::dispatchGestureEvent):
(WebCore::Node::dispatchUIRequestEvent):

  • dom/WheelEvent.cpp:
  • dom/WheelEvent.h:
4:03 PM Changeset in webkit [157194] by ap@apple.com
  • 2 edits in trunk/Tools

Would like a link to dashboard from build.webkit.org main page
https://bugs.webkit.org/show_bug.cgi?id=122577

Reviewed by Tim Hatcher.

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added.
3:57 PM Changeset in webkit [157193] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Minor clean-ups in the JSC Xcode project.

Rubber stamped by Mark Rowe.

  • When we copy the jsc binary into the framework, $(BUILT_PRODUCTS_DIR)/JavaScriptCore.framework/Resources/jsc is the *output* file not the input file. The input file is $(BUILT_PRODUCTS_DIR)/jsc.


  • Correct capitalization of "JavaScriptcore.framework" in a comment in a shell script in the project.
3:54 PM Changeset in webkit [157192] by Bem Jones-Bey
  • 7 edits in trunk

[CSS Shapes] Lines that don't intersect shape-outside should ignore both left and right margins
https://bugs.webkit.org/show_bug.cgi?id=122570

Reviewed by Alexandru Chiculita.

Source/WebCore:

Due to an oversight, the left margin on left floats and the right
margin on right floats was having an effect on lines that did not
intersect the shape (but did intersect the margin box of the float).
By the spec, lines that do not intersect the shape should act as if
the float isn't there, so those margins should have no effect on
those lines. This patch fixes this.

No new tests, it is covered by the existing tests now that they have
been fixed to have the proper behavior.

  • rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):

LayoutTests:

Update tests to work with the proper behavior for margins. Yes, the
tests were not correct before.

  • csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-007.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-009.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
  • fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes.html:
3:39 PM Changeset in webkit [157191] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] Check for MathML fonts and warn user if they are missing.
https://bugs.webkit.org/show_bug.cgi?id=122568

Reviewed by Tim Horton.

  • Scripts/webkitdirs.pm:

(checkRequiredSystemConfig): Use common gperf/bison/flex tests, rather than
Windows-specific code I added previously.
(fontExists): Added
(checkInstalledTools): Add check for MathML fonts.

3:32 PM Changeset in webkit [157190] by ap@apple.com
  • 3 edits in trunk/Tools

http://build.webkit.org/dashboard/ doesn't link to webkitpy failures
https://bugs.webkit.org/show_bug.cgi?id=122471

Reviewed by Tim Hatcher.

Added links to webkitpy, webkitperl and bindings-tests results.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:

(Buildbot.prototype.apiTestResultsURLForIteration):
(Buildbot.prototype.webkitpyTestResultsURLForIteration):
(Buildbot.prototype.webkitperlTestResultsURLForIteration):
(Buildbot.prototype.bindingsTestResultsURLForIteration):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):

3:03 PM Changeset in webkit [157189] by ap@apple.com
  • 3 edits in trunk/Tools

Move some functions from WebKitBuildbot to Buildbot class.

Suggested by Tim Hatcher.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:

(Buildbot.prototype.javascriptTestResultsURLForIteration):
(Buildbot.prototype.apiTestResultsURLForIteration):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot.prototype.layoutTestResultsURLForIteration):

2:58 PM Changeset in webkit [157188] by ap@apple.com
  • 3 edits in trunk/Tools

Add API tests to the Dashbord page.

https://bugs.webkit.org/show_bug.cgi?id=122283

Patch by Timothy Hatcher <timothy@apple.com> on 2013-10-09
Reviewed by Timothy Hatcher.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot.prototype.apiTestResultsURLForIteration):

2:56 PM Changeset in webkit [157187] by timothy@apple.com
  • 3 edits in trunk/Tools

Add API tests to the Dashbord page.

https://bugs.webkit.org/show_bug.cgi?id=122283

Reviewed by Timothy Hatcher.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot.prototype.apiTestResultsURLForIteration):

2:45 PM Changeset in webkit [157186] by Bem Jones-Bey
  • 5 edits
    8 adds in trunk

[CSS Shapes] Clip shape-outside to the bottom of the margin box
https://bugs.webkit.org/show_bug.cgi?id=122562

Reviewed by Alexandru Chiculita.

Source/WebCore:

The spec says that a shape-outside shape must be clipped to the
margin box. This implements clipping the bottom of the shape to the
bottom of the margin box.

Test: csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-000.html

csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001.html
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-002.html
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelow):

LayoutTests:

Test that the shape is properly clipped to the bottom of the float.

  • csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-000-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-000.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-002-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-002.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
2:34 PM Changeset in webkit [157185] by timothy@apple.com
  • 2 edits in trunk/Tools

Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.

https://bugs.webkit.org/show_bug.cgi?id=122515

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration.prototype.update):

2:01 PM Changeset in webkit [157184] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[CoordinatedGraphics] ASSERTION FAILED: !m_flushingLayers (after r156291)
https://bugs.webkit.org/show_bug.cgi?id=122016

Patch by Sergio Correia <Sergio Correia> on 2013-10-09
Reviewed by Noam Rosenthal.

To prevent calling scheduleLayerFlush() inside flushCompositingState(),
we now only call m_client->notifyFlushRequired() - which will trigger
scheduleLayerFlush() - if we are not already flushing layer changes.

No new tests, covered by existing ones.

  • platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:

(WebCore::CompositingCoordinator::notifyFlushRequired): Check if we
are already flushing layer changes before calling notifyFlushRequired.
(WebCore::CompositingCoordinator::sizeDidChange): Use notifyFlushRequired()
from CompositingCoordinator instead of calling the one from m_client
directly.
(WebCore::CompositingCoordinator::createGraphicsLayer): Ditto.
(WebCore::CompositingCoordinator::detachLayer): Ditto.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::notifyFlushRequired): Added helper
to check whether we are flushing layer changes before calling client()'s
notifyFlushRequired(). It returns a boolean indicating whether it
called the client's method.
(WebCore::CoordinatedGraphicsLayer::didChangeLayerState): Use the
notifyFlushRequired() helper.
(WebCore::CoordinatedGraphicsLayer::didChangeAnimations): Ditto.
(WebCore::CoordinatedGraphicsLayer::didChangeChildren): Ditto.
(WebCore::CoordinatedGraphicsLayer::didChangeFilters): Ditto.
(WebCore::CoordinatedGraphicsLayer::didChangeImageBacking): Ditto.
(WebCore::CoordinatedGraphicsLayer::setContentsNeedsDisplay): Ditto.
(WebCore::CoordinatedGraphicsLayer::setContentsToCanvas): Ditto.
(WebCore::CoordinatedGraphicsLayer::flushCompositingState): Ditto.
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreHasPendingTileCreation):Ditto.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

Declaration of the notifyFlushRequired() helper.

2:00 PM Changeset in webkit [157183] by Chris Fleizach
  • 4 edits
    3 adds in trunk

AX: VoiceOver double speaks all items in <li> nodes
https://bugs.webkit.org/show_bug.cgi?id=122564

Reviewed by Brent Fulgham.

Source/WebCore:

Test: platform/mac/accessibility/native-list-item-should-not-expose-label.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::visibleText):

LayoutTests:

Make a mac specific expectation for listitem-title on Mac.
Make a more directed test for Mac regarding listitem labeling.

  • platform/mac/accessibility/lists-expected.txt:
  • platform/mac/accessibility/listitem-title-expected.txt: Added.
  • platform/mac/accessibility/native-list-item-should-not-expose-label-expected.txt: Added.
  • platform/mac/accessibility/native-list-item-should-not-expose-label.html: Added.
1:44 PM Changeset in webkit [157182] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Many inspector protocol tests are timing out on the bots, unreproducible locally.

  • platform/gtk/TestExpectations:
1:31 PM Changeset in webkit [157181] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. A couple of paste tests began timing out after
http://trac.webkit.org/changeset/156678.

  • platform/gtk/TestExpectations:
1:26 PM Changeset in webkit [157180] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

CoordinatedGraphics: Fix integer rounding when computing pixel alignment
https://bugs.webkit.org/show_bug.cgi?id=122565

Patch by Sergio Correia <Sergio Correia> on 2013-10-09
Reviewed by Noam Rosenthal.

Source/WebCore:

Replace roundedIntRect call in computePixelAlignment() with enclosingIntRect,
so that very small rectangles (after content scaling) don't appear to be empty,
creating a crash later.

Test: transforms/3d/general/rotate-45-degrees-long-inner-text-in-dt.html

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::computePixelAlignment):

LayoutTests:

Added test that rotates 45 degrees a very long text in a dt tag that
might crash the browser depending on how it handles the integer
rounding when computing pixel alignment.

  • transforms/3d/general/rotate-45-degrees-long-inner-text-in-dt-expected.txt: Added.
  • transforms/3d/general/rotate-45-degrees-long-inner-text-in-dt.html: Added.
1:22 PM Changeset in webkit [157179] by ap@apple.com
  • 2 edits in trunk/Tools

http://build.webkit.org/dashboard/ links to a wrong jscore-test results page
https://bugs.webkit.org/show_bug.cgi?id=122569

Reviewed by Tim Hatcher.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot.prototype.javascriptTestResultsURLForIteration): "actual.html" used
to be produced by the old Mozilla test harness that we don't use any more.

1:15 PM Changeset in webkit [157178] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Set view to active in ViewClientEfl after WebProcess has relaunched
https://bugs.webkit.org/show_bug.cgi?id=118650

Patch by Sergio Correia <Sergio Correia> on 2013-10-09
Reviewed by Noam Rosenthal.

Once WebProcess relaunches, the underlying scene from the view is recreated
and is not active by default, which means it will be in `background'. In
practice, from that point on we are going to get a blank screen, unless we
set it to active.

In the normal flow, the view is set to active during its initialization; this
patch sets it to active also in ViewClientEfl, in the webProcessDidRelaunch
callback.

  • UIProcess/efl/ViewClientEfl.cpp:

(WebKit::ViewClientEfl::webProcessDidRelaunch): Added WKViewSetIsActive call.

1:05 PM Changeset in webkit [157177] by rniwa@webkit.org
  • 14 edits in trunk/Source/WebCore

Rename EventRetargeter::adjustForRelatedTarget to EventPath::setRelatedTarget
https://bugs.webkit.org/show_bug.cgi?id=122539

Reviewed by Darin Adler.

Renamed EventRetargeter::adjustForRelatedTarget to EventPath::setRelatedTarget and got rid of
EventDispatchMediators for focus events. We set the related target inside EventDispatcher's
dispatch via Event::relatedTarget, which is now virtual and overridden by mouse/focus events.

  • dom/Element.cpp: The following functions no longer use FocusEventDispatchMediators.

(WebCore::Element::dispatchFocusInEvent):
(WebCore::Element::dispatchFocusOutEvent):
(WebCore::Element::dispatchFocusEvent):
(WebCore::Element::dispatchBlurEvent):

  • dom/Event.h:

(WebCore::Event::relatedTarget): Added as a virtual function.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent): Cache Event*.
(WebCore::EventDispatcher::dispatch): Call setRelatedTargetToPath at the beginning to update
related targets in the path.

  • dom/EventDispatcher.h:
  • dom/EventRetargeter.cpp:

(WebCore::EventPath::EventPath): Initialize m_origin, used in EventPath::setRelatedTarget.
(WebCore::EventRetargeter::adjustTouchList):
(WebCore::EventPath::setRelatedTarget): Renamed from EventRetargeter::adjustForRelatedTarget.
Delegated the nullity checks to callers by taking references instead of pointers.
(WebCore::EventRetargeter::calculateAdjustedNodes):

  • dom/EventRetargeter.h: Removed AdjustedNodes typedef. It's just a Vector of RefPtr<Node>.
  • dom/FocusEvent.cpp: Removed FocusEventDispatchMediators for focus events.
  • dom/FocusEvent.h:
  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::toElement): Cache the related target now that relatedTarget() is virtual.
(WebCore::MouseEvent::fromElement): Ditto.
(WebCore::MouseEventDispatchMediator::mediateAndDispatchEvent): No longer sets the related
targets since that's done in EventDispatcher::dispatch now.

  • dom/MouseEvent.h:
  • dom/Node.cpp: Removed obnoxious Node::dispatchScopedEventDispatchMediator.

(WebCore::Node::dispatchScopedEvent):

  • dom/Node.h:
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlVolumeSliderContainerElement::defaultEventHandler): Cache the related
target in a local variable now that relatedTarget() is virtual.

11:22 AM Changeset in webkit [157176] by msaboff@apple.com
  • 2 edits in trunk/Source/WTF

Change to std::unique_ptr breaks wtf/DataLog.cpp when DATA_LOG_TO_FILE set to 1
https://bugs.webkit.org/show_bug.cgi?id=122557

Reviewed by Filip Pizlo.

Changed the leakPtr() to release().

  • wtf/DataLog.cpp:

(WTF::initializeLogFileOnce):

10:07 AM Changeset in webkit [157175] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Tools

Add GTK 64 bits release to the buildbot dashboard
https://bugs.webkit.org/show_bug.cgi?id=122548

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-10-09
Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot): add 64 bits release wk2 and wk1 testers.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(table.queue-grid tr.platform.linux-gtk img.logo): use the GTK+ logo in its dashboard line.

10:05 AM Changeset in webkit [157174] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/win

[Win] BeginPaint should only be called in response to WM_PAINT.
https://bugs.webkit.org/show_bug.cgi?id=122549

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-09
Reviewed by Brent Fulgham.

According to the documentation, the Win32 api function BeginPaint should only be called in response to a WM_PAINT message.
Currently, the WebView window procedure might call this function (via WebView::paint(0, 0)) for all types of messages.
Also, there is potential for double drawing. If some message is dispatched before WM_PAINT, WebView::paint(0, 0) will be called.
This call does not validate the area drawn, so later the WM_PAINT will arrive, drawing the same area.
This can be fixed by calling the Win32 function UpdateWindow(), which will do a synchronous window update, and validate the area.

  • WebView.cpp:

(WebView::WebViewWndProc): Use Win32 function UpdateWindow() to draw invalid area.

10:02 AM Changeset in webkit [157173] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[arm] Inverted src and dest FP registers in DFG speculative JIT when using hardfp.
https://bugs.webkit.org/show_bug.cgi?id=122555

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-09
Reviewed by Michael Saboff.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):

9:47 AM Changeset in webkit [157172] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Some accessibility tests are failing
https://bugs.webkit.org/show_bug.cgi?id=122553

Unreviewed EFL gardening

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-10-09

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
9:16 AM Changeset in webkit [157171] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: VoiceOver does not speak aria-expanded state on iOS
https://bugs.webkit.org/show_bug.cgi?id=122540

Expose aria-pressed state for iOS.

Reviewed by Mario Sanchez Prada.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityIsExpanded]):

8:33 AM Changeset in webkit [157170] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Update GObject DOM symbols file after r157163.

  • bindings/gobject/webkitdom.symbols:
8:24 AM Changeset in webkit [157169] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/planet.webkit.org

Add Frédéric Wang's blog to the planet
https://bugs.webkit.org/show_bug.cgi?id=122541

Patch by Frédéric Wang <fred.wang@free.fr> on 2013-10-09
Reviewed by Martin Robinson.

  • config.ini: Add my blog to the planet.
8:24 AM Changeset in webkit [157168] by andersca@apple.com
  • 6 edits
    1 delete in trunk/Source/WebCore

Remove RunLoopMac.mm
https://bugs.webkit.org/show_bug.cgi?id=122527

Reviewed by Antti Koivisto.

RunLoop::setUseApplicationRunLoopOnMainRunLoop() is no longer used, so we can just use the run() and stop()
implementations from RunLoopCF.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/RunLoop.cpp:
  • platform/RunLoop.h:
  • platform/cf/RunLoopCF.cpp:

(WebCore::RunLoop::stop):

  • platform/mac/RunLoopMac.mm: Removed.
7:54 AM Changeset in webkit [157167] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Add timeout as expected result for fast/history/go-back-to-iframe-with-plugin.html,
since it times out sometimes.

  • platform/gtk/TestExpectations:
7:48 AM Changeset in webkit [157166] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Add timeout as expected result for mathml/very-large-stretchy-operators.html,
since it times out on the bots.

  • platform/gtk/TestExpectations:
7:16 AM Changeset in webkit [157165] by mario@webkit.org
  • 6 edits
    1 delete in trunk

[ATK] Implement new API in AtkText: atk_text_get_string_at_offset()
https://bugs.webkit.org/show_bug.cgi?id=120638

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Implemented new atk_text_get_string_at_offset() API, introduced in
ATK 2.9.4 to simplify how text at a given offset is retrieved.

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(webkitAccessibleTextGetStringAtOffset): New function implementing
the new API, which basically translates calls to the new API to
calls to the old API using 'at' positions and START boundaries.
(webkitAccessibleTextInterfaceInit): Hook the new function.

Source/WebKit/gtk:

Update ATK unit test to check the new API as well if the version
of ATK is new enough.

  • tests/testatk.c:

(testGetStringFunction): New helper function, to check the new API.
(runGetStringTests): Ditto.
(testWebkitAtkGetStringAtOffset): New unit test, similar to the
one already present to check the old API but focused in the new one.
(testWebkitAtkGetStringAtOffsetNewlines): Ditto.
(testWebkitAtkGetStringAtOffsetTextarea): Ditto.
(testWebkitAtkGetStringAtOffsetTextInput): Ditto.
(testWebkitAtkGetStringAtOffsetWithPreformattedText): Ditto.
(testWebkitAtkGetStringAtOffsetWithSpecialCharacters): Ditto.
(testWebkitAtkGetStringAtOffsetWithWrappedLines): Ditto.
(testWebkitAtkGetStringAtOffsetWithEmbeddedObjects): Ditto.
(testWebkitAtkGetExtents): Add checks for the new API, if possible.
(testWebkitAtkLinksWithInlineImages): Ditto.
(main): Add the new unit tests to check the new API, if possible.

Tools:

  • gtk/jhbuild.modules: Raised ATK and AT-SPI versions to 2.10.0, so we

can check both the old and new APIs to retrieve text at a given offset.

6:29 AM Changeset in webkit [157164] by msaboff@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

Transition call and construct JITStubs to CCallHelper functions
https://bugs.webkit.org/show_bug.cgi?id=122453

Reviewed by Geoffrey Garen.

Transitioned cti_op_call_eval to operationCallEval. Migrated baseline JIT to use the same
call thunks as the DFG. Eliminated all of the "oldStyle" thunks and related functions.

  • bytecode/CallLinkInfo.cpp:

(JSC::CallLinkInfo::unlink):

  • jit/JIT.cpp:

(JSC::JIT::linkFor):
(JSC::JIT::linkSlowCall):

  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):

  • jit/JITInlines.h:

(JSC::JIT::callOperationWithCallFrameRollbackOnException):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • jit/ThunkGenerators.cpp:
  • jit/ThunkGenerators.h:
6:07 AM Changeset in webkit [157163] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

[GTK] mouse wheel events are not considered to be mouse events
https://bugs.webkit.org/show_bug.cgi?id=120648

Reviewed by Gustavo Noronha Silva.

Expose WheelEvent in the GObject DOM bindings API.

  • bindings/gobject/GNUmakefile.am: Add new files to compilation.
  • bindings/gobject/WebKitDOMPrivate.cpp:

(WebKit::wrap): Create a WebKitDOMWheelEvent when the given Event
is a WheelEvent.

5:50 AM Changeset in webkit [157162] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Unreviewed, rolling out r157157.
http://trac.webkit.org/changeset/157157
https://bugs.webkit.org/show_bug.cgi?id=122547

Caused crashes on several bots including gtk, mac-wk2 lion and
mountain lion (Requested by kov on #webkit).

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::registerNPObject):
(WebKit::NPRemoteObjectMap::pluginDestroyed):

  • Shared/Plugins/NPRemoteObjectMap.h:
4:21 AM Changeset in webkit [157161] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[sh4] Fix lots of unused parameter warnings.
https://bugs.webkit.org/show_bug.cgi?id=122545

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-09
Reviewed by Csaba Osztrogonác.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::revertJumpReplacementToPatchableBranchPtrWithPatch):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::andlImm8r):
(JSC::SH4Assembler::orlImm8r):
(JSC::SH4Assembler::xorlImm8r):
(JSC::SH4Assembler::cmpEqImmR0):
(JSC::SH4Assembler::testlImm8r):
(JSC::SH4Assembler::movwPCReg):
(JSC::SH4Assembler::movwMemReg):
(JSC::SH4Assembler::movbMemReg):
(JSC::SH4Assembler::printInstr):
(JSC::SH4Assembler::printBlockInstr):

4:06 AM Changeset in webkit [157160] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] accessibility/table-cells.html is failing
https://bugs.webkit.org/show_bug.cgi?id=122544

Unreviewed EFL gardening

Changed expectations so that they show proper name of the parent (the table)

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-10-09

  • platform/efl-wk1/accessibility/table-cells-expected.txt:
  • platform/efl-wk2/accessibility/table-cells-expected.txt:
2:16 AM Changeset in webkit [157159] by commit-queue@webkit.org
  • 4 edits in trunk

[sh4] Add sh4 support when building with CMake.
https://bugs.webkit.org/show_bug.cgi?id=122542

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-09
Reviewed by Csaba Osztrogonác.

.:

  • CMakeLists.txt:

Source/JavaScriptCore:

  • CMakeLists.txt:

Oct 8, 2013:

11:23 PM Changeset in webkit [157158] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix EFL buildbreak since r157152.

  • dom/EventRetargeter.cpp:

(WebCore::EventRetargeter::adjustForTouchEvent):

10:26 PM Changeset in webkit [157157] by Darin Adler
  • 3 edits in trunk/Source/WebKit2

Remove use of deleteAllValues in NPRemoteObjectMap::pluginDestroyed
https://bugs.webkit.org/show_bug.cgi?id=122496

Reviewed by Andreas Kling.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::registerNPObject): Don't call release when puttin objects
into the map.
(WebKit::NPRemoteObjectMap::pluginDestroyed): Instead of making an array of receivers
and deleting them all, remove all of the receivers from the map, which will take care
of deleting them. Also change the other loop to use a similar coding style.

  • Shared/Plugins/NPRemoteObjectMap.h: Change the value type of m_registeredNPObjects

to be unique_ptr instead of a raw pointer.

7:36 PM Changeset in webkit [157156] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Fix expectation for geolocation test that has been timing out.

  • platform/gtk-wk2/TestExpectations:
7:07 PM Changeset in webkit [157155] by kov@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed gardening. Move http/tests/loading/307-after-303-after-post.html failure
expectation to the global gtk expectations file, since it's also true for gtk-wk2.

  • platform/gtk-wk1/TestExpectations:
  • platform/gtk/TestExpectations:
6:16 PM Changeset in webkit [157154] by commit-queue@webkit.org
  • 8 edits
    1 delete in trunk

Improved WinLauncher.
https://bugs.webkit.org/show_bug.cgi?id=122536

Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-08
Reviewed by Brent Fulgham.

Source/WebCore:

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::cookieJarPath):
Put cookies.dat into the AppData directory on Windows.

Tools:

  • WinLauncher/PrintWebUIDelegate.cpp:

(PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): Added.
(PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): Added.

  • WinLauncher/PrintWebUIDelegate.h: Removed stubs.
  • WinLauncher/WinLauncher.cpp:

(createCrashReport): Use the executable name instead of "WinLauncher".

  • WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Removed.
  • WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to Wininet.lib.
  • win/DLLLauncher/DLLLauncherMain.cpp: Remove VS2005 dependency for WinCairo.
5:45 PM Changeset in webkit [157153] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove the code erroneously in the previous commit.

  • dom/EventDispatcher.h:

(WebCore::EventPath::contextAt):

5:41 PM Changeset in webkit [157152] by rniwa@webkit.org
  • 8 edits in trunk/Source/WebCore

Turn EventPath into a real class
https://bugs.webkit.org/show_bug.cgi?id=122533

Reviewed by Antti Koivisto.

Turned EventPath into a real class and made EventRetargeter::calculateEventPath its constructor.
We can turn a lot of functions in EventRetargeter.cpp member functions of EventPath since many
of them manipulate EventPath in one way or another.

  • dom/EventContext.h:

(WebCore::toMouseOrFocusEventContext):
(WebCore::toTouchEventContext):

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtTarget):
(WebCore::EventDispatcher::dispatchEventAtBubbling):
(WebCore::EventDispatcher::dispatchEventPostProcess):
(WebCore::EventDispatcher::topEventContext):
(WebCore::EventPath::hasEventListeners):

  • dom/EventDispatcher.h:

(WebCore::EventPath::isEmpty):
(WebCore::EventPath::size):
(WebCore::EventPath::item):
(WebCore::EventPath::targetRespectingTargetRules):
(WebCore::EventPath::shrink):
(WebCore::EventPath::lastContextIfExists):

  • dom/EventRetargeter.cpp:

(WebCore::EventPath::EventPath):
(WebCore::EventRetargeter::adjustForTouchEvent):
(WebCore::EventRetargeter::adjustForRelatedTarget):
(WebCore::EventRetargeter::calculateAdjustedNodes):

  • dom/EventRetargeter.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::eventHasListeners):

  • inspector/InspectorInstrumentation.h:
5:38 PM Changeset in webkit [157151] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. The 64 bits release bot has been made to use 8 bpp depth, so
fast/dom/Window/window-screen-properties.html won't pass there.

  • platform/gtk/TestExpectations:
5:24 PM Changeset in webkit [157150] by oliver@apple.com
  • 12 edits in trunk

Convert for-of iteration to in-band signalling so we can trivially avoid unnecessary object allocation
https://bugs.webkit.org/show_bug.cgi?id=122532

Reviewed by Michael Saboff.

Source/JavaScriptCore:

Switch for-of enumeration to use in band signalling to determine the end
of iteration. This allows us to trivially remove an otherwise unnecessary
object allocation, and paves the way for optimised thunks in future.

We can re-add explicit .next() functions in future that would marshall
the true iteration functions, but for now we'll ignore them.

This results in a huge improvement in the performance of for-of (in the order
of 2x) but there's still a long way to go in order to get the performance to
a satisfactory level.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ForOfNode::emitBytecode):

  • runtime/ArrayIteratorPrototype.cpp:

(JSC::ArrayIteratorPrototype::finishCreation):
(JSC::createIteratorResult):

  • runtime/CommonIdentifiers.cpp:

(JSC::CommonIdentifiers::CommonIdentifiers):

  • runtime/CommonIdentifiers.h:
  • runtime/Identifier.cpp:

(JSC::Identifier::addSlowCase):

  • runtime/JSObject.h:

(JSC::JSFinalObject::create):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

LayoutTests:

Update tests to reflect our non-exposure of .next()

  • js/array-iterators-expected.txt:
  • js/script-tests/array-iterators.js:
5:21 PM Changeset in webkit [157149] by kov@webkit.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

Unreviewed gardening. Make platform-specific expectation file apply only to gtk-wk1, since
gtk-wk2 gets the output right.

  • platform/gtk-wk1/fast/loader/show-only-one-beforeunload-dialog-expected.txt: Renamed from LayoutTests/platform/gtk/fast/loader/show-only-one-beforeunload-dialog-expected.txt.
5:08 PM Changeset in webkit [157148] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Update gtk-wk2-specific expectations for a couple of
fast/dom/Window tests:

  • fast/dom/Window/window-postmessage-clone.html (times out)
  • fast/dom/Window/open-window-min-size.html (fails)
  • platform/gtk-wk2/TestExpectations:
5:05 PM Changeset in webkit [157147] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Source/JavaScriptCore: Fixed compile errors while compiling without the JIT enabled.
https://bugs.webkit.org/show_bug.cgi?id=122530

Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-08
Reviewed by Brent Fulgham.

  • jit/JITOperations.cpp:

Protected with #if ENABLE(JIT) like the rest of the JIT source.

Source/ThirdParty/ANGLE: Generate pdb files for debugging ANGLE DLLs.
https://bugs.webkit.org/show_bug.cgi?id=122530

Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-08
Reviewed by Brent Fulgham.

  • ANGLE.vcxproj/libEGLCommon.props:
  • ANGLE.vcxproj/libGLESv2Common.props:

Generate debug information.

Source/WebCore: Enabled all necessary files for Win64 build.
https://bugs.webkit.org/show_bug.cgi?id=122530

Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-08
Reviewed by Brent Fulgham.

  • WebCore.vcxproj/WebCore.vcxproj:

Enabled MediaPlayerPrivateFullscreenWindow and
RenderLayerModelObject to be built in Win64 build.

Source/WebKit: Fixed Win64 linking.
https://bugs.webkit.org/show_bug.cgi?id=122530

Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-08
Reviewed by Brent Fulgham.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Added 64-bit linker symbols.

4:49 PM Changeset in webkit [157146] by weinig@apple.com
  • 14 edits in trunk/Source

Consolidate findString functions
https://bugs.webkit.org/show_bug.cgi?id=122480

Reviewed by Darin Adler.

../WebCore:

  • editing/Editor.cpp:
  • editing/Editor.h:
  • editing/EditorCommand.cpp:

(WebCore::executeFindString):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::find):

  • page/Page.cpp:
  • page/Page.h:

Fix a long standing FIXME.

../WebKit/efl:

  • ewk/ewk_frame.cpp:

(ewk_frame_text_search):

  • ewk/ewk_view.cpp:

(ewk_view_text_search):

../WebKit/gtk:

  • webkit/webkitwebview.cpp:

(webkit_web_view_search_text):

../WebKit/win:

  • WebView.cpp:

(WebView::searchFor):

4:25 PM Changeset in webkit [157145] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Upgrade accessibility/title-ui-element-correctness.html from crash (wk2-specific)
to fail (gtk-wide) expectation.

  • platform/gtk-wk2/TestExpectations:
4:20 PM Changeset in webkit [157144] by Bem Jones-Bey
  • 13 edits in trunk/Source/WebCore

Move m_floatingObjects to RenderBlockFlow from RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=122512

Reviewed by David Hyatt.

Floats are part of block flow, not every RenderBlock can contain
floars. This change makes it so that RenderBlock no longer can contain
floats, only RenderBlockFlow can.

This also moves a bunch of line layout stuff over to RenderBlockFlow,
but makes no effort to move all of line layout, as all of that is
destined to move out of both RenderBlockFlow and RenderBlock into its
own class.

No new tests, no behavior change.

  • rendering/InlineIterator.h:

(WebCore::InlineBidiResolver::appendRun):

  • rendering/LineWidth.cpp:

(WebCore::LineWidth::LineWidth):

  • rendering/LineWidth.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleWillChange):
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::splitFlow):
(WebCore::RenderBlock::deleteLineBoxTree):
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::adjustForBorderFit):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::containsFloats):
(WebCore::RenderBlock::shouldSkipCreatingRunsForObject):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::logicalRightFloatOffsetForLine):
(WebCore::RenderBlock::logicalLeftFloatOffsetForLine):
(WebCore::RenderBlock::moveAllChildrenOnRemovalTo):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::clipOutFloatingObjects):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::clearFloats):
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::collapseMargins):
(WebCore::RenderBlockFlow::clearFloatsIfNeeded):
(WebCore::RenderBlockFlow::adjustBlockChildForPagination):
(WebCore::RenderBlockFlow::containsFloat):
(WebCore::RenderBlockFlow::styleDidChange):
(WebCore::RenderBlockFlow::styleWillChange):
(WebCore::RenderBlockFlow::deleteLineBoxTree):
(WebCore::RenderBlockFlow::moveAllChildrenOnRemovalTo):
(WebCore::RenderBlockFlow::addOverflowFromFloats):
(WebCore::RenderBlockFlow::computeOverflow):
(WebCore::RenderBlockFlow::repaintOverhangingFloats):
(WebCore::RenderBlockFlow::paintFloats):
(WebCore::RenderBlockFlow::clipOutFloatingObjects):
(WebCore::RenderBlockFlow::createFloatingObjects):
(WebCore::RenderBlockFlow::removeFloatingObjects):
(WebCore::RenderBlockFlow::insertFloatingObject):
(WebCore::RenderBlockFlow::removeFloatingObject):
(WebCore::RenderBlockFlow::removeFloatingObjectsBelow):
(WebCore::RenderBlockFlow::computeLogicalLocationForFloat):
(WebCore::RenderBlockFlow::positionNewFloats):
(WebCore::RenderBlockFlow::newLine):
(WebCore::RenderBlockFlow::logicalLeftFloatOffsetForLine):
(WebCore::RenderBlockFlow::logicalRightFloatOffsetForLine):
(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelow):
(WebCore::RenderBlockFlow::lowestFloatLogicalBottom):
(WebCore::RenderBlockFlow::addOverhangingFloats):
(WebCore::RenderBlockFlow::hasOverhangingFloat):
(WebCore::RenderBlockFlow::addIntrudingFloats):
(WebCore::RenderBlockFlow::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlockFlow::markSiblingsWithFloatsForLayout):
(WebCore::RenderBlockFlow::getClearDelta):
(WebCore::RenderBlockFlow::hitTestFloats):
(WebCore::RenderBlockFlow::adjustForBorderFit):

  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::hasOverhangingFloats):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineBreaker::LineBreaker):
(WebCore::RenderBlockFlow::appendRunsForObject):
(WebCore::RenderBlockFlow::createLineBoxes):
(WebCore::RenderBlockFlow::constructLine):
(WebCore::RenderBlockFlow::setMarginsForRubyRun):
(WebCore::updateLogicalInlinePositions):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):
(WebCore::RenderBlockFlow::computeBlockDirectionPositionsForLine):
(WebCore::setStaticPositions):
(WebCore::RenderBlockFlow::handleTrailingSpaces):
(WebCore::RenderBlockFlow::appendFloatingObjectToLastLine):
(WebCore::constructBidiRunsForLine):
(WebCore::RenderBlockFlow::createLineBoxesFromBidiRuns):
(WebCore::RenderBlockFlow::layoutRunsAndFloats):
(WebCore::RenderBlockFlow::restartLayoutRunsAndFloatsInRange):
(WebCore::pushShapeContentOverflowBelowTheContentBox):
(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLine):
(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread):
(WebCore::RenderBlockFlow::adjustLogicalLineTopAndLogicalHeightIfNeeded):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::linkToEndLineIfNeeded):
(WebCore::RenderBlockFlow::repaintDirtyFloats):
(WebCore::RenderBlockFlow::checkFloatsInCleanLine):
(WebCore::RenderBlockFlow::determineStartPosition):
(WebCore::RenderBlockFlow::determineEndPosition):
(WebCore::RenderBlockFlow::checkPaginationAndFloatsAtEndLine):
(WebCore::RenderBlockFlow::matchedEndLine):
(WebCore::shouldSkipWhitespaceAfterStartObject):
(WebCore::updateSegmentsForShapes):
(WebCore::RenderBlockFlow::deleteEllipsisLineBoxes):
(WebCore::RenderBlockFlow::checkLinesForTextOverflow):
(WebCore::RenderBlockFlow::positionNewFloatOnLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::outermostBlockContainingFloatingObject):
(WebCore::RenderBox::removeFloatingOrPositionedChildFromBlockLists):

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::moveChildrenTo):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::splitFlow):

4:05 PM Changeset in webkit [157143] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WTF

Turn threaded scrolling on for all Mac ports.
Rubber-stamped by Simon Fraser and Sam Weinig.

  • wtf/FeatureDefines.h:
4:01 PM Changeset in webkit [157142] by mihnea@adobe.com
  • 3 edits
    130 moves in trunk/LayoutTests

[CSSRegions] Move autoheight* tests into fast/regions/auto-size
https://bugs.webkit.org/show_bug.cgi?id=122514

Reviewed by Sam Weinig.

Move tests, fix include paths, change TestExpectations when necessary.

  • fast/regions/auto-size/abspos-autoheight-nested-region-expected.txt: Renamed from LayoutTests/fast/regions/abspos-autoheight-nested-region-expected.txt.
  • fast/regions/auto-size/abspos-autoheight-nested-region.html: Renamed from LayoutTests/fast/regions/abspos-autoheight-nested-region.html.
  • fast/regions/auto-size/autoheight-abspos-bottom-align-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-abspos-bottom-align-expected.txt.
  • fast/regions/auto-size/autoheight-abspos-bottom-align.html: Renamed from LayoutTests/fast/regions/autoheight-abspos-bottom-align.html.
  • fast/regions/auto-size/autoheight-abspos-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-abspos-region-expected.html.
  • fast/regions/auto-size/autoheight-abspos-region.html: Renamed from LayoutTests/fast/regions/autoheight-abspos-region.html.
  • fast/regions/auto-size/autoheight-allregions-expected.html: Renamed from LayoutTests/fast/regions/autoheight-allregions-expected.html.
  • fast/regions/auto-size/autoheight-allregions-nobreaks-expected.html: Renamed from LayoutTests/fast/regions/autoheight-allregions-nobreaks-expected.html.
  • fast/regions/auto-size/autoheight-allregions-nobreaks.html: Renamed from LayoutTests/fast/regions/autoheight-allregions-nobreaks.html.
  • fast/regions/auto-size/autoheight-allregions.html: Renamed from LayoutTests/fast/regions/autoheight-allregions.html.
  • fast/regions/auto-size/autoheight-break-after-expected.html: Renamed from LayoutTests/fast/regions/autoheight-break-after-expected.html.
  • fast/regions/auto-size/autoheight-break-after.html: Renamed from LayoutTests/fast/regions/autoheight-break-after.html.
  • fast/regions/auto-size/autoheight-breakafteralways-maxheight-expected.html: Renamed from LayoutTests/fast/regions/autoheight-breakafteralways-maxheight-expected.html.
  • fast/regions/auto-size/autoheight-breakafteralways-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-breakafteralways-maxheight.html.
  • fast/regions/auto-size/autoheight-breakbefore-wrongheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-breakbefore-wrongheight-expected.txt.
  • fast/regions/auto-size/autoheight-breakbefore-wrongheight.html: Renamed from LayoutTests/fast/regions/autoheight-breakbefore-wrongheight.html.
  • fast/regions/auto-size/autoheight-breakbeforealways-expected.html: Renamed from LayoutTests/fast/regions/autoheight-breakbeforealways-expected.html.
  • fast/regions/auto-size/autoheight-breakbeforealways.html: Renamed from LayoutTests/fast/regions/autoheight-breakbeforealways.html.
  • fast/regions/auto-size/autoheight-correct-region-for-lines-2-expected.html: Renamed from LayoutTests/fast/regions/autoheight-correct-region-for-lines-2-expected.html.
  • fast/regions/auto-size/autoheight-correct-region-for-lines-2.html: Renamed from LayoutTests/fast/regions/autoheight-correct-region-for-lines-2.html.
  • fast/regions/auto-size/autoheight-correct-region-for-lines-expected.html: Renamed from LayoutTests/fast/regions/autoheight-correct-region-for-lines-expected.html.
  • fast/regions/auto-size/autoheight-correct-region-for-lines.html: Renamed from LayoutTests/fast/regions/autoheight-correct-region-for-lines.html.
  • fast/regions/auto-size/autoheight-definedheight-changenotdetected-expected.html: Renamed from LayoutTests/fast/regions/autoheight-definedheight-changenotdetected-expected.html.
  • fast/regions/auto-size/autoheight-definedheight-changenotdetected.html: Renamed from LayoutTests/fast/regions/autoheight-definedheight-changenotdetected.html.
  • fast/regions/auto-size/autoheight-dynamic-update-expected.html: Renamed from LayoutTests/fast/regions/autoheight-dynamic-update-expected.html.
  • fast/regions/auto-size/autoheight-dynamic-update.html: Renamed from LayoutTests/fast/regions/autoheight-dynamic-update.html.
  • fast/regions/auto-size/autoheight-firstregion-breakalways-expected.html: Renamed from LayoutTests/fast/regions/autoheight-firstregion-breakalways-expected.html.
  • fast/regions/auto-size/autoheight-firstregion-breakalways.html: Renamed from LayoutTests/fast/regions/autoheight-firstregion-breakalways.html.
  • fast/regions/auto-size/autoheight-flexbox-expected.html: Renamed from LayoutTests/fast/regions/autoheight-flexbox-expected.html.
  • fast/regions/auto-size/autoheight-flexbox.html: Renamed from LayoutTests/fast/regions/autoheight-flexbox.html.
  • fast/regions/auto-size/autoheight-floatright-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-floatright-region-expected.html.
  • fast/regions/auto-size/autoheight-floatright-region.html: Renamed from LayoutTests/fast/regions/autoheight-floatright-region.html.
  • fast/regions/auto-size/autoheight-horizontal-bt-expected.html: Renamed from LayoutTests/fast/regions/autoheight-horizontal-bt-expected.html.
  • fast/regions/auto-size/autoheight-horizontal-bt.html: Renamed from LayoutTests/fast/regions/autoheight-horizontal-bt.html.
  • fast/regions/auto-size/autoheight-inlineblock-normalflow-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-inlineblock-normalflow-region-expected.html.
  • fast/regions/auto-size/autoheight-inlineblock-normalflow-region.html: Renamed from LayoutTests/fast/regions/autoheight-inlineblock-normalflow-region.html.
  • fast/regions/auto-size/autoheight-lastregion-overflowauto-breaksignored-expected.html: Renamed from LayoutTests/fast/regions/autoheight-lastregion-overflowauto-breaksignored-expected.html.
  • fast/regions/auto-size/autoheight-lastregion-overflowauto-breaksignored.html: Renamed from LayoutTests/fast/regions/autoheight-lastregion-overflowauto-breaksignored.html.
  • fast/regions/auto-size/autoheight-lastregion-overflowauto-expected.html: Renamed from LayoutTests/fast/regions/autoheight-lastregion-overflowauto-expected.html.
  • fast/regions/auto-size/autoheight-lastregion-overflowauto.html: Renamed from LayoutTests/fast/regions/autoheight-lastregion-overflowauto.html.
  • fast/regions/auto-size/autoheight-maxheight-mixed-break-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-maxheight-mixed-break-expected.txt.
  • fast/regions/auto-size/autoheight-maxheight-mixed-break.html: Renamed from LayoutTests/fast/regions/autoheight-maxheight-mixed-break.html.
  • fast/regions/auto-size/autoheight-maxheight-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-maxheight-region-expected.html.
  • fast/regions/auto-size/autoheight-maxheight-region.html: Renamed from LayoutTests/fast/regions/autoheight-maxheight-region.html.
  • fast/regions/auto-size/autoheight-maxheight-simple-break-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-maxheight-simple-break-expected.txt.
  • fast/regions/auto-size/autoheight-maxheight-simple-break.html: Renamed from LayoutTests/fast/regions/autoheight-maxheight-simple-break.html.
  • fast/regions/auto-size/autoheight-maxheight-simple-nobreak-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-maxheight-simple-nobreak-expected.txt.
  • fast/regions/auto-size/autoheight-maxheight-simple-nobreak.html: Renamed from LayoutTests/fast/regions/autoheight-maxheight-simple-nobreak.html.
  • fast/regions/auto-size/autoheight-middleregion-expected.html: Renamed from LayoutTests/fast/regions/autoheight-middleregion-expected.html.
  • fast/regions/auto-size/autoheight-middleregion.html: Renamed from LayoutTests/fast/regions/autoheight-middleregion.html.
  • fast/regions/auto-size/autoheight-minheight-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-minheight-region-expected.html.
  • fast/regions/auto-size/autoheight-minheight-region.html: Renamed from LayoutTests/fast/regions/autoheight-minheight-region.html.
  • fast/regions/auto-size/autoheight-minmaxheight-mixed-break-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-expected.txt.
  • fast/regions/auto-size/autoheight-minmaxheight-mixed-break-hbt-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-hbt-expected.txt.
  • fast/regions/auto-size/autoheight-minmaxheight-mixed-break-hbt.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-hbt.html.
  • fast/regions/auto-size/autoheight-minmaxheight-mixed-break-vlr-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-vlr-expected.txt.
  • fast/regions/auto-size/autoheight-minmaxheight-mixed-break-vlr.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-vlr.html.
  • fast/regions/auto-size/autoheight-minmaxheight-mixed-break-vrl-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-vrl-expected.txt.
  • fast/regions/auto-size/autoheight-minmaxheight-mixed-break-vrl.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break-vrl.html.
  • fast/regions/auto-size/autoheight-minmaxheight-mixed-break.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-mixed-break.html.
  • fast/regions/auto-size/autoheight-minmaxheight-simple-break-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-simple-break-expected.txt.
  • fast/regions/auto-size/autoheight-minmaxheight-simple-break.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-simple-break.html.
  • fast/regions/auto-size/autoheight-minmaxheight-simple-nobreak-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-simple-nobreak-expected.txt.
  • fast/regions/auto-size/autoheight-minmaxheight-simple-nobreak.html: Renamed from LayoutTests/fast/regions/autoheight-minmaxheight-simple-nobreak.html.
  • fast/regions/auto-size/autoheight-mixed-nested-complex-regions-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-mixed-nested-complex-regions-expected.txt.
  • fast/regions/auto-size/autoheight-mixed-nested-complex-regions.html: Renamed from LayoutTests/fast/regions/autoheight-mixed-nested-complex-regions.html.
  • fast/regions/auto-size/autoheight-mixed-nested-regions-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-mixed-nested-regions-expected.txt.
  • fast/regions/auto-size/autoheight-mixed-nested-regions.html: Renamed from LayoutTests/fast/regions/autoheight-mixed-nested-regions.html.
  • fast/regions/auto-size/autoheight-mixed-parallel-regions-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-mixed-parallel-regions-expected.txt.
  • fast/regions/auto-size/autoheight-mixed-parallel-regions.html: Renamed from LayoutTests/fast/regions/autoheight-mixed-parallel-regions.html.
  • fast/regions/auto-size/autoheight-nested-regions-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-nested-regions-expected.txt.
  • fast/regions/auto-size/autoheight-nested-regions.html: Renamed from LayoutTests/fast/regions/autoheight-nested-regions.html.
  • fast/regions/auto-size/autoheight-normalflow-region-expected.html: Renamed from LayoutTests/fast/regions/autoheight-normalflow-region-expected.html.
  • fast/regions/auto-size/autoheight-normalflow-region.html: Renamed from LayoutTests/fast/regions/autoheight-normalflow-region.html.
  • fast/regions/auto-size/autoheight-region-decrease-maxheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-maxheight-expected.txt.
  • fast/regions/auto-size/autoheight-region-decrease-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-maxheight.html.
  • fast/regions/auto-size/autoheight-region-decrease-minheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-minheight-expected.txt.
  • fast/regions/auto-size/autoheight-region-decrease-minheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-minheight.html.
  • fast/regions/auto-size/autoheight-region-decrease-width-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-width-expected.txt.
  • fast/regions/auto-size/autoheight-region-decrease-width.html: Renamed from LayoutTests/fast/regions/autoheight-region-decrease-width.html.
  • fast/regions/auto-size/autoheight-region-increase-maxheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-increase-maxheight-expected.txt.
  • fast/regions/auto-size/autoheight-region-increase-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-increase-maxheight.html.
  • fast/regions/auto-size/autoheight-region-increase-minheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-increase-minheight-expected.txt.
  • fast/regions/auto-size/autoheight-region-increase-minheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-increase-minheight.html.
  • fast/regions/auto-size/autoheight-region-increase-width-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-increase-width-expected.txt.
  • fast/regions/auto-size/autoheight-region-increase-width.html: Renamed from LayoutTests/fast/regions/autoheight-region-increase-width.html.
  • fast/regions/auto-size/autoheight-region-new-maxheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-new-maxheight-expected.txt.
  • fast/regions/auto-size/autoheight-region-new-maxheight-vrl-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-new-maxheight-vrl-expected.txt.
  • fast/regions/auto-size/autoheight-region-new-maxheight-vrl.html: Renamed from LayoutTests/fast/regions/autoheight-region-new-maxheight-vrl.html.
  • fast/regions/auto-size/autoheight-region-new-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-new-maxheight.html.
  • fast/regions/auto-size/autoheight-region-new-minheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-new-minheight-expected.txt.
  • fast/regions/auto-size/autoheight-region-new-minheight-vlr-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-new-minheight-vlr-expected.txt.
  • fast/regions/auto-size/autoheight-region-new-minheight-vlr.html: Renamed from LayoutTests/fast/regions/autoheight-region-new-minheight-vlr.html.
  • fast/regions/auto-size/autoheight-region-new-minheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-new-minheight.html.
  • fast/regions/auto-size/autoheight-region-remove-maxheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-remove-maxheight-expected.txt.
  • fast/regions/auto-size/autoheight-region-remove-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-remove-maxheight.html.
  • fast/regions/auto-size/autoheight-region-remove-minheight-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-region-remove-minheight-expected.txt.
  • fast/regions/auto-size/autoheight-region-remove-minheight.html: Renamed from LayoutTests/fast/regions/autoheight-region-remove-minheight.html.
  • fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-regionlayoutupdate-multipletimes-expected.txt.
  • fast/regions/auto-size/autoheight-regionlayoutupdate-multipletimes.html: Renamed from LayoutTests/fast/regions/autoheight-regionlayoutupdate-multipletimes.html.
  • fast/regions/auto-size/autoheight-regions-mark-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-regions-mark-expected.txt.
  • fast/regions/auto-size/autoheight-regions-mark.html: Renamed from LayoutTests/fast/regions/autoheight-regions-mark.html.
  • fast/regions/auto-size/autoheight-secondregion-breakoutside-expected.html: Renamed from LayoutTests/fast/regions/autoheight-secondregion-breakoutside-expected.html.
  • fast/regions/auto-size/autoheight-secondregion-breakoutside.html: Renamed from LayoutTests/fast/regions/autoheight-secondregion-breakoutside.html.
  • fast/regions/auto-size/autoheight-secondregion-expected.html: Renamed from LayoutTests/fast/regions/autoheight-secondregion-expected.html.
  • fast/regions/auto-size/autoheight-secondregion.html: Renamed from LayoutTests/fast/regions/autoheight-secondregion.html.
  • fast/regions/auto-size/autoheight-singleregion-breakafteralways-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakafteralways-expected.html.
  • fast/regions/auto-size/autoheight-singleregion-breakafteralways-maxheight-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakafteralways-maxheight-expected.html.
  • fast/regions/auto-size/autoheight-singleregion-breakafteralways-maxheight.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakafteralways-maxheight.html.
  • fast/regions/auto-size/autoheight-singleregion-breakafteralways.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakafteralways.html.
  • fast/regions/auto-size/autoheight-singleregion-breakaftermargin-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakaftermargin-expected.html.
  • fast/regions/auto-size/autoheight-singleregion-breakaftermargin.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakaftermargin.html.
  • fast/regions/auto-size/autoheight-singleregion-breakbeforealways-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakbeforealways-expected.html.
  • fast/regions/auto-size/autoheight-singleregion-breakbeforealways-minheight-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakbeforealways-minheight-expected.html.
  • fast/regions/auto-size/autoheight-singleregion-breakbeforealways-minheight.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakbeforealways-minheight.html.
  • fast/regions/auto-size/autoheight-singleregion-breakbeforealways.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-breakbeforealways.html.
  • fast/regions/auto-size/autoheight-singleregion-multiplebreaks-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-multiplebreaks-expected.html.
  • fast/regions/auto-size/autoheight-singleregion-multiplebreaks.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-multiplebreaks.html.
  • fast/regions/auto-size/autoheight-singleregion-overflowauto-breaksignored-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-overflowauto-breaksignored-expected.html.
  • fast/regions/auto-size/autoheight-singleregion-overflowauto-breaksignored.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-overflowauto-breaksignored.html.
  • fast/regions/auto-size/autoheight-singleregion-overflowauto-expected.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-overflowauto-expected.html.
  • fast/regions/auto-size/autoheight-singleregion-overflowauto.html: Renamed from LayoutTests/fast/regions/autoheight-singleregion-overflowauto.html.
  • fast/regions/auto-size/autoheight-two-pass-layout-complex-001-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-two-pass-layout-complex-001-expected.txt.
  • fast/regions/auto-size/autoheight-two-pass-layout-complex-001.html: Renamed from LayoutTests/fast/regions/autoheight-two-pass-layout-complex-001.html.
  • fast/regions/auto-size/autoheight-two-pass-layout-complex-002-expected.txt: Renamed from LayoutTests/fast/regions/autoheight-two-pass-layout-complex-002-expected.txt.
  • fast/regions/auto-size/autoheight-two-pass-layout-complex-002.html: Renamed from LayoutTests/fast/regions/autoheight-two-pass-layout-complex-002.html.
  • fast/regions/auto-size/autoheight-vertical-lr-expected.html: Renamed from LayoutTests/fast/regions/autoheight-vertical-lr-expected.html.
  • fast/regions/auto-size/autoheight-vertical-lr.html: Renamed from LayoutTests/fast/regions/autoheight-vertical-lr.html.
  • fast/regions/auto-size/autoheight-vertical-rl-expected.html: Renamed from LayoutTests/fast/regions/autoheight-vertical-rl-expected.html.
  • fast/regions/auto-size/autoheight-vertical-rl.html: Renamed from LayoutTests/fast/regions/autoheight-vertical-rl.html.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
3:40 PM Changeset in webkit [157141] by ggaren@apple.com
  • 4 edits in trunk/Websites/webkit.org

Refined power management in SunSpider 1.0.2
https://bugs.webkit.org/show_bug.cgi?id=122525

Reviewed by Gavin Barraclough.

Sync'd sunspider-1.0.2 to PerformanceTests/SunSpider/hosted/sunspider-1.0.2.

  • perf/sunspider-1.0.2/sunspider-1.0.2/driver.html:
  • perf/sunspider-1.0.2/sunspider-1.0.2/sunspider-test-contents.js:
  • perf/sunspider-1.0.2/sunspider.css:

(#frameparent):
(#countdown):

3:40 PM Changeset in webkit [157140] by ggaren@apple.com
  • 4 edits in trunk/PerformanceTests/SunSpider

Refined power management in SunSpider 1.0.2
https://bugs.webkit.org/show_bug.cgi?id=122525

Reviewed by Gavin Barraclough.

  • hosted/sunspider.css:

(#frameparent):
(#countdown):

  • resources/TEMPLATE.html: Provide an explicit countdown element in the

parent, instead of hacking it into each child frame.

  • resources/driver-TEMPLATE.html: Be more explicit about how we respond

to power management. Just moving setTimeout(0) inside the loop is a
little too subtle, and may not work across browsers.

Also, leave a little extra time after changing the countdown graphic,
to give the browser some time to paint.

2:57 PM Changeset in webkit [157139] by dino@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed followup to https://bugs.webkit.org/show_bug.cgi?id=122523
This test now passes, so updating expected file.

  • fast/canvas/webgl/webgl-unprefixed-context-id-expected.txt:
2:17 PM Changeset in webkit [157138] by dino@apple.com
  • 4 edits
    2 adds in trunk

Support unprefixed WebGL context creation
https://bugs.webkit.org/show_bug.cgi?id=122523
<rdar://problem/15179463>

Reviewed by Simon Fraser.

Source/WebCore:

Add support for the unprefixed "webgl" canvas context type.

Test: fast/canvas/webgl/unprefixed-context.html

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::is3dType):

  • inspector/InjectedScriptCanvasModuleSource.js:

LayoutTests:

Tests that we can create a context without the
"experimental-" prefix. Meanwhile, most of the other
WebGL tests should start to use the unprefixed
form automatically (the helper script attempts
"webgl" first).

  • fast/canvas/webgl/unprefixed-context-expected.txt: Added.
  • fast/canvas/webgl/unprefixed-context.html: Added.
2:05 PM Changeset in webkit [157137] by andersca@apple.com
  • 15 edits in trunk/Source/WebKit2

WebProcess crash on SAP WebCycle web app
https://bugs.webkit.org/show_bug.cgi?id=122520
<rdar://problem/15030605>

Reviewed by Darin Adler.

Stop trying to use RunLoop to manage the top-level run loop and just have the child process and their
delegate subclasses start and stop the run loops. This fixes a bug with showModalDialog where we would
unintentionally call -[NSApp stop] when closing a modal dialog.

This also lets us move all knowledge of NSApplication from RunLoop. (Both the web process and plug-in process
need to use -[NSApp run] and -[NSApp stop:]).

  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:

(WebKit::PluginProcessMainDelegate::doPreInitializationWork):
Remove call to RunLoop::setUseApplicationRunLoopOnMainRunLoop. Add a startRunLoop override that calls
-[NSApp run].

  • PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:

(PluginServiceInitializer):
Remove call to RunLoop::setUseApplicationRunLoopOnMainRunLoop.

  • PluginProcess/PluginProcess.h:

Add stopRunLoop() override on Mac.

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::stopRunLoop):
Call -[NSApp stop:] and tickle the event system.

  • Shared/ChildProcess.cpp:

(WebKit::ChildProcess::stopRunLoop):
Add default implementation that just calls RunLoop::main()->stop().

(WebKit::ChildProcess::terminate):
Call stopRunLoop().

  • Shared/ChildProcess.h:
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h:

Add startRunLoop member function and call it instead of RunLoop::run().

  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.mm:

(WebKit::ChildProcessMainDelegate::startRunLoop):
Call RunLoop::run().

  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:

(WebKit::WebContentProcessMainDelegate::doPreInitializationWork):
Remove call to RunLoop::setUseApplicationRunLoopOnMainRunLoop.
Add startRunLoop override that calls -[NSApp run].

  • WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:

(WebContentServiceInitializer):
Remove call to RunLoop::setUseApplicationRunLoopOnMainRunLoop.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didClose):
Call stopRunLoop().

  • WebProcess/WebProcess.h:

Add stopRunLoop override.

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::stopRunLoop):
Call -[NSApp stop:] and tickle the event system.

1:58 PM Changeset in webkit [157136] by rniwa@webkit.org
  • 18 edits in trunk/Source/WebCore

Rename EventDispatchMediator::dispatchEvent to mediateAndDispatchEvent
https://bugs.webkit.org/show_bug.cgi?id=122522

Reviewed by Darin Adler.

Renamed EventDispatchMediator::dispatchEvent to EventDispatchMediator::mediateAndDispatchEvent
to make the future refactoring easier.

  • Modules/indieui/UIRequestEvent.cpp:

(WebCore::UIRequestEventDispatchMediator::mediateAndDispatchEvent):

  • Modules/indieui/UIRequestEvent.h:
  • dom/EventDispatchMediator.cpp:

(WebCore::EventDispatchMediator::mediateAndDispatchEvent):

  • dom/EventDispatchMediator.h:
  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

  • dom/FocusEvent.cpp:

(WebCore::FocusEventDispatchMediator::mediateAndDispatchEvent):
(WebCore::BlurEventDispatchMediator::mediateAndDispatchEvent):
(WebCore::FocusInEventDispatchMediator::mediateAndDispatchEvent):
(WebCore::FocusOutEventDispatchMediator::mediateAndDispatchEvent):

  • dom/FocusEvent.h:
  • dom/GestureEvent.cpp:

(WebCore::GestureEventDispatchMediator::mediateAndDispatchEvent):

  • dom/GestureEvent.h:
  • dom/KeyboardEvent.cpp:

(WebCore::KeyboardEventDispatchMediator::mediateAndDispatchEvent):

  • dom/KeyboardEvent.h:
  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::mediateAndDispatchEvent):

  • dom/MouseEvent.h:
  • dom/TouchEvent.cpp:

(WebCore::TouchEventDispatchMediator::mediateAndDispatchEvent):

  • dom/TouchEvent.h:
  • dom/WheelEvent.cpp:

(WebCore::WheelEventDispatchMediator::mediateAndDispatchEvent):

  • dom/WheelEvent.h:
1:42 PM Changeset in webkit [157135] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[MathML] Use of floating point floor/ceil on LayoutUnits seems wrong
https://bugs.webkit.org/show_bug.cgi?id=122367

Reviewed by Darin Adler.

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::paintCharacter): Use member methods to compute
correct floor/ceil values for LayoutUnits.

1:38 PM Changeset in webkit [157134] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skip a new WebGL test along with the others.

  • platform/gtk/TestExpectations:
1:34 PM Changeset in webkit [157133] by dino@apple.com
  • 3 edits
    2 adds in trunk

Video -> pixel buffer output should not manage color spaces
https://bugs.webkit.org/show_bug.cgi?id=122486

Reviewed by Tim Horton.

Source/WebCore:

On Mac, when we draw a video into a canvas or WebGL, the
output of the video should not be color managed. Instead, leave it
as DeviceRGB so that it matches other colors in those elements.
We'll hopefully solve this properly soon - making everything sRGB.

Test: media/video-canvas-drawing-output.html

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createImageForTimeInRect): Pass on
a CGImageRef via CGImageCreateCopyWithColorSpace rather than the raw data.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput): Tell CoreImage
to allocate a pixel buffer that is unmanaged.

LayoutTests:

  • media/video-canvas-drawing-output-expected.txt: Added.
  • media/video-canvas-drawing-output.html: Added.
1:30 PM Changeset in webkit [157132] by lauro.neto@openbossa.org
  • 2 edits in trunk/Source/WebCore

[MediaStream] Fix segfault in initializeMockSources()
https://bugs.webkit.org/show_bug.cgi?id=122517

Reviewed by Darin Adler.

Calling release() and a member function on the same RefPtr
as arguments to a function can lead to segfaults if the release
call is evaluated first.

  • platform/mock/MockMediaStreamCenter.cpp:

(WebCore::initializeMockSources):

1:26 PM Changeset in webkit [157131] by mark.lam@apple.com
  • 3 edits in trunk/Tools

Fix ruby LoadError when running run-javascriptcore-tests.
https://bugs.webkit.org/show_bug.cgi?id=122519.

Reviewed by Mark Hahnenberg.

The scripts needed to explicitly require 'rubygems' for older versions of ruby
(versions before 1.9).

  • Scripts/jsc-stress-test-helpers/profiler-test-helper:
  • Scripts/run-jsc-stress-tests:
1:25 PM Changeset in webkit [157130] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/gtk/TestExpectations: fast/backgrounds/background-opaque-images-over-color.html

failing.

1:03 PM Changeset in webkit [157129] by mihnea@adobe.com
  • 4 edits in trunk

[CSSRegions] Regions with overflow: hidden should paint over positioned sibling
https://bugs.webkit.org/show_bug.cgi?id=122389

Reviewed by Alexandru Chiculita.

Source/WebCore:

As a follow-up from https://bugs.webkit.org/show_bug.cgi?id=122321, a region should not
be a normal flow layer when it has overflow clip. Change existing test by adding overflow:hidden
to the region element.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeNormalFlowOnly):

LayoutTests:

Add overflow: hidden to the region to test that it does not move to the normal flow layers.

  • fast/regions/layers/region-normalflow-stacking-context.html:
12:58 PM Changeset in webkit [157128] by kov@webkit.org
  • 4 edits in trunk/LayoutTests

Unreviewed gardening, these tests had a couple pixels shift at some point,
needing a new baseline.

  • platform/gtk/fast/hidpi/clip-text-in-hidpi-expected.txt:
  • platform/gtk/fast/hidpi/image-set-background-dynamic-expected.txt:
  • platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt:
12:44 PM Changeset in webkit [157127] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Simplify the loop in EventRetargeter::calculateEventPath
https://bugs.webkit.org/show_bug.cgi?id=122500

Reviewed by Antti Koivisto.

Replaced the convoluted loop by two nested loops to make semantics clear.

  • dom/EventRetargeter.cpp:

(WebCore::EventRetargeter::calculateEventPath):

12:27 PM Changeset in webkit [157126] by g.czajkowski@samsung.com
  • 2 edits in trunk/LayoutTests

[Mac] Unskip editing/spelling/spelling-changed-text.html
https://bugs.webkit.org/show_bug.cgi?id=122502

Unreviewed gardening.

  • platform/mac/TestExpectations:

spelling-changed.html is passing after r156901.

12:13 PM Changeset in webkit [157125] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. A couple of media-query tests rely on 3d transforms,
so skip them along with the 3d transforms tests.

  • platform/gtk/TestExpectations:
11:25 AM Changeset in webkit [157124] by ChangSeok Oh
  • 2 edits in trunk/Source/WebCore

[GTK] Leak: GdkEvent retured by gtk_get_current_event is not freed.
https://bugs.webkit.org/show_bug.cgi?id=122506

Reviewed by Gustavo Noronha Silva.

Gdk event returned by gtk_get_current_event should be freed after using it.

No functionality changed.

  • platform/gtk/PopupMenuGtk.cpp:

(WebCore::PopupMenuGtk::show):

11:03 AM Changeset in webkit [157123] by rniwa@webkit.org
  • 6 edits in trunk/Source/WebCore

Use references in EventRetargeter::calculateEventPath and EventRetargeter::eventTargetRespectingTargetRules
https://bugs.webkit.org/show_bug.cgi?id=122494

Reviewed by Antti Koivisto.

Use referenecs instead of pointers in ventRetargeter's calculateEventPath and eventTargetRespectingTargetRules.
Also replace Vector<EventTarget*, 32> targetStack by a single pointer since we only append an item to
the vector when it's empty and we always use the last item.

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatchScopedEvent):
(WebCore::EventDispatcher::dispatch):
(WebCore::EventDispatcher::dispatchEventPostProcess):

  • dom/EventDispatcher.h:
  • dom/EventRetargeter.cpp:

(WebCore::EventRetargeter::calculateEventPath):

  • dom/EventRetargeter.h:

(WebCore::EventRetargeter::eventTargetRespectingTargetRules):

  • dom/Node.cpp:

(WebCore::Node::dispatchScopedEventDispatchMediator):

10:59 AM Changeset in webkit [157122] by Christophe Dumez
  • 2 edits in trunk/Tools

Unreviewed, add my new email to contributors.json.

Patch by Christophe Dumez <Christophe Dumez> on 2013-10-08

  • Scripts/webkitpy/common/config/contributors.json:
10:33 AM Changeset in webkit [157121] by mihnea@adobe.com
  • 8 edits
    2 adds in trunk

[CSSRegions] Computed z-Index should return 0 instead of auto for a region
https://bugs.webkit.org/show_bug.cgi?id=122405

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/layers/region-zIndex-computedStyle.html

Adjust the z-index value for a region. Also, since a box with a z-Index
that is non-auto receives a layer, i removed the requiresLayer override
in RenderRegion and RenderMultiColumnSet.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

  • rendering/RenderMultiColumnSet.cpp:
  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderRegion.cpp:
  • rendering/RenderRegion.h:
  • rendering/style/RenderStyle.h:

LayoutTests:

  • fast/regions/layers/region-zIndex-computedStyle-expected.txt: Added.
  • fast/regions/layers/region-zIndex-computedStyle.html: Added.
10:33 AM Changeset in webkit [157120] by abucur@adobe.com
  • 5 edits
    2 adds in trunk

[CSS Regions] Widows don't work if the first line in a region is aligned with the top of the region
https://bugs.webkit.org/show_bug.cgi?id=122450

Reviewed by David Hyatt.

Source/WebCore:

The patch adds a new function updateRegionForLine that updates the containing region for a line and the
flag used to determine if it's the first line in that region. This is necessary because the code in
adjustLinePositionForPagination is not sufficient to determine when an unforced break occurs and the line
being positioned is the first one in the fragmentation container or not.

Test: fast/regions/regions-widows-float-top-aligned.html

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustLinePositionForPagination): Added FIXME comment.

  • rendering/RenderBlockFlow.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlockFlow::updateRegionForLine): New function used to update the containing region and
the first line flag.

LayoutTests:

Simple test veryfing that widows are correctly computed when there is a float affecting the lines
and when they are vertically aligned with the regions height.

  • fast/regions/regions-widows-float-top-aligned-expected.html: Added.
  • fast/regions/regions-widows-float-top-aligned.html: Added.
10:25 AM Changeset in webkit [157119] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

JSManagedValue should be able to store non-object JSValues
https://bugs.webkit.org/show_bug.cgi?id=122351

Reviewed by Oliver Hunt.

We decided not to support this because we thought it didn't make sense to have a
"weak" JSValue that wasn't an object.

Our general thought process was if you have a JSObject-ObjC object pair (i.e. an
Obj-C object that you exported to JavaScript-land), it makes more sense to store
a non-object JSValue on the JavaScript-land version of the object rather than as
an ivar in the Objective-C object.

In retrospect, this may not have been a good decision at least w.r.t. consistency
in client code. If you're storing a bag of JSValues off an Obj-C object, you'd
like to store all of them either in ObjC-land or JavaScript-land, but doing some
in one and some in the other doesn't sound too good. Also, what if the object you
want to hang these values off of doesn't have a corresponding object in JavaScript-
land in which to store them?

The solution is to fix JSManagedValue to be able to reference non-object JSValues.
Right now, all JSManagedValues contain a Weak<JSObject>. We'll change this so that
they can contain either a non-cell JSValue or a JSObject*, along with a weak
reference to the JSGlobalObject for reconstructing a JSValue later on.

  • API/JSManagedValue.mm:

(PrimitiveOrObject::PrimitiveOrObject):
(PrimitiveOrObject::~PrimitiveOrObject):
(PrimitiveOrObject::clear):
(PrimitiveOrObject::isClear):
(PrimitiveOrObject::isSet):
(PrimitiveOrObject::isPrimitive):
(PrimitiveOrObject::isObject):
(PrimitiveOrObject::setPrimitive):
(PrimitiveOrObject::setObject):
(PrimitiveOrObject::object):
(PrimitiveOrObject::primitive):
(-[JSManagedValue initWithValue:]):
(-[JSManagedValue value]):
(-[JSManagedValue disconnectValue]):

10:16 AM Changeset in webkit [157118] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Adding ImageOnlyFailure expectations to:

  • fast/regions/selection/selecting-text-ignoring-region-horiz-bt.html
  • fast/regions/selection/selecting-text-ignoring-region-vert-lr.html
  • fast/regions/selection/selecting-text-in-2-regions-horiz-bt.html
  • fast/regions/selection/selecting-text-in-2-regions-vert-lr.html
  • platform/gtk/TestExpectations:
10:12 AM Changeset in webkit [157117] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test inspector/styles/add-new-rule-with-style-after-body.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122510

  • platform/mac/TestExpectations: Marking as such.
10:05 AM Changeset in webkit [157116] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test inspector/debugger/debugger-activation-crash2.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122509

  • platform/mac/TestExpectations: Marking as such.
9:52 AM Changeset in webkit [157115] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test compositing/video/video-reflection.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122508

  • platform/mac/TestExpectations: Marking as such.
9:47 AM Changeset in webkit [157114] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test media/track/track-cue-rendering.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122507

  • platform/mac/TestExpectations: Marking as such.
9:43 AM Changeset in webkit [157113] by kov@webkit.org
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed, rolling out r157080.
http://trac.webkit.org/changeset/157080

Not a proper baseline

  • platform/gtk/fast/regions/selection/selecting-text-ignoring-region-horiz-bt-expected.png: Removed.
  • platform/gtk/fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.png: Removed.
  • platform/gtk/fast/regions/selection/selecting-text-in-2-regions-horiz-bt-expected.png: Removed.
  • platform/gtk/fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.png: Removed.
9:42 AM Changeset in webkit [157112] by Brent Fulgham
  • 2 edits in trunk/Tools

Unreviewed build correction.

  • Scripts/webkitpy/port/win.py:

(WinPort.write_registry_value): Use string representation of error message to avoid
format conversion problem.

9:38 AM Changeset in webkit [157111] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Flaky Test: media/video-layer-crash.html
https://bugs.webkit.org/show_bug.cgi?id=114744

  • platform/mac/TestExpectations: Marking as such.
9:36 AM Changeset in webkit [157110] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Get EFL and GTK compiling with media stream enabled
https://bugs.webkit.org/show_bug.cgi?id=122505

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-08
Reviewed by Philippe Normand.

After r157068

No new tests needed.

  • GNUmakefile.list.am:
  • UseJSC.cmake:
9:31 AM Changeset in webkit [157109] by Darin Adler
  • 3 edits in trunk/Source/WebKit/mac

WebNetscapePluginView should no longer use deleteAllValues
https://bugs.webkit.org/show_bug.cgi?id=122495

Reviewed by Anders Carlsson.

  • Plugins/WebNetscapePluginView.h: Use unique_ptr for both the pointer to

the timers hash table, and for the values in the hash table.

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView stopTimers]): Rewrote loop so it works with unique_ptr.
(-[WebNetscapePluginView startTimers]): Ditto.
(-[WebNetscapePluginView fini]): Removed unneeded code to delete timers.
(-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]): Make
the timers hash table with make-unique. Fixed the loop that chooses the timer
ID so it won't ever try to use a deleted value, although that never happens
in practice. Use HashMap::add instead of using both contains and set.
Rearranged code so we don't need to make a raw pointer for the timer.
(-[WebNetscapePluginView unscheduleTimer:]): Use remove instead of take/delete,
since remove takes care of the deletion automatically since we are using the
unique_ptr class.

8:56 AM Changeset in webkit [157108] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Composited layer that painted into composited ancestor is not repainted after moving
https://bugs.webkit.org/show_bug.cgi?id=114655

Patch by Hurnjoo Lee <hurnjoo.lee@samsung.com> on 2013-10-08
Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/repaint/absolute-painted-into-composited-ancestor.html

Composited layers are currently skipping repainting after layout,
if the repaint status is not NeedsFullRepaint. However, in case layers
were painted into composited ancestor, they need to repaint.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldRepaintAfterLayout):

LayoutTests:

Add a text repaint test to check the repainting of composited layer
that painted into composited ancestor.

  • compositing/repaint/absolute-painted-into-composited-ancestor-expected.txt: Added.
  • compositing/repaint/absolute-painted-into-composited-ancestor.html: Added.
8:51 AM Changeset in webkit [157107] by Brent Fulgham
  • 3 edits in trunk/Tools

[Win] Add checks for proper build and test environment
https://bugs.webkit.org/show_bug.cgi?id=122466

Reviewed by Darin Adler.

This patch makes two changes:

  1. Update webkitdirs.pm to check for some common misconfigurations and provide helpful warnings or error messages so that people know what to fix to get things working.
  2. Modify the win.py port to handle the 32-bit and 64-bit test environments, as well as making sure the various environment settings are properly configured for our test environment.
  • Scripts/webkitdirs.pm:

(checkInstalledTools): Add checks for some common Cygwin configuration problems that have
caused problems in the past.
(setupAppleWinEnv):

  • Scripts/webkitpy/port/win.py:

(WinPort):
(WinPort.read_registry_string): Parameterize for run architecture and registry root.
(WinPort.write_registry_value): Parameterize registry writing by data type (string versus
DWORD, etc.)
(WinPort.write_registry_string): Revise to call new generic registry write function.
(WinPort.setup_crash_log_saving): Revise for new API
(WinPort.restore_crash_log_saving): Ditto
(WinPort.prevent_error_dialogs): Add new methods to prevent Windows dialogs that block our test
servers from running.
(WinPort.allow_error_dialogs): Ditto.
(WinPort.setup_test_run): Call new API to turn off user input dialogs on program failure.
(WinPort.clean_up_test_run): Call new API to reactivatea user input dialogs after test run finished.

8:45 AM Changeset in webkit [157106] by Philippe Normand
  • 2 edits in trunk/Tools

[GStreamer] enable v4l2 plugin
https://bugs.webkit.org/show_bug.cgi?id=122503

Reviewed by Martin Robinson.

  • gtk/jhbuild.modules: Enable the plugin, it now builds fine since

we updated our GStreamer version to 1.0.8.

8:28 AM Changeset in webkit [157105] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Unreviewed, rolling out r157090.
http://trac.webkit.org/changeset/157090
https://bugs.webkit.org/show_bug.cgi?id=122504

Caused crashes in many plug-in tests (Requested by ap on
#webkit).

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::registerNPObject):
(WebKit::NPRemoteObjectMap::pluginDestroyed):

  • Shared/Plugins/NPRemoteObjectMap.h:
8:15 AM Changeset in webkit [157104] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] Re-enable MathML for release builds
https://bugs.webkit.org/show_bug.cgi?id=122361

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-10-08
Reviewed by Darin Adler.

  • Source/autotools/SetupWebKitFeatures.m4: Enable MathML for release builds.
8:12 AM Changeset in webkit [157103] by Lucas Forschler
  • 5 edits in tags/Safari-538.1.3/Source

Versioning.

8:10 AM Changeset in webkit [157102] by Lucas Forschler
  • 1 copy in tags/Safari-538.1.3

New Tag.

7:56 AM Changeset in webkit [157101] by Darin Adler
  • 3 edits in trunk/Source/WebKit/mac

Eliminate use of deleteAllValues in ProxyInstance
https://bugs.webkit.org/show_bug.cgi?id=122499

Reviewed by Anders Carlsson.

  • Plugins/Hosted/ProxyInstance.h: Use unique_ptr for map values in m_fields and m_methods.
  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::~ProxyInstance): Removed calls to deleteAllValues.
(WebKit::ProxyInstance::methodNamed): Use make_unique and get to deal with map entries
that are unique_ptr. Also fixed a bug where this would do an expensive no-op if the map
already had an entry with a null in it. We would call the plug-in, but eventually
isNewEntry would be false so we would return null.
(WebKit::ProxyInstance::fieldNamed): Use make_unique and get to deal with map entries
that are unique_ptr.

7:39 AM Changeset in webkit [157100] by Alan Bujtas
  • 5 edits
    2 deletes in trunk

Unreviewed. Rollout of r156536. ~5% regression in inline layout performance.

Source/WebCore:

  • rendering/LineWidth.cpp:
  • rendering/LineWidth.h:

(WebCore::LineWidth::addUncommittedWidth):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineBreaker::nextSegmentBreak):

LayoutTests:

  • fast/css/unexpected-word-wrapping-with-non-empty-spans-expected.html: Removed.
  • fast/css/unexpected-word-wrapping-with-non-empty-spans.html: Removed.
5:57 AM Changeset in webkit [157099] by Michał Pakuła vel Rutka
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening

Unskip tests that are already passing.

  • platform/efl-wk1/TestExpectations: Mark unskipped test as failing for WK1.
  • platform/efl/TestExpectations:
5:07 AM Changeset in webkit [157098] by gyuyoung.kim@samsung.com
  • 12 edits in trunk/Source/WebCore

Use toCSSFooValue() instead of using static_cast<const CSSFooValue*>
https://bugs.webkit.org/show_bug.cgi?id=122491

Reviewed by Andreas Kling.

static_cast<const CSSFooValue*> wasn't cleanup. So, we need to use toCSSFooValue() for it.
To use toCSSValue() will help to detect bad type-cast.

Besides static_cast<const WebKitCSSFooValue*> helper functions need to be added to support this use.

No new tests, no behavior change.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyMatches):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::isFixedSize):
(WebCore::CSSImageGeneratorValue::isPending):
(WebCore::CSSImageGeneratorValue::knownToBeOpaque):

  • css/CSSValue.cpp:

(WebCore::CSSValue::isImplicitInitialValue):
(WebCore::CSSValue::addSubresourceStyleURLs):
(WebCore::CSSValue::hasFailedOrCanceledSubresources):
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::serializeResolvingVariables):
(WebCore::CSSValue::cloneForCSSOM):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::PropertyReference::cssName):

  • css/WebKitCSSSVGDocumentValue.h:

(WebCore::toWebKitCSSSVGDocumentValue):

  • css/WebKitCSSTransformValue.h:

(WebCore::toWebKitCSSTransformValue):

4:39 AM Changeset in webkit [157097] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Get MediaStreamCenterGStreamer compiling again
https://bugs.webkit.org/show_bug.cgi?id=122482

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-08
Reviewed by Eric Carlson.

r157068 was including a nonexistent header

No new tests needed.

  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
3:55 AM Changeset in webkit [157096] by mario@webkit.org
  • 5 edits in trunk

[ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
https://bugs.webkit.org/show_bug.cgi?id=122104

Reviewed by Chris Fleizach.

Source/WebCore:

Map invalid state of an AccessibilityObject to the proper AtkState.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(setAtkStateSetFromCoreObject): Add the mapping.

Tools:

Updated stringAttributeValue to double check that the exposure of
aria-invalid as a state is consistent with its exposure as a text
attribute as well, when it applies (implementations of AtkText).

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::stringAttributeValue): Add double check.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::stringAttributeValue): Ditto.

3:45 AM Changeset in webkit [157095] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Name for tables are now properly showing
up when exposing information for the parent of a table's cell.

  • platform/gtk/accessibility/table-cells-expected.txt: Updated.
2:56 AM Changeset in webkit [157094] by g.czajkowski@samsung.com
  • 12 edits in trunk/LayoutTests

context-menu-suggestions-multiword-selection.html and context-menu-suggestions-subword-selection.html are flaky after r156901
https://bugs.webkit.org/show_bug.cgi?id=122414

Reviewed by Ryosuke Niwa.

On Mac, first call of 'initSpellTest' from spelling/resources/util.js
often fails while checking spelling marker.
Use shouldBecomeDifferent instead of calling timers in the tests.
It should have been done at r156137 when shouldBecomeEqual/Different
was used in asynchronous spell checking tests.

  • editing/spelling/resources/util.js:

Use shouldBecomeDifferent instead of timers.

  • editing/spelling/context-menu-suggestions-multiword-selection-expected.txt:
  • editing/spelling/context-menu-suggestions-subword-selection-expected.txt:
  • editing/spelling/spelling-changed-text-expected.txt:
  • editing/spelling/spelling-double-clicked-word-expected.txt:
  • editing/spelling/spelling-exactly-selected-multiple-words-expected.txt:
  • editing/spelling/spelling-exactly-selected-word-expected.txt:
  • editing/spelling/spelling-should-select-multiple-words-expected.txt:
  • editing/spelling/spelling-with-punctuation-selection-expected.txt:
  • editing/spelling/spelling-with-whitespace-selection-expected.txt:

Rebaseline the tests which include util.js due to
shouldBecomeDifferent outputs more logs.

  • platform/mac/TestExpectations:

Now context-menu-suggestions-multiword-selection.html and
context-menu-suggestions-subword-selection.html are passing for Mac.

2:41 AM Changeset in webkit [157093] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

JavaScriptCore fails to build
https://bugs.webkit.org/show_bug.cgi?id=122440

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-10-08
Reviewed by Darin Adler.

Compilation fails in debug due to 'comparison of unsigned expression >= 0 is
always true'.

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::positionForCallFrame): Removed the offending ASSERTS.

2:01 AM Changeset in webkit [157092] by mihnea@adobe.com
  • 1 edit
    32 moves
    1 add in trunk/LayoutTests

[CSSRegions] Move autosize and autowidth tests into fast/regions/auto-size
https://bugs.webkit.org/show_bug.cgi?id=122493

Reviewed by Andreas Kling.

Simple move, changed paths in 2 tests.

  • fast/regions/auto-size/autosize-abspos-anchoredregion-expected.txt: Renamed from LayoutTests/fast/regions/autosize-abspos-anchoredregion-expected.txt.
  • fast/regions/auto-size/autosize-abspos-anchoredregion-vertlr-expected.txt: Renamed from LayoutTests/fast/regions/autosize-abspos-anchoredregion-vertlr-expected.txt.
  • fast/regions/auto-size/autosize-abspos-anchoredregion-vertlr.html: Renamed from LayoutTests/fast/regions/autosize-abspos-anchoredregion-vertlr.html.
  • fast/regions/auto-size/autosize-abspos-anchoredregion.html: Renamed from LayoutTests/fast/regions/autosize-abspos-anchoredregion.html.
  • fast/regions/auto-size/autosize-region-container-resize-expected.html: Renamed from LayoutTests/fast/regions/autosize-region-container-resize-expected.html.
  • fast/regions/auto-size/autosize-region-container-resize.html: Renamed from LayoutTests/fast/regions/autosize-region-container-resize.html.
  • fast/regions/auto-size/autosize-region-window-resize-expected.html: Renamed from LayoutTests/fast/regions/autosize-region-window-resize-expected.html.
  • fast/regions/auto-size/autosize-region-window-resize.html: Renamed from LayoutTests/fast/regions/autosize-region-window-resize.html.
  • fast/regions/auto-size/autowidth-abspos-expected.html: Renamed from LayoutTests/fast/regions/autowidth-abspos-expected.html.
  • fast/regions/auto-size/autowidth-abspos-regionchain-expected.html: Renamed from LayoutTests/fast/regions/autowidth-abspos-regionchain-expected.html.
  • fast/regions/auto-size/autowidth-abspos-regionchain.html: Renamed from LayoutTests/fast/regions/autowidth-abspos-regionchain.html.
  • fast/regions/auto-size/autowidth-abspos.html: Renamed from LayoutTests/fast/regions/autowidth-abspos.html.
  • fast/regions/auto-size/autowidth-attachedinvalidregion-expected.txt: Renamed from LayoutTests/fast/regions/autowidth-attachedinvalidregion-expected.txt.
  • fast/regions/auto-size/autowidth-attachedinvalidregion.html: Renamed from LayoutTests/fast/regions/autowidth-attachedinvalidregion.html.
  • fast/regions/auto-size/autowidth-float-expected.html: Renamed from LayoutTests/fast/regions/autowidth-float-expected.html.
  • fast/regions/auto-size/autowidth-float.html: Renamed from LayoutTests/fast/regions/autowidth-float.html.
  • fast/regions/auto-size/autowidth-inlineblock-expected.html: Renamed from LayoutTests/fast/regions/autowidth-inlineblock-expected.html.
  • fast/regions/auto-size/autowidth-inlineblock.html: Renamed from LayoutTests/fast/regions/autowidth-inlineblock.html.
  • fast/regions/auto-size/autowidth-nonreplaced-abspos-expected.html: Renamed from LayoutTests/fast/regions/autowidth-nonreplaced-abspos-expected.html.
  • fast/regions/auto-size/autowidth-nonreplaced-abspos.html: Renamed from LayoutTests/fast/regions/autowidth-nonreplaced-abspos.html.
  • fast/regions/auto-size/autowidth-nonreplacedblock-normalflow-expected.html: Renamed from LayoutTests/fast/regions/autowidth-nonreplacedblock-normalflow-expected.html.
  • fast/regions/auto-size/autowidth-nonreplacedblock-normalflow.html: Renamed from LayoutTests/fast/regions/autowidth-nonreplacedblock-normalflow.html.
  • fast/regions/auto-size/autowidth-normalflow-expected.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-expected.html.
  • fast/regions/auto-size/autowidth-normalflow-maxwidth-expected.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-maxwidth-expected.html.
  • fast/regions/auto-size/autowidth-normalflow-maxwidth.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-maxwidth.html.
  • fast/regions/auto-size/autowidth-normalflow-minmaxwidth-expected.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-minmaxwidth-expected.html.
  • fast/regions/auto-size/autowidth-normalflow-minmaxwidth.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-minmaxwidth.html.
  • fast/regions/auto-size/autowidth-normalflow-minwidth-expected.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-minwidth-expected.html.
  • fast/regions/auto-size/autowidth-normalflow-minwidth.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-minwidth.html.
  • fast/regions/auto-size/autowidth-normalflow-vertrl-expected.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-vertrl-expected.html.
  • fast/regions/auto-size/autowidth-normalflow-vertrl.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow-vertrl.html.
  • fast/regions/auto-size/autowidth-normalflow.html: Renamed from LayoutTests/fast/regions/autowidth-normalflow.html.
1:07 AM Changeset in webkit [157091] by Carlos Garcia Campos
  • 4 edits in trunk

[GTK] media/video-src-blob.html
https://bugs.webkit.org/show_bug.cgi?id=102586

Reviewed by Martin Robinson.

Source/WebCore:

Add support for loading videos using blob URLs.

Fixes media/video-src-blob.html.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart): Use BufferData buffering policy for blob
URLs.
(webKitWebSrcGetProtocols): Add blob to the list of supported
protocols.
(webKitWebSrcSetUri): Consider blob URLs as valid.

LayoutTests:

  • platform/gtk/TestExpectations: Unskip

media/video-src-blob.html.

12:58 AM Changeset in webkit [157090] by Darin Adler
  • 3 edits in trunk/Source/WebKit2

Remove use of deleteAllValues in NPRemoteObjectMap::pluginDestroyed
https://bugs.webkit.org/show_bug.cgi?id=122496

Reviewed by Andreas Kling.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::registerNPObject): Don't call release when putting objects
into the map.
(WebKit::NPRemoteObjectMap::pluginDestroyed): Instead of making an array of receivers
and deleting them all, remove all of the receivers from the map, which will take care
of deleting them. Also change the other loop to use a similar coding style.

  • Shared/Plugins/NPRemoteObjectMap.h: Change the value type of m_registeredNPObjects

to be unique_ptr instead of a raw pointer.

12:45 AM Changeset in webkit [157089] by Darin Adler
  • 7 edits in trunk/Source/WebKit/mac

Change NetscapePluginInstanceProxy::m_replies to use unique_ptr instead of deleteAllValues
https://bugs.webkit.org/show_bug.cgi?id=122492

Reviewed by Andreas Kling.

  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::instantiatePlugin): Use auto so this works with
unique_ptr instead of auto_ptr.

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WKPCGetScriptableNPObjectReply): Use make_unique instead of using new directly.
(WKPCBooleanReply): Ditto.
(WKPCBooleanAndDataReply): Ditto.
(WKPCInstantiatePluginReply): Ditto.

  • Plugins/Hosted/NetscapePluginInstanceProxy.h: Changed m_replies to map to unique_ptr

instead of to a raw pointer.
(WebKit::NetscapePluginInstanceProxy::setCurrentReply): Changed to take a unique_ptr
instead of a raw pointer since this takes ownership of the pointer.
(WebKit::NetscapePluginInstanceProxy::waitForReply): Changed to return a unique_ptr
instead of a auto_ptr because that's better. Use unique_ptr inside the function
too to avoid the need for an explicit delete.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::~NetscapePluginInstanceProxy): Removed the call to
deleteAllValues.
(WebKit::NetscapePluginInstanceProxy::cancelStreamLoad): Removed unneeded initialization
of a local variable that was already set in all code paths.
(WebKit::NetscapePluginInstanceProxy::wheelEvent): Use auto so this works with unique_ptr
instead of auto_ptr.
(WebKit::NetscapePluginInstanceProxy::print): Ditto.
(WebKit::NetscapePluginInstanceProxy::snapshot): Ditto. Ditto.
(WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply): Changed to return
a unique_ptr. Also removed an unneeded assertion.
(WebKit::NetscapePluginInstanceProxy::createBindingsInstance): Use auto so this works
with unique_ptr instead of auto_ptr.

  • Plugins/Hosted/ProxyInstance.h: Changed return type of waitForReply to unique_ptr.
  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::invoke): Use auto so this works with unique_ptr instead of auto_ptr.
(WebKit::ProxyInstance::supportsInvokeDefaultMethod): Ditto.
(WebKit::ProxyInstance::supportsConstruct): Ditto.
(WebKit::ProxyInstance::getPropertyNames): Ditto.
(WebKit::ProxyInstance::methodNamed): Ditto.
(WebKit::ProxyInstance::fieldNamed): Ditto.
(WebKit::ProxyInstance::fieldValue): Ditto.
(WebKit::ProxyInstance::setFieldValue): Ditto.

Oct 7, 2013:

11:14 PM Changeset in webkit [157088] by ap@apple.com
  • 2 edits in trunk/LayoutTests

webaudio/javascriptaudionode-upmix2-8channel-input.html is flaky on Mac WK2
https://bugs.webkit.org/show_bug.cgi?id=120148

  • platform/mac-wk2/TestExpectations: Removed a duplicate expectation that I overlooked

at first. Note that having separate expectations for Debug and Release doesn't
appear to work.

11:09 PM Changeset in webkit [157087] by ap@apple.com
  • 2 edits in trunk/LayoutTests

webaudio/javascriptaudionode-upmix2-8channel-input.html is flaky on Mac WK2
https://bugs.webkit.org/show_bug.cgi?id=120148

  • platform/mac-wk2/TestExpectations: Updated expectations to cover debug assertions,

and that this is not limited to Lion.

11:03 PM Changeset in webkit [157086] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test mathml/very-large-stretchy-operators.html is failing
https://bugs.webkit.org/show_bug.cgi?id=122490

  • platform/mac/TestExpectations: Skipped the test. It's faiing with a timeout and

taking up to 80 seconds.

9:44 PM Changeset in webkit [157085] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

EventDispatchBehavior is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=122483

Reviewed by Andreas Kling.

Removed EventDispatchBehavior and changed the return type of determineDispatchBehavior to bool.
Also renamed it to shouldEventCrossShadowBoundary to reflect the semantics more clear.

  • dom/EventRetargeter.cpp:

(WebCore::shouldEventCrossShadowBoundary):
(WebCore::EventRetargeter::calculateEventPath):

  • dom/EventRetargeter.h:
8:43 PM Changeset in webkit [157084] by fpizlo@apple.com
  • 2 edits in trunk/Tools

run-jsc-stress-tests progress meter should update more quickly on older Rubies
https://bugs.webkit.org/show_bug.cgi?id=122459

Reviewed by Darin Adler.

  • Scripts/run-jsc-stress-tests:
8:38 PM Changeset in webkit [157083] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Make buildRelatedNodeMap and findRelatedNode static to EventRetargeter.cpp
https://bugs.webkit.org/show_bug.cgi?id=122477

Reviewed by Antti Koivisto.

Make EventRetargeter::buildRelatedNodeMap and EventRetargeter::findRelatedNode static local functions
in EventRetargeter.cpp since they're only called in EventRetargeter::calculateAdjustedNodes and don't
depend on any oher member function or variable (EventRetarger doesn't have any member variables).

Also get rid of Vector local variables in both functions as they're redundant.

  • dom/EventRetargeter.cpp:

(WebCore::buildRelatedNodeMap): Moved. Replaced Vector<Node*, 32> relatedNodeStack by a single pointer
since the only time we add an item to this Vector is when it's empty, and we always use or remove the
last item.
(WebCore::addRelatedNodeForUnmapedTreeScopes): Renamed from EventRetargeter::findRelatedNode. Removed
Vector<TreeScope*, 32> parentTreeScopes since it only contains the ancestor tree scopes of scope up to
a tree scope already in relatedNodeMap. We could simply remember this tree scope and re-traverse the
ancestor tree scopes in the second loop.
(WebCore::EventRetargeter::calculateAdjustedNodes):

  • dom/EventRetargeter.h:
8:29 PM Changeset in webkit [157082] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Pass VM instead of ExecState to JSNotAnObject constructor.
<https://webkit.org/b/122474>

Reviewed by Sam Weinig.

JSNotAnObject was only using the ExecState to find the VM.

8:28 PM Changeset in webkit [157081] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

CTTE: EditCommand always has a Document.
<https://webkit.org/b/122473>

Reviewed by Anders Carlsson.

Store a Ref<Document> in EditComment since it's never null.

Since Ref enforces more const consistency than RefPtr, I had to make
document() and frame() non-const here. Only a single method depended
on the old half-const behavior.

8:26 PM Changeset in webkit [157080] by kov@webkit.org
  • 1 edit
    5 adds in trunk/LayoutTests

Gardening: add baselines for new tests.

  • platform/gtk/fast/regions/selection/selecting-text-ignoring-region-horiz-bt-expected.png: Added.
  • platform/gtk/fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.png: Added.
  • platform/gtk/fast/regions/selection/selecting-text-in-2-regions-horiz-bt-expected.png: Added.
  • platform/gtk/fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.png: Added.
7:49 PM Changeset in webkit [157079] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Gardening: skip audio/video track tests, since those are not yet supported by our
media player.

  • platform/gtk/TestExpectations:
7:40 PM Changeset in webkit [157078] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Marking svg/animations/svglengthlist-animation-3.html as flaky.

  • platform/gtk/TestExpectations:
6:59 PM Changeset in webkit [157077] by Darin Adler
  • 4 edits in trunk/Source/WTF

Improve HashMap::add comment and other similar comments
https://bugs.webkit.org/show_bug.cgi?id=122432

Reviewed by Andreas Kling.

  • wtf/HashCountedSet.h:
  • wtf/HashMap.h:
  • wtf/HashSet.h:

Updated comment wording. They were a bit old and out of date.
They also featured the word "interator".

6:37 PM Changeset in webkit [157076] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Update test again.

  • bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallback::~JSTestCallback):

6:34 PM Changeset in webkit [157075] by commit-queue@webkit.org
  • 29 edits in trunk/Source/WebCore

Unreviewed, rolling out r157061.
http://trac.webkit.org/changeset/157061
https://bugs.webkit.org/show_bug.cgi?id=122479

Broke worker tests (Requested by andersca on #webkit).

  • Modules/webdatabase/Database.cpp:

(WebCore::DerefContextTask::create):
(WebCore::DerefContextTask::DerefContextTask):
(WebCore::Database::~Database):
(WebCore::DeliverPendingCallbackTask::create):
(WebCore::DeliverPendingCallbackTask::performTask):
(WebCore::DeliverPendingCallbackTask::DeliverPendingCallbackTask):
(WebCore::Database::scheduleTransactionCallback):

  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::DatabaseManager::openDatabase):

  • Modules/webdatabase/SQLCallbackWrapper.h:

(WebCore::SQLCallbackWrapper::clear):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::create):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::performTask):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::isCleanupTask):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::create):
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::~WorkerGlobalScopeDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::WorkerGlobalScopeDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):

  • bindings/js/JSCallbackData.h:

(WebCore::DeleteCallbackDataTask::create):
(WebCore::DeleteCallbackDataTask::performTask):
(WebCore::DeleteCallbackDataTask::isCleanupTask):
(WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask):

  • bindings/js/JSDOMGlobalObjectTask.h:
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::queueTaskToEventLoop):

  • bindings/js/JSWorkerGlobalScopeBase.cpp:

(WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallbackImplementation):

  • dom/CrossThreadTask.h:

(WebCore::CrossThreadTask1::create):
(WebCore::CrossThreadTask1::performTask):
(WebCore::CrossThreadTask2::create):
(WebCore::CrossThreadTask2::performTask):
(WebCore::CrossThreadTask3::create):
(WebCore::CrossThreadTask3::performTask):
(WebCore::CrossThreadTask4::create):
(WebCore::CrossThreadTask4::performTask):
(WebCore::CrossThreadTask5::create):
(WebCore::CrossThreadTask5::performTask):
(WebCore::CrossThreadTask6::create):
(WebCore::CrossThreadTask6::performTask):
(WebCore::CrossThreadTask7::create):
(WebCore::CrossThreadTask7::performTask):
(WebCore::CrossThreadTask8::create):
(WebCore::CrossThreadTask8::performTask):
(WebCore::createCallbackTask):

  • dom/Document.cpp:

(WebCore::Document::addConsoleMessage):
(WebCore::Document::addMessage):
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::Document::postTask):
(WebCore::Document::pendingTasksTimerFired):

  • dom/Document.h:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ProcessMessagesSoonTask::create):
(WebCore::ProcessMessagesSoonTask::performTask):
(WebCore::ScriptExecutionContext::processMessagePortMessagesSoon):

  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::AddConsoleMessageTask::create):
(WebCore::ScriptExecutionContext::AddConsoleMessageTask::AddConsoleMessageTask):

  • dom/StringCallback.cpp:

(WebCore::StringCallback::scheduleCallback):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::CallCacheListenerTask::create):
(WebCore::CallCacheListenerTask::CallCacheListenerTask):
(WebCore::ApplicationCacheGroup::postListenerTask):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::SharedWorkerConnectTask::create):
(WebCore::SharedWorkerConnectTask::performTask):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
(WebCore::DefaultSharedWorkerRepository::connectToWorker):

  • workers/WorkerEventQueue.cpp:

(WebCore::WorkerEventQueue::enqueueEvent):

  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::close):
(WebCore::WorkerGlobalScope::postTask):
(WebCore::WorkerGlobalScope::addConsoleMessage):
(WebCore::WorkerGlobalScope::addMessage):

  • workers/WorkerGlobalScope.h:
  • workers/WorkerLoaderProxy.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::MessageWorkerGlobalScopeTask::create):
(WebCore::MessageWorkerGlobalScopeTask::performTask):
(WebCore::MessageWorkerTask::create):
(WebCore::MessageWorkerTask::performTask):
(WebCore::WorkerExceptionTask::create):
(WebCore::WorkerExceptionTask::performTask):
(WebCore::WorkerGlobalScopeDestroyedTask::create):
(WebCore::WorkerGlobalScopeDestroyedTask::performTask):
(WebCore::WorkerTerminateTask::create):
(WebCore::WorkerTerminateTask::WorkerTerminateTask):
(WebCore::WorkerTerminateTask::performTask):
(WebCore::WorkerThreadActivityReportTask::create):
(WebCore::WorkerThreadActivityReportTask::performTask):
(WebCore::PostMessageToPageInspectorTask::create):
(WebCore::PostMessageToPageInspectorTask::performTask):
(WebCore::NotifyNetworkStateChangeTask::create):
(WebCore::NotifyNetworkStateChangeTask::NotifyNetworkStateChangeTask):
(WebCore::NotifyNetworkStateChangeTask::performTask):
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
(WebCore::WorkerMessagingProxy::workerThreadCreated):
(WebCore::WorkerMessagingProxy::notifyNetworkStateChange):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeClosed):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
(WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
(WebCore::WorkerMessagingProxy::reportPendingActivity):

  • workers/WorkerMessagingProxy.h:
  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskAndTerminate):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::create):
(WebCore::WorkerRunLoop::Task::Task):

  • workers/WorkerRunLoop.h:
  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadShutdownFinishTask::create):
(WebCore::WorkerThreadShutdownFinishTask::performTask):
(WebCore::WorkerThreadShutdownFinishTask::isCleanupTask):
(WebCore::WorkerThreadShutdownStartTask::performTask):
(WebCore::WorkerThread::stop):
(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads):

6:28 PM Changeset in webkit [157074] by Darin Adler
  • 4 edits in trunk/Source

Make Vector::insert work for move-only types
https://bugs.webkit.org/show_bug.cgi?id=122429

Reviewed by Anders Carlsson.

Source/WebCore:

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::padDailyCountsForNewVisit): Call insertVector.
Also added some inline capacity, which should make this faster.

Source/WTF:

  • wtf/Vector.h:

(WTF::Vector::insert): Take an rvalue reference instead of a const reference.
(WTF::Vector::insertVector): Renamed to avoid overloading troubles, analogous
to what we did for appendVector.

6:24 PM Changeset in webkit [157073] by kov@webkit.org
  • 2 edits in trunk/Tools

[buildbot] parse tests that are reported as crashed correctly for GTK+
https://bugs.webkit.org/show_bug.cgi?id=122476

Reviewed by Martin Robinson.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
as a failure of the API tests.

6:21 PM Changeset in webkit [157072] by kov@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Skipping API test that is causing the next one to crash,
see https://bugs.webkit.org/show_bug.cgi?id=121970.

  • Scripts/run-gtk-tests:

(TestRunner):

6:04 PM Changeset in webkit [157071] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Update test results.

  • bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallback::~JSTestCallback):

5:36 PM Changeset in webkit [157070] by mrobinson@webkit.org
  • 19 edits
    8 adds in trunk

[MathML] Remove RenderTree modification during layout and refactor the StretchyOp code
https://bugs.webkit.org/show_bug.cgi?id=121416

Source/WebCore:

Reviewed by David Hyatt.

Tests: mathml/presentation/mo-minus.html

mathml/presentation/mo-stacked-glyphs.html
mathml/presentation/mo-stretchy-vertical-bar.html
mathml/very-large-stretchy-operators.html

MathML stretched operators by both modifying the width of the operator
and adding children to the operator node in the render tree.

Instead we make the operator width equal to the widest glyph possible that we use
to represent the operator. Additionally instead of rendering stretchy glyphs via
stacked operator pieces in separate render tree nodes, keep only one node for the
glyph, and use a custom paint method to paint the stacked representation.

With this patch, rendering seems roughly equivalent on Mac and markedly better
on Linux.

  • css/mathml.css:

Not sure what this line-height:0 was here for, but it caused bugs with the new code

  • mathml/MathMLTextElement.cpp:

(WebCore::MathMLTextElement::attach):
(WebCore):
(WebCore::MathMLTextElement::childrenChanged):
Need to update the anonymous render tree below <mo> elements when their
children change or when the renderer is first attached.

  • mathml/MathMLTextElement.h:

(MathMLTextElement):

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::RenderMathMLBlock):

  • rendering/mathml/RenderMathMLBlock.h:

Now that the preferred width doesn't depend on the height, we don't
need to override computePreferredLogicalWidths at all.

  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::styleDidChange):
Need to update the anonymous renderers for the anonymous RenderMathMLOperators.

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::expandedStretchHeight):
Store the non-expanded stretch height so that we can detect when the height
actually changed.

(WebCore::RenderMathMLOperator::stretchToHeight):
Only update the style on the anonymous render tree since this is called
from RenderMathMLRow::layout

(WebCore::RenderMathMLOperator::styleDidChange):
(WebCore::RenderMathMLOperator::glyphBoundsForCharacter): A helper to get glyph boundaries.
(WebCore::RenderMathMLOperator::glyphHeightForCharacter): Ditto for glyph width.
(WebCore::RenderMathMLOperator::advanceForCharacter): The advance is different from the width,
and we want the width of the operator to be the advance instead of the tight bounding width.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Use the max of all possible glyphs
we can use to render this operator.
(WebCore::RenderMathMLOperator::computeLogicalHeight): Return the stretched operator height, if appropriate.
(WebCore::RenderMathMLOperator::updateFromElement): We add a child for rendering the non-scaled
version of the glyph.
(WebCore::RenderMathMLOperator::firstCharacterForStretching): Helper to figure out what character
is the character used for stretching operations.
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter): Helper to find an acceptable set
of glyph pieces for stretching characters.
(WebCore::RenderMathMLOperator::updateStyle): Resize the operator to the appropriate height and hide
the child if we are using the stretchy style.
(WebCore::RenderMathMLOperator::firstLineBoxBaseline):
(WebCore::RenderMathMLOperator::paintCharacter): Helper to paint a single character component of the
stretchy glyph.
(WebCore::RenderMathMLOperator::fillWithExtensionGlyph): Helper to paint the extender glue between
features of the stretchy glyph.
(WebCore::RenderMathMLOperator::paint): Properly paint stretchy glyphs.

  • rendering/mathml/RenderMathMLOperator.h: Update method declarations.

LayoutTests:

Patch by Frédéric Wang <fred.wang@free.fr> on 2013-10-04
Reviewed by David Hyatt.

Add some reftests for stretchy operators.

  • TestExpectations: The remaining MathML pixel tests are broken by this patch.
  • LayoutTests/platform/gtk/TestExpectations:
  • LayoutTests/platform/mac/TestExpectations:
  • LayoutTests/platform/win/TestExpectations:
  • mathml/presentation/mo-minus.html: Added.
  • mathml/presentation/mo-stacked-glyphs-expected.html: Added.
  • mathml/presentation/mo-stacked-glyphs.html: Added.
  • mathml/presentation/mo-stretchy-vertical-bar-expected-mismatch.html: Added.
  • mathml/presentation/mo-stretchy-vertical-bar.html: Added.
  • mathml/very-large-stretchy-operators-expected.txt: Added.
  • mathml/very-large-stretchy-operators.html: Added.
4:56 PM Changeset in webkit [157069] by kov@webkit.org
  • 2 edits in trunk/Tools

[GTK] run-gtk-tests does not distinguish between failure and crashes
https://bugs.webkit.org/show_bug.cgi?id=122135

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-10-07
Reviewed by Martin Robinson.

The GTK+ API test runner does not distinguish between failures and crashes. This change
makes it do that, so it's easier for us to spot the more important/higher priority crash
case.

  • Scripts/run-gtk-tests:

(TestRunner._run_test_command): return the exit code instead of a boolean true/false,
so we have more information on how the process ended.
(TestRunner._run_test): check the exit code to distinguish between crashes and failures.
(TestRunner.run_tests): report crashes.

4:48 PM Changeset in webkit [157068] by eric.carlson@apple.com
  • 38 edits
    27 adds in trunk

[MediaStream API] update MediaStreamTrack object to match spec
https://bugs.webkit.org/show_bug.cgi?id=121940

Reviewed by Jer Noble.

Source/WebCore:

No new tests, existing test updated.

Add new source files to the project:

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:

New capability dictionary objects:

  • Modules/mediastream/AllAudioCapabilities.h: Added.
  • Modules/mediastream/AllAudioCapabilities.idl: Added.
  • Modules/mediastream/AllVideoCapabilities.h: Added.
  • Modules/mediastream/AllVideoCapabilities.idl: Added.
  • Modules/mediastream/AudioStreamTrack.cpp:

(WebCore::AudioStreamTrack::create): New version that takes a MediaStreamTrack*.

  • Modules/mediastream/AudioStreamTrack.h:

New object for a capability range:

  • Modules/mediastream/CapabilityRange.cpp: Added.
  • Modules/mediastream/CapabilityRange.h: Added.
  • Modules/mediastream/CapabilityRange.idl: Added.
  • Modules/mediastream/MediaConstraintsImpl.h: Make initialize() public.

New object for the current states for a media source.

  • Modules/mediastream/MediaSourceStates.cpp: Added.
  • Modules/mediastream/MediaSourceStates.h: Added.
  • Modules/mediastream/MediaSourceStates.idl: Added.

Don't call the media stream center to notify it when the state of other
objects change.

  • Modules/mediastream/MediaStream.cpp:

(WebCore::processTrack): Remove the stream source duplication hack.
(WebCore::createFromSourceVectors):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):

  • Modules/mediastream/MediaStream.h:

New object for the capabilities of a source.

  • Modules/mediastream/MediaStreamCapabilities.cpp: Added.
  • Modules/mediastream/MediaStreamCapabilities.h: Added.
  • Modules/mediastream/MediaStreamCapabilities.idl: Added.

Update interface to match spec.

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::MediaStreamTrack): Define a copy constructor to use in clone().
(WebCore::MediaStreamTrack::setSource): Call removeObserver if the track already has a source.

Initialize m_muted from new source's muted state.

(WebCore::MediaStreamTrack::id): Allow source to provide ID as the spec suggests.
(WebCore::MediaStreamTrack::setEnabled): Add some spec text to clarify logic. Always call

source->setEnabled, it can figure out if nothing needs to be done.

(WebCore::MediaStreamTrack::muted): Don't call the stream center when muted changes, the

source can take care of notifying interested parties.

(WebCore::MediaStreamTrack::readonly): New.
(WebCore::MediaStreamTrack::remote): New.
(WebCore::MediaStreamTrack::constraints): New.
(WebCore::MediaStreamTrack::states): New.
(WebCore::MediaStreamTrack::capabilities): New.
(WebCore::MediaStreamTrack::applyConstraints): New.
(WebCore::MediaStreamTrack::clone): New.
(WebCore::MediaStreamTrack::stopProducingData): New.
(WebCore::MediaStreamTrack::sourceStateChanged): Renamed from sourceChangedState.
(WebCore::MediaStreamTrack::sourceMutedChanged): New.
(WebCore::MediaStreamTrack::sourceEnabledChanged): New.
(WebCore::MediaStreamTrack::configureTrackRendering): New.
(WebCore::MediaStreamTrack::stopped): New.
(WebCore::MediaStreamTrack::stop): Call stopProducingData.
(WebCore::MediaStreamTrack::scheduleEventDispatch): New.
(WebCore::MediaStreamTrack::dispatchQueuedEvents): New.

  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/MediaStreamTrack.idl:
  • Modules/mediastream/MediaTrackConstraint.cpp: Added.
  • Modules/mediastream/MediaTrackConstraint.h: Added.
  • Modules/mediastream/MediaTrackConstraint.idl: Added.

Add empty classes/IDL for track constraint objects.

  • Modules/mediastream/MediaTrackConstraintSet.cpp: Added.
  • Modules/mediastream/MediaTrackConstraintSet.h: Added.
  • Modules/mediastream/MediaTrackConstraintSet.idl: Added.
  • Modules/mediastream/MediaTrackConstraints.cpp: Added.
  • Modules/mediastream/MediaTrackConstraints.h: Added.
  • Modules/mediastream/MediaTrackConstraints.idl: Added.
  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::callSuccessHandler): Don't call the stream center, the

stream can take care of notifying interested parties.

Add a constructor and create() that take a MediaStreamTrack*.

  • Modules/mediastream/VideoStreamTrack.cpp:

(WebCore::VideoStreamTrack::create):
(WebCore::VideoStreamTrack::VideoStreamTrack):

  • Modules/mediastream/VideoStreamTrack.h:

Create a MediaStreamSource subclass for WebAudio

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaStreamSource): Call isAudioStreamSource instead

of checking deviceID.

  • Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode): Create a

MediaStreamAudioSource instead of a MediaStreamSource.

  • Modules/webaudio/MediaStreamAudioDestinationNode.h:
  • Modules/webaudio/MediaStreamAudioSource.cpp: Added.
  • Modules/webaudio/MediaStreamAudioSource.h: Added.

(WebCore::MediaStreamAudioSource::~MediaStreamAudioSource):

Add new generated files.

  • bindings/js/JSMediaSourceStatesCustom.cpp: Added.
  • bindings/js/JSMediaStreamCapabilitiesCustom.cpp: Added.
  • dom/EventNames.h: Defined 'overconstrained' event.
  • platform/mediastream/MediaStreamCenter.h: Get rid of all of the methods nobody uses.

It isn't clear that they are necessary, and we can add them back if/when we need them.

  • platform/mediastream/MediaStreamDescriptor.cpp:

(WebCore::MediaStreamDescriptor::~MediaStreamDescriptor): Clear the all source streams.
(WebCore::MediaStreamDescriptor::removeSource): Clear the source stream.

  • platform/mediastream/MediaStreamDescriptor.h:

Make MediaStreamSource an abstract base class, and remove everyting WebAudio-specific
to MediaStreamAudioSource.

  • platform/mediastream/MediaStreamSource.cpp:

(WebCore::MediaStreamSource::MediaStreamSource): Remove readyState and requiresConsumer

parameters. Create new UUID for id if non was passed.

(WebCore::MediaStreamSource::reset): Reset internal state to just-constructed. Used for testing.
(WebCore::MediaStreamSource::setReadyState): sourceChangedState -> sourceStateChanged.
(WebCore::MediaStreamSource::setStream): Remove the ASSERT that check for a source being

added to a new stream. This is still a problem, but it is required for testing and will
be fixed as a part of bug 121954.

(WebCore::MediaStreamSource::setConstraints): Added.
(WebCore::MediaStreamSource::setMuted): Notify observers when muted changes.
(WebCore::MediaStreamSource::setEnabled): Notify observers when enabled changes.
(WebCore::MediaStreamSource::readonly): New.
(WebCore::MediaStreamSource::stop): New. Set state to Ended when all of the observers has

stopped.

  • platform/mediastream/MediaStreamSource.h:

Define platform versions of the Capabilities classes.

  • platform/mediastream/MediaStreamSourceCapabilities.h: Added.

Update the non-functional platform stream centers for the API changes.

  • platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:
  • platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:
  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
  • platform/mediastream/mac/MediaStreamCenterMac.cpp:
  • platform/mediastream/mac/MediaStreamCenterMac.h:

Update the Mock stream center for the API changes. Add a concrete mock MediaStreamSource
subclass.

  • platform/mock/MockMediaStreamCenter.cpp:

(WebCore::MockSource::MockSource): New, the mock media stream source.
(WebCore::MockSource::~MockSource):
(WebCore::MockSource::capabilities):
(WebCore::MockSource::states):
(WebCore::mockSourceMap):
(WebCore::mockAudioSourceID):
(WebCore::mockVideoSourceID):
(WebCore::initializeMockSources): Create one audio and one video mock source.
(WebCore::MockMediaStreamCenter::registerMockMediaStreamCenter): Call initializeMockSources.
(WebCore::MockMediaStreamCenter::createMediaStream): Use the already allocated mock media

sources.

(WebCore::MockMediaStreamCenter::getMediaStreamTrackSources): Ditto.

  • platform/mock/MockMediaStreamCenter.h:

LayoutTests:

  • fast/mediastream/MediaStreamTrack-expected.txt:
  • fast/mediastream/MediaStreamTrack.html:
  • fast/mediastream/MediaStreamTrack-getSources-expected.txt:
  • fast/mediastream/MediaStreamTrack-getSources.html:
4:43 PM Changeset in webkit [157067] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Missing packages for APT on install-dependencies
https://bugs.webkit.org/show_bug.cgi?id=121555

Patch by Gustavo Noronha Silva <gns@gnome.org> on 2013-10-07
Reviewed by Martin Robinson.

  • gtk/install-dependencies: add packages that are needed for

building WebKit itself and the jhbuild dependencies.

4:33 PM Changeset in webkit [157066] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Fix Windows build.

  • wtf/StdLibExtras.h:

(std::make_unique):

4:05 PM Changeset in webkit [157065] by akling@apple.com
  • 35 edits in trunk/Source/WebCore

CTTE: Live node lists always have an owner Node.
<https://webkit.org/b/122470>

Reviewed by Anders Carlsson.

Make LiveNodeListBase::m_ownerNode a Ref<Node> instead of a RefPtr
and have all constructors take Node&.

4:01 PM Changeset in webkit [157064] by kov@webkit.org
  • 3 edits in trunk/Source/WebKit2

Reduce duplicated code in WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=122230

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> on 2013-10-07
Reviewed by Darin Adler.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close): move duplicate code to resetState and call it.
(WebKit::WebPageProxy::resetState): new private method for code that is shared between
close and resetStateAfterProcessExited.
(WebKit::WebPageProxy::resetStateAfterProcessExited): move duplicate code to resetState
and call it.

  • UIProcess/WebPageProxy.h:
3:58 PM Changeset in webkit [157063] by andersca@apple.com
  • 3 edits in trunk/Tools

Fix test failures.

  • Scripts/webkitpy/port/base.py:

(Port.to.start_helper):

  • Scripts/webkitpy/port/mock_drt.py:

(MockDRTPort.start_helper):

3:46 PM Changeset in webkit [157062] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

FTL memory allocator should be able to allocate data sections in non-executable memory
https://bugs.webkit.org/show_bug.cgi?id=116189

Reviewed by Sam Weinig.

Use a RefCountedArray<int64_t> for data sections. This works out great because
RefCountedArray<> knows its own size and because the reference counting makes passing
it around very easy (you don't have to stress out about ownership).

  • ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):
(JSC::FTL::compile):

  • ftl/FTLJITCode.cpp:

(JSC::FTL::JITCode::addDataSection):

  • ftl/FTLJITCode.h:

(JSC::FTL::JITCode::dataSections):

3:37 PM Changeset in webkit [157061] by andersca@apple.com
  • 29 edits in trunk/Source/WebCore

Clean up ScriptExecutionContext::Task and subclasses
https://bugs.webkit.org/show_bug.cgi?id=122469

Reviewed by Andreas Kling.

  • Modules/webdatabase/Database.cpp:

(WebCore::DerefContextTask::DerefContextTask):
(WebCore::Database::~Database):
(WebCore::DeliverPendingCallbackTask::DeliverPendingCallbackTask):
(WebCore::Database::scheduleTransactionCallback):

  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::DatabaseManager::openDatabase):

  • Modules/webdatabase/SQLCallbackWrapper.h:

(WebCore::SQLCallbackWrapper::clear):
(WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::WorkerGlobalScopeDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):

  • bindings/js/JSCallbackData.h:

(WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask):

  • bindings/js/JSDOMGlobalObjectTask.h:
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::queueTaskToEventLoop):

  • bindings/js/JSWorkerGlobalScopeBase.cpp:

(WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallbackImplementation):

  • dom/CrossThreadTask.h:

(WebCore::createCallbackTask):

  • dom/Document.cpp:

(WebCore::Document::addConsoleMessage):
(WebCore::Document::addMessage):
(WebCore::PerformTaskContext::PerformTaskContext):
(WebCore::Document::postTask):
(WebCore::Document::pendingTasksTimerFired):

  • dom/Document.h:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ProcessMessagesSoonTask::ProcessMessagesSoonTask):
(WebCore::ScriptExecutionContext::processMessagePortMessagesSoon):

  • dom/ScriptExecutionContext.h:
  • dom/StringCallback.cpp:

(WebCore::StringCallback::scheduleCallback):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::CallCacheListenerTask::CallCacheListenerTask):
(WebCore::ApplicationCacheGroup::postListenerTask):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
(WebCore::DefaultSharedWorkerRepository::connectToWorker):

  • workers/WorkerEventQueue.cpp:

(WebCore::WorkerEventQueue::enqueueEvent):

  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::close):
(WebCore::WorkerGlobalScope::postTask):
(WebCore::WorkerGlobalScope::addConsoleMessage):
(WebCore::WorkerGlobalScope::addMessage):

  • workers/WorkerGlobalScope.h:
  • workers/WorkerLoaderProxy.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
(WebCore::WorkerMessagingProxy::workerThreadCreated):
(WebCore::WorkerMessagingProxy::notifyNetworkStateChange):
(WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyed):
(WebCore::WorkerMessagingProxy::workerGlobalScopeClosed):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
(WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
(WebCore::WorkerMessagingProxy::reportPendingActivity):

  • workers/WorkerMessagingProxy.h:
  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskAndTerminate):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::Task):

  • workers/WorkerRunLoop.h:
  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadShutdownFinishTask::WorkerThreadShutdownFinishTask):
(WebCore::WorkerThreadShutdownStartTask::performTask):
(WebCore::WorkerThread::stop):
(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads):

3:25 PM Changeset in webkit [157060] by roger_fong@apple.com
  • 4 edits in trunk/Source

Modify WTF and JavaScriptCore makefiles for x64 build.
https://bugs.webkit.org/show_bug.cgi?id=122467.
<rdar://problem/15169174>.

Reviewed by Brent Fulgham.

3:08 PM Changeset in webkit [157059] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

FTL: Optimize IsString(@2<String>) -> JSConst(true) + Phantom()
https://bugs.webkit.org/show_bug.cgi?id=122363

Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-07
Reviewed by Filip Pizlo.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

1:34 PM Changeset in webkit [157058] by commit-queue@webkit.org
  • 61 edits in trunk/Source

CTTE: Use references in and around DragController
https://bugs.webkit.org/show_bug.cgi?id=122427

Patch by Sam Weinig <sam@webkit.org> on 2013-10-07
Reviewed by Andreas Kling.

Source/WebCore:

Use references to indicate non-nullness of DragController related
objects.

Source/WebKit/efl:

  • WebCoreSupport/DragClientEfl.cpp:

(WebCore::DragClientEfl::willPerformDragDestinationAction):
(WebCore::DragClientEfl::willPerformDragSourceAction):
(WebCore::DragClientEfl::actionMaskForDrag):
(WebCore::DragClientEfl::startDrag):

  • WebCoreSupport/DragClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/DragClientGtk.cpp:

(WebKit::DragClient::willPerformDragDestinationAction):
(WebKit::DragClient::willPerformDragSourceAction):
(WebKit::DragClient::actionMaskForDrag):
(WebKit::DragClient::startDrag):

  • WebCoreSupport/DragClientGtk.h:
  • webkit/webkitwebview.cpp:

(dragExitedCallback):
(webkit_web_view_drag_motion):
(webkit_web_view_drag_data_received):
(webkit_web_view_drag_drop):

Source/WebKit/mac:

  • WebCoreSupport/WebDragClient.h:
  • WebCoreSupport/WebDragClient.mm:

(WebDragClient::actionMaskForDrag):
(WebDragClient::willPerformDragDestinationAction):
(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):
(WebDragClient::declareAndWriteDragImage):

  • WebView/WebFrame.mm:

(-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):

  • WebView/WebView.mm:

(-[WebView draggingEntered:]):
(-[WebView draggingUpdated:]):
(-[WebView draggingExited:]):
(-[WebView performDragOperation:]):

Source/WebKit/win:

  • WebCoreSupport/WebDragClient.cpp:

(WebDragClient::actionMaskForDrag):
(WebDragClient::willPerformDragDestinationAction):
(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):

  • WebCoreSupport/WebDragClient.h:

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseDragDataReceived):
(webkitWebViewBaseDragMotion):
(dragExitedCallback):
(webkitWebViewBaseDragDrop):

  • UIProcess/API/mac/WKView.mm:

(-[WKView draggingEntered:]):
(-[WKView draggingUpdated:]):
(-[WKView draggingExited:]):
(-[WKView performDragOperation:]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dragEntered):
(WebKit::WebPageProxy::dragUpdated):
(WebKit::WebPageProxy::dragExited):
(WebKit::WebPageProxy::performDrag):
(WebKit::WebPageProxy::performDragControllerAction):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebCoreSupport/WebDragClient.cpp:

(WebKit::WebDragClient::willPerformDragDestinationAction):
(WebKit::WebDragClient::willPerformDragSourceAction):
(WebKit::WebDragClient::actionMaskForDrag):
(WebKit::WebDragClient::dragSourceActionMaskForPoint):
(WebKit::WebDragClient::startDrag):

  • WebProcess/WebCoreSupport/WebDragClient.h:
  • WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:

(WebKit::WebDragClient::startDrag):

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::startDrag):
(WebKit::cachedImage):
(WebKit::WebDragClient::declareAndWriteDragImage):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):

1:28 PM Changeset in webkit [157057] by andersca@apple.com
  • 5 edits in trunk/Tools

Always force discrete mode when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=122465

Reviewed by Tim Horton.

This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Link with IOKit.

  • DumpRenderTree/mac/LayoutTestHelper.m:

(installLayoutTestColorProfile):
Check installColorProfile.

(restoreUserColorProfile):
Check installColorProfile.

(lockDownDiscreteGraphics):
New function to force discrete graphics.

(main):
Add '--install-color-profile' option.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._set_up_run):
Always start the helper, but pass self._options.pixel_tests to it.

  • Scripts/webkitpy/port/mac.py:

(MacPort.start_helper):
Pass --install-color-profile' to the helper if pixel_tests is true.

1:27 PM Changeset in webkit [157056] by timothy_horton@apple.com
  • 9 edits in trunk/Source

Animated images are not restarted when page visibility changes
https://bugs.webkit.org/show_bug.cgi?id=122464
<rdar://problem/14293474>

Reviewed by Simon Fraser.

Always kickstart animated images when the page visibility changes,
which can occur via window occlusion, and which is independent of in-window
state, which we were previously using to advance animation.

No new tests; attempts to make a test have resulted only in a flaky, timing-dependent test.

  • page/Frame.cpp:

(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
Move this call to resumeAnimatingImages() up to Page.

  • page/FrameView.cpp:

(WebCore::FrameView::setIsInWindow):
Move this call to resumeAnimatingImages() up to Page.

  • WebCore.exp.in
  • page/FrameView.h:
  • page/Page.h:

Move resumeAnimatingImages() itself up to Page.

  • page/Page.cpp:

(WebCore::Page::setIsInWindow):
Resume animated images when we move in-window.

(WebCore::Page::setVisibilityState):
Resume animated images when we become visible.
This is the one we were previously missing.

(WebCore::Page::resumeActiveDOMObjectsAndAnimations):
Resume animated images when we're told to.

(WebCore::Page::resumeAnimatingImages):
Kickstart any animated images in all frames.

1:04 PM Changeset in webkit [157055] by dino@apple.com
  • 4 edits
    3 adds in trunk

[Mac] Drawing video into canvas doesn't work on the first attempt
https://bugs.webkit.org/show_bug.cgi?id=122404

Patch by Jer Noble <jer.noble@apple.com> on 2013-10-07
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-canvas-drawing.html

If creating and painting from an AVPlayerItemVideoOutput fails, fall back
to the (much slower) AVAssetImageGenerator path. Make sure to revert to the
AVPlayerItemVideoOutput path when that object begins to have available
images, however.

To do so, remove the "MAC_OS_X_VERSION_MIN_REQUIRED < 1080" check around
the AVAssetImageGenerator code, and allow both the image generator and video
output to exist simultaneously.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::hasContextRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyContextVideoRenderer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyImageGenerator):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivateAVFoundationObjC::videoOutputHasAvailableFrame):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):

LayoutTests:

  • media/video-canvas-drawing-expected.png: Added.
  • media/video-canvas-drawing-expected.txt: Added.
  • media/video-canvas-drawing.html: Added.
12:12 PM Changeset in webkit [157054] by jer.noble@apple.com
  • 5 edits
    6 moves in trunk/Source/WebCore

URLMediaSource.idl and URLMediaStream.idl are wrong
https://bugs.webkit.org/show_bug.cgi?id=122301

Reviewed by Philippe Normand.

Rename URLMediaSource and URLMediaStream to DOMURLMediaSource and DOMURLMediaStream,
respectively.

Update the build files:

  • CMakeLists.txt: Rename URL -> DOMURL.
  • DerivedSources.make: Ditto.
  • GNUmakefile.list.am: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.

Rename the .idl and implementation files:

  • Modules/mediasource/DOMURLMediaSource.cpp: Renamed from Source/WebCore/Modules/mediasource/URLMediaSource.cpp.

(WebCore::DOMURLMediaSource::createObjectURL):

  • Modules/mediasource/DOMURLMediaSource.h: Renamed from Source/WebCore/Modules/mediasource/URLMediaSource.h.
  • Modules/mediasource/DOMURLMediaSource.idl: Renamed from Source/WebCore/Modules/mediasource/URLMediaSource.idl.
  • Modules/mediastream/DOMURLMediaStream.cpp: Renamed from Source/WebCore/Modules/mediastream/URLMediaStream.cpp.

(WebCore::DOMURLMediaStream::createObjectURL):

  • Modules/mediastream/DOMURLMediaStream.h: Renamed from Source/WebCore/Modules/mediastream/URLMediaStream.h.
  • Modules/mediastream/DOMURLMediaStream.idl: Renamed from Source/WebCore/Modules/mediastream/URLMediaStream.idl.
11:58 AM Changeset in webkit [157053] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

css3/images/cross-fade-svg-with-opacity.html fails with colorspace mismatch on Mountain Lion
https://bugs.webkit.org/show_bug.cgi?id=122456

  • platform/mac-wk2/TestExpectations:

Mark the test as failing for now.

11:52 AM Changeset in webkit [157052] by timothy@apple.com
  • 3 edits in trunk/Tools

Properly count binding test failures as failures.

Fix the total for multiple failures in different steps too by avoiding undefined.

https://bugs.webkit.org/show_bug.cgi?id=122232

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:

(BuildbotTestResults):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):

11:50 AM Changeset in webkit [157051] by mihnea@adobe.com
  • 1 edit
    36 moves
    1 add in trunk/LayoutTests

[CSSRegions] Move region styling tests into fast/regions/region-styling
https://bugs.webkit.org/show_bug.cgi?id=122451

Reviewed by Sam Weinig.

Create region-styling folder under fast/regions and move related region styling tests.

  • fast/regions/region-styling/parse-incomplete-region-rule-expected.txt: Renamed from LayoutTests/fast/regions/parse-incomplete-region-rule-expected.txt.
  • fast/regions/region-styling/parse-incomplete-region-rule.html: Renamed from LayoutTests/fast/regions/parse-incomplete-region-rule.html.
  • fast/regions/region-styling/parsing-region-style-rule-expected.txt: Renamed from LayoutTests/fast/regions/parsing-region-style-rule-expected.txt.
  • fast/regions/region-styling/parsing-region-style-rule.html: Renamed from LayoutTests/fast/regions/parsing-region-style-rule.html.
  • fast/regions/region-styling/region-rule-nested-region-rule-expected.html: Renamed from LayoutTests/fast/regions/region-rule-nested-region-rule-expected.html.
  • fast/regions/region-styling/region-rule-nested-region-rule.html: Renamed from LayoutTests/fast/regions/region-rule-nested-region-rule.html.
  • fast/regions/region-styling/region-style-block-background-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color-expected.html.
  • fast/regions/region-styling/region-style-block-background-color.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color.html.
  • fast/regions/region-styling/region-style-block-background-color2-expected.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color2-expected.html.
  • fast/regions/region-styling/region-style-block-background-color2.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color2.html.
  • fast/regions/region-styling/region-style-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-color-expected.html.
  • fast/regions/region-styling/region-style-color.html: Renamed from LayoutTests/fast/regions/region-style-color.html.
  • fast/regions/region-styling/region-style-image-background-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-image-background-color-expected.html.
  • fast/regions/region-styling/region-style-image-background-color.html: Renamed from LayoutTests/fast/regions/region-style-image-background-color.html.
  • fast/regions/region-styling/region-style-in-columns-expected.html: Renamed from LayoutTests/fast/regions/region-style-in-columns-expected.html.
  • fast/regions/region-styling/region-style-in-columns.html: Renamed from LayoutTests/fast/regions/region-style-in-columns.html.
  • fast/regions/region-styling/region-style-inline-background-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-inline-background-color-expected.html.
  • fast/regions/region-styling/region-style-inline-background-color.html: Renamed from LayoutTests/fast/regions/region-style-inline-background-color.html.
  • fast/regions/region-styling/region-style-not-supported-properties-expected.html: Renamed from LayoutTests/fast/regions/region-style-not-supported-properties-expected.html.
  • fast/regions/region-styling/region-style-not-supported-properties.html: Renamed from LayoutTests/fast/regions/region-style-not-supported-properties.html.
  • fast/regions/region-styling/region-style-rule-position-expected.html: Renamed from LayoutTests/fast/regions/region-style-rule-position-expected.html.
  • fast/regions/region-styling/region-style-rule-position.html: Renamed from LayoutTests/fast/regions/region-style-rule-position.html.
  • fast/regions/region-styling/region-style-rule-specificity-expected.html: Renamed from LayoutTests/fast/regions/region-style-rule-specificity-expected.html.
  • fast/regions/region-styling/region-style-rule-specificity.html: Renamed from LayoutTests/fast/regions/region-style-rule-specificity.html.
  • fast/regions/region-styling/region-styling-mediaquery-expected.html: Renamed from LayoutTests/fast/regions/region-styling-mediaquery-expected.html.
  • fast/regions/region-styling/region-styling-mediaquery.html: Renamed from LayoutTests/fast/regions/region-styling-mediaquery.html.
  • fast/regions/region-styling/remove-leftover-anon-block-crash-expected.txt: Renamed from LayoutTests/fast/regions/remove-leftover-anon-block-crash-expected.txt.
  • fast/regions/region-styling/remove-leftover-anon-block-crash.html: Renamed from LayoutTests/fast/regions/remove-leftover-anon-block-crash.html.
  • fast/regions/region-styling/removed-element-style-in-region-crash-expected.txt: Renamed from LayoutTests/fast/regions/removed-element-style-in-region-crash-expected.txt.
  • fast/regions/region-styling/removed-element-style-in-region-crash.html: Renamed from LayoutTests/fast/regions/removed-element-style-in-region-crash.html.
  • fast/regions/region-styling/render-region-custom-style-mark-expected.html: Renamed from LayoutTests/fast/regions/render-region-custom-style-mark-expected.html.
  • fast/regions/region-styling/render-region-custom-style-mark.html: Renamed from LayoutTests/fast/regions/render-region-custom-style-mark.html.
  • fast/regions/region-styling/set-box-style-in-region-crash-expected.txt: Renamed from LayoutTests/fast/regions/set-box-style-in-region-crash-expected.txt.
  • fast/regions/region-styling/set-box-style-in-region-crash.html: Renamed from LayoutTests/fast/regions/set-box-style-in-region-crash.html.
  • fast/regions/region-styling/webkit-region-rule-expected.txt: Renamed from LayoutTests/fast/regions/webkit-region-rule-expected.txt.
  • fast/regions/region-styling/webkit-region-rule.html: Renamed from LayoutTests/fast/regions/webkit-region-rule.html.
11:20 AM Changeset in webkit [157050] by msaboff@apple.com
  • 17 edits in trunk/Source/JavaScriptCore

Transition stack check JITStubs to CCallHelper functions
https://bugs.webkit.org/show_bug.cgi?id=122289

Reviewed by Filip Pizlo.

Replaced jit stubs cti_stack_check, cti_op_call_arityCheck and cti_op_construct_arityCheck with
jit operations operationStackCheck, operationCallArityCheck & operationConstructArityCheck.
Added new callOperationWithCallFrameRollbackOnException() in baseline and DFG JITs to call
these new functions. Added code to unwind one frame in JIT::privateCompileExceptionHandlers()
and JITCompiler::compileExceptionHandlers() for these cases that need to throw exceptions in
their caller frame when the stack is exhausted.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::andPtr): Added to handle masking a pointer with a literal.

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::and64): Added to handle masking a pointer with a literal.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileExceptionHandlers):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::linkFunction):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::exceptionCheckWithCallFrameRollback):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperationWithCallFrameRollbackOnException):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
(JSC::DFG::SpeculativeJIT::appendCallWithCallFrameRollbackOnException):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
(JSC::DFG::SpeculativeJIT::appendCallWithCallFrameRollbackOnExceptionSetResult):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • interpreter/CallFrame.h:

(JSC::ExecState::hostCallFrameFlag):

  • jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::jitAssertIsNull):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::jitAssertIsNull):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):
(JSC::JIT::privateCompileExceptionHandlers):

  • jit/JIT.h:

(JSC::JIT::exceptionCheckWithCallFrameRollback):

  • jit/JITInlines.h:

(JSC::JIT::appendCallWithCallFrameRollbackOnException):
(JSC::JIT::callOperationWithCallFrameRollbackOnException):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
11:07 AM Changeset in webkit [157049] by andersca@apple.com
  • 3 edits in trunk/Source/WTF

Remove passIn and passOut from HashTraits
https://bugs.webkit.org/show_bug.cgi?id=122452

Reviewed by Sam Weinig.

Change RefPtrHashMap to not use passOut (just like the regular HashMap) and get rid of the
passIn and passOut functions and related typedefs.

  • wtf/HashTraits.h:
  • wtf/RefPtrHashMap.h:
10:45 AM Changeset in webkit [157048] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Conditional support in bindings code generator for overloaded functions
https://bugs.webkit.org/show_bug.cgi?id=122443

Patch by Philippe Normand <pnormand@igalia.com> on 2013-10-07
Reviewed by Darin Adler.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateOverloadedFunction): Generate conditional for overloaded
function, if it's present in the idl.
(GenerateImplementation): Close the last overloaded function
conditional before generating the distpatch function.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjConstructorFunctionOverloadedMethod1):
Rebaseline overloaded function tests.

10:42 AM Changeset in webkit [157047] by fpizlo@apple.com
  • 4 edits in trunk

ASSERTION FAILED: isUInt32() in jsc-layout-tests.yaml/js/script-tests/dfg-uint32-to-number-in-middle-of-copy-propagation.js.layout-dfg-eager-no-cjit
https://bugs.webkit.org/show_bug.cgi?id=122419

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

AI was using JSValue::asUInt32() incorrectly. That method presumes that the input is
both a int32 and a uint32 (it's in the range [0, 231)). The UInt32ToNumber node is
instead dealing with an input that is always represented as a int32 but that has the
meaning of a uint32 - so AI should use JSValue::asInt32() and then do the cast.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

LayoutTests:

Reviewed by Oliver Hunt.

  • js/script-tests/dfg-uint32-to-number-in-middle-of-copy-propagation.js:
9:59 AM Changeset in webkit [157046] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[sh4] Jump over maxJumpReplacementSize in revertJumpToMove.
https://bugs.webkit.org/show_bug.cgi?id=120007

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-07
Reviewed by Oliver Hunt.

Jump over maxJumpReplacementSize in revertJumpToMove, even if there is no constant
value within the area. This patch fixes debug ASSERTs failures for sh4 architecture.

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::revertJumpToMove):

9:48 AM Changeset in webkit [157045] by timothy_horton@apple.com
  • 3 edits
    2 adds in trunk

-webkit-cross-fade paints SVGs at full opacity during cross-fade
https://bugs.webkit.org/show_bug.cgi?id=122441
<rdar://problem/13973162>

Reviewed by Simon Fraser.

Test: css3/images/cross-fade-svg-with-opacity.html

  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::drawCrossfadeSubimage):
(WebCore::CrossfadeGeneratedImage::drawCrossfade):
Factor the image painting out into a function.
Conditionally use a transparency layer around painting if the image
we're drawing is an SVG (SVGImage is the only Image subclass that will
not respect the context's opacity).

Add a test that ensures that -cross-fade with SVG images draws correctly.

  • css3/images/cross-fade-svg-with-opacity-expected.html: Added.
  • css3/images/cross-fade-svg-with-opacity.html: Added.
9:26 AM Changeset in webkit [157044] by andersca@apple.com
  • 251 edits in trunk/Source

Add OVERRIDE and virtual where appropriate
https://bugs.webkit.org/show_bug.cgi?id=122439

Reviewed by Antti Koivisto.

Source/JavaScriptCore:

  • API/JSAPIWrapperObject.mm:
  • API/JSCallbackObject.h:

(JSC::JSCallbackObjectData::~JSCallbackObjectData):

  • API/JSManagedValue.mm:
  • API/JSScriptRef.cpp:

(OpaqueJSScript::~OpaqueJSScript):

  • bytecode/CodeBlock.h:
  • bytecode/StructureStubClearingWatchpoint.h:
  • dfg/DFGArrayifySlowPathGenerator.h:
  • dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
  • dfg/DFGFailedFinalizer.h:
  • dfg/DFGJITCode.h:
  • dfg/DFGJITFinalizer.h:
  • dfg/DFGSaneStringGetByValSlowPathGenerator.h:
  • dfg/DFGSlowPathGenerator.h:
  • dfg/DFGSpeculativeJIT64.cpp:
  • heap/Heap.h:
  • heap/IncrementalSweeper.h:
  • heap/SuperRegion.h:
  • jit/ClosureCallStubRoutine.h:
  • jit/ExecutableAllocatorFixedVMPool.cpp:
  • jit/GCAwareJITStubRoutine.h:
  • jit/JITCode.h:
  • jit/JITStubs.cpp:
  • jit/JITToDFGDeferredCompilationCallback.h:
  • jit/JumpReplacementWatchpoint.h:
  • parser/Nodes.h:
  • runtime/DataView.h:
  • runtime/GCActivityCallback.h:
  • runtime/GenericTypedArrayView.h:
  • runtime/RegExpCache.h:
  • runtime/SimpleTypedArrayController.h:
  • runtime/WeakMapData.h:

Source/WebCore:

  • Modules/encryptedmedia/MediaKeys.h:
  • Modules/webaudio/AnalyserNode.h:
  • Modules/webaudio/AudioBasicInspectorNode.h:
  • Modules/webaudio/AudioBasicProcessorNode.h:
  • Modules/webaudio/AudioBufferSourceNode.h:
  • Modules/webaudio/AudioContext.h:
  • Modules/webaudio/AudioDestinationNode.h:
  • Modules/webaudio/AudioProcessingEvent.h:
  • Modules/webaudio/BiquadDSPKernel.h:
  • Modules/webaudio/BiquadProcessor.h:
  • Modules/webaudio/ChannelMergerNode.h:
  • Modules/webaudio/ChannelSplitterNode.h:
  • Modules/webaudio/ConvolverNode.h:
  • Modules/webaudio/DelayDSPKernel.h:
  • Modules/webaudio/DelayProcessor.h:
  • Modules/webaudio/DynamicsCompressorNode.h:
  • Modules/webaudio/GainNode.h:
  • Modules/webaudio/MediaElementAudioSourceNode.h:
  • Modules/webaudio/OfflineAudioCompletionEvent.h:
  • Modules/webaudio/OfflineAudioDestinationNode.h:
  • Modules/webaudio/OscillatorNode.h:
  • Modules/webaudio/PannerNode.h:
  • Modules/webaudio/ScriptProcessorNode.h:
  • Modules/webaudio/WaveShaperProcessor.h:
  • accessibility/AccessibilityARIAGrid.h:
  • accessibility/AccessibilityARIAGridCell.h:
  • accessibility/AccessibilityARIAGridRow.h:
  • accessibility/AccessibilityImageMapLink.h:
  • accessibility/AccessibilityList.h:
  • accessibility/AccessibilityListBox.h:
  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityMediaControls.h:
  • accessibility/AccessibilityMenuList.h:
  • accessibility/AccessibilityMenuListOption.h:
  • accessibility/AccessibilityMenuListPopup.h:
  • accessibility/AccessibilityMockObject.h:
  • accessibility/AccessibilityNodeObject.h:
  • accessibility/AccessibilityProgressIndicator.h:
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilitySVGRoot.h:
  • accessibility/AccessibilityScrollView.h:
  • accessibility/AccessibilityScrollbar.h:
  • accessibility/AccessibilitySlider.h:
  • accessibility/AccessibilitySpinButton.h:
  • accessibility/AccessibilityTable.h:
  • accessibility/AccessibilityTableCell.h:
  • accessibility/AccessibilityTableColumn.h:
  • accessibility/AccessibilityTableHeaderContainer.h:
  • accessibility/AccessibilityTableRow.h:
  • bindings/js/JSEventListener.h:
  • bindings/js/WebCoreTypedArrayController.h:
  • bridge/c/c_class.h:
  • bridge/c/c_instance.h:
  • bridge/c/c_runtime.h:
  • bridge/runtime_root.h:
  • css/CSSBasicShapes.h:
  • css/CSSComputedStyleDeclaration.h:
  • css/CSSStyleSheet.h:
  • dom/Attr.h:
  • dom/BeforeTextInsertedEvent.h:
  • dom/CDATASection.h:
  • dom/ChildNodeList.h:
  • dom/DatasetDOMStringMap.h:
  • dom/Document.h:
  • dom/DocumentEventQueue.h:
  • dom/DocumentFragment.h:
  • dom/Element.h:
  • dom/ErrorEvent.h:
  • dom/KeyboardEvent.h:
  • dom/Node.h:
  • dom/PageTransitionEvent.h:
  • dom/ProgressEvent.h:
  • dom/PseudoElement.h:
  • dom/ScriptExecutionContext.h:
  • dom/ShadowRoot.h:
  • dom/StyledElement.h:
  • dom/TagNodeList.h:
  • dom/Text.h:
  • dom/TextEvent.h:
  • dom/TransitionEvent.h:
  • dom/UIEvent.h:
  • dom/WebKitAnimationEvent.h:
  • dom/WebKitTransitionEvent.h:
  • editing/ApplyBlockElementCommand.h:
  • editing/ApplyStyleCommand.h:
  • editing/BreakBlockquoteCommand.h:
  • editing/CompositeEditCommand.h:
  • editing/SpellingCorrectionCommand.h:
  • fileapi/File.h:
  • fileapi/FileThreadTask.h:
  • history/BackForwardList.h:
  • html/BaseCheckableInputType.h:
  • html/HTMLAnchorElement.h:
  • html/HTMLAreaElement.h:
  • html/HTMLCanvasElement.h:
  • html/HTMLCollection.h:
  • html/HTMLElement.h:
  • html/HTMLFieldSetElement.h:
  • html/HTMLFormControlElement.h:
  • html/HTMLFormControlElementWithState.h:
  • html/HTMLFormElement.h:
  • html/HTMLFrameElementBase.h:
  • html/HTMLImageElement.h:
  • html/HTMLImageLoader.h:
  • html/HTMLInputElement.h:
  • html/HTMLLabelElement.h:
  • html/HTMLLegendElement.h:
  • html/HTMLMediaElement.h:
  • html/HTMLMeterElement.h:
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.h:
  • html/HTMLPlugInElement.h:
  • html/HTMLPlugInImageElement.h:
  • html/HTMLProgressElement.h:
  • html/HTMLSelectElement.h:
  • html/HTMLTableElement.h:
  • html/HTMLTextAreaElement.h:
  • html/HTMLTextFormControlElement.h:
  • html/HTMLVideoElement.h:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • html/shadow/MediaControlElementTypes.h:
  • html/shadow/MediaControlElements.h:
  • html/shadow/SpinButtonElement.h:
  • html/shadow/TextControlInnerElements.h:
  • html/track/AudioTrackList.h:
  • html/track/TextTrackList.h:
  • html/track/TrackListBase.h:
  • inspector/InspectorValues.h:
  • loader/EmptyClients.h:
  • loader/ImageLoader.h:
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.h:
  • loader/appcache/ApplicationCacheGroup.cpp:
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/appcache/DOMApplicationCache.h:
  • loader/archive/cf/LegacyWebArchive.h:
  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedFont.h:
  • loader/cache/CachedFontClient.h:
  • loader/cache/CachedImageClient.h:
  • loader/cache/CachedSVGDocumentClient.h:
  • loader/cache/CachedStyleSheetClient.h:
  • loader/cache/CachedXSLStyleSheet.h:
  • page/Chrome.h:
  • page/DOMWindow.h:
  • page/FrameView.h:
  • page/animation/ImplicitAnimation.h:
  • platform/PODIntervalTree.h:
  • platform/PODRedBlackTree.h:
  • platform/ScrollView.h:
  • platform/Scrollbar.h:
  • platform/Timer.h:
  • platform/animation/TimingFunction.h:

(WebCore::LinearTimingFunction::~LinearTimingFunction):
(WebCore::CubicBezierTimingFunction::~CubicBezierTimingFunction):
(WebCore::StepsTimingFunction::~StepsTimingFunction):

  • platform/audio/AudioDSPKernelProcessor.h:
  • platform/audio/HRTFPanner.h:
  • platform/audio/mac/AudioDestinationMac.h:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/filters/FilterOperation.h:
  • platform/network/ResourceHandle.h:
  • rendering/AutoTableLayout.h:
  • rendering/ClipPathOperation.h:
  • rendering/InlineFlowBox.h:
  • rendering/RenderBlock.h:
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderButton.h:
  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFlowThread.h:
  • rendering/RenderFullScreen.h:
  • rendering/RenderImage.h:
  • rendering/RenderLayer.h:
  • rendering/RenderLineBreak.h:
  • rendering/RenderListBox.h:
  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.h:
  • rendering/RenderMenuList.h:
  • rendering/RenderMeter.h:
  • rendering/RenderObject.h:
  • rendering/RenderReplaced.h:
  • rendering/RenderSlider.h:
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.h:
  • rendering/RenderText.h:
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderTextFragment.h:
  • rendering/RenderView.h:
  • rendering/RootInlineBox.h:
  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLFraction.h:
  • rendering/mathml/RenderMathMLOperator.h:
  • rendering/style/BasicShapes.h:
  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGShape.h:
  • svg/SVGAnimatedBoolean.h:
  • svg/SVGAnimatedString.h:
  • svg/SVGAnimatedTransformList.h:
  • svg/SVGDocument.h:
  • svg/SVGElement.h:
  • svg/SVGElementInstance.h:
  • svg/SVGFontElement.h:
  • svg/SVGGElement.h:
  • svg/SVGGraphicsElement.h:
  • svg/SVGTransformable.h:
  • svg/properties/SVGAnimatedListPropertyTearOff.h:
  • svg/properties/SVGAnimatedPropertyMacros.h:
  • svg/properties/SVGAnimatedTransformListPropertyTearOff.h:
  • svg/properties/SVGListPropertyTearOff.h:
  • svg/properties/SVGPropertyTearOff.h:
  • workers/WorkerGlobalScope.h:

Source/WTF:

  • wtf/Compiler.h:
  • wtf/FilePrintStream.h:
  • wtf/StringPrintStream.h:
8:50 AM Changeset in webkit [157043] by fpizlo@apple.com
  • 4 edits in trunk

Trap 5 (most likely int $3) in jsc-layout-tests.yaml/js/script-tests/integer-division-neg2tothe32-by-neg1.js.layout-dfg-eager-no-cjit
https://bugs.webkit.org/show_bug.cgi?id=122420

Source/JavaScriptCore:

Reviewed by Michael Saboff.

For the (-231/-1)|0 case, we were returning the left operand (i.e. -231) but we were
failing to account for the possibility that this operand has high-bit garbage and
int32Result() requires that the high bits are zero.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithDiv):

LayoutTests:

Reviewed by Michael Saboff.

  • js/script-tests/integer-division-neg2tothe32-by-neg1.js:
8:47 AM Changeset in webkit [157042] by Philippe Normand
  • 3 edits in trunk/Source/WebKit/gtk

[GTK] UserMediaClientGtk needs API update
https://bugs.webkit.org/show_bug.cgi?id=122324

Reviewed by Martin Robinson.

Update UserMediaClientGtk API after changes made in the parent
class in r156473.

  • WebCoreSupport/UserMediaClientGtk.cpp:

(WebKit::UserMediaClientGtk::requestPermission):
(WebKit::UserMediaClientGtk::cancelRequest):

  • WebCoreSupport/UserMediaClientGtk.h:
8:32 AM Changeset in webkit [157041] by Philippe Normand
  • 3 edits in trunk/Source/WebCore

URLMediaStream is unguarded by ENABLE(MEDIA_STREAM)
https://bugs.webkit.org/show_bug.cgi?id=122444

Reviewed by Martin Robinson.

  • Modules/mediastream/URLMediaStream.cpp: Added missing

conditional guards.

  • Modules/mediastream/URLMediaStream.h: Ditto.
8:29 AM Changeset in webkit [157040] by Philippe Normand
  • 4 edits in trunk/Source/WebCore

[GTK] webkit_dom_html_style_element_{s,g}et_scoped was removed
https://bugs.webkit.org/show_bug.cgi?id=122446

Reviewed by Martin Robinson.

Added skeleton functions warning of removed functionality for
the <style scoped> GObject DOM binding.

  • bindings/gobject/WebKitDOMCustom.cpp:
  • bindings/gobject/WebKitDOMCustom.h:
  • bindings/gobject/WebKitDOMCustom.symbols:
8:24 AM Changeset in webkit [157039] by Csaba Osztrogonác
  • 5 edits in trunk/Source/WebCore

Unreviewed buildfix for GCC 4.6.

Changed override to OVERRIDE and final to FINAL.

  • page/PageSerializer.cpp:
  • workers/AbstractWorker.h:
  • workers/SharedWorker.h:
  • workers/Worker.h:
8:10 AM Changeset in webkit [157038] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: Facebook wrapped a file upload button in an unfocusable ARIA button, which doesn't work with AXPress.
https://bugs.webkit.org/show_bug.cgi?id=122252

Reviewed by Mario Sanchez Prada.

Source/WebCore:

When an author uses a control-type ARIA role (like button), but then hides a native control-type inside,
AXPress needs to operate on the inside node if possible.

Test: accessibility/axpress-on-aria-button.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::isNodeActionElement):
(WebCore::nativeActionElement):
(WebCore::AccessibilityNodeObject::actionElement):

LayoutTests:

  • accessibility/axpress-on-aria-button-expected.txt: Added.
  • accessibility/axpress-on-aria-button.html: Added.
7:51 AM Changeset in webkit [157037] by kov@webkit.org
  • 2 edits in trunk/Tools

[GTK] Fails to build with jhbuild with newer system glib
https://bugs.webkit.org/show_bug.cgi?id=122132

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-10-07
Reviewed by Martin Robinson.

Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
started relying on. glib is not a dependency that should change test results, and is provided in
jhbuild with the intention of supporting the other bits that do, so using a newer stable release
should not be an issue.

  • gtk/jhbuild.modules:
7:44 AM Changeset in webkit [157036] by fpizlo@apple.com
  • 2 edits in trunk/Tools

run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
https://bugs.webkit.org/show_bug.cgi?id=122437

Reviewed by Antoine Quint.

  • Scripts/run-jsc-stress-tests:
7:36 AM Changeset in webkit [157035] by fpizlo@apple.com
  • 12 edits in trunk

ASSERTION FAILED: bitwise_cast<WriteBarrier<Unknown>*>(callFrame) == m_registers in jsc-layout-tests.yaml/js/script-tests/dfg-inline-arguments-capture-throw-exception.js.layout-dfg-eager-no-cjit
https://bugs.webkit.org/show_bug.cgi?id=122418

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This is pretty awesome. With stack compression, Arguments created in the DFG will point
their m_registers pointers into a different slab of stack than they would have in byte
code.

Hence OSR exit must repoint any Arguments objects' m_registers pointers. It previously
neglected to do so. This patch fixes that.

Fixing this unveiled another bug: the stack reversal broke the reification of inlined
phantom arguments.

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnArguments):
(JSC::DFG::SpeculativeJIT::compileGetArgumentsLength):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/Arguments.h:

(JSC::Arguments::offsetOfNumArguments):
(JSC::Arguments::offsetOfRegisters):
(JSC::Arguments::offsetOfSlowArgumentData):
(JSC::Arguments::offsetOfOverrodeLength):

LayoutTests:

  • js/script-tests/dfg-arguments-osr-exit-multiple-blocks-before-exit.js:
  • js/script-tests/dfg-arguments-osr-exit-multiple-blocks.js:
  • js/script-tests/dfg-arguments-osr-exit.js:
  • js/script-tests/dfg-inline-arguments-capture-throw-exception.js:
4:37 AM Changeset in webkit [157034] by g.czajkowski@samsung.com
  • 2 edits in trunk/LayoutTests

context-menu-suggestions-multiword-selection.html and context-menu-suggestions-subword-selection.html are flaky after r156901.
https://bugs.webkit.org/show_bug.cgi?id=122414

Unreviewed gardening.

  • platform/mac/TestExpectations:

Similarly to r156990, mark context-menu-suggestions-subword-selection.html as flaky.

Change-Id: I787b1d5a5a328f747799434fd7b984eec6947cd1

2:01 AM Changeset in webkit [157033] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed debug build fix for ports enabling the <template> element support.

  • html/HTMLTagNames.in: Generate type helpers for the <template> element as they're required

by the assertions in the Element type casts for HTMLTemplateElement.

1:26 AM WebKitGTK/2.2.x edited by ltilve@igalia.com
(diff)
12:48 AM Changeset in webkit [157032] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

[EFL] Build fix after r157002
https://bugs.webkit.org/show_bug.cgi?id=122434

Reviewed by Sam Weinig.

  • editing/markup.cpp: Changed override to OVERRIDE.
12:29 AM Changeset in webkit [157031] by Carlos Garcia Campos
  • 9 edits in releases/WebKitGTK/webkit-2.2/Source

Merge r156345 - [GTK] Fix compilation problems when setting ENABLE_DRAG_SUPPORT = FALSE
https://bugs.webkit.org/show_bug.cgi?id=121782

Patch by Lorenzo Tilve <ltilve@igalia.com> on 2013-09-24
Reviewed by Martin Robinson.

Disabled drag functions.

Source/WebCore:

  • page/gtk/EventHandlerGtk.cpp:
  • platform/gtk/PasteboardGtk.cpp:

Source/WebKit/gtk:

  • WebCoreSupport/DragClientGtk.cpp:
  • WebCoreSupport/DragClientGtk.h:

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkit_web_view_base_class_init):

  • WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
12:29 AM Changeset in webkit [157030] by Philippe Normand
  • 4 edits in trunk/Source/WebCore

MediaStreamTrack can't be FINAL
https://bugs.webkit.org/show_bug.cgi?id=122322

Reviewed by Darin Adler.

Marked the MediaStreamTrack subclasses as final.

  • Modules/mediastream/AudioStreamTrack.h:
  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/VideoStreamTrack.h:
12:27 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
12:25 AM Changeset in webkit [157029] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r156287 - [GTK][WK2] A plugin dirtyRect within iframe remains after moving to a different page.
https://bugs.webkit.org/show_bug.cgi?id=121600

Reviewed by Gustavo Noronha Silva.

Nowhere to destroy NetscapePlugin::m_platformPluginWidget even after destroying
an instance of NetscapePlugin. So the created GtkWidget remains visible.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformDestroy):

12:24 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
12:02 AM Changeset in webkit [157028] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore

Merge r156003 - DFG doesn't properly keep scope alive for op_put_to_scope
https://bugs.webkit.org/show_bug.cgi?id=121519

Reviewed by Michael Saboff.

This was a latent bug that can't actually occur in ToT. It was uncovered by causing slow
path calls in the baseline JIT for op_put_to_scope in places where we couldn't before (but
which were necessary for gen GC).

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

12:01 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
12:01 AM Changeset in webkit [157027] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore

Merge r155495 - WebKit crashes when trying to send a msg via 'today's birthdays' dialogue box on Facebook
https://bugs.webkit.org/show_bug.cgi?id=120612#add_comment
Patch by Chris Curtis <chris_curtis@apple.com> on 2013-09-10
Reviewed by Geoffrey Garen.

The codeBlock was assumed to exist when appendSourceToMessage was set.
This was an invalid assumption. I added a check to ensure that there is a
valid codeBlock before accessing it.

  • API/tests/testapi.c:

(valueToObjectExceptionCallAsFunction):
(valueToObjectExceptionTest):
(main):

  • runtime/VM.cpp:

(JSC::VM::throwException):

12:00 AM Changeset in webkit [157026] by Carlos Garcia Campos
  • 35 edits
    4 copies
    2 deletes in releases/WebKitGTK/webkit-2.2/Source/JavaScriptCore

Merge r154824 - CodeBlock compilation and installation should be simplified and rationalized
https://bugs.webkit.org/show_bug.cgi?id=120326

Reviewed by Oliver Hunt.

Rolling r154804 back in after fixing no-LLInt build.

Previously Executable owned the code for generating JIT code; you always had
to go through Executable. But often you also had to go through CodeBlock,
because ScriptExecutable couldn't have virtual methods, but CodeBlock could.
So you'd ask CodeBlock to do something, which would dispatch through a
virtual method that would select the appropriate Executable subtype's method.
This all meant that the same code would often be duplicated, because most of
the work needed to compile something was identical regardless of code type.
But then we tried to fix this, by having templatized helpers in
ExecutionHarness.h and JITDriver.h. The result was that if you wanted to find
out what happened when you asked for something to be compiled, you'd go on a
wild ride that started with CodeBlock, touched upon Executable, and then
ricocheted into either ExecutionHarness or JITDriver (likely both).

Another awkwardness was that for concurrent compiles, the DFG::Worklist had
super-special inside knowledge of what JITStubs.cpp's cti_optimize would have
done once the compilation finished.

Also, most of the DFG JIT drivers assumed that they couldn't install the
JITCode into the CodeBlock directly - instead they would return it via a
reference, which happened to be a reference to the JITCode pointer in
Executable. This was super weird.

Finally, there was no notion of compiling code into a special CodeBlock that
wasn't used for handling calls into an Executable. I'd like this for FTL OSR
entry.

This patch solves these problems by reducing all of that complexity into just
three primitives:

  • Executable::newCodeBlock(). This gives you a new code block, either for call or for construct, and either to serve as the baseline code or the optimized code. The new code block is then owned by the caller; Executable doesn't register it anywhere. The new code block has no JITCode and isn't callable, but it has all of the bytecode.
  • CodeBlock::prepareForExecution(). This takes the CodeBlock's bytecode and produces a JITCode, and then installs the JITCode into the CodeBlock. This method takes a JITType, and always compiles with that JIT. If you ask for JITCode::InterpreterThunk then you'll get JITCode that just points to the LLInt entrypoints. Once this returns, it is possible to call into the CodeBlock if you do so manually - but the Executable still won't know about it so JS calls to that Executable will still be routed to whatever CodeBlock is associated with the Executable.
  • Executable::installCode(). This takes a CodeBlock and makes it the code-for- entry for that Executable. This involves unlinking the Executable's last CodeBlock, if there was one. This also tells the GC about any effect on memory usage and does a bunch of weird data structure rewiring, since Executable caches some of CodeBlock's fields for the benefit of virtual call fast paths.

This functionality is then wrapped around three convenience methods:

  • Executable::prepareForExecution(). If there is no code block for that Executable, then one is created (newCodeBlock()), compiled (CodeBlock::prepareForExecution()) and installed (installCode()).
  • CodeBlock::newReplacement(). Asks the Executable for a new CodeBlock that can serve as an optimized replacement of the current one.
  • CodeBlock::install(). Asks the Executable to install this code block.

This patch allows me to kill *a lot* of code and to remove a lot of
specializations for functions vs. not-functions, and a lot of places where we
pass around JITCode references and such. ExecutionHarness and JITDriver are
both gone. Overall this patch has more red than green.

It also allows me to work on FTL OSR entry and tier-up:

  • FTL tier-up: this will involve DFGOperations.cpp asking the DFG::Worklist to do some compilation, but it will require the DFG::Worklist to do something different than what JITStubs.cpp would want, once the compilation finishes. This patch introduces a callback mechanism for that purpose.
  • FTL OSR entry: this will involve creating a special auto-jettisoned CodeBlock that is used only for FTL OSR entry. The new set of primitives allows for this: Executable can vend you a fresh new CodeBlock, and you can ask that CodeBlock to compile itself with any JIT of your choosing. Or you can take that CodeBlock and compile it yourself. Previously the act of producing a CodeBlock-for-optimization and the act of compiling code for it were tightly coupled; now you can separate them and you can create such auto-jettisoned CodeBlocks that are used for a one-shot OSR entry.
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::prepareForExecutionImpl):
(JSC::CodeBlock::prepareForExecution):
(JSC::CodeBlock::prepareForExecutionAsynchronously):
(JSC::CodeBlock::install):
(JSC::CodeBlock::newReplacement):
(JSC::FunctionCodeBlock::jettisonImpl):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::hasBaselineJITProfiling):

  • bytecode/DeferredCompilationCallback.cpp: Added.

(JSC::DeferredCompilationCallback::DeferredCompilationCallback):
(JSC::DeferredCompilationCallback::~DeferredCompilationCallback):

  • bytecode/DeferredCompilationCallback.h: Added.
  • dfg/DFGDriver.cpp:

(JSC::DFG::tryCompile):

  • dfg/DFGDriver.h:

(JSC::DFG::tryCompile):

  • dfg/DFGFailedFinalizer.cpp:

(JSC::DFG::FailedFinalizer::finalize):
(JSC::DFG::FailedFinalizer::finalizeFunction):

  • dfg/DFGFailedFinalizer.h:
  • dfg/DFGFinalizer.h:
  • dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::finalize):
(JSC::DFG::JITFinalizer::finalizeFunction):

  • dfg/DFGJITFinalizer.h:
  • dfg/DFGOSRExitPreparation.cpp:

(JSC::DFG::prepareCodeOriginForOSRExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::compileInThreadImpl):
(JSC::DFG::Plan::notifyReady):
(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):
(JSC::DFG::Plan::finalizeAndNotifyCallback):

  • dfg/DFGPlan.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::completeAllReadyPlansForVM):
(JSC::DFG::Worklist::runThread):

  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalize):
(JSC::FTL::JITFinalizer::finalizeFunction):

  • ftl/FTLJITFinalizer.h:
  • heap/Heap.h:

(JSC::Heap::isDeferred):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):

  • jit/JITDriver.h: Removed.
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC::jitCompileFor):
(JSC::lazyLinkFor):

  • jit/JITToDFGDeferredCompilationCallback.cpp: Added.

(JSC::JITToDFGDeferredCompilationCallback::JITToDFGDeferredCompilationCallback):
(JSC::JITToDFGDeferredCompilationCallback::~JITToDFGDeferredCompilationCallback):
(JSC::JITToDFGDeferredCompilationCallback::create):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidComplete):

  • jit/JITToDFGDeferredCompilationCallback.h: Added.
  • llint/LLIntEntrypoints.cpp:

(JSC::LLInt::setFunctionEntrypoint):
(JSC::LLInt::setEvalEntrypoint):
(JSC::LLInt::setProgramEntrypoint):

  • llint/LLIntEntrypoints.h:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::setUpCall):

  • runtime/ArrayPrototype.cpp:

(JSC::isNumericCompareFunction):

  • runtime/CommonSlowPaths.cpp:
  • runtime/CompilationResult.cpp:

(WTF::printInternal):

  • runtime/CompilationResult.h:
  • runtime/Executable.cpp:

(JSC::ScriptExecutable::installCode):
(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::ScriptExecutable::newReplacementCodeBlockFor):
(JSC::ScriptExecutable::prepareForExecutionImpl):

  • runtime/Executable.h:

(JSC::ExecutableBase::offsetOfJITCodeWithArityCheckFor):
(JSC::ExecutableBase::offsetOfNumParametersFor):
(JSC::ScriptExecutable::prepareForExecution):
(JSC::FunctionExecutable::jettisonOptimizedCodeFor):

  • runtime/ExecutionHarness.h: Removed.

Oct 6, 2013:

11:56 PM Changeset in webkit [157025] by Carlos Garcia Campos
  • 90 edits in releases/WebKitGTK/webkit-2.2

Merge r154797 - Source/JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.

Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.

Gardening of exception throws. The act of throwing an exception was being handled in
different ways depending on whether the code was running in the LLint, Baseline JIT,
or the DFG Jit. This made development in the vm exception and error objects difficult.

  • runtime/VM.cpp:

(JSC::appendSourceToError):
This function moved from the interpreter into the VM. It views the developers code
(if there is a codeBlock) to extract what was trying to be evaluated when the error
occurred.

(JSC::VM::throwException):
This function takes in the error object and sets the following:

1: The VM's exception stack
2: The VM's exception
3: Appends extra information on the error message(via appendSourceToError)
4: The error object's line number
5: The error object's column number
6: The error object's sourceURL
7: The error object's stack trace (unless it already exists because the developer

created the error object).

(JSC::VM::getExceptionInfo):
(JSC::VM::setExceptionInfo):
(JSC::VM::clearException):
(JSC::clearExceptionStack):

  • runtime/VM.h:

(JSC::VM::exceptionOffset):
(JSC::VM::exception):
(JSC::VM::addressOfException):
(JSC::VM::exceptionStack):
VM exception and exceptionStack are now private data members.

  • interpreter/Interpreter.h:

(JSC::ClearExceptionScope::ClearExceptionScope):
Created this structure to temporarily clear the exception within the VM. This
needed to see if addition errors occur when setting the debugger as we are
unwinding the stack.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwind):
Removed the code that would try to add error information if it did not exist.
All of this functionality has moved into the VM and all error information is set
at the time the error occurs.

The rest of these functions reference the new calling convention to throw an error.

  • API/APICallbackFunction.h:

(JSC::APICallbackFunction::call):

  • API/JSCallbackConstructor.cpp:

(JSC::constructJSCallback):

  • API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertySlot):
(JSC::::defaultValue):
(JSC::::put):
(JSC::::putByIndex):
(JSC::::deleteProperty):
(JSC::::construct):
(JSC::::customHasInstance):
(JSC::::call):
(JSC::::getStaticValue):
(JSC::::staticFunctionGetter):
(JSC::::callbackGetter):

  • debugger/Debugger.cpp:

(JSC::evaluateInGlobalCallFrame):

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluate):

  • dfg/DFGAssemblyHelpers.h:

(JSC::DFG::AssemblyHelpers::emitExceptionCheck):

  • dfg/DFGOperations.cpp:

(JSC::DFG::operationPutByValInternal):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::callCheck):

  • heap/Heap.cpp:

(JSC::Heap::markRoots):

  • interpreter/CallFrame.h:

(JSC::ExecState::clearException):
(JSC::ExecState::exception):
(JSC::ExecState::hadException):

  • interpreter/Interpreter.cpp:

(JSC::eval):
(JSC::loadVarargs):
(JSC::stackTraceAsString):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):

  • interpreter/Interpreter.h:

(JSC::ClearExceptionScope::ClearExceptionScope):

  • jit/JITCode.cpp:

(JSC::JITCode::execute):

  • jit/JITExceptions.cpp:

(JSC::genericThrow):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_catch):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_catch):

  • jit/JITStubs.cpp:

(JSC::returnToThrowTrampoline):
(JSC::throwExceptionFromOpCall):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::jitCompileFor):
(JSC::lazyLinkFor):
(JSC::putByVal):
(JSC::cti_vm_handle_exception):

  • jit/SlowPathCall.h:

(JSC::JITSlowPathCall::call):

  • jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator):

  • jsc.cpp:

(functionRun):
(functionLoad):
(functionCheckSyntax):

  • llint/LLIntExceptions.cpp:

(JSC::LLInt::doThrow):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/ArrayConstructor.cpp:

(JSC::constructArrayWithSizeQuirk):

  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::opIn):

  • runtime/CommonSlowPathsExceptions.cpp:

(JSC::CommonSlowPaths::interpreterThrowInCaller):

  • runtime/Completion.cpp:

(JSC::evaluate):

  • runtime/Error.cpp:

(JSC::addErrorInfo):
(JSC::throwTypeError):
(JSC::throwSyntaxError):

  • runtime/Error.h:

(JSC::throwVMError):

  • runtime/ExceptionHelpers.cpp:

(JSC::throwOutOfMemoryError):
(JSC::throwStackOverflowError):
(JSC::throwTerminatedExecutionException):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::create):
(JSC::FunctionExecutable::produceCodeBlockFor):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunction):
(JSC::constructFunctionSkippingEvalEnabledCheck):

  • runtime/JSArray.cpp:

(JSC::JSArray::defineOwnProperty):
(JSC::JSArray::put):
(JSC::JSArray::push):

  • runtime/JSCJSValue.cpp:

(JSC::JSValue::toObjectSlowCase):
(JSC::JSValue::synthesizePrototype):
(JSC::JSValue::putToPrimitive):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::defineOwnProperty):

  • runtime/JSGenericTypedArrayViewInlines.h:

(JSC::::create):
(JSC::::createUninitialized):
(JSC::::validateRange):
(JSC::::setWithSpecificType):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::decode):
(JSC::globalFuncProtoSetter):

  • runtime/JSNameScope.cpp:

(JSC::JSNameScope::put):

  • runtime/JSONObject.cpp:

(JSC::Stringifier::appendStringifiedValue):
(JSC::Walker::walk):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::defaultValue):
(JSC::JSObject::hasInstance):
(JSC::JSObject::defaultHasInstance):
(JSC::JSObject::defineOwnNonIndexProperty):
(JSC::throwTypeError):

  • runtime/ObjectConstructor.cpp:

(JSC::toPropertyDescriptor):

  • runtime/RegExpConstructor.cpp:

(JSC::constructRegExp):

  • runtime/StringObject.cpp:

(JSC::StringObject::defineOwnProperty):

  • runtime/StringRecursionChecker.cpp:

(JSC::StringRecursionChecker::throwStackOverflowError):

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.

Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.

Gets column information from the error object for reporting exceptions.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):

  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStackFromException):

Moved setting an exception into the vm, These functions changed to use the new functionality.

  • bindings/js/JSAudioBufferSourceNodeCustom.cpp:

(WebCore::JSAudioBufferSourceNode::setBuffer):

  • bindings/js/JSBiquadFilterNodeCustom.cpp:

(WebCore::JSBiquadFilterNode::setType):

  • bindings/js/JSCryptoCustom.cpp:

(WebCore::JSCrypto::getRandomValues):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::setFunctionVariableValue):

  • bindings/js/JSJavaScriptCallFrameCustom.cpp:

(WebCore::JSJavaScriptCallFrame::evaluate):
(WebCore::JSJavaScriptCallFrame::setVariableValue):

  • bindings/js/JSNodeFilterCondition.cpp:

(WebCore::JSNodeFilterCondition::acceptNode):

  • bindings/js/JSOscillatorNodeCustom.cpp:

(WebCore::JSOscillatorNode::setType):

  • bindings/js/JSPannerNodeCustom.cpp:

(WebCore::JSPannerNode::setPanningModel):
(WebCore::JSPannerNode::setDistanceModel):

  • bindings/js/JSSVGLengthCustom.cpp:

(WebCore::JSSVGLength::convertToSpecifiedUnits):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::getObjectParameter):
(WebCore::JSWebGLRenderingContext::getAttachedShaders):
(WebCore::JSWebGLRenderingContext::getExtension):
(WebCore::JSWebGLRenderingContext::getFramebufferAttachmentParameter):
(WebCore::JSWebGLRenderingContext::getParameter):
(WebCore::JSWebGLRenderingContext::getProgramParameter):
(WebCore::JSWebGLRenderingContext::getShaderParameter):
(WebCore::JSWebGLRenderingContext::getUniform):
(WebCore::dataFunctionf):
(WebCore::dataFunctioni):
(WebCore::dataFunctionMatrix):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::open):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneBase::throwStackOverflow):
(WebCore::CloneDeserializer::throwValidationError):
(WebCore::SerializedScriptValue::maybeThrowExceptionIfSerializationFailed):

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):
(WebCore::WorkerScriptController::setException):

  • bridge/c/c_instance.cpp:

(JSC::Bindings::CInstance::moveGlobalExceptionToExecState):
(JSC::Bindings::CInstance::invokeMethod):
(JSC::Bindings::CInstance::invokeDefaultMethod):
(JSC::Bindings::CInstance::invokeConstruct):
(JSC::Bindings::CInstance::toJSPrimitive):

  • bridge/objc/objc_instance.mm:

(ObjcInstance::invokeMethod):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcArray::setValueAt):
(JSC::Bindings::ObjcArray::valueAt):

  • bridge/objc/objc_utility.mm:

(JSC::Bindings::throwError):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtField::valueFromInstance):
(JSC::Bindings::QtField::setValueToInstance):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::put):
(JSC::RuntimeArray::putByIndex):

  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::throwInvalidAccessError):

Source/WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.

Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.

Moved setting an exception into the vm, These functions changed to use the new functionality.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::invokeMethod):

Source/WebKit2: https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.

Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.

Moved setting an exception into the vm, These functions changed to use the new functionality.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::callMethod):
(WebKit::JSNPObject::callObject):
(WebKit::JSNPObject::callConstructor):
(WebKit::JSNPObject::throwInvalidAccessError):

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::moveGlobalExceptionToExecState):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=119548
Refactoring Exception throws.

Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-28
Reviewed by Geoffrey Garen.

Column/line information was added into these results.

  • fast/events/window-onerror4-expected.txt:
  • fast/js/global-recursion-on-full-stack-expected.txt:

fixed a variable name in a case when shouldThrowType failed.

  • fast/js/mozilla/resources/js-test-pre.js:

(shouldThrowType):

Sorted the properties to allow the results always show in the same order.

  • fast/js/script-tests/exception-properties.js:
  • fast/js/exception-properties-expected.txt:

This test needed to be modified to have the line numbers match on the output across
wk and wk2. This test is inherently flaky because is relies on size of the available
native stack. To account for the flakiness an additional call was made to force the
results to match.
This patch now records and outputs the line number where the errors were occurring.
This was causing the test results to no longer match because of the line numbers.
By changing how to account for the flakiness, the results match again.

  • fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt:
  • fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html:
11:39 PM Changeset in webkit [157024] by gyuyoung.kim@samsung.com
  • 10 edits in trunk/Source/WebCore

Generate toCSSFooValue() for CSSCursorImageValue, CSSCubicBezierTimingFunctionValue, CSSStepsTimingFunctionValue and CSSUnicodeRangeValue
https://bugs.webkit.org/show_bug.cgi?id=122408

Reviewed by Andreas Kling.

As a step to use toCSSFooValue, this patch generates toCSSFooValue() for CSSCursorImageValue,
CSSCubicBezierTimingFunctionValue, CSSStepsTimingFunctionValue and CSSUnicodeRangeValue.
This will help to detect bad type cast.

No new tests, no behavior changes.

  • css/CSSCursorImageValue.h:
  • css/CSSTimingFunctionValue.h:
  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapAnimationTimingFunction):

  • css/CSSUnicodeRangeValue.h:
  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyCursor::applyValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::styleShader):

  • rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::cssCursorImageValue):

9:48 PM Changeset in webkit [157023] by akling@apple.com
  • 2 edits in trunk/Source/WebKit

No? Okay, let's try that again..

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
9:35 PM Changeset in webkit [157022] by akling@apple.com
  • 2 edits in trunk/Source/WebKit

Attempt to fix the Windows build.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
9:34 PM Changeset in webkit [157021] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

Remove an unnecessary test expectation, as the test was removed
along with the code it tested.

  • platform/mac/TestExpectations:
9:00 PM Changeset in webkit [157020] by timothy_horton@apple.com
  • 3 edits in trunk/LayoutTests

results.html doesn't support non-HTML reference tests or references with external resources
https://bugs.webkit.org/show_bug.cgi?id=122426

Reviewed by Ryosuke Niwa.

  • fast/harness/results.html:

Factor splitExtension() out of stripExtension(), so we can retrieve
the extension as well as strip it.

Factor layoutTestsBasePath() out of testLink(), so we can use it for
ref test expectation files as well.

Use layoutTestsBasePath() to link to ref test expectation files, and
use the extension of the test for the expectation, instead of hardcoding
HTML reference files.

This will work on the bots because we already use the same mechanism for
the link to the test itself.

  • fast/harness/resources/results-test.js:

Update the harness result viewer test results.

8:46 PM Changeset in webkit [157019] by mitz@apple.com
  • 2 edits in trunk/Source/ThirdParty

Build against the Xcode default toolchain when targeting OS X 10.8.

This fixes the build after r156632 in configurations that use another toolchain
by default.

  • gtest/xcode/Config/General.xcconfig:
8:39 PM Changeset in webkit [157018] by akling@apple.com
  • 38 edits in trunk/Source

Range constructors should take a Document&.
<https://webkit.org/b/122435>

Reviewed by Sam Weinig.

Source/WebCore:

Make all Range constructors take Document& instead of a PassRefPtr.
This removes one null check at every call site.

Also use a Ref<Document> for storage in Range.

Source/WTF:

Give Ref an assignment operator.

8:37 PM Changeset in webkit [157017] by fpizlo@apple.com
  • 4 edits in trunk/LayoutTests

jsc-layout-tests.yaml/js/script-tests/dfg-arguments-osr-exit.js.layout-dfg-eager-no-cjit fails in release mode on the bots
https://bugs.webkit.org/show_bug.cgi?id=122436

Unreviewed, green the bots by not running the eager variants of these tests.

Will unskip when I land the fix for https://bugs.webkit.org/show_bug.cgi?id=122418.

  • js/script-tests/dfg-arguments-osr-exit-multiple-blocks-before-exit.js:
  • js/script-tests/dfg-arguments-osr-exit-multiple-blocks.js:
  • js/script-tests/dfg-arguments-osr-exit.js:
7:37 PM Changeset in webkit [157016] by fpizlo@apple.com
  • 2 edits in trunk/Tools

Unreviewed, fix build on old Rubies.

  • Scripts/run-jsc-stress-tests:
7:17 PM Changeset in webkit [157015] by Antti Koivisto
  • 7 edits
    2 adds in trunk/Source/WebCore

Factor text paint style computation out from InlineTextBox
https://bugs.webkit.org/show_bug.cgi?id=122433

Reviewed by Andreas Kling.

Move it to TextPaintStyle.h/cpp. Other parts of the code may use it in the future.

7:14 PM Changeset in webkit [157014] by fpizlo@apple.com
  • 11 edits
    3 adds
    1 delete in trunk

Unified test infrastructure via the jsc shell
https://bugs.webkit.org/show_bug.cgi?id=120696

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Add a mozilla-tests.yaml list. This is autogenerated by create-mozilla-js-test-list.
I think it's better to leave this checked in; we may even just edit it directly in
the future. Also generating it is not cheap.

Fix some low-hanging fruit bugs that I caught by introducing more test coverage.

  • We were not emitting labels for CFA-unreachable blocks, which caused link errors. It's possible for a CFA-unreachable block to be jumped to, if the thing that causes it to be unreachable is a speculation in a Branch or peephole compare.


  • The register allocation assertions didn't handle peephole branches correctly. Since the peephole branch handling returns early from compile(), the clearBlahbittyBlah() method wasn't being called.
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCurrentBlock):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • tests/mozilla/mozilla-tests.yaml: Added.

Tools:

Reviewed by Oliver Hunt.

Make run-jsc-stress-tests smart enough to be able to handle different styles of test
output (silent or noisy) and different styles of test failure (just bad exit code,
text diff, filtering for some magical text, etc.). This allows me to get rid of the
layout-test-helper. It also allows me to switch all of the old Mozilla tests to
running in run-jsc-stress-tests.

Also removes all of the code paths that defended against not having shellwords. Just
install the shellwords gem if you want to run tests.

Also removes the non-parallel test running code. No reason for it to exist anymore.

This is a massive increase in test coverage. It uncovered bugs. I fixed two of them
as part of this patch, and left three more as new bugzillas.

  • Scripts/create-mozilla-js-test-list: Added.
  • Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
  • Scripts/jsc-stress-test-helpers/layout-test-helper: Removed.
  • Scripts/run-javascriptcore-tests:
  • Scripts/run-jsc-stress-tests:

LayoutTests:

Reviewed by Oliver Hunt.

Suppress running the no-cjit and dfg-eager variants of these tests because there are
still some hard bugs to fix; they were revealed by the increase in test coverage.

  • js/script-tests/dfg-inline-arguments-capture-throw-exception.js:
  • js/script-tests/dfg-uint32-to-number-in-middle-of-copy-propagation.js:
  • js/script-tests/integer-division-neg2tothe32-by-neg1.js:
5:43 PM Changeset in webkit [157013] by Darin Adler
  • 3 edits in trunk/Source/WebCore

[GTK] Get rid of use of deleteAllValues in GtkDragAndDropHelper
https://bugs.webkit.org/show_bug.cgi?id=122417

Reviewed by Andreas Kling.

  • platform/gtk/GtkDragAndDropHelper.cpp: Removed unneeded typedefs.

(WebCore::GtkDragAndDropHelper::~GtkDragAndDropHelper): Removed call to
deleteAllValues.
(WebCore::GtkDragAndDropHelper::handleDragEnd): Use remove directly instead
of using find then remove. I believe this fixes a storage leak.
(WebCore::GtkDragAndDropHelper::handleGetDragData): Use get instead of find.
(WebCore::GtkDragAndDropHelper::handleDragLeaveLater): Remove the explicit
delete since remove will automatically delete.
(WebCore::GtkDragAndDropHelper::handleDragLeave): Use get instead of find.
(WebCore::GtkDragAndDropHelper::handleDragMotion): Use add instead of a
combination of find and set. Also user nullptr instead of 0.
(WebCore::GtkDragAndDropHelper::handleDragDataReceived): Use get instead of find.
(WebCore::GtkDragAndDropHelper::handleDragDrop): Use get instead of find.

  • platform/gtk/GtkDragAndDropHelper.h: Use nullptr instead of 0. Change value

type of m_droppingContexts to be a std::unique_ptr.

4:26 PM Changeset in webkit [157012] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Windows build fix attempt.

  • page/win/DragControllerWin.cpp:

(WebCore::DragController::declareAndWriteDragImage):

3:55 PM Changeset in webkit [157011] by Antti Koivisto
  • 34 edits in trunk/Source/WebCore

Move paint() to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=122371

Reviewed by Darin Adler.

RenderText does not paint itself (text is painted by line boxes). We can move paint() down
to RenderElement.

This also requires some type tightening elsewhere in the code.

3:28 PM Changeset in webkit [157010] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Don't try to dispatch resize events for SVG images
https://bugs.webkit.org/show_bug.cgi?id=122410

Reviewed by Darin Adler.

Tested by avoiding assertion in svg/custom/large-image-pattern-crash.html

  • page/FrameView.cpp:

(WebCore::FrameView::sendResizeEventIfNeeded):

Bail out for SVG images. They have scripting disabled so the event wouldn't do anything anyway.
Use of FrameView mechanisms is just an implementation detail for SVG images, they are not
meant to act like real frames.

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::createTileImage):

Switch to Element iterator. This will take NoEventDispatchAssertion verifying the change.

3:07 PM Changeset in webkit [157009] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

DoYouEvenBench: Make it work on Internet Explorer 11 Release Preview
https://bugs.webkit.org/show_bug.cgi?id=122406

Reviewed by Darin Adler.

On Internet Explorer 11, $(elem).closest('li').data('id') fails to find the containig li of elem once
the first item is marked complete or deleted until we get back to the event loop in the jQuery/TodoMVC.
Worked around this limitation by overriding app.getTodo to use each item's id computed in advance.

Also use $.text instead of execCommand('InsertText') in FlightJS/MailClient since Internet Explorer
doesn't support execCommand('InsertText'). Also select the recipient to avoid exceptions.

  • DoYouEvenBench/benchmark.html:
2:29 PM Changeset in webkit [157008] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Element ancestor iterator should have a first() for convenience.
<https://webkit.org/b/122425>

Reviewed by Antti Koivisto.

Added an easy way to get the first element ancestor of a certain type
and put it to use in a few places.

2:07 PM Changeset in webkit [157007] by akling@apple.com
  • 8 edits in trunk/Source/WebCore

CTTE: FrameLoader::notifier() should return a reference.
<https://webkit.org/b/122424>

Reviewed by Anders Carlsson.

It was just returning the address of an inline member, so we should
use a reference instead. Also made the backpointer to Frame in
ResourceLoadNotifier a reference.

1:53 PM Changeset in webkit [157006] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Avoid layout in window.scroll{Y,X} when at topmost/leftmost position.
<https://webkit.org/b/122423>

Reviewed by Antti Koivisto.

Add a fast path for these properties to skip synchronous layout when
we are just going to return 0 anyway.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::scrollX):
(WebCore::DOMWindow::scrollY):

1:11 PM Changeset in webkit [157005] by andersca@apple.com
  • 7 edits in trunk/Source/WebCore

Clean up ContentData
https://bugs.webkit.org/show_bug.cgi?id=122421

Reviewed by Andreas Kling.

Replace uses of OwnPtr with std::unique_ptr and get rid of the ContentData::create overloads.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

  • rendering/style/ContentData.cpp:

(WebCore::ContentData::clone):

  • rendering/style/ContentData.h:

(WebCore::ContentData::setNext):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::appendContent):
(WebCore::RenderStyle::setContent):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareNonInheritedData.h:
12:48 PM Changeset in webkit [157004] by weinig@apple.com
  • 7 edits in trunk/Source/WebCore

Be a bit shouty about final classes while we look into why the bots don't like it.

  • dom/Comment.h:
  • dom/ProcessingInstruction.h:
  • editing/markup.cpp:
  • page/PageSerializer.cpp:
  • workers/SharedWorker.h:
  • workers/Worker.h:
12:35 PM Changeset in webkit [157003] by weinig@apple.com
  • 3 edits in trunk/Source/WebCore

Fix windows build.

  • platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::fragmentFromCFHTML):
(WebCore::fragmentFromHTML):

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeRangeToDataObject):
(WebCore::Pasteboard::writeSelection):

12:18 PM Changeset in webkit [157002] by weinig@apple.com
  • 47 edits in trunk/Source

CTTE: Thread references through markup.h
https://bugs.webkit.org/show_bug.cgi?id=122403

Reviewed by Darin Adler and Andreas Kling.

Source/WebCore:

Highlights:

  • Removed createFragmentFromMarkupWithContext(), it was unused.
  • Moved createFragmentFromNodes() into its one caller (in WebKit/mac)
  • Add a bunch more toFoo() overloads.

Source/WebKit/mac:

  • DOM/WebDOMOperations.mm:

(-[DOMNode markupString]):
(-[DOMRange markupString]):

  • WebView/WebFrame.mm:

(-[WebFrame _documentFragmentWithMarkupString:baseURLString:]):
(-[WebFrame _documentFragmentWithNodesAsParagraphs:]):

12:01 PM Changeset in webkit [157001] by zandobersek@gmail.com
  • 55 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/Modules/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122281

Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.

This patch covers IDL interfaces under Source/WebCore/Modules/.

  • Modules/battery/BatteryManager.idl:
  • Modules/encryptedmedia/MediaKeySession.idl:
  • Modules/encryptedmedia/MediaKeys.idl:
  • Modules/gamepad/GamepadList.idl:
  • Modules/geolocation/Geolocation.idl:
  • Modules/indexeddb/IDBCursor.idl:
  • Modules/indexeddb/IDBDatabase.idl:
  • Modules/indexeddb/IDBFactory.idl:
  • Modules/indexeddb/IDBIndex.idl:
  • Modules/indexeddb/IDBKeyRange.idl:
  • Modules/indexeddb/IDBObjectStore.idl:
  • Modules/indexeddb/IDBTransaction.idl:
  • Modules/indexeddb/IDBVersionChangeEvent.idl:
  • Modules/mediacontrols/MediaControlsHost.idl:
  • Modules/mediasource/MediaSource.idl:
  • Modules/mediasource/SourceBuffer.idl:
  • Modules/mediasource/SourceBufferList.idl:
  • Modules/mediasource/WebKitMediaSource.idl:
  • Modules/mediasource/WebKitSourceBuffer.idl:
  • Modules/mediasource/WebKitSourceBufferList.idl:
  • Modules/mediastream/MediaStream.idl:
  • Modules/mediastream/MediaStreamTrack.idl:
  • Modules/mediastream/RTCDTMFSender.idl:
  • Modules/mediastream/RTCDataChannel.idl:
  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCStatsReport.idl:
  • Modules/mediastream/RTCStatsResponse.idl:
  • Modules/networkinfo/NetworkInfoConnection.idl:
  • Modules/notifications/Notification.idl:
  • Modules/notifications/NotificationCenter.idl:
  • Modules/proximity/DeviceProximityEvent.idl:
  • Modules/quota/StorageInfo.idl:
  • Modules/quota/StorageQuota.idl:
  • Modules/speech/SpeechGrammarList.idl:
  • Modules/speech/SpeechRecognition.idl:
  • Modules/speech/SpeechRecognitionResult.idl:
  • Modules/speech/SpeechRecognitionResultList.idl:
  • Modules/speech/SpeechSynthesis.idl:
  • Modules/webaudio/AnalyserNode.idl:
  • Modules/webaudio/AudioBuffer.idl:
  • Modules/webaudio/AudioBufferSourceNode.idl:
  • Modules/webaudio/AudioContext.idl:
  • Modules/webaudio/AudioListener.idl:
  • Modules/webaudio/AudioNode.idl:
  • Modules/webaudio/AudioParam.idl:
  • Modules/webaudio/BiquadFilterNode.idl:
  • Modules/webaudio/OscillatorNode.idl:
  • Modules/webaudio/PannerNode.idl:
  • Modules/webdatabase/Database.idl:
  • Modules/webdatabase/DatabaseSync.idl:
  • Modules/webdatabase/SQLResultSetRowList.idl:
  • Modules/webdatabase/SQLTransaction.idl:
  • Modules/webdatabase/SQLTransactionSync.idl:
  • Modules/websockets/WebSocket.idl:
11:47 AM Changeset in webkit [157000] by akling@apple.com
  • 9 edits in trunk/Source/WebCore

Tighten AbstractWorker and subclasses a bit.
<https://webkit.org/b/122402>

Reviewed by Darin Adler.

  • Make the Worker and SharedWorker classes final.
  • Have constructors take ScriptExecutionContext by reference.
  • Remove unnecessary AbstractWorker::contextDestroyed() override.
  • Make eventTargetInterface() inline.

Inlining eventTargetInterface() is quite neat - since we only ever
call this on tightly typed pointers from generated code, combining
final and inline turns the virtual call into a compile-time constant.

11:18 AM Changeset in webkit [156999] by zandobersek@gmail.com
  • 49 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/html/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122280

Reviewed by Darin Adler.

Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.

This patch covers IDL interfaces under Source/WebCore/html/.

  • html/DOMFormData.idl:
  • html/DOMSettableTokenList.idl:
  • html/DOMTokenList.idl:
  • html/DOMURL.idl:
  • html/HTMLAllCollection.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLCollection.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFormControlsCollection.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLKeygenElement.idl:
  • html/HTMLMarqueeElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLOutputElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLVideoElement.idl:
  • html/MediaController.idl:
  • html/RadioNodeList.idl:
  • html/TimeRanges.idl:
  • html/canvas/CanvasGradient.idl:
  • html/canvas/CanvasRenderingContext2D.idl:
  • html/canvas/DOMPath.idl:
  • html/canvas/EXTDrawBuffers.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/WebGLDebugShaders.idl:
  • html/canvas/WebGLLoseContext.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • html/track/AudioTrackList.idl:
  • html/track/TextTrack.idl:
  • html/track/TextTrackCue.idl:
  • html/track/TextTrackCueList.idl:
  • html/track/TextTrackList.idl:
  • html/track/TextTrackRegionList.idl:
  • html/track/VideoTrackList.idl:
11:16 AM Changeset in webkit [156998] by akling@apple.com
  • 7 edits in trunk/Source

Pass VM instead of ExecState to StringObject constructor.
<https://webkit.org/b/122395>

Reviewed by Sam Weinig.

StringObject() only uses the ExecState to find the VM.

11:10 AM Changeset in webkit [156997] by zandobersek@gmail.com
  • 32 edits in trunk/Source/WebCore

[WebIIDL] Annotate IDL interfaces under Source/WebCore/svg/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122279

Reviewed by Darin Adler.

Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.

This patch covers IDL interfaces under Source/WebCore/svg/.

  • svg/SVGAngle.idl:
  • svg/SVGAnimationElement.idl:
  • svg/SVGColor.idl:
  • svg/SVGCursorElement.idl:
  • svg/SVGDocument.idl:
  • svg/SVGElement.idl:
  • svg/SVGElementInstanceList.idl:
  • svg/SVGException.idl:
  • svg/SVGFEDropShadowElement.idl:
  • svg/SVGFEGaussianBlurElement.idl:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFilterElement.idl:
  • svg/SVGGraphicsElement.idl:
  • svg/SVGLength.idl:
  • svg/SVGLengthList.idl:
  • svg/SVGMarkerElement.idl:
  • svg/SVGMaskElement.idl:
  • svg/SVGMatrix.idl:
  • svg/SVGNumberList.idl:
  • svg/SVGPaint.idl:
  • svg/SVGPathElement.idl:
  • svg/SVGPathSegList.idl:
  • svg/SVGPatternElement.idl:
  • svg/SVGPoint.idl:
  • svg/SVGPointList.idl:
  • svg/SVGSVGElement.idl:
  • svg/SVGStringList.idl:
  • svg/SVGTests.idl:
  • svg/SVGTextContentElement.idl:
  • svg/SVGTransform.idl:
  • svg/SVGTransformList.idl:
11:07 AM Changeset in webkit [156996] by zandobersek@gmail.com
  • 15 edits in trunk/Source/WebCore

[WebIDL] Annotate IDL interfaces under Source/WebCore/page/ with the OperationsNotDeletable attribute
https://bugs.webkit.org/show_bug.cgi?id=122278

Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
doesn't have any effect, but will keep the operations not configurable after the generator is modified
to preserve the original behavior. The attribute will be removed from each interface after checking
conformity with other browsers (in terms of configurability of operations of that interface) and the
WebKit's existing test suites.

This patch covers IDL interfaces under Source/WebCore/page/.

  • page/Console.idl:
  • page/Crypto.idl:
  • page/DOMSecurityPolicy.idl:
  • page/DOMSelection.idl:
  • page/DOMWindow.idl:
  • page/EventSource.idl:
  • page/History.idl:
  • page/Location.idl:
  • page/Navigator.idl:
  • page/Performance.idl:
  • page/PerformanceEntryList.idl:
  • page/SpeechInputResultList.idl:
  • page/WindowBase64.idl:
  • page/WindowTimers.idl:
10:58 AM Changeset in webkit [156995] by mihnea@adobe.com
  • 1 edit
    6 moves in trunk/LayoutTests

[CSSRegions] Rename parsing tests to match current css properties
https://bugs.webkit.org/show_bug.cgi?id=122413

Reviewed by Sam Weinig.

Simple renaming of files, inline with the current stable version of properties.

  • fast/regions/script-tests/webkit-flow-from-parsing.js: Renamed from LayoutTests/fast/regions/script-tests/content-webkit-from-flow-parsing.js.
  • fast/regions/script-tests/webkit-flow-into-parsing.js: Renamed from LayoutTests/fast/regions/script-tests/webkit-flow-parsing.js.
  • fast/regions/webkit-flow-from-parsing-expected.txt: Renamed from LayoutTests/fast/regions/content-webkit-from-flow-parsing-expected.txt.
  • fast/regions/webkit-flow-from-parsing.html: Renamed from LayoutTests/fast/regions/content-webkit-from-flow-parsing.html.
  • fast/regions/webkit-flow-into-parsing-expected.txt: Renamed from LayoutTests/fast/regions/webkit-flow-parsing-expected.txt.
  • fast/regions/webkit-flow-into-parsing.html: Renamed from LayoutTests/fast/regions/webkit-flow-parsing.html.
10:52 AM Changeset in webkit [156994] by Darin Adler
  • 2 edits in trunk/Source/WebCore
  • rendering/RenderButton.cpp:

(WebCore::RenderButton::setupInnerStyle): Added a comment possibly relevant
to current failures seen on Windows bot.

10:44 AM Changeset in webkit [156993] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

Unreviewed, rolling out r156988.
http://trac.webkit.org/changeset/156988
https://bugs.webkit.org/show_bug.cgi?id=122415

Broke debug build (Requested by ap on #webkit).

  • css/CSSCursorImageValue.h:
  • css/CSSTimingFunctionValue.h:
  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapAnimationTimingFunction):

  • css/CSSUnicodeRangeValue.h:
  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyCursor::applyValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::styleShader):

  • rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::cssCursorImageValue):

10:41 AM Changeset in webkit [156992] by Darin Adler
  • 2 edits in trunk/Source/WebKit

Try to fix the Windows build.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Removed export of non-existent Node::treeScope function returning
a TreeScope*. Probably will have to add an export to fix the next failure.

10:37 AM Changeset in webkit [156991] by gyuyoung.kim@samsung.com
  • 11 edits
    2 moves in trunk/Source/WebCore

Add *CSS* prefix to ShadowValue to generate toCSSShadowValue
https://bugs.webkit.org/show_bug.cgi?id=122409

Reviewed by Darin Adler.

To generate toCSSShadowValue(), we need to add *CSS* prefix to ShadowValue.
It is also to be sync with a naming rule of CSS child value.

No new tests, no behavior changes.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForShadow):

  • css/CSSParser.cpp:

(WebCore::ShadowParseContext::commitValue):

  • css/CSSShadowValue.cpp: Renamed from Source/WebCore/css/ShadowValue.cpp.

(WebCore::CSSShadowValue::CSSShadowValue):
(WebCore::CSSShadowValue::customCSSText):
(WebCore::CSSShadowValue::equals):

  • css/CSSShadowValue.h: Renamed from Source/WebCore/css/ShadowValue.h.

(WebCore::CSSShadowValue::create):

  • css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::createFilterOperations):

10:29 AM Changeset in webkit [156990] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test editing/spelling/context-menu-suggestions-multiword-selection.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=122414

  • platform/mac/TestExpectations: Marked as such.
10:15 AM Changeset in webkit [156989] by Darin Adler
  • 16 edits
    3 deletes in trunk/Source

Remove unneeded ScriptGCEvent class
https://bugs.webkit.org/show_bug.cgi?id=122390

Reviewed by Anders Carlsson.

Source/ThirdParty:

  • gtest/xcode/gtest.xcodeproj/project.pbxproj: Let Xcode update this file.

Not really part of this bug fix, but good to land anyway.

Source/WebCore:

  • GNUmakefile.list.am: Removed ScriptGCEvent files.
  • Target.pri: Ditto.
  • UseJSC.cmake: Ditto.
  • WebCore.exp.in: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
  • bindings/js/ScriptGCEvent.cpp: Removed.
  • bindings/js/ScriptGCEvent.h: Removed.
  • inspector/InspectorMemoryAgent.cpp: Removed include.
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::start): Removed GC event listening.
Some day we might add it back, but for now it is dead code.
(WebCore::InspectorTimelineAgent::stop): Ditto.
(WebCore::usedHeapSize): Renamed from getUsedHeapSize and put the
implementation here instead of indirecting through ScriptGCEvent.
(WebCore::InspectorTimelineAgent::setDOMCounters): Updated for above changes.
(WebCore::InspectorTimelineAgent::didCompleteCurrentRecord): Ditto.
(WebCore::InspectorTimelineAgent::pushCurrentRecord): Ditto.

  • inspector/InspectorTimelineAgent.h: Removed include.
  • inspector/ScriptGCEventListener.h: Removed.
  • testing/MemoryInfo.h: Updated to get heap capacity and size directly

instead of going through ScriptGCEvent.

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Replaced symbol from ScriptGCEvent with symbol from JSDOMWindowBase.

10:03 AM Changeset in webkit [156988] by gyuyoung.kim@samsung.com
  • 9 edits in trunk/Source/WebCore

Generate toCSSFooValue() for CSSCursorImageValue, CSSCubicBezierTimingFunctionValue, CSSStepsTimingFunctionValue and CSSUnicodeRangeValue
https://bugs.webkit.org/show_bug.cgi?id=122408

Reviewed by Darin Adler.

As a step to use toCSSFooValue, this patch generates toCSSFooValue() for CSSCursorImageValue,
CSSCubicBezierTimingFunctionValue, CSSStepsTimingFunctionValue and CSSUnicodeRangeValue.
This will help to detect bad type cast.

No new tests, no behavior changes.

  • css/CSSCursorImageValue.h:
  • css/CSSTimingFunctionValue.h:
  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapAnimationTimingFunction):

  • css/CSSUnicodeRangeValue.h:
  • css/CSSValue.cpp:

(WebCore::CSSValue::destroy):

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyCursor::applyValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::styleShader):

  • rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::cssCursorImageValue):

1:37 AM Changeset in webkit [156987] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

CTTE: Teach CompositeEditCommand that link Nodes are always Elements.
<https://webkit.org/b/122400>

Reviewed by Sam Weinig.

Make pushAnchorElementDown() take an Element& instead of a Node* and
tweak the surrounding code a tiny bit.

1:37 AM Changeset in webkit [156986] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

CTTE: Node::enclosingLinkEventParentOrSelf() should return an Element.
<https://webkit.org/b/122401>

Reviewed by Sam Weinig.

Only Elements are ever linked, so make enclosingLinkEventParentOrSelf()
return an Element* instead of a Node*. The only call site was already
doing toElement() on the return value without checking, so this makes
things look a bit nicer.

12:33 AM Changeset in webkit [156985] by gyuyoung.kim@samsung.com
  • 10 edits
    2 moves in trunk/Source/WebCore

Add *CSS* prefix to FontFeatureValue to generate toCSSFontFeatureValue(), and use it
https://bugs.webkit.org/show_bug.cgi?id=122204

Reviewed by Darin Adler.

*CSS* prefix needs to be added to FontFeatureValue class in order to generate toCSSFontFeatureValue().
static_cast<FontFeatureValue*> is changed with toCSSFontFeatureValue() by using this change.

No new tests, no behavior changes.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSFontFeatureValue.cpp: Renamed from Source/WebCore/css/FontFeatureValue.cpp.

(WebCore::CSSFontFeatureValue::CSSFontFeatureValue):
(WebCore::CSSFontFeatureValue::customCSSText):
(WebCore::CSSFontFeatureValue::equals):

  • css/CSSFontFeatureValue.h: Renamed from Source/WebCore/css/FontFeatureValue.h.

(WebCore::CSSFontFeatureValue::create):
(WebCore::CSSFontFeatureValue::tag):
(WebCore::CSSFontFeatureValue::value):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFontFeatureTag):

  • css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

Note: See TracTimeline for information about the timeline view.