Timeline
Oct 16, 2013:
- 8:47 PM Changeset in webkit [157558] by
-
- 6 edits in trunk
libllvmForJSC shouldn't call exit(1) on report_fatal_error()
https://bugs.webkit.org/show_bug.cgi?id=122905
<rdar://problem/15237856>
Source/JavaScriptCore:
Reviewed by Michael Saboff.
Expose the new LLVMInstallFatalErrorHandler() API through the soft linking magic and
then always call it to install something that calls CRASH().
- llvm/InitializeLLVM.cpp:
(JSC::llvmCrash):
(JSC::initializeLLVMOnce):
(JSC::initializeLLVM):
- llvm/LLVMAPIFunctions.h:
WebKitLibraries:
Reviewed by Michael Saboff.
- LLVMIncludesMountainLion.tar.bz2:
- LLVMLibrariesMountainLion.tar.bz2:
- 8:36 PM Changeset in webkit [157557] by
-
- 2 edits in trunk/Tools
We need test coverage for just the Baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=122929
Reviewed by Sam Weinig.
Adds no-LLInt versions of all tests. For the Mozilla tests, also add a BaselineJIT-only
variant.
- Scripts/run-jsc-stress-tests:
- 8:29 PM Changeset in webkit [157556] by
-
- 2 edits in trunk/Source/JavaScriptCore
Prototype chain repatching in the polymorphic case fails to check if the receiver is a dictionary
https://bugs.webkit.org/show_bug.cgi?id=122938
Reviewed by Sam Weinig.
This fixes jsc-layout-tests.yaml/js/script-tests/dictionary-prototype-caching.js.layout-no-llint.
- jit/Repatch.cpp:
(JSC::tryBuildGetByIDList):
- 8:10 PM Changeset in webkit [157555] by
-
- 1 edit19 adds in trunk
Add a new flakiness dashboard clone
https://bugs.webkit.org/show_bug.cgi?id=122936
Reviewed by Anders Carlsson.
Added the initial prototype.
- Websites/test-results: Added.
- Websites/test-results/.htaccess: Added.
- Websites/test-results/admin: Added.
- Websites/test-results/admin/index.php: Added.
- Websites/test-results/api: Added.
- Websites/test-results/api/manifest.php: Added.
- Websites/test-results/api/report.php: Added.
- Websites/test-results/api/results.php: Added.
- Websites/test-results/include: Added.
- Websites/test-results/include/config.json: Added.
- Websites/test-results/include/db.php: Added.
- Websites/test-results/include/init-database.sql: Added.
- Websites/test-results/include/json-shared.php: Added.
- Websites/test-results/include/test-results.php: Added.
- Websites/test-results/index.html: Added.
- Websites/test-results/js: Added.
- Websites/test-results/js/autocompleter.js: Added.
- Websites/test-results/js/build.js: Added.
- Websites/test-results/js/dom.js: Added.
- 8:01 PM Changeset in webkit [157554] by
-
- 2 edits in trunk/Source/JavaScriptCore
JIT::appendCall() needs to killLastResultRegister() or equivalent since there's some really bad code that expects it
https://bugs.webkit.org/show_bug.cgi?id=122937
Reviewed by Geoffrey Garen.
JITStubCall used to do it.
This makes mozilla-tests.yaml/ecma/Statements/12.10-1.js.mozilla-baseline pass.
- jit/JIT.h:
(JSC::JIT::appendCall):
- 7:36 PM Changeset in webkit [157553] by
-
- 3 edits in trunk/Tools
Support multiple repositories in submitting results to --results-server-host
https://bugs.webkit.org/show_bug.cgi?id=122935
Reviewed by Anders Carlsson.
Remoevd --got-revision and added the logic to extract revision information
from multiple repositories as done in run-perf-tests.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.upload_results):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 7:12 PM Changeset in webkit [157552] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r155607.
- platform/efl-wk2/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt: Added.
- platform/efl-wk2/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt: Added.
- 7:04 PM Changeset in webkit [157551] by
-
- 2 edits in trunk/Source/WebKit/win
Attempt to fix the Windows build after http://trac.webkit.org/changeset/157547.
Apparently some *more* Windows code uses setFrame and I missed it.
- FullscreenVideoController.cpp:
(FullscreenVideoController::LayerClient::platformCALayerLayoutSublayersOfLayer):
- 6:58 PM Changeset in webkit [157550] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix the Windows build after http://trac.webkit.org/changeset/157547.
The relevant conversion doesn't happen implicitly.
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
(WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer):
(WebCore::MediaPlayerPrivateFullscreenWindow::wndProc):
- 6:54 PM Changeset in webkit [157549] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r156527.
- platform/efl/compositing/contents-opaque/hidden-with-visible-text-expected.txt:
- platform/efl/svg/text/append-text-node-to-tspan-expected.txt:
- 6:53 PM Changeset in webkit [157548] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix the Windows build after http://trac.webkit.org/changeset/157547.
Apparently some Windows code uses setFrame and I missed it.
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
(WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer):
(WebCore::MediaPlayerPrivateFullscreenWindow::wndProc):
- 6:46 PM Changeset in webkit [157547] by
-
- 13 edits in trunk/Source
Remote Layer Tree: Complete support for simple layer properties
https://bugs.webkit.org/show_bug.cgi?id=122933
Reviewed by Anders Carlsson.
Add remote layer tree support for maskLayer, contentsRect, contentsScale,
minificationFilter, magnificationFilter, speed, and timeOffset.
No new tests, not yet testable.
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::dumpProperty):
(WebKit::dumpChangedLayers):
Add the new properties.
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::toCAFilterType):
(WebKit::RemoteLayerTreeHost::commit):
Apply the new properties.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::setSublayers):
(PlatformCALayerRemote::appendSublayer):
(PlatformCALayerRemote::insertSublayer):
Ensure that passed-in sublayers are always also PlatformCALayerRemote instances.
These are ASSERT_WITH_SECURITY_IMPLICATION as we will later unconditionally static_cast
them to PlatformCALayerRemote.
(PlatformCALayerRemote::setMask):
(PlatformCALayerRemote::setContentsRect):
(PlatformCALayerRemote::setMinificationFilter):
(PlatformCALayerRemote::setMagnificationFilter):
(PlatformCALayerRemote::setSpeed):
(PlatformCALayerRemote::setTimeOffset):
(PlatformCALayerRemote::contentsScale):
(PlatformCALayerRemote::setContentsScale):
Remove setFrame, store the new properties.
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
Remove setFrame, add isRemote, fix pointer side on playerLayer.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setName):
Don't dump the CALayer pointer if we own a PlatformCALayerRemote.
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
Fix the visible tile wash (my fault!), and make it use setPosition and
setBounds instead of setFrame; while more convenient, it is the only
caller of setFrame, so we'll remove it.
- platform/graphics/ca/PlatformCALayer.h:
(WebCore::PlatformCALayer::isRemote): Added.
- platform/graphics/ca/mac/PlatformCALayerMac.h:
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(nullActionsDictionary):
(toCAFilterType):
(PlatformCALayerMac::synchronouslyDisplayTilesInRect):
(PlatformCALayerMac::playerLayer):
Remove setFrame, fix some pointer sides.
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
- platform/graphics/ca/win/PlatformCALayerWin.h:
Remove setFrame.
- 6:23 PM Changeset in webkit [157546] by
-
- 11 edits in trunk/Source/JavaScriptCore
transition void cti_op_put_by_val* stubs to JIT operations
https://bugs.webkit.org/show_bug.cgi?id=122903
Reviewed by Geoffrey Garen.
Transitioned cti_op_put_by_val and cti_op_put_by_val_generic to operationPutByVal and
operationPutByValGeneric.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- jit/JIT.h:
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::privateCompilePutByVal):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitSlow_op_put_by_val):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- jit/JSInterfaceJIT.h:
- 6:02 PM Changeset in webkit [157545] by
-
- 16 edits3 adds in trunk
Source/JavaScriptCore: Implement ES6 spread operator
https://bugs.webkit.org/show_bug.cgi?id=122911
Reviewed by Michael Saboff.
Implement the ES6 spread operator
This has a little bit of refactoring to move the enumeration logic out ForOfNode
and into BytecodeGenerator, and then adds the logic to make it nicely callback
driven.
The rest of the logic is just the addition of the SpreadExpressionNode, the parsing,
and actually handling the spread.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitEnumeration):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::emitBytecode):
(JSC::ForOfNode::emitBytecode):
(JSC::SpreadExpressionNode::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createSpreadExpression):
- parser/Lexer.cpp:
(JSC::::lex):
- parser/NodeConstructors.h:
(JSC::SpreadExpressionNode::SpreadExpressionNode):
- parser/Nodes.h:
(JSC::ExpressionNode::isSpreadExpression):
(JSC::SpreadExpressionNode::expression):
- parser/Parser.cpp:
(JSC::::parseArrayLiteral):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
- parser/Parser.h:
(JSC::Parser::getTokenName):
(JSC::Parser::updateErrorMessageSpecialCase):
- parser/ParserTokens.h:
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createSpreadExpression):
LayoutTests: Implement spread
https://bugs.webkit.org/show_bug.cgi?id=122911
Reviewed by Michael Saboff.
Add testcases
- js/basic-spread-expected.txt: Added.
- js/basic-spread.html: Added.
- js/parser-syntax-check-expected.txt:
- js/script-tests/basic-spread.js: Added.
(f):
(o.f.o.f.o.f.o.f.h.eval.o.h.o.h.o.h.o.h.g):
- js/script-tests/parser-syntax-check.js:
- 5:25 PM Changeset in webkit [157544] by
-
- 5 edits in trunk/Source
Unreviewed build fix attempt on EFL port after r157520 and r157523
Source/WebKit2:
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
Removed ArgumentCoder<TransformationMatrix> which caused redefinition build error
in EFL port.
Source/WTF:
- wtf/PassRef.h: includes <utility>
- 5:15 PM Changeset in webkit [157543] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add a useLLInt option to jsc
https://bugs.webkit.org/show_bug.cgi?id=122930
Reviewed by Geoffrey Garen.
- runtime/Executable.cpp:
(JSC::setupLLInt):
(JSC::setupJIT):
(JSC::ScriptExecutable::prepareForExecutionImpl):
- runtime/Options.h:
- 4:57 PM Changeset in webkit [157542] by
-
- 1 edit1 add in trunk/Source/JavaScriptCore
Build fix.
Forgot to svn add DeferGC.cpp
- heap/DeferGC.cpp: Added.
- 4:49 PM Changeset in webkit [157541] by
-
- 2 edits in trunk/Source/JavaScriptCore
r157411 fails run-javascriptcore-tests when run with Baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=122902
Reviewed by Mark Hahnenberg.
It turns out that this was a long-standing bug in the DFG PutById repatching logic. It's
not legal to patch if the typeInfo tells you that you can't patch. The old JIT's patching
logic did this right, and the DFG's GetById patching logic did it right; but DFG PutById
didn't. Turns out that there's even a helpful method,
Structure::propertyAccessesAreCacheable(), that will even do all of the checks for you!
- jit/Repatch.cpp:
(JSC::tryCachePutByID):
- 4:48 PM Changeset in webkit [157540] by
-
- 3 edits in trunk/Websites/webkit.org
Publish SunSpider 1.0.2
https://bugs.webkit.org/show_bug.cgi?id=122923
Reviewed by Darin Adler.
- perf/sunspider/sunspider.html:
- perf/sunspider/versions.html:
- 4:47 PM Changeset in webkit [157539] by
-
- 17 edits in trunk/Source/JavaScriptCore
llint_slow_path_put_by_id can deadlock on a ConcurrentJITLock
https://bugs.webkit.org/show_bug.cgi?id=122667
Reviewed by Geoffrey Garen.
The issue this patch is attempting to fix is that there are places in our codebase
where we acquire the ConcurrentJITLock for a particular CodeBlock, then we do some
operations that can initiate a garbage collection. Garbage collection then calls
some methods of CodeBlock that also take the ConcurrentJITLock (because they don't
always necessarily run during garbage collection). This causes a deadlock.
To fix this issue, this patch adds a new RAII-style object (DisallowGC) that stores
into a thread-local field that indicates that it is unsafe to perform any operation
that could trigger garbage collection on the current thread. In debug builds,
ConcurrentJITLocker contains one of these DisallowGC objects so that we can eagerly
detect deadlocks.
This patch also adds a new type of ConcurrentJITLocker, GCSafeConcurrentJITLocker,
which uses the DeferGC mechanism to prevent collections from occurring while the
lock is held.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/DeferGC.h:
(JSC::DisallowGC::DisallowGC):
(JSC::DisallowGC::~DisallowGC):
(JSC::DisallowGC::isGCDisallowedOnCurrentThread):
(JSC::DisallowGC::initialize):
- jit/Repatch.cpp:
(JSC::repatchPutByID):
(JSC::buildPutByIdList):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/ConcurrentJITLock.h:
(JSC::ConcurrentJITLockerBase::ConcurrentJITLockerBase):
(JSC::ConcurrentJITLockerBase::~ConcurrentJITLockerBase):
(JSC::ConcurrentJITLockerBase::unlockEarly):
(JSC::GCSafeConcurrentJITLocker::GCSafeConcurrentJITLocker):
(JSC::GCSafeConcurrentJITLocker::~GCSafeConcurrentJITLocker):
(JSC::GCSafeConcurrentJITLocker::NoDefer::NoDefer):
(JSC::ConcurrentJITLocker::ConcurrentJITLocker):
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- runtime/JSCellInlines.h:
(JSC::allocateCell):
- runtime/JSSymbolTableObject.h:
(JSC::symbolTablePut):
- runtime/Structure.cpp: materializePropertyMapIfNecessary* now has a problem in that it
can start a garbage collection when the GCSafeConcurrentJITLocker goes out of scope, but
before the caller has a chance to use the newly created PropertyTable. The garbage collection
clears the PropertyTable, and then the caller uses it assuming it's valid. To avoid this,
we must DeferGC until the caller is done getting the newly materialized PropertyTable from
the Structure.
(JSC::Structure::materializePropertyMap):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::takePropertyTableOrCloneIfPinned):
(JSC::Structure::isSealed):
(JSC::Structure::isFrozen):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::despecifyAllFunctions):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):
(JSC::Structure::getPropertyNamesFromStructure):
- runtime/Structure.h:
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):
- runtime/StructureInlines.h:
(JSC::Structure::get):
- runtime/SymbolTable.h:
(JSC::SymbolTable::find):
(JSC::SymbolTable::end):
- 4:42 PM Changeset in webkit [157538] by
-
- 1 edit1 delete in trunk/Source/WebKit2
Remove Qt sandbox process code
https://bugs.webkit.org/show_bug.cgi?id=122920
Reviewed by Geoffrey Garen.
This code was only used by the Qt port, and the other Linux-based ports are using the seccomp based sandbox.
- Shared/linux/SandboxProcess/SandboxEnvironmentLinux.cpp: Removed.
- Shared/linux/SandboxProcess/SandboxEnvironmentLinux.h: Removed.
- 4:36 PM Changeset in webkit [157537] by
-
- 9 edits in trunk/Source/JavaScriptCore
Add SPI to disable the garbage collector timer
https://bugs.webkit.org/show_bug.cgi?id=122921
Reviewed by Geoffrey Garen.
Based on a patch by Mark Hahnenberg.
- API/JSBase.cpp:
(JSDisableGCTimer): Added; SPI function.
- API/JSBasePrivate.h:
- heap/BlockAllocator.cpp:
(JSC::createBlockFreeingThread): Added.
(JSC::BlockAllocator::BlockAllocator): Modified to use JSC::createBlockFreeingThread()
to conditionally create the "block freeing" thread depending on the value of
GCActivityCallback::s_shouldCreateGCTimer.
(JSC::BlockAllocator::~BlockAllocator):
- heap/BlockAllocator.h:
(JSC::BlockAllocator::deallocate):
- heap/Heap.cpp:
(JSC::Heap::didAbandon):
(JSC::Heap::collect):
(JSC::Heap::didAllocate):
- heap/HeapTimer.cpp:
(JSC::HeapTimer::timerDidFire):
- runtime/GCActivityCallback.cpp:
- runtime/GCActivityCallback.h:
(JSC::DefaultGCActivityCallback::create): Only instantiate a DefaultGCActivityCallback object
when GCActivityCallback::s_shouldCreateGCTimer is true so as to prevent allocating a HeapTimer
object (since DefaultGCActivityCallback ultimately extends HeapTimer).
- 3:33 PM Changeset in webkit [157536] by
-
- 15 edits3 deletes in trunk
Unreviewed, rolling out r157529.
http://trac.webkit.org/changeset/157529
https://bugs.webkit.org/show_bug.cgi?id=122919
Caused score test failures and some build failures. (Requested
by rfong on #webkit).
Source/JavaScriptCore:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitReadOnlyExceptionIfNeeded):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::emitBytecode):
(JSC::CallArguments::CallArguments):
(JSC::ForOfNode::emitBytecode):
(JSC::BindingNode::collectBoundIdentifiers):
- parser/ASTBuilder.h:
- parser/Lexer.cpp:
(JSC::::lex):
- parser/NodeConstructors.h:
(JSC::DotAccessorNode::DotAccessorNode):
- parser/Nodes.h:
- parser/Parser.cpp:
(JSC::::parseArrayLiteral):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
- parser/Parser.h:
(JSC::Parser::getTokenName):
(JSC::Parser::updateErrorMessageSpecialCase):
- parser/ParserTokens.h:
- parser/SyntaxChecker.h:
LayoutTests:
- js/basic-spread-expected.txt: Removed.
- js/basic-spread.html: Removed.
- js/parser-syntax-check-expected.txt:
- js/script-tests/basic-spread.js: Removed.
- js/script-tests/parser-syntax-check.js:
- 3:28 PM Changeset in webkit [157535] by
-
- 167 edits in trunk/Source/WebCore
Take RenderObjects out of the arena.
<https://webkit.org/b/122895>
Reviewed by Antti Koivisto.
Stop arena-allocating renderers so we can move forward on improving
render tree memory management. This will also allow rendering code
to take advantage of malloc optimizations.
Line boxes and BiDi runs remain in the arena for now.
- 3:20 PM Changeset in webkit [157534] by
-
- 13 edits2 adds in trunk
A page should exit fullscreen mode if it opens a new popup
https://bugs.webkit.org/show_bug.cgi?id=122865
Reviewed by Jer Noble.
Source/WebKit/blackberry:
If a fullscreen page opens a popup, the popup would be hidden and
therefore invisible to the user. To avoid this, exit fullscreen mode
before opening a new window.
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow):
Source/WebKit/efl:
If a fullscreen page opens a popup, the popup would be hidden and
therefore invisible to the user. To avoid this, exit fullscreen mode
before opening a new window.
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::createWindow):
Source/WebKit/gtk:
If a fullscreen page opens a popup, the popup would be hidden and
therefore invisible to the user. To avoid this, exit fullscreen mode
before opening a new window.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::createWindow):
Source/WebKit/mac:
If a fullscreen page opens a popup, the popup would be hidden and
therefore invisible to the user. To avoid this, exit fullscreen mode
before opening a new window.
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::createWindow):
Source/WebKit/win:
If a fullscreen page opens a popup, the popup would be hidden and
therefore invisible to the user. To avoid this, exit fullscreen mode
before opening a new window.
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::createWindow):
Source/WebKit2:
If a fullscreen page opens a popup, the popup would be hidden and
therefore invisible to the user. To avoid this, exit fullscreen mode
before opening a new window.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
LayoutTests:
- fullscreen/full-screen-exit-when-popup-expected.txt: Added.
- fullscreen/full-screen-exit-when-popup.html: Added.
- 3:17 PM Changeset in webkit [157533] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Speculative fix for test, media/video-canvas-drawing-output.html.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::AVFWrapper::createImageForTimeInRect):
- 3:10 PM Changeset in webkit [157532] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove useless architecture specific implementation in DFG.
https://bugs.webkit.org/show_bug.cgi?id=122917.
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-16
Reviewed by Michael Saboff.
With CPU(ARM) && CPU(ARM_HARDFP) architecture, the fallback implementation is fine
as FPRInfo::argumentFPR0 == FPRInfo::returnValueFPR in this case.
- dfg/DFGSpeculativeJIT.h:
- 3:02 PM Changeset in webkit [157531] by
-
- 2 edits in trunk/Source/WebKit2
Blind attempt to fix non-DATABASE_PROCESS builds.
- WebProcess/WebProcess.cpp:
- 2:37 PM Changeset in webkit [157530] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove unused JIT::restoreArgumentReferenceForTrampoline function.
https://bugs.webkit.org/show_bug.cgi?id=122916.
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-16
Reviewed by Michael Saboff.
This architecture specific function is not used anymore, so get rid of it.
- jit/JIT.h:
- jit/JITInlines.h:
- 2:27 PM Changeset in webkit [157529] by
-
- 15 edits3 adds in trunk
Source/JavaScriptCore: Implement ES6 spread operator
https://bugs.webkit.org/show_bug.cgi?id=122911
Reviewed by Michael Saboff.
Implement the ES6 spread operator
This has a little bit of refactoring to move the enumeration logic out ForOfNode
and into BytecodeGenerator, and then adds the logic to make it nicely callback
driven.
The rest of the logic is just the addition of the SpreadExpressionNode, the parsing,
and actually handling the spread.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitEnumeration):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::emitBytecode):
(JSC::ForOfNode::emitBytecode):
(JSC::SpreadExpressionNode::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createSpreadExpression):
- parser/Lexer.cpp:
(JSC::::lex):
- parser/NodeConstructors.h:
(JSC::SpreadExpressionNode::SpreadExpressionNode):
- parser/Nodes.h:
(JSC::ExpressionNode::isSpreadExpression):
(JSC::SpreadExpressionNode::expression):
- parser/Parser.cpp:
(JSC::::parseArrayLiteral):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):
- parser/Parser.h:
(JSC::Parser::getTokenName):
(JSC::Parser::updateErrorMessageSpecialCase):
- parser/ParserTokens.h:
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createSpreadExpression):
LayoutTests: Implement spread
https://bugs.webkit.org/show_bug.cgi?id=122911
Reviewed by Michael Saboff.
Add testcases
- js/basic-spread-expected.txt: Added.
- js/basic-spread.html: Added.
- js/parser-syntax-check-expected.txt:
- js/script-tests/basic-spread.js: Added.
(f):
(o.f.o.f.o.f.o.f.h.eval.o.h.o.h.o.h.o.h.g):
- js/script-tests/parser-syntax-check.js:
- 2:20 PM Changeset in webkit [157528] by
-
- 6 edits in trunk/Source
PlatformCALayer constructor should take layer type as an argument
https://bugs.webkit.org/show_bug.cgi?id=122915
Reviewed by Simon Fraser.
No new tests, just a minor refactoring.
- platform/graphics/ca/PlatformCALayer.h:
(WebCore::PlatformCALayer::PlatformCALayer):
Add a LayerType argument.
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::PlatformCALayerMac):
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayerWin::PlatformCALayerWin):
Use the new LayerType argument, and early-return in the case where we
are wrapping a custom PlatformLayer.
Drive-by un-indent the switch in the Mac version.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::PlatformCALayerRemote):
Use the new LayerType argument.
- 2:19 PM Changeset in webkit [157527] by
-
- 2 edits in trunk/Source/WebKit2
Remote Layer Tree: Use a default instead of an environment variable
https://bugs.webkit.org/show_bug.cgi?id=122913
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView std::WebKit::]):
Use the default 'WebKit2UseRemoteLayerTreeDrawingArea' instead of
the environment variable 'WK_USE_REMOTE_LAYER_TREE_DRAWING_AREA'
to indicate that WKViews should make RemoteLayerTreeDrawingAreas.
- 1:47 PM Changeset in webkit [157526] by
-
- 5 edits in trunk/Source
Versioning.
- 1:01 PM Changeset in webkit [157525] by
-
- 1 copy in tags/Safari-538.2
New Tag.
- 12:27 PM Changeset in webkit [157524] by
-
- 19 edits4 copies2 adds in trunk/Source
Flesh out the DatabaseProcess (and launch it!)
https://bugs.webkit.org/show_bug.cgi?id=122884
Reviewed by Tim Horton.
Source/WebCore:
- English.lproj/Localizable.strings: Add a localizable string.
- WebCore.xcodeproj/project.pbxproj: Export some more headers.
Source/WebKit2:
This patch adds actual process launching and basic messaging infrastructure for the DatabaseProcess.
It still does very little except exist.
Project file stuff:
- WebKit2.xcodeproj/project.pbxproj:
- DerivedSources.make:
WebContext owns the DatabaseProcess (much like the NetworkProcess):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureDatabaseProcess):
(WebKit::WebContext::getDatabaseProcessConnection):
- UIProcess/WebContext.h:
Add a basic DatabaseProcess that - for now - can only return a new Connection for a WebProcess:
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::createDatabaseToWebProcessConnection):
- DatabaseProcess/DatabaseProcess.h:
- DatabaseProcess/DatabaseProcess.messages.in: Added.
Add an object to represent a single connection to a single WebProcess:
- DatabaseProcess/DatabaseToWebProcessConnection.cpp:
(WebKit::DatabaseToWebProcessConnection::create):
(WebKit::DatabaseToWebProcessConnection::DatabaseToWebProcessConnection):
(WebKit::DatabaseToWebProcessConnection::~DatabaseToWebProcessConnection):
(WebKit::DatabaseToWebProcessConnection::didReceiveMessage):
(WebKit::DatabaseToWebProcessConnection::didClose):
(WebKit::DatabaseToWebProcessConnection::didReceiveInvalidMessage):
- DatabaseProcess/DatabaseToWebProcessConnection.h:
Basic DatabaseProcessProxy with the ability to ask the DatabaseProcess for a connection to hand back to a WebProcess:
- UIProcess/Databases/DatabaseProcessProxy.cpp:
(WebKit::DatabaseProcessProxy::DatabaseProcessProxy):
(WebKit::DatabaseProcessProxy::getDatabaseProcessConnection):
(WebKit::DatabaseProcessProxy::didCreateDatabaseToWebProcessConnection):
(WebKit::DatabaseProcessProxy::didFinishLaunching):
- UIProcess/Databases/DatabaseProcessProxy.h:
- UIProcess/Databases/DatabaseProcessProxy.messages.in: Added.
Add an object to represent a WebProcess’s connection to a DatabaseProcess:
- WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
(WebKit::WebToDatabaseProcessConnection::WebToDatabaseProcessConnection):
(WebKit::WebToDatabaseProcessConnection::~WebToDatabaseProcessConnection):
(WebKit::WebToDatabaseProcessConnection::didReceiveMessage):
(WebKit::WebToDatabaseProcessConnection::didClose):
(WebKit::WebToDatabaseProcessConnection::didReceiveInvalidMessage):
- WebProcess/Databases/WebToDatabaseProcessConnection.h:
(WebKit::WebToDatabaseProcessConnection::create):
(WebKit::WebToDatabaseProcessConnection::connection):
Give WebProcess(Proxy) an accessor for a Web -> Database process connection:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::webToDatabaseProcessConnectionClosed):
(WebKit::WebProcess::webToDatabaseProcessConnection):
(WebKit::WebProcess::ensureWebToDatabaseProcessConnection):
- WebProcess/WebProcess.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getDatabaseProcessConnection):
- UIProcess/WebProcessProxy.h:
- UIProcess/WebProcessProxy.messages.in:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::open): Access the database process connection to test that it works.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createIDBFactoryBackend): Keep non-DATABASE_PROCESS builds working.
- 12:04 PM Changeset in webkit [157523] by
-
- 13 edits in trunk/Source
RemoteLayerTree: Add support for more layer properties and transform layers
https://bugs.webkit.org/show_bug.cgi?id=122906
Reviewed by Anders Carlsson.
Add support for name, border width, border color, opacity, transform, sublayer transform,
hidden, geometry flipped, double sided, masks to bounds, and opaque layer properties.
Factor layer creation out from layer changes, so that we can create layers of the correct
type. Use this mechanism to create CATransformLayers when handed a LayerTypeTransformLayer.
No new tests, this code is not yet testable.
- WebCore.exp.in:
Export some TextStream and TransformationMatrix stuff.
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
- Shared/WebCoreArgumentCoders.h:
Add coders for TransformationMatrix.
- Shared/mac/RemoteLayerTreeTransaction.h:
Add the new LayerChange values.
(WebKit::RemoteLayerTreeTransaction::LayerProperties::notePropertiesChanged):
LayerProperties::layerChanges should be a LayerChange.
(WebKit::RemoteLayerTreeTransaction::createdLayers):
Expose the list of newly created layers (for RemoteLayerTreeHost's consumption).
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::LayerCreationProperties):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode):
Add (and support coding) a new LayerCreationProperties struct, which is currently
just a pair of LayerID and PlatformCALayer::LayerType. Additional properties may follow.
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
Encode and decode all of the new layer properties.
Encode changedProperties as an enum, not an unsigned.
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
Encode and decode the list of newly created layers.
(WebKit::RemoteLayerTreeTransaction::setCreatedLayers):
Setter for the list of newly created layers, which comes from the
RemoteLayerTreeContext at commit time.
(WebKit::dumpProperty):
Helper function to dump TransformationMatrix instances.
(WebKit::dumpChangedLayers):
Dump all of the new layer properties.
(WebKit::RemoteLayerTreeTransaction::dump):
Dump the list of newly created layers.
- UIProcess/mac/RemoteLayerTreeHost.h:
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::cgColorFromColor):
Factor out the code to make a CGColor from a WebCore::Color, as we need it
for both border and background color.
(WebKit::RemoteLayerTreeHost::commit):
Create layers before applying changes, using the new list of newly created layers.
When applying changes, ensure that the layer we're interested in was already created.
Rename "sublayer" to "layer", and use dot notation everywhere.
Apply all the new layer properties to the layers.
(WebKit::RemoteLayerTreeHost::getLayer):
(WebKit::RemoteLayerTreeHost::createLayer):
Separate creating a new layer from retrieving it by ID.
Ensure that a layer doesn't already exist when creating it.
Support creating CATransformLayers.
- WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
Disable accelerated animations, as we don't support proxying animations yet.
This makes GraphicsLayer fall back to software animations, which already work wonderfully remotely.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::PlatformCALayerRemote):
Inform the RemoteLayerTreeContext of the creation of every PlatformCALayerRemote.
(PlatformCALayerRemote::removeFromSuperlayer):
(PlatformCALayerRemote::replaceSublayer):
(PlatformCALayerRemote::adoptSublayers):
Assert when we hit a few critical unimplemented methods that would
leave the layer tree in a broken state.
(PlatformCALayerRemote::isOpaque):
(PlatformCALayerRemote::setOpaque):
(PlatformCALayerRemote::transform):
(PlatformCALayerRemote::setTransform):
(PlatformCALayerRemote::sublayerTransform):
(PlatformCALayerRemote::setSublayerTransform):
(PlatformCALayerRemote::setHidden):
(PlatformCALayerRemote::setGeometryFlipped):
(PlatformCALayerRemote::isDoubleSided):
(PlatformCALayerRemote::setDoubleSided):
(PlatformCALayerRemote::masksToBounds):
(PlatformCALayerRemote::setMasksToBounds):
(PlatformCALayerRemote::setBorderWidth):
(PlatformCALayerRemote::setBorderColor):
(PlatformCALayerRemote::opacity):
(PlatformCALayerRemote::setOpacity):
(PlatformCALayerRemote::setName):
Proxy all of these properties via RemoteLayerTreeTransaction.
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
Add storage for the list of newly created layers.
Use LayerID for the list of destroyed layers.
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::layerWasCreated):
Store the ID and type of the newly created layer to be pushed to the UI process later.
(WebKit::RemoteLayerTreeContext::flushLayers):
Push the created and destroyed layers to the transaction *after* flushing
GraphicsLayers, so that any changes to e.g. structural layers will not be missed.
- 10:35 AM Changeset in webkit [157522] by
-
- 3 edits2 adds in trunk
During editing, merge inline style with overriding other author styles
https://bugs.webkit.org/show_bug.cgi?id=122874
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2013-10-16
Reviewed by Ryosuke Niwa.
Source/WebCore:
Inline styles need to override other author styles even on DoNotOverrideValues mode.
So, merge and override inline styles to other author styles before merging them to m_mutableStyle.
Test: editing/deleting/merge-div-with-inline-style.html
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
LayoutTests:
Add a test for merging inline styles of parents.
- editing/deleting/merge-div-with-inline-style.html: Added.
- editing/deleting/merge-div-with-inline-style-expected.txt: Added.
- 10:26 AM Changeset in webkit [157521] by
-
- 4 edits in trunk/Source/JavaScriptCore
Transition void cti_op_tear_off* methods to JIT operations for 32 bit.
https://bugs.webkit.org/show_bug.cgi?id=122899.
Reviewed by Michael Saboff.
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_tear_off_activation):
(JSC::JIT::emit_op_tear_off_arguments):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- 10:18 AM Changeset in webkit [157520] by
-
- 13 edits1 add in trunk
Add PassRef and createRefCounted so we can improve creation of RefCounted objects
https://bugs.webkit.org/show_bug.cgi?id=122904
Reviewed by Anders Carlsson.
Source/WTF:
- GNUmakefile.list.am: Added PassRef.h.
- WTF.vcxproj/WTF.vcxproj: Ditto.
- WTF.vcxproj/WTF.vcxproj.filters: Ditto.
- WTF.xcodeproj/project.pbxproj: Ditto.
- wtf/CMakeLists.txt: Ditto.
- wtf/Forward.h: Added PassRef. Also re-sorted and un-indented to match what
the style-checking script expects.
- wtf/PassRef.h: Added. Includes the createRefCounted function template, which
is analogous to make_unique, but is for reference counted objects, and also
assumes that new will never return null. Also includes an overload of adoptRef
that takes a reference rather than a pointer.
- wtf/PassRefPtr.h: Include "PassRef.h" so we can share the adopted function.
Got rid of declarations that duplicate ones in there.
(WTF::refIfNotNull): Use nullptr.
(WTF::derefIfNotNull): Use nullptr.
(WTF::PassRefPtr::PassRefPtr): Use nullptr. Added an overload that takes a PassRef.
(WTF::PassRefPtr::operator UnspecifiedBoolType): Use nullptr.
(WTF::PassRefPtr::operator=): Made this deleted instead of compile time assertion.
(WTF::PassRefPtr::PassRefPtr): Made adopting constructor use an adopt tag instead
of an unused boolean.
(WTF::PassRefPtr::leakRef): Use nullptr.
(WTF::adoptRef): Use the adopt tag.
- wtf/Ref.h: Use Noncopyable instead of rolling our own.
(WTF::Ref::Ref): Add an overload that takes a PassRef.
(WTF::Ref::operator=): Ditto.
- wtf/RefPtr.h: Removed unneeded forward declaration of PassRefPtr.
(WTF::RefPtr::RefPtr): Use nullptr. Added overload that takes a PassRef.
(WTF::RefPtr::release): Use nullptr.
(WTF::RefPtr::operator UnspecifiedBoolType): Use nullptr.
(WTF::RefPtr::operator=): Added overload that takes a PassRef.
(WTF::RefPtr::clear): Use nullptr.
- wtf/StdLibExtras.h: Added inline keyword to isPointerTypeAlignmentOkay,
reinterpret_cast_ptr, and make_unique. Seems like a simple oversight that these
were missing before.
Tools:
- TestWebKitAPI/Tests/WTF/Ref.cpp: Added some basic tests for adoptRef and PassRef.
- 10:11 AM Changeset in webkit [157519] by
-
- 2 edits in trunk/Tools
Need tests for RefPtr self-assignment and self-move-assignment.
- TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added tests.
- 9:57 AM Changeset in webkit [157518] by
-
- 4 edits2 adds in trunk
Emphasis marks has wrong color.
https://bugs.webkit.org/show_bug.cgi?id=122829
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-16
Reviewed by Antti Koivisto.
Source/WebCore:
Tests: fast/text/text-emphasis.html.
fast/text/text-emphasis-expected.html.
Emphasis color should be set as fill color, not stroke color.
- rendering/TextPaintStyle.cpp:
(WebCore::updateGraphicsContext):
- rendering/TextPaintStyle.h:
LayoutTests:
- fast/text/text-emphasis-expected.html: Added.
- fast/text/text-emphasis.html: Added.
- 7:33 AM Changeset in webkit [157517] by
-
- 7 edits in trunk/Source/WebCore
Move code for finding rendered character offset to RenderTextLineBoxes
https://bugs.webkit.org/show_bug.cgi?id=122892
Reviewed by Andreas Kling.
- rendering/RenderText.cpp:
(WebCore::RenderText::countRenderedCharacterOffsets):
(WebCore::RenderText::containsRenderedCharacterOffset):
Renamed for consistency.
- rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::countCharacterOffsets):
This used to be Position::renderedPosition.
- 6:03 AM Changeset in webkit [157516] by
-
- 1 copy in releases/WebKitGTK/webkit-2.2.1
Tagging the WebKitGTK+ 2.2.1 release
- 5:40 AM Changeset in webkit [157515] by
-
- 28 edits in trunk/Source/WebCore
RenderElement::removeChild() should take child as a reference.
<https://webkit.org/b/122888>
We can't remove a child without a child to remove.
Reviewed by Antti Koivisto.
- 5:24 AM Changeset in webkit [157514] by
-
- 10 edits in trunk/Source/WebCore
Move test for contained caret offset to RenderTextLineBoxes
https://bugs.webkit.org/show_bug.cgi?id=122887
Reviewed by Andreas Kling.
- dom/Position.cpp:
(WebCore::Position::renderedOffset):
(WebCore::Position::isCandidate):
Remove isRenderedText, call RenderText::containsCaretOffset instead.
(WebCore::Position::isRenderedCharacter):
(WebCore::Position::rendersInDifferentPosition):
- dom/Position.h:
- dom/PositionIterator.cpp:
(WebCore::PositionIterator::isCandidate):
- rendering/InlineTextBox.cpp:
- rendering/InlineTextBox.h:
- rendering/RenderText.cpp:
(WebCore::RenderText::containsCharacterOffset):
(WebCore::RenderText::containsCaretOffset):
- rendering/RenderText.h:
- rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::containsOffset):
Combined implementations of Position::isRenderedCharacter and Position::isRenderedText.
- rendering/RenderTextLineBoxes.h:
Remove containsCaretOffset(), functionality is now in RenderTextLineBoxes::containsOffset.
- 4:07 AM Changeset in webkit [157513] by
-
- 1 edit5 adds in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r155998.
- platform/efl-wk2/compositing/contents-scale/animating-expected.txt: Added.
- platform/efl-wk2/compositing/contents-scale/scaled-ancestor-expected.txt: Added.
- platform/efl-wk2/compositing/contents-scale/simple-scale-expected.txt: Added.
- platform/efl-wk2/compositing/contents-scale/z-translate-expected.txt: Added.
- 3:34 AM Changeset in webkit [157512] by
-
- 4 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip the IndexedDB tests for now as the feature is going through substantial
changes that don't ensure constant proper functionality.
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 3:29 AM Changeset in webkit [157511] by
-
- 1 edit51 adds in trunk/LayoutTests
Revert Windows-specific expectations shuffling from r157497.
This wasn't wrong either. Shame on me. :|
- 2:52 AM Changeset in webkit [157510] by
-
- 7 edits in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r155957.
- platform/efl/css3/selectors3/html/css3-modsel-179a-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-179a-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-179a-expected.txt:
- platform/efl/fast/css/pseudo-first-line-border-width-expected.txt:
- platform/efl/fast/css/word-space-extra-expected.txt:
- platform/efl/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
- 2:34 AM Changeset in webkit [157509] by
-
- 26 edits in trunk/Source/WebCore
RenderElement::isChildAllowed() should take const references.
<https://webkit.org/b/122870>
Reviewed by Anders Carlsson.
The isChildAllowed() functions expect non-null values to be passed,
so enforce this at compile-time.
Reordered some checks to do bit tests before virtual calls.
- 2:24 AM Changeset in webkit [157508] by
-
- 1 edit22 adds in trunk/LayoutTests
Revert Mac-specific expecations shuffling from r157498.
Everything was already in order.
- 2:23 AM Changeset in webkit [157507] by
-
- 4 edits in releases/WebKitGTK/webkit-2.2
Unreviewed. Update NEWS and Versions.m4 for 2.2.1 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Add release notes.
- 2:18 AM Changeset in webkit [157506] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] video info unset if upstream doesn't query allocation
https://bugs.webkit.org/show_bug.cgi?id=122834
Reviewed by Gustavo Noronha Silva.
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkRender): If the sink didn't process any allocation
query then use the configured source pad caps and don't rely on
invalid video info.
- 2:15 AM Changeset in webkit [157505] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] move Logging.h include to GStreamerUtilities.h
https://bugs.webkit.org/show_bug.cgi?id=122886
Reviewed by Gustavo Noronha Silva.
Include Logging.h from GStreamerUtilities.h so the modules using
the LOG_MEDIA macros don't need to bother, especially for Debug builds.
- platform/graphics/gstreamer/GStreamerUtilities.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
- 2:07 AM Changeset in webkit [157504] by
-
- 6 edits in trunk
[WK2][Efl][CMake] Add support for ENABLE_NETWORK_PROCESS to the build system
https://bugs.webkit.org/show_bug.cgi?id=110139
Reviewed by Laszlo Gombos.
Original patch by Balazs Kelemen <kbalazs@webkit.org>
.:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/WebKit2:
- CMakeLists.txt:
- PlatformEfl.cmake:
- 1:51 AM Changeset in webkit [157503] by
-
- 1 edit347 deletes in trunk/LayoutTests
Remove EFL-specific test expectations that were identical to generic expectations.
<https://webkit.org/b/121551>
Reviewed by Antti Koivisto.
- platform/efl-wk2/webaudio/javascriptaudionode-expected.txt: Removed.
- platform/efl/compositing/culling/filter-occlusion-blur-expected.txt: Removed.
- platform/efl/compositing/culling/filter-occlusion-blur-large-expected.txt: Removed.
- platform/efl/compositing/geometry/fixed-position-composited-page-scale-down-expected.txt: Removed.
- platform/efl/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Removed.
- platform/efl/compositing/iframes/composited-iframe-scroll-expected.txt: Removed.
- platform/efl/compositing/iframes/iframe-content-flipping-expected.txt: Removed.
- platform/efl/compositing/iframes/repaint-after-losing-scrollbars-expected.txt: Removed.
- platform/efl/compositing/images/content-image-change-expected.txt: Removed.
- platform/efl/css1/units/rounding-expected.txt: Removed.
- platform/efl/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Removed.
- platform/efl/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Removed.
- platform/efl/css3/masking/clip-path-circle-expected.txt: Removed.
- platform/efl/css3/masking/clip-path-circle-filter-expected.txt: Removed.
- platform/efl/css3/masking/clip-path-circle-overflow-expected.txt: Removed.
- platform/efl/css3/masking/clip-path-circle-overflow-hidden-expected.txt: Removed.
- platform/efl/css3/masking/clip-path-circle-relative-overflow-expected.txt: Removed.
- platform/efl/css3/masking/clip-path-ellipse-expected.txt: Removed.
- platform/efl/css3/masking/clip-path-polygon-evenodd-expected.txt: Removed.
- platform/efl/css3/masking/clip-path-polygon-expected.txt: Removed.
- platform/efl/css3/masking/clip-path-polygon-nonzero-expected.txt: Removed.
- platform/efl/css3/masking/clip-path-rectangle-expected.txt: Removed.
- platform/efl/editing/deleting/transpose-empty-expected.txt: Removed.
- platform/efl/editing/selection/collapse-selection-in-bidi-expected.txt: Removed.
- platform/efl/editing/selection/drag-start-event-client-x-y-expected.txt: Removed.
- platform/efl/fast/backgrounds/bgCompositeCopy-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize01-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize02-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize03-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize04-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize05-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize06-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize07-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize08-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize09-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize10-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize11-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize12-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize13-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/backgroundSize14-expected.txt: Removed.
- platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
- platform/efl/fast/block/basic/fieldset-stretch-to-legend-expected.txt: Removed.
- platform/efl/fast/block/basic/quirk-percent-height-grandchild-expected.txt: Removed.
- platform/efl/fast/block/float/008-expected.txt: Removed.
- platform/efl/fast/block/float/009-expected.txt: Removed.
- platform/efl/fast/block/float/019-expected.txt: Removed.
- platform/efl/fast/block/float/034-expected.txt: Removed.
- platform/efl/fast/block/float/035-expected.txt: Removed.
- platform/efl/fast/block/float/4145535Crash-expected.txt: Removed.
- platform/efl/fast/block/float/br-with-clear-2-expected.txt: Removed.
- platform/efl/fast/block/float/float-forced-below-other-floats-expected.txt: Removed.
- platform/efl/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Removed.
- platform/efl/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Removed.
- platform/efl/fast/block/float/float-on-zero-height-line-expected.txt: Removed.
- platform/efl/fast/block/float/float-overhangs-root-expected.txt: Removed.
- platform/efl/fast/block/float/narrow-after-wide-expected.txt: Removed.
- platform/efl/fast/block/float/negative-margin-clear-expected.txt: Removed.
- platform/efl/fast/block/float/nested-clearance-expected.txt: Removed.
- platform/efl/fast/block/float/nowrap-clear-min-width-expected.txt: Removed.
- platform/efl/fast/block/float/overhanging-after-height-decrease-offsets-expected.txt: Removed.
- platform/efl/fast/block/float/relative-painted-twice-expected.txt: Removed.
- platform/efl/fast/block/positioning/003-expected.txt: Removed.
- platform/efl/fast/block/positioning/004-expected.txt: Removed.
- platform/efl/fast/block/positioning/005-expected.txt: Removed.
- platform/efl/fast/block/positioning/006-expected.txt: Removed.
- platform/efl/fast/block/positioning/007-expected.txt: Removed.
- platform/efl/fast/block/positioning/008-expected.txt: Removed.
- platform/efl/fast/block/positioning/009-expected.txt: Removed.
- platform/efl/fast/block/positioning/010-expected.txt: Removed.
- platform/efl/fast/block/positioning/011-expected.txt: Removed.
- platform/efl/fast/block/positioning/012-expected.txt: Removed.
- platform/efl/fast/block/positioning/013-expected.txt: Removed.
- platform/efl/fast/block/positioning/014-expected.txt: Removed.
- platform/efl/fast/block/positioning/015-expected.txt: Removed.
- platform/efl/fast/block/positioning/017-expected.txt: Removed.
- platform/efl/fast/block/positioning/018-expected.txt: Removed.
- platform/efl/fast/block/positioning/019-expected.txt: Removed.
- platform/efl/fast/block/positioning/020-expected.txt: Removed.
- platform/efl/fast/block/positioning/021-expected.txt: Removed.
- platform/efl/fast/block/positioning/022-expected.txt: Removed.
- platform/efl/fast/block/positioning/023-expected.txt: Removed.
- platform/efl/fast/block/positioning/024-expected.txt: Removed.
- platform/efl/fast/block/positioning/026-expected.txt: Removed.
- platform/efl/fast/block/positioning/027-expected.txt: Removed.
- platform/efl/fast/block/positioning/029-expected.txt: Removed.
- platform/efl/fast/block/positioning/030-expected.txt: Removed.
- platform/efl/fast/block/positioning/032-expected.txt: Removed.
- platform/efl/fast/block/positioning/033-expected.txt: Removed.
- platform/efl/fast/block/positioning/034-expected.txt: Removed.
- platform/efl/fast/block/positioning/035-expected.txt: Removed.
- platform/efl/fast/block/positioning/036-expected.txt: Removed.
- platform/efl/fast/block/positioning/037-expected.txt: Removed.
- platform/efl/fast/block/positioning/038-expected.txt: Removed.
- platform/efl/fast/block/positioning/039-expected.txt: Removed.
- platform/efl/fast/block/positioning/040-expected.txt: Removed.
- platform/efl/fast/block/positioning/041-expected.txt: Removed.
- platform/efl/fast/block/positioning/042-expected.txt: Removed.
- platform/efl/fast/block/positioning/043-expected.txt: Removed.
- platform/efl/fast/block/positioning/044-expected.txt: Removed.
- platform/efl/fast/block/positioning/045-expected.txt: Removed.
- platform/efl/fast/block/positioning/046-expected.txt: Removed.
- platform/efl/fast/block/positioning/048-expected.txt: Removed.
- platform/efl/fast/block/positioning/049-expected.txt: Removed.
- platform/efl/fast/block/positioning/050-expected.txt: Removed.
- platform/efl/fast/block/positioning/062-expected.txt: Removed.
- platform/efl/fast/block/positioning/complex-positioned-movement-expected.txt: Removed.
- platform/efl/fast/block/positioning/move-with-auto-width-expected.txt: Removed.
- platform/efl/fast/block/positioning/negative-rel-position-expected.txt: Removed.
- platform/efl/fast/block/positioning/relative-overconstrained-expected.txt: Removed.
- platform/efl/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Removed.
- platform/efl/fast/block/positioning/static-inline-position-dynamic-expected.txt: Removed.
- platform/efl/fast/block/positioning/vertical-lr/003-expected.txt: Removed.
- platform/efl/fast/block/positioning/vertical-lr/004-expected.txt: Removed.
- platform/efl/fast/block/positioning/vertical-lr/005-expected.txt: Removed.
- platform/efl/fast/block/positioning/vertical-lr/006-expected.txt: Removed.
- platform/efl/fast/block/positioning/vertical-rl/003-expected.txt: Removed.
- platform/efl/fast/block/positioning/vertical-rl/004-expected.txt: Removed.
- platform/efl/fast/block/positioning/vertical-rl/005-expected.txt: Removed.
- platform/efl/fast/block/positioning/vertical-rl/006-expected.txt: Removed.
- platform/efl/fast/borders/fieldsetBorderRadius-expected.txt: Removed.
- platform/efl/fast/borders/outline-offset-min-assert-expected.txt: Removed.
- platform/efl/fast/borders/webkit-border-radius-expected.txt: Removed.
- platform/efl/fast/box-shadow/shadow-tiling-artifact-expected.txt: Removed.
- platform/efl/fast/box-shadow/single-pixel-shadow-expected.txt: Removed.
- platform/efl/fast/canvas/canvas-as-image-expected.txt: Removed.
- platform/efl/fast/canvas/canvas-bg-expected.txt: Removed.
- platform/efl/fast/canvas/canvas-render-layer-expected.txt: Removed.
- platform/efl/fast/css-generated-content/table-parts-before-and-after-expected.txt: Removed.
- platform/efl/fast/css/006-expected.txt: Removed.
- platform/efl/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Removed.
- platform/efl/fast/css/bogus-color-span-expected.txt: Removed.
- platform/efl/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Removed.
- platform/efl/fast/css/content-dynamic-expected.txt: Removed.
- platform/efl/fast/css/contentDiv-expected.txt: Removed.
- platform/efl/fast/css/contentDivWithChildren-expected.txt: Removed.
- platform/efl/fast/css/contentImage-expected.txt: Removed.
- platform/efl/fast/css/empty-inline-003-quirksmode-expected.txt: Removed.
- platform/efl/fast/css/empty-inline-line-height-first-line-expected.txt: Removed.
- platform/efl/fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt: Removed.
- platform/efl/fast/css/font-face-multiple-remote-sources-expected.txt: Removed.
- platform/efl/fast/css/font-face-remote-expected.txt: Removed.
- platform/efl/fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt: Removed.
- platform/efl/fast/css/last-child-style-sharing-expected.txt: Removed.
- platform/efl/fast/css/nested-rounded-corners-expected.txt: Removed.
- platform/efl/fast/css/outline-auto-empty-rects-expected.txt: Removed.
- platform/efl/fast/css/transition-color-unspecified-expected.txt: Removed.
- platform/efl/fast/dom/Element/getBoundingClientRect-expected.txt: Removed.
- platform/efl/fast/dom/HTMLStyleElement/insert-parser-generated-expected.txt: Removed.
- platform/efl/fast/dom/Range/getBoundingClientRect-expected.txt: Removed.
- platform/efl/fast/dom/Window/window-properties-performance-expected.txt: Removed.
- platform/efl/fast/dom/attr_dead_doc-expected.txt: Removed.
- platform/efl/fast/dom/css-cached-import-rule-expected.txt: Removed.
- platform/efl/fast/dom/css-insert-import-rule-expected.txt: Removed.
- platform/efl/fast/dom/delete-contents-expected.txt: Removed.
- platform/efl/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Removed.
- platform/efl/fast/dom/shadow/shadow-contents-event-expected.txt: Removed.
- platform/efl/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Removed.
- platform/efl/fast/dynamic/001-expected.txt: Removed.
- platform/efl/fast/dynamic/005-expected.txt: Removed.
- platform/efl/fast/dynamic/anonymous-block-layer-lost-expected.txt: Removed.
- platform/efl/fast/dynamic/float-no-longer-overhanging-expected.txt: Removed.
- platform/efl/fast/dynamic/float-withdrawal-2-expected.txt: Removed.
- platform/efl/fast/dynamic/floating-to-positioned-2-expected.txt: Removed.
- platform/efl/fast/dynamic/floating-to-positioned-expected.txt: Removed.
- platform/efl/fast/dynamic/insertAdjacentElement-expected.txt: Removed.
- platform/efl/fast/dynamic/staticY-expected.txt: Removed.
- platform/efl/fast/dynamic/subtree-parent-static-y-expected.txt: Removed.
- platform/efl/fast/events/document-elementFromPoint-expected.txt: Removed.
- platform/efl/fast/events/overflow-viewport-renderer-deleted-expected.txt: Removed.
- platform/efl/fast/flexbox/flex-hang-expected.txt: Removed.
- platform/efl/fast/flexbox/overhanging-floats-removed-expected.txt: Removed.
- platform/efl/fast/forms/002-expected.txt: Removed.
- platform/efl/fast/forms/005-expected.txt: Removed.
- platform/efl/fast/forms/color/input-color-onchange-event-expected.txt: Removed.
- platform/efl/fast/forms/input-placeholder-paint-order-expected.txt: Removed.
- platform/efl/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt: Removed.
- platform/efl/fast/frames/002-expected.txt: Removed.
- platform/efl/fast/frames/calculate-fixed-expected.txt: Removed.
- platform/efl/fast/frames/calculate-order-expected.txt: Removed.
- platform/efl/fast/frames/calculate-percentage-expected.txt: Removed.
- platform/efl/fast/frames/calculate-relative-expected.txt: Removed.
- platform/efl/fast/frames/calculate-round-expected.txt: Removed.
- platform/efl/fast/frames/content-opacity-1-expected.txt: Removed.
- platform/efl/fast/frames/content-opacity-2-expected.txt: Removed.
- platform/efl/fast/frames/empty-cols-attribute-expected.txt: Removed.
- platform/efl/fast/frames/empty-frame-src-expected.txt: Removed.
- platform/efl/fast/frames/frame-set-whitespace-attributes-expected.txt: Removed.
- platform/efl/fast/frames/iframe-scaling-with-scroll-expected.txt: Removed.
- platform/efl/fast/frames/iframe-text-contents-expected.txt: Removed.
- platform/efl/fast/frames/invalid-expected.txt: Removed.
- platform/efl/fast/frames/no-frame-borders-expected.txt: Removed.
- platform/efl/fast/frames/seamless/seamless-inherited-origin-expected.txt: Removed.
- platform/efl/fast/gradients/background-clipped-expected.txt: Removed.
- platform/efl/fast/images/gif-large-checkerboard-expected.txt: Removed.
- platform/efl/fast/images/gray-scale-png-with-color-profile-expected.txt: Removed.
- platform/efl/fast/images/png-suite/test-expected.txt: Removed.
- platform/efl/fast/images/repaint-subrect-grid-expected.txt: Removed.
- platform/efl/fast/images/zoomed-img-size-expected.txt: Removed.
- platform/efl/fast/inline-block/004-expected.txt: Removed.
- platform/efl/fast/inline-block/005-expected.txt: Removed.
- platform/efl/fast/invalid/015-expected.txt: Removed.
- platform/efl/fast/invalid/table-residual-style-crash-expected.txt: Removed.
- platform/efl/fast/layers/opacity-stacking-expected.txt: Removed.
- platform/efl/fast/layers/positioned-inside-root-with-margins-expected.txt: Removed.
- platform/efl/fast/layers/zindex-ridonkulous-expected.txt: Removed.
- platform/efl/fast/lists/list-marker-before-content-table-expected.txt: Removed.
- platform/efl/fast/multicol/break-properties-expected.txt: Removed.
- platform/efl/fast/multicol/pagination-h-horizontal-bt-expected.txt: Removed.
- platform/efl/fast/multicol/pagination-h-horizontal-tb-expected.txt: Removed.
- platform/efl/fast/multicol/pagination-h-vertical-lr-expected.txt: Removed.
- platform/efl/fast/multicol/pagination-h-vertical-rl-expected.txt: Removed.
- platform/efl/fast/multicol/pagination-v-horizontal-bt-expected.txt: Removed.
- platform/efl/fast/multicol/pagination-v-horizontal-tb-expected.txt: Removed.
- platform/efl/fast/multicol/pagination-v-vertical-lr-expected.txt: Removed.
- platform/efl/fast/multicol/pagination-v-vertical-rl-expected.txt: Removed.
- platform/efl/fast/multicol/span/generated-child-split-flow-crash-expected.txt: Removed.
- platform/efl/fast/multicol/vertical-lr/break-properties-expected.txt: Removed.
- platform/efl/fast/multicol/vertical-lr/rules-with-border-before-expected.txt: Removed.
- platform/efl/fast/multicol/vertical-rl/break-properties-expected.txt: Removed.
- platform/efl/fast/multicol/vertical-rl/rules-with-border-before-expected.txt: Removed.
- platform/efl/fast/overflow/overflow-update-transform-expected.txt: Removed.
- platform/efl/fast/overflow/position-relative-expected.txt: Removed.
- platform/efl/fast/overflow/trailing-float-linebox-expected.txt: Removed.
- platform/efl/fast/overflow/unreachable-content-test-expected.txt: Removed.
- platform/efl/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Removed.
- platform/efl/fast/parser/style-script-head-test-expected.txt: Removed.
- platform/efl/fast/profiler/apply-expected.txt: Removed.
- platform/efl/fast/reflections/reflection-with-zoom-expected.txt: Removed.
- platform/efl/fast/reflections/table-cell-expected.txt: Removed.
- platform/efl/fast/repaint/background-generated-expected.txt: Removed.
- platform/efl/fast/repaint/content-into-overflow-expected.txt: Removed.
- platform/efl/fast/repaint/erase-overflow-expected.txt: Removed.
- platform/efl/fast/repaint/fixed-tranformed-expected.txt: Removed.
- platform/efl/fast/repaint/float-in-new-block-with-layout-delta-expected.txt: Removed.
- platform/efl/fast/repaint/float-new-in-block-expected.txt: Removed.
- platform/efl/fast/repaint/focus-ring-expected.txt: Removed.
- platform/efl/fast/repaint/iframe-scroll-repaint-expected.txt: Removed.
- platform/efl/fast/repaint/inline-block-resize-expected.txt: Removed.
- platform/efl/fast/repaint/intermediate-layout-position-clip-expected.txt: Removed.
- platform/efl/fast/repaint/intermediate-layout-position-expected.txt: Removed.
- platform/efl/fast/repaint/invisible-objects-expected.txt: Removed.
- platform/efl/fast/repaint/layer-hide-when-needs-layout-expected.txt: Removed.
- platform/efl/fast/repaint/layer-visibility-expected.txt: Removed.
- platform/efl/fast/repaint/layout-state-only-positioned-expected.txt: Removed.
- platform/efl/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Removed.
- platform/efl/fast/repaint/overflow-into-content-expected.txt: Removed.
- platform/efl/fast/repaint/repaint-during-scroll-expected.txt: Removed.
- platform/efl/fast/repaint/table-col-background-expected.txt: Removed.
- platform/efl/fast/repaint/table-outer-border-expected.txt: Removed.
- platform/efl/fast/repaint/table-row-expected.txt: Removed.
- platform/efl/fast/repaint/table-section-overflow-expected.txt: Removed.
- platform/efl/fast/repaint/table-two-pass-layout-overpaint-expected.txt: Removed.
- platform/efl/fast/repaint/text-emphasis-v-expected.txt: Removed.
- platform/efl/fast/repaint/transform-disable-layoutstate-expected.txt: Removed.
- platform/efl/fast/repaint/transform-replaced-shadows-expected.txt: Removed.
- platform/efl/fast/repaint/transform-rotate-and-remove-expected.txt: Removed.
- platform/efl/fast/repaint/view-background-from-body-1-expected.txt: Removed.
- platform/efl/fast/repaint/view-background-from-body-2-expected.txt: Removed.
- platform/efl/fast/replaced/008-expected.txt: Removed.
- platform/efl/fast/replaced/percent-height-in-anonymous-block-expected.txt: Removed.
- platform/efl/fast/replaced/selection-rect-expected.txt: Removed.
- platform/efl/fast/ruby/position-after-expected.txt: Removed.
- platform/efl/fast/ruby/ruby-block-style-not-updated-expected.txt: Removed.
- platform/efl/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.txt: Removed.
- platform/efl/fast/ruby/ruby-inline-style-not-updated-expected.txt: Removed.
- platform/efl/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.txt: Removed.
- platform/efl/fast/runin/runin-generated-before-content-expected.txt: Removed.
- platform/efl/fast/sub-pixel/inline-block-with-padding-expected.txt: Removed.
- platform/efl/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt: Removed.
- platform/efl/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Removed.
- platform/efl/fast/table/024-expected.txt: Removed.
- platform/efl/fast/table/031-expected.txt: Removed.
- platform/efl/fast/table/032-expected.txt: Removed.
- platform/efl/fast/table/auto-100-percent-width-expected.txt: Removed.
- platform/efl/fast/table/caption-relayout-expected.txt: Removed.
- platform/efl/fast/table/div-as-col-span-expected.txt: Removed.
- platform/efl/fast/table/fixed-granular-cols-expected.txt: Removed.
- platform/efl/fast/table/fixed-with-auto-with-colspan-expected.txt: Removed.
- platform/efl/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Removed.
- platform/efl/fast/table/growCellForImageQuirk-expected.txt: Removed.
- platform/efl/fast/table/growCellForImageQuirk-vertical-expected.txt: Removed.
- platform/efl/fast/table/height-percent-test-vertical-expected.txt: Removed.
- platform/efl/fast/table/percent-widths-stretch-expected.txt: Removed.
- platform/efl/fast/table/percent-widths-stretch-vertical-expected.txt: Removed.
- platform/efl/fast/table/table-before-child-style-update-expected.txt: Removed.
- platform/efl/fast/table/table-cell-before-after-content-around-table-block-expected.txt: Removed.
- platform/efl/fast/table/table-cell-before-after-content-around-table-expected.txt: Removed.
- platform/efl/fast/table/table-cell-before-after-content-around-table-row-expected.txt: Removed.
- platform/efl/fast/table/table-row-before-after-content-around-block-expected.txt: Removed.
- platform/efl/fast/table/table-row-before-after-content-around-table-expected.txt: Removed.
- platform/efl/fast/table/table-row-before-child-style-update-expected.txt: Removed.
- platform/efl/fast/table/table-row-outline-paint-expected.txt: Removed.
- platform/efl/fast/table/table-row-style-not-updated-expected.txt: Removed.
- platform/efl/fast/table/table-row-style-not-updated-with-after-content-expected.txt: Removed.
- platform/efl/fast/table/table-row-style-not-updated-with-before-content-expected.txt: Removed.
- platform/efl/fast/table/table-style-not-updated-expected.txt: Removed.
- platform/efl/fast/table/vertical-align-baseline-readjust-expected.txt: Removed.
- platform/efl/fast/table/wide-colspan-expected.txt: Removed.
- platform/efl/fast/table/wide-column-expected.txt: Removed.
- platform/efl/fast/text/align-center-rtl-spill-expected.txt: Removed.
- platform/efl/fast/text/emphasis-avoid-ruby-expected.txt: Removed.
- platform/efl/fast/text/soft-hyphen-4-expected.txt: Removed.
- platform/efl/fast/text/stripNullFromText-expected.txt: Removed.
- platform/efl/fast/text/wbr-pre-expected.txt: Removed.
- platform/efl/fast/text/whitespace/019-expected.txt: Removed.
- platform/efl/fast/text/whitespace/023-expected.txt: Removed.
- platform/efl/fast/tokenizer/missing-style-end-tag-1-expected.txt: Removed.
- platform/efl/fast/tokenizer/missing-style-end-tag-2-expected.txt: Removed.
- platform/efl/fast/tokenizer/script-after-frameset-expected.txt: Removed.
- platform/efl/fast/transforms/matrix-01-expected.txt: Removed.
- platform/efl/fast/transforms/matrix-02-expected.txt: Removed.
- platform/efl/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Removed.
- platform/efl/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Removed.
- platform/efl/fast/writing-mode/body-direction-propagation-blocked-expected.txt: Removed.
- platform/efl/fast/writing-mode/body-direction-propagation-expected.txt: Removed.
- platform/efl/fast/writing-mode/body-writing-mode-propagation-blocked-expected.txt: Removed.
- platform/efl/fast/writing-mode/body-writing-mode-propagation-expected.txt: Removed.
- platform/efl/fast/writing-mode/floats-in-block-layout-expected.txt: Removed.
- platform/efl/fast/writing-mode/inline-direction-positioning-expected.txt: Removed.
- platform/efl/fast/writing-mode/margin-collapse-expected.txt: Removed.
- platform/efl/fast/writing-mode/root-lr-basic-expected.txt: Removed.
- platform/efl/fast/writing-mode/self-collapsing-block-expected.txt: Removed.
- platform/efl/fullscreen/full-screen-render-inline-expected.txt: Removed.
- platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.txt: Removed.
- platform/efl/plugins/iframe-plugin-bgcolor-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug12910-2-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug131020-2-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug13169-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug137388-1-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug137388-2-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug137388-3-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug157890-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug1818-3-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug1818-6-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug222336-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug222467-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug269566-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug277062-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug28933-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug2954-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug8032-2-expected.txt: Removed.
- platform/efl/tables/mozilla/bugs/bug83786-expected.txt: Removed.
- platform/efl/tables/mozilla/core/col_widths_fix_autoFixPer-expected.txt: Removed.
- platform/efl/tables/mozilla_expected_failures/bugs/bug128876-expected.txt: Removed.
- platform/efl/transforms/3d/general/matrix-with-zoom-3d-expected.txt: Removed.
- platform/efl/transforms/3d/general/transform-origin-z-change-expected.txt: Removed.
- platform/efl/transitions/transition-end-event-rendering-expected.txt: Removed.
- 1:48 AM Changeset in webkit [157502] by
-
- 6 edits in trunk
[EFL] Minibrowser can't load child window's location
https://bugs.webkit.org/show_bug.cgi?id=122485
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-10-16
Reviewed by Gyuyoung Kim.
Source/WebKit2:
EwkView::createNewPage(), which is only called during handling of
Messages::WebPageProxy::CreateNewPage message from WebProcess, no longer passes
the URL to window_create(). As a result, no Messages::WebPage::LoadURL message
is sent back, that would load the same URL twice and effectively cancel any
other scheduled navigation inside WebProcess.
Additionally, since the url parameter in MiniBrowser's implementation of
window_create() is only used internally and is prone to bugs as demonstrated
in r139303 (d7f10c8), it has been removed in favour of explicit calls to
ewk_view_url_set().
- UIProcess/API/efl/EwkView.cpp:
(EwkView::createNewPage): No longer passes the URL to window_create() impl.
- UIProcess/API/efl/ewk_view.h: window_create() no longer has the url parameter.
- UIProcess/API/efl/tests/test_ewk2_window_features.cpp: Test methods updated to
comply with the API change.
(EWK2WindowFeaturesTest::createDefaultWindow): Ditto.
(EWK2WindowFeaturesTest::createWindow): Ditto.
Tools:
- MiniBrowser/efl/main.c: Now calling window_create() without the url parameter
followed by an explicit call to ewk_view_url_set() where appropriate.
(on_key_down):
(on_window_create):
(window_create):
(elm_main):
- 1:42 AM Changeset in webkit [157501] by
-
- 1 edit299 deletes in trunk/LayoutTests
Remove Gtk-specific test expectations that were identical to generic expectations.
<https://webkit.org/b/121551>
Reviewed by Antti Koivisto.
- platform/gtk/css1/units/rounding-expected.txt: Removed.
- platform/gtk/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Removed.
- platform/gtk/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Removed.
- platform/gtk/css3/masking/clip-path-circle-expected.txt: Removed.
- platform/gtk/css3/masking/clip-path-circle-filter-expected.txt: Removed.
- platform/gtk/css3/masking/clip-path-circle-overflow-expected.txt: Removed.
- platform/gtk/css3/masking/clip-path-circle-overflow-hidden-expected.txt: Removed.
- platform/gtk/css3/masking/clip-path-circle-relative-overflow-expected.txt: Removed.
- platform/gtk/css3/masking/clip-path-ellipse-expected.txt: Removed.
- platform/gtk/css3/masking/clip-path-polygon-evenodd-expected.txt: Removed.
- platform/gtk/css3/masking/clip-path-polygon-expected.txt: Removed.
- platform/gtk/css3/masking/clip-path-polygon-nonzero-expected.txt: Removed.
- platform/gtk/css3/masking/clip-path-rectangle-expected.txt: Removed.
- platform/gtk/editing/deleting/transpose-empty-expected.txt: Removed.
- platform/gtk/editing/pasteboard/5761530-1-expected.txt: Removed.
- platform/gtk/editing/selection/collapse-selection-in-bidi-expected.txt: Removed.
- platform/gtk/editing/selection/doubleclick-crash-expected.txt: Removed.
- platform/gtk/editing/selection/select-missing-image-expected.txt: Removed.
- platform/gtk/fast/backgrounds/bgCompositeCopy-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize01-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize02-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize03-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize04-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize05-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize06-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize07-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize08-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize09-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize10-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize11-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize12-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize13-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/backgroundSize14-expected.txt: Removed.
- platform/gtk/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
- platform/gtk/fast/block/basic/fieldset-stretch-to-legend-expected.txt: Removed.
- platform/gtk/fast/block/basic/quirk-percent-height-grandchild-expected.txt: Removed.
- platform/gtk/fast/block/float/008-expected.txt: Removed.
- platform/gtk/fast/block/float/009-expected.txt: Removed.
- platform/gtk/fast/block/float/019-expected.txt: Removed.
- platform/gtk/fast/block/float/034-expected.txt: Removed.
- platform/gtk/fast/block/float/035-expected.txt: Removed.
- platform/gtk/fast/block/float/4145535Crash-expected.txt: Removed.
- platform/gtk/fast/block/float/br-with-clear-2-expected.txt: Removed.
- platform/gtk/fast/block/float/float-forced-below-other-floats-expected.txt: Removed.
- platform/gtk/fast/block/float/float-on-zero-height-line-expected.txt: Removed.
- platform/gtk/fast/block/float/float-overhangs-root-expected.txt: Removed.
- platform/gtk/fast/block/float/narrow-after-wide-expected.txt: Removed.
- platform/gtk/fast/block/float/negative-margin-clear-expected.txt: Removed.
- platform/gtk/fast/block/float/nowrap-clear-min-width-expected.txt: Removed.
- platform/gtk/fast/block/float/overhanging-after-height-decrease-offsets-expected.txt: Removed.
- platform/gtk/fast/block/float/relative-painted-twice-expected.txt: Removed.
- platform/gtk/fast/block/positioning/003-expected.txt: Removed.
- platform/gtk/fast/block/positioning/004-expected.txt: Removed.
- platform/gtk/fast/block/positioning/005-expected.txt: Removed.
- platform/gtk/fast/block/positioning/006-expected.txt: Removed.
- platform/gtk/fast/block/positioning/007-expected.txt: Removed.
- platform/gtk/fast/block/positioning/008-expected.txt: Removed.
- platform/gtk/fast/block/positioning/009-expected.txt: Removed.
- platform/gtk/fast/block/positioning/010-expected.txt: Removed.
- platform/gtk/fast/block/positioning/011-expected.txt: Removed.
- platform/gtk/fast/block/positioning/012-expected.txt: Removed.
- platform/gtk/fast/block/positioning/013-expected.txt: Removed.
- platform/gtk/fast/block/positioning/014-expected.txt: Removed.
- platform/gtk/fast/block/positioning/015-expected.txt: Removed.
- platform/gtk/fast/block/positioning/017-expected.txt: Removed.
- platform/gtk/fast/block/positioning/018-expected.txt: Removed.
- platform/gtk/fast/block/positioning/019-expected.txt: Removed.
- platform/gtk/fast/block/positioning/020-expected.txt: Removed.
- platform/gtk/fast/block/positioning/021-expected.txt: Removed.
- platform/gtk/fast/block/positioning/022-expected.txt: Removed.
- platform/gtk/fast/block/positioning/023-expected.txt: Removed.
- platform/gtk/fast/block/positioning/024-expected.txt: Removed.
- platform/gtk/fast/block/positioning/026-expected.txt: Removed.
- platform/gtk/fast/block/positioning/027-expected.txt: Removed.
- platform/gtk/fast/block/positioning/029-expected.txt: Removed.
- platform/gtk/fast/block/positioning/030-expected.txt: Removed.
- platform/gtk/fast/block/positioning/032-expected.txt: Removed.
- platform/gtk/fast/block/positioning/033-expected.txt: Removed.
- platform/gtk/fast/block/positioning/034-expected.txt: Removed.
- platform/gtk/fast/block/positioning/035-expected.txt: Removed.
- platform/gtk/fast/block/positioning/036-expected.txt: Removed.
- platform/gtk/fast/block/positioning/037-expected.txt: Removed.
- platform/gtk/fast/block/positioning/038-expected.txt: Removed.
- platform/gtk/fast/block/positioning/039-expected.txt: Removed.
- platform/gtk/fast/block/positioning/040-expected.txt: Removed.
- platform/gtk/fast/block/positioning/041-expected.txt: Removed.
- platform/gtk/fast/block/positioning/042-expected.txt: Removed.
- platform/gtk/fast/block/positioning/043-expected.txt: Removed.
- platform/gtk/fast/block/positioning/044-expected.txt: Removed.
- platform/gtk/fast/block/positioning/045-expected.txt: Removed.
- platform/gtk/fast/block/positioning/046-expected.txt: Removed.
- platform/gtk/fast/block/positioning/048-expected.txt: Removed.
- platform/gtk/fast/block/positioning/049-expected.txt: Removed.
- platform/gtk/fast/block/positioning/050-expected.txt: Removed.
- platform/gtk/fast/block/positioning/062-expected.txt: Removed.
- platform/gtk/fast/block/positioning/complex-positioned-movement-expected.txt: Removed.
- platform/gtk/fast/block/positioning/move-with-auto-width-expected.txt: Removed.
- platform/gtk/fast/block/positioning/negative-rel-position-expected.txt: Removed.
- platform/gtk/fast/block/positioning/relative-overconstrained-expected.txt: Removed.
- platform/gtk/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Removed.
- platform/gtk/fast/block/positioning/static-inline-position-dynamic-expected.txt: Removed.
- platform/gtk/fast/block/positioning/vertical-lr/003-expected.txt: Removed.
- platform/gtk/fast/block/positioning/vertical-lr/004-expected.txt: Removed.
- platform/gtk/fast/block/positioning/vertical-lr/005-expected.txt: Removed.
- platform/gtk/fast/block/positioning/vertical-lr/006-expected.txt: Removed.
- platform/gtk/fast/block/positioning/vertical-rl/003-expected.txt: Removed.
- platform/gtk/fast/block/positioning/vertical-rl/004-expected.txt: Removed.
- platform/gtk/fast/block/positioning/vertical-rl/005-expected.txt: Removed.
- platform/gtk/fast/block/positioning/vertical-rl/006-expected.txt: Removed.
- platform/gtk/fast/borders/fieldsetBorderRadius-expected.txt: Removed.
- platform/gtk/fast/borders/outline-offset-min-assert-expected.txt: Removed.
- platform/gtk/fast/borders/webkit-border-radius-expected.txt: Removed.
- platform/gtk/fast/box-shadow/shadow-tiling-artifact-expected.txt: Removed.
- platform/gtk/fast/box-shadow/single-pixel-shadow-expected.txt: Removed.
- platform/gtk/fast/canvas/canvas-as-image-expected.txt: Removed.
- platform/gtk/fast/canvas/canvas-bg-expected.txt: Removed.
- platform/gtk/fast/canvas/canvas-render-layer-expected.txt: Removed.
- platform/gtk/fast/css-generated-content/table-parts-before-and-after-expected.txt: Removed.
- platform/gtk/fast/css/006-expected.txt: Removed.
- platform/gtk/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Removed.
- platform/gtk/fast/css/bogus-color-span-expected.txt: Removed.
- platform/gtk/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Removed.
- platform/gtk/fast/css/content-dynamic-expected.txt: Removed.
- platform/gtk/fast/css/contentDiv-expected.txt: Removed.
- platform/gtk/fast/css/contentDivWithChildren-expected.txt: Removed.
- platform/gtk/fast/css/contentImage-expected.txt: Removed.
- platform/gtk/fast/css/font-face-multiple-remote-sources-expected.txt: Removed.
- platform/gtk/fast/css/font-face-remote-expected.txt: Removed.
- platform/gtk/fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt: Removed.
- platform/gtk/fast/css/last-child-style-sharing-expected.txt: Removed.
- platform/gtk/fast/css/nested-rounded-corners-expected.txt: Removed.
- platform/gtk/fast/css/outline-auto-empty-rects-expected.txt: Removed.
- platform/gtk/fast/css/transition-color-unspecified-expected.txt: Removed.
- platform/gtk/fast/dom/HTMLStyleElement/insert-parser-generated-expected.txt: Removed.
- platform/gtk/fast/dom/attr_dead_doc-expected.txt: Removed.
- platform/gtk/fast/dom/css-cached-import-rule-expected.txt: Removed.
- platform/gtk/fast/dom/css-insert-import-rule-expected.txt: Removed.
- platform/gtk/fast/dom/delete-contents-expected.txt: Removed.
- platform/gtk/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Removed.
- platform/gtk/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Removed.
- platform/gtk/fast/dynamic/001-expected.txt: Removed.
- platform/gtk/fast/dynamic/005-expected.txt: Removed.
- platform/gtk/fast/dynamic/anonymous-block-layer-lost-expected.txt: Removed.
- platform/gtk/fast/dynamic/float-no-longer-overhanging-expected.txt: Removed.
- platform/gtk/fast/dynamic/float-withdrawal-2-expected.txt: Removed.
- platform/gtk/fast/dynamic/floating-to-positioned-2-expected.txt: Removed.
- platform/gtk/fast/dynamic/floating-to-positioned-expected.txt: Removed.
- platform/gtk/fast/dynamic/insertAdjacentElement-expected.txt: Removed.
- platform/gtk/fast/dynamic/staticY-expected.txt: Removed.
- platform/gtk/fast/dynamic/subtree-parent-static-y-expected.txt: Removed.
- platform/gtk/fast/events/document-elementFromPoint-expected.txt: Removed.
- platform/gtk/fast/events/event-attribute-expected.txt: Removed.
- platform/gtk/fast/files/workers/worker-read-blob-async-expected.txt: Removed.
- platform/gtk/fast/files/workers/worker-read-blob-sync-expected.txt: Removed.
- platform/gtk/fast/flexbox/flex-hang-expected.txt: Removed.
- platform/gtk/fast/forms/002-expected.txt: Removed.
- platform/gtk/fast/forms/005-expected.txt: Removed.
- platform/gtk/fast/forms/input-placeholder-paint-order-expected.txt: Removed.
- platform/gtk/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt: Removed.
- platform/gtk/fast/frames/002-expected.txt: Removed.
- platform/gtk/fast/frames/calculate-fixed-expected.txt: Removed.
- platform/gtk/fast/frames/calculate-order-expected.txt: Removed.
- platform/gtk/fast/frames/calculate-percentage-expected.txt: Removed.
- platform/gtk/fast/frames/calculate-relative-expected.txt: Removed.
- platform/gtk/fast/frames/calculate-round-expected.txt: Removed.
- platform/gtk/fast/frames/content-opacity-1-expected.txt: Removed.
- platform/gtk/fast/frames/content-opacity-2-expected.txt: Removed.
- platform/gtk/fast/frames/empty-cols-attribute-expected.txt: Removed.
- platform/gtk/fast/frames/empty-frame-src-expected.txt: Removed.
- platform/gtk/fast/frames/frame-set-whitespace-attributes-expected.txt: Removed.
- platform/gtk/fast/frames/iframe-scaling-with-scroll-expected.txt: Removed.
- platform/gtk/fast/frames/iframe-text-contents-expected.txt: Removed.
- platform/gtk/fast/frames/invalid-expected.txt: Removed.
- platform/gtk/fast/frames/no-frame-borders-expected.txt: Removed.
- platform/gtk/fast/gradients/background-clipped-expected.txt: Removed.
- platform/gtk/fast/images/gif-large-checkerboard-expected.txt: Removed.
- platform/gtk/fast/images/gray-scale-png-with-color-profile-expected.txt: Removed.
- platform/gtk/fast/images/png-suite/test-expected.txt: Removed.
- platform/gtk/fast/images/zoomed-img-size-expected.txt: Removed.
- platform/gtk/fast/inline-block/004-expected.txt: Removed.
- platform/gtk/fast/inline-block/005-expected.txt: Removed.
- platform/gtk/fast/invalid/015-expected.txt: Removed.
- platform/gtk/fast/invalid/table-residual-style-crash-expected.txt: Removed.
- platform/gtk/fast/layers/opacity-stacking-expected.txt: Removed.
- platform/gtk/fast/layers/positioned-inside-root-with-margins-expected.txt: Removed.
- platform/gtk/fast/layers/zindex-ridonkulous-expected.txt: Removed.
- platform/gtk/fast/multicol/break-properties-expected.txt: Removed.
- platform/gtk/fast/multicol/pagination-h-horizontal-bt-expected.txt: Removed.
- platform/gtk/fast/multicol/pagination-h-horizontal-tb-expected.txt: Removed.
- platform/gtk/fast/multicol/pagination-h-vertical-lr-expected.txt: Removed.
- platform/gtk/fast/multicol/pagination-h-vertical-rl-expected.txt: Removed.
- platform/gtk/fast/multicol/pagination-v-horizontal-bt-expected.txt: Removed.
- platform/gtk/fast/multicol/pagination-v-horizontal-tb-expected.txt: Removed.
- platform/gtk/fast/multicol/pagination-v-vertical-lr-expected.txt: Removed.
- platform/gtk/fast/multicol/pagination-v-vertical-rl-expected.txt: Removed.
- platform/gtk/fast/multicol/vertical-lr/break-properties-expected.txt: Removed.
- platform/gtk/fast/multicol/vertical-lr/rules-with-border-before-expected.txt: Removed.
- platform/gtk/fast/multicol/vertical-rl/break-properties-expected.txt: Removed.
- platform/gtk/fast/multicol/vertical-rl/rules-with-border-before-expected.txt: Removed.
- platform/gtk/fast/overflow/overflow-update-transform-expected.txt: Removed.
- platform/gtk/fast/overflow/position-relative-expected.txt: Removed.
- platform/gtk/fast/overflow/trailing-float-linebox-expected.txt: Removed.
- platform/gtk/fast/overflow/unreachable-content-test-expected.txt: Removed.
- platform/gtk/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Removed.
- platform/gtk/fast/parser/style-script-head-test-expected.txt: Removed.
- platform/gtk/fast/reflections/reflection-with-zoom-expected.txt: Removed.
- platform/gtk/fast/reflections/table-cell-expected.txt: Removed.
- platform/gtk/fast/repaint/background-generated-expected.txt: Removed.
- platform/gtk/fast/repaint/content-into-overflow-expected.txt: Removed.
- platform/gtk/fast/repaint/erase-overflow-expected.txt: Removed.
- platform/gtk/fast/repaint/fixed-tranformed-expected.txt: Removed.
- platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.txt: Removed.
- platform/gtk/fast/repaint/float-new-in-block-expected.txt: Removed.
- platform/gtk/fast/repaint/focus-ring-expected.txt: Removed.
- platform/gtk/fast/repaint/inline-block-resize-expected.txt: Removed.
- platform/gtk/fast/repaint/intermediate-layout-position-clip-expected.txt: Removed.
- platform/gtk/fast/repaint/intermediate-layout-position-expected.txt: Removed.
- platform/gtk/fast/repaint/invisible-objects-expected.txt: Removed.
- platform/gtk/fast/repaint/layer-hide-when-needs-layout-expected.txt: Removed.
- platform/gtk/fast/repaint/layer-visibility-expected.txt: Removed.
- platform/gtk/fast/repaint/layout-state-only-positioned-expected.txt: Removed.
- platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Removed.
- platform/gtk/fast/repaint/overflow-into-content-expected.txt: Removed.
- platform/gtk/fast/repaint/repaint-during-scroll-expected.txt: Removed.
- platform/gtk/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
- platform/gtk/fast/repaint/table-col-background-expected.txt: Removed.
- platform/gtk/fast/repaint/table-outer-border-expected.txt: Removed.
- platform/gtk/fast/repaint/table-row-expected.txt: Removed.
- platform/gtk/fast/repaint/table-section-overflow-expected.txt: Removed.
- platform/gtk/fast/repaint/table-two-pass-layout-overpaint-expected.txt: Removed.
- platform/gtk/fast/repaint/transform-disable-layoutstate-expected.txt: Removed.
- platform/gtk/fast/repaint/transform-replaced-shadows-expected.txt: Removed.
- platform/gtk/fast/repaint/transform-rotate-and-remove-expected.txt: Removed.
- platform/gtk/fast/repaint/view-background-from-body-1-expected.txt: Removed.
- platform/gtk/fast/repaint/view-background-from-body-2-expected.txt: Removed.
- platform/gtk/fast/replaced/008-expected.txt: Removed.
- platform/gtk/fast/replaced/percent-height-in-anonymous-block-expected.txt: Removed.
- platform/gtk/fast/replaced/selection-rect-expected.txt: Removed.
- platform/gtk/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt: Removed.
- platform/gtk/fast/table/024-expected.txt: Removed.
- platform/gtk/fast/table/031-expected.txt: Removed.
- platform/gtk/fast/table/032-expected.txt: Removed.
- platform/gtk/fast/table/auto-100-percent-width-expected.txt: Removed.
- platform/gtk/fast/table/caption-relayout-expected.txt: Removed.
- platform/gtk/fast/table/div-as-col-span-expected.txt: Removed.
- platform/gtk/fast/table/fixed-granular-cols-expected.txt: Removed.
- platform/gtk/fast/table/fixed-with-auto-with-colspan-expected.txt: Removed.
- platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Removed.
- platform/gtk/fast/table/growCellForImageQuirk-expected.txt: Removed.
- platform/gtk/fast/table/growCellForImageQuirk-vertical-expected.txt: Removed.
- platform/gtk/fast/table/height-percent-test-vertical-expected.txt: Removed.
- platform/gtk/fast/table/percent-widths-stretch-expected.txt: Removed.
- platform/gtk/fast/table/percent-widths-stretch-vertical-expected.txt: Removed.
- platform/gtk/fast/table/table-row-outline-paint-expected.txt: Removed.
- platform/gtk/fast/table/vertical-align-baseline-readjust-expected.txt: Removed.
- platform/gtk/fast/table/wide-colspan-expected.txt: Removed.
- platform/gtk/fast/table/wide-column-expected.txt: Removed.
- platform/gtk/fast/text/align-center-rtl-spill-expected.txt: Removed.
- platform/gtk/fast/text/stripNullFromText-expected.txt: Removed.
- platform/gtk/fast/text/wbr-pre-expected.txt: Removed.
- platform/gtk/fast/text/whitespace/019-expected.txt: Removed.
- platform/gtk/fast/text/whitespace/022-expected.txt: Removed.
- platform/gtk/fast/text/whitespace/023-expected.txt: Removed.
- platform/gtk/fast/tokenizer/missing-style-end-tag-1-expected.txt: Removed.
- platform/gtk/fast/tokenizer/missing-style-end-tag-2-expected.txt: Removed.
- platform/gtk/fast/tokenizer/script-after-frameset-expected.txt: Removed.
- platform/gtk/fast/transforms/matrix-01-expected.txt: Removed.
- platform/gtk/fast/transforms/matrix-02-expected.txt: Removed.
- platform/gtk/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Removed.
- platform/gtk/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Removed.
- platform/gtk/fast/writing-mode/body-direction-propagation-blocked-expected.txt: Removed.
- platform/gtk/fast/writing-mode/body-direction-propagation-expected.txt: Removed.
- platform/gtk/fast/writing-mode/body-writing-mode-propagation-blocked-expected.txt: Removed.
- platform/gtk/fast/writing-mode/body-writing-mode-propagation-expected.txt: Removed.
- platform/gtk/fast/writing-mode/floats-in-block-layout-expected.txt: Removed.
- platform/gtk/fast/writing-mode/inline-direction-positioning-expected.txt: Removed.
- platform/gtk/fast/writing-mode/margin-collapse-expected.txt: Removed.
- platform/gtk/fast/writing-mode/root-lr-basic-expected.txt: Removed.
- platform/gtk/fast/writing-mode/self-collapsing-block-expected.txt: Removed.
- platform/gtk/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Removed.
- platform/gtk/js/dom/global-constructors-attributes-shared-worker-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug12910-2-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug131020-2-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug137388-1-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug137388-2-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug137388-3-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug157890-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug1818-3-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug1818-6-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug222336-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug222467-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug269566-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug277062-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug28933-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug2954-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug8032-2-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug83786-expected.txt: Removed.
- platform/gtk/tables/mozilla/core/col_widths_fix_autoFixPer-expected.txt: Removed.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug128876-expected.txt: Removed.
- platform/gtk/transitions/transition-end-event-rendering-expected.txt: Removed.
- 1:40 AM Changeset in webkit [157500] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove more of the UNINTERRUPTED_SEQUENCE thing
https://bugs.webkit.org/show_bug.cgi?id=122885
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-16
Reviewed by Andreas Kling.
It was not completely removed by r157481, leading to build failure for sh4 architecture.
- jit/JIT.h:
- jit/JITInlines.h:
- 1:35 AM Changeset in webkit [157499] by
-
- 1 edit338 deletes in trunk/LayoutTests
Remove port-specific SVG test expectations that were identical to generic expectations.
<https://webkit.org/b/121551>
Reviewed by Antti Koivisto.
- platform/efl/fast/repaint/repaint-svg-after-style-change-expected.txt: Removed.
- platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Removed.
- platform/efl/svg/W3C-SVG-1.1/struct-frag-01-t-expected.txt: Removed.
- platform/efl/svg/as-image/image-respects-pageScaleFactor-change-expected.txt: Removed.
- platform/efl/svg/as-image/svg-as-image-expected.txt: Removed.
- platform/efl/svg/as-image/svg-non-integer-scaled-image-expected.txt: Removed.
- platform/efl/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-in-clip-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-child-clipped-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-evenodd-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-nonzero-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-recursive-call-by-child-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-recursive-call-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-transform-1-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-use-as-child2-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-use-as-child3-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-use-as-child4-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-use-as-child5-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-with-container-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.txt: Removed.
- platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.txt: Removed.
- platform/efl/svg/clip-path/clipper-placement-issue-expected.txt: Removed.
- platform/efl/svg/css/path-with-shadow-expected.txt: Removed.
- platform/efl/svg/css/shadow-and-opacity-expected.txt: Removed.
- platform/efl/svg/custom/pattern-scaling-expected.txt: Removed.
- platform/efl/svg/dom/css-transforms-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.txt: Removed.
- platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.txt: Removed.
- platform/efl/svg/filters/big-sized-filter-2-expected.txt: Removed.
- platform/efl/svg/filters/big-sized-filter-expected.txt: Removed.
- platform/efl/svg/filters/feImage-change-target-id-expected.txt: Removed.
- platform/efl/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.txt: Removed.
- platform/efl/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.txt: Removed.
- platform/efl/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.txt: Removed.
- platform/efl/svg/filters/feImage-remove-target-expected.txt: Removed.
- platform/efl/svg/filters/feMerge-wrong-input-expected.txt: Removed.
- platform/efl/svg/filters/filter-empty-g-expected.txt: Removed.
- platform/efl/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt: Removed.
- platform/efl/svg/foreignObject/fO-display-none-expected.txt: Removed.
- platform/efl/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.txt: Removed.
- platform/efl/svg/foreignObject/fO-parent-display-none-expected.txt: Removed.
- platform/efl/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Removed.
- platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Removed.
- platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Removed.
- platform/efl/svg/hixie/cascade/001-broken-expected.txt: Removed.
- platform/efl/svg/hixie/data-types/001-expected.txt: Removed.
- platform/efl/svg/hixie/dynamic/003-expected.txt: Removed.
- platform/efl/svg/hixie/dynamic/004-expected.txt: Removed.
- platform/efl/svg/hixie/dynamic/005-expected.txt: Removed.
- platform/efl/svg/hixie/dynamic/006-expected.txt: Removed.
- platform/efl/svg/hixie/error/001-expected.txt: Removed.
- platform/efl/svg/hixie/error/006-expected.txt: Removed.
- platform/efl/svg/hixie/error/007-expected.txt: Removed.
- platform/efl/svg/hixie/error/008-expected.txt: Removed.
- platform/efl/svg/hixie/error/009-expected.txt: Removed.
- platform/efl/svg/hixie/error/014-expected.txt: Removed.
- platform/efl/svg/hixie/error/014-test-expected.txt: Removed.
- platform/efl/svg/hixie/error/015-expected.txt: Removed.
- platform/efl/svg/hixie/error/016-expected.txt: Removed.
- platform/efl/svg/hixie/mixed/004-expected.txt: Removed.
- platform/efl/svg/hixie/mixed/005-expected.txt: Removed.
- platform/efl/svg/hixie/painting/001-expected.txt: Removed.
- platform/efl/svg/hixie/processing-model/005-expected.txt: Removed.
- platform/efl/svg/hixie/rendering-model/001-expected.txt: Removed.
- platform/efl/svg/hixie/rendering-model/002-expected.txt: Removed.
- platform/efl/svg/hixie/rendering-model/003a-expected.txt: Removed.
- platform/efl/svg/hixie/text/001-expected.txt: Removed.
- platform/efl/svg/hixie/transform/001-expected.txt: Removed.
- platform/efl/svg/hixie/use/001-expected.txt: Removed.
- platform/efl/svg/hixie/use/002-expected.txt: Removed.
- platform/efl/svg/hixie/use/002-test-expected.txt: Removed.
- platform/efl/svg/hixie/viewbox/001-expected.txt: Removed.
- platform/efl/svg/hixie/viewbox/002-expected.txt: Removed.
- platform/efl/svg/hixie/viewbox/003-expected.txt: Removed.
- platform/efl/svg/hixie/viewbox/004-expected.txt: Removed.
- platform/efl/svg/overflow/overflow-on-foreignObject-expected.txt: Removed.
- platform/efl/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt: Removed.
- platform/efl/svg/overflow/overflow-on-inner-svg-element-expected.txt: Removed.
- platform/efl/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Removed.
- platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Removed.
- platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Removed.
- platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Removed.
- platform/efl/svg/repaint/repainting-after-animation-element-removal-expected.txt: Removed.
- platform/efl/svg/text/text-hkern-expected.txt: Removed.
- platform/efl/svg/text/text-hkern-on-vertical-text-expected.txt: Removed.
- platform/efl/svg/text/text-vkern-expected.txt: Removed.
- platform/efl/svg/text/text-vkern-on-horizontal-text-expected.txt: Removed.
- platform/efl/svg/text/textPathBoundsBug-expected.txt: Removed.
- platform/efl/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Removed.
- platform/efl/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
- platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
- platform/efl/svg/zoom/page/zoom-svg-as-image-expected.txt: Removed.
- platform/efl/svg/zoom/page/zoom-svg-as-object-expected.txt: Removed.
- platform/efl/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Removed.
- platform/gtk/svg/W3C-SVG-1.1/struct-frag-01-t-expected.txt: Removed.
- platform/gtk/svg/as-image/svg-as-image-expected.txt: Removed.
- platform/gtk/svg/as-image/svg-non-integer-scaled-image-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-in-clip-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-child-clipped-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-clipped-no-content-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-evenodd-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-nonzero-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-recursive-call-by-child-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-recursive-call-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-transform-1-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-use-as-child2-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-use-as-child3-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-use-as-child4-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-use-as-child5-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-with-container-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-with-different-unittypes-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-with-different-unittypes2-expected.txt: Removed.
- platform/gtk/svg/clip-path/clip-path-with-invisibile-child-expected.txt: Removed.
- platform/gtk/svg/clip-path/clipper-placement-issue-expected.txt: Removed.
- platform/gtk/svg/css/path-with-shadow-expected.txt: Removed.
- platform/gtk/svg/css/shadow-and-opacity-expected.txt: Removed.
- platform/gtk/svg/custom/SVGNumber-interface-expected.txt: Removed.
- platform/gtk/svg/custom/SVGPoint-interface-expected.txt: Removed.
- platform/gtk/svg/custom/SVGRect-interface-expected.txt: Removed.
- platform/gtk/svg/custom/attribute-namespace-check-expected.txt: Removed.
- platform/gtk/svg/custom/circular-marker-reference-3-expected.txt: Removed.
- platform/gtk/svg/custom/class-baseValue-expected.txt: Removed.
- platform/gtk/svg/custom/class-selector-expected.txt: Removed.
- platform/gtk/svg/custom/clip-path-with-css-transform-1-expected.txt: Removed.
- platform/gtk/svg/custom/clip-path-with-css-transform-2-expected.txt: Removed.
- platform/gtk/svg/custom/clip-path-with-transform-expected.txt: Removed.
- platform/gtk/svg/custom/conditional-processing-outside-switch-expected.txt: Removed.
- platform/gtk/svg/custom/convolution-crash-expected.txt: Removed.
- platform/gtk/svg/custom/create-metadata-element-expected.txt: Removed.
- platform/gtk/svg/custom/createImageElement-expected.txt: Removed.
- platform/gtk/svg/custom/createelement-expected.txt: Removed.
- platform/gtk/svg/custom/css-pixels-dpi-expected.txt: Removed.
- platform/gtk/svg/custom/dasharrayOrigin-expected.txt: Removed.
- platform/gtk/svg/custom/display-none-expected.txt: Removed.
- platform/gtk/svg/custom/dynamic-empty-path-expected.txt: Removed.
- platform/gtk/svg/custom/dynamic-viewBox-expected.txt: Removed.
- platform/gtk/svg/custom/empty-merge-expected.txt: Removed.
- platform/gtk/svg/custom/evt-onload-expected.txt: Removed.
- platform/gtk/svg/custom/fill-opacity-hsl-expected.txt: Removed.
- platform/gtk/svg/custom/fill-opacity-rgba-expected.txt: Removed.
- platform/gtk/svg/custom/fill-update-expected.txt: Removed.
- platform/gtk/svg/custom/fractional-rects-expected.txt: Removed.
- platform/gtk/svg/custom/glyph-selection-arabic-forms-expected.txt: Removed.
- platform/gtk/svg/custom/glyph-selection-non-bmp-expected.txt: Removed.
- platform/gtk/svg/custom/gradient-attr-update-expected.txt: Removed.
- platform/gtk/svg/custom/gradient-rotated-bbox-expected.txt: Removed.
- platform/gtk/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt: Removed.
- platform/gtk/svg/custom/group-opacity-expected.txt: Removed.
- platform/gtk/svg/custom/hover-default-fill-expected.txt: Removed.
- platform/gtk/svg/custom/image-with-aspect-ratio-stretch-expected.txt: Removed.
- platform/gtk/svg/custom/inner-percent-expected.txt: Removed.
- platform/gtk/svg/custom/inner-svg-hit-test-expected.txt: Removed.
- platform/gtk/svg/custom/invalid-dasharray-expected.txt: Removed.
- platform/gtk/svg/custom/invalid-transforms-expected.txt: Removed.
- platform/gtk/svg/custom/js-update-container-expected.txt: Removed.
- platform/gtk/svg/custom/js-update-image-and-display-expected.txt: Removed.
- platform/gtk/svg/custom/js-update-image-and-display2-expected.txt: Removed.
- platform/gtk/svg/custom/js-update-image-and-display3-expected.txt: Removed.
- platform/gtk/svg/custom/large-bounding-box-percents-expected.txt: Removed.
- platform/gtk/svg/custom/marker-empty-path-expected.txt: Removed.
- platform/gtk/svg/custom/marker-referencePoint-expected.txt: Removed.
- platform/gtk/svg/custom/mask-changes-expected.txt: Removed.
- platform/gtk/svg/custom/mask-colorspace-expected.txt: Removed.
- platform/gtk/svg/custom/mask-excessive-malloc-expected.txt: Removed.
- platform/gtk/svg/custom/mask-inside-defs-expected.txt: Removed.
- platform/gtk/svg/custom/mask-on-multiple-objects-expected.txt: Removed.
- platform/gtk/svg/custom/mask-with-default-value-expected.txt: Removed.
- platform/gtk/svg/custom/non-scaling-stroke-markers-expected.txt: Removed.
- platform/gtk/svg/custom/outer-svg-unknown-feature-expected.txt: Removed.
- platform/gtk/svg/custom/painting-marker-07-f-inherit-expected.txt: Removed.
- platform/gtk/svg/custom/path-moveto-only-rendering-expected.txt: Removed.
- platform/gtk/svg/custom/path-update-expected.txt: Removed.
- platform/gtk/svg/custom/pattern-no-pixelation-expected.txt: Removed.
- platform/gtk/svg/custom/pattern-scaling-expected.txt: Removed.
- platform/gtk/svg/custom/pattern-y-offset-expected.txt: Removed.
- platform/gtk/svg/custom/percentage-rect2-expected.txt: Removed.
- platform/gtk/svg/custom/poly-identify-expected.txt: Removed.
- platform/gtk/svg/custom/polyline-hittest-expected.txt: Removed.
- platform/gtk/svg/custom/polyline-invalid-points-expected.txt: Removed.
- platform/gtk/svg/custom/polyline-setattribute-points-null-expected.txt: Removed.
- platform/gtk/svg/custom/root-container-opacity-clip-viewBox-expected.txt: Removed.
- platform/gtk/svg/custom/rootelement-expected.txt: Removed.
- platform/gtk/svg/custom/rounded-rects-expected.txt: Removed.
- platform/gtk/svg/custom/sheet-title-expected.txt: Removed.
- platform/gtk/svg/custom/small-rect-scale-expected.txt: Removed.
- platform/gtk/svg/custom/subpaths-moveto-only-rendering-expected.txt: Removed.
- platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
- platform/gtk/svg/custom/svgpolyparser-extra-space-expected.txt: Removed.
- platform/gtk/svg/custom/text-gradient-no-content-expected.txt: Removed.
- platform/gtk/svg/custom/transform-ignore-after-invalid-expected.txt: Removed.
- platform/gtk/svg/custom/transform-invalid-expected.txt: Removed.
- platform/gtk/svg/custom/transform-removeAttributeNS-expected.txt: Removed.
- platform/gtk/svg/custom/transform-scale-parse-expected.txt: Removed.
- platform/gtk/svg/custom/transform-with-ending-space-expected.txt: Removed.
- platform/gtk/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt: Removed.
- platform/gtk/svg/custom/use-disappears-after-style-update-expected.txt: Removed.
- platform/gtk/svg/custom/use-empty-reference-expected.txt: Removed.
- platform/gtk/svg/custom/use-extern-href-expected.txt: Removed.
- platform/gtk/svg/custom/use-invalid-pattern-expected.txt: Removed.
- platform/gtk/svg/custom/use-property-synchronization-crash-expected.txt: Removed.
- platform/gtk/svg/custom/use-recalcStyle-crash-expected.txt: Removed.
- platform/gtk/svg/custom/use-symbol-overflow-expected.txt: Removed.
- platform/gtk/svg/custom/viewBox-hit-expected.txt: Removed.
- platform/gtk/svg/custom/viewport-clip-expected.txt: Removed.
- platform/gtk/svg/custom/viewport-no-width-height-expected.txt: Removed.
- platform/gtk/svg/custom/viewport-update-expected.txt: Removed.
- platform/gtk/svg/custom/viewport-update2-expected.txt: Removed.
- platform/gtk/svg/custom/visibility-override-clip-expected.txt: Removed.
- platform/gtk/svg/custom/visibility-override-expected.txt: Removed.
- platform/gtk/svg/custom/visibility-override-filter-expected.txt: Removed.
- platform/gtk/svg/custom/visibility-override-mask-expected.txt: Removed.
- platform/gtk/svg/custom/width-full-percentage-expected.txt: Removed.
- platform/gtk/svg/custom/xhtml-no-svg-renderer-expected.txt: Removed.
- platform/gtk/svg/custom/xml-stylesheet-expected.txt: Removed.
- platform/gtk/svg/filters/big-sized-filter-2-expected.txt: Removed.
- platform/gtk/svg/filters/big-sized-filter-expected.txt: Removed.
- platform/gtk/svg/filters/feImage-change-target-id-expected.txt: Removed.
- platform/gtk/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.txt: Removed.
- platform/gtk/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.txt: Removed.
- platform/gtk/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.txt: Removed.
- platform/gtk/svg/filters/feImage-remove-target-expected.txt: Removed.
- platform/gtk/svg/filters/feMerge-wrong-input-expected.txt: Removed.
- platform/gtk/svg/filters/filter-empty-g-expected.txt: Removed.
- platform/gtk/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt: Removed.
- platform/gtk/svg/foreignObject/fO-display-none-expected.txt: Removed.
- platform/gtk/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.txt: Removed.
- platform/gtk/svg/foreignObject/fO-parent-display-none-expected.txt: Removed.
- platform/gtk/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Removed.
- platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Removed.
- platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Removed.
- platform/gtk/svg/hixie/cascade/001-broken-expected.txt: Removed.
- platform/gtk/svg/hixie/data-types/001-expected.txt: Removed.
- platform/gtk/svg/hixie/dynamic/003-expected.txt: Removed.
- platform/gtk/svg/hixie/dynamic/004-expected.txt: Removed.
- platform/gtk/svg/hixie/dynamic/005-expected.txt: Removed.
- platform/gtk/svg/hixie/dynamic/006-expected.txt: Removed.
- platform/gtk/svg/hixie/error/001-expected.txt: Removed.
- platform/gtk/svg/hixie/error/006-expected.txt: Removed.
- platform/gtk/svg/hixie/error/007-expected.txt: Removed.
- platform/gtk/svg/hixie/error/008-expected.txt: Removed.
- platform/gtk/svg/hixie/error/009-expected.txt: Removed.
- platform/gtk/svg/hixie/error/014-expected.txt: Removed.
- platform/gtk/svg/hixie/error/014-test-expected.txt: Removed.
- platform/gtk/svg/hixie/error/015-expected.txt: Removed.
- platform/gtk/svg/hixie/error/016-expected.txt: Removed.
- platform/gtk/svg/hixie/painting/001-expected.txt: Removed.
- platform/gtk/svg/hixie/processing-model/005-expected.txt: Removed.
- platform/gtk/svg/hixie/rendering-model/001-expected.txt: Removed.
- platform/gtk/svg/hixie/rendering-model/002-expected.txt: Removed.
- platform/gtk/svg/hixie/rendering-model/003a-expected.txt: Removed.
- platform/gtk/svg/hixie/text/001-expected.txt: Removed.
- platform/gtk/svg/hixie/transform/001-expected.txt: Removed.
- platform/gtk/svg/hixie/use/001-expected.txt: Removed.
- platform/gtk/svg/hixie/use/002-expected.txt: Removed.
- platform/gtk/svg/hixie/use/002-test-expected.txt: Removed.
- platform/gtk/svg/hixie/viewbox/001-expected.txt: Removed.
- platform/gtk/svg/hixie/viewbox/002-expected.txt: Removed.
- platform/gtk/svg/hixie/viewbox/003-expected.txt: Removed.
- platform/gtk/svg/hixie/viewbox/004-expected.txt: Removed.
- platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt: Removed.
- platform/gtk/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt: Removed.
- platform/gtk/svg/overflow/overflow-on-inner-svg-element-expected.txt: Removed.
- platform/gtk/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Removed.
- platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Removed.
- platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Removed.
- platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Removed.
- platform/gtk/svg/repaint/repainting-after-animation-element-removal-expected.txt: Removed.
- platform/gtk/svg/text/text-hkern-expected.txt: Removed.
- platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt: Removed.
- platform/gtk/svg/text/text-vkern-expected.txt: Removed.
- platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt: Removed.
- platform/gtk/svg/text/textPathBoundsBug-expected.txt: Removed.
- platform/gtk/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-svg-as-image-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-svg-as-object-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Removed.
- 1:25 AM Changeset in webkit [157498] by
-
- 1 edit13 deletes in trunk/LayoutTests
Remove Mac-specific test expectations that were identical to generic expectations.
<https://webkit.org/b/121551>
Reviewed by Antti Koivisto.
- platform/mac-lion/css3/filters/composited-during-animation-layertree-expected.txt: Removed.
- platform/mac-lion/fast/canvas/canvas-scale-shadowBlur-expected.txt: Removed.
- platform/mac-lion/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
- platform/mac-lion/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
- platform/mac-lion/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
- platform/mac-lion/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Removed.
- platform/mac-lion/http/tests/multipart/policy-ignore-crash-expected.txt: Removed.
- platform/mac-lion/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Removed.
- platform/mac-lion/sputnik/Unicode/Unicode_320/S7.6_A2.2_T2-expected.txt: Removed.
- platform/mac-lion/sputnik/Unicode/Unicode_320/S7.6_A5.2_T8-expected.txt: Removed.
- platform/mac-wk2/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
- platform/mac-wk2/http/tests/security/cross-origin-local-storage-wk1-expected.txt: Removed.
- platform/mac/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt: Removed.
- platform/mac/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt: Removed.
- platform/mac/webarchive/loading/mainresource-null-mimetype-crash-expected.txt: Removed.
- 1:13 AM Changeset in webkit [157497] by
-
- 1 edit39 deletes in trunk/LayoutTests
Remove Windows-specific test expectations that were identical to generic expectations.
<https://webkit.org/b/121551>
Reviewed by Antti Koivisto.
- platform/win-7sp0/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
- platform/win-future/svg/batik/text/textPosition2-expected.txt: Removed.
- platform/win/css3/filters/effect-reference-expected.txt: Removed.
- platform/win/css3/filters/effect-reference-hw-expected.txt: Removed.
- platform/win/editing/deleting/delete-br-009-expected.txt: Removed.
- platform/win/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Removed.
- platform/win/editing/inserting/insert-3800346-fix-expected.txt: Removed.
- platform/win/editing/selection/anchor-focus2-expected.txt: Removed.
- platform/win/editing/selection/anchor-focus3-expected.txt: Removed.
- platform/win/editing/selection/collapse-selection-in-bidi-expected.txt: Removed.
- platform/win/editing/selection/drag-text-delay-expected.txt: Removed.
- platform/win/editing/selection/extend-selection-home-end-expected.txt: Removed.
- platform/win/fast/block/positioning/016-expected.txt: Removed.
- platform/win/fast/block/positioning/025-expected.txt: Removed.
- platform/win/fast/block/positioning/fixed-position-stacking-context-expected.txt: Removed.
- platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Removed.
- platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Removed.
- platform/win/fast/canvas/canvas-render-layer-expected.txt: Removed.
- platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Removed.
- platform/win/fast/css/zoom-body-scroll-expected.txt: Removed.
- platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Removed.
- platform/win/fast/dom/icon-url-property-expected.txt: Removed.
- platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Removed.
- platform/win/fast/events/event-attribute-expected.txt: Removed.
- platform/win/fast/events/ondragenter-expected.txt: Removed.
- platform/win/fast/forms/cursor-at-editable-content-boundary-expected.txt: Removed.
- platform/win/fast/forms/implicit-submission-expected.txt: Removed.
- platform/win/fast/forms/range/slider-mouse-events-expected.txt: Removed.
- platform/win/fast/forms/select-popup-pagekeys-expected.txt: Removed.
- platform/win/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
- platform/win/fast/media/w3c/test_media_queries-expected.txt: Removed.
- platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
- platform/win/http/tests/inspector/resource-har-conversion-expected.txt: Removed.
- platform/win/http/tests/misc/acid3-expected.txt: Removed.
- platform/win/media/media-can-play-ogg-expected.txt: Removed.
- platform/win/media/media-can-play-wav-audio-expected.txt: Removed.
- platform/win/media/video-colorspace-yuv420-expected.txt: Removed.
- platform/win/media/video-colorspace-yuv422-expected.txt: Removed.
- platform/win/media/video-size-intrinsic-scale-expected.txt: Removed.
- platform/win/plugins/netscape-dom-access-and-reload-expected.txt: Removed.
- platform/win/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
- platform/win/svg/custom/pattern-scaling-expected.txt: Removed.
- 12:32 AM Changeset in webkit [157496] by
-
- 3 edits in trunk/Source/WebCore
Fix the build after r157478.
Rubber-stamped by Tim Horton.
Due to the way WebCore.exp.in is used, it can't be used to export a differing set of symbols
for different architectures. We often work around this by tweaking code slightly to avoid
needing to export different symbols. However, in this case the symbol name itself encodes an
architecture-specific detail and there's no clear way to avoid the requirement to export it.
To deal with this case we turn to ld's support for wildcards in the symbol export list.
- WebCore.exp.in: Use wildcards in place of the number that represents by how much "this"
should be adjusted when calling through the vtable thunk. Also sort the remainder of the file.
- make-export-file-generator: Don't attempt to verify symbol names that contain wildcard characters.
Oct 15, 2013:
- 11:56 PM Changeset in webkit [157495] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Build fix after r157476.
- GNUmakefile.am:
- 11:46 PM Changeset in webkit [157494] by
-
- 3 edits2 adds in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r155253.
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-10-15
- platform/efl/fast/forms/formmove3-expected.txt:
- platform/efl/fast/forms/input-align-image-expected.txt:
- platform/efl/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/efl/fast/invalid/003-expected.txt:
- platform/efl/tables/mozilla/bugs/bug647-expected.txt:
- 11:35 PM Changeset in webkit [157493] by
-
- 6 edits in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r155253.
- platform/efl/fast/forms/formmove3-expected.txt:
- platform/efl/fast/forms/input-align-image-expected.txt:
- platform/efl/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/efl/fast/invalid/003-expected.txt:
- platform/efl/tables/mozilla/bugs/bug647-expected.txt:
- 11:17 PM Changeset in webkit [157492] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r155324.
- platform/efl/fast/forms/placeholder-position-expected.png:
- platform/efl/fast/forms/placeholder-position-expected.txt:
- 9:44 PM Changeset in webkit [157491] by
-
- 2 edits in trunk/Source/WebCore
Two more exports for 32-bit build fix.
The duality of CGFloat means that we use a different
version of getRGBA (and the cast operator)
on 32-bit systems.
- WebCore.exp.in:
- 9:36 PM Changeset in webkit [157490] by
-
- 4 edits in trunk
[EFL][WK2] Make SeccompFilters build again after r156349 and r156353
https://bugs.webkit.org/show_bug.cgi?id=122872
Patch by Sergio Correia <Sergio Correia> on 2013-10-15
Reviewed by Anders Carlsson.
Source/WebKit2:
- Shared/linux/SeccompFilters/SeccompBroker.cpp:
(WebKit::SeccompBrokerClient::dispatch): Fix usage of extinct 'create'
methods of ArgumentEncoder/ArgumentDecoder.
(WebKit::SeccompBroker::runLoop): Ditto.
Tools:
- TestWebKitAPI/PlatformEfl.cmake: Mark SeccompFilters API test as
failing.
- 9:32 PM Changeset in webkit [157489] by
-
- 5 edits in trunk/Source/JavaScriptCore
Get rid of the StructureStubInfo::patch union
https://bugs.webkit.org/show_bug.cgi?id=122877
Reviewed by Sam Weinig.
Just simplifying code by getting rid of data structures that ain't used no more.
Note that I replace the patch union with a patch struct. This means we say things like
stubInfo.patch.valueGPR instead of stubInfo.valueGPR. I think that this extra
encapsulation makes the code more readable: the patch struct contains just those things
that you need to know to perform patching.
- bytecode/StructureStubInfo.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- jit/JIT.cpp:
(JSC::PropertyStubCompilationInfo::copyToStubInfo):
- jit/Repatch.cpp:
(JSC::repatchByIdSelfAccess):
(JSC::replaceWithJump):
(JSC::linkRestoreScratch):
(JSC::generateProtoChainAccessStub):
(JSC::tryCacheGetByID):
(JSC::getPolymorphicStructureList):
(JSC::patchJumpToGetByIdStub):
(JSC::tryBuildGetByIDList):
(JSC::emitPutReplaceStub):
(JSC::emitPutTransitionStub):
(JSC::tryCachePutByID):
(JSC::tryBuildPutByIdList):
(JSC::tryRepatchIn):
(JSC::resetGetByID):
(JSC::resetPutByID):
(JSC::resetIn):
- 9:30 PM Changeset in webkit [157488] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL gardening.
- platform/efl/TestExpectations: svg/filters/filter-hidden-content.svg is passed after r142955.
- 9:27 PM Changeset in webkit [157487] by
-
- 2 edits in trunk/Source/WebCore
Another shot at a build fix; apparently these
do need exporting for some reason, but are different
on 32-bit.
- WebCore.exp.in:
- 9:21 PM Changeset in webkit [157486] by
-
- 18 edits in trunk/Source/WebCore
GenerateIsReachable=ImplContext is confusing
https://bugs.webkit.org/show_bug.cgi?id=122864
Reviewed by Geoffrey Garen.
Renamed to ImplWebGLRenderingContext.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- html/canvas/EXTDrawBuffers.idl:
- html/canvas/EXTTextureFilterAnisotropic.idl:
- html/canvas/OESElementIndexUint.idl:
- html/canvas/OESStandardDerivatives.idl:
- html/canvas/OESTextureFloat.idl:
- html/canvas/OESTextureHalfFloat.idl:
- html/canvas/OESVertexArrayObject.idl:
- html/canvas/WebGLCompressedTextureATC.idl:
- html/canvas/WebGLCompressedTexturePVRTC.idl:
- html/canvas/WebGLCompressedTextureS3TC.idl:
- html/canvas/WebGLDebugRendererInfo.idl:
- html/canvas/WebGLDebugShaders.idl:
- html/canvas/WebGLDepthTexture.idl:
- html/canvas/WebGLLoseContext.idl:
- WebCore.xcodeproj/project.pbxproj: While at it, added OESElementIndexUint.idl
to Xcode project.
- 9:13 PM Changeset in webkit [157485] by
-
- 6 edits in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r155408.
- platform/efl/fast/forms/input-placeholder-visibility-1-expected.txt:
- platform/efl/fast/forms/input-placeholder-visibility-3-expected.txt:
- platform/efl/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
- platform/efl/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/efl/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- 9:08 PM Changeset in webkit [157484] by
-
- 3 edits in trunk/Source/WebKit2
Removed argument coders for FloatPoint3D in CoodinatedGraphicsArgumentCoders.
https://bugs.webkit.org/show_bug.cgi?id=122875
Reviewed by Gyuyoung Kim.
Argument coders for FloatPoint3D is added in WebCoreArgumentCoders after r157478
and it caused redefinition build error in EFL port.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
- 9:05 PM Changeset in webkit [157483] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix; I don't know how to export.
This may not help.
- WebCore.exp.in:
- 8:59 PM Changeset in webkit [157482] by
-
- 3 edits in trunk/Source/JavaScriptCore
FTL: add support for Int52ToValue and fix putByVal of int52s.
https://bugs.webkit.org/show_bug.cgi?id=122873
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-15
Reviewed by Filip Pizlo.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileInt52ToValue):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
- 8:10 PM Changeset in webkit [157481] by
-
- 4 edits in trunk/Source/JavaScriptCore
Get rid of the UNINTERRUPTED_SEQUENCE thing
https://bugs.webkit.org/show_bug.cgi?id=122876
Reviewed by Mark Hahnenberg.
It doesn't make sense anymore. We now use the DFG's IC logic, which never needed that.
Moreover, we should resist the temptation to bring anything like this back. We don't
want to have inline caches that only work if the assembler lays out code in a specific
predetermined way.
- jit/JIT.h:
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
- 7:19 PM Changeset in webkit [157480] by
-
- 12 edits in trunk/Source/JavaScriptCore
Baseline JIT should use the DFG GetById IC
https://bugs.webkit.org/show_bug.cgi?id=122861
Reviewed by Oliver Hunt.
This mostly just kills a ton of code.
Note that this doesn't yet do all of the simplifications that can be done, but it does
kill dead code. I'll have another change to simplify StructureStubInfo's unions and such.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetStubInternal):
- jit/JIT.cpp:
(JSC::PropertyStubCompilationInfo::copyToStubInfo):
- jit/JIT.h:
(JSC::PropertyStubCompilationInfo::PropertyStubCompilationInfo):
- jit/JITInlines.h:
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResultWithProfile):
(JSC::JIT::callOperation):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emitSlow_op_get_from_scope):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emitSlow_op_get_from_scope):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- jit/Repatch.cpp:
(JSC::repatchGetByID):
(JSC::buildGetByIDList):
- jit/ThunkGenerators.cpp:
- jit/ThunkGenerators.h:
- 5:34 PM Changeset in webkit [157479] by
-
- 12 edits in trunk
Add ENABLE_WEB_ANIMATIONS flag
https://bugs.webkit.org/show_bug.cgi?id=122871
Reviewed by Tim Horton.
Eventually might be http://dev.w3.org/fxtf/web-animations/
but this is just engine-internal work at the moment.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 5:20 PM Changeset in webkit [157478] by
-
- 23 edits4 adds2 deletes in trunk/Source
Add a PlatformCALayer subclass that proxies its property changes across the process boundary
https://bugs.webkit.org/show_bug.cgi?id=122773
Reviewed by Anders Carlsson.
PlatformCALayerRemote coordinates with RemoteLayerTreeDrawingArea and friends
to enable cross-process proxying of the hierarchy of compositing layers.
In the Web process, we have GraphicsLayerCARemote, which owns 1+ PlatformCALayerRemote(s).
Unlike PlatformCALayer{Mac, Win}, which own PlatformLayers (CALayer/CACFLayer),
PlatformCALayerRemote stores any changes to its properties in a struct, and keeps track of
which properties have changed since the last commit. Commits are scheduled and performed by
RemoteLayerTreeContext, on RemoteLayerTreeDrawingArea's behalf, and result in
RemoteLayerTreeTransaction encoding said property changes and throwing them across
to the UI process, where RemoteLayerTreeHost applies them to a tree of CALayers kept there.
This code can be enabled by running with the WK_USE_REMOTE_LAYER_TREE_DRAWING_AREA
environment variable set.
No new tests, the new drawing area is not yet testable.
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::decode):
(CoreIPC::encode):
- Shared/WebCoreArgumentCoders.h:
Add argument coders for FloatPoint3D.
- Shared/mac/RemoteLayerTreeTransaction.h:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::notePropertiesChanged):
(WebKit::RemoteLayerTreeTransaction::changedLayers):
(WebKit::RemoteLayerTreeTransaction::destroyedLayers):
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::RemoteLayerTreeTransaction::decode):
(WebKit::dumpChangedLayers):
Add support for background color and anchor point in the layer transaction.
Make layer position a 3D point because that's what it really is.
(WebKit::RemoteLayerTreeTransaction::layerPropertiesChanged):
The logic in layerPropertiesChanged is moved into PlatformCALayerRemote.
- UIProcess/WebPageProxy.h:
Include PlatformLayer.h; it seems annoying to successfully forward-declare
PlatformLayer because of the difference in definition between Objective-C and C++.
Drive-by un-indent some namespace contents and use OBJC_CLASS.
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::sizeDidChange):
(WebKit::RemoteLayerTreeDrawingAreaProxy::didUpdateGeometry):
(WebKit::RemoteLayerTreeDrawingAreaProxy::sendUpdateGeometry):
Send geometry updates to the RemoteLayerTreeDrawingArea.
- UIProcess/mac/RemoteLayerTreeHost.h:
- UIProcess/mac/RemoteLayerTreeHost.mm:
(nullActionsDictionary):
(WebKit::RemoteLayerTreeHost::commit):
Apply layer property changes to the named sublayer.
(WebKit::RemoteLayerTreeHost::getOrCreateLayer):
Create CALayers instead of GraphicsLayers.
Ensure that they won't perform implicit animations.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer):
This should take a PlatformLayer instead of a GraphicsLayer, since we don't have
GraphicsLayers in the UIProcess.
- WebKit2.xcodeproj/project.pbxproj:
Add GraphicsLayerCARemote and PlatformCALayerRemote, remove RemoteGraphicsLayer.
- WebProcess/WebPage/mac/RemoteGraphicsLayer.h: Removed.
- WebProcess/WebPage/mac/RemoteGraphicsLayer.mm: Removed.
- WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::RemoteLayerTreeContext):
(WebKit::RemoteLayerTreeContext::setRootLayer):
(WebKit::RemoteLayerTreeContext::layerWillBeDestroyed):
(WebKit::RemoteLayerTreeContext::createGraphicsLayer):
(WebKit::RemoteLayerTreeContext::flushLayers):
Build our transaction while flushing; it has no reason to exist outside of that scope.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::graphicsLayerFactory):
(WebKit::RemoteLayerTreeDrawingArea::setRootCompositingLayer):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):
(WebKit::RemoteLayerTreeDrawingArea::updateGeometry):
Fix a capitalization typo.
Update the WebPage's (and thus WebCore's) size when updateGeometry() is called.
- WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp: Added.
(WebKit::GraphicsLayerCARemote::~GraphicsLayerCARemote):
(WebKit::GraphicsLayerCARemote::filtersCanBeComposited):
(WebKit::GraphicsLayerCARemote::createPlatformCALayer):
Added. Delegate to PlatformCALayerRemote. Don't allow creation of a
GraphicsLayerCARemote given a PlatformLayer, because with UI process compositing,
there should be no PlatformLayer instances in the Web process.
- WebProcess/WebPage/mac/GraphicsLayerCARemote.h: Added.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp: Added.
(generateLayerID):
Generate a layer ID for identification across processes.
(PlatformCALayerRemote::~PlatformCALayerRemote):
Inform the RemoteLayerTreeContext that we've been destroyed, so it can convey
that information to the UI process and the corresponding CALayer can be destroyed.
(PlatformCALayerRemote::recursiveBuildTransaction):
Recursively accumulate changes in layer state on a RemoteLayerTreeTransaction.
The rest of this file is mostly an empty implementation of PlatformCALayer.
A few properties are implemented so far; see below.
(PlatformCALayerRemote::setSublayers):
(PlatformCALayerRemote::removeAllSublayers):
(PlatformCALayerRemote::appendSublayer):
(PlatformCALayerRemote::insertSublayer):
Update our list of sublayers, and note that our children have changed.
recursiveBuildTransaction() will walk our sublayers and record their IDs in the transaction.
(PlatformCALayerRemote::bounds):
(PlatformCALayerRemote::setBounds):
(PlatformCALayerRemote::position):
(PlatformCALayerRemote::setPosition):
(PlatformCALayerRemote::anchorPoint):
(PlatformCALayerRemote::setAnchorPoint):
(PlatformCALayerRemote::backgroundColor):
(PlatformCALayerRemote::setBackgroundColor):
Trivial implementations of basic layer properties, storing the new state in
our LayerProperties struct and noting that they changed in the current commit.
Properties with getters will return the last value that was set on the LayerProperties,
so we don't clear the whole struct at the end of the transaction, just the mask of changed properties.
- WebProcess/WebPage/mac/PlatformCALayerRemote.h: Added.
- WebCore.exp.in:
Export lots of GraphicsLayerCA stuff so we can inherit from it in WebKit2.
- WebCore.xcodeproj/project.pbxproj:
Make PlatformCAFilters.h a private header.
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::initialize):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayer::create):
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::initialize):
- platform/graphics/ca/GraphicsLayerCA.h:
Defer creation of the main PlatformCALayer until just after the constructor is finished
so that GraphicsLayerCA subclasses can successfully override createPlatformCALayer.
- platform/graphics/ca/PlatformCALayer.h:
(WebCore::PlatformCALayer::platformLayer):
Make platformLayer virtual so that subclasses which don't have PlatformLayers can override.
- 4:56 PM Changeset in webkit [157477] by
-
- 1 edit1 add1 delete in trunk/LayoutTests
[Windows] Unreviewed gardening of some forms tests.
- platform/win/fast/forms/search-styled-expected.txt: Added.
- platform/win/fast/forms/select-writing-direction-natural-expected.txt: Removed.
- 3:40 PM Changeset in webkit [157476] by
-
- 4 edits2 moves2 adds in trunk/Source/WebKit2
Move WebProcess/IndexedDB to WebProcess/Databases/IndexedDB
Rubberstamped by Alexey Proskuryakov.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp: Renamed from Source/WebKit2/WebProcess/IndexedDB/WebIDBFactoryBackend.cpp.
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h: Renamed from Source/WebKit2/WebProcess/IndexedDB/WebIDBFactoryBackend.h.
- 3:23 PM Changeset in webkit [157475] by
-
- 4 edits in trunk/Source/JavaScriptCore
[sh4] Some calls don't match sh4 ABI.
https://bugs.webkit.org/show_bug.cgi?id=122863
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-15
Reviewed by Michael Saboff.
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- 3:16 PM Changeset in webkit [157474] by
-
- 52 edits8 adds in trunk/Source
[iOS] Upstream JavaScriptCore support for ARM64
https://bugs.webkit.org/show_bug.cgi?id=122762
Source/JavaScriptCore:
Reviewed by Oliver Hunt and Filip Pizlo.
- Configurations/Base.xcconfig:
- Configurations/DebugRelease.xcconfig:
- Configurations/JavaScriptCore.xcconfig:
- Configurations/ToolExecutable.xcconfig:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/ARM64Assembler.h: Added.
- assembler/AbstractMacroAssembler.h:
(JSC::isARM64):
(JSC::AbstractMacroAssembler::Label::Label):
(JSC::AbstractMacroAssembler::Jump::Jump):
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
(JSC::AbstractMacroAssembler::CachedTempRegister::CachedTempRegister):
(JSC::AbstractMacroAssembler::CachedTempRegister::registerIDInvalidate):
(JSC::AbstractMacroAssembler::CachedTempRegister::registerIDNoInvalidate):
(JSC::AbstractMacroAssembler::CachedTempRegister::value):
(JSC::AbstractMacroAssembler::CachedTempRegister::setValue):
(JSC::AbstractMacroAssembler::CachedTempRegister::invalidate):
(JSC::AbstractMacroAssembler::invalidateAllTempRegisters):
(JSC::AbstractMacroAssembler::isTempRegisterValid):
(JSC::AbstractMacroAssembler::clearTempRegisterValid):
(JSC::AbstractMacroAssembler::setTempRegisterValid):
- assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::copyCompactAndLinkCode):
(JSC::LinkBuffer::linkCode):
- assembler/LinkBuffer.h:
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::isPtrAlignedAddressOffset):
(JSC::MacroAssembler::pushToSave):
(JSC::MacroAssembler::popToRestore):
(JSC::MacroAssembler::patchableBranchTest32):
- assembler/MacroAssemblerARM64.h: Added.
- assembler/MacroAssemblerARMv7.h:
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithDiv):
(JSC::DFG::SpeculativeJIT::compileArithMod):
- disassembler/ARM64/A64DOpcode.cpp: Added.
- disassembler/ARM64/A64DOpcode.h: Added.
- disassembler/ARM64Disassembler.cpp: Added.
- heap/MachineStackMarker.cpp:
(JSC::getPlatformThreadRegisters):
(JSC::otherThreadStackPointer):
- heap/Region.h:
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::debugCall):
- jit/CCallHelpers.h:
- jit/ExecutableAllocator.h:
- jit/FPRInfo.h:
(JSC::FPRInfo::toRegister):
(JSC::FPRInfo::toIndex):
(JSC::FPRInfo::debugName):
- jit/GPRInfo.h:
(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):
(JSC::GPRInfo::debugName):
- jit/JITInlines.h:
(JSC::JIT::restoreArgumentReferenceForTrampoline):
- jit/JITOperationWrappers.h:
- jit/JITOperations.cpp:
- jit/JITStubs.cpp:
(JSC::performPlatformSpecificJITAssertions):
(JSC::tryCachePutByID):
- jit/JITStubs.h:
(JSC::JITStackFrame::returnAddressSlot):
- jit/JITStubsARM64.h: Added.
- jit/JSInterfaceJIT.h:
- jit/Repatch.cpp:
(JSC::emitRestoreScratch):
(JSC::generateProtoChainAccessStub):
(JSC::tryCacheGetByID):
(JSC::emitPutReplaceStub):
(JSC::tryCachePutByID):
(JSC::tryRepatchIn):
- jit/ScratchRegisterAllocator.h:
(JSC::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
- jit/ThunkGenerators.cpp:
(JSC::nativeForGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
- jsc.cpp:
(main):
- llint/LLIntOfflineAsmConfig.h:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::handleHostCall):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter64.asm:
- offlineasm/arm.rb:
- offlineasm/arm64.rb: Added.
- offlineasm/backends.rb:
- offlineasm/instructions.rb:
- offlineasm/risc.rb:
- offlineasm/transform.rb:
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::alignCallFrameSizeInBytes):
(JSC::Yarr::YarrGenerator::initCallFrame):
(JSC::Yarr::YarrGenerator::removeCallFrame):
(JSC::Yarr::YarrGenerator::generateEnter):
- yarr/YarrJIT.h:
Source/WTF:
Reviewed by Oliver Hunt.
- Configurations/Base.xcconfig:
- wtf/Atomics.h:
(WTF::weakCompareAndSwap):
(WTF::armV7_dmb):
- wtf/FastMalloc.cpp:
- wtf/Platform.h:
- wtf/dtoa.cpp:
- wtf/dtoa/utils.h:
- wtf/text/ASCIIFastPath.h:
(WTF::copyLCharsFromUCharSource):
- wtf/text/StringImpl.h:
- 3:05 PM Changeset in webkit [157473] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix 3 operand sub operation in C loop LLINT.
https://bugs.webkit.org/show_bug.cgi?id=122866.
Reviewed by Geoffrey Garen.
- offlineasm/cloop.rb:
- 3:01 PM Changeset in webkit [157472] by
-
- 3 edits in branches/safari-537.73-branch/LayoutTests
Merging gardening patch for layout tests.
- 2:59 PM Changeset in webkit [157471] by
-
- 3 edits in branches/safari-537-branch/LayoutTests
Merging gardening patch for layout tests.
- 2:13 PM Changeset in webkit [157470] by
-
- 3 edits3 adds in trunk
REGRESSION: Crash in XMLDocumentParser::startElementNs
https://bugs.webkit.org/show_bug.cgi?id=122817
Reviewed by Darin Adler.
Source/WebCore:
Exit early in startElementNs when listeners and handlers of synchronous events such as load event
removes the inserted node inside parserAppendChild.
Test: fast/parser/xhtml-synchronous-detach-crash.html
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startElementNs):
LayoutTests:
Add a regression test from https://chromium.googlesource.com/chromium/blink/+/57afab5d21cccd89f032b9a3e62f3a61c6a0e9c2
- fast/parser/resources/remove-parent.xhtml: Added.
- fast/parser/xhtml-synchronous-detach-crash-expected.txt: Added.
- fast/parser/xhtml-synchronous-detach-crash.html: Added.
- 2:11 PM Changeset in webkit [157469] by
-
- 6 edits24 adds in trunk/Source/WebKit2
Add a skeleton Database process for future usage by Indexed Database.
https://bugs.webkit.org/show_bug.cgi?id=122849
Reviewed by Sam Weinig.
This mostly our typical "Add a new process type" boilerplate.
- Configurations/DatabaseProcess.xcconfig: Added.
- Configurations/DatabaseService.Development.xcconfig: Added.
- Configurations/DatabaseService.xcconfig: Added.
- WebKit2.xcodeproj/project.pbxproj:
- WebKit2Prefix.h:
- DatabaseProcess/DatabaseProcess.cpp: Added.
(WebKit::DatabaseProcess::shared):
(WebKit::DatabaseProcess::DatabaseProcess):
(WebKit::DatabaseProcess::~DatabaseProcess):
(WebKit::DatabaseProcess::initializeConnection):
(WebKit::DatabaseProcess::shouldTerminate):
(WebKit::DatabaseProcess::didReceiveMessage):
(WebKit::DatabaseProcess::didClose):
(WebKit::DatabaseProcess::didReceiveInvalidMessage):
(WebKit::DatabaseProcess::initializeProcess):
(WebKit::DatabaseProcess::initializeProcessName):
(WebKit::DatabaseProcess::initializeSandbox):
- DatabaseProcess/DatabaseProcess.h: Added.
- DatabaseProcess/EntryPoint/mac/LegacyProcess/DatabaseProcessMain.mm: Added.
(DatabaseProcessMain):
- DatabaseProcess/EntryPoint/mac/LegacyProcess/Info.plist: Added.
- DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService.Development/Info.plist: Added.
- DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist: Added.
- DatabaseProcess/EntryPoint/mac/XPCService/DatabaseServiceEntryPoint.mm: Added.
(DatabaseServiceInitializer):
- DatabaseProcess/mac/DatabaseProcessMac.mm: Added.
(WebKit::DatabaseProcess::initializeProcess):
(WebKit::DatabaseProcess::initializeProcessName):
(WebKit::DatabaseProcess::initializeSandbox):
- UIProcess/Databases/DatabaseProcessProxy.cpp: Added.
(WebKit::DatabaseProcessProxy::create):
(WebKit::DatabaseProcessProxy::DatabaseProcessProxy):
(WebKit::DatabaseProcessProxy::~DatabaseProcessProxy):
(WebKit::DatabaseProcessProxy::getLaunchOptions):
(WebKit::DatabaseProcessProxy::connectionWillOpen):
(WebKit::DatabaseProcessProxy::connectionWillClose):
(WebKit::DatabaseProcessProxy::didReceiveMessage):
(WebKit::DatabaseProcessProxy::didClose):
(WebKit::DatabaseProcessProxy::didReceiveInvalidMessage):
(WebKit::DatabaseProcessProxy::didFinishLaunching):
- UIProcess/Databases/DatabaseProcessProxy.h: Added.
- UIProcess/Databases/mac/DatabaseProcessProxyMac.mm: Added.
(WebKit::shouldUseXPC):
(WebKit::DatabaseProcessProxy::platformGetLaunchOptions):
- UIProcess/Launcher/ProcessLauncher.cpp:
(WebKit::ProcessLauncher::processTypeAsString):
(WebKit::ProcessLauncher::getProcessTypeFromString):
- UIProcess/Launcher/ProcessLauncher.h:
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::serviceName):
(WebKit::createProcess):
- 2:08 PM Changeset in webkit [157468] by
-
- 8 edits2 adds in trunk/Source/JavaScriptCore
ObjCCallbackFunctionImpl shouldn't store a JSContext
https://bugs.webkit.org/show_bug.cgi?id=122531
Reviewed by Geoffrey Garen.
The m_context field in ObjCCallbackFunctionImpl is vestigial and is only incidentally correct
in the common case. It's also no longer necessary in that we can look up the current JSContext
by looking using the globalObject of the callee when the function callback is invoked.
Also added a new test that would cause us to crash previously. The test required making
JSContextGetGlobalContext public API so that clients can obtain a JSContext from the JSContextRef
in C API callbacks.
- API/JSContextRef.h:
- API/JSContextRefPrivate.h:
- API/ObjCCallbackFunction.mm:
(JSC::ObjCCallbackFunctionImpl::ObjCCallbackFunctionImpl):
(JSC::objCCallbackFunctionCallAsFunction):
(objCCallbackFunctionForInvocation):
- API/WebKitAvailability.h:
- API/tests/CurrentThisInsideBlockGetterTest.h: Added.
- API/tests/CurrentThisInsideBlockGetterTest.mm: Added.
(CallAsConstructor):
(ConstructorFinalize):
(ConstructorClass):
(+[JSValue valueWithConstructorDescriptor:inContext:]):
(-[JSContext valueWithConstructorDescriptor:]):
(currentThisInsideBlockGetterTest):
- API/tests/testapi.mm:
- JavaScriptCore.xcodeproj/project.pbxproj:
- debugger/Debugger.cpp: Had to add some fully qualified names to avoid conflicts with Mac OS X headers.
- 2:03 PM Changeset in webkit [157467] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix build after r157457 for architecture with 4 argument registers.
https://bugs.webkit.org/show_bug.cgi?id=122860
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-15
Reviewed by Michael Saboff.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupStubArguments134):
- 1:47 PM Changeset in webkit [157466] by
-
- 3 edits1 delete in trunk/Source/WebCore
Web Inspector: Remove old frontend localizedStrings.js
https://bugs.webkit.org/show_bug.cgi?id=122846
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-15
Reviewed by Timothy Hatcher.
- Configurations/WebCore.xcconfig:
- English.lproj/localizedStrings.js: Removed.
- WebCore.xcodeproj/project.pbxproj:
Remove the file and references to it. We no longer need to exclude
localizedString.js from some builds.
- 1:41 PM Changeset in webkit [157465] by
-
- 4 edits in trunk/Source
Web Inspector: Remove Windows old front-end related code
https://bugs.webkit.org/show_bug.cgi?id=122845
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-15
Reviewed by Brent Fulgham.
Source/WebCore:
- WebCore.vcxproj/copyWebCoreResourceFiles.cmd:
Source/WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::openInspectorFrontend):
- 1:28 PM Changeset in webkit [157464] by
-
- 4 edits1 add in trunk/Source/WebKit
Expose -[WebPluginPackage bundle] as SPI
https://bugs.webkit.org/show_bug.cgi?id=122814
Reviewed by Anders Carlsson.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj: Added WebPluginPackagePrivate.h.
Source/WebKit/mac:
- Plugins/WebPluginPackage.mm:
(-[WebPluginPackage bundle]): Defined.
- Plugins/WebPluginPackagePrivate.h: Declared bundle as a method in a
category on NSObject.
- 1:24 PM Changeset in webkit [157463] by
-
- 2 edits in branches/safari-537.73-branch/LayoutTests
Merge r157460.
- 1:23 PM Changeset in webkit [157462] by
-
- 2 edits in branches/safari-537-branch/LayoutTests
Merge r157460.
- 1:20 PM Changeset in webkit [157461] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r157460.
http://trac.webkit.org/changeset/157460
https://bugs.webkit.org/show_bug.cgi?id=122858
Mis-skip, test isn't actually failing. (Requested by rfong on
#webkit).
- platform/wk2/TestExpectations:
- 1:10 PM Changeset in webkit [157460] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Skip unexpected flakey test: webaudio/oscillator-sawtooth.html.
- platform/wk2/TestExpectations:
- 12:40 PM Changeset in webkit [157459] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: can't select text inside a text node
https://bugs.webkit.org/show_bug.cgi?id=122828
Reviewed by Timothy Hatcher.
Cancel the default user interaction when a drag action starts if the
element is being edited.
- UserInterface/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype.onattach):
(WebInspector.DOMTreeElement.prototype.handleEvent):
- 11:45 AM Changeset in webkit [157458] by
-
- 117 edits4 adds in trunk
Add support for the column-fill property
https://bugs.webkit.org/show_bug.cgi?id=117693
Patch by Morten Stenshorne <mstensho@opera.com> on 2013-10-15
Reviewed by David Hyatt.
Source/WebCore:
This is only supported in the (new) region based multicol implementation.
With column-fill support, a lot of multicol tests needed an update.
The old implementation behaved as if column-fill were 'auto', but the
initial value is 'balance', so now we need to be explicit about that.
For auto-height tests it doesn't really matter - such multicols are always
balanced anyway.
Tests: fast/multicol/newmulticol/fixed-height-fill-auto.html
fast/multicol/newmulticol/fixed-height-fill-balance.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ColumnFill):
- css/CSSPropertyNames.in:
- css/CSSValueKeywords.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
- rendering/RenderMultiColumnBlock.h:
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleMultiColData.cpp:
(WebCore::StyleMultiColData::StyleMultiColData):
(WebCore::StyleMultiColData::operator==):
- rendering/style/StyleMultiColData.h:
LayoutTests:
With column-fill support, a lot of multicol tests needed an update.
The old implementation behaved as if column-fill were 'auto', but the
initial value is 'balance', so now we need to be explicit about that.
For auto-height tests it doesn't really matter - such multicols are always
balanced anyway.
- compositing/geometry/composited-in-columns.html:
- fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.html:
- fast/block/positioning/offsetLeft-offsetTop-multicolumn.html:
- fast/borders/border-antialiasing.html:
- fast/dynamic/float-moved-downwards-for-pagination-expected.html:
- fast/dynamic/float-moved-downwards-for-pagination.html:
- fast/dynamic/layer-no-longer-paginated.html:
- fast/events/document-elementFromPoint.html:
- fast/line-grid/line-grid-inside-columns.html:
- fast/line-grid/line-grid-into-columns.html:
- fast/multicol/break-properties.html:
- fast/multicol/cell-shrinkback.html:
- fast/multicol/client-rects.html:
- fast/multicol/column-count-with-rules.html:
- fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode.html:
- fast/multicol/flipped-blocks-hit-test.html:
- fast/multicol/float-paginate-complex.html:
- fast/multicol/float-paginate-empty-lines.html:
- fast/multicol/float-paginate.html:
- fast/multicol/float-truncation.html:
- fast/multicol/hit-test-above-or-below.html:
- fast/multicol/hit-test-end-of-column-with-line-height.html:
- fast/multicol/hit-test-end-of-column.html:
- fast/multicol/hit-test-float.html:
- fast/multicol/image-inside-nested-blocks-with-border.html:
- fast/multicol/layers-in-multicol.html:
- fast/multicol/layers-split-across-columns.html:
- fast/multicol/margin-collapse.html:
- fast/multicol/mixed-opacity-fixed-test.html:
- fast/multicol/mixed-opacity-test.html:
- fast/multicol/mixed-positioning-stacking-order.html:
- fast/multicol/nested-columns.html:
- fast/multicol/newmulticol/cell-shrinkback-expected.html:
- fast/multicol/newmulticol/cell-shrinkback.html:
- fast/multicol/newmulticol/column-rules-fixed-height-expected.html:
- fast/multicol/newmulticol/fixed-height-fill-auto-expected.html: Added.
- fast/multicol/newmulticol/fixed-height-fill-auto.html: Added.
- fast/multicol/newmulticol/fixed-height-fill-balance-expected.html: Added.
- fast/multicol/newmulticol/fixed-height-fill-balance.html: Added.
- fast/multicol/newmulticol/float-avoidance-expected.html:
- fast/multicol/newmulticol/float-avoidance.html:
- fast/multicol/newmulticol/float-multicol-expected.html:
- fast/multicol/newmulticol/float-multicol.html:
- fast/multicol/newmulticol/float-paginate-complex-expected.html:
- fast/multicol/newmulticol/float-paginate-complex.html:
- fast/multicol/newmulticol/float-paginate-empty-lines-expected.html:
- fast/multicol/newmulticol/float-paginate-empty-lines.html:
- fast/multicol/newmulticol/float-paginate-expected.html:
- fast/multicol/newmulticol/float-paginate.html:
- fast/multicol/newmulticol/layers-in-multicol-expected.html:
- fast/multicol/newmulticol/layers-in-multicol.html:
- fast/multicol/newmulticol/layers-split-across-columns-expected.html:
- fast/multicol/newmulticol/layers-split-across-columns.html:
- fast/multicol/newmulticol/positioned-split-expected.html:
- fast/multicol/newmulticol/positioned-split.html:
- fast/multicol/newmulticol/positioned-with-constrained-height-expected.html:
- fast/multicol/newmulticol/positioned-with-constrained-height.html:
- fast/multicol/null-lastFloat-in-removeFloatingObjectsBelow.html:
- fast/multicol/orphans-relayout.html:
- fast/multicol/overflow-across-columns-percent-height.html:
- fast/multicol/overflow-across-columns.html:
- fast/multicol/overflow-content-expected.html:
- fast/multicol/overflow-content.html:
- fast/multicol/overflow-unsplittable.html:
- fast/multicol/pageLogicalOffset-vertical-expected.html:
- fast/multicol/pageLogicalOffset-vertical.html:
- fast/multicol/paginate-block-replaced.html:
- fast/multicol/positioned-outside-of-columns.html:
- fast/multicol/positioned-split.html:
- fast/multicol/positive-leading.html:
- fast/multicol/progression-reverse-overflow-expected.html:
- fast/multicol/progression-reverse-overflow.html:
- fast/multicol/progression-reverse.html:
- fast/multicol/scrolling-overflow.html:
- fast/multicol/seamless-flowed-through-columns-expected.html:
- fast/multicol/seamless-flowed-through-columns.html:
- fast/multicol/table-margin-collapse.html:
- fast/multicol/table-row-height-increase-expected.html:
- fast/multicol/table-row-height-increase.html:
- fast/multicol/table-vertical-align.html:
- fast/multicol/transform-inside-opacity.html:
- fast/multicol/unsplittable-inline-block.html:
- fast/multicol/vertical-lr/break-properties.html:
- fast/multicol/vertical-lr/column-count-with-rules.html:
- fast/multicol/vertical-lr/float-multicol.html:
- fast/multicol/vertical-lr/float-paginate-complex.html:
- fast/multicol/vertical-lr/float-paginate.html:
- fast/multicol/vertical-lr/float-truncation.html:
- fast/multicol/vertical-lr/image-inside-nested-blocks-with-border.html:
- fast/multicol/vertical-lr/nested-columns.html:
- fast/multicol/vertical-lr/rules-with-border-before.html:
- fast/multicol/vertical-lr/unsplittable-inline-block.html:
- fast/multicol/vertical-rl/break-properties.html:
- fast/multicol/vertical-rl/column-count-with-rules.html:
- fast/multicol/vertical-rl/float-avoidance.html:
- fast/multicol/vertical-rl/float-multicol.html:
- fast/multicol/vertical-rl/float-paginate-complex.html:
- fast/multicol/vertical-rl/float-paginate.html:
- fast/multicol/vertical-rl/float-truncation.html:
- fast/multicol/vertical-rl/image-inside-nested-blocks-with-border.html:
- fast/multicol/vertical-rl/nested-columns.html:
- fast/multicol/vertical-rl/rule-style.html:
- fast/multicol/vertical-rl/rules-with-border-before.html:
- fast/multicol/vertical-rl/unsplittable-inline-block.html:
- fast/multicol/widows-and-orphans.html:
- fast/regions/region-style-in-columns.html:
- fast/repaint/multicol-repaint.html:
- fast/sub-pixel/column-clipping.html:
- 11:33 AM Changeset in webkit [157457] by
-
- 15 edits in trunk/Source/JavaScriptCore
transition void cti_op_* methods to JIT operations.
https://bugs.webkit.org/show_bug.cgi?id=122617
Reviewed by Geoffrey Garen.
Converted the follow stubs to JIT operations:
cti_handle_watchdog_timer
cti_op_debug
cti_op_pop_scope
cti_op_profile_did_call
cti_op_profile_will_call
cti_op_put_by_index
cti_op_put_getter_setter
cti_op_tear_off_activation
cti_op_tear_off_arguments
cti_op_throw_static_error
cti_optimize
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
(JSC::CCallHelpers::setupThreeStubArgsGPR):
(JSC::CCallHelpers::setupStubArguments):
(JSC::CCallHelpers::setupStubArguments134):
- jit/JIT.cpp:
(JSC::JIT::emitEnterOptimizationCheck):
- jit/JIT.h:
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_tear_off_activation):
(JSC::JIT::emit_op_tear_off_arguments):
(JSC::JIT::emit_op_push_with_scope):
(JSC::JIT::emit_op_pop_scope):
(JSC::JIT::emit_op_push_name_scope):
(JSC::JIT::emit_op_throw_static_error):
(JSC::JIT::emit_op_debug):
(JSC::JIT::emit_op_profile_will_call):
(JSC::JIT::emit_op_profile_did_call):
(JSC::JIT::emitSlow_op_loop_hint):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_push_with_scope):
(JSC::JIT::emit_op_pop_scope):
(JSC::JIT::emit_op_push_name_scope):
(JSC::JIT::emit_op_throw_static_error):
(JSC::JIT::emit_op_debug):
(JSC::JIT::emit_op_profile_will_call):
(JSC::JIT::emit_op_profile_did_call):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_by_index):
(JSC::JIT::emit_op_put_getter_setter):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_by_index):
(JSC::JIT::emit_op_put_getter_setter):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- 11:17 AM Changeset in webkit [157456] by
-
- 3 edits in trunk/Source/WebCore
Skip unnecessary null check in RenderText::textLength().
<https://webkit.org/b/122841>
Reviewed by Antti Koivisto.
RenderText will never have a null String in m_text, so textLength()
can grab at the StringImpl directly, avoiding a null check.
- 11:16 AM Changeset in webkit [157455] by
-
- 4 edits in trunk/Source/WebCore
FontGenericFamilies should not be ref-counted.
<https://webkit.org/b/122835>
Reviewed by Anders Carlsson.
FontGenericFamilies is singly-owned by Settings.
- 11:08 AM Changeset in webkit [157454] by
-
- 3 edits in trunk/Source/WebCore
[CSS Shapes] Move RenderBlock::layoutShapeInsideInfo into RenderBlock.cpp
http://bugs.webkit.org/show_bug.cgi?id=122843
Reviewed by Oliver Hunt.
Historically, layoutShapeInsideInfo was a static function in RenderBlockLineLayout, then it has changed to be a member of RenderBlock,
but at that time it hasn't been moved to RenderBlock.cpp. This patch moves it into RenderBlock.cpp next to the Shapes functions. I removed
an unnecessary CSS_SHAPES #ifdef as well from RenderBlock.cpp.
No new tests, no behavior change.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::markShapeInsideDescendantsForLayout):
(WebCore::RenderBlock::layoutShapeInsideInfo):
- rendering/RenderBlockLineLayout.cpp:
- 11:05 AM Changeset in webkit [157453] by
-
- 7 edits3 adds in trunk/Tools
Add some API tests for Vector, RefPtr, and Ref
https://bugs.webkit.org/show_bug.cgi?id=122840
Reviewed by Andreas Kling.
- TestWebKitAPI/CMakeLists.txt: Added new files.
- TestWebKitAPI/GNUmakefile.am: Ditto.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
- TestWebKitAPI/Tests/WTF/Ref.cpp: Added.
- TestWebKitAPI/Tests/WTF/RefLogger.h: Added.
- TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added.
- TestWebKitAPI/Tests/WTF/Vector.cpp: Added move-only insert tests.
- 11:03 AM Changeset in webkit [157452] by
-
- 3 edits in trunk/Source/JavaScriptCore
[sh4] Introduce const pools in LLINT.
https://bugs.webkit.org/show_bug.cgi?id=122746
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-15
Reviewed by Michael Saboff.
In current implementation of LLINT for sh4, immediate values outside range -128..127 are
loaded this way:
mov.l .label, rx
bra out
nop
.balign 4
.label: .long immvalue
out:
This change introduces const pools for sh4 implementation to avoid lots of useless branches
and reduce code size. It also removes lines of dirty code, like jmpf and callf.
- offlineasm/instructions.rb: Remove jmpf and callf sh4 specific instructions.
- offlineasm/sh4.rb:
- 10:01 AM Changeset in webkit [157451] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix broken C Loop LLINT build.
https://bugs.webkit.org/show_bug.cgi?id=122839.
Reviewed by Michael Saboff.
- dfg/DFGFlushedAt.cpp:
- jit/JITOperations.h:
- 9:39 AM Changeset in webkit [157450] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Build fails.
https://bugs.webkit.org/show_bug.cgi?id=122830
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-15
Reviewed by Brent Fulgham.
- platform/network/NetworkStorageSessionStub.cpp:
(WebCore::NetworkStorageSession::createPrivateBrowsingSession): Update to new return type.
- 6:02 AM Changeset in webkit [157449] by
-
- 5 edits in trunk/Source/WebCore
FileIconLoader should not be ref-counted.
<https://webkit.org/b/122827>
FileIconLoader is singly-owned by FileInputType.
Reviewed by Antti Koivisto.
- 4:45 AM Changeset in webkit [157448] by
-
- 3 edits in trunk/Source/WebCore
RenderText should cache RenderStyle in locals more.
<https://webkit.org/b/122823>
Reviewed by Antti Koivisto.
Now that fetching the RenderStyle has to go through the parent,
we should avoid unnecessary loads by caching style() in a local.
- 4:44 AM Changeset in webkit [157447] by
-
- 2 edits in trunk/Source/WebKit2
[Soup] Unreviewed buildfix after r157445 for ENABLE(NETWORK_PROCESS) builds.
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
- 4:25 AM Changeset in webkit [157446] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Fix the GTK+ build after r157445.
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
(didFailProvisionalLoadWithErrorForFrame):
- 3:24 AM Changeset in webkit [157445] by
-
- 48 edits1 copy3 moves1 delete in trunk/Source
Move PlatformCertificateInfo to WebCore and make the ResourceResponse primitives work in terms of that platform agnostic object
https://bugs.webkit.org/show_bug.cgi?id=118520
Reviewed by Anders Carlsson.
Added PlatformCertificateInfo getter and setter to ResourceErrorBase
and ResourceResponseBase so that getting and setting certificates
becomes cross platform.
Changed the existing platform specific certificate getters and setters
of ResourceError and ResourceResponse to use the
PlatformCertificateInfo member.
Original patch by Kwang Yul Seo <skyul@company100.net>
Source/WebCore:
The following things were fixed by Csaba Osztrogonác:
- trivial conflicts resolved in WebCore.exp.in, project.pbxproj, NetworkResourceLoader.cpp, WebPageProxy.h, WebFrameLoaderClient.cpp and PlatformEfl.cmake.
- trivial fix in the new AsynchronousNetworkLoaderClient.cpp
- style fixed (NULL -> 0 and smaller indentation in WebCoreArgumentCodersSoup.cpp)
- obsolete change removed from NetworkResourceLoader.cpp
- unneeded typo removed from ResourceHandleSoup.cpp
- Fixed the if guard of including RetainPtr.h in PlatformCertificateInfo.h to make Windows build happy.
- add PlatformCertificateInfoCFNet.cpp with empty constructor and destructor to make Windows build happy.
- resolved conflict in Source/WebCore/WebCore.xcodeproj/project.pbxproj after r156488
- renamed KURL to URL after r156550.
- removed obsolete Qt changes
- added back initializers for m_soupFlags
- included gio/gio.h instead of libsoup/soup.h in PlatformCertificateInfo.h
- removed unused class forward declarations and includes
- GNUmakefile.list.am:
- PlatformEfl.cmake:
- Target.pri:
- WebCore.exp.in:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/network/PlatformCertificateInfo.h: Renamed from Source/WebKit2/Shared/soup/PlatformCertificateInfo.h.
(WebCore::PlatformCertificateInfo::certificate):
(WebCore::PlatformCertificateInfo::setCertificate):
(WebCore::PlatformCertificateInfo::tlsErrors):
(WebCore::PlatformCertificateInfo::setTLSErrors):
- platform/network/ResourceErrorBase.h:
(WebCore::ResourceErrorBase::platformCertificateInfo):
(WebCore::ResourceErrorBase::setPlatformCertificateInfo):
- platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::platformCertificateInfo):
(WebCore::ResourceResponseBase::setPlatformCertificateInfo):
- platform/network/cf/ResourceResponse.h:
- platform/network/mac/PlatformCertificateInfoMac.mm: Renamed from Source/WebKit2/Shared/mac/PlatformCertificateInfo.mm.
(WebCore::PlatformCertificateInfo::PlatformCertificateInfo):
(WebCore::PlatformCertificateInfo::~PlatformCertificateInfo):
(WebCore::PlatformCertificateInfo::setCertificateChain):
(WebCore::PlatformCertificateInfo::certificateChain):
(WebCore::PlatformCertificateInfo::dump):
- platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::setCertificateChain):
(WebCore::ResourceResponse::certificateChain):
- platform/network/soup/PlatformCertificateInfoSoup.cpp:
(WebCore::PlatformCertificateInfo::PlatformCertificateInfo):
(WebCore::PlatformCertificateInfo::~PlatformCertificateInfo):
- platform/network/soup/ResourceError.h:
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::tlsErrors):
(WebCore::ResourceError::setTLSErrors):
(WebCore::ResourceError::certificate):
(WebCore::ResourceError::setCertificate):
- platform/network/soup/ResourceErrorSoup.cpp:
(WebCore::ResourceError::platformCopy):
- platform/network/soup/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::soupMessageCertificate):
(WebCore::ResourceResponse::setSoupMessageCertificate):
(WebCore::ResourceResponse::soupMessageTLSErrors):
(WebCore::ResourceResponse::setSoupMessageTLSErrors):
- platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::toSoupMessage):
(WebCore::ResourceResponse::updateFromSoupMessage):
Source/WebKit2:
The following things were fixed by Csaba Osztrogonác:
- trivial conflicts resolved in WebCore.exp.in, project.pbxproj, NetworkResourceLoader.cpp, WebPageProxy.h, WebFrameLoaderClient.cpp and PlatformEfl.cmake.
- trivial fix in the new AsynchronousNetworkLoaderClient.cpp
- style fixed (NULL -> 0 and smaller indentation in WebCoreArgumentCodersSoup.cpp)
- obsolete change removed from NetworkResourceLoader.cpp
- unneeded typo removed from ResourceHandleSoup.cpp
- Fixed the if guard of including RetainPtr.h in PlatformCertificateInfo.h to make Windows build happy.
- add PlatformCertificateInfoCFNet.cpp with empty constructor and destructor to make Windows build happy.
- resolve conflict in Source/WebCore/WebCore.xcodeproj/project.pbxproj after r156488
- rename KURL to URL after r156550.
- remove obsolete Qt changes
- added back initializers for m_soupFlags
- included gio/gio.h instead of libsoup/soup.h in PlatformCertificateInfo.h
- removed unused class forward declarations and includes
- GNUmakefile.list.am:
- NetworkProcess/AsynchronousNetworkLoaderClient.cpp:
(WebKit::AsynchronousNetworkLoaderClient::didReceiveResponse):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/NetworkResourceLoader.cpp:
- NetworkProcess/mac/NetworkProcessMac.mm:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- Shared/API/c/mac/WKCertificateInfoMac.mm:
(WKCertificateInfoCreateWithCertficateChain):
- Shared/Authentication/AuthenticationManager.h:
- Shared/Authentication/AuthenticationManager.messages.in:
- Shared/Authentication/mac/AuthenticationManager.mac.mm:
- Shared/UserMessageCoders.h:
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebCertificateInfo.h:
(WebKit::WebCertificateInfo::create):
(WebKit::WebCertificateInfo::platformCertificateInfo):
(WebKit::WebCertificateInfo::WebCertificateInfo):
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::decode):
(CoreIPC::::encode):
- Shared/WebCoreArgumentCoders.h:
- Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):
- Shared/soup/PlatformCertificateInfo.cpp: Removed.
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):
- Target.pri:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_get_tls_info):
- UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::useCredential):
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didCommitLoad):
- UIProcess/WebFrameProxy.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Network/WebResourceLoader.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
- 12:02 AM Changeset in webkit [157444] by
-
- 4 edits in trunk/Source/WebCore
Remove redundant Document::getElementById
https://bugs.webkit.org/show_bug.cgi?id=122813
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/4e8f1c5316415614b84370c602beae4a1008299f
This function simply calls virtual TreeScope::getElementById and Document inherits from TreeScope.
- WebCore.exp.in:
- dom/Document.cpp:
- dom/Document.h:
Oct 14, 2013:
- 10:55 PM Changeset in webkit [157443] by
-
- 4 edits4 adds in trunk
Source/WebCore: in safari,the background-color of input[type="search"] can't work
https://bugs.webkit.org/show_bug.cgi?id=119967
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-14
Reviewed by Ryosuke Niwa.
When input type=search is styled with css background property then
it does not change the background-color of field. Its happening becasue
search field is not counted as styled control. Thus theme ignores the
css background property. With this patch search field is also counted as
styled control so background property reflects on search field.
Test: fast/forms/search/search-field-background-color.html
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isControlStyled):Now search field is also
a styled control.
LayoutTests: in safari ,the background-color of input[type="search"] can't work
https://bugs.webkit.org/show_bug.cgi?id=119967
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-14
Reviewed by Ryosuke Niwa.
Added testcase to verify the background color of search field when
search field is styled with css background property.
- fast/forms/search/search-field-background-color-expected.txt: Added.
- fast/forms/search/search-field-background-color.html: Added.
- platform/mac/fast/forms/search-styled-expected.txt: Rebaselined.
- 10:06 PM Changeset in webkit [157442] by
-
- 1 edit22 moves1 add in trunk/LayoutTests
[CSS Shapes] Move shape-inside floats tests into their own subdirectory
https://bugs.webkit.org/show_bug.cgi?id=122761
Reviewed by Sam Weinig.
I'm going to add some new float tests soon. In order to keep our shapes tests organized,
I'm moving the shape-inside with floating content tests to their own subdirectory.
- fast/shapes/shape-inside/floats/shape-inside-floats-simple-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-floats-simple-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-floats-simple.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-floats-simple.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-left-triangle-block-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-left-triangle-block-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-left-triangle-inline-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-left-triangle-inline-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-block-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-block-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-inline-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-inline-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-block-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-block-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-inline-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-inline-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-right-triangle-block-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-right-triangle-block-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-right-triangle-inline-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content-expected.html.
- fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-right-triangle-inline-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content.html.
- 9:08 PM Changeset in webkit [157441] by
-
- 3 edits in trunk/Source/WebCore
EventPath::updateTouchLists traverses through EventPath thrice
https://bugs.webkit.org/show_bug.cgi?id=122804
Reviewed by Benjamin Poulain.
Instead of traversing through EventPath for each TouchList, traverse through TouchList for every EventContext.
This paves our way to have one-pass traversal over EventPath, and evetually to remove EventContext altogether.
This change should also improve the cache hit rate since all Touch objects tend to be allocated at the same time
but this performance improvement is probably not observable.
- dom/EventContext.h:
- dom/EventDispatcher.cpp:
(WebCore::EventRelatedNodeResolver::EventRelatedNodeResolver): Added a new constructor that takes Touch and
and TouchListType. We need to store these two values in order to update EventContext later.
(WebCore::EventRelatedNodeResolver::touch): Added,
(WebCore::EventRelatedNodeResolver::touchListType): Added.
(WebCore::addRelatedNodeResolversForTouchList): Extracted from updateTouchListsInEventPath.
(WebCore::EventPath::updateTouchLists): Moved the loop over m_path here. Notice that the outer loop iterates
over m_path instead of touchList as done in updateTouchListsInEventPath. The inner loop goes through resolvers
and adds Touch objects each EventContext as needed.
- 8:48 PM Changeset in webkit [157440] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL gardening. Below tests don't be failed anymore after enabling subpixel layout.
fast/spatial-navigation/snav-container-white-space.html
fast/spatial-navigation/snav-fully-aligned-horizontally.html
fast/spatial-navigation/snav-iframe-no-scrollable-content.html
- platform/efl/TestExpectations:
- 8:03 PM Changeset in webkit [157439] by
-
- 11 edits in trunk/Source/JavaScriptCore
Transition *switch* and *scope* JITStubs to JIT operations.
https://bugs.webkit.org/show_bug.cgi?id=122757.
Reviewed by Geoffrey Garen.
Transitioning:
cti_op_switch_char
cti_op_switch_imm
cti_op_switch_string
cti_op_resolve_scope
cti_op_get_from_scope
cti_op_put_to_scope
- jit/JIT.h:
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_resolve_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitSlow_op_put_to_scope):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitSlow_op_resolve_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitSlow_op_put_to_scope):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- 7:47 PM Changeset in webkit [157438] by
-
- 16 edits in trunk/Source/WebCore
Don't generate a wasteful isObservable check in isReachableFromOpaqueRoots
https://bugs.webkit.org/show_bug.cgi?id=122802
Reviewed by Mark Hahnenberg.
- bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): Don't.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
- bindings/scripts/test/JS/JSTestException.cpp:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
- bindings/scripts/test/JS/JSattribute.cpp:
- bindings/scripts/test/JS/JSreadonly.cpp:
Updated results.
- 6:06 PM Changeset in webkit [157437] by
-
- 5 edits1 delete in trunk
Windows select element doesn't draw RTL properly.
https://bugs.webkit.org/show_bug.cgi?id=122785.
Reviewed by Brent Fulgham.
Problems include the popup items not drawing on the right hand side and
not respecting the direction or the directional override styling of the option.
The selected element (drawn in the actual select element) also doesn't respect
the style settings of the selected menu option.
Tests:
Covered by fast/text/international/pop-up-button-text-alignment-and-direction.html.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::paint):
- WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::selectItemWritingDirectionIsNatural):
(WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection):
- platform/win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Removed.
- 5:38 PM Changeset in webkit [157436] by
-
- 3 edits2 adds in trunk
Source/WebCore: AX: fieldset should have GroupRole and legend should be description.
https://bugs.webkit.org/show_bug.cgi?id=122534
Patch by Samuel White <Samuel White> on 2013-10-14
Reviewed by Chris Fleizach.
Changes fieldset to derive AXDescription from legend if one is available. Added
convenience method to AccessibilityObject to fetch element if available.
Test: accessibility/fieldset-element.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canHaveChildren):
(WebCore::AccessibilityNodeObject::alternativeText):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::element):
(WebCore::AccessibilityObject::isARIAHidden):
(WebCore::AccessibilityObject::isDOMHidden):
(WebCore::AccessibilityObject::defaultObjectInclusion):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isHidden):
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::getAttribute):
(WebCore::AccessibilitySlider::valueForRange):
(WebCore::AccessibilitySlider::maxValueForRange):
(WebCore::AccessibilitySlider::minValueForRange):
(WebCore::AccessibilitySlider::setValue):
(WebCore::AccessibilitySlider::inputElement):
- accessibility/AccessibilitySlider.h:
- accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::legend):
- html/HTMLFieldSetElement.h:
LayoutTests: Crash in WebCore::BidiResolver<WebCore::InlineIterator, WebCore::BidiRun>::createBidiRunsForLine
https://bugs.webkit.org/show_bug.cgi?id=122776
Reviewed by Darin Adler.
- fast/text/whitespace/whitespace-and-margin-wrap-after-list-marker-crash-expected.txt: Added.
- fast/text/whitespace/whitespace-and-margin-wrap-after-list-marker-crash.html: Added.
- 5:35 PM Changeset in webkit [157435] by
-
- 2 edits in trunk/Tools
Adding myself to CC list for some components.
- Scripts/webkitpy/common/config/watchlist:
- 5:23 PM Changeset in webkit [157434] by
-
- 12 edits2 adds6 deletes in trunk
AX: fieldset should have GroupRole and legend should be description.
https://bugs.webkit.org/show_bug.cgi?id=122534
Patch by Samuel White <Samuel White> on 2013-10-14
Reviewed by Chris Fleizach.
Source/WebCore:
Changes fieldset to derive AXDescription from legend if one is available. Added
convenience method to AccessibilityObject to fetch element if available.
Test: accessibility/fieldset-element.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canHaveChildren):
(WebCore::AccessibilityNodeObject::alternativeText):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::element):
(WebCore::AccessibilityObject::isARIAHidden):
(WebCore::AccessibilityObject::isDOMHidden):
(WebCore::AccessibilityObject::defaultObjectInclusion):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isHidden):
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::getAttribute):
(WebCore::AccessibilitySlider::valueForRange):
(WebCore::AccessibilitySlider::maxValueForRange):
(WebCore::AccessibilitySlider::minValueForRange):
(WebCore::AccessibilitySlider::setValue):
(WebCore::AccessibilitySlider::inputElement):
- accessibility/AccessibilitySlider.h:
- accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::legend):
- html/HTMLFieldSetElement.h:
LayoutTests:
legend no longer treated as titleUIElement so removing tests that check this functionality.
Added test to check that legend is used as AXDescription of fieldset if present.
- accessibility/fieldset-element.html: Added.
- accessibility/hidden-legend-expected.txt: Removed.
- accessibility/hidden-legend.html: Removed.
- accessibility/legend.html: Removed.
- platform/efl/accessibility/legend-expected.txt: Removed.
- platform/gtk/accessibility/legend-expected.txt: Removed.
- platform/mac/accessibility/fieldset-element-expected.txt: Added.
- platform/mac/accessibility/legend-expected.txt: Removed.
- platform/mac/accessibility/role-subrole-roledescription-expected.txt:
- platform/mac/accessibility/role-subrole-roledescription.html:
- 5:05 PM Changeset in webkit [157433] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG PutById IC should use the ConcurrentJITLocker since it's now dealing with IC's that get read by the compiler thread
https://bugs.webkit.org/show_bug.cgi?id=122786
Reviewed by Mark Hahnenberg.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetStub): Resetting a stub should acquire the lock since this is observable from the thread; but we should only acquire the lock if we're resetting outside of GC.
- jit/Repatch.cpp:
(JSC::repatchPutByID): Doing the PutById patching should hold the lock.
(JSC::buildPutByIdList): Ditto.
- 5:02 PM Changeset in webkit [157432] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Unreviewed build fix.
- WebCore.vcxproj/WebCoreCommon.props:
- 4:58 PM Changeset in webkit [157431] by
-
- 3 edits2 adds in trunk
Assertion failure in Range::processContentsBetweenOffsets
https://bugs.webkit.org/show_bug.cgi?id=122777
Reviewed by Darin Adler.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/c15de182774c7859c20d97126eb844ae97b792a4
This patch changes ASSERT statements for checking |endOffset| inbound in Range::processContentsBetweenOffsets()
to limit |endOffset|. This is necessary when DOMNodeRemovedFromDocument event handler splits text nodes,
Range::insertNode() on text node, in the range calling Range::deleteContents().
Test: fast/dom/Range/range-delete-contents-mutation-event-crash.html
- dom/Range.cpp:
(WebCore::Range::processContentsBetweenOffsets):
LayoutTests:
- fast/dom/Range/range-delete-contents-mutation-event-crash-expected.txt: Added.
- fast/dom/Range/range-delete-contents-mutation-event-crash.html: Added.
- 4:36 PM Changeset in webkit [157430] by
-
- 12 edits11 adds in trunk
Add an empty window.crypto.webkitSubtle
https://bugs.webkit.org/show_bug.cgi?id=122778
Reviewed by Mark Hahnenberg.
Source/WebCore:
Tests: security/crypto-subtle-gc-2.html
security/crypto-subtle-gc-3.html
security/crypto-subtle-gc.html
- DerivedSources.make: Process SubtleCrypto.idl.
- crypto: Added.
- WebCore.xcodeproj/project.pbxproj:
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- bindings/js/JSSubtleCryptoCustom.cpp: Added. Empty for now, but we'll certainly
need custom bindings code here.
- crypto/SubtleCrypto.cpp: Added.
(WebCore::SubtleCrypto::SubtleCrypto):
(WebCore::SubtleCrypto::document):
- crypto/SubtleCrypto.h: Added.
- crypto/SubtleCrypto.idl: Added.
- page/Crypto.cpp:
(WebCore::Crypto::subtle):
- page/Crypto.h:
- page/Crypto.idl:
LayoutTests:
- TestExpectations: The feature isn't enabled anywhere yet, so skipping the new tests.
- security/crypto-subtle-gc-2-expected.txt: Added.
- security/crypto-subtle-gc-2.html: Added.
- security/crypto-subtle-gc-3-expected.txt: Added.
- security/crypto-subtle-gc-3.html: Added.
- security/crypto-subtle-gc-expected.txt: Added.
- security/crypto-subtle-gc.html: Added.
- 4:30 PM Changeset in webkit [157429] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add FTL support for LogicalNot(string)
https://bugs.webkit.org/show_bug.cgi?id=122765
Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-14
Reviewed by Filip Pizlo.
This patch is tested by:
regress/script-tests/emscripten-cube2hash.js.ftl-eager
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileLogicalNot):
- 4:26 PM Changeset in webkit [157428] by
-
- 6 edits in trunk/Source/WebCore
Remove GestureEvent leftovers from WebCore
<https://webkit.org/b/122780>
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-10-14
Reviewed by Anders Carlsson.
- Removed some remaining references to PlatformGestureEvent, supposed to be removed by r157316
- TOUCH_ADJUSTMENT should be reworked after GestureEvent feature removal
- page/EventHandler.cpp:
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
- page/EventHandler.h:
- platform/PlatformEvent.h:
- platform/ScrollAnimatorNone.cpp:
- platform/ScrollableArea.h:
- 4:22 PM Changeset in webkit [157427] by
-
- 5 edits in trunk/Source/JavaScriptCore
[sh4] Fixes after r157404 and r157411.
https://bugs.webkit.org/show_bug.cgi?id=122782
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-14
Reviewed by Michael Saboff.
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation): Add missing SH4_32BIT_DUMMY_ARG.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- jit/JITInlines.h:
(JSC::JIT::callOperation): Add missing SH4_32BIT_DUMMY_ARG.
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_by_id): Remove unwanted BEGIN_UNINTERRUPTED_SEQUENCE.
- 4:17 PM Changeset in webkit [157426] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r157366
http://bugs.webkit.org/show_bug.cgi?id=122783
When TOUCH_AJUSTMENT is enabled build fails due to some
refactors in TextRender functions.
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-10-14
Reviewed by Anders Carlsson.
- page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::appendContextSubtargetsForNode):
- 4:08 PM Changeset in webkit [157425] by
-
- 5 edits3 adds in trunk
The content of the DOM panel for iframes is not updated until the "onload" event
https://bugs.webkit.org/show_bug.cgi?id=122653
Reviewed by Darin Adler.
Source/WebCore:
Test: http/tests/inspector-protocol/loading-iframe-document-node.html
Renamed InspectorDOMAgent::loadEventFired to InspectorDOMAgent::didCommitLoad and moved the call site
from InspectorInstrumentation::loadEventFiredImpl to InspectorInstrumentation::didCommitLoadImpl.
This is to make sure that it will invalidate the content of the iframe as soon as the frame navigates
to a different page. This way the new node can be retrieved as soon as the page has some content, and
not just when the page is fully loaded.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::didCommitLoad): Renamed from loadEventFired, as it is now called from
didCommitLoadImpl instead.
(WebCore::InspectorDOMAgent::frameDocumentUpdated): Updated comment to point to the new function name.
- inspector/InspectorDOMAgent.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::loadEventFiredImpl): Removed call do InspectorDOMAgent.loadEventFired.
(WebCore::InspectorInstrumentation::didCommitLoadImpl): Added call to InspectorDOMAgent.didCommitLoad.
LayoutTests:
Added test to check that immediately after the scripting context is created, the
inspector already has access to the nodeId of the document of the iframe.
- http/tests/inspector-protocol/loading-iframe-document-node-expected.txt: Added.
- http/tests/inspector-protocol/loading-iframe-document-node.html: Added.
- http/tests/inspector-protocol/resources/slow-test-page.html: Added.
- 2:59 PM Changeset in webkit [157424] by
-
- 14 edits1 delete in trunk/Source/JavaScriptCore
Unreviewed, rolling out r157413.
http://trac.webkit.org/changeset/157413
https://bugs.webkit.org/show_bug.cgi?id=122779
Appears to have caused frequent crashes (Requested by ap on
#webkit).
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/DeferGC.cpp: Removed.
- heap/DeferGC.h:
- jit/JITStubs.cpp:
(JSC::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/ConcurrentJITLock.h:
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- runtime/JSCellInlines.h:
(JSC::allocateCell):
- runtime/Structure.cpp:
(JSC::Structure::materializePropertyMap):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):
- runtime/Structure.h:
- 2:45 PM Changeset in webkit [157423] by
-
- 3 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=122774.
<rdar://problem/6138855>.
Reviewed by Brent Fulgham.
Add a field to keep track of hovered over index.
Use index to determine whether or not to use the existing selected index on the mouse down event.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::PopupMenuWin):
(WebCore::PopupMenuWin::show):
(WebCore::PopupMenuWin::wndProc):
- platform/win/PopupMenuWin.h:
- 2:41 PM Changeset in webkit [157422] by
-
- 2 edits in trunk/Source/JavaScriptCore
COLLECT_ON_EVERY_ALLOCATION causes assertion failures
https://bugs.webkit.org/show_bug.cgi?id=122652
Reviewed by Filip Pizlo.
COLLECT_ON_EVERY_ALLOCATION wasn't accounting for the new GC deferral mechanism,
so we would end up ASSERTing during garbage collection.
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::allocateSlowCase):
- 2:11 PM Changeset in webkit [157421] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, fix the paths so that the test passes.
- js/regress/put-by-id.html:
- 2:08 PM Changeset in webkit [157420] by
-
- 7 edits in trunk/Source/JavaScriptCore
Separate out array iteration intrinsics
https://bugs.webkit.org/show_bug.cgi?id=122656
Reviewed by Michael Saboff.
Separate out the intrinsics for key and values iteration
of arrays.
This requires moving moving array iteration into the iterator
instance, rather than the prototype, but this is essentially
unobservable so we'll live with it for now.
- jit/ThunkGenerators.cpp:
(JSC::arrayIteratorNextThunkGenerator):
(JSC::arrayIteratorNextKeyThunkGenerator):
(JSC::arrayIteratorNextValueThunkGenerator):
- jit/ThunkGenerators.h:
- runtime/ArrayIteratorPrototype.cpp:
(JSC::ArrayIteratorPrototype::finishCreation):
- runtime/Intrinsic.h:
- runtime/JSArrayIterator.cpp:
(JSC::JSArrayIterator::finishCreation):
(JSC::createIteratorResult):
(JSC::arrayIteratorNext):
(JSC::arrayIteratorNextKey):
(JSC::arrayIteratorNextValue):
(JSC::arrayIteratorNextGeneric):
- runtime/VM.cpp:
(JSC::thunkGeneratorForIntrinsic):
- 1:49 PM Changeset in webkit [157419] by
-
- 18 edits3 adds in trunk/Source
Virtualize PlatformCALayer
https://bugs.webkit.org/show_bug.cgi?id=122672
Reviewed by Anders Carlsson.
No new tests, just a refactoring.
- WebCore.exp.in:
setGeometryFlipped is on PlatformCALayerMac now.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
Add PlatformCALayer.cpp, PlatformCALayerWin.h, and let VS do its
thing with some other files.
- WebCore.xcodeproj/project.pbxproj:
Add PlatformCALayer.cpp and PlatformCALayerMac.h.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::AVFWrapper::platformLayer):
Make a PlatformCALayerWin explicitly.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createPlatformCALayer):
Added. Decide whether to make a PlatformCALayer{Mac, Win} based on the platform.
Later, we will decide between other subclasses based on other things.
(WebCore::GraphicsLayerCA::filtersCanBeComposited):
Do the same thing for filtersCanBeComposited.
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::setContentsToSolidColor):
(WebCore::GraphicsLayerCA::setContentsToMedia):
(WebCore::GraphicsLayerCA::setContentsToCanvas):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::updateContentsImage):
(WebCore::GraphicsLayerCA::updateContentsRects):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
Use createPlatformCALayer instead of PlatformCALayer::create.
- platform/graphics/ca/mac/PlatformCAFiltersMac.mm:
For now, use the PlatformCALayerMac version of filtersCanBeComposited,
since this code is heavily tied to having CALayers in the Web process.
- platform/graphics/ca/GraphicsLayerCA.h:
Include PlatformCALayer.h here so we can get the LayerType enum.
(NOTE-to-be-removed: if there's a better way to do this, I'm open to
suggestions; I couldn't puzzle out nested 'enum class' stuff).
Add the createPlatformCALayers.
- platform/graphics/ca/PlatformCAAnimation.h:
Friend the subclasses too.
- platform/graphics/ca/PlatformCALayer.cpp: Added.
(WebCore::PlatformCALayer::~PlatformCALayer):
Pull the shared part of the PlatformCALayer destructor out.
- platform/graphics/ca/PlatformCALayer.h:
(WebCore::PlatformCALayer::platformLayer):
(WebCore::PlatformCALayer::setOwner):
(WebCore::PlatformCALayer::PlatformCALayer):
Virtualize all the things. Move platform specific members to their new subclasses.
- platform/graphics/ca/mac/PlatformCALayerMac.h: Added.
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
Move the PLATFORM(MAC) implementations from PlatformCALayer to PlatformCALayerMac.
(PlatformCALayer::platformCALayer):
The platformCALayer lookup function is static on PlatformCALayer, so it can't
be moved to the subclasses. It might be a good idea in the future to move towards
a platform-independent mechanism for looking up PlatformCALayers from PlatformLayers,
and to avoid needing to do this as often as we do now.
- platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::CACFLayerTreeHost):
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
Move the PLATFORM(WIN) implementations from PlatformCALayer to PlatformCALayerWin.
(PlatformCALayerWin::create):
(PlatformCALayer::platformCALayer):
- platform/graphics/ca/win/PlatformCALayerWin.h: Added.
- platform/graphics/win/GraphicsContext3DWin.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::createLayerForMovie):
Include PlatformCALayerWin.h and explicitly make PlatformCALayerWins here.
- FullscreenVideoController.cpp:
(FullscreenVideoController::FullscreenVideoController):
Include PlatformCALayerWin.h and explicitly make PlatformCALayerWins here.
- 1:44 PM Changeset in webkit [157418] by
-
- 3 edits in trunk/Source/WebCore
[cmake] MediaControlsApple is used only by Efl port and is on CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=122772
Reviewed by Anders Carlsson.
- CMakeLists.txt: Removed MediaControlsApple.cpp
- PlatformEfl.cmake: Added MediaControlsApple.cpp
- 1:28 PM Changeset in webkit [157417] by
-
- 6 edits2 adds in trunk
window.crypto doesn't preserve custom properties
https://bugs.webkit.org/show_bug.cgi?id=122770
Reviewed by Mark Hahnenberg.
Source/WebCore:
Test: security/crypto-gc.html
Generate isReachableFromOpaqueRoots that makes Crypto live as long as the document
lives (because that's when it's observable through window object).
- page/Crypto.cpp:
(WebCore::Crypto::Crypto):
(WebCore::Crypto::~Crypto):
(WebCore::Crypto::document):
- page/Crypto.h:
(WebCore::Crypto::create):
Made Crypto a ContextDestructionObserver, so that it can report its document to bindings.
Removed ScriptWrappable, because it seems to have served no purpose in this class.
- page/Crypto.idl: Added GenerateIsReachable. Removed ImplementationLacksVTable,
because the class now has a vtable, and can be checked for bindings integrity.
- page/DOMWindow.cpp: (WebCore::DOMWindow::crypto): Pass a document when creating
crypto.
LayoutTests:
- security/crypto-gc-expected.txt: Added.
- security/crypto-gc.html: Added.
- 1:11 PM Changeset in webkit [157416] by
-
- 4 edits in trunk/Source/WebCore
CTTE: NamedNodeMap always has a corresponding Element.
<https://webkit.org/b/122769>
Reviewed by Anders Carlsson.
Made NamedNodeMap::m_element a reference and remove an assertion
that it's never null.
- 12:53 PM Changeset in webkit [157415] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r157408): Crashes in RenderFullScreen::wrapRenderer().
Unreviewed crash fix for these two tests:
- fullscreen/full-screen-restrictions.html
- fullscreen/empty-anonymous-block-continuation-crash.html
- rendering/RenderFullScreen.cpp:
(RenderFullScreen::wrapRenderer):
Get the RenderArena from Document like we did before this patch.
- 12:35 PM Changeset in webkit [157414] by
-
- 4 edits2 adds in trunk
[CSS Shapes] Image valued shape-outside shapes should update the layout after the image has been loaded
https://bugs.webkit.org/show_bug.cgi?id=122340
Reviewed by Simon Fraser.
Source/WebCore:
Ensure that the an image-valued shape-outside layout is updated after the image has
been loaded.
Test: http/tests/css/css-image-valued-shape.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::imageChanged): Added code for the shape-outside case.
(WebCore::RenderBlock::updateShapeInsideInfoAfterStyleChange): Ditto.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::~RenderElement): Ditto.
(WebCore::RenderElement::setStyle): Ditto.
LayoutTests:
Verify that an image-valued shape-outside layout is updated after the image has been loaded.
- http/tests/css/css-image-valued-shape-expected.txt: Added.
- http/tests/css/css-image-valued-shape.html: Added.
- 12:34 PM Changeset in webkit [157413] by
-
- 14 edits1 add in trunk/Source/JavaScriptCore
llint_slow_path_put_by_id can deadlock on a ConcurrentJITLock
https://bugs.webkit.org/show_bug.cgi?id=122667
Reviewed by Filip Pizlo.
The issue this patch is attempting to fix is that there are places in our codebase
where we acquire the ConcurrentJITLock for a particular CodeBlock, then we do some
operations that can initiate a garbage collection. Garbage collection then calls
some methods of CodeBlock that also take the ConcurrentJITLock (because they don't
always necessarily run during garbage collection). This causes a deadlock.
To fix this issue, this patch adds a new RAII-style object (DisallowGC) that stores
into a thread-local field that indicates that it is unsafe to perform any operation
that could trigger garbage collection on the current thread. In debug builds,
ConcurrentJITLocker contains one of these DisallowGC objects so that we can eagerly
detect deadlocks.
This patch also adds a new type of ConcurrentJITLocker, GCSafeConcurrentJITLocker,
which uses the DeferGC mechanism to prevent collections from occurring while the
lock is held.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/DeferGC.cpp: Added.
- heap/DeferGC.h:
(JSC::DisallowGC::DisallowGC):
(JSC::DisallowGC::~DisallowGC):
(JSC::DisallowGC::isGCDisallowedOnCurrentThread):
(JSC::DisallowGC::initialize):
- jit/JITStubs.cpp:
(JSC::tryCachePutByID):
(JSC::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/ConcurrentJITLock.h:
(JSC::ConcurrentJITLockerBase::ConcurrentJITLockerBase):
(JSC::ConcurrentJITLockerBase::~ConcurrentJITLockerBase):
(JSC::ConcurrentJITLockerBase::unlockEarly):
(JSC::GCSafeConcurrentJITLocker::GCSafeConcurrentJITLocker):
(JSC::ConcurrentJITLocker::ConcurrentJITLocker):
- runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
- runtime/JSCellInlines.h:
(JSC::allocateCell):
- runtime/Structure.cpp:
(JSC::Structure::materializePropertyMap):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):
- runtime/Structure.h:
- 12:24 PM Changeset in webkit [157412] by
-
- 3 edits in trunk/Source/WebCore
Remove some silly null checks in Element/NamedNodeMap.
<https://webkit.org/b/122767>
Reviewed by Darin Adler.
Make shouldIgnoreAttributeCase() take a const Element&, exposing
some unnecessary null checks.
- 11:39 AM Changeset in webkit [157411] by
-
- 19 edits3 adds in trunk
Baseline JIT should use the DFG's PutById IC
https://bugs.webkit.org/show_bug.cgi?id=122704
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
Mostly no big deal, just removing the old Baseline JIT's put_by_id IC support and forcing
that JIT to use the DFG's (i.e. JITOperations) PutById IC.
The only complicated part was that the PutById operations assumed that we first did a
cell speculation, which the baseline JIT obviously won't do. So I changed all of those
slow paths to deal with EncodedJSValue's.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetStubInternal):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- jit/JIT.cpp:
(JSC::PropertyStubCompilationInfo::copyToStubInfo):
- jit/JIT.h:
(JSC::PropertyStubCompilationInfo::PropertyStubCompilationInfo):
(JSC::PropertyStubCompilationInfo::slowCaseInfo):
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- jit/JITOperationWrappers.h:
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- jit/Repatch.cpp:
(JSC::appropriateGenericPutByIdFunction):
(JSC::appropriateListBuildingPutByIdFunction):
(JSC::resetPutByID):
LayoutTests:
Reviewed by Mark Hahnenberg.
- js/regress/put-by-id-expected.txt: Added.
- js/regress/put-by-id.html: Added.
- js/regress/script-tests/put-by-id.js: Added.
(foo):
(bar):
- 11:29 AM Changeset in webkit [157410] by
-
- 2 edits in trunk/Source/WebCore
[Win] Build fix after r122737.
- dom/Node.h: Add explicit WebCore namespace to macro definition to work around
Visual Studio bug.
- 11:08 AM Changeset in webkit [157409] by
-
- 7 edits in trunk/Source/JavaScriptCore
FTL should have an inefficient but correct implementation of GetById
https://bugs.webkit.org/show_bug.cgi?id=122740
Reviewed by Mark Hahnenberg.
It took some effort to realize that the node->prediction() check in the DFG backends
are completely unnecessary since the ByteCodeParser will always insert a ForceOSRExit
if !prediction.
But other than that this was an easy patch.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleGetById):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetById):
- 10:55 AM Changeset in webkit [157408] by
-
- 149 edits in trunk/Source/WebCore
Pass Document directly to anonymous renderer constructors.
<https://webkit.org/b/122752>
Reviewed by Antti Koivisto.
Added separate constructors for creating anonymous renderers that
take a Document& instead of a null Element*/Text*.
Removed setDocumentForAnonymous() and all createAnonymous() helpers.
...and RenderObject::m_node is now a Node&, wohoo!
- 10:50 AM Changeset in webkit [157407] by
-
- 7 edits8 moves1 add in trunk/LayoutTests
[CSSRegions] Move style-scoped* tests into fast/regions/style-scoped
https://bugs.webkit.org/show_bug.cgi?id=122741
Reviewed by Darin Adler.
Move files, adjust TestExpectations.
- fast/regions/style-scoped/style-scoped-in-flow-expected.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-expected.html.
- fast/regions/style-scoped/style-scoped-in-flow-override-container-style-expected.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-container-style-expected.html.
- fast/regions/style-scoped/style-scoped-in-flow-override-container-style.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-container-style.html.
- fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-expected.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling-expected.html.
- fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-multiple-regions-expected.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions-expected.html.
- fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-multiple-regions.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions.html.
- fast/regions/style-scoped/style-scoped-in-flow-override-region-styling.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling.html.
- fast/regions/style-scoped/style-scoped-in-flow.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow.html.
- platform/efl/TestExpectations:
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 10:16 AM Changeset in webkit [157406] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][Efl][Soup] Make NetworkProcessMainUnix handle proxy settings.
https://bugs.webkit.org/show_bug.cgi?id=118388
Reviewed by Carlos Garcia Campos.
Original patch by Kwang Yul Seo <skyul@company100.net> .
Proxy configuration should honor the no_proxy environment variable
same to WebProcess. It is necessary not to change the current behaviour.
See https://bugs.webkit.org/show_bug.cgi?id=91747 for details.
The following things were fixed by Csaba Osztrogonác:
- moved session variable before #if not to have conflict with https://bugs.webkit.org/show_bug.cgi?id=118343
- added GRefPtr.h include
- fixed ifdef guards
- NetworkProcess/unix/NetworkProcessMainUnix.cpp:
(WebKit::NetworkProcessMain):
Copied from WebProcessMainEfl.cpp.
- 9:52 AM Changeset in webkit [157405] by
-
- 31 edits in trunk/Source/WebCore
CTTE: Add more node conversion helpers
https://bugs.webkit.org/show_bug.cgi?id=122737
Reviewed by Darin Adler.
- Factor NODE_TYPE_CASTS into TYPE_CASTS_BASE(ToClassName, FromClassName) to allow for DOCUMENT_TYPE_CASTS.
- Replace more static_casts<>.
- 9:42 AM Changeset in webkit [157404] by
-
- 16 edits in trunk/Source/JavaScriptCore
Transition misc cti_op_* JITStubs to JIT operations.
https://bugs.webkit.org/show_bug.cgi?id=122645.
Reviewed by Michael Saboff.
Stubs converted:
cti_op_check_has_instance
cti_op_create_arguments
cti_op_del_by_id
cti_op_instanceof
cti_to_object
cti_op_push_activation
cti_op_get_pnames
cti_op_load_varargs
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- jit/JIT.h:
(JSC::JIT::emitStoreCell):
- jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileLoadVarargs):
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_check_has_instance):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_get_argument_by_val):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emitSlow_op_check_has_instance):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_get_argument_by_val):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_del_by_id):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_del_by_id):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- 8:55 AM Changeset in webkit [157403] by
-
- 9 edits31 adds in trunk/LayoutTests
Unreviewed EFL gardening
Added new baselines for tests marked as skipped.
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- platform/efl/compositing/overflow/nested-scrolling-expected.txt: Added.
- platform/efl/compositing/overflow/remove-overflow-crash2-expected.png: Added.
- platform/efl/compositing/overflow/remove-overflow-crash2-expected.txt: Added.
- platform/efl/editing/spelling/inline-spelling-markers-hidpi-expected.png: Added.
- platform/efl/editing/unsupported-content/list-delete-001-expected.png:
- platform/efl/editing/unsupported-content/list-delete-001-expected.txt: Added.
- platform/efl/editing/unsupported-content/list-delete-003-expected.png:
- platform/efl/editing/unsupported-content/list-delete-003-expected.txt: Added.
- platform/efl/editing/unsupported-content/list-type-after-expected.png:
- platform/efl/editing/unsupported-content/list-type-after-expected.txt: Added.
- platform/efl/editing/unsupported-content/table-delete-002-expected.png:
- platform/efl/editing/unsupported-content/table-delete-002-expected.txt: Added.
- platform/efl/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
- platform/efl/fast/table/click-near-anonymous-table-expected.png: Added.
- platform/efl/fast/table/click-near-anonymous-table-expected.txt: Added.
- platform/efl/fast/text/international/arabic-justify-expected.png: Added.
- platform/efl/fast/text/international/arabic-justify-expected.txt: Added.
- platform/efl/fast/text/international/bidi-linebreak-001-expected.png: Added.
- platform/efl/fast/text/international/bidi-linebreak-001-expected.txt: Added.
- platform/efl/fast/text/international/bidi-linebreak-002-expected.png: Added.
- platform/efl/fast/text/international/bidi-linebreak-002-expected.txt: Added.
- platform/efl/fast/text/international/bidi-linebreak-003-expected.png: Added.
- platform/efl/fast/text/international/bidi-linebreak-003-expected.txt: Added.
- platform/efl/fast/text/unicode-variation-selector-expected.png: Added.
- platform/efl/fast/text/unicode-variation-selector-expected.txt: Added.
- platform/efl/media/video-colorspace-yuv420-expected.png: Added.
- platform/efl/media/video-colorspace-yuv420-expected.txt: Added.
- platform/efl/media/video-colorspace-yuv422-expected.png: Added.
- platform/efl/media/video-colorspace-yuv422-expected.txt: Added.
- platform/efl/svg/as-image/image-respects-deviceScaleFactor-expected.png: Added.
- platform/efl/svg/as-image/image-respects-deviceScaleFactor-expected.txt: Added.
- platform/efl/svg/hixie/data-types/002-expected.png: Added.
- platform/efl/svg/hixie/data-types/002-expected.txt:
- platform/efl/svg/text/non-bmp-positioning-lists-expected.png: Added.
- platform/efl/svg/text/non-bmp-positioning-lists-expected.txt: Added.
- platform/efl/svg/zoom/text/zoom-hixie-mixed-009-expected.png: Added.
- platform/efl/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
- 8:46 AM Changeset in webkit [157402] by
-
- 2 edits in trunk/Source/WTF
Static assertions in WTF::adoptPtr should point to using adoptRef for ref-counted objects
https://bugs.webkit.org/show_bug.cgi?id=122745
Reviewed by Anders Carlsson.
- wtf/PassOwnPtr.h:
(WTF::adoptPtr): When the object's type is convertible to the RefCountedBase or ThreadSafeRefCountedBase type,
the static assertion should note that adoptRef should be used instead.
- 8:45 AM Changeset in webkit [157401] by
-
- 2 edits in trunk/Source/WebCore
Reintroduce PassRefPtr<Event> copy in ScopedEventQueue::dispatchEvent
https://bugs.webkit.org/show_bug.cgi?id=122742
Reviewed by Alexey Proskuryakov.
This is a follow-up to r157219 which introduced a workaround for the GCC's quirky behavior that
was resulting in crashes due to the PassRefPtr<Event> object passed to EventDispatcher::dispatchEvent
being copied and nullified first before retrieving the EventTarget of the Event object wrapped in that
PassRefPtr.
The implementation is now adjusted to first retrieve the pointer to the Event's EventTarget and store
it in a local variable. That variable is then passed as the first parameter to EventDispatcher::dispatchEvent,
and the PassRefPtr<Event> passed directly as the second parameter. Previously the pointer of that PassRefPtr
object was passed in, with a new PassRefPtr being created which would increase the reference count of the
ref-counted object. Passing in the original PassRefPtr avoids the unnecessary reference count increase by creating
a copy. That still nullifies the original PassRefPtr, but that's not a problem anymore.
- dom/ScopedEventQueue.cpp:
(WebCore::ScopedEventQueue::dispatchEvent):
- 8:34 AM Changeset in webkit [157400] by
-
- 4 edits4 adds in trunk
[CSS Shapes] Shape-Margin should be animatable
https://bugs.webkit.org/show_bug.cgi?id=122524
Reviewed by Darin Adler.
Source/WebCore:
Mark content for relayout after shape-margin changes, and add shape-margin
to the list of animatable properties.
Tests: fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-margin.html
fast/shapes/shape-outside-floats/shape-outside-shape-margin-animation.html
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Add
shape-margin to the map of animatable CSS properties.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::updateShapeOutsideInfoAfterStyleChange): Compare shape-margins,
and mark dependent content for relayout if they have changed.
LayoutTests:
Test that shape-margin can be set dynamically and content lays out correctly.
Also test that shape-margin can be manipulated through CSS Animations.
- fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-margin-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-margin.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-shape-margin-animation-expected.txt: Added.
- fast/shapes/shape-outside-floats/shape-outside-shape-margin-animation.html: Added.
- 7:17 AM Changeset in webkit [157399] by
-
- 2 edits in trunk/LayoutTests
[EFL] Accessibility gardening
https://bugs.webkit.org/show_bug.cgi?id=122751
Unreviewed EFL gardening.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-10-14
- platform/efl-wk2/TestExpectations: Add bug numbers and marked missing tests.
- 7:03 AM Changeset in webkit [157398] by
-
- 2 edits in trunk/Source/WebCore
Don't crash after OpenGL robustness reset
https://bugs.webkit.org/show_bug.cgi?id=122750
Patch by Arvid Nilsson <anilsson@blackberry.com> on 2013-10-14
Reviewed by George Staikos.
JIRA 517132.
Just log the incident and pretend like nothing happened.
No new tests, we don't have repeatable steps to reproduce a robustness
reset.
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::makeContextCurrent):
- 6:39 AM Changeset in webkit [157397] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Buildfix after r157393
https://bugs.webkit.org/show_bug.cgi?id=122749
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-10-14
Reviewed by Andreas Kling.
Buildfix with error enumeration value 'CSS_FR' not handled in switch.
- css/CSSCalculationValue.cpp:
(WebCore::hasDoubleValue):
- 6:08 AM Changeset in webkit [157396] by
-
- 3 edits in trunk/Source/WTF
WebKit Nightlies broken by r157374
https://bugs.webkit.org/show_bug.cgi?id=122736
Reviewed by Andreas Kling.
Add back a callOnMainThread overload that Safari is using.
- wtf/MainThread.cpp:
(WTF::callOnMainThread):
- wtf/MainThread.h:
- 5:48 AM Changeset in webkit [157395] by
-
- 2 edits5 adds in trunk/LayoutTests
Unreviewed. EFL Gardening.
Add baselines for new tests which was added by r156767.
- platform/efl/TestExpectations: Remove tests supported by this commit.
- platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
- platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Added.
- platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
- platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
- platform/efl/fast/repaint/region-painting-invalidation-expected.txt: Added.
- 3:41 AM Changeset in webkit [157394] by
-
- 4 edits1 add in trunk
[EFL] Present replaced objects with 0xFFFC character
https://bugs.webkit.org/show_bug.cgi?id=122744
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-10-14
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Replaced elements should be emitted in GTK/EFL and
marked their presence with the replacement character.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::textIteratorBehaviorForTextRange):
LayoutTests:
Added new accessibility expectation after r156532.
- platform/efl-wk2/TestExpectations:
- platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.
- 3:36 AM Changeset in webkit [157393] by
-
- 25 edits9 adds in trunk
[CSS Grid Layout] Implement support for <flex>
https://bugs.webkit.org/show_bug.cgi?id=115362
Reviewed by Andreas Kling.
From Blink r149134, r149480, r149532, r150287 and r156127 by <jchaffraix@chromium.org>
From Blink r157820 by <svillar@igalia.com>
Source/WebCore:
Added support for flexible lengths ('fr' unit) in CSS Grid Layout
code. This requires the addition of GridLength class to
encapsulate the knowledge of <flex> to the grid layout code.
Also updated the algorithm that computes the layout. It increases
the value of 1fr based on the grid tracks' usedBreath to fraction
ratio (called normalizedFractionValue). This enables increasing
the fraction value while updating the available space to account
for processed grid tracks. The algorithm stops when we run out of
grid tracks or available space (one grid item has an intrinsic
size too big). This matches the specs to the letter for the known
available space case (both the unknown case and the interaction
with 'span' are left out of this patch).
Tests: fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html
fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html
fast/css-grid-layout/flex-content-resolution-columns.html
fast/css-grid-layout/flex-content-resolution-rows.html
- GNUmakefile.list.am: Added GridLength.h to the build system.
- Target.pri: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForGridTrackBreadth): Replace Length by GridLength.
- css/CSSGrammar.y.in: Added FR support.
- css/CSSParser.cpp: Ditto.
(WebCore::CSSParser::parseGridBreadth):
(WebCore::CSSParser::detectNumberToken):
- css/CSSParserValues.cpp: Added FR support.
(WebCore::CSSParserValue::createCSSValue):
- css/CSSParserValues.h:
(WebCore::CSSParserString::operator[]):
(WebCore::CSSParserString::equalIgnoringCase):
- css/CSSPrimitiveValue.cpp: Added FR support.
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::customCSSText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore::CSSPrimitiveValue::equals):
- css/CSSPrimitiveValue.h: Added a couple of missing const.
(WebCore::CSSPrimitiveValue::isFlex):
- css/StyleResolver.cpp: Added FR support.
(WebCore::createGridTrackBreadth):
(WebCore::createGridTrackSize):
- rendering/RenderGrid.cpp:
(WebCore::GridTrackForNormalization::GridTrackForNormalization):
New helper struct to ease the computation of track breadths with
flexible lengths.
(WebCore::GridTrackForNormalization::operator=):
(WebCore::RenderGrid::computePreferredTrackWidth): Replaced Length by GridLength.
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks): Grow grid lines
having a fraction as the MaxTrackSizingFunction.
(WebCore::RenderGrid::computeUsedBreadthOfMinLength): Replaced Length by GridLength.
(WebCore::RenderGrid::computeUsedBreadthOfMaxLength): Ditto.
(WebCore::sortByGridNormalizedFlexValue):
(WebCore::RenderGrid::computeNormalizedFractionBreadth): Increase
the fraction value while updating the available space to account
for processed grid tracks.
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::distributeSpaceToTracks): Never shrink track sizes.
(WebCore::RenderGrid::tracksAreWiderThanMinTrackBreadth):
- rendering/RenderGrid.h:
- rendering/style/GridLength.h: Added.
(WebCore::GridLength::GridLength):
(WebCore::GridLength::isLength):
(WebCore::GridLength::isFlex):
(WebCore::GridLength::length):
(WebCore::GridLength::flex):
(WebCore::GridLength::setFlex):
(WebCore::GridLength::operator==):
- rendering/style/GridTrackSize.h: Replaced Length by GridLength.
(WebCore::GridTrackSize::length):
(WebCore::GridTrackSize::setLength):
(WebCore::GridTrackSize::minTrackBreadth):
(WebCore::GridTrackSize::maxTrackBreadth):
(WebCore::GridTrackSize::setMinMax):
(WebCore::GridTrackSize::hasMinOrMaxContentMinTrackBreadth):
(WebCore::GridTrackSize::hasMaxContentMinTrackBreadth):
(WebCore::GridTrackSize::hasMinOrMaxContentMaxTrackBreadth):
(WebCore::GridTrackSize::hasMaxContentMaxTrackBreadth):
LayoutTests:
Added 4 new test cases to test the support for <flex> in CSS Grid
Layout code. Also updated some of the existing ones to check the
support for 'fr' units.
- fast/css-grid-layout/flex-and-minmax-content-resolution-columns-expected.txt: Added.
- fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html: Added.
- fast/css-grid-layout/flex-and-minmax-content-resolution-rows-expected.txt: Added.
- fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html: Added.
- fast/css-grid-layout/flex-content-resolution-columns-expected.txt: Added.
- fast/css-grid-layout/flex-content-resolution-columns.html: Added.
- fast/css-grid-layout/flex-content-resolution-rows-expected.txt: Added.
- fast/css-grid-layout/flex-content-resolution-rows.html: Added.
- fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
- fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
- fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
- fast/css-grid-layout/grid-columns-rows-get-set.html:
- fast/css-grid-layout/grid-dynamic-updates-relayout-expected.txt:
- fast/css-grid-layout/grid-dynamic-updates-relayout.html:
- fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:
- fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
- 3:33 AM Changeset in webkit [157392] by
-
- 3 edits2 adds in trunk
Broken text rendering when input field has selection.
https://bugs.webkit.org/show_bug.cgi?id=122716
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-14
Reviewed by Antti Koivisto.
Source/WebCore:
Tests: fast/text/text-rendering-with-input-selection.html.
fast/text/text-rendering-with-input-selection-expected.html.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint): Check that text has selection.
LayoutTests:
- fast/text/text-rendering-with-input-selection.html: Added.
- fast/text/text-rendering-with-input-selection-expected.html: Added.
- 2:43 AM Changeset in webkit [157391] by
-
- 3 edits2 adds in trunk
Unexpected word wrapping for wrapped content then raw content.
https://bugs.webkit.org/show_bug.cgi?id=121130
Reviewed by Antti Koivisto.
When deciding whether a line is considered empty, we need to check if the current
object is fully responsible for the currently uncommitted width. It helps differentiating
<span></span><span>abcd</span> from <span>a</span><span>bcd</span>, where in the first
case when we hit the second <span> the line is still considered empty, as opposed to the
second example.
Source/WebCore:
Test: fast/css/unexpected-word-wrapping-with-non-empty-spans.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::LineBreaker::nextSegmentBreak):
LayoutTests:
- fast/css/unexpected-word-wrapping-with-non-empty-spans-expected.html: Added.
- fast/css/unexpected-word-wrapping-with-non-empty-spans.html: Added.
- 2:16 AM Changeset in webkit [157390] by
-
- 2 edits in trunk/Source/WebCore
Be more efficient about passing RenderStyle to attachRenderTree().
<https://webkit.org/b/122743>
Reviewed by Antti Koivisto.
Have attachRenderTree() and createRendererTreeIfNeeded() pass the
RenderStyle in a PassRefPtr to avoid churning the ref count.
- 2:00 AM Changeset in webkit [157389] by
-
- 6 edits2 adds in trunk
[CSS Grid Layout] 2 span positions are not resolved correctly
https://bugs.webkit.org/show_bug.cgi?id=119717
Reviewed by Andreas Kling.
From Blink r155397 by <jchaffraix@chromium.org>
Source/WebCore:
Test: fast/css-grid-layout/grid-item-bad-resolution-double-span.html
Two opposite 'span' or 'auto' positions should be resolved using
the auto placement algorithm. We were only checking for the 'auto'
case. This also covers the case of other positions that, according
to the spec, should be treated as 'auto'.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::resolveGridPositionsFromStyle):
LayoutTests:
Added a new test case to check bad grid items resolution with two
opposite span positions. Also added a real grid container to check
also the resolution code path in some other tests.
- fast/css-grid-layout/grid-item-area-get-set.html: Added a grid container.
- fast/css-grid-layout/grid-item-bad-resolution-double-span-expected.txt: Added.
- fast/css-grid-layout/grid-item-bad-resolution-double-span.html: Added.
- fast/css-grid-layout/grid-item-end-after-get-set.html: Added a grid container.
- fast/css-grid-layout/grid-item-start-before-get-set.html: Ditto.
- 12:58 AM Changeset in webkit [157388] by
-
- 9 edits in trunk/Source/WebCore
Use RenderElement instead of RenderObject in more places.
<https://webkit.org/b/122734>
Reviewed by Antti Koivisto.
Convert some sites to use RenderElement (or type inference) instead
of RenderObject for less branchy code.
Oct 13, 2013:
- 10:58 PM Changeset in webkit [157387] by
-
- 18 edits in trunk
Deprecate or remove deleteAllValues functions; there are only a few call sites left
https://bugs.webkit.org/show_bug.cgi?id=122738
Reviewed by Anders Carlsson.
Source/WebCore:
- platform/blackberry/CookieMap.cpp:
(WebCore::CookieMap::deleteAllCookiesAndDomains):
- platform/network/blackberry/rss/RSSParserBase.cpp:
(WebCore::RSSFeed::clear):
- platform/win/WCDataObject.cpp:
(WebCore::WCDataObject::~WCDataObject):
Renamed deleteAllValues to deprecatedDeleteAllValues.
Source/WebKit/blackberry:
- WebKitSupport/InPageSearchManager.cpp:
(BlackBerry::WebKit::InPageSearchManager::cancelPendingScopingEffort):
Renamed deleteAllValues to deprecatedDeleteAllValues.
Source/WebKit2:
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::pluginDestroyed): Renamed deleteAllValues to
deprecatedDeleteAllValues.
Source/WTF:
- wtf/Deque.h: Deleted deleteAllValues.
- wtf/HashMap.h: Ditto.
- wtf/HashSet.h: Ditto.
- wtf/ListHashSet.h: Ditto.
- wtf/Vector.h: Renamed deleteAllValues to deprecatedDeleteAllValues.
Tools:
- DumpRenderTree/win/DRTDataObject.cpp:
(DRTDataObject::~DRTDataObject):
- DumpRenderTree/win/UIDelegate.cpp:
(DRTUndoStack::~DRTUndoStack):
(DRTUndoStack::clear):
Renamed deleteAllValues to deprecatedDeleteAllValues.
- Scripts/do-webcore-rename: Updated to perform this rename, as is traditional.
- 10:02 PM Changeset in webkit [157386] by
-
- 3 edits in trunk/Tools
build.webkit.org/dashboard incorrectly shows interrupted builds as green
https://bugs.webkit.org/show_bug.cgi?id=122732
Reviewed by Tim Hatcher.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.update): Removed a special case for status 4 (EXCEPTION).
I don't see it occur any time in recent history, but judging from what happens for
status 5 (RETRY), we can just finish this function normally.
Record overall text description for iteration as BuildbotIteration.text.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): If an iteration is a failure,
but no tests failed, make it yellow, and use buildbot-provided description for it.
- 5:11 PM Changeset in webkit [157385] by
-
- 104 edits in trunk/Source/WebCore
Merge NODE_TYPE_CASTS and ELEMENT_TYPE_CASTS
https://bugs.webkit.org/show_bug.cgi?id=122735
Reviewed by Antti Koivisto.
NODE_TYPE_CASTS and ELEMENT_TYPE_CASTS are identical. Let them become one
with one another.
- 3:06 PM Changeset in webkit [157384] by
-
- 2 edits in trunk/Source/WebCore
Uncrashify Document::head() too. (Why am I even awake?)
- 2:21 PM Changeset in webkit [157383] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r157381): Make Document::body() crash less when there is no documentElement.
Unreviewed.
- 1:45 PM Changeset in webkit [157382] by
-
- 3 edits in trunk/Source/JavaScriptCore
FTL OSR exit should perform zero extension on values smaller than 64-bit
https://bugs.webkit.org/show_bug.cgi?id=122688
Reviewed by Gavin Barraclough.
In the DFG we usually make the simplistic assumption that a 32-bit value in a 64-bit
register will have zeros on the high bits. In the few cases where the high bits are
non-zero, the DFG sort of tells us this explicitly.
But when working with llvm.webkit.stackmap, it doesn't work that way. Consider we might
emit LLVM IR like:
%2 = trunc i64 %1 to i32
stuff %2
call @llvm.webkit.stackmap(...., %2)
LLVM may never actually emit a truncation instruction of any kind. And that's great - in
many cases it won't be needed, like if 'stuff %2' is a 32-bit op that ignores the high
bits anyway. Hence LLVM may tell us that %2 is in the register that still had the value
from before truncation, and that register may have garbage in the high bits.
This means that on our end, if we want a 32-bit value and we want that value to be
zero-extended, we should zero-extend it ourselves. This is pretty easy and should be
cheap, so we should just do it and not make it a requirement that LLVM does it on its
end.
This makes all tests pass with JSC_ftlOSRExitUsesStackmap=true.
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStubWithOSRExitStackmap):
- ftl/FTLValueFormat.cpp:
(JSC::FTL::reboxAccordingToFormat):
- 12:21 PM Changeset in webkit [157381] by
-
- 3 edits in trunk/Source/WebCore
Rewrite Document::body and Document::head in modern style, way clearer and shorter
https://bugs.webkit.org/show_bug.cgi?id=122717
Reviewed by Andreas Kling.
- dom/Document.cpp:
(WebCore::Document::body): Use iterator to make this way easier to read.
(WebCore::Document::head): Ditto.
- html/HTMLTagNames.in: Added generateTypeHelpers for body and head.
- 12:17 PM Changeset in webkit [157380] by
-
- 5 edits5 copies in trunk
Roll depsHHHHChangeLogs.
- 11:52 AM Changeset in webkit [157379] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk-wk2/TestExpectations:
Add bug number to the failing animation tests.
- 11:39 AM Changeset in webkit [157378] by
-
- 4 edits in trunk/Source/WebCore
RenderLayerBacking should have RenderLayer& backpointer.
<https://webkit.org/b/122731>
Reviewed by Anders Carlsson.
RenderLayerBacking is always owned by a RenderLayer and so should
store its backpointer in a reference.
- 10:26 AM Changeset in webkit [157377] by
-
- 4 edits in trunk/LayoutTests
Removing input-file-entries.html from TestExpectation
https://bugs.webkit.org/show_bug.cgi?id=122674
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-13
Reviewed by Anders Carlsson.
input-file-entries.html has been removed in
changeset 156692. so removing references to this file.
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wk2/TestExpectations:
- 10:10 AM Changeset in webkit [157376] by
-
- 2 edits in trunk/Source/JavaScriptCore
Try to fix the Lion build.
- Configurations/JavaScriptCore.xcconfig:
- 9:15 AM Changeset in webkit [157375] by
-
- 52 edits in trunk/Source/WebCore
Make element predicates and type casts work more consistently on more types
https://bugs.webkit.org/show_bug.cgi?id=122718
Reviewed by Antti Koivisto.
- dom/ContainerNodeAlgorithms.cpp:
(WebCore::assertConnectedSubrameCountIsConsistent):
- dom/ContainerNodeAlgorithms.h:
(WebCore::ChildFrameDisconnector::collectFrameOwners):
Updated for name change.
- dom/Document.cpp:
(WebCore::Document::adoptNode): Use a reference instead of a pointer.
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent): Updated for
typecast name change and also to cast a reference, since we don't overload
for pointers.
(WebCore::Document::updateHoverActiveState): Ditto.
- dom/Element.h: Made the isElementOfType functions take references instead
of pointers. Also use const in the type template argument. These changes go
hand in hand with the changes in the generated code and all the classes.
Also use a bit of nullptr.
- dom/ElementIterator.h:
(WebCore::findElementAncestorOfType): Got rid of the ElementTypeWithConst
naming since this works with or without const. Added const to the call site
for isElementOfType, because it works that way now.
- dom/ElementTraversal.h:
(WebCore::Traversal::firstChildTemplate): Add const to the type when calling
isElementOfType. Along with the corresponding changes, this makes these
templates work for const types.
(WebCore::Traversal::lastChildTemplate): Ditto.
(WebCore::Traversal::firstWithinTemplate): Ditto.
(WebCore::Traversal::lastWithinTemplate): Ditto.
(WebCore::Traversal::nextTemplate): Ditto.
(WebCore::Traversal::previousTemplate): Ditto.
(WebCore::Traversal::nextSiblingTemplate): Ditto.
(WebCore::Traversal::previousSiblingTemplate): Ditto.
(WebCore::Traversal::nextSkippingChildrenTemplate): Ditto.
- dom/Node.cpp:
(WebCore::Node::handleLocalEvents): Check isElementNode and then call the
isDisabledFormControl member function, since we no longer have a helper that
takes a node.
(WebCore::Node::willRespondToMouseMoveEvents): Ditto.
(WebCore::Node::willRespondToMouseClickEvents): Ditto.
(WebCore::Node::willRespondToTouchEvents): Ditto.
- dom/PseudoElement.h: Use some nullptr. Added an isPseudoElement function
that the ELEMENT_TYPE_CASTS macro can use, and also used that macro to make
the toPseudoElement functions instead of a hand-written local variant.
- dom/make_names.pl:
(printTypeHelpers): Added unimplemented versions of the element predicate
functions that return void to catch unnecessary runtime checks of types
that are already known at compile time. Added assertions to the pointer
overloads of the predicates. Maybe later we can delete them. Added const
to the isElementOf template arguments to make these work with both const
and non-const. Put overloads in a consistent order, most specific class
first, then less specific. Changed isElementOfType to take references
rather than pointers.
- editing/Editor.cpp:
(WebCore::Editor::selectionForCommand): Updated to pass a reference.
(WebCore::Editor::setBaseWritingDirection): Ditto.
(WebCore::findFirstMarkable): Ditto.
- html/FormAssociatedElement.h: Tweaked a comment.
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::insertedInto): Updated for name change and to
pass a reference.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::translate): Removed FIXME and const_cast since the
problem is fixed.
(WebCore::HTMLElement::directionality): Use a reference.
- html/HTMLElement.h: Use const in the type of the isElementOfType functions.
Use references for all the arguments, not pointers.
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::refreshElementsIfNeeded): Use documentVersion
instead of docVersion for local variable name. Use elementDescendants instead
of elementTraversal.
(WebCore::HTMLFieldSetElement::length): Use length instead of len for name.
- html/HTMLFormControlElement.h: Put predicates into the standard format and
did them on single lines. Added ELEMENT_TYPE_CASTS so we get standard casts.
- html/HTMLFrameElementBase.h: Ditto.
- html/HTMLFrameOwnerElement.h: Ditto, but changed the name to match the class,
so it's now isHTMLFrameOwnerElement and toHTMLFrameOwnerElement.
- html/HTMLLabelElement.cpp:
(WebCore::nodeAsSupportedLabelableElement): Updated to use references.
- html/HTMLMediaElement.h: Put predicates into the standard format and did
them on single lines. Added ELEMENT_TYPE_CASTS so we get standard casts.
- html/HTMLPlugInElement.h: Ditto. Also marked isPluginElement FINAL.
- html/HTMLPlugInImageElement.h: Ditto.
- html/HTMLTableCellElement.cpp: Removed old hand-written cast functions.
- html/HTMLTableCellElement.h: Did same predicate and ELEMENT_TYPE_CASTS
changes. Also fixed up the ordering of functions in the class.
- html/HTMLTextFormControlElement.cpp:
(WebCore::enclosingTextFormControl): Updated to use references and nullptr.
- html/HTMLTextFormControlElement.h: Did same predicate and ELEMENT_TYPE_CASTS.
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::removedFrom): Call isHTMLMediaElement by its new name.
- html/LabelableElement.h: Did same predicate and ELEMENT_TYPE_CASTS.
- html/track/WebVTTElement.h: Made isWebVTTElement private. Changed the argument
type of setLanguage to const AtomicString& to avoid excess reference count churn.
Did the predicate and type casts thing.
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create): Update for name changes and use references.
- mathml/MathMLElement.h: Did same predicate and ELEMENT_TYPE_CASTS.
- page/FocusController.cpp:
(WebCore::FocusController::findFocusableElementDescendingDownIntoFrameDocument):
(WebCore::FocusController::advanceFocusInDocumentOrder):
- page/PageSerializer.cpp:
(WebCore::SerializerMarkupAccumulator::appendCustomAttributes):
Update for name change.
- platform/Pasteboard.h: Removed unneeded forward declaration.
- rendering/RenderWidget.h: Updated for name change.
- rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::buildPrimitives): Use element iterator
and nullptr.
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler): Update for name changes.
- svg/SVGAnimateElement.cpp:
(WebCore::isSVGAnimateElement): Moved here since we don't want to inline such
a long list of tag names.
- svg/SVGAnimateElement.h: Marked a lot more virtual functions OVERRIDE.
Did predicate and ELEMENT_TYPE_CASTS changes, but did not make the predicate
be inlined.
- svg/SVGElement.h: Did predicate and ELEMENT_TYPE_CASTS changes.
- svg/SVGFilterPrimitiveStandardAttributes.h: Ditto.
- svg/SVGGradientElement.cpp:
(WebCore::isSVGGradientElement): Moved here since we don't want to inline
the two tag names.
- svg/SVGGradientElement.h: Did predicate and ELEMENT_TYPE_CASTS changes.
- svg/SVGGraphicsElement.h: Ditto.
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::SVGImageElement): Took out assertion, since it
was asserting the class of the obejct we just created.
- svg/SVGPolyElement.cpp:
(WebCore::isSVGPolyElement): Moved here since we don't want to inline the
two tag names.
- svg/SVGPolyElement.h: Did predicate and ELEMENT_TYPE_CASTS changes.
- svg/SVGTextContentElement.h: Ditto.
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::connectConditions): Update for name changes,
to use references and nullptr, and to get rid of a non-helpful local.
- svg/animation/SVGSMILElement.h: Added a virtual function to check if a
given SVGElement is an SVGSMILElement so we don't have to check a long list
of tag names instead. Also did the predicate and ELEMENT_TYPE_CASTS changes.
- testing/Internals.cpp:
(WebCore::Internals::visiblePlaceholder): Updated to use references.
- 9:12 AM Changeset in webkit [157374] by
-
- 3 edits in trunk/Source/WTF
Change callOnMainThread to take an std::function
https://bugs.webkit.org/show_bug.cgi?id=122698
Reviewed by Darin Adler.
This will let us pass anything that can be converted to an std::function (including lambdas and
WTF::Function objects) to callOnMainThread.
- wtf/MainThread.cpp:
(WTF::callOnMainThread):
- wtf/MainThread.h:
- 9:00 AM Changeset in webkit [157373] by
-
- 13 edits in trunk/Source/WebCore
Text::renderer() should return RenderText
https://bugs.webkit.org/show_bug.cgi?id=122729
Reviewed by Andreas Kling.
Tighten typing.
- 8:57 AM Changeset in webkit [157372] by
-
- 5 edits in trunk/Source/WebCore
Devirtualize RenderView::viewRect().
<https://webkit.org/b/122730>
Reviewed by Antti Koivisto.
There's no need for viewRect() to be a virtual RenderObject function.
The single call site that didn't already access it through RenderView
can just go via view().
- 8:56 AM Changeset in webkit [157371] by
-
- 6 edits in trunk/Source/WebCore
Move setPseudoStyle() to RenderImage (from RenderElement.)
<https://webkit.org/b/122726>
Reviewed by Antti Koivisto.
Only RenderImages ever use setPseudoStyle() so move it there and
remove the non-image codepath.
- 8:04 AM Changeset in webkit [157370] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderSlider always has an HTMLInputElement.
<https://webkit.org/b/122728>
Reviewed by Anders Carlsson.
This renderer is never anonymous and always has a corresponding
HTMLInputElement. Tighten this up by having the constructor take
the element by reference, and override element() with a stronger
return type.
- 7:46 AM Changeset in webkit [157369] by
-
- 4 edits in trunk/Source/WebCore
Remove two unused AX functions for getting a FrameView*.
<https://webkit.org/b/122724>
Reviewed by Anders Carlsson.
- 6:26 AM Changeset in webkit [157368] by
-
- 5 edits in trunk/Source/WebCore
Add traverseNextSkippingChildren to ElementIterators
https://bugs.webkit.org/show_bug.cgi?id=122727
Reviewed by Andreas Kling.
Also switch some code using ElementTraversal over to iterators.
- 4:39 AM Changeset in webkit [157367] by
-
- 11 edits in trunk/Source/WebCore
Rename InlineBox::remove() to removeFromParent
https://bugs.webkit.org/show_bug.cgi?id=122725
Reviewed by Andreas Kling.
Also make it clear from the code that all InlineTextBoxes have behavesLikeText set.
- 4:05 AM Changeset in webkit [157366] by
-
- 11 edits in trunk/Source/WebCore
Make absoluteQuads/Rects functions return Vectors
https://bugs.webkit.org/show_bug.cgi?id=122722
Reviewed by Andreas Kling.
- dom/Document.cpp:
(WebCore::Document::adjustFloatQuadsForScrollAndAbsoluteZoomAndFrameScale):
(WebCore::Document::adjustFloatRectForScrollAndAbsoluteZoomAndFrameScale):
Take RenderStyle instead of RenderObject
- dom/Document.h:
- dom/Element.cpp:
(WebCore::Element::getClientRects):
(WebCore::Element::getBoundingClientRect):
- dom/Range.cpp:
(WebCore::Range::textRects):
(WebCore::Range::textQuads):
(WebCore::Range::getBorderAndTextQuads):
Adapt to the changes.
- rendering/RenderObject.h:
Removed unnecessary adjustFloatQuad/RectForAbsoluteZoom functions, inline code to
adjustFloatQuads/RectForScrollAndAbsoluteZoomAndFrameScale.
- rendering/RenderText.cpp:
(WebCore::RenderText::absoluteRects):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsClippedToEllipsis):
(WebCore::RenderText::absoluteQuads):
(WebCore::RenderText::absoluteQuadsForRange):
- rendering/RenderText.h:
- rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::absoluteRects):
(WebCore::RenderTextLineBoxes::absoluteRectsForRange):
(WebCore::RenderTextLineBoxes::absoluteQuads):
(WebCore::RenderTextLineBoxes::absoluteQuadsForRange):
- rendering/RenderTextLineBoxes.h:
Use return value instead of an out-arg, except for the virtual versions.
- 4:01 AM Changeset in webkit [157365] by
-
- 6 edits in trunk/Source/WebCore
LiveNodeList: rootNode() and document() should return references.
<https://webkit.org/b/122720>
Reviewed by Antti Koivisto.
Tighten up this code a bit by having rootNode() and document()
return references. Also replaced some handwritten traversal
with a call to Node::lastDescendant().
- 3:59 AM Changeset in webkit [157364] by
-
- 2 edits in trunk/Source/WebCore
Document::createRenderTree() should assert that there is no arena.
<https://webkit.org/b/122723>
Reviewed by Antti Koivisto.
Calling createRenderTree() with a RenderArena already in place would
be a programming error.
- 3:16 AM Changeset in webkit [157363] by
-
- 13 edits5 deletes in trunk/Source
Remove dead ENABLE(CUSTOM_ELEMENTS) code.
<https://webkit.org/b/122721>
Reviewed by Antti Koivisto.
There are no ports building with this flag since April and the code
has bitrotted since. Remove it for now. If someone wants to resurrect
the feature someday, getting back to this point is trivial.
- 2:39 AM Changeset in webkit [157362] by
-
- 10 edits in trunk/Source/WebCore
Move absoluteRects/Quads to RenderTextLineBoxes
https://bugs.webkit.org/show_bug.cgi?id=122706
Reviewed by Andreas Kling.
- rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::absoluteRects):
(WebCore::RenderTextLineBoxes::absoluteRectsForRange):
(WebCore::RenderTextLineBoxes::absoluteQuads):
(WebCore::RenderTextLineBoxes::absoluteQuadsForRange):
These move.
(WebCore::RenderTextLineBoxes::selectionRectForRange):
(WebCore::RenderTextLineBoxes::setSelectionState):
Also moved a few smaller functions.
- 2:02 AM Changeset in webkit [157361] by
-
- 9 edits in trunk/Source
Remove dead code hiding behind ENABLE(TOUCH_EVENT_TRACKING).
<https://webkit.org/b/122719>
Reviewed by Antti Koivisto.
Nobody is building with this flag, and it has broken-looking code
behind it anyway. Nuke from orbit.
- 12:17 AM Changeset in webkit [157360] by
-
- 2 edits in trunk/Source/WebCore
RenderLayer: Check SVG bit instead of element namespace in isTransparent().
<https://webkit.org/b/118171>
Reviewed by Darin Adler.
Replace the (virtual) namespaceURI() check with an isSVGElement() bit check.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::isTransparent):
- 12:08 AM Changeset in webkit [157359] by
-
- 12 edits in trunk/Tools
Remove Chromium specific code from flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=122714
Reviewed by Sam Weinig.
Also removed code related to GPU tests and virtual suites.
"Fallbacks map" was chromium only too, not sure why they needed special handling there.
- TestResultServer/model/jsonresults_unittest.py:
- TestResultServer/static-dashboards/builders.js:
- TestResultServer/static-dashboards/dashboard_base.js:
- TestResultServer/static-dashboards/flakiness_dashboard.html:
- TestResultServer/static-dashboards/flakiness_dashboard.js:
- TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
- TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
- TestResultServer/static-dashboards/history.js:
- TestResultServer/static-dashboards/loader.js:
- TestResultServer/static-dashboards/ui.js:
- TestResultServer/templates/uploadform.html:
Oct 12, 2013:
- 11:55 PM Changeset in webkit [157358] by
-
- 2 edits in trunk/Source/WebCore
Use nullptr in Document.cpp
https://bugs.webkit.org/show_bug.cgi?id=122715
Reviewed by Sam Weinig.
- dom/Document.cpp:
(WebCore::widgetForElement):
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::dropChildren):
(WebCore::Document::getElementByAccessKey):
(WebCore::Document::doctype):
(WebCore::Document::createElement):
(WebCore::Document::createElementNS):
(WebCore::Document::registerElement):
(WebCore::Document::createCDATASection):
(WebCore::Document::createProcessingInstruction):
(WebCore::Document::createEntityReference):
(WebCore::Document::importNode):
(WebCore::Document::adoptNode):
(WebCore::Document::webkitGetNamedFlows):
(WebCore::Document::elementFromPoint):
(WebCore::Document::caretRangeFromPoint):
(WebCore::Document::setTitle):
(WebCore::Document::removeTitle):
(WebCore::Document::view):
(WebCore::Document::page):
(WebCore::Document::settings):
(WebCore::Document::createNodeIterator):
(WebCore::Document::createTreeWalker):
(WebCore::Document::updateStyleIfNeeded):
(WebCore::Document::styleForElementIgnoringPendingStylesheets):
(WebCore::Document::disconnectFromFrame):
(WebCore::Document::destroyRenderTree):
(WebCore::Document::existingAXObjectCache):
(WebCore::Document::axObjectCache):
(WebCore::Document::scriptableDocumentParser):
(WebCore::Document::body):
(WebCore::Document::head):
(WebCore::Document::processBaseElement):
(WebCore::Document::findUnsafeParentScrollPropagationBoundary):
(WebCore::Document::cloneNode):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::removeFocusedNodeOfSubtree):
(WebCore::Document::setFocusedElement):
(WebCore::Document::getWindowAttributeEventListener):
(WebCore::Document::createEvent):
(WebCore::Document::getOverrideStyle):
(WebCore::Document::ownerElement):
(WebCore::Document::setInPageCache):
(WebCore::Document::parentDocument):
(WebCore::Document::createAttributeNS):
(WebCore::Document::initSecurityContext):
(WebCore::Document::resetHiddenFocusElementTimer):
(WebCore::Document::getCSSCanvasContext):
(WebCore::Document::enqueuePopstateEvent):
(WebCore::Document::takeAnyMediaCanStartListener):
(WebCore::Document::requestFullScreenForElement):
(WebCore::Document::webkitExitFullscreen):
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::fullScreenRendererDestroyed):
(WebCore::Document::webkitPointerLockElement):
(WebCore::Document::seamlessParentIFrame):
(WebCore::Document::loader):
(WebCore::eventTargetElementForDocument):
(WebCore::nearestCommonHoverAncestor):
(WebCore::Document::ensureTemplateDocument):
Use nullptr in many places we were using 0.
- 11:54 PM Changeset in webkit [157357] by
-
- 17 edits in trunk/Source
Get rid of the toHTMLElement helper for casting FormAssociatedElement to HTMLElement
https://bugs.webkit.org/show_bug.cgi?id=122713
Reviewed by Sam Weinig.
Source/WebCore:
Since we are using the function name toHTMLElement for casting to an HTMLElement
from a Node or Element, it's awkward to also use it for a quite different type of
type conversion on a FormAssociatedElement. We already have an asHTMLElement member
function, so lets use that.
- html/DOMFormData.cpp:
(WebCore::DOMFormData::DOMFormData): Use references instead of pointers, and
asHTMLElement instead of toHTMLElement.
- html/FormAssociatedElement.cpp: Made FormAttributeTargetObserver FINAL, made
its private inheritance explicit, made its constructor public so we can use it
with make_unique and got rid of its creation function. Also use reference instead
of a pointer.
(WebCore::FormAssociatedElement::FormAssociatedElement): Use nullptr.
(WebCore::FormAssociatedElement::~FormAssociatedElement): Ditto.
(WebCore::FormAssociatedElement::didMoveToNewDocument): Use asHTMLElement instead
of toHTMLElement and use a reference instead of a pointer.
(WebCore::FormAssociatedElement::insertedInto): Ditto.
(WebCore::FormAssociatedElement::removedFrom): Ditto.
(WebCore::FormAssociatedElement::formRemovedFromTree): Ditto.
(WebCore::FormAssociatedElement::resetFormOwner): Ditto.
(WebCore::FormAssociatedElement::formAttributeChanged): Ditto.
(WebCore::FormAssociatedElement::customError): Ditto.
(WebCore::FormAssociatedElement::resetFormAttributeTargetObserver): Use make_unique
instead of create here.
(WebCore::FormAssociatedElement::name): Use asHTMLElement.
(WebCore::FormAttributeTargetObserver::FormAttributeTargetObserver): Ditto.
(WebCore::FormAttributeTargetObserver::idTargetChanged): Updated since m_element is
now a reference.
- html/FormAssociatedElement.h: Removed some unneeded class declarations.
Made isFormAssociatedElement const. Use std::unique_ptr instead of OwnPtr.
- html/FormNamedItem.h: Made asHTMLElement return a reference, and overloaded it
for both const and non-const. Made isFormAssociatedElement const.
- html/HTMLFormControlElement.h: Updated for FormNamedItem changes. Removed an
unneeded class declaration.
- html/HTMLFormControlsCollection.cpp:
(WebCore::HTMLFormControlsCollection::virtualItemAfter): Use references, asHTMLElement,
and nullptr.
(WebCore::firstNamedItem): Ditto.
(WebCore::HTMLFormControlsCollection::namedItem): Ditto.
(WebCore::HTMLFormControlsCollection::updateNameCache): Ditto.
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::validateInteractively): Use asHTMLElement and references.
(WebCore::HTMLFormElement::getTextFieldValues): Ditto.
(WebCore::HTMLFormElement::formElementIndexWithFormAttribute): Ditto.
(WebCore::HTMLFormElement::formElementIndex): Ditto.
(WebCore::HTMLFormElement::assertItemCanBeInPastNamesMap): Ditto.
(WebCore::HTMLFormElement::elementFromPastNamesMap): Ditto, and nullptr.
- html/HTMLImageElement.h: Updated for FormNamedItem changes.
- html/HTMLObjectElement.h: Ditto.
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create): Use asHTMLElement and references.
Source/WebKit/blackberry:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::updateFormState): Use asHTMLElement.
Source/WebKit/mac:
- WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation elementWithName:inForm:]): Use asHTMLElement.
(-[WebHTMLRepresentation controlsInForm:]): Ditto.
Source/WebKit/win:
- WebFrame.cpp:
(WebFrame::controlsInForm): Use asHTMLElement.
- 11:32 PM Changeset in webkit [157356] by
-
- 2 edits in trunk/Source/WebCore
Use nullptr instead of 0 in TreeScope.cpp
https://bugs.webkit.org/show_bug.cgi?id=122711
Reviewed by Andreas Kling.
- dom/TreeScope.cpp:
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::~TreeScope):
(WebCore::TreeScope::clearDocumentScope):
(WebCore::TreeScope::getElementById):
(WebCore::TreeScope::getAllElementsById):
(WebCore::TreeScope::getElementByName):
(WebCore::TreeScope::ancestorInThisScope):
(WebCore::TreeScope::getImageMap):
(WebCore::nodeFromPoint):
(WebCore::TreeScope::labelElementForId):
(WebCore::TreeScope::getSelection):
(WebCore::TreeScope::findAnchor):
(WebCore::focusedFrameOwnerElement):
(WebCore::TreeScope::focusedElement):
(WebCore::commonTreeScope):
Use a lot more nullptr, and also rewrite one while loop as a for loop.
- 11:03 PM Changeset in webkit [157355] by
-
- 3 edits in trunk/Source/WebCore
Remove the not-much-used isShadowHost function from Element.h
https://bugs.webkit.org/show_bug.cgi?id=122710
Reviewed by Andreas Kling.
- dom/Element.h: Removed isShadowHost, which just checks if shadowRoot is null.
- page/FocusController.cpp:
(WebCore::FocusNavigationScope::focusNavigationScopeOwnedByShadowHost): Added
individual assertions instead of just asserting isShadowHost.
(WebCore::FocusNavigationScope::focusNavigationScopeOwnedByIFrame): Broke an
assertion with && in it into two assertions.
(WebCore::hasCustomFocusLogic): Changed argument type to be Element& and take
a reference instead of a pointer.
(WebCore::isNonFocusableShadowHost): Made arguments references instead of pointers.
Replaced isShadowHost check with a direct check of whether shadowRoot returns null
or not, which seems nearly as clear.
(WebCore::isFocusableShadowHost): Ditto.
(WebCore::adjustedTabIndex): Ditto.
(WebCore::shouldVisit): Ditto.
(WebCore::FocusController::findFocusableElementDescendingDownIntoFrameDocument):
Updated for changes above.
(WebCore::FocusController::advanceFocusInDocumentOrder): Ditto. Also some nullptr.
(WebCore::FocusController::findFocusableElementAcrossFocusScope): Ditto.
(WebCore::FocusController::findFocusableElementRecursively): Ditto.
(WebCore::FocusController::findElementWithExactTabIndex): Ditto.
(WebCore::nextElementWithGreaterTabIndex): Ditto.
(WebCore::previousElementWithLowerTabIndex): Ditto.
(WebCore::FocusController::nextFocusableElement): Ditto.
(WebCore::FocusController::previousFocusableElement): Ditto.
- 10:42 PM Changeset in webkit [157354] by
-
- 10 edits in trunk/Source/WebCore
Move querySelector from Node to ContainerNode and use references instead of pointers
https://bugs.webkit.org/show_bug.cgi?id=122709
Reviewed by Anders Carlsson.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::querySelector): Moved here from Node. Pass a reference instead
of a pointer to SelectorQuery. Changed return types to RefPtr and raw pointer instead of
PassRefPtr.
(WebCore::ContainerNode::querySelectorAll): Ditto.
- dom/ContainerNode.h: Added the new functions.
- dom/Element.cpp:
(WebCore::Element::webkitMatchesSelector): Use && instead of an if statement and a reference rather than
a pointer.
- dom/Node.cpp: Sorted includes, removed SelectorQuery.h, removed the querySelector functions.
(WebCore::Node::ownerDocument): Use document instead of doc and nullptr instead of 0.
- dom/Node.h: Removed the querySelector functions.
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::selectorMatches): Take references instead of pointers.
(WebCore::SelectorDataList::matches): Ditto.
(WebCore::SelectorDataList::queryAll): Return a RefPtr instead of PassRefPtr.
(WebCore::SelectorDataList::queryFirst): Ditto. Also use nullptr.
(WebCore::selectorForIdLookup): Take references instead of pointers.
(WebCore::isTreeScopeRoot): Ditto.
(WebCore::SelectorDataList::executeFastPathForIdSelector): Ditto.
(WebCore::isSingleTagNameSelector): Ditto.
(WebCore::elementsForLocalName): Ditto. Also use iterators instead of traversal.
(WebCore::anyElement): Ditto.
(WebCore::SelectorDataList::executeSingleTagNameSelectorData): Ditto.
(WebCore::isSingleClassNameSelector): Ditto.
(WebCore::SelectorDataList::executeSingleClassNameSelectorData): Ditto.
(WebCore::SelectorDataList::executeSingleSelectorData): Ditto.
(WebCore::SelectorDataList::executeSingleMultiSelectorData): Ditto.
(WebCore::SelectorDataList::execute): Ditto.
(WebCore::SelectorQueryCache::add): Ditto.
- dom/SelectorQuery.h: Update to use ContainerNode, references, and RefPtr and raw pointers
rather than PassRefPtr.
- dom/TreeScope.cpp:
(WebCore::TreeScope::getElementById): Use nullptr instead of 0.
(WebCore::TreeScope::getAllElementsById): Ditto.
(WebCore::TreeScope::getElementByName): Ditto.
(WebCore::TreeScope::ancestorInThisScope): Ditto.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::assertNode): Use nullptr instead of 0.
(WebCore::InspectorDOMAgent::assertDocument): Ditto.
(WebCore::InspectorDOMAgent::assertElement): Ditto. Also use isElementNode instead of nodeType.
(WebCore::InspectorDOMAgent::assertEditableNode): Use nullptr instead of 0.
(WebCore::InspectorDOMAgent::assertEditableElement): Ditto.
(WebCore::InspectorDOMAgent::getDocument): Use document instead of doc.
(WebCore::InspectorDOMAgent::querySelector): Changed to pass a ContainerNode.
(WebCore::InspectorDOMAgent::querySelectorAll): Ditto.
- 10:01 PM Changeset in webkit [157353] by
-
- 8 edits in trunk/Source/WebCore
Move code to find elements in slider shadow tree into RangeInputType class, since it creates that tree
https://bugs.webkit.org/show_bug.cgi?id=122708
Reviewed by Anders Carlsson.
- accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySliderThumb::elementRect): Use HTMLInputElement::sliderThumbElement
to find the thumb, rather than using the sliderThumbElementOf function.
- html/InputType.h: Use nullptr instead of 0. Tweak formatting a bit.
- html/RangeInputType.cpp:
(WebCore::RangeInputType::handleMouseDownEvent): Use typedSliderThumbElement function.
(WebCore::RangeInputType::handleTouchEvent): Ditto.
(WebCore::RangeInputType::createShadowSubtree): Fixed assertion to match the code below.
(WebCore::RangeInputType::sliderTrackElement): Moved next to the createShadowSubtree function
since it is finding an element in that subtree. Changed to do the work here instead of calling
a function in another file.
(WebCore::RangeInputType::typedSliderThumbElement): Added. Finds the slider thumb element,
and returns it as a reference with a specific type.
(WebCore::RangeInputType::sliderThumbElement): Changed to call typedSliderThumbElement, loosening
the type, and returning a pointer Changed to call typedSliderThumbElement, loosening
the type, and returning a pointer.
(WebCore::RangeInputType::minOrMaxAttributeChanged): Use typedSliderThumbElement.
(WebCore::RangeInputType::setValue): Ditto.
(WebCore::RangeInputType::listAttributeTargetChanged): Ditto.
- html/RangeInputType.h: Marked the class FINAL. Tweaked formatting a bit.
Added the typedSliderThumbElement function.
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::setPositionFromPoint): Call the HTMLInputElement::sliderTrackElement
function instead of having the input element's shadow subtree hierarchy hard-coded here.
(WebCore::SliderThumbElement::cloneElementWithoutAttributesAndChildren): Moved here from the header,
since it's a virtual function that won't be inlined.
- html/shadow/SliderThumbElement.h: Removed unneeded forward declarations. Made more virtual
functions private and added more OVERRIDE. Removed the toSliderThumbElement, sliderThumbElementOf,
and sliderTrackElementOf functions.
- rendering/RenderSlider.cpp:
(WebCore::RenderSlider::layout): Use HTMLInputElement::sliderThumbElement.
(WebCore::RenderSlider::inDragMode): Ditto.
- 10:00 PM Changeset in webkit [157352] by
-
- 11 edits1 delete in trunk/Source/WebCore
Remove unneeded extra memory allocation and indirection for ValidityState
https://bugs.webkit.org/show_bug.cgi?id=122705
Reviewed by Anders Carlsson.
- CMakeLists.txt: Removed ValidityState.cpp.
- GNUmakefile.list.am: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- html/FormAssociatedElement.cpp: Removed ValidityState.h include and the
FormAssociatedElement::validity function. That function is now an inline
in the ValidityState.h header.
- html/FormAssociatedElement.h: Added badInput function, the only function
from the ValidityState interface that was not already present here. Removed
m_validityState.
- html/HTMLFormControlElement.cpp: Removed include of ValidityState.h.
(WebCore::HTMLFormControlElement::isValidFormControlElement): Use the valid
function directly instead of indirectly through the validity state.
(WebCore::HTMLFormControlElement::setNeedsValidityCheck): Ditto.
- html/ValidityState.cpp: Removed.
- html/ValidityState.h: Removed the body of the ValidityState class and
made it effectively a "typedef" for FormAssociatedElement. It's actually
a derived class that adds no members, which is not quite right but will
work just fine for this.
(WebCore::FormAssociatedElement::validity): Implemented; just returns the
FormAssociatedElement, which the bindings expose as a ValidityState.
- html/ValidityState.idl: Use SkipVTableValidation instead of
ImplementationLacksVTable because FormAssociatedElement does have a vtable.
- 9:05 PM Changeset in webkit [157351] by
-
- 2 edits in trunk/Source/WebKit/mac
WebViews inside OS X screen savers have large caches, but should not
https://bugs.webkit.org/show_bug.cgi?id=122604
We use WebCacheModelDocumentViewer by default for apps linked against
modern WebKit, and WebCacheModelDocumentBrowser for apps linked
against legacy WebKit. ScreenSaverEngine.app doesn't link against
WebKit at all, and thus falls into the legacy case by accident because
NSVersionOfLinkTimeLibrary("WebKit") returns -1.
But WebViews inside screen savers are almost certainly not being used
as browsers, so this large-ish cache specified by
WebCacheModelDocumentBrowser is wasteful. This is likely true for all
apps that don't directly link against WebKit, so now we use
WebCacheModelDocumentViewer by default for those apps.
Reviewed by Darin Adler.
- WebView/WebPreferences.mm:
(cacheModelForMainBundle): Use WebCacheModelDocumentViewer by default
for apps that don't link against WebKit directly. Also converted to
use @autoreleasepool {} and early returns while I was in here.
- 6:18 PM Changeset in webkit [157350] by
-
- 10 edits in trunk/Source/WebCore
Rename toParentMediaElement to parentMediaElement, since it's not a type cast
https://bugs.webkit.org/show_bug.cgi?id=122707
Reviewed by Eric Carlson.
- accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControlsContainer::controllingVideoElement): Call the
function by its new name, and also remove unnecessary type casting.
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::parentMediaElement): Renamed from toParentMediaElement. Changed to use
nullptr. Removed an unnecessary null check.
- html/shadow/MediaControlElementTypes.h: Renamed from toParentMediaElement.
Changed the argument to the RenderObject overload to be a reference rather than
a pointer since it doesn't handle null.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler):
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay):
(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu):
(WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired):
(WebCore::MediaControlTextTrackContainerElement::clearTextTrackRepresentation):
(WebCore::MediaControlTextTrackContainerElement::updateSizes):
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
Updated to use the new name. Also use nullptr.
- html/shadow/MediaControlsBlackBerry.cpp:
(WebCore::MediaControlFullscreenFullscreenButtonElement::defaultEventHandler):
Updated to use the new name.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::determineFullScreenMultiplier):
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
(WebCore::RenderThemeBlackBerry::paintMediaPlayButton):
(WebCore::RenderThemeBlackBerry::paintMediaRewindButton):
(WebCore::RenderThemeBlackBerry::paintMediaMuteButton):
(WebCore::RenderThemeBlackBerry::paintMediaFullscreenButton):
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderTrack):
Updated to use the new name.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintMediaSliderTrack):
Updated to use the new name.
- platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::paintMediaSliderTrack):
(WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack):
Updated to use the new name.
- rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::paintMediaControlsPart):
Call the function by its new name and with a reference instead of a pointer.
- 3:33 PM Changeset in webkit [157349] by
-
- 6 edits in trunk/Source/WebCore
Move positionForPoint to RenderTextLineBoxes
https://bugs.webkit.org/show_bug.cgi?id=122703
Reviewed by Andreas Kling.
- 3:23 PM Changeset in webkit [157348] by
-
- 4 edits in trunk/Source/WebCore
Remove unused ScrollingCoordinator hooks.
<https://webkit.org/b/122701>
Reviewed by Anders Carlsson.
Remove leftover ScrollingCoordinator hooks that were only used
by the Chromium port.
- 2:14 PM Changeset in webkit [157347] by
-
- 2 edits in trunk/Source/WebCore
[Soup] The NeverDestroyed<std::unique_ptr<NetworkStorageSession>> variable in defaultSession() should be static
https://bugs.webkit.org/show_bug.cgi?id=122700
Reviewed by Anders Carlsson.
- platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::defaultSession): The NeverDestroyed variable should be static to avoid its reinitialization every time
the function is called. This was exposed by r157337 and should fix the subsequent crashes.
- 1:33 PM Changeset in webkit [157346] by
-
- 4 edits in trunk/Source/WebCore
Move line dirtying code to RenderTextLineBoxes
https://bugs.webkit.org/show_bug.cgi?id=122699
Reviewed by Andreas Kling.
- rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::removeAllFromParent):
Also moved the removal loop.
(WebCore::RenderTextLineBoxes::dirtyAll):
(WebCore::RenderTextLineBoxes::dirtyRange):
- 11:40 AM Changeset in webkit [157345] by
-
- 5 edits in trunk/Source/WebCore
Move more code to RenderTextLineBoxes
https://bugs.webkit.org/show_bug.cgi?id=122697
Reviewed by Andreas Kling.
- rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::boundingBox):
(WebCore::RenderTextLineBoxes::visualOverflowBoundingBox):
(WebCore::RenderTextLineBoxes::hasRenderedText):
(WebCore::RenderTextLineBoxes::caretMinOffset):
(WebCore::RenderTextLineBoxes::caretMaxOffset):
Moved these.
- 11:34 AM Changeset in webkit [157344] by
-
- 8 edits in trunk/Source
Add a feature define for SubtleCrypto
https://bugs.webkit.org/show_bug.cgi?id=122683
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 11:26 AM Changeset in webkit [157343] by
-
- 3 edits in trunk/Source/WebCore
Generate tighter isFooElement() functions for HTML elements.
<https://webkit.org/b/122696>
Reviewed by Antti Koivisto.
Specialize HTML element type checking helpers to only compare the
localName and not the fully qualified tag name.
- 11:16 AM Changeset in webkit [157342] by
-
- 27 edits in trunk/Source
Replace static cast ASSERTs with ASSERT_WITH_SECURITY_IMPLICATION
https://bugs.webkit.org/show_bug.cgi?id=120803
Patch by Jessica Pease <jessica_n_pease@apple.com> on 2013-09-27
Reviewed by Andreas Kling.
No new tests because we're just changing assertions.
Source/WebCore:
- accessibility/AccessibilityMockObject.h:
(WebCore::toAccessibilityMockObject):
- bindings/js/JSCanvasRenderingContextCustom.cpp:
(WebCore::toJS):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyTextUnderlinePosition::applyValue):
- dom/Element.cpp:
(WebCore::Element::elementRareData):
(WebCore::Element::synchronizeAttribute):
- dom/FocusEvent.h:
(WebCore::toFocusEvent):
- dom/MouseEvent.h:
(WebCore::toMouseEvent):
- dom/Node.cpp:
(WebCore::Node::rareData):
- dom/StyledElement.cpp:
(WebCore::StyledElement::ensureMutableInlineStyle):
- dom/TouchEvent.h:
(WebCore::toTouchEvent):
- editing/CompositeEditCommand.h:
(WebCore::toCompositeEditCommand):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk):
- html/track/AudioTrack.h:
(WebCore::toAudioTrack):
- html/track/TextTrack.h:
(WebCore::toTextTrack):
- html/track/VideoTrack.h:
(WebCore::toVideoTrack):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):
- loader/cache/CachedResourceClientWalker.h:
(WebCore::CachedResourceClientWalker::next):
- page/FrameView.h:
(WebCore::toFrameView):
- rendering/InlineBox.cpp:
(WebCore::InlineBox::root):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::createLineBoxesFromBidiRuns):
- rendering/svg/SVGPathData.cpp:
(WebCore::updatePathFromEllipseElement):
(WebCore::updatePathFromLineElement):
(WebCore::updatePathFromPolygonElement):
(WebCore::updatePathFromPolylineElement):
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::document):
Source/WebKit2:
- Shared/Plugins/NPObjectProxy.h:
(WebKit::NPObjectProxy::toNPObjectProxy):
- WebProcess/Plugins/Netscape/NPJSObject.h:
(WebKit::NPJSObject::toNPJSObject):
- 11:03 AM Changeset in webkit [157341] by
-
- 27 edits in trunk/Source
Replace bounds checking ASSERTs with ASSERT_WITH_SECURITY_IMPLICATION
https://bugs.webkit.org/show_bug.cgi?id=120893
Patch by Jessica Pease <jessica_n_pease@apple.com> on 2013-09-06
Reviewed by Darin Adler.
Source/WebCore:
- Modules/indexeddb/IDBKeyPath.cpp:
(WebCore::IDBKeyPathLexer::lex):
- Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::cssPropertyIDForJSCSSPropertyName):
- css/CSSFontSelector.cpp:
(WebCore::compareFontFaces):
- css/CSSParser.cpp:
(WebCore::CSSParser::rewriteSpecifiers):
- html/HTMLCollection.cpp:
(WebCore::traverseMatchingElementsForwardToOffset):
(WebCore::LiveNodeListBase::traverseChildNodeListForwardToOffset):
(WebCore::HTMLCollection::traverseForwardToOffset):
- html/HTMLFontElement.cpp:
(WebCore::parseFontSize):
- html/parser/HTMLParserIdioms.cpp:
(WebCore::parseHTMLIntegerInternal):
(WebCore::parseHTMLNonNegativeIntegerInternal):
- inspector/InspectorStyleSheet.h:
(WebCore::InspectorStyleProperty::setRawTextFromStyleDeclaration):
- platform/graphics/StringTruncator.cpp:
(WebCore::centerTruncateToBuffer):
(WebCore::rightTruncateToBuffer):
(WebCore::truncateString):
- platform/graphics/TextRun.h:
(WebCore::TextRun::subRun):
- platform/text/BidiRunList.h:
(WebCore::::reverseRuns):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::selectionRectForTextFragment):
(WebCore::SVGInlineTextBox::mapStartEndPositionsIntoFragmentCoordinates):
- rendering/svg/SVGTextChunkBuilder.cpp:
(WebCore::SVGTextChunkBuilder::buildTextChunks):
- rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::currentLogicalCharacterMetrics):
- rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::mapStartEndPositionsIntoFragmentCoordinates):
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
- svg/SVGPathByteStreamSource.h:
(WebCore::SVGPathByteStreamSource::readType):
Source/WebKit2:
- Shared/Plugins/PluginQuirks.h:
(WebKit::PluginQuirks::add):
Source/WTF:
- wtf/BumpPointerAllocator.h:
(WTF::BumpPointerPool::ensureCapacity):
(WTF::BumpPointerPool::alloc):
(WTF::BumpPointerPool::ensureCapacityCrossPool):
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- wtf/StringPrintStream.cpp:
(WTF::StringPrintStream::increaseSize):
- wtf/dtoa/utils.h:
(WTF::double_conversion::BufferReference::SubBufferReference):
- wtf/text/WTFString.cpp:
(WTF::String::fromUTF8):
- 10:41 AM Changeset in webkit [157340] by
-
- 9 edits2 adds in trunk/Source/WebCore
Factor line box code from RenderText to a class
https://bugs.webkit.org/show_bug.cgi?id=122694
Reviewed by Andreas Kling.
Create RenderTextLineBoxes and move some line box specific code there.
- 8:15 AM Changeset in webkit [157339] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix potential register trampling in JIT since r157313.
https://bugs.webkit.org/show_bug.cgi?id=122691
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-12
Reviewed by Michael Saboff.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- 7:51 AM Changeset in webkit [157338] by
-
- 5 edits in trunk/Source/WebCore
Replace RenderText::renderedTextLength with hasRenderedText
https://bugs.webkit.org/show_bug.cgi?id=122693
Reviewed by Andreas Kling.
- 7:15 AM Changeset in webkit [157337] by
-
- 37 edits in trunk/Source
Use unique_ptr instead of delete in a few places
https://bugs.webkit.org/show_bug.cgi?id=122639
Reviewed by Anders Carlsson.
Source/WebCore:
- Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::guidToDatabaseMap): Use NeverDestroyed instead of DEFINE_STATIC_LOCAL.
(WebCore::guidForOriginAndName): Ditto.
(WebCore::DatabaseBackendBase::DatabaseBackendBase): Removed unneeded initialization
of m_guid, which is set in the body of the constructor explicitly anyway. Use emptyString.
Use unique_ptr for the values in the map. Use the add idiom instead of the get/set idiom.
(WebCore::DatabaseBackendBase::closeDatabase): Use the find/remove idiom instead of the
get/remove idiom.
(WebCore::DatabaseBackendBase::performOpenAndVerify): Use auto here to avoid having to
use the map type by name.
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::CachedFont): Don't initialize m_fontData to 0; unique_ptr will do that.
(WebCore::CachedFont::~CachedFont): Don't delete m_fontData. unique_ptr will do that.
(WebCore::CachedFont::ensureCustomFontData): Add a get.
(WebCore::CachedFont::allClientsRemoved): Don't delete m_fontData. Use nullptr instead of 0.
- loader/cache/CachedFont.h: Changed m_fontData to a unique_ptr.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage): Don't initialize m_frameTimer to 0; unique_ptr will do that.
(WebCore::BitmapImage::startAnimation): Use make_unique to create the timer.
(WebCore::BitmapImage::stopAnimation): Don't delete m_frameTimer. Use nullptr instead of 0.
- platform/graphics/BitmapImage.h: Changed m_FrameTimer to a unique_ptr.
- platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::BitmapImage::BitmapImage): Don't initialize m_frameTimer to 0; unique_ptr will do that.
- platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData): Don't call CGFontRelease on m_cgFont.
(WebCore::FontCustomPlatformData::fontPlatformData): Use get on m_cgFont.
(WebCore::createFontCustomPlatformData): Use nullptr instead of 0, and make_unique instead of new.
- platform/graphics/mac/FontCustomPlatformData.h: Chnaged m_cgFont to be a RetainPtr, and the
return value from createFontCustomPlatformData to be a unique_ptr.
- platform/graphics/blackberry/FontCustomPlatformData.h:
- platform/graphics/blackberry/FontCustomPlatformDataBlackBerry.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::BitmapImage):
- platform/graphics/cairo/FontCustomPlatformData.h:
- platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::BitmapImage::BitmapImage):
- platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/win/FontCustomPlatformData.h:
- platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/wince/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/wince/FontCustomPlatformData.h:
Same thing on all the other platforms.
- platform/network/NetworkStorageSession.h: Changed return value of createPrivateBrowsingSession
to a unique_ptr, and made constructors public.
- platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::createPrivateBrowsingSession): Use make_unique.
- platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::defaultSession):
(WebCore::NetworkStorageSession::defaultStorageSession):
(WebCore::NetworkStorageSession::createPrivateBrowsingSession):
(WebCore::NetworkStorageSession::switchToNewTestingSession):
Same thing on all the other platforms.
Source/WebKit/mac:
- History/WebHistory.mm:
(-[WebHistoryPrivate init]): Use make_unique.
(-[WebHistoryPrivate dealloc]): Don't delete.
(-[WebHistoryPrivate finalize]): Don't delete.
(-[WebHistoryPrivate data]): Use get.
- WebCoreSupport/WebFrameNetworkingContext.mm:
(privateSession): Use NeverDestroyed here instead of a raw pointer.
(WebFrameNetworkingContext::ensurePrivateBrowsingSession): Use the
new function instead of direct global variable access.
(WebFrameNetworkingContext::destroyPrivateBrowsingSession): Ditto.
(WebFrameNetworkingContext::storageSession): Ditto.
- WebView/WebFrame.mm:
(-[WebFramePrivate dealloc]): Don't delete.
(-[WebFramePrivate finalize]): Don't delete.
(-[WebFrame _attachScriptDebugger]): Use make_unique.
(-[WebFrame _detachScriptDebugger]): Don't delete.
- WebView/WebFrameInternal.h: Use unique_ptr.
Source/WebKit/win:
- WebCoreSupport/WebFrameNetworkingContext.cpp:
(privateSession):
(identifierBase):
(WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebFrameNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebFrameNetworkingContext::storageSession):
Source/WebKit2:
- NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::privateBrowsingStorageSession): Use NeverDestroyed and unique_ptr.
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession): Use std::move.
- Shared/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload): Use std::move. Also add instead of set.
(WebKit::DownloadManager::convertHandleToDownload): Ditto.
(WebKit::DownloadManager::downloadFinished): Don't delete.
- Shared/Downloads/DownloadManager.h: Changed m_downloads to hold unique_ptr instead
of raw pointers.
- Shared/SandboxExtension.h: Use std::unique_ptr for m_data.
- Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtension::HandleArray::HandleArray): Don't initialize m_data to 0.
(WebKit::SandboxExtension::HandleArray::~HandleArray): Don't delete m_data.
(WebKit::SandboxExtension::HandleArray::allocate): Use make_unique to allocate m_data.
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::privateSession): Use NeverDestroyed and unique_ptr.
(WebKit::identifierBase): Use NeverDestroyed.
(WebKit::WebFrameNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
Updated to use the above.
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession): Ditto.
(WebKit::WebFrameNetworkingContext::destroyPrivateBrowsingSession): Ditto.
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts): Ditto.
(WebKit::WebFrameNetworkingContext::storageSession): Ditto.
- WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
(WebKit::privateSession):
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):
(WebKit::WebFrameNetworkingContext::webFrameLoaderClient):
More of the same.
- 3:06 AM Changeset in webkit [157336] by
-
- 5 edits in trunk/Source/WebCore
Make LayoutState not arena-allocated.
<https://webkit.org/b/122649>
Reviewed by Antti Koivisto.
Let RenderView own a singly-linked chain of LayoutState objects
managed by unique_ptr.
- 2:25 AM Changeset in webkit [157335] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] Add missing spaces in JITStubsSH4.h
https://bugs.webkit.org/show_bug.cgi?id=122690
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-12
Reviewed by Andreas Kling.
- jit/JITStubsSH4.h: Space between string concatenation is mandatory with C++11
- 2:19 AM Changeset in webkit [157334] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] Add missing test32 implementation in macro assembler.
https://bugs.webkit.org/show_bug.cgi?id=122689
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-12
Reviewed by Andreas Kling.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::test32):
- 2:15 AM Changeset in webkit [157333] by
-
- 6 edits in trunk/Source/WebCore
Make RenderLayer not arena-allocated.
<https://webkit.org/b/87523>
Reviewed by Antti Koivisto.
Let RenderLayerModelObject store its RenderLayer in a unique_ptr.
Layers are relatively low-volume objects and this looks neutral
on our performance tests.
Re-landing this since the original commit exposed a problem with
the destruction order. This pattern:
m_someRenderer->destroy();
m_someRenderer = nullptr;
..is different from what we get with unique_ptr, which clears
the pointer storage before calling the destructor.
I believe that the new order is strictly better as it removes
one path to accessing an object that is undergoing destruction.
The exposed bug was in RLC::fixedRootBackgroundLayerChanged()
where we were dereferencing the RenderView's layer() without
checking, despite it being called below ~RenderLayer.
